gdb/ChangeLog

   1 2019-09-03  Tom Tromey  <tromey@adacore.com>
   2
   3         * ada-valprint.c (ada_val_print_num): Don't recurse for range
   4         types.
   5         (has_negatives): Unbias a range type bound.
   6         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
   7         * gdbtypes.c (operator==): Handle new field.
   8         (create_range_type): Add "bias" parameter.
   9         (create_static_range_type, resolve_dynamic_range): Update.
  10         * gdbtypes.h (struct range_bounds) <bias>: New member.
  11         (create_range_type): Add bias parameter.
  12         * printcmd.c (print_scalar_formatted): Unbias range types.
  13         * value.c (unpack_long): Unbias range types.
  14         (pack_long): Bias range types.
  15
  16 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
  17
  18         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
  19         probe arguments.
  20
  21 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
  22
  23         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
  24         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
  25         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
  26         (compile_probe_arg): Likewise.
  27         * probe.h (get_argument_count): Likewise.
  28         * solib-svr4.c (solib_event_probe_action): Likewise.
  29         * stap-probe.c (stap_probe::get_argument_count): Likewise.
  30
  31 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
  32
  33         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
  34         code to here...
  35         (svr4_create_solib_event_breakpoints): ...from here.
  36
  37 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
  38
  39         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
  40         suffix from warning message.
  41
  42 2019-08-30  Tom Tromey  <tom@tromey.com>
  43
  44         * tui/tui-winsource.h (struct tui_source_window_base)
  45         <refresh_all>: Don't declare.
  46         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
  47         Remove.
  48         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
  49         tui_show_locator_content.
  50         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
  51         declare.
  52         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
  53         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
  54         declare.
  55
  56 2019-08-30  Tom Tromey  <tom@tromey.com>
  57
  58         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
  59
  60 2019-08-30  Tom Tromey  <tom@tromey.com>
  61
  62         * tui/tui-stack.c (_initialize_tui_stack): Move later.
  63         Remove unnecessary forward declarations.
  64
  65 2019-08-30  Tom Tromey  <tom@tromey.com>
  66
  67         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
  68         rerender.
  69         (tui_update_locator_fullname, tui_show_frame_info): Don't call
  70         tui_show_locator_content.
  71
  72 2019-08-30  Tom Tromey  <tom@tromey.com>
  73
  74         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
  75         (tui_locator_window::rerender): Rewrite using body of previous
  76         tui_show_locator_content.
  77
  78 2019-08-30  Tom Tromey  <tom@tromey.com>
  79
  80         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
  81         set_locator_fullname>: New methods.
  82         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
  83         Rename from tui_set_locator_fullname.
  84         (tui_locator_window::set_locator_info): Rename from
  85         tui_set_locator_info.  Return bool.
  86         (tui_update_locator_fullname, tui_show_frame_info): Update.
  87
  88 2019-08-30  Tom Tromey  <tom@tromey.com>
  89
  90         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
  91
  92 2019-08-30  Tom Tromey  <tom@tromey.com>
  93
  94         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
  95         call touchwin.
  96
  97 2019-08-30  Tom Tromey  <tom@tromey.com>
  98
  99         * tui/tui-wingeneral.c (box_win): Assume win_info and
 100         win_info->handle cannot be NULL.
 101
 102 2019-08-30  Tom Tromey  <tom@tromey.com>
 103
 104         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
 105         refresh_window>: Declare.
 106         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
 107         resize.
 108         (tui_data_item_window::rerender): Rename from
 109         tui_display_register.
 110         (tui_data_item_window::refresh_window): New method.
 111         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
 112         no-op.
 113
 114 2019-08-30  Tom Tromey  <tom@tromey.com>
 115
 116         * tui/tui-regs.h (struct tui_data_window) <regs_content,
 117         regs_column_count, current_group>: Move later.  Now private.
 118         <get_current_group>: New method.
 119         * tui/tui-regs.c (tui_reg_command): Update.
 120         * tui/tui-layout.c (tui_set_layout): Update.
 121
 122 2019-08-30  Tom Tromey  <tom@tromey.com>
 123
 124         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 125         (tui_data_window::rerender): Don't call
 126         check_and_display_highlight_if_needed.
 127         (tui_data_window::refresh_all): Remove call to
 128         erase_data_content.
 129
 130 2019-08-30  Tom Tromey  <tom@tromey.com>
 131
 132         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 133         (tui_data_window::display_registers_from)
 134         (tui_data_window::display_reg_element_at_line)
 135         (tui_data_window::display_registers_from_line): Remove checks of
 136         "empty".
 137
 138 2019-08-30  Tom Tromey  <tom@tromey.com>
 139
 140         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
 141         Don't declare.
 142         * tui/tui-regs.c (tui_data_window::show_registers): Call
 143         rerender.
 144         (tui_data_window::rerender): Rename from display_all_data.
 145         (tui_data_window::rerender): Remove old implementation.
 146
 147 2019-08-30  Tom Tromey  <tom@tromey.com>
 148
 149         * tui/tui-regs.c (tui_data_window::display_all_data): Change
 150         text.
 151         * tui/tui-data.h (NO_DATA_STRING): Remove define.
 152
 153 2019-08-29  Bernhard Wodok  <barto@gmx.net>
 154             Sergio Durigan Junior  <sergiodj@redhat.com>
 155
 156         PR win32/24284
 157         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
 158
 159 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 160
 161         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
 162         when searching for types.
 163
 164 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 165
 166         * f-lang.c (f_language_defn): Use f_print_typedef.
 167         * f-lang.h (f_print_typedef): Declare.
 168         * f-typeprint.c (f_print_typedef): Define.
 169
 170 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
 171
 172         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
 173
 174 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 175
 176         * cli/cli-utils.c (info_print_options_defs): Delete.
 177         (make_info_print_options_def_group): Delete.
 178         (extract_info_print_options): Delete.
 179         (info_print_command_completer): Delete.
 180         (info_print_args_help): Add extra parameter, and optionally
 181         include text about -n flag.
 182         * cli/cli-utils.h (struct info_print_options): Delete.
 183         (extract_info_print_options): Delete declaration.
 184         (info_print_command_completer): Delete declaration.
 185         (info_print_args_help): Add extra parameter, extend header
 186         comment.
 187         * python/python.c (gdbpy_rbreak): Pass additional parameter to
 188         search_symbols.
 189         * stack.c (struct info_print_options): New type.
 190         (info_print_options_defs): New file scoped variable.
 191         (make_info_print_options_def_group): New static function.
 192         (info_print_command_completer): New static function.
 193         (info_locals_command): Update to use new local functions.
 194         (info_args_command): Likewise.
 195         (_initialize_stack): Add extra parameter to calls to
 196         info_print_args_help.
 197         * symtab.c (search_symbols): Add extra parameter, use this to
 198         possibly excluse non-debug symbols.
 199         (symtab_symbol_info): Add extra parameter, which is passed on to
 200         search_symbols.
 201         (struct info_print_options): New type.
 202         (info_print_options_defs): New file scoped variable.
 203         (make_info_print_options_def_group): New static function.
 204         (info_print_command_completer): New static function.
 205         (info_variables_command): Update to use local functions, and pass
 206         extra parameter through to symtab_symbol_info.
 207         (info_functions_command): Likewise.
 208         (info_types_command): Pass additional argument through to
 209         symtab_symbol_info.
 210         (rbreak_command): Pass extra argument to search_symbols.
 211         (_initialize_symtab): Add extra arguments for calls to
 212         info_print_args_help, and update help text for 'info variables',
 213         'whereis', and 'info functions' commands.
 214         * symtab.h (search_symbols): Add extra argument to declaration.
 215         * NEWS: Mention new flags.
 216
 217 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
 218
 219         * symtab.c (lookup_static_symbol): Call the new function (and move
 220         it down to be next to lookup_global_symbol).
 221         (struct global_sym_lookup_data): Add block_enum member and rename to...
 222         (struct global_or_static_sym_lookup_data): ...this.
 223         (lookup_symbol_global_iterator_cb): Pass block_index instead of
 224         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
 225         (lookup_symbol_global_or_static_iterator_cb): ...this.
 226         (lookup_global_or_static_symbol): New function.
 227         (lookup_global_symbol): Call new function.
 228
 229 2019-08-26  Tom de Vries  <tdevries@suse.de>
 230
 231         PR c++/24852
 232         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
 233         when pc_probe.prob == NULL.
 234
 235 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 236
 237         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
 238         variable symbol_linkage to symbol_linkage_.
 239
 240 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 241
 242         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
 243         represent whether the symbol is static, dynamic, or we don't
 244         know.
 245
 246 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
 247
 248         * gdb/rx-tdep.c (rx_register_names): New.
 249         (rx_register_name): Delete.
 250         (rx_psw_type): Delete.
 251         (rx_fpsw_type): Delete.
 252         (rx_register_type): Delete.
 253         (rx_gdbarch_init): Convert target-descriptions.
 254         (_initialize_rx_tdep): Add initialize_tdesc_rx.
 255         * gdb/features/Makefile: Add rx.xml.
 256         * gdb/features/rx.xml: New.
 257         * gdb/features/rx.c: Generated.
 258         * gdb/NEWS: Mention target description support.
 259
 260 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 261
 262         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
 263         *slot_ptr.
 264
 265 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 266
 267         * configure.ac: Don't check for 'dlfcn.h' (moved to
 268         gdbsupport/common.m4).
 269         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
 270         'gdbsupport/'.
 271         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
 272         * compile/compile-c-support.c: Include
 273         'gdbsupport/gdb-dlfcn.h'.
 274         * gdbsupport/common.m4: Check for 'dlfcn.h'.
 275         * gdb-dlfcn.c: Move to...
 276         * gdbsupport/gdb-dlfcn.c: ... here.
 277         * gdb-dlfcn.h: Move to...
 278         * gdbsupport/gdb-dlfcn.h: ... here.
 279
 280 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
 281
 282         * nios2-tdep.c (struct reg_value): Improve comments.  Make
 283         the offset field signed.
 284
 285 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 286
 287         * python/lib/gdb/__init__.py (_execute_file): New function.
 288         * python/python.c (python_run_simple_file): Call gdb._execute_file
 289         on Windows.
 290
 291 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 292
 293         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
 294         all uses as this was never set to anything but a zero value.
 295
 296 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
 297
 298         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
 299
 300 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
 301
 302         * tui/tui-data.h (tui_gen_win_info): Add an =default
 303         move constructor, required by some GCC versions.
 304
 305 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
 306
 307         * go32-nat.c (go32_sysinfo): Add hygon_p.
 308
 309 2019-08-20  Tom Tromey  <tom@tromey.com>
 310
 311         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
 312         line_from_reg_element_no, first_reg_element_no_inline,
 313         display_all_data, delete_data_content_windows,
 314         erase_data_content>: Now private.
 315
 316 2019-08-20  Tom Tromey  <tom@tromey.com>
 317
 318         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
 319         (tui_unhighlight_win, tui_highlight_win)
 320         (tui_win_info::make_window): Update.
 321         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
 322
 323 2019-08-20  Tom Tromey  <tom@tromey.com>
 324
 325         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 326         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 327         (MAX_PID_WIDTH): Move to tui-stack.c.
 328         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 329         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 330         (MAX_PID_WIDTH): Move from tui-data.h.
 331
 332 2019-08-20  Tom Tromey  <tom@tromey.com>
 333
 334         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
 335         * tui/tui-wingeneral.c (box_win): Change type of win_info.
 336         (box_win): Update.
 337         (tui_gen_win_info::make_window): Rename from tui_make_window.
 338         (tui_win_info::make_window): New method.
 339         (tui_gen_win_info::make_visible): Update.
 340         * tui/tui-source.c (tui_source_window::set_contents): Update.
 341         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
 342         (tui_data_window::display_registers_from): Update.
 343         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 344         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
 345         Declare.
 346         <can_box>: Remove.
 347         <title>: Remove.
 348         (struct tui_win_info) <make_window>: Declare.
 349         <can_box>: Now virtual.
 350         <title>: New member.
 351         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
 352         * tui/tui-command.c (tui_cmd_window::resize): Update.
 353
 354 2019-08-20  Tom Tromey  <tom@tromey.com>
 355
 356         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
 357         * tui/tui-regs.c (tui_data_window::show_registers): Update.
 358         (tui_data_window::check_register_values): Update.
 359
 360 2019-08-20  Tom Tromey  <tom@tromey.com>
 361
 362         * tui/tui-regs.h (struct tui_data_window): Use
 363         DISABLE_COPY_AND_ASSIGN.
 364         <regs_content>: Change type, removing unique_ptr.
 365         <tui_data_window>: Add move constructor.
 366         * tui/tui-regs.c (tui_data_window::show_registers)
 367         (tui_data_window::show_register_group)
 368         (tui_data_window::display_registers_from)
 369         (tui_data_window::display_registers_from)
 370         (tui_data_window::first_data_item_displayed)
 371         (tui_data_window::delete_data_content_windows)
 372         (tui_data_window::rerender, tui_data_window::refresh_window)
 373         (tui_data_window::check_register_values): Update.
 374
 375 2019-08-20  Tom Tromey  <tom@tromey.com>
 376
 377         * tui/tui-regs.h (struct tui_data_window) <show_registers,
 378         show_register_group>: Declare.
 379         (tui_show_register_group): Don't declare.
 380         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
 381         tui_show_registers.
 382         (tui_data_window::show_register_group): Rename from
 383         tui_show_register_group.
 384         (tui_data_window::check_register_values, tui_reg_command):
 385         Update.
 386         * tui/tui-layout.c (tui_set_layout): Update.
 387
 388 2019-08-20  Tom Tromey  <tom@tromey.com>
 389
 390         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
 391         Declare.
 392         (tui_check_register_values): Don't declare.
 393         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
 394         from tui_check_register_values.
 395         * tui/tui-hooks.c (tui_register_changed): Update.
 396
 397 2019-08-20  Tom Tromey  <tom@tromey.com>
 398
 399         * tui/tui-regs.c (tui_reg_layout): Move later.
 400         (tui_show_registers): Don't enable TUI mode or change layout.
 401
 402 2019-08-20  Tom Tromey  <tom@tromey.com>
 403
 404         * tui/tui-regs.h (struct tui_data_item_window)
 405         <~tui_data_item_window>: Remove.
 406         <content>: Now a unique_xmalloc_ptr.
 407         * tui/tui-regs.c (tui_register_format): Return a
 408         unique_xmalloc_ptr.
 409         (tui_get_register): Update.
 410         (~tui_data_item_window): Remove.
 411         (tui_data_window::display_registers_from, tui_display_register):
 412         Update.
 413         * tui/tui-io.h (tui_expand_tabs): Update.
 414         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
 415         Remove "col" parameter.
 416
 417 2019-08-20  Tom Tromey  <tom@tromey.com>
 418
 419         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
 420         field.
 421         * tui/tui-regs.c (~tui_data_item_window): Update.
 422
 423 2019-08-20  Tom Tromey  <tom@tromey.com>
 424
 425         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
 426         earlier.
 427
 428 2019-08-20  Tom Tromey  <tom@tromey.com>
 429
 430         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
 431
 432 2019-08-20  Tom Tromey  <tom@tromey.com>
 433
 434         * tui/tui-source.h (struct tui_source_window): Update.
 435         * tui/tui-regs.c (tui_show_registers): Update.
 436         * tui/tui-disasm.h (struct tui_disasm_window): Update.
 437         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
 438         (NO_REGS_STRING): Remove defines.
 439
 440 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
 441
 442         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
 443         unnecessary thread walk if remote doesn't support the packet.
 444
 445 2019-08-19  Tom Tromey  <tromey@adacore.com>
 446
 447         * python/py-value.c (value_has_field): Fix indentation.
 448
 449 2019-08-19  Tom Tromey  <tromey@adacore.com>
 450
 451         * printcmd.c (do_one_display, info_display_command): Update.
 452         * block.h (contained_in): Return bool.  Add allow_nested
 453         parameter.
 454         * block.c (contained_in): Return bool.  Add allow_nested
 455         parameter.
 456
 457 2019-08-19  Tom Tromey  <tom@tromey.com>
 458
 459         * configure: Rebuild.
 460         * configure.ac: Disallow the combination of -static-libstdc++ and
 461         source highlight.
 462         * source-cache.c (get_language_name): Handle rust.
 463         (source_cache::get_source_lines): Ignore highlighting exceptions.
 464
 465 2019-08-16  Tom Tromey  <tom@tromey.com>
 466
 467         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
 468         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
 469         (struct tui_source_window_base) <make_visible, refresh_window,
 470         resize>: Remove methods.
 471         <execution_info>: Remove field.
 472         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
 473         (tui_show_source_line, tui_source_window_base)
 474         (~tui_source_window_base): Update.
 475         (tui_source_window_base::resize)
 476         (tui_source_window_base::make_visible)
 477         (tui_source_window_base::refresh_window): Remove.
 478         (tui_source_window_base::update_exec_info): Update.
 479         * tui/tui-source.c (tui_source_window::set_contents): Update.
 480         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 481
 482 2019-08-16  Tom Tromey  <tom@tromey.com>
 483
 484         * tui/tui-hooks.c (tui_remove_hooks): Don't set
 485         deprecated_query_hook.
 486
 487 2019-08-16  Tom Tromey  <tom@tromey.com>
 488
 489         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 490         (tui_update_source_windows_with_line): Update.
 491         * tui/tui-source.h (struct tui_source_window)
 492         <show_symtab_source>: Declare.
 493         (tui_show_symtab_source): Don't declare.
 494         * tui/tui-source.c (tui_show_symtab_source): Rename from
 495         tui_show_symtab_source.
 496
 497 2019-08-16  Tom Tromey  <tom@tromey.com>
 498
 499         * tui/tui-winsource.h (struct tui_source_window_base)
 500         <set_contents>: Declare.
 501         * tui/tui-winsource.c
 502         (tui_source_window_base::update_source_window_as_is): Update.
 503         * tui/tui-source.h (struct tui_source_window) <set_contents>:
 504         Declare.
 505         (tui_set_source_content): Don't declare.
 506         * tui/tui-source.c (tui_source_window::set_contents): Rename from
 507         tui_set_source_content.
 508         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
 509         Declare.
 510         (tui_set_disassem_content): Don't declare.
 511         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
 512         tui_set_disassem_content.
 513
 514 2019-08-16  Tom Tromey  <tom@tromey.com>
 515
 516         * tui/tui-winsource.h (struct tui_source_window_base)
 517         <update_breakpoint_info>: Declare.
 518         (tui_update_breakpoint_info): Don't declare.
 519         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
 520         (tui_update_all_breakpoint_info): Update.
 521         (tui_source_window_base::update_breakpoint_info): Rename from
 522         tui_update_breakpoint_info.
 523         (tui_source_window_base::update_exec_info): Update.
 524
 525 2019-08-16  Tom Tromey  <tom@tromey.com>
 526
 527         * tui/tui-winsource.h (struct tui_source_window_base)
 528         <update_source_window>: Declare.
 529         (tui_update_source_window): Don't declare.
 530         * tui/tui-winsource.c
 531         (tui_source_window_base::update_source_window): Rename from
 532         tui_update_source_window.
 533         (tui_source_window_base::rerender): Update.
 534         * tui/tui-source.c (tui_source_window::maybe_update): Update.
 535         * tui/tui-disasm.c (tui_show_disassem)
 536         (tui_show_disassem_and_update_source)
 537         (tui_disasm_window::maybe_update): Update.
 538
 539 2019-08-16  Tom Tromey  <tom@tromey.com>
 540
 541         * tui/tui-winsource.h (struct tui_source_window_base)
 542         <update_source_window_as_is>: Declare.
 543         (tui_update_source_window_as_is): Don't declare.
 544         * tui/tui-winsource.c (tui_update_source_window): Update
 545         (tui_source_window_base::update_source_window_as_is): Rename from
 546         tui_update_source_window_as_is.
 547         (tui_source_window_base::refill): Update.
 548         * tui/tui-source.c (tui_show_symtab_source): Update.
 549         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
 550         Update.
 551
 552 2019-08-16  Tom Tromey  <tom@tromey.com>
 553
 554         * tui/tui-winsource.h (tui_update_source_window)
 555         (tui_update_source_window_as_is): Remove "noerror" parameter.
 556         * tui/tui-winsource.c (tui_update_source_window)
 557         (tui_update_source_window_as_is): Remove "noerror" parameter.
 558         (tui_update_source_windows_with_addr)
 559         (tui_update_source_windows_with_line)
 560         (tui_source_window_base::rerender)
 561         (tui_source_window_base::refill): Update.
 562         * tui/tui-source.h (tui_set_source_content)
 563         (tui_show_symtab_source): Remove "noerror" parameter.
 564         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
 565         parameter.
 566         (tui_show_symtab_source): Likewise.
 567         (tui_source_window::maybe_update): Update.
 568         * tui/tui-disasm.c (tui_show_disassem)
 569         (tui_show_disassem_and_update_source)
 570         (tui_disasm_window::do_scroll_vertical)
 571         (tui_disasm_window::maybe_update): Update.
 572
 573 2019-08-16  Tom Tromey  <tom@tromey.com>
 574
 575         * tui/tui.c (tui_is_window_visible): Update.
 576         * tui/tui-wingeneral.c (tui_make_window)
 577         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
 578         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
 579         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
 580         (tui_set_win_height_command, parse_scrolling_args): Update.
 581         * tui/tui-source.c (tui_source_window::style_changed): Update.
 582         * tui/tui-regs.c (tui_show_registers)
 583         (tui_data_window::first_data_item_displayed)
 584         (tui_data_window::delete_data_content_windows)
 585         (tui_check_register_values, tui_reg_command): Update.
 586         * tui/tui-disasm.c (tui_show_disassem): Update.
 587         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
 588         method.
 589         <is_visible>: Remove field.
 590         * tui/tui-data.c (tui_next_win, tui_prev_win)
 591         (tui_delete_invisible_windows): Update.
 592
 593 2019-08-16  Tom Tromey  <tom@tromey.com>
 594
 595         * tui/tui-winsource.h (struct tui_source_window_base)
 596         <m_has_locator>: Remove.
 597         * tui/tui-layout.c (show_source_disasm_command, show_data)
 598         (show_source_or_disasm_and_command): Update.
 599
 600 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
 601
 602         * NEWS (Other MI changes): New subsection.
 603         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
 604         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
 605         * arch-utils.c (default_get_pc_address_flags): New function.
 606         * arch-utils.h (default_get_pc_address_flags): New declaration.
 607         * gdbarch.sh: Add get_pc_address_flags.
 608         * gdbarch.c: Regenerate.
 609         * gdbarch.h: Likewise.
 610         * stack.c (print_pc): New function.
 611         (print_frame_info) (print_frame): Call print_pc.
 612
 613 2019-08-16  Tom de Vries  <tdevries@suse.de>
 614
 615         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
 616         print_objfile_section_info.
 617
 618 2019-08-15  Tom Tromey  <tom@tromey.com>
 619
 620         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
 621         calling update_cmdwin_start_line.
 622         * tui/tui-winsource.h (struct tui_source_window_base)
 623         <do_make_visible_with_new_height, set_new_height>: Don't declare.
 624         <rerender>: Declare.
 625         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
 626         Call rerender.
 627         (tui_source_window_base::set_new_height): Remove.
 628         (tui_source_window_base::rerender): Rename from
 629         do_make_visible_with_new_height.
 630         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
 631         resize method.
 632         (tui_win_info::make_invisible_and_set_new_height)
 633         (tui_win_info::make_visible_with_new_height): Remove.
 634         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
 635         Declare.
 636         * tui/tui-stack.c (tui_locator_window::rerender): New method.
 637         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
 638         do_make_visible_with_new_height>: Don't declare.
 639         <rerender>: Declare.
 640         * tui/tui-regs.c (tui_data_window::rerender): Rename from
 641         set_new_height.
 642         (tui_data_window::do_make_visible_with_new_height): Remove.
 643         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
 644         call tui_show_locator_content.
 645         (tui_gen_win_info::resize): Call rerender.
 646         (show_source_or_disasm_and_command): Don't call
 647         tui_show_locator_content.
 648         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
 649         method.
 650         (struct tui_win_info) <rerender>: Declare.
 651         <set_new_height, make_invisible_and_set_new_height,
 652         make_visible_with_new_height>: Don't declare.
 653         * tui/tui-data.c (tui_win_list::rerender): New method.
 654         * tui/tui-command.h (struct tui_cmd_window)
 655         <do_make_visible_with_new_height>: Don't declare.
 656         * tui/tui-command.c
 657         (tui_cmd_window::do_make_visible_with_new_height): Remove.
 658
 659 2019-08-15  Tom Tromey  <tromey@adacore.com>
 660
 661         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
 662         * ada-lang.c (ada_enum_name): Likewise.
 663
 664 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
 665
 666         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
 667         leading underscore.
 668         (GdbOutputErrorFile): Likewise.
 669         (global scope): Adjust constructor calls to GdbOutput{,Error}File
 670         accordingly.
 671         (execute_unwinders): Rename to have a leading underscore.
 672         (auto_load_packages): Likewise.
 673         (global scope): Adjust call to auto_load_packages accordingly.
 674         (GdbSetPythonDirectory): Likewise.
 675         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
 676         instead of execute_unwinders.
 677
 678 2019-08-15  Tom Tromey  <tom@tromey.com>
 679
 680         * tui/tui-layout.c (show_layout, show_source_disasm_command)
 681         (show_data): Don't change window visibility.
 682         (tui_gen_win_info::resize): Remove special case for command
 683         window.  Use wresize, when available.
 684         (show_source_or_disasm_and_command): Don't change window
 685         visibility.
 686         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
 687         <make_visible>: New method.
 688         * tui/tui-command.c (tui_cmd_window::resize): New method.
 689
 690 2019-08-15  Tom Tromey  <tom@tromey.com>
 691
 692         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
 693         (struct tui_source_windows): New.
 694         * tui/tui-winsource.c (tui_display_main): Update.
 695         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 696         (new_height_ok, parse_scrolling_args): Update.
 697         * tui/tui-layout.c (show_layout, show_data): Update.
 698         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
 699         (tui_add_to_source_windows): Don't declare.
 700         * tui/tui-data.c (source_windows, tui_source_windows)
 701         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
 702
 703 2019-08-15  Tom Tromey  <tom@tromey.com>
 704
 705         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
 706         Rename from reset.
 707         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
 708         * tui/tui-layout.c (show_source_disasm_command, show_data):
 709         Update.
 710         (tui_gen_win_info::resize): Rename.
 711         (show_source_or_disasm_and_command): Update.
 712         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
 713         reset.
 714
 715 2019-08-15  Tom Tromey  <tom@tromey.com>
 716
 717         * tui/tui-stack.c (tui_initialize_static_data): Remove.
 718         * tui/tui-interp.c (tui_interp::init): Don't call
 719         tui_initialize_static_data.
 720         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
 721
 722 2019-08-15  Tom Tromey  <tom@tromey.com>
 723
 724         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
 725         examine tui_win_list.
 726
 727 2019-08-15  Tom Tromey  <tom@tromey.com>
 728
 729         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
 730         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
 731         tui_clear_source_content.
 732         (tui_clear_source_content): Remove.
 733         (tui_source_window_base::do_erase_source_content): Hoist call to
 734         content.clear().
 735         * tui/tui-stack.c (tui_show_frame_info): Don't call
 736         tui_clear_source_content.
 737
 738 2019-08-15  Tom Tromey  <tom@tromey.com>
 739
 740         * tui/tui-winsource.h (struct tui_source_window_base)
 741         <do_erase_source_content>: New method.
 742         <erase_source_content>: New method.
 743         (tui_erase_source_content): Don't declare.
 744         * tui/tui-winsource.c (tui_clear_source_content): Update.
 745         (tui_source_window_base::do_erase_source_content): Rename from
 746         tui_erase_source_content.
 747         (tui_source_window_base::show_source_content): Update.
 748         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 749         * tui/tui-source.h (struct tui_source_window)
 750         <erase_source_content>: New method.
 751         * tui/tui-disasm.h (struct tui_disasm_window)
 752         <erase_source_content>: New method.
 753
 754 2019-08-15  Tom Tromey  <tom@tromey.com>
 755
 756         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
 757         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
 758         constructor.
 759         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
 760         * tui/tui-source.c (tui_set_source_content): Update.
 761         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 762
 763 2019-08-15  Tom Tromey  <tom@tromey.com>
 764
 765         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
 766         * tui/tui-winsource.c (tui_line_is_displayed): Move to
 767         tui-source.c.
 768         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
 769         Declare.
 770         * tui/tui-source.c (tui_source_window::line_is_displayed): New
 771         method.
 772         (tui_source_window::maybe_update): Update.
 773
 774 2019-08-15  Tom Tromey  <tom@tromey.com>
 775
 776         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
 777         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
 778         tui-disasm.c.
 779         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
 780         Declare.
 781         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
 782         method.
 783         (tui_disasm_window::maybe_update): Update.
 784
 785 2019-08-15  Tom Tromey  <tom@tromey.com>
 786
 787         * tui/tui-winsource.h (struct tui_source_window_base)
 788         <maybe_update>: Declare.
 789         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
 790         method.
 791         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 792         Declare.
 793         * tui/tui-source.c (tui_source_window::maybe_update): New method.
 794         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 795         Declare.
 796         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
 797
 798 2019-08-15  Tom Tromey  <tom@tromey.com>
 799
 800         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
 801
 802 2019-08-15  Tom Tromey  <tom@tromey.com>
 803
 804         * tui/tui-wingeneral.c: Include tui-stack.h.
 805         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
 806         (struct tui_locator_window): Move from tui-data.h.
 807         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
 808         (tui_initialize_static_data): Move from tui-data.c.
 809         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
 810         (struct tui_locator_window): Move to tui-stack.c.
 811         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
 812         (tui_initialize_static_data): Move to tui-stack.c.
 813
 814 2019-08-15  Tom Tromey  <tom@tromey.com>
 815
 816         * tui/tui-layout.c (show_source_disasm_command)
 817         (show_source_or_disasm_and_command): Use make_visible method, not
 818         tui_make_window.
 819         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
 820         Remove.
 821
 822 2019-08-15  Tom Tromey  <tom@tromey.com>
 823
 824         * tui/tui-wingeneral.h (tui_make_window): Update.
 825         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
 826         parameter.
 827         (tui_gen_win_info::make_visible): Update.
 828         * tui/tui-regs.c (tui_data_window::display_registers_from):
 829         Update.
 830         * tui/tui-layout.c (show_source_disasm_command)
 831         (show_source_or_disasm_and_command): Update.
 832         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 833         (enum tui_box): Remove.
 834         (struct tui_win_info) <can_box>: New method.
 835         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
 836         method.
 837
 838 2019-08-15  Tom de Vries  <tdevries@suse.de>
 839
 840         * linux-nat-trad.c: Include gdbarch.h.
 841
 842 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
 843
 844         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
 845         register sizes.
 846
 847 2019-08-14  Tom Tromey  <tromey@adacore.com>
 848
 849         * darwin-nat.c: Include gdbarch.h.
 850         * darwin-nat-info.c: Include gdbarch.h.
 851
 852 2019-08-13  Tom Tromey  <tom@tromey.com>
 853
 854         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
 855         Remove.
 856         * tui/tui-data.c (tui_initialize_static_data): Update.
 857
 858 2019-08-13  Tom Tromey  <tom@tromey.com>
 859
 860         * tui/tui-winsource.h (struct tui_exec_info_window)
 861         <~tui_exec_info_window, maybe_allocate_content, get_content,
 862         m_content>: Remove.
 863         (struct tui_source_window_base) <set_exec_info_content,
 864         show_exec_info_content>: Don't declare.
 865         * tui/tui-winsource.c
 866         (tui_exec_info_window::maybe_allocate_content): Remove.
 867         (tui_source_window_base::update_exec_info): Rename from
 868         set_exec_info_content.
 869         (tui_source_window_base::show_exec_info_content)
 870         (tui_source_window_base::update_exec_info): Remove.
 871
 872 2019-08-13  Tom Tromey  <tom@tromey.com>
 873
 874         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
 875         declare.
 876         * tui/tui-winsource.c (tui_update_source_window_as_is)
 877         (tui_update_source_windows_with_addr, tui_erase_source_content):
 878         Update.
 879         (tui_clear_exec_info_content): Remove.
 880
 881 2019-08-13  Tom Tromey  <tom@tromey.com>
 882
 883         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
 884         declare.
 885         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
 886         call tui_erase_exec_info_content.
 887         (tui_clear_exec_info_content): Rename from
 888         tui_erase_exec_info_content.
 889         (tui_clear_exec_info_content): Delete.
 890
 891 2019-08-13  Tom Tromey  <tom@tromey.com>
 892
 893         * tui/tui-winsource.h (struct tui_source_window_base)
 894         <show_exec_info_content>: Declare.
 895         (tui_show_exec_info_content): Don't declare.
 896         * tui/tui-winsource.c
 897         (tui_source_window_base::show_exec_info_content): Rename from
 898         tui_show_exec_info_content.
 899         (tui_source_window_base::update_exec_info): Update.
 900
 901 2019-08-13  Tom Tromey  <tom@tromey.com>
 902
 903         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
 904         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
 905         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
 906         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
 907         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
 908         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
 909         ... here.
 910
 911 2019-08-13  Tom Tromey  <tom@tromey.com>
 912
 913         * tui/tui-winsource.h (struct tui_source_window_base)
 914         <update_exec_info>: Declare.
 915         (tui_update_exec_info): Don't declare.
 916         * tui/tui-winsource.c (tui_update_source_window_as_is)
 917         (tui_source_window_base::refresh_all)
 918         (tui_update_all_breakpoint_info): Update.
 919         (tui_source_window_base::update_exec_info): Rename from
 920         tui_update_exec_info.
 921         * tui/tui-stack.c (tui_show_frame_info): Update.
 922
 923 2019-08-13  Tom Tromey  <tom@tromey.com>
 924
 925         * tui/tui-winsource.h (struct tui_source_window_base)
 926         <set_exec_info_content>: Declare.
 927         (tui_set_exec_info_content): Don't declare.
 928         * tui/tui-winsource.c
 929         (tui_source_window_base::set_exec_info_content): Rename from
 930         tui_set_exec_info_content.
 931         (tui_update_exec_info): Update.
 932
 933 2019-08-13  Tom Tromey  <tom@tromey.com>
 934
 935         * tui/tui-winsource.h (struct tui_source_window_base)
 936         <show_source_content>: Declare.
 937         (tui_show_source_content): Don't declare.
 938         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 939         (tui_source_window_base::show_source_content): Rename from
 940         tui_show_source_content.
 941         (tui_source_window_base::refresh_all): Update.
 942         * tui/tui-layout.c (show_source_disasm_command)
 943         (show_source_or_disasm_and_command): Update.
 944
 945 2019-08-13  Tom Tromey  <tom@tromey.com>
 946
 947         * tui/tui-winsource.c (tui_erase_source_content)
 948         (tui_show_source_content, tui_source_window_base::refresh_all):
 949         Update.
 950         * tui/tui-wingeneral.h
 951         (tui_check_and_display_highlight_if_needed): Don't declare.
 952         * tui/tui-wingeneral.c
 953         (tui_win_info::check_and_display_highlight_if_needed): Rename from
 954         check_and_display_highlight_if_needed.
 955         * tui/tui-win.c (tui_rehighlight_all)
 956         (tui_win_info::make_visible_with_new_height): Update.
 957         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 958         (tui_data_window::erase_data_content)
 959         (tui_data_window::display_all_data): Update.
 960         * tui/tui-data.h (struct tui_win_info)
 961         <check_and_display_highlight_if_needed>: Declare.
 962
 963 2019-08-13  Tom Tromey  <tom@tromey.com>
 964
 965         * tui/tui-win.c (tui_resize_all): Call
 966         tui_delete_invisible_windows.
 967         * tui/tui-layout.c (show_layout): Call
 968         tui_delete_invisible_windows.
 969         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
 970         * tui/tui-data.c (tui_delete_invisible_windows): New function.
 971
 972 2019-08-13  Tom Tromey  <tom@tromey.com>
 973
 974         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
 975         tui_add_win_to_layout.
 976
 977 2019-08-13  Tom Tromey  <tom@tromey.com>
 978
 979         * tui/tui-layout.h (tui_default_win_height): Don't declare.
 980         * tui/tui-layout.c (tui_default_win_height): Now static.
 981
 982 2019-08-13  Tom Tromey  <tom@tromey.com>
 983
 984         * tui/tui-layout.c (show_layout): Unify all layout cases into a
 985         single switch.
 986         (show_source_disasm_command, show_source_or_disasm_and_command):
 987         Don't check current layout.
 988
 989 2019-08-13  Tom Tromey  <tom@tromey.com>
 990
 991         * tui/tui-wingeneral.c (make_all_visible): Remove.
 992         (tui_make_all_invisible): Simplify.
 993         * tui/tui-layout.c (tui_make_all_invisible): Move from
 994         tui-wingeneral.c; simplify.
 995         (show_layout): Hoist call to tui_make_all_invisible.
 996         (show_data): Don't call tui_make_all_invisible.
 997
 998 2019-08-13  Tom Tromey  <tom@tromey.com>
 999
1000         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
1001         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
1002
1003 2019-08-13  Tom Tromey  <tom@tromey.com>
1004
1005         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
1006         tui-data.c.
1007         (show_source_disasm_command, show_data)
1008         (show_source_or_disasm_and_command): Don't use
1009         tui_set_current_layout_to.
1010         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
1011         * tui/tui-data.c (current_layout, tui_current_layout): Move to
1012         tui-layout.c.
1013         (tui_set_current_layout_to): Remove.
1014
1015 2019-08-13  Tom Tromey  <tom@tromey.com>
1016
1017         * tui/tui-layout.c (tui_set_layout): Update.
1018         * tui/tui-data.h (struct tui_layout_def): Remove.
1019         (tui_layout_def): Don't declare.
1020         * tui/tui-data.c (layout_def): Remove.
1021         (tui_layout_def): Remove.
1022
1023 2019-08-13  Tom Tromey  <tom@tromey.com>
1024
1025         * tui/tui-winsource.h (struct tui_source_window_base)
1026         <clear_detail>: No longer "override".
1027         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
1028         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
1029         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
1030         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
1031         Remove.
1032         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
1033
1034 2019-08-13  Tom Tromey  <tromey@adacore.com>
1035
1036         * tracepoint.c: Don't include readline.h or history.h.
1037
1038 2019-08-12  Tom Tromey  <tom@tromey.com>
1039
1040         * configure: Rebuild.
1041         * configure.ac: Check for readline 7.
1042         * NEWS: Mention readline 7 requirement.
1043         * README: Update.
1044
1045 2019-08-12  Tom Tromey  <tom@tromey.com>
1046
1047         * mingw-hdep.c (gdb_select): Remove readline hack.
1048
1049 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1050
1051         * blockframe.c (find_pc_partial_function): Set *block to nullptr
1052         when the function fails.
1053
1054 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
1055
1056         * s390-tdep.c (s390_type_align): New function.
1057         (s390_gdbarch_init): Set it as type_align gdbarch method.
1058
1059 2019-08-09  Tom de Vries  <tdevries@suse.de>
1060
1061         PR gdb/24591
1062         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
1063         pc_low with relocation offset.
1064
1065 2019-08-07  Tom Tromey  <tromey@adacore.com>
1066
1067         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1068         (print_frame_args): Update.
1069         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
1070         Update.
1071         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1072         * frame.h (struct frame_arg): Add initializers.
1073         <error>: Now a unique_xmalloc_ptr.
1074
1075 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
1076
1077         * NEWS: Expand the Pointer Authentication entry.
1078         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
1079         (aarch64_frame_unmask_lr): ... to this.
1080         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
1081         Call aarch64_frame_unmask_lr.
1082         * frame.c (struct frame_info): Add "masked" variable.
1083         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
1084         (fprint_frame): Check for masked pc.
1085         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
1086         declarations.
1087         * python/py-framefilter.c (py_print_frame): Check for masked pc.
1088         * stack.c (print_frame): Check for masked pc.
1089
1090 2019-08-06  Tom Tromey  <tom@tromey.com>
1091
1092         * stabsread.c (patch_block_stabs, read_one_struct_field)
1093         (read_enum_type): Use obstack_strndup.
1094         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
1095         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
1096         * dwarf2read.c (guess_full_die_structure_name)
1097         (anonymous_struct_prefix): Use obstack_strndup.
1098         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
1099         * c-exp.y (yylex): Use obstack_strndup.
1100         * ada-exp.y (write_object_renaming, write_ambiguous_var)
1101         (write_var_or_type): Use obstack_strndup.
1102
1103 2019-08-06  Tom Tromey  <tom@tromey.com>
1104
1105         * symfile.c (reread_symbols): Use obstack_strdup.
1106         * stabsread.c (read_type): Use obstack_strdup.
1107         * gdb_obstack.h (obstack_strdup): New overload.
1108         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
1109         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
1110         (dwarf2_canonicalize_name): Use obstack_strdup.
1111         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
1112         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
1113         Use obstack_strdup.
1114
1115 2019-08-06  Tom Tromey  <tom@tromey.com>
1116
1117         * gdb_obstack.h (obstack_strdup): Define.
1118         * gdb_obstack.c (obstack_strdup): Don't define.
1119
1120 2019-08-06  Tom Tromey  <tom@tromey.com>
1121
1122         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
1123         obstack_strdup.
1124         * typeprint.c (typedef_hash_table::find_global_typedef): Use
1125         obstack_strdup.
1126         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
1127         * stabsread.c (common_block_start): Use obstack_strdup.
1128         * objfiles.c (set_objfile_main_name, objfile): Use
1129         obstack_strdup.
1130         * namespace.c (add_using_directive): Use obstack_strdup.
1131         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
1132         * jit.c (finalize_symtab): Use obstack_strdup.
1133         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
1134         (guess_partial_die_structure_name, partial_die_info::fixup)
1135         (dwarf2_name): Use obstack_strdup.
1136         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
1137         obstack_strdup.
1138         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
1139         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1140         obstack_strdup.
1141         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
1142
1143 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1144
1145         * unittests/help-doc-selftests.c: New file.
1146         * Makefile.in: Add the new file.
1147
1148 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1149
1150         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
1151         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
1152         the full first line, except when FOR_VALUE_PREFIX.  In this case,
1153         the trailing '.' is not output, and the first character is uppercased.
1154         (print_help_for_command): Update call to print_doc_line.
1155         (print_doc_of_command): Likewise.
1156         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
1157         * cli/cli-option.c (append_indented_doc): Do not append newline.
1158         (build_help_option): Append newline after first appended_indented_doc
1159         only if a second call is done.
1160         (build_help): Append 2 new lines before each option, except the first
1161         one.
1162         * compile/compile.c (_initialize_compile): Add new lines after
1163         %OPTIONS%, when not at the end of the help.
1164         Change help doc or code
1165         producing the help doc to respect the invariants.
1166         * maint-test-options.c (_initialize_maint_test_options): Likewise.
1167         Also removed the new line after 'Options:', as all other commands
1168         do not put an empty line between 'Options:' and the first option.
1169         * printcmd.c (_initialize_printcmd): Likewise.
1170         * stack.c (_initialize_stack): Likewise.
1171         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
1172         incorrectly telling COMMAND is optional.
1173         * ada-lang.c (_initialize_ada_language): Change help doc or code
1174         producing the help doc to respect the invariants.
1175         * ada-tasks.c (_initialize_ada_tasks): Likewise.
1176         * breakpoint.c (_initialize_breakpoint): Likewise.
1177         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
1178         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
1179         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
1180         * cli/cli-style.c (cli_style_option::add_setshow_commands,
1181         _initialize_cli_style): Likewise.
1182         * corelow.c (core_target_info): Likewise.
1183         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
1184         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
1185         * filesystem.c (_initialize_filesystem): Likewise.
1186         * frame.c (_initialize_frame): Likewise.
1187         * gnu-nat.c (add_task_commands): Likewise.
1188         * infcall.c (_initialize_infcall): Likewise.
1189         * infcmd.c (_initialize_infcmd): Likewise.
1190         * interps.c (_initialize_interpreter): Likewise.
1191         * language.c (_initialize_language): Likewise.
1192         * linux-fork.c (_initialize_linux_fork): Likewise.
1193         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
1194         * maint.c (_initialize_maint_cmds): Likewise.
1195         * memattr.c (_initialize_mem): Likewise.
1196         * printcmd.c (_initialize_printcmd): Likewise.
1197         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
1198         _RegEx): Likewise.
1199         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
1200         * record-btrace.c (_initialize_record_btrace): Likewise.
1201         * record-full.c (_initialize_record_full): Likewise.
1202         * record.c (_initialize_record): Likewise.
1203         * regcache-dump.c (_initialize_regcache_dump): Likewise.
1204         * regcache.c (_initialize_regcache): Likewise.
1205         * remote.c (add_packet_config_cmd, init_remote_threadtests,
1206         _initialize_remote): Likewise.
1207         * ser-tcp.c (_initialize_ser_tcp): Likewise.
1208         * serial.c (_initialize_serial): Likewise.
1209         * skip.c (_initialize_step_skip): Likewise.
1210         * source.c (_initialize_source): Likewise.
1211         * stack.c (_initialize_stack): Likewise.
1212         * symfile.c (_initialize_symfile): Likewise.
1213         * symtab.c (_initialize_symtab): Likewise.
1214         * target-descriptions.c (_initialize_target_descriptions): Likewise.
1215         * top.c (init_main): Likewise.
1216         * tracefile-tfile.c (tfile_target_info): Likewise.
1217         * tracepoint.c (_initialize_tracepoint): Likewise.
1218         * tui/tui-win.c (_initialize_tui_win): Likewise.
1219         * utils.c (add_internal_problem_command): Likewise.
1220         * valprint.c (value_print_option_defs): Likewise.
1221
1222 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
1223
1224         PR build/24886
1225         * configure.ac: Drop enable-libmcheck support.
1226         * configure, config.in: Rebuild.
1227         * libmcheck.m4: Remove.
1228         * acinclude.m4: Don't include it.
1229         * Makefile.in: Don't distribute it.
1230         * top.c (print_gdb_configuration): Don't mention it.
1231
1232 2019-08-06  Tom Tromey  <tom@tromey.com>
1233
1234         * utils.c (set_output_style): Sometimes pass stream to
1235         emit_style_escape.
1236         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
1237         * record-btrace.c (btrace_insn_history): Update.
1238         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
1239         method.
1240         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
1241         Update initializers.
1242         <m_uiout>: New field.
1243         <m_di>: Move lower.
1244         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1245         Remove "uiout" parameter.
1246         (dump_insns): Update.
1247         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
1248         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
1249
1250 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
1251
1252         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
1253         (error_in_psymtab_expansion): Likewise.
1254         (lookup_symbol_via_quick_fns): Likewise.
1255         (basic_lookup_transparent_type_quick): Likewise.
1256         (basic_lookup_transparent_type_1): Likewise.
1257
1258 2019-08-06  Tom Tromey  <tromey@adacore.com>
1259
1260         * source.c (last_source_error): Now bool.
1261         (print_source_lines_base): Make "noprint" bool.  Only open
1262         source file when last_source_visited changes.
1263
1264 2019-08-06  Tom Tromey  <tromey@adacore.com>
1265
1266         * annotate.c (annotate_source_line): Use g_source_cache.
1267         * source-cache.c (source_cache::get_plain_source_lines): Change
1268         parameters.  Populate m_offset_cache.
1269         (source_cache::ensure): New method.
1270         (source_cache::get_line_charpos): New method.
1271         (extract_lines): Move lower.  Change parameters.
1272         (source_cache::get_source_lines): Move lower.
1273         * source-cache.h (class source_cache): Update comment.
1274         <get_line_charpos>: New method.
1275         <get_source_lines>: Update comment.
1276         <clear>: Clear m_offset_cache.
1277         <get_plain_source_lines>: Change parameters.
1278         <ensure>: New method
1279         <m_offset_cache>: New member.
1280         * source.c (forget_cached_source_info_for_objfile): Update.
1281         (info_source_command): Use g_source_cache.
1282         (find_source_lines, open_source_file_with_line_charpos): Remove.
1283         (print_source_lines_base, search_command_helper): Use g_source_cache.
1284         * source.h (open_source_file_with_line_charpos): Don't declare.
1285         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
1286         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
1287         Use g_source_cache.
1288
1289 2019-08-06  Tom Tromey  <tromey@adacore.com>
1290
1291         * source-cache.c (source_cache::get_plain_source_lines):
1292         Remove "first_line" and "last_line" parameters.
1293         (source_cache::get_source_lines): Cache plain text.
1294         * source-cache.h (class source_cache)
1295         <get_plain_source_lines>: Update.
1296
1297 2019-08-06  Tom Tromey  <tromey@adacore.com>
1298
1299         * source-cache.c (extract_lines): No longer a method.
1300         Changed type of parameter.  Include final newline.
1301         (selftests::extract_lines_test): New function.
1302         (_initialize_source_cache): Likewise.
1303         * source-cache.h (class source_cache)
1304         <extract_lines>: Don't declare.
1305
1306 2019-08-06  Tom Tromey  <tromey@adacore.com>
1307
1308         * breakpoint.c (init_breakpoint_sal): Update.
1309         (breakpoint): Update.
1310         * breakpoint.h (struct breakpoint) <filter>: Now a
1311         unique_xmalloc_ptr.
1312
1313 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1314
1315         * NEWS: Mention dictionary access on blocks.
1316         * python/py-block.c (blpy_getitem): New function.
1317         (block_object_as_mapping): New struct.
1318         (block_object_type): Use new struct for tp_as_mapping field.
1319
1320 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1321
1322         * objfiles.h (objfile): Add a comment describing partial symbols.
1323
1324 2019-08-05  Tom Tromey  <tromey@adacore.com>
1325
1326         * compile/compile.c (_initialize_compile): Use _(), not N_().
1327         * thread.c (_initialize_thread): Use _(), not N_().
1328         * stack.c (_initialize_stack): Use _(), not N_().
1329         * printcmd.c (_initialize_printcmd): Use _(), not N_().
1330
1331 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
1332
1333         * dwarf2read.c (struct dw2_symtab_iterator):
1334         <want_specific_block>: Remove.
1335         <block_index>: Change type to gdb::optional.
1336         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
1337         change type of BLOCK_INDEX parameter to gdb::optional.
1338         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
1339         (dw2_lookup_symbol): Don't pass argument for
1340         WANT_SPECIFIC_BLOCK.
1341         (dw2_expand_symtabs_for_function): Don't pass argument for
1342         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
1343         (class dw2_debug_names_iterator)
1344         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
1345         parameter, change BLOCK_INDEX type to gdb::optional.
1346         <m_want_specific_block>: Remove.
1347         <m_block_index>: Change type to gdb::optional.
1348         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
1349         gdb::optional.  Re-write in function of gdb::optional.
1350         (dw2_debug_names_lookup_symbol): Don't pass argument for
1351         WANT_SPECIFIC_BLOCK.
1352         (dw2_debug_names_expand_symtabs_for_function): Don't pass
1353         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
1354         BLOCK_INDEX.
1355
1356 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1357
1358         * NEWS: Mention changes to "info sources" command.
1359
1360 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1361
1362         * symtab.c (filename_partial_match_opts): New struct type.
1363         (struct output_source_filename_data): New members
1364         regexp, c_regexp, partial_match.
1365         (output_source_filename): Use new members to decide to print file.
1366         (info_sources_option_defs): New variable.
1367         (make_info_sources_options_def_group, print_info_sources_header,
1368         info_sources_command_completer):
1369         New functions.
1370         (info_sources_command): Read new optional arguments.
1371         (_initialize_symtab): Update info sources help.
1372
1373 2019-08-02  Alexandre Oliva <oliva@adacore.com>
1374
1375         * ada-lang.c (exception_support_info_v0): Renamed from...
1376         (default_exception_support_info): ... this.  Create new
1377         definition for v1.
1378         (ada_has_this_exception_support): Look up catch_handlers_sym.
1379         (ada_exception_support_info_sniffer): Try v0 after default.
1380
1381 2019-08-01  Tom Tromey  <tromey@adacore.com>
1382
1383         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
1384         gdbarch.h.
1385
1386 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
1387
1388         * s12z-tdep.c: Fix include path for s12z-opc.h.
1389
1390 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
1391
1392         * NEWS: Require GNU make 3.82.
1393
1394 2019-07-16  Tom Tromey  <tom@tromey.com>
1395
1396         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
1397         declare.
1398
1399 2019-07-30  Tom Tromey  <tromey@adacore.com>
1400
1401         * block.c (contained_in): Remove BLOCK_FUNCTION check.
1402
1403 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
1404
1405         * printcmd.c (print_address_symbolic): Print negative offsets.
1406         (build_address_symbolic): Force signed arithmetic when computing
1407         offset.
1408
1409 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
1410
1411         PR/24474: Add a function to lookup static variables.
1412         * NEWS: Mention this new function.
1413         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
1414         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
1415         * python/python.c (python_GdbMethods): Add new function.
1416
1417 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
1418
1419         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1420         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1421         (objfpy_lookup_static_symbol): New function.
1422         (objfile_object_methods): Add new functions.
1423
1424 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1425
1426         * NEWS: Mention 'set|show print frame-info'.  Mention new
1427         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
1428         backtrace argument.  Mention that python frame filtering code
1429         is now consistent with what 'backtrace' command prints.
1430
1431 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1432
1433         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1434         comments.
1435         (print_frame_info_auto, print_frame_info_source_line,
1436         print_frame_info_location, print_frame_info_source_and_location,
1437         print_frame_info_location_and_address, print_frame_info_short_location):
1438         New declarations.
1439         (struct frame_print_options): New member print_frame_info.
1440         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1441         * stack.h (get_user_print_what_frame_info): New declaration.
1442         (frame_show_address): New declaration.
1443         * stack.c (print_frame_arguments_choices): New value 'presence'.
1444         (print_frame_info_auto, print_frame_info_source_line,
1445         print_frame_info_location, print_frame_info_source_and_location,
1446         print_frame_info_location_and_address, print_frame_info_short_location,
1447         print_frame_info_choices, print_frame_info_print_what): New definitions.
1448         (print_frame_args): Only print dots for args if print frame-arguments
1449         is 'presence'.
1450         (frame_print_option_defs): New element for "frame-info".
1451         (get_user_print_what_frame_info): New function.
1452         (frame_show_address): Make non static.  Move comment to stack.h.
1453         (print_frame_info_to_print_what): New function.
1454         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
1455         to decide what to print.
1456         (backtrace_command_1): Handle the new print_frame_arguments_presence
1457         value.
1458         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1459         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1460         (py_print_frame): In non-mi mode, use LOCATION as default for
1461         print_what, similarly to frame information printed directly by
1462         backtrace command. Handle frame-info user option in non MI mode.
1463
1464 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1465
1466         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1467         Add case for debugging 32-bit target on 64-bit host.  Revise
1468         comment.
1469
1470 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1471
1472         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1473         instead of find_function_entry_range_from_pc.
1474
1475 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1476
1477         * stack.c (find_frame_funname): Remove code which preferred
1478         minsym over symtab sym in "certain pathological cases".
1479
1480         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1481         parameter.  Change type of "do_demangle" to bool.
1482         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1483         Pass suitable "prefer_sym_over_minsym" flag to
1484         build_address_symbolic().  Don't output "+" for negative offsets.
1485         * printcmd.c (print_address_symbolic): Update invocation of
1486         build_address_symbolic to include a "prefer_sym_over_minsym"
1487         flag.
1488         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1489         Restrict cases in which use of minimal symbol is preferred to that
1490         of a found symbol.  Update comments.
1491
1492         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1493         for entry pc when entry pc is out of range for that FDE.
1494
1495 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
1496
1497         PR gdb/24839:
1498         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1499         type.
1500
1501 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
1502
1503         * python/py-objfile.c (add_separate_debug_file): Fix comment about
1504         this function's Python signature.
1505
1506
1507 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
1508
1509         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1510         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1511         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1512         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1513         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1514
1515
1516 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
1517
1518         * h8300-tdep.c (h8300_register_name_common): New.
1519         h8300_register_name): Use h8300_register_name_common.
1520         (h8300s_register_name): Likewise.
1521         (h8300sx_register_name): Likewise.
1522         (h8300h_register_nam): New.
1523         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1524
1525
1526 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
1527
1528         * arm-tdep.c (arm_skip_cmse_entry): New function.
1529         (arm_is_sgstubs_section): New function.
1530         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1531
1532 2019-07-22  Tom Tromey  <tom@tromey.com>
1533
1534         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1535         Don't self-assign.
1536
1537 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1538
1539         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1540         type_print.
1541
1542 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1543
1544         * symtab.c (search_symbols): Adjust msymbol matching type arrays
1545         so that GDB doesn't match any msymbols when searching in the
1546         TYPES_DOMAIN.
1547         (print_symbol_info): Print using typedef_print or type_print based
1548         on the type of the symbol.  Add updated FIXME comment moved from...
1549         (_initialize_symtab): ... move and update FIXME comment to above.
1550
1551 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1552
1553         * NEWS: Mention adding -q option to "info types".
1554         * symtab.c (struct info_types_options): New struct.
1555         (info_types_options_defs): New variable.
1556         (make_info_types_options_def_group): New function.
1557         (info_types_command): Use gdb::option framework to parse options.
1558         (info_types_command_completer): New function.
1559         (_initialize_symtab): Extend the help text on "info types" and
1560         register command completer.
1561
1562 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
1563
1564         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1565         (lookup_symbol_in_objfile): Change int to block_enum and add a
1566         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1567
1568 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
1569
1570         * MAINTAINERS (Write After Approval): Add self.
1571
1572 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1573
1574         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1575         instruction to the dummy code region.
1576
1577 2019-07-19  Tom Tromey  <tromey@adacore.com>
1578
1579         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1580         (ARGSUSED, PARAMS, __func__): Remove rules.
1581
1582 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1583
1584         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1585         * features/arm/arm-with-iwmmxt.c: Remove.
1586         * features/arm/arm-with-iwmmxt.xml: Remove.
1587         * features/arm/arm-with-m-fpa-layout.c: Remove.
1588         * features/arm/arm-with-m-fpa-layout.xml: Remove.
1589         * features/arm/arm-with-m-vfp-d16.c: Remove.
1590         * features/arm/arm-with-m-vfp-d16.xml: Remove.
1591         * features/arm/arm-with-m.c: Remove.
1592         * features/arm/arm-with-m.xml: Remove.
1593         * features/arm/arm-with-neon.c: Remove.
1594         * features/arm/arm-with-neon.xml: Remove.
1595         * features/arm/arm-with-vfpv2.c: Remove.
1596         * features/arm/arm-with-vfpv2.xml: Remove.
1597         * features/arm/arm-with-vfpv3.c: Remove.
1598         * features/arm/arm-with-vfpv3.xml: Remove.
1599
1600 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1601
1602         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1603
1604 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1605
1606         * arch/aarch32.c (aarch32_create_target_description): Create
1607         target descriptions using features.
1608         * arch/arm.c (arm_create_target_description)
1609         (arm_create_mprofile_target_description): Likewise.
1610         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1611
1612 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1613
1614         * Makefile.in: Add new files.
1615         * aarch32-tdep.c: New file.
1616         * aarch32-tdep.h: New file.
1617         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1618         Call aarch32_read_description.
1619         * arch/aarch32.c: New file.
1620         * arch/aarch32.h: New file.
1621         * arch/arm.c (arm_create_target_description)
1622         (arm_create_mprofile_target_description): New function.
1623         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1624         (arm_create_target_description)
1625         (arm_create_mprofile_target_description): New declaration.
1626         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1627         read_description functions.
1628         * arm-linux-nat.c (arm_linux_nat_target::read_description):
1629         Likewise.
1630         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1631         * arm-tdep.c (tdesc_arm_list): New variable.
1632         (arm_register_g_packet_guesses): Call create description functions.
1633         (arm_read_description) (arm_read_mprofile_description): New
1634         function.
1635         * arm-tdep.h (arm_read_description)
1636         (arm_read_mprofile_description): Add declaration.
1637         * configure.tgt: Add new files.
1638
1639 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
1640
1641         * top.c (new_ui_command): Open specified terminal just once.
1642
1643 2019-07-18  Tom Tromey  <tromey@adacore.com>
1644
1645         * symtab.c (main_name): Constify return type.
1646         * symfile.c (set_initial_language): Update.
1647         * symtab.h (main_name): Constify return type.
1648
1649 2019-07-17  Tom Tromey  <tom@tromey.com>
1650
1651         * tui/tui-winsource.c (tui_update_source_window)
1652         (tui_update_source_window_as_is)
1653         (tui_update_source_windows_with_line): Remove return.
1654         * tui/tui-disasm.c (tui_show_disassem)
1655         (tui_show_disassem_and_update_source): Remove return.
1656         * tui/tui.c (tui_reset): Remove return.
1657         * tui/tui-wingeneral.c
1658         (tui_check_and_display_highlight_if_needed): Remove return.
1659
1660 2019-07-17  Tom Tromey  <tom@tromey.com>
1661
1662         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1663
1664 2019-07-17  Tom Tromey  <tom@tromey.com>
1665
1666         * tui/tui-winsource.h (struct tui_exec_info_window)
1667         (struct tui_source_window_base): Move from tui-data.h.
1668         * tui/tui-winsource.c: Move many method definitions from
1669         elsewhere.  Remove "structuring" comments.
1670         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1671         (tui_source_window_base::refresh_window): Move to
1672         tui-winsource.c.
1673         * tui/tui-win.c (tui_source_window_base::refresh_all)
1674         (tui_source_window_base::update_tab_width)
1675         (tui_source_window_base::set_new_height)
1676         (tui_source_window_base::do_make_visible_with_new_height): Move to
1677         tui-winsource.c.
1678         * tui/tui-source.h: Update.
1679         * tui/tui-source.c (tui_source_window_base::reset): Move to
1680         tui-winsource.c.
1681         * tui/tui-disasm.h: Update.
1682         * tui/tui-data.h (struct tui_exec_info_window): Move to
1683         tui-winsource.h.
1684         (struct tui_source_window_base): Likewise.
1685         * tui/tui-data.c (tui_source_window_base::clear_detail)
1686         (tui_source_window_base, ~tui_source_window_base): Move to
1687         tui-winsource.c.
1688
1689 2019-07-17  Tom Tromey  <tom@tromey.com>
1690
1691         * tui/tui-win.c (tui_resize_all)
1692         (tui_source_window_base::update_tab_width)
1693         (tui_adjust_win_heights): Update.
1694         (tui_win_info::make_invisible_and_set_new_height): Rename from
1695         make_invisible_and_set_new_height.
1696         * tui/tui-data.h (struct tui_win_info)
1697         <make_invisible_and_set_new_height>: New method.
1698
1699 2019-07-17  Tom Tromey  <tom@tromey.com>
1700
1701         * tui/tui.c: Update.
1702         * tui/tui-source.h (struct tui_source_window): Move from
1703         tui-data.h.
1704         * tui/tui-layout.c: Update.
1705         * tui/tui-disasm.c: Update.
1706         * tui/tui-data.h (struct tui_source_window): Move to
1707         tui-source.h.
1708
1709 2019-07-17  Tom Tromey  <tom@tromey.com>
1710
1711         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1712         tui-data.h.
1713         * tui/tui-data.h (struct tui_disasm_window): Move to
1714         tui-disasm.h.
1715
1716 2019-07-17  Tom Tromey  <tom@tromey.com>
1717
1718         * tui/tui-regs.h (struct tui_data_item_window): Move from
1719         tui-data.h.
1720         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1721         * tui/tui-data.h (struct tui_data_item_window): Move to
1722         tui-regs.h.
1723         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1724
1725 2019-07-17  Tom Tromey  <tom@tromey.com>
1726
1727         * tui/tui.c: Update.
1728         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1729         (tui_cmd_window::max_height): Move to tui-command.c.
1730         * tui/tui-layout.c: Update.
1731         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1732         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1733         tui-command.c.
1734         * tui/tui-command.h (struct tui_cmd_window): Move from
1735         tui-data.h.
1736         * tui/tui-command.c: Remove "structuring" comments.
1737         (tui_cmd_window::clear_detail)
1738         (tui_cmd_window::do_make_visible_with_new_height)
1739         (tui_cmd_window::max_height): Move from elsewhere.
1740
1741 2019-07-17  Tom Tromey  <tom@tromey.com>
1742
1743         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1744         Now static.
1745         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1746         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1747
1748 2019-07-17  Tom Tromey  <tom@tromey.com>
1749
1750         * tui/tui.c: Update.
1751         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1752         tui-regs.c.
1753         * tui/tui-windata.h: Remove file.
1754         * tui/tui-windata.c: Remove file.
1755         * tui/tui-win.c (tui_data_window::set_new_height)
1756         (tui_data_window::do_make_visible_with_new_height): Move to
1757         tui-regs.c.
1758         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1759         * tui/tui-regs.c: Remove "structuring" comments.
1760         (tui_data_window::first_data_item_displayed)
1761         (tui_data_window::delete_data_content_windows)
1762         (tui_data_window::erase_data_content)
1763         (tui_data_window::display_all_data)
1764         (tui_data_window::refresh_all)
1765         (tui_data_window::do_scroll_vertical)
1766         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1767         (tui_data_window::do_make_visible_with_new_height)
1768         (tui_data_window::refresh_window): Move from elsewhere.
1769         (_initialize_tui_regs): Move to end of file.
1770         * tui/tui-layout.c: Update.
1771         * tui/tui-hooks.c: Update.
1772         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1773         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1774         tui-regs.c.
1775         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1776
1777 2019-07-17  Tom Tromey  <tom@tromey.com>
1778
1779         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1780         seen.
1781
1782 2019-07-17  Tom Tromey  <tom@tromey.com>
1783
1784         * tui/tui-win.c (tui_source_window_base::set_new_height)
1785         (tui_source_window_base::do_make_visible_with_new_height): Use
1786         m_has_locator field directly.
1787         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1788         method.
1789         (struct tui_source_window_base) <has_locator>: Likewise.
1790
1791 2019-07-17  Tom Tromey  <tom@tromey.com>
1792
1793         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1794         Don't declare.
1795         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1796         Remove.
1797         * tui/tui-win.c (tui_source_window_base::set_new_height)
1798         (tui_source_window_base::set_new_height)
1799         (make_invisible_and_set_new_height)
1800         (tui_source_window_base::do_make_visible_with_new_height)
1801         (tui_source_window_base::do_make_visible_with_new_height):
1802         Update.
1803         * tui/tui-layout.c (show_source_disasm_command, show_data)
1804         (show_source_or_disasm_and_command): Update.
1805         * tui/tui-layout.c (show_layout): Update.
1806
1807 2019-07-17  Tom Tromey  <tom@tromey.com>
1808
1809         * tui/tui-layout.c (make_data_window): Remove.
1810         (show_data): Unify creation and re-initialization cases.
1811
1812 2019-07-17  Tom Tromey  <tom@tromey.com>
1813
1814         * tui/tui-layout.c (make_source_window, make_disasm_window):
1815         Remove.
1816         (show_data): Unify creation and re-initialization cases.
1817
1818 2019-07-17  Tom Tromey  <tom@tromey.com>
1819
1820         * tui/tui-layout.c (make_command_window): Remove.
1821         (show_source_disasm_command, show_source_or_disasm_and_command):
1822         Unify creation and re-initialization cases.
1823
1824 2019-07-17  Tom Tromey  <tom@tromey.com>
1825
1826         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1827         creation and re-initialization cases.
1828
1829 2019-07-17  Tom Tromey  <tom@tromey.com>
1830
1831         * tui/tui-regs.c (tui_get_register): Return void.
1832
1833 2019-07-17  Tom Tromey  <tom@tromey.com>
1834
1835         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1836         Simplify.
1837
1838 2019-07-17  Tom Tromey  <tom@tromey.com>
1839
1840         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1841         resetting.
1842
1843 2019-07-17  Tom Tromey  <tom@tromey.com>
1844
1845         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1846         * tui/tui-regs.c (tui_reg_layout): New function.
1847         (tui_show_registers, tui_reg_command): Use it.
1848         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1849         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1850         parameters.
1851         (tui_layout_command): Remove.
1852
1853 2019-07-17  Tom Tromey  <tom@tromey.com>
1854
1855         * tui/tui-layout.h (tui/tui-layout): Return void.
1856         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1857
1858 2019-07-17  Tom Tromey  <tom@tromey.com>
1859
1860         * tui/tui-layout.c (show_source_disasm_command, show_data):
1861         Update.
1862         (reset_locator): Remove.
1863         (show_source_or_disasm_and_command): Update.
1864
1865 2019-07-17  Tom Tromey  <tom@tromey.com>
1866
1867         * tui/tui-source.c (tui_source_window_base::reset): Remove
1868         win_type parameter.
1869         * tui/tui-layout.c (make_command_window, make_source_window)
1870         (make_disasm_window, make_data_window)
1871         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1872         (reset_locator, show_source_or_disasm_and_command): Update.
1873         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1874         win_type parameter.
1875         (struct tui_source_window_base) <reset>: Likewise.
1876
1877 2019-07-17  Tom Tromey  <tom@tromey.com>
1878
1879         * tui/tui-layout.c (show_source_disasm_command): Use
1880         reset_locator.
1881         (reset_locator): New function.
1882         (init_and_make_win): Remove.
1883         (show_source_or_disasm_and_command): Use reset_locator.
1884
1885 2019-07-17  Tom Tromey  <tom@tromey.com>
1886
1887         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1888         condition.
1889         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1890         Remove condition.
1891         * tui/tui-source.c (tui_source_window_base::reset): New method.
1892         * tui/tui-layout.c (make_command_window): Don't call
1893         init_and_make_win.
1894         (make_source_window, make_disasm_window): Don't call
1895         make_source_or_disasm_window.
1896         (make_data_window): Don't call init_and_make_win.  Change calling
1897         convention.
1898         (show_source_disasm_command, show_data): Simplify.
1899         (make_source_or_disasm_window): Remove.
1900         (show_source_or_disasm_and_command): Simplify.
1901         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1902         (struct tui_source_window_base) <reset>: Likewise.
1903         <execution_info>: Remove initializer.
1904         * tui/tui-data.c (tui_source_window_base): Initialize
1905         execution_info.
1906
1907 2019-07-17  Tom Tromey  <tom@tromey.com>
1908
1909         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1910         variable.
1911
1912 2019-07-17  Tom Tromey  <tom@tromey.com>
1913
1914         * tui/tui.c (tui_rl_other_window): Update.
1915         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1916         superclass method first.  Always iterate over regs_content.
1917         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1918         method.
1919         * tui/tui-win.c (tui_set_focus_command): Update.
1920
1921 2019-07-17  Tom Tromey  <tom@tromey.com>
1922
1923         * tui/tui-win.c (tui_set_focus_command): Rename from
1924         tui_set_focus.  Call tui_enable.
1925         (tui_set_focus_command): Remove.
1926
1927 2019-07-17  Tom Tromey  <tom@tromey.com>
1928
1929         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1930         refresh_window.
1931         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1932         touchwin.
1933         (tui_data_window::refresh_window): Call refresh_window on data
1934         items.  Always call superclass refresh_window.
1935         (tui_win_info::refresh): Remove.
1936         (tui_source_window_base::refresh_window): Update.
1937         (tui_refresh_all): Update.
1938         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1939         refresh_window.
1940         (show_source_or_disasm_and_command): Likewise.
1941         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1942         (struct tui_source_window_base) <refresh>: Likewise.
1943
1944 2019-07-17  Tom Tromey  <tom@tromey.com>
1945
1946         * tui/tui-winsource.c (tui_clear_source_content)
1947         (tui_show_source_content): Update.
1948         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1949         whether content is empty.
1950         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1951         Remove.
1952
1953 2019-07-17  Tom Tromey  <tom@tromey.com>
1954
1955         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1956         window's contents.
1957         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1958         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1959
1960 2019-07-17  Tom Tromey  <tom@tromey.com>
1961
1962         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1963         (struct tui_data_item_window): Update.
1964
1965 2019-07-17  Tom Tromey  <tom@tromey.com>
1966
1967         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1968         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1969         defines.
1970
1971 2019-07-17  Tom Tromey  <tom@tromey.com>
1972
1973         * tui/tui-winsource.h (tui_erase_source_content)
1974         (tui_clear_source_content): Remove "display_prompt" parameter.
1975         * tui/tui-winsource.c (tui_update_source_window_as_is)
1976         (tui_update_source_windows_with_addr): Update.
1977         (tui_clear_source_content): Remove "display_prompt" parameter.
1978         (tui_erase_source_content): Likewise.  Simplify.
1979         (tui_show_source_content): Update.
1980         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1981         * tui/tui-stack.c (tui_show_frame_info): Update.
1982         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1983         Remove defines.
1984
1985 2019-07-17  Tom Tromey  <tom@tromey.com>
1986
1987         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1988         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1989         parameter.
1990         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1991         parameter.
1992
1993 2019-07-17  Tom Tromey  <tom@tromey.com>
1994
1995         * tui/tui-winsource.c (tui_clear_source_content)
1996         (tui_show_source_content, tui_show_exec_info_content)
1997         (tui_clear_exec_info_content): Update.
1998         * tui/tui-stack.c (tui_show_locator_content): Update.
1999         (tui_show_frame_info): Update.
2000         * tui/tui-source.h (tui_source_window): Don't declare.
2001         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
2002         from tui_source_is_displayed.
2003         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
2004         Remove field.
2005         (struct tui_source_window_base) <content_in_use>: New field.  Now
2006         bool.
2007         (struct tui_source_window) <showing_source_p>: New method.
2008         (TUI_SRC_WIN): Change cast.
2009         * tui/tui-data.c (tui_initialize_static_data): Update.
2010
2011 2019-07-17  Tom Tromey  <tom@tromey.com>
2012
2013         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
2014         location_matches_p.
2015         * tui/tui-source.c (tui_source_window::location_matches_p): New
2016         method.
2017         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
2018         method.
2019         * tui/tui-data.h (struct tui_source_window_base)
2020         <location_matches_p>: New method.
2021         (struct tui_source_window, struct tui_disasm_window)
2022         <location_matches_p>: Likewise.
2023
2024 2019-07-17  Tom Tromey  <tom@tromey.com>
2025
2026         * tui/tui-win.c (tui_set_win_height_command): Rename from
2027         tui_set_win_height.
2028         (tui_set_win_height_command): Remove.
2029
2030 2019-07-17  Tom Tromey  <tom@tromey.com>
2031
2032         * tui/tui-source.c (tui_source_window): New constructor.  Add
2033         observer.
2034         (~tui_source_window): New destructor.
2035         (tui_source_window::style_changed): New method.
2036         * tui/tui-hooks.c (tui_redisplay_source): Remove.
2037         (tui_attach_detach_observers): Update.
2038         * tui/tui-data.h (struct tui_source_window): Make constructor not
2039         inline.  Add destructor.
2040         (struct tui_source_window) <style_changed>: New method.
2041         <m_observable>: New member.
2042
2043 2019-07-17  Tom Tromey  <tom@tromey.com>
2044
2045         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
2046         * tui/tui-win.c (tui_resize_all): Fix typo.
2047
2048 2019-07-17  Tom Tromey  <tom@tromey.com>
2049
2050         * tui/tui-wingeneral.h (tui_refresh_all): Update.
2051         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
2052         (tui_refresh_all): Remove "list" parameter.  Use foreach.
2053         * tui/tui-win.c (window_name_completer): Use foreach.
2054         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
2055         (update_tab_width): Likewise.
2056         * tui/tui-layout.c (show_layout): Update.
2057         * tui/tui-data.h (class tui_window_iterator): New.
2058         (struct all_tui_windows): New.
2059         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
2060
2061 2019-07-17  Tom Tromey  <tom@tromey.com>
2062
2063         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
2064         parameter.  Don't reference globals.
2065         (tui_reg_command): Update.
2066
2067 2019-07-17  Tom Tromey  <tom@tromey.com>
2068
2069         * tui/tui-regs.c (tui_show_registers): Simplify.
2070
2071 2019-07-17  Tom Tromey  <tom@tromey.com>
2072
2073         * tui/tui-regs.c (tui_show_registers): Update.
2074         (tui_show_register_group): Add win_info parameter.
2075
2076 2019-07-17  Tom Tromey  <tom@tromey.com>
2077
2078         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
2079         Rename from tui_display_reg_element_at_line.
2080         (tui_data_window::display_registers_from_line): Update.
2081         * tui/tui-data.h (struct tui_data_window)
2082         <display_reg_element_at_line>: New method.
2083
2084 2019-07-17  Tom Tromey  <tom@tromey.com>
2085
2086         * tui/tui-regs.h (tui_display_registers_from)
2087         (tui_display_registers_from_line): Don't declare.
2088         * tui/tui-windata.c (tui_data_window::display_all_data)
2089         (tui_data_window::refresh_all)
2090         (tui_data_window::do_scroll_vertical): Update.
2091         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
2092         from tui_display_registers_from.
2093         (tui_display_reg_element_at_line): Update.
2094         (tui_data_window::display_registers_from_line): Rename from
2095         tui_display_registers_from_line.
2096         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
2097         display_registers_from_line>: New methods.
2098
2099 2019-07-17  Tom Tromey  <tom@tromey.com>
2100
2101         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
2102         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
2103         from tui_erase_data_content.
2104         (tui_data_window::display_all_data)
2105         (tui_data_window::refresh_all)
2106         (tui_data_window::do_scroll_vertical): Update.
2107         * tui/tui-regs.c (tui_show_registers): Update.
2108         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
2109         New method.
2110
2111 2019-07-17  Tom Tromey  <tom@tromey.com>
2112
2113         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
2114         declare.
2115         * tui/tui-windata.c
2116         (tui_data_window::delete_data_content_windows): Rename from
2117         tui_delete_data_content_windows.
2118         (tui_data_window::display_all_data)
2119         (tui_data_window::do_scroll_vertical): Update.
2120         * tui/tui-data.h (struct tui_data_window)
2121         <delete_data_content_windows>: New method.
2122
2123 2019-07-17  Tom Tromey  <tom@tromey.com>
2124
2125         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
2126         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
2127
2128 2019-07-17  Tom Tromey  <tom@tromey.com>
2129
2130         * tui/tui-windata.h (tui_display_all_data): Don't declare.
2131         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
2132         from tui_display_all_data.
2133         * tui/tui-win.c
2134         (tui_data_window::do_make_visible_with_new_height): Update.
2135         * tui/tui-regs.c (tui_show_registers): Update.
2136         * tui/tui-layout.c (tui_set_layout): Update.
2137         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
2138         method.
2139
2140 2019-07-17  Tom Tromey  <tom@tromey.com>
2141
2142         * tui/tui-windata.h (tui_display_data_from): Don't declare.
2143         * tui/tui-windata.c (tui_display_data_from): Remove.
2144         (tui_data_window::refresh_all): Update.
2145
2146 2019-07-17  Tom Tromey  <tom@tromey.com>
2147
2148         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
2149         * tui/tui-windata.c (tui_display_data_from_line): Remove.
2150         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
2151         tui_display_registers_from_line.
2152         * tui/tui-regs.h (tui_display_registers_from_line): Update.
2153         * tui/tui-regs.c (tui_display_registers_from_line): Remove
2154         "force_display" parameter.
2155
2156 2019-07-17  Tom Tromey  <tom@tromey.com>
2157
2158         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
2159         declare.
2160         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
2161         Rename from tui_first_reg_element_no_inline.
2162         (tui_display_reg_element_at_line)
2163         (tui_display_registers_from_line): Update.
2164         * tui/tui-data.h (struct tui_data_window)
2165         <first_reg_element_no_inline>: New method.
2166
2167 2019-07-17  Tom Tromey  <tom@tromey.com>
2168
2169         * tui/tui-windata.c (tui_display_data_from)
2170         (tui_data_window::do_scroll_vertical): Update.
2171         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
2172         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
2173         Rename from tui_line_from_reg_element_no.
2174         (tui_display_registers_from_line): Update.
2175         * tui/tui-data.h (struct tui_data_window)
2176         <line_from_reg_element_no>: New method.
2177
2178 2019-07-17  Tom Tromey  <tom@tromey.com>
2179
2180         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
2181         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
2182         tui_last_regs_line_no.
2183         (tui_display_reg_element_at_line)
2184         (tui_display_registers_from_line): Update.
2185         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
2186         method.
2187
2188 2019-07-17  Tom Tromey  <tom@tromey.com>
2189
2190         PR tui/24722:
2191         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
2192         (tui_update_breakpoint_info): Add "being_deleted" parameter.
2193         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2194         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
2195         (tui_update_breakpoint_info): Likewise.
2196         * tui/tui-hooks.c (tui_event_create_breakpoint)
2197         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
2198         Update.
2199
2200 2019-07-17  Tom Tromey  <tom@tromey.com>
2201
2202         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
2203
2204 2019-07-17  Tom Tromey  <tom@tromey.com>
2205
2206         * tui/tui-winsource.c (tui_update_source_window_as_is)
2207         (tui_update_source_windows_with_addr): Update.
2208         * tui/tui-source.h (tui_set_source_content)
2209         (tui_show_symtab_source): Add "win_info" parameter.
2210         * tui/tui-source.c (tui_set_source_content): Add "win_info"
2211         parameter.
2212         (tui_show_symtab_source): Likewise.
2213
2214 2019-07-17  Tom Tromey  <tom@tromey.com>
2215
2216         * tui/tui-wingeneral.c
2217         (tui_check_and_display_highlight_if_needed): Check can_highlight.
2218
2219 2019-07-17  Tom Tromey  <tom@tromey.com>
2220
2221         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
2222         (struct tui_cmd_window) <can_scroll>: New method.
2223         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
2224         method.
2225
2226 2019-07-17  Tom Tromey  <tromey@adacore.com>
2227
2228         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
2229         do_field_signed>: Rename.  Change type of "value".
2230         * ui-out.c (ui_out::field_signed): Rename from field_int.
2231         Change type of "value".
2232         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
2233         type of "value".
2234         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
2235         do_field_int.  Change type of "value".
2236         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
2237         do_field_int.  Change type of "value".
2238         * tracepoint.c (trace_status_mi, tfind_1)
2239         (print_one_static_tracepoint_marker): Update.
2240         * thread.c (print_thread_info_1, print_selected_thread_frame):
2241         Update.
2242         * stack.c (print_frame, print_frame_info): Update.
2243         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
2244         Update.
2245         * source.c (print_source_lines_base): Update.
2246         * skip.c (info_skip_command): Update.
2247         * record-btrace.c (btrace_ui_out_decode_error)
2248         (btrace_call_history_src_line): Update.
2249         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
2250         Update.
2251         * progspace.c (print_program_space): Update.
2252         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
2253         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
2254         do_field_int.  Change type of "value".
2255         * mi/mi-out.c (mi_ui_out::do_table_begin)
2256         (mi_ui_out::do_table_header): Update.
2257         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
2258         type of "value".
2259         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
2260         (mi_cmd_data_list_changed_registers, output_register)
2261         (mi_cmd_data_read_memory, mi_load_progress)
2262         (mi_cmd_trace_frame_collected): Update.
2263         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
2264         Update.
2265         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
2266         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
2267         (mi_cmd_var_list_children, varobj_update_one): Update.
2268         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
2269         (mi_cmd_stack_list_args, list_arg_or_local): Update.
2270         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
2271         * inferior.c (print_inferior): Update.
2272         * gdb_bfd.c (print_one_bfd): Update.
2273         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2274         Update.
2275         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
2276         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
2277         do_field_int.  Change type of "value".
2278         * cli-out.c (cli_ui_out::do_field_signed): Rename from
2279         do_field_int.  Change type of "value".
2280         * breakpoint.c (watchpoint_check, print_breakpoint_location)
2281         (print_one_breakpoint_location, print_it_catch_fork)
2282         (print_one_catch_fork, print_it_catch_vfork)
2283         (print_one_catch_vfork, print_it_catch_solib)
2284         (print_it_catch_exec, print_it_ranged_breakpoint)
2285         (print_mention_watchpoint, print_mention_masked_watchpoint)
2286         (bkpt_print_it, update_static_tracepoint): Update.
2287         * break-catch-throw.c (print_it_exception_catchpoint): Update.
2288         * break-catch-syscall.c (print_it_catch_syscall): Update.
2289         * ada-tasks.c (print_ada_task_info): Update.
2290         * ada-lang.c (print_it_exception, print_mention_exception):
2291         Update.
2292
2293 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2294
2295         PR breakpoints/24541
2296         * gdbarch.c: Regenerate.
2297         * gdbarch.h: Regenerate.
2298         * gdbarch.sh: Adjust return type and parameter types for
2299         'stap_adjust_register'.
2300         (i386_stap_adjust_register): Adjust signature and return new
2301         register name.
2302         * stap-probe.c (stap_parse_register_operand): Adjust use of
2303         'gdbarch_stap_adjust_register'.
2304
2305 2019-07-17  Tom Tromey  <tromey@adacore.com>
2306
2307         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
2308         declare VEC.
2309         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
2310         std::vector.
2311         (struct s390_process_info): Add initializers.
2312         (s390_add_process): Use new.
2313         (s390_linux_nat_target::low_forget_process): Use delete.
2314         (s390_linux_nat_target::low_new_fork)
2315         (s390_linux_nat_target::stopped_by_watchpoint)
2316         (s390_linux_nat_target::low_prepare_to_resume)
2317         (s390_linux_nat_target::insert_watchpoint)
2318         (s390_linux_nat_target::insert_hw_breakpoint)
2319         (s390_linux_nat_target::remove_watchpoint)
2320         (s390_linux_nat_target::remove_hw_breakpoint): Update.
2321
2322 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2323
2324         * aarch64-fbsd-nat.c: Include regcache.h.
2325         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
2326         argument.
2327         (aarch64_fbsd_nat_target::fetch_registers)
2328         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
2329         variable.
2330         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
2331
2332 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2333
2334         * fbsd-nat.c: Include gdbarch.h.
2335
2336 2019-07-15  Tom Tromey  <tromey@adacore.com>
2337
2338         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
2339
2340 2019-07-15  Tom Tromey  <tromey@adacore.com>
2341
2342         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
2343         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
2344         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
2345         * cli-out.c (cli_ui_out::do_field_int): New method.
2346         * ui-out.c (ui_out::field_unsigned): New method.
2347         * symfile.c (generic_load): Use field_unsigned.
2348         (print_transfer_performance): Likewise.
2349         * record-btrace.c (ui_out_field_uint): Remove.
2350         (btrace_call_history_insn_range, btrace_call_history): Use
2351         field_unsigned.
2352         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
2353         field_unsigned.
2354         * ui-out.h (class ui_out) <field_unsigned>: New method.
2355         <do_field_unsigned>: Likewise.
2356
2357 2019-07-15  Tom Tromey  <tromey@adacore.com>
2358
2359         * mi/mi-main.c (list_available_thread_groups): Use field_string.
2360         * mi/mi-interp.c (mi_memory_changed): Use field_string.
2361         * target.c (flash_erase_command): Use field_string.
2362         * infrun.c (print_signal_received_reason): Use field_string.
2363         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
2364         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
2365         field_string.
2366         * ada-tasks.c (print_ada_task_info): Use field_string.
2367
2368 2019-07-15  Tom Tromey  <tromey@adacore.com>
2369
2370         * target.c (flash_erase_command): Use field_core_addr.
2371         * symfile.c (generic_load): Use field_core_addr.
2372         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
2373         Use field_core_addr.
2374         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
2375         field_core_addr.
2376
2377 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2378
2379         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
2380         value if its desired type is smaller than a CORE_ADDR and signed.
2381
2382 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2383
2384         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
2385         of changes to field names, and use new is_reference field to
2386         decide if a property is a reference or not.
2387         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
2388         field.
2389         (struct dwarf2_property_baton): Update header comment, rename
2390         'referenced_type' to 'property_type' and update comments.
2391         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
2392         default property type, store in property baton, update to take
2393         accound of renamed field.
2394         (read_func_scope): Update call to attr_to_dynamic_prop.
2395         (read_array_type): Likewise.
2396         (dwarf2_per_cu_addr_sized_int_type): New function.
2397         (read_subrange_index_type): Move type finding code to
2398         dwarf2_per_cu_addr_sized_int_type.
2399         (read_subrange_type): Update calls to attr_to_dynamic_prop.
2400         (dwarf2_per_cu_addr_type): New function.
2401         (set_die_type): Update calls to attr_to_dynamic_prop.
2402
2403 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2404
2405         * dwarf2read.c (read_subrange_index_type): New function.
2406         (read_subrange_type): Move code into new function and call it.
2407         * gdbtypes.c (create_range_type): Add some asserts.
2408
2409 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2410
2411         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
2412         update return statements.
2413         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
2414         declaration, and update comment to match.
2415         * gdbtypes.c (resolve_dynamic_array): Update call to
2416         dwarf2_evaluate_property to match new return type.
2417
2418 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2419
2420         * valarith.c (value_subscripted_rvalue): Change lowerbound
2421         parameter type from int to LONGEST.
2422         * value.h (value_subscripted_rvalue): Likewise in declaration.
2423
2424 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2425
2426         * cli/cli-utils.c (info_print_command_completer): New function.
2427         * cli/cli-utils.h: Add 'completer.h' include, and forward
2428         declaration for 'struct cmd_list_element'.
2429         (info_print_command_completer): Declare.
2430         * stack.c (_initialize_stack): Add completer for 'info locals' and
2431         'info args'.
2432         * symtab.c (_initialize_symtab): Add completer for 'info
2433         variables' and 'info functions'.
2434         * NEWS: Mention completion for additional info commands.
2435
2436 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2437
2438         * cli/cli-utils.c (extract_info_print_args): Delete.
2439         (extract_arg_maybe_quoted): Delete.
2440         (info_print_options_defs): New variable.
2441         (make_info_print_options_def_group): New function.
2442         (extract_info_print_options): Define new function.
2443         * cli/cli-utils.h (extract_info_print_args): Delete.
2444         (struct info_print_options): New structure.
2445         (extract_info_print_options): Declare new function.
2446         * stack.c (info_locals_command): Update to use new
2447         extract_info_print_options, also add a header comment.
2448         (info_args_command): Likewise.
2449         * symtab.c (info_variables_command): Likewise.
2450         (info_functions_command): Likewise.
2451
2452 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2453
2454         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2455         to extract string arguments.
2456         * common/common-utils.c (extract_string_maybe_quoted): New function.
2457         * common/common-utils.h (extract_string_maybe_quoted): Declare.
2458
2459 2019-07-11  Tom Tromey  <tromey@adacore.com>
2460
2461         * main.c (get_init_files): Use GDBINIT, not gdbinit.
2462         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2463         * top.h (gdbinit): Don't declare.
2464         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2465         into...
2466         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
2467         * top.c (gdb_init): Don't call init_cli_cmds.
2468         (gdbinit): Remove.
2469         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2470
2471 2019-07-11  Tom Tromey  <tromey@adacore.com>
2472
2473         * python/py-inferior.c (add_thread_object): Don't use thread_obj
2474         after it has been moved.
2475
2476 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2477
2478         * valops.c (value_must_coerce_to_target): Change return type to
2479         bool.
2480         * value.h (value_must_coerce_to_target): Likewise.
2481
2482 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
2483
2484         * breakpoint.c (is_hardware_watchpoint): Remove
2485         forward-declaration.
2486         (is_masked_watchpoint): Change return type to bool.
2487         (is_tracepoint): Likewise.
2488         (is_breakpoint): Likewise.
2489         (is_hardware_watchpoint): Likewise.
2490         (is_watchpoint): Likewise.
2491         (is_no_memory_software_watchpoint): Likewise.
2492         (is_catchpoint): Likewise.
2493         (breakpoint_1): Make FILTER parameter's return type bool.
2494         is_masked_watchpoint): Change return type to bool.
2495         (save_breakpoints): Make FILTER parameter's return type bool.
2496         * breakpoint.h (is_breakpoint): Change return type to bool.
2497         (is_watchpoint): Likewise.
2498         (is_catchpoint): Likewise.
2499         (is_tracepoint): Likewise.
2500
2501 2019-07-10  Tom Tromey  <tom@tromey.com>
2502
2503         * defs.h: Don't include gdbarch.h.
2504         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2505         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2506         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2507         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2508         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2509         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2510         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2511         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2512         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2513         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2514         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2515         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2516         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2517         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2518         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2519         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2520         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2521         record-btrace.c, record.h, regcache-dump.c, regcache.h,
2522         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2523         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2524         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2525         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2526         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2527         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2528         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2529         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2530         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2531
2532 2019-07-10  Tom Tromey  <tromey@adacore.com>
2533
2534         * ada-lang.h (is_ada_exception_catchpoint): Declare.
2535         * breakpoint.c (init_ada_exception_breakpoint): Register as
2536         bp_catchpoint.
2537         (print_one_breakpoint_location, print_one_breakpoint): Use
2538         is_ada_exception_catchpoint.
2539         * ada-lang.c (class ada_catchpoint_location): Pass
2540         bp_loc_software_breakpoint to bp_location constructor.
2541         (is_ada_exception_catchpoint): New function.
2542
2543 2019-07-10  Tom Tromey  <tromey@adacore.com>
2544
2545         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
2546         VEC.
2547         (struct arm_exidx_entry): New method operator<.
2548         (struct arm_exidx_data) <section_maps>: Change type.
2549         (arm_exidx_data_free): Remove.
2550         (arm_exidx_data_key): Change type.  Move lower.
2551         (arm_exidx_new_objfile): Update.
2552         (arm_compare_exidx_entries): Remove.
2553         (arm_find_exidx_entry, _initialize_arm_tdep)
2554
2555 2019-07-10  Tom Tromey  <tromey@adacore.com>
2556
2557         * solib-spu.c (ocl_program_data_key): Change type.
2558         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2559         Update.
2560
2561 2019-07-10  Tom Tromey  <tromey@adacore.com>
2562
2563         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
2564         (struct solib_aix_inferior_data) <library_list>: Change type.
2565         (solib_aix_inferior_data_handle): Change type.
2566         (get_solib_aix_inferior_data): Update.
2567         (solib_aix_free_library_list): Remove.
2568         (library_list_start_library): Update.
2569         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2570         return type.
2571         (solib_aix_get_library_list)
2572         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2573         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2574
2575 2019-07-10  Tom Tromey  <tromey@adacore.com>
2576
2577         * solib-dsbt.c (struct dsbt_info): Add initializers.
2578         (solib_dsbt_pspace_data): Change type.
2579         (dsbt_pspace_data_cleanup): Remove.
2580         (get_dsbt_info, _initialize_dsbt_solib): Update.
2581
2582 2019-07-10  Tom Tromey  <tromey@adacore.com>
2583
2584         * spu-tdep.c (spu_overlay_data): Change type.
2585         (spu_get_overlay_table, spu_overlay_new_objfile)
2586         (_initialize_spu_tdep): Update.
2587
2588 2019-07-10  Tom Tromey  <tromey@adacore.com>
2589
2590         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2591         destructor.
2592         (dbx_objfile_data_key): Change type and declare later.
2593         (DBX_SYMFILE_INFO): Rewrite.
2594         * dbxread.c (dbx_objfile_data_key): Change type.
2595         (dbx_symfile_init): Update.
2596         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
2597         (coffstab_build_psymtabs, elfstab_build_psymtabs)
2598         (stabsect_build_psymtabs, _initialize_dbxread): Update.
2599
2600 2019-07-10  Tom Tromey  <tromey@adacore.com>
2601
2602         * jit.c (jit_program_space_key): Change type.  Move lower.
2603         (get_jit_program_space_data): Update.
2604         (jit_program_space_data_cleanup): Remove.
2605         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2606         Update.
2607         (struct jit_program_space_data): Add initializers.
2608
2609 2019-07-10  Tom Tromey  <tromey@adacore.com>
2610
2611         * solib-darwin.c (struct darwin_info): Add initializers.
2612         (solib_darwin_pspace_data): Change type.
2613         (darwin_pspace_data_cleanup): Remove.
2614         (get_darwin_info, _initialize_darwin_solib): Update.
2615
2616 2019-07-10  Tom Tromey  <tromey@adacore.com>
2617
2618         * remote-sim.c (struct sim_inferior_data): Add initializers,
2619         constructor, and destructor.
2620         (sim_inferior_data_key): Change type.  Move lower.
2621         (check_for_duplicate_sim_descriptor): Update.
2622         (get_sim_inferior_data): Use new.  Update.
2623         (~sim_inferior_data_cleanup): Rename from
2624         sim_inferior_data_cleanup.  Simplify.
2625         (gdbsim_close_inferior, simulator_command)
2626         (sim_command_completer, _initialize_remote_sim): Update.
2627         (next_pid, INITIAL_PID): Move earlier.
2628
2629 2019-07-10  Tom Tromey  <tromey@adacore.com>
2630
2631         * python/python-internal.h (create_thread_object): Return
2632         gdbpy_ref.
2633         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2634         * python/py-inferior.c (struct threadlist_entry): Add
2635         constructor.
2636         <thread_obj>: Now a gdbpy_ref.
2637         (thread_to_thread_object): Update.
2638         (add_thread_object): Use new.
2639         (delete_thread_object): Use delete.
2640         (infpy_threads): Update.
2641         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
2642         GIL.
2643
2644 2019-07-10  Tom Tromey  <tromey@adacore.com>
2645
2646         * valops.c (value_cast): Specialize error message for Ada.
2647
2648 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2649
2650         * breakpoint.c (breakpoint_1): Update doc and parameter names.
2651
2652 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2653
2654         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2655         bpstat_should_step): Return bool, adjust comments.
2656         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2657         bpstat_should_step): Likewise.
2658
2659 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2660
2661         * features/Makefile: Use feature target descriptions for Arm.
2662         * features/arm/arm-core.c: Generate new file.
2663         * features/arm/arm-fpa.c: Likewise.
2664         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2665         * features/arm/arm-m-profile.c: Likewise.
2666         * features/arm/arm-vfpv2.c: Likewise.
2667         * features/arm/arm-vfpv3.c: Likewise.
2668         * features/arm/xscale-iwmmxt.c: Likewise.
2669         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2670
2671 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2672
2673         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2674         ptrace earlier.
2675
2676 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2677
2678         * features/aarch64-pauth.c: Regenerate.
2679
2680 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2681
2682         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2683         bool.
2684         (bpstat_what): Use false instead of 0.
2685
2686 2019-07-09  Pedro Alves  <palves@redhat.com>
2687
2688         * break-catch-throw.c (is_exception_catchpoint): New.
2689         * breakpoint.c (print_one_breakpoint_location): New parameter
2690         'raw_loc'.  Handle it.  Use
2691         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2692         looking at the breakpoint's type.
2693         (print_one_breakpoint): If handling "maint info breakpoints", also
2694         print locations of exception catchpoints.
2695         * breakpoint.h (is_exception_catchpoint): Declare.
2696
2697 2019-07-09  Pedro Alves  <palves@redhat.com>
2698
2699         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2700         "addr" field.
2701         (allocate_location_exception_catchpoint): New.
2702         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2703         (initialize_throw_catchpoint_ops): Install
2704         allocate_location_exception_catchpoint as allocate_location
2705         method.
2706         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2707         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2708         bp_loc_other.
2709         (breakpoint_address_is_meaningful): Delete.
2710         (bl_address_is_meaningful): New.
2711         (breakpoint_locations_match): Adjust comment.
2712         (bp_location_from_bp_type): New, factored out of...
2713         (bp_location::bp_location(breakpoint *)): ... this.
2714         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2715         factored out of...
2716         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2717         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2718         breakpoint_address_is_meaningful.
2719         (bp_locations_compare): Adjust comment.
2720         (update_global_location_list): Use bl_address_is_meaningful
2721         instead of breakpoint_address_is_meaningful.
2722         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2723         explicit.
2724         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2725         * python/py-breakpoint.c (bppy_get_location): No longer check
2726         whether location is null.
2727
2728 2019-07-09  Pedro Alves  <palves@redhat.com>
2729
2730         PR c++/15468
2731         * breakpoint.c (print_one_breakpoint_location): Remove
2732         single-location assert.
2733
2734 2019-07-09  Tom Tromey  <tom@tromey.com>
2735
2736         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2737         * configure: Rebuild.
2738         * configure.ac: Change common to gdbsupport.
2739         * gdbsupport: Rename from common.
2740         * acinclude.m4: Change common to gdbsupport.
2741         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2742         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2743         gdbsupport.
2744         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2745         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2746         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2747         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2748         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2749         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2750         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2751         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2752         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2753         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2754         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2755         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2756         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2757         coff-pe-read.c, command.h, compile/compile-c-support.c,
2758         compile/compile-c.h, compile/compile-cplus-symbols.c,
2759         compile/compile-cplus-types.c, compile/compile-cplus.h,
2760         compile/compile-loc2c.c, compile/compile.c, completer.c,
2761         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2762         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2763         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2764         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2765         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2766         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2767         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2768         features/aarch64-core.c, features/aarch64-fpu.c,
2769         features/aarch64-pauth.c, features/aarch64-sve.c,
2770         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2771         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2772         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2773         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2774         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2775         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2776         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2777         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2778         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2779         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2780         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2781         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2782         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2783         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2784         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2785         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2786         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2787         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2788         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2789         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2790         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2791         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2792         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2793         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2794         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2795         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2796         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2797         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2798         minsyms.c, mips-linux-tdep.c, namespace.h,
2799         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2800         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2801         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2802         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2803         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2804         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2805         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2806         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2807         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2808         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2809         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2810         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2811         procfs.c, producer.c, progspace.h, psymtab.h,
2812         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2813         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2814         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2815         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2816         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2817         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2818         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2819         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2820         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2821         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2822         target-memory.c, target.c, target.h, target/waitstatus.c,
2823         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2824         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2825         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2826         unittests/array-view-selftests.c,
2827         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2828         unittests/common-utils-selftests.c,
2829         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2830         unittests/format_pieces-selftests.c,
2831         unittests/function-view-selftests.c,
2832         unittests/lookup_name_info-selftests.c,
2833         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2834         unittests/mkdir-recursive-selftests.c,
2835         unittests/observable-selftests.c,
2836         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2837         unittests/parse-connection-spec-selftests.c,
2838         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2839         unittests/scoped_fd-selftests.c,
2840         unittests/scoped_mmap-selftests.c,
2841         unittests/scoped_restore-selftests.c,
2842         unittests/string_view-selftests.c, unittests/style-selftests.c,
2843         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2844         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2845         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2846         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2847         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2848         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2849
2850 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2851
2852         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2853         bool value.
2854         (decode_digits_ordinary): Set explicit_line field in sal.
2855         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2856         symtab_and_line that was set on an explicit line number in
2857         assembler code.  Do always update the recorded symtab and line if
2858         we do skip the prologue.
2859
2860 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2861
2862         * breakpoint.c (set_breakpoint_location_function): Remove
2863         explicit_loc parameter.
2864         (momentary_breakpoint_from_master): Update call to
2865         set_breakpoint_location_function.
2866         (add_location_to_breakpoint): Likewise.
2867
2868 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2869
2870         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2871         required features based on default bfd type when no specific bfd
2872         is present.
2873
2874 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2875
2876         * NEWS: Mention that GDB printf and eval commands can now print
2877         C-style and Ada-style convenience var strings without
2878         calling the inferior.
2879         * printcmd.c (printf_c_string): Locally print GDB internal var
2880         instead of transiting via the inferior.
2881         (printf_wide_c_string): Likewise.
2882
2883 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2884
2885         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2886
2887 2019-07-04  Tom Tromey  <tom@tromey.com>
2888
2889         PR tui/24724:
2890         * tui/tui-winsource.c (tui_clear_source_content): Update.
2891         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2892         (tui_update_breakpoint_info): Update.
2893         (tui_set_exec_info_content): Update.
2894         * tui/tui-source.c (tui_set_source_content_nil): Update.
2895         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2896         has_break.
2897         * tui/tui-data.h (enum tui_bp_flag): New.
2898         (tui_bp_flags): New enum flags type.
2899         (struct tui_source_element) <break_mode>: Change type.  Rename
2900         from has_break.
2901         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2902         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2903         constants.
2904         * tui/tui-winsource.h: Fix comment.
2905
2906 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2907
2908         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2909         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2910         (store_fpregs_to_thread)
2911         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2912         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2913         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2914         (IWMMXT_REGS_SIZE): Add define.
2915         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2916         (fetch_vfp_regs, store_vfp_regs)
2917         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2918         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2919
2920 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2921
2922         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2923         defines.
2924         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2925         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2926         (ARM_INT_REGISTER_SIZE): ...to this.
2927         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2928         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2929         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2930         (arm_linux_collect_gregset, supply_nwfpe_register)
2931         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2932         defines.
2933         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2934         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2935         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2936         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2937         (arm_return_in_memory, arm_store_return_value)
2938         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2939         (arm_record_ld_st_multiple): Likewise.
2940         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2941         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2942
2943 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2944
2945         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2946         AARCH64_DISPLACED_MODIFIED_INSNS.
2947         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2948         (aarch64_displaced_step_copy_insn): Likewise.
2949         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2950         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2951         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2952         ARM_DISPLACED_MODIFIED_INSNS.
2953         * arm-tdep.c (arm_gdbarch_init): Likewise.
2954         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2955         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2956         (struct arm_displaced_step_closure): Use
2957         ARM_DISPLACED_MODIFIED_INSNS.
2958
2959 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2960
2961         * features/Makefile: Remove unused xml files.
2962         * features/aarch64.xml: Remove.
2963         * features/i386/amd64-avx-avx512-linux.xml: Remove.
2964         * features/i386/amd64-avx-avx512.xml: Remove.
2965         * features/i386/amd64-avx-linux.xml: Remove.
2966         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2967         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2968         * features/i386/amd64-avx-mpx-linux.xml: Remove.
2969         * features/i386/amd64-avx-mpx.xml: Remove.
2970         * features/i386/amd64-avx.xml: Remove.
2971         * features/i386/amd64-linux.xml: Remove.
2972         * features/i386/amd64-mpx-linux.xml: Remove.
2973         * features/i386/amd64-mpx.xml: Remove.
2974         * features/i386/amd64.xml: Remove.
2975         * features/i386/i386-avx-avx512-linux.xml: Remove.
2976         * features/i386/i386-avx-avx512.xml: Remove.
2977         * features/i386/i386-avx-linux.xml: Remove.
2978         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2979         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2980         * features/i386/i386-avx-mpx-linux.xml: Remove.
2981         * features/i386/i386-avx-mpx.xml: Remove.
2982         * features/i386/i386-avx.xml: Remove.
2983         * features/i386/i386-linux.xml: Remove.
2984         * features/i386/i386-mmx-linux.xml: Remove.
2985         * features/i386/i386-mmx.xml: Remove.
2986         * features/i386/i386-mpx-linux.xml: Remove.
2987         * features/i386/i386-mpx.xml: Remove.
2988         * features/i386/i386.xml: Remove.
2989         * features/i386/x32-avx-avx512-linux.xml: Remove.
2990         * features/i386/x32-avx-linux.xml: Remove.
2991         * features/i386/x32-linux.xml: Remove.
2992
2993 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2994
2995         * regformats/aarch64.dat: Remove.
2996         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2997         * regformats/i386/amd64-avx-linux.dat: Remove.
2998         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2999         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
3000         * regformats/i386/amd64-linux.dat: Remove.
3001         * regformats/i386/amd64-mpx-linux.dat: Remove.
3002         * regformats/i386/amd64.dat: Remove.
3003         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
3004         * regformats/i386/i386-avx-linux.dat: Remove.
3005         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
3006         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
3007         * regformats/i386/i386-linux.dat: Remove.
3008         * regformats/i386/i386-mmx-linux.dat: Remove.
3009         * regformats/i386/i386-mpx-linux.dat: Remove.
3010         * regformats/i386/i386.dat: Remove.
3011         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
3012         * regformats/i386/x32-avx-linux.dat: Remove.
3013         * regformats/i386/x32-linux.dat: Remove.
3014
3015 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3016
3017         * aarch64-tdep.c: Remove xml self tests.
3018         * amd64-linux-tdep.c: Likewise.
3019         * amd64-tdep.c: Likewise.
3020         * i386-linux-tdep.c: Likewise.
3021         * i386-tdep.c: Likewise.
3022
3023 2019-07-03  Pedro Alves  <palves@redhat.com>
3024
3025         PR cli/24732
3026         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
3027         (pipe_cmd_option_defs): New.
3028         (make_pipe_cmd_options_def_group): New.
3029         (pipe_command): Use gdb::option::process_options.
3030         (pipe_command_completer): New function.
3031         (_initialize_cli_cmds): Install completer for "pipe" command.
3032
3033 2019-07-03  Pedro Alves  <palves@redhat.com>
3034
3035         * cli/cli-option.c (union option_value) <string>: New field.
3036         (struct option_def_and_value): Add ctor, move ctor, dtor and
3037         use DISABLE_COPY_AND_ASSIGN.
3038         (option_def_and_value::clear_value): New.
3039         (parse_option, save_option_value_in_ctx, get_val_type_str)
3040         (add_setshow_cmds_for_options): Handle var_string.
3041         * cli-option.h (union option_def::var_address) <string>: New
3042         field.
3043         (struct string_option_def): New.
3044         * maint-test-options.c (struct test_options_opts): Add default
3045         ctor and use DISABLE_COPY_AND_ASSIGN.
3046         <string_opt>: New field.
3047         (test_options_opts::~test_options_opts): New.
3048         (test_options_opts::dump): Also dump "-string".
3049         (test_options_option_defs): Install "string.
3050
3051 2019-07-03  Pedro Alves  <palves@redhat.com>
3052
3053         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
3054         option_value with a null enumeration.
3055         (complete_options): Save the option values in the context.
3056         (save_option_value_in_ctx): New, factored out from ...
3057         (process_options): ... here.
3058         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
3059         of the function.
3060         * maint-test-options.c (test_options_opts::dump): New, factored
3061         out from ...
3062         (maintenance_test_options_command_mode): ... here.
3063         (maintenance_test_options_command_completion_result): Delete.
3064         (maintenance_test_options_command_completion_text): Update
3065         comment.
3066         (maintenance_show_test_options_completion_result): Change
3067         prototype.  Just print
3068         maintenance_test_options_command_completion_text.
3069         (save_completion_result): New.
3070         (maintenance_test_options_completer_mode): Pass options context to
3071         complete_options, and then save a dump.
3072         (_initialize_maint_test_options): Use add_cmd to install "maint
3073         show test-options-completion-result".
3074
3075 2019-07-03  Pedro Alves  <palves@redhat.com>
3076
3077         * NEWS (New commands): Mention "with" and "maint with".
3078         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
3079         (with_command, with_command_completer): New.
3080         (pipe_command): Adjust to new repeat_previous
3081         interface.
3082         (_initialize_cli_cmds): Install the "with" command and its "w"
3083         alias.
3084         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
3085         declarations.
3086         * cli/cli-setshow.c (parse_cli_var_uinteger)
3087         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
3088         argument strings for all var_types.
3089         (get_setshow_command_value_string): New, factored out from ...
3090         (do_show_command): ... this.
3091         * cli/cli-setshow.h: Include <string>.
3092         (get_setshow_command_value_string): Declare.
3093         * command.h (repeat_previous): Now returns const char *.  Adjust
3094         comment.
3095         * maint.c: Include "cli/cli-cmds.h".
3096         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
3097         (_initialize_maint_cmds): Register the "maintenance with" command.
3098         * top.c (repeat_previous): Move bits from pipe_command here:
3099         Return the saved command line, if any; error out if there's no
3100         command to relaunch.
3101
3102 2019-07-03  Pedro Alves  <palves@redhat.com>
3103
3104         * NEWS (New commands): Mention "maint set/show test-settings"
3105         instead of "maint test-settings".
3106         * maint-test-settings.c (maintenance_test_settings_list): Delete.
3107         (maintenance_test_settings_set_list): Rename to ...
3108         (maintenance_set_test_settings_list): ... this.
3109         (maintenance_test_settings_show_list): Rename to  ...
3110         (maintenance_show_test_settings_list): ... this.
3111         (maintenance_test_settings_cmd): Delete.
3112         (maintenance_test_settings_set_cmd): ...
3113         (maintenance_set_test_settings_cmd): ... this.
3114         (maintenance_test_settings_show_cmd): ...
3115         (maintenance_show_test_settings_cmd): ... this.
3116         (maintenance_test_settings_show_value_cmd):
3117         (maintenance_show_test_settings_value_cmd): ... this.
3118         (_initialize_maint_test_settings): No longer install the "maint
3119         test-settings" prefix command.  Rename "maint test-settings set"
3120         to "maint set test-settings", and "maint test-settings show" to
3121         "maint show test-settings".  Adjust all subcommands.
3122
3123 2019-07-03  Pedro Alves  <palves@redhat.com>
3124
3125         * maint-test-settings.c: Fix file's intro comment.  Replace all
3126         references to "test-options" with references to "test-settings",
3127         in comments.
3128
3129 2019-07-03  Pedro Alves  <palves@redhat.com>
3130
3131         * maint-test-settings.c (maintenance_test_settings_xxx)
3132         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
3133         New.
3134         (maintenance_test_settings_enums): Use them.
3135         (maintenance_test_settings_enum): Default to
3136         maintenance_test_settings_xxx.
3137         (_initialize_maint_test_settings): Initialize
3138         MAINTENANCE_TEST_SETTINGS_FILENAME.
3139
3140 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3141
3142         * breakpoint.h (remove_breakpoints_inf): Change return type to
3143         void, move function documentation here.
3144         * breakpoint.c (remove_breakpoints_inf): Change return type to
3145         void, move function documentation to header.
3146
3147 2019-07-02  Pedro Alves  <palves@redhat.com>
3148
3149         * NEWS (Completion improvements): Mention "info threads".
3150         * thread.c (struct info_threads_opts, info_threads_option_defs)
3151         (make_info_threads_options_def_group): New.
3152         (info_threads_command): Use gdb::option::process_options.
3153         (info_threads_command_completer): New.
3154         (_initialize_thread): Use gdb::option::build_help to build the
3155         help text for "info threads".
3156
3157 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3158
3159         * defs.h (generic_load): Move from here...
3160         * symfile.h (generic_load): ... to here.  Rename name parameter
3161         to args.
3162         * symfile.c (generic_load): Add comment.
3163
3164 2019-07-01  Tom Tromey  <tromey@adacore.com>
3165
3166         * dwarf2read.c
3167         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
3168         declaration of without_params.  Fix formatting.
3169
3170 2019-07-01  Tom Tromey  <tromey@adacore.com>
3171
3172         * ada-exp.y (find_primitive_type): Update.
3173         * ada-lang.h (ada_lookup_symbol): Update.
3174         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
3175         parameter.
3176         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
3177
3178 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3179
3180         PR breakpoints/24541
3181         * gdbarch.c: Regenerate.
3182         * gdbarch.h: Regenerate.
3183         * gdbarch.sh: Add 'stap_adjust_register'.
3184         * i386-tdep.c: Include '<unordered_set>'.
3185         (i386_stap_adjust_register): New function.
3186         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
3187         * stap-probe.c (stap_parse_register_operand): Call
3188         'gdbarch_stap_adjust_register'.
3189
3190 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3191
3192         PR python/24742
3193         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
3194         * python/python.c (do_start_initialization): Use 'xmalloc'
3195         instead of 'PyMem_Malloc'.
3196
3197 2019-06-28  Tom Tromey  <tromey@adacore.com>
3198
3199         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
3200         for Ada.
3201
3202 2019-06-27  Tom Tromey  <tromey@adacore.com>
3203
3204         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
3205         objfile_key.
3206         (arm_find_mapping_symbol, arm_record_special_symbol)
3207         (_initialize_arm_tdep): Update.
3208         (arm_objfile_data_free): Remove.
3209
3210 2019-06-27  Tom Tromey  <tromey@adacore.com>
3211
3212         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
3213         to cp_print_static_field.
3214
3215 2019-06-26  Tom Tromey  <tromey@adacore.com>
3216
3217         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
3218         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
3219         declare.
3220
3221 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3222
3223         * features/aarch64-core.c (create_feature_aarch64_core):
3224         Regenerate.
3225         * features/aarch64-core.xml: Add cpsr flags.
3226
3227 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3228
3229         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
3230         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
3231
3232 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3233
3234         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
3235         field.
3236         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
3237         use.
3238         (arm_record_special_symbol): Don't insert new symbol in sorted
3239         position, push it at the end.
3240
3241 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3242
3243         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
3244         (arm_mapping_symbol_s): Remove.
3245         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
3246         (arm_mapping_symbol_vec): New typedef.
3247         (struct arm_per_objfile): Add constructor.
3248         <section_maps>: Change type to
3249         std::unique_ptr<arm_mapping_symbol_vec[]>.
3250         (arm_compare_mapping_symbols): Remove.
3251         (arm_find_mapping_symbol): Adjust to section_maps type change.
3252         (arm_objfile_data_free): Call delete on arm_per_objfile.
3253         (arm_record_special_symbol): Adjust to section_maps type change.
3254         Allocate arm_per_objfile with new.
3255
3256 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3257
3258         * cli/cli-cmds.c (alias_command): Compare the alias prefix
3259         with the command prefix.
3260
3261 2019-06-25  Tom Tromey  <tom@tromey.com>
3262
3263         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
3264         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
3265
3266 2019-06-25  Tom Tromey  <tom@tromey.com>
3267
3268         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
3269         type.
3270         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
3271         protected.
3272
3273 2019-06-25  Tom Tromey  <tom@tromey.com>
3274
3275         * tui/tui-winsource.c
3276         (tui_source_window_base::set_is_exec_point_at): Add check against
3277         LOA_ADDRESS.
3278
3279 2019-06-25  Tom Tromey  <tom@tromey.com>
3280
3281         * tui/tui-source.c (tui_set_source_content): Don't check before
3282         xfree.
3283         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
3284
3285 2019-06-25  Tom Tromey  <tom@tromey.com>
3286
3287         * tui/tui-winsource.h (tui_update_source_window_as_is)
3288         (tui_alloc_source_buffer, tui_line_is_displayed)
3289         (tui_addr_is_displayed): Change type of win_info.
3290         * tui/tui-winsource.c (tui_update_source_window_as_is)
3291         (tui_clear_source_content, tui_show_source_line)
3292         (tui_show_source_content, tui_source_window_base::refill)
3293         (tui_source_window_base::set_is_exec_point_at)
3294         (tui_source_window_base::set_is_exec_point_at)
3295         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
3296         (tui_alloc_source_buffer, tui_line_is_displayed)
3297         (tui_addr_is_displayed): Change type of win_info.  Update.
3298         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3299         (tui_source_window_base::do_make_visible_with_new_height):
3300         Update.
3301         * tui/tui-source.c (tui_set_source_content)
3302         (tui_set_source_content_nil)
3303         (tui_source_window::do_scroll_vertical): Update.
3304         * tui/tui-layout.c (show_layout): Update.
3305         * tui/tui-disasm.c (tui_set_disassem_content)
3306         (tui_disasm_window::do_scroll_vertical): Update.
3307         * tui/tui-data.h (tui_win_content): Remove.
3308         (struct tui_gen_win_info) <content, content_size>: Remove.
3309         (struct tui_source_element): Add initializers and destructor.
3310         (union tui_which_element, struct tui_win_element): Remove.
3311         (struct tui_source_window_base) <content>: New field.
3312         (struct tui_data_window): Remove destructor.
3313         (tui_alloc_content, tui_free_win_content)
3314         (tui_free_all_source_wins_content): Don't declare.
3315         * tui/tui-data.c (tui_initialize_static_data): Update.
3316         (init_content_element, tui_alloc_content): Remove.
3317         (~tui_gen_win_info): Update.
3318         (~tui_data_window, tui_free_all_source_wins_content)
3319         (tui_free_win_content, free_content, free_content_elements):
3320         Remove.
3321
3322 2019-06-25  Tom Tromey  <tom@tromey.com>
3323
3324         * tui/tui-winsource.h (tui_clear_source_content)
3325         (tui_erase_source_content, tui_show_source_content): Change type
3326         of win_info.
3327         * tui/tui-winsource.c (tui_clear_source_content)
3328         (tui_erase_source_content, tui_show_source_content): Change type
3329         of win_info.
3330         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3331         * tui/tui-source.h (tui_set_source_content_nil): Change type of
3332         win_info.
3333         * tui/tui-source.c (tui_set_source_content_nil): Change type of
3334         win_info.
3335         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
3336
3337 2019-06-25  Tom Tromey  <tom@tromey.com>
3338
3339         * tui/tui-winsource.c (tui_clear_source_content)
3340         (tui_source_window_base::set_is_exec_point_at): Update.
3341         * tui/tui-source.c (tui_set_source_content_nil): Update.
3342         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
3343         a bool.
3344         * tui/tui-data.c (init_content_element): Update.
3345
3346 2019-06-25  Tom Tromey  <tom@tromey.com>
3347
3348         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
3349         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
3350         * tui/tui-layout.c (init_and_make_win): Update.
3351         * tui/tui.h (enum tui_win_type): Update.
3352         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
3353         tui_win_is_auxillary.
3354         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
3355         tui_win_is_auxillary.
3356
3357 2019-06-25  Tom Tromey  <tom@tromey.com>
3358
3359         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
3360         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
3361         (tui_delete_data_content_windows, tui_display_all_data)
3362         (tui_data_window::do_scroll_vertical, tui_display_data_from):
3363         Update.
3364         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
3365         * tui/tui-regs.c (tui_last_regs_line_no)
3366         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3367         (tui_show_registers): Update.
3368         (tui_show_register_group): Return void.  Update.
3369         (tui_display_registers_from, tui_display_reg_element_at_line)
3370         (tui_display_registers_from_line, tui_check_register_values):
3371         Update.
3372         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
3373         member.
3374         (struct tui_data_window) <regs_content>: Now a std::vector.
3375         <regs_content_count>: Remove.
3376         (tui_add_content_elements, tui_free_data_content): Don't declare.
3377         * tui/tui-data.c (tui_data_window::clear_detail): Update.
3378         (init_content_element): Remove DATA_WIN case.  Add assert.
3379         (tui_add_content_elements): Remove.
3380         (tui_data_window): Update.
3381         (tui_free_data_content): Remove.
3382         (free_content_elements): Remove DATA_WIN case.
3383
3384 2019-06-25  Tom Tromey  <tom@tromey.com>
3385
3386         * tui/tui-data.c (tui_data_item_window): Update.
3387         * tui/tui-windata.h (tui_check_data_values): Don't declare.
3388         * tui/tui-windata.c (tui_display_all_data)
3389         (tui_display_data_from_line): Update.
3390         (tui_check_data_values): Remove.
3391         * tui/tui-regs.c (tui_show_register_group)
3392         (tui_display_reg_element_at_line): Update.
3393         * tui/tui-hooks.c (tui_register_changed)
3394         (tui_refresh_frame_and_register_information): Call
3395         tui_check_register_values.
3396         * tui/tui-data.h (struct tui_data_window) <data_content,
3397         data_content_count, data_type>: Remove.
3398         (enum tui_data_type): Remove.
3399
3400         * tui/tui-data.c (tui_data_window::clear_detail)
3401         (~tui_data_window): Update.
3402
3403 2019-06-25  Tom Tromey  <tom@tromey.com>
3404
3405         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
3406         declare.
3407         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
3408         Rename from tui_first_data_item_displayed.  Update.
3409         (tui_data_window::refresh_all)
3410         (tui_data_window::do_scroll_vertical): Update.
3411         * tui/tui-data.h (struct tui_data_window)
3412         <first_data_item_displayed>: Declare new method.
3413
3414 2019-06-25  Tom Tromey  <tom@tromey.com>
3415
3416         * tui/tui-data.h (tui_init_generic_part): Don't declare.
3417         * tui/tui-data.c (tui_init_generic_part): Remove, moving
3418         contents...
3419         (tui_initialize_static_data): ...here.
3420
3421 2019-06-25  Tom Tromey  <tom@tromey.com>
3422
3423         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3424         (tui_display_registers_from, tui_check_register_values): Update.
3425         (tui_display_register): Remove win_info parameter; update.
3426         (tui_get_register): Change type of parameters.
3427         * tui/tui-data.h (struct tui_data_element): Remove.
3428         (union tui_which_element) <data>: Remove.
3429         <data_window>: Change type.
3430         (struct tui_data_item_window): New.
3431         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3432         case.  Add assert.
3433         (~tui_data_item_window): New destructor.
3434         (free_content_elements): Remove DATA_ITEM_WIN case.
3435
3436 2019-06-25  Tom Tromey  <tom@tromey.com>
3437
3438         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3439         Remove.
3440
3441 2019-06-25  Tom Tromey  <tom@tromey.com>
3442
3443         * tui/tui-data.h (struct tui_command_element): Remove.
3444         (union tui_which_element) <command>: Remove.
3445         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
3446         assert.
3447         (free_content_elements): Remove CMD_WIN case.
3448
3449 2019-06-25  Tom Tromey  <tom@tromey.com>
3450
3451         * tui/tui-layout.c (tui_set_layout): Update.
3452         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3453         * tui/tui-data.c (layout_def): Update.
3454
3455 2019-06-25  Tom Tromey  <tom@tromey.com>
3456
3457         * tui/tui-wingeneral.c (tui_refresh_all): Update.
3458         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3459         (tui_source_window_base::set_new_height): Update.
3460         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3461         Update.
3462         (tui_set_locator_fullname, tui_set_locator_info)
3463         (tui_show_frame_info): Update.
3464         * tui/tui-source.c (tui_set_source_content)
3465         (tui_source_is_displayed): Update.
3466         * tui/tui-layout.c (show_source_disasm_command, show_data)
3467         (show_source_or_disasm_and_command): Update.
3468         * tui/tui-disasm.c (tui_set_disassem_content)
3469         (tui_get_begin_asm_address): Update.
3470         * tui/tui-data.h (struct tui_locator_element): Remove.
3471         (union tui_which_element) <locator>: Remove.
3472         (struct tui_locator_window): New.
3473         (tui_locator_win_info_ptr): Change return type.
3474         * tui/tui-data.c (_locator): Change type.
3475         (tui_locator_win_info_ptr): Change return type.
3476         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
3477         (tui_alloc_content): Add assert.
3478
3479 2019-06-25  Tom Tromey  <tom@tromey.com>
3480
3481         * tui/tui-winsource.c
3482         (tui_exec_info_window::maybe_allocate_content): New method.
3483         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3484         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3485         (make_source_or_disasm_window): Add cast.
3486         * tui/tui-data.h (union tui_which_element) <simple_string>:
3487         Remove.
3488         (struct tui_source_info): New.
3489         (struct tui_source_window_base) <execution_info>: Change type.
3490         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3491         case, and add assert.
3492         (tui_alloc_content): Add assert.
3493
3494 2019-06-25  Tom Tromey  <tom@tromey.com>
3495
3496         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3497         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3498         * tui/tui-data.c (tui_alloc_win_info): Remove.
3499
3500 2019-06-25  Tom Tromey  <tom@tromey.com>
3501
3502         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3503         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3504         can_highlight.
3505
3506 2019-06-25  Tom Tromey  <tom@tromey.com>
3507
3508         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3509         make_visible_with_new_height method.
3510         (tui_win_info::make_visible_with_new_height): New method.
3511         (tui_source_window_base::do_make_visible_with_new_height)
3512         (tui_data_window::do_make_visible_with_new_height)
3513         (tui_cmd_window::do_make_visible_with_new_height): New methods.
3514         (make_visible_with_new_height): Remove.
3515         (tui_resize_all, tui_adjust_win_heights): Use
3516         make_visible_with_new_height method.
3517         * tui/tui-data.h (struct tui_win_info)
3518         <do_make_visible_with_new_height, make_visible_with_new_height>:
3519         New methods.
3520         (struct tui_source_window_base, struct tui_data_window)
3521         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3522         methods.
3523
3524 2019-06-25  Tom Tromey  <tom@tromey.com>
3525
3526         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3527         method.
3528         (update_tab_width): Call update_tab_width method.
3529         * tui/tui-data.h (struct tui_win_info)
3530         (struct tui_source_window_base) <update_tab_width>: New methods.
3531
3532 2019-06-25  Tom Tromey  <tom@tromey.com>
3533
3534         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3535         parameter.
3536         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3537         parameter.
3538         (tui_gen_win_info::make_visible): Update.
3539         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3540         parameter.
3541         * tui/tui-data.h (enum tui_box): New enum.
3542         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3543
3544 2019-06-25  Tom Tromey  <tom@tromey.com>
3545
3546         * tui/tui-layout.c (make_source_or_disasm_window): Always use
3547         init_and_make_win for EXEC_INFO_WIN.
3548         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3549         longer inline.
3550         (struct tui_win_info) <~tui_win_info>: Inline.
3551         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3552         Don't declare.
3553         * tui/tui-data.c (source_win, disasm_win): Remove globals.
3554         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3555         Remove.
3556         (tui_initialize_static_data): Update.
3557         (~tui_gen_win_info): Handle more cleanup here.
3558         (~tui_source_window_base): Delete "execution_info".
3559         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3560
3561 2019-06-25  Tom Tromey  <tom@tromey.com>
3562
3563         * tui/tui-layout.c (make_command_window): Don't set
3564         can_highlight.
3565         (show_source_disasm_command): Call the reset method.
3566         (show_data): Don't set can_highlight.  Call the reset method.
3567         (tui_gen_win_info::reset): Rename from init_gen_win_info
3568         (init_and_make_win): Simplify.  Return tui_gen_win_info.
3569         (show_source_or_disasm_and_command): Call the reset method.
3570         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3571         (struct tui_cmd_window): Set can_highlight.
3572
3573 2019-06-25  Tom Tromey  <tom@tromey.com>
3574
3575         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3576         from make_visible.
3577         (tui_make_visible, tui_make_invisible): Rewrite.
3578         (tui_win_info::make_visible): Remove.
3579         (tui_source_window_base::make_visible): Update.
3580         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3581         method.  Moved from...
3582         (struct tui_win_info) <make_visible>: ...here.
3583
3584 2019-06-25  Tom Tromey  <tom@tromey.com>
3585
3586         * tui/tui-winsource.c
3587         (tui_source_window_base::do_scroll_horizontal): Remove direction
3588         parameter.
3589         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3590         direction parameter.
3591         * tui/tui-win.c (tui_win_info::forward_scroll)
3592         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3593         (tui_win_info::right_scroll): Update.
3594         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3595         direction parameter.
3596         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3597         direction parameter.
3598         * tui/tui-data.h (enum tui_scroll_direction): Remove.
3599         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3600         Remove direction parameter.
3601         (struct tui_source_window_base, struct tui_source_window)
3602         (struct tui_disasm_window, struct tui_data_window)
3603         (struct tui_cmd_window): Update.
3604
3605 2019-06-25  Tom Tromey  <tom@tromey.com>
3606
3607         * tui/tui-winsource.h (tui_set_exec_info_content)
3608         (tui_show_exec_info_content, tui_erase_exec_info_content)
3609         (tui_clear_exec_info_content, tui_update_exec_info): Change
3610         argument to tui_source_window_base.
3611         * tui/tui-winsource.c (tui_set_exec_info_content)
3612         (tui_show_exec_info_content, tui_erase_exec_info_content)
3613         (tui_clear_exec_info_content, tui_update_exec_info): Change
3614         argument to tui_source_window_base.
3615
3616 2019-06-25  Tom Tromey  <tom@tromey.com>
3617
3618         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3619         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3620
3621 2019-06-25  Tom Tromey  <tom@tromey.com>
3622
3623         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3624         check.
3625
3626 2019-06-25  Tom Tromey  <tom@tromey.com>
3627
3628         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3629         type to void.
3630         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3631         type to void.
3632         * tui/tui-source.c (tui_set_source_content): Update.
3633         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3634
3635 2019-06-25  Tom Tromey  <tom@tromey.com>
3636
3637         * tui/tui-win.c (window_name_completer, tui_set_focus)
3638         (tui_all_windows_info): Use name method.
3639         * tui/tui-data.h (struct tui_gen_win_info)
3640         (struct tui_source_window, struct tui_disasm_window)
3641         (struct tui_data_window, struct tui_cmd_window) <name>: New
3642         method.
3643         (tui_win_name): Don't declare.
3644         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3645         (tui_win_name): Remove.
3646
3647 2019-06-25  Tom Tromey  <tom@tromey.com>
3648
3649         * tui/tui-winsource.h (tui_update_source_window)
3650         (tui_update_source_window_as_is): Change parameter type.
3651         * tui/tui-winsource.c (tui_update_source_window): Change win_info
3652         to be a tui_source_window_base.
3653         (tui_update_source_window_as_is): Likewise.
3654         * tui/tui-win.c (make_visible_with_new_height): Update.
3655
3656 2019-06-25  Tom Tromey  <tom@tromey.com>
3657
3658         * tui/tui-winsource.c (tui_erase_source_content)
3659         (tui_show_source_content, tui_show_exec_info_content)
3660         (tui_erase_exec_info_content): Use refresh_window method.
3661         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3662         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3663         from tui_refresh_win.
3664         (tui_data_window::refresh_window): New method.
3665         (tui_win_info::refresh, tui_source_window_base::refresh)
3666         (tui_refresh_all): Use refresh_window method.
3667         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3668         method.
3669         * tui/tui-regs.c (tui_display_register): Call refresh_window
3670         method.
3671         * tui/tui-layout.c (show_source_disasm_command)
3672         (show_source_or_disasm_and_command): Call refresh_window method.
3673         * tui/tui-data.h (struct tui_gen_win_info)
3674         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3675         New method.
3676
3677 2019-06-25  Tom Tromey  <tom@tromey.com>
3678
3679         * tui/tui.c (tui_rl_other_window, tui_enable)
3680         (tui_is_window_visible, tui_get_command_dimension): Update.
3681         * tui/tui-winsource.c (tui_update_source_window_as_is)
3682         (tui_clear_source_content, tui_erase_source_content)
3683         (tui_show_source_line, tui_source_window_base::refill)
3684         (tui_source_window_base::do_scroll_horizontal)
3685         (tui_source_window_base::set_is_exec_point_at)
3686         (tui_update_breakpoint_info, tui_set_exec_info_content)
3687         (tui_alloc_source_buffer, tui_line_is_displayed)
3688         (tui_addr_is_displayed): Update.
3689         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3690         (tui_check_and_display_highlight_if_needed)
3691         (tui_win_info::make_visible, tui_win_info::refresh)
3692         (tui_refresh_all): Update.
3693         * tui/tui-windata.c (tui_first_data_item_displayed)
3694         (tui_delete_data_content_windows, tui_erase_data_content)
3695         (tui_display_all_data, tui_data_window::refresh_all)
3696         (tui_check_data_values): Update.
3697         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3698         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3699         (tui_win_info::backward_scroll, tui_refresh_all_win)
3700         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3701         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3702         (tui_source_window_base::set_new_height)
3703         (tui_data_window::set_new_height)
3704         (make_invisible_and_set_new_height)
3705         (make_visible_with_new_height, new_height_ok)
3706         (parse_scrolling_args): Update.
3707         * tui/tui-stack.c (tui_show_frame_info): Update.
3708         * tui/tui-source.c (tui_set_source_content)
3709         (tui_set_source_content_nil, tui_source_is_displayed)
3710         (tui_source_window::do_scroll_vertical): Update.
3711         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3712         (tui_display_registers_from, tui_display_reg_element_at_line)
3713         (tui_check_register_values, tui_reg_command): Update.
3714         * tui/tui-layout.c (tui_default_win_height)
3715         (show_source_disasm_command, show_data, init_and_make_win)
3716         (show_source_or_disasm_and_command): Update.
3717         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3718         (tui_redisplay_readline, tui_mld_flush)
3719         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3720         (tui_getc): Update.
3721         * tui/tui-disasm.c (tui_set_disassem_content)
3722         (tui_disasm_window::do_scroll_vertical): Update.
3723         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3724         Now virtual.
3725         (struct tui_win_info): Derive from tui_gen_win_info.
3726         <~tui_win_info>: Mark as override.
3727         <generic>: Remove member.
3728         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3729         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3730         (~tui_data_window, ~tui_win_info)
3731         (tui_free_all_source_wins_content): Update.
3732         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3733
3734 2019-06-25  Tom Tromey  <tom@tromey.com>
3735
3736         * tui/tui-layout.c (init_and_make_win): Use new.
3737         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3738         destructor, initializers.
3739         (tui_alloc_generic_win_info): Don't declare.
3740         * tui/tui-data.c (_locator): Add argument to constructor.
3741         (source_win, disasm_win): New globals.
3742         (exec_info): Remove.
3743         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3744         Update.
3745         (tui_alloc_generic_win_info): Remove.
3746         (init_content_element): Use new.
3747         (tui_win_info::tui_win_info): Update.
3748         (free_content_elements) <case DATA_WIN>: Use delete.
3749
3750 2019-06-25  Tom Tromey  <tom@tromey.com>
3751
3752         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3753         * tui/tui-windata.c (tui_first_data_item_displayed)
3754         (tui_delete_data_content_windows): Update.
3755         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3756         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3757         (tui_display_registers_from, tui_check_register_values): Update.
3758         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3759         pointer.
3760         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3761         window.
3762         (tui_free_data_content): Update.
3763         (free_content_elements) <case DATA_WIN>: Free the window.
3764
3765 2019-06-25  Tom Tromey  <tom@tromey.com>
3766
3767         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3768         Update.
3769         * tui/tui-layout.c (make_command_window)
3770         (show_source_disasm_command, show_data, init_and_make_win)
3771         (show_source_or_disasm_and_command): Update.
3772         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3773         method.
3774         <can_highight, is_highlighted>: Now bool.
3775         (tui_set_win_highlight): Don't declare.
3776         * tui/tui-data.c (tui_set_win_highlight): Remove.
3777
3778 2019-06-25  Tom Tromey  <tom@tromey.com>
3779
3780         * tui/tui-wingeneral.c (make_visible): Remove check of window
3781         type.
3782
3783 2019-06-25  Tom Tromey  <tom@tromey.com>
3784
3785         * tui/tui-win.c (tui_win_info::max_height)
3786         (tui_cmd_window::max_height): New methods.
3787         (new_height_ok): Call max_height.
3788         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3789         <max_height>: New method.
3790
3791 2019-06-25  Tom Tromey  <tom@tromey.com>
3792
3793         * tui/tui-win.c (tui_source_window_base::set_new_height)
3794         (tui_data_window::set_new_height): New methods.
3795         (make_invisible_and_set_new_height): Call set_new_height method.
3796         * tui/tui-data.h (struct tui_win_info)
3797         (struct tui_source_window_base, struct tui_data_window)
3798         <set_new_height>: New method.
3799
3800 2019-06-25  Tom Tromey  <tom@tromey.com>
3801
3802         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3803         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3804         tui_refresh_data_win.
3805         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3806         method.
3807         (tui_refresh_all_win): Call the refresh_all method.
3808         (tui_set_focus): Likewise.
3809         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3810         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3811         Likewise.
3812
3813 2019-06-25  Tom Tromey  <tom@tromey.com>
3814
3815         * tui/tui-winsource.h (tui_refill_source_window)
3816         (tui_set_is_exec_point_at): Don't declare.
3817         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3818         (tui_source_window_base::refill): Rename from
3819         tui_refill_source_window.
3820         (tui_source_window_base::do_scroll_horizontal): Update.
3821         (tui_source_window_base::set_is_exec_point_at): Rename from
3822         tui_set_is_exec_point_at.
3823         (tui_update_all_breakpoint_info): Update.
3824         * tui/tui-stack.c (tui_show_frame_info): Update.
3825         * tui/tui-layout.c (show_data): Add cast.
3826         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3827         * tui/tui-data.h (struct tui_source_window_base) <refill,
3828         set_is_exec_point_at>: New methods.
3829         (tui_source_windows, tui_add_to_source_windows): Update types.
3830         (tui_add_to_source_windows): Remove redundant declaration.
3831         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3832         (tui_source_windows): Change return type.
3833         (tui_clear_source_windows_detail): Update.
3834         (tui_add_to_source_windows): Change type of parameter.
3835         (tui_free_all_source_wins_content): Update.
3836
3837 2019-06-25  Tom Tromey  <tom@tromey.com>
3838
3839         * tui/tui-wingeneral.c (tui_win_info::refresh)
3840         (tui_source_window_base::refresh): New methods.
3841         (tui_refresh_all): Call the refresh method.
3842         * tui/tui-data.h (struct tui_win_info)
3843         (struct tui_source_window_base) <refresh>: New method.
3844
3845 2019-06-25  Tom Tromey  <tom@tromey.com>
3846
3847         * tui/tui.h (tui_is_window_visible): Return bool.
3848         * tui/tui.c (tui_is_window_visible): Return bool.
3849         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3850         (tui_make_visible, tui_make_invisible)
3851         (tui_win_info::make_visible)
3852         (tui_source_window_base::make_visible, make_all_visible)
3853         (tui_make_all_visible, tui_make_all_invisible): Update.
3854         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3855         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3856         bool.
3857         (struct tui_win_info, struct tui_source_window_base)
3858         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3859         * tui/tui-data.c (tui_init_generic_part): Update.
3860
3861 2019-06-25  Tom Tromey  <tom@tromey.com>
3862
3863         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3864         (tui_source_window_base::make_visible): New methods.
3865         (make_all_visible): Make method call.
3866         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3867         (struct tui_source_window_base, struct tui_cmd_window): Override
3868         make_visible.
3869         (tui_win_is_source_type): Don't declare.
3870         * tui/tui-data.c (tui_win_is_source_type): Remove.
3871
3872 2019-06-25  Tom Tromey  <tom@tromey.com>
3873
3874         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3875         NULL check.
3876
3877 2019-06-25  Tom Tromey  <tom@tromey.com>
3878
3879         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3880         Inline constructor.  Add initializers for members.
3881         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3882         constructors; now inline in class.
3883
3884 2019-06-25  Tom Tromey  <tom@tromey.com>
3885
3886         * tui/tui-regs.c (tui_show_registers): Update.
3887         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3888         bool.
3889         * tui/tui-data.c (tui_data_window::clear_detail)
3890         (tui_data_window): Update.
3891
3892 2019-06-25  Tom Tromey  <tom@tromey.com>
3893
3894         * tui/tui-windata.c (tui_display_all_data)
3895         (tui_display_data_from_line, tui_display_data_from)
3896         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3897         Update.
3898         * tui/tui-regs.c (tui_last_regs_line_no)
3899         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3900         (tui_show_registers, tui_show_register_group)
3901         (tui_display_registers_from, tui_display_reg_element_at_line)
3902         (tui_display_registers_from_line, tui_check_register_values)
3903         (tui_reg_next, tui_reg_prev): Update.
3904         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3905         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3906         tui_data_window.
3907         (struct tui_win_info) <detail>: Remove.  Add new fields from
3908         tui_data_info.
3909         (TUI_DATA_WIN): Add cast.
3910         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3911         (~tui_data_window): Simplify.
3912
3913 2019-06-25  Tom Tromey  <tom@tromey.com>
3914
3915         * tui/tui-layout.c (show_source_disasm_command)
3916         (show_source_or_disasm_and_command): Update.
3917         * tui/tui-io.c (update_cmdwin_start_line)
3918         (tui_redisplay_readline): Update.
3919         * tui/tui-data.h (struct tui_command_info): Remove.
3920         (struct tui_win_info) <detail>: Remove command_info member.
3921         (struct tui_data_window) <start_line>: New member, from
3922         tui_command_info.
3923         (TUI_CMD_WIN): Add casts.
3924
3925 2019-06-25  Tom Tromey  <tom@tromey.com>
3926
3927         * tui/tui-winsource.c (tui_update_source_window)
3928         (tui_refill_source_window)
3929         (tui_source_window_base::do_scroll_horizontal)
3930         (tui_update_breakpoint_info, tui_set_exec_info_content)
3931         (tui_show_exec_info_content, tui_erase_exec_info_content)
3932         (tui_clear_exec_info_content): Update.
3933         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3934         Update.
3935         * tui/tui-win.c (make_invisible_and_set_new_height)
3936         (make_visible_with_new_height): Update.
3937         * tui/tui-source.c (tui_set_source_content)
3938         (tui_show_symtab_source): Update.
3939         * tui/tui-layout.c (extract_display_start_addr)
3940         (show_source_disasm_command, show_data)
3941         (make_source_or_disasm_window)
3942         (show_source_or_disasm_and_command): Update.
3943         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3944         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3945         "gdbarch".
3946         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3947         to tui_source_window_base.
3948         (struct tui_win_info) <detail>: Remove source_info member.
3949         (struct tui_source_window_base) <has_locator>: Inline.
3950         Move contents from tui_source_info; rename has_locator member to
3951         m_has_locator.
3952         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3953         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3954         header file.
3955         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3956         Simplify.
3957         (tui_free_all_source_wins_content): Cast to
3958         tui_source_window_base.
3959
3960 2019-06-25  Tom Tromey  <tom@tromey.com>
3961
3962         * tui/tui-win.c (make_invisible_and_set_new_height)
3963         (make_visible_with_new_height): Call has_locator method.
3964         * tui/tui-layout.c (show_source_disasm_command, show_data)
3965         (show_source_or_disasm_and_command): Update for bool change.
3966         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3967         (tui_win_info) <has_locator>: New method.
3968         (struct tui_source_window_base) <has_locator>: New method.
3969         (tui_win_has_locator): Don't declare.
3970         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3971         from tui_win_has_locator.
3972         (tui_source_window_base): Use false, not FALSE.
3973
3974 2019-06-25  Tom Tromey  <tom@tromey.com>
3975
3976         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3977         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3978         clear_detail method directly.
3979         (tui_clear_win_detail): Remove.
3980
3981 2019-06-25  Tom Tromey  <tom@tromey.com>
3982
3983         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3984         "this", not TUI_DISASM_WIN.
3985
3986 2019-06-25  Tom Tromey  <tom@tromey.com>
3987
3988         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3989         declare.
3990         * tui/tui-winsource.c
3991         (tui_source_window_base::do_scroll_horizontal): Rename from
3992         tui_horizontal_source_scroll.
3993         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3994         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3995         from tui_vertical_data_scroll.
3996         * tui/tui-win.h (tui_scroll): Don't declare.
3997         * tui/tui-win.c (tui_win_info::forward_scroll)
3998         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3999         (tui_win_info::right_scroll): Rename and update.
4000         (tui_scroll_forward_command, tui_scroll_backward_command)
4001         (tui_scroll_left_command, tui_scroll_right_command): Update.
4002         (tui_scroll): Remove.
4003         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
4004         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
4005         from tui_vertical_source_scroll.
4006         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
4007         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
4008         from tui_vertical_disassem_scroll.
4009         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
4010         do_scroll_horizontal>: New methods.
4011         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
4012         Likewise.
4013         (struct tui_source_window_base): Add do_scroll_horizontal.
4014         (struct tui_source_window, struct tui_disasm_window): Add
4015         do_scroll_vertical.
4016         (struct tui_data_window, struct tui_cmd_window): Add
4017         do_scroll_horizontal and do_scroll_vertical.
4018         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
4019
4020 2019-06-25  Tom Tromey  <tom@tromey.com>
4021
4022         * tui/tui-data.h (struct tui_source_window_base): New struct.
4023         (struct tui_source_window): Derive from tui_source_window_base.
4024         (struct tui_disasm_window): New struct.
4025         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
4026         from tui_source_window::clear_detail.
4027         (tui_source_window_base): Rename from tui_source_window.
4028         (~tui_source_window_base): Rename from ~tui_source_window.
4029         (tui_alloc_win_info): Create a tui_disasm_window.
4030
4031 2019-06-25  Tom Tromey  <tom@tromey.com>
4032
4033         * tui/tui-data.h (struct tui_source_window)
4034         (struct tui_data_window): Declare destructors.
4035         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
4036         destructors.
4037         (tui_win_info): Simplify.
4038
4039 2019-06-25  Tom Tromey  <tom@tromey.com>
4040
4041         * tui/tui-winsource.c (tui_display_main)
4042         (tui_update_source_windows_with_addr)
4043         (tui_update_all_breakpoint_info): Update.
4044         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4045         (new_height_ok, parse_scrolling_args): Update.
4046         * tui/tui-stack.c (tui_show_frame_info): Update.
4047         * tui/tui-data.h (struct tui_list): Remove.
4048         (tui_source_windows): Return a reference to a std::vector.
4049         * tui/tui-data.c (source_windows): Now a std::vector.
4050         (tui_source_windows): Change return type.
4051         (tui_clear_source_windows): Rewrite.
4052         (tui_clear_source_windows_detail, tui_add_to_source_windows)
4053         (tui_free_all_source_wins_content): Rewrite.
4054
4055 2019-06-25  Tom Tromey  <tom@tromey.com>
4056
4057         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
4058         (struct tui_data_window, struct tui_cmd_window): Declare
4059         clear_detail method.
4060         * tui/tui-data.c (tui_source_window::clear_detail)
4061         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
4062         methods.
4063         (tui_clear_win_detail): Simplify.
4064
4065 2019-06-25  Tom Tromey  <tom@tromey.com>
4066
4067         * tui/tui-layout.c (make_source_window, make_disasm_window)
4068         (make_source_or_disasm_window): Remove win_info_ptr parameter.
4069         Return the new window.
4070         (show_source_disasm_command, show_data)
4071         (show_source_or_disasm_and_command): Update.
4072
4073 2019-06-25  Tom Tromey  <tom@tromey.com>
4074
4075         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
4076         parameter.  Return the new window.
4077         (show_source_disasm_command): Update and remove NULL check.
4078         (show_source_or_disasm_and_command): Update.
4079
4080 2019-06-25  Tom Tromey  <tom@tromey.com>
4081
4082         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
4083
4084 2019-06-25  Tom Tromey  <tom@tromey.com>
4085
4086         * tui/tui-data.h (struct tui_win_info): Make constructor
4087         protected.  Make destructor virtual.  Add initializers.
4088         (tui_source_window, tui_data_window, tui_cmd_window): New
4089         classes.
4090         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
4091         constructor.  Add "type" parameter.
4092         (tui_source_window, tui_data_window, tui_cmd_window): New
4093         constructors.
4094         (tui_alloc_win_info): Instantiate the appropriate subclass.
4095
4096 2019-06-25  Tom Tromey  <tom@tromey.com>
4097
4098         * tui/tui-win.c (tui_resize_all): Use delete.
4099         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
4100         destructor.
4101         (tui_free_window): Don't declare.
4102         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
4103         Update.
4104
4105 2019-06-25  Tom Tromey  <tom@tromey.com>
4106
4107         * tui/tui-data.h (struct tui_win_info): Add constructor.
4108         * tui/tui-data.c (tui_alloc_win_info): Use new.
4109         (tui_free_window): Use delete.
4110
4111 2019-06-22  Tom Tromey  <tom@tromey.com>
4112
4113         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
4114         declare.
4115         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
4116
4117 2019-06-22  Tom Tromey  <tom@tromey.com>
4118
4119         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
4120         declare.
4121         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
4122
4123 2019-06-22  Tom de Vries  <tdevries@suse.de>
4124
4125         * dwarf2read.c (create_addrmap_from_aranges)
4126         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
4127         instead of '%zu'.
4128
4129 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
4130
4131         * dwarf2read.h (dwarf2_section_info_def): Remove.
4132         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
4133         * dwarf2read.c (struct dwo_sections) <types>: Change type to
4134         std::vector<dwarf2_section_info>.
4135         (struct dwo_file) <~dwo_file>: Remove.
4136         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
4137         types field.
4138         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
4139         (dwarf2_read_debug_names): Likewise.
4140         (create_debug_types_hash_table): Change parameter type to
4141         array_view, adjust code accordingly.
4142         (dwarf2_locate_dwo_sections): Adjust to std::vector.
4143         (partial_die_info::fixup): Likewise.
4144         (determine_prefix): Likewise.
4145         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
4146
4147 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4148
4149         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
4150         gdb_bfd_ref_ptr.
4151         <~dwo_file>: Remove call to gdb_bfd_unref.
4152         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
4153         gdb_bfd_ref_ptr::get.
4154
4155 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4156
4157         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
4158         type to htab_up.
4159         * dwarf2read.c (struct dwo_file): Initialize fields.
4160         <~dwo_file>: New.
4161         (free_dwo_file): Remove, move content to ~dwo_file.
4162         (struct dwo_file_deleter): Remove.
4163         (dwo_file_up>: Remove custom deleter.
4164         (free_dwo_files): Remove.
4165         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
4166         dwo_files.
4167         (process_skeletonless_type_units): Call unique_ptr::get.
4168         (allocate_dwo_file_hash_table): Add deleter to created hash
4169         table.  Change return type to htab_up.
4170         (lookup_dwo_file_slot): Don't memset dwo_file, call
4171         unique_ptr::get.
4172         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
4173         (create_dwo_unit_in_dwp_v2): Likewise.
4174         (open_and_init_dwo_file): Likewise.
4175         (free_dwo_file_from_slot): Remove.
4176
4177 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4178
4179         * dwarf2read.h (struct dwarf2_section_info) <readin,
4180         is_virtual>: Change type to bool.
4181         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
4182         true instead of 1.
4183
4184 2019-06-19  Tom Tromey  <tom@tromey.com>
4185
4186         * tui/tui-data.h (tui_init_content_element): Don't declare.
4187
4188 2019-06-19  Tom Tromey  <tom@tromey.com>
4189
4190         * tui/tui-data.h (tui_init_win_info): Don't declare.
4191
4192 2019-06-19  Tom de Vries  <tdevries@suse.de>
4193
4194         * dwarf2read.h (abstract_to_concrete): Change type to
4195         std::unordered_map<sect_offset, std::vector<sect_offset>,
4196         gdb::hash_enum<sect_offset>>.
4197
4198 2019-06-19  Tom Tromey  <tromey@adacore.com>
4199
4200         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
4201         EVAL_AVOID_SIDE_EFFECTS specially.
4202
4203 2019-06-19  Tom Tromey  <tromey@adacore.com>
4204
4205         * source-cache.c (highlighter): New global.
4206         (source_cache::get_source_lines): Create a highlighter on demand.
4207
4208 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4209
4210         * defs.h (deprecated_interactive_hook): Delete declaration.
4211         * interps.c (clear_interpreter_hooks): Remove use of
4212         deprecated_interactive_hook.
4213         * top.c (deprecated_interactive_hook): Delete definition.
4214         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
4215
4216 2019-06-18  Tom de Vries  <tdevries@suse.de>
4217
4218         PR gdb/24515
4219         * dwarf2read.h (abstract_to_concrete): Change type from
4220         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
4221         std::unordered_map<sect_offset, std::vector<sect_offset>>.
4222         * dwarf2read.c (read_variable): Update.
4223         (dwarf2_fetch_die_loc_sect_off): Update.
4224
4225 2019-06-17  Tom de Vries  <tdevries@suse.de>
4226
4227         PR gdb/24617
4228         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
4229         accessing parent[parent_len - 1].
4230
4231 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
4232
4233         PR gdb/24364
4234         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
4235         call dtrace_process_dof with NULL dof.
4236
4237 2019-06-16  Tom de Vries  <tdevries@suse.de>
4238
4239         PR gdb/24445
4240         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
4241
4242 2019-06-16  Tom Tromey  <tom@tromey.com>
4243
4244         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4245         (make_all_visible): Use address of member.
4246
4247 2019-06-16  Tom Tromey  <tom@tromey.com>
4248
4249         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
4250         (tui_free_window, free_content, free_content_elements): Remove
4251         unnecessary cast.
4252         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
4253         cast.
4254         * tui/tui-regs.c (tui_show_register_group)
4255         (tui_display_registers_from, tui_display_reg_element_at_line):
4256         Remove unnecessary cast.
4257
4258 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
4259
4260         * linux-nat.c (normal_mask): Delete.
4261         (_initialize_linux_nat): Don't initialise normal_mask.
4262
4263 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
4264
4265         PR gdb/24445
4266         * dwarf-index-write.h (write_psymtabs_to_index): Add
4267         dwz_basename parameter.
4268         * dwarf-index-write.c (write_gdbindex): Move file writing to
4269         write_gdbindex_1.  Change return type void.
4270         (assert_file_size): Move up, remove filename parameter.
4271         (write_gdbindex_1): New function.
4272         (write_debug_names): Change return type to void, call
4273         assert_file_size.
4274         (struct index_wip_file): New struct.
4275         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
4276         file logic to index_wip_file.  Write index for dwz file if
4277         needed.
4278         (save_gdb_index_command): Pass basename of dwz file, if present.
4279         * dwarf-index-cache.c (index_cache::store): Obtain and pass
4280         build-id of dwz file, if present.
4281         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
4282         (dwarf2_get_dwz_file): Likewise.
4283         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
4284         (dwarf2_get_dwz_file): Likewise.
4285
4286 2019-06-16  Tom Tromey  <tom@tromey.com>
4287
4288         * coffread.c (process_coff_symbol): Use xstrdup.
4289         * value.c (create_internalvar): Use xstrdup.
4290
4291 2019-06-16  Tom Tromey  <tom@tromey.com>
4292
4293         * valops.c (value_cast, value_slice): Remove unnecessary cast.
4294         * breakpoint.c (stopin_command, stopat_command)
4295         (until_break_command, decode_location_default): Remove unnecessary
4296         cast.
4297         * utils.c (subset_compare): Remove unnecessary cast.
4298         * ada-lang.c (ada_update_initial_language): Remove unnecessary
4299         cast.
4300         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
4301         cast.
4302         * infcmd.c (path_command): Remove unnecessary cast.
4303         * coffread.c (decode_type): Remove unnecessary cast.
4304         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
4305         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
4306         * tui/tui-stack.c (tui_show_locator_content)
4307         (tui_show_frame_info): Remove unnecessary cast.
4308         * tui/tui-win.c (tui_scroll_forward_command)
4309         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
4310         (parse_scrolling_args): Remove unnecessary cast.
4311         * tui/tui-data.c (init_win_info, tui_del_window)
4312         (tui_free_window, tui_del_data_windows, tui_free_data_content)
4313         (free_content_elements): Remove unnecessary cast.
4314         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
4315         unnecessary cast.
4316         * tui/tui-source.c (tui_set_source_content)
4317         (tui_vertical_source_scroll): Remove unnecessary cast.
4318         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
4319         cast.
4320         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
4321         * tui/tui-regs.c (tui_display_registers_from)
4322         (tui_display_register): Remove unnecessary cast.
4323         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
4324         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
4325         (make_visible): Remove unnecessary cast.
4326         * tui/tui-winsource.c (tui_erase_source_content)
4327         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
4328         unnecessary cast.
4329         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
4330         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
4331         * stabsread.c (read_type, read_array_type, read_range_type):
4332         Remove unnecessary cast.
4333         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
4334         (parse_symbol, parse_type, upgrade_type, parse_external)
4335         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
4336         unnecessary cast.
4337         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
4338
4339 2019-06-16  Tom Tromey  <tom@tromey.com>
4340
4341         * tui/tui-data.c (tui_alloc_generic_win_info)
4342         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
4343         checks.
4344
4345 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
4346             Andrew Burgess  <andrew.burgess@embecosm.com>
4347
4348         * f-typeprint.c (f_print_type): Don't return early for not
4349         associated or not allocated types.
4350         (f_type_print_varspec_suffix): Add print_rank parameter and print
4351         ranks of array types in case they dangling.
4352         (f_type_print_base): Add print_rank parameter.
4353
4354 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4355
4356         * NEWS: Mention new MI commands.
4357         * break-catch-throw.c (enum exception_event_kind): Move to
4358         breakpoint.h.
4359         (print_mention_exception_catchpoint): Output text as a single
4360         message.
4361         (catch_exception_command_1): Rename to...
4362         (catch_exception_event): ...this, make non-static, update header
4363         command, and change some parameter types.
4364         (catch_catch_command): Update for changes to
4365         catch_exception_command_1.
4366         (catch_throw_command): Likewise.
4367         (catch_rethrow_command): Likewise.
4368         * breakpoint.c (enum exception_event_kind): Delete.
4369         * breakpoint.h (enum exception_event_kind): Moved here from
4370         break-catch-throw.c.
4371         (catch_exception_event): Declare.
4372         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
4373         (mi_cmd_catch_throw): New function.
4374         (mi_cmd_catch_rethrow): New function.
4375         (mi_cmd_catch_catch): New function.
4376         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
4377         'catch-catch' entries.
4378         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
4379         (mi_cmd_catch_rethrow): Declare.
4380         (mi_cmd_catch_catch): Declare.
4381
4382 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4383
4384         * annotate.c (annotate_source_line): Change return type to void,
4385         update implementation to match.
4386         * annotate.h (annotate_source_line): Change return type to void,
4387         update header comment.
4388         * stack.c (print_frame_info): Don't change what frame information
4389         is printed based on whether annotations are on or not.
4390
4391 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4392
4393         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
4394         (annotate_source): Make static.
4395         (annotate_source_line): Moved from source.c and renamed from
4396         identify_source_line.  Update the return type.
4397         * annotate.h (annotate_source): Delete declaration.
4398         (annotate_source_line): Declaration moved from source.h, and
4399         renamed from identify_source_line.  Return type updated.
4400         * source.c (identify_source_line): Moved to annotate.c and renamed
4401         to annotate_source_line.
4402         (info_line_command): Remove check of annotation_level.
4403         * source.h (identify_source_line): Move declaration to annotate.h
4404         and rename to annotate_source_line.
4405         * stack.c: Add 'annotate.h' include.
4406         (print_frame_info): Remove check of annotation_level before
4407         calling annotate_source_line.
4408
4409 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4410
4411         * source-cache.c (source_cache::get_plain_source_lines): Use
4412         open_source_file_with_line_charpos instead of just
4413         open_source_file, remove call to find_source_lines.
4414         (source_cache::get_source_lines): Likewise.
4415         * source.c (find_source_lines): Make static.
4416         (get_filename_and_charpos): Renamed into...
4417         (open_source_file_with_line_charpos): ..this along with changes to
4418         return a scoped_fd, and some other minor clean ups.
4419         (identify_source_line): Use open_source_file_with_line_charpos.
4420         (search_command_helper): Use open_source_file_with_line_charpos
4421         instead of just open_source_file, remove call to
4422         find_source_lines.
4423         * source.h (open_source_file_with_line_charpos): Declare new
4424         function.
4425         (find_source_lines): Delete declaration.
4426
4427 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4428
4429         * source.c (get_filename_and_charpos): Remove fullname
4430         parameter.
4431         (identify_source_line): Update call to get_filename_and_charpos.
4432
4433 2019-06-14  Tom Tromey  <tromey@adacore.com>
4434
4435         PR gdb/24502:
4436         * ui-style.h (skip_ansi_escape): Update comment.
4437         * ui-file.h (class no_terminal_escape_file): New class.
4438         * ui-file.c (no_terminal_escape_file::write)
4439         (no_terminal_escape_file::puts): New methods.
4440         * cli/cli-logging.c (handle_redirections): Use
4441         no_terminal_escape_file.
4442
4443 2019-06-14  Tom Tromey  <tromey@adacore.com>
4444
4445         * NEWS: Move convenience variable news above Python news.
4446
4447 2019-06-14  Tom Tromey  <tom@tromey.com>
4448
4449         * gnulib: Move directory to top-level.
4450         * configure.ac: Don't configure gnulib.
4451         * configure: Rebuild.
4452         * common/common-defs.h: Use new path to gnulib.
4453         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4454         (GNULIB_H): Remove.
4455         (INCGNU): Look in new gnulib location.
4456         (HFILES_NO_SRCDIR): Remove gnulib files.
4457         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4458         (generated_files): Remove GNULIB_H.
4459         ($(LIBGNU), all-lib): Remove targets.
4460         (distclean): Don't mention GNULIB_BUILDDIR.
4461         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4462
4463 2019-06-14  Tom Tromey  <tromey@adacore.com>
4464
4465         * symfile.c (add_symbol_file_command): Remove obsolete comment.
4466         Warn if symbol file does not provide any symbols.
4467
4468 2019-06-14  Tom Tromey  <tromey@adacore.com>
4469
4470         * source.c (find_and_open_source): Respect basenames_may_differ.
4471
4472 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
4473
4474         * annotate.c (annotate_breakpoints_invalid): Make use of
4475         scoped_restore_terminal_state.
4476         (annotate_frames_invalid): Likewise.
4477
4478 2019-06-14  Tom Tromey  <tromey@adacore.com>
4479
4480         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4481         allow assignment to an internalvar.
4482
4483 2019-06-14  Tom Tromey  <tromey@adacore.com>
4484
4485         * ada-lex.l: Allow "_" in attribute names.
4486
4487 2019-06-14  Tom Tromey  <tromey@adacore.com>
4488
4489         PR gdb/24653:
4490         * regcache.c (registers_changed): Don't call alloca.
4491         * top.c (execute_command): Don't call alloca.
4492
4493 2019-06-13  Pedro Alves  <palves@redhat.com>
4494
4495         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4496         'expression'.  When parsing an expression, error out if there's
4497         junk after "unlimited".
4498         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4499         (do_set_command): Adjust calls to is_unlimited_literal.
4500
4501 2019-06-13  Pedro Alves  <palves@redhat.com>
4502
4503         * compile/compile.c (make_compile_options_def_group): Add braces
4504         around array_view initializer.
4505         * thread.c (make_thread_apply_all_options_def_group)
4506         (make_thread_apply_all_options_def_group): Likewise.
4507
4508 2019-06-13  Pedro Alves  <palves@redhat.com>
4509
4510         * NEWS (New commands): Mention "maint test-options
4511         require-delimiter", "maint test-options unknown-is-error", "maint
4512         test-options unknown-is-operand" and "maint show
4513         test-options-completion-result".
4514         (New command options, command completion): New section.
4515         (Completion improvements): New section.
4516         Mention that you can abbreviate "unlimited".
4517
4518 2019-06-13  Pedro Alves  <palves@redhat.com>
4519
4520         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4521         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4522         * unittests/cli-utils-selftests.c (test_parse_flags)
4523         (test_parse_flags_qcs): Delete.
4524         (test_cli_utils): Don't call deleted functions.
4525
4526 2019-06-13  Pedro Alves  <palves@redhat.com>
4527
4528         * thread.c: Include "cli/cli-option.h".
4529         (tp_array_compar_ascending): Global.
4530         (tp_array_compar): Delete function.
4531         (tp_array_compar_ascending, tp_array_compar_descending): New
4532         functions.
4533         (ascending_option_def, qcs_flag_option_def)
4534         (thr_qcs_flags_option_defs)
4535         (make_thread_apply_all_options_def_group)
4536         (make_thread_apply_options_def_group): New.
4537         (thread_apply_all_command): Use gdb::option::process_options.
4538         (thread_apply_command_completer)
4539         (thread_apply_all_command_completer): New.
4540         (thread_apply_command): Use gdb::option::process_options.
4541         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4542         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
4543         to generate help text of "thread apply".  Adjust "taas"'s help.
4544         * tid-parse.c (tid_range_parser::in_thread_range): New method.
4545         * tid-parse.h (tid_range_parser::in_thread_range): New method.
4546
4547 2019-06-13  Pedro Alves  <palves@redhat.com>
4548
4549         * thread.c (thread_apply_command): Check for invalid TID with
4550         isdigit instead of !isalpha.
4551
4552 2019-06-13  Pedro Alves  <palves@redhat.com>
4553
4554         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4555         (validate_flags_qcs): New.
4556         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4557         (validate_flags_qcs): Declare.
4558         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4559         (make_frame_apply_options_def_group): New.
4560         (frame_apply_command_count): Process options with
4561         gdb::option::process_options.
4562         (frame_apply_completer): New.
4563         (frame_apply_level_completer, frame_apply_all_completer)
4564         (frame_apply_completer): New.
4565         (_initialize_stack): Update help of "frame apply", "frame apply
4566         level", "frame apply all" and "faas" to mention supported options
4567         and install command completers.
4568         * stack.h (frame_apply_all_completer): Declare.
4569         * thread.c: Include "stack.h".
4570         (tfaas_command): Add "--".
4571         (_initialize_thread): Update help "tfaas" to mention supported
4572         options and install command completer.
4573
4574 2019-06-13  Pedro Alves  <palves@redhat.com>
4575
4576         * completer.c (complete_nested_command_line): New.
4577         (gdb_completion_word_break_characters_throw): Add assertion.
4578         * completer.h (complete_nested_command_line): Declare.
4579
4580 2019-06-13  Pedro Alves  <palves@redhat.com>
4581
4582         * stack.c (parse_backtrace_qualifiers): New.
4583         (backtrace_command): Use it.
4584         (backtrace_command_completer): Complete on qualifiers.
4585
4586 2019-06-13  Pedro Alves  <palves@redhat.com>
4587
4588         * frame.c: Include "cli/cli-option.h.
4589         (user_set_backtrace_options): New.
4590         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4591         Delete.
4592         (get_prev_frame): Adjust.
4593         (boolean_option_def, uinteger_option_def)
4594         (set_backtrace_option_defs): New.
4595         (_initialize_frame): Adjust and use
4596         gdb::option::add_setshow_cmds_for_options to install "set
4597         backtrace past-main" and "set backtrace past-entry".
4598         * frame.h: Include "cli/cli-option.h".
4599         (struct frame_print_options): Forward declare.
4600         (print_frame_arguments_all, print_frame_arguments_scalars)
4601         (print_frame_arguments_none): Declare.
4602         (print_entry_values): Delete declaration.
4603         (struct frame_print_options, user_frame_print_options): New.
4604         (struct set_backtrace_options): New.
4605         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4606         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4607         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4608         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4609         (list_args_or_locals): Add frame_print_options parameter.
4610         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4611         * python/py-framefilter.c (enumerate_args): Pass down
4612         USER_FRAME_PRINT_OPTIONS.
4613         * stack.c: Include "cli/cli-option.h".
4614         (print_frame_arguments_all, print_frame_arguments_scalars)
4615         (print_frame_arguments_none): Declare.
4616         (print_raw_frame_arguments, print_entry_values): Delete.
4617         (user_frame_print_options): New.
4618         (boolean_option_def, enum_option_def, frame_print_option_defs):
4619         New.
4620         (struct backtrace_cmd_options): New.
4621         (bt_flag_option_def): New.
4622         (backtrace_command_option_defs): New.
4623         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4624         (print_frame_arg, read_frame_arg, print_frame_args)
4625         (print_frame_info, print_frame): Add frame_print_options parameter
4626         and use it.
4627         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4628         (backtrace_command_1): Add frame_print_options and
4629         backtrace_cmd_options parameters and use them.
4630         (make_backtrace_options_def_group): New.
4631         (backtrace_command): Process command options with
4632         gdb::option::process_options.
4633         (backtrace_command_completer): New.
4634         (_initialize_stack): Extend "backtrace"'s help to mention
4635         supported options.  Install completer for "backtrace".
4636         Install some settings commands with add_setshow_cmds_for_options.
4637
4638 2019-06-13  Pedro Alves  <palves@redhat.com>
4639
4640         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4641         and that "set/show print raw frame-arguments" are now deprecated.
4642
4643         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4644         command.
4645         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4646         * stack.c (_initialize_stack): Install "set/show print
4647         raw-frame-arguments", and deprecate "set/show print raw
4648         frame-arguments".
4649         * valprint.c (_initialize_valprint): Deprecate "set/show print
4650         raw".
4651
4652 2019-06-13  Pedro Alves  <palves@redhat.com>
4653
4654         * compile/compile.c (struct compile_options): New.
4655         (compile_flag_option_def, compile_command_option_defs)
4656         (make_compile_options_def_group): New.
4657         (compile_file_command): Handle options with
4658         gdb::option::process_options.
4659         (compile_file_command_completer): New function.
4660         (compile_code_command): Handle options with
4661         gdb::option::process_options.
4662         (compile_code_command_completer): New function.
4663         (_initialize_compiler): Install completers for "compile code" and
4664         "compile file".  Mention available options in "compile code" and
4665         "compile code"'s help.
4666         * completer.c (advance_to_completion_word): New, factored out from
4667         ...
4668         (advance_to_expression_complete_word_point): ... this.
4669         (advance_to_filename_complete_word_point): New.
4670         * completer.h (advance_to_filename_complete_word_point): New
4671         declaration.
4672
4673 2019-06-13  Pedro Alves  <palves@redhat.com>
4674
4675         * compile/compile.c: Include "cli/cli-option.h".
4676         (compile_print_value): Scope data pointer is now a
4677         value_print_options pointer; adjust.
4678         (compile_print_command): Process options.  Scope data pointer is
4679         now a value_print_options pointer; adjust.
4680         (_initialize_compile): Update "compile print"'s help to include
4681         supported options.  Install a completer for "compile print".
4682         * cp-valprint.c (show_vtblprint, show_objectprint)
4683         (show_static_field_print): Delete.
4684         (_initialize_cp_valprint): Don't install "set print
4685         static-members", "set print vtbl", "set print object" here.
4686         * printcmd.c: Include "cli/cli-option.h" and
4687         "common/gdb_optional.h".
4688         (print_command_parse_format): Rework to fill in a
4689         value_print_options instead of a format_data.
4690         (print_value): Change parameter type from format_data pointer to
4691         value_print_options reference.  Adjust.
4692         (print_command_1): Process options.  Adjust to pass down a
4693         value_print_options.
4694         (print_command_completer): New.
4695         (_initialize_printcmd): Install print_command_completer as
4696         handle_brkchars completer for the "print" command.  Update
4697         "print"'s help to include supported options.
4698         * valprint.c: Include "cli/cli-option.h".
4699         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4700         here from cp-valprint.c.
4701         (boolean_option_def, uinteger_option_def)
4702         (value_print_option_defs, make_value_print_options_def_group):
4703         New.  Use gdb::option::add_setshow_cmds_for_options to install
4704         "set print elements", "set print null-stop", "set print repeats",
4705         "set print pretty", "set print union", "set print array", "set
4706         print address", "set print symbol", "set print array-indexes".
4707         * valprint.h: Include <string> and "cli/cli-option.h".
4708         (make_value_print_options_def_group): Declare.
4709         (print_value): Change parameter type from format_data pointer to
4710         value_print_options reference.
4711         (print_command_completer): Declare.
4712
4713 2019-06-13  Pedro Alves  <palves@redhat.com>
4714
4715         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4716         (COMMON_SFILES): Add maint-test-settings.c.
4717         * cli/cli-decode.c (boolean_enums): New global, factored out from
4718         ...
4719         (add_setshow_boolean_cmd): ... here.
4720         * cli/cli-decode.h (boolean_enums): Declare.
4721         * cli/cli-option.c: New file.
4722         * cli/cli-option.h: New file.
4723         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4724         factored out from ...
4725         (parse_cli_boolean_value(const char *)): ... this.
4726         (is_unlimited_literal): Change parameter type to pointer to
4727         pointer.  Adjust and advance ARG pointer.
4728         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4729         (parse_cli_var_enum): New, factored out from ...
4730         (do_set_command): ... this.  Adjust.
4731         * cli/cli-setshow.h (parse_cli_boolean_value)
4732         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4733         (parse_cli_var_enum): Declare.
4734         * cli/cli-utils.c: Include "cli/cli-option.h".
4735         (get_ulongest): New.
4736         * cli/cli-utils.h (get_ulongest): Declare.
4737         (check_for_argument): New overloads.
4738         * maint-test-options.c: New file.
4739
4740 2019-06-13  Pedro Alves  <palves@redhat.com>
4741
4742         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4743         parse a range if "-" is at the end of the string.
4744
4745 2019-06-13  Pedro Alves  <palves@redhat.com>
4746
4747         * cli/cli-setshow.c (parse_auto_binary_operation)
4748         (parse_cli_boolean_value): Don't allow "o".
4749
4750 2019-06-13  Pedro Alves  <palves@redhat.com>
4751
4752         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4753         * NEWS: Mention maint test-settings KIND.
4754         * maint-test-settings.c: New file.
4755
4756 2019-06-13  Pedro Alves  <palves@redhat.com>
4757
4758         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4759         completer.
4760         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4761         "set" completers.
4762
4763 2019-06-13  Pedro Alves  <palves@redhat.com>
4764
4765         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4766         after item.
4767
4768 2019-06-13  Pedro Alves  <palves@redhat.com>
4769
4770         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4771
4772 2019-06-13  Pedro Alves <palves@redhat.com>
4773
4774         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4775         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4776         call.
4777         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4778         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4779         calls.
4780         (check_for_argument): Skip spaces after argument.
4781
4782 2019-06-13  Pedro Alves  <palves@redhat.com>
4783
4784         * thread.c (thread_apply_command): Adjust TID parsing.
4785         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4786         detected before end of string.
4787         (tid_is_in_list): Error out if LIST is invalid.
4788
4789 2019-06-13  Pedro Alves  <palves@redhat.com>
4790
4791         * completer.c (complete_line_internal_1): Rewind completion word
4792         point.
4793         (completion_tracker::advance_custom_word_point_by): Change
4794         parameter type to int.
4795         * completer.h (completion_tracker::advance_custom_word_point_by):
4796         Likewise.
4797
4798 2019-06-13  Pedro Alves  <palves@redhat.com>
4799
4800         * completer.c (advance_to_completion_word): Handle delimiters.
4801
4802 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4803
4804         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4805
4806 2019-06-11  Tom Tromey  <tom@tromey.com>
4807
4808         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4809         (xmalloc_failed): Move to alloc.c.
4810         * alloc.c: New file.
4811         * Makefile.in (COMMON_SFILES): Add alloc.c.
4812
4813 2019-06-11  Tom Tromey  <tom@tromey.com>
4814
4815         * nat/linux-waitpid.c: Don't include server.h.
4816         (linux_debug): Remove.
4817         (my_waitpid): Update.
4818
4819 2019-06-11  Tom Tromey  <tromey@adacore.com>
4820
4821         * infcall.c (_initialize_infcall): Remove trailing newline from
4822         help.
4823         * user-regs.c (_initialize_user_regs): Remove trailing newline
4824         from help.
4825         * typeprint.c (_initialize_typeprint): Remove trailing newline
4826         from help.
4827         * reverse.c (_initialize_reverse): Remove trailing newlines from
4828         help.
4829         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4830         from help.
4831         * language.c (add_set_language_command): Remove trailing newline
4832         from help.
4833         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4834         help.
4835         * disasm.c (_initialize_disasm): Remove trailing newline from
4836         help.
4837         * top.c (init_main): Remove trailing newline from help.
4838         * interps.c (_initialize_interpreter): Remove trailing newline
4839         from help.
4840         * btrace.c (_initialize_btrace): Remove trailing newlines from
4841         help.
4842         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4843         from help.
4844         * python/python.c (_initialize_python): Remove trailing newline
4845         from help.
4846         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4847         help.
4848         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4849         from help.  Reformat some text.
4850         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4851         from help.
4852         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4853         newline from help.
4854
4855 2019-06-11  Tom Tromey  <tromey@adacore.com>
4856
4857         * darwin-nat.c (darwin_decode_exception_message)
4858         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4859
4860 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4861
4862         * valops.c (value_slice): Check for not allocated or not
4863         associated values.
4864
4865 2019-06-10  Tom de Vries  <tdevries@suse.de>
4866
4867         PR gdb/24618
4868         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4869         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4870         invalid.
4871
4872 2019-06-10  Tom de Vries  <tdevries@suse.de>
4873
4874         PR gdb/24611
4875         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4876         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4877
4878 2019-06-10  Tom de Vries  <tdevries@suse.de>
4879
4880         PR symtab/24545
4881         * symtab.c (struct demangled_name_entry): Add language field.
4882         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4883         static minimal symbol".  Set and use language field.
4884
4885 2019-06-10  Tom Tromey  <tromey@adacore.com>
4886
4887         * ada-lang.c (_initialize_ada_language): Update help text.
4888
4889 2019-06-10  Tom Tromey  <tromey@adacore.com>
4890
4891         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4892         with a newline.
4893         * guile/guile.c (handle_boot_error): Don't end warning with a
4894         newline.
4895         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4896         warning with a newline.
4897         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4898         newline.
4899         (s12z_frame_cache): Likewise.
4900         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4901         a newline.
4902         * solib-svr4.c (disable_probes_interface): Don't end warning with
4903         a newline.
4904         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4905         newline.
4906         * python/python.c (do_finish_initialization): Don't end warning
4907         with a newline.
4908
4909 2019-06-10  Tom Tromey  <tom@tromey.com>
4910
4911         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4912         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4913         gdbpy_enter.
4914
4915 2019-06-10  Tom Tromey  <tromey@adacore.com>
4916
4917         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4918         data.
4919         (elf_new_init): Don't call stabsread_new_init.
4920         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4921         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4922         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4923
4924 2019-06-10  Tom de Vries  <tdevries@suse.de>
4925
4926         PR symtab/16264
4927         PR symtab/24517
4928         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4929
4930 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4931
4932         * source.c (find_and_open_source): Also rewrite relative file
4933         names.
4934
4935 2019-04-26  Amos Bird  <amosbird@gmail.com>
4936
4937         * annotate.c (annotate_thread_exited): Add "thread-exited"
4938         annotation.
4939
4940 2019-06-06  Tom Tromey  <tromey@adacore.com>
4941
4942         * maint.h (class scoped_command_stats): Use
4943         DISABLE_COPY_AND_ASSIGN.
4944         <print_time>: New method.
4945         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4946         print_time.
4947         (scoped_command_stats::print_time): New method.
4948
4949 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4950
4951         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4952         instructions of lengths 6 or 8 bytes.
4953
4954 2019-06-04  Pedro Alves  <palves@redhat.com>
4955
4956         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4957
4958         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4959         * breakpoint.c (condition_completer): Likewise.
4960         * cli/cli-dump.c (scan_expression): Likewise.
4961         * common/filestuff.c (mkdir_recursive): Likewise.
4962         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4963         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4964         (gdb_abspath): Likewise.
4965         * compile/compile-cplus-types.c
4966         (compile_cplus_instance::decl_name): Likewise.
4967         * completer.c (complete_explicit_location):
4968         (signal_completer, reg_or_group_completer_1): Likewise.
4969         * cp-support.c (cp_remove_params_if_any): Likewise.
4970         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4971         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4972         * infcmd.c (strip_bg_char): Likewise.
4973         * linespec.c (copy_token_string): Likewise.
4974         * mi/mi-main.c (output_cores): Likewise.
4975         * psymtab.c (psymtab_search_name):
4976         * symfile.c (test_set_ext_lang_command): Likewise.
4977         * target.c (target_fileio_read_stralloc): Likewise.
4978         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4979         * value.c (complete_internalvar): Likewise.
4980
4981 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4982
4983         Add objfile property to gdb.Type.
4984         * NEWS: Mention Python API addition.
4985         * python/py-type.c (typy_get_objfile): New method.
4986
4987 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4988
4989         * NEWS: Mention the new set|show style [title|highlight].
4990         Mention changes to "show style", "help" and "apropos".
4991
4992 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4993
4994         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4995         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4996         instead of print_help_for_command.
4997         (print_doc_of_command): New function.
4998         (help_list): Add 'apropos -v word' suggestion.
4999         (print_help_for_command): Style the command name using title style.
5000         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
5001         (_initialize_cli_cmds): Describe -v in apropos_command help.
5002
5003 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5004
5005         * cli/cli-style.h (cli_style_option): Add name in constructor,
5006         add m_name class member, add constructor with intensity,
5007         add name class function.
5008         (cli_style_option::add_setshow_commands): Remove name argument.
5009         (highlight_style, title_style): New styles.
5010         * cli/cli-style.c (do_show): New function that shows a style
5011         characteristic styling the style name with itself.
5012         (set_style_name): New function.
5013         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
5014         Update all callers according to the changes in cli/cli-style.h.
5015         * utils.h (fputs_highlighted): New function.
5016         * utils.c (fputs_highlighted): Likewise.
5017
5018 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5019
5020         * NEWS: Mention new pipe command and new convenience variables.
5021
5022 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5023
5024         * cli/cli-cmds.c (pipe_command): New function.
5025         (_initialize_cli_cmds): Call add_com for pipe_command.
5026         Define | as an alias for pipe.
5027         (exit_status_set_internal_vars): New function.
5028         (shell_escape): Call exit_status_set_internal_vars.
5029         cli/cli-decode.c (find_command_name_length): Recognize | as
5030         a single character command.
5031
5032 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5033
5034         * gdbcmd.h (execute_command_to_ui_file): New declaration.
5035         top.c (execute_command_to_ui_file): New function, mostly a copy
5036         of execute_command_to_string.
5037         (execute_command_to_string): Implement by calling
5038         execute_command_to_ui_file.
5039
5040 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5041
5042         * top.h (saved_command_line): Remove declaration.
5043         * top.c (previous_saved_command_line, previous_repeat_arguments):
5044         New variables.
5045         (saved_command_line): Make static, define together with other
5046         'repeat variables'.
5047         (dont_repeat): Clear repeat_arguments.
5048         (repeat_previous, get_saved_command_line, save_command_line):
5049         New functions.
5050         (gdb_init): Initialize saved_command_line
5051         and previous_saved_command_line.
5052         * main.c (captured_main_1): Remove saved_command_line initialization.
5053         * event-top.c (handle_line_of_input): Update to use
5054         the new 'repeat' related functions instead of direct access to
5055         saved_command_line.
5056         * command.h (repeat_previous, get_saved_command_line,
5057         save_command_line): New declarations.
5058         (dont_repeat): Add comment.
5059
5060 2019-05-30  Tom Tromey  <tromey@adacore.com>
5061
5062         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
5063         Fix comment.
5064         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
5065
5066 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
5067
5068         PR cli/24587
5069         * completer.c (complete): Initialize variable word.
5070
5071 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
5072
5073         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5074         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
5075         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
5076         'body' is NULL to the outter 'if', protecting the '!is_define'
5077         situation as well.
5078
5079 2019-05-29  Tom Tromey  <tromey@adacore.com>
5080
5081         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
5082         (dwarf_unknown): New function.
5083         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
5084         (dwarf_type_encoding_name): Use dwarf_unknown.
5085
5086 2019-05-29  Tom Tromey  <tromey@adacore.com>
5087
5088         PR c++/20020:
5089         * cp-valprint.c (cp_print_value_fields): Call
5090         cp_print_static_field inside "try".
5091
5092 2019-05-29  Tom Tromey  <tromey@adacore.com>
5093
5094         * inflow.c (struct terminal_info): Add default operator=.
5095         * configure: Rebuild.
5096         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
5097         -Wdeprecated-copy-dtor, -Wredundant-move.
5098
5099 2019-05-29  Tom Tromey  <tromey@adacore.com>
5100
5101         * NEWS: Add entry.
5102         * infcmd.c (print_return_value_1): Handle finish_print
5103         option.
5104         (show_print_finish): New function.
5105         (_initialize_infcmd): Add "set/show print finish" commands.
5106         * valprint.c (user_print_options): Initialize new member.
5107         * valprint.h (struct value_print_options) <finish_print>: New
5108         member.
5109
5110 2019-05-28  Tom Tromey  <tromey@adacore.com>
5111
5112         * ada-lang.c (ada_remove_Xbn_suffix)
5113         (find_old_style_renaming_symbol)
5114         (parse_old_style_renaming): Remove.
5115         (ada_find_renaming_symbol): Don't call
5116         find_old_style_renaming_symbol.
5117         (ada_is_renaming_symbol): Rename from
5118         ada_find_renaming_symbol.  Remove "block" parameter.  Return
5119         bool.  Now static.
5120         (ada_read_var_value): Update and simplify.
5121         * ada-exp.y (write_var_or_type): Remove old code.
5122
5123 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
5124
5125         * event-top.c: Remove include comment.
5126         * inflow.c (class scoped_ignore_sigttou): Move from here...
5127         * inflow.h (class scoped_ignore_sigttou): ...to here.
5128         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
5129         * top.c:  Remove include comment.
5130
5131 2019-05-27  Tom Tromey  <tom@tromey.com>
5132
5133         * NEWS: Fix typo.
5134
5135 2019-05-22  Tom Tromey  <tromey@adacore.com>
5136
5137         * target.c (target_follow_exec): Constify parameter.
5138         * target-delegates.c: Rebuild.
5139         * remote.c (remote_target::follow_exec): Constify parameter.
5140         * infrun.c (follow_exec): Constify parameter.
5141         * target.h (struct target_ops) <follow_exec>: Constify parameter.
5142         (target_follow_exec): Likewise.
5143
5144 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5145
5146         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
5147         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
5148
5149 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5150
5151         * NEWS: Add debugredirect and testsuite sections.
5152
5153 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
5154
5155         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
5156         target descriptions using exclusively floating point register name
5157         aliases.
5158
5159 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
5160
5161         PR gdb/18644:
5162         * f-lang.c (build_fortran_types): Handle the case where
5163         gdbarch_floatformat_for_type returns a nullptr.
5164
5165 2019-05-21  Tom de Vries  <tdevries@suse.de>
5166
5167         PR cli/24587
5168         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
5169
5170 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5171
5172         PR gdb/18644:
5173         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
5174         16-byte floats.
5175         * i386-tdep.c (i386_floatformat_for_type): Use
5176         floatformats_ia64_quad for the 16-byte floating point component
5177         within a fortran 32-byte complex number.
5178
5179 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5180
5181         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
5182         delete default constructor.
5183         (find_partial_die): Update to return const struct.
5184         (partial_die_parent_scope): Move variable declaration into scope
5185         of its use and change its type to auto.
5186         (guess_partial_die_structure_name): Likewise.
5187         (partial_die_info::fixup): Likewise.
5188
5189 2019-05-17  Tom Tromey  <tromey@adacore.com>
5190
5191         * source.c (find_and_open_source): Remove cast.
5192
5193 2019-05-17  Tom Tromey  <tromey@adacore.com>
5194
5195         * annotate.c (annotate_source): Make "filename" const.
5196         * annotate.h (annotate_source): Use const.
5197
5198 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5199
5200         * disasm.c (set_disassembler_options): Send errors to stderr.
5201
5202 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5203
5204         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
5205         (cli_interp_base::set_logging): Check debug_redirect.
5206         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
5207         * cli/cli-logging.c (debug_redirect): Add static variable.
5208         (pop_output_files): Add default param.
5209         (handle_redirections): Print debug setting.
5210         (show_logging_command): Likewise.
5211         (_initialize_cli_logging): Add debugredirect command.
5212         * interps.c (current_interp_set_logging): Add debug_redirect
5213         parameter.
5214         * interps.h (set_logging): Add debug_redirect parameter.
5215         (current_interp_set_logging): Likewise.
5216         * mi/mi-common.h: Likewise.
5217         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
5218
5219 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5220             Tom Tromey  <tromey@adacore.com>
5221
5222         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
5223         directly.
5224         * cli/cli-interp.h (make_logging_output): Remove declaration.
5225         * cli/cli-logging.c (make_logging_output): Remove function.
5226         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
5227         directly.
5228         * ui-file.c (tee_file::tee_file): Remove bools.
5229         (tee_file::~tee_file): Remove deletes.
5230         * ui-file.h (tee_file): Remove bools.
5231
5232 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
5233
5234         * mi/mi-cmds.h (mi_cmd_complete): New function.
5235         * mi/mi-main.c (mi_cmd_complete): Likewise.
5236         * mi/mi-cmds.c: Define new MI command -complete.
5237         * NEWS: Mention new -complete command.
5238
5239 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
5240
5241         * completer.h (complete): New function.
5242         * completer.c (complete): Likewise.
5243         * cli/cli-cmds.c: (complete_command): Update to use new complete()
5244         function defined in completer.h.
5245
5246 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
5247
5248         * MAINTAINERS (Write After Approval): Add myself.
5249
5250 2019-05-17  Tom de Vries  <tdevries@suse.de>
5251
5252         PR gdb/24094
5253         * dwarf2read.c (struct cu_partial_die_info): New struct.
5254         (find_partial_die): Return cu_partial_die_info.
5255         (partial_die_parent_scope, guess_partial_die_structure_name)
5256         (partial_die_info::fixup): Handle new return type of find_partial_die.
5257
5258 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5259
5260         * stap-probe.c (stap_parse_register_operand): Make "regname" an
5261         "std::string", simplifying the algorithm.
5262
5263 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5264
5265         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
5266         (stap_static_probe_ops::get_probes): Likewise.
5267
5268 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5269
5270         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
5271         '-')" and "else if".
5272         (stap_parse_single_operand): Join checks for
5273         "gdbarch_stap_parse_special_token_p" and
5274         "gdbarch_stap_parse_special_token" in the same "if" statement.
5275         Invert check when verifying for operation on register
5276         displacement.
5277
5278 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5279
5280         * stap-probe.c (stap_get_opcode): Update comment.
5281         (stap_get_expected_argument_type): Likewise.
5282         (handle_stap_probe): Likewise.
5283
5284 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5285
5286         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
5287         return type to 'bool'.  Adjust comment.  Use 'bool' when
5288         appropriate.
5289         (i386_stap_parse_special_token_three_arg_disp): Likewise.
5290         * stap-probe.c (stap_parse_argument_1): Likewise.
5291         (stap_is_operator): Likewise.
5292         (stap_is_generic_prefix): Likewise.
5293         (stap_is_register_prefix): Likewise.
5294         (stap_is_register_indirection_prefix): Likewise.
5295         (stap_is_integer_prefix): Likewise.
5296         (stap_generic_check_suffix): Likewise.
5297         (stap_check_integer_suffix): Likewise.
5298         (stap_check_register_suffix): Likewise.
5299         (stap_check_register_indirection_suffix): Likewise.
5300         (stap_parse_register_operand): Likewise.
5301         (stap_parse_single_operand): Likewise.
5302         (stap_parse_argument_1): Likewise.
5303         (stap_probe::get_argument_count): Likewise.
5304         (stap_is_operator): Likewise.
5305
5306 2019-05-16  Tom Tromey  <tromey@adacore.com>
5307
5308         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
5309         keyword to foreach.
5310
5311 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
5312
5313         * linux-thread-db.c (try_thread_db_load_1): Change return type
5314         to bool.
5315         (try_thread_db_load): Likewise.
5316         (try_thread_db_load_from_pdir_1): Likewise.
5317         (try_thread_db_load_from_pdir): Likewise.
5318         (try_thread_db_load_from_sdir): Likewise.
5319         (try_thread_db_load_from_dir): Likewise.
5320         (thread_db_load_search): Likewise.
5321         (has_libpthread): Likewise.
5322         (thread_db_load): Likewise.
5323
5324 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
5325
5326         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5327         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
5328         NULL, and complain/return if that's the case.
5329
5330 2019-05-15  John Darrington <john@darrington.wattle.id.au>
5331
5332         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
5333         (advance, posn, abstract_read_memory): New functions.
5334         [struct mem_read_abstraction]: New struct.
5335         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
5336
5337 2019-05-14  Tom Tromey  <tromey@adacore.com>
5338
5339         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
5340         value is not lval_memory.
5341
5342 2019-05-14  Tom Tromey  <tromey@adacore.com>
5343
5344         * solib.c (info_sharedlibrary_command): Style the file name.
5345
5346 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
5347
5348         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
5349         (aarch64_vnv_type): Likewise.
5350         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
5351         * common/tdesc.c: Likewise.
5352         * common/tdesc.h (enum tdesc_type_kind): Likewise.
5353         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
5354         * features/aarch64-fpu.xml: Add ieee half view.
5355         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
5356         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
5357         * gdbtypes.h (struct builtin_type): Likewise.
5358         (struct objfile_type): Likewise.
5359
5360 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
5361
5362         * language.c (language_sniff_from_mangled_name): Fix "langauge"
5363         typo.
5364         * location.h (string_to_event_location): Likewise.
5365
5366 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
5367
5368         GDB 8.3 released.
5369
5370 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5371
5372         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
5373         New variable declaration.
5374         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
5375         New variable.
5376         (print_one_breakpoint): Use ui_out::test_flags and new global
5377         variable to compute use_fixed_output.
5378         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
5379         Remove.
5380         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
5381         (mi_multi_location_breakpoint_output_fixed): Remove.
5382         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
5383         new variable.
5384         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
5385         fix_multi_location_breakpoint_output flag if version >= 3.
5386         * ui-out.h (enum ui_out_flag)
5387         <fix_multi_location_breakpoint_output>: New enumerator.
5388
5389 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5390
5391         * contrib/cc-with-tweaks.sh: Validate dwz's work.
5392
5393 2019-05-10  Tom Tromey  <tromey@adacore.com>
5394
5395         * ada-lang.c (catch_ada_completer): New function.
5396         (_initialize_ada_language): Use it.
5397
5398 2019-05-10  Tom Tromey  <tromey@adacore.com>
5399
5400         * thread.c (print_thread_info): Make "requested_threads" const.
5401         * gdbthread.h (print_thread_info): Make "requested_threads"
5402         const.
5403         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5404         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
5405
5406 2019-05-08  Tom Tromey  <tom@tromey.com>
5407
5408         * gdbtypes.c (objfile_type_data): Change type.
5409         (objfile_type, _initialize_gdbtypes): Update.
5410
5411 2019-05-08  Tom Tromey  <tom@tromey.com>
5412
5413         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
5414         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
5415         (_initialize_dwarf2_frame): Update.
5416
5417 2019-05-08  Tom Tromey  <tom@tromey.com>
5418
5419         * objc-lang.c (objc_objfile_data): Change type.
5420         (find_methods): Update.
5421         (_initialize_objc_lang): Remove.
5422
5423 2019-05-08  Tom Tromey  <tom@tromey.com>
5424
5425         * stabsread.c (rs6000_builtin_type_data): Change type.
5426         (rs6000_builtin_type, _initialize_stabsread): Update.
5427
5428 2019-05-08  Tom Tromey  <tom@tromey.com>
5429
5430         * mips-tdep.c (mips_pdr_data): Remove.
5431         (_initialize_mips_tdep): Update.
5432
5433 2019-05-08  Tom Tromey  <tom@tromey.com>
5434
5435         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5436         (hppa_init_objfile_priv_data, read_unwind_info)
5437         (find_unwind_entry, _initialize_hppa_tdep): Update.
5438
5439 2019-05-08  Tom Tromey  <tom@tromey.com>
5440
5441         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5442         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
5443         on obstack.
5444         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5445
5446 2019-05-08  Tom Tromey  <tom@tromey.com>
5447
5448         * mdebugread.c (basic_type_data): Change type.
5449         (basic_type, _initialize_mdebugread): Update.
5450
5451 2019-05-08  Tom Tromey  <tom@tromey.com>
5452
5453         * common/gdb_unique_ptr.h (struct noop_deleter): New.
5454
5455 2019-05-08  Tom Tromey  <tom@tromey.com>
5456
5457         * nto-tdep.c (nto_inferior_data_reg): Change type.
5458         (nto_inferior_data): Update.
5459         (nto_inferior_data_cleanup, nto_new_inferior_data)
5460         (_initialize_nto_tdep): Remove.
5461         * nto-tdep.h (struct nto_inferior_data): Add initializers.
5462
5463 2019-05-08  Tom Tromey  <tom@tromey.com>
5464
5465         * ada-lang.c (struct ada_inferior_data): Add initializers.
5466         (ada_inferior_data): Change type.
5467         (ada_inferior_data_cleanup): Remove.
5468         (get_ada_inferior_data, ada_inferior_exit)
5469         (struct ada_pspace_data): Add initializers, destructor.
5470         (ada_pspace_data_handle): Change type.
5471         (get_ada_pspace_data): Update.
5472         (ada_pspace_data_cleanup): Remove.
5473
5474 2019-05-08  Tom Tromey  <tom@tromey.com>
5475
5476         * coffread.c (struct coff_symfile_info): Add initializers.
5477         (coff_objfile_data_key): Move lower.  Change type.
5478         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5479         Update.
5480         (coff_free_info): Remove.
5481
5482 2019-05-08  Tom Tromey  <tom@tromey.com>
5483
5484         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5485         (fbsd_pspace_data_handle): Move lower.  Change type.
5486         (get_fbsd_pspace_data): Update.
5487         (fbsd_pspace_data_cleanup): Remove.
5488         (_initialize_fbsd_tdep): Update.
5489
5490 2019-05-08  Tom Tromey  <tom@tromey.com>
5491
5492         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5493         (get_ada_tasks_pspace_data): Update.
5494         (ada_tasks_pspace_data_cleanup): Remove.
5495         (_initialize_tasks): Update.
5496         (ada_tasks_inferior_data_handle): Change type.
5497         (get_ada_tasks_inferior_data): Update.
5498         (ada_tasks_inferior_data_cleanup): Remove.
5499         (struct ada_tasks_pspace_data): Add initializers.
5500
5501 2019-05-08  Tom Tromey  <tom@tromey.com>
5502
5503         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5504         * symfile-debug.c (debug_sym_get_probes): Change type.
5505         * stap-probe.c (handle_stap_probe):
5506         (stap_static_probe_ops::get_probes): Change type.
5507         * probe.h (class static_probe_ops) <get_probes>: Change type.
5508         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5509         (parse_probes_in_pspace): Update.
5510         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5511         Update.
5512         (any_static_probe_ops::get_probes): Change type.
5513         * elfread.c (elfread_data): New typedef.
5514         (probe_key): Change type.
5515         (elf_get_probes): Likewise.  Update.
5516         (probe_key_free): Remove.
5517         (_initialize_elfread): Update.
5518         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5519         Change type.
5520         (dtrace_process_dof_probe, dtrace_process_dof)
5521         (dtrace_static_probe_ops::get_probe): Change type.
5522
5523 2019-05-08  Tom Tromey  <tom@tromey.com>
5524
5525         * xcoffread.c (struct xcoff_symfile_info): Rename from
5526         coff_symfile_info.  Add initializers.
5527         (xcoff_objfile_data_key): Move lower.  Change type.
5528         (XCOFF_DATA): Rewrite.
5529         (xcoff_free_info): Remove.
5530         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5531         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5532         (xcoff_initial_scan): Update.
5533
5534 2019-05-08  Tom Tromey  <tom@tromey.com>
5535
5536         * solib-svr4.c (struct svr4_info): Add initializers and
5537         destructor.
5538         <probes_table>: Now an htab_up.
5539         (solib_svr4_pspace_data): Change type.
5540         (free_probes_table): Simplify.
5541         (~svr4_info): Rename from svr4_pspace_data_cleanup.
5542         (get_svr4_info, probes_table_htab_remove_objfile_probes)
5543         (probes_table_remove_objfile_probes, register_solib_event_probe)
5544         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5545         (_initialize_svr4_solib): Update.
5546
5547 2019-05-08  Tom Tromey  <tom@tromey.com>
5548
5549         * remote.c (remote_pspace_data): Change type.
5550         (remote_pspace_data_cleanup): Remove.
5551         (get_remote_exec_file, set_pspace_remote_exec_file)
5552         (_initialize_remote): Update.
5553
5554 2019-05-08  Tom Tromey  <tom@tromey.com>
5555
5556         * breakpoint.c (breakpoint_objfile_key): Change type.
5557         (get_breakpoint_objfile_data): Update.
5558         (free_breakpoint_objfile_data): Remove.
5559         (_initialize_breakpoint): Update.
5560
5561 2019-05-08  Tom Tromey  <tom@tromey.com>
5562
5563         * linux-tdep.c (struct linux_info): Add initializers.
5564         (linux_inferior_data): Move.  Change type.
5565         (invalidate_linux_cache_inf): Update.
5566         (linux_inferior_data_cleanup): Remove.
5567         (get_linux_inferior_data, _initialize_linux_tdep): Update.
5568
5569 2019-05-08  Tom Tromey  <tom@tromey.com>
5570
5571         * auxv.c (auxv_inferior_data): Move.  Change type.
5572         (auxv_inferior_data_cleanup): Remove.
5573         (invalidate_auxv_cache_inf): Rewrite.
5574         (get_auxv_inferior_data, _initialize_auxv): Update.
5575
5576 2019-05-08  Tom Tromey  <tom@tromey.com>
5577
5578         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5579         (symfile_debug_objfile_data_key): Change type.
5580         (symfile_debug_installed, debug_qf_has_symbols)
5581         (debug_qf_find_last_source_symtab)
5582         (debug_qf_forget_cached_source_info)
5583         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5584         (debug_qf_print_stats, debug_qf_dump)
5585         (debug_qf_expand_symtabs_for_function)
5586         (debug_qf_expand_all_symtabs)
5587         (debug_qf_expand_symtabs_with_fullname)
5588         (debug_qf_map_matching_symbols)
5589         (debug_qf_expand_symtabs_matching)
5590         (debug_qf_find_pc_sect_compunit_symtab)
5591         (debug_qf_map_symbol_filenames)
5592         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5593         (debug_sym_new_init, debug_sym_init, debug_sym_read)
5594         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5595         (debug_sym_read_linetable, debug_sym_relocate): Update.
5596         (symfile_debug_free_objfile): Remove.
5597         (install_symfile_debug_logging, _initialize_symfile_debug):
5598         Update.
5599
5600 2019-05-08  Tom Tromey  <tom@tromey.com>
5601
5602         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5603         allocate_on_obstack.
5604         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5605         (get_dwarf2_per_objfile): Update.
5606         (set_dwarf2_per_objfile): Remove.
5607         (dwarf2_has_info, dwarf2_get_section_info): Update.
5608         (dwarf2_free_objfile): Remove.
5609         (_initialize_dwarf2_read): Update.
5610
5611 2019-05-08  Tom Tromey  <tom@tromey.com>
5612
5613         * auto-load.c (struct auto_load_pspace_info): Add destructor and
5614         initializers.
5615         <unsupported_script_warning_printed,
5616         script_not_found_warning_printed>: Now bool.
5617         (auto_load_pspace_data): Change type.
5618         (~auto_load_pspace_info): Rename from
5619         auto_load_pspace_data_cleanup.
5620         (get_auto_load_pspace_data, init_loaded_scripts_info)
5621         (clear_section_scripts, maybe_print_unsupported_script_warning)
5622         (maybe_print_script_not_found_warning, _initialize_auto_load):
5623         Update.
5624
5625 2019-05-08  Tom Tromey  <tom@tromey.com>
5626
5627         * objfiles.c (objfile_pspace_info): Add destructor and
5628         initializers.
5629         (objfiles_pspace_data): Change type.
5630         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5631         (get_objfile_pspace_data): Update.
5632         (objfiles_bfd_data): Change type.
5633         (get_objfile_bfd_data): Update.
5634         (objfile_bfd_data_free, _initialize_objfiles): Remove.
5635
5636 2019-05-08  Tom Tromey  <tom@tromey.com>
5637
5638         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5639         Change type.
5640         (get_catch_syscall_inferior_data): Update.
5641         (catch_syscall_inferior_data_cleanup): Remove.
5642         (_initialize_break_catch_syscall): Update.
5643
5644 2019-05-08  Tom Tromey  <tom@tromey.com>
5645
5646         * inflow.c (struct terminal_info): Add destructor and
5647         initializers.
5648         (inflow_inferior_data): Change type.
5649         (~terminal_info): Rename from inflow_inferior_data_cleanup.
5650         (get_inflow_inferior_data, inflow_inferior_exit)
5651         (swap_terminal_info, _initialize_inflow): Update.
5652
5653 2019-05-08  Tom Tromey  <tom@tromey.com>
5654
5655         * target-dcache.c (target_dcache_cleanup): Remove.
5656         (target_dcache_aspace_key): Change type.
5657         (target_dcache_init_p, target_dcache_invalidate)
5658         (target_dcache_get, target_dcache_get_or_init)
5659         (_initialize_target_dcache): Update.
5660         * dcache.h (struct dcache_deleter): New.
5661
5662 2019-05-08  Tom Tromey  <tom@tromey.com>
5663
5664         * symtab.c (struct symbol_cache): Add destructor and
5665         initializers.
5666         (symbol_cache_key): Move.  Change type.
5667         (make_symbol_cache, free_symbol_cache): Remove.
5668         (get_symbol_cache): Update.
5669         (symbol_cache_cleanup): Remove.
5670         (ALL_PSPACES, symbol_cache_flush)
5671         (maintenance_print_symbol_cache)
5672         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5673         Update.
5674
5675 2019-05-08  Tom Tromey  <tom@tromey.com>
5676
5677         * symtab.c (struct main_info): Add destructor and initializers.
5678         (main_progspace_key): Move.  Change type.
5679         (get_main_info): Update.
5680         (main_info_cleanup): Remove.
5681         (_initialize_symtab): Update.
5682
5683 2019-05-08  Tom Tromey  <tom@tromey.com>
5684
5685         * registry.h (DECLARE_REGISTRY): Define the _key class.
5686
5687 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5688
5689         * NEWS: Merge two 'New commands' sections.
5690
5691 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5692
5693         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5694         parameter and use Ada language definition instead.
5695         (ada_val_print_ptr): Remove unused language parameter.
5696         (ada_val_print_num): Remove language parameter and use Ada language
5697         definition instead.
5698         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5699         parameter.
5700         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5701         parameter and use Ada language definition instead.
5702         (ada_val_print_1): Update all ada_val_print_xxx calls.
5703         Remove language parameter.
5704         (ada_val_print): Update ada_val_print_1 call.
5705
5706 2019-05-08  Tom Tromey  <tromey@adacore.com>
5707
5708         * remote.c (remote_hw_watchpoint_limit)
5709         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5710         Now static.
5711
5712 2019-05-08  Tom Tromey  <tromey@adacore.com>
5713
5714         * maint.c (_initialize_maint_cmds): Move initialization code to
5715         remote.c.
5716         (watchdog, show_watchdog): Move to remote.c.
5717         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5718         "watchdog" static.
5719         (_initialize_remote): Move initialization code from maint.c.
5720         * defs.h (watchdog): Don't declare.
5721
5722 2019-05-08  Tom Tromey  <tromey@adacore.com>
5723
5724         * tui/tui-interp.c: Include main.h.
5725         * interps.c: Include main.h.
5726         * main.h (interpreter_p): Declare.
5727         * defs.h (interpreter_p): Don't declare.
5728
5729 2019-05-08  Tom Tromey  <tromey@adacore.com>
5730
5731         * dwarf2loc.c: Include dwarf2read.h.
5732         * defs.h (read_unsigned_leb128): Don't declare.
5733         * dwarf2read.h (read_unsigned_leb128): Declare.
5734
5735 2019-05-08  Tom Tromey  <tromey@adacore.com>
5736
5737         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5738         method.
5739
5740 2019-05-08  Tom Tromey  <tromey@adacore.com>
5741
5742         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5743         when no wrap column is set.
5744
5745 2019-05-08  Tom Tromey  <tromey@adacore.com>
5746
5747         * c-lang.c (c_get_string): Handle non-C-style arrays.
5748
5749 2019-05-08  Tom Tromey  <tromey@adacore.com>
5750
5751         * typeprint.c (print_offset_data::update): Print the bit offset,
5752         not the number of bits remaining.
5753
5754 2019-05-08  Tom Tromey  <tromey@adacore.com>
5755
5756         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5757         padding at end of comment.
5758
5759 2019-05-08  Tom Tromey  <tromey@adacore.com>
5760
5761         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5762         Compare main types.
5763
5764 2019-05-06  Tom Tromey  <tom@tromey.com>
5765
5766         * common/scoped_mmap.c: Include common-defs.h.
5767         * common/scoped_mmap.h: Don't include config.h.
5768
5769 2019-05-04  Tom Tromey  <tom@tromey.com>
5770
5771         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5772         (struct aarch64_call_info): Add initializers.
5773         <si>: Now a std::vector.
5774         (pass_on_stack, aarch64_push_dummy_call): Update.
5775
5776 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5777             Tom Tromey  <tom@tromey.com>
5778
5779         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5780         (ppc_threads): Now a std::vector.  Now static.
5781         (hwdebug_find_thread_points_by_tid)
5782         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5783         Update.
5784
5785 2019-05-04  Tom Tromey  <tom@tromey.com>
5786
5787         * arc-tdep.c (arc_tdesc_init): Return bool.
5788
5789 2019-05-04  Tom Tromey  <tom@tromey.com>
5790
5791         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5792         Use gdb_assert_not_reached.
5793
5794 2019-05-04  Tom Tromey  <tom@tromey.com>
5795
5796         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5797         "false".
5798
5799 2019-05-04  Tom Tromey  <tom@tromey.com>
5800
5801         * arc-tdep.c (arc_tdesc_init): Use bool.
5802
5803 2019-05-04  Tom Tromey  <tom@tromey.com>
5804
5805         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5806
5807 2019-05-04  Tom Tromey  <tom@tromey.com>
5808
5809         * cli/cli-cmds.c (valid_command_p): Return bool.
5810
5811 2019-05-04  Tom Tromey  <tom@tromey.com>
5812
5813         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5814         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5815
5816 2019-05-04  Raul Tambre  <raul@tambre.ee>
5817
5818         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5819         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5820         operator for comparison.
5821
5822 2019-05-04  Tom Tromey  <tom@tromey.com>
5823
5824         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5825         (lookup_partial_symbol, print_partial_symbols)
5826         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5827         (psymbol_compare): Update.
5828         (add_psymbol_to_bcache): Clear the entire psymbol.
5829         (maintenance_check_psymtabs): Update.
5830         * psympriv.h (struct partial_symbol): Don't derive from
5831         general_symbol_info.
5832         <obj_section, unrelocated_address, address,
5833         set_unrelocated_address>: Update.
5834         <ginfo>: New member.
5835         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5836         (debug_names::write_psymbols): Update.
5837
5838 2019-05-04  Tom de Vries  <tdevries@suse.de>
5839
5840         * contrib/cc-with-tweaks.sh: Support -n arg.
5841
5842 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5843
5844         * corelow.c (core_target::detach): Ensure frame cache and
5845         register caches are cleared.
5846         inferior.c (exit_inferior_1): Likewise.
5847
5848 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5849             Tom Tromey  <tom@tromey.com>
5850
5851         * dictionary.c (collate_pending_symbols_by_language): Remove
5852         "struct" from foreach.
5853         * symtab.c (lookup_global_symbol_from_objfile)
5854         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5855         foreach.
5856         * ser-tcp.c (net_open): Remove "struct" from foreach.
5857         * objfiles.c (objfile_relocate, objfile_rebase)
5858         (objfile_has_symbols): Remove "struct" from foreach.
5859         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5860         from foreach.
5861         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5862         foreach.
5863         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5864         "struct" from foreach.
5865         * ada-lang.c (create_excep_cond_exprs)
5866         (ada_exception_catchpoint_cond_string): Remove "struct" from
5867         foreach.
5868
5869 2019-05-03  Tom Tromey  <tromey@adacore.com>
5870
5871         * ada-exp.y (convert_char_literal): Check suffix of each
5872         enumerator.
5873
5874 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5875
5876         PR ada/21406:
5877         * ada-exp.y (yywrap): Don't define.
5878         * ada-lex.l (%option): Add noyywrap
5879         (yywrap): Remove.
5880
5881 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5882
5883         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5884         _WIN32_WINNT to the XP level, unless already defined to a higher
5885         level.
5886
5887         * unittests/parse-connection-spec-selftests.c:
5888         * ser-tcp.c:
5889         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5890         override.
5891
5892         * symfile.c (find_separate_debug_file): Remove colon from the
5893         drive spec of DOS/Windows file names of the target, so that the
5894         file name produced from DEBUGDIR and the target's directory will
5895         be valid on DOS/Windows systems.
5896
5897 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5898
5899         * rust-lang.c (val_print_struct): Handle printing structures
5900         containing strings.
5901
5902 2019-05-02  Tom Tromey  <tromey@adacore.com>
5903
5904         * valarith.c (_initialize_valarith): Remove.
5905
5906 2019-05-01  Tom Tromey  <tromey@adacore.com>
5907
5908         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5909         bitfields.
5910
5911 2019-05-01  Tom Tromey  <tromey@adacore.com>
5912
5913         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5914         for big-endian copies.
5915
5916 2019-04-30  Ali Tamur  <tamur@google.com>
5917         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5918         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5919         (read_3_bytes): New function.
5920
5921 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5922
5923         * windows-nat.c (main_thread_id): Delete.
5924         (handle_output_debug_string): Replace main_thread_id by
5925         current_event.dwThreadId.
5926         (fake_create_process): Likewise.
5927         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5928         Do not set main_thread_id.
5929         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5930         current_event.dwThreadId.
5931         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5932
5933 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5934
5935         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5936         Use current_event.dwThreadId instead of main_thread_id.
5937
5938 2019-04-30  Tom Tromey  <tromey@adacore.com>
5939
5940         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5941         (create_excep_cond_exprs): Iterate over program spaces.
5942         (ada_exception_catchpoint_cond_string): Examine all minimal
5943         symbols for exception types.
5944
5945 2019-04-30  Tom Tromey  <tromey@adacore.com>
5946
5947         PR c++/24470:
5948         * dwarf2read.c (process_structure_scope): Handle case where type
5949         has template parameters but no symbol was created.
5950
5951 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5952             Chris January  <chris.january@arm.com>
5953
5954         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5955         qualifier.
5956         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5957
5958 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5959
5960         * f-typeprint.c (f_print_type): Update rules for printing
5961         whitespace.
5962         (f_type_print_varspec_suffix): Likewise.
5963
5964 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5965             Chris January  <chris.january@arm.com>
5966
5967         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5968         function arguments.
5969
5970 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5971
5972         * f-lang.c (build_fortran_types): Change name of void type to
5973         lower case.
5974         * f-typeprint.c (f_type_print_base): Print the name of the void
5975         type, rather than a fixed string.
5976         * f-valprint.c (f_decorations): Use lower case void string.
5977
5978 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5979             Chris January  <chris.january@arm.com>
5980
5981         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5982         types for Fortran.
5983
5984 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5985             Chris January  <chris.january@arm.com>
5986             David Lecomber  <david.lecomber@arm.com>
5987
5988         * f-exp.y (BINOP_INTRINSIC): New token.
5989         (exp): New parser rule handling BINOP_INTRINSIC.
5990         (f77_keywords): Add new builtin procedures.
5991         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5992         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5993         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5994         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5995         (print_unop_subexp_f): New function.
5996         (print_binop_subexp_f): New function.
5997         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5998         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5999         (dump_subexp_body_f): Likewise.
6000         (operator_check_f): Likewise.
6001         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6002         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
6003
6004 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6005
6006         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
6007         UNOP_KIND.
6008         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
6009         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
6010         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
6011         (operator_length_f): New fuction.
6012         (print_subexp_f): New function.
6013         (op_name_f): New function.
6014         (dump_subexp_body_f): New function.
6015         (operator_check_f): New function.
6016         (exp_descriptor_f): Replace standard expression handling functions
6017         with new functions.
6018         * gdb/fortran-operator.def: New file.
6019         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
6020         * gdb/std-operator.def: Remove UNOP_KIND.
6021
6022 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6023
6024         * std-operator.def: Remove unbalanced, stray double quote
6025         character.
6026
6027 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6028             Chris January  <chris.january@arm.com>
6029             Daniel Everett  <daniel.everett@arm.com>
6030             Nick Forrington  <nick.forrington@arm.com>
6031             Richard Bunt  <richard.bunt@arm.com>
6032
6033         * cp-valprint.c (cp_print_value_fields): Allow an additional level
6034         of depth when printing anonymous structs or unions.
6035         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
6036         Don't print either the top-level value, or the children if the
6037         max-depth is exceeded.
6038         (ppscm_print_children): When printing the key of a map, allow one
6039         extra level of depth.
6040         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
6041         print either the top-level value, or the children if the max-depth
6042         is exceeded.
6043         (print_children): When printing the key of a map, allow one extra
6044         level of depth.
6045         * python/py-value.c (valpy_format_string): Add max_depth keyword.
6046         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
6047         (user_print_options): Initialise max_depth field.
6048         (val_print_scalar_or_string_type_p): New function.
6049         (val_print): Check to see if the max depth has been reached.
6050         (val_print_check_max_depth): Define new function.
6051         (show_print_max_depth): New function.
6052         (_initialize_valprint): Add 'print max-depth' option.
6053         * valprint.h (struct value_print_options) <max_depth>: New field.
6054         (val_print_check_max_depth): Declare new function.
6055         * NEWS: Document new feature.
6056
6057 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6058
6059         * ada-lang.c (ada_language_defn): Initialise new field.
6060         * c-lang.c (c_is_string_type_p): New function.
6061         (c_language_defn): Initialise new field.
6062         (cplus_language_defn): Initialise new field.
6063         (asm_language_defn): Initialise new field.
6064         (minimal_language_defn): Initialise new field.
6065         * c-lang.h (c_is_string_type_p): Declare new function.
6066         * d-lang.c (d_language_defn): Initialise new field.
6067         * f-lang.c (f_is_string_type_p): New function.
6068         (f_language_defn): Initialise new field.
6069         * go-lang.c (go_is_string_type_p): New function.
6070         (go_language_defn): Initialise new field.
6071         * language.c (default_is_string_type_p): New function.
6072         (unknown_language_defn): Initialise new field.
6073         (auto_language_defn): Initialise new field.
6074         * language.h (struct language_defn) <la_is_string_type_p>: New
6075         member variable.
6076         (default_is_string_type_p): Declare new function.
6077         * m2-lang.c (m2_language_defn): Initialise new field.
6078         * objc-lang.c (objc_language_defn): Initialise new field.
6079         * opencl-lang.c (opencl_language_defn): Initialise new field.
6080         * p-lang.c (pascal_is_string_type_p): New function.
6081         (pascal_language_defn): Initialise new field.
6082         * rust-lang.c (rust_is_string_type_p): New function.
6083         (rust_language_defn): Initialise new field.
6084
6085 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6086
6087         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
6088         New field.
6089         * ada-lang.c (ada_language_defn): Initialise new field.
6090         * c-lang.c (c_language_defn): Likewise.
6091         (cplus_language_defn): Likewise.
6092         (asm_language_defn): Likewise.
6093         (minimal_language_defn): Likewise.
6094         * d-lang.c (d_language_defn): Likewise.
6095         * f-lang.c (f_language_defn): Likewise.
6096         * go-lang.c (go_language_defn): Likewise.
6097         * language.c (unknown_language_defn): Likewise.
6098         (auto_language_defn): Likewise.
6099         * m2-lang.c (m2_language_defn): Likewise.
6100         * objc-lang.c (objc_language_defn): Likewise.
6101         * opencl-lang.c (opencl_language_defn): Likewise.
6102         * p-lang.c (pascal_language_defn): Likewise.
6103         * rust-lang.c (rust_language_defn): Likewise.
6104
6105 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6106
6107         * ada-lang.c (ada_is_character_type): Change return type to bool.
6108         (ada_is_string_type): Likewise.
6109         * ada-lang.h (ada_is_character_type): Update declaration
6110         (ada_is_string_type): Likewise.
6111
6112 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6113
6114         Support style in 'frame|thread apply'
6115
6116         * gdbcmd.h (execute_command_to_string): New term_out parameter.
6117         * record.c (record_start, record_stop): Update callers of
6118         execute_command_to_string with false.
6119         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
6120         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
6121         methods.
6122         (class string_file): New constructor with term_out parameter.
6123         Override methods term_out and can_emit_style_escape.  New member
6124         term_out.
6125         (class stdio_file): Override can_emit_style_escape.
6126         (class tee_file): Override term_out and can_emit_style_escape.
6127         * utils.h (can_emit_style_escape): Remove.
6128         * utils.c (can_emit_style_escape): Likewise.
6129         Update all callers of can_emit_style_escape (SOMESTREAM) to
6130         SOMESTREAM->can_emit_style_escape.
6131         * source-cache.c (source_cache::get_source_lines): Likewise.
6132         * stack.c (frame_apply_command_count): Call execute_command_to_string
6133         passing the term_out characteristic of the current gdb_stdout.
6134         * thread.c (thr_try_catch_cmd): Likewise.
6135         * top.c (execute_command_to_string): pass term_out parameter
6136         to construct the string_file for the command output.
6137         * ui-file.c (term_cli_styling): New function (most code moved
6138         from utils.c can_emit_style_escape).
6139         (string_file::string_file, string_file::can_emit_style_escape,
6140         stdio_file::can_emit_style_escape, tee_file::term_out,
6141         tee_file::can_emit_style_escape): New functions.
6142
6143 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6144
6145         * NEWS: Mention the new set|show may-call-functions.
6146         * infcall.c (may_call_functions_p): New variable.
6147         (show_may_call_functions_p): New function.
6148         (call_function_by_hand_dummy): Throws an error if not
6149         may-call-functions.
6150         (_initialize_infcall): Call add_setshow_boolean_cmd for
6151         may-call-functions.
6152
6153 2019-04-25  Keith Seitz  <keiths@redhat.com>
6154
6155         PR c++/24367
6156         * cp-support.c (inspect_type): Don't attempt substitutions
6157         of symbol with the same name.
6158
6159 2019-04-25  Tom Tromey  <tromey@adacore.com>
6160
6161         PR gdb/24475:
6162         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
6163         static.
6164
6165 2019-04-25  Tom Tromey  <tromey@adacore.com>
6166
6167         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
6168         rvalue reference.
6169         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
6170         (gdb_xml_parser::parse): Use std::move.
6171         * python/python-internal.h (gdbpy_convert_exception): Take a const
6172         reference.
6173         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
6174         std::move.
6175         * python/py-utils.c (gdbpy_convert_exception): Take a const
6176         reference.
6177         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6178         Use std::move.
6179         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6180         Use std::move.
6181         * mi/mi-main.c (mi_print_exception): Take a const reference.
6182         * main.c (handle_command_errors): Take a const reference.
6183         * linespec.c (parse_linespec): Use std::move.
6184         * infcall.c (run_inferior_call): Use std::move.
6185         (call_function_by_hand_dummy): Use std::move.
6186         * exec.c (try_open_exec_file): Use std::move.
6187         * exceptions.h (exception_print, exception_fprintf)
6188         (exception_print_same): Update.
6189         * exceptions.c (print_exception, exception_print)
6190         (exception_fprintf, exception_print_same): Change parameters to
6191         const reference.
6192         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
6193         * common/new-op.c: Use std::move.
6194         * common/common-exceptions.h (struct gdb_exception): Add move
6195         constructor.
6196         (struct gdb_exception_error, struct gdb_exception_quit, struct
6197         gdb_quit_bad_alloc): Change constructor to move constructor.
6198         (throw_exception): Change parameter to rvalue reference.
6199         * common/common-exceptions.c (throw_exception): Take rvalue
6200         reference.
6201         * cli/cli-interp.c (safe_execute_command): Use std::move.
6202         * breakpoint.c (insert_bp_location, location_to_sals): Use
6203         std::move.
6204
6205 2019-04-25  Tom Tromey  <tromey@adacore.com>
6206
6207         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
6208         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
6209         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
6210         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
6211         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
6212         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
6213         guile/scm-value.c: Use unpack.
6214         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
6215         gdbscm_gdb_exception.
6216         (gdbscm_throw_gdb_exception): Likewise.
6217         (struct gdbscm_gdb_exception): New.
6218         (unpack): New function.
6219         (gdbscm_wrap): Use unpack.
6220
6221 2019-04-25  Tom Tromey  <tromey@adacore.com>
6222
6223         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6224         (gdb_rl_callback_handler): Use std::move.
6225         * common/common-exceptions.h (struct gdb_exception): Add move
6226         assignment operator.
6227         (throw_exception_sjlj): Change "exception" to const reference.
6228         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
6229         (throw_exception_sjlj): Change "exception" to const reference.
6230
6231 2019-04-25  Tom Tromey  <tromey@adacore.com>
6232
6233         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
6234         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
6235         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6236         Update.
6237         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6238         Update.
6239         * mi/mi-interp.c (mi_interp::exec): Update.
6240         * linespec.c (parse_linespec): Update.
6241         * infcall.c (run_inferior_call): Update.
6242         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
6243         * guile/scm-symbol.c (gdbscm_lookup_symbol)
6244         (gdbscm_lookup_global_symbol): Update.
6245         * guile/scm-param.c (gdbscm_parameter_value): Update.
6246         * guile/scm-frame.c (gdbscm_frame_read_register)
6247         (gdbscm_frame_read_var): Update.
6248         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
6249         * exec.c (try_open_exec_file): Update.
6250         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6251         (gdb_rl_callback_handler): Update.
6252         * common/common-exceptions.h (exception_none): Don't declare.
6253         * common/common-exceptions.c (exception_none): Don't define.
6254         (struct catcher) <exception>: Update.
6255         * cli/cli-interp.c (safe_execute_command): Update.
6256         * breakpoint.c (insert_bp_location, location_to_sals): Update.
6257
6258 2019-04-25  Ali Tamur  <tamur@google.com>
6259
6260         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
6261         (read_attribute_value): Likewise.
6262         (dwarf2_read_addr_index): Update comment.
6263         (read_str_index): Add DW_FORM_strx.
6264         (dwarf2_string_attr): Likewise.
6265         (dwarf2_const_value_attr): Likewise.
6266         (dump_die_shallow): Likewise.
6267         (dwarf2_fetch_constant_bytes): Likewise.
6268         (skip_form_bytes): Likewise.
6269         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
6270
6271 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
6272
6273         PR corefiles/11608
6274         PR corefiles/18187
6275         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
6276         OFFSET.  Verify if current mapping contains an ELF header.
6277         (linux_find_memory_regions_full): Adjust call to
6278         dump_mapping_p.
6279
6280 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
6281             Kang Li <kanglictf@gmail.com>
6282
6283         PR gdb/21600
6284
6285         * dwarf2-frame.c (read_initial_length): Be consistent about using
6286         unsigned representation of length.
6287         (decode_frame_entry_1): Likewise.  Check for wraparound of
6288         end pointer as well as buffer overflow.
6289
6290 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
6291
6292         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
6293         "vq".
6294
6295 2019-04-24  Tom Tromey  <tromey@adacore.com>
6296
6297         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
6298
6299 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6300
6301         * s12z-tdep.c (s12z_unwind_pc): Delete.
6302         (s12z_unwind_sp): Delete.
6303         (s12z_gdbarch_init): Don't register deleted functions with
6304         gdbarch.
6305
6306 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6307
6308         * rl78-tdep.c (rl78_unwind_sp): Delete.
6309         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
6310
6311 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6312
6313         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
6314         (xstormy16_unwind_pc): Delete.
6315         (xstormy16_dummy_id): Delete.
6316         (xstormy16_gdbarch_init): Don't register deleted functions with
6317         gdbarch.
6318
6319 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6320
6321         * vax-tdep.c (vax_unwind_pc): Delete.
6322         (vax_gdbarch_init): Don't register deleted function with gdbarch.
6323
6324 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6325
6326         * v850-tdep.c (v850_unwind_sp): Delete.
6327         (v850_unwind_pc): Delete.
6328         (v850_dummy_id): Delete.
6329         (v850_gdbarch_init): Don't register deleted functions with
6330         gdbarch.
6331
6332 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6333
6334         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
6335         (tilegx_unwind_pc): Delete.
6336         (tilegx_unwind_dummy_id): Delete.
6337         (tilegx_gdbarch_init): Don't register deleted functions with
6338         gdbarch.
6339
6340 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6341
6342         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
6343         (tic6x_dummy_id): Delete.
6344         (tic6x_gdbarch_init): Don't register deleted functions with
6345         gdbarch.
6346
6347 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6348
6349         * sparc-tdep.c (sparc_unwind_pc): Delete.
6350         (sparc32_gdbarch_init): Don't register deleted function with
6351         gdbarch.
6352
6353 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6354
6355         * sh-tdep.c (sh_unwind_sp): Delete.
6356         (sh_unwind_pc): Delete.
6357         (sh_dummy_id): Delete.
6358         (sh_gdbarch_init): Don't register deleted functions with
6359         gdbarch.
6360
6361 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6362
6363         * score-tdep.c (score_unwind_sp): Delete.
6364         (score_unwind_pc): Delete.
6365         (score_dummy_id): Delete.
6366         (score_gdbarch_init): Don't register deleted functions with
6367         gdbarch.
6368
6369 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6370
6371         * rx-tdep.c (rx_unwind_pc): Delete.
6372         (rx_unwind_sp): Delete.
6373         (rx_dummy_id): Delete.
6374         (rx_gdbarch_init): Don't register deleted functions with
6375         gdbarch.  Update comment.
6376
6377 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6378
6379         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
6380         (rs6000_dummy_id): Delete.
6381         (rs6000_gdbarch_init): Don't register deleted functions with
6382         gdbarch.
6383
6384 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6385
6386         * or1k-tdep.c (or1k_dummy_id): Delete.
6387         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
6388
6389 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6390
6391         * nios2-tdep.c (nios2_dummy_id): Delete.
6392         (nios2_unwind_sp): Delete.
6393         (nios2_gdbarch_init): Don't register deleted functions with
6394         gdbarch.
6395
6396 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6397
6398         * nds32-tdep.c (nds32_dummy_id): Delete.
6399         (nds32_unwind_pc): Delete.
6400         (nds32_unwind_sp): Delete.
6401         (nds32_gdbarch_init): Don't register deleted functions with
6402         gdbarch.
6403
6404 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6405
6406         * msp430-tdep.c (msp430_unwind_pc): Delete.
6407         (msp430_unwind_sp): Delete.
6408         (msp430_dummy_id): Delete.
6409         (msp430_gdbarch_init): Don't register deleted functions with
6410         gdbarch.
6411
6412 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6413
6414         * moxie-tdep.c (moxie_unwind_sp): Delete.
6415         (moxie_unwind_pc): Delete.
6416         (moxie_dummy_id): Delete.
6417         (moxie_gdbarch_init): Don't register deleted functions with
6418         gdbarch.
6419
6420 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6421
6422         * mn10300-tdep.c (mn10300_dummy_id): Delete.
6423         (mn10300_unwind_pc): Delete.
6424         (mn10300_unwind_sp): Delete.
6425         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6426         mn10300_unwind_sp.
6427         (mn10300_frame_unwind_init): Don't register deleted functions with
6428         gdbarch.
6429
6430 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6431
6432         * mep-tdep.c (mep_unwind_pc): Delete.
6433         (mep_unwind_sp): Delete.
6434         (mep_dummy_id): Delete.
6435         (mep_gdbarch_init): Don't register deleted functions with
6436         gdbarch.
6437
6438 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6439
6440         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6441         (m68hc11_unwind_sp): Delete.
6442         (m68hc11_gdbarch_init): Don't register deleted functions with
6443         gdbarch.
6444
6445 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6446
6447         * m32r-tdep.c (m32r_unwind_sp): Delete.
6448         (m32r_unwind_pc): Delete.
6449         (m32r_dummy_id): Delete.
6450         (m32r_gdbarch_init): Don't register deleted functions with
6451         gdbarch.
6452
6453 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6454
6455         * m32c-tdep.c (m32c_unwind_pc): Delete.
6456         (m32c_unwind_sp): Delete.
6457         (m32c_dummy_id): Delete.
6458         (m32c_gdbarch_init): Don't register deleted functions with
6459         gdbarch.
6460
6461 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6462
6463         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6464         (lm32_unwind_pc): Delete.
6465         (lm32_dummy_id): Delete.
6466         (lm32_gdbarch_init): Don't register deleted functions with
6467         gdbarch.
6468
6469 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6470
6471         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6472         (iq2000_unwind_pc): Delete.
6473         (iq2000_dummy_id): Delete.
6474         (iq2000_gdbarch_init): Don't register deleted functions with
6475         gdbarch.
6476
6477 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6478
6479         * nds32-tdep.c (nds32_type_align): Delete.
6480         (nds32_push_dummy_call): Use type_align instead.
6481
6482 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6483
6484         * arm-tdep.c (arm_type_align): Only handle vector override case.
6485         (arm_push_dummy_call): Use type_align.
6486         (arm_gdbarch_init): Register arm_type_align gdbarch function.
6487
6488 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6489
6490         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6491         case.
6492         (pass_on_stack): Use type_align.
6493         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6494         function.
6495
6496 2019-04-23  Tom Tromey  <tromey@adacore.com>
6497
6498         * dwarf2read.c (line_header::file_name_at): Remove unused
6499         overload.
6500
6501 2019-04-23  Tom de Vries  <tdevries@suse.de>
6502
6503         PR gdb/24438
6504         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6505         invocation.
6506
6507
6508 2019-03-27  Ali Tamur  <tamur@google.com>
6509
6510         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6511         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6512         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6513         (dwarf_expr_context::get_addr_index): Likewise
6514         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6515         (symbol_needs_eval_context::get_addr_index): Likewise
6516         (disassemble_dwarf_expression): Add DW_OP_addrx
6517         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6518         (read_cutu_die_from_dwo): Update comment
6519         (skip_one_die): Add DW_FORM_addrx
6520         (read_attribute_value): Likewise
6521         (var_decode_location): Add DW_OP_addrx
6522         (dwarf2_const_value_attr): Add DW_FORM_addrx
6523         (dump_die_shallow): Likewise
6524         (dwarf2_fetch_constant_bytes): Likewise
6525         (decode_locdesc): Add DW_OP_addrx
6526         (skip_form_bytes): Add DW_FORM_addrx
6527
6528 2019-04-22  Ali Tamur  <tamur@google.com>
6529
6530         * MAINTAINERS (Write After Approval): Add self.
6531
6532 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
6533
6534         * solib-svr4.c (get_svr4_info): Add pspace parameter.
6535         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6536         (open_symbol_file_object): Likewise.
6537         (svr4_default_sos): Add info parameter.
6538         (svr4_read_so_list): Likewise.
6539         (svr4_current_sos_direct): Adjust functions calls to pass down
6540         info.
6541         (svr4_current_sos_1): Add info parameter.
6542         (svr4_current_sos): Call get_svr4_info, pass info down to
6543         svr4_current_sos_1.
6544         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6545         get_svr4_info.
6546         (svr4_in_dynsym_resolve_code): Pass current_program_space to
6547         get_svr4_info.
6548         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6549         to get_svr4_info.
6550         (probes_table_remove_objfile_probes): Likewise.
6551         (register_solib_event_probe): Add info parameter.
6552         (solist_update_incremental): Pass info parameter down to
6553         svr4_read_so_list.
6554         (disable_probes_interface): Add info parameter.
6555         (svr4_handle_solib_event): Pass current_program_space to
6556         get_svr4_info.  Adjust disable_probes_interface cleanup.
6557         (svr4_create_probe_breakpoints): Add info parameter, pass it
6558         down to register_solib_event_probe.
6559         (svr4_create_solib_event_breakpoints): Add info parameter,
6560         pass it down to svr4_create_probe_breakpoints.
6561         (enable_break): Pass info down to
6562         svr4_create_solib_event_breakpoints.
6563         (svr4_solib_create_inferior_hook): Pass current_program_space to
6564         get_svr4_info.
6565         (svr4_clear_solib): Likewise.
6566
6567 2019-04-22  Pedro Alves  <palves@redhat.com>
6568
6569         * solib-svr4.c (svr4_free_objfile_observer): New.
6570         (probe_and_action::objfile): New field.
6571         (probes_table_htab_remove_objfile_probes)
6572         (probes_table_remove_objfile_probes): New functions.
6573         (register_solib_event_probe): Add 'objfile' parameter.  Store it
6574         in the new probe_and_action.  Don't store the probe in 'lookup'.
6575         (svr4_create_probe_breakpoints): Pass objfile to
6576         register_solib_event_probe.
6577         (_initialize_svr4_solib): Register a free_objfile observer.
6578
6579 2019-04-19  Tom Tromey  <tom@tromey.com>
6580
6581         * common/queue.h: Remove.
6582
6583 2019-04-19  Tom Tromey  <tom@tromey.com>
6584
6585         * event-loop.c: Don't include "common/queue.h".
6586
6587 2019-04-19  Tom Tromey  <tom@tromey.com>
6588
6589         * remote.c (remote_target): Use delete.
6590         * remote-notif.h: Include <list>, not "common/queue.h".
6591         (notif_client_p): Remove typedef.
6592         (remote_notif_state): Add constructor, destructor, initializer.
6593         <notif_queue>: Now a std::list.
6594         (remote_notif_state_xfree): Don't declare.
6595         * remote-notif.c (remote_notif_process, handle_notification)
6596         (remote_notif_state_allocate): Update.
6597         (~remote_notif_state): Rename from remote_notif_state_xfree.
6598
6599 2019-04-19  Tom Tromey  <tom@tromey.com>
6600
6601         * symfile.c (reread_symbols): Update.
6602         * objfiles.c (objfile_register_static_link)
6603         (objfile_lookup_static_link): Update
6604         (~objfile) Don't delete static_links.
6605         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6606
6607 2019-04-19  Tom Tromey  <tom@tromey.com>
6608
6609         * type-stack.h (struct type_stack) <insert>: Constify string.
6610         * type-stack.c (type_stack::insert): Constify string.
6611         * gdbtypes.h (lookup_template_type): Update.
6612         (address_space_name_to_int): Update.
6613         * gdbtypes.c (address_space_name_to_int): Make space_identifier
6614         const.
6615         (lookup_template_type): Make name const.
6616         * c-exp.y: Update rules.
6617         (lex_one_token, classify_name, classify_inner_name)
6618         (c_print_token): Update.
6619         * p-exp.y: Update rules.
6620         (yylex): Update.
6621         * f-exp.y: Update rules.
6622         (yylex): Update.
6623         * d-exp.y: Update rules.
6624         (lex_one_token, classify_name, classify_inner_name): Update.
6625         * parse.c (write_dollar_variable, copy_name): Return std::string.
6626         * parser-defs.h (copy_name): Change return type.
6627         * m2-exp.y: Update rules.
6628         (yylex): Update.
6629         * go-exp.y (lex_one_token): Update.
6630         Update rules.
6631         (classify_unsafe_function, classify_packaged_name)
6632         (classify_name, yylex): Update.
6633
6634 2019-04-19  Sergei Trofimovich <siarheit@google.com>
6635
6636         * configure.ac: add --enable-source-highlight switch.
6637         * configure: Regenerate.
6638         * top.c (print_gdb_version): plumb --enable-source-highlight
6639         status to "show configuration".
6640
6641 2019-04-19  Tom Tromey  <tromey@adacore.com>
6642
6643         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6644         Check ADA_TYPE_P.
6645         (empty_record, ada_template_to_fixed_record_type_1)
6646         (template_to_static_fixed_type)
6647         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6648         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6649         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6650         macros.
6651
6652 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
6653
6654         PR symtab/24423:
6655         * source.c (print_source_lines_base): Advance "iter" when a
6656         control character is seen.
6657
6658 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6659
6660         * inferior.h (struct infcall_suspend_state_deleter):
6661         Catch exception in destructor to avoid crash.
6662
6663 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6664
6665         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6666         close to the add_com "shell".
6667
6668 2019-04-18  Tom Tromey  <tromey@adacore.com>
6669
6670         * process-stratum-target.h (class process_stratum_target)
6671         <stratum>: Add "final".
6672
6673 2019-04-17  Tom Tromey  <tromey@adacore.com>
6674
6675         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6676         against nullptr before use.
6677
6678 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6679
6680         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6681
6682 2019-04-17  Jim Wilson  <jimw@sifive.com>
6683             Andrew Burgess  <andrew.burgess@embecosm.com>
6684
6685         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6686         code read might fail, assume 4-byte breakpoint in that case.
6687
6688 2019-04-15  Leszek Swirski  <leszeks@google.com>
6689
6690         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6691         rather than a hand-rolled POD check when checking for forced MEMORY
6692         classification.
6693
6694 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6695
6696         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6697         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6698         function.
6699         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6700         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6701         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6702         declaration.
6703
6704 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6705
6706         * aarch64-linux-nat.c
6707         (aarch64_linux_nat_target::thread_architecture): Add override.
6708         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6709         each VQ.
6710
6711 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6712
6713         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6714
6715 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6716
6717         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6718         target types of size 96-bits, add some additional comments, and
6719         check that the builtin type we found was the correct size.
6720
6721 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6722
6723         * utils.c (prompt_for_continue): Don't restore the styling at the
6724         end, as applied_style has the wrong value.  This fixes styling in
6725         long lists of file names that are interrupted by the "Continue?"
6726         prompt.
6727
6728 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6729
6730         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6731         * c-lang.c (c_language_defn): Likewise.
6732         (cplus_language_defn): Likewise.
6733         (asm_language_defn): Likewise.
6734         (minimal_language_defn): Likewise.
6735         * d-lang.c (d_language_defn): Likewise.
6736         * f-lang.c (f_language_defn): Likewise.
6737         * go-lang.c (go_language_defn): Likewise.
6738         * language.c (unknown_language_defn): Likewise.
6739         (auto_language_defn): Likewise.
6740         * language.h (struct language_defn): Remove la_magic field.
6741         (LANG_MAGIC): Delete.
6742         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6743         * objc-lang.c (objc_language_defn): Likewise.
6744         * opencl-lang.c (opencl_language_defn): Likewise.
6745         * p-lang.c (pascal_language_defn): Likewise.
6746         * rust-lang.c (rust_language_defn): Likewise.
6747
6748 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6749
6750         * riscv-tdep.c (riscv_type_align): New function.
6751         (riscv_type_alignment): Delete.
6752         (riscv_arg_location): Use 'type_align'.
6753         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6754
6755 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6756
6757         * gdbtypes.c (type_align): A struct with no non-static fields also
6758         has alignment of 1.
6759
6760 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6761
6762         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6763         component to 0.
6764         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6765         member.
6766         (riscv_struct_info::analyse): New implementation using new
6767         analyse_inner member function.
6768         (riscv_struct_info::field_offset): New member function.
6769         (riscv_struct_info::m_offsets): New member variable.
6770         (riscv_struct_info::analyse_inner): New private member function,
6771         takes the old implementation of riscv_struct_info::analyse but
6772         extended to track field offsets.
6773         (riscv_call_arg_struct): Update the struct folding special cases
6774         to handle cases where empty C++ structs, which are non-zero
6775         length, are found.
6776         (riscv_arg_location): Initialise the length of each location, a
6777         non-zero length now indicates the location is in use.
6778         (riscv_push_dummy_call): Allow for the first location having a
6779         non-zero offset when setting up arguments.
6780         (riscv_return_value): Likewise, but for return values.
6781
6782 2019-04-11  Tom Tromey  <tromey@adacore.com>
6783
6784         * utils.c (internal_vproblem): Make "msg" const.
6785
6786 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6787
6788         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6789         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6790         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6791         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6792
6793 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6794
6795         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6796         function.
6797         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6798         of amd64_collect_native_gregset.
6799         (amd64_linux_nat_target::store_registers): Likewise.
6800
6801 2019-04-10  Tom Tromey  <tom@tromey.com>
6802
6803         * symtab.c (lookup_global_symbol_from_objfile)
6804         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6805         * objfiles.h (class separate_debug_iterator): New.
6806         (class separate_debug_range): New.
6807         (struct objfile) <separate_debug_objfiles>: New method.
6808         (objfile_separate_debug_iterate): Don't declare.
6809         * objfiles.c (separate_debug_iterator::operator++): Rename from
6810         objfile_separate_debug_iterate.
6811         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6812         iterator.
6813         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6814         iterator.
6815
6816 2019-04-10  Tom Tromey  <tom@tromey.com>
6817
6818         * symfile.c (reread_symbols): Remove old comment.
6819         * objfiles.c (free_all_objfiles): Fix a typo.
6820
6821 2019-04-10  Tom Tromey  <tom@tromey.com>
6822
6823         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6824         * minsyms.c (lookup_minimal_symbol): Use foreach.
6825         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6826         (lookup_minimal_symbol_solib_trampoline): Likewise.
6827         * symfile.c (reread_symbols): Use foreach.
6828
6829 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6830             Tom Tromey  <tromey@adacore.com>
6831
6832         PR rust/24414:
6833         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6834         (rust_lex_int_test): Change "value" to be LONGEST.
6835         (rust_lex_tests): Add test for long integer literal.
6836
6837 2019-04-09  Tom Tromey  <tromey@adacore.com>
6838
6839         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6840         to bool.
6841         (extended_remote_target::attach): Update.
6842         (remote_target::remote_notice_new_inferior): Update.
6843         (remote_target::add_current_inferior_and_thread): Update.
6844         * inferior.c (exit_inferior_1): Use "false".
6845         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6846
6847 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6848
6849         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6850         the "start" command.
6851
6852 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6853
6854         * python/py-inferior.c (infpy_thread_from_thread_handle):
6855         Adjust comments to reflect renaming of thread_from_thread_handle
6856         to thread_from_handle.  Adjust keywords.  Fix type error message.
6857         (inferior_object_methods): Add thread_from_handle.  Retain
6858         thread_from_thread_handle, but mark it as deprecated.
6859
6860 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6861
6862         * gdbthread.h (find_thread_by_handle): Revise declaration.
6863         * thread.c (find_thread_by_handle): Likewise.  Adjust
6864         implementation too.
6865         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6866         support for buffer objects as handles.
6867
6868 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6869
6870         * python/py-infthread.c (thpy_thread_handle): New function.
6871         (thread_object_methods): Register thpy_thread_handle.
6872
6873 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6874
6875         * gdbthread.h (thread_to_thread_handle): Declare.
6876         * thread.c (gdbtypes.h): Include.
6877         (thread_to_thread_handle): New function.
6878
6879         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6880         (target_thread_info_to_thread_handle): Declare.
6881         * target.c (target_thread_info_to_thread_handle): New function.
6882         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6883         * target-delegates.c: Regenerate.
6884
6885         * linux-thread-db.c (class thread_db_target): Add method
6886         thread_info_to_thread_handle.
6887         (thread_db_target::thread_info_to_thread_handle): Define.
6888         * remote.c (class remote_target): Add new method
6889         thread_info_to_thread_handle.
6890         (remote_target::thread_info_to_thread_handle): Define.
6891
6892 2019-04-08  Pedro Alves  <palves@redhat.com>
6893
6894         * common/common-exceptions.c (throw_exception): Don't create
6895         named object to throw; throw directly.
6896         (throw_it): Likewise.  Don't initialize gdb_exception::message
6897         here, with new; pass FMT and AP to the ctor instead.
6898         * common/common-exceptions.h: Include <string>.
6899         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6900         const char *, va_list)): New ctor.  Use std::make_shared.
6901         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6902         errors)): Delete.
6903         (gdb_exception_error::gdb_exception_error(enum errors, const char
6904         *, va_list)): New.
6905         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6906         Add assertion.
6907         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6908         errors)): Delete.
6909         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6910         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6911         Add assertion.
6912
6913 2019-04-08  Tom Tromey  <tom@tromey.com>
6914
6915         * valops.c (value_rtti_indirect_type): Replace throw_exception
6916         with throw.
6917         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6918         with throw.
6919         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6920         throw.
6921         * target.c (target_translate_tls_address): Replace throw_exception
6922         with throw.
6923         * stack.c (frame_apply_command_count): Replace throw_exception
6924         with throw.
6925         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6926         throw.
6927         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6928         with throw.
6929         * rs6000-tdep.c (rs6000_frame_cache)
6930         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6931         * remote.c: Replace throw_exception with throw.
6932         * record-full.c (record_full_message, record_full_wait_1)
6933         (record_full_restore): Replace throw_exception with throw.
6934         * record-btrace.c:
6935         (get_thread_current_frame_id, record_btrace_start_replaying)
6936         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6937         (cmd_record_btrace_start): Replace throw_exception with throw.
6938         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6939         throw.
6940         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6941         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6942         * linespec.c:
6943         (find_linespec_symbols): Replace throw_exception with throw.
6944         * infrun.c (displaced_step_prepare, resume): Replace
6945         throw_exception with throw.
6946         * infcmd.c (post_create_inferior): Replace throw_exception with
6947         throw.
6948         * inf-loop.c (inferior_event_handler): Replace throw_exception
6949         with throw.
6950         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6951         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6952         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6953         (get_prev_frame_always, get_frame_pc_if_available)
6954         (get_frame_address_in_block_if_available, get_frame_language):
6955         Replace throw_exception with throw.
6956         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6957         throw_exception with throw.
6958         * eval.c (fetch_subexp_value, evaluate_var_value)
6959         (evaluate_funcall, evaluate_subexp_standard): Replace
6960         throw_exception with throw.
6961         * dwarf2loc.c (call_site_find_chain)
6962         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6963         Replace throw_exception with throw.
6964         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6965         with throw.
6966         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6967         throw.
6968         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6969         * completer.c (complete_line_internal): Replace throw_exception
6970         with throw.
6971         * compile/compile-object-run.c (compile_object_run): Replace
6972         throw_exception with throw.
6973         * cli/cli-script.c (process_next_line): Replace throw_exception
6974         with throw.
6975         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6976         (btrace_enable, btrace_maint_update_pt_packets): Replace
6977         throw_exception with throw.
6978         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6979         throw_exception with throw.
6980         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6981         throw_exception with throw.
6982         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6983         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6984         * aarch64-tdep.c (aarch64_make_prologue_cache)
6985         (aarch64_make_stub_cache): Replace throw_exception with throw.
6986
6987 2019-04-08  Tom Tromey  <tom@tromey.com>
6988
6989         * common/common-exceptions.c (throw_exception): Rename from
6990         throw_exception_cxx.  Remove old copy.  Make argument const.
6991         (throw_it): Create and throw exception objects directly.
6992         * common/common-exceptions.h (throw_exception): Make argument
6993         const.
6994         (struct gdb_exception_error): Add constructor.
6995         (struct gdb_exception_quit): Add constructor.
6996
6997 2019-04-08  Tom Tromey  <tom@tromey.com>
6998
6999         * common/common-exceptions.h (exception_rethrow): Don't declare.
7000         (TRY_SJLJ): Update comment.
7001         (TRY, CATCH, END_CATCH): Remove.
7002         * common/common-exceptions.c (exception_rethrow): Remove.
7003
7004 2019-04-08  Tom Tromey  <tom@tromey.com>
7005
7006         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
7007         Remove.
7008         (gdb_exception_error): Rename from
7009         gdb_exception_RETURN_MASK_ERROR.
7010         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
7011         (gdb_quit_bad_alloc): Update.
7012         * aarch64-tdep.c: Update.
7013         * ada-lang.c: Update.
7014         * ada-typeprint.c: Update.
7015         * ada-valprint.c: Update.
7016         * amd64-tdep.c: Update.
7017         * arch-utils.c: Update.
7018         * break-catch-throw.c: Update.
7019         * breakpoint.c: Update.
7020         * btrace.c: Update.
7021         * c-varobj.c: Update.
7022         * cli/cli-cmds.c: Update.
7023         * cli/cli-interp.c: Update.
7024         * cli/cli-script.c: Update.
7025         * common/common-exceptions.c: Update.
7026         * common/new-op.c: Update.
7027         * common/selftest.c: Update.
7028         * compile/compile-c-symbols.c: Update.
7029         * compile/compile-cplus-symbols.c: Update.
7030         * compile/compile-object-load.c: Update.
7031         * compile/compile-object-run.c: Update.
7032         * completer.c: Update.
7033         * corelow.c: Update.
7034         * cp-abi.c: Update.
7035         * cp-support.c: Update.
7036         * cp-valprint.c: Update.
7037         * darwin-nat.c: Update.
7038         * disasm-selftests.c: Update.
7039         * dtrace-probe.c: Update.
7040         * dwarf-index-cache.c: Update.
7041         * dwarf-index-write.c: Update.
7042         * dwarf2-frame-tailcall.c: Update.
7043         * dwarf2-frame.c: Update.
7044         * dwarf2loc.c: Update.
7045         * dwarf2read.c: Update.
7046         * eval.c: Update.
7047         * event-loop.c: Update.
7048         * event-top.c: Update.
7049         * exec.c: Update.
7050         * f-valprint.c: Update.
7051         * fbsd-tdep.c: Update.
7052         * frame-unwind.c: Update.
7053         * frame.c: Update.
7054         * gdbtypes.c: Update.
7055         * gnu-v3-abi.c: Update.
7056         * guile/guile-internal.h: Update.
7057         * guile/scm-block.c: Update.
7058         * guile/scm-breakpoint.c: Update.
7059         * guile/scm-cmd.c: Update.
7060         * guile/scm-disasm.c: Update.
7061         * guile/scm-frame.c: Update.
7062         * guile/scm-lazy-string.c: Update.
7063         * guile/scm-math.c: Update.
7064         * guile/scm-param.c: Update.
7065         * guile/scm-ports.c: Update.
7066         * guile/scm-pretty-print.c: Update.
7067         * guile/scm-symbol.c: Update.
7068         * guile/scm-symtab.c: Update.
7069         * guile/scm-type.c: Update.
7070         * guile/scm-value.c: Update.
7071         * i386-linux-tdep.c: Update.
7072         * i386-tdep.c: Update.
7073         * inf-loop.c: Update.
7074         * infcall.c: Update.
7075         * infcmd.c: Update.
7076         * infrun.c: Update.
7077         * jit.c: Update.
7078         * language.c: Update.
7079         * linespec.c: Update.
7080         * linux-fork.c: Update.
7081         * linux-nat.c: Update.
7082         * linux-tdep.c: Update.
7083         * linux-thread-db.c: Update.
7084         * main.c: Update.
7085         * mi/mi-cmd-break.c: Update.
7086         * mi/mi-cmd-stack.c: Update.
7087         * mi/mi-interp.c: Update.
7088         * mi/mi-main.c: Update.
7089         * objc-lang.c: Update.
7090         * p-valprint.c: Update.
7091         * parse.c: Update.
7092         * ppc-linux-tdep.c: Update.
7093         * printcmd.c: Update.
7094         * python/py-arch.c: Update.
7095         * python/py-breakpoint.c: Update.
7096         * python/py-cmd.c: Update.
7097         * python/py-finishbreakpoint.c: Update.
7098         * python/py-frame.c: Update.
7099         * python/py-framefilter.c: Update.
7100         * python/py-gdb-readline.c: Update.
7101         * python/py-inferior.c: Update.
7102         * python/py-infthread.c: Update.
7103         * python/py-lazy-string.c: Update.
7104         * python/py-linetable.c: Update.
7105         * python/py-objfile.c: Update.
7106         * python/py-param.c: Update.
7107         * python/py-prettyprint.c: Update.
7108         * python/py-progspace.c: Update.
7109         * python/py-record-btrace.c: Update.
7110         * python/py-record.c: Update.
7111         * python/py-symbol.c: Update.
7112         * python/py-type.c: Update.
7113         * python/py-unwind.c: Update.
7114         * python/py-utils.c: Update.
7115         * python/py-value.c: Update.
7116         * python/python.c: Update.
7117         * record-btrace.c: Update.
7118         * record-full.c: Update.
7119         * remote-fileio.c: Update.
7120         * remote.c: Update.
7121         * riscv-tdep.c: Update.
7122         * rs6000-aix-tdep.c: Update.
7123         * rs6000-tdep.c: Update.
7124         * rust-exp.y: Update.
7125         * rust-lang.c: Update.
7126         * s390-tdep.c: Update.
7127         * selftest-arch.c: Update.
7128         * solib-dsbt.c: Update.
7129         * solib-frv.c: Update.
7130         * solib-spu.c: Update.
7131         * solib-svr4.c: Update.
7132         * solib.c: Update.
7133         * sparc64-linux-tdep.c: Update.
7134         * stack.c: Update.
7135         * symfile-mem.c: Update.
7136         * symmisc.c: Update.
7137         * target.c: Update.
7138         * thread.c: Update.
7139         * top.c: Update.
7140         * tracefile-tfile.c: Update.
7141         * tui/tui.c: Update.
7142         * typeprint.c: Update.
7143         * unittests/cli-utils-selftests.c: Update.
7144         * unittests/parse-connection-spec-selftests.c: Update.
7145         * valops.c: Update.
7146         * valprint.c: Update.
7147         * value.c: Update.
7148         * varobj.c: Update.
7149         * windows-nat.c: Update.
7150         * x86-linux-nat.c: Update.
7151         * xml-support.c: Update.
7152
7153 2019-04-08  Tom Tromey  <tom@tromey.com>
7154
7155         * xml-support.c: Use C++ exception handling.
7156         * x86-linux-nat.c: Use C++ exception handling.
7157         * windows-nat.c: Use C++ exception handling.
7158         * varobj.c: Use C++ exception handling.
7159         * value.c: Use C++ exception handling.
7160         * valprint.c: Use C++ exception handling.
7161         * valops.c: Use C++ exception handling.
7162         * unittests/parse-connection-spec-selftests.c: Use C++ exception
7163         handling.
7164         * unittests/cli-utils-selftests.c: Use C++ exception handling.
7165         * typeprint.c: Use C++ exception handling.
7166         * tui/tui.c: Use C++ exception handling.
7167         * tracefile-tfile.c: Use C++ exception handling.
7168         * top.c: Use C++ exception handling.
7169         * thread.c: Use C++ exception handling.
7170         * target.c: Use C++ exception handling.
7171         * symmisc.c: Use C++ exception handling.
7172         * symfile-mem.c: Use C++ exception handling.
7173         * stack.c: Use C++ exception handling.
7174         * sparc64-linux-tdep.c: Use C++ exception handling.
7175         * solib.c: Use C++ exception handling.
7176         * solib-svr4.c: Use C++ exception handling.
7177         * solib-spu.c: Use C++ exception handling.
7178         * solib-frv.c: Use C++ exception handling.
7179         * solib-dsbt.c: Use C++ exception handling.
7180         * selftest-arch.c: Use C++ exception handling.
7181         * s390-tdep.c: Use C++ exception handling.
7182         * rust-lang.c: Use C++ exception handling.
7183         * rust-exp.y: Use C++ exception handling.
7184         * rs6000-tdep.c: Use C++ exception handling.
7185         * rs6000-aix-tdep.c: Use C++ exception handling.
7186         * riscv-tdep.c: Use C++ exception handling.
7187         * remote.c: Use C++ exception handling.
7188         * remote-fileio.c: Use C++ exception handling.
7189         * record-full.c: Use C++ exception handling.
7190         * record-btrace.c: Use C++ exception handling.
7191         * python/python.c: Use C++ exception handling.
7192         * python/py-value.c: Use C++ exception handling.
7193         * python/py-utils.c: Use C++ exception handling.
7194         * python/py-unwind.c: Use C++ exception handling.
7195         * python/py-type.c: Use C++ exception handling.
7196         * python/py-symbol.c: Use C++ exception handling.
7197         * python/py-record.c: Use C++ exception handling.
7198         * python/py-record-btrace.c: Use C++ exception handling.
7199         * python/py-progspace.c: Use C++ exception handling.
7200         * python/py-prettyprint.c: Use C++ exception handling.
7201         * python/py-param.c: Use C++ exception handling.
7202         * python/py-objfile.c: Use C++ exception handling.
7203         * python/py-linetable.c: Use C++ exception handling.
7204         * python/py-lazy-string.c: Use C++ exception handling.
7205         * python/py-infthread.c: Use C++ exception handling.
7206         * python/py-inferior.c: Use C++ exception handling.
7207         * python/py-gdb-readline.c: Use C++ exception handling.
7208         * python/py-framefilter.c: Use C++ exception handling.
7209         * python/py-frame.c: Use C++ exception handling.
7210         * python/py-finishbreakpoint.c: Use C++ exception handling.
7211         * python/py-cmd.c: Use C++ exception handling.
7212         * python/py-breakpoint.c: Use C++ exception handling.
7213         * python/py-arch.c: Use C++ exception handling.
7214         * printcmd.c: Use C++ exception handling.
7215         * ppc-linux-tdep.c: Use C++ exception handling.
7216         * parse.c: Use C++ exception handling.
7217         * p-valprint.c: Use C++ exception handling.
7218         * objc-lang.c: Use C++ exception handling.
7219         * mi/mi-main.c: Use C++ exception handling.
7220         * mi/mi-interp.c: Use C++ exception handling.
7221         * mi/mi-cmd-stack.c: Use C++ exception handling.
7222         * mi/mi-cmd-break.c: Use C++ exception handling.
7223         * main.c: Use C++ exception handling.
7224         * linux-thread-db.c: Use C++ exception handling.
7225         * linux-tdep.c: Use C++ exception handling.
7226         * linux-nat.c: Use C++ exception handling.
7227         * linux-fork.c: Use C++ exception handling.
7228         * linespec.c: Use C++ exception handling.
7229         * language.c: Use C++ exception handling.
7230         * jit.c: Use C++ exception handling.
7231         * infrun.c: Use C++ exception handling.
7232         * infcmd.c: Use C++ exception handling.
7233         * infcall.c: Use C++ exception handling.
7234         * inf-loop.c: Use C++ exception handling.
7235         * i386-tdep.c: Use C++ exception handling.
7236         * i386-linux-tdep.c: Use C++ exception handling.
7237         * guile/scm-value.c: Use C++ exception handling.
7238         * guile/scm-type.c: Use C++ exception handling.
7239         * guile/scm-symtab.c: Use C++ exception handling.
7240         * guile/scm-symbol.c: Use C++ exception handling.
7241         * guile/scm-pretty-print.c: Use C++ exception handling.
7242         * guile/scm-ports.c: Use C++ exception handling.
7243         * guile/scm-param.c: Use C++ exception handling.
7244         * guile/scm-math.c: Use C++ exception handling.
7245         * guile/scm-lazy-string.c: Use C++ exception handling.
7246         * guile/scm-frame.c: Use C++ exception handling.
7247         * guile/scm-disasm.c: Use C++ exception handling.
7248         * guile/scm-cmd.c: Use C++ exception handling.
7249         * guile/scm-breakpoint.c: Use C++ exception handling.
7250         * guile/scm-block.c: Use C++ exception handling.
7251         * guile/guile-internal.h: Use C++ exception handling.
7252         * gnu-v3-abi.c: Use C++ exception handling.
7253         * gdbtypes.c: Use C++ exception handling.
7254         * frame.c: Use C++ exception handling.
7255         * frame-unwind.c: Use C++ exception handling.
7256         * fbsd-tdep.c: Use C++ exception handling.
7257         * f-valprint.c: Use C++ exception handling.
7258         * exec.c: Use C++ exception handling.
7259         * event-top.c: Use C++ exception handling.
7260         * event-loop.c: Use C++ exception handling.
7261         * eval.c: Use C++ exception handling.
7262         * dwarf2read.c: Use C++ exception handling.
7263         * dwarf2loc.c: Use C++ exception handling.
7264         * dwarf2-frame.c: Use C++ exception handling.
7265         * dwarf2-frame-tailcall.c: Use C++ exception handling.
7266         * dwarf-index-write.c: Use C++ exception handling.
7267         * dwarf-index-cache.c: Use C++ exception handling.
7268         * dtrace-probe.c: Use C++ exception handling.
7269         * disasm-selftests.c: Use C++ exception handling.
7270         * darwin-nat.c: Use C++ exception handling.
7271         * cp-valprint.c: Use C++ exception handling.
7272         * cp-support.c: Use C++ exception handling.
7273         * cp-abi.c: Use C++ exception handling.
7274         * corelow.c: Use C++ exception handling.
7275         * completer.c: Use C++ exception handling.
7276         * compile/compile-object-run.c: Use C++ exception handling.
7277         * compile/compile-object-load.c: Use C++ exception handling.
7278         * compile/compile-cplus-symbols.c: Use C++ exception handling.
7279         * compile/compile-c-symbols.c: Use C++ exception handling.
7280         * common/selftest.c: Use C++ exception handling.
7281         * common/new-op.c: Use C++ exception handling.
7282         * cli/cli-script.c: Use C++ exception handling.
7283         * cli/cli-interp.c: Use C++ exception handling.
7284         * cli/cli-cmds.c: Use C++ exception handling.
7285         * c-varobj.c: Use C++ exception handling.
7286         * btrace.c: Use C++ exception handling.
7287         * breakpoint.c: Use C++ exception handling.
7288         * break-catch-throw.c: Use C++ exception handling.
7289         * arch-utils.c: Use C++ exception handling.
7290         * amd64-tdep.c: Use C++ exception handling.
7291         * ada-valprint.c: Use C++ exception handling.
7292         * ada-typeprint.c: Use C++ exception handling.
7293         * ada-lang.c: Use C++ exception handling.
7294         * aarch64-tdep.c: Use C++ exception handling.
7295
7296 2019-04-08  Tom Tromey  <tom@tromey.com>
7297
7298         * xml-support.c (gdb_xml_parser::parse): Update.
7299         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7300         * value.c (show_convenience): Update.
7301         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
7302         (test_parse_flags_qcs): Update.
7303         * thread.c (thr_try_catch_cmd): Update.
7304         * target.c (target_translate_tls_address): Update.
7305         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
7306         (info_frame_command_core, frame_apply_command_count): Update.
7307         * rust-exp.y (rust_lex_exception_test): Update.
7308         * riscv-tdep.c (riscv_print_one_register_info): Update.
7309         * remote.c (remote_target::enable_btrace): Update.
7310         * record-btrace.c (record_btrace_enable_warn): Update.
7311         * python/py-utils.c (gdbpy_convert_exception): Update.
7312         * printcmd.c (do_one_display, print_variable_and_value): Update.
7313         * mi/mi-main.c (mi_print_exception): Update.
7314         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
7315         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
7316         * linux-nat.c (linux_nat_target::attach): Update.
7317         * linux-fork.c (class scoped_switch_fork_info): Update.
7318         * infrun.c (displaced_step_prepare): Update.
7319         * infcall.c (call_function_by_hand_dummy): Update.
7320         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
7321         * gnu-v3-abi.c (print_one_vtable): Update.
7322         * frame.c (get_prev_frame_always): Update.
7323         * f-valprint.c (info_common_command_for_block): Update.
7324         * exec.c (try_open_exec_file): Update.
7325         * exceptions.c (print_exception, exception_print)
7326         (exception_fprintf, exception_print_same): Update.
7327         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
7328         * dwarf-index-cache.c (index_cache::store)
7329         (index_cache::lookup_gdb_index): Update.
7330         * darwin-nat.c (maybe_cache_shell): Update.
7331         * cp-valprint.c (cp_print_value_fields): Update.
7332         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
7333         (gcc_cplus_symbol_address): Update.
7334         * compile/compile-c-symbols.c (gcc_convert_symbol)
7335         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
7336         * common/selftest.c: Update.
7337         * common/common-exceptions.h (struct gdb_exception) <message>: Now
7338         a std::string.
7339         (exception_try_scope_entry, exception_try_scope_exit): Don't
7340         declare.
7341         (struct exception_try_scope): Remove.
7342         (TRY): Don't use exception_try_scope.
7343         (struct gdb_exception): Add constructor, operator=.
7344         <what>: New method.
7345         (struct gdb_exception_RETURN_MASK_ALL)
7346         (struct gdb_exception_RETURN_MASK_ERROR)
7347         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
7348         (struct gdb_quit_bad_alloc): Update.
7349         * common/common-exceptions.c (exception_none): Change
7350         initializer.
7351         (struct catcher) <state, exception>: Initialize inline.
7352         <prev>: Remove member.
7353         (current_catcher): Remove.
7354         (catchers): New global.
7355         (exceptions_state_mc_init): Simplify.
7356         (catcher_pop): Remove.
7357         (exceptions_state_mc, exceptions_state_mc_catch): Update.
7358         (try_scope_depth, exception_try_scope_entry)
7359         (exception_try_scope_exit): Remove.
7360         (throw_exception_sjlj): Update.
7361         (exception_messages, exception_messages_size): Remove.
7362         (throw_it): Simplify.
7363         (gdb_exception_sliced_copy): Remove.
7364         (throw_exception_cxx): Update.
7365         * cli/cli-script.c (script_from_file): Update.
7366         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
7367         Update.
7368         * ada-valprint.c (ada_val_print): Update.
7369         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
7370         (create_excep_cond_exprs): Update.
7371
7372 2019-04-08  Tom Tromey  <tom@tromey.com>
7373
7374         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
7375         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
7376         (TRY, CATCH, END_CATCH): Remove some definitions.
7377         * common/common-exceptions.c: Don't use GDB_XCPT.
7378         (catcher_list_size): Remove.
7379         (throw_exception, throw_it): Simplify.
7380
7381 2019-04-05  Tom Tromey  <tom@tromey.com>
7382
7383         Revert the header-sorting patch.
7384         * ft32-tdep.c: Revert.
7385         * frv-tdep.c: Revert.
7386         * frv-linux-tdep.c: Revert.
7387         * frame.c: Revert.
7388         * frame-unwind.c: Revert.
7389         * frame-base.c: Revert.
7390         * fork-child.c: Revert.
7391         * findvar.c: Revert.
7392         * findcmd.c: Revert.
7393         * filesystem.c: Revert.
7394         * filename-seen-cache.h: Revert.
7395         * filename-seen-cache.c: Revert.
7396         * fbsd-tdep.c: Revert.
7397         * fbsd-nat.h: Revert.
7398         * fbsd-nat.c: Revert.
7399         * f-valprint.c: Revert.
7400         * f-typeprint.c: Revert.
7401         * f-lang.c: Revert.
7402         * extension.h: Revert.
7403         * extension.c: Revert.
7404         * extension-priv.h: Revert.
7405         * expprint.c: Revert.
7406         * exec.h: Revert.
7407         * exec.c: Revert.
7408         * exceptions.c: Revert.
7409         * event-top.c: Revert.
7410         * event-loop.c: Revert.
7411         * eval.c: Revert.
7412         * elfread.c: Revert.
7413         * dwarf2read.h: Revert.
7414         * dwarf2read.c: Revert.
7415         * dwarf2loc.c: Revert.
7416         * dwarf2expr.h: Revert.
7417         * dwarf2expr.c: Revert.
7418         * dwarf2-frame.c: Revert.
7419         * dwarf2-frame-tailcall.c: Revert.
7420         * dwarf-index-write.h: Revert.
7421         * dwarf-index-write.c: Revert.
7422         * dwarf-index-common.c: Revert.
7423         * dwarf-index-cache.h: Revert.
7424         * dwarf-index-cache.c: Revert.
7425         * dummy-frame.c: Revert.
7426         * dtrace-probe.c: Revert.
7427         * disasm.h: Revert.
7428         * disasm.c: Revert.
7429         * disasm-selftests.c: Revert.
7430         * dictionary.c: Revert.
7431         * dicos-tdep.c: Revert.
7432         * demangle.c: Revert.
7433         * dcache.h: Revert.
7434         * dcache.c: Revert.
7435         * darwin-nat.h: Revert.
7436         * darwin-nat.c: Revert.
7437         * darwin-nat-info.c: Revert.
7438         * d-valprint.c: Revert.
7439         * d-namespace.c: Revert.
7440         * d-lang.c: Revert.
7441         * ctf.c: Revert.
7442         * csky-tdep.c: Revert.
7443         * csky-linux-tdep.c: Revert.
7444         * cris-tdep.c: Revert.
7445         * cris-linux-tdep.c: Revert.
7446         * cp-valprint.c: Revert.
7447         * cp-support.c: Revert.
7448         * cp-namespace.c: Revert.
7449         * cp-abi.c: Revert.
7450         * corelow.c: Revert.
7451         * corefile.c: Revert.
7452         * continuations.c: Revert.
7453         * completer.h: Revert.
7454         * completer.c: Revert.
7455         * complaints.c: Revert.
7456         * coffread.c: Revert.
7457         * coff-pe-read.c: Revert.
7458         * cli-out.h: Revert.
7459         * cli-out.c: Revert.
7460         * charset.c: Revert.
7461         * c-varobj.c: Revert.
7462         * c-valprint.c: Revert.
7463         * c-typeprint.c: Revert.
7464         * c-lang.c: Revert.
7465         * buildsym.c: Revert.
7466         * buildsym-legacy.c: Revert.
7467         * build-id.h: Revert.
7468         * build-id.c: Revert.
7469         * btrace.c: Revert.
7470         * bsd-uthread.c: Revert.
7471         * breakpoint.h: Revert.
7472         * breakpoint.c: Revert.
7473         * break-catch-throw.c: Revert.
7474         * break-catch-syscall.c: Revert.
7475         * break-catch-sig.c: Revert.
7476         * blockframe.c: Revert.
7477         * block.c: Revert.
7478         * bfin-tdep.c: Revert.
7479         * bfin-linux-tdep.c: Revert.
7480         * bfd-target.c: Revert.
7481         * bcache.c: Revert.
7482         * ax-general.c: Revert.
7483         * ax-gdb.h: Revert.
7484         * ax-gdb.c: Revert.
7485         * avr-tdep.c: Revert.
7486         * auxv.c: Revert.
7487         * auto-load.c: Revert.
7488         * arm-wince-tdep.c: Revert.
7489         * arm-tdep.c: Revert.
7490         * arm-symbian-tdep.c: Revert.
7491         * arm-pikeos-tdep.c: Revert.
7492         * arm-obsd-tdep.c: Revert.
7493         * arm-nbsd-tdep.c: Revert.
7494         * arm-nbsd-nat.c: Revert.
7495         * arm-linux-tdep.c: Revert.
7496         * arm-linux-nat.c: Revert.
7497         * arm-fbsd-tdep.c: Revert.
7498         * arm-fbsd-nat.c: Revert.
7499         * arm-bsd-tdep.c: Revert.
7500         * arch-utils.c: Revert.
7501         * arc-tdep.c: Revert.
7502         * arc-newlib-tdep.c: Revert.
7503         * annotate.h: Revert.
7504         * annotate.c: Revert.
7505         * amd64-windows-tdep.c: Revert.
7506         * amd64-windows-nat.c: Revert.
7507         * amd64-tdep.c: Revert.
7508         * amd64-sol2-tdep.c: Revert.
7509         * amd64-obsd-tdep.c: Revert.
7510         * amd64-obsd-nat.c: Revert.
7511         * amd64-nbsd-tdep.c: Revert.
7512         * amd64-nbsd-nat.c: Revert.
7513         * amd64-nat.c: Revert.
7514         * amd64-linux-tdep.c: Revert.
7515         * amd64-linux-nat.c: Revert.
7516         * amd64-fbsd-tdep.c: Revert.
7517         * amd64-fbsd-nat.c: Revert.
7518         * amd64-dicos-tdep.c: Revert.
7519         * amd64-darwin-tdep.c: Revert.
7520         * amd64-bsd-nat.c: Revert.
7521         * alpha-tdep.c: Revert.
7522         * alpha-obsd-tdep.c: Revert.
7523         * alpha-nbsd-tdep.c: Revert.
7524         * alpha-mdebug-tdep.c: Revert.
7525         * alpha-linux-tdep.c: Revert.
7526         * alpha-linux-nat.c: Revert.
7527         * alpha-bsd-tdep.c: Revert.
7528         * alpha-bsd-nat.c: Revert.
7529         * aix-thread.c: Revert.
7530         * agent.c: Revert.
7531         * addrmap.c: Revert.
7532         * ada-varobj.c: Revert.
7533         * ada-valprint.c: Revert.
7534         * ada-typeprint.c: Revert.
7535         * ada-tasks.c: Revert.
7536         * ada-lang.c: Revert.
7537         * aarch64-tdep.c: Revert.
7538         * aarch64-ravenscar-thread.c: Revert.
7539         * aarch64-newlib-tdep.c: Revert.
7540         * aarch64-linux-tdep.c: Revert.
7541         * aarch64-linux-nat.c: Revert.
7542         * aarch64-fbsd-tdep.c: Revert.
7543         * aarch64-fbsd-nat.c: Revert.
7544         * aarch32-linux-nat.c: Revert.
7545
7546 2019-04-05  Tom Tromey  <tom@tromey.com>
7547
7548         * ft32-tdep.c: Sort headers.
7549         * frv-tdep.c: Sort headers.
7550         * frv-linux-tdep.c: Sort headers.
7551         * frame.c: Sort headers.
7552         * frame-unwind.c: Sort headers.
7553         * frame-base.c: Sort headers.
7554         * fork-child.c: Sort headers.
7555         * findvar.c: Sort headers.
7556         * findcmd.c: Sort headers.
7557         * filesystem.c: Sort headers.
7558         * filename-seen-cache.h: Sort headers.
7559         * filename-seen-cache.c: Sort headers.
7560         * fbsd-tdep.c: Sort headers.
7561         * fbsd-nat.h: Sort headers.
7562         * fbsd-nat.c: Sort headers.
7563         * f-valprint.c: Sort headers.
7564         * f-typeprint.c: Sort headers.
7565         * f-lang.c: Sort headers.
7566         * extension.h: Sort headers.
7567         * extension.c: Sort headers.
7568         * extension-priv.h: Sort headers.
7569         * expprint.c: Sort headers.
7570         * exec.h: Sort headers.
7571         * exec.c: Sort headers.
7572         * exceptions.c: Sort headers.
7573         * event-top.c: Sort headers.
7574         * event-loop.c: Sort headers.
7575         * eval.c: Sort headers.
7576         * elfread.c: Sort headers.
7577         * dwarf2read.h: Sort headers.
7578         * dwarf2read.c: Sort headers.
7579         * dwarf2loc.c: Sort headers.
7580         * dwarf2expr.h: Sort headers.
7581         * dwarf2expr.c: Sort headers.
7582         * dwarf2-frame.c: Sort headers.
7583         * dwarf2-frame-tailcall.c: Sort headers.
7584         * dwarf-index-write.h: Sort headers.
7585         * dwarf-index-write.c: Sort headers.
7586         * dwarf-index-common.c: Sort headers.
7587         * dwarf-index-cache.h: Sort headers.
7588         * dwarf-index-cache.c: Sort headers.
7589         * dummy-frame.c: Sort headers.
7590         * dtrace-probe.c: Sort headers.
7591         * disasm.h: Sort headers.
7592         * disasm.c: Sort headers.
7593         * disasm-selftests.c: Sort headers.
7594         * dictionary.c: Sort headers.
7595         * dicos-tdep.c: Sort headers.
7596         * demangle.c: Sort headers.
7597         * dcache.h: Sort headers.
7598         * dcache.c: Sort headers.
7599         * darwin-nat.h: Sort headers.
7600         * darwin-nat.c: Sort headers.
7601         * darwin-nat-info.c: Sort headers.
7602         * d-valprint.c: Sort headers.
7603         * d-namespace.c: Sort headers.
7604         * d-lang.c: Sort headers.
7605         * ctf.c: Sort headers.
7606         * csky-tdep.c: Sort headers.
7607         * csky-linux-tdep.c: Sort headers.
7608         * cris-tdep.c: Sort headers.
7609         * cris-linux-tdep.c: Sort headers.
7610         * cp-valprint.c: Sort headers.
7611         * cp-support.c: Sort headers.
7612         * cp-namespace.c: Sort headers.
7613         * cp-abi.c: Sort headers.
7614         * corelow.c: Sort headers.
7615         * corefile.c: Sort headers.
7616         * continuations.c: Sort headers.
7617         * completer.h: Sort headers.
7618         * completer.c: Sort headers.
7619         * complaints.c: Sort headers.
7620         * coffread.c: Sort headers.
7621         * coff-pe-read.c: Sort headers.
7622         * cli-out.h: Sort headers.
7623         * cli-out.c: Sort headers.
7624         * charset.c: Sort headers.
7625         * c-varobj.c: Sort headers.
7626         * c-valprint.c: Sort headers.
7627         * c-typeprint.c: Sort headers.
7628         * c-lang.c: Sort headers.
7629         * buildsym.c: Sort headers.
7630         * buildsym-legacy.c: Sort headers.
7631         * build-id.h: Sort headers.
7632         * build-id.c: Sort headers.
7633         * btrace.c: Sort headers.
7634         * bsd-uthread.c: Sort headers.
7635         * breakpoint.h: Sort headers.
7636         * breakpoint.c: Sort headers.
7637         * break-catch-throw.c: Sort headers.
7638         * break-catch-syscall.c: Sort headers.
7639         * break-catch-sig.c: Sort headers.
7640         * blockframe.c: Sort headers.
7641         * block.c: Sort headers.
7642         * bfin-tdep.c: Sort headers.
7643         * bfin-linux-tdep.c: Sort headers.
7644         * bfd-target.c: Sort headers.
7645         * bcache.c: Sort headers.
7646         * ax-general.c: Sort headers.
7647         * ax-gdb.h: Sort headers.
7648         * ax-gdb.c: Sort headers.
7649         * avr-tdep.c: Sort headers.
7650         * auxv.c: Sort headers.
7651         * auto-load.c: Sort headers.
7652         * arm-wince-tdep.c: Sort headers.
7653         * arm-tdep.c: Sort headers.
7654         * arm-symbian-tdep.c: Sort headers.
7655         * arm-pikeos-tdep.c: Sort headers.
7656         * arm-obsd-tdep.c: Sort headers.
7657         * arm-nbsd-tdep.c: Sort headers.
7658         * arm-nbsd-nat.c: Sort headers.
7659         * arm-linux-tdep.c: Sort headers.
7660         * arm-linux-nat.c: Sort headers.
7661         * arm-fbsd-tdep.c: Sort headers.
7662         * arm-fbsd-nat.c: Sort headers.
7663         * arm-bsd-tdep.c: Sort headers.
7664         * arch-utils.c: Sort headers.
7665         * arc-tdep.c: Sort headers.
7666         * arc-newlib-tdep.c: Sort headers.
7667         * annotate.h: Sort headers.
7668         * annotate.c: Sort headers.
7669         * amd64-windows-tdep.c: Sort headers.
7670         * amd64-windows-nat.c: Sort headers.
7671         * amd64-tdep.c: Sort headers.
7672         * amd64-sol2-tdep.c: Sort headers.
7673         * amd64-obsd-tdep.c: Sort headers.
7674         * amd64-obsd-nat.c: Sort headers.
7675         * amd64-nbsd-tdep.c: Sort headers.
7676         * amd64-nbsd-nat.c: Sort headers.
7677         * amd64-nat.c: Sort headers.
7678         * amd64-linux-tdep.c: Sort headers.
7679         * amd64-linux-nat.c: Sort headers.
7680         * amd64-fbsd-tdep.c: Sort headers.
7681         * amd64-fbsd-nat.c: Sort headers.
7682         * amd64-dicos-tdep.c: Sort headers.
7683         * amd64-darwin-tdep.c: Sort headers.
7684         * amd64-bsd-nat.c: Sort headers.
7685         * alpha-tdep.c: Sort headers.
7686         * alpha-obsd-tdep.c: Sort headers.
7687         * alpha-nbsd-tdep.c: Sort headers.
7688         * alpha-mdebug-tdep.c: Sort headers.
7689         * alpha-linux-tdep.c: Sort headers.
7690         * alpha-linux-nat.c: Sort headers.
7691         * alpha-bsd-tdep.c: Sort headers.
7692         * alpha-bsd-nat.c: Sort headers.
7693         * aix-thread.c: Sort headers.
7694         * agent.c: Sort headers.
7695         * addrmap.c: Sort headers.
7696         * ada-varobj.c: Sort headers.
7697         * ada-valprint.c: Sort headers.
7698         * ada-typeprint.c: Sort headers.
7699         * ada-tasks.c: Sort headers.
7700         * ada-lang.c: Sort headers.
7701         * aarch64-tdep.c: Sort headers.
7702         * aarch64-ravenscar-thread.c: Sort headers.
7703         * aarch64-newlib-tdep.c: Sort headers.
7704         * aarch64-linux-tdep.c: Sort headers.
7705         * aarch64-linux-nat.c: Sort headers.
7706         * aarch64-fbsd-tdep.c: Sort headers.
7707         * aarch64-fbsd-nat.c: Sort headers.
7708         * aarch32-linux-nat.c: Sort headers.
7709
7710 2019-04-04  Tom Tromey  <tom@tromey.com>
7711
7712         * varobj.c (varobj_create): Update.
7713         * rust-exp.y (struct rust_parser) <update_innermost_block,
7714         lookup_symbol>: New methods.
7715         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7716         Rename.
7717         (rust_parser::rust_lookup_type)
7718         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7719         * printcmd.c (display_command, do_one_display): Update.
7720         * parser-defs.h (struct parser_state) <parser_state>: Add
7721         "tracker" parameter.
7722         (block_tracker): New member.
7723         (class innermost_block_tracker) <innermost_block_tracker>: Add
7724         "types" parameter.
7725         <reset>: Remove method.
7726         (innermost_block): Don't declare.
7727         (null_post_parser): Update.
7728         * parse.c (innermost_block): Remove global.
7729         (write_dollar_variable): Update.
7730         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7731         Remove "tracker_types" parameter.
7732         (parse_expression): Add "tracker" parameter.
7733         (parse_expression_for_completion): Update.
7734         (null_post_parser): Add "tracker" parameter.
7735         * p-exp.y: Update rules.
7736         * m2-exp.y: Update rules.
7737         * language.h (struct language_defn) <la_post_parser>: Add
7738         "tracker" parameter.
7739         * go-exp.y: Update rules.
7740         * f-exp.y: Update rules.
7741         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7742         parameter.
7743         * d-exp.y: Update rules.
7744         * c-exp.y: Update rules.
7745         * breakpoint.c (set_breakpoint_condition): Create an
7746         innermost_block_tracker.
7747         (watch_command_1): Likewise.
7748         * ada-lang.c (resolve): Add "tracker" parameter.
7749         (resolve_subexp): Likewise.
7750         * ada-exp.y (write_var_from_sym): Update.
7751
7752 2019-04-04  Tom Tromey  <tom@tromey.com>
7753
7754         * type-stack.h: New file.
7755         * type-stack.c: New file.
7756         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7757         type-stack.h.
7758         (insert_into_type_stack, insert_type, push_type, push_type_int)
7759         (insert_type_address_space, pop_type, pop_type_int)
7760         (pop_typelist, pop_type_stack, append_type_stack)
7761         (push_type_stack, get_type_stack, push_typelist)
7762         (follow_type_instance_flags, follow_types): Don't declare.
7763         * parse.c (type_stack): Remove global.
7764         (parse_exp_in_context): Update.
7765         (insert_into_type_stack, insert_type, push_type, push_type_int)
7766         (insert_type_address_space, pop_type, pop_type_int)
7767         (pop_typelist, pop_type_stack, append_type_stack)
7768         (push_type_stack, get_type_stack, push_typelist)
7769         (follow_type_instance_flags, follow_types): Remove (moved to
7770         type-stack.c).
7771         * f-exp.y (type_stack): New global.
7772         Update rules.
7773         (push_kind_type, f_parse): Update.
7774         * d-exp.y (type_stack): New global.
7775         Update rules.
7776         (d_parse): Update.
7777         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7778         Update rules.
7779         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7780         (HFILES_NO_SRCDIR): Add type-stack.h.
7781
7782 2019-04-04  Tom Tromey  <tom@tromey.com>
7783
7784         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7785         (rust_parser::convert_ast_to_expression, rust_parse)
7786         (rust_lex_test_completion, rust_lex_tests): Update.
7787         * parser-defs.h (struct expr_completion_state): New.
7788         (struct parser_state) <parser_state>: Add completion parameter.
7789         <mark_struct_expression, mark_completion_tag>: New methods.
7790         <parse_completion, m_completion_state>: New members.
7791         (prefixify_expression, null_post_parser): Update.
7792         (mark_struct_expression, mark_completion_tag): Don't declare.
7793         * parse.c (parse_completion, expout_last_struct)
7794         (expout_tag_completion_type, expout_completion_name): Remove
7795         globals.
7796         (parser_state::mark_struct_expression)
7797         (parser_state::mark_completion_tag): Now methods.
7798         (prefixify_expression): Add last_struct parameter.
7799         (prefixify_subexp): Likewise.
7800         (parse_exp_1): Update.
7801         (parse_exp_in_context): Add cstate parameter.  Update.
7802         (parse_expression_for_completion): Create an
7803         expr_completion_state.
7804         (null_post_parser): Add "completion" parameter.
7805         * p-exp.y: Update rules.
7806         (yylex): Update.
7807         * language.h (struct language_defn) <la_post_parser>: Add
7808         "completing" parameter.
7809         * go-exp.y: Update rules.
7810         (lex_one_token): Update.
7811         * expression.h (parse_completion): Don't declare.
7812         * d-exp.y: Update rules.
7813         (lex_one_token): Update rules.
7814         * c-exp.y: Update rules.
7815         (lex_one_token): Update.
7816         * ada-lang.c (resolve): Add "parse_completion" parameter.
7817         (resolve_subexp): Likewise.
7818         (ada_resolve_function): Likewise.
7819
7820 2019-04-04  Tom Tromey  <tom@tromey.com>
7821
7822         * parser-defs.h (struct parser_state) <start_arglist,
7823         end_arglist>: New methods.
7824         <arglist_len, m_funcall_chain>: New members.
7825         (arglist_len, start_arglist, end_arglist): Don't declare.
7826         * parse.c (arglist_len, funcall_chain): Remove global.
7827         (start_arglist, end_arglist): Remove functions.
7828         (parse_exp_in_context): Update.
7829         * p-exp.y: Update rules.
7830         * m2-exp.y: Update rules.
7831         * go-exp.y: Update rules.
7832         * f-exp.y: Update rules.
7833         * d-exp.y: Update rules.
7834         * c-exp.y: Update rules.
7835
7836 2019-04-04  Tom Tromey  <tom@tromey.com>
7837
7838         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7839         lex_operator, push_back>: New methods.
7840         Update all rules.
7841         (rust_parser::lex_hex, lex_escape): Rename and update.
7842         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7843         (rust_parser::lex_operator): Rename and update.
7844         (rust_parser::lex_number, rustyylex, rustyyerror)
7845         (rust_lex_test_init, rust_lex_test_sequence)
7846         (rust_lex_test_push_back, rust_lex_tests): Update.
7847         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7848         parameter.
7849         <lexptr, prev_lexptr>: New members.
7850         (lexptr, prev_lexptr): Don't declare.
7851         * parse.c (lexptr, prev_lexptr): Remove globals.
7852         (parse_exp_in_context): Update.
7853         * p-exp.y (yylex, yyerror): Update.
7854         * m2-exp.y (parse_number, yylex, yyerror): Update.
7855         * go-exp.y (lex_one_token, yyerror): Update.
7856         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7857         * d-exp.y (lex_one_token, yyerror): Update.
7858         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7859         (lex_one_token, yyerror): Update.
7860         * ada-lex.l (YY_INPUT): Update.
7861         (rewind_to_char): Update.
7862         * ada-exp.y (yyerror): Update.
7863
7864 2019-04-04  Tom Tromey  <tom@tromey.com>
7865
7866         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7867         * parser-defs.h (struct parser_state) <parser_state>: Add new
7868         parameter.
7869         <comma_terminates>: New member.
7870         (comma_terminates): Don't declare global.
7871         * parse.c (comma_terminates): Remove global.
7872         (parse_exp_in_context): Update.
7873         * p-exp.y (yylex): Update.
7874         * m2-exp.y (yylex): Update.
7875         * go-exp.y (lex_one_token): Update.
7876         * f-exp.y (yylex): Update.
7877         * d-exp.y (lex_one_token): Update.
7878         * c-exp.y (lex_one_token): Update.
7879         * ada-lex.l: Update.
7880
7881 2019-04-04  Tom Tromey  <tom@tromey.com>
7882
7883         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7884         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7885         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7886         * parser-defs.h (paren_depth): Don't declare.
7887         * parse.c (paren_depth): Remove global.
7888         (parse_exp_in_context): Update.
7889         * p-exp.y (paren_depth): New global.
7890         (pascal_parse): Initialize it.
7891         * m2-exp.y (paren_depth): New global.
7892         (m2_parse): Initialize it.
7893         * go-exp.y (paren_depth): New global.
7894         (go_parse): Initialize it.
7895         * f-exp.y (paren_depth): New global.
7896         (f_parse): Initialize it.
7897         * d-exp.y (paren_depth): New global.
7898         (d_parse): Initialize it.
7899         * c-exp.y (paren_depth): New global.
7900         (c_parse): Initialize it.
7901         * ada-lex.l (paren_depth): New global.
7902         (lexer_init): Initialize it.
7903
7904 2019-04-04  Tom Tromey  <tom@tromey.com>
7905
7906         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7907         (rust_parser::convert_ast_to_type)
7908         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7909         * parser-defs.h (struct parser_state) <parser_state>: Add
7910         parameters.  Initialize new members.
7911         <expression_context_block, expression_context_pc>: New members.
7912         * parse.c (expression_context_block, expression_context_pc):
7913         Remove globals.
7914         (parse_exp_in_context): Update.
7915         * p-exp.y: Update all rules.
7916         (yylex): Update.
7917         * m2-exp.y: Update all rules.
7918         (yylex): Update.
7919         * go-exp.y (yylex): Update.
7920         * f-exp.y (yylex): Update.
7921         * d-exp.y: Update all rules.
7922         (yylex): Update.
7923         * c-exp.y: Update all rules.
7924         (lex_one_token, classify_name, yylex, c_parse): Update.
7925         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7926
7927 2019-04-04  Tom Tromey  <tom@tromey.com>
7928
7929         * gdbarch.h, gdbarch.c: Rebuild.
7930         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7931         * stap-probe.h:
7932         (struct stap_parse_info): Replace "parser_state" with
7933         "expr_builder".
7934         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7935         (parser_state): New class.
7936         * parse.c (expr_builder): Rename.
7937         (expr_builder::release): Rename.
7938         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7939         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7940         (write_exp_elt_longcst, write_exp_elt_floatcst)
7941         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7942         (write_exp_string_vector, write_exp_bitstring)
7943         (write_exp_msymbol, mark_struct_expression)
7944         (write_dollar_variable)
7945         (insert_type_address_space, increase_expout_size): Replace
7946         "parser_state" with "expr_builder".
7947         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7948         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7949         "parser_state" with "expr_builder".
7950
7951 2019-04-04  Tom Tromey  <tom@tromey.com>
7952
7953         * rust-exp.y: Replace "parse_language" with method call.
7954         * p-exp.y:
7955         (yylex): Replace "parse_language" with method call.
7956         * m2-exp.y:
7957         (yylex): Replace "parse_language" with method call.
7958         * go-exp.y (classify_name): Replace "parse_language" with method
7959         call.
7960         * f-exp.y (yylex): Replace "parse_language" with method call.
7961         * d-exp.y (lex_one_token): Replace "parse_language" with method
7962         call.
7963         * c-exp.y:
7964         (lex_one_token, classify_name, yylex): Replace "parse_language"
7965         with method call.
7966         * ada-exp.y (find_primitive_type, type_char)
7967         (type_system_address): Replace "parse_language" with method call.
7968
7969 2019-04-04  Tom Tromey  <tom@tromey.com>
7970
7971         * rust-exp.y: Replace "parse_gdbarch" with method call.
7972         * parse.c (write_dollar_variable, insert_type_address_space):
7973         Replace "parse_gdbarch" with method call.
7974         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7975         call.
7976         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7977         call.
7978         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7979         "parse_gdbarch" with method call.
7980         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7981         with method call.
7982         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7983         "parse_gdbarch" with method call.
7984         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7985         "parse_gdbarch" with method call.
7986         * c-exp.y (parse_type, parse_number, classify_name): Replace
7987         "parse_gdbarch" with method call.
7988         * ada-lex.l: Replace "parse_gdbarch" with method call.
7989         * ada-exp.y (parse_type, find_primitive_type, type_char)
7990         (type_system_address): Replace "parse_gdbarch" with method call.
7991
7992 2019-04-04  Tom Tromey  <tom@tromey.com>
7993
7994         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7995         * stap-probe.c (stap_parse_argument): Update.
7996         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7997         initial_size parameter.
7998         * rust-exp.y (rust_lex_tests): Update.
7999         * parse.c (parser_state): Update.
8000         (parse_exp_in_context): Update.
8001         * parser-defs.h (struct parser_state) <parser_state>: Remove
8002         "initial_size" parameter.
8003
8004 2019-04-04  Tom Tromey  <tom@tromey.com>
8005
8006         * parser-defs.h (increase_expout_size): Don't declare.
8007         * parse.c (increase_expout_size): Now static.
8008
8009 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
8010
8011         * gnu-nat.c (gnu_nat_target::wait): Fix
8012         target_waitstatus_to_string call.
8013
8014 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8015
8016         * eval.c (evaluate_subexp_standard): Handle internal functions
8017         during Fortran function call handling.
8018
8019 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8020
8021         * NEWS: Mention new internal functions.
8022         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
8023         (read_base_type): Use dwarf2_init_complex_target_type.
8024         * value.c (creal_internal_fn): New function.
8025         (cimag_internal_fn): New function.
8026         (_initialize_values): Register new internal functions.
8027
8028 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8029
8030         * infrun.c (stop_all_threads): If debug_infrun, always
8031         trace the wait status after wait_one, using
8032         target_waitstatus_to_string and target_pid_to_str.
8033         (handle_inferior_event): Replace various trace of
8034         wait status kind by a single trace.
8035         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
8036         wait status kind image by target_waitstatus_to_string.
8037         * target/waitstatus.c (target_waitstatus_to_string): Fix
8038         obsolete comment.
8039
8040 2019-04-01  Tom Tromey  <tromey@adacore.com>
8041
8042         PR symtab/23331:
8043         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
8044
8045 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
8046             Pedro Alves  <palves@redhat.com>
8047
8048         * top.c (quit_force): Call 'finalize_values'.
8049         * value.c (finalize_values): New function.
8050         * value.h (finalize_values): Declare.
8051
8052 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
8053
8054         * NEWS: Announce $_gdb_major and $_gdb_minor.
8055
8056         * top.c (init_gdb_version_vars): New function.
8057         (gdb_init): Call init_gdb_version_vars.
8058
8059 2019-03-29  Tom Tromey  <tromey@adacore.com>
8060
8061         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
8062         help text.  Remove dead code.
8063
8064 2019-03-29  Keith Seitz  <keiths@redhat.com>
8065
8066         From Siddhesh Poyarekar:
8067         * f-lang.h (f77_get_upperbound): Return LONGEST.
8068         (f77_get_lowerbound): Likewise.
8069         * f-typeprint.c (f_type_print_varspec_suffix): Expand
8070         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
8071         print them.
8072         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
8073         plongest to format print it.
8074         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
8075         (f77_get_upperbound): Likewise.
8076         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
8077         LOWER_BOUND to LONGEST.
8078         (f77_create_arrayprint_offset_tbl): Likewise.
8079
8080 2019-03-29  Keith Seitz  <keiths@redhat.com>
8081
8082         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
8083         %s/pulongest for TYPE_LENGTH instead of %d in format
8084         strings.
8085         * ada-typerint.c (ada_print_type): Likewise.
8086         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
8087         * compile/compile-c-support.c (generate_register_struct): Likewise.
8088         * gdbtypes.c (recursive_dump_type): Likewise.
8089         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
8090         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
8091         instead of %d in format strings.
8092         * riscv-tdep.c (riscv_type_alignment): Cast second argument
8093         to std::min to ULONGEST.
8094         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
8095         instead of %d in format strings.
8096         * tracepoint.c (info_scope_command): Likewise.
8097         * typeprint.c (print_offset_data::update)
8098         (print_offset_data::finish): Likewise.
8099         * xtensa-tdep.c (xtensa_store_return_value)
8100         (xtensa_push_dummy_call): Likewise.
8101
8102 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
8103
8104         * windows-nat.c (display_selector): Fixed format specifications
8105         for 64-bit Cygwin.
8106
8107 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8108
8109         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
8110
8111 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
8112
8113         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
8114         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
8115         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
8116         (nios2_linux_init_abi): Install it.
8117
8118 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8119
8120         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
8121
8122 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8123
8124         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
8125
8126 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8127             Tom Tromey  <tromey@adacore.com>
8128
8129         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
8130
8131 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
8132
8133         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
8134         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
8135         method to compute the bounds of range types. Also print "[evaluated]"
8136         if the bounds' values come from a dynamic evaluation.
8137
8138 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8139
8140         * cp-valprint.c (cp_print_value_fields): Don't print trailing
8141         whitespace when pretty printing is on.
8142
8143 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8144
8145         * ppc-linux-nat.c: Add include.
8146
8147 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8148
8149         * NEWS: Mention AArch64 Pointer Authentication.
8150
8151 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8152
8153         * arm-linux-nat.c: Add include.
8154
8155 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
8156
8157         * source-cache.c (source_cache::get_source_lines): Re-read
8158         fullname after calling open_source_file.
8159
8160 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
8161
8162         * NEWS: Mention TLS support for FreeBSD.
8163
8164 2019-03-25  Tom Tromey  <tromey@adacore.com>
8165
8166         * minsyms.c (BUNCH_SIZE): Update comment.
8167         (~minimal_symbol_reader): Remove old comment.
8168         (compact_minimal_symbols): Update comment.
8169         (minimal_symbol_reader::install): Remove old comment.  Update
8170         other comments.
8171
8172 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8173
8174         * s390-linux-nat.c: Add include.
8175
8176 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8177
8178         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
8179         Call linux_get_hwcap.
8180         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
8181         Likewise.
8182         (aarch64_linux_get_hwcap): Remove function.
8183         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
8184         declaration.
8185         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
8186         linux_get_hwcap.
8187         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
8188         * linux-tdep.c (linux_get_hwcap): Add function.
8189         (linux_get_hwcap2): Likewise.
8190         * linux-tdep.h (linux_get_hwcap): Add declaration.
8191         (linux_get_hwcap2): Likewise.
8192         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
8193         (ppc_linux_get_hwcap2): Likewise.
8194         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
8195         linux_get_hwcap.
8196         (ppc_linux_nat_target::insert_watchpoint): Likewise.
8197         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
8198         (ppc_linux_nat_target::read_description): Likewise.
8199         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
8200         * s390-linux-nat.c: Likewise.
8201         * s390-linux-tdep.c (s390_core_read_description): Likewise.
8202
8203 2019-03-24  Tom Tromey  <tom@tromey.com>
8204
8205         * ada-lang.c (standard_lookup): Simplify initialization.
8206         (ada_lookup_symbol_nonlocal): Simplify return.
8207         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
8208         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
8209         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
8210         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
8211         initialization.
8212         * solib.c (solib_global_lookup): Simplify.
8213         * symtab.c (null_block_symbol): Remove.
8214         (symbol_cache_lookup): Simplify returns.
8215         (lookup_language_this): Simplify returns.
8216         (lookup_symbol_aux): Simplify return.
8217         (lookup_local_symbol): Simplify returns.
8218         (lookup_global_symbol_from_objfile): Simplify return.
8219         (lookup_symbol_in_objfile_symtabs)
8220         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
8221         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
8222         (lookup_static_symbol, lookup_global_symbol): Simplify return.
8223         * cp-namespace.c (cp_lookup_bare_symbol)
8224         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
8225         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
8226         (cp_lookup_nested_symbol): Don't use null_block_symbol.
8227         (cp_lookup_symbol_via_imports): Simplify initialization.
8228         (find_symbol_in_baseclass): Likewise.
8229         * symtab.h (null_block_symbol): Remove.
8230         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
8231         (d_lookup_nested_symbol, d_lookup_symbol_imports)
8232         (d_lookup_symbol_module): Likewise.
8233         (find_symbol_in_baseclass): Simplify initialization.
8234
8235 2019-03-24  Tom Tromey  <tom@tromey.com>
8236
8237         * expression.h: Don't include symtab.h.
8238         (struct block): Forward declare.
8239
8240 2019-03-24  Tom Tromey  <tom@tromey.com>
8241
8242         * c-exp.y (typebase): Remove casts.
8243         * gdbtypes.c (lookup_unsigned_typename, )
8244         (lookup_signed_typename): Remove cast.
8245         * eval.c (parse_to_comma_and_eval): Remove cast.
8246         * parse.c (write_dollar_variable): Remove cast.
8247         * block.h (struct block) <superblock>: Now const.
8248         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
8249         * psymtab.c (psym_map_matching_symbols): Make "block" const.
8250         (map_block): Make "block" const.
8251         * symfile.h (struct quick_symbol_functions)
8252         <map_matching_symbols>: Constify block argument to "callback".
8253         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
8254         const.
8255         (find_pc_sect_compunit_symtab): Make "b" const.
8256         (find_symbol_at_address): Likewise.
8257         (search_symbols): Likewise.
8258         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
8259         (dw2_debug_names_lookup_symbol): Likewise.
8260         (dw2_map_matching_symbols): Update.
8261         * p-valprint.c (pascal_val_print): Remove "block".
8262         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
8263         (aux_add_nonlocal_symbols): Make "block" const.
8264         (resolve_subexp): Remove cast.
8265         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
8266         const.
8267         (iterate_over_file_blocks): Likewise.
8268         * f-exp.y (%union) <bval>: Remove.
8269         * coffread.c (patch_opaque_types): Make "b" const.
8270         * spu-tdep.c (spu_catch_start): Make "block" const.
8271         * c-valprint.c (print_unpacked_pointer): Remove "block".
8272         * symmisc.c (dump_symtab_1): Make "b" const.
8273         (block_depth): Make "block" const.
8274         * d-exp.y (%union) <bval>: Remove.
8275         * cp-support.h (cp_lookup_rtti_type): Update.
8276         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
8277         * psymtab.c (psym_lookup_symbol): Make "block" const.
8278         (maintenance_check_psymtabs): Make "b" const.
8279         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
8280         (enumerate_locals, enumerate_args): Update.
8281         * python/py-symtab.c (stpy_global_block): Make "block" const.
8282         (stpy_static_block): Likewise.
8283         * inline-frame.c (block_starting_point_at): Make "new_block"
8284         const.
8285         * block.c (find_block_in_blockvector): Make return type const.
8286         (blockvector_for_pc_sect): Make "b" const.
8287         (find_block_in_blockvector): Make "b" const.
8288
8289 2019-03-23  Tom Tromey  <tom@tromey.com>
8290
8291         * varobj.c (varobj_create): Update.
8292         * symfile.c (clear_symtab_users): Don't reset innermost_block.
8293         * printcmd.c (display_command, do_one_display): Don't reset
8294         innermost_block.
8295         * parser-defs.h (enum innermost_block_tracker_type): Move to
8296         expression.h.
8297         (innermost_block): Update comment.
8298         * parse.c (parse_exp_1): Add tracker_types parameter.
8299         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
8300         tracker_types parameter.  Reset innermost_block.
8301         (parse_exp_in_context): Remove.
8302         (parse_expression_for_completion): Update.
8303         * objfiles.c (~objfile): Don't reset expression_context_block or
8304         innermost_block.
8305         * expression.h (enum innermost_block_tracker_type): Move from
8306         parser-defs.h.
8307         (parse_exp_1): Add tracker_types parameter.
8308         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
8309         reset innermost_block.
8310
8311 2019-03-23  Tom Tromey  <tom@tromey.com>
8312
8313         * objfiles.h: Include bcache.h.
8314
8315 2019-03-23  Tom Tromey  <tom@tromey.com>
8316
8317         * linespec.c (get_current_search_block): Use
8318         scoped_restore_current_language.
8319         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
8320
8321 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8322             Jiong Wang  <jiong.wang@arm.com>
8323
8324         * aarch64-linux-tdep.c
8325         (aarch64_linux_iterate_over_regset_sections): Check for pauth
8326         section.
8327         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
8328
8329 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8330             Jiong Wang  <jiong.wang@arm.com>
8331
8332         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
8333         instructions.
8334         (aarch64_analyze_prologue_test): Add PACIASP test.
8335         (aarch64_prologue_prev_register): Unmask PC value.
8336
8337 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8338             Jiong Wang  <jiong.wang@arm.com>
8339
8340         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
8341         (aarch64_dwarf2_prev_register): Unmask PC value.
8342         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
8343         (aarch64_execute_dwarf_cfa_vendor_op): Check for
8344         DW_CFA_AARCH64_negate_ra_state.
8345         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
8346
8347 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8348             Jiong Wang  <jiong.wang@arm.com>
8349
8350         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
8351         registers.
8352         (aarch64_pseudo_register_name): Likewise.
8353         (aarch64_pseudo_register_type): Likewise.
8354         (aarch64_pseudo_register_reggroup_p): Likewise.
8355         (aarch64_gdbarch_init): Add pauth registers.
8356         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
8357         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
8358         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
8359         (struct gdbarch_tdep): Add regnum for ra_state.
8360
8361 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8362             Jiong Wang  <jiong.wang@arm.com>
8363
8364         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
8365
8366 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8367             Jiong Wang  <jiong.wang@arm.com>
8368
8369         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
8370         function.
8371         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
8372         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
8373         (aarch64_gdbarch_init): Add puth registers.
8374         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
8375         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
8376         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
8377
8378 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8379             Jiong Wang  <jiong.wang@arm.com>
8380
8381         * aarch64-linux-nat.c
8382         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
8383         * aarch64-linux-tdep.c
8384         (aarch64_linux_core_read_description): Likewise.
8385         (aarch64_linux_get_hwcap): New function.
8386         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
8387         (aarch64_linux_get_hwcap): New declaration.
8388
8389 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8390             Jiong Wang  <jiong.wang@arm.com>
8391
8392         * aarch64-linux-nat.c
8393         (aarch64_linux_nat_target::read_description): Add pauth param.
8394         * aarch64-linux-tdep.c
8395         (aarch64_linux_core_read_description): Likewise.
8396         * aarch64-tdep.c (struct target_desc): Add in pauth.
8397         (aarch64_read_description): Add pauth param.
8398         (aarch64_gdbarch_init): Likewise.
8399         * aarch64-tdep.h (aarch64_read_description): Likewise.
8400         * arch/aarch64.c (aarch64_create_target_description): Likewise.
8401         * arch/aarch64.h (aarch64_create_target_description): Likewise.
8402         * features/Makefile: Add new files.
8403         * features/aarch64-pauth.c: New file.
8404         * features/aarch64-pauth.xml: New file.
8405
8406 2019-03-20  Tom Tromey  <tromey@adacore.com>
8407
8408         * infrun.c (handle_inferior_event): Rename from
8409         handle_inferior_event_1.  Create a scoped_value_mark.
8410         (handle_inferior_event): Remove.
8411
8412 2019-03-19  Tom Tromey  <tromey@adacore.com>
8413
8414         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
8415         * infrun.h (print_stop_event): Add "displays" parameter.
8416         * infrun.c (print_stop_event): Add "displays" parameter.
8417
8418 2019-03-19  Pedro Alves  <palves@redhat.com>
8419
8420         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8421         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
8422         to -1.  Fix TABs vs spaces.
8423         (tui_ui_out::tui_ui_out): Don't initialize fields here.
8424         * tui/tui-out.h (tui_ui_out) Add intro comments.
8425         <m_line, m_start_of_line>: In-class initialize, and add describing
8426         comment.
8427
8428 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
8429
8430         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8431         variable names.
8432         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8433
8434 2019-03-18  Pedro Alves  <palves@redhat.com>
8435             Eli Zaretskii <eliz@gnu.org>
8436
8437         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8438         m_line and m_start_of_line.
8439
8440 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
8441
8442         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8443         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8444         it returns a newline.  This fixes a regression in TU mode, whereby
8445         the next line is output on the same screen line as the user input.
8446
8447 2019-03-18  Tom Tromey  <tromey@adacore.com>
8448
8449         * minsyms.c (minimal_symbol_reader::install): Remove call to
8450         obstack_blank.
8451
8452 2019-03-18  Pedro Alves  <palves@redhat.com>
8453
8454         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8455         New globals.
8456         (apply_style): New, factored out from ...
8457         (apply_ansi_escape): ... this.  Handle reverse video mode.
8458         (tui_set_reverse_mode): New function.
8459         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8460         * tui/tui-winsource.c (tui_show_source_line): Use
8461         tui_set_reverse_mode instead of setting A_STANDOUT.
8462         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8463         New setter methods.
8464
8465 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
8466
8467         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8468         Handle tabs.
8469
8470 2019-03-18  Tom Tromey  <tromey@adacore.com>
8471
8472         * ada-lang.c (empty_array): Add "high" parameter.
8473         (ada_evaluate_subexp): Update.
8474
8475 2019-03-17  Sergei Trofimovich <siarheit@google.com>
8476
8477         * unittests/string_view-selftests.c: Define
8478         _initialize_string_view_selftests unconditionally.
8479
8480 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8481
8482         PR gdb/24350
8483         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8484
8485 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8486
8487         PR gdb/24351
8488         * windows-nat.c (display_selector): Fix format specifiers.
8489
8490 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
8491
8492         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8493         tui_refill_source_window instead of tui_refresh_win, to update the
8494         current execution line.  This fixes redisplay of the current line
8495         when stepping through the code with "next" or "step".
8496
8497 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8498
8499         * source-cache.c (source_cache::get_source_lines): Call
8500         find_source_lines to initialize s->nlines.  This fixes vertical
8501         scrolling of TUI source window when the DOWN arrow is pressed.
8502
8503 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8504
8505         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8506         linux-thread-db.c (_initialize_thread_db): Likewise.
8507
8508 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8509
8510         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8511         wclrtoeol in tui_show_source_line".  This reverts changes made in
8512         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8513
8514 2019-03-15  Tom Tromey  <tom@tromey.com>
8515
8516         * symtab.h (struct minimal_symbol): Derive from
8517         general_symbol_info.
8518         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8519         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8520         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8521         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8522         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8523         (MSYMBOL_SEARCH_NAME): Update.
8524         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8525         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8526         * minsyms.c (minimal_symbol_reader::record_full): Update.
8527
8528 2019-03-15  Tom Tromey  <tom@tromey.com>
8529
8530         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8531
8532 2019-03-15  Tom Tromey  <tom@tromey.com>
8533
8534         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8535         unique_xmalloc_ptr.
8536         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8537         Update.
8538         * minsyms.c (lookup_minimal_symbol_by_pc_section)
8539         (build_minimal_symbol_hash_tables)
8540         (minimal_symbol_reader::install): Update.
8541
8542 2019-03-15  Tom Tromey  <tom@tromey.com>
8543
8544         * symtab.c (create_demangled_names_hash): Update.
8545         (symbol_set_names): Update.
8546         * objfiles.h (struct objfile_per_bfd_storage)
8547         <demangled_names_hash>: Now an htab_up.
8548         * objfiles.c (objfile_per_bfd_storage): Simplify.
8549
8550 2019-03-15  Tom Tromey  <tom@tromey.com>
8551
8552         * objfiles.h (struct objfile_per_bfd_storage): Declare
8553         destructor.
8554         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8555         New.
8556         (get_objfile_bfd_data): Use new.  Don't initialize
8557         language_of_main.
8558         (free_objfile_per_bfd_storage): Remove.
8559         (objfile_bfd_data_free, objfile::~objfile): Use delete.
8560
8561 2019-03-15  Tom Tromey  <tom@tromey.com>
8562
8563         * symfile.c (reread_symbols): Update.
8564         * objfiles.c (objfile::objfile): Update.
8565         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8566         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8567         comment.
8568         (minimal_symbol_reader::install): Update.
8569         (terminate_minimal_symbol_table): Remove.
8570         * jit.c (jit_object_close_impl): Update.
8571
8572 2019-03-15  Tom Tromey  <tom@tromey.com>
8573
8574         * minsyms.c (minimal_symbol_reader::record_full): Remove some
8575         initializations.
8576
8577 2019-03-15  Tom Tromey  <tom@tromey.com>
8578
8579         * objfiles.h (struct objfile_per_bfd_storage)
8580         <demangled_hash_languages>: Now a bitset.
8581         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8582         (lookup_minimal_symbol): Update.
8583
8584 2019-03-15  Tom Tromey  <tom@tromey.com>
8585
8586         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8587         Don't return the symbol.
8588         * coffread.c (record_minimal_symbol): Use record_full.
8589
8590 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
8591
8592         The MS-Windows port of ncurses fails to switch to a color pair if
8593         one or both of the colors are the implicit default colors.  This
8594         change records the default colors when TUI is initialized, and
8595         then specifies them explicitly when a color pair uses the default
8596         colors.  This allows color styling in TUI mode on MS-Windows.
8597
8598         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
8599         ncurses_norm_attr.
8600         (tui_initialize_io) [__MINGW32__]: Record the default terminal
8601         colors in ncurses_norm_attr.
8602         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8603         "none", replace it with the default color recorded in
8604         ncurses_norm_attr.
8605
8606 2019-03-14  Tom Tromey  <tromey@adacore.com>
8607
8608         * source-cache.h (class source_cache) <get_source_lines>: Return
8609         std::string.
8610         * source-cache.c (source_cache::extract_lines): Handle case where
8611         first_pos==npos.  Return std::string.
8612         (source_cache::get_source_lines): Update.
8613
8614 2019-03-14  Tom Tromey  <tromey@adacore.com>
8615
8616         * NEWS: Add item for "style sources" commands.
8617         * source-cache.c (source_cache::get_source_lines): Check
8618         source_styling.
8619         * cli/cli-style.c (source_styling): New global.
8620         (_initialize_cli_style): Add "style sources" commands.
8621         (show_style_sources): New function.
8622         * cli/cli-style.h (source_styling): Declare.
8623
8624 2019-03-14  Pedro Alves  <palves@redhat.com>
8625             Tom Tromey  <tromey@adacore.com>
8626
8627         * tui/tui-winsource.h (tui_refill_source_window): Declare.
8628         * tui/tui-winsource.c (tui_refill_source_window): New function,
8629         from...
8630         (tui_horizontal_source_scroll): ... here.  Move some logic.
8631         * cli/cli-style.c (set_style_enabled): Notify new observable.
8632         * tui/tui-hooks.c (tui_redisplay_source): New function.
8633         (tui_attach_detach_observers): Attach or detach
8634         tui_redisplay_source.
8635         * observable.h (source_styling_changed): New observable.
8636         * observable.c: Define source_styling_changed observable.
8637
8638 2019-03-13  Tom Tromey  <tromey@adacore.com>
8639
8640         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8641         (i386_gnu_nat_target::store_registers): Update.
8642         * target-debug.h (target_debug_print_std_string): New macro.
8643         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8644         * windows-tdep.c (display_one_tib): Update.
8645         * tui/tui-stack.c (tui_make_status_line): Update.
8646         * top.c (print_inferior_quit_action): Update.
8647         * thread.c (thr_try_catch_cmd): Update.
8648         (add_thread_with_info): Update.
8649         (thread_target_id_str): Update.
8650         (thr_try_catch_cmd): Update.
8651         (thread_command): Update.
8652         (thread_find_command): Update.
8653         * record-btrace.c (record_btrace_target::info_record)
8654         (record_btrace_resume_thread, record_btrace_target::resume)
8655         (record_btrace_cancel_resume, record_btrace_step_thread)
8656         (record_btrace_target::wait, record_btrace_target::wait)
8657         (record_btrace_target::wait, record_btrace_target::stop): Update.
8658         * progspace.c (print_program_space): Update.
8659         * process-stratum-target.c
8660         (process_stratum_target::thread_address_space): Update.
8661         * linux-fork.c (linux_fork_mourn_inferior)
8662         (detach_checkpoint_command, info_checkpoints_command)
8663         (linux_fork_context): Update.
8664         (linux_fork_detach): Update.
8665         (class scoped_switch_fork_info): Update.
8666         (delete_checkpoint_command): Update.
8667         * infrun.c (follow_fork_inferior): Update.
8668         (follow_fork_inferior): Update.
8669         (proceed_after_vfork_done): Update.
8670         (handle_vfork_child_exec_or_exit): Update.
8671         (follow_exec): Update.
8672         (displaced_step_prepare_throw): Update.
8673         (displaced_step_restore): Update.
8674         (start_step_over): Update.
8675         (resume_1): Update.
8676         (clear_proceed_status_thread): Update.
8677         (proceed): Update.
8678         (print_target_wait_results): Update.
8679         (do_target_wait): Update.
8680         (context_switch): Update.
8681         (stop_all_threads): Update.
8682         (restart_threads): Update.
8683         (finish_step_over): Update.
8684         (handle_signal_stop): Update.
8685         (switch_back_to_stepped_thread): Update.
8686         (keep_going_pass_signal): Update.
8687         (print_exited_reason): Update.
8688         (normal_stop): Update.
8689         * inferior.c (inferior_pid_to_str): Change return type.
8690         (print_selected_inferior): Update.
8691         (add_inferior): Update.
8692         (detach_inferior): Update.
8693         * dummy-frame.c (fprint_dummy_frames): Update.
8694         * dcache.c (dcache_info_1): Update.
8695         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8696         (btrace_fetch, btrace_clear): Update.
8697         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8698         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8699         type.
8700         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8701         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8702         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8703         * gdbarch.c, gdbarch.h: Rebuild.
8704         * gdbarch.sh (core_pid_to_str): Change return type.
8705         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8706         return type.
8707         (windows_nat_target::pid_to_str): Change return type.
8708         (windows_delete_thread): Update.
8709         (windows_nat_target::attach): Update.
8710         (windows_nat_target::files_info): Update.
8711         * target-delegates.c: Rebuild.
8712         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8713         return type.
8714         (sol_thread_target::pid_to_str): Change return type.
8715         * remote.c (class remote_target) <pid_to_str>: Change return
8716         type.
8717         (remote_target::pid_to_str): Change return type.
8718         (extended_remote_target::attach, remote_target::remote_stop_ns)
8719         (remote_target::remote_notif_remove_queued_reply)
8720         (remote_target::push_stop_reply, remote_target::disable_btrace):
8721         Update.
8722         (extended_remote_target::attach): Update.
8723         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8724         type.
8725         (gdbsim_target::pid_to_str): Change return type.
8726         * ravenscar-thread.c (struct ravenscar_thread_target)
8727         <pid_to_str>: Change return type.
8728         (ravenscar_thread_target::pid_to_str): Change return type.
8729         * procfs.c (class procfs_target) <pid_to_str>: Change return
8730         type.
8731         (procfs_target::pid_to_str): Change return type.
8732         (procfs_target::attach): Update.
8733         (procfs_target::detach): Update.
8734         (procfs_target::fetch_registers): Update.
8735         (procfs_target::store_registers): Update.
8736         (procfs_target::wait): Update.
8737         (procfs_target::files_info): Update.
8738         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8739         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8740         return type.
8741         (nto_procfs_target::pid_to_str): Change return type.
8742         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8743         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8744         return type.
8745         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8746         (exit_lwp): Update.
8747         (attach_proc_task_lwp_callback, get_detach_signal)
8748         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8749         (linux_nat_target::resume, wait_lwp, stop_callback)
8750         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8751         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8752         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8753         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8754         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8755         type.
8756         (inf_ptrace_target::attach): Update.
8757         (inf_ptrace_target::files_info): Update.
8758         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8759         type.
8760         (go32_nat_target::pid_to_str): Change return type.
8761         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8762         (gnu_nat_target::wait): Update.
8763         (gnu_nat_target::wait): Update.
8764         (gnu_nat_target::resume): Update.
8765         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8766         (fbsd_nat_target::wait): Update.
8767         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8768         type.
8769         (darwin_nat_target::attach): Update.
8770         * corelow.c (class core_target) <pid_to_str>: Change return type.
8771         (core_target::pid_to_str): Change return type.
8772         * target.c (normal_pid_to_str): Change return type.
8773         (default_pid_to_str): Likewise.
8774         (target_pid_to_str): Change return type.
8775         (target_translate_tls_address): Update.
8776         (target_announce_detach): Update.
8777         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8778         return type.
8779         (bsd_uthread_target::pid_to_str): Change return type.
8780         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8781         type.
8782         (bsd_kvm_target::pid_to_str): Change return type.
8783         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8784         return type.
8785         (aix_thread_target::pid_to_str): Change return type.
8786         * target.h (struct target_ops) <pid_to_str>: Change return type.
8787         (target_pid_to_str, normal_pid_to_str): Likewise.
8788         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8789         type.
8790         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8791         type.
8792         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8793         return type.
8794         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8795         type.
8796         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8797         type.
8798         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8799         return type.
8800
8801 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8802
8803         * NEWS: Mention that the new default MI version is 3.  Mention
8804         changes to the output of commands and events that deal with
8805         multi-location breakpoints.
8806         * breakpoint.c: Include "mi/mi-out.h".
8807         (print_one_breakpoint): Change output syntax if using MI version
8808         >= 3.
8809         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8810         New.
8811         (mi_multi_location_breakpoint_output_fixed): New.
8812         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8813         (mi_cmd_fix_multi_location_breakpoint_output): New.
8814         (mi_multi_location_breakpoint_output_fixed): New.
8815         * mi/mi-cmds.c (mi_cmds): Register command
8816         -fix-multi-location-breakpoint-output.
8817         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8818         interpreter "mi".
8819
8820 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8821
8822         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8823         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8824         instantiate mi_ui_out based on interpreter name.
8825         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8826         * mi/mi-main.c (mi_load_progress): Likewise.
8827
8828 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8829
8830         * NEWS: Combine separate "New targets" sections for 8.3.
8831
8832 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8833
8834         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8835         (ppcfbsd_init_abi): Install gdbarch
8836         "fetch_tls_load_module_address" and "get_thread_local_address"
8837         methods.
8838
8839 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8840
8841         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8842         (riscv_fbsd_init_abi): Install gdbarch
8843         "fetch_tls_load_module_address" and "get_thread_local_address"
8844         methods.
8845
8846 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8847
8848         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8849         (i386fbsd_init_abi): Install gdbarch
8850         "fetch_tls_load_module_address" and "get_thread_local_address"
8851         methods.
8852
8853 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8854
8855         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8856         (amd64fbsd_init_abi): Install gdbarch
8857         "fetch_tls_load_module_address" and "get_thread_local_address"
8858         methods.
8859
8860 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8861
8862         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8863         (struct fbsd_pspace_data): New type.
8864         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8865         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8866         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8867         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8868         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8869
8870 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8871
8872         * gdbtypes.c (lookup_struct_elt): New function.
8873         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8874         * gdbtypes.h (struct struct_elt): New type.
8875         (lookup_struct_elt): New prototype.
8876
8877 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8878
8879         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8880         remove disabled code block.
8881
8882 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8883
8884         * gdbarch.sh (get_thread_local_address): New method.
8885         * gdbarch.h, gdbarch.c: Regenerate.
8886         * target.c (target_translate_tls_address): Use
8887         gdbarch_get_thread_local_address if present instead of
8888         target::get_thread_local_address.
8889
8890 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8891
8892         * target.h (target::get_thread_local_address): Update comment.
8893
8894 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8895
8896         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8897         objfile->separate_debug_objfile_backlink if not NULL.
8898
8899 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8900
8901         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8902         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8903         (amd64bsd_store_inferior_registers): Likewise.
8904         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8905         Enable segment base registers.
8906         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8907         PT_GETFSBASE and PT_GETGSBASE.
8908         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8909         PT_SETGSBASE.
8910         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8911         segment base registers.
8912         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8913
8914 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8915
8916         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8917         Update calls to i386_target_description to add 'segments'
8918         parameter.
8919         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8920         add segment base registers.
8921         * arch/i386.c (i386_create_target_description): Add 'segments'
8922         parameter to enable segment base registers.
8923         * arch/i386.h (i386_create_target_description): Likewise.
8924         * features/i386/32bit-segments.xml: New file.
8925         * features/i386/32bit-segments.c: Generate.
8926         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8927         call to i386_target_description to add 'segments' parameter.
8928         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8929         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8930         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8931         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8932         if feature is present.
8933         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8934         Add 'segments' parameter to call to i386_target_description.
8935         (i386_target_description): Add 'segments' parameter to enable
8936         segment base registers.
8937         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8938         to call to i386_target_description.
8939         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8940         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8941         Define I386_NUM_REGS.
8942         (i386_target_description): Add 'segments' parameter to enable
8943         segment base registers.
8944
8945 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8946
8947         PR/24325
8948         * source-cache.c: #undef open and close, to avoid unresolved
8949         externals during linking.
8950
8951 2019-03-12  Tom Tromey  <tromey@adacore.com>
8952
8953         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8954         const.  Add initializers.
8955         (_initialize_remote): Don't initialize ptid globals.
8956
8957 2019-03-12  Pedro Alves  <palves@redhat.com>
8958
8959         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8960
8961 2019-03-12  Pedro Alves  <palves@redhat.com>
8962
8963         * cp-name-parser.y (main): Remove unused 'len' variable.
8964
8965 2019-03-12  Tom Tromey  <tromey@adacore.com>
8966
8967         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8968         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8969
8970 2019-03-12  Tom Tromey  <tromey@adacore.com>
8971
8972         * linux-nat.c (iterate_over_lwps): Update.
8973         (stop_callback): Remove parameter.
8974         (stop_wait_callback, detach_callback, resume_set_callback)
8975         (select_singlestep_lwp_callback, set_ignore_sigint)
8976         (status_callback, resumed_callback, resume_clear_callback)
8977         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8978         data parameter.
8979         (linux_nat_target::detach, linux_nat_target::resume)
8980         (linux_stop_and_wait_all_lwps, select_event_lwp)
8981         (linux_nat_filter_event, linux_nat_wait_1)
8982         (linux_nat_target::kill, linux_nat_target::stop)
8983         (linux_nat_target::stop): Update.
8984         (linux_nat_resume_callback): Change type.
8985         (resume_stopped_resumed_lwps, count_events_callback)
8986         (select_event_lwp_callback): Likewise.
8987         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8988         * arm-linux-nat.c (struct update_registers_data): Remove.
8989         (update_registers_callback): Change type.
8990         (arm_linux_insert_hw_breakpoint1): Update.
8991         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8992         parameter.
8993         (x86_linux_dr_set_addr): Update.
8994         (x86_linux_dr_set_control): Update.
8995         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8996         (iterate_over_lwps): Use gdb::function_view.
8997         * nat/aarch64-linux-hw-point.c (struct
8998         aarch64_dr_update_callback_param): Remove.
8999         (debug_reg_change_callback): Change type.
9000         (aarch64_notify_debug_reg_change): Update.
9001         * s390-linux-nat.c (s390_refresh_per_info): Update.
9002
9003 2019-03-11  Tom Tromey  <tromey@adacore.com>
9004
9005         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
9006         redundant assignment to "this_cu".
9007
9008 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9009
9010         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
9011
9012 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9013
9014         * gdbtypes.c (rank_one_type_parm_set): New function extracted
9015         from...
9016         (rank_one_type): ... this.
9017
9018 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9019
9020         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
9021         from...
9022         (rank_one_type): ... this.
9023
9024 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9025
9026         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
9027         from...
9028         (rank_one_type): ... this.
9029
9030 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9031
9032         * gdbtypes.c (rank_one_type_parm_float): New function extracted
9033         from...
9034         (rank_one_type): ... this.
9035
9036 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9037
9038         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
9039         from...
9040         (rank_one_type): ... this.
9041
9042 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9043
9044         * gdbtypes.c (rank_one_type_parm_range): New function extracted
9045         from...
9046         (rank_one_type): ... this.
9047
9048 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9049
9050         * gdbtypes.c (rank_one_type_parm_char): New function extracted
9051         from...
9052         (rank_one_type): ... this.
9053
9054 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9055
9056         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
9057         from...
9058         (rank_one_type): ... this.
9059
9060 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9061
9062         * gdbtypes.c (rank_one_type_parm_int): New function extracted
9063         from...
9064         (rank_one_type): ... this.
9065
9066 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9067
9068         * gdbtypes.c (rank_one_type_parm_func): New function extracted
9069         from...
9070         (rank_one_type): ... this.
9071
9072 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9073
9074         * gdbtypes.c (rank_one_type_parm_array): New function extracted
9075         from...
9076         (rank_one_type): ... this.
9077
9078 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9079
9080         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
9081         from...
9082         (rank_one_type): ... this.
9083
9084 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9085
9086         * inferior.c (initialize_inferiors): Ensure 'help set/show print
9087         inferior-events' shows the example events.
9088
9089 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
9090
9091         Support styling on native MS-Windows console
9092
9093         PR/24315
9094         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
9095         on MS-Windows if $TERM is not defined.
9096
9097         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
9098
9099         * posix-hdep.c (gdb_console_fputs):
9100         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
9101         functions.
9102         * ui-file.h (gdb_console_fputs): Add prototype.
9103
9104         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
9105         back to fputs only if the former returns zero.
9106
9107 2019-03-07  Tom Tromey  <tom@tromey.com>
9108
9109         * symmisc.c (print_symbol_bcache_statistics): Update.
9110         (print_objfile_statistics): Update.
9111         * symfile.c (allocate_symtab): Update.
9112         * stabsread.c: Don't include bcache.h.
9113         * psymtab.h (struct psymbol_bcache): Don't declare.
9114         (class psymtab_storage) <psymbol_cache>: Now a bcache.
9115         (psymbol_bcache_init, psymbol_bcache_free)
9116         (psymbol_bcache_get_bcache): Don't declare.
9117         * psymtab.c (struct psymbol_bcache): Remove.
9118         (psymtab_storage::psymtab_storage): Update.
9119         (psymtab_storage::~psymtab_storage): Update.
9120         (psymbol_bcache_init, psymbol_bcache_free)
9121         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
9122         (add_psymbol_to_bcache): Update.
9123         (allocate_psymtab): Update.
9124         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
9125         macro_cache>: No longer pointers.
9126         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
9127         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
9128         * macrotab.c (macro_bcache): Update.
9129         * macroexp.c: Don't include bcache.h.
9130         * gdbtypes.c (check_types_worklist): Update.
9131         (types_deeply_equal): Remove TRY/CATCH.  Update.
9132         * elfread.c (elf_symtab_read): Update.
9133         * dwarf2read.c: Don't include bcache.h.
9134         * buildsym.c (buildsym_compunit::get_macro_table): Update.
9135         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
9136         (print_bcache_statistics, bcache_memory_used): Don't declare.
9137         (struct bcache): Move from bcache.c.  Add constructor, destructor,
9138         methods.  Rename all data members.
9139         * bcache.c (struct bcache): Move to bcache.h.
9140         (bcache::expand_hash_table): Rename from expand_hash_table.
9141         (bcache): Remove.
9142         (bcache::insert): Rename from bcache_full.
9143         (bcache::compare): Rename from bcache_compare.
9144         (bcache_xmalloc): Remove.
9145         (bcache::~bcache): Rename from bcache_xfree.
9146         (bcache::print_statistics): Rename from print_bcache_statistics.
9147         (bcache::memory_used): Rename from bcache_memory_used.
9148
9149 2019-03-07  Pedro Alves  <palves@redhat.com>
9150
9151         * infrun.c (normal_stop): Also check for
9152         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
9153
9154 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
9155
9156         * f-lang.c (value_from_host_double): Moved to...
9157         * value.c (value_from_host_double): ...here.
9158         * value.h (value_from_host_double): Declare.
9159         * guile/scm-math.c (vlscm_convert_typed_number): Use
9160         value_from_host_double.
9161         (vlscm_convert_number): Likewise.
9162         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
9163         * python/py-value.c (convert_value_from_python): Likewise.
9164
9165 2019-03-06  Tom Tromey  <tom@tromey.com>
9166
9167         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
9168
9169 2019-03-06  Tom Tromey  <tom@tromey.com>
9170
9171         * utils.h (free_current_contents): Don't declare.
9172         * utils.c (free_current_contents): Remove.
9173
9174 2019-03-06  Tom Tromey  <tom@tromey.com>
9175
9176         * top.c (quit_force): Update.
9177         * main.c (captured_command_loop): Update.
9178         * common/new-op.c (operator new): Update.
9179         * common/common-exceptions.c (struct catcher)
9180         <save_cleanup_chain>: Remove member.
9181         (exceptions_state_mc_init): Update.
9182         (exception_try_scope_entry): Return nullptr.
9183         (exception_try_scope_exit, exception_rethrow)
9184         (throw_exception_sjlj, throw_exception_cxx): Update.
9185         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
9186         (all_cleanups, do_cleanups, discard_cleanups)
9187         (discard_final_cleanups, save_cleanups, save_final_cleanups)
9188         (restore_cleanups, restore_final_cleanups): Don't declare.
9189         (do_final_cleanups): Remove parameter.
9190         * common/cleanups.c (cleanup_chain, make_cleanup)
9191         (make_cleanup_dtor, all_cleanups, do_cleanups)
9192         (discard_my_cleanups, discard_cleanups)
9193         (discard_final_cleanups, save_my_cleanups, save_cleanups)
9194         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
9195         (null_cleanup): Remove.
9196         (do_final_cleanups): Remove parameter.
9197
9198 2019-03-06  Tom Tromey  <tom@tromey.com>
9199
9200         * remote.c (remote_target::remote_parse_stop_reply): Use
9201         unique_xmalloc_ptr.
9202
9203 2019-03-06  Tom Tromey  <tom@tromey.com>
9204
9205         * stabsread.c (struct stabs_field_info): Rename from field_info.
9206         <list, fnlist>: Add initializers.
9207         <obstack>: New member.
9208         (read_member_functions, read_struct_fields, read_baseclasses):
9209         Allocate on obstack.  Don't use cleanups.
9210         (read_one_struct_field, read_member_functions, read_struct_fields)
9211         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
9212         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
9213         (read_struct_type): Update.
9214
9215 2019-03-06  Tom Tromey  <tom@tromey.com>
9216
9217         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
9218         * common/filestuff.h (make_cleanup_close): Don't declare.
9219         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
9220         Remove.
9221
9222 2019-03-06  Tom Tromey  <tom@tromey.com>
9223
9224         * solib-aix.c: Use make_scope_exit.
9225
9226 2019-03-06  Tom Tromey  <tom@tromey.com>
9227
9228         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
9229         Use make_scope_exit.
9230
9231 2019-03-06  Tom Tromey  <tom@tromey.com>
9232
9233         * solib-svr4.c (disable_probes_interface): Remove parameter.
9234         (svr4_handle_solib_event): Use make_scope_exit.
9235
9236 2019-03-06  Tom Tromey  <tom@tromey.com>
9237
9238         * remote.c (struct stop_reply_deleter): Remove.
9239         (stop_reply_up): Update.
9240         (struct stop_reply): Derive from notif_event.  Don't typedef.
9241         <regcache>: Now a std::vector.
9242         (stop_reply_xfree): Remove.
9243         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
9244         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
9245         (remote_target::discard_pending_stop_replies): Use delete.
9246         (remote_target::remote_parse_stop_reply): Update.
9247         (remote_target::process_stop_reply): Update.
9248         * remote-notif.h (struct notif_event): Add virtual destructor.
9249         Remove "dtr" member.
9250         (struct notif_client) <alloc_event>: Return a unique_ptr.
9251         (notif_event_xfree): Don't declare.
9252         (notif_event_up): New typedef.
9253         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
9254         (notif_event_xfree, do_notif_event_xfree): Remove.
9255         (remote_notif_state_xfree): Update.
9256
9257 2019-03-06  Tom Tromey  <tom@tromey.com>
9258
9259         * infrun.c (displaced_step_clear_cleanup): Now a
9260         forward_scope_exit type.
9261         (displaced_step_prepare_throw): Update.
9262         (displaced_step_fixup): Update.
9263
9264 2019-03-06  Tom Tromey  <tom@tromey.com>
9265
9266         * inferior.h (class inferior): Update comment.
9267         * gdbthread.h (class thread_info): Update comment.
9268
9269 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
9270             Tom Tromey  <tom@tromey.com>
9271
9272         * stabsread.h (struct stab_section_list): Remove.
9273         (coffstab_build_psymtabs): Update.
9274         * dbxread.c (symbuf_sections): Now a std::vector.
9275         (sect_idx): New global.
9276         (fill_symbuf): Update.
9277         (coffstab_build_psymtabs): Change type of stabsects parameter.
9278         Update.
9279         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
9280         std::vector.
9281         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
9282         (coff_locate_sections): Update.
9283         (coff_symfile_read): Remove cleanups.  Update.
9284         (init_stringtab): Add storage parameter.
9285         (free_stringtab, free_stringtab_cleanup): Remove.
9286         (init_lineno): Add storage parameter.
9287         (free_linetab, free_linetab_cleanup): Remove.
9288
9289 2019-03-06  Pedro Alves  <palves@redhat.com>
9290
9291         * linux-fork.c (fork_info::clobber_regs): Delete.
9292         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
9293         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
9294         comment.  Adjust.
9295         (scoped_switch_fork_info::scoped_switch_fork_info)
9296         (checkpoint_command, linux_fork_context): Adjust
9297         fork_save_infrun_state calls.
9298
9299 2019-03-06  Pedro Alves  <palves@redhat.com>
9300
9301         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
9302         (inf_has_multiple_threads): Return 'bool' and rewrite using
9303         inferior_info::threads().
9304
9305 2019-03-06  Pedro Alves  <palves@redhat.com>
9306
9307         * linux-fork.c: Include <list>.
9308         (fork_list): Now a std::list instance.
9309         (fork_info): Add ctor, dtor, and in-class initialize all fields.
9310         (forks_exist_p, find_last_fork): Adjust.
9311         (new_fork): Delete.
9312         (one_fork_p): New.
9313         (add_fork): Adjust.
9314         (free_fork): Delete, folded into fork_info::~fork_info().
9315         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
9316         Adjust.
9317         (init_fork_list): Delete.
9318         (linux_fork_killall, linux_fork_mourn_inferior)
9319         (linux_fork_detach, info_checkpoints_command): Adjust.
9320         (_initialize_linux_fork): No longer call init_fork_list.
9321
9322 2019-03-06  Pedro Alves  <palves@redhat.com>
9323
9324         * linux-fork.c (new_fork): New, split out of ...
9325         (add_fork): ... this.  Return void.  Move "first fork" special
9326         case from here, to ...
9327         (checkpoint_command): ... here.
9328         * linux-linux.h (add_fork): Return void.
9329
9330 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9331
9332         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
9333
9334 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9335             Chris January  <chris.january@arm.com>
9336             David Lecomber  <david.lecomber@arm.com>
9337
9338         * f-exp.y: New token, UNOP_INTRINSIC.
9339         (exp): New pattern using UNOP_INTRINSIC token.
9340         (f77_keywords): Add 'abs' keyword.
9341         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
9342         (value_from_host_double): New function.
9343         (evaluate_subexp_f): Support UNOP_ABS.
9344
9345 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9346
9347         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
9348         types.
9349
9350 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9351
9352         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
9353         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
9354         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
9355
9356 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9357
9358         * f-exp.y (convert_to_kind_type): Handle more type kinds.
9359
9360 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9361             Chris January  <chris.january@arm.com>
9362
9363         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
9364         * f-exp.y: Define 'KIND' token.
9365         (exp): New pattern for KIND expressions.
9366         (ptype): Handle types with a kind extension.
9367         (direct_abs_decl): Extend to spot kind extensions.
9368         (f77_keywords): Add 'kind' to the list.
9369         (push_kind_type): New function.
9370         (convert_to_kind_type): New function.
9371         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
9372         * parse.c (operator_length_standard): Likewise.
9373         * parser-defs.h (enum type_pieces): Add tp_kind.
9374         * std-operator.def: Add UNOP_KIND.
9375
9376 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9377
9378         * f-exp.y (f_parse): Set yydebug.
9379
9380 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9381
9382         * f-lang.c (evaluate_subexp_f): New function.
9383         (exp_descriptor_f): New global.
9384         (f_language_defn): Use exp_descriptor_f instead of
9385         exp_descriptor_standard.
9386
9387 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9388
9389         * f-exp.y (struct token): Add comments.
9390         (dot_ops): Remove uppercase versions and the end marker.
9391         (f77_keywords): Likewise.
9392         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
9393         entries in the dot_ops array are case insensitive, and use
9394         strncasecmp to compare strings.  Also some whitespace cleanup in
9395         this area.  Similar for the f77_keywords array, except entries in
9396         this list might be case sensitive.
9397
9398 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9399
9400         * f-exp.y (struct f77_boolean_val): Add comments.
9401         (boolean_values): Remove uppercase versions, and end marker.
9402         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9403         and use strncasecmp to achieve case insensitivity.  Additionally,
9404         perform whitespace cleanup around this code.
9405
9406 2019-03-06  Tom Tromey  <tromey@adacore.com>
9407
9408         * remote-sim.c (gdbsim_target_open): Use result of
9409         gdb_argv::release.
9410
9411 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
9412         Dirk Schubert  <dirk.schubert@arm.com>
9413         Chris January  <chris.january@arm.com>
9414
9415         * eval.c (evaluate_subexp_standard): Call Fortran argument
9416         wrapping logic.
9417         * f-lang.c (struct value): A value which can be passed into a
9418         Fortran function call.
9419         (fortran_argument_convert): Wrap Fortran arguments in a pointer
9420         where appropriate.
9421         (struct type): Value ready for a Fortran function call.
9422         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9423         is needed.
9424         * f-lang.h (fortran_argument_convert): Declaration.
9425         (fortran_preserve_arg_pointer): Declaration.
9426         * infcall.c (value_arg_coerce): Call Fortran argument logic.
9427
9428 2019-03-05  Tom Tromey  <tromey@adacore.com>
9429
9430         * python/py-prettyprint.c (print_string_repr): Remove #if.
9431         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9432
9433 2019-03-05  Tom Tromey  <tromey@adacore.com>
9434
9435         * target.c (the_dummy_target): Move later.  Change type to
9436         "dummy_target".
9437         (initialize_targets): Don't initialize the_dummy_target.
9438
9439 2019-03-05  Tom Tromey  <tromey@adacore.com>
9440
9441         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9442         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9443
9444 2019-03-05  Tom Tromey  <tromey@adacore.com>
9445
9446         * windows-nat.c (windows_nat_target::attach)
9447         (windows_nat_target::detach): Don't call gdb_flush.
9448         * valprint.c (generic_val_print, val_print, val_print_string):
9449         Don't call gdb_flush.
9450         * utils.c (defaulted_query): Don't call gdb_flush.
9451         * typeprint.c (print_type_scalar): Don't call gdb_flush.
9452         * target.c (target_announce_detach): Don't call gdb_flush.
9453         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9454         * remote.c (extended_remote_target::attach): Don't call
9455         gdb_flush.
9456         * procfs.c (procfs_target::detach): Don't call gdb_flush.
9457         * printcmd.c (do_examine): Don't call gdb_flush.
9458         (info_display_command): Don't call gdb_flush.
9459         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9460         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9461         * memattr.c (info_mem_command): Don't call gdb_flush.
9462         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9463         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9464         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9465         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9466         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9467         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9468         (gnu_nat_target::detach): Don't call gdb_flush.
9469         * f-valprint.c (f_val_print): Don't call gdb_flush.
9470         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9471         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9472         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9473         gdb_flush.
9474         * c-valprint.c (c_val_print): Don't call gdb_flush.
9475         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9476
9477 2019-03-05  Tom Tromey  <tromey@adacore.com>
9478
9479         * varobj.c (update_dynamic_varobj_children): Update.
9480         (install_default_visualizer): Use reset, not release.
9481         * value.c (set_internalvar): Update.
9482         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9483         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9484         ATTRIBUTE_UNUSED_RESULT.
9485
9486 2019-03-05  Tom Tromey  <tromey@adacore.com>
9487
9488         * remote.c (class scoped_remote_fd) <release>: Add
9489         ATTRIBUTE_UNUSED_RESULT.
9490
9491 2019-03-05  Tom Tromey  <tromey@adacore.com>
9492
9493         * macroexp.c (struct macro_buffer) <release>: Add
9494         ATTRIBUTE_UNUSED_RESULT.
9495
9496 2019-03-05  Tom Tromey  <tromey@adacore.com>
9497
9498         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9499         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9500         ATTRIBUTE_UNUSED_RESULT.
9501
9502 2019-03-05  Tom Tromey  <tromey@adacore.com>
9503
9504         * common/scoped_fd.h (class scoped_fd) <release>: Add
9505         ATTRIBUTE_UNUSED_RESULT.
9506
9507 2019-03-05  Tom Tromey  <tromey@adacore.com>
9508
9509         * parser-defs.h (struct parser_state) <release>: Add
9510         ATTRIBUTE_UNUSED_RESULT.
9511
9512 2019-03-05  Tom Tromey  <tromey@adacore.com>
9513
9514         * utils.h (class gdb_argv) <release>: Add
9515         ATTRIBUTE_UNUSED_RESULT.
9516         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9517
9518 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
9519
9520         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9521         for-loop range, to avoid compiler warnings.
9522
9523         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9524         avoid compiler warnings about unused variables.
9525
9526         * NEWS: Mention end of support for native debugging on MS-Windows
9527         before XP.
9528
9529         PR gdb/24292
9530         * common/netstuff.c:
9531         * gdbserver/gdbreplay.c
9532         * gdbserver/remote-utils.c:
9533         * ser-tcp.c:
9534         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9535         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
9536         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9537         'getaddrinfo' and 'freeaddrinfo' were not available before
9538         Windows XP, and mingw.org's MinGW headers by default define
9539         _WIN32_WINNT to 0x500.
9540
9541 2019-03-01  Gary Benson <gbenson@redhat.com>
9542
9543         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9544
9545 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
9546             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
9547
9548         PR gdb/8527
9549         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9550         set_sigint_trap, clear_sigint_trap.
9551
9552 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9553
9554         * target.c (target_detach): Clear the regcache and the
9555         frame cache.
9556
9557 2019-02-27  Pedro Alves  <palves@redhat.com>
9558
9559         * utils.c (set_screen_size): When we cap the height/width sizes,
9560         tweak the corresponding command variable to show "unlimited":
9561
9562 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
9563             Pedro Alves  <palves@redhat.com>
9564
9565         * utils.c (set_screen_size): Reduce "infinite" rows and columns
9566         before calling rl_set_screen_size.
9567
9568 2019-02-27  Tom Tromey  <tromey@adacore.com>
9569
9570         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9571         define.
9572         * python/py-value.c: Remove Python 2.4 workaround.
9573         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9574         workaround.
9575         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9576         Python 2.4 workaround.
9577         * python/python-internal.h: Remove Python 2.4 comment.
9578         (Py_ssize_t): Don't define.
9579         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9580         (gdb_Py_DECREF): Remove Python 2.4 workaround.
9581         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9582         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9583         * python/python.c (do_start_initialization): Remove Python 2.4
9584         workaround.
9585         * python/py-prettyprint.c (class dummy_python_frame): Remove.
9586         (print_children): Remove Python 2.4 workaround.
9587         * python/py-inferior.c (buffer_procs): Remove Python 2.4
9588         workaround.
9589         (CHARBUFFERPROC_NAME): Remove.
9590         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9591         Python 2.4 workaround.
9592
9593 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9594
9595         * NEWS: Note minimum Python version.
9596
9597 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9598
9599         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9600         code from these functions.  Remove corresponding ifdefs.  Use
9601         Py_buffer_up instead of explicit calls to PyBuffer_Release.
9602         Remove gotos and target of gotos.
9603         (infpy_search_memory): Likewise.
9604
9605 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9606
9607         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9608         (hppa_gdbarch_init): Don't register deleted functions with
9609         gdbarch.
9610
9611 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9612
9613         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9614         (h8300_unwind_sp): Delete.
9615         (h8300_dummy_id): Delete.
9616         (h8300_gdbarch_init): Don't register deleted functions with
9617         gdbarch.
9618
9619 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9620
9621         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9622         (ft32_unwind_pc): Delete.
9623         (ft32_unwind_sp): Delete.
9624         (ft32_gdbarch_init): Don't register deleted functions with
9625         gdbarch.
9626
9627 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9628
9629         * gdb/frv-tdep.c (frv_dummy_id): Delete.
9630         (frv_unwind_pc): Delete.
9631         (frv_unwind_sp): Delete.
9632         (frv_gdbarch_init): Don't register deleted functions with
9633         gdbarch.
9634
9635 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9636
9637         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9638         (riscv_unwind_pc): Delete.
9639         (riscv_unwind_sp): Delete.
9640         (riscv_gdbarch_init): Don't register deleted functions with
9641         gdbarch.
9642
9643 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9644
9645         * gdb/csky-tdep.c (csky_dummy_id): Delete.
9646         (csky_unwind_pc): Delete.
9647         (csky_unwind_sp): Delete.
9648         (csky_gdbarch_init): Don't register deleted functions with
9649         gdbarch.
9650
9651 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9652
9653         * gdb/cris-tdep.c (cris_dummy_id): Delete.
9654         (cris_unwind_pc): Delete.
9655         (cris_unwind_sp): Delete.
9656         (cris_gdbarch_init): Don't register deleted functions with
9657         gdbarch.
9658
9659 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9660
9661         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9662         (bfin_unwind_pc): Delete.
9663         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9664
9665 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9666
9667         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9668         (arm_unwind_pc): Delete.
9669         (arm_unwind_sp): Delete.
9670         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9671
9672 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9673
9674         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9675         (arc_unwind_pc): Delete.
9676         (arc_unwind_sp): Delete.
9677         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9678
9679 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9680
9681         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9682         (alpha_unwind_pc): Delete.
9683         (alpha_gdbarch_init): Don't register deleted functions with
9684         gdbarch.
9685
9686 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9687
9688         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9689         (aarch64_unwind_pc): Delete.
9690         (aarch64_unwind_sp): Delete.
9691         (aarch64_gdbarch_init): Don't register deleted functions with
9692         gdbarch.
9693
9694 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9695
9696         * gdbtypes.c (type_align): Don't consider static members when
9697         computing structure alignment.
9698
9699 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9700
9701         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9702         return 0 for other types.
9703         * arch-utils.c (default_type_align): Always return 0.
9704         * gdbarch.h: Regenerate.
9705         * gdbarch.sh (type_align): Extend comment.
9706         * gdbtypes.c (type_align): Add additional comments, always call
9707         gdbarch_type_align before applying the default rules.
9708         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9709         generic code will then apply a suitable default.
9710         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9711         types, return 0 for other types.
9712
9713 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9714
9715         * NEWS: Create a new section for the next release branch.
9716         Rename the section of the current branch, now that it has
9717         been cut.
9718
9719 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9720
9721         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9722         * version.in: Bump version to 8.3.50.DATE-git.
9723
9724 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9725
9726         * aix-thread.c (ptid_cmp): Remove unused variable.
9727         (get_signaled_thread): Likewise.
9728         (store_regs_user_thread): Likewise.
9729         (store_regs_kernel_thread): Likewise.
9730         (fetch_regs_kernel_thread): Remove shadowed variable.
9731
9732 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9733
9734         * features/riscv/32bit-cpu.xml: Add register numbers.
9735         * features/riscv/32bit-fpu.c: Regenerate.
9736         * features/riscv/32bit-fpu.xml: Add register numbers.
9737         * features/riscv/64bit-cpu.xml: Add register numbers.
9738         * features/riscv/64bit-fpu.c: Regenerate.
9739         * features/riscv/64bit-fpu.xml: Add register numbers.
9740
9741 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9742
9743         * NEWS: Mention two argument form of gdb.Value constructor.
9744         * python/py-value.c (convert_buffer_and_type_to_value): New
9745         function.
9746         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9747         Add support for handling an optional second argument.  Call
9748         convert_buffer_and_type_to_value as appropriate.
9749         * python/python-internal.h (Py_buffer_deleter): New struct.
9750         (Py_buffer_up): New typedef.
9751
9752 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9753
9754         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9755         instead of releasing ownership.
9756
9757 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9758
9759         * dwarf2read.c (open_and_init_dwp_file): Call
9760         elf_numsections instead of bfd_count_sections to initialize
9761         dwp_file->num_sections.
9762
9763 2019-02-25  Tom Tromey  <tromey@adacore.com>
9764
9765         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9766
9767 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9768
9769         * gcore.in: Add '--readnever' option when invoking GDB.
9770
9771 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9772
9773         * MAINTAINERS: Update my email address.
9774
9775 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9776
9777         * build-id.c (build_id_to_debug_bfd_1): New function.
9778         (build_id_to_debug_bfd): Look for separate debug file in
9779         sysroot.
9780
9781 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9782
9783         * gdbarch.sh: Update the copyright year range that is placed into
9784         generated files.
9785
9786 2019-02-22  Keith Seitz  <keiths@redhat.com>
9787
9788         PR symtab/23853
9789         * linespec.c (create_sals_line_offset): Search for the default
9790         symtab's filename instead of its fullname.
9791
9792 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9793
9794         * NEWS: Update style defaults.
9795
9796 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9797
9798         * main.c (captured_main_1): Disable styling in batch mode.
9799
9800 2019-02-20  Tom Tromey  <tom@tromey.com>
9801
9802         * symtab.c (symtab_symbol_info): Fix typos.
9803
9804 2019-02-20  Tom Tromey  <tromey@adacore.com>
9805
9806         * findcmd.c (_initialize_mem_search): Use upper case for
9807         metasyntactic variables.
9808
9809 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9810
9811         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9812         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9813
9814 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9815
9816         * top.h (source_file_name): Change to std::string.
9817         * top.c (source_file_name): Likewise.
9818         (command_line_input): Adjust.
9819         * cli/cli-script.c (script_from_file): Adjust.
9820
9821 2019-02-19  Tom Tromey  <tromey@adacore.com>
9822
9823         * ravenscar-thread.c
9824         (ravenscar_thread_target::update_thread_list): Don't call
9825         ada_build_task_list.
9826         * ada-lang.h (ada_build_task_list): Don't declare.
9827         * ada-tasks.c (struct ada_tasks_inferior_data)
9828         <task_list_valid_p>: Now bool.
9829         (read_known_tasks, ada_task_list_changed)
9830         (ada_tasks_invalidate_inferior_data): Update.
9831         (read_known_tasks_array): Return bool.
9832         (read_known_tasks_list): Likewise.
9833         (read_known_tasks): Return void.
9834         (ada_build_task_list): Now static.
9835
9836 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9837
9838         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9839         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9840
9841 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9842
9843         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9844         variant for ada_tasks_pspace_data_handle and
9845         ada_tasks_inferior_data_handle.
9846         (ada_tasks_pspace_data_cleanup): New function.
9847         (ada_tasks_inferior_data_cleanup): New function.
9848
9849 2019-02-17  Tom Tromey  <tom@tromey.com>
9850
9851         * macrotab.h (macro_source_fullname): Return a std::string.
9852         * macrotab.c (macro_include, check_for_redefinition)
9853         (macro_undef, macro_lookup_definition, foreach_macro)
9854         (foreach_macro_in_scope): Update.
9855         (macro_source_fullname): Return a std::string.
9856         * macrocmd.c (show_pp_source_pos): Update.
9857
9858 2019-02-17  Tom Tromey  <tom@tromey.com>
9859
9860         * macrocmd.c (show_pp_source_pos): Style the file names.
9861
9862 2019-02-17  Tom Tromey  <tom@tromey.com>
9863
9864         PR tui/24197:
9865         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9866
9867 2019-02-17  Tom Tromey  <tom@tromey.com>
9868
9869         * ada-lang.c (user_select_syms): Use filtered printing.
9870         * utils.c (wrap_style): New global.
9871         (desired_style): Remove.
9872         (emit_style_escape): Add stream parameter.
9873         (set_output_style, reset_terminal_style, prompt_for_continue):
9874         Update.
9875         (flush_wrap_buffer): Only flush gdb_stdout.
9876         (wrap_here): Set wrap_style.
9877         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9878         treat escape sequences as a character.  Change when wrap buffer is
9879         flushed.
9880         (fputs_styled): Do not set the output style when the default is
9881         requested.
9882         * ui-style.h (struct ui_file_style) <is_default>: New method.
9883         * source.c (print_source_lines_base): Emit escape sequences in one
9884         piece.
9885
9886 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9887
9888         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9889         integers and enumeration types.
9890
9891 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9892
9893         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9894         instead of lookup_symbol_in_language
9895         (do_exact_match): New function.
9896         (ada_get_symbol_name_matcher): Return do_exact_match when
9897         doing a verbatim match.
9898
9899 2019-02-15  Tom Tromey  <tromey@adacore.com>
9900
9901         * ravenscar-thread.c (ravenscar_thread_target::resume)
9902         (ravenscar_thread_target::wait): Special case wildcard requests.
9903
9904 2019-02-15  Tom Tromey  <tromey@adacore.com>
9905
9906         * ravenscar-thread.c (base_ptid): Remove.
9907         (struct ravenscar_thread_target) <close>: New method.
9908         <m_base_ptid>: New member.
9909         <update_inferior_ptid, active_task, task_is_currently_active,
9910         runtime_initialized>: Declare methods.
9911         <ravenscar_thread_target>: Add constructor.
9912         (ravenscar_thread_target::task_is_currently_active)
9913         (ravenscar_thread_target::update_inferior_ptid)
9914         (ravenscar_runtime_initialized): Rename.  Now methods.
9915         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9916         (ravenscar_thread_target::update_thread_list): Update.
9917         (ravenscar_thread_target::active_task): Now method.
9918         (ravenscar_thread_target::store_registers)
9919         (ravenscar_thread_target::prepare_to_store)
9920         (ravenscar_thread_target::prepare_to_store)
9921         (ravenscar_thread_target::mourn_inferior): Update.
9922         (ravenscar_inferior_created): Use "new" to create target.
9923         (ravenscar_thread_target::get_ada_task_ptid): Update.
9924         (_initialize_ravenscar): Don't initialize base_ptid.
9925         (ravenscar_ops): Remove global.
9926
9927 2019-02-15  Tom Tromey  <tromey@adacore.com>
9928
9929         * target.h (push_target): Declare new overload.
9930         * target.c (push_target): New overload, taking an rvalue reference.
9931         * remote.c (remote_target::open_1): Use push_target overload.
9932         * corelow.c (core_target_open): Use push_target overload.
9933
9934 2019-02-15  Tom Tromey  <tromey@adacore.com>
9935
9936         * ravenscar-thread.c (is_ravenscar_task)
9937         (ravenscar_task_is_currently_active): Return bool.
9938         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9939         (_initialize_ravenscar): Remove "(void)".
9940         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9941         Return bool.
9942
9943 2019-02-15  Tom Tromey  <tromey@adacore.com>
9944
9945         * ravenscar-thread.c (ravenscar_runtime_initializer)
9946         (has_ravenscar_runtime, get_running_thread_id)
9947         (ravenscar_thread_target::resume): Fix indentation.
9948
9949 2019-02-15  Tom Tromey  <tromey@adacore.com>
9950
9951         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9952         from ravenscar_arch_ops.
9953         (sparc_ravenscar_ops::fetch_registers)
9954         (sparc_ravenscar_ops::store_registers): Now methods.
9955         (sparc_ravenscar_prepare_to_store): Remove.
9956         (sparc_ravenscar_ops): Redefine.
9957         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9958         methods and destructor.  Remove members.
9959         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9960         (ravenscar_thread_target::store_registers)
9961         (ravenscar_thread_target::prepare_to_store): Update.
9962         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9963         Remove.
9964         (struct ppc_ravenscar_powerpc_ops): Derive from
9965         ravenscar_arch_ops.
9966         (ppc_ravenscar_powerpc_ops::fetch_registers)
9967         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9968         (ppc_ravenscar_powerpc_ops): Redefine.
9969         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9970         (ppc_ravenscar_e500_ops::fetch_registers)
9971         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9972         (ppc_ravenscar_e500_ops): Redefine.
9973         * aarch64-ravenscar-thread.c
9974         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9975         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9976         (aarch64_ravenscar_fetch_registers)
9977         (aarch64_ravenscar_store_registers): Now methods.
9978         (aarch64_ravenscar_ops): Redefine.
9979
9980 2019-02-15  Tom Tromey  <tromey@adacore.com>
9981
9982         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9983         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9984         (ravenscar_thread_target::stopped_by_watchpoint)
9985         (ravenscar_thread_target::stopped_data_address)
9986         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9987
9988 2019-02-15  Tom Tromey  <tromey@adacore.com>
9989
9990         * ravenscar-thread.c: Fix some typos.
9991
9992 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9993             Tom Tromey  <tromey@adacore.com>
9994
9995         * ada-lang.c (ada_exception_sal): Change addr_string to a
9996         std::string.
9997         (create_ada_exception_catchpoint): Update.
9998
9999 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10000             Tom Tromey  <tromey@adacore.com>
10001
10002         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
10003         (bp_location_ops): Remove.
10004         (base_breakpoint_allocate_location): Update.
10005         (free_bp_location): Update.
10006         * ada-lang.c (class ada_catchpoint_location)
10007         <ada_catchpoint_location>: Remove ops parameter.
10008         (ada_catchpoint_location_dtor): Remove.
10009         (ada_catchpoint_location_ops): Remove.
10010         (allocate_location_exception): Update.
10011         * breakpoint.h (struct bp_location_ops): Remove.
10012         (class bp_location) <bp_location>: Remove bp_location_ops
10013         parameter.
10014         <~bp_location>: Add destructor.
10015         <ops>: Remove.
10016
10017 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10018             Pedro Alves  <palves@redhat.com>
10019
10020         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
10021         'PATH_MAX'.
10022
10023 2019-02-14  David Michael  <fedora.dm0@gmail.com>
10024             Samuel Thibault  <samuel.thibault@gnu.org>
10025             Thomas Schwinge  <thomas@codesourcery.com>
10026
10027         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
10028         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
10029
10030 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10031
10032         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
10033         (check_empty): Use "const char *".
10034
10035         * gnu-nat.c (gnu_nat_target::detach): Instead of
10036         'detach_inferior (pid)' call
10037         'detach_inferior (find_inferior_pid (pid))'.
10038
10039         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
10040         'nat/fork-inferior.o'.
10041         * gnu-nat.c: #include "nat/fork-inferior.h".
10042
10043         * gnu-nat.c (gnu_nat_target::detach): Instead of
10044         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
10045         * gnu-nat.h: #include "inf-child.h".
10046         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
10047         'i386_gnu_nat_target::fetch_registers'.
10048         (gnu_store_registers): Rename/move to
10049         'i386_gnu_nat_target::store_registers'.
10050
10051         * config/i386/nm-i386gnu.h: Don't "#include" any files.
10052         * gnu-nat.h (mach_thread_info): New function.
10053         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
10054
10055         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
10056
10057 2019-02-14  Frederic Konrad  <konrad@adacore.com>
10058
10059         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
10060
10061 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
10062
10063         * windows-nat.c (windows_add_thread): Add new parameter
10064         "main_thread_p" with default value set to false.  Update
10065         function documentation as well as all callers.
10066         (windows_delete_thread): Likewise.
10067         (fake_create_process): Update call to windows_add_thread.
10068         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
10069         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
10070         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
10071         call to windows_delete_thread.
10072
10073 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
10074
10075         * MAINTAINERS: Add Andrew Burgess as global maintainer.
10076
10077 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10078
10079         * symfile.c (find_separate_debug_file): Use canonical path of
10080         sysroot with child_path instead of gdb_sysroot if it is valid.
10081
10082 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10083
10084         * symfile.c (find_separate_debug_file): Use child_path to
10085         determine if an object file is under a sysroot.
10086
10087 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10088
10089         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
10090         unittests/child-path-selftests.c.
10091         * common/pathstuff.c (child_path): New function.
10092         * common/pathstuff.h (child_path): New prototype.
10093         * unittests/child-path-selftests.c: New file.
10094
10095 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10096
10097         * symfile.c (find_separate_debug_file): Look for separate debug
10098         files in debug directories under the sysroot.
10099
10100 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10101
10102         * symtab.h (struct minimal_symbol data_p): New const method.
10103         (struct minimal_symbol text_p): Likewise.
10104         * symtab.c (output_source_filename): Use file name style
10105         to print file name.
10106         (print_symbol_info): Likewise.
10107         (print_msymbol_info): Use address style to print addresses.
10108         Use function name style to print executable text symbols.
10109         (expand_symtab_containing_pc): Use data_p.
10110         (find_pc_sect_compunit_symtab): Likewise.
10111
10112 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10113
10114         * breakpoint.c (describe_other_breakpoints): Use address style
10115         to print addresses.
10116         (say_where): Likewise.
10117
10118 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10119
10120         * ada-typeprint.c (print_func_type): Print function name
10121         style to print function name.
10122         * c-typeprint.c (c_print_type_1): Likewise.
10123
10124 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
10125
10126         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
10127         for execve.
10128
10129 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10130
10131         * c-exp.y (direct_abs_decl): Use emplace_back to record the
10132         type_stack.
10133
10134 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
10135
10136         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
10137         TYPE_CODE_REF types.
10138
10139 2019-02-08  Jim Wilson  <jimw@sifive.com>
10140
10141         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
10142         (riscv_linux_fregset): New.
10143         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
10144
10145 2019-02-07  Tom Tromey  <tom@tromey.com>
10146
10147         * thread.c (thread_cancel_execution_command): Update.
10148         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
10149         methods.
10150         (struct thread_fsm_ops): Remove.
10151         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
10152         (thread_fsm_should_stop, thread_fsm_return_value)
10153         (thread_fsm_set_finished, thread_fsm_finished_p)
10154         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
10155         Don't declare.
10156         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
10157         * infrun.c (clear_proceed_status_thread)
10158         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
10159         (print_stop_event): Update.
10160         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
10161         Add constructor.
10162         (step_command_fsm_ops): Remove.
10163         (new_step_command_fsm): Remove.
10164         (step_1): Update.
10165         (step_command_fsm::should_stop): Rename from
10166         step_command_fsm_should_stop.
10167         (step_command_fsm::clean_up): Rename from
10168         step_command_fsm_clean_up.
10169         (step_command_fsm::do_async_reply_reason): Rename from
10170         step_command_fsm_async_reply_reason.
10171         (struct until_next_fsm): Inherit from thread_fsm.  Add
10172         constructor.
10173         (until_next_fsm_ops): Remove.
10174         (new_until_next_fsm): Remove.
10175         (until_next_fsm::should_stop): Rename from
10176         until_next_fsm_should_stop.
10177         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
10178         (until_next_fsm::do_async_reply_reason): Rename from
10179         until_next_fsm_async_reply_reason.
10180         (struct finish_command_fsm): Inherit from thread_fsm.  Add
10181         constructor.  Change type of breakpoint.
10182         (finish_command_fsm_ops): Remove.
10183         (new_finish_command_fsm): Remove.
10184         (finish_command_fsm::should_stop): Rename from
10185         finish_command_fsm_should_stop.
10186         (finish_command_fsm::clean_up): Rename from
10187         finish_command_fsm_clean_up.
10188         (finish_command_fsm::return_value): Rename from
10189         finish_command_fsm_return_value.
10190         (finish_command_fsm::do_async_reply_reason): Rename from
10191         finish_command_fsm_async_reply_reason.
10192         (finish_command): Update.
10193         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
10194         Add constructor.
10195         (call_thread_fsm_ops): Remove.
10196         (call_thread_fsm::call_thread_fsm): Rename from
10197         new_call_thread_fsm.
10198         (call_thread_fsm::should_stop): Rename from
10199         call_thread_fsm_should_stop.
10200         (call_thread_fsm::should_notify_stop): Rename from
10201         call_thread_fsm_should_notify_stop.
10202         (run_inferior_call, call_function_by_hand_dummy): Update.
10203         * cli/cli-interp.c (should_print_stop_to_console): Update.
10204         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
10205         Add constructor.  Change type of location_breakpoint,
10206         caller_breakpoint.
10207         (until_break_fsm_ops): Remove.
10208         (new_until_break_fsm): Remove.
10209         (until_break_fsm::should_stop): Rename from
10210         until_break_fsm_should_stop.
10211         (until_break_fsm::clean_up): Rename from
10212         until_break_fsm_clean_up.
10213         (until_break_fsm::do_async_reply_reason): Rename from
10214         until_break_fsm_async_reply_reason.
10215         (until_break_command): Update.
10216         * thread-fsm.c: Remove.
10217         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
10218
10219 2019-02-07  Tom Tromey  <tom@tromey.com>
10220
10221         * yy-remap.h: Add include guard.
10222         * xtensa-tdep.h: Add include guard.
10223         * xcoffread.h: Rename include guard.
10224         * varobj-iter.h: Add include guard.
10225         * tui/tui.h: Rename include guard.
10226         * tui/tui-winsource.h: Rename include guard.
10227         * tui/tui-wingeneral.h: Rename include guard.
10228         * tui/tui-windata.h: Rename include guard.
10229         * tui/tui-win.h: Rename include guard.
10230         * tui/tui-stack.h: Rename include guard.
10231         * tui/tui-source.h: Rename include guard.
10232         * tui/tui-regs.h: Rename include guard.
10233         * tui/tui-out.h: Rename include guard.
10234         * tui/tui-layout.h: Rename include guard.
10235         * tui/tui-io.h: Rename include guard.
10236         * tui/tui-hooks.h: Rename include guard.
10237         * tui/tui-file.h: Rename include guard.
10238         * tui/tui-disasm.h: Rename include guard.
10239         * tui/tui-data.h: Rename include guard.
10240         * tui/tui-command.h: Rename include guard.
10241         * tic6x-tdep.h: Add include guard.
10242         * target/waitstatus.h: Rename include guard.
10243         * target/wait.h: Rename include guard.
10244         * target/target.h: Rename include guard.
10245         * target/resume.h: Rename include guard.
10246         * target-float.h: Rename include guard.
10247         * stabsread.h: Add include guard.
10248         * rs6000-tdep.h: Add include guard.
10249         * riscv-fbsd-tdep.h: Add include guard.
10250         * regformats/regdef.h: Rename include guard.
10251         * record.h: Rename include guard.
10252         * python/python.h: Rename include guard.
10253         * python/python-internal.h: Rename include guard.
10254         * python/py-stopevent.h: Rename include guard.
10255         * python/py-ref.h: Rename include guard.
10256         * python/py-record.h: Rename include guard.
10257         * python/py-record-full.h: Rename include guard.
10258         * python/py-record-btrace.h: Rename include guard.
10259         * python/py-instruction.h: Rename include guard.
10260         * python/py-events.h: Rename include guard.
10261         * python/py-event.h: Rename include guard.
10262         * procfs.h: Add include guard.
10263         * proc-utils.h: Add include guard.
10264         * p-lang.h: Add include guard.
10265         * or1k-tdep.h: Rename include guard.
10266         * observable.h: Rename include guard.
10267         * nto-tdep.h: Rename include guard.
10268         * nat/x86-linux.h: Rename include guard.
10269         * nat/x86-linux-dregs.h: Rename include guard.
10270         * nat/x86-gcc-cpuid.h: Add include guard.
10271         * nat/x86-dregs.h: Rename include guard.
10272         * nat/x86-cpuid.h: Rename include guard.
10273         * nat/ppc-linux.h: Rename include guard.
10274         * nat/mips-linux-watch.h: Rename include guard.
10275         * nat/linux-waitpid.h: Rename include guard.
10276         * nat/linux-ptrace.h: Rename include guard.
10277         * nat/linux-procfs.h: Rename include guard.
10278         * nat/linux-osdata.h: Rename include guard.
10279         * nat/linux-nat.h: Rename include guard.
10280         * nat/linux-namespaces.h: Rename include guard.
10281         * nat/linux-btrace.h: Rename include guard.
10282         * nat/glibc_thread_db.h: Rename include guard.
10283         * nat/gdb_thread_db.h: Rename include guard.
10284         * nat/gdb_ptrace.h: Rename include guard.
10285         * nat/fork-inferior.h: Rename include guard.
10286         * nat/amd64-linux-siginfo.h: Rename include guard.
10287         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
10288         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
10289         * nat/aarch64-linux.h: Rename include guard.
10290         * nat/aarch64-linux-hw-point.h: Rename include guard.
10291         * mn10300-tdep.h: Add include guard.
10292         * mips-linux-tdep.h: Add include guard.
10293         * mi/mi-parse.h: Rename include guard.
10294         * mi/mi-out.h: Rename include guard.
10295         * mi/mi-main.h: Rename include guard.
10296         * mi/mi-interp.h: Rename include guard.
10297         * mi/mi-getopt.h: Rename include guard.
10298         * mi/mi-console.h: Rename include guard.
10299         * mi/mi-common.h: Rename include guard.
10300         * mi/mi-cmds.h: Rename include guard.
10301         * mi/mi-cmd-break.h: Rename include guard.
10302         * m2-lang.h: Add include guard.
10303         * location.h: Rename include guard.
10304         * linux-record.h: Rename include guard.
10305         * linux-nat.h: Add include guard.
10306         * linux-fork.h: Add include guard.
10307         * i386-darwin-tdep.h: Rename include guard.
10308         * hppa-linux-offsets.h: Add include guard.
10309         * guile/guile.h: Rename include guard.
10310         * guile/guile-internal.h: Rename include guard.
10311         * gnu-nat.h: Rename include guard.
10312         * gdb-stabs.h: Rename include guard.
10313         * frv-tdep.h: Add include guard.
10314         * f-lang.h: Add include guard.
10315         * event-loop.h: Add include guard.
10316         * darwin-nat.h: Rename include guard.
10317         * cp-abi.h: Rename include guard.
10318         * config/sparc/nm-sol2.h: Rename include guard.
10319         * config/nm-nto.h: Rename include guard.
10320         * config/nm-linux.h: Add include guard.
10321         * config/i386/nm-i386gnu.h: Rename include guard.
10322         * config/djgpp/nl_types.h: Rename include guard.
10323         * config/djgpp/langinfo.h: Rename include guard.
10324         * compile/gcc-cp-plugin.h: Add include guard.
10325         * compile/gcc-c-plugin.h: Add include guard.
10326         * compile/compile.h: Rename include guard.
10327         * compile/compile-object-run.h: Rename include guard.
10328         * compile/compile-object-load.h: Rename include guard.
10329         * compile/compile-internal.h: Rename include guard.
10330         * compile/compile-cplus.h: Rename include guard.
10331         * compile/compile-c.h: Rename include guard.
10332         * common/xml-utils.h: Rename include guard.
10333         * common/x86-xstate.h: Rename include guard.
10334         * common/version.h: Rename include guard.
10335         * common/vec.h: Rename include guard.
10336         * common/tdesc.h: Rename include guard.
10337         * common/selftest.h: Rename include guard.
10338         * common/scoped_restore.h: Rename include guard.
10339         * common/scoped_mmap.h: Rename include guard.
10340         * common/scoped_fd.h: Rename include guard.
10341         * common/safe-iterator.h: Rename include guard.
10342         * common/run-time-clock.h: Rename include guard.
10343         * common/refcounted-object.h: Rename include guard.
10344         * common/queue.h: Rename include guard.
10345         * common/ptid.h: Rename include guard.
10346         * common/print-utils.h: Rename include guard.
10347         * common/preprocessor.h: Rename include guard.
10348         * common/pathstuff.h: Rename include guard.
10349         * common/observable.h: Rename include guard.
10350         * common/netstuff.h: Rename include guard.
10351         * common/job-control.h: Rename include guard.
10352         * common/host-defs.h: Rename include guard.
10353         * common/gdb_wait.h: Rename include guard.
10354         * common/gdb_vecs.h: Rename include guard.
10355         * common/gdb_unlinker.h: Rename include guard.
10356         * common/gdb_unique_ptr.h: Rename include guard.
10357         * common/gdb_tilde_expand.h: Rename include guard.
10358         * common/gdb_sys_time.h: Rename include guard.
10359         * common/gdb_string_view.h: Rename include guard.
10360         * common/gdb_splay_tree.h: Rename include guard.
10361         * common/gdb_setjmp.h: Rename include guard.
10362         * common/gdb_ref_ptr.h: Rename include guard.
10363         * common/gdb_optional.h: Rename include guard.
10364         * common/gdb_locale.h: Rename include guard.
10365         * common/gdb_assert.h: Rename include guard.
10366         * common/filtered-iterator.h: Rename include guard.
10367         * common/filestuff.h: Rename include guard.
10368         * common/fileio.h: Rename include guard.
10369         * common/environ.h: Rename include guard.
10370         * common/common-utils.h: Rename include guard.
10371         * common/common-types.h: Rename include guard.
10372         * common/common-regcache.h: Rename include guard.
10373         * common/common-inferior.h: Rename include guard.
10374         * common/common-gdbthread.h: Rename include guard.
10375         * common/common-exceptions.h: Rename include guard.
10376         * common/common-defs.h: Rename include guard.
10377         * common/common-debug.h: Rename include guard.
10378         * common/cleanups.h: Rename include guard.
10379         * common/buffer.h: Rename include guard.
10380         * common/btrace-common.h: Rename include guard.
10381         * common/break-common.h: Rename include guard.
10382         * cli/cli-utils.h: Rename include guard.
10383         * cli/cli-style.h: Rename include guard.
10384         * cli/cli-setshow.h: Rename include guard.
10385         * cli/cli-script.h: Rename include guard.
10386         * cli/cli-interp.h: Rename include guard.
10387         * cli/cli-decode.h: Rename include guard.
10388         * cli/cli-cmds.h: Rename include guard.
10389         * charset-list.h: Add include guard.
10390         * buildsym-legacy.h: Rename include guard.
10391         * bfin-tdep.h: Add include guard.
10392         * ax.h: Rename include guard.
10393         * arm-linux-tdep.h: Add include guard.
10394         * arm-fbsd-tdep.h: Add include guard.
10395         * arch/xtensa.h: Rename include guard.
10396         * arch/tic6x.h: Add include guard.
10397         * arch/i386.h: Add include guard.
10398         * arch/arm.h: Rename include guard.
10399         * arch/arm-linux.h: Rename include guard.
10400         * arch/arm-get-next-pcs.h: Rename include guard.
10401         * arch/amd64.h: Add include guard.
10402         * arch/aarch64-insn.h: Rename include guard.
10403         * arch-utils.h: Rename include guard.
10404         * annotate.h: Add include guard.
10405         * amd64-darwin-tdep.h: Rename include guard.
10406         * aarch64-linux-tdep.h: Add include guard.
10407         * aarch64-fbsd-tdep.h: Add include guard.
10408         * aarch32-linux-nat.h: Add include guard.
10409
10410 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10411
10412         * macrotab.c (macro_define_internal): New function that
10413         factorizes macro_define_object_internal and macro_define_function
10414         code.
10415         (macro_define_object_internal): Use macro_define_internal.
10416         (macro_define_function): Likewise.
10417
10418 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10419
10420         * macrocmd.c (extract_identifier): Return
10421         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10422         callers.
10423
10424 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
10425
10426         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10427
10428 2019-02-05  Tom Tromey  <tom@tromey.com>
10429
10430         * target.c (target_stack::unpush): Move assertion earlier.
10431
10432 2019-01-30  Tom Tromey  <tom@tromey.com>
10433
10434         PR python/23615:
10435         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10436         (gdbpy_parse_and_eval): Likewise.
10437         * python/python-internal.h (gdbpy_allow_threads): New class.
10438
10439 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
10440
10441         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10442         (aarch64_fbsd_fpregmap): Move earlier.
10443         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10444         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10445         instead of individual calls to trad_frame_set_reg_addr.
10446         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10447         earlier.
10448         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10449         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10450         instead of individual calls to trad_frame_set_reg_addr.
10451
10452 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
10453
10454         * CONTRIBUTE: Replace contribution list with wiki link.
10455
10456 2019-01-25  Tom Tromey  <tom@tromey.com>
10457
10458         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10459
10460 2019-01-25  Tom Tromey  <tom@tromey.com>
10461
10462         * xtensa-linux-nat.c: Fix common/ includes.
10463         * xml-support.h: Fix common/ includes.
10464         * xml-support.c: Fix common/ includes.
10465         * x86-linux-nat.c: Fix common/ includes.
10466         * windows-nat.c: Fix common/ includes.
10467         * varobj.h: Fix common/ includes.
10468         * varobj.c: Fix common/ includes.
10469         * value.c: Fix common/ includes.
10470         * valops.c: Fix common/ includes.
10471         * utils.c: Fix common/ includes.
10472         * unittests/xml-utils-selftests.c: Fix common/ includes.
10473         * unittests/utils-selftests.c: Fix common/ includes.
10474         * unittests/unpack-selftests.c: Fix common/ includes.
10475         * unittests/tracepoint-selftests.c: Fix common/ includes.
10476         * unittests/style-selftests.c: Fix common/ includes.
10477         * unittests/string_view-selftests.c: Fix common/ includes.
10478         * unittests/scoped_restore-selftests.c: Fix common/ includes.
10479         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10480         * unittests/scoped_fd-selftests.c: Fix common/ includes.
10481         * unittests/rsp-low-selftests.c: Fix common/ includes.
10482         * unittests/parse-connection-spec-selftests.c: Fix common/
10483         includes.
10484         * unittests/optional-selftests.c: Fix common/ includes.
10485         * unittests/offset-type-selftests.c: Fix common/ includes.
10486         * unittests/observable-selftests.c: Fix common/ includes.
10487         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10488         * unittests/memrange-selftests.c: Fix common/ includes.
10489         * unittests/memory-map-selftests.c: Fix common/ includes.
10490         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10491         * unittests/function-view-selftests.c: Fix common/ includes.
10492         * unittests/environ-selftests.c: Fix common/ includes.
10493         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10494         * unittests/common-utils-selftests.c: Fix common/ includes.
10495         * unittests/cli-utils-selftests.c: Fix common/ includes.
10496         * unittests/array-view-selftests.c: Fix common/ includes.
10497         * ui-file.c: Fix common/ includes.
10498         * tui/tui-io.c: Fix common/ includes.
10499         * tracepoint.h: Fix common/ includes.
10500         * tracepoint.c: Fix common/ includes.
10501         * tracefile-tfile.c: Fix common/ includes.
10502         * top.h: Fix common/ includes.
10503         * top.c: Fix common/ includes.
10504         * thread.c: Fix common/ includes.
10505         * target/waitstatus.h: Fix common/ includes.
10506         * target/waitstatus.c: Fix common/ includes.
10507         * target.h: Fix common/ includes.
10508         * target.c: Fix common/ includes.
10509         * target-memory.c: Fix common/ includes.
10510         * target-descriptions.c: Fix common/ includes.
10511         * symtab.h: Fix common/ includes.
10512         * symfile.c: Fix common/ includes.
10513         * stap-probe.c: Fix common/ includes.
10514         * spu-linux-nat.c: Fix common/ includes.
10515         * sparc-nat.c: Fix common/ includes.
10516         * source.c: Fix common/ includes.
10517         * solib.c: Fix common/ includes.
10518         * solib-target.c: Fix common/ includes.
10519         * ser-unix.c: Fix common/ includes.
10520         * ser-tcp.c: Fix common/ includes.
10521         * ser-pipe.c: Fix common/ includes.
10522         * ser-base.c: Fix common/ includes.
10523         * selftest-arch.c: Fix common/ includes.
10524         * s12z-tdep.c: Fix common/ includes.
10525         * rust-exp.y: Fix common/ includes.
10526         * rs6000-aix-tdep.c: Fix common/ includes.
10527         * riscv-tdep.c: Fix common/ includes.
10528         * remote.c: Fix common/ includes.
10529         * remote-notif.h: Fix common/ includes.
10530         * remote-fileio.h: Fix common/ includes.
10531         * remote-fileio.c: Fix common/ includes.
10532         * regcache.h: Fix common/ includes.
10533         * regcache.c: Fix common/ includes.
10534         * record-btrace.c: Fix common/ includes.
10535         * python/python.c: Fix common/ includes.
10536         * python/py-type.c: Fix common/ includes.
10537         * python/py-inferior.c: Fix common/ includes.
10538         * progspace.h: Fix common/ includes.
10539         * producer.c: Fix common/ includes.
10540         * procfs.c: Fix common/ includes.
10541         * proc-api.c: Fix common/ includes.
10542         * printcmd.c: Fix common/ includes.
10543         * ppc-linux-nat.c: Fix common/ includes.
10544         * parser-defs.h: Fix common/ includes.
10545         * osdata.c: Fix common/ includes.
10546         * obsd-nat.c: Fix common/ includes.
10547         * nat/x86-linux.c: Fix common/ includes.
10548         * nat/x86-linux-dregs.c: Fix common/ includes.
10549         * nat/x86-dregs.h: Fix common/ includes.
10550         * nat/x86-dregs.c: Fix common/ includes.
10551         * nat/ppc-linux.c: Fix common/ includes.
10552         * nat/mips-linux-watch.h: Fix common/ includes.
10553         * nat/mips-linux-watch.c: Fix common/ includes.
10554         * nat/linux-waitpid.c: Fix common/ includes.
10555         * nat/linux-ptrace.h: Fix common/ includes.
10556         * nat/linux-ptrace.c: Fix common/ includes.
10557         * nat/linux-procfs.c: Fix common/ includes.
10558         * nat/linux-personality.c: Fix common/ includes.
10559         * nat/linux-osdata.c: Fix common/ includes.
10560         * nat/linux-namespaces.c: Fix common/ includes.
10561         * nat/linux-btrace.h: Fix common/ includes.
10562         * nat/linux-btrace.c: Fix common/ includes.
10563         * nat/fork-inferior.c: Fix common/ includes.
10564         * nat/amd64-linux-siginfo.c: Fix common/ includes.
10565         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10566         * nat/aarch64-linux.c: Fix common/ includes.
10567         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10568         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10569         * namespace.h: Fix common/ includes.
10570         * mips-linux-tdep.c: Fix common/ includes.
10571         * minsyms.c: Fix common/ includes.
10572         * mi/mi-parse.h: Fix common/ includes.
10573         * mi/mi-main.c: Fix common/ includes.
10574         * mi/mi-cmd-env.c: Fix common/ includes.
10575         * memrange.h: Fix common/ includes.
10576         * memattr.c: Fix common/ includes.
10577         * maint.h: Fix common/ includes.
10578         * maint.c: Fix common/ includes.
10579         * main.c: Fix common/ includes.
10580         * machoread.c: Fix common/ includes.
10581         * location.c: Fix common/ includes.
10582         * linux-thread-db.c: Fix common/ includes.
10583         * linux-nat.c: Fix common/ includes.
10584         * linux-fork.c: Fix common/ includes.
10585         * inline-frame.c: Fix common/ includes.
10586         * infrun.c: Fix common/ includes.
10587         * inflow.c: Fix common/ includes.
10588         * inferior.h: Fix common/ includes.
10589         * inferior.c: Fix common/ includes.
10590         * infcmd.c: Fix common/ includes.
10591         * inf-ptrace.c: Fix common/ includes.
10592         * inf-child.c: Fix common/ includes.
10593         * ia64-linux-nat.c: Fix common/ includes.
10594         * i387-tdep.c: Fix common/ includes.
10595         * i386-tdep.c: Fix common/ includes.
10596         * i386-linux-tdep.c: Fix common/ includes.
10597         * i386-linux-nat.c: Fix common/ includes.
10598         * i386-go32-tdep.c: Fix common/ includes.
10599         * i386-fbsd-tdep.c: Fix common/ includes.
10600         * i386-fbsd-nat.c: Fix common/ includes.
10601         * guile/scm-type.c: Fix common/ includes.
10602         * guile/guile.c: Fix common/ includes.
10603         * go32-nat.c: Fix common/ includes.
10604         * gnu-nat.c: Fix common/ includes.
10605         * gdbthread.h: Fix common/ includes.
10606         * gdbarch-selftests.c: Fix common/ includes.
10607         * gdb_usleep.c: Fix common/ includes.
10608         * gdb_select.h: Fix common/ includes.
10609         * gdb_bfd.c: Fix common/ includes.
10610         * gcore.c: Fix common/ includes.
10611         * fork-child.c: Fix common/ includes.
10612         * findvar.c: Fix common/ includes.
10613         * fbsd-nat.c: Fix common/ includes.
10614         * event-top.c: Fix common/ includes.
10615         * event-loop.c: Fix common/ includes.
10616         * dwarf2read.c: Fix common/ includes.
10617         * dwarf2loc.c: Fix common/ includes.
10618         * dwarf2-frame.c: Fix common/ includes.
10619         * dwarf-index-cache.c: Fix common/ includes.
10620         * dtrace-probe.c: Fix common/ includes.
10621         * disasm-selftests.c: Fix common/ includes.
10622         * defs.h: Fix common/ includes.
10623         * csky-tdep.c: Fix common/ includes.
10624         * cp-valprint.c: Fix common/ includes.
10625         * cp-support.h: Fix common/ includes.
10626         * cp-support.c: Fix common/ includes.
10627         * corelow.c: Fix common/ includes.
10628         * completer.h: Fix common/ includes.
10629         * completer.c: Fix common/ includes.
10630         * compile/compile.c: Fix common/ includes.
10631         * compile/compile-loc2c.c: Fix common/ includes.
10632         * compile/compile-cplus-types.c: Fix common/ includes.
10633         * compile/compile-cplus-symbols.c: Fix common/ includes.
10634         * command.h: Fix common/ includes.
10635         * cli/cli-dump.c: Fix common/ includes.
10636         * cli/cli-cmds.c: Fix common/ includes.
10637         * charset.c: Fix common/ includes.
10638         * build-id.c: Fix common/ includes.
10639         * btrace.h: Fix common/ includes.
10640         * btrace.c: Fix common/ includes.
10641         * breakpoint.h: Fix common/ includes.
10642         * breakpoint.c: Fix common/ includes.
10643         * ax.h:
10644         (enum agent_op): Fix common/ includes.
10645         * ax-general.c (struct aop_map): Fix common/ includes.
10646         * ax-gdb.c: Fix common/ includes.
10647         * auxv.c: Fix common/ includes.
10648         * auto-load.c: Fix common/ includes.
10649         * arm-tdep.c: Fix common/ includes.
10650         * arch/riscv.c: Fix common/ includes.
10651         * arch/ppc-linux-common.c: Fix common/ includes.
10652         * arch/i386.c: Fix common/ includes.
10653         * arch/arm.c: Fix common/ includes.
10654         * arch/arm-linux.c: Fix common/ includes.
10655         * arch/arm-get-next-pcs.c: Fix common/ includes.
10656         * arch/amd64.c: Fix common/ includes.
10657         * arch/aarch64.c: Fix common/ includes.
10658         * arch/aarch64-insn.c: Fix common/ includes.
10659         * arch-utils.c: Fix common/ includes.
10660         * amd64-windows-tdep.c: Fix common/ includes.
10661         * amd64-tdep.c: Fix common/ includes.
10662         * amd64-sol2-tdep.c: Fix common/ includes.
10663         * amd64-obsd-tdep.c: Fix common/ includes.
10664         * amd64-nbsd-tdep.c: Fix common/ includes.
10665         * amd64-linux-tdep.c: Fix common/ includes.
10666         * amd64-linux-nat.c: Fix common/ includes.
10667         * amd64-fbsd-tdep.c: Fix common/ includes.
10668         * amd64-fbsd-nat.c: Fix common/ includes.
10669         * amd64-dicos-tdep.c: Fix common/ includes.
10670         * amd64-darwin-tdep.c: Fix common/ includes.
10671         * agent.c: Fix common/ includes.
10672         * ada-lang.h: Fix common/ includes.
10673         * ada-lang.c: Fix common/ includes.
10674         * aarch64-tdep.c: Fix common/ includes.
10675
10676 2019-01-25  Tom Tromey  <tom@tromey.com>
10677
10678         * common/create-version.sh: Use common/version.h.
10679
10680 2019-01-24  Pedro Alves  <palves@redhat.com>
10681
10682         * infrun.c (signal_stop, signal_print, signal_program)
10683         (signal_catch, signal_pass): Now arrays instead of pointers.
10684         (update_signals_program_target, do_target_resume)
10685         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10686         * linux-nat.c (linux_nat_target::pass_signals)
10687         (linux_nat_target::create_inferior, linux_nat_target::attach):
10688         Adjust.
10689         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10690         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10691         * procfs.c (procfs_target::pass_signals): Adjust.
10692         * record-full.c (record_full_target::resume): Adjust.
10693         * remote.c (remote_target::pass_signals)
10694         (remote_target::program_signals): Adjust.
10695         * target-debug.h (target_debug_print_signals): Now takes a
10696         gdb::array_view as parameter.  Adjust.
10697         * target.h (target_ops) <pass_signals, program_signals>: Replace
10698         pointer and length parameters with gdb::array_view.
10699         (target_pass_signals, target_program_signals): Likewise.
10700         * target-delegates.c: Regenerate.
10701
10702 2019-01-24  Pedro Alves  <palves@redhat.com>
10703
10704         * common/forward-scope-exit.h
10705         (forward_scope_exit::forward_scope_exit): Pass arguments to
10706         m_bind_function directly, instead of creating a std::bind and
10707         copying that.
10708
10709 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10710
10711         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10712         for static members.
10713         (pass_in_v_vfp_candidate): Likewise.
10714
10715 2019-01-23  Tom Tromey  <tom@tromey.com>
10716             Pedro Alves  <palves@redhat.com>
10717
10718         * regcache.c (class regcache_invalidator): Remove.
10719         (regcache::raw_write): Use make_scope_exit.
10720
10721 2019-01-23  Tom Tromey  <tom@tromey.com>
10722
10723         * ui-out.h (class ui_out_emit_type): Update comment.
10724
10725 2019-01-23  Tom Tromey  <tom@tromey.com>
10726
10727         * infrun.c (fetch_inferior_event): Update comment.
10728
10729 2019-01-23  Tom Tromey  <tom@tromey.com>
10730             Pedro Alves  <palves@redhat.com>
10731
10732         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10733         parameter.
10734         (fetch_inferior_event): Use SCOPE_EXIT.
10735
10736
10737 2019-01-23  Tom Tromey  <tom@tromey.com>
10738             Pedro Alves  <palves@redhat.com>
10739
10740         * infrun.c (disable_thread_events): Delete.
10741         (stop_all_threads): Use SCOPE_EXIT.
10742
10743 2019-01-23  Tom Tromey  <tom@tromey.com>
10744             Pedro Alves  <palves@redhat.com>
10745
10746         * symfile.c: Include forward-scope-exit.h.
10747         (clear_symtab_users_cleanup): Replace forward declaration with
10748         a FORWARD_SCOPE_EXIT.
10749         (syms_from_objfile_1): Use the forward_scope_exit and
10750         gdb::optional instead of cleanup_function.
10751         (reread_symbols): Use the forward_scope_exit instead of
10752         cleanup_function.
10753         (clear_symtab_users_cleanup): Remove function.
10754
10755 2019-01-23  Tom Tromey  <tom@tromey.com>
10756             Pedro Alves  <palves@redhat.com>
10757
10758         * linux-nat.c: Include scope-exit.h.
10759         (cleanup_target_stop): Remove.
10760         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10761         SCOPE_EXIT.
10762
10763 2019-01-23  Tom Tromey  <tom@tromey.com>
10764             Pedro Alves  <palves@redhat.com>
10765
10766         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10767         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10768
10769 2019-01-23  Tom Tromey  <tom@tromey.com>
10770             Andrew Burgess  <andrew.burgess@embecosm.com>
10771             Pedro Alves  <palves@redhat.com>
10772
10773         * infrun.c (fetch_inferior_event): Use scope_exit.
10774         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10775         * top.c (execute_command): Use scope_exit.
10776         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10777         * utils.c (do_bpstat_clear_actions_cleanup)
10778         (make_bpstat_clear_actions_cleanup): Remove.
10779
10780 2019-01-23  Tom Tromey  <tom@tromey.com>
10781             Pedro Alves  <palves@redhat.com>
10782
10783         * infrun.c: Include "common/scope-exit.h"
10784         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10785         (wait_for_inferior): Use SCOPE_EXIT.
10786         (fetch_inferior_event): Use scope_exit.
10787
10788 2019-01-23  Tom Tromey  <tom@tromey.com>
10789             Pedro Alves  <palves@redhat.com>
10790
10791         * breakpoint.c (create_breakpoint): Remove cleanup.
10792
10793 2019-01-23  Tom Tromey  <tom@tromey.com>
10794             Andrew Burgess  <andrew.burgess@embecosm.com>
10795             Pedro Alves  <palves@redhat.com>
10796
10797 2019-01-23  Pedro Alves  <palves@redhat.com>
10798
10799         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10800
10801 2019-01-23  Pedro Alves  <palves@redhat.com>
10802             Andrew Burgess  <andrew.burgess@embecosm.com>
10803
10804         * gdbthread.h: Include "common/forward-scope-exit.h".
10805         (scoped_finish_thread_state): Redefine custom class in terms of
10806         forward_scope_exit.
10807
10808 2019-01-23  Pedro Alves  <palves@redhat.com>
10809             Andrew Burgess  <andrew.burgess@embecosm.com>
10810
10811         * common/forward-scope-exit.h: New file.
10812
10813 2019-01-23  Pedro Alves  <palves@redhat.com>
10814             Andrew Burgess  <andrew.burgess@embecosm.com>
10815             Tom Tromey  <tom@tromey.com>
10816
10817         * common/scope-exit.h: New file.
10818
10819 2019-01-23  Pedro Alves  <palves@redhat.com>
10820
10821         * common/preprocessor.h (ESC): Rename to ...
10822         (ESC_PARENS): ... this.
10823         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10824         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10825
10826 2019-01-23  Tom Tromey  <tom@tromey.com>
10827
10828         * language.h (class scoped_switch_to_sym_language_if_auto):
10829         Initialize m_lang in both cases.
10830
10831 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10832
10833         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10834         with XCNEW.
10835
10836 2019-01-22  Tom Tromey  <tom@tromey.com>
10837
10838         * corelow.c: Do not include sys/file.h.
10839
10840 2019-01-22  Tom Tromey  <tom@tromey.com>
10841
10842         * tui/tui-wingeneral.h: Include gdb_curses.h.
10843
10844 2019-01-22  Tom Tromey  <tom@tromey.com>
10845
10846         * source-cache.h (class source_cache) <get_source_lines,
10847         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10848
10849 2019-01-22  Tom Tromey  <tom@tromey.com>
10850
10851         * remote-fileio.h (struct remote_target): Declare.
10852
10853 2019-01-22  Tom Tromey  <tom@tromey.com>
10854
10855         * python/py-arch.c: Do not include py-ref.h.
10856         * python/py-bpevent.c: Do not include py-ref.h.
10857         * python/py-cmd.c: Do not include py-ref.h.
10858         * python/py-continueevent.c: Do not include py-ref.h.
10859         * python/py-event.h: Do not include py-ref.h.
10860         * python/py-evtregistry.c: Do not include py-ref.h.
10861         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10862         * python/py-frame.c: Do not include py-ref.h.
10863         * python/py-framefilter.c: Do not include py-ref.h.
10864         * python/py-function.c: Do not include py-ref.h.
10865         * python/py-infevents.c: Do not include py-ref.h.
10866         * python/py-linetable.c: Do not include py-ref.h.
10867         * python/py-objfile.c: Do not include py-ref.h.
10868         * python/py-param.c: Do not include py-ref.h.
10869         * python/py-prettyprint.c: Do not include py-ref.h.
10870         * python/py-progspace.c: Do not include py-ref.h.
10871         * python/py-symbol.c: Do not include py-ref.h.
10872         * python/py-symtab.c: Do not include py-ref.h.
10873         * python/py-type.c: Do not include py-ref.h.
10874         * python/py-unwind.c: Do not include py-ref.h.
10875         * python/py-utils.c: Do not include py-ref.h.
10876         * python/py-value.c: Do not include py-ref.h.
10877         * python/py-varobj.c: Do not include py-ref.h.
10878         * python/py-xmethods.c: Do not include py-ref.h.
10879         * python/python.c: Do not include py-ref.h.
10880         * varobj.c: Do not include py-ref.h.
10881
10882 2019-01-22  Tom Tromey  <tom@tromey.com>
10883
10884         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10885         keyword for bcache.
10886
10887 2019-01-22  Tom Tromey  <tom@tromey.com>
10888
10889         * compile/compile-cplus-types.c: Remove a comment by #include.
10890
10891 2019-01-22  Tom Tromey  <tom@tromey.com>
10892
10893         * compile/gcc-c-plugin.h: Include compile-internal.h.
10894
10895 2019-01-22  Tom Tromey  <tom@tromey.com>
10896
10897         * stabsread.c (EXTERN): Do not define.
10898         (symnum, next_symbol_text_func, processing_gcc_compilation)
10899         (within_function, global_sym_chain, global_stabs)
10900         (previous_stab_code, this_object_header_files)
10901         (n_this_object_header_files)
10902         (n_allocated_this_object_header_files): Define.
10903         * stabsread.h (EXTERN): Never define.  Use "extern".
10904
10905 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10906
10907         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10908         history_value.
10909
10910 2019-01-21  Tom Tromey  <tom@tromey.com>
10911
10912         * ui-out.c: Fix includes.
10913         * tui/tui-source.c: Fix includes.
10914         * target.c: Fix includes.
10915         * remote.c: Fix includes.
10916         * regcache.c: Fix includes.
10917         * python/py-block.c: Fix includes.
10918         * printcmd.c: Fix includes.
10919         * or1k-tdep.c: Fix includes.
10920         * mi/mi-main.c: Fix includes.
10921         * m32r-tdep.c: Fix includes.
10922         * csky-tdep.c: Fix includes.
10923         * compile/compile-cplus-types.c: Fix includes.
10924         * cli/cli-interp.c: Fix includes.
10925
10926 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10927
10928         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10929         for padding.
10930
10931 2019-01-16  Tom Tromey  <tom@tromey.com>
10932
10933         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10934         earlier.
10935         (struct objfile) <msymbols_range>: Move from top level.
10936         <msymbols>: New method.
10937         (class objfile_msymbols): Remove.
10938         * symtab.c (default_collect_symbol_completion_matches_break_on):
10939         Update.
10940         * symmisc.c (dump_msymbols): Update.
10941         * stabsread.c (scan_file_globals): Update.
10942         * objc-lang.c (info_selectors_command, info_classes_command)
10943         (find_methods): Update.
10944         * minsyms.c (find_solib_trampoline_target): Update.
10945         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10946         * coffread.c (coff_symfile_read): Update.
10947         * ada-lang.c (ada_lookup_simple_minsym)
10948         (ada_collect_symbol_completion_matches): Update.
10949
10950 2019-01-16  Tom Tromey  <tom@tromey.com>
10951
10952         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10953         type.  Remove no-argument constructor.
10954         <iterator::operator++>: Simplify.
10955         <begin>: Update.
10956         <end>: Use minimal_symbol_count.
10957
10958 2019-01-16  Tom Tromey  <tom@tromey.com>
10959
10960         * objfiles.h (struct objfile) <psymtabs>: New method.
10961         (class objfile_psymtabs): Remove.
10962         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10963         typedef.
10964         <range>: New method.
10965         (require_partial_symbols): Change return type.
10966         * psymtab.c (require_partial_symbols)
10967         (psym_expand_symtabs_matching): Update.
10968         * mdebugread.c (parse_partial_symbols): Update.
10969         * dbxread.c (dbx_end_psymtab): Update.
10970
10971 2019-01-15  Tom Tromey  <tom@tromey.com>
10972
10973         * symtab.c (lookup_objfile_from_block)
10974         (lookup_symbol_in_objfile_symtabs)
10975         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10976         (find_line_symtab, info_sources_command)
10977         (default_collect_symbol_completion_matches_break_on)
10978         (make_source_files_completion_list): Update.
10979         * symmisc.c (print_objfile_statistics, dump_objfile)
10980         (maintenance_print_symbols, maintenance_info_symtabs)
10981         (maintenance_check_symtabs, maintenance_info_line_tables):
10982         Update.
10983         * source.c (select_source_symtab)
10984         (forget_cached_source_info_for_objfile): Update.
10985         * objfiles.h (class objfile_compunits): Remove.
10986         (struct objfile) <compunits_range>: New typedef.
10987         (compunits): New method.
10988         * objfiles.c (objfile_relocate1): Update.
10989         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10990         * maint.c (count_symtabs_and_blocks): Update.
10991         * linespec.c (iterate_over_all_matching_symtabs): Update.
10992         * cp-support.c (add_symbol_overload_list_qualified): Update.
10993         * coffread.c (coff_symtab_read): Update.
10994         * ada-lang.c (add_nonlocal_symbols)
10995         (ada_collect_symbol_completion_matches)
10996         (ada_add_global_exceptions): Update.
10997
10998 2019-01-15  Tom Tromey  <tom@tromey.com>
10999
11000         * progspace.h (program_space) <objfiles_safe_range>: New
11001         typedef.
11002         <objfiles_safe>: New method.
11003         * objfiles.h (class all_objfiles_safe): Remove.
11004         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
11005         * jit.c (jit_inferior_exit_hook): Update.
11006
11007 2019-01-17  Tom Tromey  <tom@tromey.com>
11008
11009         * progspace.h (program_space) <objfiles_range>: New typedef.
11010         <objfiles>: New method.
11011         <objfiles_head>: Rename from objfiles.
11012         (object_files): Update.
11013         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
11014         * guile/scm-pretty-print.c
11015         (ppscm_find_pretty_printer_from_objfiles): Update.
11016         * guile/scm-objfile.c (gdbscm_objfiles): Update.
11017         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
11018         Update.
11019         * python/py-progspace.c (pspy_get_objfiles): Update.
11020         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11021         Update.
11022         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11023         (objfpy_lookup_objfile_by_build_id): Update.
11024         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11025         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11026         Update.
11027         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11028         (expand_symtab_containing_pc, lookup_objfile_from_block)
11029         (lookup_static_symbol, basic_lookup_transparent_type)
11030         (find_pc_sect_compunit_symtab, find_symbol_at_address)
11031         (find_line_symtab, info_sources_command)
11032         (default_collect_symbol_completion_matches_break_on)
11033         (make_source_files_completion_list, find_main_name): Update.
11034         * symmisc.c (print_symbol_bcache_statistics)
11035         (print_objfile_statistics, maintenance_print_symbols)
11036         (maintenance_print_msymbols, maintenance_print_objfiles)
11037         (maintenance_info_symtabs, maintenance_check_symtabs)
11038         (maintenance_expand_symtabs, maintenance_info_line_tables):
11039         Update.
11040         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
11041         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
11042         (map_overlay_command, unmap_overlay_command)
11043         (simple_overlay_update, expand_symtabs_matching)
11044         (map_symbol_filenames): Update.
11045         * symfile-debug.c (set_debug_symfile): Update.
11046         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
11047         Update.
11048         * source.c (select_source_symtab, forget_cached_source_info):
11049         Update.
11050         * solib.c (solib_read_symbols): Update.
11051         * solib-spu.c (append_ocl_sos): Update.
11052         * psymtab.c (maintenance_print_psymbols)
11053         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
11054         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
11055         * printcmd.c (info_symbol_command): Update.
11056         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
11057         Update.
11058         * objfiles.h (class all_objfiles): Remove.
11059         * objfiles.c (have_partial_symbols, have_full_symbols)
11060         (have_minimal_symbols, qsort_cmp, update_section_map)
11061         (shared_objfile_contains_address_p)
11062         (default_iterate_over_objfiles_in_search_order): Update.
11063         * objc-lang.c (info_selectors_command, info_classes_command)
11064         (find_methods): Update.
11065         * minsyms.c (find_solib_trampoline_target): Update.
11066         * maint.c (maintenance_info_sections)
11067         (maintenance_translate_address, count_symtabs_and_blocks):
11068         Update.
11069         * main.c (captured_main_1): Update.
11070         * linux-thread-db.c (try_thread_db_load_from_pdir)
11071         (has_libpthread): Update.
11072         * linespec.c (iterate_over_all_matching_symtabs)
11073         (search_minsyms_for_name): Update.
11074         * jit.c (jit_find_objf_with_entry_addr): Update.
11075         * hppa-tdep.c (find_unwind_entry)
11076         (hppa_lookup_stub_minimal_symbol): Update.
11077         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
11078         Update.
11079         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11080         (elf_gnu_ifunc_resolve_by_got): Update.
11081         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
11082         * dwarf-index-write.c (save_gdb_index_command): Update.
11083         * cp-support.c (add_symbol_overload_list_qualified): Update.
11084         * breakpoint.c (create_overlay_event_breakpoint)
11085         (create_longjmp_master_breakpoint)
11086         (create_std_terminate_master_breakpoint)
11087         (create_exception_master_breakpoint): Update.
11088         * blockframe.c (find_pc_partial_function): Update.
11089         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
11090         (ada_collect_symbol_completion_matches)
11091         (ada_add_global_exceptions): Update.
11092
11093 2019-01-17  Tom Tromey  <tom@tromey.com>
11094
11095         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
11096         declare VEC.
11097         (solib_target_parse_libraries): Change return type.
11098         (library_list_start_segment, library_list_start_section)
11099         (library_list_end_library, library_list_start_library); Update.
11100         (solib_target_free_library_list): Remove.
11101         (solib_target_parse_libraries): Remove cleanup.  Change return
11102         type.
11103         (solib_target_current_sos): Update.
11104
11105 2019-01-17  Tom Tromey  <tromey@bapiya>
11106
11107         * valprint.c: Replace "the the" with "the".
11108         * symtab.c: Replace "the the" with "the".
11109         * solib.c: Replace "the the" with "the".
11110         * solib-dsbt.c: Replace "the the" with "the".
11111         * linespec.c: Replace "the the" with "the".
11112         * dwarf2loc.h: Replace "the the" with "the".
11113         * amd64-windows-tdep.c: Replace "the the" with "the".
11114         * aarch64-tdep.c: Replace "the the" with "the".
11115
11116 2019-01-16  Keith Seitz  <keiths@redhat.com>
11117
11118         PR gdb/23773
11119         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
11120         <builder>: Rename to ..
11121         <m_builder>: ... this and make private.
11122         (dwarf2_cu::get_builder): New method.  Change all users of
11123         `builder' to use this method.
11124         (dwarf2_start_symtab): Move to ...
11125         (dwarf2_cu::start_symtab): ... here.  Update all callers
11126         (setup_type_unit_groups): Move to ...
11127         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
11128         callers.
11129         (dwarf2_cu::reset_builder): New method.
11130         (process_full_compunit, process_full_type_unit): Use
11131         dwarf2_cu::reset_builder.
11132         (follow_die_offset): Record the ancestor CU if it is different
11133         from the followed DIE's CU.
11134         (follow_die_sig_1): Likewise.
11135
11136 2019-01-15  Tom Tromey  <tom@tromey.com>
11137
11138         * remote.c (class remote_state) <buf>: Now a char_vector.
11139         <buf_size>: Remove.
11140         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
11141         parameter.
11142         (remote_target::getpkt_or_notif_sane_1)
11143         (remote_target::getpkt_sane)
11144         (remote_target::getpkt_or_notif_sane): Likewise.
11145         (class remote_target) <putpkt>: New overload.
11146         (remote_target::read_frame): Change type of "buf_p".  Remove
11147         sizeof_p parameter.
11148         (packet_ok): New overload.
11149         (packet_check_result): New overload.
11150         Update all uses.
11151
11152 2019-01-14  Tom Tromey  <tom@tromey.com>
11153
11154         * remote-notif.c (handle_notification, remote_notif_ack)
11155         (remote_notif_parse): Make "buf" const.
11156         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
11157         const.
11158         (remote_notif_parse, remote_notif_ack, handle_notification):
11159         Likewise.
11160         * remote.c (remote_notif_stop_parse): Make "buf" const.
11161         (remote_target::remote_parse_stop_reply): Make "buf" const.
11162         (remote_notif_stop_ack): Make "buf" const.
11163
11164 2019-01-14  Tom Tromey  <tom@tromey.com>
11165
11166         * remote.c (remote_console_output): Make parameter const.
11167
11168 2019-01-14  Tom Tromey  <tom@tromey.com>
11169
11170         * target-debug.h (target_debug_print_signals): Constify.
11171         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
11172         * procfs.c (procfs_target::pass_signals): Update.
11173         * linux-nat.c (linux_nat_target::pass_signals): Update.
11174         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
11175         * target-delegates.c: Rebuild.
11176         * remote.c (remote_target::program_signals): Update.
11177         (remote_target::pass_signals): Update.
11178         * target.c (target_pass_signals): Constify argument.
11179         (target_program_signals): Likewise.
11180         * target.h (struct target_ops) <pass_signals, program_signals>:
11181         Constify argument.
11182         (target_pass_signals, target_program_signals): Constify argument.
11183
11184 2019-01-14  Tom Tromey  <tom@tromey.com>
11185
11186         PR tui/28819:
11187         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
11188
11189 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
11190
11191         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
11192         field.
11193         * rs6000-tdep.c: Include reggroups.h.
11194         (IS_V_ALIAS_PSEUDOREG): Define.
11195         (rs6000_register_name): Return names for the "vX" aliases.
11196         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
11197         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
11198         aliases.  Call default_register_reggroup_p for all other
11199         pseudo-registers.
11200         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
11201         New functions.
11202         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
11203         Handle "vX" aliases.
11204         (v_alias_pseudo_register_collect): New function.
11205         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
11206         (rs6000_gdbarch_init): Initialize "vX" aliases as
11207         pseudo-registers.  Restore registration of
11208         rs6000_pseudo_register_reggroup_p with
11209         set_tdesc_pseudo_register_reggroup_p.
11210
11211 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
11212
11213         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
11214         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
11215         set_gdbarch_num_pseudo_regs.
11216
11217 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11218
11219         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
11220         Remove arg prefixname, add do_set and do_show.
11221         Add member functions set_list and show_list.
11222         * cli/cli-style.c (class cli_style_option): Update accordingly.
11223         (style_set_list): Move to file scope.
11224         (style_show_list): Likewise.
11225         (set_style): Call help_list.
11226         (show_style): Call cmd_show_list.
11227         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
11228         Update to use the new macro.
11229
11230 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
11231
11232         * ada-lang.c (_initialize_ada_language): Expand the help text
11233         for the "catch exception" command.
11234
11235 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11236
11237         * symtab.c (matching_obj_sections): Initialize obj,
11238         declare it closer to its usage.
11239
11240 2019-01-10  Tom Tromey  <tom@tromey.com>
11241
11242         * thread-iter.h (inf_threads_iterator): Use next_iterator.
11243         (basic_inf_threads_range): Remove.
11244         (inf_threads_range, inf_non_exited_threads_range)
11245         (safe_inf_threads_range): Use next_adapter.
11246
11247 2019-01-10  Keith Seitz  <keiths@redhat.com>
11248
11249         PR gdb/23712
11250         PR symtab/23010
11251         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
11252         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
11253
11254 2019-01-10  Keith Seitz  <keiths@redhat.com>
11255
11256         PR gdb/23712
11257         PR symtab/23010
11258         * dictionary.c (pending_to_vector): Remove.
11259         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11260         Remove _1 suffix, replacing functions of the same name.  Update
11261         all callers.
11262         (dict_create_hashed, dict_create_hashed_expandable)
11263         (dict_create_linear, dict_create_linear_expandable, dict_free)
11264         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
11265         Make functions static.
11266
11267 2019-01-10  Keith Seitz  <keiths@redhat.com>
11268
11269         PR gdb/23712
11270         PR symtab/23010
11271         * dictionary.h (struct dictionary): Replace declaration with
11272         multidictionary.
11273         (dict_create_hashed, dict_create_hashed_expandable)
11274         (dict_create_linear, dict_create_linear_expandable)
11275         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
11276         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
11277         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
11278         taking multidictionary argument.
11279         [ALL_DICT_SYMBOLS]: Update for multidictionary.
11280         * block.h (struct block) <dict>: Change to multidictionary
11281         and rename `multidict'.
11282         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
11283         symmisc.c: Update all dictionary references to multidictionary.
11284
11285 2019-01-10  Keith Seitz  <keiths@redhat.com>
11286
11287         PR gdb/23712
11288         PR symtab/23010
11289         * dictionary.c: Include unordered_map.
11290         (pending_to_vector): New function.
11291         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11292         Rewrite the non-"_1" functions to take vector instead
11293         of linked list.
11294         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
11295         "new" _1 versions of the same name.
11296         (multidictionary): Define.
11297         (std::hash<enum language): New definition.
11298         (collate_pending_symbols_by_language, mdict_create_hashed)
11299         (mdict_create_hashed_expandable, mdict_create_linear)
11300         (mdict_create_linear_expandable, mdict_free)
11301         (find_language_dictionary, create_new_language_dictionary)
11302         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
11303         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
11304         (mdict_size, mdict_empty): New functions.
11305         * dictionary.h (mdict_iterator): Define.
11306
11307 2019-01-10  Pedro Alves  <palves@redhat.com>
11308
11309         * breakpoint.c (read_uploaded_action)
11310         (create_tracepoint_from_upload): Adjust to use
11311         gdb::unique_xmalloc_ptr.
11312         * ctf.c (ctf_write_uploaded_tp):
11313         (SET_ARRAY_FIELD): Use emplace_back.
11314         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
11315         * tracefile-tfile.c (tfile_write_uploaded_tp):
11316         * tracepoint.c (parse_tracepoint_definition): Adjust to use
11317         gdb::unique_xmalloc_ptr.
11318         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
11319         at_string, cond_string, cmd_strings>: Replace char pointers
11320         with gdb::unique_xmalloc_ptr.
11321
11322 2019-01-10  Pedro Alves  <palves@redhat.com>
11323
11324         * solib-target.c (library_list_start_library): Don't xstrdup name.
11325
11326 2019-01-10  Pedro Alves  <palves@redhat.com>
11327
11328         * mdebugread.c (parse_partial_symbols): Use
11329         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
11330
11331 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11332
11333         * linux-fork.c (scoped_switch_fork_info)
11334         <~scoped_switch_fork_info>: Fix incorrect variable name.
11335
11336 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11337
11338         * linux-fork.c (scoped_switch_fork_info)
11339         <scoped_switch_fork_info>: Make explicit.
11340         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
11341
11342 2019-01-10  Tom Tromey  <tom@tromey.com>
11343
11344         * objfiles.h (objfile::reset_psymtabs): Update.
11345         * objfiles.c (objfile::objfile): Update.
11346         * psymtab.h (psymtab_storage::obstack): Update.
11347         (psymtab_storage::m_obstack): Use gdb::optional.
11348         (class psymtab_storage): Update comment.  Remove objfile
11349         parameter.
11350         * psymtab.c (psymtab_storage::psymtab_storage): Update.
11351
11352 2019-01-10  Tom Tromey  <tom@tromey.com>
11353
11354         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
11355         <free_psymtabs>: Now private.
11356         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
11357         (allocate_psymtab): Use new method.
11358
11359 2019-01-10  Tom Tromey  <tom@tromey.com>
11360
11361         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
11362         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
11363         * mdebugread.c (parse_partial_symbols): Use
11364         allocate_dependencies.
11365         * dwarf2read.c (dwarf2_create_include_psymtab): Use
11366         allocate_dependencies.
11367         (process_psymtab_comp_unit_reader)
11368         (build_type_psymtab_dependencies): Likewise.
11369         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
11370
11371 2019-01-10  Tom Tromey  <tom@tromey.com>
11372
11373         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
11374         PSYMBOL_SET_LANGUAGE.
11375         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
11376
11377 2019-01-10  Tom Tromey  <tom@tromey.com>
11378
11379         * psymtab.h (psymtab_storage::obstack): New method.
11380         <m_obstack>: Rename from obstack; now private.
11381         * psymtab.c (psymtab_storage): Update.
11382         * dwarf2read.c (create_addrmap_from_index)
11383         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
11384         Update.
11385
11386 2019-01-10  Tom Tromey  <tom@tromey.com>
11387
11388         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
11389         * objfiles.h (objfile::reset_psymtabs): New method.
11390
11391 2019-01-10  Tom Tromey  <tom@tromey.com>
11392
11393         * symmisc.c (print_symbol_bcache_statistics): Update.
11394         (print_objfile_statistics): Update.
11395         * symfile.c (reread_symbols): Update.
11396         * psymtab.h (class psymtab_storage): New.
11397         * psymtab.c (psymtab_storage): New constructor.
11398         (~psymtab_storage): New destructor.
11399         (require_partial_symbols): Update.
11400         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11401         (find_pc_sect_psymtab, find_pc_sect_psymbol)
11402         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11403         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11404         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
11405         (start_psymtab_common, end_psymtab_common)
11406         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
11407         (allocate_psymtab): Update.
11408         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
11409         Update.
11410         (dump_psymtab_addrmap, maintenance_print_psymbols)
11411         (maintenance_check_psymtabs): Update.
11412         (class objfile_psymtabs): Move to objfiles.h.
11413         * psympriv.h (discard_psymtab): Now inline.
11414         (psymtab_discarder::psymtab_discarder): Update.
11415         (psymtab_discarder::~psymtab_discarder): Update.
11416         (ALL_OBJFILE_PSYMTABS): Rewrite.
11417         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11418         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11419         Remove fields.
11420         <partial_symtabs>: New field.
11421         (class objfile_psymtabs): Move from psymtab.h.  Update.
11422         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11423         psymbol_cache.
11424         (objfile::~objfile): Don't destroy psymbol_cache.
11425         * mdebugread.c (parse_partial_symbols): Update.
11426         * dwarf2read.c (create_addrmap_from_index)
11427         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11428         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11429         (add_partial_subprogram, dwarf2_ranges_read): Update.
11430         * dwarf-index-write.c (write_address_map)
11431         (write_one_signatured_type, recursively_write_psymbols)
11432         (class debug_names, class debug_names, write_psymtabs_to_index):
11433         Update.
11434
11435 2019-01-10  Tom Tromey  <tom@tromey.com>
11436
11437         * symtab.h (SYMBOL_SET_NAMES): Update.
11438         (symbol_set_names): Update.
11439         (MSYMBOL_SET_NAMES): Update.
11440         * symtab.c (symbol_set_names): Change argument to be an
11441         objfile_per_bfd_storage.
11442         * psymtab.c (add_psymbol_to_bcache): Update.
11443         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11444
11445 2019-01-10  Tom Tromey  <tom@tromey.com>
11446
11447         * symtab.c (create_demangled_names_hash): Change argument to be an
11448         objfile_per_bfd_storage.
11449         (symbol_set_names): Update.
11450
11451 2019-01-10  Tom Tromey  <tom@tromey.com>
11452
11453         * xcoffread.c (xcoff_initial_scan): Unconditionally call
11454         init_psymbol_list.
11455         * psymtab.c (init_psymbol_list): Do nothing if already called.
11456         * psympriv.h (init_psymbol_list): Add comment.
11457         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11458         init_psymbol_list.
11459         * dbxread.c (dbx_symfile_read): Unconditionally call
11460         init_psymbol_list.
11461
11462 2019-01-10  Tom Tromey  <tom@tromey.com>
11463
11464         * xcoffread.c (scan_xcoff_symtab): Update.
11465         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11466         "where".
11467         * mdebugread.c (parse_partial_symbols)
11468         (handle_psymbol_enumerators): Update.
11469         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11470         * dbxread.c (read_dbx_symtab): Update.
11471         * psympriv.h (psymbol_placement): New enum.
11472         (add_psymbol_to_list): Update.
11473
11474 2019-01-10  Tom Tromey  <tom@tromey.com>
11475
11476         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11477         static_psymbols parameters.
11478         (scan_xcoff_symtab): Update.
11479         * psymtab.c (start_psymtab_common): Remove global_psymbols and
11480         static_psymbols parameters.
11481         * psympriv.h (start_psymtab_common): Update.
11482         * mdebugread.c (parse_partial_symbols): Update.
11483         * dwarf2read.c (create_partial_symtab): Update.
11484         * dbxread.c (read_dbx_symtab): Update.
11485         (start_psymtab): Remove global_psymbols and static_psymbols
11486         parameters.
11487
11488 2019-01-10  Tom Tromey  <tom@tromey.com>
11489
11490         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11491         * psymtab.c (allocate_psymtab): Add comment.
11492         * psympriv.h (allocate_psymtab): Add comment.
11493         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11494         initializations.
11495         * dbxread.c (dbx_end_psymtab): Remove some initializations.
11496
11497 2019-01-10  Tom Tromey  <tom@tromey.com>
11498
11499         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11500         Don't declare.
11501         * mipsread.c: Include mdebugread.h.
11502         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11503         Declare.
11504         * elfread.c: Include mdebugread.h.
11505
11506 2019-01-09  Tom Tromey  <tom@tromey.com>
11507
11508         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11509         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11510         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11511         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11512         (psym_lookup_symbol, psym_find_last_source_symtab)
11513         (psym_forget_cached_source_info, psym_print_stats)
11514         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11515         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11516         (psym_map_matching_symbols, psym_expand_symtabs_matching)
11517         (psym_find_compunit_symtab_by_address)
11518         (maintenance_print_psymbols, maintenance_info_psymtabs)
11519         (maintenance_check_psymtabs): Use ranged for.
11520         * psymtab.h (class objfile_psymtabs): New.
11521         (require_partial_symbols): Return objfile_psymtabs.
11522         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11523
11524 2019-01-09  Tom Tromey  <tom@tromey.com>
11525
11526         * symfile.c (overlay_invalidate_all, find_pc_overlay)
11527         (find_pc_mapped_section, list_overlays_command)
11528         (map_overlay_command, unmap_overlay_command)
11529         (simple_overlay_update): Use all_objfiles.
11530         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11531         * printcmd.c (info_symbol_command): Use all_objfiles.
11532         * objfiles.h (ALL_OBJSECTIONS): Remove.
11533         * maint.c (maintenance_translate_address): Use all_objfiles.
11534         * gcore.c (gcore_create_callback): Use all_objfiles.
11535         (objfile_find_memory_regions): Likewise.
11536
11537 2019-01-09  Tom Tromey  <tom@tromey.com>
11538
11539         * symtab.c (find_line_symtab, info_sources_command)
11540         (make_source_files_completion_list): Use objfile_compunits.
11541         * source.c (select_source_symtab): Use objfile_compunits.
11542         * objfiles.h (struct objfile): Update comment.
11543         (ALL_OBJFILES): Remove.
11544         (ALL_FILETABS): Remove.
11545         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11546         objfile_compunits.
11547
11548 2019-01-09  Tom Tromey  <tom@tromey.com>
11549
11550         * symmisc.c (print_objfile_statistics, dump_objfile)
11551         (maintenance_print_symbols): Use compunit_filetabs.
11552         * source.c (forget_cached_source_info_for_objfile): Use
11553         compunit_filetabs.
11554         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11555         (ALL_FILETABS): Use compunit_filetabs.
11556         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11557         * coffread.c (coff_symtab_read): Use compunit_filetabs.
11558
11559 2019-01-09  Tom Tromey  <tom@tromey.com>
11560
11561         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11562         (compunit_filetabs): New.
11563         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11564         compunit_filetabs.
11565         (info_sources_command, make_source_files_completion_list): Remove
11566         declaration.
11567         * symmisc.c (print_objfile_statistics, dump_objfile)
11568         (maintenance_print_symbols): Remove declaration.
11569         (maintenance_info_symtabs): Use compunit_filetabs.
11570         (maintenance_info_line_tables): Likewise.
11571         * source.c (select_source_symtab): Change local variable name.
11572         (forget_cached_source_info_for_objfile): Remove declaration.
11573         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11574         * objfiles.c (objfile_relocate1): Remove declaration.
11575         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11576         declaration.
11577         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11578         * coffread.c (coff_symtab_read): Remove declaration.
11579         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11580         compunit_filetabs.
11581
11582 2019-01-09  Tom Tromey  <tom@tromey.com>
11583
11584         * symtab.c (lookup_objfile_from_block)
11585         (find_pc_sect_compunit_symtab, search_symbols)
11586         (default_collect_symbol_completion_matches_break_on): Use
11587         objfile_compunits.
11588         * objfiles.h (ALL_COMPUNITS): Remove.
11589         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11590         * cp-support.c (add_symbol_overload_list_qualified): Use
11591         objfile_compunits.
11592         * ada-lang.c (ada_collect_symbol_completion_matches)
11593         (ada_add_global_exceptions): Use objfile_compunits.
11594
11595 2019-01-09  Tom Tromey  <tom@tromey.com>
11596
11597         * source.c (select_source_symtab)
11598         (forget_cached_source_info_for_objfile): Remove declaration.
11599         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11600         declaration.
11601         * maint.c (count_symtabs_and_blocks): Remove declaration.
11602         * cp-support.c (add_symbol_overload_list_qualified): Remove
11603         declaration.
11604         * coffread.c (coff_symtab_read): Remove declaration.
11605         * symtab.c (lookup_symbol_in_objfile_symtabs)
11606         (basic_lookup_transparent_type_1): Use objfile_compunits.
11607         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11608         (info_sources_command, search_symbols)
11609         (default_collect_symbol_completion_matches_break_on)
11610         (make_source_files_completion_list): Remove declaration.
11611         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11612         (ada_collect_symbol_completion_matches)
11613         (ada_add_global_exceptions): Remove declaration.
11614         * linespec.c (iterate_over_all_matching_symtabs): Use
11615         objfile_compunits.
11616         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11617         (class objfile_compunits): New.
11618         (ALL_COMPUNITS): Use objfile_compunits.
11619         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11620         (maintenance_check_symtabs, maintenance_info_line_tables): Use
11621         objfile_compunits.
11622         * objfiles.c (objfile_relocate1): Use objfile_compunits.
11623
11624 2019-01-09  Tom Tromey  <tom@tromey.com>
11625
11626         * symtab.c (search_symbols)
11627         (default_collect_symbol_completion_matches_break_on): Use
11628         objfile_msymbols.
11629         * ada-lang.c (ada_lookup_simple_minsym)
11630         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11631         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11632         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11633         objfile_msymbols.
11634         * coffread.c (coff_symfile_read): Use objfile_msymbols.
11635         * symmisc.c (dump_msymbols): Use objfile_msymbols.
11636         * objc-lang.c (find_methods): Use objfile_msymbols.
11637         (info_selectors_command, info_classes_command): Likewise.
11638         * stabsread.c (scan_file_globals): Use objfile_msymbols.
11639         * objfiles.h (class objfile_msymbols): New.
11640         (ALL_OBJFILE_MSYMBOLS): Remove.
11641         (ALL_MSYMBOLS): Remove.
11642
11643 2019-01-09  Tom Tromey  <tom@tromey.com>
11644
11645         * common/next-iterator.h (next_adapter): Add Iterator template
11646         parameter.
11647         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11648         (class all_objfiles_safe): New.
11649         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11650         * objfiles.c (put_objfile_before): Update comment.
11651         (add_separate_debug_objfile): Likewise.
11652         (free_all_objfiles): Use all_objfiles_safe.
11653         (objfile_purge_solibs): Likewise.
11654
11655 2019-01-09  Tom Tromey  <tom@tromey.com>
11656
11657         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11658         (expand_symtab_containing_pc, lookup_static_symbol)
11659         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11660         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11661         all_objfiles.
11662         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11663         * breakpoint.c (create_overlay_event_breakpoint)
11664         (create_longjmp_master_breakpoint)
11665         (create_std_terminate_master_breakpoint)
11666         (create_exception_master_breakpoint): Use all_objfiles.
11667         * linux-thread-db.c (try_thread_db_load_from_pdir)
11668         (has_libpthread): Use all_objfiles.
11669         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11670         * linespec.c (iterate_over_all_matching_symtabs)
11671         (search_minsyms_for_name): Use all_objfiles.
11672         * maint.c (maintenance_info_sections): Use all_objfiles.
11673         * main.c (captured_main_1): Use all_objfiles.
11674         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11675         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11676         * guile/scm-pretty-print.c
11677         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11678         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11679         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11680         (maintenance_print_msymbols): Use all_objfiles.
11681         * source.c (select_source_symtab): Use all_objfiles.
11682         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11683         * symfile.c (remove_symbol_file_command)
11684         (expand_symtabs_matching, map_symbol_filenames): Use
11685         all_objfiles.
11686         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11687         all_objfiles.
11688         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11689         * objc-lang.c (find_methods): Use all_objfiles.
11690         * objfiles.c (have_partial_symbols, have_full_symbols)
11691         (have_minimal_symbols, qsort_cmp)
11692         (default_iterate_over_objfiles_in_search_order): Use
11693         all_objfiles.
11694         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11695         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11696         (maintenance_check_psymtabs): Use all_objfiles.
11697         (ALL_PSYMTABS): Remove.
11698         * compile/compile-object-run.c (do_module_cleanup): Use
11699         all_objfiles.
11700         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11701         * cp-support.c (add_symbol_overload_list_qualified): Use
11702         all_objfiles.
11703         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11704         Use all_objfiles.
11705         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11706         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11707         all_objfiles.
11708         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11709         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11710         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11711         Uses all_objfiles.
11712         * solib.c (solib_read_symbols): Use all_objfiles
11713
11714 2019-01-09  Tom Tromey  <tom@tromey.com>
11715
11716         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11717         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11718         all_objfiles.
11719         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11720         * symmisc.c (print_symbol_bcache_statistics)
11721         (print_objfile_statistics, maintenance_print_objfiles)
11722         (maintenance_info_symtabs, maintenance_check_symtabs)
11723         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11724         all_objfiles.
11725         * source.c (forget_cached_source_info): Use all_objfiles.
11726         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11727         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11728         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11729         * objfiles.c (update_section_map): Use all_objfiles.
11730         (shared_objfile_contains_address_p): Likewise.
11731         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11732         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11733
11734 2019-01-09  Tom Tromey  <tom@tromey.com>
11735
11736         * common/next-iterator.h: New file.
11737         * objfiles.h (class all_objfiles): New.
11738         (struct objfile_iterator): New.
11739
11740 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11741
11742         * NEWS: Move the description of the changed "frame", "select-frame",
11743          and "info frame" commands to the Changed commands section.
11744
11745 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11746
11747         * gdbtypes.c (check_stub_method_group): Remove handling of old
11748         mangling schemes.
11749         * linespec.c (find_methods): Likewise.
11750         * stabsread.c (read_member_functions): Likewise.
11751         * valops.c (search_struct_method): Likewise.
11752         (value_struct_elt_for_reference): Likewise.
11753         * NEWS: Mention this change.
11754
11755 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11756
11757         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11758         print_source_lines.
11759         * source.c (print_source_lines_base): Update line number check.
11760         (print_source_lines): New function.
11761         (source_lines_range::source_lines_range): New function.
11762         * source.h (class source_lines_range): New class.
11763         (print_source_lines): New declaration.
11764
11765 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11766
11767         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11768
11769 2019-01-08  Tom Tromey  <tom@tromey.com>
11770             Simon Marchi  <simon.marchi@ericsson.com>
11771
11772         PR gdb/24060
11773         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11774         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11775         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11776         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11777         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11778         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11779
11780 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11781
11782         * source.c (select_source_symtab): Move header comment to
11783         declaration in source.h.
11784         (forget_cached_source_info_for_objfile): Likewise.
11785         (forget_cached_source_info): Likewise.
11786         (identify_source_line): Likewise.
11787         * source.h (identify_source_line): Move declaration from symtab.h
11788         and add comment from source.c
11789         (print_source_lines): Likewise.
11790         (forget_cached_source_info_for_objfile): Likewise.
11791         (forget_cached_source_info): Likewise.
11792         (select_source_symtab): Likewise.
11793         (enum print_source_lines_flag): Move definition from symtab.h.
11794         * symtab.h (identify_source_line): Move declaration to source.h.
11795         (print_source_lines): Likewise.
11796         (forget_cached_source_info_for_objfile): Likewise.
11797         (forget_cached_source_info): Likewise.
11798         (select_source_symtab): Likewise.
11799         (enum print_source_lines_flag): Move definition to source.h.
11800         * tui/tui-hooks.c: Add 'source.h' include.
11801
11802 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11803
11804         * source.c (print_source_lines_base): Handle requests to print
11805         reverse line number sequences, and guard against empty lines
11806         string.
11807
11808 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11809
11810         * source.c (print_source_lines_base): Fix skip of '\r' if next
11811         character is '\n'.
11812
11813 2019-01-06  Tom Tromey  <tom@tromey.com>
11814
11815         * c-exp.y (struct c_parse_state) <macro_original_text,
11816         expansion_obstack>: New member.
11817         (macro_original_text, expansion_obstack): Remove globals.
11818         (scan_macro_expansion, scanning_macro_expansion)
11819         (finished_macro_expansion): Update.
11820         (scan_macro_cleanup): Remove.
11821         (yylex, c_parse): Update.
11822
11823 2019-01-06  Tom Tromey  <tom@tromey.com>
11824
11825         * c-exp.y (struct c_parse_state) <strings>: New member.
11826         (operator_stoken): Update.
11827
11828 2019-01-06  Tom Tromey  <tom@tromey.com>
11829
11830         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11831         (union type_stack_elt) <typelist_val>: Now a pointer to
11832         std::vector.
11833         (type_stack_cleanup): Don't declare.
11834         (push_typelist): Update.
11835         * parse.c (pop_typelist): Return a std::vector.
11836         (push_typelist): Take a std::vector.
11837         (follow_types): Update.  Do not free args.
11838         (type_stack_cleanup): Remove.
11839         * c-exp.y (struct c_parse_state): New.
11840         (cpstate): New global.
11841         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11842         (nonempty_typelist): Update.
11843         (func_mod): Create a new vector.
11844         (c_parse): Create a c_parse_state.
11845         (check_parameter_typelist): Do not delete params.
11846         (function_method): Update.  Do not delete type_list.
11847
11848 2019-01-06  Tom Tromey  <tom@tromey.com>
11849
11850         PR gdb/28155:
11851         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11852         check_typedef.
11853         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11854         (print_return_value): Likewise.
11855
11856 2019-01-05  Tom Tromey  <tom@tromey.com>
11857
11858         * contrib/cleanup_check.py: Remove.
11859         * contrib/gcc-with-excheck: Remove.
11860         * contrib/exsummary.py: Remove.
11861         * contrib/excheck.py: Remove.
11862
11863 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11864
11865         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11866         NULL. Initialize tpprev to NULL instead of assigning it
11867         to NULL on the next statement.
11868         * windows-nat.c (windows_delete_thread): Remove check for
11869         main_thread_id before printing thread exit notifications.
11870         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11871         Remove thread ID check against main_thread_id.
11872         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11873         windows_delete_thread.
11874         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11875
11876 2019-01-04  Tom Tromey  <tom@tromey.com>
11877
11878         * compile/compile.c (_initialize_compile): Use upper case for
11879         metasyntactic variables.
11880         * symmisc.c (_initialize_symmisc): Use upper case for
11881         metasyntactic variables.
11882         * psymtab.c (_initialize_psymtab): Use upper case for
11883         metasyntactic variables.
11884         * demangle.c (demangle_command): Use upper case for metasyntactic
11885         variables.
11886         (_initialize_demangler): Likewise.
11887         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11888         variables.
11889
11890 2019-01-03  Tom Tromey  <tom@tromey.com>
11891
11892         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11893
11894 2019-01-03  Tom Tromey  <tom@tromey.com>
11895
11896         * python/py-symtab.c (salpy_str): Update.
11897         (struct salpy_sal_object) <symtab>: Now a PyObject.
11898         (salpy_dealloc): Update.
11899         (del_objfile_sal): Use gdbpy_ref.
11900
11901 2019-01-03  Tom Tromey  <tom@tromey.com>
11902
11903         * python/py-type.c (convert_field): Use new_reference.  Return
11904         gdbpy_ref.
11905         (make_fielditem): Return gdbpy_ref.
11906         (typy_fields): Update.
11907         (typy_getitem): Update.
11908         (field_name): Return gdbpy_ref.  Use new_reference.
11909         (typy_iterator_iternext): Update.
11910
11911 2019-01-03  Tom Tromey  <tom@tromey.com>
11912
11913         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11914
11915 2019-01-03  Tom Tromey  <tom@tromey.com>
11916
11917         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11918         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11919         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11920         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11921         (pspy_set_type_printers): Likewise.
11922         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11923         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11924         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11925         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11926         (objfpy_set_type_printers): Likewise.
11927
11928 2019-01-03  Tom Tromey  <tom@tromey.com>
11929
11930         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11931         (gdbpy_print_stack): Use gdbpy_err_fetch.
11932         * python/python-internal.h (class gdbpy_err_fetch): New class.
11933         (class gdbpy_enter) <m_error_type, m_error_value,
11934         m_error_traceback>: Remove.
11935         <m_error>: New member.
11936         (gdbpy_exception_to_string): Don't declare.
11937         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11938         * python/py-value.c (convert_value_from_python): Use
11939         gdbpy_err_fetch.
11940         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11941         gdbpy_exception_to_string.
11942         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11943         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11944         gdbpy_err_fetch.
11945
11946 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11947
11948         * linux-nat.c (delete_lwp_cleanup): Delete.
11949         (struct lwp_deleter): New struct.
11950         (lwp_info_up): New typedef.
11951         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11952         lwp_info_up.
11953
11954 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11955
11956         * linux-fork.c (class scoped_switch_fork_info): New class.
11957         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11958
11959 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11960
11961         * valops.c (find_overload_match): Remove use of null_cleanup, and
11962         calls to do_cleanups.
11963
11964 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11965
11966         * compile/compile-cplus-types.c
11967         (compile_cplus_instance::decl_name): Handle changes to
11968         cp_func_name.
11969         * cp-support.c (cp_func_name): Update header comment, update
11970         return type.
11971         * cp-support.h (cp_func_name): Update return type in declaration.
11972         * valops.c (find_overload_match): Move temp_func local to top
11973         level of function and change its type.  Use temp_func to hold and
11974         delete temporary string obtained from cp_func_name.
11975
11976 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11977
11978         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11979         gdb::char_vector, remove cleanup, and update uses of `msg`.
11980
11981 2019-01-03  Jim Wilson  <jimw@sifive.com>
11982
11983         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11984
11985 2019-01-02  Tom Tromey  <tom@tromey.com>
11986
11987         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11988         (tdesc_parse_xml): Remove cleanups.
11989         * target-descriptions.h (make_cleanup_free_target_description):
11990         Don't declare.
11991         (target_desc_deleter): New struct.
11992         (target_desc_up): New typedef.
11993         * target-descriptions.c (target_desc_deleter::operator()): Rename
11994         from free_target_description.
11995         (make_cleanup_free_target_description): Remove.
11996
11997 2019-01-02  Tom Tromey  <tom@tromey.com>
11998
11999         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
12000         constructor, destructor.
12001         (linespec_parser): Remove typedef.
12002         (~linespec_parser): Rename from linespec_parser_delete.
12003         (linespec_lex_to_end, linespec_complete_label)
12004         (linespec_complete): Update.
12005         (decode_line_full): Remove cleanups.
12006         (decode_line_1): Update.
12007
12008 2019-01-02  Tom Tromey  <tom@tromey.com>
12009
12010         * python/python-internal.h (inferior_to_inferior_object): Change
12011         return type.
12012         * python/py-exitedevent.c (create_exited_event_object): Update.
12013         * python/py-inferior.c (inferior_to_inferior_object): Return
12014         gdbpy_ref.
12015         (python_new_inferior, python_inferior_deleted)
12016         (thread_to_thread_object, delete_thread_object)
12017         (build_inferior_list, gdbpy_selected_inferior): Update.
12018         * python/py-infthread.c (create_thread_object): Update.  Also fail
12019         if inferior_to_inferior_object fails.
12020
12021 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
12022
12023         * inferior.h (class inferior) <displaced_step_state>: New field.
12024         * infrun.h (struct displaced_step_state): Move here from
12025         infrun.c.  Initialize fields, add constructor.
12026         <inf>: Remove field.
12027         <reset>: New method.
12028         * infrun.c (struct displaced_step_inferior_state): Move to
12029         infrun.h.
12030         (displaced_step_inferior_states): Remove.
12031         (get_displaced_stepping_state): Adust.
12032         (displaced_step_in_progress_any_inferior): Adjust.
12033         (displaced_step_in_progress_thread): Adjust.
12034         (displaced_step_in_progress): Adjust.
12035         (add_displaced_stepping_state): Remove.
12036         (get_displaced_step_closure_by_addr): Adjust.
12037         (remove_displaced_stepping_state): Remove.
12038         (infrun_inferior_exit): Call displaced_step_state.reset.
12039         (use_displaced_stepping): Don't check for NULL.
12040         (displaced_step_prepare_throw): Call
12041         get_displaced_stepping_state.
12042         (displaced_step_fixup): Don't check for NULL.
12043         (prepare_for_detach): Don't check for NULL.
12044
12045 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12046
12047         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
12048          in case of call that did not complete.
12049
12050 2019-01-02  Andrey Utkin  <autkin@undo.io>
12051
12052         * symfile.c (find_separate_debug_file): Fix search of debug files for
12053         remote debuggee.
12054
12055 2019-01-02  Tom Tromey  <tom@tromey.com>
12056
12057         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
12058         indentation.
12059         * python/py-frame.c (frapy_older): Remove cast.
12060         (frapy_newer): Likewise.
12061         * python/py-breakpoint.c (local_setattro): Remove cast.
12062         * python/py-arch.c (archpy_name): Remove local variable.
12063         * python/py-type.c (gdbpy_lookup_type): Remove cast.
12064
12065 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
12066
12067         * unittests/basic_string_view/element_access/char/empty.cc:
12068         Fix year range in copyright header.
12069
12070 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12071
12072         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
12073         Delete.
12074         <operator==>: Update with for removed field.
12075         <hash>: Likewise.
12076         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
12077         <isa_features>: ...this.
12078         <abi_features>: New field.
12079         (riscv_isa_flen): Update comment.
12080         (riscv_abi_xlen): New declaration.
12081         (riscv_abi_flen): New declaration.
12082         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
12083         isa_features.
12084         (riscv_abi_xlen): New function.
12085         (riscv_isa_flen): Update to get answer from isa_features.
12086         (riscv_abi_flen): New function.
12087         (riscv_has_fp_abi): Update to get answer from abi_features.
12088         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
12089         xlen and flen.
12090         (riscv_call_info) <xlen, flen>: Update comment.
12091         (riscv_call_arg_struct): Remove invalid assertions
12092         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
12093         is removed.
12094         (riscv_gdbarch_init): Gather isa features and abi features
12095         separately, ensure both match on the gdbarch when reusing an old
12096         gdbarch.  Relax an error check to allow 32-bit abi float to run on
12097         a target with 64-bit float hardware.
12098
12099 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12100
12101         * source.c (search_command_helper): Stop reverse search
12102         when line 1 has been searched.
12103
12104 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12105
12106         * record-full.c (record_full_base_target::close): Rewrite
12107         record_full_core_buf_list free logic.
12108
12109 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12110
12111         * break-catch-syscall.c (print_one_catch_syscall): xfree
12112         the last text.
12113
12114 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12115
12116         * top.c (print_gdb_version): Update Copyright year in version
12117         message.
12118
12119 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12120
12121         Update copyright year range in all GDB files.
12122
12123 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
12124
12125         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
12126
12127 For older changes see ChangeLog-2018.
12128 \f
12129 Local Variables:
12130 mode: change-log
12131 left-margin: 8
12132 fill-column: 74
12133 version-control: never
12134 coding: utf-8
12135 End:
12136