gdb/ChangeLog

   1 2019-09-18  Alan Modra  <amodra@gmail.com>
   2
   3         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
   4         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
   5         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
   6
   7 2019-09-18  Alan Modra  <amodra@gmail.com>
   8
   9         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
  10         * spu-linux-nat.c (spu_bfd_open): Likewise.
  11
  12 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
  13
  14         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
  15         to bool to match definition in dwarf2read.c.
  16
  17 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
  18
  19         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
  20         (print_signatures): Likewise.
  21         (trust_pad_over_xvs): Likewise.
  22         * arch/aarch64-insn.c (aarch64_debug): Likewise.
  23         * arch/aarch64-insn.h (aarch64_debug): Likewise.
  24         * arm-linux-nat.c (arm_apcs_32): Likewise.
  25         * arm-linux-tdep.c (arm_apcs_32): Likewise.
  26         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
  27         * arm-tdep.c (arm_debug): Likewise.
  28         (arm_apcs_32): Likewise.
  29         * auto-load.c (debug_auto_load): Likewise.
  30         (auto_load_gdb_scripts): Likewise.
  31         (global_auto_load): Likewise.
  32         (auto_load_local_gdbinit): Likewise.
  33         (auto_load_local_gdbinit_loaded): Likewise.
  34         * auto-load.h (global_auto_load): Likewise.
  35         (auto_load_local_gdbinit): Likewise.
  36         (auto_load_local_gdbinit_loaded): Likewise.
  37         * breakpoint.c (disconnected_dprintf): Likewise.
  38         (breakpoint_proceeded): Likewise.
  39         (automatic_hardware_breakpoints): Likewise.
  40         (always_inserted_mode): Likewise.
  41         (target_exact_watchpoints): Likewise.
  42         (_initialize_breakpoint): Update.
  43         * breakpoint.h (target_exact_watchpoints): Change to bool.
  44         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
  45         * cli/cli-cmds.c (trace_commands): Likewise.
  46         * cli/cli-cmds.h (trace_commands): Likewise.
  47         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
  48         to bool*.
  49         * cli/cli-logging.c (logging_overwrite): Change to bool.
  50         (logging_redirect): Likewise.
  51         (debug_redirect): Likewise.
  52         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
  53         (struct boolean_option_def) <get_var_address_cb_>: Change return type
  54         to bool.
  55         <boolean_option_def>: Update.
  56         (struct flag_option_def): Change default type of Context to bool
  57         from int.
  58         <flag_option_def>: Change return type of var_address_cb_ to bool*.
  59         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
  60         (get_setshow_command_value_string): Likewise.
  61         * cli/cli-style.c (cli_styling): Change to bool.
  62         (source_styling): Likewise.
  63         * cli/cli-style.h (source_styling): Likewise.
  64         (cli_styling): Likewise.
  65         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
  66         to bool.
  67         * command.h (var_types): Update comment.
  68         (add_setshow_boolean_cmd): Change int* var argument to bool*.
  69         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
  70         bool.
  71         (debug_compile_cplus_scopes): Likewise.
  72         * compile/compile-internal.h (compile_debug): Likewise.
  73         * compile/compile.c (compile_debug): Likewise.
  74         (struct compile_options) <raw>: Likewise.
  75         * cp-support.c (catch_demangler_crashes): Likewise.
  76         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
  77         (usr_cmd_cris_dwarf2_cfi): Likewise.
  78         * csky-tdep.c (csky_debug): Likewise.
  79         * darwin-nat.c (enable_mach_exceptions): Likewise.
  80         * dcache.c (dcache_enabled_p): Likewise.
  81         * defs.h (info_verbose): Likewise.
  82         * demangle.c (demangle): Likewise.
  83         (asm_demangle): Likewise.
  84         * dwarf-index-cache.c (debug_index_cache): Likewise.
  85         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
  86         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
  87         * dwarf2read.c (check_physname): Likewise.
  88         (use_deprecated_index_sections): Likewise.
  89         (dwarf_always_disassemble): Likewise.
  90         * eval.c (overload_resolution): Likewise.
  91         * event-top.c (set_editing_cmd_var): Likewise.
  92         (exec_done_display_p): Likewise.
  93         * event-top.h (set_editing_cmd_var): Likewise.
  94         (exec_done_display_p): Likewise.
  95         * exec.c (write_files): Likewise.
  96         * fbsd-nat.c (debug_fbsd_lwp): Likewise
  97         (debug_fbsd_nat): Likewise.
  98         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
  99         Likewise.
 100         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
 101         <backtrace_past_entry> Likewise.
 102         * gdb-demangle.h (demangle): Likewise.
 103         (asm_demangle): Likewise.
 104         * gdb_bfd.c (bfd_sharing): Likewise.
 105         * gdbcore.h (write_files): Likewise.
 106         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
 107         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
 108         * gdbthread.h (print_thread_events): Likewise.
 109         * gdbtypes.c (opaque_type_resolution): Likewise.
 110         (strict_type_checking): Likewise.
 111         * gnu-nat.c (gnu_debug_flag): Likewise.
 112         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
 113         * guile/scm-param.c (pascm_variable): Add boolval.
 114         (add_setshow_generic): Update.
 115         (pascm_param_value): Update.
 116         (pascm_set_param_value_x): Update.
 117         * hppa-tdep.c (hppa_debug): Change to bool..
 118         * infcall.c (may_call_functions_p): Likewise.
 119         (coerce_float_to_double_p): Likewise.
 120         (unwind_on_signal_p): Likewise.
 121         (unwind_on_terminating_exception_p): Likewise.
 122         * infcmd.c (startup_with_shell): Likewise.
 123         * inferior.c (print_inferior_events): Likewise.
 124         * inferior.h (startup_with_shell): Likewise.
 125         (print_inferior_events): Likewise.
 126         * infrun.c (step_stop_if_no_debug): Likewise.
 127         (detach_fork): Likewise.
 128         (debug_displaced): Likewise.
 129         (disable_randomization): Likewise.
 130         (non_stop): Likewise.
 131         (non_stop_1): Likewise.
 132         (observer_mode): Likewise.
 133         (observer_mode_1): Likewise.
 134         (set_observer_mode): Update.
 135         (sched_multi): Change to bool.
 136         * infrun.h (debug_displaced): Likewise.
 137         (sched_multi): Likewise.
 138         (step_stop_if_no_debug): Likewise.
 139         (non_stop): Likewise.
 140         (disable_randomization): Likewise.
 141         * linux-tdep.c (use_coredump_filter): Likewise.
 142         (dump_excluded_mappings): Likewise.
 143         * linux-thread-db.c (auto_load_thread_db): Likewise.
 144         (check_thread_db_on_load): Likewise.
 145         * main.c (captured_main_1): Update.
 146         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
 147         xx2_opt, boolean_opt>: Change to bool.
 148         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
 149         * maint.c (maintenance_profile_p): Likewise.
 150         (per_command_time): Likewise.
 151         (per_command_space): Likewise.
 152         (per_command_symtab): Likewise.
 153         * memattr.c (inaccessible_by_default): Likewise.
 154         * mi/mi-main.c (mi_async): Likewise.
 155         (mi_async_1): Likewise.
 156         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
 157         * nat/fork-inferior.h (startup_with_shell): Likewise.
 158         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
 159         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
 160         * nios2-tdep.c (nios2_debug): Likewise.
 161         * or1k-tdep.c (or1k_debug): Likewise.
 162         * parse.c (parser_debug): Likewise.
 163         * parser-defs.h (parser_debug): Likewise.
 164         * printcmd.c (print_symbol_filename): Likewise.
 165         * proc-api.c (procfs_trace): Likewise.
 166         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
 167         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
 168         (set_parameter_value): Update.
 169         (add_setshow_generic): Update.
 170         * python/py-value.c (copy_py_bool_obj): Change argument from int*
 171         to bool*.
 172         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
 173         int*.
 174         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
 175         * record-btrace.c (record_btrace_target::store_registers): Update.
 176         * record-full.c (record_full_memory_query): Change to bool.
 177         (record_full_stop_at_limit): Likewise.
 178         * record-full.h (record_full_memory_query): Likewise.
 179         * remote-notif.c (notif_debug): Likewise.
 180         * remote-notif.h (notif_debug): Likewise.
 181         * remote.c (use_range_stepping): Likewise.
 182         (interrupt_on_connect): Likewise.
 183         (remote_break): Likewise.
 184         * ser-tcp.c (tcp_auto_retry): Likewise.
 185         * ser-unix.c (serial_hwflow): Likewise.
 186         * skip.c (debug_skip): Likewise.
 187         * solib-aix.c (solib_aix_debug): Likewise.
 188         * spu-tdep.c (spu_stop_on_load_p): Likewise.
 189         (spu_auto_flush_cache_p): Likewise.
 190         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
 191         Likewise.
 192         (struct info_print_options) <quiet>: Likewise.
 193         * symfile-debug.c (debug_symfile): Likewise.
 194         * symfile.c (auto_solib_add): Likewise.
 195         (separate_debug_file_debug): Likewise.
 196         * symfile.h (auto_solib_add): Likewise.
 197         (separate_debug_file_debug): Likewise.
 198         * symtab.c (basenames_may_differ): Likewise.
 199         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
 200         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
 201         (struct info_types_options) <quiet>: Likewise.
 202         * symtab.h (demangle): Likewise.
 203         (basenames_may_differ): Likewise.
 204         * target-dcache.c (stack_cache_enabled_1): Likewise.
 205         (code_cache_enabled_1): Likewise.
 206         * target.c (trust_readonly): Likewise.
 207         (may_write_registers): Likewise.
 208         (may_write_memory): Likewise.
 209         (may_insert_breakpoints): Likewise.
 210         (may_insert_tracepoints): Likewise.
 211         (may_insert_fast_tracepoints): Likewise.
 212         (may_stop): Likewise.
 213         (auto_connect_native_target): Likewise.
 214         (target_stop_and_wait): Update.
 215         (target_async_permitted): Change to bool.
 216         (target_async_permitted_1): Likewise.
 217         (may_write_registers_1): Likewise.
 218         (may_write_memory_1): Likewise.
 219         (may_insert_breakpoints_1): Likewise.
 220         (may_insert_tracepoints_1): Likewise.
 221         (may_insert_fast_tracepoints_1): Likewise.
 222         (may_stop_1): Likewise.
 223         * target.h (target_async_permitted): Likewise.
 224         (may_write_registers): Likewise.
 225         (may_write_memory): Likewise.
 226         (may_insert_breakpoints): Likewise.
 227         (may_insert_tracepoints): Likewise.
 228         (may_insert_fast_tracepoints): Likewise.
 229         (may_stop): Likewise.
 230         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
 231         (make_thread_apply_all_options_def_group): Change argument from int*
 232         to bool*.
 233         (thread_apply_all_command): Update.
 234         (print_thread_events): Change to bool.
 235         * top.c (confirm): Likewise.
 236         (command_editing_p): Likewise.
 237         (history_expansion_p): Likewise.
 238         (write_history_p): Likewise.
 239         (info_verbose): Likewise.
 240         * top.h (confirm): Likewise.
 241         (history_expansion_p): Likewise.
 242         * tracepoint.c (disconnected_tracing): Likewise.
 243         (circular_trace_buffer): Likewise.
 244         * typeprint.c (print_methods): Likewise.
 245         (print_typedefs): Likewise.
 246         * utils.c (debug_timestamp): Likewise.
 247         (sevenbit_strings): Likewise.
 248         (pagination_enabled): Likewise.
 249         * utils.h (sevenbit_strings): Likewise.
 250         (pagination_enabled): Likewise.
 251         * valops.c (overload_resolution): Likewise.
 252         * valprint.h (struct value_print_options) <prettyformat_arrays,
 253         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
 254         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
 255         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
 256         Likewise.
 257         * windows-nat.c (new_console): Likewise.
 258         (cygwin_exceptions): Likewise.
 259         (new_group): Likewise.
 260         (debug_exec): Likewise.
 261         (debug_events): Likewise.
 262         (debug_memory): Likewise.
 263         (debug_exceptions): Likewise.
 264         (useshell): Likewise.
 265         * windows-tdep.c (maint_display_all_tib): Likewise.
 266         * xml-support.c (debug_xml): Likewise.
 267
 268 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
 269
 270         * source.c (prepare_path_for_appending): New function.
 271         (openp): Make use of new function.
 272         (find_and_open_source): Search for the compilation directory and
 273         source file as a relative path beneath the directory search path.
 274
 275 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 276
 277         * source-cache.c (source_cache::get_line_charpos): Catch
 278         exceptions and return false, this matches the behaviour documented
 279         in the header file.
 280
 281 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
 282
 283         * ada-tasks.c (info_task): Remove quoting of the task's name.
 284
 285 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
 286
 287         * symfile.c (auto_solib_add): Replace comment with a reference
 288         to the header file.
 289
 290 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
 291
 292         * NEWS: Mention that gdb can now be compiled with Python 3
 293         on Windows.
 294
 295 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 296
 297         * maint.c (maint_print_section_data::maint_print_section_data):
 298         Force use of 'float log10 (float)' by casting the argument to
 299         float.
 300
 301 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 302
 303         * maint.c: Add 'cmath' include.
 304         (struct maint_print_section_data): New structure.
 305         (print_section_index): New function.
 306         (print_bfd_section_info): Add header comment, small whitespace
 307         cleanup, and update to call new print_section_index function.
 308         (print_objfile_section_info): Likewise.
 309         (maint_obj_section_from_bfd_section): New function.
 310         (print_bfd_section_info_maybe_relocated): New function.
 311         (maintenance_info_sections): Add header comment, always use
 312         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
 313
 314 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 315
 316         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
 317         inner scope, add check that the objfile has psymtabs before
 318         checking psymtabs_addrmap.
 319         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
 320
 321 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 322
 323         * NEWS: Announce that Ada task names are now shown at more places,
 324         and between quotes (except in info task output).
 325         * gdb/ada-tasks.c (task_to_str): New function.
 326         (display_current_task_id): Call task_to_str.
 327         (task_command_1): Likewise.
 328         (print_ada_task_info): In non-mi mode, Properly align headers and data
 329         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
 330
 331 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 332
 333         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
 334         prstatus.pr_lwp.pr_info instead of making it up.
 335
 336 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 337
 338         * auto-load.c (auto_load_expand_dir_vars): Update.
 339         * defs.h (gdb_datadir): Change to std::string.
 340         (python_libdir): Likewise.
 341         (relocate_gdb_directory): Change return type to std::string.
 342         * guile/guile.c (gdbscm_data_directory): Update.
 343         (initialize_scheme_side): Update.
 344         * jit.c (jit_reader_dir): Change to std::string.
 345         (jit_reader_load_command): Update.
 346         * main.c (gdb_datadir): Change to std::string.
 347         (python_libdir): Likewise.
 348         (set_gdb_data_directory): Update.
 349         (relocate_path): Change to return std::string.
 350         (relocate_gdb_directory): Change to return std::string.
 351         (relocate_gdbinit_path_maybe_in_datadir): Update.
 352         (captured_main_1): Update.
 353         * python/python.c (do_start_initialization): Update.
 354         * top.c (show_gdb_datadir): Update.
 355         * xml-syscall.c (xml_init_syscalls_info): Update.
 356         (init_syscalls_info): Update.
 357
 358 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 359
 360         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
 361         out of get_init_files.
 362         (get_init_files): Update.
 363
 364 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 365
 366         * main.c (get_init_files): Change to use std::string.
 367         (captured_main_1): Update.
 368         (print_gdb_help): Update.
 369
 370 2019-09-11  Ali Tamur  <tamur@google.com>
 371
 372         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
 373         implementation.
 374
 375 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 376
 377         * dbxread.c (read_dbx_symtab): Update.
 378         * dwarf2read.c (load_partial_dies): Update.
 379         * mdebugread.c (parse_partial_symbols): Update.
 380         (handle_psymbol_enumerators): Update.
 381         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
 382         * psymtab.c (add_psymbol_to_bcache): Likewise.
 383         (add_psymbol_to_list): Likewise.
 384         * symtab.c (symbol_set_names): Likewise.
 385         * symtab.h (symbol_set_names): Likewise.
 386         * xcoffread.c (scan_xcoff_symtab): Update.
 387
 388 2019-09-11  Tom Tromey  <tom@tromey.com>
 389
 390         * symfile-mem.c (symbol_file_add_from_memory): Use
 391         bfd_set_filename.
 392         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
 393         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
 394
 395 2019-09-10  Tom Tromey  <tromey@adacore.com>
 396
 397         * dwarf-index-write.c (write_psymbols): Extend error message.
 398         (debug_names::insert): Add Ada code.
 399         (debug_names::write_psymbols): Remove Ada check.
 400         (debug_names) <m_string_obstack>: New member.
 401         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
 402         (gdb_index_symbol_name_matcher::matches): Remove.
 403         (mapped_index_base::find_name_components_bounds): Add "lang"
 404         parameter.
 405         (mapped_index_base::build_name_components): Also split names
 406         according to Ada syntax.
 407         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
 408         type of "match_callback".
 409         (check_match, check_find_bounds_finds)
 410         (dw2_expand_symtabs_matching): Update.
 411         (dw2_debug_names_iterator): Add new constructor.
 412         (dw2_debug_names_map_matching_symbols): New function.
 413         (dw2_debug_names_expand_symtabs_matching): Update.
 414         (dwarf2_debug_names_functions): Use
 415         dw2_debug_names_map_matching_symbols.
 416
 417 2019-09-10  Tom Tromey  <tromey@adacore.com>
 418
 419         * dwarf2read.c (dw2_get_file_names_reader): Add the
 420         CU's file name to the results.
 421
 422 2019-09-10  Tom Tromey  <tromey@adacore.com>
 423
 424         * ada-lang.c (add_nonlocal_symbols): Combine calls to
 425         map_matching_symbols.  Update.
 426         * dwarf2read.c (dw2_map_matching_symbols): Update.
 427         * psymtab.c (match_partial_symbol): Change type; update.
 428         (psym_map_matching_symbols): Likewise.
 429         * symfile-debug.c (debug_qf_map_matching_symbols): Change
 430         type; update.
 431         * symfile.h (struct quick_symbol_functions)
 432         <map_matching_symbols>: Change "name" to be a lookup_name_info.
 433         Remove "match".
 434
 435 2019-09-10  Tom Tromey  <tromey@adacore.com>
 436
 437         * psymtab.c (map_block): Remove.
 438         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
 439         * symtab.c (iterate_over_symbols_terminated): New function.
 440         * symtab.c (iterate_over_symbols_terminated): Declare.
 441
 442 2019-09-10  Tom Tromey  <tromey@adacore.com>
 443
 444         * ada-lang.c (ada_iterate_over_symbols): Return bool.
 445         * language.h (struct language_defn) <la_iterate_over_symbols>:
 446         Return bool.
 447         * symtab.c (iterate_over_symbols): Return bool.
 448         * symtab.h (iterate_over_symbols): Return bool.
 449
 450 2019-09-10  Tom Tromey  <tromey@adacore.com>
 451
 452         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
 453         (add_nonlocal_symbols): Update.
 454         * dwarf2read.c (dw2_map_matching_symbols): Change type.
 455         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
 456         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
 457         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
 458         Change type of "callback".  Remove "data".
 459
 460
 461 2019-09-09  Ali Tamur  <tamur@google.com>
 462
 463         * dwarf2read.c (comp_unit_head): Update comment.
 464         (dwarf2_dwo_name): New function declaration.
 465         (dwarf_unit_type_name): New function declaration.
 466         (read_comp_unit_head): Add support for new compilation units,
 467         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
 468         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
 469         (currently named as "signature") in their header. Also clarify error
 470         messages.
 471         (lookup_dwo_id): New function. Returns the dwo id of the given
 472         compile unit.
 473         (lookup_dwo_unit): Use the new lookup_dwo_id function.
 474         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
 475         functions.
 476         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
 477         (dwarf2_dwo_name): Get the dwo name if present.
 478         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
 479         purposes.
 480
 481 2019-09-09  Tom Tromey  <tom@tromey.com>
 482
 483         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
 484
 485 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 486
 487         * python/python.c (do_start_initialization): Make progname_copy static,
 488         to avoid a leak report.
 489
 490 2019-09-08  Tom Tromey  <tom@tromey.com>
 491
 492         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
 493
 494 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
 495
 496         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
 497         Change type to gdb::optional<block_enum>.
 498         (dw2_symtab_iter_init): Change block_index parameter type
 499         to gdb::optional<block_enum>.
 500         (dw2_lookup_symbol): Change block_index parameter
 501         type to block_enum.c
 502         (dw2_debug_names_lookup_symbol): Likewise.
 503         * psymtab.c (psym_lookup_symbol): Likewise.
 504         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
 505         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
 506         Likewise.
 507
 508 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
 509
 510         * defs.h (relocate_gdb_directory): Change int to bool in
 511         signature and rename flag to relocatable.
 512         * main.c (relocate_path): Likewise.
 513         (relocate_gdb_directory): Likewise.
 514
 515 2019-09-06  Alan Modra  <amodra@gmail.com>
 516
 517         * coffread.c (coff_symfile_read): Constify filename variable.
 518         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
 519         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
 520         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
 521         * solib.c (reload_shared_libraries_1): Likewise.
 522         * symfile.c (reread_symbols): Likewise.
 523         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
 524         * solib-darwin.c (darwin_bfd_open): Likewise.
 525         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
 526
 527 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 528
 529         * psymtab.c (print_partial_symbols): Handle missing domain_enum
 530         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
 531
 532 2019-09-03  Tom Tromey  <tromey@adacore.com>
 533
 534         * ada-valprint.c (ada_val_print_num): Don't recurse for range
 535         types.
 536         (has_negatives): Unbias a range type bound.
 537         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
 538         * gdbtypes.c (operator==): Handle new field.
 539         (create_range_type): Add "bias" parameter.
 540         (create_static_range_type, resolve_dynamic_range): Update.
 541         * gdbtypes.h (struct range_bounds) <bias>: New member.
 542         (create_range_type): Add bias parameter.
 543         * printcmd.c (print_scalar_formatted): Unbias range types.
 544         * value.c (unpack_long): Unbias range types.
 545         (pack_long): Bias range types.
 546
 547 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 548
 549         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
 550         probe arguments.
 551
 552 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 553
 554         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
 555         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
 556         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
 557         (compile_probe_arg): Likewise.
 558         * probe.h (get_argument_count): Likewise.
 559         * solib-svr4.c (solib_event_probe_action): Likewise.
 560         * stap-probe.c (stap_probe::get_argument_count): Likewise.
 561
 562 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 563
 564         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
 565         code to here...
 566         (svr4_create_solib_event_breakpoints): ...from here.
 567
 568 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
 569
 570         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
 571         suffix from warning message.
 572
 573 2019-08-30  Tom Tromey  <tom@tromey.com>
 574
 575         * tui/tui-winsource.h (struct tui_source_window_base)
 576         <refresh_all>: Don't declare.
 577         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
 578         Remove.
 579         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
 580         tui_show_locator_content.
 581         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
 582         declare.
 583         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
 584         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
 585         declare.
 586
 587 2019-08-30  Tom Tromey  <tom@tromey.com>
 588
 589         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
 590
 591 2019-08-30  Tom Tromey  <tom@tromey.com>
 592
 593         * tui/tui-stack.c (_initialize_tui_stack): Move later.
 594         Remove unnecessary forward declarations.
 595
 596 2019-08-30  Tom Tromey  <tom@tromey.com>
 597
 598         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
 599         rerender.
 600         (tui_update_locator_fullname, tui_show_frame_info): Don't call
 601         tui_show_locator_content.
 602
 603 2019-08-30  Tom Tromey  <tom@tromey.com>
 604
 605         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
 606         (tui_locator_window::rerender): Rewrite using body of previous
 607         tui_show_locator_content.
 608
 609 2019-08-30  Tom Tromey  <tom@tromey.com>
 610
 611         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
 612         set_locator_fullname>: New methods.
 613         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
 614         Rename from tui_set_locator_fullname.
 615         (tui_locator_window::set_locator_info): Rename from
 616         tui_set_locator_info.  Return bool.
 617         (tui_update_locator_fullname, tui_show_frame_info): Update.
 618
 619 2019-08-30  Tom Tromey  <tom@tromey.com>
 620
 621         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
 622
 623 2019-08-30  Tom Tromey  <tom@tromey.com>
 624
 625         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
 626         call touchwin.
 627
 628 2019-08-30  Tom Tromey  <tom@tromey.com>
 629
 630         * tui/tui-wingeneral.c (box_win): Assume win_info and
 631         win_info->handle cannot be NULL.
 632
 633 2019-08-30  Tom Tromey  <tom@tromey.com>
 634
 635         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
 636         refresh_window>: Declare.
 637         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
 638         resize.
 639         (tui_data_item_window::rerender): Rename from
 640         tui_display_register.
 641         (tui_data_item_window::refresh_window): New method.
 642         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
 643         no-op.
 644
 645 2019-08-30  Tom Tromey  <tom@tromey.com>
 646
 647         * tui/tui-regs.h (struct tui_data_window) <regs_content,
 648         regs_column_count, current_group>: Move later.  Now private.
 649         <get_current_group>: New method.
 650         * tui/tui-regs.c (tui_reg_command): Update.
 651         * tui/tui-layout.c (tui_set_layout): Update.
 652
 653 2019-08-30  Tom Tromey  <tom@tromey.com>
 654
 655         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 656         (tui_data_window::rerender): Don't call
 657         check_and_display_highlight_if_needed.
 658         (tui_data_window::refresh_all): Remove call to
 659         erase_data_content.
 660
 661 2019-08-30  Tom Tromey  <tom@tromey.com>
 662
 663         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 664         (tui_data_window::display_registers_from)
 665         (tui_data_window::display_reg_element_at_line)
 666         (tui_data_window::display_registers_from_line): Remove checks of
 667         "empty".
 668
 669 2019-08-30  Tom Tromey  <tom@tromey.com>
 670
 671         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
 672         Don't declare.
 673         * tui/tui-regs.c (tui_data_window::show_registers): Call
 674         rerender.
 675         (tui_data_window::rerender): Rename from display_all_data.
 676         (tui_data_window::rerender): Remove old implementation.
 677
 678 2019-08-30  Tom Tromey  <tom@tromey.com>
 679
 680         * tui/tui-regs.c (tui_data_window::display_all_data): Change
 681         text.
 682         * tui/tui-data.h (NO_DATA_STRING): Remove define.
 683
 684 2019-08-29  Bernhard Wodok  <barto@gmx.net>
 685             Sergio Durigan Junior  <sergiodj@redhat.com>
 686
 687         PR win32/24284
 688         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
 689
 690 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 691
 692         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
 693         when searching for types.
 694
 695 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 696
 697         * f-lang.c (f_language_defn): Use f_print_typedef.
 698         * f-lang.h (f_print_typedef): Declare.
 699         * f-typeprint.c (f_print_typedef): Define.
 700
 701 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
 702
 703         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
 704
 705 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 706
 707         * cli/cli-utils.c (info_print_options_defs): Delete.
 708         (make_info_print_options_def_group): Delete.
 709         (extract_info_print_options): Delete.
 710         (info_print_command_completer): Delete.
 711         (info_print_args_help): Add extra parameter, and optionally
 712         include text about -n flag.
 713         * cli/cli-utils.h (struct info_print_options): Delete.
 714         (extract_info_print_options): Delete declaration.
 715         (info_print_command_completer): Delete declaration.
 716         (info_print_args_help): Add extra parameter, extend header
 717         comment.
 718         * python/python.c (gdbpy_rbreak): Pass additional parameter to
 719         search_symbols.
 720         * stack.c (struct info_print_options): New type.
 721         (info_print_options_defs): New file scoped variable.
 722         (make_info_print_options_def_group): New static function.
 723         (info_print_command_completer): New static function.
 724         (info_locals_command): Update to use new local functions.
 725         (info_args_command): Likewise.
 726         (_initialize_stack): Add extra parameter to calls to
 727         info_print_args_help.
 728         * symtab.c (search_symbols): Add extra parameter, use this to
 729         possibly excluse non-debug symbols.
 730         (symtab_symbol_info): Add extra parameter, which is passed on to
 731         search_symbols.
 732         (struct info_print_options): New type.
 733         (info_print_options_defs): New file scoped variable.
 734         (make_info_print_options_def_group): New static function.
 735         (info_print_command_completer): New static function.
 736         (info_variables_command): Update to use local functions, and pass
 737         extra parameter through to symtab_symbol_info.
 738         (info_functions_command): Likewise.
 739         (info_types_command): Pass additional argument through to
 740         symtab_symbol_info.
 741         (rbreak_command): Pass extra argument to search_symbols.
 742         (_initialize_symtab): Add extra arguments for calls to
 743         info_print_args_help, and update help text for 'info variables',
 744         'whereis', and 'info functions' commands.
 745         * symtab.h (search_symbols): Add extra argument to declaration.
 746         * NEWS: Mention new flags.
 747
 748 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
 749
 750         * symtab.c (lookup_static_symbol): Call the new function (and move
 751         it down to be next to lookup_global_symbol).
 752         (struct global_sym_lookup_data): Add block_enum member and rename to...
 753         (struct global_or_static_sym_lookup_data): ...this.
 754         (lookup_symbol_global_iterator_cb): Pass block_index instead of
 755         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
 756         (lookup_symbol_global_or_static_iterator_cb): ...this.
 757         (lookup_global_or_static_symbol): New function.
 758         (lookup_global_symbol): Call new function.
 759
 760 2019-08-26  Tom de Vries  <tdevries@suse.de>
 761
 762         PR c++/24852
 763         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
 764         when pc_probe.prob == NULL.
 765
 766 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 767
 768         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
 769         variable symbol_linkage to symbol_linkage_.
 770
 771 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 772
 773         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
 774         represent whether the symbol is static, dynamic, or we don't
 775         know.
 776
 777 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
 778
 779         * gdb/rx-tdep.c (rx_register_names): New.
 780         (rx_register_name): Delete.
 781         (rx_psw_type): Delete.
 782         (rx_fpsw_type): Delete.
 783         (rx_register_type): Delete.
 784         (rx_gdbarch_init): Convert target-descriptions.
 785         (_initialize_rx_tdep): Add initialize_tdesc_rx.
 786         * gdb/features/Makefile: Add rx.xml.
 787         * gdb/features/rx.xml: New.
 788         * gdb/features/rx.c: Generated.
 789         * gdb/NEWS: Mention target description support.
 790
 791 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 792
 793         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
 794         *slot_ptr.
 795
 796 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 797
 798         * configure.ac: Don't check for 'dlfcn.h' (moved to
 799         gdbsupport/common.m4).
 800         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
 801         'gdbsupport/'.
 802         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
 803         * compile/compile-c-support.c: Include
 804         'gdbsupport/gdb-dlfcn.h'.
 805         * gdbsupport/common.m4: Check for 'dlfcn.h'.
 806         * gdb-dlfcn.c: Move to...
 807         * gdbsupport/gdb-dlfcn.c: ... here.
 808         * gdb-dlfcn.h: Move to...
 809         * gdbsupport/gdb-dlfcn.h: ... here.
 810
 811 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
 812
 813         * nios2-tdep.c (struct reg_value): Improve comments.  Make
 814         the offset field signed.
 815
 816 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 817
 818         * python/lib/gdb/__init__.py (_execute_file): New function.
 819         * python/python.c (python_run_simple_file): Call gdb._execute_file
 820         on Windows.
 821
 822 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 823
 824         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
 825         all uses as this was never set to anything but a zero value.
 826
 827 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
 828
 829         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
 830
 831 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
 832
 833         * tui/tui-data.h (tui_gen_win_info): Add an =default
 834         move constructor, required by some GCC versions.
 835
 836 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
 837
 838         * go32-nat.c (go32_sysinfo): Add hygon_p.
 839
 840 2019-08-20  Tom Tromey  <tom@tromey.com>
 841
 842         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
 843         line_from_reg_element_no, first_reg_element_no_inline,
 844         display_all_data, delete_data_content_windows,
 845         erase_data_content>: Now private.
 846
 847 2019-08-20  Tom Tromey  <tom@tromey.com>
 848
 849         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
 850         (tui_unhighlight_win, tui_highlight_win)
 851         (tui_win_info::make_window): Update.
 852         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
 853
 854 2019-08-20  Tom Tromey  <tom@tromey.com>
 855
 856         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 857         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 858         (MAX_PID_WIDTH): Move to tui-stack.c.
 859         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 860         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 861         (MAX_PID_WIDTH): Move from tui-data.h.
 862
 863 2019-08-20  Tom Tromey  <tom@tromey.com>
 864
 865         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
 866         * tui/tui-wingeneral.c (box_win): Change type of win_info.
 867         (box_win): Update.
 868         (tui_gen_win_info::make_window): Rename from tui_make_window.
 869         (tui_win_info::make_window): New method.
 870         (tui_gen_win_info::make_visible): Update.
 871         * tui/tui-source.c (tui_source_window::set_contents): Update.
 872         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
 873         (tui_data_window::display_registers_from): Update.
 874         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 875         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
 876         Declare.
 877         <can_box>: Remove.
 878         <title>: Remove.
 879         (struct tui_win_info) <make_window>: Declare.
 880         <can_box>: Now virtual.
 881         <title>: New member.
 882         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
 883         * tui/tui-command.c (tui_cmd_window::resize): Update.
 884
 885 2019-08-20  Tom Tromey  <tom@tromey.com>
 886
 887         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
 888         * tui/tui-regs.c (tui_data_window::show_registers): Update.
 889         (tui_data_window::check_register_values): Update.
 890
 891 2019-08-20  Tom Tromey  <tom@tromey.com>
 892
 893         * tui/tui-regs.h (struct tui_data_window): Use
 894         DISABLE_COPY_AND_ASSIGN.
 895         <regs_content>: Change type, removing unique_ptr.
 896         <tui_data_window>: Add move constructor.
 897         * tui/tui-regs.c (tui_data_window::show_registers)
 898         (tui_data_window::show_register_group)
 899         (tui_data_window::display_registers_from)
 900         (tui_data_window::display_registers_from)
 901         (tui_data_window::first_data_item_displayed)
 902         (tui_data_window::delete_data_content_windows)
 903         (tui_data_window::rerender, tui_data_window::refresh_window)
 904         (tui_data_window::check_register_values): Update.
 905
 906 2019-08-20  Tom Tromey  <tom@tromey.com>
 907
 908         * tui/tui-regs.h (struct tui_data_window) <show_registers,
 909         show_register_group>: Declare.
 910         (tui_show_register_group): Don't declare.
 911         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
 912         tui_show_registers.
 913         (tui_data_window::show_register_group): Rename from
 914         tui_show_register_group.
 915         (tui_data_window::check_register_values, tui_reg_command):
 916         Update.
 917         * tui/tui-layout.c (tui_set_layout): Update.
 918
 919 2019-08-20  Tom Tromey  <tom@tromey.com>
 920
 921         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
 922         Declare.
 923         (tui_check_register_values): Don't declare.
 924         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
 925         from tui_check_register_values.
 926         * tui/tui-hooks.c (tui_register_changed): Update.
 927
 928 2019-08-20  Tom Tromey  <tom@tromey.com>
 929
 930         * tui/tui-regs.c (tui_reg_layout): Move later.
 931         (tui_show_registers): Don't enable TUI mode or change layout.
 932
 933 2019-08-20  Tom Tromey  <tom@tromey.com>
 934
 935         * tui/tui-regs.h (struct tui_data_item_window)
 936         <~tui_data_item_window>: Remove.
 937         <content>: Now a unique_xmalloc_ptr.
 938         * tui/tui-regs.c (tui_register_format): Return a
 939         unique_xmalloc_ptr.
 940         (tui_get_register): Update.
 941         (~tui_data_item_window): Remove.
 942         (tui_data_window::display_registers_from, tui_display_register):
 943         Update.
 944         * tui/tui-io.h (tui_expand_tabs): Update.
 945         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
 946         Remove "col" parameter.
 947
 948 2019-08-20  Tom Tromey  <tom@tromey.com>
 949
 950         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
 951         field.
 952         * tui/tui-regs.c (~tui_data_item_window): Update.
 953
 954 2019-08-20  Tom Tromey  <tom@tromey.com>
 955
 956         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
 957         earlier.
 958
 959 2019-08-20  Tom Tromey  <tom@tromey.com>
 960
 961         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
 962
 963 2019-08-20  Tom Tromey  <tom@tromey.com>
 964
 965         * tui/tui-source.h (struct tui_source_window): Update.
 966         * tui/tui-regs.c (tui_show_registers): Update.
 967         * tui/tui-disasm.h (struct tui_disasm_window): Update.
 968         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
 969         (NO_REGS_STRING): Remove defines.
 970
 971 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
 972
 973         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
 974         unnecessary thread walk if remote doesn't support the packet.
 975
 976 2019-08-19  Tom Tromey  <tromey@adacore.com>
 977
 978         * python/py-value.c (value_has_field): Fix indentation.
 979
 980 2019-08-19  Tom Tromey  <tromey@adacore.com>
 981
 982         * printcmd.c (do_one_display, info_display_command): Update.
 983         * block.h (contained_in): Return bool.  Add allow_nested
 984         parameter.
 985         * block.c (contained_in): Return bool.  Add allow_nested
 986         parameter.
 987
 988 2019-08-19  Tom Tromey  <tom@tromey.com>
 989
 990         * configure: Rebuild.
 991         * configure.ac: Disallow the combination of -static-libstdc++ and
 992         source highlight.
 993         * source-cache.c (get_language_name): Handle rust.
 994         (source_cache::get_source_lines): Ignore highlighting exceptions.
 995
 996 2019-08-16  Tom Tromey  <tom@tromey.com>
 997
 998         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
 999         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
1000         (struct tui_source_window_base) <make_visible, refresh_window,
1001         resize>: Remove methods.
1002         <execution_info>: Remove field.
1003         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
1004         (tui_show_source_line, tui_source_window_base)
1005         (~tui_source_window_base): Update.
1006         (tui_source_window_base::resize)
1007         (tui_source_window_base::make_visible)
1008         (tui_source_window_base::refresh_window): Remove.
1009         (tui_source_window_base::update_exec_info): Update.
1010         * tui/tui-source.c (tui_source_window::set_contents): Update.
1011         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1012
1013 2019-08-16  Tom Tromey  <tom@tromey.com>
1014
1015         * tui/tui-hooks.c (tui_remove_hooks): Don't set
1016         deprecated_query_hook.
1017
1018 2019-08-16  Tom Tromey  <tom@tromey.com>
1019
1020         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1021         (tui_update_source_windows_with_line): Update.
1022         * tui/tui-source.h (struct tui_source_window)
1023         <show_symtab_source>: Declare.
1024         (tui_show_symtab_source): Don't declare.
1025         * tui/tui-source.c (tui_show_symtab_source): Rename from
1026         tui_show_symtab_source.
1027
1028 2019-08-16  Tom Tromey  <tom@tromey.com>
1029
1030         * tui/tui-winsource.h (struct tui_source_window_base)
1031         <set_contents>: Declare.
1032         * tui/tui-winsource.c
1033         (tui_source_window_base::update_source_window_as_is): Update.
1034         * tui/tui-source.h (struct tui_source_window) <set_contents>:
1035         Declare.
1036         (tui_set_source_content): Don't declare.
1037         * tui/tui-source.c (tui_source_window::set_contents): Rename from
1038         tui_set_source_content.
1039         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
1040         Declare.
1041         (tui_set_disassem_content): Don't declare.
1042         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
1043         tui_set_disassem_content.
1044
1045 2019-08-16  Tom Tromey  <tom@tromey.com>
1046
1047         * tui/tui-winsource.h (struct tui_source_window_base)
1048         <update_breakpoint_info>: Declare.
1049         (tui_update_breakpoint_info): Don't declare.
1050         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
1051         (tui_update_all_breakpoint_info): Update.
1052         (tui_source_window_base::update_breakpoint_info): Rename from
1053         tui_update_breakpoint_info.
1054         (tui_source_window_base::update_exec_info): Update.
1055
1056 2019-08-16  Tom Tromey  <tom@tromey.com>
1057
1058         * tui/tui-winsource.h (struct tui_source_window_base)
1059         <update_source_window>: Declare.
1060         (tui_update_source_window): Don't declare.
1061         * tui/tui-winsource.c
1062         (tui_source_window_base::update_source_window): Rename from
1063         tui_update_source_window.
1064         (tui_source_window_base::rerender): Update.
1065         * tui/tui-source.c (tui_source_window::maybe_update): Update.
1066         * tui/tui-disasm.c (tui_show_disassem)
1067         (tui_show_disassem_and_update_source)
1068         (tui_disasm_window::maybe_update): Update.
1069
1070 2019-08-16  Tom Tromey  <tom@tromey.com>
1071
1072         * tui/tui-winsource.h (struct tui_source_window_base)
1073         <update_source_window_as_is>: Declare.
1074         (tui_update_source_window_as_is): Don't declare.
1075         * tui/tui-winsource.c (tui_update_source_window): Update
1076         (tui_source_window_base::update_source_window_as_is): Rename from
1077         tui_update_source_window_as_is.
1078         (tui_source_window_base::refill): Update.
1079         * tui/tui-source.c (tui_show_symtab_source): Update.
1080         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
1081         Update.
1082
1083 2019-08-16  Tom Tromey  <tom@tromey.com>
1084
1085         * tui/tui-winsource.h (tui_update_source_window)
1086         (tui_update_source_window_as_is): Remove "noerror" parameter.
1087         * tui/tui-winsource.c (tui_update_source_window)
1088         (tui_update_source_window_as_is): Remove "noerror" parameter.
1089         (tui_update_source_windows_with_addr)
1090         (tui_update_source_windows_with_line)
1091         (tui_source_window_base::rerender)
1092         (tui_source_window_base::refill): Update.
1093         * tui/tui-source.h (tui_set_source_content)
1094         (tui_show_symtab_source): Remove "noerror" parameter.
1095         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
1096         parameter.
1097         (tui_show_symtab_source): Likewise.
1098         (tui_source_window::maybe_update): Update.
1099         * tui/tui-disasm.c (tui_show_disassem)
1100         (tui_show_disassem_and_update_source)
1101         (tui_disasm_window::do_scroll_vertical)
1102         (tui_disasm_window::maybe_update): Update.
1103
1104 2019-08-16  Tom Tromey  <tom@tromey.com>
1105
1106         * tui/tui.c (tui_is_window_visible): Update.
1107         * tui/tui-wingeneral.c (tui_make_window)
1108         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
1109         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
1110         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
1111         (tui_set_win_height_command, parse_scrolling_args): Update.
1112         * tui/tui-source.c (tui_source_window::style_changed): Update.
1113         * tui/tui-regs.c (tui_show_registers)
1114         (tui_data_window::first_data_item_displayed)
1115         (tui_data_window::delete_data_content_windows)
1116         (tui_check_register_values, tui_reg_command): Update.
1117         * tui/tui-disasm.c (tui_show_disassem): Update.
1118         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
1119         method.
1120         <is_visible>: Remove field.
1121         * tui/tui-data.c (tui_next_win, tui_prev_win)
1122         (tui_delete_invisible_windows): Update.
1123
1124 2019-08-16  Tom Tromey  <tom@tromey.com>
1125
1126         * tui/tui-winsource.h (struct tui_source_window_base)
1127         <m_has_locator>: Remove.
1128         * tui/tui-layout.c (show_source_disasm_command, show_data)
1129         (show_source_or_disasm_and_command): Update.
1130
1131 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
1132
1133         * NEWS (Other MI changes): New subsection.
1134         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
1135         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
1136         * arch-utils.c (default_get_pc_address_flags): New function.
1137         * arch-utils.h (default_get_pc_address_flags): New declaration.
1138         * gdbarch.sh: Add get_pc_address_flags.
1139         * gdbarch.c: Regenerate.
1140         * gdbarch.h: Likewise.
1141         * stack.c (print_pc): New function.
1142         (print_frame_info) (print_frame): Call print_pc.
1143
1144 2019-08-16  Tom de Vries  <tdevries@suse.de>
1145
1146         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
1147         print_objfile_section_info.
1148
1149 2019-08-15  Tom Tromey  <tom@tromey.com>
1150
1151         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
1152         calling update_cmdwin_start_line.
1153         * tui/tui-winsource.h (struct tui_source_window_base)
1154         <do_make_visible_with_new_height, set_new_height>: Don't declare.
1155         <rerender>: Declare.
1156         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
1157         Call rerender.
1158         (tui_source_window_base::set_new_height): Remove.
1159         (tui_source_window_base::rerender): Rename from
1160         do_make_visible_with_new_height.
1161         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
1162         resize method.
1163         (tui_win_info::make_invisible_and_set_new_height)
1164         (tui_win_info::make_visible_with_new_height): Remove.
1165         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
1166         Declare.
1167         * tui/tui-stack.c (tui_locator_window::rerender): New method.
1168         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
1169         do_make_visible_with_new_height>: Don't declare.
1170         <rerender>: Declare.
1171         * tui/tui-regs.c (tui_data_window::rerender): Rename from
1172         set_new_height.
1173         (tui_data_window::do_make_visible_with_new_height): Remove.
1174         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
1175         call tui_show_locator_content.
1176         (tui_gen_win_info::resize): Call rerender.
1177         (show_source_or_disasm_and_command): Don't call
1178         tui_show_locator_content.
1179         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
1180         method.
1181         (struct tui_win_info) <rerender>: Declare.
1182         <set_new_height, make_invisible_and_set_new_height,
1183         make_visible_with_new_height>: Don't declare.
1184         * tui/tui-data.c (tui_win_list::rerender): New method.
1185         * tui/tui-command.h (struct tui_cmd_window)
1186         <do_make_visible_with_new_height>: Don't declare.
1187         * tui/tui-command.c
1188         (tui_cmd_window::do_make_visible_with_new_height): Remove.
1189
1190 2019-08-15  Tom Tromey  <tromey@adacore.com>
1191
1192         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
1193         * ada-lang.c (ada_enum_name): Likewise.
1194
1195 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
1196
1197         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
1198         leading underscore.
1199         (GdbOutputErrorFile): Likewise.
1200         (global scope): Adjust constructor calls to GdbOutput{,Error}File
1201         accordingly.
1202         (execute_unwinders): Rename to have a leading underscore.
1203         (auto_load_packages): Likewise.
1204         (global scope): Adjust call to auto_load_packages accordingly.
1205         (GdbSetPythonDirectory): Likewise.
1206         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
1207         instead of execute_unwinders.
1208
1209 2019-08-15  Tom Tromey  <tom@tromey.com>
1210
1211         * tui/tui-layout.c (show_layout, show_source_disasm_command)
1212         (show_data): Don't change window visibility.
1213         (tui_gen_win_info::resize): Remove special case for command
1214         window.  Use wresize, when available.
1215         (show_source_or_disasm_and_command): Don't change window
1216         visibility.
1217         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
1218         <make_visible>: New method.
1219         * tui/tui-command.c (tui_cmd_window::resize): New method.
1220
1221 2019-08-15  Tom Tromey  <tom@tromey.com>
1222
1223         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
1224         (struct tui_source_windows): New.
1225         * tui/tui-winsource.c (tui_display_main): Update.
1226         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1227         (new_height_ok, parse_scrolling_args): Update.
1228         * tui/tui-layout.c (show_layout, show_data): Update.
1229         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
1230         (tui_add_to_source_windows): Don't declare.
1231         * tui/tui-data.c (source_windows, tui_source_windows)
1232         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
1233
1234 2019-08-15  Tom Tromey  <tom@tromey.com>
1235
1236         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
1237         Rename from reset.
1238         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
1239         * tui/tui-layout.c (show_source_disasm_command, show_data):
1240         Update.
1241         (tui_gen_win_info::resize): Rename.
1242         (show_source_or_disasm_and_command): Update.
1243         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
1244         reset.
1245
1246 2019-08-15  Tom Tromey  <tom@tromey.com>
1247
1248         * tui/tui-stack.c (tui_initialize_static_data): Remove.
1249         * tui/tui-interp.c (tui_interp::init): Don't call
1250         tui_initialize_static_data.
1251         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
1252
1253 2019-08-15  Tom Tromey  <tom@tromey.com>
1254
1255         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
1256         examine tui_win_list.
1257
1258 2019-08-15  Tom Tromey  <tom@tromey.com>
1259
1260         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
1261         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
1262         tui_clear_source_content.
1263         (tui_clear_source_content): Remove.
1264         (tui_source_window_base::do_erase_source_content): Hoist call to
1265         content.clear().
1266         * tui/tui-stack.c (tui_show_frame_info): Don't call
1267         tui_clear_source_content.
1268
1269 2019-08-15  Tom Tromey  <tom@tromey.com>
1270
1271         * tui/tui-winsource.h (struct tui_source_window_base)
1272         <do_erase_source_content>: New method.
1273         <erase_source_content>: New method.
1274         (tui_erase_source_content): Don't declare.
1275         * tui/tui-winsource.c (tui_clear_source_content): Update.
1276         (tui_source_window_base::do_erase_source_content): Rename from
1277         tui_erase_source_content.
1278         (tui_source_window_base::show_source_content): Update.
1279         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1280         * tui/tui-source.h (struct tui_source_window)
1281         <erase_source_content>: New method.
1282         * tui/tui-disasm.h (struct tui_disasm_window)
1283         <erase_source_content>: New method.
1284
1285 2019-08-15  Tom Tromey  <tom@tromey.com>
1286
1287         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
1288         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
1289         constructor.
1290         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
1291         * tui/tui-source.c (tui_set_source_content): Update.
1292         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1293
1294 2019-08-15  Tom Tromey  <tom@tromey.com>
1295
1296         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
1297         * tui/tui-winsource.c (tui_line_is_displayed): Move to
1298         tui-source.c.
1299         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
1300         Declare.
1301         * tui/tui-source.c (tui_source_window::line_is_displayed): New
1302         method.
1303         (tui_source_window::maybe_update): Update.
1304
1305 2019-08-15  Tom Tromey  <tom@tromey.com>
1306
1307         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
1308         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
1309         tui-disasm.c.
1310         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
1311         Declare.
1312         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
1313         method.
1314         (tui_disasm_window::maybe_update): Update.
1315
1316 2019-08-15  Tom Tromey  <tom@tromey.com>
1317
1318         * tui/tui-winsource.h (struct tui_source_window_base)
1319         <maybe_update>: Declare.
1320         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
1321         method.
1322         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
1323         Declare.
1324         * tui/tui-source.c (tui_source_window::maybe_update): New method.
1325         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
1326         Declare.
1327         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
1328
1329 2019-08-15  Tom Tromey  <tom@tromey.com>
1330
1331         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
1332
1333 2019-08-15  Tom Tromey  <tom@tromey.com>
1334
1335         * tui/tui-wingeneral.c: Include tui-stack.h.
1336         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
1337         (struct tui_locator_window): Move from tui-data.h.
1338         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
1339         (tui_initialize_static_data): Move from tui-data.c.
1340         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
1341         (struct tui_locator_window): Move to tui-stack.c.
1342         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
1343         (tui_initialize_static_data): Move to tui-stack.c.
1344
1345 2019-08-15  Tom Tromey  <tom@tromey.com>
1346
1347         * tui/tui-layout.c (show_source_disasm_command)
1348         (show_source_or_disasm_and_command): Use make_visible method, not
1349         tui_make_window.
1350         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
1351         Remove.
1352
1353 2019-08-15  Tom Tromey  <tom@tromey.com>
1354
1355         * tui/tui-wingeneral.h (tui_make_window): Update.
1356         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
1357         parameter.
1358         (tui_gen_win_info::make_visible): Update.
1359         * tui/tui-regs.c (tui_data_window::display_registers_from):
1360         Update.
1361         * tui/tui-layout.c (show_source_disasm_command)
1362         (show_source_or_disasm_and_command): Update.
1363         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
1364         (enum tui_box): Remove.
1365         (struct tui_win_info) <can_box>: New method.
1366         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
1367         method.
1368
1369 2019-08-15  Tom de Vries  <tdevries@suse.de>
1370
1371         * linux-nat-trad.c: Include gdbarch.h.
1372
1373 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
1374
1375         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
1376         register sizes.
1377
1378 2019-08-14  Tom Tromey  <tromey@adacore.com>
1379
1380         * darwin-nat.c: Include gdbarch.h.
1381         * darwin-nat-info.c: Include gdbarch.h.
1382
1383 2019-08-13  Tom Tromey  <tom@tromey.com>
1384
1385         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
1386         Remove.
1387         * tui/tui-data.c (tui_initialize_static_data): Update.
1388
1389 2019-08-13  Tom Tromey  <tom@tromey.com>
1390
1391         * tui/tui-winsource.h (struct tui_exec_info_window)
1392         <~tui_exec_info_window, maybe_allocate_content, get_content,
1393         m_content>: Remove.
1394         (struct tui_source_window_base) <set_exec_info_content,
1395         show_exec_info_content>: Don't declare.
1396         * tui/tui-winsource.c
1397         (tui_exec_info_window::maybe_allocate_content): Remove.
1398         (tui_source_window_base::update_exec_info): Rename from
1399         set_exec_info_content.
1400         (tui_source_window_base::show_exec_info_content)
1401         (tui_source_window_base::update_exec_info): Remove.
1402
1403 2019-08-13  Tom Tromey  <tom@tromey.com>
1404
1405         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
1406         declare.
1407         * tui/tui-winsource.c (tui_update_source_window_as_is)
1408         (tui_update_source_windows_with_addr, tui_erase_source_content):
1409         Update.
1410         (tui_clear_exec_info_content): Remove.
1411
1412 2019-08-13  Tom Tromey  <tom@tromey.com>
1413
1414         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
1415         declare.
1416         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
1417         call tui_erase_exec_info_content.
1418         (tui_clear_exec_info_content): Rename from
1419         tui_erase_exec_info_content.
1420         (tui_clear_exec_info_content): Delete.
1421
1422 2019-08-13  Tom Tromey  <tom@tromey.com>
1423
1424         * tui/tui-winsource.h (struct tui_source_window_base)
1425         <show_exec_info_content>: Declare.
1426         (tui_show_exec_info_content): Don't declare.
1427         * tui/tui-winsource.c
1428         (tui_source_window_base::show_exec_info_content): Rename from
1429         tui_show_exec_info_content.
1430         (tui_source_window_base::update_exec_info): Update.
1431
1432 2019-08-13  Tom Tromey  <tom@tromey.com>
1433
1434         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
1435         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
1436         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
1437         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
1438         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
1439         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
1440         ... here.
1441
1442 2019-08-13  Tom Tromey  <tom@tromey.com>
1443
1444         * tui/tui-winsource.h (struct tui_source_window_base)
1445         <update_exec_info>: Declare.
1446         (tui_update_exec_info): Don't declare.
1447         * tui/tui-winsource.c (tui_update_source_window_as_is)
1448         (tui_source_window_base::refresh_all)
1449         (tui_update_all_breakpoint_info): Update.
1450         (tui_source_window_base::update_exec_info): Rename from
1451         tui_update_exec_info.
1452         * tui/tui-stack.c (tui_show_frame_info): Update.
1453
1454 2019-08-13  Tom Tromey  <tom@tromey.com>
1455
1456         * tui/tui-winsource.h (struct tui_source_window_base)
1457         <set_exec_info_content>: Declare.
1458         (tui_set_exec_info_content): Don't declare.
1459         * tui/tui-winsource.c
1460         (tui_source_window_base::set_exec_info_content): Rename from
1461         tui_set_exec_info_content.
1462         (tui_update_exec_info): Update.
1463
1464 2019-08-13  Tom Tromey  <tom@tromey.com>
1465
1466         * tui/tui-winsource.h (struct tui_source_window_base)
1467         <show_source_content>: Declare.
1468         (tui_show_source_content): Don't declare.
1469         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1470         (tui_source_window_base::show_source_content): Rename from
1471         tui_show_source_content.
1472         (tui_source_window_base::refresh_all): Update.
1473         * tui/tui-layout.c (show_source_disasm_command)
1474         (show_source_or_disasm_and_command): Update.
1475
1476 2019-08-13  Tom Tromey  <tom@tromey.com>
1477
1478         * tui/tui-winsource.c (tui_erase_source_content)
1479         (tui_show_source_content, tui_source_window_base::refresh_all):
1480         Update.
1481         * tui/tui-wingeneral.h
1482         (tui_check_and_display_highlight_if_needed): Don't declare.
1483         * tui/tui-wingeneral.c
1484         (tui_win_info::check_and_display_highlight_if_needed): Rename from
1485         check_and_display_highlight_if_needed.
1486         * tui/tui-win.c (tui_rehighlight_all)
1487         (tui_win_info::make_visible_with_new_height): Update.
1488         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1489         (tui_data_window::erase_data_content)
1490         (tui_data_window::display_all_data): Update.
1491         * tui/tui-data.h (struct tui_win_info)
1492         <check_and_display_highlight_if_needed>: Declare.
1493
1494 2019-08-13  Tom Tromey  <tom@tromey.com>
1495
1496         * tui/tui-win.c (tui_resize_all): Call
1497         tui_delete_invisible_windows.
1498         * tui/tui-layout.c (show_layout): Call
1499         tui_delete_invisible_windows.
1500         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
1501         * tui/tui-data.c (tui_delete_invisible_windows): New function.
1502
1503 2019-08-13  Tom Tromey  <tom@tromey.com>
1504
1505         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
1506         tui_add_win_to_layout.
1507
1508 2019-08-13  Tom Tromey  <tom@tromey.com>
1509
1510         * tui/tui-layout.h (tui_default_win_height): Don't declare.
1511         * tui/tui-layout.c (tui_default_win_height): Now static.
1512
1513 2019-08-13  Tom Tromey  <tom@tromey.com>
1514
1515         * tui/tui-layout.c (show_layout): Unify all layout cases into a
1516         single switch.
1517         (show_source_disasm_command, show_source_or_disasm_and_command):
1518         Don't check current layout.
1519
1520 2019-08-13  Tom Tromey  <tom@tromey.com>
1521
1522         * tui/tui-wingeneral.c (make_all_visible): Remove.
1523         (tui_make_all_invisible): Simplify.
1524         * tui/tui-layout.c (tui_make_all_invisible): Move from
1525         tui-wingeneral.c; simplify.
1526         (show_layout): Hoist call to tui_make_all_invisible.
1527         (show_data): Don't call tui_make_all_invisible.
1528
1529 2019-08-13  Tom Tromey  <tom@tromey.com>
1530
1531         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
1532         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
1533
1534 2019-08-13  Tom Tromey  <tom@tromey.com>
1535
1536         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
1537         tui-data.c.
1538         (show_source_disasm_command, show_data)
1539         (show_source_or_disasm_and_command): Don't use
1540         tui_set_current_layout_to.
1541         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
1542         * tui/tui-data.c (current_layout, tui_current_layout): Move to
1543         tui-layout.c.
1544         (tui_set_current_layout_to): Remove.
1545
1546 2019-08-13  Tom Tromey  <tom@tromey.com>
1547
1548         * tui/tui-layout.c (tui_set_layout): Update.
1549         * tui/tui-data.h (struct tui_layout_def): Remove.
1550         (tui_layout_def): Don't declare.
1551         * tui/tui-data.c (layout_def): Remove.
1552         (tui_layout_def): Remove.
1553
1554 2019-08-13  Tom Tromey  <tom@tromey.com>
1555
1556         * tui/tui-winsource.h (struct tui_source_window_base)
1557         <clear_detail>: No longer "override".
1558         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
1559         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
1560         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
1561         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
1562         Remove.
1563         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
1564
1565 2019-08-13  Tom Tromey  <tromey@adacore.com>
1566
1567         * tracepoint.c: Don't include readline.h or history.h.
1568
1569 2019-08-12  Tom Tromey  <tom@tromey.com>
1570
1571         * configure: Rebuild.
1572         * configure.ac: Check for readline 7.
1573         * NEWS: Mention readline 7 requirement.
1574         * README: Update.
1575
1576 2019-08-12  Tom Tromey  <tom@tromey.com>
1577
1578         * mingw-hdep.c (gdb_select): Remove readline hack.
1579
1580 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1581
1582         * blockframe.c (find_pc_partial_function): Set *block to nullptr
1583         when the function fails.
1584
1585 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
1586
1587         * s390-tdep.c (s390_type_align): New function.
1588         (s390_gdbarch_init): Set it as type_align gdbarch method.
1589
1590 2019-08-09  Tom de Vries  <tdevries@suse.de>
1591
1592         PR gdb/24591
1593         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
1594         pc_low with relocation offset.
1595
1596 2019-08-07  Tom Tromey  <tromey@adacore.com>
1597
1598         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1599         (print_frame_args): Update.
1600         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
1601         Update.
1602         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1603         * frame.h (struct frame_arg): Add initializers.
1604         <error>: Now a unique_xmalloc_ptr.
1605
1606 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
1607
1608         * NEWS: Expand the Pointer Authentication entry.
1609         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
1610         (aarch64_frame_unmask_lr): ... to this.
1611         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
1612         Call aarch64_frame_unmask_lr.
1613         * frame.c (struct frame_info): Add "masked" variable.
1614         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
1615         (fprint_frame): Check for masked pc.
1616         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
1617         declarations.
1618         * python/py-framefilter.c (py_print_frame): Check for masked pc.
1619         * stack.c (print_frame): Check for masked pc.
1620
1621 2019-08-06  Tom Tromey  <tom@tromey.com>
1622
1623         * stabsread.c (patch_block_stabs, read_one_struct_field)
1624         (read_enum_type): Use obstack_strndup.
1625         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
1626         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
1627         * dwarf2read.c (guess_full_die_structure_name)
1628         (anonymous_struct_prefix): Use obstack_strndup.
1629         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
1630         * c-exp.y (yylex): Use obstack_strndup.
1631         * ada-exp.y (write_object_renaming, write_ambiguous_var)
1632         (write_var_or_type): Use obstack_strndup.
1633
1634 2019-08-06  Tom Tromey  <tom@tromey.com>
1635
1636         * symfile.c (reread_symbols): Use obstack_strdup.
1637         * stabsread.c (read_type): Use obstack_strdup.
1638         * gdb_obstack.h (obstack_strdup): New overload.
1639         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
1640         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
1641         (dwarf2_canonicalize_name): Use obstack_strdup.
1642         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
1643         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
1644         Use obstack_strdup.
1645
1646 2019-08-06  Tom Tromey  <tom@tromey.com>
1647
1648         * gdb_obstack.h (obstack_strdup): Define.
1649         * gdb_obstack.c (obstack_strdup): Don't define.
1650
1651 2019-08-06  Tom Tromey  <tom@tromey.com>
1652
1653         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
1654         obstack_strdup.
1655         * typeprint.c (typedef_hash_table::find_global_typedef): Use
1656         obstack_strdup.
1657         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
1658         * stabsread.c (common_block_start): Use obstack_strdup.
1659         * objfiles.c (set_objfile_main_name, objfile): Use
1660         obstack_strdup.
1661         * namespace.c (add_using_directive): Use obstack_strdup.
1662         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
1663         * jit.c (finalize_symtab): Use obstack_strdup.
1664         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
1665         (guess_partial_die_structure_name, partial_die_info::fixup)
1666         (dwarf2_name): Use obstack_strdup.
1667         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
1668         obstack_strdup.
1669         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
1670         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1671         obstack_strdup.
1672         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
1673
1674 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1675
1676         * unittests/help-doc-selftests.c: New file.
1677         * Makefile.in: Add the new file.
1678
1679 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1680
1681         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
1682         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
1683         the full first line, except when FOR_VALUE_PREFIX.  In this case,
1684         the trailing '.' is not output, and the first character is uppercased.
1685         (print_help_for_command): Update call to print_doc_line.
1686         (print_doc_of_command): Likewise.
1687         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
1688         * cli/cli-option.c (append_indented_doc): Do not append newline.
1689         (build_help_option): Append newline after first appended_indented_doc
1690         only if a second call is done.
1691         (build_help): Append 2 new lines before each option, except the first
1692         one.
1693         * compile/compile.c (_initialize_compile): Add new lines after
1694         %OPTIONS%, when not at the end of the help.
1695         Change help doc or code
1696         producing the help doc to respect the invariants.
1697         * maint-test-options.c (_initialize_maint_test_options): Likewise.
1698         Also removed the new line after 'Options:', as all other commands
1699         do not put an empty line between 'Options:' and the first option.
1700         * printcmd.c (_initialize_printcmd): Likewise.
1701         * stack.c (_initialize_stack): Likewise.
1702         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
1703         incorrectly telling COMMAND is optional.
1704         * ada-lang.c (_initialize_ada_language): Change help doc or code
1705         producing the help doc to respect the invariants.
1706         * ada-tasks.c (_initialize_ada_tasks): Likewise.
1707         * breakpoint.c (_initialize_breakpoint): Likewise.
1708         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
1709         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
1710         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
1711         * cli/cli-style.c (cli_style_option::add_setshow_commands,
1712         _initialize_cli_style): Likewise.
1713         * corelow.c (core_target_info): Likewise.
1714         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
1715         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
1716         * filesystem.c (_initialize_filesystem): Likewise.
1717         * frame.c (_initialize_frame): Likewise.
1718         * gnu-nat.c (add_task_commands): Likewise.
1719         * infcall.c (_initialize_infcall): Likewise.
1720         * infcmd.c (_initialize_infcmd): Likewise.
1721         * interps.c (_initialize_interpreter): Likewise.
1722         * language.c (_initialize_language): Likewise.
1723         * linux-fork.c (_initialize_linux_fork): Likewise.
1724         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
1725         * maint.c (_initialize_maint_cmds): Likewise.
1726         * memattr.c (_initialize_mem): Likewise.
1727         * printcmd.c (_initialize_printcmd): Likewise.
1728         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
1729         _RegEx): Likewise.
1730         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
1731         * record-btrace.c (_initialize_record_btrace): Likewise.
1732         * record-full.c (_initialize_record_full): Likewise.
1733         * record.c (_initialize_record): Likewise.
1734         * regcache-dump.c (_initialize_regcache_dump): Likewise.
1735         * regcache.c (_initialize_regcache): Likewise.
1736         * remote.c (add_packet_config_cmd, init_remote_threadtests,
1737         _initialize_remote): Likewise.
1738         * ser-tcp.c (_initialize_ser_tcp): Likewise.
1739         * serial.c (_initialize_serial): Likewise.
1740         * skip.c (_initialize_step_skip): Likewise.
1741         * source.c (_initialize_source): Likewise.
1742         * stack.c (_initialize_stack): Likewise.
1743         * symfile.c (_initialize_symfile): Likewise.
1744         * symtab.c (_initialize_symtab): Likewise.
1745         * target-descriptions.c (_initialize_target_descriptions): Likewise.
1746         * top.c (init_main): Likewise.
1747         * tracefile-tfile.c (tfile_target_info): Likewise.
1748         * tracepoint.c (_initialize_tracepoint): Likewise.
1749         * tui/tui-win.c (_initialize_tui_win): Likewise.
1750         * utils.c (add_internal_problem_command): Likewise.
1751         * valprint.c (value_print_option_defs): Likewise.
1752
1753 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
1754
1755         PR build/24886
1756         * configure.ac: Drop enable-libmcheck support.
1757         * configure, config.in: Rebuild.
1758         * libmcheck.m4: Remove.
1759         * acinclude.m4: Don't include it.
1760         * Makefile.in: Don't distribute it.
1761         * top.c (print_gdb_configuration): Don't mention it.
1762
1763 2019-08-06  Tom Tromey  <tom@tromey.com>
1764
1765         * utils.c (set_output_style): Sometimes pass stream to
1766         emit_style_escape.
1767         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
1768         * record-btrace.c (btrace_insn_history): Update.
1769         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
1770         method.
1771         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
1772         Update initializers.
1773         <m_uiout>: New field.
1774         <m_di>: Move lower.
1775         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1776         Remove "uiout" parameter.
1777         (dump_insns): Update.
1778         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
1779         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
1780
1781 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
1782
1783         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
1784         (error_in_psymtab_expansion): Likewise.
1785         (lookup_symbol_via_quick_fns): Likewise.
1786         (basic_lookup_transparent_type_quick): Likewise.
1787         (basic_lookup_transparent_type_1): Likewise.
1788
1789 2019-08-06  Tom Tromey  <tromey@adacore.com>
1790
1791         * source.c (last_source_error): Now bool.
1792         (print_source_lines_base): Make "noprint" bool.  Only open
1793         source file when last_source_visited changes.
1794
1795 2019-08-06  Tom Tromey  <tromey@adacore.com>
1796
1797         * annotate.c (annotate_source_line): Use g_source_cache.
1798         * source-cache.c (source_cache::get_plain_source_lines): Change
1799         parameters.  Populate m_offset_cache.
1800         (source_cache::ensure): New method.
1801         (source_cache::get_line_charpos): New method.
1802         (extract_lines): Move lower.  Change parameters.
1803         (source_cache::get_source_lines): Move lower.
1804         * source-cache.h (class source_cache): Update comment.
1805         <get_line_charpos>: New method.
1806         <get_source_lines>: Update comment.
1807         <clear>: Clear m_offset_cache.
1808         <get_plain_source_lines>: Change parameters.
1809         <ensure>: New method
1810         <m_offset_cache>: New member.
1811         * source.c (forget_cached_source_info_for_objfile): Update.
1812         (info_source_command): Use g_source_cache.
1813         (find_source_lines, open_source_file_with_line_charpos): Remove.
1814         (print_source_lines_base, search_command_helper): Use g_source_cache.
1815         * source.h (open_source_file_with_line_charpos): Don't declare.
1816         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
1817         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
1818         Use g_source_cache.
1819
1820 2019-08-06  Tom Tromey  <tromey@adacore.com>
1821
1822         * source-cache.c (source_cache::get_plain_source_lines):
1823         Remove "first_line" and "last_line" parameters.
1824         (source_cache::get_source_lines): Cache plain text.
1825         * source-cache.h (class source_cache)
1826         <get_plain_source_lines>: Update.
1827
1828 2019-08-06  Tom Tromey  <tromey@adacore.com>
1829
1830         * source-cache.c (extract_lines): No longer a method.
1831         Changed type of parameter.  Include final newline.
1832         (selftests::extract_lines_test): New function.
1833         (_initialize_source_cache): Likewise.
1834         * source-cache.h (class source_cache)
1835         <extract_lines>: Don't declare.
1836
1837 2019-08-06  Tom Tromey  <tromey@adacore.com>
1838
1839         * breakpoint.c (init_breakpoint_sal): Update.
1840         (breakpoint): Update.
1841         * breakpoint.h (struct breakpoint) <filter>: Now a
1842         unique_xmalloc_ptr.
1843
1844 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1845
1846         * NEWS: Mention dictionary access on blocks.
1847         * python/py-block.c (blpy_getitem): New function.
1848         (block_object_as_mapping): New struct.
1849         (block_object_type): Use new struct for tp_as_mapping field.
1850
1851 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1852
1853         * objfiles.h (objfile): Add a comment describing partial symbols.
1854
1855 2019-08-05  Tom Tromey  <tromey@adacore.com>
1856
1857         * compile/compile.c (_initialize_compile): Use _(), not N_().
1858         * thread.c (_initialize_thread): Use _(), not N_().
1859         * stack.c (_initialize_stack): Use _(), not N_().
1860         * printcmd.c (_initialize_printcmd): Use _(), not N_().
1861
1862 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
1863
1864         * dwarf2read.c (struct dw2_symtab_iterator):
1865         <want_specific_block>: Remove.
1866         <block_index>: Change type to gdb::optional.
1867         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
1868         change type of BLOCK_INDEX parameter to gdb::optional.
1869         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
1870         (dw2_lookup_symbol): Don't pass argument for
1871         WANT_SPECIFIC_BLOCK.
1872         (dw2_expand_symtabs_for_function): Don't pass argument for
1873         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
1874         (class dw2_debug_names_iterator)
1875         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
1876         parameter, change BLOCK_INDEX type to gdb::optional.
1877         <m_want_specific_block>: Remove.
1878         <m_block_index>: Change type to gdb::optional.
1879         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
1880         gdb::optional.  Re-write in function of gdb::optional.
1881         (dw2_debug_names_lookup_symbol): Don't pass argument for
1882         WANT_SPECIFIC_BLOCK.
1883         (dw2_debug_names_expand_symtabs_for_function): Don't pass
1884         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
1885         BLOCK_INDEX.
1886
1887 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1888
1889         * NEWS: Mention changes to "info sources" command.
1890
1891 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1892
1893         * symtab.c (filename_partial_match_opts): New struct type.
1894         (struct output_source_filename_data): New members
1895         regexp, c_regexp, partial_match.
1896         (output_source_filename): Use new members to decide to print file.
1897         (info_sources_option_defs): New variable.
1898         (make_info_sources_options_def_group, print_info_sources_header,
1899         info_sources_command_completer):
1900         New functions.
1901         (info_sources_command): Read new optional arguments.
1902         (_initialize_symtab): Update info sources help.
1903
1904 2019-08-02  Alexandre Oliva <oliva@adacore.com>
1905
1906         * ada-lang.c (exception_support_info_v0): Renamed from...
1907         (default_exception_support_info): ... this.  Create new
1908         definition for v1.
1909         (ada_has_this_exception_support): Look up catch_handlers_sym.
1910         (ada_exception_support_info_sniffer): Try v0 after default.
1911
1912 2019-08-01  Tom Tromey  <tromey@adacore.com>
1913
1914         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
1915         gdbarch.h.
1916
1917 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
1918
1919         * s12z-tdep.c: Fix include path for s12z-opc.h.
1920
1921 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
1922
1923         * NEWS: Require GNU make 3.82.
1924
1925 2019-07-16  Tom Tromey  <tom@tromey.com>
1926
1927         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
1928         declare.
1929
1930 2019-07-30  Tom Tromey  <tromey@adacore.com>
1931
1932         * block.c (contained_in): Remove BLOCK_FUNCTION check.
1933
1934 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
1935
1936         * printcmd.c (print_address_symbolic): Print negative offsets.
1937         (build_address_symbolic): Force signed arithmetic when computing
1938         offset.
1939
1940 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
1941
1942         PR/24474: Add a function to lookup static variables.
1943         * NEWS: Mention this new function.
1944         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
1945         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
1946         * python/python.c (python_GdbMethods): Add new function.
1947
1948 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
1949
1950         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1951         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1952         (objfpy_lookup_static_symbol): New function.
1953         (objfile_object_methods): Add new functions.
1954
1955 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1956
1957         * NEWS: Mention 'set|show print frame-info'.  Mention new
1958         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
1959         backtrace argument.  Mention that python frame filtering code
1960         is now consistent with what 'backtrace' command prints.
1961
1962 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1963
1964         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1965         comments.
1966         (print_frame_info_auto, print_frame_info_source_line,
1967         print_frame_info_location, print_frame_info_source_and_location,
1968         print_frame_info_location_and_address, print_frame_info_short_location):
1969         New declarations.
1970         (struct frame_print_options): New member print_frame_info.
1971         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1972         * stack.h (get_user_print_what_frame_info): New declaration.
1973         (frame_show_address): New declaration.
1974         * stack.c (print_frame_arguments_choices): New value 'presence'.
1975         (print_frame_info_auto, print_frame_info_source_line,
1976         print_frame_info_location, print_frame_info_source_and_location,
1977         print_frame_info_location_and_address, print_frame_info_short_location,
1978         print_frame_info_choices, print_frame_info_print_what): New definitions.
1979         (print_frame_args): Only print dots for args if print frame-arguments
1980         is 'presence'.
1981         (frame_print_option_defs): New element for "frame-info".
1982         (get_user_print_what_frame_info): New function.
1983         (frame_show_address): Make non static.  Move comment to stack.h.
1984         (print_frame_info_to_print_what): New function.
1985         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
1986         to decide what to print.
1987         (backtrace_command_1): Handle the new print_frame_arguments_presence
1988         value.
1989         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1990         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1991         (py_print_frame): In non-mi mode, use LOCATION as default for
1992         print_what, similarly to frame information printed directly by
1993         backtrace command. Handle frame-info user option in non MI mode.
1994
1995 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1996
1997         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1998         Add case for debugging 32-bit target on 64-bit host.  Revise
1999         comment.
2000
2001 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2002
2003         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
2004         instead of find_function_entry_range_from_pc.
2005
2006 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2007
2008         * stack.c (find_frame_funname): Remove code which preferred
2009         minsym over symtab sym in "certain pathological cases".
2010
2011         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
2012         parameter.  Change type of "do_demangle" to bool.
2013         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2014         Pass suitable "prefer_sym_over_minsym" flag to
2015         build_address_symbolic().  Don't output "+" for negative offsets.
2016         * printcmd.c (print_address_symbolic): Update invocation of
2017         build_address_symbolic to include a "prefer_sym_over_minsym"
2018         flag.
2019         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
2020         Restrict cases in which use of minimal symbol is preferred to that
2021         of a found symbol.  Update comments.
2022
2023         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
2024         for entry pc when entry pc is out of range for that FDE.
2025
2026 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
2027
2028         PR gdb/24839:
2029         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
2030         type.
2031
2032 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
2033
2034         * python/py-objfile.c (add_separate_debug_file): Fix comment about
2035         this function's Python signature.
2036
2037
2038 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
2039
2040         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
2041         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2042         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2043         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
2044         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
2045
2046
2047 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
2048
2049         * h8300-tdep.c (h8300_register_name_common): New.
2050         h8300_register_name): Use h8300_register_name_common.
2051         (h8300s_register_name): Likewise.
2052         (h8300sx_register_name): Likewise.
2053         (h8300h_register_nam): New.
2054         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
2055
2056
2057 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
2058
2059         * arm-tdep.c (arm_skip_cmse_entry): New function.
2060         (arm_is_sgstubs_section): New function.
2061         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
2062
2063 2019-07-22  Tom Tromey  <tom@tromey.com>
2064
2065         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
2066         Don't self-assign.
2067
2068 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2069
2070         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
2071         type_print.
2072
2073 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2074
2075         * symtab.c (search_symbols): Adjust msymbol matching type arrays
2076         so that GDB doesn't match any msymbols when searching in the
2077         TYPES_DOMAIN.
2078         (print_symbol_info): Print using typedef_print or type_print based
2079         on the type of the symbol.  Add updated FIXME comment moved from...
2080         (_initialize_symtab): ... move and update FIXME comment to above.
2081
2082 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2083
2084         * NEWS: Mention adding -q option to "info types".
2085         * symtab.c (struct info_types_options): New struct.
2086         (info_types_options_defs): New variable.
2087         (make_info_types_options_def_group): New function.
2088         (info_types_command): Use gdb::option framework to parse options.
2089         (info_types_command_completer): New function.
2090         (_initialize_symtab): Extend the help text on "info types" and
2091         register command completer.
2092
2093 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
2094
2095         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
2096         (lookup_symbol_in_objfile): Change int to block_enum and add a
2097         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
2098
2099 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
2100
2101         * MAINTAINERS (Write After Approval): Add self.
2102
2103 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2104
2105         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
2106         instruction to the dummy code region.
2107
2108 2019-07-19  Tom Tromey  <tromey@adacore.com>
2109
2110         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
2111         (ARGSUSED, PARAMS, __func__): Remove rules.
2112
2113 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2114
2115         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
2116         * features/arm/arm-with-iwmmxt.c: Remove.
2117         * features/arm/arm-with-iwmmxt.xml: Remove.
2118         * features/arm/arm-with-m-fpa-layout.c: Remove.
2119         * features/arm/arm-with-m-fpa-layout.xml: Remove.
2120         * features/arm/arm-with-m-vfp-d16.c: Remove.
2121         * features/arm/arm-with-m-vfp-d16.xml: Remove.
2122         * features/arm/arm-with-m.c: Remove.
2123         * features/arm/arm-with-m.xml: Remove.
2124         * features/arm/arm-with-neon.c: Remove.
2125         * features/arm/arm-with-neon.xml: Remove.
2126         * features/arm/arm-with-vfpv2.c: Remove.
2127         * features/arm/arm-with-vfpv2.xml: Remove.
2128         * features/arm/arm-with-vfpv3.c: Remove.
2129         * features/arm/arm-with-vfpv3.xml: Remove.
2130
2131 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2132
2133         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
2134
2135 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2136
2137         * arch/aarch32.c (aarch32_create_target_description): Create
2138         target descriptions using features.
2139         * arch/arm.c (arm_create_target_description)
2140         (arm_create_mprofile_target_description): Likewise.
2141         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
2142
2143 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2144
2145         * Makefile.in: Add new files.
2146         * aarch32-tdep.c: New file.
2147         * aarch32-tdep.h: New file.
2148         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2149         Call aarch32_read_description.
2150         * arch/aarch32.c: New file.
2151         * arch/aarch32.h: New file.
2152         * arch/arm.c (arm_create_target_description)
2153         (arm_create_mprofile_target_description): New function.
2154         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
2155         (arm_create_target_description)
2156         (arm_create_mprofile_target_description): New declaration.
2157         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
2158         read_description functions.
2159         * arm-linux-nat.c (arm_linux_nat_target::read_description):
2160         Likewise.
2161         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2162         * arm-tdep.c (tdesc_arm_list): New variable.
2163         (arm_register_g_packet_guesses): Call create description functions.
2164         (arm_read_description) (arm_read_mprofile_description): New
2165         function.
2166         * arm-tdep.h (arm_read_description)
2167         (arm_read_mprofile_description): Add declaration.
2168         * configure.tgt: Add new files.
2169
2170 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
2171
2172         * top.c (new_ui_command): Open specified terminal just once.
2173
2174 2019-07-18  Tom Tromey  <tromey@adacore.com>
2175
2176         * symtab.c (main_name): Constify return type.
2177         * symfile.c (set_initial_language): Update.
2178         * symtab.h (main_name): Constify return type.
2179
2180 2019-07-17  Tom Tromey  <tom@tromey.com>
2181
2182         * tui/tui-winsource.c (tui_update_source_window)
2183         (tui_update_source_window_as_is)
2184         (tui_update_source_windows_with_line): Remove return.
2185         * tui/tui-disasm.c (tui_show_disassem)
2186         (tui_show_disassem_and_update_source): Remove return.
2187         * tui/tui.c (tui_reset): Remove return.
2188         * tui/tui-wingeneral.c
2189         (tui_check_and_display_highlight_if_needed): Remove return.
2190
2191 2019-07-17  Tom Tromey  <tom@tromey.com>
2192
2193         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
2194
2195 2019-07-17  Tom Tromey  <tom@tromey.com>
2196
2197         * tui/tui-winsource.h (struct tui_exec_info_window)
2198         (struct tui_source_window_base): Move from tui-data.h.
2199         * tui/tui-winsource.c: Move many method definitions from
2200         elsewhere.  Remove "structuring" comments.
2201         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
2202         (tui_source_window_base::refresh_window): Move to
2203         tui-winsource.c.
2204         * tui/tui-win.c (tui_source_window_base::refresh_all)
2205         (tui_source_window_base::update_tab_width)
2206         (tui_source_window_base::set_new_height)
2207         (tui_source_window_base::do_make_visible_with_new_height): Move to
2208         tui-winsource.c.
2209         * tui/tui-source.h: Update.
2210         * tui/tui-source.c (tui_source_window_base::reset): Move to
2211         tui-winsource.c.
2212         * tui/tui-disasm.h: Update.
2213         * tui/tui-data.h (struct tui_exec_info_window): Move to
2214         tui-winsource.h.
2215         (struct tui_source_window_base): Likewise.
2216         * tui/tui-data.c (tui_source_window_base::clear_detail)
2217         (tui_source_window_base, ~tui_source_window_base): Move to
2218         tui-winsource.c.
2219
2220 2019-07-17  Tom Tromey  <tom@tromey.com>
2221
2222         * tui/tui-win.c (tui_resize_all)
2223         (tui_source_window_base::update_tab_width)
2224         (tui_adjust_win_heights): Update.
2225         (tui_win_info::make_invisible_and_set_new_height): Rename from
2226         make_invisible_and_set_new_height.
2227         * tui/tui-data.h (struct tui_win_info)
2228         <make_invisible_and_set_new_height>: New method.
2229
2230 2019-07-17  Tom Tromey  <tom@tromey.com>
2231
2232         * tui/tui.c: Update.
2233         * tui/tui-source.h (struct tui_source_window): Move from
2234         tui-data.h.
2235         * tui/tui-layout.c: Update.
2236         * tui/tui-disasm.c: Update.
2237         * tui/tui-data.h (struct tui_source_window): Move to
2238         tui-source.h.
2239
2240 2019-07-17  Tom Tromey  <tom@tromey.com>
2241
2242         * tui/tui-disasm.h (struct tui_disasm_window): Move from
2243         tui-data.h.
2244         * tui/tui-data.h (struct tui_disasm_window): Move to
2245         tui-disasm.h.
2246
2247 2019-07-17  Tom Tromey  <tom@tromey.com>
2248
2249         * tui/tui-regs.h (struct tui_data_item_window): Move from
2250         tui-data.h.
2251         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
2252         * tui/tui-data.h (struct tui_data_item_window): Move to
2253         tui-regs.h.
2254         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
2255
2256 2019-07-17  Tom Tromey  <tom@tromey.com>
2257
2258         * tui/tui.c: Update.
2259         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
2260         (tui_cmd_window::max_height): Move to tui-command.c.
2261         * tui/tui-layout.c: Update.
2262         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
2263         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
2264         tui-command.c.
2265         * tui/tui-command.h (struct tui_cmd_window): Move from
2266         tui-data.h.
2267         * tui/tui-command.c: Remove "structuring" comments.
2268         (tui_cmd_window::clear_detail)
2269         (tui_cmd_window::do_make_visible_with_new_height)
2270         (tui_cmd_window::max_height): Move from elsewhere.
2271
2272 2019-07-17  Tom Tromey  <tom@tromey.com>
2273
2274         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
2275         Now static.
2276         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
2277         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
2278
2279 2019-07-17  Tom Tromey  <tom@tromey.com>
2280
2281         * tui/tui.c: Update.
2282         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
2283         tui-regs.c.
2284         * tui/tui-windata.h: Remove file.
2285         * tui/tui-windata.c: Remove file.
2286         * tui/tui-win.c (tui_data_window::set_new_height)
2287         (tui_data_window::do_make_visible_with_new_height): Move to
2288         tui-regs.c.
2289         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
2290         * tui/tui-regs.c: Remove "structuring" comments.
2291         (tui_data_window::first_data_item_displayed)
2292         (tui_data_window::delete_data_content_windows)
2293         (tui_data_window::erase_data_content)
2294         (tui_data_window::display_all_data)
2295         (tui_data_window::refresh_all)
2296         (tui_data_window::do_scroll_vertical)
2297         (tui_data_window::clear_detail, tui_data_window::set_new_height)
2298         (tui_data_window::do_make_visible_with_new_height)
2299         (tui_data_window::refresh_window): Move from elsewhere.
2300         (_initialize_tui_regs): Move to end of file.
2301         * tui/tui-layout.c: Update.
2302         * tui/tui-hooks.c: Update.
2303         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
2304         * tui/tui-data.c (tui_data_window::clear_detail): Move to
2305         tui-regs.c.
2306         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
2307
2308 2019-07-17  Tom Tromey  <tom@tromey.com>
2309
2310         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
2311         seen.
2312
2313 2019-07-17  Tom Tromey  <tom@tromey.com>
2314
2315         * tui/tui-win.c (tui_source_window_base::set_new_height)
2316         (tui_source_window_base::do_make_visible_with_new_height): Use
2317         m_has_locator field directly.
2318         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
2319         method.
2320         (struct tui_source_window_base) <has_locator>: Likewise.
2321
2322 2019-07-17  Tom Tromey  <tom@tromey.com>
2323
2324         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
2325         Don't declare.
2326         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
2327         Remove.
2328         * tui/tui-win.c (tui_source_window_base::set_new_height)
2329         (tui_source_window_base::set_new_height)
2330         (make_invisible_and_set_new_height)
2331         (tui_source_window_base::do_make_visible_with_new_height)
2332         (tui_source_window_base::do_make_visible_with_new_height):
2333         Update.
2334         * tui/tui-layout.c (show_source_disasm_command, show_data)
2335         (show_source_or_disasm_and_command): Update.
2336         * tui/tui-layout.c (show_layout): Update.
2337
2338 2019-07-17  Tom Tromey  <tom@tromey.com>
2339
2340         * tui/tui-layout.c (make_data_window): Remove.
2341         (show_data): Unify creation and re-initialization cases.
2342
2343 2019-07-17  Tom Tromey  <tom@tromey.com>
2344
2345         * tui/tui-layout.c (make_source_window, make_disasm_window):
2346         Remove.
2347         (show_data): Unify creation and re-initialization cases.
2348
2349 2019-07-17  Tom Tromey  <tom@tromey.com>
2350
2351         * tui/tui-layout.c (make_command_window): Remove.
2352         (show_source_disasm_command, show_source_or_disasm_and_command):
2353         Unify creation and re-initialization cases.
2354
2355 2019-07-17  Tom Tromey  <tom@tromey.com>
2356
2357         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
2358         creation and re-initialization cases.
2359
2360 2019-07-17  Tom Tromey  <tom@tromey.com>
2361
2362         * tui/tui-regs.c (tui_get_register): Return void.
2363
2364 2019-07-17  Tom Tromey  <tom@tromey.com>
2365
2366         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
2367         Simplify.
2368
2369 2019-07-17  Tom Tromey  <tom@tromey.com>
2370
2371         * tui/tui-layout.c (show_source_disasm_command): Simplify window
2372         resetting.
2373
2374 2019-07-17  Tom Tromey  <tom@tromey.com>
2375
2376         * tui/tui.h (tui_set_layout_by_name): Don't declare.
2377         * tui/tui-regs.c (tui_reg_layout): New function.
2378         (tui_show_registers, tui_reg_command): Use it.
2379         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
2380         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
2381         parameters.
2382         (tui_layout_command): Remove.
2383
2384 2019-07-17  Tom Tromey  <tom@tromey.com>
2385
2386         * tui/tui-layout.h (tui/tui-layout): Return void.
2387         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
2388
2389 2019-07-17  Tom Tromey  <tom@tromey.com>
2390
2391         * tui/tui-layout.c (show_source_disasm_command, show_data):
2392         Update.
2393         (reset_locator): Remove.
2394         (show_source_or_disasm_and_command): Update.
2395
2396 2019-07-17  Tom Tromey  <tom@tromey.com>
2397
2398         * tui/tui-source.c (tui_source_window_base::reset): Remove
2399         win_type parameter.
2400         * tui/tui-layout.c (make_command_window, make_source_window)
2401         (make_disasm_window, make_data_window)
2402         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
2403         (reset_locator, show_source_or_disasm_and_command): Update.
2404         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
2405         win_type parameter.
2406         (struct tui_source_window_base) <reset>: Likewise.
2407
2408 2019-07-17  Tom Tromey  <tom@tromey.com>
2409
2410         * tui/tui-layout.c (show_source_disasm_command): Use
2411         reset_locator.
2412         (reset_locator): New function.
2413         (init_and_make_win): Remove.
2414         (show_source_or_disasm_and_command): Use reset_locator.
2415
2416 2019-07-17  Tom Tromey  <tom@tromey.com>
2417
2418         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
2419         condition.
2420         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
2421         Remove condition.
2422         * tui/tui-source.c (tui_source_window_base::reset): New method.
2423         * tui/tui-layout.c (make_command_window): Don't call
2424         init_and_make_win.
2425         (make_source_window, make_disasm_window): Don't call
2426         make_source_or_disasm_window.
2427         (make_data_window): Don't call init_and_make_win.  Change calling
2428         convention.
2429         (show_source_disasm_command, show_data): Simplify.
2430         (make_source_or_disasm_window): Remove.
2431         (show_source_or_disasm_and_command): Simplify.
2432         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
2433         (struct tui_source_window_base) <reset>: Likewise.
2434         <execution_info>: Remove initializer.
2435         * tui/tui-data.c (tui_source_window_base): Initialize
2436         execution_info.
2437
2438 2019-07-17  Tom Tromey  <tom@tromey.com>
2439
2440         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
2441         variable.
2442
2443 2019-07-17  Tom Tromey  <tom@tromey.com>
2444
2445         * tui/tui.c (tui_rl_other_window): Update.
2446         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
2447         superclass method first.  Always iterate over regs_content.
2448         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
2449         method.
2450         * tui/tui-win.c (tui_set_focus_command): Update.
2451
2452 2019-07-17  Tom Tromey  <tom@tromey.com>
2453
2454         * tui/tui-win.c (tui_set_focus_command): Rename from
2455         tui_set_focus.  Call tui_enable.
2456         (tui_set_focus_command): Remove.
2457
2458 2019-07-17  Tom Tromey  <tom@tromey.com>
2459
2460         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
2461         refresh_window.
2462         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
2463         touchwin.
2464         (tui_data_window::refresh_window): Call refresh_window on data
2465         items.  Always call superclass refresh_window.
2466         (tui_win_info::refresh): Remove.
2467         (tui_source_window_base::refresh_window): Update.
2468         (tui_refresh_all): Update.
2469         * tui/tui-layout.c (show_source_disasm_command): Remove call to
2470         refresh_window.
2471         (show_source_or_disasm_and_command): Likewise.
2472         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
2473         (struct tui_source_window_base) <refresh>: Likewise.
2474
2475 2019-07-17  Tom Tromey  <tom@tromey.com>
2476
2477         * tui/tui-winsource.c (tui_clear_source_content)
2478         (tui_show_source_content): Update.
2479         * tui/tui-source.c (tui_source_window::showing_source_p): Check
2480         whether content is empty.
2481         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
2482         Remove.
2483
2484 2019-07-17  Tom Tromey  <tom@tromey.com>
2485
2486         * tui/tui-winsource.c (tui_erase_source_content): Clear the
2487         window's contents.
2488         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
2489         * tui/tui-source.c (tui_set_source_content_nil): Remove.
2490
2491 2019-07-17  Tom Tromey  <tom@tromey.com>
2492
2493         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
2494         (struct tui_data_item_window): Update.
2495
2496 2019-07-17  Tom Tromey  <tom@tromey.com>
2497
2498         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
2499         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
2500         defines.
2501
2502 2019-07-17  Tom Tromey  <tom@tromey.com>
2503
2504         * tui/tui-winsource.h (tui_erase_source_content)
2505         (tui_clear_source_content): Remove "display_prompt" parameter.
2506         * tui/tui-winsource.c (tui_update_source_window_as_is)
2507         (tui_update_source_windows_with_addr): Update.
2508         (tui_clear_source_content): Remove "display_prompt" parameter.
2509         (tui_erase_source_content): Likewise.  Simplify.
2510         (tui_show_source_content): Update.
2511         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2512         * tui/tui-stack.c (tui_show_frame_info): Update.
2513         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
2514         Remove defines.
2515
2516 2019-07-17  Tom Tromey  <tom@tromey.com>
2517
2518         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2519         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
2520         parameter.
2521         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
2522         parameter.
2523
2524 2019-07-17  Tom Tromey  <tom@tromey.com>
2525
2526         * tui/tui-winsource.c (tui_clear_source_content)
2527         (tui_show_source_content, tui_show_exec_info_content)
2528         (tui_clear_exec_info_content): Update.
2529         * tui/tui-stack.c (tui_show_locator_content): Update.
2530         (tui_show_frame_info): Update.
2531         * tui/tui-source.h (tui_source_window): Don't declare.
2532         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
2533         from tui_source_is_displayed.
2534         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
2535         Remove field.
2536         (struct tui_source_window_base) <content_in_use>: New field.  Now
2537         bool.
2538         (struct tui_source_window) <showing_source_p>: New method.
2539         (TUI_SRC_WIN): Change cast.
2540         * tui/tui-data.c (tui_initialize_static_data): Update.
2541
2542 2019-07-17  Tom Tromey  <tom@tromey.com>
2543
2544         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
2545         location_matches_p.
2546         * tui/tui-source.c (tui_source_window::location_matches_p): New
2547         method.
2548         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
2549         method.
2550         * tui/tui-data.h (struct tui_source_window_base)
2551         <location_matches_p>: New method.
2552         (struct tui_source_window, struct tui_disasm_window)
2553         <location_matches_p>: Likewise.
2554
2555 2019-07-17  Tom Tromey  <tom@tromey.com>
2556
2557         * tui/tui-win.c (tui_set_win_height_command): Rename from
2558         tui_set_win_height.
2559         (tui_set_win_height_command): Remove.
2560
2561 2019-07-17  Tom Tromey  <tom@tromey.com>
2562
2563         * tui/tui-source.c (tui_source_window): New constructor.  Add
2564         observer.
2565         (~tui_source_window): New destructor.
2566         (tui_source_window::style_changed): New method.
2567         * tui/tui-hooks.c (tui_redisplay_source): Remove.
2568         (tui_attach_detach_observers): Update.
2569         * tui/tui-data.h (struct tui_source_window): Make constructor not
2570         inline.  Add destructor.
2571         (struct tui_source_window) <style_changed>: New method.
2572         <m_observable>: New member.
2573
2574 2019-07-17  Tom Tromey  <tom@tromey.com>
2575
2576         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
2577         * tui/tui-win.c (tui_resize_all): Fix typo.
2578
2579 2019-07-17  Tom Tromey  <tom@tromey.com>
2580
2581         * tui/tui-wingeneral.h (tui_refresh_all): Update.
2582         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
2583         (tui_refresh_all): Remove "list" parameter.  Use foreach.
2584         * tui/tui-win.c (window_name_completer): Use foreach.
2585         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
2586         (update_tab_width): Likewise.
2587         * tui/tui-layout.c (show_layout): Update.
2588         * tui/tui-data.h (class tui_window_iterator): New.
2589         (struct all_tui_windows): New.
2590         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
2591
2592 2019-07-17  Tom Tromey  <tom@tromey.com>
2593
2594         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
2595         parameter.  Don't reference globals.
2596         (tui_reg_command): Update.
2597
2598 2019-07-17  Tom Tromey  <tom@tromey.com>
2599
2600         * tui/tui-regs.c (tui_show_registers): Simplify.
2601
2602 2019-07-17  Tom Tromey  <tom@tromey.com>
2603
2604         * tui/tui-regs.c (tui_show_registers): Update.
2605         (tui_show_register_group): Add win_info parameter.
2606
2607 2019-07-17  Tom Tromey  <tom@tromey.com>
2608
2609         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
2610         Rename from tui_display_reg_element_at_line.
2611         (tui_data_window::display_registers_from_line): Update.
2612         * tui/tui-data.h (struct tui_data_window)
2613         <display_reg_element_at_line>: New method.
2614
2615 2019-07-17  Tom Tromey  <tom@tromey.com>
2616
2617         * tui/tui-regs.h (tui_display_registers_from)
2618         (tui_display_registers_from_line): Don't declare.
2619         * tui/tui-windata.c (tui_data_window::display_all_data)
2620         (tui_data_window::refresh_all)
2621         (tui_data_window::do_scroll_vertical): Update.
2622         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
2623         from tui_display_registers_from.
2624         (tui_display_reg_element_at_line): Update.
2625         (tui_data_window::display_registers_from_line): Rename from
2626         tui_display_registers_from_line.
2627         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
2628         display_registers_from_line>: New methods.
2629
2630 2019-07-17  Tom Tromey  <tom@tromey.com>
2631
2632         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
2633         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
2634         from tui_erase_data_content.
2635         (tui_data_window::display_all_data)
2636         (tui_data_window::refresh_all)
2637         (tui_data_window::do_scroll_vertical): Update.
2638         * tui/tui-regs.c (tui_show_registers): Update.
2639         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
2640         New method.
2641
2642 2019-07-17  Tom Tromey  <tom@tromey.com>
2643
2644         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
2645         declare.
2646         * tui/tui-windata.c
2647         (tui_data_window::delete_data_content_windows): Rename from
2648         tui_delete_data_content_windows.
2649         (tui_data_window::display_all_data)
2650         (tui_data_window::do_scroll_vertical): Update.
2651         * tui/tui-data.h (struct tui_data_window)
2652         <delete_data_content_windows>: New method.
2653
2654 2019-07-17  Tom Tromey  <tom@tromey.com>
2655
2656         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
2657         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
2658
2659 2019-07-17  Tom Tromey  <tom@tromey.com>
2660
2661         * tui/tui-windata.h (tui_display_all_data): Don't declare.
2662         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
2663         from tui_display_all_data.
2664         * tui/tui-win.c
2665         (tui_data_window::do_make_visible_with_new_height): Update.
2666         * tui/tui-regs.c (tui_show_registers): Update.
2667         * tui/tui-layout.c (tui_set_layout): Update.
2668         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
2669         method.
2670
2671 2019-07-17  Tom Tromey  <tom@tromey.com>
2672
2673         * tui/tui-windata.h (tui_display_data_from): Don't declare.
2674         * tui/tui-windata.c (tui_display_data_from): Remove.
2675         (tui_data_window::refresh_all): Update.
2676
2677 2019-07-17  Tom Tromey  <tom@tromey.com>
2678
2679         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
2680         * tui/tui-windata.c (tui_display_data_from_line): Remove.
2681         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
2682         tui_display_registers_from_line.
2683         * tui/tui-regs.h (tui_display_registers_from_line): Update.
2684         * tui/tui-regs.c (tui_display_registers_from_line): Remove
2685         "force_display" parameter.
2686
2687 2019-07-17  Tom Tromey  <tom@tromey.com>
2688
2689         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
2690         declare.
2691         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
2692         Rename from tui_first_reg_element_no_inline.
2693         (tui_display_reg_element_at_line)
2694         (tui_display_registers_from_line): Update.
2695         * tui/tui-data.h (struct tui_data_window)
2696         <first_reg_element_no_inline>: New method.
2697
2698 2019-07-17  Tom Tromey  <tom@tromey.com>
2699
2700         * tui/tui-windata.c (tui_display_data_from)
2701         (tui_data_window::do_scroll_vertical): Update.
2702         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
2703         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
2704         Rename from tui_line_from_reg_element_no.
2705         (tui_display_registers_from_line): Update.
2706         * tui/tui-data.h (struct tui_data_window)
2707         <line_from_reg_element_no>: New method.
2708
2709 2019-07-17  Tom Tromey  <tom@tromey.com>
2710
2711         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
2712         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
2713         tui_last_regs_line_no.
2714         (tui_display_reg_element_at_line)
2715         (tui_display_registers_from_line): Update.
2716         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
2717         method.
2718
2719 2019-07-17  Tom Tromey  <tom@tromey.com>
2720
2721         PR tui/24722:
2722         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
2723         (tui_update_breakpoint_info): Add "being_deleted" parameter.
2724         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2725         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
2726         (tui_update_breakpoint_info): Likewise.
2727         * tui/tui-hooks.c (tui_event_create_breakpoint)
2728         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
2729         Update.
2730
2731 2019-07-17  Tom Tromey  <tom@tromey.com>
2732
2733         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
2734
2735 2019-07-17  Tom Tromey  <tom@tromey.com>
2736
2737         * tui/tui-winsource.c (tui_update_source_window_as_is)
2738         (tui_update_source_windows_with_addr): Update.
2739         * tui/tui-source.h (tui_set_source_content)
2740         (tui_show_symtab_source): Add "win_info" parameter.
2741         * tui/tui-source.c (tui_set_source_content): Add "win_info"
2742         parameter.
2743         (tui_show_symtab_source): Likewise.
2744
2745 2019-07-17  Tom Tromey  <tom@tromey.com>
2746
2747         * tui/tui-wingeneral.c
2748         (tui_check_and_display_highlight_if_needed): Check can_highlight.
2749
2750 2019-07-17  Tom Tromey  <tom@tromey.com>
2751
2752         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
2753         (struct tui_cmd_window) <can_scroll>: New method.
2754         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
2755         method.
2756
2757 2019-07-17  Tom Tromey  <tromey@adacore.com>
2758
2759         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
2760         do_field_signed>: Rename.  Change type of "value".
2761         * ui-out.c (ui_out::field_signed): Rename from field_int.
2762         Change type of "value".
2763         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
2764         type of "value".
2765         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
2766         do_field_int.  Change type of "value".
2767         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
2768         do_field_int.  Change type of "value".
2769         * tracepoint.c (trace_status_mi, tfind_1)
2770         (print_one_static_tracepoint_marker): Update.
2771         * thread.c (print_thread_info_1, print_selected_thread_frame):
2772         Update.
2773         * stack.c (print_frame, print_frame_info): Update.
2774         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
2775         Update.
2776         * source.c (print_source_lines_base): Update.
2777         * skip.c (info_skip_command): Update.
2778         * record-btrace.c (btrace_ui_out_decode_error)
2779         (btrace_call_history_src_line): Update.
2780         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
2781         Update.
2782         * progspace.c (print_program_space): Update.
2783         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
2784         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
2785         do_field_int.  Change type of "value".
2786         * mi/mi-out.c (mi_ui_out::do_table_begin)
2787         (mi_ui_out::do_table_header): Update.
2788         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
2789         type of "value".
2790         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
2791         (mi_cmd_data_list_changed_registers, output_register)
2792         (mi_cmd_data_read_memory, mi_load_progress)
2793         (mi_cmd_trace_frame_collected): Update.
2794         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
2795         Update.
2796         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
2797         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
2798         (mi_cmd_var_list_children, varobj_update_one): Update.
2799         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
2800         (mi_cmd_stack_list_args, list_arg_or_local): Update.
2801         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
2802         * inferior.c (print_inferior): Update.
2803         * gdb_bfd.c (print_one_bfd): Update.
2804         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2805         Update.
2806         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
2807         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
2808         do_field_int.  Change type of "value".
2809         * cli-out.c (cli_ui_out::do_field_signed): Rename from
2810         do_field_int.  Change type of "value".
2811         * breakpoint.c (watchpoint_check, print_breakpoint_location)
2812         (print_one_breakpoint_location, print_it_catch_fork)
2813         (print_one_catch_fork, print_it_catch_vfork)
2814         (print_one_catch_vfork, print_it_catch_solib)
2815         (print_it_catch_exec, print_it_ranged_breakpoint)
2816         (print_mention_watchpoint, print_mention_masked_watchpoint)
2817         (bkpt_print_it, update_static_tracepoint): Update.
2818         * break-catch-throw.c (print_it_exception_catchpoint): Update.
2819         * break-catch-syscall.c (print_it_catch_syscall): Update.
2820         * ada-tasks.c (print_ada_task_info): Update.
2821         * ada-lang.c (print_it_exception, print_mention_exception):
2822         Update.
2823
2824 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2825
2826         PR breakpoints/24541
2827         * gdbarch.c: Regenerate.
2828         * gdbarch.h: Regenerate.
2829         * gdbarch.sh: Adjust return type and parameter types for
2830         'stap_adjust_register'.
2831         (i386_stap_adjust_register): Adjust signature and return new
2832         register name.
2833         * stap-probe.c (stap_parse_register_operand): Adjust use of
2834         'gdbarch_stap_adjust_register'.
2835
2836 2019-07-17  Tom Tromey  <tromey@adacore.com>
2837
2838         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
2839         declare VEC.
2840         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
2841         std::vector.
2842         (struct s390_process_info): Add initializers.
2843         (s390_add_process): Use new.
2844         (s390_linux_nat_target::low_forget_process): Use delete.
2845         (s390_linux_nat_target::low_new_fork)
2846         (s390_linux_nat_target::stopped_by_watchpoint)
2847         (s390_linux_nat_target::low_prepare_to_resume)
2848         (s390_linux_nat_target::insert_watchpoint)
2849         (s390_linux_nat_target::insert_hw_breakpoint)
2850         (s390_linux_nat_target::remove_watchpoint)
2851         (s390_linux_nat_target::remove_hw_breakpoint): Update.
2852
2853 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2854
2855         * aarch64-fbsd-nat.c: Include regcache.h.
2856         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
2857         argument.
2858         (aarch64_fbsd_nat_target::fetch_registers)
2859         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
2860         variable.
2861         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
2862
2863 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2864
2865         * fbsd-nat.c: Include gdbarch.h.
2866
2867 2019-07-15  Tom Tromey  <tromey@adacore.com>
2868
2869         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
2870
2871 2019-07-15  Tom Tromey  <tromey@adacore.com>
2872
2873         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
2874         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
2875         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
2876         * cli-out.c (cli_ui_out::do_field_int): New method.
2877         * ui-out.c (ui_out::field_unsigned): New method.
2878         * symfile.c (generic_load): Use field_unsigned.
2879         (print_transfer_performance): Likewise.
2880         * record-btrace.c (ui_out_field_uint): Remove.
2881         (btrace_call_history_insn_range, btrace_call_history): Use
2882         field_unsigned.
2883         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
2884         field_unsigned.
2885         * ui-out.h (class ui_out) <field_unsigned>: New method.
2886         <do_field_unsigned>: Likewise.
2887
2888 2019-07-15  Tom Tromey  <tromey@adacore.com>
2889
2890         * mi/mi-main.c (list_available_thread_groups): Use field_string.
2891         * mi/mi-interp.c (mi_memory_changed): Use field_string.
2892         * target.c (flash_erase_command): Use field_string.
2893         * infrun.c (print_signal_received_reason): Use field_string.
2894         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
2895         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
2896         field_string.
2897         * ada-tasks.c (print_ada_task_info): Use field_string.
2898
2899 2019-07-15  Tom Tromey  <tromey@adacore.com>
2900
2901         * target.c (flash_erase_command): Use field_core_addr.
2902         * symfile.c (generic_load): Use field_core_addr.
2903         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
2904         Use field_core_addr.
2905         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
2906         field_core_addr.
2907
2908 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2909
2910         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
2911         value if its desired type is smaller than a CORE_ADDR and signed.
2912
2913 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2914
2915         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
2916         of changes to field names, and use new is_reference field to
2917         decide if a property is a reference or not.
2918         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
2919         field.
2920         (struct dwarf2_property_baton): Update header comment, rename
2921         'referenced_type' to 'property_type' and update comments.
2922         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
2923         default property type, store in property baton, update to take
2924         accound of renamed field.
2925         (read_func_scope): Update call to attr_to_dynamic_prop.
2926         (read_array_type): Likewise.
2927         (dwarf2_per_cu_addr_sized_int_type): New function.
2928         (read_subrange_index_type): Move type finding code to
2929         dwarf2_per_cu_addr_sized_int_type.
2930         (read_subrange_type): Update calls to attr_to_dynamic_prop.
2931         (dwarf2_per_cu_addr_type): New function.
2932         (set_die_type): Update calls to attr_to_dynamic_prop.
2933
2934 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2935
2936         * dwarf2read.c (read_subrange_index_type): New function.
2937         (read_subrange_type): Move code into new function and call it.
2938         * gdbtypes.c (create_range_type): Add some asserts.
2939
2940 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2941
2942         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
2943         update return statements.
2944         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
2945         declaration, and update comment to match.
2946         * gdbtypes.c (resolve_dynamic_array): Update call to
2947         dwarf2_evaluate_property to match new return type.
2948
2949 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2950
2951         * valarith.c (value_subscripted_rvalue): Change lowerbound
2952         parameter type from int to LONGEST.
2953         * value.h (value_subscripted_rvalue): Likewise in declaration.
2954
2955 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2956
2957         * cli/cli-utils.c (info_print_command_completer): New function.
2958         * cli/cli-utils.h: Add 'completer.h' include, and forward
2959         declaration for 'struct cmd_list_element'.
2960         (info_print_command_completer): Declare.
2961         * stack.c (_initialize_stack): Add completer for 'info locals' and
2962         'info args'.
2963         * symtab.c (_initialize_symtab): Add completer for 'info
2964         variables' and 'info functions'.
2965         * NEWS: Mention completion for additional info commands.
2966
2967 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2968
2969         * cli/cli-utils.c (extract_info_print_args): Delete.
2970         (extract_arg_maybe_quoted): Delete.
2971         (info_print_options_defs): New variable.
2972         (make_info_print_options_def_group): New function.
2973         (extract_info_print_options): Define new function.
2974         * cli/cli-utils.h (extract_info_print_args): Delete.
2975         (struct info_print_options): New structure.
2976         (extract_info_print_options): Declare new function.
2977         * stack.c (info_locals_command): Update to use new
2978         extract_info_print_options, also add a header comment.
2979         (info_args_command): Likewise.
2980         * symtab.c (info_variables_command): Likewise.
2981         (info_functions_command): Likewise.
2982
2983 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2984
2985         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2986         to extract string arguments.
2987         * common/common-utils.c (extract_string_maybe_quoted): New function.
2988         * common/common-utils.h (extract_string_maybe_quoted): Declare.
2989
2990 2019-07-11  Tom Tromey  <tromey@adacore.com>
2991
2992         * main.c (get_init_files): Use GDBINIT, not gdbinit.
2993         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2994         * top.h (gdbinit): Don't declare.
2995         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2996         into...
2997         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
2998         * top.c (gdb_init): Don't call init_cli_cmds.
2999         (gdbinit): Remove.
3000         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
3001
3002 2019-07-11  Tom Tromey  <tromey@adacore.com>
3003
3004         * python/py-inferior.c (add_thread_object): Don't use thread_obj
3005         after it has been moved.
3006
3007 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3008
3009         * valops.c (value_must_coerce_to_target): Change return type to
3010         bool.
3011         * value.h (value_must_coerce_to_target): Likewise.
3012
3013 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
3014
3015         * breakpoint.c (is_hardware_watchpoint): Remove
3016         forward-declaration.
3017         (is_masked_watchpoint): Change return type to bool.
3018         (is_tracepoint): Likewise.
3019         (is_breakpoint): Likewise.
3020         (is_hardware_watchpoint): Likewise.
3021         (is_watchpoint): Likewise.
3022         (is_no_memory_software_watchpoint): Likewise.
3023         (is_catchpoint): Likewise.
3024         (breakpoint_1): Make FILTER parameter's return type bool.
3025         is_masked_watchpoint): Change return type to bool.
3026         (save_breakpoints): Make FILTER parameter's return type bool.
3027         * breakpoint.h (is_breakpoint): Change return type to bool.
3028         (is_watchpoint): Likewise.
3029         (is_catchpoint): Likewise.
3030         (is_tracepoint): Likewise.
3031
3032 2019-07-10  Tom Tromey  <tom@tromey.com>
3033
3034         * defs.h: Don't include gdbarch.h.
3035         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
3036         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
3037         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
3038         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
3039         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
3040         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
3041         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
3042         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
3043         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
3044         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
3045         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
3046         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
3047         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
3048         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
3049         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
3050         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
3051         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
3052         record-btrace.c, record.h, regcache-dump.c, regcache.h,
3053         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
3054         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
3055         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
3056         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
3057         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
3058         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
3059         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
3060         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
3061         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
3062
3063 2019-07-10  Tom Tromey  <tromey@adacore.com>
3064
3065         * ada-lang.h (is_ada_exception_catchpoint): Declare.
3066         * breakpoint.c (init_ada_exception_breakpoint): Register as
3067         bp_catchpoint.
3068         (print_one_breakpoint_location, print_one_breakpoint): Use
3069         is_ada_exception_catchpoint.
3070         * ada-lang.c (class ada_catchpoint_location): Pass
3071         bp_loc_software_breakpoint to bp_location constructor.
3072         (is_ada_exception_catchpoint): New function.
3073
3074 2019-07-10  Tom Tromey  <tromey@adacore.com>
3075
3076         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
3077         VEC.
3078         (struct arm_exidx_entry): New method operator<.
3079         (struct arm_exidx_data) <section_maps>: Change type.
3080         (arm_exidx_data_free): Remove.
3081         (arm_exidx_data_key): Change type.  Move lower.
3082         (arm_exidx_new_objfile): Update.
3083         (arm_compare_exidx_entries): Remove.
3084         (arm_find_exidx_entry, _initialize_arm_tdep)
3085
3086 2019-07-10  Tom Tromey  <tromey@adacore.com>
3087
3088         * solib-spu.c (ocl_program_data_key): Change type.
3089         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
3090         Update.
3091
3092 2019-07-10  Tom Tromey  <tromey@adacore.com>
3093
3094         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
3095         (struct solib_aix_inferior_data) <library_list>: Change type.
3096         (solib_aix_inferior_data_handle): Change type.
3097         (get_solib_aix_inferior_data): Update.
3098         (solib_aix_free_library_list): Remove.
3099         (library_list_start_library): Update.
3100         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
3101         return type.
3102         (solib_aix_get_library_list)
3103         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
3104         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
3105
3106 2019-07-10  Tom Tromey  <tromey@adacore.com>
3107
3108         * solib-dsbt.c (struct dsbt_info): Add initializers.
3109         (solib_dsbt_pspace_data): Change type.
3110         (dsbt_pspace_data_cleanup): Remove.
3111         (get_dsbt_info, _initialize_dsbt_solib): Update.
3112
3113 2019-07-10  Tom Tromey  <tromey@adacore.com>
3114
3115         * spu-tdep.c (spu_overlay_data): Change type.
3116         (spu_get_overlay_table, spu_overlay_new_objfile)
3117         (_initialize_spu_tdep): Update.
3118
3119 2019-07-10  Tom Tromey  <tromey@adacore.com>
3120
3121         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
3122         destructor.
3123         (dbx_objfile_data_key): Change type and declare later.
3124         (DBX_SYMFILE_INFO): Rewrite.
3125         * dbxread.c (dbx_objfile_data_key): Change type.
3126         (dbx_symfile_init): Update.
3127         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
3128         (coffstab_build_psymtabs, elfstab_build_psymtabs)
3129         (stabsect_build_psymtabs, _initialize_dbxread): Update.
3130
3131 2019-07-10  Tom Tromey  <tromey@adacore.com>
3132
3133         * jit.c (jit_program_space_key): Change type.  Move lower.
3134         (get_jit_program_space_data): Update.
3135         (jit_program_space_data_cleanup): Remove.
3136         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
3137         Update.
3138         (struct jit_program_space_data): Add initializers.
3139
3140 2019-07-10  Tom Tromey  <tromey@adacore.com>
3141
3142         * solib-darwin.c (struct darwin_info): Add initializers.
3143         (solib_darwin_pspace_data): Change type.
3144         (darwin_pspace_data_cleanup): Remove.
3145         (get_darwin_info, _initialize_darwin_solib): Update.
3146
3147 2019-07-10  Tom Tromey  <tromey@adacore.com>
3148
3149         * remote-sim.c (struct sim_inferior_data): Add initializers,
3150         constructor, and destructor.
3151         (sim_inferior_data_key): Change type.  Move lower.
3152         (check_for_duplicate_sim_descriptor): Update.
3153         (get_sim_inferior_data): Use new.  Update.
3154         (~sim_inferior_data_cleanup): Rename from
3155         sim_inferior_data_cleanup.  Simplify.
3156         (gdbsim_close_inferior, simulator_command)
3157         (sim_command_completer, _initialize_remote_sim): Update.
3158         (next_pid, INITIAL_PID): Move earlier.
3159
3160 2019-07-10  Tom Tromey  <tromey@adacore.com>
3161
3162         * python/python-internal.h (create_thread_object): Return
3163         gdbpy_ref.
3164         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
3165         * python/py-inferior.c (struct threadlist_entry): Add
3166         constructor.
3167         <thread_obj>: Now a gdbpy_ref.
3168         (thread_to_thread_object): Update.
3169         (add_thread_object): Use new.
3170         (delete_thread_object): Use delete.
3171         (infpy_threads): Update.
3172         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
3173         GIL.
3174
3175 2019-07-10  Tom Tromey  <tromey@adacore.com>
3176
3177         * valops.c (value_cast): Specialize error message for Ada.
3178
3179 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3180
3181         * breakpoint.c (breakpoint_1): Update doc and parameter names.
3182
3183 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3184
3185         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
3186         bpstat_should_step): Return bool, adjust comments.
3187         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
3188         bpstat_should_step): Likewise.
3189
3190 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3191
3192         * features/Makefile: Use feature target descriptions for Arm.
3193         * features/arm/arm-core.c: Generate new file.
3194         * features/arm/arm-fpa.c: Likewise.
3195         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
3196         * features/arm/arm-m-profile.c: Likewise.
3197         * features/arm/arm-vfpv2.c: Likewise.
3198         * features/arm/arm-vfpv3.c: Likewise.
3199         * features/arm/xscale-iwmmxt.c: Likewise.
3200         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
3201
3202 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3203
3204         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
3205         ptrace earlier.
3206
3207 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3208
3209         * features/aarch64-pauth.c: Regenerate.
3210
3211 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
3212
3213         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
3214         bool.
3215         (bpstat_what): Use false instead of 0.
3216
3217 2019-07-09  Pedro Alves  <palves@redhat.com>
3218
3219         * break-catch-throw.c (is_exception_catchpoint): New.
3220         * breakpoint.c (print_one_breakpoint_location): New parameter
3221         'raw_loc'.  Handle it.  Use
3222         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
3223         looking at the breakpoint's type.
3224         (print_one_breakpoint): If handling "maint info breakpoints", also
3225         print locations of exception catchpoints.
3226         * breakpoint.h (is_exception_catchpoint): Declare.
3227
3228 2019-07-09  Pedro Alves  <palves@redhat.com>
3229
3230         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
3231         "addr" field.
3232         (allocate_location_exception_catchpoint): New.
3233         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
3234         (initialize_throw_catchpoint_ops): Install
3235         allocate_location_exception_catchpoint as allocate_location
3236         method.
3237         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
3238         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
3239         bp_loc_other.
3240         (breakpoint_address_is_meaningful): Delete.
3241         (bl_address_is_meaningful): New.
3242         (breakpoint_locations_match): Adjust comment.
3243         (bp_location_from_bp_type): New, factored out of...
3244         (bp_location::bp_location(breakpoint *)): ... this.
3245         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
3246         factored out of...
3247         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
3248         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
3249         breakpoint_address_is_meaningful.
3250         (bp_locations_compare): Adjust comment.
3251         (update_global_location_list): Use bl_address_is_meaningful
3252         instead of breakpoint_address_is_meaningful.
3253         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
3254         explicit.
3255         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
3256         * python/py-breakpoint.c (bppy_get_location): No longer check
3257         whether location is null.
3258
3259 2019-07-09  Pedro Alves  <palves@redhat.com>
3260
3261         PR c++/15468
3262         * breakpoint.c (print_one_breakpoint_location): Remove
3263         single-location assert.
3264
3265 2019-07-09  Tom Tromey  <tom@tromey.com>
3266
3267         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
3268         * configure: Rebuild.
3269         * configure.ac: Change common to gdbsupport.
3270         * gdbsupport: Rename from common.
3271         * acinclude.m4: Change common to gdbsupport.
3272         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
3273         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
3274         gdbsupport.
3275         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
3276         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
3277         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
3278         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
3279         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
3280         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
3281         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
3282         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
3283         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
3284         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
3285         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
3286         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
3287         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
3288         coff-pe-read.c, command.h, compile/compile-c-support.c,
3289         compile/compile-c.h, compile/compile-cplus-symbols.c,
3290         compile/compile-cplus-types.c, compile/compile-cplus.h,
3291         compile/compile-loc2c.c, compile/compile.c, completer.c,
3292         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
3293         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
3294         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
3295         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
3296         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
3297         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
3298         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
3299         features/aarch64-core.c, features/aarch64-fpu.c,
3300         features/aarch64-pauth.c, features/aarch64-sve.c,
3301         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
3302         features/i386/32bit-core.c, features/i386/32bit-linux.c,
3303         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
3304         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
3305         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
3306         features/i386/64bit-core.c, features/i386/64bit-linux.c,
3307         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
3308         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
3309         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
3310         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
3311         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
3312         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
3313         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
3314         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
3315         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
3316         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
3317         go32-nat.c, guile/guile.c, guile/scm-ports.c,
3318         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
3319         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
3320         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
3321         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
3322         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
3323         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
3324         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
3325         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
3326         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
3327         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
3328         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
3329         minsyms.c, mips-linux-tdep.c, namespace.h,
3330         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
3331         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
3332         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
3333         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
3334         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
3335         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
3336         nat/linux-waitpid.c, nat/mips-linux-watch.c,
3337         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
3338         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
3339         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
3340         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
3341         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
3342         procfs.c, producer.c, progspace.h, psymtab.h,
3343         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
3344         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
3345         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
3346         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
3347         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
3348         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
3349         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
3350         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
3351         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
3352         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
3353         target-memory.c, target.c, target.h, target/waitstatus.c,
3354         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
3355         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
3356         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
3357         unittests/array-view-selftests.c,
3358         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
3359         unittests/common-utils-selftests.c,
3360         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
3361         unittests/format_pieces-selftests.c,
3362         unittests/function-view-selftests.c,
3363         unittests/lookup_name_info-selftests.c,
3364         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
3365         unittests/mkdir-recursive-selftests.c,
3366         unittests/observable-selftests.c,
3367         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
3368         unittests/parse-connection-spec-selftests.c,
3369         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
3370         unittests/scoped_fd-selftests.c,
3371         unittests/scoped_mmap-selftests.c,
3372         unittests/scoped_restore-selftests.c,
3373         unittests/string_view-selftests.c, unittests/style-selftests.c,
3374         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
3375         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
3376         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
3377         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
3378         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
3379         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
3380
3381 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3382
3383         * linespec.c (decode_digits_list_mode): Set explicit_line to a
3384         bool value.
3385         (decode_digits_ordinary): Set explicit_line field in sal.
3386         * symtab.c (skip_prologue_sal): Don't skip prologue for a
3387         symtab_and_line that was set on an explicit line number in
3388         assembler code.  Do always update the recorded symtab and line if
3389         we do skip the prologue.
3390
3391 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3392
3393         * breakpoint.c (set_breakpoint_location_function): Remove
3394         explicit_loc parameter.
3395         (momentary_breakpoint_from_master): Update call to
3396         set_breakpoint_location_function.
3397         (add_location_to_breakpoint): Likewise.
3398
3399 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3400
3401         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
3402         required features based on default bfd type when no specific bfd
3403         is present.
3404
3405 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3406
3407         * NEWS: Mention that GDB printf and eval commands can now print
3408         C-style and Ada-style convenience var strings without
3409         calling the inferior.
3410         * printcmd.c (printf_c_string): Locally print GDB internal var
3411         instead of transiting via the inferior.
3412         (printf_wide_c_string): Likewise.
3413
3414 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3415
3416         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
3417
3418 2019-07-04  Tom Tromey  <tom@tromey.com>
3419
3420         PR tui/24724:
3421         * tui/tui-winsource.c (tui_clear_source_content): Update.
3422         (tui_source_window_base::set_is_exec_point_at): Fix comment.
3423         (tui_update_breakpoint_info): Update.
3424         (tui_set_exec_info_content): Update.
3425         * tui/tui-source.c (tui_set_source_content_nil): Update.
3426         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
3427         has_break.
3428         * tui/tui-data.h (enum tui_bp_flag): New.
3429         (tui_bp_flags): New enum flags type.
3430         (struct tui_source_element) <break_mode>: Change type.  Rename
3431         from has_break.
3432         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
3433         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
3434         constants.
3435         * tui/tui-winsource.h: Fix comment.
3436
3437 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3438
3439         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
3440         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
3441         (store_fpregs_to_thread)
3442         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3443         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
3444         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
3445         (IWMMXT_REGS_SIZE): Add define.
3446         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
3447         (fetch_vfp_regs, store_vfp_regs)
3448         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3449         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
3450
3451 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3452
3453         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
3454         defines.
3455         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
3456         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
3457         (ARM_INT_REGISTER_SIZE): ...to this.
3458         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
3459         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
3460         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
3461         (arm_linux_collect_gregset, supply_nwfpe_register)
3462         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
3463         defines.
3464         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
3465         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
3466         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
3467         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
3468         (arm_return_in_memory, arm_store_return_value)
3469         (arm_get_longjmp_target, arm_register_g_packet_guesses)
3470         (arm_record_ld_st_multiple): Likewise.
3471         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
3472         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
3473
3474 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3475
3476         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
3477         AARCH64_DISPLACED_MODIFIED_INSNS.
3478         * aarch64-tdep.c (struct aarch64_displaced_step_data)
3479         (aarch64_displaced_step_copy_insn): Likewise.
3480         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3481         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
3482         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
3483         ARM_DISPLACED_MODIFIED_INSNS.
3484         * arm-tdep.c (arm_gdbarch_init): Likewise.
3485         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3486         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
3487         (struct arm_displaced_step_closure): Use
3488         ARM_DISPLACED_MODIFIED_INSNS.
3489
3490 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3491
3492         * features/Makefile: Remove unused xml files.
3493         * features/aarch64.xml: Remove.
3494         * features/i386/amd64-avx-avx512-linux.xml: Remove.
3495         * features/i386/amd64-avx-avx512.xml: Remove.
3496         * features/i386/amd64-avx-linux.xml: Remove.
3497         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
3498         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
3499         * features/i386/amd64-avx-mpx-linux.xml: Remove.
3500         * features/i386/amd64-avx-mpx.xml: Remove.
3501         * features/i386/amd64-avx.xml: Remove.
3502         * features/i386/amd64-linux.xml: Remove.
3503         * features/i386/amd64-mpx-linux.xml: Remove.
3504         * features/i386/amd64-mpx.xml: Remove.
3505         * features/i386/amd64.xml: Remove.
3506         * features/i386/i386-avx-avx512-linux.xml: Remove.
3507         * features/i386/i386-avx-avx512.xml: Remove.
3508         * features/i386/i386-avx-linux.xml: Remove.
3509         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
3510         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
3511         * features/i386/i386-avx-mpx-linux.xml: Remove.
3512         * features/i386/i386-avx-mpx.xml: Remove.
3513         * features/i386/i386-avx.xml: Remove.
3514         * features/i386/i386-linux.xml: Remove.
3515         * features/i386/i386-mmx-linux.xml: Remove.
3516         * features/i386/i386-mmx.xml: Remove.
3517         * features/i386/i386-mpx-linux.xml: Remove.
3518         * features/i386/i386-mpx.xml: Remove.
3519         * features/i386/i386.xml: Remove.
3520         * features/i386/x32-avx-avx512-linux.xml: Remove.
3521         * features/i386/x32-avx-linux.xml: Remove.
3522         * features/i386/x32-linux.xml: Remove.
3523
3524 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3525
3526         * regformats/aarch64.dat: Remove.
3527         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
3528         * regformats/i386/amd64-avx-linux.dat: Remove.
3529         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
3530         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
3531         * regformats/i386/amd64-linux.dat: Remove.
3532         * regformats/i386/amd64-mpx-linux.dat: Remove.
3533         * regformats/i386/amd64.dat: Remove.
3534         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
3535         * regformats/i386/i386-avx-linux.dat: Remove.
3536         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
3537         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
3538         * regformats/i386/i386-linux.dat: Remove.
3539         * regformats/i386/i386-mmx-linux.dat: Remove.
3540         * regformats/i386/i386-mpx-linux.dat: Remove.
3541         * regformats/i386/i386.dat: Remove.
3542         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
3543         * regformats/i386/x32-avx-linux.dat: Remove.
3544         * regformats/i386/x32-linux.dat: Remove.
3545
3546 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3547
3548         * aarch64-tdep.c: Remove xml self tests.
3549         * amd64-linux-tdep.c: Likewise.
3550         * amd64-tdep.c: Likewise.
3551         * i386-linux-tdep.c: Likewise.
3552         * i386-tdep.c: Likewise.
3553
3554 2019-07-03  Pedro Alves  <palves@redhat.com>
3555
3556         PR cli/24732
3557         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
3558         (pipe_cmd_option_defs): New.
3559         (make_pipe_cmd_options_def_group): New.
3560         (pipe_command): Use gdb::option::process_options.
3561         (pipe_command_completer): New function.
3562         (_initialize_cli_cmds): Install completer for "pipe" command.
3563
3564 2019-07-03  Pedro Alves  <palves@redhat.com>
3565
3566         * cli/cli-option.c (union option_value) <string>: New field.
3567         (struct option_def_and_value): Add ctor, move ctor, dtor and
3568         use DISABLE_COPY_AND_ASSIGN.
3569         (option_def_and_value::clear_value): New.
3570         (parse_option, save_option_value_in_ctx, get_val_type_str)
3571         (add_setshow_cmds_for_options): Handle var_string.
3572         * cli-option.h (union option_def::var_address) <string>: New
3573         field.
3574         (struct string_option_def): New.
3575         * maint-test-options.c (struct test_options_opts): Add default
3576         ctor and use DISABLE_COPY_AND_ASSIGN.
3577         <string_opt>: New field.
3578         (test_options_opts::~test_options_opts): New.
3579         (test_options_opts::dump): Also dump "-string".
3580         (test_options_option_defs): Install "string.
3581
3582 2019-07-03  Pedro Alves  <palves@redhat.com>
3583
3584         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
3585         option_value with a null enumeration.
3586         (complete_options): Save the option values in the context.
3587         (save_option_value_in_ctx): New, factored out from ...
3588         (process_options): ... here.
3589         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
3590         of the function.
3591         * maint-test-options.c (test_options_opts::dump): New, factored
3592         out from ...
3593         (maintenance_test_options_command_mode): ... here.
3594         (maintenance_test_options_command_completion_result): Delete.
3595         (maintenance_test_options_command_completion_text): Update
3596         comment.
3597         (maintenance_show_test_options_completion_result): Change
3598         prototype.  Just print
3599         maintenance_test_options_command_completion_text.
3600         (save_completion_result): New.
3601         (maintenance_test_options_completer_mode): Pass options context to
3602         complete_options, and then save a dump.
3603         (_initialize_maint_test_options): Use add_cmd to install "maint
3604         show test-options-completion-result".
3605
3606 2019-07-03  Pedro Alves  <palves@redhat.com>
3607
3608         * NEWS (New commands): Mention "with" and "maint with".
3609         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
3610         (with_command, with_command_completer): New.
3611         (pipe_command): Adjust to new repeat_previous
3612         interface.
3613         (_initialize_cli_cmds): Install the "with" command and its "w"
3614         alias.
3615         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
3616         declarations.
3617         * cli/cli-setshow.c (parse_cli_var_uinteger)
3618         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
3619         argument strings for all var_types.
3620         (get_setshow_command_value_string): New, factored out from ...
3621         (do_show_command): ... this.
3622         * cli/cli-setshow.h: Include <string>.
3623         (get_setshow_command_value_string): Declare.
3624         * command.h (repeat_previous): Now returns const char *.  Adjust
3625         comment.
3626         * maint.c: Include "cli/cli-cmds.h".
3627         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
3628         (_initialize_maint_cmds): Register the "maintenance with" command.
3629         * top.c (repeat_previous): Move bits from pipe_command here:
3630         Return the saved command line, if any; error out if there's no
3631         command to relaunch.
3632
3633 2019-07-03  Pedro Alves  <palves@redhat.com>
3634
3635         * NEWS (New commands): Mention "maint set/show test-settings"
3636         instead of "maint test-settings".
3637         * maint-test-settings.c (maintenance_test_settings_list): Delete.
3638         (maintenance_test_settings_set_list): Rename to ...
3639         (maintenance_set_test_settings_list): ... this.
3640         (maintenance_test_settings_show_list): Rename to  ...
3641         (maintenance_show_test_settings_list): ... this.
3642         (maintenance_test_settings_cmd): Delete.
3643         (maintenance_test_settings_set_cmd): ...
3644         (maintenance_set_test_settings_cmd): ... this.
3645         (maintenance_test_settings_show_cmd): ...
3646         (maintenance_show_test_settings_cmd): ... this.
3647         (maintenance_test_settings_show_value_cmd):
3648         (maintenance_show_test_settings_value_cmd): ... this.
3649         (_initialize_maint_test_settings): No longer install the "maint
3650         test-settings" prefix command.  Rename "maint test-settings set"
3651         to "maint set test-settings", and "maint test-settings show" to
3652         "maint show test-settings".  Adjust all subcommands.
3653
3654 2019-07-03  Pedro Alves  <palves@redhat.com>
3655
3656         * maint-test-settings.c: Fix file's intro comment.  Replace all
3657         references to "test-options" with references to "test-settings",
3658         in comments.
3659
3660 2019-07-03  Pedro Alves  <palves@redhat.com>
3661
3662         * maint-test-settings.c (maintenance_test_settings_xxx)
3663         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
3664         New.
3665         (maintenance_test_settings_enums): Use them.
3666         (maintenance_test_settings_enum): Default to
3667         maintenance_test_settings_xxx.
3668         (_initialize_maint_test_settings): Initialize
3669         MAINTENANCE_TEST_SETTINGS_FILENAME.
3670
3671 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3672
3673         * breakpoint.h (remove_breakpoints_inf): Change return type to
3674         void, move function documentation here.
3675         * breakpoint.c (remove_breakpoints_inf): Change return type to
3676         void, move function documentation to header.
3677
3678 2019-07-02  Pedro Alves  <palves@redhat.com>
3679
3680         * NEWS (Completion improvements): Mention "info threads".
3681         * thread.c (struct info_threads_opts, info_threads_option_defs)
3682         (make_info_threads_options_def_group): New.
3683         (info_threads_command): Use gdb::option::process_options.
3684         (info_threads_command_completer): New.
3685         (_initialize_thread): Use gdb::option::build_help to build the
3686         help text for "info threads".
3687
3688 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3689
3690         * defs.h (generic_load): Move from here...
3691         * symfile.h (generic_load): ... to here.  Rename name parameter
3692         to args.
3693         * symfile.c (generic_load): Add comment.
3694
3695 2019-07-01  Tom Tromey  <tromey@adacore.com>
3696
3697         * dwarf2read.c
3698         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
3699         declaration of without_params.  Fix formatting.
3700
3701 2019-07-01  Tom Tromey  <tromey@adacore.com>
3702
3703         * ada-exp.y (find_primitive_type): Update.
3704         * ada-lang.h (ada_lookup_symbol): Update.
3705         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
3706         parameter.
3707         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
3708
3709 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3710
3711         PR breakpoints/24541
3712         * gdbarch.c: Regenerate.
3713         * gdbarch.h: Regenerate.
3714         * gdbarch.sh: Add 'stap_adjust_register'.
3715         * i386-tdep.c: Include '<unordered_set>'.
3716         (i386_stap_adjust_register): New function.
3717         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
3718         * stap-probe.c (stap_parse_register_operand): Call
3719         'gdbarch_stap_adjust_register'.
3720
3721 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3722
3723         PR python/24742
3724         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
3725         * python/python.c (do_start_initialization): Use 'xmalloc'
3726         instead of 'PyMem_Malloc'.
3727
3728 2019-06-28  Tom Tromey  <tromey@adacore.com>
3729
3730         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
3731         for Ada.
3732
3733 2019-06-27  Tom Tromey  <tromey@adacore.com>
3734
3735         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
3736         objfile_key.
3737         (arm_find_mapping_symbol, arm_record_special_symbol)
3738         (_initialize_arm_tdep): Update.
3739         (arm_objfile_data_free): Remove.
3740
3741 2019-06-27  Tom Tromey  <tromey@adacore.com>
3742
3743         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
3744         to cp_print_static_field.
3745
3746 2019-06-26  Tom Tromey  <tromey@adacore.com>
3747
3748         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
3749         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
3750         declare.
3751
3752 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3753
3754         * features/aarch64-core.c (create_feature_aarch64_core):
3755         Regenerate.
3756         * features/aarch64-core.xml: Add cpsr flags.
3757
3758 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3759
3760         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
3761         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
3762
3763 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3764
3765         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
3766         field.
3767         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
3768         use.
3769         (arm_record_special_symbol): Don't insert new symbol in sorted
3770         position, push it at the end.
3771
3772 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3773
3774         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
3775         (arm_mapping_symbol_s): Remove.
3776         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
3777         (arm_mapping_symbol_vec): New typedef.
3778         (struct arm_per_objfile): Add constructor.
3779         <section_maps>: Change type to
3780         std::unique_ptr<arm_mapping_symbol_vec[]>.
3781         (arm_compare_mapping_symbols): Remove.
3782         (arm_find_mapping_symbol): Adjust to section_maps type change.
3783         (arm_objfile_data_free): Call delete on arm_per_objfile.
3784         (arm_record_special_symbol): Adjust to section_maps type change.
3785         Allocate arm_per_objfile with new.
3786
3787 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3788
3789         * cli/cli-cmds.c (alias_command): Compare the alias prefix
3790         with the command prefix.
3791
3792 2019-06-25  Tom Tromey  <tom@tromey.com>
3793
3794         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
3795         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
3796
3797 2019-06-25  Tom Tromey  <tom@tromey.com>
3798
3799         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
3800         type.
3801         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
3802         protected.
3803
3804 2019-06-25  Tom Tromey  <tom@tromey.com>
3805
3806         * tui/tui-winsource.c
3807         (tui_source_window_base::set_is_exec_point_at): Add check against
3808         LOA_ADDRESS.
3809
3810 2019-06-25  Tom Tromey  <tom@tromey.com>
3811
3812         * tui/tui-source.c (tui_set_source_content): Don't check before
3813         xfree.
3814         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
3815
3816 2019-06-25  Tom Tromey  <tom@tromey.com>
3817
3818         * tui/tui-winsource.h (tui_update_source_window_as_is)
3819         (tui_alloc_source_buffer, tui_line_is_displayed)
3820         (tui_addr_is_displayed): Change type of win_info.
3821         * tui/tui-winsource.c (tui_update_source_window_as_is)
3822         (tui_clear_source_content, tui_show_source_line)
3823         (tui_show_source_content, tui_source_window_base::refill)
3824         (tui_source_window_base::set_is_exec_point_at)
3825         (tui_source_window_base::set_is_exec_point_at)
3826         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
3827         (tui_alloc_source_buffer, tui_line_is_displayed)
3828         (tui_addr_is_displayed): Change type of win_info.  Update.
3829         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3830         (tui_source_window_base::do_make_visible_with_new_height):
3831         Update.
3832         * tui/tui-source.c (tui_set_source_content)
3833         (tui_set_source_content_nil)
3834         (tui_source_window::do_scroll_vertical): Update.
3835         * tui/tui-layout.c (show_layout): Update.
3836         * tui/tui-disasm.c (tui_set_disassem_content)
3837         (tui_disasm_window::do_scroll_vertical): Update.
3838         * tui/tui-data.h (tui_win_content): Remove.
3839         (struct tui_gen_win_info) <content, content_size>: Remove.
3840         (struct tui_source_element): Add initializers and destructor.
3841         (union tui_which_element, struct tui_win_element): Remove.
3842         (struct tui_source_window_base) <content>: New field.
3843         (struct tui_data_window): Remove destructor.
3844         (tui_alloc_content, tui_free_win_content)
3845         (tui_free_all_source_wins_content): Don't declare.
3846         * tui/tui-data.c (tui_initialize_static_data): Update.
3847         (init_content_element, tui_alloc_content): Remove.
3848         (~tui_gen_win_info): Update.
3849         (~tui_data_window, tui_free_all_source_wins_content)
3850         (tui_free_win_content, free_content, free_content_elements):
3851         Remove.
3852
3853 2019-06-25  Tom Tromey  <tom@tromey.com>
3854
3855         * tui/tui-winsource.h (tui_clear_source_content)
3856         (tui_erase_source_content, tui_show_source_content): Change type
3857         of win_info.
3858         * tui/tui-winsource.c (tui_clear_source_content)
3859         (tui_erase_source_content, tui_show_source_content): Change type
3860         of win_info.
3861         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3862         * tui/tui-source.h (tui_set_source_content_nil): Change type of
3863         win_info.
3864         * tui/tui-source.c (tui_set_source_content_nil): Change type of
3865         win_info.
3866         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
3867
3868 2019-06-25  Tom Tromey  <tom@tromey.com>
3869
3870         * tui/tui-winsource.c (tui_clear_source_content)
3871         (tui_source_window_base::set_is_exec_point_at): Update.
3872         * tui/tui-source.c (tui_set_source_content_nil): Update.
3873         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
3874         a bool.
3875         * tui/tui-data.c (init_content_element): Update.
3876
3877 2019-06-25  Tom Tromey  <tom@tromey.com>
3878
3879         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
3880         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
3881         * tui/tui-layout.c (init_and_make_win): Update.
3882         * tui/tui.h (enum tui_win_type): Update.
3883         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
3884         tui_win_is_auxillary.
3885         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
3886         tui_win_is_auxillary.
3887
3888 2019-06-25  Tom Tromey  <tom@tromey.com>
3889
3890         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
3891         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
3892         (tui_delete_data_content_windows, tui_display_all_data)
3893         (tui_data_window::do_scroll_vertical, tui_display_data_from):
3894         Update.
3895         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
3896         * tui/tui-regs.c (tui_last_regs_line_no)
3897         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3898         (tui_show_registers): Update.
3899         (tui_show_register_group): Return void.  Update.
3900         (tui_display_registers_from, tui_display_reg_element_at_line)
3901         (tui_display_registers_from_line, tui_check_register_values):
3902         Update.
3903         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
3904         member.
3905         (struct tui_data_window) <regs_content>: Now a std::vector.
3906         <regs_content_count>: Remove.
3907         (tui_add_content_elements, tui_free_data_content): Don't declare.
3908         * tui/tui-data.c (tui_data_window::clear_detail): Update.
3909         (init_content_element): Remove DATA_WIN case.  Add assert.
3910         (tui_add_content_elements): Remove.
3911         (tui_data_window): Update.
3912         (tui_free_data_content): Remove.
3913         (free_content_elements): Remove DATA_WIN case.
3914
3915 2019-06-25  Tom Tromey  <tom@tromey.com>
3916
3917         * tui/tui-data.c (tui_data_item_window): Update.
3918         * tui/tui-windata.h (tui_check_data_values): Don't declare.
3919         * tui/tui-windata.c (tui_display_all_data)
3920         (tui_display_data_from_line): Update.
3921         (tui_check_data_values): Remove.
3922         * tui/tui-regs.c (tui_show_register_group)
3923         (tui_display_reg_element_at_line): Update.
3924         * tui/tui-hooks.c (tui_register_changed)
3925         (tui_refresh_frame_and_register_information): Call
3926         tui_check_register_values.
3927         * tui/tui-data.h (struct tui_data_window) <data_content,
3928         data_content_count, data_type>: Remove.
3929         (enum tui_data_type): Remove.
3930
3931         * tui/tui-data.c (tui_data_window::clear_detail)
3932         (~tui_data_window): Update.
3933
3934 2019-06-25  Tom Tromey  <tom@tromey.com>
3935
3936         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
3937         declare.
3938         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
3939         Rename from tui_first_data_item_displayed.  Update.
3940         (tui_data_window::refresh_all)
3941         (tui_data_window::do_scroll_vertical): Update.
3942         * tui/tui-data.h (struct tui_data_window)
3943         <first_data_item_displayed>: Declare new method.
3944
3945 2019-06-25  Tom Tromey  <tom@tromey.com>
3946
3947         * tui/tui-data.h (tui_init_generic_part): Don't declare.
3948         * tui/tui-data.c (tui_init_generic_part): Remove, moving
3949         contents...
3950         (tui_initialize_static_data): ...here.
3951
3952 2019-06-25  Tom Tromey  <tom@tromey.com>
3953
3954         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3955         (tui_display_registers_from, tui_check_register_values): Update.
3956         (tui_display_register): Remove win_info parameter; update.
3957         (tui_get_register): Change type of parameters.
3958         * tui/tui-data.h (struct tui_data_element): Remove.
3959         (union tui_which_element) <data>: Remove.
3960         <data_window>: Change type.
3961         (struct tui_data_item_window): New.
3962         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3963         case.  Add assert.
3964         (~tui_data_item_window): New destructor.
3965         (free_content_elements): Remove DATA_ITEM_WIN case.
3966
3967 2019-06-25  Tom Tromey  <tom@tromey.com>
3968
3969         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3970         Remove.
3971
3972 2019-06-25  Tom Tromey  <tom@tromey.com>
3973
3974         * tui/tui-data.h (struct tui_command_element): Remove.
3975         (union tui_which_element) <command>: Remove.
3976         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
3977         assert.
3978         (free_content_elements): Remove CMD_WIN case.
3979
3980 2019-06-25  Tom Tromey  <tom@tromey.com>
3981
3982         * tui/tui-layout.c (tui_set_layout): Update.
3983         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3984         * tui/tui-data.c (layout_def): Update.
3985
3986 2019-06-25  Tom Tromey  <tom@tromey.com>
3987
3988         * tui/tui-wingeneral.c (tui_refresh_all): Update.
3989         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3990         (tui_source_window_base::set_new_height): Update.
3991         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3992         Update.
3993         (tui_set_locator_fullname, tui_set_locator_info)
3994         (tui_show_frame_info): Update.
3995         * tui/tui-source.c (tui_set_source_content)
3996         (tui_source_is_displayed): Update.
3997         * tui/tui-layout.c (show_source_disasm_command, show_data)
3998         (show_source_or_disasm_and_command): Update.
3999         * tui/tui-disasm.c (tui_set_disassem_content)
4000         (tui_get_begin_asm_address): Update.
4001         * tui/tui-data.h (struct tui_locator_element): Remove.
4002         (union tui_which_element) <locator>: Remove.
4003         (struct tui_locator_window): New.
4004         (tui_locator_win_info_ptr): Change return type.
4005         * tui/tui-data.c (_locator): Change type.
4006         (tui_locator_win_info_ptr): Change return type.
4007         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
4008         (tui_alloc_content): Add assert.
4009
4010 2019-06-25  Tom Tromey  <tom@tromey.com>
4011
4012         * tui/tui-winsource.c
4013         (tui_exec_info_window::maybe_allocate_content): New method.
4014         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
4015         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
4016         (make_source_or_disasm_window): Add cast.
4017         * tui/tui-data.h (union tui_which_element) <simple_string>:
4018         Remove.
4019         (struct tui_source_info): New.
4020         (struct tui_source_window_base) <execution_info>: Change type.
4021         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
4022         case, and add assert.
4023         (tui_alloc_content): Add assert.
4024
4025 2019-06-25  Tom Tromey  <tom@tromey.com>
4026
4027         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
4028         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
4029         * tui/tui-data.c (tui_alloc_win_info): Remove.
4030
4031 2019-06-25  Tom Tromey  <tom@tromey.com>
4032
4033         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
4034         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
4035         can_highlight.
4036
4037 2019-06-25  Tom Tromey  <tom@tromey.com>
4038
4039         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
4040         make_visible_with_new_height method.
4041         (tui_win_info::make_visible_with_new_height): New method.
4042         (tui_source_window_base::do_make_visible_with_new_height)
4043         (tui_data_window::do_make_visible_with_new_height)
4044         (tui_cmd_window::do_make_visible_with_new_height): New methods.
4045         (make_visible_with_new_height): Remove.
4046         (tui_resize_all, tui_adjust_win_heights): Use
4047         make_visible_with_new_height method.
4048         * tui/tui-data.h (struct tui_win_info)
4049         <do_make_visible_with_new_height, make_visible_with_new_height>:
4050         New methods.
4051         (struct tui_source_window_base, struct tui_data_window)
4052         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
4053         methods.
4054
4055 2019-06-25  Tom Tromey  <tom@tromey.com>
4056
4057         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
4058         method.
4059         (update_tab_width): Call update_tab_width method.
4060         * tui/tui-data.h (struct tui_win_info)
4061         (struct tui_source_window_base) <update_tab_width>: New methods.
4062
4063 2019-06-25  Tom Tromey  <tom@tromey.com>
4064
4065         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
4066         parameter.
4067         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
4068         parameter.
4069         (tui_gen_win_info::make_visible): Update.
4070         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
4071         parameter.
4072         * tui/tui-data.h (enum tui_box): New enum.
4073         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
4074
4075 2019-06-25  Tom Tromey  <tom@tromey.com>
4076
4077         * tui/tui-layout.c (make_source_or_disasm_window): Always use
4078         init_and_make_win for EXEC_INFO_WIN.
4079         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
4080         longer inline.
4081         (struct tui_win_info) <~tui_win_info>: Inline.
4082         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4083         Don't declare.
4084         * tui/tui-data.c (source_win, disasm_win): Remove globals.
4085         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4086         Remove.
4087         (tui_initialize_static_data): Update.
4088         (~tui_gen_win_info): Handle more cleanup here.
4089         (~tui_source_window_base): Delete "execution_info".
4090         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
4091
4092 2019-06-25  Tom Tromey  <tom@tromey.com>
4093
4094         * tui/tui-layout.c (make_command_window): Don't set
4095         can_highlight.
4096         (show_source_disasm_command): Call the reset method.
4097         (show_data): Don't set can_highlight.  Call the reset method.
4098         (tui_gen_win_info::reset): Rename from init_gen_win_info
4099         (init_and_make_win): Simplify.  Return tui_gen_win_info.
4100         (show_source_or_disasm_and_command): Call the reset method.
4101         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
4102         (struct tui_cmd_window): Set can_highlight.
4103
4104 2019-06-25  Tom Tromey  <tom@tromey.com>
4105
4106         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
4107         from make_visible.
4108         (tui_make_visible, tui_make_invisible): Rewrite.
4109         (tui_win_info::make_visible): Remove.
4110         (tui_source_window_base::make_visible): Update.
4111         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
4112         method.  Moved from...
4113         (struct tui_win_info) <make_visible>: ...here.
4114
4115 2019-06-25  Tom Tromey  <tom@tromey.com>
4116
4117         * tui/tui-winsource.c
4118         (tui_source_window_base::do_scroll_horizontal): Remove direction
4119         parameter.
4120         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
4121         direction parameter.
4122         * tui/tui-win.c (tui_win_info::forward_scroll)
4123         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4124         (tui_win_info::right_scroll): Update.
4125         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
4126         direction parameter.
4127         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
4128         direction parameter.
4129         * tui/tui-data.h (enum tui_scroll_direction): Remove.
4130         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
4131         Remove direction parameter.
4132         (struct tui_source_window_base, struct tui_source_window)
4133         (struct tui_disasm_window, struct tui_data_window)
4134         (struct tui_cmd_window): Update.
4135
4136 2019-06-25  Tom Tromey  <tom@tromey.com>
4137
4138         * tui/tui-winsource.h (tui_set_exec_info_content)
4139         (tui_show_exec_info_content, tui_erase_exec_info_content)
4140         (tui_clear_exec_info_content, tui_update_exec_info): Change
4141         argument to tui_source_window_base.
4142         * tui/tui-winsource.c (tui_set_exec_info_content)
4143         (tui_show_exec_info_content, tui_erase_exec_info_content)
4144         (tui_clear_exec_info_content, tui_update_exec_info): Change
4145         argument to tui_source_window_base.
4146
4147 2019-06-25  Tom Tromey  <tom@tromey.com>
4148
4149         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
4150         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
4151
4152 2019-06-25  Tom Tromey  <tom@tromey.com>
4153
4154         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
4155         check.
4156
4157 2019-06-25  Tom Tromey  <tom@tromey.com>
4158
4159         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
4160         type to void.
4161         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
4162         type to void.
4163         * tui/tui-source.c (tui_set_source_content): Update.
4164         * tui/tui-disasm.c (tui_set_disassem_content): Update.
4165
4166 2019-06-25  Tom Tromey  <tom@tromey.com>
4167
4168         * tui/tui-win.c (window_name_completer, tui_set_focus)
4169         (tui_all_windows_info): Use name method.
4170         * tui/tui-data.h (struct tui_gen_win_info)
4171         (struct tui_source_window, struct tui_disasm_window)
4172         (struct tui_data_window, struct tui_cmd_window) <name>: New
4173         method.
4174         (tui_win_name): Don't declare.
4175         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
4176         (tui_win_name): Remove.
4177
4178 2019-06-25  Tom Tromey  <tom@tromey.com>
4179
4180         * tui/tui-winsource.h (tui_update_source_window)
4181         (tui_update_source_window_as_is): Change parameter type.
4182         * tui/tui-winsource.c (tui_update_source_window): Change win_info
4183         to be a tui_source_window_base.
4184         (tui_update_source_window_as_is): Likewise.
4185         * tui/tui-win.c (make_visible_with_new_height): Update.
4186
4187 2019-06-25  Tom Tromey  <tom@tromey.com>
4188
4189         * tui/tui-winsource.c (tui_erase_source_content)
4190         (tui_show_source_content, tui_show_exec_info_content)
4191         (tui_erase_exec_info_content): Use refresh_window method.
4192         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
4193         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
4194         from tui_refresh_win.
4195         (tui_data_window::refresh_window): New method.
4196         (tui_win_info::refresh, tui_source_window_base::refresh)
4197         (tui_refresh_all): Use refresh_window method.
4198         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
4199         method.
4200         * tui/tui-regs.c (tui_display_register): Call refresh_window
4201         method.
4202         * tui/tui-layout.c (show_source_disasm_command)
4203         (show_source_or_disasm_and_command): Call refresh_window method.
4204         * tui/tui-data.h (struct tui_gen_win_info)
4205         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
4206         New method.
4207
4208 2019-06-25  Tom Tromey  <tom@tromey.com>
4209
4210         * tui/tui.c (tui_rl_other_window, tui_enable)
4211         (tui_is_window_visible, tui_get_command_dimension): Update.
4212         * tui/tui-winsource.c (tui_update_source_window_as_is)
4213         (tui_clear_source_content, tui_erase_source_content)
4214         (tui_show_source_line, tui_source_window_base::refill)
4215         (tui_source_window_base::do_scroll_horizontal)
4216         (tui_source_window_base::set_is_exec_point_at)
4217         (tui_update_breakpoint_info, tui_set_exec_info_content)
4218         (tui_alloc_source_buffer, tui_line_is_displayed)
4219         (tui_addr_is_displayed): Update.
4220         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4221         (tui_check_and_display_highlight_if_needed)
4222         (tui_win_info::make_visible, tui_win_info::refresh)
4223         (tui_refresh_all): Update.
4224         * tui/tui-windata.c (tui_first_data_item_displayed)
4225         (tui_delete_data_content_windows, tui_erase_data_content)
4226         (tui_display_all_data, tui_data_window::refresh_all)
4227         (tui_check_data_values): Update.
4228         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
4229         (tui_set_win_focus_to, tui_win_info::forward_scroll)
4230         (tui_win_info::backward_scroll, tui_refresh_all_win)
4231         (tui_resize_all, tui_set_focus, tui_all_windows_info)
4232         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
4233         (tui_source_window_base::set_new_height)
4234         (tui_data_window::set_new_height)
4235         (make_invisible_and_set_new_height)
4236         (make_visible_with_new_height, new_height_ok)
4237         (parse_scrolling_args): Update.
4238         * tui/tui-stack.c (tui_show_frame_info): Update.
4239         * tui/tui-source.c (tui_set_source_content)
4240         (tui_set_source_content_nil, tui_source_is_displayed)
4241         (tui_source_window::do_scroll_vertical): Update.
4242         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4243         (tui_display_registers_from, tui_display_reg_element_at_line)
4244         (tui_check_register_values, tui_reg_command): Update.
4245         * tui/tui-layout.c (tui_default_win_height)
4246         (show_source_disasm_command, show_data, init_and_make_win)
4247         (show_source_or_disasm_and_command): Update.
4248         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
4249         (tui_redisplay_readline, tui_mld_flush)
4250         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
4251         (tui_getc): Update.
4252         * tui/tui-disasm.c (tui_set_disassem_content)
4253         (tui_disasm_window::do_scroll_vertical): Update.
4254         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
4255         Now virtual.
4256         (struct tui_win_info): Derive from tui_gen_win_info.
4257         <~tui_win_info>: Mark as override.
4258         <generic>: Remove member.
4259         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
4260         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
4261         (~tui_data_window, ~tui_win_info)
4262         (tui_free_all_source_wins_content): Update.
4263         * tui/tui-command.c (tui_refresh_cmd_win): Update.
4264
4265 2019-06-25  Tom Tromey  <tom@tromey.com>
4266
4267         * tui/tui-layout.c (init_and_make_win): Use new.
4268         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
4269         destructor, initializers.
4270         (tui_alloc_generic_win_info): Don't declare.
4271         * tui/tui-data.c (_locator): Add argument to constructor.
4272         (source_win, disasm_win): New globals.
4273         (exec_info): Remove.
4274         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4275         Update.
4276         (tui_alloc_generic_win_info): Remove.
4277         (init_content_element): Use new.
4278         (tui_win_info::tui_win_info): Update.
4279         (free_content_elements) <case DATA_WIN>: Use delete.
4280
4281 2019-06-25  Tom Tromey  <tom@tromey.com>
4282
4283         * tui/tui-wingeneral.c (tui_refresh_win): Update.
4284         * tui/tui-windata.c (tui_first_data_item_displayed)
4285         (tui_delete_data_content_windows): Update.
4286         * tui/tui-win.c (tui_data_window::set_new_height): Update.
4287         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4288         (tui_display_registers_from, tui_check_register_values): Update.
4289         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
4290         pointer.
4291         * tui/tui-data.c (init_content_element): Update.  Allocate the new
4292         window.
4293         (tui_free_data_content): Update.
4294         (free_content_elements) <case DATA_WIN>: Free the window.
4295
4296 2019-06-25  Tom Tromey  <tom@tromey.com>
4297
4298         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
4299         Update.
4300         * tui/tui-layout.c (make_command_window)
4301         (show_source_disasm_command, show_data, init_and_make_win)
4302         (show_source_or_disasm_and_command): Update.
4303         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
4304         method.
4305         <can_highight, is_highlighted>: Now bool.
4306         (tui_set_win_highlight): Don't declare.
4307         * tui/tui-data.c (tui_set_win_highlight): Remove.
4308
4309 2019-06-25  Tom Tromey  <tom@tromey.com>
4310
4311         * tui/tui-wingeneral.c (make_visible): Remove check of window
4312         type.
4313
4314 2019-06-25  Tom Tromey  <tom@tromey.com>
4315
4316         * tui/tui-win.c (tui_win_info::max_height)
4317         (tui_cmd_window::max_height): New methods.
4318         (new_height_ok): Call max_height.
4319         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
4320         <max_height>: New method.
4321
4322 2019-06-25  Tom Tromey  <tom@tromey.com>
4323
4324         * tui/tui-win.c (tui_source_window_base::set_new_height)
4325         (tui_data_window::set_new_height): New methods.
4326         (make_invisible_and_set_new_height): Call set_new_height method.
4327         * tui/tui-data.h (struct tui_win_info)
4328         (struct tui_source_window_base, struct tui_data_window)
4329         <set_new_height>: New method.
4330
4331 2019-06-25  Tom Tromey  <tom@tromey.com>
4332
4333         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
4334         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
4335         tui_refresh_data_win.
4336         * tui/tui-win.c (tui_source_window_base::refresh_all): New
4337         method.
4338         (tui_refresh_all_win): Call the refresh_all method.
4339         (tui_set_focus): Likewise.
4340         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
4341         (struct tui_source_window_base, struct tui_data_window) <refresh>:
4342         Likewise.
4343
4344 2019-06-25  Tom Tromey  <tom@tromey.com>
4345
4346         * tui/tui-winsource.h (tui_refill_source_window)
4347         (tui_set_is_exec_point_at): Don't declare.
4348         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4349         (tui_source_window_base::refill): Rename from
4350         tui_refill_source_window.
4351         (tui_source_window_base::do_scroll_horizontal): Update.
4352         (tui_source_window_base::set_is_exec_point_at): Rename from
4353         tui_set_is_exec_point_at.
4354         (tui_update_all_breakpoint_info): Update.
4355         * tui/tui-stack.c (tui_show_frame_info): Update.
4356         * tui/tui-layout.c (show_data): Add cast.
4357         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
4358         * tui/tui-data.h (struct tui_source_window_base) <refill,
4359         set_is_exec_point_at>: New methods.
4360         (tui_source_windows, tui_add_to_source_windows): Update types.
4361         (tui_add_to_source_windows): Remove redundant declaration.
4362         * tui/tui-data.c (source_windows): Store tui_source_window_base.
4363         (tui_source_windows): Change return type.
4364         (tui_clear_source_windows_detail): Update.
4365         (tui_add_to_source_windows): Change type of parameter.
4366         (tui_free_all_source_wins_content): Update.
4367
4368 2019-06-25  Tom Tromey  <tom@tromey.com>
4369
4370         * tui/tui-wingeneral.c (tui_win_info::refresh)
4371         (tui_source_window_base::refresh): New methods.
4372         (tui_refresh_all): Call the refresh method.
4373         * tui/tui-data.h (struct tui_win_info)
4374         (struct tui_source_window_base) <refresh>: New method.
4375
4376 2019-06-25  Tom Tromey  <tom@tromey.com>
4377
4378         * tui/tui.h (tui_is_window_visible): Return bool.
4379         * tui/tui.c (tui_is_window_visible): Return bool.
4380         * tui/tui-wingeneral.c (tui_make_window, make_visible)
4381         (tui_make_visible, tui_make_invisible)
4382         (tui_win_info::make_visible)
4383         (tui_source_window_base::make_visible, make_all_visible)
4384         (tui_make_all_visible, tui_make_all_invisible): Update.
4385         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
4386         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
4387         bool.
4388         (struct tui_win_info, struct tui_source_window_base)
4389         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
4390         * tui/tui-data.c (tui_init_generic_part): Update.
4391
4392 2019-06-25  Tom Tromey  <tom@tromey.com>
4393
4394         * tui/tui-wingeneral.c (tui_win_info::make_visible)
4395         (tui_source_window_base::make_visible): New methods.
4396         (make_all_visible): Make method call.
4397         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
4398         (struct tui_source_window_base, struct tui_cmd_window): Override
4399         make_visible.
4400         (tui_win_is_source_type): Don't declare.
4401         * tui/tui-data.c (tui_win_is_source_type): Remove.
4402
4403 2019-06-25  Tom Tromey  <tom@tromey.com>
4404
4405         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
4406         NULL check.
4407
4408 2019-06-25  Tom Tromey  <tom@tromey.com>
4409
4410         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
4411         Inline constructor.  Add initializers for members.
4412         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
4413         constructors; now inline in class.
4414
4415 2019-06-25  Tom Tromey  <tom@tromey.com>
4416
4417         * tui/tui-regs.c (tui_show_registers): Update.
4418         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
4419         bool.
4420         * tui/tui-data.c (tui_data_window::clear_detail)
4421         (tui_data_window): Update.
4422
4423 2019-06-25  Tom Tromey  <tom@tromey.com>
4424
4425         * tui/tui-windata.c (tui_display_all_data)
4426         (tui_display_data_from_line, tui_display_data_from)
4427         (tui_check_data_values, tui_data_window::do_scroll_vertical):
4428         Update.
4429         * tui/tui-regs.c (tui_last_regs_line_no)
4430         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4431         (tui_show_registers, tui_show_register_group)
4432         (tui_display_registers_from, tui_display_reg_element_at_line)
4433         (tui_display_registers_from_line, tui_check_register_values)
4434         (tui_reg_next, tui_reg_prev): Update.
4435         * tui/tui-layout.c (tui_set_layout, show_data): Update.
4436         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
4437         tui_data_window.
4438         (struct tui_win_info) <detail>: Remove.  Add new fields from
4439         tui_data_info.
4440         (TUI_DATA_WIN): Add cast.
4441         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
4442         (~tui_data_window): Simplify.
4443
4444 2019-06-25  Tom Tromey  <tom@tromey.com>
4445
4446         * tui/tui-layout.c (show_source_disasm_command)
4447         (show_source_or_disasm_and_command): Update.
4448         * tui/tui-io.c (update_cmdwin_start_line)
4449         (tui_redisplay_readline): Update.
4450         * tui/tui-data.h (struct tui_command_info): Remove.
4451         (struct tui_win_info) <detail>: Remove command_info member.
4452         (struct tui_data_window) <start_line>: New member, from
4453         tui_command_info.
4454         (TUI_CMD_WIN): Add casts.
4455
4456 2019-06-25  Tom Tromey  <tom@tromey.com>
4457
4458         * tui/tui-winsource.c (tui_update_source_window)
4459         (tui_refill_source_window)
4460         (tui_source_window_base::do_scroll_horizontal)
4461         (tui_update_breakpoint_info, tui_set_exec_info_content)
4462         (tui_show_exec_info_content, tui_erase_exec_info_content)
4463         (tui_clear_exec_info_content): Update.
4464         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
4465         Update.
4466         * tui/tui-win.c (make_invisible_and_set_new_height)
4467         (make_visible_with_new_height): Update.
4468         * tui/tui-source.c (tui_set_source_content)
4469         (tui_show_symtab_source): Update.
4470         * tui/tui-layout.c (extract_display_start_addr)
4471         (show_source_disasm_command, show_data)
4472         (make_source_or_disasm_window)
4473         (show_source_or_disasm_and_command): Update.
4474         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
4475         (tui_disasm_window::do_scroll_vertical): Remove shadowing
4476         "gdbarch".
4477         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
4478         to tui_source_window_base.
4479         (struct tui_win_info) <detail>: Remove source_info member.
4480         (struct tui_source_window_base) <has_locator>: Inline.
4481         Move contents from tui_source_info; rename has_locator member to
4482         m_has_locator.
4483         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
4484         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
4485         header file.
4486         (tui_source_window_base::clear_detail, ~tui_source_window_base):
4487         Simplify.
4488         (tui_free_all_source_wins_content): Cast to
4489         tui_source_window_base.
4490
4491 2019-06-25  Tom Tromey  <tom@tromey.com>
4492
4493         * tui/tui-win.c (make_invisible_and_set_new_height)
4494         (make_visible_with_new_height): Call has_locator method.
4495         * tui/tui-layout.c (show_source_disasm_command, show_data)
4496         (show_source_or_disasm_and_command): Update for bool change.
4497         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
4498         (tui_win_info) <has_locator>: New method.
4499         (struct tui_source_window_base) <has_locator>: New method.
4500         (tui_win_has_locator): Don't declare.
4501         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
4502         from tui_win_has_locator.
4503         (tui_source_window_base): Use false, not FALSE.
4504
4505 2019-06-25  Tom Tromey  <tom@tromey.com>
4506
4507         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
4508         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
4509         clear_detail method directly.
4510         (tui_clear_win_detail): Remove.
4511
4512 2019-06-25  Tom Tromey  <tom@tromey.com>
4513
4514         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
4515         "this", not TUI_DISASM_WIN.
4516
4517 2019-06-25  Tom Tromey  <tom@tromey.com>
4518
4519         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
4520         declare.
4521         * tui/tui-winsource.c
4522         (tui_source_window_base::do_scroll_horizontal): Rename from
4523         tui_horizontal_source_scroll.
4524         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
4525         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
4526         from tui_vertical_data_scroll.
4527         * tui/tui-win.h (tui_scroll): Don't declare.
4528         * tui/tui-win.c (tui_win_info::forward_scroll)
4529         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4530         (tui_win_info::right_scroll): Rename and update.
4531         (tui_scroll_forward_command, tui_scroll_backward_command)
4532         (tui_scroll_left_command, tui_scroll_right_command): Update.
4533         (tui_scroll): Remove.
4534         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
4535         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
4536         from tui_vertical_source_scroll.
4537         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
4538         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
4539         from tui_vertical_disassem_scroll.
4540         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
4541         do_scroll_horizontal>: New methods.
4542         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
4543         Likewise.
4544         (struct tui_source_window_base): Add do_scroll_horizontal.
4545         (struct tui_source_window, struct tui_disasm_window): Add
4546         do_scroll_vertical.
4547         (struct tui_data_window, struct tui_cmd_window): Add
4548         do_scroll_horizontal and do_scroll_vertical.
4549         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
4550
4551 2019-06-25  Tom Tromey  <tom@tromey.com>
4552
4553         * tui/tui-data.h (struct tui_source_window_base): New struct.
4554         (struct tui_source_window): Derive from tui_source_window_base.
4555         (struct tui_disasm_window): New struct.
4556         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
4557         from tui_source_window::clear_detail.
4558         (tui_source_window_base): Rename from tui_source_window.
4559         (~tui_source_window_base): Rename from ~tui_source_window.
4560         (tui_alloc_win_info): Create a tui_disasm_window.
4561
4562 2019-06-25  Tom Tromey  <tom@tromey.com>
4563
4564         * tui/tui-data.h (struct tui_source_window)
4565         (struct tui_data_window): Declare destructors.
4566         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
4567         destructors.
4568         (tui_win_info): Simplify.
4569
4570 2019-06-25  Tom Tromey  <tom@tromey.com>
4571
4572         * tui/tui-winsource.c (tui_display_main)
4573         (tui_update_source_windows_with_addr)
4574         (tui_update_all_breakpoint_info): Update.
4575         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4576         (new_height_ok, parse_scrolling_args): Update.
4577         * tui/tui-stack.c (tui_show_frame_info): Update.
4578         * tui/tui-data.h (struct tui_list): Remove.
4579         (tui_source_windows): Return a reference to a std::vector.
4580         * tui/tui-data.c (source_windows): Now a std::vector.
4581         (tui_source_windows): Change return type.
4582         (tui_clear_source_windows): Rewrite.
4583         (tui_clear_source_windows_detail, tui_add_to_source_windows)
4584         (tui_free_all_source_wins_content): Rewrite.
4585
4586 2019-06-25  Tom Tromey  <tom@tromey.com>
4587
4588         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
4589         (struct tui_data_window, struct tui_cmd_window): Declare
4590         clear_detail method.
4591         * tui/tui-data.c (tui_source_window::clear_detail)
4592         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
4593         methods.
4594         (tui_clear_win_detail): Simplify.
4595
4596 2019-06-25  Tom Tromey  <tom@tromey.com>
4597
4598         * tui/tui-layout.c (make_source_window, make_disasm_window)
4599         (make_source_or_disasm_window): Remove win_info_ptr parameter.
4600         Return the new window.
4601         (show_source_disasm_command, show_data)
4602         (show_source_or_disasm_and_command): Update.
4603
4604 2019-06-25  Tom Tromey  <tom@tromey.com>
4605
4606         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
4607         parameter.  Return the new window.
4608         (show_source_disasm_command): Update and remove NULL check.
4609         (show_source_or_disasm_and_command): Update.
4610
4611 2019-06-25  Tom Tromey  <tom@tromey.com>
4612
4613         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
4614
4615 2019-06-25  Tom Tromey  <tom@tromey.com>
4616
4617         * tui/tui-data.h (struct tui_win_info): Make constructor
4618         protected.  Make destructor virtual.  Add initializers.
4619         (tui_source_window, tui_data_window, tui_cmd_window): New
4620         classes.
4621         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
4622         constructor.  Add "type" parameter.
4623         (tui_source_window, tui_data_window, tui_cmd_window): New
4624         constructors.
4625         (tui_alloc_win_info): Instantiate the appropriate subclass.
4626
4627 2019-06-25  Tom Tromey  <tom@tromey.com>
4628
4629         * tui/tui-win.c (tui_resize_all): Use delete.
4630         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
4631         destructor.
4632         (tui_free_window): Don't declare.
4633         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
4634         Update.
4635
4636 2019-06-25  Tom Tromey  <tom@tromey.com>
4637
4638         * tui/tui-data.h (struct tui_win_info): Add constructor.
4639         * tui/tui-data.c (tui_alloc_win_info): Use new.
4640         (tui_free_window): Use delete.
4641
4642 2019-06-22  Tom Tromey  <tom@tromey.com>
4643
4644         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
4645         declare.
4646         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
4647
4648 2019-06-22  Tom Tromey  <tom@tromey.com>
4649
4650         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
4651         declare.
4652         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
4653
4654 2019-06-22  Tom de Vries  <tdevries@suse.de>
4655
4656         * dwarf2read.c (create_addrmap_from_aranges)
4657         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
4658         instead of '%zu'.
4659
4660 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
4661
4662         * dwarf2read.h (dwarf2_section_info_def): Remove.
4663         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
4664         * dwarf2read.c (struct dwo_sections) <types>: Change type to
4665         std::vector<dwarf2_section_info>.
4666         (struct dwo_file) <~dwo_file>: Remove.
4667         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
4668         types field.
4669         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
4670         (dwarf2_read_debug_names): Likewise.
4671         (create_debug_types_hash_table): Change parameter type to
4672         array_view, adjust code accordingly.
4673         (dwarf2_locate_dwo_sections): Adjust to std::vector.
4674         (partial_die_info::fixup): Likewise.
4675         (determine_prefix): Likewise.
4676         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
4677
4678 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4679
4680         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
4681         gdb_bfd_ref_ptr.
4682         <~dwo_file>: Remove call to gdb_bfd_unref.
4683         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
4684         gdb_bfd_ref_ptr::get.
4685
4686 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4687
4688         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
4689         type to htab_up.
4690         * dwarf2read.c (struct dwo_file): Initialize fields.
4691         <~dwo_file>: New.
4692         (free_dwo_file): Remove, move content to ~dwo_file.
4693         (struct dwo_file_deleter): Remove.
4694         (dwo_file_up>: Remove custom deleter.
4695         (free_dwo_files): Remove.
4696         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
4697         dwo_files.
4698         (process_skeletonless_type_units): Call unique_ptr::get.
4699         (allocate_dwo_file_hash_table): Add deleter to created hash
4700         table.  Change return type to htab_up.
4701         (lookup_dwo_file_slot): Don't memset dwo_file, call
4702         unique_ptr::get.
4703         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
4704         (create_dwo_unit_in_dwp_v2): Likewise.
4705         (open_and_init_dwo_file): Likewise.
4706         (free_dwo_file_from_slot): Remove.
4707
4708 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4709
4710         * dwarf2read.h (struct dwarf2_section_info) <readin,
4711         is_virtual>: Change type to bool.
4712         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
4713         true instead of 1.
4714
4715 2019-06-19  Tom Tromey  <tom@tromey.com>
4716
4717         * tui/tui-data.h (tui_init_content_element): Don't declare.
4718
4719 2019-06-19  Tom Tromey  <tom@tromey.com>
4720
4721         * tui/tui-data.h (tui_init_win_info): Don't declare.
4722
4723 2019-06-19  Tom de Vries  <tdevries@suse.de>
4724
4725         * dwarf2read.h (abstract_to_concrete): Change type to
4726         std::unordered_map<sect_offset, std::vector<sect_offset>,
4727         gdb::hash_enum<sect_offset>>.
4728
4729 2019-06-19  Tom Tromey  <tromey@adacore.com>
4730
4731         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
4732         EVAL_AVOID_SIDE_EFFECTS specially.
4733
4734 2019-06-19  Tom Tromey  <tromey@adacore.com>
4735
4736         * source-cache.c (highlighter): New global.
4737         (source_cache::get_source_lines): Create a highlighter on demand.
4738
4739 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4740
4741         * defs.h (deprecated_interactive_hook): Delete declaration.
4742         * interps.c (clear_interpreter_hooks): Remove use of
4743         deprecated_interactive_hook.
4744         * top.c (deprecated_interactive_hook): Delete definition.
4745         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
4746
4747 2019-06-18  Tom de Vries  <tdevries@suse.de>
4748
4749         PR gdb/24515
4750         * dwarf2read.h (abstract_to_concrete): Change type from
4751         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
4752         std::unordered_map<sect_offset, std::vector<sect_offset>>.
4753         * dwarf2read.c (read_variable): Update.
4754         (dwarf2_fetch_die_loc_sect_off): Update.
4755
4756 2019-06-17  Tom de Vries  <tdevries@suse.de>
4757
4758         PR gdb/24617
4759         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
4760         accessing parent[parent_len - 1].
4761
4762 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
4763
4764         PR gdb/24364
4765         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
4766         call dtrace_process_dof with NULL dof.
4767
4768 2019-06-16  Tom de Vries  <tdevries@suse.de>
4769
4770         PR gdb/24445
4771         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
4772
4773 2019-06-16  Tom Tromey  <tom@tromey.com>
4774
4775         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4776         (make_all_visible): Use address of member.
4777
4778 2019-06-16  Tom Tromey  <tom@tromey.com>
4779
4780         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
4781         (tui_free_window, free_content, free_content_elements): Remove
4782         unnecessary cast.
4783         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
4784         cast.
4785         * tui/tui-regs.c (tui_show_register_group)
4786         (tui_display_registers_from, tui_display_reg_element_at_line):
4787         Remove unnecessary cast.
4788
4789 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
4790
4791         * linux-nat.c (normal_mask): Delete.
4792         (_initialize_linux_nat): Don't initialise normal_mask.
4793
4794 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
4795
4796         PR gdb/24445
4797         * dwarf-index-write.h (write_psymtabs_to_index): Add
4798         dwz_basename parameter.
4799         * dwarf-index-write.c (write_gdbindex): Move file writing to
4800         write_gdbindex_1.  Change return type void.
4801         (assert_file_size): Move up, remove filename parameter.
4802         (write_gdbindex_1): New function.
4803         (write_debug_names): Change return type to void, call
4804         assert_file_size.
4805         (struct index_wip_file): New struct.
4806         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
4807         file logic to index_wip_file.  Write index for dwz file if
4808         needed.
4809         (save_gdb_index_command): Pass basename of dwz file, if present.
4810         * dwarf-index-cache.c (index_cache::store): Obtain and pass
4811         build-id of dwz file, if present.
4812         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
4813         (dwarf2_get_dwz_file): Likewise.
4814         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
4815         (dwarf2_get_dwz_file): Likewise.
4816
4817 2019-06-16  Tom Tromey  <tom@tromey.com>
4818
4819         * coffread.c (process_coff_symbol): Use xstrdup.
4820         * value.c (create_internalvar): Use xstrdup.
4821
4822 2019-06-16  Tom Tromey  <tom@tromey.com>
4823
4824         * valops.c (value_cast, value_slice): Remove unnecessary cast.
4825         * breakpoint.c (stopin_command, stopat_command)
4826         (until_break_command, decode_location_default): Remove unnecessary
4827         cast.
4828         * utils.c (subset_compare): Remove unnecessary cast.
4829         * ada-lang.c (ada_update_initial_language): Remove unnecessary
4830         cast.
4831         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
4832         cast.
4833         * infcmd.c (path_command): Remove unnecessary cast.
4834         * coffread.c (decode_type): Remove unnecessary cast.
4835         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
4836         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
4837         * tui/tui-stack.c (tui_show_locator_content)
4838         (tui_show_frame_info): Remove unnecessary cast.
4839         * tui/tui-win.c (tui_scroll_forward_command)
4840         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
4841         (parse_scrolling_args): Remove unnecessary cast.
4842         * tui/tui-data.c (init_win_info, tui_del_window)
4843         (tui_free_window, tui_del_data_windows, tui_free_data_content)
4844         (free_content_elements): Remove unnecessary cast.
4845         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
4846         unnecessary cast.
4847         * tui/tui-source.c (tui_set_source_content)
4848         (tui_vertical_source_scroll): Remove unnecessary cast.
4849         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
4850         cast.
4851         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
4852         * tui/tui-regs.c (tui_display_registers_from)
4853         (tui_display_register): Remove unnecessary cast.
4854         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
4855         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
4856         (make_visible): Remove unnecessary cast.
4857         * tui/tui-winsource.c (tui_erase_source_content)
4858         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
4859         unnecessary cast.
4860         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
4861         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
4862         * stabsread.c (read_type, read_array_type, read_range_type):
4863         Remove unnecessary cast.
4864         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
4865         (parse_symbol, parse_type, upgrade_type, parse_external)
4866         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
4867         unnecessary cast.
4868         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
4869
4870 2019-06-16  Tom Tromey  <tom@tromey.com>
4871
4872         * tui/tui-data.c (tui_alloc_generic_win_info)
4873         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
4874         checks.
4875
4876 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
4877             Andrew Burgess  <andrew.burgess@embecosm.com>
4878
4879         * f-typeprint.c (f_print_type): Don't return early for not
4880         associated or not allocated types.
4881         (f_type_print_varspec_suffix): Add print_rank parameter and print
4882         ranks of array types in case they dangling.
4883         (f_type_print_base): Add print_rank parameter.
4884
4885 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4886
4887         * NEWS: Mention new MI commands.
4888         * break-catch-throw.c (enum exception_event_kind): Move to
4889         breakpoint.h.
4890         (print_mention_exception_catchpoint): Output text as a single
4891         message.
4892         (catch_exception_command_1): Rename to...
4893         (catch_exception_event): ...this, make non-static, update header
4894         command, and change some parameter types.
4895         (catch_catch_command): Update for changes to
4896         catch_exception_command_1.
4897         (catch_throw_command): Likewise.
4898         (catch_rethrow_command): Likewise.
4899         * breakpoint.c (enum exception_event_kind): Delete.
4900         * breakpoint.h (enum exception_event_kind): Moved here from
4901         break-catch-throw.c.
4902         (catch_exception_event): Declare.
4903         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
4904         (mi_cmd_catch_throw): New function.
4905         (mi_cmd_catch_rethrow): New function.
4906         (mi_cmd_catch_catch): New function.
4907         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
4908         'catch-catch' entries.
4909         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
4910         (mi_cmd_catch_rethrow): Declare.
4911         (mi_cmd_catch_catch): Declare.
4912
4913 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4914
4915         * annotate.c (annotate_source_line): Change return type to void,
4916         update implementation to match.
4917         * annotate.h (annotate_source_line): Change return type to void,
4918         update header comment.
4919         * stack.c (print_frame_info): Don't change what frame information
4920         is printed based on whether annotations are on or not.
4921
4922 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4923
4924         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
4925         (annotate_source): Make static.
4926         (annotate_source_line): Moved from source.c and renamed from
4927         identify_source_line.  Update the return type.
4928         * annotate.h (annotate_source): Delete declaration.
4929         (annotate_source_line): Declaration moved from source.h, and
4930         renamed from identify_source_line.  Return type updated.
4931         * source.c (identify_source_line): Moved to annotate.c and renamed
4932         to annotate_source_line.
4933         (info_line_command): Remove check of annotation_level.
4934         * source.h (identify_source_line): Move declaration to annotate.h
4935         and rename to annotate_source_line.
4936         * stack.c: Add 'annotate.h' include.
4937         (print_frame_info): Remove check of annotation_level before
4938         calling annotate_source_line.
4939
4940 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4941
4942         * source-cache.c (source_cache::get_plain_source_lines): Use
4943         open_source_file_with_line_charpos instead of just
4944         open_source_file, remove call to find_source_lines.
4945         (source_cache::get_source_lines): Likewise.
4946         * source.c (find_source_lines): Make static.
4947         (get_filename_and_charpos): Renamed into...
4948         (open_source_file_with_line_charpos): ..this along with changes to
4949         return a scoped_fd, and some other minor clean ups.
4950         (identify_source_line): Use open_source_file_with_line_charpos.
4951         (search_command_helper): Use open_source_file_with_line_charpos
4952         instead of just open_source_file, remove call to
4953         find_source_lines.
4954         * source.h (open_source_file_with_line_charpos): Declare new
4955         function.
4956         (find_source_lines): Delete declaration.
4957
4958 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4959
4960         * source.c (get_filename_and_charpos): Remove fullname
4961         parameter.
4962         (identify_source_line): Update call to get_filename_and_charpos.
4963
4964 2019-06-14  Tom Tromey  <tromey@adacore.com>
4965
4966         PR gdb/24502:
4967         * ui-style.h (skip_ansi_escape): Update comment.
4968         * ui-file.h (class no_terminal_escape_file): New class.
4969         * ui-file.c (no_terminal_escape_file::write)
4970         (no_terminal_escape_file::puts): New methods.
4971         * cli/cli-logging.c (handle_redirections): Use
4972         no_terminal_escape_file.
4973
4974 2019-06-14  Tom Tromey  <tromey@adacore.com>
4975
4976         * NEWS: Move convenience variable news above Python news.
4977
4978 2019-06-14  Tom Tromey  <tom@tromey.com>
4979
4980         * gnulib: Move directory to top-level.
4981         * configure.ac: Don't configure gnulib.
4982         * configure: Rebuild.
4983         * common/common-defs.h: Use new path to gnulib.
4984         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4985         (GNULIB_H): Remove.
4986         (INCGNU): Look in new gnulib location.
4987         (HFILES_NO_SRCDIR): Remove gnulib files.
4988         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4989         (generated_files): Remove GNULIB_H.
4990         ($(LIBGNU), all-lib): Remove targets.
4991         (distclean): Don't mention GNULIB_BUILDDIR.
4992         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4993
4994 2019-06-14  Tom Tromey  <tromey@adacore.com>
4995
4996         * symfile.c (add_symbol_file_command): Remove obsolete comment.
4997         Warn if symbol file does not provide any symbols.
4998
4999 2019-06-14  Tom Tromey  <tromey@adacore.com>
5000
5001         * source.c (find_and_open_source): Respect basenames_may_differ.
5002
5003 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
5004
5005         * annotate.c (annotate_breakpoints_invalid): Make use of
5006         scoped_restore_terminal_state.
5007         (annotate_frames_invalid): Likewise.
5008
5009 2019-06-14  Tom Tromey  <tromey@adacore.com>
5010
5011         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
5012         allow assignment to an internalvar.
5013
5014 2019-06-14  Tom Tromey  <tromey@adacore.com>
5015
5016         * ada-lex.l: Allow "_" in attribute names.
5017
5018 2019-06-14  Tom Tromey  <tromey@adacore.com>
5019
5020         PR gdb/24653:
5021         * regcache.c (registers_changed): Don't call alloca.
5022         * top.c (execute_command): Don't call alloca.
5023
5024 2019-06-13  Pedro Alves  <palves@redhat.com>
5025
5026         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
5027         'expression'.  When parsing an expression, error out if there's
5028         junk after "unlimited".
5029         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5030         (do_set_command): Adjust calls to is_unlimited_literal.
5031
5032 2019-06-13  Pedro Alves  <palves@redhat.com>
5033
5034         * compile/compile.c (make_compile_options_def_group): Add braces
5035         around array_view initializer.
5036         * thread.c (make_thread_apply_all_options_def_group)
5037         (make_thread_apply_all_options_def_group): Likewise.
5038
5039 2019-06-13  Pedro Alves  <palves@redhat.com>
5040
5041         * NEWS (New commands): Mention "maint test-options
5042         require-delimiter", "maint test-options unknown-is-error", "maint
5043         test-options unknown-is-operand" and "maint show
5044         test-options-completion-result".
5045         (New command options, command completion): New section.
5046         (Completion improvements): New section.
5047         Mention that you can abbreviate "unlimited".
5048
5049 2019-06-13  Pedro Alves  <palves@redhat.com>
5050
5051         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
5052         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
5053         * unittests/cli-utils-selftests.c (test_parse_flags)
5054         (test_parse_flags_qcs): Delete.
5055         (test_cli_utils): Don't call deleted functions.
5056
5057 2019-06-13  Pedro Alves  <palves@redhat.com>
5058
5059         * thread.c: Include "cli/cli-option.h".
5060         (tp_array_compar_ascending): Global.
5061         (tp_array_compar): Delete function.
5062         (tp_array_compar_ascending, tp_array_compar_descending): New
5063         functions.
5064         (ascending_option_def, qcs_flag_option_def)
5065         (thr_qcs_flags_option_defs)
5066         (make_thread_apply_all_options_def_group)
5067         (make_thread_apply_options_def_group): New.
5068         (thread_apply_all_command): Use gdb::option::process_options.
5069         (thread_apply_command_completer)
5070         (thread_apply_all_command_completer): New.
5071         (thread_apply_command): Use gdb::option::process_options.
5072         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
5073         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
5074         to generate help text of "thread apply".  Adjust "taas"'s help.
5075         * tid-parse.c (tid_range_parser::in_thread_range): New method.
5076         * tid-parse.h (tid_range_parser::in_thread_range): New method.
5077
5078 2019-06-13  Pedro Alves  <palves@redhat.com>
5079
5080         * thread.c (thread_apply_command): Check for invalid TID with
5081         isdigit instead of !isalpha.
5082
5083 2019-06-13  Pedro Alves  <palves@redhat.com>
5084
5085         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
5086         (validate_flags_qcs): New.
5087         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
5088         (validate_flags_qcs): Declare.
5089         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
5090         (make_frame_apply_options_def_group): New.
5091         (frame_apply_command_count): Process options with
5092         gdb::option::process_options.
5093         (frame_apply_completer): New.
5094         (frame_apply_level_completer, frame_apply_all_completer)
5095         (frame_apply_completer): New.
5096         (_initialize_stack): Update help of "frame apply", "frame apply
5097         level", "frame apply all" and "faas" to mention supported options
5098         and install command completers.
5099         * stack.h (frame_apply_all_completer): Declare.
5100         * thread.c: Include "stack.h".
5101         (tfaas_command): Add "--".
5102         (_initialize_thread): Update help "tfaas" to mention supported
5103         options and install command completer.
5104
5105 2019-06-13  Pedro Alves  <palves@redhat.com>
5106
5107         * completer.c (complete_nested_command_line): New.
5108         (gdb_completion_word_break_characters_throw): Add assertion.
5109         * completer.h (complete_nested_command_line): Declare.
5110
5111 2019-06-13  Pedro Alves  <palves@redhat.com>
5112
5113         * stack.c (parse_backtrace_qualifiers): New.
5114         (backtrace_command): Use it.
5115         (backtrace_command_completer): Complete on qualifiers.
5116
5117 2019-06-13  Pedro Alves  <palves@redhat.com>
5118
5119         * frame.c: Include "cli/cli-option.h.
5120         (user_set_backtrace_options): New.
5121         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
5122         Delete.
5123         (get_prev_frame): Adjust.
5124         (boolean_option_def, uinteger_option_def)
5125         (set_backtrace_option_defs): New.
5126         (_initialize_frame): Adjust and use
5127         gdb::option::add_setshow_cmds_for_options to install "set
5128         backtrace past-main" and "set backtrace past-entry".
5129         * frame.h: Include "cli/cli-option.h".
5130         (struct frame_print_options): Forward declare.
5131         (print_frame_arguments_all, print_frame_arguments_scalars)
5132         (print_frame_arguments_none): Declare.
5133         (print_entry_values): Delete declaration.
5134         (struct frame_print_options, user_frame_print_options): New.
5135         (struct set_backtrace_options): New.
5136         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
5137         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
5138         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
5139         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
5140         (list_args_or_locals): Add frame_print_options parameter.
5141         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5142         * python/py-framefilter.c (enumerate_args): Pass down
5143         USER_FRAME_PRINT_OPTIONS.
5144         * stack.c: Include "cli/cli-option.h".
5145         (print_frame_arguments_all, print_frame_arguments_scalars)
5146         (print_frame_arguments_none): Declare.
5147         (print_raw_frame_arguments, print_entry_values): Delete.
5148         (user_frame_print_options): New.
5149         (boolean_option_def, enum_option_def, frame_print_option_defs):
5150         New.
5151         (struct backtrace_cmd_options): New.
5152         (bt_flag_option_def): New.
5153         (backtrace_command_option_defs): New.
5154         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5155         (print_frame_arg, read_frame_arg, print_frame_args)
5156         (print_frame_info, print_frame): Add frame_print_options parameter
5157         and use it.
5158         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
5159         (backtrace_command_1): Add frame_print_options and
5160         backtrace_cmd_options parameters and use them.
5161         (make_backtrace_options_def_group): New.
5162         (backtrace_command): Process command options with
5163         gdb::option::process_options.
5164         (backtrace_command_completer): New.
5165         (_initialize_stack): Extend "backtrace"'s help to mention
5166         supported options.  Install completer for "backtrace".
5167         Install some settings commands with add_setshow_cmds_for_options.
5168
5169 2019-06-13  Pedro Alves  <palves@redhat.com>
5170
5171         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
5172         and that "set/show print raw frame-arguments" are now deprecated.
5173
5174         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
5175         command.
5176         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
5177         * stack.c (_initialize_stack): Install "set/show print
5178         raw-frame-arguments", and deprecate "set/show print raw
5179         frame-arguments".
5180         * valprint.c (_initialize_valprint): Deprecate "set/show print
5181         raw".
5182
5183 2019-06-13  Pedro Alves  <palves@redhat.com>
5184
5185         * compile/compile.c (struct compile_options): New.
5186         (compile_flag_option_def, compile_command_option_defs)
5187         (make_compile_options_def_group): New.
5188         (compile_file_command): Handle options with
5189         gdb::option::process_options.
5190         (compile_file_command_completer): New function.
5191         (compile_code_command): Handle options with
5192         gdb::option::process_options.
5193         (compile_code_command_completer): New function.
5194         (_initialize_compiler): Install completers for "compile code" and
5195         "compile file".  Mention available options in "compile code" and
5196         "compile code"'s help.
5197         * completer.c (advance_to_completion_word): New, factored out from
5198         ...
5199         (advance_to_expression_complete_word_point): ... this.
5200         (advance_to_filename_complete_word_point): New.
5201         * completer.h (advance_to_filename_complete_word_point): New
5202         declaration.
5203
5204 2019-06-13  Pedro Alves  <palves@redhat.com>
5205
5206         * compile/compile.c: Include "cli/cli-option.h".
5207         (compile_print_value): Scope data pointer is now a
5208         value_print_options pointer; adjust.
5209         (compile_print_command): Process options.  Scope data pointer is
5210         now a value_print_options pointer; adjust.
5211         (_initialize_compile): Update "compile print"'s help to include
5212         supported options.  Install a completer for "compile print".
5213         * cp-valprint.c (show_vtblprint, show_objectprint)
5214         (show_static_field_print): Delete.
5215         (_initialize_cp_valprint): Don't install "set print
5216         static-members", "set print vtbl", "set print object" here.
5217         * printcmd.c: Include "cli/cli-option.h" and
5218         "common/gdb_optional.h".
5219         (print_command_parse_format): Rework to fill in a
5220         value_print_options instead of a format_data.
5221         (print_value): Change parameter type from format_data pointer to
5222         value_print_options reference.  Adjust.
5223         (print_command_1): Process options.  Adjust to pass down a
5224         value_print_options.
5225         (print_command_completer): New.
5226         (_initialize_printcmd): Install print_command_completer as
5227         handle_brkchars completer for the "print" command.  Update
5228         "print"'s help to include supported options.
5229         * valprint.c: Include "cli/cli-option.h".
5230         (show_vtblprint, show_objectprint, show_static_field_print): Moved
5231         here from cp-valprint.c.
5232         (boolean_option_def, uinteger_option_def)
5233         (value_print_option_defs, make_value_print_options_def_group):
5234         New.  Use gdb::option::add_setshow_cmds_for_options to install
5235         "set print elements", "set print null-stop", "set print repeats",
5236         "set print pretty", "set print union", "set print array", "set
5237         print address", "set print symbol", "set print array-indexes".
5238         * valprint.h: Include <string> and "cli/cli-option.h".
5239         (make_value_print_options_def_group): Declare.
5240         (print_value): Change parameter type from format_data pointer to
5241         value_print_options reference.
5242         (print_command_completer): Declare.
5243
5244 2019-06-13  Pedro Alves  <palves@redhat.com>
5245
5246         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
5247         (COMMON_SFILES): Add maint-test-settings.c.
5248         * cli/cli-decode.c (boolean_enums): New global, factored out from
5249         ...
5250         (add_setshow_boolean_cmd): ... here.
5251         * cli/cli-decode.h (boolean_enums): Declare.
5252         * cli/cli-option.c: New file.
5253         * cli/cli-option.h: New file.
5254         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
5255         factored out from ...
5256         (parse_cli_boolean_value(const char *)): ... this.
5257         (is_unlimited_literal): Change parameter type to pointer to
5258         pointer.  Adjust and advance ARG pointer.
5259         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5260         (parse_cli_var_enum): New, factored out from ...
5261         (do_set_command): ... this.  Adjust.
5262         * cli/cli-setshow.h (parse_cli_boolean_value)
5263         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5264         (parse_cli_var_enum): Declare.
5265         * cli/cli-utils.c: Include "cli/cli-option.h".
5266         (get_ulongest): New.
5267         * cli/cli-utils.h (get_ulongest): Declare.
5268         (check_for_argument): New overloads.
5269         * maint-test-options.c: New file.
5270
5271 2019-06-13  Pedro Alves  <palves@redhat.com>
5272
5273         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
5274         parse a range if "-" is at the end of the string.
5275
5276 2019-06-13  Pedro Alves  <palves@redhat.com>
5277
5278         * cli/cli-setshow.c (parse_auto_binary_operation)
5279         (parse_cli_boolean_value): Don't allow "o".
5280
5281 2019-06-13  Pedro Alves  <palves@redhat.com>
5282
5283         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
5284         * NEWS: Mention maint test-settings KIND.
5285         * maint-test-settings.c: New file.
5286
5287 2019-06-13  Pedro Alves  <palves@redhat.com>
5288
5289         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
5290         completer.
5291         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
5292         "set" completers.
5293
5294 2019-06-13  Pedro Alves  <palves@redhat.com>
5295
5296         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
5297         after item.
5298
5299 2019-06-13  Pedro Alves  <palves@redhat.com>
5300
5301         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
5302
5303 2019-06-13  Pedro Alves <palves@redhat.com>
5304
5305         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
5306         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
5307         call.
5308         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
5309         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
5310         calls.
5311         (check_for_argument): Skip spaces after argument.
5312
5313 2019-06-13  Pedro Alves  <palves@redhat.com>
5314
5315         * thread.c (thread_apply_command): Adjust TID parsing.
5316         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
5317         detected before end of string.
5318         (tid_is_in_list): Error out if LIST is invalid.
5319
5320 2019-06-13  Pedro Alves  <palves@redhat.com>
5321
5322         * completer.c (complete_line_internal_1): Rewind completion word
5323         point.
5324         (completion_tracker::advance_custom_word_point_by): Change
5325         parameter type to int.
5326         * completer.h (completion_tracker::advance_custom_word_point_by):
5327         Likewise.
5328
5329 2019-06-13  Pedro Alves  <palves@redhat.com>
5330
5331         * completer.c (advance_to_completion_word): Handle delimiters.
5332
5333 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
5334
5335         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
5336
5337 2019-06-11  Tom Tromey  <tom@tromey.com>
5338
5339         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
5340         (xmalloc_failed): Move to alloc.c.
5341         * alloc.c: New file.
5342         * Makefile.in (COMMON_SFILES): Add alloc.c.
5343
5344 2019-06-11  Tom Tromey  <tom@tromey.com>
5345
5346         * nat/linux-waitpid.c: Don't include server.h.
5347         (linux_debug): Remove.
5348         (my_waitpid): Update.
5349
5350 2019-06-11  Tom Tromey  <tromey@adacore.com>
5351
5352         * infcall.c (_initialize_infcall): Remove trailing newline from
5353         help.
5354         * user-regs.c (_initialize_user_regs): Remove trailing newline
5355         from help.
5356         * typeprint.c (_initialize_typeprint): Remove trailing newline
5357         from help.
5358         * reverse.c (_initialize_reverse): Remove trailing newlines from
5359         help.
5360         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
5361         from help.
5362         * language.c (add_set_language_command): Remove trailing newline
5363         from help.
5364         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
5365         help.
5366         * disasm.c (_initialize_disasm): Remove trailing newline from
5367         help.
5368         * top.c (init_main): Remove trailing newline from help.
5369         * interps.c (_initialize_interpreter): Remove trailing newline
5370         from help.
5371         * btrace.c (_initialize_btrace): Remove trailing newlines from
5372         help.
5373         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
5374         from help.
5375         * python/python.c (_initialize_python): Remove trailing newline
5376         from help.
5377         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
5378         help.
5379         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
5380         from help.  Reformat some text.
5381         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
5382         from help.
5383         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
5384         newline from help.
5385
5386 2019-06-11  Tom Tromey  <tromey@adacore.com>
5387
5388         * darwin-nat.c (darwin_decode_exception_message)
5389         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
5390
5391 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5392
5393         * valops.c (value_slice): Check for not allocated or not
5394         associated values.
5395
5396 2019-06-10  Tom de Vries  <tdevries@suse.de>
5397
5398         PR gdb/24618
5399         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
5400         sure an empty slot (defined by a 32-bit zero pair) is recognized as
5401         invalid.
5402
5403 2019-06-10  Tom de Vries  <tdevries@suse.de>
5404
5405         PR gdb/24611
5406         * linespec.c (linespec_lexer_lex_string): Remove incorrect
5407         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
5408
5409 2019-06-10  Tom de Vries  <tdevries@suse.de>
5410
5411         PR symtab/24545
5412         * symtab.c (struct demangled_name_entry): Add language field.
5413         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
5414         static minimal symbol".  Set and use language field.
5415
5416 2019-06-10  Tom Tromey  <tromey@adacore.com>
5417
5418         * ada-lang.c (_initialize_ada_language): Update help text.
5419
5420 2019-06-10  Tom Tromey  <tromey@adacore.com>
5421
5422         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
5423         with a newline.
5424         * guile/guile.c (handle_boot_error): Don't end warning with a
5425         newline.
5426         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
5427         warning with a newline.
5428         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
5429         newline.
5430         (s12z_frame_cache): Likewise.
5431         * dwarf-index-cache.c (index_cache::store): Don't end warning with
5432         a newline.
5433         * solib-svr4.c (disable_probes_interface): Don't end warning with
5434         a newline.
5435         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
5436         newline.
5437         * python/python.c (do_finish_initialization): Don't end warning
5438         with a newline.
5439
5440 2019-06-10  Tom Tromey  <tom@tromey.com>
5441
5442         * python/py-breakpoint.c (gdbpy_breakpoint_created)
5443         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
5444         gdbpy_enter.
5445
5446 2019-06-10  Tom Tromey  <tromey@adacore.com>
5447
5448         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
5449         data.
5450         (elf_new_init): Don't call stabsread_new_init.
5451         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
5452         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
5453         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
5454
5455 2019-06-10  Tom de Vries  <tdevries@suse.de>
5456
5457         PR symtab/16264
5458         PR symtab/24517
5459         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
5460
5461 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
5462
5463         * source.c (find_and_open_source): Also rewrite relative file
5464         names.
5465
5466 2019-04-26  Amos Bird  <amosbird@gmail.com>
5467
5468         * annotate.c (annotate_thread_exited): Add "thread-exited"
5469         annotation.
5470
5471 2019-06-06  Tom Tromey  <tromey@adacore.com>
5472
5473         * maint.h (class scoped_command_stats): Use
5474         DISABLE_COPY_AND_ASSIGN.
5475         <print_time>: New method.
5476         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
5477         print_time.
5478         (scoped_command_stats::print_time): New method.
5479
5480 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
5481
5482         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
5483         instructions of lengths 6 or 8 bytes.
5484
5485 2019-06-04  Pedro Alves  <palves@redhat.com>
5486
5487         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
5488
5489         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
5490         * breakpoint.c (condition_completer): Likewise.
5491         * cli/cli-dump.c (scan_expression): Likewise.
5492         * common/filestuff.c (mkdir_recursive): Likewise.
5493         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
5494         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
5495         (gdb_abspath): Likewise.
5496         * compile/compile-cplus-types.c
5497         (compile_cplus_instance::decl_name): Likewise.
5498         * completer.c (complete_explicit_location):
5499         (signal_completer, reg_or_group_completer_1): Likewise.
5500         * cp-support.c (cp_remove_params_if_any): Likewise.
5501         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
5502         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
5503         * infcmd.c (strip_bg_char): Likewise.
5504         * linespec.c (copy_token_string): Likewise.
5505         * mi/mi-main.c (output_cores): Likewise.
5506         * psymtab.c (psymtab_search_name):
5507         * symfile.c (test_set_ext_lang_command): Likewise.
5508         * target.c (target_fileio_read_stralloc): Likewise.
5509         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
5510         * value.c (complete_internalvar): Likewise.
5511
5512 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
5513
5514         Add objfile property to gdb.Type.
5515         * NEWS: Mention Python API addition.
5516         * python/py-type.c (typy_get_objfile): New method.
5517
5518 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5519
5520         * NEWS: Mention the new set|show style [title|highlight].
5521         Mention changes to "show style", "help" and "apropos".
5522
5523 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5524
5525         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
5526         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
5527         instead of print_help_for_command.
5528         (print_doc_of_command): New function.
5529         (help_list): Add 'apropos -v word' suggestion.
5530         (print_help_for_command): Style the command name using title style.
5531         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
5532         (_initialize_cli_cmds): Describe -v in apropos_command help.
5533
5534 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5535
5536         * cli/cli-style.h (cli_style_option): Add name in constructor,
5537         add m_name class member, add constructor with intensity,
5538         add name class function.
5539         (cli_style_option::add_setshow_commands): Remove name argument.
5540         (highlight_style, title_style): New styles.
5541         * cli/cli-style.c (do_show): New function that shows a style
5542         characteristic styling the style name with itself.
5543         (set_style_name): New function.
5544         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
5545         Update all callers according to the changes in cli/cli-style.h.
5546         * utils.h (fputs_highlighted): New function.
5547         * utils.c (fputs_highlighted): Likewise.
5548
5549 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5550
5551         * NEWS: Mention new pipe command and new convenience variables.
5552
5553 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5554
5555         * cli/cli-cmds.c (pipe_command): New function.
5556         (_initialize_cli_cmds): Call add_com for pipe_command.
5557         Define | as an alias for pipe.
5558         (exit_status_set_internal_vars): New function.
5559         (shell_escape): Call exit_status_set_internal_vars.
5560         cli/cli-decode.c (find_command_name_length): Recognize | as
5561         a single character command.
5562
5563 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5564
5565         * gdbcmd.h (execute_command_to_ui_file): New declaration.
5566         top.c (execute_command_to_ui_file): New function, mostly a copy
5567         of execute_command_to_string.
5568         (execute_command_to_string): Implement by calling
5569         execute_command_to_ui_file.
5570
5571 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5572
5573         * top.h (saved_command_line): Remove declaration.
5574         * top.c (previous_saved_command_line, previous_repeat_arguments):
5575         New variables.
5576         (saved_command_line): Make static, define together with other
5577         'repeat variables'.
5578         (dont_repeat): Clear repeat_arguments.
5579         (repeat_previous, get_saved_command_line, save_command_line):
5580         New functions.
5581         (gdb_init): Initialize saved_command_line
5582         and previous_saved_command_line.
5583         * main.c (captured_main_1): Remove saved_command_line initialization.
5584         * event-top.c (handle_line_of_input): Update to use
5585         the new 'repeat' related functions instead of direct access to
5586         saved_command_line.
5587         * command.h (repeat_previous, get_saved_command_line,
5588         save_command_line): New declarations.
5589         (dont_repeat): Add comment.
5590
5591 2019-05-30  Tom Tromey  <tromey@adacore.com>
5592
5593         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
5594         Fix comment.
5595         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
5596
5597 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
5598
5599         PR cli/24587
5600         * completer.c (complete): Initialize variable word.
5601
5602 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
5603
5604         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5605         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
5606         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
5607         'body' is NULL to the outter 'if', protecting the '!is_define'
5608         situation as well.
5609
5610 2019-05-29  Tom Tromey  <tromey@adacore.com>
5611
5612         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
5613         (dwarf_unknown): New function.
5614         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
5615         (dwarf_type_encoding_name): Use dwarf_unknown.
5616
5617 2019-05-29  Tom Tromey  <tromey@adacore.com>
5618
5619         PR c++/20020:
5620         * cp-valprint.c (cp_print_value_fields): Call
5621         cp_print_static_field inside "try".
5622
5623 2019-05-29  Tom Tromey  <tromey@adacore.com>
5624
5625         * inflow.c (struct terminal_info): Add default operator=.
5626         * configure: Rebuild.
5627         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
5628         -Wdeprecated-copy-dtor, -Wredundant-move.
5629
5630 2019-05-29  Tom Tromey  <tromey@adacore.com>
5631
5632         * NEWS: Add entry.
5633         * infcmd.c (print_return_value_1): Handle finish_print
5634         option.
5635         (show_print_finish): New function.
5636         (_initialize_infcmd): Add "set/show print finish" commands.
5637         * valprint.c (user_print_options): Initialize new member.
5638         * valprint.h (struct value_print_options) <finish_print>: New
5639         member.
5640
5641 2019-05-28  Tom Tromey  <tromey@adacore.com>
5642
5643         * ada-lang.c (ada_remove_Xbn_suffix)
5644         (find_old_style_renaming_symbol)
5645         (parse_old_style_renaming): Remove.
5646         (ada_find_renaming_symbol): Don't call
5647         find_old_style_renaming_symbol.
5648         (ada_is_renaming_symbol): Rename from
5649         ada_find_renaming_symbol.  Remove "block" parameter.  Return
5650         bool.  Now static.
5651         (ada_read_var_value): Update and simplify.
5652         * ada-exp.y (write_var_or_type): Remove old code.
5653
5654 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
5655
5656         * event-top.c: Remove include comment.
5657         * inflow.c (class scoped_ignore_sigttou): Move from here...
5658         * inflow.h (class scoped_ignore_sigttou): ...to here.
5659         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
5660         * top.c:  Remove include comment.
5661
5662 2019-05-27  Tom Tromey  <tom@tromey.com>
5663
5664         * NEWS: Fix typo.
5665
5666 2019-05-22  Tom Tromey  <tromey@adacore.com>
5667
5668         * target.c (target_follow_exec): Constify parameter.
5669         * target-delegates.c: Rebuild.
5670         * remote.c (remote_target::follow_exec): Constify parameter.
5671         * infrun.c (follow_exec): Constify parameter.
5672         * target.h (struct target_ops) <follow_exec>: Constify parameter.
5673         (target_follow_exec): Likewise.
5674
5675 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5676
5677         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
5678         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
5679
5680 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5681
5682         * NEWS: Add debugredirect and testsuite sections.
5683
5684 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
5685
5686         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
5687         target descriptions using exclusively floating point register name
5688         aliases.
5689
5690 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
5691
5692         PR gdb/18644:
5693         * f-lang.c (build_fortran_types): Handle the case where
5694         gdbarch_floatformat_for_type returns a nullptr.
5695
5696 2019-05-21  Tom de Vries  <tdevries@suse.de>
5697
5698         PR cli/24587
5699         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
5700
5701 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5702
5703         PR gdb/18644:
5704         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
5705         16-byte floats.
5706         * i386-tdep.c (i386_floatformat_for_type): Use
5707         floatformats_ia64_quad for the 16-byte floating point component
5708         within a fortran 32-byte complex number.
5709
5710 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5711
5712         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
5713         delete default constructor.
5714         (find_partial_die): Update to return const struct.
5715         (partial_die_parent_scope): Move variable declaration into scope
5716         of its use and change its type to auto.
5717         (guess_partial_die_structure_name): Likewise.
5718         (partial_die_info::fixup): Likewise.
5719
5720 2019-05-17  Tom Tromey  <tromey@adacore.com>
5721
5722         * source.c (find_and_open_source): Remove cast.
5723
5724 2019-05-17  Tom Tromey  <tromey@adacore.com>
5725
5726         * annotate.c (annotate_source): Make "filename" const.
5727         * annotate.h (annotate_source): Use const.
5728
5729 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5730
5731         * disasm.c (set_disassembler_options): Send errors to stderr.
5732
5733 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5734
5735         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
5736         (cli_interp_base::set_logging): Check debug_redirect.
5737         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
5738         * cli/cli-logging.c (debug_redirect): Add static variable.
5739         (pop_output_files): Add default param.
5740         (handle_redirections): Print debug setting.
5741         (show_logging_command): Likewise.
5742         (_initialize_cli_logging): Add debugredirect command.
5743         * interps.c (current_interp_set_logging): Add debug_redirect
5744         parameter.
5745         * interps.h (set_logging): Add debug_redirect parameter.
5746         (current_interp_set_logging): Likewise.
5747         * mi/mi-common.h: Likewise.
5748         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
5749
5750 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5751             Tom Tromey  <tromey@adacore.com>
5752
5753         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
5754         directly.
5755         * cli/cli-interp.h (make_logging_output): Remove declaration.
5756         * cli/cli-logging.c (make_logging_output): Remove function.
5757         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
5758         directly.
5759         * ui-file.c (tee_file::tee_file): Remove bools.
5760         (tee_file::~tee_file): Remove deletes.
5761         * ui-file.h (tee_file): Remove bools.
5762
5763 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
5764
5765         * mi/mi-cmds.h (mi_cmd_complete): New function.
5766         * mi/mi-main.c (mi_cmd_complete): Likewise.
5767         * mi/mi-cmds.c: Define new MI command -complete.
5768         * NEWS: Mention new -complete command.
5769
5770 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
5771
5772         * completer.h (complete): New function.
5773         * completer.c (complete): Likewise.
5774         * cli/cli-cmds.c: (complete_command): Update to use new complete()
5775         function defined in completer.h.
5776
5777 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
5778
5779         * MAINTAINERS (Write After Approval): Add myself.
5780
5781 2019-05-17  Tom de Vries  <tdevries@suse.de>
5782
5783         PR gdb/24094
5784         * dwarf2read.c (struct cu_partial_die_info): New struct.
5785         (find_partial_die): Return cu_partial_die_info.
5786         (partial_die_parent_scope, guess_partial_die_structure_name)
5787         (partial_die_info::fixup): Handle new return type of find_partial_die.
5788
5789 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5790
5791         * stap-probe.c (stap_parse_register_operand): Make "regname" an
5792         "std::string", simplifying the algorithm.
5793
5794 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5795
5796         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
5797         (stap_static_probe_ops::get_probes): Likewise.
5798
5799 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5800
5801         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
5802         '-')" and "else if".
5803         (stap_parse_single_operand): Join checks for
5804         "gdbarch_stap_parse_special_token_p" and
5805         "gdbarch_stap_parse_special_token" in the same "if" statement.
5806         Invert check when verifying for operation on register
5807         displacement.
5808
5809 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5810
5811         * stap-probe.c (stap_get_opcode): Update comment.
5812         (stap_get_expected_argument_type): Likewise.
5813         (handle_stap_probe): Likewise.
5814
5815 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5816
5817         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
5818         return type to 'bool'.  Adjust comment.  Use 'bool' when
5819         appropriate.
5820         (i386_stap_parse_special_token_three_arg_disp): Likewise.
5821         * stap-probe.c (stap_parse_argument_1): Likewise.
5822         (stap_is_operator): Likewise.
5823         (stap_is_generic_prefix): Likewise.
5824         (stap_is_register_prefix): Likewise.
5825         (stap_is_register_indirection_prefix): Likewise.
5826         (stap_is_integer_prefix): Likewise.
5827         (stap_generic_check_suffix): Likewise.
5828         (stap_check_integer_suffix): Likewise.
5829         (stap_check_register_suffix): Likewise.
5830         (stap_check_register_indirection_suffix): Likewise.
5831         (stap_parse_register_operand): Likewise.
5832         (stap_parse_single_operand): Likewise.
5833         (stap_parse_argument_1): Likewise.
5834         (stap_probe::get_argument_count): Likewise.
5835         (stap_is_operator): Likewise.
5836
5837 2019-05-16  Tom Tromey  <tromey@adacore.com>
5838
5839         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
5840         keyword to foreach.
5841
5842 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
5843
5844         * linux-thread-db.c (try_thread_db_load_1): Change return type
5845         to bool.
5846         (try_thread_db_load): Likewise.
5847         (try_thread_db_load_from_pdir_1): Likewise.
5848         (try_thread_db_load_from_pdir): Likewise.
5849         (try_thread_db_load_from_sdir): Likewise.
5850         (try_thread_db_load_from_dir): Likewise.
5851         (thread_db_load_search): Likewise.
5852         (has_libpthread): Likewise.
5853         (thread_db_load): Likewise.
5854
5855 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
5856
5857         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5858         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
5859         NULL, and complain/return if that's the case.
5860
5861 2019-05-15  John Darrington <john@darrington.wattle.id.au>
5862
5863         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
5864         (advance, posn, abstract_read_memory): New functions.
5865         [struct mem_read_abstraction]: New struct.
5866         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
5867
5868 2019-05-14  Tom Tromey  <tromey@adacore.com>
5869
5870         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
5871         value is not lval_memory.
5872
5873 2019-05-14  Tom Tromey  <tromey@adacore.com>
5874
5875         * solib.c (info_sharedlibrary_command): Style the file name.
5876
5877 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
5878
5879         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
5880         (aarch64_vnv_type): Likewise.
5881         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
5882         * common/tdesc.c: Likewise.
5883         * common/tdesc.h (enum tdesc_type_kind): Likewise.
5884         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
5885         * features/aarch64-fpu.xml: Add ieee half view.
5886         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
5887         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
5888         * gdbtypes.h (struct builtin_type): Likewise.
5889         (struct objfile_type): Likewise.
5890
5891 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
5892
5893         * language.c (language_sniff_from_mangled_name): Fix "langauge"
5894         typo.
5895         * location.h (string_to_event_location): Likewise.
5896
5897 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
5898
5899         GDB 8.3 released.
5900
5901 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5902
5903         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
5904         New variable declaration.
5905         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
5906         New variable.
5907         (print_one_breakpoint): Use ui_out::test_flags and new global
5908         variable to compute use_fixed_output.
5909         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
5910         Remove.
5911         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
5912         (mi_multi_location_breakpoint_output_fixed): Remove.
5913         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
5914         new variable.
5915         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
5916         fix_multi_location_breakpoint_output flag if version >= 3.
5917         * ui-out.h (enum ui_out_flag)
5918         <fix_multi_location_breakpoint_output>: New enumerator.
5919
5920 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5921
5922         * contrib/cc-with-tweaks.sh: Validate dwz's work.
5923
5924 2019-05-10  Tom Tromey  <tromey@adacore.com>
5925
5926         * ada-lang.c (catch_ada_completer): New function.
5927         (_initialize_ada_language): Use it.
5928
5929 2019-05-10  Tom Tromey  <tromey@adacore.com>
5930
5931         * thread.c (print_thread_info): Make "requested_threads" const.
5932         * gdbthread.h (print_thread_info): Make "requested_threads"
5933         const.
5934         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5935         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
5936
5937 2019-05-08  Tom Tromey  <tom@tromey.com>
5938
5939         * gdbtypes.c (objfile_type_data): Change type.
5940         (objfile_type, _initialize_gdbtypes): Update.
5941
5942 2019-05-08  Tom Tromey  <tom@tromey.com>
5943
5944         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
5945         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
5946         (_initialize_dwarf2_frame): Update.
5947
5948 2019-05-08  Tom Tromey  <tom@tromey.com>
5949
5950         * objc-lang.c (objc_objfile_data): Change type.
5951         (find_methods): Update.
5952         (_initialize_objc_lang): Remove.
5953
5954 2019-05-08  Tom Tromey  <tom@tromey.com>
5955
5956         * stabsread.c (rs6000_builtin_type_data): Change type.
5957         (rs6000_builtin_type, _initialize_stabsread): Update.
5958
5959 2019-05-08  Tom Tromey  <tom@tromey.com>
5960
5961         * mips-tdep.c (mips_pdr_data): Remove.
5962         (_initialize_mips_tdep): Update.
5963
5964 2019-05-08  Tom Tromey  <tom@tromey.com>
5965
5966         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5967         (hppa_init_objfile_priv_data, read_unwind_info)
5968         (find_unwind_entry, _initialize_hppa_tdep): Update.
5969
5970 2019-05-08  Tom Tromey  <tom@tromey.com>
5971
5972         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5973         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
5974         on obstack.
5975         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5976
5977 2019-05-08  Tom Tromey  <tom@tromey.com>
5978
5979         * mdebugread.c (basic_type_data): Change type.
5980         (basic_type, _initialize_mdebugread): Update.
5981
5982 2019-05-08  Tom Tromey  <tom@tromey.com>
5983
5984         * common/gdb_unique_ptr.h (struct noop_deleter): New.
5985
5986 2019-05-08  Tom Tromey  <tom@tromey.com>
5987
5988         * nto-tdep.c (nto_inferior_data_reg): Change type.
5989         (nto_inferior_data): Update.
5990         (nto_inferior_data_cleanup, nto_new_inferior_data)
5991         (_initialize_nto_tdep): Remove.
5992         * nto-tdep.h (struct nto_inferior_data): Add initializers.
5993
5994 2019-05-08  Tom Tromey  <tom@tromey.com>
5995
5996         * ada-lang.c (struct ada_inferior_data): Add initializers.
5997         (ada_inferior_data): Change type.
5998         (ada_inferior_data_cleanup): Remove.
5999         (get_ada_inferior_data, ada_inferior_exit)
6000         (struct ada_pspace_data): Add initializers, destructor.
6001         (ada_pspace_data_handle): Change type.
6002         (get_ada_pspace_data): Update.
6003         (ada_pspace_data_cleanup): Remove.
6004
6005 2019-05-08  Tom Tromey  <tom@tromey.com>
6006
6007         * coffread.c (struct coff_symfile_info): Add initializers.
6008         (coff_objfile_data_key): Move lower.  Change type.
6009         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
6010         Update.
6011         (coff_free_info): Remove.
6012
6013 2019-05-08  Tom Tromey  <tom@tromey.com>
6014
6015         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
6016         (fbsd_pspace_data_handle): Move lower.  Change type.
6017         (get_fbsd_pspace_data): Update.
6018         (fbsd_pspace_data_cleanup): Remove.
6019         (_initialize_fbsd_tdep): Update.
6020
6021 2019-05-08  Tom Tromey  <tom@tromey.com>
6022
6023         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
6024         (get_ada_tasks_pspace_data): Update.
6025         (ada_tasks_pspace_data_cleanup): Remove.
6026         (_initialize_tasks): Update.
6027         (ada_tasks_inferior_data_handle): Change type.
6028         (get_ada_tasks_inferior_data): Update.
6029         (ada_tasks_inferior_data_cleanup): Remove.
6030         (struct ada_tasks_pspace_data): Add initializers.
6031
6032 2019-05-08  Tom Tromey  <tom@tromey.com>
6033
6034         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
6035         * symfile-debug.c (debug_sym_get_probes): Change type.
6036         * stap-probe.c (handle_stap_probe):
6037         (stap_static_probe_ops::get_probes): Change type.
6038         * probe.h (class static_probe_ops) <get_probes>: Change type.
6039         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
6040         (parse_probes_in_pspace): Update.
6041         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
6042         Update.
6043         (any_static_probe_ops::get_probes): Change type.
6044         * elfread.c (elfread_data): New typedef.
6045         (probe_key): Change type.
6046         (elf_get_probes): Likewise.  Update.
6047         (probe_key_free): Remove.
6048         (_initialize_elfread): Update.
6049         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
6050         Change type.
6051         (dtrace_process_dof_probe, dtrace_process_dof)
6052         (dtrace_static_probe_ops::get_probe): Change type.
6053
6054 2019-05-08  Tom Tromey  <tom@tromey.com>
6055
6056         * xcoffread.c (struct xcoff_symfile_info): Rename from
6057         coff_symfile_info.  Add initializers.
6058         (xcoff_objfile_data_key): Move lower.  Change type.
6059         (XCOFF_DATA): Rewrite.
6060         (xcoff_free_info): Remove.
6061         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
6062         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
6063         (xcoff_initial_scan): Update.
6064
6065 2019-05-08  Tom Tromey  <tom@tromey.com>
6066
6067         * solib-svr4.c (struct svr4_info): Add initializers and
6068         destructor.
6069         <probes_table>: Now an htab_up.
6070         (solib_svr4_pspace_data): Change type.
6071         (free_probes_table): Simplify.
6072         (~svr4_info): Rename from svr4_pspace_data_cleanup.
6073         (get_svr4_info, probes_table_htab_remove_objfile_probes)
6074         (probes_table_remove_objfile_probes, register_solib_event_probe)
6075         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
6076         (_initialize_svr4_solib): Update.
6077
6078 2019-05-08  Tom Tromey  <tom@tromey.com>
6079
6080         * remote.c (remote_pspace_data): Change type.
6081         (remote_pspace_data_cleanup): Remove.
6082         (get_remote_exec_file, set_pspace_remote_exec_file)
6083         (_initialize_remote): Update.
6084
6085 2019-05-08  Tom Tromey  <tom@tromey.com>
6086
6087         * breakpoint.c (breakpoint_objfile_key): Change type.
6088         (get_breakpoint_objfile_data): Update.
6089         (free_breakpoint_objfile_data): Remove.
6090         (_initialize_breakpoint): Update.
6091
6092 2019-05-08  Tom Tromey  <tom@tromey.com>
6093
6094         * linux-tdep.c (struct linux_info): Add initializers.
6095         (linux_inferior_data): Move.  Change type.
6096         (invalidate_linux_cache_inf): Update.
6097         (linux_inferior_data_cleanup): Remove.
6098         (get_linux_inferior_data, _initialize_linux_tdep): Update.
6099
6100 2019-05-08  Tom Tromey  <tom@tromey.com>
6101
6102         * auxv.c (auxv_inferior_data): Move.  Change type.
6103         (auxv_inferior_data_cleanup): Remove.
6104         (invalidate_auxv_cache_inf): Rewrite.
6105         (get_auxv_inferior_data, _initialize_auxv): Update.
6106
6107 2019-05-08  Tom Tromey  <tom@tromey.com>
6108
6109         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
6110         (symfile_debug_objfile_data_key): Change type.
6111         (symfile_debug_installed, debug_qf_has_symbols)
6112         (debug_qf_find_last_source_symtab)
6113         (debug_qf_forget_cached_source_info)
6114         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
6115         (debug_qf_print_stats, debug_qf_dump)
6116         (debug_qf_expand_symtabs_for_function)
6117         (debug_qf_expand_all_symtabs)
6118         (debug_qf_expand_symtabs_with_fullname)
6119         (debug_qf_map_matching_symbols)
6120         (debug_qf_expand_symtabs_matching)
6121         (debug_qf_find_pc_sect_compunit_symtab)
6122         (debug_qf_map_symbol_filenames)
6123         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
6124         (debug_sym_new_init, debug_sym_init, debug_sym_read)
6125         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
6126         (debug_sym_read_linetable, debug_sym_relocate): Update.
6127         (symfile_debug_free_objfile): Remove.
6128         (install_symfile_debug_logging, _initialize_symfile_debug):
6129         Update.
6130
6131 2019-05-08  Tom Tromey  <tom@tromey.com>
6132
6133         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
6134         allocate_on_obstack.
6135         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
6136         (get_dwarf2_per_objfile): Update.
6137         (set_dwarf2_per_objfile): Remove.
6138         (dwarf2_has_info, dwarf2_get_section_info): Update.
6139         (dwarf2_free_objfile): Remove.
6140         (_initialize_dwarf2_read): Update.
6141
6142 2019-05-08  Tom Tromey  <tom@tromey.com>
6143
6144         * auto-load.c (struct auto_load_pspace_info): Add destructor and
6145         initializers.
6146         <unsupported_script_warning_printed,
6147         script_not_found_warning_printed>: Now bool.
6148         (auto_load_pspace_data): Change type.
6149         (~auto_load_pspace_info): Rename from
6150         auto_load_pspace_data_cleanup.
6151         (get_auto_load_pspace_data, init_loaded_scripts_info)
6152         (clear_section_scripts, maybe_print_unsupported_script_warning)
6153         (maybe_print_script_not_found_warning, _initialize_auto_load):
6154         Update.
6155
6156 2019-05-08  Tom Tromey  <tom@tromey.com>
6157
6158         * objfiles.c (objfile_pspace_info): Add destructor and
6159         initializers.
6160         (objfiles_pspace_data): Change type.
6161         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
6162         (get_objfile_pspace_data): Update.
6163         (objfiles_bfd_data): Change type.
6164         (get_objfile_bfd_data): Update.
6165         (objfile_bfd_data_free, _initialize_objfiles): Remove.
6166
6167 2019-05-08  Tom Tromey  <tom@tromey.com>
6168
6169         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
6170         Change type.
6171         (get_catch_syscall_inferior_data): Update.
6172         (catch_syscall_inferior_data_cleanup): Remove.
6173         (_initialize_break_catch_syscall): Update.
6174
6175 2019-05-08  Tom Tromey  <tom@tromey.com>
6176
6177         * inflow.c (struct terminal_info): Add destructor and
6178         initializers.
6179         (inflow_inferior_data): Change type.
6180         (~terminal_info): Rename from inflow_inferior_data_cleanup.
6181         (get_inflow_inferior_data, inflow_inferior_exit)
6182         (swap_terminal_info, _initialize_inflow): Update.
6183
6184 2019-05-08  Tom Tromey  <tom@tromey.com>
6185
6186         * target-dcache.c (target_dcache_cleanup): Remove.
6187         (target_dcache_aspace_key): Change type.
6188         (target_dcache_init_p, target_dcache_invalidate)
6189         (target_dcache_get, target_dcache_get_or_init)
6190         (_initialize_target_dcache): Update.
6191         * dcache.h (struct dcache_deleter): New.
6192
6193 2019-05-08  Tom Tromey  <tom@tromey.com>
6194
6195         * symtab.c (struct symbol_cache): Add destructor and
6196         initializers.
6197         (symbol_cache_key): Move.  Change type.
6198         (make_symbol_cache, free_symbol_cache): Remove.
6199         (get_symbol_cache): Update.
6200         (symbol_cache_cleanup): Remove.
6201         (ALL_PSPACES, symbol_cache_flush)
6202         (maintenance_print_symbol_cache)
6203         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
6204         Update.
6205
6206 2019-05-08  Tom Tromey  <tom@tromey.com>
6207
6208         * symtab.c (struct main_info): Add destructor and initializers.
6209         (main_progspace_key): Move.  Change type.
6210         (get_main_info): Update.
6211         (main_info_cleanup): Remove.
6212         (_initialize_symtab): Update.
6213
6214 2019-05-08  Tom Tromey  <tom@tromey.com>
6215
6216         * registry.h (DECLARE_REGISTRY): Define the _key class.
6217
6218 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6219
6220         * NEWS: Merge two 'New commands' sections.
6221
6222 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
6223
6224         * ada-valprint.c (ada_val_print_gnat_array): Remove language
6225         parameter and use Ada language definition instead.
6226         (ada_val_print_ptr): Remove unused language parameter.
6227         (ada_val_print_num): Remove language parameter and use Ada language
6228         definition instead.
6229         (ada_val_print_enum, ada_val_print_flt): Remove unused language
6230         parameter.
6231         (ada_val_print_struct_union, ada_val_print_ref): Remove language
6232         parameter and use Ada language definition instead.
6233         (ada_val_print_1): Update all ada_val_print_xxx calls.
6234         Remove language parameter.
6235         (ada_val_print): Update ada_val_print_1 call.
6236
6237 2019-05-08  Tom Tromey  <tromey@adacore.com>
6238
6239         * remote.c (remote_hw_watchpoint_limit)
6240         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
6241         Now static.
6242
6243 2019-05-08  Tom Tromey  <tromey@adacore.com>
6244
6245         * maint.c (_initialize_maint_cmds): Move initialization code to
6246         remote.c.
6247         (watchdog, show_watchdog): Move to remote.c.
6248         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
6249         "watchdog" static.
6250         (_initialize_remote): Move initialization code from maint.c.
6251         * defs.h (watchdog): Don't declare.
6252
6253 2019-05-08  Tom Tromey  <tromey@adacore.com>
6254
6255         * tui/tui-interp.c: Include main.h.
6256         * interps.c: Include main.h.
6257         * main.h (interpreter_p): Declare.
6258         * defs.h (interpreter_p): Don't declare.
6259
6260 2019-05-08  Tom Tromey  <tromey@adacore.com>
6261
6262         * dwarf2loc.c: Include dwarf2read.h.
6263         * defs.h (read_unsigned_leb128): Don't declare.
6264         * dwarf2read.h (read_unsigned_leb128): Declare.
6265
6266 2019-05-08  Tom Tromey  <tromey@adacore.com>
6267
6268         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
6269         method.
6270
6271 2019-05-08  Tom Tromey  <tromey@adacore.com>
6272
6273         * utils.c (fputs_maybe_filtered): Reset style after paging, even
6274         when no wrap column is set.
6275
6276 2019-05-08  Tom Tromey  <tromey@adacore.com>
6277
6278         * c-lang.c (c_get_string): Handle non-C-style arrays.
6279
6280 2019-05-08  Tom Tromey  <tromey@adacore.com>
6281
6282         * typeprint.c (print_offset_data::update): Print the bit offset,
6283         not the number of bits remaining.
6284
6285 2019-05-08  Tom Tromey  <tromey@adacore.com>
6286
6287         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
6288         padding at end of comment.
6289
6290 2019-05-08  Tom Tromey  <tromey@adacore.com>
6291
6292         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
6293         Compare main types.
6294
6295 2019-05-06  Tom Tromey  <tom@tromey.com>
6296
6297         * common/scoped_mmap.c: Include common-defs.h.
6298         * common/scoped_mmap.h: Don't include config.h.
6299
6300 2019-05-04  Tom Tromey  <tom@tromey.com>
6301
6302         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
6303         (struct aarch64_call_info): Add initializers.
6304         <si>: Now a std::vector.
6305         (pass_on_stack, aarch64_push_dummy_call): Update.
6306
6307 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
6308             Tom Tromey  <tom@tromey.com>
6309
6310         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
6311         (ppc_threads): Now a std::vector.  Now static.
6312         (hwdebug_find_thread_points_by_tid)
6313         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
6314         Update.
6315
6316 2019-05-04  Tom Tromey  <tom@tromey.com>
6317
6318         * arc-tdep.c (arc_tdesc_init): Return bool.
6319
6320 2019-05-04  Tom Tromey  <tom@tromey.com>
6321
6322         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
6323         Use gdb_assert_not_reached.
6324
6325 2019-05-04  Tom Tromey  <tom@tromey.com>
6326
6327         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
6328         "false".
6329
6330 2019-05-04  Tom Tromey  <tom@tromey.com>
6331
6332         * arc-tdep.c (arc_tdesc_init): Use bool.
6333
6334 2019-05-04  Tom Tromey  <tom@tromey.com>
6335
6336         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
6337
6338 2019-05-04  Tom Tromey  <tom@tromey.com>
6339
6340         * cli/cli-cmds.c (valid_command_p): Return bool.
6341
6342 2019-05-04  Tom Tromey  <tom@tromey.com>
6343
6344         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
6345         * command.h (valid_user_defined_cmd_name_p): Channge return type.
6346
6347 2019-05-04  Raul Tambre  <raul@tambre.ee>
6348
6349         * python/lib/gdb/prompt.py (_ExtendedPrompt)
6350         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
6351         operator for comparison.
6352
6353 2019-05-04  Tom Tromey  <tom@tromey.com>
6354
6355         * psymtab.c (psymbol_name_matches, match_partial_symbol)
6356         (lookup_partial_symbol, print_partial_symbols)
6357         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
6358         (psymbol_compare): Update.
6359         (add_psymbol_to_bcache): Clear the entire psymbol.
6360         (maintenance_check_psymtabs): Update.
6361         * psympriv.h (struct partial_symbol): Don't derive from
6362         general_symbol_info.
6363         <obj_section, unrelocated_address, address,
6364         set_unrelocated_address>: Update.
6365         <ginfo>: New member.
6366         * dwarf-index-write.c (write_psymbols, debug_names::insert)
6367         (debug_names::write_psymbols): Update.
6368
6369 2019-05-04  Tom de Vries  <tdevries@suse.de>
6370
6371         * contrib/cc-with-tweaks.sh: Support -n arg.
6372
6373 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6374
6375         * corelow.c (core_target::detach): Ensure frame cache and
6376         register caches are cleared.
6377         inferior.c (exit_inferior_1): Likewise.
6378
6379 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
6380             Tom Tromey  <tom@tromey.com>
6381
6382         * dictionary.c (collate_pending_symbols_by_language): Remove
6383         "struct" from foreach.
6384         * symtab.c (lookup_global_symbol_from_objfile)
6385         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
6386         foreach.
6387         * ser-tcp.c (net_open): Remove "struct" from foreach.
6388         * objfiles.c (objfile_relocate, objfile_rebase)
6389         (objfile_has_symbols): Remove "struct" from foreach.
6390         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
6391         from foreach.
6392         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
6393         foreach.
6394         * darwin-nat.c (thread_info_from_private_thread_info): Remove
6395         "struct" from foreach.
6396         * ada-lang.c (create_excep_cond_exprs)
6397         (ada_exception_catchpoint_cond_string): Remove "struct" from
6398         foreach.
6399
6400 2019-05-03  Tom Tromey  <tromey@adacore.com>
6401
6402         * ada-exp.y (convert_char_literal): Check suffix of each
6403         enumerator.
6404
6405 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
6406
6407         PR ada/21406:
6408         * ada-exp.y (yywrap): Don't define.
6409         * ada-lex.l (%option): Add noyywrap
6410         (yywrap): Remove.
6411
6412 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
6413
6414         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
6415         _WIN32_WINNT to the XP level, unless already defined to a higher
6416         level.
6417
6418         * unittests/parse-connection-spec-selftests.c:
6419         * ser-tcp.c:
6420         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
6421         override.
6422
6423         * symfile.c (find_separate_debug_file): Remove colon from the
6424         drive spec of DOS/Windows file names of the target, so that the
6425         file name produced from DEBUGDIR and the target's directory will
6426         be valid on DOS/Windows systems.
6427
6428 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
6429
6430         * rust-lang.c (val_print_struct): Handle printing structures
6431         containing strings.
6432
6433 2019-05-02  Tom Tromey  <tromey@adacore.com>
6434
6435         * valarith.c (_initialize_valarith): Remove.
6436
6437 2019-05-01  Tom Tromey  <tromey@adacore.com>
6438
6439         * ada-lang.c (ada_value_primitive_field): Treat more fields as
6440         bitfields.
6441
6442 2019-05-01  Tom Tromey  <tromey@adacore.com>
6443
6444         * ada-lang.c (ada_value_assign): Correctly compute starting offset
6445         for big-endian copies.
6446
6447 2019-04-30  Ali Tamur  <tamur@google.com>
6448         * gdb/dwarf2read.c (read_3_bytes): New declaration.
6449         (read_attribute_value): Added DW_FORM_strx1-4 cases.
6450         (read_3_bytes): New function.
6451
6452 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6453
6454         * windows-nat.c (main_thread_id): Delete.
6455         (handle_output_debug_string): Replace main_thread_id by
6456         current_event.dwThreadId.
6457         (fake_create_process): Likewise.
6458         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
6459         Do not set main_thread_id.
6460         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
6461         current_event.dwThreadId.
6462         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
6463
6464 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6465
6466         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
6467         Use current_event.dwThreadId instead of main_thread_id.
6468
6469 2019-04-30  Tom Tromey  <tromey@adacore.com>
6470
6471         * ada-lang.c (ada_lookup_simple_minsyms): New function.
6472         (create_excep_cond_exprs): Iterate over program spaces.
6473         (ada_exception_catchpoint_cond_string): Examine all minimal
6474         symbols for exception types.
6475
6476 2019-04-30  Tom Tromey  <tromey@adacore.com>
6477
6478         PR c++/24470:
6479         * dwarf2read.c (process_structure_scope): Handle case where type
6480         has template parameters but no symbol was created.
6481
6482 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6483             Chris January  <chris.january@arm.com>
6484
6485         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
6486         qualifier.
6487         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
6488
6489 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6490
6491         * f-typeprint.c (f_print_type): Update rules for printing
6492         whitespace.
6493         (f_type_print_varspec_suffix): Likewise.
6494
6495 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6496             Chris January  <chris.january@arm.com>
6497
6498         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
6499         function arguments.
6500
6501 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6502
6503         * f-lang.c (build_fortran_types): Change name of void type to
6504         lower case.
6505         * f-typeprint.c (f_type_print_base): Print the name of the void
6506         type, rather than a fixed string.
6507         * f-valprint.c (f_decorations): Use lower case void string.
6508
6509 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6510             Chris January  <chris.january@arm.com>
6511
6512         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
6513         types for Fortran.
6514
6515 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6516             Chris January  <chris.january@arm.com>
6517             David Lecomber  <david.lecomber@arm.com>
6518
6519         * f-exp.y (BINOP_INTRINSIC): New token.
6520         (exp): New parser rule handling BINOP_INTRINSIC.
6521         (f77_keywords): Add new builtin procedures.
6522         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
6523         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6524         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
6525         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6526         (print_unop_subexp_f): New function.
6527         (print_binop_subexp_f): New function.
6528         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6529         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6530         (dump_subexp_body_f): Likewise.
6531         (operator_check_f): Likewise.
6532         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6533         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
6534
6535 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6536
6537         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
6538         UNOP_KIND.
6539         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
6540         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
6541         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
6542         (operator_length_f): New fuction.
6543         (print_subexp_f): New function.
6544         (op_name_f): New function.
6545         (dump_subexp_body_f): New function.
6546         (operator_check_f): New function.
6547         (exp_descriptor_f): Replace standard expression handling functions
6548         with new functions.
6549         * gdb/fortran-operator.def: New file.
6550         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
6551         * gdb/std-operator.def: Remove UNOP_KIND.
6552
6553 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6554
6555         * std-operator.def: Remove unbalanced, stray double quote
6556         character.
6557
6558 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6559             Chris January  <chris.january@arm.com>
6560             Daniel Everett  <daniel.everett@arm.com>
6561             Nick Forrington  <nick.forrington@arm.com>
6562             Richard Bunt  <richard.bunt@arm.com>
6563
6564         * cp-valprint.c (cp_print_value_fields): Allow an additional level
6565         of depth when printing anonymous structs or unions.
6566         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
6567         Don't print either the top-level value, or the children if the
6568         max-depth is exceeded.
6569         (ppscm_print_children): When printing the key of a map, allow one
6570         extra level of depth.
6571         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
6572         print either the top-level value, or the children if the max-depth
6573         is exceeded.
6574         (print_children): When printing the key of a map, allow one extra
6575         level of depth.
6576         * python/py-value.c (valpy_format_string): Add max_depth keyword.
6577         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
6578         (user_print_options): Initialise max_depth field.
6579         (val_print_scalar_or_string_type_p): New function.
6580         (val_print): Check to see if the max depth has been reached.
6581         (val_print_check_max_depth): Define new function.
6582         (show_print_max_depth): New function.
6583         (_initialize_valprint): Add 'print max-depth' option.
6584         * valprint.h (struct value_print_options) <max_depth>: New field.
6585         (val_print_check_max_depth): Declare new function.
6586         * NEWS: Document new feature.
6587
6588 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6589
6590         * ada-lang.c (ada_language_defn): Initialise new field.
6591         * c-lang.c (c_is_string_type_p): New function.
6592         (c_language_defn): Initialise new field.
6593         (cplus_language_defn): Initialise new field.
6594         (asm_language_defn): Initialise new field.
6595         (minimal_language_defn): Initialise new field.
6596         * c-lang.h (c_is_string_type_p): Declare new function.
6597         * d-lang.c (d_language_defn): Initialise new field.
6598         * f-lang.c (f_is_string_type_p): New function.
6599         (f_language_defn): Initialise new field.
6600         * go-lang.c (go_is_string_type_p): New function.
6601         (go_language_defn): Initialise new field.
6602         * language.c (default_is_string_type_p): New function.
6603         (unknown_language_defn): Initialise new field.
6604         (auto_language_defn): Initialise new field.
6605         * language.h (struct language_defn) <la_is_string_type_p>: New
6606         member variable.
6607         (default_is_string_type_p): Declare new function.
6608         * m2-lang.c (m2_language_defn): Initialise new field.
6609         * objc-lang.c (objc_language_defn): Initialise new field.
6610         * opencl-lang.c (opencl_language_defn): Initialise new field.
6611         * p-lang.c (pascal_is_string_type_p): New function.
6612         (pascal_language_defn): Initialise new field.
6613         * rust-lang.c (rust_is_string_type_p): New function.
6614         (rust_language_defn): Initialise new field.
6615
6616 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6617
6618         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
6619         New field.
6620         * ada-lang.c (ada_language_defn): Initialise new field.
6621         * c-lang.c (c_language_defn): Likewise.
6622         (cplus_language_defn): Likewise.
6623         (asm_language_defn): Likewise.
6624         (minimal_language_defn): Likewise.
6625         * d-lang.c (d_language_defn): Likewise.
6626         * f-lang.c (f_language_defn): Likewise.
6627         * go-lang.c (go_language_defn): Likewise.
6628         * language.c (unknown_language_defn): Likewise.
6629         (auto_language_defn): Likewise.
6630         * m2-lang.c (m2_language_defn): Likewise.
6631         * objc-lang.c (objc_language_defn): Likewise.
6632         * opencl-lang.c (opencl_language_defn): Likewise.
6633         * p-lang.c (pascal_language_defn): Likewise.
6634         * rust-lang.c (rust_language_defn): Likewise.
6635
6636 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6637
6638         * ada-lang.c (ada_is_character_type): Change return type to bool.
6639         (ada_is_string_type): Likewise.
6640         * ada-lang.h (ada_is_character_type): Update declaration
6641         (ada_is_string_type): Likewise.
6642
6643 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6644
6645         Support style in 'frame|thread apply'
6646
6647         * gdbcmd.h (execute_command_to_string): New term_out parameter.
6648         * record.c (record_start, record_stop): Update callers of
6649         execute_command_to_string with false.
6650         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
6651         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
6652         methods.
6653         (class string_file): New constructor with term_out parameter.
6654         Override methods term_out and can_emit_style_escape.  New member
6655         term_out.
6656         (class stdio_file): Override can_emit_style_escape.
6657         (class tee_file): Override term_out and can_emit_style_escape.
6658         * utils.h (can_emit_style_escape): Remove.
6659         * utils.c (can_emit_style_escape): Likewise.
6660         Update all callers of can_emit_style_escape (SOMESTREAM) to
6661         SOMESTREAM->can_emit_style_escape.
6662         * source-cache.c (source_cache::get_source_lines): Likewise.
6663         * stack.c (frame_apply_command_count): Call execute_command_to_string
6664         passing the term_out characteristic of the current gdb_stdout.
6665         * thread.c (thr_try_catch_cmd): Likewise.
6666         * top.c (execute_command_to_string): pass term_out parameter
6667         to construct the string_file for the command output.
6668         * ui-file.c (term_cli_styling): New function (most code moved
6669         from utils.c can_emit_style_escape).
6670         (string_file::string_file, string_file::can_emit_style_escape,
6671         stdio_file::can_emit_style_escape, tee_file::term_out,
6672         tee_file::can_emit_style_escape): New functions.
6673
6674 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6675
6676         * NEWS: Mention the new set|show may-call-functions.
6677         * infcall.c (may_call_functions_p): New variable.
6678         (show_may_call_functions_p): New function.
6679         (call_function_by_hand_dummy): Throws an error if not
6680         may-call-functions.
6681         (_initialize_infcall): Call add_setshow_boolean_cmd for
6682         may-call-functions.
6683
6684 2019-04-25  Keith Seitz  <keiths@redhat.com>
6685
6686         PR c++/24367
6687         * cp-support.c (inspect_type): Don't attempt substitutions
6688         of symbol with the same name.
6689
6690 2019-04-25  Tom Tromey  <tromey@adacore.com>
6691
6692         PR gdb/24475:
6693         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
6694         static.
6695
6696 2019-04-25  Tom Tromey  <tromey@adacore.com>
6697
6698         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
6699         rvalue reference.
6700         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
6701         (gdb_xml_parser::parse): Use std::move.
6702         * python/python-internal.h (gdbpy_convert_exception): Take a const
6703         reference.
6704         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
6705         std::move.
6706         * python/py-utils.c (gdbpy_convert_exception): Take a const
6707         reference.
6708         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6709         Use std::move.
6710         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6711         Use std::move.
6712         * mi/mi-main.c (mi_print_exception): Take a const reference.
6713         * main.c (handle_command_errors): Take a const reference.
6714         * linespec.c (parse_linespec): Use std::move.
6715         * infcall.c (run_inferior_call): Use std::move.
6716         (call_function_by_hand_dummy): Use std::move.
6717         * exec.c (try_open_exec_file): Use std::move.
6718         * exceptions.h (exception_print, exception_fprintf)
6719         (exception_print_same): Update.
6720         * exceptions.c (print_exception, exception_print)
6721         (exception_fprintf, exception_print_same): Change parameters to
6722         const reference.
6723         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
6724         * common/new-op.c: Use std::move.
6725         * common/common-exceptions.h (struct gdb_exception): Add move
6726         constructor.
6727         (struct gdb_exception_error, struct gdb_exception_quit, struct
6728         gdb_quit_bad_alloc): Change constructor to move constructor.
6729         (throw_exception): Change parameter to rvalue reference.
6730         * common/common-exceptions.c (throw_exception): Take rvalue
6731         reference.
6732         * cli/cli-interp.c (safe_execute_command): Use std::move.
6733         * breakpoint.c (insert_bp_location, location_to_sals): Use
6734         std::move.
6735
6736 2019-04-25  Tom Tromey  <tromey@adacore.com>
6737
6738         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
6739         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
6740         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
6741         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
6742         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
6743         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
6744         guile/scm-value.c: Use unpack.
6745         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
6746         gdbscm_gdb_exception.
6747         (gdbscm_throw_gdb_exception): Likewise.
6748         (struct gdbscm_gdb_exception): New.
6749         (unpack): New function.
6750         (gdbscm_wrap): Use unpack.
6751
6752 2019-04-25  Tom Tromey  <tromey@adacore.com>
6753
6754         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6755         (gdb_rl_callback_handler): Use std::move.
6756         * common/common-exceptions.h (struct gdb_exception): Add move
6757         assignment operator.
6758         (throw_exception_sjlj): Change "exception" to const reference.
6759         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
6760         (throw_exception_sjlj): Change "exception" to const reference.
6761
6762 2019-04-25  Tom Tromey  <tromey@adacore.com>
6763
6764         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
6765         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
6766         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6767         Update.
6768         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6769         Update.
6770         * mi/mi-interp.c (mi_interp::exec): Update.
6771         * linespec.c (parse_linespec): Update.
6772         * infcall.c (run_inferior_call): Update.
6773         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
6774         * guile/scm-symbol.c (gdbscm_lookup_symbol)
6775         (gdbscm_lookup_global_symbol): Update.
6776         * guile/scm-param.c (gdbscm_parameter_value): Update.
6777         * guile/scm-frame.c (gdbscm_frame_read_register)
6778         (gdbscm_frame_read_var): Update.
6779         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
6780         * exec.c (try_open_exec_file): Update.
6781         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6782         (gdb_rl_callback_handler): Update.
6783         * common/common-exceptions.h (exception_none): Don't declare.
6784         * common/common-exceptions.c (exception_none): Don't define.
6785         (struct catcher) <exception>: Update.
6786         * cli/cli-interp.c (safe_execute_command): Update.
6787         * breakpoint.c (insert_bp_location, location_to_sals): Update.
6788
6789 2019-04-25  Ali Tamur  <tamur@google.com>
6790
6791         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
6792         (read_attribute_value): Likewise.
6793         (dwarf2_read_addr_index): Update comment.
6794         (read_str_index): Add DW_FORM_strx.
6795         (dwarf2_string_attr): Likewise.
6796         (dwarf2_const_value_attr): Likewise.
6797         (dump_die_shallow): Likewise.
6798         (dwarf2_fetch_constant_bytes): Likewise.
6799         (skip_form_bytes): Likewise.
6800         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
6801
6802 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
6803
6804         PR corefiles/11608
6805         PR corefiles/18187
6806         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
6807         OFFSET.  Verify if current mapping contains an ELF header.
6808         (linux_find_memory_regions_full): Adjust call to
6809         dump_mapping_p.
6810
6811 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
6812             Kang Li <kanglictf@gmail.com>
6813
6814         PR gdb/21600
6815
6816         * dwarf2-frame.c (read_initial_length): Be consistent about using
6817         unsigned representation of length.
6818         (decode_frame_entry_1): Likewise.  Check for wraparound of
6819         end pointer as well as buffer overflow.
6820
6821 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
6822
6823         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
6824         "vq".
6825
6826 2019-04-24  Tom Tromey  <tromey@adacore.com>
6827
6828         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
6829
6830 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6831
6832         * s12z-tdep.c (s12z_unwind_pc): Delete.
6833         (s12z_unwind_sp): Delete.
6834         (s12z_gdbarch_init): Don't register deleted functions with
6835         gdbarch.
6836
6837 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6838
6839         * rl78-tdep.c (rl78_unwind_sp): Delete.
6840         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
6841
6842 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6843
6844         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
6845         (xstormy16_unwind_pc): Delete.
6846         (xstormy16_dummy_id): Delete.
6847         (xstormy16_gdbarch_init): Don't register deleted functions with
6848         gdbarch.
6849
6850 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6851
6852         * vax-tdep.c (vax_unwind_pc): Delete.
6853         (vax_gdbarch_init): Don't register deleted function with gdbarch.
6854
6855 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6856
6857         * v850-tdep.c (v850_unwind_sp): Delete.
6858         (v850_unwind_pc): Delete.
6859         (v850_dummy_id): Delete.
6860         (v850_gdbarch_init): Don't register deleted functions with
6861         gdbarch.
6862
6863 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6864
6865         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
6866         (tilegx_unwind_pc): Delete.
6867         (tilegx_unwind_dummy_id): Delete.
6868         (tilegx_gdbarch_init): Don't register deleted functions with
6869         gdbarch.
6870
6871 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6872
6873         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
6874         (tic6x_dummy_id): Delete.
6875         (tic6x_gdbarch_init): Don't register deleted functions with
6876         gdbarch.
6877
6878 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6879
6880         * sparc-tdep.c (sparc_unwind_pc): Delete.
6881         (sparc32_gdbarch_init): Don't register deleted function with
6882         gdbarch.
6883
6884 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6885
6886         * sh-tdep.c (sh_unwind_sp): Delete.
6887         (sh_unwind_pc): Delete.
6888         (sh_dummy_id): Delete.
6889         (sh_gdbarch_init): Don't register deleted functions with
6890         gdbarch.
6891
6892 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6893
6894         * score-tdep.c (score_unwind_sp): Delete.
6895         (score_unwind_pc): Delete.
6896         (score_dummy_id): Delete.
6897         (score_gdbarch_init): Don't register deleted functions with
6898         gdbarch.
6899
6900 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6901
6902         * rx-tdep.c (rx_unwind_pc): Delete.
6903         (rx_unwind_sp): Delete.
6904         (rx_dummy_id): Delete.
6905         (rx_gdbarch_init): Don't register deleted functions with
6906         gdbarch.  Update comment.
6907
6908 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6909
6910         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
6911         (rs6000_dummy_id): Delete.
6912         (rs6000_gdbarch_init): Don't register deleted functions with
6913         gdbarch.
6914
6915 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6916
6917         * or1k-tdep.c (or1k_dummy_id): Delete.
6918         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
6919
6920 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6921
6922         * nios2-tdep.c (nios2_dummy_id): Delete.
6923         (nios2_unwind_sp): Delete.
6924         (nios2_gdbarch_init): Don't register deleted functions with
6925         gdbarch.
6926
6927 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6928
6929         * nds32-tdep.c (nds32_dummy_id): Delete.
6930         (nds32_unwind_pc): Delete.
6931         (nds32_unwind_sp): Delete.
6932         (nds32_gdbarch_init): Don't register deleted functions with
6933         gdbarch.
6934
6935 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6936
6937         * msp430-tdep.c (msp430_unwind_pc): Delete.
6938         (msp430_unwind_sp): Delete.
6939         (msp430_dummy_id): Delete.
6940         (msp430_gdbarch_init): Don't register deleted functions with
6941         gdbarch.
6942
6943 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6944
6945         * moxie-tdep.c (moxie_unwind_sp): Delete.
6946         (moxie_unwind_pc): Delete.
6947         (moxie_dummy_id): Delete.
6948         (moxie_gdbarch_init): Don't register deleted functions with
6949         gdbarch.
6950
6951 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6952
6953         * mn10300-tdep.c (mn10300_dummy_id): Delete.
6954         (mn10300_unwind_pc): Delete.
6955         (mn10300_unwind_sp): Delete.
6956         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6957         mn10300_unwind_sp.
6958         (mn10300_frame_unwind_init): Don't register deleted functions with
6959         gdbarch.
6960
6961 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6962
6963         * mep-tdep.c (mep_unwind_pc): Delete.
6964         (mep_unwind_sp): Delete.
6965         (mep_dummy_id): Delete.
6966         (mep_gdbarch_init): Don't register deleted functions with
6967         gdbarch.
6968
6969 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6970
6971         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6972         (m68hc11_unwind_sp): Delete.
6973         (m68hc11_gdbarch_init): Don't register deleted functions with
6974         gdbarch.
6975
6976 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6977
6978         * m32r-tdep.c (m32r_unwind_sp): Delete.
6979         (m32r_unwind_pc): Delete.
6980         (m32r_dummy_id): Delete.
6981         (m32r_gdbarch_init): Don't register deleted functions with
6982         gdbarch.
6983
6984 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6985
6986         * m32c-tdep.c (m32c_unwind_pc): Delete.
6987         (m32c_unwind_sp): Delete.
6988         (m32c_dummy_id): Delete.
6989         (m32c_gdbarch_init): Don't register deleted functions with
6990         gdbarch.
6991
6992 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6993
6994         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6995         (lm32_unwind_pc): Delete.
6996         (lm32_dummy_id): Delete.
6997         (lm32_gdbarch_init): Don't register deleted functions with
6998         gdbarch.
6999
7000 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7001
7002         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
7003         (iq2000_unwind_pc): Delete.
7004         (iq2000_dummy_id): Delete.
7005         (iq2000_gdbarch_init): Don't register deleted functions with
7006         gdbarch.
7007
7008 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7009
7010         * nds32-tdep.c (nds32_type_align): Delete.
7011         (nds32_push_dummy_call): Use type_align instead.
7012
7013 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7014
7015         * arm-tdep.c (arm_type_align): Only handle vector override case.
7016         (arm_push_dummy_call): Use type_align.
7017         (arm_gdbarch_init): Register arm_type_align gdbarch function.
7018
7019 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7020
7021         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
7022         case.
7023         (pass_on_stack): Use type_align.
7024         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
7025         function.
7026
7027 2019-04-23  Tom Tromey  <tromey@adacore.com>
7028
7029         * dwarf2read.c (line_header::file_name_at): Remove unused
7030         overload.
7031
7032 2019-04-23  Tom de Vries  <tdevries@suse.de>
7033
7034         PR gdb/24438
7035         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
7036         invocation.
7037
7038
7039 2019-03-27  Ali Tamur  <tamur@google.com>
7040
7041         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
7042         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
7043         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
7044         (dwarf_expr_context::get_addr_index): Likewise
7045         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
7046         (symbol_needs_eval_context::get_addr_index): Likewise
7047         (disassemble_dwarf_expression): Add DW_OP_addrx
7048         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
7049         (read_cutu_die_from_dwo): Update comment
7050         (skip_one_die): Add DW_FORM_addrx
7051         (read_attribute_value): Likewise
7052         (var_decode_location): Add DW_OP_addrx
7053         (dwarf2_const_value_attr): Add DW_FORM_addrx
7054         (dump_die_shallow): Likewise
7055         (dwarf2_fetch_constant_bytes): Likewise
7056         (decode_locdesc): Add DW_OP_addrx
7057         (skip_form_bytes): Add DW_FORM_addrx
7058
7059 2019-04-22  Ali Tamur  <tamur@google.com>
7060
7061         * MAINTAINERS (Write After Approval): Add self.
7062
7063 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
7064
7065         * solib-svr4.c (get_svr4_info): Add pspace parameter.
7066         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
7067         (open_symbol_file_object): Likewise.
7068         (svr4_default_sos): Add info parameter.
7069         (svr4_read_so_list): Likewise.
7070         (svr4_current_sos_direct): Adjust functions calls to pass down
7071         info.
7072         (svr4_current_sos_1): Add info parameter.
7073         (svr4_current_sos): Call get_svr4_info, pass info down to
7074         svr4_current_sos_1.
7075         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
7076         get_svr4_info.
7077         (svr4_in_dynsym_resolve_code): Pass current_program_space to
7078         get_svr4_info.
7079         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
7080         to get_svr4_info.
7081         (probes_table_remove_objfile_probes): Likewise.
7082         (register_solib_event_probe): Add info parameter.
7083         (solist_update_incremental): Pass info parameter down to
7084         svr4_read_so_list.
7085         (disable_probes_interface): Add info parameter.
7086         (svr4_handle_solib_event): Pass current_program_space to
7087         get_svr4_info.  Adjust disable_probes_interface cleanup.
7088         (svr4_create_probe_breakpoints): Add info parameter, pass it
7089         down to register_solib_event_probe.
7090         (svr4_create_solib_event_breakpoints): Add info parameter,
7091         pass it down to svr4_create_probe_breakpoints.
7092         (enable_break): Pass info down to
7093         svr4_create_solib_event_breakpoints.
7094         (svr4_solib_create_inferior_hook): Pass current_program_space to
7095         get_svr4_info.
7096         (svr4_clear_solib): Likewise.
7097
7098 2019-04-22  Pedro Alves  <palves@redhat.com>
7099
7100         * solib-svr4.c (svr4_free_objfile_observer): New.
7101         (probe_and_action::objfile): New field.
7102         (probes_table_htab_remove_objfile_probes)
7103         (probes_table_remove_objfile_probes): New functions.
7104         (register_solib_event_probe): Add 'objfile' parameter.  Store it
7105         in the new probe_and_action.  Don't store the probe in 'lookup'.
7106         (svr4_create_probe_breakpoints): Pass objfile to
7107         register_solib_event_probe.
7108         (_initialize_svr4_solib): Register a free_objfile observer.
7109
7110 2019-04-19  Tom Tromey  <tom@tromey.com>
7111
7112         * common/queue.h: Remove.
7113
7114 2019-04-19  Tom Tromey  <tom@tromey.com>
7115
7116         * event-loop.c: Don't include "common/queue.h".
7117
7118 2019-04-19  Tom Tromey  <tom@tromey.com>
7119
7120         * remote.c (remote_target): Use delete.
7121         * remote-notif.h: Include <list>, not "common/queue.h".
7122         (notif_client_p): Remove typedef.
7123         (remote_notif_state): Add constructor, destructor, initializer.
7124         <notif_queue>: Now a std::list.
7125         (remote_notif_state_xfree): Don't declare.
7126         * remote-notif.c (remote_notif_process, handle_notification)
7127         (remote_notif_state_allocate): Update.
7128         (~remote_notif_state): Rename from remote_notif_state_xfree.
7129
7130 2019-04-19  Tom Tromey  <tom@tromey.com>
7131
7132         * symfile.c (reread_symbols): Update.
7133         * objfiles.c (objfile_register_static_link)
7134         (objfile_lookup_static_link): Update
7135         (~objfile) Don't delete static_links.
7136         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
7137
7138 2019-04-19  Tom Tromey  <tom@tromey.com>
7139
7140         * type-stack.h (struct type_stack) <insert>: Constify string.
7141         * type-stack.c (type_stack::insert): Constify string.
7142         * gdbtypes.h (lookup_template_type): Update.
7143         (address_space_name_to_int): Update.
7144         * gdbtypes.c (address_space_name_to_int): Make space_identifier
7145         const.
7146         (lookup_template_type): Make name const.
7147         * c-exp.y: Update rules.
7148         (lex_one_token, classify_name, classify_inner_name)
7149         (c_print_token): Update.
7150         * p-exp.y: Update rules.
7151         (yylex): Update.
7152         * f-exp.y: Update rules.
7153         (yylex): Update.
7154         * d-exp.y: Update rules.
7155         (lex_one_token, classify_name, classify_inner_name): Update.
7156         * parse.c (write_dollar_variable, copy_name): Return std::string.
7157         * parser-defs.h (copy_name): Change return type.
7158         * m2-exp.y: Update rules.
7159         (yylex): Update.
7160         * go-exp.y (lex_one_token): Update.
7161         Update rules.
7162         (classify_unsafe_function, classify_packaged_name)
7163         (classify_name, yylex): Update.
7164
7165 2019-04-19  Sergei Trofimovich <siarheit@google.com>
7166
7167         * configure.ac: add --enable-source-highlight switch.
7168         * configure: Regenerate.
7169         * top.c (print_gdb_version): plumb --enable-source-highlight
7170         status to "show configuration".
7171
7172 2019-04-19  Tom Tromey  <tromey@adacore.com>
7173
7174         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
7175         Check ADA_TYPE_P.
7176         (empty_record, ada_template_to_fixed_record_type_1)
7177         (template_to_static_fixed_type)
7178         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
7179         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
7180         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
7181         macros.
7182
7183 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
7184
7185         PR symtab/24423:
7186         * source.c (print_source_lines_base): Advance "iter" when a
7187         control character is seen.
7188
7189 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7190
7191         * inferior.h (struct infcall_suspend_state_deleter):
7192         Catch exception in destructor to avoid crash.
7193
7194 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7195
7196         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
7197         close to the add_com "shell".
7198
7199 2019-04-18  Tom Tromey  <tromey@adacore.com>
7200
7201         * process-stratum-target.h (class process_stratum_target)
7202         <stratum>: Add "final".
7203
7204 2019-04-17  Tom Tromey  <tromey@adacore.com>
7205
7206         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
7207         against nullptr before use.
7208
7209 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
7210
7211         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
7212
7213 2019-04-17  Jim Wilson  <jimw@sifive.com>
7214             Andrew Burgess  <andrew.burgess@embecosm.com>
7215
7216         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
7217         code read might fail, assume 4-byte breakpoint in that case.
7218
7219 2019-04-15  Leszek Swirski  <leszeks@google.com>
7220
7221         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
7222         rather than a hand-rolled POD check when checking for forced MEMORY
7223         classification.
7224
7225 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7226
7227         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
7228         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
7229         function.
7230         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
7231         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
7232         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
7233         declaration.
7234
7235 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7236
7237         * aarch64-linux-nat.c
7238         (aarch64_linux_nat_target::thread_architecture): Add override.
7239         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
7240         each VQ.
7241
7242 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7243
7244         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
7245
7246 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
7247
7248         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
7249         target types of size 96-bits, add some additional comments, and
7250         check that the builtin type we found was the correct size.
7251
7252 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
7253
7254         * utils.c (prompt_for_continue): Don't restore the styling at the
7255         end, as applied_style has the wrong value.  This fixes styling in
7256         long lists of file names that are interrupted by the "Continue?"
7257         prompt.
7258
7259 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7260
7261         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
7262         * c-lang.c (c_language_defn): Likewise.
7263         (cplus_language_defn): Likewise.
7264         (asm_language_defn): Likewise.
7265         (minimal_language_defn): Likewise.
7266         * d-lang.c (d_language_defn): Likewise.
7267         * f-lang.c (f_language_defn): Likewise.
7268         * go-lang.c (go_language_defn): Likewise.
7269         * language.c (unknown_language_defn): Likewise.
7270         (auto_language_defn): Likewise.
7271         * language.h (struct language_defn): Remove la_magic field.
7272         (LANG_MAGIC): Delete.
7273         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
7274         * objc-lang.c (objc_language_defn): Likewise.
7275         * opencl-lang.c (opencl_language_defn): Likewise.
7276         * p-lang.c (pascal_language_defn): Likewise.
7277         * rust-lang.c (rust_language_defn): Likewise.
7278
7279 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7280
7281         * riscv-tdep.c (riscv_type_align): New function.
7282         (riscv_type_alignment): Delete.
7283         (riscv_arg_location): Use 'type_align'.
7284         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
7285
7286 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7287
7288         * gdbtypes.c (type_align): A struct with no non-static fields also
7289         has alignment of 1.
7290
7291 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7292
7293         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
7294         component to 0.
7295         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
7296         member.
7297         (riscv_struct_info::analyse): New implementation using new
7298         analyse_inner member function.
7299         (riscv_struct_info::field_offset): New member function.
7300         (riscv_struct_info::m_offsets): New member variable.
7301         (riscv_struct_info::analyse_inner): New private member function,
7302         takes the old implementation of riscv_struct_info::analyse but
7303         extended to track field offsets.
7304         (riscv_call_arg_struct): Update the struct folding special cases
7305         to handle cases where empty C++ structs, which are non-zero
7306         length, are found.
7307         (riscv_arg_location): Initialise the length of each location, a
7308         non-zero length now indicates the location is in use.
7309         (riscv_push_dummy_call): Allow for the first location having a
7310         non-zero offset when setting up arguments.
7311         (riscv_return_value): Likewise, but for return values.
7312
7313 2019-04-11  Tom Tromey  <tromey@adacore.com>
7314
7315         * utils.c (internal_vproblem): Make "msg" const.
7316
7317 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
7318
7319         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
7320         * trad-frame.c (trad_frame_reset_saved_regs): New function.
7321         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
7322         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
7323
7324 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
7325
7326         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
7327         function.
7328         (fill_gregset): Call amd64_linux_collect_native_gregset instead
7329         of amd64_collect_native_gregset.
7330         (amd64_linux_nat_target::store_registers): Likewise.
7331
7332 2019-04-10  Tom Tromey  <tom@tromey.com>
7333
7334         * symtab.c (lookup_global_symbol_from_objfile)
7335         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
7336         * objfiles.h (class separate_debug_iterator): New.
7337         (class separate_debug_range): New.
7338         (struct objfile) <separate_debug_objfiles>: New method.
7339         (objfile_separate_debug_iterate): Don't declare.
7340         * objfiles.c (separate_debug_iterator::operator++): Rename from
7341         objfile_separate_debug_iterate.
7342         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
7343         iterator.
7344         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
7345         iterator.
7346
7347 2019-04-10  Tom Tromey  <tom@tromey.com>
7348
7349         * symfile.c (reread_symbols): Remove old comment.
7350         * objfiles.c (free_all_objfiles): Fix a typo.
7351
7352 2019-04-10  Tom Tromey  <tom@tromey.com>
7353
7354         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
7355         * minsyms.c (lookup_minimal_symbol): Use foreach.
7356         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
7357         (lookup_minimal_symbol_solib_trampoline): Likewise.
7358         * symfile.c (reread_symbols): Use foreach.
7359
7360 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
7361             Tom Tromey  <tromey@adacore.com>
7362
7363         PR rust/24414:
7364         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
7365         (rust_lex_int_test): Change "value" to be LONGEST.
7366         (rust_lex_tests): Add test for long integer literal.
7367
7368 2019-04-09  Tom Tromey  <tromey@adacore.com>
7369
7370         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
7371         to bool.
7372         (extended_remote_target::attach): Update.
7373         (remote_target::remote_notice_new_inferior): Update.
7374         (remote_target::add_current_inferior_and_thread): Update.
7375         * inferior.c (exit_inferior_1): Use "false".
7376         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
7377
7378 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
7379
7380         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
7381         the "start" command.
7382
7383 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7384
7385         * python/py-inferior.c (infpy_thread_from_thread_handle):
7386         Adjust comments to reflect renaming of thread_from_thread_handle
7387         to thread_from_handle.  Adjust keywords.  Fix type error message.
7388         (inferior_object_methods): Add thread_from_handle.  Retain
7389         thread_from_thread_handle, but mark it as deprecated.
7390
7391 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7392
7393         * gdbthread.h (find_thread_by_handle): Revise declaration.
7394         * thread.c (find_thread_by_handle): Likewise.  Adjust
7395         implementation too.
7396         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
7397         support for buffer objects as handles.
7398
7399 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7400
7401         * python/py-infthread.c (thpy_thread_handle): New function.
7402         (thread_object_methods): Register thpy_thread_handle.
7403
7404 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7405
7406         * gdbthread.h (thread_to_thread_handle): Declare.
7407         * thread.c (gdbtypes.h): Include.
7408         (thread_to_thread_handle): New function.
7409
7410         * target.h (struct target_ops): Add thread_info_to_thread_handle.
7411         (target_thread_info_to_thread_handle): Declare.
7412         * target.c (target_thread_info_to_thread_handle): New function.
7413         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
7414         * target-delegates.c: Regenerate.
7415
7416         * linux-thread-db.c (class thread_db_target): Add method
7417         thread_info_to_thread_handle.
7418         (thread_db_target::thread_info_to_thread_handle): Define.
7419         * remote.c (class remote_target): Add new method
7420         thread_info_to_thread_handle.
7421         (remote_target::thread_info_to_thread_handle): Define.
7422
7423 2019-04-08  Pedro Alves  <palves@redhat.com>
7424
7425         * common/common-exceptions.c (throw_exception): Don't create
7426         named object to throw; throw directly.
7427         (throw_it): Likewise.  Don't initialize gdb_exception::message
7428         here, with new; pass FMT and AP to the ctor instead.
7429         * common/common-exceptions.h: Include <string>.
7430         (gdb_exception::gdb_exception(enum return_reason, enum errors,
7431         const char *, va_list)): New ctor.  Use std::make_shared.
7432         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
7433         errors)): Delete.
7434         (gdb_exception_error::gdb_exception_error(enum errors, const char
7435         *, va_list)): New.
7436         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
7437         Add assertion.
7438         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
7439         errors)): Delete.
7440         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
7441         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
7442         Add assertion.
7443
7444 2019-04-08  Tom Tromey  <tom@tromey.com>
7445
7446         * valops.c (value_rtti_indirect_type): Replace throw_exception
7447         with throw.
7448         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
7449         with throw.
7450         * thread.c (thr_try_catch_cmd): Replace throw_exception with
7451         throw.
7452         * target.c (target_translate_tls_address): Replace throw_exception
7453         with throw.
7454         * stack.c (frame_apply_command_count): Replace throw_exception
7455         with throw.
7456         * solib-spu.c (append_ocl_sos): Replace throw_exception with
7457         throw.
7458         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
7459         with throw.
7460         * rs6000-tdep.c (rs6000_frame_cache)
7461         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
7462         * remote.c: Replace throw_exception with throw.
7463         * record-full.c (record_full_message, record_full_wait_1)
7464         (record_full_restore): Replace throw_exception with throw.
7465         * record-btrace.c:
7466         (get_thread_current_frame_id, record_btrace_start_replaying)
7467         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
7468         (cmd_record_btrace_start): Replace throw_exception with throw.
7469         * parse.c (parse_exp_in_context_1): Replace throw_exception with
7470         throw.
7471         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
7472         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
7473         * linespec.c:
7474         (find_linespec_symbols): Replace throw_exception with throw.
7475         * infrun.c (displaced_step_prepare, resume): Replace
7476         throw_exception with throw.
7477         * infcmd.c (post_create_inferior): Replace throw_exception with
7478         throw.
7479         * inf-loop.c (inferior_event_handler): Replace throw_exception
7480         with throw.
7481         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
7482         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
7483         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
7484         (get_prev_frame_always, get_frame_pc_if_available)
7485         (get_frame_address_in_block_if_available, get_frame_language):
7486         Replace throw_exception with throw.
7487         * frame-unwind.c (frame_unwind_try_unwinder): Replace
7488         throw_exception with throw.
7489         * eval.c (fetch_subexp_value, evaluate_var_value)
7490         (evaluate_funcall, evaluate_subexp_standard): Replace
7491         throw_exception with throw.
7492         * dwarf2loc.c (call_site_find_chain)
7493         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
7494         Replace throw_exception with throw.
7495         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
7496         with throw.
7497         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
7498         throw.
7499         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
7500         * completer.c (complete_line_internal): Replace throw_exception
7501         with throw.
7502         * compile/compile-object-run.c (compile_object_run): Replace
7503         throw_exception with throw.
7504         * cli/cli-script.c (process_next_line): Replace throw_exception
7505         with throw.
7506         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
7507         (btrace_enable, btrace_maint_update_pt_packets): Replace
7508         throw_exception with throw.
7509         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
7510         throw_exception with throw.
7511         * break-catch-throw.c (re_set_exception_catchpoint): Replace
7512         throw_exception with throw.
7513         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
7514         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
7515         * aarch64-tdep.c (aarch64_make_prologue_cache)
7516         (aarch64_make_stub_cache): Replace throw_exception with throw.
7517
7518 2019-04-08  Tom Tromey  <tom@tromey.com>
7519
7520         * common/common-exceptions.c (throw_exception): Rename from
7521         throw_exception_cxx.  Remove old copy.  Make argument const.
7522         (throw_it): Create and throw exception objects directly.
7523         * common/common-exceptions.h (throw_exception): Make argument
7524         const.
7525         (struct gdb_exception_error): Add constructor.
7526         (struct gdb_exception_quit): Add constructor.
7527
7528 2019-04-08  Tom Tromey  <tom@tromey.com>
7529
7530         * common/common-exceptions.h (exception_rethrow): Don't declare.
7531         (TRY_SJLJ): Update comment.
7532         (TRY, CATCH, END_CATCH): Remove.
7533         * common/common-exceptions.c (exception_rethrow): Remove.
7534
7535 2019-04-08  Tom Tromey  <tom@tromey.com>
7536
7537         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
7538         Remove.
7539         (gdb_exception_error): Rename from
7540         gdb_exception_RETURN_MASK_ERROR.
7541         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
7542         (gdb_quit_bad_alloc): Update.
7543         * aarch64-tdep.c: Update.
7544         * ada-lang.c: Update.
7545         * ada-typeprint.c: Update.
7546         * ada-valprint.c: Update.
7547         * amd64-tdep.c: Update.
7548         * arch-utils.c: Update.
7549         * break-catch-throw.c: Update.
7550         * breakpoint.c: Update.
7551         * btrace.c: Update.
7552         * c-varobj.c: Update.
7553         * cli/cli-cmds.c: Update.
7554         * cli/cli-interp.c: Update.
7555         * cli/cli-script.c: Update.
7556         * common/common-exceptions.c: Update.
7557         * common/new-op.c: Update.
7558         * common/selftest.c: Update.
7559         * compile/compile-c-symbols.c: Update.
7560         * compile/compile-cplus-symbols.c: Update.
7561         * compile/compile-object-load.c: Update.
7562         * compile/compile-object-run.c: Update.
7563         * completer.c: Update.
7564         * corelow.c: Update.
7565         * cp-abi.c: Update.
7566         * cp-support.c: Update.
7567         * cp-valprint.c: Update.
7568         * darwin-nat.c: Update.
7569         * disasm-selftests.c: Update.
7570         * dtrace-probe.c: Update.
7571         * dwarf-index-cache.c: Update.
7572         * dwarf-index-write.c: Update.
7573         * dwarf2-frame-tailcall.c: Update.
7574         * dwarf2-frame.c: Update.
7575         * dwarf2loc.c: Update.
7576         * dwarf2read.c: Update.
7577         * eval.c: Update.
7578         * event-loop.c: Update.
7579         * event-top.c: Update.
7580         * exec.c: Update.
7581         * f-valprint.c: Update.
7582         * fbsd-tdep.c: Update.
7583         * frame-unwind.c: Update.
7584         * frame.c: Update.
7585         * gdbtypes.c: Update.
7586         * gnu-v3-abi.c: Update.
7587         * guile/guile-internal.h: Update.
7588         * guile/scm-block.c: Update.
7589         * guile/scm-breakpoint.c: Update.
7590         * guile/scm-cmd.c: Update.
7591         * guile/scm-disasm.c: Update.
7592         * guile/scm-frame.c: Update.
7593         * guile/scm-lazy-string.c: Update.
7594         * guile/scm-math.c: Update.
7595         * guile/scm-param.c: Update.
7596         * guile/scm-ports.c: Update.
7597         * guile/scm-pretty-print.c: Update.
7598         * guile/scm-symbol.c: Update.
7599         * guile/scm-symtab.c: Update.
7600         * guile/scm-type.c: Update.
7601         * guile/scm-value.c: Update.
7602         * i386-linux-tdep.c: Update.
7603         * i386-tdep.c: Update.
7604         * inf-loop.c: Update.
7605         * infcall.c: Update.
7606         * infcmd.c: Update.
7607         * infrun.c: Update.
7608         * jit.c: Update.
7609         * language.c: Update.
7610         * linespec.c: Update.
7611         * linux-fork.c: Update.
7612         * linux-nat.c: Update.
7613         * linux-tdep.c: Update.
7614         * linux-thread-db.c: Update.
7615         * main.c: Update.
7616         * mi/mi-cmd-break.c: Update.
7617         * mi/mi-cmd-stack.c: Update.
7618         * mi/mi-interp.c: Update.
7619         * mi/mi-main.c: Update.
7620         * objc-lang.c: Update.
7621         * p-valprint.c: Update.
7622         * parse.c: Update.
7623         * ppc-linux-tdep.c: Update.
7624         * printcmd.c: Update.
7625         * python/py-arch.c: Update.
7626         * python/py-breakpoint.c: Update.
7627         * python/py-cmd.c: Update.
7628         * python/py-finishbreakpoint.c: Update.
7629         * python/py-frame.c: Update.
7630         * python/py-framefilter.c: Update.
7631         * python/py-gdb-readline.c: Update.
7632         * python/py-inferior.c: Update.
7633         * python/py-infthread.c: Update.
7634         * python/py-lazy-string.c: Update.
7635         * python/py-linetable.c: Update.
7636         * python/py-objfile.c: Update.
7637         * python/py-param.c: Update.
7638         * python/py-prettyprint.c: Update.
7639         * python/py-progspace.c: Update.
7640         * python/py-record-btrace.c: Update.
7641         * python/py-record.c: Update.
7642         * python/py-symbol.c: Update.
7643         * python/py-type.c: Update.
7644         * python/py-unwind.c: Update.
7645         * python/py-utils.c: Update.
7646         * python/py-value.c: Update.
7647         * python/python.c: Update.
7648         * record-btrace.c: Update.
7649         * record-full.c: Update.
7650         * remote-fileio.c: Update.
7651         * remote.c: Update.
7652         * riscv-tdep.c: Update.
7653         * rs6000-aix-tdep.c: Update.
7654         * rs6000-tdep.c: Update.
7655         * rust-exp.y: Update.
7656         * rust-lang.c: Update.
7657         * s390-tdep.c: Update.
7658         * selftest-arch.c: Update.
7659         * solib-dsbt.c: Update.
7660         * solib-frv.c: Update.
7661         * solib-spu.c: Update.
7662         * solib-svr4.c: Update.
7663         * solib.c: Update.
7664         * sparc64-linux-tdep.c: Update.
7665         * stack.c: Update.
7666         * symfile-mem.c: Update.
7667         * symmisc.c: Update.
7668         * target.c: Update.
7669         * thread.c: Update.
7670         * top.c: Update.
7671         * tracefile-tfile.c: Update.
7672         * tui/tui.c: Update.
7673         * typeprint.c: Update.
7674         * unittests/cli-utils-selftests.c: Update.
7675         * unittests/parse-connection-spec-selftests.c: Update.
7676         * valops.c: Update.
7677         * valprint.c: Update.
7678         * value.c: Update.
7679         * varobj.c: Update.
7680         * windows-nat.c: Update.
7681         * x86-linux-nat.c: Update.
7682         * xml-support.c: Update.
7683
7684 2019-04-08  Tom Tromey  <tom@tromey.com>
7685
7686         * xml-support.c: Use C++ exception handling.
7687         * x86-linux-nat.c: Use C++ exception handling.
7688         * windows-nat.c: Use C++ exception handling.
7689         * varobj.c: Use C++ exception handling.
7690         * value.c: Use C++ exception handling.
7691         * valprint.c: Use C++ exception handling.
7692         * valops.c: Use C++ exception handling.
7693         * unittests/parse-connection-spec-selftests.c: Use C++ exception
7694         handling.
7695         * unittests/cli-utils-selftests.c: Use C++ exception handling.
7696         * typeprint.c: Use C++ exception handling.
7697         * tui/tui.c: Use C++ exception handling.
7698         * tracefile-tfile.c: Use C++ exception handling.
7699         * top.c: Use C++ exception handling.
7700         * thread.c: Use C++ exception handling.
7701         * target.c: Use C++ exception handling.
7702         * symmisc.c: Use C++ exception handling.
7703         * symfile-mem.c: Use C++ exception handling.
7704         * stack.c: Use C++ exception handling.
7705         * sparc64-linux-tdep.c: Use C++ exception handling.
7706         * solib.c: Use C++ exception handling.
7707         * solib-svr4.c: Use C++ exception handling.
7708         * solib-spu.c: Use C++ exception handling.
7709         * solib-frv.c: Use C++ exception handling.
7710         * solib-dsbt.c: Use C++ exception handling.
7711         * selftest-arch.c: Use C++ exception handling.
7712         * s390-tdep.c: Use C++ exception handling.
7713         * rust-lang.c: Use C++ exception handling.
7714         * rust-exp.y: Use C++ exception handling.
7715         * rs6000-tdep.c: Use C++ exception handling.
7716         * rs6000-aix-tdep.c: Use C++ exception handling.
7717         * riscv-tdep.c: Use C++ exception handling.
7718         * remote.c: Use C++ exception handling.
7719         * remote-fileio.c: Use C++ exception handling.
7720         * record-full.c: Use C++ exception handling.
7721         * record-btrace.c: Use C++ exception handling.
7722         * python/python.c: Use C++ exception handling.
7723         * python/py-value.c: Use C++ exception handling.
7724         * python/py-utils.c: Use C++ exception handling.
7725         * python/py-unwind.c: Use C++ exception handling.
7726         * python/py-type.c: Use C++ exception handling.
7727         * python/py-symbol.c: Use C++ exception handling.
7728         * python/py-record.c: Use C++ exception handling.
7729         * python/py-record-btrace.c: Use C++ exception handling.
7730         * python/py-progspace.c: Use C++ exception handling.
7731         * python/py-prettyprint.c: Use C++ exception handling.
7732         * python/py-param.c: Use C++ exception handling.
7733         * python/py-objfile.c: Use C++ exception handling.
7734         * python/py-linetable.c: Use C++ exception handling.
7735         * python/py-lazy-string.c: Use C++ exception handling.
7736         * python/py-infthread.c: Use C++ exception handling.
7737         * python/py-inferior.c: Use C++ exception handling.
7738         * python/py-gdb-readline.c: Use C++ exception handling.
7739         * python/py-framefilter.c: Use C++ exception handling.
7740         * python/py-frame.c: Use C++ exception handling.
7741         * python/py-finishbreakpoint.c: Use C++ exception handling.
7742         * python/py-cmd.c: Use C++ exception handling.
7743         * python/py-breakpoint.c: Use C++ exception handling.
7744         * python/py-arch.c: Use C++ exception handling.
7745         * printcmd.c: Use C++ exception handling.
7746         * ppc-linux-tdep.c: Use C++ exception handling.
7747         * parse.c: Use C++ exception handling.
7748         * p-valprint.c: Use C++ exception handling.
7749         * objc-lang.c: Use C++ exception handling.
7750         * mi/mi-main.c: Use C++ exception handling.
7751         * mi/mi-interp.c: Use C++ exception handling.
7752         * mi/mi-cmd-stack.c: Use C++ exception handling.
7753         * mi/mi-cmd-break.c: Use C++ exception handling.
7754         * main.c: Use C++ exception handling.
7755         * linux-thread-db.c: Use C++ exception handling.
7756         * linux-tdep.c: Use C++ exception handling.
7757         * linux-nat.c: Use C++ exception handling.
7758         * linux-fork.c: Use C++ exception handling.
7759         * linespec.c: Use C++ exception handling.
7760         * language.c: Use C++ exception handling.
7761         * jit.c: Use C++ exception handling.
7762         * infrun.c: Use C++ exception handling.
7763         * infcmd.c: Use C++ exception handling.
7764         * infcall.c: Use C++ exception handling.
7765         * inf-loop.c: Use C++ exception handling.
7766         * i386-tdep.c: Use C++ exception handling.
7767         * i386-linux-tdep.c: Use C++ exception handling.
7768         * guile/scm-value.c: Use C++ exception handling.
7769         * guile/scm-type.c: Use C++ exception handling.
7770         * guile/scm-symtab.c: Use C++ exception handling.
7771         * guile/scm-symbol.c: Use C++ exception handling.
7772         * guile/scm-pretty-print.c: Use C++ exception handling.
7773         * guile/scm-ports.c: Use C++ exception handling.
7774         * guile/scm-param.c: Use C++ exception handling.
7775         * guile/scm-math.c: Use C++ exception handling.
7776         * guile/scm-lazy-string.c: Use C++ exception handling.
7777         * guile/scm-frame.c: Use C++ exception handling.
7778         * guile/scm-disasm.c: Use C++ exception handling.
7779         * guile/scm-cmd.c: Use C++ exception handling.
7780         * guile/scm-breakpoint.c: Use C++ exception handling.
7781         * guile/scm-block.c: Use C++ exception handling.
7782         * guile/guile-internal.h: Use C++ exception handling.
7783         * gnu-v3-abi.c: Use C++ exception handling.
7784         * gdbtypes.c: Use C++ exception handling.
7785         * frame.c: Use C++ exception handling.
7786         * frame-unwind.c: Use C++ exception handling.
7787         * fbsd-tdep.c: Use C++ exception handling.
7788         * f-valprint.c: Use C++ exception handling.
7789         * exec.c: Use C++ exception handling.
7790         * event-top.c: Use C++ exception handling.
7791         * event-loop.c: Use C++ exception handling.
7792         * eval.c: Use C++ exception handling.
7793         * dwarf2read.c: Use C++ exception handling.
7794         * dwarf2loc.c: Use C++ exception handling.
7795         * dwarf2-frame.c: Use C++ exception handling.
7796         * dwarf2-frame-tailcall.c: Use C++ exception handling.
7797         * dwarf-index-write.c: Use C++ exception handling.
7798         * dwarf-index-cache.c: Use C++ exception handling.
7799         * dtrace-probe.c: Use C++ exception handling.
7800         * disasm-selftests.c: Use C++ exception handling.
7801         * darwin-nat.c: Use C++ exception handling.
7802         * cp-valprint.c: Use C++ exception handling.
7803         * cp-support.c: Use C++ exception handling.
7804         * cp-abi.c: Use C++ exception handling.
7805         * corelow.c: Use C++ exception handling.
7806         * completer.c: Use C++ exception handling.
7807         * compile/compile-object-run.c: Use C++ exception handling.
7808         * compile/compile-object-load.c: Use C++ exception handling.
7809         * compile/compile-cplus-symbols.c: Use C++ exception handling.
7810         * compile/compile-c-symbols.c: Use C++ exception handling.
7811         * common/selftest.c: Use C++ exception handling.
7812         * common/new-op.c: Use C++ exception handling.
7813         * cli/cli-script.c: Use C++ exception handling.
7814         * cli/cli-interp.c: Use C++ exception handling.
7815         * cli/cli-cmds.c: Use C++ exception handling.
7816         * c-varobj.c: Use C++ exception handling.
7817         * btrace.c: Use C++ exception handling.
7818         * breakpoint.c: Use C++ exception handling.
7819         * break-catch-throw.c: Use C++ exception handling.
7820         * arch-utils.c: Use C++ exception handling.
7821         * amd64-tdep.c: Use C++ exception handling.
7822         * ada-valprint.c: Use C++ exception handling.
7823         * ada-typeprint.c: Use C++ exception handling.
7824         * ada-lang.c: Use C++ exception handling.
7825         * aarch64-tdep.c: Use C++ exception handling.
7826
7827 2019-04-08  Tom Tromey  <tom@tromey.com>
7828
7829         * xml-support.c (gdb_xml_parser::parse): Update.
7830         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7831         * value.c (show_convenience): Update.
7832         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
7833         (test_parse_flags_qcs): Update.
7834         * thread.c (thr_try_catch_cmd): Update.
7835         * target.c (target_translate_tls_address): Update.
7836         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
7837         (info_frame_command_core, frame_apply_command_count): Update.
7838         * rust-exp.y (rust_lex_exception_test): Update.
7839         * riscv-tdep.c (riscv_print_one_register_info): Update.
7840         * remote.c (remote_target::enable_btrace): Update.
7841         * record-btrace.c (record_btrace_enable_warn): Update.
7842         * python/py-utils.c (gdbpy_convert_exception): Update.
7843         * printcmd.c (do_one_display, print_variable_and_value): Update.
7844         * mi/mi-main.c (mi_print_exception): Update.
7845         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
7846         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
7847         * linux-nat.c (linux_nat_target::attach): Update.
7848         * linux-fork.c (class scoped_switch_fork_info): Update.
7849         * infrun.c (displaced_step_prepare): Update.
7850         * infcall.c (call_function_by_hand_dummy): Update.
7851         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
7852         * gnu-v3-abi.c (print_one_vtable): Update.
7853         * frame.c (get_prev_frame_always): Update.
7854         * f-valprint.c (info_common_command_for_block): Update.
7855         * exec.c (try_open_exec_file): Update.
7856         * exceptions.c (print_exception, exception_print)
7857         (exception_fprintf, exception_print_same): Update.
7858         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
7859         * dwarf-index-cache.c (index_cache::store)
7860         (index_cache::lookup_gdb_index): Update.
7861         * darwin-nat.c (maybe_cache_shell): Update.
7862         * cp-valprint.c (cp_print_value_fields): Update.
7863         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
7864         (gcc_cplus_symbol_address): Update.
7865         * compile/compile-c-symbols.c (gcc_convert_symbol)
7866         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
7867         * common/selftest.c: Update.
7868         * common/common-exceptions.h (struct gdb_exception) <message>: Now
7869         a std::string.
7870         (exception_try_scope_entry, exception_try_scope_exit): Don't
7871         declare.
7872         (struct exception_try_scope): Remove.
7873         (TRY): Don't use exception_try_scope.
7874         (struct gdb_exception): Add constructor, operator=.
7875         <what>: New method.
7876         (struct gdb_exception_RETURN_MASK_ALL)
7877         (struct gdb_exception_RETURN_MASK_ERROR)
7878         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
7879         (struct gdb_quit_bad_alloc): Update.
7880         * common/common-exceptions.c (exception_none): Change
7881         initializer.
7882         (struct catcher) <state, exception>: Initialize inline.
7883         <prev>: Remove member.
7884         (current_catcher): Remove.
7885         (catchers): New global.
7886         (exceptions_state_mc_init): Simplify.
7887         (catcher_pop): Remove.
7888         (exceptions_state_mc, exceptions_state_mc_catch): Update.
7889         (try_scope_depth, exception_try_scope_entry)
7890         (exception_try_scope_exit): Remove.
7891         (throw_exception_sjlj): Update.
7892         (exception_messages, exception_messages_size): Remove.
7893         (throw_it): Simplify.
7894         (gdb_exception_sliced_copy): Remove.
7895         (throw_exception_cxx): Update.
7896         * cli/cli-script.c (script_from_file): Update.
7897         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
7898         Update.
7899         * ada-valprint.c (ada_val_print): Update.
7900         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
7901         (create_excep_cond_exprs): Update.
7902
7903 2019-04-08  Tom Tromey  <tom@tromey.com>
7904
7905         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
7906         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
7907         (TRY, CATCH, END_CATCH): Remove some definitions.
7908         * common/common-exceptions.c: Don't use GDB_XCPT.
7909         (catcher_list_size): Remove.
7910         (throw_exception, throw_it): Simplify.
7911
7912 2019-04-05  Tom Tromey  <tom@tromey.com>
7913
7914         Revert the header-sorting patch.
7915         * ft32-tdep.c: Revert.
7916         * frv-tdep.c: Revert.
7917         * frv-linux-tdep.c: Revert.
7918         * frame.c: Revert.
7919         * frame-unwind.c: Revert.
7920         * frame-base.c: Revert.
7921         * fork-child.c: Revert.
7922         * findvar.c: Revert.
7923         * findcmd.c: Revert.
7924         * filesystem.c: Revert.
7925         * filename-seen-cache.h: Revert.
7926         * filename-seen-cache.c: Revert.
7927         * fbsd-tdep.c: Revert.
7928         * fbsd-nat.h: Revert.
7929         * fbsd-nat.c: Revert.
7930         * f-valprint.c: Revert.
7931         * f-typeprint.c: Revert.
7932         * f-lang.c: Revert.
7933         * extension.h: Revert.
7934         * extension.c: Revert.
7935         * extension-priv.h: Revert.
7936         * expprint.c: Revert.
7937         * exec.h: Revert.
7938         * exec.c: Revert.
7939         * exceptions.c: Revert.
7940         * event-top.c: Revert.
7941         * event-loop.c: Revert.
7942         * eval.c: Revert.
7943         * elfread.c: Revert.
7944         * dwarf2read.h: Revert.
7945         * dwarf2read.c: Revert.
7946         * dwarf2loc.c: Revert.
7947         * dwarf2expr.h: Revert.
7948         * dwarf2expr.c: Revert.
7949         * dwarf2-frame.c: Revert.
7950         * dwarf2-frame-tailcall.c: Revert.
7951         * dwarf-index-write.h: Revert.
7952         * dwarf-index-write.c: Revert.
7953         * dwarf-index-common.c: Revert.
7954         * dwarf-index-cache.h: Revert.
7955         * dwarf-index-cache.c: Revert.
7956         * dummy-frame.c: Revert.
7957         * dtrace-probe.c: Revert.
7958         * disasm.h: Revert.
7959         * disasm.c: Revert.
7960         * disasm-selftests.c: Revert.
7961         * dictionary.c: Revert.
7962         * dicos-tdep.c: Revert.
7963         * demangle.c: Revert.
7964         * dcache.h: Revert.
7965         * dcache.c: Revert.
7966         * darwin-nat.h: Revert.
7967         * darwin-nat.c: Revert.
7968         * darwin-nat-info.c: Revert.
7969         * d-valprint.c: Revert.
7970         * d-namespace.c: Revert.
7971         * d-lang.c: Revert.
7972         * ctf.c: Revert.
7973         * csky-tdep.c: Revert.
7974         * csky-linux-tdep.c: Revert.
7975         * cris-tdep.c: Revert.
7976         * cris-linux-tdep.c: Revert.
7977         * cp-valprint.c: Revert.
7978         * cp-support.c: Revert.
7979         * cp-namespace.c: Revert.
7980         * cp-abi.c: Revert.
7981         * corelow.c: Revert.
7982         * corefile.c: Revert.
7983         * continuations.c: Revert.
7984         * completer.h: Revert.
7985         * completer.c: Revert.
7986         * complaints.c: Revert.
7987         * coffread.c: Revert.
7988         * coff-pe-read.c: Revert.
7989         * cli-out.h: Revert.
7990         * cli-out.c: Revert.
7991         * charset.c: Revert.
7992         * c-varobj.c: Revert.
7993         * c-valprint.c: Revert.
7994         * c-typeprint.c: Revert.
7995         * c-lang.c: Revert.
7996         * buildsym.c: Revert.
7997         * buildsym-legacy.c: Revert.
7998         * build-id.h: Revert.
7999         * build-id.c: Revert.
8000         * btrace.c: Revert.
8001         * bsd-uthread.c: Revert.
8002         * breakpoint.h: Revert.
8003         * breakpoint.c: Revert.
8004         * break-catch-throw.c: Revert.
8005         * break-catch-syscall.c: Revert.
8006         * break-catch-sig.c: Revert.
8007         * blockframe.c: Revert.
8008         * block.c: Revert.
8009         * bfin-tdep.c: Revert.
8010         * bfin-linux-tdep.c: Revert.
8011         * bfd-target.c: Revert.
8012         * bcache.c: Revert.
8013         * ax-general.c: Revert.
8014         * ax-gdb.h: Revert.
8015         * ax-gdb.c: Revert.
8016         * avr-tdep.c: Revert.
8017         * auxv.c: Revert.
8018         * auto-load.c: Revert.
8019         * arm-wince-tdep.c: Revert.
8020         * arm-tdep.c: Revert.
8021         * arm-symbian-tdep.c: Revert.
8022         * arm-pikeos-tdep.c: Revert.
8023         * arm-obsd-tdep.c: Revert.
8024         * arm-nbsd-tdep.c: Revert.
8025         * arm-nbsd-nat.c: Revert.
8026         * arm-linux-tdep.c: Revert.
8027         * arm-linux-nat.c: Revert.
8028         * arm-fbsd-tdep.c: Revert.
8029         * arm-fbsd-nat.c: Revert.
8030         * arm-bsd-tdep.c: Revert.
8031         * arch-utils.c: Revert.
8032         * arc-tdep.c: Revert.
8033         * arc-newlib-tdep.c: Revert.
8034         * annotate.h: Revert.
8035         * annotate.c: Revert.
8036         * amd64-windows-tdep.c: Revert.
8037         * amd64-windows-nat.c: Revert.
8038         * amd64-tdep.c: Revert.
8039         * amd64-sol2-tdep.c: Revert.
8040         * amd64-obsd-tdep.c: Revert.
8041         * amd64-obsd-nat.c: Revert.
8042         * amd64-nbsd-tdep.c: Revert.
8043         * amd64-nbsd-nat.c: Revert.
8044         * amd64-nat.c: Revert.
8045         * amd64-linux-tdep.c: Revert.
8046         * amd64-linux-nat.c: Revert.
8047         * amd64-fbsd-tdep.c: Revert.
8048         * amd64-fbsd-nat.c: Revert.
8049         * amd64-dicos-tdep.c: Revert.
8050         * amd64-darwin-tdep.c: Revert.
8051         * amd64-bsd-nat.c: Revert.
8052         * alpha-tdep.c: Revert.
8053         * alpha-obsd-tdep.c: Revert.
8054         * alpha-nbsd-tdep.c: Revert.
8055         * alpha-mdebug-tdep.c: Revert.
8056         * alpha-linux-tdep.c: Revert.
8057         * alpha-linux-nat.c: Revert.
8058         * alpha-bsd-tdep.c: Revert.
8059         * alpha-bsd-nat.c: Revert.
8060         * aix-thread.c: Revert.
8061         * agent.c: Revert.
8062         * addrmap.c: Revert.
8063         * ada-varobj.c: Revert.
8064         * ada-valprint.c: Revert.
8065         * ada-typeprint.c: Revert.
8066         * ada-tasks.c: Revert.
8067         * ada-lang.c: Revert.
8068         * aarch64-tdep.c: Revert.
8069         * aarch64-ravenscar-thread.c: Revert.
8070         * aarch64-newlib-tdep.c: Revert.
8071         * aarch64-linux-tdep.c: Revert.
8072         * aarch64-linux-nat.c: Revert.
8073         * aarch64-fbsd-tdep.c: Revert.
8074         * aarch64-fbsd-nat.c: Revert.
8075         * aarch32-linux-nat.c: Revert.
8076
8077 2019-04-05  Tom Tromey  <tom@tromey.com>
8078
8079         * ft32-tdep.c: Sort headers.
8080         * frv-tdep.c: Sort headers.
8081         * frv-linux-tdep.c: Sort headers.
8082         * frame.c: Sort headers.
8083         * frame-unwind.c: Sort headers.
8084         * frame-base.c: Sort headers.
8085         * fork-child.c: Sort headers.
8086         * findvar.c: Sort headers.
8087         * findcmd.c: Sort headers.
8088         * filesystem.c: Sort headers.
8089         * filename-seen-cache.h: Sort headers.
8090         * filename-seen-cache.c: Sort headers.
8091         * fbsd-tdep.c: Sort headers.
8092         * fbsd-nat.h: Sort headers.
8093         * fbsd-nat.c: Sort headers.
8094         * f-valprint.c: Sort headers.
8095         * f-typeprint.c: Sort headers.
8096         * f-lang.c: Sort headers.
8097         * extension.h: Sort headers.
8098         * extension.c: Sort headers.
8099         * extension-priv.h: Sort headers.
8100         * expprint.c: Sort headers.
8101         * exec.h: Sort headers.
8102         * exec.c: Sort headers.
8103         * exceptions.c: Sort headers.
8104         * event-top.c: Sort headers.
8105         * event-loop.c: Sort headers.
8106         * eval.c: Sort headers.
8107         * elfread.c: Sort headers.
8108         * dwarf2read.h: Sort headers.
8109         * dwarf2read.c: Sort headers.
8110         * dwarf2loc.c: Sort headers.
8111         * dwarf2expr.h: Sort headers.
8112         * dwarf2expr.c: Sort headers.
8113         * dwarf2-frame.c: Sort headers.
8114         * dwarf2-frame-tailcall.c: Sort headers.
8115         * dwarf-index-write.h: Sort headers.
8116         * dwarf-index-write.c: Sort headers.
8117         * dwarf-index-common.c: Sort headers.
8118         * dwarf-index-cache.h: Sort headers.
8119         * dwarf-index-cache.c: Sort headers.
8120         * dummy-frame.c: Sort headers.
8121         * dtrace-probe.c: Sort headers.
8122         * disasm.h: Sort headers.
8123         * disasm.c: Sort headers.
8124         * disasm-selftests.c: Sort headers.
8125         * dictionary.c: Sort headers.
8126         * dicos-tdep.c: Sort headers.
8127         * demangle.c: Sort headers.
8128         * dcache.h: Sort headers.
8129         * dcache.c: Sort headers.
8130         * darwin-nat.h: Sort headers.
8131         * darwin-nat.c: Sort headers.
8132         * darwin-nat-info.c: Sort headers.
8133         * d-valprint.c: Sort headers.
8134         * d-namespace.c: Sort headers.
8135         * d-lang.c: Sort headers.
8136         * ctf.c: Sort headers.
8137         * csky-tdep.c: Sort headers.
8138         * csky-linux-tdep.c: Sort headers.
8139         * cris-tdep.c: Sort headers.
8140         * cris-linux-tdep.c: Sort headers.
8141         * cp-valprint.c: Sort headers.
8142         * cp-support.c: Sort headers.
8143         * cp-namespace.c: Sort headers.
8144         * cp-abi.c: Sort headers.
8145         * corelow.c: Sort headers.
8146         * corefile.c: Sort headers.
8147         * continuations.c: Sort headers.
8148         * completer.h: Sort headers.
8149         * completer.c: Sort headers.
8150         * complaints.c: Sort headers.
8151         * coffread.c: Sort headers.
8152         * coff-pe-read.c: Sort headers.
8153         * cli-out.h: Sort headers.
8154         * cli-out.c: Sort headers.
8155         * charset.c: Sort headers.
8156         * c-varobj.c: Sort headers.
8157         * c-valprint.c: Sort headers.
8158         * c-typeprint.c: Sort headers.
8159         * c-lang.c: Sort headers.
8160         * buildsym.c: Sort headers.
8161         * buildsym-legacy.c: Sort headers.
8162         * build-id.h: Sort headers.
8163         * build-id.c: Sort headers.
8164         * btrace.c: Sort headers.
8165         * bsd-uthread.c: Sort headers.
8166         * breakpoint.h: Sort headers.
8167         * breakpoint.c: Sort headers.
8168         * break-catch-throw.c: Sort headers.
8169         * break-catch-syscall.c: Sort headers.
8170         * break-catch-sig.c: Sort headers.
8171         * blockframe.c: Sort headers.
8172         * block.c: Sort headers.
8173         * bfin-tdep.c: Sort headers.
8174         * bfin-linux-tdep.c: Sort headers.
8175         * bfd-target.c: Sort headers.
8176         * bcache.c: Sort headers.
8177         * ax-general.c: Sort headers.
8178         * ax-gdb.h: Sort headers.
8179         * ax-gdb.c: Sort headers.
8180         * avr-tdep.c: Sort headers.
8181         * auxv.c: Sort headers.
8182         * auto-load.c: Sort headers.
8183         * arm-wince-tdep.c: Sort headers.
8184         * arm-tdep.c: Sort headers.
8185         * arm-symbian-tdep.c: Sort headers.
8186         * arm-pikeos-tdep.c: Sort headers.
8187         * arm-obsd-tdep.c: Sort headers.
8188         * arm-nbsd-tdep.c: Sort headers.
8189         * arm-nbsd-nat.c: Sort headers.
8190         * arm-linux-tdep.c: Sort headers.
8191         * arm-linux-nat.c: Sort headers.
8192         * arm-fbsd-tdep.c: Sort headers.
8193         * arm-fbsd-nat.c: Sort headers.
8194         * arm-bsd-tdep.c: Sort headers.
8195         * arch-utils.c: Sort headers.
8196         * arc-tdep.c: Sort headers.
8197         * arc-newlib-tdep.c: Sort headers.
8198         * annotate.h: Sort headers.
8199         * annotate.c: Sort headers.
8200         * amd64-windows-tdep.c: Sort headers.
8201         * amd64-windows-nat.c: Sort headers.
8202         * amd64-tdep.c: Sort headers.
8203         * amd64-sol2-tdep.c: Sort headers.
8204         * amd64-obsd-tdep.c: Sort headers.
8205         * amd64-obsd-nat.c: Sort headers.
8206         * amd64-nbsd-tdep.c: Sort headers.
8207         * amd64-nbsd-nat.c: Sort headers.
8208         * amd64-nat.c: Sort headers.
8209         * amd64-linux-tdep.c: Sort headers.
8210         * amd64-linux-nat.c: Sort headers.
8211         * amd64-fbsd-tdep.c: Sort headers.
8212         * amd64-fbsd-nat.c: Sort headers.
8213         * amd64-dicos-tdep.c: Sort headers.
8214         * amd64-darwin-tdep.c: Sort headers.
8215         * amd64-bsd-nat.c: Sort headers.
8216         * alpha-tdep.c: Sort headers.
8217         * alpha-obsd-tdep.c: Sort headers.
8218         * alpha-nbsd-tdep.c: Sort headers.
8219         * alpha-mdebug-tdep.c: Sort headers.
8220         * alpha-linux-tdep.c: Sort headers.
8221         * alpha-linux-nat.c: Sort headers.
8222         * alpha-bsd-tdep.c: Sort headers.
8223         * alpha-bsd-nat.c: Sort headers.
8224         * aix-thread.c: Sort headers.
8225         * agent.c: Sort headers.
8226         * addrmap.c: Sort headers.
8227         * ada-varobj.c: Sort headers.
8228         * ada-valprint.c: Sort headers.
8229         * ada-typeprint.c: Sort headers.
8230         * ada-tasks.c: Sort headers.
8231         * ada-lang.c: Sort headers.
8232         * aarch64-tdep.c: Sort headers.
8233         * aarch64-ravenscar-thread.c: Sort headers.
8234         * aarch64-newlib-tdep.c: Sort headers.
8235         * aarch64-linux-tdep.c: Sort headers.
8236         * aarch64-linux-nat.c: Sort headers.
8237         * aarch64-fbsd-tdep.c: Sort headers.
8238         * aarch64-fbsd-nat.c: Sort headers.
8239         * aarch32-linux-nat.c: Sort headers.
8240
8241 2019-04-04  Tom Tromey  <tom@tromey.com>
8242
8243         * varobj.c (varobj_create): Update.
8244         * rust-exp.y (struct rust_parser) <update_innermost_block,
8245         lookup_symbol>: New methods.
8246         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
8247         Rename.
8248         (rust_parser::rust_lookup_type)
8249         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8250         * printcmd.c (display_command, do_one_display): Update.
8251         * parser-defs.h (struct parser_state) <parser_state>: Add
8252         "tracker" parameter.
8253         (block_tracker): New member.
8254         (class innermost_block_tracker) <innermost_block_tracker>: Add
8255         "types" parameter.
8256         <reset>: Remove method.
8257         (innermost_block): Don't declare.
8258         (null_post_parser): Update.
8259         * parse.c (innermost_block): Remove global.
8260         (write_dollar_variable): Update.
8261         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
8262         Remove "tracker_types" parameter.
8263         (parse_expression): Add "tracker" parameter.
8264         (parse_expression_for_completion): Update.
8265         (null_post_parser): Add "tracker" parameter.
8266         * p-exp.y: Update rules.
8267         * m2-exp.y: Update rules.
8268         * language.h (struct language_defn) <la_post_parser>: Add
8269         "tracker" parameter.
8270         * go-exp.y: Update rules.
8271         * f-exp.y: Update rules.
8272         * expression.h (parse_expression, parse_exp_1): Add "tracker"
8273         parameter.
8274         * d-exp.y: Update rules.
8275         * c-exp.y: Update rules.
8276         * breakpoint.c (set_breakpoint_condition): Create an
8277         innermost_block_tracker.
8278         (watch_command_1): Likewise.
8279         * ada-lang.c (resolve): Add "tracker" parameter.
8280         (resolve_subexp): Likewise.
8281         * ada-exp.y (write_var_from_sym): Update.
8282
8283 2019-04-04  Tom Tromey  <tom@tromey.com>
8284
8285         * type-stack.h: New file.
8286         * type-stack.c: New file.
8287         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
8288         type-stack.h.
8289         (insert_into_type_stack, insert_type, push_type, push_type_int)
8290         (insert_type_address_space, pop_type, pop_type_int)
8291         (pop_typelist, pop_type_stack, append_type_stack)
8292         (push_type_stack, get_type_stack, push_typelist)
8293         (follow_type_instance_flags, follow_types): Don't declare.
8294         * parse.c (type_stack): Remove global.
8295         (parse_exp_in_context): Update.
8296         (insert_into_type_stack, insert_type, push_type, push_type_int)
8297         (insert_type_address_space, pop_type, pop_type_int)
8298         (pop_typelist, pop_type_stack, append_type_stack)
8299         (push_type_stack, get_type_stack, push_typelist)
8300         (follow_type_instance_flags, follow_types): Remove (moved to
8301         type-stack.c).
8302         * f-exp.y (type_stack): New global.
8303         Update rules.
8304         (push_kind_type, f_parse): Update.
8305         * d-exp.y (type_stack): New global.
8306         Update rules.
8307         (d_parse): Update.
8308         * c-exp.y (struct c_parse_state) <type_stack>: New member.
8309         Update rules.
8310         * Makefile.in (COMMON_SFILES): Add type-stack.c.
8311         (HFILES_NO_SRCDIR): Add type-stack.h.
8312
8313 2019-04-04  Tom Tromey  <tom@tromey.com>
8314
8315         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
8316         (rust_parser::convert_ast_to_expression, rust_parse)
8317         (rust_lex_test_completion, rust_lex_tests): Update.
8318         * parser-defs.h (struct expr_completion_state): New.
8319         (struct parser_state) <parser_state>: Add completion parameter.
8320         <mark_struct_expression, mark_completion_tag>: New methods.
8321         <parse_completion, m_completion_state>: New members.
8322         (prefixify_expression, null_post_parser): Update.
8323         (mark_struct_expression, mark_completion_tag): Don't declare.
8324         * parse.c (parse_completion, expout_last_struct)
8325         (expout_tag_completion_type, expout_completion_name): Remove
8326         globals.
8327         (parser_state::mark_struct_expression)
8328         (parser_state::mark_completion_tag): Now methods.
8329         (prefixify_expression): Add last_struct parameter.
8330         (prefixify_subexp): Likewise.
8331         (parse_exp_1): Update.
8332         (parse_exp_in_context): Add cstate parameter.  Update.
8333         (parse_expression_for_completion): Create an
8334         expr_completion_state.
8335         (null_post_parser): Add "completion" parameter.
8336         * p-exp.y: Update rules.
8337         (yylex): Update.
8338         * language.h (struct language_defn) <la_post_parser>: Add
8339         "completing" parameter.
8340         * go-exp.y: Update rules.
8341         (lex_one_token): Update.
8342         * expression.h (parse_completion): Don't declare.
8343         * d-exp.y: Update rules.
8344         (lex_one_token): Update rules.
8345         * c-exp.y: Update rules.
8346         (lex_one_token): Update.
8347         * ada-lang.c (resolve): Add "parse_completion" parameter.
8348         (resolve_subexp): Likewise.
8349         (ada_resolve_function): Likewise.
8350
8351 2019-04-04  Tom Tromey  <tom@tromey.com>
8352
8353         * parser-defs.h (struct parser_state) <start_arglist,
8354         end_arglist>: New methods.
8355         <arglist_len, m_funcall_chain>: New members.
8356         (arglist_len, start_arglist, end_arglist): Don't declare.
8357         * parse.c (arglist_len, funcall_chain): Remove global.
8358         (start_arglist, end_arglist): Remove functions.
8359         (parse_exp_in_context): Update.
8360         * p-exp.y: Update rules.
8361         * m2-exp.y: Update rules.
8362         * go-exp.y: Update rules.
8363         * f-exp.y: Update rules.
8364         * d-exp.y: Update rules.
8365         * c-exp.y: Update rules.
8366
8367 2019-04-04  Tom Tromey  <tom@tromey.com>
8368
8369         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
8370         lex_operator, push_back>: New methods.
8371         Update all rules.
8372         (rust_parser::lex_hex, lex_escape): Rename and update.
8373         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
8374         (rust_parser::lex_operator): Rename and update.
8375         (rust_parser::lex_number, rustyylex, rustyyerror)
8376         (rust_lex_test_init, rust_lex_test_sequence)
8377         (rust_lex_test_push_back, rust_lex_tests): Update.
8378         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
8379         parameter.
8380         <lexptr, prev_lexptr>: New members.
8381         (lexptr, prev_lexptr): Don't declare.
8382         * parse.c (lexptr, prev_lexptr): Remove globals.
8383         (parse_exp_in_context): Update.
8384         * p-exp.y (yylex, yyerror): Update.
8385         * m2-exp.y (parse_number, yylex, yyerror): Update.
8386         * go-exp.y (lex_one_token, yyerror): Update.
8387         * f-exp.y (match_string_literal, yylex, yyerror): Update.
8388         * d-exp.y (lex_one_token, yyerror): Update.
8389         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
8390         (lex_one_token, yyerror): Update.
8391         * ada-lex.l (YY_INPUT): Update.
8392         (rewind_to_char): Update.
8393         * ada-exp.y (yyerror): Update.
8394
8395 2019-04-04  Tom Tromey  <tom@tromey.com>
8396
8397         * rust-exp.y (rustyylex, rust_lex_tests): Update.
8398         * parser-defs.h (struct parser_state) <parser_state>: Add new
8399         parameter.
8400         <comma_terminates>: New member.
8401         (comma_terminates): Don't declare global.
8402         * parse.c (comma_terminates): Remove global.
8403         (parse_exp_in_context): Update.
8404         * p-exp.y (yylex): Update.
8405         * m2-exp.y (yylex): Update.
8406         * go-exp.y (lex_one_token): Update.
8407         * f-exp.y (yylex): Update.
8408         * d-exp.y (lex_one_token): Update.
8409         * c-exp.y (lex_one_token): Update.
8410         * ada-lex.l: Update.
8411
8412 2019-04-04  Tom Tromey  <tom@tromey.com>
8413
8414         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
8415         (rustyylex, rust_lex_test_init, rust_lex_test_one)
8416         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
8417         * parser-defs.h (paren_depth): Don't declare.
8418         * parse.c (paren_depth): Remove global.
8419         (parse_exp_in_context): Update.
8420         * p-exp.y (paren_depth): New global.
8421         (pascal_parse): Initialize it.
8422         * m2-exp.y (paren_depth): New global.
8423         (m2_parse): Initialize it.
8424         * go-exp.y (paren_depth): New global.
8425         (go_parse): Initialize it.
8426         * f-exp.y (paren_depth): New global.
8427         (f_parse): Initialize it.
8428         * d-exp.y (paren_depth): New global.
8429         (d_parse): Initialize it.
8430         * c-exp.y (paren_depth): New global.
8431         (c_parse): Initialize it.
8432         * ada-lex.l (paren_depth): New global.
8433         (lexer_init): Initialize it.
8434
8435 2019-04-04  Tom Tromey  <tom@tromey.com>
8436
8437         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
8438         (rust_parser::convert_ast_to_type)
8439         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8440         * parser-defs.h (struct parser_state) <parser_state>: Add
8441         parameters.  Initialize new members.
8442         <expression_context_block, expression_context_pc>: New members.
8443         * parse.c (expression_context_block, expression_context_pc):
8444         Remove globals.
8445         (parse_exp_in_context): Update.
8446         * p-exp.y: Update all rules.
8447         (yylex): Update.
8448         * m2-exp.y: Update all rules.
8449         (yylex): Update.
8450         * go-exp.y (yylex): Update.
8451         * f-exp.y (yylex): Update.
8452         * d-exp.y: Update all rules.
8453         (yylex): Update.
8454         * c-exp.y: Update all rules.
8455         (lex_one_token, classify_name, yylex, c_parse): Update.
8456         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
8457
8458 2019-04-04  Tom Tromey  <tom@tromey.com>
8459
8460         * gdbarch.h, gdbarch.c: Rebuild.
8461         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
8462         * stap-probe.h:
8463         (struct stap_parse_info): Replace "parser_state" with
8464         "expr_builder".
8465         * parser-defs.h (struct expr_builder): Rename from "parser_state".
8466         (parser_state): New class.
8467         * parse.c (expr_builder): Rename.
8468         (expr_builder::release): Rename.
8469         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
8470         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
8471         (write_exp_elt_longcst, write_exp_elt_floatcst)
8472         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
8473         (write_exp_string_vector, write_exp_bitstring)
8474         (write_exp_msymbol, mark_struct_expression)
8475         (write_dollar_variable)
8476         (insert_type_address_space, increase_expout_size): Replace
8477         "parser_state" with "expr_builder".
8478         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
8479         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
8480         "parser_state" with "expr_builder".
8481
8482 2019-04-04  Tom Tromey  <tom@tromey.com>
8483
8484         * rust-exp.y: Replace "parse_language" with method call.
8485         * p-exp.y:
8486         (yylex): Replace "parse_language" with method call.
8487         * m2-exp.y:
8488         (yylex): Replace "parse_language" with method call.
8489         * go-exp.y (classify_name): Replace "parse_language" with method
8490         call.
8491         * f-exp.y (yylex): Replace "parse_language" with method call.
8492         * d-exp.y (lex_one_token): Replace "parse_language" with method
8493         call.
8494         * c-exp.y:
8495         (lex_one_token, classify_name, yylex): Replace "parse_language"
8496         with method call.
8497         * ada-exp.y (find_primitive_type, type_char)
8498         (type_system_address): Replace "parse_language" with method call.
8499
8500 2019-04-04  Tom Tromey  <tom@tromey.com>
8501
8502         * rust-exp.y: Replace "parse_gdbarch" with method call.
8503         * parse.c (write_dollar_variable, insert_type_address_space):
8504         Replace "parse_gdbarch" with method call.
8505         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
8506         call.
8507         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
8508         call.
8509         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
8510         "parse_gdbarch" with method call.
8511         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
8512         with method call.
8513         * f-exp.y (parse_type, parse_f_type, yylex): Replace
8514         "parse_gdbarch" with method call.
8515         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
8516         "parse_gdbarch" with method call.
8517         * c-exp.y (parse_type, parse_number, classify_name): Replace
8518         "parse_gdbarch" with method call.
8519         * ada-lex.l: Replace "parse_gdbarch" with method call.
8520         * ada-exp.y (parse_type, find_primitive_type, type_char)
8521         (type_system_address): Replace "parse_gdbarch" with method call.
8522
8523 2019-04-04  Tom Tromey  <tom@tromey.com>
8524
8525         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
8526         * stap-probe.c (stap_parse_argument): Update.
8527         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
8528         initial_size parameter.
8529         * rust-exp.y (rust_lex_tests): Update.
8530         * parse.c (parser_state): Update.
8531         (parse_exp_in_context): Update.
8532         * parser-defs.h (struct parser_state) <parser_state>: Remove
8533         "initial_size" parameter.
8534
8535 2019-04-04  Tom Tromey  <tom@tromey.com>
8536
8537         * parser-defs.h (increase_expout_size): Don't declare.
8538         * parse.c (increase_expout_size): Now static.
8539
8540 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
8541
8542         * gnu-nat.c (gnu_nat_target::wait): Fix
8543         target_waitstatus_to_string call.
8544
8545 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8546
8547         * eval.c (evaluate_subexp_standard): Handle internal functions
8548         during Fortran function call handling.
8549
8550 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8551
8552         * NEWS: Mention new internal functions.
8553         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
8554         (read_base_type): Use dwarf2_init_complex_target_type.
8555         * value.c (creal_internal_fn): New function.
8556         (cimag_internal_fn): New function.
8557         (_initialize_values): Register new internal functions.
8558
8559 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8560
8561         * infrun.c (stop_all_threads): If debug_infrun, always
8562         trace the wait status after wait_one, using
8563         target_waitstatus_to_string and target_pid_to_str.
8564         (handle_inferior_event): Replace various trace of
8565         wait status kind by a single trace.
8566         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
8567         wait status kind image by target_waitstatus_to_string.
8568         * target/waitstatus.c (target_waitstatus_to_string): Fix
8569         obsolete comment.
8570
8571 2019-04-01  Tom Tromey  <tromey@adacore.com>
8572
8573         PR symtab/23331:
8574         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
8575
8576 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
8577             Pedro Alves  <palves@redhat.com>
8578
8579         * top.c (quit_force): Call 'finalize_values'.
8580         * value.c (finalize_values): New function.
8581         * value.h (finalize_values): Declare.
8582
8583 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
8584
8585         * NEWS: Announce $_gdb_major and $_gdb_minor.
8586
8587         * top.c (init_gdb_version_vars): New function.
8588         (gdb_init): Call init_gdb_version_vars.
8589
8590 2019-03-29  Tom Tromey  <tromey@adacore.com>
8591
8592         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
8593         help text.  Remove dead code.
8594
8595 2019-03-29  Keith Seitz  <keiths@redhat.com>
8596
8597         From Siddhesh Poyarekar:
8598         * f-lang.h (f77_get_upperbound): Return LONGEST.
8599         (f77_get_lowerbound): Likewise.
8600         * f-typeprint.c (f_type_print_varspec_suffix): Expand
8601         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
8602         print them.
8603         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
8604         plongest to format print it.
8605         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
8606         (f77_get_upperbound): Likewise.
8607         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
8608         LOWER_BOUND to LONGEST.
8609         (f77_create_arrayprint_offset_tbl): Likewise.
8610
8611 2019-03-29  Keith Seitz  <keiths@redhat.com>
8612
8613         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
8614         %s/pulongest for TYPE_LENGTH instead of %d in format
8615         strings.
8616         * ada-typerint.c (ada_print_type): Likewise.
8617         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
8618         * compile/compile-c-support.c (generate_register_struct): Likewise.
8619         * gdbtypes.c (recursive_dump_type): Likewise.
8620         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
8621         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
8622         instead of %d in format strings.
8623         * riscv-tdep.c (riscv_type_alignment): Cast second argument
8624         to std::min to ULONGEST.
8625         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
8626         instead of %d in format strings.
8627         * tracepoint.c (info_scope_command): Likewise.
8628         * typeprint.c (print_offset_data::update)
8629         (print_offset_data::finish): Likewise.
8630         * xtensa-tdep.c (xtensa_store_return_value)
8631         (xtensa_push_dummy_call): Likewise.
8632
8633 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
8634
8635         * windows-nat.c (display_selector): Fixed format specifications
8636         for 64-bit Cygwin.
8637
8638 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8639
8640         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
8641
8642 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
8643
8644         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
8645         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
8646         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
8647         (nios2_linux_init_abi): Install it.
8648
8649 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8650
8651         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
8652
8653 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8654
8655         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
8656
8657 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8658             Tom Tromey  <tromey@adacore.com>
8659
8660         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
8661
8662 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
8663
8664         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
8665         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
8666         method to compute the bounds of range types. Also print "[evaluated]"
8667         if the bounds' values come from a dynamic evaluation.
8668
8669 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8670
8671         * cp-valprint.c (cp_print_value_fields): Don't print trailing
8672         whitespace when pretty printing is on.
8673
8674 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8675
8676         * ppc-linux-nat.c: Add include.
8677
8678 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8679
8680         * NEWS: Mention AArch64 Pointer Authentication.
8681
8682 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8683
8684         * arm-linux-nat.c: Add include.
8685
8686 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
8687
8688         * source-cache.c (source_cache::get_source_lines): Re-read
8689         fullname after calling open_source_file.
8690
8691 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
8692
8693         * NEWS: Mention TLS support for FreeBSD.
8694
8695 2019-03-25  Tom Tromey  <tromey@adacore.com>
8696
8697         * minsyms.c (BUNCH_SIZE): Update comment.
8698         (~minimal_symbol_reader): Remove old comment.
8699         (compact_minimal_symbols): Update comment.
8700         (minimal_symbol_reader::install): Remove old comment.  Update
8701         other comments.
8702
8703 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8704
8705         * s390-linux-nat.c: Add include.
8706
8707 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8708
8709         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
8710         Call linux_get_hwcap.
8711         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
8712         Likewise.
8713         (aarch64_linux_get_hwcap): Remove function.
8714         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
8715         declaration.
8716         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
8717         linux_get_hwcap.
8718         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
8719         * linux-tdep.c (linux_get_hwcap): Add function.
8720         (linux_get_hwcap2): Likewise.
8721         * linux-tdep.h (linux_get_hwcap): Add declaration.
8722         (linux_get_hwcap2): Likewise.
8723         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
8724         (ppc_linux_get_hwcap2): Likewise.
8725         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
8726         linux_get_hwcap.
8727         (ppc_linux_nat_target::insert_watchpoint): Likewise.
8728         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
8729         (ppc_linux_nat_target::read_description): Likewise.
8730         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
8731         * s390-linux-nat.c: Likewise.
8732         * s390-linux-tdep.c (s390_core_read_description): Likewise.
8733
8734 2019-03-24  Tom Tromey  <tom@tromey.com>
8735
8736         * ada-lang.c (standard_lookup): Simplify initialization.
8737         (ada_lookup_symbol_nonlocal): Simplify return.
8738         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
8739         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
8740         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
8741         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
8742         initialization.
8743         * solib.c (solib_global_lookup): Simplify.
8744         * symtab.c (null_block_symbol): Remove.
8745         (symbol_cache_lookup): Simplify returns.
8746         (lookup_language_this): Simplify returns.
8747         (lookup_symbol_aux): Simplify return.
8748         (lookup_local_symbol): Simplify returns.
8749         (lookup_global_symbol_from_objfile): Simplify return.
8750         (lookup_symbol_in_objfile_symtabs)
8751         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
8752         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
8753         (lookup_static_symbol, lookup_global_symbol): Simplify return.
8754         * cp-namespace.c (cp_lookup_bare_symbol)
8755         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
8756         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
8757         (cp_lookup_nested_symbol): Don't use null_block_symbol.
8758         (cp_lookup_symbol_via_imports): Simplify initialization.
8759         (find_symbol_in_baseclass): Likewise.
8760         * symtab.h (null_block_symbol): Remove.
8761         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
8762         (d_lookup_nested_symbol, d_lookup_symbol_imports)
8763         (d_lookup_symbol_module): Likewise.
8764         (find_symbol_in_baseclass): Simplify initialization.
8765
8766 2019-03-24  Tom Tromey  <tom@tromey.com>
8767
8768         * expression.h: Don't include symtab.h.
8769         (struct block): Forward declare.
8770
8771 2019-03-24  Tom Tromey  <tom@tromey.com>
8772
8773         * c-exp.y (typebase): Remove casts.
8774         * gdbtypes.c (lookup_unsigned_typename, )
8775         (lookup_signed_typename): Remove cast.
8776         * eval.c (parse_to_comma_and_eval): Remove cast.
8777         * parse.c (write_dollar_variable): Remove cast.
8778         * block.h (struct block) <superblock>: Now const.
8779         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
8780         * psymtab.c (psym_map_matching_symbols): Make "block" const.
8781         (map_block): Make "block" const.
8782         * symfile.h (struct quick_symbol_functions)
8783         <map_matching_symbols>: Constify block argument to "callback".
8784         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
8785         const.
8786         (find_pc_sect_compunit_symtab): Make "b" const.
8787         (find_symbol_at_address): Likewise.
8788         (search_symbols): Likewise.
8789         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
8790         (dw2_debug_names_lookup_symbol): Likewise.
8791         (dw2_map_matching_symbols): Update.
8792         * p-valprint.c (pascal_val_print): Remove "block".
8793         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
8794         (aux_add_nonlocal_symbols): Make "block" const.
8795         (resolve_subexp): Remove cast.
8796         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
8797         const.
8798         (iterate_over_file_blocks): Likewise.
8799         * f-exp.y (%union) <bval>: Remove.
8800         * coffread.c (patch_opaque_types): Make "b" const.
8801         * spu-tdep.c (spu_catch_start): Make "block" const.
8802         * c-valprint.c (print_unpacked_pointer): Remove "block".
8803         * symmisc.c (dump_symtab_1): Make "b" const.
8804         (block_depth): Make "block" const.
8805         * d-exp.y (%union) <bval>: Remove.
8806         * cp-support.h (cp_lookup_rtti_type): Update.
8807         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
8808         * psymtab.c (psym_lookup_symbol): Make "block" const.
8809         (maintenance_check_psymtabs): Make "b" const.
8810         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
8811         (enumerate_locals, enumerate_args): Update.
8812         * python/py-symtab.c (stpy_global_block): Make "block" const.
8813         (stpy_static_block): Likewise.
8814         * inline-frame.c (block_starting_point_at): Make "new_block"
8815         const.
8816         * block.c (find_block_in_blockvector): Make return type const.
8817         (blockvector_for_pc_sect): Make "b" const.
8818         (find_block_in_blockvector): Make "b" const.
8819
8820 2019-03-23  Tom Tromey  <tom@tromey.com>
8821
8822         * varobj.c (varobj_create): Update.
8823         * symfile.c (clear_symtab_users): Don't reset innermost_block.
8824         * printcmd.c (display_command, do_one_display): Don't reset
8825         innermost_block.
8826         * parser-defs.h (enum innermost_block_tracker_type): Move to
8827         expression.h.
8828         (innermost_block): Update comment.
8829         * parse.c (parse_exp_1): Add tracker_types parameter.
8830         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
8831         tracker_types parameter.  Reset innermost_block.
8832         (parse_exp_in_context): Remove.
8833         (parse_expression_for_completion): Update.
8834         * objfiles.c (~objfile): Don't reset expression_context_block or
8835         innermost_block.
8836         * expression.h (enum innermost_block_tracker_type): Move from
8837         parser-defs.h.
8838         (parse_exp_1): Add tracker_types parameter.
8839         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
8840         reset innermost_block.
8841
8842 2019-03-23  Tom Tromey  <tom@tromey.com>
8843
8844         * objfiles.h: Include bcache.h.
8845
8846 2019-03-23  Tom Tromey  <tom@tromey.com>
8847
8848         * linespec.c (get_current_search_block): Use
8849         scoped_restore_current_language.
8850         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
8851
8852 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8853             Jiong Wang  <jiong.wang@arm.com>
8854
8855         * aarch64-linux-tdep.c
8856         (aarch64_linux_iterate_over_regset_sections): Check for pauth
8857         section.
8858         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
8859
8860 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8861             Jiong Wang  <jiong.wang@arm.com>
8862
8863         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
8864         instructions.
8865         (aarch64_analyze_prologue_test): Add PACIASP test.
8866         (aarch64_prologue_prev_register): Unmask PC value.
8867
8868 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8869             Jiong Wang  <jiong.wang@arm.com>
8870
8871         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
8872         (aarch64_dwarf2_prev_register): Unmask PC value.
8873         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
8874         (aarch64_execute_dwarf_cfa_vendor_op): Check for
8875         DW_CFA_AARCH64_negate_ra_state.
8876         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
8877
8878 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8879             Jiong Wang  <jiong.wang@arm.com>
8880
8881         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
8882         registers.
8883         (aarch64_pseudo_register_name): Likewise.
8884         (aarch64_pseudo_register_type): Likewise.
8885         (aarch64_pseudo_register_reggroup_p): Likewise.
8886         (aarch64_gdbarch_init): Add pauth registers.
8887         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
8888         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
8889         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
8890         (struct gdbarch_tdep): Add regnum for ra_state.
8891
8892 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8893             Jiong Wang  <jiong.wang@arm.com>
8894
8895         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
8896
8897 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8898             Jiong Wang  <jiong.wang@arm.com>
8899
8900         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
8901         function.
8902         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
8903         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
8904         (aarch64_gdbarch_init): Add puth registers.
8905         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
8906         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
8907         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
8908
8909 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8910             Jiong Wang  <jiong.wang@arm.com>
8911
8912         * aarch64-linux-nat.c
8913         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
8914         * aarch64-linux-tdep.c
8915         (aarch64_linux_core_read_description): Likewise.
8916         (aarch64_linux_get_hwcap): New function.
8917         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
8918         (aarch64_linux_get_hwcap): New declaration.
8919
8920 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8921             Jiong Wang  <jiong.wang@arm.com>
8922
8923         * aarch64-linux-nat.c
8924         (aarch64_linux_nat_target::read_description): Add pauth param.
8925         * aarch64-linux-tdep.c
8926         (aarch64_linux_core_read_description): Likewise.
8927         * aarch64-tdep.c (struct target_desc): Add in pauth.
8928         (aarch64_read_description): Add pauth param.
8929         (aarch64_gdbarch_init): Likewise.
8930         * aarch64-tdep.h (aarch64_read_description): Likewise.
8931         * arch/aarch64.c (aarch64_create_target_description): Likewise.
8932         * arch/aarch64.h (aarch64_create_target_description): Likewise.
8933         * features/Makefile: Add new files.
8934         * features/aarch64-pauth.c: New file.
8935         * features/aarch64-pauth.xml: New file.
8936
8937 2019-03-20  Tom Tromey  <tromey@adacore.com>
8938
8939         * infrun.c (handle_inferior_event): Rename from
8940         handle_inferior_event_1.  Create a scoped_value_mark.
8941         (handle_inferior_event): Remove.
8942
8943 2019-03-19  Tom Tromey  <tromey@adacore.com>
8944
8945         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
8946         * infrun.h (print_stop_event): Add "displays" parameter.
8947         * infrun.c (print_stop_event): Add "displays" parameter.
8948
8949 2019-03-19  Pedro Alves  <palves@redhat.com>
8950
8951         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8952         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
8953         to -1.  Fix TABs vs spaces.
8954         (tui_ui_out::tui_ui_out): Don't initialize fields here.
8955         * tui/tui-out.h (tui_ui_out) Add intro comments.
8956         <m_line, m_start_of_line>: In-class initialize, and add describing
8957         comment.
8958
8959 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
8960
8961         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8962         variable names.
8963         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8964
8965 2019-03-18  Pedro Alves  <palves@redhat.com>
8966             Eli Zaretskii <eliz@gnu.org>
8967
8968         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8969         m_line and m_start_of_line.
8970
8971 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
8972
8973         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8974         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8975         it returns a newline.  This fixes a regression in TU mode, whereby
8976         the next line is output on the same screen line as the user input.
8977
8978 2019-03-18  Tom Tromey  <tromey@adacore.com>
8979
8980         * minsyms.c (minimal_symbol_reader::install): Remove call to
8981         obstack_blank.
8982
8983 2019-03-18  Pedro Alves  <palves@redhat.com>
8984
8985         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8986         New globals.
8987         (apply_style): New, factored out from ...
8988         (apply_ansi_escape): ... this.  Handle reverse video mode.
8989         (tui_set_reverse_mode): New function.
8990         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8991         * tui/tui-winsource.c (tui_show_source_line): Use
8992         tui_set_reverse_mode instead of setting A_STANDOUT.
8993         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8994         New setter methods.
8995
8996 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
8997
8998         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8999         Handle tabs.
9000
9001 2019-03-18  Tom Tromey  <tromey@adacore.com>
9002
9003         * ada-lang.c (empty_array): Add "high" parameter.
9004         (ada_evaluate_subexp): Update.
9005
9006 2019-03-17  Sergei Trofimovich <siarheit@google.com>
9007
9008         * unittests/string_view-selftests.c: Define
9009         _initialize_string_view_selftests unconditionally.
9010
9011 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9012
9013         PR gdb/24350
9014         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
9015
9016 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9017
9018         PR gdb/24351
9019         * windows-nat.c (display_selector): Fix format specifiers.
9020
9021 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
9022
9023         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
9024         tui_refill_source_window instead of tui_refresh_win, to update the
9025         current execution line.  This fixes redisplay of the current line
9026         when stepping through the code with "next" or "step".
9027
9028 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9029
9030         * source-cache.c (source_cache::get_source_lines): Call
9031         find_source_lines to initialize s->nlines.  This fixes vertical
9032         scrolling of TUI source window when the DOWN arrow is pressed.
9033
9034 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9035
9036         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
9037         linux-thread-db.c (_initialize_thread_db): Likewise.
9038
9039 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9040
9041         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
9042         wclrtoeol in tui_show_source_line".  This reverts changes made in
9043         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
9044
9045 2019-03-15  Tom Tromey  <tom@tromey.com>
9046
9047         * symtab.h (struct minimal_symbol): Derive from
9048         general_symbol_info.
9049         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
9050         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
9051         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
9052         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
9053         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
9054         (MSYMBOL_SEARCH_NAME): Update.
9055         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
9056         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
9057         * minsyms.c (minimal_symbol_reader::record_full): Update.
9058
9059 2019-03-15  Tom Tromey  <tom@tromey.com>
9060
9061         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
9062
9063 2019-03-15  Tom Tromey  <tom@tromey.com>
9064
9065         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
9066         unique_xmalloc_ptr.
9067         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
9068         Update.
9069         * minsyms.c (lookup_minimal_symbol_by_pc_section)
9070         (build_minimal_symbol_hash_tables)
9071         (minimal_symbol_reader::install): Update.
9072
9073 2019-03-15  Tom Tromey  <tom@tromey.com>
9074
9075         * symtab.c (create_demangled_names_hash): Update.
9076         (symbol_set_names): Update.
9077         * objfiles.h (struct objfile_per_bfd_storage)
9078         <demangled_names_hash>: Now an htab_up.
9079         * objfiles.c (objfile_per_bfd_storage): Simplify.
9080
9081 2019-03-15  Tom Tromey  <tom@tromey.com>
9082
9083         * objfiles.h (struct objfile_per_bfd_storage): Declare
9084         destructor.
9085         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
9086         New.
9087         (get_objfile_bfd_data): Use new.  Don't initialize
9088         language_of_main.
9089         (free_objfile_per_bfd_storage): Remove.
9090         (objfile_bfd_data_free, objfile::~objfile): Use delete.
9091
9092 2019-03-15  Tom Tromey  <tom@tromey.com>
9093
9094         * symfile.c (reread_symbols): Update.
9095         * objfiles.c (objfile::objfile): Update.
9096         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
9097         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
9098         comment.
9099         (minimal_symbol_reader::install): Update.
9100         (terminate_minimal_symbol_table): Remove.
9101         * jit.c (jit_object_close_impl): Update.
9102
9103 2019-03-15  Tom Tromey  <tom@tromey.com>
9104
9105         * minsyms.c (minimal_symbol_reader::record_full): Remove some
9106         initializations.
9107
9108 2019-03-15  Tom Tromey  <tom@tromey.com>
9109
9110         * objfiles.h (struct objfile_per_bfd_storage)
9111         <demangled_hash_languages>: Now a bitset.
9112         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
9113         (lookup_minimal_symbol): Update.
9114
9115 2019-03-15  Tom Tromey  <tom@tromey.com>
9116
9117         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
9118         Don't return the symbol.
9119         * coffread.c (record_minimal_symbol): Use record_full.
9120
9121 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
9122
9123         The MS-Windows port of ncurses fails to switch to a color pair if
9124         one or both of the colors are the implicit default colors.  This
9125         change records the default colors when TUI is initialized, and
9126         then specifies them explicitly when a color pair uses the default
9127         colors.  This allows color styling in TUI mode on MS-Windows.
9128
9129         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
9130         ncurses_norm_attr.
9131         (tui_initialize_io) [__MINGW32__]: Record the default terminal
9132         colors in ncurses_norm_attr.
9133         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
9134         "none", replace it with the default color recorded in
9135         ncurses_norm_attr.
9136
9137 2019-03-14  Tom Tromey  <tromey@adacore.com>
9138
9139         * source-cache.h (class source_cache) <get_source_lines>: Return
9140         std::string.
9141         * source-cache.c (source_cache::extract_lines): Handle case where
9142         first_pos==npos.  Return std::string.
9143         (source_cache::get_source_lines): Update.
9144
9145 2019-03-14  Tom Tromey  <tromey@adacore.com>
9146
9147         * NEWS: Add item for "style sources" commands.
9148         * source-cache.c (source_cache::get_source_lines): Check
9149         source_styling.
9150         * cli/cli-style.c (source_styling): New global.
9151         (_initialize_cli_style): Add "style sources" commands.
9152         (show_style_sources): New function.
9153         * cli/cli-style.h (source_styling): Declare.
9154
9155 2019-03-14  Pedro Alves  <palves@redhat.com>
9156             Tom Tromey  <tromey@adacore.com>
9157
9158         * tui/tui-winsource.h (tui_refill_source_window): Declare.
9159         * tui/tui-winsource.c (tui_refill_source_window): New function,
9160         from...
9161         (tui_horizontal_source_scroll): ... here.  Move some logic.
9162         * cli/cli-style.c (set_style_enabled): Notify new observable.
9163         * tui/tui-hooks.c (tui_redisplay_source): New function.
9164         (tui_attach_detach_observers): Attach or detach
9165         tui_redisplay_source.
9166         * observable.h (source_styling_changed): New observable.
9167         * observable.c: Define source_styling_changed observable.
9168
9169 2019-03-13  Tom Tromey  <tromey@adacore.com>
9170
9171         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
9172         (i386_gnu_nat_target::store_registers): Update.
9173         * target-debug.h (target_debug_print_std_string): New macro.
9174         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9175         * windows-tdep.c (display_one_tib): Update.
9176         * tui/tui-stack.c (tui_make_status_line): Update.
9177         * top.c (print_inferior_quit_action): Update.
9178         * thread.c (thr_try_catch_cmd): Update.
9179         (add_thread_with_info): Update.
9180         (thread_target_id_str): Update.
9181         (thr_try_catch_cmd): Update.
9182         (thread_command): Update.
9183         (thread_find_command): Update.
9184         * record-btrace.c (record_btrace_target::info_record)
9185         (record_btrace_resume_thread, record_btrace_target::resume)
9186         (record_btrace_cancel_resume, record_btrace_step_thread)
9187         (record_btrace_target::wait, record_btrace_target::wait)
9188         (record_btrace_target::wait, record_btrace_target::stop): Update.
9189         * progspace.c (print_program_space): Update.
9190         * process-stratum-target.c
9191         (process_stratum_target::thread_address_space): Update.
9192         * linux-fork.c (linux_fork_mourn_inferior)
9193         (detach_checkpoint_command, info_checkpoints_command)
9194         (linux_fork_context): Update.
9195         (linux_fork_detach): Update.
9196         (class scoped_switch_fork_info): Update.
9197         (delete_checkpoint_command): Update.
9198         * infrun.c (follow_fork_inferior): Update.
9199         (follow_fork_inferior): Update.
9200         (proceed_after_vfork_done): Update.
9201         (handle_vfork_child_exec_or_exit): Update.
9202         (follow_exec): Update.
9203         (displaced_step_prepare_throw): Update.
9204         (displaced_step_restore): Update.
9205         (start_step_over): Update.
9206         (resume_1): Update.
9207         (clear_proceed_status_thread): Update.
9208         (proceed): Update.
9209         (print_target_wait_results): Update.
9210         (do_target_wait): Update.
9211         (context_switch): Update.
9212         (stop_all_threads): Update.
9213         (restart_threads): Update.
9214         (finish_step_over): Update.
9215         (handle_signal_stop): Update.
9216         (switch_back_to_stepped_thread): Update.
9217         (keep_going_pass_signal): Update.
9218         (print_exited_reason): Update.
9219         (normal_stop): Update.
9220         * inferior.c (inferior_pid_to_str): Change return type.
9221         (print_selected_inferior): Update.
9222         (add_inferior): Update.
9223         (detach_inferior): Update.
9224         * dummy-frame.c (fprint_dummy_frames): Update.
9225         * dcache.c (dcache_info_1): Update.
9226         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
9227         (btrace_fetch, btrace_clear): Update.
9228         * linux-tdep.c (linux_core_pid_to_str): Change return type.
9229         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
9230         type.
9231         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
9232         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
9233         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
9234         * gdbarch.c, gdbarch.h: Rebuild.
9235         * gdbarch.sh (core_pid_to_str): Change return type.
9236         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
9237         return type.
9238         (windows_nat_target::pid_to_str): Change return type.
9239         (windows_delete_thread): Update.
9240         (windows_nat_target::attach): Update.
9241         (windows_nat_target::files_info): Update.
9242         * target-delegates.c: Rebuild.
9243         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
9244         return type.
9245         (sol_thread_target::pid_to_str): Change return type.
9246         * remote.c (class remote_target) <pid_to_str>: Change return
9247         type.
9248         (remote_target::pid_to_str): Change return type.
9249         (extended_remote_target::attach, remote_target::remote_stop_ns)
9250         (remote_target::remote_notif_remove_queued_reply)
9251         (remote_target::push_stop_reply, remote_target::disable_btrace):
9252         Update.
9253         (extended_remote_target::attach): Update.
9254         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
9255         type.
9256         (gdbsim_target::pid_to_str): Change return type.
9257         * ravenscar-thread.c (struct ravenscar_thread_target)
9258         <pid_to_str>: Change return type.
9259         (ravenscar_thread_target::pid_to_str): Change return type.
9260         * procfs.c (class procfs_target) <pid_to_str>: Change return
9261         type.
9262         (procfs_target::pid_to_str): Change return type.
9263         (procfs_target::attach): Update.
9264         (procfs_target::detach): Update.
9265         (procfs_target::fetch_registers): Update.
9266         (procfs_target::store_registers): Update.
9267         (procfs_target::wait): Update.
9268         (procfs_target::files_info): Update.
9269         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
9270         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
9271         return type.
9272         (nto_procfs_target::pid_to_str): Change return type.
9273         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
9274         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
9275         return type.
9276         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
9277         (exit_lwp): Update.
9278         (attach_proc_task_lwp_callback, get_detach_signal)
9279         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
9280         (linux_nat_target::resume, wait_lwp, stop_callback)
9281         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
9282         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
9283         (linux_nat_wait_1, resume_stopped_resumed_lwps)
9284         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
9285         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
9286         type.
9287         (inf_ptrace_target::attach): Update.
9288         (inf_ptrace_target::files_info): Update.
9289         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
9290         type.
9291         (go32_nat_target::pid_to_str): Change return type.
9292         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
9293         (gnu_nat_target::wait): Update.
9294         (gnu_nat_target::wait): Update.
9295         (gnu_nat_target::resume): Update.
9296         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
9297         (fbsd_nat_target::wait): Update.
9298         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
9299         type.
9300         (darwin_nat_target::attach): Update.
9301         * corelow.c (class core_target) <pid_to_str>: Change return type.
9302         (core_target::pid_to_str): Change return type.
9303         * target.c (normal_pid_to_str): Change return type.
9304         (default_pid_to_str): Likewise.
9305         (target_pid_to_str): Change return type.
9306         (target_translate_tls_address): Update.
9307         (target_announce_detach): Update.
9308         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
9309         return type.
9310         (bsd_uthread_target::pid_to_str): Change return type.
9311         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
9312         type.
9313         (bsd_kvm_target::pid_to_str): Change return type.
9314         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
9315         return type.
9316         (aix_thread_target::pid_to_str): Change return type.
9317         * target.h (struct target_ops) <pid_to_str>: Change return type.
9318         (target_pid_to_str, normal_pid_to_str): Likewise.
9319         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
9320         type.
9321         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
9322         type.
9323         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
9324         return type.
9325         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
9326         type.
9327         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
9328         type.
9329         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
9330         return type.
9331
9332 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
9333
9334         * NEWS: Mention that the new default MI version is 3.  Mention
9335         changes to the output of commands and events that deal with
9336         multi-location breakpoints.
9337         * breakpoint.c: Include "mi/mi-out.h".
9338         (print_one_breakpoint): Change output syntax if using MI version
9339         >= 3.
9340         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
9341         New.
9342         (mi_multi_location_breakpoint_output_fixed): New.
9343         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
9344         (mi_cmd_fix_multi_location_breakpoint_output): New.
9345         (mi_multi_location_breakpoint_output_fixed): New.
9346         * mi/mi-cmds.c (mi_cmds): Register command
9347         -fix-multi-location-breakpoint-output.
9348         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
9349         interpreter "mi".
9350
9351 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
9352
9353         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
9354         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
9355         instantiate mi_ui_out based on interpreter name.
9356         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
9357         * mi/mi-main.c (mi_load_progress): Likewise.
9358
9359 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9360
9361         * NEWS: Combine separate "New targets" sections for 8.3.
9362
9363 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9364
9365         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
9366         (ppcfbsd_init_abi): Install gdbarch
9367         "fetch_tls_load_module_address" and "get_thread_local_address"
9368         methods.
9369
9370 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9371
9372         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
9373         (riscv_fbsd_init_abi): Install gdbarch
9374         "fetch_tls_load_module_address" and "get_thread_local_address"
9375         methods.
9376
9377 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9378
9379         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
9380         (i386fbsd_init_abi): Install gdbarch
9381         "fetch_tls_load_module_address" and "get_thread_local_address"
9382         methods.
9383
9384 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9385
9386         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
9387         (amd64fbsd_init_abi): Install gdbarch
9388         "fetch_tls_load_module_address" and "get_thread_local_address"
9389         methods.
9390
9391 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9392
9393         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
9394         (struct fbsd_pspace_data): New type.
9395         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
9396         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
9397         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
9398         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
9399         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
9400
9401 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9402
9403         * gdbtypes.c (lookup_struct_elt): New function.
9404         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
9405         * gdbtypes.h (struct struct_elt): New type.
9406         (lookup_struct_elt): New prototype.
9407
9408 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9409
9410         * gdbtypes.c (lookup_struct_elt_type): Update comment and
9411         remove disabled code block.
9412
9413 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9414
9415         * gdbarch.sh (get_thread_local_address): New method.
9416         * gdbarch.h, gdbarch.c: Regenerate.
9417         * target.c (target_translate_tls_address): Use
9418         gdbarch_get_thread_local_address if present instead of
9419         target::get_thread_local_address.
9420
9421 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9422
9423         * target.h (target::get_thread_local_address): Update comment.
9424
9425 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9426
9427         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
9428         objfile->separate_debug_objfile_backlink if not NULL.
9429
9430 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9431
9432         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
9433         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
9434         (amd64bsd_store_inferior_registers): Likewise.
9435         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9436         Enable segment base registers.
9437         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
9438         PT_GETFSBASE and PT_GETGSBASE.
9439         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
9440         PT_SETGSBASE.
9441         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
9442         segment base registers.
9443         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9444
9445 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9446
9447         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9448         Update calls to i386_target_description to add 'segments'
9449         parameter.
9450         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
9451         add segment base registers.
9452         * arch/i386.c (i386_create_target_description): Add 'segments'
9453         parameter to enable segment base registers.
9454         * arch/i386.h (i386_create_target_description): Likewise.
9455         * features/i386/32bit-segments.xml: New file.
9456         * features/i386/32bit-segments.c: Generate.
9457         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
9458         call to i386_target_description to add 'segments' parameter.
9459         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9460         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
9461         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
9462         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
9463         if feature is present.
9464         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
9465         Add 'segments' parameter to call to i386_target_description.
9466         (i386_target_description): Add 'segments' parameter to enable
9467         segment base registers.
9468         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
9469         to call to i386_target_description.
9470         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
9471         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
9472         Define I386_NUM_REGS.
9473         (i386_target_description): Add 'segments' parameter to enable
9474         segment base registers.
9475
9476 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
9477
9478         PR/24325
9479         * source-cache.c: #undef open and close, to avoid unresolved
9480         externals during linking.
9481
9482 2019-03-12  Tom Tromey  <tromey@adacore.com>
9483
9484         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
9485         const.  Add initializers.
9486         (_initialize_remote): Don't initialize ptid globals.
9487
9488 2019-03-12  Pedro Alves  <palves@redhat.com>
9489
9490         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
9491
9492 2019-03-12  Pedro Alves  <palves@redhat.com>
9493
9494         * cp-name-parser.y (main): Remove unused 'len' variable.
9495
9496 2019-03-12  Tom Tromey  <tromey@adacore.com>
9497
9498         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
9499         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
9500
9501 2019-03-12  Tom Tromey  <tromey@adacore.com>
9502
9503         * linux-nat.c (iterate_over_lwps): Update.
9504         (stop_callback): Remove parameter.
9505         (stop_wait_callback, detach_callback, resume_set_callback)
9506         (select_singlestep_lwp_callback, set_ignore_sigint)
9507         (status_callback, resumed_callback, resume_clear_callback)
9508         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
9509         data parameter.
9510         (linux_nat_target::detach, linux_nat_target::resume)
9511         (linux_stop_and_wait_all_lwps, select_event_lwp)
9512         (linux_nat_filter_event, linux_nat_wait_1)
9513         (linux_nat_target::kill, linux_nat_target::stop)
9514         (linux_nat_target::stop): Update.
9515         (linux_nat_resume_callback): Change type.
9516         (resume_stopped_resumed_lwps, count_events_callback)
9517         (select_event_lwp_callback): Likewise.
9518         (linux_stop_lwp, linux_nat_stop_lwp): Update.
9519         * arm-linux-nat.c (struct update_registers_data): Remove.
9520         (update_registers_callback): Change type.
9521         (arm_linux_insert_hw_breakpoint1): Update.
9522         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
9523         parameter.
9524         (x86_linux_dr_set_addr): Update.
9525         (x86_linux_dr_set_control): Update.
9526         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
9527         (iterate_over_lwps): Use gdb::function_view.
9528         * nat/aarch64-linux-hw-point.c (struct
9529         aarch64_dr_update_callback_param): Remove.
9530         (debug_reg_change_callback): Change type.
9531         (aarch64_notify_debug_reg_change): Update.
9532         * s390-linux-nat.c (s390_refresh_per_info): Update.
9533
9534 2019-03-11  Tom Tromey  <tromey@adacore.com>
9535
9536         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
9537         redundant assignment to "this_cu".
9538
9539 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9540
9541         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
9542
9543 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9544
9545         * gdbtypes.c (rank_one_type_parm_set): New function extracted
9546         from...
9547         (rank_one_type): ... this.
9548
9549 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9550
9551         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
9552         from...
9553         (rank_one_type): ... this.
9554
9555 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9556
9557         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
9558         from...
9559         (rank_one_type): ... this.
9560
9561 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9562
9563         * gdbtypes.c (rank_one_type_parm_float): New function extracted
9564         from...
9565         (rank_one_type): ... this.
9566
9567 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9568
9569         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
9570         from...
9571         (rank_one_type): ... this.
9572
9573 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9574
9575         * gdbtypes.c (rank_one_type_parm_range): New function extracted
9576         from...
9577         (rank_one_type): ... this.
9578
9579 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9580
9581         * gdbtypes.c (rank_one_type_parm_char): New function extracted
9582         from...
9583         (rank_one_type): ... this.
9584
9585 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9586
9587         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
9588         from...
9589         (rank_one_type): ... this.
9590
9591 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9592
9593         * gdbtypes.c (rank_one_type_parm_int): New function extracted
9594         from...
9595         (rank_one_type): ... this.
9596
9597 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9598
9599         * gdbtypes.c (rank_one_type_parm_func): New function extracted
9600         from...
9601         (rank_one_type): ... this.
9602
9603 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9604
9605         * gdbtypes.c (rank_one_type_parm_array): New function extracted
9606         from...
9607         (rank_one_type): ... this.
9608
9609 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9610
9611         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
9612         from...
9613         (rank_one_type): ... this.
9614
9615 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9616
9617         * inferior.c (initialize_inferiors): Ensure 'help set/show print
9618         inferior-events' shows the example events.
9619
9620 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
9621
9622         Support styling on native MS-Windows console
9623
9624         PR/24315
9625         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
9626         on MS-Windows if $TERM is not defined.
9627
9628         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
9629
9630         * posix-hdep.c (gdb_console_fputs):
9631         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
9632         functions.
9633         * ui-file.h (gdb_console_fputs): Add prototype.
9634
9635         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
9636         back to fputs only if the former returns zero.
9637
9638 2019-03-07  Tom Tromey  <tom@tromey.com>
9639
9640         * symmisc.c (print_symbol_bcache_statistics): Update.
9641         (print_objfile_statistics): Update.
9642         * symfile.c (allocate_symtab): Update.
9643         * stabsread.c: Don't include bcache.h.
9644         * psymtab.h (struct psymbol_bcache): Don't declare.
9645         (class psymtab_storage) <psymbol_cache>: Now a bcache.
9646         (psymbol_bcache_init, psymbol_bcache_free)
9647         (psymbol_bcache_get_bcache): Don't declare.
9648         * psymtab.c (struct psymbol_bcache): Remove.
9649         (psymtab_storage::psymtab_storage): Update.
9650         (psymtab_storage::~psymtab_storage): Update.
9651         (psymbol_bcache_init, psymbol_bcache_free)
9652         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
9653         (add_psymbol_to_bcache): Update.
9654         (allocate_psymtab): Update.
9655         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
9656         macro_cache>: No longer pointers.
9657         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
9658         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
9659         * macrotab.c (macro_bcache): Update.
9660         * macroexp.c: Don't include bcache.h.
9661         * gdbtypes.c (check_types_worklist): Update.
9662         (types_deeply_equal): Remove TRY/CATCH.  Update.
9663         * elfread.c (elf_symtab_read): Update.
9664         * dwarf2read.c: Don't include bcache.h.
9665         * buildsym.c (buildsym_compunit::get_macro_table): Update.
9666         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
9667         (print_bcache_statistics, bcache_memory_used): Don't declare.
9668         (struct bcache): Move from bcache.c.  Add constructor, destructor,
9669         methods.  Rename all data members.
9670         * bcache.c (struct bcache): Move to bcache.h.
9671         (bcache::expand_hash_table): Rename from expand_hash_table.
9672         (bcache): Remove.
9673         (bcache::insert): Rename from bcache_full.
9674         (bcache::compare): Rename from bcache_compare.
9675         (bcache_xmalloc): Remove.
9676         (bcache::~bcache): Rename from bcache_xfree.
9677         (bcache::print_statistics): Rename from print_bcache_statistics.
9678         (bcache::memory_used): Rename from bcache_memory_used.
9679
9680 2019-03-07  Pedro Alves  <palves@redhat.com>
9681
9682         * infrun.c (normal_stop): Also check for
9683         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
9684
9685 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
9686
9687         * f-lang.c (value_from_host_double): Moved to...
9688         * value.c (value_from_host_double): ...here.
9689         * value.h (value_from_host_double): Declare.
9690         * guile/scm-math.c (vlscm_convert_typed_number): Use
9691         value_from_host_double.
9692         (vlscm_convert_number): Likewise.
9693         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
9694         * python/py-value.c (convert_value_from_python): Likewise.
9695
9696 2019-03-06  Tom Tromey  <tom@tromey.com>
9697
9698         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
9699
9700 2019-03-06  Tom Tromey  <tom@tromey.com>
9701
9702         * utils.h (free_current_contents): Don't declare.
9703         * utils.c (free_current_contents): Remove.
9704
9705 2019-03-06  Tom Tromey  <tom@tromey.com>
9706
9707         * top.c (quit_force): Update.
9708         * main.c (captured_command_loop): Update.
9709         * common/new-op.c (operator new): Update.
9710         * common/common-exceptions.c (struct catcher)
9711         <save_cleanup_chain>: Remove member.
9712         (exceptions_state_mc_init): Update.
9713         (exception_try_scope_entry): Return nullptr.
9714         (exception_try_scope_exit, exception_rethrow)
9715         (throw_exception_sjlj, throw_exception_cxx): Update.
9716         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
9717         (all_cleanups, do_cleanups, discard_cleanups)
9718         (discard_final_cleanups, save_cleanups, save_final_cleanups)
9719         (restore_cleanups, restore_final_cleanups): Don't declare.
9720         (do_final_cleanups): Remove parameter.
9721         * common/cleanups.c (cleanup_chain, make_cleanup)
9722         (make_cleanup_dtor, all_cleanups, do_cleanups)
9723         (discard_my_cleanups, discard_cleanups)
9724         (discard_final_cleanups, save_my_cleanups, save_cleanups)
9725         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
9726         (null_cleanup): Remove.
9727         (do_final_cleanups): Remove parameter.
9728
9729 2019-03-06  Tom Tromey  <tom@tromey.com>
9730
9731         * remote.c (remote_target::remote_parse_stop_reply): Use
9732         unique_xmalloc_ptr.
9733
9734 2019-03-06  Tom Tromey  <tom@tromey.com>
9735
9736         * stabsread.c (struct stabs_field_info): Rename from field_info.
9737         <list, fnlist>: Add initializers.
9738         <obstack>: New member.
9739         (read_member_functions, read_struct_fields, read_baseclasses):
9740         Allocate on obstack.  Don't use cleanups.
9741         (read_one_struct_field, read_member_functions, read_struct_fields)
9742         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
9743         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
9744         (read_struct_type): Update.
9745
9746 2019-03-06  Tom Tromey  <tom@tromey.com>
9747
9748         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
9749         * common/filestuff.h (make_cleanup_close): Don't declare.
9750         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
9751         Remove.
9752
9753 2019-03-06  Tom Tromey  <tom@tromey.com>
9754
9755         * solib-aix.c: Use make_scope_exit.
9756
9757 2019-03-06  Tom Tromey  <tom@tromey.com>
9758
9759         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
9760         Use make_scope_exit.
9761
9762 2019-03-06  Tom Tromey  <tom@tromey.com>
9763
9764         * solib-svr4.c (disable_probes_interface): Remove parameter.
9765         (svr4_handle_solib_event): Use make_scope_exit.
9766
9767 2019-03-06  Tom Tromey  <tom@tromey.com>
9768
9769         * remote.c (struct stop_reply_deleter): Remove.
9770         (stop_reply_up): Update.
9771         (struct stop_reply): Derive from notif_event.  Don't typedef.
9772         <regcache>: Now a std::vector.
9773         (stop_reply_xfree): Remove.
9774         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
9775         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
9776         (remote_target::discard_pending_stop_replies): Use delete.
9777         (remote_target::remote_parse_stop_reply): Update.
9778         (remote_target::process_stop_reply): Update.
9779         * remote-notif.h (struct notif_event): Add virtual destructor.
9780         Remove "dtr" member.
9781         (struct notif_client) <alloc_event>: Return a unique_ptr.
9782         (notif_event_xfree): Don't declare.
9783         (notif_event_up): New typedef.
9784         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
9785         (notif_event_xfree, do_notif_event_xfree): Remove.
9786         (remote_notif_state_xfree): Update.
9787
9788 2019-03-06  Tom Tromey  <tom@tromey.com>
9789
9790         * infrun.c (displaced_step_clear_cleanup): Now a
9791         forward_scope_exit type.
9792         (displaced_step_prepare_throw): Update.
9793         (displaced_step_fixup): Update.
9794
9795 2019-03-06  Tom Tromey  <tom@tromey.com>
9796
9797         * inferior.h (class inferior): Update comment.
9798         * gdbthread.h (class thread_info): Update comment.
9799
9800 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
9801             Tom Tromey  <tom@tromey.com>
9802
9803         * stabsread.h (struct stab_section_list): Remove.
9804         (coffstab_build_psymtabs): Update.
9805         * dbxread.c (symbuf_sections): Now a std::vector.
9806         (sect_idx): New global.
9807         (fill_symbuf): Update.
9808         (coffstab_build_psymtabs): Change type of stabsects parameter.
9809         Update.
9810         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
9811         std::vector.
9812         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
9813         (coff_locate_sections): Update.
9814         (coff_symfile_read): Remove cleanups.  Update.
9815         (init_stringtab): Add storage parameter.
9816         (free_stringtab, free_stringtab_cleanup): Remove.
9817         (init_lineno): Add storage parameter.
9818         (free_linetab, free_linetab_cleanup): Remove.
9819
9820 2019-03-06  Pedro Alves  <palves@redhat.com>
9821
9822         * linux-fork.c (fork_info::clobber_regs): Delete.
9823         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
9824         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
9825         comment.  Adjust.
9826         (scoped_switch_fork_info::scoped_switch_fork_info)
9827         (checkpoint_command, linux_fork_context): Adjust
9828         fork_save_infrun_state calls.
9829
9830 2019-03-06  Pedro Alves  <palves@redhat.com>
9831
9832         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
9833         (inf_has_multiple_threads): Return 'bool' and rewrite using
9834         inferior_info::threads().
9835
9836 2019-03-06  Pedro Alves  <palves@redhat.com>
9837
9838         * linux-fork.c: Include <list>.
9839         (fork_list): Now a std::list instance.
9840         (fork_info): Add ctor, dtor, and in-class initialize all fields.
9841         (forks_exist_p, find_last_fork): Adjust.
9842         (new_fork): Delete.
9843         (one_fork_p): New.
9844         (add_fork): Adjust.
9845         (free_fork): Delete, folded into fork_info::~fork_info().
9846         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
9847         Adjust.
9848         (init_fork_list): Delete.
9849         (linux_fork_killall, linux_fork_mourn_inferior)
9850         (linux_fork_detach, info_checkpoints_command): Adjust.
9851         (_initialize_linux_fork): No longer call init_fork_list.
9852
9853 2019-03-06  Pedro Alves  <palves@redhat.com>
9854
9855         * linux-fork.c (new_fork): New, split out of ...
9856         (add_fork): ... this.  Return void.  Move "first fork" special
9857         case from here, to ...
9858         (checkpoint_command): ... here.
9859         * linux-linux.h (add_fork): Return void.
9860
9861 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9862
9863         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
9864
9865 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9866             Chris January  <chris.january@arm.com>
9867             David Lecomber  <david.lecomber@arm.com>
9868
9869         * f-exp.y: New token, UNOP_INTRINSIC.
9870         (exp): New pattern using UNOP_INTRINSIC token.
9871         (f77_keywords): Add 'abs' keyword.
9872         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
9873         (value_from_host_double): New function.
9874         (evaluate_subexp_f): Support UNOP_ABS.
9875
9876 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9877
9878         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
9879         types.
9880
9881 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9882
9883         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
9884         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
9885         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
9886
9887 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9888
9889         * f-exp.y (convert_to_kind_type): Handle more type kinds.
9890
9891 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9892             Chris January  <chris.january@arm.com>
9893
9894         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
9895         * f-exp.y: Define 'KIND' token.
9896         (exp): New pattern for KIND expressions.
9897         (ptype): Handle types with a kind extension.
9898         (direct_abs_decl): Extend to spot kind extensions.
9899         (f77_keywords): Add 'kind' to the list.
9900         (push_kind_type): New function.
9901         (convert_to_kind_type): New function.
9902         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
9903         * parse.c (operator_length_standard): Likewise.
9904         * parser-defs.h (enum type_pieces): Add tp_kind.
9905         * std-operator.def: Add UNOP_KIND.
9906
9907 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9908
9909         * f-exp.y (f_parse): Set yydebug.
9910
9911 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9912
9913         * f-lang.c (evaluate_subexp_f): New function.
9914         (exp_descriptor_f): New global.
9915         (f_language_defn): Use exp_descriptor_f instead of
9916         exp_descriptor_standard.
9917
9918 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9919
9920         * f-exp.y (struct token): Add comments.
9921         (dot_ops): Remove uppercase versions and the end marker.
9922         (f77_keywords): Likewise.
9923         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
9924         entries in the dot_ops array are case insensitive, and use
9925         strncasecmp to compare strings.  Also some whitespace cleanup in
9926         this area.  Similar for the f77_keywords array, except entries in
9927         this list might be case sensitive.
9928
9929 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9930
9931         * f-exp.y (struct f77_boolean_val): Add comments.
9932         (boolean_values): Remove uppercase versions, and end marker.
9933         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9934         and use strncasecmp to achieve case insensitivity.  Additionally,
9935         perform whitespace cleanup around this code.
9936
9937 2019-03-06  Tom Tromey  <tromey@adacore.com>
9938
9939         * remote-sim.c (gdbsim_target_open): Use result of
9940         gdb_argv::release.
9941
9942 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
9943         Dirk Schubert  <dirk.schubert@arm.com>
9944         Chris January  <chris.january@arm.com>
9945
9946         * eval.c (evaluate_subexp_standard): Call Fortran argument
9947         wrapping logic.
9948         * f-lang.c (struct value): A value which can be passed into a
9949         Fortran function call.
9950         (fortran_argument_convert): Wrap Fortran arguments in a pointer
9951         where appropriate.
9952         (struct type): Value ready for a Fortran function call.
9953         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9954         is needed.
9955         * f-lang.h (fortran_argument_convert): Declaration.
9956         (fortran_preserve_arg_pointer): Declaration.
9957         * infcall.c (value_arg_coerce): Call Fortran argument logic.
9958
9959 2019-03-05  Tom Tromey  <tromey@adacore.com>
9960
9961         * python/py-prettyprint.c (print_string_repr): Remove #if.
9962         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9963
9964 2019-03-05  Tom Tromey  <tromey@adacore.com>
9965
9966         * target.c (the_dummy_target): Move later.  Change type to
9967         "dummy_target".
9968         (initialize_targets): Don't initialize the_dummy_target.
9969
9970 2019-03-05  Tom Tromey  <tromey@adacore.com>
9971
9972         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9973         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9974
9975 2019-03-05  Tom Tromey  <tromey@adacore.com>
9976
9977         * windows-nat.c (windows_nat_target::attach)
9978         (windows_nat_target::detach): Don't call gdb_flush.
9979         * valprint.c (generic_val_print, val_print, val_print_string):
9980         Don't call gdb_flush.
9981         * utils.c (defaulted_query): Don't call gdb_flush.
9982         * typeprint.c (print_type_scalar): Don't call gdb_flush.
9983         * target.c (target_announce_detach): Don't call gdb_flush.
9984         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9985         * remote.c (extended_remote_target::attach): Don't call
9986         gdb_flush.
9987         * procfs.c (procfs_target::detach): Don't call gdb_flush.
9988         * printcmd.c (do_examine): Don't call gdb_flush.
9989         (info_display_command): Don't call gdb_flush.
9990         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9991         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9992         * memattr.c (info_mem_command): Don't call gdb_flush.
9993         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9994         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9995         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9996         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9997         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9998         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9999         (gnu_nat_target::detach): Don't call gdb_flush.
10000         * f-valprint.c (f_val_print): Don't call gdb_flush.
10001         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
10002         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
10003         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
10004         gdb_flush.
10005         * c-valprint.c (c_val_print): Don't call gdb_flush.
10006         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
10007
10008 2019-03-05  Tom Tromey  <tromey@adacore.com>
10009
10010         * varobj.c (update_dynamic_varobj_children): Update.
10011         (install_default_visualizer): Use reset, not release.
10012         * value.c (set_internalvar): Update.
10013         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
10014         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
10015         ATTRIBUTE_UNUSED_RESULT.
10016
10017 2019-03-05  Tom Tromey  <tromey@adacore.com>
10018
10019         * remote.c (class scoped_remote_fd) <release>: Add
10020         ATTRIBUTE_UNUSED_RESULT.
10021
10022 2019-03-05  Tom Tromey  <tromey@adacore.com>
10023
10024         * macroexp.c (struct macro_buffer) <release>: Add
10025         ATTRIBUTE_UNUSED_RESULT.
10026
10027 2019-03-05  Tom Tromey  <tromey@adacore.com>
10028
10029         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
10030         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
10031         ATTRIBUTE_UNUSED_RESULT.
10032
10033 2019-03-05  Tom Tromey  <tromey@adacore.com>
10034
10035         * common/scoped_fd.h (class scoped_fd) <release>: Add
10036         ATTRIBUTE_UNUSED_RESULT.
10037
10038 2019-03-05  Tom Tromey  <tromey@adacore.com>
10039
10040         * parser-defs.h (struct parser_state) <release>: Add
10041         ATTRIBUTE_UNUSED_RESULT.
10042
10043 2019-03-05  Tom Tromey  <tromey@adacore.com>
10044
10045         * utils.h (class gdb_argv) <release>: Add
10046         ATTRIBUTE_UNUSED_RESULT.
10047         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
10048
10049 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
10050
10051         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
10052         for-loop range, to avoid compiler warnings.
10053
10054         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
10055         avoid compiler warnings about unused variables.
10056
10057         * NEWS: Mention end of support for native debugging on MS-Windows
10058         before XP.
10059
10060         PR gdb/24292
10061         * common/netstuff.c:
10062         * gdbserver/gdbreplay.c
10063         * gdbserver/remote-utils.c:
10064         * ser-tcp.c:
10065         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
10066         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
10067         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
10068         'getaddrinfo' and 'freeaddrinfo' were not available before
10069         Windows XP, and mingw.org's MinGW headers by default define
10070         _WIN32_WINNT to 0x500.
10071
10072 2019-03-01  Gary Benson <gbenson@redhat.com>
10073
10074         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
10075
10076 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
10077             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
10078
10079         PR gdb/8527
10080         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
10081         set_sigint_trap, clear_sigint_trap.
10082
10083 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10084
10085         * target.c (target_detach): Clear the regcache and the
10086         frame cache.
10087
10088 2019-02-27  Pedro Alves  <palves@redhat.com>
10089
10090         * utils.c (set_screen_size): When we cap the height/width sizes,
10091         tweak the corresponding command variable to show "unlimited":
10092
10093 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
10094             Pedro Alves  <palves@redhat.com>
10095
10096         * utils.c (set_screen_size): Reduce "infinite" rows and columns
10097         before calling rl_set_screen_size.
10098
10099 2019-02-27  Tom Tromey  <tromey@adacore.com>
10100
10101         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
10102         define.
10103         * python/py-value.c: Remove Python 2.4 workaround.
10104         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
10105         workaround.
10106         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
10107         Python 2.4 workaround.
10108         * python/python-internal.h: Remove Python 2.4 comment.
10109         (Py_ssize_t): Don't define.
10110         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
10111         (gdb_Py_DECREF): Remove Python 2.4 workaround.
10112         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
10113         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
10114         * python/python.c (do_start_initialization): Remove Python 2.4
10115         workaround.
10116         * python/py-prettyprint.c (class dummy_python_frame): Remove.
10117         (print_children): Remove Python 2.4 workaround.
10118         * python/py-inferior.c (buffer_procs): Remove Python 2.4
10119         workaround.
10120         (CHARBUFFERPROC_NAME): Remove.
10121         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
10122         Python 2.4 workaround.
10123
10124 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10125
10126         * NEWS: Note minimum Python version.
10127
10128 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10129
10130         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
10131         code from these functions.  Remove corresponding ifdefs.  Use
10132         Py_buffer_up instead of explicit calls to PyBuffer_Release.
10133         Remove gotos and target of gotos.
10134         (infpy_search_memory): Likewise.
10135
10136 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10137
10138         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
10139         (hppa_gdbarch_init): Don't register deleted functions with
10140         gdbarch.
10141
10142 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10143
10144         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
10145         (h8300_unwind_sp): Delete.
10146         (h8300_dummy_id): Delete.
10147         (h8300_gdbarch_init): Don't register deleted functions with
10148         gdbarch.
10149
10150 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10151
10152         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
10153         (ft32_unwind_pc): Delete.
10154         (ft32_unwind_sp): Delete.
10155         (ft32_gdbarch_init): Don't register deleted functions with
10156         gdbarch.
10157
10158 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10159
10160         * gdb/frv-tdep.c (frv_dummy_id): Delete.
10161         (frv_unwind_pc): Delete.
10162         (frv_unwind_sp): Delete.
10163         (frv_gdbarch_init): Don't register deleted functions with
10164         gdbarch.
10165
10166 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10167
10168         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
10169         (riscv_unwind_pc): Delete.
10170         (riscv_unwind_sp): Delete.
10171         (riscv_gdbarch_init): Don't register deleted functions with
10172         gdbarch.
10173
10174 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10175
10176         * gdb/csky-tdep.c (csky_dummy_id): Delete.
10177         (csky_unwind_pc): Delete.
10178         (csky_unwind_sp): Delete.
10179         (csky_gdbarch_init): Don't register deleted functions with
10180         gdbarch.
10181
10182 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10183
10184         * gdb/cris-tdep.c (cris_dummy_id): Delete.
10185         (cris_unwind_pc): Delete.
10186         (cris_unwind_sp): Delete.
10187         (cris_gdbarch_init): Don't register deleted functions with
10188         gdbarch.
10189
10190 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10191
10192         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
10193         (bfin_unwind_pc): Delete.
10194         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
10195
10196 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10197
10198         * gdb/arm-tdep.c (arm_dummy_id): Delete.
10199         (arm_unwind_pc): Delete.
10200         (arm_unwind_sp): Delete.
10201         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
10202
10203 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10204
10205         * gdb/arc-tdep.c (arc_dummy_id): Delete.
10206         (arc_unwind_pc): Delete.
10207         (arc_unwind_sp): Delete.
10208         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
10209
10210 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10211
10212         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
10213         (alpha_unwind_pc): Delete.
10214         (alpha_gdbarch_init): Don't register deleted functions with
10215         gdbarch.
10216
10217 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10218
10219         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
10220         (aarch64_unwind_pc): Delete.
10221         (aarch64_unwind_sp): Delete.
10222         (aarch64_gdbarch_init): Don't register deleted functions with
10223         gdbarch.
10224
10225 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10226
10227         * gdbtypes.c (type_align): Don't consider static members when
10228         computing structure alignment.
10229
10230 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10231
10232         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
10233         return 0 for other types.
10234         * arch-utils.c (default_type_align): Always return 0.
10235         * gdbarch.h: Regenerate.
10236         * gdbarch.sh (type_align): Extend comment.
10237         * gdbtypes.c (type_align): Add additional comments, always call
10238         gdbarch_type_align before applying the default rules.
10239         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
10240         generic code will then apply a suitable default.
10241         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
10242         types, return 0 for other types.
10243
10244 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
10245
10246         * NEWS: Create a new section for the next release branch.
10247         Rename the section of the current branch, now that it has
10248         been cut.
10249
10250 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
10251
10252         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
10253         * version.in: Bump version to 8.3.50.DATE-git.
10254
10255 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
10256
10257         * aix-thread.c (ptid_cmp): Remove unused variable.
10258         (get_signaled_thread): Likewise.
10259         (store_regs_user_thread): Likewise.
10260         (store_regs_kernel_thread): Likewise.
10261         (fetch_regs_kernel_thread): Remove shadowed variable.
10262
10263 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10264
10265         * features/riscv/32bit-cpu.xml: Add register numbers.
10266         * features/riscv/32bit-fpu.c: Regenerate.
10267         * features/riscv/32bit-fpu.xml: Add register numbers.
10268         * features/riscv/64bit-cpu.xml: Add register numbers.
10269         * features/riscv/64bit-fpu.c: Regenerate.
10270         * features/riscv/64bit-fpu.xml: Add register numbers.
10271
10272 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
10273
10274         * NEWS: Mention two argument form of gdb.Value constructor.
10275         * python/py-value.c (convert_buffer_and_type_to_value): New
10276         function.
10277         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
10278         Add support for handling an optional second argument.  Call
10279         convert_buffer_and_type_to_value as appropriate.
10280         * python/python-internal.h (Py_buffer_deleter): New struct.
10281         (Py_buffer_up): New typedef.
10282
10283 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
10284
10285         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
10286         instead of releasing ownership.
10287
10288 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
10289
10290         * dwarf2read.c (open_and_init_dwp_file): Call
10291         elf_numsections instead of bfd_count_sections to initialize
10292         dwp_file->num_sections.
10293
10294 2019-02-25  Tom Tromey  <tromey@adacore.com>
10295
10296         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
10297
10298 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
10299
10300         * gcore.in: Add '--readnever' option when invoking GDB.
10301
10302 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
10303
10304         * MAINTAINERS: Update my email address.
10305
10306 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
10307
10308         * build-id.c (build_id_to_debug_bfd_1): New function.
10309         (build_id_to_debug_bfd): Look for separate debug file in
10310         sysroot.
10311
10312 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
10313
10314         * gdbarch.sh: Update the copyright year range that is placed into
10315         generated files.
10316
10317 2019-02-22  Keith Seitz  <keiths@redhat.com>
10318
10319         PR symtab/23853
10320         * linespec.c (create_sals_line_offset): Search for the default
10321         symtab's filename instead of its fullname.
10322
10323 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
10324
10325         * NEWS: Update style defaults.
10326
10327 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
10328
10329         * main.c (captured_main_1): Disable styling in batch mode.
10330
10331 2019-02-20  Tom Tromey  <tom@tromey.com>
10332
10333         * symtab.c (symtab_symbol_info): Fix typos.
10334
10335 2019-02-20  Tom Tromey  <tromey@adacore.com>
10336
10337         * findcmd.c (_initialize_mem_search): Use upper case for
10338         metasyntactic variables.
10339
10340 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
10341
10342         * aarch64-tdep.c (aarch64_add_reggroups): New function.
10343         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
10344
10345 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
10346
10347         * top.h (source_file_name): Change to std::string.
10348         * top.c (source_file_name): Likewise.
10349         (command_line_input): Adjust.
10350         * cli/cli-script.c (script_from_file): Adjust.
10351
10352 2019-02-19  Tom Tromey  <tromey@adacore.com>
10353
10354         * ravenscar-thread.c
10355         (ravenscar_thread_target::update_thread_list): Don't call
10356         ada_build_task_list.
10357         * ada-lang.h (ada_build_task_list): Don't declare.
10358         * ada-tasks.c (struct ada_tasks_inferior_data)
10359         <task_list_valid_p>: Now bool.
10360         (read_known_tasks, ada_task_list_changed)
10361         (ada_tasks_invalidate_inferior_data): Update.
10362         (read_known_tasks_array): Return bool.
10363         (read_known_tasks_list): Likewise.
10364         (read_known_tasks): Return void.
10365         (ada_build_task_list): Now static.
10366
10367 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10368
10369         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
10370         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
10371
10372 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10373
10374         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
10375         variant for ada_tasks_pspace_data_handle and
10376         ada_tasks_inferior_data_handle.
10377         (ada_tasks_pspace_data_cleanup): New function.
10378         (ada_tasks_inferior_data_cleanup): New function.
10379
10380 2019-02-17  Tom Tromey  <tom@tromey.com>
10381
10382         * macrotab.h (macro_source_fullname): Return a std::string.
10383         * macrotab.c (macro_include, check_for_redefinition)
10384         (macro_undef, macro_lookup_definition, foreach_macro)
10385         (foreach_macro_in_scope): Update.
10386         (macro_source_fullname): Return a std::string.
10387         * macrocmd.c (show_pp_source_pos): Update.
10388
10389 2019-02-17  Tom Tromey  <tom@tromey.com>
10390
10391         * macrocmd.c (show_pp_source_pos): Style the file names.
10392
10393 2019-02-17  Tom Tromey  <tom@tromey.com>
10394
10395         PR tui/24197:
10396         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
10397
10398 2019-02-17  Tom Tromey  <tom@tromey.com>
10399
10400         * ada-lang.c (user_select_syms): Use filtered printing.
10401         * utils.c (wrap_style): New global.
10402         (desired_style): Remove.
10403         (emit_style_escape): Add stream parameter.
10404         (set_output_style, reset_terminal_style, prompt_for_continue):
10405         Update.
10406         (flush_wrap_buffer): Only flush gdb_stdout.
10407         (wrap_here): Set wrap_style.
10408         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
10409         treat escape sequences as a character.  Change when wrap buffer is
10410         flushed.
10411         (fputs_styled): Do not set the output style when the default is
10412         requested.
10413         * ui-style.h (struct ui_file_style) <is_default>: New method.
10414         * source.c (print_source_lines_base): Emit escape sequences in one
10415         piece.
10416
10417 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10418
10419         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
10420         integers and enumeration types.
10421
10422 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10423
10424         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
10425         instead of lookup_symbol_in_language
10426         (do_exact_match): New function.
10427         (ada_get_symbol_name_matcher): Return do_exact_match when
10428         doing a verbatim match.
10429
10430 2019-02-15  Tom Tromey  <tromey@adacore.com>
10431
10432         * ravenscar-thread.c (ravenscar_thread_target::resume)
10433         (ravenscar_thread_target::wait): Special case wildcard requests.
10434
10435 2019-02-15  Tom Tromey  <tromey@adacore.com>
10436
10437         * ravenscar-thread.c (base_ptid): Remove.
10438         (struct ravenscar_thread_target) <close>: New method.
10439         <m_base_ptid>: New member.
10440         <update_inferior_ptid, active_task, task_is_currently_active,
10441         runtime_initialized>: Declare methods.
10442         <ravenscar_thread_target>: Add constructor.
10443         (ravenscar_thread_target::task_is_currently_active)
10444         (ravenscar_thread_target::update_inferior_ptid)
10445         (ravenscar_runtime_initialized): Rename.  Now methods.
10446         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
10447         (ravenscar_thread_target::update_thread_list): Update.
10448         (ravenscar_thread_target::active_task): Now method.
10449         (ravenscar_thread_target::store_registers)
10450         (ravenscar_thread_target::prepare_to_store)
10451         (ravenscar_thread_target::prepare_to_store)
10452         (ravenscar_thread_target::mourn_inferior): Update.
10453         (ravenscar_inferior_created): Use "new" to create target.
10454         (ravenscar_thread_target::get_ada_task_ptid): Update.
10455         (_initialize_ravenscar): Don't initialize base_ptid.
10456         (ravenscar_ops): Remove global.
10457
10458 2019-02-15  Tom Tromey  <tromey@adacore.com>
10459
10460         * target.h (push_target): Declare new overload.
10461         * target.c (push_target): New overload, taking an rvalue reference.
10462         * remote.c (remote_target::open_1): Use push_target overload.
10463         * corelow.c (core_target_open): Use push_target overload.
10464
10465 2019-02-15  Tom Tromey  <tromey@adacore.com>
10466
10467         * ravenscar-thread.c (is_ravenscar_task)
10468         (ravenscar_task_is_currently_active): Return bool.
10469         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
10470         (_initialize_ravenscar): Remove "(void)".
10471         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
10472         Return bool.
10473
10474 2019-02-15  Tom Tromey  <tromey@adacore.com>
10475
10476         * ravenscar-thread.c (ravenscar_runtime_initializer)
10477         (has_ravenscar_runtime, get_running_thread_id)
10478         (ravenscar_thread_target::resume): Fix indentation.
10479
10480 2019-02-15  Tom Tromey  <tromey@adacore.com>
10481
10482         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
10483         from ravenscar_arch_ops.
10484         (sparc_ravenscar_ops::fetch_registers)
10485         (sparc_ravenscar_ops::store_registers): Now methods.
10486         (sparc_ravenscar_prepare_to_store): Remove.
10487         (sparc_ravenscar_ops): Redefine.
10488         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
10489         methods and destructor.  Remove members.
10490         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
10491         (ravenscar_thread_target::store_registers)
10492         (ravenscar_thread_target::prepare_to_store): Update.
10493         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
10494         Remove.
10495         (struct ppc_ravenscar_powerpc_ops): Derive from
10496         ravenscar_arch_ops.
10497         (ppc_ravenscar_powerpc_ops::fetch_registers)
10498         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
10499         (ppc_ravenscar_powerpc_ops): Redefine.
10500         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
10501         (ppc_ravenscar_e500_ops::fetch_registers)
10502         (ppc_ravenscar_e500_ops::store_registers): Now methods.
10503         (ppc_ravenscar_e500_ops): Redefine.
10504         * aarch64-ravenscar-thread.c
10505         (aarch64_ravenscar_generic_prepare_to_store): Remove.
10506         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
10507         (aarch64_ravenscar_fetch_registers)
10508         (aarch64_ravenscar_store_registers): Now methods.
10509         (aarch64_ravenscar_ops): Redefine.
10510
10511 2019-02-15  Tom Tromey  <tromey@adacore.com>
10512
10513         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
10514         (ravenscar_thread_target::stopped_by_hw_breakpoint)
10515         (ravenscar_thread_target::stopped_by_watchpoint)
10516         (ravenscar_thread_target::stopped_data_address)
10517         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
10518
10519 2019-02-15  Tom Tromey  <tromey@adacore.com>
10520
10521         * ravenscar-thread.c: Fix some typos.
10522
10523 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10524             Tom Tromey  <tromey@adacore.com>
10525
10526         * ada-lang.c (ada_exception_sal): Change addr_string to a
10527         std::string.
10528         (create_ada_exception_catchpoint): Update.
10529
10530 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10531             Tom Tromey  <tromey@adacore.com>
10532
10533         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
10534         (bp_location_ops): Remove.
10535         (base_breakpoint_allocate_location): Update.
10536         (free_bp_location): Update.
10537         * ada-lang.c (class ada_catchpoint_location)
10538         <ada_catchpoint_location>: Remove ops parameter.
10539         (ada_catchpoint_location_dtor): Remove.
10540         (ada_catchpoint_location_ops): Remove.
10541         (allocate_location_exception): Update.
10542         * breakpoint.h (struct bp_location_ops): Remove.
10543         (class bp_location) <bp_location>: Remove bp_location_ops
10544         parameter.
10545         <~bp_location>: Add destructor.
10546         <ops>: Remove.
10547
10548 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10549             Pedro Alves  <palves@redhat.com>
10550
10551         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
10552         'PATH_MAX'.
10553
10554 2019-02-14  David Michael  <fedora.dm0@gmail.com>
10555             Samuel Thibault  <samuel.thibault@gnu.org>
10556             Thomas Schwinge  <thomas@codesourcery.com>
10557
10558         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
10559         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
10560
10561 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10562
10563         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
10564         (check_empty): Use "const char *".
10565
10566         * gnu-nat.c (gnu_nat_target::detach): Instead of
10567         'detach_inferior (pid)' call
10568         'detach_inferior (find_inferior_pid (pid))'.
10569
10570         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
10571         'nat/fork-inferior.o'.
10572         * gnu-nat.c: #include "nat/fork-inferior.h".
10573
10574         * gnu-nat.c (gnu_nat_target::detach): Instead of
10575         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
10576         * gnu-nat.h: #include "inf-child.h".
10577         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
10578         'i386_gnu_nat_target::fetch_registers'.
10579         (gnu_store_registers): Rename/move to
10580         'i386_gnu_nat_target::store_registers'.
10581
10582         * config/i386/nm-i386gnu.h: Don't "#include" any files.
10583         * gnu-nat.h (mach_thread_info): New function.
10584         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
10585
10586         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
10587
10588 2019-02-14  Frederic Konrad  <konrad@adacore.com>
10589
10590         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
10591
10592 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
10593
10594         * windows-nat.c (windows_add_thread): Add new parameter
10595         "main_thread_p" with default value set to false.  Update
10596         function documentation as well as all callers.
10597         (windows_delete_thread): Likewise.
10598         (fake_create_process): Update call to windows_add_thread.
10599         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
10600         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
10601         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
10602         call to windows_delete_thread.
10603
10604 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
10605
10606         * MAINTAINERS: Add Andrew Burgess as global maintainer.
10607
10608 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10609
10610         * symfile.c (find_separate_debug_file): Use canonical path of
10611         sysroot with child_path instead of gdb_sysroot if it is valid.
10612
10613 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10614
10615         * symfile.c (find_separate_debug_file): Use child_path to
10616         determine if an object file is under a sysroot.
10617
10618 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10619
10620         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
10621         unittests/child-path-selftests.c.
10622         * common/pathstuff.c (child_path): New function.
10623         * common/pathstuff.h (child_path): New prototype.
10624         * unittests/child-path-selftests.c: New file.
10625
10626 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10627
10628         * symfile.c (find_separate_debug_file): Look for separate debug
10629         files in debug directories under the sysroot.
10630
10631 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10632
10633         * symtab.h (struct minimal_symbol data_p): New const method.
10634         (struct minimal_symbol text_p): Likewise.
10635         * symtab.c (output_source_filename): Use file name style
10636         to print file name.
10637         (print_symbol_info): Likewise.
10638         (print_msymbol_info): Use address style to print addresses.
10639         Use function name style to print executable text symbols.
10640         (expand_symtab_containing_pc): Use data_p.
10641         (find_pc_sect_compunit_symtab): Likewise.
10642
10643 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10644
10645         * breakpoint.c (describe_other_breakpoints): Use address style
10646         to print addresses.
10647         (say_where): Likewise.
10648
10649 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10650
10651         * ada-typeprint.c (print_func_type): Print function name
10652         style to print function name.
10653         * c-typeprint.c (c_print_type_1): Likewise.
10654
10655 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
10656
10657         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
10658         for execve.
10659
10660 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10661
10662         * c-exp.y (direct_abs_decl): Use emplace_back to record the
10663         type_stack.
10664
10665 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
10666
10667         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
10668         TYPE_CODE_REF types.
10669
10670 2019-02-08  Jim Wilson  <jimw@sifive.com>
10671
10672         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
10673         (riscv_linux_fregset): New.
10674         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
10675
10676 2019-02-07  Tom Tromey  <tom@tromey.com>
10677
10678         * thread.c (thread_cancel_execution_command): Update.
10679         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
10680         methods.
10681         (struct thread_fsm_ops): Remove.
10682         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
10683         (thread_fsm_should_stop, thread_fsm_return_value)
10684         (thread_fsm_set_finished, thread_fsm_finished_p)
10685         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
10686         Don't declare.
10687         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
10688         * infrun.c (clear_proceed_status_thread)
10689         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
10690         (print_stop_event): Update.
10691         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
10692         Add constructor.
10693         (step_command_fsm_ops): Remove.
10694         (new_step_command_fsm): Remove.
10695         (step_1): Update.
10696         (step_command_fsm::should_stop): Rename from
10697         step_command_fsm_should_stop.
10698         (step_command_fsm::clean_up): Rename from
10699         step_command_fsm_clean_up.
10700         (step_command_fsm::do_async_reply_reason): Rename from
10701         step_command_fsm_async_reply_reason.
10702         (struct until_next_fsm): Inherit from thread_fsm.  Add
10703         constructor.
10704         (until_next_fsm_ops): Remove.
10705         (new_until_next_fsm): Remove.
10706         (until_next_fsm::should_stop): Rename from
10707         until_next_fsm_should_stop.
10708         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
10709         (until_next_fsm::do_async_reply_reason): Rename from
10710         until_next_fsm_async_reply_reason.
10711         (struct finish_command_fsm): Inherit from thread_fsm.  Add
10712         constructor.  Change type of breakpoint.
10713         (finish_command_fsm_ops): Remove.
10714         (new_finish_command_fsm): Remove.
10715         (finish_command_fsm::should_stop): Rename from
10716         finish_command_fsm_should_stop.
10717         (finish_command_fsm::clean_up): Rename from
10718         finish_command_fsm_clean_up.
10719         (finish_command_fsm::return_value): Rename from
10720         finish_command_fsm_return_value.
10721         (finish_command_fsm::do_async_reply_reason): Rename from
10722         finish_command_fsm_async_reply_reason.
10723         (finish_command): Update.
10724         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
10725         Add constructor.
10726         (call_thread_fsm_ops): Remove.
10727         (call_thread_fsm::call_thread_fsm): Rename from
10728         new_call_thread_fsm.
10729         (call_thread_fsm::should_stop): Rename from
10730         call_thread_fsm_should_stop.
10731         (call_thread_fsm::should_notify_stop): Rename from
10732         call_thread_fsm_should_notify_stop.
10733         (run_inferior_call, call_function_by_hand_dummy): Update.
10734         * cli/cli-interp.c (should_print_stop_to_console): Update.
10735         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
10736         Add constructor.  Change type of location_breakpoint,
10737         caller_breakpoint.
10738         (until_break_fsm_ops): Remove.
10739         (new_until_break_fsm): Remove.
10740         (until_break_fsm::should_stop): Rename from
10741         until_break_fsm_should_stop.
10742         (until_break_fsm::clean_up): Rename from
10743         until_break_fsm_clean_up.
10744         (until_break_fsm::do_async_reply_reason): Rename from
10745         until_break_fsm_async_reply_reason.
10746         (until_break_command): Update.
10747         * thread-fsm.c: Remove.
10748         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
10749
10750 2019-02-07  Tom Tromey  <tom@tromey.com>
10751
10752         * yy-remap.h: Add include guard.
10753         * xtensa-tdep.h: Add include guard.
10754         * xcoffread.h: Rename include guard.
10755         * varobj-iter.h: Add include guard.
10756         * tui/tui.h: Rename include guard.
10757         * tui/tui-winsource.h: Rename include guard.
10758         * tui/tui-wingeneral.h: Rename include guard.
10759         * tui/tui-windata.h: Rename include guard.
10760         * tui/tui-win.h: Rename include guard.
10761         * tui/tui-stack.h: Rename include guard.
10762         * tui/tui-source.h: Rename include guard.
10763         * tui/tui-regs.h: Rename include guard.
10764         * tui/tui-out.h: Rename include guard.
10765         * tui/tui-layout.h: Rename include guard.
10766         * tui/tui-io.h: Rename include guard.
10767         * tui/tui-hooks.h: Rename include guard.
10768         * tui/tui-file.h: Rename include guard.
10769         * tui/tui-disasm.h: Rename include guard.
10770         * tui/tui-data.h: Rename include guard.
10771         * tui/tui-command.h: Rename include guard.
10772         * tic6x-tdep.h: Add include guard.
10773         * target/waitstatus.h: Rename include guard.
10774         * target/wait.h: Rename include guard.
10775         * target/target.h: Rename include guard.
10776         * target/resume.h: Rename include guard.
10777         * target-float.h: Rename include guard.
10778         * stabsread.h: Add include guard.
10779         * rs6000-tdep.h: Add include guard.
10780         * riscv-fbsd-tdep.h: Add include guard.
10781         * regformats/regdef.h: Rename include guard.
10782         * record.h: Rename include guard.
10783         * python/python.h: Rename include guard.
10784         * python/python-internal.h: Rename include guard.
10785         * python/py-stopevent.h: Rename include guard.
10786         * python/py-ref.h: Rename include guard.
10787         * python/py-record.h: Rename include guard.
10788         * python/py-record-full.h: Rename include guard.
10789         * python/py-record-btrace.h: Rename include guard.
10790         * python/py-instruction.h: Rename include guard.
10791         * python/py-events.h: Rename include guard.
10792         * python/py-event.h: Rename include guard.
10793         * procfs.h: Add include guard.
10794         * proc-utils.h: Add include guard.
10795         * p-lang.h: Add include guard.
10796         * or1k-tdep.h: Rename include guard.
10797         * observable.h: Rename include guard.
10798         * nto-tdep.h: Rename include guard.
10799         * nat/x86-linux.h: Rename include guard.
10800         * nat/x86-linux-dregs.h: Rename include guard.
10801         * nat/x86-gcc-cpuid.h: Add include guard.
10802         * nat/x86-dregs.h: Rename include guard.
10803         * nat/x86-cpuid.h: Rename include guard.
10804         * nat/ppc-linux.h: Rename include guard.
10805         * nat/mips-linux-watch.h: Rename include guard.
10806         * nat/linux-waitpid.h: Rename include guard.
10807         * nat/linux-ptrace.h: Rename include guard.
10808         * nat/linux-procfs.h: Rename include guard.
10809         * nat/linux-osdata.h: Rename include guard.
10810         * nat/linux-nat.h: Rename include guard.
10811         * nat/linux-namespaces.h: Rename include guard.
10812         * nat/linux-btrace.h: Rename include guard.
10813         * nat/glibc_thread_db.h: Rename include guard.
10814         * nat/gdb_thread_db.h: Rename include guard.
10815         * nat/gdb_ptrace.h: Rename include guard.
10816         * nat/fork-inferior.h: Rename include guard.
10817         * nat/amd64-linux-siginfo.h: Rename include guard.
10818         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
10819         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
10820         * nat/aarch64-linux.h: Rename include guard.
10821         * nat/aarch64-linux-hw-point.h: Rename include guard.
10822         * mn10300-tdep.h: Add include guard.
10823         * mips-linux-tdep.h: Add include guard.
10824         * mi/mi-parse.h: Rename include guard.
10825         * mi/mi-out.h: Rename include guard.
10826         * mi/mi-main.h: Rename include guard.
10827         * mi/mi-interp.h: Rename include guard.
10828         * mi/mi-getopt.h: Rename include guard.
10829         * mi/mi-console.h: Rename include guard.
10830         * mi/mi-common.h: Rename include guard.
10831         * mi/mi-cmds.h: Rename include guard.
10832         * mi/mi-cmd-break.h: Rename include guard.
10833         * m2-lang.h: Add include guard.
10834         * location.h: Rename include guard.
10835         * linux-record.h: Rename include guard.
10836         * linux-nat.h: Add include guard.
10837         * linux-fork.h: Add include guard.
10838         * i386-darwin-tdep.h: Rename include guard.
10839         * hppa-linux-offsets.h: Add include guard.
10840         * guile/guile.h: Rename include guard.
10841         * guile/guile-internal.h: Rename include guard.
10842         * gnu-nat.h: Rename include guard.
10843         * gdb-stabs.h: Rename include guard.
10844         * frv-tdep.h: Add include guard.
10845         * f-lang.h: Add include guard.
10846         * event-loop.h: Add include guard.
10847         * darwin-nat.h: Rename include guard.
10848         * cp-abi.h: Rename include guard.
10849         * config/sparc/nm-sol2.h: Rename include guard.
10850         * config/nm-nto.h: Rename include guard.
10851         * config/nm-linux.h: Add include guard.
10852         * config/i386/nm-i386gnu.h: Rename include guard.
10853         * config/djgpp/nl_types.h: Rename include guard.
10854         * config/djgpp/langinfo.h: Rename include guard.
10855         * compile/gcc-cp-plugin.h: Add include guard.
10856         * compile/gcc-c-plugin.h: Add include guard.
10857         * compile/compile.h: Rename include guard.
10858         * compile/compile-object-run.h: Rename include guard.
10859         * compile/compile-object-load.h: Rename include guard.
10860         * compile/compile-internal.h: Rename include guard.
10861         * compile/compile-cplus.h: Rename include guard.
10862         * compile/compile-c.h: Rename include guard.
10863         * common/xml-utils.h: Rename include guard.
10864         * common/x86-xstate.h: Rename include guard.
10865         * common/version.h: Rename include guard.
10866         * common/vec.h: Rename include guard.
10867         * common/tdesc.h: Rename include guard.
10868         * common/selftest.h: Rename include guard.
10869         * common/scoped_restore.h: Rename include guard.
10870         * common/scoped_mmap.h: Rename include guard.
10871         * common/scoped_fd.h: Rename include guard.
10872         * common/safe-iterator.h: Rename include guard.
10873         * common/run-time-clock.h: Rename include guard.
10874         * common/refcounted-object.h: Rename include guard.
10875         * common/queue.h: Rename include guard.
10876         * common/ptid.h: Rename include guard.
10877         * common/print-utils.h: Rename include guard.
10878         * common/preprocessor.h: Rename include guard.
10879         * common/pathstuff.h: Rename include guard.
10880         * common/observable.h: Rename include guard.
10881         * common/netstuff.h: Rename include guard.
10882         * common/job-control.h: Rename include guard.
10883         * common/host-defs.h: Rename include guard.
10884         * common/gdb_wait.h: Rename include guard.
10885         * common/gdb_vecs.h: Rename include guard.
10886         * common/gdb_unlinker.h: Rename include guard.
10887         * common/gdb_unique_ptr.h: Rename include guard.
10888         * common/gdb_tilde_expand.h: Rename include guard.
10889         * common/gdb_sys_time.h: Rename include guard.
10890         * common/gdb_string_view.h: Rename include guard.
10891         * common/gdb_splay_tree.h: Rename include guard.
10892         * common/gdb_setjmp.h: Rename include guard.
10893         * common/gdb_ref_ptr.h: Rename include guard.
10894         * common/gdb_optional.h: Rename include guard.
10895         * common/gdb_locale.h: Rename include guard.
10896         * common/gdb_assert.h: Rename include guard.
10897         * common/filtered-iterator.h: Rename include guard.
10898         * common/filestuff.h: Rename include guard.
10899         * common/fileio.h: Rename include guard.
10900         * common/environ.h: Rename include guard.
10901         * common/common-utils.h: Rename include guard.
10902         * common/common-types.h: Rename include guard.
10903         * common/common-regcache.h: Rename include guard.
10904         * common/common-inferior.h: Rename include guard.
10905         * common/common-gdbthread.h: Rename include guard.
10906         * common/common-exceptions.h: Rename include guard.
10907         * common/common-defs.h: Rename include guard.
10908         * common/common-debug.h: Rename include guard.
10909         * common/cleanups.h: Rename include guard.
10910         * common/buffer.h: Rename include guard.
10911         * common/btrace-common.h: Rename include guard.
10912         * common/break-common.h: Rename include guard.
10913         * cli/cli-utils.h: Rename include guard.
10914         * cli/cli-style.h: Rename include guard.
10915         * cli/cli-setshow.h: Rename include guard.
10916         * cli/cli-script.h: Rename include guard.
10917         * cli/cli-interp.h: Rename include guard.
10918         * cli/cli-decode.h: Rename include guard.
10919         * cli/cli-cmds.h: Rename include guard.
10920         * charset-list.h: Add include guard.
10921         * buildsym-legacy.h: Rename include guard.
10922         * bfin-tdep.h: Add include guard.
10923         * ax.h: Rename include guard.
10924         * arm-linux-tdep.h: Add include guard.
10925         * arm-fbsd-tdep.h: Add include guard.
10926         * arch/xtensa.h: Rename include guard.
10927         * arch/tic6x.h: Add include guard.
10928         * arch/i386.h: Add include guard.
10929         * arch/arm.h: Rename include guard.
10930         * arch/arm-linux.h: Rename include guard.
10931         * arch/arm-get-next-pcs.h: Rename include guard.
10932         * arch/amd64.h: Add include guard.
10933         * arch/aarch64-insn.h: Rename include guard.
10934         * arch-utils.h: Rename include guard.
10935         * annotate.h: Add include guard.
10936         * amd64-darwin-tdep.h: Rename include guard.
10937         * aarch64-linux-tdep.h: Add include guard.
10938         * aarch64-fbsd-tdep.h: Add include guard.
10939         * aarch32-linux-nat.h: Add include guard.
10940
10941 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10942
10943         * macrotab.c (macro_define_internal): New function that
10944         factorizes macro_define_object_internal and macro_define_function
10945         code.
10946         (macro_define_object_internal): Use macro_define_internal.
10947         (macro_define_function): Likewise.
10948
10949 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10950
10951         * macrocmd.c (extract_identifier): Return
10952         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10953         callers.
10954
10955 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
10956
10957         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10958
10959 2019-02-05  Tom Tromey  <tom@tromey.com>
10960
10961         * target.c (target_stack::unpush): Move assertion earlier.
10962
10963 2019-01-30  Tom Tromey  <tom@tromey.com>
10964
10965         PR python/23615:
10966         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10967         (gdbpy_parse_and_eval): Likewise.
10968         * python/python-internal.h (gdbpy_allow_threads): New class.
10969
10970 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
10971
10972         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10973         (aarch64_fbsd_fpregmap): Move earlier.
10974         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10975         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10976         instead of individual calls to trad_frame_set_reg_addr.
10977         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10978         earlier.
10979         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10980         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10981         instead of individual calls to trad_frame_set_reg_addr.
10982
10983 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
10984
10985         * CONTRIBUTE: Replace contribution list with wiki link.
10986
10987 2019-01-25  Tom Tromey  <tom@tromey.com>
10988
10989         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10990
10991 2019-01-25  Tom Tromey  <tom@tromey.com>
10992
10993         * xtensa-linux-nat.c: Fix common/ includes.
10994         * xml-support.h: Fix common/ includes.
10995         * xml-support.c: Fix common/ includes.
10996         * x86-linux-nat.c: Fix common/ includes.
10997         * windows-nat.c: Fix common/ includes.
10998         * varobj.h: Fix common/ includes.
10999         * varobj.c: Fix common/ includes.
11000         * value.c: Fix common/ includes.
11001         * valops.c: Fix common/ includes.
11002         * utils.c: Fix common/ includes.
11003         * unittests/xml-utils-selftests.c: Fix common/ includes.
11004         * unittests/utils-selftests.c: Fix common/ includes.
11005         * unittests/unpack-selftests.c: Fix common/ includes.
11006         * unittests/tracepoint-selftests.c: Fix common/ includes.
11007         * unittests/style-selftests.c: Fix common/ includes.
11008         * unittests/string_view-selftests.c: Fix common/ includes.
11009         * unittests/scoped_restore-selftests.c: Fix common/ includes.
11010         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
11011         * unittests/scoped_fd-selftests.c: Fix common/ includes.
11012         * unittests/rsp-low-selftests.c: Fix common/ includes.
11013         * unittests/parse-connection-spec-selftests.c: Fix common/
11014         includes.
11015         * unittests/optional-selftests.c: Fix common/ includes.
11016         * unittests/offset-type-selftests.c: Fix common/ includes.
11017         * unittests/observable-selftests.c: Fix common/ includes.
11018         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
11019         * unittests/memrange-selftests.c: Fix common/ includes.
11020         * unittests/memory-map-selftests.c: Fix common/ includes.
11021         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
11022         * unittests/function-view-selftests.c: Fix common/ includes.
11023         * unittests/environ-selftests.c: Fix common/ includes.
11024         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
11025         * unittests/common-utils-selftests.c: Fix common/ includes.
11026         * unittests/cli-utils-selftests.c: Fix common/ includes.
11027         * unittests/array-view-selftests.c: Fix common/ includes.
11028         * ui-file.c: Fix common/ includes.
11029         * tui/tui-io.c: Fix common/ includes.
11030         * tracepoint.h: Fix common/ includes.
11031         * tracepoint.c: Fix common/ includes.
11032         * tracefile-tfile.c: Fix common/ includes.
11033         * top.h: Fix common/ includes.
11034         * top.c: Fix common/ includes.
11035         * thread.c: Fix common/ includes.
11036         * target/waitstatus.h: Fix common/ includes.
11037         * target/waitstatus.c: Fix common/ includes.
11038         * target.h: Fix common/ includes.
11039         * target.c: Fix common/ includes.
11040         * target-memory.c: Fix common/ includes.
11041         * target-descriptions.c: Fix common/ includes.
11042         * symtab.h: Fix common/ includes.
11043         * symfile.c: Fix common/ includes.
11044         * stap-probe.c: Fix common/ includes.
11045         * spu-linux-nat.c: Fix common/ includes.
11046         * sparc-nat.c: Fix common/ includes.
11047         * source.c: Fix common/ includes.
11048         * solib.c: Fix common/ includes.
11049         * solib-target.c: Fix common/ includes.
11050         * ser-unix.c: Fix common/ includes.
11051         * ser-tcp.c: Fix common/ includes.
11052         * ser-pipe.c: Fix common/ includes.
11053         * ser-base.c: Fix common/ includes.
11054         * selftest-arch.c: Fix common/ includes.
11055         * s12z-tdep.c: Fix common/ includes.
11056         * rust-exp.y: Fix common/ includes.
11057         * rs6000-aix-tdep.c: Fix common/ includes.
11058         * riscv-tdep.c: Fix common/ includes.
11059         * remote.c: Fix common/ includes.
11060         * remote-notif.h: Fix common/ includes.
11061         * remote-fileio.h: Fix common/ includes.
11062         * remote-fileio.c: Fix common/ includes.
11063         * regcache.h: Fix common/ includes.
11064         * regcache.c: Fix common/ includes.
11065         * record-btrace.c: Fix common/ includes.
11066         * python/python.c: Fix common/ includes.
11067         * python/py-type.c: Fix common/ includes.
11068         * python/py-inferior.c: Fix common/ includes.
11069         * progspace.h: Fix common/ includes.
11070         * producer.c: Fix common/ includes.
11071         * procfs.c: Fix common/ includes.
11072         * proc-api.c: Fix common/ includes.
11073         * printcmd.c: Fix common/ includes.
11074         * ppc-linux-nat.c: Fix common/ includes.
11075         * parser-defs.h: Fix common/ includes.
11076         * osdata.c: Fix common/ includes.
11077         * obsd-nat.c: Fix common/ includes.
11078         * nat/x86-linux.c: Fix common/ includes.
11079         * nat/x86-linux-dregs.c: Fix common/ includes.
11080         * nat/x86-dregs.h: Fix common/ includes.
11081         * nat/x86-dregs.c: Fix common/ includes.
11082         * nat/ppc-linux.c: Fix common/ includes.
11083         * nat/mips-linux-watch.h: Fix common/ includes.
11084         * nat/mips-linux-watch.c: Fix common/ includes.
11085         * nat/linux-waitpid.c: Fix common/ includes.
11086         * nat/linux-ptrace.h: Fix common/ includes.
11087         * nat/linux-ptrace.c: Fix common/ includes.
11088         * nat/linux-procfs.c: Fix common/ includes.
11089         * nat/linux-personality.c: Fix common/ includes.
11090         * nat/linux-osdata.c: Fix common/ includes.
11091         * nat/linux-namespaces.c: Fix common/ includes.
11092         * nat/linux-btrace.h: Fix common/ includes.
11093         * nat/linux-btrace.c: Fix common/ includes.
11094         * nat/fork-inferior.c: Fix common/ includes.
11095         * nat/amd64-linux-siginfo.c: Fix common/ includes.
11096         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
11097         * nat/aarch64-linux.c: Fix common/ includes.
11098         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
11099         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
11100         * namespace.h: Fix common/ includes.
11101         * mips-linux-tdep.c: Fix common/ includes.
11102         * minsyms.c: Fix common/ includes.
11103         * mi/mi-parse.h: Fix common/ includes.
11104         * mi/mi-main.c: Fix common/ includes.
11105         * mi/mi-cmd-env.c: Fix common/ includes.
11106         * memrange.h: Fix common/ includes.
11107         * memattr.c: Fix common/ includes.
11108         * maint.h: Fix common/ includes.
11109         * maint.c: Fix common/ includes.
11110         * main.c: Fix common/ includes.
11111         * machoread.c: Fix common/ includes.
11112         * location.c: Fix common/ includes.
11113         * linux-thread-db.c: Fix common/ includes.
11114         * linux-nat.c: Fix common/ includes.
11115         * linux-fork.c: Fix common/ includes.
11116         * inline-frame.c: Fix common/ includes.
11117         * infrun.c: Fix common/ includes.
11118         * inflow.c: Fix common/ includes.
11119         * inferior.h: Fix common/ includes.
11120         * inferior.c: Fix common/ includes.
11121         * infcmd.c: Fix common/ includes.
11122         * inf-ptrace.c: Fix common/ includes.
11123         * inf-child.c: Fix common/ includes.
11124         * ia64-linux-nat.c: Fix common/ includes.
11125         * i387-tdep.c: Fix common/ includes.
11126         * i386-tdep.c: Fix common/ includes.
11127         * i386-linux-tdep.c: Fix common/ includes.
11128         * i386-linux-nat.c: Fix common/ includes.
11129         * i386-go32-tdep.c: Fix common/ includes.
11130         * i386-fbsd-tdep.c: Fix common/ includes.
11131         * i386-fbsd-nat.c: Fix common/ includes.
11132         * guile/scm-type.c: Fix common/ includes.
11133         * guile/guile.c: Fix common/ includes.
11134         * go32-nat.c: Fix common/ includes.
11135         * gnu-nat.c: Fix common/ includes.
11136         * gdbthread.h: Fix common/ includes.
11137         * gdbarch-selftests.c: Fix common/ includes.
11138         * gdb_usleep.c: Fix common/ includes.
11139         * gdb_select.h: Fix common/ includes.
11140         * gdb_bfd.c: Fix common/ includes.
11141         * gcore.c: Fix common/ includes.
11142         * fork-child.c: Fix common/ includes.
11143         * findvar.c: Fix common/ includes.
11144         * fbsd-nat.c: Fix common/ includes.
11145         * event-top.c: Fix common/ includes.
11146         * event-loop.c: Fix common/ includes.
11147         * dwarf2read.c: Fix common/ includes.
11148         * dwarf2loc.c: Fix common/ includes.
11149         * dwarf2-frame.c: Fix common/ includes.
11150         * dwarf-index-cache.c: Fix common/ includes.
11151         * dtrace-probe.c: Fix common/ includes.
11152         * disasm-selftests.c: Fix common/ includes.
11153         * defs.h: Fix common/ includes.
11154         * csky-tdep.c: Fix common/ includes.
11155         * cp-valprint.c: Fix common/ includes.
11156         * cp-support.h: Fix common/ includes.
11157         * cp-support.c: Fix common/ includes.
11158         * corelow.c: Fix common/ includes.
11159         * completer.h: Fix common/ includes.
11160         * completer.c: Fix common/ includes.
11161         * compile/compile.c: Fix common/ includes.
11162         * compile/compile-loc2c.c: Fix common/ includes.
11163         * compile/compile-cplus-types.c: Fix common/ includes.
11164         * compile/compile-cplus-symbols.c: Fix common/ includes.
11165         * command.h: Fix common/ includes.
11166         * cli/cli-dump.c: Fix common/ includes.
11167         * cli/cli-cmds.c: Fix common/ includes.
11168         * charset.c: Fix common/ includes.
11169         * build-id.c: Fix common/ includes.
11170         * btrace.h: Fix common/ includes.
11171         * btrace.c: Fix common/ includes.
11172         * breakpoint.h: Fix common/ includes.
11173         * breakpoint.c: Fix common/ includes.
11174         * ax.h:
11175         (enum agent_op): Fix common/ includes.
11176         * ax-general.c (struct aop_map): Fix common/ includes.
11177         * ax-gdb.c: Fix common/ includes.
11178         * auxv.c: Fix common/ includes.
11179         * auto-load.c: Fix common/ includes.
11180         * arm-tdep.c: Fix common/ includes.
11181         * arch/riscv.c: Fix common/ includes.
11182         * arch/ppc-linux-common.c: Fix common/ includes.
11183         * arch/i386.c: Fix common/ includes.
11184         * arch/arm.c: Fix common/ includes.
11185         * arch/arm-linux.c: Fix common/ includes.
11186         * arch/arm-get-next-pcs.c: Fix common/ includes.
11187         * arch/amd64.c: Fix common/ includes.
11188         * arch/aarch64.c: Fix common/ includes.
11189         * arch/aarch64-insn.c: Fix common/ includes.
11190         * arch-utils.c: Fix common/ includes.
11191         * amd64-windows-tdep.c: Fix common/ includes.
11192         * amd64-tdep.c: Fix common/ includes.
11193         * amd64-sol2-tdep.c: Fix common/ includes.
11194         * amd64-obsd-tdep.c: Fix common/ includes.
11195         * amd64-nbsd-tdep.c: Fix common/ includes.
11196         * amd64-linux-tdep.c: Fix common/ includes.
11197         * amd64-linux-nat.c: Fix common/ includes.
11198         * amd64-fbsd-tdep.c: Fix common/ includes.
11199         * amd64-fbsd-nat.c: Fix common/ includes.
11200         * amd64-dicos-tdep.c: Fix common/ includes.
11201         * amd64-darwin-tdep.c: Fix common/ includes.
11202         * agent.c: Fix common/ includes.
11203         * ada-lang.h: Fix common/ includes.
11204         * ada-lang.c: Fix common/ includes.
11205         * aarch64-tdep.c: Fix common/ includes.
11206
11207 2019-01-25  Tom Tromey  <tom@tromey.com>
11208
11209         * common/create-version.sh: Use common/version.h.
11210
11211 2019-01-24  Pedro Alves  <palves@redhat.com>
11212
11213         * infrun.c (signal_stop, signal_print, signal_program)
11214         (signal_catch, signal_pass): Now arrays instead of pointers.
11215         (update_signals_program_target, do_target_resume)
11216         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
11217         * linux-nat.c (linux_nat_target::pass_signals)
11218         (linux_nat_target::create_inferior, linux_nat_target::attach):
11219         Adjust.
11220         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
11221         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
11222         * procfs.c (procfs_target::pass_signals): Adjust.
11223         * record-full.c (record_full_target::resume): Adjust.
11224         * remote.c (remote_target::pass_signals)
11225         (remote_target::program_signals): Adjust.
11226         * target-debug.h (target_debug_print_signals): Now takes a
11227         gdb::array_view as parameter.  Adjust.
11228         * target.h (target_ops) <pass_signals, program_signals>: Replace
11229         pointer and length parameters with gdb::array_view.
11230         (target_pass_signals, target_program_signals): Likewise.
11231         * target-delegates.c: Regenerate.
11232
11233 2019-01-24  Pedro Alves  <palves@redhat.com>
11234
11235         * common/forward-scope-exit.h
11236         (forward_scope_exit::forward_scope_exit): Pass arguments to
11237         m_bind_function directly, instead of creating a std::bind and
11238         copying that.
11239
11240 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
11241
11242         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11243         for static members.
11244         (pass_in_v_vfp_candidate): Likewise.
11245
11246 2019-01-23  Tom Tromey  <tom@tromey.com>
11247             Pedro Alves  <palves@redhat.com>
11248
11249         * regcache.c (class regcache_invalidator): Remove.
11250         (regcache::raw_write): Use make_scope_exit.
11251
11252 2019-01-23  Tom Tromey  <tom@tromey.com>
11253
11254         * ui-out.h (class ui_out_emit_type): Update comment.
11255
11256 2019-01-23  Tom Tromey  <tom@tromey.com>
11257
11258         * infrun.c (fetch_inferior_event): Update comment.
11259
11260 2019-01-23  Tom Tromey  <tom@tromey.com>
11261             Pedro Alves  <palves@redhat.com>
11262
11263         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
11264         parameter.
11265         (fetch_inferior_event): Use SCOPE_EXIT.
11266
11267
11268 2019-01-23  Tom Tromey  <tom@tromey.com>
11269             Pedro Alves  <palves@redhat.com>
11270
11271         * infrun.c (disable_thread_events): Delete.
11272         (stop_all_threads): Use SCOPE_EXIT.
11273
11274 2019-01-23  Tom Tromey  <tom@tromey.com>
11275             Pedro Alves  <palves@redhat.com>
11276
11277         * symfile.c: Include forward-scope-exit.h.
11278         (clear_symtab_users_cleanup): Replace forward declaration with
11279         a FORWARD_SCOPE_EXIT.
11280         (syms_from_objfile_1): Use the forward_scope_exit and
11281         gdb::optional instead of cleanup_function.
11282         (reread_symbols): Use the forward_scope_exit instead of
11283         cleanup_function.
11284         (clear_symtab_users_cleanup): Remove function.
11285
11286 2019-01-23  Tom Tromey  <tom@tromey.com>
11287             Pedro Alves  <palves@redhat.com>
11288
11289         * linux-nat.c: Include scope-exit.h.
11290         (cleanup_target_stop): Remove.
11291         (linux_nat_target::static_tracepoint_markers_by_strid): Use
11292         SCOPE_EXIT.
11293
11294 2019-01-23  Tom Tromey  <tom@tromey.com>
11295             Pedro Alves  <palves@redhat.com>
11296
11297         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
11298         (call_function_by_hand_dummy): Use SCOPE_EXIT.
11299
11300 2019-01-23  Tom Tromey  <tom@tromey.com>
11301             Andrew Burgess  <andrew.burgess@embecosm.com>
11302             Pedro Alves  <palves@redhat.com>
11303
11304         * infrun.c (fetch_inferior_event): Use scope_exit.
11305         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
11306         * top.c (execute_command): Use scope_exit.
11307         * breakpoint.c (bpstat_do_actions): Use scope_exit.
11308         * utils.c (do_bpstat_clear_actions_cleanup)
11309         (make_bpstat_clear_actions_cleanup): Remove.
11310
11311 2019-01-23  Tom Tromey  <tom@tromey.com>
11312             Pedro Alves  <palves@redhat.com>
11313
11314         * infrun.c: Include "common/scope-exit.h"
11315         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
11316         (wait_for_inferior): Use SCOPE_EXIT.
11317         (fetch_inferior_event): Use scope_exit.
11318
11319 2019-01-23  Tom Tromey  <tom@tromey.com>
11320             Pedro Alves  <palves@redhat.com>
11321
11322         * breakpoint.c (create_breakpoint): Remove cleanup.
11323
11324 2019-01-23  Tom Tromey  <tom@tromey.com>
11325             Andrew Burgess  <andrew.burgess@embecosm.com>
11326             Pedro Alves  <palves@redhat.com>
11327
11328 2019-01-23  Pedro Alves  <palves@redhat.com>
11329
11330         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
11331
11332 2019-01-23  Pedro Alves  <palves@redhat.com>
11333             Andrew Burgess  <andrew.burgess@embecosm.com>
11334
11335         * gdbthread.h: Include "common/forward-scope-exit.h".
11336         (scoped_finish_thread_state): Redefine custom class in terms of
11337         forward_scope_exit.
11338
11339 2019-01-23  Pedro Alves  <palves@redhat.com>
11340             Andrew Burgess  <andrew.burgess@embecosm.com>
11341
11342         * common/forward-scope-exit.h: New file.
11343
11344 2019-01-23  Pedro Alves  <palves@redhat.com>
11345             Andrew Burgess  <andrew.burgess@embecosm.com>
11346             Tom Tromey  <tom@tromey.com>
11347
11348         * common/scope-exit.h: New file.
11349
11350 2019-01-23  Pedro Alves  <palves@redhat.com>
11351
11352         * common/preprocessor.h (ESC): Rename to ...
11353         (ESC_PARENS): ... this.
11354         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
11355         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
11356
11357 2019-01-23  Tom Tromey  <tom@tromey.com>
11358
11359         * language.h (class scoped_switch_to_sym_language_if_auto):
11360         Initialize m_lang in both cases.
11361
11362 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
11363
11364         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
11365         with XCNEW.
11366
11367 2019-01-22  Tom Tromey  <tom@tromey.com>
11368
11369         * corelow.c: Do not include sys/file.h.
11370
11371 2019-01-22  Tom Tromey  <tom@tromey.com>
11372
11373         * tui/tui-wingeneral.h: Include gdb_curses.h.
11374
11375 2019-01-22  Tom Tromey  <tom@tromey.com>
11376
11377         * source-cache.h (class source_cache) <get_source_lines,
11378         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
11379
11380 2019-01-22  Tom Tromey  <tom@tromey.com>
11381
11382         * remote-fileio.h (struct remote_target): Declare.
11383
11384 2019-01-22  Tom Tromey  <tom@tromey.com>
11385
11386         * python/py-arch.c: Do not include py-ref.h.
11387         * python/py-bpevent.c: Do not include py-ref.h.
11388         * python/py-cmd.c: Do not include py-ref.h.
11389         * python/py-continueevent.c: Do not include py-ref.h.
11390         * python/py-event.h: Do not include py-ref.h.
11391         * python/py-evtregistry.c: Do not include py-ref.h.
11392         * python/py-finishbreakpoint.c: Do not include py-ref.h.
11393         * python/py-frame.c: Do not include py-ref.h.
11394         * python/py-framefilter.c: Do not include py-ref.h.
11395         * python/py-function.c: Do not include py-ref.h.
11396         * python/py-infevents.c: Do not include py-ref.h.
11397         * python/py-linetable.c: Do not include py-ref.h.
11398         * python/py-objfile.c: Do not include py-ref.h.
11399         * python/py-param.c: Do not include py-ref.h.
11400         * python/py-prettyprint.c: Do not include py-ref.h.
11401         * python/py-progspace.c: Do not include py-ref.h.
11402         * python/py-symbol.c: Do not include py-ref.h.
11403         * python/py-symtab.c: Do not include py-ref.h.
11404         * python/py-type.c: Do not include py-ref.h.
11405         * python/py-unwind.c: Do not include py-ref.h.
11406         * python/py-utils.c: Do not include py-ref.h.
11407         * python/py-value.c: Do not include py-ref.h.
11408         * python/py-varobj.c: Do not include py-ref.h.
11409         * python/py-xmethods.c: Do not include py-ref.h.
11410         * python/python.c: Do not include py-ref.h.
11411         * varobj.c: Do not include py-ref.h.
11412
11413 2019-01-22  Tom Tromey  <tom@tromey.com>
11414
11415         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
11416         keyword for bcache.
11417
11418 2019-01-22  Tom Tromey  <tom@tromey.com>
11419
11420         * compile/compile-cplus-types.c: Remove a comment by #include.
11421
11422 2019-01-22  Tom Tromey  <tom@tromey.com>
11423
11424         * compile/gcc-c-plugin.h: Include compile-internal.h.
11425
11426 2019-01-22  Tom Tromey  <tom@tromey.com>
11427
11428         * stabsread.c (EXTERN): Do not define.
11429         (symnum, next_symbol_text_func, processing_gcc_compilation)
11430         (within_function, global_sym_chain, global_stabs)
11431         (previous_stab_code, this_object_header_files)
11432         (n_this_object_header_files)
11433         (n_allocated_this_object_header_files): Define.
11434         * stabsread.h (EXTERN): Never define.  Use "extern".
11435
11436 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11437
11438         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
11439         history_value.
11440
11441 2019-01-21  Tom Tromey  <tom@tromey.com>
11442
11443         * ui-out.c: Fix includes.
11444         * tui/tui-source.c: Fix includes.
11445         * target.c: Fix includes.
11446         * remote.c: Fix includes.
11447         * regcache.c: Fix includes.
11448         * python/py-block.c: Fix includes.
11449         * printcmd.c: Fix includes.
11450         * or1k-tdep.c: Fix includes.
11451         * mi/mi-main.c: Fix includes.
11452         * m32r-tdep.c: Fix includes.
11453         * csky-tdep.c: Fix includes.
11454         * compile/compile-cplus-types.c: Fix includes.
11455         * cli/cli-interp.c: Fix includes.
11456
11457 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
11458
11459         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11460         for padding.
11461
11462 2019-01-16  Tom Tromey  <tom@tromey.com>
11463
11464         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
11465         earlier.
11466         (struct objfile) <msymbols_range>: Move from top level.
11467         <msymbols>: New method.
11468         (class objfile_msymbols): Remove.
11469         * symtab.c (default_collect_symbol_completion_matches_break_on):
11470         Update.
11471         * symmisc.c (dump_msymbols): Update.
11472         * stabsread.c (scan_file_globals): Update.
11473         * objc-lang.c (info_selectors_command, info_classes_command)
11474         (find_methods): Update.
11475         * minsyms.c (find_solib_trampoline_target): Update.
11476         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
11477         * coffread.c (coff_symfile_read): Update.
11478         * ada-lang.c (ada_lookup_simple_minsym)
11479         (ada_collect_symbol_completion_matches): Update.
11480
11481 2019-01-16  Tom Tromey  <tom@tromey.com>
11482
11483         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
11484         type.  Remove no-argument constructor.
11485         <iterator::operator++>: Simplify.
11486         <begin>: Update.
11487         <end>: Use minimal_symbol_count.
11488
11489 2019-01-16  Tom Tromey  <tom@tromey.com>
11490
11491         * objfiles.h (struct objfile) <psymtabs>: New method.
11492         (class objfile_psymtabs): Remove.
11493         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
11494         typedef.
11495         <range>: New method.
11496         (require_partial_symbols): Change return type.
11497         * psymtab.c (require_partial_symbols)
11498         (psym_expand_symtabs_matching): Update.
11499         * mdebugread.c (parse_partial_symbols): Update.
11500         * dbxread.c (dbx_end_psymtab): Update.
11501
11502 2019-01-15  Tom Tromey  <tom@tromey.com>
11503
11504         * symtab.c (lookup_objfile_from_block)
11505         (lookup_symbol_in_objfile_symtabs)
11506         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
11507         (find_line_symtab, info_sources_command)
11508         (default_collect_symbol_completion_matches_break_on)
11509         (make_source_files_completion_list): Update.
11510         * symmisc.c (print_objfile_statistics, dump_objfile)
11511         (maintenance_print_symbols, maintenance_info_symtabs)
11512         (maintenance_check_symtabs, maintenance_info_line_tables):
11513         Update.
11514         * source.c (select_source_symtab)
11515         (forget_cached_source_info_for_objfile): Update.
11516         * objfiles.h (class objfile_compunits): Remove.
11517         (struct objfile) <compunits_range>: New typedef.
11518         (compunits): New method.
11519         * objfiles.c (objfile_relocate1): Update.
11520         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11521         * maint.c (count_symtabs_and_blocks): Update.
11522         * linespec.c (iterate_over_all_matching_symtabs): Update.
11523         * cp-support.c (add_symbol_overload_list_qualified): Update.
11524         * coffread.c (coff_symtab_read): Update.
11525         * ada-lang.c (add_nonlocal_symbols)
11526         (ada_collect_symbol_completion_matches)
11527         (ada_add_global_exceptions): Update.
11528
11529 2019-01-15  Tom Tromey  <tom@tromey.com>
11530
11531         * progspace.h (program_space) <objfiles_safe_range>: New
11532         typedef.
11533         <objfiles_safe>: New method.
11534         * objfiles.h (class all_objfiles_safe): Remove.
11535         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
11536         * jit.c (jit_inferior_exit_hook): Update.
11537
11538 2019-01-17  Tom Tromey  <tom@tromey.com>
11539
11540         * progspace.h (program_space) <objfiles_range>: New typedef.
11541         <objfiles>: New method.
11542         <objfiles_head>: Rename from objfiles.
11543         (object_files): Update.
11544         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
11545         * guile/scm-pretty-print.c
11546         (ppscm_find_pretty_printer_from_objfiles): Update.
11547         * guile/scm-objfile.c (gdbscm_objfiles): Update.
11548         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
11549         Update.
11550         * python/py-progspace.c (pspy_get_objfiles): Update.
11551         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11552         Update.
11553         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11554         (objfpy_lookup_objfile_by_build_id): Update.
11555         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11556         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11557         Update.
11558         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11559         (expand_symtab_containing_pc, lookup_objfile_from_block)
11560         (lookup_static_symbol, basic_lookup_transparent_type)
11561         (find_pc_sect_compunit_symtab, find_symbol_at_address)
11562         (find_line_symtab, info_sources_command)
11563         (default_collect_symbol_completion_matches_break_on)
11564         (make_source_files_completion_list, find_main_name): Update.
11565         * symmisc.c (print_symbol_bcache_statistics)
11566         (print_objfile_statistics, maintenance_print_symbols)
11567         (maintenance_print_msymbols, maintenance_print_objfiles)
11568         (maintenance_info_symtabs, maintenance_check_symtabs)
11569         (maintenance_expand_symtabs, maintenance_info_line_tables):
11570         Update.
11571         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
11572         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
11573         (map_overlay_command, unmap_overlay_command)
11574         (simple_overlay_update, expand_symtabs_matching)
11575         (map_symbol_filenames): Update.
11576         * symfile-debug.c (set_debug_symfile): Update.
11577         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
11578         Update.
11579         * source.c (select_source_symtab, forget_cached_source_info):
11580         Update.
11581         * solib.c (solib_read_symbols): Update.
11582         * solib-spu.c (append_ocl_sos): Update.
11583         * psymtab.c (maintenance_print_psymbols)
11584         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
11585         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
11586         * printcmd.c (info_symbol_command): Update.
11587         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
11588         Update.
11589         * objfiles.h (class all_objfiles): Remove.
11590         * objfiles.c (have_partial_symbols, have_full_symbols)
11591         (have_minimal_symbols, qsort_cmp, update_section_map)
11592         (shared_objfile_contains_address_p)
11593         (default_iterate_over_objfiles_in_search_order): Update.
11594         * objc-lang.c (info_selectors_command, info_classes_command)
11595         (find_methods): Update.
11596         * minsyms.c (find_solib_trampoline_target): Update.
11597         * maint.c (maintenance_info_sections)
11598         (maintenance_translate_address, count_symtabs_and_blocks):
11599         Update.
11600         * main.c (captured_main_1): Update.
11601         * linux-thread-db.c (try_thread_db_load_from_pdir)
11602         (has_libpthread): Update.
11603         * linespec.c (iterate_over_all_matching_symtabs)
11604         (search_minsyms_for_name): Update.
11605         * jit.c (jit_find_objf_with_entry_addr): Update.
11606         * hppa-tdep.c (find_unwind_entry)
11607         (hppa_lookup_stub_minimal_symbol): Update.
11608         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
11609         Update.
11610         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11611         (elf_gnu_ifunc_resolve_by_got): Update.
11612         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
11613         * dwarf-index-write.c (save_gdb_index_command): Update.
11614         * cp-support.c (add_symbol_overload_list_qualified): Update.
11615         * breakpoint.c (create_overlay_event_breakpoint)
11616         (create_longjmp_master_breakpoint)
11617         (create_std_terminate_master_breakpoint)
11618         (create_exception_master_breakpoint): Update.
11619         * blockframe.c (find_pc_partial_function): Update.
11620         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
11621         (ada_collect_symbol_completion_matches)
11622         (ada_add_global_exceptions): Update.
11623
11624 2019-01-17  Tom Tromey  <tom@tromey.com>
11625
11626         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
11627         declare VEC.
11628         (solib_target_parse_libraries): Change return type.
11629         (library_list_start_segment, library_list_start_section)
11630         (library_list_end_library, library_list_start_library); Update.
11631         (solib_target_free_library_list): Remove.
11632         (solib_target_parse_libraries): Remove cleanup.  Change return
11633         type.
11634         (solib_target_current_sos): Update.
11635
11636 2019-01-17  Tom Tromey  <tromey@bapiya>
11637
11638         * valprint.c: Replace "the the" with "the".
11639         * symtab.c: Replace "the the" with "the".
11640         * solib.c: Replace "the the" with "the".
11641         * solib-dsbt.c: Replace "the the" with "the".
11642         * linespec.c: Replace "the the" with "the".
11643         * dwarf2loc.h: Replace "the the" with "the".
11644         * amd64-windows-tdep.c: Replace "the the" with "the".
11645         * aarch64-tdep.c: Replace "the the" with "the".
11646
11647 2019-01-16  Keith Seitz  <keiths@redhat.com>
11648
11649         PR gdb/23773
11650         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
11651         <builder>: Rename to ..
11652         <m_builder>: ... this and make private.
11653         (dwarf2_cu::get_builder): New method.  Change all users of
11654         `builder' to use this method.
11655         (dwarf2_start_symtab): Move to ...
11656         (dwarf2_cu::start_symtab): ... here.  Update all callers
11657         (setup_type_unit_groups): Move to ...
11658         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
11659         callers.
11660         (dwarf2_cu::reset_builder): New method.
11661         (process_full_compunit, process_full_type_unit): Use
11662         dwarf2_cu::reset_builder.
11663         (follow_die_offset): Record the ancestor CU if it is different
11664         from the followed DIE's CU.
11665         (follow_die_sig_1): Likewise.
11666
11667 2019-01-15  Tom Tromey  <tom@tromey.com>
11668
11669         * remote.c (class remote_state) <buf>: Now a char_vector.
11670         <buf_size>: Remove.
11671         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
11672         parameter.
11673         (remote_target::getpkt_or_notif_sane_1)
11674         (remote_target::getpkt_sane)
11675         (remote_target::getpkt_or_notif_sane): Likewise.
11676         (class remote_target) <putpkt>: New overload.
11677         (remote_target::read_frame): Change type of "buf_p".  Remove
11678         sizeof_p parameter.
11679         (packet_ok): New overload.
11680         (packet_check_result): New overload.
11681         Update all uses.
11682
11683 2019-01-14  Tom Tromey  <tom@tromey.com>
11684
11685         * remote-notif.c (handle_notification, remote_notif_ack)
11686         (remote_notif_parse): Make "buf" const.
11687         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
11688         const.
11689         (remote_notif_parse, remote_notif_ack, handle_notification):
11690         Likewise.
11691         * remote.c (remote_notif_stop_parse): Make "buf" const.
11692         (remote_target::remote_parse_stop_reply): Make "buf" const.
11693         (remote_notif_stop_ack): Make "buf" const.
11694
11695 2019-01-14  Tom Tromey  <tom@tromey.com>
11696
11697         * remote.c (remote_console_output): Make parameter const.
11698
11699 2019-01-14  Tom Tromey  <tom@tromey.com>
11700
11701         * target-debug.h (target_debug_print_signals): Constify.
11702         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
11703         * procfs.c (procfs_target::pass_signals): Update.
11704         * linux-nat.c (linux_nat_target::pass_signals): Update.
11705         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
11706         * target-delegates.c: Rebuild.
11707         * remote.c (remote_target::program_signals): Update.
11708         (remote_target::pass_signals): Update.
11709         * target.c (target_pass_signals): Constify argument.
11710         (target_program_signals): Likewise.
11711         * target.h (struct target_ops) <pass_signals, program_signals>:
11712         Constify argument.
11713         (target_pass_signals, target_program_signals): Constify argument.
11714
11715 2019-01-14  Tom Tromey  <tom@tromey.com>
11716
11717         PR tui/28819:
11718         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
11719
11720 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
11721
11722         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
11723         field.
11724         * rs6000-tdep.c: Include reggroups.h.
11725         (IS_V_ALIAS_PSEUDOREG): Define.
11726         (rs6000_register_name): Return names for the "vX" aliases.
11727         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
11728         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
11729         aliases.  Call default_register_reggroup_p for all other
11730         pseudo-registers.
11731         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
11732         New functions.
11733         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
11734         Handle "vX" aliases.
11735         (v_alias_pseudo_register_collect): New function.
11736         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
11737         (rs6000_gdbarch_init): Initialize "vX" aliases as
11738         pseudo-registers.  Restore registration of
11739         rs6000_pseudo_register_reggroup_p with
11740         set_tdesc_pseudo_register_reggroup_p.
11741
11742 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
11743
11744         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
11745         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
11746         set_gdbarch_num_pseudo_regs.
11747
11748 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11749
11750         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
11751         Remove arg prefixname, add do_set and do_show.
11752         Add member functions set_list and show_list.
11753         * cli/cli-style.c (class cli_style_option): Update accordingly.
11754         (style_set_list): Move to file scope.
11755         (style_show_list): Likewise.
11756         (set_style): Call help_list.
11757         (show_style): Call cmd_show_list.
11758         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
11759         Update to use the new macro.
11760
11761 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
11762
11763         * ada-lang.c (_initialize_ada_language): Expand the help text
11764         for the "catch exception" command.
11765
11766 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11767
11768         * symtab.c (matching_obj_sections): Initialize obj,
11769         declare it closer to its usage.
11770
11771 2019-01-10  Tom Tromey  <tom@tromey.com>
11772
11773         * thread-iter.h (inf_threads_iterator): Use next_iterator.
11774         (basic_inf_threads_range): Remove.
11775         (inf_threads_range, inf_non_exited_threads_range)
11776         (safe_inf_threads_range): Use next_adapter.
11777
11778 2019-01-10  Keith Seitz  <keiths@redhat.com>
11779
11780         PR gdb/23712
11781         PR symtab/23010
11782         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
11783         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
11784
11785 2019-01-10  Keith Seitz  <keiths@redhat.com>
11786
11787         PR gdb/23712
11788         PR symtab/23010
11789         * dictionary.c (pending_to_vector): Remove.
11790         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11791         Remove _1 suffix, replacing functions of the same name.  Update
11792         all callers.
11793         (dict_create_hashed, dict_create_hashed_expandable)
11794         (dict_create_linear, dict_create_linear_expandable, dict_free)
11795         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
11796         Make functions static.
11797
11798 2019-01-10  Keith Seitz  <keiths@redhat.com>
11799
11800         PR gdb/23712
11801         PR symtab/23010
11802         * dictionary.h (struct dictionary): Replace declaration with
11803         multidictionary.
11804         (dict_create_hashed, dict_create_hashed_expandable)
11805         (dict_create_linear, dict_create_linear_expandable)
11806         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
11807         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
11808         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
11809         taking multidictionary argument.
11810         [ALL_DICT_SYMBOLS]: Update for multidictionary.
11811         * block.h (struct block) <dict>: Change to multidictionary
11812         and rename `multidict'.
11813         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
11814         symmisc.c: Update all dictionary references to multidictionary.
11815
11816 2019-01-10  Keith Seitz  <keiths@redhat.com>
11817
11818         PR gdb/23712
11819         PR symtab/23010
11820         * dictionary.c: Include unordered_map.
11821         (pending_to_vector): New function.
11822         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11823         Rewrite the non-"_1" functions to take vector instead
11824         of linked list.
11825         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
11826         "new" _1 versions of the same name.
11827         (multidictionary): Define.
11828         (std::hash<enum language): New definition.
11829         (collate_pending_symbols_by_language, mdict_create_hashed)
11830         (mdict_create_hashed_expandable, mdict_create_linear)
11831         (mdict_create_linear_expandable, mdict_free)
11832         (find_language_dictionary, create_new_language_dictionary)
11833         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
11834         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
11835         (mdict_size, mdict_empty): New functions.
11836         * dictionary.h (mdict_iterator): Define.
11837
11838 2019-01-10  Pedro Alves  <palves@redhat.com>
11839
11840         * breakpoint.c (read_uploaded_action)
11841         (create_tracepoint_from_upload): Adjust to use
11842         gdb::unique_xmalloc_ptr.
11843         * ctf.c (ctf_write_uploaded_tp):
11844         (SET_ARRAY_FIELD): Use emplace_back.
11845         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
11846         * tracefile-tfile.c (tfile_write_uploaded_tp):
11847         * tracepoint.c (parse_tracepoint_definition): Adjust to use
11848         gdb::unique_xmalloc_ptr.
11849         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
11850         at_string, cond_string, cmd_strings>: Replace char pointers
11851         with gdb::unique_xmalloc_ptr.
11852
11853 2019-01-10  Pedro Alves  <palves@redhat.com>
11854
11855         * solib-target.c (library_list_start_library): Don't xstrdup name.
11856
11857 2019-01-10  Pedro Alves  <palves@redhat.com>
11858
11859         * mdebugread.c (parse_partial_symbols): Use
11860         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
11861
11862 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11863
11864         * linux-fork.c (scoped_switch_fork_info)
11865         <~scoped_switch_fork_info>: Fix incorrect variable name.
11866
11867 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11868
11869         * linux-fork.c (scoped_switch_fork_info)
11870         <scoped_switch_fork_info>: Make explicit.
11871         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
11872
11873 2019-01-10  Tom Tromey  <tom@tromey.com>
11874
11875         * objfiles.h (objfile::reset_psymtabs): Update.
11876         * objfiles.c (objfile::objfile): Update.
11877         * psymtab.h (psymtab_storage::obstack): Update.
11878         (psymtab_storage::m_obstack): Use gdb::optional.
11879         (class psymtab_storage): Update comment.  Remove objfile
11880         parameter.
11881         * psymtab.c (psymtab_storage::psymtab_storage): Update.
11882
11883 2019-01-10  Tom Tromey  <tom@tromey.com>
11884
11885         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
11886         <free_psymtabs>: Now private.
11887         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
11888         (allocate_psymtab): Use new method.
11889
11890 2019-01-10  Tom Tromey  <tom@tromey.com>
11891
11892         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
11893         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
11894         * mdebugread.c (parse_partial_symbols): Use
11895         allocate_dependencies.
11896         * dwarf2read.c (dwarf2_create_include_psymtab): Use
11897         allocate_dependencies.
11898         (process_psymtab_comp_unit_reader)
11899         (build_type_psymtab_dependencies): Likewise.
11900         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
11901
11902 2019-01-10  Tom Tromey  <tom@tromey.com>
11903
11904         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
11905         PSYMBOL_SET_LANGUAGE.
11906         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
11907
11908 2019-01-10  Tom Tromey  <tom@tromey.com>
11909
11910         * psymtab.h (psymtab_storage::obstack): New method.
11911         <m_obstack>: Rename from obstack; now private.
11912         * psymtab.c (psymtab_storage): Update.
11913         * dwarf2read.c (create_addrmap_from_index)
11914         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
11915         Update.
11916
11917 2019-01-10  Tom Tromey  <tom@tromey.com>
11918
11919         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
11920         * objfiles.h (objfile::reset_psymtabs): New method.
11921
11922 2019-01-10  Tom Tromey  <tom@tromey.com>
11923
11924         * symmisc.c (print_symbol_bcache_statistics): Update.
11925         (print_objfile_statistics): Update.
11926         * symfile.c (reread_symbols): Update.
11927         * psymtab.h (class psymtab_storage): New.
11928         * psymtab.c (psymtab_storage): New constructor.
11929         (~psymtab_storage): New destructor.
11930         (require_partial_symbols): Update.
11931         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11932         (find_pc_sect_psymtab, find_pc_sect_psymbol)
11933         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11934         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11935         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
11936         (start_psymtab_common, end_psymtab_common)
11937         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
11938         (allocate_psymtab): Update.
11939         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
11940         Update.
11941         (dump_psymtab_addrmap, maintenance_print_psymbols)
11942         (maintenance_check_psymtabs): Update.
11943         (class objfile_psymtabs): Move to objfiles.h.
11944         * psympriv.h (discard_psymtab): Now inline.
11945         (psymtab_discarder::psymtab_discarder): Update.
11946         (psymtab_discarder::~psymtab_discarder): Update.
11947         (ALL_OBJFILE_PSYMTABS): Rewrite.
11948         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11949         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11950         Remove fields.
11951         <partial_symtabs>: New field.
11952         (class objfile_psymtabs): Move from psymtab.h.  Update.
11953         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11954         psymbol_cache.
11955         (objfile::~objfile): Don't destroy psymbol_cache.
11956         * mdebugread.c (parse_partial_symbols): Update.
11957         * dwarf2read.c (create_addrmap_from_index)
11958         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11959         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11960         (add_partial_subprogram, dwarf2_ranges_read): Update.
11961         * dwarf-index-write.c (write_address_map)
11962         (write_one_signatured_type, recursively_write_psymbols)
11963         (class debug_names, class debug_names, write_psymtabs_to_index):
11964         Update.
11965
11966 2019-01-10  Tom Tromey  <tom@tromey.com>
11967
11968         * symtab.h (SYMBOL_SET_NAMES): Update.
11969         (symbol_set_names): Update.
11970         (MSYMBOL_SET_NAMES): Update.
11971         * symtab.c (symbol_set_names): Change argument to be an
11972         objfile_per_bfd_storage.
11973         * psymtab.c (add_psymbol_to_bcache): Update.
11974         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11975
11976 2019-01-10  Tom Tromey  <tom@tromey.com>
11977
11978         * symtab.c (create_demangled_names_hash): Change argument to be an
11979         objfile_per_bfd_storage.
11980         (symbol_set_names): Update.
11981
11982 2019-01-10  Tom Tromey  <tom@tromey.com>
11983
11984         * xcoffread.c (xcoff_initial_scan): Unconditionally call
11985         init_psymbol_list.
11986         * psymtab.c (init_psymbol_list): Do nothing if already called.
11987         * psympriv.h (init_psymbol_list): Add comment.
11988         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11989         init_psymbol_list.
11990         * dbxread.c (dbx_symfile_read): Unconditionally call
11991         init_psymbol_list.
11992
11993 2019-01-10  Tom Tromey  <tom@tromey.com>
11994
11995         * xcoffread.c (scan_xcoff_symtab): Update.
11996         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11997         "where".
11998         * mdebugread.c (parse_partial_symbols)
11999         (handle_psymbol_enumerators): Update.
12000         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
12001         * dbxread.c (read_dbx_symtab): Update.
12002         * psympriv.h (psymbol_placement): New enum.
12003         (add_psymbol_to_list): Update.
12004
12005 2019-01-10  Tom Tromey  <tom@tromey.com>
12006
12007         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
12008         static_psymbols parameters.
12009         (scan_xcoff_symtab): Update.
12010         * psymtab.c (start_psymtab_common): Remove global_psymbols and
12011         static_psymbols parameters.
12012         * psympriv.h (start_psymtab_common): Update.
12013         * mdebugread.c (parse_partial_symbols): Update.
12014         * dwarf2read.c (create_partial_symtab): Update.
12015         * dbxread.c (read_dbx_symtab): Update.
12016         (start_psymtab): Remove global_psymbols and static_psymbols
12017         parameters.
12018
12019 2019-01-10  Tom Tromey  <tom@tromey.com>
12020
12021         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
12022         * psymtab.c (allocate_psymtab): Add comment.
12023         * psympriv.h (allocate_psymtab): Add comment.
12024         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
12025         initializations.
12026         * dbxread.c (dbx_end_psymtab): Remove some initializations.
12027
12028 2019-01-10  Tom Tromey  <tom@tromey.com>
12029
12030         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12031         Don't declare.
12032         * mipsread.c: Include mdebugread.h.
12033         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12034         Declare.
12035         * elfread.c: Include mdebugread.h.
12036
12037 2019-01-09  Tom Tromey  <tom@tromey.com>
12038
12039         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
12040         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
12041         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
12042         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
12043         (psym_lookup_symbol, psym_find_last_source_symtab)
12044         (psym_forget_cached_source_info, psym_print_stats)
12045         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
12046         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
12047         (psym_map_matching_symbols, psym_expand_symtabs_matching)
12048         (psym_find_compunit_symtab_by_address)
12049         (maintenance_print_psymbols, maintenance_info_psymtabs)
12050         (maintenance_check_psymtabs): Use ranged for.
12051         * psymtab.h (class objfile_psymtabs): New.
12052         (require_partial_symbols): Return objfile_psymtabs.
12053         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
12054
12055 2019-01-09  Tom Tromey  <tom@tromey.com>
12056
12057         * symfile.c (overlay_invalidate_all, find_pc_overlay)
12058         (find_pc_mapped_section, list_overlays_command)
12059         (map_overlay_command, unmap_overlay_command)
12060         (simple_overlay_update): Use all_objfiles.
12061         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
12062         * printcmd.c (info_symbol_command): Use all_objfiles.
12063         * objfiles.h (ALL_OBJSECTIONS): Remove.
12064         * maint.c (maintenance_translate_address): Use all_objfiles.
12065         * gcore.c (gcore_create_callback): Use all_objfiles.
12066         (objfile_find_memory_regions): Likewise.
12067
12068 2019-01-09  Tom Tromey  <tom@tromey.com>
12069
12070         * symtab.c (find_line_symtab, info_sources_command)
12071         (make_source_files_completion_list): Use objfile_compunits.
12072         * source.c (select_source_symtab): Use objfile_compunits.
12073         * objfiles.h (struct objfile): Update comment.
12074         (ALL_OBJFILES): Remove.
12075         (ALL_FILETABS): Remove.
12076         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
12077         objfile_compunits.
12078
12079 2019-01-09  Tom Tromey  <tom@tromey.com>
12080
12081         * symmisc.c (print_objfile_statistics, dump_objfile)
12082         (maintenance_print_symbols): Use compunit_filetabs.
12083         * source.c (forget_cached_source_info_for_objfile): Use
12084         compunit_filetabs.
12085         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
12086         (ALL_FILETABS): Use compunit_filetabs.
12087         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
12088         * coffread.c (coff_symtab_read): Use compunit_filetabs.
12089
12090 2019-01-09  Tom Tromey  <tom@tromey.com>
12091
12092         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
12093         (compunit_filetabs): New.
12094         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
12095         compunit_filetabs.
12096         (info_sources_command, make_source_files_completion_list): Remove
12097         declaration.
12098         * symmisc.c (print_objfile_statistics, dump_objfile)
12099         (maintenance_print_symbols): Remove declaration.
12100         (maintenance_info_symtabs): Use compunit_filetabs.
12101         (maintenance_info_line_tables): Likewise.
12102         * source.c (select_source_symtab): Change local variable name.
12103         (forget_cached_source_info_for_objfile): Remove declaration.
12104         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
12105         * objfiles.c (objfile_relocate1): Remove declaration.
12106         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12107         declaration.
12108         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
12109         * coffread.c (coff_symtab_read): Remove declaration.
12110         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
12111         compunit_filetabs.
12112
12113 2019-01-09  Tom Tromey  <tom@tromey.com>
12114
12115         * symtab.c (lookup_objfile_from_block)
12116         (find_pc_sect_compunit_symtab, search_symbols)
12117         (default_collect_symbol_completion_matches_break_on): Use
12118         objfile_compunits.
12119         * objfiles.h (ALL_COMPUNITS): Remove.
12120         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
12121         * cp-support.c (add_symbol_overload_list_qualified): Use
12122         objfile_compunits.
12123         * ada-lang.c (ada_collect_symbol_completion_matches)
12124         (ada_add_global_exceptions): Use objfile_compunits.
12125
12126 2019-01-09  Tom Tromey  <tom@tromey.com>
12127
12128         * source.c (select_source_symtab)
12129         (forget_cached_source_info_for_objfile): Remove declaration.
12130         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12131         declaration.
12132         * maint.c (count_symtabs_and_blocks): Remove declaration.
12133         * cp-support.c (add_symbol_overload_list_qualified): Remove
12134         declaration.
12135         * coffread.c (coff_symtab_read): Remove declaration.
12136         * symtab.c (lookup_symbol_in_objfile_symtabs)
12137         (basic_lookup_transparent_type_1): Use objfile_compunits.
12138         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
12139         (info_sources_command, search_symbols)
12140         (default_collect_symbol_completion_matches_break_on)
12141         (make_source_files_completion_list): Remove declaration.
12142         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
12143         (ada_collect_symbol_completion_matches)
12144         (ada_add_global_exceptions): Remove declaration.
12145         * linespec.c (iterate_over_all_matching_symtabs): Use
12146         objfile_compunits.
12147         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
12148         (class objfile_compunits): New.
12149         (ALL_COMPUNITS): Use objfile_compunits.
12150         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
12151         (maintenance_check_symtabs, maintenance_info_line_tables): Use
12152         objfile_compunits.
12153         * objfiles.c (objfile_relocate1): Use objfile_compunits.
12154
12155 2019-01-09  Tom Tromey  <tom@tromey.com>
12156
12157         * symtab.c (search_symbols)
12158         (default_collect_symbol_completion_matches_break_on): Use
12159         objfile_msymbols.
12160         * ada-lang.c (ada_lookup_simple_minsym)
12161         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
12162         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
12163         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
12164         objfile_msymbols.
12165         * coffread.c (coff_symfile_read): Use objfile_msymbols.
12166         * symmisc.c (dump_msymbols): Use objfile_msymbols.
12167         * objc-lang.c (find_methods): Use objfile_msymbols.
12168         (info_selectors_command, info_classes_command): Likewise.
12169         * stabsread.c (scan_file_globals): Use objfile_msymbols.
12170         * objfiles.h (class objfile_msymbols): New.
12171         (ALL_OBJFILE_MSYMBOLS): Remove.
12172         (ALL_MSYMBOLS): Remove.
12173
12174 2019-01-09  Tom Tromey  <tom@tromey.com>
12175
12176         * common/next-iterator.h (next_adapter): Add Iterator template
12177         parameter.
12178         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
12179         (class all_objfiles_safe): New.
12180         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
12181         * objfiles.c (put_objfile_before): Update comment.
12182         (add_separate_debug_objfile): Likewise.
12183         (free_all_objfiles): Use all_objfiles_safe.
12184         (objfile_purge_solibs): Likewise.
12185
12186 2019-01-09  Tom Tromey  <tom@tromey.com>
12187
12188         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12189         (expand_symtab_containing_pc, lookup_static_symbol)
12190         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
12191         (find_symbol_at_address, find_line_symtab, find_main_name): Use
12192         all_objfiles.
12193         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
12194         * breakpoint.c (create_overlay_event_breakpoint)
12195         (create_longjmp_master_breakpoint)
12196         (create_std_terminate_master_breakpoint)
12197         (create_exception_master_breakpoint): Use all_objfiles.
12198         * linux-thread-db.c (try_thread_db_load_from_pdir)
12199         (has_libpthread): Use all_objfiles.
12200         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
12201         * linespec.c (iterate_over_all_matching_symtabs)
12202         (search_minsyms_for_name): Use all_objfiles.
12203         * maint.c (maintenance_info_sections): Use all_objfiles.
12204         * main.c (captured_main_1): Use all_objfiles.
12205         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
12206         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
12207         * guile/scm-pretty-print.c
12208         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
12209         * solib-spu.c (append_ocl_sos): Use all_objfiles.
12210         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
12211         (maintenance_print_msymbols): Use all_objfiles.
12212         * source.c (select_source_symtab): Use all_objfiles.
12213         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
12214         * symfile.c (remove_symbol_file_command)
12215         (expand_symtabs_matching, map_symbol_filenames): Use
12216         all_objfiles.
12217         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
12218         all_objfiles.
12219         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
12220         * objc-lang.c (find_methods): Use all_objfiles.
12221         * objfiles.c (have_partial_symbols, have_full_symbols)
12222         (have_minimal_symbols, qsort_cmp)
12223         (default_iterate_over_objfiles_in_search_order): Use
12224         all_objfiles.
12225         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
12226         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
12227         (maintenance_check_psymtabs): Use all_objfiles.
12228         (ALL_PSYMTABS): Remove.
12229         * compile/compile-object-run.c (do_module_cleanup): Use
12230         all_objfiles.
12231         * blockframe.c (find_pc_partial_function): Use all_objfiles.
12232         * cp-support.c (add_symbol_overload_list_qualified): Use
12233         all_objfiles.
12234         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12235         Use all_objfiles.
12236         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
12237         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
12238         all_objfiles.
12239         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12240         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
12241         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12242         Uses all_objfiles.
12243         * solib.c (solib_read_symbols): Use all_objfiles
12244
12245 2019-01-09  Tom Tromey  <tom@tromey.com>
12246
12247         * probe.c (parse_probes_in_pspace): Use all_objfiles.
12248         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
12249         all_objfiles.
12250         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
12251         * symmisc.c (print_symbol_bcache_statistics)
12252         (print_objfile_statistics, maintenance_print_objfiles)
12253         (maintenance_info_symtabs, maintenance_check_symtabs)
12254         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
12255         all_objfiles.
12256         * source.c (forget_cached_source_info): Use all_objfiles.
12257         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
12258         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12259         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
12260         * objfiles.c (update_section_map): Use all_objfiles.
12261         (shared_objfile_contains_address_p): Likewise.
12262         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
12263         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
12264
12265 2019-01-09  Tom Tromey  <tom@tromey.com>
12266
12267         * common/next-iterator.h: New file.
12268         * objfiles.h (class all_objfiles): New.
12269         (struct objfile_iterator): New.
12270
12271 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12272
12273         * NEWS: Move the description of the changed "frame", "select-frame",
12274          and "info frame" commands to the Changed commands section.
12275
12276 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
12277
12278         * gdbtypes.c (check_stub_method_group): Remove handling of old
12279         mangling schemes.
12280         * linespec.c (find_methods): Likewise.
12281         * stabsread.c (read_member_functions): Likewise.
12282         * valops.c (search_struct_method): Likewise.
12283         (value_struct_elt_for_reference): Likewise.
12284         * NEWS: Mention this change.
12285
12286 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
12287
12288         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
12289         print_source_lines.
12290         * source.c (print_source_lines_base): Update line number check.
12291         (print_source_lines): New function.
12292         (source_lines_range::source_lines_range): New function.
12293         * source.h (class source_lines_range): New class.
12294         (print_source_lines): New declaration.
12295
12296 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12297
12298         * linespec.c (linespec_state_destructor): Free self->canonical_names.
12299
12300 2019-01-08  Tom Tromey  <tom@tromey.com>
12301             Simon Marchi  <simon.marchi@ericsson.com>
12302
12303         PR gdb/24060
12304         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
12305         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
12306         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12307         * f-exp.y (DOLLAR_VARIABLE): Likewise.
12308         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
12309         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12310
12311 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12312
12313         * source.c (select_source_symtab): Move header comment to
12314         declaration in source.h.
12315         (forget_cached_source_info_for_objfile): Likewise.
12316         (forget_cached_source_info): Likewise.
12317         (identify_source_line): Likewise.
12318         * source.h (identify_source_line): Move declaration from symtab.h
12319         and add comment from source.c
12320         (print_source_lines): Likewise.
12321         (forget_cached_source_info_for_objfile): Likewise.
12322         (forget_cached_source_info): Likewise.
12323         (select_source_symtab): Likewise.
12324         (enum print_source_lines_flag): Move definition from symtab.h.
12325         * symtab.h (identify_source_line): Move declaration to source.h.
12326         (print_source_lines): Likewise.
12327         (forget_cached_source_info_for_objfile): Likewise.
12328         (forget_cached_source_info): Likewise.
12329         (select_source_symtab): Likewise.
12330         (enum print_source_lines_flag): Move definition to source.h.
12331         * tui/tui-hooks.c: Add 'source.h' include.
12332
12333 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12334
12335         * source.c (print_source_lines_base): Handle requests to print
12336         reverse line number sequences, and guard against empty lines
12337         string.
12338
12339 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12340
12341         * source.c (print_source_lines_base): Fix skip of '\r' if next
12342         character is '\n'.
12343
12344 2019-01-06  Tom Tromey  <tom@tromey.com>
12345
12346         * c-exp.y (struct c_parse_state) <macro_original_text,
12347         expansion_obstack>: New member.
12348         (macro_original_text, expansion_obstack): Remove globals.
12349         (scan_macro_expansion, scanning_macro_expansion)
12350         (finished_macro_expansion): Update.
12351         (scan_macro_cleanup): Remove.
12352         (yylex, c_parse): Update.
12353
12354 2019-01-06  Tom Tromey  <tom@tromey.com>
12355
12356         * c-exp.y (struct c_parse_state) <strings>: New member.
12357         (operator_stoken): Update.
12358
12359 2019-01-06  Tom Tromey  <tom@tromey.com>
12360
12361         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
12362         (union type_stack_elt) <typelist_val>: Now a pointer to
12363         std::vector.
12364         (type_stack_cleanup): Don't declare.
12365         (push_typelist): Update.
12366         * parse.c (pop_typelist): Return a std::vector.
12367         (push_typelist): Take a std::vector.
12368         (follow_types): Update.  Do not free args.
12369         (type_stack_cleanup): Remove.
12370         * c-exp.y (struct c_parse_state): New.
12371         (cpstate): New global.
12372         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
12373         (nonempty_typelist): Update.
12374         (func_mod): Create a new vector.
12375         (c_parse): Create a c_parse_state.
12376         (check_parameter_typelist): Do not delete params.
12377         (function_method): Update.  Do not delete type_list.
12378
12379 2019-01-06  Tom Tromey  <tom@tromey.com>
12380
12381         PR gdb/28155:
12382         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
12383         check_typedef.
12384         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
12385         (print_return_value): Likewise.
12386
12387 2019-01-05  Tom Tromey  <tom@tromey.com>
12388
12389         * contrib/cleanup_check.py: Remove.
12390         * contrib/gcc-with-excheck: Remove.
12391         * contrib/exsummary.py: Remove.
12392         * contrib/excheck.py: Remove.
12393
12394 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
12395
12396         * thread.c (delete_thread_1): Add gdb_assert that THR is not
12397         NULL. Initialize tpprev to NULL instead of assigning it
12398         to NULL on the next statement.
12399         * windows-nat.c (windows_delete_thread): Remove check for
12400         main_thread_id before printing thread exit notifications.
12401         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
12402         Remove thread ID check against main_thread_id.
12403         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
12404         windows_delete_thread.
12405         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
12406
12407 2019-01-04  Tom Tromey  <tom@tromey.com>
12408
12409         * compile/compile.c (_initialize_compile): Use upper case for
12410         metasyntactic variables.
12411         * symmisc.c (_initialize_symmisc): Use upper case for
12412         metasyntactic variables.
12413         * psymtab.c (_initialize_psymtab): Use upper case for
12414         metasyntactic variables.
12415         * demangle.c (demangle_command): Use upper case for metasyntactic
12416         variables.
12417         (_initialize_demangler): Likewise.
12418         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
12419         variables.
12420
12421 2019-01-03  Tom Tromey  <tom@tromey.com>
12422
12423         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
12424
12425 2019-01-03  Tom Tromey  <tom@tromey.com>
12426
12427         * python/py-symtab.c (salpy_str): Update.
12428         (struct salpy_sal_object) <symtab>: Now a PyObject.
12429         (salpy_dealloc): Update.
12430         (del_objfile_sal): Use gdbpy_ref.
12431
12432 2019-01-03  Tom Tromey  <tom@tromey.com>
12433
12434         * python/py-type.c (convert_field): Use new_reference.  Return
12435         gdbpy_ref.
12436         (make_fielditem): Return gdbpy_ref.
12437         (typy_fields): Update.
12438         (typy_getitem): Update.
12439         (field_name): Return gdbpy_ref.  Use new_reference.
12440         (typy_iterator_iternext): Update.
12441
12442 2019-01-03  Tom Tromey  <tom@tromey.com>
12443
12444         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
12445
12446 2019-01-03  Tom Tromey  <tom@tromey.com>
12447
12448         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
12449         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
12450         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
12451         (pspy_set_frame_filters, pspy_set_frame_unwinders)
12452         (pspy_set_type_printers): Likewise.
12453         * python/py-function.c (fnpy_init): Use gdbpy_ref.
12454         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
12455         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
12456         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
12457         (objfpy_set_type_printers): Likewise.
12458
12459 2019-01-03  Tom Tromey  <tom@tromey.com>
12460
12461         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
12462         (gdbpy_print_stack): Use gdbpy_err_fetch.
12463         * python/python-internal.h (class gdbpy_err_fetch): New class.
12464         (class gdbpy_enter) <m_error_type, m_error_value,
12465         m_error_traceback>: Remove.
12466         <m_error>: New member.
12467         (gdbpy_exception_to_string): Don't declare.
12468         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
12469         * python/py-value.c (convert_value_from_python): Use
12470         gdbpy_err_fetch.
12471         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
12472         gdbpy_exception_to_string.
12473         (gdbpy_handle_exception): Use gdbpy_err_fetch.
12474         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
12475         gdbpy_err_fetch.
12476
12477 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12478
12479         * linux-nat.c (delete_lwp_cleanup): Delete.
12480         (struct lwp_deleter): New struct.
12481         (lwp_info_up): New typedef.
12482         (linux_nat_target::follow_fork): Delete cleanup, and make use of
12483         lwp_info_up.
12484
12485 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12486
12487         * linux-fork.c (class scoped_switch_fork_info): New class.
12488         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
12489
12490 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12491
12492         * valops.c (find_overload_match): Remove use of null_cleanup, and
12493         calls to do_cleanups.
12494
12495 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12496
12497         * compile/compile-cplus-types.c
12498         (compile_cplus_instance::decl_name): Handle changes to
12499         cp_func_name.
12500         * cp-support.c (cp_func_name): Update header comment, update
12501         return type.
12502         * cp-support.h (cp_func_name): Update return type in declaration.
12503         * valops.c (find_overload_match): Move temp_func local to top
12504         level of function and change its type.  Use temp_func to hold and
12505         delete temporary string obtained from cp_func_name.
12506
12507 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12508
12509         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
12510         gdb::char_vector, remove cleanup, and update uses of `msg`.
12511
12512 2019-01-03  Jim Wilson  <jimw@sifive.com>
12513
12514         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
12515
12516 2019-01-02  Tom Tromey  <tom@tromey.com>
12517
12518         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
12519         (tdesc_parse_xml): Remove cleanups.
12520         * target-descriptions.h (make_cleanup_free_target_description):
12521         Don't declare.
12522         (target_desc_deleter): New struct.
12523         (target_desc_up): New typedef.
12524         * target-descriptions.c (target_desc_deleter::operator()): Rename
12525         from free_target_description.
12526         (make_cleanup_free_target_description): Remove.
12527
12528 2019-01-02  Tom Tromey  <tom@tromey.com>
12529
12530         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
12531         constructor, destructor.
12532         (linespec_parser): Remove typedef.
12533         (~linespec_parser): Rename from linespec_parser_delete.
12534         (linespec_lex_to_end, linespec_complete_label)
12535         (linespec_complete): Update.
12536         (decode_line_full): Remove cleanups.
12537         (decode_line_1): Update.
12538
12539 2019-01-02  Tom Tromey  <tom@tromey.com>
12540
12541         * python/python-internal.h (inferior_to_inferior_object): Change
12542         return type.
12543         * python/py-exitedevent.c (create_exited_event_object): Update.
12544         * python/py-inferior.c (inferior_to_inferior_object): Return
12545         gdbpy_ref.
12546         (python_new_inferior, python_inferior_deleted)
12547         (thread_to_thread_object, delete_thread_object)
12548         (build_inferior_list, gdbpy_selected_inferior): Update.
12549         * python/py-infthread.c (create_thread_object): Update.  Also fail
12550         if inferior_to_inferior_object fails.
12551
12552 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
12553
12554         * inferior.h (class inferior) <displaced_step_state>: New field.
12555         * infrun.h (struct displaced_step_state): Move here from
12556         infrun.c.  Initialize fields, add constructor.
12557         <inf>: Remove field.
12558         <reset>: New method.
12559         * infrun.c (struct displaced_step_inferior_state): Move to
12560         infrun.h.
12561         (displaced_step_inferior_states): Remove.
12562         (get_displaced_stepping_state): Adust.
12563         (displaced_step_in_progress_any_inferior): Adjust.
12564         (displaced_step_in_progress_thread): Adjust.
12565         (displaced_step_in_progress): Adjust.
12566         (add_displaced_stepping_state): Remove.
12567         (get_displaced_step_closure_by_addr): Adjust.
12568         (remove_displaced_stepping_state): Remove.
12569         (infrun_inferior_exit): Call displaced_step_state.reset.
12570         (use_displaced_stepping): Don't check for NULL.
12571         (displaced_step_prepare_throw): Call
12572         get_displaced_stepping_state.
12573         (displaced_step_fixup): Don't check for NULL.
12574         (prepare_for_detach): Don't check for NULL.
12575
12576 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12577
12578         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
12579          in case of call that did not complete.
12580
12581 2019-01-02  Andrey Utkin  <autkin@undo.io>
12582
12583         * symfile.c (find_separate_debug_file): Fix search of debug files for
12584         remote debuggee.
12585
12586 2019-01-02  Tom Tromey  <tom@tromey.com>
12587
12588         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
12589         indentation.
12590         * python/py-frame.c (frapy_older): Remove cast.
12591         (frapy_newer): Likewise.
12592         * python/py-breakpoint.c (local_setattro): Remove cast.
12593         * python/py-arch.c (archpy_name): Remove local variable.
12594         * python/py-type.c (gdbpy_lookup_type): Remove cast.
12595
12596 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
12597
12598         * unittests/basic_string_view/element_access/char/empty.cc:
12599         Fix year range in copyright header.
12600
12601 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12602
12603         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
12604         Delete.
12605         <operator==>: Update with for removed field.
12606         <hash>: Likewise.
12607         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
12608         <isa_features>: ...this.
12609         <abi_features>: New field.
12610         (riscv_isa_flen): Update comment.
12611         (riscv_abi_xlen): New declaration.
12612         (riscv_abi_flen): New declaration.
12613         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
12614         isa_features.
12615         (riscv_abi_xlen): New function.
12616         (riscv_isa_flen): Update to get answer from isa_features.
12617         (riscv_abi_flen): New function.
12618         (riscv_has_fp_abi): Update to get answer from abi_features.
12619         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
12620         xlen and flen.
12621         (riscv_call_info) <xlen, flen>: Update comment.
12622         (riscv_call_arg_struct): Remove invalid assertions
12623         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
12624         is removed.
12625         (riscv_gdbarch_init): Gather isa features and abi features
12626         separately, ensure both match on the gdbarch when reusing an old
12627         gdbarch.  Relax an error check to allow 32-bit abi float to run on
12628         a target with 64-bit float hardware.
12629
12630 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12631
12632         * source.c (search_command_helper): Stop reverse search
12633         when line 1 has been searched.
12634
12635 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12636
12637         * record-full.c (record_full_base_target::close): Rewrite
12638         record_full_core_buf_list free logic.
12639
12640 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12641
12642         * break-catch-syscall.c (print_one_catch_syscall): xfree
12643         the last text.
12644
12645 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12646
12647         * top.c (print_gdb_version): Update Copyright year in version
12648         message.
12649
12650 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12651
12652         Update copyright year range in all GDB files.
12653
12654 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
12655
12656         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
12657
12658 For older changes see ChangeLog-2018.
12659 \f
12660 Local Variables:
12661 mode: change-log
12662 left-margin: 8
12663 fill-column: 74
12664 version-control: never
12665 coding: utf-8
12666 End:
12667