gdb/ChangeLog

   1 2019-06-25  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
   4         type.
   5         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
   6         protected.
   7
   8 2019-06-25  Tom Tromey  <tom@tromey.com>
   9
  10         * tui/tui-winsource.c
  11         (tui_source_window_base::set_is_exec_point_at): Add check against
  12         LOA_ADDRESS.
  13
  14 2019-06-25  Tom Tromey  <tom@tromey.com>
  15
  16         * tui/tui-source.c (tui_set_source_content): Don't check before
  17         xfree.
  18         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
  19
  20 2019-06-25  Tom Tromey  <tom@tromey.com>
  21
  22         * tui/tui-winsource.h (tui_update_source_window_as_is)
  23         (tui_alloc_source_buffer, tui_line_is_displayed)
  24         (tui_addr_is_displayed): Change type of win_info.
  25         * tui/tui-winsource.c (tui_update_source_window_as_is)
  26         (tui_clear_source_content, tui_show_source_line)
  27         (tui_show_source_content, tui_source_window_base::refill)
  28         (tui_source_window_base::set_is_exec_point_at)
  29         (tui_source_window_base::set_is_exec_point_at)
  30         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
  31         (tui_alloc_source_buffer, tui_line_is_displayed)
  32         (tui_addr_is_displayed): Change type of win_info.  Update.
  33         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
  34         (tui_source_window_base::do_make_visible_with_new_height):
  35         Update.
  36         * tui/tui-source.c (tui_set_source_content)
  37         (tui_set_source_content_nil)
  38         (tui_source_window::do_scroll_vertical): Update.
  39         * tui/tui-layout.c (show_layout): Update.
  40         * tui/tui-disasm.c (tui_set_disassem_content)
  41         (tui_disasm_window::do_scroll_vertical): Update.
  42         * tui/tui-data.h (tui_win_content): Remove.
  43         (struct tui_gen_win_info) <content, content_size>: Remove.
  44         (struct tui_source_element): Add initializers and destructor.
  45         (union tui_which_element, struct tui_win_element): Remove.
  46         (struct tui_source_window_base) <content>: New field.
  47         (struct tui_data_window): Remove destructor.
  48         (tui_alloc_content, tui_free_win_content)
  49         (tui_free_all_source_wins_content): Don't declare.
  50         * tui/tui-data.c (tui_initialize_static_data): Update.
  51         (init_content_element, tui_alloc_content): Remove.
  52         (~tui_gen_win_info): Update.
  53         (~tui_data_window, tui_free_all_source_wins_content)
  54         (tui_free_win_content, free_content, free_content_elements):
  55         Remove.
  56
  57 2019-06-25  Tom Tromey  <tom@tromey.com>
  58
  59         * tui/tui-winsource.h (tui_clear_source_content)
  60         (tui_erase_source_content, tui_show_source_content): Change type
  61         of win_info.
  62         * tui/tui-winsource.c (tui_clear_source_content)
  63         (tui_erase_source_content, tui_show_source_content): Change type
  64         of win_info.
  65         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
  66         * tui/tui-source.h (tui_set_source_content_nil): Change type of
  67         win_info.
  68         * tui/tui-source.c (tui_set_source_content_nil): Change type of
  69         win_info.
  70         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
  71
  72 2019-06-25  Tom Tromey  <tom@tromey.com>
  73
  74         * tui/tui-winsource.c (tui_clear_source_content)
  75         (tui_source_window_base::set_is_exec_point_at): Update.
  76         * tui/tui-source.c (tui_set_source_content_nil): Update.
  77         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
  78         a bool.
  79         * tui/tui-data.c (init_content_element): Update.
  80
  81 2019-06-25  Tom Tromey  <tom@tromey.com>
  82
  83         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
  84         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
  85         * tui/tui-layout.c (init_and_make_win): Update.
  86         * tui/tui.h (enum tui_win_type): Update.
  87         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
  88         tui_win_is_auxillary.
  89         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
  90         tui_win_is_auxillary.
  91
  92 2019-06-25  Tom Tromey  <tom@tromey.com>
  93
  94         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
  95         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
  96         (tui_delete_data_content_windows, tui_display_all_data)
  97         (tui_data_window::do_scroll_vertical, tui_display_data_from):
  98         Update.
  99         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
 100         * tui/tui-regs.c (tui_last_regs_line_no)
 101         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 102         (tui_show_registers): Update.
 103         (tui_show_register_group): Return void.  Update.
 104         (tui_display_registers_from, tui_display_reg_element_at_line)
 105         (tui_display_registers_from_line, tui_check_register_values):
 106         Update.
 107         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
 108         member.
 109         (struct tui_data_window) <regs_content>: Now a std::vector.
 110         <regs_content_count>: Remove.
 111         (tui_add_content_elements, tui_free_data_content): Don't declare.
 112         * tui/tui-data.c (tui_data_window::clear_detail): Update.
 113         (init_content_element): Remove DATA_WIN case.  Add assert.
 114         (tui_add_content_elements): Remove.
 115         (tui_data_window): Update.
 116         (tui_free_data_content): Remove.
 117         (free_content_elements): Remove DATA_WIN case.
 118
 119 2019-06-25  Tom Tromey  <tom@tromey.com>
 120
 121         * tui/tui-data.c (tui_data_item_window): Update.
 122         * tui/tui-windata.h (tui_check_data_values): Don't declare.
 123         * tui/tui-windata.c (tui_display_all_data)
 124         (tui_display_data_from_line): Update.
 125         (tui_check_data_values): Remove.
 126         * tui/tui-regs.c (tui_show_register_group)
 127         (tui_display_reg_element_at_line): Update.
 128         * tui/tui-hooks.c (tui_register_changed)
 129         (tui_refresh_frame_and_register_information): Call
 130         tui_check_register_values.
 131         * tui/tui-data.h (struct tui_data_window) <data_content,
 132         data_content_count, data_type>: Remove.
 133         (enum tui_data_type): Remove.
 134
 135         * tui/tui-data.c (tui_data_window::clear_detail)
 136         (~tui_data_window): Update.
 137
 138 2019-06-25  Tom Tromey  <tom@tromey.com>
 139
 140         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
 141         declare.
 142         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
 143         Rename from tui_first_data_item_displayed.  Update.
 144         (tui_data_window::refresh_all)
 145         (tui_data_window::do_scroll_vertical): Update.
 146         * tui/tui-data.h (struct tui_data_window)
 147         <first_data_item_displayed>: Declare new method.
 148
 149 2019-06-25  Tom Tromey  <tom@tromey.com>
 150
 151         * tui/tui-data.h (tui_init_generic_part): Don't declare.
 152         * tui/tui-data.c (tui_init_generic_part): Remove, moving
 153         contents...
 154         (tui_initialize_static_data): ...here.
 155
 156 2019-06-25  Tom Tromey  <tom@tromey.com>
 157
 158         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 159         (tui_display_registers_from, tui_check_register_values): Update.
 160         (tui_display_register): Remove win_info parameter; update.
 161         (tui_get_register): Change type of parameters.
 162         * tui/tui-data.h (struct tui_data_element): Remove.
 163         (union tui_which_element) <data>: Remove.
 164         <data_window>: Change type.
 165         (struct tui_data_item_window): New.
 166         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
 167         case.  Add assert.
 168         (~tui_data_item_window): New destructor.
 169         (free_content_elements): Remove DATA_ITEM_WIN case.
 170
 171 2019-06-25  Tom Tromey  <tom@tromey.com>
 172
 173         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
 174         Remove.
 175
 176 2019-06-25  Tom Tromey  <tom@tromey.com>
 177
 178         * tui/tui-data.h (struct tui_command_element): Remove.
 179         (union tui_which_element) <command>: Remove.
 180         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
 181         assert.
 182         (free_content_elements): Remove CMD_WIN case.
 183
 184 2019-06-25  Tom Tromey  <tom@tromey.com>
 185
 186         * tui/tui-layout.c (tui_set_layout): Update.
 187         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
 188         * tui/tui-data.c (layout_def): Update.
 189
 190 2019-06-25  Tom Tromey  <tom@tromey.com>
 191
 192         * tui/tui-wingeneral.c (tui_refresh_all): Update.
 193         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 194         (tui_source_window_base::set_new_height): Update.
 195         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
 196         Update.
 197         (tui_set_locator_fullname, tui_set_locator_info)
 198         (tui_show_frame_info): Update.
 199         * tui/tui-source.c (tui_set_source_content)
 200         (tui_source_is_displayed): Update.
 201         * tui/tui-layout.c (show_source_disasm_command, show_data)
 202         (show_source_or_disasm_and_command): Update.
 203         * tui/tui-disasm.c (tui_set_disassem_content)
 204         (tui_get_begin_asm_address): Update.
 205         * tui/tui-data.h (struct tui_locator_element): Remove.
 206         (union tui_which_element) <locator>: Remove.
 207         (struct tui_locator_window): New.
 208         (tui_locator_win_info_ptr): Change return type.
 209         * tui/tui-data.c (_locator): Change type.
 210         (tui_locator_win_info_ptr): Change return type.
 211         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
 212         (tui_alloc_content): Add assert.
 213
 214 2019-06-25  Tom Tromey  <tom@tromey.com>
 215
 216         * tui/tui-winsource.c
 217         (tui_exec_info_window::maybe_allocate_content): New method.
 218         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
 219         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
 220         (make_source_or_disasm_window): Add cast.
 221         * tui/tui-data.h (union tui_which_element) <simple_string>:
 222         Remove.
 223         (struct tui_source_info): New.
 224         (struct tui_source_window_base) <execution_info>: Change type.
 225         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
 226         case, and add assert.
 227         (tui_alloc_content): Add assert.
 228
 229 2019-06-25  Tom Tromey  <tom@tromey.com>
 230
 231         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
 232         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
 233         * tui/tui-data.c (tui_alloc_win_info): Remove.
 234
 235 2019-06-25  Tom Tromey  <tom@tromey.com>
 236
 237         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
 238         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
 239         can_highlight.
 240
 241 2019-06-25  Tom Tromey  <tom@tromey.com>
 242
 243         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
 244         make_visible_with_new_height method.
 245         (tui_win_info::make_visible_with_new_height): New method.
 246         (tui_source_window_base::do_make_visible_with_new_height)
 247         (tui_data_window::do_make_visible_with_new_height)
 248         (tui_cmd_window::do_make_visible_with_new_height): New methods.
 249         (make_visible_with_new_height): Remove.
 250         (tui_resize_all, tui_adjust_win_heights): Use
 251         make_visible_with_new_height method.
 252         * tui/tui-data.h (struct tui_win_info)
 253         <do_make_visible_with_new_height, make_visible_with_new_height>:
 254         New methods.
 255         (struct tui_source_window_base, struct tui_data_window)
 256         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
 257         methods.
 258
 259 2019-06-25  Tom Tromey  <tom@tromey.com>
 260
 261         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
 262         method.
 263         (update_tab_width): Call update_tab_width method.
 264         * tui/tui-data.h (struct tui_win_info)
 265         (struct tui_source_window_base) <update_tab_width>: New methods.
 266
 267 2019-06-25  Tom Tromey  <tom@tromey.com>
 268
 269         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
 270         parameter.
 271         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
 272         parameter.
 273         (tui_gen_win_info::make_visible): Update.
 274         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
 275         parameter.
 276         * tui/tui-data.h (enum tui_box): New enum.
 277         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
 278
 279 2019-06-25  Tom Tromey  <tom@tromey.com>
 280
 281         * tui/tui-layout.c (make_source_or_disasm_window): Always use
 282         init_and_make_win for EXEC_INFO_WIN.
 283         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
 284         longer inline.
 285         (struct tui_win_info) <~tui_win_info>: Inline.
 286         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 287         Don't declare.
 288         * tui/tui-data.c (source_win, disasm_win): Remove globals.
 289         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 290         Remove.
 291         (tui_initialize_static_data): Update.
 292         (~tui_gen_win_info): Handle more cleanup here.
 293         (~tui_source_window_base): Delete "execution_info".
 294         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
 295
 296 2019-06-25  Tom Tromey  <tom@tromey.com>
 297
 298         * tui/tui-layout.c (make_command_window): Don't set
 299         can_highlight.
 300         (show_source_disasm_command): Call the reset method.
 301         (show_data): Don't set can_highlight.  Call the reset method.
 302         (tui_gen_win_info::reset): Rename from init_gen_win_info
 303         (init_and_make_win): Simplify.  Return tui_gen_win_info.
 304         (show_source_or_disasm_and_command): Call the reset method.
 305         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
 306         (struct tui_cmd_window): Set can_highlight.
 307
 308 2019-06-25  Tom Tromey  <tom@tromey.com>
 309
 310         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
 311         from make_visible.
 312         (tui_make_visible, tui_make_invisible): Rewrite.
 313         (tui_win_info::make_visible): Remove.
 314         (tui_source_window_base::make_visible): Update.
 315         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
 316         method.  Moved from...
 317         (struct tui_win_info) <make_visible>: ...here.
 318
 319 2019-06-25  Tom Tromey  <tom@tromey.com>
 320
 321         * tui/tui-winsource.c
 322         (tui_source_window_base::do_scroll_horizontal): Remove direction
 323         parameter.
 324         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
 325         direction parameter.
 326         * tui/tui-win.c (tui_win_info::forward_scroll)
 327         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 328         (tui_win_info::right_scroll): Update.
 329         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
 330         direction parameter.
 331         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
 332         direction parameter.
 333         * tui/tui-data.h (enum tui_scroll_direction): Remove.
 334         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
 335         Remove direction parameter.
 336         (struct tui_source_window_base, struct tui_source_window)
 337         (struct tui_disasm_window, struct tui_data_window)
 338         (struct tui_cmd_window): Update.
 339
 340 2019-06-25  Tom Tromey  <tom@tromey.com>
 341
 342         * tui/tui-winsource.h (tui_set_exec_info_content)
 343         (tui_show_exec_info_content, tui_erase_exec_info_content)
 344         (tui_clear_exec_info_content, tui_update_exec_info): Change
 345         argument to tui_source_window_base.
 346         * tui/tui-winsource.c (tui_set_exec_info_content)
 347         (tui_show_exec_info_content, tui_erase_exec_info_content)
 348         (tui_clear_exec_info_content, tui_update_exec_info): Change
 349         argument to tui_source_window_base.
 350
 351 2019-06-25  Tom Tromey  <tom@tromey.com>
 352
 353         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
 354         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
 355
 356 2019-06-25  Tom Tromey  <tom@tromey.com>
 357
 358         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
 359         check.
 360
 361 2019-06-25  Tom Tromey  <tom@tromey.com>
 362
 363         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
 364         type to void.
 365         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
 366         type to void.
 367         * tui/tui-source.c (tui_set_source_content): Update.
 368         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 369
 370 2019-06-25  Tom Tromey  <tom@tromey.com>
 371
 372         * tui/tui-win.c (window_name_completer, tui_set_focus)
 373         (tui_all_windows_info): Use name method.
 374         * tui/tui-data.h (struct tui_gen_win_info)
 375         (struct tui_source_window, struct tui_disasm_window)
 376         (struct tui_data_window, struct tui_cmd_window) <name>: New
 377         method.
 378         (tui_win_name): Don't declare.
 379         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
 380         (tui_win_name): Remove.
 381
 382 2019-06-25  Tom Tromey  <tom@tromey.com>
 383
 384         * tui/tui-winsource.h (tui_update_source_window)
 385         (tui_update_source_window_as_is): Change parameter type.
 386         * tui/tui-winsource.c (tui_update_source_window): Change win_info
 387         to be a tui_source_window_base.
 388         (tui_update_source_window_as_is): Likewise.
 389         * tui/tui-win.c (make_visible_with_new_height): Update.
 390
 391 2019-06-25  Tom Tromey  <tom@tromey.com>
 392
 393         * tui/tui-winsource.c (tui_erase_source_content)
 394         (tui_show_source_content, tui_show_exec_info_content)
 395         (tui_erase_exec_info_content): Use refresh_window method.
 396         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
 397         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
 398         from tui_refresh_win.
 399         (tui_data_window::refresh_window): New method.
 400         (tui_win_info::refresh, tui_source_window_base::refresh)
 401         (tui_refresh_all): Use refresh_window method.
 402         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
 403         method.
 404         * tui/tui-regs.c (tui_display_register): Call refresh_window
 405         method.
 406         * tui/tui-layout.c (show_source_disasm_command)
 407         (show_source_or_disasm_and_command): Call refresh_window method.
 408         * tui/tui-data.h (struct tui_gen_win_info)
 409         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
 410         New method.
 411
 412 2019-06-25  Tom Tromey  <tom@tromey.com>
 413
 414         * tui/tui.c (tui_rl_other_window, tui_enable)
 415         (tui_is_window_visible, tui_get_command_dimension): Update.
 416         * tui/tui-winsource.c (tui_update_source_window_as_is)
 417         (tui_clear_source_content, tui_erase_source_content)
 418         (tui_show_source_line, tui_source_window_base::refill)
 419         (tui_source_window_base::do_scroll_horizontal)
 420         (tui_source_window_base::set_is_exec_point_at)
 421         (tui_update_breakpoint_info, tui_set_exec_info_content)
 422         (tui_alloc_source_buffer, tui_line_is_displayed)
 423         (tui_addr_is_displayed): Update.
 424         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 425         (tui_check_and_display_highlight_if_needed)
 426         (tui_win_info::make_visible, tui_win_info::refresh)
 427         (tui_refresh_all): Update.
 428         * tui/tui-windata.c (tui_first_data_item_displayed)
 429         (tui_delete_data_content_windows, tui_erase_data_content)
 430         (tui_display_all_data, tui_data_window::refresh_all)
 431         (tui_check_data_values): Update.
 432         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
 433         (tui_set_win_focus_to, tui_win_info::forward_scroll)
 434         (tui_win_info::backward_scroll, tui_refresh_all_win)
 435         (tui_resize_all, tui_set_focus, tui_all_windows_info)
 436         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
 437         (tui_source_window_base::set_new_height)
 438         (tui_data_window::set_new_height)
 439         (make_invisible_and_set_new_height)
 440         (make_visible_with_new_height, new_height_ok)
 441         (parse_scrolling_args): Update.
 442         * tui/tui-stack.c (tui_show_frame_info): Update.
 443         * tui/tui-source.c (tui_set_source_content)
 444         (tui_set_source_content_nil, tui_source_is_displayed)
 445         (tui_source_window::do_scroll_vertical): Update.
 446         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 447         (tui_display_registers_from, tui_display_reg_element_at_line)
 448         (tui_check_register_values, tui_reg_command): Update.
 449         * tui/tui-layout.c (tui_default_win_height)
 450         (show_source_disasm_command, show_data, init_and_make_win)
 451         (show_source_or_disasm_and_command): Update.
 452         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 453         (tui_redisplay_readline, tui_mld_flush)
 454         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
 455         (tui_getc): Update.
 456         * tui/tui-disasm.c (tui_set_disassem_content)
 457         (tui_disasm_window::do_scroll_vertical): Update.
 458         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
 459         Now virtual.
 460         (struct tui_win_info): Derive from tui_gen_win_info.
 461         <~tui_win_info>: Mark as override.
 462         <generic>: Remove member.
 463         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
 464         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
 465         (~tui_data_window, ~tui_win_info)
 466         (tui_free_all_source_wins_content): Update.
 467         * tui/tui-command.c (tui_refresh_cmd_win): Update.
 468
 469 2019-06-25  Tom Tromey  <tom@tromey.com>
 470
 471         * tui/tui-layout.c (init_and_make_win): Use new.
 472         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
 473         destructor, initializers.
 474         (tui_alloc_generic_win_info): Don't declare.
 475         * tui/tui-data.c (_locator): Add argument to constructor.
 476         (source_win, disasm_win): New globals.
 477         (exec_info): Remove.
 478         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 479         Update.
 480         (tui_alloc_generic_win_info): Remove.
 481         (init_content_element): Use new.
 482         (tui_win_info::tui_win_info): Update.
 483         (free_content_elements) <case DATA_WIN>: Use delete.
 484
 485 2019-06-25  Tom Tromey  <tom@tromey.com>
 486
 487         * tui/tui-wingeneral.c (tui_refresh_win): Update.
 488         * tui/tui-windata.c (tui_first_data_item_displayed)
 489         (tui_delete_data_content_windows): Update.
 490         * tui/tui-win.c (tui_data_window::set_new_height): Update.
 491         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 492         (tui_display_registers_from, tui_check_register_values): Update.
 493         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
 494         pointer.
 495         * tui/tui-data.c (init_content_element): Update.  Allocate the new
 496         window.
 497         (tui_free_data_content): Update.
 498         (free_content_elements) <case DATA_WIN>: Free the window.
 499
 500 2019-06-25  Tom Tromey  <tom@tromey.com>
 501
 502         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
 503         Update.
 504         * tui/tui-layout.c (make_command_window)
 505         (show_source_disasm_command, show_data, init_and_make_win)
 506         (show_source_or_disasm_and_command): Update.
 507         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
 508         method.
 509         <can_highight, is_highlighted>: Now bool.
 510         (tui_set_win_highlight): Don't declare.
 511         * tui/tui-data.c (tui_set_win_highlight): Remove.
 512
 513 2019-06-25  Tom Tromey  <tom@tromey.com>
 514
 515         * tui/tui-wingeneral.c (make_visible): Remove check of window
 516         type.
 517
 518 2019-06-25  Tom Tromey  <tom@tromey.com>
 519
 520         * tui/tui-win.c (tui_win_info::max_height)
 521         (tui_cmd_window::max_height): New methods.
 522         (new_height_ok): Call max_height.
 523         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
 524         <max_height>: New method.
 525
 526 2019-06-25  Tom Tromey  <tom@tromey.com>
 527
 528         * tui/tui-win.c (tui_source_window_base::set_new_height)
 529         (tui_data_window::set_new_height): New methods.
 530         (make_invisible_and_set_new_height): Call set_new_height method.
 531         * tui/tui-data.h (struct tui_win_info)
 532         (struct tui_source_window_base, struct tui_data_window)
 533         <set_new_height>: New method.
 534
 535 2019-06-25  Tom Tromey  <tom@tromey.com>
 536
 537         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
 538         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
 539         tui_refresh_data_win.
 540         * tui/tui-win.c (tui_source_window_base::refresh_all): New
 541         method.
 542         (tui_refresh_all_win): Call the refresh_all method.
 543         (tui_set_focus): Likewise.
 544         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
 545         (struct tui_source_window_base, struct tui_data_window) <refresh>:
 546         Likewise.
 547
 548 2019-06-25  Tom Tromey  <tom@tromey.com>
 549
 550         * tui/tui-winsource.h (tui_refill_source_window)
 551         (tui_set_is_exec_point_at): Don't declare.
 552         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 553         (tui_source_window_base::refill): Rename from
 554         tui_refill_source_window.
 555         (tui_source_window_base::do_scroll_horizontal): Update.
 556         (tui_source_window_base::set_is_exec_point_at): Rename from
 557         tui_set_is_exec_point_at.
 558         (tui_update_all_breakpoint_info): Update.
 559         * tui/tui-stack.c (tui_show_frame_info): Update.
 560         * tui/tui-layout.c (show_data): Add cast.
 561         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
 562         * tui/tui-data.h (struct tui_source_window_base) <refill,
 563         set_is_exec_point_at>: New methods.
 564         (tui_source_windows, tui_add_to_source_windows): Update types.
 565         (tui_add_to_source_windows): Remove redundant declaration.
 566         * tui/tui-data.c (source_windows): Store tui_source_window_base.
 567         (tui_source_windows): Change return type.
 568         (tui_clear_source_windows_detail): Update.
 569         (tui_add_to_source_windows): Change type of parameter.
 570         (tui_free_all_source_wins_content): Update.
 571
 572 2019-06-25  Tom Tromey  <tom@tromey.com>
 573
 574         * tui/tui-wingeneral.c (tui_win_info::refresh)
 575         (tui_source_window_base::refresh): New methods.
 576         (tui_refresh_all): Call the refresh method.
 577         * tui/tui-data.h (struct tui_win_info)
 578         (struct tui_source_window_base) <refresh>: New method.
 579
 580 2019-06-25  Tom Tromey  <tom@tromey.com>
 581
 582         * tui/tui.h (tui_is_window_visible): Return bool.
 583         * tui/tui.c (tui_is_window_visible): Return bool.
 584         * tui/tui-wingeneral.c (tui_make_window, make_visible)
 585         (tui_make_visible, tui_make_invisible)
 586         (tui_win_info::make_visible)
 587         (tui_source_window_base::make_visible, make_all_visible)
 588         (tui_make_all_visible, tui_make_all_invisible): Update.
 589         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
 590         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
 591         bool.
 592         (struct tui_win_info, struct tui_source_window_base)
 593         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
 594         * tui/tui-data.c (tui_init_generic_part): Update.
 595
 596 2019-06-25  Tom Tromey  <tom@tromey.com>
 597
 598         * tui/tui-wingeneral.c (tui_win_info::make_visible)
 599         (tui_source_window_base::make_visible): New methods.
 600         (make_all_visible): Make method call.
 601         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
 602         (struct tui_source_window_base, struct tui_cmd_window): Override
 603         make_visible.
 604         (tui_win_is_source_type): Don't declare.
 605         * tui/tui-data.c (tui_win_is_source_type): Remove.
 606
 607 2019-06-25  Tom Tromey  <tom@tromey.com>
 608
 609         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
 610         NULL check.
 611
 612 2019-06-25  Tom Tromey  <tom@tromey.com>
 613
 614         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
 615         Inline constructor.  Add initializers for members.
 616         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
 617         constructors; now inline in class.
 618
 619 2019-06-25  Tom Tromey  <tom@tromey.com>
 620
 621         * tui/tui-regs.c (tui_show_registers): Update.
 622         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
 623         bool.
 624         * tui/tui-data.c (tui_data_window::clear_detail)
 625         (tui_data_window): Update.
 626
 627 2019-06-25  Tom Tromey  <tom@tromey.com>
 628
 629         * tui/tui-windata.c (tui_display_all_data)
 630         (tui_display_data_from_line, tui_display_data_from)
 631         (tui_check_data_values, tui_data_window::do_scroll_vertical):
 632         Update.
 633         * tui/tui-regs.c (tui_last_regs_line_no)
 634         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 635         (tui_show_registers, tui_show_register_group)
 636         (tui_display_registers_from, tui_display_reg_element_at_line)
 637         (tui_display_registers_from_line, tui_check_register_values)
 638         (tui_reg_next, tui_reg_prev): Update.
 639         * tui/tui-layout.c (tui_set_layout, show_data): Update.
 640         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
 641         tui_data_window.
 642         (struct tui_win_info) <detail>: Remove.  Add new fields from
 643         tui_data_info.
 644         (TUI_DATA_WIN): Add cast.
 645         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
 646         (~tui_data_window): Simplify.
 647
 648 2019-06-25  Tom Tromey  <tom@tromey.com>
 649
 650         * tui/tui-layout.c (show_source_disasm_command)
 651         (show_source_or_disasm_and_command): Update.
 652         * tui/tui-io.c (update_cmdwin_start_line)
 653         (tui_redisplay_readline): Update.
 654         * tui/tui-data.h (struct tui_command_info): Remove.
 655         (struct tui_win_info) <detail>: Remove command_info member.
 656         (struct tui_data_window) <start_line>: New member, from
 657         tui_command_info.
 658         (TUI_CMD_WIN): Add casts.
 659
 660 2019-06-25  Tom Tromey  <tom@tromey.com>
 661
 662         * tui/tui-winsource.c (tui_update_source_window)
 663         (tui_refill_source_window)
 664         (tui_source_window_base::do_scroll_horizontal)
 665         (tui_update_breakpoint_info, tui_set_exec_info_content)
 666         (tui_show_exec_info_content, tui_erase_exec_info_content)
 667         (tui_clear_exec_info_content): Update.
 668         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
 669         Update.
 670         * tui/tui-win.c (make_invisible_and_set_new_height)
 671         (make_visible_with_new_height): Update.
 672         * tui/tui-source.c (tui_set_source_content)
 673         (tui_show_symtab_source): Update.
 674         * tui/tui-layout.c (extract_display_start_addr)
 675         (show_source_disasm_command, show_data)
 676         (make_source_or_disasm_window)
 677         (show_source_or_disasm_and_command): Update.
 678         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
 679         (tui_disasm_window::do_scroll_vertical): Remove shadowing
 680         "gdbarch".
 681         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
 682         to tui_source_window_base.
 683         (struct tui_win_info) <detail>: Remove source_info member.
 684         (struct tui_source_window_base) <has_locator>: Inline.
 685         Move contents from tui_source_info; rename has_locator member to
 686         m_has_locator.
 687         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
 688         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
 689         header file.
 690         (tui_source_window_base::clear_detail, ~tui_source_window_base):
 691         Simplify.
 692         (tui_free_all_source_wins_content): Cast to
 693         tui_source_window_base.
 694
 695 2019-06-25  Tom Tromey  <tom@tromey.com>
 696
 697         * tui/tui-win.c (make_invisible_and_set_new_height)
 698         (make_visible_with_new_height): Call has_locator method.
 699         * tui/tui-layout.c (show_source_disasm_command, show_data)
 700         (show_source_or_disasm_and_command): Update for bool change.
 701         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
 702         (tui_win_info) <has_locator>: New method.
 703         (struct tui_source_window_base) <has_locator>: New method.
 704         (tui_win_has_locator): Don't declare.
 705         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
 706         from tui_win_has_locator.
 707         (tui_source_window_base): Use false, not FALSE.
 708
 709 2019-06-25  Tom Tromey  <tom@tromey.com>
 710
 711         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
 712         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
 713         clear_detail method directly.
 714         (tui_clear_win_detail): Remove.
 715
 716 2019-06-25  Tom Tromey  <tom@tromey.com>
 717
 718         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
 719         "this", not TUI_DISASM_WIN.
 720
 721 2019-06-25  Tom Tromey  <tom@tromey.com>
 722
 723         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
 724         declare.
 725         * tui/tui-winsource.c
 726         (tui_source_window_base::do_scroll_horizontal): Rename from
 727         tui_horizontal_source_scroll.
 728         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
 729         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
 730         from tui_vertical_data_scroll.
 731         * tui/tui-win.h (tui_scroll): Don't declare.
 732         * tui/tui-win.c (tui_win_info::forward_scroll)
 733         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 734         (tui_win_info::right_scroll): Rename and update.
 735         (tui_scroll_forward_command, tui_scroll_backward_command)
 736         (tui_scroll_left_command, tui_scroll_right_command): Update.
 737         (tui_scroll): Remove.
 738         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
 739         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
 740         from tui_vertical_source_scroll.
 741         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
 742         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
 743         from tui_vertical_disassem_scroll.
 744         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
 745         do_scroll_horizontal>: New methods.
 746         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
 747         Likewise.
 748         (struct tui_source_window_base): Add do_scroll_horizontal.
 749         (struct tui_source_window, struct tui_disasm_window): Add
 750         do_scroll_vertical.
 751         (struct tui_data_window, struct tui_cmd_window): Add
 752         do_scroll_horizontal and do_scroll_vertical.
 753         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
 754
 755 2019-06-25  Tom Tromey  <tom@tromey.com>
 756
 757         * tui/tui-data.h (struct tui_source_window_base): New struct.
 758         (struct tui_source_window): Derive from tui_source_window_base.
 759         (struct tui_disasm_window): New struct.
 760         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
 761         from tui_source_window::clear_detail.
 762         (tui_source_window_base): Rename from tui_source_window.
 763         (~tui_source_window_base): Rename from ~tui_source_window.
 764         (tui_alloc_win_info): Create a tui_disasm_window.
 765
 766 2019-06-25  Tom Tromey  <tom@tromey.com>
 767
 768         * tui/tui-data.h (struct tui_source_window)
 769         (struct tui_data_window): Declare destructors.
 770         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
 771         destructors.
 772         (tui_win_info): Simplify.
 773
 774 2019-06-25  Tom Tromey  <tom@tromey.com>
 775
 776         * tui/tui-winsource.c (tui_display_main)
 777         (tui_update_source_windows_with_addr)
 778         (tui_update_all_breakpoint_info): Update.
 779         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 780         (new_height_ok, parse_scrolling_args): Update.
 781         * tui/tui-stack.c (tui_show_frame_info): Update.
 782         * tui/tui-data.h (struct tui_list): Remove.
 783         (tui_source_windows): Return a reference to a std::vector.
 784         * tui/tui-data.c (source_windows): Now a std::vector.
 785         (tui_source_windows): Change return type.
 786         (tui_clear_source_windows): Rewrite.
 787         (tui_clear_source_windows_detail, tui_add_to_source_windows)
 788         (tui_free_all_source_wins_content): Rewrite.
 789
 790 2019-06-25  Tom Tromey  <tom@tromey.com>
 791
 792         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
 793         (struct tui_data_window, struct tui_cmd_window): Declare
 794         clear_detail method.
 795         * tui/tui-data.c (tui_source_window::clear_detail)
 796         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
 797         methods.
 798         (tui_clear_win_detail): Simplify.
 799
 800 2019-06-25  Tom Tromey  <tom@tromey.com>
 801
 802         * tui/tui-layout.c (make_source_window, make_disasm_window)
 803         (make_source_or_disasm_window): Remove win_info_ptr parameter.
 804         Return the new window.
 805         (show_source_disasm_command, show_data)
 806         (show_source_or_disasm_and_command): Update.
 807
 808 2019-06-25  Tom Tromey  <tom@tromey.com>
 809
 810         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
 811         parameter.  Return the new window.
 812         (show_source_disasm_command): Update and remove NULL check.
 813         (show_source_or_disasm_and_command): Update.
 814
 815 2019-06-25  Tom Tromey  <tom@tromey.com>
 816
 817         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
 818
 819 2019-06-25  Tom Tromey  <tom@tromey.com>
 820
 821         * tui/tui-data.h (struct tui_win_info): Make constructor
 822         protected.  Make destructor virtual.  Add initializers.
 823         (tui_source_window, tui_data_window, tui_cmd_window): New
 824         classes.
 825         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
 826         constructor.  Add "type" parameter.
 827         (tui_source_window, tui_data_window, tui_cmd_window): New
 828         constructors.
 829         (tui_alloc_win_info): Instantiate the appropriate subclass.
 830
 831 2019-06-25  Tom Tromey  <tom@tromey.com>
 832
 833         * tui/tui-win.c (tui_resize_all): Use delete.
 834         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
 835         destructor.
 836         (tui_free_window): Don't declare.
 837         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
 838         Update.
 839
 840 2019-06-25  Tom Tromey  <tom@tromey.com>
 841
 842         * tui/tui-data.h (struct tui_win_info): Add constructor.
 843         * tui/tui-data.c (tui_alloc_win_info): Use new.
 844         (tui_free_window): Use delete.
 845
 846 2019-06-22  Tom Tromey  <tom@tromey.com>
 847
 848         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
 849         declare.
 850         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
 851
 852 2019-06-22  Tom Tromey  <tom@tromey.com>
 853
 854         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
 855         declare.
 856         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
 857
 858 2019-06-22  Tom de Vries  <tdevries@suse.de>
 859
 860         * dwarf2read.c (create_addrmap_from_aranges)
 861         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
 862         instead of '%zu'.
 863
 864 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
 865
 866         * dwarf2read.h (dwarf2_section_info_def): Remove.
 867         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
 868         * dwarf2read.c (struct dwo_sections) <types>: Change type to
 869         std::vector<dwarf2_section_info>.
 870         (struct dwo_file) <~dwo_file>: Remove.
 871         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
 872         types field.
 873         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
 874         (dwarf2_read_debug_names): Likewise.
 875         (create_debug_types_hash_table): Change parameter type to
 876         array_view, adjust code accordingly.
 877         (dwarf2_locate_dwo_sections): Adjust to std::vector.
 878         (partial_die_info::fixup): Likewise.
 879         (determine_prefix): Likewise.
 880         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
 881
 882 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 883
 884         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
 885         gdb_bfd_ref_ptr.
 886         <~dwo_file>: Remove call to gdb_bfd_unref.
 887         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
 888         gdb_bfd_ref_ptr::get.
 889
 890 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 891
 892         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
 893         type to htab_up.
 894         * dwarf2read.c (struct dwo_file): Initialize fields.
 895         <~dwo_file>: New.
 896         (free_dwo_file): Remove, move content to ~dwo_file.
 897         (struct dwo_file_deleter): Remove.
 898         (dwo_file_up>: Remove custom deleter.
 899         (free_dwo_files): Remove.
 900         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
 901         dwo_files.
 902         (process_skeletonless_type_units): Call unique_ptr::get.
 903         (allocate_dwo_file_hash_table): Add deleter to created hash
 904         table.  Change return type to htab_up.
 905         (lookup_dwo_file_slot): Don't memset dwo_file, call
 906         unique_ptr::get.
 907         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
 908         (create_dwo_unit_in_dwp_v2): Likewise.
 909         (open_and_init_dwo_file): Likewise.
 910         (free_dwo_file_from_slot): Remove.
 911
 912 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 913
 914         * dwarf2read.h (struct dwarf2_section_info) <readin,
 915         is_virtual>: Change type to bool.
 916         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
 917         true instead of 1.
 918
 919 2019-06-19  Tom Tromey  <tom@tromey.com>
 920
 921         * tui/tui-data.h (tui_init_content_element): Don't declare.
 922
 923 2019-06-19  Tom Tromey  <tom@tromey.com>
 924
 925         * tui/tui-data.h (tui_init_win_info): Don't declare.
 926
 927 2019-06-19  Tom de Vries  <tdevries@suse.de>
 928
 929         * dwarf2read.h (abstract_to_concrete): Change type to
 930         std::unordered_map<sect_offset, std::vector<sect_offset>,
 931         gdb::hash_enum<sect_offset>>.
 932
 933 2019-06-19  Tom Tromey  <tromey@adacore.com>
 934
 935         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
 936         EVAL_AVOID_SIDE_EFFECTS specially.
 937
 938 2019-06-19  Tom Tromey  <tromey@adacore.com>
 939
 940         * source-cache.c (highlighter): New global.
 941         (source_cache::get_source_lines): Create a highlighter on demand.
 942
 943 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 944
 945         * defs.h (deprecated_interactive_hook): Delete declaration.
 946         * interps.c (clear_interpreter_hooks): Remove use of
 947         deprecated_interactive_hook.
 948         * top.c (deprecated_interactive_hook): Delete definition.
 949         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
 950
 951 2019-06-18  Tom de Vries  <tdevries@suse.de>
 952
 953         PR gdb/24515
 954         * dwarf2read.h (abstract_to_concrete): Change type from
 955         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
 956         std::unordered_map<sect_offset, std::vector<sect_offset>>.
 957         * dwarf2read.c (read_variable): Update.
 958         (dwarf2_fetch_die_loc_sect_off): Update.
 959
 960 2019-06-17  Tom de Vries  <tdevries@suse.de>
 961
 962         PR gdb/24617
 963         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
 964         accessing parent[parent_len - 1].
 965
 966 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
 967
 968         PR gdb/24364
 969         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
 970         call dtrace_process_dof with NULL dof.
 971
 972 2019-06-16  Tom de Vries  <tdevries@suse.de>
 973
 974         PR gdb/24445
 975         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
 976
 977 2019-06-16  Tom Tromey  <tom@tromey.com>
 978
 979         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 980         (make_all_visible): Use address of member.
 981
 982 2019-06-16  Tom Tromey  <tom@tromey.com>
 983
 984         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
 985         (tui_free_window, free_content, free_content_elements): Remove
 986         unnecessary cast.
 987         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
 988         cast.
 989         * tui/tui-regs.c (tui_show_register_group)
 990         (tui_display_registers_from, tui_display_reg_element_at_line):
 991         Remove unnecessary cast.
 992
 993 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
 994
 995         * linux-nat.c (normal_mask): Delete.
 996         (_initialize_linux_nat): Don't initialise normal_mask.
 997
 998 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
 999
1000         PR gdb/24445
1001         * dwarf-index-write.h (write_psymtabs_to_index): Add
1002         dwz_basename parameter.
1003         * dwarf-index-write.c (write_gdbindex): Move file writing to
1004         write_gdbindex_1.  Change return type void.
1005         (assert_file_size): Move up, remove filename parameter.
1006         (write_gdbindex_1): New function.
1007         (write_debug_names): Change return type to void, call
1008         assert_file_size.
1009         (struct index_wip_file): New struct.
1010         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
1011         file logic to index_wip_file.  Write index for dwz file if
1012         needed.
1013         (save_gdb_index_command): Pass basename of dwz file, if present.
1014         * dwarf-index-cache.c (index_cache::store): Obtain and pass
1015         build-id of dwz file, if present.
1016         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
1017         (dwarf2_get_dwz_file): Likewise.
1018         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1019         (dwarf2_get_dwz_file): Likewise.
1020
1021 2019-06-16  Tom Tromey  <tom@tromey.com>
1022
1023         * coffread.c (process_coff_symbol): Use xstrdup.
1024         * value.c (create_internalvar): Use xstrdup.
1025
1026 2019-06-16  Tom Tromey  <tom@tromey.com>
1027
1028         * valops.c (value_cast, value_slice): Remove unnecessary cast.
1029         * breakpoint.c (stopin_command, stopat_command)
1030         (until_break_command, decode_location_default): Remove unnecessary
1031         cast.
1032         * utils.c (subset_compare): Remove unnecessary cast.
1033         * ada-lang.c (ada_update_initial_language): Remove unnecessary
1034         cast.
1035         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
1036         cast.
1037         * infcmd.c (path_command): Remove unnecessary cast.
1038         * coffread.c (decode_type): Remove unnecessary cast.
1039         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
1040         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
1041         * tui/tui-stack.c (tui_show_locator_content)
1042         (tui_show_frame_info): Remove unnecessary cast.
1043         * tui/tui-win.c (tui_scroll_forward_command)
1044         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
1045         (parse_scrolling_args): Remove unnecessary cast.
1046         * tui/tui-data.c (init_win_info, tui_del_window)
1047         (tui_free_window, tui_del_data_windows, tui_free_data_content)
1048         (free_content_elements): Remove unnecessary cast.
1049         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
1050         unnecessary cast.
1051         * tui/tui-source.c (tui_set_source_content)
1052         (tui_vertical_source_scroll): Remove unnecessary cast.
1053         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
1054         cast.
1055         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
1056         * tui/tui-regs.c (tui_display_registers_from)
1057         (tui_display_register): Remove unnecessary cast.
1058         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
1059         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
1060         (make_visible): Remove unnecessary cast.
1061         * tui/tui-winsource.c (tui_erase_source_content)
1062         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
1063         unnecessary cast.
1064         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
1065         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
1066         * stabsread.c (read_type, read_array_type, read_range_type):
1067         Remove unnecessary cast.
1068         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
1069         (parse_symbol, parse_type, upgrade_type, parse_external)
1070         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
1071         unnecessary cast.
1072         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
1073
1074 2019-06-16  Tom Tromey  <tom@tromey.com>
1075
1076         * tui/tui-data.c (tui_alloc_generic_win_info)
1077         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
1078         checks.
1079
1080 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
1081             Andrew Burgess  <andrew.burgess@embecosm.com>
1082
1083         * f-typeprint.c (f_print_type): Don't return early for not
1084         associated or not allocated types.
1085         (f_type_print_varspec_suffix): Add print_rank parameter and print
1086         ranks of array types in case they dangling.
1087         (f_type_print_base): Add print_rank parameter.
1088
1089 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1090
1091         * NEWS: Mention new MI commands.
1092         * break-catch-throw.c (enum exception_event_kind): Move to
1093         breakpoint.h.
1094         (print_mention_exception_catchpoint): Output text as a single
1095         message.
1096         (catch_exception_command_1): Rename to...
1097         (catch_exception_event): ...this, make non-static, update header
1098         command, and change some parameter types.
1099         (catch_catch_command): Update for changes to
1100         catch_exception_command_1.
1101         (catch_throw_command): Likewise.
1102         (catch_rethrow_command): Likewise.
1103         * breakpoint.c (enum exception_event_kind): Delete.
1104         * breakpoint.h (enum exception_event_kind): Moved here from
1105         break-catch-throw.c.
1106         (catch_exception_event): Declare.
1107         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
1108         (mi_cmd_catch_throw): New function.
1109         (mi_cmd_catch_rethrow): New function.
1110         (mi_cmd_catch_catch): New function.
1111         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
1112         'catch-catch' entries.
1113         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
1114         (mi_cmd_catch_rethrow): Declare.
1115         (mi_cmd_catch_catch): Declare.
1116
1117 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1118
1119         * annotate.c (annotate_source_line): Change return type to void,
1120         update implementation to match.
1121         * annotate.h (annotate_source_line): Change return type to void,
1122         update header comment.
1123         * stack.c (print_frame_info): Don't change what frame information
1124         is printed based on whether annotations are on or not.
1125
1126 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1127
1128         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
1129         (annotate_source): Make static.
1130         (annotate_source_line): Moved from source.c and renamed from
1131         identify_source_line.  Update the return type.
1132         * annotate.h (annotate_source): Delete declaration.
1133         (annotate_source_line): Declaration moved from source.h, and
1134         renamed from identify_source_line.  Return type updated.
1135         * source.c (identify_source_line): Moved to annotate.c and renamed
1136         to annotate_source_line.
1137         (info_line_command): Remove check of annotation_level.
1138         * source.h (identify_source_line): Move declaration to annotate.h
1139         and rename to annotate_source_line.
1140         * stack.c: Add 'annotate.h' include.
1141         (print_frame_info): Remove check of annotation_level before
1142         calling annotate_source_line.
1143
1144 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1145
1146         * source-cache.c (source_cache::get_plain_source_lines): Use
1147         open_source_file_with_line_charpos instead of just
1148         open_source_file, remove call to find_source_lines.
1149         (source_cache::get_source_lines): Likewise.
1150         * source.c (find_source_lines): Make static.
1151         (get_filename_and_charpos): Renamed into...
1152         (open_source_file_with_line_charpos): ..this along with changes to
1153         return a scoped_fd, and some other minor clean ups.
1154         (identify_source_line): Use open_source_file_with_line_charpos.
1155         (search_command_helper): Use open_source_file_with_line_charpos
1156         instead of just open_source_file, remove call to
1157         find_source_lines.
1158         * source.h (open_source_file_with_line_charpos): Declare new
1159         function.
1160         (find_source_lines): Delete declaration.
1161
1162 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1163
1164         * source.c (get_filename_and_charpos): Remove fullname
1165         parameter.
1166         (identify_source_line): Update call to get_filename_and_charpos.
1167
1168 2019-06-14  Tom Tromey  <tromey@adacore.com>
1169
1170         PR gdb/24502:
1171         * ui-style.h (skip_ansi_escape): Update comment.
1172         * ui-file.h (class no_terminal_escape_file): New class.
1173         * ui-file.c (no_terminal_escape_file::write)
1174         (no_terminal_escape_file::puts): New methods.
1175         * cli/cli-logging.c (handle_redirections): Use
1176         no_terminal_escape_file.
1177
1178 2019-06-14  Tom Tromey  <tromey@adacore.com>
1179
1180         * NEWS: Move convenience variable news above Python news.
1181
1182 2019-06-14  Tom Tromey  <tom@tromey.com>
1183
1184         * gnulib: Move directory to top-level.
1185         * configure.ac: Don't configure gnulib.
1186         * configure: Rebuild.
1187         * common/common-defs.h: Use new path to gnulib.
1188         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
1189         (GNULIB_H): Remove.
1190         (INCGNU): Look in new gnulib location.
1191         (HFILES_NO_SRCDIR): Remove gnulib files.
1192         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
1193         (generated_files): Remove GNULIB_H.
1194         ($(LIBGNU), all-lib): Remove targets.
1195         (distclean): Don't mention GNULIB_BUILDDIR.
1196         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
1197
1198 2019-06-14  Tom Tromey  <tromey@adacore.com>
1199
1200         * symfile.c (add_symbol_file_command): Remove obsolete comment.
1201         Warn if symbol file does not provide any symbols.
1202
1203 2019-06-14  Tom Tromey  <tromey@adacore.com>
1204
1205         * source.c (find_and_open_source): Respect basenames_may_differ.
1206
1207 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
1208
1209         * annotate.c (annotate_breakpoints_invalid): Make use of
1210         scoped_restore_terminal_state.
1211         (annotate_frames_invalid): Likewise.
1212
1213 2019-06-14  Tom Tromey  <tromey@adacore.com>
1214
1215         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
1216         allow assignment to an internalvar.
1217
1218 2019-06-14  Tom Tromey  <tromey@adacore.com>
1219
1220         * ada-lex.l: Allow "_" in attribute names.
1221
1222 2019-06-14  Tom Tromey  <tromey@adacore.com>
1223
1224         PR gdb/24653:
1225         * regcache.c (registers_changed): Don't call alloca.
1226         * top.c (execute_command): Don't call alloca.
1227
1228 2019-06-13  Pedro Alves  <palves@redhat.com>
1229
1230         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
1231         'expression'.  When parsing an expression, error out if there's
1232         junk after "unlimited".
1233         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1234         (do_set_command): Adjust calls to is_unlimited_literal.
1235
1236 2019-06-13  Pedro Alves  <palves@redhat.com>
1237
1238         * compile/compile.c (make_compile_options_def_group): Add braces
1239         around array_view initializer.
1240         * thread.c (make_thread_apply_all_options_def_group)
1241         (make_thread_apply_all_options_def_group): Likewise.
1242
1243 2019-06-13  Pedro Alves  <palves@redhat.com>
1244
1245         * NEWS (New commands): Mention "maint test-options
1246         require-delimiter", "maint test-options unknown-is-error", "maint
1247         test-options unknown-is-operand" and "maint show
1248         test-options-completion-result".
1249         (New command options, command completion): New section.
1250         (Completion improvements): New section.
1251         Mention that you can abbreviate "unlimited".
1252
1253 2019-06-13  Pedro Alves  <palves@redhat.com>
1254
1255         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
1256         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
1257         * unittests/cli-utils-selftests.c (test_parse_flags)
1258         (test_parse_flags_qcs): Delete.
1259         (test_cli_utils): Don't call deleted functions.
1260
1261 2019-06-13  Pedro Alves  <palves@redhat.com>
1262
1263         * thread.c: Include "cli/cli-option.h".
1264         (tp_array_compar_ascending): Global.
1265         (tp_array_compar): Delete function.
1266         (tp_array_compar_ascending, tp_array_compar_descending): New
1267         functions.
1268         (ascending_option_def, qcs_flag_option_def)
1269         (thr_qcs_flags_option_defs)
1270         (make_thread_apply_all_options_def_group)
1271         (make_thread_apply_options_def_group): New.
1272         (thread_apply_all_command): Use gdb::option::process_options.
1273         (thread_apply_command_completer)
1274         (thread_apply_all_command_completer): New.
1275         (thread_apply_command): Use gdb::option::process_options.
1276         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
1277         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
1278         to generate help text of "thread apply".  Adjust "taas"'s help.
1279         * tid-parse.c (tid_range_parser::in_thread_range): New method.
1280         * tid-parse.h (tid_range_parser::in_thread_range): New method.
1281
1282 2019-06-13  Pedro Alves  <palves@redhat.com>
1283
1284         * thread.c (thread_apply_command): Check for invalid TID with
1285         isdigit instead of !isalpha.
1286
1287 2019-06-13  Pedro Alves  <palves@redhat.com>
1288
1289         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
1290         (validate_flags_qcs): New.
1291         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
1292         (validate_flags_qcs): Declare.
1293         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
1294         (make_frame_apply_options_def_group): New.
1295         (frame_apply_command_count): Process options with
1296         gdb::option::process_options.
1297         (frame_apply_completer): New.
1298         (frame_apply_level_completer, frame_apply_all_completer)
1299         (frame_apply_completer): New.
1300         (_initialize_stack): Update help of "frame apply", "frame apply
1301         level", "frame apply all" and "faas" to mention supported options
1302         and install command completers.
1303         * stack.h (frame_apply_all_completer): Declare.
1304         * thread.c: Include "stack.h".
1305         (tfaas_command): Add "--".
1306         (_initialize_thread): Update help "tfaas" to mention supported
1307         options and install command completer.
1308
1309 2019-06-13  Pedro Alves  <palves@redhat.com>
1310
1311         * completer.c (complete_nested_command_line): New.
1312         (gdb_completion_word_break_characters_throw): Add assertion.
1313         * completer.h (complete_nested_command_line): Declare.
1314
1315 2019-06-13  Pedro Alves  <palves@redhat.com>
1316
1317         * stack.c (parse_backtrace_qualifiers): New.
1318         (backtrace_command): Use it.
1319         (backtrace_command_completer): Complete on qualifiers.
1320
1321 2019-06-13  Pedro Alves  <palves@redhat.com>
1322
1323         * frame.c: Include "cli/cli-option.h.
1324         (user_set_backtrace_options): New.
1325         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
1326         Delete.
1327         (get_prev_frame): Adjust.
1328         (boolean_option_def, uinteger_option_def)
1329         (set_backtrace_option_defs): New.
1330         (_initialize_frame): Adjust and use
1331         gdb::option::add_setshow_cmds_for_options to install "set
1332         backtrace past-main" and "set backtrace past-entry".
1333         * frame.h: Include "cli/cli-option.h".
1334         (struct frame_print_options): Forward declare.
1335         (print_frame_arguments_all, print_frame_arguments_scalars)
1336         (print_frame_arguments_none): Declare.
1337         (print_entry_values): Delete declaration.
1338         (struct frame_print_options, user_frame_print_options): New.
1339         (struct set_backtrace_options): New.
1340         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
1341         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
1342         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
1343         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
1344         (list_args_or_locals): Add frame_print_options parameter.
1345         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1346         * python/py-framefilter.c (enumerate_args): Pass down
1347         USER_FRAME_PRINT_OPTIONS.
1348         * stack.c: Include "cli/cli-option.h".
1349         (print_frame_arguments_all, print_frame_arguments_scalars)
1350         (print_frame_arguments_none): Declare.
1351         (print_raw_frame_arguments, print_entry_values): Delete.
1352         (user_frame_print_options): New.
1353         (boolean_option_def, enum_option_def, frame_print_option_defs):
1354         New.
1355         (struct backtrace_cmd_options): New.
1356         (bt_flag_option_def): New.
1357         (backtrace_command_option_defs): New.
1358         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1359         (print_frame_arg, read_frame_arg, print_frame_args)
1360         (print_frame_info, print_frame): Add frame_print_options parameter
1361         and use it.
1362         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
1363         (backtrace_command_1): Add frame_print_options and
1364         backtrace_cmd_options parameters and use them.
1365         (make_backtrace_options_def_group): New.
1366         (backtrace_command): Process command options with
1367         gdb::option::process_options.
1368         (backtrace_command_completer): New.
1369         (_initialize_stack): Extend "backtrace"'s help to mention
1370         supported options.  Install completer for "backtrace".
1371         Install some settings commands with add_setshow_cmds_for_options.
1372
1373 2019-06-13  Pedro Alves  <palves@redhat.com>
1374
1375         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
1376         and that "set/show print raw frame-arguments" are now deprecated.
1377
1378         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
1379         command.
1380         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
1381         * stack.c (_initialize_stack): Install "set/show print
1382         raw-frame-arguments", and deprecate "set/show print raw
1383         frame-arguments".
1384         * valprint.c (_initialize_valprint): Deprecate "set/show print
1385         raw".
1386
1387 2019-06-13  Pedro Alves  <palves@redhat.com>
1388
1389         * compile/compile.c (struct compile_options): New.
1390         (compile_flag_option_def, compile_command_option_defs)
1391         (make_compile_options_def_group): New.
1392         (compile_file_command): Handle options with
1393         gdb::option::process_options.
1394         (compile_file_command_completer): New function.
1395         (compile_code_command): Handle options with
1396         gdb::option::process_options.
1397         (compile_code_command_completer): New function.
1398         (_initialize_compiler): Install completers for "compile code" and
1399         "compile file".  Mention available options in "compile code" and
1400         "compile code"'s help.
1401         * completer.c (advance_to_completion_word): New, factored out from
1402         ...
1403         (advance_to_expression_complete_word_point): ... this.
1404         (advance_to_filename_complete_word_point): New.
1405         * completer.h (advance_to_filename_complete_word_point): New
1406         declaration.
1407
1408 2019-06-13  Pedro Alves  <palves@redhat.com>
1409
1410         * compile/compile.c: Include "cli/cli-option.h".
1411         (compile_print_value): Scope data pointer is now a
1412         value_print_options pointer; adjust.
1413         (compile_print_command): Process options.  Scope data pointer is
1414         now a value_print_options pointer; adjust.
1415         (_initialize_compile): Update "compile print"'s help to include
1416         supported options.  Install a completer for "compile print".
1417         * cp-valprint.c (show_vtblprint, show_objectprint)
1418         (show_static_field_print): Delete.
1419         (_initialize_cp_valprint): Don't install "set print
1420         static-members", "set print vtbl", "set print object" here.
1421         * printcmd.c: Include "cli/cli-option.h" and
1422         "common/gdb_optional.h".
1423         (print_command_parse_format): Rework to fill in a
1424         value_print_options instead of a format_data.
1425         (print_value): Change parameter type from format_data pointer to
1426         value_print_options reference.  Adjust.
1427         (print_command_1): Process options.  Adjust to pass down a
1428         value_print_options.
1429         (print_command_completer): New.
1430         (_initialize_printcmd): Install print_command_completer as
1431         handle_brkchars completer for the "print" command.  Update
1432         "print"'s help to include supported options.
1433         * valprint.c: Include "cli/cli-option.h".
1434         (show_vtblprint, show_objectprint, show_static_field_print): Moved
1435         here from cp-valprint.c.
1436         (boolean_option_def, uinteger_option_def)
1437         (value_print_option_defs, make_value_print_options_def_group):
1438         New.  Use gdb::option::add_setshow_cmds_for_options to install
1439         "set print elements", "set print null-stop", "set print repeats",
1440         "set print pretty", "set print union", "set print array", "set
1441         print address", "set print symbol", "set print array-indexes".
1442         * valprint.h: Include <string> and "cli/cli-option.h".
1443         (make_value_print_options_def_group): Declare.
1444         (print_value): Change parameter type from format_data pointer to
1445         value_print_options reference.
1446         (print_command_completer): Declare.
1447
1448 2019-06-13  Pedro Alves  <palves@redhat.com>
1449
1450         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
1451         (COMMON_SFILES): Add maint-test-settings.c.
1452         * cli/cli-decode.c (boolean_enums): New global, factored out from
1453         ...
1454         (add_setshow_boolean_cmd): ... here.
1455         * cli/cli-decode.h (boolean_enums): Declare.
1456         * cli/cli-option.c: New file.
1457         * cli/cli-option.h: New file.
1458         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
1459         factored out from ...
1460         (parse_cli_boolean_value(const char *)): ... this.
1461         (is_unlimited_literal): Change parameter type to pointer to
1462         pointer.  Adjust and advance ARG pointer.
1463         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1464         (parse_cli_var_enum): New, factored out from ...
1465         (do_set_command): ... this.  Adjust.
1466         * cli/cli-setshow.h (parse_cli_boolean_value)
1467         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1468         (parse_cli_var_enum): Declare.
1469         * cli/cli-utils.c: Include "cli/cli-option.h".
1470         (get_ulongest): New.
1471         * cli/cli-utils.h (get_ulongest): Declare.
1472         (check_for_argument): New overloads.
1473         * maint-test-options.c: New file.
1474
1475 2019-06-13  Pedro Alves  <palves@redhat.com>
1476
1477         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
1478         parse a range if "-" is at the end of the string.
1479
1480 2019-06-13  Pedro Alves  <palves@redhat.com>
1481
1482         * cli/cli-setshow.c (parse_auto_binary_operation)
1483         (parse_cli_boolean_value): Don't allow "o".
1484
1485 2019-06-13  Pedro Alves  <palves@redhat.com>
1486
1487         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
1488         * NEWS: Mention maint test-settings KIND.
1489         * maint-test-settings.c: New file.
1490
1491 2019-06-13  Pedro Alves  <palves@redhat.com>
1492
1493         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
1494         completer.
1495         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
1496         "set" completers.
1497
1498 2019-06-13  Pedro Alves  <palves@redhat.com>
1499
1500         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
1501         after item.
1502
1503 2019-06-13  Pedro Alves  <palves@redhat.com>
1504
1505         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
1506
1507 2019-06-13  Pedro Alves <palves@redhat.com>
1508
1509         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
1510         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
1511         call.
1512         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
1513         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
1514         calls.
1515         (check_for_argument): Skip spaces after argument.
1516
1517 2019-06-13  Pedro Alves  <palves@redhat.com>
1518
1519         * thread.c (thread_apply_command): Adjust TID parsing.
1520         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
1521         detected before end of string.
1522         (tid_is_in_list): Error out if LIST is invalid.
1523
1524 2019-06-13  Pedro Alves  <palves@redhat.com>
1525
1526         * completer.c (complete_line_internal_1): Rewind completion word
1527         point.
1528         (completion_tracker::advance_custom_word_point_by): Change
1529         parameter type to int.
1530         * completer.h (completion_tracker::advance_custom_word_point_by):
1531         Likewise.
1532
1533 2019-06-13  Pedro Alves  <palves@redhat.com>
1534
1535         * completer.c (advance_to_completion_word): Handle delimiters.
1536
1537 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
1538
1539         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
1540
1541 2019-06-11  Tom Tromey  <tom@tromey.com>
1542
1543         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
1544         (xmalloc_failed): Move to alloc.c.
1545         * alloc.c: New file.
1546         * Makefile.in (COMMON_SFILES): Add alloc.c.
1547
1548 2019-06-11  Tom Tromey  <tom@tromey.com>
1549
1550         * nat/linux-waitpid.c: Don't include server.h.
1551         (linux_debug): Remove.
1552         (my_waitpid): Update.
1553
1554 2019-06-11  Tom Tromey  <tromey@adacore.com>
1555
1556         * infcall.c (_initialize_infcall): Remove trailing newline from
1557         help.
1558         * user-regs.c (_initialize_user_regs): Remove trailing newline
1559         from help.
1560         * typeprint.c (_initialize_typeprint): Remove trailing newline
1561         from help.
1562         * reverse.c (_initialize_reverse): Remove trailing newlines from
1563         help.
1564         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
1565         from help.
1566         * language.c (add_set_language_command): Remove trailing newline
1567         from help.
1568         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
1569         help.
1570         * disasm.c (_initialize_disasm): Remove trailing newline from
1571         help.
1572         * top.c (init_main): Remove trailing newline from help.
1573         * interps.c (_initialize_interpreter): Remove trailing newline
1574         from help.
1575         * btrace.c (_initialize_btrace): Remove trailing newlines from
1576         help.
1577         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
1578         from help.
1579         * python/python.c (_initialize_python): Remove trailing newline
1580         from help.
1581         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
1582         help.
1583         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
1584         from help.  Reformat some text.
1585         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
1586         from help.
1587         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
1588         newline from help.
1589
1590 2019-06-11  Tom Tromey  <tromey@adacore.com>
1591
1592         * darwin-nat.c (darwin_decode_exception_message)
1593         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
1594
1595 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1596
1597         * valops.c (value_slice): Check for not allocated or not
1598         associated values.
1599
1600 2019-06-10  Tom de Vries  <tdevries@suse.de>
1601
1602         PR gdb/24618
1603         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
1604         sure an empty slot (defined by a 32-bit zero pair) is recognized as
1605         invalid.
1606
1607 2019-06-10  Tom de Vries  <tdevries@suse.de>
1608
1609         PR gdb/24611
1610         * linespec.c (linespec_lexer_lex_string): Remove incorrect
1611         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
1612
1613 2019-06-10  Tom de Vries  <tdevries@suse.de>
1614
1615         PR symtab/24545
1616         * symtab.c (struct demangled_name_entry): Add language field.
1617         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
1618         static minimal symbol".  Set and use language field.
1619
1620 2019-06-10  Tom Tromey  <tromey@adacore.com>
1621
1622         * ada-lang.c (_initialize_ada_language): Update help text.
1623
1624 2019-06-10  Tom Tromey  <tromey@adacore.com>
1625
1626         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
1627         with a newline.
1628         * guile/guile.c (handle_boot_error): Don't end warning with a
1629         newline.
1630         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
1631         warning with a newline.
1632         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
1633         newline.
1634         (s12z_frame_cache): Likewise.
1635         * dwarf-index-cache.c (index_cache::store): Don't end warning with
1636         a newline.
1637         * solib-svr4.c (disable_probes_interface): Don't end warning with
1638         a newline.
1639         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
1640         newline.
1641         * python/python.c (do_finish_initialization): Don't end warning
1642         with a newline.
1643
1644 2019-06-10  Tom Tromey  <tom@tromey.com>
1645
1646         * python/py-breakpoint.c (gdbpy_breakpoint_created)
1647         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
1648         gdbpy_enter.
1649
1650 2019-06-10  Tom Tromey  <tromey@adacore.com>
1651
1652         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
1653         data.
1654         (elf_new_init): Don't call stabsread_new_init.
1655         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
1656         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
1657         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
1658
1659 2019-06-10  Tom de Vries  <tdevries@suse.de>
1660
1661         PR symtab/16264
1662         PR symtab/24517
1663         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
1664
1665 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
1666
1667         * source.c (find_and_open_source): Also rewrite relative file
1668         names.
1669
1670 2019-04-26  Amos Bird  <amosbird@gmail.com>
1671
1672         * annotate.c (annotate_thread_exited): Add "thread-exited"
1673         annotation.
1674
1675 2019-06-06  Tom Tromey  <tromey@adacore.com>
1676
1677         * maint.h (class scoped_command_stats): Use
1678         DISABLE_COPY_AND_ASSIGN.
1679         <print_time>: New method.
1680         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
1681         print_time.
1682         (scoped_command_stats::print_time): New method.
1683
1684 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
1685
1686         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
1687         instructions of lengths 6 or 8 bytes.
1688
1689 2019-06-04  Pedro Alves  <palves@redhat.com>
1690
1691         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
1692
1693         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
1694         * breakpoint.c (condition_completer): Likewise.
1695         * cli/cli-dump.c (scan_expression): Likewise.
1696         * common/filestuff.c (mkdir_recursive): Likewise.
1697         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
1698         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
1699         (gdb_abspath): Likewise.
1700         * compile/compile-cplus-types.c
1701         (compile_cplus_instance::decl_name): Likewise.
1702         * completer.c (complete_explicit_location):
1703         (signal_completer, reg_or_group_completer_1): Likewise.
1704         * cp-support.c (cp_remove_params_if_any): Likewise.
1705         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
1706         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
1707         * infcmd.c (strip_bg_char): Likewise.
1708         * linespec.c (copy_token_string): Likewise.
1709         * mi/mi-main.c (output_cores): Likewise.
1710         * psymtab.c (psymtab_search_name):
1711         * symfile.c (test_set_ext_lang_command): Likewise.
1712         * target.c (target_fileio_read_stralloc): Likewise.
1713         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
1714         * value.c (complete_internalvar): Likewise.
1715
1716 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
1717
1718         Add objfile property to gdb.Type.
1719         * NEWS: Mention Python API addition.
1720         * python/py-type.c (typy_get_objfile): New method.
1721
1722 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1723
1724         * NEWS: Mention the new set|show style [title|highlight].
1725         Mention changes to "show style", "help" and "apropos".
1726
1727 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1728
1729         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
1730         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
1731         instead of print_help_for_command.
1732         (print_doc_of_command): New function.
1733         (help_list): Add 'apropos -v word' suggestion.
1734         (print_help_for_command): Style the command name using title style.
1735         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
1736         (_initialize_cli_cmds): Describe -v in apropos_command help.
1737
1738 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1739
1740         * cli/cli-style.h (cli_style_option): Add name in constructor,
1741         add m_name class member, add constructor with intensity,
1742         add name class function.
1743         (cli_style_option::add_setshow_commands): Remove name argument.
1744         (highlight_style, title_style): New styles.
1745         * cli/cli-style.c (do_show): New function that shows a style
1746         characteristic styling the style name with itself.
1747         (set_style_name): New function.
1748         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
1749         Update all callers according to the changes in cli/cli-style.h.
1750         * utils.h (fputs_highlighted): New function.
1751         * utils.c (fputs_highlighted): Likewise.
1752
1753 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1754
1755         * NEWS: Mention new pipe command and new convenience variables.
1756
1757 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1758
1759         * cli/cli-cmds.c (pipe_command): New function.
1760         (_initialize_cli_cmds): Call add_com for pipe_command.
1761         Define | as an alias for pipe.
1762         (exit_status_set_internal_vars): New function.
1763         (shell_escape): Call exit_status_set_internal_vars.
1764         cli/cli-decode.c (find_command_name_length): Recognize | as
1765         a single character command.
1766
1767 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1768
1769         * gdbcmd.h (execute_command_to_ui_file): New declaration.
1770         top.c (execute_command_to_ui_file): New function, mostly a copy
1771         of execute_command_to_string.
1772         (execute_command_to_string): Implement by calling
1773         execute_command_to_ui_file.
1774
1775 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1776
1777         * top.h (saved_command_line): Remove declaration.
1778         * top.c (previous_saved_command_line, previous_repeat_arguments):
1779         New variables.
1780         (saved_command_line): Make static, define together with other
1781         'repeat variables'.
1782         (dont_repeat): Clear repeat_arguments.
1783         (repeat_previous, get_saved_command_line, save_command_line):
1784         New functions.
1785         (gdb_init): Initialize saved_command_line
1786         and previous_saved_command_line.
1787         * main.c (captured_main_1): Remove saved_command_line initialization.
1788         * event-top.c (handle_line_of_input): Update to use
1789         the new 'repeat' related functions instead of direct access to
1790         saved_command_line.
1791         * command.h (repeat_previous, get_saved_command_line,
1792         save_command_line): New declarations.
1793         (dont_repeat): Add comment.
1794
1795 2019-05-30  Tom Tromey  <tromey@adacore.com>
1796
1797         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
1798         Fix comment.
1799         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
1800
1801 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
1802
1803         PR cli/24587
1804         * completer.c (complete): Initialize variable word.
1805
1806 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
1807
1808         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1809         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
1810         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
1811         'body' is NULL to the outter 'if', protecting the '!is_define'
1812         situation as well.
1813
1814 2019-05-29  Tom Tromey  <tromey@adacore.com>
1815
1816         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
1817         (dwarf_unknown): New function.
1818         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
1819         (dwarf_type_encoding_name): Use dwarf_unknown.
1820
1821 2019-05-29  Tom Tromey  <tromey@adacore.com>
1822
1823         PR c++/20020:
1824         * cp-valprint.c (cp_print_value_fields): Call
1825         cp_print_static_field inside "try".
1826
1827 2019-05-29  Tom Tromey  <tromey@adacore.com>
1828
1829         * inflow.c (struct terminal_info): Add default operator=.
1830         * configure: Rebuild.
1831         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
1832         -Wdeprecated-copy-dtor, -Wredundant-move.
1833
1834 2019-05-29  Tom Tromey  <tromey@adacore.com>
1835
1836         * NEWS: Add entry.
1837         * infcmd.c (print_return_value_1): Handle finish_print
1838         option.
1839         (show_print_finish): New function.
1840         (_initialize_infcmd): Add "set/show print finish" commands.
1841         * valprint.c (user_print_options): Initialize new member.
1842         * valprint.h (struct value_print_options) <finish_print>: New
1843         member.
1844
1845 2019-05-28  Tom Tromey  <tromey@adacore.com>
1846
1847         * ada-lang.c (ada_remove_Xbn_suffix)
1848         (find_old_style_renaming_symbol)
1849         (parse_old_style_renaming): Remove.
1850         (ada_find_renaming_symbol): Don't call
1851         find_old_style_renaming_symbol.
1852         (ada_is_renaming_symbol): Rename from
1853         ada_find_renaming_symbol.  Remove "block" parameter.  Return
1854         bool.  Now static.
1855         (ada_read_var_value): Update and simplify.
1856         * ada-exp.y (write_var_or_type): Remove old code.
1857
1858 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
1859
1860         * event-top.c: Remove include comment.
1861         * inflow.c (class scoped_ignore_sigttou): Move from here...
1862         * inflow.h (class scoped_ignore_sigttou): ...to here.
1863         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
1864         * top.c:  Remove include comment.
1865
1866 2019-05-27  Tom Tromey  <tom@tromey.com>
1867
1868         * NEWS: Fix typo.
1869
1870 2019-05-22  Tom Tromey  <tromey@adacore.com>
1871
1872         * target.c (target_follow_exec): Constify parameter.
1873         * target-delegates.c: Rebuild.
1874         * remote.c (remote_target::follow_exec): Constify parameter.
1875         * infrun.c (follow_exec): Constify parameter.
1876         * target.h (struct target_ops) <follow_exec>: Constify parameter.
1877         (target_follow_exec): Likewise.
1878
1879 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1880
1881         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
1882         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
1883
1884 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1885
1886         * NEWS: Add debugredirect and testsuite sections.
1887
1888 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
1889
1890         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
1891         target descriptions using exclusively floating point register name
1892         aliases.
1893
1894 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1895
1896         PR gdb/18644:
1897         * f-lang.c (build_fortran_types): Handle the case where
1898         gdbarch_floatformat_for_type returns a nullptr.
1899
1900 2019-05-21  Tom de Vries  <tdevries@suse.de>
1901
1902         PR cli/24587
1903         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
1904
1905 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1906
1907         PR gdb/18644:
1908         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
1909         16-byte floats.
1910         * i386-tdep.c (i386_floatformat_for_type): Use
1911         floatformats_ia64_quad for the 16-byte floating point component
1912         within a fortran 32-byte complex number.
1913
1914 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1915
1916         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
1917         delete default constructor.
1918         (find_partial_die): Update to return const struct.
1919         (partial_die_parent_scope): Move variable declaration into scope
1920         of its use and change its type to auto.
1921         (guess_partial_die_structure_name): Likewise.
1922         (partial_die_info::fixup): Likewise.
1923
1924 2019-05-17  Tom Tromey  <tromey@adacore.com>
1925
1926         * source.c (find_and_open_source): Remove cast.
1927
1928 2019-05-17  Tom Tromey  <tromey@adacore.com>
1929
1930         * annotate.c (annotate_source): Make "filename" const.
1931         * annotate.h (annotate_source): Use const.
1932
1933 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1934
1935         * disasm.c (set_disassembler_options): Send errors to stderr.
1936
1937 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1938
1939         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
1940         (cli_interp_base::set_logging): Check debug_redirect.
1941         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
1942         * cli/cli-logging.c (debug_redirect): Add static variable.
1943         (pop_output_files): Add default param.
1944         (handle_redirections): Print debug setting.
1945         (show_logging_command): Likewise.
1946         (_initialize_cli_logging): Add debugredirect command.
1947         * interps.c (current_interp_set_logging): Add debug_redirect
1948         parameter.
1949         * interps.h (set_logging): Add debug_redirect parameter.
1950         (current_interp_set_logging): Likewise.
1951         * mi/mi-common.h: Likewise.
1952         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
1953
1954 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1955             Tom Tromey  <tromey@adacore.com>
1956
1957         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
1958         directly.
1959         * cli/cli-interp.h (make_logging_output): Remove declaration.
1960         * cli/cli-logging.c (make_logging_output): Remove function.
1961         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
1962         directly.
1963         * ui-file.c (tee_file::tee_file): Remove bools.
1964         (tee_file::~tee_file): Remove deletes.
1965         * ui-file.h (tee_file): Remove bools.
1966
1967 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
1968
1969         * mi/mi-cmds.h (mi_cmd_complete): New function.
1970         * mi/mi-main.c (mi_cmd_complete): Likewise.
1971         * mi/mi-cmds.c: Define new MI command -complete.
1972         * NEWS: Mention new -complete command.
1973
1974 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
1975
1976         * completer.h (complete): New function.
1977         * completer.c (complete): Likewise.
1978         * cli/cli-cmds.c: (complete_command): Update to use new complete()
1979         function defined in completer.h.
1980
1981 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
1982
1983         * MAINTAINERS (Write After Approval): Add myself.
1984
1985 2019-05-17  Tom de Vries  <tdevries@suse.de>
1986
1987         PR gdb/24094
1988         * dwarf2read.c (struct cu_partial_die_info): New struct.
1989         (find_partial_die): Return cu_partial_die_info.
1990         (partial_die_parent_scope, guess_partial_die_structure_name)
1991         (partial_die_info::fixup): Handle new return type of find_partial_die.
1992
1993 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1994
1995         * stap-probe.c (stap_parse_register_operand): Make "regname" an
1996         "std::string", simplifying the algorithm.
1997
1998 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1999
2000         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
2001         (stap_static_probe_ops::get_probes): Likewise.
2002
2003 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2004
2005         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
2006         '-')" and "else if".
2007         (stap_parse_single_operand): Join checks for
2008         "gdbarch_stap_parse_special_token_p" and
2009         "gdbarch_stap_parse_special_token" in the same "if" statement.
2010         Invert check when verifying for operation on register
2011         displacement.
2012
2013 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2014
2015         * stap-probe.c (stap_get_opcode): Update comment.
2016         (stap_get_expected_argument_type): Likewise.
2017         (handle_stap_probe): Likewise.
2018
2019 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2020
2021         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2022         return type to 'bool'.  Adjust comment.  Use 'bool' when
2023         appropriate.
2024         (i386_stap_parse_special_token_three_arg_disp): Likewise.
2025         * stap-probe.c (stap_parse_argument_1): Likewise.
2026         (stap_is_operator): Likewise.
2027         (stap_is_generic_prefix): Likewise.
2028         (stap_is_register_prefix): Likewise.
2029         (stap_is_register_indirection_prefix): Likewise.
2030         (stap_is_integer_prefix): Likewise.
2031         (stap_generic_check_suffix): Likewise.
2032         (stap_check_integer_suffix): Likewise.
2033         (stap_check_register_suffix): Likewise.
2034         (stap_check_register_indirection_suffix): Likewise.
2035         (stap_parse_register_operand): Likewise.
2036         (stap_parse_single_operand): Likewise.
2037         (stap_parse_argument_1): Likewise.
2038         (stap_probe::get_argument_count): Likewise.
2039         (stap_is_operator): Likewise.
2040
2041 2019-05-16  Tom Tromey  <tromey@adacore.com>
2042
2043         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
2044         keyword to foreach.
2045
2046 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
2047
2048         * linux-thread-db.c (try_thread_db_load_1): Change return type
2049         to bool.
2050         (try_thread_db_load): Likewise.
2051         (try_thread_db_load_from_pdir_1): Likewise.
2052         (try_thread_db_load_from_pdir): Likewise.
2053         (try_thread_db_load_from_sdir): Likewise.
2054         (try_thread_db_load_from_dir): Likewise.
2055         (thread_db_load_search): Likewise.
2056         (has_libpthread): Likewise.
2057         (thread_db_load): Likewise.
2058
2059 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
2060
2061         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2062         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
2063         NULL, and complain/return if that's the case.
2064
2065 2019-05-15  John Darrington <john@darrington.wattle.id.au>
2066
2067         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
2068         (advance, posn, abstract_read_memory): New functions.
2069         [struct mem_read_abstraction]: New struct.
2070         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
2071
2072 2019-05-14  Tom Tromey  <tromey@adacore.com>
2073
2074         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
2075         value is not lval_memory.
2076
2077 2019-05-14  Tom Tromey  <tromey@adacore.com>
2078
2079         * solib.c (info_sharedlibrary_command): Style the file name.
2080
2081 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
2082
2083         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
2084         (aarch64_vnv_type): Likewise.
2085         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
2086         * common/tdesc.c: Likewise.
2087         * common/tdesc.h (enum tdesc_type_kind): Likewise.
2088         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
2089         * features/aarch64-fpu.xml: Add ieee half view.
2090         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
2091         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
2092         * gdbtypes.h (struct builtin_type): Likewise.
2093         (struct objfile_type): Likewise.
2094
2095 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
2096
2097         * language.c (language_sniff_from_mangled_name): Fix "langauge"
2098         typo.
2099         * location.h (string_to_event_location): Likewise.
2100
2101 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
2102
2103         GDB 8.3 released.
2104
2105 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2106
2107         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
2108         New variable declaration.
2109         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
2110         New variable.
2111         (print_one_breakpoint): Use ui_out::test_flags and new global
2112         variable to compute use_fixed_output.
2113         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
2114         Remove.
2115         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
2116         (mi_multi_location_breakpoint_output_fixed): Remove.
2117         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
2118         new variable.
2119         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
2120         fix_multi_location_breakpoint_output flag if version >= 3.
2121         * ui-out.h (enum ui_out_flag)
2122         <fix_multi_location_breakpoint_output>: New enumerator.
2123
2124 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2125
2126         * contrib/cc-with-tweaks.sh: Validate dwz's work.
2127
2128 2019-05-10  Tom Tromey  <tromey@adacore.com>
2129
2130         * ada-lang.c (catch_ada_completer): New function.
2131         (_initialize_ada_language): Use it.
2132
2133 2019-05-10  Tom Tromey  <tromey@adacore.com>
2134
2135         * thread.c (print_thread_info): Make "requested_threads" const.
2136         * gdbthread.h (print_thread_info): Make "requested_threads"
2137         const.
2138         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
2139         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
2140
2141 2019-05-08  Tom Tromey  <tom@tromey.com>
2142
2143         * gdbtypes.c (objfile_type_data): Change type.
2144         (objfile_type, _initialize_gdbtypes): Update.
2145
2146 2019-05-08  Tom Tromey  <tom@tromey.com>
2147
2148         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
2149         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
2150         (_initialize_dwarf2_frame): Update.
2151
2152 2019-05-08  Tom Tromey  <tom@tromey.com>
2153
2154         * objc-lang.c (objc_objfile_data): Change type.
2155         (find_methods): Update.
2156         (_initialize_objc_lang): Remove.
2157
2158 2019-05-08  Tom Tromey  <tom@tromey.com>
2159
2160         * stabsread.c (rs6000_builtin_type_data): Change type.
2161         (rs6000_builtin_type, _initialize_stabsread): Update.
2162
2163 2019-05-08  Tom Tromey  <tom@tromey.com>
2164
2165         * mips-tdep.c (mips_pdr_data): Remove.
2166         (_initialize_mips_tdep): Update.
2167
2168 2019-05-08  Tom Tromey  <tom@tromey.com>
2169
2170         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
2171         (hppa_init_objfile_priv_data, read_unwind_info)
2172         (find_unwind_entry, _initialize_hppa_tdep): Update.
2173
2174 2019-05-08  Tom Tromey  <tom@tromey.com>
2175
2176         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
2177         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
2178         on obstack.
2179         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
2180
2181 2019-05-08  Tom Tromey  <tom@tromey.com>
2182
2183         * mdebugread.c (basic_type_data): Change type.
2184         (basic_type, _initialize_mdebugread): Update.
2185
2186 2019-05-08  Tom Tromey  <tom@tromey.com>
2187
2188         * common/gdb_unique_ptr.h (struct noop_deleter): New.
2189
2190 2019-05-08  Tom Tromey  <tom@tromey.com>
2191
2192         * nto-tdep.c (nto_inferior_data_reg): Change type.
2193         (nto_inferior_data): Update.
2194         (nto_inferior_data_cleanup, nto_new_inferior_data)
2195         (_initialize_nto_tdep): Remove.
2196         * nto-tdep.h (struct nto_inferior_data): Add initializers.
2197
2198 2019-05-08  Tom Tromey  <tom@tromey.com>
2199
2200         * ada-lang.c (struct ada_inferior_data): Add initializers.
2201         (ada_inferior_data): Change type.
2202         (ada_inferior_data_cleanup): Remove.
2203         (get_ada_inferior_data, ada_inferior_exit)
2204         (struct ada_pspace_data): Add initializers, destructor.
2205         (ada_pspace_data_handle): Change type.
2206         (get_ada_pspace_data): Update.
2207         (ada_pspace_data_cleanup): Remove.
2208
2209 2019-05-08  Tom Tromey  <tom@tromey.com>
2210
2211         * coffread.c (struct coff_symfile_info): Add initializers.
2212         (coff_objfile_data_key): Move lower.  Change type.
2213         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
2214         Update.
2215         (coff_free_info): Remove.
2216
2217 2019-05-08  Tom Tromey  <tom@tromey.com>
2218
2219         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
2220         (fbsd_pspace_data_handle): Move lower.  Change type.
2221         (get_fbsd_pspace_data): Update.
2222         (fbsd_pspace_data_cleanup): Remove.
2223         (_initialize_fbsd_tdep): Update.
2224
2225 2019-05-08  Tom Tromey  <tom@tromey.com>
2226
2227         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
2228         (get_ada_tasks_pspace_data): Update.
2229         (ada_tasks_pspace_data_cleanup): Remove.
2230         (_initialize_tasks): Update.
2231         (ada_tasks_inferior_data_handle): Change type.
2232         (get_ada_tasks_inferior_data): Update.
2233         (ada_tasks_inferior_data_cleanup): Remove.
2234         (struct ada_tasks_pspace_data): Add initializers.
2235
2236 2019-05-08  Tom Tromey  <tom@tromey.com>
2237
2238         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
2239         * symfile-debug.c (debug_sym_get_probes): Change type.
2240         * stap-probe.c (handle_stap_probe):
2241         (stap_static_probe_ops::get_probes): Change type.
2242         * probe.h (class static_probe_ops) <get_probes>: Change type.
2243         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
2244         (parse_probes_in_pspace): Update.
2245         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
2246         Update.
2247         (any_static_probe_ops::get_probes): Change type.
2248         * elfread.c (elfread_data): New typedef.
2249         (probe_key): Change type.
2250         (elf_get_probes): Likewise.  Update.
2251         (probe_key_free): Remove.
2252         (_initialize_elfread): Update.
2253         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
2254         Change type.
2255         (dtrace_process_dof_probe, dtrace_process_dof)
2256         (dtrace_static_probe_ops::get_probe): Change type.
2257
2258 2019-05-08  Tom Tromey  <tom@tromey.com>
2259
2260         * xcoffread.c (struct xcoff_symfile_info): Rename from
2261         coff_symfile_info.  Add initializers.
2262         (xcoff_objfile_data_key): Move lower.  Change type.
2263         (XCOFF_DATA): Rewrite.
2264         (xcoff_free_info): Remove.
2265         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
2266         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
2267         (xcoff_initial_scan): Update.
2268
2269 2019-05-08  Tom Tromey  <tom@tromey.com>
2270
2271         * solib-svr4.c (struct svr4_info): Add initializers and
2272         destructor.
2273         <probes_table>: Now an htab_up.
2274         (solib_svr4_pspace_data): Change type.
2275         (free_probes_table): Simplify.
2276         (~svr4_info): Rename from svr4_pspace_data_cleanup.
2277         (get_svr4_info, probes_table_htab_remove_objfile_probes)
2278         (probes_table_remove_objfile_probes, register_solib_event_probe)
2279         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
2280         (_initialize_svr4_solib): Update.
2281
2282 2019-05-08  Tom Tromey  <tom@tromey.com>
2283
2284         * remote.c (remote_pspace_data): Change type.
2285         (remote_pspace_data_cleanup): Remove.
2286         (get_remote_exec_file, set_pspace_remote_exec_file)
2287         (_initialize_remote): Update.
2288
2289 2019-05-08  Tom Tromey  <tom@tromey.com>
2290
2291         * breakpoint.c (breakpoint_objfile_key): Change type.
2292         (get_breakpoint_objfile_data): Update.
2293         (free_breakpoint_objfile_data): Remove.
2294         (_initialize_breakpoint): Update.
2295
2296 2019-05-08  Tom Tromey  <tom@tromey.com>
2297
2298         * linux-tdep.c (struct linux_info): Add initializers.
2299         (linux_inferior_data): Move.  Change type.
2300         (invalidate_linux_cache_inf): Update.
2301         (linux_inferior_data_cleanup): Remove.
2302         (get_linux_inferior_data, _initialize_linux_tdep): Update.
2303
2304 2019-05-08  Tom Tromey  <tom@tromey.com>
2305
2306         * auxv.c (auxv_inferior_data): Move.  Change type.
2307         (auxv_inferior_data_cleanup): Remove.
2308         (invalidate_auxv_cache_inf): Rewrite.
2309         (get_auxv_inferior_data, _initialize_auxv): Update.
2310
2311 2019-05-08  Tom Tromey  <tom@tromey.com>
2312
2313         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
2314         (symfile_debug_objfile_data_key): Change type.
2315         (symfile_debug_installed, debug_qf_has_symbols)
2316         (debug_qf_find_last_source_symtab)
2317         (debug_qf_forget_cached_source_info)
2318         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
2319         (debug_qf_print_stats, debug_qf_dump)
2320         (debug_qf_expand_symtabs_for_function)
2321         (debug_qf_expand_all_symtabs)
2322         (debug_qf_expand_symtabs_with_fullname)
2323         (debug_qf_map_matching_symbols)
2324         (debug_qf_expand_symtabs_matching)
2325         (debug_qf_find_pc_sect_compunit_symtab)
2326         (debug_qf_map_symbol_filenames)
2327         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
2328         (debug_sym_new_init, debug_sym_init, debug_sym_read)
2329         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
2330         (debug_sym_read_linetable, debug_sym_relocate): Update.
2331         (symfile_debug_free_objfile): Remove.
2332         (install_symfile_debug_logging, _initialize_symfile_debug):
2333         Update.
2334
2335 2019-05-08  Tom Tromey  <tom@tromey.com>
2336
2337         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
2338         allocate_on_obstack.
2339         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
2340         (get_dwarf2_per_objfile): Update.
2341         (set_dwarf2_per_objfile): Remove.
2342         (dwarf2_has_info, dwarf2_get_section_info): Update.
2343         (dwarf2_free_objfile): Remove.
2344         (_initialize_dwarf2_read): Update.
2345
2346 2019-05-08  Tom Tromey  <tom@tromey.com>
2347
2348         * auto-load.c (struct auto_load_pspace_info): Add destructor and
2349         initializers.
2350         <unsupported_script_warning_printed,
2351         script_not_found_warning_printed>: Now bool.
2352         (auto_load_pspace_data): Change type.
2353         (~auto_load_pspace_info): Rename from
2354         auto_load_pspace_data_cleanup.
2355         (get_auto_load_pspace_data, init_loaded_scripts_info)
2356         (clear_section_scripts, maybe_print_unsupported_script_warning)
2357         (maybe_print_script_not_found_warning, _initialize_auto_load):
2358         Update.
2359
2360 2019-05-08  Tom Tromey  <tom@tromey.com>
2361
2362         * objfiles.c (objfile_pspace_info): Add destructor and
2363         initializers.
2364         (objfiles_pspace_data): Change type.
2365         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
2366         (get_objfile_pspace_data): Update.
2367         (objfiles_bfd_data): Change type.
2368         (get_objfile_bfd_data): Update.
2369         (objfile_bfd_data_free, _initialize_objfiles): Remove.
2370
2371 2019-05-08  Tom Tromey  <tom@tromey.com>
2372
2373         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
2374         Change type.
2375         (get_catch_syscall_inferior_data): Update.
2376         (catch_syscall_inferior_data_cleanup): Remove.
2377         (_initialize_break_catch_syscall): Update.
2378
2379 2019-05-08  Tom Tromey  <tom@tromey.com>
2380
2381         * inflow.c (struct terminal_info): Add destructor and
2382         initializers.
2383         (inflow_inferior_data): Change type.
2384         (~terminal_info): Rename from inflow_inferior_data_cleanup.
2385         (get_inflow_inferior_data, inflow_inferior_exit)
2386         (swap_terminal_info, _initialize_inflow): Update.
2387
2388 2019-05-08  Tom Tromey  <tom@tromey.com>
2389
2390         * target-dcache.c (target_dcache_cleanup): Remove.
2391         (target_dcache_aspace_key): Change type.
2392         (target_dcache_init_p, target_dcache_invalidate)
2393         (target_dcache_get, target_dcache_get_or_init)
2394         (_initialize_target_dcache): Update.
2395         * dcache.h (struct dcache_deleter): New.
2396
2397 2019-05-08  Tom Tromey  <tom@tromey.com>
2398
2399         * symtab.c (struct symbol_cache): Add destructor and
2400         initializers.
2401         (symbol_cache_key): Move.  Change type.
2402         (make_symbol_cache, free_symbol_cache): Remove.
2403         (get_symbol_cache): Update.
2404         (symbol_cache_cleanup): Remove.
2405         (ALL_PSPACES, symbol_cache_flush)
2406         (maintenance_print_symbol_cache)
2407         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
2408         Update.
2409
2410 2019-05-08  Tom Tromey  <tom@tromey.com>
2411
2412         * symtab.c (struct main_info): Add destructor and initializers.
2413         (main_progspace_key): Move.  Change type.
2414         (get_main_info): Update.
2415         (main_info_cleanup): Remove.
2416         (_initialize_symtab): Update.
2417
2418 2019-05-08  Tom Tromey  <tom@tromey.com>
2419
2420         * registry.h (DECLARE_REGISTRY): Define the _key class.
2421
2422 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2423
2424         * NEWS: Merge two 'New commands' sections.
2425
2426 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
2427
2428         * ada-valprint.c (ada_val_print_gnat_array): Remove language
2429         parameter and use Ada language definition instead.
2430         (ada_val_print_ptr): Remove unused language parameter.
2431         (ada_val_print_num): Remove language parameter and use Ada language
2432         definition instead.
2433         (ada_val_print_enum, ada_val_print_flt): Remove unused language
2434         parameter.
2435         (ada_val_print_struct_union, ada_val_print_ref): Remove language
2436         parameter and use Ada language definition instead.
2437         (ada_val_print_1): Update all ada_val_print_xxx calls.
2438         Remove language parameter.
2439         (ada_val_print): Update ada_val_print_1 call.
2440
2441 2019-05-08  Tom Tromey  <tromey@adacore.com>
2442
2443         * remote.c (remote_hw_watchpoint_limit)
2444         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
2445         Now static.
2446
2447 2019-05-08  Tom Tromey  <tromey@adacore.com>
2448
2449         * maint.c (_initialize_maint_cmds): Move initialization code to
2450         remote.c.
2451         (watchdog, show_watchdog): Move to remote.c.
2452         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
2453         "watchdog" static.
2454         (_initialize_remote): Move initialization code from maint.c.
2455         * defs.h (watchdog): Don't declare.
2456
2457 2019-05-08  Tom Tromey  <tromey@adacore.com>
2458
2459         * tui/tui-interp.c: Include main.h.
2460         * interps.c: Include main.h.
2461         * main.h (interpreter_p): Declare.
2462         * defs.h (interpreter_p): Don't declare.
2463
2464 2019-05-08  Tom Tromey  <tromey@adacore.com>
2465
2466         * dwarf2loc.c: Include dwarf2read.h.
2467         * defs.h (read_unsigned_leb128): Don't declare.
2468         * dwarf2read.h (read_unsigned_leb128): Declare.
2469
2470 2019-05-08  Tom Tromey  <tromey@adacore.com>
2471
2472         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
2473         method.
2474
2475 2019-05-08  Tom Tromey  <tromey@adacore.com>
2476
2477         * utils.c (fputs_maybe_filtered): Reset style after paging, even
2478         when no wrap column is set.
2479
2480 2019-05-08  Tom Tromey  <tromey@adacore.com>
2481
2482         * c-lang.c (c_get_string): Handle non-C-style arrays.
2483
2484 2019-05-08  Tom Tromey  <tromey@adacore.com>
2485
2486         * typeprint.c (print_offset_data::update): Print the bit offset,
2487         not the number of bits remaining.
2488
2489 2019-05-08  Tom Tromey  <tromey@adacore.com>
2490
2491         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
2492         padding at end of comment.
2493
2494 2019-05-08  Tom Tromey  <tromey@adacore.com>
2495
2496         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
2497         Compare main types.
2498
2499 2019-05-06  Tom Tromey  <tom@tromey.com>
2500
2501         * common/scoped_mmap.c: Include common-defs.h.
2502         * common/scoped_mmap.h: Don't include config.h.
2503
2504 2019-05-04  Tom Tromey  <tom@tromey.com>
2505
2506         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
2507         (struct aarch64_call_info): Add initializers.
2508         <si>: Now a std::vector.
2509         (pass_on_stack, aarch64_push_dummy_call): Update.
2510
2511 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
2512             Tom Tromey  <tom@tromey.com>
2513
2514         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
2515         (ppc_threads): Now a std::vector.  Now static.
2516         (hwdebug_find_thread_points_by_tid)
2517         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
2518         Update.
2519
2520 2019-05-04  Tom Tromey  <tom@tromey.com>
2521
2522         * arc-tdep.c (arc_tdesc_init): Return bool.
2523
2524 2019-05-04  Tom Tromey  <tom@tromey.com>
2525
2526         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
2527         Use gdb_assert_not_reached.
2528
2529 2019-05-04  Tom Tromey  <tom@tromey.com>
2530
2531         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
2532         "false".
2533
2534 2019-05-04  Tom Tromey  <tom@tromey.com>
2535
2536         * arc-tdep.c (arc_tdesc_init): Use bool.
2537
2538 2019-05-04  Tom Tromey  <tom@tromey.com>
2539
2540         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
2541
2542 2019-05-04  Tom Tromey  <tom@tromey.com>
2543
2544         * cli/cli-cmds.c (valid_command_p): Return bool.
2545
2546 2019-05-04  Tom Tromey  <tom@tromey.com>
2547
2548         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
2549         * command.h (valid_user_defined_cmd_name_p): Channge return type.
2550
2551 2019-05-04  Raul Tambre  <raul@tambre.ee>
2552
2553         * python/lib/gdb/prompt.py (_ExtendedPrompt)
2554         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
2555         operator for comparison.
2556
2557 2019-05-04  Tom Tromey  <tom@tromey.com>
2558
2559         * psymtab.c (psymbol_name_matches, match_partial_symbol)
2560         (lookup_partial_symbol, print_partial_symbols)
2561         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
2562         (psymbol_compare): Update.
2563         (add_psymbol_to_bcache): Clear the entire psymbol.
2564         (maintenance_check_psymtabs): Update.
2565         * psympriv.h (struct partial_symbol): Don't derive from
2566         general_symbol_info.
2567         <obj_section, unrelocated_address, address,
2568         set_unrelocated_address>: Update.
2569         <ginfo>: New member.
2570         * dwarf-index-write.c (write_psymbols, debug_names::insert)
2571         (debug_names::write_psymbols): Update.
2572
2573 2019-05-04  Tom de Vries  <tdevries@suse.de>
2574
2575         * contrib/cc-with-tweaks.sh: Support -n arg.
2576
2577 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2578
2579         * corelow.c (core_target::detach): Ensure frame cache and
2580         register caches are cleared.
2581         inferior.c (exit_inferior_1): Likewise.
2582
2583 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
2584             Tom Tromey  <tom@tromey.com>
2585
2586         * dictionary.c (collate_pending_symbols_by_language): Remove
2587         "struct" from foreach.
2588         * symtab.c (lookup_global_symbol_from_objfile)
2589         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
2590         foreach.
2591         * ser-tcp.c (net_open): Remove "struct" from foreach.
2592         * objfiles.c (objfile_relocate, objfile_rebase)
2593         (objfile_has_symbols): Remove "struct" from foreach.
2594         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
2595         from foreach.
2596         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
2597         foreach.
2598         * darwin-nat.c (thread_info_from_private_thread_info): Remove
2599         "struct" from foreach.
2600         * ada-lang.c (create_excep_cond_exprs)
2601         (ada_exception_catchpoint_cond_string): Remove "struct" from
2602         foreach.
2603
2604 2019-05-03  Tom Tromey  <tromey@adacore.com>
2605
2606         * ada-exp.y (convert_char_literal): Check suffix of each
2607         enumerator.
2608
2609 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
2610
2611         PR ada/21406:
2612         * ada-exp.y (yywrap): Don't define.
2613         * ada-lex.l (%option): Add noyywrap
2614         (yywrap): Remove.
2615
2616 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
2617
2618         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
2619         _WIN32_WINNT to the XP level, unless already defined to a higher
2620         level.
2621
2622         * unittests/parse-connection-spec-selftests.c:
2623         * ser-tcp.c:
2624         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
2625         override.
2626
2627         * symfile.c (find_separate_debug_file): Remove colon from the
2628         drive spec of DOS/Windows file names of the target, so that the
2629         file name produced from DEBUGDIR and the target's directory will
2630         be valid on DOS/Windows systems.
2631
2632 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2633
2634         * rust-lang.c (val_print_struct): Handle printing structures
2635         containing strings.
2636
2637 2019-05-02  Tom Tromey  <tromey@adacore.com>
2638
2639         * valarith.c (_initialize_valarith): Remove.
2640
2641 2019-05-01  Tom Tromey  <tromey@adacore.com>
2642
2643         * ada-lang.c (ada_value_primitive_field): Treat more fields as
2644         bitfields.
2645
2646 2019-05-01  Tom Tromey  <tromey@adacore.com>
2647
2648         * ada-lang.c (ada_value_assign): Correctly compute starting offset
2649         for big-endian copies.
2650
2651 2019-04-30  Ali Tamur  <tamur@google.com>
2652         * gdb/dwarf2read.c (read_3_bytes): New declaration.
2653         (read_attribute_value): Added DW_FORM_strx1-4 cases.
2654         (read_3_bytes): New function.
2655
2656 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2657
2658         * windows-nat.c (main_thread_id): Delete.
2659         (handle_output_debug_string): Replace main_thread_id by
2660         current_event.dwThreadId.
2661         (fake_create_process): Likewise.
2662         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
2663         Do not set main_thread_id.
2664         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
2665         current_event.dwThreadId.
2666         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
2667
2668 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2669
2670         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
2671         Use current_event.dwThreadId instead of main_thread_id.
2672
2673 2019-04-30  Tom Tromey  <tromey@adacore.com>
2674
2675         * ada-lang.c (ada_lookup_simple_minsyms): New function.
2676         (create_excep_cond_exprs): Iterate over program spaces.
2677         (ada_exception_catchpoint_cond_string): Examine all minimal
2678         symbols for exception types.
2679
2680 2019-04-30  Tom Tromey  <tromey@adacore.com>
2681
2682         PR c++/24470:
2683         * dwarf2read.c (process_structure_scope): Handle case where type
2684         has template parameters but no symbol was created.
2685
2686 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2687             Chris January  <chris.january@arm.com>
2688
2689         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
2690         qualifier.
2691         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
2692
2693 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2694
2695         * f-typeprint.c (f_print_type): Update rules for printing
2696         whitespace.
2697         (f_type_print_varspec_suffix): Likewise.
2698
2699 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2700             Chris January  <chris.january@arm.com>
2701
2702         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
2703         function arguments.
2704
2705 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2706
2707         * f-lang.c (build_fortran_types): Change name of void type to
2708         lower case.
2709         * f-typeprint.c (f_type_print_base): Print the name of the void
2710         type, rather than a fixed string.
2711         * f-valprint.c (f_decorations): Use lower case void string.
2712
2713 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2714             Chris January  <chris.january@arm.com>
2715
2716         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
2717         types for Fortran.
2718
2719 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2720             Chris January  <chris.january@arm.com>
2721             David Lecomber  <david.lecomber@arm.com>
2722
2723         * f-exp.y (BINOP_INTRINSIC): New token.
2724         (exp): New parser rule handling BINOP_INTRINSIC.
2725         (f77_keywords): Add new builtin procedures.
2726         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
2727         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2728         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
2729         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2730         (print_unop_subexp_f): New function.
2731         (print_binop_subexp_f): New function.
2732         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2733         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2734         (dump_subexp_body_f): Likewise.
2735         (operator_check_f): Likewise.
2736         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2737         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
2738
2739 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2740
2741         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
2742         UNOP_KIND.
2743         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
2744         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
2745         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
2746         (operator_length_f): New fuction.
2747         (print_subexp_f): New function.
2748         (op_name_f): New function.
2749         (dump_subexp_body_f): New function.
2750         (operator_check_f): New function.
2751         (exp_descriptor_f): Replace standard expression handling functions
2752         with new functions.
2753         * gdb/fortran-operator.def: New file.
2754         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
2755         * gdb/std-operator.def: Remove UNOP_KIND.
2756
2757 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2758
2759         * std-operator.def: Remove unbalanced, stray double quote
2760         character.
2761
2762 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2763             Chris January  <chris.january@arm.com>
2764             Daniel Everett  <daniel.everett@arm.com>
2765             Nick Forrington  <nick.forrington@arm.com>
2766             Richard Bunt  <richard.bunt@arm.com>
2767
2768         * cp-valprint.c (cp_print_value_fields): Allow an additional level
2769         of depth when printing anonymous structs or unions.
2770         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
2771         Don't print either the top-level value, or the children if the
2772         max-depth is exceeded.
2773         (ppscm_print_children): When printing the key of a map, allow one
2774         extra level of depth.
2775         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
2776         print either the top-level value, or the children if the max-depth
2777         is exceeded.
2778         (print_children): When printing the key of a map, allow one extra
2779         level of depth.
2780         * python/py-value.c (valpy_format_string): Add max_depth keyword.
2781         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
2782         (user_print_options): Initialise max_depth field.
2783         (val_print_scalar_or_string_type_p): New function.
2784         (val_print): Check to see if the max depth has been reached.
2785         (val_print_check_max_depth): Define new function.
2786         (show_print_max_depth): New function.
2787         (_initialize_valprint): Add 'print max-depth' option.
2788         * valprint.h (struct value_print_options) <max_depth>: New field.
2789         (val_print_check_max_depth): Declare new function.
2790         * NEWS: Document new feature.
2791
2792 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2793
2794         * ada-lang.c (ada_language_defn): Initialise new field.
2795         * c-lang.c (c_is_string_type_p): New function.
2796         (c_language_defn): Initialise new field.
2797         (cplus_language_defn): Initialise new field.
2798         (asm_language_defn): Initialise new field.
2799         (minimal_language_defn): Initialise new field.
2800         * c-lang.h (c_is_string_type_p): Declare new function.
2801         * d-lang.c (d_language_defn): Initialise new field.
2802         * f-lang.c (f_is_string_type_p): New function.
2803         (f_language_defn): Initialise new field.
2804         * go-lang.c (go_is_string_type_p): New function.
2805         (go_language_defn): Initialise new field.
2806         * language.c (default_is_string_type_p): New function.
2807         (unknown_language_defn): Initialise new field.
2808         (auto_language_defn): Initialise new field.
2809         * language.h (struct language_defn) <la_is_string_type_p>: New
2810         member variable.
2811         (default_is_string_type_p): Declare new function.
2812         * m2-lang.c (m2_language_defn): Initialise new field.
2813         * objc-lang.c (objc_language_defn): Initialise new field.
2814         * opencl-lang.c (opencl_language_defn): Initialise new field.
2815         * p-lang.c (pascal_is_string_type_p): New function.
2816         (pascal_language_defn): Initialise new field.
2817         * rust-lang.c (rust_is_string_type_p): New function.
2818         (rust_language_defn): Initialise new field.
2819
2820 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2821
2822         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
2823         New field.
2824         * ada-lang.c (ada_language_defn): Initialise new field.
2825         * c-lang.c (c_language_defn): Likewise.
2826         (cplus_language_defn): Likewise.
2827         (asm_language_defn): Likewise.
2828         (minimal_language_defn): Likewise.
2829         * d-lang.c (d_language_defn): Likewise.
2830         * f-lang.c (f_language_defn): Likewise.
2831         * go-lang.c (go_language_defn): Likewise.
2832         * language.c (unknown_language_defn): Likewise.
2833         (auto_language_defn): Likewise.
2834         * m2-lang.c (m2_language_defn): Likewise.
2835         * objc-lang.c (objc_language_defn): Likewise.
2836         * opencl-lang.c (opencl_language_defn): Likewise.
2837         * p-lang.c (pascal_language_defn): Likewise.
2838         * rust-lang.c (rust_language_defn): Likewise.
2839
2840 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2841
2842         * ada-lang.c (ada_is_character_type): Change return type to bool.
2843         (ada_is_string_type): Likewise.
2844         * ada-lang.h (ada_is_character_type): Update declaration
2845         (ada_is_string_type): Likewise.
2846
2847 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2848
2849         Support style in 'frame|thread apply'
2850
2851         * gdbcmd.h (execute_command_to_string): New term_out parameter.
2852         * record.c (record_start, record_stop): Update callers of
2853         execute_command_to_string with false.
2854         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
2855         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
2856         methods.
2857         (class string_file): New constructor with term_out parameter.
2858         Override methods term_out and can_emit_style_escape.  New member
2859         term_out.
2860         (class stdio_file): Override can_emit_style_escape.
2861         (class tee_file): Override term_out and can_emit_style_escape.
2862         * utils.h (can_emit_style_escape): Remove.
2863         * utils.c (can_emit_style_escape): Likewise.
2864         Update all callers of can_emit_style_escape (SOMESTREAM) to
2865         SOMESTREAM->can_emit_style_escape.
2866         * source-cache.c (source_cache::get_source_lines): Likewise.
2867         * stack.c (frame_apply_command_count): Call execute_command_to_string
2868         passing the term_out characteristic of the current gdb_stdout.
2869         * thread.c (thr_try_catch_cmd): Likewise.
2870         * top.c (execute_command_to_string): pass term_out parameter
2871         to construct the string_file for the command output.
2872         * ui-file.c (term_cli_styling): New function (most code moved
2873         from utils.c can_emit_style_escape).
2874         (string_file::string_file, string_file::can_emit_style_escape,
2875         stdio_file::can_emit_style_escape, tee_file::term_out,
2876         tee_file::can_emit_style_escape): New functions.
2877
2878 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2879
2880         * NEWS: Mention the new set|show may-call-functions.
2881         * infcall.c (may_call_functions_p): New variable.
2882         (show_may_call_functions_p): New function.
2883         (call_function_by_hand_dummy): Throws an error if not
2884         may-call-functions.
2885         (_initialize_infcall): Call add_setshow_boolean_cmd for
2886         may-call-functions.
2887
2888 2019-04-25  Keith Seitz  <keiths@redhat.com>
2889
2890         PR c++/24367
2891         * cp-support.c (inspect_type): Don't attempt substitutions
2892         of symbol with the same name.
2893
2894 2019-04-25  Tom Tromey  <tromey@adacore.com>
2895
2896         PR gdb/24475:
2897         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
2898         static.
2899
2900 2019-04-25  Tom Tromey  <tromey@adacore.com>
2901
2902         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
2903         rvalue reference.
2904         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
2905         (gdb_xml_parser::parse): Use std::move.
2906         * python/python-internal.h (gdbpy_convert_exception): Take a const
2907         reference.
2908         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
2909         std::move.
2910         * python/py-utils.c (gdbpy_convert_exception): Take a const
2911         reference.
2912         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2913         Use std::move.
2914         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2915         Use std::move.
2916         * mi/mi-main.c (mi_print_exception): Take a const reference.
2917         * main.c (handle_command_errors): Take a const reference.
2918         * linespec.c (parse_linespec): Use std::move.
2919         * infcall.c (run_inferior_call): Use std::move.
2920         (call_function_by_hand_dummy): Use std::move.
2921         * exec.c (try_open_exec_file): Use std::move.
2922         * exceptions.h (exception_print, exception_fprintf)
2923         (exception_print_same): Update.
2924         * exceptions.c (print_exception, exception_print)
2925         (exception_fprintf, exception_print_same): Change parameters to
2926         const reference.
2927         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
2928         * common/new-op.c: Use std::move.
2929         * common/common-exceptions.h (struct gdb_exception): Add move
2930         constructor.
2931         (struct gdb_exception_error, struct gdb_exception_quit, struct
2932         gdb_quit_bad_alloc): Change constructor to move constructor.
2933         (throw_exception): Change parameter to rvalue reference.
2934         * common/common-exceptions.c (throw_exception): Take rvalue
2935         reference.
2936         * cli/cli-interp.c (safe_execute_command): Use std::move.
2937         * breakpoint.c (insert_bp_location, location_to_sals): Use
2938         std::move.
2939
2940 2019-04-25  Tom Tromey  <tromey@adacore.com>
2941
2942         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
2943         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
2944         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
2945         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
2946         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
2947         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
2948         guile/scm-value.c: Use unpack.
2949         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
2950         gdbscm_gdb_exception.
2951         (gdbscm_throw_gdb_exception): Likewise.
2952         (struct gdbscm_gdb_exception): New.
2953         (unpack): New function.
2954         (gdbscm_wrap): Use unpack.
2955
2956 2019-04-25  Tom Tromey  <tromey@adacore.com>
2957
2958         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2959         (gdb_rl_callback_handler): Use std::move.
2960         * common/common-exceptions.h (struct gdb_exception): Add move
2961         assignment operator.
2962         (throw_exception_sjlj): Change "exception" to const reference.
2963         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
2964         (throw_exception_sjlj): Change "exception" to const reference.
2965
2966 2019-04-25  Tom Tromey  <tromey@adacore.com>
2967
2968         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
2969         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
2970         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2971         Update.
2972         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2973         Update.
2974         * mi/mi-interp.c (mi_interp::exec): Update.
2975         * linespec.c (parse_linespec): Update.
2976         * infcall.c (run_inferior_call): Update.
2977         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
2978         * guile/scm-symbol.c (gdbscm_lookup_symbol)
2979         (gdbscm_lookup_global_symbol): Update.
2980         * guile/scm-param.c (gdbscm_parameter_value): Update.
2981         * guile/scm-frame.c (gdbscm_frame_read_register)
2982         (gdbscm_frame_read_var): Update.
2983         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
2984         * exec.c (try_open_exec_file): Update.
2985         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2986         (gdb_rl_callback_handler): Update.
2987         * common/common-exceptions.h (exception_none): Don't declare.
2988         * common/common-exceptions.c (exception_none): Don't define.
2989         (struct catcher) <exception>: Update.
2990         * cli/cli-interp.c (safe_execute_command): Update.
2991         * breakpoint.c (insert_bp_location, location_to_sals): Update.
2992
2993 2019-04-25  Ali Tamur  <tamur@google.com>
2994
2995         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
2996         (read_attribute_value): Likewise.
2997         (dwarf2_read_addr_index): Update comment.
2998         (read_str_index): Add DW_FORM_strx.
2999         (dwarf2_string_attr): Likewise.
3000         (dwarf2_const_value_attr): Likewise.
3001         (dump_die_shallow): Likewise.
3002         (dwarf2_fetch_constant_bytes): Likewise.
3003         (skip_form_bytes): Likewise.
3004         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
3005
3006 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
3007
3008         PR corefiles/11608
3009         PR corefiles/18187
3010         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
3011         OFFSET.  Verify if current mapping contains an ELF header.
3012         (linux_find_memory_regions_full): Adjust call to
3013         dump_mapping_p.
3014
3015 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
3016             Kang Li <kanglictf@gmail.com>
3017
3018         PR gdb/21600
3019
3020         * dwarf2-frame.c (read_initial_length): Be consistent about using
3021         unsigned representation of length.
3022         (decode_frame_entry_1): Likewise.  Check for wraparound of
3023         end pointer as well as buffer overflow.
3024
3025 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
3026
3027         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
3028         "vq".
3029
3030 2019-04-24  Tom Tromey  <tromey@adacore.com>
3031
3032         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
3033
3034 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3035
3036         * s12z-tdep.c (s12z_unwind_pc): Delete.
3037         (s12z_unwind_sp): Delete.
3038         (s12z_gdbarch_init): Don't register deleted functions with
3039         gdbarch.
3040
3041 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3042
3043         * rl78-tdep.c (rl78_unwind_sp): Delete.
3044         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
3045
3046 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3047
3048         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
3049         (xstormy16_unwind_pc): Delete.
3050         (xstormy16_dummy_id): Delete.
3051         (xstormy16_gdbarch_init): Don't register deleted functions with
3052         gdbarch.
3053
3054 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3055
3056         * vax-tdep.c (vax_unwind_pc): Delete.
3057         (vax_gdbarch_init): Don't register deleted function with gdbarch.
3058
3059 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3060
3061         * v850-tdep.c (v850_unwind_sp): Delete.
3062         (v850_unwind_pc): Delete.
3063         (v850_dummy_id): Delete.
3064         (v850_gdbarch_init): Don't register deleted functions with
3065         gdbarch.
3066
3067 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3068
3069         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
3070         (tilegx_unwind_pc): Delete.
3071         (tilegx_unwind_dummy_id): Delete.
3072         (tilegx_gdbarch_init): Don't register deleted functions with
3073         gdbarch.
3074
3075 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3076
3077         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
3078         (tic6x_dummy_id): Delete.
3079         (tic6x_gdbarch_init): Don't register deleted functions with
3080         gdbarch.
3081
3082 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3083
3084         * sparc-tdep.c (sparc_unwind_pc): Delete.
3085         (sparc32_gdbarch_init): Don't register deleted function with
3086         gdbarch.
3087
3088 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3089
3090         * sh-tdep.c (sh_unwind_sp): Delete.
3091         (sh_unwind_pc): Delete.
3092         (sh_dummy_id): Delete.
3093         (sh_gdbarch_init): Don't register deleted functions with
3094         gdbarch.
3095
3096 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3097
3098         * score-tdep.c (score_unwind_sp): Delete.
3099         (score_unwind_pc): Delete.
3100         (score_dummy_id): Delete.
3101         (score_gdbarch_init): Don't register deleted functions with
3102         gdbarch.
3103
3104 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3105
3106         * rx-tdep.c (rx_unwind_pc): Delete.
3107         (rx_unwind_sp): Delete.
3108         (rx_dummy_id): Delete.
3109         (rx_gdbarch_init): Don't register deleted functions with
3110         gdbarch.  Update comment.
3111
3112 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3113
3114         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
3115         (rs6000_dummy_id): Delete.
3116         (rs6000_gdbarch_init): Don't register deleted functions with
3117         gdbarch.
3118
3119 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3120
3121         * or1k-tdep.c (or1k_dummy_id): Delete.
3122         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
3123
3124 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3125
3126         * nios2-tdep.c (nios2_dummy_id): Delete.
3127         (nios2_unwind_sp): Delete.
3128         (nios2_gdbarch_init): Don't register deleted functions with
3129         gdbarch.
3130
3131 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3132
3133         * nds32-tdep.c (nds32_dummy_id): Delete.
3134         (nds32_unwind_pc): Delete.
3135         (nds32_unwind_sp): Delete.
3136         (nds32_gdbarch_init): Don't register deleted functions with
3137         gdbarch.
3138
3139 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3140
3141         * msp430-tdep.c (msp430_unwind_pc): Delete.
3142         (msp430_unwind_sp): Delete.
3143         (msp430_dummy_id): Delete.
3144         (msp430_gdbarch_init): Don't register deleted functions with
3145         gdbarch.
3146
3147 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3148
3149         * moxie-tdep.c (moxie_unwind_sp): Delete.
3150         (moxie_unwind_pc): Delete.
3151         (moxie_dummy_id): Delete.
3152         (moxie_gdbarch_init): Don't register deleted functions with
3153         gdbarch.
3154
3155 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3156
3157         * mn10300-tdep.c (mn10300_dummy_id): Delete.
3158         (mn10300_unwind_pc): Delete.
3159         (mn10300_unwind_sp): Delete.
3160         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
3161         mn10300_unwind_sp.
3162         (mn10300_frame_unwind_init): Don't register deleted functions with
3163         gdbarch.
3164
3165 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3166
3167         * mep-tdep.c (mep_unwind_pc): Delete.
3168         (mep_unwind_sp): Delete.
3169         (mep_dummy_id): Delete.
3170         (mep_gdbarch_init): Don't register deleted functions with
3171         gdbarch.
3172
3173 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3174
3175         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
3176         (m68hc11_unwind_sp): Delete.
3177         (m68hc11_gdbarch_init): Don't register deleted functions with
3178         gdbarch.
3179
3180 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3181
3182         * m32r-tdep.c (m32r_unwind_sp): Delete.
3183         (m32r_unwind_pc): Delete.
3184         (m32r_dummy_id): Delete.
3185         (m32r_gdbarch_init): Don't register deleted functions with
3186         gdbarch.
3187
3188 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3189
3190         * m32c-tdep.c (m32c_unwind_pc): Delete.
3191         (m32c_unwind_sp): Delete.
3192         (m32c_dummy_id): Delete.
3193         (m32c_gdbarch_init): Don't register deleted functions with
3194         gdbarch.
3195
3196 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3197
3198         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
3199         (lm32_unwind_pc): Delete.
3200         (lm32_dummy_id): Delete.
3201         (lm32_gdbarch_init): Don't register deleted functions with
3202         gdbarch.
3203
3204 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3205
3206         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
3207         (iq2000_unwind_pc): Delete.
3208         (iq2000_dummy_id): Delete.
3209         (iq2000_gdbarch_init): Don't register deleted functions with
3210         gdbarch.
3211
3212 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3213
3214         * nds32-tdep.c (nds32_type_align): Delete.
3215         (nds32_push_dummy_call): Use type_align instead.
3216
3217 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3218
3219         * arm-tdep.c (arm_type_align): Only handle vector override case.
3220         (arm_push_dummy_call): Use type_align.
3221         (arm_gdbarch_init): Register arm_type_align gdbarch function.
3222
3223 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3224
3225         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
3226         case.
3227         (pass_on_stack): Use type_align.
3228         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
3229         function.
3230
3231 2019-04-23  Tom Tromey  <tromey@adacore.com>
3232
3233         * dwarf2read.c (line_header::file_name_at): Remove unused
3234         overload.
3235
3236 2019-04-23  Tom de Vries  <tdevries@suse.de>
3237
3238         PR gdb/24438
3239         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
3240         invocation.
3241
3242
3243 2019-03-27  Ali Tamur  <tamur@google.com>
3244
3245         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
3246         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
3247         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
3248         (dwarf_expr_context::get_addr_index): Likewise
3249         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
3250         (symbol_needs_eval_context::get_addr_index): Likewise
3251         (disassemble_dwarf_expression): Add DW_OP_addrx
3252         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
3253         (read_cutu_die_from_dwo): Update comment
3254         (skip_one_die): Add DW_FORM_addrx
3255         (read_attribute_value): Likewise
3256         (var_decode_location): Add DW_OP_addrx
3257         (dwarf2_const_value_attr): Add DW_FORM_addrx
3258         (dump_die_shallow): Likewise
3259         (dwarf2_fetch_constant_bytes): Likewise
3260         (decode_locdesc): Add DW_OP_addrx
3261         (skip_form_bytes): Add DW_FORM_addrx
3262
3263 2019-04-22  Ali Tamur  <tamur@google.com>
3264
3265         * MAINTAINERS (Write After Approval): Add self.
3266
3267 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
3268
3269         * solib-svr4.c (get_svr4_info): Add pspace parameter.
3270         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
3271         (open_symbol_file_object): Likewise.
3272         (svr4_default_sos): Add info parameter.
3273         (svr4_read_so_list): Likewise.
3274         (svr4_current_sos_direct): Adjust functions calls to pass down
3275         info.
3276         (svr4_current_sos_1): Add info parameter.
3277         (svr4_current_sos): Call get_svr4_info, pass info down to
3278         svr4_current_sos_1.
3279         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
3280         get_svr4_info.
3281         (svr4_in_dynsym_resolve_code): Pass current_program_space to
3282         get_svr4_info.
3283         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
3284         to get_svr4_info.
3285         (probes_table_remove_objfile_probes): Likewise.
3286         (register_solib_event_probe): Add info parameter.
3287         (solist_update_incremental): Pass info parameter down to
3288         svr4_read_so_list.
3289         (disable_probes_interface): Add info parameter.
3290         (svr4_handle_solib_event): Pass current_program_space to
3291         get_svr4_info.  Adjust disable_probes_interface cleanup.
3292         (svr4_create_probe_breakpoints): Add info parameter, pass it
3293         down to register_solib_event_probe.
3294         (svr4_create_solib_event_breakpoints): Add info parameter,
3295         pass it down to svr4_create_probe_breakpoints.
3296         (enable_break): Pass info down to
3297         svr4_create_solib_event_breakpoints.
3298         (svr4_solib_create_inferior_hook): Pass current_program_space to
3299         get_svr4_info.
3300         (svr4_clear_solib): Likewise.
3301
3302 2019-04-22  Pedro Alves  <palves@redhat.com>
3303
3304         * solib-svr4.c (svr4_free_objfile_observer): New.
3305         (probe_and_action::objfile): New field.
3306         (probes_table_htab_remove_objfile_probes)
3307         (probes_table_remove_objfile_probes): New functions.
3308         (register_solib_event_probe): Add 'objfile' parameter.  Store it
3309         in the new probe_and_action.  Don't store the probe in 'lookup'.
3310         (svr4_create_probe_breakpoints): Pass objfile to
3311         register_solib_event_probe.
3312         (_initialize_svr4_solib): Register a free_objfile observer.
3313
3314 2019-04-19  Tom Tromey  <tom@tromey.com>
3315
3316         * common/queue.h: Remove.
3317
3318 2019-04-19  Tom Tromey  <tom@tromey.com>
3319
3320         * event-loop.c: Don't include "common/queue.h".
3321
3322 2019-04-19  Tom Tromey  <tom@tromey.com>
3323
3324         * remote.c (remote_target): Use delete.
3325         * remote-notif.h: Include <list>, not "common/queue.h".
3326         (notif_client_p): Remove typedef.
3327         (remote_notif_state): Add constructor, destructor, initializer.
3328         <notif_queue>: Now a std::list.
3329         (remote_notif_state_xfree): Don't declare.
3330         * remote-notif.c (remote_notif_process, handle_notification)
3331         (remote_notif_state_allocate): Update.
3332         (~remote_notif_state): Rename from remote_notif_state_xfree.
3333
3334 2019-04-19  Tom Tromey  <tom@tromey.com>
3335
3336         * symfile.c (reread_symbols): Update.
3337         * objfiles.c (objfile_register_static_link)
3338         (objfile_lookup_static_link): Update
3339         (~objfile) Don't delete static_links.
3340         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
3341
3342 2019-04-19  Tom Tromey  <tom@tromey.com>
3343
3344         * type-stack.h (struct type_stack) <insert>: Constify string.
3345         * type-stack.c (type_stack::insert): Constify string.
3346         * gdbtypes.h (lookup_template_type): Update.
3347         (address_space_name_to_int): Update.
3348         * gdbtypes.c (address_space_name_to_int): Make space_identifier
3349         const.
3350         (lookup_template_type): Make name const.
3351         * c-exp.y: Update rules.
3352         (lex_one_token, classify_name, classify_inner_name)
3353         (c_print_token): Update.
3354         * p-exp.y: Update rules.
3355         (yylex): Update.
3356         * f-exp.y: Update rules.
3357         (yylex): Update.
3358         * d-exp.y: Update rules.
3359         (lex_one_token, classify_name, classify_inner_name): Update.
3360         * parse.c (write_dollar_variable, copy_name): Return std::string.
3361         * parser-defs.h (copy_name): Change return type.
3362         * m2-exp.y: Update rules.
3363         (yylex): Update.
3364         * go-exp.y (lex_one_token): Update.
3365         Update rules.
3366         (classify_unsafe_function, classify_packaged_name)
3367         (classify_name, yylex): Update.
3368
3369 2019-04-19  Sergei Trofimovich <siarheit@google.com>
3370
3371         * configure.ac: add --enable-source-highlight switch.
3372         * configure: Regenerate.
3373         * top.c (print_gdb_version): plumb --enable-source-highlight
3374         status to "show configuration".
3375
3376 2019-04-19  Tom Tromey  <tromey@adacore.com>
3377
3378         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
3379         Check ADA_TYPE_P.
3380         (empty_record, ada_template_to_fixed_record_type_1)
3381         (template_to_static_fixed_type)
3382         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
3383         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
3384         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
3385         macros.
3386
3387 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
3388
3389         PR symtab/24423:
3390         * source.c (print_source_lines_base): Advance "iter" when a
3391         control character is seen.
3392
3393 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3394
3395         * inferior.h (struct infcall_suspend_state_deleter):
3396         Catch exception in destructor to avoid crash.
3397
3398 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3399
3400         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
3401         close to the add_com "shell".
3402
3403 2019-04-18  Tom Tromey  <tromey@adacore.com>
3404
3405         * process-stratum-target.h (class process_stratum_target)
3406         <stratum>: Add "final".
3407
3408 2019-04-17  Tom Tromey  <tromey@adacore.com>
3409
3410         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
3411         against nullptr before use.
3412
3413 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
3414
3415         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
3416
3417 2019-04-17  Jim Wilson  <jimw@sifive.com>
3418             Andrew Burgess  <andrew.burgess@embecosm.com>
3419
3420         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
3421         code read might fail, assume 4-byte breakpoint in that case.
3422
3423 2019-04-15  Leszek Swirski  <leszeks@google.com>
3424
3425         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
3426         rather than a hand-rolled POD check when checking for forced MEMORY
3427         classification.
3428
3429 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3430
3431         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
3432         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
3433         function.
3434         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
3435         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
3436         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
3437         declaration.
3438
3439 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3440
3441         * aarch64-linux-nat.c
3442         (aarch64_linux_nat_target::thread_architecture): Add override.
3443         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
3444         each VQ.
3445
3446 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3447
3448         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
3449
3450 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
3451
3452         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
3453         target types of size 96-bits, add some additional comments, and
3454         check that the builtin type we found was the correct size.
3455
3456 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
3457
3458         * utils.c (prompt_for_continue): Don't restore the styling at the
3459         end, as applied_style has the wrong value.  This fixes styling in
3460         long lists of file names that are interrupted by the "Continue?"
3461         prompt.
3462
3463 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3464
3465         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
3466         * c-lang.c (c_language_defn): Likewise.
3467         (cplus_language_defn): Likewise.
3468         (asm_language_defn): Likewise.
3469         (minimal_language_defn): Likewise.
3470         * d-lang.c (d_language_defn): Likewise.
3471         * f-lang.c (f_language_defn): Likewise.
3472         * go-lang.c (go_language_defn): Likewise.
3473         * language.c (unknown_language_defn): Likewise.
3474         (auto_language_defn): Likewise.
3475         * language.h (struct language_defn): Remove la_magic field.
3476         (LANG_MAGIC): Delete.
3477         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
3478         * objc-lang.c (objc_language_defn): Likewise.
3479         * opencl-lang.c (opencl_language_defn): Likewise.
3480         * p-lang.c (pascal_language_defn): Likewise.
3481         * rust-lang.c (rust_language_defn): Likewise.
3482
3483 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3484
3485         * riscv-tdep.c (riscv_type_align): New function.
3486         (riscv_type_alignment): Delete.
3487         (riscv_arg_location): Use 'type_align'.
3488         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
3489
3490 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3491
3492         * gdbtypes.c (type_align): A struct with no non-static fields also
3493         has alignment of 1.
3494
3495 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3496
3497         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
3498         component to 0.
3499         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
3500         member.
3501         (riscv_struct_info::analyse): New implementation using new
3502         analyse_inner member function.
3503         (riscv_struct_info::field_offset): New member function.
3504         (riscv_struct_info::m_offsets): New member variable.
3505         (riscv_struct_info::analyse_inner): New private member function,
3506         takes the old implementation of riscv_struct_info::analyse but
3507         extended to track field offsets.
3508         (riscv_call_arg_struct): Update the struct folding special cases
3509         to handle cases where empty C++ structs, which are non-zero
3510         length, are found.
3511         (riscv_arg_location): Initialise the length of each location, a
3512         non-zero length now indicates the location is in use.
3513         (riscv_push_dummy_call): Allow for the first location having a
3514         non-zero offset when setting up arguments.
3515         (riscv_return_value): Likewise, but for return values.
3516
3517 2019-04-11  Tom Tromey  <tromey@adacore.com>
3518
3519         * utils.c (internal_vproblem): Make "msg" const.
3520
3521 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
3522
3523         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
3524         * trad-frame.c (trad_frame_reset_saved_regs): New function.
3525         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
3526         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
3527
3528 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
3529
3530         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
3531         function.
3532         (fill_gregset): Call amd64_linux_collect_native_gregset instead
3533         of amd64_collect_native_gregset.
3534         (amd64_linux_nat_target::store_registers): Likewise.
3535
3536 2019-04-10  Tom Tromey  <tom@tromey.com>
3537
3538         * symtab.c (lookup_global_symbol_from_objfile)
3539         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
3540         * objfiles.h (class separate_debug_iterator): New.
3541         (class separate_debug_range): New.
3542         (struct objfile) <separate_debug_objfiles>: New method.
3543         (objfile_separate_debug_iterate): Don't declare.
3544         * objfiles.c (separate_debug_iterator::operator++): Rename from
3545         objfile_separate_debug_iterate.
3546         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
3547         iterator.
3548         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
3549         iterator.
3550
3551 2019-04-10  Tom Tromey  <tom@tromey.com>
3552
3553         * symfile.c (reread_symbols): Remove old comment.
3554         * objfiles.c (free_all_objfiles): Fix a typo.
3555
3556 2019-04-10  Tom Tromey  <tom@tromey.com>
3557
3558         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
3559         * minsyms.c (lookup_minimal_symbol): Use foreach.
3560         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
3561         (lookup_minimal_symbol_solib_trampoline): Likewise.
3562         * symfile.c (reread_symbols): Use foreach.
3563
3564 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
3565             Tom Tromey  <tromey@adacore.com>
3566
3567         PR rust/24414:
3568         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
3569         (rust_lex_int_test): Change "value" to be LONGEST.
3570         (rust_lex_tests): Add test for long integer literal.
3571
3572 2019-04-09  Tom Tromey  <tromey@adacore.com>
3573
3574         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
3575         to bool.
3576         (extended_remote_target::attach): Update.
3577         (remote_target::remote_notice_new_inferior): Update.
3578         (remote_target::add_current_inferior_and_thread): Update.
3579         * inferior.c (exit_inferior_1): Use "false".
3580         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
3581
3582 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
3583
3584         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
3585         the "start" command.
3586
3587 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3588
3589         * python/py-inferior.c (infpy_thread_from_thread_handle):
3590         Adjust comments to reflect renaming of thread_from_thread_handle
3591         to thread_from_handle.  Adjust keywords.  Fix type error message.
3592         (inferior_object_methods): Add thread_from_handle.  Retain
3593         thread_from_thread_handle, but mark it as deprecated.
3594
3595 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3596
3597         * gdbthread.h (find_thread_by_handle): Revise declaration.
3598         * thread.c (find_thread_by_handle): Likewise.  Adjust
3599         implementation too.
3600         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
3601         support for buffer objects as handles.
3602
3603 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3604
3605         * python/py-infthread.c (thpy_thread_handle): New function.
3606         (thread_object_methods): Register thpy_thread_handle.
3607
3608 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3609
3610         * gdbthread.h (thread_to_thread_handle): Declare.
3611         * thread.c (gdbtypes.h): Include.
3612         (thread_to_thread_handle): New function.
3613
3614         * target.h (struct target_ops): Add thread_info_to_thread_handle.
3615         (target_thread_info_to_thread_handle): Declare.
3616         * target.c (target_thread_info_to_thread_handle): New function.
3617         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
3618         * target-delegates.c: Regenerate.
3619
3620         * linux-thread-db.c (class thread_db_target): Add method
3621         thread_info_to_thread_handle.
3622         (thread_db_target::thread_info_to_thread_handle): Define.
3623         * remote.c (class remote_target): Add new method
3624         thread_info_to_thread_handle.
3625         (remote_target::thread_info_to_thread_handle): Define.
3626
3627 2019-04-08  Pedro Alves  <palves@redhat.com>
3628
3629         * common/common-exceptions.c (throw_exception): Don't create
3630         named object to throw; throw directly.
3631         (throw_it): Likewise.  Don't initialize gdb_exception::message
3632         here, with new; pass FMT and AP to the ctor instead.
3633         * common/common-exceptions.h: Include <string>.
3634         (gdb_exception::gdb_exception(enum return_reason, enum errors,
3635         const char *, va_list)): New ctor.  Use std::make_shared.
3636         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
3637         errors)): Delete.
3638         (gdb_exception_error::gdb_exception_error(enum errors, const char
3639         *, va_list)): New.
3640         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
3641         Add assertion.
3642         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
3643         errors)): Delete.
3644         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
3645         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
3646         Add assertion.
3647
3648 2019-04-08  Tom Tromey  <tom@tromey.com>
3649
3650         * valops.c (value_rtti_indirect_type): Replace throw_exception
3651         with throw.
3652         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
3653         with throw.
3654         * thread.c (thr_try_catch_cmd): Replace throw_exception with
3655         throw.
3656         * target.c (target_translate_tls_address): Replace throw_exception
3657         with throw.
3658         * stack.c (frame_apply_command_count): Replace throw_exception
3659         with throw.
3660         * solib-spu.c (append_ocl_sos): Replace throw_exception with
3661         throw.
3662         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
3663         with throw.
3664         * rs6000-tdep.c (rs6000_frame_cache)
3665         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
3666         * remote.c: Replace throw_exception with throw.
3667         * record-full.c (record_full_message, record_full_wait_1)
3668         (record_full_restore): Replace throw_exception with throw.
3669         * record-btrace.c:
3670         (get_thread_current_frame_id, record_btrace_start_replaying)
3671         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
3672         (cmd_record_btrace_start): Replace throw_exception with throw.
3673         * parse.c (parse_exp_in_context_1): Replace throw_exception with
3674         throw.
3675         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
3676         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
3677         * linespec.c:
3678         (find_linespec_symbols): Replace throw_exception with throw.
3679         * infrun.c (displaced_step_prepare, resume): Replace
3680         throw_exception with throw.
3681         * infcmd.c (post_create_inferior): Replace throw_exception with
3682         throw.
3683         * inf-loop.c (inferior_event_handler): Replace throw_exception
3684         with throw.
3685         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
3686         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
3687         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
3688         (get_prev_frame_always, get_frame_pc_if_available)
3689         (get_frame_address_in_block_if_available, get_frame_language):
3690         Replace throw_exception with throw.
3691         * frame-unwind.c (frame_unwind_try_unwinder): Replace
3692         throw_exception with throw.
3693         * eval.c (fetch_subexp_value, evaluate_var_value)
3694         (evaluate_funcall, evaluate_subexp_standard): Replace
3695         throw_exception with throw.
3696         * dwarf2loc.c (call_site_find_chain)
3697         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
3698         Replace throw_exception with throw.
3699         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
3700         with throw.
3701         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
3702         throw.
3703         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
3704         * completer.c (complete_line_internal): Replace throw_exception
3705         with throw.
3706         * compile/compile-object-run.c (compile_object_run): Replace
3707         throw_exception with throw.
3708         * cli/cli-script.c (process_next_line): Replace throw_exception
3709         with throw.
3710         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
3711         (btrace_enable, btrace_maint_update_pt_packets): Replace
3712         throw_exception with throw.
3713         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
3714         throw_exception with throw.
3715         * break-catch-throw.c (re_set_exception_catchpoint): Replace
3716         throw_exception with throw.
3717         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
3718         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
3719         * aarch64-tdep.c (aarch64_make_prologue_cache)
3720         (aarch64_make_stub_cache): Replace throw_exception with throw.
3721
3722 2019-04-08  Tom Tromey  <tom@tromey.com>
3723
3724         * common/common-exceptions.c (throw_exception): Rename from
3725         throw_exception_cxx.  Remove old copy.  Make argument const.
3726         (throw_it): Create and throw exception objects directly.
3727         * common/common-exceptions.h (throw_exception): Make argument
3728         const.
3729         (struct gdb_exception_error): Add constructor.
3730         (struct gdb_exception_quit): Add constructor.
3731
3732 2019-04-08  Tom Tromey  <tom@tromey.com>
3733
3734         * common/common-exceptions.h (exception_rethrow): Don't declare.
3735         (TRY_SJLJ): Update comment.
3736         (TRY, CATCH, END_CATCH): Remove.
3737         * common/common-exceptions.c (exception_rethrow): Remove.
3738
3739 2019-04-08  Tom Tromey  <tom@tromey.com>
3740
3741         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
3742         Remove.
3743         (gdb_exception_error): Rename from
3744         gdb_exception_RETURN_MASK_ERROR.
3745         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
3746         (gdb_quit_bad_alloc): Update.
3747         * aarch64-tdep.c: Update.
3748         * ada-lang.c: Update.
3749         * ada-typeprint.c: Update.
3750         * ada-valprint.c: Update.
3751         * amd64-tdep.c: Update.
3752         * arch-utils.c: Update.
3753         * break-catch-throw.c: Update.
3754         * breakpoint.c: Update.
3755         * btrace.c: Update.
3756         * c-varobj.c: Update.
3757         * cli/cli-cmds.c: Update.
3758         * cli/cli-interp.c: Update.
3759         * cli/cli-script.c: Update.
3760         * common/common-exceptions.c: Update.
3761         * common/new-op.c: Update.
3762         * common/selftest.c: Update.
3763         * compile/compile-c-symbols.c: Update.
3764         * compile/compile-cplus-symbols.c: Update.
3765         * compile/compile-object-load.c: Update.
3766         * compile/compile-object-run.c: Update.
3767         * completer.c: Update.
3768         * corelow.c: Update.
3769         * cp-abi.c: Update.
3770         * cp-support.c: Update.
3771         * cp-valprint.c: Update.
3772         * darwin-nat.c: Update.
3773         * disasm-selftests.c: Update.
3774         * dtrace-probe.c: Update.
3775         * dwarf-index-cache.c: Update.
3776         * dwarf-index-write.c: Update.
3777         * dwarf2-frame-tailcall.c: Update.
3778         * dwarf2-frame.c: Update.
3779         * dwarf2loc.c: Update.
3780         * dwarf2read.c: Update.
3781         * eval.c: Update.
3782         * event-loop.c: Update.
3783         * event-top.c: Update.
3784         * exec.c: Update.
3785         * f-valprint.c: Update.
3786         * fbsd-tdep.c: Update.
3787         * frame-unwind.c: Update.
3788         * frame.c: Update.
3789         * gdbtypes.c: Update.
3790         * gnu-v3-abi.c: Update.
3791         * guile/guile-internal.h: Update.
3792         * guile/scm-block.c: Update.
3793         * guile/scm-breakpoint.c: Update.
3794         * guile/scm-cmd.c: Update.
3795         * guile/scm-disasm.c: Update.
3796         * guile/scm-frame.c: Update.
3797         * guile/scm-lazy-string.c: Update.
3798         * guile/scm-math.c: Update.
3799         * guile/scm-param.c: Update.
3800         * guile/scm-ports.c: Update.
3801         * guile/scm-pretty-print.c: Update.
3802         * guile/scm-symbol.c: Update.
3803         * guile/scm-symtab.c: Update.
3804         * guile/scm-type.c: Update.
3805         * guile/scm-value.c: Update.
3806         * i386-linux-tdep.c: Update.
3807         * i386-tdep.c: Update.
3808         * inf-loop.c: Update.
3809         * infcall.c: Update.
3810         * infcmd.c: Update.
3811         * infrun.c: Update.
3812         * jit.c: Update.
3813         * language.c: Update.
3814         * linespec.c: Update.
3815         * linux-fork.c: Update.
3816         * linux-nat.c: Update.
3817         * linux-tdep.c: Update.
3818         * linux-thread-db.c: Update.
3819         * main.c: Update.
3820         * mi/mi-cmd-break.c: Update.
3821         * mi/mi-cmd-stack.c: Update.
3822         * mi/mi-interp.c: Update.
3823         * mi/mi-main.c: Update.
3824         * objc-lang.c: Update.
3825         * p-valprint.c: Update.
3826         * parse.c: Update.
3827         * ppc-linux-tdep.c: Update.
3828         * printcmd.c: Update.
3829         * python/py-arch.c: Update.
3830         * python/py-breakpoint.c: Update.
3831         * python/py-cmd.c: Update.
3832         * python/py-finishbreakpoint.c: Update.
3833         * python/py-frame.c: Update.
3834         * python/py-framefilter.c: Update.
3835         * python/py-gdb-readline.c: Update.
3836         * python/py-inferior.c: Update.
3837         * python/py-infthread.c: Update.
3838         * python/py-lazy-string.c: Update.
3839         * python/py-linetable.c: Update.
3840         * python/py-objfile.c: Update.
3841         * python/py-param.c: Update.
3842         * python/py-prettyprint.c: Update.
3843         * python/py-progspace.c: Update.
3844         * python/py-record-btrace.c: Update.
3845         * python/py-record.c: Update.
3846         * python/py-symbol.c: Update.
3847         * python/py-type.c: Update.
3848         * python/py-unwind.c: Update.
3849         * python/py-utils.c: Update.
3850         * python/py-value.c: Update.
3851         * python/python.c: Update.
3852         * record-btrace.c: Update.
3853         * record-full.c: Update.
3854         * remote-fileio.c: Update.
3855         * remote.c: Update.
3856         * riscv-tdep.c: Update.
3857         * rs6000-aix-tdep.c: Update.
3858         * rs6000-tdep.c: Update.
3859         * rust-exp.y: Update.
3860         * rust-lang.c: Update.
3861         * s390-tdep.c: Update.
3862         * selftest-arch.c: Update.
3863         * solib-dsbt.c: Update.
3864         * solib-frv.c: Update.
3865         * solib-spu.c: Update.
3866         * solib-svr4.c: Update.
3867         * solib.c: Update.
3868         * sparc64-linux-tdep.c: Update.
3869         * stack.c: Update.
3870         * symfile-mem.c: Update.
3871         * symmisc.c: Update.
3872         * target.c: Update.
3873         * thread.c: Update.
3874         * top.c: Update.
3875         * tracefile-tfile.c: Update.
3876         * tui/tui.c: Update.
3877         * typeprint.c: Update.
3878         * unittests/cli-utils-selftests.c: Update.
3879         * unittests/parse-connection-spec-selftests.c: Update.
3880         * valops.c: Update.
3881         * valprint.c: Update.
3882         * value.c: Update.
3883         * varobj.c: Update.
3884         * windows-nat.c: Update.
3885         * x86-linux-nat.c: Update.
3886         * xml-support.c: Update.
3887
3888 2019-04-08  Tom Tromey  <tom@tromey.com>
3889
3890         * xml-support.c: Use C++ exception handling.
3891         * x86-linux-nat.c: Use C++ exception handling.
3892         * windows-nat.c: Use C++ exception handling.
3893         * varobj.c: Use C++ exception handling.
3894         * value.c: Use C++ exception handling.
3895         * valprint.c: Use C++ exception handling.
3896         * valops.c: Use C++ exception handling.
3897         * unittests/parse-connection-spec-selftests.c: Use C++ exception
3898         handling.
3899         * unittests/cli-utils-selftests.c: Use C++ exception handling.
3900         * typeprint.c: Use C++ exception handling.
3901         * tui/tui.c: Use C++ exception handling.
3902         * tracefile-tfile.c: Use C++ exception handling.
3903         * top.c: Use C++ exception handling.
3904         * thread.c: Use C++ exception handling.
3905         * target.c: Use C++ exception handling.
3906         * symmisc.c: Use C++ exception handling.
3907         * symfile-mem.c: Use C++ exception handling.
3908         * stack.c: Use C++ exception handling.
3909         * sparc64-linux-tdep.c: Use C++ exception handling.
3910         * solib.c: Use C++ exception handling.
3911         * solib-svr4.c: Use C++ exception handling.
3912         * solib-spu.c: Use C++ exception handling.
3913         * solib-frv.c: Use C++ exception handling.
3914         * solib-dsbt.c: Use C++ exception handling.
3915         * selftest-arch.c: Use C++ exception handling.
3916         * s390-tdep.c: Use C++ exception handling.
3917         * rust-lang.c: Use C++ exception handling.
3918         * rust-exp.y: Use C++ exception handling.
3919         * rs6000-tdep.c: Use C++ exception handling.
3920         * rs6000-aix-tdep.c: Use C++ exception handling.
3921         * riscv-tdep.c: Use C++ exception handling.
3922         * remote.c: Use C++ exception handling.
3923         * remote-fileio.c: Use C++ exception handling.
3924         * record-full.c: Use C++ exception handling.
3925         * record-btrace.c: Use C++ exception handling.
3926         * python/python.c: Use C++ exception handling.
3927         * python/py-value.c: Use C++ exception handling.
3928         * python/py-utils.c: Use C++ exception handling.
3929         * python/py-unwind.c: Use C++ exception handling.
3930         * python/py-type.c: Use C++ exception handling.
3931         * python/py-symbol.c: Use C++ exception handling.
3932         * python/py-record.c: Use C++ exception handling.
3933         * python/py-record-btrace.c: Use C++ exception handling.
3934         * python/py-progspace.c: Use C++ exception handling.
3935         * python/py-prettyprint.c: Use C++ exception handling.
3936         * python/py-param.c: Use C++ exception handling.
3937         * python/py-objfile.c: Use C++ exception handling.
3938         * python/py-linetable.c: Use C++ exception handling.
3939         * python/py-lazy-string.c: Use C++ exception handling.
3940         * python/py-infthread.c: Use C++ exception handling.
3941         * python/py-inferior.c: Use C++ exception handling.
3942         * python/py-gdb-readline.c: Use C++ exception handling.
3943         * python/py-framefilter.c: Use C++ exception handling.
3944         * python/py-frame.c: Use C++ exception handling.
3945         * python/py-finishbreakpoint.c: Use C++ exception handling.
3946         * python/py-cmd.c: Use C++ exception handling.
3947         * python/py-breakpoint.c: Use C++ exception handling.
3948         * python/py-arch.c: Use C++ exception handling.
3949         * printcmd.c: Use C++ exception handling.
3950         * ppc-linux-tdep.c: Use C++ exception handling.
3951         * parse.c: Use C++ exception handling.
3952         * p-valprint.c: Use C++ exception handling.
3953         * objc-lang.c: Use C++ exception handling.
3954         * mi/mi-main.c: Use C++ exception handling.
3955         * mi/mi-interp.c: Use C++ exception handling.
3956         * mi/mi-cmd-stack.c: Use C++ exception handling.
3957         * mi/mi-cmd-break.c: Use C++ exception handling.
3958         * main.c: Use C++ exception handling.
3959         * linux-thread-db.c: Use C++ exception handling.
3960         * linux-tdep.c: Use C++ exception handling.
3961         * linux-nat.c: Use C++ exception handling.
3962         * linux-fork.c: Use C++ exception handling.
3963         * linespec.c: Use C++ exception handling.
3964         * language.c: Use C++ exception handling.
3965         * jit.c: Use C++ exception handling.
3966         * infrun.c: Use C++ exception handling.
3967         * infcmd.c: Use C++ exception handling.
3968         * infcall.c: Use C++ exception handling.
3969         * inf-loop.c: Use C++ exception handling.
3970         * i386-tdep.c: Use C++ exception handling.
3971         * i386-linux-tdep.c: Use C++ exception handling.
3972         * guile/scm-value.c: Use C++ exception handling.
3973         * guile/scm-type.c: Use C++ exception handling.
3974         * guile/scm-symtab.c: Use C++ exception handling.
3975         * guile/scm-symbol.c: Use C++ exception handling.
3976         * guile/scm-pretty-print.c: Use C++ exception handling.
3977         * guile/scm-ports.c: Use C++ exception handling.
3978         * guile/scm-param.c: Use C++ exception handling.
3979         * guile/scm-math.c: Use C++ exception handling.
3980         * guile/scm-lazy-string.c: Use C++ exception handling.
3981         * guile/scm-frame.c: Use C++ exception handling.
3982         * guile/scm-disasm.c: Use C++ exception handling.
3983         * guile/scm-cmd.c: Use C++ exception handling.
3984         * guile/scm-breakpoint.c: Use C++ exception handling.
3985         * guile/scm-block.c: Use C++ exception handling.
3986         * guile/guile-internal.h: Use C++ exception handling.
3987         * gnu-v3-abi.c: Use C++ exception handling.
3988         * gdbtypes.c: Use C++ exception handling.
3989         * frame.c: Use C++ exception handling.
3990         * frame-unwind.c: Use C++ exception handling.
3991         * fbsd-tdep.c: Use C++ exception handling.
3992         * f-valprint.c: Use C++ exception handling.
3993         * exec.c: Use C++ exception handling.
3994         * event-top.c: Use C++ exception handling.
3995         * event-loop.c: Use C++ exception handling.
3996         * eval.c: Use C++ exception handling.
3997         * dwarf2read.c: Use C++ exception handling.
3998         * dwarf2loc.c: Use C++ exception handling.
3999         * dwarf2-frame.c: Use C++ exception handling.
4000         * dwarf2-frame-tailcall.c: Use C++ exception handling.
4001         * dwarf-index-write.c: Use C++ exception handling.
4002         * dwarf-index-cache.c: Use C++ exception handling.
4003         * dtrace-probe.c: Use C++ exception handling.
4004         * disasm-selftests.c: Use C++ exception handling.
4005         * darwin-nat.c: Use C++ exception handling.
4006         * cp-valprint.c: Use C++ exception handling.
4007         * cp-support.c: Use C++ exception handling.
4008         * cp-abi.c: Use C++ exception handling.
4009         * corelow.c: Use C++ exception handling.
4010         * completer.c: Use C++ exception handling.
4011         * compile/compile-object-run.c: Use C++ exception handling.
4012         * compile/compile-object-load.c: Use C++ exception handling.
4013         * compile/compile-cplus-symbols.c: Use C++ exception handling.
4014         * compile/compile-c-symbols.c: Use C++ exception handling.
4015         * common/selftest.c: Use C++ exception handling.
4016         * common/new-op.c: Use C++ exception handling.
4017         * cli/cli-script.c: Use C++ exception handling.
4018         * cli/cli-interp.c: Use C++ exception handling.
4019         * cli/cli-cmds.c: Use C++ exception handling.
4020         * c-varobj.c: Use C++ exception handling.
4021         * btrace.c: Use C++ exception handling.
4022         * breakpoint.c: Use C++ exception handling.
4023         * break-catch-throw.c: Use C++ exception handling.
4024         * arch-utils.c: Use C++ exception handling.
4025         * amd64-tdep.c: Use C++ exception handling.
4026         * ada-valprint.c: Use C++ exception handling.
4027         * ada-typeprint.c: Use C++ exception handling.
4028         * ada-lang.c: Use C++ exception handling.
4029         * aarch64-tdep.c: Use C++ exception handling.
4030
4031 2019-04-08  Tom Tromey  <tom@tromey.com>
4032
4033         * xml-support.c (gdb_xml_parser::parse): Update.
4034         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4035         * value.c (show_convenience): Update.
4036         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
4037         (test_parse_flags_qcs): Update.
4038         * thread.c (thr_try_catch_cmd): Update.
4039         * target.c (target_translate_tls_address): Update.
4040         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4041         (info_frame_command_core, frame_apply_command_count): Update.
4042         * rust-exp.y (rust_lex_exception_test): Update.
4043         * riscv-tdep.c (riscv_print_one_register_info): Update.
4044         * remote.c (remote_target::enable_btrace): Update.
4045         * record-btrace.c (record_btrace_enable_warn): Update.
4046         * python/py-utils.c (gdbpy_convert_exception): Update.
4047         * printcmd.c (do_one_display, print_variable_and_value): Update.
4048         * mi/mi-main.c (mi_print_exception): Update.
4049         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
4050         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4051         * linux-nat.c (linux_nat_target::attach): Update.
4052         * linux-fork.c (class scoped_switch_fork_info): Update.
4053         * infrun.c (displaced_step_prepare): Update.
4054         * infcall.c (call_function_by_hand_dummy): Update.
4055         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
4056         * gnu-v3-abi.c (print_one_vtable): Update.
4057         * frame.c (get_prev_frame_always): Update.
4058         * f-valprint.c (info_common_command_for_block): Update.
4059         * exec.c (try_open_exec_file): Update.
4060         * exceptions.c (print_exception, exception_print)
4061         (exception_fprintf, exception_print_same): Update.
4062         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
4063         * dwarf-index-cache.c (index_cache::store)
4064         (index_cache::lookup_gdb_index): Update.
4065         * darwin-nat.c (maybe_cache_shell): Update.
4066         * cp-valprint.c (cp_print_value_fields): Update.
4067         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
4068         (gcc_cplus_symbol_address): Update.
4069         * compile/compile-c-symbols.c (gcc_convert_symbol)
4070         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
4071         * common/selftest.c: Update.
4072         * common/common-exceptions.h (struct gdb_exception) <message>: Now
4073         a std::string.
4074         (exception_try_scope_entry, exception_try_scope_exit): Don't
4075         declare.
4076         (struct exception_try_scope): Remove.
4077         (TRY): Don't use exception_try_scope.
4078         (struct gdb_exception): Add constructor, operator=.
4079         <what>: New method.
4080         (struct gdb_exception_RETURN_MASK_ALL)
4081         (struct gdb_exception_RETURN_MASK_ERROR)
4082         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
4083         (struct gdb_quit_bad_alloc): Update.
4084         * common/common-exceptions.c (exception_none): Change
4085         initializer.
4086         (struct catcher) <state, exception>: Initialize inline.
4087         <prev>: Remove member.
4088         (current_catcher): Remove.
4089         (catchers): New global.
4090         (exceptions_state_mc_init): Simplify.
4091         (catcher_pop): Remove.
4092         (exceptions_state_mc, exceptions_state_mc_catch): Update.
4093         (try_scope_depth, exception_try_scope_entry)
4094         (exception_try_scope_exit): Remove.
4095         (throw_exception_sjlj): Update.
4096         (exception_messages, exception_messages_size): Remove.
4097         (throw_it): Simplify.
4098         (gdb_exception_sliced_copy): Remove.
4099         (throw_exception_cxx): Update.
4100         * cli/cli-script.c (script_from_file): Update.
4101         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
4102         Update.
4103         * ada-valprint.c (ada_val_print): Update.
4104         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
4105         (create_excep_cond_exprs): Update.
4106
4107 2019-04-08  Tom Tromey  <tom@tromey.com>
4108
4109         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
4110         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
4111         (TRY, CATCH, END_CATCH): Remove some definitions.
4112         * common/common-exceptions.c: Don't use GDB_XCPT.
4113         (catcher_list_size): Remove.
4114         (throw_exception, throw_it): Simplify.
4115
4116 2019-04-05  Tom Tromey  <tom@tromey.com>
4117
4118         Revert the header-sorting patch.
4119         * ft32-tdep.c: Revert.
4120         * frv-tdep.c: Revert.
4121         * frv-linux-tdep.c: Revert.
4122         * frame.c: Revert.
4123         * frame-unwind.c: Revert.
4124         * frame-base.c: Revert.
4125         * fork-child.c: Revert.
4126         * findvar.c: Revert.
4127         * findcmd.c: Revert.
4128         * filesystem.c: Revert.
4129         * filename-seen-cache.h: Revert.
4130         * filename-seen-cache.c: Revert.
4131         * fbsd-tdep.c: Revert.
4132         * fbsd-nat.h: Revert.
4133         * fbsd-nat.c: Revert.
4134         * f-valprint.c: Revert.
4135         * f-typeprint.c: Revert.
4136         * f-lang.c: Revert.
4137         * extension.h: Revert.
4138         * extension.c: Revert.
4139         * extension-priv.h: Revert.
4140         * expprint.c: Revert.
4141         * exec.h: Revert.
4142         * exec.c: Revert.
4143         * exceptions.c: Revert.
4144         * event-top.c: Revert.
4145         * event-loop.c: Revert.
4146         * eval.c: Revert.
4147         * elfread.c: Revert.
4148         * dwarf2read.h: Revert.
4149         * dwarf2read.c: Revert.
4150         * dwarf2loc.c: Revert.
4151         * dwarf2expr.h: Revert.
4152         * dwarf2expr.c: Revert.
4153         * dwarf2-frame.c: Revert.
4154         * dwarf2-frame-tailcall.c: Revert.
4155         * dwarf-index-write.h: Revert.
4156         * dwarf-index-write.c: Revert.
4157         * dwarf-index-common.c: Revert.
4158         * dwarf-index-cache.h: Revert.
4159         * dwarf-index-cache.c: Revert.
4160         * dummy-frame.c: Revert.
4161         * dtrace-probe.c: Revert.
4162         * disasm.h: Revert.
4163         * disasm.c: Revert.
4164         * disasm-selftests.c: Revert.
4165         * dictionary.c: Revert.
4166         * dicos-tdep.c: Revert.
4167         * demangle.c: Revert.
4168         * dcache.h: Revert.
4169         * dcache.c: Revert.
4170         * darwin-nat.h: Revert.
4171         * darwin-nat.c: Revert.
4172         * darwin-nat-info.c: Revert.
4173         * d-valprint.c: Revert.
4174         * d-namespace.c: Revert.
4175         * d-lang.c: Revert.
4176         * ctf.c: Revert.
4177         * csky-tdep.c: Revert.
4178         * csky-linux-tdep.c: Revert.
4179         * cris-tdep.c: Revert.
4180         * cris-linux-tdep.c: Revert.
4181         * cp-valprint.c: Revert.
4182         * cp-support.c: Revert.
4183         * cp-namespace.c: Revert.
4184         * cp-abi.c: Revert.
4185         * corelow.c: Revert.
4186         * corefile.c: Revert.
4187         * continuations.c: Revert.
4188         * completer.h: Revert.
4189         * completer.c: Revert.
4190         * complaints.c: Revert.
4191         * coffread.c: Revert.
4192         * coff-pe-read.c: Revert.
4193         * cli-out.h: Revert.
4194         * cli-out.c: Revert.
4195         * charset.c: Revert.
4196         * c-varobj.c: Revert.
4197         * c-valprint.c: Revert.
4198         * c-typeprint.c: Revert.
4199         * c-lang.c: Revert.
4200         * buildsym.c: Revert.
4201         * buildsym-legacy.c: Revert.
4202         * build-id.h: Revert.
4203         * build-id.c: Revert.
4204         * btrace.c: Revert.
4205         * bsd-uthread.c: Revert.
4206         * breakpoint.h: Revert.
4207         * breakpoint.c: Revert.
4208         * break-catch-throw.c: Revert.
4209         * break-catch-syscall.c: Revert.
4210         * break-catch-sig.c: Revert.
4211         * blockframe.c: Revert.
4212         * block.c: Revert.
4213         * bfin-tdep.c: Revert.
4214         * bfin-linux-tdep.c: Revert.
4215         * bfd-target.c: Revert.
4216         * bcache.c: Revert.
4217         * ax-general.c: Revert.
4218         * ax-gdb.h: Revert.
4219         * ax-gdb.c: Revert.
4220         * avr-tdep.c: Revert.
4221         * auxv.c: Revert.
4222         * auto-load.c: Revert.
4223         * arm-wince-tdep.c: Revert.
4224         * arm-tdep.c: Revert.
4225         * arm-symbian-tdep.c: Revert.
4226         * arm-pikeos-tdep.c: Revert.
4227         * arm-obsd-tdep.c: Revert.
4228         * arm-nbsd-tdep.c: Revert.
4229         * arm-nbsd-nat.c: Revert.
4230         * arm-linux-tdep.c: Revert.
4231         * arm-linux-nat.c: Revert.
4232         * arm-fbsd-tdep.c: Revert.
4233         * arm-fbsd-nat.c: Revert.
4234         * arm-bsd-tdep.c: Revert.
4235         * arch-utils.c: Revert.
4236         * arc-tdep.c: Revert.
4237         * arc-newlib-tdep.c: Revert.
4238         * annotate.h: Revert.
4239         * annotate.c: Revert.
4240         * amd64-windows-tdep.c: Revert.
4241         * amd64-windows-nat.c: Revert.
4242         * amd64-tdep.c: Revert.
4243         * amd64-sol2-tdep.c: Revert.
4244         * amd64-obsd-tdep.c: Revert.
4245         * amd64-obsd-nat.c: Revert.
4246         * amd64-nbsd-tdep.c: Revert.
4247         * amd64-nbsd-nat.c: Revert.
4248         * amd64-nat.c: Revert.
4249         * amd64-linux-tdep.c: Revert.
4250         * amd64-linux-nat.c: Revert.
4251         * amd64-fbsd-tdep.c: Revert.
4252         * amd64-fbsd-nat.c: Revert.
4253         * amd64-dicos-tdep.c: Revert.
4254         * amd64-darwin-tdep.c: Revert.
4255         * amd64-bsd-nat.c: Revert.
4256         * alpha-tdep.c: Revert.
4257         * alpha-obsd-tdep.c: Revert.
4258         * alpha-nbsd-tdep.c: Revert.
4259         * alpha-mdebug-tdep.c: Revert.
4260         * alpha-linux-tdep.c: Revert.
4261         * alpha-linux-nat.c: Revert.
4262         * alpha-bsd-tdep.c: Revert.
4263         * alpha-bsd-nat.c: Revert.
4264         * aix-thread.c: Revert.
4265         * agent.c: Revert.
4266         * addrmap.c: Revert.
4267         * ada-varobj.c: Revert.
4268         * ada-valprint.c: Revert.
4269         * ada-typeprint.c: Revert.
4270         * ada-tasks.c: Revert.
4271         * ada-lang.c: Revert.
4272         * aarch64-tdep.c: Revert.
4273         * aarch64-ravenscar-thread.c: Revert.
4274         * aarch64-newlib-tdep.c: Revert.
4275         * aarch64-linux-tdep.c: Revert.
4276         * aarch64-linux-nat.c: Revert.
4277         * aarch64-fbsd-tdep.c: Revert.
4278         * aarch64-fbsd-nat.c: Revert.
4279         * aarch32-linux-nat.c: Revert.
4280
4281 2019-04-05  Tom Tromey  <tom@tromey.com>
4282
4283         * ft32-tdep.c: Sort headers.
4284         * frv-tdep.c: Sort headers.
4285         * frv-linux-tdep.c: Sort headers.
4286         * frame.c: Sort headers.
4287         * frame-unwind.c: Sort headers.
4288         * frame-base.c: Sort headers.
4289         * fork-child.c: Sort headers.
4290         * findvar.c: Sort headers.
4291         * findcmd.c: Sort headers.
4292         * filesystem.c: Sort headers.
4293         * filename-seen-cache.h: Sort headers.
4294         * filename-seen-cache.c: Sort headers.
4295         * fbsd-tdep.c: Sort headers.
4296         * fbsd-nat.h: Sort headers.
4297         * fbsd-nat.c: Sort headers.
4298         * f-valprint.c: Sort headers.
4299         * f-typeprint.c: Sort headers.
4300         * f-lang.c: Sort headers.
4301         * extension.h: Sort headers.
4302         * extension.c: Sort headers.
4303         * extension-priv.h: Sort headers.
4304         * expprint.c: Sort headers.
4305         * exec.h: Sort headers.
4306         * exec.c: Sort headers.
4307         * exceptions.c: Sort headers.
4308         * event-top.c: Sort headers.
4309         * event-loop.c: Sort headers.
4310         * eval.c: Sort headers.
4311         * elfread.c: Sort headers.
4312         * dwarf2read.h: Sort headers.
4313         * dwarf2read.c: Sort headers.
4314         * dwarf2loc.c: Sort headers.
4315         * dwarf2expr.h: Sort headers.
4316         * dwarf2expr.c: Sort headers.
4317         * dwarf2-frame.c: Sort headers.
4318         * dwarf2-frame-tailcall.c: Sort headers.
4319         * dwarf-index-write.h: Sort headers.
4320         * dwarf-index-write.c: Sort headers.
4321         * dwarf-index-common.c: Sort headers.
4322         * dwarf-index-cache.h: Sort headers.
4323         * dwarf-index-cache.c: Sort headers.
4324         * dummy-frame.c: Sort headers.
4325         * dtrace-probe.c: Sort headers.
4326         * disasm.h: Sort headers.
4327         * disasm.c: Sort headers.
4328         * disasm-selftests.c: Sort headers.
4329         * dictionary.c: Sort headers.
4330         * dicos-tdep.c: Sort headers.
4331         * demangle.c: Sort headers.
4332         * dcache.h: Sort headers.
4333         * dcache.c: Sort headers.
4334         * darwin-nat.h: Sort headers.
4335         * darwin-nat.c: Sort headers.
4336         * darwin-nat-info.c: Sort headers.
4337         * d-valprint.c: Sort headers.
4338         * d-namespace.c: Sort headers.
4339         * d-lang.c: Sort headers.
4340         * ctf.c: Sort headers.
4341         * csky-tdep.c: Sort headers.
4342         * csky-linux-tdep.c: Sort headers.
4343         * cris-tdep.c: Sort headers.
4344         * cris-linux-tdep.c: Sort headers.
4345         * cp-valprint.c: Sort headers.
4346         * cp-support.c: Sort headers.
4347         * cp-namespace.c: Sort headers.
4348         * cp-abi.c: Sort headers.
4349         * corelow.c: Sort headers.
4350         * corefile.c: Sort headers.
4351         * continuations.c: Sort headers.
4352         * completer.h: Sort headers.
4353         * completer.c: Sort headers.
4354         * complaints.c: Sort headers.
4355         * coffread.c: Sort headers.
4356         * coff-pe-read.c: Sort headers.
4357         * cli-out.h: Sort headers.
4358         * cli-out.c: Sort headers.
4359         * charset.c: Sort headers.
4360         * c-varobj.c: Sort headers.
4361         * c-valprint.c: Sort headers.
4362         * c-typeprint.c: Sort headers.
4363         * c-lang.c: Sort headers.
4364         * buildsym.c: Sort headers.
4365         * buildsym-legacy.c: Sort headers.
4366         * build-id.h: Sort headers.
4367         * build-id.c: Sort headers.
4368         * btrace.c: Sort headers.
4369         * bsd-uthread.c: Sort headers.
4370         * breakpoint.h: Sort headers.
4371         * breakpoint.c: Sort headers.
4372         * break-catch-throw.c: Sort headers.
4373         * break-catch-syscall.c: Sort headers.
4374         * break-catch-sig.c: Sort headers.
4375         * blockframe.c: Sort headers.
4376         * block.c: Sort headers.
4377         * bfin-tdep.c: Sort headers.
4378         * bfin-linux-tdep.c: Sort headers.
4379         * bfd-target.c: Sort headers.
4380         * bcache.c: Sort headers.
4381         * ax-general.c: Sort headers.
4382         * ax-gdb.h: Sort headers.
4383         * ax-gdb.c: Sort headers.
4384         * avr-tdep.c: Sort headers.
4385         * auxv.c: Sort headers.
4386         * auto-load.c: Sort headers.
4387         * arm-wince-tdep.c: Sort headers.
4388         * arm-tdep.c: Sort headers.
4389         * arm-symbian-tdep.c: Sort headers.
4390         * arm-pikeos-tdep.c: Sort headers.
4391         * arm-obsd-tdep.c: Sort headers.
4392         * arm-nbsd-tdep.c: Sort headers.
4393         * arm-nbsd-nat.c: Sort headers.
4394         * arm-linux-tdep.c: Sort headers.
4395         * arm-linux-nat.c: Sort headers.
4396         * arm-fbsd-tdep.c: Sort headers.
4397         * arm-fbsd-nat.c: Sort headers.
4398         * arm-bsd-tdep.c: Sort headers.
4399         * arch-utils.c: Sort headers.
4400         * arc-tdep.c: Sort headers.
4401         * arc-newlib-tdep.c: Sort headers.
4402         * annotate.h: Sort headers.
4403         * annotate.c: Sort headers.
4404         * amd64-windows-tdep.c: Sort headers.
4405         * amd64-windows-nat.c: Sort headers.
4406         * amd64-tdep.c: Sort headers.
4407         * amd64-sol2-tdep.c: Sort headers.
4408         * amd64-obsd-tdep.c: Sort headers.
4409         * amd64-obsd-nat.c: Sort headers.
4410         * amd64-nbsd-tdep.c: Sort headers.
4411         * amd64-nbsd-nat.c: Sort headers.
4412         * amd64-nat.c: Sort headers.
4413         * amd64-linux-tdep.c: Sort headers.
4414         * amd64-linux-nat.c: Sort headers.
4415         * amd64-fbsd-tdep.c: Sort headers.
4416         * amd64-fbsd-nat.c: Sort headers.
4417         * amd64-dicos-tdep.c: Sort headers.
4418         * amd64-darwin-tdep.c: Sort headers.
4419         * amd64-bsd-nat.c: Sort headers.
4420         * alpha-tdep.c: Sort headers.
4421         * alpha-obsd-tdep.c: Sort headers.
4422         * alpha-nbsd-tdep.c: Sort headers.
4423         * alpha-mdebug-tdep.c: Sort headers.
4424         * alpha-linux-tdep.c: Sort headers.
4425         * alpha-linux-nat.c: Sort headers.
4426         * alpha-bsd-tdep.c: Sort headers.
4427         * alpha-bsd-nat.c: Sort headers.
4428         * aix-thread.c: Sort headers.
4429         * agent.c: Sort headers.
4430         * addrmap.c: Sort headers.
4431         * ada-varobj.c: Sort headers.
4432         * ada-valprint.c: Sort headers.
4433         * ada-typeprint.c: Sort headers.
4434         * ada-tasks.c: Sort headers.
4435         * ada-lang.c: Sort headers.
4436         * aarch64-tdep.c: Sort headers.
4437         * aarch64-ravenscar-thread.c: Sort headers.
4438         * aarch64-newlib-tdep.c: Sort headers.
4439         * aarch64-linux-tdep.c: Sort headers.
4440         * aarch64-linux-nat.c: Sort headers.
4441         * aarch64-fbsd-tdep.c: Sort headers.
4442         * aarch64-fbsd-nat.c: Sort headers.
4443         * aarch32-linux-nat.c: Sort headers.
4444
4445 2019-04-04  Tom Tromey  <tom@tromey.com>
4446
4447         * varobj.c (varobj_create): Update.
4448         * rust-exp.y (struct rust_parser) <update_innermost_block,
4449         lookup_symbol>: New methods.
4450         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
4451         Rename.
4452         (rust_parser::rust_lookup_type)
4453         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4454         * printcmd.c (display_command, do_one_display): Update.
4455         * parser-defs.h (struct parser_state) <parser_state>: Add
4456         "tracker" parameter.
4457         (block_tracker): New member.
4458         (class innermost_block_tracker) <innermost_block_tracker>: Add
4459         "types" parameter.
4460         <reset>: Remove method.
4461         (innermost_block): Don't declare.
4462         (null_post_parser): Update.
4463         * parse.c (innermost_block): Remove global.
4464         (write_dollar_variable): Update.
4465         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
4466         Remove "tracker_types" parameter.
4467         (parse_expression): Add "tracker" parameter.
4468         (parse_expression_for_completion): Update.
4469         (null_post_parser): Add "tracker" parameter.
4470         * p-exp.y: Update rules.
4471         * m2-exp.y: Update rules.
4472         * language.h (struct language_defn) <la_post_parser>: Add
4473         "tracker" parameter.
4474         * go-exp.y: Update rules.
4475         * f-exp.y: Update rules.
4476         * expression.h (parse_expression, parse_exp_1): Add "tracker"
4477         parameter.
4478         * d-exp.y: Update rules.
4479         * c-exp.y: Update rules.
4480         * breakpoint.c (set_breakpoint_condition): Create an
4481         innermost_block_tracker.
4482         (watch_command_1): Likewise.
4483         * ada-lang.c (resolve): Add "tracker" parameter.
4484         (resolve_subexp): Likewise.
4485         * ada-exp.y (write_var_from_sym): Update.
4486
4487 2019-04-04  Tom Tromey  <tom@tromey.com>
4488
4489         * type-stack.h: New file.
4490         * type-stack.c: New file.
4491         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
4492         type-stack.h.
4493         (insert_into_type_stack, insert_type, push_type, push_type_int)
4494         (insert_type_address_space, pop_type, pop_type_int)
4495         (pop_typelist, pop_type_stack, append_type_stack)
4496         (push_type_stack, get_type_stack, push_typelist)
4497         (follow_type_instance_flags, follow_types): Don't declare.
4498         * parse.c (type_stack): Remove global.
4499         (parse_exp_in_context): Update.
4500         (insert_into_type_stack, insert_type, push_type, push_type_int)
4501         (insert_type_address_space, pop_type, pop_type_int)
4502         (pop_typelist, pop_type_stack, append_type_stack)
4503         (push_type_stack, get_type_stack, push_typelist)
4504         (follow_type_instance_flags, follow_types): Remove (moved to
4505         type-stack.c).
4506         * f-exp.y (type_stack): New global.
4507         Update rules.
4508         (push_kind_type, f_parse): Update.
4509         * d-exp.y (type_stack): New global.
4510         Update rules.
4511         (d_parse): Update.
4512         * c-exp.y (struct c_parse_state) <type_stack>: New member.
4513         Update rules.
4514         * Makefile.in (COMMON_SFILES): Add type-stack.c.
4515         (HFILES_NO_SRCDIR): Add type-stack.h.
4516
4517 2019-04-04  Tom Tromey  <tom@tromey.com>
4518
4519         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
4520         (rust_parser::convert_ast_to_expression, rust_parse)
4521         (rust_lex_test_completion, rust_lex_tests): Update.
4522         * parser-defs.h (struct expr_completion_state): New.
4523         (struct parser_state) <parser_state>: Add completion parameter.
4524         <mark_struct_expression, mark_completion_tag>: New methods.
4525         <parse_completion, m_completion_state>: New members.
4526         (prefixify_expression, null_post_parser): Update.
4527         (mark_struct_expression, mark_completion_tag): Don't declare.
4528         * parse.c (parse_completion, expout_last_struct)
4529         (expout_tag_completion_type, expout_completion_name): Remove
4530         globals.
4531         (parser_state::mark_struct_expression)
4532         (parser_state::mark_completion_tag): Now methods.
4533         (prefixify_expression): Add last_struct parameter.
4534         (prefixify_subexp): Likewise.
4535         (parse_exp_1): Update.
4536         (parse_exp_in_context): Add cstate parameter.  Update.
4537         (parse_expression_for_completion): Create an
4538         expr_completion_state.
4539         (null_post_parser): Add "completion" parameter.
4540         * p-exp.y: Update rules.
4541         (yylex): Update.
4542         * language.h (struct language_defn) <la_post_parser>: Add
4543         "completing" parameter.
4544         * go-exp.y: Update rules.
4545         (lex_one_token): Update.
4546         * expression.h (parse_completion): Don't declare.
4547         * d-exp.y: Update rules.
4548         (lex_one_token): Update rules.
4549         * c-exp.y: Update rules.
4550         (lex_one_token): Update.
4551         * ada-lang.c (resolve): Add "parse_completion" parameter.
4552         (resolve_subexp): Likewise.
4553         (ada_resolve_function): Likewise.
4554
4555 2019-04-04  Tom Tromey  <tom@tromey.com>
4556
4557         * parser-defs.h (struct parser_state) <start_arglist,
4558         end_arglist>: New methods.
4559         <arglist_len, m_funcall_chain>: New members.
4560         (arglist_len, start_arglist, end_arglist): Don't declare.
4561         * parse.c (arglist_len, funcall_chain): Remove global.
4562         (start_arglist, end_arglist): Remove functions.
4563         (parse_exp_in_context): Update.
4564         * p-exp.y: Update rules.
4565         * m2-exp.y: Update rules.
4566         * go-exp.y: Update rules.
4567         * f-exp.y: Update rules.
4568         * d-exp.y: Update rules.
4569         * c-exp.y: Update rules.
4570
4571 2019-04-04  Tom Tromey  <tom@tromey.com>
4572
4573         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
4574         lex_operator, push_back>: New methods.
4575         Update all rules.
4576         (rust_parser::lex_hex, lex_escape): Rename and update.
4577         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
4578         (rust_parser::lex_operator): Rename and update.
4579         (rust_parser::lex_number, rustyylex, rustyyerror)
4580         (rust_lex_test_init, rust_lex_test_sequence)
4581         (rust_lex_test_push_back, rust_lex_tests): Update.
4582         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
4583         parameter.
4584         <lexptr, prev_lexptr>: New members.
4585         (lexptr, prev_lexptr): Don't declare.
4586         * parse.c (lexptr, prev_lexptr): Remove globals.
4587         (parse_exp_in_context): Update.
4588         * p-exp.y (yylex, yyerror): Update.
4589         * m2-exp.y (parse_number, yylex, yyerror): Update.
4590         * go-exp.y (lex_one_token, yyerror): Update.
4591         * f-exp.y (match_string_literal, yylex, yyerror): Update.
4592         * d-exp.y (lex_one_token, yyerror): Update.
4593         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
4594         (lex_one_token, yyerror): Update.
4595         * ada-lex.l (YY_INPUT): Update.
4596         (rewind_to_char): Update.
4597         * ada-exp.y (yyerror): Update.
4598
4599 2019-04-04  Tom Tromey  <tom@tromey.com>
4600
4601         * rust-exp.y (rustyylex, rust_lex_tests): Update.
4602         * parser-defs.h (struct parser_state) <parser_state>: Add new
4603         parameter.
4604         <comma_terminates>: New member.
4605         (comma_terminates): Don't declare global.
4606         * parse.c (comma_terminates): Remove global.
4607         (parse_exp_in_context): Update.
4608         * p-exp.y (yylex): Update.
4609         * m2-exp.y (yylex): Update.
4610         * go-exp.y (lex_one_token): Update.
4611         * f-exp.y (yylex): Update.
4612         * d-exp.y (lex_one_token): Update.
4613         * c-exp.y (lex_one_token): Update.
4614         * ada-lex.l: Update.
4615
4616 2019-04-04  Tom Tromey  <tom@tromey.com>
4617
4618         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
4619         (rustyylex, rust_lex_test_init, rust_lex_test_one)
4620         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
4621         * parser-defs.h (paren_depth): Don't declare.
4622         * parse.c (paren_depth): Remove global.
4623         (parse_exp_in_context): Update.
4624         * p-exp.y (paren_depth): New global.
4625         (pascal_parse): Initialize it.
4626         * m2-exp.y (paren_depth): New global.
4627         (m2_parse): Initialize it.
4628         * go-exp.y (paren_depth): New global.
4629         (go_parse): Initialize it.
4630         * f-exp.y (paren_depth): New global.
4631         (f_parse): Initialize it.
4632         * d-exp.y (paren_depth): New global.
4633         (d_parse): Initialize it.
4634         * c-exp.y (paren_depth): New global.
4635         (c_parse): Initialize it.
4636         * ada-lex.l (paren_depth): New global.
4637         (lexer_init): Initialize it.
4638
4639 2019-04-04  Tom Tromey  <tom@tromey.com>
4640
4641         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
4642         (rust_parser::convert_ast_to_type)
4643         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4644         * parser-defs.h (struct parser_state) <parser_state>: Add
4645         parameters.  Initialize new members.
4646         <expression_context_block, expression_context_pc>: New members.
4647         * parse.c (expression_context_block, expression_context_pc):
4648         Remove globals.
4649         (parse_exp_in_context): Update.
4650         * p-exp.y: Update all rules.
4651         (yylex): Update.
4652         * m2-exp.y: Update all rules.
4653         (yylex): Update.
4654         * go-exp.y (yylex): Update.
4655         * f-exp.y (yylex): Update.
4656         * d-exp.y: Update all rules.
4657         (yylex): Update.
4658         * c-exp.y: Update all rules.
4659         (lex_one_token, classify_name, yylex, c_parse): Update.
4660         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
4661
4662 2019-04-04  Tom Tromey  <tom@tromey.com>
4663
4664         * gdbarch.h, gdbarch.c: Rebuild.
4665         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
4666         * stap-probe.h:
4667         (struct stap_parse_info): Replace "parser_state" with
4668         "expr_builder".
4669         * parser-defs.h (struct expr_builder): Rename from "parser_state".
4670         (parser_state): New class.
4671         * parse.c (expr_builder): Rename.
4672         (expr_builder::release): Rename.
4673         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
4674         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
4675         (write_exp_elt_longcst, write_exp_elt_floatcst)
4676         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
4677         (write_exp_string_vector, write_exp_bitstring)
4678         (write_exp_msymbol, mark_struct_expression)
4679         (write_dollar_variable)
4680         (insert_type_address_space, increase_expout_size): Replace
4681         "parser_state" with "expr_builder".
4682         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
4683         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
4684         "parser_state" with "expr_builder".
4685
4686 2019-04-04  Tom Tromey  <tom@tromey.com>
4687
4688         * rust-exp.y: Replace "parse_language" with method call.
4689         * p-exp.y:
4690         (yylex): Replace "parse_language" with method call.
4691         * m2-exp.y:
4692         (yylex): Replace "parse_language" with method call.
4693         * go-exp.y (classify_name): Replace "parse_language" with method
4694         call.
4695         * f-exp.y (yylex): Replace "parse_language" with method call.
4696         * d-exp.y (lex_one_token): Replace "parse_language" with method
4697         call.
4698         * c-exp.y:
4699         (lex_one_token, classify_name, yylex): Replace "parse_language"
4700         with method call.
4701         * ada-exp.y (find_primitive_type, type_char)
4702         (type_system_address): Replace "parse_language" with method call.
4703
4704 2019-04-04  Tom Tromey  <tom@tromey.com>
4705
4706         * rust-exp.y: Replace "parse_gdbarch" with method call.
4707         * parse.c (write_dollar_variable, insert_type_address_space):
4708         Replace "parse_gdbarch" with method call.
4709         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
4710         call.
4711         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
4712         call.
4713         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
4714         "parse_gdbarch" with method call.
4715         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
4716         with method call.
4717         * f-exp.y (parse_type, parse_f_type, yylex): Replace
4718         "parse_gdbarch" with method call.
4719         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
4720         "parse_gdbarch" with method call.
4721         * c-exp.y (parse_type, parse_number, classify_name): Replace
4722         "parse_gdbarch" with method call.
4723         * ada-lex.l: Replace "parse_gdbarch" with method call.
4724         * ada-exp.y (parse_type, find_primitive_type, type_char)
4725         (type_system_address): Replace "parse_gdbarch" with method call.
4726
4727 2019-04-04  Tom Tromey  <tom@tromey.com>
4728
4729         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
4730         * stap-probe.c (stap_parse_argument): Update.
4731         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
4732         initial_size parameter.
4733         * rust-exp.y (rust_lex_tests): Update.
4734         * parse.c (parser_state): Update.
4735         (parse_exp_in_context): Update.
4736         * parser-defs.h (struct parser_state) <parser_state>: Remove
4737         "initial_size" parameter.
4738
4739 2019-04-04  Tom Tromey  <tom@tromey.com>
4740
4741         * parser-defs.h (increase_expout_size): Don't declare.
4742         * parse.c (increase_expout_size): Now static.
4743
4744 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
4745
4746         * gnu-nat.c (gnu_nat_target::wait): Fix
4747         target_waitstatus_to_string call.
4748
4749 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4750
4751         * eval.c (evaluate_subexp_standard): Handle internal functions
4752         during Fortran function call handling.
4753
4754 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4755
4756         * NEWS: Mention new internal functions.
4757         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
4758         (read_base_type): Use dwarf2_init_complex_target_type.
4759         * value.c (creal_internal_fn): New function.
4760         (cimag_internal_fn): New function.
4761         (_initialize_values): Register new internal functions.
4762
4763 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4764
4765         * infrun.c (stop_all_threads): If debug_infrun, always
4766         trace the wait status after wait_one, using
4767         target_waitstatus_to_string and target_pid_to_str.
4768         (handle_inferior_event): Replace various trace of
4769         wait status kind by a single trace.
4770         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
4771         wait status kind image by target_waitstatus_to_string.
4772         * target/waitstatus.c (target_waitstatus_to_string): Fix
4773         obsolete comment.
4774
4775 2019-04-01  Tom Tromey  <tromey@adacore.com>
4776
4777         PR symtab/23331:
4778         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
4779
4780 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
4781             Pedro Alves  <palves@redhat.com>
4782
4783         * top.c (quit_force): Call 'finalize_values'.
4784         * value.c (finalize_values): New function.
4785         * value.h (finalize_values): Declare.
4786
4787 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
4788
4789         * NEWS: Announce $_gdb_major and $_gdb_minor.
4790
4791         * top.c (init_gdb_version_vars): New function.
4792         (gdb_init): Call init_gdb_version_vars.
4793
4794 2019-03-29  Tom Tromey  <tromey@adacore.com>
4795
4796         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
4797         help text.  Remove dead code.
4798
4799 2019-03-29  Keith Seitz  <keiths@redhat.com>
4800
4801         From Siddhesh Poyarekar:
4802         * f-lang.h (f77_get_upperbound): Return LONGEST.
4803         (f77_get_lowerbound): Likewise.
4804         * f-typeprint.c (f_type_print_varspec_suffix): Expand
4805         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
4806         print them.
4807         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
4808         plongest to format print it.
4809         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
4810         (f77_get_upperbound): Likewise.
4811         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
4812         LOWER_BOUND to LONGEST.
4813         (f77_create_arrayprint_offset_tbl): Likewise.
4814
4815 2019-03-29  Keith Seitz  <keiths@redhat.com>
4816
4817         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
4818         %s/pulongest for TYPE_LENGTH instead of %d in format
4819         strings.
4820         * ada-typerint.c (ada_print_type): Likewise.
4821         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
4822         * compile/compile-c-support.c (generate_register_struct): Likewise.
4823         * gdbtypes.c (recursive_dump_type): Likewise.
4824         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
4825         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
4826         instead of %d in format strings.
4827         * riscv-tdep.c (riscv_type_alignment): Cast second argument
4828         to std::min to ULONGEST.
4829         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
4830         instead of %d in format strings.
4831         * tracepoint.c (info_scope_command): Likewise.
4832         * typeprint.c (print_offset_data::update)
4833         (print_offset_data::finish): Likewise.
4834         * xtensa-tdep.c (xtensa_store_return_value)
4835         (xtensa_push_dummy_call): Likewise.
4836
4837 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
4838
4839         * windows-nat.c (display_selector): Fixed format specifications
4840         for 64-bit Cygwin.
4841
4842 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4843
4844         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
4845
4846 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
4847
4848         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
4849         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
4850         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
4851         (nios2_linux_init_abi): Install it.
4852
4853 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4854
4855         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
4856
4857 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4858
4859         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
4860
4861 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4862             Tom Tromey  <tromey@adacore.com>
4863
4864         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
4865
4866 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
4867
4868         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
4869         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
4870         method to compute the bounds of range types. Also print "[evaluated]"
4871         if the bounds' values come from a dynamic evaluation.
4872
4873 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4874
4875         * cp-valprint.c (cp_print_value_fields): Don't print trailing
4876         whitespace when pretty printing is on.
4877
4878 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4879
4880         * ppc-linux-nat.c: Add include.
4881
4882 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4883
4884         * NEWS: Mention AArch64 Pointer Authentication.
4885
4886 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4887
4888         * arm-linux-nat.c: Add include.
4889
4890 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
4891
4892         * source-cache.c (source_cache::get_source_lines): Re-read
4893         fullname after calling open_source_file.
4894
4895 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
4896
4897         * NEWS: Mention TLS support for FreeBSD.
4898
4899 2019-03-25  Tom Tromey  <tromey@adacore.com>
4900
4901         * minsyms.c (BUNCH_SIZE): Update comment.
4902         (~minimal_symbol_reader): Remove old comment.
4903         (compact_minimal_symbols): Update comment.
4904         (minimal_symbol_reader::install): Remove old comment.  Update
4905         other comments.
4906
4907 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4908
4909         * s390-linux-nat.c: Add include.
4910
4911 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4912
4913         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4914         Call linux_get_hwcap.
4915         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
4916         Likewise.
4917         (aarch64_linux_get_hwcap): Remove function.
4918         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
4919         declaration.
4920         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
4921         linux_get_hwcap.
4922         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4923         * linux-tdep.c (linux_get_hwcap): Add function.
4924         (linux_get_hwcap2): Likewise.
4925         * linux-tdep.h (linux_get_hwcap): Add declaration.
4926         (linux_get_hwcap2): Likewise.
4927         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
4928         (ppc_linux_get_hwcap2): Likewise.
4929         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
4930         linux_get_hwcap.
4931         (ppc_linux_nat_target::insert_watchpoint): Likewise.
4932         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
4933         (ppc_linux_nat_target::read_description): Likewise.
4934         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
4935         * s390-linux-nat.c: Likewise.
4936         * s390-linux-tdep.c (s390_core_read_description): Likewise.
4937
4938 2019-03-24  Tom Tromey  <tom@tromey.com>
4939
4940         * ada-lang.c (standard_lookup): Simplify initialization.
4941         (ada_lookup_symbol_nonlocal): Simplify return.
4942         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
4943         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
4944         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
4945         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
4946         initialization.
4947         * solib.c (solib_global_lookup): Simplify.
4948         * symtab.c (null_block_symbol): Remove.
4949         (symbol_cache_lookup): Simplify returns.
4950         (lookup_language_this): Simplify returns.
4951         (lookup_symbol_aux): Simplify return.
4952         (lookup_local_symbol): Simplify returns.
4953         (lookup_global_symbol_from_objfile): Simplify return.
4954         (lookup_symbol_in_objfile_symtabs)
4955         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
4956         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
4957         (lookup_static_symbol, lookup_global_symbol): Simplify return.
4958         * cp-namespace.c (cp_lookup_bare_symbol)
4959         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
4960         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
4961         (cp_lookup_nested_symbol): Don't use null_block_symbol.
4962         (cp_lookup_symbol_via_imports): Simplify initialization.
4963         (find_symbol_in_baseclass): Likewise.
4964         * symtab.h (null_block_symbol): Remove.
4965         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
4966         (d_lookup_nested_symbol, d_lookup_symbol_imports)
4967         (d_lookup_symbol_module): Likewise.
4968         (find_symbol_in_baseclass): Simplify initialization.
4969
4970 2019-03-24  Tom Tromey  <tom@tromey.com>
4971
4972         * expression.h: Don't include symtab.h.
4973         (struct block): Forward declare.
4974
4975 2019-03-24  Tom Tromey  <tom@tromey.com>
4976
4977         * c-exp.y (typebase): Remove casts.
4978         * gdbtypes.c (lookup_unsigned_typename, )
4979         (lookup_signed_typename): Remove cast.
4980         * eval.c (parse_to_comma_and_eval): Remove cast.
4981         * parse.c (write_dollar_variable): Remove cast.
4982         * block.h (struct block) <superblock>: Now const.
4983         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
4984         * psymtab.c (psym_map_matching_symbols): Make "block" const.
4985         (map_block): Make "block" const.
4986         * symfile.h (struct quick_symbol_functions)
4987         <map_matching_symbols>: Constify block argument to "callback".
4988         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
4989         const.
4990         (find_pc_sect_compunit_symtab): Make "b" const.
4991         (find_symbol_at_address): Likewise.
4992         (search_symbols): Likewise.
4993         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
4994         (dw2_debug_names_lookup_symbol): Likewise.
4995         (dw2_map_matching_symbols): Update.
4996         * p-valprint.c (pascal_val_print): Remove "block".
4997         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
4998         (aux_add_nonlocal_symbols): Make "block" const.
4999         (resolve_subexp): Remove cast.
5000         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
5001         const.
5002         (iterate_over_file_blocks): Likewise.
5003         * f-exp.y (%union) <bval>: Remove.
5004         * coffread.c (patch_opaque_types): Make "b" const.
5005         * spu-tdep.c (spu_catch_start): Make "block" const.
5006         * c-valprint.c (print_unpacked_pointer): Remove "block".
5007         * symmisc.c (dump_symtab_1): Make "b" const.
5008         (block_depth): Make "block" const.
5009         * d-exp.y (%union) <bval>: Remove.
5010         * cp-support.h (cp_lookup_rtti_type): Update.
5011         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
5012         * psymtab.c (psym_lookup_symbol): Make "block" const.
5013         (maintenance_check_psymtabs): Make "b" const.
5014         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
5015         (enumerate_locals, enumerate_args): Update.
5016         * python/py-symtab.c (stpy_global_block): Make "block" const.
5017         (stpy_static_block): Likewise.
5018         * inline-frame.c (block_starting_point_at): Make "new_block"
5019         const.
5020         * block.c (find_block_in_blockvector): Make return type const.
5021         (blockvector_for_pc_sect): Make "b" const.
5022         (find_block_in_blockvector): Make "b" const.
5023
5024 2019-03-23  Tom Tromey  <tom@tromey.com>
5025
5026         * varobj.c (varobj_create): Update.
5027         * symfile.c (clear_symtab_users): Don't reset innermost_block.
5028         * printcmd.c (display_command, do_one_display): Don't reset
5029         innermost_block.
5030         * parser-defs.h (enum innermost_block_tracker_type): Move to
5031         expression.h.
5032         (innermost_block): Update comment.
5033         * parse.c (parse_exp_1): Add tracker_types parameter.
5034         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
5035         tracker_types parameter.  Reset innermost_block.
5036         (parse_exp_in_context): Remove.
5037         (parse_expression_for_completion): Update.
5038         * objfiles.c (~objfile): Don't reset expression_context_block or
5039         innermost_block.
5040         * expression.h (enum innermost_block_tracker_type): Move from
5041         parser-defs.h.
5042         (parse_exp_1): Add tracker_types parameter.
5043         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
5044         reset innermost_block.
5045
5046 2019-03-23  Tom Tromey  <tom@tromey.com>
5047
5048         * objfiles.h: Include bcache.h.
5049
5050 2019-03-23  Tom Tromey  <tom@tromey.com>
5051
5052         * linespec.c (get_current_search_block): Use
5053         scoped_restore_current_language.
5054         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
5055
5056 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5057             Jiong Wang  <jiong.wang@arm.com>
5058
5059         * aarch64-linux-tdep.c
5060         (aarch64_linux_iterate_over_regset_sections): Check for pauth
5061         section.
5062         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
5063
5064 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5065             Jiong Wang  <jiong.wang@arm.com>
5066
5067         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
5068         instructions.
5069         (aarch64_analyze_prologue_test): Add PACIASP test.
5070         (aarch64_prologue_prev_register): Unmask PC value.
5071
5072 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5073             Jiong Wang  <jiong.wang@arm.com>
5074
5075         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
5076         (aarch64_dwarf2_prev_register): Unmask PC value.
5077         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
5078         (aarch64_execute_dwarf_cfa_vendor_op): Check for
5079         DW_CFA_AARCH64_negate_ra_state.
5080         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
5081
5082 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5083             Jiong Wang  <jiong.wang@arm.com>
5084
5085         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
5086         registers.
5087         (aarch64_pseudo_register_name): Likewise.
5088         (aarch64_pseudo_register_type): Likewise.
5089         (aarch64_pseudo_register_reggroup_p): Likewise.
5090         (aarch64_gdbarch_init): Add pauth registers.
5091         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
5092         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
5093         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
5094         (struct gdbarch_tdep): Add regnum for ra_state.
5095
5096 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5097             Jiong Wang  <jiong.wang@arm.com>
5098
5099         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
5100
5101 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5102             Jiong Wang  <jiong.wang@arm.com>
5103
5104         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
5105         function.
5106         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
5107         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
5108         (aarch64_gdbarch_init): Add puth registers.
5109         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
5110         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
5111         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
5112
5113 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5114             Jiong Wang  <jiong.wang@arm.com>
5115
5116         * aarch64-linux-nat.c
5117         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
5118         * aarch64-linux-tdep.c
5119         (aarch64_linux_core_read_description): Likewise.
5120         (aarch64_linux_get_hwcap): New function.
5121         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
5122         (aarch64_linux_get_hwcap): New declaration.
5123
5124 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5125             Jiong Wang  <jiong.wang@arm.com>
5126
5127         * aarch64-linux-nat.c
5128         (aarch64_linux_nat_target::read_description): Add pauth param.
5129         * aarch64-linux-tdep.c
5130         (aarch64_linux_core_read_description): Likewise.
5131         * aarch64-tdep.c (struct target_desc): Add in pauth.
5132         (aarch64_read_description): Add pauth param.
5133         (aarch64_gdbarch_init): Likewise.
5134         * aarch64-tdep.h (aarch64_read_description): Likewise.
5135         * arch/aarch64.c (aarch64_create_target_description): Likewise.
5136         * arch/aarch64.h (aarch64_create_target_description): Likewise.
5137         * features/Makefile: Add new files.
5138         * features/aarch64-pauth.c: New file.
5139         * features/aarch64-pauth.xml: New file.
5140
5141 2019-03-20  Tom Tromey  <tromey@adacore.com>
5142
5143         * infrun.c (handle_inferior_event): Rename from
5144         handle_inferior_event_1.  Create a scoped_value_mark.
5145         (handle_inferior_event): Remove.
5146
5147 2019-03-19  Tom Tromey  <tromey@adacore.com>
5148
5149         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
5150         * infrun.h (print_stop_event): Add "displays" parameter.
5151         * infrun.c (print_stop_event): Add "displays" parameter.
5152
5153 2019-03-19  Pedro Alves  <palves@redhat.com>
5154
5155         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
5156         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
5157         to -1.  Fix TABs vs spaces.
5158         (tui_ui_out::tui_ui_out): Don't initialize fields here.
5159         * tui/tui-out.h (tui_ui_out) Add intro comments.
5160         <m_line, m_start_of_line>: In-class initialize, and add describing
5161         comment.
5162
5163 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
5164
5165         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
5166         variable names.
5167         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
5168
5169 2019-03-18  Pedro Alves  <palves@redhat.com>
5170             Eli Zaretskii <eliz@gnu.org>
5171
5172         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
5173         m_line and m_start_of_line.
5174
5175 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
5176
5177         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
5178         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
5179         it returns a newline.  This fixes a regression in TU mode, whereby
5180         the next line is output on the same screen line as the user input.
5181
5182 2019-03-18  Tom Tromey  <tromey@adacore.com>
5183
5184         * minsyms.c (minimal_symbol_reader::install): Remove call to
5185         obstack_blank.
5186
5187 2019-03-18  Pedro Alves  <palves@redhat.com>
5188
5189         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
5190         New globals.
5191         (apply_style): New, factored out from ...
5192         (apply_ansi_escape): ... this.  Handle reverse video mode.
5193         (tui_set_reverse_mode): New function.
5194         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
5195         * tui/tui-winsource.c (tui_show_source_line): Use
5196         tui_set_reverse_mode instead of setting A_STANDOUT.
5197         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
5198         New setter methods.
5199
5200 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
5201
5202         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
5203         Handle tabs.
5204
5205 2019-03-18  Tom Tromey  <tromey@adacore.com>
5206
5207         * ada-lang.c (empty_array): Add "high" parameter.
5208         (ada_evaluate_subexp): Update.
5209
5210 2019-03-17  Sergei Trofimovich <siarheit@google.com>
5211
5212         * unittests/string_view-selftests.c: Define
5213         _initialize_string_view_selftests unconditionally.
5214
5215 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5216
5217         PR gdb/24350
5218         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
5219
5220 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5221
5222         PR gdb/24351
5223         * windows-nat.c (display_selector): Fix format specifiers.
5224
5225 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
5226
5227         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
5228         tui_refill_source_window instead of tui_refresh_win, to update the
5229         current execution line.  This fixes redisplay of the current line
5230         when stepping through the code with "next" or "step".
5231
5232 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5233
5234         * source-cache.c (source_cache::get_source_lines): Call
5235         find_source_lines to initialize s->nlines.  This fixes vertical
5236         scrolling of TUI source window when the DOWN arrow is pressed.
5237
5238 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5239
5240         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
5241         linux-thread-db.c (_initialize_thread_db): Likewise.
5242
5243 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5244
5245         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
5246         wclrtoeol in tui_show_source_line".  This reverts changes made in
5247         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
5248
5249 2019-03-15  Tom Tromey  <tom@tromey.com>
5250
5251         * symtab.h (struct minimal_symbol): Derive from
5252         general_symbol_info.
5253         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
5254         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
5255         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
5256         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
5257         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
5258         (MSYMBOL_SEARCH_NAME): Update.
5259         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
5260         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
5261         * minsyms.c (minimal_symbol_reader::record_full): Update.
5262
5263 2019-03-15  Tom Tromey  <tom@tromey.com>
5264
5265         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
5266
5267 2019-03-15  Tom Tromey  <tom@tromey.com>
5268
5269         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
5270         unique_xmalloc_ptr.
5271         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
5272         Update.
5273         * minsyms.c (lookup_minimal_symbol_by_pc_section)
5274         (build_minimal_symbol_hash_tables)
5275         (minimal_symbol_reader::install): Update.
5276
5277 2019-03-15  Tom Tromey  <tom@tromey.com>
5278
5279         * symtab.c (create_demangled_names_hash): Update.
5280         (symbol_set_names): Update.
5281         * objfiles.h (struct objfile_per_bfd_storage)
5282         <demangled_names_hash>: Now an htab_up.
5283         * objfiles.c (objfile_per_bfd_storage): Simplify.
5284
5285 2019-03-15  Tom Tromey  <tom@tromey.com>
5286
5287         * objfiles.h (struct objfile_per_bfd_storage): Declare
5288         destructor.
5289         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
5290         New.
5291         (get_objfile_bfd_data): Use new.  Don't initialize
5292         language_of_main.
5293         (free_objfile_per_bfd_storage): Remove.
5294         (objfile_bfd_data_free, objfile::~objfile): Use delete.
5295
5296 2019-03-15  Tom Tromey  <tom@tromey.com>
5297
5298         * symfile.c (reread_symbols): Update.
5299         * objfiles.c (objfile::objfile): Update.
5300         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
5301         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
5302         comment.
5303         (minimal_symbol_reader::install): Update.
5304         (terminate_minimal_symbol_table): Remove.
5305         * jit.c (jit_object_close_impl): Update.
5306
5307 2019-03-15  Tom Tromey  <tom@tromey.com>
5308
5309         * minsyms.c (minimal_symbol_reader::record_full): Remove some
5310         initializations.
5311
5312 2019-03-15  Tom Tromey  <tom@tromey.com>
5313
5314         * objfiles.h (struct objfile_per_bfd_storage)
5315         <demangled_hash_languages>: Now a bitset.
5316         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
5317         (lookup_minimal_symbol): Update.
5318
5319 2019-03-15  Tom Tromey  <tom@tromey.com>
5320
5321         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
5322         Don't return the symbol.
5323         * coffread.c (record_minimal_symbol): Use record_full.
5324
5325 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
5326
5327         The MS-Windows port of ncurses fails to switch to a color pair if
5328         one or both of the colors are the implicit default colors.  This
5329         change records the default colors when TUI is initialized, and
5330         then specifies them explicitly when a color pair uses the default
5331         colors.  This allows color styling in TUI mode on MS-Windows.
5332
5333         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
5334         ncurses_norm_attr.
5335         (tui_initialize_io) [__MINGW32__]: Record the default terminal
5336         colors in ncurses_norm_attr.
5337         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
5338         "none", replace it with the default color recorded in
5339         ncurses_norm_attr.
5340
5341 2019-03-14  Tom Tromey  <tromey@adacore.com>
5342
5343         * source-cache.h (class source_cache) <get_source_lines>: Return
5344         std::string.
5345         * source-cache.c (source_cache::extract_lines): Handle case where
5346         first_pos==npos.  Return std::string.
5347         (source_cache::get_source_lines): Update.
5348
5349 2019-03-14  Tom Tromey  <tromey@adacore.com>
5350
5351         * NEWS: Add item for "style sources" commands.
5352         * source-cache.c (source_cache::get_source_lines): Check
5353         source_styling.
5354         * cli/cli-style.c (source_styling): New global.
5355         (_initialize_cli_style): Add "style sources" commands.
5356         (show_style_sources): New function.
5357         * cli/cli-style.h (source_styling): Declare.
5358
5359 2019-03-14  Pedro Alves  <palves@redhat.com>
5360             Tom Tromey  <tromey@adacore.com>
5361
5362         * tui/tui-winsource.h (tui_refill_source_window): Declare.
5363         * tui/tui-winsource.c (tui_refill_source_window): New function,
5364         from...
5365         (tui_horizontal_source_scroll): ... here.  Move some logic.
5366         * cli/cli-style.c (set_style_enabled): Notify new observable.
5367         * tui/tui-hooks.c (tui_redisplay_source): New function.
5368         (tui_attach_detach_observers): Attach or detach
5369         tui_redisplay_source.
5370         * observable.h (source_styling_changed): New observable.
5371         * observable.c: Define source_styling_changed observable.
5372
5373 2019-03-13  Tom Tromey  <tromey@adacore.com>
5374
5375         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
5376         (i386_gnu_nat_target::store_registers): Update.
5377         * target-debug.h (target_debug_print_std_string): New macro.
5378         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5379         * windows-tdep.c (display_one_tib): Update.
5380         * tui/tui-stack.c (tui_make_status_line): Update.
5381         * top.c (print_inferior_quit_action): Update.
5382         * thread.c (thr_try_catch_cmd): Update.
5383         (add_thread_with_info): Update.
5384         (thread_target_id_str): Update.
5385         (thr_try_catch_cmd): Update.
5386         (thread_command): Update.
5387         (thread_find_command): Update.
5388         * record-btrace.c (record_btrace_target::info_record)
5389         (record_btrace_resume_thread, record_btrace_target::resume)
5390         (record_btrace_cancel_resume, record_btrace_step_thread)
5391         (record_btrace_target::wait, record_btrace_target::wait)
5392         (record_btrace_target::wait, record_btrace_target::stop): Update.
5393         * progspace.c (print_program_space): Update.
5394         * process-stratum-target.c
5395         (process_stratum_target::thread_address_space): Update.
5396         * linux-fork.c (linux_fork_mourn_inferior)
5397         (detach_checkpoint_command, info_checkpoints_command)
5398         (linux_fork_context): Update.
5399         (linux_fork_detach): Update.
5400         (class scoped_switch_fork_info): Update.
5401         (delete_checkpoint_command): Update.
5402         * infrun.c (follow_fork_inferior): Update.
5403         (follow_fork_inferior): Update.
5404         (proceed_after_vfork_done): Update.
5405         (handle_vfork_child_exec_or_exit): Update.
5406         (follow_exec): Update.
5407         (displaced_step_prepare_throw): Update.
5408         (displaced_step_restore): Update.
5409         (start_step_over): Update.
5410         (resume_1): Update.
5411         (clear_proceed_status_thread): Update.
5412         (proceed): Update.
5413         (print_target_wait_results): Update.
5414         (do_target_wait): Update.
5415         (context_switch): Update.
5416         (stop_all_threads): Update.
5417         (restart_threads): Update.
5418         (finish_step_over): Update.
5419         (handle_signal_stop): Update.
5420         (switch_back_to_stepped_thread): Update.
5421         (keep_going_pass_signal): Update.
5422         (print_exited_reason): Update.
5423         (normal_stop): Update.
5424         * inferior.c (inferior_pid_to_str): Change return type.
5425         (print_selected_inferior): Update.
5426         (add_inferior): Update.
5427         (detach_inferior): Update.
5428         * dummy-frame.c (fprint_dummy_frames): Update.
5429         * dcache.c (dcache_info_1): Update.
5430         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
5431         (btrace_fetch, btrace_clear): Update.
5432         * linux-tdep.c (linux_core_pid_to_str): Change return type.
5433         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
5434         type.
5435         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
5436         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
5437         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
5438         * gdbarch.c, gdbarch.h: Rebuild.
5439         * gdbarch.sh (core_pid_to_str): Change return type.
5440         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
5441         return type.
5442         (windows_nat_target::pid_to_str): Change return type.
5443         (windows_delete_thread): Update.
5444         (windows_nat_target::attach): Update.
5445         (windows_nat_target::files_info): Update.
5446         * target-delegates.c: Rebuild.
5447         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
5448         return type.
5449         (sol_thread_target::pid_to_str): Change return type.
5450         * remote.c (class remote_target) <pid_to_str>: Change return
5451         type.
5452         (remote_target::pid_to_str): Change return type.
5453         (extended_remote_target::attach, remote_target::remote_stop_ns)
5454         (remote_target::remote_notif_remove_queued_reply)
5455         (remote_target::push_stop_reply, remote_target::disable_btrace):
5456         Update.
5457         (extended_remote_target::attach): Update.
5458         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
5459         type.
5460         (gdbsim_target::pid_to_str): Change return type.
5461         * ravenscar-thread.c (struct ravenscar_thread_target)
5462         <pid_to_str>: Change return type.
5463         (ravenscar_thread_target::pid_to_str): Change return type.
5464         * procfs.c (class procfs_target) <pid_to_str>: Change return
5465         type.
5466         (procfs_target::pid_to_str): Change return type.
5467         (procfs_target::attach): Update.
5468         (procfs_target::detach): Update.
5469         (procfs_target::fetch_registers): Update.
5470         (procfs_target::store_registers): Update.
5471         (procfs_target::wait): Update.
5472         (procfs_target::files_info): Update.
5473         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
5474         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
5475         return type.
5476         (nto_procfs_target::pid_to_str): Change return type.
5477         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
5478         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
5479         return type.
5480         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
5481         (exit_lwp): Update.
5482         (attach_proc_task_lwp_callback, get_detach_signal)
5483         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
5484         (linux_nat_target::resume, wait_lwp, stop_callback)
5485         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
5486         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
5487         (linux_nat_wait_1, resume_stopped_resumed_lwps)
5488         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
5489         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
5490         type.
5491         (inf_ptrace_target::attach): Update.
5492         (inf_ptrace_target::files_info): Update.
5493         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
5494         type.
5495         (go32_nat_target::pid_to_str): Change return type.
5496         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
5497         (gnu_nat_target::wait): Update.
5498         (gnu_nat_target::wait): Update.
5499         (gnu_nat_target::resume): Update.
5500         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
5501         (fbsd_nat_target::wait): Update.
5502         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
5503         type.
5504         (darwin_nat_target::attach): Update.
5505         * corelow.c (class core_target) <pid_to_str>: Change return type.
5506         (core_target::pid_to_str): Change return type.
5507         * target.c (normal_pid_to_str): Change return type.
5508         (default_pid_to_str): Likewise.
5509         (target_pid_to_str): Change return type.
5510         (target_translate_tls_address): Update.
5511         (target_announce_detach): Update.
5512         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
5513         return type.
5514         (bsd_uthread_target::pid_to_str): Change return type.
5515         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
5516         type.
5517         (bsd_kvm_target::pid_to_str): Change return type.
5518         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
5519         return type.
5520         (aix_thread_target::pid_to_str): Change return type.
5521         * target.h (struct target_ops) <pid_to_str>: Change return type.
5522         (target_pid_to_str, normal_pid_to_str): Likewise.
5523         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
5524         type.
5525         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
5526         type.
5527         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
5528         return type.
5529         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
5530         type.
5531         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
5532         type.
5533         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
5534         return type.
5535
5536 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
5537
5538         * NEWS: Mention that the new default MI version is 3.  Mention
5539         changes to the output of commands and events that deal with
5540         multi-location breakpoints.
5541         * breakpoint.c: Include "mi/mi-out.h".
5542         (print_one_breakpoint): Change output syntax if using MI version
5543         >= 3.
5544         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
5545         New.
5546         (mi_multi_location_breakpoint_output_fixed): New.
5547         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
5548         (mi_cmd_fix_multi_location_breakpoint_output): New.
5549         (mi_multi_location_breakpoint_output_fixed): New.
5550         * mi/mi-cmds.c (mi_cmds): Register command
5551         -fix-multi-location-breakpoint-output.
5552         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
5553         interpreter "mi".
5554
5555 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
5556
5557         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
5558         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
5559         instantiate mi_ui_out based on interpreter name.
5560         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
5561         * mi/mi-main.c (mi_load_progress): Likewise.
5562
5563 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5564
5565         * NEWS: Combine separate "New targets" sections for 8.3.
5566
5567 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5568
5569         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
5570         (ppcfbsd_init_abi): Install gdbarch
5571         "fetch_tls_load_module_address" and "get_thread_local_address"
5572         methods.
5573
5574 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5575
5576         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
5577         (riscv_fbsd_init_abi): Install gdbarch
5578         "fetch_tls_load_module_address" and "get_thread_local_address"
5579         methods.
5580
5581 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5582
5583         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
5584         (i386fbsd_init_abi): Install gdbarch
5585         "fetch_tls_load_module_address" and "get_thread_local_address"
5586         methods.
5587
5588 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5589
5590         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
5591         (amd64fbsd_init_abi): Install gdbarch
5592         "fetch_tls_load_module_address" and "get_thread_local_address"
5593         methods.
5594
5595 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5596
5597         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
5598         (struct fbsd_pspace_data): New type.
5599         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
5600         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
5601         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
5602         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
5603         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
5604
5605 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5606
5607         * gdbtypes.c (lookup_struct_elt): New function.
5608         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
5609         * gdbtypes.h (struct struct_elt): New type.
5610         (lookup_struct_elt): New prototype.
5611
5612 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5613
5614         * gdbtypes.c (lookup_struct_elt_type): Update comment and
5615         remove disabled code block.
5616
5617 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5618
5619         * gdbarch.sh (get_thread_local_address): New method.
5620         * gdbarch.h, gdbarch.c: Regenerate.
5621         * target.c (target_translate_tls_address): Use
5622         gdbarch_get_thread_local_address if present instead of
5623         target::get_thread_local_address.
5624
5625 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5626
5627         * target.h (target::get_thread_local_address): Update comment.
5628
5629 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5630
5631         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
5632         objfile->separate_debug_objfile_backlink if not NULL.
5633
5634 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5635
5636         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
5637         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
5638         (amd64bsd_store_inferior_registers): Likewise.
5639         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5640         Enable segment base registers.
5641         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
5642         PT_GETFSBASE and PT_GETGSBASE.
5643         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
5644         PT_SETGSBASE.
5645         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
5646         segment base registers.
5647         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5648
5649 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5650
5651         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5652         Update calls to i386_target_description to add 'segments'
5653         parameter.
5654         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
5655         add segment base registers.
5656         * arch/i386.c (i386_create_target_description): Add 'segments'
5657         parameter to enable segment base registers.
5658         * arch/i386.h (i386_create_target_description): Likewise.
5659         * features/i386/32bit-segments.xml: New file.
5660         * features/i386/32bit-segments.c: Generate.
5661         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
5662         call to i386_target_description to add 'segments' parameter.
5663         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5664         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
5665         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
5666         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
5667         if feature is present.
5668         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
5669         Add 'segments' parameter to call to i386_target_description.
5670         (i386_target_description): Add 'segments' parameter to enable
5671         segment base registers.
5672         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
5673         to call to i386_target_description.
5674         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
5675         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
5676         Define I386_NUM_REGS.
5677         (i386_target_description): Add 'segments' parameter to enable
5678         segment base registers.
5679
5680 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
5681
5682         PR/24325
5683         * source-cache.c: #undef open and close, to avoid unresolved
5684         externals during linking.
5685
5686 2019-03-12  Tom Tromey  <tromey@adacore.com>
5687
5688         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
5689         const.  Add initializers.
5690         (_initialize_remote): Don't initialize ptid globals.
5691
5692 2019-03-12  Pedro Alves  <palves@redhat.com>
5693
5694         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
5695
5696 2019-03-12  Pedro Alves  <palves@redhat.com>
5697
5698         * cp-name-parser.y (main): Remove unused 'len' variable.
5699
5700 2019-03-12  Tom Tromey  <tromey@adacore.com>
5701
5702         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
5703         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
5704
5705 2019-03-12  Tom Tromey  <tromey@adacore.com>
5706
5707         * linux-nat.c (iterate_over_lwps): Update.
5708         (stop_callback): Remove parameter.
5709         (stop_wait_callback, detach_callback, resume_set_callback)
5710         (select_singlestep_lwp_callback, set_ignore_sigint)
5711         (status_callback, resumed_callback, resume_clear_callback)
5712         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
5713         data parameter.
5714         (linux_nat_target::detach, linux_nat_target::resume)
5715         (linux_stop_and_wait_all_lwps, select_event_lwp)
5716         (linux_nat_filter_event, linux_nat_wait_1)
5717         (linux_nat_target::kill, linux_nat_target::stop)
5718         (linux_nat_target::stop): Update.
5719         (linux_nat_resume_callback): Change type.
5720         (resume_stopped_resumed_lwps, count_events_callback)
5721         (select_event_lwp_callback): Likewise.
5722         (linux_stop_lwp, linux_nat_stop_lwp): Update.
5723         * arm-linux-nat.c (struct update_registers_data): Remove.
5724         (update_registers_callback): Change type.
5725         (arm_linux_insert_hw_breakpoint1): Update.
5726         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
5727         parameter.
5728         (x86_linux_dr_set_addr): Update.
5729         (x86_linux_dr_set_control): Update.
5730         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
5731         (iterate_over_lwps): Use gdb::function_view.
5732         * nat/aarch64-linux-hw-point.c (struct
5733         aarch64_dr_update_callback_param): Remove.
5734         (debug_reg_change_callback): Change type.
5735         (aarch64_notify_debug_reg_change): Update.
5736         * s390-linux-nat.c (s390_refresh_per_info): Update.
5737
5738 2019-03-11  Tom Tromey  <tromey@adacore.com>
5739
5740         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
5741         redundant assignment to "this_cu".
5742
5743 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5744
5745         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
5746
5747 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5748
5749         * gdbtypes.c (rank_one_type_parm_set): New function extracted
5750         from...
5751         (rank_one_type): ... this.
5752
5753 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5754
5755         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
5756         from...
5757         (rank_one_type): ... this.
5758
5759 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5760
5761         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
5762         from...
5763         (rank_one_type): ... this.
5764
5765 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5766
5767         * gdbtypes.c (rank_one_type_parm_float): New function extracted
5768         from...
5769         (rank_one_type): ... this.
5770
5771 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5772
5773         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
5774         from...
5775         (rank_one_type): ... this.
5776
5777 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5778
5779         * gdbtypes.c (rank_one_type_parm_range): New function extracted
5780         from...
5781         (rank_one_type): ... this.
5782
5783 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5784
5785         * gdbtypes.c (rank_one_type_parm_char): New function extracted
5786         from...
5787         (rank_one_type): ... this.
5788
5789 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5790
5791         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
5792         from...
5793         (rank_one_type): ... this.
5794
5795 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5796
5797         * gdbtypes.c (rank_one_type_parm_int): New function extracted
5798         from...
5799         (rank_one_type): ... this.
5800
5801 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5802
5803         * gdbtypes.c (rank_one_type_parm_func): New function extracted
5804         from...
5805         (rank_one_type): ... this.
5806
5807 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5808
5809         * gdbtypes.c (rank_one_type_parm_array): New function extracted
5810         from...
5811         (rank_one_type): ... this.
5812
5813 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5814
5815         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
5816         from...
5817         (rank_one_type): ... this.
5818
5819 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5820
5821         * inferior.c (initialize_inferiors): Ensure 'help set/show print
5822         inferior-events' shows the example events.
5823
5824 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
5825
5826         Support styling on native MS-Windows console
5827
5828         PR/24315
5829         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
5830         on MS-Windows if $TERM is not defined.
5831
5832         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
5833
5834         * posix-hdep.c (gdb_console_fputs):
5835         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
5836         functions.
5837         * ui-file.h (gdb_console_fputs): Add prototype.
5838
5839         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
5840         back to fputs only if the former returns zero.
5841
5842 2019-03-07  Tom Tromey  <tom@tromey.com>
5843
5844         * symmisc.c (print_symbol_bcache_statistics): Update.
5845         (print_objfile_statistics): Update.
5846         * symfile.c (allocate_symtab): Update.
5847         * stabsread.c: Don't include bcache.h.
5848         * psymtab.h (struct psymbol_bcache): Don't declare.
5849         (class psymtab_storage) <psymbol_cache>: Now a bcache.
5850         (psymbol_bcache_init, psymbol_bcache_free)
5851         (psymbol_bcache_get_bcache): Don't declare.
5852         * psymtab.c (struct psymbol_bcache): Remove.
5853         (psymtab_storage::psymtab_storage): Update.
5854         (psymtab_storage::~psymtab_storage): Update.
5855         (psymbol_bcache_init, psymbol_bcache_free)
5856         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
5857         (add_psymbol_to_bcache): Update.
5858         (allocate_psymtab): Update.
5859         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
5860         macro_cache>: No longer pointers.
5861         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
5862         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
5863         * macrotab.c (macro_bcache): Update.
5864         * macroexp.c: Don't include bcache.h.
5865         * gdbtypes.c (check_types_worklist): Update.
5866         (types_deeply_equal): Remove TRY/CATCH.  Update.
5867         * elfread.c (elf_symtab_read): Update.
5868         * dwarf2read.c: Don't include bcache.h.
5869         * buildsym.c (buildsym_compunit::get_macro_table): Update.
5870         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
5871         (print_bcache_statistics, bcache_memory_used): Don't declare.
5872         (struct bcache): Move from bcache.c.  Add constructor, destructor,
5873         methods.  Rename all data members.
5874         * bcache.c (struct bcache): Move to bcache.h.
5875         (bcache::expand_hash_table): Rename from expand_hash_table.
5876         (bcache): Remove.
5877         (bcache::insert): Rename from bcache_full.
5878         (bcache::compare): Rename from bcache_compare.
5879         (bcache_xmalloc): Remove.
5880         (bcache::~bcache): Rename from bcache_xfree.
5881         (bcache::print_statistics): Rename from print_bcache_statistics.
5882         (bcache::memory_used): Rename from bcache_memory_used.
5883
5884 2019-03-07  Pedro Alves  <palves@redhat.com>
5885
5886         * infrun.c (normal_stop): Also check for
5887         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
5888
5889 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
5890
5891         * f-lang.c (value_from_host_double): Moved to...
5892         * value.c (value_from_host_double): ...here.
5893         * value.h (value_from_host_double): Declare.
5894         * guile/scm-math.c (vlscm_convert_typed_number): Use
5895         value_from_host_double.
5896         (vlscm_convert_number): Likewise.
5897         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
5898         * python/py-value.c (convert_value_from_python): Likewise.
5899
5900 2019-03-06  Tom Tromey  <tom@tromey.com>
5901
5902         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
5903
5904 2019-03-06  Tom Tromey  <tom@tromey.com>
5905
5906         * utils.h (free_current_contents): Don't declare.
5907         * utils.c (free_current_contents): Remove.
5908
5909 2019-03-06  Tom Tromey  <tom@tromey.com>
5910
5911         * top.c (quit_force): Update.
5912         * main.c (captured_command_loop): Update.
5913         * common/new-op.c (operator new): Update.
5914         * common/common-exceptions.c (struct catcher)
5915         <save_cleanup_chain>: Remove member.
5916         (exceptions_state_mc_init): Update.
5917         (exception_try_scope_entry): Return nullptr.
5918         (exception_try_scope_exit, exception_rethrow)
5919         (throw_exception_sjlj, throw_exception_cxx): Update.
5920         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
5921         (all_cleanups, do_cleanups, discard_cleanups)
5922         (discard_final_cleanups, save_cleanups, save_final_cleanups)
5923         (restore_cleanups, restore_final_cleanups): Don't declare.
5924         (do_final_cleanups): Remove parameter.
5925         * common/cleanups.c (cleanup_chain, make_cleanup)
5926         (make_cleanup_dtor, all_cleanups, do_cleanups)
5927         (discard_my_cleanups, discard_cleanups)
5928         (discard_final_cleanups, save_my_cleanups, save_cleanups)
5929         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
5930         (null_cleanup): Remove.
5931         (do_final_cleanups): Remove parameter.
5932
5933 2019-03-06  Tom Tromey  <tom@tromey.com>
5934
5935         * remote.c (remote_target::remote_parse_stop_reply): Use
5936         unique_xmalloc_ptr.
5937
5938 2019-03-06  Tom Tromey  <tom@tromey.com>
5939
5940         * stabsread.c (struct stabs_field_info): Rename from field_info.
5941         <list, fnlist>: Add initializers.
5942         <obstack>: New member.
5943         (read_member_functions, read_struct_fields, read_baseclasses):
5944         Allocate on obstack.  Don't use cleanups.
5945         (read_one_struct_field, read_member_functions, read_struct_fields)
5946         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
5947         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
5948         (read_struct_type): Update.
5949
5950 2019-03-06  Tom Tromey  <tom@tromey.com>
5951
5952         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
5953         * common/filestuff.h (make_cleanup_close): Don't declare.
5954         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
5955         Remove.
5956
5957 2019-03-06  Tom Tromey  <tom@tromey.com>
5958
5959         * solib-aix.c: Use make_scope_exit.
5960
5961 2019-03-06  Tom Tromey  <tom@tromey.com>
5962
5963         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
5964         Use make_scope_exit.
5965
5966 2019-03-06  Tom Tromey  <tom@tromey.com>
5967
5968         * solib-svr4.c (disable_probes_interface): Remove parameter.
5969         (svr4_handle_solib_event): Use make_scope_exit.
5970
5971 2019-03-06  Tom Tromey  <tom@tromey.com>
5972
5973         * remote.c (struct stop_reply_deleter): Remove.
5974         (stop_reply_up): Update.
5975         (struct stop_reply): Derive from notif_event.  Don't typedef.
5976         <regcache>: Now a std::vector.
5977         (stop_reply_xfree): Remove.
5978         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
5979         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
5980         (remote_target::discard_pending_stop_replies): Use delete.
5981         (remote_target::remote_parse_stop_reply): Update.
5982         (remote_target::process_stop_reply): Update.
5983         * remote-notif.h (struct notif_event): Add virtual destructor.
5984         Remove "dtr" member.
5985         (struct notif_client) <alloc_event>: Return a unique_ptr.
5986         (notif_event_xfree): Don't declare.
5987         (notif_event_up): New typedef.
5988         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
5989         (notif_event_xfree, do_notif_event_xfree): Remove.
5990         (remote_notif_state_xfree): Update.
5991
5992 2019-03-06  Tom Tromey  <tom@tromey.com>
5993
5994         * infrun.c (displaced_step_clear_cleanup): Now a
5995         forward_scope_exit type.
5996         (displaced_step_prepare_throw): Update.
5997         (displaced_step_fixup): Update.
5998
5999 2019-03-06  Tom Tromey  <tom@tromey.com>
6000
6001         * inferior.h (class inferior): Update comment.
6002         * gdbthread.h (class thread_info): Update comment.
6003
6004 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
6005             Tom Tromey  <tom@tromey.com>
6006
6007         * stabsread.h (struct stab_section_list): Remove.
6008         (coffstab_build_psymtabs): Update.
6009         * dbxread.c (symbuf_sections): Now a std::vector.
6010         (sect_idx): New global.
6011         (fill_symbuf): Update.
6012         (coffstab_build_psymtabs): Change type of stabsects parameter.
6013         Update.
6014         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
6015         std::vector.
6016         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
6017         (coff_locate_sections): Update.
6018         (coff_symfile_read): Remove cleanups.  Update.
6019         (init_stringtab): Add storage parameter.
6020         (free_stringtab, free_stringtab_cleanup): Remove.
6021         (init_lineno): Add storage parameter.
6022         (free_linetab, free_linetab_cleanup): Remove.
6023
6024 2019-03-06  Pedro Alves  <palves@redhat.com>
6025
6026         * linux-fork.c (fork_info::clobber_regs): Delete.
6027         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
6028         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
6029         comment.  Adjust.
6030         (scoped_switch_fork_info::scoped_switch_fork_info)
6031         (checkpoint_command, linux_fork_context): Adjust
6032         fork_save_infrun_state calls.
6033
6034 2019-03-06  Pedro Alves  <palves@redhat.com>
6035
6036         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
6037         (inf_has_multiple_threads): Return 'bool' and rewrite using
6038         inferior_info::threads().
6039
6040 2019-03-06  Pedro Alves  <palves@redhat.com>
6041
6042         * linux-fork.c: Include <list>.
6043         (fork_list): Now a std::list instance.
6044         (fork_info): Add ctor, dtor, and in-class initialize all fields.
6045         (forks_exist_p, find_last_fork): Adjust.
6046         (new_fork): Delete.
6047         (one_fork_p): New.
6048         (add_fork): Adjust.
6049         (free_fork): Delete, folded into fork_info::~fork_info().
6050         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
6051         Adjust.
6052         (init_fork_list): Delete.
6053         (linux_fork_killall, linux_fork_mourn_inferior)
6054         (linux_fork_detach, info_checkpoints_command): Adjust.
6055         (_initialize_linux_fork): No longer call init_fork_list.
6056
6057 2019-03-06  Pedro Alves  <palves@redhat.com>
6058
6059         * linux-fork.c (new_fork): New, split out of ...
6060         (add_fork): ... this.  Return void.  Move "first fork" special
6061         case from here, to ...
6062         (checkpoint_command): ... here.
6063         * linux-linux.h (add_fork): Return void.
6064
6065 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6066
6067         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
6068
6069 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6070             Chris January  <chris.january@arm.com>
6071             David Lecomber  <david.lecomber@arm.com>
6072
6073         * f-exp.y: New token, UNOP_INTRINSIC.
6074         (exp): New pattern using UNOP_INTRINSIC token.
6075         (f77_keywords): Add 'abs' keyword.
6076         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
6077         (value_from_host_double): New function.
6078         (evaluate_subexp_f): Support UNOP_ABS.
6079
6080 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6081
6082         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
6083         types.
6084
6085 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6086
6087         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
6088         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
6089         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
6090
6091 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6092
6093         * f-exp.y (convert_to_kind_type): Handle more type kinds.
6094
6095 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6096             Chris January  <chris.january@arm.com>
6097
6098         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
6099         * f-exp.y: Define 'KIND' token.
6100         (exp): New pattern for KIND expressions.
6101         (ptype): Handle types with a kind extension.
6102         (direct_abs_decl): Extend to spot kind extensions.
6103         (f77_keywords): Add 'kind' to the list.
6104         (push_kind_type): New function.
6105         (convert_to_kind_type): New function.
6106         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
6107         * parse.c (operator_length_standard): Likewise.
6108         * parser-defs.h (enum type_pieces): Add tp_kind.
6109         * std-operator.def: Add UNOP_KIND.
6110
6111 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6112
6113         * f-exp.y (f_parse): Set yydebug.
6114
6115 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6116
6117         * f-lang.c (evaluate_subexp_f): New function.
6118         (exp_descriptor_f): New global.
6119         (f_language_defn): Use exp_descriptor_f instead of
6120         exp_descriptor_standard.
6121
6122 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6123
6124         * f-exp.y (struct token): Add comments.
6125         (dot_ops): Remove uppercase versions and the end marker.
6126         (f77_keywords): Likewise.
6127         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
6128         entries in the dot_ops array are case insensitive, and use
6129         strncasecmp to compare strings.  Also some whitespace cleanup in
6130         this area.  Similar for the f77_keywords array, except entries in
6131         this list might be case sensitive.
6132
6133 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6134
6135         * f-exp.y (struct f77_boolean_val): Add comments.
6136         (boolean_values): Remove uppercase versions, and end marker.
6137         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
6138         and use strncasecmp to achieve case insensitivity.  Additionally,
6139         perform whitespace cleanup around this code.
6140
6141 2019-03-06  Tom Tromey  <tromey@adacore.com>
6142
6143         * remote-sim.c (gdbsim_target_open): Use result of
6144         gdb_argv::release.
6145
6146 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
6147         Dirk Schubert  <dirk.schubert@arm.com>
6148         Chris January  <chris.january@arm.com>
6149
6150         * eval.c (evaluate_subexp_standard): Call Fortran argument
6151         wrapping logic.
6152         * f-lang.c (struct value): A value which can be passed into a
6153         Fortran function call.
6154         (fortran_argument_convert): Wrap Fortran arguments in a pointer
6155         where appropriate.
6156         (struct type): Value ready for a Fortran function call.
6157         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
6158         is needed.
6159         * f-lang.h (fortran_argument_convert): Declaration.
6160         (fortran_preserve_arg_pointer): Declaration.
6161         * infcall.c (value_arg_coerce): Call Fortran argument logic.
6162
6163 2019-03-05  Tom Tromey  <tromey@adacore.com>
6164
6165         * python/py-prettyprint.c (print_string_repr): Remove #if.
6166         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
6167
6168 2019-03-05  Tom Tromey  <tromey@adacore.com>
6169
6170         * target.c (the_dummy_target): Move later.  Change type to
6171         "dummy_target".
6172         (initialize_targets): Don't initialize the_dummy_target.
6173
6174 2019-03-05  Tom Tromey  <tromey@adacore.com>
6175
6176         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
6177         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
6178
6179 2019-03-05  Tom Tromey  <tromey@adacore.com>
6180
6181         * windows-nat.c (windows_nat_target::attach)
6182         (windows_nat_target::detach): Don't call gdb_flush.
6183         * valprint.c (generic_val_print, val_print, val_print_string):
6184         Don't call gdb_flush.
6185         * utils.c (defaulted_query): Don't call gdb_flush.
6186         * typeprint.c (print_type_scalar): Don't call gdb_flush.
6187         * target.c (target_announce_detach): Don't call gdb_flush.
6188         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
6189         * remote.c (extended_remote_target::attach): Don't call
6190         gdb_flush.
6191         * procfs.c (procfs_target::detach): Don't call gdb_flush.
6192         * printcmd.c (do_examine): Don't call gdb_flush.
6193         (info_display_command): Don't call gdb_flush.
6194         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
6195         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
6196         * memattr.c (info_mem_command): Don't call gdb_flush.
6197         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
6198         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
6199         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
6200         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
6201         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
6202         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
6203         (gnu_nat_target::detach): Don't call gdb_flush.
6204         * f-valprint.c (f_val_print): Don't call gdb_flush.
6205         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
6206         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
6207         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
6208         gdb_flush.
6209         * c-valprint.c (c_val_print): Don't call gdb_flush.
6210         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
6211
6212 2019-03-05  Tom Tromey  <tromey@adacore.com>
6213
6214         * varobj.c (update_dynamic_varobj_children): Update.
6215         (install_default_visualizer): Use reset, not release.
6216         * value.c (set_internalvar): Update.
6217         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
6218         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
6219         ATTRIBUTE_UNUSED_RESULT.
6220
6221 2019-03-05  Tom Tromey  <tromey@adacore.com>
6222
6223         * remote.c (class scoped_remote_fd) <release>: Add
6224         ATTRIBUTE_UNUSED_RESULT.
6225
6226 2019-03-05  Tom Tromey  <tromey@adacore.com>
6227
6228         * macroexp.c (struct macro_buffer) <release>: Add
6229         ATTRIBUTE_UNUSED_RESULT.
6230
6231 2019-03-05  Tom Tromey  <tromey@adacore.com>
6232
6233         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
6234         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
6235         ATTRIBUTE_UNUSED_RESULT.
6236
6237 2019-03-05  Tom Tromey  <tromey@adacore.com>
6238
6239         * common/scoped_fd.h (class scoped_fd) <release>: Add
6240         ATTRIBUTE_UNUSED_RESULT.
6241
6242 2019-03-05  Tom Tromey  <tromey@adacore.com>
6243
6244         * parser-defs.h (struct parser_state) <release>: Add
6245         ATTRIBUTE_UNUSED_RESULT.
6246
6247 2019-03-05  Tom Tromey  <tromey@adacore.com>
6248
6249         * utils.h (class gdb_argv) <release>: Add
6250         ATTRIBUTE_UNUSED_RESULT.
6251         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
6252
6253 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
6254
6255         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
6256         for-loop range, to avoid compiler warnings.
6257
6258         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
6259         avoid compiler warnings about unused variables.
6260
6261         * NEWS: Mention end of support for native debugging on MS-Windows
6262         before XP.
6263
6264         PR gdb/24292
6265         * common/netstuff.c:
6266         * gdbserver/gdbreplay.c
6267         * gdbserver/remote-utils.c:
6268         * ser-tcp.c:
6269         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
6270         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
6271         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
6272         'getaddrinfo' and 'freeaddrinfo' were not available before
6273         Windows XP, and mingw.org's MinGW headers by default define
6274         _WIN32_WINNT to 0x500.
6275
6276 2019-03-01  Gary Benson <gbenson@redhat.com>
6277
6278         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
6279
6280 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
6281             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
6282
6283         PR gdb/8527
6284         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
6285         set_sigint_trap, clear_sigint_trap.
6286
6287 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6288
6289         * target.c (target_detach): Clear the regcache and the
6290         frame cache.
6291
6292 2019-02-27  Pedro Alves  <palves@redhat.com>
6293
6294         * utils.c (set_screen_size): When we cap the height/width sizes,
6295         tweak the corresponding command variable to show "unlimited":
6296
6297 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
6298             Pedro Alves  <palves@redhat.com>
6299
6300         * utils.c (set_screen_size): Reduce "infinite" rows and columns
6301         before calling rl_set_screen_size.
6302
6303 2019-02-27  Tom Tromey  <tromey@adacore.com>
6304
6305         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
6306         define.
6307         * python/py-value.c: Remove Python 2.4 workaround.
6308         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
6309         workaround.
6310         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
6311         Python 2.4 workaround.
6312         * python/python-internal.h: Remove Python 2.4 comment.
6313         (Py_ssize_t): Don't define.
6314         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
6315         (gdb_Py_DECREF): Remove Python 2.4 workaround.
6316         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
6317         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
6318         * python/python.c (do_start_initialization): Remove Python 2.4
6319         workaround.
6320         * python/py-prettyprint.c (class dummy_python_frame): Remove.
6321         (print_children): Remove Python 2.4 workaround.
6322         * python/py-inferior.c (buffer_procs): Remove Python 2.4
6323         workaround.
6324         (CHARBUFFERPROC_NAME): Remove.
6325         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
6326         Python 2.4 workaround.
6327
6328 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6329
6330         * NEWS: Note minimum Python version.
6331
6332 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6333
6334         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
6335         code from these functions.  Remove corresponding ifdefs.  Use
6336         Py_buffer_up instead of explicit calls to PyBuffer_Release.
6337         Remove gotos and target of gotos.
6338         (infpy_search_memory): Likewise.
6339
6340 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6341
6342         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
6343         (hppa_gdbarch_init): Don't register deleted functions with
6344         gdbarch.
6345
6346 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6347
6348         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
6349         (h8300_unwind_sp): Delete.
6350         (h8300_dummy_id): Delete.
6351         (h8300_gdbarch_init): Don't register deleted functions with
6352         gdbarch.
6353
6354 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6355
6356         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
6357         (ft32_unwind_pc): Delete.
6358         (ft32_unwind_sp): Delete.
6359         (ft32_gdbarch_init): Don't register deleted functions with
6360         gdbarch.
6361
6362 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6363
6364         * gdb/frv-tdep.c (frv_dummy_id): Delete.
6365         (frv_unwind_pc): Delete.
6366         (frv_unwind_sp): Delete.
6367         (frv_gdbarch_init): Don't register deleted functions with
6368         gdbarch.
6369
6370 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6371
6372         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
6373         (riscv_unwind_pc): Delete.
6374         (riscv_unwind_sp): Delete.
6375         (riscv_gdbarch_init): Don't register deleted functions with
6376         gdbarch.
6377
6378 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6379
6380         * gdb/csky-tdep.c (csky_dummy_id): Delete.
6381         (csky_unwind_pc): Delete.
6382         (csky_unwind_sp): Delete.
6383         (csky_gdbarch_init): Don't register deleted functions with
6384         gdbarch.
6385
6386 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6387
6388         * gdb/cris-tdep.c (cris_dummy_id): Delete.
6389         (cris_unwind_pc): Delete.
6390         (cris_unwind_sp): Delete.
6391         (cris_gdbarch_init): Don't register deleted functions with
6392         gdbarch.
6393
6394 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6395
6396         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
6397         (bfin_unwind_pc): Delete.
6398         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
6399
6400 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6401
6402         * gdb/arm-tdep.c (arm_dummy_id): Delete.
6403         (arm_unwind_pc): Delete.
6404         (arm_unwind_sp): Delete.
6405         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
6406
6407 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6408
6409         * gdb/arc-tdep.c (arc_dummy_id): Delete.
6410         (arc_unwind_pc): Delete.
6411         (arc_unwind_sp): Delete.
6412         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
6413
6414 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6415
6416         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
6417         (alpha_unwind_pc): Delete.
6418         (alpha_gdbarch_init): Don't register deleted functions with
6419         gdbarch.
6420
6421 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6422
6423         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
6424         (aarch64_unwind_pc): Delete.
6425         (aarch64_unwind_sp): Delete.
6426         (aarch64_gdbarch_init): Don't register deleted functions with
6427         gdbarch.
6428
6429 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6430
6431         * gdbtypes.c (type_align): Don't consider static members when
6432         computing structure alignment.
6433
6434 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6435
6436         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
6437         return 0 for other types.
6438         * arch-utils.c (default_type_align): Always return 0.
6439         * gdbarch.h: Regenerate.
6440         * gdbarch.sh (type_align): Extend comment.
6441         * gdbtypes.c (type_align): Add additional comments, always call
6442         gdbarch_type_align before applying the default rules.
6443         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
6444         generic code will then apply a suitable default.
6445         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
6446         types, return 0 for other types.
6447
6448 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6449
6450         * NEWS: Create a new section for the next release branch.
6451         Rename the section of the current branch, now that it has
6452         been cut.
6453
6454 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6455
6456         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
6457         * version.in: Bump version to 8.3.50.DATE-git.
6458
6459 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
6460
6461         * aix-thread.c (ptid_cmp): Remove unused variable.
6462         (get_signaled_thread): Likewise.
6463         (store_regs_user_thread): Likewise.
6464         (store_regs_kernel_thread): Likewise.
6465         (fetch_regs_kernel_thread): Remove shadowed variable.
6466
6467 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6468
6469         * features/riscv/32bit-cpu.xml: Add register numbers.
6470         * features/riscv/32bit-fpu.c: Regenerate.
6471         * features/riscv/32bit-fpu.xml: Add register numbers.
6472         * features/riscv/64bit-cpu.xml: Add register numbers.
6473         * features/riscv/64bit-fpu.c: Regenerate.
6474         * features/riscv/64bit-fpu.xml: Add register numbers.
6475
6476 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
6477
6478         * NEWS: Mention two argument form of gdb.Value constructor.
6479         * python/py-value.c (convert_buffer_and_type_to_value): New
6480         function.
6481         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
6482         Add support for handling an optional second argument.  Call
6483         convert_buffer_and_type_to_value as appropriate.
6484         * python/python-internal.h (Py_buffer_deleter): New struct.
6485         (Py_buffer_up): New typedef.
6486
6487 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
6488
6489         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
6490         instead of releasing ownership.
6491
6492 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
6493
6494         * dwarf2read.c (open_and_init_dwp_file): Call
6495         elf_numsections instead of bfd_count_sections to initialize
6496         dwp_file->num_sections.
6497
6498 2019-02-25  Tom Tromey  <tromey@adacore.com>
6499
6500         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
6501
6502 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
6503
6504         * gcore.in: Add '--readnever' option when invoking GDB.
6505
6506 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6507
6508         * MAINTAINERS: Update my email address.
6509
6510 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6511
6512         * build-id.c (build_id_to_debug_bfd_1): New function.
6513         (build_id_to_debug_bfd): Look for separate debug file in
6514         sysroot.
6515
6516 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6517
6518         * gdbarch.sh: Update the copyright year range that is placed into
6519         generated files.
6520
6521 2019-02-22  Keith Seitz  <keiths@redhat.com>
6522
6523         PR symtab/23853
6524         * linespec.c (create_sals_line_offset): Search for the default
6525         symtab's filename instead of its fullname.
6526
6527 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6528
6529         * NEWS: Update style defaults.
6530
6531 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6532
6533         * main.c (captured_main_1): Disable styling in batch mode.
6534
6535 2019-02-20  Tom Tromey  <tom@tromey.com>
6536
6537         * symtab.c (symtab_symbol_info): Fix typos.
6538
6539 2019-02-20  Tom Tromey  <tromey@adacore.com>
6540
6541         * findcmd.c (_initialize_mem_search): Use upper case for
6542         metasyntactic variables.
6543
6544 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
6545
6546         * aarch64-tdep.c (aarch64_add_reggroups): New function.
6547         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
6548
6549 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
6550
6551         * top.h (source_file_name): Change to std::string.
6552         * top.c (source_file_name): Likewise.
6553         (command_line_input): Adjust.
6554         * cli/cli-script.c (script_from_file): Adjust.
6555
6556 2019-02-19  Tom Tromey  <tromey@adacore.com>
6557
6558         * ravenscar-thread.c
6559         (ravenscar_thread_target::update_thread_list): Don't call
6560         ada_build_task_list.
6561         * ada-lang.h (ada_build_task_list): Don't declare.
6562         * ada-tasks.c (struct ada_tasks_inferior_data)
6563         <task_list_valid_p>: Now bool.
6564         (read_known_tasks, ada_task_list_changed)
6565         (ada_tasks_invalidate_inferior_data): Update.
6566         (read_known_tasks_array): Return bool.
6567         (read_known_tasks_list): Likewise.
6568         (read_known_tasks): Return void.
6569         (ada_build_task_list): Now static.
6570
6571 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6572
6573         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
6574         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
6575
6576 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6577
6578         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
6579         variant for ada_tasks_pspace_data_handle and
6580         ada_tasks_inferior_data_handle.
6581         (ada_tasks_pspace_data_cleanup): New function.
6582         (ada_tasks_inferior_data_cleanup): New function.
6583
6584 2019-02-17  Tom Tromey  <tom@tromey.com>
6585
6586         * macrotab.h (macro_source_fullname): Return a std::string.
6587         * macrotab.c (macro_include, check_for_redefinition)
6588         (macro_undef, macro_lookup_definition, foreach_macro)
6589         (foreach_macro_in_scope): Update.
6590         (macro_source_fullname): Return a std::string.
6591         * macrocmd.c (show_pp_source_pos): Update.
6592
6593 2019-02-17  Tom Tromey  <tom@tromey.com>
6594
6595         * macrocmd.c (show_pp_source_pos): Style the file names.
6596
6597 2019-02-17  Tom Tromey  <tom@tromey.com>
6598
6599         PR tui/24197:
6600         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
6601
6602 2019-02-17  Tom Tromey  <tom@tromey.com>
6603
6604         * ada-lang.c (user_select_syms): Use filtered printing.
6605         * utils.c (wrap_style): New global.
6606         (desired_style): Remove.
6607         (emit_style_escape): Add stream parameter.
6608         (set_output_style, reset_terminal_style, prompt_for_continue):
6609         Update.
6610         (flush_wrap_buffer): Only flush gdb_stdout.
6611         (wrap_here): Set wrap_style.
6612         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
6613         treat escape sequences as a character.  Change when wrap buffer is
6614         flushed.
6615         (fputs_styled): Do not set the output style when the default is
6616         requested.
6617         * ui-style.h (struct ui_file_style) <is_default>: New method.
6618         * source.c (print_source_lines_base): Emit escape sequences in one
6619         piece.
6620
6621 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6622
6623         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
6624         integers and enumeration types.
6625
6626 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6627
6628         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
6629         instead of lookup_symbol_in_language
6630         (do_exact_match): New function.
6631         (ada_get_symbol_name_matcher): Return do_exact_match when
6632         doing a verbatim match.
6633
6634 2019-02-15  Tom Tromey  <tromey@adacore.com>
6635
6636         * ravenscar-thread.c (ravenscar_thread_target::resume)
6637         (ravenscar_thread_target::wait): Special case wildcard requests.
6638
6639 2019-02-15  Tom Tromey  <tromey@adacore.com>
6640
6641         * ravenscar-thread.c (base_ptid): Remove.
6642         (struct ravenscar_thread_target) <close>: New method.
6643         <m_base_ptid>: New member.
6644         <update_inferior_ptid, active_task, task_is_currently_active,
6645         runtime_initialized>: Declare methods.
6646         <ravenscar_thread_target>: Add constructor.
6647         (ravenscar_thread_target::task_is_currently_active)
6648         (ravenscar_thread_target::update_inferior_ptid)
6649         (ravenscar_runtime_initialized): Rename.  Now methods.
6650         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
6651         (ravenscar_thread_target::update_thread_list): Update.
6652         (ravenscar_thread_target::active_task): Now method.
6653         (ravenscar_thread_target::store_registers)
6654         (ravenscar_thread_target::prepare_to_store)
6655         (ravenscar_thread_target::prepare_to_store)
6656         (ravenscar_thread_target::mourn_inferior): Update.
6657         (ravenscar_inferior_created): Use "new" to create target.
6658         (ravenscar_thread_target::get_ada_task_ptid): Update.
6659         (_initialize_ravenscar): Don't initialize base_ptid.
6660         (ravenscar_ops): Remove global.
6661
6662 2019-02-15  Tom Tromey  <tromey@adacore.com>
6663
6664         * target.h (push_target): Declare new overload.
6665         * target.c (push_target): New overload, taking an rvalue reference.
6666         * remote.c (remote_target::open_1): Use push_target overload.
6667         * corelow.c (core_target_open): Use push_target overload.
6668
6669 2019-02-15  Tom Tromey  <tromey@adacore.com>
6670
6671         * ravenscar-thread.c (is_ravenscar_task)
6672         (ravenscar_task_is_currently_active): Return bool.
6673         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
6674         (_initialize_ravenscar): Remove "(void)".
6675         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
6676         Return bool.
6677
6678 2019-02-15  Tom Tromey  <tromey@adacore.com>
6679
6680         * ravenscar-thread.c (ravenscar_runtime_initializer)
6681         (has_ravenscar_runtime, get_running_thread_id)
6682         (ravenscar_thread_target::resume): Fix indentation.
6683
6684 2019-02-15  Tom Tromey  <tromey@adacore.com>
6685
6686         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
6687         from ravenscar_arch_ops.
6688         (sparc_ravenscar_ops::fetch_registers)
6689         (sparc_ravenscar_ops::store_registers): Now methods.
6690         (sparc_ravenscar_prepare_to_store): Remove.
6691         (sparc_ravenscar_ops): Redefine.
6692         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
6693         methods and destructor.  Remove members.
6694         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
6695         (ravenscar_thread_target::store_registers)
6696         (ravenscar_thread_target::prepare_to_store): Update.
6697         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
6698         Remove.
6699         (struct ppc_ravenscar_powerpc_ops): Derive from
6700         ravenscar_arch_ops.
6701         (ppc_ravenscar_powerpc_ops::fetch_registers)
6702         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
6703         (ppc_ravenscar_powerpc_ops): Redefine.
6704         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
6705         (ppc_ravenscar_e500_ops::fetch_registers)
6706         (ppc_ravenscar_e500_ops::store_registers): Now methods.
6707         (ppc_ravenscar_e500_ops): Redefine.
6708         * aarch64-ravenscar-thread.c
6709         (aarch64_ravenscar_generic_prepare_to_store): Remove.
6710         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
6711         (aarch64_ravenscar_fetch_registers)
6712         (aarch64_ravenscar_store_registers): Now methods.
6713         (aarch64_ravenscar_ops): Redefine.
6714
6715 2019-02-15  Tom Tromey  <tromey@adacore.com>
6716
6717         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
6718         (ravenscar_thread_target::stopped_by_hw_breakpoint)
6719         (ravenscar_thread_target::stopped_by_watchpoint)
6720         (ravenscar_thread_target::stopped_data_address)
6721         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
6722
6723 2019-02-15  Tom Tromey  <tromey@adacore.com>
6724
6725         * ravenscar-thread.c: Fix some typos.
6726
6727 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6728             Tom Tromey  <tromey@adacore.com>
6729
6730         * ada-lang.c (ada_exception_sal): Change addr_string to a
6731         std::string.
6732         (create_ada_exception_catchpoint): Update.
6733
6734 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6735             Tom Tromey  <tromey@adacore.com>
6736
6737         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
6738         (bp_location_ops): Remove.
6739         (base_breakpoint_allocate_location): Update.
6740         (free_bp_location): Update.
6741         * ada-lang.c (class ada_catchpoint_location)
6742         <ada_catchpoint_location>: Remove ops parameter.
6743         (ada_catchpoint_location_dtor): Remove.
6744         (ada_catchpoint_location_ops): Remove.
6745         (allocate_location_exception): Update.
6746         * breakpoint.h (struct bp_location_ops): Remove.
6747         (class bp_location) <bp_location>: Remove bp_location_ops
6748         parameter.
6749         <~bp_location>: Add destructor.
6750         <ops>: Remove.
6751
6752 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6753             Pedro Alves  <palves@redhat.com>
6754
6755         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
6756         'PATH_MAX'.
6757
6758 2019-02-14  David Michael  <fedora.dm0@gmail.com>
6759             Samuel Thibault  <samuel.thibault@gnu.org>
6760             Thomas Schwinge  <thomas@codesourcery.com>
6761
6762         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
6763         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
6764
6765 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6766
6767         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
6768         (check_empty): Use "const char *".
6769
6770         * gnu-nat.c (gnu_nat_target::detach): Instead of
6771         'detach_inferior (pid)' call
6772         'detach_inferior (find_inferior_pid (pid))'.
6773
6774         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
6775         'nat/fork-inferior.o'.
6776         * gnu-nat.c: #include "nat/fork-inferior.h".
6777
6778         * gnu-nat.c (gnu_nat_target::detach): Instead of
6779         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
6780         * gnu-nat.h: #include "inf-child.h".
6781         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
6782         'i386_gnu_nat_target::fetch_registers'.
6783         (gnu_store_registers): Rename/move to
6784         'i386_gnu_nat_target::store_registers'.
6785
6786         * config/i386/nm-i386gnu.h: Don't "#include" any files.
6787         * gnu-nat.h (mach_thread_info): New function.
6788         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
6789
6790         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
6791
6792 2019-02-14  Frederic Konrad  <konrad@adacore.com>
6793
6794         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
6795
6796 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
6797
6798         * windows-nat.c (windows_add_thread): Add new parameter
6799         "main_thread_p" with default value set to false.  Update
6800         function documentation as well as all callers.
6801         (windows_delete_thread): Likewise.
6802         (fake_create_process): Update call to windows_add_thread.
6803         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
6804         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
6805         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
6806         call to windows_delete_thread.
6807
6808 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
6809
6810         * MAINTAINERS: Add Andrew Burgess as global maintainer.
6811
6812 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6813
6814         * symfile.c (find_separate_debug_file): Use canonical path of
6815         sysroot with child_path instead of gdb_sysroot if it is valid.
6816
6817 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6818
6819         * symfile.c (find_separate_debug_file): Use child_path to
6820         determine if an object file is under a sysroot.
6821
6822 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6823
6824         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6825         unittests/child-path-selftests.c.
6826         * common/pathstuff.c (child_path): New function.
6827         * common/pathstuff.h (child_path): New prototype.
6828         * unittests/child-path-selftests.c: New file.
6829
6830 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6831
6832         * symfile.c (find_separate_debug_file): Look for separate debug
6833         files in debug directories under the sysroot.
6834
6835 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6836
6837         * symtab.h (struct minimal_symbol data_p): New const method.
6838         (struct minimal_symbol text_p): Likewise.
6839         * symtab.c (output_source_filename): Use file name style
6840         to print file name.
6841         (print_symbol_info): Likewise.
6842         (print_msymbol_info): Use address style to print addresses.
6843         Use function name style to print executable text symbols.
6844         (expand_symtab_containing_pc): Use data_p.
6845         (find_pc_sect_compunit_symtab): Likewise.
6846
6847 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6848
6849         * breakpoint.c (describe_other_breakpoints): Use address style
6850         to print addresses.
6851         (say_where): Likewise.
6852
6853 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6854
6855         * ada-typeprint.c (print_func_type): Print function name
6856         style to print function name.
6857         * c-typeprint.c (c_print_type_1): Likewise.
6858
6859 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
6860
6861         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
6862         for execve.
6863
6864 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6865
6866         * c-exp.y (direct_abs_decl): Use emplace_back to record the
6867         type_stack.
6868
6869 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
6870
6871         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
6872         TYPE_CODE_REF types.
6873
6874 2019-02-08  Jim Wilson  <jimw@sifive.com>
6875
6876         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
6877         (riscv_linux_fregset): New.
6878         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
6879
6880 2019-02-07  Tom Tromey  <tom@tromey.com>
6881
6882         * thread.c (thread_cancel_execution_command): Update.
6883         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
6884         methods.
6885         (struct thread_fsm_ops): Remove.
6886         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
6887         (thread_fsm_should_stop, thread_fsm_return_value)
6888         (thread_fsm_set_finished, thread_fsm_finished_p)
6889         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
6890         Don't declare.
6891         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
6892         * infrun.c (clear_proceed_status_thread)
6893         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
6894         (print_stop_event): Update.
6895         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
6896         Add constructor.
6897         (step_command_fsm_ops): Remove.
6898         (new_step_command_fsm): Remove.
6899         (step_1): Update.
6900         (step_command_fsm::should_stop): Rename from
6901         step_command_fsm_should_stop.
6902         (step_command_fsm::clean_up): Rename from
6903         step_command_fsm_clean_up.
6904         (step_command_fsm::do_async_reply_reason): Rename from
6905         step_command_fsm_async_reply_reason.
6906         (struct until_next_fsm): Inherit from thread_fsm.  Add
6907         constructor.
6908         (until_next_fsm_ops): Remove.
6909         (new_until_next_fsm): Remove.
6910         (until_next_fsm::should_stop): Rename from
6911         until_next_fsm_should_stop.
6912         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
6913         (until_next_fsm::do_async_reply_reason): Rename from
6914         until_next_fsm_async_reply_reason.
6915         (struct finish_command_fsm): Inherit from thread_fsm.  Add
6916         constructor.  Change type of breakpoint.
6917         (finish_command_fsm_ops): Remove.
6918         (new_finish_command_fsm): Remove.
6919         (finish_command_fsm::should_stop): Rename from
6920         finish_command_fsm_should_stop.
6921         (finish_command_fsm::clean_up): Rename from
6922         finish_command_fsm_clean_up.
6923         (finish_command_fsm::return_value): Rename from
6924         finish_command_fsm_return_value.
6925         (finish_command_fsm::do_async_reply_reason): Rename from
6926         finish_command_fsm_async_reply_reason.
6927         (finish_command): Update.
6928         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
6929         Add constructor.
6930         (call_thread_fsm_ops): Remove.
6931         (call_thread_fsm::call_thread_fsm): Rename from
6932         new_call_thread_fsm.
6933         (call_thread_fsm::should_stop): Rename from
6934         call_thread_fsm_should_stop.
6935         (call_thread_fsm::should_notify_stop): Rename from
6936         call_thread_fsm_should_notify_stop.
6937         (run_inferior_call, call_function_by_hand_dummy): Update.
6938         * cli/cli-interp.c (should_print_stop_to_console): Update.
6939         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
6940         Add constructor.  Change type of location_breakpoint,
6941         caller_breakpoint.
6942         (until_break_fsm_ops): Remove.
6943         (new_until_break_fsm): Remove.
6944         (until_break_fsm::should_stop): Rename from
6945         until_break_fsm_should_stop.
6946         (until_break_fsm::clean_up): Rename from
6947         until_break_fsm_clean_up.
6948         (until_break_fsm::do_async_reply_reason): Rename from
6949         until_break_fsm_async_reply_reason.
6950         (until_break_command): Update.
6951         * thread-fsm.c: Remove.
6952         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
6953
6954 2019-02-07  Tom Tromey  <tom@tromey.com>
6955
6956         * yy-remap.h: Add include guard.
6957         * xtensa-tdep.h: Add include guard.
6958         * xcoffread.h: Rename include guard.
6959         * varobj-iter.h: Add include guard.
6960         * tui/tui.h: Rename include guard.
6961         * tui/tui-winsource.h: Rename include guard.
6962         * tui/tui-wingeneral.h: Rename include guard.
6963         * tui/tui-windata.h: Rename include guard.
6964         * tui/tui-win.h: Rename include guard.
6965         * tui/tui-stack.h: Rename include guard.
6966         * tui/tui-source.h: Rename include guard.
6967         * tui/tui-regs.h: Rename include guard.
6968         * tui/tui-out.h: Rename include guard.
6969         * tui/tui-layout.h: Rename include guard.
6970         * tui/tui-io.h: Rename include guard.
6971         * tui/tui-hooks.h: Rename include guard.
6972         * tui/tui-file.h: Rename include guard.
6973         * tui/tui-disasm.h: Rename include guard.
6974         * tui/tui-data.h: Rename include guard.
6975         * tui/tui-command.h: Rename include guard.
6976         * tic6x-tdep.h: Add include guard.
6977         * target/waitstatus.h: Rename include guard.
6978         * target/wait.h: Rename include guard.
6979         * target/target.h: Rename include guard.
6980         * target/resume.h: Rename include guard.
6981         * target-float.h: Rename include guard.
6982         * stabsread.h: Add include guard.
6983         * rs6000-tdep.h: Add include guard.
6984         * riscv-fbsd-tdep.h: Add include guard.
6985         * regformats/regdef.h: Rename include guard.
6986         * record.h: Rename include guard.
6987         * python/python.h: Rename include guard.
6988         * python/python-internal.h: Rename include guard.
6989         * python/py-stopevent.h: Rename include guard.
6990         * python/py-ref.h: Rename include guard.
6991         * python/py-record.h: Rename include guard.
6992         * python/py-record-full.h: Rename include guard.
6993         * python/py-record-btrace.h: Rename include guard.
6994         * python/py-instruction.h: Rename include guard.
6995         * python/py-events.h: Rename include guard.
6996         * python/py-event.h: Rename include guard.
6997         * procfs.h: Add include guard.
6998         * proc-utils.h: Add include guard.
6999         * p-lang.h: Add include guard.
7000         * or1k-tdep.h: Rename include guard.
7001         * observable.h: Rename include guard.
7002         * nto-tdep.h: Rename include guard.
7003         * nat/x86-linux.h: Rename include guard.
7004         * nat/x86-linux-dregs.h: Rename include guard.
7005         * nat/x86-gcc-cpuid.h: Add include guard.
7006         * nat/x86-dregs.h: Rename include guard.
7007         * nat/x86-cpuid.h: Rename include guard.
7008         * nat/ppc-linux.h: Rename include guard.
7009         * nat/mips-linux-watch.h: Rename include guard.
7010         * nat/linux-waitpid.h: Rename include guard.
7011         * nat/linux-ptrace.h: Rename include guard.
7012         * nat/linux-procfs.h: Rename include guard.
7013         * nat/linux-osdata.h: Rename include guard.
7014         * nat/linux-nat.h: Rename include guard.
7015         * nat/linux-namespaces.h: Rename include guard.
7016         * nat/linux-btrace.h: Rename include guard.
7017         * nat/glibc_thread_db.h: Rename include guard.
7018         * nat/gdb_thread_db.h: Rename include guard.
7019         * nat/gdb_ptrace.h: Rename include guard.
7020         * nat/fork-inferior.h: Rename include guard.
7021         * nat/amd64-linux-siginfo.h: Rename include guard.
7022         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7023         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7024         * nat/aarch64-linux.h: Rename include guard.
7025         * nat/aarch64-linux-hw-point.h: Rename include guard.
7026         * mn10300-tdep.h: Add include guard.
7027         * mips-linux-tdep.h: Add include guard.
7028         * mi/mi-parse.h: Rename include guard.
7029         * mi/mi-out.h: Rename include guard.
7030         * mi/mi-main.h: Rename include guard.
7031         * mi/mi-interp.h: Rename include guard.
7032         * mi/mi-getopt.h: Rename include guard.
7033         * mi/mi-console.h: Rename include guard.
7034         * mi/mi-common.h: Rename include guard.
7035         * mi/mi-cmds.h: Rename include guard.
7036         * mi/mi-cmd-break.h: Rename include guard.
7037         * m2-lang.h: Add include guard.
7038         * location.h: Rename include guard.
7039         * linux-record.h: Rename include guard.
7040         * linux-nat.h: Add include guard.
7041         * linux-fork.h: Add include guard.
7042         * i386-darwin-tdep.h: Rename include guard.
7043         * hppa-linux-offsets.h: Add include guard.
7044         * guile/guile.h: Rename include guard.
7045         * guile/guile-internal.h: Rename include guard.
7046         * gnu-nat.h: Rename include guard.
7047         * gdb-stabs.h: Rename include guard.
7048         * frv-tdep.h: Add include guard.
7049         * f-lang.h: Add include guard.
7050         * event-loop.h: Add include guard.
7051         * darwin-nat.h: Rename include guard.
7052         * cp-abi.h: Rename include guard.
7053         * config/sparc/nm-sol2.h: Rename include guard.
7054         * config/nm-nto.h: Rename include guard.
7055         * config/nm-linux.h: Add include guard.
7056         * config/i386/nm-i386gnu.h: Rename include guard.
7057         * config/djgpp/nl_types.h: Rename include guard.
7058         * config/djgpp/langinfo.h: Rename include guard.
7059         * compile/gcc-cp-plugin.h: Add include guard.
7060         * compile/gcc-c-plugin.h: Add include guard.
7061         * compile/compile.h: Rename include guard.
7062         * compile/compile-object-run.h: Rename include guard.
7063         * compile/compile-object-load.h: Rename include guard.
7064         * compile/compile-internal.h: Rename include guard.
7065         * compile/compile-cplus.h: Rename include guard.
7066         * compile/compile-c.h: Rename include guard.
7067         * common/xml-utils.h: Rename include guard.
7068         * common/x86-xstate.h: Rename include guard.
7069         * common/version.h: Rename include guard.
7070         * common/vec.h: Rename include guard.
7071         * common/tdesc.h: Rename include guard.
7072         * common/selftest.h: Rename include guard.
7073         * common/scoped_restore.h: Rename include guard.
7074         * common/scoped_mmap.h: Rename include guard.
7075         * common/scoped_fd.h: Rename include guard.
7076         * common/safe-iterator.h: Rename include guard.
7077         * common/run-time-clock.h: Rename include guard.
7078         * common/refcounted-object.h: Rename include guard.
7079         * common/queue.h: Rename include guard.
7080         * common/ptid.h: Rename include guard.
7081         * common/print-utils.h: Rename include guard.
7082         * common/preprocessor.h: Rename include guard.
7083         * common/pathstuff.h: Rename include guard.
7084         * common/observable.h: Rename include guard.
7085         * common/netstuff.h: Rename include guard.
7086         * common/job-control.h: Rename include guard.
7087         * common/host-defs.h: Rename include guard.
7088         * common/gdb_wait.h: Rename include guard.
7089         * common/gdb_vecs.h: Rename include guard.
7090         * common/gdb_unlinker.h: Rename include guard.
7091         * common/gdb_unique_ptr.h: Rename include guard.
7092         * common/gdb_tilde_expand.h: Rename include guard.
7093         * common/gdb_sys_time.h: Rename include guard.
7094         * common/gdb_string_view.h: Rename include guard.
7095         * common/gdb_splay_tree.h: Rename include guard.
7096         * common/gdb_setjmp.h: Rename include guard.
7097         * common/gdb_ref_ptr.h: Rename include guard.
7098         * common/gdb_optional.h: Rename include guard.
7099         * common/gdb_locale.h: Rename include guard.
7100         * common/gdb_assert.h: Rename include guard.
7101         * common/filtered-iterator.h: Rename include guard.
7102         * common/filestuff.h: Rename include guard.
7103         * common/fileio.h: Rename include guard.
7104         * common/environ.h: Rename include guard.
7105         * common/common-utils.h: Rename include guard.
7106         * common/common-types.h: Rename include guard.
7107         * common/common-regcache.h: Rename include guard.
7108         * common/common-inferior.h: Rename include guard.
7109         * common/common-gdbthread.h: Rename include guard.
7110         * common/common-exceptions.h: Rename include guard.
7111         * common/common-defs.h: Rename include guard.
7112         * common/common-debug.h: Rename include guard.
7113         * common/cleanups.h: Rename include guard.
7114         * common/buffer.h: Rename include guard.
7115         * common/btrace-common.h: Rename include guard.
7116         * common/break-common.h: Rename include guard.
7117         * cli/cli-utils.h: Rename include guard.
7118         * cli/cli-style.h: Rename include guard.
7119         * cli/cli-setshow.h: Rename include guard.
7120         * cli/cli-script.h: Rename include guard.
7121         * cli/cli-interp.h: Rename include guard.
7122         * cli/cli-decode.h: Rename include guard.
7123         * cli/cli-cmds.h: Rename include guard.
7124         * charset-list.h: Add include guard.
7125         * buildsym-legacy.h: Rename include guard.
7126         * bfin-tdep.h: Add include guard.
7127         * ax.h: Rename include guard.
7128         * arm-linux-tdep.h: Add include guard.
7129         * arm-fbsd-tdep.h: Add include guard.
7130         * arch/xtensa.h: Rename include guard.
7131         * arch/tic6x.h: Add include guard.
7132         * arch/i386.h: Add include guard.
7133         * arch/arm.h: Rename include guard.
7134         * arch/arm-linux.h: Rename include guard.
7135         * arch/arm-get-next-pcs.h: Rename include guard.
7136         * arch/amd64.h: Add include guard.
7137         * arch/aarch64-insn.h: Rename include guard.
7138         * arch-utils.h: Rename include guard.
7139         * annotate.h: Add include guard.
7140         * amd64-darwin-tdep.h: Rename include guard.
7141         * aarch64-linux-tdep.h: Add include guard.
7142         * aarch64-fbsd-tdep.h: Add include guard.
7143         * aarch32-linux-nat.h: Add include guard.
7144
7145 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7146
7147         * macrotab.c (macro_define_internal): New function that
7148         factorizes macro_define_object_internal and macro_define_function
7149         code.
7150         (macro_define_object_internal): Use macro_define_internal.
7151         (macro_define_function): Likewise.
7152
7153 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7154
7155         * macrocmd.c (extract_identifier): Return
7156         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
7157         callers.
7158
7159 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
7160
7161         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
7162
7163 2019-02-05  Tom Tromey  <tom@tromey.com>
7164
7165         * target.c (target_stack::unpush): Move assertion earlier.
7166
7167 2019-01-30  Tom Tromey  <tom@tromey.com>
7168
7169         PR python/23615:
7170         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
7171         (gdbpy_parse_and_eval): Likewise.
7172         * python/python-internal.h (gdbpy_allow_threads): New class.
7173
7174 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
7175
7176         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
7177         (aarch64_fbsd_fpregmap): Move earlier.
7178         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
7179         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7180         instead of individual calls to trad_frame_set_reg_addr.
7181         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
7182         earlier.
7183         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
7184         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7185         instead of individual calls to trad_frame_set_reg_addr.
7186
7187 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
7188
7189         * CONTRIBUTE: Replace contribution list with wiki link.
7190
7191 2019-01-25  Tom Tromey  <tom@tromey.com>
7192
7193         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
7194
7195 2019-01-25  Tom Tromey  <tom@tromey.com>
7196
7197         * xtensa-linux-nat.c: Fix common/ includes.
7198         * xml-support.h: Fix common/ includes.
7199         * xml-support.c: Fix common/ includes.
7200         * x86-linux-nat.c: Fix common/ includes.
7201         * windows-nat.c: Fix common/ includes.
7202         * varobj.h: Fix common/ includes.
7203         * varobj.c: Fix common/ includes.
7204         * value.c: Fix common/ includes.
7205         * valops.c: Fix common/ includes.
7206         * utils.c: Fix common/ includes.
7207         * unittests/xml-utils-selftests.c: Fix common/ includes.
7208         * unittests/utils-selftests.c: Fix common/ includes.
7209         * unittests/unpack-selftests.c: Fix common/ includes.
7210         * unittests/tracepoint-selftests.c: Fix common/ includes.
7211         * unittests/style-selftests.c: Fix common/ includes.
7212         * unittests/string_view-selftests.c: Fix common/ includes.
7213         * unittests/scoped_restore-selftests.c: Fix common/ includes.
7214         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
7215         * unittests/scoped_fd-selftests.c: Fix common/ includes.
7216         * unittests/rsp-low-selftests.c: Fix common/ includes.
7217         * unittests/parse-connection-spec-selftests.c: Fix common/
7218         includes.
7219         * unittests/optional-selftests.c: Fix common/ includes.
7220         * unittests/offset-type-selftests.c: Fix common/ includes.
7221         * unittests/observable-selftests.c: Fix common/ includes.
7222         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
7223         * unittests/memrange-selftests.c: Fix common/ includes.
7224         * unittests/memory-map-selftests.c: Fix common/ includes.
7225         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
7226         * unittests/function-view-selftests.c: Fix common/ includes.
7227         * unittests/environ-selftests.c: Fix common/ includes.
7228         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
7229         * unittests/common-utils-selftests.c: Fix common/ includes.
7230         * unittests/cli-utils-selftests.c: Fix common/ includes.
7231         * unittests/array-view-selftests.c: Fix common/ includes.
7232         * ui-file.c: Fix common/ includes.
7233         * tui/tui-io.c: Fix common/ includes.
7234         * tracepoint.h: Fix common/ includes.
7235         * tracepoint.c: Fix common/ includes.
7236         * tracefile-tfile.c: Fix common/ includes.
7237         * top.h: Fix common/ includes.
7238         * top.c: Fix common/ includes.
7239         * thread.c: Fix common/ includes.
7240         * target/waitstatus.h: Fix common/ includes.
7241         * target/waitstatus.c: Fix common/ includes.
7242         * target.h: Fix common/ includes.
7243         * target.c: Fix common/ includes.
7244         * target-memory.c: Fix common/ includes.
7245         * target-descriptions.c: Fix common/ includes.
7246         * symtab.h: Fix common/ includes.
7247         * symfile.c: Fix common/ includes.
7248         * stap-probe.c: Fix common/ includes.
7249         * spu-linux-nat.c: Fix common/ includes.
7250         * sparc-nat.c: Fix common/ includes.
7251         * source.c: Fix common/ includes.
7252         * solib.c: Fix common/ includes.
7253         * solib-target.c: Fix common/ includes.
7254         * ser-unix.c: Fix common/ includes.
7255         * ser-tcp.c: Fix common/ includes.
7256         * ser-pipe.c: Fix common/ includes.
7257         * ser-base.c: Fix common/ includes.
7258         * selftest-arch.c: Fix common/ includes.
7259         * s12z-tdep.c: Fix common/ includes.
7260         * rust-exp.y: Fix common/ includes.
7261         * rs6000-aix-tdep.c: Fix common/ includes.
7262         * riscv-tdep.c: Fix common/ includes.
7263         * remote.c: Fix common/ includes.
7264         * remote-notif.h: Fix common/ includes.
7265         * remote-fileio.h: Fix common/ includes.
7266         * remote-fileio.c: Fix common/ includes.
7267         * regcache.h: Fix common/ includes.
7268         * regcache.c: Fix common/ includes.
7269         * record-btrace.c: Fix common/ includes.
7270         * python/python.c: Fix common/ includes.
7271         * python/py-type.c: Fix common/ includes.
7272         * python/py-inferior.c: Fix common/ includes.
7273         * progspace.h: Fix common/ includes.
7274         * producer.c: Fix common/ includes.
7275         * procfs.c: Fix common/ includes.
7276         * proc-api.c: Fix common/ includes.
7277         * printcmd.c: Fix common/ includes.
7278         * ppc-linux-nat.c: Fix common/ includes.
7279         * parser-defs.h: Fix common/ includes.
7280         * osdata.c: Fix common/ includes.
7281         * obsd-nat.c: Fix common/ includes.
7282         * nat/x86-linux.c: Fix common/ includes.
7283         * nat/x86-linux-dregs.c: Fix common/ includes.
7284         * nat/x86-dregs.h: Fix common/ includes.
7285         * nat/x86-dregs.c: Fix common/ includes.
7286         * nat/ppc-linux.c: Fix common/ includes.
7287         * nat/mips-linux-watch.h: Fix common/ includes.
7288         * nat/mips-linux-watch.c: Fix common/ includes.
7289         * nat/linux-waitpid.c: Fix common/ includes.
7290         * nat/linux-ptrace.h: Fix common/ includes.
7291         * nat/linux-ptrace.c: Fix common/ includes.
7292         * nat/linux-procfs.c: Fix common/ includes.
7293         * nat/linux-personality.c: Fix common/ includes.
7294         * nat/linux-osdata.c: Fix common/ includes.
7295         * nat/linux-namespaces.c: Fix common/ includes.
7296         * nat/linux-btrace.h: Fix common/ includes.
7297         * nat/linux-btrace.c: Fix common/ includes.
7298         * nat/fork-inferior.c: Fix common/ includes.
7299         * nat/amd64-linux-siginfo.c: Fix common/ includes.
7300         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
7301         * nat/aarch64-linux.c: Fix common/ includes.
7302         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
7303         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
7304         * namespace.h: Fix common/ includes.
7305         * mips-linux-tdep.c: Fix common/ includes.
7306         * minsyms.c: Fix common/ includes.
7307         * mi/mi-parse.h: Fix common/ includes.
7308         * mi/mi-main.c: Fix common/ includes.
7309         * mi/mi-cmd-env.c: Fix common/ includes.
7310         * memrange.h: Fix common/ includes.
7311         * memattr.c: Fix common/ includes.
7312         * maint.h: Fix common/ includes.
7313         * maint.c: Fix common/ includes.
7314         * main.c: Fix common/ includes.
7315         * machoread.c: Fix common/ includes.
7316         * location.c: Fix common/ includes.
7317         * linux-thread-db.c: Fix common/ includes.
7318         * linux-nat.c: Fix common/ includes.
7319         * linux-fork.c: Fix common/ includes.
7320         * inline-frame.c: Fix common/ includes.
7321         * infrun.c: Fix common/ includes.
7322         * inflow.c: Fix common/ includes.
7323         * inferior.h: Fix common/ includes.
7324         * inferior.c: Fix common/ includes.
7325         * infcmd.c: Fix common/ includes.
7326         * inf-ptrace.c: Fix common/ includes.
7327         * inf-child.c: Fix common/ includes.
7328         * ia64-linux-nat.c: Fix common/ includes.
7329         * i387-tdep.c: Fix common/ includes.
7330         * i386-tdep.c: Fix common/ includes.
7331         * i386-linux-tdep.c: Fix common/ includes.
7332         * i386-linux-nat.c: Fix common/ includes.
7333         * i386-go32-tdep.c: Fix common/ includes.
7334         * i386-fbsd-tdep.c: Fix common/ includes.
7335         * i386-fbsd-nat.c: Fix common/ includes.
7336         * guile/scm-type.c: Fix common/ includes.
7337         * guile/guile.c: Fix common/ includes.
7338         * go32-nat.c: Fix common/ includes.
7339         * gnu-nat.c: Fix common/ includes.
7340         * gdbthread.h: Fix common/ includes.
7341         * gdbarch-selftests.c: Fix common/ includes.
7342         * gdb_usleep.c: Fix common/ includes.
7343         * gdb_select.h: Fix common/ includes.
7344         * gdb_bfd.c: Fix common/ includes.
7345         * gcore.c: Fix common/ includes.
7346         * fork-child.c: Fix common/ includes.
7347         * findvar.c: Fix common/ includes.
7348         * fbsd-nat.c: Fix common/ includes.
7349         * event-top.c: Fix common/ includes.
7350         * event-loop.c: Fix common/ includes.
7351         * dwarf2read.c: Fix common/ includes.
7352         * dwarf2loc.c: Fix common/ includes.
7353         * dwarf2-frame.c: Fix common/ includes.
7354         * dwarf-index-cache.c: Fix common/ includes.
7355         * dtrace-probe.c: Fix common/ includes.
7356         * disasm-selftests.c: Fix common/ includes.
7357         * defs.h: Fix common/ includes.
7358         * csky-tdep.c: Fix common/ includes.
7359         * cp-valprint.c: Fix common/ includes.
7360         * cp-support.h: Fix common/ includes.
7361         * cp-support.c: Fix common/ includes.
7362         * corelow.c: Fix common/ includes.
7363         * completer.h: Fix common/ includes.
7364         * completer.c: Fix common/ includes.
7365         * compile/compile.c: Fix common/ includes.
7366         * compile/compile-loc2c.c: Fix common/ includes.
7367         * compile/compile-cplus-types.c: Fix common/ includes.
7368         * compile/compile-cplus-symbols.c: Fix common/ includes.
7369         * command.h: Fix common/ includes.
7370         * cli/cli-dump.c: Fix common/ includes.
7371         * cli/cli-cmds.c: Fix common/ includes.
7372         * charset.c: Fix common/ includes.
7373         * build-id.c: Fix common/ includes.
7374         * btrace.h: Fix common/ includes.
7375         * btrace.c: Fix common/ includes.
7376         * breakpoint.h: Fix common/ includes.
7377         * breakpoint.c: Fix common/ includes.
7378         * ax.h:
7379         (enum agent_op): Fix common/ includes.
7380         * ax-general.c (struct aop_map): Fix common/ includes.
7381         * ax-gdb.c: Fix common/ includes.
7382         * auxv.c: Fix common/ includes.
7383         * auto-load.c: Fix common/ includes.
7384         * arm-tdep.c: Fix common/ includes.
7385         * arch/riscv.c: Fix common/ includes.
7386         * arch/ppc-linux-common.c: Fix common/ includes.
7387         * arch/i386.c: Fix common/ includes.
7388         * arch/arm.c: Fix common/ includes.
7389         * arch/arm-linux.c: Fix common/ includes.
7390         * arch/arm-get-next-pcs.c: Fix common/ includes.
7391         * arch/amd64.c: Fix common/ includes.
7392         * arch/aarch64.c: Fix common/ includes.
7393         * arch/aarch64-insn.c: Fix common/ includes.
7394         * arch-utils.c: Fix common/ includes.
7395         * amd64-windows-tdep.c: Fix common/ includes.
7396         * amd64-tdep.c: Fix common/ includes.
7397         * amd64-sol2-tdep.c: Fix common/ includes.
7398         * amd64-obsd-tdep.c: Fix common/ includes.
7399         * amd64-nbsd-tdep.c: Fix common/ includes.
7400         * amd64-linux-tdep.c: Fix common/ includes.
7401         * amd64-linux-nat.c: Fix common/ includes.
7402         * amd64-fbsd-tdep.c: Fix common/ includes.
7403         * amd64-fbsd-nat.c: Fix common/ includes.
7404         * amd64-dicos-tdep.c: Fix common/ includes.
7405         * amd64-darwin-tdep.c: Fix common/ includes.
7406         * agent.c: Fix common/ includes.
7407         * ada-lang.h: Fix common/ includes.
7408         * ada-lang.c: Fix common/ includes.
7409         * aarch64-tdep.c: Fix common/ includes.
7410
7411 2019-01-25  Tom Tromey  <tom@tromey.com>
7412
7413         * common/create-version.sh: Use common/version.h.
7414
7415 2019-01-24  Pedro Alves  <palves@redhat.com>
7416
7417         * infrun.c (signal_stop, signal_print, signal_program)
7418         (signal_catch, signal_pass): Now arrays instead of pointers.
7419         (update_signals_program_target, do_target_resume)
7420         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
7421         * linux-nat.c (linux_nat_target::pass_signals)
7422         (linux_nat_target::create_inferior, linux_nat_target::attach):
7423         Adjust.
7424         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
7425         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
7426         * procfs.c (procfs_target::pass_signals): Adjust.
7427         * record-full.c (record_full_target::resume): Adjust.
7428         * remote.c (remote_target::pass_signals)
7429         (remote_target::program_signals): Adjust.
7430         * target-debug.h (target_debug_print_signals): Now takes a
7431         gdb::array_view as parameter.  Adjust.
7432         * target.h (target_ops) <pass_signals, program_signals>: Replace
7433         pointer and length parameters with gdb::array_view.
7434         (target_pass_signals, target_program_signals): Likewise.
7435         * target-delegates.c: Regenerate.
7436
7437 2019-01-24  Pedro Alves  <palves@redhat.com>
7438
7439         * common/forward-scope-exit.h
7440         (forward_scope_exit::forward_scope_exit): Pass arguments to
7441         m_bind_function directly, instead of creating a std::bind and
7442         copying that.
7443
7444 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
7445
7446         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7447         for static members.
7448         (pass_in_v_vfp_candidate): Likewise.
7449
7450 2019-01-23  Tom Tromey  <tom@tromey.com>
7451             Pedro Alves  <palves@redhat.com>
7452
7453         * regcache.c (class regcache_invalidator): Remove.
7454         (regcache::raw_write): Use make_scope_exit.
7455
7456 2019-01-23  Tom Tromey  <tom@tromey.com>
7457
7458         * ui-out.h (class ui_out_emit_type): Update comment.
7459
7460 2019-01-23  Tom Tromey  <tom@tromey.com>
7461
7462         * infrun.c (fetch_inferior_event): Update comment.
7463
7464 2019-01-23  Tom Tromey  <tom@tromey.com>
7465             Pedro Alves  <palves@redhat.com>
7466
7467         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
7468         parameter.
7469         (fetch_inferior_event): Use SCOPE_EXIT.
7470
7471
7472 2019-01-23  Tom Tromey  <tom@tromey.com>
7473             Pedro Alves  <palves@redhat.com>
7474
7475         * infrun.c (disable_thread_events): Delete.
7476         (stop_all_threads): Use SCOPE_EXIT.
7477
7478 2019-01-23  Tom Tromey  <tom@tromey.com>
7479             Pedro Alves  <palves@redhat.com>
7480
7481         * symfile.c: Include forward-scope-exit.h.
7482         (clear_symtab_users_cleanup): Replace forward declaration with
7483         a FORWARD_SCOPE_EXIT.
7484         (syms_from_objfile_1): Use the forward_scope_exit and
7485         gdb::optional instead of cleanup_function.
7486         (reread_symbols): Use the forward_scope_exit instead of
7487         cleanup_function.
7488         (clear_symtab_users_cleanup): Remove function.
7489
7490 2019-01-23  Tom Tromey  <tom@tromey.com>
7491             Pedro Alves  <palves@redhat.com>
7492
7493         * linux-nat.c: Include scope-exit.h.
7494         (cleanup_target_stop): Remove.
7495         (linux_nat_target::static_tracepoint_markers_by_strid): Use
7496         SCOPE_EXIT.
7497
7498 2019-01-23  Tom Tromey  <tom@tromey.com>
7499             Pedro Alves  <palves@redhat.com>
7500
7501         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
7502         (call_function_by_hand_dummy): Use SCOPE_EXIT.
7503
7504 2019-01-23  Tom Tromey  <tom@tromey.com>
7505             Andrew Burgess  <andrew.burgess@embecosm.com>
7506             Pedro Alves  <palves@redhat.com>
7507
7508         * infrun.c (fetch_inferior_event): Use scope_exit.
7509         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
7510         * top.c (execute_command): Use scope_exit.
7511         * breakpoint.c (bpstat_do_actions): Use scope_exit.
7512         * utils.c (do_bpstat_clear_actions_cleanup)
7513         (make_bpstat_clear_actions_cleanup): Remove.
7514
7515 2019-01-23  Tom Tromey  <tom@tromey.com>
7516             Pedro Alves  <palves@redhat.com>
7517
7518         * infrun.c: Include "common/scope-exit.h"
7519         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
7520         (wait_for_inferior): Use SCOPE_EXIT.
7521         (fetch_inferior_event): Use scope_exit.
7522
7523 2019-01-23  Tom Tromey  <tom@tromey.com>
7524             Pedro Alves  <palves@redhat.com>
7525
7526         * breakpoint.c (create_breakpoint): Remove cleanup.
7527
7528 2019-01-23  Tom Tromey  <tom@tromey.com>
7529             Andrew Burgess  <andrew.burgess@embecosm.com>
7530             Pedro Alves  <palves@redhat.com>
7531
7532 2019-01-23  Pedro Alves  <palves@redhat.com>
7533
7534         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
7535
7536 2019-01-23  Pedro Alves  <palves@redhat.com>
7537             Andrew Burgess  <andrew.burgess@embecosm.com>
7538
7539         * gdbthread.h: Include "common/forward-scope-exit.h".
7540         (scoped_finish_thread_state): Redefine custom class in terms of
7541         forward_scope_exit.
7542
7543 2019-01-23  Pedro Alves  <palves@redhat.com>
7544             Andrew Burgess  <andrew.burgess@embecosm.com>
7545
7546         * common/forward-scope-exit.h: New file.
7547
7548 2019-01-23  Pedro Alves  <palves@redhat.com>
7549             Andrew Burgess  <andrew.burgess@embecosm.com>
7550             Tom Tromey  <tom@tromey.com>
7551
7552         * common/scope-exit.h: New file.
7553
7554 2019-01-23  Pedro Alves  <palves@redhat.com>
7555
7556         * common/preprocessor.h (ESC): Rename to ...
7557         (ESC_PARENS): ... this.
7558         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
7559         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
7560
7561 2019-01-23  Tom Tromey  <tom@tromey.com>
7562
7563         * language.h (class scoped_switch_to_sym_language_if_auto):
7564         Initialize m_lang in both cases.
7565
7566 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
7567
7568         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
7569         with XCNEW.
7570
7571 2019-01-22  Tom Tromey  <tom@tromey.com>
7572
7573         * corelow.c: Do not include sys/file.h.
7574
7575 2019-01-22  Tom Tromey  <tom@tromey.com>
7576
7577         * tui/tui-wingeneral.h: Include gdb_curses.h.
7578
7579 2019-01-22  Tom Tromey  <tom@tromey.com>
7580
7581         * source-cache.h (class source_cache) <get_source_lines,
7582         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
7583
7584 2019-01-22  Tom Tromey  <tom@tromey.com>
7585
7586         * remote-fileio.h (struct remote_target): Declare.
7587
7588 2019-01-22  Tom Tromey  <tom@tromey.com>
7589
7590         * python/py-arch.c: Do not include py-ref.h.
7591         * python/py-bpevent.c: Do not include py-ref.h.
7592         * python/py-cmd.c: Do not include py-ref.h.
7593         * python/py-continueevent.c: Do not include py-ref.h.
7594         * python/py-event.h: Do not include py-ref.h.
7595         * python/py-evtregistry.c: Do not include py-ref.h.
7596         * python/py-finishbreakpoint.c: Do not include py-ref.h.
7597         * python/py-frame.c: Do not include py-ref.h.
7598         * python/py-framefilter.c: Do not include py-ref.h.
7599         * python/py-function.c: Do not include py-ref.h.
7600         * python/py-infevents.c: Do not include py-ref.h.
7601         * python/py-linetable.c: Do not include py-ref.h.
7602         * python/py-objfile.c: Do not include py-ref.h.
7603         * python/py-param.c: Do not include py-ref.h.
7604         * python/py-prettyprint.c: Do not include py-ref.h.
7605         * python/py-progspace.c: Do not include py-ref.h.
7606         * python/py-symbol.c: Do not include py-ref.h.
7607         * python/py-symtab.c: Do not include py-ref.h.
7608         * python/py-type.c: Do not include py-ref.h.
7609         * python/py-unwind.c: Do not include py-ref.h.
7610         * python/py-utils.c: Do not include py-ref.h.
7611         * python/py-value.c: Do not include py-ref.h.
7612         * python/py-varobj.c: Do not include py-ref.h.
7613         * python/py-xmethods.c: Do not include py-ref.h.
7614         * python/python.c: Do not include py-ref.h.
7615         * varobj.c: Do not include py-ref.h.
7616
7617 2019-01-22  Tom Tromey  <tom@tromey.com>
7618
7619         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
7620         keyword for bcache.
7621
7622 2019-01-22  Tom Tromey  <tom@tromey.com>
7623
7624         * compile/compile-cplus-types.c: Remove a comment by #include.
7625
7626 2019-01-22  Tom Tromey  <tom@tromey.com>
7627
7628         * compile/gcc-c-plugin.h: Include compile-internal.h.
7629
7630 2019-01-22  Tom Tromey  <tom@tromey.com>
7631
7632         * stabsread.c (EXTERN): Do not define.
7633         (symnum, next_symbol_text_func, processing_gcc_compilation)
7634         (within_function, global_sym_chain, global_stabs)
7635         (previous_stab_code, this_object_header_files)
7636         (n_this_object_header_files)
7637         (n_allocated_this_object_header_files): Define.
7638         * stabsread.h (EXTERN): Never define.  Use "extern".
7639
7640 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7641
7642         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
7643         history_value.
7644
7645 2019-01-21  Tom Tromey  <tom@tromey.com>
7646
7647         * ui-out.c: Fix includes.
7648         * tui/tui-source.c: Fix includes.
7649         * target.c: Fix includes.
7650         * remote.c: Fix includes.
7651         * regcache.c: Fix includes.
7652         * python/py-block.c: Fix includes.
7653         * printcmd.c: Fix includes.
7654         * or1k-tdep.c: Fix includes.
7655         * mi/mi-main.c: Fix includes.
7656         * m32r-tdep.c: Fix includes.
7657         * csky-tdep.c: Fix includes.
7658         * compile/compile-cplus-types.c: Fix includes.
7659         * cli/cli-interp.c: Fix includes.
7660
7661 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
7662
7663         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7664         for padding.
7665
7666 2019-01-16  Tom Tromey  <tom@tromey.com>
7667
7668         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
7669         earlier.
7670         (struct objfile) <msymbols_range>: Move from top level.
7671         <msymbols>: New method.
7672         (class objfile_msymbols): Remove.
7673         * symtab.c (default_collect_symbol_completion_matches_break_on):
7674         Update.
7675         * symmisc.c (dump_msymbols): Update.
7676         * stabsread.c (scan_file_globals): Update.
7677         * objc-lang.c (info_selectors_command, info_classes_command)
7678         (find_methods): Update.
7679         * minsyms.c (find_solib_trampoline_target): Update.
7680         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
7681         * coffread.c (coff_symfile_read): Update.
7682         * ada-lang.c (ada_lookup_simple_minsym)
7683         (ada_collect_symbol_completion_matches): Update.
7684
7685 2019-01-16  Tom Tromey  <tom@tromey.com>
7686
7687         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
7688         type.  Remove no-argument constructor.
7689         <iterator::operator++>: Simplify.
7690         <begin>: Update.
7691         <end>: Use minimal_symbol_count.
7692
7693 2019-01-16  Tom Tromey  <tom@tromey.com>
7694
7695         * objfiles.h (struct objfile) <psymtabs>: New method.
7696         (class objfile_psymtabs): Remove.
7697         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
7698         typedef.
7699         <range>: New method.
7700         (require_partial_symbols): Change return type.
7701         * psymtab.c (require_partial_symbols)
7702         (psym_expand_symtabs_matching): Update.
7703         * mdebugread.c (parse_partial_symbols): Update.
7704         * dbxread.c (dbx_end_psymtab): Update.
7705
7706 2019-01-15  Tom Tromey  <tom@tromey.com>
7707
7708         * symtab.c (lookup_objfile_from_block)
7709         (lookup_symbol_in_objfile_symtabs)
7710         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
7711         (find_line_symtab, info_sources_command)
7712         (default_collect_symbol_completion_matches_break_on)
7713         (make_source_files_completion_list): Update.
7714         * symmisc.c (print_objfile_statistics, dump_objfile)
7715         (maintenance_print_symbols, maintenance_info_symtabs)
7716         (maintenance_check_symtabs, maintenance_info_line_tables):
7717         Update.
7718         * source.c (select_source_symtab)
7719         (forget_cached_source_info_for_objfile): Update.
7720         * objfiles.h (class objfile_compunits): Remove.
7721         (struct objfile) <compunits_range>: New typedef.
7722         (compunits): New method.
7723         * objfiles.c (objfile_relocate1): Update.
7724         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7725         * maint.c (count_symtabs_and_blocks): Update.
7726         * linespec.c (iterate_over_all_matching_symtabs): Update.
7727         * cp-support.c (add_symbol_overload_list_qualified): Update.
7728         * coffread.c (coff_symtab_read): Update.
7729         * ada-lang.c (add_nonlocal_symbols)
7730         (ada_collect_symbol_completion_matches)
7731         (ada_add_global_exceptions): Update.
7732
7733 2019-01-15  Tom Tromey  <tom@tromey.com>
7734
7735         * progspace.h (program_space) <objfiles_safe_range>: New
7736         typedef.
7737         <objfiles_safe>: New method.
7738         * objfiles.h (class all_objfiles_safe): Remove.
7739         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
7740         * jit.c (jit_inferior_exit_hook): Update.
7741
7742 2019-01-17  Tom Tromey  <tom@tromey.com>
7743
7744         * progspace.h (program_space) <objfiles_range>: New typedef.
7745         <objfiles>: New method.
7746         <objfiles_head>: Rename from objfiles.
7747         (object_files): Update.
7748         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
7749         * guile/scm-pretty-print.c
7750         (ppscm_find_pretty_printer_from_objfiles): Update.
7751         * guile/scm-objfile.c (gdbscm_objfiles): Update.
7752         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
7753         Update.
7754         * python/py-progspace.c (pspy_get_objfiles): Update.
7755         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7756         Update.
7757         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7758         (objfpy_lookup_objfile_by_build_id): Update.
7759         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7760         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7761         Update.
7762         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7763         (expand_symtab_containing_pc, lookup_objfile_from_block)
7764         (lookup_static_symbol, basic_lookup_transparent_type)
7765         (find_pc_sect_compunit_symtab, find_symbol_at_address)
7766         (find_line_symtab, info_sources_command)
7767         (default_collect_symbol_completion_matches_break_on)
7768         (make_source_files_completion_list, find_main_name): Update.
7769         * symmisc.c (print_symbol_bcache_statistics)
7770         (print_objfile_statistics, maintenance_print_symbols)
7771         (maintenance_print_msymbols, maintenance_print_objfiles)
7772         (maintenance_info_symtabs, maintenance_check_symtabs)
7773         (maintenance_expand_symtabs, maintenance_info_line_tables):
7774         Update.
7775         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
7776         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
7777         (map_overlay_command, unmap_overlay_command)
7778         (simple_overlay_update, expand_symtabs_matching)
7779         (map_symbol_filenames): Update.
7780         * symfile-debug.c (set_debug_symfile): Update.
7781         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
7782         Update.
7783         * source.c (select_source_symtab, forget_cached_source_info):
7784         Update.
7785         * solib.c (solib_read_symbols): Update.
7786         * solib-spu.c (append_ocl_sos): Update.
7787         * psymtab.c (maintenance_print_psymbols)
7788         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
7789         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
7790         * printcmd.c (info_symbol_command): Update.
7791         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
7792         Update.
7793         * objfiles.h (class all_objfiles): Remove.
7794         * objfiles.c (have_partial_symbols, have_full_symbols)
7795         (have_minimal_symbols, qsort_cmp, update_section_map)
7796         (shared_objfile_contains_address_p)
7797         (default_iterate_over_objfiles_in_search_order): Update.
7798         * objc-lang.c (info_selectors_command, info_classes_command)
7799         (find_methods): Update.
7800         * minsyms.c (find_solib_trampoline_target): Update.
7801         * maint.c (maintenance_info_sections)
7802         (maintenance_translate_address, count_symtabs_and_blocks):
7803         Update.
7804         * main.c (captured_main_1): Update.
7805         * linux-thread-db.c (try_thread_db_load_from_pdir)
7806         (has_libpthread): Update.
7807         * linespec.c (iterate_over_all_matching_symtabs)
7808         (search_minsyms_for_name): Update.
7809         * jit.c (jit_find_objf_with_entry_addr): Update.
7810         * hppa-tdep.c (find_unwind_entry)
7811         (hppa_lookup_stub_minimal_symbol): Update.
7812         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
7813         Update.
7814         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7815         (elf_gnu_ifunc_resolve_by_got): Update.
7816         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
7817         * dwarf-index-write.c (save_gdb_index_command): Update.
7818         * cp-support.c (add_symbol_overload_list_qualified): Update.
7819         * breakpoint.c (create_overlay_event_breakpoint)
7820         (create_longjmp_master_breakpoint)
7821         (create_std_terminate_master_breakpoint)
7822         (create_exception_master_breakpoint): Update.
7823         * blockframe.c (find_pc_partial_function): Update.
7824         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
7825         (ada_collect_symbol_completion_matches)
7826         (ada_add_global_exceptions): Update.
7827
7828 2019-01-17  Tom Tromey  <tom@tromey.com>
7829
7830         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
7831         declare VEC.
7832         (solib_target_parse_libraries): Change return type.
7833         (library_list_start_segment, library_list_start_section)
7834         (library_list_end_library, library_list_start_library); Update.
7835         (solib_target_free_library_list): Remove.
7836         (solib_target_parse_libraries): Remove cleanup.  Change return
7837         type.
7838         (solib_target_current_sos): Update.
7839
7840 2019-01-17  Tom Tromey  <tromey@bapiya>
7841
7842         * valprint.c: Replace "the the" with "the".
7843         * symtab.c: Replace "the the" with "the".
7844         * solib.c: Replace "the the" with "the".
7845         * solib-dsbt.c: Replace "the the" with "the".
7846         * linespec.c: Replace "the the" with "the".
7847         * dwarf2loc.h: Replace "the the" with "the".
7848         * amd64-windows-tdep.c: Replace "the the" with "the".
7849         * aarch64-tdep.c: Replace "the the" with "the".
7850
7851 2019-01-16  Keith Seitz  <keiths@redhat.com>
7852
7853         PR gdb/23773
7854         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
7855         <builder>: Rename to ..
7856         <m_builder>: ... this and make private.
7857         (dwarf2_cu::get_builder): New method.  Change all users of
7858         `builder' to use this method.
7859         (dwarf2_start_symtab): Move to ...
7860         (dwarf2_cu::start_symtab): ... here.  Update all callers
7861         (setup_type_unit_groups): Move to ...
7862         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
7863         callers.
7864         (dwarf2_cu::reset_builder): New method.
7865         (process_full_compunit, process_full_type_unit): Use
7866         dwarf2_cu::reset_builder.
7867         (follow_die_offset): Record the ancestor CU if it is different
7868         from the followed DIE's CU.
7869         (follow_die_sig_1): Likewise.
7870
7871 2019-01-15  Tom Tromey  <tom@tromey.com>
7872
7873         * remote.c (class remote_state) <buf>: Now a char_vector.
7874         <buf_size>: Remove.
7875         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
7876         parameter.
7877         (remote_target::getpkt_or_notif_sane_1)
7878         (remote_target::getpkt_sane)
7879         (remote_target::getpkt_or_notif_sane): Likewise.
7880         (class remote_target) <putpkt>: New overload.
7881         (remote_target::read_frame): Change type of "buf_p".  Remove
7882         sizeof_p parameter.
7883         (packet_ok): New overload.
7884         (packet_check_result): New overload.
7885         Update all uses.
7886
7887 2019-01-14  Tom Tromey  <tom@tromey.com>
7888
7889         * remote-notif.c (handle_notification, remote_notif_ack)
7890         (remote_notif_parse): Make "buf" const.
7891         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
7892         const.
7893         (remote_notif_parse, remote_notif_ack, handle_notification):
7894         Likewise.
7895         * remote.c (remote_notif_stop_parse): Make "buf" const.
7896         (remote_target::remote_parse_stop_reply): Make "buf" const.
7897         (remote_notif_stop_ack): Make "buf" const.
7898
7899 2019-01-14  Tom Tromey  <tom@tromey.com>
7900
7901         * remote.c (remote_console_output): Make parameter const.
7902
7903 2019-01-14  Tom Tromey  <tom@tromey.com>
7904
7905         * target-debug.h (target_debug_print_signals): Constify.
7906         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
7907         * procfs.c (procfs_target::pass_signals): Update.
7908         * linux-nat.c (linux_nat_target::pass_signals): Update.
7909         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
7910         * target-delegates.c: Rebuild.
7911         * remote.c (remote_target::program_signals): Update.
7912         (remote_target::pass_signals): Update.
7913         * target.c (target_pass_signals): Constify argument.
7914         (target_program_signals): Likewise.
7915         * target.h (struct target_ops) <pass_signals, program_signals>:
7916         Constify argument.
7917         (target_pass_signals, target_program_signals): Constify argument.
7918
7919 2019-01-14  Tom Tromey  <tom@tromey.com>
7920
7921         PR tui/28819:
7922         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
7923
7924 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
7925
7926         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
7927         field.
7928         * rs6000-tdep.c: Include reggroups.h.
7929         (IS_V_ALIAS_PSEUDOREG): Define.
7930         (rs6000_register_name): Return names for the "vX" aliases.
7931         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
7932         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
7933         aliases.  Call default_register_reggroup_p for all other
7934         pseudo-registers.
7935         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
7936         New functions.
7937         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
7938         Handle "vX" aliases.
7939         (v_alias_pseudo_register_collect): New function.
7940         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
7941         (rs6000_gdbarch_init): Initialize "vX" aliases as
7942         pseudo-registers.  Restore registration of
7943         rs6000_pseudo_register_reggroup_p with
7944         set_tdesc_pseudo_register_reggroup_p.
7945
7946 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
7947
7948         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
7949         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
7950         set_gdbarch_num_pseudo_regs.
7951
7952 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7953
7954         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
7955         Remove arg prefixname, add do_set and do_show.
7956         Add member functions set_list and show_list.
7957         * cli/cli-style.c (class cli_style_option): Update accordingly.
7958         (style_set_list): Move to file scope.
7959         (style_show_list): Likewise.
7960         (set_style): Call help_list.
7961         (show_style): Call cmd_show_list.
7962         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
7963         Update to use the new macro.
7964
7965 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
7966
7967         * ada-lang.c (_initialize_ada_language): Expand the help text
7968         for the "catch exception" command.
7969
7970 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7971
7972         * symtab.c (matching_obj_sections): Initialize obj,
7973         declare it closer to its usage.
7974
7975 2019-01-10  Tom Tromey  <tom@tromey.com>
7976
7977         * thread-iter.h (inf_threads_iterator): Use next_iterator.
7978         (basic_inf_threads_range): Remove.
7979         (inf_threads_range, inf_non_exited_threads_range)
7980         (safe_inf_threads_range): Use next_adapter.
7981
7982 2019-01-10  Keith Seitz  <keiths@redhat.com>
7983
7984         PR gdb/23712
7985         PR symtab/23010
7986         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
7987         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
7988
7989 2019-01-10  Keith Seitz  <keiths@redhat.com>
7990
7991         PR gdb/23712
7992         PR symtab/23010
7993         * dictionary.c (pending_to_vector): Remove.
7994         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7995         Remove _1 suffix, replacing functions of the same name.  Update
7996         all callers.
7997         (dict_create_hashed, dict_create_hashed_expandable)
7998         (dict_create_linear, dict_create_linear_expandable, dict_free)
7999         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
8000         Make functions static.
8001
8002 2019-01-10  Keith Seitz  <keiths@redhat.com>
8003
8004         PR gdb/23712
8005         PR symtab/23010
8006         * dictionary.h (struct dictionary): Replace declaration with
8007         multidictionary.
8008         (dict_create_hashed, dict_create_hashed_expandable)
8009         (dict_create_linear, dict_create_linear_expandable)
8010         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
8011         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
8012         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
8013         taking multidictionary argument.
8014         [ALL_DICT_SYMBOLS]: Update for multidictionary.
8015         * block.h (struct block) <dict>: Change to multidictionary
8016         and rename `multidict'.
8017         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
8018         symmisc.c: Update all dictionary references to multidictionary.
8019
8020 2019-01-10  Keith Seitz  <keiths@redhat.com>
8021
8022         PR gdb/23712
8023         PR symtab/23010
8024         * dictionary.c: Include unordered_map.
8025         (pending_to_vector): New function.
8026         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8027         Rewrite the non-"_1" functions to take vector instead
8028         of linked list.
8029         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
8030         "new" _1 versions of the same name.
8031         (multidictionary): Define.
8032         (std::hash<enum language): New definition.
8033         (collate_pending_symbols_by_language, mdict_create_hashed)
8034         (mdict_create_hashed_expandable, mdict_create_linear)
8035         (mdict_create_linear_expandable, mdict_free)
8036         (find_language_dictionary, create_new_language_dictionary)
8037         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
8038         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
8039         (mdict_size, mdict_empty): New functions.
8040         * dictionary.h (mdict_iterator): Define.
8041
8042 2019-01-10  Pedro Alves  <palves@redhat.com>
8043
8044         * breakpoint.c (read_uploaded_action)
8045         (create_tracepoint_from_upload): Adjust to use
8046         gdb::unique_xmalloc_ptr.
8047         * ctf.c (ctf_write_uploaded_tp):
8048         (SET_ARRAY_FIELD): Use emplace_back.
8049         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
8050         * tracefile-tfile.c (tfile_write_uploaded_tp):
8051         * tracepoint.c (parse_tracepoint_definition): Adjust to use
8052         gdb::unique_xmalloc_ptr.
8053         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
8054         at_string, cond_string, cmd_strings>: Replace char pointers
8055         with gdb::unique_xmalloc_ptr.
8056
8057 2019-01-10  Pedro Alves  <palves@redhat.com>
8058
8059         * solib-target.c (library_list_start_library): Don't xstrdup name.
8060
8061 2019-01-10  Pedro Alves  <palves@redhat.com>
8062
8063         * mdebugread.c (parse_partial_symbols): Use
8064         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
8065
8066 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8067
8068         * linux-fork.c (scoped_switch_fork_info)
8069         <~scoped_switch_fork_info>: Fix incorrect variable name.
8070
8071 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8072
8073         * linux-fork.c (scoped_switch_fork_info)
8074         <scoped_switch_fork_info>: Make explicit.
8075         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
8076
8077 2019-01-10  Tom Tromey  <tom@tromey.com>
8078
8079         * objfiles.h (objfile::reset_psymtabs): Update.
8080         * objfiles.c (objfile::objfile): Update.
8081         * psymtab.h (psymtab_storage::obstack): Update.
8082         (psymtab_storage::m_obstack): Use gdb::optional.
8083         (class psymtab_storage): Update comment.  Remove objfile
8084         parameter.
8085         * psymtab.c (psymtab_storage::psymtab_storage): Update.
8086
8087 2019-01-10  Tom Tromey  <tom@tromey.com>
8088
8089         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
8090         <free_psymtabs>: Now private.
8091         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
8092         (allocate_psymtab): Use new method.
8093
8094 2019-01-10  Tom Tromey  <tom@tromey.com>
8095
8096         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
8097         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
8098         * mdebugread.c (parse_partial_symbols): Use
8099         allocate_dependencies.
8100         * dwarf2read.c (dwarf2_create_include_psymtab): Use
8101         allocate_dependencies.
8102         (process_psymtab_comp_unit_reader)
8103         (build_type_psymtab_dependencies): Likewise.
8104         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
8105
8106 2019-01-10  Tom Tromey  <tom@tromey.com>
8107
8108         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
8109         PSYMBOL_SET_LANGUAGE.
8110         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
8111
8112 2019-01-10  Tom Tromey  <tom@tromey.com>
8113
8114         * psymtab.h (psymtab_storage::obstack): New method.
8115         <m_obstack>: Rename from obstack; now private.
8116         * psymtab.c (psymtab_storage): Update.
8117         * dwarf2read.c (create_addrmap_from_index)
8118         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
8119         Update.
8120
8121 2019-01-10  Tom Tromey  <tom@tromey.com>
8122
8123         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
8124         * objfiles.h (objfile::reset_psymtabs): New method.
8125
8126 2019-01-10  Tom Tromey  <tom@tromey.com>
8127
8128         * symmisc.c (print_symbol_bcache_statistics): Update.
8129         (print_objfile_statistics): Update.
8130         * symfile.c (reread_symbols): Update.
8131         * psymtab.h (class psymtab_storage): New.
8132         * psymtab.c (psymtab_storage): New constructor.
8133         (~psymtab_storage): New destructor.
8134         (require_partial_symbols): Update.
8135         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
8136         (find_pc_sect_psymtab, find_pc_sect_psymbol)
8137         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
8138         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
8139         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
8140         (start_psymtab_common, end_psymtab_common)
8141         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
8142         (allocate_psymtab): Update.
8143         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
8144         Update.
8145         (dump_psymtab_addrmap, maintenance_print_psymbols)
8146         (maintenance_check_psymtabs): Update.
8147         (class objfile_psymtabs): Move to objfiles.h.
8148         * psympriv.h (discard_psymtab): Now inline.
8149         (psymtab_discarder::psymtab_discarder): Update.
8150         (psymtab_discarder::~psymtab_discarder): Update.
8151         (ALL_OBJFILE_PSYMTABS): Rewrite.
8152         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
8153         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
8154         Remove fields.
8155         <partial_symtabs>: New field.
8156         (class objfile_psymtabs): Move from psymtab.h.  Update.
8157         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
8158         psymbol_cache.
8159         (objfile::~objfile): Don't destroy psymbol_cache.
8160         * mdebugread.c (parse_partial_symbols): Update.
8161         * dwarf2read.c (create_addrmap_from_index)
8162         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
8163         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
8164         (add_partial_subprogram, dwarf2_ranges_read): Update.
8165         * dwarf-index-write.c (write_address_map)
8166         (write_one_signatured_type, recursively_write_psymbols)
8167         (class debug_names, class debug_names, write_psymtabs_to_index):
8168         Update.
8169
8170 2019-01-10  Tom Tromey  <tom@tromey.com>
8171
8172         * symtab.h (SYMBOL_SET_NAMES): Update.
8173         (symbol_set_names): Update.
8174         (MSYMBOL_SET_NAMES): Update.
8175         * symtab.c (symbol_set_names): Change argument to be an
8176         objfile_per_bfd_storage.
8177         * psymtab.c (add_psymbol_to_bcache): Update.
8178         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
8179
8180 2019-01-10  Tom Tromey  <tom@tromey.com>
8181
8182         * symtab.c (create_demangled_names_hash): Change argument to be an
8183         objfile_per_bfd_storage.
8184         (symbol_set_names): Update.
8185
8186 2019-01-10  Tom Tromey  <tom@tromey.com>
8187
8188         * xcoffread.c (xcoff_initial_scan): Unconditionally call
8189         init_psymbol_list.
8190         * psymtab.c (init_psymbol_list): Do nothing if already called.
8191         * psympriv.h (init_psymbol_list): Add comment.
8192         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
8193         init_psymbol_list.
8194         * dbxread.c (dbx_symfile_read): Unconditionally call
8195         init_psymbol_list.
8196
8197 2019-01-10  Tom Tromey  <tom@tromey.com>
8198
8199         * xcoffread.c (scan_xcoff_symtab): Update.
8200         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
8201         "where".
8202         * mdebugread.c (parse_partial_symbols)
8203         (handle_psymbol_enumerators): Update.
8204         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
8205         * dbxread.c (read_dbx_symtab): Update.
8206         * psympriv.h (psymbol_placement): New enum.
8207         (add_psymbol_to_list): Update.
8208
8209 2019-01-10  Tom Tromey  <tom@tromey.com>
8210
8211         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
8212         static_psymbols parameters.
8213         (scan_xcoff_symtab): Update.
8214         * psymtab.c (start_psymtab_common): Remove global_psymbols and
8215         static_psymbols parameters.
8216         * psympriv.h (start_psymtab_common): Update.
8217         * mdebugread.c (parse_partial_symbols): Update.
8218         * dwarf2read.c (create_partial_symtab): Update.
8219         * dbxread.c (read_dbx_symtab): Update.
8220         (start_psymtab): Remove global_psymbols and static_psymbols
8221         parameters.
8222
8223 2019-01-10  Tom Tromey  <tom@tromey.com>
8224
8225         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
8226         * psymtab.c (allocate_psymtab): Add comment.
8227         * psympriv.h (allocate_psymtab): Add comment.
8228         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
8229         initializations.
8230         * dbxread.c (dbx_end_psymtab): Remove some initializations.
8231
8232 2019-01-10  Tom Tromey  <tom@tromey.com>
8233
8234         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8235         Don't declare.
8236         * mipsread.c: Include mdebugread.h.
8237         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8238         Declare.
8239         * elfread.c: Include mdebugread.h.
8240
8241 2019-01-09  Tom Tromey  <tom@tromey.com>
8242
8243         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
8244         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
8245         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
8246         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
8247         (psym_lookup_symbol, psym_find_last_source_symtab)
8248         (psym_forget_cached_source_info, psym_print_stats)
8249         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
8250         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
8251         (psym_map_matching_symbols, psym_expand_symtabs_matching)
8252         (psym_find_compunit_symtab_by_address)
8253         (maintenance_print_psymbols, maintenance_info_psymtabs)
8254         (maintenance_check_psymtabs): Use ranged for.
8255         * psymtab.h (class objfile_psymtabs): New.
8256         (require_partial_symbols): Return objfile_psymtabs.
8257         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
8258
8259 2019-01-09  Tom Tromey  <tom@tromey.com>
8260
8261         * symfile.c (overlay_invalidate_all, find_pc_overlay)
8262         (find_pc_mapped_section, list_overlays_command)
8263         (map_overlay_command, unmap_overlay_command)
8264         (simple_overlay_update): Use all_objfiles.
8265         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
8266         * printcmd.c (info_symbol_command): Use all_objfiles.
8267         * objfiles.h (ALL_OBJSECTIONS): Remove.
8268         * maint.c (maintenance_translate_address): Use all_objfiles.
8269         * gcore.c (gcore_create_callback): Use all_objfiles.
8270         (objfile_find_memory_regions): Likewise.
8271
8272 2019-01-09  Tom Tromey  <tom@tromey.com>
8273
8274         * symtab.c (find_line_symtab, info_sources_command)
8275         (make_source_files_completion_list): Use objfile_compunits.
8276         * source.c (select_source_symtab): Use objfile_compunits.
8277         * objfiles.h (struct objfile): Update comment.
8278         (ALL_OBJFILES): Remove.
8279         (ALL_FILETABS): Remove.
8280         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
8281         objfile_compunits.
8282
8283 2019-01-09  Tom Tromey  <tom@tromey.com>
8284
8285         * symmisc.c (print_objfile_statistics, dump_objfile)
8286         (maintenance_print_symbols): Use compunit_filetabs.
8287         * source.c (forget_cached_source_info_for_objfile): Use
8288         compunit_filetabs.
8289         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
8290         (ALL_FILETABS): Use compunit_filetabs.
8291         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
8292         * coffread.c (coff_symtab_read): Use compunit_filetabs.
8293
8294 2019-01-09  Tom Tromey  <tom@tromey.com>
8295
8296         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
8297         (compunit_filetabs): New.
8298         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
8299         compunit_filetabs.
8300         (info_sources_command, make_source_files_completion_list): Remove
8301         declaration.
8302         * symmisc.c (print_objfile_statistics, dump_objfile)
8303         (maintenance_print_symbols): Remove declaration.
8304         (maintenance_info_symtabs): Use compunit_filetabs.
8305         (maintenance_info_line_tables): Likewise.
8306         * source.c (select_source_symtab): Change local variable name.
8307         (forget_cached_source_info_for_objfile): Remove declaration.
8308         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
8309         * objfiles.c (objfile_relocate1): Remove declaration.
8310         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8311         declaration.
8312         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
8313         * coffread.c (coff_symtab_read): Remove declaration.
8314         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
8315         compunit_filetabs.
8316
8317 2019-01-09  Tom Tromey  <tom@tromey.com>
8318
8319         * symtab.c (lookup_objfile_from_block)
8320         (find_pc_sect_compunit_symtab, search_symbols)
8321         (default_collect_symbol_completion_matches_break_on): Use
8322         objfile_compunits.
8323         * objfiles.h (ALL_COMPUNITS): Remove.
8324         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
8325         * cp-support.c (add_symbol_overload_list_qualified): Use
8326         objfile_compunits.
8327         * ada-lang.c (ada_collect_symbol_completion_matches)
8328         (ada_add_global_exceptions): Use objfile_compunits.
8329
8330 2019-01-09  Tom Tromey  <tom@tromey.com>
8331
8332         * source.c (select_source_symtab)
8333         (forget_cached_source_info_for_objfile): Remove declaration.
8334         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8335         declaration.
8336         * maint.c (count_symtabs_and_blocks): Remove declaration.
8337         * cp-support.c (add_symbol_overload_list_qualified): Remove
8338         declaration.
8339         * coffread.c (coff_symtab_read): Remove declaration.
8340         * symtab.c (lookup_symbol_in_objfile_symtabs)
8341         (basic_lookup_transparent_type_1): Use objfile_compunits.
8342         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
8343         (info_sources_command, search_symbols)
8344         (default_collect_symbol_completion_matches_break_on)
8345         (make_source_files_completion_list): Remove declaration.
8346         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
8347         (ada_collect_symbol_completion_matches)
8348         (ada_add_global_exceptions): Remove declaration.
8349         * linespec.c (iterate_over_all_matching_symtabs): Use
8350         objfile_compunits.
8351         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
8352         (class objfile_compunits): New.
8353         (ALL_COMPUNITS): Use objfile_compunits.
8354         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
8355         (maintenance_check_symtabs, maintenance_info_line_tables): Use
8356         objfile_compunits.
8357         * objfiles.c (objfile_relocate1): Use objfile_compunits.
8358
8359 2019-01-09  Tom Tromey  <tom@tromey.com>
8360
8361         * symtab.c (search_symbols)
8362         (default_collect_symbol_completion_matches_break_on): Use
8363         objfile_msymbols.
8364         * ada-lang.c (ada_lookup_simple_minsym)
8365         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
8366         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
8367         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
8368         objfile_msymbols.
8369         * coffread.c (coff_symfile_read): Use objfile_msymbols.
8370         * symmisc.c (dump_msymbols): Use objfile_msymbols.
8371         * objc-lang.c (find_methods): Use objfile_msymbols.
8372         (info_selectors_command, info_classes_command): Likewise.
8373         * stabsread.c (scan_file_globals): Use objfile_msymbols.
8374         * objfiles.h (class objfile_msymbols): New.
8375         (ALL_OBJFILE_MSYMBOLS): Remove.
8376         (ALL_MSYMBOLS): Remove.
8377
8378 2019-01-09  Tom Tromey  <tom@tromey.com>
8379
8380         * common/next-iterator.h (next_adapter): Add Iterator template
8381         parameter.
8382         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
8383         (class all_objfiles_safe): New.
8384         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
8385         * objfiles.c (put_objfile_before): Update comment.
8386         (add_separate_debug_objfile): Likewise.
8387         (free_all_objfiles): Use all_objfiles_safe.
8388         (objfile_purge_solibs): Likewise.
8389
8390 2019-01-09  Tom Tromey  <tom@tromey.com>
8391
8392         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8393         (expand_symtab_containing_pc, lookup_static_symbol)
8394         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
8395         (find_symbol_at_address, find_line_symtab, find_main_name): Use
8396         all_objfiles.
8397         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
8398         * breakpoint.c (create_overlay_event_breakpoint)
8399         (create_longjmp_master_breakpoint)
8400         (create_std_terminate_master_breakpoint)
8401         (create_exception_master_breakpoint): Use all_objfiles.
8402         * linux-thread-db.c (try_thread_db_load_from_pdir)
8403         (has_libpthread): Use all_objfiles.
8404         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
8405         * linespec.c (iterate_over_all_matching_symtabs)
8406         (search_minsyms_for_name): Use all_objfiles.
8407         * maint.c (maintenance_info_sections): Use all_objfiles.
8408         * main.c (captured_main_1): Use all_objfiles.
8409         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
8410         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
8411         * guile/scm-pretty-print.c
8412         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
8413         * solib-spu.c (append_ocl_sos): Use all_objfiles.
8414         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
8415         (maintenance_print_msymbols): Use all_objfiles.
8416         * source.c (select_source_symtab): Use all_objfiles.
8417         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
8418         * symfile.c (remove_symbol_file_command)
8419         (expand_symtabs_matching, map_symbol_filenames): Use
8420         all_objfiles.
8421         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
8422         all_objfiles.
8423         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
8424         * objc-lang.c (find_methods): Use all_objfiles.
8425         * objfiles.c (have_partial_symbols, have_full_symbols)
8426         (have_minimal_symbols, qsort_cmp)
8427         (default_iterate_over_objfiles_in_search_order): Use
8428         all_objfiles.
8429         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
8430         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
8431         (maintenance_check_psymtabs): Use all_objfiles.
8432         (ALL_PSYMTABS): Remove.
8433         * compile/compile-object-run.c (do_module_cleanup): Use
8434         all_objfiles.
8435         * blockframe.c (find_pc_partial_function): Use all_objfiles.
8436         * cp-support.c (add_symbol_overload_list_qualified): Use
8437         all_objfiles.
8438         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8439         Use all_objfiles.
8440         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
8441         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
8442         all_objfiles.
8443         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8444         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
8445         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8446         Uses all_objfiles.
8447         * solib.c (solib_read_symbols): Use all_objfiles
8448
8449 2019-01-09  Tom Tromey  <tom@tromey.com>
8450
8451         * probe.c (parse_probes_in_pspace): Use all_objfiles.
8452         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
8453         all_objfiles.
8454         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
8455         * symmisc.c (print_symbol_bcache_statistics)
8456         (print_objfile_statistics, maintenance_print_objfiles)
8457         (maintenance_info_symtabs, maintenance_check_symtabs)
8458         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
8459         all_objfiles.
8460         * source.c (forget_cached_source_info): Use all_objfiles.
8461         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
8462         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8463         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
8464         * objfiles.c (update_section_map): Use all_objfiles.
8465         (shared_objfile_contains_address_p): Likewise.
8466         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
8467         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
8468
8469 2019-01-09  Tom Tromey  <tom@tromey.com>
8470
8471         * common/next-iterator.h: New file.
8472         * objfiles.h (class all_objfiles): New.
8473         (struct objfile_iterator): New.
8474
8475 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8476
8477         * NEWS: Move the description of the changed "frame", "select-frame",
8478          and "info frame" commands to the Changed commands section.
8479
8480 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
8481
8482         * gdbtypes.c (check_stub_method_group): Remove handling of old
8483         mangling schemes.
8484         * linespec.c (find_methods): Likewise.
8485         * stabsread.c (read_member_functions): Likewise.
8486         * valops.c (search_struct_method): Likewise.
8487         (value_struct_elt_for_reference): Likewise.
8488         * NEWS: Mention this change.
8489
8490 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
8491
8492         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
8493         print_source_lines.
8494         * source.c (print_source_lines_base): Update line number check.
8495         (print_source_lines): New function.
8496         (source_lines_range::source_lines_range): New function.
8497         * source.h (class source_lines_range): New class.
8498         (print_source_lines): New declaration.
8499
8500 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8501
8502         * linespec.c (linespec_state_destructor): Free self->canonical_names.
8503
8504 2019-01-08  Tom Tromey  <tom@tromey.com>
8505             Simon Marchi  <simon.marchi@ericsson.com>
8506
8507         PR gdb/24060
8508         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
8509         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
8510         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8511         * f-exp.y (DOLLAR_VARIABLE): Likewise.
8512         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
8513         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8514
8515 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8516
8517         * source.c (select_source_symtab): Move header comment to
8518         declaration in source.h.
8519         (forget_cached_source_info_for_objfile): Likewise.
8520         (forget_cached_source_info): Likewise.
8521         (identify_source_line): Likewise.
8522         * source.h (identify_source_line): Move declaration from symtab.h
8523         and add comment from source.c
8524         (print_source_lines): Likewise.
8525         (forget_cached_source_info_for_objfile): Likewise.
8526         (forget_cached_source_info): Likewise.
8527         (select_source_symtab): Likewise.
8528         (enum print_source_lines_flag): Move definition from symtab.h.
8529         * symtab.h (identify_source_line): Move declaration to source.h.
8530         (print_source_lines): Likewise.
8531         (forget_cached_source_info_for_objfile): Likewise.
8532         (forget_cached_source_info): Likewise.
8533         (select_source_symtab): Likewise.
8534         (enum print_source_lines_flag): Move definition to source.h.
8535         * tui/tui-hooks.c: Add 'source.h' include.
8536
8537 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8538
8539         * source.c (print_source_lines_base): Handle requests to print
8540         reverse line number sequences, and guard against empty lines
8541         string.
8542
8543 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8544
8545         * source.c (print_source_lines_base): Fix skip of '\r' if next
8546         character is '\n'.
8547
8548 2019-01-06  Tom Tromey  <tom@tromey.com>
8549
8550         * c-exp.y (struct c_parse_state) <macro_original_text,
8551         expansion_obstack>: New member.
8552         (macro_original_text, expansion_obstack): Remove globals.
8553         (scan_macro_expansion, scanning_macro_expansion)
8554         (finished_macro_expansion): Update.
8555         (scan_macro_cleanup): Remove.
8556         (yylex, c_parse): Update.
8557
8558 2019-01-06  Tom Tromey  <tom@tromey.com>
8559
8560         * c-exp.y (struct c_parse_state) <strings>: New member.
8561         (operator_stoken): Update.
8562
8563 2019-01-06  Tom Tromey  <tom@tromey.com>
8564
8565         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
8566         (union type_stack_elt) <typelist_val>: Now a pointer to
8567         std::vector.
8568         (type_stack_cleanup): Don't declare.
8569         (push_typelist): Update.
8570         * parse.c (pop_typelist): Return a std::vector.
8571         (push_typelist): Take a std::vector.
8572         (follow_types): Update.  Do not free args.
8573         (type_stack_cleanup): Remove.
8574         * c-exp.y (struct c_parse_state): New.
8575         (cpstate): New global.
8576         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
8577         (nonempty_typelist): Update.
8578         (func_mod): Create a new vector.
8579         (c_parse): Create a c_parse_state.
8580         (check_parameter_typelist): Do not delete params.
8581         (function_method): Update.  Do not delete type_list.
8582
8583 2019-01-06  Tom Tromey  <tom@tromey.com>
8584
8585         PR gdb/28155:
8586         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
8587         check_typedef.
8588         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
8589         (print_return_value): Likewise.
8590
8591 2019-01-05  Tom Tromey  <tom@tromey.com>
8592
8593         * contrib/cleanup_check.py: Remove.
8594         * contrib/gcc-with-excheck: Remove.
8595         * contrib/exsummary.py: Remove.
8596         * contrib/excheck.py: Remove.
8597
8598 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
8599
8600         * thread.c (delete_thread_1): Add gdb_assert that THR is not
8601         NULL. Initialize tpprev to NULL instead of assigning it
8602         to NULL on the next statement.
8603         * windows-nat.c (windows_delete_thread): Remove check for
8604         main_thread_id before printing thread exit notifications.
8605         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
8606         Remove thread ID check against main_thread_id.
8607         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
8608         windows_delete_thread.
8609         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
8610
8611 2019-01-04  Tom Tromey  <tom@tromey.com>
8612
8613         * compile/compile.c (_initialize_compile): Use upper case for
8614         metasyntactic variables.
8615         * symmisc.c (_initialize_symmisc): Use upper case for
8616         metasyntactic variables.
8617         * psymtab.c (_initialize_psymtab): Use upper case for
8618         metasyntactic variables.
8619         * demangle.c (demangle_command): Use upper case for metasyntactic
8620         variables.
8621         (_initialize_demangler): Likewise.
8622         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
8623         variables.
8624
8625 2019-01-03  Tom Tromey  <tom@tromey.com>
8626
8627         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
8628
8629 2019-01-03  Tom Tromey  <tom@tromey.com>
8630
8631         * python/py-symtab.c (salpy_str): Update.
8632         (struct salpy_sal_object) <symtab>: Now a PyObject.
8633         (salpy_dealloc): Update.
8634         (del_objfile_sal): Use gdbpy_ref.
8635
8636 2019-01-03  Tom Tromey  <tom@tromey.com>
8637
8638         * python/py-type.c (convert_field): Use new_reference.  Return
8639         gdbpy_ref.
8640         (make_fielditem): Return gdbpy_ref.
8641         (typy_fields): Update.
8642         (typy_getitem): Update.
8643         (field_name): Return gdbpy_ref.  Use new_reference.
8644         (typy_iterator_iternext): Update.
8645
8646 2019-01-03  Tom Tromey  <tom@tromey.com>
8647
8648         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
8649
8650 2019-01-03  Tom Tromey  <tom@tromey.com>
8651
8652         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
8653         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
8654         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
8655         (pspy_set_frame_filters, pspy_set_frame_unwinders)
8656         (pspy_set_type_printers): Likewise.
8657         * python/py-function.c (fnpy_init): Use gdbpy_ref.
8658         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
8659         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
8660         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
8661         (objfpy_set_type_printers): Likewise.
8662
8663 2019-01-03  Tom Tromey  <tom@tromey.com>
8664
8665         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
8666         (gdbpy_print_stack): Use gdbpy_err_fetch.
8667         * python/python-internal.h (class gdbpy_err_fetch): New class.
8668         (class gdbpy_enter) <m_error_type, m_error_value,
8669         m_error_traceback>: Remove.
8670         <m_error>: New member.
8671         (gdbpy_exception_to_string): Don't declare.
8672         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
8673         * python/py-value.c (convert_value_from_python): Use
8674         gdbpy_err_fetch.
8675         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
8676         gdbpy_exception_to_string.
8677         (gdbpy_handle_exception): Use gdbpy_err_fetch.
8678         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
8679         gdbpy_err_fetch.
8680
8681 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8682
8683         * linux-nat.c (delete_lwp_cleanup): Delete.
8684         (struct lwp_deleter): New struct.
8685         (lwp_info_up): New typedef.
8686         (linux_nat_target::follow_fork): Delete cleanup, and make use of
8687         lwp_info_up.
8688
8689 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8690
8691         * linux-fork.c (class scoped_switch_fork_info): New class.
8692         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
8693
8694 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8695
8696         * valops.c (find_overload_match): Remove use of null_cleanup, and
8697         calls to do_cleanups.
8698
8699 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8700
8701         * compile/compile-cplus-types.c
8702         (compile_cplus_instance::decl_name): Handle changes to
8703         cp_func_name.
8704         * cp-support.c (cp_func_name): Update header comment, update
8705         return type.
8706         * cp-support.h (cp_func_name): Update return type in declaration.
8707         * valops.c (find_overload_match): Move temp_func local to top
8708         level of function and change its type.  Use temp_func to hold and
8709         delete temporary string obtained from cp_func_name.
8710
8711 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8712
8713         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
8714         gdb::char_vector, remove cleanup, and update uses of `msg`.
8715
8716 2019-01-03  Jim Wilson  <jimw@sifive.com>
8717
8718         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
8719
8720 2019-01-02  Tom Tromey  <tom@tromey.com>
8721
8722         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
8723         (tdesc_parse_xml): Remove cleanups.
8724         * target-descriptions.h (make_cleanup_free_target_description):
8725         Don't declare.
8726         (target_desc_deleter): New struct.
8727         (target_desc_up): New typedef.
8728         * target-descriptions.c (target_desc_deleter::operator()): Rename
8729         from free_target_description.
8730         (make_cleanup_free_target_description): Remove.
8731
8732 2019-01-02  Tom Tromey  <tom@tromey.com>
8733
8734         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
8735         constructor, destructor.
8736         (linespec_parser): Remove typedef.
8737         (~linespec_parser): Rename from linespec_parser_delete.
8738         (linespec_lex_to_end, linespec_complete_label)
8739         (linespec_complete): Update.
8740         (decode_line_full): Remove cleanups.
8741         (decode_line_1): Update.
8742
8743 2019-01-02  Tom Tromey  <tom@tromey.com>
8744
8745         * python/python-internal.h (inferior_to_inferior_object): Change
8746         return type.
8747         * python/py-exitedevent.c (create_exited_event_object): Update.
8748         * python/py-inferior.c (inferior_to_inferior_object): Return
8749         gdbpy_ref.
8750         (python_new_inferior, python_inferior_deleted)
8751         (thread_to_thread_object, delete_thread_object)
8752         (build_inferior_list, gdbpy_selected_inferior): Update.
8753         * python/py-infthread.c (create_thread_object): Update.  Also fail
8754         if inferior_to_inferior_object fails.
8755
8756 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
8757
8758         * inferior.h (class inferior) <displaced_step_state>: New field.
8759         * infrun.h (struct displaced_step_state): Move here from
8760         infrun.c.  Initialize fields, add constructor.
8761         <inf>: Remove field.
8762         <reset>: New method.
8763         * infrun.c (struct displaced_step_inferior_state): Move to
8764         infrun.h.
8765         (displaced_step_inferior_states): Remove.
8766         (get_displaced_stepping_state): Adust.
8767         (displaced_step_in_progress_any_inferior): Adjust.
8768         (displaced_step_in_progress_thread): Adjust.
8769         (displaced_step_in_progress): Adjust.
8770         (add_displaced_stepping_state): Remove.
8771         (get_displaced_step_closure_by_addr): Adjust.
8772         (remove_displaced_stepping_state): Remove.
8773         (infrun_inferior_exit): Call displaced_step_state.reset.
8774         (use_displaced_stepping): Don't check for NULL.
8775         (displaced_step_prepare_throw): Call
8776         get_displaced_stepping_state.
8777         (displaced_step_fixup): Don't check for NULL.
8778         (prepare_for_detach): Don't check for NULL.
8779
8780 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8781
8782         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
8783          in case of call that did not complete.
8784
8785 2019-01-02  Andrey Utkin  <autkin@undo.io>
8786
8787         * symfile.c (find_separate_debug_file): Fix search of debug files for
8788         remote debuggee.
8789
8790 2019-01-02  Tom Tromey  <tom@tromey.com>
8791
8792         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
8793         indentation.
8794         * python/py-frame.c (frapy_older): Remove cast.
8795         (frapy_newer): Likewise.
8796         * python/py-breakpoint.c (local_setattro): Remove cast.
8797         * python/py-arch.c (archpy_name): Remove local variable.
8798         * python/py-type.c (gdbpy_lookup_type): Remove cast.
8799
8800 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
8801
8802         * unittests/basic_string_view/element_access/char/empty.cc:
8803         Fix year range in copyright header.
8804
8805 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8806
8807         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
8808         Delete.
8809         <operator==>: Update with for removed field.
8810         <hash>: Likewise.
8811         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
8812         <isa_features>: ...this.
8813         <abi_features>: New field.
8814         (riscv_isa_flen): Update comment.
8815         (riscv_abi_xlen): New declaration.
8816         (riscv_abi_flen): New declaration.
8817         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
8818         isa_features.
8819         (riscv_abi_xlen): New function.
8820         (riscv_isa_flen): Update to get answer from isa_features.
8821         (riscv_abi_flen): New function.
8822         (riscv_has_fp_abi): Update to get answer from abi_features.
8823         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
8824         xlen and flen.
8825         (riscv_call_info) <xlen, flen>: Update comment.
8826         (riscv_call_arg_struct): Remove invalid assertions
8827         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
8828         is removed.
8829         (riscv_gdbarch_init): Gather isa features and abi features
8830         separately, ensure both match on the gdbarch when reusing an old
8831         gdbarch.  Relax an error check to allow 32-bit abi float to run on
8832         a target with 64-bit float hardware.
8833
8834 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8835
8836         * source.c (search_command_helper): Stop reverse search
8837         when line 1 has been searched.
8838
8839 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8840
8841         * record-full.c (record_full_base_target::close): Rewrite
8842         record_full_core_buf_list free logic.
8843
8844 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8845
8846         * break-catch-syscall.c (print_one_catch_syscall): xfree
8847         the last text.
8848
8849 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8850
8851         * top.c (print_gdb_version): Update Copyright year in version
8852         message.
8853
8854 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8855
8856         Update copyright year range in all GDB files.
8857
8858 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
8859
8860         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
8861
8862 For older changes see ChangeLog-2018.
8863 \f
8864 Local Variables:
8865 mode: change-log
8866 left-margin: 8
8867 fill-column: 74
8868 version-control: never
8869 coding: utf-8
8870 End:
8871