gdb/ChangeLog

   1 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
   2
   3         * NEWS: Move entries about default MI version now being
   4         version 3, and about the GDB/MI fix for multi-location
   5         breakpoints to the "since GDB 8.3" section.
   6
   7 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
   8
   9         GDB 8.3.1 released.
  10
  11 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
  12
  13         * NEWS: Mention that Cell/B.E. debugging support was removed.
  14         * MAINTAINERS: Remove spu target.
  15
  16         * config/djgpp/fnchange.lst: Remove entries for removed files.
  17
  18         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
  19         spu-multiarch.o, and spu-tdep.o.
  20         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
  21         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
  22         spu-multiarch.c, and spu-tdep.c.
  23         * spu-linux-nat.c: Remove file.
  24         * spu-multiarch.c: Remove file.
  25         * spu-tdep.c: Remove file.
  26         * spu-tdep.h: Remove file.
  27         * solib-spu.c: Remove file.
  28         * solib-spu.h: Remove file.
  29
  30         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
  31         * configure.nat (spu-linux): Remove.
  32         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
  33         solib-multiarch.o from gdb_target_obs.
  34         (spu*-*-*): Remove.
  35
  36         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
  37         feature flag.
  38         (ppc_linux_no_features): Update.
  39         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
  40         Cell/B.E. support.
  41         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
  42         (tdesc_powerpc_cell64l): Likewise.
  43         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
  44         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
  45         Cell/B.E. support.
  46         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
  47         Do not include "features/rs6000/powerpc-cell32l.c" or
  48         "features/rs6000/powerpc-cell64l.c".
  49         (ppc_linux_spu_section): Remove.
  50         (ppc_linux_core_read_description): Remove Cell/B.E. support.
  51         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
  52         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
  53         (ppc_linux_spe_context_lookup): Remove.
  54         (ppc_linux_spe_context_inferior_created): Remove.
  55         (ppc_linux_spe_context_solib_loaded): Remove.
  56         (ppc_linux_spe_context_solib_unloaded): Remove.
  57         (ppc_linux_spe_context): Remove.
  58         (struct ppu2spu_cache): Remove.
  59         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
  60         (struct ppu2spu_data): Remove.
  61         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
  62         ppu2spu_unwind): Remove.
  63         (ppc_linux_init_abi): Remove Cell/B.E. support.
  64         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
  65
  66         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
  67         (rs6000/powerpc-cell64l-expedite): Likewise
  68         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
  69         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
  70         rs6000/powerpc-cell64l.xml.
  71         * features/rs6000/powerpc-cell32l.xml: Remove.
  72         * features/rs6000/powerpc-cell64l.xml: Likewise.
  73         * features/rs6000/powerpc-cell32l.c: Remove generated file.
  74         * features/rs6000/powerpc-cell64l.c: Likewise.
  75         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
  76         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
  77         * regformats/reg-spu.dat: Remove.
  78
  79         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
  80         * corelow.c (struct spuid_list): Remove.
  81         (add_to_spuid_list): Remove.
  82         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
  83         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
  84         (remote_protocol_features): Remove associated entries.
  85         (_initialize_remote): No longer initialize them.
  86         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
  87         * linux-nat.c (SPUFS_MAGIC): Remove.
  88         (linux_proc_xfer_spu): Remove.
  89         (spu_enumerate_spu_ids): Remove.
  90         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
  91         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
  92         (linux_make_corefile_notes): No longer call it.
  93
  94         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
  95         (cooked_write_test): Likewise.
  96
  97 2019-09-20  Tom Tromey  <tom@tromey.com>
  98
  99         * NEWS: Mention case-sensitivity of TUI commands.
 100         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
 101         (tui_set_win_height_command, parse_scrolling_args): Likewise.
 102         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
 103
 104 2019-09-20  Tom Tromey  <tom@tromey.com>
 105
 106         * tui/tui-source.c (tui_source_window::set_contents): Use
 107         make_unique_xstrdup.
 108         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
 109         make_unique_xstrdup.
 110
 111 2019-09-20  Tom Tromey  <tom@tromey.com>
 112
 113         * tui/tui-data.c: Remove separator comments.
 114         * tui/tui-layout.c: Remove separator comments.
 115         * tui/tui-win.c: Remove separator comments.
 116         * tui/tui-wingeneral.c: Remove separator comments.
 117
 118 2019-09-20  Tom Tromey  <tom@tromey.com>
 119
 120         * tui/tui.h (strcat_to_buf): Don't declare.
 121         * tui/tui.c (strcat_to_buf): Remove.
 122
 123 2019-09-20  Tom Tromey  <tom@tromey.com>
 124
 125         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
 126         from "fullname".
 127         * tui/tui-source.c (tui_source_window::set_contents)
 128         (tui_source_window::location_matches_p)
 129         (tui_source_window::maybe_update): Update.
 130
 131 2019-09-20  Tom Tromey  <tom@tromey.com>
 132
 133         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
 134         Update.
 135         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
 136         prefix.
 137         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 138         (tui_data_window::line_from_reg_element_no)
 139         (tui_data_window::first_reg_element_no_inline)
 140         (tui_data_window::show_registers)
 141         (tui_data_window::show_register_group)
 142         (tui_data_window::display_registers_from)
 143         (tui_data_window::display_registers_from_line)
 144         (tui_data_window::first_data_item_displayed)
 145         (tui_data_window::delete_data_content_windows)
 146         (tui_data_window::erase_data_content)
 147         (tui_data_window::do_scroll_vertical)
 148         (tui_data_window::refresh_window)
 149         (tui_data_window::check_register_values): Update.
 150
 151 2019-09-20  Tom Tromey  <tom@tromey.com>
 152
 153         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
 154         (struct tui_locator_window) <full_name, proc_name>: Now
 155         std::string.
 156         * tui/tui-stack.c (tui_locator_window::make_status_line)
 157         (tui_locator_window::set_locator_fullname)
 158         (tui_locator_window::set_locator_info): Update.
 159         * tui/tui-source.c (tui_source_window::set_contents)
 160         (tui_source_window::showing_source_p): Update.
 161
 162 2019-09-20  Tom Tromey  <tom@tromey.com>
 163
 164         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
 165         Don't call tui_locator_win_info_ptr.
 166
 167 2019-09-20  Tom Tromey  <tom@tromey.com>
 168
 169         * tui/tui-win.c (tui_resize_all): Don't call refresh.
 170
 171 2019-09-20  Tom Tromey  <tom@tromey.com>
 172
 173         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
 174         height for locator.
 175         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
 176         * tui/tui-layout.c (show_source_disasm_command, show_data)
 177         (show_source_or_disasm_and_command): Use 1 as height for locator.
 178
 179 2019-09-20  Tom Tromey  <tom@tromey.com>
 180
 181         * tui/tui.c (tui_enable): Update.
 182         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
 183         Update.
 184         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
 185         Update.
 186         * tui/tui-data.c (win_resized): Now bool.
 187         (tui_win_resized): Return bool.
 188         (tui_set_win_resized_to): Accept a bool.
 189
 190 2019-09-20  Tom Tromey  <tom@tromey.com>
 191
 192         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
 193         Change type of "refresh_values_only".
 194         * tui/tui-regs.c (tui_data_window::show_register_group): Change
 195         type of "refresh_values_only".
 196
 197 2019-09-20  Tom Tromey  <tom@tromey.com>
 198
 199         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
 200         std::string.
 201         (tui_disassemble): Add "pos" parameter.
 202         (tui_disasm_window::set_contents): Simplify.
 203
 204 2019-09-20  Tom Tromey  <tom@tromey.com>
 205
 206         * tui/tui-winsource.h (struct tui_source_window_base)
 207         <show_source_content>: Now private.
 208         * tui/tui-winsource.c
 209         (tui_source_window_base::show_source_content): Don't handle empty
 210         content case.
 211
 212 2019-09-20  Tom Tromey  <tom@tromey.com>
 213
 214         * tui/tui-layout.c (show_source_disasm_command)
 215         (show_source_or_disasm_and_command): Don't call
 216         show_source_content.
 217
 218 2019-09-20  Tom Tromey  <tom@tromey.com>
 219
 220         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
 221         Declare.
 222         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
 223         from tui_make_status_line.
 224         (tui_locator_window::rerender): Update.
 225
 226 2019-09-20  Tom Tromey  <tom@tromey.com>
 227
 228         * tui/tui-stack.c (tui_make_status_line): Return std::string.
 229         (tui_locator_window::rerender): Update.
 230
 231 2019-09-20  Tom Tromey  <tom@tromey.com>
 232
 233         * tui/tui-winsource.h (struct tui_source_window_base)
 234         <~tui_source_window_base>: Don't declare.
 235         <fullname>: Remove.
 236         * tui/tui-winsource.c (~tui_source_window_base): Remove.
 237         * tui/tui-source.h (struct tui_source_window) <fullname>: New
 238         member.
 239         * tui/tui-source.c (tui_source_window::set_contents): Update.
 240         (tui_source_window::location_matches_p)
 241         (tui_source_window::maybe_update): Update.
 242
 243 2019-09-20  Tom Tromey  <tom@tromey.com>
 244
 245         * tui/tui-winsource.h (~tui_source_element): Remove.
 246         (tui_source_element): Update.
 247         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
 248         * tui/tui-winsource.c (tui_show_source_line): Update.
 249         * tui/tui-source.c (tui_source_window::set_contents): Update.
 250         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 251
 252 2019-09-20  Tom Tromey  <tom@tromey.com>
 253
 254         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
 255         declare.
 256         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
 257         tui_clear_source_windows_detail.
 258         * tui/tui-winsource.h (struct tui_source_window_base)
 259         <clear_detail>: Don't declare.
 260         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
 261         Remove.
 262         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
 263
 264 2019-09-20  Tom Tromey  <tromey@adacore.com>
 265
 266         PR ada/24919:
 267         * block.c (contained_in): Fix final return value.
 268
 269 2019-09-20  Alan Modra  <amodra@gmail.com>
 270
 271         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
 272         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
 273         (read_indirect_string_from_dwz): Use bfd accessor.
 274         * dwarf2read.h (struct dwz_file <filename>): Likewise.
 275         * machoread.c (macho_symfile_read_all_oso): Likewise.
 276         * solib.c (solib_bfd_open): Likewise.
 277
 278 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 279
 280         * eval.c: Move declaration of overload_resolution to...
 281         * value.h: ...here.
 282
 283 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 284
 285         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
 286         * arm-linux-tdep.c: Likewise.
 287         * arm-nbsd-nat.c: Likewise.
 288         * arm-tdep.h: Declare arm_apcs_32.
 289         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
 290
 291 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 292
 293         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
 294         * dwarf2read.h: Declare dwarf_always_disassemble.
 295
 296 2019-09-19  Tom de Vries  <tdevries@suse.de>
 297
 298         PR gdb/25009
 299         * source-cache.c (source_cache::ensure): Catch exception thrown during
 300         construction of the highlighter.
 301
 302 2019-09-18  Alan Modra  <amodra@gmail.com>
 303
 304         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
 305         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
 306         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
 307         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
 308         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
 309         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
 310         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
 311         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
 312         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
 313         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
 314         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
 315         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
 316         * solib-spu.c, * solib-svr4.c, * solib-target.c,
 317         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
 318         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
 319         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
 320         * mi/mi-interp.c: Update throughout for bfd section macro and
 321         function changes.
 322         * gcore (gcore_create_callback): Use bfd_set_section_lma.
 323         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
 324
 325 2019-09-18  Tom Tromey  <tom@tromey.com>
 326
 327         * NEWS: Add entry.
 328         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
 329         call rl_initialize.
 330         (tui_enable): Do not call rl_initialize.
 331
 332 2019-09-18  Christian Groessler  <chris@groessler.org>
 333
 334         * alpha-linux-nat.c: Include gdbarch.h.
 335
 336 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
 337
 338         * ui-file.c: Include cli/cli-style.h.
 339         (term_cli_styling): Remove cli_styling declaration.
 340
 341 2019-09-18  Alan Modra  <amodra@gmail.com>
 342
 343         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
 344         to bfd_asymbol_section.
 345
 346 2019-09-18  Alan Modra  <amodra@gmail.com>
 347
 348         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
 349         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
 350         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
 351
 352 2019-09-18  Alan Modra  <amodra@gmail.com>
 353
 354         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
 355         * spu-linux-nat.c (spu_bfd_open): Likewise.
 356
 357 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
 358
 359         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
 360         to bool to match definition in dwarf2read.c.
 361
 362 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
 363
 364         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
 365         (print_signatures): Likewise.
 366         (trust_pad_over_xvs): Likewise.
 367         * arch/aarch64-insn.c (aarch64_debug): Likewise.
 368         * arch/aarch64-insn.h (aarch64_debug): Likewise.
 369         * arm-linux-nat.c (arm_apcs_32): Likewise.
 370         * arm-linux-tdep.c (arm_apcs_32): Likewise.
 371         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
 372         * arm-tdep.c (arm_debug): Likewise.
 373         (arm_apcs_32): Likewise.
 374         * auto-load.c (debug_auto_load): Likewise.
 375         (auto_load_gdb_scripts): Likewise.
 376         (global_auto_load): Likewise.
 377         (auto_load_local_gdbinit): Likewise.
 378         (auto_load_local_gdbinit_loaded): Likewise.
 379         * auto-load.h (global_auto_load): Likewise.
 380         (auto_load_local_gdbinit): Likewise.
 381         (auto_load_local_gdbinit_loaded): Likewise.
 382         * breakpoint.c (disconnected_dprintf): Likewise.
 383         (breakpoint_proceeded): Likewise.
 384         (automatic_hardware_breakpoints): Likewise.
 385         (always_inserted_mode): Likewise.
 386         (target_exact_watchpoints): Likewise.
 387         (_initialize_breakpoint): Update.
 388         * breakpoint.h (target_exact_watchpoints): Change to bool.
 389         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
 390         * cli/cli-cmds.c (trace_commands): Likewise.
 391         * cli/cli-cmds.h (trace_commands): Likewise.
 392         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
 393         to bool*.
 394         * cli/cli-logging.c (logging_overwrite): Change to bool.
 395         (logging_redirect): Likewise.
 396         (debug_redirect): Likewise.
 397         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
 398         (struct boolean_option_def) <get_var_address_cb_>: Change return type
 399         to bool.
 400         <boolean_option_def>: Update.
 401         (struct flag_option_def): Change default type of Context to bool
 402         from int.
 403         <flag_option_def>: Change return type of var_address_cb_ to bool*.
 404         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
 405         (get_setshow_command_value_string): Likewise.
 406         * cli/cli-style.c (cli_styling): Change to bool.
 407         (source_styling): Likewise.
 408         * cli/cli-style.h (source_styling): Likewise.
 409         (cli_styling): Likewise.
 410         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
 411         to bool.
 412         * command.h (var_types): Update comment.
 413         (add_setshow_boolean_cmd): Change int* var argument to bool*.
 414         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
 415         bool.
 416         (debug_compile_cplus_scopes): Likewise.
 417         * compile/compile-internal.h (compile_debug): Likewise.
 418         * compile/compile.c (compile_debug): Likewise.
 419         (struct compile_options) <raw>: Likewise.
 420         * cp-support.c (catch_demangler_crashes): Likewise.
 421         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
 422         (usr_cmd_cris_dwarf2_cfi): Likewise.
 423         * csky-tdep.c (csky_debug): Likewise.
 424         * darwin-nat.c (enable_mach_exceptions): Likewise.
 425         * dcache.c (dcache_enabled_p): Likewise.
 426         * defs.h (info_verbose): Likewise.
 427         * demangle.c (demangle): Likewise.
 428         (asm_demangle): Likewise.
 429         * dwarf-index-cache.c (debug_index_cache): Likewise.
 430         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
 431         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
 432         * dwarf2read.c (check_physname): Likewise.
 433         (use_deprecated_index_sections): Likewise.
 434         (dwarf_always_disassemble): Likewise.
 435         * eval.c (overload_resolution): Likewise.
 436         * event-top.c (set_editing_cmd_var): Likewise.
 437         (exec_done_display_p): Likewise.
 438         * event-top.h (set_editing_cmd_var): Likewise.
 439         (exec_done_display_p): Likewise.
 440         * exec.c (write_files): Likewise.
 441         * fbsd-nat.c (debug_fbsd_lwp): Likewise
 442         (debug_fbsd_nat): Likewise.
 443         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
 444         Likewise.
 445         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
 446         <backtrace_past_entry> Likewise.
 447         * gdb-demangle.h (demangle): Likewise.
 448         (asm_demangle): Likewise.
 449         * gdb_bfd.c (bfd_sharing): Likewise.
 450         * gdbcore.h (write_files): Likewise.
 451         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
 452         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
 453         * gdbthread.h (print_thread_events): Likewise.
 454         * gdbtypes.c (opaque_type_resolution): Likewise.
 455         (strict_type_checking): Likewise.
 456         * gnu-nat.c (gnu_debug_flag): Likewise.
 457         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
 458         * guile/scm-param.c (pascm_variable): Add boolval.
 459         (add_setshow_generic): Update.
 460         (pascm_param_value): Update.
 461         (pascm_set_param_value_x): Update.
 462         * hppa-tdep.c (hppa_debug): Change to bool..
 463         * infcall.c (may_call_functions_p): Likewise.
 464         (coerce_float_to_double_p): Likewise.
 465         (unwind_on_signal_p): Likewise.
 466         (unwind_on_terminating_exception_p): Likewise.
 467         * infcmd.c (startup_with_shell): Likewise.
 468         * inferior.c (print_inferior_events): Likewise.
 469         * inferior.h (startup_with_shell): Likewise.
 470         (print_inferior_events): Likewise.
 471         * infrun.c (step_stop_if_no_debug): Likewise.
 472         (detach_fork): Likewise.
 473         (debug_displaced): Likewise.
 474         (disable_randomization): Likewise.
 475         (non_stop): Likewise.
 476         (non_stop_1): Likewise.
 477         (observer_mode): Likewise.
 478         (observer_mode_1): Likewise.
 479         (set_observer_mode): Update.
 480         (sched_multi): Change to bool.
 481         * infrun.h (debug_displaced): Likewise.
 482         (sched_multi): Likewise.
 483         (step_stop_if_no_debug): Likewise.
 484         (non_stop): Likewise.
 485         (disable_randomization): Likewise.
 486         * linux-tdep.c (use_coredump_filter): Likewise.
 487         (dump_excluded_mappings): Likewise.
 488         * linux-thread-db.c (auto_load_thread_db): Likewise.
 489         (check_thread_db_on_load): Likewise.
 490         * main.c (captured_main_1): Update.
 491         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
 492         xx2_opt, boolean_opt>: Change to bool.
 493         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
 494         * maint.c (maintenance_profile_p): Likewise.
 495         (per_command_time): Likewise.
 496         (per_command_space): Likewise.
 497         (per_command_symtab): Likewise.
 498         * memattr.c (inaccessible_by_default): Likewise.
 499         * mi/mi-main.c (mi_async): Likewise.
 500         (mi_async_1): Likewise.
 501         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
 502         * nat/fork-inferior.h (startup_with_shell): Likewise.
 503         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
 504         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
 505         * nios2-tdep.c (nios2_debug): Likewise.
 506         * or1k-tdep.c (or1k_debug): Likewise.
 507         * parse.c (parser_debug): Likewise.
 508         * parser-defs.h (parser_debug): Likewise.
 509         * printcmd.c (print_symbol_filename): Likewise.
 510         * proc-api.c (procfs_trace): Likewise.
 511         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
 512         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
 513         (set_parameter_value): Update.
 514         (add_setshow_generic): Update.
 515         * python/py-value.c (copy_py_bool_obj): Change argument from int*
 516         to bool*.
 517         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
 518         int*.
 519         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
 520         * record-btrace.c (record_btrace_target::store_registers): Update.
 521         * record-full.c (record_full_memory_query): Change to bool.
 522         (record_full_stop_at_limit): Likewise.
 523         * record-full.h (record_full_memory_query): Likewise.
 524         * remote-notif.c (notif_debug): Likewise.
 525         * remote-notif.h (notif_debug): Likewise.
 526         * remote.c (use_range_stepping): Likewise.
 527         (interrupt_on_connect): Likewise.
 528         (remote_break): Likewise.
 529         * ser-tcp.c (tcp_auto_retry): Likewise.
 530         * ser-unix.c (serial_hwflow): Likewise.
 531         * skip.c (debug_skip): Likewise.
 532         * solib-aix.c (solib_aix_debug): Likewise.
 533         * spu-tdep.c (spu_stop_on_load_p): Likewise.
 534         (spu_auto_flush_cache_p): Likewise.
 535         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
 536         Likewise.
 537         (struct info_print_options) <quiet>: Likewise.
 538         * symfile-debug.c (debug_symfile): Likewise.
 539         * symfile.c (auto_solib_add): Likewise.
 540         (separate_debug_file_debug): Likewise.
 541         * symfile.h (auto_solib_add): Likewise.
 542         (separate_debug_file_debug): Likewise.
 543         * symtab.c (basenames_may_differ): Likewise.
 544         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
 545         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
 546         (struct info_types_options) <quiet>: Likewise.
 547         * symtab.h (demangle): Likewise.
 548         (basenames_may_differ): Likewise.
 549         * target-dcache.c (stack_cache_enabled_1): Likewise.
 550         (code_cache_enabled_1): Likewise.
 551         * target.c (trust_readonly): Likewise.
 552         (may_write_registers): Likewise.
 553         (may_write_memory): Likewise.
 554         (may_insert_breakpoints): Likewise.
 555         (may_insert_tracepoints): Likewise.
 556         (may_insert_fast_tracepoints): Likewise.
 557         (may_stop): Likewise.
 558         (auto_connect_native_target): Likewise.
 559         (target_stop_and_wait): Update.
 560         (target_async_permitted): Change to bool.
 561         (target_async_permitted_1): Likewise.
 562         (may_write_registers_1): Likewise.
 563         (may_write_memory_1): Likewise.
 564         (may_insert_breakpoints_1): Likewise.
 565         (may_insert_tracepoints_1): Likewise.
 566         (may_insert_fast_tracepoints_1): Likewise.
 567         (may_stop_1): Likewise.
 568         * target.h (target_async_permitted): Likewise.
 569         (may_write_registers): Likewise.
 570         (may_write_memory): Likewise.
 571         (may_insert_breakpoints): Likewise.
 572         (may_insert_tracepoints): Likewise.
 573         (may_insert_fast_tracepoints): Likewise.
 574         (may_stop): Likewise.
 575         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
 576         (make_thread_apply_all_options_def_group): Change argument from int*
 577         to bool*.
 578         (thread_apply_all_command): Update.
 579         (print_thread_events): Change to bool.
 580         * top.c (confirm): Likewise.
 581         (command_editing_p): Likewise.
 582         (history_expansion_p): Likewise.
 583         (write_history_p): Likewise.
 584         (info_verbose): Likewise.
 585         * top.h (confirm): Likewise.
 586         (history_expansion_p): Likewise.
 587         * tracepoint.c (disconnected_tracing): Likewise.
 588         (circular_trace_buffer): Likewise.
 589         * typeprint.c (print_methods): Likewise.
 590         (print_typedefs): Likewise.
 591         * utils.c (debug_timestamp): Likewise.
 592         (sevenbit_strings): Likewise.
 593         (pagination_enabled): Likewise.
 594         * utils.h (sevenbit_strings): Likewise.
 595         (pagination_enabled): Likewise.
 596         * valops.c (overload_resolution): Likewise.
 597         * valprint.h (struct value_print_options) <prettyformat_arrays,
 598         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
 599         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
 600         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
 601         Likewise.
 602         * windows-nat.c (new_console): Likewise.
 603         (cygwin_exceptions): Likewise.
 604         (new_group): Likewise.
 605         (debug_exec): Likewise.
 606         (debug_events): Likewise.
 607         (debug_memory): Likewise.
 608         (debug_exceptions): Likewise.
 609         (useshell): Likewise.
 610         * windows-tdep.c (maint_display_all_tib): Likewise.
 611         * xml-support.c (debug_xml): Likewise.
 612
 613 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
 614
 615         * source.c (prepare_path_for_appending): New function.
 616         (openp): Make use of new function.
 617         (find_and_open_source): Search for the compilation directory and
 618         source file as a relative path beneath the directory search path.
 619
 620 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 621
 622         * source-cache.c (source_cache::get_line_charpos): Catch
 623         exceptions and return false, this matches the behaviour documented
 624         in the header file.
 625
 626 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
 627
 628         * ada-tasks.c (info_task): Remove quoting of the task's name.
 629
 630 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
 631
 632         * symfile.c (auto_solib_add): Replace comment with a reference
 633         to the header file.
 634
 635 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
 636
 637         * NEWS: Mention that gdb can now be compiled with Python 3
 638         on Windows.
 639
 640 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 641
 642         * maint.c (maint_print_section_data::maint_print_section_data):
 643         Force use of 'float log10 (float)' by casting the argument to
 644         float.
 645
 646 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 647
 648         * maint.c: Add 'cmath' include.
 649         (struct maint_print_section_data): New structure.
 650         (print_section_index): New function.
 651         (print_bfd_section_info): Add header comment, small whitespace
 652         cleanup, and update to call new print_section_index function.
 653         (print_objfile_section_info): Likewise.
 654         (maint_obj_section_from_bfd_section): New function.
 655         (print_bfd_section_info_maybe_relocated): New function.
 656         (maintenance_info_sections): Add header comment, always use
 657         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
 658
 659 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 660
 661         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
 662         inner scope, add check that the objfile has psymtabs before
 663         checking psymtabs_addrmap.
 664         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
 665
 666 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 667
 668         * NEWS: Announce that Ada task names are now shown at more places,
 669         and between quotes (except in info task output).
 670         * gdb/ada-tasks.c (task_to_str): New function.
 671         (display_current_task_id): Call task_to_str.
 672         (task_command_1): Likewise.
 673         (print_ada_task_info): In non-mi mode, Properly align headers and data
 674         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
 675
 676 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 677
 678         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
 679         prstatus.pr_lwp.pr_info instead of making it up.
 680
 681 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 682
 683         * auto-load.c (auto_load_expand_dir_vars): Update.
 684         * defs.h (gdb_datadir): Change to std::string.
 685         (python_libdir): Likewise.
 686         (relocate_gdb_directory): Change return type to std::string.
 687         * guile/guile.c (gdbscm_data_directory): Update.
 688         (initialize_scheme_side): Update.
 689         * jit.c (jit_reader_dir): Change to std::string.
 690         (jit_reader_load_command): Update.
 691         * main.c (gdb_datadir): Change to std::string.
 692         (python_libdir): Likewise.
 693         (set_gdb_data_directory): Update.
 694         (relocate_path): Change to return std::string.
 695         (relocate_gdb_directory): Change to return std::string.
 696         (relocate_gdbinit_path_maybe_in_datadir): Update.
 697         (captured_main_1): Update.
 698         * python/python.c (do_start_initialization): Update.
 699         * top.c (show_gdb_datadir): Update.
 700         * xml-syscall.c (xml_init_syscalls_info): Update.
 701         (init_syscalls_info): Update.
 702
 703 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 704
 705         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
 706         out of get_init_files.
 707         (get_init_files): Update.
 708
 709 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 710
 711         * main.c (get_init_files): Change to use std::string.
 712         (captured_main_1): Update.
 713         (print_gdb_help): Update.
 714
 715 2019-09-11  Ali Tamur  <tamur@google.com>
 716
 717         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
 718         implementation.
 719
 720 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 721
 722         * dbxread.c (read_dbx_symtab): Update.
 723         * dwarf2read.c (load_partial_dies): Update.
 724         * mdebugread.c (parse_partial_symbols): Update.
 725         (handle_psymbol_enumerators): Update.
 726         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
 727         * psymtab.c (add_psymbol_to_bcache): Likewise.
 728         (add_psymbol_to_list): Likewise.
 729         * symtab.c (symbol_set_names): Likewise.
 730         * symtab.h (symbol_set_names): Likewise.
 731         * xcoffread.c (scan_xcoff_symtab): Update.
 732
 733 2019-09-11  Tom Tromey  <tom@tromey.com>
 734
 735         * symfile-mem.c (symbol_file_add_from_memory): Use
 736         bfd_set_filename.
 737         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
 738         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
 739
 740 2019-09-10  Tom Tromey  <tromey@adacore.com>
 741
 742         * dwarf-index-write.c (write_psymbols): Extend error message.
 743         (debug_names::insert): Add Ada code.
 744         (debug_names::write_psymbols): Remove Ada check.
 745         (debug_names) <m_string_obstack>: New member.
 746         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
 747         (gdb_index_symbol_name_matcher::matches): Remove.
 748         (mapped_index_base::find_name_components_bounds): Add "lang"
 749         parameter.
 750         (mapped_index_base::build_name_components): Also split names
 751         according to Ada syntax.
 752         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
 753         type of "match_callback".
 754         (check_match, check_find_bounds_finds)
 755         (dw2_expand_symtabs_matching): Update.
 756         (dw2_debug_names_iterator): Add new constructor.
 757         (dw2_debug_names_map_matching_symbols): New function.
 758         (dw2_debug_names_expand_symtabs_matching): Update.
 759         (dwarf2_debug_names_functions): Use
 760         dw2_debug_names_map_matching_symbols.
 761
 762 2019-09-10  Tom Tromey  <tromey@adacore.com>
 763
 764         * dwarf2read.c (dw2_get_file_names_reader): Add the
 765         CU's file name to the results.
 766
 767 2019-09-10  Tom Tromey  <tromey@adacore.com>
 768
 769         * ada-lang.c (add_nonlocal_symbols): Combine calls to
 770         map_matching_symbols.  Update.
 771         * dwarf2read.c (dw2_map_matching_symbols): Update.
 772         * psymtab.c (match_partial_symbol): Change type; update.
 773         (psym_map_matching_symbols): Likewise.
 774         * symfile-debug.c (debug_qf_map_matching_symbols): Change
 775         type; update.
 776         * symfile.h (struct quick_symbol_functions)
 777         <map_matching_symbols>: Change "name" to be a lookup_name_info.
 778         Remove "match".
 779
 780 2019-09-10  Tom Tromey  <tromey@adacore.com>
 781
 782         * psymtab.c (map_block): Remove.
 783         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
 784         * symtab.c (iterate_over_symbols_terminated): New function.
 785         * symtab.c (iterate_over_symbols_terminated): Declare.
 786
 787 2019-09-10  Tom Tromey  <tromey@adacore.com>
 788
 789         * ada-lang.c (ada_iterate_over_symbols): Return bool.
 790         * language.h (struct language_defn) <la_iterate_over_symbols>:
 791         Return bool.
 792         * symtab.c (iterate_over_symbols): Return bool.
 793         * symtab.h (iterate_over_symbols): Return bool.
 794
 795 2019-09-10  Tom Tromey  <tromey@adacore.com>
 796
 797         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
 798         (add_nonlocal_symbols): Update.
 799         * dwarf2read.c (dw2_map_matching_symbols): Change type.
 800         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
 801         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
 802         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
 803         Change type of "callback".  Remove "data".
 804
 805
 806 2019-09-09  Ali Tamur  <tamur@google.com>
 807
 808         * dwarf2read.c (comp_unit_head): Update comment.
 809         (dwarf2_dwo_name): New function declaration.
 810         (dwarf_unit_type_name): New function declaration.
 811         (read_comp_unit_head): Add support for new compilation units,
 812         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
 813         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
 814         (currently named as "signature") in their header. Also clarify error
 815         messages.
 816         (lookup_dwo_id): New function. Returns the dwo id of the given
 817         compile unit.
 818         (lookup_dwo_unit): Use the new lookup_dwo_id function.
 819         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
 820         functions.
 821         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
 822         (dwarf2_dwo_name): Get the dwo name if present.
 823         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
 824         purposes.
 825
 826 2019-09-09  Tom Tromey  <tom@tromey.com>
 827
 828         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
 829
 830 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 831
 832         * python/python.c (do_start_initialization): Make progname_copy static,
 833         to avoid a leak report.
 834
 835 2019-09-08  Tom Tromey  <tom@tromey.com>
 836
 837         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
 838
 839 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
 840
 841         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
 842         Change type to gdb::optional<block_enum>.
 843         (dw2_symtab_iter_init): Change block_index parameter type
 844         to gdb::optional<block_enum>.
 845         (dw2_lookup_symbol): Change block_index parameter
 846         type to block_enum.c
 847         (dw2_debug_names_lookup_symbol): Likewise.
 848         * psymtab.c (psym_lookup_symbol): Likewise.
 849         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
 850         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
 851         Likewise.
 852
 853 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
 854
 855         * defs.h (relocate_gdb_directory): Change int to bool in
 856         signature and rename flag to relocatable.
 857         * main.c (relocate_path): Likewise.
 858         (relocate_gdb_directory): Likewise.
 859
 860 2019-09-06  Alan Modra  <amodra@gmail.com>
 861
 862         * coffread.c (coff_symfile_read): Constify filename variable.
 863         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
 864         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
 865         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
 866         * solib.c (reload_shared_libraries_1): Likewise.
 867         * symfile.c (reread_symbols): Likewise.
 868         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
 869         * solib-darwin.c (darwin_bfd_open): Likewise.
 870         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
 871
 872 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 873
 874         * psymtab.c (print_partial_symbols): Handle missing domain_enum
 875         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
 876
 877 2019-09-03  Tom Tromey  <tromey@adacore.com>
 878
 879         * ada-valprint.c (ada_val_print_num): Don't recurse for range
 880         types.
 881         (has_negatives): Unbias a range type bound.
 882         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
 883         * gdbtypes.c (operator==): Handle new field.
 884         (create_range_type): Add "bias" parameter.
 885         (create_static_range_type, resolve_dynamic_range): Update.
 886         * gdbtypes.h (struct range_bounds) <bias>: New member.
 887         (create_range_type): Add bias parameter.
 888         * printcmd.c (print_scalar_formatted): Unbias range types.
 889         * value.c (unpack_long): Unbias range types.
 890         (pack_long): Bias range types.
 891
 892 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 893
 894         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
 895         probe arguments.
 896
 897 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 898
 899         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
 900         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
 901         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
 902         (compile_probe_arg): Likewise.
 903         * probe.h (get_argument_count): Likewise.
 904         * solib-svr4.c (solib_event_probe_action): Likewise.
 905         * stap-probe.c (stap_probe::get_argument_count): Likewise.
 906
 907 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 908
 909         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
 910         code to here...
 911         (svr4_create_solib_event_breakpoints): ...from here.
 912
 913 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
 914
 915         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
 916         suffix from warning message.
 917
 918 2019-08-30  Tom Tromey  <tom@tromey.com>
 919
 920         * tui/tui-winsource.h (struct tui_source_window_base)
 921         <refresh_all>: Don't declare.
 922         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
 923         Remove.
 924         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
 925         tui_show_locator_content.
 926         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
 927         declare.
 928         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
 929         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
 930         declare.
 931
 932 2019-08-30  Tom Tromey  <tom@tromey.com>
 933
 934         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
 935
 936 2019-08-30  Tom Tromey  <tom@tromey.com>
 937
 938         * tui/tui-stack.c (_initialize_tui_stack): Move later.
 939         Remove unnecessary forward declarations.
 940
 941 2019-08-30  Tom Tromey  <tom@tromey.com>
 942
 943         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
 944         rerender.
 945         (tui_update_locator_fullname, tui_show_frame_info): Don't call
 946         tui_show_locator_content.
 947
 948 2019-08-30  Tom Tromey  <tom@tromey.com>
 949
 950         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
 951         (tui_locator_window::rerender): Rewrite using body of previous
 952         tui_show_locator_content.
 953
 954 2019-08-30  Tom Tromey  <tom@tromey.com>
 955
 956         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
 957         set_locator_fullname>: New methods.
 958         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
 959         Rename from tui_set_locator_fullname.
 960         (tui_locator_window::set_locator_info): Rename from
 961         tui_set_locator_info.  Return bool.
 962         (tui_update_locator_fullname, tui_show_frame_info): Update.
 963
 964 2019-08-30  Tom Tromey  <tom@tromey.com>
 965
 966         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
 967
 968 2019-08-30  Tom Tromey  <tom@tromey.com>
 969
 970         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
 971         call touchwin.
 972
 973 2019-08-30  Tom Tromey  <tom@tromey.com>
 974
 975         * tui/tui-wingeneral.c (box_win): Assume win_info and
 976         win_info->handle cannot be NULL.
 977
 978 2019-08-30  Tom Tromey  <tom@tromey.com>
 979
 980         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
 981         refresh_window>: Declare.
 982         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
 983         resize.
 984         (tui_data_item_window::rerender): Rename from
 985         tui_display_register.
 986         (tui_data_item_window::refresh_window): New method.
 987         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
 988         no-op.
 989
 990 2019-08-30  Tom Tromey  <tom@tromey.com>
 991
 992         * tui/tui-regs.h (struct tui_data_window) <regs_content,
 993         regs_column_count, current_group>: Move later.  Now private.
 994         <get_current_group>: New method.
 995         * tui/tui-regs.c (tui_reg_command): Update.
 996         * tui/tui-layout.c (tui_set_layout): Update.
 997
 998 2019-08-30  Tom Tromey  <tom@tromey.com>
 999
1000         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1001         (tui_data_window::rerender): Don't call
1002         check_and_display_highlight_if_needed.
1003         (tui_data_window::refresh_all): Remove call to
1004         erase_data_content.
1005
1006 2019-08-30  Tom Tromey  <tom@tromey.com>
1007
1008         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1009         (tui_data_window::display_registers_from)
1010         (tui_data_window::display_reg_element_at_line)
1011         (tui_data_window::display_registers_from_line): Remove checks of
1012         "empty".
1013
1014 2019-08-30  Tom Tromey  <tom@tromey.com>
1015
1016         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
1017         Don't declare.
1018         * tui/tui-regs.c (tui_data_window::show_registers): Call
1019         rerender.
1020         (tui_data_window::rerender): Rename from display_all_data.
1021         (tui_data_window::rerender): Remove old implementation.
1022
1023 2019-08-30  Tom Tromey  <tom@tromey.com>
1024
1025         * tui/tui-regs.c (tui_data_window::display_all_data): Change
1026         text.
1027         * tui/tui-data.h (NO_DATA_STRING): Remove define.
1028
1029 2019-08-29  Bernhard Wodok  <barto@gmx.net>
1030             Sergio Durigan Junior  <sergiodj@redhat.com>
1031
1032         PR win32/24284
1033         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
1034
1035 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1036
1037         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
1038         when searching for types.
1039
1040 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1041
1042         * f-lang.c (f_language_defn): Use f_print_typedef.
1043         * f-lang.h (f_print_typedef): Declare.
1044         * f-typeprint.c (f_print_typedef): Define.
1045
1046 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
1047
1048         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
1049
1050 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1051
1052         * cli/cli-utils.c (info_print_options_defs): Delete.
1053         (make_info_print_options_def_group): Delete.
1054         (extract_info_print_options): Delete.
1055         (info_print_command_completer): Delete.
1056         (info_print_args_help): Add extra parameter, and optionally
1057         include text about -n flag.
1058         * cli/cli-utils.h (struct info_print_options): Delete.
1059         (extract_info_print_options): Delete declaration.
1060         (info_print_command_completer): Delete declaration.
1061         (info_print_args_help): Add extra parameter, extend header
1062         comment.
1063         * python/python.c (gdbpy_rbreak): Pass additional parameter to
1064         search_symbols.
1065         * stack.c (struct info_print_options): New type.
1066         (info_print_options_defs): New file scoped variable.
1067         (make_info_print_options_def_group): New static function.
1068         (info_print_command_completer): New static function.
1069         (info_locals_command): Update to use new local functions.
1070         (info_args_command): Likewise.
1071         (_initialize_stack): Add extra parameter to calls to
1072         info_print_args_help.
1073         * symtab.c (search_symbols): Add extra parameter, use this to
1074         possibly excluse non-debug symbols.
1075         (symtab_symbol_info): Add extra parameter, which is passed on to
1076         search_symbols.
1077         (struct info_print_options): New type.
1078         (info_print_options_defs): New file scoped variable.
1079         (make_info_print_options_def_group): New static function.
1080         (info_print_command_completer): New static function.
1081         (info_variables_command): Update to use local functions, and pass
1082         extra parameter through to symtab_symbol_info.
1083         (info_functions_command): Likewise.
1084         (info_types_command): Pass additional argument through to
1085         symtab_symbol_info.
1086         (rbreak_command): Pass extra argument to search_symbols.
1087         (_initialize_symtab): Add extra arguments for calls to
1088         info_print_args_help, and update help text for 'info variables',
1089         'whereis', and 'info functions' commands.
1090         * symtab.h (search_symbols): Add extra argument to declaration.
1091         * NEWS: Mention new flags.
1092
1093 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
1094
1095         * symtab.c (lookup_static_symbol): Call the new function (and move
1096         it down to be next to lookup_global_symbol).
1097         (struct global_sym_lookup_data): Add block_enum member and rename to...
1098         (struct global_or_static_sym_lookup_data): ...this.
1099         (lookup_symbol_global_iterator_cb): Pass block_index instead of
1100         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
1101         (lookup_symbol_global_or_static_iterator_cb): ...this.
1102         (lookup_global_or_static_symbol): New function.
1103         (lookup_global_symbol): Call new function.
1104
1105 2019-08-26  Tom de Vries  <tdevries@suse.de>
1106
1107         PR c++/24852
1108         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
1109         when pc_probe.prob == NULL.
1110
1111 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1112
1113         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
1114         variable symbol_linkage to symbol_linkage_.
1115
1116 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1117
1118         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
1119         represent whether the symbol is static, dynamic, or we don't
1120         know.
1121
1122 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
1123
1124         * gdb/rx-tdep.c (rx_register_names): New.
1125         (rx_register_name): Delete.
1126         (rx_psw_type): Delete.
1127         (rx_fpsw_type): Delete.
1128         (rx_register_type): Delete.
1129         (rx_gdbarch_init): Convert target-descriptions.
1130         (_initialize_rx_tdep): Add initialize_tdesc_rx.
1131         * gdb/features/Makefile: Add rx.xml.
1132         * gdb/features/rx.xml: New.
1133         * gdb/features/rx.c: Generated.
1134         * gdb/NEWS: Mention target description support.
1135
1136 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1137
1138         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
1139         *slot_ptr.
1140
1141 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1142
1143         * configure.ac: Don't check for 'dlfcn.h' (moved to
1144         gdbsupport/common.m4).
1145         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
1146         'gdbsupport/'.
1147         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
1148         * compile/compile-c-support.c: Include
1149         'gdbsupport/gdb-dlfcn.h'.
1150         * gdbsupport/common.m4: Check for 'dlfcn.h'.
1151         * gdb-dlfcn.c: Move to...
1152         * gdbsupport/gdb-dlfcn.c: ... here.
1153         * gdb-dlfcn.h: Move to...
1154         * gdbsupport/gdb-dlfcn.h: ... here.
1155
1156 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
1157
1158         * nios2-tdep.c (struct reg_value): Improve comments.  Make
1159         the offset field signed.
1160
1161 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1162
1163         * python/lib/gdb/__init__.py (_execute_file): New function.
1164         * python/python.c (python_run_simple_file): Call gdb._execute_file
1165         on Windows.
1166
1167 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1168
1169         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
1170         all uses as this was never set to anything but a zero value.
1171
1172 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
1173
1174         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
1175
1176 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
1177
1178         * tui/tui-data.h (tui_gen_win_info): Add an =default
1179         move constructor, required by some GCC versions.
1180
1181 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
1182
1183         * go32-nat.c (go32_sysinfo): Add hygon_p.
1184
1185 2019-08-20  Tom Tromey  <tom@tromey.com>
1186
1187         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
1188         line_from_reg_element_no, first_reg_element_no_inline,
1189         display_all_data, delete_data_content_windows,
1190         erase_data_content>: Now private.
1191
1192 2019-08-20  Tom Tromey  <tom@tromey.com>
1193
1194         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
1195         (tui_unhighlight_win, tui_highlight_win)
1196         (tui_win_info::make_window): Update.
1197         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
1198
1199 2019-08-20  Tom Tromey  <tom@tromey.com>
1200
1201         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1202         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1203         (MAX_PID_WIDTH): Move to tui-stack.c.
1204         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1205         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1206         (MAX_PID_WIDTH): Move from tui-data.h.
1207
1208 2019-08-20  Tom Tromey  <tom@tromey.com>
1209
1210         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
1211         * tui/tui-wingeneral.c (box_win): Change type of win_info.
1212         (box_win): Update.
1213         (tui_gen_win_info::make_window): Rename from tui_make_window.
1214         (tui_win_info::make_window): New method.
1215         (tui_gen_win_info::make_visible): Update.
1216         * tui/tui-source.c (tui_source_window::set_contents): Update.
1217         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
1218         (tui_data_window::display_registers_from): Update.
1219         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1220         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
1221         Declare.
1222         <can_box>: Remove.
1223         <title>: Remove.
1224         (struct tui_win_info) <make_window>: Declare.
1225         <can_box>: Now virtual.
1226         <title>: New member.
1227         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
1228         * tui/tui-command.c (tui_cmd_window::resize): Update.
1229
1230 2019-08-20  Tom Tromey  <tom@tromey.com>
1231
1232         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
1233         * tui/tui-regs.c (tui_data_window::show_registers): Update.
1234         (tui_data_window::check_register_values): Update.
1235
1236 2019-08-20  Tom Tromey  <tom@tromey.com>
1237
1238         * tui/tui-regs.h (struct tui_data_window): Use
1239         DISABLE_COPY_AND_ASSIGN.
1240         <regs_content>: Change type, removing unique_ptr.
1241         <tui_data_window>: Add move constructor.
1242         * tui/tui-regs.c (tui_data_window::show_registers)
1243         (tui_data_window::show_register_group)
1244         (tui_data_window::display_registers_from)
1245         (tui_data_window::display_registers_from)
1246         (tui_data_window::first_data_item_displayed)
1247         (tui_data_window::delete_data_content_windows)
1248         (tui_data_window::rerender, tui_data_window::refresh_window)
1249         (tui_data_window::check_register_values): Update.
1250
1251 2019-08-20  Tom Tromey  <tom@tromey.com>
1252
1253         * tui/tui-regs.h (struct tui_data_window) <show_registers,
1254         show_register_group>: Declare.
1255         (tui_show_register_group): Don't declare.
1256         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
1257         tui_show_registers.
1258         (tui_data_window::show_register_group): Rename from
1259         tui_show_register_group.
1260         (tui_data_window::check_register_values, tui_reg_command):
1261         Update.
1262         * tui/tui-layout.c (tui_set_layout): Update.
1263
1264 2019-08-20  Tom Tromey  <tom@tromey.com>
1265
1266         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
1267         Declare.
1268         (tui_check_register_values): Don't declare.
1269         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
1270         from tui_check_register_values.
1271         * tui/tui-hooks.c (tui_register_changed): Update.
1272
1273 2019-08-20  Tom Tromey  <tom@tromey.com>
1274
1275         * tui/tui-regs.c (tui_reg_layout): Move later.
1276         (tui_show_registers): Don't enable TUI mode or change layout.
1277
1278 2019-08-20  Tom Tromey  <tom@tromey.com>
1279
1280         * tui/tui-regs.h (struct tui_data_item_window)
1281         <~tui_data_item_window>: Remove.
1282         <content>: Now a unique_xmalloc_ptr.
1283         * tui/tui-regs.c (tui_register_format): Return a
1284         unique_xmalloc_ptr.
1285         (tui_get_register): Update.
1286         (~tui_data_item_window): Remove.
1287         (tui_data_window::display_registers_from, tui_display_register):
1288         Update.
1289         * tui/tui-io.h (tui_expand_tabs): Update.
1290         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
1291         Remove "col" parameter.
1292
1293 2019-08-20  Tom Tromey  <tom@tromey.com>
1294
1295         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
1296         field.
1297         * tui/tui-regs.c (~tui_data_item_window): Update.
1298
1299 2019-08-20  Tom Tromey  <tom@tromey.com>
1300
1301         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
1302         earlier.
1303
1304 2019-08-20  Tom Tromey  <tom@tromey.com>
1305
1306         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
1307
1308 2019-08-20  Tom Tromey  <tom@tromey.com>
1309
1310         * tui/tui-source.h (struct tui_source_window): Update.
1311         * tui/tui-regs.c (tui_show_registers): Update.
1312         * tui/tui-disasm.h (struct tui_disasm_window): Update.
1313         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
1314         (NO_REGS_STRING): Remove defines.
1315
1316 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
1317
1318         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
1319         unnecessary thread walk if remote doesn't support the packet.
1320
1321 2019-08-19  Tom Tromey  <tromey@adacore.com>
1322
1323         * python/py-value.c (value_has_field): Fix indentation.
1324
1325 2019-08-19  Tom Tromey  <tromey@adacore.com>
1326
1327         * printcmd.c (do_one_display, info_display_command): Update.
1328         * block.h (contained_in): Return bool.  Add allow_nested
1329         parameter.
1330         * block.c (contained_in): Return bool.  Add allow_nested
1331         parameter.
1332
1333 2019-08-19  Tom Tromey  <tom@tromey.com>
1334
1335         * configure: Rebuild.
1336         * configure.ac: Disallow the combination of -static-libstdc++ and
1337         source highlight.
1338         * source-cache.c (get_language_name): Handle rust.
1339         (source_cache::get_source_lines): Ignore highlighting exceptions.
1340
1341 2019-08-16  Tom Tromey  <tom@tromey.com>
1342
1343         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
1344         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
1345         (struct tui_source_window_base) <make_visible, refresh_window,
1346         resize>: Remove methods.
1347         <execution_info>: Remove field.
1348         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
1349         (tui_show_source_line, tui_source_window_base)
1350         (~tui_source_window_base): Update.
1351         (tui_source_window_base::resize)
1352         (tui_source_window_base::make_visible)
1353         (tui_source_window_base::refresh_window): Remove.
1354         (tui_source_window_base::update_exec_info): Update.
1355         * tui/tui-source.c (tui_source_window::set_contents): Update.
1356         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1357
1358 2019-08-16  Tom Tromey  <tom@tromey.com>
1359
1360         * tui/tui-hooks.c (tui_remove_hooks): Don't set
1361         deprecated_query_hook.
1362
1363 2019-08-16  Tom Tromey  <tom@tromey.com>
1364
1365         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1366         (tui_update_source_windows_with_line): Update.
1367         * tui/tui-source.h (struct tui_source_window)
1368         <show_symtab_source>: Declare.
1369         (tui_show_symtab_source): Don't declare.
1370         * tui/tui-source.c (tui_show_symtab_source): Rename from
1371         tui_show_symtab_source.
1372
1373 2019-08-16  Tom Tromey  <tom@tromey.com>
1374
1375         * tui/tui-winsource.h (struct tui_source_window_base)
1376         <set_contents>: Declare.
1377         * tui/tui-winsource.c
1378         (tui_source_window_base::update_source_window_as_is): Update.
1379         * tui/tui-source.h (struct tui_source_window) <set_contents>:
1380         Declare.
1381         (tui_set_source_content): Don't declare.
1382         * tui/tui-source.c (tui_source_window::set_contents): Rename from
1383         tui_set_source_content.
1384         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
1385         Declare.
1386         (tui_set_disassem_content): Don't declare.
1387         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
1388         tui_set_disassem_content.
1389
1390 2019-08-16  Tom Tromey  <tom@tromey.com>
1391
1392         * tui/tui-winsource.h (struct tui_source_window_base)
1393         <update_breakpoint_info>: Declare.
1394         (tui_update_breakpoint_info): Don't declare.
1395         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
1396         (tui_update_all_breakpoint_info): Update.
1397         (tui_source_window_base::update_breakpoint_info): Rename from
1398         tui_update_breakpoint_info.
1399         (tui_source_window_base::update_exec_info): Update.
1400
1401 2019-08-16  Tom Tromey  <tom@tromey.com>
1402
1403         * tui/tui-winsource.h (struct tui_source_window_base)
1404         <update_source_window>: Declare.
1405         (tui_update_source_window): Don't declare.
1406         * tui/tui-winsource.c
1407         (tui_source_window_base::update_source_window): Rename from
1408         tui_update_source_window.
1409         (tui_source_window_base::rerender): Update.
1410         * tui/tui-source.c (tui_source_window::maybe_update): Update.
1411         * tui/tui-disasm.c (tui_show_disassem)
1412         (tui_show_disassem_and_update_source)
1413         (tui_disasm_window::maybe_update): Update.
1414
1415 2019-08-16  Tom Tromey  <tom@tromey.com>
1416
1417         * tui/tui-winsource.h (struct tui_source_window_base)
1418         <update_source_window_as_is>: Declare.
1419         (tui_update_source_window_as_is): Don't declare.
1420         * tui/tui-winsource.c (tui_update_source_window): Update
1421         (tui_source_window_base::update_source_window_as_is): Rename from
1422         tui_update_source_window_as_is.
1423         (tui_source_window_base::refill): Update.
1424         * tui/tui-source.c (tui_show_symtab_source): Update.
1425         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
1426         Update.
1427
1428 2019-08-16  Tom Tromey  <tom@tromey.com>
1429
1430         * tui/tui-winsource.h (tui_update_source_window)
1431         (tui_update_source_window_as_is): Remove "noerror" parameter.
1432         * tui/tui-winsource.c (tui_update_source_window)
1433         (tui_update_source_window_as_is): Remove "noerror" parameter.
1434         (tui_update_source_windows_with_addr)
1435         (tui_update_source_windows_with_line)
1436         (tui_source_window_base::rerender)
1437         (tui_source_window_base::refill): Update.
1438         * tui/tui-source.h (tui_set_source_content)
1439         (tui_show_symtab_source): Remove "noerror" parameter.
1440         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
1441         parameter.
1442         (tui_show_symtab_source): Likewise.
1443         (tui_source_window::maybe_update): Update.
1444         * tui/tui-disasm.c (tui_show_disassem)
1445         (tui_show_disassem_and_update_source)
1446         (tui_disasm_window::do_scroll_vertical)
1447         (tui_disasm_window::maybe_update): Update.
1448
1449 2019-08-16  Tom Tromey  <tom@tromey.com>
1450
1451         * tui/tui.c (tui_is_window_visible): Update.
1452         * tui/tui-wingeneral.c (tui_make_window)
1453         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
1454         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
1455         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
1456         (tui_set_win_height_command, parse_scrolling_args): Update.
1457         * tui/tui-source.c (tui_source_window::style_changed): Update.
1458         * tui/tui-regs.c (tui_show_registers)
1459         (tui_data_window::first_data_item_displayed)
1460         (tui_data_window::delete_data_content_windows)
1461         (tui_check_register_values, tui_reg_command): Update.
1462         * tui/tui-disasm.c (tui_show_disassem): Update.
1463         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
1464         method.
1465         <is_visible>: Remove field.
1466         * tui/tui-data.c (tui_next_win, tui_prev_win)
1467         (tui_delete_invisible_windows): Update.
1468
1469 2019-08-16  Tom Tromey  <tom@tromey.com>
1470
1471         * tui/tui-winsource.h (struct tui_source_window_base)
1472         <m_has_locator>: Remove.
1473         * tui/tui-layout.c (show_source_disasm_command, show_data)
1474         (show_source_or_disasm_and_command): Update.
1475
1476 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
1477
1478         * NEWS (Other MI changes): New subsection.
1479         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
1480         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
1481         * arch-utils.c (default_get_pc_address_flags): New function.
1482         * arch-utils.h (default_get_pc_address_flags): New declaration.
1483         * gdbarch.sh: Add get_pc_address_flags.
1484         * gdbarch.c: Regenerate.
1485         * gdbarch.h: Likewise.
1486         * stack.c (print_pc): New function.
1487         (print_frame_info) (print_frame): Call print_pc.
1488
1489 2019-08-16  Tom de Vries  <tdevries@suse.de>
1490
1491         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
1492         print_objfile_section_info.
1493
1494 2019-08-15  Tom Tromey  <tom@tromey.com>
1495
1496         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
1497         calling update_cmdwin_start_line.
1498         * tui/tui-winsource.h (struct tui_source_window_base)
1499         <do_make_visible_with_new_height, set_new_height>: Don't declare.
1500         <rerender>: Declare.
1501         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
1502         Call rerender.
1503         (tui_source_window_base::set_new_height): Remove.
1504         (tui_source_window_base::rerender): Rename from
1505         do_make_visible_with_new_height.
1506         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
1507         resize method.
1508         (tui_win_info::make_invisible_and_set_new_height)
1509         (tui_win_info::make_visible_with_new_height): Remove.
1510         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
1511         Declare.
1512         * tui/tui-stack.c (tui_locator_window::rerender): New method.
1513         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
1514         do_make_visible_with_new_height>: Don't declare.
1515         <rerender>: Declare.
1516         * tui/tui-regs.c (tui_data_window::rerender): Rename from
1517         set_new_height.
1518         (tui_data_window::do_make_visible_with_new_height): Remove.
1519         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
1520         call tui_show_locator_content.
1521         (tui_gen_win_info::resize): Call rerender.
1522         (show_source_or_disasm_and_command): Don't call
1523         tui_show_locator_content.
1524         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
1525         method.
1526         (struct tui_win_info) <rerender>: Declare.
1527         <set_new_height, make_invisible_and_set_new_height,
1528         make_visible_with_new_height>: Don't declare.
1529         * tui/tui-data.c (tui_win_list::rerender): New method.
1530         * tui/tui-command.h (struct tui_cmd_window)
1531         <do_make_visible_with_new_height>: Don't declare.
1532         * tui/tui-command.c
1533         (tui_cmd_window::do_make_visible_with_new_height): Remove.
1534
1535 2019-08-15  Tom Tromey  <tromey@adacore.com>
1536
1537         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
1538         * ada-lang.c (ada_enum_name): Likewise.
1539
1540 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
1541
1542         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
1543         leading underscore.
1544         (GdbOutputErrorFile): Likewise.
1545         (global scope): Adjust constructor calls to GdbOutput{,Error}File
1546         accordingly.
1547         (execute_unwinders): Rename to have a leading underscore.
1548         (auto_load_packages): Likewise.
1549         (global scope): Adjust call to auto_load_packages accordingly.
1550         (GdbSetPythonDirectory): Likewise.
1551         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
1552         instead of execute_unwinders.
1553
1554 2019-08-15  Tom Tromey  <tom@tromey.com>
1555
1556         * tui/tui-layout.c (show_layout, show_source_disasm_command)
1557         (show_data): Don't change window visibility.
1558         (tui_gen_win_info::resize): Remove special case for command
1559         window.  Use wresize, when available.
1560         (show_source_or_disasm_and_command): Don't change window
1561         visibility.
1562         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
1563         <make_visible>: New method.
1564         * tui/tui-command.c (tui_cmd_window::resize): New method.
1565
1566 2019-08-15  Tom Tromey  <tom@tromey.com>
1567
1568         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
1569         (struct tui_source_windows): New.
1570         * tui/tui-winsource.c (tui_display_main): Update.
1571         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1572         (new_height_ok, parse_scrolling_args): Update.
1573         * tui/tui-layout.c (show_layout, show_data): Update.
1574         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
1575         (tui_add_to_source_windows): Don't declare.
1576         * tui/tui-data.c (source_windows, tui_source_windows)
1577         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
1578
1579 2019-08-15  Tom Tromey  <tom@tromey.com>
1580
1581         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
1582         Rename from reset.
1583         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
1584         * tui/tui-layout.c (show_source_disasm_command, show_data):
1585         Update.
1586         (tui_gen_win_info::resize): Rename.
1587         (show_source_or_disasm_and_command): Update.
1588         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
1589         reset.
1590
1591 2019-08-15  Tom Tromey  <tom@tromey.com>
1592
1593         * tui/tui-stack.c (tui_initialize_static_data): Remove.
1594         * tui/tui-interp.c (tui_interp::init): Don't call
1595         tui_initialize_static_data.
1596         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
1597
1598 2019-08-15  Tom Tromey  <tom@tromey.com>
1599
1600         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
1601         examine tui_win_list.
1602
1603 2019-08-15  Tom Tromey  <tom@tromey.com>
1604
1605         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
1606         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
1607         tui_clear_source_content.
1608         (tui_clear_source_content): Remove.
1609         (tui_source_window_base::do_erase_source_content): Hoist call to
1610         content.clear().
1611         * tui/tui-stack.c (tui_show_frame_info): Don't call
1612         tui_clear_source_content.
1613
1614 2019-08-15  Tom Tromey  <tom@tromey.com>
1615
1616         * tui/tui-winsource.h (struct tui_source_window_base)
1617         <do_erase_source_content>: New method.
1618         <erase_source_content>: New method.
1619         (tui_erase_source_content): Don't declare.
1620         * tui/tui-winsource.c (tui_clear_source_content): Update.
1621         (tui_source_window_base::do_erase_source_content): Rename from
1622         tui_erase_source_content.
1623         (tui_source_window_base::show_source_content): Update.
1624         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1625         * tui/tui-source.h (struct tui_source_window)
1626         <erase_source_content>: New method.
1627         * tui/tui-disasm.h (struct tui_disasm_window)
1628         <erase_source_content>: New method.
1629
1630 2019-08-15  Tom Tromey  <tom@tromey.com>
1631
1632         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
1633         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
1634         constructor.
1635         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
1636         * tui/tui-source.c (tui_set_source_content): Update.
1637         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1638
1639 2019-08-15  Tom Tromey  <tom@tromey.com>
1640
1641         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
1642         * tui/tui-winsource.c (tui_line_is_displayed): Move to
1643         tui-source.c.
1644         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
1645         Declare.
1646         * tui/tui-source.c (tui_source_window::line_is_displayed): New
1647         method.
1648         (tui_source_window::maybe_update): Update.
1649
1650 2019-08-15  Tom Tromey  <tom@tromey.com>
1651
1652         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
1653         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
1654         tui-disasm.c.
1655         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
1656         Declare.
1657         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
1658         method.
1659         (tui_disasm_window::maybe_update): Update.
1660
1661 2019-08-15  Tom Tromey  <tom@tromey.com>
1662
1663         * tui/tui-winsource.h (struct tui_source_window_base)
1664         <maybe_update>: Declare.
1665         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
1666         method.
1667         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
1668         Declare.
1669         * tui/tui-source.c (tui_source_window::maybe_update): New method.
1670         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
1671         Declare.
1672         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
1673
1674 2019-08-15  Tom Tromey  <tom@tromey.com>
1675
1676         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
1677
1678 2019-08-15  Tom Tromey  <tom@tromey.com>
1679
1680         * tui/tui-wingeneral.c: Include tui-stack.h.
1681         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
1682         (struct tui_locator_window): Move from tui-data.h.
1683         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
1684         (tui_initialize_static_data): Move from tui-data.c.
1685         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
1686         (struct tui_locator_window): Move to tui-stack.c.
1687         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
1688         (tui_initialize_static_data): Move to tui-stack.c.
1689
1690 2019-08-15  Tom Tromey  <tom@tromey.com>
1691
1692         * tui/tui-layout.c (show_source_disasm_command)
1693         (show_source_or_disasm_and_command): Use make_visible method, not
1694         tui_make_window.
1695         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
1696         Remove.
1697
1698 2019-08-15  Tom Tromey  <tom@tromey.com>
1699
1700         * tui/tui-wingeneral.h (tui_make_window): Update.
1701         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
1702         parameter.
1703         (tui_gen_win_info::make_visible): Update.
1704         * tui/tui-regs.c (tui_data_window::display_registers_from):
1705         Update.
1706         * tui/tui-layout.c (show_source_disasm_command)
1707         (show_source_or_disasm_and_command): Update.
1708         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
1709         (enum tui_box): Remove.
1710         (struct tui_win_info) <can_box>: New method.
1711         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
1712         method.
1713
1714 2019-08-15  Tom de Vries  <tdevries@suse.de>
1715
1716         * linux-nat-trad.c: Include gdbarch.h.
1717
1718 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
1719
1720         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
1721         register sizes.
1722
1723 2019-08-14  Tom Tromey  <tromey@adacore.com>
1724
1725         * darwin-nat.c: Include gdbarch.h.
1726         * darwin-nat-info.c: Include gdbarch.h.
1727
1728 2019-08-13  Tom Tromey  <tom@tromey.com>
1729
1730         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
1731         Remove.
1732         * tui/tui-data.c (tui_initialize_static_data): Update.
1733
1734 2019-08-13  Tom Tromey  <tom@tromey.com>
1735
1736         * tui/tui-winsource.h (struct tui_exec_info_window)
1737         <~tui_exec_info_window, maybe_allocate_content, get_content,
1738         m_content>: Remove.
1739         (struct tui_source_window_base) <set_exec_info_content,
1740         show_exec_info_content>: Don't declare.
1741         * tui/tui-winsource.c
1742         (tui_exec_info_window::maybe_allocate_content): Remove.
1743         (tui_source_window_base::update_exec_info): Rename from
1744         set_exec_info_content.
1745         (tui_source_window_base::show_exec_info_content)
1746         (tui_source_window_base::update_exec_info): Remove.
1747
1748 2019-08-13  Tom Tromey  <tom@tromey.com>
1749
1750         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
1751         declare.
1752         * tui/tui-winsource.c (tui_update_source_window_as_is)
1753         (tui_update_source_windows_with_addr, tui_erase_source_content):
1754         Update.
1755         (tui_clear_exec_info_content): Remove.
1756
1757 2019-08-13  Tom Tromey  <tom@tromey.com>
1758
1759         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
1760         declare.
1761         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
1762         call tui_erase_exec_info_content.
1763         (tui_clear_exec_info_content): Rename from
1764         tui_erase_exec_info_content.
1765         (tui_clear_exec_info_content): Delete.
1766
1767 2019-08-13  Tom Tromey  <tom@tromey.com>
1768
1769         * tui/tui-winsource.h (struct tui_source_window_base)
1770         <show_exec_info_content>: Declare.
1771         (tui_show_exec_info_content): Don't declare.
1772         * tui/tui-winsource.c
1773         (tui_source_window_base::show_exec_info_content): Rename from
1774         tui_show_exec_info_content.
1775         (tui_source_window_base::update_exec_info): Update.
1776
1777 2019-08-13  Tom Tromey  <tom@tromey.com>
1778
1779         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
1780         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
1781         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
1782         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
1783         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
1784         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
1785         ... here.
1786
1787 2019-08-13  Tom Tromey  <tom@tromey.com>
1788
1789         * tui/tui-winsource.h (struct tui_source_window_base)
1790         <update_exec_info>: Declare.
1791         (tui_update_exec_info): Don't declare.
1792         * tui/tui-winsource.c (tui_update_source_window_as_is)
1793         (tui_source_window_base::refresh_all)
1794         (tui_update_all_breakpoint_info): Update.
1795         (tui_source_window_base::update_exec_info): Rename from
1796         tui_update_exec_info.
1797         * tui/tui-stack.c (tui_show_frame_info): Update.
1798
1799 2019-08-13  Tom Tromey  <tom@tromey.com>
1800
1801         * tui/tui-winsource.h (struct tui_source_window_base)
1802         <set_exec_info_content>: Declare.
1803         (tui_set_exec_info_content): Don't declare.
1804         * tui/tui-winsource.c
1805         (tui_source_window_base::set_exec_info_content): Rename from
1806         tui_set_exec_info_content.
1807         (tui_update_exec_info): Update.
1808
1809 2019-08-13  Tom Tromey  <tom@tromey.com>
1810
1811         * tui/tui-winsource.h (struct tui_source_window_base)
1812         <show_source_content>: Declare.
1813         (tui_show_source_content): Don't declare.
1814         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1815         (tui_source_window_base::show_source_content): Rename from
1816         tui_show_source_content.
1817         (tui_source_window_base::refresh_all): Update.
1818         * tui/tui-layout.c (show_source_disasm_command)
1819         (show_source_or_disasm_and_command): Update.
1820
1821 2019-08-13  Tom Tromey  <tom@tromey.com>
1822
1823         * tui/tui-winsource.c (tui_erase_source_content)
1824         (tui_show_source_content, tui_source_window_base::refresh_all):
1825         Update.
1826         * tui/tui-wingeneral.h
1827         (tui_check_and_display_highlight_if_needed): Don't declare.
1828         * tui/tui-wingeneral.c
1829         (tui_win_info::check_and_display_highlight_if_needed): Rename from
1830         check_and_display_highlight_if_needed.
1831         * tui/tui-win.c (tui_rehighlight_all)
1832         (tui_win_info::make_visible_with_new_height): Update.
1833         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1834         (tui_data_window::erase_data_content)
1835         (tui_data_window::display_all_data): Update.
1836         * tui/tui-data.h (struct tui_win_info)
1837         <check_and_display_highlight_if_needed>: Declare.
1838
1839 2019-08-13  Tom Tromey  <tom@tromey.com>
1840
1841         * tui/tui-win.c (tui_resize_all): Call
1842         tui_delete_invisible_windows.
1843         * tui/tui-layout.c (show_layout): Call
1844         tui_delete_invisible_windows.
1845         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
1846         * tui/tui-data.c (tui_delete_invisible_windows): New function.
1847
1848 2019-08-13  Tom Tromey  <tom@tromey.com>
1849
1850         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
1851         tui_add_win_to_layout.
1852
1853 2019-08-13  Tom Tromey  <tom@tromey.com>
1854
1855         * tui/tui-layout.h (tui_default_win_height): Don't declare.
1856         * tui/tui-layout.c (tui_default_win_height): Now static.
1857
1858 2019-08-13  Tom Tromey  <tom@tromey.com>
1859
1860         * tui/tui-layout.c (show_layout): Unify all layout cases into a
1861         single switch.
1862         (show_source_disasm_command, show_source_or_disasm_and_command):
1863         Don't check current layout.
1864
1865 2019-08-13  Tom Tromey  <tom@tromey.com>
1866
1867         * tui/tui-wingeneral.c (make_all_visible): Remove.
1868         (tui_make_all_invisible): Simplify.
1869         * tui/tui-layout.c (tui_make_all_invisible): Move from
1870         tui-wingeneral.c; simplify.
1871         (show_layout): Hoist call to tui_make_all_invisible.
1872         (show_data): Don't call tui_make_all_invisible.
1873
1874 2019-08-13  Tom Tromey  <tom@tromey.com>
1875
1876         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
1877         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
1878
1879 2019-08-13  Tom Tromey  <tom@tromey.com>
1880
1881         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
1882         tui-data.c.
1883         (show_source_disasm_command, show_data)
1884         (show_source_or_disasm_and_command): Don't use
1885         tui_set_current_layout_to.
1886         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
1887         * tui/tui-data.c (current_layout, tui_current_layout): Move to
1888         tui-layout.c.
1889         (tui_set_current_layout_to): Remove.
1890
1891 2019-08-13  Tom Tromey  <tom@tromey.com>
1892
1893         * tui/tui-layout.c (tui_set_layout): Update.
1894         * tui/tui-data.h (struct tui_layout_def): Remove.
1895         (tui_layout_def): Don't declare.
1896         * tui/tui-data.c (layout_def): Remove.
1897         (tui_layout_def): Remove.
1898
1899 2019-08-13  Tom Tromey  <tom@tromey.com>
1900
1901         * tui/tui-winsource.h (struct tui_source_window_base)
1902         <clear_detail>: No longer "override".
1903         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
1904         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
1905         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
1906         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
1907         Remove.
1908         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
1909
1910 2019-08-13  Tom Tromey  <tromey@adacore.com>
1911
1912         * tracepoint.c: Don't include readline.h or history.h.
1913
1914 2019-08-12  Tom Tromey  <tom@tromey.com>
1915
1916         * configure: Rebuild.
1917         * configure.ac: Check for readline 7.
1918         * NEWS: Mention readline 7 requirement.
1919         * README: Update.
1920
1921 2019-08-12  Tom Tromey  <tom@tromey.com>
1922
1923         * mingw-hdep.c (gdb_select): Remove readline hack.
1924
1925 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1926
1927         * blockframe.c (find_pc_partial_function): Set *block to nullptr
1928         when the function fails.
1929
1930 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
1931
1932         * s390-tdep.c (s390_type_align): New function.
1933         (s390_gdbarch_init): Set it as type_align gdbarch method.
1934
1935 2019-08-09  Tom de Vries  <tdevries@suse.de>
1936
1937         PR gdb/24591
1938         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
1939         pc_low with relocation offset.
1940
1941 2019-08-07  Tom Tromey  <tromey@adacore.com>
1942
1943         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1944         (print_frame_args): Update.
1945         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
1946         Update.
1947         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1948         * frame.h (struct frame_arg): Add initializers.
1949         <error>: Now a unique_xmalloc_ptr.
1950
1951 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
1952
1953         * NEWS: Expand the Pointer Authentication entry.
1954         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
1955         (aarch64_frame_unmask_lr): ... to this.
1956         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
1957         Call aarch64_frame_unmask_lr.
1958         * frame.c (struct frame_info): Add "masked" variable.
1959         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
1960         (fprint_frame): Check for masked pc.
1961         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
1962         declarations.
1963         * python/py-framefilter.c (py_print_frame): Check for masked pc.
1964         * stack.c (print_frame): Check for masked pc.
1965
1966 2019-08-06  Tom Tromey  <tom@tromey.com>
1967
1968         * stabsread.c (patch_block_stabs, read_one_struct_field)
1969         (read_enum_type): Use obstack_strndup.
1970         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
1971         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
1972         * dwarf2read.c (guess_full_die_structure_name)
1973         (anonymous_struct_prefix): Use obstack_strndup.
1974         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
1975         * c-exp.y (yylex): Use obstack_strndup.
1976         * ada-exp.y (write_object_renaming, write_ambiguous_var)
1977         (write_var_or_type): Use obstack_strndup.
1978
1979 2019-08-06  Tom Tromey  <tom@tromey.com>
1980
1981         * symfile.c (reread_symbols): Use obstack_strdup.
1982         * stabsread.c (read_type): Use obstack_strdup.
1983         * gdb_obstack.h (obstack_strdup): New overload.
1984         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
1985         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
1986         (dwarf2_canonicalize_name): Use obstack_strdup.
1987         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
1988         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
1989         Use obstack_strdup.
1990
1991 2019-08-06  Tom Tromey  <tom@tromey.com>
1992
1993         * gdb_obstack.h (obstack_strdup): Define.
1994         * gdb_obstack.c (obstack_strdup): Don't define.
1995
1996 2019-08-06  Tom Tromey  <tom@tromey.com>
1997
1998         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
1999         obstack_strdup.
2000         * typeprint.c (typedef_hash_table::find_global_typedef): Use
2001         obstack_strdup.
2002         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
2003         * stabsread.c (common_block_start): Use obstack_strdup.
2004         * objfiles.c (set_objfile_main_name, objfile): Use
2005         obstack_strdup.
2006         * namespace.c (add_using_directive): Use obstack_strdup.
2007         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
2008         * jit.c (finalize_symtab): Use obstack_strdup.
2009         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
2010         (guess_partial_die_structure_name, partial_die_info::fixup)
2011         (dwarf2_name): Use obstack_strdup.
2012         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
2013         obstack_strdup.
2014         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
2015         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2016         obstack_strdup.
2017         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
2018
2019 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2020
2021         * unittests/help-doc-selftests.c: New file.
2022         * Makefile.in: Add the new file.
2023
2024 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2025
2026         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
2027         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
2028         the full first line, except when FOR_VALUE_PREFIX.  In this case,
2029         the trailing '.' is not output, and the first character is uppercased.
2030         (print_help_for_command): Update call to print_doc_line.
2031         (print_doc_of_command): Likewise.
2032         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
2033         * cli/cli-option.c (append_indented_doc): Do not append newline.
2034         (build_help_option): Append newline after first appended_indented_doc
2035         only if a second call is done.
2036         (build_help): Append 2 new lines before each option, except the first
2037         one.
2038         * compile/compile.c (_initialize_compile): Add new lines after
2039         %OPTIONS%, when not at the end of the help.
2040         Change help doc or code
2041         producing the help doc to respect the invariants.
2042         * maint-test-options.c (_initialize_maint_test_options): Likewise.
2043         Also removed the new line after 'Options:', as all other commands
2044         do not put an empty line between 'Options:' and the first option.
2045         * printcmd.c (_initialize_printcmd): Likewise.
2046         * stack.c (_initialize_stack): Likewise.
2047         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
2048         incorrectly telling COMMAND is optional.
2049         * ada-lang.c (_initialize_ada_language): Change help doc or code
2050         producing the help doc to respect the invariants.
2051         * ada-tasks.c (_initialize_ada_tasks): Likewise.
2052         * breakpoint.c (_initialize_breakpoint): Likewise.
2053         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
2054         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
2055         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
2056         * cli/cli-style.c (cli_style_option::add_setshow_commands,
2057         _initialize_cli_style): Likewise.
2058         * corelow.c (core_target_info): Likewise.
2059         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
2060         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
2061         * filesystem.c (_initialize_filesystem): Likewise.
2062         * frame.c (_initialize_frame): Likewise.
2063         * gnu-nat.c (add_task_commands): Likewise.
2064         * infcall.c (_initialize_infcall): Likewise.
2065         * infcmd.c (_initialize_infcmd): Likewise.
2066         * interps.c (_initialize_interpreter): Likewise.
2067         * language.c (_initialize_language): Likewise.
2068         * linux-fork.c (_initialize_linux_fork): Likewise.
2069         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
2070         * maint.c (_initialize_maint_cmds): Likewise.
2071         * memattr.c (_initialize_mem): Likewise.
2072         * printcmd.c (_initialize_printcmd): Likewise.
2073         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
2074         _RegEx): Likewise.
2075         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
2076         * record-btrace.c (_initialize_record_btrace): Likewise.
2077         * record-full.c (_initialize_record_full): Likewise.
2078         * record.c (_initialize_record): Likewise.
2079         * regcache-dump.c (_initialize_regcache_dump): Likewise.
2080         * regcache.c (_initialize_regcache): Likewise.
2081         * remote.c (add_packet_config_cmd, init_remote_threadtests,
2082         _initialize_remote): Likewise.
2083         * ser-tcp.c (_initialize_ser_tcp): Likewise.
2084         * serial.c (_initialize_serial): Likewise.
2085         * skip.c (_initialize_step_skip): Likewise.
2086         * source.c (_initialize_source): Likewise.
2087         * stack.c (_initialize_stack): Likewise.
2088         * symfile.c (_initialize_symfile): Likewise.
2089         * symtab.c (_initialize_symtab): Likewise.
2090         * target-descriptions.c (_initialize_target_descriptions): Likewise.
2091         * top.c (init_main): Likewise.
2092         * tracefile-tfile.c (tfile_target_info): Likewise.
2093         * tracepoint.c (_initialize_tracepoint): Likewise.
2094         * tui/tui-win.c (_initialize_tui_win): Likewise.
2095         * utils.c (add_internal_problem_command): Likewise.
2096         * valprint.c (value_print_option_defs): Likewise.
2097
2098 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
2099
2100         PR build/24886
2101         * configure.ac: Drop enable-libmcheck support.
2102         * configure, config.in: Rebuild.
2103         * libmcheck.m4: Remove.
2104         * acinclude.m4: Don't include it.
2105         * Makefile.in: Don't distribute it.
2106         * top.c (print_gdb_configuration): Don't mention it.
2107
2108 2019-08-06  Tom Tromey  <tom@tromey.com>
2109
2110         * utils.c (set_output_style): Sometimes pass stream to
2111         emit_style_escape.
2112         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
2113         * record-btrace.c (btrace_insn_history): Update.
2114         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
2115         method.
2116         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
2117         Update initializers.
2118         <m_uiout>: New field.
2119         <m_di>: Move lower.
2120         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2121         Remove "uiout" parameter.
2122         (dump_insns): Update.
2123         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
2124         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
2125
2126 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
2127
2128         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
2129         (error_in_psymtab_expansion): Likewise.
2130         (lookup_symbol_via_quick_fns): Likewise.
2131         (basic_lookup_transparent_type_quick): Likewise.
2132         (basic_lookup_transparent_type_1): Likewise.
2133
2134 2019-08-06  Tom Tromey  <tromey@adacore.com>
2135
2136         * source.c (last_source_error): Now bool.
2137         (print_source_lines_base): Make "noprint" bool.  Only open
2138         source file when last_source_visited changes.
2139
2140 2019-08-06  Tom Tromey  <tromey@adacore.com>
2141
2142         * annotate.c (annotate_source_line): Use g_source_cache.
2143         * source-cache.c (source_cache::get_plain_source_lines): Change
2144         parameters.  Populate m_offset_cache.
2145         (source_cache::ensure): New method.
2146         (source_cache::get_line_charpos): New method.
2147         (extract_lines): Move lower.  Change parameters.
2148         (source_cache::get_source_lines): Move lower.
2149         * source-cache.h (class source_cache): Update comment.
2150         <get_line_charpos>: New method.
2151         <get_source_lines>: Update comment.
2152         <clear>: Clear m_offset_cache.
2153         <get_plain_source_lines>: Change parameters.
2154         <ensure>: New method
2155         <m_offset_cache>: New member.
2156         * source.c (forget_cached_source_info_for_objfile): Update.
2157         (info_source_command): Use g_source_cache.
2158         (find_source_lines, open_source_file_with_line_charpos): Remove.
2159         (print_source_lines_base, search_command_helper): Use g_source_cache.
2160         * source.h (open_source_file_with_line_charpos): Don't declare.
2161         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
2162         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
2163         Use g_source_cache.
2164
2165 2019-08-06  Tom Tromey  <tromey@adacore.com>
2166
2167         * source-cache.c (source_cache::get_plain_source_lines):
2168         Remove "first_line" and "last_line" parameters.
2169         (source_cache::get_source_lines): Cache plain text.
2170         * source-cache.h (class source_cache)
2171         <get_plain_source_lines>: Update.
2172
2173 2019-08-06  Tom Tromey  <tromey@adacore.com>
2174
2175         * source-cache.c (extract_lines): No longer a method.
2176         Changed type of parameter.  Include final newline.
2177         (selftests::extract_lines_test): New function.
2178         (_initialize_source_cache): Likewise.
2179         * source-cache.h (class source_cache)
2180         <extract_lines>: Don't declare.
2181
2182 2019-08-06  Tom Tromey  <tromey@adacore.com>
2183
2184         * breakpoint.c (init_breakpoint_sal): Update.
2185         (breakpoint): Update.
2186         * breakpoint.h (struct breakpoint) <filter>: Now a
2187         unique_xmalloc_ptr.
2188
2189 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2190
2191         * NEWS: Mention dictionary access on blocks.
2192         * python/py-block.c (blpy_getitem): New function.
2193         (block_object_as_mapping): New struct.
2194         (block_object_type): Use new struct for tp_as_mapping field.
2195
2196 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2197
2198         * objfiles.h (objfile): Add a comment describing partial symbols.
2199
2200 2019-08-05  Tom Tromey  <tromey@adacore.com>
2201
2202         * compile/compile.c (_initialize_compile): Use _(), not N_().
2203         * thread.c (_initialize_thread): Use _(), not N_().
2204         * stack.c (_initialize_stack): Use _(), not N_().
2205         * printcmd.c (_initialize_printcmd): Use _(), not N_().
2206
2207 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
2208
2209         * dwarf2read.c (struct dw2_symtab_iterator):
2210         <want_specific_block>: Remove.
2211         <block_index>: Change type to gdb::optional.
2212         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
2213         change type of BLOCK_INDEX parameter to gdb::optional.
2214         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
2215         (dw2_lookup_symbol): Don't pass argument for
2216         WANT_SPECIFIC_BLOCK.
2217         (dw2_expand_symtabs_for_function): Don't pass argument for
2218         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
2219         (class dw2_debug_names_iterator)
2220         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
2221         parameter, change BLOCK_INDEX type to gdb::optional.
2222         <m_want_specific_block>: Remove.
2223         <m_block_index>: Change type to gdb::optional.
2224         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
2225         gdb::optional.  Re-write in function of gdb::optional.
2226         (dw2_debug_names_lookup_symbol): Don't pass argument for
2227         WANT_SPECIFIC_BLOCK.
2228         (dw2_debug_names_expand_symtabs_for_function): Don't pass
2229         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
2230         BLOCK_INDEX.
2231
2232 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2233
2234         * NEWS: Mention changes to "info sources" command.
2235
2236 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2237
2238         * symtab.c (filename_partial_match_opts): New struct type.
2239         (struct output_source_filename_data): New members
2240         regexp, c_regexp, partial_match.
2241         (output_source_filename): Use new members to decide to print file.
2242         (info_sources_option_defs): New variable.
2243         (make_info_sources_options_def_group, print_info_sources_header,
2244         info_sources_command_completer):
2245         New functions.
2246         (info_sources_command): Read new optional arguments.
2247         (_initialize_symtab): Update info sources help.
2248
2249 2019-08-02  Alexandre Oliva <oliva@adacore.com>
2250
2251         * ada-lang.c (exception_support_info_v0): Renamed from...
2252         (default_exception_support_info): ... this.  Create new
2253         definition for v1.
2254         (ada_has_this_exception_support): Look up catch_handlers_sym.
2255         (ada_exception_support_info_sniffer): Try v0 after default.
2256
2257 2019-08-01  Tom Tromey  <tromey@adacore.com>
2258
2259         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
2260         gdbarch.h.
2261
2262 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
2263
2264         * s12z-tdep.c: Fix include path for s12z-opc.h.
2265
2266 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
2267
2268         * NEWS: Require GNU make 3.82.
2269
2270 2019-07-16  Tom Tromey  <tom@tromey.com>
2271
2272         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
2273         declare.
2274
2275 2019-07-30  Tom Tromey  <tromey@adacore.com>
2276
2277         * block.c (contained_in): Remove BLOCK_FUNCTION check.
2278
2279 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
2280
2281         * printcmd.c (print_address_symbolic): Print negative offsets.
2282         (build_address_symbolic): Force signed arithmetic when computing
2283         offset.
2284
2285 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
2286
2287         PR/24474: Add a function to lookup static variables.
2288         * NEWS: Mention this new function.
2289         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
2290         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
2291         * python/python.c (python_GdbMethods): Add new function.
2292
2293 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
2294
2295         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
2296         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
2297         (objfpy_lookup_static_symbol): New function.
2298         (objfile_object_methods): Add new functions.
2299
2300 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2301
2302         * NEWS: Mention 'set|show print frame-info'.  Mention new
2303         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
2304         backtrace argument.  Mention that python frame filtering code
2305         is now consistent with what 'backtrace' command prints.
2306
2307 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2308
2309         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
2310         comments.
2311         (print_frame_info_auto, print_frame_info_source_line,
2312         print_frame_info_location, print_frame_info_source_and_location,
2313         print_frame_info_location_and_address, print_frame_info_short_location):
2314         New declarations.
2315         (struct frame_print_options): New member print_frame_info.
2316         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
2317         * stack.h (get_user_print_what_frame_info): New declaration.
2318         (frame_show_address): New declaration.
2319         * stack.c (print_frame_arguments_choices): New value 'presence'.
2320         (print_frame_info_auto, print_frame_info_source_line,
2321         print_frame_info_location, print_frame_info_source_and_location,
2322         print_frame_info_location_and_address, print_frame_info_short_location,
2323         print_frame_info_choices, print_frame_info_print_what): New definitions.
2324         (print_frame_args): Only print dots for args if print frame-arguments
2325         is 'presence'.
2326         (frame_print_option_defs): New element for "frame-info".
2327         (get_user_print_what_frame_info): New function.
2328         (frame_show_address): Make non static.  Move comment to stack.h.
2329         (print_frame_info_to_print_what): New function.
2330         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
2331         to decide what to print.
2332         (backtrace_command_1): Handle the new print_frame_arguments_presence
2333         value.
2334         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
2335         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
2336         (py_print_frame): In non-mi mode, use LOCATION as default for
2337         print_what, similarly to frame information printed directly by
2338         backtrace command. Handle frame-info user option in non MI mode.
2339
2340 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2341
2342         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
2343         Add case for debugging 32-bit target on 64-bit host.  Revise
2344         comment.
2345
2346 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2347
2348         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
2349         instead of find_function_entry_range_from_pc.
2350
2351 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2352
2353         * stack.c (find_frame_funname): Remove code which preferred
2354         minsym over symtab sym in "certain pathological cases".
2355
2356         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
2357         parameter.  Change type of "do_demangle" to bool.
2358         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2359         Pass suitable "prefer_sym_over_minsym" flag to
2360         build_address_symbolic().  Don't output "+" for negative offsets.
2361         * printcmd.c (print_address_symbolic): Update invocation of
2362         build_address_symbolic to include a "prefer_sym_over_minsym"
2363         flag.
2364         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
2365         Restrict cases in which use of minimal symbol is preferred to that
2366         of a found symbol.  Update comments.
2367
2368         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
2369         for entry pc when entry pc is out of range for that FDE.
2370
2371 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
2372
2373         PR gdb/24839:
2374         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
2375         type.
2376
2377 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
2378
2379         * python/py-objfile.c (add_separate_debug_file): Fix comment about
2380         this function's Python signature.
2381
2382
2383 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
2384
2385         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
2386         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2387         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2388         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
2389         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
2390
2391
2392 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
2393
2394         * h8300-tdep.c (h8300_register_name_common): New.
2395         h8300_register_name): Use h8300_register_name_common.
2396         (h8300s_register_name): Likewise.
2397         (h8300sx_register_name): Likewise.
2398         (h8300h_register_nam): New.
2399         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
2400
2401
2402 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
2403
2404         * arm-tdep.c (arm_skip_cmse_entry): New function.
2405         (arm_is_sgstubs_section): New function.
2406         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
2407
2408 2019-07-22  Tom Tromey  <tom@tromey.com>
2409
2410         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
2411         Don't self-assign.
2412
2413 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2414
2415         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
2416         type_print.
2417
2418 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2419
2420         * symtab.c (search_symbols): Adjust msymbol matching type arrays
2421         so that GDB doesn't match any msymbols when searching in the
2422         TYPES_DOMAIN.
2423         (print_symbol_info): Print using typedef_print or type_print based
2424         on the type of the symbol.  Add updated FIXME comment moved from...
2425         (_initialize_symtab): ... move and update FIXME comment to above.
2426
2427 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2428
2429         * NEWS: Mention adding -q option to "info types".
2430         * symtab.c (struct info_types_options): New struct.
2431         (info_types_options_defs): New variable.
2432         (make_info_types_options_def_group): New function.
2433         (info_types_command): Use gdb::option framework to parse options.
2434         (info_types_command_completer): New function.
2435         (_initialize_symtab): Extend the help text on "info types" and
2436         register command completer.
2437
2438 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
2439
2440         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
2441         (lookup_symbol_in_objfile): Change int to block_enum and add a
2442         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
2443
2444 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
2445
2446         * MAINTAINERS (Write After Approval): Add self.
2447
2448 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2449
2450         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
2451         instruction to the dummy code region.
2452
2453 2019-07-19  Tom Tromey  <tromey@adacore.com>
2454
2455         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
2456         (ARGSUSED, PARAMS, __func__): Remove rules.
2457
2458 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2459
2460         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
2461         * features/arm/arm-with-iwmmxt.c: Remove.
2462         * features/arm/arm-with-iwmmxt.xml: Remove.
2463         * features/arm/arm-with-m-fpa-layout.c: Remove.
2464         * features/arm/arm-with-m-fpa-layout.xml: Remove.
2465         * features/arm/arm-with-m-vfp-d16.c: Remove.
2466         * features/arm/arm-with-m-vfp-d16.xml: Remove.
2467         * features/arm/arm-with-m.c: Remove.
2468         * features/arm/arm-with-m.xml: Remove.
2469         * features/arm/arm-with-neon.c: Remove.
2470         * features/arm/arm-with-neon.xml: Remove.
2471         * features/arm/arm-with-vfpv2.c: Remove.
2472         * features/arm/arm-with-vfpv2.xml: Remove.
2473         * features/arm/arm-with-vfpv3.c: Remove.
2474         * features/arm/arm-with-vfpv3.xml: Remove.
2475
2476 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2477
2478         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
2479
2480 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2481
2482         * arch/aarch32.c (aarch32_create_target_description): Create
2483         target descriptions using features.
2484         * arch/arm.c (arm_create_target_description)
2485         (arm_create_mprofile_target_description): Likewise.
2486         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
2487
2488 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2489
2490         * Makefile.in: Add new files.
2491         * aarch32-tdep.c: New file.
2492         * aarch32-tdep.h: New file.
2493         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2494         Call aarch32_read_description.
2495         * arch/aarch32.c: New file.
2496         * arch/aarch32.h: New file.
2497         * arch/arm.c (arm_create_target_description)
2498         (arm_create_mprofile_target_description): New function.
2499         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
2500         (arm_create_target_description)
2501         (arm_create_mprofile_target_description): New declaration.
2502         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
2503         read_description functions.
2504         * arm-linux-nat.c (arm_linux_nat_target::read_description):
2505         Likewise.
2506         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2507         * arm-tdep.c (tdesc_arm_list): New variable.
2508         (arm_register_g_packet_guesses): Call create description functions.
2509         (arm_read_description) (arm_read_mprofile_description): New
2510         function.
2511         * arm-tdep.h (arm_read_description)
2512         (arm_read_mprofile_description): Add declaration.
2513         * configure.tgt: Add new files.
2514
2515 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
2516
2517         * top.c (new_ui_command): Open specified terminal just once.
2518
2519 2019-07-18  Tom Tromey  <tromey@adacore.com>
2520
2521         * symtab.c (main_name): Constify return type.
2522         * symfile.c (set_initial_language): Update.
2523         * symtab.h (main_name): Constify return type.
2524
2525 2019-07-17  Tom Tromey  <tom@tromey.com>
2526
2527         * tui/tui-winsource.c (tui_update_source_window)
2528         (tui_update_source_window_as_is)
2529         (tui_update_source_windows_with_line): Remove return.
2530         * tui/tui-disasm.c (tui_show_disassem)
2531         (tui_show_disassem_and_update_source): Remove return.
2532         * tui/tui.c (tui_reset): Remove return.
2533         * tui/tui-wingeneral.c
2534         (tui_check_and_display_highlight_if_needed): Remove return.
2535
2536 2019-07-17  Tom Tromey  <tom@tromey.com>
2537
2538         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
2539
2540 2019-07-17  Tom Tromey  <tom@tromey.com>
2541
2542         * tui/tui-winsource.h (struct tui_exec_info_window)
2543         (struct tui_source_window_base): Move from tui-data.h.
2544         * tui/tui-winsource.c: Move many method definitions from
2545         elsewhere.  Remove "structuring" comments.
2546         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
2547         (tui_source_window_base::refresh_window): Move to
2548         tui-winsource.c.
2549         * tui/tui-win.c (tui_source_window_base::refresh_all)
2550         (tui_source_window_base::update_tab_width)
2551         (tui_source_window_base::set_new_height)
2552         (tui_source_window_base::do_make_visible_with_new_height): Move to
2553         tui-winsource.c.
2554         * tui/tui-source.h: Update.
2555         * tui/tui-source.c (tui_source_window_base::reset): Move to
2556         tui-winsource.c.
2557         * tui/tui-disasm.h: Update.
2558         * tui/tui-data.h (struct tui_exec_info_window): Move to
2559         tui-winsource.h.
2560         (struct tui_source_window_base): Likewise.
2561         * tui/tui-data.c (tui_source_window_base::clear_detail)
2562         (tui_source_window_base, ~tui_source_window_base): Move to
2563         tui-winsource.c.
2564
2565 2019-07-17  Tom Tromey  <tom@tromey.com>
2566
2567         * tui/tui-win.c (tui_resize_all)
2568         (tui_source_window_base::update_tab_width)
2569         (tui_adjust_win_heights): Update.
2570         (tui_win_info::make_invisible_and_set_new_height): Rename from
2571         make_invisible_and_set_new_height.
2572         * tui/tui-data.h (struct tui_win_info)
2573         <make_invisible_and_set_new_height>: New method.
2574
2575 2019-07-17  Tom Tromey  <tom@tromey.com>
2576
2577         * tui/tui.c: Update.
2578         * tui/tui-source.h (struct tui_source_window): Move from
2579         tui-data.h.
2580         * tui/tui-layout.c: Update.
2581         * tui/tui-disasm.c: Update.
2582         * tui/tui-data.h (struct tui_source_window): Move to
2583         tui-source.h.
2584
2585 2019-07-17  Tom Tromey  <tom@tromey.com>
2586
2587         * tui/tui-disasm.h (struct tui_disasm_window): Move from
2588         tui-data.h.
2589         * tui/tui-data.h (struct tui_disasm_window): Move to
2590         tui-disasm.h.
2591
2592 2019-07-17  Tom Tromey  <tom@tromey.com>
2593
2594         * tui/tui-regs.h (struct tui_data_item_window): Move from
2595         tui-data.h.
2596         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
2597         * tui/tui-data.h (struct tui_data_item_window): Move to
2598         tui-regs.h.
2599         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
2600
2601 2019-07-17  Tom Tromey  <tom@tromey.com>
2602
2603         * tui/tui.c: Update.
2604         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
2605         (tui_cmd_window::max_height): Move to tui-command.c.
2606         * tui/tui-layout.c: Update.
2607         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
2608         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
2609         tui-command.c.
2610         * tui/tui-command.h (struct tui_cmd_window): Move from
2611         tui-data.h.
2612         * tui/tui-command.c: Remove "structuring" comments.
2613         (tui_cmd_window::clear_detail)
2614         (tui_cmd_window::do_make_visible_with_new_height)
2615         (tui_cmd_window::max_height): Move from elsewhere.
2616
2617 2019-07-17  Tom Tromey  <tom@tromey.com>
2618
2619         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
2620         Now static.
2621         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
2622         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
2623
2624 2019-07-17  Tom Tromey  <tom@tromey.com>
2625
2626         * tui/tui.c: Update.
2627         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
2628         tui-regs.c.
2629         * tui/tui-windata.h: Remove file.
2630         * tui/tui-windata.c: Remove file.
2631         * tui/tui-win.c (tui_data_window::set_new_height)
2632         (tui_data_window::do_make_visible_with_new_height): Move to
2633         tui-regs.c.
2634         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
2635         * tui/tui-regs.c: Remove "structuring" comments.
2636         (tui_data_window::first_data_item_displayed)
2637         (tui_data_window::delete_data_content_windows)
2638         (tui_data_window::erase_data_content)
2639         (tui_data_window::display_all_data)
2640         (tui_data_window::refresh_all)
2641         (tui_data_window::do_scroll_vertical)
2642         (tui_data_window::clear_detail, tui_data_window::set_new_height)
2643         (tui_data_window::do_make_visible_with_new_height)
2644         (tui_data_window::refresh_window): Move from elsewhere.
2645         (_initialize_tui_regs): Move to end of file.
2646         * tui/tui-layout.c: Update.
2647         * tui/tui-hooks.c: Update.
2648         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
2649         * tui/tui-data.c (tui_data_window::clear_detail): Move to
2650         tui-regs.c.
2651         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
2652
2653 2019-07-17  Tom Tromey  <tom@tromey.com>
2654
2655         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
2656         seen.
2657
2658 2019-07-17  Tom Tromey  <tom@tromey.com>
2659
2660         * tui/tui-win.c (tui_source_window_base::set_new_height)
2661         (tui_source_window_base::do_make_visible_with_new_height): Use
2662         m_has_locator field directly.
2663         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
2664         method.
2665         (struct tui_source_window_base) <has_locator>: Likewise.
2666
2667 2019-07-17  Tom Tromey  <tom@tromey.com>
2668
2669         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
2670         Don't declare.
2671         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
2672         Remove.
2673         * tui/tui-win.c (tui_source_window_base::set_new_height)
2674         (tui_source_window_base::set_new_height)
2675         (make_invisible_and_set_new_height)
2676         (tui_source_window_base::do_make_visible_with_new_height)
2677         (tui_source_window_base::do_make_visible_with_new_height):
2678         Update.
2679         * tui/tui-layout.c (show_source_disasm_command, show_data)
2680         (show_source_or_disasm_and_command): Update.
2681         * tui/tui-layout.c (show_layout): Update.
2682
2683 2019-07-17  Tom Tromey  <tom@tromey.com>
2684
2685         * tui/tui-layout.c (make_data_window): Remove.
2686         (show_data): Unify creation and re-initialization cases.
2687
2688 2019-07-17  Tom Tromey  <tom@tromey.com>
2689
2690         * tui/tui-layout.c (make_source_window, make_disasm_window):
2691         Remove.
2692         (show_data): Unify creation and re-initialization cases.
2693
2694 2019-07-17  Tom Tromey  <tom@tromey.com>
2695
2696         * tui/tui-layout.c (make_command_window): Remove.
2697         (show_source_disasm_command, show_source_or_disasm_and_command):
2698         Unify creation and re-initialization cases.
2699
2700 2019-07-17  Tom Tromey  <tom@tromey.com>
2701
2702         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
2703         creation and re-initialization cases.
2704
2705 2019-07-17  Tom Tromey  <tom@tromey.com>
2706
2707         * tui/tui-regs.c (tui_get_register): Return void.
2708
2709 2019-07-17  Tom Tromey  <tom@tromey.com>
2710
2711         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
2712         Simplify.
2713
2714 2019-07-17  Tom Tromey  <tom@tromey.com>
2715
2716         * tui/tui-layout.c (show_source_disasm_command): Simplify window
2717         resetting.
2718
2719 2019-07-17  Tom Tromey  <tom@tromey.com>
2720
2721         * tui/tui.h (tui_set_layout_by_name): Don't declare.
2722         * tui/tui-regs.c (tui_reg_layout): New function.
2723         (tui_show_registers, tui_reg_command): Use it.
2724         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
2725         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
2726         parameters.
2727         (tui_layout_command): Remove.
2728
2729 2019-07-17  Tom Tromey  <tom@tromey.com>
2730
2731         * tui/tui-layout.h (tui/tui-layout): Return void.
2732         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
2733
2734 2019-07-17  Tom Tromey  <tom@tromey.com>
2735
2736         * tui/tui-layout.c (show_source_disasm_command, show_data):
2737         Update.
2738         (reset_locator): Remove.
2739         (show_source_or_disasm_and_command): Update.
2740
2741 2019-07-17  Tom Tromey  <tom@tromey.com>
2742
2743         * tui/tui-source.c (tui_source_window_base::reset): Remove
2744         win_type parameter.
2745         * tui/tui-layout.c (make_command_window, make_source_window)
2746         (make_disasm_window, make_data_window)
2747         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
2748         (reset_locator, show_source_or_disasm_and_command): Update.
2749         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
2750         win_type parameter.
2751         (struct tui_source_window_base) <reset>: Likewise.
2752
2753 2019-07-17  Tom Tromey  <tom@tromey.com>
2754
2755         * tui/tui-layout.c (show_source_disasm_command): Use
2756         reset_locator.
2757         (reset_locator): New function.
2758         (init_and_make_win): Remove.
2759         (show_source_or_disasm_and_command): Use reset_locator.
2760
2761 2019-07-17  Tom Tromey  <tom@tromey.com>
2762
2763         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
2764         condition.
2765         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
2766         Remove condition.
2767         * tui/tui-source.c (tui_source_window_base::reset): New method.
2768         * tui/tui-layout.c (make_command_window): Don't call
2769         init_and_make_win.
2770         (make_source_window, make_disasm_window): Don't call
2771         make_source_or_disasm_window.
2772         (make_data_window): Don't call init_and_make_win.  Change calling
2773         convention.
2774         (show_source_disasm_command, show_data): Simplify.
2775         (make_source_or_disasm_window): Remove.
2776         (show_source_or_disasm_and_command): Simplify.
2777         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
2778         (struct tui_source_window_base) <reset>: Likewise.
2779         <execution_info>: Remove initializer.
2780         * tui/tui-data.c (tui_source_window_base): Initialize
2781         execution_info.
2782
2783 2019-07-17  Tom Tromey  <tom@tromey.com>
2784
2785         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
2786         variable.
2787
2788 2019-07-17  Tom Tromey  <tom@tromey.com>
2789
2790         * tui/tui.c (tui_rl_other_window): Update.
2791         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
2792         superclass method first.  Always iterate over regs_content.
2793         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
2794         method.
2795         * tui/tui-win.c (tui_set_focus_command): Update.
2796
2797 2019-07-17  Tom Tromey  <tom@tromey.com>
2798
2799         * tui/tui-win.c (tui_set_focus_command): Rename from
2800         tui_set_focus.  Call tui_enable.
2801         (tui_set_focus_command): Remove.
2802
2803 2019-07-17  Tom Tromey  <tom@tromey.com>
2804
2805         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
2806         refresh_window.
2807         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
2808         touchwin.
2809         (tui_data_window::refresh_window): Call refresh_window on data
2810         items.  Always call superclass refresh_window.
2811         (tui_win_info::refresh): Remove.
2812         (tui_source_window_base::refresh_window): Update.
2813         (tui_refresh_all): Update.
2814         * tui/tui-layout.c (show_source_disasm_command): Remove call to
2815         refresh_window.
2816         (show_source_or_disasm_and_command): Likewise.
2817         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
2818         (struct tui_source_window_base) <refresh>: Likewise.
2819
2820 2019-07-17  Tom Tromey  <tom@tromey.com>
2821
2822         * tui/tui-winsource.c (tui_clear_source_content)
2823         (tui_show_source_content): Update.
2824         * tui/tui-source.c (tui_source_window::showing_source_p): Check
2825         whether content is empty.
2826         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
2827         Remove.
2828
2829 2019-07-17  Tom Tromey  <tom@tromey.com>
2830
2831         * tui/tui-winsource.c (tui_erase_source_content): Clear the
2832         window's contents.
2833         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
2834         * tui/tui-source.c (tui_set_source_content_nil): Remove.
2835
2836 2019-07-17  Tom Tromey  <tom@tromey.com>
2837
2838         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
2839         (struct tui_data_item_window): Update.
2840
2841 2019-07-17  Tom Tromey  <tom@tromey.com>
2842
2843         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
2844         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
2845         defines.
2846
2847 2019-07-17  Tom Tromey  <tom@tromey.com>
2848
2849         * tui/tui-winsource.h (tui_erase_source_content)
2850         (tui_clear_source_content): Remove "display_prompt" parameter.
2851         * tui/tui-winsource.c (tui_update_source_window_as_is)
2852         (tui_update_source_windows_with_addr): Update.
2853         (tui_clear_source_content): Remove "display_prompt" parameter.
2854         (tui_erase_source_content): Likewise.  Simplify.
2855         (tui_show_source_content): Update.
2856         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2857         * tui/tui-stack.c (tui_show_frame_info): Update.
2858         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
2859         Remove defines.
2860
2861 2019-07-17  Tom Tromey  <tom@tromey.com>
2862
2863         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2864         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
2865         parameter.
2866         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
2867         parameter.
2868
2869 2019-07-17  Tom Tromey  <tom@tromey.com>
2870
2871         * tui/tui-winsource.c (tui_clear_source_content)
2872         (tui_show_source_content, tui_show_exec_info_content)
2873         (tui_clear_exec_info_content): Update.
2874         * tui/tui-stack.c (tui_show_locator_content): Update.
2875         (tui_show_frame_info): Update.
2876         * tui/tui-source.h (tui_source_window): Don't declare.
2877         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
2878         from tui_source_is_displayed.
2879         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
2880         Remove field.
2881         (struct tui_source_window_base) <content_in_use>: New field.  Now
2882         bool.
2883         (struct tui_source_window) <showing_source_p>: New method.
2884         (TUI_SRC_WIN): Change cast.
2885         * tui/tui-data.c (tui_initialize_static_data): Update.
2886
2887 2019-07-17  Tom Tromey  <tom@tromey.com>
2888
2889         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
2890         location_matches_p.
2891         * tui/tui-source.c (tui_source_window::location_matches_p): New
2892         method.
2893         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
2894         method.
2895         * tui/tui-data.h (struct tui_source_window_base)
2896         <location_matches_p>: New method.
2897         (struct tui_source_window, struct tui_disasm_window)
2898         <location_matches_p>: Likewise.
2899
2900 2019-07-17  Tom Tromey  <tom@tromey.com>
2901
2902         * tui/tui-win.c (tui_set_win_height_command): Rename from
2903         tui_set_win_height.
2904         (tui_set_win_height_command): Remove.
2905
2906 2019-07-17  Tom Tromey  <tom@tromey.com>
2907
2908         * tui/tui-source.c (tui_source_window): New constructor.  Add
2909         observer.
2910         (~tui_source_window): New destructor.
2911         (tui_source_window::style_changed): New method.
2912         * tui/tui-hooks.c (tui_redisplay_source): Remove.
2913         (tui_attach_detach_observers): Update.
2914         * tui/tui-data.h (struct tui_source_window): Make constructor not
2915         inline.  Add destructor.
2916         (struct tui_source_window) <style_changed>: New method.
2917         <m_observable>: New member.
2918
2919 2019-07-17  Tom Tromey  <tom@tromey.com>
2920
2921         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
2922         * tui/tui-win.c (tui_resize_all): Fix typo.
2923
2924 2019-07-17  Tom Tromey  <tom@tromey.com>
2925
2926         * tui/tui-wingeneral.h (tui_refresh_all): Update.
2927         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
2928         (tui_refresh_all): Remove "list" parameter.  Use foreach.
2929         * tui/tui-win.c (window_name_completer): Use foreach.
2930         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
2931         (update_tab_width): Likewise.
2932         * tui/tui-layout.c (show_layout): Update.
2933         * tui/tui-data.h (class tui_window_iterator): New.
2934         (struct all_tui_windows): New.
2935         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
2936
2937 2019-07-17  Tom Tromey  <tom@tromey.com>
2938
2939         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
2940         parameter.  Don't reference globals.
2941         (tui_reg_command): Update.
2942
2943 2019-07-17  Tom Tromey  <tom@tromey.com>
2944
2945         * tui/tui-regs.c (tui_show_registers): Simplify.
2946
2947 2019-07-17  Tom Tromey  <tom@tromey.com>
2948
2949         * tui/tui-regs.c (tui_show_registers): Update.
2950         (tui_show_register_group): Add win_info parameter.
2951
2952 2019-07-17  Tom Tromey  <tom@tromey.com>
2953
2954         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
2955         Rename from tui_display_reg_element_at_line.
2956         (tui_data_window::display_registers_from_line): Update.
2957         * tui/tui-data.h (struct tui_data_window)
2958         <display_reg_element_at_line>: New method.
2959
2960 2019-07-17  Tom Tromey  <tom@tromey.com>
2961
2962         * tui/tui-regs.h (tui_display_registers_from)
2963         (tui_display_registers_from_line): Don't declare.
2964         * tui/tui-windata.c (tui_data_window::display_all_data)
2965         (tui_data_window::refresh_all)
2966         (tui_data_window::do_scroll_vertical): Update.
2967         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
2968         from tui_display_registers_from.
2969         (tui_display_reg_element_at_line): Update.
2970         (tui_data_window::display_registers_from_line): Rename from
2971         tui_display_registers_from_line.
2972         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
2973         display_registers_from_line>: New methods.
2974
2975 2019-07-17  Tom Tromey  <tom@tromey.com>
2976
2977         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
2978         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
2979         from tui_erase_data_content.
2980         (tui_data_window::display_all_data)
2981         (tui_data_window::refresh_all)
2982         (tui_data_window::do_scroll_vertical): Update.
2983         * tui/tui-regs.c (tui_show_registers): Update.
2984         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
2985         New method.
2986
2987 2019-07-17  Tom Tromey  <tom@tromey.com>
2988
2989         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
2990         declare.
2991         * tui/tui-windata.c
2992         (tui_data_window::delete_data_content_windows): Rename from
2993         tui_delete_data_content_windows.
2994         (tui_data_window::display_all_data)
2995         (tui_data_window::do_scroll_vertical): Update.
2996         * tui/tui-data.h (struct tui_data_window)
2997         <delete_data_content_windows>: New method.
2998
2999 2019-07-17  Tom Tromey  <tom@tromey.com>
3000
3001         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
3002         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
3003
3004 2019-07-17  Tom Tromey  <tom@tromey.com>
3005
3006         * tui/tui-windata.h (tui_display_all_data): Don't declare.
3007         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
3008         from tui_display_all_data.
3009         * tui/tui-win.c
3010         (tui_data_window::do_make_visible_with_new_height): Update.
3011         * tui/tui-regs.c (tui_show_registers): Update.
3012         * tui/tui-layout.c (tui_set_layout): Update.
3013         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
3014         method.
3015
3016 2019-07-17  Tom Tromey  <tom@tromey.com>
3017
3018         * tui/tui-windata.h (tui_display_data_from): Don't declare.
3019         * tui/tui-windata.c (tui_display_data_from): Remove.
3020         (tui_data_window::refresh_all): Update.
3021
3022 2019-07-17  Tom Tromey  <tom@tromey.com>
3023
3024         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
3025         * tui/tui-windata.c (tui_display_data_from_line): Remove.
3026         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
3027         tui_display_registers_from_line.
3028         * tui/tui-regs.h (tui_display_registers_from_line): Update.
3029         * tui/tui-regs.c (tui_display_registers_from_line): Remove
3030         "force_display" parameter.
3031
3032 2019-07-17  Tom Tromey  <tom@tromey.com>
3033
3034         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
3035         declare.
3036         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
3037         Rename from tui_first_reg_element_no_inline.
3038         (tui_display_reg_element_at_line)
3039         (tui_display_registers_from_line): Update.
3040         * tui/tui-data.h (struct tui_data_window)
3041         <first_reg_element_no_inline>: New method.
3042
3043 2019-07-17  Tom Tromey  <tom@tromey.com>
3044
3045         * tui/tui-windata.c (tui_display_data_from)
3046         (tui_data_window::do_scroll_vertical): Update.
3047         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
3048         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
3049         Rename from tui_line_from_reg_element_no.
3050         (tui_display_registers_from_line): Update.
3051         * tui/tui-data.h (struct tui_data_window)
3052         <line_from_reg_element_no>: New method.
3053
3054 2019-07-17  Tom Tromey  <tom@tromey.com>
3055
3056         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
3057         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
3058         tui_last_regs_line_no.
3059         (tui_display_reg_element_at_line)
3060         (tui_display_registers_from_line): Update.
3061         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
3062         method.
3063
3064 2019-07-17  Tom Tromey  <tom@tromey.com>
3065
3066         PR tui/24722:
3067         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
3068         (tui_update_breakpoint_info): Add "being_deleted" parameter.
3069         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3070         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
3071         (tui_update_breakpoint_info): Likewise.
3072         * tui/tui-hooks.c (tui_event_create_breakpoint)
3073         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
3074         Update.
3075
3076 2019-07-17  Tom Tromey  <tom@tromey.com>
3077
3078         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
3079
3080 2019-07-17  Tom Tromey  <tom@tromey.com>
3081
3082         * tui/tui-winsource.c (tui_update_source_window_as_is)
3083         (tui_update_source_windows_with_addr): Update.
3084         * tui/tui-source.h (tui_set_source_content)
3085         (tui_show_symtab_source): Add "win_info" parameter.
3086         * tui/tui-source.c (tui_set_source_content): Add "win_info"
3087         parameter.
3088         (tui_show_symtab_source): Likewise.
3089
3090 2019-07-17  Tom Tromey  <tom@tromey.com>
3091
3092         * tui/tui-wingeneral.c
3093         (tui_check_and_display_highlight_if_needed): Check can_highlight.
3094
3095 2019-07-17  Tom Tromey  <tom@tromey.com>
3096
3097         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
3098         (struct tui_cmd_window) <can_scroll>: New method.
3099         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
3100         method.
3101
3102 2019-07-17  Tom Tromey  <tromey@adacore.com>
3103
3104         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
3105         do_field_signed>: Rename.  Change type of "value".
3106         * ui-out.c (ui_out::field_signed): Rename from field_int.
3107         Change type of "value".
3108         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
3109         type of "value".
3110         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
3111         do_field_int.  Change type of "value".
3112         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
3113         do_field_int.  Change type of "value".
3114         * tracepoint.c (trace_status_mi, tfind_1)
3115         (print_one_static_tracepoint_marker): Update.
3116         * thread.c (print_thread_info_1, print_selected_thread_frame):
3117         Update.
3118         * stack.c (print_frame, print_frame_info): Update.
3119         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
3120         Update.
3121         * source.c (print_source_lines_base): Update.
3122         * skip.c (info_skip_command): Update.
3123         * record-btrace.c (btrace_ui_out_decode_error)
3124         (btrace_call_history_src_line): Update.
3125         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
3126         Update.
3127         * progspace.c (print_program_space): Update.
3128         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
3129         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
3130         do_field_int.  Change type of "value".
3131         * mi/mi-out.c (mi_ui_out::do_table_begin)
3132         (mi_ui_out::do_table_header): Update.
3133         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
3134         type of "value".
3135         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
3136         (mi_cmd_data_list_changed_registers, output_register)
3137         (mi_cmd_data_read_memory, mi_load_progress)
3138         (mi_cmd_trace_frame_collected): Update.
3139         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
3140         Update.
3141         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
3142         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
3143         (mi_cmd_var_list_children, varobj_update_one): Update.
3144         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
3145         (mi_cmd_stack_list_args, list_arg_or_local): Update.
3146         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
3147         * inferior.c (print_inferior): Update.
3148         * gdb_bfd.c (print_one_bfd): Update.
3149         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3150         Update.
3151         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
3152         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
3153         do_field_int.  Change type of "value".
3154         * cli-out.c (cli_ui_out::do_field_signed): Rename from
3155         do_field_int.  Change type of "value".
3156         * breakpoint.c (watchpoint_check, print_breakpoint_location)
3157         (print_one_breakpoint_location, print_it_catch_fork)
3158         (print_one_catch_fork, print_it_catch_vfork)
3159         (print_one_catch_vfork, print_it_catch_solib)
3160         (print_it_catch_exec, print_it_ranged_breakpoint)
3161         (print_mention_watchpoint, print_mention_masked_watchpoint)
3162         (bkpt_print_it, update_static_tracepoint): Update.
3163         * break-catch-throw.c (print_it_exception_catchpoint): Update.
3164         * break-catch-syscall.c (print_it_catch_syscall): Update.
3165         * ada-tasks.c (print_ada_task_info): Update.
3166         * ada-lang.c (print_it_exception, print_mention_exception):
3167         Update.
3168
3169 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
3170
3171         PR breakpoints/24541
3172         * gdbarch.c: Regenerate.
3173         * gdbarch.h: Regenerate.
3174         * gdbarch.sh: Adjust return type and parameter types for
3175         'stap_adjust_register'.
3176         (i386_stap_adjust_register): Adjust signature and return new
3177         register name.
3178         * stap-probe.c (stap_parse_register_operand): Adjust use of
3179         'gdbarch_stap_adjust_register'.
3180
3181 2019-07-17  Tom Tromey  <tromey@adacore.com>
3182
3183         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
3184         declare VEC.
3185         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
3186         std::vector.
3187         (struct s390_process_info): Add initializers.
3188         (s390_add_process): Use new.
3189         (s390_linux_nat_target::low_forget_process): Use delete.
3190         (s390_linux_nat_target::low_new_fork)
3191         (s390_linux_nat_target::stopped_by_watchpoint)
3192         (s390_linux_nat_target::low_prepare_to_resume)
3193         (s390_linux_nat_target::insert_watchpoint)
3194         (s390_linux_nat_target::insert_hw_breakpoint)
3195         (s390_linux_nat_target::remove_watchpoint)
3196         (s390_linux_nat_target::remove_hw_breakpoint): Update.
3197
3198 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3199
3200         * aarch64-fbsd-nat.c: Include regcache.h.
3201         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
3202         argument.
3203         (aarch64_fbsd_nat_target::fetch_registers)
3204         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
3205         variable.
3206         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
3207
3208 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3209
3210         * fbsd-nat.c: Include gdbarch.h.
3211
3212 2019-07-15  Tom Tromey  <tromey@adacore.com>
3213
3214         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
3215
3216 2019-07-15  Tom Tromey  <tromey@adacore.com>
3217
3218         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
3219         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
3220         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
3221         * cli-out.c (cli_ui_out::do_field_int): New method.
3222         * ui-out.c (ui_out::field_unsigned): New method.
3223         * symfile.c (generic_load): Use field_unsigned.
3224         (print_transfer_performance): Likewise.
3225         * record-btrace.c (ui_out_field_uint): Remove.
3226         (btrace_call_history_insn_range, btrace_call_history): Use
3227         field_unsigned.
3228         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
3229         field_unsigned.
3230         * ui-out.h (class ui_out) <field_unsigned>: New method.
3231         <do_field_unsigned>: Likewise.
3232
3233 2019-07-15  Tom Tromey  <tromey@adacore.com>
3234
3235         * mi/mi-main.c (list_available_thread_groups): Use field_string.
3236         * mi/mi-interp.c (mi_memory_changed): Use field_string.
3237         * target.c (flash_erase_command): Use field_string.
3238         * infrun.c (print_signal_received_reason): Use field_string.
3239         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
3240         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
3241         field_string.
3242         * ada-tasks.c (print_ada_task_info): Use field_string.
3243
3244 2019-07-15  Tom Tromey  <tromey@adacore.com>
3245
3246         * target.c (flash_erase_command): Use field_core_addr.
3247         * symfile.c (generic_load): Use field_core_addr.
3248         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
3249         Use field_core_addr.
3250         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
3251         field_core_addr.
3252
3253 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3254
3255         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
3256         value if its desired type is smaller than a CORE_ADDR and signed.
3257
3258 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3259
3260         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
3261         of changes to field names, and use new is_reference field to
3262         decide if a property is a reference or not.
3263         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
3264         field.
3265         (struct dwarf2_property_baton): Update header comment, rename
3266         'referenced_type' to 'property_type' and update comments.
3267         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
3268         default property type, store in property baton, update to take
3269         accound of renamed field.
3270         (read_func_scope): Update call to attr_to_dynamic_prop.
3271         (read_array_type): Likewise.
3272         (dwarf2_per_cu_addr_sized_int_type): New function.
3273         (read_subrange_index_type): Move type finding code to
3274         dwarf2_per_cu_addr_sized_int_type.
3275         (read_subrange_type): Update calls to attr_to_dynamic_prop.
3276         (dwarf2_per_cu_addr_type): New function.
3277         (set_die_type): Update calls to attr_to_dynamic_prop.
3278
3279 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3280
3281         * dwarf2read.c (read_subrange_index_type): New function.
3282         (read_subrange_type): Move code into new function and call it.
3283         * gdbtypes.c (create_range_type): Add some asserts.
3284
3285 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3286
3287         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
3288         update return statements.
3289         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
3290         declaration, and update comment to match.
3291         * gdbtypes.c (resolve_dynamic_array): Update call to
3292         dwarf2_evaluate_property to match new return type.
3293
3294 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3295
3296         * valarith.c (value_subscripted_rvalue): Change lowerbound
3297         parameter type from int to LONGEST.
3298         * value.h (value_subscripted_rvalue): Likewise in declaration.
3299
3300 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3301
3302         * cli/cli-utils.c (info_print_command_completer): New function.
3303         * cli/cli-utils.h: Add 'completer.h' include, and forward
3304         declaration for 'struct cmd_list_element'.
3305         (info_print_command_completer): Declare.
3306         * stack.c (_initialize_stack): Add completer for 'info locals' and
3307         'info args'.
3308         * symtab.c (_initialize_symtab): Add completer for 'info
3309         variables' and 'info functions'.
3310         * NEWS: Mention completion for additional info commands.
3311
3312 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3313
3314         * cli/cli-utils.c (extract_info_print_args): Delete.
3315         (extract_arg_maybe_quoted): Delete.
3316         (info_print_options_defs): New variable.
3317         (make_info_print_options_def_group): New function.
3318         (extract_info_print_options): Define new function.
3319         * cli/cli-utils.h (extract_info_print_args): Delete.
3320         (struct info_print_options): New structure.
3321         (extract_info_print_options): Declare new function.
3322         * stack.c (info_locals_command): Update to use new
3323         extract_info_print_options, also add a header comment.
3324         (info_args_command): Likewise.
3325         * symtab.c (info_variables_command): Likewise.
3326         (info_functions_command): Likewise.
3327
3328 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3329
3330         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
3331         to extract string arguments.
3332         * common/common-utils.c (extract_string_maybe_quoted): New function.
3333         * common/common-utils.h (extract_string_maybe_quoted): Declare.
3334
3335 2019-07-11  Tom Tromey  <tromey@adacore.com>
3336
3337         * main.c (get_init_files): Use GDBINIT, not gdbinit.
3338         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
3339         * top.h (gdbinit): Don't declare.
3340         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
3341         into...
3342         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
3343         * top.c (gdb_init): Don't call init_cli_cmds.
3344         (gdbinit): Remove.
3345         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
3346
3347 2019-07-11  Tom Tromey  <tromey@adacore.com>
3348
3349         * python/py-inferior.c (add_thread_object): Don't use thread_obj
3350         after it has been moved.
3351
3352 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3353
3354         * valops.c (value_must_coerce_to_target): Change return type to
3355         bool.
3356         * value.h (value_must_coerce_to_target): Likewise.
3357
3358 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
3359
3360         * breakpoint.c (is_hardware_watchpoint): Remove
3361         forward-declaration.
3362         (is_masked_watchpoint): Change return type to bool.
3363         (is_tracepoint): Likewise.
3364         (is_breakpoint): Likewise.
3365         (is_hardware_watchpoint): Likewise.
3366         (is_watchpoint): Likewise.
3367         (is_no_memory_software_watchpoint): Likewise.
3368         (is_catchpoint): Likewise.
3369         (breakpoint_1): Make FILTER parameter's return type bool.
3370         is_masked_watchpoint): Change return type to bool.
3371         (save_breakpoints): Make FILTER parameter's return type bool.
3372         * breakpoint.h (is_breakpoint): Change return type to bool.
3373         (is_watchpoint): Likewise.
3374         (is_catchpoint): Likewise.
3375         (is_tracepoint): Likewise.
3376
3377 2019-07-10  Tom Tromey  <tom@tromey.com>
3378
3379         * defs.h: Don't include gdbarch.h.
3380         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
3381         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
3382         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
3383         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
3384         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
3385         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
3386         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
3387         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
3388         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
3389         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
3390         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
3391         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
3392         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
3393         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
3394         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
3395         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
3396         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
3397         record-btrace.c, record.h, regcache-dump.c, regcache.h,
3398         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
3399         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
3400         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
3401         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
3402         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
3403         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
3404         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
3405         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
3406         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
3407
3408 2019-07-10  Tom Tromey  <tromey@adacore.com>
3409
3410         * ada-lang.h (is_ada_exception_catchpoint): Declare.
3411         * breakpoint.c (init_ada_exception_breakpoint): Register as
3412         bp_catchpoint.
3413         (print_one_breakpoint_location, print_one_breakpoint): Use
3414         is_ada_exception_catchpoint.
3415         * ada-lang.c (class ada_catchpoint_location): Pass
3416         bp_loc_software_breakpoint to bp_location constructor.
3417         (is_ada_exception_catchpoint): New function.
3418
3419 2019-07-10  Tom Tromey  <tromey@adacore.com>
3420
3421         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
3422         VEC.
3423         (struct arm_exidx_entry): New method operator<.
3424         (struct arm_exidx_data) <section_maps>: Change type.
3425         (arm_exidx_data_free): Remove.
3426         (arm_exidx_data_key): Change type.  Move lower.
3427         (arm_exidx_new_objfile): Update.
3428         (arm_compare_exidx_entries): Remove.
3429         (arm_find_exidx_entry, _initialize_arm_tdep)
3430
3431 2019-07-10  Tom Tromey  <tromey@adacore.com>
3432
3433         * solib-spu.c (ocl_program_data_key): Change type.
3434         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
3435         Update.
3436
3437 2019-07-10  Tom Tromey  <tromey@adacore.com>
3438
3439         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
3440         (struct solib_aix_inferior_data) <library_list>: Change type.
3441         (solib_aix_inferior_data_handle): Change type.
3442         (get_solib_aix_inferior_data): Update.
3443         (solib_aix_free_library_list): Remove.
3444         (library_list_start_library): Update.
3445         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
3446         return type.
3447         (solib_aix_get_library_list)
3448         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
3449         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
3450
3451 2019-07-10  Tom Tromey  <tromey@adacore.com>
3452
3453         * solib-dsbt.c (struct dsbt_info): Add initializers.
3454         (solib_dsbt_pspace_data): Change type.
3455         (dsbt_pspace_data_cleanup): Remove.
3456         (get_dsbt_info, _initialize_dsbt_solib): Update.
3457
3458 2019-07-10  Tom Tromey  <tromey@adacore.com>
3459
3460         * spu-tdep.c (spu_overlay_data): Change type.
3461         (spu_get_overlay_table, spu_overlay_new_objfile)
3462         (_initialize_spu_tdep): Update.
3463
3464 2019-07-10  Tom Tromey  <tromey@adacore.com>
3465
3466         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
3467         destructor.
3468         (dbx_objfile_data_key): Change type and declare later.
3469         (DBX_SYMFILE_INFO): Rewrite.
3470         * dbxread.c (dbx_objfile_data_key): Change type.
3471         (dbx_symfile_init): Update.
3472         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
3473         (coffstab_build_psymtabs, elfstab_build_psymtabs)
3474         (stabsect_build_psymtabs, _initialize_dbxread): Update.
3475
3476 2019-07-10  Tom Tromey  <tromey@adacore.com>
3477
3478         * jit.c (jit_program_space_key): Change type.  Move lower.
3479         (get_jit_program_space_data): Update.
3480         (jit_program_space_data_cleanup): Remove.
3481         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
3482         Update.
3483         (struct jit_program_space_data): Add initializers.
3484
3485 2019-07-10  Tom Tromey  <tromey@adacore.com>
3486
3487         * solib-darwin.c (struct darwin_info): Add initializers.
3488         (solib_darwin_pspace_data): Change type.
3489         (darwin_pspace_data_cleanup): Remove.
3490         (get_darwin_info, _initialize_darwin_solib): Update.
3491
3492 2019-07-10  Tom Tromey  <tromey@adacore.com>
3493
3494         * remote-sim.c (struct sim_inferior_data): Add initializers,
3495         constructor, and destructor.
3496         (sim_inferior_data_key): Change type.  Move lower.
3497         (check_for_duplicate_sim_descriptor): Update.
3498         (get_sim_inferior_data): Use new.  Update.
3499         (~sim_inferior_data_cleanup): Rename from
3500         sim_inferior_data_cleanup.  Simplify.
3501         (gdbsim_close_inferior, simulator_command)
3502         (sim_command_completer, _initialize_remote_sim): Update.
3503         (next_pid, INITIAL_PID): Move earlier.
3504
3505 2019-07-10  Tom Tromey  <tromey@adacore.com>
3506
3507         * python/python-internal.h (create_thread_object): Return
3508         gdbpy_ref.
3509         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
3510         * python/py-inferior.c (struct threadlist_entry): Add
3511         constructor.
3512         <thread_obj>: Now a gdbpy_ref.
3513         (thread_to_thread_object): Update.
3514         (add_thread_object): Use new.
3515         (delete_thread_object): Use delete.
3516         (infpy_threads): Update.
3517         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
3518         GIL.
3519
3520 2019-07-10  Tom Tromey  <tromey@adacore.com>
3521
3522         * valops.c (value_cast): Specialize error message for Ada.
3523
3524 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3525
3526         * breakpoint.c (breakpoint_1): Update doc and parameter names.
3527
3528 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3529
3530         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
3531         bpstat_should_step): Return bool, adjust comments.
3532         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
3533         bpstat_should_step): Likewise.
3534
3535 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3536
3537         * features/Makefile: Use feature target descriptions for Arm.
3538         * features/arm/arm-core.c: Generate new file.
3539         * features/arm/arm-fpa.c: Likewise.
3540         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
3541         * features/arm/arm-m-profile.c: Likewise.
3542         * features/arm/arm-vfpv2.c: Likewise.
3543         * features/arm/arm-vfpv3.c: Likewise.
3544         * features/arm/xscale-iwmmxt.c: Likewise.
3545         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
3546
3547 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3548
3549         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
3550         ptrace earlier.
3551
3552 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3553
3554         * features/aarch64-pauth.c: Regenerate.
3555
3556 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
3557
3558         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
3559         bool.
3560         (bpstat_what): Use false instead of 0.
3561
3562 2019-07-09  Pedro Alves  <palves@redhat.com>
3563
3564         * break-catch-throw.c (is_exception_catchpoint): New.
3565         * breakpoint.c (print_one_breakpoint_location): New parameter
3566         'raw_loc'.  Handle it.  Use
3567         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
3568         looking at the breakpoint's type.
3569         (print_one_breakpoint): If handling "maint info breakpoints", also
3570         print locations of exception catchpoints.
3571         * breakpoint.h (is_exception_catchpoint): Declare.
3572
3573 2019-07-09  Pedro Alves  <palves@redhat.com>
3574
3575         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
3576         "addr" field.
3577         (allocate_location_exception_catchpoint): New.
3578         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
3579         (initialize_throw_catchpoint_ops): Install
3580         allocate_location_exception_catchpoint as allocate_location
3581         method.
3582         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
3583         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
3584         bp_loc_other.
3585         (breakpoint_address_is_meaningful): Delete.
3586         (bl_address_is_meaningful): New.
3587         (breakpoint_locations_match): Adjust comment.
3588         (bp_location_from_bp_type): New, factored out of...
3589         (bp_location::bp_location(breakpoint *)): ... this.
3590         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
3591         factored out of...
3592         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
3593         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
3594         breakpoint_address_is_meaningful.
3595         (bp_locations_compare): Adjust comment.
3596         (update_global_location_list): Use bl_address_is_meaningful
3597         instead of breakpoint_address_is_meaningful.
3598         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
3599         explicit.
3600         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
3601         * python/py-breakpoint.c (bppy_get_location): No longer check
3602         whether location is null.
3603
3604 2019-07-09  Pedro Alves  <palves@redhat.com>
3605
3606         PR c++/15468
3607         * breakpoint.c (print_one_breakpoint_location): Remove
3608         single-location assert.
3609
3610 2019-07-09  Tom Tromey  <tom@tromey.com>
3611
3612         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
3613         * configure: Rebuild.
3614         * configure.ac: Change common to gdbsupport.
3615         * gdbsupport: Rename from common.
3616         * acinclude.m4: Change common to gdbsupport.
3617         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
3618         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
3619         gdbsupport.
3620         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
3621         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
3622         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
3623         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
3624         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
3625         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
3626         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
3627         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
3628         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
3629         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
3630         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
3631         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
3632         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
3633         coff-pe-read.c, command.h, compile/compile-c-support.c,
3634         compile/compile-c.h, compile/compile-cplus-symbols.c,
3635         compile/compile-cplus-types.c, compile/compile-cplus.h,
3636         compile/compile-loc2c.c, compile/compile.c, completer.c,
3637         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
3638         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
3639         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
3640         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
3641         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
3642         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
3643         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
3644         features/aarch64-core.c, features/aarch64-fpu.c,
3645         features/aarch64-pauth.c, features/aarch64-sve.c,
3646         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
3647         features/i386/32bit-core.c, features/i386/32bit-linux.c,
3648         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
3649         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
3650         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
3651         features/i386/64bit-core.c, features/i386/64bit-linux.c,
3652         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
3653         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
3654         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
3655         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
3656         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
3657         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
3658         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
3659         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
3660         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
3661         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
3662         go32-nat.c, guile/guile.c, guile/scm-ports.c,
3663         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
3664         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
3665         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
3666         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
3667         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
3668         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
3669         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
3670         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
3671         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
3672         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
3673         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
3674         minsyms.c, mips-linux-tdep.c, namespace.h,
3675         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
3676         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
3677         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
3678         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
3679         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
3680         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
3681         nat/linux-waitpid.c, nat/mips-linux-watch.c,
3682         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
3683         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
3684         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
3685         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
3686         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
3687         procfs.c, producer.c, progspace.h, psymtab.h,
3688         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
3689         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
3690         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
3691         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
3692         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
3693         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
3694         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
3695         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
3696         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
3697         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
3698         target-memory.c, target.c, target.h, target/waitstatus.c,
3699         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
3700         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
3701         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
3702         unittests/array-view-selftests.c,
3703         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
3704         unittests/common-utils-selftests.c,
3705         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
3706         unittests/format_pieces-selftests.c,
3707         unittests/function-view-selftests.c,
3708         unittests/lookup_name_info-selftests.c,
3709         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
3710         unittests/mkdir-recursive-selftests.c,
3711         unittests/observable-selftests.c,
3712         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
3713         unittests/parse-connection-spec-selftests.c,
3714         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
3715         unittests/scoped_fd-selftests.c,
3716         unittests/scoped_mmap-selftests.c,
3717         unittests/scoped_restore-selftests.c,
3718         unittests/string_view-selftests.c, unittests/style-selftests.c,
3719         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
3720         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
3721         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
3722         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
3723         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
3724         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
3725
3726 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3727
3728         * linespec.c (decode_digits_list_mode): Set explicit_line to a
3729         bool value.
3730         (decode_digits_ordinary): Set explicit_line field in sal.
3731         * symtab.c (skip_prologue_sal): Don't skip prologue for a
3732         symtab_and_line that was set on an explicit line number in
3733         assembler code.  Do always update the recorded symtab and line if
3734         we do skip the prologue.
3735
3736 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3737
3738         * breakpoint.c (set_breakpoint_location_function): Remove
3739         explicit_loc parameter.
3740         (momentary_breakpoint_from_master): Update call to
3741         set_breakpoint_location_function.
3742         (add_location_to_breakpoint): Likewise.
3743
3744 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3745
3746         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
3747         required features based on default bfd type when no specific bfd
3748         is present.
3749
3750 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3751
3752         * NEWS: Mention that GDB printf and eval commands can now print
3753         C-style and Ada-style convenience var strings without
3754         calling the inferior.
3755         * printcmd.c (printf_c_string): Locally print GDB internal var
3756         instead of transiting via the inferior.
3757         (printf_wide_c_string): Likewise.
3758
3759 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3760
3761         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
3762
3763 2019-07-04  Tom Tromey  <tom@tromey.com>
3764
3765         PR tui/24724:
3766         * tui/tui-winsource.c (tui_clear_source_content): Update.
3767         (tui_source_window_base::set_is_exec_point_at): Fix comment.
3768         (tui_update_breakpoint_info): Update.
3769         (tui_set_exec_info_content): Update.
3770         * tui/tui-source.c (tui_set_source_content_nil): Update.
3771         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
3772         has_break.
3773         * tui/tui-data.h (enum tui_bp_flag): New.
3774         (tui_bp_flags): New enum flags type.
3775         (struct tui_source_element) <break_mode>: Change type.  Rename
3776         from has_break.
3777         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
3778         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
3779         constants.
3780         * tui/tui-winsource.h: Fix comment.
3781
3782 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3783
3784         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
3785         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
3786         (store_fpregs_to_thread)
3787         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3788         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
3789         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
3790         (IWMMXT_REGS_SIZE): Add define.
3791         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
3792         (fetch_vfp_regs, store_vfp_regs)
3793         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3794         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
3795
3796 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3797
3798         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
3799         defines.
3800         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
3801         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
3802         (ARM_INT_REGISTER_SIZE): ...to this.
3803         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
3804         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
3805         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
3806         (arm_linux_collect_gregset, supply_nwfpe_register)
3807         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
3808         defines.
3809         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
3810         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
3811         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
3812         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
3813         (arm_return_in_memory, arm_store_return_value)
3814         (arm_get_longjmp_target, arm_register_g_packet_guesses)
3815         (arm_record_ld_st_multiple): Likewise.
3816         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
3817         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
3818
3819 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3820
3821         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
3822         AARCH64_DISPLACED_MODIFIED_INSNS.
3823         * aarch64-tdep.c (struct aarch64_displaced_step_data)
3824         (aarch64_displaced_step_copy_insn): Likewise.
3825         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3826         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
3827         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
3828         ARM_DISPLACED_MODIFIED_INSNS.
3829         * arm-tdep.c (arm_gdbarch_init): Likewise.
3830         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3831         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
3832         (struct arm_displaced_step_closure): Use
3833         ARM_DISPLACED_MODIFIED_INSNS.
3834
3835 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3836
3837         * features/Makefile: Remove unused xml files.
3838         * features/aarch64.xml: Remove.
3839         * features/i386/amd64-avx-avx512-linux.xml: Remove.
3840         * features/i386/amd64-avx-avx512.xml: Remove.
3841         * features/i386/amd64-avx-linux.xml: Remove.
3842         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
3843         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
3844         * features/i386/amd64-avx-mpx-linux.xml: Remove.
3845         * features/i386/amd64-avx-mpx.xml: Remove.
3846         * features/i386/amd64-avx.xml: Remove.
3847         * features/i386/amd64-linux.xml: Remove.
3848         * features/i386/amd64-mpx-linux.xml: Remove.
3849         * features/i386/amd64-mpx.xml: Remove.
3850         * features/i386/amd64.xml: Remove.
3851         * features/i386/i386-avx-avx512-linux.xml: Remove.
3852         * features/i386/i386-avx-avx512.xml: Remove.
3853         * features/i386/i386-avx-linux.xml: Remove.
3854         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
3855         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
3856         * features/i386/i386-avx-mpx-linux.xml: Remove.
3857         * features/i386/i386-avx-mpx.xml: Remove.
3858         * features/i386/i386-avx.xml: Remove.
3859         * features/i386/i386-linux.xml: Remove.
3860         * features/i386/i386-mmx-linux.xml: Remove.
3861         * features/i386/i386-mmx.xml: Remove.
3862         * features/i386/i386-mpx-linux.xml: Remove.
3863         * features/i386/i386-mpx.xml: Remove.
3864         * features/i386/i386.xml: Remove.
3865         * features/i386/x32-avx-avx512-linux.xml: Remove.
3866         * features/i386/x32-avx-linux.xml: Remove.
3867         * features/i386/x32-linux.xml: Remove.
3868
3869 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3870
3871         * regformats/aarch64.dat: Remove.
3872         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
3873         * regformats/i386/amd64-avx-linux.dat: Remove.
3874         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
3875         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
3876         * regformats/i386/amd64-linux.dat: Remove.
3877         * regformats/i386/amd64-mpx-linux.dat: Remove.
3878         * regformats/i386/amd64.dat: Remove.
3879         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
3880         * regformats/i386/i386-avx-linux.dat: Remove.
3881         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
3882         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
3883         * regformats/i386/i386-linux.dat: Remove.
3884         * regformats/i386/i386-mmx-linux.dat: Remove.
3885         * regformats/i386/i386-mpx-linux.dat: Remove.
3886         * regformats/i386/i386.dat: Remove.
3887         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
3888         * regformats/i386/x32-avx-linux.dat: Remove.
3889         * regformats/i386/x32-linux.dat: Remove.
3890
3891 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3892
3893         * aarch64-tdep.c: Remove xml self tests.
3894         * amd64-linux-tdep.c: Likewise.
3895         * amd64-tdep.c: Likewise.
3896         * i386-linux-tdep.c: Likewise.
3897         * i386-tdep.c: Likewise.
3898
3899 2019-07-03  Pedro Alves  <palves@redhat.com>
3900
3901         PR cli/24732
3902         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
3903         (pipe_cmd_option_defs): New.
3904         (make_pipe_cmd_options_def_group): New.
3905         (pipe_command): Use gdb::option::process_options.
3906         (pipe_command_completer): New function.
3907         (_initialize_cli_cmds): Install completer for "pipe" command.
3908
3909 2019-07-03  Pedro Alves  <palves@redhat.com>
3910
3911         * cli/cli-option.c (union option_value) <string>: New field.
3912         (struct option_def_and_value): Add ctor, move ctor, dtor and
3913         use DISABLE_COPY_AND_ASSIGN.
3914         (option_def_and_value::clear_value): New.
3915         (parse_option, save_option_value_in_ctx, get_val_type_str)
3916         (add_setshow_cmds_for_options): Handle var_string.
3917         * cli-option.h (union option_def::var_address) <string>: New
3918         field.
3919         (struct string_option_def): New.
3920         * maint-test-options.c (struct test_options_opts): Add default
3921         ctor and use DISABLE_COPY_AND_ASSIGN.
3922         <string_opt>: New field.
3923         (test_options_opts::~test_options_opts): New.
3924         (test_options_opts::dump): Also dump "-string".
3925         (test_options_option_defs): Install "string.
3926
3927 2019-07-03  Pedro Alves  <palves@redhat.com>
3928
3929         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
3930         option_value with a null enumeration.
3931         (complete_options): Save the option values in the context.
3932         (save_option_value_in_ctx): New, factored out from ...
3933         (process_options): ... here.
3934         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
3935         of the function.
3936         * maint-test-options.c (test_options_opts::dump): New, factored
3937         out from ...
3938         (maintenance_test_options_command_mode): ... here.
3939         (maintenance_test_options_command_completion_result): Delete.
3940         (maintenance_test_options_command_completion_text): Update
3941         comment.
3942         (maintenance_show_test_options_completion_result): Change
3943         prototype.  Just print
3944         maintenance_test_options_command_completion_text.
3945         (save_completion_result): New.
3946         (maintenance_test_options_completer_mode): Pass options context to
3947         complete_options, and then save a dump.
3948         (_initialize_maint_test_options): Use add_cmd to install "maint
3949         show test-options-completion-result".
3950
3951 2019-07-03  Pedro Alves  <palves@redhat.com>
3952
3953         * NEWS (New commands): Mention "with" and "maint with".
3954         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
3955         (with_command, with_command_completer): New.
3956         (pipe_command): Adjust to new repeat_previous
3957         interface.
3958         (_initialize_cli_cmds): Install the "with" command and its "w"
3959         alias.
3960         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
3961         declarations.
3962         * cli/cli-setshow.c (parse_cli_var_uinteger)
3963         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
3964         argument strings for all var_types.
3965         (get_setshow_command_value_string): New, factored out from ...
3966         (do_show_command): ... this.
3967         * cli/cli-setshow.h: Include <string>.
3968         (get_setshow_command_value_string): Declare.
3969         * command.h (repeat_previous): Now returns const char *.  Adjust
3970         comment.
3971         * maint.c: Include "cli/cli-cmds.h".
3972         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
3973         (_initialize_maint_cmds): Register the "maintenance with" command.
3974         * top.c (repeat_previous): Move bits from pipe_command here:
3975         Return the saved command line, if any; error out if there's no
3976         command to relaunch.
3977
3978 2019-07-03  Pedro Alves  <palves@redhat.com>
3979
3980         * NEWS (New commands): Mention "maint set/show test-settings"
3981         instead of "maint test-settings".
3982         * maint-test-settings.c (maintenance_test_settings_list): Delete.
3983         (maintenance_test_settings_set_list): Rename to ...
3984         (maintenance_set_test_settings_list): ... this.
3985         (maintenance_test_settings_show_list): Rename to  ...
3986         (maintenance_show_test_settings_list): ... this.
3987         (maintenance_test_settings_cmd): Delete.
3988         (maintenance_test_settings_set_cmd): ...
3989         (maintenance_set_test_settings_cmd): ... this.
3990         (maintenance_test_settings_show_cmd): ...
3991         (maintenance_show_test_settings_cmd): ... this.
3992         (maintenance_test_settings_show_value_cmd):
3993         (maintenance_show_test_settings_value_cmd): ... this.
3994         (_initialize_maint_test_settings): No longer install the "maint
3995         test-settings" prefix command.  Rename "maint test-settings set"
3996         to "maint set test-settings", and "maint test-settings show" to
3997         "maint show test-settings".  Adjust all subcommands.
3998
3999 2019-07-03  Pedro Alves  <palves@redhat.com>
4000
4001         * maint-test-settings.c: Fix file's intro comment.  Replace all
4002         references to "test-options" with references to "test-settings",
4003         in comments.
4004
4005 2019-07-03  Pedro Alves  <palves@redhat.com>
4006
4007         * maint-test-settings.c (maintenance_test_settings_xxx)
4008         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
4009         New.
4010         (maintenance_test_settings_enums): Use them.
4011         (maintenance_test_settings_enum): Default to
4012         maintenance_test_settings_xxx.
4013         (_initialize_maint_test_settings): Initialize
4014         MAINTENANCE_TEST_SETTINGS_FILENAME.
4015
4016 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4017
4018         * breakpoint.h (remove_breakpoints_inf): Change return type to
4019         void, move function documentation here.
4020         * breakpoint.c (remove_breakpoints_inf): Change return type to
4021         void, move function documentation to header.
4022
4023 2019-07-02  Pedro Alves  <palves@redhat.com>
4024
4025         * NEWS (Completion improvements): Mention "info threads".
4026         * thread.c (struct info_threads_opts, info_threads_option_defs)
4027         (make_info_threads_options_def_group): New.
4028         (info_threads_command): Use gdb::option::process_options.
4029         (info_threads_command_completer): New.
4030         (_initialize_thread): Use gdb::option::build_help to build the
4031         help text for "info threads".
4032
4033 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4034
4035         * defs.h (generic_load): Move from here...
4036         * symfile.h (generic_load): ... to here.  Rename name parameter
4037         to args.
4038         * symfile.c (generic_load): Add comment.
4039
4040 2019-07-01  Tom Tromey  <tromey@adacore.com>
4041
4042         * dwarf2read.c
4043         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
4044         declaration of without_params.  Fix formatting.
4045
4046 2019-07-01  Tom Tromey  <tromey@adacore.com>
4047
4048         * ada-exp.y (find_primitive_type): Update.
4049         * ada-lang.h (ada_lookup_symbol): Update.
4050         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
4051         parameter.
4052         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
4053
4054 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4055
4056         PR breakpoints/24541
4057         * gdbarch.c: Regenerate.
4058         * gdbarch.h: Regenerate.
4059         * gdbarch.sh: Add 'stap_adjust_register'.
4060         * i386-tdep.c: Include '<unordered_set>'.
4061         (i386_stap_adjust_register): New function.
4062         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
4063         * stap-probe.c (stap_parse_register_operand): Call
4064         'gdbarch_stap_adjust_register'.
4065
4066 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4067
4068         PR python/24742
4069         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
4070         * python/python.c (do_start_initialization): Use 'xmalloc'
4071         instead of 'PyMem_Malloc'.
4072
4073 2019-06-28  Tom Tromey  <tromey@adacore.com>
4074
4075         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
4076         for Ada.
4077
4078 2019-06-27  Tom Tromey  <tromey@adacore.com>
4079
4080         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
4081         objfile_key.
4082         (arm_find_mapping_symbol, arm_record_special_symbol)
4083         (_initialize_arm_tdep): Update.
4084         (arm_objfile_data_free): Remove.
4085
4086 2019-06-27  Tom Tromey  <tromey@adacore.com>
4087
4088         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
4089         to cp_print_static_field.
4090
4091 2019-06-26  Tom Tromey  <tromey@adacore.com>
4092
4093         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
4094         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
4095         declare.
4096
4097 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4098
4099         * features/aarch64-core.c (create_feature_aarch64_core):
4100         Regenerate.
4101         * features/aarch64-core.xml: Add cpsr flags.
4102
4103 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4104
4105         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
4106         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
4107
4108 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4109
4110         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
4111         field.
4112         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
4113         use.
4114         (arm_record_special_symbol): Don't insert new symbol in sorted
4115         position, push it at the end.
4116
4117 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4118
4119         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
4120         (arm_mapping_symbol_s): Remove.
4121         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
4122         (arm_mapping_symbol_vec): New typedef.
4123         (struct arm_per_objfile): Add constructor.
4124         <section_maps>: Change type to
4125         std::unique_ptr<arm_mapping_symbol_vec[]>.
4126         (arm_compare_mapping_symbols): Remove.
4127         (arm_find_mapping_symbol): Adjust to section_maps type change.
4128         (arm_objfile_data_free): Call delete on arm_per_objfile.
4129         (arm_record_special_symbol): Adjust to section_maps type change.
4130         Allocate arm_per_objfile with new.
4131
4132 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4133
4134         * cli/cli-cmds.c (alias_command): Compare the alias prefix
4135         with the command prefix.
4136
4137 2019-06-25  Tom Tromey  <tom@tromey.com>
4138
4139         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
4140         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
4141
4142 2019-06-25  Tom Tromey  <tom@tromey.com>
4143
4144         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
4145         type.
4146         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
4147         protected.
4148
4149 2019-06-25  Tom Tromey  <tom@tromey.com>
4150
4151         * tui/tui-winsource.c
4152         (tui_source_window_base::set_is_exec_point_at): Add check against
4153         LOA_ADDRESS.
4154
4155 2019-06-25  Tom Tromey  <tom@tromey.com>
4156
4157         * tui/tui-source.c (tui_set_source_content): Don't check before
4158         xfree.
4159         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
4160
4161 2019-06-25  Tom Tromey  <tom@tromey.com>
4162
4163         * tui/tui-winsource.h (tui_update_source_window_as_is)
4164         (tui_alloc_source_buffer, tui_line_is_displayed)
4165         (tui_addr_is_displayed): Change type of win_info.
4166         * tui/tui-winsource.c (tui_update_source_window_as_is)
4167         (tui_clear_source_content, tui_show_source_line)
4168         (tui_show_source_content, tui_source_window_base::refill)
4169         (tui_source_window_base::set_is_exec_point_at)
4170         (tui_source_window_base::set_is_exec_point_at)
4171         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
4172         (tui_alloc_source_buffer, tui_line_is_displayed)
4173         (tui_addr_is_displayed): Change type of win_info.  Update.
4174         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4175         (tui_source_window_base::do_make_visible_with_new_height):
4176         Update.
4177         * tui/tui-source.c (tui_set_source_content)
4178         (tui_set_source_content_nil)
4179         (tui_source_window::do_scroll_vertical): Update.
4180         * tui/tui-layout.c (show_layout): Update.
4181         * tui/tui-disasm.c (tui_set_disassem_content)
4182         (tui_disasm_window::do_scroll_vertical): Update.
4183         * tui/tui-data.h (tui_win_content): Remove.
4184         (struct tui_gen_win_info) <content, content_size>: Remove.
4185         (struct tui_source_element): Add initializers and destructor.
4186         (union tui_which_element, struct tui_win_element): Remove.
4187         (struct tui_source_window_base) <content>: New field.
4188         (struct tui_data_window): Remove destructor.
4189         (tui_alloc_content, tui_free_win_content)
4190         (tui_free_all_source_wins_content): Don't declare.
4191         * tui/tui-data.c (tui_initialize_static_data): Update.
4192         (init_content_element, tui_alloc_content): Remove.
4193         (~tui_gen_win_info): Update.
4194         (~tui_data_window, tui_free_all_source_wins_content)
4195         (tui_free_win_content, free_content, free_content_elements):
4196         Remove.
4197
4198 2019-06-25  Tom Tromey  <tom@tromey.com>
4199
4200         * tui/tui-winsource.h (tui_clear_source_content)
4201         (tui_erase_source_content, tui_show_source_content): Change type
4202         of win_info.
4203         * tui/tui-winsource.c (tui_clear_source_content)
4204         (tui_erase_source_content, tui_show_source_content): Change type
4205         of win_info.
4206         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4207         * tui/tui-source.h (tui_set_source_content_nil): Change type of
4208         win_info.
4209         * tui/tui-source.c (tui_set_source_content_nil): Change type of
4210         win_info.
4211         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
4212
4213 2019-06-25  Tom Tromey  <tom@tromey.com>
4214
4215         * tui/tui-winsource.c (tui_clear_source_content)
4216         (tui_source_window_base::set_is_exec_point_at): Update.
4217         * tui/tui-source.c (tui_set_source_content_nil): Update.
4218         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
4219         a bool.
4220         * tui/tui-data.c (init_content_element): Update.
4221
4222 2019-06-25  Tom Tromey  <tom@tromey.com>
4223
4224         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
4225         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
4226         * tui/tui-layout.c (init_and_make_win): Update.
4227         * tui/tui.h (enum tui_win_type): Update.
4228         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
4229         tui_win_is_auxillary.
4230         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
4231         tui_win_is_auxillary.
4232
4233 2019-06-25  Tom Tromey  <tom@tromey.com>
4234
4235         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
4236         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
4237         (tui_delete_data_content_windows, tui_display_all_data)
4238         (tui_data_window::do_scroll_vertical, tui_display_data_from):
4239         Update.
4240         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
4241         * tui/tui-regs.c (tui_last_regs_line_no)
4242         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4243         (tui_show_registers): Update.
4244         (tui_show_register_group): Return void.  Update.
4245         (tui_display_registers_from, tui_display_reg_element_at_line)
4246         (tui_display_registers_from_line, tui_check_register_values):
4247         Update.
4248         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
4249         member.
4250         (struct tui_data_window) <regs_content>: Now a std::vector.
4251         <regs_content_count>: Remove.
4252         (tui_add_content_elements, tui_free_data_content): Don't declare.
4253         * tui/tui-data.c (tui_data_window::clear_detail): Update.
4254         (init_content_element): Remove DATA_WIN case.  Add assert.
4255         (tui_add_content_elements): Remove.
4256         (tui_data_window): Update.
4257         (tui_free_data_content): Remove.
4258         (free_content_elements): Remove DATA_WIN case.
4259
4260 2019-06-25  Tom Tromey  <tom@tromey.com>
4261
4262         * tui/tui-data.c (tui_data_item_window): Update.
4263         * tui/tui-windata.h (tui_check_data_values): Don't declare.
4264         * tui/tui-windata.c (tui_display_all_data)
4265         (tui_display_data_from_line): Update.
4266         (tui_check_data_values): Remove.
4267         * tui/tui-regs.c (tui_show_register_group)
4268         (tui_display_reg_element_at_line): Update.
4269         * tui/tui-hooks.c (tui_register_changed)
4270         (tui_refresh_frame_and_register_information): Call
4271         tui_check_register_values.
4272         * tui/tui-data.h (struct tui_data_window) <data_content,
4273         data_content_count, data_type>: Remove.
4274         (enum tui_data_type): Remove.
4275
4276         * tui/tui-data.c (tui_data_window::clear_detail)
4277         (~tui_data_window): Update.
4278
4279 2019-06-25  Tom Tromey  <tom@tromey.com>
4280
4281         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
4282         declare.
4283         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
4284         Rename from tui_first_data_item_displayed.  Update.
4285         (tui_data_window::refresh_all)
4286         (tui_data_window::do_scroll_vertical): Update.
4287         * tui/tui-data.h (struct tui_data_window)
4288         <first_data_item_displayed>: Declare new method.
4289
4290 2019-06-25  Tom Tromey  <tom@tromey.com>
4291
4292         * tui/tui-data.h (tui_init_generic_part): Don't declare.
4293         * tui/tui-data.c (tui_init_generic_part): Remove, moving
4294         contents...
4295         (tui_initialize_static_data): ...here.
4296
4297 2019-06-25  Tom Tromey  <tom@tromey.com>
4298
4299         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4300         (tui_display_registers_from, tui_check_register_values): Update.
4301         (tui_display_register): Remove win_info parameter; update.
4302         (tui_get_register): Change type of parameters.
4303         * tui/tui-data.h (struct tui_data_element): Remove.
4304         (union tui_which_element) <data>: Remove.
4305         <data_window>: Change type.
4306         (struct tui_data_item_window): New.
4307         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
4308         case.  Add assert.
4309         (~tui_data_item_window): New destructor.
4310         (free_content_elements): Remove DATA_ITEM_WIN case.
4311
4312 2019-06-25  Tom Tromey  <tom@tromey.com>
4313
4314         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
4315         Remove.
4316
4317 2019-06-25  Tom Tromey  <tom@tromey.com>
4318
4319         * tui/tui-data.h (struct tui_command_element): Remove.
4320         (union tui_which_element) <command>: Remove.
4321         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
4322         assert.
4323         (free_content_elements): Remove CMD_WIN case.
4324
4325 2019-06-25  Tom Tromey  <tom@tromey.com>
4326
4327         * tui/tui-layout.c (tui_set_layout): Update.
4328         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
4329         * tui/tui-data.c (layout_def): Update.
4330
4331 2019-06-25  Tom Tromey  <tom@tromey.com>
4332
4333         * tui/tui-wingeneral.c (tui_refresh_all): Update.
4334         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4335         (tui_source_window_base::set_new_height): Update.
4336         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
4337         Update.
4338         (tui_set_locator_fullname, tui_set_locator_info)
4339         (tui_show_frame_info): Update.
4340         * tui/tui-source.c (tui_set_source_content)
4341         (tui_source_is_displayed): Update.
4342         * tui/tui-layout.c (show_source_disasm_command, show_data)
4343         (show_source_or_disasm_and_command): Update.
4344         * tui/tui-disasm.c (tui_set_disassem_content)
4345         (tui_get_begin_asm_address): Update.
4346         * tui/tui-data.h (struct tui_locator_element): Remove.
4347         (union tui_which_element) <locator>: Remove.
4348         (struct tui_locator_window): New.
4349         (tui_locator_win_info_ptr): Change return type.
4350         * tui/tui-data.c (_locator): Change type.
4351         (tui_locator_win_info_ptr): Change return type.
4352         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
4353         (tui_alloc_content): Add assert.
4354
4355 2019-06-25  Tom Tromey  <tom@tromey.com>
4356
4357         * tui/tui-winsource.c
4358         (tui_exec_info_window::maybe_allocate_content): New method.
4359         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
4360         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
4361         (make_source_or_disasm_window): Add cast.
4362         * tui/tui-data.h (union tui_which_element) <simple_string>:
4363         Remove.
4364         (struct tui_source_info): New.
4365         (struct tui_source_window_base) <execution_info>: Change type.
4366         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
4367         case, and add assert.
4368         (tui_alloc_content): Add assert.
4369
4370 2019-06-25  Tom Tromey  <tom@tromey.com>
4371
4372         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
4373         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
4374         * tui/tui-data.c (tui_alloc_win_info): Remove.
4375
4376 2019-06-25  Tom Tromey  <tom@tromey.com>
4377
4378         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
4379         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
4380         can_highlight.
4381
4382 2019-06-25  Tom Tromey  <tom@tromey.com>
4383
4384         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
4385         make_visible_with_new_height method.
4386         (tui_win_info::make_visible_with_new_height): New method.
4387         (tui_source_window_base::do_make_visible_with_new_height)
4388         (tui_data_window::do_make_visible_with_new_height)
4389         (tui_cmd_window::do_make_visible_with_new_height): New methods.
4390         (make_visible_with_new_height): Remove.
4391         (tui_resize_all, tui_adjust_win_heights): Use
4392         make_visible_with_new_height method.
4393         * tui/tui-data.h (struct tui_win_info)
4394         <do_make_visible_with_new_height, make_visible_with_new_height>:
4395         New methods.
4396         (struct tui_source_window_base, struct tui_data_window)
4397         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
4398         methods.
4399
4400 2019-06-25  Tom Tromey  <tom@tromey.com>
4401
4402         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
4403         method.
4404         (update_tab_width): Call update_tab_width method.
4405         * tui/tui-data.h (struct tui_win_info)
4406         (struct tui_source_window_base) <update_tab_width>: New methods.
4407
4408 2019-06-25  Tom Tromey  <tom@tromey.com>
4409
4410         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
4411         parameter.
4412         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
4413         parameter.
4414         (tui_gen_win_info::make_visible): Update.
4415         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
4416         parameter.
4417         * tui/tui-data.h (enum tui_box): New enum.
4418         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
4419
4420 2019-06-25  Tom Tromey  <tom@tromey.com>
4421
4422         * tui/tui-layout.c (make_source_or_disasm_window): Always use
4423         init_and_make_win for EXEC_INFO_WIN.
4424         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
4425         longer inline.
4426         (struct tui_win_info) <~tui_win_info>: Inline.
4427         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4428         Don't declare.
4429         * tui/tui-data.c (source_win, disasm_win): Remove globals.
4430         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4431         Remove.
4432         (tui_initialize_static_data): Update.
4433         (~tui_gen_win_info): Handle more cleanup here.
4434         (~tui_source_window_base): Delete "execution_info".
4435         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
4436
4437 2019-06-25  Tom Tromey  <tom@tromey.com>
4438
4439         * tui/tui-layout.c (make_command_window): Don't set
4440         can_highlight.
4441         (show_source_disasm_command): Call the reset method.
4442         (show_data): Don't set can_highlight.  Call the reset method.
4443         (tui_gen_win_info::reset): Rename from init_gen_win_info
4444         (init_and_make_win): Simplify.  Return tui_gen_win_info.
4445         (show_source_or_disasm_and_command): Call the reset method.
4446         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
4447         (struct tui_cmd_window): Set can_highlight.
4448
4449 2019-06-25  Tom Tromey  <tom@tromey.com>
4450
4451         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
4452         from make_visible.
4453         (tui_make_visible, tui_make_invisible): Rewrite.
4454         (tui_win_info::make_visible): Remove.
4455         (tui_source_window_base::make_visible): Update.
4456         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
4457         method.  Moved from...
4458         (struct tui_win_info) <make_visible>: ...here.
4459
4460 2019-06-25  Tom Tromey  <tom@tromey.com>
4461
4462         * tui/tui-winsource.c
4463         (tui_source_window_base::do_scroll_horizontal): Remove direction
4464         parameter.
4465         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
4466         direction parameter.
4467         * tui/tui-win.c (tui_win_info::forward_scroll)
4468         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4469         (tui_win_info::right_scroll): Update.
4470         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
4471         direction parameter.
4472         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
4473         direction parameter.
4474         * tui/tui-data.h (enum tui_scroll_direction): Remove.
4475         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
4476         Remove direction parameter.
4477         (struct tui_source_window_base, struct tui_source_window)
4478         (struct tui_disasm_window, struct tui_data_window)
4479         (struct tui_cmd_window): Update.
4480
4481 2019-06-25  Tom Tromey  <tom@tromey.com>
4482
4483         * tui/tui-winsource.h (tui_set_exec_info_content)
4484         (tui_show_exec_info_content, tui_erase_exec_info_content)
4485         (tui_clear_exec_info_content, tui_update_exec_info): Change
4486         argument to tui_source_window_base.
4487         * tui/tui-winsource.c (tui_set_exec_info_content)
4488         (tui_show_exec_info_content, tui_erase_exec_info_content)
4489         (tui_clear_exec_info_content, tui_update_exec_info): Change
4490         argument to tui_source_window_base.
4491
4492 2019-06-25  Tom Tromey  <tom@tromey.com>
4493
4494         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
4495         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
4496
4497 2019-06-25  Tom Tromey  <tom@tromey.com>
4498
4499         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
4500         check.
4501
4502 2019-06-25  Tom Tromey  <tom@tromey.com>
4503
4504         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
4505         type to void.
4506         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
4507         type to void.
4508         * tui/tui-source.c (tui_set_source_content): Update.
4509         * tui/tui-disasm.c (tui_set_disassem_content): Update.
4510
4511 2019-06-25  Tom Tromey  <tom@tromey.com>
4512
4513         * tui/tui-win.c (window_name_completer, tui_set_focus)
4514         (tui_all_windows_info): Use name method.
4515         * tui/tui-data.h (struct tui_gen_win_info)
4516         (struct tui_source_window, struct tui_disasm_window)
4517         (struct tui_data_window, struct tui_cmd_window) <name>: New
4518         method.
4519         (tui_win_name): Don't declare.
4520         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
4521         (tui_win_name): Remove.
4522
4523 2019-06-25  Tom Tromey  <tom@tromey.com>
4524
4525         * tui/tui-winsource.h (tui_update_source_window)
4526         (tui_update_source_window_as_is): Change parameter type.
4527         * tui/tui-winsource.c (tui_update_source_window): Change win_info
4528         to be a tui_source_window_base.
4529         (tui_update_source_window_as_is): Likewise.
4530         * tui/tui-win.c (make_visible_with_new_height): Update.
4531
4532 2019-06-25  Tom Tromey  <tom@tromey.com>
4533
4534         * tui/tui-winsource.c (tui_erase_source_content)
4535         (tui_show_source_content, tui_show_exec_info_content)
4536         (tui_erase_exec_info_content): Use refresh_window method.
4537         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
4538         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
4539         from tui_refresh_win.
4540         (tui_data_window::refresh_window): New method.
4541         (tui_win_info::refresh, tui_source_window_base::refresh)
4542         (tui_refresh_all): Use refresh_window method.
4543         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
4544         method.
4545         * tui/tui-regs.c (tui_display_register): Call refresh_window
4546         method.
4547         * tui/tui-layout.c (show_source_disasm_command)
4548         (show_source_or_disasm_and_command): Call refresh_window method.
4549         * tui/tui-data.h (struct tui_gen_win_info)
4550         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
4551         New method.
4552
4553 2019-06-25  Tom Tromey  <tom@tromey.com>
4554
4555         * tui/tui.c (tui_rl_other_window, tui_enable)
4556         (tui_is_window_visible, tui_get_command_dimension): Update.
4557         * tui/tui-winsource.c (tui_update_source_window_as_is)
4558         (tui_clear_source_content, tui_erase_source_content)
4559         (tui_show_source_line, tui_source_window_base::refill)
4560         (tui_source_window_base::do_scroll_horizontal)
4561         (tui_source_window_base::set_is_exec_point_at)
4562         (tui_update_breakpoint_info, tui_set_exec_info_content)
4563         (tui_alloc_source_buffer, tui_line_is_displayed)
4564         (tui_addr_is_displayed): Update.
4565         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4566         (tui_check_and_display_highlight_if_needed)
4567         (tui_win_info::make_visible, tui_win_info::refresh)
4568         (tui_refresh_all): Update.
4569         * tui/tui-windata.c (tui_first_data_item_displayed)
4570         (tui_delete_data_content_windows, tui_erase_data_content)
4571         (tui_display_all_data, tui_data_window::refresh_all)
4572         (tui_check_data_values): Update.
4573         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
4574         (tui_set_win_focus_to, tui_win_info::forward_scroll)
4575         (tui_win_info::backward_scroll, tui_refresh_all_win)
4576         (tui_resize_all, tui_set_focus, tui_all_windows_info)
4577         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
4578         (tui_source_window_base::set_new_height)
4579         (tui_data_window::set_new_height)
4580         (make_invisible_and_set_new_height)
4581         (make_visible_with_new_height, new_height_ok)
4582         (parse_scrolling_args): Update.
4583         * tui/tui-stack.c (tui_show_frame_info): Update.
4584         * tui/tui-source.c (tui_set_source_content)
4585         (tui_set_source_content_nil, tui_source_is_displayed)
4586         (tui_source_window::do_scroll_vertical): Update.
4587         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4588         (tui_display_registers_from, tui_display_reg_element_at_line)
4589         (tui_check_register_values, tui_reg_command): Update.
4590         * tui/tui-layout.c (tui_default_win_height)
4591         (show_source_disasm_command, show_data, init_and_make_win)
4592         (show_source_or_disasm_and_command): Update.
4593         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
4594         (tui_redisplay_readline, tui_mld_flush)
4595         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
4596         (tui_getc): Update.
4597         * tui/tui-disasm.c (tui_set_disassem_content)
4598         (tui_disasm_window::do_scroll_vertical): Update.
4599         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
4600         Now virtual.
4601         (struct tui_win_info): Derive from tui_gen_win_info.
4602         <~tui_win_info>: Mark as override.
4603         <generic>: Remove member.
4604         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
4605         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
4606         (~tui_data_window, ~tui_win_info)
4607         (tui_free_all_source_wins_content): Update.
4608         * tui/tui-command.c (tui_refresh_cmd_win): Update.
4609
4610 2019-06-25  Tom Tromey  <tom@tromey.com>
4611
4612         * tui/tui-layout.c (init_and_make_win): Use new.
4613         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
4614         destructor, initializers.
4615         (tui_alloc_generic_win_info): Don't declare.
4616         * tui/tui-data.c (_locator): Add argument to constructor.
4617         (source_win, disasm_win): New globals.
4618         (exec_info): Remove.
4619         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4620         Update.
4621         (tui_alloc_generic_win_info): Remove.
4622         (init_content_element): Use new.
4623         (tui_win_info::tui_win_info): Update.
4624         (free_content_elements) <case DATA_WIN>: Use delete.
4625
4626 2019-06-25  Tom Tromey  <tom@tromey.com>
4627
4628         * tui/tui-wingeneral.c (tui_refresh_win): Update.
4629         * tui/tui-windata.c (tui_first_data_item_displayed)
4630         (tui_delete_data_content_windows): Update.
4631         * tui/tui-win.c (tui_data_window::set_new_height): Update.
4632         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4633         (tui_display_registers_from, tui_check_register_values): Update.
4634         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
4635         pointer.
4636         * tui/tui-data.c (init_content_element): Update.  Allocate the new
4637         window.
4638         (tui_free_data_content): Update.
4639         (free_content_elements) <case DATA_WIN>: Free the window.
4640
4641 2019-06-25  Tom Tromey  <tom@tromey.com>
4642
4643         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
4644         Update.
4645         * tui/tui-layout.c (make_command_window)
4646         (show_source_disasm_command, show_data, init_and_make_win)
4647         (show_source_or_disasm_and_command): Update.
4648         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
4649         method.
4650         <can_highight, is_highlighted>: Now bool.
4651         (tui_set_win_highlight): Don't declare.
4652         * tui/tui-data.c (tui_set_win_highlight): Remove.
4653
4654 2019-06-25  Tom Tromey  <tom@tromey.com>
4655
4656         * tui/tui-wingeneral.c (make_visible): Remove check of window
4657         type.
4658
4659 2019-06-25  Tom Tromey  <tom@tromey.com>
4660
4661         * tui/tui-win.c (tui_win_info::max_height)
4662         (tui_cmd_window::max_height): New methods.
4663         (new_height_ok): Call max_height.
4664         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
4665         <max_height>: New method.
4666
4667 2019-06-25  Tom Tromey  <tom@tromey.com>
4668
4669         * tui/tui-win.c (tui_source_window_base::set_new_height)
4670         (tui_data_window::set_new_height): New methods.
4671         (make_invisible_and_set_new_height): Call set_new_height method.
4672         * tui/tui-data.h (struct tui_win_info)
4673         (struct tui_source_window_base, struct tui_data_window)
4674         <set_new_height>: New method.
4675
4676 2019-06-25  Tom Tromey  <tom@tromey.com>
4677
4678         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
4679         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
4680         tui_refresh_data_win.
4681         * tui/tui-win.c (tui_source_window_base::refresh_all): New
4682         method.
4683         (tui_refresh_all_win): Call the refresh_all method.
4684         (tui_set_focus): Likewise.
4685         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
4686         (struct tui_source_window_base, struct tui_data_window) <refresh>:
4687         Likewise.
4688
4689 2019-06-25  Tom Tromey  <tom@tromey.com>
4690
4691         * tui/tui-winsource.h (tui_refill_source_window)
4692         (tui_set_is_exec_point_at): Don't declare.
4693         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4694         (tui_source_window_base::refill): Rename from
4695         tui_refill_source_window.
4696         (tui_source_window_base::do_scroll_horizontal): Update.
4697         (tui_source_window_base::set_is_exec_point_at): Rename from
4698         tui_set_is_exec_point_at.
4699         (tui_update_all_breakpoint_info): Update.
4700         * tui/tui-stack.c (tui_show_frame_info): Update.
4701         * tui/tui-layout.c (show_data): Add cast.
4702         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
4703         * tui/tui-data.h (struct tui_source_window_base) <refill,
4704         set_is_exec_point_at>: New methods.
4705         (tui_source_windows, tui_add_to_source_windows): Update types.
4706         (tui_add_to_source_windows): Remove redundant declaration.
4707         * tui/tui-data.c (source_windows): Store tui_source_window_base.
4708         (tui_source_windows): Change return type.
4709         (tui_clear_source_windows_detail): Update.
4710         (tui_add_to_source_windows): Change type of parameter.
4711         (tui_free_all_source_wins_content): Update.
4712
4713 2019-06-25  Tom Tromey  <tom@tromey.com>
4714
4715         * tui/tui-wingeneral.c (tui_win_info::refresh)
4716         (tui_source_window_base::refresh): New methods.
4717         (tui_refresh_all): Call the refresh method.
4718         * tui/tui-data.h (struct tui_win_info)
4719         (struct tui_source_window_base) <refresh>: New method.
4720
4721 2019-06-25  Tom Tromey  <tom@tromey.com>
4722
4723         * tui/tui.h (tui_is_window_visible): Return bool.
4724         * tui/tui.c (tui_is_window_visible): Return bool.
4725         * tui/tui-wingeneral.c (tui_make_window, make_visible)
4726         (tui_make_visible, tui_make_invisible)
4727         (tui_win_info::make_visible)
4728         (tui_source_window_base::make_visible, make_all_visible)
4729         (tui_make_all_visible, tui_make_all_invisible): Update.
4730         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
4731         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
4732         bool.
4733         (struct tui_win_info, struct tui_source_window_base)
4734         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
4735         * tui/tui-data.c (tui_init_generic_part): Update.
4736
4737 2019-06-25  Tom Tromey  <tom@tromey.com>
4738
4739         * tui/tui-wingeneral.c (tui_win_info::make_visible)
4740         (tui_source_window_base::make_visible): New methods.
4741         (make_all_visible): Make method call.
4742         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
4743         (struct tui_source_window_base, struct tui_cmd_window): Override
4744         make_visible.
4745         (tui_win_is_source_type): Don't declare.
4746         * tui/tui-data.c (tui_win_is_source_type): Remove.
4747
4748 2019-06-25  Tom Tromey  <tom@tromey.com>
4749
4750         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
4751         NULL check.
4752
4753 2019-06-25  Tom Tromey  <tom@tromey.com>
4754
4755         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
4756         Inline constructor.  Add initializers for members.
4757         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
4758         constructors; now inline in class.
4759
4760 2019-06-25  Tom Tromey  <tom@tromey.com>
4761
4762         * tui/tui-regs.c (tui_show_registers): Update.
4763         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
4764         bool.
4765         * tui/tui-data.c (tui_data_window::clear_detail)
4766         (tui_data_window): Update.
4767
4768 2019-06-25  Tom Tromey  <tom@tromey.com>
4769
4770         * tui/tui-windata.c (tui_display_all_data)
4771         (tui_display_data_from_line, tui_display_data_from)
4772         (tui_check_data_values, tui_data_window::do_scroll_vertical):
4773         Update.
4774         * tui/tui-regs.c (tui_last_regs_line_no)
4775         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4776         (tui_show_registers, tui_show_register_group)
4777         (tui_display_registers_from, tui_display_reg_element_at_line)
4778         (tui_display_registers_from_line, tui_check_register_values)
4779         (tui_reg_next, tui_reg_prev): Update.
4780         * tui/tui-layout.c (tui_set_layout, show_data): Update.
4781         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
4782         tui_data_window.
4783         (struct tui_win_info) <detail>: Remove.  Add new fields from
4784         tui_data_info.
4785         (TUI_DATA_WIN): Add cast.
4786         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
4787         (~tui_data_window): Simplify.
4788
4789 2019-06-25  Tom Tromey  <tom@tromey.com>
4790
4791         * tui/tui-layout.c (show_source_disasm_command)
4792         (show_source_or_disasm_and_command): Update.
4793         * tui/tui-io.c (update_cmdwin_start_line)
4794         (tui_redisplay_readline): Update.
4795         * tui/tui-data.h (struct tui_command_info): Remove.
4796         (struct tui_win_info) <detail>: Remove command_info member.
4797         (struct tui_data_window) <start_line>: New member, from
4798         tui_command_info.
4799         (TUI_CMD_WIN): Add casts.
4800
4801 2019-06-25  Tom Tromey  <tom@tromey.com>
4802
4803         * tui/tui-winsource.c (tui_update_source_window)
4804         (tui_refill_source_window)
4805         (tui_source_window_base::do_scroll_horizontal)
4806         (tui_update_breakpoint_info, tui_set_exec_info_content)
4807         (tui_show_exec_info_content, tui_erase_exec_info_content)
4808         (tui_clear_exec_info_content): Update.
4809         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
4810         Update.
4811         * tui/tui-win.c (make_invisible_and_set_new_height)
4812         (make_visible_with_new_height): Update.
4813         * tui/tui-source.c (tui_set_source_content)
4814         (tui_show_symtab_source): Update.
4815         * tui/tui-layout.c (extract_display_start_addr)
4816         (show_source_disasm_command, show_data)
4817         (make_source_or_disasm_window)
4818         (show_source_or_disasm_and_command): Update.
4819         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
4820         (tui_disasm_window::do_scroll_vertical): Remove shadowing
4821         "gdbarch".
4822         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
4823         to tui_source_window_base.
4824         (struct tui_win_info) <detail>: Remove source_info member.
4825         (struct tui_source_window_base) <has_locator>: Inline.
4826         Move contents from tui_source_info; rename has_locator member to
4827         m_has_locator.
4828         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
4829         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
4830         header file.
4831         (tui_source_window_base::clear_detail, ~tui_source_window_base):
4832         Simplify.
4833         (tui_free_all_source_wins_content): Cast to
4834         tui_source_window_base.
4835
4836 2019-06-25  Tom Tromey  <tom@tromey.com>
4837
4838         * tui/tui-win.c (make_invisible_and_set_new_height)
4839         (make_visible_with_new_height): Call has_locator method.
4840         * tui/tui-layout.c (show_source_disasm_command, show_data)
4841         (show_source_or_disasm_and_command): Update for bool change.
4842         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
4843         (tui_win_info) <has_locator>: New method.
4844         (struct tui_source_window_base) <has_locator>: New method.
4845         (tui_win_has_locator): Don't declare.
4846         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
4847         from tui_win_has_locator.
4848         (tui_source_window_base): Use false, not FALSE.
4849
4850 2019-06-25  Tom Tromey  <tom@tromey.com>
4851
4852         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
4853         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
4854         clear_detail method directly.
4855         (tui_clear_win_detail): Remove.
4856
4857 2019-06-25  Tom Tromey  <tom@tromey.com>
4858
4859         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
4860         "this", not TUI_DISASM_WIN.
4861
4862 2019-06-25  Tom Tromey  <tom@tromey.com>
4863
4864         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
4865         declare.
4866         * tui/tui-winsource.c
4867         (tui_source_window_base::do_scroll_horizontal): Rename from
4868         tui_horizontal_source_scroll.
4869         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
4870         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
4871         from tui_vertical_data_scroll.
4872         * tui/tui-win.h (tui_scroll): Don't declare.
4873         * tui/tui-win.c (tui_win_info::forward_scroll)
4874         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4875         (tui_win_info::right_scroll): Rename and update.
4876         (tui_scroll_forward_command, tui_scroll_backward_command)
4877         (tui_scroll_left_command, tui_scroll_right_command): Update.
4878         (tui_scroll): Remove.
4879         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
4880         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
4881         from tui_vertical_source_scroll.
4882         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
4883         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
4884         from tui_vertical_disassem_scroll.
4885         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
4886         do_scroll_horizontal>: New methods.
4887         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
4888         Likewise.
4889         (struct tui_source_window_base): Add do_scroll_horizontal.
4890         (struct tui_source_window, struct tui_disasm_window): Add
4891         do_scroll_vertical.
4892         (struct tui_data_window, struct tui_cmd_window): Add
4893         do_scroll_horizontal and do_scroll_vertical.
4894         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
4895
4896 2019-06-25  Tom Tromey  <tom@tromey.com>
4897
4898         * tui/tui-data.h (struct tui_source_window_base): New struct.
4899         (struct tui_source_window): Derive from tui_source_window_base.
4900         (struct tui_disasm_window): New struct.
4901         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
4902         from tui_source_window::clear_detail.
4903         (tui_source_window_base): Rename from tui_source_window.
4904         (~tui_source_window_base): Rename from ~tui_source_window.
4905         (tui_alloc_win_info): Create a tui_disasm_window.
4906
4907 2019-06-25  Tom Tromey  <tom@tromey.com>
4908
4909         * tui/tui-data.h (struct tui_source_window)
4910         (struct tui_data_window): Declare destructors.
4911         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
4912         destructors.
4913         (tui_win_info): Simplify.
4914
4915 2019-06-25  Tom Tromey  <tom@tromey.com>
4916
4917         * tui/tui-winsource.c (tui_display_main)
4918         (tui_update_source_windows_with_addr)
4919         (tui_update_all_breakpoint_info): Update.
4920         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4921         (new_height_ok, parse_scrolling_args): Update.
4922         * tui/tui-stack.c (tui_show_frame_info): Update.
4923         * tui/tui-data.h (struct tui_list): Remove.
4924         (tui_source_windows): Return a reference to a std::vector.
4925         * tui/tui-data.c (source_windows): Now a std::vector.
4926         (tui_source_windows): Change return type.
4927         (tui_clear_source_windows): Rewrite.
4928         (tui_clear_source_windows_detail, tui_add_to_source_windows)
4929         (tui_free_all_source_wins_content): Rewrite.
4930
4931 2019-06-25  Tom Tromey  <tom@tromey.com>
4932
4933         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
4934         (struct tui_data_window, struct tui_cmd_window): Declare
4935         clear_detail method.
4936         * tui/tui-data.c (tui_source_window::clear_detail)
4937         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
4938         methods.
4939         (tui_clear_win_detail): Simplify.
4940
4941 2019-06-25  Tom Tromey  <tom@tromey.com>
4942
4943         * tui/tui-layout.c (make_source_window, make_disasm_window)
4944         (make_source_or_disasm_window): Remove win_info_ptr parameter.
4945         Return the new window.
4946         (show_source_disasm_command, show_data)
4947         (show_source_or_disasm_and_command): Update.
4948
4949 2019-06-25  Tom Tromey  <tom@tromey.com>
4950
4951         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
4952         parameter.  Return the new window.
4953         (show_source_disasm_command): Update and remove NULL check.
4954         (show_source_or_disasm_and_command): Update.
4955
4956 2019-06-25  Tom Tromey  <tom@tromey.com>
4957
4958         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
4959
4960 2019-06-25  Tom Tromey  <tom@tromey.com>
4961
4962         * tui/tui-data.h (struct tui_win_info): Make constructor
4963         protected.  Make destructor virtual.  Add initializers.
4964         (tui_source_window, tui_data_window, tui_cmd_window): New
4965         classes.
4966         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
4967         constructor.  Add "type" parameter.
4968         (tui_source_window, tui_data_window, tui_cmd_window): New
4969         constructors.
4970         (tui_alloc_win_info): Instantiate the appropriate subclass.
4971
4972 2019-06-25  Tom Tromey  <tom@tromey.com>
4973
4974         * tui/tui-win.c (tui_resize_all): Use delete.
4975         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
4976         destructor.
4977         (tui_free_window): Don't declare.
4978         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
4979         Update.
4980
4981 2019-06-25  Tom Tromey  <tom@tromey.com>
4982
4983         * tui/tui-data.h (struct tui_win_info): Add constructor.
4984         * tui/tui-data.c (tui_alloc_win_info): Use new.
4985         (tui_free_window): Use delete.
4986
4987 2019-06-22  Tom Tromey  <tom@tromey.com>
4988
4989         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
4990         declare.
4991         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
4992
4993 2019-06-22  Tom Tromey  <tom@tromey.com>
4994
4995         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
4996         declare.
4997         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
4998
4999 2019-06-22  Tom de Vries  <tdevries@suse.de>
5000
5001         * dwarf2read.c (create_addrmap_from_aranges)
5002         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
5003         instead of '%zu'.
5004
5005 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
5006
5007         * dwarf2read.h (dwarf2_section_info_def): Remove.
5008         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
5009         * dwarf2read.c (struct dwo_sections) <types>: Change type to
5010         std::vector<dwarf2_section_info>.
5011         (struct dwo_file) <~dwo_file>: Remove.
5012         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
5013         types field.
5014         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
5015         (dwarf2_read_debug_names): Likewise.
5016         (create_debug_types_hash_table): Change parameter type to
5017         array_view, adjust code accordingly.
5018         (dwarf2_locate_dwo_sections): Adjust to std::vector.
5019         (partial_die_info::fixup): Likewise.
5020         (determine_prefix): Likewise.
5021         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
5022
5023 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5024
5025         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
5026         gdb_bfd_ref_ptr.
5027         <~dwo_file>: Remove call to gdb_bfd_unref.
5028         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
5029         gdb_bfd_ref_ptr::get.
5030
5031 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5032
5033         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
5034         type to htab_up.
5035         * dwarf2read.c (struct dwo_file): Initialize fields.
5036         <~dwo_file>: New.
5037         (free_dwo_file): Remove, move content to ~dwo_file.
5038         (struct dwo_file_deleter): Remove.
5039         (dwo_file_up>: Remove custom deleter.
5040         (free_dwo_files): Remove.
5041         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
5042         dwo_files.
5043         (process_skeletonless_type_units): Call unique_ptr::get.
5044         (allocate_dwo_file_hash_table): Add deleter to created hash
5045         table.  Change return type to htab_up.
5046         (lookup_dwo_file_slot): Don't memset dwo_file, call
5047         unique_ptr::get.
5048         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
5049         (create_dwo_unit_in_dwp_v2): Likewise.
5050         (open_and_init_dwo_file): Likewise.
5051         (free_dwo_file_from_slot): Remove.
5052
5053 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5054
5055         * dwarf2read.h (struct dwarf2_section_info) <readin,
5056         is_virtual>: Change type to bool.
5057         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
5058         true instead of 1.
5059
5060 2019-06-19  Tom Tromey  <tom@tromey.com>
5061
5062         * tui/tui-data.h (tui_init_content_element): Don't declare.
5063
5064 2019-06-19  Tom Tromey  <tom@tromey.com>
5065
5066         * tui/tui-data.h (tui_init_win_info): Don't declare.
5067
5068 2019-06-19  Tom de Vries  <tdevries@suse.de>
5069
5070         * dwarf2read.h (abstract_to_concrete): Change type to
5071         std::unordered_map<sect_offset, std::vector<sect_offset>,
5072         gdb::hash_enum<sect_offset>>.
5073
5074 2019-06-19  Tom Tromey  <tromey@adacore.com>
5075
5076         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
5077         EVAL_AVOID_SIDE_EFFECTS specially.
5078
5079 2019-06-19  Tom Tromey  <tromey@adacore.com>
5080
5081         * source-cache.c (highlighter): New global.
5082         (source_cache::get_source_lines): Create a highlighter on demand.
5083
5084 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5085
5086         * defs.h (deprecated_interactive_hook): Delete declaration.
5087         * interps.c (clear_interpreter_hooks): Remove use of
5088         deprecated_interactive_hook.
5089         * top.c (deprecated_interactive_hook): Delete definition.
5090         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
5091
5092 2019-06-18  Tom de Vries  <tdevries@suse.de>
5093
5094         PR gdb/24515
5095         * dwarf2read.h (abstract_to_concrete): Change type from
5096         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
5097         std::unordered_map<sect_offset, std::vector<sect_offset>>.
5098         * dwarf2read.c (read_variable): Update.
5099         (dwarf2_fetch_die_loc_sect_off): Update.
5100
5101 2019-06-17  Tom de Vries  <tdevries@suse.de>
5102
5103         PR gdb/24617
5104         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
5105         accessing parent[parent_len - 1].
5106
5107 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
5108
5109         PR gdb/24364
5110         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
5111         call dtrace_process_dof with NULL dof.
5112
5113 2019-06-16  Tom de Vries  <tdevries@suse.de>
5114
5115         PR gdb/24445
5116         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
5117
5118 2019-06-16  Tom Tromey  <tom@tromey.com>
5119
5120         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5121         (make_all_visible): Use address of member.
5122
5123 2019-06-16  Tom Tromey  <tom@tromey.com>
5124
5125         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
5126         (tui_free_window, free_content, free_content_elements): Remove
5127         unnecessary cast.
5128         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
5129         cast.
5130         * tui/tui-regs.c (tui_show_register_group)
5131         (tui_display_registers_from, tui_display_reg_element_at_line):
5132         Remove unnecessary cast.
5133
5134 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
5135
5136         * linux-nat.c (normal_mask): Delete.
5137         (_initialize_linux_nat): Don't initialise normal_mask.
5138
5139 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
5140
5141         PR gdb/24445
5142         * dwarf-index-write.h (write_psymtabs_to_index): Add
5143         dwz_basename parameter.
5144         * dwarf-index-write.c (write_gdbindex): Move file writing to
5145         write_gdbindex_1.  Change return type void.
5146         (assert_file_size): Move up, remove filename parameter.
5147         (write_gdbindex_1): New function.
5148         (write_debug_names): Change return type to void, call
5149         assert_file_size.
5150         (struct index_wip_file): New struct.
5151         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
5152         file logic to index_wip_file.  Write index for dwz file if
5153         needed.
5154         (save_gdb_index_command): Pass basename of dwz file, if present.
5155         * dwarf-index-cache.c (index_cache::store): Obtain and pass
5156         build-id of dwz file, if present.
5157         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
5158         (dwarf2_get_dwz_file): Likewise.
5159         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
5160         (dwarf2_get_dwz_file): Likewise.
5161
5162 2019-06-16  Tom Tromey  <tom@tromey.com>
5163
5164         * coffread.c (process_coff_symbol): Use xstrdup.
5165         * value.c (create_internalvar): Use xstrdup.
5166
5167 2019-06-16  Tom Tromey  <tom@tromey.com>
5168
5169         * valops.c (value_cast, value_slice): Remove unnecessary cast.
5170         * breakpoint.c (stopin_command, stopat_command)
5171         (until_break_command, decode_location_default): Remove unnecessary
5172         cast.
5173         * utils.c (subset_compare): Remove unnecessary cast.
5174         * ada-lang.c (ada_update_initial_language): Remove unnecessary
5175         cast.
5176         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
5177         cast.
5178         * infcmd.c (path_command): Remove unnecessary cast.
5179         * coffread.c (decode_type): Remove unnecessary cast.
5180         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
5181         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
5182         * tui/tui-stack.c (tui_show_locator_content)
5183         (tui_show_frame_info): Remove unnecessary cast.
5184         * tui/tui-win.c (tui_scroll_forward_command)
5185         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
5186         (parse_scrolling_args): Remove unnecessary cast.
5187         * tui/tui-data.c (init_win_info, tui_del_window)
5188         (tui_free_window, tui_del_data_windows, tui_free_data_content)
5189         (free_content_elements): Remove unnecessary cast.
5190         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
5191         unnecessary cast.
5192         * tui/tui-source.c (tui_set_source_content)
5193         (tui_vertical_source_scroll): Remove unnecessary cast.
5194         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
5195         cast.
5196         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
5197         * tui/tui-regs.c (tui_display_registers_from)
5198         (tui_display_register): Remove unnecessary cast.
5199         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
5200         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
5201         (make_visible): Remove unnecessary cast.
5202         * tui/tui-winsource.c (tui_erase_source_content)
5203         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
5204         unnecessary cast.
5205         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
5206         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
5207         * stabsread.c (read_type, read_array_type, read_range_type):
5208         Remove unnecessary cast.
5209         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
5210         (parse_symbol, parse_type, upgrade_type, parse_external)
5211         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
5212         unnecessary cast.
5213         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
5214
5215 2019-06-16  Tom Tromey  <tom@tromey.com>
5216
5217         * tui/tui-data.c (tui_alloc_generic_win_info)
5218         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
5219         checks.
5220
5221 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
5222             Andrew Burgess  <andrew.burgess@embecosm.com>
5223
5224         * f-typeprint.c (f_print_type): Don't return early for not
5225         associated or not allocated types.
5226         (f_type_print_varspec_suffix): Add print_rank parameter and print
5227         ranks of array types in case they dangling.
5228         (f_type_print_base): Add print_rank parameter.
5229
5230 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5231
5232         * NEWS: Mention new MI commands.
5233         * break-catch-throw.c (enum exception_event_kind): Move to
5234         breakpoint.h.
5235         (print_mention_exception_catchpoint): Output text as a single
5236         message.
5237         (catch_exception_command_1): Rename to...
5238         (catch_exception_event): ...this, make non-static, update header
5239         command, and change some parameter types.
5240         (catch_catch_command): Update for changes to
5241         catch_exception_command_1.
5242         (catch_throw_command): Likewise.
5243         (catch_rethrow_command): Likewise.
5244         * breakpoint.c (enum exception_event_kind): Delete.
5245         * breakpoint.h (enum exception_event_kind): Moved here from
5246         break-catch-throw.c.
5247         (catch_exception_event): Declare.
5248         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
5249         (mi_cmd_catch_throw): New function.
5250         (mi_cmd_catch_rethrow): New function.
5251         (mi_cmd_catch_catch): New function.
5252         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
5253         'catch-catch' entries.
5254         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
5255         (mi_cmd_catch_rethrow): Declare.
5256         (mi_cmd_catch_catch): Declare.
5257
5258 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5259
5260         * annotate.c (annotate_source_line): Change return type to void,
5261         update implementation to match.
5262         * annotate.h (annotate_source_line): Change return type to void,
5263         update header comment.
5264         * stack.c (print_frame_info): Don't change what frame information
5265         is printed based on whether annotations are on or not.
5266
5267 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5268
5269         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
5270         (annotate_source): Make static.
5271         (annotate_source_line): Moved from source.c and renamed from
5272         identify_source_line.  Update the return type.
5273         * annotate.h (annotate_source): Delete declaration.
5274         (annotate_source_line): Declaration moved from source.h, and
5275         renamed from identify_source_line.  Return type updated.
5276         * source.c (identify_source_line): Moved to annotate.c and renamed
5277         to annotate_source_line.
5278         (info_line_command): Remove check of annotation_level.
5279         * source.h (identify_source_line): Move declaration to annotate.h
5280         and rename to annotate_source_line.
5281         * stack.c: Add 'annotate.h' include.
5282         (print_frame_info): Remove check of annotation_level before
5283         calling annotate_source_line.
5284
5285 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5286
5287         * source-cache.c (source_cache::get_plain_source_lines): Use
5288         open_source_file_with_line_charpos instead of just
5289         open_source_file, remove call to find_source_lines.
5290         (source_cache::get_source_lines): Likewise.
5291         * source.c (find_source_lines): Make static.
5292         (get_filename_and_charpos): Renamed into...
5293         (open_source_file_with_line_charpos): ..this along with changes to
5294         return a scoped_fd, and some other minor clean ups.
5295         (identify_source_line): Use open_source_file_with_line_charpos.
5296         (search_command_helper): Use open_source_file_with_line_charpos
5297         instead of just open_source_file, remove call to
5298         find_source_lines.
5299         * source.h (open_source_file_with_line_charpos): Declare new
5300         function.
5301         (find_source_lines): Delete declaration.
5302
5303 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5304
5305         * source.c (get_filename_and_charpos): Remove fullname
5306         parameter.
5307         (identify_source_line): Update call to get_filename_and_charpos.
5308
5309 2019-06-14  Tom Tromey  <tromey@adacore.com>
5310
5311         PR gdb/24502:
5312         * ui-style.h (skip_ansi_escape): Update comment.
5313         * ui-file.h (class no_terminal_escape_file): New class.
5314         * ui-file.c (no_terminal_escape_file::write)
5315         (no_terminal_escape_file::puts): New methods.
5316         * cli/cli-logging.c (handle_redirections): Use
5317         no_terminal_escape_file.
5318
5319 2019-06-14  Tom Tromey  <tromey@adacore.com>
5320
5321         * NEWS: Move convenience variable news above Python news.
5322
5323 2019-06-14  Tom Tromey  <tom@tromey.com>
5324
5325         * gnulib: Move directory to top-level.
5326         * configure.ac: Don't configure gnulib.
5327         * configure: Rebuild.
5328         * common/common-defs.h: Use new path to gnulib.
5329         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
5330         (GNULIB_H): Remove.
5331         (INCGNU): Look in new gnulib location.
5332         (HFILES_NO_SRCDIR): Remove gnulib files.
5333         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
5334         (generated_files): Remove GNULIB_H.
5335         ($(LIBGNU), all-lib): Remove targets.
5336         (distclean): Don't mention GNULIB_BUILDDIR.
5337         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
5338
5339 2019-06-14  Tom Tromey  <tromey@adacore.com>
5340
5341         * symfile.c (add_symbol_file_command): Remove obsolete comment.
5342         Warn if symbol file does not provide any symbols.
5343
5344 2019-06-14  Tom Tromey  <tromey@adacore.com>
5345
5346         * source.c (find_and_open_source): Respect basenames_may_differ.
5347
5348 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
5349
5350         * annotate.c (annotate_breakpoints_invalid): Make use of
5351         scoped_restore_terminal_state.
5352         (annotate_frames_invalid): Likewise.
5353
5354 2019-06-14  Tom Tromey  <tromey@adacore.com>
5355
5356         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
5357         allow assignment to an internalvar.
5358
5359 2019-06-14  Tom Tromey  <tromey@adacore.com>
5360
5361         * ada-lex.l: Allow "_" in attribute names.
5362
5363 2019-06-14  Tom Tromey  <tromey@adacore.com>
5364
5365         PR gdb/24653:
5366         * regcache.c (registers_changed): Don't call alloca.
5367         * top.c (execute_command): Don't call alloca.
5368
5369 2019-06-13  Pedro Alves  <palves@redhat.com>
5370
5371         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
5372         'expression'.  When parsing an expression, error out if there's
5373         junk after "unlimited".
5374         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5375         (do_set_command): Adjust calls to is_unlimited_literal.
5376
5377 2019-06-13  Pedro Alves  <palves@redhat.com>
5378
5379         * compile/compile.c (make_compile_options_def_group): Add braces
5380         around array_view initializer.
5381         * thread.c (make_thread_apply_all_options_def_group)
5382         (make_thread_apply_all_options_def_group): Likewise.
5383
5384 2019-06-13  Pedro Alves  <palves@redhat.com>
5385
5386         * NEWS (New commands): Mention "maint test-options
5387         require-delimiter", "maint test-options unknown-is-error", "maint
5388         test-options unknown-is-operand" and "maint show
5389         test-options-completion-result".
5390         (New command options, command completion): New section.
5391         (Completion improvements): New section.
5392         Mention that you can abbreviate "unlimited".
5393
5394 2019-06-13  Pedro Alves  <palves@redhat.com>
5395
5396         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
5397         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
5398         * unittests/cli-utils-selftests.c (test_parse_flags)
5399         (test_parse_flags_qcs): Delete.
5400         (test_cli_utils): Don't call deleted functions.
5401
5402 2019-06-13  Pedro Alves  <palves@redhat.com>
5403
5404         * thread.c: Include "cli/cli-option.h".
5405         (tp_array_compar_ascending): Global.
5406         (tp_array_compar): Delete function.
5407         (tp_array_compar_ascending, tp_array_compar_descending): New
5408         functions.
5409         (ascending_option_def, qcs_flag_option_def)
5410         (thr_qcs_flags_option_defs)
5411         (make_thread_apply_all_options_def_group)
5412         (make_thread_apply_options_def_group): New.
5413         (thread_apply_all_command): Use gdb::option::process_options.
5414         (thread_apply_command_completer)
5415         (thread_apply_all_command_completer): New.
5416         (thread_apply_command): Use gdb::option::process_options.
5417         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
5418         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
5419         to generate help text of "thread apply".  Adjust "taas"'s help.
5420         * tid-parse.c (tid_range_parser::in_thread_range): New method.
5421         * tid-parse.h (tid_range_parser::in_thread_range): New method.
5422
5423 2019-06-13  Pedro Alves  <palves@redhat.com>
5424
5425         * thread.c (thread_apply_command): Check for invalid TID with
5426         isdigit instead of !isalpha.
5427
5428 2019-06-13  Pedro Alves  <palves@redhat.com>
5429
5430         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
5431         (validate_flags_qcs): New.
5432         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
5433         (validate_flags_qcs): Declare.
5434         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
5435         (make_frame_apply_options_def_group): New.
5436         (frame_apply_command_count): Process options with
5437         gdb::option::process_options.
5438         (frame_apply_completer): New.
5439         (frame_apply_level_completer, frame_apply_all_completer)
5440         (frame_apply_completer): New.
5441         (_initialize_stack): Update help of "frame apply", "frame apply
5442         level", "frame apply all" and "faas" to mention supported options
5443         and install command completers.
5444         * stack.h (frame_apply_all_completer): Declare.
5445         * thread.c: Include "stack.h".
5446         (tfaas_command): Add "--".
5447         (_initialize_thread): Update help "tfaas" to mention supported
5448         options and install command completer.
5449
5450 2019-06-13  Pedro Alves  <palves@redhat.com>
5451
5452         * completer.c (complete_nested_command_line): New.
5453         (gdb_completion_word_break_characters_throw): Add assertion.
5454         * completer.h (complete_nested_command_line): Declare.
5455
5456 2019-06-13  Pedro Alves  <palves@redhat.com>
5457
5458         * stack.c (parse_backtrace_qualifiers): New.
5459         (backtrace_command): Use it.
5460         (backtrace_command_completer): Complete on qualifiers.
5461
5462 2019-06-13  Pedro Alves  <palves@redhat.com>
5463
5464         * frame.c: Include "cli/cli-option.h.
5465         (user_set_backtrace_options): New.
5466         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
5467         Delete.
5468         (get_prev_frame): Adjust.
5469         (boolean_option_def, uinteger_option_def)
5470         (set_backtrace_option_defs): New.
5471         (_initialize_frame): Adjust and use
5472         gdb::option::add_setshow_cmds_for_options to install "set
5473         backtrace past-main" and "set backtrace past-entry".
5474         * frame.h: Include "cli/cli-option.h".
5475         (struct frame_print_options): Forward declare.
5476         (print_frame_arguments_all, print_frame_arguments_scalars)
5477         (print_frame_arguments_none): Declare.
5478         (print_entry_values): Delete declaration.
5479         (struct frame_print_options, user_frame_print_options): New.
5480         (struct set_backtrace_options): New.
5481         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
5482         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
5483         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
5484         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
5485         (list_args_or_locals): Add frame_print_options parameter.
5486         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5487         * python/py-framefilter.c (enumerate_args): Pass down
5488         USER_FRAME_PRINT_OPTIONS.
5489         * stack.c: Include "cli/cli-option.h".
5490         (print_frame_arguments_all, print_frame_arguments_scalars)
5491         (print_frame_arguments_none): Declare.
5492         (print_raw_frame_arguments, print_entry_values): Delete.
5493         (user_frame_print_options): New.
5494         (boolean_option_def, enum_option_def, frame_print_option_defs):
5495         New.
5496         (struct backtrace_cmd_options): New.
5497         (bt_flag_option_def): New.
5498         (backtrace_command_option_defs): New.
5499         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5500         (print_frame_arg, read_frame_arg, print_frame_args)
5501         (print_frame_info, print_frame): Add frame_print_options parameter
5502         and use it.
5503         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
5504         (backtrace_command_1): Add frame_print_options and
5505         backtrace_cmd_options parameters and use them.
5506         (make_backtrace_options_def_group): New.
5507         (backtrace_command): Process command options with
5508         gdb::option::process_options.
5509         (backtrace_command_completer): New.
5510         (_initialize_stack): Extend "backtrace"'s help to mention
5511         supported options.  Install completer for "backtrace".
5512         Install some settings commands with add_setshow_cmds_for_options.
5513
5514 2019-06-13  Pedro Alves  <palves@redhat.com>
5515
5516         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
5517         and that "set/show print raw frame-arguments" are now deprecated.
5518
5519         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
5520         command.
5521         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
5522         * stack.c (_initialize_stack): Install "set/show print
5523         raw-frame-arguments", and deprecate "set/show print raw
5524         frame-arguments".
5525         * valprint.c (_initialize_valprint): Deprecate "set/show print
5526         raw".
5527
5528 2019-06-13  Pedro Alves  <palves@redhat.com>
5529
5530         * compile/compile.c (struct compile_options): New.
5531         (compile_flag_option_def, compile_command_option_defs)
5532         (make_compile_options_def_group): New.
5533         (compile_file_command): Handle options with
5534         gdb::option::process_options.
5535         (compile_file_command_completer): New function.
5536         (compile_code_command): Handle options with
5537         gdb::option::process_options.
5538         (compile_code_command_completer): New function.
5539         (_initialize_compiler): Install completers for "compile code" and
5540         "compile file".  Mention available options in "compile code" and
5541         "compile code"'s help.
5542         * completer.c (advance_to_completion_word): New, factored out from
5543         ...
5544         (advance_to_expression_complete_word_point): ... this.
5545         (advance_to_filename_complete_word_point): New.
5546         * completer.h (advance_to_filename_complete_word_point): New
5547         declaration.
5548
5549 2019-06-13  Pedro Alves  <palves@redhat.com>
5550
5551         * compile/compile.c: Include "cli/cli-option.h".
5552         (compile_print_value): Scope data pointer is now a
5553         value_print_options pointer; adjust.
5554         (compile_print_command): Process options.  Scope data pointer is
5555         now a value_print_options pointer; adjust.
5556         (_initialize_compile): Update "compile print"'s help to include
5557         supported options.  Install a completer for "compile print".
5558         * cp-valprint.c (show_vtblprint, show_objectprint)
5559         (show_static_field_print): Delete.
5560         (_initialize_cp_valprint): Don't install "set print
5561         static-members", "set print vtbl", "set print object" here.
5562         * printcmd.c: Include "cli/cli-option.h" and
5563         "common/gdb_optional.h".
5564         (print_command_parse_format): Rework to fill in a
5565         value_print_options instead of a format_data.
5566         (print_value): Change parameter type from format_data pointer to
5567         value_print_options reference.  Adjust.
5568         (print_command_1): Process options.  Adjust to pass down a
5569         value_print_options.
5570         (print_command_completer): New.
5571         (_initialize_printcmd): Install print_command_completer as
5572         handle_brkchars completer for the "print" command.  Update
5573         "print"'s help to include supported options.
5574         * valprint.c: Include "cli/cli-option.h".
5575         (show_vtblprint, show_objectprint, show_static_field_print): Moved
5576         here from cp-valprint.c.
5577         (boolean_option_def, uinteger_option_def)
5578         (value_print_option_defs, make_value_print_options_def_group):
5579         New.  Use gdb::option::add_setshow_cmds_for_options to install
5580         "set print elements", "set print null-stop", "set print repeats",
5581         "set print pretty", "set print union", "set print array", "set
5582         print address", "set print symbol", "set print array-indexes".
5583         * valprint.h: Include <string> and "cli/cli-option.h".
5584         (make_value_print_options_def_group): Declare.
5585         (print_value): Change parameter type from format_data pointer to
5586         value_print_options reference.
5587         (print_command_completer): Declare.
5588
5589 2019-06-13  Pedro Alves  <palves@redhat.com>
5590
5591         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
5592         (COMMON_SFILES): Add maint-test-settings.c.
5593         * cli/cli-decode.c (boolean_enums): New global, factored out from
5594         ...
5595         (add_setshow_boolean_cmd): ... here.
5596         * cli/cli-decode.h (boolean_enums): Declare.
5597         * cli/cli-option.c: New file.
5598         * cli/cli-option.h: New file.
5599         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
5600         factored out from ...
5601         (parse_cli_boolean_value(const char *)): ... this.
5602         (is_unlimited_literal): Change parameter type to pointer to
5603         pointer.  Adjust and advance ARG pointer.
5604         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5605         (parse_cli_var_enum): New, factored out from ...
5606         (do_set_command): ... this.  Adjust.
5607         * cli/cli-setshow.h (parse_cli_boolean_value)
5608         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5609         (parse_cli_var_enum): Declare.
5610         * cli/cli-utils.c: Include "cli/cli-option.h".
5611         (get_ulongest): New.
5612         * cli/cli-utils.h (get_ulongest): Declare.
5613         (check_for_argument): New overloads.
5614         * maint-test-options.c: New file.
5615
5616 2019-06-13  Pedro Alves  <palves@redhat.com>
5617
5618         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
5619         parse a range if "-" is at the end of the string.
5620
5621 2019-06-13  Pedro Alves  <palves@redhat.com>
5622
5623         * cli/cli-setshow.c (parse_auto_binary_operation)
5624         (parse_cli_boolean_value): Don't allow "o".
5625
5626 2019-06-13  Pedro Alves  <palves@redhat.com>
5627
5628         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
5629         * NEWS: Mention maint test-settings KIND.
5630         * maint-test-settings.c: New file.
5631
5632 2019-06-13  Pedro Alves  <palves@redhat.com>
5633
5634         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
5635         completer.
5636         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
5637         "set" completers.
5638
5639 2019-06-13  Pedro Alves  <palves@redhat.com>
5640
5641         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
5642         after item.
5643
5644 2019-06-13  Pedro Alves  <palves@redhat.com>
5645
5646         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
5647
5648 2019-06-13  Pedro Alves <palves@redhat.com>
5649
5650         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
5651         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
5652         call.
5653         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
5654         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
5655         calls.
5656         (check_for_argument): Skip spaces after argument.
5657
5658 2019-06-13  Pedro Alves  <palves@redhat.com>
5659
5660         * thread.c (thread_apply_command): Adjust TID parsing.
5661         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
5662         detected before end of string.
5663         (tid_is_in_list): Error out if LIST is invalid.
5664
5665 2019-06-13  Pedro Alves  <palves@redhat.com>
5666
5667         * completer.c (complete_line_internal_1): Rewind completion word
5668         point.
5669         (completion_tracker::advance_custom_word_point_by): Change
5670         parameter type to int.
5671         * completer.h (completion_tracker::advance_custom_word_point_by):
5672         Likewise.
5673
5674 2019-06-13  Pedro Alves  <palves@redhat.com>
5675
5676         * completer.c (advance_to_completion_word): Handle delimiters.
5677
5678 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
5679
5680         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
5681
5682 2019-06-11  Tom Tromey  <tom@tromey.com>
5683
5684         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
5685         (xmalloc_failed): Move to alloc.c.
5686         * alloc.c: New file.
5687         * Makefile.in (COMMON_SFILES): Add alloc.c.
5688
5689 2019-06-11  Tom Tromey  <tom@tromey.com>
5690
5691         * nat/linux-waitpid.c: Don't include server.h.
5692         (linux_debug): Remove.
5693         (my_waitpid): Update.
5694
5695 2019-06-11  Tom Tromey  <tromey@adacore.com>
5696
5697         * infcall.c (_initialize_infcall): Remove trailing newline from
5698         help.
5699         * user-regs.c (_initialize_user_regs): Remove trailing newline
5700         from help.
5701         * typeprint.c (_initialize_typeprint): Remove trailing newline
5702         from help.
5703         * reverse.c (_initialize_reverse): Remove trailing newlines from
5704         help.
5705         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
5706         from help.
5707         * language.c (add_set_language_command): Remove trailing newline
5708         from help.
5709         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
5710         help.
5711         * disasm.c (_initialize_disasm): Remove trailing newline from
5712         help.
5713         * top.c (init_main): Remove trailing newline from help.
5714         * interps.c (_initialize_interpreter): Remove trailing newline
5715         from help.
5716         * btrace.c (_initialize_btrace): Remove trailing newlines from
5717         help.
5718         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
5719         from help.
5720         * python/python.c (_initialize_python): Remove trailing newline
5721         from help.
5722         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
5723         help.
5724         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
5725         from help.  Reformat some text.
5726         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
5727         from help.
5728         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
5729         newline from help.
5730
5731 2019-06-11  Tom Tromey  <tromey@adacore.com>
5732
5733         * darwin-nat.c (darwin_decode_exception_message)
5734         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
5735
5736 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5737
5738         * valops.c (value_slice): Check for not allocated or not
5739         associated values.
5740
5741 2019-06-10  Tom de Vries  <tdevries@suse.de>
5742
5743         PR gdb/24618
5744         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
5745         sure an empty slot (defined by a 32-bit zero pair) is recognized as
5746         invalid.
5747
5748 2019-06-10  Tom de Vries  <tdevries@suse.de>
5749
5750         PR gdb/24611
5751         * linespec.c (linespec_lexer_lex_string): Remove incorrect
5752         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
5753
5754 2019-06-10  Tom de Vries  <tdevries@suse.de>
5755
5756         PR symtab/24545
5757         * symtab.c (struct demangled_name_entry): Add language field.
5758         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
5759         static minimal symbol".  Set and use language field.
5760
5761 2019-06-10  Tom Tromey  <tromey@adacore.com>
5762
5763         * ada-lang.c (_initialize_ada_language): Update help text.
5764
5765 2019-06-10  Tom Tromey  <tromey@adacore.com>
5766
5767         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
5768         with a newline.
5769         * guile/guile.c (handle_boot_error): Don't end warning with a
5770         newline.
5771         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
5772         warning with a newline.
5773         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
5774         newline.
5775         (s12z_frame_cache): Likewise.
5776         * dwarf-index-cache.c (index_cache::store): Don't end warning with
5777         a newline.
5778         * solib-svr4.c (disable_probes_interface): Don't end warning with
5779         a newline.
5780         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
5781         newline.
5782         * python/python.c (do_finish_initialization): Don't end warning
5783         with a newline.
5784
5785 2019-06-10  Tom Tromey  <tom@tromey.com>
5786
5787         * python/py-breakpoint.c (gdbpy_breakpoint_created)
5788         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
5789         gdbpy_enter.
5790
5791 2019-06-10  Tom Tromey  <tromey@adacore.com>
5792
5793         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
5794         data.
5795         (elf_new_init): Don't call stabsread_new_init.
5796         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
5797         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
5798         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
5799
5800 2019-06-10  Tom de Vries  <tdevries@suse.de>
5801
5802         PR symtab/16264
5803         PR symtab/24517
5804         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
5805
5806 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
5807
5808         * source.c (find_and_open_source): Also rewrite relative file
5809         names.
5810
5811 2019-04-26  Amos Bird  <amosbird@gmail.com>
5812
5813         * annotate.c (annotate_thread_exited): Add "thread-exited"
5814         annotation.
5815
5816 2019-06-06  Tom Tromey  <tromey@adacore.com>
5817
5818         * maint.h (class scoped_command_stats): Use
5819         DISABLE_COPY_AND_ASSIGN.
5820         <print_time>: New method.
5821         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
5822         print_time.
5823         (scoped_command_stats::print_time): New method.
5824
5825 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
5826
5827         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
5828         instructions of lengths 6 or 8 bytes.
5829
5830 2019-06-04  Pedro Alves  <palves@redhat.com>
5831
5832         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
5833
5834         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
5835         * breakpoint.c (condition_completer): Likewise.
5836         * cli/cli-dump.c (scan_expression): Likewise.
5837         * common/filestuff.c (mkdir_recursive): Likewise.
5838         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
5839         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
5840         (gdb_abspath): Likewise.
5841         * compile/compile-cplus-types.c
5842         (compile_cplus_instance::decl_name): Likewise.
5843         * completer.c (complete_explicit_location):
5844         (signal_completer, reg_or_group_completer_1): Likewise.
5845         * cp-support.c (cp_remove_params_if_any): Likewise.
5846         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
5847         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
5848         * infcmd.c (strip_bg_char): Likewise.
5849         * linespec.c (copy_token_string): Likewise.
5850         * mi/mi-main.c (output_cores): Likewise.
5851         * psymtab.c (psymtab_search_name):
5852         * symfile.c (test_set_ext_lang_command): Likewise.
5853         * target.c (target_fileio_read_stralloc): Likewise.
5854         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
5855         * value.c (complete_internalvar): Likewise.
5856
5857 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
5858
5859         Add objfile property to gdb.Type.
5860         * NEWS: Mention Python API addition.
5861         * python/py-type.c (typy_get_objfile): New method.
5862
5863 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5864
5865         * NEWS: Mention the new set|show style [title|highlight].
5866         Mention changes to "show style", "help" and "apropos".
5867
5868 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5869
5870         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
5871         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
5872         instead of print_help_for_command.
5873         (print_doc_of_command): New function.
5874         (help_list): Add 'apropos -v word' suggestion.
5875         (print_help_for_command): Style the command name using title style.
5876         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
5877         (_initialize_cli_cmds): Describe -v in apropos_command help.
5878
5879 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5880
5881         * cli/cli-style.h (cli_style_option): Add name in constructor,
5882         add m_name class member, add constructor with intensity,
5883         add name class function.
5884         (cli_style_option::add_setshow_commands): Remove name argument.
5885         (highlight_style, title_style): New styles.
5886         * cli/cli-style.c (do_show): New function that shows a style
5887         characteristic styling the style name with itself.
5888         (set_style_name): New function.
5889         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
5890         Update all callers according to the changes in cli/cli-style.h.
5891         * utils.h (fputs_highlighted): New function.
5892         * utils.c (fputs_highlighted): Likewise.
5893
5894 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5895
5896         * NEWS: Mention new pipe command and new convenience variables.
5897
5898 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5899
5900         * cli/cli-cmds.c (pipe_command): New function.
5901         (_initialize_cli_cmds): Call add_com for pipe_command.
5902         Define | as an alias for pipe.
5903         (exit_status_set_internal_vars): New function.
5904         (shell_escape): Call exit_status_set_internal_vars.
5905         cli/cli-decode.c (find_command_name_length): Recognize | as
5906         a single character command.
5907
5908 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5909
5910         * gdbcmd.h (execute_command_to_ui_file): New declaration.
5911         top.c (execute_command_to_ui_file): New function, mostly a copy
5912         of execute_command_to_string.
5913         (execute_command_to_string): Implement by calling
5914         execute_command_to_ui_file.
5915
5916 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5917
5918         * top.h (saved_command_line): Remove declaration.
5919         * top.c (previous_saved_command_line, previous_repeat_arguments):
5920         New variables.
5921         (saved_command_line): Make static, define together with other
5922         'repeat variables'.
5923         (dont_repeat): Clear repeat_arguments.
5924         (repeat_previous, get_saved_command_line, save_command_line):
5925         New functions.
5926         (gdb_init): Initialize saved_command_line
5927         and previous_saved_command_line.
5928         * main.c (captured_main_1): Remove saved_command_line initialization.
5929         * event-top.c (handle_line_of_input): Update to use
5930         the new 'repeat' related functions instead of direct access to
5931         saved_command_line.
5932         * command.h (repeat_previous, get_saved_command_line,
5933         save_command_line): New declarations.
5934         (dont_repeat): Add comment.
5935
5936 2019-05-30  Tom Tromey  <tromey@adacore.com>
5937
5938         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
5939         Fix comment.
5940         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
5941
5942 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
5943
5944         PR cli/24587
5945         * completer.c (complete): Initialize variable word.
5946
5947 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
5948
5949         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5950         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
5951         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
5952         'body' is NULL to the outter 'if', protecting the '!is_define'
5953         situation as well.
5954
5955 2019-05-29  Tom Tromey  <tromey@adacore.com>
5956
5957         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
5958         (dwarf_unknown): New function.
5959         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
5960         (dwarf_type_encoding_name): Use dwarf_unknown.
5961
5962 2019-05-29  Tom Tromey  <tromey@adacore.com>
5963
5964         PR c++/20020:
5965         * cp-valprint.c (cp_print_value_fields): Call
5966         cp_print_static_field inside "try".
5967
5968 2019-05-29  Tom Tromey  <tromey@adacore.com>
5969
5970         * inflow.c (struct terminal_info): Add default operator=.
5971         * configure: Rebuild.
5972         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
5973         -Wdeprecated-copy-dtor, -Wredundant-move.
5974
5975 2019-05-29  Tom Tromey  <tromey@adacore.com>
5976
5977         * NEWS: Add entry.
5978         * infcmd.c (print_return_value_1): Handle finish_print
5979         option.
5980         (show_print_finish): New function.
5981         (_initialize_infcmd): Add "set/show print finish" commands.
5982         * valprint.c (user_print_options): Initialize new member.
5983         * valprint.h (struct value_print_options) <finish_print>: New
5984         member.
5985
5986 2019-05-28  Tom Tromey  <tromey@adacore.com>
5987
5988         * ada-lang.c (ada_remove_Xbn_suffix)
5989         (find_old_style_renaming_symbol)
5990         (parse_old_style_renaming): Remove.
5991         (ada_find_renaming_symbol): Don't call
5992         find_old_style_renaming_symbol.
5993         (ada_is_renaming_symbol): Rename from
5994         ada_find_renaming_symbol.  Remove "block" parameter.  Return
5995         bool.  Now static.
5996         (ada_read_var_value): Update and simplify.
5997         * ada-exp.y (write_var_or_type): Remove old code.
5998
5999 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
6000
6001         * event-top.c: Remove include comment.
6002         * inflow.c (class scoped_ignore_sigttou): Move from here...
6003         * inflow.h (class scoped_ignore_sigttou): ...to here.
6004         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
6005         * top.c:  Remove include comment.
6006
6007 2019-05-27  Tom Tromey  <tom@tromey.com>
6008
6009         * NEWS: Fix typo.
6010
6011 2019-05-22  Tom Tromey  <tromey@adacore.com>
6012
6013         * target.c (target_follow_exec): Constify parameter.
6014         * target-delegates.c: Rebuild.
6015         * remote.c (remote_target::follow_exec): Constify parameter.
6016         * infrun.c (follow_exec): Constify parameter.
6017         * target.h (struct target_ops) <follow_exec>: Constify parameter.
6018         (target_follow_exec): Likewise.
6019
6020 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6021
6022         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
6023         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
6024
6025 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6026
6027         * NEWS: Add debugredirect and testsuite sections.
6028
6029 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
6030
6031         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
6032         target descriptions using exclusively floating point register name
6033         aliases.
6034
6035 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6036
6037         PR gdb/18644:
6038         * f-lang.c (build_fortran_types): Handle the case where
6039         gdbarch_floatformat_for_type returns a nullptr.
6040
6041 2019-05-21  Tom de Vries  <tdevries@suse.de>
6042
6043         PR cli/24587
6044         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
6045
6046 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6047
6048         PR gdb/18644:
6049         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
6050         16-byte floats.
6051         * i386-tdep.c (i386_floatformat_for_type): Use
6052         floatformats_ia64_quad for the 16-byte floating point component
6053         within a fortran 32-byte complex number.
6054
6055 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6056
6057         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
6058         delete default constructor.
6059         (find_partial_die): Update to return const struct.
6060         (partial_die_parent_scope): Move variable declaration into scope
6061         of its use and change its type to auto.
6062         (guess_partial_die_structure_name): Likewise.
6063         (partial_die_info::fixup): Likewise.
6064
6065 2019-05-17  Tom Tromey  <tromey@adacore.com>
6066
6067         * source.c (find_and_open_source): Remove cast.
6068
6069 2019-05-17  Tom Tromey  <tromey@adacore.com>
6070
6071         * annotate.c (annotate_source): Make "filename" const.
6072         * annotate.h (annotate_source): Use const.
6073
6074 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6075
6076         * disasm.c (set_disassembler_options): Send errors to stderr.
6077
6078 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6079
6080         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
6081         (cli_interp_base::set_logging): Check debug_redirect.
6082         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
6083         * cli/cli-logging.c (debug_redirect): Add static variable.
6084         (pop_output_files): Add default param.
6085         (handle_redirections): Print debug setting.
6086         (show_logging_command): Likewise.
6087         (_initialize_cli_logging): Add debugredirect command.
6088         * interps.c (current_interp_set_logging): Add debug_redirect
6089         parameter.
6090         * interps.h (set_logging): Add debug_redirect parameter.
6091         (current_interp_set_logging): Likewise.
6092         * mi/mi-common.h: Likewise.
6093         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
6094
6095 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6096             Tom Tromey  <tromey@adacore.com>
6097
6098         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
6099         directly.
6100         * cli/cli-interp.h (make_logging_output): Remove declaration.
6101         * cli/cli-logging.c (make_logging_output): Remove function.
6102         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
6103         directly.
6104         * ui-file.c (tee_file::tee_file): Remove bools.
6105         (tee_file::~tee_file): Remove deletes.
6106         * ui-file.h (tee_file): Remove bools.
6107
6108 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
6109
6110         * mi/mi-cmds.h (mi_cmd_complete): New function.
6111         * mi/mi-main.c (mi_cmd_complete): Likewise.
6112         * mi/mi-cmds.c: Define new MI command -complete.
6113         * NEWS: Mention new -complete command.
6114
6115 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
6116
6117         * completer.h (complete): New function.
6118         * completer.c (complete): Likewise.
6119         * cli/cli-cmds.c: (complete_command): Update to use new complete()
6120         function defined in completer.h.
6121
6122 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
6123
6124         * MAINTAINERS (Write After Approval): Add myself.
6125
6126 2019-05-17  Tom de Vries  <tdevries@suse.de>
6127
6128         PR gdb/24094
6129         * dwarf2read.c (struct cu_partial_die_info): New struct.
6130         (find_partial_die): Return cu_partial_die_info.
6131         (partial_die_parent_scope, guess_partial_die_structure_name)
6132         (partial_die_info::fixup): Handle new return type of find_partial_die.
6133
6134 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6135
6136         PR breakpoints/24541
6137         * stap-probe.c (stap_parse_register_operand): Make "regname" an
6138         "std::string", simplifying the algorithm.
6139
6140 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6141
6142         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
6143         (stap_static_probe_ops::get_probes): Likewise.
6144
6145 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6146
6147         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
6148         '-')" and "else if".
6149         (stap_parse_single_operand): Join checks for
6150         "gdbarch_stap_parse_special_token_p" and
6151         "gdbarch_stap_parse_special_token" in the same "if" statement.
6152         Invert check when verifying for operation on register
6153         displacement.
6154
6155 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6156
6157         * stap-probe.c (stap_get_opcode): Update comment.
6158         (stap_get_expected_argument_type): Likewise.
6159         (handle_stap_probe): Likewise.
6160
6161 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6162
6163         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
6164         return type to 'bool'.  Adjust comment.  Use 'bool' when
6165         appropriate.
6166         (i386_stap_parse_special_token_three_arg_disp): Likewise.
6167         * stap-probe.c (stap_parse_argument_1): Likewise.
6168         (stap_is_operator): Likewise.
6169         (stap_is_generic_prefix): Likewise.
6170         (stap_is_register_prefix): Likewise.
6171         (stap_is_register_indirection_prefix): Likewise.
6172         (stap_is_integer_prefix): Likewise.
6173         (stap_generic_check_suffix): Likewise.
6174         (stap_check_integer_suffix): Likewise.
6175         (stap_check_register_suffix): Likewise.
6176         (stap_check_register_indirection_suffix): Likewise.
6177         (stap_parse_register_operand): Likewise.
6178         (stap_parse_single_operand): Likewise.
6179         (stap_parse_argument_1): Likewise.
6180         (stap_probe::get_argument_count): Likewise.
6181         (stap_is_operator): Likewise.
6182
6183 2019-05-16  Tom Tromey  <tromey@adacore.com>
6184
6185         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
6186         keyword to foreach.
6187
6188 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
6189
6190         * linux-thread-db.c (try_thread_db_load_1): Change return type
6191         to bool.
6192         (try_thread_db_load): Likewise.
6193         (try_thread_db_load_from_pdir_1): Likewise.
6194         (try_thread_db_load_from_pdir): Likewise.
6195         (try_thread_db_load_from_sdir): Likewise.
6196         (try_thread_db_load_from_dir): Likewise.
6197         (thread_db_load_search): Likewise.
6198         (has_libpthread): Likewise.
6199         (thread_db_load): Likewise.
6200
6201 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
6202
6203         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6204         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
6205         NULL, and complain/return if that's the case.
6206
6207 2019-05-15  John Darrington <john@darrington.wattle.id.au>
6208
6209         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
6210         (advance, posn, abstract_read_memory): New functions.
6211         [struct mem_read_abstraction]: New struct.
6212         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
6213
6214 2019-05-14  Tom Tromey  <tromey@adacore.com>
6215
6216         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
6217         value is not lval_memory.
6218
6219 2019-05-14  Tom Tromey  <tromey@adacore.com>
6220
6221         * solib.c (info_sharedlibrary_command): Style the file name.
6222
6223 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
6224
6225         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
6226         (aarch64_vnv_type): Likewise.
6227         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
6228         * common/tdesc.c: Likewise.
6229         * common/tdesc.h (enum tdesc_type_kind): Likewise.
6230         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
6231         * features/aarch64-fpu.xml: Add ieee half view.
6232         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
6233         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
6234         * gdbtypes.h (struct builtin_type): Likewise.
6235         (struct objfile_type): Likewise.
6236
6237 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
6238
6239         * language.c (language_sniff_from_mangled_name): Fix "langauge"
6240         typo.
6241         * location.h (string_to_event_location): Likewise.
6242
6243 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
6244
6245         GDB 8.3 released.
6246
6247 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6248
6249         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
6250         New variable declaration.
6251         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
6252         New variable.
6253         (print_one_breakpoint): Use ui_out::test_flags and new global
6254         variable to compute use_fixed_output.
6255         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
6256         Remove.
6257         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
6258         (mi_multi_location_breakpoint_output_fixed): Remove.
6259         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
6260         new variable.
6261         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
6262         fix_multi_location_breakpoint_output flag if version >= 3.
6263         * ui-out.h (enum ui_out_flag)
6264         <fix_multi_location_breakpoint_output>: New enumerator.
6265
6266 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6267
6268         * contrib/cc-with-tweaks.sh: Validate dwz's work.
6269
6270 2019-05-10  Tom Tromey  <tromey@adacore.com>
6271
6272         * ada-lang.c (catch_ada_completer): New function.
6273         (_initialize_ada_language): Use it.
6274
6275 2019-05-10  Tom Tromey  <tromey@adacore.com>
6276
6277         * thread.c (print_thread_info): Make "requested_threads" const.
6278         * gdbthread.h (print_thread_info): Make "requested_threads"
6279         const.
6280         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
6281         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
6282
6283 2019-05-08  Tom Tromey  <tom@tromey.com>
6284
6285         * gdbtypes.c (objfile_type_data): Change type.
6286         (objfile_type, _initialize_gdbtypes): Update.
6287
6288 2019-05-08  Tom Tromey  <tom@tromey.com>
6289
6290         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
6291         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
6292         (_initialize_dwarf2_frame): Update.
6293
6294 2019-05-08  Tom Tromey  <tom@tromey.com>
6295
6296         * objc-lang.c (objc_objfile_data): Change type.
6297         (find_methods): Update.
6298         (_initialize_objc_lang): Remove.
6299
6300 2019-05-08  Tom Tromey  <tom@tromey.com>
6301
6302         * stabsread.c (rs6000_builtin_type_data): Change type.
6303         (rs6000_builtin_type, _initialize_stabsread): Update.
6304
6305 2019-05-08  Tom Tromey  <tom@tromey.com>
6306
6307         * mips-tdep.c (mips_pdr_data): Remove.
6308         (_initialize_mips_tdep): Update.
6309
6310 2019-05-08  Tom Tromey  <tom@tromey.com>
6311
6312         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
6313         (hppa_init_objfile_priv_data, read_unwind_info)
6314         (find_unwind_entry, _initialize_hppa_tdep): Update.
6315
6316 2019-05-08  Tom Tromey  <tom@tromey.com>
6317
6318         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
6319         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
6320         on obstack.
6321         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
6322
6323 2019-05-08  Tom Tromey  <tom@tromey.com>
6324
6325         * mdebugread.c (basic_type_data): Change type.
6326         (basic_type, _initialize_mdebugread): Update.
6327
6328 2019-05-08  Tom Tromey  <tom@tromey.com>
6329
6330         * common/gdb_unique_ptr.h (struct noop_deleter): New.
6331
6332 2019-05-08  Tom Tromey  <tom@tromey.com>
6333
6334         * nto-tdep.c (nto_inferior_data_reg): Change type.
6335         (nto_inferior_data): Update.
6336         (nto_inferior_data_cleanup, nto_new_inferior_data)
6337         (_initialize_nto_tdep): Remove.
6338         * nto-tdep.h (struct nto_inferior_data): Add initializers.
6339
6340 2019-05-08  Tom Tromey  <tom@tromey.com>
6341
6342         * ada-lang.c (struct ada_inferior_data): Add initializers.
6343         (ada_inferior_data): Change type.
6344         (ada_inferior_data_cleanup): Remove.
6345         (get_ada_inferior_data, ada_inferior_exit)
6346         (struct ada_pspace_data): Add initializers, destructor.
6347         (ada_pspace_data_handle): Change type.
6348         (get_ada_pspace_data): Update.
6349         (ada_pspace_data_cleanup): Remove.
6350
6351 2019-05-08  Tom Tromey  <tom@tromey.com>
6352
6353         * coffread.c (struct coff_symfile_info): Add initializers.
6354         (coff_objfile_data_key): Move lower.  Change type.
6355         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
6356         Update.
6357         (coff_free_info): Remove.
6358
6359 2019-05-08  Tom Tromey  <tom@tromey.com>
6360
6361         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
6362         (fbsd_pspace_data_handle): Move lower.  Change type.
6363         (get_fbsd_pspace_data): Update.
6364         (fbsd_pspace_data_cleanup): Remove.
6365         (_initialize_fbsd_tdep): Update.
6366
6367 2019-05-08  Tom Tromey  <tom@tromey.com>
6368
6369         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
6370         (get_ada_tasks_pspace_data): Update.
6371         (ada_tasks_pspace_data_cleanup): Remove.
6372         (_initialize_tasks): Update.
6373         (ada_tasks_inferior_data_handle): Change type.
6374         (get_ada_tasks_inferior_data): Update.
6375         (ada_tasks_inferior_data_cleanup): Remove.
6376         (struct ada_tasks_pspace_data): Add initializers.
6377
6378 2019-05-08  Tom Tromey  <tom@tromey.com>
6379
6380         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
6381         * symfile-debug.c (debug_sym_get_probes): Change type.
6382         * stap-probe.c (handle_stap_probe):
6383         (stap_static_probe_ops::get_probes): Change type.
6384         * probe.h (class static_probe_ops) <get_probes>: Change type.
6385         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
6386         (parse_probes_in_pspace): Update.
6387         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
6388         Update.
6389         (any_static_probe_ops::get_probes): Change type.
6390         * elfread.c (elfread_data): New typedef.
6391         (probe_key): Change type.
6392         (elf_get_probes): Likewise.  Update.
6393         (probe_key_free): Remove.
6394         (_initialize_elfread): Update.
6395         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
6396         Change type.
6397         (dtrace_process_dof_probe, dtrace_process_dof)
6398         (dtrace_static_probe_ops::get_probe): Change type.
6399
6400 2019-05-08  Tom Tromey  <tom@tromey.com>
6401
6402         * xcoffread.c (struct xcoff_symfile_info): Rename from
6403         coff_symfile_info.  Add initializers.
6404         (xcoff_objfile_data_key): Move lower.  Change type.
6405         (XCOFF_DATA): Rewrite.
6406         (xcoff_free_info): Remove.
6407         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
6408         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
6409         (xcoff_initial_scan): Update.
6410
6411 2019-05-08  Tom Tromey  <tom@tromey.com>
6412
6413         * solib-svr4.c (struct svr4_info): Add initializers and
6414         destructor.
6415         <probes_table>: Now an htab_up.
6416         (solib_svr4_pspace_data): Change type.
6417         (free_probes_table): Simplify.
6418         (~svr4_info): Rename from svr4_pspace_data_cleanup.
6419         (get_svr4_info, probes_table_htab_remove_objfile_probes)
6420         (probes_table_remove_objfile_probes, register_solib_event_probe)
6421         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
6422         (_initialize_svr4_solib): Update.
6423
6424 2019-05-08  Tom Tromey  <tom@tromey.com>
6425
6426         * remote.c (remote_pspace_data): Change type.
6427         (remote_pspace_data_cleanup): Remove.
6428         (get_remote_exec_file, set_pspace_remote_exec_file)
6429         (_initialize_remote): Update.
6430
6431 2019-05-08  Tom Tromey  <tom@tromey.com>
6432
6433         * breakpoint.c (breakpoint_objfile_key): Change type.
6434         (get_breakpoint_objfile_data): Update.
6435         (free_breakpoint_objfile_data): Remove.
6436         (_initialize_breakpoint): Update.
6437
6438 2019-05-08  Tom Tromey  <tom@tromey.com>
6439
6440         * linux-tdep.c (struct linux_info): Add initializers.
6441         (linux_inferior_data): Move.  Change type.
6442         (invalidate_linux_cache_inf): Update.
6443         (linux_inferior_data_cleanup): Remove.
6444         (get_linux_inferior_data, _initialize_linux_tdep): Update.
6445
6446 2019-05-08  Tom Tromey  <tom@tromey.com>
6447
6448         * auxv.c (auxv_inferior_data): Move.  Change type.
6449         (auxv_inferior_data_cleanup): Remove.
6450         (invalidate_auxv_cache_inf): Rewrite.
6451         (get_auxv_inferior_data, _initialize_auxv): Update.
6452
6453 2019-05-08  Tom Tromey  <tom@tromey.com>
6454
6455         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
6456         (symfile_debug_objfile_data_key): Change type.
6457         (symfile_debug_installed, debug_qf_has_symbols)
6458         (debug_qf_find_last_source_symtab)
6459         (debug_qf_forget_cached_source_info)
6460         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
6461         (debug_qf_print_stats, debug_qf_dump)
6462         (debug_qf_expand_symtabs_for_function)
6463         (debug_qf_expand_all_symtabs)
6464         (debug_qf_expand_symtabs_with_fullname)
6465         (debug_qf_map_matching_symbols)
6466         (debug_qf_expand_symtabs_matching)
6467         (debug_qf_find_pc_sect_compunit_symtab)
6468         (debug_qf_map_symbol_filenames)
6469         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
6470         (debug_sym_new_init, debug_sym_init, debug_sym_read)
6471         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
6472         (debug_sym_read_linetable, debug_sym_relocate): Update.
6473         (symfile_debug_free_objfile): Remove.
6474         (install_symfile_debug_logging, _initialize_symfile_debug):
6475         Update.
6476
6477 2019-05-08  Tom Tromey  <tom@tromey.com>
6478
6479         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
6480         allocate_on_obstack.
6481         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
6482         (get_dwarf2_per_objfile): Update.
6483         (set_dwarf2_per_objfile): Remove.
6484         (dwarf2_has_info, dwarf2_get_section_info): Update.
6485         (dwarf2_free_objfile): Remove.
6486         (_initialize_dwarf2_read): Update.
6487
6488 2019-05-08  Tom Tromey  <tom@tromey.com>
6489
6490         * auto-load.c (struct auto_load_pspace_info): Add destructor and
6491         initializers.
6492         <unsupported_script_warning_printed,
6493         script_not_found_warning_printed>: Now bool.
6494         (auto_load_pspace_data): Change type.
6495         (~auto_load_pspace_info): Rename from
6496         auto_load_pspace_data_cleanup.
6497         (get_auto_load_pspace_data, init_loaded_scripts_info)
6498         (clear_section_scripts, maybe_print_unsupported_script_warning)
6499         (maybe_print_script_not_found_warning, _initialize_auto_load):
6500         Update.
6501
6502 2019-05-08  Tom Tromey  <tom@tromey.com>
6503
6504         * objfiles.c (objfile_pspace_info): Add destructor and
6505         initializers.
6506         (objfiles_pspace_data): Change type.
6507         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
6508         (get_objfile_pspace_data): Update.
6509         (objfiles_bfd_data): Change type.
6510         (get_objfile_bfd_data): Update.
6511         (objfile_bfd_data_free, _initialize_objfiles): Remove.
6512
6513 2019-05-08  Tom Tromey  <tom@tromey.com>
6514
6515         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
6516         Change type.
6517         (get_catch_syscall_inferior_data): Update.
6518         (catch_syscall_inferior_data_cleanup): Remove.
6519         (_initialize_break_catch_syscall): Update.
6520
6521 2019-05-08  Tom Tromey  <tom@tromey.com>
6522
6523         * inflow.c (struct terminal_info): Add destructor and
6524         initializers.
6525         (inflow_inferior_data): Change type.
6526         (~terminal_info): Rename from inflow_inferior_data_cleanup.
6527         (get_inflow_inferior_data, inflow_inferior_exit)
6528         (swap_terminal_info, _initialize_inflow): Update.
6529
6530 2019-05-08  Tom Tromey  <tom@tromey.com>
6531
6532         * target-dcache.c (target_dcache_cleanup): Remove.
6533         (target_dcache_aspace_key): Change type.
6534         (target_dcache_init_p, target_dcache_invalidate)
6535         (target_dcache_get, target_dcache_get_or_init)
6536         (_initialize_target_dcache): Update.
6537         * dcache.h (struct dcache_deleter): New.
6538
6539 2019-05-08  Tom Tromey  <tom@tromey.com>
6540
6541         * symtab.c (struct symbol_cache): Add destructor and
6542         initializers.
6543         (symbol_cache_key): Move.  Change type.
6544         (make_symbol_cache, free_symbol_cache): Remove.
6545         (get_symbol_cache): Update.
6546         (symbol_cache_cleanup): Remove.
6547         (ALL_PSPACES, symbol_cache_flush)
6548         (maintenance_print_symbol_cache)
6549         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
6550         Update.
6551
6552 2019-05-08  Tom Tromey  <tom@tromey.com>
6553
6554         * symtab.c (struct main_info): Add destructor and initializers.
6555         (main_progspace_key): Move.  Change type.
6556         (get_main_info): Update.
6557         (main_info_cleanup): Remove.
6558         (_initialize_symtab): Update.
6559
6560 2019-05-08  Tom Tromey  <tom@tromey.com>
6561
6562         * registry.h (DECLARE_REGISTRY): Define the _key class.
6563
6564 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6565
6566         * NEWS: Merge two 'New commands' sections.
6567
6568 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
6569
6570         * ada-valprint.c (ada_val_print_gnat_array): Remove language
6571         parameter and use Ada language definition instead.
6572         (ada_val_print_ptr): Remove unused language parameter.
6573         (ada_val_print_num): Remove language parameter and use Ada language
6574         definition instead.
6575         (ada_val_print_enum, ada_val_print_flt): Remove unused language
6576         parameter.
6577         (ada_val_print_struct_union, ada_val_print_ref): Remove language
6578         parameter and use Ada language definition instead.
6579         (ada_val_print_1): Update all ada_val_print_xxx calls.
6580         Remove language parameter.
6581         (ada_val_print): Update ada_val_print_1 call.
6582
6583 2019-05-08  Tom Tromey  <tromey@adacore.com>
6584
6585         * remote.c (remote_hw_watchpoint_limit)
6586         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
6587         Now static.
6588
6589 2019-05-08  Tom Tromey  <tromey@adacore.com>
6590
6591         * maint.c (_initialize_maint_cmds): Move initialization code to
6592         remote.c.
6593         (watchdog, show_watchdog): Move to remote.c.
6594         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
6595         "watchdog" static.
6596         (_initialize_remote): Move initialization code from maint.c.
6597         * defs.h (watchdog): Don't declare.
6598
6599 2019-05-08  Tom Tromey  <tromey@adacore.com>
6600
6601         * tui/tui-interp.c: Include main.h.
6602         * interps.c: Include main.h.
6603         * main.h (interpreter_p): Declare.
6604         * defs.h (interpreter_p): Don't declare.
6605
6606 2019-05-08  Tom Tromey  <tromey@adacore.com>
6607
6608         * dwarf2loc.c: Include dwarf2read.h.
6609         * defs.h (read_unsigned_leb128): Don't declare.
6610         * dwarf2read.h (read_unsigned_leb128): Declare.
6611
6612 2019-05-08  Tom Tromey  <tromey@adacore.com>
6613
6614         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
6615         method.
6616
6617 2019-05-08  Tom Tromey  <tromey@adacore.com>
6618
6619         * utils.c (fputs_maybe_filtered): Reset style after paging, even
6620         when no wrap column is set.
6621
6622 2019-05-08  Tom Tromey  <tromey@adacore.com>
6623
6624         * c-lang.c (c_get_string): Handle non-C-style arrays.
6625
6626 2019-05-08  Tom Tromey  <tromey@adacore.com>
6627
6628         * typeprint.c (print_offset_data::update): Print the bit offset,
6629         not the number of bits remaining.
6630
6631 2019-05-08  Tom Tromey  <tromey@adacore.com>
6632
6633         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
6634         padding at end of comment.
6635
6636 2019-05-08  Tom Tromey  <tromey@adacore.com>
6637
6638         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
6639         Compare main types.
6640
6641 2019-05-06  Tom Tromey  <tom@tromey.com>
6642
6643         * common/scoped_mmap.c: Include common-defs.h.
6644         * common/scoped_mmap.h: Don't include config.h.
6645
6646 2019-05-04  Tom Tromey  <tom@tromey.com>
6647
6648         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
6649         (struct aarch64_call_info): Add initializers.
6650         <si>: Now a std::vector.
6651         (pass_on_stack, aarch64_push_dummy_call): Update.
6652
6653 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
6654             Tom Tromey  <tom@tromey.com>
6655
6656         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
6657         (ppc_threads): Now a std::vector.  Now static.
6658         (hwdebug_find_thread_points_by_tid)
6659         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
6660         Update.
6661
6662 2019-05-04  Tom Tromey  <tom@tromey.com>
6663
6664         * arc-tdep.c (arc_tdesc_init): Return bool.
6665
6666 2019-05-04  Tom Tromey  <tom@tromey.com>
6667
6668         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
6669         Use gdb_assert_not_reached.
6670
6671 2019-05-04  Tom Tromey  <tom@tromey.com>
6672
6673         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
6674         "false".
6675
6676 2019-05-04  Tom Tromey  <tom@tromey.com>
6677
6678         * arc-tdep.c (arc_tdesc_init): Use bool.
6679
6680 2019-05-04  Tom Tromey  <tom@tromey.com>
6681
6682         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
6683
6684 2019-05-04  Tom Tromey  <tom@tromey.com>
6685
6686         * cli/cli-cmds.c (valid_command_p): Return bool.
6687
6688 2019-05-04  Tom Tromey  <tom@tromey.com>
6689
6690         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
6691         * command.h (valid_user_defined_cmd_name_p): Channge return type.
6692
6693 2019-05-04  Raul Tambre  <raul@tambre.ee>
6694
6695         * python/lib/gdb/prompt.py (_ExtendedPrompt)
6696         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
6697         operator for comparison.
6698
6699 2019-05-04  Tom Tromey  <tom@tromey.com>
6700
6701         * psymtab.c (psymbol_name_matches, match_partial_symbol)
6702         (lookup_partial_symbol, print_partial_symbols)
6703         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
6704         (psymbol_compare): Update.
6705         (add_psymbol_to_bcache): Clear the entire psymbol.
6706         (maintenance_check_psymtabs): Update.
6707         * psympriv.h (struct partial_symbol): Don't derive from
6708         general_symbol_info.
6709         <obj_section, unrelocated_address, address,
6710         set_unrelocated_address>: Update.
6711         <ginfo>: New member.
6712         * dwarf-index-write.c (write_psymbols, debug_names::insert)
6713         (debug_names::write_psymbols): Update.
6714
6715 2019-05-04  Tom de Vries  <tdevries@suse.de>
6716
6717         * contrib/cc-with-tweaks.sh: Support -n arg.
6718
6719 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6720
6721         * corelow.c (core_target::detach): Ensure frame cache and
6722         register caches are cleared.
6723         inferior.c (exit_inferior_1): Likewise.
6724
6725 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
6726             Tom Tromey  <tom@tromey.com>
6727
6728         * dictionary.c (collate_pending_symbols_by_language): Remove
6729         "struct" from foreach.
6730         * symtab.c (lookup_global_symbol_from_objfile)
6731         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
6732         foreach.
6733         * ser-tcp.c (net_open): Remove "struct" from foreach.
6734         * objfiles.c (objfile_relocate, objfile_rebase)
6735         (objfile_has_symbols): Remove "struct" from foreach.
6736         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
6737         from foreach.
6738         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
6739         foreach.
6740         * darwin-nat.c (thread_info_from_private_thread_info): Remove
6741         "struct" from foreach.
6742         * ada-lang.c (create_excep_cond_exprs)
6743         (ada_exception_catchpoint_cond_string): Remove "struct" from
6744         foreach.
6745
6746 2019-05-03  Tom Tromey  <tromey@adacore.com>
6747
6748         * ada-exp.y (convert_char_literal): Check suffix of each
6749         enumerator.
6750
6751 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
6752
6753         PR ada/21406:
6754         * ada-exp.y (yywrap): Don't define.
6755         * ada-lex.l (%option): Add noyywrap
6756         (yywrap): Remove.
6757
6758 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
6759
6760         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
6761         _WIN32_WINNT to the XP level, unless already defined to a higher
6762         level.
6763
6764         * unittests/parse-connection-spec-selftests.c:
6765         * ser-tcp.c:
6766         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
6767         override.
6768
6769         * symfile.c (find_separate_debug_file): Remove colon from the
6770         drive spec of DOS/Windows file names of the target, so that the
6771         file name produced from DEBUGDIR and the target's directory will
6772         be valid on DOS/Windows systems.
6773
6774 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
6775
6776         * rust-lang.c (val_print_struct): Handle printing structures
6777         containing strings.
6778
6779 2019-05-02  Tom Tromey  <tromey@adacore.com>
6780
6781         * valarith.c (_initialize_valarith): Remove.
6782
6783 2019-05-01  Tom Tromey  <tromey@adacore.com>
6784
6785         * ada-lang.c (ada_value_primitive_field): Treat more fields as
6786         bitfields.
6787
6788 2019-05-01  Tom Tromey  <tromey@adacore.com>
6789
6790         * ada-lang.c (ada_value_assign): Correctly compute starting offset
6791         for big-endian copies.
6792
6793 2019-04-30  Ali Tamur  <tamur@google.com>
6794         * gdb/dwarf2read.c (read_3_bytes): New declaration.
6795         (read_attribute_value): Added DW_FORM_strx1-4 cases.
6796         (read_3_bytes): New function.
6797
6798 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6799
6800         * windows-nat.c (main_thread_id): Delete.
6801         (handle_output_debug_string): Replace main_thread_id by
6802         current_event.dwThreadId.
6803         (fake_create_process): Likewise.
6804         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
6805         Do not set main_thread_id.
6806         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
6807         current_event.dwThreadId.
6808         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
6809
6810 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6811
6812         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
6813         Use current_event.dwThreadId instead of main_thread_id.
6814
6815 2019-04-30  Tom Tromey  <tromey@adacore.com>
6816
6817         * ada-lang.c (ada_lookup_simple_minsyms): New function.
6818         (create_excep_cond_exprs): Iterate over program spaces.
6819         (ada_exception_catchpoint_cond_string): Examine all minimal
6820         symbols for exception types.
6821
6822 2019-04-30  Tom Tromey  <tromey@adacore.com>
6823
6824         PR c++/24470:
6825         * dwarf2read.c (process_structure_scope): Handle case where type
6826         has template parameters but no symbol was created.
6827
6828 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6829             Chris January  <chris.january@arm.com>
6830
6831         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
6832         qualifier.
6833         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
6834
6835 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6836
6837         * f-typeprint.c (f_print_type): Update rules for printing
6838         whitespace.
6839         (f_type_print_varspec_suffix): Likewise.
6840
6841 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6842             Chris January  <chris.january@arm.com>
6843
6844         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
6845         function arguments.
6846
6847 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6848
6849         * f-lang.c (build_fortran_types): Change name of void type to
6850         lower case.
6851         * f-typeprint.c (f_type_print_base): Print the name of the void
6852         type, rather than a fixed string.
6853         * f-valprint.c (f_decorations): Use lower case void string.
6854
6855 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6856             Chris January  <chris.january@arm.com>
6857
6858         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
6859         types for Fortran.
6860
6861 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6862             Chris January  <chris.january@arm.com>
6863             David Lecomber  <david.lecomber@arm.com>
6864
6865         * f-exp.y (BINOP_INTRINSIC): New token.
6866         (exp): New parser rule handling BINOP_INTRINSIC.
6867         (f77_keywords): Add new builtin procedures.
6868         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
6869         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6870         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
6871         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6872         (print_unop_subexp_f): New function.
6873         (print_binop_subexp_f): New function.
6874         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6875         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6876         (dump_subexp_body_f): Likewise.
6877         (operator_check_f): Likewise.
6878         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6879         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
6880
6881 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6882
6883         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
6884         UNOP_KIND.
6885         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
6886         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
6887         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
6888         (operator_length_f): New fuction.
6889         (print_subexp_f): New function.
6890         (op_name_f): New function.
6891         (dump_subexp_body_f): New function.
6892         (operator_check_f): New function.
6893         (exp_descriptor_f): Replace standard expression handling functions
6894         with new functions.
6895         * gdb/fortran-operator.def: New file.
6896         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
6897         * gdb/std-operator.def: Remove UNOP_KIND.
6898
6899 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6900
6901         * std-operator.def: Remove unbalanced, stray double quote
6902         character.
6903
6904 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6905             Chris January  <chris.january@arm.com>
6906             Daniel Everett  <daniel.everett@arm.com>
6907             Nick Forrington  <nick.forrington@arm.com>
6908             Richard Bunt  <richard.bunt@arm.com>
6909
6910         * cp-valprint.c (cp_print_value_fields): Allow an additional level
6911         of depth when printing anonymous structs or unions.
6912         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
6913         Don't print either the top-level value, or the children if the
6914         max-depth is exceeded.
6915         (ppscm_print_children): When printing the key of a map, allow one
6916         extra level of depth.
6917         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
6918         print either the top-level value, or the children if the max-depth
6919         is exceeded.
6920         (print_children): When printing the key of a map, allow one extra
6921         level of depth.
6922         * python/py-value.c (valpy_format_string): Add max_depth keyword.
6923         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
6924         (user_print_options): Initialise max_depth field.
6925         (val_print_scalar_or_string_type_p): New function.
6926         (val_print): Check to see if the max depth has been reached.
6927         (val_print_check_max_depth): Define new function.
6928         (show_print_max_depth): New function.
6929         (_initialize_valprint): Add 'print max-depth' option.
6930         * valprint.h (struct value_print_options) <max_depth>: New field.
6931         (val_print_check_max_depth): Declare new function.
6932         * NEWS: Document new feature.
6933
6934 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6935
6936         * ada-lang.c (ada_language_defn): Initialise new field.
6937         * c-lang.c (c_is_string_type_p): New function.
6938         (c_language_defn): Initialise new field.
6939         (cplus_language_defn): Initialise new field.
6940         (asm_language_defn): Initialise new field.
6941         (minimal_language_defn): Initialise new field.
6942         * c-lang.h (c_is_string_type_p): Declare new function.
6943         * d-lang.c (d_language_defn): Initialise new field.
6944         * f-lang.c (f_is_string_type_p): New function.
6945         (f_language_defn): Initialise new field.
6946         * go-lang.c (go_is_string_type_p): New function.
6947         (go_language_defn): Initialise new field.
6948         * language.c (default_is_string_type_p): New function.
6949         (unknown_language_defn): Initialise new field.
6950         (auto_language_defn): Initialise new field.
6951         * language.h (struct language_defn) <la_is_string_type_p>: New
6952         member variable.
6953         (default_is_string_type_p): Declare new function.
6954         * m2-lang.c (m2_language_defn): Initialise new field.
6955         * objc-lang.c (objc_language_defn): Initialise new field.
6956         * opencl-lang.c (opencl_language_defn): Initialise new field.
6957         * p-lang.c (pascal_is_string_type_p): New function.
6958         (pascal_language_defn): Initialise new field.
6959         * rust-lang.c (rust_is_string_type_p): New function.
6960         (rust_language_defn): Initialise new field.
6961
6962 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6963
6964         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
6965         New field.
6966         * ada-lang.c (ada_language_defn): Initialise new field.
6967         * c-lang.c (c_language_defn): Likewise.
6968         (cplus_language_defn): Likewise.
6969         (asm_language_defn): Likewise.
6970         (minimal_language_defn): Likewise.
6971         * d-lang.c (d_language_defn): Likewise.
6972         * f-lang.c (f_language_defn): Likewise.
6973         * go-lang.c (go_language_defn): Likewise.
6974         * language.c (unknown_language_defn): Likewise.
6975         (auto_language_defn): Likewise.
6976         * m2-lang.c (m2_language_defn): Likewise.
6977         * objc-lang.c (objc_language_defn): Likewise.
6978         * opencl-lang.c (opencl_language_defn): Likewise.
6979         * p-lang.c (pascal_language_defn): Likewise.
6980         * rust-lang.c (rust_language_defn): Likewise.
6981
6982 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6983
6984         * ada-lang.c (ada_is_character_type): Change return type to bool.
6985         (ada_is_string_type): Likewise.
6986         * ada-lang.h (ada_is_character_type): Update declaration
6987         (ada_is_string_type): Likewise.
6988
6989 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6990
6991         Support style in 'frame|thread apply'
6992
6993         * gdbcmd.h (execute_command_to_string): New term_out parameter.
6994         * record.c (record_start, record_stop): Update callers of
6995         execute_command_to_string with false.
6996         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
6997         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
6998         methods.
6999         (class string_file): New constructor with term_out parameter.
7000         Override methods term_out and can_emit_style_escape.  New member
7001         term_out.
7002         (class stdio_file): Override can_emit_style_escape.
7003         (class tee_file): Override term_out and can_emit_style_escape.
7004         * utils.h (can_emit_style_escape): Remove.
7005         * utils.c (can_emit_style_escape): Likewise.
7006         Update all callers of can_emit_style_escape (SOMESTREAM) to
7007         SOMESTREAM->can_emit_style_escape.
7008         * source-cache.c (source_cache::get_source_lines): Likewise.
7009         * stack.c (frame_apply_command_count): Call execute_command_to_string
7010         passing the term_out characteristic of the current gdb_stdout.
7011         * thread.c (thr_try_catch_cmd): Likewise.
7012         * top.c (execute_command_to_string): pass term_out parameter
7013         to construct the string_file for the command output.
7014         * ui-file.c (term_cli_styling): New function (most code moved
7015         from utils.c can_emit_style_escape).
7016         (string_file::string_file, string_file::can_emit_style_escape,
7017         stdio_file::can_emit_style_escape, tee_file::term_out,
7018         tee_file::can_emit_style_escape): New functions.
7019
7020 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7021
7022         * NEWS: Mention the new set|show may-call-functions.
7023         * infcall.c (may_call_functions_p): New variable.
7024         (show_may_call_functions_p): New function.
7025         (call_function_by_hand_dummy): Throws an error if not
7026         may-call-functions.
7027         (_initialize_infcall): Call add_setshow_boolean_cmd for
7028         may-call-functions.
7029
7030 2019-04-25  Keith Seitz  <keiths@redhat.com>
7031
7032         PR c++/24367
7033         * cp-support.c (inspect_type): Don't attempt substitutions
7034         of symbol with the same name.
7035
7036 2019-04-25  Tom Tromey  <tromey@adacore.com>
7037
7038         PR gdb/24475:
7039         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
7040         static.
7041
7042 2019-04-25  Tom Tromey  <tromey@adacore.com>
7043
7044         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
7045         rvalue reference.
7046         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
7047         (gdb_xml_parser::parse): Use std::move.
7048         * python/python-internal.h (gdbpy_convert_exception): Take a const
7049         reference.
7050         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
7051         std::move.
7052         * python/py-utils.c (gdbpy_convert_exception): Take a const
7053         reference.
7054         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7055         Use std::move.
7056         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7057         Use std::move.
7058         * mi/mi-main.c (mi_print_exception): Take a const reference.
7059         * main.c (handle_command_errors): Take a const reference.
7060         * linespec.c (parse_linespec): Use std::move.
7061         * infcall.c (run_inferior_call): Use std::move.
7062         (call_function_by_hand_dummy): Use std::move.
7063         * exec.c (try_open_exec_file): Use std::move.
7064         * exceptions.h (exception_print, exception_fprintf)
7065         (exception_print_same): Update.
7066         * exceptions.c (print_exception, exception_print)
7067         (exception_fprintf, exception_print_same): Change parameters to
7068         const reference.
7069         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
7070         * common/new-op.c: Use std::move.
7071         * common/common-exceptions.h (struct gdb_exception): Add move
7072         constructor.
7073         (struct gdb_exception_error, struct gdb_exception_quit, struct
7074         gdb_quit_bad_alloc): Change constructor to move constructor.
7075         (throw_exception): Change parameter to rvalue reference.
7076         * common/common-exceptions.c (throw_exception): Take rvalue
7077         reference.
7078         * cli/cli-interp.c (safe_execute_command): Use std::move.
7079         * breakpoint.c (insert_bp_location, location_to_sals): Use
7080         std::move.
7081
7082 2019-04-25  Tom Tromey  <tromey@adacore.com>
7083
7084         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
7085         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
7086         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
7087         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
7088         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
7089         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
7090         guile/scm-value.c: Use unpack.
7091         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
7092         gdbscm_gdb_exception.
7093         (gdbscm_throw_gdb_exception): Likewise.
7094         (struct gdbscm_gdb_exception): New.
7095         (unpack): New function.
7096         (gdbscm_wrap): Use unpack.
7097
7098 2019-04-25  Tom Tromey  <tromey@adacore.com>
7099
7100         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7101         (gdb_rl_callback_handler): Use std::move.
7102         * common/common-exceptions.h (struct gdb_exception): Add move
7103         assignment operator.
7104         (throw_exception_sjlj): Change "exception" to const reference.
7105         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
7106         (throw_exception_sjlj): Change "exception" to const reference.
7107
7108 2019-04-25  Tom Tromey  <tromey@adacore.com>
7109
7110         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
7111         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
7112         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7113         Update.
7114         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7115         Update.
7116         * mi/mi-interp.c (mi_interp::exec): Update.
7117         * linespec.c (parse_linespec): Update.
7118         * infcall.c (run_inferior_call): Update.
7119         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
7120         * guile/scm-symbol.c (gdbscm_lookup_symbol)
7121         (gdbscm_lookup_global_symbol): Update.
7122         * guile/scm-param.c (gdbscm_parameter_value): Update.
7123         * guile/scm-frame.c (gdbscm_frame_read_register)
7124         (gdbscm_frame_read_var): Update.
7125         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
7126         * exec.c (try_open_exec_file): Update.
7127         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7128         (gdb_rl_callback_handler): Update.
7129         * common/common-exceptions.h (exception_none): Don't declare.
7130         * common/common-exceptions.c (exception_none): Don't define.
7131         (struct catcher) <exception>: Update.
7132         * cli/cli-interp.c (safe_execute_command): Update.
7133         * breakpoint.c (insert_bp_location, location_to_sals): Update.
7134
7135 2019-04-25  Ali Tamur  <tamur@google.com>
7136
7137         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
7138         (read_attribute_value): Likewise.
7139         (dwarf2_read_addr_index): Update comment.
7140         (read_str_index): Add DW_FORM_strx.
7141         (dwarf2_string_attr): Likewise.
7142         (dwarf2_const_value_attr): Likewise.
7143         (dump_die_shallow): Likewise.
7144         (dwarf2_fetch_constant_bytes): Likewise.
7145         (skip_form_bytes): Likewise.
7146         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
7147
7148 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
7149
7150         PR corefiles/11608
7151         PR corefiles/18187
7152         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
7153         OFFSET.  Verify if current mapping contains an ELF header.
7154         (linux_find_memory_regions_full): Adjust call to
7155         dump_mapping_p.
7156
7157 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
7158             Kang Li <kanglictf@gmail.com>
7159
7160         PR gdb/21600
7161
7162         * dwarf2-frame.c (read_initial_length): Be consistent about using
7163         unsigned representation of length.
7164         (decode_frame_entry_1): Likewise.  Check for wraparound of
7165         end pointer as well as buffer overflow.
7166
7167 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
7168
7169         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
7170         "vq".
7171
7172 2019-04-24  Tom Tromey  <tromey@adacore.com>
7173
7174         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
7175
7176 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7177
7178         * s12z-tdep.c (s12z_unwind_pc): Delete.
7179         (s12z_unwind_sp): Delete.
7180         (s12z_gdbarch_init): Don't register deleted functions with
7181         gdbarch.
7182
7183 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7184
7185         * rl78-tdep.c (rl78_unwind_sp): Delete.
7186         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
7187
7188 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7189
7190         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
7191         (xstormy16_unwind_pc): Delete.
7192         (xstormy16_dummy_id): Delete.
7193         (xstormy16_gdbarch_init): Don't register deleted functions with
7194         gdbarch.
7195
7196 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7197
7198         * vax-tdep.c (vax_unwind_pc): Delete.
7199         (vax_gdbarch_init): Don't register deleted function with gdbarch.
7200
7201 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7202
7203         * v850-tdep.c (v850_unwind_sp): Delete.
7204         (v850_unwind_pc): Delete.
7205         (v850_dummy_id): Delete.
7206         (v850_gdbarch_init): Don't register deleted functions with
7207         gdbarch.
7208
7209 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7210
7211         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
7212         (tilegx_unwind_pc): Delete.
7213         (tilegx_unwind_dummy_id): Delete.
7214         (tilegx_gdbarch_init): Don't register deleted functions with
7215         gdbarch.
7216
7217 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7218
7219         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
7220         (tic6x_dummy_id): Delete.
7221         (tic6x_gdbarch_init): Don't register deleted functions with
7222         gdbarch.
7223
7224 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7225
7226         * sparc-tdep.c (sparc_unwind_pc): Delete.
7227         (sparc32_gdbarch_init): Don't register deleted function with
7228         gdbarch.
7229
7230 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7231
7232         * sh-tdep.c (sh_unwind_sp): Delete.
7233         (sh_unwind_pc): Delete.
7234         (sh_dummy_id): Delete.
7235         (sh_gdbarch_init): Don't register deleted functions with
7236         gdbarch.
7237
7238 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7239
7240         * score-tdep.c (score_unwind_sp): Delete.
7241         (score_unwind_pc): Delete.
7242         (score_dummy_id): Delete.
7243         (score_gdbarch_init): Don't register deleted functions with
7244         gdbarch.
7245
7246 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7247
7248         * rx-tdep.c (rx_unwind_pc): Delete.
7249         (rx_unwind_sp): Delete.
7250         (rx_dummy_id): Delete.
7251         (rx_gdbarch_init): Don't register deleted functions with
7252         gdbarch.  Update comment.
7253
7254 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7255
7256         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
7257         (rs6000_dummy_id): Delete.
7258         (rs6000_gdbarch_init): Don't register deleted functions with
7259         gdbarch.
7260
7261 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7262
7263         * or1k-tdep.c (or1k_dummy_id): Delete.
7264         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
7265
7266 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7267
7268         * nios2-tdep.c (nios2_dummy_id): Delete.
7269         (nios2_unwind_sp): Delete.
7270         (nios2_gdbarch_init): Don't register deleted functions with
7271         gdbarch.
7272
7273 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7274
7275         * nds32-tdep.c (nds32_dummy_id): Delete.
7276         (nds32_unwind_pc): Delete.
7277         (nds32_unwind_sp): Delete.
7278         (nds32_gdbarch_init): Don't register deleted functions with
7279         gdbarch.
7280
7281 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7282
7283         * msp430-tdep.c (msp430_unwind_pc): Delete.
7284         (msp430_unwind_sp): Delete.
7285         (msp430_dummy_id): Delete.
7286         (msp430_gdbarch_init): Don't register deleted functions with
7287         gdbarch.
7288
7289 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7290
7291         * moxie-tdep.c (moxie_unwind_sp): Delete.
7292         (moxie_unwind_pc): Delete.
7293         (moxie_dummy_id): Delete.
7294         (moxie_gdbarch_init): Don't register deleted functions with
7295         gdbarch.
7296
7297 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7298
7299         * mn10300-tdep.c (mn10300_dummy_id): Delete.
7300         (mn10300_unwind_pc): Delete.
7301         (mn10300_unwind_sp): Delete.
7302         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
7303         mn10300_unwind_sp.
7304         (mn10300_frame_unwind_init): Don't register deleted functions with
7305         gdbarch.
7306
7307 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7308
7309         * mep-tdep.c (mep_unwind_pc): Delete.
7310         (mep_unwind_sp): Delete.
7311         (mep_dummy_id): Delete.
7312         (mep_gdbarch_init): Don't register deleted functions with
7313         gdbarch.
7314
7315 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7316
7317         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
7318         (m68hc11_unwind_sp): Delete.
7319         (m68hc11_gdbarch_init): Don't register deleted functions with
7320         gdbarch.
7321
7322 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7323
7324         * m32r-tdep.c (m32r_unwind_sp): Delete.
7325         (m32r_unwind_pc): Delete.
7326         (m32r_dummy_id): Delete.
7327         (m32r_gdbarch_init): Don't register deleted functions with
7328         gdbarch.
7329
7330 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7331
7332         * m32c-tdep.c (m32c_unwind_pc): Delete.
7333         (m32c_unwind_sp): Delete.
7334         (m32c_dummy_id): Delete.
7335         (m32c_gdbarch_init): Don't register deleted functions with
7336         gdbarch.
7337
7338 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7339
7340         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
7341         (lm32_unwind_pc): Delete.
7342         (lm32_dummy_id): Delete.
7343         (lm32_gdbarch_init): Don't register deleted functions with
7344         gdbarch.
7345
7346 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7347
7348         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
7349         (iq2000_unwind_pc): Delete.
7350         (iq2000_dummy_id): Delete.
7351         (iq2000_gdbarch_init): Don't register deleted functions with
7352         gdbarch.
7353
7354 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7355
7356         * nds32-tdep.c (nds32_type_align): Delete.
7357         (nds32_push_dummy_call): Use type_align instead.
7358
7359 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7360
7361         * arm-tdep.c (arm_type_align): Only handle vector override case.
7362         (arm_push_dummy_call): Use type_align.
7363         (arm_gdbarch_init): Register arm_type_align gdbarch function.
7364
7365 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7366
7367         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
7368         case.
7369         (pass_on_stack): Use type_align.
7370         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
7371         function.
7372
7373 2019-04-23  Tom Tromey  <tromey@adacore.com>
7374
7375         * dwarf2read.c (line_header::file_name_at): Remove unused
7376         overload.
7377
7378 2019-04-23  Tom de Vries  <tdevries@suse.de>
7379
7380         PR gdb/24438
7381         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
7382         invocation.
7383
7384
7385 2019-03-27  Ali Tamur  <tamur@google.com>
7386
7387         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
7388         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
7389         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
7390         (dwarf_expr_context::get_addr_index): Likewise
7391         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
7392         (symbol_needs_eval_context::get_addr_index): Likewise
7393         (disassemble_dwarf_expression): Add DW_OP_addrx
7394         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
7395         (read_cutu_die_from_dwo): Update comment
7396         (skip_one_die): Add DW_FORM_addrx
7397         (read_attribute_value): Likewise
7398         (var_decode_location): Add DW_OP_addrx
7399         (dwarf2_const_value_attr): Add DW_FORM_addrx
7400         (dump_die_shallow): Likewise
7401         (dwarf2_fetch_constant_bytes): Likewise
7402         (decode_locdesc): Add DW_OP_addrx
7403         (skip_form_bytes): Add DW_FORM_addrx
7404
7405 2019-04-22  Ali Tamur  <tamur@google.com>
7406
7407         * MAINTAINERS (Write After Approval): Add self.
7408
7409 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
7410
7411         * solib-svr4.c (get_svr4_info): Add pspace parameter.
7412         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
7413         (open_symbol_file_object): Likewise.
7414         (svr4_default_sos): Add info parameter.
7415         (svr4_read_so_list): Likewise.
7416         (svr4_current_sos_direct): Adjust functions calls to pass down
7417         info.
7418         (svr4_current_sos_1): Add info parameter.
7419         (svr4_current_sos): Call get_svr4_info, pass info down to
7420         svr4_current_sos_1.
7421         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
7422         get_svr4_info.
7423         (svr4_in_dynsym_resolve_code): Pass current_program_space to
7424         get_svr4_info.
7425         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
7426         to get_svr4_info.
7427         (probes_table_remove_objfile_probes): Likewise.
7428         (register_solib_event_probe): Add info parameter.
7429         (solist_update_incremental): Pass info parameter down to
7430         svr4_read_so_list.
7431         (disable_probes_interface): Add info parameter.
7432         (svr4_handle_solib_event): Pass current_program_space to
7433         get_svr4_info.  Adjust disable_probes_interface cleanup.
7434         (svr4_create_probe_breakpoints): Add info parameter, pass it
7435         down to register_solib_event_probe.
7436         (svr4_create_solib_event_breakpoints): Add info parameter,
7437         pass it down to svr4_create_probe_breakpoints.
7438         (enable_break): Pass info down to
7439         svr4_create_solib_event_breakpoints.
7440         (svr4_solib_create_inferior_hook): Pass current_program_space to
7441         get_svr4_info.
7442         (svr4_clear_solib): Likewise.
7443
7444 2019-04-22  Pedro Alves  <palves@redhat.com>
7445
7446         * solib-svr4.c (svr4_free_objfile_observer): New.
7447         (probe_and_action::objfile): New field.
7448         (probes_table_htab_remove_objfile_probes)
7449         (probes_table_remove_objfile_probes): New functions.
7450         (register_solib_event_probe): Add 'objfile' parameter.  Store it
7451         in the new probe_and_action.  Don't store the probe in 'lookup'.
7452         (svr4_create_probe_breakpoints): Pass objfile to
7453         register_solib_event_probe.
7454         (_initialize_svr4_solib): Register a free_objfile observer.
7455
7456 2019-04-19  Tom Tromey  <tom@tromey.com>
7457
7458         * common/queue.h: Remove.
7459
7460 2019-04-19  Tom Tromey  <tom@tromey.com>
7461
7462         * event-loop.c: Don't include "common/queue.h".
7463
7464 2019-04-19  Tom Tromey  <tom@tromey.com>
7465
7466         * remote.c (remote_target): Use delete.
7467         * remote-notif.h: Include <list>, not "common/queue.h".
7468         (notif_client_p): Remove typedef.
7469         (remote_notif_state): Add constructor, destructor, initializer.
7470         <notif_queue>: Now a std::list.
7471         (remote_notif_state_xfree): Don't declare.
7472         * remote-notif.c (remote_notif_process, handle_notification)
7473         (remote_notif_state_allocate): Update.
7474         (~remote_notif_state): Rename from remote_notif_state_xfree.
7475
7476 2019-04-19  Tom Tromey  <tom@tromey.com>
7477
7478         * symfile.c (reread_symbols): Update.
7479         * objfiles.c (objfile_register_static_link)
7480         (objfile_lookup_static_link): Update
7481         (~objfile) Don't delete static_links.
7482         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
7483
7484 2019-04-19  Tom Tromey  <tom@tromey.com>
7485
7486         * type-stack.h (struct type_stack) <insert>: Constify string.
7487         * type-stack.c (type_stack::insert): Constify string.
7488         * gdbtypes.h (lookup_template_type): Update.
7489         (address_space_name_to_int): Update.
7490         * gdbtypes.c (address_space_name_to_int): Make space_identifier
7491         const.
7492         (lookup_template_type): Make name const.
7493         * c-exp.y: Update rules.
7494         (lex_one_token, classify_name, classify_inner_name)
7495         (c_print_token): Update.
7496         * p-exp.y: Update rules.
7497         (yylex): Update.
7498         * f-exp.y: Update rules.
7499         (yylex): Update.
7500         * d-exp.y: Update rules.
7501         (lex_one_token, classify_name, classify_inner_name): Update.
7502         * parse.c (write_dollar_variable, copy_name): Return std::string.
7503         * parser-defs.h (copy_name): Change return type.
7504         * m2-exp.y: Update rules.
7505         (yylex): Update.
7506         * go-exp.y (lex_one_token): Update.
7507         Update rules.
7508         (classify_unsafe_function, classify_packaged_name)
7509         (classify_name, yylex): Update.
7510
7511 2019-04-19  Sergei Trofimovich <siarheit@google.com>
7512
7513         * configure.ac: add --enable-source-highlight switch.
7514         * configure: Regenerate.
7515         * top.c (print_gdb_version): plumb --enable-source-highlight
7516         status to "show configuration".
7517
7518 2019-04-19  Tom Tromey  <tromey@adacore.com>
7519
7520         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
7521         Check ADA_TYPE_P.
7522         (empty_record, ada_template_to_fixed_record_type_1)
7523         (template_to_static_fixed_type)
7524         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
7525         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
7526         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
7527         macros.
7528
7529 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
7530
7531         PR symtab/24423:
7532         * source.c (print_source_lines_base): Advance "iter" when a
7533         control character is seen.
7534
7535 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7536
7537         * inferior.h (struct infcall_suspend_state_deleter):
7538         Catch exception in destructor to avoid crash.
7539
7540 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7541
7542         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
7543         close to the add_com "shell".
7544
7545 2019-04-18  Tom Tromey  <tromey@adacore.com>
7546
7547         * process-stratum-target.h (class process_stratum_target)
7548         <stratum>: Add "final".
7549
7550 2019-04-17  Tom Tromey  <tromey@adacore.com>
7551
7552         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
7553         against nullptr before use.
7554
7555 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
7556
7557         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
7558
7559 2019-04-17  Jim Wilson  <jimw@sifive.com>
7560             Andrew Burgess  <andrew.burgess@embecosm.com>
7561
7562         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
7563         code read might fail, assume 4-byte breakpoint in that case.
7564
7565 2019-04-15  Leszek Swirski  <leszeks@google.com>
7566
7567         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
7568         rather than a hand-rolled POD check when checking for forced MEMORY
7569         classification.
7570
7571 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7572
7573         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
7574         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
7575         function.
7576         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
7577         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
7578         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
7579         declaration.
7580
7581 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7582
7583         * aarch64-linux-nat.c
7584         (aarch64_linux_nat_target::thread_architecture): Add override.
7585         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
7586         each VQ.
7587
7588 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7589
7590         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
7591
7592 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
7593
7594         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
7595         target types of size 96-bits, add some additional comments, and
7596         check that the builtin type we found was the correct size.
7597
7598 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
7599
7600         * utils.c (prompt_for_continue): Don't restore the styling at the
7601         end, as applied_style has the wrong value.  This fixes styling in
7602         long lists of file names that are interrupted by the "Continue?"
7603         prompt.
7604
7605 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7606
7607         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
7608         * c-lang.c (c_language_defn): Likewise.
7609         (cplus_language_defn): Likewise.
7610         (asm_language_defn): Likewise.
7611         (minimal_language_defn): Likewise.
7612         * d-lang.c (d_language_defn): Likewise.
7613         * f-lang.c (f_language_defn): Likewise.
7614         * go-lang.c (go_language_defn): Likewise.
7615         * language.c (unknown_language_defn): Likewise.
7616         (auto_language_defn): Likewise.
7617         * language.h (struct language_defn): Remove la_magic field.
7618         (LANG_MAGIC): Delete.
7619         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
7620         * objc-lang.c (objc_language_defn): Likewise.
7621         * opencl-lang.c (opencl_language_defn): Likewise.
7622         * p-lang.c (pascal_language_defn): Likewise.
7623         * rust-lang.c (rust_language_defn): Likewise.
7624
7625 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7626
7627         * riscv-tdep.c (riscv_type_align): New function.
7628         (riscv_type_alignment): Delete.
7629         (riscv_arg_location): Use 'type_align'.
7630         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
7631
7632 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7633
7634         * gdbtypes.c (type_align): A struct with no non-static fields also
7635         has alignment of 1.
7636
7637 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7638
7639         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
7640         component to 0.
7641         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
7642         member.
7643         (riscv_struct_info::analyse): New implementation using new
7644         analyse_inner member function.
7645         (riscv_struct_info::field_offset): New member function.
7646         (riscv_struct_info::m_offsets): New member variable.
7647         (riscv_struct_info::analyse_inner): New private member function,
7648         takes the old implementation of riscv_struct_info::analyse but
7649         extended to track field offsets.
7650         (riscv_call_arg_struct): Update the struct folding special cases
7651         to handle cases where empty C++ structs, which are non-zero
7652         length, are found.
7653         (riscv_arg_location): Initialise the length of each location, a
7654         non-zero length now indicates the location is in use.
7655         (riscv_push_dummy_call): Allow for the first location having a
7656         non-zero offset when setting up arguments.
7657         (riscv_return_value): Likewise, but for return values.
7658
7659 2019-04-11  Tom Tromey  <tromey@adacore.com>
7660
7661         * utils.c (internal_vproblem): Make "msg" const.
7662
7663 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
7664
7665         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
7666         * trad-frame.c (trad_frame_reset_saved_regs): New function.
7667         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
7668         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
7669
7670 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
7671
7672         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
7673         function.
7674         (fill_gregset): Call amd64_linux_collect_native_gregset instead
7675         of amd64_collect_native_gregset.
7676         (amd64_linux_nat_target::store_registers): Likewise.
7677
7678 2019-04-10  Tom Tromey  <tom@tromey.com>
7679
7680         * symtab.c (lookup_global_symbol_from_objfile)
7681         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
7682         * objfiles.h (class separate_debug_iterator): New.
7683         (class separate_debug_range): New.
7684         (struct objfile) <separate_debug_objfiles>: New method.
7685         (objfile_separate_debug_iterate): Don't declare.
7686         * objfiles.c (separate_debug_iterator::operator++): Rename from
7687         objfile_separate_debug_iterate.
7688         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
7689         iterator.
7690         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
7691         iterator.
7692
7693 2019-04-10  Tom Tromey  <tom@tromey.com>
7694
7695         * symfile.c (reread_symbols): Remove old comment.
7696         * objfiles.c (free_all_objfiles): Fix a typo.
7697
7698 2019-04-10  Tom Tromey  <tom@tromey.com>
7699
7700         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
7701         * minsyms.c (lookup_minimal_symbol): Use foreach.
7702         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
7703         (lookup_minimal_symbol_solib_trampoline): Likewise.
7704         * symfile.c (reread_symbols): Use foreach.
7705
7706 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
7707             Tom Tromey  <tromey@adacore.com>
7708
7709         PR rust/24414:
7710         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
7711         (rust_lex_int_test): Change "value" to be LONGEST.
7712         (rust_lex_tests): Add test for long integer literal.
7713
7714 2019-04-09  Tom Tromey  <tromey@adacore.com>
7715
7716         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
7717         to bool.
7718         (extended_remote_target::attach): Update.
7719         (remote_target::remote_notice_new_inferior): Update.
7720         (remote_target::add_current_inferior_and_thread): Update.
7721         * inferior.c (exit_inferior_1): Use "false".
7722         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
7723
7724 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
7725
7726         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
7727         the "start" command.
7728
7729 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7730
7731         * python/py-inferior.c (infpy_thread_from_thread_handle):
7732         Adjust comments to reflect renaming of thread_from_thread_handle
7733         to thread_from_handle.  Adjust keywords.  Fix type error message.
7734         (inferior_object_methods): Add thread_from_handle.  Retain
7735         thread_from_thread_handle, but mark it as deprecated.
7736
7737 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7738
7739         * gdbthread.h (find_thread_by_handle): Revise declaration.
7740         * thread.c (find_thread_by_handle): Likewise.  Adjust
7741         implementation too.
7742         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
7743         support for buffer objects as handles.
7744
7745 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7746
7747         * python/py-infthread.c (thpy_thread_handle): New function.
7748         (thread_object_methods): Register thpy_thread_handle.
7749
7750 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7751
7752         * gdbthread.h (thread_to_thread_handle): Declare.
7753         * thread.c (gdbtypes.h): Include.
7754         (thread_to_thread_handle): New function.
7755
7756         * target.h (struct target_ops): Add thread_info_to_thread_handle.
7757         (target_thread_info_to_thread_handle): Declare.
7758         * target.c (target_thread_info_to_thread_handle): New function.
7759         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
7760         * target-delegates.c: Regenerate.
7761
7762         * linux-thread-db.c (class thread_db_target): Add method
7763         thread_info_to_thread_handle.
7764         (thread_db_target::thread_info_to_thread_handle): Define.
7765         * remote.c (class remote_target): Add new method
7766         thread_info_to_thread_handle.
7767         (remote_target::thread_info_to_thread_handle): Define.
7768
7769 2019-04-08  Pedro Alves  <palves@redhat.com>
7770
7771         * common/common-exceptions.c (throw_exception): Don't create
7772         named object to throw; throw directly.
7773         (throw_it): Likewise.  Don't initialize gdb_exception::message
7774         here, with new; pass FMT and AP to the ctor instead.
7775         * common/common-exceptions.h: Include <string>.
7776         (gdb_exception::gdb_exception(enum return_reason, enum errors,
7777         const char *, va_list)): New ctor.  Use std::make_shared.
7778         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
7779         errors)): Delete.
7780         (gdb_exception_error::gdb_exception_error(enum errors, const char
7781         *, va_list)): New.
7782         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
7783         Add assertion.
7784         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
7785         errors)): Delete.
7786         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
7787         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
7788         Add assertion.
7789
7790 2019-04-08  Tom Tromey  <tom@tromey.com>
7791
7792         * valops.c (value_rtti_indirect_type): Replace throw_exception
7793         with throw.
7794         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
7795         with throw.
7796         * thread.c (thr_try_catch_cmd): Replace throw_exception with
7797         throw.
7798         * target.c (target_translate_tls_address): Replace throw_exception
7799         with throw.
7800         * stack.c (frame_apply_command_count): Replace throw_exception
7801         with throw.
7802         * solib-spu.c (append_ocl_sos): Replace throw_exception with
7803         throw.
7804         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
7805         with throw.
7806         * rs6000-tdep.c (rs6000_frame_cache)
7807         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
7808         * remote.c: Replace throw_exception with throw.
7809         * record-full.c (record_full_message, record_full_wait_1)
7810         (record_full_restore): Replace throw_exception with throw.
7811         * record-btrace.c:
7812         (get_thread_current_frame_id, record_btrace_start_replaying)
7813         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
7814         (cmd_record_btrace_start): Replace throw_exception with throw.
7815         * parse.c (parse_exp_in_context_1): Replace throw_exception with
7816         throw.
7817         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
7818         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
7819         * linespec.c:
7820         (find_linespec_symbols): Replace throw_exception with throw.
7821         * infrun.c (displaced_step_prepare, resume): Replace
7822         throw_exception with throw.
7823         * infcmd.c (post_create_inferior): Replace throw_exception with
7824         throw.
7825         * inf-loop.c (inferior_event_handler): Replace throw_exception
7826         with throw.
7827         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
7828         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
7829         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
7830         (get_prev_frame_always, get_frame_pc_if_available)
7831         (get_frame_address_in_block_if_available, get_frame_language):
7832         Replace throw_exception with throw.
7833         * frame-unwind.c (frame_unwind_try_unwinder): Replace
7834         throw_exception with throw.
7835         * eval.c (fetch_subexp_value, evaluate_var_value)
7836         (evaluate_funcall, evaluate_subexp_standard): Replace
7837         throw_exception with throw.
7838         * dwarf2loc.c (call_site_find_chain)
7839         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
7840         Replace throw_exception with throw.
7841         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
7842         with throw.
7843         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
7844         throw.
7845         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
7846         * completer.c (complete_line_internal): Replace throw_exception
7847         with throw.
7848         * compile/compile-object-run.c (compile_object_run): Replace
7849         throw_exception with throw.
7850         * cli/cli-script.c (process_next_line): Replace throw_exception
7851         with throw.
7852         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
7853         (btrace_enable, btrace_maint_update_pt_packets): Replace
7854         throw_exception with throw.
7855         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
7856         throw_exception with throw.
7857         * break-catch-throw.c (re_set_exception_catchpoint): Replace
7858         throw_exception with throw.
7859         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
7860         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
7861         * aarch64-tdep.c (aarch64_make_prologue_cache)
7862         (aarch64_make_stub_cache): Replace throw_exception with throw.
7863
7864 2019-04-08  Tom Tromey  <tom@tromey.com>
7865
7866         * common/common-exceptions.c (throw_exception): Rename from
7867         throw_exception_cxx.  Remove old copy.  Make argument const.
7868         (throw_it): Create and throw exception objects directly.
7869         * common/common-exceptions.h (throw_exception): Make argument
7870         const.
7871         (struct gdb_exception_error): Add constructor.
7872         (struct gdb_exception_quit): Add constructor.
7873
7874 2019-04-08  Tom Tromey  <tom@tromey.com>
7875
7876         * common/common-exceptions.h (exception_rethrow): Don't declare.
7877         (TRY_SJLJ): Update comment.
7878         (TRY, CATCH, END_CATCH): Remove.
7879         * common/common-exceptions.c (exception_rethrow): Remove.
7880
7881 2019-04-08  Tom Tromey  <tom@tromey.com>
7882
7883         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
7884         Remove.
7885         (gdb_exception_error): Rename from
7886         gdb_exception_RETURN_MASK_ERROR.
7887         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
7888         (gdb_quit_bad_alloc): Update.
7889         * aarch64-tdep.c: Update.
7890         * ada-lang.c: Update.
7891         * ada-typeprint.c: Update.
7892         * ada-valprint.c: Update.
7893         * amd64-tdep.c: Update.
7894         * arch-utils.c: Update.
7895         * break-catch-throw.c: Update.
7896         * breakpoint.c: Update.
7897         * btrace.c: Update.
7898         * c-varobj.c: Update.
7899         * cli/cli-cmds.c: Update.
7900         * cli/cli-interp.c: Update.
7901         * cli/cli-script.c: Update.
7902         * common/common-exceptions.c: Update.
7903         * common/new-op.c: Update.
7904         * common/selftest.c: Update.
7905         * compile/compile-c-symbols.c: Update.
7906         * compile/compile-cplus-symbols.c: Update.
7907         * compile/compile-object-load.c: Update.
7908         * compile/compile-object-run.c: Update.
7909         * completer.c: Update.
7910         * corelow.c: Update.
7911         * cp-abi.c: Update.
7912         * cp-support.c: Update.
7913         * cp-valprint.c: Update.
7914         * darwin-nat.c: Update.
7915         * disasm-selftests.c: Update.
7916         * dtrace-probe.c: Update.
7917         * dwarf-index-cache.c: Update.
7918         * dwarf-index-write.c: Update.
7919         * dwarf2-frame-tailcall.c: Update.
7920         * dwarf2-frame.c: Update.
7921         * dwarf2loc.c: Update.
7922         * dwarf2read.c: Update.
7923         * eval.c: Update.
7924         * event-loop.c: Update.
7925         * event-top.c: Update.
7926         * exec.c: Update.
7927         * f-valprint.c: Update.
7928         * fbsd-tdep.c: Update.
7929         * frame-unwind.c: Update.
7930         * frame.c: Update.
7931         * gdbtypes.c: Update.
7932         * gnu-v3-abi.c: Update.
7933         * guile/guile-internal.h: Update.
7934         * guile/scm-block.c: Update.
7935         * guile/scm-breakpoint.c: Update.
7936         * guile/scm-cmd.c: Update.
7937         * guile/scm-disasm.c: Update.
7938         * guile/scm-frame.c: Update.
7939         * guile/scm-lazy-string.c: Update.
7940         * guile/scm-math.c: Update.
7941         * guile/scm-param.c: Update.
7942         * guile/scm-ports.c: Update.
7943         * guile/scm-pretty-print.c: Update.
7944         * guile/scm-symbol.c: Update.
7945         * guile/scm-symtab.c: Update.
7946         * guile/scm-type.c: Update.
7947         * guile/scm-value.c: Update.
7948         * i386-linux-tdep.c: Update.
7949         * i386-tdep.c: Update.
7950         * inf-loop.c: Update.
7951         * infcall.c: Update.
7952         * infcmd.c: Update.
7953         * infrun.c: Update.
7954         * jit.c: Update.
7955         * language.c: Update.
7956         * linespec.c: Update.
7957         * linux-fork.c: Update.
7958         * linux-nat.c: Update.
7959         * linux-tdep.c: Update.
7960         * linux-thread-db.c: Update.
7961         * main.c: Update.
7962         * mi/mi-cmd-break.c: Update.
7963         * mi/mi-cmd-stack.c: Update.
7964         * mi/mi-interp.c: Update.
7965         * mi/mi-main.c: Update.
7966         * objc-lang.c: Update.
7967         * p-valprint.c: Update.
7968         * parse.c: Update.
7969         * ppc-linux-tdep.c: Update.
7970         * printcmd.c: Update.
7971         * python/py-arch.c: Update.
7972         * python/py-breakpoint.c: Update.
7973         * python/py-cmd.c: Update.
7974         * python/py-finishbreakpoint.c: Update.
7975         * python/py-frame.c: Update.
7976         * python/py-framefilter.c: Update.
7977         * python/py-gdb-readline.c: Update.
7978         * python/py-inferior.c: Update.
7979         * python/py-infthread.c: Update.
7980         * python/py-lazy-string.c: Update.
7981         * python/py-linetable.c: Update.
7982         * python/py-objfile.c: Update.
7983         * python/py-param.c: Update.
7984         * python/py-prettyprint.c: Update.
7985         * python/py-progspace.c: Update.
7986         * python/py-record-btrace.c: Update.
7987         * python/py-record.c: Update.
7988         * python/py-symbol.c: Update.
7989         * python/py-type.c: Update.
7990         * python/py-unwind.c: Update.
7991         * python/py-utils.c: Update.
7992         * python/py-value.c: Update.
7993         * python/python.c: Update.
7994         * record-btrace.c: Update.
7995         * record-full.c: Update.
7996         * remote-fileio.c: Update.
7997         * remote.c: Update.
7998         * riscv-tdep.c: Update.
7999         * rs6000-aix-tdep.c: Update.
8000         * rs6000-tdep.c: Update.
8001         * rust-exp.y: Update.
8002         * rust-lang.c: Update.
8003         * s390-tdep.c: Update.
8004         * selftest-arch.c: Update.
8005         * solib-dsbt.c: Update.
8006         * solib-frv.c: Update.
8007         * solib-spu.c: Update.
8008         * solib-svr4.c: Update.
8009         * solib.c: Update.
8010         * sparc64-linux-tdep.c: Update.
8011         * stack.c: Update.
8012         * symfile-mem.c: Update.
8013         * symmisc.c: Update.
8014         * target.c: Update.
8015         * thread.c: Update.
8016         * top.c: Update.
8017         * tracefile-tfile.c: Update.
8018         * tui/tui.c: Update.
8019         * typeprint.c: Update.
8020         * unittests/cli-utils-selftests.c: Update.
8021         * unittests/parse-connection-spec-selftests.c: Update.
8022         * valops.c: Update.
8023         * valprint.c: Update.
8024         * value.c: Update.
8025         * varobj.c: Update.
8026         * windows-nat.c: Update.
8027         * x86-linux-nat.c: Update.
8028         * xml-support.c: Update.
8029
8030 2019-04-08  Tom Tromey  <tom@tromey.com>
8031
8032         * xml-support.c: Use C++ exception handling.
8033         * x86-linux-nat.c: Use C++ exception handling.
8034         * windows-nat.c: Use C++ exception handling.
8035         * varobj.c: Use C++ exception handling.
8036         * value.c: Use C++ exception handling.
8037         * valprint.c: Use C++ exception handling.
8038         * valops.c: Use C++ exception handling.
8039         * unittests/parse-connection-spec-selftests.c: Use C++ exception
8040         handling.
8041         * unittests/cli-utils-selftests.c: Use C++ exception handling.
8042         * typeprint.c: Use C++ exception handling.
8043         * tui/tui.c: Use C++ exception handling.
8044         * tracefile-tfile.c: Use C++ exception handling.
8045         * top.c: Use C++ exception handling.
8046         * thread.c: Use C++ exception handling.
8047         * target.c: Use C++ exception handling.
8048         * symmisc.c: Use C++ exception handling.
8049         * symfile-mem.c: Use C++ exception handling.
8050         * stack.c: Use C++ exception handling.
8051         * sparc64-linux-tdep.c: Use C++ exception handling.
8052         * solib.c: Use C++ exception handling.
8053         * solib-svr4.c: Use C++ exception handling.
8054         * solib-spu.c: Use C++ exception handling.
8055         * solib-frv.c: Use C++ exception handling.
8056         * solib-dsbt.c: Use C++ exception handling.
8057         * selftest-arch.c: Use C++ exception handling.
8058         * s390-tdep.c: Use C++ exception handling.
8059         * rust-lang.c: Use C++ exception handling.
8060         * rust-exp.y: Use C++ exception handling.
8061         * rs6000-tdep.c: Use C++ exception handling.
8062         * rs6000-aix-tdep.c: Use C++ exception handling.
8063         * riscv-tdep.c: Use C++ exception handling.
8064         * remote.c: Use C++ exception handling.
8065         * remote-fileio.c: Use C++ exception handling.
8066         * record-full.c: Use C++ exception handling.
8067         * record-btrace.c: Use C++ exception handling.
8068         * python/python.c: Use C++ exception handling.
8069         * python/py-value.c: Use C++ exception handling.
8070         * python/py-utils.c: Use C++ exception handling.
8071         * python/py-unwind.c: Use C++ exception handling.
8072         * python/py-type.c: Use C++ exception handling.
8073         * python/py-symbol.c: Use C++ exception handling.
8074         * python/py-record.c: Use C++ exception handling.
8075         * python/py-record-btrace.c: Use C++ exception handling.
8076         * python/py-progspace.c: Use C++ exception handling.
8077         * python/py-prettyprint.c: Use C++ exception handling.
8078         * python/py-param.c: Use C++ exception handling.
8079         * python/py-objfile.c: Use C++ exception handling.
8080         * python/py-linetable.c: Use C++ exception handling.
8081         * python/py-lazy-string.c: Use C++ exception handling.
8082         * python/py-infthread.c: Use C++ exception handling.
8083         * python/py-inferior.c: Use C++ exception handling.
8084         * python/py-gdb-readline.c: Use C++ exception handling.
8085         * python/py-framefilter.c: Use C++ exception handling.
8086         * python/py-frame.c: Use C++ exception handling.
8087         * python/py-finishbreakpoint.c: Use C++ exception handling.
8088         * python/py-cmd.c: Use C++ exception handling.
8089         * python/py-breakpoint.c: Use C++ exception handling.
8090         * python/py-arch.c: Use C++ exception handling.
8091         * printcmd.c: Use C++ exception handling.
8092         * ppc-linux-tdep.c: Use C++ exception handling.
8093         * parse.c: Use C++ exception handling.
8094         * p-valprint.c: Use C++ exception handling.
8095         * objc-lang.c: Use C++ exception handling.
8096         * mi/mi-main.c: Use C++ exception handling.
8097         * mi/mi-interp.c: Use C++ exception handling.
8098         * mi/mi-cmd-stack.c: Use C++ exception handling.
8099         * mi/mi-cmd-break.c: Use C++ exception handling.
8100         * main.c: Use C++ exception handling.
8101         * linux-thread-db.c: Use C++ exception handling.
8102         * linux-tdep.c: Use C++ exception handling.
8103         * linux-nat.c: Use C++ exception handling.
8104         * linux-fork.c: Use C++ exception handling.
8105         * linespec.c: Use C++ exception handling.
8106         * language.c: Use C++ exception handling.
8107         * jit.c: Use C++ exception handling.
8108         * infrun.c: Use C++ exception handling.
8109         * infcmd.c: Use C++ exception handling.
8110         * infcall.c: Use C++ exception handling.
8111         * inf-loop.c: Use C++ exception handling.
8112         * i386-tdep.c: Use C++ exception handling.
8113         * i386-linux-tdep.c: Use C++ exception handling.
8114         * guile/scm-value.c: Use C++ exception handling.
8115         * guile/scm-type.c: Use C++ exception handling.
8116         * guile/scm-symtab.c: Use C++ exception handling.
8117         * guile/scm-symbol.c: Use C++ exception handling.
8118         * guile/scm-pretty-print.c: Use C++ exception handling.
8119         * guile/scm-ports.c: Use C++ exception handling.
8120         * guile/scm-param.c: Use C++ exception handling.
8121         * guile/scm-math.c: Use C++ exception handling.
8122         * guile/scm-lazy-string.c: Use C++ exception handling.
8123         * guile/scm-frame.c: Use C++ exception handling.
8124         * guile/scm-disasm.c: Use C++ exception handling.
8125         * guile/scm-cmd.c: Use C++ exception handling.
8126         * guile/scm-breakpoint.c: Use C++ exception handling.
8127         * guile/scm-block.c: Use C++ exception handling.
8128         * guile/guile-internal.h: Use C++ exception handling.
8129         * gnu-v3-abi.c: Use C++ exception handling.
8130         * gdbtypes.c: Use C++ exception handling.
8131         * frame.c: Use C++ exception handling.
8132         * frame-unwind.c: Use C++ exception handling.
8133         * fbsd-tdep.c: Use C++ exception handling.
8134         * f-valprint.c: Use C++ exception handling.
8135         * exec.c: Use C++ exception handling.
8136         * event-top.c: Use C++ exception handling.
8137         * event-loop.c: Use C++ exception handling.
8138         * eval.c: Use C++ exception handling.
8139         * dwarf2read.c: Use C++ exception handling.
8140         * dwarf2loc.c: Use C++ exception handling.
8141         * dwarf2-frame.c: Use C++ exception handling.
8142         * dwarf2-frame-tailcall.c: Use C++ exception handling.
8143         * dwarf-index-write.c: Use C++ exception handling.
8144         * dwarf-index-cache.c: Use C++ exception handling.
8145         * dtrace-probe.c: Use C++ exception handling.
8146         * disasm-selftests.c: Use C++ exception handling.
8147         * darwin-nat.c: Use C++ exception handling.
8148         * cp-valprint.c: Use C++ exception handling.
8149         * cp-support.c: Use C++ exception handling.
8150         * cp-abi.c: Use C++ exception handling.
8151         * corelow.c: Use C++ exception handling.
8152         * completer.c: Use C++ exception handling.
8153         * compile/compile-object-run.c: Use C++ exception handling.
8154         * compile/compile-object-load.c: Use C++ exception handling.
8155         * compile/compile-cplus-symbols.c: Use C++ exception handling.
8156         * compile/compile-c-symbols.c: Use C++ exception handling.
8157         * common/selftest.c: Use C++ exception handling.
8158         * common/new-op.c: Use C++ exception handling.
8159         * cli/cli-script.c: Use C++ exception handling.
8160         * cli/cli-interp.c: Use C++ exception handling.
8161         * cli/cli-cmds.c: Use C++ exception handling.
8162         * c-varobj.c: Use C++ exception handling.
8163         * btrace.c: Use C++ exception handling.
8164         * breakpoint.c: Use C++ exception handling.
8165         * break-catch-throw.c: Use C++ exception handling.
8166         * arch-utils.c: Use C++ exception handling.
8167         * amd64-tdep.c: Use C++ exception handling.
8168         * ada-valprint.c: Use C++ exception handling.
8169         * ada-typeprint.c: Use C++ exception handling.
8170         * ada-lang.c: Use C++ exception handling.
8171         * aarch64-tdep.c: Use C++ exception handling.
8172
8173 2019-04-08  Tom Tromey  <tom@tromey.com>
8174
8175         * xml-support.c (gdb_xml_parser::parse): Update.
8176         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8177         * value.c (show_convenience): Update.
8178         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
8179         (test_parse_flags_qcs): Update.
8180         * thread.c (thr_try_catch_cmd): Update.
8181         * target.c (target_translate_tls_address): Update.
8182         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
8183         (info_frame_command_core, frame_apply_command_count): Update.
8184         * rust-exp.y (rust_lex_exception_test): Update.
8185         * riscv-tdep.c (riscv_print_one_register_info): Update.
8186         * remote.c (remote_target::enable_btrace): Update.
8187         * record-btrace.c (record_btrace_enable_warn): Update.
8188         * python/py-utils.c (gdbpy_convert_exception): Update.
8189         * printcmd.c (do_one_display, print_variable_and_value): Update.
8190         * mi/mi-main.c (mi_print_exception): Update.
8191         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
8192         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
8193         * linux-nat.c (linux_nat_target::attach): Update.
8194         * linux-fork.c (class scoped_switch_fork_info): Update.
8195         * infrun.c (displaced_step_prepare): Update.
8196         * infcall.c (call_function_by_hand_dummy): Update.
8197         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
8198         * gnu-v3-abi.c (print_one_vtable): Update.
8199         * frame.c (get_prev_frame_always): Update.
8200         * f-valprint.c (info_common_command_for_block): Update.
8201         * exec.c (try_open_exec_file): Update.
8202         * exceptions.c (print_exception, exception_print)
8203         (exception_fprintf, exception_print_same): Update.
8204         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
8205         * dwarf-index-cache.c (index_cache::store)
8206         (index_cache::lookup_gdb_index): Update.
8207         * darwin-nat.c (maybe_cache_shell): Update.
8208         * cp-valprint.c (cp_print_value_fields): Update.
8209         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
8210         (gcc_cplus_symbol_address): Update.
8211         * compile/compile-c-symbols.c (gcc_convert_symbol)
8212         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
8213         * common/selftest.c: Update.
8214         * common/common-exceptions.h (struct gdb_exception) <message>: Now
8215         a std::string.
8216         (exception_try_scope_entry, exception_try_scope_exit): Don't
8217         declare.
8218         (struct exception_try_scope): Remove.
8219         (TRY): Don't use exception_try_scope.
8220         (struct gdb_exception): Add constructor, operator=.
8221         <what>: New method.
8222         (struct gdb_exception_RETURN_MASK_ALL)
8223         (struct gdb_exception_RETURN_MASK_ERROR)
8224         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
8225         (struct gdb_quit_bad_alloc): Update.
8226         * common/common-exceptions.c (exception_none): Change
8227         initializer.
8228         (struct catcher) <state, exception>: Initialize inline.
8229         <prev>: Remove member.
8230         (current_catcher): Remove.
8231         (catchers): New global.
8232         (exceptions_state_mc_init): Simplify.
8233         (catcher_pop): Remove.
8234         (exceptions_state_mc, exceptions_state_mc_catch): Update.
8235         (try_scope_depth, exception_try_scope_entry)
8236         (exception_try_scope_exit): Remove.
8237         (throw_exception_sjlj): Update.
8238         (exception_messages, exception_messages_size): Remove.
8239         (throw_it): Simplify.
8240         (gdb_exception_sliced_copy): Remove.
8241         (throw_exception_cxx): Update.
8242         * cli/cli-script.c (script_from_file): Update.
8243         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
8244         Update.
8245         * ada-valprint.c (ada_val_print): Update.
8246         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
8247         (create_excep_cond_exprs): Update.
8248
8249 2019-04-08  Tom Tromey  <tom@tromey.com>
8250
8251         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
8252         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
8253         (TRY, CATCH, END_CATCH): Remove some definitions.
8254         * common/common-exceptions.c: Don't use GDB_XCPT.
8255         (catcher_list_size): Remove.
8256         (throw_exception, throw_it): Simplify.
8257
8258 2019-04-05  Tom Tromey  <tom@tromey.com>
8259
8260         Revert the header-sorting patch.
8261         * ft32-tdep.c: Revert.
8262         * frv-tdep.c: Revert.
8263         * frv-linux-tdep.c: Revert.
8264         * frame.c: Revert.
8265         * frame-unwind.c: Revert.
8266         * frame-base.c: Revert.
8267         * fork-child.c: Revert.
8268         * findvar.c: Revert.
8269         * findcmd.c: Revert.
8270         * filesystem.c: Revert.
8271         * filename-seen-cache.h: Revert.
8272         * filename-seen-cache.c: Revert.
8273         * fbsd-tdep.c: Revert.
8274         * fbsd-nat.h: Revert.
8275         * fbsd-nat.c: Revert.
8276         * f-valprint.c: Revert.
8277         * f-typeprint.c: Revert.
8278         * f-lang.c: Revert.
8279         * extension.h: Revert.
8280         * extension.c: Revert.
8281         * extension-priv.h: Revert.
8282         * expprint.c: Revert.
8283         * exec.h: Revert.
8284         * exec.c: Revert.
8285         * exceptions.c: Revert.
8286         * event-top.c: Revert.
8287         * event-loop.c: Revert.
8288         * eval.c: Revert.
8289         * elfread.c: Revert.
8290         * dwarf2read.h: Revert.
8291         * dwarf2read.c: Revert.
8292         * dwarf2loc.c: Revert.
8293         * dwarf2expr.h: Revert.
8294         * dwarf2expr.c: Revert.
8295         * dwarf2-frame.c: Revert.
8296         * dwarf2-frame-tailcall.c: Revert.
8297         * dwarf-index-write.h: Revert.
8298         * dwarf-index-write.c: Revert.
8299         * dwarf-index-common.c: Revert.
8300         * dwarf-index-cache.h: Revert.
8301         * dwarf-index-cache.c: Revert.
8302         * dummy-frame.c: Revert.
8303         * dtrace-probe.c: Revert.
8304         * disasm.h: Revert.
8305         * disasm.c: Revert.
8306         * disasm-selftests.c: Revert.
8307         * dictionary.c: Revert.
8308         * dicos-tdep.c: Revert.
8309         * demangle.c: Revert.
8310         * dcache.h: Revert.
8311         * dcache.c: Revert.
8312         * darwin-nat.h: Revert.
8313         * darwin-nat.c: Revert.
8314         * darwin-nat-info.c: Revert.
8315         * d-valprint.c: Revert.
8316         * d-namespace.c: Revert.
8317         * d-lang.c: Revert.
8318         * ctf.c: Revert.
8319         * csky-tdep.c: Revert.
8320         * csky-linux-tdep.c: Revert.
8321         * cris-tdep.c: Revert.
8322         * cris-linux-tdep.c: Revert.
8323         * cp-valprint.c: Revert.
8324         * cp-support.c: Revert.
8325         * cp-namespace.c: Revert.
8326         * cp-abi.c: Revert.
8327         * corelow.c: Revert.
8328         * corefile.c: Revert.
8329         * continuations.c: Revert.
8330         * completer.h: Revert.
8331         * completer.c: Revert.
8332         * complaints.c: Revert.
8333         * coffread.c: Revert.
8334         * coff-pe-read.c: Revert.
8335         * cli-out.h: Revert.
8336         * cli-out.c: Revert.
8337         * charset.c: Revert.
8338         * c-varobj.c: Revert.
8339         * c-valprint.c: Revert.
8340         * c-typeprint.c: Revert.
8341         * c-lang.c: Revert.
8342         * buildsym.c: Revert.
8343         * buildsym-legacy.c: Revert.
8344         * build-id.h: Revert.
8345         * build-id.c: Revert.
8346         * btrace.c: Revert.
8347         * bsd-uthread.c: Revert.
8348         * breakpoint.h: Revert.
8349         * breakpoint.c: Revert.
8350         * break-catch-throw.c: Revert.
8351         * break-catch-syscall.c: Revert.
8352         * break-catch-sig.c: Revert.
8353         * blockframe.c: Revert.
8354         * block.c: Revert.
8355         * bfin-tdep.c: Revert.
8356         * bfin-linux-tdep.c: Revert.
8357         * bfd-target.c: Revert.
8358         * bcache.c: Revert.
8359         * ax-general.c: Revert.
8360         * ax-gdb.h: Revert.
8361         * ax-gdb.c: Revert.
8362         * avr-tdep.c: Revert.
8363         * auxv.c: Revert.
8364         * auto-load.c: Revert.
8365         * arm-wince-tdep.c: Revert.
8366         * arm-tdep.c: Revert.
8367         * arm-symbian-tdep.c: Revert.
8368         * arm-pikeos-tdep.c: Revert.
8369         * arm-obsd-tdep.c: Revert.
8370         * arm-nbsd-tdep.c: Revert.
8371         * arm-nbsd-nat.c: Revert.
8372         * arm-linux-tdep.c: Revert.
8373         * arm-linux-nat.c: Revert.
8374         * arm-fbsd-tdep.c: Revert.
8375         * arm-fbsd-nat.c: Revert.
8376         * arm-bsd-tdep.c: Revert.
8377         * arch-utils.c: Revert.
8378         * arc-tdep.c: Revert.
8379         * arc-newlib-tdep.c: Revert.
8380         * annotate.h: Revert.
8381         * annotate.c: Revert.
8382         * amd64-windows-tdep.c: Revert.
8383         * amd64-windows-nat.c: Revert.
8384         * amd64-tdep.c: Revert.
8385         * amd64-sol2-tdep.c: Revert.
8386         * amd64-obsd-tdep.c: Revert.
8387         * amd64-obsd-nat.c: Revert.
8388         * amd64-nbsd-tdep.c: Revert.
8389         * amd64-nbsd-nat.c: Revert.
8390         * amd64-nat.c: Revert.
8391         * amd64-linux-tdep.c: Revert.
8392         * amd64-linux-nat.c: Revert.
8393         * amd64-fbsd-tdep.c: Revert.
8394         * amd64-fbsd-nat.c: Revert.
8395         * amd64-dicos-tdep.c: Revert.
8396         * amd64-darwin-tdep.c: Revert.
8397         * amd64-bsd-nat.c: Revert.
8398         * alpha-tdep.c: Revert.
8399         * alpha-obsd-tdep.c: Revert.
8400         * alpha-nbsd-tdep.c: Revert.
8401         * alpha-mdebug-tdep.c: Revert.
8402         * alpha-linux-tdep.c: Revert.
8403         * alpha-linux-nat.c: Revert.
8404         * alpha-bsd-tdep.c: Revert.
8405         * alpha-bsd-nat.c: Revert.
8406         * aix-thread.c: Revert.
8407         * agent.c: Revert.
8408         * addrmap.c: Revert.
8409         * ada-varobj.c: Revert.
8410         * ada-valprint.c: Revert.
8411         * ada-typeprint.c: Revert.
8412         * ada-tasks.c: Revert.
8413         * ada-lang.c: Revert.
8414         * aarch64-tdep.c: Revert.
8415         * aarch64-ravenscar-thread.c: Revert.
8416         * aarch64-newlib-tdep.c: Revert.
8417         * aarch64-linux-tdep.c: Revert.
8418         * aarch64-linux-nat.c: Revert.
8419         * aarch64-fbsd-tdep.c: Revert.
8420         * aarch64-fbsd-nat.c: Revert.
8421         * aarch32-linux-nat.c: Revert.
8422
8423 2019-04-05  Tom Tromey  <tom@tromey.com>
8424
8425         * ft32-tdep.c: Sort headers.
8426         * frv-tdep.c: Sort headers.
8427         * frv-linux-tdep.c: Sort headers.
8428         * frame.c: Sort headers.
8429         * frame-unwind.c: Sort headers.
8430         * frame-base.c: Sort headers.
8431         * fork-child.c: Sort headers.
8432         * findvar.c: Sort headers.
8433         * findcmd.c: Sort headers.
8434         * filesystem.c: Sort headers.
8435         * filename-seen-cache.h: Sort headers.
8436         * filename-seen-cache.c: Sort headers.
8437         * fbsd-tdep.c: Sort headers.
8438         * fbsd-nat.h: Sort headers.
8439         * fbsd-nat.c: Sort headers.
8440         * f-valprint.c: Sort headers.
8441         * f-typeprint.c: Sort headers.
8442         * f-lang.c: Sort headers.
8443         * extension.h: Sort headers.
8444         * extension.c: Sort headers.
8445         * extension-priv.h: Sort headers.
8446         * expprint.c: Sort headers.
8447         * exec.h: Sort headers.
8448         * exec.c: Sort headers.
8449         * exceptions.c: Sort headers.
8450         * event-top.c: Sort headers.
8451         * event-loop.c: Sort headers.
8452         * eval.c: Sort headers.
8453         * elfread.c: Sort headers.
8454         * dwarf2read.h: Sort headers.
8455         * dwarf2read.c: Sort headers.
8456         * dwarf2loc.c: Sort headers.
8457         * dwarf2expr.h: Sort headers.
8458         * dwarf2expr.c: Sort headers.
8459         * dwarf2-frame.c: Sort headers.
8460         * dwarf2-frame-tailcall.c: Sort headers.
8461         * dwarf-index-write.h: Sort headers.
8462         * dwarf-index-write.c: Sort headers.
8463         * dwarf-index-common.c: Sort headers.
8464         * dwarf-index-cache.h: Sort headers.
8465         * dwarf-index-cache.c: Sort headers.
8466         * dummy-frame.c: Sort headers.
8467         * dtrace-probe.c: Sort headers.
8468         * disasm.h: Sort headers.
8469         * disasm.c: Sort headers.
8470         * disasm-selftests.c: Sort headers.
8471         * dictionary.c: Sort headers.
8472         * dicos-tdep.c: Sort headers.
8473         * demangle.c: Sort headers.
8474         * dcache.h: Sort headers.
8475         * dcache.c: Sort headers.
8476         * darwin-nat.h: Sort headers.
8477         * darwin-nat.c: Sort headers.
8478         * darwin-nat-info.c: Sort headers.
8479         * d-valprint.c: Sort headers.
8480         * d-namespace.c: Sort headers.
8481         * d-lang.c: Sort headers.
8482         * ctf.c: Sort headers.
8483         * csky-tdep.c: Sort headers.
8484         * csky-linux-tdep.c: Sort headers.
8485         * cris-tdep.c: Sort headers.
8486         * cris-linux-tdep.c: Sort headers.
8487         * cp-valprint.c: Sort headers.
8488         * cp-support.c: Sort headers.
8489         * cp-namespace.c: Sort headers.
8490         * cp-abi.c: Sort headers.
8491         * corelow.c: Sort headers.
8492         * corefile.c: Sort headers.
8493         * continuations.c: Sort headers.
8494         * completer.h: Sort headers.
8495         * completer.c: Sort headers.
8496         * complaints.c: Sort headers.
8497         * coffread.c: Sort headers.
8498         * coff-pe-read.c: Sort headers.
8499         * cli-out.h: Sort headers.
8500         * cli-out.c: Sort headers.
8501         * charset.c: Sort headers.
8502         * c-varobj.c: Sort headers.
8503         * c-valprint.c: Sort headers.
8504         * c-typeprint.c: Sort headers.
8505         * c-lang.c: Sort headers.
8506         * buildsym.c: Sort headers.
8507         * buildsym-legacy.c: Sort headers.
8508         * build-id.h: Sort headers.
8509         * build-id.c: Sort headers.
8510         * btrace.c: Sort headers.
8511         * bsd-uthread.c: Sort headers.
8512         * breakpoint.h: Sort headers.
8513         * breakpoint.c: Sort headers.
8514         * break-catch-throw.c: Sort headers.
8515         * break-catch-syscall.c: Sort headers.
8516         * break-catch-sig.c: Sort headers.
8517         * blockframe.c: Sort headers.
8518         * block.c: Sort headers.
8519         * bfin-tdep.c: Sort headers.
8520         * bfin-linux-tdep.c: Sort headers.
8521         * bfd-target.c: Sort headers.
8522         * bcache.c: Sort headers.
8523         * ax-general.c: Sort headers.
8524         * ax-gdb.h: Sort headers.
8525         * ax-gdb.c: Sort headers.
8526         * avr-tdep.c: Sort headers.
8527         * auxv.c: Sort headers.
8528         * auto-load.c: Sort headers.
8529         * arm-wince-tdep.c: Sort headers.
8530         * arm-tdep.c: Sort headers.
8531         * arm-symbian-tdep.c: Sort headers.
8532         * arm-pikeos-tdep.c: Sort headers.
8533         * arm-obsd-tdep.c: Sort headers.
8534         * arm-nbsd-tdep.c: Sort headers.
8535         * arm-nbsd-nat.c: Sort headers.
8536         * arm-linux-tdep.c: Sort headers.
8537         * arm-linux-nat.c: Sort headers.
8538         * arm-fbsd-tdep.c: Sort headers.
8539         * arm-fbsd-nat.c: Sort headers.
8540         * arm-bsd-tdep.c: Sort headers.
8541         * arch-utils.c: Sort headers.
8542         * arc-tdep.c: Sort headers.
8543         * arc-newlib-tdep.c: Sort headers.
8544         * annotate.h: Sort headers.
8545         * annotate.c: Sort headers.
8546         * amd64-windows-tdep.c: Sort headers.
8547         * amd64-windows-nat.c: Sort headers.
8548         * amd64-tdep.c: Sort headers.
8549         * amd64-sol2-tdep.c: Sort headers.
8550         * amd64-obsd-tdep.c: Sort headers.
8551         * amd64-obsd-nat.c: Sort headers.
8552         * amd64-nbsd-tdep.c: Sort headers.
8553         * amd64-nbsd-nat.c: Sort headers.
8554         * amd64-nat.c: Sort headers.
8555         * amd64-linux-tdep.c: Sort headers.
8556         * amd64-linux-nat.c: Sort headers.
8557         * amd64-fbsd-tdep.c: Sort headers.
8558         * amd64-fbsd-nat.c: Sort headers.
8559         * amd64-dicos-tdep.c: Sort headers.
8560         * amd64-darwin-tdep.c: Sort headers.
8561         * amd64-bsd-nat.c: Sort headers.
8562         * alpha-tdep.c: Sort headers.
8563         * alpha-obsd-tdep.c: Sort headers.
8564         * alpha-nbsd-tdep.c: Sort headers.
8565         * alpha-mdebug-tdep.c: Sort headers.
8566         * alpha-linux-tdep.c: Sort headers.
8567         * alpha-linux-nat.c: Sort headers.
8568         * alpha-bsd-tdep.c: Sort headers.
8569         * alpha-bsd-nat.c: Sort headers.
8570         * aix-thread.c: Sort headers.
8571         * agent.c: Sort headers.
8572         * addrmap.c: Sort headers.
8573         * ada-varobj.c: Sort headers.
8574         * ada-valprint.c: Sort headers.
8575         * ada-typeprint.c: Sort headers.
8576         * ada-tasks.c: Sort headers.
8577         * ada-lang.c: Sort headers.
8578         * aarch64-tdep.c: Sort headers.
8579         * aarch64-ravenscar-thread.c: Sort headers.
8580         * aarch64-newlib-tdep.c: Sort headers.
8581         * aarch64-linux-tdep.c: Sort headers.
8582         * aarch64-linux-nat.c: Sort headers.
8583         * aarch64-fbsd-tdep.c: Sort headers.
8584         * aarch64-fbsd-nat.c: Sort headers.
8585         * aarch32-linux-nat.c: Sort headers.
8586
8587 2019-04-04  Tom Tromey  <tom@tromey.com>
8588
8589         * varobj.c (varobj_create): Update.
8590         * rust-exp.y (struct rust_parser) <update_innermost_block,
8591         lookup_symbol>: New methods.
8592         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
8593         Rename.
8594         (rust_parser::rust_lookup_type)
8595         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8596         * printcmd.c (display_command, do_one_display): Update.
8597         * parser-defs.h (struct parser_state) <parser_state>: Add
8598         "tracker" parameter.
8599         (block_tracker): New member.
8600         (class innermost_block_tracker) <innermost_block_tracker>: Add
8601         "types" parameter.
8602         <reset>: Remove method.
8603         (innermost_block): Don't declare.
8604         (null_post_parser): Update.
8605         * parse.c (innermost_block): Remove global.
8606         (write_dollar_variable): Update.
8607         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
8608         Remove "tracker_types" parameter.
8609         (parse_expression): Add "tracker" parameter.
8610         (parse_expression_for_completion): Update.
8611         (null_post_parser): Add "tracker" parameter.
8612         * p-exp.y: Update rules.
8613         * m2-exp.y: Update rules.
8614         * language.h (struct language_defn) <la_post_parser>: Add
8615         "tracker" parameter.
8616         * go-exp.y: Update rules.
8617         * f-exp.y: Update rules.
8618         * expression.h (parse_expression, parse_exp_1): Add "tracker"
8619         parameter.
8620         * d-exp.y: Update rules.
8621         * c-exp.y: Update rules.
8622         * breakpoint.c (set_breakpoint_condition): Create an
8623         innermost_block_tracker.
8624         (watch_command_1): Likewise.
8625         * ada-lang.c (resolve): Add "tracker" parameter.
8626         (resolve_subexp): Likewise.
8627         * ada-exp.y (write_var_from_sym): Update.
8628
8629 2019-04-04  Tom Tromey  <tom@tromey.com>
8630
8631         * type-stack.h: New file.
8632         * type-stack.c: New file.
8633         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
8634         type-stack.h.
8635         (insert_into_type_stack, insert_type, push_type, push_type_int)
8636         (insert_type_address_space, pop_type, pop_type_int)
8637         (pop_typelist, pop_type_stack, append_type_stack)
8638         (push_type_stack, get_type_stack, push_typelist)
8639         (follow_type_instance_flags, follow_types): Don't declare.
8640         * parse.c (type_stack): Remove global.
8641         (parse_exp_in_context): Update.
8642         (insert_into_type_stack, insert_type, push_type, push_type_int)
8643         (insert_type_address_space, pop_type, pop_type_int)
8644         (pop_typelist, pop_type_stack, append_type_stack)
8645         (push_type_stack, get_type_stack, push_typelist)
8646         (follow_type_instance_flags, follow_types): Remove (moved to
8647         type-stack.c).
8648         * f-exp.y (type_stack): New global.
8649         Update rules.
8650         (push_kind_type, f_parse): Update.
8651         * d-exp.y (type_stack): New global.
8652         Update rules.
8653         (d_parse): Update.
8654         * c-exp.y (struct c_parse_state) <type_stack>: New member.
8655         Update rules.
8656         * Makefile.in (COMMON_SFILES): Add type-stack.c.
8657         (HFILES_NO_SRCDIR): Add type-stack.h.
8658
8659 2019-04-04  Tom Tromey  <tom@tromey.com>
8660
8661         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
8662         (rust_parser::convert_ast_to_expression, rust_parse)
8663         (rust_lex_test_completion, rust_lex_tests): Update.
8664         * parser-defs.h (struct expr_completion_state): New.
8665         (struct parser_state) <parser_state>: Add completion parameter.
8666         <mark_struct_expression, mark_completion_tag>: New methods.
8667         <parse_completion, m_completion_state>: New members.
8668         (prefixify_expression, null_post_parser): Update.
8669         (mark_struct_expression, mark_completion_tag): Don't declare.
8670         * parse.c (parse_completion, expout_last_struct)
8671         (expout_tag_completion_type, expout_completion_name): Remove
8672         globals.
8673         (parser_state::mark_struct_expression)
8674         (parser_state::mark_completion_tag): Now methods.
8675         (prefixify_expression): Add last_struct parameter.
8676         (prefixify_subexp): Likewise.
8677         (parse_exp_1): Update.
8678         (parse_exp_in_context): Add cstate parameter.  Update.
8679         (parse_expression_for_completion): Create an
8680         expr_completion_state.
8681         (null_post_parser): Add "completion" parameter.
8682         * p-exp.y: Update rules.
8683         (yylex): Update.
8684         * language.h (struct language_defn) <la_post_parser>: Add
8685         "completing" parameter.
8686         * go-exp.y: Update rules.
8687         (lex_one_token): Update.
8688         * expression.h (parse_completion): Don't declare.
8689         * d-exp.y: Update rules.
8690         (lex_one_token): Update rules.
8691         * c-exp.y: Update rules.
8692         (lex_one_token): Update.
8693         * ada-lang.c (resolve): Add "parse_completion" parameter.
8694         (resolve_subexp): Likewise.
8695         (ada_resolve_function): Likewise.
8696
8697 2019-04-04  Tom Tromey  <tom@tromey.com>
8698
8699         * parser-defs.h (struct parser_state) <start_arglist,
8700         end_arglist>: New methods.
8701         <arglist_len, m_funcall_chain>: New members.
8702         (arglist_len, start_arglist, end_arglist): Don't declare.
8703         * parse.c (arglist_len, funcall_chain): Remove global.
8704         (start_arglist, end_arglist): Remove functions.
8705         (parse_exp_in_context): Update.
8706         * p-exp.y: Update rules.
8707         * m2-exp.y: Update rules.
8708         * go-exp.y: Update rules.
8709         * f-exp.y: Update rules.
8710         * d-exp.y: Update rules.
8711         * c-exp.y: Update rules.
8712
8713 2019-04-04  Tom Tromey  <tom@tromey.com>
8714
8715         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
8716         lex_operator, push_back>: New methods.
8717         Update all rules.
8718         (rust_parser::lex_hex, lex_escape): Rename and update.
8719         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
8720         (rust_parser::lex_operator): Rename and update.
8721         (rust_parser::lex_number, rustyylex, rustyyerror)
8722         (rust_lex_test_init, rust_lex_test_sequence)
8723         (rust_lex_test_push_back, rust_lex_tests): Update.
8724         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
8725         parameter.
8726         <lexptr, prev_lexptr>: New members.
8727         (lexptr, prev_lexptr): Don't declare.
8728         * parse.c (lexptr, prev_lexptr): Remove globals.
8729         (parse_exp_in_context): Update.
8730         * p-exp.y (yylex, yyerror): Update.
8731         * m2-exp.y (parse_number, yylex, yyerror): Update.
8732         * go-exp.y (lex_one_token, yyerror): Update.
8733         * f-exp.y (match_string_literal, yylex, yyerror): Update.
8734         * d-exp.y (lex_one_token, yyerror): Update.
8735         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
8736         (lex_one_token, yyerror): Update.
8737         * ada-lex.l (YY_INPUT): Update.
8738         (rewind_to_char): Update.
8739         * ada-exp.y (yyerror): Update.
8740
8741 2019-04-04  Tom Tromey  <tom@tromey.com>
8742
8743         * rust-exp.y (rustyylex, rust_lex_tests): Update.
8744         * parser-defs.h (struct parser_state) <parser_state>: Add new
8745         parameter.
8746         <comma_terminates>: New member.
8747         (comma_terminates): Don't declare global.
8748         * parse.c (comma_terminates): Remove global.
8749         (parse_exp_in_context): Update.
8750         * p-exp.y (yylex): Update.
8751         * m2-exp.y (yylex): Update.
8752         * go-exp.y (lex_one_token): Update.
8753         * f-exp.y (yylex): Update.
8754         * d-exp.y (lex_one_token): Update.
8755         * c-exp.y (lex_one_token): Update.
8756         * ada-lex.l: Update.
8757
8758 2019-04-04  Tom Tromey  <tom@tromey.com>
8759
8760         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
8761         (rustyylex, rust_lex_test_init, rust_lex_test_one)
8762         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
8763         * parser-defs.h (paren_depth): Don't declare.
8764         * parse.c (paren_depth): Remove global.
8765         (parse_exp_in_context): Update.
8766         * p-exp.y (paren_depth): New global.
8767         (pascal_parse): Initialize it.
8768         * m2-exp.y (paren_depth): New global.
8769         (m2_parse): Initialize it.
8770         * go-exp.y (paren_depth): New global.
8771         (go_parse): Initialize it.
8772         * f-exp.y (paren_depth): New global.
8773         (f_parse): Initialize it.
8774         * d-exp.y (paren_depth): New global.
8775         (d_parse): Initialize it.
8776         * c-exp.y (paren_depth): New global.
8777         (c_parse): Initialize it.
8778         * ada-lex.l (paren_depth): New global.
8779         (lexer_init): Initialize it.
8780
8781 2019-04-04  Tom Tromey  <tom@tromey.com>
8782
8783         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
8784         (rust_parser::convert_ast_to_type)
8785         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8786         * parser-defs.h (struct parser_state) <parser_state>: Add
8787         parameters.  Initialize new members.
8788         <expression_context_block, expression_context_pc>: New members.
8789         * parse.c (expression_context_block, expression_context_pc):
8790         Remove globals.
8791         (parse_exp_in_context): Update.
8792         * p-exp.y: Update all rules.
8793         (yylex): Update.
8794         * m2-exp.y: Update all rules.
8795         (yylex): Update.
8796         * go-exp.y (yylex): Update.
8797         * f-exp.y (yylex): Update.
8798         * d-exp.y: Update all rules.
8799         (yylex): Update.
8800         * c-exp.y: Update all rules.
8801         (lex_one_token, classify_name, yylex, c_parse): Update.
8802         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
8803
8804 2019-04-04  Tom Tromey  <tom@tromey.com>
8805
8806         * gdbarch.h, gdbarch.c: Rebuild.
8807         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
8808         * stap-probe.h:
8809         (struct stap_parse_info): Replace "parser_state" with
8810         "expr_builder".
8811         * parser-defs.h (struct expr_builder): Rename from "parser_state".
8812         (parser_state): New class.
8813         * parse.c (expr_builder): Rename.
8814         (expr_builder::release): Rename.
8815         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
8816         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
8817         (write_exp_elt_longcst, write_exp_elt_floatcst)
8818         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
8819         (write_exp_string_vector, write_exp_bitstring)
8820         (write_exp_msymbol, mark_struct_expression)
8821         (write_dollar_variable)
8822         (insert_type_address_space, increase_expout_size): Replace
8823         "parser_state" with "expr_builder".
8824         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
8825         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
8826         "parser_state" with "expr_builder".
8827
8828 2019-04-04  Tom Tromey  <tom@tromey.com>
8829
8830         * rust-exp.y: Replace "parse_language" with method call.
8831         * p-exp.y:
8832         (yylex): Replace "parse_language" with method call.
8833         * m2-exp.y:
8834         (yylex): Replace "parse_language" with method call.
8835         * go-exp.y (classify_name): Replace "parse_language" with method
8836         call.
8837         * f-exp.y (yylex): Replace "parse_language" with method call.
8838         * d-exp.y (lex_one_token): Replace "parse_language" with method
8839         call.
8840         * c-exp.y:
8841         (lex_one_token, classify_name, yylex): Replace "parse_language"
8842         with method call.
8843         * ada-exp.y (find_primitive_type, type_char)
8844         (type_system_address): Replace "parse_language" with method call.
8845
8846 2019-04-04  Tom Tromey  <tom@tromey.com>
8847
8848         * rust-exp.y: Replace "parse_gdbarch" with method call.
8849         * parse.c (write_dollar_variable, insert_type_address_space):
8850         Replace "parse_gdbarch" with method call.
8851         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
8852         call.
8853         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
8854         call.
8855         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
8856         "parse_gdbarch" with method call.
8857         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
8858         with method call.
8859         * f-exp.y (parse_type, parse_f_type, yylex): Replace
8860         "parse_gdbarch" with method call.
8861         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
8862         "parse_gdbarch" with method call.
8863         * c-exp.y (parse_type, parse_number, classify_name): Replace
8864         "parse_gdbarch" with method call.
8865         * ada-lex.l: Replace "parse_gdbarch" with method call.
8866         * ada-exp.y (parse_type, find_primitive_type, type_char)
8867         (type_system_address): Replace "parse_gdbarch" with method call.
8868
8869 2019-04-04  Tom Tromey  <tom@tromey.com>
8870
8871         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
8872         * stap-probe.c (stap_parse_argument): Update.
8873         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
8874         initial_size parameter.
8875         * rust-exp.y (rust_lex_tests): Update.
8876         * parse.c (parser_state): Update.
8877         (parse_exp_in_context): Update.
8878         * parser-defs.h (struct parser_state) <parser_state>: Remove
8879         "initial_size" parameter.
8880
8881 2019-04-04  Tom Tromey  <tom@tromey.com>
8882
8883         * parser-defs.h (increase_expout_size): Don't declare.
8884         * parse.c (increase_expout_size): Now static.
8885
8886 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
8887
8888         * gnu-nat.c (gnu_nat_target::wait): Fix
8889         target_waitstatus_to_string call.
8890
8891 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8892
8893         * eval.c (evaluate_subexp_standard): Handle internal functions
8894         during Fortran function call handling.
8895
8896 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8897
8898         * NEWS: Mention new internal functions.
8899         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
8900         (read_base_type): Use dwarf2_init_complex_target_type.
8901         * value.c (creal_internal_fn): New function.
8902         (cimag_internal_fn): New function.
8903         (_initialize_values): Register new internal functions.
8904
8905 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8906
8907         * infrun.c (stop_all_threads): If debug_infrun, always
8908         trace the wait status after wait_one, using
8909         target_waitstatus_to_string and target_pid_to_str.
8910         (handle_inferior_event): Replace various trace of
8911         wait status kind by a single trace.
8912         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
8913         wait status kind image by target_waitstatus_to_string.
8914         * target/waitstatus.c (target_waitstatus_to_string): Fix
8915         obsolete comment.
8916
8917 2019-04-01  Tom Tromey  <tromey@adacore.com>
8918
8919         PR symtab/23331:
8920         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
8921
8922 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
8923             Pedro Alves  <palves@redhat.com>
8924
8925         * top.c (quit_force): Call 'finalize_values'.
8926         * value.c (finalize_values): New function.
8927         * value.h (finalize_values): Declare.
8928
8929 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
8930
8931         * NEWS: Announce $_gdb_major and $_gdb_minor.
8932
8933         * top.c (init_gdb_version_vars): New function.
8934         (gdb_init): Call init_gdb_version_vars.
8935
8936 2019-03-29  Tom Tromey  <tromey@adacore.com>
8937
8938         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
8939         help text.  Remove dead code.
8940
8941 2019-03-29  Keith Seitz  <keiths@redhat.com>
8942
8943         From Siddhesh Poyarekar:
8944         * f-lang.h (f77_get_upperbound): Return LONGEST.
8945         (f77_get_lowerbound): Likewise.
8946         * f-typeprint.c (f_type_print_varspec_suffix): Expand
8947         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
8948         print them.
8949         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
8950         plongest to format print it.
8951         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
8952         (f77_get_upperbound): Likewise.
8953         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
8954         LOWER_BOUND to LONGEST.
8955         (f77_create_arrayprint_offset_tbl): Likewise.
8956
8957 2019-03-29  Keith Seitz  <keiths@redhat.com>
8958
8959         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
8960         %s/pulongest for TYPE_LENGTH instead of %d in format
8961         strings.
8962         * ada-typerint.c (ada_print_type): Likewise.
8963         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
8964         * compile/compile-c-support.c (generate_register_struct): Likewise.
8965         * gdbtypes.c (recursive_dump_type): Likewise.
8966         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
8967         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
8968         instead of %d in format strings.
8969         * riscv-tdep.c (riscv_type_alignment): Cast second argument
8970         to std::min to ULONGEST.
8971         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
8972         instead of %d in format strings.
8973         * tracepoint.c (info_scope_command): Likewise.
8974         * typeprint.c (print_offset_data::update)
8975         (print_offset_data::finish): Likewise.
8976         * xtensa-tdep.c (xtensa_store_return_value)
8977         (xtensa_push_dummy_call): Likewise.
8978
8979 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
8980
8981         * windows-nat.c (display_selector): Fixed format specifications
8982         for 64-bit Cygwin.
8983
8984 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8985
8986         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
8987
8988 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
8989
8990         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
8991         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
8992         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
8993         (nios2_linux_init_abi): Install it.
8994
8995 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8996
8997         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
8998
8999 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9000
9001         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
9002
9003 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9004             Tom Tromey  <tromey@adacore.com>
9005
9006         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
9007
9008 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
9009
9010         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
9011         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
9012         method to compute the bounds of range types. Also print "[evaluated]"
9013         if the bounds' values come from a dynamic evaluation.
9014
9015 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9016
9017         * cp-valprint.c (cp_print_value_fields): Don't print trailing
9018         whitespace when pretty printing is on.
9019
9020 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9021
9022         * ppc-linux-nat.c: Add include.
9023
9024 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9025
9026         * NEWS: Mention AArch64 Pointer Authentication.
9027
9028 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9029
9030         * arm-linux-nat.c: Add include.
9031
9032 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
9033
9034         * source-cache.c (source_cache::get_source_lines): Re-read
9035         fullname after calling open_source_file.
9036
9037 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
9038
9039         * NEWS: Mention TLS support for FreeBSD.
9040
9041 2019-03-25  Tom Tromey  <tromey@adacore.com>
9042
9043         * minsyms.c (BUNCH_SIZE): Update comment.
9044         (~minimal_symbol_reader): Remove old comment.
9045         (compact_minimal_symbols): Update comment.
9046         (minimal_symbol_reader::install): Remove old comment.  Update
9047         other comments.
9048
9049 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9050
9051         * s390-linux-nat.c: Add include.
9052
9053 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9054
9055         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
9056         Call linux_get_hwcap.
9057         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
9058         Likewise.
9059         (aarch64_linux_get_hwcap): Remove function.
9060         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
9061         declaration.
9062         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
9063         linux_get_hwcap.
9064         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
9065         * linux-tdep.c (linux_get_hwcap): Add function.
9066         (linux_get_hwcap2): Likewise.
9067         * linux-tdep.h (linux_get_hwcap): Add declaration.
9068         (linux_get_hwcap2): Likewise.
9069         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
9070         (ppc_linux_get_hwcap2): Likewise.
9071         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
9072         linux_get_hwcap.
9073         (ppc_linux_nat_target::insert_watchpoint): Likewise.
9074         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
9075         (ppc_linux_nat_target::read_description): Likewise.
9076         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
9077         * s390-linux-nat.c: Likewise.
9078         * s390-linux-tdep.c (s390_core_read_description): Likewise.
9079
9080 2019-03-24  Tom Tromey  <tom@tromey.com>
9081
9082         * ada-lang.c (standard_lookup): Simplify initialization.
9083         (ada_lookup_symbol_nonlocal): Simplify return.
9084         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
9085         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
9086         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
9087         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
9088         initialization.
9089         * solib.c (solib_global_lookup): Simplify.
9090         * symtab.c (null_block_symbol): Remove.
9091         (symbol_cache_lookup): Simplify returns.
9092         (lookup_language_this): Simplify returns.
9093         (lookup_symbol_aux): Simplify return.
9094         (lookup_local_symbol): Simplify returns.
9095         (lookup_global_symbol_from_objfile): Simplify return.
9096         (lookup_symbol_in_objfile_symtabs)
9097         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
9098         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
9099         (lookup_static_symbol, lookup_global_symbol): Simplify return.
9100         * cp-namespace.c (cp_lookup_bare_symbol)
9101         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
9102         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
9103         (cp_lookup_nested_symbol): Don't use null_block_symbol.
9104         (cp_lookup_symbol_via_imports): Simplify initialization.
9105         (find_symbol_in_baseclass): Likewise.
9106         * symtab.h (null_block_symbol): Remove.
9107         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
9108         (d_lookup_nested_symbol, d_lookup_symbol_imports)
9109         (d_lookup_symbol_module): Likewise.
9110         (find_symbol_in_baseclass): Simplify initialization.
9111
9112 2019-03-24  Tom Tromey  <tom@tromey.com>
9113
9114         * expression.h: Don't include symtab.h.
9115         (struct block): Forward declare.
9116
9117 2019-03-24  Tom Tromey  <tom@tromey.com>
9118
9119         * c-exp.y (typebase): Remove casts.
9120         * gdbtypes.c (lookup_unsigned_typename, )
9121         (lookup_signed_typename): Remove cast.
9122         * eval.c (parse_to_comma_and_eval): Remove cast.
9123         * parse.c (write_dollar_variable): Remove cast.
9124         * block.h (struct block) <superblock>: Now const.
9125         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
9126         * psymtab.c (psym_map_matching_symbols): Make "block" const.
9127         (map_block): Make "block" const.
9128         * symfile.h (struct quick_symbol_functions)
9129         <map_matching_symbols>: Constify block argument to "callback".
9130         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
9131         const.
9132         (find_pc_sect_compunit_symtab): Make "b" const.
9133         (find_symbol_at_address): Likewise.
9134         (search_symbols): Likewise.
9135         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
9136         (dw2_debug_names_lookup_symbol): Likewise.
9137         (dw2_map_matching_symbols): Update.
9138         * p-valprint.c (pascal_val_print): Remove "block".
9139         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
9140         (aux_add_nonlocal_symbols): Make "block" const.
9141         (resolve_subexp): Remove cast.
9142         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
9143         const.
9144         (iterate_over_file_blocks): Likewise.
9145         * f-exp.y (%union) <bval>: Remove.
9146         * coffread.c (patch_opaque_types): Make "b" const.
9147         * spu-tdep.c (spu_catch_start): Make "block" const.
9148         * c-valprint.c (print_unpacked_pointer): Remove "block".
9149         * symmisc.c (dump_symtab_1): Make "b" const.
9150         (block_depth): Make "block" const.
9151         * d-exp.y (%union) <bval>: Remove.
9152         * cp-support.h (cp_lookup_rtti_type): Update.
9153         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
9154         * psymtab.c (psym_lookup_symbol): Make "block" const.
9155         (maintenance_check_psymtabs): Make "b" const.
9156         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
9157         (enumerate_locals, enumerate_args): Update.
9158         * python/py-symtab.c (stpy_global_block): Make "block" const.
9159         (stpy_static_block): Likewise.
9160         * inline-frame.c (block_starting_point_at): Make "new_block"
9161         const.
9162         * block.c (find_block_in_blockvector): Make return type const.
9163         (blockvector_for_pc_sect): Make "b" const.
9164         (find_block_in_blockvector): Make "b" const.
9165
9166 2019-03-23  Tom Tromey  <tom@tromey.com>
9167
9168         * varobj.c (varobj_create): Update.
9169         * symfile.c (clear_symtab_users): Don't reset innermost_block.
9170         * printcmd.c (display_command, do_one_display): Don't reset
9171         innermost_block.
9172         * parser-defs.h (enum innermost_block_tracker_type): Move to
9173         expression.h.
9174         (innermost_block): Update comment.
9175         * parse.c (parse_exp_1): Add tracker_types parameter.
9176         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
9177         tracker_types parameter.  Reset innermost_block.
9178         (parse_exp_in_context): Remove.
9179         (parse_expression_for_completion): Update.
9180         * objfiles.c (~objfile): Don't reset expression_context_block or
9181         innermost_block.
9182         * expression.h (enum innermost_block_tracker_type): Move from
9183         parser-defs.h.
9184         (parse_exp_1): Add tracker_types parameter.
9185         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
9186         reset innermost_block.
9187
9188 2019-03-23  Tom Tromey  <tom@tromey.com>
9189
9190         * objfiles.h: Include bcache.h.
9191
9192 2019-03-23  Tom Tromey  <tom@tromey.com>
9193
9194         * linespec.c (get_current_search_block): Use
9195         scoped_restore_current_language.
9196         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
9197
9198 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9199             Jiong Wang  <jiong.wang@arm.com>
9200
9201         * aarch64-linux-tdep.c
9202         (aarch64_linux_iterate_over_regset_sections): Check for pauth
9203         section.
9204         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
9205
9206 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9207             Jiong Wang  <jiong.wang@arm.com>
9208
9209         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
9210         instructions.
9211         (aarch64_analyze_prologue_test): Add PACIASP test.
9212         (aarch64_prologue_prev_register): Unmask PC value.
9213
9214 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9215             Jiong Wang  <jiong.wang@arm.com>
9216
9217         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
9218         (aarch64_dwarf2_prev_register): Unmask PC value.
9219         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
9220         (aarch64_execute_dwarf_cfa_vendor_op): Check for
9221         DW_CFA_AARCH64_negate_ra_state.
9222         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
9223
9224 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9225             Jiong Wang  <jiong.wang@arm.com>
9226
9227         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
9228         registers.
9229         (aarch64_pseudo_register_name): Likewise.
9230         (aarch64_pseudo_register_type): Likewise.
9231         (aarch64_pseudo_register_reggroup_p): Likewise.
9232         (aarch64_gdbarch_init): Add pauth registers.
9233         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
9234         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
9235         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
9236         (struct gdbarch_tdep): Add regnum for ra_state.
9237
9238 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9239             Jiong Wang  <jiong.wang@arm.com>
9240
9241         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
9242
9243 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9244             Jiong Wang  <jiong.wang@arm.com>
9245
9246         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
9247         function.
9248         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
9249         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
9250         (aarch64_gdbarch_init): Add puth registers.
9251         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
9252         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
9253         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
9254
9255 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9256             Jiong Wang  <jiong.wang@arm.com>
9257
9258         * aarch64-linux-nat.c
9259         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
9260         * aarch64-linux-tdep.c
9261         (aarch64_linux_core_read_description): Likewise.
9262         (aarch64_linux_get_hwcap): New function.
9263         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
9264         (aarch64_linux_get_hwcap): New declaration.
9265
9266 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9267             Jiong Wang  <jiong.wang@arm.com>
9268
9269         * aarch64-linux-nat.c
9270         (aarch64_linux_nat_target::read_description): Add pauth param.
9271         * aarch64-linux-tdep.c
9272         (aarch64_linux_core_read_description): Likewise.
9273         * aarch64-tdep.c (struct target_desc): Add in pauth.
9274         (aarch64_read_description): Add pauth param.
9275         (aarch64_gdbarch_init): Likewise.
9276         * aarch64-tdep.h (aarch64_read_description): Likewise.
9277         * arch/aarch64.c (aarch64_create_target_description): Likewise.
9278         * arch/aarch64.h (aarch64_create_target_description): Likewise.
9279         * features/Makefile: Add new files.
9280         * features/aarch64-pauth.c: New file.
9281         * features/aarch64-pauth.xml: New file.
9282
9283 2019-03-20  Tom Tromey  <tromey@adacore.com>
9284
9285         * infrun.c (handle_inferior_event): Rename from
9286         handle_inferior_event_1.  Create a scoped_value_mark.
9287         (handle_inferior_event): Remove.
9288
9289 2019-03-19  Tom Tromey  <tromey@adacore.com>
9290
9291         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
9292         * infrun.h (print_stop_event): Add "displays" parameter.
9293         * infrun.c (print_stop_event): Add "displays" parameter.
9294
9295 2019-03-19  Pedro Alves  <palves@redhat.com>
9296
9297         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
9298         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
9299         to -1.  Fix TABs vs spaces.
9300         (tui_ui_out::tui_ui_out): Don't initialize fields here.
9301         * tui/tui-out.h (tui_ui_out) Add intro comments.
9302         <m_line, m_start_of_line>: In-class initialize, and add describing
9303         comment.
9304
9305 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
9306
9307         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
9308         variable names.
9309         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
9310
9311 2019-03-18  Pedro Alves  <palves@redhat.com>
9312             Eli Zaretskii <eliz@gnu.org>
9313
9314         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
9315         m_line and m_start_of_line.
9316
9317 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
9318
9319         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
9320         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
9321         it returns a newline.  This fixes a regression in TU mode, whereby
9322         the next line is output on the same screen line as the user input.
9323
9324 2019-03-18  Tom Tromey  <tromey@adacore.com>
9325
9326         * minsyms.c (minimal_symbol_reader::install): Remove call to
9327         obstack_blank.
9328
9329 2019-03-18  Pedro Alves  <palves@redhat.com>
9330
9331         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
9332         New globals.
9333         (apply_style): New, factored out from ...
9334         (apply_ansi_escape): ... this.  Handle reverse video mode.
9335         (tui_set_reverse_mode): New function.
9336         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
9337         * tui/tui-winsource.c (tui_show_source_line): Use
9338         tui_set_reverse_mode instead of setting A_STANDOUT.
9339         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
9340         New setter methods.
9341
9342 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
9343
9344         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
9345         Handle tabs.
9346
9347 2019-03-18  Tom Tromey  <tromey@adacore.com>
9348
9349         * ada-lang.c (empty_array): Add "high" parameter.
9350         (ada_evaluate_subexp): Update.
9351
9352 2019-03-17  Sergei Trofimovich <siarheit@google.com>
9353
9354         * unittests/string_view-selftests.c: Define
9355         _initialize_string_view_selftests unconditionally.
9356
9357 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9358
9359         PR gdb/24350
9360         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
9361
9362 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9363
9364         PR gdb/24351
9365         * windows-nat.c (display_selector): Fix format specifiers.
9366
9367 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
9368
9369         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
9370         tui_refill_source_window instead of tui_refresh_win, to update the
9371         current execution line.  This fixes redisplay of the current line
9372         when stepping through the code with "next" or "step".
9373
9374 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9375
9376         * source-cache.c (source_cache::get_source_lines): Call
9377         find_source_lines to initialize s->nlines.  This fixes vertical
9378         scrolling of TUI source window when the DOWN arrow is pressed.
9379
9380 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9381
9382         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
9383         linux-thread-db.c (_initialize_thread_db): Likewise.
9384
9385 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9386
9387         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
9388         wclrtoeol in tui_show_source_line".  This reverts changes made in
9389         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
9390
9391 2019-03-15  Tom Tromey  <tom@tromey.com>
9392
9393         * symtab.h (struct minimal_symbol): Derive from
9394         general_symbol_info.
9395         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
9396         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
9397         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
9398         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
9399         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
9400         (MSYMBOL_SEARCH_NAME): Update.
9401         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
9402         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
9403         * minsyms.c (minimal_symbol_reader::record_full): Update.
9404
9405 2019-03-15  Tom Tromey  <tom@tromey.com>
9406
9407         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
9408
9409 2019-03-15  Tom Tromey  <tom@tromey.com>
9410
9411         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
9412         unique_xmalloc_ptr.
9413         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
9414         Update.
9415         * minsyms.c (lookup_minimal_symbol_by_pc_section)
9416         (build_minimal_symbol_hash_tables)
9417         (minimal_symbol_reader::install): Update.
9418
9419 2019-03-15  Tom Tromey  <tom@tromey.com>
9420
9421         * symtab.c (create_demangled_names_hash): Update.
9422         (symbol_set_names): Update.
9423         * objfiles.h (struct objfile_per_bfd_storage)
9424         <demangled_names_hash>: Now an htab_up.
9425         * objfiles.c (objfile_per_bfd_storage): Simplify.
9426
9427 2019-03-15  Tom Tromey  <tom@tromey.com>
9428
9429         * objfiles.h (struct objfile_per_bfd_storage): Declare
9430         destructor.
9431         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
9432         New.
9433         (get_objfile_bfd_data): Use new.  Don't initialize
9434         language_of_main.
9435         (free_objfile_per_bfd_storage): Remove.
9436         (objfile_bfd_data_free, objfile::~objfile): Use delete.
9437
9438 2019-03-15  Tom Tromey  <tom@tromey.com>
9439
9440         * symfile.c (reread_symbols): Update.
9441         * objfiles.c (objfile::objfile): Update.
9442         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
9443         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
9444         comment.
9445         (minimal_symbol_reader::install): Update.
9446         (terminate_minimal_symbol_table): Remove.
9447         * jit.c (jit_object_close_impl): Update.
9448
9449 2019-03-15  Tom Tromey  <tom@tromey.com>
9450
9451         * minsyms.c (minimal_symbol_reader::record_full): Remove some
9452         initializations.
9453
9454 2019-03-15  Tom Tromey  <tom@tromey.com>
9455
9456         * objfiles.h (struct objfile_per_bfd_storage)
9457         <demangled_hash_languages>: Now a bitset.
9458         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
9459         (lookup_minimal_symbol): Update.
9460
9461 2019-03-15  Tom Tromey  <tom@tromey.com>
9462
9463         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
9464         Don't return the symbol.
9465         * coffread.c (record_minimal_symbol): Use record_full.
9466
9467 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
9468
9469         The MS-Windows port of ncurses fails to switch to a color pair if
9470         one or both of the colors are the implicit default colors.  This
9471         change records the default colors when TUI is initialized, and
9472         then specifies them explicitly when a color pair uses the default
9473         colors.  This allows color styling in TUI mode on MS-Windows.
9474
9475         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
9476         ncurses_norm_attr.
9477         (tui_initialize_io) [__MINGW32__]: Record the default terminal
9478         colors in ncurses_norm_attr.
9479         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
9480         "none", replace it with the default color recorded in
9481         ncurses_norm_attr.
9482
9483 2019-03-14  Tom Tromey  <tromey@adacore.com>
9484
9485         * source-cache.h (class source_cache) <get_source_lines>: Return
9486         std::string.
9487         * source-cache.c (source_cache::extract_lines): Handle case where
9488         first_pos==npos.  Return std::string.
9489         (source_cache::get_source_lines): Update.
9490
9491 2019-03-14  Tom Tromey  <tromey@adacore.com>
9492
9493         * NEWS: Add item for "style sources" commands.
9494         * source-cache.c (source_cache::get_source_lines): Check
9495         source_styling.
9496         * cli/cli-style.c (source_styling): New global.
9497         (_initialize_cli_style): Add "style sources" commands.
9498         (show_style_sources): New function.
9499         * cli/cli-style.h (source_styling): Declare.
9500
9501 2019-03-14  Pedro Alves  <palves@redhat.com>
9502             Tom Tromey  <tromey@adacore.com>
9503
9504         * tui/tui-winsource.h (tui_refill_source_window): Declare.
9505         * tui/tui-winsource.c (tui_refill_source_window): New function,
9506         from...
9507         (tui_horizontal_source_scroll): ... here.  Move some logic.
9508         * cli/cli-style.c (set_style_enabled): Notify new observable.
9509         * tui/tui-hooks.c (tui_redisplay_source): New function.
9510         (tui_attach_detach_observers): Attach or detach
9511         tui_redisplay_source.
9512         * observable.h (source_styling_changed): New observable.
9513         * observable.c: Define source_styling_changed observable.
9514
9515 2019-03-13  Tom Tromey  <tromey@adacore.com>
9516
9517         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
9518         (i386_gnu_nat_target::store_registers): Update.
9519         * target-debug.h (target_debug_print_std_string): New macro.
9520         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9521         * windows-tdep.c (display_one_tib): Update.
9522         * tui/tui-stack.c (tui_make_status_line): Update.
9523         * top.c (print_inferior_quit_action): Update.
9524         * thread.c (thr_try_catch_cmd): Update.
9525         (add_thread_with_info): Update.
9526         (thread_target_id_str): Update.
9527         (thr_try_catch_cmd): Update.
9528         (thread_command): Update.
9529         (thread_find_command): Update.
9530         * record-btrace.c (record_btrace_target::info_record)
9531         (record_btrace_resume_thread, record_btrace_target::resume)
9532         (record_btrace_cancel_resume, record_btrace_step_thread)
9533         (record_btrace_target::wait, record_btrace_target::wait)
9534         (record_btrace_target::wait, record_btrace_target::stop): Update.
9535         * progspace.c (print_program_space): Update.
9536         * process-stratum-target.c
9537         (process_stratum_target::thread_address_space): Update.
9538         * linux-fork.c (linux_fork_mourn_inferior)
9539         (detach_checkpoint_command, info_checkpoints_command)
9540         (linux_fork_context): Update.
9541         (linux_fork_detach): Update.
9542         (class scoped_switch_fork_info): Update.
9543         (delete_checkpoint_command): Update.
9544         * infrun.c (follow_fork_inferior): Update.
9545         (follow_fork_inferior): Update.
9546         (proceed_after_vfork_done): Update.
9547         (handle_vfork_child_exec_or_exit): Update.
9548         (follow_exec): Update.
9549         (displaced_step_prepare_throw): Update.
9550         (displaced_step_restore): Update.
9551         (start_step_over): Update.
9552         (resume_1): Update.
9553         (clear_proceed_status_thread): Update.
9554         (proceed): Update.
9555         (print_target_wait_results): Update.
9556         (do_target_wait): Update.
9557         (context_switch): Update.
9558         (stop_all_threads): Update.
9559         (restart_threads): Update.
9560         (finish_step_over): Update.
9561         (handle_signal_stop): Update.
9562         (switch_back_to_stepped_thread): Update.
9563         (keep_going_pass_signal): Update.
9564         (print_exited_reason): Update.
9565         (normal_stop): Update.
9566         * inferior.c (inferior_pid_to_str): Change return type.
9567         (print_selected_inferior): Update.
9568         (add_inferior): Update.
9569         (detach_inferior): Update.
9570         * dummy-frame.c (fprint_dummy_frames): Update.
9571         * dcache.c (dcache_info_1): Update.
9572         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
9573         (btrace_fetch, btrace_clear): Update.
9574         * linux-tdep.c (linux_core_pid_to_str): Change return type.
9575         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
9576         type.
9577         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
9578         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
9579         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
9580         * gdbarch.c, gdbarch.h: Rebuild.
9581         * gdbarch.sh (core_pid_to_str): Change return type.
9582         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
9583         return type.
9584         (windows_nat_target::pid_to_str): Change return type.
9585         (windows_delete_thread): Update.
9586         (windows_nat_target::attach): Update.
9587         (windows_nat_target::files_info): Update.
9588         * target-delegates.c: Rebuild.
9589         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
9590         return type.
9591         (sol_thread_target::pid_to_str): Change return type.
9592         * remote.c (class remote_target) <pid_to_str>: Change return
9593         type.
9594         (remote_target::pid_to_str): Change return type.
9595         (extended_remote_target::attach, remote_target::remote_stop_ns)
9596         (remote_target::remote_notif_remove_queued_reply)
9597         (remote_target::push_stop_reply, remote_target::disable_btrace):
9598         Update.
9599         (extended_remote_target::attach): Update.
9600         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
9601         type.
9602         (gdbsim_target::pid_to_str): Change return type.
9603         * ravenscar-thread.c (struct ravenscar_thread_target)
9604         <pid_to_str>: Change return type.
9605         (ravenscar_thread_target::pid_to_str): Change return type.
9606         * procfs.c (class procfs_target) <pid_to_str>: Change return
9607         type.
9608         (procfs_target::pid_to_str): Change return type.
9609         (procfs_target::attach): Update.
9610         (procfs_target::detach): Update.
9611         (procfs_target::fetch_registers): Update.
9612         (procfs_target::store_registers): Update.
9613         (procfs_target::wait): Update.
9614         (procfs_target::files_info): Update.
9615         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
9616         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
9617         return type.
9618         (nto_procfs_target::pid_to_str): Change return type.
9619         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
9620         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
9621         return type.
9622         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
9623         (exit_lwp): Update.
9624         (attach_proc_task_lwp_callback, get_detach_signal)
9625         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
9626         (linux_nat_target::resume, wait_lwp, stop_callback)
9627         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
9628         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
9629         (linux_nat_wait_1, resume_stopped_resumed_lwps)
9630         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
9631         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
9632         type.
9633         (inf_ptrace_target::attach): Update.
9634         (inf_ptrace_target::files_info): Update.
9635         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
9636         type.
9637         (go32_nat_target::pid_to_str): Change return type.
9638         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
9639         (gnu_nat_target::wait): Update.
9640         (gnu_nat_target::wait): Update.
9641         (gnu_nat_target::resume): Update.
9642         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
9643         (fbsd_nat_target::wait): Update.
9644         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
9645         type.
9646         (darwin_nat_target::attach): Update.
9647         * corelow.c (class core_target) <pid_to_str>: Change return type.
9648         (core_target::pid_to_str): Change return type.
9649         * target.c (normal_pid_to_str): Change return type.
9650         (default_pid_to_str): Likewise.
9651         (target_pid_to_str): Change return type.
9652         (target_translate_tls_address): Update.
9653         (target_announce_detach): Update.
9654         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
9655         return type.
9656         (bsd_uthread_target::pid_to_str): Change return type.
9657         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
9658         type.
9659         (bsd_kvm_target::pid_to_str): Change return type.
9660         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
9661         return type.
9662         (aix_thread_target::pid_to_str): Change return type.
9663         * target.h (struct target_ops) <pid_to_str>: Change return type.
9664         (target_pid_to_str, normal_pid_to_str): Likewise.
9665         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
9666         type.
9667         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
9668         type.
9669         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
9670         return type.
9671         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
9672         type.
9673         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
9674         type.
9675         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
9676         return type.
9677
9678 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
9679
9680         * NEWS: Mention that the new default MI version is 3.  Mention
9681         changes to the output of commands and events that deal with
9682         multi-location breakpoints.
9683         * breakpoint.c: Include "mi/mi-out.h".
9684         (print_one_breakpoint): Change output syntax if using MI version
9685         >= 3.
9686         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
9687         New.
9688         (mi_multi_location_breakpoint_output_fixed): New.
9689         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
9690         (mi_cmd_fix_multi_location_breakpoint_output): New.
9691         (mi_multi_location_breakpoint_output_fixed): New.
9692         * mi/mi-cmds.c (mi_cmds): Register command
9693         -fix-multi-location-breakpoint-output.
9694         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
9695         interpreter "mi".
9696
9697 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
9698
9699         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
9700         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
9701         instantiate mi_ui_out based on interpreter name.
9702         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
9703         * mi/mi-main.c (mi_load_progress): Likewise.
9704
9705 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9706
9707         * NEWS: Combine separate "New targets" sections for 8.3.
9708
9709 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9710
9711         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
9712         (ppcfbsd_init_abi): Install gdbarch
9713         "fetch_tls_load_module_address" and "get_thread_local_address"
9714         methods.
9715
9716 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9717
9718         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
9719         (riscv_fbsd_init_abi): Install gdbarch
9720         "fetch_tls_load_module_address" and "get_thread_local_address"
9721         methods.
9722
9723 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9724
9725         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
9726         (i386fbsd_init_abi): Install gdbarch
9727         "fetch_tls_load_module_address" and "get_thread_local_address"
9728         methods.
9729
9730 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9731
9732         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
9733         (amd64fbsd_init_abi): Install gdbarch
9734         "fetch_tls_load_module_address" and "get_thread_local_address"
9735         methods.
9736
9737 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9738
9739         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
9740         (struct fbsd_pspace_data): New type.
9741         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
9742         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
9743         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
9744         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
9745         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
9746
9747 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9748
9749         * gdbtypes.c (lookup_struct_elt): New function.
9750         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
9751         * gdbtypes.h (struct struct_elt): New type.
9752         (lookup_struct_elt): New prototype.
9753
9754 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9755
9756         * gdbtypes.c (lookup_struct_elt_type): Update comment and
9757         remove disabled code block.
9758
9759 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9760
9761         * gdbarch.sh (get_thread_local_address): New method.
9762         * gdbarch.h, gdbarch.c: Regenerate.
9763         * target.c (target_translate_tls_address): Use
9764         gdbarch_get_thread_local_address if present instead of
9765         target::get_thread_local_address.
9766
9767 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9768
9769         * target.h (target::get_thread_local_address): Update comment.
9770
9771 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9772
9773         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
9774         objfile->separate_debug_objfile_backlink if not NULL.
9775
9776 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9777
9778         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
9779         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
9780         (amd64bsd_store_inferior_registers): Likewise.
9781         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9782         Enable segment base registers.
9783         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
9784         PT_GETFSBASE and PT_GETGSBASE.
9785         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
9786         PT_SETGSBASE.
9787         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
9788         segment base registers.
9789         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9790
9791 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9792
9793         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9794         Update calls to i386_target_description to add 'segments'
9795         parameter.
9796         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
9797         add segment base registers.
9798         * arch/i386.c (i386_create_target_description): Add 'segments'
9799         parameter to enable segment base registers.
9800         * arch/i386.h (i386_create_target_description): Likewise.
9801         * features/i386/32bit-segments.xml: New file.
9802         * features/i386/32bit-segments.c: Generate.
9803         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
9804         call to i386_target_description to add 'segments' parameter.
9805         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9806         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
9807         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
9808         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
9809         if feature is present.
9810         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
9811         Add 'segments' parameter to call to i386_target_description.
9812         (i386_target_description): Add 'segments' parameter to enable
9813         segment base registers.
9814         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
9815         to call to i386_target_description.
9816         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
9817         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
9818         Define I386_NUM_REGS.
9819         (i386_target_description): Add 'segments' parameter to enable
9820         segment base registers.
9821
9822 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
9823
9824         PR/24325
9825         * source-cache.c: #undef open and close, to avoid unresolved
9826         externals during linking.
9827
9828 2019-03-12  Tom Tromey  <tromey@adacore.com>
9829
9830         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
9831         const.  Add initializers.
9832         (_initialize_remote): Don't initialize ptid globals.
9833
9834 2019-03-12  Pedro Alves  <palves@redhat.com>
9835
9836         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
9837
9838 2019-03-12  Pedro Alves  <palves@redhat.com>
9839
9840         * cp-name-parser.y (main): Remove unused 'len' variable.
9841
9842 2019-03-12  Tom Tromey  <tromey@adacore.com>
9843
9844         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
9845         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
9846
9847 2019-03-12  Tom Tromey  <tromey@adacore.com>
9848
9849         * linux-nat.c (iterate_over_lwps): Update.
9850         (stop_callback): Remove parameter.
9851         (stop_wait_callback, detach_callback, resume_set_callback)
9852         (select_singlestep_lwp_callback, set_ignore_sigint)
9853         (status_callback, resumed_callback, resume_clear_callback)
9854         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
9855         data parameter.
9856         (linux_nat_target::detach, linux_nat_target::resume)
9857         (linux_stop_and_wait_all_lwps, select_event_lwp)
9858         (linux_nat_filter_event, linux_nat_wait_1)
9859         (linux_nat_target::kill, linux_nat_target::stop)
9860         (linux_nat_target::stop): Update.
9861         (linux_nat_resume_callback): Change type.
9862         (resume_stopped_resumed_lwps, count_events_callback)
9863         (select_event_lwp_callback): Likewise.
9864         (linux_stop_lwp, linux_nat_stop_lwp): Update.
9865         * arm-linux-nat.c (struct update_registers_data): Remove.
9866         (update_registers_callback): Change type.
9867         (arm_linux_insert_hw_breakpoint1): Update.
9868         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
9869         parameter.
9870         (x86_linux_dr_set_addr): Update.
9871         (x86_linux_dr_set_control): Update.
9872         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
9873         (iterate_over_lwps): Use gdb::function_view.
9874         * nat/aarch64-linux-hw-point.c (struct
9875         aarch64_dr_update_callback_param): Remove.
9876         (debug_reg_change_callback): Change type.
9877         (aarch64_notify_debug_reg_change): Update.
9878         * s390-linux-nat.c (s390_refresh_per_info): Update.
9879
9880 2019-03-11  Tom Tromey  <tromey@adacore.com>
9881
9882         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
9883         redundant assignment to "this_cu".
9884
9885 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9886
9887         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
9888
9889 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9890
9891         * gdbtypes.c (rank_one_type_parm_set): New function extracted
9892         from...
9893         (rank_one_type): ... this.
9894
9895 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9896
9897         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
9898         from...
9899         (rank_one_type): ... this.
9900
9901 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9902
9903         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
9904         from...
9905         (rank_one_type): ... this.
9906
9907 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9908
9909         * gdbtypes.c (rank_one_type_parm_float): New function extracted
9910         from...
9911         (rank_one_type): ... this.
9912
9913 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9914
9915         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
9916         from...
9917         (rank_one_type): ... this.
9918
9919 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9920
9921         * gdbtypes.c (rank_one_type_parm_range): New function extracted
9922         from...
9923         (rank_one_type): ... this.
9924
9925 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9926
9927         * gdbtypes.c (rank_one_type_parm_char): New function extracted
9928         from...
9929         (rank_one_type): ... this.
9930
9931 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9932
9933         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
9934         from...
9935         (rank_one_type): ... this.
9936
9937 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9938
9939         * gdbtypes.c (rank_one_type_parm_int): New function extracted
9940         from...
9941         (rank_one_type): ... this.
9942
9943 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9944
9945         * gdbtypes.c (rank_one_type_parm_func): New function extracted
9946         from...
9947         (rank_one_type): ... this.
9948
9949 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9950
9951         * gdbtypes.c (rank_one_type_parm_array): New function extracted
9952         from...
9953         (rank_one_type): ... this.
9954
9955 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9956
9957         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
9958         from...
9959         (rank_one_type): ... this.
9960
9961 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9962
9963         * inferior.c (initialize_inferiors): Ensure 'help set/show print
9964         inferior-events' shows the example events.
9965
9966 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
9967
9968         Support styling on native MS-Windows console
9969
9970         PR/24315
9971         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
9972         on MS-Windows if $TERM is not defined.
9973
9974         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
9975
9976         * posix-hdep.c (gdb_console_fputs):
9977         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
9978         functions.
9979         * ui-file.h (gdb_console_fputs): Add prototype.
9980
9981         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
9982         back to fputs only if the former returns zero.
9983
9984 2019-03-07  Tom Tromey  <tom@tromey.com>
9985
9986         * symmisc.c (print_symbol_bcache_statistics): Update.
9987         (print_objfile_statistics): Update.
9988         * symfile.c (allocate_symtab): Update.
9989         * stabsread.c: Don't include bcache.h.
9990         * psymtab.h (struct psymbol_bcache): Don't declare.
9991         (class psymtab_storage) <psymbol_cache>: Now a bcache.
9992         (psymbol_bcache_init, psymbol_bcache_free)
9993         (psymbol_bcache_get_bcache): Don't declare.
9994         * psymtab.c (struct psymbol_bcache): Remove.
9995         (psymtab_storage::psymtab_storage): Update.
9996         (psymtab_storage::~psymtab_storage): Update.
9997         (psymbol_bcache_init, psymbol_bcache_free)
9998         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
9999         (add_psymbol_to_bcache): Update.
10000         (allocate_psymtab): Update.
10001         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
10002         macro_cache>: No longer pointers.
10003         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
10004         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
10005         * macrotab.c (macro_bcache): Update.
10006         * macroexp.c: Don't include bcache.h.
10007         * gdbtypes.c (check_types_worklist): Update.
10008         (types_deeply_equal): Remove TRY/CATCH.  Update.
10009         * elfread.c (elf_symtab_read): Update.
10010         * dwarf2read.c: Don't include bcache.h.
10011         * buildsym.c (buildsym_compunit::get_macro_table): Update.
10012         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
10013         (print_bcache_statistics, bcache_memory_used): Don't declare.
10014         (struct bcache): Move from bcache.c.  Add constructor, destructor,
10015         methods.  Rename all data members.
10016         * bcache.c (struct bcache): Move to bcache.h.
10017         (bcache::expand_hash_table): Rename from expand_hash_table.
10018         (bcache): Remove.
10019         (bcache::insert): Rename from bcache_full.
10020         (bcache::compare): Rename from bcache_compare.
10021         (bcache_xmalloc): Remove.
10022         (bcache::~bcache): Rename from bcache_xfree.
10023         (bcache::print_statistics): Rename from print_bcache_statistics.
10024         (bcache::memory_used): Rename from bcache_memory_used.
10025
10026 2019-03-07  Pedro Alves  <palves@redhat.com>
10027
10028         * infrun.c (normal_stop): Also check for
10029         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
10030
10031 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
10032
10033         * f-lang.c (value_from_host_double): Moved to...
10034         * value.c (value_from_host_double): ...here.
10035         * value.h (value_from_host_double): Declare.
10036         * guile/scm-math.c (vlscm_convert_typed_number): Use
10037         value_from_host_double.
10038         (vlscm_convert_number): Likewise.
10039         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
10040         * python/py-value.c (convert_value_from_python): Likewise.
10041
10042 2019-03-06  Tom Tromey  <tom@tromey.com>
10043
10044         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
10045
10046 2019-03-06  Tom Tromey  <tom@tromey.com>
10047
10048         * utils.h (free_current_contents): Don't declare.
10049         * utils.c (free_current_contents): Remove.
10050
10051 2019-03-06  Tom Tromey  <tom@tromey.com>
10052
10053         * top.c (quit_force): Update.
10054         * main.c (captured_command_loop): Update.
10055         * common/new-op.c (operator new): Update.
10056         * common/common-exceptions.c (struct catcher)
10057         <save_cleanup_chain>: Remove member.
10058         (exceptions_state_mc_init): Update.
10059         (exception_try_scope_entry): Return nullptr.
10060         (exception_try_scope_exit, exception_rethrow)
10061         (throw_exception_sjlj, throw_exception_cxx): Update.
10062         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
10063         (all_cleanups, do_cleanups, discard_cleanups)
10064         (discard_final_cleanups, save_cleanups, save_final_cleanups)
10065         (restore_cleanups, restore_final_cleanups): Don't declare.
10066         (do_final_cleanups): Remove parameter.
10067         * common/cleanups.c (cleanup_chain, make_cleanup)
10068         (make_cleanup_dtor, all_cleanups, do_cleanups)
10069         (discard_my_cleanups, discard_cleanups)
10070         (discard_final_cleanups, save_my_cleanups, save_cleanups)
10071         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
10072         (null_cleanup): Remove.
10073         (do_final_cleanups): Remove parameter.
10074
10075 2019-03-06  Tom Tromey  <tom@tromey.com>
10076
10077         * remote.c (remote_target::remote_parse_stop_reply): Use
10078         unique_xmalloc_ptr.
10079
10080 2019-03-06  Tom Tromey  <tom@tromey.com>
10081
10082         * stabsread.c (struct stabs_field_info): Rename from field_info.
10083         <list, fnlist>: Add initializers.
10084         <obstack>: New member.
10085         (read_member_functions, read_struct_fields, read_baseclasses):
10086         Allocate on obstack.  Don't use cleanups.
10087         (read_one_struct_field, read_member_functions, read_struct_fields)
10088         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
10089         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
10090         (read_struct_type): Update.
10091
10092 2019-03-06  Tom Tromey  <tom@tromey.com>
10093
10094         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
10095         * common/filestuff.h (make_cleanup_close): Don't declare.
10096         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
10097         Remove.
10098
10099 2019-03-06  Tom Tromey  <tom@tromey.com>
10100
10101         * solib-aix.c: Use make_scope_exit.
10102
10103 2019-03-06  Tom Tromey  <tom@tromey.com>
10104
10105         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
10106         Use make_scope_exit.
10107
10108 2019-03-06  Tom Tromey  <tom@tromey.com>
10109
10110         * solib-svr4.c (disable_probes_interface): Remove parameter.
10111         (svr4_handle_solib_event): Use make_scope_exit.
10112
10113 2019-03-06  Tom Tromey  <tom@tromey.com>
10114
10115         * remote.c (struct stop_reply_deleter): Remove.
10116         (stop_reply_up): Update.
10117         (struct stop_reply): Derive from notif_event.  Don't typedef.
10118         <regcache>: Now a std::vector.
10119         (stop_reply_xfree): Remove.
10120         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
10121         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
10122         (remote_target::discard_pending_stop_replies): Use delete.
10123         (remote_target::remote_parse_stop_reply): Update.
10124         (remote_target::process_stop_reply): Update.
10125         * remote-notif.h (struct notif_event): Add virtual destructor.
10126         Remove "dtr" member.
10127         (struct notif_client) <alloc_event>: Return a unique_ptr.
10128         (notif_event_xfree): Don't declare.
10129         (notif_event_up): New typedef.
10130         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
10131         (notif_event_xfree, do_notif_event_xfree): Remove.
10132         (remote_notif_state_xfree): Update.
10133
10134 2019-03-06  Tom Tromey  <tom@tromey.com>
10135
10136         * infrun.c (displaced_step_clear_cleanup): Now a
10137         forward_scope_exit type.
10138         (displaced_step_prepare_throw): Update.
10139         (displaced_step_fixup): Update.
10140
10141 2019-03-06  Tom Tromey  <tom@tromey.com>
10142
10143         * inferior.h (class inferior): Update comment.
10144         * gdbthread.h (class thread_info): Update comment.
10145
10146 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
10147             Tom Tromey  <tom@tromey.com>
10148
10149         * stabsread.h (struct stab_section_list): Remove.
10150         (coffstab_build_psymtabs): Update.
10151         * dbxread.c (symbuf_sections): Now a std::vector.
10152         (sect_idx): New global.
10153         (fill_symbuf): Update.
10154         (coffstab_build_psymtabs): Change type of stabsects parameter.
10155         Update.
10156         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
10157         std::vector.
10158         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
10159         (coff_locate_sections): Update.
10160         (coff_symfile_read): Remove cleanups.  Update.
10161         (init_stringtab): Add storage parameter.
10162         (free_stringtab, free_stringtab_cleanup): Remove.
10163         (init_lineno): Add storage parameter.
10164         (free_linetab, free_linetab_cleanup): Remove.
10165
10166 2019-03-06  Pedro Alves  <palves@redhat.com>
10167
10168         * linux-fork.c (fork_info::clobber_regs): Delete.
10169         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
10170         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
10171         comment.  Adjust.
10172         (scoped_switch_fork_info::scoped_switch_fork_info)
10173         (checkpoint_command, linux_fork_context): Adjust
10174         fork_save_infrun_state calls.
10175
10176 2019-03-06  Pedro Alves  <palves@redhat.com>
10177
10178         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
10179         (inf_has_multiple_threads): Return 'bool' and rewrite using
10180         inferior_info::threads().
10181
10182 2019-03-06  Pedro Alves  <palves@redhat.com>
10183
10184         * linux-fork.c: Include <list>.
10185         (fork_list): Now a std::list instance.
10186         (fork_info): Add ctor, dtor, and in-class initialize all fields.
10187         (forks_exist_p, find_last_fork): Adjust.
10188         (new_fork): Delete.
10189         (one_fork_p): New.
10190         (add_fork): Adjust.
10191         (free_fork): Delete, folded into fork_info::~fork_info().
10192         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
10193         Adjust.
10194         (init_fork_list): Delete.
10195         (linux_fork_killall, linux_fork_mourn_inferior)
10196         (linux_fork_detach, info_checkpoints_command): Adjust.
10197         (_initialize_linux_fork): No longer call init_fork_list.
10198
10199 2019-03-06  Pedro Alves  <palves@redhat.com>
10200
10201         * linux-fork.c (new_fork): New, split out of ...
10202         (add_fork): ... this.  Return void.  Move "first fork" special
10203         case from here, to ...
10204         (checkpoint_command): ... here.
10205         * linux-linux.h (add_fork): Return void.
10206
10207 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10208
10209         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
10210
10211 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10212             Chris January  <chris.january@arm.com>
10213             David Lecomber  <david.lecomber@arm.com>
10214
10215         * f-exp.y: New token, UNOP_INTRINSIC.
10216         (exp): New pattern using UNOP_INTRINSIC token.
10217         (f77_keywords): Add 'abs' keyword.
10218         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
10219         (value_from_host_double): New function.
10220         (evaluate_subexp_f): Support UNOP_ABS.
10221
10222 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10223
10224         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
10225         types.
10226
10227 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10228
10229         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
10230         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
10231         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
10232
10233 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10234
10235         * f-exp.y (convert_to_kind_type): Handle more type kinds.
10236
10237 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10238             Chris January  <chris.january@arm.com>
10239
10240         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
10241         * f-exp.y: Define 'KIND' token.
10242         (exp): New pattern for KIND expressions.
10243         (ptype): Handle types with a kind extension.
10244         (direct_abs_decl): Extend to spot kind extensions.
10245         (f77_keywords): Add 'kind' to the list.
10246         (push_kind_type): New function.
10247         (convert_to_kind_type): New function.
10248         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
10249         * parse.c (operator_length_standard): Likewise.
10250         * parser-defs.h (enum type_pieces): Add tp_kind.
10251         * std-operator.def: Add UNOP_KIND.
10252
10253 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10254
10255         * f-exp.y (f_parse): Set yydebug.
10256
10257 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10258
10259         * f-lang.c (evaluate_subexp_f): New function.
10260         (exp_descriptor_f): New global.
10261         (f_language_defn): Use exp_descriptor_f instead of
10262         exp_descriptor_standard.
10263
10264 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10265
10266         * f-exp.y (struct token): Add comments.
10267         (dot_ops): Remove uppercase versions and the end marker.
10268         (f77_keywords): Likewise.
10269         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
10270         entries in the dot_ops array are case insensitive, and use
10271         strncasecmp to compare strings.  Also some whitespace cleanup in
10272         this area.  Similar for the f77_keywords array, except entries in
10273         this list might be case sensitive.
10274
10275 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10276
10277         * f-exp.y (struct f77_boolean_val): Add comments.
10278         (boolean_values): Remove uppercase versions, and end marker.
10279         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
10280         and use strncasecmp to achieve case insensitivity.  Additionally,
10281         perform whitespace cleanup around this code.
10282
10283 2019-03-06  Tom Tromey  <tromey@adacore.com>
10284
10285         * remote-sim.c (gdbsim_target_open): Use result of
10286         gdb_argv::release.
10287
10288 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
10289         Dirk Schubert  <dirk.schubert@arm.com>
10290         Chris January  <chris.january@arm.com>
10291
10292         * eval.c (evaluate_subexp_standard): Call Fortran argument
10293         wrapping logic.
10294         * f-lang.c (struct value): A value which can be passed into a
10295         Fortran function call.
10296         (fortran_argument_convert): Wrap Fortran arguments in a pointer
10297         where appropriate.
10298         (struct type): Value ready for a Fortran function call.
10299         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
10300         is needed.
10301         * f-lang.h (fortran_argument_convert): Declaration.
10302         (fortran_preserve_arg_pointer): Declaration.
10303         * infcall.c (value_arg_coerce): Call Fortran argument logic.
10304
10305 2019-03-05  Tom Tromey  <tromey@adacore.com>
10306
10307         * python/py-prettyprint.c (print_string_repr): Remove #if.
10308         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
10309
10310 2019-03-05  Tom Tromey  <tromey@adacore.com>
10311
10312         * target.c (the_dummy_target): Move later.  Change type to
10313         "dummy_target".
10314         (initialize_targets): Don't initialize the_dummy_target.
10315
10316 2019-03-05  Tom Tromey  <tromey@adacore.com>
10317
10318         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
10319         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
10320
10321 2019-03-05  Tom Tromey  <tromey@adacore.com>
10322
10323         * windows-nat.c (windows_nat_target::attach)
10324         (windows_nat_target::detach): Don't call gdb_flush.
10325         * valprint.c (generic_val_print, val_print, val_print_string):
10326         Don't call gdb_flush.
10327         * utils.c (defaulted_query): Don't call gdb_flush.
10328         * typeprint.c (print_type_scalar): Don't call gdb_flush.
10329         * target.c (target_announce_detach): Don't call gdb_flush.
10330         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
10331         * remote.c (extended_remote_target::attach): Don't call
10332         gdb_flush.
10333         * procfs.c (procfs_target::detach): Don't call gdb_flush.
10334         * printcmd.c (do_examine): Don't call gdb_flush.
10335         (info_display_command): Don't call gdb_flush.
10336         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
10337         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
10338         * memattr.c (info_mem_command): Don't call gdb_flush.
10339         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
10340         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
10341         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
10342         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
10343         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
10344         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
10345         (gnu_nat_target::detach): Don't call gdb_flush.
10346         * f-valprint.c (f_val_print): Don't call gdb_flush.
10347         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
10348         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
10349         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
10350         gdb_flush.
10351         * c-valprint.c (c_val_print): Don't call gdb_flush.
10352         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
10353
10354 2019-03-05  Tom Tromey  <tromey@adacore.com>
10355
10356         * varobj.c (update_dynamic_varobj_children): Update.
10357         (install_default_visualizer): Use reset, not release.
10358         * value.c (set_internalvar): Update.
10359         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
10360         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
10361         ATTRIBUTE_UNUSED_RESULT.
10362
10363 2019-03-05  Tom Tromey  <tromey@adacore.com>
10364
10365         * remote.c (class scoped_remote_fd) <release>: Add
10366         ATTRIBUTE_UNUSED_RESULT.
10367
10368 2019-03-05  Tom Tromey  <tromey@adacore.com>
10369
10370         * macroexp.c (struct macro_buffer) <release>: Add
10371         ATTRIBUTE_UNUSED_RESULT.
10372
10373 2019-03-05  Tom Tromey  <tromey@adacore.com>
10374
10375         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
10376         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
10377         ATTRIBUTE_UNUSED_RESULT.
10378
10379 2019-03-05  Tom Tromey  <tromey@adacore.com>
10380
10381         * common/scoped_fd.h (class scoped_fd) <release>: Add
10382         ATTRIBUTE_UNUSED_RESULT.
10383
10384 2019-03-05  Tom Tromey  <tromey@adacore.com>
10385
10386         * parser-defs.h (struct parser_state) <release>: Add
10387         ATTRIBUTE_UNUSED_RESULT.
10388
10389 2019-03-05  Tom Tromey  <tromey@adacore.com>
10390
10391         * utils.h (class gdb_argv) <release>: Add
10392         ATTRIBUTE_UNUSED_RESULT.
10393         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
10394
10395 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
10396
10397         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
10398         for-loop range, to avoid compiler warnings.
10399
10400         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
10401         avoid compiler warnings about unused variables.
10402
10403         * NEWS: Mention end of support for native debugging on MS-Windows
10404         before XP.
10405
10406         PR gdb/24292
10407         * common/netstuff.c:
10408         * gdbserver/gdbreplay.c
10409         * gdbserver/remote-utils.c:
10410         * ser-tcp.c:
10411         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
10412         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
10413         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
10414         'getaddrinfo' and 'freeaddrinfo' were not available before
10415         Windows XP, and mingw.org's MinGW headers by default define
10416         _WIN32_WINNT to 0x500.
10417
10418 2019-03-01  Gary Benson <gbenson@redhat.com>
10419
10420         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
10421
10422 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
10423             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
10424
10425         PR gdb/8527
10426         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
10427         set_sigint_trap, clear_sigint_trap.
10428
10429 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10430
10431         * target.c (target_detach): Clear the regcache and the
10432         frame cache.
10433
10434 2019-02-27  Pedro Alves  <palves@redhat.com>
10435
10436         * utils.c (set_screen_size): When we cap the height/width sizes,
10437         tweak the corresponding command variable to show "unlimited":
10438
10439 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
10440             Pedro Alves  <palves@redhat.com>
10441
10442         * utils.c (set_screen_size): Reduce "infinite" rows and columns
10443         before calling rl_set_screen_size.
10444
10445 2019-02-27  Tom Tromey  <tromey@adacore.com>
10446
10447         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
10448         define.
10449         * python/py-value.c: Remove Python 2.4 workaround.
10450         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
10451         workaround.
10452         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
10453         Python 2.4 workaround.
10454         * python/python-internal.h: Remove Python 2.4 comment.
10455         (Py_ssize_t): Don't define.
10456         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
10457         (gdb_Py_DECREF): Remove Python 2.4 workaround.
10458         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
10459         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
10460         * python/python.c (do_start_initialization): Remove Python 2.4
10461         workaround.
10462         * python/py-prettyprint.c (class dummy_python_frame): Remove.
10463         (print_children): Remove Python 2.4 workaround.
10464         * python/py-inferior.c (buffer_procs): Remove Python 2.4
10465         workaround.
10466         (CHARBUFFERPROC_NAME): Remove.
10467         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
10468         Python 2.4 workaround.
10469
10470 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10471
10472         * NEWS: Note minimum Python version.
10473
10474 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10475
10476         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
10477         code from these functions.  Remove corresponding ifdefs.  Use
10478         Py_buffer_up instead of explicit calls to PyBuffer_Release.
10479         Remove gotos and target of gotos.
10480         (infpy_search_memory): Likewise.
10481
10482 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10483
10484         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
10485         (hppa_gdbarch_init): Don't register deleted functions with
10486         gdbarch.
10487
10488 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10489
10490         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
10491         (h8300_unwind_sp): Delete.
10492         (h8300_dummy_id): Delete.
10493         (h8300_gdbarch_init): Don't register deleted functions with
10494         gdbarch.
10495
10496 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10497
10498         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
10499         (ft32_unwind_pc): Delete.
10500         (ft32_unwind_sp): Delete.
10501         (ft32_gdbarch_init): Don't register deleted functions with
10502         gdbarch.
10503
10504 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10505
10506         * gdb/frv-tdep.c (frv_dummy_id): Delete.
10507         (frv_unwind_pc): Delete.
10508         (frv_unwind_sp): Delete.
10509         (frv_gdbarch_init): Don't register deleted functions with
10510         gdbarch.
10511
10512 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10513
10514         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
10515         (riscv_unwind_pc): Delete.
10516         (riscv_unwind_sp): Delete.
10517         (riscv_gdbarch_init): Don't register deleted functions with
10518         gdbarch.
10519
10520 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10521
10522         * gdb/csky-tdep.c (csky_dummy_id): Delete.
10523         (csky_unwind_pc): Delete.
10524         (csky_unwind_sp): Delete.
10525         (csky_gdbarch_init): Don't register deleted functions with
10526         gdbarch.
10527
10528 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10529
10530         * gdb/cris-tdep.c (cris_dummy_id): Delete.
10531         (cris_unwind_pc): Delete.
10532         (cris_unwind_sp): Delete.
10533         (cris_gdbarch_init): Don't register deleted functions with
10534         gdbarch.
10535
10536 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10537
10538         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
10539         (bfin_unwind_pc): Delete.
10540         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
10541
10542 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10543
10544         * gdb/arm-tdep.c (arm_dummy_id): Delete.
10545         (arm_unwind_pc): Delete.
10546         (arm_unwind_sp): Delete.
10547         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
10548
10549 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10550
10551         * gdb/arc-tdep.c (arc_dummy_id): Delete.
10552         (arc_unwind_pc): Delete.
10553         (arc_unwind_sp): Delete.
10554         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
10555
10556 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10557
10558         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
10559         (alpha_unwind_pc): Delete.
10560         (alpha_gdbarch_init): Don't register deleted functions with
10561         gdbarch.
10562
10563 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10564
10565         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
10566         (aarch64_unwind_pc): Delete.
10567         (aarch64_unwind_sp): Delete.
10568         (aarch64_gdbarch_init): Don't register deleted functions with
10569         gdbarch.
10570
10571 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10572
10573         * gdbtypes.c (type_align): Don't consider static members when
10574         computing structure alignment.
10575
10576 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10577
10578         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
10579         return 0 for other types.
10580         * arch-utils.c (default_type_align): Always return 0.
10581         * gdbarch.h: Regenerate.
10582         * gdbarch.sh (type_align): Extend comment.
10583         * gdbtypes.c (type_align): Add additional comments, always call
10584         gdbarch_type_align before applying the default rules.
10585         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
10586         generic code will then apply a suitable default.
10587         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
10588         types, return 0 for other types.
10589
10590 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
10591
10592         * NEWS: Create a new section for the next release branch.
10593         Rename the section of the current branch, now that it has
10594         been cut.
10595
10596 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
10597
10598         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
10599         * version.in: Bump version to 8.3.50.DATE-git.
10600
10601 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
10602
10603         * aix-thread.c (ptid_cmp): Remove unused variable.
10604         (get_signaled_thread): Likewise.
10605         (store_regs_user_thread): Likewise.
10606         (store_regs_kernel_thread): Likewise.
10607         (fetch_regs_kernel_thread): Remove shadowed variable.
10608
10609 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10610
10611         * features/riscv/32bit-cpu.xml: Add register numbers.
10612         * features/riscv/32bit-fpu.c: Regenerate.
10613         * features/riscv/32bit-fpu.xml: Add register numbers.
10614         * features/riscv/64bit-cpu.xml: Add register numbers.
10615         * features/riscv/64bit-fpu.c: Regenerate.
10616         * features/riscv/64bit-fpu.xml: Add register numbers.
10617
10618 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
10619
10620         * NEWS: Mention two argument form of gdb.Value constructor.
10621         * python/py-value.c (convert_buffer_and_type_to_value): New
10622         function.
10623         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
10624         Add support for handling an optional second argument.  Call
10625         convert_buffer_and_type_to_value as appropriate.
10626         * python/python-internal.h (Py_buffer_deleter): New struct.
10627         (Py_buffer_up): New typedef.
10628
10629 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
10630
10631         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
10632         instead of releasing ownership.
10633
10634 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
10635
10636         * dwarf2read.c (open_and_init_dwp_file): Call
10637         elf_numsections instead of bfd_count_sections to initialize
10638         dwp_file->num_sections.
10639
10640 2019-02-25  Tom Tromey  <tromey@adacore.com>
10641
10642         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
10643
10644 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
10645
10646         * gcore.in: Add '--readnever' option when invoking GDB.
10647
10648 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
10649
10650         * MAINTAINERS: Update my email address.
10651
10652 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
10653
10654         * build-id.c (build_id_to_debug_bfd_1): New function.
10655         (build_id_to_debug_bfd): Look for separate debug file in
10656         sysroot.
10657
10658 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
10659
10660         * gdbarch.sh: Update the copyright year range that is placed into
10661         generated files.
10662
10663 2019-02-22  Keith Seitz  <keiths@redhat.com>
10664
10665         PR symtab/23853
10666         * linespec.c (create_sals_line_offset): Search for the default
10667         symtab's filename instead of its fullname.
10668
10669 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
10670
10671         * NEWS: Update style defaults.
10672
10673 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
10674
10675         * main.c (captured_main_1): Disable styling in batch mode.
10676
10677 2019-02-20  Tom Tromey  <tom@tromey.com>
10678
10679         * symtab.c (symtab_symbol_info): Fix typos.
10680
10681 2019-02-20  Tom Tromey  <tromey@adacore.com>
10682
10683         * findcmd.c (_initialize_mem_search): Use upper case for
10684         metasyntactic variables.
10685
10686 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
10687
10688         * aarch64-tdep.c (aarch64_add_reggroups): New function.
10689         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
10690
10691 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
10692
10693         * top.h (source_file_name): Change to std::string.
10694         * top.c (source_file_name): Likewise.
10695         (command_line_input): Adjust.
10696         * cli/cli-script.c (script_from_file): Adjust.
10697
10698 2019-02-19  Tom Tromey  <tromey@adacore.com>
10699
10700         * ravenscar-thread.c
10701         (ravenscar_thread_target::update_thread_list): Don't call
10702         ada_build_task_list.
10703         * ada-lang.h (ada_build_task_list): Don't declare.
10704         * ada-tasks.c (struct ada_tasks_inferior_data)
10705         <task_list_valid_p>: Now bool.
10706         (read_known_tasks, ada_task_list_changed)
10707         (ada_tasks_invalidate_inferior_data): Update.
10708         (read_known_tasks_array): Return bool.
10709         (read_known_tasks_list): Likewise.
10710         (read_known_tasks): Return void.
10711         (ada_build_task_list): Now static.
10712
10713 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10714
10715         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
10716         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
10717
10718 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10719
10720         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
10721         variant for ada_tasks_pspace_data_handle and
10722         ada_tasks_inferior_data_handle.
10723         (ada_tasks_pspace_data_cleanup): New function.
10724         (ada_tasks_inferior_data_cleanup): New function.
10725
10726 2019-02-17  Tom Tromey  <tom@tromey.com>
10727
10728         * macrotab.h (macro_source_fullname): Return a std::string.
10729         * macrotab.c (macro_include, check_for_redefinition)
10730         (macro_undef, macro_lookup_definition, foreach_macro)
10731         (foreach_macro_in_scope): Update.
10732         (macro_source_fullname): Return a std::string.
10733         * macrocmd.c (show_pp_source_pos): Update.
10734
10735 2019-02-17  Tom Tromey  <tom@tromey.com>
10736
10737         * macrocmd.c (show_pp_source_pos): Style the file names.
10738
10739 2019-02-17  Tom Tromey  <tom@tromey.com>
10740
10741         PR tui/24197:
10742         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
10743
10744 2019-02-17  Tom Tromey  <tom@tromey.com>
10745
10746         * ada-lang.c (user_select_syms): Use filtered printing.
10747         * utils.c (wrap_style): New global.
10748         (desired_style): Remove.
10749         (emit_style_escape): Add stream parameter.
10750         (set_output_style, reset_terminal_style, prompt_for_continue):
10751         Update.
10752         (flush_wrap_buffer): Only flush gdb_stdout.
10753         (wrap_here): Set wrap_style.
10754         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
10755         treat escape sequences as a character.  Change when wrap buffer is
10756         flushed.
10757         (fputs_styled): Do not set the output style when the default is
10758         requested.
10759         * ui-style.h (struct ui_file_style) <is_default>: New method.
10760         * source.c (print_source_lines_base): Emit escape sequences in one
10761         piece.
10762
10763 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10764
10765         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
10766         integers and enumeration types.
10767
10768 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10769
10770         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
10771         instead of lookup_symbol_in_language
10772         (do_exact_match): New function.
10773         (ada_get_symbol_name_matcher): Return do_exact_match when
10774         doing a verbatim match.
10775
10776 2019-02-15  Tom Tromey  <tromey@adacore.com>
10777
10778         * ravenscar-thread.c (ravenscar_thread_target::resume)
10779         (ravenscar_thread_target::wait): Special case wildcard requests.
10780
10781 2019-02-15  Tom Tromey  <tromey@adacore.com>
10782
10783         * ravenscar-thread.c (base_ptid): Remove.
10784         (struct ravenscar_thread_target) <close>: New method.
10785         <m_base_ptid>: New member.
10786         <update_inferior_ptid, active_task, task_is_currently_active,
10787         runtime_initialized>: Declare methods.
10788         <ravenscar_thread_target>: Add constructor.
10789         (ravenscar_thread_target::task_is_currently_active)
10790         (ravenscar_thread_target::update_inferior_ptid)
10791         (ravenscar_runtime_initialized): Rename.  Now methods.
10792         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
10793         (ravenscar_thread_target::update_thread_list): Update.
10794         (ravenscar_thread_target::active_task): Now method.
10795         (ravenscar_thread_target::store_registers)
10796         (ravenscar_thread_target::prepare_to_store)
10797         (ravenscar_thread_target::prepare_to_store)
10798         (ravenscar_thread_target::mourn_inferior): Update.
10799         (ravenscar_inferior_created): Use "new" to create target.
10800         (ravenscar_thread_target::get_ada_task_ptid): Update.
10801         (_initialize_ravenscar): Don't initialize base_ptid.
10802         (ravenscar_ops): Remove global.
10803
10804 2019-02-15  Tom Tromey  <tromey@adacore.com>
10805
10806         * target.h (push_target): Declare new overload.
10807         * target.c (push_target): New overload, taking an rvalue reference.
10808         * remote.c (remote_target::open_1): Use push_target overload.
10809         * corelow.c (core_target_open): Use push_target overload.
10810
10811 2019-02-15  Tom Tromey  <tromey@adacore.com>
10812
10813         * ravenscar-thread.c (is_ravenscar_task)
10814         (ravenscar_task_is_currently_active): Return bool.
10815         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
10816         (_initialize_ravenscar): Remove "(void)".
10817         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
10818         Return bool.
10819
10820 2019-02-15  Tom Tromey  <tromey@adacore.com>
10821
10822         * ravenscar-thread.c (ravenscar_runtime_initializer)
10823         (has_ravenscar_runtime, get_running_thread_id)
10824         (ravenscar_thread_target::resume): Fix indentation.
10825
10826 2019-02-15  Tom Tromey  <tromey@adacore.com>
10827
10828         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
10829         from ravenscar_arch_ops.
10830         (sparc_ravenscar_ops::fetch_registers)
10831         (sparc_ravenscar_ops::store_registers): Now methods.
10832         (sparc_ravenscar_prepare_to_store): Remove.
10833         (sparc_ravenscar_ops): Redefine.
10834         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
10835         methods and destructor.  Remove members.
10836         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
10837         (ravenscar_thread_target::store_registers)
10838         (ravenscar_thread_target::prepare_to_store): Update.
10839         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
10840         Remove.
10841         (struct ppc_ravenscar_powerpc_ops): Derive from
10842         ravenscar_arch_ops.
10843         (ppc_ravenscar_powerpc_ops::fetch_registers)
10844         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
10845         (ppc_ravenscar_powerpc_ops): Redefine.
10846         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
10847         (ppc_ravenscar_e500_ops::fetch_registers)
10848         (ppc_ravenscar_e500_ops::store_registers): Now methods.
10849         (ppc_ravenscar_e500_ops): Redefine.
10850         * aarch64-ravenscar-thread.c
10851         (aarch64_ravenscar_generic_prepare_to_store): Remove.
10852         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
10853         (aarch64_ravenscar_fetch_registers)
10854         (aarch64_ravenscar_store_registers): Now methods.
10855         (aarch64_ravenscar_ops): Redefine.
10856
10857 2019-02-15  Tom Tromey  <tromey@adacore.com>
10858
10859         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
10860         (ravenscar_thread_target::stopped_by_hw_breakpoint)
10861         (ravenscar_thread_target::stopped_by_watchpoint)
10862         (ravenscar_thread_target::stopped_data_address)
10863         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
10864
10865 2019-02-15  Tom Tromey  <tromey@adacore.com>
10866
10867         * ravenscar-thread.c: Fix some typos.
10868
10869 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10870             Tom Tromey  <tromey@adacore.com>
10871
10872         * ada-lang.c (ada_exception_sal): Change addr_string to a
10873         std::string.
10874         (create_ada_exception_catchpoint): Update.
10875
10876 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10877             Tom Tromey  <tromey@adacore.com>
10878
10879         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
10880         (bp_location_ops): Remove.
10881         (base_breakpoint_allocate_location): Update.
10882         (free_bp_location): Update.
10883         * ada-lang.c (class ada_catchpoint_location)
10884         <ada_catchpoint_location>: Remove ops parameter.
10885         (ada_catchpoint_location_dtor): Remove.
10886         (ada_catchpoint_location_ops): Remove.
10887         (allocate_location_exception): Update.
10888         * breakpoint.h (struct bp_location_ops): Remove.
10889         (class bp_location) <bp_location>: Remove bp_location_ops
10890         parameter.
10891         <~bp_location>: Add destructor.
10892         <ops>: Remove.
10893
10894 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10895             Pedro Alves  <palves@redhat.com>
10896
10897         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
10898         'PATH_MAX'.
10899
10900 2019-02-14  David Michael  <fedora.dm0@gmail.com>
10901             Samuel Thibault  <samuel.thibault@gnu.org>
10902             Thomas Schwinge  <thomas@codesourcery.com>
10903
10904         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
10905         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
10906
10907 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10908
10909         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
10910         (check_empty): Use "const char *".
10911
10912         * gnu-nat.c (gnu_nat_target::detach): Instead of
10913         'detach_inferior (pid)' call
10914         'detach_inferior (find_inferior_pid (pid))'.
10915
10916         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
10917         'nat/fork-inferior.o'.
10918         * gnu-nat.c: #include "nat/fork-inferior.h".
10919
10920         * gnu-nat.c (gnu_nat_target::detach): Instead of
10921         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
10922         * gnu-nat.h: #include "inf-child.h".
10923         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
10924         'i386_gnu_nat_target::fetch_registers'.
10925         (gnu_store_registers): Rename/move to
10926         'i386_gnu_nat_target::store_registers'.
10927
10928         * config/i386/nm-i386gnu.h: Don't "#include" any files.
10929         * gnu-nat.h (mach_thread_info): New function.
10930         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
10931
10932         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
10933
10934 2019-02-14  Frederic Konrad  <konrad@adacore.com>
10935
10936         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
10937
10938 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
10939
10940         * windows-nat.c (windows_add_thread): Add new parameter
10941         "main_thread_p" with default value set to false.  Update
10942         function documentation as well as all callers.
10943         (windows_delete_thread): Likewise.
10944         (fake_create_process): Update call to windows_add_thread.
10945         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
10946         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
10947         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
10948         call to windows_delete_thread.
10949
10950 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
10951
10952         * MAINTAINERS: Add Andrew Burgess as global maintainer.
10953
10954 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10955
10956         * symfile.c (find_separate_debug_file): Use canonical path of
10957         sysroot with child_path instead of gdb_sysroot if it is valid.
10958
10959 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10960
10961         * symfile.c (find_separate_debug_file): Use child_path to
10962         determine if an object file is under a sysroot.
10963
10964 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10965
10966         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
10967         unittests/child-path-selftests.c.
10968         * common/pathstuff.c (child_path): New function.
10969         * common/pathstuff.h (child_path): New prototype.
10970         * unittests/child-path-selftests.c: New file.
10971
10972 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10973
10974         * symfile.c (find_separate_debug_file): Look for separate debug
10975         files in debug directories under the sysroot.
10976
10977 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10978
10979         * symtab.h (struct minimal_symbol data_p): New const method.
10980         (struct minimal_symbol text_p): Likewise.
10981         * symtab.c (output_source_filename): Use file name style
10982         to print file name.
10983         (print_symbol_info): Likewise.
10984         (print_msymbol_info): Use address style to print addresses.
10985         Use function name style to print executable text symbols.
10986         (expand_symtab_containing_pc): Use data_p.
10987         (find_pc_sect_compunit_symtab): Likewise.
10988
10989 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10990
10991         * breakpoint.c (describe_other_breakpoints): Use address style
10992         to print addresses.
10993         (say_where): Likewise.
10994
10995 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10996
10997         * ada-typeprint.c (print_func_type): Print function name
10998         style to print function name.
10999         * c-typeprint.c (c_print_type_1): Likewise.
11000
11001 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
11002
11003         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
11004         for execve.
11005
11006 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11007
11008         * c-exp.y (direct_abs_decl): Use emplace_back to record the
11009         type_stack.
11010
11011 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
11012
11013         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
11014         TYPE_CODE_REF types.
11015
11016 2019-02-08  Jim Wilson  <jimw@sifive.com>
11017
11018         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
11019         (riscv_linux_fregset): New.
11020         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
11021
11022 2019-02-07  Tom Tromey  <tom@tromey.com>
11023
11024         * thread.c (thread_cancel_execution_command): Update.
11025         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
11026         methods.
11027         (struct thread_fsm_ops): Remove.
11028         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
11029         (thread_fsm_should_stop, thread_fsm_return_value)
11030         (thread_fsm_set_finished, thread_fsm_finished_p)
11031         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
11032         Don't declare.
11033         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
11034         * infrun.c (clear_proceed_status_thread)
11035         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
11036         (print_stop_event): Update.
11037         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
11038         Add constructor.
11039         (step_command_fsm_ops): Remove.
11040         (new_step_command_fsm): Remove.
11041         (step_1): Update.
11042         (step_command_fsm::should_stop): Rename from
11043         step_command_fsm_should_stop.
11044         (step_command_fsm::clean_up): Rename from
11045         step_command_fsm_clean_up.
11046         (step_command_fsm::do_async_reply_reason): Rename from
11047         step_command_fsm_async_reply_reason.
11048         (struct until_next_fsm): Inherit from thread_fsm.  Add
11049         constructor.
11050         (until_next_fsm_ops): Remove.
11051         (new_until_next_fsm): Remove.
11052         (until_next_fsm::should_stop): Rename from
11053         until_next_fsm_should_stop.
11054         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
11055         (until_next_fsm::do_async_reply_reason): Rename from
11056         until_next_fsm_async_reply_reason.
11057         (struct finish_command_fsm): Inherit from thread_fsm.  Add
11058         constructor.  Change type of breakpoint.
11059         (finish_command_fsm_ops): Remove.
11060         (new_finish_command_fsm): Remove.
11061         (finish_command_fsm::should_stop): Rename from
11062         finish_command_fsm_should_stop.
11063         (finish_command_fsm::clean_up): Rename from
11064         finish_command_fsm_clean_up.
11065         (finish_command_fsm::return_value): Rename from
11066         finish_command_fsm_return_value.
11067         (finish_command_fsm::do_async_reply_reason): Rename from
11068         finish_command_fsm_async_reply_reason.
11069         (finish_command): Update.
11070         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
11071         Add constructor.
11072         (call_thread_fsm_ops): Remove.
11073         (call_thread_fsm::call_thread_fsm): Rename from
11074         new_call_thread_fsm.
11075         (call_thread_fsm::should_stop): Rename from
11076         call_thread_fsm_should_stop.
11077         (call_thread_fsm::should_notify_stop): Rename from
11078         call_thread_fsm_should_notify_stop.
11079         (run_inferior_call, call_function_by_hand_dummy): Update.
11080         * cli/cli-interp.c (should_print_stop_to_console): Update.
11081         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
11082         Add constructor.  Change type of location_breakpoint,
11083         caller_breakpoint.
11084         (until_break_fsm_ops): Remove.
11085         (new_until_break_fsm): Remove.
11086         (until_break_fsm::should_stop): Rename from
11087         until_break_fsm_should_stop.
11088         (until_break_fsm::clean_up): Rename from
11089         until_break_fsm_clean_up.
11090         (until_break_fsm::do_async_reply_reason): Rename from
11091         until_break_fsm_async_reply_reason.
11092         (until_break_command): Update.
11093         * thread-fsm.c: Remove.
11094         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
11095
11096 2019-02-07  Tom Tromey  <tom@tromey.com>
11097
11098         * yy-remap.h: Add include guard.
11099         * xtensa-tdep.h: Add include guard.
11100         * xcoffread.h: Rename include guard.
11101         * varobj-iter.h: Add include guard.
11102         * tui/tui.h: Rename include guard.
11103         * tui/tui-winsource.h: Rename include guard.
11104         * tui/tui-wingeneral.h: Rename include guard.
11105         * tui/tui-windata.h: Rename include guard.
11106         * tui/tui-win.h: Rename include guard.
11107         * tui/tui-stack.h: Rename include guard.
11108         * tui/tui-source.h: Rename include guard.
11109         * tui/tui-regs.h: Rename include guard.
11110         * tui/tui-out.h: Rename include guard.
11111         * tui/tui-layout.h: Rename include guard.
11112         * tui/tui-io.h: Rename include guard.
11113         * tui/tui-hooks.h: Rename include guard.
11114         * tui/tui-file.h: Rename include guard.
11115         * tui/tui-disasm.h: Rename include guard.
11116         * tui/tui-data.h: Rename include guard.
11117         * tui/tui-command.h: Rename include guard.
11118         * tic6x-tdep.h: Add include guard.
11119         * target/waitstatus.h: Rename include guard.
11120         * target/wait.h: Rename include guard.
11121         * target/target.h: Rename include guard.
11122         * target/resume.h: Rename include guard.
11123         * target-float.h: Rename include guard.
11124         * stabsread.h: Add include guard.
11125         * rs6000-tdep.h: Add include guard.
11126         * riscv-fbsd-tdep.h: Add include guard.
11127         * regformats/regdef.h: Rename include guard.
11128         * record.h: Rename include guard.
11129         * python/python.h: Rename include guard.
11130         * python/python-internal.h: Rename include guard.
11131         * python/py-stopevent.h: Rename include guard.
11132         * python/py-ref.h: Rename include guard.
11133         * python/py-record.h: Rename include guard.
11134         * python/py-record-full.h: Rename include guard.
11135         * python/py-record-btrace.h: Rename include guard.
11136         * python/py-instruction.h: Rename include guard.
11137         * python/py-events.h: Rename include guard.
11138         * python/py-event.h: Rename include guard.
11139         * procfs.h: Add include guard.
11140         * proc-utils.h: Add include guard.
11141         * p-lang.h: Add include guard.
11142         * or1k-tdep.h: Rename include guard.
11143         * observable.h: Rename include guard.
11144         * nto-tdep.h: Rename include guard.
11145         * nat/x86-linux.h: Rename include guard.
11146         * nat/x86-linux-dregs.h: Rename include guard.
11147         * nat/x86-gcc-cpuid.h: Add include guard.
11148         * nat/x86-dregs.h: Rename include guard.
11149         * nat/x86-cpuid.h: Rename include guard.
11150         * nat/ppc-linux.h: Rename include guard.
11151         * nat/mips-linux-watch.h: Rename include guard.
11152         * nat/linux-waitpid.h: Rename include guard.
11153         * nat/linux-ptrace.h: Rename include guard.
11154         * nat/linux-procfs.h: Rename include guard.
11155         * nat/linux-osdata.h: Rename include guard.
11156         * nat/linux-nat.h: Rename include guard.
11157         * nat/linux-namespaces.h: Rename include guard.
11158         * nat/linux-btrace.h: Rename include guard.
11159         * nat/glibc_thread_db.h: Rename include guard.
11160         * nat/gdb_thread_db.h: Rename include guard.
11161         * nat/gdb_ptrace.h: Rename include guard.
11162         * nat/fork-inferior.h: Rename include guard.
11163         * nat/amd64-linux-siginfo.h: Rename include guard.
11164         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
11165         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
11166         * nat/aarch64-linux.h: Rename include guard.
11167         * nat/aarch64-linux-hw-point.h: Rename include guard.
11168         * mn10300-tdep.h: Add include guard.
11169         * mips-linux-tdep.h: Add include guard.
11170         * mi/mi-parse.h: Rename include guard.
11171         * mi/mi-out.h: Rename include guard.
11172         * mi/mi-main.h: Rename include guard.
11173         * mi/mi-interp.h: Rename include guard.
11174         * mi/mi-getopt.h: Rename include guard.
11175         * mi/mi-console.h: Rename include guard.
11176         * mi/mi-common.h: Rename include guard.
11177         * mi/mi-cmds.h: Rename include guard.
11178         * mi/mi-cmd-break.h: Rename include guard.
11179         * m2-lang.h: Add include guard.
11180         * location.h: Rename include guard.
11181         * linux-record.h: Rename include guard.
11182         * linux-nat.h: Add include guard.
11183         * linux-fork.h: Add include guard.
11184         * i386-darwin-tdep.h: Rename include guard.
11185         * hppa-linux-offsets.h: Add include guard.
11186         * guile/guile.h: Rename include guard.
11187         * guile/guile-internal.h: Rename include guard.
11188         * gnu-nat.h: Rename include guard.
11189         * gdb-stabs.h: Rename include guard.
11190         * frv-tdep.h: Add include guard.
11191         * f-lang.h: Add include guard.
11192         * event-loop.h: Add include guard.
11193         * darwin-nat.h: Rename include guard.
11194         * cp-abi.h: Rename include guard.
11195         * config/sparc/nm-sol2.h: Rename include guard.
11196         * config/nm-nto.h: Rename include guard.
11197         * config/nm-linux.h: Add include guard.
11198         * config/i386/nm-i386gnu.h: Rename include guard.
11199         * config/djgpp/nl_types.h: Rename include guard.
11200         * config/djgpp/langinfo.h: Rename include guard.
11201         * compile/gcc-cp-plugin.h: Add include guard.
11202         * compile/gcc-c-plugin.h: Add include guard.
11203         * compile/compile.h: Rename include guard.
11204         * compile/compile-object-run.h: Rename include guard.
11205         * compile/compile-object-load.h: Rename include guard.
11206         * compile/compile-internal.h: Rename include guard.
11207         * compile/compile-cplus.h: Rename include guard.
11208         * compile/compile-c.h: Rename include guard.
11209         * common/xml-utils.h: Rename include guard.
11210         * common/x86-xstate.h: Rename include guard.
11211         * common/version.h: Rename include guard.
11212         * common/vec.h: Rename include guard.
11213         * common/tdesc.h: Rename include guard.
11214         * common/selftest.h: Rename include guard.
11215         * common/scoped_restore.h: Rename include guard.
11216         * common/scoped_mmap.h: Rename include guard.
11217         * common/scoped_fd.h: Rename include guard.
11218         * common/safe-iterator.h: Rename include guard.
11219         * common/run-time-clock.h: Rename include guard.
11220         * common/refcounted-object.h: Rename include guard.
11221         * common/queue.h: Rename include guard.
11222         * common/ptid.h: Rename include guard.
11223         * common/print-utils.h: Rename include guard.
11224         * common/preprocessor.h: Rename include guard.
11225         * common/pathstuff.h: Rename include guard.
11226         * common/observable.h: Rename include guard.
11227         * common/netstuff.h: Rename include guard.
11228         * common/job-control.h: Rename include guard.
11229         * common/host-defs.h: Rename include guard.
11230         * common/gdb_wait.h: Rename include guard.
11231         * common/gdb_vecs.h: Rename include guard.
11232         * common/gdb_unlinker.h: Rename include guard.
11233         * common/gdb_unique_ptr.h: Rename include guard.
11234         * common/gdb_tilde_expand.h: Rename include guard.
11235         * common/gdb_sys_time.h: Rename include guard.
11236         * common/gdb_string_view.h: Rename include guard.
11237         * common/gdb_splay_tree.h: Rename include guard.
11238         * common/gdb_setjmp.h: Rename include guard.
11239         * common/gdb_ref_ptr.h: Rename include guard.
11240         * common/gdb_optional.h: Rename include guard.
11241         * common/gdb_locale.h: Rename include guard.
11242         * common/gdb_assert.h: Rename include guard.
11243         * common/filtered-iterator.h: Rename include guard.
11244         * common/filestuff.h: Rename include guard.
11245         * common/fileio.h: Rename include guard.
11246         * common/environ.h: Rename include guard.
11247         * common/common-utils.h: Rename include guard.
11248         * common/common-types.h: Rename include guard.
11249         * common/common-regcache.h: Rename include guard.
11250         * common/common-inferior.h: Rename include guard.
11251         * common/common-gdbthread.h: Rename include guard.
11252         * common/common-exceptions.h: Rename include guard.
11253         * common/common-defs.h: Rename include guard.
11254         * common/common-debug.h: Rename include guard.
11255         * common/cleanups.h: Rename include guard.
11256         * common/buffer.h: Rename include guard.
11257         * common/btrace-common.h: Rename include guard.
11258         * common/break-common.h: Rename include guard.
11259         * cli/cli-utils.h: Rename include guard.
11260         * cli/cli-style.h: Rename include guard.
11261         * cli/cli-setshow.h: Rename include guard.
11262         * cli/cli-script.h: Rename include guard.
11263         * cli/cli-interp.h: Rename include guard.
11264         * cli/cli-decode.h: Rename include guard.
11265         * cli/cli-cmds.h: Rename include guard.
11266         * charset-list.h: Add include guard.
11267         * buildsym-legacy.h: Rename include guard.
11268         * bfin-tdep.h: Add include guard.
11269         * ax.h: Rename include guard.
11270         * arm-linux-tdep.h: Add include guard.
11271         * arm-fbsd-tdep.h: Add include guard.
11272         * arch/xtensa.h: Rename include guard.
11273         * arch/tic6x.h: Add include guard.
11274         * arch/i386.h: Add include guard.
11275         * arch/arm.h: Rename include guard.
11276         * arch/arm-linux.h: Rename include guard.
11277         * arch/arm-get-next-pcs.h: Rename include guard.
11278         * arch/amd64.h: Add include guard.
11279         * arch/aarch64-insn.h: Rename include guard.
11280         * arch-utils.h: Rename include guard.
11281         * annotate.h: Add include guard.
11282         * amd64-darwin-tdep.h: Rename include guard.
11283         * aarch64-linux-tdep.h: Add include guard.
11284         * aarch64-fbsd-tdep.h: Add include guard.
11285         * aarch32-linux-nat.h: Add include guard.
11286
11287 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11288
11289         * macrotab.c (macro_define_internal): New function that
11290         factorizes macro_define_object_internal and macro_define_function
11291         code.
11292         (macro_define_object_internal): Use macro_define_internal.
11293         (macro_define_function): Likewise.
11294
11295 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11296
11297         * macrocmd.c (extract_identifier): Return
11298         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
11299         callers.
11300
11301 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
11302
11303         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
11304
11305 2019-02-05  Tom Tromey  <tom@tromey.com>
11306
11307         * target.c (target_stack::unpush): Move assertion earlier.
11308
11309 2019-01-30  Tom Tromey  <tom@tromey.com>
11310
11311         PR python/23615:
11312         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
11313         (gdbpy_parse_and_eval): Likewise.
11314         * python/python-internal.h (gdbpy_allow_threads): New class.
11315
11316 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
11317
11318         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
11319         (aarch64_fbsd_fpregmap): Move earlier.
11320         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
11321         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11322         instead of individual calls to trad_frame_set_reg_addr.
11323         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
11324         earlier.
11325         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
11326         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11327         instead of individual calls to trad_frame_set_reg_addr.
11328
11329 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
11330
11331         * CONTRIBUTE: Replace contribution list with wiki link.
11332
11333 2019-01-25  Tom Tromey  <tom@tromey.com>
11334
11335         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
11336
11337 2019-01-25  Tom Tromey  <tom@tromey.com>
11338
11339         * xtensa-linux-nat.c: Fix common/ includes.
11340         * xml-support.h: Fix common/ includes.
11341         * xml-support.c: Fix common/ includes.
11342         * x86-linux-nat.c: Fix common/ includes.
11343         * windows-nat.c: Fix common/ includes.
11344         * varobj.h: Fix common/ includes.
11345         * varobj.c: Fix common/ includes.
11346         * value.c: Fix common/ includes.
11347         * valops.c: Fix common/ includes.
11348         * utils.c: Fix common/ includes.
11349         * unittests/xml-utils-selftests.c: Fix common/ includes.
11350         * unittests/utils-selftests.c: Fix common/ includes.
11351         * unittests/unpack-selftests.c: Fix common/ includes.
11352         * unittests/tracepoint-selftests.c: Fix common/ includes.
11353         * unittests/style-selftests.c: Fix common/ includes.
11354         * unittests/string_view-selftests.c: Fix common/ includes.
11355         * unittests/scoped_restore-selftests.c: Fix common/ includes.
11356         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
11357         * unittests/scoped_fd-selftests.c: Fix common/ includes.
11358         * unittests/rsp-low-selftests.c: Fix common/ includes.
11359         * unittests/parse-connection-spec-selftests.c: Fix common/
11360         includes.
11361         * unittests/optional-selftests.c: Fix common/ includes.
11362         * unittests/offset-type-selftests.c: Fix common/ includes.
11363         * unittests/observable-selftests.c: Fix common/ includes.
11364         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
11365         * unittests/memrange-selftests.c: Fix common/ includes.
11366         * unittests/memory-map-selftests.c: Fix common/ includes.
11367         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
11368         * unittests/function-view-selftests.c: Fix common/ includes.
11369         * unittests/environ-selftests.c: Fix common/ includes.
11370         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
11371         * unittests/common-utils-selftests.c: Fix common/ includes.
11372         * unittests/cli-utils-selftests.c: Fix common/ includes.
11373         * unittests/array-view-selftests.c: Fix common/ includes.
11374         * ui-file.c: Fix common/ includes.
11375         * tui/tui-io.c: Fix common/ includes.
11376         * tracepoint.h: Fix common/ includes.
11377         * tracepoint.c: Fix common/ includes.
11378         * tracefile-tfile.c: Fix common/ includes.
11379         * top.h: Fix common/ includes.
11380         * top.c: Fix common/ includes.
11381         * thread.c: Fix common/ includes.
11382         * target/waitstatus.h: Fix common/ includes.
11383         * target/waitstatus.c: Fix common/ includes.
11384         * target.h: Fix common/ includes.
11385         * target.c: Fix common/ includes.
11386         * target-memory.c: Fix common/ includes.
11387         * target-descriptions.c: Fix common/ includes.
11388         * symtab.h: Fix common/ includes.
11389         * symfile.c: Fix common/ includes.
11390         * stap-probe.c: Fix common/ includes.
11391         * spu-linux-nat.c: Fix common/ includes.
11392         * sparc-nat.c: Fix common/ includes.
11393         * source.c: Fix common/ includes.
11394         * solib.c: Fix common/ includes.
11395         * solib-target.c: Fix common/ includes.
11396         * ser-unix.c: Fix common/ includes.
11397         * ser-tcp.c: Fix common/ includes.
11398         * ser-pipe.c: Fix common/ includes.
11399         * ser-base.c: Fix common/ includes.
11400         * selftest-arch.c: Fix common/ includes.
11401         * s12z-tdep.c: Fix common/ includes.
11402         * rust-exp.y: Fix common/ includes.
11403         * rs6000-aix-tdep.c: Fix common/ includes.
11404         * riscv-tdep.c: Fix common/ includes.
11405         * remote.c: Fix common/ includes.
11406         * remote-notif.h: Fix common/ includes.
11407         * remote-fileio.h: Fix common/ includes.
11408         * remote-fileio.c: Fix common/ includes.
11409         * regcache.h: Fix common/ includes.
11410         * regcache.c: Fix common/ includes.
11411         * record-btrace.c: Fix common/ includes.
11412         * python/python.c: Fix common/ includes.
11413         * python/py-type.c: Fix common/ includes.
11414         * python/py-inferior.c: Fix common/ includes.
11415         * progspace.h: Fix common/ includes.
11416         * producer.c: Fix common/ includes.
11417         * procfs.c: Fix common/ includes.
11418         * proc-api.c: Fix common/ includes.
11419         * printcmd.c: Fix common/ includes.
11420         * ppc-linux-nat.c: Fix common/ includes.
11421         * parser-defs.h: Fix common/ includes.
11422         * osdata.c: Fix common/ includes.
11423         * obsd-nat.c: Fix common/ includes.
11424         * nat/x86-linux.c: Fix common/ includes.
11425         * nat/x86-linux-dregs.c: Fix common/ includes.
11426         * nat/x86-dregs.h: Fix common/ includes.
11427         * nat/x86-dregs.c: Fix common/ includes.
11428         * nat/ppc-linux.c: Fix common/ includes.
11429         * nat/mips-linux-watch.h: Fix common/ includes.
11430         * nat/mips-linux-watch.c: Fix common/ includes.
11431         * nat/linux-waitpid.c: Fix common/ includes.
11432         * nat/linux-ptrace.h: Fix common/ includes.
11433         * nat/linux-ptrace.c: Fix common/ includes.
11434         * nat/linux-procfs.c: Fix common/ includes.
11435         * nat/linux-personality.c: Fix common/ includes.
11436         * nat/linux-osdata.c: Fix common/ includes.
11437         * nat/linux-namespaces.c: Fix common/ includes.
11438         * nat/linux-btrace.h: Fix common/ includes.
11439         * nat/linux-btrace.c: Fix common/ includes.
11440         * nat/fork-inferior.c: Fix common/ includes.
11441         * nat/amd64-linux-siginfo.c: Fix common/ includes.
11442         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
11443         * nat/aarch64-linux.c: Fix common/ includes.
11444         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
11445         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
11446         * namespace.h: Fix common/ includes.
11447         * mips-linux-tdep.c: Fix common/ includes.
11448         * minsyms.c: Fix common/ includes.
11449         * mi/mi-parse.h: Fix common/ includes.
11450         * mi/mi-main.c: Fix common/ includes.
11451         * mi/mi-cmd-env.c: Fix common/ includes.
11452         * memrange.h: Fix common/ includes.
11453         * memattr.c: Fix common/ includes.
11454         * maint.h: Fix common/ includes.
11455         * maint.c: Fix common/ includes.
11456         * main.c: Fix common/ includes.
11457         * machoread.c: Fix common/ includes.
11458         * location.c: Fix common/ includes.
11459         * linux-thread-db.c: Fix common/ includes.
11460         * linux-nat.c: Fix common/ includes.
11461         * linux-fork.c: Fix common/ includes.
11462         * inline-frame.c: Fix common/ includes.
11463         * infrun.c: Fix common/ includes.
11464         * inflow.c: Fix common/ includes.
11465         * inferior.h: Fix common/ includes.
11466         * inferior.c: Fix common/ includes.
11467         * infcmd.c: Fix common/ includes.
11468         * inf-ptrace.c: Fix common/ includes.
11469         * inf-child.c: Fix common/ includes.
11470         * ia64-linux-nat.c: Fix common/ includes.
11471         * i387-tdep.c: Fix common/ includes.
11472         * i386-tdep.c: Fix common/ includes.
11473         * i386-linux-tdep.c: Fix common/ includes.
11474         * i386-linux-nat.c: Fix common/ includes.
11475         * i386-go32-tdep.c: Fix common/ includes.
11476         * i386-fbsd-tdep.c: Fix common/ includes.
11477         * i386-fbsd-nat.c: Fix common/ includes.
11478         * guile/scm-type.c: Fix common/ includes.
11479         * guile/guile.c: Fix common/ includes.
11480         * go32-nat.c: Fix common/ includes.
11481         * gnu-nat.c: Fix common/ includes.
11482         * gdbthread.h: Fix common/ includes.
11483         * gdbarch-selftests.c: Fix common/ includes.
11484         * gdb_usleep.c: Fix common/ includes.
11485         * gdb_select.h: Fix common/ includes.
11486         * gdb_bfd.c: Fix common/ includes.
11487         * gcore.c: Fix common/ includes.
11488         * fork-child.c: Fix common/ includes.
11489         * findvar.c: Fix common/ includes.
11490         * fbsd-nat.c: Fix common/ includes.
11491         * event-top.c: Fix common/ includes.
11492         * event-loop.c: Fix common/ includes.
11493         * dwarf2read.c: Fix common/ includes.
11494         * dwarf2loc.c: Fix common/ includes.
11495         * dwarf2-frame.c: Fix common/ includes.
11496         * dwarf-index-cache.c: Fix common/ includes.
11497         * dtrace-probe.c: Fix common/ includes.
11498         * disasm-selftests.c: Fix common/ includes.
11499         * defs.h: Fix common/ includes.
11500         * csky-tdep.c: Fix common/ includes.
11501         * cp-valprint.c: Fix common/ includes.
11502         * cp-support.h: Fix common/ includes.
11503         * cp-support.c: Fix common/ includes.
11504         * corelow.c: Fix common/ includes.
11505         * completer.h: Fix common/ includes.
11506         * completer.c: Fix common/ includes.
11507         * compile/compile.c: Fix common/ includes.
11508         * compile/compile-loc2c.c: Fix common/ includes.
11509         * compile/compile-cplus-types.c: Fix common/ includes.
11510         * compile/compile-cplus-symbols.c: Fix common/ includes.
11511         * command.h: Fix common/ includes.
11512         * cli/cli-dump.c: Fix common/ includes.
11513         * cli/cli-cmds.c: Fix common/ includes.
11514         * charset.c: Fix common/ includes.
11515         * build-id.c: Fix common/ includes.
11516         * btrace.h: Fix common/ includes.
11517         * btrace.c: Fix common/ includes.
11518         * breakpoint.h: Fix common/ includes.
11519         * breakpoint.c: Fix common/ includes.
11520         * ax.h:
11521         (enum agent_op): Fix common/ includes.
11522         * ax-general.c (struct aop_map): Fix common/ includes.
11523         * ax-gdb.c: Fix common/ includes.
11524         * auxv.c: Fix common/ includes.
11525         * auto-load.c: Fix common/ includes.
11526         * arm-tdep.c: Fix common/ includes.
11527         * arch/riscv.c: Fix common/ includes.
11528         * arch/ppc-linux-common.c: Fix common/ includes.
11529         * arch/i386.c: Fix common/ includes.
11530         * arch/arm.c: Fix common/ includes.
11531         * arch/arm-linux.c: Fix common/ includes.
11532         * arch/arm-get-next-pcs.c: Fix common/ includes.
11533         * arch/amd64.c: Fix common/ includes.
11534         * arch/aarch64.c: Fix common/ includes.
11535         * arch/aarch64-insn.c: Fix common/ includes.
11536         * arch-utils.c: Fix common/ includes.
11537         * amd64-windows-tdep.c: Fix common/ includes.
11538         * amd64-tdep.c: Fix common/ includes.
11539         * amd64-sol2-tdep.c: Fix common/ includes.
11540         * amd64-obsd-tdep.c: Fix common/ includes.
11541         * amd64-nbsd-tdep.c: Fix common/ includes.
11542         * amd64-linux-tdep.c: Fix common/ includes.
11543         * amd64-linux-nat.c: Fix common/ includes.
11544         * amd64-fbsd-tdep.c: Fix common/ includes.
11545         * amd64-fbsd-nat.c: Fix common/ includes.
11546         * amd64-dicos-tdep.c: Fix common/ includes.
11547         * amd64-darwin-tdep.c: Fix common/ includes.
11548         * agent.c: Fix common/ includes.
11549         * ada-lang.h: Fix common/ includes.
11550         * ada-lang.c: Fix common/ includes.
11551         * aarch64-tdep.c: Fix common/ includes.
11552
11553 2019-01-25  Tom Tromey  <tom@tromey.com>
11554
11555         * common/create-version.sh: Use common/version.h.
11556
11557 2019-01-24  Pedro Alves  <palves@redhat.com>
11558
11559         * infrun.c (signal_stop, signal_print, signal_program)
11560         (signal_catch, signal_pass): Now arrays instead of pointers.
11561         (update_signals_program_target, do_target_resume)
11562         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
11563         * linux-nat.c (linux_nat_target::pass_signals)
11564         (linux_nat_target::create_inferior, linux_nat_target::attach):
11565         Adjust.
11566         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
11567         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
11568         * procfs.c (procfs_target::pass_signals): Adjust.
11569         * record-full.c (record_full_target::resume): Adjust.
11570         * remote.c (remote_target::pass_signals)
11571         (remote_target::program_signals): Adjust.
11572         * target-debug.h (target_debug_print_signals): Now takes a
11573         gdb::array_view as parameter.  Adjust.
11574         * target.h (target_ops) <pass_signals, program_signals>: Replace
11575         pointer and length parameters with gdb::array_view.
11576         (target_pass_signals, target_program_signals): Likewise.
11577         * target-delegates.c: Regenerate.
11578
11579 2019-01-24  Pedro Alves  <palves@redhat.com>
11580
11581         * common/forward-scope-exit.h
11582         (forward_scope_exit::forward_scope_exit): Pass arguments to
11583         m_bind_function directly, instead of creating a std::bind and
11584         copying that.
11585
11586 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
11587
11588         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11589         for static members.
11590         (pass_in_v_vfp_candidate): Likewise.
11591
11592 2019-01-23  Tom Tromey  <tom@tromey.com>
11593             Pedro Alves  <palves@redhat.com>
11594
11595         * regcache.c (class regcache_invalidator): Remove.
11596         (regcache::raw_write): Use make_scope_exit.
11597
11598 2019-01-23  Tom Tromey  <tom@tromey.com>
11599
11600         * ui-out.h (class ui_out_emit_type): Update comment.
11601
11602 2019-01-23  Tom Tromey  <tom@tromey.com>
11603
11604         * infrun.c (fetch_inferior_event): Update comment.
11605
11606 2019-01-23  Tom Tromey  <tom@tromey.com>
11607             Pedro Alves  <palves@redhat.com>
11608
11609         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
11610         parameter.
11611         (fetch_inferior_event): Use SCOPE_EXIT.
11612
11613
11614 2019-01-23  Tom Tromey  <tom@tromey.com>
11615             Pedro Alves  <palves@redhat.com>
11616
11617         * infrun.c (disable_thread_events): Delete.
11618         (stop_all_threads): Use SCOPE_EXIT.
11619
11620 2019-01-23  Tom Tromey  <tom@tromey.com>
11621             Pedro Alves  <palves@redhat.com>
11622
11623         * symfile.c: Include forward-scope-exit.h.
11624         (clear_symtab_users_cleanup): Replace forward declaration with
11625         a FORWARD_SCOPE_EXIT.
11626         (syms_from_objfile_1): Use the forward_scope_exit and
11627         gdb::optional instead of cleanup_function.
11628         (reread_symbols): Use the forward_scope_exit instead of
11629         cleanup_function.
11630         (clear_symtab_users_cleanup): Remove function.
11631
11632 2019-01-23  Tom Tromey  <tom@tromey.com>
11633             Pedro Alves  <palves@redhat.com>
11634
11635         * linux-nat.c: Include scope-exit.h.
11636         (cleanup_target_stop): Remove.
11637         (linux_nat_target::static_tracepoint_markers_by_strid): Use
11638         SCOPE_EXIT.
11639
11640 2019-01-23  Tom Tromey  <tom@tromey.com>
11641             Pedro Alves  <palves@redhat.com>
11642
11643         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
11644         (call_function_by_hand_dummy): Use SCOPE_EXIT.
11645
11646 2019-01-23  Tom Tromey  <tom@tromey.com>
11647             Andrew Burgess  <andrew.burgess@embecosm.com>
11648             Pedro Alves  <palves@redhat.com>
11649
11650         * infrun.c (fetch_inferior_event): Use scope_exit.
11651         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
11652         * top.c (execute_command): Use scope_exit.
11653         * breakpoint.c (bpstat_do_actions): Use scope_exit.
11654         * utils.c (do_bpstat_clear_actions_cleanup)
11655         (make_bpstat_clear_actions_cleanup): Remove.
11656
11657 2019-01-23  Tom Tromey  <tom@tromey.com>
11658             Pedro Alves  <palves@redhat.com>
11659
11660         * infrun.c: Include "common/scope-exit.h"
11661         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
11662         (wait_for_inferior): Use SCOPE_EXIT.
11663         (fetch_inferior_event): Use scope_exit.
11664
11665 2019-01-23  Tom Tromey  <tom@tromey.com>
11666             Pedro Alves  <palves@redhat.com>
11667
11668         * breakpoint.c (create_breakpoint): Remove cleanup.
11669
11670 2019-01-23  Tom Tromey  <tom@tromey.com>
11671             Andrew Burgess  <andrew.burgess@embecosm.com>
11672             Pedro Alves  <palves@redhat.com>
11673
11674 2019-01-23  Pedro Alves  <palves@redhat.com>
11675
11676         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
11677
11678 2019-01-23  Pedro Alves  <palves@redhat.com>
11679             Andrew Burgess  <andrew.burgess@embecosm.com>
11680
11681         * gdbthread.h: Include "common/forward-scope-exit.h".
11682         (scoped_finish_thread_state): Redefine custom class in terms of
11683         forward_scope_exit.
11684
11685 2019-01-23  Pedro Alves  <palves@redhat.com>
11686             Andrew Burgess  <andrew.burgess@embecosm.com>
11687
11688         * common/forward-scope-exit.h: New file.
11689
11690 2019-01-23  Pedro Alves  <palves@redhat.com>
11691             Andrew Burgess  <andrew.burgess@embecosm.com>
11692             Tom Tromey  <tom@tromey.com>
11693
11694         * common/scope-exit.h: New file.
11695
11696 2019-01-23  Pedro Alves  <palves@redhat.com>
11697
11698         * common/preprocessor.h (ESC): Rename to ...
11699         (ESC_PARENS): ... this.
11700         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
11701         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
11702
11703 2019-01-23  Tom Tromey  <tom@tromey.com>
11704
11705         * language.h (class scoped_switch_to_sym_language_if_auto):
11706         Initialize m_lang in both cases.
11707
11708 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
11709
11710         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
11711         with XCNEW.
11712
11713 2019-01-22  Tom Tromey  <tom@tromey.com>
11714
11715         * corelow.c: Do not include sys/file.h.
11716
11717 2019-01-22  Tom Tromey  <tom@tromey.com>
11718
11719         * tui/tui-wingeneral.h: Include gdb_curses.h.
11720
11721 2019-01-22  Tom Tromey  <tom@tromey.com>
11722
11723         * source-cache.h (class source_cache) <get_source_lines,
11724         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
11725
11726 2019-01-22  Tom Tromey  <tom@tromey.com>
11727
11728         * remote-fileio.h (struct remote_target): Declare.
11729
11730 2019-01-22  Tom Tromey  <tom@tromey.com>
11731
11732         * python/py-arch.c: Do not include py-ref.h.
11733         * python/py-bpevent.c: Do not include py-ref.h.
11734         * python/py-cmd.c: Do not include py-ref.h.
11735         * python/py-continueevent.c: Do not include py-ref.h.
11736         * python/py-event.h: Do not include py-ref.h.
11737         * python/py-evtregistry.c: Do not include py-ref.h.
11738         * python/py-finishbreakpoint.c: Do not include py-ref.h.
11739         * python/py-frame.c: Do not include py-ref.h.
11740         * python/py-framefilter.c: Do not include py-ref.h.
11741         * python/py-function.c: Do not include py-ref.h.
11742         * python/py-infevents.c: Do not include py-ref.h.
11743         * python/py-linetable.c: Do not include py-ref.h.
11744         * python/py-objfile.c: Do not include py-ref.h.
11745         * python/py-param.c: Do not include py-ref.h.
11746         * python/py-prettyprint.c: Do not include py-ref.h.
11747         * python/py-progspace.c: Do not include py-ref.h.
11748         * python/py-symbol.c: Do not include py-ref.h.
11749         * python/py-symtab.c: Do not include py-ref.h.
11750         * python/py-type.c: Do not include py-ref.h.
11751         * python/py-unwind.c: Do not include py-ref.h.
11752         * python/py-utils.c: Do not include py-ref.h.
11753         * python/py-value.c: Do not include py-ref.h.
11754         * python/py-varobj.c: Do not include py-ref.h.
11755         * python/py-xmethods.c: Do not include py-ref.h.
11756         * python/python.c: Do not include py-ref.h.
11757         * varobj.c: Do not include py-ref.h.
11758
11759 2019-01-22  Tom Tromey  <tom@tromey.com>
11760
11761         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
11762         keyword for bcache.
11763
11764 2019-01-22  Tom Tromey  <tom@tromey.com>
11765
11766         * compile/compile-cplus-types.c: Remove a comment by #include.
11767
11768 2019-01-22  Tom Tromey  <tom@tromey.com>
11769
11770         * compile/gcc-c-plugin.h: Include compile-internal.h.
11771
11772 2019-01-22  Tom Tromey  <tom@tromey.com>
11773
11774         * stabsread.c (EXTERN): Do not define.
11775         (symnum, next_symbol_text_func, processing_gcc_compilation)
11776         (within_function, global_sym_chain, global_stabs)
11777         (previous_stab_code, this_object_header_files)
11778         (n_this_object_header_files)
11779         (n_allocated_this_object_header_files): Define.
11780         * stabsread.h (EXTERN): Never define.  Use "extern".
11781
11782 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11783
11784         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
11785         history_value.
11786
11787 2019-01-21  Tom Tromey  <tom@tromey.com>
11788
11789         * ui-out.c: Fix includes.
11790         * tui/tui-source.c: Fix includes.
11791         * target.c: Fix includes.
11792         * remote.c: Fix includes.
11793         * regcache.c: Fix includes.
11794         * python/py-block.c: Fix includes.
11795         * printcmd.c: Fix includes.
11796         * or1k-tdep.c: Fix includes.
11797         * mi/mi-main.c: Fix includes.
11798         * m32r-tdep.c: Fix includes.
11799         * csky-tdep.c: Fix includes.
11800         * compile/compile-cplus-types.c: Fix includes.
11801         * cli/cli-interp.c: Fix includes.
11802
11803 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
11804
11805         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11806         for padding.
11807
11808 2019-01-16  Tom Tromey  <tom@tromey.com>
11809
11810         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
11811         earlier.
11812         (struct objfile) <msymbols_range>: Move from top level.
11813         <msymbols>: New method.
11814         (class objfile_msymbols): Remove.
11815         * symtab.c (default_collect_symbol_completion_matches_break_on):
11816         Update.
11817         * symmisc.c (dump_msymbols): Update.
11818         * stabsread.c (scan_file_globals): Update.
11819         * objc-lang.c (info_selectors_command, info_classes_command)
11820         (find_methods): Update.
11821         * minsyms.c (find_solib_trampoline_target): Update.
11822         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
11823         * coffread.c (coff_symfile_read): Update.
11824         * ada-lang.c (ada_lookup_simple_minsym)
11825         (ada_collect_symbol_completion_matches): Update.
11826
11827 2019-01-16  Tom Tromey  <tom@tromey.com>
11828
11829         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
11830         type.  Remove no-argument constructor.
11831         <iterator::operator++>: Simplify.
11832         <begin>: Update.
11833         <end>: Use minimal_symbol_count.
11834
11835 2019-01-16  Tom Tromey  <tom@tromey.com>
11836
11837         * objfiles.h (struct objfile) <psymtabs>: New method.
11838         (class objfile_psymtabs): Remove.
11839         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
11840         typedef.
11841         <range>: New method.
11842         (require_partial_symbols): Change return type.
11843         * psymtab.c (require_partial_symbols)
11844         (psym_expand_symtabs_matching): Update.
11845         * mdebugread.c (parse_partial_symbols): Update.
11846         * dbxread.c (dbx_end_psymtab): Update.
11847
11848 2019-01-15  Tom Tromey  <tom@tromey.com>
11849
11850         * symtab.c (lookup_objfile_from_block)
11851         (lookup_symbol_in_objfile_symtabs)
11852         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
11853         (find_line_symtab, info_sources_command)
11854         (default_collect_symbol_completion_matches_break_on)
11855         (make_source_files_completion_list): Update.
11856         * symmisc.c (print_objfile_statistics, dump_objfile)
11857         (maintenance_print_symbols, maintenance_info_symtabs)
11858         (maintenance_check_symtabs, maintenance_info_line_tables):
11859         Update.
11860         * source.c (select_source_symtab)
11861         (forget_cached_source_info_for_objfile): Update.
11862         * objfiles.h (class objfile_compunits): Remove.
11863         (struct objfile) <compunits_range>: New typedef.
11864         (compunits): New method.
11865         * objfiles.c (objfile_relocate1): Update.
11866         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11867         * maint.c (count_symtabs_and_blocks): Update.
11868         * linespec.c (iterate_over_all_matching_symtabs): Update.
11869         * cp-support.c (add_symbol_overload_list_qualified): Update.
11870         * coffread.c (coff_symtab_read): Update.
11871         * ada-lang.c (add_nonlocal_symbols)
11872         (ada_collect_symbol_completion_matches)
11873         (ada_add_global_exceptions): Update.
11874
11875 2019-01-15  Tom Tromey  <tom@tromey.com>
11876
11877         * progspace.h (program_space) <objfiles_safe_range>: New
11878         typedef.
11879         <objfiles_safe>: New method.
11880         * objfiles.h (class all_objfiles_safe): Remove.
11881         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
11882         * jit.c (jit_inferior_exit_hook): Update.
11883
11884 2019-01-17  Tom Tromey  <tom@tromey.com>
11885
11886         * progspace.h (program_space) <objfiles_range>: New typedef.
11887         <objfiles>: New method.
11888         <objfiles_head>: Rename from objfiles.
11889         (object_files): Update.
11890         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
11891         * guile/scm-pretty-print.c
11892         (ppscm_find_pretty_printer_from_objfiles): Update.
11893         * guile/scm-objfile.c (gdbscm_objfiles): Update.
11894         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
11895         Update.
11896         * python/py-progspace.c (pspy_get_objfiles): Update.
11897         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11898         Update.
11899         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11900         (objfpy_lookup_objfile_by_build_id): Update.
11901         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11902         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11903         Update.
11904         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11905         (expand_symtab_containing_pc, lookup_objfile_from_block)
11906         (lookup_static_symbol, basic_lookup_transparent_type)
11907         (find_pc_sect_compunit_symtab, find_symbol_at_address)
11908         (find_line_symtab, info_sources_command)
11909         (default_collect_symbol_completion_matches_break_on)
11910         (make_source_files_completion_list, find_main_name): Update.
11911         * symmisc.c (print_symbol_bcache_statistics)
11912         (print_objfile_statistics, maintenance_print_symbols)
11913         (maintenance_print_msymbols, maintenance_print_objfiles)
11914         (maintenance_info_symtabs, maintenance_check_symtabs)
11915         (maintenance_expand_symtabs, maintenance_info_line_tables):
11916         Update.
11917         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
11918         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
11919         (map_overlay_command, unmap_overlay_command)
11920         (simple_overlay_update, expand_symtabs_matching)
11921         (map_symbol_filenames): Update.
11922         * symfile-debug.c (set_debug_symfile): Update.
11923         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
11924         Update.
11925         * source.c (select_source_symtab, forget_cached_source_info):
11926         Update.
11927         * solib.c (solib_read_symbols): Update.
11928         * solib-spu.c (append_ocl_sos): Update.
11929         * psymtab.c (maintenance_print_psymbols)
11930         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
11931         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
11932         * printcmd.c (info_symbol_command): Update.
11933         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
11934         Update.
11935         * objfiles.h (class all_objfiles): Remove.
11936         * objfiles.c (have_partial_symbols, have_full_symbols)
11937         (have_minimal_symbols, qsort_cmp, update_section_map)
11938         (shared_objfile_contains_address_p)
11939         (default_iterate_over_objfiles_in_search_order): Update.
11940         * objc-lang.c (info_selectors_command, info_classes_command)
11941         (find_methods): Update.
11942         * minsyms.c (find_solib_trampoline_target): Update.
11943         * maint.c (maintenance_info_sections)
11944         (maintenance_translate_address, count_symtabs_and_blocks):
11945         Update.
11946         * main.c (captured_main_1): Update.
11947         * linux-thread-db.c (try_thread_db_load_from_pdir)
11948         (has_libpthread): Update.
11949         * linespec.c (iterate_over_all_matching_symtabs)
11950         (search_minsyms_for_name): Update.
11951         * jit.c (jit_find_objf_with_entry_addr): Update.
11952         * hppa-tdep.c (find_unwind_entry)
11953         (hppa_lookup_stub_minimal_symbol): Update.
11954         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
11955         Update.
11956         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11957         (elf_gnu_ifunc_resolve_by_got): Update.
11958         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
11959         * dwarf-index-write.c (save_gdb_index_command): Update.
11960         * cp-support.c (add_symbol_overload_list_qualified): Update.
11961         * breakpoint.c (create_overlay_event_breakpoint)
11962         (create_longjmp_master_breakpoint)
11963         (create_std_terminate_master_breakpoint)
11964         (create_exception_master_breakpoint): Update.
11965         * blockframe.c (find_pc_partial_function): Update.
11966         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
11967         (ada_collect_symbol_completion_matches)
11968         (ada_add_global_exceptions): Update.
11969
11970 2019-01-17  Tom Tromey  <tom@tromey.com>
11971
11972         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
11973         declare VEC.
11974         (solib_target_parse_libraries): Change return type.
11975         (library_list_start_segment, library_list_start_section)
11976         (library_list_end_library, library_list_start_library); Update.
11977         (solib_target_free_library_list): Remove.
11978         (solib_target_parse_libraries): Remove cleanup.  Change return
11979         type.
11980         (solib_target_current_sos): Update.
11981
11982 2019-01-17  Tom Tromey  <tromey@bapiya>
11983
11984         * valprint.c: Replace "the the" with "the".
11985         * symtab.c: Replace "the the" with "the".
11986         * solib.c: Replace "the the" with "the".
11987         * solib-dsbt.c: Replace "the the" with "the".
11988         * linespec.c: Replace "the the" with "the".
11989         * dwarf2loc.h: Replace "the the" with "the".
11990         * amd64-windows-tdep.c: Replace "the the" with "the".
11991         * aarch64-tdep.c: Replace "the the" with "the".
11992
11993 2019-01-16  Keith Seitz  <keiths@redhat.com>
11994
11995         PR gdb/23773
11996         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
11997         <builder>: Rename to ..
11998         <m_builder>: ... this and make private.
11999         (dwarf2_cu::get_builder): New method.  Change all users of
12000         `builder' to use this method.
12001         (dwarf2_start_symtab): Move to ...
12002         (dwarf2_cu::start_symtab): ... here.  Update all callers
12003         (setup_type_unit_groups): Move to ...
12004         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
12005         callers.
12006         (dwarf2_cu::reset_builder): New method.
12007         (process_full_compunit, process_full_type_unit): Use
12008         dwarf2_cu::reset_builder.
12009         (follow_die_offset): Record the ancestor CU if it is different
12010         from the followed DIE's CU.
12011         (follow_die_sig_1): Likewise.
12012
12013 2019-01-15  Tom Tromey  <tom@tromey.com>
12014
12015         * remote.c (class remote_state) <buf>: Now a char_vector.
12016         <buf_size>: Remove.
12017         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
12018         parameter.
12019         (remote_target::getpkt_or_notif_sane_1)
12020         (remote_target::getpkt_sane)
12021         (remote_target::getpkt_or_notif_sane): Likewise.
12022         (class remote_target) <putpkt>: New overload.
12023         (remote_target::read_frame): Change type of "buf_p".  Remove
12024         sizeof_p parameter.
12025         (packet_ok): New overload.
12026         (packet_check_result): New overload.
12027         Update all uses.
12028
12029 2019-01-14  Tom Tromey  <tom@tromey.com>
12030
12031         * remote-notif.c (handle_notification, remote_notif_ack)
12032         (remote_notif_parse): Make "buf" const.
12033         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
12034         const.
12035         (remote_notif_parse, remote_notif_ack, handle_notification):
12036         Likewise.
12037         * remote.c (remote_notif_stop_parse): Make "buf" const.
12038         (remote_target::remote_parse_stop_reply): Make "buf" const.
12039         (remote_notif_stop_ack): Make "buf" const.
12040
12041 2019-01-14  Tom Tromey  <tom@tromey.com>
12042
12043         * remote.c (remote_console_output): Make parameter const.
12044
12045 2019-01-14  Tom Tromey  <tom@tromey.com>
12046
12047         * target-debug.h (target_debug_print_signals): Constify.
12048         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
12049         * procfs.c (procfs_target::pass_signals): Update.
12050         * linux-nat.c (linux_nat_target::pass_signals): Update.
12051         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
12052         * target-delegates.c: Rebuild.
12053         * remote.c (remote_target::program_signals): Update.
12054         (remote_target::pass_signals): Update.
12055         * target.c (target_pass_signals): Constify argument.
12056         (target_program_signals): Likewise.
12057         * target.h (struct target_ops) <pass_signals, program_signals>:
12058         Constify argument.
12059         (target_pass_signals, target_program_signals): Constify argument.
12060
12061 2019-01-14  Tom Tromey  <tom@tromey.com>
12062
12063         PR tui/28819:
12064         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
12065
12066 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
12067
12068         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
12069         field.
12070         * rs6000-tdep.c: Include reggroups.h.
12071         (IS_V_ALIAS_PSEUDOREG): Define.
12072         (rs6000_register_name): Return names for the "vX" aliases.
12073         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
12074         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
12075         aliases.  Call default_register_reggroup_p for all other
12076         pseudo-registers.
12077         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
12078         New functions.
12079         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
12080         Handle "vX" aliases.
12081         (v_alias_pseudo_register_collect): New function.
12082         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
12083         (rs6000_gdbarch_init): Initialize "vX" aliases as
12084         pseudo-registers.  Restore registration of
12085         rs6000_pseudo_register_reggroup_p with
12086         set_tdesc_pseudo_register_reggroup_p.
12087
12088 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
12089
12090         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
12091         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
12092         set_gdbarch_num_pseudo_regs.
12093
12094 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12095
12096         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
12097         Remove arg prefixname, add do_set and do_show.
12098         Add member functions set_list and show_list.
12099         * cli/cli-style.c (class cli_style_option): Update accordingly.
12100         (style_set_list): Move to file scope.
12101         (style_show_list): Likewise.
12102         (set_style): Call help_list.
12103         (show_style): Call cmd_show_list.
12104         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
12105         Update to use the new macro.
12106
12107 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
12108
12109         * ada-lang.c (_initialize_ada_language): Expand the help text
12110         for the "catch exception" command.
12111
12112 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12113
12114         * symtab.c (matching_obj_sections): Initialize obj,
12115         declare it closer to its usage.
12116
12117 2019-01-10  Tom Tromey  <tom@tromey.com>
12118
12119         * thread-iter.h (inf_threads_iterator): Use next_iterator.
12120         (basic_inf_threads_range): Remove.
12121         (inf_threads_range, inf_non_exited_threads_range)
12122         (safe_inf_threads_range): Use next_adapter.
12123
12124 2019-01-10  Keith Seitz  <keiths@redhat.com>
12125
12126         PR gdb/23712
12127         PR symtab/23010
12128         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
12129         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
12130
12131 2019-01-10  Keith Seitz  <keiths@redhat.com>
12132
12133         PR gdb/23712
12134         PR symtab/23010
12135         * dictionary.c (pending_to_vector): Remove.
12136         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12137         Remove _1 suffix, replacing functions of the same name.  Update
12138         all callers.
12139         (dict_create_hashed, dict_create_hashed_expandable)
12140         (dict_create_linear, dict_create_linear_expandable, dict_free)
12141         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
12142         Make functions static.
12143
12144 2019-01-10  Keith Seitz  <keiths@redhat.com>
12145
12146         PR gdb/23712
12147         PR symtab/23010
12148         * dictionary.h (struct dictionary): Replace declaration with
12149         multidictionary.
12150         (dict_create_hashed, dict_create_hashed_expandable)
12151         (dict_create_linear, dict_create_linear_expandable)
12152         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
12153         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
12154         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
12155         taking multidictionary argument.
12156         [ALL_DICT_SYMBOLS]: Update for multidictionary.
12157         * block.h (struct block) <dict>: Change to multidictionary
12158         and rename `multidict'.
12159         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
12160         symmisc.c: Update all dictionary references to multidictionary.
12161
12162 2019-01-10  Keith Seitz  <keiths@redhat.com>
12163
12164         PR gdb/23712
12165         PR symtab/23010
12166         * dictionary.c: Include unordered_map.
12167         (pending_to_vector): New function.
12168         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12169         Rewrite the non-"_1" functions to take vector instead
12170         of linked list.
12171         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
12172         "new" _1 versions of the same name.
12173         (multidictionary): Define.
12174         (std::hash<enum language): New definition.
12175         (collate_pending_symbols_by_language, mdict_create_hashed)
12176         (mdict_create_hashed_expandable, mdict_create_linear)
12177         (mdict_create_linear_expandable, mdict_free)
12178         (find_language_dictionary, create_new_language_dictionary)
12179         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
12180         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
12181         (mdict_size, mdict_empty): New functions.
12182         * dictionary.h (mdict_iterator): Define.
12183
12184 2019-01-10  Pedro Alves  <palves@redhat.com>
12185
12186         * breakpoint.c (read_uploaded_action)
12187         (create_tracepoint_from_upload): Adjust to use
12188         gdb::unique_xmalloc_ptr.
12189         * ctf.c (ctf_write_uploaded_tp):
12190         (SET_ARRAY_FIELD): Use emplace_back.
12191         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
12192         * tracefile-tfile.c (tfile_write_uploaded_tp):
12193         * tracepoint.c (parse_tracepoint_definition): Adjust to use
12194         gdb::unique_xmalloc_ptr.
12195         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
12196         at_string, cond_string, cmd_strings>: Replace char pointers
12197         with gdb::unique_xmalloc_ptr.
12198
12199 2019-01-10  Pedro Alves  <palves@redhat.com>
12200
12201         * solib-target.c (library_list_start_library): Don't xstrdup name.
12202
12203 2019-01-10  Pedro Alves  <palves@redhat.com>
12204
12205         * mdebugread.c (parse_partial_symbols): Use
12206         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
12207
12208 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12209
12210         * linux-fork.c (scoped_switch_fork_info)
12211         <~scoped_switch_fork_info>: Fix incorrect variable name.
12212
12213 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12214
12215         * linux-fork.c (scoped_switch_fork_info)
12216         <scoped_switch_fork_info>: Make explicit.
12217         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
12218
12219 2019-01-10  Tom Tromey  <tom@tromey.com>
12220
12221         * objfiles.h (objfile::reset_psymtabs): Update.
12222         * objfiles.c (objfile::objfile): Update.
12223         * psymtab.h (psymtab_storage::obstack): Update.
12224         (psymtab_storage::m_obstack): Use gdb::optional.
12225         (class psymtab_storage): Update comment.  Remove objfile
12226         parameter.
12227         * psymtab.c (psymtab_storage::psymtab_storage): Update.
12228
12229 2019-01-10  Tom Tromey  <tom@tromey.com>
12230
12231         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
12232         <free_psymtabs>: Now private.
12233         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
12234         (allocate_psymtab): Use new method.
12235
12236 2019-01-10  Tom Tromey  <tom@tromey.com>
12237
12238         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
12239         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
12240         * mdebugread.c (parse_partial_symbols): Use
12241         allocate_dependencies.
12242         * dwarf2read.c (dwarf2_create_include_psymtab): Use
12243         allocate_dependencies.
12244         (process_psymtab_comp_unit_reader)
12245         (build_type_psymtab_dependencies): Likewise.
12246         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
12247
12248 2019-01-10  Tom Tromey  <tom@tromey.com>
12249
12250         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
12251         PSYMBOL_SET_LANGUAGE.
12252         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
12253
12254 2019-01-10  Tom Tromey  <tom@tromey.com>
12255
12256         * psymtab.h (psymtab_storage::obstack): New method.
12257         <m_obstack>: Rename from obstack; now private.
12258         * psymtab.c (psymtab_storage): Update.
12259         * dwarf2read.c (create_addrmap_from_index)
12260         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
12261         Update.
12262
12263 2019-01-10  Tom Tromey  <tom@tromey.com>
12264
12265         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
12266         * objfiles.h (objfile::reset_psymtabs): New method.
12267
12268 2019-01-10  Tom Tromey  <tom@tromey.com>
12269
12270         * symmisc.c (print_symbol_bcache_statistics): Update.
12271         (print_objfile_statistics): Update.
12272         * symfile.c (reread_symbols): Update.
12273         * psymtab.h (class psymtab_storage): New.
12274         * psymtab.c (psymtab_storage): New constructor.
12275         (~psymtab_storage): New destructor.
12276         (require_partial_symbols): Update.
12277         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
12278         (find_pc_sect_psymtab, find_pc_sect_psymbol)
12279         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
12280         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
12281         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
12282         (start_psymtab_common, end_psymtab_common)
12283         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
12284         (allocate_psymtab): Update.
12285         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
12286         Update.
12287         (dump_psymtab_addrmap, maintenance_print_psymbols)
12288         (maintenance_check_psymtabs): Update.
12289         (class objfile_psymtabs): Move to objfiles.h.
12290         * psympriv.h (discard_psymtab): Now inline.
12291         (psymtab_discarder::psymtab_discarder): Update.
12292         (psymtab_discarder::~psymtab_discarder): Update.
12293         (ALL_OBJFILE_PSYMTABS): Rewrite.
12294         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
12295         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
12296         Remove fields.
12297         <partial_symtabs>: New field.
12298         (class objfile_psymtabs): Move from psymtab.h.  Update.
12299         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
12300         psymbol_cache.
12301         (objfile::~objfile): Don't destroy psymbol_cache.
12302         * mdebugread.c (parse_partial_symbols): Update.
12303         * dwarf2read.c (create_addrmap_from_index)
12304         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
12305         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
12306         (add_partial_subprogram, dwarf2_ranges_read): Update.
12307         * dwarf-index-write.c (write_address_map)
12308         (write_one_signatured_type, recursively_write_psymbols)
12309         (class debug_names, class debug_names, write_psymtabs_to_index):
12310         Update.
12311
12312 2019-01-10  Tom Tromey  <tom@tromey.com>
12313
12314         * symtab.h (SYMBOL_SET_NAMES): Update.
12315         (symbol_set_names): Update.
12316         (MSYMBOL_SET_NAMES): Update.
12317         * symtab.c (symbol_set_names): Change argument to be an
12318         objfile_per_bfd_storage.
12319         * psymtab.c (add_psymbol_to_bcache): Update.
12320         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
12321
12322 2019-01-10  Tom Tromey  <tom@tromey.com>
12323
12324         * symtab.c (create_demangled_names_hash): Change argument to be an
12325         objfile_per_bfd_storage.
12326         (symbol_set_names): Update.
12327
12328 2019-01-10  Tom Tromey  <tom@tromey.com>
12329
12330         * xcoffread.c (xcoff_initial_scan): Unconditionally call
12331         init_psymbol_list.
12332         * psymtab.c (init_psymbol_list): Do nothing if already called.
12333         * psympriv.h (init_psymbol_list): Add comment.
12334         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
12335         init_psymbol_list.
12336         * dbxread.c (dbx_symfile_read): Unconditionally call
12337         init_psymbol_list.
12338
12339 2019-01-10  Tom Tromey  <tom@tromey.com>
12340
12341         * xcoffread.c (scan_xcoff_symtab): Update.
12342         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
12343         "where".
12344         * mdebugread.c (parse_partial_symbols)
12345         (handle_psymbol_enumerators): Update.
12346         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
12347         * dbxread.c (read_dbx_symtab): Update.
12348         * psympriv.h (psymbol_placement): New enum.
12349         (add_psymbol_to_list): Update.
12350
12351 2019-01-10  Tom Tromey  <tom@tromey.com>
12352
12353         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
12354         static_psymbols parameters.
12355         (scan_xcoff_symtab): Update.
12356         * psymtab.c (start_psymtab_common): Remove global_psymbols and
12357         static_psymbols parameters.
12358         * psympriv.h (start_psymtab_common): Update.
12359         * mdebugread.c (parse_partial_symbols): Update.
12360         * dwarf2read.c (create_partial_symtab): Update.
12361         * dbxread.c (read_dbx_symtab): Update.
12362         (start_psymtab): Remove global_psymbols and static_psymbols
12363         parameters.
12364
12365 2019-01-10  Tom Tromey  <tom@tromey.com>
12366
12367         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
12368         * psymtab.c (allocate_psymtab): Add comment.
12369         * psympriv.h (allocate_psymtab): Add comment.
12370         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
12371         initializations.
12372         * dbxread.c (dbx_end_psymtab): Remove some initializations.
12373
12374 2019-01-10  Tom Tromey  <tom@tromey.com>
12375
12376         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12377         Don't declare.
12378         * mipsread.c: Include mdebugread.h.
12379         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12380         Declare.
12381         * elfread.c: Include mdebugread.h.
12382
12383 2019-01-09  Tom Tromey  <tom@tromey.com>
12384
12385         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
12386         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
12387         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
12388         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
12389         (psym_lookup_symbol, psym_find_last_source_symtab)
12390         (psym_forget_cached_source_info, psym_print_stats)
12391         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
12392         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
12393         (psym_map_matching_symbols, psym_expand_symtabs_matching)
12394         (psym_find_compunit_symtab_by_address)
12395         (maintenance_print_psymbols, maintenance_info_psymtabs)
12396         (maintenance_check_psymtabs): Use ranged for.
12397         * psymtab.h (class objfile_psymtabs): New.
12398         (require_partial_symbols): Return objfile_psymtabs.
12399         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
12400
12401 2019-01-09  Tom Tromey  <tom@tromey.com>
12402
12403         * symfile.c (overlay_invalidate_all, find_pc_overlay)
12404         (find_pc_mapped_section, list_overlays_command)
12405         (map_overlay_command, unmap_overlay_command)
12406         (simple_overlay_update): Use all_objfiles.
12407         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
12408         * printcmd.c (info_symbol_command): Use all_objfiles.
12409         * objfiles.h (ALL_OBJSECTIONS): Remove.
12410         * maint.c (maintenance_translate_address): Use all_objfiles.
12411         * gcore.c (gcore_create_callback): Use all_objfiles.
12412         (objfile_find_memory_regions): Likewise.
12413
12414 2019-01-09  Tom Tromey  <tom@tromey.com>
12415
12416         * symtab.c (find_line_symtab, info_sources_command)
12417         (make_source_files_completion_list): Use objfile_compunits.
12418         * source.c (select_source_symtab): Use objfile_compunits.
12419         * objfiles.h (struct objfile): Update comment.
12420         (ALL_OBJFILES): Remove.
12421         (ALL_FILETABS): Remove.
12422         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
12423         objfile_compunits.
12424
12425 2019-01-09  Tom Tromey  <tom@tromey.com>
12426
12427         * symmisc.c (print_objfile_statistics, dump_objfile)
12428         (maintenance_print_symbols): Use compunit_filetabs.
12429         * source.c (forget_cached_source_info_for_objfile): Use
12430         compunit_filetabs.
12431         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
12432         (ALL_FILETABS): Use compunit_filetabs.
12433         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
12434         * coffread.c (coff_symtab_read): Use compunit_filetabs.
12435
12436 2019-01-09  Tom Tromey  <tom@tromey.com>
12437
12438         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
12439         (compunit_filetabs): New.
12440         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
12441         compunit_filetabs.
12442         (info_sources_command, make_source_files_completion_list): Remove
12443         declaration.
12444         * symmisc.c (print_objfile_statistics, dump_objfile)
12445         (maintenance_print_symbols): Remove declaration.
12446         (maintenance_info_symtabs): Use compunit_filetabs.
12447         (maintenance_info_line_tables): Likewise.
12448         * source.c (select_source_symtab): Change local variable name.
12449         (forget_cached_source_info_for_objfile): Remove declaration.
12450         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
12451         * objfiles.c (objfile_relocate1): Remove declaration.
12452         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12453         declaration.
12454         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
12455         * coffread.c (coff_symtab_read): Remove declaration.
12456         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
12457         compunit_filetabs.
12458
12459 2019-01-09  Tom Tromey  <tom@tromey.com>
12460
12461         * symtab.c (lookup_objfile_from_block)
12462         (find_pc_sect_compunit_symtab, search_symbols)
12463         (default_collect_symbol_completion_matches_break_on): Use
12464         objfile_compunits.
12465         * objfiles.h (ALL_COMPUNITS): Remove.
12466         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
12467         * cp-support.c (add_symbol_overload_list_qualified): Use
12468         objfile_compunits.
12469         * ada-lang.c (ada_collect_symbol_completion_matches)
12470         (ada_add_global_exceptions): Use objfile_compunits.
12471
12472 2019-01-09  Tom Tromey  <tom@tromey.com>
12473
12474         * source.c (select_source_symtab)
12475         (forget_cached_source_info_for_objfile): Remove declaration.
12476         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12477         declaration.
12478         * maint.c (count_symtabs_and_blocks): Remove declaration.
12479         * cp-support.c (add_symbol_overload_list_qualified): Remove
12480         declaration.
12481         * coffread.c (coff_symtab_read): Remove declaration.
12482         * symtab.c (lookup_symbol_in_objfile_symtabs)
12483         (basic_lookup_transparent_type_1): Use objfile_compunits.
12484         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
12485         (info_sources_command, search_symbols)
12486         (default_collect_symbol_completion_matches_break_on)
12487         (make_source_files_completion_list): Remove declaration.
12488         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
12489         (ada_collect_symbol_completion_matches)
12490         (ada_add_global_exceptions): Remove declaration.
12491         * linespec.c (iterate_over_all_matching_symtabs): Use
12492         objfile_compunits.
12493         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
12494         (class objfile_compunits): New.
12495         (ALL_COMPUNITS): Use objfile_compunits.
12496         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
12497         (maintenance_check_symtabs, maintenance_info_line_tables): Use
12498         objfile_compunits.
12499         * objfiles.c (objfile_relocate1): Use objfile_compunits.
12500
12501 2019-01-09  Tom Tromey  <tom@tromey.com>
12502
12503         * symtab.c (search_symbols)
12504         (default_collect_symbol_completion_matches_break_on): Use
12505         objfile_msymbols.
12506         * ada-lang.c (ada_lookup_simple_minsym)
12507         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
12508         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
12509         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
12510         objfile_msymbols.
12511         * coffread.c (coff_symfile_read): Use objfile_msymbols.
12512         * symmisc.c (dump_msymbols): Use objfile_msymbols.
12513         * objc-lang.c (find_methods): Use objfile_msymbols.
12514         (info_selectors_command, info_classes_command): Likewise.
12515         * stabsread.c (scan_file_globals): Use objfile_msymbols.
12516         * objfiles.h (class objfile_msymbols): New.
12517         (ALL_OBJFILE_MSYMBOLS): Remove.
12518         (ALL_MSYMBOLS): Remove.
12519
12520 2019-01-09  Tom Tromey  <tom@tromey.com>
12521
12522         * common/next-iterator.h (next_adapter): Add Iterator template
12523         parameter.
12524         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
12525         (class all_objfiles_safe): New.
12526         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
12527         * objfiles.c (put_objfile_before): Update comment.
12528         (add_separate_debug_objfile): Likewise.
12529         (free_all_objfiles): Use all_objfiles_safe.
12530         (objfile_purge_solibs): Likewise.
12531
12532 2019-01-09  Tom Tromey  <tom@tromey.com>
12533
12534         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12535         (expand_symtab_containing_pc, lookup_static_symbol)
12536         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
12537         (find_symbol_at_address, find_line_symtab, find_main_name): Use
12538         all_objfiles.
12539         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
12540         * breakpoint.c (create_overlay_event_breakpoint)
12541         (create_longjmp_master_breakpoint)
12542         (create_std_terminate_master_breakpoint)
12543         (create_exception_master_breakpoint): Use all_objfiles.
12544         * linux-thread-db.c (try_thread_db_load_from_pdir)
12545         (has_libpthread): Use all_objfiles.
12546         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
12547         * linespec.c (iterate_over_all_matching_symtabs)
12548         (search_minsyms_for_name): Use all_objfiles.
12549         * maint.c (maintenance_info_sections): Use all_objfiles.
12550         * main.c (captured_main_1): Use all_objfiles.
12551         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
12552         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
12553         * guile/scm-pretty-print.c
12554         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
12555         * solib-spu.c (append_ocl_sos): Use all_objfiles.
12556         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
12557         (maintenance_print_msymbols): Use all_objfiles.
12558         * source.c (select_source_symtab): Use all_objfiles.
12559         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
12560         * symfile.c (remove_symbol_file_command)
12561         (expand_symtabs_matching, map_symbol_filenames): Use
12562         all_objfiles.
12563         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
12564         all_objfiles.
12565         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
12566         * objc-lang.c (find_methods): Use all_objfiles.
12567         * objfiles.c (have_partial_symbols, have_full_symbols)
12568         (have_minimal_symbols, qsort_cmp)
12569         (default_iterate_over_objfiles_in_search_order): Use
12570         all_objfiles.
12571         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
12572         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
12573         (maintenance_check_psymtabs): Use all_objfiles.
12574         (ALL_PSYMTABS): Remove.
12575         * compile/compile-object-run.c (do_module_cleanup): Use
12576         all_objfiles.
12577         * blockframe.c (find_pc_partial_function): Use all_objfiles.
12578         * cp-support.c (add_symbol_overload_list_qualified): Use
12579         all_objfiles.
12580         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12581         Use all_objfiles.
12582         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
12583         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
12584         all_objfiles.
12585         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12586         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
12587         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12588         Uses all_objfiles.
12589         * solib.c (solib_read_symbols): Use all_objfiles
12590
12591 2019-01-09  Tom Tromey  <tom@tromey.com>
12592
12593         * probe.c (parse_probes_in_pspace): Use all_objfiles.
12594         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
12595         all_objfiles.
12596         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
12597         * symmisc.c (print_symbol_bcache_statistics)
12598         (print_objfile_statistics, maintenance_print_objfiles)
12599         (maintenance_info_symtabs, maintenance_check_symtabs)
12600         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
12601         all_objfiles.
12602         * source.c (forget_cached_source_info): Use all_objfiles.
12603         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
12604         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12605         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
12606         * objfiles.c (update_section_map): Use all_objfiles.
12607         (shared_objfile_contains_address_p): Likewise.
12608         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
12609         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
12610
12611 2019-01-09  Tom Tromey  <tom@tromey.com>
12612
12613         * common/next-iterator.h: New file.
12614         * objfiles.h (class all_objfiles): New.
12615         (struct objfile_iterator): New.
12616
12617 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12618
12619         * NEWS: Move the description of the changed "frame", "select-frame",
12620          and "info frame" commands to the Changed commands section.
12621
12622 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
12623
12624         * gdbtypes.c (check_stub_method_group): Remove handling of old
12625         mangling schemes.
12626         * linespec.c (find_methods): Likewise.
12627         * stabsread.c (read_member_functions): Likewise.
12628         * valops.c (search_struct_method): Likewise.
12629         (value_struct_elt_for_reference): Likewise.
12630         * NEWS: Mention this change.
12631
12632 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
12633
12634         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
12635         print_source_lines.
12636         * source.c (print_source_lines_base): Update line number check.
12637         (print_source_lines): New function.
12638         (source_lines_range::source_lines_range): New function.
12639         * source.h (class source_lines_range): New class.
12640         (print_source_lines): New declaration.
12641
12642 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12643
12644         * linespec.c (linespec_state_destructor): Free self->canonical_names.
12645
12646 2019-01-08  Tom Tromey  <tom@tromey.com>
12647             Simon Marchi  <simon.marchi@ericsson.com>
12648
12649         PR gdb/24060
12650         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
12651         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
12652         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12653         * f-exp.y (DOLLAR_VARIABLE): Likewise.
12654         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
12655         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12656
12657 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12658
12659         * source.c (select_source_symtab): Move header comment to
12660         declaration in source.h.
12661         (forget_cached_source_info_for_objfile): Likewise.
12662         (forget_cached_source_info): Likewise.
12663         (identify_source_line): Likewise.
12664         * source.h (identify_source_line): Move declaration from symtab.h
12665         and add comment from source.c
12666         (print_source_lines): Likewise.
12667         (forget_cached_source_info_for_objfile): Likewise.
12668         (forget_cached_source_info): Likewise.
12669         (select_source_symtab): Likewise.
12670         (enum print_source_lines_flag): Move definition from symtab.h.
12671         * symtab.h (identify_source_line): Move declaration to source.h.
12672         (print_source_lines): Likewise.
12673         (forget_cached_source_info_for_objfile): Likewise.
12674         (forget_cached_source_info): Likewise.
12675         (select_source_symtab): Likewise.
12676         (enum print_source_lines_flag): Move definition to source.h.
12677         * tui/tui-hooks.c: Add 'source.h' include.
12678
12679 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12680
12681         * source.c (print_source_lines_base): Handle requests to print
12682         reverse line number sequences, and guard against empty lines
12683         string.
12684
12685 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12686
12687         * source.c (print_source_lines_base): Fix skip of '\r' if next
12688         character is '\n'.
12689
12690 2019-01-06  Tom Tromey  <tom@tromey.com>
12691
12692         * c-exp.y (struct c_parse_state) <macro_original_text,
12693         expansion_obstack>: New member.
12694         (macro_original_text, expansion_obstack): Remove globals.
12695         (scan_macro_expansion, scanning_macro_expansion)
12696         (finished_macro_expansion): Update.
12697         (scan_macro_cleanup): Remove.
12698         (yylex, c_parse): Update.
12699
12700 2019-01-06  Tom Tromey  <tom@tromey.com>
12701
12702         * c-exp.y (struct c_parse_state) <strings>: New member.
12703         (operator_stoken): Update.
12704
12705 2019-01-06  Tom Tromey  <tom@tromey.com>
12706
12707         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
12708         (union type_stack_elt) <typelist_val>: Now a pointer to
12709         std::vector.
12710         (type_stack_cleanup): Don't declare.
12711         (push_typelist): Update.
12712         * parse.c (pop_typelist): Return a std::vector.
12713         (push_typelist): Take a std::vector.
12714         (follow_types): Update.  Do not free args.
12715         (type_stack_cleanup): Remove.
12716         * c-exp.y (struct c_parse_state): New.
12717         (cpstate): New global.
12718         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
12719         (nonempty_typelist): Update.
12720         (func_mod): Create a new vector.
12721         (c_parse): Create a c_parse_state.
12722         (check_parameter_typelist): Do not delete params.
12723         (function_method): Update.  Do not delete type_list.
12724
12725 2019-01-06  Tom Tromey  <tom@tromey.com>
12726
12727         PR gdb/28155:
12728         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
12729         check_typedef.
12730         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
12731         (print_return_value): Likewise.
12732
12733 2019-01-05  Tom Tromey  <tom@tromey.com>
12734
12735         * contrib/cleanup_check.py: Remove.
12736         * contrib/gcc-with-excheck: Remove.
12737         * contrib/exsummary.py: Remove.
12738         * contrib/excheck.py: Remove.
12739
12740 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
12741
12742         * thread.c (delete_thread_1): Add gdb_assert that THR is not
12743         NULL. Initialize tpprev to NULL instead of assigning it
12744         to NULL on the next statement.
12745         * windows-nat.c (windows_delete_thread): Remove check for
12746         main_thread_id before printing thread exit notifications.
12747         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
12748         Remove thread ID check against main_thread_id.
12749         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
12750         windows_delete_thread.
12751         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
12752
12753 2019-01-04  Tom Tromey  <tom@tromey.com>
12754
12755         * compile/compile.c (_initialize_compile): Use upper case for
12756         metasyntactic variables.
12757         * symmisc.c (_initialize_symmisc): Use upper case for
12758         metasyntactic variables.
12759         * psymtab.c (_initialize_psymtab): Use upper case for
12760         metasyntactic variables.
12761         * demangle.c (demangle_command): Use upper case for metasyntactic
12762         variables.
12763         (_initialize_demangler): Likewise.
12764         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
12765         variables.
12766
12767 2019-01-03  Tom Tromey  <tom@tromey.com>
12768
12769         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
12770
12771 2019-01-03  Tom Tromey  <tom@tromey.com>
12772
12773         * python/py-symtab.c (salpy_str): Update.
12774         (struct salpy_sal_object) <symtab>: Now a PyObject.
12775         (salpy_dealloc): Update.
12776         (del_objfile_sal): Use gdbpy_ref.
12777
12778 2019-01-03  Tom Tromey  <tom@tromey.com>
12779
12780         * python/py-type.c (convert_field): Use new_reference.  Return
12781         gdbpy_ref.
12782         (make_fielditem): Return gdbpy_ref.
12783         (typy_fields): Update.
12784         (typy_getitem): Update.
12785         (field_name): Return gdbpy_ref.  Use new_reference.
12786         (typy_iterator_iternext): Update.
12787
12788 2019-01-03  Tom Tromey  <tom@tromey.com>
12789
12790         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
12791
12792 2019-01-03  Tom Tromey  <tom@tromey.com>
12793
12794         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
12795         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
12796         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
12797         (pspy_set_frame_filters, pspy_set_frame_unwinders)
12798         (pspy_set_type_printers): Likewise.
12799         * python/py-function.c (fnpy_init): Use gdbpy_ref.
12800         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
12801         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
12802         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
12803         (objfpy_set_type_printers): Likewise.
12804
12805 2019-01-03  Tom Tromey  <tom@tromey.com>
12806
12807         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
12808         (gdbpy_print_stack): Use gdbpy_err_fetch.
12809         * python/python-internal.h (class gdbpy_err_fetch): New class.
12810         (class gdbpy_enter) <m_error_type, m_error_value,
12811         m_error_traceback>: Remove.
12812         <m_error>: New member.
12813         (gdbpy_exception_to_string): Don't declare.
12814         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
12815         * python/py-value.c (convert_value_from_python): Use
12816         gdbpy_err_fetch.
12817         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
12818         gdbpy_exception_to_string.
12819         (gdbpy_handle_exception): Use gdbpy_err_fetch.
12820         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
12821         gdbpy_err_fetch.
12822
12823 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12824
12825         * linux-nat.c (delete_lwp_cleanup): Delete.
12826         (struct lwp_deleter): New struct.
12827         (lwp_info_up): New typedef.
12828         (linux_nat_target::follow_fork): Delete cleanup, and make use of
12829         lwp_info_up.
12830
12831 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12832
12833         * linux-fork.c (class scoped_switch_fork_info): New class.
12834         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
12835
12836 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12837
12838         * valops.c (find_overload_match): Remove use of null_cleanup, and
12839         calls to do_cleanups.
12840
12841 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12842
12843         * compile/compile-cplus-types.c
12844         (compile_cplus_instance::decl_name): Handle changes to
12845         cp_func_name.
12846         * cp-support.c (cp_func_name): Update header comment, update
12847         return type.
12848         * cp-support.h (cp_func_name): Update return type in declaration.
12849         * valops.c (find_overload_match): Move temp_func local to top
12850         level of function and change its type.  Use temp_func to hold and
12851         delete temporary string obtained from cp_func_name.
12852
12853 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12854
12855         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
12856         gdb::char_vector, remove cleanup, and update uses of `msg`.
12857
12858 2019-01-03  Jim Wilson  <jimw@sifive.com>
12859
12860         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
12861
12862 2019-01-02  Tom Tromey  <tom@tromey.com>
12863
12864         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
12865         (tdesc_parse_xml): Remove cleanups.
12866         * target-descriptions.h (make_cleanup_free_target_description):
12867         Don't declare.
12868         (target_desc_deleter): New struct.
12869         (target_desc_up): New typedef.
12870         * target-descriptions.c (target_desc_deleter::operator()): Rename
12871         from free_target_description.
12872         (make_cleanup_free_target_description): Remove.
12873
12874 2019-01-02  Tom Tromey  <tom@tromey.com>
12875
12876         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
12877         constructor, destructor.
12878         (linespec_parser): Remove typedef.
12879         (~linespec_parser): Rename from linespec_parser_delete.
12880         (linespec_lex_to_end, linespec_complete_label)
12881         (linespec_complete): Update.
12882         (decode_line_full): Remove cleanups.
12883         (decode_line_1): Update.
12884
12885 2019-01-02  Tom Tromey  <tom@tromey.com>
12886
12887         * python/python-internal.h (inferior_to_inferior_object): Change
12888         return type.
12889         * python/py-exitedevent.c (create_exited_event_object): Update.
12890         * python/py-inferior.c (inferior_to_inferior_object): Return
12891         gdbpy_ref.
12892         (python_new_inferior, python_inferior_deleted)
12893         (thread_to_thread_object, delete_thread_object)
12894         (build_inferior_list, gdbpy_selected_inferior): Update.
12895         * python/py-infthread.c (create_thread_object): Update.  Also fail
12896         if inferior_to_inferior_object fails.
12897
12898 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
12899
12900         * inferior.h (class inferior) <displaced_step_state>: New field.
12901         * infrun.h (struct displaced_step_state): Move here from
12902         infrun.c.  Initialize fields, add constructor.
12903         <inf>: Remove field.
12904         <reset>: New method.
12905         * infrun.c (struct displaced_step_inferior_state): Move to
12906         infrun.h.
12907         (displaced_step_inferior_states): Remove.
12908         (get_displaced_stepping_state): Adust.
12909         (displaced_step_in_progress_any_inferior): Adjust.
12910         (displaced_step_in_progress_thread): Adjust.
12911         (displaced_step_in_progress): Adjust.
12912         (add_displaced_stepping_state): Remove.
12913         (get_displaced_step_closure_by_addr): Adjust.
12914         (remove_displaced_stepping_state): Remove.
12915         (infrun_inferior_exit): Call displaced_step_state.reset.
12916         (use_displaced_stepping): Don't check for NULL.
12917         (displaced_step_prepare_throw): Call
12918         get_displaced_stepping_state.
12919         (displaced_step_fixup): Don't check for NULL.
12920         (prepare_for_detach): Don't check for NULL.
12921
12922 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12923
12924         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
12925          in case of call that did not complete.
12926
12927 2019-01-02  Andrey Utkin  <autkin@undo.io>
12928
12929         * symfile.c (find_separate_debug_file): Fix search of debug files for
12930         remote debuggee.
12931
12932 2019-01-02  Tom Tromey  <tom@tromey.com>
12933
12934         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
12935         indentation.
12936         * python/py-frame.c (frapy_older): Remove cast.
12937         (frapy_newer): Likewise.
12938         * python/py-breakpoint.c (local_setattro): Remove cast.
12939         * python/py-arch.c (archpy_name): Remove local variable.
12940         * python/py-type.c (gdbpy_lookup_type): Remove cast.
12941
12942 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
12943
12944         * unittests/basic_string_view/element_access/char/empty.cc:
12945         Fix year range in copyright header.
12946
12947 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12948
12949         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
12950         Delete.
12951         <operator==>: Update with for removed field.
12952         <hash>: Likewise.
12953         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
12954         <isa_features>: ...this.
12955         <abi_features>: New field.
12956         (riscv_isa_flen): Update comment.
12957         (riscv_abi_xlen): New declaration.
12958         (riscv_abi_flen): New declaration.
12959         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
12960         isa_features.
12961         (riscv_abi_xlen): New function.
12962         (riscv_isa_flen): Update to get answer from isa_features.
12963         (riscv_abi_flen): New function.
12964         (riscv_has_fp_abi): Update to get answer from abi_features.
12965         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
12966         xlen and flen.
12967         (riscv_call_info) <xlen, flen>: Update comment.
12968         (riscv_call_arg_struct): Remove invalid assertions
12969         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
12970         is removed.
12971         (riscv_gdbarch_init): Gather isa features and abi features
12972         separately, ensure both match on the gdbarch when reusing an old
12973         gdbarch.  Relax an error check to allow 32-bit abi float to run on
12974         a target with 64-bit float hardware.
12975
12976 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12977
12978         * source.c (search_command_helper): Stop reverse search
12979         when line 1 has been searched.
12980
12981 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12982
12983         * record-full.c (record_full_base_target::close): Rewrite
12984         record_full_core_buf_list free logic.
12985
12986 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12987
12988         * break-catch-syscall.c (print_one_catch_syscall): xfree
12989         the last text.
12990
12991 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12992
12993         * top.c (print_gdb_version): Update Copyright year in version
12994         message.
12995
12996 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12997
12998         Update copyright year range in all GDB files.
12999
13000 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
13001
13002         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
13003
13004 For older changes see ChangeLog-2018.
13005 \f
13006 Local Variables:
13007 mode: change-log
13008 left-margin: 8
13009 fill-column: 74
13010 version-control: never
13011 coding: utf-8
13012 End:
13013