gdb/ChangeLog

   1 2019-05-17  Tom Tromey  <tromey@adacore.com>
   2
   3         * source.c (find_and_open_source): Remove cast.
   4
   5 2019-05-17  Tom Tromey  <tromey@adacore.com>
   6
   7         * annotate.c (annotate_source): Make "filename" const.
   8         * annotate.h (annotate_source): Use const.
   9
  10 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
  11
  12         * disasm.c (set_disassembler_options): Send errors to stderr.
  13
  14 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
  15
  16         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
  17         (cli_interp_base::set_logging): Check debug_redirect.
  18         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
  19         * cli/cli-logging.c (debug_redirect): Add static variable.
  20         (pop_output_files): Add default param.
  21         (handle_redirections): Print debug setting.
  22         (show_logging_command): Likewise.
  23         (_initialize_cli_logging): Add debugredirect command.
  24         * interps.c (current_interp_set_logging): Add debug_redirect
  25         parameter.
  26         * interps.h (set_logging): Add debug_redirect parameter.
  27         (current_interp_set_logging): Likewise.
  28         * mi/mi-common.h: Likewise.
  29         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
  30
  31 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
  32             Tom Tromey  <tromey@adacore.com>
  33
  34         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
  35         directly.
  36         * cli/cli-interp.h (make_logging_output): Remove declaration.
  37         * cli/cli-logging.c (make_logging_output): Remove function.
  38         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
  39         directly.
  40         * ui-file.c (tee_file::tee_file): Remove bools.
  41         (tee_file::~tee_file): Remove deletes.
  42         * ui-file.h (tee_file): Remove bools.
  43
  44 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
  45
  46         * mi/mi-cmds.h (mi_cmd_complete): New function.
  47         * mi/mi-main.c (mi_cmd_complete): Likewise.
  48         * mi/mi-cmds.c: Define new MI command -complete.
  49         * NEWS: Mention new -complete command.
  50
  51 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
  52
  53         * completer.h (complete): New function.
  54         * completer.c (complete): Likewise.
  55         * cli/cli-cmds.c: (complete_command): Update to use new complete()
  56         function defined in completer.h.
  57
  58 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
  59
  60        * MAINTAINERS (Write After Approval): Add myself.
  61
  62 2019-05-17  Tom de Vries  <tdevries@suse.de>
  63
  64         PR gdb/24094
  65         * dwarf2read.c (struct cu_partial_die_info): New struct.
  66         (find_partial_die): Return cu_partial_die_info.
  67         (partial_die_parent_scope, guess_partial_die_structure_name)
  68         (partial_die_info::fixup): Handle new return type of find_partial_die.
  69
  70 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
  71
  72         * stap-probe.c (stap_parse_register_operand): Make "regname" an
  73         "std::string", simplifying the algorithm.
  74
  75 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
  76
  77         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
  78         (stap_static_probe_ops::get_probes): Likewise.
  79
  80 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
  81
  82         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
  83         '-')" and "else if".
  84         (stap_parse_single_operand): Join checks for
  85         "gdbarch_stap_parse_special_token_p" and
  86         "gdbarch_stap_parse_special_token" in the same "if" statement.
  87         Invert check when verifying for operation on register
  88         displacement.
  89
  90 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
  91
  92         * stap-probe.c (stap_get_opcode): Update comment.
  93         (stap_get_expected_argument_type): Likewise.
  94         (handle_stap_probe): Likewise.
  95
  96 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
  97
  98         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
  99         return type to 'bool'.  Adjust comment.  Use 'bool' when
 100         appropriate.
 101         (i386_stap_parse_special_token_three_arg_disp): Likewise.
 102         * stap-probe.c (stap_parse_argument_1): Likewise.
 103         (stap_is_operator): Likewise.
 104         (stap_is_generic_prefix): Likewise.
 105         (stap_is_register_prefix): Likewise.
 106         (stap_is_register_indirection_prefix): Likewise.
 107         (stap_is_integer_prefix): Likewise.
 108         (stap_generic_check_suffix): Likewise.
 109         (stap_check_integer_suffix): Likewise.
 110         (stap_check_register_suffix): Likewise.
 111         (stap_check_register_indirection_suffix): Likewise.
 112         (stap_parse_register_operand): Likewise.
 113         (stap_parse_single_operand): Likewise.
 114         (stap_parse_argument_1): Likewise.
 115         (stap_probe::get_argument_count): Likewise.
 116         (stap_is_operator): Likewise.
 117
 118 2019-05-16  Tom Tromey  <tromey@adacore.com>
 119
 120         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
 121         keyword to foreach.
 122
 123 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
 124
 125         * linux-thread-db.c (try_thread_db_load_1): Change return type
 126         to bool.
 127         (try_thread_db_load): Likewise.
 128         (try_thread_db_load_from_pdir_1): Likewise.
 129         (try_thread_db_load_from_pdir): Likewise.
 130         (try_thread_db_load_from_sdir): Likewise.
 131         (try_thread_db_load_from_dir): Likewise.
 132         (thread_db_load_search): Likewise.
 133         (has_libpthread): Likewise.
 134         (thread_db_load): Likewise.
 135
 136 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
 137
 138         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 139         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
 140         NULL, and complain/return if that's the case.
 141
 142 2019-05-15  John Darrington <john@darrington.wattle.id.au>
 143
 144         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
 145         (advance, posn, abstract_read_memory): New functions.
 146         [struct mem_read_abstraction]: New struct.
 147         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
 148
 149 2019-05-14  Tom Tromey  <tromey@adacore.com>
 150
 151         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
 152         value is not lval_memory.
 153
 154 2019-05-14  Tom Tromey  <tromey@adacore.com>
 155
 156         * solib.c (info_sharedlibrary_command): Style the file name.
 157
 158 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
 159
 160         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
 161         (aarch64_vnv_type): Likewise.
 162         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
 163         * common/tdesc.c: Likewise.
 164         * common/tdesc.h (enum tdesc_type_kind): Likewise.
 165         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
 166         * features/aarch64-fpu.xml: Add ieee half view.
 167         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
 168         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
 169         * gdbtypes.h (struct builtin_type): Likewise.
 170         (struct objfile_type): Likewise.
 171
 172 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
 173
 174         * language.c (language_sniff_from_mangled_name): Fix "langauge"
 175         typo.
 176         * location.h (string_to_event_location): Likewise.
 177
 178 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
 179
 180         GDB 8.3 released.
 181
 182 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 183
 184         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
 185         New variable declaration.
 186         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
 187         New variable.
 188         (print_one_breakpoint): Use ui_out::test_flags and new global
 189         variable to compute use_fixed_output.
 190         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
 191         Remove.
 192         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
 193         (mi_multi_location_breakpoint_output_fixed): Remove.
 194         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
 195         new variable.
 196         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
 197         fix_multi_location_breakpoint_output flag if version >= 3.
 198         * ui-out.h (enum ui_out_flag)
 199         <fix_multi_location_breakpoint_output>: New enumerator.
 200
 201 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 202
 203         * contrib/cc-with-tweaks.sh: Validate dwz's work.
 204
 205 2019-05-10  Tom Tromey  <tromey@adacore.com>
 206
 207         * ada-lang.c (catch_ada_completer): New function.
 208         (_initialize_ada_language): Use it.
 209
 210 2019-05-10  Tom Tromey  <tromey@adacore.com>
 211
 212         * thread.c (print_thread_info): Make "requested_threads" const.
 213         * gdbthread.h (print_thread_info): Make "requested_threads"
 214         const.
 215         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
 216         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
 217
 218 2019-05-08  Tom Tromey  <tom@tromey.com>
 219
 220         * gdbtypes.c (objfile_type_data): Change type.
 221         (objfile_type, _initialize_gdbtypes): Update.
 222
 223 2019-05-08  Tom Tromey  <tom@tromey.com>
 224
 225         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
 226         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
 227         (_initialize_dwarf2_frame): Update.
 228
 229 2019-05-08  Tom Tromey  <tom@tromey.com>
 230
 231         * objc-lang.c (objc_objfile_data): Change type.
 232         (find_methods): Update.
 233         (_initialize_objc_lang): Remove.
 234
 235 2019-05-08  Tom Tromey  <tom@tromey.com>
 236
 237         * stabsread.c (rs6000_builtin_type_data): Change type.
 238         (rs6000_builtin_type, _initialize_stabsread): Update.
 239
 240 2019-05-08  Tom Tromey  <tom@tromey.com>
 241
 242         * mips-tdep.c (mips_pdr_data): Remove.
 243         (_initialize_mips_tdep): Update.
 244
 245 2019-05-08  Tom Tromey  <tom@tromey.com>
 246
 247         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
 248         (hppa_init_objfile_priv_data, read_unwind_info)
 249         (find_unwind_entry, _initialize_hppa_tdep): Update.
 250
 251 2019-05-08  Tom Tromey  <tom@tromey.com>
 252
 253         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
 254         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
 255         on obstack.
 256         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
 257
 258 2019-05-08  Tom Tromey  <tom@tromey.com>
 259
 260         * mdebugread.c (basic_type_data): Change type.
 261         (basic_type, _initialize_mdebugread): Update.
 262
 263 2019-05-08  Tom Tromey  <tom@tromey.com>
 264
 265         * common/gdb_unique_ptr.h (struct noop_deleter): New.
 266
 267 2019-05-08  Tom Tromey  <tom@tromey.com>
 268
 269         * nto-tdep.c (nto_inferior_data_reg): Change type.
 270         (nto_inferior_data): Update.
 271         (nto_inferior_data_cleanup, nto_new_inferior_data)
 272         (_initialize_nto_tdep): Remove.
 273         * nto-tdep.h (struct nto_inferior_data): Add initializers.
 274
 275 2019-05-08  Tom Tromey  <tom@tromey.com>
 276
 277         * ada-lang.c (struct ada_inferior_data): Add initializers.
 278         (ada_inferior_data): Change type.
 279         (ada_inferior_data_cleanup): Remove.
 280         (get_ada_inferior_data, ada_inferior_exit)
 281         (struct ada_pspace_data): Add initializers, destructor.
 282         (ada_pspace_data_handle): Change type.
 283         (get_ada_pspace_data): Update.
 284         (ada_pspace_data_cleanup): Remove.
 285
 286 2019-05-08  Tom Tromey  <tom@tromey.com>
 287
 288         * coffread.c (struct coff_symfile_info): Add initializers.
 289         (coff_objfile_data_key): Move lower.  Change type.
 290         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
 291         Update.
 292         (coff_free_info): Remove.
 293
 294 2019-05-08  Tom Tromey  <tom@tromey.com>
 295
 296         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
 297         (fbsd_pspace_data_handle): Move lower.  Change type.
 298         (get_fbsd_pspace_data): Update.
 299         (fbsd_pspace_data_cleanup): Remove.
 300         (_initialize_fbsd_tdep): Update.
 301
 302 2019-05-08  Tom Tromey  <tom@tromey.com>
 303
 304         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
 305         (get_ada_tasks_pspace_data): Update.
 306         (ada_tasks_pspace_data_cleanup): Remove.
 307         (_initialize_tasks): Update.
 308         (ada_tasks_inferior_data_handle): Change type.
 309         (get_ada_tasks_inferior_data): Update.
 310         (ada_tasks_inferior_data_cleanup): Remove.
 311         (struct ada_tasks_pspace_data): Add initializers.
 312
 313 2019-05-08  Tom Tromey  <tom@tromey.com>
 314
 315         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
 316         * symfile-debug.c (debug_sym_get_probes): Change type.
 317         * stap-probe.c (handle_stap_probe):
 318         (stap_static_probe_ops::get_probes): Change type.
 319         * probe.h (class static_probe_ops) <get_probes>: Change type.
 320         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
 321         (parse_probes_in_pspace): Update.
 322         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
 323         Update.
 324         (any_static_probe_ops::get_probes): Change type.
 325         * elfread.c (elfread_data): New typedef.
 326         (probe_key): Change type.
 327         (elf_get_probes): Likewise.  Update.
 328         (probe_key_free): Remove.
 329         (_initialize_elfread): Update.
 330         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
 331         Change type.
 332         (dtrace_process_dof_probe, dtrace_process_dof)
 333         (dtrace_static_probe_ops::get_probe): Change type.
 334
 335 2019-05-08  Tom Tromey  <tom@tromey.com>
 336
 337         * xcoffread.c (struct xcoff_symfile_info): Rename from
 338         coff_symfile_info.  Add initializers.
 339         (xcoff_objfile_data_key): Move lower.  Change type.
 340         (XCOFF_DATA): Rewrite.
 341         (xcoff_free_info): Remove.
 342         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
 343         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
 344         (xcoff_initial_scan): Update.
 345
 346 2019-05-08  Tom Tromey  <tom@tromey.com>
 347
 348         * solib-svr4.c (struct svr4_info): Add initializers and
 349         destructor.
 350         <probes_table>: Now an htab_up.
 351         (solib_svr4_pspace_data): Change type.
 352         (free_probes_table): Simplify.
 353         (~svr4_info): Rename from svr4_pspace_data_cleanup.
 354         (get_svr4_info, probes_table_htab_remove_objfile_probes)
 355         (probes_table_remove_objfile_probes, register_solib_event_probe)
 356         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
 357         (_initialize_svr4_solib): Update.
 358
 359 2019-05-08  Tom Tromey  <tom@tromey.com>
 360
 361         * remote.c (remote_pspace_data): Change type.
 362         (remote_pspace_data_cleanup): Remove.
 363         (get_remote_exec_file, set_pspace_remote_exec_file)
 364         (_initialize_remote): Update.
 365
 366 2019-05-08  Tom Tromey  <tom@tromey.com>
 367
 368         * breakpoint.c (breakpoint_objfile_key): Change type.
 369         (get_breakpoint_objfile_data): Update.
 370         (free_breakpoint_objfile_data): Remove.
 371         (_initialize_breakpoint): Update.
 372
 373 2019-05-08  Tom Tromey  <tom@tromey.com>
 374
 375         * linux-tdep.c (struct linux_info): Add initializers.
 376         (linux_inferior_data): Move.  Change type.
 377         (invalidate_linux_cache_inf): Update.
 378         (linux_inferior_data_cleanup): Remove.
 379         (get_linux_inferior_data, _initialize_linux_tdep): Update.
 380
 381 2019-05-08  Tom Tromey  <tom@tromey.com>
 382
 383         * auxv.c (auxv_inferior_data): Move.  Change type.
 384         (auxv_inferior_data_cleanup): Remove.
 385         (invalidate_auxv_cache_inf): Rewrite.
 386         (get_auxv_inferior_data, _initialize_auxv): Update.
 387
 388 2019-05-08  Tom Tromey  <tom@tromey.com>
 389
 390         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
 391         (symfile_debug_objfile_data_key): Change type.
 392         (symfile_debug_installed, debug_qf_has_symbols)
 393         (debug_qf_find_last_source_symtab)
 394         (debug_qf_forget_cached_source_info)
 395         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
 396         (debug_qf_print_stats, debug_qf_dump)
 397         (debug_qf_expand_symtabs_for_function)
 398         (debug_qf_expand_all_symtabs)
 399         (debug_qf_expand_symtabs_with_fullname)
 400         (debug_qf_map_matching_symbols)
 401         (debug_qf_expand_symtabs_matching)
 402         (debug_qf_find_pc_sect_compunit_symtab)
 403         (debug_qf_map_symbol_filenames)
 404         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
 405         (debug_sym_new_init, debug_sym_init, debug_sym_read)
 406         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
 407         (debug_sym_read_linetable, debug_sym_relocate): Update.
 408         (symfile_debug_free_objfile): Remove.
 409         (install_symfile_debug_logging, _initialize_symfile_debug):
 410         Update.
 411
 412 2019-05-08  Tom Tromey  <tom@tromey.com>
 413
 414         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
 415         allocate_on_obstack.
 416         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
 417         (get_dwarf2_per_objfile): Update.
 418         (set_dwarf2_per_objfile): Remove.
 419         (dwarf2_has_info, dwarf2_get_section_info): Update.
 420         (dwarf2_free_objfile): Remove.
 421         (_initialize_dwarf2_read): Update.
 422
 423 2019-05-08  Tom Tromey  <tom@tromey.com>
 424
 425         * auto-load.c (struct auto_load_pspace_info): Add destructor and
 426         initializers.
 427         <unsupported_script_warning_printed,
 428         script_not_found_warning_printed>: Now bool.
 429         (auto_load_pspace_data): Change type.
 430         (~auto_load_pspace_info): Rename from
 431         auto_load_pspace_data_cleanup.
 432         (get_auto_load_pspace_data, init_loaded_scripts_info)
 433         (clear_section_scripts, maybe_print_unsupported_script_warning)
 434         (maybe_print_script_not_found_warning, _initialize_auto_load):
 435         Update.
 436
 437 2019-05-08  Tom Tromey  <tom@tromey.com>
 438
 439         * objfiles.c (objfile_pspace_info): Add destructor and
 440         initializers.
 441         (objfiles_pspace_data): Change type.
 442         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
 443         (get_objfile_pspace_data): Update.
 444         (objfiles_bfd_data): Change type.
 445         (get_objfile_bfd_data): Update.
 446         (objfile_bfd_data_free, _initialize_objfiles): Remove.
 447
 448 2019-05-08  Tom Tromey  <tom@tromey.com>
 449
 450         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
 451         Change type.
 452         (get_catch_syscall_inferior_data): Update.
 453         (catch_syscall_inferior_data_cleanup): Remove.
 454         (_initialize_break_catch_syscall): Update.
 455
 456 2019-05-08  Tom Tromey  <tom@tromey.com>
 457
 458         * inflow.c (struct terminal_info): Add destructor and
 459         initializers.
 460         (inflow_inferior_data): Change type.
 461         (~terminal_info): Rename from inflow_inferior_data_cleanup.
 462         (get_inflow_inferior_data, inflow_inferior_exit)
 463         (swap_terminal_info, _initialize_inflow): Update.
 464
 465 2019-05-08  Tom Tromey  <tom@tromey.com>
 466
 467         * target-dcache.c (target_dcache_cleanup): Remove.
 468         (target_dcache_aspace_key): Change type.
 469         (target_dcache_init_p, target_dcache_invalidate)
 470         (target_dcache_get, target_dcache_get_or_init)
 471         (_initialize_target_dcache): Update.
 472         * dcache.h (struct dcache_deleter): New.
 473
 474 2019-05-08  Tom Tromey  <tom@tromey.com>
 475
 476         * symtab.c (struct symbol_cache): Add destructor and
 477         initializers.
 478         (symbol_cache_key): Move.  Change type.
 479         (make_symbol_cache, free_symbol_cache): Remove.
 480         (get_symbol_cache): Update.
 481         (symbol_cache_cleanup): Remove.
 482         (ALL_PSPACES, symbol_cache_flush)
 483         (maintenance_print_symbol_cache)
 484         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
 485         Update.
 486
 487 2019-05-08  Tom Tromey  <tom@tromey.com>
 488
 489         * symtab.c (struct main_info): Add destructor and initializers.
 490         (main_progspace_key): Move.  Change type.
 491         (get_main_info): Update.
 492         (main_info_cleanup): Remove.
 493         (_initialize_symtab): Update.
 494
 495 2019-05-08  Tom Tromey  <tom@tromey.com>
 496
 497         * registry.h (DECLARE_REGISTRY): Define the _key class.
 498
 499 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 500
 501         * NEWS: Merge two 'New commands' sections.
 502
 503 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
 504
 505         * ada-valprint.c (ada_val_print_gnat_array): Remove language
 506         parameter and use Ada language definition instead.
 507         (ada_val_print_ptr): Remove unused language parameter.
 508         (ada_val_print_num): Remove language parameter and use Ada language
 509         definition instead.
 510         (ada_val_print_enum, ada_val_print_flt): Remove unused language
 511         parameter.
 512         (ada_val_print_struct_union, ada_val_print_ref): Remove language
 513         parameter and use Ada language definition instead.
 514         (ada_val_print_1): Update all ada_val_print_xxx calls.
 515         Remove language parameter.
 516         (ada_val_print): Update ada_val_print_1 call.
 517
 518 2019-05-08  Tom Tromey  <tromey@adacore.com>
 519
 520         * remote.c (remote_hw_watchpoint_limit)
 521         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
 522         Now static.
 523
 524 2019-05-08  Tom Tromey  <tromey@adacore.com>
 525
 526         * maint.c (_initialize_maint_cmds): Move initialization code to
 527         remote.c.
 528         (watchdog, show_watchdog): Move to remote.c.
 529         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
 530         "watchdog" static.
 531         (_initialize_remote): Move initialization code from maint.c.
 532         * defs.h (watchdog): Don't declare.
 533
 534 2019-05-08  Tom Tromey  <tromey@adacore.com>
 535
 536         * tui/tui-interp.c: Include main.h.
 537         * interps.c: Include main.h.
 538         * main.h (interpreter_p): Declare.
 539         * defs.h (interpreter_p): Don't declare.
 540
 541 2019-05-08  Tom Tromey  <tromey@adacore.com>
 542
 543         * dwarf2loc.c: Include dwarf2read.h.
 544         * defs.h (read_unsigned_leb128): Don't declare.
 545         * dwarf2read.h (read_unsigned_leb128): Declare.
 546
 547 2019-05-08  Tom Tromey  <tromey@adacore.com>
 548
 549         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
 550         method.
 551
 552 2019-05-08  Tom Tromey  <tromey@adacore.com>
 553
 554         * utils.c (fputs_maybe_filtered): Reset style after paging, even
 555         when no wrap column is set.
 556
 557 2019-05-08  Tom Tromey  <tromey@adacore.com>
 558
 559         * c-lang.c (c_get_string): Handle non-C-style arrays.
 560
 561 2019-05-08  Tom Tromey  <tromey@adacore.com>
 562
 563         * typeprint.c (print_offset_data::update): Print the bit offset,
 564         not the number of bits remaining.
 565
 566 2019-05-08  Tom Tromey  <tromey@adacore.com>
 567
 568         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
 569         padding at end of comment.
 570
 571 2019-05-08  Tom Tromey  <tromey@adacore.com>
 572
 573         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
 574         Compare main types.
 575
 576 2019-05-06  Tom Tromey  <tom@tromey.com>
 577
 578         * common/scoped_mmap.c: Include common-defs.h.
 579         * common/scoped_mmap.h: Don't include config.h.
 580
 581 2019-05-04  Tom Tromey  <tom@tromey.com>
 582
 583         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
 584         (struct aarch64_call_info): Add initializers.
 585         <si>: Now a std::vector.
 586         (pass_on_stack, aarch64_push_dummy_call): Update.
 587
 588 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
 589             Tom Tromey  <tom@tromey.com>
 590
 591         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
 592         (ppc_threads): Now a std::vector.  Now static.
 593         (hwdebug_find_thread_points_by_tid)
 594         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
 595         Update.
 596
 597 2019-05-04  Tom Tromey  <tom@tromey.com>
 598
 599         * arc-tdep.c (arc_tdesc_init): Return bool.
 600
 601 2019-05-04  Tom Tromey  <tom@tromey.com>
 602
 603         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
 604         Use gdb_assert_not_reached.
 605
 606 2019-05-04  Tom Tromey  <tom@tromey.com>
 607
 608         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
 609         "false".
 610
 611 2019-05-04  Tom Tromey  <tom@tromey.com>
 612
 613         * arc-tdep.c (arc_tdesc_init): Use bool.
 614
 615 2019-05-04  Tom Tromey  <tom@tromey.com>
 616
 617         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
 618
 619 2019-05-04  Tom Tromey  <tom@tromey.com>
 620
 621         * cli/cli-cmds.c (valid_command_p): Return bool.
 622
 623 2019-05-04  Tom Tromey  <tom@tromey.com>
 624
 625         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
 626         * command.h (valid_user_defined_cmd_name_p): Channge return type.
 627
 628 2019-05-04  Raul Tambre  <raul@tambre.ee>
 629
 630         * python/lib/gdb/prompt.py (_ExtendedPrompt)
 631         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
 632         operator for comparison.
 633
 634 2019-05-04  Tom Tromey  <tom@tromey.com>
 635
 636         * psymtab.c (psymbol_name_matches, match_partial_symbol)
 637         (lookup_partial_symbol, print_partial_symbols)
 638         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
 639         (psymbol_compare): Update.
 640         (add_psymbol_to_bcache): Clear the entire psymbol.
 641         (maintenance_check_psymtabs): Update.
 642         * psympriv.h (struct partial_symbol): Don't derive from
 643         general_symbol_info.
 644         <obj_section, unrelocated_address, address,
 645         set_unrelocated_address>: Update.
 646         <ginfo>: New member.
 647         * dwarf-index-write.c (write_psymbols, debug_names::insert)
 648         (debug_names::write_psymbols): Update.
 649
 650 2019-05-04  Tom de Vries  <tdevries@suse.de>
 651
 652         * contrib/cc-with-tweaks.sh: Support -n arg.
 653
 654 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 655
 656         * corelow.c (core_target::detach): Ensure frame cache and
 657         register caches are cleared.
 658         inferior.c (exit_inferior_1): Likewise.
 659
 660 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
 661             Tom Tromey  <tom@tromey.com>
 662
 663         * dictionary.c (collate_pending_symbols_by_language): Remove
 664         "struct" from foreach.
 665         * symtab.c (lookup_global_symbol_from_objfile)
 666         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
 667         foreach.
 668         * ser-tcp.c (net_open): Remove "struct" from foreach.
 669         * objfiles.c (objfile_relocate, objfile_rebase)
 670         (objfile_has_symbols): Remove "struct" from foreach.
 671         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
 672         from foreach.
 673         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
 674         foreach.
 675         * darwin-nat.c (thread_info_from_private_thread_info): Remove
 676         "struct" from foreach.
 677         * ada-lang.c (create_excep_cond_exprs)
 678         (ada_exception_catchpoint_cond_string): Remove "struct" from
 679         foreach.
 680
 681 2019-05-03  Tom Tromey  <tromey@adacore.com>
 682
 683         * ada-exp.y (convert_char_literal): Check suffix of each
 684         enumerator.
 685
 686 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
 687
 688         PR ada/21406:
 689         * ada-exp.y (yywrap): Don't define.
 690         * ada-lex.l (%option): Add noyywrap
 691         (yywrap): Remove.
 692
 693 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
 694
 695         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
 696         _WIN32_WINNT to the XP level, unless already defined to a higher
 697         level.
 698
 699         * unittests/parse-connection-spec-selftests.c:
 700         * ser-tcp.c:
 701         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
 702         override.
 703
 704         * symfile.c (find_separate_debug_file): Remove colon from the
 705         drive spec of DOS/Windows file names of the target, so that the
 706         file name produced from DEBUGDIR and the target's directory will
 707         be valid on DOS/Windows systems.
 708
 709 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 710
 711         * rust-lang.c (val_print_struct): Handle printing structures
 712         containing strings.
 713
 714 2019-05-02  Tom Tromey  <tromey@adacore.com>
 715
 716         * valarith.c (_initialize_valarith): Remove.
 717
 718 2019-05-01  Tom Tromey  <tromey@adacore.com>
 719
 720         * ada-lang.c (ada_value_primitive_field): Treat more fields as
 721         bitfields.
 722
 723 2019-05-01  Tom Tromey  <tromey@adacore.com>
 724
 725         * ada-lang.c (ada_value_assign): Correctly compute starting offset
 726         for big-endian copies.
 727
 728 2019-04-30  Ali Tamur  <tamur@google.com>
 729         * gdb/dwarf2read.c (read_3_bytes): New declaration.
 730         (read_attribute_value): Added DW_FORM_strx1-4 cases.
 731         (read_3_bytes): New function.
 732
 733 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 734
 735         * windows-nat.c (main_thread_id): Delete.
 736         (handle_output_debug_string): Replace main_thread_id by
 737         current_event.dwThreadId.
 738         (fake_create_process): Likewise.
 739         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
 740         Do not set main_thread_id.
 741         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
 742         current_event.dwThreadId.
 743         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
 744
 745 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 746
 747         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
 748         Use current_event.dwThreadId instead of main_thread_id.
 749
 750 2019-04-30  Tom Tromey  <tromey@adacore.com>
 751
 752         * ada-lang.c (ada_lookup_simple_minsyms): New function.
 753         (create_excep_cond_exprs): Iterate over program spaces.
 754         (ada_exception_catchpoint_cond_string): Examine all minimal
 755         symbols for exception types.
 756
 757 2019-04-30  Tom Tromey  <tromey@adacore.com>
 758
 759         PR c++/24470:
 760         * dwarf2read.c (process_structure_scope): Handle case where type
 761         has template parameters but no symbol was created.
 762
 763 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 764             Chris January  <chris.january@arm.com>
 765
 766         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
 767         qualifier.
 768         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
 769
 770 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 771
 772         * f-typeprint.c (f_print_type): Update rules for printing
 773         whitespace.
 774         (f_type_print_varspec_suffix): Likewise.
 775
 776 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 777             Chris January  <chris.january@arm.com>
 778
 779         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 780         function arguments.
 781
 782 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 783
 784         * f-lang.c (build_fortran_types): Change name of void type to
 785         lower case.
 786         * f-typeprint.c (f_type_print_base): Print the name of the void
 787         type, rather than a fixed string.
 788         * f-valprint.c (f_decorations): Use lower case void string.
 789
 790 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 791             Chris January  <chris.january@arm.com>
 792
 793         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 794         types for Fortran.
 795
 796 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 797             Chris January  <chris.january@arm.com>
 798             David Lecomber  <david.lecomber@arm.com>
 799
 800         * f-exp.y (BINOP_INTRINSIC): New token.
 801         (exp): New parser rule handling BINOP_INTRINSIC.
 802         (f77_keywords): Add new builtin procedures.
 803         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 804         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 805         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 806         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 807         (print_unop_subexp_f): New function.
 808         (print_binop_subexp_f): New function.
 809         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 810         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 811         (dump_subexp_body_f): Likewise.
 812         (operator_check_f): Likewise.
 813         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 814         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 815
 816 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 817
 818         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 819         UNOP_KIND.
 820         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 821         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 822         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 823         (operator_length_f): New fuction.
 824         (print_subexp_f): New function.
 825         (op_name_f): New function.
 826         (dump_subexp_body_f): New function.
 827         (operator_check_f): New function.
 828         (exp_descriptor_f): Replace standard expression handling functions
 829         with new functions.
 830         * gdb/fortran-operator.def: New file.
 831         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 832         * gdb/std-operator.def: Remove UNOP_KIND.
 833
 834 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 835
 836         * std-operator.def: Remove unbalanced, stray double quote
 837         character.
 838
 839 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 840             Chris January  <chris.january@arm.com>
 841             Daniel Everett  <daniel.everett@arm.com>
 842             Nick Forrington  <nick.forrington@arm.com>
 843             Richard Bunt  <richard.bunt@arm.com>
 844
 845         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 846         of depth when printing anonymous structs or unions.
 847         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 848         Don't print either the top-level value, or the children if the
 849         max-depth is exceeded.
 850         (ppscm_print_children): When printing the key of a map, allow one
 851         extra level of depth.
 852         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 853         print either the top-level value, or the children if the max-depth
 854         is exceeded.
 855         (print_children): When printing the key of a map, allow one extra
 856         level of depth.
 857         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 858         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 859         (user_print_options): Initialise max_depth field.
 860         (val_print_scalar_or_string_type_p): New function.
 861         (val_print): Check to see if the max depth has been reached.
 862         (val_print_check_max_depth): Define new function.
 863         (show_print_max_depth): New function.
 864         (_initialize_valprint): Add 'print max-depth' option.
 865         * valprint.h (struct value_print_options) <max_depth>: New field.
 866         (val_print_check_max_depth): Declare new function.
 867         * NEWS: Document new feature.
 868
 869 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 870
 871         * ada-lang.c (ada_language_defn): Initialise new field.
 872         * c-lang.c (c_is_string_type_p): New function.
 873         (c_language_defn): Initialise new field.
 874         (cplus_language_defn): Initialise new field.
 875         (asm_language_defn): Initialise new field.
 876         (minimal_language_defn): Initialise new field.
 877         * c-lang.h (c_is_string_type_p): Declare new function.
 878         * d-lang.c (d_language_defn): Initialise new field.
 879         * f-lang.c (f_is_string_type_p): New function.
 880         (f_language_defn): Initialise new field.
 881         * go-lang.c (go_is_string_type_p): New function.
 882         (go_language_defn): Initialise new field.
 883         * language.c (default_is_string_type_p): New function.
 884         (unknown_language_defn): Initialise new field.
 885         (auto_language_defn): Initialise new field.
 886         * language.h (struct language_defn) <la_is_string_type_p>: New
 887         member variable.
 888         (default_is_string_type_p): Declare new function.
 889         * m2-lang.c (m2_language_defn): Initialise new field.
 890         * objc-lang.c (objc_language_defn): Initialise new field.
 891         * opencl-lang.c (opencl_language_defn): Initialise new field.
 892         * p-lang.c (pascal_is_string_type_p): New function.
 893         (pascal_language_defn): Initialise new field.
 894         * rust-lang.c (rust_is_string_type_p): New function.
 895         (rust_language_defn): Initialise new field.
 896
 897 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 898
 899         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 900         New field.
 901         * ada-lang.c (ada_language_defn): Initialise new field.
 902         * c-lang.c (c_language_defn): Likewise.
 903         (cplus_language_defn): Likewise.
 904         (asm_language_defn): Likewise.
 905         (minimal_language_defn): Likewise.
 906         * d-lang.c (d_language_defn): Likewise.
 907         * f-lang.c (f_language_defn): Likewise.
 908         * go-lang.c (go_language_defn): Likewise.
 909         * language.c (unknown_language_defn): Likewise.
 910         (auto_language_defn): Likewise.
 911         * m2-lang.c (m2_language_defn): Likewise.
 912         * objc-lang.c (objc_language_defn): Likewise.
 913         * opencl-lang.c (opencl_language_defn): Likewise.
 914         * p-lang.c (pascal_language_defn): Likewise.
 915         * rust-lang.c (rust_language_defn): Likewise.
 916
 917 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 918
 919         * ada-lang.c (ada_is_character_type): Change return type to bool.
 920         (ada_is_string_type): Likewise.
 921         * ada-lang.h (ada_is_character_type): Update declaration
 922         (ada_is_string_type): Likewise.
 923
 924 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 925
 926         Support style in 'frame|thread apply'
 927
 928         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 929         * record.c (record_start, record_stop): Update callers of
 930         execute_command_to_string with false.
 931         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 932         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 933         methods.
 934         (class string_file): New constructor with term_out parameter.
 935         Override methods term_out and can_emit_style_escape.  New member
 936         term_out.
 937         (class stdio_file): Override can_emit_style_escape.
 938         (class tee_file): Override term_out and can_emit_style_escape.
 939         * utils.h (can_emit_style_escape): Remove.
 940         * utils.c (can_emit_style_escape): Likewise.
 941         Update all callers of can_emit_style_escape (SOMESTREAM) to
 942         SOMESTREAM->can_emit_style_escape.
 943         * source-cache.c (source_cache::get_source_lines): Likewise.
 944         * stack.c (frame_apply_command_count): Call execute_command_to_string
 945         passing the term_out characteristic of the current gdb_stdout.
 946         * thread.c (thr_try_catch_cmd): Likewise.
 947         * top.c (execute_command_to_string): pass term_out parameter
 948         to construct the string_file for the command output.
 949         * ui-file.c (term_cli_styling): New function (most code moved
 950         from utils.c can_emit_style_escape).
 951         (string_file::string_file, string_file::can_emit_style_escape,
 952         stdio_file::can_emit_style_escape, tee_file::term_out,
 953         tee_file::can_emit_style_escape): New functions.
 954
 955 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 956
 957         * NEWS: Mention the new set|show may-call-functions.
 958         * infcall.c (may_call_functions_p): New variable.
 959         (show_may_call_functions_p): New function.
 960         (call_function_by_hand_dummy): Throws an error if not
 961         may-call-functions.
 962         (_initialize_infcall): Call add_setshow_boolean_cmd for
 963         may-call-functions.
 964
 965 2019-04-25  Keith Seitz  <keiths@redhat.com>
 966
 967         PR c++/24367
 968         * cp-support.c (inspect_type): Don't attempt substitutions
 969         of symbol with the same name.
 970
 971 2019-04-25  Tom Tromey  <tromey@adacore.com>
 972
 973         PR gdb/24475:
 974         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 975         static.
 976
 977 2019-04-25  Tom Tromey  <tromey@adacore.com>
 978
 979         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
 980         rvalue reference.
 981         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
 982         (gdb_xml_parser::parse): Use std::move.
 983         * python/python-internal.h (gdbpy_convert_exception): Take a const
 984         reference.
 985         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
 986         std::move.
 987         * python/py-utils.c (gdbpy_convert_exception): Take a const
 988         reference.
 989         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 990         Use std::move.
 991         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 992         Use std::move.
 993         * mi/mi-main.c (mi_print_exception): Take a const reference.
 994         * main.c (handle_command_errors): Take a const reference.
 995         * linespec.c (parse_linespec): Use std::move.
 996         * infcall.c (run_inferior_call): Use std::move.
 997         (call_function_by_hand_dummy): Use std::move.
 998         * exec.c (try_open_exec_file): Use std::move.
 999         * exceptions.h (exception_print, exception_fprintf)
1000         (exception_print_same): Update.
1001         * exceptions.c (print_exception, exception_print)
1002         (exception_fprintf, exception_print_same): Change parameters to
1003         const reference.
1004         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
1005         * common/new-op.c: Use std::move.
1006         * common/common-exceptions.h (struct gdb_exception): Add move
1007         constructor.
1008         (struct gdb_exception_error, struct gdb_exception_quit, struct
1009         gdb_quit_bad_alloc): Change constructor to move constructor.
1010         (throw_exception): Change parameter to rvalue reference.
1011         * common/common-exceptions.c (throw_exception): Take rvalue
1012         reference.
1013         * cli/cli-interp.c (safe_execute_command): Use std::move.
1014         * breakpoint.c (insert_bp_location, location_to_sals): Use
1015         std::move.
1016
1017 2019-04-25  Tom Tromey  <tromey@adacore.com>
1018
1019         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
1020         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
1021         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
1022         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
1023         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
1024         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
1025         guile/scm-value.c: Use unpack.
1026         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
1027         gdbscm_gdb_exception.
1028         (gdbscm_throw_gdb_exception): Likewise.
1029         (struct gdbscm_gdb_exception): New.
1030         (unpack): New function.
1031         (gdbscm_wrap): Use unpack.
1032
1033 2019-04-25  Tom Tromey  <tromey@adacore.com>
1034
1035         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1036         (gdb_rl_callback_handler): Use std::move.
1037         * common/common-exceptions.h (struct gdb_exception): Add move
1038         assignment operator.
1039         (throw_exception_sjlj): Change "exception" to const reference.
1040         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
1041         (throw_exception_sjlj): Change "exception" to const reference.
1042
1043 2019-04-25  Tom Tromey  <tromey@adacore.com>
1044
1045         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
1046         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
1047         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1048         Update.
1049         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1050         Update.
1051         * mi/mi-interp.c (mi_interp::exec): Update.
1052         * linespec.c (parse_linespec): Update.
1053         * infcall.c (run_inferior_call): Update.
1054         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
1055         * guile/scm-symbol.c (gdbscm_lookup_symbol)
1056         (gdbscm_lookup_global_symbol): Update.
1057         * guile/scm-param.c (gdbscm_parameter_value): Update.
1058         * guile/scm-frame.c (gdbscm_frame_read_register)
1059         (gdbscm_frame_read_var): Update.
1060         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
1061         * exec.c (try_open_exec_file): Update.
1062         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1063         (gdb_rl_callback_handler): Update.
1064         * common/common-exceptions.h (exception_none): Don't declare.
1065         * common/common-exceptions.c (exception_none): Don't define.
1066         (struct catcher) <exception>: Update.
1067         * cli/cli-interp.c (safe_execute_command): Update.
1068         * breakpoint.c (insert_bp_location, location_to_sals): Update.
1069
1070 2019-04-25  Ali Tamur  <tamur@google.com>
1071
1072         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
1073         (read_attribute_value): Likewise.
1074         (dwarf2_read_addr_index): Update comment.
1075         (read_str_index): Add DW_FORM_strx.
1076         (dwarf2_string_attr): Likewise.
1077         (dwarf2_const_value_attr): Likewise.
1078         (dump_die_shallow): Likewise.
1079         (dwarf2_fetch_constant_bytes): Likewise.
1080         (skip_form_bytes): Likewise.
1081         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
1082
1083 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
1084
1085         PR corefiles/11608
1086         PR corefiles/18187
1087         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
1088         OFFSET.  Verify if current mapping contains an ELF header.
1089         (linux_find_memory_regions_full): Adjust call to
1090         dump_mapping_p.
1091
1092 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
1093             Kang Li <kanglictf@gmail.com>
1094
1095         PR gdb/21600
1096
1097         * dwarf2-frame.c (read_initial_length): Be consistent about using
1098         unsigned representation of length.
1099         (decode_frame_entry_1): Likewise.  Check for wraparound of
1100         end pointer as well as buffer overflow.
1101
1102 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
1103
1104         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
1105         "vq".
1106
1107 2019-04-24  Tom Tromey  <tromey@adacore.com>
1108
1109         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
1110
1111 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1112
1113         * s12z-tdep.c (s12z_unwind_pc): Delete.
1114         (s12z_unwind_sp): Delete.
1115         (s12z_gdbarch_init): Don't register deleted functions with
1116         gdbarch.
1117
1118 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1119
1120         * rl78-tdep.c (rl78_unwind_sp): Delete.
1121         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
1122
1123 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1124
1125         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
1126         (xstormy16_unwind_pc): Delete.
1127         (xstormy16_dummy_id): Delete.
1128         (xstormy16_gdbarch_init): Don't register deleted functions with
1129         gdbarch.
1130
1131 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1132
1133         * vax-tdep.c (vax_unwind_pc): Delete.
1134         (vax_gdbarch_init): Don't register deleted function with gdbarch.
1135
1136 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1137
1138         * v850-tdep.c (v850_unwind_sp): Delete.
1139         (v850_unwind_pc): Delete.
1140         (v850_dummy_id): Delete.
1141         (v850_gdbarch_init): Don't register deleted functions with
1142         gdbarch.
1143
1144 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1145
1146         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
1147         (tilegx_unwind_pc): Delete.
1148         (tilegx_unwind_dummy_id): Delete.
1149         (tilegx_gdbarch_init): Don't register deleted functions with
1150         gdbarch.
1151
1152 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1153
1154         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
1155         (tic6x_dummy_id): Delete.
1156         (tic6x_gdbarch_init): Don't register deleted functions with
1157         gdbarch.
1158
1159 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1160
1161         * sparc-tdep.c (sparc_unwind_pc): Delete.
1162         (sparc32_gdbarch_init): Don't register deleted function with
1163         gdbarch.
1164
1165 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1166
1167         * sh-tdep.c (sh_unwind_sp): Delete.
1168         (sh_unwind_pc): Delete.
1169         (sh_dummy_id): Delete.
1170         (sh_gdbarch_init): Don't register deleted functions with
1171         gdbarch.
1172
1173 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1174
1175         * score-tdep.c (score_unwind_sp): Delete.
1176         (score_unwind_pc): Delete.
1177         (score_dummy_id): Delete.
1178         (score_gdbarch_init): Don't register deleted functions with
1179         gdbarch.
1180
1181 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1182
1183         * rx-tdep.c (rx_unwind_pc): Delete.
1184         (rx_unwind_sp): Delete.
1185         (rx_dummy_id): Delete.
1186         (rx_gdbarch_init): Don't register deleted functions with
1187         gdbarch.  Update comment.
1188
1189 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1190
1191         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
1192         (rs6000_dummy_id): Delete.
1193         (rs6000_gdbarch_init): Don't register deleted functions with
1194         gdbarch.
1195
1196 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1197
1198         * or1k-tdep.c (or1k_dummy_id): Delete.
1199         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
1200
1201 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1202
1203         * nios2-tdep.c (nios2_dummy_id): Delete.
1204         (nios2_unwind_sp): Delete.
1205         (nios2_gdbarch_init): Don't register deleted functions with
1206         gdbarch.
1207
1208 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1209
1210         * nds32-tdep.c (nds32_dummy_id): Delete.
1211         (nds32_unwind_pc): Delete.
1212         (nds32_unwind_sp): Delete.
1213         (nds32_gdbarch_init): Don't register deleted functions with
1214         gdbarch.
1215
1216 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1217
1218         * msp430-tdep.c (msp430_unwind_pc): Delete.
1219         (msp430_unwind_sp): Delete.
1220         (msp430_dummy_id): Delete.
1221         (msp430_gdbarch_init): Don't register deleted functions with
1222         gdbarch.
1223
1224 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1225
1226         * moxie-tdep.c (moxie_unwind_sp): Delete.
1227         (moxie_unwind_pc): Delete.
1228         (moxie_dummy_id): Delete.
1229         (moxie_gdbarch_init): Don't register deleted functions with
1230         gdbarch.
1231
1232 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1233
1234         * mn10300-tdep.c (mn10300_dummy_id): Delete.
1235         (mn10300_unwind_pc): Delete.
1236         (mn10300_unwind_sp): Delete.
1237         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
1238         mn10300_unwind_sp.
1239         (mn10300_frame_unwind_init): Don't register deleted functions with
1240         gdbarch.
1241
1242 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1243
1244         * mep-tdep.c (mep_unwind_pc): Delete.
1245         (mep_unwind_sp): Delete.
1246         (mep_dummy_id): Delete.
1247         (mep_gdbarch_init): Don't register deleted functions with
1248         gdbarch.
1249
1250 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1251
1252         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
1253         (m68hc11_unwind_sp): Delete.
1254         (m68hc11_gdbarch_init): Don't register deleted functions with
1255         gdbarch.
1256
1257 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1258
1259         * m32r-tdep.c (m32r_unwind_sp): Delete.
1260         (m32r_unwind_pc): Delete.
1261         (m32r_dummy_id): Delete.
1262         (m32r_gdbarch_init): Don't register deleted functions with
1263         gdbarch.
1264
1265 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1266
1267         * m32c-tdep.c (m32c_unwind_pc): Delete.
1268         (m32c_unwind_sp): Delete.
1269         (m32c_dummy_id): Delete.
1270         (m32c_gdbarch_init): Don't register deleted functions with
1271         gdbarch.
1272
1273 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1274
1275         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
1276         (lm32_unwind_pc): Delete.
1277         (lm32_dummy_id): Delete.
1278         (lm32_gdbarch_init): Don't register deleted functions with
1279         gdbarch.
1280
1281 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1282
1283         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
1284         (iq2000_unwind_pc): Delete.
1285         (iq2000_dummy_id): Delete.
1286         (iq2000_gdbarch_init): Don't register deleted functions with
1287         gdbarch.
1288
1289 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1290
1291         * nds32-tdep.c (nds32_type_align): Delete.
1292         (nds32_push_dummy_call): Use type_align instead.
1293
1294 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1295
1296         * arm-tdep.c (arm_type_align): Only handle vector override case.
1297         (arm_push_dummy_call): Use type_align.
1298         (arm_gdbarch_init): Register arm_type_align gdbarch function.
1299
1300 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1301
1302         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
1303         case.
1304         (pass_on_stack): Use type_align.
1305         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
1306         function.
1307
1308 2019-04-23  Tom Tromey  <tromey@adacore.com>
1309
1310         * dwarf2read.c (line_header::file_name_at): Remove unused
1311         overload.
1312
1313 2019-04-23  Tom de Vries  <tdevries@suse.de>
1314
1315         PR gdb/24438
1316         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
1317         invocation.
1318
1319
1320 2019-03-27  Ali Tamur  <tamur@google.com>
1321
1322         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
1323         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
1324         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
1325         (dwarf_expr_context::get_addr_index): Likewise
1326         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
1327         (symbol_needs_eval_context::get_addr_index): Likewise
1328         (disassemble_dwarf_expression): Add DW_OP_addrx
1329         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
1330         (read_cutu_die_from_dwo): Update comment
1331         (skip_one_die): Add DW_FORM_addrx
1332         (read_attribute_value): Likewise
1333         (var_decode_location): Add DW_OP_addrx
1334         (dwarf2_const_value_attr): Add DW_FORM_addrx
1335         (dump_die_shallow): Likewise
1336         (dwarf2_fetch_constant_bytes): Likewise
1337         (decode_locdesc): Add DW_OP_addrx
1338         (skip_form_bytes): Add DW_FORM_addrx
1339
1340 2019-04-22  Ali Tamur  <tamur@google.com>
1341
1342         * MAINTAINERS (Write After Approval): Add self.
1343
1344 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
1345
1346         * solib-svr4.c (get_svr4_info): Add pspace parameter.
1347         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
1348         (open_symbol_file_object): Likewise.
1349         (svr4_default_sos): Add info parameter.
1350         (svr4_read_so_list): Likewise.
1351         (svr4_current_sos_direct): Adjust functions calls to pass down
1352         info.
1353         (svr4_current_sos_1): Add info parameter.
1354         (svr4_current_sos): Call get_svr4_info, pass info down to
1355         svr4_current_sos_1.
1356         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
1357         get_svr4_info.
1358         (svr4_in_dynsym_resolve_code): Pass current_program_space to
1359         get_svr4_info.
1360         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
1361         to get_svr4_info.
1362         (probes_table_remove_objfile_probes): Likewise.
1363         (register_solib_event_probe): Add info parameter.
1364         (solist_update_incremental): Pass info parameter down to
1365         svr4_read_so_list.
1366         (disable_probes_interface): Add info parameter.
1367         (svr4_handle_solib_event): Pass current_program_space to
1368         get_svr4_info.  Adjust disable_probes_interface cleanup.
1369         (svr4_create_probe_breakpoints): Add info parameter, pass it
1370         down to register_solib_event_probe.
1371         (svr4_create_solib_event_breakpoints): Add info parameter,
1372         pass it down to svr4_create_probe_breakpoints.
1373         (enable_break): Pass info down to
1374         svr4_create_solib_event_breakpoints.
1375         (svr4_solib_create_inferior_hook): Pass current_program_space to
1376         get_svr4_info.
1377         (svr4_clear_solib): Likewise.
1378
1379 2019-04-22  Pedro Alves  <palves@redhat.com>
1380
1381         * solib-svr4.c (svr4_free_objfile_observer): New.
1382         (probe_and_action::objfile): New field.
1383         (probes_table_htab_remove_objfile_probes)
1384         (probes_table_remove_objfile_probes): New functions.
1385         (register_solib_event_probe): Add 'objfile' parameter.  Store it
1386         in the new probe_and_action.  Don't store the probe in 'lookup'.
1387         (svr4_create_probe_breakpoints): Pass objfile to
1388         register_solib_event_probe.
1389         (_initialize_svr4_solib): Register a free_objfile observer.
1390
1391 2019-04-19  Tom Tromey  <tom@tromey.com>
1392
1393         * common/queue.h: Remove.
1394
1395 2019-04-19  Tom Tromey  <tom@tromey.com>
1396
1397         * event-loop.c: Don't include "common/queue.h".
1398
1399 2019-04-19  Tom Tromey  <tom@tromey.com>
1400
1401         * remote.c (remote_target): Use delete.
1402         * remote-notif.h: Include <list>, not "common/queue.h".
1403         (notif_client_p): Remove typedef.
1404         (remote_notif_state): Add constructor, destructor, initializer.
1405         <notif_queue>: Now a std::list.
1406         (remote_notif_state_xfree): Don't declare.
1407         * remote-notif.c (remote_notif_process, handle_notification)
1408         (remote_notif_state_allocate): Update.
1409         (~remote_notif_state): Rename from remote_notif_state_xfree.
1410
1411 2019-04-19  Tom Tromey  <tom@tromey.com>
1412
1413         * symfile.c (reread_symbols): Update.
1414         * objfiles.c (objfile_register_static_link)
1415         (objfile_lookup_static_link): Update
1416         (~objfile) Don't delete static_links.
1417         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
1418
1419 2019-04-19  Tom Tromey  <tom@tromey.com>
1420
1421         * type-stack.h (struct type_stack) <insert>: Constify string.
1422         * type-stack.c (type_stack::insert): Constify string.
1423         * gdbtypes.h (lookup_template_type): Update.
1424         (address_space_name_to_int): Update.
1425         * gdbtypes.c (address_space_name_to_int): Make space_identifier
1426         const.
1427         (lookup_template_type): Make name const.
1428         * c-exp.y: Update rules.
1429         (lex_one_token, classify_name, classify_inner_name)
1430         (c_print_token): Update.
1431         * p-exp.y: Update rules.
1432         (yylex): Update.
1433         * f-exp.y: Update rules.
1434         (yylex): Update.
1435         * d-exp.y: Update rules.
1436         (lex_one_token, classify_name, classify_inner_name): Update.
1437         * parse.c (write_dollar_variable, copy_name): Return std::string.
1438         * parser-defs.h (copy_name): Change return type.
1439         * m2-exp.y: Update rules.
1440         (yylex): Update.
1441         * go-exp.y (lex_one_token): Update.
1442         Update rules.
1443         (classify_unsafe_function, classify_packaged_name)
1444         (classify_name, yylex): Update.
1445
1446 2019-04-19  Sergei Trofimovich <siarheit@google.com>
1447
1448         * configure.ac: add --enable-source-highlight switch.
1449         * configure: Regenerate.
1450         * top.c (print_gdb_version): plumb --enable-source-highlight
1451         status to "show configuration".
1452
1453 2019-04-19  Tom Tromey  <tromey@adacore.com>
1454
1455         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
1456         Check ADA_TYPE_P.
1457         (empty_record, ada_template_to_fixed_record_type_1)
1458         (template_to_static_fixed_type)
1459         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
1460         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
1461         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
1462         macros.
1463
1464 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
1465
1466         PR symtab/24423:
1467         * source.c (print_source_lines_base): Advance "iter" when a
1468         control character is seen.
1469
1470 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1471
1472         * inferior.h (struct infcall_suspend_state_deleter):
1473         Catch exception in destructor to avoid crash.
1474
1475 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1476
1477         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
1478         close to the add_com "shell".
1479
1480 2019-04-18  Tom Tromey  <tromey@adacore.com>
1481
1482         * process-stratum-target.h (class process_stratum_target)
1483         <stratum>: Add "final".
1484
1485 2019-04-17  Tom Tromey  <tromey@adacore.com>
1486
1487         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
1488         against nullptr before use.
1489
1490 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
1491
1492         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
1493
1494 2019-04-17  Jim Wilson  <jimw@sifive.com>
1495             Andrew Burgess  <andrew.burgess@embecosm.com>
1496
1497         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
1498         code read might fail, assume 4-byte breakpoint in that case.
1499
1500 2019-04-15  Leszek Swirski  <leszeks@google.com>
1501
1502         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
1503         rather than a hand-rolled POD check when checking for forced MEMORY
1504         classification.
1505
1506 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1507
1508         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
1509         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
1510         function.
1511         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
1512         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
1513         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
1514         declaration.
1515
1516 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1517
1518         * aarch64-linux-nat.c
1519         (aarch64_linux_nat_target::thread_architecture): Add override.
1520         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
1521         each VQ.
1522
1523 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1524
1525         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
1526
1527 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
1528
1529         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
1530         target types of size 96-bits, add some additional comments, and
1531         check that the builtin type we found was the correct size.
1532
1533 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
1534
1535         * utils.c (prompt_for_continue): Don't restore the styling at the
1536         end, as applied_style has the wrong value.  This fixes styling in
1537         long lists of file names that are interrupted by the "Continue?"
1538         prompt.
1539
1540 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1541
1542         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
1543         * c-lang.c (c_language_defn): Likewise.
1544         (cplus_language_defn): Likewise.
1545         (asm_language_defn): Likewise.
1546         (minimal_language_defn): Likewise.
1547         * d-lang.c (d_language_defn): Likewise.
1548         * f-lang.c (f_language_defn): Likewise.
1549         * go-lang.c (go_language_defn): Likewise.
1550         * language.c (unknown_language_defn): Likewise.
1551         (auto_language_defn): Likewise.
1552         * language.h (struct language_defn): Remove la_magic field.
1553         (LANG_MAGIC): Delete.
1554         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
1555         * objc-lang.c (objc_language_defn): Likewise.
1556         * opencl-lang.c (opencl_language_defn): Likewise.
1557         * p-lang.c (pascal_language_defn): Likewise.
1558         * rust-lang.c (rust_language_defn): Likewise.
1559
1560 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1561
1562         * riscv-tdep.c (riscv_type_align): New function.
1563         (riscv_type_alignment): Delete.
1564         (riscv_arg_location): Use 'type_align'.
1565         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
1566
1567 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1568
1569         * gdbtypes.c (type_align): A struct with no non-static fields also
1570         has alignment of 1.
1571
1572 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1573
1574         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
1575         component to 0.
1576         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
1577         member.
1578         (riscv_struct_info::analyse): New implementation using new
1579         analyse_inner member function.
1580         (riscv_struct_info::field_offset): New member function.
1581         (riscv_struct_info::m_offsets): New member variable.
1582         (riscv_struct_info::analyse_inner): New private member function,
1583         takes the old implementation of riscv_struct_info::analyse but
1584         extended to track field offsets.
1585         (riscv_call_arg_struct): Update the struct folding special cases
1586         to handle cases where empty C++ structs, which are non-zero
1587         length, are found.
1588         (riscv_arg_location): Initialise the length of each location, a
1589         non-zero length now indicates the location is in use.
1590         (riscv_push_dummy_call): Allow for the first location having a
1591         non-zero offset when setting up arguments.
1592         (riscv_return_value): Likewise, but for return values.
1593
1594 2019-04-11  Tom Tromey  <tromey@adacore.com>
1595
1596         * utils.c (internal_vproblem): Make "msg" const.
1597
1598 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
1599
1600         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
1601         * trad-frame.c (trad_frame_reset_saved_regs): New function.
1602         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
1603         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
1604
1605 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
1606
1607         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
1608         function.
1609         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1610         of amd64_collect_native_gregset.
1611         (amd64_linux_nat_target::store_registers): Likewise.
1612
1613 2019-04-10  Tom Tromey  <tom@tromey.com>
1614
1615         * symtab.c (lookup_global_symbol_from_objfile)
1616         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1617         * objfiles.h (class separate_debug_iterator): New.
1618         (class separate_debug_range): New.
1619         (struct objfile) <separate_debug_objfiles>: New method.
1620         (objfile_separate_debug_iterate): Don't declare.
1621         * objfiles.c (separate_debug_iterator::operator++): Rename from
1622         objfile_separate_debug_iterate.
1623         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1624         iterator.
1625         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1626         iterator.
1627
1628 2019-04-10  Tom Tromey  <tom@tromey.com>
1629
1630         * symfile.c (reread_symbols): Remove old comment.
1631         * objfiles.c (free_all_objfiles): Fix a typo.
1632
1633 2019-04-10  Tom Tromey  <tom@tromey.com>
1634
1635         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1636         * minsyms.c (lookup_minimal_symbol): Use foreach.
1637         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1638         (lookup_minimal_symbol_solib_trampoline): Likewise.
1639         * symfile.c (reread_symbols): Use foreach.
1640
1641 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1642             Tom Tromey  <tromey@adacore.com>
1643
1644         PR rust/24414:
1645         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1646         (rust_lex_int_test): Change "value" to be LONGEST.
1647         (rust_lex_tests): Add test for long integer literal.
1648
1649 2019-04-09  Tom Tromey  <tromey@adacore.com>
1650
1651         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1652         to bool.
1653         (extended_remote_target::attach): Update.
1654         (remote_target::remote_notice_new_inferior): Update.
1655         (remote_target::add_current_inferior_and_thread): Update.
1656         * inferior.c (exit_inferior_1): Use "false".
1657         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1658
1659 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1660
1661         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1662         the "start" command.
1663
1664 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1665
1666         * python/py-inferior.c (infpy_thread_from_thread_handle):
1667         Adjust comments to reflect renaming of thread_from_thread_handle
1668         to thread_from_handle.  Adjust keywords.  Fix type error message.
1669         (inferior_object_methods): Add thread_from_handle.  Retain
1670         thread_from_thread_handle, but mark it as deprecated.
1671
1672 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1673
1674         * gdbthread.h (find_thread_by_handle): Revise declaration.
1675         * thread.c (find_thread_by_handle): Likewise.  Adjust
1676         implementation too.
1677         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1678         support for buffer objects as handles.
1679
1680 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1681
1682         * python/py-infthread.c (thpy_thread_handle): New function.
1683         (thread_object_methods): Register thpy_thread_handle.
1684
1685 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1686
1687         * gdbthread.h (thread_to_thread_handle): Declare.
1688         * thread.c (gdbtypes.h): Include.
1689         (thread_to_thread_handle): New function.
1690
1691         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1692         (target_thread_info_to_thread_handle): Declare.
1693         * target.c (target_thread_info_to_thread_handle): New function.
1694         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1695         * target-delegates.c: Regenerate.
1696
1697         * linux-thread-db.c (class thread_db_target): Add method
1698         thread_info_to_thread_handle.
1699         (thread_db_target::thread_info_to_thread_handle): Define.
1700         * remote.c (class remote_target): Add new method
1701         thread_info_to_thread_handle.
1702         (remote_target::thread_info_to_thread_handle): Define.
1703
1704 2019-04-08  Pedro Alves  <palves@redhat.com>
1705
1706         * common/common-exceptions.c (throw_exception): Don't create
1707         named object to throw; throw directly.
1708         (throw_it): Likewise.  Don't initialize gdb_exception::message
1709         here, with new; pass FMT and AP to the ctor instead.
1710         * common/common-exceptions.h: Include <string>.
1711         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1712         const char *, va_list)): New ctor.  Use std::make_shared.
1713         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1714         errors)): Delete.
1715         (gdb_exception_error::gdb_exception_error(enum errors, const char
1716         *, va_list)): New.
1717         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1718         Add assertion.
1719         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1720         errors)): Delete.
1721         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1722         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1723         Add assertion.
1724
1725 2019-04-08  Tom Tromey  <tom@tromey.com>
1726
1727         * valops.c (value_rtti_indirect_type): Replace throw_exception
1728         with throw.
1729         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1730         with throw.
1731         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1732         throw.
1733         * target.c (target_translate_tls_address): Replace throw_exception
1734         with throw.
1735         * stack.c (frame_apply_command_count): Replace throw_exception
1736         with throw.
1737         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1738         throw.
1739         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1740         with throw.
1741         * rs6000-tdep.c (rs6000_frame_cache)
1742         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1743         * remote.c: Replace throw_exception with throw.
1744         * record-full.c (record_full_message, record_full_wait_1)
1745         (record_full_restore): Replace throw_exception with throw.
1746         * record-btrace.c:
1747         (get_thread_current_frame_id, record_btrace_start_replaying)
1748         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1749         (cmd_record_btrace_start): Replace throw_exception with throw.
1750         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1751         throw.
1752         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1753         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1754         * linespec.c:
1755         (find_linespec_symbols): Replace throw_exception with throw.
1756         * infrun.c (displaced_step_prepare, resume): Replace
1757         throw_exception with throw.
1758         * infcmd.c (post_create_inferior): Replace throw_exception with
1759         throw.
1760         * inf-loop.c (inferior_event_handler): Replace throw_exception
1761         with throw.
1762         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1763         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1764         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1765         (get_prev_frame_always, get_frame_pc_if_available)
1766         (get_frame_address_in_block_if_available, get_frame_language):
1767         Replace throw_exception with throw.
1768         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1769         throw_exception with throw.
1770         * eval.c (fetch_subexp_value, evaluate_var_value)
1771         (evaluate_funcall, evaluate_subexp_standard): Replace
1772         throw_exception with throw.
1773         * dwarf2loc.c (call_site_find_chain)
1774         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1775         Replace throw_exception with throw.
1776         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1777         with throw.
1778         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1779         throw.
1780         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1781         * completer.c (complete_line_internal): Replace throw_exception
1782         with throw.
1783         * compile/compile-object-run.c (compile_object_run): Replace
1784         throw_exception with throw.
1785         * cli/cli-script.c (process_next_line): Replace throw_exception
1786         with throw.
1787         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1788         (btrace_enable, btrace_maint_update_pt_packets): Replace
1789         throw_exception with throw.
1790         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1791         throw_exception with throw.
1792         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1793         throw_exception with throw.
1794         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1795         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1796         * aarch64-tdep.c (aarch64_make_prologue_cache)
1797         (aarch64_make_stub_cache): Replace throw_exception with throw.
1798
1799 2019-04-08  Tom Tromey  <tom@tromey.com>
1800
1801         * common/common-exceptions.c (throw_exception): Rename from
1802         throw_exception_cxx.  Remove old copy.  Make argument const.
1803         (throw_it): Create and throw exception objects directly.
1804         * common/common-exceptions.h (throw_exception): Make argument
1805         const.
1806         (struct gdb_exception_error): Add constructor.
1807         (struct gdb_exception_quit): Add constructor.
1808
1809 2019-04-08  Tom Tromey  <tom@tromey.com>
1810
1811         * common/common-exceptions.h (exception_rethrow): Don't declare.
1812         (TRY_SJLJ): Update comment.
1813         (TRY, CATCH, END_CATCH): Remove.
1814         * common/common-exceptions.c (exception_rethrow): Remove.
1815
1816 2019-04-08  Tom Tromey  <tom@tromey.com>
1817
1818         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1819         Remove.
1820         (gdb_exception_error): Rename from
1821         gdb_exception_RETURN_MASK_ERROR.
1822         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1823         (gdb_quit_bad_alloc): Update.
1824         * aarch64-tdep.c: Update.
1825         * ada-lang.c: Update.
1826         * ada-typeprint.c: Update.
1827         * ada-valprint.c: Update.
1828         * amd64-tdep.c: Update.
1829         * arch-utils.c: Update.
1830         * break-catch-throw.c: Update.
1831         * breakpoint.c: Update.
1832         * btrace.c: Update.
1833         * c-varobj.c: Update.
1834         * cli/cli-cmds.c: Update.
1835         * cli/cli-interp.c: Update.
1836         * cli/cli-script.c: Update.
1837         * common/common-exceptions.c: Update.
1838         * common/new-op.c: Update.
1839         * common/selftest.c: Update.
1840         * compile/compile-c-symbols.c: Update.
1841         * compile/compile-cplus-symbols.c: Update.
1842         * compile/compile-object-load.c: Update.
1843         * compile/compile-object-run.c: Update.
1844         * completer.c: Update.
1845         * corelow.c: Update.
1846         * cp-abi.c: Update.
1847         * cp-support.c: Update.
1848         * cp-valprint.c: Update.
1849         * darwin-nat.c: Update.
1850         * disasm-selftests.c: Update.
1851         * dtrace-probe.c: Update.
1852         * dwarf-index-cache.c: Update.
1853         * dwarf-index-write.c: Update.
1854         * dwarf2-frame-tailcall.c: Update.
1855         * dwarf2-frame.c: Update.
1856         * dwarf2loc.c: Update.
1857         * dwarf2read.c: Update.
1858         * eval.c: Update.
1859         * event-loop.c: Update.
1860         * event-top.c: Update.
1861         * exec.c: Update.
1862         * f-valprint.c: Update.
1863         * fbsd-tdep.c: Update.
1864         * frame-unwind.c: Update.
1865         * frame.c: Update.
1866         * gdbtypes.c: Update.
1867         * gnu-v3-abi.c: Update.
1868         * guile/guile-internal.h: Update.
1869         * guile/scm-block.c: Update.
1870         * guile/scm-breakpoint.c: Update.
1871         * guile/scm-cmd.c: Update.
1872         * guile/scm-disasm.c: Update.
1873         * guile/scm-frame.c: Update.
1874         * guile/scm-lazy-string.c: Update.
1875         * guile/scm-math.c: Update.
1876         * guile/scm-param.c: Update.
1877         * guile/scm-ports.c: Update.
1878         * guile/scm-pretty-print.c: Update.
1879         * guile/scm-symbol.c: Update.
1880         * guile/scm-symtab.c: Update.
1881         * guile/scm-type.c: Update.
1882         * guile/scm-value.c: Update.
1883         * i386-linux-tdep.c: Update.
1884         * i386-tdep.c: Update.
1885         * inf-loop.c: Update.
1886         * infcall.c: Update.
1887         * infcmd.c: Update.
1888         * infrun.c: Update.
1889         * jit.c: Update.
1890         * language.c: Update.
1891         * linespec.c: Update.
1892         * linux-fork.c: Update.
1893         * linux-nat.c: Update.
1894         * linux-tdep.c: Update.
1895         * linux-thread-db.c: Update.
1896         * main.c: Update.
1897         * mi/mi-cmd-break.c: Update.
1898         * mi/mi-cmd-stack.c: Update.
1899         * mi/mi-interp.c: Update.
1900         * mi/mi-main.c: Update.
1901         * objc-lang.c: Update.
1902         * p-valprint.c: Update.
1903         * parse.c: Update.
1904         * ppc-linux-tdep.c: Update.
1905         * printcmd.c: Update.
1906         * python/py-arch.c: Update.
1907         * python/py-breakpoint.c: Update.
1908         * python/py-cmd.c: Update.
1909         * python/py-finishbreakpoint.c: Update.
1910         * python/py-frame.c: Update.
1911         * python/py-framefilter.c: Update.
1912         * python/py-gdb-readline.c: Update.
1913         * python/py-inferior.c: Update.
1914         * python/py-infthread.c: Update.
1915         * python/py-lazy-string.c: Update.
1916         * python/py-linetable.c: Update.
1917         * python/py-objfile.c: Update.
1918         * python/py-param.c: Update.
1919         * python/py-prettyprint.c: Update.
1920         * python/py-progspace.c: Update.
1921         * python/py-record-btrace.c: Update.
1922         * python/py-record.c: Update.
1923         * python/py-symbol.c: Update.
1924         * python/py-type.c: Update.
1925         * python/py-unwind.c: Update.
1926         * python/py-utils.c: Update.
1927         * python/py-value.c: Update.
1928         * python/python.c: Update.
1929         * record-btrace.c: Update.
1930         * record-full.c: Update.
1931         * remote-fileio.c: Update.
1932         * remote.c: Update.
1933         * riscv-tdep.c: Update.
1934         * rs6000-aix-tdep.c: Update.
1935         * rs6000-tdep.c: Update.
1936         * rust-exp.y: Update.
1937         * rust-lang.c: Update.
1938         * s390-tdep.c: Update.
1939         * selftest-arch.c: Update.
1940         * solib-dsbt.c: Update.
1941         * solib-frv.c: Update.
1942         * solib-spu.c: Update.
1943         * solib-svr4.c: Update.
1944         * solib.c: Update.
1945         * sparc64-linux-tdep.c: Update.
1946         * stack.c: Update.
1947         * symfile-mem.c: Update.
1948         * symmisc.c: Update.
1949         * target.c: Update.
1950         * thread.c: Update.
1951         * top.c: Update.
1952         * tracefile-tfile.c: Update.
1953         * tui/tui.c: Update.
1954         * typeprint.c: Update.
1955         * unittests/cli-utils-selftests.c: Update.
1956         * unittests/parse-connection-spec-selftests.c: Update.
1957         * valops.c: Update.
1958         * valprint.c: Update.
1959         * value.c: Update.
1960         * varobj.c: Update.
1961         * windows-nat.c: Update.
1962         * x86-linux-nat.c: Update.
1963         * xml-support.c: Update.
1964
1965 2019-04-08  Tom Tromey  <tom@tromey.com>
1966
1967         * xml-support.c: Use C++ exception handling.
1968         * x86-linux-nat.c: Use C++ exception handling.
1969         * windows-nat.c: Use C++ exception handling.
1970         * varobj.c: Use C++ exception handling.
1971         * value.c: Use C++ exception handling.
1972         * valprint.c: Use C++ exception handling.
1973         * valops.c: Use C++ exception handling.
1974         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1975         handling.
1976         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1977         * typeprint.c: Use C++ exception handling.
1978         * tui/tui.c: Use C++ exception handling.
1979         * tracefile-tfile.c: Use C++ exception handling.
1980         * top.c: Use C++ exception handling.
1981         * thread.c: Use C++ exception handling.
1982         * target.c: Use C++ exception handling.
1983         * symmisc.c: Use C++ exception handling.
1984         * symfile-mem.c: Use C++ exception handling.
1985         * stack.c: Use C++ exception handling.
1986         * sparc64-linux-tdep.c: Use C++ exception handling.
1987         * solib.c: Use C++ exception handling.
1988         * solib-svr4.c: Use C++ exception handling.
1989         * solib-spu.c: Use C++ exception handling.
1990         * solib-frv.c: Use C++ exception handling.
1991         * solib-dsbt.c: Use C++ exception handling.
1992         * selftest-arch.c: Use C++ exception handling.
1993         * s390-tdep.c: Use C++ exception handling.
1994         * rust-lang.c: Use C++ exception handling.
1995         * rust-exp.y: Use C++ exception handling.
1996         * rs6000-tdep.c: Use C++ exception handling.
1997         * rs6000-aix-tdep.c: Use C++ exception handling.
1998         * riscv-tdep.c: Use C++ exception handling.
1999         * remote.c: Use C++ exception handling.
2000         * remote-fileio.c: Use C++ exception handling.
2001         * record-full.c: Use C++ exception handling.
2002         * record-btrace.c: Use C++ exception handling.
2003         * python/python.c: Use C++ exception handling.
2004         * python/py-value.c: Use C++ exception handling.
2005         * python/py-utils.c: Use C++ exception handling.
2006         * python/py-unwind.c: Use C++ exception handling.
2007         * python/py-type.c: Use C++ exception handling.
2008         * python/py-symbol.c: Use C++ exception handling.
2009         * python/py-record.c: Use C++ exception handling.
2010         * python/py-record-btrace.c: Use C++ exception handling.
2011         * python/py-progspace.c: Use C++ exception handling.
2012         * python/py-prettyprint.c: Use C++ exception handling.
2013         * python/py-param.c: Use C++ exception handling.
2014         * python/py-objfile.c: Use C++ exception handling.
2015         * python/py-linetable.c: Use C++ exception handling.
2016         * python/py-lazy-string.c: Use C++ exception handling.
2017         * python/py-infthread.c: Use C++ exception handling.
2018         * python/py-inferior.c: Use C++ exception handling.
2019         * python/py-gdb-readline.c: Use C++ exception handling.
2020         * python/py-framefilter.c: Use C++ exception handling.
2021         * python/py-frame.c: Use C++ exception handling.
2022         * python/py-finishbreakpoint.c: Use C++ exception handling.
2023         * python/py-cmd.c: Use C++ exception handling.
2024         * python/py-breakpoint.c: Use C++ exception handling.
2025         * python/py-arch.c: Use C++ exception handling.
2026         * printcmd.c: Use C++ exception handling.
2027         * ppc-linux-tdep.c: Use C++ exception handling.
2028         * parse.c: Use C++ exception handling.
2029         * p-valprint.c: Use C++ exception handling.
2030         * objc-lang.c: Use C++ exception handling.
2031         * mi/mi-main.c: Use C++ exception handling.
2032         * mi/mi-interp.c: Use C++ exception handling.
2033         * mi/mi-cmd-stack.c: Use C++ exception handling.
2034         * mi/mi-cmd-break.c: Use C++ exception handling.
2035         * main.c: Use C++ exception handling.
2036         * linux-thread-db.c: Use C++ exception handling.
2037         * linux-tdep.c: Use C++ exception handling.
2038         * linux-nat.c: Use C++ exception handling.
2039         * linux-fork.c: Use C++ exception handling.
2040         * linespec.c: Use C++ exception handling.
2041         * language.c: Use C++ exception handling.
2042         * jit.c: Use C++ exception handling.
2043         * infrun.c: Use C++ exception handling.
2044         * infcmd.c: Use C++ exception handling.
2045         * infcall.c: Use C++ exception handling.
2046         * inf-loop.c: Use C++ exception handling.
2047         * i386-tdep.c: Use C++ exception handling.
2048         * i386-linux-tdep.c: Use C++ exception handling.
2049         * guile/scm-value.c: Use C++ exception handling.
2050         * guile/scm-type.c: Use C++ exception handling.
2051         * guile/scm-symtab.c: Use C++ exception handling.
2052         * guile/scm-symbol.c: Use C++ exception handling.
2053         * guile/scm-pretty-print.c: Use C++ exception handling.
2054         * guile/scm-ports.c: Use C++ exception handling.
2055         * guile/scm-param.c: Use C++ exception handling.
2056         * guile/scm-math.c: Use C++ exception handling.
2057         * guile/scm-lazy-string.c: Use C++ exception handling.
2058         * guile/scm-frame.c: Use C++ exception handling.
2059         * guile/scm-disasm.c: Use C++ exception handling.
2060         * guile/scm-cmd.c: Use C++ exception handling.
2061         * guile/scm-breakpoint.c: Use C++ exception handling.
2062         * guile/scm-block.c: Use C++ exception handling.
2063         * guile/guile-internal.h: Use C++ exception handling.
2064         * gnu-v3-abi.c: Use C++ exception handling.
2065         * gdbtypes.c: Use C++ exception handling.
2066         * frame.c: Use C++ exception handling.
2067         * frame-unwind.c: Use C++ exception handling.
2068         * fbsd-tdep.c: Use C++ exception handling.
2069         * f-valprint.c: Use C++ exception handling.
2070         * exec.c: Use C++ exception handling.
2071         * event-top.c: Use C++ exception handling.
2072         * event-loop.c: Use C++ exception handling.
2073         * eval.c: Use C++ exception handling.
2074         * dwarf2read.c: Use C++ exception handling.
2075         * dwarf2loc.c: Use C++ exception handling.
2076         * dwarf2-frame.c: Use C++ exception handling.
2077         * dwarf2-frame-tailcall.c: Use C++ exception handling.
2078         * dwarf-index-write.c: Use C++ exception handling.
2079         * dwarf-index-cache.c: Use C++ exception handling.
2080         * dtrace-probe.c: Use C++ exception handling.
2081         * disasm-selftests.c: Use C++ exception handling.
2082         * darwin-nat.c: Use C++ exception handling.
2083         * cp-valprint.c: Use C++ exception handling.
2084         * cp-support.c: Use C++ exception handling.
2085         * cp-abi.c: Use C++ exception handling.
2086         * corelow.c: Use C++ exception handling.
2087         * completer.c: Use C++ exception handling.
2088         * compile/compile-object-run.c: Use C++ exception handling.
2089         * compile/compile-object-load.c: Use C++ exception handling.
2090         * compile/compile-cplus-symbols.c: Use C++ exception handling.
2091         * compile/compile-c-symbols.c: Use C++ exception handling.
2092         * common/selftest.c: Use C++ exception handling.
2093         * common/new-op.c: Use C++ exception handling.
2094         * cli/cli-script.c: Use C++ exception handling.
2095         * cli/cli-interp.c: Use C++ exception handling.
2096         * cli/cli-cmds.c: Use C++ exception handling.
2097         * c-varobj.c: Use C++ exception handling.
2098         * btrace.c: Use C++ exception handling.
2099         * breakpoint.c: Use C++ exception handling.
2100         * break-catch-throw.c: Use C++ exception handling.
2101         * arch-utils.c: Use C++ exception handling.
2102         * amd64-tdep.c: Use C++ exception handling.
2103         * ada-valprint.c: Use C++ exception handling.
2104         * ada-typeprint.c: Use C++ exception handling.
2105         * ada-lang.c: Use C++ exception handling.
2106         * aarch64-tdep.c: Use C++ exception handling.
2107
2108 2019-04-08  Tom Tromey  <tom@tromey.com>
2109
2110         * xml-support.c (gdb_xml_parser::parse): Update.
2111         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2112         * value.c (show_convenience): Update.
2113         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
2114         (test_parse_flags_qcs): Update.
2115         * thread.c (thr_try_catch_cmd): Update.
2116         * target.c (target_translate_tls_address): Update.
2117         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2118         (info_frame_command_core, frame_apply_command_count): Update.
2119         * rust-exp.y (rust_lex_exception_test): Update.
2120         * riscv-tdep.c (riscv_print_one_register_info): Update.
2121         * remote.c (remote_target::enable_btrace): Update.
2122         * record-btrace.c (record_btrace_enable_warn): Update.
2123         * python/py-utils.c (gdbpy_convert_exception): Update.
2124         * printcmd.c (do_one_display, print_variable_and_value): Update.
2125         * mi/mi-main.c (mi_print_exception): Update.
2126         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
2127         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2128         * linux-nat.c (linux_nat_target::attach): Update.
2129         * linux-fork.c (class scoped_switch_fork_info): Update.
2130         * infrun.c (displaced_step_prepare): Update.
2131         * infcall.c (call_function_by_hand_dummy): Update.
2132         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
2133         * gnu-v3-abi.c (print_one_vtable): Update.
2134         * frame.c (get_prev_frame_always): Update.
2135         * f-valprint.c (info_common_command_for_block): Update.
2136         * exec.c (try_open_exec_file): Update.
2137         * exceptions.c (print_exception, exception_print)
2138         (exception_fprintf, exception_print_same): Update.
2139         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
2140         * dwarf-index-cache.c (index_cache::store)
2141         (index_cache::lookup_gdb_index): Update.
2142         * darwin-nat.c (maybe_cache_shell): Update.
2143         * cp-valprint.c (cp_print_value_fields): Update.
2144         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
2145         (gcc_cplus_symbol_address): Update.
2146         * compile/compile-c-symbols.c (gcc_convert_symbol)
2147         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
2148         * common/selftest.c: Update.
2149         * common/common-exceptions.h (struct gdb_exception) <message>: Now
2150         a std::string.
2151         (exception_try_scope_entry, exception_try_scope_exit): Don't
2152         declare.
2153         (struct exception_try_scope): Remove.
2154         (TRY): Don't use exception_try_scope.
2155         (struct gdb_exception): Add constructor, operator=.
2156         <what>: New method.
2157         (struct gdb_exception_RETURN_MASK_ALL)
2158         (struct gdb_exception_RETURN_MASK_ERROR)
2159         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
2160         (struct gdb_quit_bad_alloc): Update.
2161         * common/common-exceptions.c (exception_none): Change
2162         initializer.
2163         (struct catcher) <state, exception>: Initialize inline.
2164         <prev>: Remove member.
2165         (current_catcher): Remove.
2166         (catchers): New global.
2167         (exceptions_state_mc_init): Simplify.
2168         (catcher_pop): Remove.
2169         (exceptions_state_mc, exceptions_state_mc_catch): Update.
2170         (try_scope_depth, exception_try_scope_entry)
2171         (exception_try_scope_exit): Remove.
2172         (throw_exception_sjlj): Update.
2173         (exception_messages, exception_messages_size): Remove.
2174         (throw_it): Simplify.
2175         (gdb_exception_sliced_copy): Remove.
2176         (throw_exception_cxx): Update.
2177         * cli/cli-script.c (script_from_file): Update.
2178         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
2179         Update.
2180         * ada-valprint.c (ada_val_print): Update.
2181         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
2182         (create_excep_cond_exprs): Update.
2183
2184 2019-04-08  Tom Tromey  <tom@tromey.com>
2185
2186         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
2187         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
2188         (TRY, CATCH, END_CATCH): Remove some definitions.
2189         * common/common-exceptions.c: Don't use GDB_XCPT.
2190         (catcher_list_size): Remove.
2191         (throw_exception, throw_it): Simplify.
2192
2193 2019-04-05  Tom Tromey  <tom@tromey.com>
2194
2195         Revert the header-sorting patch.
2196         * ft32-tdep.c: Revert.
2197         * frv-tdep.c: Revert.
2198         * frv-linux-tdep.c: Revert.
2199         * frame.c: Revert.
2200         * frame-unwind.c: Revert.
2201         * frame-base.c: Revert.
2202         * fork-child.c: Revert.
2203         * findvar.c: Revert.
2204         * findcmd.c: Revert.
2205         * filesystem.c: Revert.
2206         * filename-seen-cache.h: Revert.
2207         * filename-seen-cache.c: Revert.
2208         * fbsd-tdep.c: Revert.
2209         * fbsd-nat.h: Revert.
2210         * fbsd-nat.c: Revert.
2211         * f-valprint.c: Revert.
2212         * f-typeprint.c: Revert.
2213         * f-lang.c: Revert.
2214         * extension.h: Revert.
2215         * extension.c: Revert.
2216         * extension-priv.h: Revert.
2217         * expprint.c: Revert.
2218         * exec.h: Revert.
2219         * exec.c: Revert.
2220         * exceptions.c: Revert.
2221         * event-top.c: Revert.
2222         * event-loop.c: Revert.
2223         * eval.c: Revert.
2224         * elfread.c: Revert.
2225         * dwarf2read.h: Revert.
2226         * dwarf2read.c: Revert.
2227         * dwarf2loc.c: Revert.
2228         * dwarf2expr.h: Revert.
2229         * dwarf2expr.c: Revert.
2230         * dwarf2-frame.c: Revert.
2231         * dwarf2-frame-tailcall.c: Revert.
2232         * dwarf-index-write.h: Revert.
2233         * dwarf-index-write.c: Revert.
2234         * dwarf-index-common.c: Revert.
2235         * dwarf-index-cache.h: Revert.
2236         * dwarf-index-cache.c: Revert.
2237         * dummy-frame.c: Revert.
2238         * dtrace-probe.c: Revert.
2239         * disasm.h: Revert.
2240         * disasm.c: Revert.
2241         * disasm-selftests.c: Revert.
2242         * dictionary.c: Revert.
2243         * dicos-tdep.c: Revert.
2244         * demangle.c: Revert.
2245         * dcache.h: Revert.
2246         * dcache.c: Revert.
2247         * darwin-nat.h: Revert.
2248         * darwin-nat.c: Revert.
2249         * darwin-nat-info.c: Revert.
2250         * d-valprint.c: Revert.
2251         * d-namespace.c: Revert.
2252         * d-lang.c: Revert.
2253         * ctf.c: Revert.
2254         * csky-tdep.c: Revert.
2255         * csky-linux-tdep.c: Revert.
2256         * cris-tdep.c: Revert.
2257         * cris-linux-tdep.c: Revert.
2258         * cp-valprint.c: Revert.
2259         * cp-support.c: Revert.
2260         * cp-namespace.c: Revert.
2261         * cp-abi.c: Revert.
2262         * corelow.c: Revert.
2263         * corefile.c: Revert.
2264         * continuations.c: Revert.
2265         * completer.h: Revert.
2266         * completer.c: Revert.
2267         * complaints.c: Revert.
2268         * coffread.c: Revert.
2269         * coff-pe-read.c: Revert.
2270         * cli-out.h: Revert.
2271         * cli-out.c: Revert.
2272         * charset.c: Revert.
2273         * c-varobj.c: Revert.
2274         * c-valprint.c: Revert.
2275         * c-typeprint.c: Revert.
2276         * c-lang.c: Revert.
2277         * buildsym.c: Revert.
2278         * buildsym-legacy.c: Revert.
2279         * build-id.h: Revert.
2280         * build-id.c: Revert.
2281         * btrace.c: Revert.
2282         * bsd-uthread.c: Revert.
2283         * breakpoint.h: Revert.
2284         * breakpoint.c: Revert.
2285         * break-catch-throw.c: Revert.
2286         * break-catch-syscall.c: Revert.
2287         * break-catch-sig.c: Revert.
2288         * blockframe.c: Revert.
2289         * block.c: Revert.
2290         * bfin-tdep.c: Revert.
2291         * bfin-linux-tdep.c: Revert.
2292         * bfd-target.c: Revert.
2293         * bcache.c: Revert.
2294         * ax-general.c: Revert.
2295         * ax-gdb.h: Revert.
2296         * ax-gdb.c: Revert.
2297         * avr-tdep.c: Revert.
2298         * auxv.c: Revert.
2299         * auto-load.c: Revert.
2300         * arm-wince-tdep.c: Revert.
2301         * arm-tdep.c: Revert.
2302         * arm-symbian-tdep.c: Revert.
2303         * arm-pikeos-tdep.c: Revert.
2304         * arm-obsd-tdep.c: Revert.
2305         * arm-nbsd-tdep.c: Revert.
2306         * arm-nbsd-nat.c: Revert.
2307         * arm-linux-tdep.c: Revert.
2308         * arm-linux-nat.c: Revert.
2309         * arm-fbsd-tdep.c: Revert.
2310         * arm-fbsd-nat.c: Revert.
2311         * arm-bsd-tdep.c: Revert.
2312         * arch-utils.c: Revert.
2313         * arc-tdep.c: Revert.
2314         * arc-newlib-tdep.c: Revert.
2315         * annotate.h: Revert.
2316         * annotate.c: Revert.
2317         * amd64-windows-tdep.c: Revert.
2318         * amd64-windows-nat.c: Revert.
2319         * amd64-tdep.c: Revert.
2320         * amd64-sol2-tdep.c: Revert.
2321         * amd64-obsd-tdep.c: Revert.
2322         * amd64-obsd-nat.c: Revert.
2323         * amd64-nbsd-tdep.c: Revert.
2324         * amd64-nbsd-nat.c: Revert.
2325         * amd64-nat.c: Revert.
2326         * amd64-linux-tdep.c: Revert.
2327         * amd64-linux-nat.c: Revert.
2328         * amd64-fbsd-tdep.c: Revert.
2329         * amd64-fbsd-nat.c: Revert.
2330         * amd64-dicos-tdep.c: Revert.
2331         * amd64-darwin-tdep.c: Revert.
2332         * amd64-bsd-nat.c: Revert.
2333         * alpha-tdep.c: Revert.
2334         * alpha-obsd-tdep.c: Revert.
2335         * alpha-nbsd-tdep.c: Revert.
2336         * alpha-mdebug-tdep.c: Revert.
2337         * alpha-linux-tdep.c: Revert.
2338         * alpha-linux-nat.c: Revert.
2339         * alpha-bsd-tdep.c: Revert.
2340         * alpha-bsd-nat.c: Revert.
2341         * aix-thread.c: Revert.
2342         * agent.c: Revert.
2343         * addrmap.c: Revert.
2344         * ada-varobj.c: Revert.
2345         * ada-valprint.c: Revert.
2346         * ada-typeprint.c: Revert.
2347         * ada-tasks.c: Revert.
2348         * ada-lang.c: Revert.
2349         * aarch64-tdep.c: Revert.
2350         * aarch64-ravenscar-thread.c: Revert.
2351         * aarch64-newlib-tdep.c: Revert.
2352         * aarch64-linux-tdep.c: Revert.
2353         * aarch64-linux-nat.c: Revert.
2354         * aarch64-fbsd-tdep.c: Revert.
2355         * aarch64-fbsd-nat.c: Revert.
2356         * aarch32-linux-nat.c: Revert.
2357
2358 2019-04-05  Tom Tromey  <tom@tromey.com>
2359
2360         * ft32-tdep.c: Sort headers.
2361         * frv-tdep.c: Sort headers.
2362         * frv-linux-tdep.c: Sort headers.
2363         * frame.c: Sort headers.
2364         * frame-unwind.c: Sort headers.
2365         * frame-base.c: Sort headers.
2366         * fork-child.c: Sort headers.
2367         * findvar.c: Sort headers.
2368         * findcmd.c: Sort headers.
2369         * filesystem.c: Sort headers.
2370         * filename-seen-cache.h: Sort headers.
2371         * filename-seen-cache.c: Sort headers.
2372         * fbsd-tdep.c: Sort headers.
2373         * fbsd-nat.h: Sort headers.
2374         * fbsd-nat.c: Sort headers.
2375         * f-valprint.c: Sort headers.
2376         * f-typeprint.c: Sort headers.
2377         * f-lang.c: Sort headers.
2378         * extension.h: Sort headers.
2379         * extension.c: Sort headers.
2380         * extension-priv.h: Sort headers.
2381         * expprint.c: Sort headers.
2382         * exec.h: Sort headers.
2383         * exec.c: Sort headers.
2384         * exceptions.c: Sort headers.
2385         * event-top.c: Sort headers.
2386         * event-loop.c: Sort headers.
2387         * eval.c: Sort headers.
2388         * elfread.c: Sort headers.
2389         * dwarf2read.h: Sort headers.
2390         * dwarf2read.c: Sort headers.
2391         * dwarf2loc.c: Sort headers.
2392         * dwarf2expr.h: Sort headers.
2393         * dwarf2expr.c: Sort headers.
2394         * dwarf2-frame.c: Sort headers.
2395         * dwarf2-frame-tailcall.c: Sort headers.
2396         * dwarf-index-write.h: Sort headers.
2397         * dwarf-index-write.c: Sort headers.
2398         * dwarf-index-common.c: Sort headers.
2399         * dwarf-index-cache.h: Sort headers.
2400         * dwarf-index-cache.c: Sort headers.
2401         * dummy-frame.c: Sort headers.
2402         * dtrace-probe.c: Sort headers.
2403         * disasm.h: Sort headers.
2404         * disasm.c: Sort headers.
2405         * disasm-selftests.c: Sort headers.
2406         * dictionary.c: Sort headers.
2407         * dicos-tdep.c: Sort headers.
2408         * demangle.c: Sort headers.
2409         * dcache.h: Sort headers.
2410         * dcache.c: Sort headers.
2411         * darwin-nat.h: Sort headers.
2412         * darwin-nat.c: Sort headers.
2413         * darwin-nat-info.c: Sort headers.
2414         * d-valprint.c: Sort headers.
2415         * d-namespace.c: Sort headers.
2416         * d-lang.c: Sort headers.
2417         * ctf.c: Sort headers.
2418         * csky-tdep.c: Sort headers.
2419         * csky-linux-tdep.c: Sort headers.
2420         * cris-tdep.c: Sort headers.
2421         * cris-linux-tdep.c: Sort headers.
2422         * cp-valprint.c: Sort headers.
2423         * cp-support.c: Sort headers.
2424         * cp-namespace.c: Sort headers.
2425         * cp-abi.c: Sort headers.
2426         * corelow.c: Sort headers.
2427         * corefile.c: Sort headers.
2428         * continuations.c: Sort headers.
2429         * completer.h: Sort headers.
2430         * completer.c: Sort headers.
2431         * complaints.c: Sort headers.
2432         * coffread.c: Sort headers.
2433         * coff-pe-read.c: Sort headers.
2434         * cli-out.h: Sort headers.
2435         * cli-out.c: Sort headers.
2436         * charset.c: Sort headers.
2437         * c-varobj.c: Sort headers.
2438         * c-valprint.c: Sort headers.
2439         * c-typeprint.c: Sort headers.
2440         * c-lang.c: Sort headers.
2441         * buildsym.c: Sort headers.
2442         * buildsym-legacy.c: Sort headers.
2443         * build-id.h: Sort headers.
2444         * build-id.c: Sort headers.
2445         * btrace.c: Sort headers.
2446         * bsd-uthread.c: Sort headers.
2447         * breakpoint.h: Sort headers.
2448         * breakpoint.c: Sort headers.
2449         * break-catch-throw.c: Sort headers.
2450         * break-catch-syscall.c: Sort headers.
2451         * break-catch-sig.c: Sort headers.
2452         * blockframe.c: Sort headers.
2453         * block.c: Sort headers.
2454         * bfin-tdep.c: Sort headers.
2455         * bfin-linux-tdep.c: Sort headers.
2456         * bfd-target.c: Sort headers.
2457         * bcache.c: Sort headers.
2458         * ax-general.c: Sort headers.
2459         * ax-gdb.h: Sort headers.
2460         * ax-gdb.c: Sort headers.
2461         * avr-tdep.c: Sort headers.
2462         * auxv.c: Sort headers.
2463         * auto-load.c: Sort headers.
2464         * arm-wince-tdep.c: Sort headers.
2465         * arm-tdep.c: Sort headers.
2466         * arm-symbian-tdep.c: Sort headers.
2467         * arm-pikeos-tdep.c: Sort headers.
2468         * arm-obsd-tdep.c: Sort headers.
2469         * arm-nbsd-tdep.c: Sort headers.
2470         * arm-nbsd-nat.c: Sort headers.
2471         * arm-linux-tdep.c: Sort headers.
2472         * arm-linux-nat.c: Sort headers.
2473         * arm-fbsd-tdep.c: Sort headers.
2474         * arm-fbsd-nat.c: Sort headers.
2475         * arm-bsd-tdep.c: Sort headers.
2476         * arch-utils.c: Sort headers.
2477         * arc-tdep.c: Sort headers.
2478         * arc-newlib-tdep.c: Sort headers.
2479         * annotate.h: Sort headers.
2480         * annotate.c: Sort headers.
2481         * amd64-windows-tdep.c: Sort headers.
2482         * amd64-windows-nat.c: Sort headers.
2483         * amd64-tdep.c: Sort headers.
2484         * amd64-sol2-tdep.c: Sort headers.
2485         * amd64-obsd-tdep.c: Sort headers.
2486         * amd64-obsd-nat.c: Sort headers.
2487         * amd64-nbsd-tdep.c: Sort headers.
2488         * amd64-nbsd-nat.c: Sort headers.
2489         * amd64-nat.c: Sort headers.
2490         * amd64-linux-tdep.c: Sort headers.
2491         * amd64-linux-nat.c: Sort headers.
2492         * amd64-fbsd-tdep.c: Sort headers.
2493         * amd64-fbsd-nat.c: Sort headers.
2494         * amd64-dicos-tdep.c: Sort headers.
2495         * amd64-darwin-tdep.c: Sort headers.
2496         * amd64-bsd-nat.c: Sort headers.
2497         * alpha-tdep.c: Sort headers.
2498         * alpha-obsd-tdep.c: Sort headers.
2499         * alpha-nbsd-tdep.c: Sort headers.
2500         * alpha-mdebug-tdep.c: Sort headers.
2501         * alpha-linux-tdep.c: Sort headers.
2502         * alpha-linux-nat.c: Sort headers.
2503         * alpha-bsd-tdep.c: Sort headers.
2504         * alpha-bsd-nat.c: Sort headers.
2505         * aix-thread.c: Sort headers.
2506         * agent.c: Sort headers.
2507         * addrmap.c: Sort headers.
2508         * ada-varobj.c: Sort headers.
2509         * ada-valprint.c: Sort headers.
2510         * ada-typeprint.c: Sort headers.
2511         * ada-tasks.c: Sort headers.
2512         * ada-lang.c: Sort headers.
2513         * aarch64-tdep.c: Sort headers.
2514         * aarch64-ravenscar-thread.c: Sort headers.
2515         * aarch64-newlib-tdep.c: Sort headers.
2516         * aarch64-linux-tdep.c: Sort headers.
2517         * aarch64-linux-nat.c: Sort headers.
2518         * aarch64-fbsd-tdep.c: Sort headers.
2519         * aarch64-fbsd-nat.c: Sort headers.
2520         * aarch32-linux-nat.c: Sort headers.
2521
2522 2019-04-04  Tom Tromey  <tom@tromey.com>
2523
2524         * varobj.c (varobj_create): Update.
2525         * rust-exp.y (struct rust_parser) <update_innermost_block,
2526         lookup_symbol>: New methods.
2527         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
2528         Rename.
2529         (rust_parser::rust_lookup_type)
2530         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2531         * printcmd.c (display_command, do_one_display): Update.
2532         * parser-defs.h (struct parser_state) <parser_state>: Add
2533         "tracker" parameter.
2534         (block_tracker): New member.
2535         (class innermost_block_tracker) <innermost_block_tracker>: Add
2536         "types" parameter.
2537         <reset>: Remove method.
2538         (innermost_block): Don't declare.
2539         (null_post_parser): Update.
2540         * parse.c (innermost_block): Remove global.
2541         (write_dollar_variable): Update.
2542         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
2543         Remove "tracker_types" parameter.
2544         (parse_expression): Add "tracker" parameter.
2545         (parse_expression_for_completion): Update.
2546         (null_post_parser): Add "tracker" parameter.
2547         * p-exp.y: Update rules.
2548         * m2-exp.y: Update rules.
2549         * language.h (struct language_defn) <la_post_parser>: Add
2550         "tracker" parameter.
2551         * go-exp.y: Update rules.
2552         * f-exp.y: Update rules.
2553         * expression.h (parse_expression, parse_exp_1): Add "tracker"
2554         parameter.
2555         * d-exp.y: Update rules.
2556         * c-exp.y: Update rules.
2557         * breakpoint.c (set_breakpoint_condition): Create an
2558         innermost_block_tracker.
2559         (watch_command_1): Likewise.
2560         * ada-lang.c (resolve): Add "tracker" parameter.
2561         (resolve_subexp): Likewise.
2562         * ada-exp.y (write_var_from_sym): Update.
2563
2564 2019-04-04  Tom Tromey  <tom@tromey.com>
2565
2566         * type-stack.h: New file.
2567         * type-stack.c: New file.
2568         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
2569         type-stack.h.
2570         (insert_into_type_stack, insert_type, push_type, push_type_int)
2571         (insert_type_address_space, pop_type, pop_type_int)
2572         (pop_typelist, pop_type_stack, append_type_stack)
2573         (push_type_stack, get_type_stack, push_typelist)
2574         (follow_type_instance_flags, follow_types): Don't declare.
2575         * parse.c (type_stack): Remove global.
2576         (parse_exp_in_context): Update.
2577         (insert_into_type_stack, insert_type, push_type, push_type_int)
2578         (insert_type_address_space, pop_type, pop_type_int)
2579         (pop_typelist, pop_type_stack, append_type_stack)
2580         (push_type_stack, get_type_stack, push_typelist)
2581         (follow_type_instance_flags, follow_types): Remove (moved to
2582         type-stack.c).
2583         * f-exp.y (type_stack): New global.
2584         Update rules.
2585         (push_kind_type, f_parse): Update.
2586         * d-exp.y (type_stack): New global.
2587         Update rules.
2588         (d_parse): Update.
2589         * c-exp.y (struct c_parse_state) <type_stack>: New member.
2590         Update rules.
2591         * Makefile.in (COMMON_SFILES): Add type-stack.c.
2592         (HFILES_NO_SRCDIR): Add type-stack.h.
2593
2594 2019-04-04  Tom Tromey  <tom@tromey.com>
2595
2596         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
2597         (rust_parser::convert_ast_to_expression, rust_parse)
2598         (rust_lex_test_completion, rust_lex_tests): Update.
2599         * parser-defs.h (struct expr_completion_state): New.
2600         (struct parser_state) <parser_state>: Add completion parameter.
2601         <mark_struct_expression, mark_completion_tag>: New methods.
2602         <parse_completion, m_completion_state>: New members.
2603         (prefixify_expression, null_post_parser): Update.
2604         (mark_struct_expression, mark_completion_tag): Don't declare.
2605         * parse.c (parse_completion, expout_last_struct)
2606         (expout_tag_completion_type, expout_completion_name): Remove
2607         globals.
2608         (parser_state::mark_struct_expression)
2609         (parser_state::mark_completion_tag): Now methods.
2610         (prefixify_expression): Add last_struct parameter.
2611         (prefixify_subexp): Likewise.
2612         (parse_exp_1): Update.
2613         (parse_exp_in_context): Add cstate parameter.  Update.
2614         (parse_expression_for_completion): Create an
2615         expr_completion_state.
2616         (null_post_parser): Add "completion" parameter.
2617         * p-exp.y: Update rules.
2618         (yylex): Update.
2619         * language.h (struct language_defn) <la_post_parser>: Add
2620         "completing" parameter.
2621         * go-exp.y: Update rules.
2622         (lex_one_token): Update.
2623         * expression.h (parse_completion): Don't declare.
2624         * d-exp.y: Update rules.
2625         (lex_one_token): Update rules.
2626         * c-exp.y: Update rules.
2627         (lex_one_token): Update.
2628         * ada-lang.c (resolve): Add "parse_completion" parameter.
2629         (resolve_subexp): Likewise.
2630         (ada_resolve_function): Likewise.
2631
2632 2019-04-04  Tom Tromey  <tom@tromey.com>
2633
2634         * parser-defs.h (struct parser_state) <start_arglist,
2635         end_arglist>: New methods.
2636         <arglist_len, m_funcall_chain>: New members.
2637         (arglist_len, start_arglist, end_arglist): Don't declare.
2638         * parse.c (arglist_len, funcall_chain): Remove global.
2639         (start_arglist, end_arglist): Remove functions.
2640         (parse_exp_in_context): Update.
2641         * p-exp.y: Update rules.
2642         * m2-exp.y: Update rules.
2643         * go-exp.y: Update rules.
2644         * f-exp.y: Update rules.
2645         * d-exp.y: Update rules.
2646         * c-exp.y: Update rules.
2647
2648 2019-04-04  Tom Tromey  <tom@tromey.com>
2649
2650         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2651         lex_operator, push_back>: New methods.
2652         Update all rules.
2653         (rust_parser::lex_hex, lex_escape): Rename and update.
2654         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2655         (rust_parser::lex_operator): Rename and update.
2656         (rust_parser::lex_number, rustyylex, rustyyerror)
2657         (rust_lex_test_init, rust_lex_test_sequence)
2658         (rust_lex_test_push_back, rust_lex_tests): Update.
2659         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2660         parameter.
2661         <lexptr, prev_lexptr>: New members.
2662         (lexptr, prev_lexptr): Don't declare.
2663         * parse.c (lexptr, prev_lexptr): Remove globals.
2664         (parse_exp_in_context): Update.
2665         * p-exp.y (yylex, yyerror): Update.
2666         * m2-exp.y (parse_number, yylex, yyerror): Update.
2667         * go-exp.y (lex_one_token, yyerror): Update.
2668         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2669         * d-exp.y (lex_one_token, yyerror): Update.
2670         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2671         (lex_one_token, yyerror): Update.
2672         * ada-lex.l (YY_INPUT): Update.
2673         (rewind_to_char): Update.
2674         * ada-exp.y (yyerror): Update.
2675
2676 2019-04-04  Tom Tromey  <tom@tromey.com>
2677
2678         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2679         * parser-defs.h (struct parser_state) <parser_state>: Add new
2680         parameter.
2681         <comma_terminates>: New member.
2682         (comma_terminates): Don't declare global.
2683         * parse.c (comma_terminates): Remove global.
2684         (parse_exp_in_context): Update.
2685         * p-exp.y (yylex): Update.
2686         * m2-exp.y (yylex): Update.
2687         * go-exp.y (lex_one_token): Update.
2688         * f-exp.y (yylex): Update.
2689         * d-exp.y (lex_one_token): Update.
2690         * c-exp.y (lex_one_token): Update.
2691         * ada-lex.l: Update.
2692
2693 2019-04-04  Tom Tromey  <tom@tromey.com>
2694
2695         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2696         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2697         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2698         * parser-defs.h (paren_depth): Don't declare.
2699         * parse.c (paren_depth): Remove global.
2700         (parse_exp_in_context): Update.
2701         * p-exp.y (paren_depth): New global.
2702         (pascal_parse): Initialize it.
2703         * m2-exp.y (paren_depth): New global.
2704         (m2_parse): Initialize it.
2705         * go-exp.y (paren_depth): New global.
2706         (go_parse): Initialize it.
2707         * f-exp.y (paren_depth): New global.
2708         (f_parse): Initialize it.
2709         * d-exp.y (paren_depth): New global.
2710         (d_parse): Initialize it.
2711         * c-exp.y (paren_depth): New global.
2712         (c_parse): Initialize it.
2713         * ada-lex.l (paren_depth): New global.
2714         (lexer_init): Initialize it.
2715
2716 2019-04-04  Tom Tromey  <tom@tromey.com>
2717
2718         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2719         (rust_parser::convert_ast_to_type)
2720         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2721         * parser-defs.h (struct parser_state) <parser_state>: Add
2722         parameters.  Initialize new members.
2723         <expression_context_block, expression_context_pc>: New members.
2724         * parse.c (expression_context_block, expression_context_pc):
2725         Remove globals.
2726         (parse_exp_in_context): Update.
2727         * p-exp.y: Update all rules.
2728         (yylex): Update.
2729         * m2-exp.y: Update all rules.
2730         (yylex): Update.
2731         * go-exp.y (yylex): Update.
2732         * f-exp.y (yylex): Update.
2733         * d-exp.y: Update all rules.
2734         (yylex): Update.
2735         * c-exp.y: Update all rules.
2736         (lex_one_token, classify_name, yylex, c_parse): Update.
2737         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2738
2739 2019-04-04  Tom Tromey  <tom@tromey.com>
2740
2741         * gdbarch.h, gdbarch.c: Rebuild.
2742         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2743         * stap-probe.h:
2744         (struct stap_parse_info): Replace "parser_state" with
2745         "expr_builder".
2746         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2747         (parser_state): New class.
2748         * parse.c (expr_builder): Rename.
2749         (expr_builder::release): Rename.
2750         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2751         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2752         (write_exp_elt_longcst, write_exp_elt_floatcst)
2753         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2754         (write_exp_string_vector, write_exp_bitstring)
2755         (write_exp_msymbol, mark_struct_expression)
2756         (write_dollar_variable)
2757         (insert_type_address_space, increase_expout_size): Replace
2758         "parser_state" with "expr_builder".
2759         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2760         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2761         "parser_state" with "expr_builder".
2762
2763 2019-04-04  Tom Tromey  <tom@tromey.com>
2764
2765         * rust-exp.y: Replace "parse_language" with method call.
2766         * p-exp.y:
2767         (yylex): Replace "parse_language" with method call.
2768         * m2-exp.y:
2769         (yylex): Replace "parse_language" with method call.
2770         * go-exp.y (classify_name): Replace "parse_language" with method
2771         call.
2772         * f-exp.y (yylex): Replace "parse_language" with method call.
2773         * d-exp.y (lex_one_token): Replace "parse_language" with method
2774         call.
2775         * c-exp.y:
2776         (lex_one_token, classify_name, yylex): Replace "parse_language"
2777         with method call.
2778         * ada-exp.y (find_primitive_type, type_char)
2779         (type_system_address): Replace "parse_language" with method call.
2780
2781 2019-04-04  Tom Tromey  <tom@tromey.com>
2782
2783         * rust-exp.y: Replace "parse_gdbarch" with method call.
2784         * parse.c (write_dollar_variable, insert_type_address_space):
2785         Replace "parse_gdbarch" with method call.
2786         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2787         call.
2788         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2789         call.
2790         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2791         "parse_gdbarch" with method call.
2792         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2793         with method call.
2794         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2795         "parse_gdbarch" with method call.
2796         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2797         "parse_gdbarch" with method call.
2798         * c-exp.y (parse_type, parse_number, classify_name): Replace
2799         "parse_gdbarch" with method call.
2800         * ada-lex.l: Replace "parse_gdbarch" with method call.
2801         * ada-exp.y (parse_type, find_primitive_type, type_char)
2802         (type_system_address): Replace "parse_gdbarch" with method call.
2803
2804 2019-04-04  Tom Tromey  <tom@tromey.com>
2805
2806         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2807         * stap-probe.c (stap_parse_argument): Update.
2808         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2809         initial_size parameter.
2810         * rust-exp.y (rust_lex_tests): Update.
2811         * parse.c (parser_state): Update.
2812         (parse_exp_in_context): Update.
2813         * parser-defs.h (struct parser_state) <parser_state>: Remove
2814         "initial_size" parameter.
2815
2816 2019-04-04  Tom Tromey  <tom@tromey.com>
2817
2818         * parser-defs.h (increase_expout_size): Don't declare.
2819         * parse.c (increase_expout_size): Now static.
2820
2821 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2822
2823         * gnu-nat.c (gnu_nat_target::wait): Fix
2824         target_waitstatus_to_string call.
2825
2826 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2827
2828         * eval.c (evaluate_subexp_standard): Handle internal functions
2829         during Fortran function call handling.
2830
2831 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2832
2833         * NEWS: Mention new internal functions.
2834         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2835         (read_base_type): Use dwarf2_init_complex_target_type.
2836         * value.c (creal_internal_fn): New function.
2837         (cimag_internal_fn): New function.
2838         (_initialize_values): Register new internal functions.
2839
2840 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2841
2842         * infrun.c (stop_all_threads): If debug_infrun, always
2843         trace the wait status after wait_one, using
2844         target_waitstatus_to_string and target_pid_to_str.
2845         (handle_inferior_event): Replace various trace of
2846         wait status kind by a single trace.
2847         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2848         wait status kind image by target_waitstatus_to_string.
2849         * target/waitstatus.c (target_waitstatus_to_string): Fix
2850         obsolete comment.
2851
2852 2019-04-01  Tom Tromey  <tromey@adacore.com>
2853
2854         PR symtab/23331:
2855         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2856
2857 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2858             Pedro Alves  <palves@redhat.com>
2859
2860         * top.c (quit_force): Call 'finalize_values'.
2861         * value.c (finalize_values): New function.
2862         * value.h (finalize_values): Declare.
2863
2864 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2865
2866         * NEWS: Announce $_gdb_major and $_gdb_minor.
2867
2868         * top.c (init_gdb_version_vars): New function.
2869         (gdb_init): Call init_gdb_version_vars.
2870
2871 2019-03-29  Tom Tromey  <tromey@adacore.com>
2872
2873         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2874         help text.  Remove dead code.
2875
2876 2019-03-29  Keith Seitz  <keiths@redhat.com>
2877
2878         From Siddhesh Poyarekar:
2879         * f-lang.h (f77_get_upperbound): Return LONGEST.
2880         (f77_get_lowerbound): Likewise.
2881         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2882         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2883         print them.
2884         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2885         plongest to format print it.
2886         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2887         (f77_get_upperbound): Likewise.
2888         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2889         LOWER_BOUND to LONGEST.
2890         (f77_create_arrayprint_offset_tbl): Likewise.
2891
2892 2019-03-29  Keith Seitz  <keiths@redhat.com>
2893
2894         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2895         %s/pulongest for TYPE_LENGTH instead of %d in format
2896         strings.
2897         * ada-typerint.c (ada_print_type): Likewise.
2898         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2899         * compile/compile-c-support.c (generate_register_struct): Likewise.
2900         * gdbtypes.c (recursive_dump_type): Likewise.
2901         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2902         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2903         instead of %d in format strings.
2904         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2905         to std::min to ULONGEST.
2906         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2907         instead of %d in format strings.
2908         * tracepoint.c (info_scope_command): Likewise.
2909         * typeprint.c (print_offset_data::update)
2910         (print_offset_data::finish): Likewise.
2911         * xtensa-tdep.c (xtensa_store_return_value)
2912         (xtensa_push_dummy_call): Likewise.
2913
2914 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2915
2916         * windows-nat.c (display_selector): Fixed format specifications
2917         for 64-bit Cygwin.
2918
2919 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2920
2921         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2922
2923 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2924
2925         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2926         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2927         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2928         (nios2_linux_init_abi): Install it.
2929
2930 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2931
2932         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2933
2934 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2935
2936         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2937
2938 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2939             Tom Tromey  <tromey@adacore.com>
2940
2941         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2942
2943 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2944
2945         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2946         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2947         method to compute the bounds of range types. Also print "[evaluated]"
2948         if the bounds' values come from a dynamic evaluation.
2949
2950 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2951
2952         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2953         whitespace when pretty printing is on.
2954
2955 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2956
2957         * ppc-linux-nat.c: Add include.
2958
2959 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2960
2961         * NEWS: Mention AArch64 Pointer Authentication.
2962
2963 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2964
2965         * arm-linux-nat.c: Add include.
2966
2967 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2968
2969         * source-cache.c (source_cache::get_source_lines): Re-read
2970         fullname after calling open_source_file.
2971
2972 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2973
2974         * NEWS: Mention TLS support for FreeBSD.
2975
2976 2019-03-25  Tom Tromey  <tromey@adacore.com>
2977
2978         * minsyms.c (BUNCH_SIZE): Update comment.
2979         (~minimal_symbol_reader): Remove old comment.
2980         (compact_minimal_symbols): Update comment.
2981         (minimal_symbol_reader::install): Remove old comment.  Update
2982         other comments.
2983
2984 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2985
2986         * s390-linux-nat.c: Add include.
2987
2988 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2989
2990         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2991         Call linux_get_hwcap.
2992         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2993         Likewise.
2994         (aarch64_linux_get_hwcap): Remove function.
2995         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2996         declaration.
2997         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2998         linux_get_hwcap.
2999         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3000         * linux-tdep.c (linux_get_hwcap): Add function.
3001         (linux_get_hwcap2): Likewise.
3002         * linux-tdep.h (linux_get_hwcap): Add declaration.
3003         (linux_get_hwcap2): Likewise.
3004         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
3005         (ppc_linux_get_hwcap2): Likewise.
3006         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
3007         linux_get_hwcap.
3008         (ppc_linux_nat_target::insert_watchpoint): Likewise.
3009         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
3010         (ppc_linux_nat_target::read_description): Likewise.
3011         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
3012         * s390-linux-nat.c: Likewise.
3013         * s390-linux-tdep.c (s390_core_read_description): Likewise.
3014
3015 2019-03-24  Tom Tromey  <tom@tromey.com>
3016
3017         * ada-lang.c (standard_lookup): Simplify initialization.
3018         (ada_lookup_symbol_nonlocal): Simplify return.
3019         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
3020         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
3021         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
3022         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
3023         initialization.
3024         * solib.c (solib_global_lookup): Simplify.
3025         * symtab.c (null_block_symbol): Remove.
3026         (symbol_cache_lookup): Simplify returns.
3027         (lookup_language_this): Simplify returns.
3028         (lookup_symbol_aux): Simplify return.
3029         (lookup_local_symbol): Simplify returns.
3030         (lookup_global_symbol_from_objfile): Simplify return.
3031         (lookup_symbol_in_objfile_symtabs)
3032         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
3033         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
3034         (lookup_static_symbol, lookup_global_symbol): Simplify return.
3035         * cp-namespace.c (cp_lookup_bare_symbol)
3036         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
3037         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
3038         (cp_lookup_nested_symbol): Don't use null_block_symbol.
3039         (cp_lookup_symbol_via_imports): Simplify initialization.
3040         (find_symbol_in_baseclass): Likewise.
3041         * symtab.h (null_block_symbol): Remove.
3042         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
3043         (d_lookup_nested_symbol, d_lookup_symbol_imports)
3044         (d_lookup_symbol_module): Likewise.
3045         (find_symbol_in_baseclass): Simplify initialization.
3046
3047 2019-03-24  Tom Tromey  <tom@tromey.com>
3048
3049         * expression.h: Don't include symtab.h.
3050         (struct block): Forward declare.
3051
3052 2019-03-24  Tom Tromey  <tom@tromey.com>
3053
3054         * c-exp.y (typebase): Remove casts.
3055         * gdbtypes.c (lookup_unsigned_typename, )
3056         (lookup_signed_typename): Remove cast.
3057         * eval.c (parse_to_comma_and_eval): Remove cast.
3058         * parse.c (write_dollar_variable): Remove cast.
3059         * block.h (struct block) <superblock>: Now const.
3060         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
3061         * psymtab.c (psym_map_matching_symbols): Make "block" const.
3062         (map_block): Make "block" const.
3063         * symfile.h (struct quick_symbol_functions)
3064         <map_matching_symbols>: Constify block argument to "callback".
3065         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
3066         const.
3067         (find_pc_sect_compunit_symtab): Make "b" const.
3068         (find_symbol_at_address): Likewise.
3069         (search_symbols): Likewise.
3070         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
3071         (dw2_debug_names_lookup_symbol): Likewise.
3072         (dw2_map_matching_symbols): Update.
3073         * p-valprint.c (pascal_val_print): Remove "block".
3074         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
3075         (aux_add_nonlocal_symbols): Make "block" const.
3076         (resolve_subexp): Remove cast.
3077         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
3078         const.
3079         (iterate_over_file_blocks): Likewise.
3080         * f-exp.y (%union) <bval>: Remove.
3081         * coffread.c (patch_opaque_types): Make "b" const.
3082         * spu-tdep.c (spu_catch_start): Make "block" const.
3083         * c-valprint.c (print_unpacked_pointer): Remove "block".
3084         * symmisc.c (dump_symtab_1): Make "b" const.
3085         (block_depth): Make "block" const.
3086         * d-exp.y (%union) <bval>: Remove.
3087         * cp-support.h (cp_lookup_rtti_type): Update.
3088         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
3089         * psymtab.c (psym_lookup_symbol): Make "block" const.
3090         (maintenance_check_psymtabs): Make "b" const.
3091         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
3092         (enumerate_locals, enumerate_args): Update.
3093         * python/py-symtab.c (stpy_global_block): Make "block" const.
3094         (stpy_static_block): Likewise.
3095         * inline-frame.c (block_starting_point_at): Make "new_block"
3096         const.
3097         * block.c (find_block_in_blockvector): Make return type const.
3098         (blockvector_for_pc_sect): Make "b" const.
3099         (find_block_in_blockvector): Make "b" const.
3100
3101 2019-03-23  Tom Tromey  <tom@tromey.com>
3102
3103         * varobj.c (varobj_create): Update.
3104         * symfile.c (clear_symtab_users): Don't reset innermost_block.
3105         * printcmd.c (display_command, do_one_display): Don't reset
3106         innermost_block.
3107         * parser-defs.h (enum innermost_block_tracker_type): Move to
3108         expression.h.
3109         (innermost_block): Update comment.
3110         * parse.c (parse_exp_1): Add tracker_types parameter.
3111         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
3112         tracker_types parameter.  Reset innermost_block.
3113         (parse_exp_in_context): Remove.
3114         (parse_expression_for_completion): Update.
3115         * objfiles.c (~objfile): Don't reset expression_context_block or
3116         innermost_block.
3117         * expression.h (enum innermost_block_tracker_type): Move from
3118         parser-defs.h.
3119         (parse_exp_1): Add tracker_types parameter.
3120         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
3121         reset innermost_block.
3122
3123 2019-03-23  Tom Tromey  <tom@tromey.com>
3124
3125         * objfiles.h: Include bcache.h.
3126
3127 2019-03-23  Tom Tromey  <tom@tromey.com>
3128
3129         * linespec.c (get_current_search_block): Use
3130         scoped_restore_current_language.
3131         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
3132
3133 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3134             Jiong Wang  <jiong.wang@arm.com>
3135
3136         * aarch64-linux-tdep.c
3137         (aarch64_linux_iterate_over_regset_sections): Check for pauth
3138         section.
3139         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
3140
3141 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3142             Jiong Wang  <jiong.wang@arm.com>
3143
3144         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
3145         instructions.
3146         (aarch64_analyze_prologue_test): Add PACIASP test.
3147         (aarch64_prologue_prev_register): Unmask PC value.
3148
3149 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3150             Jiong Wang  <jiong.wang@arm.com>
3151
3152         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
3153         (aarch64_dwarf2_prev_register): Unmask PC value.
3154         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
3155         (aarch64_execute_dwarf_cfa_vendor_op): Check for
3156         DW_CFA_AARCH64_negate_ra_state.
3157         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
3158
3159 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3160             Jiong Wang  <jiong.wang@arm.com>
3161
3162         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
3163         registers.
3164         (aarch64_pseudo_register_name): Likewise.
3165         (aarch64_pseudo_register_type): Likewise.
3166         (aarch64_pseudo_register_reggroup_p): Likewise.
3167         (aarch64_gdbarch_init): Add pauth registers.
3168         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
3169         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
3170         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
3171         (struct gdbarch_tdep): Add regnum for ra_state.
3172
3173 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3174             Jiong Wang  <jiong.wang@arm.com>
3175
3176         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
3177
3178 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3179             Jiong Wang  <jiong.wang@arm.com>
3180
3181         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
3182         function.
3183         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
3184         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
3185         (aarch64_gdbarch_init): Add puth registers.
3186         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
3187         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
3188         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
3189
3190 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3191             Jiong Wang  <jiong.wang@arm.com>
3192
3193         * aarch64-linux-nat.c
3194         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
3195         * aarch64-linux-tdep.c
3196         (aarch64_linux_core_read_description): Likewise.
3197         (aarch64_linux_get_hwcap): New function.
3198         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
3199         (aarch64_linux_get_hwcap): New declaration.
3200
3201 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3202             Jiong Wang  <jiong.wang@arm.com>
3203
3204         * aarch64-linux-nat.c
3205         (aarch64_linux_nat_target::read_description): Add pauth param.
3206         * aarch64-linux-tdep.c
3207         (aarch64_linux_core_read_description): Likewise.
3208         * aarch64-tdep.c (struct target_desc): Add in pauth.
3209         (aarch64_read_description): Add pauth param.
3210         (aarch64_gdbarch_init): Likewise.
3211         * aarch64-tdep.h (aarch64_read_description): Likewise.
3212         * arch/aarch64.c (aarch64_create_target_description): Likewise.
3213         * arch/aarch64.h (aarch64_create_target_description): Likewise.
3214         * features/Makefile: Add new files.
3215         * features/aarch64-pauth.c: New file.
3216         * features/aarch64-pauth.xml: New file.
3217
3218 2019-03-20  Tom Tromey  <tromey@adacore.com>
3219
3220         * infrun.c (handle_inferior_event): Rename from
3221         handle_inferior_event_1.  Create a scoped_value_mark.
3222         (handle_inferior_event): Remove.
3223
3224 2019-03-19  Tom Tromey  <tromey@adacore.com>
3225
3226         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
3227         * infrun.h (print_stop_event): Add "displays" parameter.
3228         * infrun.c (print_stop_event): Add "displays" parameter.
3229
3230 2019-03-19  Pedro Alves  <palves@redhat.com>
3231
3232         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
3233         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
3234         to -1.  Fix TABs vs spaces.
3235         (tui_ui_out::tui_ui_out): Don't initialize fields here.
3236         * tui/tui-out.h (tui_ui_out) Add intro comments.
3237         <m_line, m_start_of_line>: In-class initialize, and add describing
3238         comment.
3239
3240 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
3241
3242         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
3243         variable names.
3244         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
3245
3246 2019-03-18  Pedro Alves  <palves@redhat.com>
3247             Eli Zaretskii <eliz@gnu.org>
3248
3249         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
3250         m_line and m_start_of_line.
3251
3252 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
3253
3254         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
3255         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
3256         it returns a newline.  This fixes a regression in TU mode, whereby
3257         the next line is output on the same screen line as the user input.
3258
3259 2019-03-18  Tom Tromey  <tromey@adacore.com>
3260
3261         * minsyms.c (minimal_symbol_reader::install): Remove call to
3262         obstack_blank.
3263
3264 2019-03-18  Pedro Alves  <palves@redhat.com>
3265
3266         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
3267         New globals.
3268         (apply_style): New, factored out from ...
3269         (apply_ansi_escape): ... this.  Handle reverse video mode.
3270         (tui_set_reverse_mode): New function.
3271         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
3272         * tui/tui-winsource.c (tui_show_source_line): Use
3273         tui_set_reverse_mode instead of setting A_STANDOUT.
3274         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
3275         New setter methods.
3276
3277 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
3278
3279         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
3280         Handle tabs.
3281
3282 2019-03-18  Tom Tromey  <tromey@adacore.com>
3283
3284         * ada-lang.c (empty_array): Add "high" parameter.
3285         (ada_evaluate_subexp): Update.
3286
3287 2019-03-17  Sergei Trofimovich <siarheit@google.com>
3288
3289         * unittests/string_view-selftests.c: Define
3290         _initialize_string_view_selftests unconditionally.
3291
3292 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3293
3294         PR gdb/24350
3295         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
3296
3297 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3298
3299         PR gdb/24351
3300         * windows-nat.c (display_selector): Fix format specifiers.
3301
3302 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
3303
3304         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
3305         tui_refill_source_window instead of tui_refresh_win, to update the
3306         current execution line.  This fixes redisplay of the current line
3307         when stepping through the code with "next" or "step".
3308
3309 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3310
3311         * source-cache.c (source_cache::get_source_lines): Call
3312         find_source_lines to initialize s->nlines.  This fixes vertical
3313         scrolling of TUI source window when the DOWN arrow is pressed.
3314
3315 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3316
3317         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
3318         linux-thread-db.c (_initialize_thread_db): Likewise.
3319
3320 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3321
3322         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
3323         wclrtoeol in tui_show_source_line".  This reverts changes made in
3324         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
3325
3326 2019-03-15  Tom Tromey  <tom@tromey.com>
3327
3328         * symtab.h (struct minimal_symbol): Derive from
3329         general_symbol_info.
3330         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
3331         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
3332         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
3333         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
3334         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
3335         (MSYMBOL_SEARCH_NAME): Update.
3336         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
3337         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
3338         * minsyms.c (minimal_symbol_reader::record_full): Update.
3339
3340 2019-03-15  Tom Tromey  <tom@tromey.com>
3341
3342         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
3343
3344 2019-03-15  Tom Tromey  <tom@tromey.com>
3345
3346         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
3347         unique_xmalloc_ptr.
3348         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
3349         Update.
3350         * minsyms.c (lookup_minimal_symbol_by_pc_section)
3351         (build_minimal_symbol_hash_tables)
3352         (minimal_symbol_reader::install): Update.
3353
3354 2019-03-15  Tom Tromey  <tom@tromey.com>
3355
3356         * symtab.c (create_demangled_names_hash): Update.
3357         (symbol_set_names): Update.
3358         * objfiles.h (struct objfile_per_bfd_storage)
3359         <demangled_names_hash>: Now an htab_up.
3360         * objfiles.c (objfile_per_bfd_storage): Simplify.
3361
3362 2019-03-15  Tom Tromey  <tom@tromey.com>
3363
3364         * objfiles.h (struct objfile_per_bfd_storage): Declare
3365         destructor.
3366         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
3367         New.
3368         (get_objfile_bfd_data): Use new.  Don't initialize
3369         language_of_main.
3370         (free_objfile_per_bfd_storage): Remove.
3371         (objfile_bfd_data_free, objfile::~objfile): Use delete.
3372
3373 2019-03-15  Tom Tromey  <tom@tromey.com>
3374
3375         * symfile.c (reread_symbols): Update.
3376         * objfiles.c (objfile::objfile): Update.
3377         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
3378         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
3379         comment.
3380         (minimal_symbol_reader::install): Update.
3381         (terminate_minimal_symbol_table): Remove.
3382         * jit.c (jit_object_close_impl): Update.
3383
3384 2019-03-15  Tom Tromey  <tom@tromey.com>
3385
3386         * minsyms.c (minimal_symbol_reader::record_full): Remove some
3387         initializations.
3388
3389 2019-03-15  Tom Tromey  <tom@tromey.com>
3390
3391         * objfiles.h (struct objfile_per_bfd_storage)
3392         <demangled_hash_languages>: Now a bitset.
3393         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
3394         (lookup_minimal_symbol): Update.
3395
3396 2019-03-15  Tom Tromey  <tom@tromey.com>
3397
3398         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
3399         Don't return the symbol.
3400         * coffread.c (record_minimal_symbol): Use record_full.
3401
3402 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
3403
3404         The MS-Windows port of ncurses fails to switch to a color pair if
3405         one or both of the colors are the implicit default colors.  This
3406         change records the default colors when TUI is initialized, and
3407         then specifies them explicitly when a color pair uses the default
3408         colors.  This allows color styling in TUI mode on MS-Windows.
3409
3410         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
3411         ncurses_norm_attr.
3412         (tui_initialize_io) [__MINGW32__]: Record the default terminal
3413         colors in ncurses_norm_attr.
3414         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
3415         "none", replace it with the default color recorded in
3416         ncurses_norm_attr.
3417
3418 2019-03-14  Tom Tromey  <tromey@adacore.com>
3419
3420         * source-cache.h (class source_cache) <get_source_lines>: Return
3421         std::string.
3422         * source-cache.c (source_cache::extract_lines): Handle case where
3423         first_pos==npos.  Return std::string.
3424         (source_cache::get_source_lines): Update.
3425
3426 2019-03-14  Tom Tromey  <tromey@adacore.com>
3427
3428         * NEWS: Add item for "style sources" commands.
3429         * source-cache.c (source_cache::get_source_lines): Check
3430         source_styling.
3431         * cli/cli-style.c (source_styling): New global.
3432         (_initialize_cli_style): Add "style sources" commands.
3433         (show_style_sources): New function.
3434         * cli/cli-style.h (source_styling): Declare.
3435
3436 2019-03-14  Pedro Alves  <palves@redhat.com>
3437             Tom Tromey  <tromey@adacore.com>
3438
3439         * tui/tui-winsource.h (tui_refill_source_window): Declare.
3440         * tui/tui-winsource.c (tui_refill_source_window): New function,
3441         from...
3442         (tui_horizontal_source_scroll): ... here.  Move some logic.
3443         * cli/cli-style.c (set_style_enabled): Notify new observable.
3444         * tui/tui-hooks.c (tui_redisplay_source): New function.
3445         (tui_attach_detach_observers): Attach or detach
3446         tui_redisplay_source.
3447         * observable.h (source_styling_changed): New observable.
3448         * observable.c: Define source_styling_changed observable.
3449
3450 2019-03-13  Tom Tromey  <tromey@adacore.com>
3451
3452         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
3453         (i386_gnu_nat_target::store_registers): Update.
3454         * target-debug.h (target_debug_print_std_string): New macro.
3455         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3456         * windows-tdep.c (display_one_tib): Update.
3457         * tui/tui-stack.c (tui_make_status_line): Update.
3458         * top.c (print_inferior_quit_action): Update.
3459         * thread.c (thr_try_catch_cmd): Update.
3460         (add_thread_with_info): Update.
3461         (thread_target_id_str): Update.
3462         (thr_try_catch_cmd): Update.
3463         (thread_command): Update.
3464         (thread_find_command): Update.
3465         * record-btrace.c (record_btrace_target::info_record)
3466         (record_btrace_resume_thread, record_btrace_target::resume)
3467         (record_btrace_cancel_resume, record_btrace_step_thread)
3468         (record_btrace_target::wait, record_btrace_target::wait)
3469         (record_btrace_target::wait, record_btrace_target::stop): Update.
3470         * progspace.c (print_program_space): Update.
3471         * process-stratum-target.c
3472         (process_stratum_target::thread_address_space): Update.
3473         * linux-fork.c (linux_fork_mourn_inferior)
3474         (detach_checkpoint_command, info_checkpoints_command)
3475         (linux_fork_context): Update.
3476         (linux_fork_detach): Update.
3477         (class scoped_switch_fork_info): Update.
3478         (delete_checkpoint_command): Update.
3479         * infrun.c (follow_fork_inferior): Update.
3480         (follow_fork_inferior): Update.
3481         (proceed_after_vfork_done): Update.
3482         (handle_vfork_child_exec_or_exit): Update.
3483         (follow_exec): Update.
3484         (displaced_step_prepare_throw): Update.
3485         (displaced_step_restore): Update.
3486         (start_step_over): Update.
3487         (resume_1): Update.
3488         (clear_proceed_status_thread): Update.
3489         (proceed): Update.
3490         (print_target_wait_results): Update.
3491         (do_target_wait): Update.
3492         (context_switch): Update.
3493         (stop_all_threads): Update.
3494         (restart_threads): Update.
3495         (finish_step_over): Update.
3496         (handle_signal_stop): Update.
3497         (switch_back_to_stepped_thread): Update.
3498         (keep_going_pass_signal): Update.
3499         (print_exited_reason): Update.
3500         (normal_stop): Update.
3501         * inferior.c (inferior_pid_to_str): Change return type.
3502         (print_selected_inferior): Update.
3503         (add_inferior): Update.
3504         (detach_inferior): Update.
3505         * dummy-frame.c (fprint_dummy_frames): Update.
3506         * dcache.c (dcache_info_1): Update.
3507         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
3508         (btrace_fetch, btrace_clear): Update.
3509         * linux-tdep.c (linux_core_pid_to_str): Change return type.
3510         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
3511         type.
3512         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
3513         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
3514         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
3515         * gdbarch.c, gdbarch.h: Rebuild.
3516         * gdbarch.sh (core_pid_to_str): Change return type.
3517         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
3518         return type.
3519         (windows_nat_target::pid_to_str): Change return type.
3520         (windows_delete_thread): Update.
3521         (windows_nat_target::attach): Update.
3522         (windows_nat_target::files_info): Update.
3523         * target-delegates.c: Rebuild.
3524         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
3525         return type.
3526         (sol_thread_target::pid_to_str): Change return type.
3527         * remote.c (class remote_target) <pid_to_str>: Change return
3528         type.
3529         (remote_target::pid_to_str): Change return type.
3530         (extended_remote_target::attach, remote_target::remote_stop_ns)
3531         (remote_target::remote_notif_remove_queued_reply)
3532         (remote_target::push_stop_reply, remote_target::disable_btrace):
3533         Update.
3534         (extended_remote_target::attach): Update.
3535         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
3536         type.
3537         (gdbsim_target::pid_to_str): Change return type.
3538         * ravenscar-thread.c (struct ravenscar_thread_target)
3539         <pid_to_str>: Change return type.
3540         (ravenscar_thread_target::pid_to_str): Change return type.
3541         * procfs.c (class procfs_target) <pid_to_str>: Change return
3542         type.
3543         (procfs_target::pid_to_str): Change return type.
3544         (procfs_target::attach): Update.
3545         (procfs_target::detach): Update.
3546         (procfs_target::fetch_registers): Update.
3547         (procfs_target::store_registers): Update.
3548         (procfs_target::wait): Update.
3549         (procfs_target::files_info): Update.
3550         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
3551         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
3552         return type.
3553         (nto_procfs_target::pid_to_str): Change return type.
3554         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
3555         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
3556         return type.
3557         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
3558         (exit_lwp): Update.
3559         (attach_proc_task_lwp_callback, get_detach_signal)
3560         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
3561         (linux_nat_target::resume, wait_lwp, stop_callback)
3562         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
3563         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
3564         (linux_nat_wait_1, resume_stopped_resumed_lwps)
3565         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
3566         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
3567         type.
3568         (inf_ptrace_target::attach): Update.
3569         (inf_ptrace_target::files_info): Update.
3570         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
3571         type.
3572         (go32_nat_target::pid_to_str): Change return type.
3573         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
3574         (gnu_nat_target::wait): Update.
3575         (gnu_nat_target::wait): Update.
3576         (gnu_nat_target::resume): Update.
3577         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
3578         (fbsd_nat_target::wait): Update.
3579         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
3580         type.
3581         (darwin_nat_target::attach): Update.
3582         * corelow.c (class core_target) <pid_to_str>: Change return type.
3583         (core_target::pid_to_str): Change return type.
3584         * target.c (normal_pid_to_str): Change return type.
3585         (default_pid_to_str): Likewise.
3586         (target_pid_to_str): Change return type.
3587         (target_translate_tls_address): Update.
3588         (target_announce_detach): Update.
3589         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
3590         return type.
3591         (bsd_uthread_target::pid_to_str): Change return type.
3592         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
3593         type.
3594         (bsd_kvm_target::pid_to_str): Change return type.
3595         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
3596         return type.
3597         (aix_thread_target::pid_to_str): Change return type.
3598         * target.h (struct target_ops) <pid_to_str>: Change return type.
3599         (target_pid_to_str, normal_pid_to_str): Likewise.
3600         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
3601         type.
3602         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
3603         type.
3604         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
3605         return type.
3606         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
3607         type.
3608         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
3609         type.
3610         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3611         return type.
3612
3613 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3614
3615         * NEWS: Mention that the new default MI version is 3.  Mention
3616         changes to the output of commands and events that deal with
3617         multi-location breakpoints.
3618         * breakpoint.c: Include "mi/mi-out.h".
3619         (print_one_breakpoint): Change output syntax if using MI version
3620         >= 3.
3621         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3622         New.
3623         (mi_multi_location_breakpoint_output_fixed): New.
3624         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3625         (mi_cmd_fix_multi_location_breakpoint_output): New.
3626         (mi_multi_location_breakpoint_output_fixed): New.
3627         * mi/mi-cmds.c (mi_cmds): Register command
3628         -fix-multi-location-breakpoint-output.
3629         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3630         interpreter "mi".
3631
3632 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3633
3634         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3635         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3636         instantiate mi_ui_out based on interpreter name.
3637         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3638         * mi/mi-main.c (mi_load_progress): Likewise.
3639
3640 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3641
3642         * NEWS: Combine separate "New targets" sections for 8.3.
3643
3644 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3645
3646         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3647         (ppcfbsd_init_abi): Install gdbarch
3648         "fetch_tls_load_module_address" and "get_thread_local_address"
3649         methods.
3650
3651 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3652
3653         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3654         (riscv_fbsd_init_abi): Install gdbarch
3655         "fetch_tls_load_module_address" and "get_thread_local_address"
3656         methods.
3657
3658 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3659
3660         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3661         (i386fbsd_init_abi): Install gdbarch
3662         "fetch_tls_load_module_address" and "get_thread_local_address"
3663         methods.
3664
3665 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3666
3667         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3668         (amd64fbsd_init_abi): Install gdbarch
3669         "fetch_tls_load_module_address" and "get_thread_local_address"
3670         methods.
3671
3672 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3673
3674         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3675         (struct fbsd_pspace_data): New type.
3676         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3677         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3678         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3679         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3680         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3681
3682 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3683
3684         * gdbtypes.c (lookup_struct_elt): New function.
3685         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3686         * gdbtypes.h (struct struct_elt): New type.
3687         (lookup_struct_elt): New prototype.
3688
3689 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3690
3691         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3692         remove disabled code block.
3693
3694 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3695
3696         * gdbarch.sh (get_thread_local_address): New method.
3697         * gdbarch.h, gdbarch.c: Regenerate.
3698         * target.c (target_translate_tls_address): Use
3699         gdbarch_get_thread_local_address if present instead of
3700         target::get_thread_local_address.
3701
3702 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3703
3704         * target.h (target::get_thread_local_address): Update comment.
3705
3706 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3707
3708         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3709         objfile->separate_debug_objfile_backlink if not NULL.
3710
3711 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3712
3713         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3714         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3715         (amd64bsd_store_inferior_registers): Likewise.
3716         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3717         Enable segment base registers.
3718         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3719         PT_GETFSBASE and PT_GETGSBASE.
3720         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3721         PT_SETGSBASE.
3722         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3723         segment base registers.
3724         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3725
3726 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3727
3728         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3729         Update calls to i386_target_description to add 'segments'
3730         parameter.
3731         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3732         add segment base registers.
3733         * arch/i386.c (i386_create_target_description): Add 'segments'
3734         parameter to enable segment base registers.
3735         * arch/i386.h (i386_create_target_description): Likewise.
3736         * features/i386/32bit-segments.xml: New file.
3737         * features/i386/32bit-segments.c: Generate.
3738         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3739         call to i386_target_description to add 'segments' parameter.
3740         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3741         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3742         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3743         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3744         if feature is present.
3745         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3746         Add 'segments' parameter to call to i386_target_description.
3747         (i386_target_description): Add 'segments' parameter to enable
3748         segment base registers.
3749         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3750         to call to i386_target_description.
3751         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3752         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3753         Define I386_NUM_REGS.
3754         (i386_target_description): Add 'segments' parameter to enable
3755         segment base registers.
3756
3757 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3758
3759         PR/24325
3760         * source-cache.c: #undef open and close, to avoid unresolved
3761         externals during linking.
3762
3763 2019-03-12  Tom Tromey  <tromey@adacore.com>
3764
3765         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3766         const.  Add initializers.
3767         (_initialize_remote): Don't initialize ptid globals.
3768
3769 2019-03-12  Pedro Alves  <palves@redhat.com>
3770
3771         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3772
3773 2019-03-12  Pedro Alves  <palves@redhat.com>
3774
3775         * cp-name-parser.y (main): Remove unused 'len' variable.
3776
3777 2019-03-12  Tom Tromey  <tromey@adacore.com>
3778
3779         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3780         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3781
3782 2019-03-12  Tom Tromey  <tromey@adacore.com>
3783
3784         * linux-nat.c (iterate_over_lwps): Update.
3785         (stop_callback): Remove parameter.
3786         (stop_wait_callback, detach_callback, resume_set_callback)
3787         (select_singlestep_lwp_callback, set_ignore_sigint)
3788         (status_callback, resumed_callback, resume_clear_callback)
3789         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3790         data parameter.
3791         (linux_nat_target::detach, linux_nat_target::resume)
3792         (linux_stop_and_wait_all_lwps, select_event_lwp)
3793         (linux_nat_filter_event, linux_nat_wait_1)
3794         (linux_nat_target::kill, linux_nat_target::stop)
3795         (linux_nat_target::stop): Update.
3796         (linux_nat_resume_callback): Change type.
3797         (resume_stopped_resumed_lwps, count_events_callback)
3798         (select_event_lwp_callback): Likewise.
3799         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3800         * arm-linux-nat.c (struct update_registers_data): Remove.
3801         (update_registers_callback): Change type.
3802         (arm_linux_insert_hw_breakpoint1): Update.
3803         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3804         parameter.
3805         (x86_linux_dr_set_addr): Update.
3806         (x86_linux_dr_set_control): Update.
3807         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3808         (iterate_over_lwps): Use gdb::function_view.
3809         * nat/aarch64-linux-hw-point.c (struct
3810         aarch64_dr_update_callback_param): Remove.
3811         (debug_reg_change_callback): Change type.
3812         (aarch64_notify_debug_reg_change): Update.
3813         * s390-linux-nat.c (s390_refresh_per_info): Update.
3814
3815 2019-03-11  Tom Tromey  <tromey@adacore.com>
3816
3817         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3818         redundant assignment to "this_cu".
3819
3820 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3821
3822         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3823
3824 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3825
3826         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3827         from...
3828         (rank_one_type): ... this.
3829
3830 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3831
3832         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3833         from...
3834         (rank_one_type): ... this.
3835
3836 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3837
3838         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3839         from...
3840         (rank_one_type): ... this.
3841
3842 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3843
3844         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3845         from...
3846         (rank_one_type): ... this.
3847
3848 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3849
3850         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3851         from...
3852         (rank_one_type): ... this.
3853
3854 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3855
3856         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3857         from...
3858         (rank_one_type): ... this.
3859
3860 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3861
3862         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3863         from...
3864         (rank_one_type): ... this.
3865
3866 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3867
3868         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3869         from...
3870         (rank_one_type): ... this.
3871
3872 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3873
3874         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3875         from...
3876         (rank_one_type): ... this.
3877
3878 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3879
3880         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3881         from...
3882         (rank_one_type): ... this.
3883
3884 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3885
3886         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3887         from...
3888         (rank_one_type): ... this.
3889
3890 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3891
3892         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3893         from...
3894         (rank_one_type): ... this.
3895
3896 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3897
3898         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3899         inferior-events' shows the example events.
3900
3901 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3902
3903         Support styling on native MS-Windows console
3904
3905         PR/24315
3906         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3907         on MS-Windows if $TERM is not defined.
3908
3909         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3910
3911         * posix-hdep.c (gdb_console_fputs):
3912         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3913         functions.
3914         * ui-file.h (gdb_console_fputs): Add prototype.
3915
3916         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3917         back to fputs only if the former returns zero.
3918
3919 2019-03-07  Tom Tromey  <tom@tromey.com>
3920
3921         * symmisc.c (print_symbol_bcache_statistics): Update.
3922         (print_objfile_statistics): Update.
3923         * symfile.c (allocate_symtab): Update.
3924         * stabsread.c: Don't include bcache.h.
3925         * psymtab.h (struct psymbol_bcache): Don't declare.
3926         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3927         (psymbol_bcache_init, psymbol_bcache_free)
3928         (psymbol_bcache_get_bcache): Don't declare.
3929         * psymtab.c (struct psymbol_bcache): Remove.
3930         (psymtab_storage::psymtab_storage): Update.
3931         (psymtab_storage::~psymtab_storage): Update.
3932         (psymbol_bcache_init, psymbol_bcache_free)
3933         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3934         (add_psymbol_to_bcache): Update.
3935         (allocate_psymtab): Update.
3936         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3937         macro_cache>: No longer pointers.
3938         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3939         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3940         * macrotab.c (macro_bcache): Update.
3941         * macroexp.c: Don't include bcache.h.
3942         * gdbtypes.c (check_types_worklist): Update.
3943         (types_deeply_equal): Remove TRY/CATCH.  Update.
3944         * elfread.c (elf_symtab_read): Update.
3945         * dwarf2read.c: Don't include bcache.h.
3946         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3947         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3948         (print_bcache_statistics, bcache_memory_used): Don't declare.
3949         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3950         methods.  Rename all data members.
3951         * bcache.c (struct bcache): Move to bcache.h.
3952         (bcache::expand_hash_table): Rename from expand_hash_table.
3953         (bcache): Remove.
3954         (bcache::insert): Rename from bcache_full.
3955         (bcache::compare): Rename from bcache_compare.
3956         (bcache_xmalloc): Remove.
3957         (bcache::~bcache): Rename from bcache_xfree.
3958         (bcache::print_statistics): Rename from print_bcache_statistics.
3959         (bcache::memory_used): Rename from bcache_memory_used.
3960
3961 2019-03-07  Pedro Alves  <palves@redhat.com>
3962
3963         * infrun.c (normal_stop): Also check for
3964         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3965
3966 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3967
3968         * f-lang.c (value_from_host_double): Moved to...
3969         * value.c (value_from_host_double): ...here.
3970         * value.h (value_from_host_double): Declare.
3971         * guile/scm-math.c (vlscm_convert_typed_number): Use
3972         value_from_host_double.
3973         (vlscm_convert_number): Likewise.
3974         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3975         * python/py-value.c (convert_value_from_python): Likewise.
3976
3977 2019-03-06  Tom Tromey  <tom@tromey.com>
3978
3979         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3980
3981 2019-03-06  Tom Tromey  <tom@tromey.com>
3982
3983         * utils.h (free_current_contents): Don't declare.
3984         * utils.c (free_current_contents): Remove.
3985
3986 2019-03-06  Tom Tromey  <tom@tromey.com>
3987
3988         * top.c (quit_force): Update.
3989         * main.c (captured_command_loop): Update.
3990         * common/new-op.c (operator new): Update.
3991         * common/common-exceptions.c (struct catcher)
3992         <save_cleanup_chain>: Remove member.
3993         (exceptions_state_mc_init): Update.
3994         (exception_try_scope_entry): Return nullptr.
3995         (exception_try_scope_exit, exception_rethrow)
3996         (throw_exception_sjlj, throw_exception_cxx): Update.
3997         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3998         (all_cleanups, do_cleanups, discard_cleanups)
3999         (discard_final_cleanups, save_cleanups, save_final_cleanups)
4000         (restore_cleanups, restore_final_cleanups): Don't declare.
4001         (do_final_cleanups): Remove parameter.
4002         * common/cleanups.c (cleanup_chain, make_cleanup)
4003         (make_cleanup_dtor, all_cleanups, do_cleanups)
4004         (discard_my_cleanups, discard_cleanups)
4005         (discard_final_cleanups, save_my_cleanups, save_cleanups)
4006         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
4007         (null_cleanup): Remove.
4008         (do_final_cleanups): Remove parameter.
4009
4010 2019-03-06  Tom Tromey  <tom@tromey.com>
4011
4012         * remote.c (remote_target::remote_parse_stop_reply): Use
4013         unique_xmalloc_ptr.
4014
4015 2019-03-06  Tom Tromey  <tom@tromey.com>
4016
4017         * stabsread.c (struct stabs_field_info): Rename from field_info.
4018         <list, fnlist>: Add initializers.
4019         <obstack>: New member.
4020         (read_member_functions, read_struct_fields, read_baseclasses):
4021         Allocate on obstack.  Don't use cleanups.
4022         (read_one_struct_field, read_member_functions, read_struct_fields)
4023         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
4024         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
4025         (read_struct_type): Update.
4026
4027 2019-03-06  Tom Tromey  <tom@tromey.com>
4028
4029         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
4030         * common/filestuff.h (make_cleanup_close): Don't declare.
4031         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
4032         Remove.
4033
4034 2019-03-06  Tom Tromey  <tom@tromey.com>
4035
4036         * solib-aix.c: Use make_scope_exit.
4037
4038 2019-03-06  Tom Tromey  <tom@tromey.com>
4039
4040         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
4041         Use make_scope_exit.
4042
4043 2019-03-06  Tom Tromey  <tom@tromey.com>
4044
4045         * solib-svr4.c (disable_probes_interface): Remove parameter.
4046         (svr4_handle_solib_event): Use make_scope_exit.
4047
4048 2019-03-06  Tom Tromey  <tom@tromey.com>
4049
4050         * remote.c (struct stop_reply_deleter): Remove.
4051         (stop_reply_up): Update.
4052         (struct stop_reply): Derive from notif_event.  Don't typedef.
4053         <regcache>: Now a std::vector.
4054         (stop_reply_xfree): Remove.
4055         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
4056         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
4057         (remote_target::discard_pending_stop_replies): Use delete.
4058         (remote_target::remote_parse_stop_reply): Update.
4059         (remote_target::process_stop_reply): Update.
4060         * remote-notif.h (struct notif_event): Add virtual destructor.
4061         Remove "dtr" member.
4062         (struct notif_client) <alloc_event>: Return a unique_ptr.
4063         (notif_event_xfree): Don't declare.
4064         (notif_event_up): New typedef.
4065         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
4066         (notif_event_xfree, do_notif_event_xfree): Remove.
4067         (remote_notif_state_xfree): Update.
4068
4069 2019-03-06  Tom Tromey  <tom@tromey.com>
4070
4071         * infrun.c (displaced_step_clear_cleanup): Now a
4072         forward_scope_exit type.
4073         (displaced_step_prepare_throw): Update.
4074         (displaced_step_fixup): Update.
4075
4076 2019-03-06  Tom Tromey  <tom@tromey.com>
4077
4078         * inferior.h (class inferior): Update comment.
4079         * gdbthread.h (class thread_info): Update comment.
4080
4081 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
4082             Tom Tromey  <tom@tromey.com>
4083
4084         * stabsread.h (struct stab_section_list): Remove.
4085         (coffstab_build_psymtabs): Update.
4086         * dbxread.c (symbuf_sections): Now a std::vector.
4087         (sect_idx): New global.
4088         (fill_symbuf): Update.
4089         (coffstab_build_psymtabs): Change type of stabsects parameter.
4090         Update.
4091         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
4092         std::vector.
4093         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
4094         (coff_locate_sections): Update.
4095         (coff_symfile_read): Remove cleanups.  Update.
4096         (init_stringtab): Add storage parameter.
4097         (free_stringtab, free_stringtab_cleanup): Remove.
4098         (init_lineno): Add storage parameter.
4099         (free_linetab, free_linetab_cleanup): Remove.
4100
4101 2019-03-06  Pedro Alves  <palves@redhat.com>
4102
4103         * linux-fork.c (fork_info::clobber_regs): Delete.
4104         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
4105         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
4106         comment.  Adjust.
4107         (scoped_switch_fork_info::scoped_switch_fork_info)
4108         (checkpoint_command, linux_fork_context): Adjust
4109         fork_save_infrun_state calls.
4110
4111 2019-03-06  Pedro Alves  <palves@redhat.com>
4112
4113         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
4114         (inf_has_multiple_threads): Return 'bool' and rewrite using
4115         inferior_info::threads().
4116
4117 2019-03-06  Pedro Alves  <palves@redhat.com>
4118
4119         * linux-fork.c: Include <list>.
4120         (fork_list): Now a std::list instance.
4121         (fork_info): Add ctor, dtor, and in-class initialize all fields.
4122         (forks_exist_p, find_last_fork): Adjust.
4123         (new_fork): Delete.
4124         (one_fork_p): New.
4125         (add_fork): Adjust.
4126         (free_fork): Delete, folded into fork_info::~fork_info().
4127         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
4128         Adjust.
4129         (init_fork_list): Delete.
4130         (linux_fork_killall, linux_fork_mourn_inferior)
4131         (linux_fork_detach, info_checkpoints_command): Adjust.
4132         (_initialize_linux_fork): No longer call init_fork_list.
4133
4134 2019-03-06  Pedro Alves  <palves@redhat.com>
4135
4136         * linux-fork.c (new_fork): New, split out of ...
4137         (add_fork): ... this.  Return void.  Move "first fork" special
4138         case from here, to ...
4139         (checkpoint_command): ... here.
4140         * linux-linux.h (add_fork): Return void.
4141
4142 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4143
4144         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
4145
4146 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4147             Chris January  <chris.january@arm.com>
4148             David Lecomber  <david.lecomber@arm.com>
4149
4150         * f-exp.y: New token, UNOP_INTRINSIC.
4151         (exp): New pattern using UNOP_INTRINSIC token.
4152         (f77_keywords): Add 'abs' keyword.
4153         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
4154         (value_from_host_double): New function.
4155         (evaluate_subexp_f): Support UNOP_ABS.
4156
4157 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4158
4159         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
4160         types.
4161
4162 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4163
4164         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
4165         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
4166         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
4167
4168 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4169
4170         * f-exp.y (convert_to_kind_type): Handle more type kinds.
4171
4172 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4173             Chris January  <chris.january@arm.com>
4174
4175         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
4176         * f-exp.y: Define 'KIND' token.
4177         (exp): New pattern for KIND expressions.
4178         (ptype): Handle types with a kind extension.
4179         (direct_abs_decl): Extend to spot kind extensions.
4180         (f77_keywords): Add 'kind' to the list.
4181         (push_kind_type): New function.
4182         (convert_to_kind_type): New function.
4183         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
4184         * parse.c (operator_length_standard): Likewise.
4185         * parser-defs.h (enum type_pieces): Add tp_kind.
4186         * std-operator.def: Add UNOP_KIND.
4187
4188 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4189
4190         * f-exp.y (f_parse): Set yydebug.
4191
4192 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4193
4194         * f-lang.c (evaluate_subexp_f): New function.
4195         (exp_descriptor_f): New global.
4196         (f_language_defn): Use exp_descriptor_f instead of
4197         exp_descriptor_standard.
4198
4199 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4200
4201         * f-exp.y (struct token): Add comments.
4202         (dot_ops): Remove uppercase versions and the end marker.
4203         (f77_keywords): Likewise.
4204         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
4205         entries in the dot_ops array are case insensitive, and use
4206         strncasecmp to compare strings.  Also some whitespace cleanup in
4207         this area.  Similar for the f77_keywords array, except entries in
4208         this list might be case sensitive.
4209
4210 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4211
4212         * f-exp.y (struct f77_boolean_val): Add comments.
4213         (boolean_values): Remove uppercase versions, and end marker.
4214         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
4215         and use strncasecmp to achieve case insensitivity.  Additionally,
4216         perform whitespace cleanup around this code.
4217
4218 2019-03-06  Tom Tromey  <tromey@adacore.com>
4219
4220         * remote-sim.c (gdbsim_target_open): Use result of
4221         gdb_argv::release.
4222
4223 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
4224         Dirk Schubert  <dirk.schubert@arm.com>
4225         Chris January  <chris.january@arm.com>
4226
4227         * eval.c (evaluate_subexp_standard): Call Fortran argument
4228         wrapping logic.
4229         * f-lang.c (struct value): A value which can be passed into a
4230         Fortran function call.
4231         (fortran_argument_convert): Wrap Fortran arguments in a pointer
4232         where appropriate.
4233         (struct type): Value ready for a Fortran function call.
4234         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
4235         is needed.
4236         * f-lang.h (fortran_argument_convert): Declaration.
4237         (fortran_preserve_arg_pointer): Declaration.
4238         * infcall.c (value_arg_coerce): Call Fortran argument logic.
4239
4240 2019-03-05  Tom Tromey  <tromey@adacore.com>
4241
4242         * python/py-prettyprint.c (print_string_repr): Remove #if.
4243         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
4244
4245 2019-03-05  Tom Tromey  <tromey@adacore.com>
4246
4247         * target.c (the_dummy_target): Move later.  Change type to
4248         "dummy_target".
4249         (initialize_targets): Don't initialize the_dummy_target.
4250
4251 2019-03-05  Tom Tromey  <tromey@adacore.com>
4252
4253         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
4254         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
4255
4256 2019-03-05  Tom Tromey  <tromey@adacore.com>
4257
4258         * windows-nat.c (windows_nat_target::attach)
4259         (windows_nat_target::detach): Don't call gdb_flush.
4260         * valprint.c (generic_val_print, val_print, val_print_string):
4261         Don't call gdb_flush.
4262         * utils.c (defaulted_query): Don't call gdb_flush.
4263         * typeprint.c (print_type_scalar): Don't call gdb_flush.
4264         * target.c (target_announce_detach): Don't call gdb_flush.
4265         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
4266         * remote.c (extended_remote_target::attach): Don't call
4267         gdb_flush.
4268         * procfs.c (procfs_target::detach): Don't call gdb_flush.
4269         * printcmd.c (do_examine): Don't call gdb_flush.
4270         (info_display_command): Don't call gdb_flush.
4271         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
4272         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
4273         * memattr.c (info_mem_command): Don't call gdb_flush.
4274         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
4275         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
4276         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
4277         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
4278         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
4279         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
4280         (gnu_nat_target::detach): Don't call gdb_flush.
4281         * f-valprint.c (f_val_print): Don't call gdb_flush.
4282         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
4283         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
4284         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
4285         gdb_flush.
4286         * c-valprint.c (c_val_print): Don't call gdb_flush.
4287         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
4288
4289 2019-03-05  Tom Tromey  <tromey@adacore.com>
4290
4291         * varobj.c (update_dynamic_varobj_children): Update.
4292         (install_default_visualizer): Use reset, not release.
4293         * value.c (set_internalvar): Update.
4294         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
4295         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
4296         ATTRIBUTE_UNUSED_RESULT.
4297
4298 2019-03-05  Tom Tromey  <tromey@adacore.com>
4299
4300         * remote.c (class scoped_remote_fd) <release>: Add
4301         ATTRIBUTE_UNUSED_RESULT.
4302
4303 2019-03-05  Tom Tromey  <tromey@adacore.com>
4304
4305         * macroexp.c (struct macro_buffer) <release>: Add
4306         ATTRIBUTE_UNUSED_RESULT.
4307
4308 2019-03-05  Tom Tromey  <tromey@adacore.com>
4309
4310         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
4311         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
4312         ATTRIBUTE_UNUSED_RESULT.
4313
4314 2019-03-05  Tom Tromey  <tromey@adacore.com>
4315
4316         * common/scoped_fd.h (class scoped_fd) <release>: Add
4317         ATTRIBUTE_UNUSED_RESULT.
4318
4319 2019-03-05  Tom Tromey  <tromey@adacore.com>
4320
4321         * parser-defs.h (struct parser_state) <release>: Add
4322         ATTRIBUTE_UNUSED_RESULT.
4323
4324 2019-03-05  Tom Tromey  <tromey@adacore.com>
4325
4326         * utils.h (class gdb_argv) <release>: Add
4327         ATTRIBUTE_UNUSED_RESULT.
4328         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
4329
4330 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
4331
4332         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
4333         for-loop range, to avoid compiler warnings.
4334
4335         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
4336         avoid compiler warnings about unused variables.
4337
4338         * NEWS: Mention end of support for native debugging on MS-Windows
4339         before XP.
4340
4341         PR gdb/24292
4342         * common/netstuff.c:
4343         * gdbserver/gdbreplay.c
4344         * gdbserver/remote-utils.c:
4345         * ser-tcp.c:
4346         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
4347         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
4348         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
4349         'getaddrinfo' and 'freeaddrinfo' were not available before
4350         Windows XP, and mingw.org's MinGW headers by default define
4351         _WIN32_WINNT to 0x500.
4352
4353 2019-03-01  Gary Benson <gbenson@redhat.com>
4354
4355         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
4356
4357 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
4358             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4359
4360         PR gdb/8527
4361         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
4362         set_sigint_trap, clear_sigint_trap.
4363
4364 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4365
4366         * target.c (target_detach): Clear the regcache and the
4367         frame cache.
4368
4369 2019-02-27  Pedro Alves  <palves@redhat.com>
4370
4371         * utils.c (set_screen_size): When we cap the height/width sizes,
4372         tweak the corresponding command variable to show "unlimited":
4373
4374 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
4375             Pedro Alves  <palves@redhat.com>
4376
4377         * utils.c (set_screen_size): Reduce "infinite" rows and columns
4378         before calling rl_set_screen_size.
4379
4380 2019-02-27  Tom Tromey  <tromey@adacore.com>
4381
4382         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
4383         define.
4384         * python/py-value.c: Remove Python 2.4 workaround.
4385         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
4386         workaround.
4387         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
4388         Python 2.4 workaround.
4389         * python/python-internal.h: Remove Python 2.4 comment.
4390         (Py_ssize_t): Don't define.
4391         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
4392         (gdb_Py_DECREF): Remove Python 2.4 workaround.
4393         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
4394         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
4395         * python/python.c (do_start_initialization): Remove Python 2.4
4396         workaround.
4397         * python/py-prettyprint.c (class dummy_python_frame): Remove.
4398         (print_children): Remove Python 2.4 workaround.
4399         * python/py-inferior.c (buffer_procs): Remove Python 2.4
4400         workaround.
4401         (CHARBUFFERPROC_NAME): Remove.
4402         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
4403         Python 2.4 workaround.
4404
4405 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4406
4407         * NEWS: Note minimum Python version.
4408
4409 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4410
4411         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
4412         code from these functions.  Remove corresponding ifdefs.  Use
4413         Py_buffer_up instead of explicit calls to PyBuffer_Release.
4414         Remove gotos and target of gotos.
4415         (infpy_search_memory): Likewise.
4416
4417 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4418
4419         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
4420         (hppa_gdbarch_init): Don't register deleted functions with
4421         gdbarch.
4422
4423 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4424
4425         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
4426         (h8300_unwind_sp): Delete.
4427         (h8300_dummy_id): Delete.
4428         (h8300_gdbarch_init): Don't register deleted functions with
4429         gdbarch.
4430
4431 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4432
4433         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
4434         (ft32_unwind_pc): Delete.
4435         (ft32_unwind_sp): Delete.
4436         (ft32_gdbarch_init): Don't register deleted functions with
4437         gdbarch.
4438
4439 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4440
4441         * gdb/frv-tdep.c (frv_dummy_id): Delete.
4442         (frv_unwind_pc): Delete.
4443         (frv_unwind_sp): Delete.
4444         (frv_gdbarch_init): Don't register deleted functions with
4445         gdbarch.
4446
4447 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4448
4449         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
4450         (riscv_unwind_pc): Delete.
4451         (riscv_unwind_sp): Delete.
4452         (riscv_gdbarch_init): Don't register deleted functions with
4453         gdbarch.
4454
4455 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4456
4457         * gdb/csky-tdep.c (csky_dummy_id): Delete.
4458         (csky_unwind_pc): Delete.
4459         (csky_unwind_sp): Delete.
4460         (csky_gdbarch_init): Don't register deleted functions with
4461         gdbarch.
4462
4463 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4464
4465         * gdb/cris-tdep.c (cris_dummy_id): Delete.
4466         (cris_unwind_pc): Delete.
4467         (cris_unwind_sp): Delete.
4468         (cris_gdbarch_init): Don't register deleted functions with
4469         gdbarch.
4470
4471 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4472
4473         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
4474         (bfin_unwind_pc): Delete.
4475         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
4476
4477 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4478
4479         * gdb/arm-tdep.c (arm_dummy_id): Delete.
4480         (arm_unwind_pc): Delete.
4481         (arm_unwind_sp): Delete.
4482         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
4483
4484 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4485
4486         * gdb/arc-tdep.c (arc_dummy_id): Delete.
4487         (arc_unwind_pc): Delete.
4488         (arc_unwind_sp): Delete.
4489         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
4490
4491 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4492
4493         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
4494         (alpha_unwind_pc): Delete.
4495         (alpha_gdbarch_init): Don't register deleted functions with
4496         gdbarch.
4497
4498 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4499
4500         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
4501         (aarch64_unwind_pc): Delete.
4502         (aarch64_unwind_sp): Delete.
4503         (aarch64_gdbarch_init): Don't register deleted functions with
4504         gdbarch.
4505
4506 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4507
4508         * gdbtypes.c (type_align): Don't consider static members when
4509         computing structure alignment.
4510
4511 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4512
4513         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
4514         return 0 for other types.
4515         * arch-utils.c (default_type_align): Always return 0.
4516         * gdbarch.h: Regenerate.
4517         * gdbarch.sh (type_align): Extend comment.
4518         * gdbtypes.c (type_align): Add additional comments, always call
4519         gdbarch_type_align before applying the default rules.
4520         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
4521         generic code will then apply a suitable default.
4522         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
4523         types, return 0 for other types.
4524
4525 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4526
4527         * NEWS: Create a new section for the next release branch.
4528         Rename the section of the current branch, now that it has
4529         been cut.
4530
4531 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4532
4533         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
4534         * version.in: Bump version to 8.3.50.DATE-git.
4535
4536 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
4537
4538         * aix-thread.c (ptid_cmp): Remove unused variable.
4539         (get_signaled_thread): Likewise.
4540         (store_regs_user_thread): Likewise.
4541         (store_regs_kernel_thread): Likewise.
4542         (fetch_regs_kernel_thread): Remove shadowed variable.
4543
4544 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4545
4546         * features/riscv/32bit-cpu.xml: Add register numbers.
4547         * features/riscv/32bit-fpu.c: Regenerate.
4548         * features/riscv/32bit-fpu.xml: Add register numbers.
4549         * features/riscv/64bit-cpu.xml: Add register numbers.
4550         * features/riscv/64bit-fpu.c: Regenerate.
4551         * features/riscv/64bit-fpu.xml: Add register numbers.
4552
4553 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
4554
4555         * NEWS: Mention two argument form of gdb.Value constructor.
4556         * python/py-value.c (convert_buffer_and_type_to_value): New
4557         function.
4558         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
4559         Add support for handling an optional second argument.  Call
4560         convert_buffer_and_type_to_value as appropriate.
4561         * python/python-internal.h (Py_buffer_deleter): New struct.
4562         (Py_buffer_up): New typedef.
4563
4564 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
4565
4566         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
4567         instead of releasing ownership.
4568
4569 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
4570
4571         * dwarf2read.c (open_and_init_dwp_file): Call
4572         elf_numsections instead of bfd_count_sections to initialize
4573         dwp_file->num_sections.
4574
4575 2019-02-25  Tom Tromey  <tromey@adacore.com>
4576
4577         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
4578
4579 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4580
4581         * gcore.in: Add '--readnever' option when invoking GDB.
4582
4583 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4584
4585         * MAINTAINERS: Update my email address.
4586
4587 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4588
4589         * build-id.c (build_id_to_debug_bfd_1): New function.
4590         (build_id_to_debug_bfd): Look for separate debug file in
4591         sysroot.
4592
4593 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4594
4595         * gdbarch.sh: Update the copyright year range that is placed into
4596         generated files.
4597
4598 2019-02-22  Keith Seitz  <keiths@redhat.com>
4599
4600         PR symtab/23853
4601         * linespec.c (create_sals_line_offset): Search for the default
4602         symtab's filename instead of its fullname.
4603
4604 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4605
4606         * NEWS: Update style defaults.
4607
4608 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4609
4610         * main.c (captured_main_1): Disable styling in batch mode.
4611
4612 2019-02-20  Tom Tromey  <tom@tromey.com>
4613
4614         * symtab.c (symtab_symbol_info): Fix typos.
4615
4616 2019-02-20  Tom Tromey  <tromey@adacore.com>
4617
4618         * findcmd.c (_initialize_mem_search): Use upper case for
4619         metasyntactic variables.
4620
4621 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4622
4623         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4624         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4625
4626 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4627
4628         * top.h (source_file_name): Change to std::string.
4629         * top.c (source_file_name): Likewise.
4630         (command_line_input): Adjust.
4631         * cli/cli-script.c (script_from_file): Adjust.
4632
4633 2019-02-19  Tom Tromey  <tromey@adacore.com>
4634
4635         * ravenscar-thread.c
4636         (ravenscar_thread_target::update_thread_list): Don't call
4637         ada_build_task_list.
4638         * ada-lang.h (ada_build_task_list): Don't declare.
4639         * ada-tasks.c (struct ada_tasks_inferior_data)
4640         <task_list_valid_p>: Now bool.
4641         (read_known_tasks, ada_task_list_changed)
4642         (ada_tasks_invalidate_inferior_data): Update.
4643         (read_known_tasks_array): Return bool.
4644         (read_known_tasks_list): Likewise.
4645         (read_known_tasks): Return void.
4646         (ada_build_task_list): Now static.
4647
4648 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4649
4650         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4651         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4652
4653 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4654
4655         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4656         variant for ada_tasks_pspace_data_handle and
4657         ada_tasks_inferior_data_handle.
4658         (ada_tasks_pspace_data_cleanup): New function.
4659         (ada_tasks_inferior_data_cleanup): New function.
4660
4661 2019-02-17  Tom Tromey  <tom@tromey.com>
4662
4663         * macrotab.h (macro_source_fullname): Return a std::string.
4664         * macrotab.c (macro_include, check_for_redefinition)
4665         (macro_undef, macro_lookup_definition, foreach_macro)
4666         (foreach_macro_in_scope): Update.
4667         (macro_source_fullname): Return a std::string.
4668         * macrocmd.c (show_pp_source_pos): Update.
4669
4670 2019-02-17  Tom Tromey  <tom@tromey.com>
4671
4672         * macrocmd.c (show_pp_source_pos): Style the file names.
4673
4674 2019-02-17  Tom Tromey  <tom@tromey.com>
4675
4676         PR tui/24197:
4677         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4678
4679 2019-02-17  Tom Tromey  <tom@tromey.com>
4680
4681         * ada-lang.c (user_select_syms): Use filtered printing.
4682         * utils.c (wrap_style): New global.
4683         (desired_style): Remove.
4684         (emit_style_escape): Add stream parameter.
4685         (set_output_style, reset_terminal_style, prompt_for_continue):
4686         Update.
4687         (flush_wrap_buffer): Only flush gdb_stdout.
4688         (wrap_here): Set wrap_style.
4689         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4690         treat escape sequences as a character.  Change when wrap buffer is
4691         flushed.
4692         (fputs_styled): Do not set the output style when the default is
4693         requested.
4694         * ui-style.h (struct ui_file_style) <is_default>: New method.
4695         * source.c (print_source_lines_base): Emit escape sequences in one
4696         piece.
4697
4698 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4699
4700         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4701         integers and enumeration types.
4702
4703 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4704
4705         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4706         instead of lookup_symbol_in_language
4707         (do_exact_match): New function.
4708         (ada_get_symbol_name_matcher): Return do_exact_match when
4709         doing a verbatim match.
4710
4711 2019-02-15  Tom Tromey  <tromey@adacore.com>
4712
4713         * ravenscar-thread.c (ravenscar_thread_target::resume)
4714         (ravenscar_thread_target::wait): Special case wildcard requests.
4715
4716 2019-02-15  Tom Tromey  <tromey@adacore.com>
4717
4718         * ravenscar-thread.c (base_ptid): Remove.
4719         (struct ravenscar_thread_target) <close>: New method.
4720         <m_base_ptid>: New member.
4721         <update_inferior_ptid, active_task, task_is_currently_active,
4722         runtime_initialized>: Declare methods.
4723         <ravenscar_thread_target>: Add constructor.
4724         (ravenscar_thread_target::task_is_currently_active)
4725         (ravenscar_thread_target::update_inferior_ptid)
4726         (ravenscar_runtime_initialized): Rename.  Now methods.
4727         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4728         (ravenscar_thread_target::update_thread_list): Update.
4729         (ravenscar_thread_target::active_task): Now method.
4730         (ravenscar_thread_target::store_registers)
4731         (ravenscar_thread_target::prepare_to_store)
4732         (ravenscar_thread_target::prepare_to_store)
4733         (ravenscar_thread_target::mourn_inferior): Update.
4734         (ravenscar_inferior_created): Use "new" to create target.
4735         (ravenscar_thread_target::get_ada_task_ptid): Update.
4736         (_initialize_ravenscar): Don't initialize base_ptid.
4737         (ravenscar_ops): Remove global.
4738
4739 2019-02-15  Tom Tromey  <tromey@adacore.com>
4740
4741         * target.h (push_target): Declare new overload.
4742         * target.c (push_target): New overload, taking an rvalue reference.
4743         * remote.c (remote_target::open_1): Use push_target overload.
4744         * corelow.c (core_target_open): Use push_target overload.
4745
4746 2019-02-15  Tom Tromey  <tromey@adacore.com>
4747
4748         * ravenscar-thread.c (is_ravenscar_task)
4749         (ravenscar_task_is_currently_active): Return bool.
4750         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4751         (_initialize_ravenscar): Remove "(void)".
4752         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4753         Return bool.
4754
4755 2019-02-15  Tom Tromey  <tromey@adacore.com>
4756
4757         * ravenscar-thread.c (ravenscar_runtime_initializer)
4758         (has_ravenscar_runtime, get_running_thread_id)
4759         (ravenscar_thread_target::resume): Fix indentation.
4760
4761 2019-02-15  Tom Tromey  <tromey@adacore.com>
4762
4763         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4764         from ravenscar_arch_ops.
4765         (sparc_ravenscar_ops::fetch_registers)
4766         (sparc_ravenscar_ops::store_registers): Now methods.
4767         (sparc_ravenscar_prepare_to_store): Remove.
4768         (sparc_ravenscar_ops): Redefine.
4769         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4770         methods and destructor.  Remove members.
4771         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4772         (ravenscar_thread_target::store_registers)
4773         (ravenscar_thread_target::prepare_to_store): Update.
4774         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4775         Remove.
4776         (struct ppc_ravenscar_powerpc_ops): Derive from
4777         ravenscar_arch_ops.
4778         (ppc_ravenscar_powerpc_ops::fetch_registers)
4779         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4780         (ppc_ravenscar_powerpc_ops): Redefine.
4781         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4782         (ppc_ravenscar_e500_ops::fetch_registers)
4783         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4784         (ppc_ravenscar_e500_ops): Redefine.
4785         * aarch64-ravenscar-thread.c
4786         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4787         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4788         (aarch64_ravenscar_fetch_registers)
4789         (aarch64_ravenscar_store_registers): Now methods.
4790         (aarch64_ravenscar_ops): Redefine.
4791
4792 2019-02-15  Tom Tromey  <tromey@adacore.com>
4793
4794         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4795         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4796         (ravenscar_thread_target::stopped_by_watchpoint)
4797         (ravenscar_thread_target::stopped_data_address)
4798         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4799
4800 2019-02-15  Tom Tromey  <tromey@adacore.com>
4801
4802         * ravenscar-thread.c: Fix some typos.
4803
4804 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4805             Tom Tromey  <tromey@adacore.com>
4806
4807         * ada-lang.c (ada_exception_sal): Change addr_string to a
4808         std::string.
4809         (create_ada_exception_catchpoint): Update.
4810
4811 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4812             Tom Tromey  <tromey@adacore.com>
4813
4814         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4815         (bp_location_ops): Remove.
4816         (base_breakpoint_allocate_location): Update.
4817         (free_bp_location): Update.
4818         * ada-lang.c (class ada_catchpoint_location)
4819         <ada_catchpoint_location>: Remove ops parameter.
4820         (ada_catchpoint_location_dtor): Remove.
4821         (ada_catchpoint_location_ops): Remove.
4822         (allocate_location_exception): Update.
4823         * breakpoint.h (struct bp_location_ops): Remove.
4824         (class bp_location) <bp_location>: Remove bp_location_ops
4825         parameter.
4826         <~bp_location>: Add destructor.
4827         <ops>: Remove.
4828
4829 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4830             Pedro Alves  <palves@redhat.com>
4831
4832         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4833         'PATH_MAX'.
4834
4835 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4836             Samuel Thibault  <samuel.thibault@gnu.org>
4837             Thomas Schwinge  <thomas@codesourcery.com>
4838
4839         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4840         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4841
4842 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4843
4844         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4845         (check_empty): Use "const char *".
4846
4847         * gnu-nat.c (gnu_nat_target::detach): Instead of
4848         'detach_inferior (pid)' call
4849         'detach_inferior (find_inferior_pid (pid))'.
4850
4851         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4852         'nat/fork-inferior.o'.
4853         * gnu-nat.c: #include "nat/fork-inferior.h".
4854
4855         * gnu-nat.c (gnu_nat_target::detach): Instead of
4856         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4857         * gnu-nat.h: #include "inf-child.h".
4858         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4859         'i386_gnu_nat_target::fetch_registers'.
4860         (gnu_store_registers): Rename/move to
4861         'i386_gnu_nat_target::store_registers'.
4862
4863         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4864         * gnu-nat.h (mach_thread_info): New function.
4865         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4866
4867         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4868
4869 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4870
4871         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4872
4873 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4874
4875         * windows-nat.c (windows_add_thread): Add new parameter
4876         "main_thread_p" with default value set to false.  Update
4877         function documentation as well as all callers.
4878         (windows_delete_thread): Likewise.
4879         (fake_create_process): Update call to windows_add_thread.
4880         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4881         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4882         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4883         call to windows_delete_thread.
4884
4885 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4886
4887         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4888
4889 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4890
4891         * symfile.c (find_separate_debug_file): Use canonical path of
4892         sysroot with child_path instead of gdb_sysroot if it is valid.
4893
4894 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4895
4896         * symfile.c (find_separate_debug_file): Use child_path to
4897         determine if an object file is under a sysroot.
4898
4899 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4900
4901         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4902         unittests/child-path-selftests.c.
4903         * common/pathstuff.c (child_path): New function.
4904         * common/pathstuff.h (child_path): New prototype.
4905         * unittests/child-path-selftests.c: New file.
4906
4907 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4908
4909         * symfile.c (find_separate_debug_file): Look for separate debug
4910         files in debug directories under the sysroot.
4911
4912 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4913
4914         * symtab.h (struct minimal_symbol data_p): New const method.
4915         (struct minimal_symbol text_p): Likewise.
4916         * symtab.c (output_source_filename): Use file name style
4917         to print file name.
4918         (print_symbol_info): Likewise.
4919         (print_msymbol_info): Use address style to print addresses.
4920         Use function name style to print executable text symbols.
4921         (expand_symtab_containing_pc): Use data_p.
4922         (find_pc_sect_compunit_symtab): Likewise.
4923
4924 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4925
4926         * breakpoint.c (describe_other_breakpoints): Use address style
4927         to print addresses.
4928         (say_where): Likewise.
4929
4930 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4931
4932         * ada-typeprint.c (print_func_type): Print function name
4933         style to print function name.
4934         * c-typeprint.c (c_print_type_1): Likewise.
4935
4936 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4937
4938         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4939         for execve.
4940
4941 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4942
4943         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4944         type_stack.
4945
4946 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4947
4948         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4949         TYPE_CODE_REF types.
4950
4951 2019-02-08  Jim Wilson  <jimw@sifive.com>
4952
4953         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4954         (riscv_linux_fregset): New.
4955         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4956
4957 2019-02-07  Tom Tromey  <tom@tromey.com>
4958
4959         * thread.c (thread_cancel_execution_command): Update.
4960         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4961         methods.
4962         (struct thread_fsm_ops): Remove.
4963         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4964         (thread_fsm_should_stop, thread_fsm_return_value)
4965         (thread_fsm_set_finished, thread_fsm_finished_p)
4966         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4967         Don't declare.
4968         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4969         * infrun.c (clear_proceed_status_thread)
4970         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4971         (print_stop_event): Update.
4972         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4973         Add constructor.
4974         (step_command_fsm_ops): Remove.
4975         (new_step_command_fsm): Remove.
4976         (step_1): Update.
4977         (step_command_fsm::should_stop): Rename from
4978         step_command_fsm_should_stop.
4979         (step_command_fsm::clean_up): Rename from
4980         step_command_fsm_clean_up.
4981         (step_command_fsm::do_async_reply_reason): Rename from
4982         step_command_fsm_async_reply_reason.
4983         (struct until_next_fsm): Inherit from thread_fsm.  Add
4984         constructor.
4985         (until_next_fsm_ops): Remove.
4986         (new_until_next_fsm): Remove.
4987         (until_next_fsm::should_stop): Rename from
4988         until_next_fsm_should_stop.
4989         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4990         (until_next_fsm::do_async_reply_reason): Rename from
4991         until_next_fsm_async_reply_reason.
4992         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4993         constructor.  Change type of breakpoint.
4994         (finish_command_fsm_ops): Remove.
4995         (new_finish_command_fsm): Remove.
4996         (finish_command_fsm::should_stop): Rename from
4997         finish_command_fsm_should_stop.
4998         (finish_command_fsm::clean_up): Rename from
4999         finish_command_fsm_clean_up.
5000         (finish_command_fsm::return_value): Rename from
5001         finish_command_fsm_return_value.
5002         (finish_command_fsm::do_async_reply_reason): Rename from
5003         finish_command_fsm_async_reply_reason.
5004         (finish_command): Update.
5005         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
5006         Add constructor.
5007         (call_thread_fsm_ops): Remove.
5008         (call_thread_fsm::call_thread_fsm): Rename from
5009         new_call_thread_fsm.
5010         (call_thread_fsm::should_stop): Rename from
5011         call_thread_fsm_should_stop.
5012         (call_thread_fsm::should_notify_stop): Rename from
5013         call_thread_fsm_should_notify_stop.
5014         (run_inferior_call, call_function_by_hand_dummy): Update.
5015         * cli/cli-interp.c (should_print_stop_to_console): Update.
5016         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
5017         Add constructor.  Change type of location_breakpoint,
5018         caller_breakpoint.
5019         (until_break_fsm_ops): Remove.
5020         (new_until_break_fsm): Remove.
5021         (until_break_fsm::should_stop): Rename from
5022         until_break_fsm_should_stop.
5023         (until_break_fsm::clean_up): Rename from
5024         until_break_fsm_clean_up.
5025         (until_break_fsm::do_async_reply_reason): Rename from
5026         until_break_fsm_async_reply_reason.
5027         (until_break_command): Update.
5028         * thread-fsm.c: Remove.
5029         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
5030
5031 2019-02-07  Tom Tromey  <tom@tromey.com>
5032
5033         * yy-remap.h: Add include guard.
5034         * xtensa-tdep.h: Add include guard.
5035         * xcoffread.h: Rename include guard.
5036         * varobj-iter.h: Add include guard.
5037         * tui/tui.h: Rename include guard.
5038         * tui/tui-winsource.h: Rename include guard.
5039         * tui/tui-wingeneral.h: Rename include guard.
5040         * tui/tui-windata.h: Rename include guard.
5041         * tui/tui-win.h: Rename include guard.
5042         * tui/tui-stack.h: Rename include guard.
5043         * tui/tui-source.h: Rename include guard.
5044         * tui/tui-regs.h: Rename include guard.
5045         * tui/tui-out.h: Rename include guard.
5046         * tui/tui-layout.h: Rename include guard.
5047         * tui/tui-io.h: Rename include guard.
5048         * tui/tui-hooks.h: Rename include guard.
5049         * tui/tui-file.h: Rename include guard.
5050         * tui/tui-disasm.h: Rename include guard.
5051         * tui/tui-data.h: Rename include guard.
5052         * tui/tui-command.h: Rename include guard.
5053         * tic6x-tdep.h: Add include guard.
5054         * target/waitstatus.h: Rename include guard.
5055         * target/wait.h: Rename include guard.
5056         * target/target.h: Rename include guard.
5057         * target/resume.h: Rename include guard.
5058         * target-float.h: Rename include guard.
5059         * stabsread.h: Add include guard.
5060         * rs6000-tdep.h: Add include guard.
5061         * riscv-fbsd-tdep.h: Add include guard.
5062         * regformats/regdef.h: Rename include guard.
5063         * record.h: Rename include guard.
5064         * python/python.h: Rename include guard.
5065         * python/python-internal.h: Rename include guard.
5066         * python/py-stopevent.h: Rename include guard.
5067         * python/py-ref.h: Rename include guard.
5068         * python/py-record.h: Rename include guard.
5069         * python/py-record-full.h: Rename include guard.
5070         * python/py-record-btrace.h: Rename include guard.
5071         * python/py-instruction.h: Rename include guard.
5072         * python/py-events.h: Rename include guard.
5073         * python/py-event.h: Rename include guard.
5074         * procfs.h: Add include guard.
5075         * proc-utils.h: Add include guard.
5076         * p-lang.h: Add include guard.
5077         * or1k-tdep.h: Rename include guard.
5078         * observable.h: Rename include guard.
5079         * nto-tdep.h: Rename include guard.
5080         * nat/x86-linux.h: Rename include guard.
5081         * nat/x86-linux-dregs.h: Rename include guard.
5082         * nat/x86-gcc-cpuid.h: Add include guard.
5083         * nat/x86-dregs.h: Rename include guard.
5084         * nat/x86-cpuid.h: Rename include guard.
5085         * nat/ppc-linux.h: Rename include guard.
5086         * nat/mips-linux-watch.h: Rename include guard.
5087         * nat/linux-waitpid.h: Rename include guard.
5088         * nat/linux-ptrace.h: Rename include guard.
5089         * nat/linux-procfs.h: Rename include guard.
5090         * nat/linux-osdata.h: Rename include guard.
5091         * nat/linux-nat.h: Rename include guard.
5092         * nat/linux-namespaces.h: Rename include guard.
5093         * nat/linux-btrace.h: Rename include guard.
5094         * nat/glibc_thread_db.h: Rename include guard.
5095         * nat/gdb_thread_db.h: Rename include guard.
5096         * nat/gdb_ptrace.h: Rename include guard.
5097         * nat/fork-inferior.h: Rename include guard.
5098         * nat/amd64-linux-siginfo.h: Rename include guard.
5099         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
5100         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
5101         * nat/aarch64-linux.h: Rename include guard.
5102         * nat/aarch64-linux-hw-point.h: Rename include guard.
5103         * mn10300-tdep.h: Add include guard.
5104         * mips-linux-tdep.h: Add include guard.
5105         * mi/mi-parse.h: Rename include guard.
5106         * mi/mi-out.h: Rename include guard.
5107         * mi/mi-main.h: Rename include guard.
5108         * mi/mi-interp.h: Rename include guard.
5109         * mi/mi-getopt.h: Rename include guard.
5110         * mi/mi-console.h: Rename include guard.
5111         * mi/mi-common.h: Rename include guard.
5112         * mi/mi-cmds.h: Rename include guard.
5113         * mi/mi-cmd-break.h: Rename include guard.
5114         * m2-lang.h: Add include guard.
5115         * location.h: Rename include guard.
5116         * linux-record.h: Rename include guard.
5117         * linux-nat.h: Add include guard.
5118         * linux-fork.h: Add include guard.
5119         * i386-darwin-tdep.h: Rename include guard.
5120         * hppa-linux-offsets.h: Add include guard.
5121         * guile/guile.h: Rename include guard.
5122         * guile/guile-internal.h: Rename include guard.
5123         * gnu-nat.h: Rename include guard.
5124         * gdb-stabs.h: Rename include guard.
5125         * frv-tdep.h: Add include guard.
5126         * f-lang.h: Add include guard.
5127         * event-loop.h: Add include guard.
5128         * darwin-nat.h: Rename include guard.
5129         * cp-abi.h: Rename include guard.
5130         * config/sparc/nm-sol2.h: Rename include guard.
5131         * config/nm-nto.h: Rename include guard.
5132         * config/nm-linux.h: Add include guard.
5133         * config/i386/nm-i386gnu.h: Rename include guard.
5134         * config/djgpp/nl_types.h: Rename include guard.
5135         * config/djgpp/langinfo.h: Rename include guard.
5136         * compile/gcc-cp-plugin.h: Add include guard.
5137         * compile/gcc-c-plugin.h: Add include guard.
5138         * compile/compile.h: Rename include guard.
5139         * compile/compile-object-run.h: Rename include guard.
5140         * compile/compile-object-load.h: Rename include guard.
5141         * compile/compile-internal.h: Rename include guard.
5142         * compile/compile-cplus.h: Rename include guard.
5143         * compile/compile-c.h: Rename include guard.
5144         * common/xml-utils.h: Rename include guard.
5145         * common/x86-xstate.h: Rename include guard.
5146         * common/version.h: Rename include guard.
5147         * common/vec.h: Rename include guard.
5148         * common/tdesc.h: Rename include guard.
5149         * common/selftest.h: Rename include guard.
5150         * common/scoped_restore.h: Rename include guard.
5151         * common/scoped_mmap.h: Rename include guard.
5152         * common/scoped_fd.h: Rename include guard.
5153         * common/safe-iterator.h: Rename include guard.
5154         * common/run-time-clock.h: Rename include guard.
5155         * common/refcounted-object.h: Rename include guard.
5156         * common/queue.h: Rename include guard.
5157         * common/ptid.h: Rename include guard.
5158         * common/print-utils.h: Rename include guard.
5159         * common/preprocessor.h: Rename include guard.
5160         * common/pathstuff.h: Rename include guard.
5161         * common/observable.h: Rename include guard.
5162         * common/netstuff.h: Rename include guard.
5163         * common/job-control.h: Rename include guard.
5164         * common/host-defs.h: Rename include guard.
5165         * common/gdb_wait.h: Rename include guard.
5166         * common/gdb_vecs.h: Rename include guard.
5167         * common/gdb_unlinker.h: Rename include guard.
5168         * common/gdb_unique_ptr.h: Rename include guard.
5169         * common/gdb_tilde_expand.h: Rename include guard.
5170         * common/gdb_sys_time.h: Rename include guard.
5171         * common/gdb_string_view.h: Rename include guard.
5172         * common/gdb_splay_tree.h: Rename include guard.
5173         * common/gdb_setjmp.h: Rename include guard.
5174         * common/gdb_ref_ptr.h: Rename include guard.
5175         * common/gdb_optional.h: Rename include guard.
5176         * common/gdb_locale.h: Rename include guard.
5177         * common/gdb_assert.h: Rename include guard.
5178         * common/filtered-iterator.h: Rename include guard.
5179         * common/filestuff.h: Rename include guard.
5180         * common/fileio.h: Rename include guard.
5181         * common/environ.h: Rename include guard.
5182         * common/common-utils.h: Rename include guard.
5183         * common/common-types.h: Rename include guard.
5184         * common/common-regcache.h: Rename include guard.
5185         * common/common-inferior.h: Rename include guard.
5186         * common/common-gdbthread.h: Rename include guard.
5187         * common/common-exceptions.h: Rename include guard.
5188         * common/common-defs.h: Rename include guard.
5189         * common/common-debug.h: Rename include guard.
5190         * common/cleanups.h: Rename include guard.
5191         * common/buffer.h: Rename include guard.
5192         * common/btrace-common.h: Rename include guard.
5193         * common/break-common.h: Rename include guard.
5194         * cli/cli-utils.h: Rename include guard.
5195         * cli/cli-style.h: Rename include guard.
5196         * cli/cli-setshow.h: Rename include guard.
5197         * cli/cli-script.h: Rename include guard.
5198         * cli/cli-interp.h: Rename include guard.
5199         * cli/cli-decode.h: Rename include guard.
5200         * cli/cli-cmds.h: Rename include guard.
5201         * charset-list.h: Add include guard.
5202         * buildsym-legacy.h: Rename include guard.
5203         * bfin-tdep.h: Add include guard.
5204         * ax.h: Rename include guard.
5205         * arm-linux-tdep.h: Add include guard.
5206         * arm-fbsd-tdep.h: Add include guard.
5207         * arch/xtensa.h: Rename include guard.
5208         * arch/tic6x.h: Add include guard.
5209         * arch/i386.h: Add include guard.
5210         * arch/arm.h: Rename include guard.
5211         * arch/arm-linux.h: Rename include guard.
5212         * arch/arm-get-next-pcs.h: Rename include guard.
5213         * arch/amd64.h: Add include guard.
5214         * arch/aarch64-insn.h: Rename include guard.
5215         * arch-utils.h: Rename include guard.
5216         * annotate.h: Add include guard.
5217         * amd64-darwin-tdep.h: Rename include guard.
5218         * aarch64-linux-tdep.h: Add include guard.
5219         * aarch64-fbsd-tdep.h: Add include guard.
5220         * aarch32-linux-nat.h: Add include guard.
5221
5222 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5223
5224         * macrotab.c (macro_define_internal): New function that
5225         factorizes macro_define_object_internal and macro_define_function
5226         code.
5227         (macro_define_object_internal): Use macro_define_internal.
5228         (macro_define_function): Likewise.
5229
5230 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5231
5232         * macrocmd.c (extract_identifier): Return
5233         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
5234         callers.
5235
5236 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
5237
5238         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
5239
5240 2019-02-05  Tom Tromey  <tom@tromey.com>
5241
5242         * target.c (target_stack::unpush): Move assertion earlier.
5243
5244 2019-01-30  Tom Tromey  <tom@tromey.com>
5245
5246         PR python/23615:
5247         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
5248         (gdbpy_parse_and_eval): Likewise.
5249         * python/python-internal.h (gdbpy_allow_threads): New class.
5250
5251 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
5252
5253         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
5254         (aarch64_fbsd_fpregmap): Move earlier.
5255         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
5256         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5257         instead of individual calls to trad_frame_set_reg_addr.
5258         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
5259         earlier.
5260         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
5261         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5262         instead of individual calls to trad_frame_set_reg_addr.
5263
5264 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
5265
5266         * CONTRIBUTE: Replace contribution list with wiki link.
5267
5268 2019-01-25  Tom Tromey  <tom@tromey.com>
5269
5270         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
5271
5272 2019-01-25  Tom Tromey  <tom@tromey.com>
5273
5274         * xtensa-linux-nat.c: Fix common/ includes.
5275         * xml-support.h: Fix common/ includes.
5276         * xml-support.c: Fix common/ includes.
5277         * x86-linux-nat.c: Fix common/ includes.
5278         * windows-nat.c: Fix common/ includes.
5279         * varobj.h: Fix common/ includes.
5280         * varobj.c: Fix common/ includes.
5281         * value.c: Fix common/ includes.
5282         * valops.c: Fix common/ includes.
5283         * utils.c: Fix common/ includes.
5284         * unittests/xml-utils-selftests.c: Fix common/ includes.
5285         * unittests/utils-selftests.c: Fix common/ includes.
5286         * unittests/unpack-selftests.c: Fix common/ includes.
5287         * unittests/tracepoint-selftests.c: Fix common/ includes.
5288         * unittests/style-selftests.c: Fix common/ includes.
5289         * unittests/string_view-selftests.c: Fix common/ includes.
5290         * unittests/scoped_restore-selftests.c: Fix common/ includes.
5291         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
5292         * unittests/scoped_fd-selftests.c: Fix common/ includes.
5293         * unittests/rsp-low-selftests.c: Fix common/ includes.
5294         * unittests/parse-connection-spec-selftests.c: Fix common/
5295         includes.
5296         * unittests/optional-selftests.c: Fix common/ includes.
5297         * unittests/offset-type-selftests.c: Fix common/ includes.
5298         * unittests/observable-selftests.c: Fix common/ includes.
5299         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
5300         * unittests/memrange-selftests.c: Fix common/ includes.
5301         * unittests/memory-map-selftests.c: Fix common/ includes.
5302         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
5303         * unittests/function-view-selftests.c: Fix common/ includes.
5304         * unittests/environ-selftests.c: Fix common/ includes.
5305         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
5306         * unittests/common-utils-selftests.c: Fix common/ includes.
5307         * unittests/cli-utils-selftests.c: Fix common/ includes.
5308         * unittests/array-view-selftests.c: Fix common/ includes.
5309         * ui-file.c: Fix common/ includes.
5310         * tui/tui-io.c: Fix common/ includes.
5311         * tracepoint.h: Fix common/ includes.
5312         * tracepoint.c: Fix common/ includes.
5313         * tracefile-tfile.c: Fix common/ includes.
5314         * top.h: Fix common/ includes.
5315         * top.c: Fix common/ includes.
5316         * thread.c: Fix common/ includes.
5317         * target/waitstatus.h: Fix common/ includes.
5318         * target/waitstatus.c: Fix common/ includes.
5319         * target.h: Fix common/ includes.
5320         * target.c: Fix common/ includes.
5321         * target-memory.c: Fix common/ includes.
5322         * target-descriptions.c: Fix common/ includes.
5323         * symtab.h: Fix common/ includes.
5324         * symfile.c: Fix common/ includes.
5325         * stap-probe.c: Fix common/ includes.
5326         * spu-linux-nat.c: Fix common/ includes.
5327         * sparc-nat.c: Fix common/ includes.
5328         * source.c: Fix common/ includes.
5329         * solib.c: Fix common/ includes.
5330         * solib-target.c: Fix common/ includes.
5331         * ser-unix.c: Fix common/ includes.
5332         * ser-tcp.c: Fix common/ includes.
5333         * ser-pipe.c: Fix common/ includes.
5334         * ser-base.c: Fix common/ includes.
5335         * selftest-arch.c: Fix common/ includes.
5336         * s12z-tdep.c: Fix common/ includes.
5337         * rust-exp.y: Fix common/ includes.
5338         * rs6000-aix-tdep.c: Fix common/ includes.
5339         * riscv-tdep.c: Fix common/ includes.
5340         * remote.c: Fix common/ includes.
5341         * remote-notif.h: Fix common/ includes.
5342         * remote-fileio.h: Fix common/ includes.
5343         * remote-fileio.c: Fix common/ includes.
5344         * regcache.h: Fix common/ includes.
5345         * regcache.c: Fix common/ includes.
5346         * record-btrace.c: Fix common/ includes.
5347         * python/python.c: Fix common/ includes.
5348         * python/py-type.c: Fix common/ includes.
5349         * python/py-inferior.c: Fix common/ includes.
5350         * progspace.h: Fix common/ includes.
5351         * producer.c: Fix common/ includes.
5352         * procfs.c: Fix common/ includes.
5353         * proc-api.c: Fix common/ includes.
5354         * printcmd.c: Fix common/ includes.
5355         * ppc-linux-nat.c: Fix common/ includes.
5356         * parser-defs.h: Fix common/ includes.
5357         * osdata.c: Fix common/ includes.
5358         * obsd-nat.c: Fix common/ includes.
5359         * nat/x86-linux.c: Fix common/ includes.
5360         * nat/x86-linux-dregs.c: Fix common/ includes.
5361         * nat/x86-dregs.h: Fix common/ includes.
5362         * nat/x86-dregs.c: Fix common/ includes.
5363         * nat/ppc-linux.c: Fix common/ includes.
5364         * nat/mips-linux-watch.h: Fix common/ includes.
5365         * nat/mips-linux-watch.c: Fix common/ includes.
5366         * nat/linux-waitpid.c: Fix common/ includes.
5367         * nat/linux-ptrace.h: Fix common/ includes.
5368         * nat/linux-ptrace.c: Fix common/ includes.
5369         * nat/linux-procfs.c: Fix common/ includes.
5370         * nat/linux-personality.c: Fix common/ includes.
5371         * nat/linux-osdata.c: Fix common/ includes.
5372         * nat/linux-namespaces.c: Fix common/ includes.
5373         * nat/linux-btrace.h: Fix common/ includes.
5374         * nat/linux-btrace.c: Fix common/ includes.
5375         * nat/fork-inferior.c: Fix common/ includes.
5376         * nat/amd64-linux-siginfo.c: Fix common/ includes.
5377         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
5378         * nat/aarch64-linux.c: Fix common/ includes.
5379         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
5380         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
5381         * namespace.h: Fix common/ includes.
5382         * mips-linux-tdep.c: Fix common/ includes.
5383         * minsyms.c: Fix common/ includes.
5384         * mi/mi-parse.h: Fix common/ includes.
5385         * mi/mi-main.c: Fix common/ includes.
5386         * mi/mi-cmd-env.c: Fix common/ includes.
5387         * memrange.h: Fix common/ includes.
5388         * memattr.c: Fix common/ includes.
5389         * maint.h: Fix common/ includes.
5390         * maint.c: Fix common/ includes.
5391         * main.c: Fix common/ includes.
5392         * machoread.c: Fix common/ includes.
5393         * location.c: Fix common/ includes.
5394         * linux-thread-db.c: Fix common/ includes.
5395         * linux-nat.c: Fix common/ includes.
5396         * linux-fork.c: Fix common/ includes.
5397         * inline-frame.c: Fix common/ includes.
5398         * infrun.c: Fix common/ includes.
5399         * inflow.c: Fix common/ includes.
5400         * inferior.h: Fix common/ includes.
5401         * inferior.c: Fix common/ includes.
5402         * infcmd.c: Fix common/ includes.
5403         * inf-ptrace.c: Fix common/ includes.
5404         * inf-child.c: Fix common/ includes.
5405         * ia64-linux-nat.c: Fix common/ includes.
5406         * i387-tdep.c: Fix common/ includes.
5407         * i386-tdep.c: Fix common/ includes.
5408         * i386-linux-tdep.c: Fix common/ includes.
5409         * i386-linux-nat.c: Fix common/ includes.
5410         * i386-go32-tdep.c: Fix common/ includes.
5411         * i386-fbsd-tdep.c: Fix common/ includes.
5412         * i386-fbsd-nat.c: Fix common/ includes.
5413         * guile/scm-type.c: Fix common/ includes.
5414         * guile/guile.c: Fix common/ includes.
5415         * go32-nat.c: Fix common/ includes.
5416         * gnu-nat.c: Fix common/ includes.
5417         * gdbthread.h: Fix common/ includes.
5418         * gdbarch-selftests.c: Fix common/ includes.
5419         * gdb_usleep.c: Fix common/ includes.
5420         * gdb_select.h: Fix common/ includes.
5421         * gdb_bfd.c: Fix common/ includes.
5422         * gcore.c: Fix common/ includes.
5423         * fork-child.c: Fix common/ includes.
5424         * findvar.c: Fix common/ includes.
5425         * fbsd-nat.c: Fix common/ includes.
5426         * event-top.c: Fix common/ includes.
5427         * event-loop.c: Fix common/ includes.
5428         * dwarf2read.c: Fix common/ includes.
5429         * dwarf2loc.c: Fix common/ includes.
5430         * dwarf2-frame.c: Fix common/ includes.
5431         * dwarf-index-cache.c: Fix common/ includes.
5432         * dtrace-probe.c: Fix common/ includes.
5433         * disasm-selftests.c: Fix common/ includes.
5434         * defs.h: Fix common/ includes.
5435         * csky-tdep.c: Fix common/ includes.
5436         * cp-valprint.c: Fix common/ includes.
5437         * cp-support.h: Fix common/ includes.
5438         * cp-support.c: Fix common/ includes.
5439         * corelow.c: Fix common/ includes.
5440         * completer.h: Fix common/ includes.
5441         * completer.c: Fix common/ includes.
5442         * compile/compile.c: Fix common/ includes.
5443         * compile/compile-loc2c.c: Fix common/ includes.
5444         * compile/compile-cplus-types.c: Fix common/ includes.
5445         * compile/compile-cplus-symbols.c: Fix common/ includes.
5446         * command.h: Fix common/ includes.
5447         * cli/cli-dump.c: Fix common/ includes.
5448         * cli/cli-cmds.c: Fix common/ includes.
5449         * charset.c: Fix common/ includes.
5450         * build-id.c: Fix common/ includes.
5451         * btrace.h: Fix common/ includes.
5452         * btrace.c: Fix common/ includes.
5453         * breakpoint.h: Fix common/ includes.
5454         * breakpoint.c: Fix common/ includes.
5455         * ax.h:
5456         (enum agent_op): Fix common/ includes.
5457         * ax-general.c (struct aop_map): Fix common/ includes.
5458         * ax-gdb.c: Fix common/ includes.
5459         * auxv.c: Fix common/ includes.
5460         * auto-load.c: Fix common/ includes.
5461         * arm-tdep.c: Fix common/ includes.
5462         * arch/riscv.c: Fix common/ includes.
5463         * arch/ppc-linux-common.c: Fix common/ includes.
5464         * arch/i386.c: Fix common/ includes.
5465         * arch/arm.c: Fix common/ includes.
5466         * arch/arm-linux.c: Fix common/ includes.
5467         * arch/arm-get-next-pcs.c: Fix common/ includes.
5468         * arch/amd64.c: Fix common/ includes.
5469         * arch/aarch64.c: Fix common/ includes.
5470         * arch/aarch64-insn.c: Fix common/ includes.
5471         * arch-utils.c: Fix common/ includes.
5472         * amd64-windows-tdep.c: Fix common/ includes.
5473         * amd64-tdep.c: Fix common/ includes.
5474         * amd64-sol2-tdep.c: Fix common/ includes.
5475         * amd64-obsd-tdep.c: Fix common/ includes.
5476         * amd64-nbsd-tdep.c: Fix common/ includes.
5477         * amd64-linux-tdep.c: Fix common/ includes.
5478         * amd64-linux-nat.c: Fix common/ includes.
5479         * amd64-fbsd-tdep.c: Fix common/ includes.
5480         * amd64-fbsd-nat.c: Fix common/ includes.
5481         * amd64-dicos-tdep.c: Fix common/ includes.
5482         * amd64-darwin-tdep.c: Fix common/ includes.
5483         * agent.c: Fix common/ includes.
5484         * ada-lang.h: Fix common/ includes.
5485         * ada-lang.c: Fix common/ includes.
5486         * aarch64-tdep.c: Fix common/ includes.
5487
5488 2019-01-25  Tom Tromey  <tom@tromey.com>
5489
5490         * common/create-version.sh: Use common/version.h.
5491
5492 2019-01-24  Pedro Alves  <palves@redhat.com>
5493
5494         * infrun.c (signal_stop, signal_print, signal_program)
5495         (signal_catch, signal_pass): Now arrays instead of pointers.
5496         (update_signals_program_target, do_target_resume)
5497         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
5498         * linux-nat.c (linux_nat_target::pass_signals)
5499         (linux_nat_target::create_inferior, linux_nat_target::attach):
5500         Adjust.
5501         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
5502         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
5503         * procfs.c (procfs_target::pass_signals): Adjust.
5504         * record-full.c (record_full_target::resume): Adjust.
5505         * remote.c (remote_target::pass_signals)
5506         (remote_target::program_signals): Adjust.
5507         * target-debug.h (target_debug_print_signals): Now takes a
5508         gdb::array_view as parameter.  Adjust.
5509         * target.h (target_ops) <pass_signals, program_signals>: Replace
5510         pointer and length parameters with gdb::array_view.
5511         (target_pass_signals, target_program_signals): Likewise.
5512         * target-delegates.c: Regenerate.
5513
5514 2019-01-24  Pedro Alves  <palves@redhat.com>
5515
5516         * common/forward-scope-exit.h
5517         (forward_scope_exit::forward_scope_exit): Pass arguments to
5518         m_bind_function directly, instead of creating a std::bind and
5519         copying that.
5520
5521 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
5522
5523         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5524         for static members.
5525         (pass_in_v_vfp_candidate): Likewise.
5526
5527 2019-01-23  Tom Tromey  <tom@tromey.com>
5528             Pedro Alves  <palves@redhat.com>
5529
5530         * regcache.c (class regcache_invalidator): Remove.
5531         (regcache::raw_write): Use make_scope_exit.
5532
5533 2019-01-23  Tom Tromey  <tom@tromey.com>
5534
5535         * ui-out.h (class ui_out_emit_type): Update comment.
5536
5537 2019-01-23  Tom Tromey  <tom@tromey.com>
5538
5539         * infrun.c (fetch_inferior_event): Update comment.
5540
5541 2019-01-23  Tom Tromey  <tom@tromey.com>
5542             Pedro Alves  <palves@redhat.com>
5543
5544         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
5545         parameter.
5546         (fetch_inferior_event): Use SCOPE_EXIT.
5547
5548
5549 2019-01-23  Tom Tromey  <tom@tromey.com>
5550             Pedro Alves  <palves@redhat.com>
5551
5552         * infrun.c (disable_thread_events): Delete.
5553         (stop_all_threads): Use SCOPE_EXIT.
5554
5555 2019-01-23  Tom Tromey  <tom@tromey.com>
5556             Pedro Alves  <palves@redhat.com>
5557
5558         * symfile.c: Include forward-scope-exit.h.
5559         (clear_symtab_users_cleanup): Replace forward declaration with
5560         a FORWARD_SCOPE_EXIT.
5561         (syms_from_objfile_1): Use the forward_scope_exit and
5562         gdb::optional instead of cleanup_function.
5563         (reread_symbols): Use the forward_scope_exit instead of
5564         cleanup_function.
5565         (clear_symtab_users_cleanup): Remove function.
5566
5567 2019-01-23  Tom Tromey  <tom@tromey.com>
5568             Pedro Alves  <palves@redhat.com>
5569
5570         * linux-nat.c: Include scope-exit.h.
5571         (cleanup_target_stop): Remove.
5572         (linux_nat_target::static_tracepoint_markers_by_strid): Use
5573         SCOPE_EXIT.
5574
5575 2019-01-23  Tom Tromey  <tom@tromey.com>
5576             Pedro Alves  <palves@redhat.com>
5577
5578         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
5579         (call_function_by_hand_dummy): Use SCOPE_EXIT.
5580
5581 2019-01-23  Tom Tromey  <tom@tromey.com>
5582             Andrew Burgess  <andrew.burgess@embecosm.com>
5583             Pedro Alves  <palves@redhat.com>
5584
5585         * infrun.c (fetch_inferior_event): Use scope_exit.
5586         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
5587         * top.c (execute_command): Use scope_exit.
5588         * breakpoint.c (bpstat_do_actions): Use scope_exit.
5589         * utils.c (do_bpstat_clear_actions_cleanup)
5590         (make_bpstat_clear_actions_cleanup): Remove.
5591
5592 2019-01-23  Tom Tromey  <tom@tromey.com>
5593             Pedro Alves  <palves@redhat.com>
5594
5595         * infrun.c: Include "common/scope-exit.h"
5596         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
5597         (wait_for_inferior): Use SCOPE_EXIT.
5598         (fetch_inferior_event): Use scope_exit.
5599
5600 2019-01-23  Tom Tromey  <tom@tromey.com>
5601             Pedro Alves  <palves@redhat.com>
5602
5603         * breakpoint.c (create_breakpoint): Remove cleanup.
5604
5605 2019-01-23  Tom Tromey  <tom@tromey.com>
5606             Andrew Burgess  <andrew.burgess@embecosm.com>
5607             Pedro Alves  <palves@redhat.com>
5608
5609 2019-01-23  Pedro Alves  <palves@redhat.com>
5610
5611         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5612
5613 2019-01-23  Pedro Alves  <palves@redhat.com>
5614             Andrew Burgess  <andrew.burgess@embecosm.com>
5615
5616         * gdbthread.h: Include "common/forward-scope-exit.h".
5617         (scoped_finish_thread_state): Redefine custom class in terms of
5618         forward_scope_exit.
5619
5620 2019-01-23  Pedro Alves  <palves@redhat.com>
5621             Andrew Burgess  <andrew.burgess@embecosm.com>
5622
5623         * common/forward-scope-exit.h: New file.
5624
5625 2019-01-23  Pedro Alves  <palves@redhat.com>
5626             Andrew Burgess  <andrew.burgess@embecosm.com>
5627             Tom Tromey  <tom@tromey.com>
5628
5629         * common/scope-exit.h: New file.
5630
5631 2019-01-23  Pedro Alves  <palves@redhat.com>
5632
5633         * common/preprocessor.h (ESC): Rename to ...
5634         (ESC_PARENS): ... this.
5635         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5636         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5637
5638 2019-01-23  Tom Tromey  <tom@tromey.com>
5639
5640         * language.h (class scoped_switch_to_sym_language_if_auto):
5641         Initialize m_lang in both cases.
5642
5643 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5644
5645         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5646         with XCNEW.
5647
5648 2019-01-22  Tom Tromey  <tom@tromey.com>
5649
5650         * corelow.c: Do not include sys/file.h.
5651
5652 2019-01-22  Tom Tromey  <tom@tromey.com>
5653
5654         * tui/tui-wingeneral.h: Include gdb_curses.h.
5655
5656 2019-01-22  Tom Tromey  <tom@tromey.com>
5657
5658         * source-cache.h (class source_cache) <get_source_lines,
5659         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5660
5661 2019-01-22  Tom Tromey  <tom@tromey.com>
5662
5663         * remote-fileio.h (struct remote_target): Declare.
5664
5665 2019-01-22  Tom Tromey  <tom@tromey.com>
5666
5667         * python/py-arch.c: Do not include py-ref.h.
5668         * python/py-bpevent.c: Do not include py-ref.h.
5669         * python/py-cmd.c: Do not include py-ref.h.
5670         * python/py-continueevent.c: Do not include py-ref.h.
5671         * python/py-event.h: Do not include py-ref.h.
5672         * python/py-evtregistry.c: Do not include py-ref.h.
5673         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5674         * python/py-frame.c: Do not include py-ref.h.
5675         * python/py-framefilter.c: Do not include py-ref.h.
5676         * python/py-function.c: Do not include py-ref.h.
5677         * python/py-infevents.c: Do not include py-ref.h.
5678         * python/py-linetable.c: Do not include py-ref.h.
5679         * python/py-objfile.c: Do not include py-ref.h.
5680         * python/py-param.c: Do not include py-ref.h.
5681         * python/py-prettyprint.c: Do not include py-ref.h.
5682         * python/py-progspace.c: Do not include py-ref.h.
5683         * python/py-symbol.c: Do not include py-ref.h.
5684         * python/py-symtab.c: Do not include py-ref.h.
5685         * python/py-type.c: Do not include py-ref.h.
5686         * python/py-unwind.c: Do not include py-ref.h.
5687         * python/py-utils.c: Do not include py-ref.h.
5688         * python/py-value.c: Do not include py-ref.h.
5689         * python/py-varobj.c: Do not include py-ref.h.
5690         * python/py-xmethods.c: Do not include py-ref.h.
5691         * python/python.c: Do not include py-ref.h.
5692         * varobj.c: Do not include py-ref.h.
5693
5694 2019-01-22  Tom Tromey  <tom@tromey.com>
5695
5696         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5697         keyword for bcache.
5698
5699 2019-01-22  Tom Tromey  <tom@tromey.com>
5700
5701         * compile/compile-cplus-types.c: Remove a comment by #include.
5702
5703 2019-01-22  Tom Tromey  <tom@tromey.com>
5704
5705         * compile/gcc-c-plugin.h: Include compile-internal.h.
5706
5707 2019-01-22  Tom Tromey  <tom@tromey.com>
5708
5709         * stabsread.c (EXTERN): Do not define.
5710         (symnum, next_symbol_text_func, processing_gcc_compilation)
5711         (within_function, global_sym_chain, global_stabs)
5712         (previous_stab_code, this_object_header_files)
5713         (n_this_object_header_files)
5714         (n_allocated_this_object_header_files): Define.
5715         * stabsread.h (EXTERN): Never define.  Use "extern".
5716
5717 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5718
5719         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5720         history_value.
5721
5722 2019-01-21  Tom Tromey  <tom@tromey.com>
5723
5724         * ui-out.c: Fix includes.
5725         * tui/tui-source.c: Fix includes.
5726         * target.c: Fix includes.
5727         * remote.c: Fix includes.
5728         * regcache.c: Fix includes.
5729         * python/py-block.c: Fix includes.
5730         * printcmd.c: Fix includes.
5731         * or1k-tdep.c: Fix includes.
5732         * mi/mi-main.c: Fix includes.
5733         * m32r-tdep.c: Fix includes.
5734         * csky-tdep.c: Fix includes.
5735         * compile/compile-cplus-types.c: Fix includes.
5736         * cli/cli-interp.c: Fix includes.
5737
5738 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5739
5740         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5741         for padding.
5742
5743 2019-01-16  Tom Tromey  <tom@tromey.com>
5744
5745         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5746         earlier.
5747         (struct objfile) <msymbols_range>: Move from top level.
5748         <msymbols>: New method.
5749         (class objfile_msymbols): Remove.
5750         * symtab.c (default_collect_symbol_completion_matches_break_on):
5751         Update.
5752         * symmisc.c (dump_msymbols): Update.
5753         * stabsread.c (scan_file_globals): Update.
5754         * objc-lang.c (info_selectors_command, info_classes_command)
5755         (find_methods): Update.
5756         * minsyms.c (find_solib_trampoline_target): Update.
5757         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5758         * coffread.c (coff_symfile_read): Update.
5759         * ada-lang.c (ada_lookup_simple_minsym)
5760         (ada_collect_symbol_completion_matches): Update.
5761
5762 2019-01-16  Tom Tromey  <tom@tromey.com>
5763
5764         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5765         type.  Remove no-argument constructor.
5766         <iterator::operator++>: Simplify.
5767         <begin>: Update.
5768         <end>: Use minimal_symbol_count.
5769
5770 2019-01-16  Tom Tromey  <tom@tromey.com>
5771
5772         * objfiles.h (struct objfile) <psymtabs>: New method.
5773         (class objfile_psymtabs): Remove.
5774         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5775         typedef.
5776         <range>: New method.
5777         (require_partial_symbols): Change return type.
5778         * psymtab.c (require_partial_symbols)
5779         (psym_expand_symtabs_matching): Update.
5780         * mdebugread.c (parse_partial_symbols): Update.
5781         * dbxread.c (dbx_end_psymtab): Update.
5782
5783 2019-01-15  Tom Tromey  <tom@tromey.com>
5784
5785         * symtab.c (lookup_objfile_from_block)
5786         (lookup_symbol_in_objfile_symtabs)
5787         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5788         (find_line_symtab, info_sources_command)
5789         (default_collect_symbol_completion_matches_break_on)
5790         (make_source_files_completion_list): Update.
5791         * symmisc.c (print_objfile_statistics, dump_objfile)
5792         (maintenance_print_symbols, maintenance_info_symtabs)
5793         (maintenance_check_symtabs, maintenance_info_line_tables):
5794         Update.
5795         * source.c (select_source_symtab)
5796         (forget_cached_source_info_for_objfile): Update.
5797         * objfiles.h (class objfile_compunits): Remove.
5798         (struct objfile) <compunits_range>: New typedef.
5799         (compunits): New method.
5800         * objfiles.c (objfile_relocate1): Update.
5801         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5802         * maint.c (count_symtabs_and_blocks): Update.
5803         * linespec.c (iterate_over_all_matching_symtabs): Update.
5804         * cp-support.c (add_symbol_overload_list_qualified): Update.
5805         * coffread.c (coff_symtab_read): Update.
5806         * ada-lang.c (add_nonlocal_symbols)
5807         (ada_collect_symbol_completion_matches)
5808         (ada_add_global_exceptions): Update.
5809
5810 2019-01-15  Tom Tromey  <tom@tromey.com>
5811
5812         * progspace.h (program_space) <objfiles_safe_range>: New
5813         typedef.
5814         <objfiles_safe>: New method.
5815         * objfiles.h (class all_objfiles_safe): Remove.
5816         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5817         * jit.c (jit_inferior_exit_hook): Update.
5818
5819 2019-01-17  Tom Tromey  <tom@tromey.com>
5820
5821         * progspace.h (program_space) <objfiles_range>: New typedef.
5822         <objfiles>: New method.
5823         <objfiles_head>: Rename from objfiles.
5824         (object_files): Update.
5825         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5826         * guile/scm-pretty-print.c
5827         (ppscm_find_pretty_printer_from_objfiles): Update.
5828         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5829         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5830         Update.
5831         * python/py-progspace.c (pspy_get_objfiles): Update.
5832         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5833         Update.
5834         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5835         (objfpy_lookup_objfile_by_build_id): Update.
5836         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5837         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5838         Update.
5839         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5840         (expand_symtab_containing_pc, lookup_objfile_from_block)
5841         (lookup_static_symbol, basic_lookup_transparent_type)
5842         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5843         (find_line_symtab, info_sources_command)
5844         (default_collect_symbol_completion_matches_break_on)
5845         (make_source_files_completion_list, find_main_name): Update.
5846         * symmisc.c (print_symbol_bcache_statistics)
5847         (print_objfile_statistics, maintenance_print_symbols)
5848         (maintenance_print_msymbols, maintenance_print_objfiles)
5849         (maintenance_info_symtabs, maintenance_check_symtabs)
5850         (maintenance_expand_symtabs, maintenance_info_line_tables):
5851         Update.
5852         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5853         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5854         (map_overlay_command, unmap_overlay_command)
5855         (simple_overlay_update, expand_symtabs_matching)
5856         (map_symbol_filenames): Update.
5857         * symfile-debug.c (set_debug_symfile): Update.
5858         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5859         Update.
5860         * source.c (select_source_symtab, forget_cached_source_info):
5861         Update.
5862         * solib.c (solib_read_symbols): Update.
5863         * solib-spu.c (append_ocl_sos): Update.
5864         * psymtab.c (maintenance_print_psymbols)
5865         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5866         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5867         * printcmd.c (info_symbol_command): Update.
5868         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5869         Update.
5870         * objfiles.h (class all_objfiles): Remove.
5871         * objfiles.c (have_partial_symbols, have_full_symbols)
5872         (have_minimal_symbols, qsort_cmp, update_section_map)
5873         (shared_objfile_contains_address_p)
5874         (default_iterate_over_objfiles_in_search_order): Update.
5875         * objc-lang.c (info_selectors_command, info_classes_command)
5876         (find_methods): Update.
5877         * minsyms.c (find_solib_trampoline_target): Update.
5878         * maint.c (maintenance_info_sections)
5879         (maintenance_translate_address, count_symtabs_and_blocks):
5880         Update.
5881         * main.c (captured_main_1): Update.
5882         * linux-thread-db.c (try_thread_db_load_from_pdir)
5883         (has_libpthread): Update.
5884         * linespec.c (iterate_over_all_matching_symtabs)
5885         (search_minsyms_for_name): Update.
5886         * jit.c (jit_find_objf_with_entry_addr): Update.
5887         * hppa-tdep.c (find_unwind_entry)
5888         (hppa_lookup_stub_minimal_symbol): Update.
5889         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5890         Update.
5891         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5892         (elf_gnu_ifunc_resolve_by_got): Update.
5893         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5894         * dwarf-index-write.c (save_gdb_index_command): Update.
5895         * cp-support.c (add_symbol_overload_list_qualified): Update.
5896         * breakpoint.c (create_overlay_event_breakpoint)
5897         (create_longjmp_master_breakpoint)
5898         (create_std_terminate_master_breakpoint)
5899         (create_exception_master_breakpoint): Update.
5900         * blockframe.c (find_pc_partial_function): Update.
5901         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5902         (ada_collect_symbol_completion_matches)
5903         (ada_add_global_exceptions): Update.
5904
5905 2019-01-17  Tom Tromey  <tom@tromey.com>
5906
5907         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5908         declare VEC.
5909         (solib_target_parse_libraries): Change return type.
5910         (library_list_start_segment, library_list_start_section)
5911         (library_list_end_library, library_list_start_library); Update.
5912         (solib_target_free_library_list): Remove.
5913         (solib_target_parse_libraries): Remove cleanup.  Change return
5914         type.
5915         (solib_target_current_sos): Update.
5916
5917 2019-01-17  Tom Tromey  <tromey@bapiya>
5918
5919         * valprint.c: Replace "the the" with "the".
5920         * symtab.c: Replace "the the" with "the".
5921         * solib.c: Replace "the the" with "the".
5922         * solib-dsbt.c: Replace "the the" with "the".
5923         * linespec.c: Replace "the the" with "the".
5924         * dwarf2loc.h: Replace "the the" with "the".
5925         * amd64-windows-tdep.c: Replace "the the" with "the".
5926         * aarch64-tdep.c: Replace "the the" with "the".
5927
5928 2019-01-16  Keith Seitz  <keiths@redhat.com>
5929
5930         PR gdb/23773
5931         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5932         <builder>: Rename to ..
5933         <m_builder>: ... this and make private.
5934         (dwarf2_cu::get_builder): New method.  Change all users of
5935         `builder' to use this method.
5936         (dwarf2_start_symtab): Move to ...
5937         (dwarf2_cu::start_symtab): ... here.  Update all callers
5938         (setup_type_unit_groups): Move to ...
5939         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5940         callers.
5941         (dwarf2_cu::reset_builder): New method.
5942         (process_full_compunit, process_full_type_unit): Use
5943         dwarf2_cu::reset_builder.
5944         (follow_die_offset): Record the ancestor CU if it is different
5945         from the followed DIE's CU.
5946         (follow_die_sig_1): Likewise.
5947
5948 2019-01-15  Tom Tromey  <tom@tromey.com>
5949
5950         * remote.c (class remote_state) <buf>: Now a char_vector.
5951         <buf_size>: Remove.
5952         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5953         parameter.
5954         (remote_target::getpkt_or_notif_sane_1)
5955         (remote_target::getpkt_sane)
5956         (remote_target::getpkt_or_notif_sane): Likewise.
5957         (class remote_target) <putpkt>: New overload.
5958         (remote_target::read_frame): Change type of "buf_p".  Remove
5959         sizeof_p parameter.
5960         (packet_ok): New overload.
5961         (packet_check_result): New overload.
5962         Update all uses.
5963
5964 2019-01-14  Tom Tromey  <tom@tromey.com>
5965
5966         * remote-notif.c (handle_notification, remote_notif_ack)
5967         (remote_notif_parse): Make "buf" const.
5968         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5969         const.
5970         (remote_notif_parse, remote_notif_ack, handle_notification):
5971         Likewise.
5972         * remote.c (remote_notif_stop_parse): Make "buf" const.
5973         (remote_target::remote_parse_stop_reply): Make "buf" const.
5974         (remote_notif_stop_ack): Make "buf" const.
5975
5976 2019-01-14  Tom Tromey  <tom@tromey.com>
5977
5978         * remote.c (remote_console_output): Make parameter const.
5979
5980 2019-01-14  Tom Tromey  <tom@tromey.com>
5981
5982         * target-debug.h (target_debug_print_signals): Constify.
5983         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5984         * procfs.c (procfs_target::pass_signals): Update.
5985         * linux-nat.c (linux_nat_target::pass_signals): Update.
5986         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5987         * target-delegates.c: Rebuild.
5988         * remote.c (remote_target::program_signals): Update.
5989         (remote_target::pass_signals): Update.
5990         * target.c (target_pass_signals): Constify argument.
5991         (target_program_signals): Likewise.
5992         * target.h (struct target_ops) <pass_signals, program_signals>:
5993         Constify argument.
5994         (target_pass_signals, target_program_signals): Constify argument.
5995
5996 2019-01-14  Tom Tromey  <tom@tromey.com>
5997
5998         PR tui/28819:
5999         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
6000
6001 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6002
6003         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
6004         field.
6005         * rs6000-tdep.c: Include reggroups.h.
6006         (IS_V_ALIAS_PSEUDOREG): Define.
6007         (rs6000_register_name): Return names for the "vX" aliases.
6008         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
6009         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
6010         aliases.  Call default_register_reggroup_p for all other
6011         pseudo-registers.
6012         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
6013         New functions.
6014         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
6015         Handle "vX" aliases.
6016         (v_alias_pseudo_register_collect): New function.
6017         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
6018         (rs6000_gdbarch_init): Initialize "vX" aliases as
6019         pseudo-registers.  Restore registration of
6020         rs6000_pseudo_register_reggroup_p with
6021         set_tdesc_pseudo_register_reggroup_p.
6022
6023 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
6024
6025         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
6026         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
6027         set_gdbarch_num_pseudo_regs.
6028
6029 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6030
6031         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
6032         Remove arg prefixname, add do_set and do_show.
6033         Add member functions set_list and show_list.
6034         * cli/cli-style.c (class cli_style_option): Update accordingly.
6035         (style_set_list): Move to file scope.
6036         (style_show_list): Likewise.
6037         (set_style): Call help_list.
6038         (show_style): Call cmd_show_list.
6039         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
6040         Update to use the new macro.
6041
6042 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
6043
6044         * ada-lang.c (_initialize_ada_language): Expand the help text
6045         for the "catch exception" command.
6046
6047 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6048
6049         * symtab.c (matching_obj_sections): Initialize obj,
6050         declare it closer to its usage.
6051
6052 2019-01-10  Tom Tromey  <tom@tromey.com>
6053
6054         * thread-iter.h (inf_threads_iterator): Use next_iterator.
6055         (basic_inf_threads_range): Remove.
6056         (inf_threads_range, inf_non_exited_threads_range)
6057         (safe_inf_threads_range): Use next_adapter.
6058
6059 2019-01-10  Keith Seitz  <keiths@redhat.com>
6060
6061         PR gdb/23712
6062         PR symtab/23010
6063         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
6064         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
6065
6066 2019-01-10  Keith Seitz  <keiths@redhat.com>
6067
6068         PR gdb/23712
6069         PR symtab/23010
6070         * dictionary.c (pending_to_vector): Remove.
6071         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6072         Remove _1 suffix, replacing functions of the same name.  Update
6073         all callers.
6074         (dict_create_hashed, dict_create_hashed_expandable)
6075         (dict_create_linear, dict_create_linear_expandable, dict_free)
6076         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
6077         Make functions static.
6078
6079 2019-01-10  Keith Seitz  <keiths@redhat.com>
6080
6081         PR gdb/23712
6082         PR symtab/23010
6083         * dictionary.h (struct dictionary): Replace declaration with
6084         multidictionary.
6085         (dict_create_hashed, dict_create_hashed_expandable)
6086         (dict_create_linear, dict_create_linear_expandable)
6087         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
6088         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
6089         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
6090         taking multidictionary argument.
6091         [ALL_DICT_SYMBOLS]: Update for multidictionary.
6092         * block.h (struct block) <dict>: Change to multidictionary
6093         and rename `multidict'.
6094         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
6095         symmisc.c: Update all dictionary references to multidictionary.
6096
6097 2019-01-10  Keith Seitz  <keiths@redhat.com>
6098
6099         PR gdb/23712
6100         PR symtab/23010
6101         * dictionary.c: Include unordered_map.
6102         (pending_to_vector): New function.
6103         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6104         Rewrite the non-"_1" functions to take vector instead
6105         of linked list.
6106         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
6107         "new" _1 versions of the same name.
6108         (multidictionary): Define.
6109         (std::hash<enum language): New definition.
6110         (collate_pending_symbols_by_language, mdict_create_hashed)
6111         (mdict_create_hashed_expandable, mdict_create_linear)
6112         (mdict_create_linear_expandable, mdict_free)
6113         (find_language_dictionary, create_new_language_dictionary)
6114         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
6115         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
6116         (mdict_size, mdict_empty): New functions.
6117         * dictionary.h (mdict_iterator): Define.
6118
6119 2019-01-10  Pedro Alves  <palves@redhat.com>
6120
6121         * breakpoint.c (read_uploaded_action)
6122         (create_tracepoint_from_upload): Adjust to use
6123         gdb::unique_xmalloc_ptr.
6124         * ctf.c (ctf_write_uploaded_tp):
6125         (SET_ARRAY_FIELD): Use emplace_back.
6126         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
6127         * tracefile-tfile.c (tfile_write_uploaded_tp):
6128         * tracepoint.c (parse_tracepoint_definition): Adjust to use
6129         gdb::unique_xmalloc_ptr.
6130         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
6131         at_string, cond_string, cmd_strings>: Replace char pointers
6132         with gdb::unique_xmalloc_ptr.
6133
6134 2019-01-10  Pedro Alves  <palves@redhat.com>
6135
6136         * solib-target.c (library_list_start_library): Don't xstrdup name.
6137
6138 2019-01-10  Pedro Alves  <palves@redhat.com>
6139
6140         * mdebugread.c (parse_partial_symbols): Use
6141         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
6142
6143 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6144
6145         * linux-fork.c (scoped_switch_fork_info)
6146         <~scoped_switch_fork_info>: Fix incorrect variable name.
6147
6148 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6149
6150         * linux-fork.c (scoped_switch_fork_info)
6151         <scoped_switch_fork_info>: Make explicit.
6152         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
6153
6154 2019-01-10  Tom Tromey  <tom@tromey.com>
6155
6156         * objfiles.h (objfile::reset_psymtabs): Update.
6157         * objfiles.c (objfile::objfile): Update.
6158         * psymtab.h (psymtab_storage::obstack): Update.
6159         (psymtab_storage::m_obstack): Use gdb::optional.
6160         (class psymtab_storage): Update comment.  Remove objfile
6161         parameter.
6162         * psymtab.c (psymtab_storage::psymtab_storage): Update.
6163
6164 2019-01-10  Tom Tromey  <tom@tromey.com>
6165
6166         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
6167         <free_psymtabs>: Now private.
6168         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
6169         (allocate_psymtab): Use new method.
6170
6171 2019-01-10  Tom Tromey  <tom@tromey.com>
6172
6173         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
6174         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
6175         * mdebugread.c (parse_partial_symbols): Use
6176         allocate_dependencies.
6177         * dwarf2read.c (dwarf2_create_include_psymtab): Use
6178         allocate_dependencies.
6179         (process_psymtab_comp_unit_reader)
6180         (build_type_psymtab_dependencies): Likewise.
6181         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
6182
6183 2019-01-10  Tom Tromey  <tom@tromey.com>
6184
6185         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
6186         PSYMBOL_SET_LANGUAGE.
6187         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
6188
6189 2019-01-10  Tom Tromey  <tom@tromey.com>
6190
6191         * psymtab.h (psymtab_storage::obstack): New method.
6192         <m_obstack>: Rename from obstack; now private.
6193         * psymtab.c (psymtab_storage): Update.
6194         * dwarf2read.c (create_addrmap_from_index)
6195         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
6196         Update.
6197
6198 2019-01-10  Tom Tromey  <tom@tromey.com>
6199
6200         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
6201         * objfiles.h (objfile::reset_psymtabs): New method.
6202
6203 2019-01-10  Tom Tromey  <tom@tromey.com>
6204
6205         * symmisc.c (print_symbol_bcache_statistics): Update.
6206         (print_objfile_statistics): Update.
6207         * symfile.c (reread_symbols): Update.
6208         * psymtab.h (class psymtab_storage): New.
6209         * psymtab.c (psymtab_storage): New constructor.
6210         (~psymtab_storage): New destructor.
6211         (require_partial_symbols): Update.
6212         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
6213         (find_pc_sect_psymtab, find_pc_sect_psymbol)
6214         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
6215         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
6216         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
6217         (start_psymtab_common, end_psymtab_common)
6218         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
6219         (allocate_psymtab): Update.
6220         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
6221         Update.
6222         (dump_psymtab_addrmap, maintenance_print_psymbols)
6223         (maintenance_check_psymtabs): Update.
6224         (class objfile_psymtabs): Move to objfiles.h.
6225         * psympriv.h (discard_psymtab): Now inline.
6226         (psymtab_discarder::psymtab_discarder): Update.
6227         (psymtab_discarder::~psymtab_discarder): Update.
6228         (ALL_OBJFILE_PSYMTABS): Rewrite.
6229         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
6230         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
6231         Remove fields.
6232         <partial_symtabs>: New field.
6233         (class objfile_psymtabs): Move from psymtab.h.  Update.
6234         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
6235         psymbol_cache.
6236         (objfile::~objfile): Don't destroy psymbol_cache.
6237         * mdebugread.c (parse_partial_symbols): Update.
6238         * dwarf2read.c (create_addrmap_from_index)
6239         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
6240         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
6241         (add_partial_subprogram, dwarf2_ranges_read): Update.
6242         * dwarf-index-write.c (write_address_map)
6243         (write_one_signatured_type, recursively_write_psymbols)
6244         (class debug_names, class debug_names, write_psymtabs_to_index):
6245         Update.
6246
6247 2019-01-10  Tom Tromey  <tom@tromey.com>
6248
6249         * symtab.h (SYMBOL_SET_NAMES): Update.
6250         (symbol_set_names): Update.
6251         (MSYMBOL_SET_NAMES): Update.
6252         * symtab.c (symbol_set_names): Change argument to be an
6253         objfile_per_bfd_storage.
6254         * psymtab.c (add_psymbol_to_bcache): Update.
6255         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
6256
6257 2019-01-10  Tom Tromey  <tom@tromey.com>
6258
6259         * symtab.c (create_demangled_names_hash): Change argument to be an
6260         objfile_per_bfd_storage.
6261         (symbol_set_names): Update.
6262
6263 2019-01-10  Tom Tromey  <tom@tromey.com>
6264
6265         * xcoffread.c (xcoff_initial_scan): Unconditionally call
6266         init_psymbol_list.
6267         * psymtab.c (init_psymbol_list): Do nothing if already called.
6268         * psympriv.h (init_psymbol_list): Add comment.
6269         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
6270         init_psymbol_list.
6271         * dbxread.c (dbx_symfile_read): Unconditionally call
6272         init_psymbol_list.
6273
6274 2019-01-10  Tom Tromey  <tom@tromey.com>
6275
6276         * xcoffread.c (scan_xcoff_symtab): Update.
6277         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
6278         "where".
6279         * mdebugread.c (parse_partial_symbols)
6280         (handle_psymbol_enumerators): Update.
6281         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
6282         * dbxread.c (read_dbx_symtab): Update.
6283         * psympriv.h (psymbol_placement): New enum.
6284         (add_psymbol_to_list): Update.
6285
6286 2019-01-10  Tom Tromey  <tom@tromey.com>
6287
6288         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
6289         static_psymbols parameters.
6290         (scan_xcoff_symtab): Update.
6291         * psymtab.c (start_psymtab_common): Remove global_psymbols and
6292         static_psymbols parameters.
6293         * psympriv.h (start_psymtab_common): Update.
6294         * mdebugread.c (parse_partial_symbols): Update.
6295         * dwarf2read.c (create_partial_symtab): Update.
6296         * dbxread.c (read_dbx_symtab): Update.
6297         (start_psymtab): Remove global_psymbols and static_psymbols
6298         parameters.
6299
6300 2019-01-10  Tom Tromey  <tom@tromey.com>
6301
6302         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
6303         * psymtab.c (allocate_psymtab): Add comment.
6304         * psympriv.h (allocate_psymtab): Add comment.
6305         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
6306         initializations.
6307         * dbxread.c (dbx_end_psymtab): Remove some initializations.
6308
6309 2019-01-10  Tom Tromey  <tom@tromey.com>
6310
6311         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6312         Don't declare.
6313         * mipsread.c: Include mdebugread.h.
6314         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6315         Declare.
6316         * elfread.c: Include mdebugread.h.
6317
6318 2019-01-09  Tom Tromey  <tom@tromey.com>
6319
6320         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
6321         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
6322         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
6323         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
6324         (psym_lookup_symbol, psym_find_last_source_symtab)
6325         (psym_forget_cached_source_info, psym_print_stats)
6326         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
6327         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
6328         (psym_map_matching_symbols, psym_expand_symtabs_matching)
6329         (psym_find_compunit_symtab_by_address)
6330         (maintenance_print_psymbols, maintenance_info_psymtabs)
6331         (maintenance_check_psymtabs): Use ranged for.
6332         * psymtab.h (class objfile_psymtabs): New.
6333         (require_partial_symbols): Return objfile_psymtabs.
6334         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
6335
6336 2019-01-09  Tom Tromey  <tom@tromey.com>
6337
6338         * symfile.c (overlay_invalidate_all, find_pc_overlay)
6339         (find_pc_mapped_section, list_overlays_command)
6340         (map_overlay_command, unmap_overlay_command)
6341         (simple_overlay_update): Use all_objfiles.
6342         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
6343         * printcmd.c (info_symbol_command): Use all_objfiles.
6344         * objfiles.h (ALL_OBJSECTIONS): Remove.
6345         * maint.c (maintenance_translate_address): Use all_objfiles.
6346         * gcore.c (gcore_create_callback): Use all_objfiles.
6347         (objfile_find_memory_regions): Likewise.
6348
6349 2019-01-09  Tom Tromey  <tom@tromey.com>
6350
6351         * symtab.c (find_line_symtab, info_sources_command)
6352         (make_source_files_completion_list): Use objfile_compunits.
6353         * source.c (select_source_symtab): Use objfile_compunits.
6354         * objfiles.h (struct objfile): Update comment.
6355         (ALL_OBJFILES): Remove.
6356         (ALL_FILETABS): Remove.
6357         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
6358         objfile_compunits.
6359
6360 2019-01-09  Tom Tromey  <tom@tromey.com>
6361
6362         * symmisc.c (print_objfile_statistics, dump_objfile)
6363         (maintenance_print_symbols): Use compunit_filetabs.
6364         * source.c (forget_cached_source_info_for_objfile): Use
6365         compunit_filetabs.
6366         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
6367         (ALL_FILETABS): Use compunit_filetabs.
6368         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
6369         * coffread.c (coff_symtab_read): Use compunit_filetabs.
6370
6371 2019-01-09  Tom Tromey  <tom@tromey.com>
6372
6373         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
6374         (compunit_filetabs): New.
6375         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
6376         compunit_filetabs.
6377         (info_sources_command, make_source_files_completion_list): Remove
6378         declaration.
6379         * symmisc.c (print_objfile_statistics, dump_objfile)
6380         (maintenance_print_symbols): Remove declaration.
6381         (maintenance_info_symtabs): Use compunit_filetabs.
6382         (maintenance_info_line_tables): Likewise.
6383         * source.c (select_source_symtab): Change local variable name.
6384         (forget_cached_source_info_for_objfile): Remove declaration.
6385         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
6386         * objfiles.c (objfile_relocate1): Remove declaration.
6387         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6388         declaration.
6389         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
6390         * coffread.c (coff_symtab_read): Remove declaration.
6391         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6392         compunit_filetabs.
6393
6394 2019-01-09  Tom Tromey  <tom@tromey.com>
6395
6396         * symtab.c (lookup_objfile_from_block)
6397         (find_pc_sect_compunit_symtab, search_symbols)
6398         (default_collect_symbol_completion_matches_break_on): Use
6399         objfile_compunits.
6400         * objfiles.h (ALL_COMPUNITS): Remove.
6401         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
6402         * cp-support.c (add_symbol_overload_list_qualified): Use
6403         objfile_compunits.
6404         * ada-lang.c (ada_collect_symbol_completion_matches)
6405         (ada_add_global_exceptions): Use objfile_compunits.
6406
6407 2019-01-09  Tom Tromey  <tom@tromey.com>
6408
6409         * source.c (select_source_symtab)
6410         (forget_cached_source_info_for_objfile): Remove declaration.
6411         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6412         declaration.
6413         * maint.c (count_symtabs_and_blocks): Remove declaration.
6414         * cp-support.c (add_symbol_overload_list_qualified): Remove
6415         declaration.
6416         * coffread.c (coff_symtab_read): Remove declaration.
6417         * symtab.c (lookup_symbol_in_objfile_symtabs)
6418         (basic_lookup_transparent_type_1): Use objfile_compunits.
6419         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
6420         (info_sources_command, search_symbols)
6421         (default_collect_symbol_completion_matches_break_on)
6422         (make_source_files_completion_list): Remove declaration.
6423         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
6424         (ada_collect_symbol_completion_matches)
6425         (ada_add_global_exceptions): Remove declaration.
6426         * linespec.c (iterate_over_all_matching_symtabs): Use
6427         objfile_compunits.
6428         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
6429         (class objfile_compunits): New.
6430         (ALL_COMPUNITS): Use objfile_compunits.
6431         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
6432         (maintenance_check_symtabs, maintenance_info_line_tables): Use
6433         objfile_compunits.
6434         * objfiles.c (objfile_relocate1): Use objfile_compunits.
6435
6436 2019-01-09  Tom Tromey  <tom@tromey.com>
6437
6438         * symtab.c (search_symbols)
6439         (default_collect_symbol_completion_matches_break_on): Use
6440         objfile_msymbols.
6441         * ada-lang.c (ada_lookup_simple_minsym)
6442         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
6443         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
6444         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
6445         objfile_msymbols.
6446         * coffread.c (coff_symfile_read): Use objfile_msymbols.
6447         * symmisc.c (dump_msymbols): Use objfile_msymbols.
6448         * objc-lang.c (find_methods): Use objfile_msymbols.
6449         (info_selectors_command, info_classes_command): Likewise.
6450         * stabsread.c (scan_file_globals): Use objfile_msymbols.
6451         * objfiles.h (class objfile_msymbols): New.
6452         (ALL_OBJFILE_MSYMBOLS): Remove.
6453         (ALL_MSYMBOLS): Remove.
6454
6455 2019-01-09  Tom Tromey  <tom@tromey.com>
6456
6457         * common/next-iterator.h (next_adapter): Add Iterator template
6458         parameter.
6459         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
6460         (class all_objfiles_safe): New.
6461         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
6462         * objfiles.c (put_objfile_before): Update comment.
6463         (add_separate_debug_objfile): Likewise.
6464         (free_all_objfiles): Use all_objfiles_safe.
6465         (objfile_purge_solibs): Likewise.
6466
6467 2019-01-09  Tom Tromey  <tom@tromey.com>
6468
6469         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6470         (expand_symtab_containing_pc, lookup_static_symbol)
6471         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
6472         (find_symbol_at_address, find_line_symtab, find_main_name): Use
6473         all_objfiles.
6474         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
6475         * breakpoint.c (create_overlay_event_breakpoint)
6476         (create_longjmp_master_breakpoint)
6477         (create_std_terminate_master_breakpoint)
6478         (create_exception_master_breakpoint): Use all_objfiles.
6479         * linux-thread-db.c (try_thread_db_load_from_pdir)
6480         (has_libpthread): Use all_objfiles.
6481         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
6482         * linespec.c (iterate_over_all_matching_symtabs)
6483         (search_minsyms_for_name): Use all_objfiles.
6484         * maint.c (maintenance_info_sections): Use all_objfiles.
6485         * main.c (captured_main_1): Use all_objfiles.
6486         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
6487         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
6488         * guile/scm-pretty-print.c
6489         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
6490         * solib-spu.c (append_ocl_sos): Use all_objfiles.
6491         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
6492         (maintenance_print_msymbols): Use all_objfiles.
6493         * source.c (select_source_symtab): Use all_objfiles.
6494         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
6495         * symfile.c (remove_symbol_file_command)
6496         (expand_symtabs_matching, map_symbol_filenames): Use
6497         all_objfiles.
6498         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
6499         all_objfiles.
6500         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
6501         * objc-lang.c (find_methods): Use all_objfiles.
6502         * objfiles.c (have_partial_symbols, have_full_symbols)
6503         (have_minimal_symbols, qsort_cmp)
6504         (default_iterate_over_objfiles_in_search_order): Use
6505         all_objfiles.
6506         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
6507         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
6508         (maintenance_check_psymtabs): Use all_objfiles.
6509         (ALL_PSYMTABS): Remove.
6510         * compile/compile-object-run.c (do_module_cleanup): Use
6511         all_objfiles.
6512         * blockframe.c (find_pc_partial_function): Use all_objfiles.
6513         * cp-support.c (add_symbol_overload_list_qualified): Use
6514         all_objfiles.
6515         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6516         Use all_objfiles.
6517         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
6518         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
6519         all_objfiles.
6520         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6521         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
6522         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6523         Uses all_objfiles.
6524         * solib.c (solib_read_symbols): Use all_objfiles
6525
6526 2019-01-09  Tom Tromey  <tom@tromey.com>
6527
6528         * probe.c (parse_probes_in_pspace): Use all_objfiles.
6529         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
6530         all_objfiles.
6531         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
6532         * symmisc.c (print_symbol_bcache_statistics)
6533         (print_objfile_statistics, maintenance_print_objfiles)
6534         (maintenance_info_symtabs, maintenance_check_symtabs)
6535         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
6536         all_objfiles.
6537         * source.c (forget_cached_source_info): Use all_objfiles.
6538         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
6539         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6540         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
6541         * objfiles.c (update_section_map): Use all_objfiles.
6542         (shared_objfile_contains_address_p): Likewise.
6543         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
6544         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
6545
6546 2019-01-09  Tom Tromey  <tom@tromey.com>
6547
6548         * common/next-iterator.h: New file.
6549         * objfiles.h (class all_objfiles): New.
6550         (struct objfile_iterator): New.
6551
6552 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6553
6554         * NEWS: Move the description of the changed "frame", "select-frame",
6555          and "info frame" commands to the Changed commands section.
6556
6557 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
6558
6559         * gdbtypes.c (check_stub_method_group): Remove handling of old
6560         mangling schemes.
6561         * linespec.c (find_methods): Likewise.
6562         * stabsread.c (read_member_functions): Likewise.
6563         * valops.c (search_struct_method): Likewise.
6564         (value_struct_elt_for_reference): Likewise.
6565         * NEWS: Mention this change.
6566
6567 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6568
6569         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
6570         print_source_lines.
6571         * source.c (print_source_lines_base): Update line number check.
6572         (print_source_lines): New function.
6573         (source_lines_range::source_lines_range): New function.
6574         * source.h (class source_lines_range): New class.
6575         (print_source_lines): New declaration.
6576
6577 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6578
6579         * linespec.c (linespec_state_destructor): Free self->canonical_names.
6580
6581 2019-01-08  Tom Tromey  <tom@tromey.com>
6582             Simon Marchi  <simon.marchi@ericsson.com>
6583
6584         PR gdb/24060
6585         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
6586         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
6587         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6588         * f-exp.y (DOLLAR_VARIABLE): Likewise.
6589         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
6590         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6591
6592 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6593
6594         * source.c (select_source_symtab): Move header comment to
6595         declaration in source.h.
6596         (forget_cached_source_info_for_objfile): Likewise.
6597         (forget_cached_source_info): Likewise.
6598         (identify_source_line): Likewise.
6599         * source.h (identify_source_line): Move declaration from symtab.h
6600         and add comment from source.c
6601         (print_source_lines): Likewise.
6602         (forget_cached_source_info_for_objfile): Likewise.
6603         (forget_cached_source_info): Likewise.
6604         (select_source_symtab): Likewise.
6605         (enum print_source_lines_flag): Move definition from symtab.h.
6606         * symtab.h (identify_source_line): Move declaration to source.h.
6607         (print_source_lines): Likewise.
6608         (forget_cached_source_info_for_objfile): Likewise.
6609         (forget_cached_source_info): Likewise.
6610         (select_source_symtab): Likewise.
6611         (enum print_source_lines_flag): Move definition to source.h.
6612         * tui/tui-hooks.c: Add 'source.h' include.
6613
6614 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6615
6616         * source.c (print_source_lines_base): Handle requests to print
6617         reverse line number sequences, and guard against empty lines
6618         string.
6619
6620 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6621
6622         * source.c (print_source_lines_base): Fix skip of '\r' if next
6623         character is '\n'.
6624
6625 2019-01-06  Tom Tromey  <tom@tromey.com>
6626
6627         * c-exp.y (struct c_parse_state) <macro_original_text,
6628         expansion_obstack>: New member.
6629         (macro_original_text, expansion_obstack): Remove globals.
6630         (scan_macro_expansion, scanning_macro_expansion)
6631         (finished_macro_expansion): Update.
6632         (scan_macro_cleanup): Remove.
6633         (yylex, c_parse): Update.
6634
6635 2019-01-06  Tom Tromey  <tom@tromey.com>
6636
6637         * c-exp.y (struct c_parse_state) <strings>: New member.
6638         (operator_stoken): Update.
6639
6640 2019-01-06  Tom Tromey  <tom@tromey.com>
6641
6642         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6643         (union type_stack_elt) <typelist_val>: Now a pointer to
6644         std::vector.
6645         (type_stack_cleanup): Don't declare.
6646         (push_typelist): Update.
6647         * parse.c (pop_typelist): Return a std::vector.
6648         (push_typelist): Take a std::vector.
6649         (follow_types): Update.  Do not free args.
6650         (type_stack_cleanup): Remove.
6651         * c-exp.y (struct c_parse_state): New.
6652         (cpstate): New global.
6653         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6654         (nonempty_typelist): Update.
6655         (func_mod): Create a new vector.
6656         (c_parse): Create a c_parse_state.
6657         (check_parameter_typelist): Do not delete params.
6658         (function_method): Update.  Do not delete type_list.
6659
6660 2019-01-06  Tom Tromey  <tom@tromey.com>
6661
6662         PR gdb/28155:
6663         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6664         check_typedef.
6665         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6666         (print_return_value): Likewise.
6667
6668 2019-01-05  Tom Tromey  <tom@tromey.com>
6669
6670         * contrib/cleanup_check.py: Remove.
6671         * contrib/gcc-with-excheck: Remove.
6672         * contrib/exsummary.py: Remove.
6673         * contrib/excheck.py: Remove.
6674
6675 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6676
6677         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6678         NULL. Initialize tpprev to NULL instead of assigning it
6679         to NULL on the next statement.
6680         * windows-nat.c (windows_delete_thread): Remove check for
6681         main_thread_id before printing thread exit notifications.
6682         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6683         Remove thread ID check against main_thread_id.
6684         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6685         windows_delete_thread.
6686         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6687
6688 2019-01-04  Tom Tromey  <tom@tromey.com>
6689
6690         * compile/compile.c (_initialize_compile): Use upper case for
6691         metasyntactic variables.
6692         * symmisc.c (_initialize_symmisc): Use upper case for
6693         metasyntactic variables.
6694         * psymtab.c (_initialize_psymtab): Use upper case for
6695         metasyntactic variables.
6696         * demangle.c (demangle_command): Use upper case for metasyntactic
6697         variables.
6698         (_initialize_demangler): Likewise.
6699         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6700         variables.
6701
6702 2019-01-03  Tom Tromey  <tom@tromey.com>
6703
6704         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6705
6706 2019-01-03  Tom Tromey  <tom@tromey.com>
6707
6708         * python/py-symtab.c (salpy_str): Update.
6709         (struct salpy_sal_object) <symtab>: Now a PyObject.
6710         (salpy_dealloc): Update.
6711         (del_objfile_sal): Use gdbpy_ref.
6712
6713 2019-01-03  Tom Tromey  <tom@tromey.com>
6714
6715         * python/py-type.c (convert_field): Use new_reference.  Return
6716         gdbpy_ref.
6717         (make_fielditem): Return gdbpy_ref.
6718         (typy_fields): Update.
6719         (typy_getitem): Update.
6720         (field_name): Return gdbpy_ref.  Use new_reference.
6721         (typy_iterator_iternext): Update.
6722
6723 2019-01-03  Tom Tromey  <tom@tromey.com>
6724
6725         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6726
6727 2019-01-03  Tom Tromey  <tom@tromey.com>
6728
6729         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6730         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6731         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6732         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6733         (pspy_set_type_printers): Likewise.
6734         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6735         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6736         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6737         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6738         (objfpy_set_type_printers): Likewise.
6739
6740 2019-01-03  Tom Tromey  <tom@tromey.com>
6741
6742         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6743         (gdbpy_print_stack): Use gdbpy_err_fetch.
6744         * python/python-internal.h (class gdbpy_err_fetch): New class.
6745         (class gdbpy_enter) <m_error_type, m_error_value,
6746         m_error_traceback>: Remove.
6747         <m_error>: New member.
6748         (gdbpy_exception_to_string): Don't declare.
6749         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6750         * python/py-value.c (convert_value_from_python): Use
6751         gdbpy_err_fetch.
6752         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6753         gdbpy_exception_to_string.
6754         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6755         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6756         gdbpy_err_fetch.
6757
6758 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6759
6760         * linux-nat.c (delete_lwp_cleanup): Delete.
6761         (struct lwp_deleter): New struct.
6762         (lwp_info_up): New typedef.
6763         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6764         lwp_info_up.
6765
6766 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6767
6768         * linux-fork.c (class scoped_switch_fork_info): New class.
6769         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6770
6771 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6772
6773         * valops.c (find_overload_match): Remove use of null_cleanup, and
6774         calls to do_cleanups.
6775
6776 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6777
6778         * compile/compile-cplus-types.c
6779         (compile_cplus_instance::decl_name): Handle changes to
6780         cp_func_name.
6781         * cp-support.c (cp_func_name): Update header comment, update
6782         return type.
6783         * cp-support.h (cp_func_name): Update return type in declaration.
6784         * valops.c (find_overload_match): Move temp_func local to top
6785         level of function and change its type.  Use temp_func to hold and
6786         delete temporary string obtained from cp_func_name.
6787
6788 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6789
6790         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6791         gdb::char_vector, remove cleanup, and update uses of `msg`.
6792
6793 2019-01-03  Jim Wilson  <jimw@sifive.com>
6794
6795         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6796
6797 2019-01-02  Tom Tromey  <tom@tromey.com>
6798
6799         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6800         (tdesc_parse_xml): Remove cleanups.
6801         * target-descriptions.h (make_cleanup_free_target_description):
6802         Don't declare.
6803         (target_desc_deleter): New struct.
6804         (target_desc_up): New typedef.
6805         * target-descriptions.c (target_desc_deleter::operator()): Rename
6806         from free_target_description.
6807         (make_cleanup_free_target_description): Remove.
6808
6809 2019-01-02  Tom Tromey  <tom@tromey.com>
6810
6811         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6812         constructor, destructor.
6813         (linespec_parser): Remove typedef.
6814         (~linespec_parser): Rename from linespec_parser_delete.
6815         (linespec_lex_to_end, linespec_complete_label)
6816         (linespec_complete): Update.
6817         (decode_line_full): Remove cleanups.
6818         (decode_line_1): Update.
6819
6820 2019-01-02  Tom Tromey  <tom@tromey.com>
6821
6822         * python/python-internal.h (inferior_to_inferior_object): Change
6823         return type.
6824         * python/py-exitedevent.c (create_exited_event_object): Update.
6825         * python/py-inferior.c (inferior_to_inferior_object): Return
6826         gdbpy_ref.
6827         (python_new_inferior, python_inferior_deleted)
6828         (thread_to_thread_object, delete_thread_object)
6829         (build_inferior_list, gdbpy_selected_inferior): Update.
6830         * python/py-infthread.c (create_thread_object): Update.  Also fail
6831         if inferior_to_inferior_object fails.
6832
6833 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6834
6835         * inferior.h (class inferior) <displaced_step_state>: New field.
6836         * infrun.h (struct displaced_step_state): Move here from
6837         infrun.c.  Initialize fields, add constructor.
6838         <inf>: Remove field.
6839         <reset>: New method.
6840         * infrun.c (struct displaced_step_inferior_state): Move to
6841         infrun.h.
6842         (displaced_step_inferior_states): Remove.
6843         (get_displaced_stepping_state): Adust.
6844         (displaced_step_in_progress_any_inferior): Adjust.
6845         (displaced_step_in_progress_thread): Adjust.
6846         (displaced_step_in_progress): Adjust.
6847         (add_displaced_stepping_state): Remove.
6848         (get_displaced_step_closure_by_addr): Adjust.
6849         (remove_displaced_stepping_state): Remove.
6850         (infrun_inferior_exit): Call displaced_step_state.reset.
6851         (use_displaced_stepping): Don't check for NULL.
6852         (displaced_step_prepare_throw): Call
6853         get_displaced_stepping_state.
6854         (displaced_step_fixup): Don't check for NULL.
6855         (prepare_for_detach): Don't check for NULL.
6856
6857 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6858
6859         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6860          in case of call that did not complete.
6861
6862 2019-01-02  Andrey Utkin  <autkin@undo.io>
6863
6864         * symfile.c (find_separate_debug_file): Fix search of debug files for
6865         remote debuggee.
6866
6867 2019-01-02  Tom Tromey  <tom@tromey.com>
6868
6869         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6870         indentation.
6871         * python/py-frame.c (frapy_older): Remove cast.
6872         (frapy_newer): Likewise.
6873         * python/py-breakpoint.c (local_setattro): Remove cast.
6874         * python/py-arch.c (archpy_name): Remove local variable.
6875         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6876
6877 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6878
6879         * unittests/basic_string_view/element_access/char/empty.cc:
6880         Fix year range in copyright header.
6881
6882 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6883
6884         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6885         Delete.
6886         <operator==>: Update with for removed field.
6887         <hash>: Likewise.
6888         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6889         <isa_features>: ...this.
6890         <abi_features>: New field.
6891         (riscv_isa_flen): Update comment.
6892         (riscv_abi_xlen): New declaration.
6893         (riscv_abi_flen): New declaration.
6894         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6895         isa_features.
6896         (riscv_abi_xlen): New function.
6897         (riscv_isa_flen): Update to get answer from isa_features.
6898         (riscv_abi_flen): New function.
6899         (riscv_has_fp_abi): Update to get answer from abi_features.
6900         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6901         xlen and flen.
6902         (riscv_call_info) <xlen, flen>: Update comment.
6903         (riscv_call_arg_struct): Remove invalid assertions
6904         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6905         is removed.
6906         (riscv_gdbarch_init): Gather isa features and abi features
6907         separately, ensure both match on the gdbarch when reusing an old
6908         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6909         a target with 64-bit float hardware.
6910
6911 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6912
6913         * source.c (search_command_helper): Stop reverse search
6914         when line 1 has been searched.
6915
6916 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6917
6918         * record-full.c (record_full_base_target::close): Rewrite
6919         record_full_core_buf_list free logic.
6920
6921 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6922
6923         * break-catch-syscall.c (print_one_catch_syscall): xfree
6924         the last text.
6925
6926 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6927
6928         * top.c (print_gdb_version): Update Copyright year in version
6929         message.
6930
6931 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6932
6933         Update copyright year range in all GDB files.
6934
6935 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6936
6937         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6938
6939 For older changes see ChangeLog-2018.
6940 \f
6941 Local Variables:
6942 mode: change-log
6943 left-margin: 8
6944 fill-column: 74
6945 version-control: never
6946 coding: utf-8
6947 End:
6948