gdb/ChangeLog

   1 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
   2
   3         * ada-lang.c (ada_is_character_type): Change return type to bool.
   4         (ada_is_string_type): Likewise.
   5         * ada-lang.h (ada_is_character_type): Update declaration
   6         (ada_is_string_type): Likewise.
   7
   8 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
   9
  10         Support style in 'frame|thread apply'
  11
  12         * gdbcmd.h (execute_command_to_string): New term_out parameter.
  13         * record.c (record_start, record_stop): Update callers of
  14         execute_command_to_string with false.
  15         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
  16         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
  17         methods.
  18         (class string_file): New constructor with term_out parameter.
  19         Override methods term_out and can_emit_style_escape.  New member
  20         term_out.
  21         (class stdio_file): Override can_emit_style_escape.
  22         (class tee_file): Override term_out and can_emit_style_escape.
  23         * utils.h (can_emit_style_escape): Remove.
  24         * utils.c (can_emit_style_escape): Likewise.
  25         Update all callers of can_emit_style_escape (SOMESTREAM) to
  26         SOMESTREAM->can_emit_style_escape.
  27         * source-cache.c (source_cache::get_source_lines): Likewise.
  28         * stack.c (frame_apply_command_count): Call execute_command_to_string
  29         passing the term_out characteristic of the current gdb_stdout.
  30         * thread.c (thr_try_catch_cmd): Likewise.
  31         * top.c (execute_command_to_string): pass term_out parameter
  32         to construct the string_file for the command output.
  33         * ui-file.c (term_cli_styling): New function (most code moved
  34         from utils.c can_emit_style_escape).
  35         (string_file::string_file, string_file::can_emit_style_escape,
  36         stdio_file::can_emit_style_escape, tee_file::term_out,
  37         tee_file::can_emit_style_escape): New functions.
  38
  39 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  40
  41         * NEWS: Mention the new set|show may-call-functions.
  42         * infcall.c (may_call_functions_p): New variable.
  43         (show_may_call_functions_p): New function.
  44         (call_function_by_hand_dummy): Throws an error if not
  45         may-call-functions.
  46         (_initialize_infcall): Call add_setshow_boolean_cmd for
  47         may-call-functions.
  48
  49 2019-04-25  Keith Seitz  <keiths@redhat.com>
  50
  51         PR c++/24367
  52         * cp-support.c (inspect_type): Don't attempt substitutions
  53         of symbol with the same name.
  54
  55 2019-04-25  Tom Tromey  <tromey@adacore.com>
  56
  57         PR gdb/24475:
  58         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
  59         static.
  60
  61 2019-04-25  Tom Tromey  <tromey@adacore.com>
  62
  63         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
  64         rvalue reference.
  65         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
  66         (gdb_xml_parser::parse): Use std::move.
  67         * python/python-internal.h (gdbpy_convert_exception): Take a const
  68         reference.
  69         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
  70         std::move.
  71         * python/py-utils.c (gdbpy_convert_exception): Take a const
  72         reference.
  73         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
  74         Use std::move.
  75         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
  76         Use std::move.
  77         * mi/mi-main.c (mi_print_exception): Take a const reference.
  78         * main.c (handle_command_errors): Take a const reference.
  79         * linespec.c (parse_linespec): Use std::move.
  80         * infcall.c (run_inferior_call): Use std::move.
  81         (call_function_by_hand_dummy): Use std::move.
  82         * exec.c (try_open_exec_file): Use std::move.
  83         * exceptions.h (exception_print, exception_fprintf)
  84         (exception_print_same): Update.
  85         * exceptions.c (print_exception, exception_print)
  86         (exception_fprintf, exception_print_same): Change parameters to
  87         const reference.
  88         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
  89         * common/new-op.c: Use std::move.
  90         * common/common-exceptions.h (struct gdb_exception): Add move
  91         constructor.
  92         (struct gdb_exception_error, struct gdb_exception_quit, struct
  93         gdb_quit_bad_alloc): Change constructor to move constructor.
  94         (throw_exception): Change parameter to rvalue reference.
  95         * common/common-exceptions.c (throw_exception): Take rvalue
  96         reference.
  97         * cli/cli-interp.c (safe_execute_command): Use std::move.
  98         * breakpoint.c (insert_bp_location, location_to_sals): Use
  99         std::move.
 100
 101 2019-04-25  Tom Tromey  <tromey@adacore.com>
 102
 103         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
 104         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
 105         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
 106         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
 107         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
 108         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
 109         guile/scm-value.c: Use unpack.
 110         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
 111         gdbscm_gdb_exception.
 112         (gdbscm_throw_gdb_exception): Likewise.
 113         (struct gdbscm_gdb_exception): New.
 114         (unpack): New function.
 115         (gdbscm_wrap): Use unpack.
 116
 117 2019-04-25  Tom Tromey  <tromey@adacore.com>
 118
 119         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 120         (gdb_rl_callback_handler): Use std::move.
 121         * common/common-exceptions.h (struct gdb_exception): Add move
 122         assignment operator.
 123         (throw_exception_sjlj): Change "exception" to const reference.
 124         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
 125         (throw_exception_sjlj): Change "exception" to const reference.
 126
 127 2019-04-25  Tom Tromey  <tromey@adacore.com>
 128
 129         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
 130         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
 131         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 132         Update.
 133         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 134         Update.
 135         * mi/mi-interp.c (mi_interp::exec): Update.
 136         * linespec.c (parse_linespec): Update.
 137         * infcall.c (run_inferior_call): Update.
 138         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
 139         * guile/scm-symbol.c (gdbscm_lookup_symbol)
 140         (gdbscm_lookup_global_symbol): Update.
 141         * guile/scm-param.c (gdbscm_parameter_value): Update.
 142         * guile/scm-frame.c (gdbscm_frame_read_register)
 143         (gdbscm_frame_read_var): Update.
 144         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
 145         * exec.c (try_open_exec_file): Update.
 146         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 147         (gdb_rl_callback_handler): Update.
 148         * common/common-exceptions.h (exception_none): Don't declare.
 149         * common/common-exceptions.c (exception_none): Don't define.
 150         (struct catcher) <exception>: Update.
 151         * cli/cli-interp.c (safe_execute_command): Update.
 152         * breakpoint.c (insert_bp_location, location_to_sals): Update.
 153
 154 2019-04-25  Ali Tamur  <tamur@google.com>
 155
 156         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
 157         (read_attribute_value): Likewise.
 158         (dwarf2_read_addr_index): Update comment.
 159         (read_str_index): Add DW_FORM_strx.
 160         (dwarf2_string_attr): Likewise.
 161         (dwarf2_const_value_attr): Likewise.
 162         (dump_die_shallow): Likewise.
 163         (dwarf2_fetch_constant_bytes): Likewise.
 164         (skip_form_bytes): Likewise.
 165         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
 166
 167 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
 168
 169         PR corefiles/11608
 170         PR corefiles/18187
 171         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
 172         OFFSET.  Verify if current mapping contains an ELF header.
 173         (linux_find_memory_regions_full): Adjust call to
 174         dump_mapping_p.
 175
 176 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
 177             Kang Li <kanglictf@gmail.com>
 178
 179         PR gdb/21600
 180
 181         * dwarf2-frame.c (read_initial_length): Be consistent about using
 182         unsigned representation of length.
 183         (decode_frame_entry_1): Likewise.  Check for wraparound of
 184         end pointer as well as buffer overflow.
 185
 186 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
 187
 188         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
 189         "vq".
 190
 191 2019-04-24  Tom Tromey  <tromey@adacore.com>
 192
 193         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
 194
 195 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 196
 197         * s12z-tdep.c (s12z_unwind_pc): Delete.
 198         (s12z_unwind_sp): Delete.
 199         (s12z_gdbarch_init): Don't register deleted functions with
 200         gdbarch.
 201
 202 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 203
 204         * rl78-tdep.c (rl78_unwind_sp): Delete.
 205         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
 206
 207 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 208
 209         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
 210         (xstormy16_unwind_pc): Delete.
 211         (xstormy16_dummy_id): Delete.
 212         (xstormy16_gdbarch_init): Don't register deleted functions with
 213         gdbarch.
 214
 215 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 216
 217         * vax-tdep.c (vax_unwind_pc): Delete.
 218         (vax_gdbarch_init): Don't register deleted function with gdbarch.
 219
 220 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 221
 222         * v850-tdep.c (v850_unwind_sp): Delete.
 223         (v850_unwind_pc): Delete.
 224         (v850_dummy_id): Delete.
 225         (v850_gdbarch_init): Don't register deleted functions with
 226         gdbarch.
 227
 228 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 229
 230         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
 231         (tilegx_unwind_pc): Delete.
 232         (tilegx_unwind_dummy_id): Delete.
 233         (tilegx_gdbarch_init): Don't register deleted functions with
 234         gdbarch.
 235
 236 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 237
 238         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
 239         (tic6x_dummy_id): Delete.
 240         (tic6x_gdbarch_init): Don't register deleted functions with
 241         gdbarch.
 242
 243 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 244
 245         * sparc-tdep.c (sparc_unwind_pc): Delete.
 246         (sparc32_gdbarch_init): Don't register deleted function with
 247         gdbarch.
 248
 249 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 250
 251         * sh-tdep.c (sh_unwind_sp): Delete.
 252         (sh_unwind_pc): Delete.
 253         (sh_dummy_id): Delete.
 254         (sh_gdbarch_init): Don't register deleted functions with
 255         gdbarch.
 256
 257 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 258
 259         * score-tdep.c (score_unwind_sp): Delete.
 260         (score_unwind_pc): Delete.
 261         (score_dummy_id): Delete.
 262         (score_gdbarch_init): Don't register deleted functions with
 263         gdbarch.
 264
 265 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 266
 267         * rx-tdep.c (rx_unwind_pc): Delete.
 268         (rx_unwind_sp): Delete.
 269         (rx_dummy_id): Delete.
 270         (rx_gdbarch_init): Don't register deleted functions with
 271         gdbarch.  Update comment.
 272
 273 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 274
 275         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
 276         (rs6000_dummy_id): Delete.
 277         (rs6000_gdbarch_init): Don't register deleted functions with
 278         gdbarch.
 279
 280 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 281
 282         * or1k-tdep.c (or1k_dummy_id): Delete.
 283         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
 284
 285 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 286
 287         * nios2-tdep.c (nios2_dummy_id): Delete.
 288         (nios2_unwind_sp): Delete.
 289         (nios2_gdbarch_init): Don't register deleted functions with
 290         gdbarch.
 291
 292 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 293
 294         * nds32-tdep.c (nds32_dummy_id): Delete.
 295         (nds32_unwind_pc): Delete.
 296         (nds32_unwind_sp): Delete.
 297         (nds32_gdbarch_init): Don't register deleted functions with
 298         gdbarch.
 299
 300 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 301
 302         * msp430-tdep.c (msp430_unwind_pc): Delete.
 303         (msp430_unwind_sp): Delete.
 304         (msp430_dummy_id): Delete.
 305         (msp430_gdbarch_init): Don't register deleted functions with
 306         gdbarch.
 307
 308 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 309
 310         * moxie-tdep.c (moxie_unwind_sp): Delete.
 311         (moxie_unwind_pc): Delete.
 312         (moxie_dummy_id): Delete.
 313         (moxie_gdbarch_init): Don't register deleted functions with
 314         gdbarch.
 315
 316 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 317
 318         * mn10300-tdep.c (mn10300_dummy_id): Delete.
 319         (mn10300_unwind_pc): Delete.
 320         (mn10300_unwind_sp): Delete.
 321         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
 322         mn10300_unwind_sp.
 323         (mn10300_frame_unwind_init): Don't register deleted functions with
 324         gdbarch.
 325
 326 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 327
 328         * mep-tdep.c (mep_unwind_pc): Delete.
 329         (mep_unwind_sp): Delete.
 330         (mep_dummy_id): Delete.
 331         (mep_gdbarch_init): Don't register deleted functions with
 332         gdbarch.
 333
 334 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 335
 336         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
 337         (m68hc11_unwind_sp): Delete.
 338         (m68hc11_gdbarch_init): Don't register deleted functions with
 339         gdbarch.
 340
 341 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 342
 343         * m32r-tdep.c (m32r_unwind_sp): Delete.
 344         (m32r_unwind_pc): Delete.
 345         (m32r_dummy_id): Delete.
 346         (m32r_gdbarch_init): Don't register deleted functions with
 347         gdbarch.
 348
 349 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 350
 351         * m32c-tdep.c (m32c_unwind_pc): Delete.
 352         (m32c_unwind_sp): Delete.
 353         (m32c_dummy_id): Delete.
 354         (m32c_gdbarch_init): Don't register deleted functions with
 355         gdbarch.
 356
 357 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 358
 359         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
 360         (lm32_unwind_pc): Delete.
 361         (lm32_dummy_id): Delete.
 362         (lm32_gdbarch_init): Don't register deleted functions with
 363         gdbarch.
 364
 365 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 366
 367         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
 368         (iq2000_unwind_pc): Delete.
 369         (iq2000_dummy_id): Delete.
 370         (iq2000_gdbarch_init): Don't register deleted functions with
 371         gdbarch.
 372
 373 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 374
 375         * nds32-tdep.c (nds32_type_align): Delete.
 376         (nds32_push_dummy_call): Use type_align instead.
 377
 378 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 379
 380         * arm-tdep.c (arm_type_align): Only handle vector override case.
 381         (arm_push_dummy_call): Use type_align.
 382         (arm_gdbarch_init): Register arm_type_align gdbarch function.
 383
 384 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 385
 386         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
 387         case.
 388         (pass_on_stack): Use type_align.
 389         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
 390         function.
 391
 392 2019-04-23  Tom Tromey  <tromey@adacore.com>
 393
 394         * dwarf2read.c (line_header::file_name_at): Remove unused
 395         overload.
 396
 397 2019-04-23  Tom de Vries  <tdevries@suse.de>
 398
 399         PR gdb/24438
 400         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
 401         invocation.
 402
 403
 404 2019-03-27  Ali Tamur  <tamur@google.com>
 405
 406         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
 407         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
 408         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
 409         (dwarf_expr_context::get_addr_index): Likewise
 410         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
 411         (symbol_needs_eval_context::get_addr_index): Likewise
 412         (disassemble_dwarf_expression): Add DW_OP_addrx
 413         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
 414         (read_cutu_die_from_dwo): Update comment
 415         (skip_one_die): Add DW_FORM_addrx
 416         (read_attribute_value): Likewise
 417         (var_decode_location): Add DW_OP_addrx
 418         (dwarf2_const_value_attr): Add DW_FORM_addrx
 419         (dump_die_shallow): Likewise
 420         (dwarf2_fetch_constant_bytes): Likewise
 421         (decode_locdesc): Add DW_OP_addrx
 422         (skip_form_bytes): Add DW_FORM_addrx
 423
 424 2019-04-22  Ali Tamur  <tamur@google.com>
 425
 426         * MAINTAINERS (Write After Approval): Add self.
 427
 428 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
 429
 430         * solib-svr4.c (get_svr4_info): Add pspace parameter.
 431         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
 432         (open_symbol_file_object): Likewise.
 433         (svr4_default_sos): Add info parameter.
 434         (svr4_read_so_list): Likewise.
 435         (svr4_current_sos_direct): Adjust functions calls to pass down
 436         info.
 437         (svr4_current_sos_1): Add info parameter.
 438         (svr4_current_sos): Call get_svr4_info, pass info down to
 439         svr4_current_sos_1.
 440         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
 441         get_svr4_info.
 442         (svr4_in_dynsym_resolve_code): Pass current_program_space to
 443         get_svr4_info.
 444         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
 445         to get_svr4_info.
 446         (probes_table_remove_objfile_probes): Likewise.
 447         (register_solib_event_probe): Add info parameter.
 448         (solist_update_incremental): Pass info parameter down to
 449         svr4_read_so_list.
 450         (disable_probes_interface): Add info parameter.
 451         (svr4_handle_solib_event): Pass current_program_space to
 452         get_svr4_info.  Adjust disable_probes_interface cleanup.
 453         (svr4_create_probe_breakpoints): Add info parameter, pass it
 454         down to register_solib_event_probe.
 455         (svr4_create_solib_event_breakpoints): Add info parameter,
 456         pass it down to svr4_create_probe_breakpoints.
 457         (enable_break): Pass info down to
 458         svr4_create_solib_event_breakpoints.
 459         (svr4_solib_create_inferior_hook): Pass current_program_space to
 460         get_svr4_info.
 461         (svr4_clear_solib): Likewise.
 462
 463 2019-04-22  Pedro Alves  <palves@redhat.com>
 464
 465         * solib-svr4.c (svr4_free_objfile_observer): New.
 466         (probe_and_action::objfile): New field.
 467         (probes_table_htab_remove_objfile_probes)
 468         (probes_table_remove_objfile_probes): New functions.
 469         (register_solib_event_probe): Add 'objfile' parameter.  Store it
 470         in the new probe_and_action.  Don't store the probe in 'lookup'.
 471         (svr4_create_probe_breakpoints): Pass objfile to
 472         register_solib_event_probe.
 473         (_initialize_svr4_solib): Register a free_objfile observer.
 474
 475 2019-04-19  Tom Tromey  <tom@tromey.com>
 476
 477         * common/queue.h: Remove.
 478
 479 2019-04-19  Tom Tromey  <tom@tromey.com>
 480
 481         * event-loop.c: Don't include "common/queue.h".
 482
 483 2019-04-19  Tom Tromey  <tom@tromey.com>
 484
 485         * remote.c (remote_target): Use delete.
 486         * remote-notif.h: Include <list>, not "common/queue.h".
 487         (notif_client_p): Remove typedef.
 488         (remote_notif_state): Add constructor, destructor, initializer.
 489         <notif_queue>: Now a std::list.
 490         (remote_notif_state_xfree): Don't declare.
 491         * remote-notif.c (remote_notif_process, handle_notification)
 492         (remote_notif_state_allocate): Update.
 493         (~remote_notif_state): Rename from remote_notif_state_xfree.
 494
 495 2019-04-19  Tom Tromey  <tom@tromey.com>
 496
 497         * symfile.c (reread_symbols): Update.
 498         * objfiles.c (objfile_register_static_link)
 499         (objfile_lookup_static_link): Update
 500         (~objfile) Don't delete static_links.
 501         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
 502
 503 2019-04-19  Tom Tromey  <tom@tromey.com>
 504
 505         * type-stack.h (struct type_stack) <insert>: Constify string.
 506         * type-stack.c (type_stack::insert): Constify string.
 507         * gdbtypes.h (lookup_template_type): Update.
 508         (address_space_name_to_int): Update.
 509         * gdbtypes.c (address_space_name_to_int): Make space_identifier
 510         const.
 511         (lookup_template_type): Make name const.
 512         * c-exp.y: Update rules.
 513         (lex_one_token, classify_name, classify_inner_name)
 514         (c_print_token): Update.
 515         * p-exp.y: Update rules.
 516         (yylex): Update.
 517         * f-exp.y: Update rules.
 518         (yylex): Update.
 519         * d-exp.y: Update rules.
 520         (lex_one_token, classify_name, classify_inner_name): Update.
 521         * parse.c (write_dollar_variable, copy_name): Return std::string.
 522         * parser-defs.h (copy_name): Change return type.
 523         * m2-exp.y: Update rules.
 524         (yylex): Update.
 525         * go-exp.y (lex_one_token): Update.
 526         Update rules.
 527         (classify_unsafe_function, classify_packaged_name)
 528         (classify_name, yylex): Update.
 529
 530 2019-04-19  Sergei Trofimovich <siarheit@google.com>
 531
 532         * configure.ac: add --enable-source-highlight switch.
 533         * configure: Regenerate.
 534         * top.c (print_gdb_version): plumb --enable-source-highlight
 535         status to "show configuration".
 536
 537 2019-04-19  Tom Tromey  <tromey@adacore.com>
 538
 539         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
 540         Check ADA_TYPE_P.
 541         (empty_record, ada_template_to_fixed_record_type_1)
 542         (template_to_static_fixed_type)
 543         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
 544         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
 545         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
 546         macros.
 547
 548 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
 549
 550         PR symtab/24423:
 551         * source.c (print_source_lines_base): Advance "iter" when a
 552         control character is seen.
 553
 554 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 555
 556         * inferior.h (struct infcall_suspend_state_deleter):
 557         Catch exception in destructor to avoid crash.
 558
 559 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 560
 561         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
 562         close to the add_com "shell".
 563
 564 2019-04-18  Tom Tromey  <tromey@adacore.com>
 565
 566         * process-stratum-target.h (class process_stratum_target)
 567         <stratum>: Add "final".
 568
 569 2019-04-17  Tom Tromey  <tromey@adacore.com>
 570
 571         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
 572         against nullptr before use.
 573
 574 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
 575
 576         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
 577
 578 2019-04-17  Jim Wilson  <jimw@sifive.com>
 579             Andrew Burgess  <andrew.burgess@embecosm.com>
 580
 581         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
 582         code read might fail, assume 4-byte breakpoint in that case.
 583
 584 2019-04-15  Leszek Swirski  <leszeks@google.com>
 585
 586         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
 587         rather than a hand-rolled POD check when checking for forced MEMORY
 588         classification.
 589
 590 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 591
 592         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
 593         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
 594         function.
 595         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
 596         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
 597         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
 598         declaration.
 599
 600 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 601
 602         * aarch64-linux-nat.c
 603         (aarch64_linux_nat_target::thread_architecture): Add override.
 604         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
 605         each VQ.
 606
 607 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 608
 609         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
 610
 611 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
 612
 613         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
 614         target types of size 96-bits, add some additional comments, and
 615         check that the builtin type we found was the correct size.
 616
 617 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
 618
 619         * utils.c (prompt_for_continue): Don't restore the styling at the
 620         end, as applied_style has the wrong value.  This fixes styling in
 621         long lists of file names that are interrupted by the "Continue?"
 622         prompt.
 623
 624 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 625
 626         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
 627         * c-lang.c (c_language_defn): Likewise.
 628         (cplus_language_defn): Likewise.
 629         (asm_language_defn): Likewise.
 630         (minimal_language_defn): Likewise.
 631         * d-lang.c (d_language_defn): Likewise.
 632         * f-lang.c (f_language_defn): Likewise.
 633         * go-lang.c (go_language_defn): Likewise.
 634         * language.c (unknown_language_defn): Likewise.
 635         (auto_language_defn): Likewise.
 636         * language.h (struct language_defn): Remove la_magic field.
 637         (LANG_MAGIC): Delete.
 638         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
 639         * objc-lang.c (objc_language_defn): Likewise.
 640         * opencl-lang.c (opencl_language_defn): Likewise.
 641         * p-lang.c (pascal_language_defn): Likewise.
 642         * rust-lang.c (rust_language_defn): Likewise.
 643
 644 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 645
 646         * riscv-tdep.c (riscv_type_align): New function.
 647         (riscv_type_alignment): Delete.
 648         (riscv_arg_location): Use 'type_align'.
 649         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
 650
 651 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 652
 653         * gdbtypes.c (type_align): A struct with no non-static fields also
 654         has alignment of 1.
 655
 656 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 657
 658         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
 659         component to 0.
 660         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
 661         member.
 662         (riscv_struct_info::analyse): New implementation using new
 663         analyse_inner member function.
 664         (riscv_struct_info::field_offset): New member function.
 665         (riscv_struct_info::m_offsets): New member variable.
 666         (riscv_struct_info::analyse_inner): New private member function,
 667         takes the old implementation of riscv_struct_info::analyse but
 668         extended to track field offsets.
 669         (riscv_call_arg_struct): Update the struct folding special cases
 670         to handle cases where empty C++ structs, which are non-zero
 671         length, are found.
 672         (riscv_arg_location): Initialise the length of each location, a
 673         non-zero length now indicates the location is in use.
 674         (riscv_push_dummy_call): Allow for the first location having a
 675         non-zero offset when setting up arguments.
 676         (riscv_return_value): Likewise, but for return values.
 677
 678 2019-04-11  Tom Tromey  <tromey@adacore.com>
 679
 680         * utils.c (internal_vproblem): Make "msg" const.
 681
 682 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
 683
 684         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
 685         * trad-frame.c (trad_frame_reset_saved_regs): New function.
 686         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
 687         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
 688
 689 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
 690
 691         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
 692         function.
 693         (fill_gregset): Call amd64_linux_collect_native_gregset instead
 694         of amd64_collect_native_gregset.
 695         (amd64_linux_nat_target::store_registers): Likewise.
 696
 697 2019-04-10  Tom Tromey  <tom@tromey.com>
 698
 699         * symtab.c (lookup_global_symbol_from_objfile)
 700         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
 701         * objfiles.h (class separate_debug_iterator): New.
 702         (class separate_debug_range): New.
 703         (struct objfile) <separate_debug_objfiles>: New method.
 704         (objfile_separate_debug_iterate): Don't declare.
 705         * objfiles.c (separate_debug_iterator::operator++): Rename from
 706         objfile_separate_debug_iterate.
 707         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
 708         iterator.
 709         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
 710         iterator.
 711
 712 2019-04-10  Tom Tromey  <tom@tromey.com>
 713
 714         * symfile.c (reread_symbols): Remove old comment.
 715         * objfiles.c (free_all_objfiles): Fix a typo.
 716
 717 2019-04-10  Tom Tromey  <tom@tromey.com>
 718
 719         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
 720         * minsyms.c (lookup_minimal_symbol): Use foreach.
 721         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
 722         (lookup_minimal_symbol_solib_trampoline): Likewise.
 723         * symfile.c (reread_symbols): Use foreach.
 724
 725 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
 726             Tom Tromey  <tromey@adacore.com>
 727
 728         PR rust/24414:
 729         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
 730         (rust_lex_int_test): Change "value" to be LONGEST.
 731         (rust_lex_tests): Add test for long integer literal.
 732
 733 2019-04-09  Tom Tromey  <tromey@adacore.com>
 734
 735         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
 736         to bool.
 737         (extended_remote_target::attach): Update.
 738         (remote_target::remote_notice_new_inferior): Update.
 739         (remote_target::add_current_inferior_and_thread): Update.
 740         * inferior.c (exit_inferior_1): Use "false".
 741         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
 742
 743 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
 744
 745         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
 746         the "start" command.
 747
 748 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 749
 750         * python/py-inferior.c (infpy_thread_from_thread_handle):
 751         Adjust comments to reflect renaming of thread_from_thread_handle
 752         to thread_from_handle.  Adjust keywords.  Fix type error message.
 753         (inferior_object_methods): Add thread_from_handle.  Retain
 754         thread_from_thread_handle, but mark it as deprecated.
 755
 756 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 757
 758         * gdbthread.h (find_thread_by_handle): Revise declaration.
 759         * thread.c (find_thread_by_handle): Likewise.  Adjust
 760         implementation too.
 761         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
 762         support for buffer objects as handles.
 763
 764 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 765
 766         * python/py-infthread.c (thpy_thread_handle): New function.
 767         (thread_object_methods): Register thpy_thread_handle.
 768
 769 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 770
 771         * gdbthread.h (thread_to_thread_handle): Declare.
 772         * thread.c (gdbtypes.h): Include.
 773         (thread_to_thread_handle): New function.
 774
 775         * target.h (struct target_ops): Add thread_info_to_thread_handle.
 776         (target_thread_info_to_thread_handle): Declare.
 777         * target.c (target_thread_info_to_thread_handle): New function.
 778         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
 779         * target-delegates.c: Regenerate.
 780
 781         * linux-thread-db.c (class thread_db_target): Add method
 782         thread_info_to_thread_handle.
 783         (thread_db_target::thread_info_to_thread_handle): Define.
 784         * remote.c (class remote_target): Add new method
 785         thread_info_to_thread_handle.
 786         (remote_target::thread_info_to_thread_handle): Define.
 787
 788 2019-04-08  Pedro Alves  <palves@redhat.com>
 789
 790         * common/common-exceptions.c (throw_exception): Don't create
 791         named object to throw; throw directly.
 792         (throw_it): Likewise.  Don't initialize gdb_exception::message
 793         here, with new; pass FMT and AP to the ctor instead.
 794         * common/common-exceptions.h: Include <string>.
 795         (gdb_exception::gdb_exception(enum return_reason, enum errors,
 796         const char *, va_list)): New ctor.  Use std::make_shared.
 797         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
 798         errors)): Delete.
 799         (gdb_exception_error::gdb_exception_error(enum errors, const char
 800         *, va_list)): New.
 801         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
 802         Add assertion.
 803         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
 804         errors)): Delete.
 805         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
 806         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
 807         Add assertion.
 808
 809 2019-04-08  Tom Tromey  <tom@tromey.com>
 810
 811         * valops.c (value_rtti_indirect_type): Replace throw_exception
 812         with throw.
 813         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
 814         with throw.
 815         * thread.c (thr_try_catch_cmd): Replace throw_exception with
 816         throw.
 817         * target.c (target_translate_tls_address): Replace throw_exception
 818         with throw.
 819         * stack.c (frame_apply_command_count): Replace throw_exception
 820         with throw.
 821         * solib-spu.c (append_ocl_sos): Replace throw_exception with
 822         throw.
 823         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
 824         with throw.
 825         * rs6000-tdep.c (rs6000_frame_cache)
 826         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
 827         * remote.c: Replace throw_exception with throw.
 828         * record-full.c (record_full_message, record_full_wait_1)
 829         (record_full_restore): Replace throw_exception with throw.
 830         * record-btrace.c:
 831         (get_thread_current_frame_id, record_btrace_start_replaying)
 832         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
 833         (cmd_record_btrace_start): Replace throw_exception with throw.
 834         * parse.c (parse_exp_in_context_1): Replace throw_exception with
 835         throw.
 836         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
 837         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
 838         * linespec.c:
 839         (find_linespec_symbols): Replace throw_exception with throw.
 840         * infrun.c (displaced_step_prepare, resume): Replace
 841         throw_exception with throw.
 842         * infcmd.c (post_create_inferior): Replace throw_exception with
 843         throw.
 844         * inf-loop.c (inferior_event_handler): Replace throw_exception
 845         with throw.
 846         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
 847         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
 848         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
 849         (get_prev_frame_always, get_frame_pc_if_available)
 850         (get_frame_address_in_block_if_available, get_frame_language):
 851         Replace throw_exception with throw.
 852         * frame-unwind.c (frame_unwind_try_unwinder): Replace
 853         throw_exception with throw.
 854         * eval.c (fetch_subexp_value, evaluate_var_value)
 855         (evaluate_funcall, evaluate_subexp_standard): Replace
 856         throw_exception with throw.
 857         * dwarf2loc.c (call_site_find_chain)
 858         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
 859         Replace throw_exception with throw.
 860         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
 861         with throw.
 862         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
 863         throw.
 864         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
 865         * completer.c (complete_line_internal): Replace throw_exception
 866         with throw.
 867         * compile/compile-object-run.c (compile_object_run): Replace
 868         throw_exception with throw.
 869         * cli/cli-script.c (process_next_line): Replace throw_exception
 870         with throw.
 871         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
 872         (btrace_enable, btrace_maint_update_pt_packets): Replace
 873         throw_exception with throw.
 874         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
 875         throw_exception with throw.
 876         * break-catch-throw.c (re_set_exception_catchpoint): Replace
 877         throw_exception with throw.
 878         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
 879         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
 880         * aarch64-tdep.c (aarch64_make_prologue_cache)
 881         (aarch64_make_stub_cache): Replace throw_exception with throw.
 882
 883 2019-04-08  Tom Tromey  <tom@tromey.com>
 884
 885         * common/common-exceptions.c (throw_exception): Rename from
 886         throw_exception_cxx.  Remove old copy.  Make argument const.
 887         (throw_it): Create and throw exception objects directly.
 888         * common/common-exceptions.h (throw_exception): Make argument
 889         const.
 890         (struct gdb_exception_error): Add constructor.
 891         (struct gdb_exception_quit): Add constructor.
 892
 893 2019-04-08  Tom Tromey  <tom@tromey.com>
 894
 895         * common/common-exceptions.h (exception_rethrow): Don't declare.
 896         (TRY_SJLJ): Update comment.
 897         (TRY, CATCH, END_CATCH): Remove.
 898         * common/common-exceptions.c (exception_rethrow): Remove.
 899
 900 2019-04-08  Tom Tromey  <tom@tromey.com>
 901
 902         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
 903         Remove.
 904         (gdb_exception_error): Rename from
 905         gdb_exception_RETURN_MASK_ERROR.
 906         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
 907         (gdb_quit_bad_alloc): Update.
 908         * aarch64-tdep.c: Update.
 909         * ada-lang.c: Update.
 910         * ada-typeprint.c: Update.
 911         * ada-valprint.c: Update.
 912         * amd64-tdep.c: Update.
 913         * arch-utils.c: Update.
 914         * break-catch-throw.c: Update.
 915         * breakpoint.c: Update.
 916         * btrace.c: Update.
 917         * c-varobj.c: Update.
 918         * cli/cli-cmds.c: Update.
 919         * cli/cli-interp.c: Update.
 920         * cli/cli-script.c: Update.
 921         * common/common-exceptions.c: Update.
 922         * common/new-op.c: Update.
 923         * common/selftest.c: Update.
 924         * compile/compile-c-symbols.c: Update.
 925         * compile/compile-cplus-symbols.c: Update.
 926         * compile/compile-object-load.c: Update.
 927         * compile/compile-object-run.c: Update.
 928         * completer.c: Update.
 929         * corelow.c: Update.
 930         * cp-abi.c: Update.
 931         * cp-support.c: Update.
 932         * cp-valprint.c: Update.
 933         * darwin-nat.c: Update.
 934         * disasm-selftests.c: Update.
 935         * dtrace-probe.c: Update.
 936         * dwarf-index-cache.c: Update.
 937         * dwarf-index-write.c: Update.
 938         * dwarf2-frame-tailcall.c: Update.
 939         * dwarf2-frame.c: Update.
 940         * dwarf2loc.c: Update.
 941         * dwarf2read.c: Update.
 942         * eval.c: Update.
 943         * event-loop.c: Update.
 944         * event-top.c: Update.
 945         * exec.c: Update.
 946         * f-valprint.c: Update.
 947         * fbsd-tdep.c: Update.
 948         * frame-unwind.c: Update.
 949         * frame.c: Update.
 950         * gdbtypes.c: Update.
 951         * gnu-v3-abi.c: Update.
 952         * guile/guile-internal.h: Update.
 953         * guile/scm-block.c: Update.
 954         * guile/scm-breakpoint.c: Update.
 955         * guile/scm-cmd.c: Update.
 956         * guile/scm-disasm.c: Update.
 957         * guile/scm-frame.c: Update.
 958         * guile/scm-lazy-string.c: Update.
 959         * guile/scm-math.c: Update.
 960         * guile/scm-param.c: Update.
 961         * guile/scm-ports.c: Update.
 962         * guile/scm-pretty-print.c: Update.
 963         * guile/scm-symbol.c: Update.
 964         * guile/scm-symtab.c: Update.
 965         * guile/scm-type.c: Update.
 966         * guile/scm-value.c: Update.
 967         * i386-linux-tdep.c: Update.
 968         * i386-tdep.c: Update.
 969         * inf-loop.c: Update.
 970         * infcall.c: Update.
 971         * infcmd.c: Update.
 972         * infrun.c: Update.
 973         * jit.c: Update.
 974         * language.c: Update.
 975         * linespec.c: Update.
 976         * linux-fork.c: Update.
 977         * linux-nat.c: Update.
 978         * linux-tdep.c: Update.
 979         * linux-thread-db.c: Update.
 980         * main.c: Update.
 981         * mi/mi-cmd-break.c: Update.
 982         * mi/mi-cmd-stack.c: Update.
 983         * mi/mi-interp.c: Update.
 984         * mi/mi-main.c: Update.
 985         * objc-lang.c: Update.
 986         * p-valprint.c: Update.
 987         * parse.c: Update.
 988         * ppc-linux-tdep.c: Update.
 989         * printcmd.c: Update.
 990         * python/py-arch.c: Update.
 991         * python/py-breakpoint.c: Update.
 992         * python/py-cmd.c: Update.
 993         * python/py-finishbreakpoint.c: Update.
 994         * python/py-frame.c: Update.
 995         * python/py-framefilter.c: Update.
 996         * python/py-gdb-readline.c: Update.
 997         * python/py-inferior.c: Update.
 998         * python/py-infthread.c: Update.
 999         * python/py-lazy-string.c: Update.
1000         * python/py-linetable.c: Update.
1001         * python/py-objfile.c: Update.
1002         * python/py-param.c: Update.
1003         * python/py-prettyprint.c: Update.
1004         * python/py-progspace.c: Update.
1005         * python/py-record-btrace.c: Update.
1006         * python/py-record.c: Update.
1007         * python/py-symbol.c: Update.
1008         * python/py-type.c: Update.
1009         * python/py-unwind.c: Update.
1010         * python/py-utils.c: Update.
1011         * python/py-value.c: Update.
1012         * python/python.c: Update.
1013         * record-btrace.c: Update.
1014         * record-full.c: Update.
1015         * remote-fileio.c: Update.
1016         * remote.c: Update.
1017         * riscv-tdep.c: Update.
1018         * rs6000-aix-tdep.c: Update.
1019         * rs6000-tdep.c: Update.
1020         * rust-exp.y: Update.
1021         * rust-lang.c: Update.
1022         * s390-tdep.c: Update.
1023         * selftest-arch.c: Update.
1024         * solib-dsbt.c: Update.
1025         * solib-frv.c: Update.
1026         * solib-spu.c: Update.
1027         * solib-svr4.c: Update.
1028         * solib.c: Update.
1029         * sparc64-linux-tdep.c: Update.
1030         * stack.c: Update.
1031         * symfile-mem.c: Update.
1032         * symmisc.c: Update.
1033         * target.c: Update.
1034         * thread.c: Update.
1035         * top.c: Update.
1036         * tracefile-tfile.c: Update.
1037         * tui/tui.c: Update.
1038         * typeprint.c: Update.
1039         * unittests/cli-utils-selftests.c: Update.
1040         * unittests/parse-connection-spec-selftests.c: Update.
1041         * valops.c: Update.
1042         * valprint.c: Update.
1043         * value.c: Update.
1044         * varobj.c: Update.
1045         * windows-nat.c: Update.
1046         * x86-linux-nat.c: Update.
1047         * xml-support.c: Update.
1048
1049 2019-04-08  Tom Tromey  <tom@tromey.com>
1050
1051         * xml-support.c: Use C++ exception handling.
1052         * x86-linux-nat.c: Use C++ exception handling.
1053         * windows-nat.c: Use C++ exception handling.
1054         * varobj.c: Use C++ exception handling.
1055         * value.c: Use C++ exception handling.
1056         * valprint.c: Use C++ exception handling.
1057         * valops.c: Use C++ exception handling.
1058         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1059         handling.
1060         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1061         * typeprint.c: Use C++ exception handling.
1062         * tui/tui.c: Use C++ exception handling.
1063         * tracefile-tfile.c: Use C++ exception handling.
1064         * top.c: Use C++ exception handling.
1065         * thread.c: Use C++ exception handling.
1066         * target.c: Use C++ exception handling.
1067         * symmisc.c: Use C++ exception handling.
1068         * symfile-mem.c: Use C++ exception handling.
1069         * stack.c: Use C++ exception handling.
1070         * sparc64-linux-tdep.c: Use C++ exception handling.
1071         * solib.c: Use C++ exception handling.
1072         * solib-svr4.c: Use C++ exception handling.
1073         * solib-spu.c: Use C++ exception handling.
1074         * solib-frv.c: Use C++ exception handling.
1075         * solib-dsbt.c: Use C++ exception handling.
1076         * selftest-arch.c: Use C++ exception handling.
1077         * s390-tdep.c: Use C++ exception handling.
1078         * rust-lang.c: Use C++ exception handling.
1079         * rust-exp.y: Use C++ exception handling.
1080         * rs6000-tdep.c: Use C++ exception handling.
1081         * rs6000-aix-tdep.c: Use C++ exception handling.
1082         * riscv-tdep.c: Use C++ exception handling.
1083         * remote.c: Use C++ exception handling.
1084         * remote-fileio.c: Use C++ exception handling.
1085         * record-full.c: Use C++ exception handling.
1086         * record-btrace.c: Use C++ exception handling.
1087         * python/python.c: Use C++ exception handling.
1088         * python/py-value.c: Use C++ exception handling.
1089         * python/py-utils.c: Use C++ exception handling.
1090         * python/py-unwind.c: Use C++ exception handling.
1091         * python/py-type.c: Use C++ exception handling.
1092         * python/py-symbol.c: Use C++ exception handling.
1093         * python/py-record.c: Use C++ exception handling.
1094         * python/py-record-btrace.c: Use C++ exception handling.
1095         * python/py-progspace.c: Use C++ exception handling.
1096         * python/py-prettyprint.c: Use C++ exception handling.
1097         * python/py-param.c: Use C++ exception handling.
1098         * python/py-objfile.c: Use C++ exception handling.
1099         * python/py-linetable.c: Use C++ exception handling.
1100         * python/py-lazy-string.c: Use C++ exception handling.
1101         * python/py-infthread.c: Use C++ exception handling.
1102         * python/py-inferior.c: Use C++ exception handling.
1103         * python/py-gdb-readline.c: Use C++ exception handling.
1104         * python/py-framefilter.c: Use C++ exception handling.
1105         * python/py-frame.c: Use C++ exception handling.
1106         * python/py-finishbreakpoint.c: Use C++ exception handling.
1107         * python/py-cmd.c: Use C++ exception handling.
1108         * python/py-breakpoint.c: Use C++ exception handling.
1109         * python/py-arch.c: Use C++ exception handling.
1110         * printcmd.c: Use C++ exception handling.
1111         * ppc-linux-tdep.c: Use C++ exception handling.
1112         * parse.c: Use C++ exception handling.
1113         * p-valprint.c: Use C++ exception handling.
1114         * objc-lang.c: Use C++ exception handling.
1115         * mi/mi-main.c: Use C++ exception handling.
1116         * mi/mi-interp.c: Use C++ exception handling.
1117         * mi/mi-cmd-stack.c: Use C++ exception handling.
1118         * mi/mi-cmd-break.c: Use C++ exception handling.
1119         * main.c: Use C++ exception handling.
1120         * linux-thread-db.c: Use C++ exception handling.
1121         * linux-tdep.c: Use C++ exception handling.
1122         * linux-nat.c: Use C++ exception handling.
1123         * linux-fork.c: Use C++ exception handling.
1124         * linespec.c: Use C++ exception handling.
1125         * language.c: Use C++ exception handling.
1126         * jit.c: Use C++ exception handling.
1127         * infrun.c: Use C++ exception handling.
1128         * infcmd.c: Use C++ exception handling.
1129         * infcall.c: Use C++ exception handling.
1130         * inf-loop.c: Use C++ exception handling.
1131         * i386-tdep.c: Use C++ exception handling.
1132         * i386-linux-tdep.c: Use C++ exception handling.
1133         * guile/scm-value.c: Use C++ exception handling.
1134         * guile/scm-type.c: Use C++ exception handling.
1135         * guile/scm-symtab.c: Use C++ exception handling.
1136         * guile/scm-symbol.c: Use C++ exception handling.
1137         * guile/scm-pretty-print.c: Use C++ exception handling.
1138         * guile/scm-ports.c: Use C++ exception handling.
1139         * guile/scm-param.c: Use C++ exception handling.
1140         * guile/scm-math.c: Use C++ exception handling.
1141         * guile/scm-lazy-string.c: Use C++ exception handling.
1142         * guile/scm-frame.c: Use C++ exception handling.
1143         * guile/scm-disasm.c: Use C++ exception handling.
1144         * guile/scm-cmd.c: Use C++ exception handling.
1145         * guile/scm-breakpoint.c: Use C++ exception handling.
1146         * guile/scm-block.c: Use C++ exception handling.
1147         * guile/guile-internal.h: Use C++ exception handling.
1148         * gnu-v3-abi.c: Use C++ exception handling.
1149         * gdbtypes.c: Use C++ exception handling.
1150         * frame.c: Use C++ exception handling.
1151         * frame-unwind.c: Use C++ exception handling.
1152         * fbsd-tdep.c: Use C++ exception handling.
1153         * f-valprint.c: Use C++ exception handling.
1154         * exec.c: Use C++ exception handling.
1155         * event-top.c: Use C++ exception handling.
1156         * event-loop.c: Use C++ exception handling.
1157         * eval.c: Use C++ exception handling.
1158         * dwarf2read.c: Use C++ exception handling.
1159         * dwarf2loc.c: Use C++ exception handling.
1160         * dwarf2-frame.c: Use C++ exception handling.
1161         * dwarf2-frame-tailcall.c: Use C++ exception handling.
1162         * dwarf-index-write.c: Use C++ exception handling.
1163         * dwarf-index-cache.c: Use C++ exception handling.
1164         * dtrace-probe.c: Use C++ exception handling.
1165         * disasm-selftests.c: Use C++ exception handling.
1166         * darwin-nat.c: Use C++ exception handling.
1167         * cp-valprint.c: Use C++ exception handling.
1168         * cp-support.c: Use C++ exception handling.
1169         * cp-abi.c: Use C++ exception handling.
1170         * corelow.c: Use C++ exception handling.
1171         * completer.c: Use C++ exception handling.
1172         * compile/compile-object-run.c: Use C++ exception handling.
1173         * compile/compile-object-load.c: Use C++ exception handling.
1174         * compile/compile-cplus-symbols.c: Use C++ exception handling.
1175         * compile/compile-c-symbols.c: Use C++ exception handling.
1176         * common/selftest.c: Use C++ exception handling.
1177         * common/new-op.c: Use C++ exception handling.
1178         * cli/cli-script.c: Use C++ exception handling.
1179         * cli/cli-interp.c: Use C++ exception handling.
1180         * cli/cli-cmds.c: Use C++ exception handling.
1181         * c-varobj.c: Use C++ exception handling.
1182         * btrace.c: Use C++ exception handling.
1183         * breakpoint.c: Use C++ exception handling.
1184         * break-catch-throw.c: Use C++ exception handling.
1185         * arch-utils.c: Use C++ exception handling.
1186         * amd64-tdep.c: Use C++ exception handling.
1187         * ada-valprint.c: Use C++ exception handling.
1188         * ada-typeprint.c: Use C++ exception handling.
1189         * ada-lang.c: Use C++ exception handling.
1190         * aarch64-tdep.c: Use C++ exception handling.
1191
1192 2019-04-08  Tom Tromey  <tom@tromey.com>
1193
1194         * xml-support.c (gdb_xml_parser::parse): Update.
1195         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1196         * value.c (show_convenience): Update.
1197         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
1198         (test_parse_flags_qcs): Update.
1199         * thread.c (thr_try_catch_cmd): Update.
1200         * target.c (target_translate_tls_address): Update.
1201         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1202         (info_frame_command_core, frame_apply_command_count): Update.
1203         * rust-exp.y (rust_lex_exception_test): Update.
1204         * riscv-tdep.c (riscv_print_one_register_info): Update.
1205         * remote.c (remote_target::enable_btrace): Update.
1206         * record-btrace.c (record_btrace_enable_warn): Update.
1207         * python/py-utils.c (gdbpy_convert_exception): Update.
1208         * printcmd.c (do_one_display, print_variable_and_value): Update.
1209         * mi/mi-main.c (mi_print_exception): Update.
1210         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
1211         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1212         * linux-nat.c (linux_nat_target::attach): Update.
1213         * linux-fork.c (class scoped_switch_fork_info): Update.
1214         * infrun.c (displaced_step_prepare): Update.
1215         * infcall.c (call_function_by_hand_dummy): Update.
1216         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
1217         * gnu-v3-abi.c (print_one_vtable): Update.
1218         * frame.c (get_prev_frame_always): Update.
1219         * f-valprint.c (info_common_command_for_block): Update.
1220         * exec.c (try_open_exec_file): Update.
1221         * exceptions.c (print_exception, exception_print)
1222         (exception_fprintf, exception_print_same): Update.
1223         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
1224         * dwarf-index-cache.c (index_cache::store)
1225         (index_cache::lookup_gdb_index): Update.
1226         * darwin-nat.c (maybe_cache_shell): Update.
1227         * cp-valprint.c (cp_print_value_fields): Update.
1228         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
1229         (gcc_cplus_symbol_address): Update.
1230         * compile/compile-c-symbols.c (gcc_convert_symbol)
1231         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
1232         * common/selftest.c: Update.
1233         * common/common-exceptions.h (struct gdb_exception) <message>: Now
1234         a std::string.
1235         (exception_try_scope_entry, exception_try_scope_exit): Don't
1236         declare.
1237         (struct exception_try_scope): Remove.
1238         (TRY): Don't use exception_try_scope.
1239         (struct gdb_exception): Add constructor, operator=.
1240         <what>: New method.
1241         (struct gdb_exception_RETURN_MASK_ALL)
1242         (struct gdb_exception_RETURN_MASK_ERROR)
1243         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
1244         (struct gdb_quit_bad_alloc): Update.
1245         * common/common-exceptions.c (exception_none): Change
1246         initializer.
1247         (struct catcher) <state, exception>: Initialize inline.
1248         <prev>: Remove member.
1249         (current_catcher): Remove.
1250         (catchers): New global.
1251         (exceptions_state_mc_init): Simplify.
1252         (catcher_pop): Remove.
1253         (exceptions_state_mc, exceptions_state_mc_catch): Update.
1254         (try_scope_depth, exception_try_scope_entry)
1255         (exception_try_scope_exit): Remove.
1256         (throw_exception_sjlj): Update.
1257         (exception_messages, exception_messages_size): Remove.
1258         (throw_it): Simplify.
1259         (gdb_exception_sliced_copy): Remove.
1260         (throw_exception_cxx): Update.
1261         * cli/cli-script.c (script_from_file): Update.
1262         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
1263         Update.
1264         * ada-valprint.c (ada_val_print): Update.
1265         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
1266         (create_excep_cond_exprs): Update.
1267
1268 2019-04-08  Tom Tromey  <tom@tromey.com>
1269
1270         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
1271         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
1272         (TRY, CATCH, END_CATCH): Remove some definitions.
1273         * common/common-exceptions.c: Don't use GDB_XCPT.
1274         (catcher_list_size): Remove.
1275         (throw_exception, throw_it): Simplify.
1276
1277 2019-04-05  Tom Tromey  <tom@tromey.com>
1278
1279         Revert the header-sorting patch.
1280         * ft32-tdep.c: Revert.
1281         * frv-tdep.c: Revert.
1282         * frv-linux-tdep.c: Revert.
1283         * frame.c: Revert.
1284         * frame-unwind.c: Revert.
1285         * frame-base.c: Revert.
1286         * fork-child.c: Revert.
1287         * findvar.c: Revert.
1288         * findcmd.c: Revert.
1289         * filesystem.c: Revert.
1290         * filename-seen-cache.h: Revert.
1291         * filename-seen-cache.c: Revert.
1292         * fbsd-tdep.c: Revert.
1293         * fbsd-nat.h: Revert.
1294         * fbsd-nat.c: Revert.
1295         * f-valprint.c: Revert.
1296         * f-typeprint.c: Revert.
1297         * f-lang.c: Revert.
1298         * extension.h: Revert.
1299         * extension.c: Revert.
1300         * extension-priv.h: Revert.
1301         * expprint.c: Revert.
1302         * exec.h: Revert.
1303         * exec.c: Revert.
1304         * exceptions.c: Revert.
1305         * event-top.c: Revert.
1306         * event-loop.c: Revert.
1307         * eval.c: Revert.
1308         * elfread.c: Revert.
1309         * dwarf2read.h: Revert.
1310         * dwarf2read.c: Revert.
1311         * dwarf2loc.c: Revert.
1312         * dwarf2expr.h: Revert.
1313         * dwarf2expr.c: Revert.
1314         * dwarf2-frame.c: Revert.
1315         * dwarf2-frame-tailcall.c: Revert.
1316         * dwarf-index-write.h: Revert.
1317         * dwarf-index-write.c: Revert.
1318         * dwarf-index-common.c: Revert.
1319         * dwarf-index-cache.h: Revert.
1320         * dwarf-index-cache.c: Revert.
1321         * dummy-frame.c: Revert.
1322         * dtrace-probe.c: Revert.
1323         * disasm.h: Revert.
1324         * disasm.c: Revert.
1325         * disasm-selftests.c: Revert.
1326         * dictionary.c: Revert.
1327         * dicos-tdep.c: Revert.
1328         * demangle.c: Revert.
1329         * dcache.h: Revert.
1330         * dcache.c: Revert.
1331         * darwin-nat.h: Revert.
1332         * darwin-nat.c: Revert.
1333         * darwin-nat-info.c: Revert.
1334         * d-valprint.c: Revert.
1335         * d-namespace.c: Revert.
1336         * d-lang.c: Revert.
1337         * ctf.c: Revert.
1338         * csky-tdep.c: Revert.
1339         * csky-linux-tdep.c: Revert.
1340         * cris-tdep.c: Revert.
1341         * cris-linux-tdep.c: Revert.
1342         * cp-valprint.c: Revert.
1343         * cp-support.c: Revert.
1344         * cp-namespace.c: Revert.
1345         * cp-abi.c: Revert.
1346         * corelow.c: Revert.
1347         * corefile.c: Revert.
1348         * continuations.c: Revert.
1349         * completer.h: Revert.
1350         * completer.c: Revert.
1351         * complaints.c: Revert.
1352         * coffread.c: Revert.
1353         * coff-pe-read.c: Revert.
1354         * cli-out.h: Revert.
1355         * cli-out.c: Revert.
1356         * charset.c: Revert.
1357         * c-varobj.c: Revert.
1358         * c-valprint.c: Revert.
1359         * c-typeprint.c: Revert.
1360         * c-lang.c: Revert.
1361         * buildsym.c: Revert.
1362         * buildsym-legacy.c: Revert.
1363         * build-id.h: Revert.
1364         * build-id.c: Revert.
1365         * btrace.c: Revert.
1366         * bsd-uthread.c: Revert.
1367         * breakpoint.h: Revert.
1368         * breakpoint.c: Revert.
1369         * break-catch-throw.c: Revert.
1370         * break-catch-syscall.c: Revert.
1371         * break-catch-sig.c: Revert.
1372         * blockframe.c: Revert.
1373         * block.c: Revert.
1374         * bfin-tdep.c: Revert.
1375         * bfin-linux-tdep.c: Revert.
1376         * bfd-target.c: Revert.
1377         * bcache.c: Revert.
1378         * ax-general.c: Revert.
1379         * ax-gdb.h: Revert.
1380         * ax-gdb.c: Revert.
1381         * avr-tdep.c: Revert.
1382         * auxv.c: Revert.
1383         * auto-load.c: Revert.
1384         * arm-wince-tdep.c: Revert.
1385         * arm-tdep.c: Revert.
1386         * arm-symbian-tdep.c: Revert.
1387         * arm-pikeos-tdep.c: Revert.
1388         * arm-obsd-tdep.c: Revert.
1389         * arm-nbsd-tdep.c: Revert.
1390         * arm-nbsd-nat.c: Revert.
1391         * arm-linux-tdep.c: Revert.
1392         * arm-linux-nat.c: Revert.
1393         * arm-fbsd-tdep.c: Revert.
1394         * arm-fbsd-nat.c: Revert.
1395         * arm-bsd-tdep.c: Revert.
1396         * arch-utils.c: Revert.
1397         * arc-tdep.c: Revert.
1398         * arc-newlib-tdep.c: Revert.
1399         * annotate.h: Revert.
1400         * annotate.c: Revert.
1401         * amd64-windows-tdep.c: Revert.
1402         * amd64-windows-nat.c: Revert.
1403         * amd64-tdep.c: Revert.
1404         * amd64-sol2-tdep.c: Revert.
1405         * amd64-obsd-tdep.c: Revert.
1406         * amd64-obsd-nat.c: Revert.
1407         * amd64-nbsd-tdep.c: Revert.
1408         * amd64-nbsd-nat.c: Revert.
1409         * amd64-nat.c: Revert.
1410         * amd64-linux-tdep.c: Revert.
1411         * amd64-linux-nat.c: Revert.
1412         * amd64-fbsd-tdep.c: Revert.
1413         * amd64-fbsd-nat.c: Revert.
1414         * amd64-dicos-tdep.c: Revert.
1415         * amd64-darwin-tdep.c: Revert.
1416         * amd64-bsd-nat.c: Revert.
1417         * alpha-tdep.c: Revert.
1418         * alpha-obsd-tdep.c: Revert.
1419         * alpha-nbsd-tdep.c: Revert.
1420         * alpha-mdebug-tdep.c: Revert.
1421         * alpha-linux-tdep.c: Revert.
1422         * alpha-linux-nat.c: Revert.
1423         * alpha-bsd-tdep.c: Revert.
1424         * alpha-bsd-nat.c: Revert.
1425         * aix-thread.c: Revert.
1426         * agent.c: Revert.
1427         * addrmap.c: Revert.
1428         * ada-varobj.c: Revert.
1429         * ada-valprint.c: Revert.
1430         * ada-typeprint.c: Revert.
1431         * ada-tasks.c: Revert.
1432         * ada-lang.c: Revert.
1433         * aarch64-tdep.c: Revert.
1434         * aarch64-ravenscar-thread.c: Revert.
1435         * aarch64-newlib-tdep.c: Revert.
1436         * aarch64-linux-tdep.c: Revert.
1437         * aarch64-linux-nat.c: Revert.
1438         * aarch64-fbsd-tdep.c: Revert.
1439         * aarch64-fbsd-nat.c: Revert.
1440         * aarch32-linux-nat.c: Revert.
1441
1442 2019-04-05  Tom Tromey  <tom@tromey.com>
1443
1444         * ft32-tdep.c: Sort headers.
1445         * frv-tdep.c: Sort headers.
1446         * frv-linux-tdep.c: Sort headers.
1447         * frame.c: Sort headers.
1448         * frame-unwind.c: Sort headers.
1449         * frame-base.c: Sort headers.
1450         * fork-child.c: Sort headers.
1451         * findvar.c: Sort headers.
1452         * findcmd.c: Sort headers.
1453         * filesystem.c: Sort headers.
1454         * filename-seen-cache.h: Sort headers.
1455         * filename-seen-cache.c: Sort headers.
1456         * fbsd-tdep.c: Sort headers.
1457         * fbsd-nat.h: Sort headers.
1458         * fbsd-nat.c: Sort headers.
1459         * f-valprint.c: Sort headers.
1460         * f-typeprint.c: Sort headers.
1461         * f-lang.c: Sort headers.
1462         * extension.h: Sort headers.
1463         * extension.c: Sort headers.
1464         * extension-priv.h: Sort headers.
1465         * expprint.c: Sort headers.
1466         * exec.h: Sort headers.
1467         * exec.c: Sort headers.
1468         * exceptions.c: Sort headers.
1469         * event-top.c: Sort headers.
1470         * event-loop.c: Sort headers.
1471         * eval.c: Sort headers.
1472         * elfread.c: Sort headers.
1473         * dwarf2read.h: Sort headers.
1474         * dwarf2read.c: Sort headers.
1475         * dwarf2loc.c: Sort headers.
1476         * dwarf2expr.h: Sort headers.
1477         * dwarf2expr.c: Sort headers.
1478         * dwarf2-frame.c: Sort headers.
1479         * dwarf2-frame-tailcall.c: Sort headers.
1480         * dwarf-index-write.h: Sort headers.
1481         * dwarf-index-write.c: Sort headers.
1482         * dwarf-index-common.c: Sort headers.
1483         * dwarf-index-cache.h: Sort headers.
1484         * dwarf-index-cache.c: Sort headers.
1485         * dummy-frame.c: Sort headers.
1486         * dtrace-probe.c: Sort headers.
1487         * disasm.h: Sort headers.
1488         * disasm.c: Sort headers.
1489         * disasm-selftests.c: Sort headers.
1490         * dictionary.c: Sort headers.
1491         * dicos-tdep.c: Sort headers.
1492         * demangle.c: Sort headers.
1493         * dcache.h: Sort headers.
1494         * dcache.c: Sort headers.
1495         * darwin-nat.h: Sort headers.
1496         * darwin-nat.c: Sort headers.
1497         * darwin-nat-info.c: Sort headers.
1498         * d-valprint.c: Sort headers.
1499         * d-namespace.c: Sort headers.
1500         * d-lang.c: Sort headers.
1501         * ctf.c: Sort headers.
1502         * csky-tdep.c: Sort headers.
1503         * csky-linux-tdep.c: Sort headers.
1504         * cris-tdep.c: Sort headers.
1505         * cris-linux-tdep.c: Sort headers.
1506         * cp-valprint.c: Sort headers.
1507         * cp-support.c: Sort headers.
1508         * cp-namespace.c: Sort headers.
1509         * cp-abi.c: Sort headers.
1510         * corelow.c: Sort headers.
1511         * corefile.c: Sort headers.
1512         * continuations.c: Sort headers.
1513         * completer.h: Sort headers.
1514         * completer.c: Sort headers.
1515         * complaints.c: Sort headers.
1516         * coffread.c: Sort headers.
1517         * coff-pe-read.c: Sort headers.
1518         * cli-out.h: Sort headers.
1519         * cli-out.c: Sort headers.
1520         * charset.c: Sort headers.
1521         * c-varobj.c: Sort headers.
1522         * c-valprint.c: Sort headers.
1523         * c-typeprint.c: Sort headers.
1524         * c-lang.c: Sort headers.
1525         * buildsym.c: Sort headers.
1526         * buildsym-legacy.c: Sort headers.
1527         * build-id.h: Sort headers.
1528         * build-id.c: Sort headers.
1529         * btrace.c: Sort headers.
1530         * bsd-uthread.c: Sort headers.
1531         * breakpoint.h: Sort headers.
1532         * breakpoint.c: Sort headers.
1533         * break-catch-throw.c: Sort headers.
1534         * break-catch-syscall.c: Sort headers.
1535         * break-catch-sig.c: Sort headers.
1536         * blockframe.c: Sort headers.
1537         * block.c: Sort headers.
1538         * bfin-tdep.c: Sort headers.
1539         * bfin-linux-tdep.c: Sort headers.
1540         * bfd-target.c: Sort headers.
1541         * bcache.c: Sort headers.
1542         * ax-general.c: Sort headers.
1543         * ax-gdb.h: Sort headers.
1544         * ax-gdb.c: Sort headers.
1545         * avr-tdep.c: Sort headers.
1546         * auxv.c: Sort headers.
1547         * auto-load.c: Sort headers.
1548         * arm-wince-tdep.c: Sort headers.
1549         * arm-tdep.c: Sort headers.
1550         * arm-symbian-tdep.c: Sort headers.
1551         * arm-pikeos-tdep.c: Sort headers.
1552         * arm-obsd-tdep.c: Sort headers.
1553         * arm-nbsd-tdep.c: Sort headers.
1554         * arm-nbsd-nat.c: Sort headers.
1555         * arm-linux-tdep.c: Sort headers.
1556         * arm-linux-nat.c: Sort headers.
1557         * arm-fbsd-tdep.c: Sort headers.
1558         * arm-fbsd-nat.c: Sort headers.
1559         * arm-bsd-tdep.c: Sort headers.
1560         * arch-utils.c: Sort headers.
1561         * arc-tdep.c: Sort headers.
1562         * arc-newlib-tdep.c: Sort headers.
1563         * annotate.h: Sort headers.
1564         * annotate.c: Sort headers.
1565         * amd64-windows-tdep.c: Sort headers.
1566         * amd64-windows-nat.c: Sort headers.
1567         * amd64-tdep.c: Sort headers.
1568         * amd64-sol2-tdep.c: Sort headers.
1569         * amd64-obsd-tdep.c: Sort headers.
1570         * amd64-obsd-nat.c: Sort headers.
1571         * amd64-nbsd-tdep.c: Sort headers.
1572         * amd64-nbsd-nat.c: Sort headers.
1573         * amd64-nat.c: Sort headers.
1574         * amd64-linux-tdep.c: Sort headers.
1575         * amd64-linux-nat.c: Sort headers.
1576         * amd64-fbsd-tdep.c: Sort headers.
1577         * amd64-fbsd-nat.c: Sort headers.
1578         * amd64-dicos-tdep.c: Sort headers.
1579         * amd64-darwin-tdep.c: Sort headers.
1580         * amd64-bsd-nat.c: Sort headers.
1581         * alpha-tdep.c: Sort headers.
1582         * alpha-obsd-tdep.c: Sort headers.
1583         * alpha-nbsd-tdep.c: Sort headers.
1584         * alpha-mdebug-tdep.c: Sort headers.
1585         * alpha-linux-tdep.c: Sort headers.
1586         * alpha-linux-nat.c: Sort headers.
1587         * alpha-bsd-tdep.c: Sort headers.
1588         * alpha-bsd-nat.c: Sort headers.
1589         * aix-thread.c: Sort headers.
1590         * agent.c: Sort headers.
1591         * addrmap.c: Sort headers.
1592         * ada-varobj.c: Sort headers.
1593         * ada-valprint.c: Sort headers.
1594         * ada-typeprint.c: Sort headers.
1595         * ada-tasks.c: Sort headers.
1596         * ada-lang.c: Sort headers.
1597         * aarch64-tdep.c: Sort headers.
1598         * aarch64-ravenscar-thread.c: Sort headers.
1599         * aarch64-newlib-tdep.c: Sort headers.
1600         * aarch64-linux-tdep.c: Sort headers.
1601         * aarch64-linux-nat.c: Sort headers.
1602         * aarch64-fbsd-tdep.c: Sort headers.
1603         * aarch64-fbsd-nat.c: Sort headers.
1604         * aarch32-linux-nat.c: Sort headers.
1605
1606 2019-04-04  Tom Tromey  <tom@tromey.com>
1607
1608         * varobj.c (varobj_create): Update.
1609         * rust-exp.y (struct rust_parser) <update_innermost_block,
1610         lookup_symbol>: New methods.
1611         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
1612         Rename.
1613         (rust_parser::rust_lookup_type)
1614         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1615         * printcmd.c (display_command, do_one_display): Update.
1616         * parser-defs.h (struct parser_state) <parser_state>: Add
1617         "tracker" parameter.
1618         (block_tracker): New member.
1619         (class innermost_block_tracker) <innermost_block_tracker>: Add
1620         "types" parameter.
1621         <reset>: Remove method.
1622         (innermost_block): Don't declare.
1623         (null_post_parser): Update.
1624         * parse.c (innermost_block): Remove global.
1625         (write_dollar_variable): Update.
1626         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
1627         Remove "tracker_types" parameter.
1628         (parse_expression): Add "tracker" parameter.
1629         (parse_expression_for_completion): Update.
1630         (null_post_parser): Add "tracker" parameter.
1631         * p-exp.y: Update rules.
1632         * m2-exp.y: Update rules.
1633         * language.h (struct language_defn) <la_post_parser>: Add
1634         "tracker" parameter.
1635         * go-exp.y: Update rules.
1636         * f-exp.y: Update rules.
1637         * expression.h (parse_expression, parse_exp_1): Add "tracker"
1638         parameter.
1639         * d-exp.y: Update rules.
1640         * c-exp.y: Update rules.
1641         * breakpoint.c (set_breakpoint_condition): Create an
1642         innermost_block_tracker.
1643         (watch_command_1): Likewise.
1644         * ada-lang.c (resolve): Add "tracker" parameter.
1645         (resolve_subexp): Likewise.
1646         * ada-exp.y (write_var_from_sym): Update.
1647
1648 2019-04-04  Tom Tromey  <tom@tromey.com>
1649
1650         * type-stack.h: New file.
1651         * type-stack.c: New file.
1652         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
1653         type-stack.h.
1654         (insert_into_type_stack, insert_type, push_type, push_type_int)
1655         (insert_type_address_space, pop_type, pop_type_int)
1656         (pop_typelist, pop_type_stack, append_type_stack)
1657         (push_type_stack, get_type_stack, push_typelist)
1658         (follow_type_instance_flags, follow_types): Don't declare.
1659         * parse.c (type_stack): Remove global.
1660         (parse_exp_in_context): Update.
1661         (insert_into_type_stack, insert_type, push_type, push_type_int)
1662         (insert_type_address_space, pop_type, pop_type_int)
1663         (pop_typelist, pop_type_stack, append_type_stack)
1664         (push_type_stack, get_type_stack, push_typelist)
1665         (follow_type_instance_flags, follow_types): Remove (moved to
1666         type-stack.c).
1667         * f-exp.y (type_stack): New global.
1668         Update rules.
1669         (push_kind_type, f_parse): Update.
1670         * d-exp.y (type_stack): New global.
1671         Update rules.
1672         (d_parse): Update.
1673         * c-exp.y (struct c_parse_state) <type_stack>: New member.
1674         Update rules.
1675         * Makefile.in (COMMON_SFILES): Add type-stack.c.
1676         (HFILES_NO_SRCDIR): Add type-stack.h.
1677
1678 2019-04-04  Tom Tromey  <tom@tromey.com>
1679
1680         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
1681         (rust_parser::convert_ast_to_expression, rust_parse)
1682         (rust_lex_test_completion, rust_lex_tests): Update.
1683         * parser-defs.h (struct expr_completion_state): New.
1684         (struct parser_state) <parser_state>: Add completion parameter.
1685         <mark_struct_expression, mark_completion_tag>: New methods.
1686         <parse_completion, m_completion_state>: New members.
1687         (prefixify_expression, null_post_parser): Update.
1688         (mark_struct_expression, mark_completion_tag): Don't declare.
1689         * parse.c (parse_completion, expout_last_struct)
1690         (expout_tag_completion_type, expout_completion_name): Remove
1691         globals.
1692         (parser_state::mark_struct_expression)
1693         (parser_state::mark_completion_tag): Now methods.
1694         (prefixify_expression): Add last_struct parameter.
1695         (prefixify_subexp): Likewise.
1696         (parse_exp_1): Update.
1697         (parse_exp_in_context): Add cstate parameter.  Update.
1698         (parse_expression_for_completion): Create an
1699         expr_completion_state.
1700         (null_post_parser): Add "completion" parameter.
1701         * p-exp.y: Update rules.
1702         (yylex): Update.
1703         * language.h (struct language_defn) <la_post_parser>: Add
1704         "completing" parameter.
1705         * go-exp.y: Update rules.
1706         (lex_one_token): Update.
1707         * expression.h (parse_completion): Don't declare.
1708         * d-exp.y: Update rules.
1709         (lex_one_token): Update rules.
1710         * c-exp.y: Update rules.
1711         (lex_one_token): Update.
1712         * ada-lang.c (resolve): Add "parse_completion" parameter.
1713         (resolve_subexp): Likewise.
1714         (ada_resolve_function): Likewise.
1715
1716 2019-04-04  Tom Tromey  <tom@tromey.com>
1717
1718         * parser-defs.h (struct parser_state) <start_arglist,
1719         end_arglist>: New methods.
1720         <arglist_len, m_funcall_chain>: New members.
1721         (arglist_len, start_arglist, end_arglist): Don't declare.
1722         * parse.c (arglist_len, funcall_chain): Remove global.
1723         (start_arglist, end_arglist): Remove functions.
1724         (parse_exp_in_context): Update.
1725         * p-exp.y: Update rules.
1726         * m2-exp.y: Update rules.
1727         * go-exp.y: Update rules.
1728         * f-exp.y: Update rules.
1729         * d-exp.y: Update rules.
1730         * c-exp.y: Update rules.
1731
1732 2019-04-04  Tom Tromey  <tom@tromey.com>
1733
1734         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
1735         lex_operator, push_back>: New methods.
1736         Update all rules.
1737         (rust_parser::lex_hex, lex_escape): Rename and update.
1738         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
1739         (rust_parser::lex_operator): Rename and update.
1740         (rust_parser::lex_number, rustyylex, rustyyerror)
1741         (rust_lex_test_init, rust_lex_test_sequence)
1742         (rust_lex_test_push_back, rust_lex_tests): Update.
1743         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
1744         parameter.
1745         <lexptr, prev_lexptr>: New members.
1746         (lexptr, prev_lexptr): Don't declare.
1747         * parse.c (lexptr, prev_lexptr): Remove globals.
1748         (parse_exp_in_context): Update.
1749         * p-exp.y (yylex, yyerror): Update.
1750         * m2-exp.y (parse_number, yylex, yyerror): Update.
1751         * go-exp.y (lex_one_token, yyerror): Update.
1752         * f-exp.y (match_string_literal, yylex, yyerror): Update.
1753         * d-exp.y (lex_one_token, yyerror): Update.
1754         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
1755         (lex_one_token, yyerror): Update.
1756         * ada-lex.l (YY_INPUT): Update.
1757         (rewind_to_char): Update.
1758         * ada-exp.y (yyerror): Update.
1759
1760 2019-04-04  Tom Tromey  <tom@tromey.com>
1761
1762         * rust-exp.y (rustyylex, rust_lex_tests): Update.
1763         * parser-defs.h (struct parser_state) <parser_state>: Add new
1764         parameter.
1765         <comma_terminates>: New member.
1766         (comma_terminates): Don't declare global.
1767         * parse.c (comma_terminates): Remove global.
1768         (parse_exp_in_context): Update.
1769         * p-exp.y (yylex): Update.
1770         * m2-exp.y (yylex): Update.
1771         * go-exp.y (lex_one_token): Update.
1772         * f-exp.y (yylex): Update.
1773         * d-exp.y (lex_one_token): Update.
1774         * c-exp.y (lex_one_token): Update.
1775         * ada-lex.l: Update.
1776
1777 2019-04-04  Tom Tromey  <tom@tromey.com>
1778
1779         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
1780         (rustyylex, rust_lex_test_init, rust_lex_test_one)
1781         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
1782         * parser-defs.h (paren_depth): Don't declare.
1783         * parse.c (paren_depth): Remove global.
1784         (parse_exp_in_context): Update.
1785         * p-exp.y (paren_depth): New global.
1786         (pascal_parse): Initialize it.
1787         * m2-exp.y (paren_depth): New global.
1788         (m2_parse): Initialize it.
1789         * go-exp.y (paren_depth): New global.
1790         (go_parse): Initialize it.
1791         * f-exp.y (paren_depth): New global.
1792         (f_parse): Initialize it.
1793         * d-exp.y (paren_depth): New global.
1794         (d_parse): Initialize it.
1795         * c-exp.y (paren_depth): New global.
1796         (c_parse): Initialize it.
1797         * ada-lex.l (paren_depth): New global.
1798         (lexer_init): Initialize it.
1799
1800 2019-04-04  Tom Tromey  <tom@tromey.com>
1801
1802         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
1803         (rust_parser::convert_ast_to_type)
1804         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1805         * parser-defs.h (struct parser_state) <parser_state>: Add
1806         parameters.  Initialize new members.
1807         <expression_context_block, expression_context_pc>: New members.
1808         * parse.c (expression_context_block, expression_context_pc):
1809         Remove globals.
1810         (parse_exp_in_context): Update.
1811         * p-exp.y: Update all rules.
1812         (yylex): Update.
1813         * m2-exp.y: Update all rules.
1814         (yylex): Update.
1815         * go-exp.y (yylex): Update.
1816         * f-exp.y (yylex): Update.
1817         * d-exp.y: Update all rules.
1818         (yylex): Update.
1819         * c-exp.y: Update all rules.
1820         (lex_one_token, classify_name, yylex, c_parse): Update.
1821         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
1822
1823 2019-04-04  Tom Tromey  <tom@tromey.com>
1824
1825         * gdbarch.h, gdbarch.c: Rebuild.
1826         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
1827         * stap-probe.h:
1828         (struct stap_parse_info): Replace "parser_state" with
1829         "expr_builder".
1830         * parser-defs.h (struct expr_builder): Rename from "parser_state".
1831         (parser_state): New class.
1832         * parse.c (expr_builder): Rename.
1833         (expr_builder::release): Rename.
1834         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
1835         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
1836         (write_exp_elt_longcst, write_exp_elt_floatcst)
1837         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
1838         (write_exp_string_vector, write_exp_bitstring)
1839         (write_exp_msymbol, mark_struct_expression)
1840         (write_dollar_variable)
1841         (insert_type_address_space, increase_expout_size): Replace
1842         "parser_state" with "expr_builder".
1843         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
1844         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
1845         "parser_state" with "expr_builder".
1846
1847 2019-04-04  Tom Tromey  <tom@tromey.com>
1848
1849         * rust-exp.y: Replace "parse_language" with method call.
1850         * p-exp.y:
1851         (yylex): Replace "parse_language" with method call.
1852         * m2-exp.y:
1853         (yylex): Replace "parse_language" with method call.
1854         * go-exp.y (classify_name): Replace "parse_language" with method
1855         call.
1856         * f-exp.y (yylex): Replace "parse_language" with method call.
1857         * d-exp.y (lex_one_token): Replace "parse_language" with method
1858         call.
1859         * c-exp.y:
1860         (lex_one_token, classify_name, yylex): Replace "parse_language"
1861         with method call.
1862         * ada-exp.y (find_primitive_type, type_char)
1863         (type_system_address): Replace "parse_language" with method call.
1864
1865 2019-04-04  Tom Tromey  <tom@tromey.com>
1866
1867         * rust-exp.y: Replace "parse_gdbarch" with method call.
1868         * parse.c (write_dollar_variable, insert_type_address_space):
1869         Replace "parse_gdbarch" with method call.
1870         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
1871         call.
1872         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
1873         call.
1874         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
1875         "parse_gdbarch" with method call.
1876         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
1877         with method call.
1878         * f-exp.y (parse_type, parse_f_type, yylex): Replace
1879         "parse_gdbarch" with method call.
1880         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
1881         "parse_gdbarch" with method call.
1882         * c-exp.y (parse_type, parse_number, classify_name): Replace
1883         "parse_gdbarch" with method call.
1884         * ada-lex.l: Replace "parse_gdbarch" with method call.
1885         * ada-exp.y (parse_type, find_primitive_type, type_char)
1886         (type_system_address): Replace "parse_gdbarch" with method call.
1887
1888 2019-04-04  Tom Tromey  <tom@tromey.com>
1889
1890         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
1891         * stap-probe.c (stap_parse_argument): Update.
1892         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
1893         initial_size parameter.
1894         * rust-exp.y (rust_lex_tests): Update.
1895         * parse.c (parser_state): Update.
1896         (parse_exp_in_context): Update.
1897         * parser-defs.h (struct parser_state) <parser_state>: Remove
1898         "initial_size" parameter.
1899
1900 2019-04-04  Tom Tromey  <tom@tromey.com>
1901
1902         * parser-defs.h (increase_expout_size): Don't declare.
1903         * parse.c (increase_expout_size): Now static.
1904
1905 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
1906
1907         * gnu-nat.c (gnu_nat_target::wait): Fix
1908         target_waitstatus_to_string call.
1909
1910 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1911
1912         * eval.c (evaluate_subexp_standard): Handle internal functions
1913         during Fortran function call handling.
1914
1915 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1916
1917         * NEWS: Mention new internal functions.
1918         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
1919         (read_base_type): Use dwarf2_init_complex_target_type.
1920         * value.c (creal_internal_fn): New function.
1921         (cimag_internal_fn): New function.
1922         (_initialize_values): Register new internal functions.
1923
1924 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1925
1926         * infrun.c (stop_all_threads): If debug_infrun, always
1927         trace the wait status after wait_one, using
1928         target_waitstatus_to_string and target_pid_to_str.
1929         (handle_inferior_event): Replace various trace of
1930         wait status kind by a single trace.
1931         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
1932         wait status kind image by target_waitstatus_to_string.
1933         * target/waitstatus.c (target_waitstatus_to_string): Fix
1934         obsolete comment.
1935
1936 2019-04-01  Tom Tromey  <tromey@adacore.com>
1937
1938         PR symtab/23331:
1939         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
1940
1941 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
1942             Pedro Alves  <palves@redhat.com>
1943
1944         * top.c (quit_force): Call 'finalize_values'.
1945         * value.c (finalize_values): New function.
1946         * value.h (finalize_values): Declare.
1947
1948 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
1949
1950         * NEWS: Announce $_gdb_major and $_gdb_minor.
1951
1952         * top.c (init_gdb_version_vars): New function.
1953         (gdb_init): Call init_gdb_version_vars.
1954
1955 2019-03-29  Tom Tromey  <tromey@adacore.com>
1956
1957         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
1958         help text.  Remove dead code.
1959
1960 2019-03-29  Keith Seitz  <keiths@redhat.com>
1961
1962         From Siddhesh Poyarekar:
1963         * f-lang.h (f77_get_upperbound): Return LONGEST.
1964         (f77_get_lowerbound): Likewise.
1965         * f-typeprint.c (f_type_print_varspec_suffix): Expand
1966         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
1967         print them.
1968         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
1969         plongest to format print it.
1970         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
1971         (f77_get_upperbound): Likewise.
1972         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
1973         LOWER_BOUND to LONGEST.
1974         (f77_create_arrayprint_offset_tbl): Likewise.
1975
1976 2019-03-29  Keith Seitz  <keiths@redhat.com>
1977
1978         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
1979         %s/pulongest for TYPE_LENGTH instead of %d in format
1980         strings.
1981         * ada-typerint.c (ada_print_type): Likewise.
1982         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
1983         * compile/compile-c-support.c (generate_register_struct): Likewise.
1984         * gdbtypes.c (recursive_dump_type): Likewise.
1985         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
1986         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
1987         instead of %d in format strings.
1988         * riscv-tdep.c (riscv_type_alignment): Cast second argument
1989         to std::min to ULONGEST.
1990         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
1991         instead of %d in format strings.
1992         * tracepoint.c (info_scope_command): Likewise.
1993         * typeprint.c (print_offset_data::update)
1994         (print_offset_data::finish): Likewise.
1995         * xtensa-tdep.c (xtensa_store_return_value)
1996         (xtensa_push_dummy_call): Likewise.
1997
1998 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
1999
2000         * windows-nat.c (display_selector): Fixed format specifications
2001         for 64-bit Cygwin.
2002
2003 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2004
2005         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2006
2007 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2008
2009         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2010         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2011         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2012         (nios2_linux_init_abi): Install it.
2013
2014 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2015
2016         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2017
2018 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2019
2020         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2021
2022 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2023             Tom Tromey  <tromey@adacore.com>
2024
2025         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2026
2027 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2028
2029         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2030         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2031         method to compute the bounds of range types. Also print "[evaluated]"
2032         if the bounds' values come from a dynamic evaluation.
2033
2034 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2035
2036         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2037         whitespace when pretty printing is on.
2038
2039 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2040
2041         * ppc-linux-nat.c: Add include.
2042
2043 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2044
2045         * NEWS: Mention AArch64 Pointer Authentication.
2046
2047 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2048
2049         * arm-linux-nat.c: Add include.
2050
2051 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2052
2053         * source-cache.c (source_cache::get_source_lines): Re-read
2054         fullname after calling open_source_file.
2055
2056 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2057
2058         * NEWS: Mention TLS support for FreeBSD.
2059
2060 2019-03-25  Tom Tromey  <tromey@adacore.com>
2061
2062         * minsyms.c (BUNCH_SIZE): Update comment.
2063         (~minimal_symbol_reader): Remove old comment.
2064         (compact_minimal_symbols): Update comment.
2065         (minimal_symbol_reader::install): Remove old comment.  Update
2066         other comments.
2067
2068 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2069
2070         * s390-linux-nat.c: Add include.
2071
2072 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2073
2074         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2075         Call linux_get_hwcap.
2076         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2077         Likewise.
2078         (aarch64_linux_get_hwcap): Remove function.
2079         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2080         declaration.
2081         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2082         linux_get_hwcap.
2083         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2084         * linux-tdep.c (linux_get_hwcap): Add function.
2085         (linux_get_hwcap2): Likewise.
2086         * linux-tdep.h (linux_get_hwcap): Add declaration.
2087         (linux_get_hwcap2): Likewise.
2088         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
2089         (ppc_linux_get_hwcap2): Likewise.
2090         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
2091         linux_get_hwcap.
2092         (ppc_linux_nat_target::insert_watchpoint): Likewise.
2093         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
2094         (ppc_linux_nat_target::read_description): Likewise.
2095         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
2096         * s390-linux-nat.c: Likewise.
2097         * s390-linux-tdep.c (s390_core_read_description): Likewise.
2098
2099 2019-03-24  Tom Tromey  <tom@tromey.com>
2100
2101         * ada-lang.c (standard_lookup): Simplify initialization.
2102         (ada_lookup_symbol_nonlocal): Simplify return.
2103         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
2104         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
2105         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
2106         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
2107         initialization.
2108         * solib.c (solib_global_lookup): Simplify.
2109         * symtab.c (null_block_symbol): Remove.
2110         (symbol_cache_lookup): Simplify returns.
2111         (lookup_language_this): Simplify returns.
2112         (lookup_symbol_aux): Simplify return.
2113         (lookup_local_symbol): Simplify returns.
2114         (lookup_global_symbol_from_objfile): Simplify return.
2115         (lookup_symbol_in_objfile_symtabs)
2116         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
2117         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
2118         (lookup_static_symbol, lookup_global_symbol): Simplify return.
2119         * cp-namespace.c (cp_lookup_bare_symbol)
2120         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
2121         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
2122         (cp_lookup_nested_symbol): Don't use null_block_symbol.
2123         (cp_lookup_symbol_via_imports): Simplify initialization.
2124         (find_symbol_in_baseclass): Likewise.
2125         * symtab.h (null_block_symbol): Remove.
2126         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2127         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2128         (d_lookup_symbol_module): Likewise.
2129         (find_symbol_in_baseclass): Simplify initialization.
2130
2131 2019-03-24  Tom Tromey  <tom@tromey.com>
2132
2133         * expression.h: Don't include symtab.h.
2134         (struct block): Forward declare.
2135
2136 2019-03-24  Tom Tromey  <tom@tromey.com>
2137
2138         * c-exp.y (typebase): Remove casts.
2139         * gdbtypes.c (lookup_unsigned_typename, )
2140         (lookup_signed_typename): Remove cast.
2141         * eval.c (parse_to_comma_and_eval): Remove cast.
2142         * parse.c (write_dollar_variable): Remove cast.
2143         * block.h (struct block) <superblock>: Now const.
2144         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
2145         * psymtab.c (psym_map_matching_symbols): Make "block" const.
2146         (map_block): Make "block" const.
2147         * symfile.h (struct quick_symbol_functions)
2148         <map_matching_symbols>: Constify block argument to "callback".
2149         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
2150         const.
2151         (find_pc_sect_compunit_symtab): Make "b" const.
2152         (find_symbol_at_address): Likewise.
2153         (search_symbols): Likewise.
2154         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
2155         (dw2_debug_names_lookup_symbol): Likewise.
2156         (dw2_map_matching_symbols): Update.
2157         * p-valprint.c (pascal_val_print): Remove "block".
2158         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
2159         (aux_add_nonlocal_symbols): Make "block" const.
2160         (resolve_subexp): Remove cast.
2161         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
2162         const.
2163         (iterate_over_file_blocks): Likewise.
2164         * f-exp.y (%union) <bval>: Remove.
2165         * coffread.c (patch_opaque_types): Make "b" const.
2166         * spu-tdep.c (spu_catch_start): Make "block" const.
2167         * c-valprint.c (print_unpacked_pointer): Remove "block".
2168         * symmisc.c (dump_symtab_1): Make "b" const.
2169         (block_depth): Make "block" const.
2170         * d-exp.y (%union) <bval>: Remove.
2171         * cp-support.h (cp_lookup_rtti_type): Update.
2172         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
2173         * psymtab.c (psym_lookup_symbol): Make "block" const.
2174         (maintenance_check_psymtabs): Make "b" const.
2175         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
2176         (enumerate_locals, enumerate_args): Update.
2177         * python/py-symtab.c (stpy_global_block): Make "block" const.
2178         (stpy_static_block): Likewise.
2179         * inline-frame.c (block_starting_point_at): Make "new_block"
2180         const.
2181         * block.c (find_block_in_blockvector): Make return type const.
2182         (blockvector_for_pc_sect): Make "b" const.
2183         (find_block_in_blockvector): Make "b" const.
2184
2185 2019-03-23  Tom Tromey  <tom@tromey.com>
2186
2187         * varobj.c (varobj_create): Update.
2188         * symfile.c (clear_symtab_users): Don't reset innermost_block.
2189         * printcmd.c (display_command, do_one_display): Don't reset
2190         innermost_block.
2191         * parser-defs.h (enum innermost_block_tracker_type): Move to
2192         expression.h.
2193         (innermost_block): Update comment.
2194         * parse.c (parse_exp_1): Add tracker_types parameter.
2195         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
2196         tracker_types parameter.  Reset innermost_block.
2197         (parse_exp_in_context): Remove.
2198         (parse_expression_for_completion): Update.
2199         * objfiles.c (~objfile): Don't reset expression_context_block or
2200         innermost_block.
2201         * expression.h (enum innermost_block_tracker_type): Move from
2202         parser-defs.h.
2203         (parse_exp_1): Add tracker_types parameter.
2204         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
2205         reset innermost_block.
2206
2207 2019-03-23  Tom Tromey  <tom@tromey.com>
2208
2209         * objfiles.h: Include bcache.h.
2210
2211 2019-03-23  Tom Tromey  <tom@tromey.com>
2212
2213         * linespec.c (get_current_search_block): Use
2214         scoped_restore_current_language.
2215         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
2216
2217 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2218             Jiong Wang  <jiong.wang@arm.com>
2219
2220         * aarch64-linux-tdep.c
2221         (aarch64_linux_iterate_over_regset_sections): Check for pauth
2222         section.
2223         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
2224
2225 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2226             Jiong Wang  <jiong.wang@arm.com>
2227
2228         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
2229         instructions.
2230         (aarch64_analyze_prologue_test): Add PACIASP test.
2231         (aarch64_prologue_prev_register): Unmask PC value.
2232
2233 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2234             Jiong Wang  <jiong.wang@arm.com>
2235
2236         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
2237         (aarch64_dwarf2_prev_register): Unmask PC value.
2238         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
2239         (aarch64_execute_dwarf_cfa_vendor_op): Check for
2240         DW_CFA_AARCH64_negate_ra_state.
2241         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
2242
2243 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2244             Jiong Wang  <jiong.wang@arm.com>
2245
2246         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
2247         registers.
2248         (aarch64_pseudo_register_name): Likewise.
2249         (aarch64_pseudo_register_type): Likewise.
2250         (aarch64_pseudo_register_reggroup_p): Likewise.
2251         (aarch64_gdbarch_init): Add pauth registers.
2252         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
2253         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
2254         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
2255         (struct gdbarch_tdep): Add regnum for ra_state.
2256
2257 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2258             Jiong Wang  <jiong.wang@arm.com>
2259
2260         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
2261
2262 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2263             Jiong Wang  <jiong.wang@arm.com>
2264
2265         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
2266         function.
2267         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
2268         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
2269         (aarch64_gdbarch_init): Add puth registers.
2270         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
2271         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
2272         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
2273
2274 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2275             Jiong Wang  <jiong.wang@arm.com>
2276
2277         * aarch64-linux-nat.c
2278         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
2279         * aarch64-linux-tdep.c
2280         (aarch64_linux_core_read_description): Likewise.
2281         (aarch64_linux_get_hwcap): New function.
2282         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
2283         (aarch64_linux_get_hwcap): New declaration.
2284
2285 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2286             Jiong Wang  <jiong.wang@arm.com>
2287
2288         * aarch64-linux-nat.c
2289         (aarch64_linux_nat_target::read_description): Add pauth param.
2290         * aarch64-linux-tdep.c
2291         (aarch64_linux_core_read_description): Likewise.
2292         * aarch64-tdep.c (struct target_desc): Add in pauth.
2293         (aarch64_read_description): Add pauth param.
2294         (aarch64_gdbarch_init): Likewise.
2295         * aarch64-tdep.h (aarch64_read_description): Likewise.
2296         * arch/aarch64.c (aarch64_create_target_description): Likewise.
2297         * arch/aarch64.h (aarch64_create_target_description): Likewise.
2298         * features/Makefile: Add new files.
2299         * features/aarch64-pauth.c: New file.
2300         * features/aarch64-pauth.xml: New file.
2301
2302 2019-03-20  Tom Tromey  <tromey@adacore.com>
2303
2304         * infrun.c (handle_inferior_event): Rename from
2305         handle_inferior_event_1.  Create a scoped_value_mark.
2306         (handle_inferior_event): Remove.
2307
2308 2019-03-19  Tom Tromey  <tromey@adacore.com>
2309
2310         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
2311         * infrun.h (print_stop_event): Add "displays" parameter.
2312         * infrun.c (print_stop_event): Add "displays" parameter.
2313
2314 2019-03-19  Pedro Alves  <palves@redhat.com>
2315
2316         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
2317         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
2318         to -1.  Fix TABs vs spaces.
2319         (tui_ui_out::tui_ui_out): Don't initialize fields here.
2320         * tui/tui-out.h (tui_ui_out) Add intro comments.
2321         <m_line, m_start_of_line>: In-class initialize, and add describing
2322         comment.
2323
2324 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
2325
2326         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
2327         variable names.
2328         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
2329
2330 2019-03-18  Pedro Alves  <palves@redhat.com>
2331             Eli Zaretskii <eliz@gnu.org>
2332
2333         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
2334         m_line and m_start_of_line.
2335
2336 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
2337
2338         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
2339         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
2340         it returns a newline.  This fixes a regression in TU mode, whereby
2341         the next line is output on the same screen line as the user input.
2342
2343 2019-03-18  Tom Tromey  <tromey@adacore.com>
2344
2345         * minsyms.c (minimal_symbol_reader::install): Remove call to
2346         obstack_blank.
2347
2348 2019-03-18  Pedro Alves  <palves@redhat.com>
2349
2350         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
2351         New globals.
2352         (apply_style): New, factored out from ...
2353         (apply_ansi_escape): ... this.  Handle reverse video mode.
2354         (tui_set_reverse_mode): New function.
2355         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
2356         * tui/tui-winsource.c (tui_show_source_line): Use
2357         tui_set_reverse_mode instead of setting A_STANDOUT.
2358         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
2359         New setter methods.
2360
2361 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
2362
2363         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
2364         Handle tabs.
2365
2366 2019-03-18  Tom Tromey  <tromey@adacore.com>
2367
2368         * ada-lang.c (empty_array): Add "high" parameter.
2369         (ada_evaluate_subexp): Update.
2370
2371 2019-03-17  Sergei Trofimovich <siarheit@google.com>
2372
2373         * unittests/string_view-selftests.c: Define
2374         _initialize_string_view_selftests unconditionally.
2375
2376 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2377
2378         PR gdb/24350
2379         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
2380
2381 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2382
2383         PR gdb/24351
2384         * windows-nat.c (display_selector): Fix format specifiers.
2385
2386 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
2387
2388         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
2389         tui_refill_source_window instead of tui_refresh_win, to update the
2390         current execution line.  This fixes redisplay of the current line
2391         when stepping through the code with "next" or "step".
2392
2393 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2394
2395         * source-cache.c (source_cache::get_source_lines): Call
2396         find_source_lines to initialize s->nlines.  This fixes vertical
2397         scrolling of TUI source window when the DOWN arrow is pressed.
2398
2399 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2400
2401         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
2402         linux-thread-db.c (_initialize_thread_db): Likewise.
2403
2404 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2405
2406         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
2407         wclrtoeol in tui_show_source_line".  This reverts changes made in
2408         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
2409
2410 2019-03-15  Tom Tromey  <tom@tromey.com>
2411
2412         * symtab.h (struct minimal_symbol): Derive from
2413         general_symbol_info.
2414         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
2415         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
2416         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
2417         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
2418         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
2419         (MSYMBOL_SEARCH_NAME): Update.
2420         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
2421         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
2422         * minsyms.c (minimal_symbol_reader::record_full): Update.
2423
2424 2019-03-15  Tom Tromey  <tom@tromey.com>
2425
2426         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
2427
2428 2019-03-15  Tom Tromey  <tom@tromey.com>
2429
2430         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
2431         unique_xmalloc_ptr.
2432         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
2433         Update.
2434         * minsyms.c (lookup_minimal_symbol_by_pc_section)
2435         (build_minimal_symbol_hash_tables)
2436         (minimal_symbol_reader::install): Update.
2437
2438 2019-03-15  Tom Tromey  <tom@tromey.com>
2439
2440         * symtab.c (create_demangled_names_hash): Update.
2441         (symbol_set_names): Update.
2442         * objfiles.h (struct objfile_per_bfd_storage)
2443         <demangled_names_hash>: Now an htab_up.
2444         * objfiles.c (objfile_per_bfd_storage): Simplify.
2445
2446 2019-03-15  Tom Tromey  <tom@tromey.com>
2447
2448         * objfiles.h (struct objfile_per_bfd_storage): Declare
2449         destructor.
2450         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
2451         New.
2452         (get_objfile_bfd_data): Use new.  Don't initialize
2453         language_of_main.
2454         (free_objfile_per_bfd_storage): Remove.
2455         (objfile_bfd_data_free, objfile::~objfile): Use delete.
2456
2457 2019-03-15  Tom Tromey  <tom@tromey.com>
2458
2459         * symfile.c (reread_symbols): Update.
2460         * objfiles.c (objfile::objfile): Update.
2461         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
2462         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
2463         comment.
2464         (minimal_symbol_reader::install): Update.
2465         (terminate_minimal_symbol_table): Remove.
2466         * jit.c (jit_object_close_impl): Update.
2467
2468 2019-03-15  Tom Tromey  <tom@tromey.com>
2469
2470         * minsyms.c (minimal_symbol_reader::record_full): Remove some
2471         initializations.
2472
2473 2019-03-15  Tom Tromey  <tom@tromey.com>
2474
2475         * objfiles.h (struct objfile_per_bfd_storage)
2476         <demangled_hash_languages>: Now a bitset.
2477         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
2478         (lookup_minimal_symbol): Update.
2479
2480 2019-03-15  Tom Tromey  <tom@tromey.com>
2481
2482         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
2483         Don't return the symbol.
2484         * coffread.c (record_minimal_symbol): Use record_full.
2485
2486 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
2487
2488         The MS-Windows port of ncurses fails to switch to a color pair if
2489         one or both of the colors are the implicit default colors.  This
2490         change records the default colors when TUI is initialized, and
2491         then specifies them explicitly when a color pair uses the default
2492         colors.  This allows color styling in TUI mode on MS-Windows.
2493
2494         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
2495         ncurses_norm_attr.
2496         (tui_initialize_io) [__MINGW32__]: Record the default terminal
2497         colors in ncurses_norm_attr.
2498         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
2499         "none", replace it with the default color recorded in
2500         ncurses_norm_attr.
2501
2502 2019-03-14  Tom Tromey  <tromey@adacore.com>
2503
2504         * source-cache.h (class source_cache) <get_source_lines>: Return
2505         std::string.
2506         * source-cache.c (source_cache::extract_lines): Handle case where
2507         first_pos==npos.  Return std::string.
2508         (source_cache::get_source_lines): Update.
2509
2510 2019-03-14  Tom Tromey  <tromey@adacore.com>
2511
2512         * NEWS: Add item for "style sources" commands.
2513         * source-cache.c (source_cache::get_source_lines): Check
2514         source_styling.
2515         * cli/cli-style.c (source_styling): New global.
2516         (_initialize_cli_style): Add "style sources" commands.
2517         (show_style_sources): New function.
2518         * cli/cli-style.h (source_styling): Declare.
2519
2520 2019-03-14  Pedro Alves  <palves@redhat.com>
2521             Tom Tromey  <tromey@adacore.com>
2522
2523         * tui/tui-winsource.h (tui_refill_source_window): Declare.
2524         * tui/tui-winsource.c (tui_refill_source_window): New function,
2525         from...
2526         (tui_horizontal_source_scroll): ... here.  Move some logic.
2527         * cli/cli-style.c (set_style_enabled): Notify new observable.
2528         * tui/tui-hooks.c (tui_redisplay_source): New function.
2529         (tui_attach_detach_observers): Attach or detach
2530         tui_redisplay_source.
2531         * observable.h (source_styling_changed): New observable.
2532         * observable.c: Define source_styling_changed observable.
2533
2534 2019-03-13  Tom Tromey  <tromey@adacore.com>
2535
2536         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
2537         (i386_gnu_nat_target::store_registers): Update.
2538         * target-debug.h (target_debug_print_std_string): New macro.
2539         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2540         * windows-tdep.c (display_one_tib): Update.
2541         * tui/tui-stack.c (tui_make_status_line): Update.
2542         * top.c (print_inferior_quit_action): Update.
2543         * thread.c (thr_try_catch_cmd): Update.
2544         (add_thread_with_info): Update.
2545         (thread_target_id_str): Update.
2546         (thr_try_catch_cmd): Update.
2547         (thread_command): Update.
2548         (thread_find_command): Update.
2549         * record-btrace.c (record_btrace_target::info_record)
2550         (record_btrace_resume_thread, record_btrace_target::resume)
2551         (record_btrace_cancel_resume, record_btrace_step_thread)
2552         (record_btrace_target::wait, record_btrace_target::wait)
2553         (record_btrace_target::wait, record_btrace_target::stop): Update.
2554         * progspace.c (print_program_space): Update.
2555         * process-stratum-target.c
2556         (process_stratum_target::thread_address_space): Update.
2557         * linux-fork.c (linux_fork_mourn_inferior)
2558         (detach_checkpoint_command, info_checkpoints_command)
2559         (linux_fork_context): Update.
2560         (linux_fork_detach): Update.
2561         (class scoped_switch_fork_info): Update.
2562         (delete_checkpoint_command): Update.
2563         * infrun.c (follow_fork_inferior): Update.
2564         (follow_fork_inferior): Update.
2565         (proceed_after_vfork_done): Update.
2566         (handle_vfork_child_exec_or_exit): Update.
2567         (follow_exec): Update.
2568         (displaced_step_prepare_throw): Update.
2569         (displaced_step_restore): Update.
2570         (start_step_over): Update.
2571         (resume_1): Update.
2572         (clear_proceed_status_thread): Update.
2573         (proceed): Update.
2574         (print_target_wait_results): Update.
2575         (do_target_wait): Update.
2576         (context_switch): Update.
2577         (stop_all_threads): Update.
2578         (restart_threads): Update.
2579         (finish_step_over): Update.
2580         (handle_signal_stop): Update.
2581         (switch_back_to_stepped_thread): Update.
2582         (keep_going_pass_signal): Update.
2583         (print_exited_reason): Update.
2584         (normal_stop): Update.
2585         * inferior.c (inferior_pid_to_str): Change return type.
2586         (print_selected_inferior): Update.
2587         (add_inferior): Update.
2588         (detach_inferior): Update.
2589         * dummy-frame.c (fprint_dummy_frames): Update.
2590         * dcache.c (dcache_info_1): Update.
2591         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
2592         (btrace_fetch, btrace_clear): Update.
2593         * linux-tdep.c (linux_core_pid_to_str): Change return type.
2594         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
2595         type.
2596         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
2597         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
2598         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
2599         * gdbarch.c, gdbarch.h: Rebuild.
2600         * gdbarch.sh (core_pid_to_str): Change return type.
2601         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
2602         return type.
2603         (windows_nat_target::pid_to_str): Change return type.
2604         (windows_delete_thread): Update.
2605         (windows_nat_target::attach): Update.
2606         (windows_nat_target::files_info): Update.
2607         * target-delegates.c: Rebuild.
2608         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
2609         return type.
2610         (sol_thread_target::pid_to_str): Change return type.
2611         * remote.c (class remote_target) <pid_to_str>: Change return
2612         type.
2613         (remote_target::pid_to_str): Change return type.
2614         (extended_remote_target::attach, remote_target::remote_stop_ns)
2615         (remote_target::remote_notif_remove_queued_reply)
2616         (remote_target::push_stop_reply, remote_target::disable_btrace):
2617         Update.
2618         (extended_remote_target::attach): Update.
2619         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
2620         type.
2621         (gdbsim_target::pid_to_str): Change return type.
2622         * ravenscar-thread.c (struct ravenscar_thread_target)
2623         <pid_to_str>: Change return type.
2624         (ravenscar_thread_target::pid_to_str): Change return type.
2625         * procfs.c (class procfs_target) <pid_to_str>: Change return
2626         type.
2627         (procfs_target::pid_to_str): Change return type.
2628         (procfs_target::attach): Update.
2629         (procfs_target::detach): Update.
2630         (procfs_target::fetch_registers): Update.
2631         (procfs_target::store_registers): Update.
2632         (procfs_target::wait): Update.
2633         (procfs_target::files_info): Update.
2634         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
2635         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
2636         return type.
2637         (nto_procfs_target::pid_to_str): Change return type.
2638         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
2639         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
2640         return type.
2641         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
2642         (exit_lwp): Update.
2643         (attach_proc_task_lwp_callback, get_detach_signal)
2644         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
2645         (linux_nat_target::resume, wait_lwp, stop_callback)
2646         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
2647         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
2648         (linux_nat_wait_1, resume_stopped_resumed_lwps)
2649         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
2650         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
2651         type.
2652         (inf_ptrace_target::attach): Update.
2653         (inf_ptrace_target::files_info): Update.
2654         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
2655         type.
2656         (go32_nat_target::pid_to_str): Change return type.
2657         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
2658         (gnu_nat_target::wait): Update.
2659         (gnu_nat_target::wait): Update.
2660         (gnu_nat_target::resume): Update.
2661         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
2662         (fbsd_nat_target::wait): Update.
2663         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
2664         type.
2665         (darwin_nat_target::attach): Update.
2666         * corelow.c (class core_target) <pid_to_str>: Change return type.
2667         (core_target::pid_to_str): Change return type.
2668         * target.c (normal_pid_to_str): Change return type.
2669         (default_pid_to_str): Likewise.
2670         (target_pid_to_str): Change return type.
2671         (target_translate_tls_address): Update.
2672         (target_announce_detach): Update.
2673         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
2674         return type.
2675         (bsd_uthread_target::pid_to_str): Change return type.
2676         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
2677         type.
2678         (bsd_kvm_target::pid_to_str): Change return type.
2679         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
2680         return type.
2681         (aix_thread_target::pid_to_str): Change return type.
2682         * target.h (struct target_ops) <pid_to_str>: Change return type.
2683         (target_pid_to_str, normal_pid_to_str): Likewise.
2684         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
2685         type.
2686         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
2687         type.
2688         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
2689         return type.
2690         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
2691         type.
2692         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
2693         type.
2694         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
2695         return type.
2696
2697 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
2698
2699         * NEWS: Mention that the new default MI version is 3.  Mention
2700         changes to the output of commands and events that deal with
2701         multi-location breakpoints.
2702         * breakpoint.c: Include "mi/mi-out.h".
2703         (print_one_breakpoint): Change output syntax if using MI version
2704         >= 3.
2705         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
2706         New.
2707         (mi_multi_location_breakpoint_output_fixed): New.
2708         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
2709         (mi_cmd_fix_multi_location_breakpoint_output): New.
2710         (mi_multi_location_breakpoint_output_fixed): New.
2711         * mi/mi-cmds.c (mi_cmds): Register command
2712         -fix-multi-location-breakpoint-output.
2713         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
2714         interpreter "mi".
2715
2716 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
2717
2718         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
2719         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
2720         instantiate mi_ui_out based on interpreter name.
2721         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
2722         * mi/mi-main.c (mi_load_progress): Likewise.
2723
2724 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2725
2726         * NEWS: Combine separate "New targets" sections for 8.3.
2727
2728 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2729
2730         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
2731         (ppcfbsd_init_abi): Install gdbarch
2732         "fetch_tls_load_module_address" and "get_thread_local_address"
2733         methods.
2734
2735 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2736
2737         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
2738         (riscv_fbsd_init_abi): Install gdbarch
2739         "fetch_tls_load_module_address" and "get_thread_local_address"
2740         methods.
2741
2742 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2743
2744         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
2745         (i386fbsd_init_abi): Install gdbarch
2746         "fetch_tls_load_module_address" and "get_thread_local_address"
2747         methods.
2748
2749 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2750
2751         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
2752         (amd64fbsd_init_abi): Install gdbarch
2753         "fetch_tls_load_module_address" and "get_thread_local_address"
2754         methods.
2755
2756 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2757
2758         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
2759         (struct fbsd_pspace_data): New type.
2760         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
2761         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
2762         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
2763         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
2764         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
2765
2766 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2767
2768         * gdbtypes.c (lookup_struct_elt): New function.
2769         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
2770         * gdbtypes.h (struct struct_elt): New type.
2771         (lookup_struct_elt): New prototype.
2772
2773 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2774
2775         * gdbtypes.c (lookup_struct_elt_type): Update comment and
2776         remove disabled code block.
2777
2778 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2779
2780         * gdbarch.sh (get_thread_local_address): New method.
2781         * gdbarch.h, gdbarch.c: Regenerate.
2782         * target.c (target_translate_tls_address): Use
2783         gdbarch_get_thread_local_address if present instead of
2784         target::get_thread_local_address.
2785
2786 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2787
2788         * target.h (target::get_thread_local_address): Update comment.
2789
2790 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2791
2792         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
2793         objfile->separate_debug_objfile_backlink if not NULL.
2794
2795 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2796
2797         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
2798         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
2799         (amd64bsd_store_inferior_registers): Likewise.
2800         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2801         Enable segment base registers.
2802         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
2803         PT_GETFSBASE and PT_GETGSBASE.
2804         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
2805         PT_SETGSBASE.
2806         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
2807         segment base registers.
2808         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2809
2810 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2811
2812         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2813         Update calls to i386_target_description to add 'segments'
2814         parameter.
2815         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
2816         add segment base registers.
2817         * arch/i386.c (i386_create_target_description): Add 'segments'
2818         parameter to enable segment base registers.
2819         * arch/i386.h (i386_create_target_description): Likewise.
2820         * features/i386/32bit-segments.xml: New file.
2821         * features/i386/32bit-segments.c: Generate.
2822         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
2823         call to i386_target_description to add 'segments' parameter.
2824         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2825         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
2826         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
2827         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
2828         if feature is present.
2829         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
2830         Add 'segments' parameter to call to i386_target_description.
2831         (i386_target_description): Add 'segments' parameter to enable
2832         segment base registers.
2833         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
2834         to call to i386_target_description.
2835         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
2836         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
2837         Define I386_NUM_REGS.
2838         (i386_target_description): Add 'segments' parameter to enable
2839         segment base registers.
2840
2841 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
2842
2843         PR/24325
2844         * source-cache.c: #undef open and close, to avoid unresolved
2845         externals during linking.
2846
2847 2019-03-12  Tom Tromey  <tromey@adacore.com>
2848
2849         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
2850         const.  Add initializers.
2851         (_initialize_remote): Don't initialize ptid globals.
2852
2853 2019-03-12  Pedro Alves  <palves@redhat.com>
2854
2855         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
2856
2857 2019-03-12  Pedro Alves  <palves@redhat.com>
2858
2859         * cp-name-parser.y (main): Remove unused 'len' variable.
2860
2861 2019-03-12  Tom Tromey  <tromey@adacore.com>
2862
2863         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
2864         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
2865
2866 2019-03-12  Tom Tromey  <tromey@adacore.com>
2867
2868         * linux-nat.c (iterate_over_lwps): Update.
2869         (stop_callback): Remove parameter.
2870         (stop_wait_callback, detach_callback, resume_set_callback)
2871         (select_singlestep_lwp_callback, set_ignore_sigint)
2872         (status_callback, resumed_callback, resume_clear_callback)
2873         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
2874         data parameter.
2875         (linux_nat_target::detach, linux_nat_target::resume)
2876         (linux_stop_and_wait_all_lwps, select_event_lwp)
2877         (linux_nat_filter_event, linux_nat_wait_1)
2878         (linux_nat_target::kill, linux_nat_target::stop)
2879         (linux_nat_target::stop): Update.
2880         (linux_nat_resume_callback): Change type.
2881         (resume_stopped_resumed_lwps, count_events_callback)
2882         (select_event_lwp_callback): Likewise.
2883         (linux_stop_lwp, linux_nat_stop_lwp): Update.
2884         * arm-linux-nat.c (struct update_registers_data): Remove.
2885         (update_registers_callback): Change type.
2886         (arm_linux_insert_hw_breakpoint1): Update.
2887         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
2888         parameter.
2889         (x86_linux_dr_set_addr): Update.
2890         (x86_linux_dr_set_control): Update.
2891         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
2892         (iterate_over_lwps): Use gdb::function_view.
2893         * nat/aarch64-linux-hw-point.c (struct
2894         aarch64_dr_update_callback_param): Remove.
2895         (debug_reg_change_callback): Change type.
2896         (aarch64_notify_debug_reg_change): Update.
2897         * s390-linux-nat.c (s390_refresh_per_info): Update.
2898
2899 2019-03-11  Tom Tromey  <tromey@adacore.com>
2900
2901         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
2902         redundant assignment to "this_cu".
2903
2904 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2905
2906         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
2907
2908 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2909
2910         * gdbtypes.c (rank_one_type_parm_set): New function extracted
2911         from...
2912         (rank_one_type): ... this.
2913
2914 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2915
2916         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
2917         from...
2918         (rank_one_type): ... this.
2919
2920 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2921
2922         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
2923         from...
2924         (rank_one_type): ... this.
2925
2926 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2927
2928         * gdbtypes.c (rank_one_type_parm_float): New function extracted
2929         from...
2930         (rank_one_type): ... this.
2931
2932 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2933
2934         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
2935         from...
2936         (rank_one_type): ... this.
2937
2938 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2939
2940         * gdbtypes.c (rank_one_type_parm_range): New function extracted
2941         from...
2942         (rank_one_type): ... this.
2943
2944 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2945
2946         * gdbtypes.c (rank_one_type_parm_char): New function extracted
2947         from...
2948         (rank_one_type): ... this.
2949
2950 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2951
2952         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
2953         from...
2954         (rank_one_type): ... this.
2955
2956 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2957
2958         * gdbtypes.c (rank_one_type_parm_int): New function extracted
2959         from...
2960         (rank_one_type): ... this.
2961
2962 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2963
2964         * gdbtypes.c (rank_one_type_parm_func): New function extracted
2965         from...
2966         (rank_one_type): ... this.
2967
2968 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2969
2970         * gdbtypes.c (rank_one_type_parm_array): New function extracted
2971         from...
2972         (rank_one_type): ... this.
2973
2974 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2975
2976         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
2977         from...
2978         (rank_one_type): ... this.
2979
2980 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2981
2982         * inferior.c (initialize_inferiors): Ensure 'help set/show print
2983         inferior-events' shows the example events.
2984
2985 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
2986
2987         Support styling on native MS-Windows console
2988
2989         PR/24315
2990         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
2991         on MS-Windows if $TERM is not defined.
2992
2993         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
2994
2995         * posix-hdep.c (gdb_console_fputs):
2996         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
2997         functions.
2998         * ui-file.h (gdb_console_fputs): Add prototype.
2999
3000         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3001         back to fputs only if the former returns zero.
3002
3003 2019-03-07  Tom Tromey  <tom@tromey.com>
3004
3005         * symmisc.c (print_symbol_bcache_statistics): Update.
3006         (print_objfile_statistics): Update.
3007         * symfile.c (allocate_symtab): Update.
3008         * stabsread.c: Don't include bcache.h.
3009         * psymtab.h (struct psymbol_bcache): Don't declare.
3010         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3011         (psymbol_bcache_init, psymbol_bcache_free)
3012         (psymbol_bcache_get_bcache): Don't declare.
3013         * psymtab.c (struct psymbol_bcache): Remove.
3014         (psymtab_storage::psymtab_storage): Update.
3015         (psymtab_storage::~psymtab_storage): Update.
3016         (psymbol_bcache_init, psymbol_bcache_free)
3017         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3018         (add_psymbol_to_bcache): Update.
3019         (allocate_psymtab): Update.
3020         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3021         macro_cache>: No longer pointers.
3022         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3023         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3024         * macrotab.c (macro_bcache): Update.
3025         * macroexp.c: Don't include bcache.h.
3026         * gdbtypes.c (check_types_worklist): Update.
3027         (types_deeply_equal): Remove TRY/CATCH.  Update.
3028         * elfread.c (elf_symtab_read): Update.
3029         * dwarf2read.c: Don't include bcache.h.
3030         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3031         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3032         (print_bcache_statistics, bcache_memory_used): Don't declare.
3033         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3034         methods.  Rename all data members.
3035         * bcache.c (struct bcache): Move to bcache.h.
3036         (bcache::expand_hash_table): Rename from expand_hash_table.
3037         (bcache): Remove.
3038         (bcache::insert): Rename from bcache_full.
3039         (bcache::compare): Rename from bcache_compare.
3040         (bcache_xmalloc): Remove.
3041         (bcache::~bcache): Rename from bcache_xfree.
3042         (bcache::print_statistics): Rename from print_bcache_statistics.
3043         (bcache::memory_used): Rename from bcache_memory_used.
3044
3045 2019-03-07  Pedro Alves  <palves@redhat.com>
3046
3047         * infrun.c (normal_stop): Also check for
3048         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3049
3050 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3051
3052         * f-lang.c (value_from_host_double): Moved to...
3053         * value.c (value_from_host_double): ...here.
3054         * value.h (value_from_host_double): Declare.
3055         * guile/scm-math.c (vlscm_convert_typed_number): Use
3056         value_from_host_double.
3057         (vlscm_convert_number): Likewise.
3058         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3059         * python/py-value.c (convert_value_from_python): Likewise.
3060
3061 2019-03-06  Tom Tromey  <tom@tromey.com>
3062
3063         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3064
3065 2019-03-06  Tom Tromey  <tom@tromey.com>
3066
3067         * utils.h (free_current_contents): Don't declare.
3068         * utils.c (free_current_contents): Remove.
3069
3070 2019-03-06  Tom Tromey  <tom@tromey.com>
3071
3072         * top.c (quit_force): Update.
3073         * main.c (captured_command_loop): Update.
3074         * common/new-op.c (operator new): Update.
3075         * common/common-exceptions.c (struct catcher)
3076         <save_cleanup_chain>: Remove member.
3077         (exceptions_state_mc_init): Update.
3078         (exception_try_scope_entry): Return nullptr.
3079         (exception_try_scope_exit, exception_rethrow)
3080         (throw_exception_sjlj, throw_exception_cxx): Update.
3081         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3082         (all_cleanups, do_cleanups, discard_cleanups)
3083         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3084         (restore_cleanups, restore_final_cleanups): Don't declare.
3085         (do_final_cleanups): Remove parameter.
3086         * common/cleanups.c (cleanup_chain, make_cleanup)
3087         (make_cleanup_dtor, all_cleanups, do_cleanups)
3088         (discard_my_cleanups, discard_cleanups)
3089         (discard_final_cleanups, save_my_cleanups, save_cleanups)
3090         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
3091         (null_cleanup): Remove.
3092         (do_final_cleanups): Remove parameter.
3093
3094 2019-03-06  Tom Tromey  <tom@tromey.com>
3095
3096         * remote.c (remote_target::remote_parse_stop_reply): Use
3097         unique_xmalloc_ptr.
3098
3099 2019-03-06  Tom Tromey  <tom@tromey.com>
3100
3101         * stabsread.c (struct stabs_field_info): Rename from field_info.
3102         <list, fnlist>: Add initializers.
3103         <obstack>: New member.
3104         (read_member_functions, read_struct_fields, read_baseclasses):
3105         Allocate on obstack.  Don't use cleanups.
3106         (read_one_struct_field, read_member_functions, read_struct_fields)
3107         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
3108         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
3109         (read_struct_type): Update.
3110
3111 2019-03-06  Tom Tromey  <tom@tromey.com>
3112
3113         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
3114         * common/filestuff.h (make_cleanup_close): Don't declare.
3115         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
3116         Remove.
3117
3118 2019-03-06  Tom Tromey  <tom@tromey.com>
3119
3120         * solib-aix.c: Use make_scope_exit.
3121
3122 2019-03-06  Tom Tromey  <tom@tromey.com>
3123
3124         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
3125         Use make_scope_exit.
3126
3127 2019-03-06  Tom Tromey  <tom@tromey.com>
3128
3129         * solib-svr4.c (disable_probes_interface): Remove parameter.
3130         (svr4_handle_solib_event): Use make_scope_exit.
3131
3132 2019-03-06  Tom Tromey  <tom@tromey.com>
3133
3134         * remote.c (struct stop_reply_deleter): Remove.
3135         (stop_reply_up): Update.
3136         (struct stop_reply): Derive from notif_event.  Don't typedef.
3137         <regcache>: Now a std::vector.
3138         (stop_reply_xfree): Remove.
3139         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
3140         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
3141         (remote_target::discard_pending_stop_replies): Use delete.
3142         (remote_target::remote_parse_stop_reply): Update.
3143         (remote_target::process_stop_reply): Update.
3144         * remote-notif.h (struct notif_event): Add virtual destructor.
3145         Remove "dtr" member.
3146         (struct notif_client) <alloc_event>: Return a unique_ptr.
3147         (notif_event_xfree): Don't declare.
3148         (notif_event_up): New typedef.
3149         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
3150         (notif_event_xfree, do_notif_event_xfree): Remove.
3151         (remote_notif_state_xfree): Update.
3152
3153 2019-03-06  Tom Tromey  <tom@tromey.com>
3154
3155         * infrun.c (displaced_step_clear_cleanup): Now a
3156         forward_scope_exit type.
3157         (displaced_step_prepare_throw): Update.
3158         (displaced_step_fixup): Update.
3159
3160 2019-03-06  Tom Tromey  <tom@tromey.com>
3161
3162         * inferior.h (class inferior): Update comment.
3163         * gdbthread.h (class thread_info): Update comment.
3164
3165 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
3166             Tom Tromey  <tom@tromey.com>
3167
3168         * stabsread.h (struct stab_section_list): Remove.
3169         (coffstab_build_psymtabs): Update.
3170         * dbxread.c (symbuf_sections): Now a std::vector.
3171         (sect_idx): New global.
3172         (fill_symbuf): Update.
3173         (coffstab_build_psymtabs): Change type of stabsects parameter.
3174         Update.
3175         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
3176         std::vector.
3177         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
3178         (coff_locate_sections): Update.
3179         (coff_symfile_read): Remove cleanups.  Update.
3180         (init_stringtab): Add storage parameter.
3181         (free_stringtab, free_stringtab_cleanup): Remove.
3182         (init_lineno): Add storage parameter.
3183         (free_linetab, free_linetab_cleanup): Remove.
3184
3185 2019-03-06  Pedro Alves  <palves@redhat.com>
3186
3187         * linux-fork.c (fork_info::clobber_regs): Delete.
3188         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
3189         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
3190         comment.  Adjust.
3191         (scoped_switch_fork_info::scoped_switch_fork_info)
3192         (checkpoint_command, linux_fork_context): Adjust
3193         fork_save_infrun_state calls.
3194
3195 2019-03-06  Pedro Alves  <palves@redhat.com>
3196
3197         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
3198         (inf_has_multiple_threads): Return 'bool' and rewrite using
3199         inferior_info::threads().
3200
3201 2019-03-06  Pedro Alves  <palves@redhat.com>
3202
3203         * linux-fork.c: Include <list>.
3204         (fork_list): Now a std::list instance.
3205         (fork_info): Add ctor, dtor, and in-class initialize all fields.
3206         (forks_exist_p, find_last_fork): Adjust.
3207         (new_fork): Delete.
3208         (one_fork_p): New.
3209         (add_fork): Adjust.
3210         (free_fork): Delete, folded into fork_info::~fork_info().
3211         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
3212         Adjust.
3213         (init_fork_list): Delete.
3214         (linux_fork_killall, linux_fork_mourn_inferior)
3215         (linux_fork_detach, info_checkpoints_command): Adjust.
3216         (_initialize_linux_fork): No longer call init_fork_list.
3217
3218 2019-03-06  Pedro Alves  <palves@redhat.com>
3219
3220         * linux-fork.c (new_fork): New, split out of ...
3221         (add_fork): ... this.  Return void.  Move "first fork" special
3222         case from here, to ...
3223         (checkpoint_command): ... here.
3224         * linux-linux.h (add_fork): Return void.
3225
3226 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3227
3228         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
3229
3230 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3231             Chris January  <chris.january@arm.com>
3232             David Lecomber  <david.lecomber@arm.com>
3233
3234         * f-exp.y: New token, UNOP_INTRINSIC.
3235         (exp): New pattern using UNOP_INTRINSIC token.
3236         (f77_keywords): Add 'abs' keyword.
3237         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
3238         (value_from_host_double): New function.
3239         (evaluate_subexp_f): Support UNOP_ABS.
3240
3241 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3242
3243         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
3244         types.
3245
3246 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3247
3248         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
3249         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
3250         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
3251
3252 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3253
3254         * f-exp.y (convert_to_kind_type): Handle more type kinds.
3255
3256 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3257             Chris January  <chris.january@arm.com>
3258
3259         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
3260         * f-exp.y: Define 'KIND' token.
3261         (exp): New pattern for KIND expressions.
3262         (ptype): Handle types with a kind extension.
3263         (direct_abs_decl): Extend to spot kind extensions.
3264         (f77_keywords): Add 'kind' to the list.
3265         (push_kind_type): New function.
3266         (convert_to_kind_type): New function.
3267         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
3268         * parse.c (operator_length_standard): Likewise.
3269         * parser-defs.h (enum type_pieces): Add tp_kind.
3270         * std-operator.def: Add UNOP_KIND.
3271
3272 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3273
3274         * f-exp.y (f_parse): Set yydebug.
3275
3276 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3277
3278         * f-lang.c (evaluate_subexp_f): New function.
3279         (exp_descriptor_f): New global.
3280         (f_language_defn): Use exp_descriptor_f instead of
3281         exp_descriptor_standard.
3282
3283 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3284
3285         * f-exp.y (struct token): Add comments.
3286         (dot_ops): Remove uppercase versions and the end marker.
3287         (f77_keywords): Likewise.
3288         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
3289         entries in the dot_ops array are case insensitive, and use
3290         strncasecmp to compare strings.  Also some whitespace cleanup in
3291         this area.  Similar for the f77_keywords array, except entries in
3292         this list might be case sensitive.
3293
3294 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3295
3296         * f-exp.y (struct f77_boolean_val): Add comments.
3297         (boolean_values): Remove uppercase versions, and end marker.
3298         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
3299         and use strncasecmp to achieve case insensitivity.  Additionally,
3300         perform whitespace cleanup around this code.
3301
3302 2019-03-06  Tom Tromey  <tromey@adacore.com>
3303
3304         * remote-sim.c (gdbsim_target_open): Use result of
3305         gdb_argv::release.
3306
3307 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
3308         Dirk Schubert  <dirk.schubert@arm.com>
3309         Chris January  <chris.january@arm.com>
3310
3311         * eval.c (evaluate_subexp_standard): Call Fortran argument
3312         wrapping logic.
3313         * f-lang.c (struct value): A value which can be passed into a
3314         Fortran function call.
3315         (fortran_argument_convert): Wrap Fortran arguments in a pointer
3316         where appropriate.
3317         (struct type): Value ready for a Fortran function call.
3318         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
3319         is needed.
3320         * f-lang.h (fortran_argument_convert): Declaration.
3321         (fortran_preserve_arg_pointer): Declaration.
3322         * infcall.c (value_arg_coerce): Call Fortran argument logic.
3323
3324 2019-03-05  Tom Tromey  <tromey@adacore.com>
3325
3326         * python/py-prettyprint.c (print_string_repr): Remove #if.
3327         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
3328
3329 2019-03-05  Tom Tromey  <tromey@adacore.com>
3330
3331         * target.c (the_dummy_target): Move later.  Change type to
3332         "dummy_target".
3333         (initialize_targets): Don't initialize the_dummy_target.
3334
3335 2019-03-05  Tom Tromey  <tromey@adacore.com>
3336
3337         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
3338         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
3339
3340 2019-03-05  Tom Tromey  <tromey@adacore.com>
3341
3342         * windows-nat.c (windows_nat_target::attach)
3343         (windows_nat_target::detach): Don't call gdb_flush.
3344         * valprint.c (generic_val_print, val_print, val_print_string):
3345         Don't call gdb_flush.
3346         * utils.c (defaulted_query): Don't call gdb_flush.
3347         * typeprint.c (print_type_scalar): Don't call gdb_flush.
3348         * target.c (target_announce_detach): Don't call gdb_flush.
3349         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
3350         * remote.c (extended_remote_target::attach): Don't call
3351         gdb_flush.
3352         * procfs.c (procfs_target::detach): Don't call gdb_flush.
3353         * printcmd.c (do_examine): Don't call gdb_flush.
3354         (info_display_command): Don't call gdb_flush.
3355         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
3356         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
3357         * memattr.c (info_mem_command): Don't call gdb_flush.
3358         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
3359         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
3360         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
3361         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
3362         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
3363         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
3364         (gnu_nat_target::detach): Don't call gdb_flush.
3365         * f-valprint.c (f_val_print): Don't call gdb_flush.
3366         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
3367         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
3368         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
3369         gdb_flush.
3370         * c-valprint.c (c_val_print): Don't call gdb_flush.
3371         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
3372
3373 2019-03-05  Tom Tromey  <tromey@adacore.com>
3374
3375         * varobj.c (update_dynamic_varobj_children): Update.
3376         (install_default_visualizer): Use reset, not release.
3377         * value.c (set_internalvar): Update.
3378         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
3379         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
3380         ATTRIBUTE_UNUSED_RESULT.
3381
3382 2019-03-05  Tom Tromey  <tromey@adacore.com>
3383
3384         * remote.c (class scoped_remote_fd) <release>: Add
3385         ATTRIBUTE_UNUSED_RESULT.
3386
3387 2019-03-05  Tom Tromey  <tromey@adacore.com>
3388
3389         * macroexp.c (struct macro_buffer) <release>: Add
3390         ATTRIBUTE_UNUSED_RESULT.
3391
3392 2019-03-05  Tom Tromey  <tromey@adacore.com>
3393
3394         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
3395         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
3396         ATTRIBUTE_UNUSED_RESULT.
3397
3398 2019-03-05  Tom Tromey  <tromey@adacore.com>
3399
3400         * common/scoped_fd.h (class scoped_fd) <release>: Add
3401         ATTRIBUTE_UNUSED_RESULT.
3402
3403 2019-03-05  Tom Tromey  <tromey@adacore.com>
3404
3405         * parser-defs.h (struct parser_state) <release>: Add
3406         ATTRIBUTE_UNUSED_RESULT.
3407
3408 2019-03-05  Tom Tromey  <tromey@adacore.com>
3409
3410         * utils.h (class gdb_argv) <release>: Add
3411         ATTRIBUTE_UNUSED_RESULT.
3412         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
3413
3414 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
3415
3416         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
3417         for-loop range, to avoid compiler warnings.
3418
3419         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
3420         avoid compiler warnings about unused variables.
3421
3422         * NEWS: Mention end of support for native debugging on MS-Windows
3423         before XP.
3424
3425         PR gdb/24292
3426         * common/netstuff.c:
3427         * gdbserver/gdbreplay.c
3428         * gdbserver/remote-utils.c:
3429         * ser-tcp.c:
3430         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
3431         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
3432         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
3433         'getaddrinfo' and 'freeaddrinfo' were not available before
3434         Windows XP, and mingw.org's MinGW headers by default define
3435         _WIN32_WINNT to 0x500.
3436
3437 2019-03-01  Gary Benson <gbenson@redhat.com>
3438
3439         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
3440
3441 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
3442             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3443
3444         PR gdb/8527
3445         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
3446         set_sigint_trap, clear_sigint_trap.
3447
3448 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3449
3450         * target.c (target_detach): Clear the regcache and the
3451         frame cache.
3452
3453 2019-02-27  Pedro Alves  <palves@redhat.com>
3454
3455         * utils.c (set_screen_size): When we cap the height/width sizes,
3456         tweak the corresponding command variable to show "unlimited":
3457
3458 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
3459             Pedro Alves  <palves@redhat.com>
3460
3461         * utils.c (set_screen_size): Reduce "infinite" rows and columns
3462         before calling rl_set_screen_size.
3463
3464 2019-02-27  Tom Tromey  <tromey@adacore.com>
3465
3466         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
3467         define.
3468         * python/py-value.c: Remove Python 2.4 workaround.
3469         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
3470         workaround.
3471         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
3472         Python 2.4 workaround.
3473         * python/python-internal.h: Remove Python 2.4 comment.
3474         (Py_ssize_t): Don't define.
3475         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
3476         (gdb_Py_DECREF): Remove Python 2.4 workaround.
3477         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
3478         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
3479         * python/python.c (do_start_initialization): Remove Python 2.4
3480         workaround.
3481         * python/py-prettyprint.c (class dummy_python_frame): Remove.
3482         (print_children): Remove Python 2.4 workaround.
3483         * python/py-inferior.c (buffer_procs): Remove Python 2.4
3484         workaround.
3485         (CHARBUFFERPROC_NAME): Remove.
3486         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
3487         Python 2.4 workaround.
3488
3489 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3490
3491         * NEWS: Note minimum Python version.
3492
3493 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3494
3495         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
3496         code from these functions.  Remove corresponding ifdefs.  Use
3497         Py_buffer_up instead of explicit calls to PyBuffer_Release.
3498         Remove gotos and target of gotos.
3499         (infpy_search_memory): Likewise.
3500
3501 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3502
3503         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
3504         (hppa_gdbarch_init): Don't register deleted functions with
3505         gdbarch.
3506
3507 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3508
3509         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
3510         (h8300_unwind_sp): Delete.
3511         (h8300_dummy_id): Delete.
3512         (h8300_gdbarch_init): Don't register deleted functions with
3513         gdbarch.
3514
3515 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3516
3517         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
3518         (ft32_unwind_pc): Delete.
3519         (ft32_unwind_sp): Delete.
3520         (ft32_gdbarch_init): Don't register deleted functions with
3521         gdbarch.
3522
3523 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3524
3525         * gdb/frv-tdep.c (frv_dummy_id): Delete.
3526         (frv_unwind_pc): Delete.
3527         (frv_unwind_sp): Delete.
3528         (frv_gdbarch_init): Don't register deleted functions with
3529         gdbarch.
3530
3531 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3532
3533         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
3534         (riscv_unwind_pc): Delete.
3535         (riscv_unwind_sp): Delete.
3536         (riscv_gdbarch_init): Don't register deleted functions with
3537         gdbarch.
3538
3539 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3540
3541         * gdb/csky-tdep.c (csky_dummy_id): Delete.
3542         (csky_unwind_pc): Delete.
3543         (csky_unwind_sp): Delete.
3544         (csky_gdbarch_init): Don't register deleted functions with
3545         gdbarch.
3546
3547 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3548
3549         * gdb/cris-tdep.c (cris_dummy_id): Delete.
3550         (cris_unwind_pc): Delete.
3551         (cris_unwind_sp): Delete.
3552         (cris_gdbarch_init): Don't register deleted functions with
3553         gdbarch.
3554
3555 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3556
3557         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
3558         (bfin_unwind_pc): Delete.
3559         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
3560
3561 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3562
3563         * gdb/arm-tdep.c (arm_dummy_id): Delete.
3564         (arm_unwind_pc): Delete.
3565         (arm_unwind_sp): Delete.
3566         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
3567
3568 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3569
3570         * gdb/arc-tdep.c (arc_dummy_id): Delete.
3571         (arc_unwind_pc): Delete.
3572         (arc_unwind_sp): Delete.
3573         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
3574
3575 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3576
3577         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
3578         (alpha_unwind_pc): Delete.
3579         (alpha_gdbarch_init): Don't register deleted functions with
3580         gdbarch.
3581
3582 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3583
3584         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
3585         (aarch64_unwind_pc): Delete.
3586         (aarch64_unwind_sp): Delete.
3587         (aarch64_gdbarch_init): Don't register deleted functions with
3588         gdbarch.
3589
3590 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3591
3592         * gdbtypes.c (type_align): Don't consider static members when
3593         computing structure alignment.
3594
3595 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3596
3597         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
3598         return 0 for other types.
3599         * arch-utils.c (default_type_align): Always return 0.
3600         * gdbarch.h: Regenerate.
3601         * gdbarch.sh (type_align): Extend comment.
3602         * gdbtypes.c (type_align): Add additional comments, always call
3603         gdbarch_type_align before applying the default rules.
3604         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
3605         generic code will then apply a suitable default.
3606         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
3607         types, return 0 for other types.
3608
3609 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3610
3611         * NEWS: Create a new section for the next release branch.
3612         Rename the section of the current branch, now that it has
3613         been cut.
3614
3615 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3616
3617         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
3618         * version.in: Bump version to 8.3.50.DATE-git.
3619
3620 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
3621
3622         * aix-thread.c (ptid_cmp): Remove unused variable.
3623         (get_signaled_thread): Likewise.
3624         (store_regs_user_thread): Likewise.
3625         (store_regs_kernel_thread): Likewise.
3626         (fetch_regs_kernel_thread): Remove shadowed variable.
3627
3628 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3629
3630         * features/riscv/32bit-cpu.xml: Add register numbers.
3631         * features/riscv/32bit-fpu.c: Regenerate.
3632         * features/riscv/32bit-fpu.xml: Add register numbers.
3633         * features/riscv/64bit-cpu.xml: Add register numbers.
3634         * features/riscv/64bit-fpu.c: Regenerate.
3635         * features/riscv/64bit-fpu.xml: Add register numbers.
3636
3637 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
3638
3639         * NEWS: Mention two argument form of gdb.Value constructor.
3640         * python/py-value.c (convert_buffer_and_type_to_value): New
3641         function.
3642         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
3643         Add support for handling an optional second argument.  Call
3644         convert_buffer_and_type_to_value as appropriate.
3645         * python/python-internal.h (Py_buffer_deleter): New struct.
3646         (Py_buffer_up): New typedef.
3647
3648 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
3649
3650         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
3651         instead of releasing ownership.
3652
3653 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
3654
3655         * dwarf2read.c (open_and_init_dwp_file): Call
3656         elf_numsections instead of bfd_count_sections to initialize
3657         dwp_file->num_sections.
3658
3659 2019-02-25  Tom Tromey  <tromey@adacore.com>
3660
3661         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
3662
3663 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
3664
3665         * gcore.in: Add '--readnever' option when invoking GDB.
3666
3667 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3668
3669         * MAINTAINERS: Update my email address.
3670
3671 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3672
3673         * build-id.c (build_id_to_debug_bfd_1): New function.
3674         (build_id_to_debug_bfd): Look for separate debug file in
3675         sysroot.
3676
3677 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3678
3679         * gdbarch.sh: Update the copyright year range that is placed into
3680         generated files.
3681
3682 2019-02-22  Keith Seitz  <keiths@redhat.com>
3683
3684         PR symtab/23853
3685         * linespec.c (create_sals_line_offset): Search for the default
3686         symtab's filename instead of its fullname.
3687
3688 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3689
3690         * NEWS: Update style defaults.
3691
3692 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3693
3694         * main.c (captured_main_1): Disable styling in batch mode.
3695
3696 2019-02-20  Tom Tromey  <tom@tromey.com>
3697
3698         * symtab.c (symtab_symbol_info): Fix typos.
3699
3700 2019-02-20  Tom Tromey  <tromey@adacore.com>
3701
3702         * findcmd.c (_initialize_mem_search): Use upper case for
3703         metasyntactic variables.
3704
3705 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
3706
3707         * aarch64-tdep.c (aarch64_add_reggroups): New function.
3708         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
3709
3710 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
3711
3712         * top.h (source_file_name): Change to std::string.
3713         * top.c (source_file_name): Likewise.
3714         (command_line_input): Adjust.
3715         * cli/cli-script.c (script_from_file): Adjust.
3716
3717 2019-02-19  Tom Tromey  <tromey@adacore.com>
3718
3719         * ravenscar-thread.c
3720         (ravenscar_thread_target::update_thread_list): Don't call
3721         ada_build_task_list.
3722         * ada-lang.h (ada_build_task_list): Don't declare.
3723         * ada-tasks.c (struct ada_tasks_inferior_data)
3724         <task_list_valid_p>: Now bool.
3725         (read_known_tasks, ada_task_list_changed)
3726         (ada_tasks_invalidate_inferior_data): Update.
3727         (read_known_tasks_array): Return bool.
3728         (read_known_tasks_list): Likewise.
3729         (read_known_tasks): Return void.
3730         (ada_build_task_list): Now static.
3731
3732 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3733
3734         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
3735         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
3736
3737 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3738
3739         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
3740         variant for ada_tasks_pspace_data_handle and
3741         ada_tasks_inferior_data_handle.
3742         (ada_tasks_pspace_data_cleanup): New function.
3743         (ada_tasks_inferior_data_cleanup): New function.
3744
3745 2019-02-17  Tom Tromey  <tom@tromey.com>
3746
3747         * macrotab.h (macro_source_fullname): Return a std::string.
3748         * macrotab.c (macro_include, check_for_redefinition)
3749         (macro_undef, macro_lookup_definition, foreach_macro)
3750         (foreach_macro_in_scope): Update.
3751         (macro_source_fullname): Return a std::string.
3752         * macrocmd.c (show_pp_source_pos): Update.
3753
3754 2019-02-17  Tom Tromey  <tom@tromey.com>
3755
3756         * macrocmd.c (show_pp_source_pos): Style the file names.
3757
3758 2019-02-17  Tom Tromey  <tom@tromey.com>
3759
3760         PR tui/24197:
3761         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
3762
3763 2019-02-17  Tom Tromey  <tom@tromey.com>
3764
3765         * ada-lang.c (user_select_syms): Use filtered printing.
3766         * utils.c (wrap_style): New global.
3767         (desired_style): Remove.
3768         (emit_style_escape): Add stream parameter.
3769         (set_output_style, reset_terminal_style, prompt_for_continue):
3770         Update.
3771         (flush_wrap_buffer): Only flush gdb_stdout.
3772         (wrap_here): Set wrap_style.
3773         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
3774         treat escape sequences as a character.  Change when wrap buffer is
3775         flushed.
3776         (fputs_styled): Do not set the output style when the default is
3777         requested.
3778         * ui-style.h (struct ui_file_style) <is_default>: New method.
3779         * source.c (print_source_lines_base): Emit escape sequences in one
3780         piece.
3781
3782 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3783
3784         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
3785         integers and enumeration types.
3786
3787 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3788
3789         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
3790         instead of lookup_symbol_in_language
3791         (do_exact_match): New function.
3792         (ada_get_symbol_name_matcher): Return do_exact_match when
3793         doing a verbatim match.
3794
3795 2019-02-15  Tom Tromey  <tromey@adacore.com>
3796
3797         * ravenscar-thread.c (ravenscar_thread_target::resume)
3798         (ravenscar_thread_target::wait): Special case wildcard requests.
3799
3800 2019-02-15  Tom Tromey  <tromey@adacore.com>
3801
3802         * ravenscar-thread.c (base_ptid): Remove.
3803         (struct ravenscar_thread_target) <close>: New method.
3804         <m_base_ptid>: New member.
3805         <update_inferior_ptid, active_task, task_is_currently_active,
3806         runtime_initialized>: Declare methods.
3807         <ravenscar_thread_target>: Add constructor.
3808         (ravenscar_thread_target::task_is_currently_active)
3809         (ravenscar_thread_target::update_inferior_ptid)
3810         (ravenscar_runtime_initialized): Rename.  Now methods.
3811         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
3812         (ravenscar_thread_target::update_thread_list): Update.
3813         (ravenscar_thread_target::active_task): Now method.
3814         (ravenscar_thread_target::store_registers)
3815         (ravenscar_thread_target::prepare_to_store)
3816         (ravenscar_thread_target::prepare_to_store)
3817         (ravenscar_thread_target::mourn_inferior): Update.
3818         (ravenscar_inferior_created): Use "new" to create target.
3819         (ravenscar_thread_target::get_ada_task_ptid): Update.
3820         (_initialize_ravenscar): Don't initialize base_ptid.
3821         (ravenscar_ops): Remove global.
3822
3823 2019-02-15  Tom Tromey  <tromey@adacore.com>
3824
3825         * target.h (push_target): Declare new overload.
3826         * target.c (push_target): New overload, taking an rvalue reference.
3827         * remote.c (remote_target::open_1): Use push_target overload.
3828         * corelow.c (core_target_open): Use push_target overload.
3829
3830 2019-02-15  Tom Tromey  <tromey@adacore.com>
3831
3832         * ravenscar-thread.c (is_ravenscar_task)
3833         (ravenscar_task_is_currently_active): Return bool.
3834         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
3835         (_initialize_ravenscar): Remove "(void)".
3836         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
3837         Return bool.
3838
3839 2019-02-15  Tom Tromey  <tromey@adacore.com>
3840
3841         * ravenscar-thread.c (ravenscar_runtime_initializer)
3842         (has_ravenscar_runtime, get_running_thread_id)
3843         (ravenscar_thread_target::resume): Fix indentation.
3844
3845 2019-02-15  Tom Tromey  <tromey@adacore.com>
3846
3847         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
3848         from ravenscar_arch_ops.
3849         (sparc_ravenscar_ops::fetch_registers)
3850         (sparc_ravenscar_ops::store_registers): Now methods.
3851         (sparc_ravenscar_prepare_to_store): Remove.
3852         (sparc_ravenscar_ops): Redefine.
3853         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
3854         methods and destructor.  Remove members.
3855         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
3856         (ravenscar_thread_target::store_registers)
3857         (ravenscar_thread_target::prepare_to_store): Update.
3858         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
3859         Remove.
3860         (struct ppc_ravenscar_powerpc_ops): Derive from
3861         ravenscar_arch_ops.
3862         (ppc_ravenscar_powerpc_ops::fetch_registers)
3863         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
3864         (ppc_ravenscar_powerpc_ops): Redefine.
3865         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
3866         (ppc_ravenscar_e500_ops::fetch_registers)
3867         (ppc_ravenscar_e500_ops::store_registers): Now methods.
3868         (ppc_ravenscar_e500_ops): Redefine.
3869         * aarch64-ravenscar-thread.c
3870         (aarch64_ravenscar_generic_prepare_to_store): Remove.
3871         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
3872         (aarch64_ravenscar_fetch_registers)
3873         (aarch64_ravenscar_store_registers): Now methods.
3874         (aarch64_ravenscar_ops): Redefine.
3875
3876 2019-02-15  Tom Tromey  <tromey@adacore.com>
3877
3878         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
3879         (ravenscar_thread_target::stopped_by_hw_breakpoint)
3880         (ravenscar_thread_target::stopped_by_watchpoint)
3881         (ravenscar_thread_target::stopped_data_address)
3882         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
3883
3884 2019-02-15  Tom Tromey  <tromey@adacore.com>
3885
3886         * ravenscar-thread.c: Fix some typos.
3887
3888 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3889             Tom Tromey  <tromey@adacore.com>
3890
3891         * ada-lang.c (ada_exception_sal): Change addr_string to a
3892         std::string.
3893         (create_ada_exception_catchpoint): Update.
3894
3895 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3896             Tom Tromey  <tromey@adacore.com>
3897
3898         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
3899         (bp_location_ops): Remove.
3900         (base_breakpoint_allocate_location): Update.
3901         (free_bp_location): Update.
3902         * ada-lang.c (class ada_catchpoint_location)
3903         <ada_catchpoint_location>: Remove ops parameter.
3904         (ada_catchpoint_location_dtor): Remove.
3905         (ada_catchpoint_location_ops): Remove.
3906         (allocate_location_exception): Update.
3907         * breakpoint.h (struct bp_location_ops): Remove.
3908         (class bp_location) <bp_location>: Remove bp_location_ops
3909         parameter.
3910         <~bp_location>: Add destructor.
3911         <ops>: Remove.
3912
3913 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3914             Pedro Alves  <palves@redhat.com>
3915
3916         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
3917         'PATH_MAX'.
3918
3919 2019-02-14  David Michael  <fedora.dm0@gmail.com>
3920             Samuel Thibault  <samuel.thibault@gnu.org>
3921             Thomas Schwinge  <thomas@codesourcery.com>
3922
3923         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
3924         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
3925
3926 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3927
3928         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
3929         (check_empty): Use "const char *".
3930
3931         * gnu-nat.c (gnu_nat_target::detach): Instead of
3932         'detach_inferior (pid)' call
3933         'detach_inferior (find_inferior_pid (pid))'.
3934
3935         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
3936         'nat/fork-inferior.o'.
3937         * gnu-nat.c: #include "nat/fork-inferior.h".
3938
3939         * gnu-nat.c (gnu_nat_target::detach): Instead of
3940         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
3941         * gnu-nat.h: #include "inf-child.h".
3942         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
3943         'i386_gnu_nat_target::fetch_registers'.
3944         (gnu_store_registers): Rename/move to
3945         'i386_gnu_nat_target::store_registers'.
3946
3947         * config/i386/nm-i386gnu.h: Don't "#include" any files.
3948         * gnu-nat.h (mach_thread_info): New function.
3949         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
3950
3951         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
3952
3953 2019-02-14  Frederic Konrad  <konrad@adacore.com>
3954
3955         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
3956
3957 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
3958
3959         * windows-nat.c (windows_add_thread): Add new parameter
3960         "main_thread_p" with default value set to false.  Update
3961         function documentation as well as all callers.
3962         (windows_delete_thread): Likewise.
3963         (fake_create_process): Update call to windows_add_thread.
3964         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
3965         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
3966         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
3967         call to windows_delete_thread.
3968
3969 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
3970
3971         * MAINTAINERS: Add Andrew Burgess as global maintainer.
3972
3973 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3974
3975         * symfile.c (find_separate_debug_file): Use canonical path of
3976         sysroot with child_path instead of gdb_sysroot if it is valid.
3977
3978 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3979
3980         * symfile.c (find_separate_debug_file): Use child_path to
3981         determine if an object file is under a sysroot.
3982
3983 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3984
3985         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
3986         unittests/child-path-selftests.c.
3987         * common/pathstuff.c (child_path): New function.
3988         * common/pathstuff.h (child_path): New prototype.
3989         * unittests/child-path-selftests.c: New file.
3990
3991 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3992
3993         * symfile.c (find_separate_debug_file): Look for separate debug
3994         files in debug directories under the sysroot.
3995
3996 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3997
3998         * symtab.h (struct minimal_symbol data_p): New const method.
3999         (struct minimal_symbol text_p): Likewise.
4000         * symtab.c (output_source_filename): Use file name style
4001         to print file name.
4002         (print_symbol_info): Likewise.
4003         (print_msymbol_info): Use address style to print addresses.
4004         Use function name style to print executable text symbols.
4005         (expand_symtab_containing_pc): Use data_p.
4006         (find_pc_sect_compunit_symtab): Likewise.
4007
4008 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4009
4010         * breakpoint.c (describe_other_breakpoints): Use address style
4011         to print addresses.
4012         (say_where): Likewise.
4013
4014 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4015
4016         * ada-typeprint.c (print_func_type): Print function name
4017         style to print function name.
4018         * c-typeprint.c (c_print_type_1): Likewise.
4019
4020 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4021
4022         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4023         for execve.
4024
4025 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4026
4027         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4028         type_stack.
4029
4030 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4031
4032         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4033         TYPE_CODE_REF types.
4034
4035 2019-02-08  Jim Wilson  <jimw@sifive.com>
4036
4037         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4038         (riscv_linux_fregset): New.
4039         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4040
4041 2019-02-07  Tom Tromey  <tom@tromey.com>
4042
4043         * thread.c (thread_cancel_execution_command): Update.
4044         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4045         methods.
4046         (struct thread_fsm_ops): Remove.
4047         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4048         (thread_fsm_should_stop, thread_fsm_return_value)
4049         (thread_fsm_set_finished, thread_fsm_finished_p)
4050         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4051         Don't declare.
4052         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4053         * infrun.c (clear_proceed_status_thread)
4054         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4055         (print_stop_event): Update.
4056         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4057         Add constructor.
4058         (step_command_fsm_ops): Remove.
4059         (new_step_command_fsm): Remove.
4060         (step_1): Update.
4061         (step_command_fsm::should_stop): Rename from
4062         step_command_fsm_should_stop.
4063         (step_command_fsm::clean_up): Rename from
4064         step_command_fsm_clean_up.
4065         (step_command_fsm::do_async_reply_reason): Rename from
4066         step_command_fsm_async_reply_reason.
4067         (struct until_next_fsm): Inherit from thread_fsm.  Add
4068         constructor.
4069         (until_next_fsm_ops): Remove.
4070         (new_until_next_fsm): Remove.
4071         (until_next_fsm::should_stop): Rename from
4072         until_next_fsm_should_stop.
4073         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4074         (until_next_fsm::do_async_reply_reason): Rename from
4075         until_next_fsm_async_reply_reason.
4076         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4077         constructor.  Change type of breakpoint.
4078         (finish_command_fsm_ops): Remove.
4079         (new_finish_command_fsm): Remove.
4080         (finish_command_fsm::should_stop): Rename from
4081         finish_command_fsm_should_stop.
4082         (finish_command_fsm::clean_up): Rename from
4083         finish_command_fsm_clean_up.
4084         (finish_command_fsm::return_value): Rename from
4085         finish_command_fsm_return_value.
4086         (finish_command_fsm::do_async_reply_reason): Rename from
4087         finish_command_fsm_async_reply_reason.
4088         (finish_command): Update.
4089         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
4090         Add constructor.
4091         (call_thread_fsm_ops): Remove.
4092         (call_thread_fsm::call_thread_fsm): Rename from
4093         new_call_thread_fsm.
4094         (call_thread_fsm::should_stop): Rename from
4095         call_thread_fsm_should_stop.
4096         (call_thread_fsm::should_notify_stop): Rename from
4097         call_thread_fsm_should_notify_stop.
4098         (run_inferior_call, call_function_by_hand_dummy): Update.
4099         * cli/cli-interp.c (should_print_stop_to_console): Update.
4100         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
4101         Add constructor.  Change type of location_breakpoint,
4102         caller_breakpoint.
4103         (until_break_fsm_ops): Remove.
4104         (new_until_break_fsm): Remove.
4105         (until_break_fsm::should_stop): Rename from
4106         until_break_fsm_should_stop.
4107         (until_break_fsm::clean_up): Rename from
4108         until_break_fsm_clean_up.
4109         (until_break_fsm::do_async_reply_reason): Rename from
4110         until_break_fsm_async_reply_reason.
4111         (until_break_command): Update.
4112         * thread-fsm.c: Remove.
4113         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
4114
4115 2019-02-07  Tom Tromey  <tom@tromey.com>
4116
4117         * yy-remap.h: Add include guard.
4118         * xtensa-tdep.h: Add include guard.
4119         * xcoffread.h: Rename include guard.
4120         * varobj-iter.h: Add include guard.
4121         * tui/tui.h: Rename include guard.
4122         * tui/tui-winsource.h: Rename include guard.
4123         * tui/tui-wingeneral.h: Rename include guard.
4124         * tui/tui-windata.h: Rename include guard.
4125         * tui/tui-win.h: Rename include guard.
4126         * tui/tui-stack.h: Rename include guard.
4127         * tui/tui-source.h: Rename include guard.
4128         * tui/tui-regs.h: Rename include guard.
4129         * tui/tui-out.h: Rename include guard.
4130         * tui/tui-layout.h: Rename include guard.
4131         * tui/tui-io.h: Rename include guard.
4132         * tui/tui-hooks.h: Rename include guard.
4133         * tui/tui-file.h: Rename include guard.
4134         * tui/tui-disasm.h: Rename include guard.
4135         * tui/tui-data.h: Rename include guard.
4136         * tui/tui-command.h: Rename include guard.
4137         * tic6x-tdep.h: Add include guard.
4138         * target/waitstatus.h: Rename include guard.
4139         * target/wait.h: Rename include guard.
4140         * target/target.h: Rename include guard.
4141         * target/resume.h: Rename include guard.
4142         * target-float.h: Rename include guard.
4143         * stabsread.h: Add include guard.
4144         * rs6000-tdep.h: Add include guard.
4145         * riscv-fbsd-tdep.h: Add include guard.
4146         * regformats/regdef.h: Rename include guard.
4147         * record.h: Rename include guard.
4148         * python/python.h: Rename include guard.
4149         * python/python-internal.h: Rename include guard.
4150         * python/py-stopevent.h: Rename include guard.
4151         * python/py-ref.h: Rename include guard.
4152         * python/py-record.h: Rename include guard.
4153         * python/py-record-full.h: Rename include guard.
4154         * python/py-record-btrace.h: Rename include guard.
4155         * python/py-instruction.h: Rename include guard.
4156         * python/py-events.h: Rename include guard.
4157         * python/py-event.h: Rename include guard.
4158         * procfs.h: Add include guard.
4159         * proc-utils.h: Add include guard.
4160         * p-lang.h: Add include guard.
4161         * or1k-tdep.h: Rename include guard.
4162         * observable.h: Rename include guard.
4163         * nto-tdep.h: Rename include guard.
4164         * nat/x86-linux.h: Rename include guard.
4165         * nat/x86-linux-dregs.h: Rename include guard.
4166         * nat/x86-gcc-cpuid.h: Add include guard.
4167         * nat/x86-dregs.h: Rename include guard.
4168         * nat/x86-cpuid.h: Rename include guard.
4169         * nat/ppc-linux.h: Rename include guard.
4170         * nat/mips-linux-watch.h: Rename include guard.
4171         * nat/linux-waitpid.h: Rename include guard.
4172         * nat/linux-ptrace.h: Rename include guard.
4173         * nat/linux-procfs.h: Rename include guard.
4174         * nat/linux-osdata.h: Rename include guard.
4175         * nat/linux-nat.h: Rename include guard.
4176         * nat/linux-namespaces.h: Rename include guard.
4177         * nat/linux-btrace.h: Rename include guard.
4178         * nat/glibc_thread_db.h: Rename include guard.
4179         * nat/gdb_thread_db.h: Rename include guard.
4180         * nat/gdb_ptrace.h: Rename include guard.
4181         * nat/fork-inferior.h: Rename include guard.
4182         * nat/amd64-linux-siginfo.h: Rename include guard.
4183         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
4184         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
4185         * nat/aarch64-linux.h: Rename include guard.
4186         * nat/aarch64-linux-hw-point.h: Rename include guard.
4187         * mn10300-tdep.h: Add include guard.
4188         * mips-linux-tdep.h: Add include guard.
4189         * mi/mi-parse.h: Rename include guard.
4190         * mi/mi-out.h: Rename include guard.
4191         * mi/mi-main.h: Rename include guard.
4192         * mi/mi-interp.h: Rename include guard.
4193         * mi/mi-getopt.h: Rename include guard.
4194         * mi/mi-console.h: Rename include guard.
4195         * mi/mi-common.h: Rename include guard.
4196         * mi/mi-cmds.h: Rename include guard.
4197         * mi/mi-cmd-break.h: Rename include guard.
4198         * m2-lang.h: Add include guard.
4199         * location.h: Rename include guard.
4200         * linux-record.h: Rename include guard.
4201         * linux-nat.h: Add include guard.
4202         * linux-fork.h: Add include guard.
4203         * i386-darwin-tdep.h: Rename include guard.
4204         * hppa-linux-offsets.h: Add include guard.
4205         * guile/guile.h: Rename include guard.
4206         * guile/guile-internal.h: Rename include guard.
4207         * gnu-nat.h: Rename include guard.
4208         * gdb-stabs.h: Rename include guard.
4209         * frv-tdep.h: Add include guard.
4210         * f-lang.h: Add include guard.
4211         * event-loop.h: Add include guard.
4212         * darwin-nat.h: Rename include guard.
4213         * cp-abi.h: Rename include guard.
4214         * config/sparc/nm-sol2.h: Rename include guard.
4215         * config/nm-nto.h: Rename include guard.
4216         * config/nm-linux.h: Add include guard.
4217         * config/i386/nm-i386gnu.h: Rename include guard.
4218         * config/djgpp/nl_types.h: Rename include guard.
4219         * config/djgpp/langinfo.h: Rename include guard.
4220         * compile/gcc-cp-plugin.h: Add include guard.
4221         * compile/gcc-c-plugin.h: Add include guard.
4222         * compile/compile.h: Rename include guard.
4223         * compile/compile-object-run.h: Rename include guard.
4224         * compile/compile-object-load.h: Rename include guard.
4225         * compile/compile-internal.h: Rename include guard.
4226         * compile/compile-cplus.h: Rename include guard.
4227         * compile/compile-c.h: Rename include guard.
4228         * common/xml-utils.h: Rename include guard.
4229         * common/x86-xstate.h: Rename include guard.
4230         * common/version.h: Rename include guard.
4231         * common/vec.h: Rename include guard.
4232         * common/tdesc.h: Rename include guard.
4233         * common/selftest.h: Rename include guard.
4234         * common/scoped_restore.h: Rename include guard.
4235         * common/scoped_mmap.h: Rename include guard.
4236         * common/scoped_fd.h: Rename include guard.
4237         * common/safe-iterator.h: Rename include guard.
4238         * common/run-time-clock.h: Rename include guard.
4239         * common/refcounted-object.h: Rename include guard.
4240         * common/queue.h: Rename include guard.
4241         * common/ptid.h: Rename include guard.
4242         * common/print-utils.h: Rename include guard.
4243         * common/preprocessor.h: Rename include guard.
4244         * common/pathstuff.h: Rename include guard.
4245         * common/observable.h: Rename include guard.
4246         * common/netstuff.h: Rename include guard.
4247         * common/job-control.h: Rename include guard.
4248         * common/host-defs.h: Rename include guard.
4249         * common/gdb_wait.h: Rename include guard.
4250         * common/gdb_vecs.h: Rename include guard.
4251         * common/gdb_unlinker.h: Rename include guard.
4252         * common/gdb_unique_ptr.h: Rename include guard.
4253         * common/gdb_tilde_expand.h: Rename include guard.
4254         * common/gdb_sys_time.h: Rename include guard.
4255         * common/gdb_string_view.h: Rename include guard.
4256         * common/gdb_splay_tree.h: Rename include guard.
4257         * common/gdb_setjmp.h: Rename include guard.
4258         * common/gdb_ref_ptr.h: Rename include guard.
4259         * common/gdb_optional.h: Rename include guard.
4260         * common/gdb_locale.h: Rename include guard.
4261         * common/gdb_assert.h: Rename include guard.
4262         * common/filtered-iterator.h: Rename include guard.
4263         * common/filestuff.h: Rename include guard.
4264         * common/fileio.h: Rename include guard.
4265         * common/environ.h: Rename include guard.
4266         * common/common-utils.h: Rename include guard.
4267         * common/common-types.h: Rename include guard.
4268         * common/common-regcache.h: Rename include guard.
4269         * common/common-inferior.h: Rename include guard.
4270         * common/common-gdbthread.h: Rename include guard.
4271         * common/common-exceptions.h: Rename include guard.
4272         * common/common-defs.h: Rename include guard.
4273         * common/common-debug.h: Rename include guard.
4274         * common/cleanups.h: Rename include guard.
4275         * common/buffer.h: Rename include guard.
4276         * common/btrace-common.h: Rename include guard.
4277         * common/break-common.h: Rename include guard.
4278         * cli/cli-utils.h: Rename include guard.
4279         * cli/cli-style.h: Rename include guard.
4280         * cli/cli-setshow.h: Rename include guard.
4281         * cli/cli-script.h: Rename include guard.
4282         * cli/cli-interp.h: Rename include guard.
4283         * cli/cli-decode.h: Rename include guard.
4284         * cli/cli-cmds.h: Rename include guard.
4285         * charset-list.h: Add include guard.
4286         * buildsym-legacy.h: Rename include guard.
4287         * bfin-tdep.h: Add include guard.
4288         * ax.h: Rename include guard.
4289         * arm-linux-tdep.h: Add include guard.
4290         * arm-fbsd-tdep.h: Add include guard.
4291         * arch/xtensa.h: Rename include guard.
4292         * arch/tic6x.h: Add include guard.
4293         * arch/i386.h: Add include guard.
4294         * arch/arm.h: Rename include guard.
4295         * arch/arm-linux.h: Rename include guard.
4296         * arch/arm-get-next-pcs.h: Rename include guard.
4297         * arch/amd64.h: Add include guard.
4298         * arch/aarch64-insn.h: Rename include guard.
4299         * arch-utils.h: Rename include guard.
4300         * annotate.h: Add include guard.
4301         * amd64-darwin-tdep.h: Rename include guard.
4302         * aarch64-linux-tdep.h: Add include guard.
4303         * aarch64-fbsd-tdep.h: Add include guard.
4304         * aarch32-linux-nat.h: Add include guard.
4305
4306 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4307
4308         * macrotab.c (macro_define_internal): New function that
4309         factorizes macro_define_object_internal and macro_define_function
4310         code.
4311         (macro_define_object_internal): Use macro_define_internal.
4312         (macro_define_function): Likewise.
4313
4314 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4315
4316         * macrocmd.c (extract_identifier): Return
4317         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
4318         callers.
4319
4320 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
4321
4322         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
4323
4324 2019-02-05  Tom Tromey  <tom@tromey.com>
4325
4326         * target.c (target_stack::unpush): Move assertion earlier.
4327
4328 2019-01-30  Tom Tromey  <tom@tromey.com>
4329
4330         PR python/23615:
4331         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
4332         (gdbpy_parse_and_eval): Likewise.
4333         * python/python-internal.h (gdbpy_allow_threads): New class.
4334
4335 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
4336
4337         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
4338         (aarch64_fbsd_fpregmap): Move earlier.
4339         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
4340         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4341         instead of individual calls to trad_frame_set_reg_addr.
4342         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
4343         earlier.
4344         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
4345         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4346         instead of individual calls to trad_frame_set_reg_addr.
4347
4348 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
4349
4350         * CONTRIBUTE: Replace contribution list with wiki link.
4351
4352 2019-01-25  Tom Tromey  <tom@tromey.com>
4353
4354         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
4355
4356 2019-01-25  Tom Tromey  <tom@tromey.com>
4357
4358         * xtensa-linux-nat.c: Fix common/ includes.
4359         * xml-support.h: Fix common/ includes.
4360         * xml-support.c: Fix common/ includes.
4361         * x86-linux-nat.c: Fix common/ includes.
4362         * windows-nat.c: Fix common/ includes.
4363         * varobj.h: Fix common/ includes.
4364         * varobj.c: Fix common/ includes.
4365         * value.c: Fix common/ includes.
4366         * valops.c: Fix common/ includes.
4367         * utils.c: Fix common/ includes.
4368         * unittests/xml-utils-selftests.c: Fix common/ includes.
4369         * unittests/utils-selftests.c: Fix common/ includes.
4370         * unittests/unpack-selftests.c: Fix common/ includes.
4371         * unittests/tracepoint-selftests.c: Fix common/ includes.
4372         * unittests/style-selftests.c: Fix common/ includes.
4373         * unittests/string_view-selftests.c: Fix common/ includes.
4374         * unittests/scoped_restore-selftests.c: Fix common/ includes.
4375         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
4376         * unittests/scoped_fd-selftests.c: Fix common/ includes.
4377         * unittests/rsp-low-selftests.c: Fix common/ includes.
4378         * unittests/parse-connection-spec-selftests.c: Fix common/
4379         includes.
4380         * unittests/optional-selftests.c: Fix common/ includes.
4381         * unittests/offset-type-selftests.c: Fix common/ includes.
4382         * unittests/observable-selftests.c: Fix common/ includes.
4383         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
4384         * unittests/memrange-selftests.c: Fix common/ includes.
4385         * unittests/memory-map-selftests.c: Fix common/ includes.
4386         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
4387         * unittests/function-view-selftests.c: Fix common/ includes.
4388         * unittests/environ-selftests.c: Fix common/ includes.
4389         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
4390         * unittests/common-utils-selftests.c: Fix common/ includes.
4391         * unittests/cli-utils-selftests.c: Fix common/ includes.
4392         * unittests/array-view-selftests.c: Fix common/ includes.
4393         * ui-file.c: Fix common/ includes.
4394         * tui/tui-io.c: Fix common/ includes.
4395         * tracepoint.h: Fix common/ includes.
4396         * tracepoint.c: Fix common/ includes.
4397         * tracefile-tfile.c: Fix common/ includes.
4398         * top.h: Fix common/ includes.
4399         * top.c: Fix common/ includes.
4400         * thread.c: Fix common/ includes.
4401         * target/waitstatus.h: Fix common/ includes.
4402         * target/waitstatus.c: Fix common/ includes.
4403         * target.h: Fix common/ includes.
4404         * target.c: Fix common/ includes.
4405         * target-memory.c: Fix common/ includes.
4406         * target-descriptions.c: Fix common/ includes.
4407         * symtab.h: Fix common/ includes.
4408         * symfile.c: Fix common/ includes.
4409         * stap-probe.c: Fix common/ includes.
4410         * spu-linux-nat.c: Fix common/ includes.
4411         * sparc-nat.c: Fix common/ includes.
4412         * source.c: Fix common/ includes.
4413         * solib.c: Fix common/ includes.
4414         * solib-target.c: Fix common/ includes.
4415         * ser-unix.c: Fix common/ includes.
4416         * ser-tcp.c: Fix common/ includes.
4417         * ser-pipe.c: Fix common/ includes.
4418         * ser-base.c: Fix common/ includes.
4419         * selftest-arch.c: Fix common/ includes.
4420         * s12z-tdep.c: Fix common/ includes.
4421         * rust-exp.y: Fix common/ includes.
4422         * rs6000-aix-tdep.c: Fix common/ includes.
4423         * riscv-tdep.c: Fix common/ includes.
4424         * remote.c: Fix common/ includes.
4425         * remote-notif.h: Fix common/ includes.
4426         * remote-fileio.h: Fix common/ includes.
4427         * remote-fileio.c: Fix common/ includes.
4428         * regcache.h: Fix common/ includes.
4429         * regcache.c: Fix common/ includes.
4430         * record-btrace.c: Fix common/ includes.
4431         * python/python.c: Fix common/ includes.
4432         * python/py-type.c: Fix common/ includes.
4433         * python/py-inferior.c: Fix common/ includes.
4434         * progspace.h: Fix common/ includes.
4435         * producer.c: Fix common/ includes.
4436         * procfs.c: Fix common/ includes.
4437         * proc-api.c: Fix common/ includes.
4438         * printcmd.c: Fix common/ includes.
4439         * ppc-linux-nat.c: Fix common/ includes.
4440         * parser-defs.h: Fix common/ includes.
4441         * osdata.c: Fix common/ includes.
4442         * obsd-nat.c: Fix common/ includes.
4443         * nat/x86-linux.c: Fix common/ includes.
4444         * nat/x86-linux-dregs.c: Fix common/ includes.
4445         * nat/x86-dregs.h: Fix common/ includes.
4446         * nat/x86-dregs.c: Fix common/ includes.
4447         * nat/ppc-linux.c: Fix common/ includes.
4448         * nat/mips-linux-watch.h: Fix common/ includes.
4449         * nat/mips-linux-watch.c: Fix common/ includes.
4450         * nat/linux-waitpid.c: Fix common/ includes.
4451         * nat/linux-ptrace.h: Fix common/ includes.
4452         * nat/linux-ptrace.c: Fix common/ includes.
4453         * nat/linux-procfs.c: Fix common/ includes.
4454         * nat/linux-personality.c: Fix common/ includes.
4455         * nat/linux-osdata.c: Fix common/ includes.
4456         * nat/linux-namespaces.c: Fix common/ includes.
4457         * nat/linux-btrace.h: Fix common/ includes.
4458         * nat/linux-btrace.c: Fix common/ includes.
4459         * nat/fork-inferior.c: Fix common/ includes.
4460         * nat/amd64-linux-siginfo.c: Fix common/ includes.
4461         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
4462         * nat/aarch64-linux.c: Fix common/ includes.
4463         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
4464         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
4465         * namespace.h: Fix common/ includes.
4466         * mips-linux-tdep.c: Fix common/ includes.
4467         * minsyms.c: Fix common/ includes.
4468         * mi/mi-parse.h: Fix common/ includes.
4469         * mi/mi-main.c: Fix common/ includes.
4470         * mi/mi-cmd-env.c: Fix common/ includes.
4471         * memrange.h: Fix common/ includes.
4472         * memattr.c: Fix common/ includes.
4473         * maint.h: Fix common/ includes.
4474         * maint.c: Fix common/ includes.
4475         * main.c: Fix common/ includes.
4476         * machoread.c: Fix common/ includes.
4477         * location.c: Fix common/ includes.
4478         * linux-thread-db.c: Fix common/ includes.
4479         * linux-nat.c: Fix common/ includes.
4480         * linux-fork.c: Fix common/ includes.
4481         * inline-frame.c: Fix common/ includes.
4482         * infrun.c: Fix common/ includes.
4483         * inflow.c: Fix common/ includes.
4484         * inferior.h: Fix common/ includes.
4485         * inferior.c: Fix common/ includes.
4486         * infcmd.c: Fix common/ includes.
4487         * inf-ptrace.c: Fix common/ includes.
4488         * inf-child.c: Fix common/ includes.
4489         * ia64-linux-nat.c: Fix common/ includes.
4490         * i387-tdep.c: Fix common/ includes.
4491         * i386-tdep.c: Fix common/ includes.
4492         * i386-linux-tdep.c: Fix common/ includes.
4493         * i386-linux-nat.c: Fix common/ includes.
4494         * i386-go32-tdep.c: Fix common/ includes.
4495         * i386-fbsd-tdep.c: Fix common/ includes.
4496         * i386-fbsd-nat.c: Fix common/ includes.
4497         * guile/scm-type.c: Fix common/ includes.
4498         * guile/guile.c: Fix common/ includes.
4499         * go32-nat.c: Fix common/ includes.
4500         * gnu-nat.c: Fix common/ includes.
4501         * gdbthread.h: Fix common/ includes.
4502         * gdbarch-selftests.c: Fix common/ includes.
4503         * gdb_usleep.c: Fix common/ includes.
4504         * gdb_select.h: Fix common/ includes.
4505         * gdb_bfd.c: Fix common/ includes.
4506         * gcore.c: Fix common/ includes.
4507         * fork-child.c: Fix common/ includes.
4508         * findvar.c: Fix common/ includes.
4509         * fbsd-nat.c: Fix common/ includes.
4510         * event-top.c: Fix common/ includes.
4511         * event-loop.c: Fix common/ includes.
4512         * dwarf2read.c: Fix common/ includes.
4513         * dwarf2loc.c: Fix common/ includes.
4514         * dwarf2-frame.c: Fix common/ includes.
4515         * dwarf-index-cache.c: Fix common/ includes.
4516         * dtrace-probe.c: Fix common/ includes.
4517         * disasm-selftests.c: Fix common/ includes.
4518         * defs.h: Fix common/ includes.
4519         * csky-tdep.c: Fix common/ includes.
4520         * cp-valprint.c: Fix common/ includes.
4521         * cp-support.h: Fix common/ includes.
4522         * cp-support.c: Fix common/ includes.
4523         * corelow.c: Fix common/ includes.
4524         * completer.h: Fix common/ includes.
4525         * completer.c: Fix common/ includes.
4526         * compile/compile.c: Fix common/ includes.
4527         * compile/compile-loc2c.c: Fix common/ includes.
4528         * compile/compile-cplus-types.c: Fix common/ includes.
4529         * compile/compile-cplus-symbols.c: Fix common/ includes.
4530         * command.h: Fix common/ includes.
4531         * cli/cli-dump.c: Fix common/ includes.
4532         * cli/cli-cmds.c: Fix common/ includes.
4533         * charset.c: Fix common/ includes.
4534         * build-id.c: Fix common/ includes.
4535         * btrace.h: Fix common/ includes.
4536         * btrace.c: Fix common/ includes.
4537         * breakpoint.h: Fix common/ includes.
4538         * breakpoint.c: Fix common/ includes.
4539         * ax.h:
4540         (enum agent_op): Fix common/ includes.
4541         * ax-general.c (struct aop_map): Fix common/ includes.
4542         * ax-gdb.c: Fix common/ includes.
4543         * auxv.c: Fix common/ includes.
4544         * auto-load.c: Fix common/ includes.
4545         * arm-tdep.c: Fix common/ includes.
4546         * arch/riscv.c: Fix common/ includes.
4547         * arch/ppc-linux-common.c: Fix common/ includes.
4548         * arch/i386.c: Fix common/ includes.
4549         * arch/arm.c: Fix common/ includes.
4550         * arch/arm-linux.c: Fix common/ includes.
4551         * arch/arm-get-next-pcs.c: Fix common/ includes.
4552         * arch/amd64.c: Fix common/ includes.
4553         * arch/aarch64.c: Fix common/ includes.
4554         * arch/aarch64-insn.c: Fix common/ includes.
4555         * arch-utils.c: Fix common/ includes.
4556         * amd64-windows-tdep.c: Fix common/ includes.
4557         * amd64-tdep.c: Fix common/ includes.
4558         * amd64-sol2-tdep.c: Fix common/ includes.
4559         * amd64-obsd-tdep.c: Fix common/ includes.
4560         * amd64-nbsd-tdep.c: Fix common/ includes.
4561         * amd64-linux-tdep.c: Fix common/ includes.
4562         * amd64-linux-nat.c: Fix common/ includes.
4563         * amd64-fbsd-tdep.c: Fix common/ includes.
4564         * amd64-fbsd-nat.c: Fix common/ includes.
4565         * amd64-dicos-tdep.c: Fix common/ includes.
4566         * amd64-darwin-tdep.c: Fix common/ includes.
4567         * agent.c: Fix common/ includes.
4568         * ada-lang.h: Fix common/ includes.
4569         * ada-lang.c: Fix common/ includes.
4570         * aarch64-tdep.c: Fix common/ includes.
4571
4572 2019-01-25  Tom Tromey  <tom@tromey.com>
4573
4574         * common/create-version.sh: Use common/version.h.
4575
4576 2019-01-24  Pedro Alves  <palves@redhat.com>
4577
4578         * infrun.c (signal_stop, signal_print, signal_program)
4579         (signal_catch, signal_pass): Now arrays instead of pointers.
4580         (update_signals_program_target, do_target_resume)
4581         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
4582         * linux-nat.c (linux_nat_target::pass_signals)
4583         (linux_nat_target::create_inferior, linux_nat_target::attach):
4584         Adjust.
4585         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
4586         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
4587         * procfs.c (procfs_target::pass_signals): Adjust.
4588         * record-full.c (record_full_target::resume): Adjust.
4589         * remote.c (remote_target::pass_signals)
4590         (remote_target::program_signals): Adjust.
4591         * target-debug.h (target_debug_print_signals): Now takes a
4592         gdb::array_view as parameter.  Adjust.
4593         * target.h (target_ops) <pass_signals, program_signals>: Replace
4594         pointer and length parameters with gdb::array_view.
4595         (target_pass_signals, target_program_signals): Likewise.
4596         * target-delegates.c: Regenerate.
4597
4598 2019-01-24  Pedro Alves  <palves@redhat.com>
4599
4600         * common/forward-scope-exit.h
4601         (forward_scope_exit::forward_scope_exit): Pass arguments to
4602         m_bind_function directly, instead of creating a std::bind and
4603         copying that.
4604
4605 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
4606
4607         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4608         for static members.
4609         (pass_in_v_vfp_candidate): Likewise.
4610
4611 2019-01-23  Tom Tromey  <tom@tromey.com>
4612             Pedro Alves  <palves@redhat.com>
4613
4614         * regcache.c (class regcache_invalidator): Remove.
4615         (regcache::raw_write): Use make_scope_exit.
4616
4617 2019-01-23  Tom Tromey  <tom@tromey.com>
4618
4619         * ui-out.h (class ui_out_emit_type): Update comment.
4620
4621 2019-01-23  Tom Tromey  <tom@tromey.com>
4622
4623         * infrun.c (fetch_inferior_event): Update comment.
4624
4625 2019-01-23  Tom Tromey  <tom@tromey.com>
4626             Pedro Alves  <palves@redhat.com>
4627
4628         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
4629         parameter.
4630         (fetch_inferior_event): Use SCOPE_EXIT.
4631
4632
4633 2019-01-23  Tom Tromey  <tom@tromey.com>
4634             Pedro Alves  <palves@redhat.com>
4635
4636         * infrun.c (disable_thread_events): Delete.
4637         (stop_all_threads): Use SCOPE_EXIT.
4638
4639 2019-01-23  Tom Tromey  <tom@tromey.com>
4640             Pedro Alves  <palves@redhat.com>
4641
4642         * symfile.c: Include forward-scope-exit.h.
4643         (clear_symtab_users_cleanup): Replace forward declaration with
4644         a FORWARD_SCOPE_EXIT.
4645         (syms_from_objfile_1): Use the forward_scope_exit and
4646         gdb::optional instead of cleanup_function.
4647         (reread_symbols): Use the forward_scope_exit instead of
4648         cleanup_function.
4649         (clear_symtab_users_cleanup): Remove function.
4650
4651 2019-01-23  Tom Tromey  <tom@tromey.com>
4652             Pedro Alves  <palves@redhat.com>
4653
4654         * linux-nat.c: Include scope-exit.h.
4655         (cleanup_target_stop): Remove.
4656         (linux_nat_target::static_tracepoint_markers_by_strid): Use
4657         SCOPE_EXIT.
4658
4659 2019-01-23  Tom Tromey  <tom@tromey.com>
4660             Pedro Alves  <palves@redhat.com>
4661
4662         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
4663         (call_function_by_hand_dummy): Use SCOPE_EXIT.
4664
4665 2019-01-23  Tom Tromey  <tom@tromey.com>
4666             Andrew Burgess  <andrew.burgess@embecosm.com>
4667             Pedro Alves  <palves@redhat.com>
4668
4669         * infrun.c (fetch_inferior_event): Use scope_exit.
4670         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
4671         * top.c (execute_command): Use scope_exit.
4672         * breakpoint.c (bpstat_do_actions): Use scope_exit.
4673         * utils.c (do_bpstat_clear_actions_cleanup)
4674         (make_bpstat_clear_actions_cleanup): Remove.
4675
4676 2019-01-23  Tom Tromey  <tom@tromey.com>
4677             Pedro Alves  <palves@redhat.com>
4678
4679         * infrun.c: Include "common/scope-exit.h"
4680         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
4681         (wait_for_inferior): Use SCOPE_EXIT.
4682         (fetch_inferior_event): Use scope_exit.
4683
4684 2019-01-23  Tom Tromey  <tom@tromey.com>
4685             Pedro Alves  <palves@redhat.com>
4686
4687         * breakpoint.c (create_breakpoint): Remove cleanup.
4688
4689 2019-01-23  Tom Tromey  <tom@tromey.com>
4690             Andrew Burgess  <andrew.burgess@embecosm.com>
4691             Pedro Alves  <palves@redhat.com>
4692
4693 2019-01-23  Pedro Alves  <palves@redhat.com>
4694
4695         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
4696
4697 2019-01-23  Pedro Alves  <palves@redhat.com>
4698             Andrew Burgess  <andrew.burgess@embecosm.com>
4699
4700         * gdbthread.h: Include "common/forward-scope-exit.h".
4701         (scoped_finish_thread_state): Redefine custom class in terms of
4702         forward_scope_exit.
4703
4704 2019-01-23  Pedro Alves  <palves@redhat.com>
4705             Andrew Burgess  <andrew.burgess@embecosm.com>
4706
4707         * common/forward-scope-exit.h: New file.
4708
4709 2019-01-23  Pedro Alves  <palves@redhat.com>
4710             Andrew Burgess  <andrew.burgess@embecosm.com>
4711             Tom Tromey  <tom@tromey.com>
4712
4713         * common/scope-exit.h: New file.
4714
4715 2019-01-23  Pedro Alves  <palves@redhat.com>
4716
4717         * common/preprocessor.h (ESC): Rename to ...
4718         (ESC_PARENS): ... this.
4719         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
4720         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
4721
4722 2019-01-23  Tom Tromey  <tom@tromey.com>
4723
4724         * language.h (class scoped_switch_to_sym_language_if_auto):
4725         Initialize m_lang in both cases.
4726
4727 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
4728
4729         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
4730         with XCNEW.
4731
4732 2019-01-22  Tom Tromey  <tom@tromey.com>
4733
4734         * corelow.c: Do not include sys/file.h.
4735
4736 2019-01-22  Tom Tromey  <tom@tromey.com>
4737
4738         * tui/tui-wingeneral.h: Include gdb_curses.h.
4739
4740 2019-01-22  Tom Tromey  <tom@tromey.com>
4741
4742         * source-cache.h (class source_cache) <get_source_lines,
4743         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
4744
4745 2019-01-22  Tom Tromey  <tom@tromey.com>
4746
4747         * remote-fileio.h (struct remote_target): Declare.
4748
4749 2019-01-22  Tom Tromey  <tom@tromey.com>
4750
4751         * python/py-arch.c: Do not include py-ref.h.
4752         * python/py-bpevent.c: Do not include py-ref.h.
4753         * python/py-cmd.c: Do not include py-ref.h.
4754         * python/py-continueevent.c: Do not include py-ref.h.
4755         * python/py-event.h: Do not include py-ref.h.
4756         * python/py-evtregistry.c: Do not include py-ref.h.
4757         * python/py-finishbreakpoint.c: Do not include py-ref.h.
4758         * python/py-frame.c: Do not include py-ref.h.
4759         * python/py-framefilter.c: Do not include py-ref.h.
4760         * python/py-function.c: Do not include py-ref.h.
4761         * python/py-infevents.c: Do not include py-ref.h.
4762         * python/py-linetable.c: Do not include py-ref.h.
4763         * python/py-objfile.c: Do not include py-ref.h.
4764         * python/py-param.c: Do not include py-ref.h.
4765         * python/py-prettyprint.c: Do not include py-ref.h.
4766         * python/py-progspace.c: Do not include py-ref.h.
4767         * python/py-symbol.c: Do not include py-ref.h.
4768         * python/py-symtab.c: Do not include py-ref.h.
4769         * python/py-type.c: Do not include py-ref.h.
4770         * python/py-unwind.c: Do not include py-ref.h.
4771         * python/py-utils.c: Do not include py-ref.h.
4772         * python/py-value.c: Do not include py-ref.h.
4773         * python/py-varobj.c: Do not include py-ref.h.
4774         * python/py-xmethods.c: Do not include py-ref.h.
4775         * python/python.c: Do not include py-ref.h.
4776         * varobj.c: Do not include py-ref.h.
4777
4778 2019-01-22  Tom Tromey  <tom@tromey.com>
4779
4780         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
4781         keyword for bcache.
4782
4783 2019-01-22  Tom Tromey  <tom@tromey.com>
4784
4785         * compile/compile-cplus-types.c: Remove a comment by #include.
4786
4787 2019-01-22  Tom Tromey  <tom@tromey.com>
4788
4789         * compile/gcc-c-plugin.h: Include compile-internal.h.
4790
4791 2019-01-22  Tom Tromey  <tom@tromey.com>
4792
4793         * stabsread.c (EXTERN): Do not define.
4794         (symnum, next_symbol_text_func, processing_gcc_compilation)
4795         (within_function, global_sym_chain, global_stabs)
4796         (previous_stab_code, this_object_header_files)
4797         (n_this_object_header_files)
4798         (n_allocated_this_object_header_files): Define.
4799         * stabsread.h (EXTERN): Never define.  Use "extern".
4800
4801 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4802
4803         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
4804         history_value.
4805
4806 2019-01-21  Tom Tromey  <tom@tromey.com>
4807
4808         * ui-out.c: Fix includes.
4809         * tui/tui-source.c: Fix includes.
4810         * target.c: Fix includes.
4811         * remote.c: Fix includes.
4812         * regcache.c: Fix includes.
4813         * python/py-block.c: Fix includes.
4814         * printcmd.c: Fix includes.
4815         * or1k-tdep.c: Fix includes.
4816         * mi/mi-main.c: Fix includes.
4817         * m32r-tdep.c: Fix includes.
4818         * csky-tdep.c: Fix includes.
4819         * compile/compile-cplus-types.c: Fix includes.
4820         * cli/cli-interp.c: Fix includes.
4821
4822 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
4823
4824         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4825         for padding.
4826
4827 2019-01-16  Tom Tromey  <tom@tromey.com>
4828
4829         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
4830         earlier.
4831         (struct objfile) <msymbols_range>: Move from top level.
4832         <msymbols>: New method.
4833         (class objfile_msymbols): Remove.
4834         * symtab.c (default_collect_symbol_completion_matches_break_on):
4835         Update.
4836         * symmisc.c (dump_msymbols): Update.
4837         * stabsread.c (scan_file_globals): Update.
4838         * objc-lang.c (info_selectors_command, info_classes_command)
4839         (find_methods): Update.
4840         * minsyms.c (find_solib_trampoline_target): Update.
4841         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
4842         * coffread.c (coff_symfile_read): Update.
4843         * ada-lang.c (ada_lookup_simple_minsym)
4844         (ada_collect_symbol_completion_matches): Update.
4845
4846 2019-01-16  Tom Tromey  <tom@tromey.com>
4847
4848         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
4849         type.  Remove no-argument constructor.
4850         <iterator::operator++>: Simplify.
4851         <begin>: Update.
4852         <end>: Use minimal_symbol_count.
4853
4854 2019-01-16  Tom Tromey  <tom@tromey.com>
4855
4856         * objfiles.h (struct objfile) <psymtabs>: New method.
4857         (class objfile_psymtabs): Remove.
4858         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
4859         typedef.
4860         <range>: New method.
4861         (require_partial_symbols): Change return type.
4862         * psymtab.c (require_partial_symbols)
4863         (psym_expand_symtabs_matching): Update.
4864         * mdebugread.c (parse_partial_symbols): Update.
4865         * dbxread.c (dbx_end_psymtab): Update.
4866
4867 2019-01-15  Tom Tromey  <tom@tromey.com>
4868
4869         * symtab.c (lookup_objfile_from_block)
4870         (lookup_symbol_in_objfile_symtabs)
4871         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
4872         (find_line_symtab, info_sources_command)
4873         (default_collect_symbol_completion_matches_break_on)
4874         (make_source_files_completion_list): Update.
4875         * symmisc.c (print_objfile_statistics, dump_objfile)
4876         (maintenance_print_symbols, maintenance_info_symtabs)
4877         (maintenance_check_symtabs, maintenance_info_line_tables):
4878         Update.
4879         * source.c (select_source_symtab)
4880         (forget_cached_source_info_for_objfile): Update.
4881         * objfiles.h (class objfile_compunits): Remove.
4882         (struct objfile) <compunits_range>: New typedef.
4883         (compunits): New method.
4884         * objfiles.c (objfile_relocate1): Update.
4885         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4886         * maint.c (count_symtabs_and_blocks): Update.
4887         * linespec.c (iterate_over_all_matching_symtabs): Update.
4888         * cp-support.c (add_symbol_overload_list_qualified): Update.
4889         * coffread.c (coff_symtab_read): Update.
4890         * ada-lang.c (add_nonlocal_symbols)
4891         (ada_collect_symbol_completion_matches)
4892         (ada_add_global_exceptions): Update.
4893
4894 2019-01-15  Tom Tromey  <tom@tromey.com>
4895
4896         * progspace.h (program_space) <objfiles_safe_range>: New
4897         typedef.
4898         <objfiles_safe>: New method.
4899         * objfiles.h (class all_objfiles_safe): Remove.
4900         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
4901         * jit.c (jit_inferior_exit_hook): Update.
4902
4903 2019-01-17  Tom Tromey  <tom@tromey.com>
4904
4905         * progspace.h (program_space) <objfiles_range>: New typedef.
4906         <objfiles>: New method.
4907         <objfiles_head>: Rename from objfiles.
4908         (object_files): Update.
4909         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
4910         * guile/scm-pretty-print.c
4911         (ppscm_find_pretty_printer_from_objfiles): Update.
4912         * guile/scm-objfile.c (gdbscm_objfiles): Update.
4913         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
4914         Update.
4915         * python/py-progspace.c (pspy_get_objfiles): Update.
4916         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
4917         Update.
4918         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
4919         (objfpy_lookup_objfile_by_build_id): Update.
4920         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4921         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
4922         Update.
4923         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4924         (expand_symtab_containing_pc, lookup_objfile_from_block)
4925         (lookup_static_symbol, basic_lookup_transparent_type)
4926         (find_pc_sect_compunit_symtab, find_symbol_at_address)
4927         (find_line_symtab, info_sources_command)
4928         (default_collect_symbol_completion_matches_break_on)
4929         (make_source_files_completion_list, find_main_name): Update.
4930         * symmisc.c (print_symbol_bcache_statistics)
4931         (print_objfile_statistics, maintenance_print_symbols)
4932         (maintenance_print_msymbols, maintenance_print_objfiles)
4933         (maintenance_info_symtabs, maintenance_check_symtabs)
4934         (maintenance_expand_symtabs, maintenance_info_line_tables):
4935         Update.
4936         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
4937         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
4938         (map_overlay_command, unmap_overlay_command)
4939         (simple_overlay_update, expand_symtabs_matching)
4940         (map_symbol_filenames): Update.
4941         * symfile-debug.c (set_debug_symfile): Update.
4942         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
4943         Update.
4944         * source.c (select_source_symtab, forget_cached_source_info):
4945         Update.
4946         * solib.c (solib_read_symbols): Update.
4947         * solib-spu.c (append_ocl_sos): Update.
4948         * psymtab.c (maintenance_print_psymbols)
4949         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
4950         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
4951         * printcmd.c (info_symbol_command): Update.
4952         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
4953         Update.
4954         * objfiles.h (class all_objfiles): Remove.
4955         * objfiles.c (have_partial_symbols, have_full_symbols)
4956         (have_minimal_symbols, qsort_cmp, update_section_map)
4957         (shared_objfile_contains_address_p)
4958         (default_iterate_over_objfiles_in_search_order): Update.
4959         * objc-lang.c (info_selectors_command, info_classes_command)
4960         (find_methods): Update.
4961         * minsyms.c (find_solib_trampoline_target): Update.
4962         * maint.c (maintenance_info_sections)
4963         (maintenance_translate_address, count_symtabs_and_blocks):
4964         Update.
4965         * main.c (captured_main_1): Update.
4966         * linux-thread-db.c (try_thread_db_load_from_pdir)
4967         (has_libpthread): Update.
4968         * linespec.c (iterate_over_all_matching_symtabs)
4969         (search_minsyms_for_name): Update.
4970         * jit.c (jit_find_objf_with_entry_addr): Update.
4971         * hppa-tdep.c (find_unwind_entry)
4972         (hppa_lookup_stub_minimal_symbol): Update.
4973         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
4974         Update.
4975         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
4976         (elf_gnu_ifunc_resolve_by_got): Update.
4977         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
4978         * dwarf-index-write.c (save_gdb_index_command): Update.
4979         * cp-support.c (add_symbol_overload_list_qualified): Update.
4980         * breakpoint.c (create_overlay_event_breakpoint)
4981         (create_longjmp_master_breakpoint)
4982         (create_std_terminate_master_breakpoint)
4983         (create_exception_master_breakpoint): Update.
4984         * blockframe.c (find_pc_partial_function): Update.
4985         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
4986         (ada_collect_symbol_completion_matches)
4987         (ada_add_global_exceptions): Update.
4988
4989 2019-01-17  Tom Tromey  <tom@tromey.com>
4990
4991         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
4992         declare VEC.
4993         (solib_target_parse_libraries): Change return type.
4994         (library_list_start_segment, library_list_start_section)
4995         (library_list_end_library, library_list_start_library); Update.
4996         (solib_target_free_library_list): Remove.
4997         (solib_target_parse_libraries): Remove cleanup.  Change return
4998         type.
4999         (solib_target_current_sos): Update.
5000
5001 2019-01-17  Tom Tromey  <tromey@bapiya>
5002
5003         * valprint.c: Replace "the the" with "the".
5004         * symtab.c: Replace "the the" with "the".
5005         * solib.c: Replace "the the" with "the".
5006         * solib-dsbt.c: Replace "the the" with "the".
5007         * linespec.c: Replace "the the" with "the".
5008         * dwarf2loc.h: Replace "the the" with "the".
5009         * amd64-windows-tdep.c: Replace "the the" with "the".
5010         * aarch64-tdep.c: Replace "the the" with "the".
5011
5012 2019-01-16  Keith Seitz  <keiths@redhat.com>
5013
5014         PR gdb/23773
5015         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5016         <builder>: Rename to ..
5017         <m_builder>: ... this and make private.
5018         (dwarf2_cu::get_builder): New method.  Change all users of
5019         `builder' to use this method.
5020         (dwarf2_start_symtab): Move to ...
5021         (dwarf2_cu::start_symtab): ... here.  Update all callers
5022         (setup_type_unit_groups): Move to ...
5023         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5024         callers.
5025         (dwarf2_cu::reset_builder): New method.
5026         (process_full_compunit, process_full_type_unit): Use
5027         dwarf2_cu::reset_builder.
5028         (follow_die_offset): Record the ancestor CU if it is different
5029         from the followed DIE's CU.
5030         (follow_die_sig_1): Likewise.
5031
5032 2019-01-15  Tom Tromey  <tom@tromey.com>
5033
5034         * remote.c (class remote_state) <buf>: Now a char_vector.
5035         <buf_size>: Remove.
5036         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5037         parameter.
5038         (remote_target::getpkt_or_notif_sane_1)
5039         (remote_target::getpkt_sane)
5040         (remote_target::getpkt_or_notif_sane): Likewise.
5041         (class remote_target) <putpkt>: New overload.
5042         (remote_target::read_frame): Change type of "buf_p".  Remove
5043         sizeof_p parameter.
5044         (packet_ok): New overload.
5045         (packet_check_result): New overload.
5046         Update all uses.
5047
5048 2019-01-14  Tom Tromey  <tom@tromey.com>
5049
5050         * remote-notif.c (handle_notification, remote_notif_ack)
5051         (remote_notif_parse): Make "buf" const.
5052         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5053         const.
5054         (remote_notif_parse, remote_notif_ack, handle_notification):
5055         Likewise.
5056         * remote.c (remote_notif_stop_parse): Make "buf" const.
5057         (remote_target::remote_parse_stop_reply): Make "buf" const.
5058         (remote_notif_stop_ack): Make "buf" const.
5059
5060 2019-01-14  Tom Tromey  <tom@tromey.com>
5061
5062         * remote.c (remote_console_output): Make parameter const.
5063
5064 2019-01-14  Tom Tromey  <tom@tromey.com>
5065
5066         * target-debug.h (target_debug_print_signals): Constify.
5067         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5068         * procfs.c (procfs_target::pass_signals): Update.
5069         * linux-nat.c (linux_nat_target::pass_signals): Update.
5070         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5071         * target-delegates.c: Rebuild.
5072         * remote.c (remote_target::program_signals): Update.
5073         (remote_target::pass_signals): Update.
5074         * target.c (target_pass_signals): Constify argument.
5075         (target_program_signals): Likewise.
5076         * target.h (struct target_ops) <pass_signals, program_signals>:
5077         Constify argument.
5078         (target_pass_signals, target_program_signals): Constify argument.
5079
5080 2019-01-14  Tom Tromey  <tom@tromey.com>
5081
5082         PR tui/28819:
5083         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5084
5085 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5086
5087         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
5088         field.
5089         * rs6000-tdep.c: Include reggroups.h.
5090         (IS_V_ALIAS_PSEUDOREG): Define.
5091         (rs6000_register_name): Return names for the "vX" aliases.
5092         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
5093         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
5094         aliases.  Call default_register_reggroup_p for all other
5095         pseudo-registers.
5096         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
5097         New functions.
5098         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
5099         Handle "vX" aliases.
5100         (v_alias_pseudo_register_collect): New function.
5101         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
5102         (rs6000_gdbarch_init): Initialize "vX" aliases as
5103         pseudo-registers.  Restore registration of
5104         rs6000_pseudo_register_reggroup_p with
5105         set_tdesc_pseudo_register_reggroup_p.
5106
5107 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
5108
5109         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
5110         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
5111         set_gdbarch_num_pseudo_regs.
5112
5113 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5114
5115         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
5116         Remove arg prefixname, add do_set and do_show.
5117         Add member functions set_list and show_list.
5118         * cli/cli-style.c (class cli_style_option): Update accordingly.
5119         (style_set_list): Move to file scope.
5120         (style_show_list): Likewise.
5121         (set_style): Call help_list.
5122         (show_style): Call cmd_show_list.
5123         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
5124         Update to use the new macro.
5125
5126 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5127
5128         * ada-lang.c (_initialize_ada_language): Expand the help text
5129         for the "catch exception" command.
5130
5131 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5132
5133         * symtab.c (matching_obj_sections): Initialize obj,
5134         declare it closer to its usage.
5135
5136 2019-01-10  Tom Tromey  <tom@tromey.com>
5137
5138         * thread-iter.h (inf_threads_iterator): Use next_iterator.
5139         (basic_inf_threads_range): Remove.
5140         (inf_threads_range, inf_non_exited_threads_range)
5141         (safe_inf_threads_range): Use next_adapter.
5142
5143 2019-01-10  Keith Seitz  <keiths@redhat.com>
5144
5145         PR gdb/23712
5146         PR symtab/23010
5147         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
5148         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
5149
5150 2019-01-10  Keith Seitz  <keiths@redhat.com>
5151
5152         PR gdb/23712
5153         PR symtab/23010
5154         * dictionary.c (pending_to_vector): Remove.
5155         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5156         Remove _1 suffix, replacing functions of the same name.  Update
5157         all callers.
5158         (dict_create_hashed, dict_create_hashed_expandable)
5159         (dict_create_linear, dict_create_linear_expandable, dict_free)
5160         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
5161         Make functions static.
5162
5163 2019-01-10  Keith Seitz  <keiths@redhat.com>
5164
5165         PR gdb/23712
5166         PR symtab/23010
5167         * dictionary.h (struct dictionary): Replace declaration with
5168         multidictionary.
5169         (dict_create_hashed, dict_create_hashed_expandable)
5170         (dict_create_linear, dict_create_linear_expandable)
5171         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
5172         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
5173         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
5174         taking multidictionary argument.
5175         [ALL_DICT_SYMBOLS]: Update for multidictionary.
5176         * block.h (struct block) <dict>: Change to multidictionary
5177         and rename `multidict'.
5178         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
5179         symmisc.c: Update all dictionary references to multidictionary.
5180
5181 2019-01-10  Keith Seitz  <keiths@redhat.com>
5182
5183         PR gdb/23712
5184         PR symtab/23010
5185         * dictionary.c: Include unordered_map.
5186         (pending_to_vector): New function.
5187         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5188         Rewrite the non-"_1" functions to take vector instead
5189         of linked list.
5190         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
5191         "new" _1 versions of the same name.
5192         (multidictionary): Define.
5193         (std::hash<enum language): New definition.
5194         (collate_pending_symbols_by_language, mdict_create_hashed)
5195         (mdict_create_hashed_expandable, mdict_create_linear)
5196         (mdict_create_linear_expandable, mdict_free)
5197         (find_language_dictionary, create_new_language_dictionary)
5198         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
5199         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
5200         (mdict_size, mdict_empty): New functions.
5201         * dictionary.h (mdict_iterator): Define.
5202
5203 2019-01-10  Pedro Alves  <palves@redhat.com>
5204
5205         * breakpoint.c (read_uploaded_action)
5206         (create_tracepoint_from_upload): Adjust to use
5207         gdb::unique_xmalloc_ptr.
5208         * ctf.c (ctf_write_uploaded_tp):
5209         (SET_ARRAY_FIELD): Use emplace_back.
5210         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
5211         * tracefile-tfile.c (tfile_write_uploaded_tp):
5212         * tracepoint.c (parse_tracepoint_definition): Adjust to use
5213         gdb::unique_xmalloc_ptr.
5214         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
5215         at_string, cond_string, cmd_strings>: Replace char pointers
5216         with gdb::unique_xmalloc_ptr.
5217
5218 2019-01-10  Pedro Alves  <palves@redhat.com>
5219
5220         * solib-target.c (library_list_start_library): Don't xstrdup name.
5221
5222 2019-01-10  Pedro Alves  <palves@redhat.com>
5223
5224         * mdebugread.c (parse_partial_symbols): Use
5225         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
5226
5227 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5228
5229         * linux-fork.c (scoped_switch_fork_info)
5230         <~scoped_switch_fork_info>: Fix incorrect variable name.
5231
5232 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5233
5234         * linux-fork.c (scoped_switch_fork_info)
5235         <scoped_switch_fork_info>: Make explicit.
5236         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
5237
5238 2019-01-10  Tom Tromey  <tom@tromey.com>
5239
5240         * objfiles.h (objfile::reset_psymtabs): Update.
5241         * objfiles.c (objfile::objfile): Update.
5242         * psymtab.h (psymtab_storage::obstack): Update.
5243         (psymtab_storage::m_obstack): Use gdb::optional.
5244         (class psymtab_storage): Update comment.  Remove objfile
5245         parameter.
5246         * psymtab.c (psymtab_storage::psymtab_storage): Update.
5247
5248 2019-01-10  Tom Tromey  <tom@tromey.com>
5249
5250         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
5251         <free_psymtabs>: Now private.
5252         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
5253         (allocate_psymtab): Use new method.
5254
5255 2019-01-10  Tom Tromey  <tom@tromey.com>
5256
5257         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
5258         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
5259         * mdebugread.c (parse_partial_symbols): Use
5260         allocate_dependencies.
5261         * dwarf2read.c (dwarf2_create_include_psymtab): Use
5262         allocate_dependencies.
5263         (process_psymtab_comp_unit_reader)
5264         (build_type_psymtab_dependencies): Likewise.
5265         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
5266
5267 2019-01-10  Tom Tromey  <tom@tromey.com>
5268
5269         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
5270         PSYMBOL_SET_LANGUAGE.
5271         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
5272
5273 2019-01-10  Tom Tromey  <tom@tromey.com>
5274
5275         * psymtab.h (psymtab_storage::obstack): New method.
5276         <m_obstack>: Rename from obstack; now private.
5277         * psymtab.c (psymtab_storage): Update.
5278         * dwarf2read.c (create_addrmap_from_index)
5279         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
5280         Update.
5281
5282 2019-01-10  Tom Tromey  <tom@tromey.com>
5283
5284         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
5285         * objfiles.h (objfile::reset_psymtabs): New method.
5286
5287 2019-01-10  Tom Tromey  <tom@tromey.com>
5288
5289         * symmisc.c (print_symbol_bcache_statistics): Update.
5290         (print_objfile_statistics): Update.
5291         * symfile.c (reread_symbols): Update.
5292         * psymtab.h (class psymtab_storage): New.
5293         * psymtab.c (psymtab_storage): New constructor.
5294         (~psymtab_storage): New destructor.
5295         (require_partial_symbols): Update.
5296         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
5297         (find_pc_sect_psymtab, find_pc_sect_psymbol)
5298         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
5299         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
5300         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
5301         (start_psymtab_common, end_psymtab_common)
5302         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
5303         (allocate_psymtab): Update.
5304         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
5305         Update.
5306         (dump_psymtab_addrmap, maintenance_print_psymbols)
5307         (maintenance_check_psymtabs): Update.
5308         (class objfile_psymtabs): Move to objfiles.h.
5309         * psympriv.h (discard_psymtab): Now inline.
5310         (psymtab_discarder::psymtab_discarder): Update.
5311         (psymtab_discarder::~psymtab_discarder): Update.
5312         (ALL_OBJFILE_PSYMTABS): Rewrite.
5313         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
5314         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
5315         Remove fields.
5316         <partial_symtabs>: New field.
5317         (class objfile_psymtabs): Move from psymtab.h.  Update.
5318         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
5319         psymbol_cache.
5320         (objfile::~objfile): Don't destroy psymbol_cache.
5321         * mdebugread.c (parse_partial_symbols): Update.
5322         * dwarf2read.c (create_addrmap_from_index)
5323         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5324         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
5325         (add_partial_subprogram, dwarf2_ranges_read): Update.
5326         * dwarf-index-write.c (write_address_map)
5327         (write_one_signatured_type, recursively_write_psymbols)
5328         (class debug_names, class debug_names, write_psymtabs_to_index):
5329         Update.
5330
5331 2019-01-10  Tom Tromey  <tom@tromey.com>
5332
5333         * symtab.h (SYMBOL_SET_NAMES): Update.
5334         (symbol_set_names): Update.
5335         (MSYMBOL_SET_NAMES): Update.
5336         * symtab.c (symbol_set_names): Change argument to be an
5337         objfile_per_bfd_storage.
5338         * psymtab.c (add_psymbol_to_bcache): Update.
5339         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
5340
5341 2019-01-10  Tom Tromey  <tom@tromey.com>
5342
5343         * symtab.c (create_demangled_names_hash): Change argument to be an
5344         objfile_per_bfd_storage.
5345         (symbol_set_names): Update.
5346
5347 2019-01-10  Tom Tromey  <tom@tromey.com>
5348
5349         * xcoffread.c (xcoff_initial_scan): Unconditionally call
5350         init_psymbol_list.
5351         * psymtab.c (init_psymbol_list): Do nothing if already called.
5352         * psympriv.h (init_psymbol_list): Add comment.
5353         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
5354         init_psymbol_list.
5355         * dbxread.c (dbx_symfile_read): Unconditionally call
5356         init_psymbol_list.
5357
5358 2019-01-10  Tom Tromey  <tom@tromey.com>
5359
5360         * xcoffread.c (scan_xcoff_symtab): Update.
5361         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
5362         "where".
5363         * mdebugread.c (parse_partial_symbols)
5364         (handle_psymbol_enumerators): Update.
5365         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
5366         * dbxread.c (read_dbx_symtab): Update.
5367         * psympriv.h (psymbol_placement): New enum.
5368         (add_psymbol_to_list): Update.
5369
5370 2019-01-10  Tom Tromey  <tom@tromey.com>
5371
5372         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
5373         static_psymbols parameters.
5374         (scan_xcoff_symtab): Update.
5375         * psymtab.c (start_psymtab_common): Remove global_psymbols and
5376         static_psymbols parameters.
5377         * psympriv.h (start_psymtab_common): Update.
5378         * mdebugread.c (parse_partial_symbols): Update.
5379         * dwarf2read.c (create_partial_symtab): Update.
5380         * dbxread.c (read_dbx_symtab): Update.
5381         (start_psymtab): Remove global_psymbols and static_psymbols
5382         parameters.
5383
5384 2019-01-10  Tom Tromey  <tom@tromey.com>
5385
5386         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
5387         * psymtab.c (allocate_psymtab): Add comment.
5388         * psympriv.h (allocate_psymtab): Add comment.
5389         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
5390         initializations.
5391         * dbxread.c (dbx_end_psymtab): Remove some initializations.
5392
5393 2019-01-10  Tom Tromey  <tom@tromey.com>
5394
5395         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5396         Don't declare.
5397         * mipsread.c: Include mdebugread.h.
5398         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5399         Declare.
5400         * elfread.c: Include mdebugread.h.
5401
5402 2019-01-09  Tom Tromey  <tom@tromey.com>
5403
5404         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
5405         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
5406         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
5407         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
5408         (psym_lookup_symbol, psym_find_last_source_symtab)
5409         (psym_forget_cached_source_info, psym_print_stats)
5410         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
5411         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
5412         (psym_map_matching_symbols, psym_expand_symtabs_matching)
5413         (psym_find_compunit_symtab_by_address)
5414         (maintenance_print_psymbols, maintenance_info_psymtabs)
5415         (maintenance_check_psymtabs): Use ranged for.
5416         * psymtab.h (class objfile_psymtabs): New.
5417         (require_partial_symbols): Return objfile_psymtabs.
5418         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
5419
5420 2019-01-09  Tom Tromey  <tom@tromey.com>
5421
5422         * symfile.c (overlay_invalidate_all, find_pc_overlay)
5423         (find_pc_mapped_section, list_overlays_command)
5424         (map_overlay_command, unmap_overlay_command)
5425         (simple_overlay_update): Use all_objfiles.
5426         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
5427         * printcmd.c (info_symbol_command): Use all_objfiles.
5428         * objfiles.h (ALL_OBJSECTIONS): Remove.
5429         * maint.c (maintenance_translate_address): Use all_objfiles.
5430         * gcore.c (gcore_create_callback): Use all_objfiles.
5431         (objfile_find_memory_regions): Likewise.
5432
5433 2019-01-09  Tom Tromey  <tom@tromey.com>
5434
5435         * symtab.c (find_line_symtab, info_sources_command)
5436         (make_source_files_completion_list): Use objfile_compunits.
5437         * source.c (select_source_symtab): Use objfile_compunits.
5438         * objfiles.h (struct objfile): Update comment.
5439         (ALL_OBJFILES): Remove.
5440         (ALL_FILETABS): Remove.
5441         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
5442         objfile_compunits.
5443
5444 2019-01-09  Tom Tromey  <tom@tromey.com>
5445
5446         * symmisc.c (print_objfile_statistics, dump_objfile)
5447         (maintenance_print_symbols): Use compunit_filetabs.
5448         * source.c (forget_cached_source_info_for_objfile): Use
5449         compunit_filetabs.
5450         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
5451         (ALL_FILETABS): Use compunit_filetabs.
5452         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
5453         * coffread.c (coff_symtab_read): Use compunit_filetabs.
5454
5455 2019-01-09  Tom Tromey  <tom@tromey.com>
5456
5457         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
5458         (compunit_filetabs): New.
5459         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
5460         compunit_filetabs.
5461         (info_sources_command, make_source_files_completion_list): Remove
5462         declaration.
5463         * symmisc.c (print_objfile_statistics, dump_objfile)
5464         (maintenance_print_symbols): Remove declaration.
5465         (maintenance_info_symtabs): Use compunit_filetabs.
5466         (maintenance_info_line_tables): Likewise.
5467         * source.c (select_source_symtab): Change local variable name.
5468         (forget_cached_source_info_for_objfile): Remove declaration.
5469         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
5470         * objfiles.c (objfile_relocate1): Remove declaration.
5471         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5472         declaration.
5473         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
5474         * coffread.c (coff_symtab_read): Remove declaration.
5475         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5476         compunit_filetabs.
5477
5478 2019-01-09  Tom Tromey  <tom@tromey.com>
5479
5480         * symtab.c (lookup_objfile_from_block)
5481         (find_pc_sect_compunit_symtab, search_symbols)
5482         (default_collect_symbol_completion_matches_break_on): Use
5483         objfile_compunits.
5484         * objfiles.h (ALL_COMPUNITS): Remove.
5485         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
5486         * cp-support.c (add_symbol_overload_list_qualified): Use
5487         objfile_compunits.
5488         * ada-lang.c (ada_collect_symbol_completion_matches)
5489         (ada_add_global_exceptions): Use objfile_compunits.
5490
5491 2019-01-09  Tom Tromey  <tom@tromey.com>
5492
5493         * source.c (select_source_symtab)
5494         (forget_cached_source_info_for_objfile): Remove declaration.
5495         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5496         declaration.
5497         * maint.c (count_symtabs_and_blocks): Remove declaration.
5498         * cp-support.c (add_symbol_overload_list_qualified): Remove
5499         declaration.
5500         * coffread.c (coff_symtab_read): Remove declaration.
5501         * symtab.c (lookup_symbol_in_objfile_symtabs)
5502         (basic_lookup_transparent_type_1): Use objfile_compunits.
5503         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
5504         (info_sources_command, search_symbols)
5505         (default_collect_symbol_completion_matches_break_on)
5506         (make_source_files_completion_list): Remove declaration.
5507         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
5508         (ada_collect_symbol_completion_matches)
5509         (ada_add_global_exceptions): Remove declaration.
5510         * linespec.c (iterate_over_all_matching_symtabs): Use
5511         objfile_compunits.
5512         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
5513         (class objfile_compunits): New.
5514         (ALL_COMPUNITS): Use objfile_compunits.
5515         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
5516         (maintenance_check_symtabs, maintenance_info_line_tables): Use
5517         objfile_compunits.
5518         * objfiles.c (objfile_relocate1): Use objfile_compunits.
5519
5520 2019-01-09  Tom Tromey  <tom@tromey.com>
5521
5522         * symtab.c (search_symbols)
5523         (default_collect_symbol_completion_matches_break_on): Use
5524         objfile_msymbols.
5525         * ada-lang.c (ada_lookup_simple_minsym)
5526         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
5527         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
5528         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
5529         objfile_msymbols.
5530         * coffread.c (coff_symfile_read): Use objfile_msymbols.
5531         * symmisc.c (dump_msymbols): Use objfile_msymbols.
5532         * objc-lang.c (find_methods): Use objfile_msymbols.
5533         (info_selectors_command, info_classes_command): Likewise.
5534         * stabsread.c (scan_file_globals): Use objfile_msymbols.
5535         * objfiles.h (class objfile_msymbols): New.
5536         (ALL_OBJFILE_MSYMBOLS): Remove.
5537         (ALL_MSYMBOLS): Remove.
5538
5539 2019-01-09  Tom Tromey  <tom@tromey.com>
5540
5541         * common/next-iterator.h (next_adapter): Add Iterator template
5542         parameter.
5543         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
5544         (class all_objfiles_safe): New.
5545         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
5546         * objfiles.c (put_objfile_before): Update comment.
5547         (add_separate_debug_objfile): Likewise.
5548         (free_all_objfiles): Use all_objfiles_safe.
5549         (objfile_purge_solibs): Likewise.
5550
5551 2019-01-09  Tom Tromey  <tom@tromey.com>
5552
5553         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5554         (expand_symtab_containing_pc, lookup_static_symbol)
5555         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
5556         (find_symbol_at_address, find_line_symtab, find_main_name): Use
5557         all_objfiles.
5558         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
5559         * breakpoint.c (create_overlay_event_breakpoint)
5560         (create_longjmp_master_breakpoint)
5561         (create_std_terminate_master_breakpoint)
5562         (create_exception_master_breakpoint): Use all_objfiles.
5563         * linux-thread-db.c (try_thread_db_load_from_pdir)
5564         (has_libpthread): Use all_objfiles.
5565         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
5566         * linespec.c (iterate_over_all_matching_symtabs)
5567         (search_minsyms_for_name): Use all_objfiles.
5568         * maint.c (maintenance_info_sections): Use all_objfiles.
5569         * main.c (captured_main_1): Use all_objfiles.
5570         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
5571         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
5572         * guile/scm-pretty-print.c
5573         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
5574         * solib-spu.c (append_ocl_sos): Use all_objfiles.
5575         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
5576         (maintenance_print_msymbols): Use all_objfiles.
5577         * source.c (select_source_symtab): Use all_objfiles.
5578         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
5579         * symfile.c (remove_symbol_file_command)
5580         (expand_symtabs_matching, map_symbol_filenames): Use
5581         all_objfiles.
5582         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
5583         all_objfiles.
5584         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
5585         * objc-lang.c (find_methods): Use all_objfiles.
5586         * objfiles.c (have_partial_symbols, have_full_symbols)
5587         (have_minimal_symbols, qsort_cmp)
5588         (default_iterate_over_objfiles_in_search_order): Use
5589         all_objfiles.
5590         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
5591         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
5592         (maintenance_check_psymtabs): Use all_objfiles.
5593         (ALL_PSYMTABS): Remove.
5594         * compile/compile-object-run.c (do_module_cleanup): Use
5595         all_objfiles.
5596         * blockframe.c (find_pc_partial_function): Use all_objfiles.
5597         * cp-support.c (add_symbol_overload_list_qualified): Use
5598         all_objfiles.
5599         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5600         Use all_objfiles.
5601         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
5602         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
5603         all_objfiles.
5604         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5605         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
5606         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5607         Uses all_objfiles.
5608         * solib.c (solib_read_symbols): Use all_objfiles
5609
5610 2019-01-09  Tom Tromey  <tom@tromey.com>
5611
5612         * probe.c (parse_probes_in_pspace): Use all_objfiles.
5613         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
5614         all_objfiles.
5615         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
5616         * symmisc.c (print_symbol_bcache_statistics)
5617         (print_objfile_statistics, maintenance_print_objfiles)
5618         (maintenance_info_symtabs, maintenance_check_symtabs)
5619         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
5620         all_objfiles.
5621         * source.c (forget_cached_source_info): Use all_objfiles.
5622         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
5623         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5624         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
5625         * objfiles.c (update_section_map): Use all_objfiles.
5626         (shared_objfile_contains_address_p): Likewise.
5627         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
5628         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
5629
5630 2019-01-09  Tom Tromey  <tom@tromey.com>
5631
5632         * common/next-iterator.h: New file.
5633         * objfiles.h (class all_objfiles): New.
5634         (struct objfile_iterator): New.
5635
5636 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5637
5638         * NEWS: Move the description of the changed "frame", "select-frame",
5639          and "info frame" commands to the Changed commands section.
5640
5641 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
5642
5643         * gdbtypes.c (check_stub_method_group): Remove handling of old
5644         mangling schemes.
5645         * linespec.c (find_methods): Likewise.
5646         * stabsread.c (read_member_functions): Likewise.
5647         * valops.c (search_struct_method): Likewise.
5648         (value_struct_elt_for_reference): Likewise.
5649         * NEWS: Mention this change.
5650
5651 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5652
5653         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
5654         print_source_lines.
5655         * source.c (print_source_lines_base): Update line number check.
5656         (print_source_lines): New function.
5657         (source_lines_range::source_lines_range): New function.
5658         * source.h (class source_lines_range): New class.
5659         (print_source_lines): New declaration.
5660
5661 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5662
5663         * linespec.c (linespec_state_destructor): Free self->canonical_names.
5664
5665 2019-01-08  Tom Tromey  <tom@tromey.com>
5666             Simon Marchi  <simon.marchi@ericsson.com>
5667
5668         PR gdb/24060
5669         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
5670         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
5671         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5672         * f-exp.y (DOLLAR_VARIABLE): Likewise.
5673         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
5674         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5675
5676 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5677
5678         * source.c (select_source_symtab): Move header comment to
5679         declaration in source.h.
5680         (forget_cached_source_info_for_objfile): Likewise.
5681         (forget_cached_source_info): Likewise.
5682         (identify_source_line): Likewise.
5683         * source.h (identify_source_line): Move declaration from symtab.h
5684         and add comment from source.c
5685         (print_source_lines): Likewise.
5686         (forget_cached_source_info_for_objfile): Likewise.
5687         (forget_cached_source_info): Likewise.
5688         (select_source_symtab): Likewise.
5689         (enum print_source_lines_flag): Move definition from symtab.h.
5690         * symtab.h (identify_source_line): Move declaration to source.h.
5691         (print_source_lines): Likewise.
5692         (forget_cached_source_info_for_objfile): Likewise.
5693         (forget_cached_source_info): Likewise.
5694         (select_source_symtab): Likewise.
5695         (enum print_source_lines_flag): Move definition to source.h.
5696         * tui/tui-hooks.c: Add 'source.h' include.
5697
5698 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5699
5700         * source.c (print_source_lines_base): Handle requests to print
5701         reverse line number sequences, and guard against empty lines
5702         string.
5703
5704 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5705
5706         * source.c (print_source_lines_base): Fix skip of '\r' if next
5707         character is '\n'.
5708
5709 2019-01-06  Tom Tromey  <tom@tromey.com>
5710
5711         * c-exp.y (struct c_parse_state) <macro_original_text,
5712         expansion_obstack>: New member.
5713         (macro_original_text, expansion_obstack): Remove globals.
5714         (scan_macro_expansion, scanning_macro_expansion)
5715         (finished_macro_expansion): Update.
5716         (scan_macro_cleanup): Remove.
5717         (yylex, c_parse): Update.
5718
5719 2019-01-06  Tom Tromey  <tom@tromey.com>
5720
5721         * c-exp.y (struct c_parse_state) <strings>: New member.
5722         (operator_stoken): Update.
5723
5724 2019-01-06  Tom Tromey  <tom@tromey.com>
5725
5726         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
5727         (union type_stack_elt) <typelist_val>: Now a pointer to
5728         std::vector.
5729         (type_stack_cleanup): Don't declare.
5730         (push_typelist): Update.
5731         * parse.c (pop_typelist): Return a std::vector.
5732         (push_typelist): Take a std::vector.
5733         (follow_types): Update.  Do not free args.
5734         (type_stack_cleanup): Remove.
5735         * c-exp.y (struct c_parse_state): New.
5736         (cpstate): New global.
5737         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
5738         (nonempty_typelist): Update.
5739         (func_mod): Create a new vector.
5740         (c_parse): Create a c_parse_state.
5741         (check_parameter_typelist): Do not delete params.
5742         (function_method): Update.  Do not delete type_list.
5743
5744 2019-01-06  Tom Tromey  <tom@tromey.com>
5745
5746         PR gdb/28155:
5747         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
5748         check_typedef.
5749         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
5750         (print_return_value): Likewise.
5751
5752 2019-01-05  Tom Tromey  <tom@tromey.com>
5753
5754         * contrib/cleanup_check.py: Remove.
5755         * contrib/gcc-with-excheck: Remove.
5756         * contrib/exsummary.py: Remove.
5757         * contrib/excheck.py: Remove.
5758
5759 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
5760
5761         * thread.c (delete_thread_1): Add gdb_assert that THR is not
5762         NULL. Initialize tpprev to NULL instead of assigning it
5763         to NULL on the next statement.
5764         * windows-nat.c (windows_delete_thread): Remove check for
5765         main_thread_id before printing thread exit notifications.
5766         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
5767         Remove thread ID check against main_thread_id.
5768         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
5769         windows_delete_thread.
5770         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
5771
5772 2019-01-04  Tom Tromey  <tom@tromey.com>
5773
5774         * compile/compile.c (_initialize_compile): Use upper case for
5775         metasyntactic variables.
5776         * symmisc.c (_initialize_symmisc): Use upper case for
5777         metasyntactic variables.
5778         * psymtab.c (_initialize_psymtab): Use upper case for
5779         metasyntactic variables.
5780         * demangle.c (demangle_command): Use upper case for metasyntactic
5781         variables.
5782         (_initialize_demangler): Likewise.
5783         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
5784         variables.
5785
5786 2019-01-03  Tom Tromey  <tom@tromey.com>
5787
5788         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
5789
5790 2019-01-03  Tom Tromey  <tom@tromey.com>
5791
5792         * python/py-symtab.c (salpy_str): Update.
5793         (struct salpy_sal_object) <symtab>: Now a PyObject.
5794         (salpy_dealloc): Update.
5795         (del_objfile_sal): Use gdbpy_ref.
5796
5797 2019-01-03  Tom Tromey  <tom@tromey.com>
5798
5799         * python/py-type.c (convert_field): Use new_reference.  Return
5800         gdbpy_ref.
5801         (make_fielditem): Return gdbpy_ref.
5802         (typy_fields): Update.
5803         (typy_getitem): Update.
5804         (field_name): Return gdbpy_ref.  Use new_reference.
5805         (typy_iterator_iternext): Update.
5806
5807 2019-01-03  Tom Tromey  <tom@tromey.com>
5808
5809         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
5810
5811 2019-01-03  Tom Tromey  <tom@tromey.com>
5812
5813         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
5814         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
5815         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
5816         (pspy_set_frame_filters, pspy_set_frame_unwinders)
5817         (pspy_set_type_printers): Likewise.
5818         * python/py-function.c (fnpy_init): Use gdbpy_ref.
5819         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
5820         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
5821         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
5822         (objfpy_set_type_printers): Likewise.
5823
5824 2019-01-03  Tom Tromey  <tom@tromey.com>
5825
5826         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
5827         (gdbpy_print_stack): Use gdbpy_err_fetch.
5828         * python/python-internal.h (class gdbpy_err_fetch): New class.
5829         (class gdbpy_enter) <m_error_type, m_error_value,
5830         m_error_traceback>: Remove.
5831         <m_error>: New member.
5832         (gdbpy_exception_to_string): Don't declare.
5833         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
5834         * python/py-value.c (convert_value_from_python): Use
5835         gdbpy_err_fetch.
5836         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
5837         gdbpy_exception_to_string.
5838         (gdbpy_handle_exception): Use gdbpy_err_fetch.
5839         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
5840         gdbpy_err_fetch.
5841
5842 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5843
5844         * linux-nat.c (delete_lwp_cleanup): Delete.
5845         (struct lwp_deleter): New struct.
5846         (lwp_info_up): New typedef.
5847         (linux_nat_target::follow_fork): Delete cleanup, and make use of
5848         lwp_info_up.
5849
5850 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5851
5852         * linux-fork.c (class scoped_switch_fork_info): New class.
5853         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
5854
5855 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5856
5857         * valops.c (find_overload_match): Remove use of null_cleanup, and
5858         calls to do_cleanups.
5859
5860 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5861
5862         * compile/compile-cplus-types.c
5863         (compile_cplus_instance::decl_name): Handle changes to
5864         cp_func_name.
5865         * cp-support.c (cp_func_name): Update header comment, update
5866         return type.
5867         * cp-support.h (cp_func_name): Update return type in declaration.
5868         * valops.c (find_overload_match): Move temp_func local to top
5869         level of function and change its type.  Use temp_func to hold and
5870         delete temporary string obtained from cp_func_name.
5871
5872 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5873
5874         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
5875         gdb::char_vector, remove cleanup, and update uses of `msg`.
5876
5877 2019-01-03  Jim Wilson  <jimw@sifive.com>
5878
5879         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
5880
5881 2019-01-02  Tom Tromey  <tom@tromey.com>
5882
5883         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
5884         (tdesc_parse_xml): Remove cleanups.
5885         * target-descriptions.h (make_cleanup_free_target_description):
5886         Don't declare.
5887         (target_desc_deleter): New struct.
5888         (target_desc_up): New typedef.
5889         * target-descriptions.c (target_desc_deleter::operator()): Rename
5890         from free_target_description.
5891         (make_cleanup_free_target_description): Remove.
5892
5893 2019-01-02  Tom Tromey  <tom@tromey.com>
5894
5895         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
5896         constructor, destructor.
5897         (linespec_parser): Remove typedef.
5898         (~linespec_parser): Rename from linespec_parser_delete.
5899         (linespec_lex_to_end, linespec_complete_label)
5900         (linespec_complete): Update.
5901         (decode_line_full): Remove cleanups.
5902         (decode_line_1): Update.
5903
5904 2019-01-02  Tom Tromey  <tom@tromey.com>
5905
5906         * python/python-internal.h (inferior_to_inferior_object): Change
5907         return type.
5908         * python/py-exitedevent.c (create_exited_event_object): Update.
5909         * python/py-inferior.c (inferior_to_inferior_object): Return
5910         gdbpy_ref.
5911         (python_new_inferior, python_inferior_deleted)
5912         (thread_to_thread_object, delete_thread_object)
5913         (build_inferior_list, gdbpy_selected_inferior): Update.
5914         * python/py-infthread.c (create_thread_object): Update.  Also fail
5915         if inferior_to_inferior_object fails.
5916
5917 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
5918
5919         * inferior.h (class inferior) <displaced_step_state>: New field.
5920         * infrun.h (struct displaced_step_state): Move here from
5921         infrun.c.  Initialize fields, add constructor.
5922         <inf>: Remove field.
5923         <reset>: New method.
5924         * infrun.c (struct displaced_step_inferior_state): Move to
5925         infrun.h.
5926         (displaced_step_inferior_states): Remove.
5927         (get_displaced_stepping_state): Adust.
5928         (displaced_step_in_progress_any_inferior): Adjust.
5929         (displaced_step_in_progress_thread): Adjust.
5930         (displaced_step_in_progress): Adjust.
5931         (add_displaced_stepping_state): Remove.
5932         (get_displaced_step_closure_by_addr): Adjust.
5933         (remove_displaced_stepping_state): Remove.
5934         (infrun_inferior_exit): Call displaced_step_state.reset.
5935         (use_displaced_stepping): Don't check for NULL.
5936         (displaced_step_prepare_throw): Call
5937         get_displaced_stepping_state.
5938         (displaced_step_fixup): Don't check for NULL.
5939         (prepare_for_detach): Don't check for NULL.
5940
5941 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5942
5943         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
5944          in case of call that did not complete.
5945
5946 2019-01-02  Andrey Utkin  <autkin@undo.io>
5947
5948         * symfile.c (find_separate_debug_file): Fix search of debug files for
5949         remote debuggee.
5950
5951 2019-01-02  Tom Tromey  <tom@tromey.com>
5952
5953         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
5954         indentation.
5955         * python/py-frame.c (frapy_older): Remove cast.
5956         (frapy_newer): Likewise.
5957         * python/py-breakpoint.c (local_setattro): Remove cast.
5958         * python/py-arch.c (archpy_name): Remove local variable.
5959         * python/py-type.c (gdbpy_lookup_type): Remove cast.
5960
5961 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
5962
5963         * unittests/basic_string_view/element_access/char/empty.cc:
5964         Fix year range in copyright header.
5965
5966 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5967
5968         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
5969         Delete.
5970         <operator==>: Update with for removed field.
5971         <hash>: Likewise.
5972         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
5973         <isa_features>: ...this.
5974         <abi_features>: New field.
5975         (riscv_isa_flen): Update comment.
5976         (riscv_abi_xlen): New declaration.
5977         (riscv_abi_flen): New declaration.
5978         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
5979         isa_features.
5980         (riscv_abi_xlen): New function.
5981         (riscv_isa_flen): Update to get answer from isa_features.
5982         (riscv_abi_flen): New function.
5983         (riscv_has_fp_abi): Update to get answer from abi_features.
5984         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
5985         xlen and flen.
5986         (riscv_call_info) <xlen, flen>: Update comment.
5987         (riscv_call_arg_struct): Remove invalid assertions
5988         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
5989         is removed.
5990         (riscv_gdbarch_init): Gather isa features and abi features
5991         separately, ensure both match on the gdbarch when reusing an old
5992         gdbarch.  Relax an error check to allow 32-bit abi float to run on
5993         a target with 64-bit float hardware.
5994
5995 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5996
5997         * source.c (search_command_helper): Stop reverse search
5998         when line 1 has been searched.
5999
6000 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6001
6002         * record-full.c (record_full_base_target::close): Rewrite
6003         record_full_core_buf_list free logic.
6004
6005 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6006
6007         * break-catch-syscall.c (print_one_catch_syscall): xfree
6008         the last text.
6009
6010 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6011
6012         * top.c (print_gdb_version): Update Copyright year in version
6013         message.
6014
6015 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6016
6017         Update copyright year range in all GDB files.
6018
6019 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6020
6021         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6022
6023 For older changes see ChangeLog-2018.
6024 \f
6025 Local Variables:
6026 mode: change-log
6027 left-margin: 8
6028 fill-column: 74
6029 version-control: never
6030 coding: utf-8
6031 End:
6032