gdb/ChangeLog

   1 2019-03-29  Keith Seitz  <keiths@redhat.com>
   2
   3         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
   4         %s/pulongest for TYPE_LENGTH instead of %d in format
   5         strings.
   6         * ada-typerint.c (ada_print_type): Likewise.
   7         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
   8         * compile/compile-c-support.c (generate_register_struct): Likewise.
   9         * gdbtypes.c (recursive_dump_type): Likewise.
  10         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
  11         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
  12         instead of %d in format strings.
  13         * riscv-tdep.c (riscv_type_alignment): Cast second argument
  14         to std::min to ULONGEST.
  15         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
  16         instead of %d in format strings.
  17         * tracepoint.c (info_scope_command): Likewise.
  18         * typeprint.c (print_offset_data::update)
  19         (print_offset_data::finish): Likewise.
  20         * xtensa-tdep.c (xtensa_store_return_value)
  21         (xtensa_push_dummy_call): Likewise.
  22
  23 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
  24
  25         * windows-nat.c (display_selector): Fixed format specifications
  26         for 64-bit Cygwin.
  27
  28 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  29
  30         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
  31
  32 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
  33
  34         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
  35         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
  36         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
  37         (nios2_linux_init_abi): Install it.
  38
  39 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
  40
  41         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
  42
  43 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
  44
  45         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
  46
  47 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  48             Tom Tromey  <tromey@adacore.com>
  49
  50         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
  51
  52 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
  53
  54         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
  55         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
  56         method to compute the bounds of range types. Also print "[evaluated]"
  57         if the bounds' values come from a dynamic evaluation.
  58
  59 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
  60
  61         * cp-valprint.c (cp_print_value_fields): Don't print trailing
  62         whitespace when pretty printing is on.
  63
  64 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
  65
  66         * ppc-linux-nat.c: Add include.
  67
  68 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
  69
  70         * NEWS: Mention AArch64 Pointer Authentication.
  71
  72 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
  73
  74         * arm-linux-nat.c: Add include.
  75
  76 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
  77
  78         * source-cache.c (source_cache::get_source_lines): Re-read
  79         fullname after calling open_source_file.
  80
  81 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
  82
  83         * NEWS: Mention TLS support for FreeBSD.
  84
  85 2019-03-25  Tom Tromey  <tromey@adacore.com>
  86
  87         * minsyms.c (BUNCH_SIZE): Update comment.
  88         (~minimal_symbol_reader): Remove old comment.
  89         (compact_minimal_symbols): Update comment.
  90         (minimal_symbol_reader::install): Remove old comment.  Update
  91         other comments.
  92
  93 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
  94
  95         * s390-linux-nat.c: Add include.
  96
  97 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
  98
  99         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 100         Call linux_get_hwcap.
 101         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
 102         Likewise.
 103         (aarch64_linux_get_hwcap): Remove function.
 104         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
 105         declaration.
 106         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
 107         linux_get_hwcap.
 108         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 109         * linux-tdep.c (linux_get_hwcap): Add function.
 110         (linux_get_hwcap2): Likewise.
 111         * linux-tdep.h (linux_get_hwcap): Add declaration.
 112         (linux_get_hwcap2): Likewise.
 113         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
 114         (ppc_linux_get_hwcap2): Likewise.
 115         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
 116         linux_get_hwcap.
 117         (ppc_linux_nat_target::insert_watchpoint): Likewise.
 118         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
 119         (ppc_linux_nat_target::read_description): Likewise.
 120         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
 121         * s390-linux-nat.c: Likewise.
 122         * s390-linux-tdep.c (s390_core_read_description): Likewise.
 123
 124 2019-03-24  Tom Tromey  <tom@tromey.com>
 125
 126         * ada-lang.c (standard_lookup): Simplify initialization.
 127         (ada_lookup_symbol_nonlocal): Simplify return.
 128         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
 129         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
 130         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
 131         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
 132         initialization.
 133         * solib.c (solib_global_lookup): Simplify.
 134         * symtab.c (null_block_symbol): Remove.
 135         (symbol_cache_lookup): Simplify returns.
 136         (lookup_language_this): Simplify returns.
 137         (lookup_symbol_aux): Simplify return.
 138         (lookup_local_symbol): Simplify returns.
 139         (lookup_global_symbol_from_objfile): Simplify return.
 140         (lookup_symbol_in_objfile_symtabs)
 141         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
 142         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
 143         (lookup_static_symbol, lookup_global_symbol): Simplify return.
 144         * cp-namespace.c (cp_lookup_bare_symbol)
 145         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
 146         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
 147         (cp_lookup_nested_symbol): Don't use null_block_symbol.
 148         (cp_lookup_symbol_via_imports): Simplify initialization.
 149         (find_symbol_in_baseclass): Likewise.
 150         * symtab.h (null_block_symbol): Remove.
 151         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
 152         (d_lookup_nested_symbol, d_lookup_symbol_imports)
 153         (d_lookup_symbol_module): Likewise.
 154         (find_symbol_in_baseclass): Simplify initialization.
 155
 156 2019-03-24  Tom Tromey  <tom@tromey.com>
 157
 158         * expression.h: Don't include symtab.h.
 159         (struct block): Forward declare.
 160
 161 2019-03-24  Tom Tromey  <tom@tromey.com>
 162
 163         * c-exp.y (typebase): Remove casts.
 164         * gdbtypes.c (lookup_unsigned_typename, )
 165         (lookup_signed_typename): Remove cast.
 166         * eval.c (parse_to_comma_and_eval): Remove cast.
 167         * parse.c (write_dollar_variable): Remove cast.
 168         * block.h (struct block) <superblock>: Now const.
 169         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
 170         * psymtab.c (psym_map_matching_symbols): Make "block" const.
 171         (map_block): Make "block" const.
 172         * symfile.h (struct quick_symbol_functions)
 173         <map_matching_symbols>: Constify block argument to "callback".
 174         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
 175         const.
 176         (find_pc_sect_compunit_symtab): Make "b" const.
 177         (find_symbol_at_address): Likewise.
 178         (search_symbols): Likewise.
 179         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
 180         (dw2_debug_names_lookup_symbol): Likewise.
 181         (dw2_map_matching_symbols): Update.
 182         * p-valprint.c (pascal_val_print): Remove "block".
 183         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
 184         (aux_add_nonlocal_symbols): Make "block" const.
 185         (resolve_subexp): Remove cast.
 186         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
 187         const.
 188         (iterate_over_file_blocks): Likewise.
 189         * f-exp.y (%union) <bval>: Remove.
 190         * coffread.c (patch_opaque_types): Make "b" const.
 191         * spu-tdep.c (spu_catch_start): Make "block" const.
 192         * c-valprint.c (print_unpacked_pointer): Remove "block".
 193         * symmisc.c (dump_symtab_1): Make "b" const.
 194         (block_depth): Make "block" const.
 195         * d-exp.y (%union) <bval>: Remove.
 196         * cp-support.h (cp_lookup_rtti_type): Update.
 197         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
 198         * psymtab.c (psym_lookup_symbol): Make "block" const.
 199         (maintenance_check_psymtabs): Make "b" const.
 200         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
 201         (enumerate_locals, enumerate_args): Update.
 202         * python/py-symtab.c (stpy_global_block): Make "block" const.
 203         (stpy_static_block): Likewise.
 204         * inline-frame.c (block_starting_point_at): Make "new_block"
 205         const.
 206         * block.c (find_block_in_blockvector): Make return type const.
 207         (blockvector_for_pc_sect): Make "b" const.
 208         (find_block_in_blockvector): Make "b" const.
 209
 210 2019-03-23  Tom Tromey  <tom@tromey.com>
 211
 212         * varobj.c (varobj_create): Update.
 213         * symfile.c (clear_symtab_users): Don't reset innermost_block.
 214         * printcmd.c (display_command, do_one_display): Don't reset
 215         innermost_block.
 216         * parser-defs.h (enum innermost_block_tracker_type): Move to
 217         expression.h.
 218         (innermost_block): Update comment.
 219         * parse.c (parse_exp_1): Add tracker_types parameter.
 220         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
 221         tracker_types parameter.  Reset innermost_block.
 222         (parse_exp_in_context): Remove.
 223         (parse_expression_for_completion): Update.
 224         * objfiles.c (~objfile): Don't reset expression_context_block or
 225         innermost_block.
 226         * expression.h (enum innermost_block_tracker_type): Move from
 227         parser-defs.h.
 228         (parse_exp_1): Add tracker_types parameter.
 229         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
 230         reset innermost_block.
 231
 232 2019-03-23  Tom Tromey  <tom@tromey.com>
 233
 234         * objfiles.h: Include bcache.h.
 235
 236 2019-03-23  Tom Tromey  <tom@tromey.com>
 237
 238         * linespec.c (get_current_search_block): Use
 239         scoped_restore_current_language.
 240         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
 241
 242 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 243             Jiong Wang  <jiong.wang@arm.com>
 244
 245         * aarch64-linux-tdep.c
 246         (aarch64_linux_iterate_over_regset_sections): Check for pauth
 247         section.
 248         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
 249
 250 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 251             Jiong Wang  <jiong.wang@arm.com>
 252
 253         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
 254         instructions.
 255         (aarch64_analyze_prologue_test): Add PACIASP test.
 256         (aarch64_prologue_prev_register): Unmask PC value.
 257
 258 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 259             Jiong Wang  <jiong.wang@arm.com>
 260
 261         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
 262         (aarch64_dwarf2_prev_register): Unmask PC value.
 263         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
 264         (aarch64_execute_dwarf_cfa_vendor_op): Check for
 265         DW_CFA_AARCH64_negate_ra_state.
 266         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
 267
 268 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 269             Jiong Wang  <jiong.wang@arm.com>
 270
 271         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
 272         registers.
 273         (aarch64_pseudo_register_name): Likewise.
 274         (aarch64_pseudo_register_type): Likewise.
 275         (aarch64_pseudo_register_reggroup_p): Likewise.
 276         (aarch64_gdbarch_init): Add pauth registers.
 277         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
 278         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
 279         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
 280         (struct gdbarch_tdep): Add regnum for ra_state.
 281
 282 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 283             Jiong Wang  <jiong.wang@arm.com>
 284
 285         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
 286
 287 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 288             Jiong Wang  <jiong.wang@arm.com>
 289
 290         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
 291         function.
 292         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
 293         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
 294         (aarch64_gdbarch_init): Add puth registers.
 295         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
 296         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
 297         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
 298
 299 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 300             Jiong Wang  <jiong.wang@arm.com>
 301
 302         * aarch64-linux-nat.c
 303         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
 304         * aarch64-linux-tdep.c
 305         (aarch64_linux_core_read_description): Likewise.
 306         (aarch64_linux_get_hwcap): New function.
 307         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
 308         (aarch64_linux_get_hwcap): New declaration.
 309
 310 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 311             Jiong Wang  <jiong.wang@arm.com>
 312
 313         * aarch64-linux-nat.c
 314         (aarch64_linux_nat_target::read_description): Add pauth param.
 315         * aarch64-linux-tdep.c
 316         (aarch64_linux_core_read_description): Likewise.
 317         * aarch64-tdep.c (struct target_desc): Add in pauth.
 318         (aarch64_read_description): Add pauth param.
 319         (aarch64_gdbarch_init): Likewise.
 320         * aarch64-tdep.h (aarch64_read_description): Likewise.
 321         * arch/aarch64.c (aarch64_create_target_description): Likewise.
 322         * arch/aarch64.h (aarch64_create_target_description): Likewise.
 323         * features/Makefile: Add new files.
 324         * features/aarch64-pauth.c: New file.
 325         * features/aarch64-pauth.xml: New file.
 326
 327 2019-03-20  Tom Tromey  <tromey@adacore.com>
 328
 329         * infrun.c (handle_inferior_event): Rename from
 330         handle_inferior_event_1.  Create a scoped_value_mark.
 331         (handle_inferior_event): Remove.
 332
 333 2019-03-19  Tom Tromey  <tromey@adacore.com>
 334
 335         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
 336         * infrun.h (print_stop_event): Add "displays" parameter.
 337         * infrun.c (print_stop_event): Add "displays" parameter.
 338
 339 2019-03-19  Pedro Alves  <palves@redhat.com>
 340
 341         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
 342         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
 343         to -1.  Fix TABs vs spaces.
 344         (tui_ui_out::tui_ui_out): Don't initialize fields here.
 345         * tui/tui-out.h (tui_ui_out) Add intro comments.
 346         <m_line, m_start_of_line>: In-class initialize, and add describing
 347         comment.
 348
 349 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
 350
 351         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
 352         variable names.
 353         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
 354
 355 2019-03-18  Pedro Alves  <palves@redhat.com>
 356             Eli Zaretskii <eliz@gnu.org>
 357
 358         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
 359         m_line and m_start_of_line.
 360
 361 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
 362
 363         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
 364         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
 365         it returns a newline.  This fixes a regression in TU mode, whereby
 366         the next line is output on the same screen line as the user input.
 367
 368 2019-03-18  Tom Tromey  <tromey@adacore.com>
 369
 370         * minsyms.c (minimal_symbol_reader::install): Remove call to
 371         obstack_blank.
 372
 373 2019-03-18  Pedro Alves  <palves@redhat.com>
 374
 375         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
 376         New globals.
 377         (apply_style): New, factored out from ...
 378         (apply_ansi_escape): ... this.  Handle reverse video mode.
 379         (tui_set_reverse_mode): New function.
 380         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
 381         * tui/tui-winsource.c (tui_show_source_line): Use
 382         tui_set_reverse_mode instead of setting A_STANDOUT.
 383         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
 384         New setter methods.
 385
 386 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
 387
 388         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
 389         Handle tabs.
 390
 391 2019-03-18  Tom Tromey  <tromey@adacore.com>
 392
 393         * ada-lang.c (empty_array): Add "high" parameter.
 394         (ada_evaluate_subexp): Update.
 395
 396 2019-03-17  Sergei Trofimovich <siarheit@google.com>
 397
 398         * unittests/string_view-selftests.c: Define
 399         _initialize_string_view_selftests unconditionally.
 400
 401 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 402
 403         PR gdb/24350
 404         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
 405
 406 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 407
 408         PR gdb/24351
 409         * windows-nat.c (display_selector): Fix format specifiers.
 410
 411 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
 412
 413         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
 414         tui_refill_source_window instead of tui_refresh_win, to update the
 415         current execution line.  This fixes redisplay of the current line
 416         when stepping through the code with "next" or "step".
 417
 418 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 419
 420         * source-cache.c (source_cache::get_source_lines): Call
 421         find_source_lines to initialize s->nlines.  This fixes vertical
 422         scrolling of TUI source window when the DOWN arrow is pressed.
 423
 424 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 425
 426         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
 427         linux-thread-db.c (_initialize_thread_db): Likewise.
 428
 429 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 430
 431         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
 432         wclrtoeol in tui_show_source_line".  This reverts changes made in
 433         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
 434
 435 2019-03-15  Tom Tromey  <tom@tromey.com>
 436
 437         * symtab.h (struct minimal_symbol): Derive from
 438         general_symbol_info.
 439         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
 440         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
 441         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
 442         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
 443         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
 444         (MSYMBOL_SEARCH_NAME): Update.
 445         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
 446         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
 447         * minsyms.c (minimal_symbol_reader::record_full): Update.
 448
 449 2019-03-15  Tom Tromey  <tom@tromey.com>
 450
 451         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
 452
 453 2019-03-15  Tom Tromey  <tom@tromey.com>
 454
 455         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
 456         unique_xmalloc_ptr.
 457         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
 458         Update.
 459         * minsyms.c (lookup_minimal_symbol_by_pc_section)
 460         (build_minimal_symbol_hash_tables)
 461         (minimal_symbol_reader::install): Update.
 462
 463 2019-03-15  Tom Tromey  <tom@tromey.com>
 464
 465         * symtab.c (create_demangled_names_hash): Update.
 466         (symbol_set_names): Update.
 467         * objfiles.h (struct objfile_per_bfd_storage)
 468         <demangled_names_hash>: Now an htab_up.
 469         * objfiles.c (objfile_per_bfd_storage): Simplify.
 470
 471 2019-03-15  Tom Tromey  <tom@tromey.com>
 472
 473         * objfiles.h (struct objfile_per_bfd_storage): Declare
 474         destructor.
 475         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
 476         New.
 477         (get_objfile_bfd_data): Use new.  Don't initialize
 478         language_of_main.
 479         (free_objfile_per_bfd_storage): Remove.
 480         (objfile_bfd_data_free, objfile::~objfile): Use delete.
 481
 482 2019-03-15  Tom Tromey  <tom@tromey.com>
 483
 484         * symfile.c (reread_symbols): Update.
 485         * objfiles.c (objfile::objfile): Update.
 486         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
 487         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
 488         comment.
 489         (minimal_symbol_reader::install): Update.
 490         (terminate_minimal_symbol_table): Remove.
 491         * jit.c (jit_object_close_impl): Update.
 492
 493 2019-03-15  Tom Tromey  <tom@tromey.com>
 494
 495         * minsyms.c (minimal_symbol_reader::record_full): Remove some
 496         initializations.
 497
 498 2019-03-15  Tom Tromey  <tom@tromey.com>
 499
 500         * objfiles.h (struct objfile_per_bfd_storage)
 501         <demangled_hash_languages>: Now a bitset.
 502         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 503         (lookup_minimal_symbol): Update.
 504
 505 2019-03-15  Tom Tromey  <tom@tromey.com>
 506
 507         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
 508         Don't return the symbol.
 509         * coffread.c (record_minimal_symbol): Use record_full.
 510
 511 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
 512
 513         The MS-Windows port of ncurses fails to switch to a color pair if
 514         one or both of the colors are the implicit default colors.  This
 515         change records the default colors when TUI is initialized, and
 516         then specifies them explicitly when a color pair uses the default
 517         colors.  This allows color styling in TUI mode on MS-Windows.
 518
 519         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
 520         ncurses_norm_attr.
 521         (tui_initialize_io) [__MINGW32__]: Record the default terminal
 522         colors in ncurses_norm_attr.
 523         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
 524         "none", replace it with the default color recorded in
 525         ncurses_norm_attr.
 526
 527 2019-03-14  Tom Tromey  <tromey@adacore.com>
 528
 529         * source-cache.h (class source_cache) <get_source_lines>: Return
 530         std::string.
 531         * source-cache.c (source_cache::extract_lines): Handle case where
 532         first_pos==npos.  Return std::string.
 533         (source_cache::get_source_lines): Update.
 534
 535 2019-03-14  Tom Tromey  <tromey@adacore.com>
 536
 537         * NEWS: Add item for "style sources" commands.
 538         * source-cache.c (source_cache::get_source_lines): Check
 539         source_styling.
 540         * cli/cli-style.c (source_styling): New global.
 541         (_initialize_cli_style): Add "style sources" commands.
 542         (show_style_sources): New function.
 543         * cli/cli-style.h (source_styling): Declare.
 544
 545 2019-03-14  Pedro Alves  <palves@redhat.com>
 546             Tom Tromey  <tromey@adacore.com>
 547
 548         * tui/tui-winsource.h (tui_refill_source_window): Declare.
 549         * tui/tui-winsource.c (tui_refill_source_window): New function,
 550         from...
 551         (tui_horizontal_source_scroll): ... here.  Move some logic.
 552         * cli/cli-style.c (set_style_enabled): Notify new observable.
 553         * tui/tui-hooks.c (tui_redisplay_source): New function.
 554         (tui_attach_detach_observers): Attach or detach
 555         tui_redisplay_source.
 556         * observable.h (source_styling_changed): New observable.
 557         * observable.c: Define source_styling_changed observable.
 558
 559 2019-03-13  Tom Tromey  <tromey@adacore.com>
 560
 561         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
 562         (i386_gnu_nat_target::store_registers): Update.
 563         * target-debug.h (target_debug_print_std_string): New macro.
 564         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
 565         * windows-tdep.c (display_one_tib): Update.
 566         * tui/tui-stack.c (tui_make_status_line): Update.
 567         * top.c (print_inferior_quit_action): Update.
 568         * thread.c (thr_try_catch_cmd): Update.
 569         (add_thread_with_info): Update.
 570         (thread_target_id_str): Update.
 571         (thr_try_catch_cmd): Update.
 572         (thread_command): Update.
 573         (thread_find_command): Update.
 574         * record-btrace.c (record_btrace_target::info_record)
 575         (record_btrace_resume_thread, record_btrace_target::resume)
 576         (record_btrace_cancel_resume, record_btrace_step_thread)
 577         (record_btrace_target::wait, record_btrace_target::wait)
 578         (record_btrace_target::wait, record_btrace_target::stop): Update.
 579         * progspace.c (print_program_space): Update.
 580         * process-stratum-target.c
 581         (process_stratum_target::thread_address_space): Update.
 582         * linux-fork.c (linux_fork_mourn_inferior)
 583         (detach_checkpoint_command, info_checkpoints_command)
 584         (linux_fork_context): Update.
 585         (linux_fork_detach): Update.
 586         (class scoped_switch_fork_info): Update.
 587         (delete_checkpoint_command): Update.
 588         * infrun.c (follow_fork_inferior): Update.
 589         (follow_fork_inferior): Update.
 590         (proceed_after_vfork_done): Update.
 591         (handle_vfork_child_exec_or_exit): Update.
 592         (follow_exec): Update.
 593         (displaced_step_prepare_throw): Update.
 594         (displaced_step_restore): Update.
 595         (start_step_over): Update.
 596         (resume_1): Update.
 597         (clear_proceed_status_thread): Update.
 598         (proceed): Update.
 599         (print_target_wait_results): Update.
 600         (do_target_wait): Update.
 601         (context_switch): Update.
 602         (stop_all_threads): Update.
 603         (restart_threads): Update.
 604         (finish_step_over): Update.
 605         (handle_signal_stop): Update.
 606         (switch_back_to_stepped_thread): Update.
 607         (keep_going_pass_signal): Update.
 608         (print_exited_reason): Update.
 609         (normal_stop): Update.
 610         * inferior.c (inferior_pid_to_str): Change return type.
 611         (print_selected_inferior): Update.
 612         (add_inferior): Update.
 613         (detach_inferior): Update.
 614         * dummy-frame.c (fprint_dummy_frames): Update.
 615         * dcache.c (dcache_info_1): Update.
 616         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
 617         (btrace_fetch, btrace_clear): Update.
 618         * linux-tdep.c (linux_core_pid_to_str): Change return type.
 619         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
 620         type.
 621         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
 622         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
 623         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
 624         * gdbarch.c, gdbarch.h: Rebuild.
 625         * gdbarch.sh (core_pid_to_str): Change return type.
 626         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
 627         return type.
 628         (windows_nat_target::pid_to_str): Change return type.
 629         (windows_delete_thread): Update.
 630         (windows_nat_target::attach): Update.
 631         (windows_nat_target::files_info): Update.
 632         * target-delegates.c: Rebuild.
 633         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
 634         return type.
 635         (sol_thread_target::pid_to_str): Change return type.
 636         * remote.c (class remote_target) <pid_to_str>: Change return
 637         type.
 638         (remote_target::pid_to_str): Change return type.
 639         (extended_remote_target::attach, remote_target::remote_stop_ns)
 640         (remote_target::remote_notif_remove_queued_reply)
 641         (remote_target::push_stop_reply, remote_target::disable_btrace):
 642         Update.
 643         (extended_remote_target::attach): Update.
 644         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
 645         type.
 646         (gdbsim_target::pid_to_str): Change return type.
 647         * ravenscar-thread.c (struct ravenscar_thread_target)
 648         <pid_to_str>: Change return type.
 649         (ravenscar_thread_target::pid_to_str): Change return type.
 650         * procfs.c (class procfs_target) <pid_to_str>: Change return
 651         type.
 652         (procfs_target::pid_to_str): Change return type.
 653         (procfs_target::attach): Update.
 654         (procfs_target::detach): Update.
 655         (procfs_target::fetch_registers): Update.
 656         (procfs_target::store_registers): Update.
 657         (procfs_target::wait): Update.
 658         (procfs_target::files_info): Update.
 659         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
 660         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
 661         return type.
 662         (nto_procfs_target::pid_to_str): Change return type.
 663         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
 664         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
 665         return type.
 666         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
 667         (exit_lwp): Update.
 668         (attach_proc_task_lwp_callback, get_detach_signal)
 669         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
 670         (linux_nat_target::resume, wait_lwp, stop_callback)
 671         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
 672         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
 673         (linux_nat_wait_1, resume_stopped_resumed_lwps)
 674         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
 675         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
 676         type.
 677         (inf_ptrace_target::attach): Update.
 678         (inf_ptrace_target::files_info): Update.
 679         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
 680         type.
 681         (go32_nat_target::pid_to_str): Change return type.
 682         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
 683         (gnu_nat_target::wait): Update.
 684         (gnu_nat_target::wait): Update.
 685         (gnu_nat_target::resume): Update.
 686         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
 687         (fbsd_nat_target::wait): Update.
 688         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
 689         type.
 690         (darwin_nat_target::attach): Update.
 691         * corelow.c (class core_target) <pid_to_str>: Change return type.
 692         (core_target::pid_to_str): Change return type.
 693         * target.c (normal_pid_to_str): Change return type.
 694         (default_pid_to_str): Likewise.
 695         (target_pid_to_str): Change return type.
 696         (target_translate_tls_address): Update.
 697         (target_announce_detach): Update.
 698         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
 699         return type.
 700         (bsd_uthread_target::pid_to_str): Change return type.
 701         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
 702         type.
 703         (bsd_kvm_target::pid_to_str): Change return type.
 704         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
 705         return type.
 706         (aix_thread_target::pid_to_str): Change return type.
 707         * target.h (struct target_ops) <pid_to_str>: Change return type.
 708         (target_pid_to_str, normal_pid_to_str): Likewise.
 709         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
 710         type.
 711         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
 712         type.
 713         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
 714         return type.
 715         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
 716         type.
 717         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
 718         type.
 719         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
 720         return type.
 721
 722 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
 723
 724         * NEWS: Mention that the new default MI version is 3.  Mention
 725         changes to the output of commands and events that deal with
 726         multi-location breakpoints.
 727         * breakpoint.c: Include "mi/mi-out.h".
 728         (print_one_breakpoint): Change output syntax if using MI version
 729         >= 3.
 730         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
 731         New.
 732         (mi_multi_location_breakpoint_output_fixed): New.
 733         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
 734         (mi_cmd_fix_multi_location_breakpoint_output): New.
 735         (mi_multi_location_breakpoint_output_fixed): New.
 736         * mi/mi-cmds.c (mi_cmds): Register command
 737         -fix-multi-location-breakpoint-output.
 738         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
 739         interpreter "mi".
 740
 741 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
 742
 743         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
 744         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
 745         instantiate mi_ui_out based on interpreter name.
 746         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
 747         * mi/mi-main.c (mi_load_progress): Likewise.
 748
 749 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 750
 751         * NEWS: Combine separate "New targets" sections for 8.3.
 752
 753 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 754
 755         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
 756         (ppcfbsd_init_abi): Install gdbarch
 757         "fetch_tls_load_module_address" and "get_thread_local_address"
 758         methods.
 759
 760 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 761
 762         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
 763         (riscv_fbsd_init_abi): Install gdbarch
 764         "fetch_tls_load_module_address" and "get_thread_local_address"
 765         methods.
 766
 767 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 768
 769         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
 770         (i386fbsd_init_abi): Install gdbarch
 771         "fetch_tls_load_module_address" and "get_thread_local_address"
 772         methods.
 773
 774 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 775
 776         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
 777         (amd64fbsd_init_abi): Install gdbarch
 778         "fetch_tls_load_module_address" and "get_thread_local_address"
 779         methods.
 780
 781 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 782
 783         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
 784         (struct fbsd_pspace_data): New type.
 785         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
 786         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
 787         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
 788         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
 789         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
 790
 791 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 792
 793         * gdbtypes.c (lookup_struct_elt): New function.
 794         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
 795         * gdbtypes.h (struct struct_elt): New type.
 796         (lookup_struct_elt): New prototype.
 797
 798 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 799
 800         * gdbtypes.c (lookup_struct_elt_type): Update comment and
 801         remove disabled code block.
 802
 803 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 804
 805         * gdbarch.sh (get_thread_local_address): New method.
 806         * gdbarch.h, gdbarch.c: Regenerate.
 807         * target.c (target_translate_tls_address): Use
 808         gdbarch_get_thread_local_address if present instead of
 809         target::get_thread_local_address.
 810
 811 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 812
 813         * target.h (target::get_thread_local_address): Update comment.
 814
 815 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 816
 817         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
 818         objfile->separate_debug_objfile_backlink if not NULL.
 819
 820 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 821
 822         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
 823         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
 824         (amd64bsd_store_inferior_registers): Likewise.
 825         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 826         Enable segment base registers.
 827         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
 828         PT_GETFSBASE and PT_GETGSBASE.
 829         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
 830         PT_SETGSBASE.
 831         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
 832         segment base registers.
 833         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 834
 835 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 836
 837         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 838         Update calls to i386_target_description to add 'segments'
 839         parameter.
 840         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
 841         add segment base registers.
 842         * arch/i386.c (i386_create_target_description): Add 'segments'
 843         parameter to enable segment base registers.
 844         * arch/i386.h (i386_create_target_description): Likewise.
 845         * features/i386/32bit-segments.xml: New file.
 846         * features/i386/32bit-segments.c: Generate.
 847         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
 848         call to i386_target_description to add 'segments' parameter.
 849         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 850         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
 851         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
 852         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
 853         if feature is present.
 854         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
 855         Add 'segments' parameter to call to i386_target_description.
 856         (i386_target_description): Add 'segments' parameter to enable
 857         segment base registers.
 858         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
 859         to call to i386_target_description.
 860         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
 861         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
 862         Define I386_NUM_REGS.
 863         (i386_target_description): Add 'segments' parameter to enable
 864         segment base registers.
 865
 866 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
 867
 868         PR/24325
 869         * source-cache.c: #undef open and close, to avoid unresolved
 870         externals during linking.
 871
 872 2019-03-12  Tom Tromey  <tromey@adacore.com>
 873
 874         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
 875         const.  Add initializers.
 876         (_initialize_remote): Don't initialize ptid globals.
 877
 878 2019-03-12  Pedro Alves  <palves@redhat.com>
 879
 880         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
 881
 882 2019-03-12  Pedro Alves  <palves@redhat.com>
 883
 884         * cp-name-parser.y (main): Remove unused 'len' variable.
 885
 886 2019-03-12  Tom Tromey  <tromey@adacore.com>
 887
 888         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
 889         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
 890
 891 2019-03-12  Tom Tromey  <tromey@adacore.com>
 892
 893         * linux-nat.c (iterate_over_lwps): Update.
 894         (stop_callback): Remove parameter.
 895         (stop_wait_callback, detach_callback, resume_set_callback)
 896         (select_singlestep_lwp_callback, set_ignore_sigint)
 897         (status_callback, resumed_callback, resume_clear_callback)
 898         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
 899         data parameter.
 900         (linux_nat_target::detach, linux_nat_target::resume)
 901         (linux_stop_and_wait_all_lwps, select_event_lwp)
 902         (linux_nat_filter_event, linux_nat_wait_1)
 903         (linux_nat_target::kill, linux_nat_target::stop)
 904         (linux_nat_target::stop): Update.
 905         (linux_nat_resume_callback): Change type.
 906         (resume_stopped_resumed_lwps, count_events_callback)
 907         (select_event_lwp_callback): Likewise.
 908         (linux_stop_lwp, linux_nat_stop_lwp): Update.
 909         * arm-linux-nat.c (struct update_registers_data): Remove.
 910         (update_registers_callback): Change type.
 911         (arm_linux_insert_hw_breakpoint1): Update.
 912         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
 913         parameter.
 914         (x86_linux_dr_set_addr): Update.
 915         (x86_linux_dr_set_control): Update.
 916         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
 917         (iterate_over_lwps): Use gdb::function_view.
 918         * nat/aarch64-linux-hw-point.c (struct
 919         aarch64_dr_update_callback_param): Remove.
 920         (debug_reg_change_callback): Change type.
 921         (aarch64_notify_debug_reg_change): Update.
 922         * s390-linux-nat.c (s390_refresh_per_info): Update.
 923
 924 2019-03-11  Tom Tromey  <tromey@adacore.com>
 925
 926         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
 927         redundant assignment to "this_cu".
 928
 929 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 930
 931         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
 932
 933 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 934
 935         * gdbtypes.c (rank_one_type_parm_set): New function extracted
 936         from...
 937         (rank_one_type): ... this.
 938
 939 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 940
 941         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
 942         from...
 943         (rank_one_type): ... this.
 944
 945 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 946
 947         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
 948         from...
 949         (rank_one_type): ... this.
 950
 951 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 952
 953         * gdbtypes.c (rank_one_type_parm_float): New function extracted
 954         from...
 955         (rank_one_type): ... this.
 956
 957 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 958
 959         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
 960         from...
 961         (rank_one_type): ... this.
 962
 963 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 964
 965         * gdbtypes.c (rank_one_type_parm_range): New function extracted
 966         from...
 967         (rank_one_type): ... this.
 968
 969 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 970
 971         * gdbtypes.c (rank_one_type_parm_char): New function extracted
 972         from...
 973         (rank_one_type): ... this.
 974
 975 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 976
 977         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
 978         from...
 979         (rank_one_type): ... this.
 980
 981 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 982
 983         * gdbtypes.c (rank_one_type_parm_int): New function extracted
 984         from...
 985         (rank_one_type): ... this.
 986
 987 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 988
 989         * gdbtypes.c (rank_one_type_parm_func): New function extracted
 990         from...
 991         (rank_one_type): ... this.
 992
 993 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 994
 995         * gdbtypes.c (rank_one_type_parm_array): New function extracted
 996         from...
 997         (rank_one_type): ... this.
 998
 999 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1000
1001         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
1002         from...
1003         (rank_one_type): ... this.
1004
1005 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1006
1007         * inferior.c (initialize_inferiors): Ensure 'help set/show print
1008         inferior-events' shows the example events.
1009
1010 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
1011
1012         Support styling on native MS-Windows console
1013
1014         PR/24315
1015         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
1016         on MS-Windows if $TERM is not defined.
1017
1018         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
1019
1020         * posix-hdep.c (gdb_console_fputs):
1021         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
1022         functions.
1023         * ui-file.h (gdb_console_fputs): Add prototype.
1024
1025         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
1026         back to fputs only if the former returns zero.
1027
1028 2019-03-07  Tom Tromey  <tom@tromey.com>
1029
1030         * symmisc.c (print_symbol_bcache_statistics): Update.
1031         (print_objfile_statistics): Update.
1032         * symfile.c (allocate_symtab): Update.
1033         * stabsread.c: Don't include bcache.h.
1034         * psymtab.h (struct psymbol_bcache): Don't declare.
1035         (class psymtab_storage) <psymbol_cache>: Now a bcache.
1036         (psymbol_bcache_init, psymbol_bcache_free)
1037         (psymbol_bcache_get_bcache): Don't declare.
1038         * psymtab.c (struct psymbol_bcache): Remove.
1039         (psymtab_storage::psymtab_storage): Update.
1040         (psymtab_storage::~psymtab_storage): Update.
1041         (psymbol_bcache_init, psymbol_bcache_free)
1042         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
1043         (add_psymbol_to_bcache): Update.
1044         (allocate_psymtab): Update.
1045         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
1046         macro_cache>: No longer pointers.
1047         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
1048         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
1049         * macrotab.c (macro_bcache): Update.
1050         * macroexp.c: Don't include bcache.h.
1051         * gdbtypes.c (check_types_worklist): Update.
1052         (types_deeply_equal): Remove TRY/CATCH.  Update.
1053         * elfread.c (elf_symtab_read): Update.
1054         * dwarf2read.c: Don't include bcache.h.
1055         * buildsym.c (buildsym_compunit::get_macro_table): Update.
1056         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
1057         (print_bcache_statistics, bcache_memory_used): Don't declare.
1058         (struct bcache): Move from bcache.c.  Add constructor, destructor,
1059         methods.  Rename all data members.
1060         * bcache.c (struct bcache): Move to bcache.h.
1061         (bcache::expand_hash_table): Rename from expand_hash_table.
1062         (bcache): Remove.
1063         (bcache::insert): Rename from bcache_full.
1064         (bcache::compare): Rename from bcache_compare.
1065         (bcache_xmalloc): Remove.
1066         (bcache::~bcache): Rename from bcache_xfree.
1067         (bcache::print_statistics): Rename from print_bcache_statistics.
1068         (bcache::memory_used): Rename from bcache_memory_used.
1069
1070 2019-03-07  Pedro Alves  <palves@redhat.com>
1071
1072         * infrun.c (normal_stop): Also check for
1073         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
1074
1075 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
1076
1077         * f-lang.c (value_from_host_double): Moved to...
1078         * value.c (value_from_host_double): ...here.
1079         * value.h (value_from_host_double): Declare.
1080         * guile/scm-math.c (vlscm_convert_typed_number): Use
1081         value_from_host_double.
1082         (vlscm_convert_number): Likewise.
1083         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
1084         * python/py-value.c (convert_value_from_python): Likewise.
1085
1086 2019-03-06  Tom Tromey  <tom@tromey.com>
1087
1088         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
1089
1090 2019-03-06  Tom Tromey  <tom@tromey.com>
1091
1092         * utils.h (free_current_contents): Don't declare.
1093         * utils.c (free_current_contents): Remove.
1094
1095 2019-03-06  Tom Tromey  <tom@tromey.com>
1096
1097         * top.c (quit_force): Update.
1098         * main.c (captured_command_loop): Update.
1099         * common/new-op.c (operator new): Update.
1100         * common/common-exceptions.c (struct catcher)
1101         <save_cleanup_chain>: Remove member.
1102         (exceptions_state_mc_init): Update.
1103         (exception_try_scope_entry): Return nullptr.
1104         (exception_try_scope_exit, exception_rethrow)
1105         (throw_exception_sjlj, throw_exception_cxx): Update.
1106         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
1107         (all_cleanups, do_cleanups, discard_cleanups)
1108         (discard_final_cleanups, save_cleanups, save_final_cleanups)
1109         (restore_cleanups, restore_final_cleanups): Don't declare.
1110         (do_final_cleanups): Remove parameter.
1111         * common/cleanups.c (cleanup_chain, make_cleanup)
1112         (make_cleanup_dtor, all_cleanups, do_cleanups)
1113         (discard_my_cleanups, discard_cleanups)
1114         (discard_final_cleanups, save_my_cleanups, save_cleanups)
1115         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
1116         (null_cleanup): Remove.
1117         (do_final_cleanups): Remove parameter.
1118
1119 2019-03-06  Tom Tromey  <tom@tromey.com>
1120
1121         * remote.c (remote_target::remote_parse_stop_reply): Use
1122         unique_xmalloc_ptr.
1123
1124 2019-03-06  Tom Tromey  <tom@tromey.com>
1125
1126         * stabsread.c (struct stabs_field_info): Rename from field_info.
1127         <list, fnlist>: Add initializers.
1128         <obstack>: New member.
1129         (read_member_functions, read_struct_fields, read_baseclasses):
1130         Allocate on obstack.  Don't use cleanups.
1131         (read_one_struct_field, read_member_functions, read_struct_fields)
1132         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
1133         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
1134         (read_struct_type): Update.
1135
1136 2019-03-06  Tom Tromey  <tom@tromey.com>
1137
1138         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
1139         * common/filestuff.h (make_cleanup_close): Don't declare.
1140         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
1141         Remove.
1142
1143 2019-03-06  Tom Tromey  <tom@tromey.com>
1144
1145         * solib-aix.c: Use make_scope_exit.
1146
1147 2019-03-06  Tom Tromey  <tom@tromey.com>
1148
1149         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
1150         Use make_scope_exit.
1151
1152 2019-03-06  Tom Tromey  <tom@tromey.com>
1153
1154         * solib-svr4.c (disable_probes_interface): Remove parameter.
1155         (svr4_handle_solib_event): Use make_scope_exit.
1156
1157 2019-03-06  Tom Tromey  <tom@tromey.com>
1158
1159         * remote.c (struct stop_reply_deleter): Remove.
1160         (stop_reply_up): Update.
1161         (struct stop_reply): Derive from notif_event.  Don't typedef.
1162         <regcache>: Now a std::vector.
1163         (stop_reply_xfree): Remove.
1164         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
1165         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
1166         (remote_target::discard_pending_stop_replies): Use delete.
1167         (remote_target::remote_parse_stop_reply): Update.
1168         (remote_target::process_stop_reply): Update.
1169         * remote-notif.h (struct notif_event): Add virtual destructor.
1170         Remove "dtr" member.
1171         (struct notif_client) <alloc_event>: Return a unique_ptr.
1172         (notif_event_xfree): Don't declare.
1173         (notif_event_up): New typedef.
1174         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
1175         (notif_event_xfree, do_notif_event_xfree): Remove.
1176         (remote_notif_state_xfree): Update.
1177
1178 2019-03-06  Tom Tromey  <tom@tromey.com>
1179
1180         * infrun.c (displaced_step_clear_cleanup): Now a
1181         forward_scope_exit type.
1182         (displaced_step_prepare_throw): Update.
1183         (displaced_step_fixup): Update.
1184
1185 2019-03-06  Tom Tromey  <tom@tromey.com>
1186
1187         * inferior.h (class inferior): Update comment.
1188         * gdbthread.h (class thread_info): Update comment.
1189
1190 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
1191             Tom Tromey  <tom@tromey.com>
1192
1193         * stabsread.h (struct stab_section_list): Remove.
1194         (coffstab_build_psymtabs): Update.
1195         * dbxread.c (symbuf_sections): Now a std::vector.
1196         (sect_idx): New global.
1197         (fill_symbuf): Update.
1198         (coffstab_build_psymtabs): Change type of stabsects parameter.
1199         Update.
1200         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
1201         std::vector.
1202         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
1203         (coff_locate_sections): Update.
1204         (coff_symfile_read): Remove cleanups.  Update.
1205         (init_stringtab): Add storage parameter.
1206         (free_stringtab, free_stringtab_cleanup): Remove.
1207         (init_lineno): Add storage parameter.
1208         (free_linetab, free_linetab_cleanup): Remove.
1209
1210 2019-03-06  Pedro Alves  <palves@redhat.com>
1211
1212         * linux-fork.c (fork_info::clobber_regs): Delete.
1213         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
1214         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
1215         comment.  Adjust.
1216         (scoped_switch_fork_info::scoped_switch_fork_info)
1217         (checkpoint_command, linux_fork_context): Adjust
1218         fork_save_infrun_state calls.
1219
1220 2019-03-06  Pedro Alves  <palves@redhat.com>
1221
1222         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
1223         (inf_has_multiple_threads): Return 'bool' and rewrite using
1224         inferior_info::threads().
1225
1226 2019-03-06  Pedro Alves  <palves@redhat.com>
1227
1228         * linux-fork.c: Include <list>.
1229         (fork_list): Now a std::list instance.
1230         (fork_info): Add ctor, dtor, and in-class initialize all fields.
1231         (forks_exist_p, find_last_fork): Adjust.
1232         (new_fork): Delete.
1233         (one_fork_p): New.
1234         (add_fork): Adjust.
1235         (free_fork): Delete, folded into fork_info::~fork_info().
1236         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
1237         Adjust.
1238         (init_fork_list): Delete.
1239         (linux_fork_killall, linux_fork_mourn_inferior)
1240         (linux_fork_detach, info_checkpoints_command): Adjust.
1241         (_initialize_linux_fork): No longer call init_fork_list.
1242
1243 2019-03-06  Pedro Alves  <palves@redhat.com>
1244
1245         * linux-fork.c (new_fork): New, split out of ...
1246         (add_fork): ... this.  Return void.  Move "first fork" special
1247         case from here, to ...
1248         (checkpoint_command): ... here.
1249         * linux-linux.h (add_fork): Return void.
1250
1251 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1252
1253         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
1254
1255 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1256             Chris January  <chris.january@arm.com>
1257             David Lecomber  <david.lecomber@arm.com>
1258
1259         * f-exp.y: New token, UNOP_INTRINSIC.
1260         (exp): New pattern using UNOP_INTRINSIC token.
1261         (f77_keywords): Add 'abs' keyword.
1262         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
1263         (value_from_host_double): New function.
1264         (evaluate_subexp_f): Support UNOP_ABS.
1265
1266 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1267
1268         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
1269         types.
1270
1271 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1272
1273         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
1274         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
1275         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
1276
1277 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1278
1279         * f-exp.y (convert_to_kind_type): Handle more type kinds.
1280
1281 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1282             Chris January  <chris.january@arm.com>
1283
1284         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
1285         * f-exp.y: Define 'KIND' token.
1286         (exp): New pattern for KIND expressions.
1287         (ptype): Handle types with a kind extension.
1288         (direct_abs_decl): Extend to spot kind extensions.
1289         (f77_keywords): Add 'kind' to the list.
1290         (push_kind_type): New function.
1291         (convert_to_kind_type): New function.
1292         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
1293         * parse.c (operator_length_standard): Likewise.
1294         * parser-defs.h (enum type_pieces): Add tp_kind.
1295         * std-operator.def: Add UNOP_KIND.
1296
1297 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1298
1299         * f-exp.y (f_parse): Set yydebug.
1300
1301 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1302
1303         * f-lang.c (evaluate_subexp_f): New function.
1304         (exp_descriptor_f): New global.
1305         (f_language_defn): Use exp_descriptor_f instead of
1306         exp_descriptor_standard.
1307
1308 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1309
1310         * f-exp.y (struct token): Add comments.
1311         (dot_ops): Remove uppercase versions and the end marker.
1312         (f77_keywords): Likewise.
1313         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
1314         entries in the dot_ops array are case insensitive, and use
1315         strncasecmp to compare strings.  Also some whitespace cleanup in
1316         this area.  Similar for the f77_keywords array, except entries in
1317         this list might be case sensitive.
1318
1319 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1320
1321         * f-exp.y (struct f77_boolean_val): Add comments.
1322         (boolean_values): Remove uppercase versions, and end marker.
1323         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
1324         and use strncasecmp to achieve case insensitivity.  Additionally,
1325         perform whitespace cleanup around this code.
1326
1327 2019-03-06  Tom Tromey  <tromey@adacore.com>
1328
1329         * remote-sim.c (gdbsim_target_open): Use result of
1330         gdb_argv::release.
1331
1332 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
1333         Dirk Schubert  <dirk.schubert@arm.com>
1334         Chris January  <chris.january@arm.com>
1335
1336         * eval.c (evaluate_subexp_standard): Call Fortran argument
1337         wrapping logic.
1338         * f-lang.c (struct value): A value which can be passed into a
1339         Fortran function call.
1340         (fortran_argument_convert): Wrap Fortran arguments in a pointer
1341         where appropriate.
1342         (struct type): Value ready for a Fortran function call.
1343         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
1344         is needed.
1345         * f-lang.h (fortran_argument_convert): Declaration.
1346         (fortran_preserve_arg_pointer): Declaration.
1347         * infcall.c (value_arg_coerce): Call Fortran argument logic.
1348
1349 2019-03-05  Tom Tromey  <tromey@adacore.com>
1350
1351         * python/py-prettyprint.c (print_string_repr): Remove #if.
1352         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
1353
1354 2019-03-05  Tom Tromey  <tromey@adacore.com>
1355
1356         * target.c (the_dummy_target): Move later.  Change type to
1357         "dummy_target".
1358         (initialize_targets): Don't initialize the_dummy_target.
1359
1360 2019-03-05  Tom Tromey  <tromey@adacore.com>
1361
1362         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
1363         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
1364
1365 2019-03-05  Tom Tromey  <tromey@adacore.com>
1366
1367         * windows-nat.c (windows_nat_target::attach)
1368         (windows_nat_target::detach): Don't call gdb_flush.
1369         * valprint.c (generic_val_print, val_print, val_print_string):
1370         Don't call gdb_flush.
1371         * utils.c (defaulted_query): Don't call gdb_flush.
1372         * typeprint.c (print_type_scalar): Don't call gdb_flush.
1373         * target.c (target_announce_detach): Don't call gdb_flush.
1374         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
1375         * remote.c (extended_remote_target::attach): Don't call
1376         gdb_flush.
1377         * procfs.c (procfs_target::detach): Don't call gdb_flush.
1378         * printcmd.c (do_examine): Don't call gdb_flush.
1379         (info_display_command): Don't call gdb_flush.
1380         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
1381         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
1382         * memattr.c (info_mem_command): Don't call gdb_flush.
1383         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
1384         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
1385         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
1386         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
1387         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
1388         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
1389         (gnu_nat_target::detach): Don't call gdb_flush.
1390         * f-valprint.c (f_val_print): Don't call gdb_flush.
1391         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
1392         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
1393         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
1394         gdb_flush.
1395         * c-valprint.c (c_val_print): Don't call gdb_flush.
1396         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
1397
1398 2019-03-05  Tom Tromey  <tromey@adacore.com>
1399
1400         * varobj.c (update_dynamic_varobj_children): Update.
1401         (install_default_visualizer): Use reset, not release.
1402         * value.c (set_internalvar): Update.
1403         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
1404         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
1405         ATTRIBUTE_UNUSED_RESULT.
1406
1407 2019-03-05  Tom Tromey  <tromey@adacore.com>
1408
1409         * remote.c (class scoped_remote_fd) <release>: Add
1410         ATTRIBUTE_UNUSED_RESULT.
1411
1412 2019-03-05  Tom Tromey  <tromey@adacore.com>
1413
1414         * macroexp.c (struct macro_buffer) <release>: Add
1415         ATTRIBUTE_UNUSED_RESULT.
1416
1417 2019-03-05  Tom Tromey  <tromey@adacore.com>
1418
1419         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
1420         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
1421         ATTRIBUTE_UNUSED_RESULT.
1422
1423 2019-03-05  Tom Tromey  <tromey@adacore.com>
1424
1425         * common/scoped_fd.h (class scoped_fd) <release>: Add
1426         ATTRIBUTE_UNUSED_RESULT.
1427
1428 2019-03-05  Tom Tromey  <tromey@adacore.com>
1429
1430         * parser-defs.h (struct parser_state) <release>: Add
1431         ATTRIBUTE_UNUSED_RESULT.
1432
1433 2019-03-05  Tom Tromey  <tromey@adacore.com>
1434
1435         * utils.h (class gdb_argv) <release>: Add
1436         ATTRIBUTE_UNUSED_RESULT.
1437         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
1438
1439 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
1440
1441         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
1442         for-loop range, to avoid compiler warnings.
1443
1444         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
1445         avoid compiler warnings about unused variables.
1446
1447         * NEWS: Mention end of support for native debugging on MS-Windows
1448         before XP.
1449
1450         PR gdb/24292
1451         * common/netstuff.c:
1452         * gdbserver/gdbreplay.c
1453         * gdbserver/remote-utils.c:
1454         * ser-tcp.c:
1455         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
1456         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
1457         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
1458         'getaddrinfo' and 'freeaddrinfo' were not available before
1459         Windows XP, and mingw.org's MinGW headers by default define
1460         _WIN32_WINNT to 0x500.
1461
1462 2019-03-01  Gary Benson <gbenson@redhat.com>
1463
1464         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
1465
1466 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
1467             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1468
1469         PR gdb/8527
1470         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
1471         set_sigint_trap, clear_sigint_trap.
1472
1473 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1474
1475         * target.c (target_detach): Clear the regcache and the
1476         frame cache.
1477
1478 2019-02-27  Pedro Alves  <palves@redhat.com>
1479
1480         * utils.c (set_screen_size): When we cap the height/width sizes,
1481         tweak the corresponding command variable to show "unlimited":
1482
1483 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
1484             Pedro Alves  <palves@redhat.com>
1485
1486         * utils.c (set_screen_size): Reduce "infinite" rows and columns
1487         before calling rl_set_screen_size.
1488
1489 2019-02-27  Tom Tromey  <tromey@adacore.com>
1490
1491         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
1492         define.
1493         * python/py-value.c: Remove Python 2.4 workaround.
1494         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
1495         workaround.
1496         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
1497         Python 2.4 workaround.
1498         * python/python-internal.h: Remove Python 2.4 comment.
1499         (Py_ssize_t): Don't define.
1500         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
1501         (gdb_Py_DECREF): Remove Python 2.4 workaround.
1502         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
1503         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
1504         * python/python.c (do_start_initialization): Remove Python 2.4
1505         workaround.
1506         * python/py-prettyprint.c (class dummy_python_frame): Remove.
1507         (print_children): Remove Python 2.4 workaround.
1508         * python/py-inferior.c (buffer_procs): Remove Python 2.4
1509         workaround.
1510         (CHARBUFFERPROC_NAME): Remove.
1511         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
1512         Python 2.4 workaround.
1513
1514 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1515
1516         * NEWS: Note minimum Python version.
1517
1518 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1519
1520         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
1521         code from these functions.  Remove corresponding ifdefs.  Use
1522         Py_buffer_up instead of explicit calls to PyBuffer_Release.
1523         Remove gotos and target of gotos.
1524         (infpy_search_memory): Likewise.
1525
1526 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1527
1528         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
1529         (hppa_gdbarch_init): Don't register deleted functions with
1530         gdbarch.
1531
1532 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1533
1534         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
1535         (h8300_unwind_sp): Delete.
1536         (h8300_dummy_id): Delete.
1537         (h8300_gdbarch_init): Don't register deleted functions with
1538         gdbarch.
1539
1540 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1541
1542         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
1543         (ft32_unwind_pc): Delete.
1544         (ft32_unwind_sp): Delete.
1545         (ft32_gdbarch_init): Don't register deleted functions with
1546         gdbarch.
1547
1548 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1549
1550         * gdb/frv-tdep.c (frv_dummy_id): Delete.
1551         (frv_unwind_pc): Delete.
1552         (frv_unwind_sp): Delete.
1553         (frv_gdbarch_init): Don't register deleted functions with
1554         gdbarch.
1555
1556 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1557
1558         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
1559         (riscv_unwind_pc): Delete.
1560         (riscv_unwind_sp): Delete.
1561         (riscv_gdbarch_init): Don't register deleted functions with
1562         gdbarch.
1563
1564 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1565
1566         * gdb/csky-tdep.c (csky_dummy_id): Delete.
1567         (csky_unwind_pc): Delete.
1568         (csky_unwind_sp): Delete.
1569         (csky_gdbarch_init): Don't register deleted functions with
1570         gdbarch.
1571
1572 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1573
1574         * gdb/cris-tdep.c (cris_dummy_id): Delete.
1575         (cris_unwind_pc): Delete.
1576         (cris_unwind_sp): Delete.
1577         (cris_gdbarch_init): Don't register deleted functions with
1578         gdbarch.
1579
1580 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1581
1582         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
1583         (bfin_unwind_pc): Delete.
1584         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
1585
1586 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1587
1588         * gdb/arm-tdep.c (arm_dummy_id): Delete.
1589         (arm_unwind_pc): Delete.
1590         (arm_unwind_sp): Delete.
1591         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
1592
1593 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1594
1595         * gdb/arc-tdep.c (arc_dummy_id): Delete.
1596         (arc_unwind_pc): Delete.
1597         (arc_unwind_sp): Delete.
1598         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
1599
1600 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1601
1602         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
1603         (alpha_unwind_pc): Delete.
1604         (alpha_gdbarch_init): Don't register deleted functions with
1605         gdbarch.
1606
1607 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1608
1609         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
1610         (aarch64_unwind_pc): Delete.
1611         (aarch64_unwind_sp): Delete.
1612         (aarch64_gdbarch_init): Don't register deleted functions with
1613         gdbarch.
1614
1615 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1616
1617         * gdbtypes.c (type_align): Don't consider static members when
1618         computing structure alignment.
1619
1620 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1621
1622         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
1623         return 0 for other types.
1624         * arch-utils.c (default_type_align): Always return 0.
1625         * gdbarch.h: Regenerate.
1626         * gdbarch.sh (type_align): Extend comment.
1627         * gdbtypes.c (type_align): Add additional comments, always call
1628         gdbarch_type_align before applying the default rules.
1629         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
1630         generic code will then apply a suitable default.
1631         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
1632         types, return 0 for other types.
1633
1634 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1635
1636         * NEWS: Create a new section for the next release branch.
1637         Rename the section of the current branch, now that it has
1638         been cut.
1639
1640 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1641
1642         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
1643         * version.in: Bump version to 8.3.50.DATE-git.
1644
1645 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
1646
1647         * aix-thread.c (ptid_cmp): Remove unused variable.
1648         (get_signaled_thread): Likewise.
1649         (store_regs_user_thread): Likewise.
1650         (store_regs_kernel_thread): Likewise.
1651         (fetch_regs_kernel_thread): Remove shadowed variable.
1652
1653 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1654
1655         * features/riscv/32bit-cpu.xml: Add register numbers.
1656         * features/riscv/32bit-fpu.c: Regenerate.
1657         * features/riscv/32bit-fpu.xml: Add register numbers.
1658         * features/riscv/64bit-cpu.xml: Add register numbers.
1659         * features/riscv/64bit-fpu.c: Regenerate.
1660         * features/riscv/64bit-fpu.xml: Add register numbers.
1661
1662 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
1663
1664         * NEWS: Mention two argument form of gdb.Value constructor.
1665         * python/py-value.c (convert_buffer_and_type_to_value): New
1666         function.
1667         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
1668         Add support for handling an optional second argument.  Call
1669         convert_buffer_and_type_to_value as appropriate.
1670         * python/python-internal.h (Py_buffer_deleter): New struct.
1671         (Py_buffer_up): New typedef.
1672
1673 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
1674
1675         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
1676         instead of releasing ownership.
1677
1678 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
1679
1680         * dwarf2read.c (open_and_init_dwp_file): Call
1681         elf_numsections instead of bfd_count_sections to initialize
1682         dwp_file->num_sections.
1683
1684 2019-02-25  Tom Tromey  <tromey@adacore.com>
1685
1686         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
1687
1688 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1689
1690         * gcore.in: Add '--readnever' option when invoking GDB.
1691
1692 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1693
1694         * MAINTAINERS: Update my email address.
1695
1696 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1697
1698         * build-id.c (build_id_to_debug_bfd_1): New function.
1699         (build_id_to_debug_bfd): Look for separate debug file in
1700         sysroot.
1701
1702 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1703
1704         * gdbarch.sh: Update the copyright year range that is placed into
1705         generated files.
1706
1707 2019-02-22  Keith Seitz  <keiths@redhat.com>
1708
1709         PR symtab/23853
1710         * linespec.c (create_sals_line_offset): Search for the default
1711         symtab's filename instead of its fullname.
1712
1713 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1714
1715         * NEWS: Update style defaults.
1716
1717 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1718
1719         * main.c (captured_main_1): Disable styling in batch mode.
1720
1721 2019-02-20  Tom Tromey  <tom@tromey.com>
1722
1723         * symtab.c (symtab_symbol_info): Fix typos.
1724
1725 2019-02-20  Tom Tromey  <tromey@adacore.com>
1726
1727         * findcmd.c (_initialize_mem_search): Use upper case for
1728         metasyntactic variables.
1729
1730 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
1731
1732         * aarch64-tdep.c (aarch64_add_reggroups): New function.
1733         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
1734
1735 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
1736
1737         * top.h (source_file_name): Change to std::string.
1738         * top.c (source_file_name): Likewise.
1739         (command_line_input): Adjust.
1740         * cli/cli-script.c (script_from_file): Adjust.
1741
1742 2019-02-19  Tom Tromey  <tromey@adacore.com>
1743
1744         * ravenscar-thread.c
1745         (ravenscar_thread_target::update_thread_list): Don't call
1746         ada_build_task_list.
1747         * ada-lang.h (ada_build_task_list): Don't declare.
1748         * ada-tasks.c (struct ada_tasks_inferior_data)
1749         <task_list_valid_p>: Now bool.
1750         (read_known_tasks, ada_task_list_changed)
1751         (ada_tasks_invalidate_inferior_data): Update.
1752         (read_known_tasks_array): Return bool.
1753         (read_known_tasks_list): Likewise.
1754         (read_known_tasks): Return void.
1755         (ada_build_task_list): Now static.
1756
1757 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1758
1759         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
1760         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
1761
1762 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1763
1764         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
1765         variant for ada_tasks_pspace_data_handle and
1766         ada_tasks_inferior_data_handle.
1767         (ada_tasks_pspace_data_cleanup): New function.
1768         (ada_tasks_inferior_data_cleanup): New function.
1769
1770 2019-02-17  Tom Tromey  <tom@tromey.com>
1771
1772         * macrotab.h (macro_source_fullname): Return a std::string.
1773         * macrotab.c (macro_include, check_for_redefinition)
1774         (macro_undef, macro_lookup_definition, foreach_macro)
1775         (foreach_macro_in_scope): Update.
1776         (macro_source_fullname): Return a std::string.
1777         * macrocmd.c (show_pp_source_pos): Update.
1778
1779 2019-02-17  Tom Tromey  <tom@tromey.com>
1780
1781         * macrocmd.c (show_pp_source_pos): Style the file names.
1782
1783 2019-02-17  Tom Tromey  <tom@tromey.com>
1784
1785         PR tui/24197:
1786         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
1787
1788 2019-02-17  Tom Tromey  <tom@tromey.com>
1789
1790         * ada-lang.c (user_select_syms): Use filtered printing.
1791         * utils.c (wrap_style): New global.
1792         (desired_style): Remove.
1793         (emit_style_escape): Add stream parameter.
1794         (set_output_style, reset_terminal_style, prompt_for_continue):
1795         Update.
1796         (flush_wrap_buffer): Only flush gdb_stdout.
1797         (wrap_here): Set wrap_style.
1798         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
1799         treat escape sequences as a character.  Change when wrap buffer is
1800         flushed.
1801         (fputs_styled): Do not set the output style when the default is
1802         requested.
1803         * ui-style.h (struct ui_file_style) <is_default>: New method.
1804         * source.c (print_source_lines_base): Emit escape sequences in one
1805         piece.
1806
1807 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1808
1809         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
1810         integers and enumeration types.
1811
1812 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1813
1814         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
1815         instead of lookup_symbol_in_language
1816         (do_exact_match): New function.
1817         (ada_get_symbol_name_matcher): Return do_exact_match when
1818         doing a verbatim match.
1819
1820 2019-02-15  Tom Tromey  <tromey@adacore.com>
1821
1822         * ravenscar-thread.c (ravenscar_thread_target::resume)
1823         (ravenscar_thread_target::wait): Special case wildcard requests.
1824
1825 2019-02-15  Tom Tromey  <tromey@adacore.com>
1826
1827         * ravenscar-thread.c (base_ptid): Remove.
1828         (struct ravenscar_thread_target) <close>: New method.
1829         <m_base_ptid>: New member.
1830         <update_inferior_ptid, active_task, task_is_currently_active,
1831         runtime_initialized>: Declare methods.
1832         <ravenscar_thread_target>: Add constructor.
1833         (ravenscar_thread_target::task_is_currently_active)
1834         (ravenscar_thread_target::update_inferior_ptid)
1835         (ravenscar_runtime_initialized): Rename.  Now methods.
1836         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
1837         (ravenscar_thread_target::update_thread_list): Update.
1838         (ravenscar_thread_target::active_task): Now method.
1839         (ravenscar_thread_target::store_registers)
1840         (ravenscar_thread_target::prepare_to_store)
1841         (ravenscar_thread_target::prepare_to_store)
1842         (ravenscar_thread_target::mourn_inferior): Update.
1843         (ravenscar_inferior_created): Use "new" to create target.
1844         (ravenscar_thread_target::get_ada_task_ptid): Update.
1845         (_initialize_ravenscar): Don't initialize base_ptid.
1846         (ravenscar_ops): Remove global.
1847
1848 2019-02-15  Tom Tromey  <tromey@adacore.com>
1849
1850         * target.h (push_target): Declare new overload.
1851         * target.c (push_target): New overload, taking an rvalue reference.
1852         * remote.c (remote_target::open_1): Use push_target overload.
1853         * corelow.c (core_target_open): Use push_target overload.
1854
1855 2019-02-15  Tom Tromey  <tromey@adacore.com>
1856
1857         * ravenscar-thread.c (is_ravenscar_task)
1858         (ravenscar_task_is_currently_active): Return bool.
1859         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
1860         (_initialize_ravenscar): Remove "(void)".
1861         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
1862         Return bool.
1863
1864 2019-02-15  Tom Tromey  <tromey@adacore.com>
1865
1866         * ravenscar-thread.c (ravenscar_runtime_initializer)
1867         (has_ravenscar_runtime, get_running_thread_id)
1868         (ravenscar_thread_target::resume): Fix indentation.
1869
1870 2019-02-15  Tom Tromey  <tromey@adacore.com>
1871
1872         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
1873         from ravenscar_arch_ops.
1874         (sparc_ravenscar_ops::fetch_registers)
1875         (sparc_ravenscar_ops::store_registers): Now methods.
1876         (sparc_ravenscar_prepare_to_store): Remove.
1877         (sparc_ravenscar_ops): Redefine.
1878         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
1879         methods and destructor.  Remove members.
1880         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
1881         (ravenscar_thread_target::store_registers)
1882         (ravenscar_thread_target::prepare_to_store): Update.
1883         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
1884         Remove.
1885         (struct ppc_ravenscar_powerpc_ops): Derive from
1886         ravenscar_arch_ops.
1887         (ppc_ravenscar_powerpc_ops::fetch_registers)
1888         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
1889         (ppc_ravenscar_powerpc_ops): Redefine.
1890         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
1891         (ppc_ravenscar_e500_ops::fetch_registers)
1892         (ppc_ravenscar_e500_ops::store_registers): Now methods.
1893         (ppc_ravenscar_e500_ops): Redefine.
1894         * aarch64-ravenscar-thread.c
1895         (aarch64_ravenscar_generic_prepare_to_store): Remove.
1896         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
1897         (aarch64_ravenscar_fetch_registers)
1898         (aarch64_ravenscar_store_registers): Now methods.
1899         (aarch64_ravenscar_ops): Redefine.
1900
1901 2019-02-15  Tom Tromey  <tromey@adacore.com>
1902
1903         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
1904         (ravenscar_thread_target::stopped_by_hw_breakpoint)
1905         (ravenscar_thread_target::stopped_by_watchpoint)
1906         (ravenscar_thread_target::stopped_data_address)
1907         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
1908
1909 2019-02-15  Tom Tromey  <tromey@adacore.com>
1910
1911         * ravenscar-thread.c: Fix some typos.
1912
1913 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1914             Tom Tromey  <tromey@adacore.com>
1915
1916         * ada-lang.c (ada_exception_sal): Change addr_string to a
1917         std::string.
1918         (create_ada_exception_catchpoint): Update.
1919
1920 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1921             Tom Tromey  <tromey@adacore.com>
1922
1923         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
1924         (bp_location_ops): Remove.
1925         (base_breakpoint_allocate_location): Update.
1926         (free_bp_location): Update.
1927         * ada-lang.c (class ada_catchpoint_location)
1928         <ada_catchpoint_location>: Remove ops parameter.
1929         (ada_catchpoint_location_dtor): Remove.
1930         (ada_catchpoint_location_ops): Remove.
1931         (allocate_location_exception): Update.
1932         * breakpoint.h (struct bp_location_ops): Remove.
1933         (class bp_location) <bp_location>: Remove bp_location_ops
1934         parameter.
1935         <~bp_location>: Add destructor.
1936         <ops>: Remove.
1937
1938 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1939             Pedro Alves  <palves@redhat.com>
1940
1941         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
1942         'PATH_MAX'.
1943
1944 2019-02-14  David Michael  <fedora.dm0@gmail.com>
1945             Samuel Thibault  <samuel.thibault@gnu.org>
1946             Thomas Schwinge  <thomas@codesourcery.com>
1947
1948         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
1949         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
1950
1951 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1952
1953         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
1954         (check_empty): Use "const char *".
1955
1956         * gnu-nat.c (gnu_nat_target::detach): Instead of
1957         'detach_inferior (pid)' call
1958         'detach_inferior (find_inferior_pid (pid))'.
1959
1960         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
1961         'nat/fork-inferior.o'.
1962         * gnu-nat.c: #include "nat/fork-inferior.h".
1963
1964         * gnu-nat.c (gnu_nat_target::detach): Instead of
1965         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
1966         * gnu-nat.h: #include "inf-child.h".
1967         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
1968         'i386_gnu_nat_target::fetch_registers'.
1969         (gnu_store_registers): Rename/move to
1970         'i386_gnu_nat_target::store_registers'.
1971
1972         * config/i386/nm-i386gnu.h: Don't "#include" any files.
1973         * gnu-nat.h (mach_thread_info): New function.
1974         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
1975
1976         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
1977
1978 2019-02-14  Frederic Konrad  <konrad@adacore.com>
1979
1980         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
1981
1982 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
1983
1984         * windows-nat.c (windows_add_thread): Add new parameter
1985         "main_thread_p" with default value set to false.  Update
1986         function documentation as well as all callers.
1987         (windows_delete_thread): Likewise.
1988         (fake_create_process): Update call to windows_add_thread.
1989         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
1990         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
1991         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
1992         call to windows_delete_thread.
1993
1994 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
1995
1996         * MAINTAINERS: Add Andrew Burgess as global maintainer.
1997
1998 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1999
2000         * symfile.c (find_separate_debug_file): Use canonical path of
2001         sysroot with child_path instead of gdb_sysroot if it is valid.
2002
2003 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2004
2005         * symfile.c (find_separate_debug_file): Use child_path to
2006         determine if an object file is under a sysroot.
2007
2008 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2009
2010         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
2011         unittests/child-path-selftests.c.
2012         * common/pathstuff.c (child_path): New function.
2013         * common/pathstuff.h (child_path): New prototype.
2014         * unittests/child-path-selftests.c: New file.
2015
2016 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2017
2018         * symfile.c (find_separate_debug_file): Look for separate debug
2019         files in debug directories under the sysroot.
2020
2021 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2022
2023         * symtab.h (struct minimal_symbol data_p): New const method.
2024         (struct minimal_symbol text_p): Likewise.
2025         * symtab.c (output_source_filename): Use file name style
2026         to print file name.
2027         (print_symbol_info): Likewise.
2028         (print_msymbol_info): Use address style to print addresses.
2029         Use function name style to print executable text symbols.
2030         (expand_symtab_containing_pc): Use data_p.
2031         (find_pc_sect_compunit_symtab): Likewise.
2032
2033 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2034
2035         * breakpoint.c (describe_other_breakpoints): Use address style
2036         to print addresses.
2037         (say_where): Likewise.
2038
2039 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2040
2041         * ada-typeprint.c (print_func_type): Print function name
2042         style to print function name.
2043         * c-typeprint.c (c_print_type_1): Likewise.
2044
2045 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
2046
2047         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
2048         for execve.
2049
2050 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2051
2052         * c-exp.y (direct_abs_decl): Use emplace_back to record the
2053         type_stack.
2054
2055 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
2056
2057         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
2058         TYPE_CODE_REF types.
2059
2060 2019-02-08  Jim Wilson  <jimw@sifive.com>
2061
2062         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
2063         (riscv_linux_fregset): New.
2064         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
2065
2066 2019-02-07  Tom Tromey  <tom@tromey.com>
2067
2068         * thread.c (thread_cancel_execution_command): Update.
2069         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
2070         methods.
2071         (struct thread_fsm_ops): Remove.
2072         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
2073         (thread_fsm_should_stop, thread_fsm_return_value)
2074         (thread_fsm_set_finished, thread_fsm_finished_p)
2075         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
2076         Don't declare.
2077         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
2078         * infrun.c (clear_proceed_status_thread)
2079         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
2080         (print_stop_event): Update.
2081         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
2082         Add constructor.
2083         (step_command_fsm_ops): Remove.
2084         (new_step_command_fsm): Remove.
2085         (step_1): Update.
2086         (step_command_fsm::should_stop): Rename from
2087         step_command_fsm_should_stop.
2088         (step_command_fsm::clean_up): Rename from
2089         step_command_fsm_clean_up.
2090         (step_command_fsm::do_async_reply_reason): Rename from
2091         step_command_fsm_async_reply_reason.
2092         (struct until_next_fsm): Inherit from thread_fsm.  Add
2093         constructor.
2094         (until_next_fsm_ops): Remove.
2095         (new_until_next_fsm): Remove.
2096         (until_next_fsm::should_stop): Rename from
2097         until_next_fsm_should_stop.
2098         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
2099         (until_next_fsm::do_async_reply_reason): Rename from
2100         until_next_fsm_async_reply_reason.
2101         (struct finish_command_fsm): Inherit from thread_fsm.  Add
2102         constructor.  Change type of breakpoint.
2103         (finish_command_fsm_ops): Remove.
2104         (new_finish_command_fsm): Remove.
2105         (finish_command_fsm::should_stop): Rename from
2106         finish_command_fsm_should_stop.
2107         (finish_command_fsm::clean_up): Rename from
2108         finish_command_fsm_clean_up.
2109         (finish_command_fsm::return_value): Rename from
2110         finish_command_fsm_return_value.
2111         (finish_command_fsm::do_async_reply_reason): Rename from
2112         finish_command_fsm_async_reply_reason.
2113         (finish_command): Update.
2114         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
2115         Add constructor.
2116         (call_thread_fsm_ops): Remove.
2117         (call_thread_fsm::call_thread_fsm): Rename from
2118         new_call_thread_fsm.
2119         (call_thread_fsm::should_stop): Rename from
2120         call_thread_fsm_should_stop.
2121         (call_thread_fsm::should_notify_stop): Rename from
2122         call_thread_fsm_should_notify_stop.
2123         (run_inferior_call, call_function_by_hand_dummy): Update.
2124         * cli/cli-interp.c (should_print_stop_to_console): Update.
2125         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
2126         Add constructor.  Change type of location_breakpoint,
2127         caller_breakpoint.
2128         (until_break_fsm_ops): Remove.
2129         (new_until_break_fsm): Remove.
2130         (until_break_fsm::should_stop): Rename from
2131         until_break_fsm_should_stop.
2132         (until_break_fsm::clean_up): Rename from
2133         until_break_fsm_clean_up.
2134         (until_break_fsm::do_async_reply_reason): Rename from
2135         until_break_fsm_async_reply_reason.
2136         (until_break_command): Update.
2137         * thread-fsm.c: Remove.
2138         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
2139
2140 2019-02-07  Tom Tromey  <tom@tromey.com>
2141
2142         * yy-remap.h: Add include guard.
2143         * xtensa-tdep.h: Add include guard.
2144         * xcoffread.h: Rename include guard.
2145         * varobj-iter.h: Add include guard.
2146         * tui/tui.h: Rename include guard.
2147         * tui/tui-winsource.h: Rename include guard.
2148         * tui/tui-wingeneral.h: Rename include guard.
2149         * tui/tui-windata.h: Rename include guard.
2150         * tui/tui-win.h: Rename include guard.
2151         * tui/tui-stack.h: Rename include guard.
2152         * tui/tui-source.h: Rename include guard.
2153         * tui/tui-regs.h: Rename include guard.
2154         * tui/tui-out.h: Rename include guard.
2155         * tui/tui-layout.h: Rename include guard.
2156         * tui/tui-io.h: Rename include guard.
2157         * tui/tui-hooks.h: Rename include guard.
2158         * tui/tui-file.h: Rename include guard.
2159         * tui/tui-disasm.h: Rename include guard.
2160         * tui/tui-data.h: Rename include guard.
2161         * tui/tui-command.h: Rename include guard.
2162         * tic6x-tdep.h: Add include guard.
2163         * target/waitstatus.h: Rename include guard.
2164         * target/wait.h: Rename include guard.
2165         * target/target.h: Rename include guard.
2166         * target/resume.h: Rename include guard.
2167         * target-float.h: Rename include guard.
2168         * stabsread.h: Add include guard.
2169         * rs6000-tdep.h: Add include guard.
2170         * riscv-fbsd-tdep.h: Add include guard.
2171         * regformats/regdef.h: Rename include guard.
2172         * record.h: Rename include guard.
2173         * python/python.h: Rename include guard.
2174         * python/python-internal.h: Rename include guard.
2175         * python/py-stopevent.h: Rename include guard.
2176         * python/py-ref.h: Rename include guard.
2177         * python/py-record.h: Rename include guard.
2178         * python/py-record-full.h: Rename include guard.
2179         * python/py-record-btrace.h: Rename include guard.
2180         * python/py-instruction.h: Rename include guard.
2181         * python/py-events.h: Rename include guard.
2182         * python/py-event.h: Rename include guard.
2183         * procfs.h: Add include guard.
2184         * proc-utils.h: Add include guard.
2185         * p-lang.h: Add include guard.
2186         * or1k-tdep.h: Rename include guard.
2187         * observable.h: Rename include guard.
2188         * nto-tdep.h: Rename include guard.
2189         * nat/x86-linux.h: Rename include guard.
2190         * nat/x86-linux-dregs.h: Rename include guard.
2191         * nat/x86-gcc-cpuid.h: Add include guard.
2192         * nat/x86-dregs.h: Rename include guard.
2193         * nat/x86-cpuid.h: Rename include guard.
2194         * nat/ppc-linux.h: Rename include guard.
2195         * nat/mips-linux-watch.h: Rename include guard.
2196         * nat/linux-waitpid.h: Rename include guard.
2197         * nat/linux-ptrace.h: Rename include guard.
2198         * nat/linux-procfs.h: Rename include guard.
2199         * nat/linux-osdata.h: Rename include guard.
2200         * nat/linux-nat.h: Rename include guard.
2201         * nat/linux-namespaces.h: Rename include guard.
2202         * nat/linux-btrace.h: Rename include guard.
2203         * nat/glibc_thread_db.h: Rename include guard.
2204         * nat/gdb_thread_db.h: Rename include guard.
2205         * nat/gdb_ptrace.h: Rename include guard.
2206         * nat/fork-inferior.h: Rename include guard.
2207         * nat/amd64-linux-siginfo.h: Rename include guard.
2208         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
2209         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
2210         * nat/aarch64-linux.h: Rename include guard.
2211         * nat/aarch64-linux-hw-point.h: Rename include guard.
2212         * mn10300-tdep.h: Add include guard.
2213         * mips-linux-tdep.h: Add include guard.
2214         * mi/mi-parse.h: Rename include guard.
2215         * mi/mi-out.h: Rename include guard.
2216         * mi/mi-main.h: Rename include guard.
2217         * mi/mi-interp.h: Rename include guard.
2218         * mi/mi-getopt.h: Rename include guard.
2219         * mi/mi-console.h: Rename include guard.
2220         * mi/mi-common.h: Rename include guard.
2221         * mi/mi-cmds.h: Rename include guard.
2222         * mi/mi-cmd-break.h: Rename include guard.
2223         * m2-lang.h: Add include guard.
2224         * location.h: Rename include guard.
2225         * linux-record.h: Rename include guard.
2226         * linux-nat.h: Add include guard.
2227         * linux-fork.h: Add include guard.
2228         * i386-darwin-tdep.h: Rename include guard.
2229         * hppa-linux-offsets.h: Add include guard.
2230         * guile/guile.h: Rename include guard.
2231         * guile/guile-internal.h: Rename include guard.
2232         * gnu-nat.h: Rename include guard.
2233         * gdb-stabs.h: Rename include guard.
2234         * frv-tdep.h: Add include guard.
2235         * f-lang.h: Add include guard.
2236         * event-loop.h: Add include guard.
2237         * darwin-nat.h: Rename include guard.
2238         * cp-abi.h: Rename include guard.
2239         * config/sparc/nm-sol2.h: Rename include guard.
2240         * config/nm-nto.h: Rename include guard.
2241         * config/nm-linux.h: Add include guard.
2242         * config/i386/nm-i386gnu.h: Rename include guard.
2243         * config/djgpp/nl_types.h: Rename include guard.
2244         * config/djgpp/langinfo.h: Rename include guard.
2245         * compile/gcc-cp-plugin.h: Add include guard.
2246         * compile/gcc-c-plugin.h: Add include guard.
2247         * compile/compile.h: Rename include guard.
2248         * compile/compile-object-run.h: Rename include guard.
2249         * compile/compile-object-load.h: Rename include guard.
2250         * compile/compile-internal.h: Rename include guard.
2251         * compile/compile-cplus.h: Rename include guard.
2252         * compile/compile-c.h: Rename include guard.
2253         * common/xml-utils.h: Rename include guard.
2254         * common/x86-xstate.h: Rename include guard.
2255         * common/version.h: Rename include guard.
2256         * common/vec.h: Rename include guard.
2257         * common/tdesc.h: Rename include guard.
2258         * common/selftest.h: Rename include guard.
2259         * common/scoped_restore.h: Rename include guard.
2260         * common/scoped_mmap.h: Rename include guard.
2261         * common/scoped_fd.h: Rename include guard.
2262         * common/safe-iterator.h: Rename include guard.
2263         * common/run-time-clock.h: Rename include guard.
2264         * common/refcounted-object.h: Rename include guard.
2265         * common/queue.h: Rename include guard.
2266         * common/ptid.h: Rename include guard.
2267         * common/print-utils.h: Rename include guard.
2268         * common/preprocessor.h: Rename include guard.
2269         * common/pathstuff.h: Rename include guard.
2270         * common/observable.h: Rename include guard.
2271         * common/netstuff.h: Rename include guard.
2272         * common/job-control.h: Rename include guard.
2273         * common/host-defs.h: Rename include guard.
2274         * common/gdb_wait.h: Rename include guard.
2275         * common/gdb_vecs.h: Rename include guard.
2276         * common/gdb_unlinker.h: Rename include guard.
2277         * common/gdb_unique_ptr.h: Rename include guard.
2278         * common/gdb_tilde_expand.h: Rename include guard.
2279         * common/gdb_sys_time.h: Rename include guard.
2280         * common/gdb_string_view.h: Rename include guard.
2281         * common/gdb_splay_tree.h: Rename include guard.
2282         * common/gdb_setjmp.h: Rename include guard.
2283         * common/gdb_ref_ptr.h: Rename include guard.
2284         * common/gdb_optional.h: Rename include guard.
2285         * common/gdb_locale.h: Rename include guard.
2286         * common/gdb_assert.h: Rename include guard.
2287         * common/filtered-iterator.h: Rename include guard.
2288         * common/filestuff.h: Rename include guard.
2289         * common/fileio.h: Rename include guard.
2290         * common/environ.h: Rename include guard.
2291         * common/common-utils.h: Rename include guard.
2292         * common/common-types.h: Rename include guard.
2293         * common/common-regcache.h: Rename include guard.
2294         * common/common-inferior.h: Rename include guard.
2295         * common/common-gdbthread.h: Rename include guard.
2296         * common/common-exceptions.h: Rename include guard.
2297         * common/common-defs.h: Rename include guard.
2298         * common/common-debug.h: Rename include guard.
2299         * common/cleanups.h: Rename include guard.
2300         * common/buffer.h: Rename include guard.
2301         * common/btrace-common.h: Rename include guard.
2302         * common/break-common.h: Rename include guard.
2303         * cli/cli-utils.h: Rename include guard.
2304         * cli/cli-style.h: Rename include guard.
2305         * cli/cli-setshow.h: Rename include guard.
2306         * cli/cli-script.h: Rename include guard.
2307         * cli/cli-interp.h: Rename include guard.
2308         * cli/cli-decode.h: Rename include guard.
2309         * cli/cli-cmds.h: Rename include guard.
2310         * charset-list.h: Add include guard.
2311         * buildsym-legacy.h: Rename include guard.
2312         * bfin-tdep.h: Add include guard.
2313         * ax.h: Rename include guard.
2314         * arm-linux-tdep.h: Add include guard.
2315         * arm-fbsd-tdep.h: Add include guard.
2316         * arch/xtensa.h: Rename include guard.
2317         * arch/tic6x.h: Add include guard.
2318         * arch/i386.h: Add include guard.
2319         * arch/arm.h: Rename include guard.
2320         * arch/arm-linux.h: Rename include guard.
2321         * arch/arm-get-next-pcs.h: Rename include guard.
2322         * arch/amd64.h: Add include guard.
2323         * arch/aarch64-insn.h: Rename include guard.
2324         * arch-utils.h: Rename include guard.
2325         * annotate.h: Add include guard.
2326         * amd64-darwin-tdep.h: Rename include guard.
2327         * aarch64-linux-tdep.h: Add include guard.
2328         * aarch64-fbsd-tdep.h: Add include guard.
2329         * aarch32-linux-nat.h: Add include guard.
2330
2331 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2332
2333         * macrotab.c (macro_define_internal): New function that
2334         factorizes macro_define_object_internal and macro_define_function
2335         code.
2336         (macro_define_object_internal): Use macro_define_internal.
2337         (macro_define_function): Likewise.
2338
2339 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2340
2341         * macrocmd.c (extract_identifier): Return
2342         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
2343         callers.
2344
2345 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
2346
2347         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
2348
2349 2019-02-05  Tom Tromey  <tom@tromey.com>
2350
2351         * target.c (target_stack::unpush): Move assertion earlier.
2352
2353 2019-01-30  Tom Tromey  <tom@tromey.com>
2354
2355         PR python/23615:
2356         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
2357         (gdbpy_parse_and_eval): Likewise.
2358         * python/python-internal.h (gdbpy_allow_threads): New class.
2359
2360 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
2361
2362         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
2363         (aarch64_fbsd_fpregmap): Move earlier.
2364         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
2365         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2366         instead of individual calls to trad_frame_set_reg_addr.
2367         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
2368         earlier.
2369         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
2370         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2371         instead of individual calls to trad_frame_set_reg_addr.
2372
2373 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
2374
2375         * CONTRIBUTE: Replace contribution list with wiki link.
2376
2377 2019-01-25  Tom Tromey  <tom@tromey.com>
2378
2379         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
2380
2381 2019-01-25  Tom Tromey  <tom@tromey.com>
2382
2383         * xtensa-linux-nat.c: Fix common/ includes.
2384         * xml-support.h: Fix common/ includes.
2385         * xml-support.c: Fix common/ includes.
2386         * x86-linux-nat.c: Fix common/ includes.
2387         * windows-nat.c: Fix common/ includes.
2388         * varobj.h: Fix common/ includes.
2389         * varobj.c: Fix common/ includes.
2390         * value.c: Fix common/ includes.
2391         * valops.c: Fix common/ includes.
2392         * utils.c: Fix common/ includes.
2393         * unittests/xml-utils-selftests.c: Fix common/ includes.
2394         * unittests/utils-selftests.c: Fix common/ includes.
2395         * unittests/unpack-selftests.c: Fix common/ includes.
2396         * unittests/tracepoint-selftests.c: Fix common/ includes.
2397         * unittests/style-selftests.c: Fix common/ includes.
2398         * unittests/string_view-selftests.c: Fix common/ includes.
2399         * unittests/scoped_restore-selftests.c: Fix common/ includes.
2400         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
2401         * unittests/scoped_fd-selftests.c: Fix common/ includes.
2402         * unittests/rsp-low-selftests.c: Fix common/ includes.
2403         * unittests/parse-connection-spec-selftests.c: Fix common/
2404         includes.
2405         * unittests/optional-selftests.c: Fix common/ includes.
2406         * unittests/offset-type-selftests.c: Fix common/ includes.
2407         * unittests/observable-selftests.c: Fix common/ includes.
2408         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
2409         * unittests/memrange-selftests.c: Fix common/ includes.
2410         * unittests/memory-map-selftests.c: Fix common/ includes.
2411         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
2412         * unittests/function-view-selftests.c: Fix common/ includes.
2413         * unittests/environ-selftests.c: Fix common/ includes.
2414         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
2415         * unittests/common-utils-selftests.c: Fix common/ includes.
2416         * unittests/cli-utils-selftests.c: Fix common/ includes.
2417         * unittests/array-view-selftests.c: Fix common/ includes.
2418         * ui-file.c: Fix common/ includes.
2419         * tui/tui-io.c: Fix common/ includes.
2420         * tracepoint.h: Fix common/ includes.
2421         * tracepoint.c: Fix common/ includes.
2422         * tracefile-tfile.c: Fix common/ includes.
2423         * top.h: Fix common/ includes.
2424         * top.c: Fix common/ includes.
2425         * thread.c: Fix common/ includes.
2426         * target/waitstatus.h: Fix common/ includes.
2427         * target/waitstatus.c: Fix common/ includes.
2428         * target.h: Fix common/ includes.
2429         * target.c: Fix common/ includes.
2430         * target-memory.c: Fix common/ includes.
2431         * target-descriptions.c: Fix common/ includes.
2432         * symtab.h: Fix common/ includes.
2433         * symfile.c: Fix common/ includes.
2434         * stap-probe.c: Fix common/ includes.
2435         * spu-linux-nat.c: Fix common/ includes.
2436         * sparc-nat.c: Fix common/ includes.
2437         * source.c: Fix common/ includes.
2438         * solib.c: Fix common/ includes.
2439         * solib-target.c: Fix common/ includes.
2440         * ser-unix.c: Fix common/ includes.
2441         * ser-tcp.c: Fix common/ includes.
2442         * ser-pipe.c: Fix common/ includes.
2443         * ser-base.c: Fix common/ includes.
2444         * selftest-arch.c: Fix common/ includes.
2445         * s12z-tdep.c: Fix common/ includes.
2446         * rust-exp.y: Fix common/ includes.
2447         * rs6000-aix-tdep.c: Fix common/ includes.
2448         * riscv-tdep.c: Fix common/ includes.
2449         * remote.c: Fix common/ includes.
2450         * remote-notif.h: Fix common/ includes.
2451         * remote-fileio.h: Fix common/ includes.
2452         * remote-fileio.c: Fix common/ includes.
2453         * regcache.h: Fix common/ includes.
2454         * regcache.c: Fix common/ includes.
2455         * record-btrace.c: Fix common/ includes.
2456         * python/python.c: Fix common/ includes.
2457         * python/py-type.c: Fix common/ includes.
2458         * python/py-inferior.c: Fix common/ includes.
2459         * progspace.h: Fix common/ includes.
2460         * producer.c: Fix common/ includes.
2461         * procfs.c: Fix common/ includes.
2462         * proc-api.c: Fix common/ includes.
2463         * printcmd.c: Fix common/ includes.
2464         * ppc-linux-nat.c: Fix common/ includes.
2465         * parser-defs.h: Fix common/ includes.
2466         * osdata.c: Fix common/ includes.
2467         * obsd-nat.c: Fix common/ includes.
2468         * nat/x86-linux.c: Fix common/ includes.
2469         * nat/x86-linux-dregs.c: Fix common/ includes.
2470         * nat/x86-dregs.h: Fix common/ includes.
2471         * nat/x86-dregs.c: Fix common/ includes.
2472         * nat/ppc-linux.c: Fix common/ includes.
2473         * nat/mips-linux-watch.h: Fix common/ includes.
2474         * nat/mips-linux-watch.c: Fix common/ includes.
2475         * nat/linux-waitpid.c: Fix common/ includes.
2476         * nat/linux-ptrace.h: Fix common/ includes.
2477         * nat/linux-ptrace.c: Fix common/ includes.
2478         * nat/linux-procfs.c: Fix common/ includes.
2479         * nat/linux-personality.c: Fix common/ includes.
2480         * nat/linux-osdata.c: Fix common/ includes.
2481         * nat/linux-namespaces.c: Fix common/ includes.
2482         * nat/linux-btrace.h: Fix common/ includes.
2483         * nat/linux-btrace.c: Fix common/ includes.
2484         * nat/fork-inferior.c: Fix common/ includes.
2485         * nat/amd64-linux-siginfo.c: Fix common/ includes.
2486         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
2487         * nat/aarch64-linux.c: Fix common/ includes.
2488         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
2489         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
2490         * namespace.h: Fix common/ includes.
2491         * mips-linux-tdep.c: Fix common/ includes.
2492         * minsyms.c: Fix common/ includes.
2493         * mi/mi-parse.h: Fix common/ includes.
2494         * mi/mi-main.c: Fix common/ includes.
2495         * mi/mi-cmd-env.c: Fix common/ includes.
2496         * memrange.h: Fix common/ includes.
2497         * memattr.c: Fix common/ includes.
2498         * maint.h: Fix common/ includes.
2499         * maint.c: Fix common/ includes.
2500         * main.c: Fix common/ includes.
2501         * machoread.c: Fix common/ includes.
2502         * location.c: Fix common/ includes.
2503         * linux-thread-db.c: Fix common/ includes.
2504         * linux-nat.c: Fix common/ includes.
2505         * linux-fork.c: Fix common/ includes.
2506         * inline-frame.c: Fix common/ includes.
2507         * infrun.c: Fix common/ includes.
2508         * inflow.c: Fix common/ includes.
2509         * inferior.h: Fix common/ includes.
2510         * inferior.c: Fix common/ includes.
2511         * infcmd.c: Fix common/ includes.
2512         * inf-ptrace.c: Fix common/ includes.
2513         * inf-child.c: Fix common/ includes.
2514         * ia64-linux-nat.c: Fix common/ includes.
2515         * i387-tdep.c: Fix common/ includes.
2516         * i386-tdep.c: Fix common/ includes.
2517         * i386-linux-tdep.c: Fix common/ includes.
2518         * i386-linux-nat.c: Fix common/ includes.
2519         * i386-go32-tdep.c: Fix common/ includes.
2520         * i386-fbsd-tdep.c: Fix common/ includes.
2521         * i386-fbsd-nat.c: Fix common/ includes.
2522         * guile/scm-type.c: Fix common/ includes.
2523         * guile/guile.c: Fix common/ includes.
2524         * go32-nat.c: Fix common/ includes.
2525         * gnu-nat.c: Fix common/ includes.
2526         * gdbthread.h: Fix common/ includes.
2527         * gdbarch-selftests.c: Fix common/ includes.
2528         * gdb_usleep.c: Fix common/ includes.
2529         * gdb_select.h: Fix common/ includes.
2530         * gdb_bfd.c: Fix common/ includes.
2531         * gcore.c: Fix common/ includes.
2532         * fork-child.c: Fix common/ includes.
2533         * findvar.c: Fix common/ includes.
2534         * fbsd-nat.c: Fix common/ includes.
2535         * event-top.c: Fix common/ includes.
2536         * event-loop.c: Fix common/ includes.
2537         * dwarf2read.c: Fix common/ includes.
2538         * dwarf2loc.c: Fix common/ includes.
2539         * dwarf2-frame.c: Fix common/ includes.
2540         * dwarf-index-cache.c: Fix common/ includes.
2541         * dtrace-probe.c: Fix common/ includes.
2542         * disasm-selftests.c: Fix common/ includes.
2543         * defs.h: Fix common/ includes.
2544         * csky-tdep.c: Fix common/ includes.
2545         * cp-valprint.c: Fix common/ includes.
2546         * cp-support.h: Fix common/ includes.
2547         * cp-support.c: Fix common/ includes.
2548         * corelow.c: Fix common/ includes.
2549         * completer.h: Fix common/ includes.
2550         * completer.c: Fix common/ includes.
2551         * compile/compile.c: Fix common/ includes.
2552         * compile/compile-loc2c.c: Fix common/ includes.
2553         * compile/compile-cplus-types.c: Fix common/ includes.
2554         * compile/compile-cplus-symbols.c: Fix common/ includes.
2555         * command.h: Fix common/ includes.
2556         * cli/cli-dump.c: Fix common/ includes.
2557         * cli/cli-cmds.c: Fix common/ includes.
2558         * charset.c: Fix common/ includes.
2559         * build-id.c: Fix common/ includes.
2560         * btrace.h: Fix common/ includes.
2561         * btrace.c: Fix common/ includes.
2562         * breakpoint.h: Fix common/ includes.
2563         * breakpoint.c: Fix common/ includes.
2564         * ax.h:
2565         (enum agent_op): Fix common/ includes.
2566         * ax-general.c (struct aop_map): Fix common/ includes.
2567         * ax-gdb.c: Fix common/ includes.
2568         * auxv.c: Fix common/ includes.
2569         * auto-load.c: Fix common/ includes.
2570         * arm-tdep.c: Fix common/ includes.
2571         * arch/riscv.c: Fix common/ includes.
2572         * arch/ppc-linux-common.c: Fix common/ includes.
2573         * arch/i386.c: Fix common/ includes.
2574         * arch/arm.c: Fix common/ includes.
2575         * arch/arm-linux.c: Fix common/ includes.
2576         * arch/arm-get-next-pcs.c: Fix common/ includes.
2577         * arch/amd64.c: Fix common/ includes.
2578         * arch/aarch64.c: Fix common/ includes.
2579         * arch/aarch64-insn.c: Fix common/ includes.
2580         * arch-utils.c: Fix common/ includes.
2581         * amd64-windows-tdep.c: Fix common/ includes.
2582         * amd64-tdep.c: Fix common/ includes.
2583         * amd64-sol2-tdep.c: Fix common/ includes.
2584         * amd64-obsd-tdep.c: Fix common/ includes.
2585         * amd64-nbsd-tdep.c: Fix common/ includes.
2586         * amd64-linux-tdep.c: Fix common/ includes.
2587         * amd64-linux-nat.c: Fix common/ includes.
2588         * amd64-fbsd-tdep.c: Fix common/ includes.
2589         * amd64-fbsd-nat.c: Fix common/ includes.
2590         * amd64-dicos-tdep.c: Fix common/ includes.
2591         * amd64-darwin-tdep.c: Fix common/ includes.
2592         * agent.c: Fix common/ includes.
2593         * ada-lang.h: Fix common/ includes.
2594         * ada-lang.c: Fix common/ includes.
2595         * aarch64-tdep.c: Fix common/ includes.
2596
2597 2019-01-25  Tom Tromey  <tom@tromey.com>
2598
2599         * common/create-version.sh: Use common/version.h.
2600
2601 2019-01-24  Pedro Alves  <palves@redhat.com>
2602
2603         * infrun.c (signal_stop, signal_print, signal_program)
2604         (signal_catch, signal_pass): Now arrays instead of pointers.
2605         (update_signals_program_target, do_target_resume)
2606         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
2607         * linux-nat.c (linux_nat_target::pass_signals)
2608         (linux_nat_target::create_inferior, linux_nat_target::attach):
2609         Adjust.
2610         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
2611         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
2612         * procfs.c (procfs_target::pass_signals): Adjust.
2613         * record-full.c (record_full_target::resume): Adjust.
2614         * remote.c (remote_target::pass_signals)
2615         (remote_target::program_signals): Adjust.
2616         * target-debug.h (target_debug_print_signals): Now takes a
2617         gdb::array_view as parameter.  Adjust.
2618         * target.h (target_ops) <pass_signals, program_signals>: Replace
2619         pointer and length parameters with gdb::array_view.
2620         (target_pass_signals, target_program_signals): Likewise.
2621         * target-delegates.c: Regenerate.
2622
2623 2019-01-24  Pedro Alves  <palves@redhat.com>
2624
2625         * common/forward-scope-exit.h
2626         (forward_scope_exit::forward_scope_exit): Pass arguments to
2627         m_bind_function directly, instead of creating a std::bind and
2628         copying that.
2629
2630 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
2631
2632         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2633         for static members.
2634         (pass_in_v_vfp_candidate): Likewise.
2635
2636 2019-01-23  Tom Tromey  <tom@tromey.com>
2637             Pedro Alves  <palves@redhat.com>
2638
2639         * regcache.c (class regcache_invalidator): Remove.
2640         (regcache::raw_write): Use make_scope_exit.
2641
2642 2019-01-23  Tom Tromey  <tom@tromey.com>
2643
2644         * ui-out.h (class ui_out_emit_type): Update comment.
2645
2646 2019-01-23  Tom Tromey  <tom@tromey.com>
2647
2648         * infrun.c (fetch_inferior_event): Update comment.
2649
2650 2019-01-23  Tom Tromey  <tom@tromey.com>
2651             Pedro Alves  <palves@redhat.com>
2652
2653         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
2654         parameter.
2655         (fetch_inferior_event): Use SCOPE_EXIT.
2656
2657
2658 2019-01-23  Tom Tromey  <tom@tromey.com>
2659             Pedro Alves  <palves@redhat.com>
2660
2661         * infrun.c (disable_thread_events): Delete.
2662         (stop_all_threads): Use SCOPE_EXIT.
2663
2664 2019-01-23  Tom Tromey  <tom@tromey.com>
2665             Pedro Alves  <palves@redhat.com>
2666
2667         * symfile.c: Include forward-scope-exit.h.
2668         (clear_symtab_users_cleanup): Replace forward declaration with
2669         a FORWARD_SCOPE_EXIT.
2670         (syms_from_objfile_1): Use the forward_scope_exit and
2671         gdb::optional instead of cleanup_function.
2672         (reread_symbols): Use the forward_scope_exit instead of
2673         cleanup_function.
2674         (clear_symtab_users_cleanup): Remove function.
2675
2676 2019-01-23  Tom Tromey  <tom@tromey.com>
2677             Pedro Alves  <palves@redhat.com>
2678
2679         * linux-nat.c: Include scope-exit.h.
2680         (cleanup_target_stop): Remove.
2681         (linux_nat_target::static_tracepoint_markers_by_strid): Use
2682         SCOPE_EXIT.
2683
2684 2019-01-23  Tom Tromey  <tom@tromey.com>
2685             Pedro Alves  <palves@redhat.com>
2686
2687         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
2688         (call_function_by_hand_dummy): Use SCOPE_EXIT.
2689
2690 2019-01-23  Tom Tromey  <tom@tromey.com>
2691             Andrew Burgess  <andrew.burgess@embecosm.com>
2692             Pedro Alves  <palves@redhat.com>
2693
2694         * infrun.c (fetch_inferior_event): Use scope_exit.
2695         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
2696         * top.c (execute_command): Use scope_exit.
2697         * breakpoint.c (bpstat_do_actions): Use scope_exit.
2698         * utils.c (do_bpstat_clear_actions_cleanup)
2699         (make_bpstat_clear_actions_cleanup): Remove.
2700
2701 2019-01-23  Tom Tromey  <tom@tromey.com>
2702             Pedro Alves  <palves@redhat.com>
2703
2704         * infrun.c: Include "common/scope-exit.h"
2705         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
2706         (wait_for_inferior): Use SCOPE_EXIT.
2707         (fetch_inferior_event): Use scope_exit.
2708
2709 2019-01-23  Tom Tromey  <tom@tromey.com>
2710             Pedro Alves  <palves@redhat.com>
2711
2712         * breakpoint.c (create_breakpoint): Remove cleanup.
2713
2714 2019-01-23  Tom Tromey  <tom@tromey.com>
2715             Andrew Burgess  <andrew.burgess@embecosm.com>
2716             Pedro Alves  <palves@redhat.com>
2717
2718 2019-01-23  Pedro Alves  <palves@redhat.com>
2719
2720         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
2721
2722 2019-01-23  Pedro Alves  <palves@redhat.com>
2723             Andrew Burgess  <andrew.burgess@embecosm.com>
2724
2725         * gdbthread.h: Include "common/forward-scope-exit.h".
2726         (scoped_finish_thread_state): Redefine custom class in terms of
2727         forward_scope_exit.
2728
2729 2019-01-23  Pedro Alves  <palves@redhat.com>
2730             Andrew Burgess  <andrew.burgess@embecosm.com>
2731
2732         * common/forward-scope-exit.h: New file.
2733
2734 2019-01-23  Pedro Alves  <palves@redhat.com>
2735             Andrew Burgess  <andrew.burgess@embecosm.com>
2736             Tom Tromey  <tom@tromey.com>
2737
2738         * common/scope-exit.h: New file.
2739
2740 2019-01-23  Pedro Alves  <palves@redhat.com>
2741
2742         * common/preprocessor.h (ESC): Rename to ...
2743         (ESC_PARENS): ... this.
2744         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
2745         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
2746
2747 2019-01-23  Tom Tromey  <tom@tromey.com>
2748
2749         * language.h (class scoped_switch_to_sym_language_if_auto):
2750         Initialize m_lang in both cases.
2751
2752 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
2753
2754         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
2755         with XCNEW.
2756
2757 2019-01-22  Tom Tromey  <tom@tromey.com>
2758
2759         * corelow.c: Do not include sys/file.h.
2760
2761 2019-01-22  Tom Tromey  <tom@tromey.com>
2762
2763         * tui/tui-wingeneral.h: Include gdb_curses.h.
2764
2765 2019-01-22  Tom Tromey  <tom@tromey.com>
2766
2767         * source-cache.h (class source_cache) <get_source_lines,
2768         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
2769
2770 2019-01-22  Tom Tromey  <tom@tromey.com>
2771
2772         * remote-fileio.h (struct remote_target): Declare.
2773
2774 2019-01-22  Tom Tromey  <tom@tromey.com>
2775
2776         * python/py-arch.c: Do not include py-ref.h.
2777         * python/py-bpevent.c: Do not include py-ref.h.
2778         * python/py-cmd.c: Do not include py-ref.h.
2779         * python/py-continueevent.c: Do not include py-ref.h.
2780         * python/py-event.h: Do not include py-ref.h.
2781         * python/py-evtregistry.c: Do not include py-ref.h.
2782         * python/py-finishbreakpoint.c: Do not include py-ref.h.
2783         * python/py-frame.c: Do not include py-ref.h.
2784         * python/py-framefilter.c: Do not include py-ref.h.
2785         * python/py-function.c: Do not include py-ref.h.
2786         * python/py-infevents.c: Do not include py-ref.h.
2787         * python/py-linetable.c: Do not include py-ref.h.
2788         * python/py-objfile.c: Do not include py-ref.h.
2789         * python/py-param.c: Do not include py-ref.h.
2790         * python/py-prettyprint.c: Do not include py-ref.h.
2791         * python/py-progspace.c: Do not include py-ref.h.
2792         * python/py-symbol.c: Do not include py-ref.h.
2793         * python/py-symtab.c: Do not include py-ref.h.
2794         * python/py-type.c: Do not include py-ref.h.
2795         * python/py-unwind.c: Do not include py-ref.h.
2796         * python/py-utils.c: Do not include py-ref.h.
2797         * python/py-value.c: Do not include py-ref.h.
2798         * python/py-varobj.c: Do not include py-ref.h.
2799         * python/py-xmethods.c: Do not include py-ref.h.
2800         * python/python.c: Do not include py-ref.h.
2801         * varobj.c: Do not include py-ref.h.
2802
2803 2019-01-22  Tom Tromey  <tom@tromey.com>
2804
2805         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
2806         keyword for bcache.
2807
2808 2019-01-22  Tom Tromey  <tom@tromey.com>
2809
2810         * compile/compile-cplus-types.c: Remove a comment by #include.
2811
2812 2019-01-22  Tom Tromey  <tom@tromey.com>
2813
2814         * compile/gcc-c-plugin.h: Include compile-internal.h.
2815
2816 2019-01-22  Tom Tromey  <tom@tromey.com>
2817
2818         * stabsread.c (EXTERN): Do not define.
2819         (symnum, next_symbol_text_func, processing_gcc_compilation)
2820         (within_function, global_sym_chain, global_stabs)
2821         (previous_stab_code, this_object_header_files)
2822         (n_this_object_header_files)
2823         (n_allocated_this_object_header_files): Define.
2824         * stabsread.h (EXTERN): Never define.  Use "extern".
2825
2826 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2827
2828         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
2829         history_value.
2830
2831 2019-01-21  Tom Tromey  <tom@tromey.com>
2832
2833         * ui-out.c: Fix includes.
2834         * tui/tui-source.c: Fix includes.
2835         * target.c: Fix includes.
2836         * remote.c: Fix includes.
2837         * regcache.c: Fix includes.
2838         * python/py-block.c: Fix includes.
2839         * printcmd.c: Fix includes.
2840         * or1k-tdep.c: Fix includes.
2841         * mi/mi-main.c: Fix includes.
2842         * m32r-tdep.c: Fix includes.
2843         * csky-tdep.c: Fix includes.
2844         * compile/compile-cplus-types.c: Fix includes.
2845         * cli/cli-interp.c: Fix includes.
2846
2847 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
2848
2849         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2850         for padding.
2851
2852 2019-01-16  Tom Tromey  <tom@tromey.com>
2853
2854         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
2855         earlier.
2856         (struct objfile) <msymbols_range>: Move from top level.
2857         <msymbols>: New method.
2858         (class objfile_msymbols): Remove.
2859         * symtab.c (default_collect_symbol_completion_matches_break_on):
2860         Update.
2861         * symmisc.c (dump_msymbols): Update.
2862         * stabsread.c (scan_file_globals): Update.
2863         * objc-lang.c (info_selectors_command, info_classes_command)
2864         (find_methods): Update.
2865         * minsyms.c (find_solib_trampoline_target): Update.
2866         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2867         * coffread.c (coff_symfile_read): Update.
2868         * ada-lang.c (ada_lookup_simple_minsym)
2869         (ada_collect_symbol_completion_matches): Update.
2870
2871 2019-01-16  Tom Tromey  <tom@tromey.com>
2872
2873         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
2874         type.  Remove no-argument constructor.
2875         <iterator::operator++>: Simplify.
2876         <begin>: Update.
2877         <end>: Use minimal_symbol_count.
2878
2879 2019-01-16  Tom Tromey  <tom@tromey.com>
2880
2881         * objfiles.h (struct objfile) <psymtabs>: New method.
2882         (class objfile_psymtabs): Remove.
2883         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
2884         typedef.
2885         <range>: New method.
2886         (require_partial_symbols): Change return type.
2887         * psymtab.c (require_partial_symbols)
2888         (psym_expand_symtabs_matching): Update.
2889         * mdebugread.c (parse_partial_symbols): Update.
2890         * dbxread.c (dbx_end_psymtab): Update.
2891
2892 2019-01-15  Tom Tromey  <tom@tromey.com>
2893
2894         * symtab.c (lookup_objfile_from_block)
2895         (lookup_symbol_in_objfile_symtabs)
2896         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
2897         (find_line_symtab, info_sources_command)
2898         (default_collect_symbol_completion_matches_break_on)
2899         (make_source_files_completion_list): Update.
2900         * symmisc.c (print_objfile_statistics, dump_objfile)
2901         (maintenance_print_symbols, maintenance_info_symtabs)
2902         (maintenance_check_symtabs, maintenance_info_line_tables):
2903         Update.
2904         * source.c (select_source_symtab)
2905         (forget_cached_source_info_for_objfile): Update.
2906         * objfiles.h (class objfile_compunits): Remove.
2907         (struct objfile) <compunits_range>: New typedef.
2908         (compunits): New method.
2909         * objfiles.c (objfile_relocate1): Update.
2910         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2911         * maint.c (count_symtabs_and_blocks): Update.
2912         * linespec.c (iterate_over_all_matching_symtabs): Update.
2913         * cp-support.c (add_symbol_overload_list_qualified): Update.
2914         * coffread.c (coff_symtab_read): Update.
2915         * ada-lang.c (add_nonlocal_symbols)
2916         (ada_collect_symbol_completion_matches)
2917         (ada_add_global_exceptions): Update.
2918
2919 2019-01-15  Tom Tromey  <tom@tromey.com>
2920
2921         * progspace.h (program_space) <objfiles_safe_range>: New
2922         typedef.
2923         <objfiles_safe>: New method.
2924         * objfiles.h (class all_objfiles_safe): Remove.
2925         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
2926         * jit.c (jit_inferior_exit_hook): Update.
2927
2928 2019-01-17  Tom Tromey  <tom@tromey.com>
2929
2930         * progspace.h (program_space) <objfiles_range>: New typedef.
2931         <objfiles>: New method.
2932         <objfiles_head>: Rename from objfiles.
2933         (object_files): Update.
2934         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
2935         * guile/scm-pretty-print.c
2936         (ppscm_find_pretty_printer_from_objfiles): Update.
2937         * guile/scm-objfile.c (gdbscm_objfiles): Update.
2938         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
2939         Update.
2940         * python/py-progspace.c (pspy_get_objfiles): Update.
2941         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2942         Update.
2943         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2944         (objfpy_lookup_objfile_by_build_id): Update.
2945         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2946         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2947         Update.
2948         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2949         (expand_symtab_containing_pc, lookup_objfile_from_block)
2950         (lookup_static_symbol, basic_lookup_transparent_type)
2951         (find_pc_sect_compunit_symtab, find_symbol_at_address)
2952         (find_line_symtab, info_sources_command)
2953         (default_collect_symbol_completion_matches_break_on)
2954         (make_source_files_completion_list, find_main_name): Update.
2955         * symmisc.c (print_symbol_bcache_statistics)
2956         (print_objfile_statistics, maintenance_print_symbols)
2957         (maintenance_print_msymbols, maintenance_print_objfiles)
2958         (maintenance_info_symtabs, maintenance_check_symtabs)
2959         (maintenance_expand_symtabs, maintenance_info_line_tables):
2960         Update.
2961         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
2962         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
2963         (map_overlay_command, unmap_overlay_command)
2964         (simple_overlay_update, expand_symtabs_matching)
2965         (map_symbol_filenames): Update.
2966         * symfile-debug.c (set_debug_symfile): Update.
2967         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
2968         Update.
2969         * source.c (select_source_symtab, forget_cached_source_info):
2970         Update.
2971         * solib.c (solib_read_symbols): Update.
2972         * solib-spu.c (append_ocl_sos): Update.
2973         * psymtab.c (maintenance_print_psymbols)
2974         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
2975         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
2976         * printcmd.c (info_symbol_command): Update.
2977         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
2978         Update.
2979         * objfiles.h (class all_objfiles): Remove.
2980         * objfiles.c (have_partial_symbols, have_full_symbols)
2981         (have_minimal_symbols, qsort_cmp, update_section_map)
2982         (shared_objfile_contains_address_p)
2983         (default_iterate_over_objfiles_in_search_order): Update.
2984         * objc-lang.c (info_selectors_command, info_classes_command)
2985         (find_methods): Update.
2986         * minsyms.c (find_solib_trampoline_target): Update.
2987         * maint.c (maintenance_info_sections)
2988         (maintenance_translate_address, count_symtabs_and_blocks):
2989         Update.
2990         * main.c (captured_main_1): Update.
2991         * linux-thread-db.c (try_thread_db_load_from_pdir)
2992         (has_libpthread): Update.
2993         * linespec.c (iterate_over_all_matching_symtabs)
2994         (search_minsyms_for_name): Update.
2995         * jit.c (jit_find_objf_with_entry_addr): Update.
2996         * hppa-tdep.c (find_unwind_entry)
2997         (hppa_lookup_stub_minimal_symbol): Update.
2998         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
2999         Update.
3000         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3001         (elf_gnu_ifunc_resolve_by_got): Update.
3002         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
3003         * dwarf-index-write.c (save_gdb_index_command): Update.
3004         * cp-support.c (add_symbol_overload_list_qualified): Update.
3005         * breakpoint.c (create_overlay_event_breakpoint)
3006         (create_longjmp_master_breakpoint)
3007         (create_std_terminate_master_breakpoint)
3008         (create_exception_master_breakpoint): Update.
3009         * blockframe.c (find_pc_partial_function): Update.
3010         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
3011         (ada_collect_symbol_completion_matches)
3012         (ada_add_global_exceptions): Update.
3013
3014 2019-01-17  Tom Tromey  <tom@tromey.com>
3015
3016         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
3017         declare VEC.
3018         (solib_target_parse_libraries): Change return type.
3019         (library_list_start_segment, library_list_start_section)
3020         (library_list_end_library, library_list_start_library); Update.
3021         (solib_target_free_library_list): Remove.
3022         (solib_target_parse_libraries): Remove cleanup.  Change return
3023         type.
3024         (solib_target_current_sos): Update.
3025
3026 2019-01-17  Tom Tromey  <tromey@bapiya>
3027
3028         * valprint.c: Replace "the the" with "the".
3029         * symtab.c: Replace "the the" with "the".
3030         * solib.c: Replace "the the" with "the".
3031         * solib-dsbt.c: Replace "the the" with "the".
3032         * linespec.c: Replace "the the" with "the".
3033         * dwarf2loc.h: Replace "the the" with "the".
3034         * amd64-windows-tdep.c: Replace "the the" with "the".
3035         * aarch64-tdep.c: Replace "the the" with "the".
3036
3037 2019-01-16  Keith Seitz  <keiths@redhat.com>
3038
3039         PR gdb/23773
3040         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
3041         <builder>: Rename to ..
3042         <m_builder>: ... this and make private.
3043         (dwarf2_cu::get_builder): New method.  Change all users of
3044         `builder' to use this method.
3045         (dwarf2_start_symtab): Move to ...
3046         (dwarf2_cu::start_symtab): ... here.  Update all callers
3047         (setup_type_unit_groups): Move to ...
3048         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
3049         callers.
3050         (dwarf2_cu::reset_builder): New method.
3051         (process_full_compunit, process_full_type_unit): Use
3052         dwarf2_cu::reset_builder.
3053         (follow_die_offset): Record the ancestor CU if it is different
3054         from the followed DIE's CU.
3055         (follow_die_sig_1): Likewise.
3056
3057 2019-01-15  Tom Tromey  <tom@tromey.com>
3058
3059         * remote.c (class remote_state) <buf>: Now a char_vector.
3060         <buf_size>: Remove.
3061         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
3062         parameter.
3063         (remote_target::getpkt_or_notif_sane_1)
3064         (remote_target::getpkt_sane)
3065         (remote_target::getpkt_or_notif_sane): Likewise.
3066         (class remote_target) <putpkt>: New overload.
3067         (remote_target::read_frame): Change type of "buf_p".  Remove
3068         sizeof_p parameter.
3069         (packet_ok): New overload.
3070         (packet_check_result): New overload.
3071         Update all uses.
3072
3073 2019-01-14  Tom Tromey  <tom@tromey.com>
3074
3075         * remote-notif.c (handle_notification, remote_notif_ack)
3076         (remote_notif_parse): Make "buf" const.
3077         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
3078         const.
3079         (remote_notif_parse, remote_notif_ack, handle_notification):
3080         Likewise.
3081         * remote.c (remote_notif_stop_parse): Make "buf" const.
3082         (remote_target::remote_parse_stop_reply): Make "buf" const.
3083         (remote_notif_stop_ack): Make "buf" const.
3084
3085 2019-01-14  Tom Tromey  <tom@tromey.com>
3086
3087         * remote.c (remote_console_output): Make parameter const.
3088
3089 2019-01-14  Tom Tromey  <tom@tromey.com>
3090
3091         * target-debug.h (target_debug_print_signals): Constify.
3092         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
3093         * procfs.c (procfs_target::pass_signals): Update.
3094         * linux-nat.c (linux_nat_target::pass_signals): Update.
3095         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
3096         * target-delegates.c: Rebuild.
3097         * remote.c (remote_target::program_signals): Update.
3098         (remote_target::pass_signals): Update.
3099         * target.c (target_pass_signals): Constify argument.
3100         (target_program_signals): Likewise.
3101         * target.h (struct target_ops) <pass_signals, program_signals>:
3102         Constify argument.
3103         (target_pass_signals, target_program_signals): Constify argument.
3104
3105 2019-01-14  Tom Tromey  <tom@tromey.com>
3106
3107         PR tui/28819:
3108         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
3109
3110 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3111
3112         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
3113         field.
3114         * rs6000-tdep.c: Include reggroups.h.
3115         (IS_V_ALIAS_PSEUDOREG): Define.
3116         (rs6000_register_name): Return names for the "vX" aliases.
3117         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
3118         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
3119         aliases.  Call default_register_reggroup_p for all other
3120         pseudo-registers.
3121         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
3122         New functions.
3123         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
3124         Handle "vX" aliases.
3125         (v_alias_pseudo_register_collect): New function.
3126         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
3127         (rs6000_gdbarch_init): Initialize "vX" aliases as
3128         pseudo-registers.  Restore registration of
3129         rs6000_pseudo_register_reggroup_p with
3130         set_tdesc_pseudo_register_reggroup_p.
3131
3132 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
3133
3134         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
3135         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
3136         set_gdbarch_num_pseudo_regs.
3137
3138 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3139
3140         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
3141         Remove arg prefixname, add do_set and do_show.
3142         Add member functions set_list and show_list.
3143         * cli/cli-style.c (class cli_style_option): Update accordingly.
3144         (style_set_list): Move to file scope.
3145         (style_show_list): Likewise.
3146         (set_style): Call help_list.
3147         (show_style): Call cmd_show_list.
3148         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
3149         Update to use the new macro.
3150
3151 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
3152
3153         * ada-lang.c (_initialize_ada_language): Expand the help text
3154         for the "catch exception" command.
3155
3156 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3157
3158         * symtab.c (matching_obj_sections): Initialize obj,
3159         declare it closer to its usage.
3160
3161 2019-01-10  Tom Tromey  <tom@tromey.com>
3162
3163         * thread-iter.h (inf_threads_iterator): Use next_iterator.
3164         (basic_inf_threads_range): Remove.
3165         (inf_threads_range, inf_non_exited_threads_range)
3166         (safe_inf_threads_range): Use next_adapter.
3167
3168 2019-01-10  Keith Seitz  <keiths@redhat.com>
3169
3170         PR gdb/23712
3171         PR symtab/23010
3172         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
3173         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
3174
3175 2019-01-10  Keith Seitz  <keiths@redhat.com>
3176
3177         PR gdb/23712
3178         PR symtab/23010
3179         * dictionary.c (pending_to_vector): Remove.
3180         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3181         Remove _1 suffix, replacing functions of the same name.  Update
3182         all callers.
3183         (dict_create_hashed, dict_create_hashed_expandable)
3184         (dict_create_linear, dict_create_linear_expandable, dict_free)
3185         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
3186         Make functions static.
3187
3188 2019-01-10  Keith Seitz  <keiths@redhat.com>
3189
3190         PR gdb/23712
3191         PR symtab/23010
3192         * dictionary.h (struct dictionary): Replace declaration with
3193         multidictionary.
3194         (dict_create_hashed, dict_create_hashed_expandable)
3195         (dict_create_linear, dict_create_linear_expandable)
3196         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
3197         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
3198         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
3199         taking multidictionary argument.
3200         [ALL_DICT_SYMBOLS]: Update for multidictionary.
3201         * block.h (struct block) <dict>: Change to multidictionary
3202         and rename `multidict'.
3203         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
3204         symmisc.c: Update all dictionary references to multidictionary.
3205
3206 2019-01-10  Keith Seitz  <keiths@redhat.com>
3207
3208         PR gdb/23712
3209         PR symtab/23010
3210         * dictionary.c: Include unordered_map.
3211         (pending_to_vector): New function.
3212         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3213         Rewrite the non-"_1" functions to take vector instead
3214         of linked list.
3215         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
3216         "new" _1 versions of the same name.
3217         (multidictionary): Define.
3218         (std::hash<enum language): New definition.
3219         (collate_pending_symbols_by_language, mdict_create_hashed)
3220         (mdict_create_hashed_expandable, mdict_create_linear)
3221         (mdict_create_linear_expandable, mdict_free)
3222         (find_language_dictionary, create_new_language_dictionary)
3223         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
3224         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
3225         (mdict_size, mdict_empty): New functions.
3226         * dictionary.h (mdict_iterator): Define.
3227
3228 2019-01-10  Pedro Alves  <palves@redhat.com>
3229
3230         * breakpoint.c (read_uploaded_action)
3231         (create_tracepoint_from_upload): Adjust to use
3232         gdb::unique_xmalloc_ptr.
3233         * ctf.c (ctf_write_uploaded_tp):
3234         (SET_ARRAY_FIELD): Use emplace_back.
3235         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
3236         * tracefile-tfile.c (tfile_write_uploaded_tp):
3237         * tracepoint.c (parse_tracepoint_definition): Adjust to use
3238         gdb::unique_xmalloc_ptr.
3239         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
3240         at_string, cond_string, cmd_strings>: Replace char pointers
3241         with gdb::unique_xmalloc_ptr.
3242
3243 2019-01-10  Pedro Alves  <palves@redhat.com>
3244
3245         * solib-target.c (library_list_start_library): Don't xstrdup name.
3246
3247 2019-01-10  Pedro Alves  <palves@redhat.com>
3248
3249         * mdebugread.c (parse_partial_symbols): Use
3250         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
3251
3252 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3253
3254         * linux-fork.c (scoped_switch_fork_info)
3255         <~scoped_switch_fork_info>: Fix incorrect variable name.
3256
3257 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3258
3259         * linux-fork.c (scoped_switch_fork_info)
3260         <scoped_switch_fork_info>: Make explicit.
3261         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
3262
3263 2019-01-10  Tom Tromey  <tom@tromey.com>
3264
3265         * objfiles.h (objfile::reset_psymtabs): Update.
3266         * objfiles.c (objfile::objfile): Update.
3267         * psymtab.h (psymtab_storage::obstack): Update.
3268         (psymtab_storage::m_obstack): Use gdb::optional.
3269         (class psymtab_storage): Update comment.  Remove objfile
3270         parameter.
3271         * psymtab.c (psymtab_storage::psymtab_storage): Update.
3272
3273 2019-01-10  Tom Tromey  <tom@tromey.com>
3274
3275         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
3276         <free_psymtabs>: Now private.
3277         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
3278         (allocate_psymtab): Use new method.
3279
3280 2019-01-10  Tom Tromey  <tom@tromey.com>
3281
3282         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
3283         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
3284         * mdebugread.c (parse_partial_symbols): Use
3285         allocate_dependencies.
3286         * dwarf2read.c (dwarf2_create_include_psymtab): Use
3287         allocate_dependencies.
3288         (process_psymtab_comp_unit_reader)
3289         (build_type_psymtab_dependencies): Likewise.
3290         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
3291
3292 2019-01-10  Tom Tromey  <tom@tromey.com>
3293
3294         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
3295         PSYMBOL_SET_LANGUAGE.
3296         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
3297
3298 2019-01-10  Tom Tromey  <tom@tromey.com>
3299
3300         * psymtab.h (psymtab_storage::obstack): New method.
3301         <m_obstack>: Rename from obstack; now private.
3302         * psymtab.c (psymtab_storage): Update.
3303         * dwarf2read.c (create_addrmap_from_index)
3304         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
3305         Update.
3306
3307 2019-01-10  Tom Tromey  <tom@tromey.com>
3308
3309         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
3310         * objfiles.h (objfile::reset_psymtabs): New method.
3311
3312 2019-01-10  Tom Tromey  <tom@tromey.com>
3313
3314         * symmisc.c (print_symbol_bcache_statistics): Update.
3315         (print_objfile_statistics): Update.
3316         * symfile.c (reread_symbols): Update.
3317         * psymtab.h (class psymtab_storage): New.
3318         * psymtab.c (psymtab_storage): New constructor.
3319         (~psymtab_storage): New destructor.
3320         (require_partial_symbols): Update.
3321         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
3322         (find_pc_sect_psymtab, find_pc_sect_psymbol)
3323         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
3324         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
3325         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
3326         (start_psymtab_common, end_psymtab_common)
3327         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
3328         (allocate_psymtab): Update.
3329         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
3330         Update.
3331         (dump_psymtab_addrmap, maintenance_print_psymbols)
3332         (maintenance_check_psymtabs): Update.
3333         (class objfile_psymtabs): Move to objfiles.h.
3334         * psympriv.h (discard_psymtab): Now inline.
3335         (psymtab_discarder::psymtab_discarder): Update.
3336         (psymtab_discarder::~psymtab_discarder): Update.
3337         (ALL_OBJFILE_PSYMTABS): Rewrite.
3338         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
3339         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
3340         Remove fields.
3341         <partial_symtabs>: New field.
3342         (class objfile_psymtabs): Move from psymtab.h.  Update.
3343         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
3344         psymbol_cache.
3345         (objfile::~objfile): Don't destroy psymbol_cache.
3346         * mdebugread.c (parse_partial_symbols): Update.
3347         * dwarf2read.c (create_addrmap_from_index)
3348         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
3349         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
3350         (add_partial_subprogram, dwarf2_ranges_read): Update.
3351         * dwarf-index-write.c (write_address_map)
3352         (write_one_signatured_type, recursively_write_psymbols)
3353         (class debug_names, class debug_names, write_psymtabs_to_index):
3354         Update.
3355
3356 2019-01-10  Tom Tromey  <tom@tromey.com>
3357
3358         * symtab.h (SYMBOL_SET_NAMES): Update.
3359         (symbol_set_names): Update.
3360         (MSYMBOL_SET_NAMES): Update.
3361         * symtab.c (symbol_set_names): Change argument to be an
3362         objfile_per_bfd_storage.
3363         * psymtab.c (add_psymbol_to_bcache): Update.
3364         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
3365
3366 2019-01-10  Tom Tromey  <tom@tromey.com>
3367
3368         * symtab.c (create_demangled_names_hash): Change argument to be an
3369         objfile_per_bfd_storage.
3370         (symbol_set_names): Update.
3371
3372 2019-01-10  Tom Tromey  <tom@tromey.com>
3373
3374         * xcoffread.c (xcoff_initial_scan): Unconditionally call
3375         init_psymbol_list.
3376         * psymtab.c (init_psymbol_list): Do nothing if already called.
3377         * psympriv.h (init_psymbol_list): Add comment.
3378         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
3379         init_psymbol_list.
3380         * dbxread.c (dbx_symfile_read): Unconditionally call
3381         init_psymbol_list.
3382
3383 2019-01-10  Tom Tromey  <tom@tromey.com>
3384
3385         * xcoffread.c (scan_xcoff_symtab): Update.
3386         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
3387         "where".
3388         * mdebugread.c (parse_partial_symbols)
3389         (handle_psymbol_enumerators): Update.
3390         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
3391         * dbxread.c (read_dbx_symtab): Update.
3392         * psympriv.h (psymbol_placement): New enum.
3393         (add_psymbol_to_list): Update.
3394
3395 2019-01-10  Tom Tromey  <tom@tromey.com>
3396
3397         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
3398         static_psymbols parameters.
3399         (scan_xcoff_symtab): Update.
3400         * psymtab.c (start_psymtab_common): Remove global_psymbols and
3401         static_psymbols parameters.
3402         * psympriv.h (start_psymtab_common): Update.
3403         * mdebugread.c (parse_partial_symbols): Update.
3404         * dwarf2read.c (create_partial_symtab): Update.
3405         * dbxread.c (read_dbx_symtab): Update.
3406         (start_psymtab): Remove global_psymbols and static_psymbols
3407         parameters.
3408
3409 2019-01-10  Tom Tromey  <tom@tromey.com>
3410
3411         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
3412         * psymtab.c (allocate_psymtab): Add comment.
3413         * psympriv.h (allocate_psymtab): Add comment.
3414         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
3415         initializations.
3416         * dbxread.c (dbx_end_psymtab): Remove some initializations.
3417
3418 2019-01-10  Tom Tromey  <tom@tromey.com>
3419
3420         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3421         Don't declare.
3422         * mipsread.c: Include mdebugread.h.
3423         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3424         Declare.
3425         * elfread.c: Include mdebugread.h.
3426
3427 2019-01-09  Tom Tromey  <tom@tromey.com>
3428
3429         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
3430         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
3431         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
3432         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
3433         (psym_lookup_symbol, psym_find_last_source_symtab)
3434         (psym_forget_cached_source_info, psym_print_stats)
3435         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
3436         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
3437         (psym_map_matching_symbols, psym_expand_symtabs_matching)
3438         (psym_find_compunit_symtab_by_address)
3439         (maintenance_print_psymbols, maintenance_info_psymtabs)
3440         (maintenance_check_psymtabs): Use ranged for.
3441         * psymtab.h (class objfile_psymtabs): New.
3442         (require_partial_symbols): Return objfile_psymtabs.
3443         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
3444
3445 2019-01-09  Tom Tromey  <tom@tromey.com>
3446
3447         * symfile.c (overlay_invalidate_all, find_pc_overlay)
3448         (find_pc_mapped_section, list_overlays_command)
3449         (map_overlay_command, unmap_overlay_command)
3450         (simple_overlay_update): Use all_objfiles.
3451         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
3452         * printcmd.c (info_symbol_command): Use all_objfiles.
3453         * objfiles.h (ALL_OBJSECTIONS): Remove.
3454         * maint.c (maintenance_translate_address): Use all_objfiles.
3455         * gcore.c (gcore_create_callback): Use all_objfiles.
3456         (objfile_find_memory_regions): Likewise.
3457
3458 2019-01-09  Tom Tromey  <tom@tromey.com>
3459
3460         * symtab.c (find_line_symtab, info_sources_command)
3461         (make_source_files_completion_list): Use objfile_compunits.
3462         * source.c (select_source_symtab): Use objfile_compunits.
3463         * objfiles.h (struct objfile): Update comment.
3464         (ALL_OBJFILES): Remove.
3465         (ALL_FILETABS): Remove.
3466         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
3467         objfile_compunits.
3468
3469 2019-01-09  Tom Tromey  <tom@tromey.com>
3470
3471         * symmisc.c (print_objfile_statistics, dump_objfile)
3472         (maintenance_print_symbols): Use compunit_filetabs.
3473         * source.c (forget_cached_source_info_for_objfile): Use
3474         compunit_filetabs.
3475         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
3476         (ALL_FILETABS): Use compunit_filetabs.
3477         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
3478         * coffread.c (coff_symtab_read): Use compunit_filetabs.
3479
3480 2019-01-09  Tom Tromey  <tom@tromey.com>
3481
3482         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
3483         (compunit_filetabs): New.
3484         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
3485         compunit_filetabs.
3486         (info_sources_command, make_source_files_completion_list): Remove
3487         declaration.
3488         * symmisc.c (print_objfile_statistics, dump_objfile)
3489         (maintenance_print_symbols): Remove declaration.
3490         (maintenance_info_symtabs): Use compunit_filetabs.
3491         (maintenance_info_line_tables): Likewise.
3492         * source.c (select_source_symtab): Change local variable name.
3493         (forget_cached_source_info_for_objfile): Remove declaration.
3494         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
3495         * objfiles.c (objfile_relocate1): Remove declaration.
3496         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3497         declaration.
3498         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
3499         * coffread.c (coff_symtab_read): Remove declaration.
3500         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3501         compunit_filetabs.
3502
3503 2019-01-09  Tom Tromey  <tom@tromey.com>
3504
3505         * symtab.c (lookup_objfile_from_block)
3506         (find_pc_sect_compunit_symtab, search_symbols)
3507         (default_collect_symbol_completion_matches_break_on): Use
3508         objfile_compunits.
3509         * objfiles.h (ALL_COMPUNITS): Remove.
3510         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
3511         * cp-support.c (add_symbol_overload_list_qualified): Use
3512         objfile_compunits.
3513         * ada-lang.c (ada_collect_symbol_completion_matches)
3514         (ada_add_global_exceptions): Use objfile_compunits.
3515
3516 2019-01-09  Tom Tromey  <tom@tromey.com>
3517
3518         * source.c (select_source_symtab)
3519         (forget_cached_source_info_for_objfile): Remove declaration.
3520         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3521         declaration.
3522         * maint.c (count_symtabs_and_blocks): Remove declaration.
3523         * cp-support.c (add_symbol_overload_list_qualified): Remove
3524         declaration.
3525         * coffread.c (coff_symtab_read): Remove declaration.
3526         * symtab.c (lookup_symbol_in_objfile_symtabs)
3527         (basic_lookup_transparent_type_1): Use objfile_compunits.
3528         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
3529         (info_sources_command, search_symbols)
3530         (default_collect_symbol_completion_matches_break_on)
3531         (make_source_files_completion_list): Remove declaration.
3532         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
3533         (ada_collect_symbol_completion_matches)
3534         (ada_add_global_exceptions): Remove declaration.
3535         * linespec.c (iterate_over_all_matching_symtabs): Use
3536         objfile_compunits.
3537         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
3538         (class objfile_compunits): New.
3539         (ALL_COMPUNITS): Use objfile_compunits.
3540         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
3541         (maintenance_check_symtabs, maintenance_info_line_tables): Use
3542         objfile_compunits.
3543         * objfiles.c (objfile_relocate1): Use objfile_compunits.
3544
3545 2019-01-09  Tom Tromey  <tom@tromey.com>
3546
3547         * symtab.c (search_symbols)
3548         (default_collect_symbol_completion_matches_break_on): Use
3549         objfile_msymbols.
3550         * ada-lang.c (ada_lookup_simple_minsym)
3551         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
3552         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
3553         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
3554         objfile_msymbols.
3555         * coffread.c (coff_symfile_read): Use objfile_msymbols.
3556         * symmisc.c (dump_msymbols): Use objfile_msymbols.
3557         * objc-lang.c (find_methods): Use objfile_msymbols.
3558         (info_selectors_command, info_classes_command): Likewise.
3559         * stabsread.c (scan_file_globals): Use objfile_msymbols.
3560         * objfiles.h (class objfile_msymbols): New.
3561         (ALL_OBJFILE_MSYMBOLS): Remove.
3562         (ALL_MSYMBOLS): Remove.
3563
3564 2019-01-09  Tom Tromey  <tom@tromey.com>
3565
3566         * common/next-iterator.h (next_adapter): Add Iterator template
3567         parameter.
3568         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
3569         (class all_objfiles_safe): New.
3570         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
3571         * objfiles.c (put_objfile_before): Update comment.
3572         (add_separate_debug_objfile): Likewise.
3573         (free_all_objfiles): Use all_objfiles_safe.
3574         (objfile_purge_solibs): Likewise.
3575
3576 2019-01-09  Tom Tromey  <tom@tromey.com>
3577
3578         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3579         (expand_symtab_containing_pc, lookup_static_symbol)
3580         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
3581         (find_symbol_at_address, find_line_symtab, find_main_name): Use
3582         all_objfiles.
3583         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
3584         * breakpoint.c (create_overlay_event_breakpoint)
3585         (create_longjmp_master_breakpoint)
3586         (create_std_terminate_master_breakpoint)
3587         (create_exception_master_breakpoint): Use all_objfiles.
3588         * linux-thread-db.c (try_thread_db_load_from_pdir)
3589         (has_libpthread): Use all_objfiles.
3590         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
3591         * linespec.c (iterate_over_all_matching_symtabs)
3592         (search_minsyms_for_name): Use all_objfiles.
3593         * maint.c (maintenance_info_sections): Use all_objfiles.
3594         * main.c (captured_main_1): Use all_objfiles.
3595         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
3596         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
3597         * guile/scm-pretty-print.c
3598         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
3599         * solib-spu.c (append_ocl_sos): Use all_objfiles.
3600         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
3601         (maintenance_print_msymbols): Use all_objfiles.
3602         * source.c (select_source_symtab): Use all_objfiles.
3603         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
3604         * symfile.c (remove_symbol_file_command)
3605         (expand_symtabs_matching, map_symbol_filenames): Use
3606         all_objfiles.
3607         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
3608         all_objfiles.
3609         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
3610         * objc-lang.c (find_methods): Use all_objfiles.
3611         * objfiles.c (have_partial_symbols, have_full_symbols)
3612         (have_minimal_symbols, qsort_cmp)
3613         (default_iterate_over_objfiles_in_search_order): Use
3614         all_objfiles.
3615         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
3616         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
3617         (maintenance_check_psymtabs): Use all_objfiles.
3618         (ALL_PSYMTABS): Remove.
3619         * compile/compile-object-run.c (do_module_cleanup): Use
3620         all_objfiles.
3621         * blockframe.c (find_pc_partial_function): Use all_objfiles.
3622         * cp-support.c (add_symbol_overload_list_qualified): Use
3623         all_objfiles.
3624         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3625         Use all_objfiles.
3626         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
3627         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
3628         all_objfiles.
3629         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3630         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
3631         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3632         Uses all_objfiles.
3633         * solib.c (solib_read_symbols): Use all_objfiles
3634
3635 2019-01-09  Tom Tromey  <tom@tromey.com>
3636
3637         * probe.c (parse_probes_in_pspace): Use all_objfiles.
3638         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
3639         all_objfiles.
3640         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
3641         * symmisc.c (print_symbol_bcache_statistics)
3642         (print_objfile_statistics, maintenance_print_objfiles)
3643         (maintenance_info_symtabs, maintenance_check_symtabs)
3644         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
3645         all_objfiles.
3646         * source.c (forget_cached_source_info): Use all_objfiles.
3647         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
3648         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3649         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
3650         * objfiles.c (update_section_map): Use all_objfiles.
3651         (shared_objfile_contains_address_p): Likewise.
3652         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
3653         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
3654
3655 2019-01-09  Tom Tromey  <tom@tromey.com>
3656
3657         * common/next-iterator.h: New file.
3658         * objfiles.h (class all_objfiles): New.
3659         (struct objfile_iterator): New.
3660
3661 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3662
3663         * NEWS: Move the description of the changed "frame", "select-frame",
3664          and "info frame" commands to the Changed commands section.
3665
3666 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
3667
3668         * gdbtypes.c (check_stub_method_group): Remove handling of old
3669         mangling schemes.
3670         * linespec.c (find_methods): Likewise.
3671         * stabsread.c (read_member_functions): Likewise.
3672         * valops.c (search_struct_method): Likewise.
3673         (value_struct_elt_for_reference): Likewise.
3674         * NEWS: Mention this change.
3675
3676 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3677
3678         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
3679         print_source_lines.
3680         * source.c (print_source_lines_base): Update line number check.
3681         (print_source_lines): New function.
3682         (source_lines_range::source_lines_range): New function.
3683         * source.h (class source_lines_range): New class.
3684         (print_source_lines): New declaration.
3685
3686 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3687
3688         * linespec.c (linespec_state_destructor): Free self->canonical_names.
3689
3690 2019-01-08  Tom Tromey  <tom@tromey.com>
3691             Simon Marchi  <simon.marchi@ericsson.com>
3692
3693         PR gdb/24060
3694         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
3695         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
3696         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3697         * f-exp.y (DOLLAR_VARIABLE): Likewise.
3698         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
3699         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3700
3701 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3702
3703         * source.c (select_source_symtab): Move header comment to
3704         declaration in source.h.
3705         (forget_cached_source_info_for_objfile): Likewise.
3706         (forget_cached_source_info): Likewise.
3707         (identify_source_line): Likewise.
3708         * source.h (identify_source_line): Move declaration from symtab.h
3709         and add comment from source.c
3710         (print_source_lines): Likewise.
3711         (forget_cached_source_info_for_objfile): Likewise.
3712         (forget_cached_source_info): Likewise.
3713         (select_source_symtab): Likewise.
3714         (enum print_source_lines_flag): Move definition from symtab.h.
3715         * symtab.h (identify_source_line): Move declaration to source.h.
3716         (print_source_lines): Likewise.
3717         (forget_cached_source_info_for_objfile): Likewise.
3718         (forget_cached_source_info): Likewise.
3719         (select_source_symtab): Likewise.
3720         (enum print_source_lines_flag): Move definition to source.h.
3721         * tui/tui-hooks.c: Add 'source.h' include.
3722
3723 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3724
3725         * source.c (print_source_lines_base): Handle requests to print
3726         reverse line number sequences, and guard against empty lines
3727         string.
3728
3729 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3730
3731         * source.c (print_source_lines_base): Fix skip of '\r' if next
3732         character is '\n'.
3733
3734 2019-01-06  Tom Tromey  <tom@tromey.com>
3735
3736         * c-exp.y (struct c_parse_state) <macro_original_text,
3737         expansion_obstack>: New member.
3738         (macro_original_text, expansion_obstack): Remove globals.
3739         (scan_macro_expansion, scanning_macro_expansion)
3740         (finished_macro_expansion): Update.
3741         (scan_macro_cleanup): Remove.
3742         (yylex, c_parse): Update.
3743
3744 2019-01-06  Tom Tromey  <tom@tromey.com>
3745
3746         * c-exp.y (struct c_parse_state) <strings>: New member.
3747         (operator_stoken): Update.
3748
3749 2019-01-06  Tom Tromey  <tom@tromey.com>
3750
3751         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
3752         (union type_stack_elt) <typelist_val>: Now a pointer to
3753         std::vector.
3754         (type_stack_cleanup): Don't declare.
3755         (push_typelist): Update.
3756         * parse.c (pop_typelist): Return a std::vector.
3757         (push_typelist): Take a std::vector.
3758         (follow_types): Update.  Do not free args.
3759         (type_stack_cleanup): Remove.
3760         * c-exp.y (struct c_parse_state): New.
3761         (cpstate): New global.
3762         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
3763         (nonempty_typelist): Update.
3764         (func_mod): Create a new vector.
3765         (c_parse): Create a c_parse_state.
3766         (check_parameter_typelist): Do not delete params.
3767         (function_method): Update.  Do not delete type_list.
3768
3769 2019-01-06  Tom Tromey  <tom@tromey.com>
3770
3771         PR gdb/28155:
3772         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
3773         check_typedef.
3774         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
3775         (print_return_value): Likewise.
3776
3777 2019-01-05  Tom Tromey  <tom@tromey.com>
3778
3779         * contrib/cleanup_check.py: Remove.
3780         * contrib/gcc-with-excheck: Remove.
3781         * contrib/exsummary.py: Remove.
3782         * contrib/excheck.py: Remove.
3783
3784 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
3785
3786         * thread.c (delete_thread_1): Add gdb_assert that THR is not
3787         NULL. Initialize tpprev to NULL instead of assigning it
3788         to NULL on the next statement.
3789         * windows-nat.c (windows_delete_thread): Remove check for
3790         main_thread_id before printing thread exit notifications.
3791         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
3792         Remove thread ID check against main_thread_id.
3793         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
3794         windows_delete_thread.
3795         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
3796
3797 2019-01-04  Tom Tromey  <tom@tromey.com>
3798
3799         * compile/compile.c (_initialize_compile): Use upper case for
3800         metasyntactic variables.
3801         * symmisc.c (_initialize_symmisc): Use upper case for
3802         metasyntactic variables.
3803         * psymtab.c (_initialize_psymtab): Use upper case for
3804         metasyntactic variables.
3805         * demangle.c (demangle_command): Use upper case for metasyntactic
3806         variables.
3807         (_initialize_demangler): Likewise.
3808         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
3809         variables.
3810
3811 2019-01-03  Tom Tromey  <tom@tromey.com>
3812
3813         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
3814
3815 2019-01-03  Tom Tromey  <tom@tromey.com>
3816
3817         * python/py-symtab.c (salpy_str): Update.
3818         (struct salpy_sal_object) <symtab>: Now a PyObject.
3819         (salpy_dealloc): Update.
3820         (del_objfile_sal): Use gdbpy_ref.
3821
3822 2019-01-03  Tom Tromey  <tom@tromey.com>
3823
3824         * python/py-type.c (convert_field): Use new_reference.  Return
3825         gdbpy_ref.
3826         (make_fielditem): Return gdbpy_ref.
3827         (typy_fields): Update.
3828         (typy_getitem): Update.
3829         (field_name): Return gdbpy_ref.  Use new_reference.
3830         (typy_iterator_iternext): Update.
3831
3832 2019-01-03  Tom Tromey  <tom@tromey.com>
3833
3834         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
3835
3836 2019-01-03  Tom Tromey  <tom@tromey.com>
3837
3838         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
3839         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
3840         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
3841         (pspy_set_frame_filters, pspy_set_frame_unwinders)
3842         (pspy_set_type_printers): Likewise.
3843         * python/py-function.c (fnpy_init): Use gdbpy_ref.
3844         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
3845         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
3846         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
3847         (objfpy_set_type_printers): Likewise.
3848
3849 2019-01-03  Tom Tromey  <tom@tromey.com>
3850
3851         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
3852         (gdbpy_print_stack): Use gdbpy_err_fetch.
3853         * python/python-internal.h (class gdbpy_err_fetch): New class.
3854         (class gdbpy_enter) <m_error_type, m_error_value,
3855         m_error_traceback>: Remove.
3856         <m_error>: New member.
3857         (gdbpy_exception_to_string): Don't declare.
3858         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
3859         * python/py-value.c (convert_value_from_python): Use
3860         gdbpy_err_fetch.
3861         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
3862         gdbpy_exception_to_string.
3863         (gdbpy_handle_exception): Use gdbpy_err_fetch.
3864         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3865         gdbpy_err_fetch.
3866
3867 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3868
3869         * linux-nat.c (delete_lwp_cleanup): Delete.
3870         (struct lwp_deleter): New struct.
3871         (lwp_info_up): New typedef.
3872         (linux_nat_target::follow_fork): Delete cleanup, and make use of
3873         lwp_info_up.
3874
3875 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3876
3877         * linux-fork.c (class scoped_switch_fork_info): New class.
3878         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
3879
3880 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3881
3882         * valops.c (find_overload_match): Remove use of null_cleanup, and
3883         calls to do_cleanups.
3884
3885 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3886
3887         * compile/compile-cplus-types.c
3888         (compile_cplus_instance::decl_name): Handle changes to
3889         cp_func_name.
3890         * cp-support.c (cp_func_name): Update header comment, update
3891         return type.
3892         * cp-support.h (cp_func_name): Update return type in declaration.
3893         * valops.c (find_overload_match): Move temp_func local to top
3894         level of function and change its type.  Use temp_func to hold and
3895         delete temporary string obtained from cp_func_name.
3896
3897 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3898
3899         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
3900         gdb::char_vector, remove cleanup, and update uses of `msg`.
3901
3902 2019-01-03  Jim Wilson  <jimw@sifive.com>
3903
3904         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
3905
3906 2019-01-02  Tom Tromey  <tom@tromey.com>
3907
3908         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
3909         (tdesc_parse_xml): Remove cleanups.
3910         * target-descriptions.h (make_cleanup_free_target_description):
3911         Don't declare.
3912         (target_desc_deleter): New struct.
3913         (target_desc_up): New typedef.
3914         * target-descriptions.c (target_desc_deleter::operator()): Rename
3915         from free_target_description.
3916         (make_cleanup_free_target_description): Remove.
3917
3918 2019-01-02  Tom Tromey  <tom@tromey.com>
3919
3920         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
3921         constructor, destructor.
3922         (linespec_parser): Remove typedef.
3923         (~linespec_parser): Rename from linespec_parser_delete.
3924         (linespec_lex_to_end, linespec_complete_label)
3925         (linespec_complete): Update.
3926         (decode_line_full): Remove cleanups.
3927         (decode_line_1): Update.
3928
3929 2019-01-02  Tom Tromey  <tom@tromey.com>
3930
3931         * python/python-internal.h (inferior_to_inferior_object): Change
3932         return type.
3933         * python/py-exitedevent.c (create_exited_event_object): Update.
3934         * python/py-inferior.c (inferior_to_inferior_object): Return
3935         gdbpy_ref.
3936         (python_new_inferior, python_inferior_deleted)
3937         (thread_to_thread_object, delete_thread_object)
3938         (build_inferior_list, gdbpy_selected_inferior): Update.
3939         * python/py-infthread.c (create_thread_object): Update.  Also fail
3940         if inferior_to_inferior_object fails.
3941
3942 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
3943
3944         * inferior.h (class inferior) <displaced_step_state>: New field.
3945         * infrun.h (struct displaced_step_state): Move here from
3946         infrun.c.  Initialize fields, add constructor.
3947         <inf>: Remove field.
3948         <reset>: New method.
3949         * infrun.c (struct displaced_step_inferior_state): Move to
3950         infrun.h.
3951         (displaced_step_inferior_states): Remove.
3952         (get_displaced_stepping_state): Adust.
3953         (displaced_step_in_progress_any_inferior): Adjust.
3954         (displaced_step_in_progress_thread): Adjust.
3955         (displaced_step_in_progress): Adjust.
3956         (add_displaced_stepping_state): Remove.
3957         (get_displaced_step_closure_by_addr): Adjust.
3958         (remove_displaced_stepping_state): Remove.
3959         (infrun_inferior_exit): Call displaced_step_state.reset.
3960         (use_displaced_stepping): Don't check for NULL.
3961         (displaced_step_prepare_throw): Call
3962         get_displaced_stepping_state.
3963         (displaced_step_fixup): Don't check for NULL.
3964         (prepare_for_detach): Don't check for NULL.
3965
3966 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3967
3968         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
3969          in case of call that did not complete.
3970
3971 2019-01-02  Andrey Utkin  <autkin@undo.io>
3972
3973         * symfile.c (find_separate_debug_file): Fix search of debug files for
3974         remote debuggee.
3975
3976 2019-01-02  Tom Tromey  <tom@tromey.com>
3977
3978         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
3979         indentation.
3980         * python/py-frame.c (frapy_older): Remove cast.
3981         (frapy_newer): Likewise.
3982         * python/py-breakpoint.c (local_setattro): Remove cast.
3983         * python/py-arch.c (archpy_name): Remove local variable.
3984         * python/py-type.c (gdbpy_lookup_type): Remove cast.
3985
3986 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
3987
3988         * unittests/basic_string_view/element_access/char/empty.cc:
3989         Fix year range in copyright header.
3990
3991 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3992
3993         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
3994         Delete.
3995         <operator==>: Update with for removed field.
3996         <hash>: Likewise.
3997         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
3998         <isa_features>: ...this.
3999         <abi_features>: New field.
4000         (riscv_isa_flen): Update comment.
4001         (riscv_abi_xlen): New declaration.
4002         (riscv_abi_flen): New declaration.
4003         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
4004         isa_features.
4005         (riscv_abi_xlen): New function.
4006         (riscv_isa_flen): Update to get answer from isa_features.
4007         (riscv_abi_flen): New function.
4008         (riscv_has_fp_abi): Update to get answer from abi_features.
4009         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
4010         xlen and flen.
4011         (riscv_call_info) <xlen, flen>: Update comment.
4012         (riscv_call_arg_struct): Remove invalid assertions
4013         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
4014         is removed.
4015         (riscv_gdbarch_init): Gather isa features and abi features
4016         separately, ensure both match on the gdbarch when reusing an old
4017         gdbarch.  Relax an error check to allow 32-bit abi float to run on
4018         a target with 64-bit float hardware.
4019
4020 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4021
4022         * source.c (search_command_helper): Stop reverse search
4023         when line 1 has been searched.
4024
4025 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4026
4027         * record-full.c (record_full_base_target::close): Rewrite
4028         record_full_core_buf_list free logic.
4029
4030 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4031
4032         * break-catch-syscall.c (print_one_catch_syscall): xfree
4033         the last text.
4034
4035 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
4036
4037         * top.c (print_gdb_version): Update Copyright year in version
4038         message.
4039
4040 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
4041
4042         Update copyright year range in all GDB files.
4043
4044 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
4045
4046         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
4047
4048 For older changes see ChangeLog-2018.
4049 \f
4050 Local Variables:
4051 mode: change-log
4052 left-margin: 8
4053 fill-column: 74
4054 version-control: never
4055 coding: utf-8
4056 End:
4057