gdb/ChangeLog

   1 2019-06-25  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
   4         Update.
   5         * tui/tui-layout.c (make_command_window)
   6         (show_source_disasm_command, show_data, init_and_make_win)
   7         (show_source_or_disasm_and_command): Update.
   8         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
   9         method.
  10         <can_highight, is_highlighted>: Now bool.
  11         (tui_set_win_highlight): Don't declare.
  12         * tui/tui-data.c (tui_set_win_highlight): Remove.
  13
  14 2019-06-25  Tom Tromey  <tom@tromey.com>
  15
  16         * tui/tui-wingeneral.c (make_visible): Remove check of window
  17         type.
  18
  19 2019-06-25  Tom Tromey  <tom@tromey.com>
  20
  21         * tui/tui-win.c (tui_win_info::max_height)
  22         (tui_cmd_window::max_height): New methods.
  23         (new_height_ok): Call max_height.
  24         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
  25         <max_height>: New method.
  26
  27 2019-06-25  Tom Tromey  <tom@tromey.com>
  28
  29         * tui/tui-win.c (tui_source_window_base::set_new_height)
  30         (tui_data_window::set_new_height): New methods.
  31         (make_invisible_and_set_new_height): Call set_new_height method.
  32         * tui/tui-data.h (struct tui_win_info)
  33         (struct tui_source_window_base, struct tui_data_window)
  34         <set_new_height>: New method.
  35
  36 2019-06-25  Tom Tromey  <tom@tromey.com>
  37
  38         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
  39         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
  40         tui_refresh_data_win.
  41         * tui/tui-win.c (tui_source_window_base::refresh_all): New
  42         method.
  43         (tui_refresh_all_win): Call the refresh_all method.
  44         (tui_set_focus): Likewise.
  45         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
  46         (struct tui_source_window_base, struct tui_data_window) <refresh>:
  47         Likewise.
  48
  49 2019-06-25  Tom Tromey  <tom@tromey.com>
  50
  51         * tui/tui-winsource.h (tui_refill_source_window)
  52         (tui_set_is_exec_point_at): Don't declare.
  53         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
  54         (tui_source_window_base::refill): Rename from
  55         tui_refill_source_window.
  56         (tui_source_window_base::do_scroll_horizontal): Update.
  57         (tui_source_window_base::set_is_exec_point_at): Rename from
  58         tui_set_is_exec_point_at.
  59         (tui_update_all_breakpoint_info): Update.
  60         * tui/tui-stack.c (tui_show_frame_info): Update.
  61         * tui/tui-layout.c (show_data): Add cast.
  62         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
  63         * tui/tui-data.h (struct tui_source_window_base) <refill,
  64         set_is_exec_point_at>: New methods.
  65         (tui_source_windows, tui_add_to_source_windows): Update types.
  66         (tui_add_to_source_windows): Remove redundant declaration.
  67         * tui/tui-data.c (source_windows): Store tui_source_window_base.
  68         (tui_source_windows): Change return type.
  69         (tui_clear_source_windows_detail): Update.
  70         (tui_add_to_source_windows): Change type of parameter.
  71         (tui_free_all_source_wins_content): Update.
  72
  73 2019-06-25  Tom Tromey  <tom@tromey.com>
  74
  75         * tui/tui-wingeneral.c (tui_win_info::refresh)
  76         (tui_source_window_base::refresh): New methods.
  77         (tui_refresh_all): Call the refresh method.
  78         * tui/tui-data.h (struct tui_win_info)
  79         (struct tui_source_window_base) <refresh>: New method.
  80
  81 2019-06-25  Tom Tromey  <tom@tromey.com>
  82
  83         * tui/tui.h (tui_is_window_visible): Return bool.
  84         * tui/tui.c (tui_is_window_visible): Return bool.
  85         * tui/tui-wingeneral.c (tui_make_window, make_visible)
  86         (tui_make_visible, tui_make_invisible)
  87         (tui_win_info::make_visible)
  88         (tui_source_window_base::make_visible, make_all_visible)
  89         (tui_make_all_visible, tui_make_all_invisible): Update.
  90         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
  91         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
  92         bool.
  93         (struct tui_win_info, struct tui_source_window_base)
  94         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
  95         * tui/tui-data.c (tui_init_generic_part): Update.
  96
  97 2019-06-25  Tom Tromey  <tom@tromey.com>
  98
  99         * tui/tui-wingeneral.c (tui_win_info::make_visible)
 100         (tui_source_window_base::make_visible): New methods.
 101         (make_all_visible): Make method call.
 102         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
 103         (struct tui_source_window_base, struct tui_cmd_window): Override
 104         make_visible.
 105         (tui_win_is_source_type): Don't declare.
 106         * tui/tui-data.c (tui_win_is_source_type): Remove.
 107
 108 2019-06-25  Tom Tromey  <tom@tromey.com>
 109
 110         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
 111         NULL check.
 112
 113 2019-06-25  Tom Tromey  <tom@tromey.com>
 114
 115         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
 116         Inline constructor.  Add initializers for members.
 117         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
 118         constructors; now inline in class.
 119
 120 2019-06-25  Tom Tromey  <tom@tromey.com>
 121
 122         * tui/tui-regs.c (tui_show_registers): Update.
 123         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
 124         bool.
 125         * tui/tui-data.c (tui_data_window::clear_detail)
 126         (tui_data_window): Update.
 127
 128 2019-06-25  Tom Tromey  <tom@tromey.com>
 129
 130         * tui/tui-windata.c (tui_display_all_data)
 131         (tui_display_data_from_line, tui_display_data_from)
 132         (tui_check_data_values, tui_data_window::do_scroll_vertical):
 133         Update.
 134         * tui/tui-regs.c (tui_last_regs_line_no)
 135         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 136         (tui_show_registers, tui_show_register_group)
 137         (tui_display_registers_from, tui_display_reg_element_at_line)
 138         (tui_display_registers_from_line, tui_check_register_values)
 139         (tui_reg_next, tui_reg_prev): Update.
 140         * tui/tui-layout.c (tui_set_layout, show_data): Update.
 141         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
 142         tui_data_window.
 143         (struct tui_win_info) <detail>: Remove.  Add new fields from
 144         tui_data_info.
 145         (TUI_DATA_WIN): Add cast.
 146         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
 147         (~tui_data_window): Simplify.
 148
 149 2019-06-25  Tom Tromey  <tom@tromey.com>
 150
 151         * tui/tui-layout.c (show_source_disasm_command)
 152         (show_source_or_disasm_and_command): Update.
 153         * tui/tui-io.c (update_cmdwin_start_line)
 154         (tui_redisplay_readline): Update.
 155         * tui/tui-data.h (struct tui_command_info): Remove.
 156         (struct tui_win_info) <detail>: Remove command_info member.
 157         (struct tui_data_window) <start_line>: New member, from
 158         tui_command_info.
 159         (TUI_CMD_WIN): Add casts.
 160
 161 2019-06-25  Tom Tromey  <tom@tromey.com>
 162
 163         * tui/tui-winsource.c (tui_update_source_window)
 164         (tui_refill_source_window)
 165         (tui_source_window_base::do_scroll_horizontal)
 166         (tui_update_breakpoint_info, tui_set_exec_info_content)
 167         (tui_show_exec_info_content, tui_erase_exec_info_content)
 168         (tui_clear_exec_info_content): Update.
 169         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
 170         Update.
 171         * tui/tui-win.c (make_invisible_and_set_new_height)
 172         (make_visible_with_new_height): Update.
 173         * tui/tui-source.c (tui_set_source_content)
 174         (tui_show_symtab_source): Update.
 175         * tui/tui-layout.c (extract_display_start_addr)
 176         (show_source_disasm_command, show_data)
 177         (make_source_or_disasm_window)
 178         (show_source_or_disasm_and_command): Update.
 179         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
 180         (tui_disasm_window::do_scroll_vertical): Remove shadowing
 181         "gdbarch".
 182         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
 183         to tui_source_window_base.
 184         (struct tui_win_info) <detail>: Remove source_info member.
 185         (struct tui_source_window_base) <has_locator>: Inline.
 186         Move contents from tui_source_info; rename has_locator member to
 187         m_has_locator.
 188         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
 189         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
 190         header file.
 191         (tui_source_window_base::clear_detail, ~tui_source_window_base):
 192         Simplify.
 193         (tui_free_all_source_wins_content): Cast to
 194         tui_source_window_base.
 195
 196 2019-06-25  Tom Tromey  <tom@tromey.com>
 197
 198         * tui/tui-win.c (make_invisible_and_set_new_height)
 199         (make_visible_with_new_height): Call has_locator method.
 200         * tui/tui-layout.c (show_source_disasm_command, show_data)
 201         (show_source_or_disasm_and_command): Update for bool change.
 202         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
 203         (tui_win_info) <has_locator>: New method.
 204         (struct tui_source_window_base) <has_locator>: New method.
 205         (tui_win_has_locator): Don't declare.
 206         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
 207         from tui_win_has_locator.
 208         (tui_source_window_base): Use false, not FALSE.
 209
 210 2019-06-25  Tom Tromey  <tom@tromey.com>
 211
 212         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
 213         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
 214         clear_detail method directly.
 215         (tui_clear_win_detail): Remove.
 216
 217 2019-06-25  Tom Tromey  <tom@tromey.com>
 218
 219         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
 220         "this", not TUI_DISASM_WIN.
 221
 222 2019-06-25  Tom Tromey  <tom@tromey.com>
 223
 224         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
 225         declare.
 226         * tui/tui-winsource.c
 227         (tui_source_window_base::do_scroll_horizontal): Rename from
 228         tui_horizontal_source_scroll.
 229         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
 230         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
 231         from tui_vertical_data_scroll.
 232         * tui/tui-win.h (tui_scroll): Don't declare.
 233         * tui/tui-win.c (tui_win_info::forward_scroll)
 234         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 235         (tui_win_info::right_scroll): Rename and update.
 236         (tui_scroll_forward_command, tui_scroll_backward_command)
 237         (tui_scroll_left_command, tui_scroll_right_command): Update.
 238         (tui_scroll): Remove.
 239         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
 240         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
 241         from tui_vertical_source_scroll.
 242         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
 243         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
 244         from tui_vertical_disassem_scroll.
 245         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
 246         do_scroll_horizontal>: New methods.
 247         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
 248         Likewise.
 249         (struct tui_source_window_base): Add do_scroll_horizontal.
 250         (struct tui_source_window, struct tui_disasm_window): Add
 251         do_scroll_vertical.
 252         (struct tui_data_window, struct tui_cmd_window): Add
 253         do_scroll_horizontal and do_scroll_vertical.
 254         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
 255
 256 2019-06-25  Tom Tromey  <tom@tromey.com>
 257
 258         * tui/tui-data.h (struct tui_source_window_base): New struct.
 259         (struct tui_source_window): Derive from tui_source_window_base.
 260         (struct tui_disasm_window): New struct.
 261         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
 262         from tui_source_window::clear_detail.
 263         (tui_source_window_base): Rename from tui_source_window.
 264         (~tui_source_window_base): Rename from ~tui_source_window.
 265         (tui_alloc_win_info): Create a tui_disasm_window.
 266
 267 2019-06-25  Tom Tromey  <tom@tromey.com>
 268
 269         * tui/tui-data.h (struct tui_source_window)
 270         (struct tui_data_window): Declare destructors.
 271         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
 272         destructors.
 273         (tui_win_info): Simplify.
 274
 275 2019-06-25  Tom Tromey  <tom@tromey.com>
 276
 277         * tui/tui-winsource.c (tui_display_main)
 278         (tui_update_source_windows_with_addr)
 279         (tui_update_all_breakpoint_info): Update.
 280         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 281         (new_height_ok, parse_scrolling_args): Update.
 282         * tui/tui-stack.c (tui_show_frame_info): Update.
 283         * tui/tui-data.h (struct tui_list): Remove.
 284         (tui_source_windows): Return a reference to a std::vector.
 285         * tui/tui-data.c (source_windows): Now a std::vector.
 286         (tui_source_windows): Change return type.
 287         (tui_clear_source_windows): Rewrite.
 288         (tui_clear_source_windows_detail, tui_add_to_source_windows)
 289         (tui_free_all_source_wins_content): Rewrite.
 290
 291 2019-06-25  Tom Tromey  <tom@tromey.com>
 292
 293         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
 294         (struct tui_data_window, struct tui_cmd_window): Declare
 295         clear_detail method.
 296         * tui/tui-data.c (tui_source_window::clear_detail)
 297         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
 298         methods.
 299         (tui_clear_win_detail): Simplify.
 300
 301 2019-06-25  Tom Tromey  <tom@tromey.com>
 302
 303         * tui/tui-layout.c (make_source_window, make_disasm_window)
 304         (make_source_or_disasm_window): Remove win_info_ptr parameter.
 305         Return the new window.
 306         (show_source_disasm_command, show_data)
 307         (show_source_or_disasm_and_command): Update.
 308
 309 2019-06-25  Tom Tromey  <tom@tromey.com>
 310
 311         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
 312         parameter.  Return the new window.
 313         (show_source_disasm_command): Update and remove NULL check.
 314         (show_source_or_disasm_and_command): Update.
 315
 316 2019-06-25  Tom Tromey  <tom@tromey.com>
 317
 318         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
 319
 320 2019-06-25  Tom Tromey  <tom@tromey.com>
 321
 322         * tui/tui-data.h (struct tui_win_info): Make constructor
 323         protected.  Make destructor virtual.  Add initializers.
 324         (tui_source_window, tui_data_window, tui_cmd_window): New
 325         classes.
 326         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
 327         constructor.  Add "type" parameter.
 328         (tui_source_window, tui_data_window, tui_cmd_window): New
 329         constructors.
 330         (tui_alloc_win_info): Instantiate the appropriate subclass.
 331
 332 2019-06-25  Tom Tromey  <tom@tromey.com>
 333
 334         * tui/tui-win.c (tui_resize_all): Use delete.
 335         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
 336         destructor.
 337         (tui_free_window): Don't declare.
 338         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
 339         Update.
 340
 341 2019-06-25  Tom Tromey  <tom@tromey.com>
 342
 343         * tui/tui-data.h (struct tui_win_info): Add constructor.
 344         * tui/tui-data.c (tui_alloc_win_info): Use new.
 345         (tui_free_window): Use delete.
 346
 347 2019-06-22  Tom Tromey  <tom@tromey.com>
 348
 349         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
 350         declare.
 351         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
 352
 353 2019-06-22  Tom Tromey  <tom@tromey.com>
 354
 355         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
 356         declare.
 357         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
 358
 359 2019-06-22  Tom de Vries  <tdevries@suse.de>
 360
 361         * dwarf2read.c (create_addrmap_from_aranges)
 362         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
 363         instead of '%zu'.
 364
 365 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
 366
 367         * dwarf2read.h (dwarf2_section_info_def): Remove.
 368         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
 369         * dwarf2read.c (struct dwo_sections) <types>: Change type to
 370         std::vector<dwarf2_section_info>.
 371         (struct dwo_file) <~dwo_file>: Remove.
 372         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
 373         types field.
 374         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
 375         (dwarf2_read_debug_names): Likewise.
 376         (create_debug_types_hash_table): Change parameter type to
 377         array_view, adjust code accordingly.
 378         (dwarf2_locate_dwo_sections): Adjust to std::vector.
 379         (partial_die_info::fixup): Likewise.
 380         (determine_prefix): Likewise.
 381         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
 382
 383 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 384
 385         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
 386         gdb_bfd_ref_ptr.
 387         <~dwo_file>: Remove call to gdb_bfd_unref.
 388         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
 389         gdb_bfd_ref_ptr::get.
 390
 391 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 392
 393         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
 394         type to htab_up.
 395         * dwarf2read.c (struct dwo_file): Initialize fields.
 396         <~dwo_file>: New.
 397         (free_dwo_file): Remove, move content to ~dwo_file.
 398         (struct dwo_file_deleter): Remove.
 399         (dwo_file_up>: Remove custom deleter.
 400         (free_dwo_files): Remove.
 401         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
 402         dwo_files.
 403         (process_skeletonless_type_units): Call unique_ptr::get.
 404         (allocate_dwo_file_hash_table): Add deleter to created hash
 405         table.  Change return type to htab_up.
 406         (lookup_dwo_file_slot): Don't memset dwo_file, call
 407         unique_ptr::get.
 408         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
 409         (create_dwo_unit_in_dwp_v2): Likewise.
 410         (open_and_init_dwo_file): Likewise.
 411         (free_dwo_file_from_slot): Remove.
 412
 413 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 414
 415         * dwarf2read.h (struct dwarf2_section_info) <readin,
 416         is_virtual>: Change type to bool.
 417         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
 418         true instead of 1.
 419
 420 2019-06-19  Tom Tromey  <tom@tromey.com>
 421
 422         * tui/tui-data.h (tui_init_content_element): Don't declare.
 423
 424 2019-06-19  Tom Tromey  <tom@tromey.com>
 425
 426         * tui/tui-data.h (tui_init_win_info): Don't declare.
 427
 428 2019-06-19  Tom de Vries  <tdevries@suse.de>
 429
 430         * dwarf2read.h (abstract_to_concrete): Change type to
 431         std::unordered_map<sect_offset, std::vector<sect_offset>,
 432         gdb::hash_enum<sect_offset>>.
 433
 434 2019-06-19  Tom Tromey  <tromey@adacore.com>
 435
 436         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
 437         EVAL_AVOID_SIDE_EFFECTS specially.
 438
 439 2019-06-19  Tom Tromey  <tromey@adacore.com>
 440
 441         * source-cache.c (highlighter): New global.
 442         (source_cache::get_source_lines): Create a highlighter on demand.
 443
 444 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 445
 446         * defs.h (deprecated_interactive_hook): Delete declaration.
 447         * interps.c (clear_interpreter_hooks): Remove use of
 448         deprecated_interactive_hook.
 449         * top.c (deprecated_interactive_hook): Delete definition.
 450         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
 451
 452 2019-06-18  Tom de Vries  <tdevries@suse.de>
 453
 454         PR gdb/24515
 455         * dwarf2read.h (abstract_to_concrete): Change type from
 456         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
 457         std::unordered_map<sect_offset, std::vector<sect_offset>>.
 458         * dwarf2read.c (read_variable): Update.
 459         (dwarf2_fetch_die_loc_sect_off): Update.
 460
 461 2019-06-17  Tom de Vries  <tdevries@suse.de>
 462
 463         PR gdb/24617
 464         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
 465         accessing parent[parent_len - 1].
 466
 467 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
 468
 469         PR gdb/24364
 470         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
 471         call dtrace_process_dof with NULL dof.
 472
 473 2019-06-16  Tom de Vries  <tdevries@suse.de>
 474
 475         PR gdb/24445
 476         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
 477
 478 2019-06-16  Tom Tromey  <tom@tromey.com>
 479
 480         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 481         (make_all_visible): Use address of member.
 482
 483 2019-06-16  Tom Tromey  <tom@tromey.com>
 484
 485         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
 486         (tui_free_window, free_content, free_content_elements): Remove
 487         unnecessary cast.
 488         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
 489         cast.
 490         * tui/tui-regs.c (tui_show_register_group)
 491         (tui_display_registers_from, tui_display_reg_element_at_line):
 492         Remove unnecessary cast.
 493
 494 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
 495
 496         * linux-nat.c (normal_mask): Delete.
 497         (_initialize_linux_nat): Don't initialise normal_mask.
 498
 499 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
 500
 501         PR gdb/24445
 502         * dwarf-index-write.h (write_psymtabs_to_index): Add
 503         dwz_basename parameter.
 504         * dwarf-index-write.c (write_gdbindex): Move file writing to
 505         write_gdbindex_1.  Change return type void.
 506         (assert_file_size): Move up, remove filename parameter.
 507         (write_gdbindex_1): New function.
 508         (write_debug_names): Change return type to void, call
 509         assert_file_size.
 510         (struct index_wip_file): New struct.
 511         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
 512         file logic to index_wip_file.  Write index for dwz file if
 513         needed.
 514         (save_gdb_index_command): Pass basename of dwz file, if present.
 515         * dwarf-index-cache.c (index_cache::store): Obtain and pass
 516         build-id of dwz file, if present.
 517         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
 518         (dwarf2_get_dwz_file): Likewise.
 519         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
 520         (dwarf2_get_dwz_file): Likewise.
 521
 522 2019-06-16  Tom Tromey  <tom@tromey.com>
 523
 524         * coffread.c (process_coff_symbol): Use xstrdup.
 525         * value.c (create_internalvar): Use xstrdup.
 526
 527 2019-06-16  Tom Tromey  <tom@tromey.com>
 528
 529         * valops.c (value_cast, value_slice): Remove unnecessary cast.
 530         * breakpoint.c (stopin_command, stopat_command)
 531         (until_break_command, decode_location_default): Remove unnecessary
 532         cast.
 533         * utils.c (subset_compare): Remove unnecessary cast.
 534         * ada-lang.c (ada_update_initial_language): Remove unnecessary
 535         cast.
 536         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
 537         cast.
 538         * infcmd.c (path_command): Remove unnecessary cast.
 539         * coffread.c (decode_type): Remove unnecessary cast.
 540         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
 541         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
 542         * tui/tui-stack.c (tui_show_locator_content)
 543         (tui_show_frame_info): Remove unnecessary cast.
 544         * tui/tui-win.c (tui_scroll_forward_command)
 545         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
 546         (parse_scrolling_args): Remove unnecessary cast.
 547         * tui/tui-data.c (init_win_info, tui_del_window)
 548         (tui_free_window, tui_del_data_windows, tui_free_data_content)
 549         (free_content_elements): Remove unnecessary cast.
 550         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
 551         unnecessary cast.
 552         * tui/tui-source.c (tui_set_source_content)
 553         (tui_vertical_source_scroll): Remove unnecessary cast.
 554         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
 555         cast.
 556         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
 557         * tui/tui-regs.c (tui_display_registers_from)
 558         (tui_display_register): Remove unnecessary cast.
 559         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
 560         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
 561         (make_visible): Remove unnecessary cast.
 562         * tui/tui-winsource.c (tui_erase_source_content)
 563         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
 564         unnecessary cast.
 565         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
 566         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
 567         * stabsread.c (read_type, read_array_type, read_range_type):
 568         Remove unnecessary cast.
 569         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
 570         (parse_symbol, parse_type, upgrade_type, parse_external)
 571         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
 572         unnecessary cast.
 573         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
 574
 575 2019-06-16  Tom Tromey  <tom@tromey.com>
 576
 577         * tui/tui-data.c (tui_alloc_generic_win_info)
 578         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
 579         checks.
 580
 581 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
 582             Andrew Burgess  <andrew.burgess@embecosm.com>
 583
 584         * f-typeprint.c (f_print_type): Don't return early for not
 585         associated or not allocated types.
 586         (f_type_print_varspec_suffix): Add print_rank parameter and print
 587         ranks of array types in case they dangling.
 588         (f_type_print_base): Add print_rank parameter.
 589
 590 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 591
 592         * NEWS: Mention new MI commands.
 593         * break-catch-throw.c (enum exception_event_kind): Move to
 594         breakpoint.h.
 595         (print_mention_exception_catchpoint): Output text as a single
 596         message.
 597         (catch_exception_command_1): Rename to...
 598         (catch_exception_event): ...this, make non-static, update header
 599         command, and change some parameter types.
 600         (catch_catch_command): Update for changes to
 601         catch_exception_command_1.
 602         (catch_throw_command): Likewise.
 603         (catch_rethrow_command): Likewise.
 604         * breakpoint.c (enum exception_event_kind): Delete.
 605         * breakpoint.h (enum exception_event_kind): Moved here from
 606         break-catch-throw.c.
 607         (catch_exception_event): Declare.
 608         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
 609         (mi_cmd_catch_throw): New function.
 610         (mi_cmd_catch_rethrow): New function.
 611         (mi_cmd_catch_catch): New function.
 612         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
 613         'catch-catch' entries.
 614         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
 615         (mi_cmd_catch_rethrow): Declare.
 616         (mi_cmd_catch_catch): Declare.
 617
 618 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 619
 620         * annotate.c (annotate_source_line): Change return type to void,
 621         update implementation to match.
 622         * annotate.h (annotate_source_line): Change return type to void,
 623         update header comment.
 624         * stack.c (print_frame_info): Don't change what frame information
 625         is printed based on whether annotations are on or not.
 626
 627 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 628
 629         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
 630         (annotate_source): Make static.
 631         (annotate_source_line): Moved from source.c and renamed from
 632         identify_source_line.  Update the return type.
 633         * annotate.h (annotate_source): Delete declaration.
 634         (annotate_source_line): Declaration moved from source.h, and
 635         renamed from identify_source_line.  Return type updated.
 636         * source.c (identify_source_line): Moved to annotate.c and renamed
 637         to annotate_source_line.
 638         (info_line_command): Remove check of annotation_level.
 639         * source.h (identify_source_line): Move declaration to annotate.h
 640         and rename to annotate_source_line.
 641         * stack.c: Add 'annotate.h' include.
 642         (print_frame_info): Remove check of annotation_level before
 643         calling annotate_source_line.
 644
 645 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 646
 647         * source-cache.c (source_cache::get_plain_source_lines): Use
 648         open_source_file_with_line_charpos instead of just
 649         open_source_file, remove call to find_source_lines.
 650         (source_cache::get_source_lines): Likewise.
 651         * source.c (find_source_lines): Make static.
 652         (get_filename_and_charpos): Renamed into...
 653         (open_source_file_with_line_charpos): ..this along with changes to
 654         return a scoped_fd, and some other minor clean ups.
 655         (identify_source_line): Use open_source_file_with_line_charpos.
 656         (search_command_helper): Use open_source_file_with_line_charpos
 657         instead of just open_source_file, remove call to
 658         find_source_lines.
 659         * source.h (open_source_file_with_line_charpos): Declare new
 660         function.
 661         (find_source_lines): Delete declaration.
 662
 663 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 664
 665         * source.c (get_filename_and_charpos): Remove fullname
 666         parameter.
 667         (identify_source_line): Update call to get_filename_and_charpos.
 668
 669 2019-06-14  Tom Tromey  <tromey@adacore.com>
 670
 671         PR gdb/24502:
 672         * ui-style.h (skip_ansi_escape): Update comment.
 673         * ui-file.h (class no_terminal_escape_file): New class.
 674         * ui-file.c (no_terminal_escape_file::write)
 675         (no_terminal_escape_file::puts): New methods.
 676         * cli/cli-logging.c (handle_redirections): Use
 677         no_terminal_escape_file.
 678
 679 2019-06-14  Tom Tromey  <tromey@adacore.com>
 680
 681         * NEWS: Move convenience variable news above Python news.
 682
 683 2019-06-14  Tom Tromey  <tom@tromey.com>
 684
 685         * gnulib: Move directory to top-level.
 686         * configure.ac: Don't configure gnulib.
 687         * configure: Rebuild.
 688         * common/common-defs.h: Use new path to gnulib.
 689         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
 690         (GNULIB_H): Remove.
 691         (INCGNU): Look in new gnulib location.
 692         (HFILES_NO_SRCDIR): Remove gnulib files.
 693         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
 694         (generated_files): Remove GNULIB_H.
 695         ($(LIBGNU), all-lib): Remove targets.
 696         (distclean): Don't mention GNULIB_BUILDDIR.
 697         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
 698
 699 2019-06-14  Tom Tromey  <tromey@adacore.com>
 700
 701         * symfile.c (add_symbol_file_command): Remove obsolete comment.
 702         Warn if symbol file does not provide any symbols.
 703
 704 2019-06-14  Tom Tromey  <tromey@adacore.com>
 705
 706         * source.c (find_and_open_source): Respect basenames_may_differ.
 707
 708 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
 709
 710         * annotate.c (annotate_breakpoints_invalid): Make use of
 711         scoped_restore_terminal_state.
 712         (annotate_frames_invalid): Likewise.
 713
 714 2019-06-14  Tom Tromey  <tromey@adacore.com>
 715
 716         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
 717         allow assignment to an internalvar.
 718
 719 2019-06-14  Tom Tromey  <tromey@adacore.com>
 720
 721         * ada-lex.l: Allow "_" in attribute names.
 722
 723 2019-06-14  Tom Tromey  <tromey@adacore.com>
 724
 725         PR gdb/24653:
 726         * regcache.c (registers_changed): Don't call alloca.
 727         * top.c (execute_command): Don't call alloca.
 728
 729 2019-06-13  Pedro Alves  <palves@redhat.com>
 730
 731         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
 732         'expression'.  When parsing an expression, error out if there's
 733         junk after "unlimited".
 734         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 735         (do_set_command): Adjust calls to is_unlimited_literal.
 736
 737 2019-06-13  Pedro Alves  <palves@redhat.com>
 738
 739         * compile/compile.c (make_compile_options_def_group): Add braces
 740         around array_view initializer.
 741         * thread.c (make_thread_apply_all_options_def_group)
 742         (make_thread_apply_all_options_def_group): Likewise.
 743
 744 2019-06-13  Pedro Alves  <palves@redhat.com>
 745
 746         * NEWS (New commands): Mention "maint test-options
 747         require-delimiter", "maint test-options unknown-is-error", "maint
 748         test-options unknown-is-operand" and "maint show
 749         test-options-completion-result".
 750         (New command options, command completion): New section.
 751         (Completion improvements): New section.
 752         Mention that you can abbreviate "unlimited".
 753
 754 2019-06-13  Pedro Alves  <palves@redhat.com>
 755
 756         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
 757         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
 758         * unittests/cli-utils-selftests.c (test_parse_flags)
 759         (test_parse_flags_qcs): Delete.
 760         (test_cli_utils): Don't call deleted functions.
 761
 762 2019-06-13  Pedro Alves  <palves@redhat.com>
 763
 764         * thread.c: Include "cli/cli-option.h".
 765         (tp_array_compar_ascending): Global.
 766         (tp_array_compar): Delete function.
 767         (tp_array_compar_ascending, tp_array_compar_descending): New
 768         functions.
 769         (ascending_option_def, qcs_flag_option_def)
 770         (thr_qcs_flags_option_defs)
 771         (make_thread_apply_all_options_def_group)
 772         (make_thread_apply_options_def_group): New.
 773         (thread_apply_all_command): Use gdb::option::process_options.
 774         (thread_apply_command_completer)
 775         (thread_apply_all_command_completer): New.
 776         (thread_apply_command): Use gdb::option::process_options.
 777         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
 778         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
 779         to generate help text of "thread apply".  Adjust "taas"'s help.
 780         * tid-parse.c (tid_range_parser::in_thread_range): New method.
 781         * tid-parse.h (tid_range_parser::in_thread_range): New method.
 782
 783 2019-06-13  Pedro Alves  <palves@redhat.com>
 784
 785         * thread.c (thread_apply_command): Check for invalid TID with
 786         isdigit instead of !isalpha.
 787
 788 2019-06-13  Pedro Alves  <palves@redhat.com>
 789
 790         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
 791         (validate_flags_qcs): New.
 792         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
 793         (validate_flags_qcs): Declare.
 794         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
 795         (make_frame_apply_options_def_group): New.
 796         (frame_apply_command_count): Process options with
 797         gdb::option::process_options.
 798         (frame_apply_completer): New.
 799         (frame_apply_level_completer, frame_apply_all_completer)
 800         (frame_apply_completer): New.
 801         (_initialize_stack): Update help of "frame apply", "frame apply
 802         level", "frame apply all" and "faas" to mention supported options
 803         and install command completers.
 804         * stack.h (frame_apply_all_completer): Declare.
 805         * thread.c: Include "stack.h".
 806         (tfaas_command): Add "--".
 807         (_initialize_thread): Update help "tfaas" to mention supported
 808         options and install command completer.
 809
 810 2019-06-13  Pedro Alves  <palves@redhat.com>
 811
 812         * completer.c (complete_nested_command_line): New.
 813         (gdb_completion_word_break_characters_throw): Add assertion.
 814         * completer.h (complete_nested_command_line): Declare.
 815
 816 2019-06-13  Pedro Alves  <palves@redhat.com>
 817
 818         * stack.c (parse_backtrace_qualifiers): New.
 819         (backtrace_command): Use it.
 820         (backtrace_command_completer): Complete on qualifiers.
 821
 822 2019-06-13  Pedro Alves  <palves@redhat.com>
 823
 824         * frame.c: Include "cli/cli-option.h.
 825         (user_set_backtrace_options): New.
 826         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
 827         Delete.
 828         (get_prev_frame): Adjust.
 829         (boolean_option_def, uinteger_option_def)
 830         (set_backtrace_option_defs): New.
 831         (_initialize_frame): Adjust and use
 832         gdb::option::add_setshow_cmds_for_options to install "set
 833         backtrace past-main" and "set backtrace past-entry".
 834         * frame.h: Include "cli/cli-option.h".
 835         (struct frame_print_options): Forward declare.
 836         (print_frame_arguments_all, print_frame_arguments_scalars)
 837         (print_frame_arguments_none): Declare.
 838         (print_entry_values): Delete declaration.
 839         (struct frame_print_options, user_frame_print_options): New.
 840         (struct set_backtrace_options): New.
 841         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
 842         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
 843         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
 844         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
 845         (list_args_or_locals): Add frame_print_options parameter.
 846         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 847         * python/py-framefilter.c (enumerate_args): Pass down
 848         USER_FRAME_PRINT_OPTIONS.
 849         * stack.c: Include "cli/cli-option.h".
 850         (print_frame_arguments_all, print_frame_arguments_scalars)
 851         (print_frame_arguments_none): Declare.
 852         (print_raw_frame_arguments, print_entry_values): Delete.
 853         (user_frame_print_options): New.
 854         (boolean_option_def, enum_option_def, frame_print_option_defs):
 855         New.
 856         (struct backtrace_cmd_options): New.
 857         (bt_flag_option_def): New.
 858         (backtrace_command_option_defs): New.
 859         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 860         (print_frame_arg, read_frame_arg, print_frame_args)
 861         (print_frame_info, print_frame): Add frame_print_options parameter
 862         and use it.
 863         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
 864         (backtrace_command_1): Add frame_print_options and
 865         backtrace_cmd_options parameters and use them.
 866         (make_backtrace_options_def_group): New.
 867         (backtrace_command): Process command options with
 868         gdb::option::process_options.
 869         (backtrace_command_completer): New.
 870         (_initialize_stack): Extend "backtrace"'s help to mention
 871         supported options.  Install completer for "backtrace".
 872         Install some settings commands with add_setshow_cmds_for_options.
 873
 874 2019-06-13  Pedro Alves  <palves@redhat.com>
 875
 876         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
 877         and that "set/show print raw frame-arguments" are now deprecated.
 878
 879         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
 880         command.
 881         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
 882         * stack.c (_initialize_stack): Install "set/show print
 883         raw-frame-arguments", and deprecate "set/show print raw
 884         frame-arguments".
 885         * valprint.c (_initialize_valprint): Deprecate "set/show print
 886         raw".
 887
 888 2019-06-13  Pedro Alves  <palves@redhat.com>
 889
 890         * compile/compile.c (struct compile_options): New.
 891         (compile_flag_option_def, compile_command_option_defs)
 892         (make_compile_options_def_group): New.
 893         (compile_file_command): Handle options with
 894         gdb::option::process_options.
 895         (compile_file_command_completer): New function.
 896         (compile_code_command): Handle options with
 897         gdb::option::process_options.
 898         (compile_code_command_completer): New function.
 899         (_initialize_compiler): Install completers for "compile code" and
 900         "compile file".  Mention available options in "compile code" and
 901         "compile code"'s help.
 902         * completer.c (advance_to_completion_word): New, factored out from
 903         ...
 904         (advance_to_expression_complete_word_point): ... this.
 905         (advance_to_filename_complete_word_point): New.
 906         * completer.h (advance_to_filename_complete_word_point): New
 907         declaration.
 908
 909 2019-06-13  Pedro Alves  <palves@redhat.com>
 910
 911         * compile/compile.c: Include "cli/cli-option.h".
 912         (compile_print_value): Scope data pointer is now a
 913         value_print_options pointer; adjust.
 914         (compile_print_command): Process options.  Scope data pointer is
 915         now a value_print_options pointer; adjust.
 916         (_initialize_compile): Update "compile print"'s help to include
 917         supported options.  Install a completer for "compile print".
 918         * cp-valprint.c (show_vtblprint, show_objectprint)
 919         (show_static_field_print): Delete.
 920         (_initialize_cp_valprint): Don't install "set print
 921         static-members", "set print vtbl", "set print object" here.
 922         * printcmd.c: Include "cli/cli-option.h" and
 923         "common/gdb_optional.h".
 924         (print_command_parse_format): Rework to fill in a
 925         value_print_options instead of a format_data.
 926         (print_value): Change parameter type from format_data pointer to
 927         value_print_options reference.  Adjust.
 928         (print_command_1): Process options.  Adjust to pass down a
 929         value_print_options.
 930         (print_command_completer): New.
 931         (_initialize_printcmd): Install print_command_completer as
 932         handle_brkchars completer for the "print" command.  Update
 933         "print"'s help to include supported options.
 934         * valprint.c: Include "cli/cli-option.h".
 935         (show_vtblprint, show_objectprint, show_static_field_print): Moved
 936         here from cp-valprint.c.
 937         (boolean_option_def, uinteger_option_def)
 938         (value_print_option_defs, make_value_print_options_def_group):
 939         New.  Use gdb::option::add_setshow_cmds_for_options to install
 940         "set print elements", "set print null-stop", "set print repeats",
 941         "set print pretty", "set print union", "set print array", "set
 942         print address", "set print symbol", "set print array-indexes".
 943         * valprint.h: Include <string> and "cli/cli-option.h".
 944         (make_value_print_options_def_group): Declare.
 945         (print_value): Change parameter type from format_data pointer to
 946         value_print_options reference.
 947         (print_command_completer): Declare.
 948
 949 2019-06-13  Pedro Alves  <palves@redhat.com>
 950
 951         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
 952         (COMMON_SFILES): Add maint-test-settings.c.
 953         * cli/cli-decode.c (boolean_enums): New global, factored out from
 954         ...
 955         (add_setshow_boolean_cmd): ... here.
 956         * cli/cli-decode.h (boolean_enums): Declare.
 957         * cli/cli-option.c: New file.
 958         * cli/cli-option.h: New file.
 959         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
 960         factored out from ...
 961         (parse_cli_boolean_value(const char *)): ... this.
 962         (is_unlimited_literal): Change parameter type to pointer to
 963         pointer.  Adjust and advance ARG pointer.
 964         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 965         (parse_cli_var_enum): New, factored out from ...
 966         (do_set_command): ... this.  Adjust.
 967         * cli/cli-setshow.h (parse_cli_boolean_value)
 968         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 969         (parse_cli_var_enum): Declare.
 970         * cli/cli-utils.c: Include "cli/cli-option.h".
 971         (get_ulongest): New.
 972         * cli/cli-utils.h (get_ulongest): Declare.
 973         (check_for_argument): New overloads.
 974         * maint-test-options.c: New file.
 975
 976 2019-06-13  Pedro Alves  <palves@redhat.com>
 977
 978         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
 979         parse a range if "-" is at the end of the string.
 980
 981 2019-06-13  Pedro Alves  <palves@redhat.com>
 982
 983         * cli/cli-setshow.c (parse_auto_binary_operation)
 984         (parse_cli_boolean_value): Don't allow "o".
 985
 986 2019-06-13  Pedro Alves  <palves@redhat.com>
 987
 988         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
 989         * NEWS: Mention maint test-settings KIND.
 990         * maint-test-settings.c: New file.
 991
 992 2019-06-13  Pedro Alves  <palves@redhat.com>
 993
 994         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
 995         completer.
 996         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
 997         "set" completers.
 998
 999 2019-06-13  Pedro Alves  <palves@redhat.com>
1000
1001         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
1002         after item.
1003
1004 2019-06-13  Pedro Alves  <palves@redhat.com>
1005
1006         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
1007
1008 2019-06-13  Pedro Alves <palves@redhat.com>
1009
1010         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
1011         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
1012         call.
1013         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
1014         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
1015         calls.
1016         (check_for_argument): Skip spaces after argument.
1017
1018 2019-06-13  Pedro Alves  <palves@redhat.com>
1019
1020         * thread.c (thread_apply_command): Adjust TID parsing.
1021         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
1022         detected before end of string.
1023         (tid_is_in_list): Error out if LIST is invalid.
1024
1025 2019-06-13  Pedro Alves  <palves@redhat.com>
1026
1027         * completer.c (complete_line_internal_1): Rewind completion word
1028         point.
1029         (completion_tracker::advance_custom_word_point_by): Change
1030         parameter type to int.
1031         * completer.h (completion_tracker::advance_custom_word_point_by):
1032         Likewise.
1033
1034 2019-06-13  Pedro Alves  <palves@redhat.com>
1035
1036         * completer.c (advance_to_completion_word): Handle delimiters.
1037
1038 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
1039
1040         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
1041
1042 2019-06-11  Tom Tromey  <tom@tromey.com>
1043
1044         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
1045         (xmalloc_failed): Move to alloc.c.
1046         * alloc.c: New file.
1047         * Makefile.in (COMMON_SFILES): Add alloc.c.
1048
1049 2019-06-11  Tom Tromey  <tom@tromey.com>
1050
1051         * nat/linux-waitpid.c: Don't include server.h.
1052         (linux_debug): Remove.
1053         (my_waitpid): Update.
1054
1055 2019-06-11  Tom Tromey  <tromey@adacore.com>
1056
1057         * infcall.c (_initialize_infcall): Remove trailing newline from
1058         help.
1059         * user-regs.c (_initialize_user_regs): Remove trailing newline
1060         from help.
1061         * typeprint.c (_initialize_typeprint): Remove trailing newline
1062         from help.
1063         * reverse.c (_initialize_reverse): Remove trailing newlines from
1064         help.
1065         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
1066         from help.
1067         * language.c (add_set_language_command): Remove trailing newline
1068         from help.
1069         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
1070         help.
1071         * disasm.c (_initialize_disasm): Remove trailing newline from
1072         help.
1073         * top.c (init_main): Remove trailing newline from help.
1074         * interps.c (_initialize_interpreter): Remove trailing newline
1075         from help.
1076         * btrace.c (_initialize_btrace): Remove trailing newlines from
1077         help.
1078         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
1079         from help.
1080         * python/python.c (_initialize_python): Remove trailing newline
1081         from help.
1082         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
1083         help.
1084         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
1085         from help.  Reformat some text.
1086         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
1087         from help.
1088         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
1089         newline from help.
1090
1091 2019-06-11  Tom Tromey  <tromey@adacore.com>
1092
1093         * darwin-nat.c (darwin_decode_exception_message)
1094         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
1095
1096 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1097
1098         * valops.c (value_slice): Check for not allocated or not
1099         associated values.
1100
1101 2019-06-10  Tom de Vries  <tdevries@suse.de>
1102
1103         PR gdb/24618
1104         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
1105         sure an empty slot (defined by a 32-bit zero pair) is recognized as
1106         invalid.
1107
1108 2019-06-10  Tom de Vries  <tdevries@suse.de>
1109
1110         PR gdb/24611
1111         * linespec.c (linespec_lexer_lex_string): Remove incorrect
1112         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
1113
1114 2019-06-10  Tom de Vries  <tdevries@suse.de>
1115
1116         PR symtab/24545
1117         * symtab.c (struct demangled_name_entry): Add language field.
1118         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
1119         static minimal symbol".  Set and use language field.
1120
1121 2019-06-10  Tom Tromey  <tromey@adacore.com>
1122
1123         * ada-lang.c (_initialize_ada_language): Update help text.
1124
1125 2019-06-10  Tom Tromey  <tromey@adacore.com>
1126
1127         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
1128         with a newline.
1129         * guile/guile.c (handle_boot_error): Don't end warning with a
1130         newline.
1131         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
1132         warning with a newline.
1133         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
1134         newline.
1135         (s12z_frame_cache): Likewise.
1136         * dwarf-index-cache.c (index_cache::store): Don't end warning with
1137         a newline.
1138         * solib-svr4.c (disable_probes_interface): Don't end warning with
1139         a newline.
1140         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
1141         newline.
1142         * python/python.c (do_finish_initialization): Don't end warning
1143         with a newline.
1144
1145 2019-06-10  Tom Tromey  <tom@tromey.com>
1146
1147         * python/py-breakpoint.c (gdbpy_breakpoint_created)
1148         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
1149         gdbpy_enter.
1150
1151 2019-06-10  Tom Tromey  <tromey@adacore.com>
1152
1153         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
1154         data.
1155         (elf_new_init): Don't call stabsread_new_init.
1156         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
1157         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
1158         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
1159
1160 2019-06-10  Tom de Vries  <tdevries@suse.de>
1161
1162         PR symtab/16264
1163         PR symtab/24517
1164         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
1165
1166 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
1167
1168         * source.c (find_and_open_source): Also rewrite relative file
1169         names.
1170
1171 2019-04-26  Amos Bird  <amosbird@gmail.com>
1172
1173         * annotate.c (annotate_thread_exited): Add "thread-exited"
1174         annotation.
1175
1176 2019-06-06  Tom Tromey  <tromey@adacore.com>
1177
1178         * maint.h (class scoped_command_stats): Use
1179         DISABLE_COPY_AND_ASSIGN.
1180         <print_time>: New method.
1181         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
1182         print_time.
1183         (scoped_command_stats::print_time): New method.
1184
1185 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
1186
1187         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
1188         instructions of lengths 6 or 8 bytes.
1189
1190 2019-06-04  Pedro Alves  <palves@redhat.com>
1191
1192         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
1193
1194         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
1195         * breakpoint.c (condition_completer): Likewise.
1196         * cli/cli-dump.c (scan_expression): Likewise.
1197         * common/filestuff.c (mkdir_recursive): Likewise.
1198         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
1199         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
1200         (gdb_abspath): Likewise.
1201         * compile/compile-cplus-types.c
1202         (compile_cplus_instance::decl_name): Likewise.
1203         * completer.c (complete_explicit_location):
1204         (signal_completer, reg_or_group_completer_1): Likewise.
1205         * cp-support.c (cp_remove_params_if_any): Likewise.
1206         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
1207         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
1208         * infcmd.c (strip_bg_char): Likewise.
1209         * linespec.c (copy_token_string): Likewise.
1210         * mi/mi-main.c (output_cores): Likewise.
1211         * psymtab.c (psymtab_search_name):
1212         * symfile.c (test_set_ext_lang_command): Likewise.
1213         * target.c (target_fileio_read_stralloc): Likewise.
1214         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
1215         * value.c (complete_internalvar): Likewise.
1216
1217 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
1218
1219         Add objfile property to gdb.Type.
1220         * NEWS: Mention Python API addition.
1221         * python/py-type.c (typy_get_objfile): New method.
1222
1223 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1224
1225         * NEWS: Mention the new set|show style [title|highlight].
1226         Mention changes to "show style", "help" and "apropos".
1227
1228 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1229
1230         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
1231         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
1232         instead of print_help_for_command.
1233         (print_doc_of_command): New function.
1234         (help_list): Add 'apropos -v word' suggestion.
1235         (print_help_for_command): Style the command name using title style.
1236         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
1237         (_initialize_cli_cmds): Describe -v in apropos_command help.
1238
1239 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1240
1241         * cli/cli-style.h (cli_style_option): Add name in constructor,
1242         add m_name class member, add constructor with intensity,
1243         add name class function.
1244         (cli_style_option::add_setshow_commands): Remove name argument.
1245         (highlight_style, title_style): New styles.
1246         * cli/cli-style.c (do_show): New function that shows a style
1247         characteristic styling the style name with itself.
1248         (set_style_name): New function.
1249         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
1250         Update all callers according to the changes in cli/cli-style.h.
1251         * utils.h (fputs_highlighted): New function.
1252         * utils.c (fputs_highlighted): Likewise.
1253
1254 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1255
1256         * NEWS: Mention new pipe command and new convenience variables.
1257
1258 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1259
1260         * cli/cli-cmds.c (pipe_command): New function.
1261         (_initialize_cli_cmds): Call add_com for pipe_command.
1262         Define | as an alias for pipe.
1263         (exit_status_set_internal_vars): New function.
1264         (shell_escape): Call exit_status_set_internal_vars.
1265         cli/cli-decode.c (find_command_name_length): Recognize | as
1266         a single character command.
1267
1268 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1269
1270         * gdbcmd.h (execute_command_to_ui_file): New declaration.
1271         top.c (execute_command_to_ui_file): New function, mostly a copy
1272         of execute_command_to_string.
1273         (execute_command_to_string): Implement by calling
1274         execute_command_to_ui_file.
1275
1276 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1277
1278         * top.h (saved_command_line): Remove declaration.
1279         * top.c (previous_saved_command_line, previous_repeat_arguments):
1280         New variables.
1281         (saved_command_line): Make static, define together with other
1282         'repeat variables'.
1283         (dont_repeat): Clear repeat_arguments.
1284         (repeat_previous, get_saved_command_line, save_command_line):
1285         New functions.
1286         (gdb_init): Initialize saved_command_line
1287         and previous_saved_command_line.
1288         * main.c (captured_main_1): Remove saved_command_line initialization.
1289         * event-top.c (handle_line_of_input): Update to use
1290         the new 'repeat' related functions instead of direct access to
1291         saved_command_line.
1292         * command.h (repeat_previous, get_saved_command_line,
1293         save_command_line): New declarations.
1294         (dont_repeat): Add comment.
1295
1296 2019-05-30  Tom Tromey  <tromey@adacore.com>
1297
1298         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
1299         Fix comment.
1300         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
1301
1302 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
1303
1304         PR cli/24587
1305         * completer.c (complete): Initialize variable word.
1306
1307 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
1308
1309         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1310         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
1311         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
1312         'body' is NULL to the outter 'if', protecting the '!is_define'
1313         situation as well.
1314
1315 2019-05-29  Tom Tromey  <tromey@adacore.com>
1316
1317         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
1318         (dwarf_unknown): New function.
1319         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
1320         (dwarf_type_encoding_name): Use dwarf_unknown.
1321
1322 2019-05-29  Tom Tromey  <tromey@adacore.com>
1323
1324         PR c++/20020:
1325         * cp-valprint.c (cp_print_value_fields): Call
1326         cp_print_static_field inside "try".
1327
1328 2019-05-29  Tom Tromey  <tromey@adacore.com>
1329
1330         * inflow.c (struct terminal_info): Add default operator=.
1331         * configure: Rebuild.
1332         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
1333         -Wdeprecated-copy-dtor, -Wredundant-move.
1334
1335 2019-05-29  Tom Tromey  <tromey@adacore.com>
1336
1337         * NEWS: Add entry.
1338         * infcmd.c (print_return_value_1): Handle finish_print
1339         option.
1340         (show_print_finish): New function.
1341         (_initialize_infcmd): Add "set/show print finish" commands.
1342         * valprint.c (user_print_options): Initialize new member.
1343         * valprint.h (struct value_print_options) <finish_print>: New
1344         member.
1345
1346 2019-05-28  Tom Tromey  <tromey@adacore.com>
1347
1348         * ada-lang.c (ada_remove_Xbn_suffix)
1349         (find_old_style_renaming_symbol)
1350         (parse_old_style_renaming): Remove.
1351         (ada_find_renaming_symbol): Don't call
1352         find_old_style_renaming_symbol.
1353         (ada_is_renaming_symbol): Rename from
1354         ada_find_renaming_symbol.  Remove "block" parameter.  Return
1355         bool.  Now static.
1356         (ada_read_var_value): Update and simplify.
1357         * ada-exp.y (write_var_or_type): Remove old code.
1358
1359 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
1360
1361         * event-top.c: Remove include comment.
1362         * inflow.c (class scoped_ignore_sigttou): Move from here...
1363         * inflow.h (class scoped_ignore_sigttou): ...to here.
1364         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
1365         * top.c:  Remove include comment.
1366
1367 2019-05-27  Tom Tromey  <tom@tromey.com>
1368
1369         * NEWS: Fix typo.
1370
1371 2019-05-22  Tom Tromey  <tromey@adacore.com>
1372
1373         * target.c (target_follow_exec): Constify parameter.
1374         * target-delegates.c: Rebuild.
1375         * remote.c (remote_target::follow_exec): Constify parameter.
1376         * infrun.c (follow_exec): Constify parameter.
1377         * target.h (struct target_ops) <follow_exec>: Constify parameter.
1378         (target_follow_exec): Likewise.
1379
1380 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1381
1382         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
1383         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
1384
1385 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1386
1387         * NEWS: Add debugredirect and testsuite sections.
1388
1389 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
1390
1391         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
1392         target descriptions using exclusively floating point register name
1393         aliases.
1394
1395 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1396
1397         PR gdb/18644:
1398         * f-lang.c (build_fortran_types): Handle the case where
1399         gdbarch_floatformat_for_type returns a nullptr.
1400
1401 2019-05-21  Tom de Vries  <tdevries@suse.de>
1402
1403         PR cli/24587
1404         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
1405
1406 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1407
1408         PR gdb/18644:
1409         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
1410         16-byte floats.
1411         * i386-tdep.c (i386_floatformat_for_type): Use
1412         floatformats_ia64_quad for the 16-byte floating point component
1413         within a fortran 32-byte complex number.
1414
1415 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1416
1417         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
1418         delete default constructor.
1419         (find_partial_die): Update to return const struct.
1420         (partial_die_parent_scope): Move variable declaration into scope
1421         of its use and change its type to auto.
1422         (guess_partial_die_structure_name): Likewise.
1423         (partial_die_info::fixup): Likewise.
1424
1425 2019-05-17  Tom Tromey  <tromey@adacore.com>
1426
1427         * source.c (find_and_open_source): Remove cast.
1428
1429 2019-05-17  Tom Tromey  <tromey@adacore.com>
1430
1431         * annotate.c (annotate_source): Make "filename" const.
1432         * annotate.h (annotate_source): Use const.
1433
1434 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1435
1436         * disasm.c (set_disassembler_options): Send errors to stderr.
1437
1438 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1439
1440         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
1441         (cli_interp_base::set_logging): Check debug_redirect.
1442         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
1443         * cli/cli-logging.c (debug_redirect): Add static variable.
1444         (pop_output_files): Add default param.
1445         (handle_redirections): Print debug setting.
1446         (show_logging_command): Likewise.
1447         (_initialize_cli_logging): Add debugredirect command.
1448         * interps.c (current_interp_set_logging): Add debug_redirect
1449         parameter.
1450         * interps.h (set_logging): Add debug_redirect parameter.
1451         (current_interp_set_logging): Likewise.
1452         * mi/mi-common.h: Likewise.
1453         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
1454
1455 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1456             Tom Tromey  <tromey@adacore.com>
1457
1458         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
1459         directly.
1460         * cli/cli-interp.h (make_logging_output): Remove declaration.
1461         * cli/cli-logging.c (make_logging_output): Remove function.
1462         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
1463         directly.
1464         * ui-file.c (tee_file::tee_file): Remove bools.
1465         (tee_file::~tee_file): Remove deletes.
1466         * ui-file.h (tee_file): Remove bools.
1467
1468 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
1469
1470         * mi/mi-cmds.h (mi_cmd_complete): New function.
1471         * mi/mi-main.c (mi_cmd_complete): Likewise.
1472         * mi/mi-cmds.c: Define new MI command -complete.
1473         * NEWS: Mention new -complete command.
1474
1475 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
1476
1477         * completer.h (complete): New function.
1478         * completer.c (complete): Likewise.
1479         * cli/cli-cmds.c: (complete_command): Update to use new complete()
1480         function defined in completer.h.
1481
1482 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
1483
1484         * MAINTAINERS (Write After Approval): Add myself.
1485
1486 2019-05-17  Tom de Vries  <tdevries@suse.de>
1487
1488         PR gdb/24094
1489         * dwarf2read.c (struct cu_partial_die_info): New struct.
1490         (find_partial_die): Return cu_partial_die_info.
1491         (partial_die_parent_scope, guess_partial_die_structure_name)
1492         (partial_die_info::fixup): Handle new return type of find_partial_die.
1493
1494 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1495
1496         * stap-probe.c (stap_parse_register_operand): Make "regname" an
1497         "std::string", simplifying the algorithm.
1498
1499 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1500
1501         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
1502         (stap_static_probe_ops::get_probes): Likewise.
1503
1504 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1505
1506         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
1507         '-')" and "else if".
1508         (stap_parse_single_operand): Join checks for
1509         "gdbarch_stap_parse_special_token_p" and
1510         "gdbarch_stap_parse_special_token" in the same "if" statement.
1511         Invert check when verifying for operation on register
1512         displacement.
1513
1514 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1515
1516         * stap-probe.c (stap_get_opcode): Update comment.
1517         (stap_get_expected_argument_type): Likewise.
1518         (handle_stap_probe): Likewise.
1519
1520 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1521
1522         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
1523         return type to 'bool'.  Adjust comment.  Use 'bool' when
1524         appropriate.
1525         (i386_stap_parse_special_token_three_arg_disp): Likewise.
1526         * stap-probe.c (stap_parse_argument_1): Likewise.
1527         (stap_is_operator): Likewise.
1528         (stap_is_generic_prefix): Likewise.
1529         (stap_is_register_prefix): Likewise.
1530         (stap_is_register_indirection_prefix): Likewise.
1531         (stap_is_integer_prefix): Likewise.
1532         (stap_generic_check_suffix): Likewise.
1533         (stap_check_integer_suffix): Likewise.
1534         (stap_check_register_suffix): Likewise.
1535         (stap_check_register_indirection_suffix): Likewise.
1536         (stap_parse_register_operand): Likewise.
1537         (stap_parse_single_operand): Likewise.
1538         (stap_parse_argument_1): Likewise.
1539         (stap_probe::get_argument_count): Likewise.
1540         (stap_is_operator): Likewise.
1541
1542 2019-05-16  Tom Tromey  <tromey@adacore.com>
1543
1544         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
1545         keyword to foreach.
1546
1547 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
1548
1549         * linux-thread-db.c (try_thread_db_load_1): Change return type
1550         to bool.
1551         (try_thread_db_load): Likewise.
1552         (try_thread_db_load_from_pdir_1): Likewise.
1553         (try_thread_db_load_from_pdir): Likewise.
1554         (try_thread_db_load_from_sdir): Likewise.
1555         (try_thread_db_load_from_dir): Likewise.
1556         (thread_db_load_search): Likewise.
1557         (has_libpthread): Likewise.
1558         (thread_db_load): Likewise.
1559
1560 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
1561
1562         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1563         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
1564         NULL, and complain/return if that's the case.
1565
1566 2019-05-15  John Darrington <john@darrington.wattle.id.au>
1567
1568         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
1569         (advance, posn, abstract_read_memory): New functions.
1570         [struct mem_read_abstraction]: New struct.
1571         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
1572
1573 2019-05-14  Tom Tromey  <tromey@adacore.com>
1574
1575         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
1576         value is not lval_memory.
1577
1578 2019-05-14  Tom Tromey  <tromey@adacore.com>
1579
1580         * solib.c (info_sharedlibrary_command): Style the file name.
1581
1582 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
1583
1584         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
1585         (aarch64_vnv_type): Likewise.
1586         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
1587         * common/tdesc.c: Likewise.
1588         * common/tdesc.h (enum tdesc_type_kind): Likewise.
1589         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
1590         * features/aarch64-fpu.xml: Add ieee half view.
1591         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
1592         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
1593         * gdbtypes.h (struct builtin_type): Likewise.
1594         (struct objfile_type): Likewise.
1595
1596 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
1597
1598         * language.c (language_sniff_from_mangled_name): Fix "langauge"
1599         typo.
1600         * location.h (string_to_event_location): Likewise.
1601
1602 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
1603
1604         GDB 8.3 released.
1605
1606 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1607
1608         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
1609         New variable declaration.
1610         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
1611         New variable.
1612         (print_one_breakpoint): Use ui_out::test_flags and new global
1613         variable to compute use_fixed_output.
1614         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
1615         Remove.
1616         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
1617         (mi_multi_location_breakpoint_output_fixed): Remove.
1618         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
1619         new variable.
1620         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
1621         fix_multi_location_breakpoint_output flag if version >= 3.
1622         * ui-out.h (enum ui_out_flag)
1623         <fix_multi_location_breakpoint_output>: New enumerator.
1624
1625 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1626
1627         * contrib/cc-with-tweaks.sh: Validate dwz's work.
1628
1629 2019-05-10  Tom Tromey  <tromey@adacore.com>
1630
1631         * ada-lang.c (catch_ada_completer): New function.
1632         (_initialize_ada_language): Use it.
1633
1634 2019-05-10  Tom Tromey  <tromey@adacore.com>
1635
1636         * thread.c (print_thread_info): Make "requested_threads" const.
1637         * gdbthread.h (print_thread_info): Make "requested_threads"
1638         const.
1639         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
1640         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
1641
1642 2019-05-08  Tom Tromey  <tom@tromey.com>
1643
1644         * gdbtypes.c (objfile_type_data): Change type.
1645         (objfile_type, _initialize_gdbtypes): Update.
1646
1647 2019-05-08  Tom Tromey  <tom@tromey.com>
1648
1649         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
1650         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
1651         (_initialize_dwarf2_frame): Update.
1652
1653 2019-05-08  Tom Tromey  <tom@tromey.com>
1654
1655         * objc-lang.c (objc_objfile_data): Change type.
1656         (find_methods): Update.
1657         (_initialize_objc_lang): Remove.
1658
1659 2019-05-08  Tom Tromey  <tom@tromey.com>
1660
1661         * stabsread.c (rs6000_builtin_type_data): Change type.
1662         (rs6000_builtin_type, _initialize_stabsread): Update.
1663
1664 2019-05-08  Tom Tromey  <tom@tromey.com>
1665
1666         * mips-tdep.c (mips_pdr_data): Remove.
1667         (_initialize_mips_tdep): Update.
1668
1669 2019-05-08  Tom Tromey  <tom@tromey.com>
1670
1671         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
1672         (hppa_init_objfile_priv_data, read_unwind_info)
1673         (find_unwind_entry, _initialize_hppa_tdep): Update.
1674
1675 2019-05-08  Tom Tromey  <tom@tromey.com>
1676
1677         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
1678         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
1679         on obstack.
1680         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
1681
1682 2019-05-08  Tom Tromey  <tom@tromey.com>
1683
1684         * mdebugread.c (basic_type_data): Change type.
1685         (basic_type, _initialize_mdebugread): Update.
1686
1687 2019-05-08  Tom Tromey  <tom@tromey.com>
1688
1689         * common/gdb_unique_ptr.h (struct noop_deleter): New.
1690
1691 2019-05-08  Tom Tromey  <tom@tromey.com>
1692
1693         * nto-tdep.c (nto_inferior_data_reg): Change type.
1694         (nto_inferior_data): Update.
1695         (nto_inferior_data_cleanup, nto_new_inferior_data)
1696         (_initialize_nto_tdep): Remove.
1697         * nto-tdep.h (struct nto_inferior_data): Add initializers.
1698
1699 2019-05-08  Tom Tromey  <tom@tromey.com>
1700
1701         * ada-lang.c (struct ada_inferior_data): Add initializers.
1702         (ada_inferior_data): Change type.
1703         (ada_inferior_data_cleanup): Remove.
1704         (get_ada_inferior_data, ada_inferior_exit)
1705         (struct ada_pspace_data): Add initializers, destructor.
1706         (ada_pspace_data_handle): Change type.
1707         (get_ada_pspace_data): Update.
1708         (ada_pspace_data_cleanup): Remove.
1709
1710 2019-05-08  Tom Tromey  <tom@tromey.com>
1711
1712         * coffread.c (struct coff_symfile_info): Add initializers.
1713         (coff_objfile_data_key): Move lower.  Change type.
1714         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
1715         Update.
1716         (coff_free_info): Remove.
1717
1718 2019-05-08  Tom Tromey  <tom@tromey.com>
1719
1720         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
1721         (fbsd_pspace_data_handle): Move lower.  Change type.
1722         (get_fbsd_pspace_data): Update.
1723         (fbsd_pspace_data_cleanup): Remove.
1724         (_initialize_fbsd_tdep): Update.
1725
1726 2019-05-08  Tom Tromey  <tom@tromey.com>
1727
1728         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
1729         (get_ada_tasks_pspace_data): Update.
1730         (ada_tasks_pspace_data_cleanup): Remove.
1731         (_initialize_tasks): Update.
1732         (ada_tasks_inferior_data_handle): Change type.
1733         (get_ada_tasks_inferior_data): Update.
1734         (ada_tasks_inferior_data_cleanup): Remove.
1735         (struct ada_tasks_pspace_data): Add initializers.
1736
1737 2019-05-08  Tom Tromey  <tom@tromey.com>
1738
1739         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
1740         * symfile-debug.c (debug_sym_get_probes): Change type.
1741         * stap-probe.c (handle_stap_probe):
1742         (stap_static_probe_ops::get_probes): Change type.
1743         * probe.h (class static_probe_ops) <get_probes>: Change type.
1744         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
1745         (parse_probes_in_pspace): Update.
1746         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
1747         Update.
1748         (any_static_probe_ops::get_probes): Change type.
1749         * elfread.c (elfread_data): New typedef.
1750         (probe_key): Change type.
1751         (elf_get_probes): Likewise.  Update.
1752         (probe_key_free): Remove.
1753         (_initialize_elfread): Update.
1754         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
1755         Change type.
1756         (dtrace_process_dof_probe, dtrace_process_dof)
1757         (dtrace_static_probe_ops::get_probe): Change type.
1758
1759 2019-05-08  Tom Tromey  <tom@tromey.com>
1760
1761         * xcoffread.c (struct xcoff_symfile_info): Rename from
1762         coff_symfile_info.  Add initializers.
1763         (xcoff_objfile_data_key): Move lower.  Change type.
1764         (XCOFF_DATA): Rewrite.
1765         (xcoff_free_info): Remove.
1766         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
1767         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
1768         (xcoff_initial_scan): Update.
1769
1770 2019-05-08  Tom Tromey  <tom@tromey.com>
1771
1772         * solib-svr4.c (struct svr4_info): Add initializers and
1773         destructor.
1774         <probes_table>: Now an htab_up.
1775         (solib_svr4_pspace_data): Change type.
1776         (free_probes_table): Simplify.
1777         (~svr4_info): Rename from svr4_pspace_data_cleanup.
1778         (get_svr4_info, probes_table_htab_remove_objfile_probes)
1779         (probes_table_remove_objfile_probes, register_solib_event_probe)
1780         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
1781         (_initialize_svr4_solib): Update.
1782
1783 2019-05-08  Tom Tromey  <tom@tromey.com>
1784
1785         * remote.c (remote_pspace_data): Change type.
1786         (remote_pspace_data_cleanup): Remove.
1787         (get_remote_exec_file, set_pspace_remote_exec_file)
1788         (_initialize_remote): Update.
1789
1790 2019-05-08  Tom Tromey  <tom@tromey.com>
1791
1792         * breakpoint.c (breakpoint_objfile_key): Change type.
1793         (get_breakpoint_objfile_data): Update.
1794         (free_breakpoint_objfile_data): Remove.
1795         (_initialize_breakpoint): Update.
1796
1797 2019-05-08  Tom Tromey  <tom@tromey.com>
1798
1799         * linux-tdep.c (struct linux_info): Add initializers.
1800         (linux_inferior_data): Move.  Change type.
1801         (invalidate_linux_cache_inf): Update.
1802         (linux_inferior_data_cleanup): Remove.
1803         (get_linux_inferior_data, _initialize_linux_tdep): Update.
1804
1805 2019-05-08  Tom Tromey  <tom@tromey.com>
1806
1807         * auxv.c (auxv_inferior_data): Move.  Change type.
1808         (auxv_inferior_data_cleanup): Remove.
1809         (invalidate_auxv_cache_inf): Rewrite.
1810         (get_auxv_inferior_data, _initialize_auxv): Update.
1811
1812 2019-05-08  Tom Tromey  <tom@tromey.com>
1813
1814         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
1815         (symfile_debug_objfile_data_key): Change type.
1816         (symfile_debug_installed, debug_qf_has_symbols)
1817         (debug_qf_find_last_source_symtab)
1818         (debug_qf_forget_cached_source_info)
1819         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
1820         (debug_qf_print_stats, debug_qf_dump)
1821         (debug_qf_expand_symtabs_for_function)
1822         (debug_qf_expand_all_symtabs)
1823         (debug_qf_expand_symtabs_with_fullname)
1824         (debug_qf_map_matching_symbols)
1825         (debug_qf_expand_symtabs_matching)
1826         (debug_qf_find_pc_sect_compunit_symtab)
1827         (debug_qf_map_symbol_filenames)
1828         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
1829         (debug_sym_new_init, debug_sym_init, debug_sym_read)
1830         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
1831         (debug_sym_read_linetable, debug_sym_relocate): Update.
1832         (symfile_debug_free_objfile): Remove.
1833         (install_symfile_debug_logging, _initialize_symfile_debug):
1834         Update.
1835
1836 2019-05-08  Tom Tromey  <tom@tromey.com>
1837
1838         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
1839         allocate_on_obstack.
1840         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
1841         (get_dwarf2_per_objfile): Update.
1842         (set_dwarf2_per_objfile): Remove.
1843         (dwarf2_has_info, dwarf2_get_section_info): Update.
1844         (dwarf2_free_objfile): Remove.
1845         (_initialize_dwarf2_read): Update.
1846
1847 2019-05-08  Tom Tromey  <tom@tromey.com>
1848
1849         * auto-load.c (struct auto_load_pspace_info): Add destructor and
1850         initializers.
1851         <unsupported_script_warning_printed,
1852         script_not_found_warning_printed>: Now bool.
1853         (auto_load_pspace_data): Change type.
1854         (~auto_load_pspace_info): Rename from
1855         auto_load_pspace_data_cleanup.
1856         (get_auto_load_pspace_data, init_loaded_scripts_info)
1857         (clear_section_scripts, maybe_print_unsupported_script_warning)
1858         (maybe_print_script_not_found_warning, _initialize_auto_load):
1859         Update.
1860
1861 2019-05-08  Tom Tromey  <tom@tromey.com>
1862
1863         * objfiles.c (objfile_pspace_info): Add destructor and
1864         initializers.
1865         (objfiles_pspace_data): Change type.
1866         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
1867         (get_objfile_pspace_data): Update.
1868         (objfiles_bfd_data): Change type.
1869         (get_objfile_bfd_data): Update.
1870         (objfile_bfd_data_free, _initialize_objfiles): Remove.
1871
1872 2019-05-08  Tom Tromey  <tom@tromey.com>
1873
1874         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
1875         Change type.
1876         (get_catch_syscall_inferior_data): Update.
1877         (catch_syscall_inferior_data_cleanup): Remove.
1878         (_initialize_break_catch_syscall): Update.
1879
1880 2019-05-08  Tom Tromey  <tom@tromey.com>
1881
1882         * inflow.c (struct terminal_info): Add destructor and
1883         initializers.
1884         (inflow_inferior_data): Change type.
1885         (~terminal_info): Rename from inflow_inferior_data_cleanup.
1886         (get_inflow_inferior_data, inflow_inferior_exit)
1887         (swap_terminal_info, _initialize_inflow): Update.
1888
1889 2019-05-08  Tom Tromey  <tom@tromey.com>
1890
1891         * target-dcache.c (target_dcache_cleanup): Remove.
1892         (target_dcache_aspace_key): Change type.
1893         (target_dcache_init_p, target_dcache_invalidate)
1894         (target_dcache_get, target_dcache_get_or_init)
1895         (_initialize_target_dcache): Update.
1896         * dcache.h (struct dcache_deleter): New.
1897
1898 2019-05-08  Tom Tromey  <tom@tromey.com>
1899
1900         * symtab.c (struct symbol_cache): Add destructor and
1901         initializers.
1902         (symbol_cache_key): Move.  Change type.
1903         (make_symbol_cache, free_symbol_cache): Remove.
1904         (get_symbol_cache): Update.
1905         (symbol_cache_cleanup): Remove.
1906         (ALL_PSPACES, symbol_cache_flush)
1907         (maintenance_print_symbol_cache)
1908         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
1909         Update.
1910
1911 2019-05-08  Tom Tromey  <tom@tromey.com>
1912
1913         * symtab.c (struct main_info): Add destructor and initializers.
1914         (main_progspace_key): Move.  Change type.
1915         (get_main_info): Update.
1916         (main_info_cleanup): Remove.
1917         (_initialize_symtab): Update.
1918
1919 2019-05-08  Tom Tromey  <tom@tromey.com>
1920
1921         * registry.h (DECLARE_REGISTRY): Define the _key class.
1922
1923 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1924
1925         * NEWS: Merge two 'New commands' sections.
1926
1927 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
1928
1929         * ada-valprint.c (ada_val_print_gnat_array): Remove language
1930         parameter and use Ada language definition instead.
1931         (ada_val_print_ptr): Remove unused language parameter.
1932         (ada_val_print_num): Remove language parameter and use Ada language
1933         definition instead.
1934         (ada_val_print_enum, ada_val_print_flt): Remove unused language
1935         parameter.
1936         (ada_val_print_struct_union, ada_val_print_ref): Remove language
1937         parameter and use Ada language definition instead.
1938         (ada_val_print_1): Update all ada_val_print_xxx calls.
1939         Remove language parameter.
1940         (ada_val_print): Update ada_val_print_1 call.
1941
1942 2019-05-08  Tom Tromey  <tromey@adacore.com>
1943
1944         * remote.c (remote_hw_watchpoint_limit)
1945         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
1946         Now static.
1947
1948 2019-05-08  Tom Tromey  <tromey@adacore.com>
1949
1950         * maint.c (_initialize_maint_cmds): Move initialization code to
1951         remote.c.
1952         (watchdog, show_watchdog): Move to remote.c.
1953         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
1954         "watchdog" static.
1955         (_initialize_remote): Move initialization code from maint.c.
1956         * defs.h (watchdog): Don't declare.
1957
1958 2019-05-08  Tom Tromey  <tromey@adacore.com>
1959
1960         * tui/tui-interp.c: Include main.h.
1961         * interps.c: Include main.h.
1962         * main.h (interpreter_p): Declare.
1963         * defs.h (interpreter_p): Don't declare.
1964
1965 2019-05-08  Tom Tromey  <tromey@adacore.com>
1966
1967         * dwarf2loc.c: Include dwarf2read.h.
1968         * defs.h (read_unsigned_leb128): Don't declare.
1969         * dwarf2read.h (read_unsigned_leb128): Declare.
1970
1971 2019-05-08  Tom Tromey  <tromey@adacore.com>
1972
1973         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
1974         method.
1975
1976 2019-05-08  Tom Tromey  <tromey@adacore.com>
1977
1978         * utils.c (fputs_maybe_filtered): Reset style after paging, even
1979         when no wrap column is set.
1980
1981 2019-05-08  Tom Tromey  <tromey@adacore.com>
1982
1983         * c-lang.c (c_get_string): Handle non-C-style arrays.
1984
1985 2019-05-08  Tom Tromey  <tromey@adacore.com>
1986
1987         * typeprint.c (print_offset_data::update): Print the bit offset,
1988         not the number of bits remaining.
1989
1990 2019-05-08  Tom Tromey  <tromey@adacore.com>
1991
1992         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
1993         padding at end of comment.
1994
1995 2019-05-08  Tom Tromey  <tromey@adacore.com>
1996
1997         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
1998         Compare main types.
1999
2000 2019-05-06  Tom Tromey  <tom@tromey.com>
2001
2002         * common/scoped_mmap.c: Include common-defs.h.
2003         * common/scoped_mmap.h: Don't include config.h.
2004
2005 2019-05-04  Tom Tromey  <tom@tromey.com>
2006
2007         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
2008         (struct aarch64_call_info): Add initializers.
2009         <si>: Now a std::vector.
2010         (pass_on_stack, aarch64_push_dummy_call): Update.
2011
2012 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
2013             Tom Tromey  <tom@tromey.com>
2014
2015         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
2016         (ppc_threads): Now a std::vector.  Now static.
2017         (hwdebug_find_thread_points_by_tid)
2018         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
2019         Update.
2020
2021 2019-05-04  Tom Tromey  <tom@tromey.com>
2022
2023         * arc-tdep.c (arc_tdesc_init): Return bool.
2024
2025 2019-05-04  Tom Tromey  <tom@tromey.com>
2026
2027         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
2028         Use gdb_assert_not_reached.
2029
2030 2019-05-04  Tom Tromey  <tom@tromey.com>
2031
2032         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
2033         "false".
2034
2035 2019-05-04  Tom Tromey  <tom@tromey.com>
2036
2037         * arc-tdep.c (arc_tdesc_init): Use bool.
2038
2039 2019-05-04  Tom Tromey  <tom@tromey.com>
2040
2041         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
2042
2043 2019-05-04  Tom Tromey  <tom@tromey.com>
2044
2045         * cli/cli-cmds.c (valid_command_p): Return bool.
2046
2047 2019-05-04  Tom Tromey  <tom@tromey.com>
2048
2049         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
2050         * command.h (valid_user_defined_cmd_name_p): Channge return type.
2051
2052 2019-05-04  Raul Tambre  <raul@tambre.ee>
2053
2054         * python/lib/gdb/prompt.py (_ExtendedPrompt)
2055         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
2056         operator for comparison.
2057
2058 2019-05-04  Tom Tromey  <tom@tromey.com>
2059
2060         * psymtab.c (psymbol_name_matches, match_partial_symbol)
2061         (lookup_partial_symbol, print_partial_symbols)
2062         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
2063         (psymbol_compare): Update.
2064         (add_psymbol_to_bcache): Clear the entire psymbol.
2065         (maintenance_check_psymtabs): Update.
2066         * psympriv.h (struct partial_symbol): Don't derive from
2067         general_symbol_info.
2068         <obj_section, unrelocated_address, address,
2069         set_unrelocated_address>: Update.
2070         <ginfo>: New member.
2071         * dwarf-index-write.c (write_psymbols, debug_names::insert)
2072         (debug_names::write_psymbols): Update.
2073
2074 2019-05-04  Tom de Vries  <tdevries@suse.de>
2075
2076         * contrib/cc-with-tweaks.sh: Support -n arg.
2077
2078 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2079
2080         * corelow.c (core_target::detach): Ensure frame cache and
2081         register caches are cleared.
2082         inferior.c (exit_inferior_1): Likewise.
2083
2084 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
2085             Tom Tromey  <tom@tromey.com>
2086
2087         * dictionary.c (collate_pending_symbols_by_language): Remove
2088         "struct" from foreach.
2089         * symtab.c (lookup_global_symbol_from_objfile)
2090         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
2091         foreach.
2092         * ser-tcp.c (net_open): Remove "struct" from foreach.
2093         * objfiles.c (objfile_relocate, objfile_rebase)
2094         (objfile_has_symbols): Remove "struct" from foreach.
2095         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
2096         from foreach.
2097         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
2098         foreach.
2099         * darwin-nat.c (thread_info_from_private_thread_info): Remove
2100         "struct" from foreach.
2101         * ada-lang.c (create_excep_cond_exprs)
2102         (ada_exception_catchpoint_cond_string): Remove "struct" from
2103         foreach.
2104
2105 2019-05-03  Tom Tromey  <tromey@adacore.com>
2106
2107         * ada-exp.y (convert_char_literal): Check suffix of each
2108         enumerator.
2109
2110 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
2111
2112         PR ada/21406:
2113         * ada-exp.y (yywrap): Don't define.
2114         * ada-lex.l (%option): Add noyywrap
2115         (yywrap): Remove.
2116
2117 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
2118
2119         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
2120         _WIN32_WINNT to the XP level, unless already defined to a higher
2121         level.
2122
2123         * unittests/parse-connection-spec-selftests.c:
2124         * ser-tcp.c:
2125         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
2126         override.
2127
2128         * symfile.c (find_separate_debug_file): Remove colon from the
2129         drive spec of DOS/Windows file names of the target, so that the
2130         file name produced from DEBUGDIR and the target's directory will
2131         be valid on DOS/Windows systems.
2132
2133 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2134
2135         * rust-lang.c (val_print_struct): Handle printing structures
2136         containing strings.
2137
2138 2019-05-02  Tom Tromey  <tromey@adacore.com>
2139
2140         * valarith.c (_initialize_valarith): Remove.
2141
2142 2019-05-01  Tom Tromey  <tromey@adacore.com>
2143
2144         * ada-lang.c (ada_value_primitive_field): Treat more fields as
2145         bitfields.
2146
2147 2019-05-01  Tom Tromey  <tromey@adacore.com>
2148
2149         * ada-lang.c (ada_value_assign): Correctly compute starting offset
2150         for big-endian copies.
2151
2152 2019-04-30  Ali Tamur  <tamur@google.com>
2153         * gdb/dwarf2read.c (read_3_bytes): New declaration.
2154         (read_attribute_value): Added DW_FORM_strx1-4 cases.
2155         (read_3_bytes): New function.
2156
2157 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2158
2159         * windows-nat.c (main_thread_id): Delete.
2160         (handle_output_debug_string): Replace main_thread_id by
2161         current_event.dwThreadId.
2162         (fake_create_process): Likewise.
2163         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
2164         Do not set main_thread_id.
2165         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
2166         current_event.dwThreadId.
2167         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
2168
2169 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2170
2171         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
2172         Use current_event.dwThreadId instead of main_thread_id.
2173
2174 2019-04-30  Tom Tromey  <tromey@adacore.com>
2175
2176         * ada-lang.c (ada_lookup_simple_minsyms): New function.
2177         (create_excep_cond_exprs): Iterate over program spaces.
2178         (ada_exception_catchpoint_cond_string): Examine all minimal
2179         symbols for exception types.
2180
2181 2019-04-30  Tom Tromey  <tromey@adacore.com>
2182
2183         PR c++/24470:
2184         * dwarf2read.c (process_structure_scope): Handle case where type
2185         has template parameters but no symbol was created.
2186
2187 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2188             Chris January  <chris.january@arm.com>
2189
2190         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
2191         qualifier.
2192         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
2193
2194 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2195
2196         * f-typeprint.c (f_print_type): Update rules for printing
2197         whitespace.
2198         (f_type_print_varspec_suffix): Likewise.
2199
2200 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2201             Chris January  <chris.january@arm.com>
2202
2203         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
2204         function arguments.
2205
2206 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2207
2208         * f-lang.c (build_fortran_types): Change name of void type to
2209         lower case.
2210         * f-typeprint.c (f_type_print_base): Print the name of the void
2211         type, rather than a fixed string.
2212         * f-valprint.c (f_decorations): Use lower case void string.
2213
2214 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2215             Chris January  <chris.january@arm.com>
2216
2217         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
2218         types for Fortran.
2219
2220 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2221             Chris January  <chris.january@arm.com>
2222             David Lecomber  <david.lecomber@arm.com>
2223
2224         * f-exp.y (BINOP_INTRINSIC): New token.
2225         (exp): New parser rule handling BINOP_INTRINSIC.
2226         (f77_keywords): Add new builtin procedures.
2227         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
2228         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2229         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
2230         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2231         (print_unop_subexp_f): New function.
2232         (print_binop_subexp_f): New function.
2233         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2234         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2235         (dump_subexp_body_f): Likewise.
2236         (operator_check_f): Likewise.
2237         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2238         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
2239
2240 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2241
2242         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
2243         UNOP_KIND.
2244         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
2245         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
2246         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
2247         (operator_length_f): New fuction.
2248         (print_subexp_f): New function.
2249         (op_name_f): New function.
2250         (dump_subexp_body_f): New function.
2251         (operator_check_f): New function.
2252         (exp_descriptor_f): Replace standard expression handling functions
2253         with new functions.
2254         * gdb/fortran-operator.def: New file.
2255         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
2256         * gdb/std-operator.def: Remove UNOP_KIND.
2257
2258 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2259
2260         * std-operator.def: Remove unbalanced, stray double quote
2261         character.
2262
2263 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2264             Chris January  <chris.january@arm.com>
2265             Daniel Everett  <daniel.everett@arm.com>
2266             Nick Forrington  <nick.forrington@arm.com>
2267             Richard Bunt  <richard.bunt@arm.com>
2268
2269         * cp-valprint.c (cp_print_value_fields): Allow an additional level
2270         of depth when printing anonymous structs or unions.
2271         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
2272         Don't print either the top-level value, or the children if the
2273         max-depth is exceeded.
2274         (ppscm_print_children): When printing the key of a map, allow one
2275         extra level of depth.
2276         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
2277         print either the top-level value, or the children if the max-depth
2278         is exceeded.
2279         (print_children): When printing the key of a map, allow one extra
2280         level of depth.
2281         * python/py-value.c (valpy_format_string): Add max_depth keyword.
2282         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
2283         (user_print_options): Initialise max_depth field.
2284         (val_print_scalar_or_string_type_p): New function.
2285         (val_print): Check to see if the max depth has been reached.
2286         (val_print_check_max_depth): Define new function.
2287         (show_print_max_depth): New function.
2288         (_initialize_valprint): Add 'print max-depth' option.
2289         * valprint.h (struct value_print_options) <max_depth>: New field.
2290         (val_print_check_max_depth): Declare new function.
2291         * NEWS: Document new feature.
2292
2293 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2294
2295         * ada-lang.c (ada_language_defn): Initialise new field.
2296         * c-lang.c (c_is_string_type_p): New function.
2297         (c_language_defn): Initialise new field.
2298         (cplus_language_defn): Initialise new field.
2299         (asm_language_defn): Initialise new field.
2300         (minimal_language_defn): Initialise new field.
2301         * c-lang.h (c_is_string_type_p): Declare new function.
2302         * d-lang.c (d_language_defn): Initialise new field.
2303         * f-lang.c (f_is_string_type_p): New function.
2304         (f_language_defn): Initialise new field.
2305         * go-lang.c (go_is_string_type_p): New function.
2306         (go_language_defn): Initialise new field.
2307         * language.c (default_is_string_type_p): New function.
2308         (unknown_language_defn): Initialise new field.
2309         (auto_language_defn): Initialise new field.
2310         * language.h (struct language_defn) <la_is_string_type_p>: New
2311         member variable.
2312         (default_is_string_type_p): Declare new function.
2313         * m2-lang.c (m2_language_defn): Initialise new field.
2314         * objc-lang.c (objc_language_defn): Initialise new field.
2315         * opencl-lang.c (opencl_language_defn): Initialise new field.
2316         * p-lang.c (pascal_is_string_type_p): New function.
2317         (pascal_language_defn): Initialise new field.
2318         * rust-lang.c (rust_is_string_type_p): New function.
2319         (rust_language_defn): Initialise new field.
2320
2321 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2322
2323         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
2324         New field.
2325         * ada-lang.c (ada_language_defn): Initialise new field.
2326         * c-lang.c (c_language_defn): Likewise.
2327         (cplus_language_defn): Likewise.
2328         (asm_language_defn): Likewise.
2329         (minimal_language_defn): Likewise.
2330         * d-lang.c (d_language_defn): Likewise.
2331         * f-lang.c (f_language_defn): Likewise.
2332         * go-lang.c (go_language_defn): Likewise.
2333         * language.c (unknown_language_defn): Likewise.
2334         (auto_language_defn): Likewise.
2335         * m2-lang.c (m2_language_defn): Likewise.
2336         * objc-lang.c (objc_language_defn): Likewise.
2337         * opencl-lang.c (opencl_language_defn): Likewise.
2338         * p-lang.c (pascal_language_defn): Likewise.
2339         * rust-lang.c (rust_language_defn): Likewise.
2340
2341 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2342
2343         * ada-lang.c (ada_is_character_type): Change return type to bool.
2344         (ada_is_string_type): Likewise.
2345         * ada-lang.h (ada_is_character_type): Update declaration
2346         (ada_is_string_type): Likewise.
2347
2348 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2349
2350         Support style in 'frame|thread apply'
2351
2352         * gdbcmd.h (execute_command_to_string): New term_out parameter.
2353         * record.c (record_start, record_stop): Update callers of
2354         execute_command_to_string with false.
2355         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
2356         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
2357         methods.
2358         (class string_file): New constructor with term_out parameter.
2359         Override methods term_out and can_emit_style_escape.  New member
2360         term_out.
2361         (class stdio_file): Override can_emit_style_escape.
2362         (class tee_file): Override term_out and can_emit_style_escape.
2363         * utils.h (can_emit_style_escape): Remove.
2364         * utils.c (can_emit_style_escape): Likewise.
2365         Update all callers of can_emit_style_escape (SOMESTREAM) to
2366         SOMESTREAM->can_emit_style_escape.
2367         * source-cache.c (source_cache::get_source_lines): Likewise.
2368         * stack.c (frame_apply_command_count): Call execute_command_to_string
2369         passing the term_out characteristic of the current gdb_stdout.
2370         * thread.c (thr_try_catch_cmd): Likewise.
2371         * top.c (execute_command_to_string): pass term_out parameter
2372         to construct the string_file for the command output.
2373         * ui-file.c (term_cli_styling): New function (most code moved
2374         from utils.c can_emit_style_escape).
2375         (string_file::string_file, string_file::can_emit_style_escape,
2376         stdio_file::can_emit_style_escape, tee_file::term_out,
2377         tee_file::can_emit_style_escape): New functions.
2378
2379 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2380
2381         * NEWS: Mention the new set|show may-call-functions.
2382         * infcall.c (may_call_functions_p): New variable.
2383         (show_may_call_functions_p): New function.
2384         (call_function_by_hand_dummy): Throws an error if not
2385         may-call-functions.
2386         (_initialize_infcall): Call add_setshow_boolean_cmd for
2387         may-call-functions.
2388
2389 2019-04-25  Keith Seitz  <keiths@redhat.com>
2390
2391         PR c++/24367
2392         * cp-support.c (inspect_type): Don't attempt substitutions
2393         of symbol with the same name.
2394
2395 2019-04-25  Tom Tromey  <tromey@adacore.com>
2396
2397         PR gdb/24475:
2398         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
2399         static.
2400
2401 2019-04-25  Tom Tromey  <tromey@adacore.com>
2402
2403         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
2404         rvalue reference.
2405         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
2406         (gdb_xml_parser::parse): Use std::move.
2407         * python/python-internal.h (gdbpy_convert_exception): Take a const
2408         reference.
2409         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
2410         std::move.
2411         * python/py-utils.c (gdbpy_convert_exception): Take a const
2412         reference.
2413         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2414         Use std::move.
2415         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2416         Use std::move.
2417         * mi/mi-main.c (mi_print_exception): Take a const reference.
2418         * main.c (handle_command_errors): Take a const reference.
2419         * linespec.c (parse_linespec): Use std::move.
2420         * infcall.c (run_inferior_call): Use std::move.
2421         (call_function_by_hand_dummy): Use std::move.
2422         * exec.c (try_open_exec_file): Use std::move.
2423         * exceptions.h (exception_print, exception_fprintf)
2424         (exception_print_same): Update.
2425         * exceptions.c (print_exception, exception_print)
2426         (exception_fprintf, exception_print_same): Change parameters to
2427         const reference.
2428         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
2429         * common/new-op.c: Use std::move.
2430         * common/common-exceptions.h (struct gdb_exception): Add move
2431         constructor.
2432         (struct gdb_exception_error, struct gdb_exception_quit, struct
2433         gdb_quit_bad_alloc): Change constructor to move constructor.
2434         (throw_exception): Change parameter to rvalue reference.
2435         * common/common-exceptions.c (throw_exception): Take rvalue
2436         reference.
2437         * cli/cli-interp.c (safe_execute_command): Use std::move.
2438         * breakpoint.c (insert_bp_location, location_to_sals): Use
2439         std::move.
2440
2441 2019-04-25  Tom Tromey  <tromey@adacore.com>
2442
2443         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
2444         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
2445         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
2446         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
2447         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
2448         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
2449         guile/scm-value.c: Use unpack.
2450         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
2451         gdbscm_gdb_exception.
2452         (gdbscm_throw_gdb_exception): Likewise.
2453         (struct gdbscm_gdb_exception): New.
2454         (unpack): New function.
2455         (gdbscm_wrap): Use unpack.
2456
2457 2019-04-25  Tom Tromey  <tromey@adacore.com>
2458
2459         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2460         (gdb_rl_callback_handler): Use std::move.
2461         * common/common-exceptions.h (struct gdb_exception): Add move
2462         assignment operator.
2463         (throw_exception_sjlj): Change "exception" to const reference.
2464         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
2465         (throw_exception_sjlj): Change "exception" to const reference.
2466
2467 2019-04-25  Tom Tromey  <tromey@adacore.com>
2468
2469         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
2470         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
2471         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2472         Update.
2473         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2474         Update.
2475         * mi/mi-interp.c (mi_interp::exec): Update.
2476         * linespec.c (parse_linespec): Update.
2477         * infcall.c (run_inferior_call): Update.
2478         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
2479         * guile/scm-symbol.c (gdbscm_lookup_symbol)
2480         (gdbscm_lookup_global_symbol): Update.
2481         * guile/scm-param.c (gdbscm_parameter_value): Update.
2482         * guile/scm-frame.c (gdbscm_frame_read_register)
2483         (gdbscm_frame_read_var): Update.
2484         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
2485         * exec.c (try_open_exec_file): Update.
2486         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2487         (gdb_rl_callback_handler): Update.
2488         * common/common-exceptions.h (exception_none): Don't declare.
2489         * common/common-exceptions.c (exception_none): Don't define.
2490         (struct catcher) <exception>: Update.
2491         * cli/cli-interp.c (safe_execute_command): Update.
2492         * breakpoint.c (insert_bp_location, location_to_sals): Update.
2493
2494 2019-04-25  Ali Tamur  <tamur@google.com>
2495
2496         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
2497         (read_attribute_value): Likewise.
2498         (dwarf2_read_addr_index): Update comment.
2499         (read_str_index): Add DW_FORM_strx.
2500         (dwarf2_string_attr): Likewise.
2501         (dwarf2_const_value_attr): Likewise.
2502         (dump_die_shallow): Likewise.
2503         (dwarf2_fetch_constant_bytes): Likewise.
2504         (skip_form_bytes): Likewise.
2505         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
2506
2507 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
2508
2509         PR corefiles/11608
2510         PR corefiles/18187
2511         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
2512         OFFSET.  Verify if current mapping contains an ELF header.
2513         (linux_find_memory_regions_full): Adjust call to
2514         dump_mapping_p.
2515
2516 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
2517             Kang Li <kanglictf@gmail.com>
2518
2519         PR gdb/21600
2520
2521         * dwarf2-frame.c (read_initial_length): Be consistent about using
2522         unsigned representation of length.
2523         (decode_frame_entry_1): Likewise.  Check for wraparound of
2524         end pointer as well as buffer overflow.
2525
2526 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
2527
2528         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
2529         "vq".
2530
2531 2019-04-24  Tom Tromey  <tromey@adacore.com>
2532
2533         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
2534
2535 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2536
2537         * s12z-tdep.c (s12z_unwind_pc): Delete.
2538         (s12z_unwind_sp): Delete.
2539         (s12z_gdbarch_init): Don't register deleted functions with
2540         gdbarch.
2541
2542 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2543
2544         * rl78-tdep.c (rl78_unwind_sp): Delete.
2545         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
2546
2547 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2548
2549         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
2550         (xstormy16_unwind_pc): Delete.
2551         (xstormy16_dummy_id): Delete.
2552         (xstormy16_gdbarch_init): Don't register deleted functions with
2553         gdbarch.
2554
2555 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2556
2557         * vax-tdep.c (vax_unwind_pc): Delete.
2558         (vax_gdbarch_init): Don't register deleted function with gdbarch.
2559
2560 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2561
2562         * v850-tdep.c (v850_unwind_sp): Delete.
2563         (v850_unwind_pc): Delete.
2564         (v850_dummy_id): Delete.
2565         (v850_gdbarch_init): Don't register deleted functions with
2566         gdbarch.
2567
2568 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2569
2570         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
2571         (tilegx_unwind_pc): Delete.
2572         (tilegx_unwind_dummy_id): Delete.
2573         (tilegx_gdbarch_init): Don't register deleted functions with
2574         gdbarch.
2575
2576 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2577
2578         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
2579         (tic6x_dummy_id): Delete.
2580         (tic6x_gdbarch_init): Don't register deleted functions with
2581         gdbarch.
2582
2583 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2584
2585         * sparc-tdep.c (sparc_unwind_pc): Delete.
2586         (sparc32_gdbarch_init): Don't register deleted function with
2587         gdbarch.
2588
2589 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2590
2591         * sh-tdep.c (sh_unwind_sp): Delete.
2592         (sh_unwind_pc): Delete.
2593         (sh_dummy_id): Delete.
2594         (sh_gdbarch_init): Don't register deleted functions with
2595         gdbarch.
2596
2597 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2598
2599         * score-tdep.c (score_unwind_sp): Delete.
2600         (score_unwind_pc): Delete.
2601         (score_dummy_id): Delete.
2602         (score_gdbarch_init): Don't register deleted functions with
2603         gdbarch.
2604
2605 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2606
2607         * rx-tdep.c (rx_unwind_pc): Delete.
2608         (rx_unwind_sp): Delete.
2609         (rx_dummy_id): Delete.
2610         (rx_gdbarch_init): Don't register deleted functions with
2611         gdbarch.  Update comment.
2612
2613 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2614
2615         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
2616         (rs6000_dummy_id): Delete.
2617         (rs6000_gdbarch_init): Don't register deleted functions with
2618         gdbarch.
2619
2620 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2621
2622         * or1k-tdep.c (or1k_dummy_id): Delete.
2623         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
2624
2625 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2626
2627         * nios2-tdep.c (nios2_dummy_id): Delete.
2628         (nios2_unwind_sp): Delete.
2629         (nios2_gdbarch_init): Don't register deleted functions with
2630         gdbarch.
2631
2632 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2633
2634         * nds32-tdep.c (nds32_dummy_id): Delete.
2635         (nds32_unwind_pc): Delete.
2636         (nds32_unwind_sp): Delete.
2637         (nds32_gdbarch_init): Don't register deleted functions with
2638         gdbarch.
2639
2640 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2641
2642         * msp430-tdep.c (msp430_unwind_pc): Delete.
2643         (msp430_unwind_sp): Delete.
2644         (msp430_dummy_id): Delete.
2645         (msp430_gdbarch_init): Don't register deleted functions with
2646         gdbarch.
2647
2648 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2649
2650         * moxie-tdep.c (moxie_unwind_sp): Delete.
2651         (moxie_unwind_pc): Delete.
2652         (moxie_dummy_id): Delete.
2653         (moxie_gdbarch_init): Don't register deleted functions with
2654         gdbarch.
2655
2656 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2657
2658         * mn10300-tdep.c (mn10300_dummy_id): Delete.
2659         (mn10300_unwind_pc): Delete.
2660         (mn10300_unwind_sp): Delete.
2661         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
2662         mn10300_unwind_sp.
2663         (mn10300_frame_unwind_init): Don't register deleted functions with
2664         gdbarch.
2665
2666 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2667
2668         * mep-tdep.c (mep_unwind_pc): Delete.
2669         (mep_unwind_sp): Delete.
2670         (mep_dummy_id): Delete.
2671         (mep_gdbarch_init): Don't register deleted functions with
2672         gdbarch.
2673
2674 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2675
2676         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
2677         (m68hc11_unwind_sp): Delete.
2678         (m68hc11_gdbarch_init): Don't register deleted functions with
2679         gdbarch.
2680
2681 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2682
2683         * m32r-tdep.c (m32r_unwind_sp): Delete.
2684         (m32r_unwind_pc): Delete.
2685         (m32r_dummy_id): Delete.
2686         (m32r_gdbarch_init): Don't register deleted functions with
2687         gdbarch.
2688
2689 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2690
2691         * m32c-tdep.c (m32c_unwind_pc): Delete.
2692         (m32c_unwind_sp): Delete.
2693         (m32c_dummy_id): Delete.
2694         (m32c_gdbarch_init): Don't register deleted functions with
2695         gdbarch.
2696
2697 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2698
2699         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
2700         (lm32_unwind_pc): Delete.
2701         (lm32_dummy_id): Delete.
2702         (lm32_gdbarch_init): Don't register deleted functions with
2703         gdbarch.
2704
2705 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2706
2707         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
2708         (iq2000_unwind_pc): Delete.
2709         (iq2000_dummy_id): Delete.
2710         (iq2000_gdbarch_init): Don't register deleted functions with
2711         gdbarch.
2712
2713 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2714
2715         * nds32-tdep.c (nds32_type_align): Delete.
2716         (nds32_push_dummy_call): Use type_align instead.
2717
2718 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2719
2720         * arm-tdep.c (arm_type_align): Only handle vector override case.
2721         (arm_push_dummy_call): Use type_align.
2722         (arm_gdbarch_init): Register arm_type_align gdbarch function.
2723
2724 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2725
2726         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
2727         case.
2728         (pass_on_stack): Use type_align.
2729         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
2730         function.
2731
2732 2019-04-23  Tom Tromey  <tromey@adacore.com>
2733
2734         * dwarf2read.c (line_header::file_name_at): Remove unused
2735         overload.
2736
2737 2019-04-23  Tom de Vries  <tdevries@suse.de>
2738
2739         PR gdb/24438
2740         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
2741         invocation.
2742
2743
2744 2019-03-27  Ali Tamur  <tamur@google.com>
2745
2746         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
2747         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
2748         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
2749         (dwarf_expr_context::get_addr_index): Likewise
2750         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
2751         (symbol_needs_eval_context::get_addr_index): Likewise
2752         (disassemble_dwarf_expression): Add DW_OP_addrx
2753         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
2754         (read_cutu_die_from_dwo): Update comment
2755         (skip_one_die): Add DW_FORM_addrx
2756         (read_attribute_value): Likewise
2757         (var_decode_location): Add DW_OP_addrx
2758         (dwarf2_const_value_attr): Add DW_FORM_addrx
2759         (dump_die_shallow): Likewise
2760         (dwarf2_fetch_constant_bytes): Likewise
2761         (decode_locdesc): Add DW_OP_addrx
2762         (skip_form_bytes): Add DW_FORM_addrx
2763
2764 2019-04-22  Ali Tamur  <tamur@google.com>
2765
2766         * MAINTAINERS (Write After Approval): Add self.
2767
2768 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
2769
2770         * solib-svr4.c (get_svr4_info): Add pspace parameter.
2771         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
2772         (open_symbol_file_object): Likewise.
2773         (svr4_default_sos): Add info parameter.
2774         (svr4_read_so_list): Likewise.
2775         (svr4_current_sos_direct): Adjust functions calls to pass down
2776         info.
2777         (svr4_current_sos_1): Add info parameter.
2778         (svr4_current_sos): Call get_svr4_info, pass info down to
2779         svr4_current_sos_1.
2780         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
2781         get_svr4_info.
2782         (svr4_in_dynsym_resolve_code): Pass current_program_space to
2783         get_svr4_info.
2784         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
2785         to get_svr4_info.
2786         (probes_table_remove_objfile_probes): Likewise.
2787         (register_solib_event_probe): Add info parameter.
2788         (solist_update_incremental): Pass info parameter down to
2789         svr4_read_so_list.
2790         (disable_probes_interface): Add info parameter.
2791         (svr4_handle_solib_event): Pass current_program_space to
2792         get_svr4_info.  Adjust disable_probes_interface cleanup.
2793         (svr4_create_probe_breakpoints): Add info parameter, pass it
2794         down to register_solib_event_probe.
2795         (svr4_create_solib_event_breakpoints): Add info parameter,
2796         pass it down to svr4_create_probe_breakpoints.
2797         (enable_break): Pass info down to
2798         svr4_create_solib_event_breakpoints.
2799         (svr4_solib_create_inferior_hook): Pass current_program_space to
2800         get_svr4_info.
2801         (svr4_clear_solib): Likewise.
2802
2803 2019-04-22  Pedro Alves  <palves@redhat.com>
2804
2805         * solib-svr4.c (svr4_free_objfile_observer): New.
2806         (probe_and_action::objfile): New field.
2807         (probes_table_htab_remove_objfile_probes)
2808         (probes_table_remove_objfile_probes): New functions.
2809         (register_solib_event_probe): Add 'objfile' parameter.  Store it
2810         in the new probe_and_action.  Don't store the probe in 'lookup'.
2811         (svr4_create_probe_breakpoints): Pass objfile to
2812         register_solib_event_probe.
2813         (_initialize_svr4_solib): Register a free_objfile observer.
2814
2815 2019-04-19  Tom Tromey  <tom@tromey.com>
2816
2817         * common/queue.h: Remove.
2818
2819 2019-04-19  Tom Tromey  <tom@tromey.com>
2820
2821         * event-loop.c: Don't include "common/queue.h".
2822
2823 2019-04-19  Tom Tromey  <tom@tromey.com>
2824
2825         * remote.c (remote_target): Use delete.
2826         * remote-notif.h: Include <list>, not "common/queue.h".
2827         (notif_client_p): Remove typedef.
2828         (remote_notif_state): Add constructor, destructor, initializer.
2829         <notif_queue>: Now a std::list.
2830         (remote_notif_state_xfree): Don't declare.
2831         * remote-notif.c (remote_notif_process, handle_notification)
2832         (remote_notif_state_allocate): Update.
2833         (~remote_notif_state): Rename from remote_notif_state_xfree.
2834
2835 2019-04-19  Tom Tromey  <tom@tromey.com>
2836
2837         * symfile.c (reread_symbols): Update.
2838         * objfiles.c (objfile_register_static_link)
2839         (objfile_lookup_static_link): Update
2840         (~objfile) Don't delete static_links.
2841         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
2842
2843 2019-04-19  Tom Tromey  <tom@tromey.com>
2844
2845         * type-stack.h (struct type_stack) <insert>: Constify string.
2846         * type-stack.c (type_stack::insert): Constify string.
2847         * gdbtypes.h (lookup_template_type): Update.
2848         (address_space_name_to_int): Update.
2849         * gdbtypes.c (address_space_name_to_int): Make space_identifier
2850         const.
2851         (lookup_template_type): Make name const.
2852         * c-exp.y: Update rules.
2853         (lex_one_token, classify_name, classify_inner_name)
2854         (c_print_token): Update.
2855         * p-exp.y: Update rules.
2856         (yylex): Update.
2857         * f-exp.y: Update rules.
2858         (yylex): Update.
2859         * d-exp.y: Update rules.
2860         (lex_one_token, classify_name, classify_inner_name): Update.
2861         * parse.c (write_dollar_variable, copy_name): Return std::string.
2862         * parser-defs.h (copy_name): Change return type.
2863         * m2-exp.y: Update rules.
2864         (yylex): Update.
2865         * go-exp.y (lex_one_token): Update.
2866         Update rules.
2867         (classify_unsafe_function, classify_packaged_name)
2868         (classify_name, yylex): Update.
2869
2870 2019-04-19  Sergei Trofimovich <siarheit@google.com>
2871
2872         * configure.ac: add --enable-source-highlight switch.
2873         * configure: Regenerate.
2874         * top.c (print_gdb_version): plumb --enable-source-highlight
2875         status to "show configuration".
2876
2877 2019-04-19  Tom Tromey  <tromey@adacore.com>
2878
2879         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
2880         Check ADA_TYPE_P.
2881         (empty_record, ada_template_to_fixed_record_type_1)
2882         (template_to_static_fixed_type)
2883         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
2884         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
2885         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
2886         macros.
2887
2888 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
2889
2890         PR symtab/24423:
2891         * source.c (print_source_lines_base): Advance "iter" when a
2892         control character is seen.
2893
2894 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2895
2896         * inferior.h (struct infcall_suspend_state_deleter):
2897         Catch exception in destructor to avoid crash.
2898
2899 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2900
2901         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
2902         close to the add_com "shell".
2903
2904 2019-04-18  Tom Tromey  <tromey@adacore.com>
2905
2906         * process-stratum-target.h (class process_stratum_target)
2907         <stratum>: Add "final".
2908
2909 2019-04-17  Tom Tromey  <tromey@adacore.com>
2910
2911         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
2912         against nullptr before use.
2913
2914 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
2915
2916         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
2917
2918 2019-04-17  Jim Wilson  <jimw@sifive.com>
2919             Andrew Burgess  <andrew.burgess@embecosm.com>
2920
2921         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
2922         code read might fail, assume 4-byte breakpoint in that case.
2923
2924 2019-04-15  Leszek Swirski  <leszeks@google.com>
2925
2926         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
2927         rather than a hand-rolled POD check when checking for forced MEMORY
2928         classification.
2929
2930 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2931
2932         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
2933         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
2934         function.
2935         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
2936         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
2937         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
2938         declaration.
2939
2940 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2941
2942         * aarch64-linux-nat.c
2943         (aarch64_linux_nat_target::thread_architecture): Add override.
2944         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
2945         each VQ.
2946
2947 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2948
2949         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
2950
2951 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2952
2953         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
2954         target types of size 96-bits, add some additional comments, and
2955         check that the builtin type we found was the correct size.
2956
2957 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
2958
2959         * utils.c (prompt_for_continue): Don't restore the styling at the
2960         end, as applied_style has the wrong value.  This fixes styling in
2961         long lists of file names that are interrupted by the "Continue?"
2962         prompt.
2963
2964 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2965
2966         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
2967         * c-lang.c (c_language_defn): Likewise.
2968         (cplus_language_defn): Likewise.
2969         (asm_language_defn): Likewise.
2970         (minimal_language_defn): Likewise.
2971         * d-lang.c (d_language_defn): Likewise.
2972         * f-lang.c (f_language_defn): Likewise.
2973         * go-lang.c (go_language_defn): Likewise.
2974         * language.c (unknown_language_defn): Likewise.
2975         (auto_language_defn): Likewise.
2976         * language.h (struct language_defn): Remove la_magic field.
2977         (LANG_MAGIC): Delete.
2978         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
2979         * objc-lang.c (objc_language_defn): Likewise.
2980         * opencl-lang.c (opencl_language_defn): Likewise.
2981         * p-lang.c (pascal_language_defn): Likewise.
2982         * rust-lang.c (rust_language_defn): Likewise.
2983
2984 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2985
2986         * riscv-tdep.c (riscv_type_align): New function.
2987         (riscv_type_alignment): Delete.
2988         (riscv_arg_location): Use 'type_align'.
2989         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
2990
2991 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2992
2993         * gdbtypes.c (type_align): A struct with no non-static fields also
2994         has alignment of 1.
2995
2996 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2997
2998         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
2999         component to 0.
3000         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
3001         member.
3002         (riscv_struct_info::analyse): New implementation using new
3003         analyse_inner member function.
3004         (riscv_struct_info::field_offset): New member function.
3005         (riscv_struct_info::m_offsets): New member variable.
3006         (riscv_struct_info::analyse_inner): New private member function,
3007         takes the old implementation of riscv_struct_info::analyse but
3008         extended to track field offsets.
3009         (riscv_call_arg_struct): Update the struct folding special cases
3010         to handle cases where empty C++ structs, which are non-zero
3011         length, are found.
3012         (riscv_arg_location): Initialise the length of each location, a
3013         non-zero length now indicates the location is in use.
3014         (riscv_push_dummy_call): Allow for the first location having a
3015         non-zero offset when setting up arguments.
3016         (riscv_return_value): Likewise, but for return values.
3017
3018 2019-04-11  Tom Tromey  <tromey@adacore.com>
3019
3020         * utils.c (internal_vproblem): Make "msg" const.
3021
3022 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
3023
3024         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
3025         * trad-frame.c (trad_frame_reset_saved_regs): New function.
3026         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
3027         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
3028
3029 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
3030
3031         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
3032         function.
3033         (fill_gregset): Call amd64_linux_collect_native_gregset instead
3034         of amd64_collect_native_gregset.
3035         (amd64_linux_nat_target::store_registers): Likewise.
3036
3037 2019-04-10  Tom Tromey  <tom@tromey.com>
3038
3039         * symtab.c (lookup_global_symbol_from_objfile)
3040         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
3041         * objfiles.h (class separate_debug_iterator): New.
3042         (class separate_debug_range): New.
3043         (struct objfile) <separate_debug_objfiles>: New method.
3044         (objfile_separate_debug_iterate): Don't declare.
3045         * objfiles.c (separate_debug_iterator::operator++): Rename from
3046         objfile_separate_debug_iterate.
3047         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
3048         iterator.
3049         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
3050         iterator.
3051
3052 2019-04-10  Tom Tromey  <tom@tromey.com>
3053
3054         * symfile.c (reread_symbols): Remove old comment.
3055         * objfiles.c (free_all_objfiles): Fix a typo.
3056
3057 2019-04-10  Tom Tromey  <tom@tromey.com>
3058
3059         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
3060         * minsyms.c (lookup_minimal_symbol): Use foreach.
3061         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
3062         (lookup_minimal_symbol_solib_trampoline): Likewise.
3063         * symfile.c (reread_symbols): Use foreach.
3064
3065 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
3066             Tom Tromey  <tromey@adacore.com>
3067
3068         PR rust/24414:
3069         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
3070         (rust_lex_int_test): Change "value" to be LONGEST.
3071         (rust_lex_tests): Add test for long integer literal.
3072
3073 2019-04-09  Tom Tromey  <tromey@adacore.com>
3074
3075         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
3076         to bool.
3077         (extended_remote_target::attach): Update.
3078         (remote_target::remote_notice_new_inferior): Update.
3079         (remote_target::add_current_inferior_and_thread): Update.
3080         * inferior.c (exit_inferior_1): Use "false".
3081         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
3082
3083 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
3084
3085         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
3086         the "start" command.
3087
3088 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3089
3090         * python/py-inferior.c (infpy_thread_from_thread_handle):
3091         Adjust comments to reflect renaming of thread_from_thread_handle
3092         to thread_from_handle.  Adjust keywords.  Fix type error message.
3093         (inferior_object_methods): Add thread_from_handle.  Retain
3094         thread_from_thread_handle, but mark it as deprecated.
3095
3096 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3097
3098         * gdbthread.h (find_thread_by_handle): Revise declaration.
3099         * thread.c (find_thread_by_handle): Likewise.  Adjust
3100         implementation too.
3101         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
3102         support for buffer objects as handles.
3103
3104 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3105
3106         * python/py-infthread.c (thpy_thread_handle): New function.
3107         (thread_object_methods): Register thpy_thread_handle.
3108
3109 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3110
3111         * gdbthread.h (thread_to_thread_handle): Declare.
3112         * thread.c (gdbtypes.h): Include.
3113         (thread_to_thread_handle): New function.
3114
3115         * target.h (struct target_ops): Add thread_info_to_thread_handle.
3116         (target_thread_info_to_thread_handle): Declare.
3117         * target.c (target_thread_info_to_thread_handle): New function.
3118         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
3119         * target-delegates.c: Regenerate.
3120
3121         * linux-thread-db.c (class thread_db_target): Add method
3122         thread_info_to_thread_handle.
3123         (thread_db_target::thread_info_to_thread_handle): Define.
3124         * remote.c (class remote_target): Add new method
3125         thread_info_to_thread_handle.
3126         (remote_target::thread_info_to_thread_handle): Define.
3127
3128 2019-04-08  Pedro Alves  <palves@redhat.com>
3129
3130         * common/common-exceptions.c (throw_exception): Don't create
3131         named object to throw; throw directly.
3132         (throw_it): Likewise.  Don't initialize gdb_exception::message
3133         here, with new; pass FMT and AP to the ctor instead.
3134         * common/common-exceptions.h: Include <string>.
3135         (gdb_exception::gdb_exception(enum return_reason, enum errors,
3136         const char *, va_list)): New ctor.  Use std::make_shared.
3137         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
3138         errors)): Delete.
3139         (gdb_exception_error::gdb_exception_error(enum errors, const char
3140         *, va_list)): New.
3141         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
3142         Add assertion.
3143         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
3144         errors)): Delete.
3145         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
3146         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
3147         Add assertion.
3148
3149 2019-04-08  Tom Tromey  <tom@tromey.com>
3150
3151         * valops.c (value_rtti_indirect_type): Replace throw_exception
3152         with throw.
3153         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
3154         with throw.
3155         * thread.c (thr_try_catch_cmd): Replace throw_exception with
3156         throw.
3157         * target.c (target_translate_tls_address): Replace throw_exception
3158         with throw.
3159         * stack.c (frame_apply_command_count): Replace throw_exception
3160         with throw.
3161         * solib-spu.c (append_ocl_sos): Replace throw_exception with
3162         throw.
3163         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
3164         with throw.
3165         * rs6000-tdep.c (rs6000_frame_cache)
3166         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
3167         * remote.c: Replace throw_exception with throw.
3168         * record-full.c (record_full_message, record_full_wait_1)
3169         (record_full_restore): Replace throw_exception with throw.
3170         * record-btrace.c:
3171         (get_thread_current_frame_id, record_btrace_start_replaying)
3172         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
3173         (cmd_record_btrace_start): Replace throw_exception with throw.
3174         * parse.c (parse_exp_in_context_1): Replace throw_exception with
3175         throw.
3176         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
3177         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
3178         * linespec.c:
3179         (find_linespec_symbols): Replace throw_exception with throw.
3180         * infrun.c (displaced_step_prepare, resume): Replace
3181         throw_exception with throw.
3182         * infcmd.c (post_create_inferior): Replace throw_exception with
3183         throw.
3184         * inf-loop.c (inferior_event_handler): Replace throw_exception
3185         with throw.
3186         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
3187         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
3188         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
3189         (get_prev_frame_always, get_frame_pc_if_available)
3190         (get_frame_address_in_block_if_available, get_frame_language):
3191         Replace throw_exception with throw.
3192         * frame-unwind.c (frame_unwind_try_unwinder): Replace
3193         throw_exception with throw.
3194         * eval.c (fetch_subexp_value, evaluate_var_value)
3195         (evaluate_funcall, evaluate_subexp_standard): Replace
3196         throw_exception with throw.
3197         * dwarf2loc.c (call_site_find_chain)
3198         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
3199         Replace throw_exception with throw.
3200         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
3201         with throw.
3202         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
3203         throw.
3204         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
3205         * completer.c (complete_line_internal): Replace throw_exception
3206         with throw.
3207         * compile/compile-object-run.c (compile_object_run): Replace
3208         throw_exception with throw.
3209         * cli/cli-script.c (process_next_line): Replace throw_exception
3210         with throw.
3211         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
3212         (btrace_enable, btrace_maint_update_pt_packets): Replace
3213         throw_exception with throw.
3214         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
3215         throw_exception with throw.
3216         * break-catch-throw.c (re_set_exception_catchpoint): Replace
3217         throw_exception with throw.
3218         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
3219         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
3220         * aarch64-tdep.c (aarch64_make_prologue_cache)
3221         (aarch64_make_stub_cache): Replace throw_exception with throw.
3222
3223 2019-04-08  Tom Tromey  <tom@tromey.com>
3224
3225         * common/common-exceptions.c (throw_exception): Rename from
3226         throw_exception_cxx.  Remove old copy.  Make argument const.
3227         (throw_it): Create and throw exception objects directly.
3228         * common/common-exceptions.h (throw_exception): Make argument
3229         const.
3230         (struct gdb_exception_error): Add constructor.
3231         (struct gdb_exception_quit): Add constructor.
3232
3233 2019-04-08  Tom Tromey  <tom@tromey.com>
3234
3235         * common/common-exceptions.h (exception_rethrow): Don't declare.
3236         (TRY_SJLJ): Update comment.
3237         (TRY, CATCH, END_CATCH): Remove.
3238         * common/common-exceptions.c (exception_rethrow): Remove.
3239
3240 2019-04-08  Tom Tromey  <tom@tromey.com>
3241
3242         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
3243         Remove.
3244         (gdb_exception_error): Rename from
3245         gdb_exception_RETURN_MASK_ERROR.
3246         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
3247         (gdb_quit_bad_alloc): Update.
3248         * aarch64-tdep.c: Update.
3249         * ada-lang.c: Update.
3250         * ada-typeprint.c: Update.
3251         * ada-valprint.c: Update.
3252         * amd64-tdep.c: Update.
3253         * arch-utils.c: Update.
3254         * break-catch-throw.c: Update.
3255         * breakpoint.c: Update.
3256         * btrace.c: Update.
3257         * c-varobj.c: Update.
3258         * cli/cli-cmds.c: Update.
3259         * cli/cli-interp.c: Update.
3260         * cli/cli-script.c: Update.
3261         * common/common-exceptions.c: Update.
3262         * common/new-op.c: Update.
3263         * common/selftest.c: Update.
3264         * compile/compile-c-symbols.c: Update.
3265         * compile/compile-cplus-symbols.c: Update.
3266         * compile/compile-object-load.c: Update.
3267         * compile/compile-object-run.c: Update.
3268         * completer.c: Update.
3269         * corelow.c: Update.
3270         * cp-abi.c: Update.
3271         * cp-support.c: Update.
3272         * cp-valprint.c: Update.
3273         * darwin-nat.c: Update.
3274         * disasm-selftests.c: Update.
3275         * dtrace-probe.c: Update.
3276         * dwarf-index-cache.c: Update.
3277         * dwarf-index-write.c: Update.
3278         * dwarf2-frame-tailcall.c: Update.
3279         * dwarf2-frame.c: Update.
3280         * dwarf2loc.c: Update.
3281         * dwarf2read.c: Update.
3282         * eval.c: Update.
3283         * event-loop.c: Update.
3284         * event-top.c: Update.
3285         * exec.c: Update.
3286         * f-valprint.c: Update.
3287         * fbsd-tdep.c: Update.
3288         * frame-unwind.c: Update.
3289         * frame.c: Update.
3290         * gdbtypes.c: Update.
3291         * gnu-v3-abi.c: Update.
3292         * guile/guile-internal.h: Update.
3293         * guile/scm-block.c: Update.
3294         * guile/scm-breakpoint.c: Update.
3295         * guile/scm-cmd.c: Update.
3296         * guile/scm-disasm.c: Update.
3297         * guile/scm-frame.c: Update.
3298         * guile/scm-lazy-string.c: Update.
3299         * guile/scm-math.c: Update.
3300         * guile/scm-param.c: Update.
3301         * guile/scm-ports.c: Update.
3302         * guile/scm-pretty-print.c: Update.
3303         * guile/scm-symbol.c: Update.
3304         * guile/scm-symtab.c: Update.
3305         * guile/scm-type.c: Update.
3306         * guile/scm-value.c: Update.
3307         * i386-linux-tdep.c: Update.
3308         * i386-tdep.c: Update.
3309         * inf-loop.c: Update.
3310         * infcall.c: Update.
3311         * infcmd.c: Update.
3312         * infrun.c: Update.
3313         * jit.c: Update.
3314         * language.c: Update.
3315         * linespec.c: Update.
3316         * linux-fork.c: Update.
3317         * linux-nat.c: Update.
3318         * linux-tdep.c: Update.
3319         * linux-thread-db.c: Update.
3320         * main.c: Update.
3321         * mi/mi-cmd-break.c: Update.
3322         * mi/mi-cmd-stack.c: Update.
3323         * mi/mi-interp.c: Update.
3324         * mi/mi-main.c: Update.
3325         * objc-lang.c: Update.
3326         * p-valprint.c: Update.
3327         * parse.c: Update.
3328         * ppc-linux-tdep.c: Update.
3329         * printcmd.c: Update.
3330         * python/py-arch.c: Update.
3331         * python/py-breakpoint.c: Update.
3332         * python/py-cmd.c: Update.
3333         * python/py-finishbreakpoint.c: Update.
3334         * python/py-frame.c: Update.
3335         * python/py-framefilter.c: Update.
3336         * python/py-gdb-readline.c: Update.
3337         * python/py-inferior.c: Update.
3338         * python/py-infthread.c: Update.
3339         * python/py-lazy-string.c: Update.
3340         * python/py-linetable.c: Update.
3341         * python/py-objfile.c: Update.
3342         * python/py-param.c: Update.
3343         * python/py-prettyprint.c: Update.
3344         * python/py-progspace.c: Update.
3345         * python/py-record-btrace.c: Update.
3346         * python/py-record.c: Update.
3347         * python/py-symbol.c: Update.
3348         * python/py-type.c: Update.
3349         * python/py-unwind.c: Update.
3350         * python/py-utils.c: Update.
3351         * python/py-value.c: Update.
3352         * python/python.c: Update.
3353         * record-btrace.c: Update.
3354         * record-full.c: Update.
3355         * remote-fileio.c: Update.
3356         * remote.c: Update.
3357         * riscv-tdep.c: Update.
3358         * rs6000-aix-tdep.c: Update.
3359         * rs6000-tdep.c: Update.
3360         * rust-exp.y: Update.
3361         * rust-lang.c: Update.
3362         * s390-tdep.c: Update.
3363         * selftest-arch.c: Update.
3364         * solib-dsbt.c: Update.
3365         * solib-frv.c: Update.
3366         * solib-spu.c: Update.
3367         * solib-svr4.c: Update.
3368         * solib.c: Update.
3369         * sparc64-linux-tdep.c: Update.
3370         * stack.c: Update.
3371         * symfile-mem.c: Update.
3372         * symmisc.c: Update.
3373         * target.c: Update.
3374         * thread.c: Update.
3375         * top.c: Update.
3376         * tracefile-tfile.c: Update.
3377         * tui/tui.c: Update.
3378         * typeprint.c: Update.
3379         * unittests/cli-utils-selftests.c: Update.
3380         * unittests/parse-connection-spec-selftests.c: Update.
3381         * valops.c: Update.
3382         * valprint.c: Update.
3383         * value.c: Update.
3384         * varobj.c: Update.
3385         * windows-nat.c: Update.
3386         * x86-linux-nat.c: Update.
3387         * xml-support.c: Update.
3388
3389 2019-04-08  Tom Tromey  <tom@tromey.com>
3390
3391         * xml-support.c: Use C++ exception handling.
3392         * x86-linux-nat.c: Use C++ exception handling.
3393         * windows-nat.c: Use C++ exception handling.
3394         * varobj.c: Use C++ exception handling.
3395         * value.c: Use C++ exception handling.
3396         * valprint.c: Use C++ exception handling.
3397         * valops.c: Use C++ exception handling.
3398         * unittests/parse-connection-spec-selftests.c: Use C++ exception
3399         handling.
3400         * unittests/cli-utils-selftests.c: Use C++ exception handling.
3401         * typeprint.c: Use C++ exception handling.
3402         * tui/tui.c: Use C++ exception handling.
3403         * tracefile-tfile.c: Use C++ exception handling.
3404         * top.c: Use C++ exception handling.
3405         * thread.c: Use C++ exception handling.
3406         * target.c: Use C++ exception handling.
3407         * symmisc.c: Use C++ exception handling.
3408         * symfile-mem.c: Use C++ exception handling.
3409         * stack.c: Use C++ exception handling.
3410         * sparc64-linux-tdep.c: Use C++ exception handling.
3411         * solib.c: Use C++ exception handling.
3412         * solib-svr4.c: Use C++ exception handling.
3413         * solib-spu.c: Use C++ exception handling.
3414         * solib-frv.c: Use C++ exception handling.
3415         * solib-dsbt.c: Use C++ exception handling.
3416         * selftest-arch.c: Use C++ exception handling.
3417         * s390-tdep.c: Use C++ exception handling.
3418         * rust-lang.c: Use C++ exception handling.
3419         * rust-exp.y: Use C++ exception handling.
3420         * rs6000-tdep.c: Use C++ exception handling.
3421         * rs6000-aix-tdep.c: Use C++ exception handling.
3422         * riscv-tdep.c: Use C++ exception handling.
3423         * remote.c: Use C++ exception handling.
3424         * remote-fileio.c: Use C++ exception handling.
3425         * record-full.c: Use C++ exception handling.
3426         * record-btrace.c: Use C++ exception handling.
3427         * python/python.c: Use C++ exception handling.
3428         * python/py-value.c: Use C++ exception handling.
3429         * python/py-utils.c: Use C++ exception handling.
3430         * python/py-unwind.c: Use C++ exception handling.
3431         * python/py-type.c: Use C++ exception handling.
3432         * python/py-symbol.c: Use C++ exception handling.
3433         * python/py-record.c: Use C++ exception handling.
3434         * python/py-record-btrace.c: Use C++ exception handling.
3435         * python/py-progspace.c: Use C++ exception handling.
3436         * python/py-prettyprint.c: Use C++ exception handling.
3437         * python/py-param.c: Use C++ exception handling.
3438         * python/py-objfile.c: Use C++ exception handling.
3439         * python/py-linetable.c: Use C++ exception handling.
3440         * python/py-lazy-string.c: Use C++ exception handling.
3441         * python/py-infthread.c: Use C++ exception handling.
3442         * python/py-inferior.c: Use C++ exception handling.
3443         * python/py-gdb-readline.c: Use C++ exception handling.
3444         * python/py-framefilter.c: Use C++ exception handling.
3445         * python/py-frame.c: Use C++ exception handling.
3446         * python/py-finishbreakpoint.c: Use C++ exception handling.
3447         * python/py-cmd.c: Use C++ exception handling.
3448         * python/py-breakpoint.c: Use C++ exception handling.
3449         * python/py-arch.c: Use C++ exception handling.
3450         * printcmd.c: Use C++ exception handling.
3451         * ppc-linux-tdep.c: Use C++ exception handling.
3452         * parse.c: Use C++ exception handling.
3453         * p-valprint.c: Use C++ exception handling.
3454         * objc-lang.c: Use C++ exception handling.
3455         * mi/mi-main.c: Use C++ exception handling.
3456         * mi/mi-interp.c: Use C++ exception handling.
3457         * mi/mi-cmd-stack.c: Use C++ exception handling.
3458         * mi/mi-cmd-break.c: Use C++ exception handling.
3459         * main.c: Use C++ exception handling.
3460         * linux-thread-db.c: Use C++ exception handling.
3461         * linux-tdep.c: Use C++ exception handling.
3462         * linux-nat.c: Use C++ exception handling.
3463         * linux-fork.c: Use C++ exception handling.
3464         * linespec.c: Use C++ exception handling.
3465         * language.c: Use C++ exception handling.
3466         * jit.c: Use C++ exception handling.
3467         * infrun.c: Use C++ exception handling.
3468         * infcmd.c: Use C++ exception handling.
3469         * infcall.c: Use C++ exception handling.
3470         * inf-loop.c: Use C++ exception handling.
3471         * i386-tdep.c: Use C++ exception handling.
3472         * i386-linux-tdep.c: Use C++ exception handling.
3473         * guile/scm-value.c: Use C++ exception handling.
3474         * guile/scm-type.c: Use C++ exception handling.
3475         * guile/scm-symtab.c: Use C++ exception handling.
3476         * guile/scm-symbol.c: Use C++ exception handling.
3477         * guile/scm-pretty-print.c: Use C++ exception handling.
3478         * guile/scm-ports.c: Use C++ exception handling.
3479         * guile/scm-param.c: Use C++ exception handling.
3480         * guile/scm-math.c: Use C++ exception handling.
3481         * guile/scm-lazy-string.c: Use C++ exception handling.
3482         * guile/scm-frame.c: Use C++ exception handling.
3483         * guile/scm-disasm.c: Use C++ exception handling.
3484         * guile/scm-cmd.c: Use C++ exception handling.
3485         * guile/scm-breakpoint.c: Use C++ exception handling.
3486         * guile/scm-block.c: Use C++ exception handling.
3487         * guile/guile-internal.h: Use C++ exception handling.
3488         * gnu-v3-abi.c: Use C++ exception handling.
3489         * gdbtypes.c: Use C++ exception handling.
3490         * frame.c: Use C++ exception handling.
3491         * frame-unwind.c: Use C++ exception handling.
3492         * fbsd-tdep.c: Use C++ exception handling.
3493         * f-valprint.c: Use C++ exception handling.
3494         * exec.c: Use C++ exception handling.
3495         * event-top.c: Use C++ exception handling.
3496         * event-loop.c: Use C++ exception handling.
3497         * eval.c: Use C++ exception handling.
3498         * dwarf2read.c: Use C++ exception handling.
3499         * dwarf2loc.c: Use C++ exception handling.
3500         * dwarf2-frame.c: Use C++ exception handling.
3501         * dwarf2-frame-tailcall.c: Use C++ exception handling.
3502         * dwarf-index-write.c: Use C++ exception handling.
3503         * dwarf-index-cache.c: Use C++ exception handling.
3504         * dtrace-probe.c: Use C++ exception handling.
3505         * disasm-selftests.c: Use C++ exception handling.
3506         * darwin-nat.c: Use C++ exception handling.
3507         * cp-valprint.c: Use C++ exception handling.
3508         * cp-support.c: Use C++ exception handling.
3509         * cp-abi.c: Use C++ exception handling.
3510         * corelow.c: Use C++ exception handling.
3511         * completer.c: Use C++ exception handling.
3512         * compile/compile-object-run.c: Use C++ exception handling.
3513         * compile/compile-object-load.c: Use C++ exception handling.
3514         * compile/compile-cplus-symbols.c: Use C++ exception handling.
3515         * compile/compile-c-symbols.c: Use C++ exception handling.
3516         * common/selftest.c: Use C++ exception handling.
3517         * common/new-op.c: Use C++ exception handling.
3518         * cli/cli-script.c: Use C++ exception handling.
3519         * cli/cli-interp.c: Use C++ exception handling.
3520         * cli/cli-cmds.c: Use C++ exception handling.
3521         * c-varobj.c: Use C++ exception handling.
3522         * btrace.c: Use C++ exception handling.
3523         * breakpoint.c: Use C++ exception handling.
3524         * break-catch-throw.c: Use C++ exception handling.
3525         * arch-utils.c: Use C++ exception handling.
3526         * amd64-tdep.c: Use C++ exception handling.
3527         * ada-valprint.c: Use C++ exception handling.
3528         * ada-typeprint.c: Use C++ exception handling.
3529         * ada-lang.c: Use C++ exception handling.
3530         * aarch64-tdep.c: Use C++ exception handling.
3531
3532 2019-04-08  Tom Tromey  <tom@tromey.com>
3533
3534         * xml-support.c (gdb_xml_parser::parse): Update.
3535         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3536         * value.c (show_convenience): Update.
3537         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
3538         (test_parse_flags_qcs): Update.
3539         * thread.c (thr_try_catch_cmd): Update.
3540         * target.c (target_translate_tls_address): Update.
3541         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3542         (info_frame_command_core, frame_apply_command_count): Update.
3543         * rust-exp.y (rust_lex_exception_test): Update.
3544         * riscv-tdep.c (riscv_print_one_register_info): Update.
3545         * remote.c (remote_target::enable_btrace): Update.
3546         * record-btrace.c (record_btrace_enable_warn): Update.
3547         * python/py-utils.c (gdbpy_convert_exception): Update.
3548         * printcmd.c (do_one_display, print_variable_and_value): Update.
3549         * mi/mi-main.c (mi_print_exception): Update.
3550         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
3551         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3552         * linux-nat.c (linux_nat_target::attach): Update.
3553         * linux-fork.c (class scoped_switch_fork_info): Update.
3554         * infrun.c (displaced_step_prepare): Update.
3555         * infcall.c (call_function_by_hand_dummy): Update.
3556         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
3557         * gnu-v3-abi.c (print_one_vtable): Update.
3558         * frame.c (get_prev_frame_always): Update.
3559         * f-valprint.c (info_common_command_for_block): Update.
3560         * exec.c (try_open_exec_file): Update.
3561         * exceptions.c (print_exception, exception_print)
3562         (exception_fprintf, exception_print_same): Update.
3563         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
3564         * dwarf-index-cache.c (index_cache::store)
3565         (index_cache::lookup_gdb_index): Update.
3566         * darwin-nat.c (maybe_cache_shell): Update.
3567         * cp-valprint.c (cp_print_value_fields): Update.
3568         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
3569         (gcc_cplus_symbol_address): Update.
3570         * compile/compile-c-symbols.c (gcc_convert_symbol)
3571         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
3572         * common/selftest.c: Update.
3573         * common/common-exceptions.h (struct gdb_exception) <message>: Now
3574         a std::string.
3575         (exception_try_scope_entry, exception_try_scope_exit): Don't
3576         declare.
3577         (struct exception_try_scope): Remove.
3578         (TRY): Don't use exception_try_scope.
3579         (struct gdb_exception): Add constructor, operator=.
3580         <what>: New method.
3581         (struct gdb_exception_RETURN_MASK_ALL)
3582         (struct gdb_exception_RETURN_MASK_ERROR)
3583         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
3584         (struct gdb_quit_bad_alloc): Update.
3585         * common/common-exceptions.c (exception_none): Change
3586         initializer.
3587         (struct catcher) <state, exception>: Initialize inline.
3588         <prev>: Remove member.
3589         (current_catcher): Remove.
3590         (catchers): New global.
3591         (exceptions_state_mc_init): Simplify.
3592         (catcher_pop): Remove.
3593         (exceptions_state_mc, exceptions_state_mc_catch): Update.
3594         (try_scope_depth, exception_try_scope_entry)
3595         (exception_try_scope_exit): Remove.
3596         (throw_exception_sjlj): Update.
3597         (exception_messages, exception_messages_size): Remove.
3598         (throw_it): Simplify.
3599         (gdb_exception_sliced_copy): Remove.
3600         (throw_exception_cxx): Update.
3601         * cli/cli-script.c (script_from_file): Update.
3602         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
3603         Update.
3604         * ada-valprint.c (ada_val_print): Update.
3605         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
3606         (create_excep_cond_exprs): Update.
3607
3608 2019-04-08  Tom Tromey  <tom@tromey.com>
3609
3610         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
3611         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
3612         (TRY, CATCH, END_CATCH): Remove some definitions.
3613         * common/common-exceptions.c: Don't use GDB_XCPT.
3614         (catcher_list_size): Remove.
3615         (throw_exception, throw_it): Simplify.
3616
3617 2019-04-05  Tom Tromey  <tom@tromey.com>
3618
3619         Revert the header-sorting patch.
3620         * ft32-tdep.c: Revert.
3621         * frv-tdep.c: Revert.
3622         * frv-linux-tdep.c: Revert.
3623         * frame.c: Revert.
3624         * frame-unwind.c: Revert.
3625         * frame-base.c: Revert.
3626         * fork-child.c: Revert.
3627         * findvar.c: Revert.
3628         * findcmd.c: Revert.
3629         * filesystem.c: Revert.
3630         * filename-seen-cache.h: Revert.
3631         * filename-seen-cache.c: Revert.
3632         * fbsd-tdep.c: Revert.
3633         * fbsd-nat.h: Revert.
3634         * fbsd-nat.c: Revert.
3635         * f-valprint.c: Revert.
3636         * f-typeprint.c: Revert.
3637         * f-lang.c: Revert.
3638         * extension.h: Revert.
3639         * extension.c: Revert.
3640         * extension-priv.h: Revert.
3641         * expprint.c: Revert.
3642         * exec.h: Revert.
3643         * exec.c: Revert.
3644         * exceptions.c: Revert.
3645         * event-top.c: Revert.
3646         * event-loop.c: Revert.
3647         * eval.c: Revert.
3648         * elfread.c: Revert.
3649         * dwarf2read.h: Revert.
3650         * dwarf2read.c: Revert.
3651         * dwarf2loc.c: Revert.
3652         * dwarf2expr.h: Revert.
3653         * dwarf2expr.c: Revert.
3654         * dwarf2-frame.c: Revert.
3655         * dwarf2-frame-tailcall.c: Revert.
3656         * dwarf-index-write.h: Revert.
3657         * dwarf-index-write.c: Revert.
3658         * dwarf-index-common.c: Revert.
3659         * dwarf-index-cache.h: Revert.
3660         * dwarf-index-cache.c: Revert.
3661         * dummy-frame.c: Revert.
3662         * dtrace-probe.c: Revert.
3663         * disasm.h: Revert.
3664         * disasm.c: Revert.
3665         * disasm-selftests.c: Revert.
3666         * dictionary.c: Revert.
3667         * dicos-tdep.c: Revert.
3668         * demangle.c: Revert.
3669         * dcache.h: Revert.
3670         * dcache.c: Revert.
3671         * darwin-nat.h: Revert.
3672         * darwin-nat.c: Revert.
3673         * darwin-nat-info.c: Revert.
3674         * d-valprint.c: Revert.
3675         * d-namespace.c: Revert.
3676         * d-lang.c: Revert.
3677         * ctf.c: Revert.
3678         * csky-tdep.c: Revert.
3679         * csky-linux-tdep.c: Revert.
3680         * cris-tdep.c: Revert.
3681         * cris-linux-tdep.c: Revert.
3682         * cp-valprint.c: Revert.
3683         * cp-support.c: Revert.
3684         * cp-namespace.c: Revert.
3685         * cp-abi.c: Revert.
3686         * corelow.c: Revert.
3687         * corefile.c: Revert.
3688         * continuations.c: Revert.
3689         * completer.h: Revert.
3690         * completer.c: Revert.
3691         * complaints.c: Revert.
3692         * coffread.c: Revert.
3693         * coff-pe-read.c: Revert.
3694         * cli-out.h: Revert.
3695         * cli-out.c: Revert.
3696         * charset.c: Revert.
3697         * c-varobj.c: Revert.
3698         * c-valprint.c: Revert.
3699         * c-typeprint.c: Revert.
3700         * c-lang.c: Revert.
3701         * buildsym.c: Revert.
3702         * buildsym-legacy.c: Revert.
3703         * build-id.h: Revert.
3704         * build-id.c: Revert.
3705         * btrace.c: Revert.
3706         * bsd-uthread.c: Revert.
3707         * breakpoint.h: Revert.
3708         * breakpoint.c: Revert.
3709         * break-catch-throw.c: Revert.
3710         * break-catch-syscall.c: Revert.
3711         * break-catch-sig.c: Revert.
3712         * blockframe.c: Revert.
3713         * block.c: Revert.
3714         * bfin-tdep.c: Revert.
3715         * bfin-linux-tdep.c: Revert.
3716         * bfd-target.c: Revert.
3717         * bcache.c: Revert.
3718         * ax-general.c: Revert.
3719         * ax-gdb.h: Revert.
3720         * ax-gdb.c: Revert.
3721         * avr-tdep.c: Revert.
3722         * auxv.c: Revert.
3723         * auto-load.c: Revert.
3724         * arm-wince-tdep.c: Revert.
3725         * arm-tdep.c: Revert.
3726         * arm-symbian-tdep.c: Revert.
3727         * arm-pikeos-tdep.c: Revert.
3728         * arm-obsd-tdep.c: Revert.
3729         * arm-nbsd-tdep.c: Revert.
3730         * arm-nbsd-nat.c: Revert.
3731         * arm-linux-tdep.c: Revert.
3732         * arm-linux-nat.c: Revert.
3733         * arm-fbsd-tdep.c: Revert.
3734         * arm-fbsd-nat.c: Revert.
3735         * arm-bsd-tdep.c: Revert.
3736         * arch-utils.c: Revert.
3737         * arc-tdep.c: Revert.
3738         * arc-newlib-tdep.c: Revert.
3739         * annotate.h: Revert.
3740         * annotate.c: Revert.
3741         * amd64-windows-tdep.c: Revert.
3742         * amd64-windows-nat.c: Revert.
3743         * amd64-tdep.c: Revert.
3744         * amd64-sol2-tdep.c: Revert.
3745         * amd64-obsd-tdep.c: Revert.
3746         * amd64-obsd-nat.c: Revert.
3747         * amd64-nbsd-tdep.c: Revert.
3748         * amd64-nbsd-nat.c: Revert.
3749         * amd64-nat.c: Revert.
3750         * amd64-linux-tdep.c: Revert.
3751         * amd64-linux-nat.c: Revert.
3752         * amd64-fbsd-tdep.c: Revert.
3753         * amd64-fbsd-nat.c: Revert.
3754         * amd64-dicos-tdep.c: Revert.
3755         * amd64-darwin-tdep.c: Revert.
3756         * amd64-bsd-nat.c: Revert.
3757         * alpha-tdep.c: Revert.
3758         * alpha-obsd-tdep.c: Revert.
3759         * alpha-nbsd-tdep.c: Revert.
3760         * alpha-mdebug-tdep.c: Revert.
3761         * alpha-linux-tdep.c: Revert.
3762         * alpha-linux-nat.c: Revert.
3763         * alpha-bsd-tdep.c: Revert.
3764         * alpha-bsd-nat.c: Revert.
3765         * aix-thread.c: Revert.
3766         * agent.c: Revert.
3767         * addrmap.c: Revert.
3768         * ada-varobj.c: Revert.
3769         * ada-valprint.c: Revert.
3770         * ada-typeprint.c: Revert.
3771         * ada-tasks.c: Revert.
3772         * ada-lang.c: Revert.
3773         * aarch64-tdep.c: Revert.
3774         * aarch64-ravenscar-thread.c: Revert.
3775         * aarch64-newlib-tdep.c: Revert.
3776         * aarch64-linux-tdep.c: Revert.
3777         * aarch64-linux-nat.c: Revert.
3778         * aarch64-fbsd-tdep.c: Revert.
3779         * aarch64-fbsd-nat.c: Revert.
3780         * aarch32-linux-nat.c: Revert.
3781
3782 2019-04-05  Tom Tromey  <tom@tromey.com>
3783
3784         * ft32-tdep.c: Sort headers.
3785         * frv-tdep.c: Sort headers.
3786         * frv-linux-tdep.c: Sort headers.
3787         * frame.c: Sort headers.
3788         * frame-unwind.c: Sort headers.
3789         * frame-base.c: Sort headers.
3790         * fork-child.c: Sort headers.
3791         * findvar.c: Sort headers.
3792         * findcmd.c: Sort headers.
3793         * filesystem.c: Sort headers.
3794         * filename-seen-cache.h: Sort headers.
3795         * filename-seen-cache.c: Sort headers.
3796         * fbsd-tdep.c: Sort headers.
3797         * fbsd-nat.h: Sort headers.
3798         * fbsd-nat.c: Sort headers.
3799         * f-valprint.c: Sort headers.
3800         * f-typeprint.c: Sort headers.
3801         * f-lang.c: Sort headers.
3802         * extension.h: Sort headers.
3803         * extension.c: Sort headers.
3804         * extension-priv.h: Sort headers.
3805         * expprint.c: Sort headers.
3806         * exec.h: Sort headers.
3807         * exec.c: Sort headers.
3808         * exceptions.c: Sort headers.
3809         * event-top.c: Sort headers.
3810         * event-loop.c: Sort headers.
3811         * eval.c: Sort headers.
3812         * elfread.c: Sort headers.
3813         * dwarf2read.h: Sort headers.
3814         * dwarf2read.c: Sort headers.
3815         * dwarf2loc.c: Sort headers.
3816         * dwarf2expr.h: Sort headers.
3817         * dwarf2expr.c: Sort headers.
3818         * dwarf2-frame.c: Sort headers.
3819         * dwarf2-frame-tailcall.c: Sort headers.
3820         * dwarf-index-write.h: Sort headers.
3821         * dwarf-index-write.c: Sort headers.
3822         * dwarf-index-common.c: Sort headers.
3823         * dwarf-index-cache.h: Sort headers.
3824         * dwarf-index-cache.c: Sort headers.
3825         * dummy-frame.c: Sort headers.
3826         * dtrace-probe.c: Sort headers.
3827         * disasm.h: Sort headers.
3828         * disasm.c: Sort headers.
3829         * disasm-selftests.c: Sort headers.
3830         * dictionary.c: Sort headers.
3831         * dicos-tdep.c: Sort headers.
3832         * demangle.c: Sort headers.
3833         * dcache.h: Sort headers.
3834         * dcache.c: Sort headers.
3835         * darwin-nat.h: Sort headers.
3836         * darwin-nat.c: Sort headers.
3837         * darwin-nat-info.c: Sort headers.
3838         * d-valprint.c: Sort headers.
3839         * d-namespace.c: Sort headers.
3840         * d-lang.c: Sort headers.
3841         * ctf.c: Sort headers.
3842         * csky-tdep.c: Sort headers.
3843         * csky-linux-tdep.c: Sort headers.
3844         * cris-tdep.c: Sort headers.
3845         * cris-linux-tdep.c: Sort headers.
3846         * cp-valprint.c: Sort headers.
3847         * cp-support.c: Sort headers.
3848         * cp-namespace.c: Sort headers.
3849         * cp-abi.c: Sort headers.
3850         * corelow.c: Sort headers.
3851         * corefile.c: Sort headers.
3852         * continuations.c: Sort headers.
3853         * completer.h: Sort headers.
3854         * completer.c: Sort headers.
3855         * complaints.c: Sort headers.
3856         * coffread.c: Sort headers.
3857         * coff-pe-read.c: Sort headers.
3858         * cli-out.h: Sort headers.
3859         * cli-out.c: Sort headers.
3860         * charset.c: Sort headers.
3861         * c-varobj.c: Sort headers.
3862         * c-valprint.c: Sort headers.
3863         * c-typeprint.c: Sort headers.
3864         * c-lang.c: Sort headers.
3865         * buildsym.c: Sort headers.
3866         * buildsym-legacy.c: Sort headers.
3867         * build-id.h: Sort headers.
3868         * build-id.c: Sort headers.
3869         * btrace.c: Sort headers.
3870         * bsd-uthread.c: Sort headers.
3871         * breakpoint.h: Sort headers.
3872         * breakpoint.c: Sort headers.
3873         * break-catch-throw.c: Sort headers.
3874         * break-catch-syscall.c: Sort headers.
3875         * break-catch-sig.c: Sort headers.
3876         * blockframe.c: Sort headers.
3877         * block.c: Sort headers.
3878         * bfin-tdep.c: Sort headers.
3879         * bfin-linux-tdep.c: Sort headers.
3880         * bfd-target.c: Sort headers.
3881         * bcache.c: Sort headers.
3882         * ax-general.c: Sort headers.
3883         * ax-gdb.h: Sort headers.
3884         * ax-gdb.c: Sort headers.
3885         * avr-tdep.c: Sort headers.
3886         * auxv.c: Sort headers.
3887         * auto-load.c: Sort headers.
3888         * arm-wince-tdep.c: Sort headers.
3889         * arm-tdep.c: Sort headers.
3890         * arm-symbian-tdep.c: Sort headers.
3891         * arm-pikeos-tdep.c: Sort headers.
3892         * arm-obsd-tdep.c: Sort headers.
3893         * arm-nbsd-tdep.c: Sort headers.
3894         * arm-nbsd-nat.c: Sort headers.
3895         * arm-linux-tdep.c: Sort headers.
3896         * arm-linux-nat.c: Sort headers.
3897         * arm-fbsd-tdep.c: Sort headers.
3898         * arm-fbsd-nat.c: Sort headers.
3899         * arm-bsd-tdep.c: Sort headers.
3900         * arch-utils.c: Sort headers.
3901         * arc-tdep.c: Sort headers.
3902         * arc-newlib-tdep.c: Sort headers.
3903         * annotate.h: Sort headers.
3904         * annotate.c: Sort headers.
3905         * amd64-windows-tdep.c: Sort headers.
3906         * amd64-windows-nat.c: Sort headers.
3907         * amd64-tdep.c: Sort headers.
3908         * amd64-sol2-tdep.c: Sort headers.
3909         * amd64-obsd-tdep.c: Sort headers.
3910         * amd64-obsd-nat.c: Sort headers.
3911         * amd64-nbsd-tdep.c: Sort headers.
3912         * amd64-nbsd-nat.c: Sort headers.
3913         * amd64-nat.c: Sort headers.
3914         * amd64-linux-tdep.c: Sort headers.
3915         * amd64-linux-nat.c: Sort headers.
3916         * amd64-fbsd-tdep.c: Sort headers.
3917         * amd64-fbsd-nat.c: Sort headers.
3918         * amd64-dicos-tdep.c: Sort headers.
3919         * amd64-darwin-tdep.c: Sort headers.
3920         * amd64-bsd-nat.c: Sort headers.
3921         * alpha-tdep.c: Sort headers.
3922         * alpha-obsd-tdep.c: Sort headers.
3923         * alpha-nbsd-tdep.c: Sort headers.
3924         * alpha-mdebug-tdep.c: Sort headers.
3925         * alpha-linux-tdep.c: Sort headers.
3926         * alpha-linux-nat.c: Sort headers.
3927         * alpha-bsd-tdep.c: Sort headers.
3928         * alpha-bsd-nat.c: Sort headers.
3929         * aix-thread.c: Sort headers.
3930         * agent.c: Sort headers.
3931         * addrmap.c: Sort headers.
3932         * ada-varobj.c: Sort headers.
3933         * ada-valprint.c: Sort headers.
3934         * ada-typeprint.c: Sort headers.
3935         * ada-tasks.c: Sort headers.
3936         * ada-lang.c: Sort headers.
3937         * aarch64-tdep.c: Sort headers.
3938         * aarch64-ravenscar-thread.c: Sort headers.
3939         * aarch64-newlib-tdep.c: Sort headers.
3940         * aarch64-linux-tdep.c: Sort headers.
3941         * aarch64-linux-nat.c: Sort headers.
3942         * aarch64-fbsd-tdep.c: Sort headers.
3943         * aarch64-fbsd-nat.c: Sort headers.
3944         * aarch32-linux-nat.c: Sort headers.
3945
3946 2019-04-04  Tom Tromey  <tom@tromey.com>
3947
3948         * varobj.c (varobj_create): Update.
3949         * rust-exp.y (struct rust_parser) <update_innermost_block,
3950         lookup_symbol>: New methods.
3951         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
3952         Rename.
3953         (rust_parser::rust_lookup_type)
3954         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3955         * printcmd.c (display_command, do_one_display): Update.
3956         * parser-defs.h (struct parser_state) <parser_state>: Add
3957         "tracker" parameter.
3958         (block_tracker): New member.
3959         (class innermost_block_tracker) <innermost_block_tracker>: Add
3960         "types" parameter.
3961         <reset>: Remove method.
3962         (innermost_block): Don't declare.
3963         (null_post_parser): Update.
3964         * parse.c (innermost_block): Remove global.
3965         (write_dollar_variable): Update.
3966         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
3967         Remove "tracker_types" parameter.
3968         (parse_expression): Add "tracker" parameter.
3969         (parse_expression_for_completion): Update.
3970         (null_post_parser): Add "tracker" parameter.
3971         * p-exp.y: Update rules.
3972         * m2-exp.y: Update rules.
3973         * language.h (struct language_defn) <la_post_parser>: Add
3974         "tracker" parameter.
3975         * go-exp.y: Update rules.
3976         * f-exp.y: Update rules.
3977         * expression.h (parse_expression, parse_exp_1): Add "tracker"
3978         parameter.
3979         * d-exp.y: Update rules.
3980         * c-exp.y: Update rules.
3981         * breakpoint.c (set_breakpoint_condition): Create an
3982         innermost_block_tracker.
3983         (watch_command_1): Likewise.
3984         * ada-lang.c (resolve): Add "tracker" parameter.
3985         (resolve_subexp): Likewise.
3986         * ada-exp.y (write_var_from_sym): Update.
3987
3988 2019-04-04  Tom Tromey  <tom@tromey.com>
3989
3990         * type-stack.h: New file.
3991         * type-stack.c: New file.
3992         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
3993         type-stack.h.
3994         (insert_into_type_stack, insert_type, push_type, push_type_int)
3995         (insert_type_address_space, pop_type, pop_type_int)
3996         (pop_typelist, pop_type_stack, append_type_stack)
3997         (push_type_stack, get_type_stack, push_typelist)
3998         (follow_type_instance_flags, follow_types): Don't declare.
3999         * parse.c (type_stack): Remove global.
4000         (parse_exp_in_context): Update.
4001         (insert_into_type_stack, insert_type, push_type, push_type_int)
4002         (insert_type_address_space, pop_type, pop_type_int)
4003         (pop_typelist, pop_type_stack, append_type_stack)
4004         (push_type_stack, get_type_stack, push_typelist)
4005         (follow_type_instance_flags, follow_types): Remove (moved to
4006         type-stack.c).
4007         * f-exp.y (type_stack): New global.
4008         Update rules.
4009         (push_kind_type, f_parse): Update.
4010         * d-exp.y (type_stack): New global.
4011         Update rules.
4012         (d_parse): Update.
4013         * c-exp.y (struct c_parse_state) <type_stack>: New member.
4014         Update rules.
4015         * Makefile.in (COMMON_SFILES): Add type-stack.c.
4016         (HFILES_NO_SRCDIR): Add type-stack.h.
4017
4018 2019-04-04  Tom Tromey  <tom@tromey.com>
4019
4020         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
4021         (rust_parser::convert_ast_to_expression, rust_parse)
4022         (rust_lex_test_completion, rust_lex_tests): Update.
4023         * parser-defs.h (struct expr_completion_state): New.
4024         (struct parser_state) <parser_state>: Add completion parameter.
4025         <mark_struct_expression, mark_completion_tag>: New methods.
4026         <parse_completion, m_completion_state>: New members.
4027         (prefixify_expression, null_post_parser): Update.
4028         (mark_struct_expression, mark_completion_tag): Don't declare.
4029         * parse.c (parse_completion, expout_last_struct)
4030         (expout_tag_completion_type, expout_completion_name): Remove
4031         globals.
4032         (parser_state::mark_struct_expression)
4033         (parser_state::mark_completion_tag): Now methods.
4034         (prefixify_expression): Add last_struct parameter.
4035         (prefixify_subexp): Likewise.
4036         (parse_exp_1): Update.
4037         (parse_exp_in_context): Add cstate parameter.  Update.
4038         (parse_expression_for_completion): Create an
4039         expr_completion_state.
4040         (null_post_parser): Add "completion" parameter.
4041         * p-exp.y: Update rules.
4042         (yylex): Update.
4043         * language.h (struct language_defn) <la_post_parser>: Add
4044         "completing" parameter.
4045         * go-exp.y: Update rules.
4046         (lex_one_token): Update.
4047         * expression.h (parse_completion): Don't declare.
4048         * d-exp.y: Update rules.
4049         (lex_one_token): Update rules.
4050         * c-exp.y: Update rules.
4051         (lex_one_token): Update.
4052         * ada-lang.c (resolve): Add "parse_completion" parameter.
4053         (resolve_subexp): Likewise.
4054         (ada_resolve_function): Likewise.
4055
4056 2019-04-04  Tom Tromey  <tom@tromey.com>
4057
4058         * parser-defs.h (struct parser_state) <start_arglist,
4059         end_arglist>: New methods.
4060         <arglist_len, m_funcall_chain>: New members.
4061         (arglist_len, start_arglist, end_arglist): Don't declare.
4062         * parse.c (arglist_len, funcall_chain): Remove global.
4063         (start_arglist, end_arglist): Remove functions.
4064         (parse_exp_in_context): Update.
4065         * p-exp.y: Update rules.
4066         * m2-exp.y: Update rules.
4067         * go-exp.y: Update rules.
4068         * f-exp.y: Update rules.
4069         * d-exp.y: Update rules.
4070         * c-exp.y: Update rules.
4071
4072 2019-04-04  Tom Tromey  <tom@tromey.com>
4073
4074         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
4075         lex_operator, push_back>: New methods.
4076         Update all rules.
4077         (rust_parser::lex_hex, lex_escape): Rename and update.
4078         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
4079         (rust_parser::lex_operator): Rename and update.
4080         (rust_parser::lex_number, rustyylex, rustyyerror)
4081         (rust_lex_test_init, rust_lex_test_sequence)
4082         (rust_lex_test_push_back, rust_lex_tests): Update.
4083         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
4084         parameter.
4085         <lexptr, prev_lexptr>: New members.
4086         (lexptr, prev_lexptr): Don't declare.
4087         * parse.c (lexptr, prev_lexptr): Remove globals.
4088         (parse_exp_in_context): Update.
4089         * p-exp.y (yylex, yyerror): Update.
4090         * m2-exp.y (parse_number, yylex, yyerror): Update.
4091         * go-exp.y (lex_one_token, yyerror): Update.
4092         * f-exp.y (match_string_literal, yylex, yyerror): Update.
4093         * d-exp.y (lex_one_token, yyerror): Update.
4094         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
4095         (lex_one_token, yyerror): Update.
4096         * ada-lex.l (YY_INPUT): Update.
4097         (rewind_to_char): Update.
4098         * ada-exp.y (yyerror): Update.
4099
4100 2019-04-04  Tom Tromey  <tom@tromey.com>
4101
4102         * rust-exp.y (rustyylex, rust_lex_tests): Update.
4103         * parser-defs.h (struct parser_state) <parser_state>: Add new
4104         parameter.
4105         <comma_terminates>: New member.
4106         (comma_terminates): Don't declare global.
4107         * parse.c (comma_terminates): Remove global.
4108         (parse_exp_in_context): Update.
4109         * p-exp.y (yylex): Update.
4110         * m2-exp.y (yylex): Update.
4111         * go-exp.y (lex_one_token): Update.
4112         * f-exp.y (yylex): Update.
4113         * d-exp.y (lex_one_token): Update.
4114         * c-exp.y (lex_one_token): Update.
4115         * ada-lex.l: Update.
4116
4117 2019-04-04  Tom Tromey  <tom@tromey.com>
4118
4119         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
4120         (rustyylex, rust_lex_test_init, rust_lex_test_one)
4121         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
4122         * parser-defs.h (paren_depth): Don't declare.
4123         * parse.c (paren_depth): Remove global.
4124         (parse_exp_in_context): Update.
4125         * p-exp.y (paren_depth): New global.
4126         (pascal_parse): Initialize it.
4127         * m2-exp.y (paren_depth): New global.
4128         (m2_parse): Initialize it.
4129         * go-exp.y (paren_depth): New global.
4130         (go_parse): Initialize it.
4131         * f-exp.y (paren_depth): New global.
4132         (f_parse): Initialize it.
4133         * d-exp.y (paren_depth): New global.
4134         (d_parse): Initialize it.
4135         * c-exp.y (paren_depth): New global.
4136         (c_parse): Initialize it.
4137         * ada-lex.l (paren_depth): New global.
4138         (lexer_init): Initialize it.
4139
4140 2019-04-04  Tom Tromey  <tom@tromey.com>
4141
4142         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
4143         (rust_parser::convert_ast_to_type)
4144         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4145         * parser-defs.h (struct parser_state) <parser_state>: Add
4146         parameters.  Initialize new members.
4147         <expression_context_block, expression_context_pc>: New members.
4148         * parse.c (expression_context_block, expression_context_pc):
4149         Remove globals.
4150         (parse_exp_in_context): Update.
4151         * p-exp.y: Update all rules.
4152         (yylex): Update.
4153         * m2-exp.y: Update all rules.
4154         (yylex): Update.
4155         * go-exp.y (yylex): Update.
4156         * f-exp.y (yylex): Update.
4157         * d-exp.y: Update all rules.
4158         (yylex): Update.
4159         * c-exp.y: Update all rules.
4160         (lex_one_token, classify_name, yylex, c_parse): Update.
4161         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
4162
4163 2019-04-04  Tom Tromey  <tom@tromey.com>
4164
4165         * gdbarch.h, gdbarch.c: Rebuild.
4166         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
4167         * stap-probe.h:
4168         (struct stap_parse_info): Replace "parser_state" with
4169         "expr_builder".
4170         * parser-defs.h (struct expr_builder): Rename from "parser_state".
4171         (parser_state): New class.
4172         * parse.c (expr_builder): Rename.
4173         (expr_builder::release): Rename.
4174         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
4175         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
4176         (write_exp_elt_longcst, write_exp_elt_floatcst)
4177         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
4178         (write_exp_string_vector, write_exp_bitstring)
4179         (write_exp_msymbol, mark_struct_expression)
4180         (write_dollar_variable)
4181         (insert_type_address_space, increase_expout_size): Replace
4182         "parser_state" with "expr_builder".
4183         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
4184         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
4185         "parser_state" with "expr_builder".
4186
4187 2019-04-04  Tom Tromey  <tom@tromey.com>
4188
4189         * rust-exp.y: Replace "parse_language" with method call.
4190         * p-exp.y:
4191         (yylex): Replace "parse_language" with method call.
4192         * m2-exp.y:
4193         (yylex): Replace "parse_language" with method call.
4194         * go-exp.y (classify_name): Replace "parse_language" with method
4195         call.
4196         * f-exp.y (yylex): Replace "parse_language" with method call.
4197         * d-exp.y (lex_one_token): Replace "parse_language" with method
4198         call.
4199         * c-exp.y:
4200         (lex_one_token, classify_name, yylex): Replace "parse_language"
4201         with method call.
4202         * ada-exp.y (find_primitive_type, type_char)
4203         (type_system_address): Replace "parse_language" with method call.
4204
4205 2019-04-04  Tom Tromey  <tom@tromey.com>
4206
4207         * rust-exp.y: Replace "parse_gdbarch" with method call.
4208         * parse.c (write_dollar_variable, insert_type_address_space):
4209         Replace "parse_gdbarch" with method call.
4210         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
4211         call.
4212         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
4213         call.
4214         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
4215         "parse_gdbarch" with method call.
4216         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
4217         with method call.
4218         * f-exp.y (parse_type, parse_f_type, yylex): Replace
4219         "parse_gdbarch" with method call.
4220         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
4221         "parse_gdbarch" with method call.
4222         * c-exp.y (parse_type, parse_number, classify_name): Replace
4223         "parse_gdbarch" with method call.
4224         * ada-lex.l: Replace "parse_gdbarch" with method call.
4225         * ada-exp.y (parse_type, find_primitive_type, type_char)
4226         (type_system_address): Replace "parse_gdbarch" with method call.
4227
4228 2019-04-04  Tom Tromey  <tom@tromey.com>
4229
4230         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
4231         * stap-probe.c (stap_parse_argument): Update.
4232         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
4233         initial_size parameter.
4234         * rust-exp.y (rust_lex_tests): Update.
4235         * parse.c (parser_state): Update.
4236         (parse_exp_in_context): Update.
4237         * parser-defs.h (struct parser_state) <parser_state>: Remove
4238         "initial_size" parameter.
4239
4240 2019-04-04  Tom Tromey  <tom@tromey.com>
4241
4242         * parser-defs.h (increase_expout_size): Don't declare.
4243         * parse.c (increase_expout_size): Now static.
4244
4245 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
4246
4247         * gnu-nat.c (gnu_nat_target::wait): Fix
4248         target_waitstatus_to_string call.
4249
4250 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4251
4252         * eval.c (evaluate_subexp_standard): Handle internal functions
4253         during Fortran function call handling.
4254
4255 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4256
4257         * NEWS: Mention new internal functions.
4258         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
4259         (read_base_type): Use dwarf2_init_complex_target_type.
4260         * value.c (creal_internal_fn): New function.
4261         (cimag_internal_fn): New function.
4262         (_initialize_values): Register new internal functions.
4263
4264 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4265
4266         * infrun.c (stop_all_threads): If debug_infrun, always
4267         trace the wait status after wait_one, using
4268         target_waitstatus_to_string and target_pid_to_str.
4269         (handle_inferior_event): Replace various trace of
4270         wait status kind by a single trace.
4271         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
4272         wait status kind image by target_waitstatus_to_string.
4273         * target/waitstatus.c (target_waitstatus_to_string): Fix
4274         obsolete comment.
4275
4276 2019-04-01  Tom Tromey  <tromey@adacore.com>
4277
4278         PR symtab/23331:
4279         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
4280
4281 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
4282             Pedro Alves  <palves@redhat.com>
4283
4284         * top.c (quit_force): Call 'finalize_values'.
4285         * value.c (finalize_values): New function.
4286         * value.h (finalize_values): Declare.
4287
4288 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
4289
4290         * NEWS: Announce $_gdb_major and $_gdb_minor.
4291
4292         * top.c (init_gdb_version_vars): New function.
4293         (gdb_init): Call init_gdb_version_vars.
4294
4295 2019-03-29  Tom Tromey  <tromey@adacore.com>
4296
4297         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
4298         help text.  Remove dead code.
4299
4300 2019-03-29  Keith Seitz  <keiths@redhat.com>
4301
4302         From Siddhesh Poyarekar:
4303         * f-lang.h (f77_get_upperbound): Return LONGEST.
4304         (f77_get_lowerbound): Likewise.
4305         * f-typeprint.c (f_type_print_varspec_suffix): Expand
4306         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
4307         print them.
4308         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
4309         plongest to format print it.
4310         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
4311         (f77_get_upperbound): Likewise.
4312         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
4313         LOWER_BOUND to LONGEST.
4314         (f77_create_arrayprint_offset_tbl): Likewise.
4315
4316 2019-03-29  Keith Seitz  <keiths@redhat.com>
4317
4318         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
4319         %s/pulongest for TYPE_LENGTH instead of %d in format
4320         strings.
4321         * ada-typerint.c (ada_print_type): Likewise.
4322         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
4323         * compile/compile-c-support.c (generate_register_struct): Likewise.
4324         * gdbtypes.c (recursive_dump_type): Likewise.
4325         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
4326         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
4327         instead of %d in format strings.
4328         * riscv-tdep.c (riscv_type_alignment): Cast second argument
4329         to std::min to ULONGEST.
4330         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
4331         instead of %d in format strings.
4332         * tracepoint.c (info_scope_command): Likewise.
4333         * typeprint.c (print_offset_data::update)
4334         (print_offset_data::finish): Likewise.
4335         * xtensa-tdep.c (xtensa_store_return_value)
4336         (xtensa_push_dummy_call): Likewise.
4337
4338 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
4339
4340         * windows-nat.c (display_selector): Fixed format specifications
4341         for 64-bit Cygwin.
4342
4343 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4344
4345         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
4346
4347 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
4348
4349         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
4350         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
4351         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
4352         (nios2_linux_init_abi): Install it.
4353
4354 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4355
4356         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
4357
4358 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4359
4360         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
4361
4362 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4363             Tom Tromey  <tromey@adacore.com>
4364
4365         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
4366
4367 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
4368
4369         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
4370         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
4371         method to compute the bounds of range types. Also print "[evaluated]"
4372         if the bounds' values come from a dynamic evaluation.
4373
4374 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4375
4376         * cp-valprint.c (cp_print_value_fields): Don't print trailing
4377         whitespace when pretty printing is on.
4378
4379 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4380
4381         * ppc-linux-nat.c: Add include.
4382
4383 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4384
4385         * NEWS: Mention AArch64 Pointer Authentication.
4386
4387 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4388
4389         * arm-linux-nat.c: Add include.
4390
4391 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
4392
4393         * source-cache.c (source_cache::get_source_lines): Re-read
4394         fullname after calling open_source_file.
4395
4396 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
4397
4398         * NEWS: Mention TLS support for FreeBSD.
4399
4400 2019-03-25  Tom Tromey  <tromey@adacore.com>
4401
4402         * minsyms.c (BUNCH_SIZE): Update comment.
4403         (~minimal_symbol_reader): Remove old comment.
4404         (compact_minimal_symbols): Update comment.
4405         (minimal_symbol_reader::install): Remove old comment.  Update
4406         other comments.
4407
4408 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4409
4410         * s390-linux-nat.c: Add include.
4411
4412 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4413
4414         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4415         Call linux_get_hwcap.
4416         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
4417         Likewise.
4418         (aarch64_linux_get_hwcap): Remove function.
4419         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
4420         declaration.
4421         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
4422         linux_get_hwcap.
4423         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4424         * linux-tdep.c (linux_get_hwcap): Add function.
4425         (linux_get_hwcap2): Likewise.
4426         * linux-tdep.h (linux_get_hwcap): Add declaration.
4427         (linux_get_hwcap2): Likewise.
4428         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
4429         (ppc_linux_get_hwcap2): Likewise.
4430         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
4431         linux_get_hwcap.
4432         (ppc_linux_nat_target::insert_watchpoint): Likewise.
4433         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
4434         (ppc_linux_nat_target::read_description): Likewise.
4435         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
4436         * s390-linux-nat.c: Likewise.
4437         * s390-linux-tdep.c (s390_core_read_description): Likewise.
4438
4439 2019-03-24  Tom Tromey  <tom@tromey.com>
4440
4441         * ada-lang.c (standard_lookup): Simplify initialization.
4442         (ada_lookup_symbol_nonlocal): Simplify return.
4443         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
4444         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
4445         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
4446         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
4447         initialization.
4448         * solib.c (solib_global_lookup): Simplify.
4449         * symtab.c (null_block_symbol): Remove.
4450         (symbol_cache_lookup): Simplify returns.
4451         (lookup_language_this): Simplify returns.
4452         (lookup_symbol_aux): Simplify return.
4453         (lookup_local_symbol): Simplify returns.
4454         (lookup_global_symbol_from_objfile): Simplify return.
4455         (lookup_symbol_in_objfile_symtabs)
4456         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
4457         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
4458         (lookup_static_symbol, lookup_global_symbol): Simplify return.
4459         * cp-namespace.c (cp_lookup_bare_symbol)
4460         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
4461         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
4462         (cp_lookup_nested_symbol): Don't use null_block_symbol.
4463         (cp_lookup_symbol_via_imports): Simplify initialization.
4464         (find_symbol_in_baseclass): Likewise.
4465         * symtab.h (null_block_symbol): Remove.
4466         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
4467         (d_lookup_nested_symbol, d_lookup_symbol_imports)
4468         (d_lookup_symbol_module): Likewise.
4469         (find_symbol_in_baseclass): Simplify initialization.
4470
4471 2019-03-24  Tom Tromey  <tom@tromey.com>
4472
4473         * expression.h: Don't include symtab.h.
4474         (struct block): Forward declare.
4475
4476 2019-03-24  Tom Tromey  <tom@tromey.com>
4477
4478         * c-exp.y (typebase): Remove casts.
4479         * gdbtypes.c (lookup_unsigned_typename, )
4480         (lookup_signed_typename): Remove cast.
4481         * eval.c (parse_to_comma_and_eval): Remove cast.
4482         * parse.c (write_dollar_variable): Remove cast.
4483         * block.h (struct block) <superblock>: Now const.
4484         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
4485         * psymtab.c (psym_map_matching_symbols): Make "block" const.
4486         (map_block): Make "block" const.
4487         * symfile.h (struct quick_symbol_functions)
4488         <map_matching_symbols>: Constify block argument to "callback".
4489         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
4490         const.
4491         (find_pc_sect_compunit_symtab): Make "b" const.
4492         (find_symbol_at_address): Likewise.
4493         (search_symbols): Likewise.
4494         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
4495         (dw2_debug_names_lookup_symbol): Likewise.
4496         (dw2_map_matching_symbols): Update.
4497         * p-valprint.c (pascal_val_print): Remove "block".
4498         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
4499         (aux_add_nonlocal_symbols): Make "block" const.
4500         (resolve_subexp): Remove cast.
4501         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
4502         const.
4503         (iterate_over_file_blocks): Likewise.
4504         * f-exp.y (%union) <bval>: Remove.
4505         * coffread.c (patch_opaque_types): Make "b" const.
4506         * spu-tdep.c (spu_catch_start): Make "block" const.
4507         * c-valprint.c (print_unpacked_pointer): Remove "block".
4508         * symmisc.c (dump_symtab_1): Make "b" const.
4509         (block_depth): Make "block" const.
4510         * d-exp.y (%union) <bval>: Remove.
4511         * cp-support.h (cp_lookup_rtti_type): Update.
4512         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
4513         * psymtab.c (psym_lookup_symbol): Make "block" const.
4514         (maintenance_check_psymtabs): Make "b" const.
4515         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
4516         (enumerate_locals, enumerate_args): Update.
4517         * python/py-symtab.c (stpy_global_block): Make "block" const.
4518         (stpy_static_block): Likewise.
4519         * inline-frame.c (block_starting_point_at): Make "new_block"
4520         const.
4521         * block.c (find_block_in_blockvector): Make return type const.
4522         (blockvector_for_pc_sect): Make "b" const.
4523         (find_block_in_blockvector): Make "b" const.
4524
4525 2019-03-23  Tom Tromey  <tom@tromey.com>
4526
4527         * varobj.c (varobj_create): Update.
4528         * symfile.c (clear_symtab_users): Don't reset innermost_block.
4529         * printcmd.c (display_command, do_one_display): Don't reset
4530         innermost_block.
4531         * parser-defs.h (enum innermost_block_tracker_type): Move to
4532         expression.h.
4533         (innermost_block): Update comment.
4534         * parse.c (parse_exp_1): Add tracker_types parameter.
4535         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
4536         tracker_types parameter.  Reset innermost_block.
4537         (parse_exp_in_context): Remove.
4538         (parse_expression_for_completion): Update.
4539         * objfiles.c (~objfile): Don't reset expression_context_block or
4540         innermost_block.
4541         * expression.h (enum innermost_block_tracker_type): Move from
4542         parser-defs.h.
4543         (parse_exp_1): Add tracker_types parameter.
4544         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
4545         reset innermost_block.
4546
4547 2019-03-23  Tom Tromey  <tom@tromey.com>
4548
4549         * objfiles.h: Include bcache.h.
4550
4551 2019-03-23  Tom Tromey  <tom@tromey.com>
4552
4553         * linespec.c (get_current_search_block): Use
4554         scoped_restore_current_language.
4555         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
4556
4557 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4558             Jiong Wang  <jiong.wang@arm.com>
4559
4560         * aarch64-linux-tdep.c
4561         (aarch64_linux_iterate_over_regset_sections): Check for pauth
4562         section.
4563         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
4564
4565 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4566             Jiong Wang  <jiong.wang@arm.com>
4567
4568         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
4569         instructions.
4570         (aarch64_analyze_prologue_test): Add PACIASP test.
4571         (aarch64_prologue_prev_register): Unmask PC value.
4572
4573 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4574             Jiong Wang  <jiong.wang@arm.com>
4575
4576         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
4577         (aarch64_dwarf2_prev_register): Unmask PC value.
4578         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
4579         (aarch64_execute_dwarf_cfa_vendor_op): Check for
4580         DW_CFA_AARCH64_negate_ra_state.
4581         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
4582
4583 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4584             Jiong Wang  <jiong.wang@arm.com>
4585
4586         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
4587         registers.
4588         (aarch64_pseudo_register_name): Likewise.
4589         (aarch64_pseudo_register_type): Likewise.
4590         (aarch64_pseudo_register_reggroup_p): Likewise.
4591         (aarch64_gdbarch_init): Add pauth registers.
4592         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
4593         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
4594         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
4595         (struct gdbarch_tdep): Add regnum for ra_state.
4596
4597 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4598             Jiong Wang  <jiong.wang@arm.com>
4599
4600         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
4601
4602 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4603             Jiong Wang  <jiong.wang@arm.com>
4604
4605         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
4606         function.
4607         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
4608         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
4609         (aarch64_gdbarch_init): Add puth registers.
4610         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
4611         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
4612         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
4613
4614 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4615             Jiong Wang  <jiong.wang@arm.com>
4616
4617         * aarch64-linux-nat.c
4618         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
4619         * aarch64-linux-tdep.c
4620         (aarch64_linux_core_read_description): Likewise.
4621         (aarch64_linux_get_hwcap): New function.
4622         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
4623         (aarch64_linux_get_hwcap): New declaration.
4624
4625 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4626             Jiong Wang  <jiong.wang@arm.com>
4627
4628         * aarch64-linux-nat.c
4629         (aarch64_linux_nat_target::read_description): Add pauth param.
4630         * aarch64-linux-tdep.c
4631         (aarch64_linux_core_read_description): Likewise.
4632         * aarch64-tdep.c (struct target_desc): Add in pauth.
4633         (aarch64_read_description): Add pauth param.
4634         (aarch64_gdbarch_init): Likewise.
4635         * aarch64-tdep.h (aarch64_read_description): Likewise.
4636         * arch/aarch64.c (aarch64_create_target_description): Likewise.
4637         * arch/aarch64.h (aarch64_create_target_description): Likewise.
4638         * features/Makefile: Add new files.
4639         * features/aarch64-pauth.c: New file.
4640         * features/aarch64-pauth.xml: New file.
4641
4642 2019-03-20  Tom Tromey  <tromey@adacore.com>
4643
4644         * infrun.c (handle_inferior_event): Rename from
4645         handle_inferior_event_1.  Create a scoped_value_mark.
4646         (handle_inferior_event): Remove.
4647
4648 2019-03-19  Tom Tromey  <tromey@adacore.com>
4649
4650         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
4651         * infrun.h (print_stop_event): Add "displays" parameter.
4652         * infrun.c (print_stop_event): Add "displays" parameter.
4653
4654 2019-03-19  Pedro Alves  <palves@redhat.com>
4655
4656         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
4657         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
4658         to -1.  Fix TABs vs spaces.
4659         (tui_ui_out::tui_ui_out): Don't initialize fields here.
4660         * tui/tui-out.h (tui_ui_out) Add intro comments.
4661         <m_line, m_start_of_line>: In-class initialize, and add describing
4662         comment.
4663
4664 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
4665
4666         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
4667         variable names.
4668         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
4669
4670 2019-03-18  Pedro Alves  <palves@redhat.com>
4671             Eli Zaretskii <eliz@gnu.org>
4672
4673         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
4674         m_line and m_start_of_line.
4675
4676 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
4677
4678         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
4679         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
4680         it returns a newline.  This fixes a regression in TU mode, whereby
4681         the next line is output on the same screen line as the user input.
4682
4683 2019-03-18  Tom Tromey  <tromey@adacore.com>
4684
4685         * minsyms.c (minimal_symbol_reader::install): Remove call to
4686         obstack_blank.
4687
4688 2019-03-18  Pedro Alves  <palves@redhat.com>
4689
4690         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
4691         New globals.
4692         (apply_style): New, factored out from ...
4693         (apply_ansi_escape): ... this.  Handle reverse video mode.
4694         (tui_set_reverse_mode): New function.
4695         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
4696         * tui/tui-winsource.c (tui_show_source_line): Use
4697         tui_set_reverse_mode instead of setting A_STANDOUT.
4698         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
4699         New setter methods.
4700
4701 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
4702
4703         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
4704         Handle tabs.
4705
4706 2019-03-18  Tom Tromey  <tromey@adacore.com>
4707
4708         * ada-lang.c (empty_array): Add "high" parameter.
4709         (ada_evaluate_subexp): Update.
4710
4711 2019-03-17  Sergei Trofimovich <siarheit@google.com>
4712
4713         * unittests/string_view-selftests.c: Define
4714         _initialize_string_view_selftests unconditionally.
4715
4716 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4717
4718         PR gdb/24350
4719         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
4720
4721 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4722
4723         PR gdb/24351
4724         * windows-nat.c (display_selector): Fix format specifiers.
4725
4726 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
4727
4728         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
4729         tui_refill_source_window instead of tui_refresh_win, to update the
4730         current execution line.  This fixes redisplay of the current line
4731         when stepping through the code with "next" or "step".
4732
4733 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4734
4735         * source-cache.c (source_cache::get_source_lines): Call
4736         find_source_lines to initialize s->nlines.  This fixes vertical
4737         scrolling of TUI source window when the DOWN arrow is pressed.
4738
4739 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4740
4741         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
4742         linux-thread-db.c (_initialize_thread_db): Likewise.
4743
4744 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4745
4746         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
4747         wclrtoeol in tui_show_source_line".  This reverts changes made in
4748         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
4749
4750 2019-03-15  Tom Tromey  <tom@tromey.com>
4751
4752         * symtab.h (struct minimal_symbol): Derive from
4753         general_symbol_info.
4754         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
4755         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
4756         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
4757         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
4758         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
4759         (MSYMBOL_SEARCH_NAME): Update.
4760         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
4761         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
4762         * minsyms.c (minimal_symbol_reader::record_full): Update.
4763
4764 2019-03-15  Tom Tromey  <tom@tromey.com>
4765
4766         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
4767
4768 2019-03-15  Tom Tromey  <tom@tromey.com>
4769
4770         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
4771         unique_xmalloc_ptr.
4772         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
4773         Update.
4774         * minsyms.c (lookup_minimal_symbol_by_pc_section)
4775         (build_minimal_symbol_hash_tables)
4776         (minimal_symbol_reader::install): Update.
4777
4778 2019-03-15  Tom Tromey  <tom@tromey.com>
4779
4780         * symtab.c (create_demangled_names_hash): Update.
4781         (symbol_set_names): Update.
4782         * objfiles.h (struct objfile_per_bfd_storage)
4783         <demangled_names_hash>: Now an htab_up.
4784         * objfiles.c (objfile_per_bfd_storage): Simplify.
4785
4786 2019-03-15  Tom Tromey  <tom@tromey.com>
4787
4788         * objfiles.h (struct objfile_per_bfd_storage): Declare
4789         destructor.
4790         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
4791         New.
4792         (get_objfile_bfd_data): Use new.  Don't initialize
4793         language_of_main.
4794         (free_objfile_per_bfd_storage): Remove.
4795         (objfile_bfd_data_free, objfile::~objfile): Use delete.
4796
4797 2019-03-15  Tom Tromey  <tom@tromey.com>
4798
4799         * symfile.c (reread_symbols): Update.
4800         * objfiles.c (objfile::objfile): Update.
4801         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
4802         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
4803         comment.
4804         (minimal_symbol_reader::install): Update.
4805         (terminate_minimal_symbol_table): Remove.
4806         * jit.c (jit_object_close_impl): Update.
4807
4808 2019-03-15  Tom Tromey  <tom@tromey.com>
4809
4810         * minsyms.c (minimal_symbol_reader::record_full): Remove some
4811         initializations.
4812
4813 2019-03-15  Tom Tromey  <tom@tromey.com>
4814
4815         * objfiles.h (struct objfile_per_bfd_storage)
4816         <demangled_hash_languages>: Now a bitset.
4817         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
4818         (lookup_minimal_symbol): Update.
4819
4820 2019-03-15  Tom Tromey  <tom@tromey.com>
4821
4822         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
4823         Don't return the symbol.
4824         * coffread.c (record_minimal_symbol): Use record_full.
4825
4826 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
4827
4828         The MS-Windows port of ncurses fails to switch to a color pair if
4829         one or both of the colors are the implicit default colors.  This
4830         change records the default colors when TUI is initialized, and
4831         then specifies them explicitly when a color pair uses the default
4832         colors.  This allows color styling in TUI mode on MS-Windows.
4833
4834         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
4835         ncurses_norm_attr.
4836         (tui_initialize_io) [__MINGW32__]: Record the default terminal
4837         colors in ncurses_norm_attr.
4838         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
4839         "none", replace it with the default color recorded in
4840         ncurses_norm_attr.
4841
4842 2019-03-14  Tom Tromey  <tromey@adacore.com>
4843
4844         * source-cache.h (class source_cache) <get_source_lines>: Return
4845         std::string.
4846         * source-cache.c (source_cache::extract_lines): Handle case where
4847         first_pos==npos.  Return std::string.
4848         (source_cache::get_source_lines): Update.
4849
4850 2019-03-14  Tom Tromey  <tromey@adacore.com>
4851
4852         * NEWS: Add item for "style sources" commands.
4853         * source-cache.c (source_cache::get_source_lines): Check
4854         source_styling.
4855         * cli/cli-style.c (source_styling): New global.
4856         (_initialize_cli_style): Add "style sources" commands.
4857         (show_style_sources): New function.
4858         * cli/cli-style.h (source_styling): Declare.
4859
4860 2019-03-14  Pedro Alves  <palves@redhat.com>
4861             Tom Tromey  <tromey@adacore.com>
4862
4863         * tui/tui-winsource.h (tui_refill_source_window): Declare.
4864         * tui/tui-winsource.c (tui_refill_source_window): New function,
4865         from...
4866         (tui_horizontal_source_scroll): ... here.  Move some logic.
4867         * cli/cli-style.c (set_style_enabled): Notify new observable.
4868         * tui/tui-hooks.c (tui_redisplay_source): New function.
4869         (tui_attach_detach_observers): Attach or detach
4870         tui_redisplay_source.
4871         * observable.h (source_styling_changed): New observable.
4872         * observable.c: Define source_styling_changed observable.
4873
4874 2019-03-13  Tom Tromey  <tromey@adacore.com>
4875
4876         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
4877         (i386_gnu_nat_target::store_registers): Update.
4878         * target-debug.h (target_debug_print_std_string): New macro.
4879         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4880         * windows-tdep.c (display_one_tib): Update.
4881         * tui/tui-stack.c (tui_make_status_line): Update.
4882         * top.c (print_inferior_quit_action): Update.
4883         * thread.c (thr_try_catch_cmd): Update.
4884         (add_thread_with_info): Update.
4885         (thread_target_id_str): Update.
4886         (thr_try_catch_cmd): Update.
4887         (thread_command): Update.
4888         (thread_find_command): Update.
4889         * record-btrace.c (record_btrace_target::info_record)
4890         (record_btrace_resume_thread, record_btrace_target::resume)
4891         (record_btrace_cancel_resume, record_btrace_step_thread)
4892         (record_btrace_target::wait, record_btrace_target::wait)
4893         (record_btrace_target::wait, record_btrace_target::stop): Update.
4894         * progspace.c (print_program_space): Update.
4895         * process-stratum-target.c
4896         (process_stratum_target::thread_address_space): Update.
4897         * linux-fork.c (linux_fork_mourn_inferior)
4898         (detach_checkpoint_command, info_checkpoints_command)
4899         (linux_fork_context): Update.
4900         (linux_fork_detach): Update.
4901         (class scoped_switch_fork_info): Update.
4902         (delete_checkpoint_command): Update.
4903         * infrun.c (follow_fork_inferior): Update.
4904         (follow_fork_inferior): Update.
4905         (proceed_after_vfork_done): Update.
4906         (handle_vfork_child_exec_or_exit): Update.
4907         (follow_exec): Update.
4908         (displaced_step_prepare_throw): Update.
4909         (displaced_step_restore): Update.
4910         (start_step_over): Update.
4911         (resume_1): Update.
4912         (clear_proceed_status_thread): Update.
4913         (proceed): Update.
4914         (print_target_wait_results): Update.
4915         (do_target_wait): Update.
4916         (context_switch): Update.
4917         (stop_all_threads): Update.
4918         (restart_threads): Update.
4919         (finish_step_over): Update.
4920         (handle_signal_stop): Update.
4921         (switch_back_to_stepped_thread): Update.
4922         (keep_going_pass_signal): Update.
4923         (print_exited_reason): Update.
4924         (normal_stop): Update.
4925         * inferior.c (inferior_pid_to_str): Change return type.
4926         (print_selected_inferior): Update.
4927         (add_inferior): Update.
4928         (detach_inferior): Update.
4929         * dummy-frame.c (fprint_dummy_frames): Update.
4930         * dcache.c (dcache_info_1): Update.
4931         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
4932         (btrace_fetch, btrace_clear): Update.
4933         * linux-tdep.c (linux_core_pid_to_str): Change return type.
4934         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
4935         type.
4936         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
4937         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
4938         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
4939         * gdbarch.c, gdbarch.h: Rebuild.
4940         * gdbarch.sh (core_pid_to_str): Change return type.
4941         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
4942         return type.
4943         (windows_nat_target::pid_to_str): Change return type.
4944         (windows_delete_thread): Update.
4945         (windows_nat_target::attach): Update.
4946         (windows_nat_target::files_info): Update.
4947         * target-delegates.c: Rebuild.
4948         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
4949         return type.
4950         (sol_thread_target::pid_to_str): Change return type.
4951         * remote.c (class remote_target) <pid_to_str>: Change return
4952         type.
4953         (remote_target::pid_to_str): Change return type.
4954         (extended_remote_target::attach, remote_target::remote_stop_ns)
4955         (remote_target::remote_notif_remove_queued_reply)
4956         (remote_target::push_stop_reply, remote_target::disable_btrace):
4957         Update.
4958         (extended_remote_target::attach): Update.
4959         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
4960         type.
4961         (gdbsim_target::pid_to_str): Change return type.
4962         * ravenscar-thread.c (struct ravenscar_thread_target)
4963         <pid_to_str>: Change return type.
4964         (ravenscar_thread_target::pid_to_str): Change return type.
4965         * procfs.c (class procfs_target) <pid_to_str>: Change return
4966         type.
4967         (procfs_target::pid_to_str): Change return type.
4968         (procfs_target::attach): Update.
4969         (procfs_target::detach): Update.
4970         (procfs_target::fetch_registers): Update.
4971         (procfs_target::store_registers): Update.
4972         (procfs_target::wait): Update.
4973         (procfs_target::files_info): Update.
4974         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
4975         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
4976         return type.
4977         (nto_procfs_target::pid_to_str): Change return type.
4978         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
4979         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
4980         return type.
4981         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
4982         (exit_lwp): Update.
4983         (attach_proc_task_lwp_callback, get_detach_signal)
4984         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
4985         (linux_nat_target::resume, wait_lwp, stop_callback)
4986         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
4987         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
4988         (linux_nat_wait_1, resume_stopped_resumed_lwps)
4989         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
4990         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
4991         type.
4992         (inf_ptrace_target::attach): Update.
4993         (inf_ptrace_target::files_info): Update.
4994         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
4995         type.
4996         (go32_nat_target::pid_to_str): Change return type.
4997         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
4998         (gnu_nat_target::wait): Update.
4999         (gnu_nat_target::wait): Update.
5000         (gnu_nat_target::resume): Update.
5001         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
5002         (fbsd_nat_target::wait): Update.
5003         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
5004         type.
5005         (darwin_nat_target::attach): Update.
5006         * corelow.c (class core_target) <pid_to_str>: Change return type.
5007         (core_target::pid_to_str): Change return type.
5008         * target.c (normal_pid_to_str): Change return type.
5009         (default_pid_to_str): Likewise.
5010         (target_pid_to_str): Change return type.
5011         (target_translate_tls_address): Update.
5012         (target_announce_detach): Update.
5013         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
5014         return type.
5015         (bsd_uthread_target::pid_to_str): Change return type.
5016         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
5017         type.
5018         (bsd_kvm_target::pid_to_str): Change return type.
5019         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
5020         return type.
5021         (aix_thread_target::pid_to_str): Change return type.
5022         * target.h (struct target_ops) <pid_to_str>: Change return type.
5023         (target_pid_to_str, normal_pid_to_str): Likewise.
5024         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
5025         type.
5026         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
5027         type.
5028         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
5029         return type.
5030         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
5031         type.
5032         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
5033         type.
5034         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
5035         return type.
5036
5037 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
5038
5039         * NEWS: Mention that the new default MI version is 3.  Mention
5040         changes to the output of commands and events that deal with
5041         multi-location breakpoints.
5042         * breakpoint.c: Include "mi/mi-out.h".
5043         (print_one_breakpoint): Change output syntax if using MI version
5044         >= 3.
5045         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
5046         New.
5047         (mi_multi_location_breakpoint_output_fixed): New.
5048         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
5049         (mi_cmd_fix_multi_location_breakpoint_output): New.
5050         (mi_multi_location_breakpoint_output_fixed): New.
5051         * mi/mi-cmds.c (mi_cmds): Register command
5052         -fix-multi-location-breakpoint-output.
5053         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
5054         interpreter "mi".
5055
5056 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
5057
5058         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
5059         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
5060         instantiate mi_ui_out based on interpreter name.
5061         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
5062         * mi/mi-main.c (mi_load_progress): Likewise.
5063
5064 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5065
5066         * NEWS: Combine separate "New targets" sections for 8.3.
5067
5068 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5069
5070         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
5071         (ppcfbsd_init_abi): Install gdbarch
5072         "fetch_tls_load_module_address" and "get_thread_local_address"
5073         methods.
5074
5075 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5076
5077         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
5078         (riscv_fbsd_init_abi): Install gdbarch
5079         "fetch_tls_load_module_address" and "get_thread_local_address"
5080         methods.
5081
5082 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5083
5084         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
5085         (i386fbsd_init_abi): Install gdbarch
5086         "fetch_tls_load_module_address" and "get_thread_local_address"
5087         methods.
5088
5089 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5090
5091         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
5092         (amd64fbsd_init_abi): Install gdbarch
5093         "fetch_tls_load_module_address" and "get_thread_local_address"
5094         methods.
5095
5096 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5097
5098         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
5099         (struct fbsd_pspace_data): New type.
5100         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
5101         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
5102         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
5103         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
5104         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
5105
5106 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5107
5108         * gdbtypes.c (lookup_struct_elt): New function.
5109         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
5110         * gdbtypes.h (struct struct_elt): New type.
5111         (lookup_struct_elt): New prototype.
5112
5113 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5114
5115         * gdbtypes.c (lookup_struct_elt_type): Update comment and
5116         remove disabled code block.
5117
5118 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5119
5120         * gdbarch.sh (get_thread_local_address): New method.
5121         * gdbarch.h, gdbarch.c: Regenerate.
5122         * target.c (target_translate_tls_address): Use
5123         gdbarch_get_thread_local_address if present instead of
5124         target::get_thread_local_address.
5125
5126 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5127
5128         * target.h (target::get_thread_local_address): Update comment.
5129
5130 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5131
5132         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
5133         objfile->separate_debug_objfile_backlink if not NULL.
5134
5135 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5136
5137         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
5138         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
5139         (amd64bsd_store_inferior_registers): Likewise.
5140         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5141         Enable segment base registers.
5142         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
5143         PT_GETFSBASE and PT_GETGSBASE.
5144         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
5145         PT_SETGSBASE.
5146         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
5147         segment base registers.
5148         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5149
5150 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5151
5152         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5153         Update calls to i386_target_description to add 'segments'
5154         parameter.
5155         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
5156         add segment base registers.
5157         * arch/i386.c (i386_create_target_description): Add 'segments'
5158         parameter to enable segment base registers.
5159         * arch/i386.h (i386_create_target_description): Likewise.
5160         * features/i386/32bit-segments.xml: New file.
5161         * features/i386/32bit-segments.c: Generate.
5162         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
5163         call to i386_target_description to add 'segments' parameter.
5164         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5165         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
5166         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
5167         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
5168         if feature is present.
5169         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
5170         Add 'segments' parameter to call to i386_target_description.
5171         (i386_target_description): Add 'segments' parameter to enable
5172         segment base registers.
5173         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
5174         to call to i386_target_description.
5175         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
5176         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
5177         Define I386_NUM_REGS.
5178         (i386_target_description): Add 'segments' parameter to enable
5179         segment base registers.
5180
5181 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
5182
5183         PR/24325
5184         * source-cache.c: #undef open and close, to avoid unresolved
5185         externals during linking.
5186
5187 2019-03-12  Tom Tromey  <tromey@adacore.com>
5188
5189         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
5190         const.  Add initializers.
5191         (_initialize_remote): Don't initialize ptid globals.
5192
5193 2019-03-12  Pedro Alves  <palves@redhat.com>
5194
5195         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
5196
5197 2019-03-12  Pedro Alves  <palves@redhat.com>
5198
5199         * cp-name-parser.y (main): Remove unused 'len' variable.
5200
5201 2019-03-12  Tom Tromey  <tromey@adacore.com>
5202
5203         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
5204         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
5205
5206 2019-03-12  Tom Tromey  <tromey@adacore.com>
5207
5208         * linux-nat.c (iterate_over_lwps): Update.
5209         (stop_callback): Remove parameter.
5210         (stop_wait_callback, detach_callback, resume_set_callback)
5211         (select_singlestep_lwp_callback, set_ignore_sigint)
5212         (status_callback, resumed_callback, resume_clear_callback)
5213         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
5214         data parameter.
5215         (linux_nat_target::detach, linux_nat_target::resume)
5216         (linux_stop_and_wait_all_lwps, select_event_lwp)
5217         (linux_nat_filter_event, linux_nat_wait_1)
5218         (linux_nat_target::kill, linux_nat_target::stop)
5219         (linux_nat_target::stop): Update.
5220         (linux_nat_resume_callback): Change type.
5221         (resume_stopped_resumed_lwps, count_events_callback)
5222         (select_event_lwp_callback): Likewise.
5223         (linux_stop_lwp, linux_nat_stop_lwp): Update.
5224         * arm-linux-nat.c (struct update_registers_data): Remove.
5225         (update_registers_callback): Change type.
5226         (arm_linux_insert_hw_breakpoint1): Update.
5227         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
5228         parameter.
5229         (x86_linux_dr_set_addr): Update.
5230         (x86_linux_dr_set_control): Update.
5231         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
5232         (iterate_over_lwps): Use gdb::function_view.
5233         * nat/aarch64-linux-hw-point.c (struct
5234         aarch64_dr_update_callback_param): Remove.
5235         (debug_reg_change_callback): Change type.
5236         (aarch64_notify_debug_reg_change): Update.
5237         * s390-linux-nat.c (s390_refresh_per_info): Update.
5238
5239 2019-03-11  Tom Tromey  <tromey@adacore.com>
5240
5241         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
5242         redundant assignment to "this_cu".
5243
5244 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5245
5246         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
5247
5248 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5249
5250         * gdbtypes.c (rank_one_type_parm_set): New function extracted
5251         from...
5252         (rank_one_type): ... this.
5253
5254 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5255
5256         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
5257         from...
5258         (rank_one_type): ... this.
5259
5260 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5261
5262         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
5263         from...
5264         (rank_one_type): ... this.
5265
5266 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5267
5268         * gdbtypes.c (rank_one_type_parm_float): New function extracted
5269         from...
5270         (rank_one_type): ... this.
5271
5272 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5273
5274         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
5275         from...
5276         (rank_one_type): ... this.
5277
5278 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5279
5280         * gdbtypes.c (rank_one_type_parm_range): New function extracted
5281         from...
5282         (rank_one_type): ... this.
5283
5284 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5285
5286         * gdbtypes.c (rank_one_type_parm_char): New function extracted
5287         from...
5288         (rank_one_type): ... this.
5289
5290 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5291
5292         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
5293         from...
5294         (rank_one_type): ... this.
5295
5296 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5297
5298         * gdbtypes.c (rank_one_type_parm_int): New function extracted
5299         from...
5300         (rank_one_type): ... this.
5301
5302 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5303
5304         * gdbtypes.c (rank_one_type_parm_func): New function extracted
5305         from...
5306         (rank_one_type): ... this.
5307
5308 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5309
5310         * gdbtypes.c (rank_one_type_parm_array): New function extracted
5311         from...
5312         (rank_one_type): ... this.
5313
5314 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5315
5316         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
5317         from...
5318         (rank_one_type): ... this.
5319
5320 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5321
5322         * inferior.c (initialize_inferiors): Ensure 'help set/show print
5323         inferior-events' shows the example events.
5324
5325 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
5326
5327         Support styling on native MS-Windows console
5328
5329         PR/24315
5330         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
5331         on MS-Windows if $TERM is not defined.
5332
5333         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
5334
5335         * posix-hdep.c (gdb_console_fputs):
5336         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
5337         functions.
5338         * ui-file.h (gdb_console_fputs): Add prototype.
5339
5340         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
5341         back to fputs only if the former returns zero.
5342
5343 2019-03-07  Tom Tromey  <tom@tromey.com>
5344
5345         * symmisc.c (print_symbol_bcache_statistics): Update.
5346         (print_objfile_statistics): Update.
5347         * symfile.c (allocate_symtab): Update.
5348         * stabsread.c: Don't include bcache.h.
5349         * psymtab.h (struct psymbol_bcache): Don't declare.
5350         (class psymtab_storage) <psymbol_cache>: Now a bcache.
5351         (psymbol_bcache_init, psymbol_bcache_free)
5352         (psymbol_bcache_get_bcache): Don't declare.
5353         * psymtab.c (struct psymbol_bcache): Remove.
5354         (psymtab_storage::psymtab_storage): Update.
5355         (psymtab_storage::~psymtab_storage): Update.
5356         (psymbol_bcache_init, psymbol_bcache_free)
5357         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
5358         (add_psymbol_to_bcache): Update.
5359         (allocate_psymtab): Update.
5360         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
5361         macro_cache>: No longer pointers.
5362         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
5363         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
5364         * macrotab.c (macro_bcache): Update.
5365         * macroexp.c: Don't include bcache.h.
5366         * gdbtypes.c (check_types_worklist): Update.
5367         (types_deeply_equal): Remove TRY/CATCH.  Update.
5368         * elfread.c (elf_symtab_read): Update.
5369         * dwarf2read.c: Don't include bcache.h.
5370         * buildsym.c (buildsym_compunit::get_macro_table): Update.
5371         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
5372         (print_bcache_statistics, bcache_memory_used): Don't declare.
5373         (struct bcache): Move from bcache.c.  Add constructor, destructor,
5374         methods.  Rename all data members.
5375         * bcache.c (struct bcache): Move to bcache.h.
5376         (bcache::expand_hash_table): Rename from expand_hash_table.
5377         (bcache): Remove.
5378         (bcache::insert): Rename from bcache_full.
5379         (bcache::compare): Rename from bcache_compare.
5380         (bcache_xmalloc): Remove.
5381         (bcache::~bcache): Rename from bcache_xfree.
5382         (bcache::print_statistics): Rename from print_bcache_statistics.
5383         (bcache::memory_used): Rename from bcache_memory_used.
5384
5385 2019-03-07  Pedro Alves  <palves@redhat.com>
5386
5387         * infrun.c (normal_stop): Also check for
5388         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
5389
5390 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
5391
5392         * f-lang.c (value_from_host_double): Moved to...
5393         * value.c (value_from_host_double): ...here.
5394         * value.h (value_from_host_double): Declare.
5395         * guile/scm-math.c (vlscm_convert_typed_number): Use
5396         value_from_host_double.
5397         (vlscm_convert_number): Likewise.
5398         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
5399         * python/py-value.c (convert_value_from_python): Likewise.
5400
5401 2019-03-06  Tom Tromey  <tom@tromey.com>
5402
5403         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
5404
5405 2019-03-06  Tom Tromey  <tom@tromey.com>
5406
5407         * utils.h (free_current_contents): Don't declare.
5408         * utils.c (free_current_contents): Remove.
5409
5410 2019-03-06  Tom Tromey  <tom@tromey.com>
5411
5412         * top.c (quit_force): Update.
5413         * main.c (captured_command_loop): Update.
5414         * common/new-op.c (operator new): Update.
5415         * common/common-exceptions.c (struct catcher)
5416         <save_cleanup_chain>: Remove member.
5417         (exceptions_state_mc_init): Update.
5418         (exception_try_scope_entry): Return nullptr.
5419         (exception_try_scope_exit, exception_rethrow)
5420         (throw_exception_sjlj, throw_exception_cxx): Update.
5421         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
5422         (all_cleanups, do_cleanups, discard_cleanups)
5423         (discard_final_cleanups, save_cleanups, save_final_cleanups)
5424         (restore_cleanups, restore_final_cleanups): Don't declare.
5425         (do_final_cleanups): Remove parameter.
5426         * common/cleanups.c (cleanup_chain, make_cleanup)
5427         (make_cleanup_dtor, all_cleanups, do_cleanups)
5428         (discard_my_cleanups, discard_cleanups)
5429         (discard_final_cleanups, save_my_cleanups, save_cleanups)
5430         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
5431         (null_cleanup): Remove.
5432         (do_final_cleanups): Remove parameter.
5433
5434 2019-03-06  Tom Tromey  <tom@tromey.com>
5435
5436         * remote.c (remote_target::remote_parse_stop_reply): Use
5437         unique_xmalloc_ptr.
5438
5439 2019-03-06  Tom Tromey  <tom@tromey.com>
5440
5441         * stabsread.c (struct stabs_field_info): Rename from field_info.
5442         <list, fnlist>: Add initializers.
5443         <obstack>: New member.
5444         (read_member_functions, read_struct_fields, read_baseclasses):
5445         Allocate on obstack.  Don't use cleanups.
5446         (read_one_struct_field, read_member_functions, read_struct_fields)
5447         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
5448         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
5449         (read_struct_type): Update.
5450
5451 2019-03-06  Tom Tromey  <tom@tromey.com>
5452
5453         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
5454         * common/filestuff.h (make_cleanup_close): Don't declare.
5455         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
5456         Remove.
5457
5458 2019-03-06  Tom Tromey  <tom@tromey.com>
5459
5460         * solib-aix.c: Use make_scope_exit.
5461
5462 2019-03-06  Tom Tromey  <tom@tromey.com>
5463
5464         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
5465         Use make_scope_exit.
5466
5467 2019-03-06  Tom Tromey  <tom@tromey.com>
5468
5469         * solib-svr4.c (disable_probes_interface): Remove parameter.
5470         (svr4_handle_solib_event): Use make_scope_exit.
5471
5472 2019-03-06  Tom Tromey  <tom@tromey.com>
5473
5474         * remote.c (struct stop_reply_deleter): Remove.
5475         (stop_reply_up): Update.
5476         (struct stop_reply): Derive from notif_event.  Don't typedef.
5477         <regcache>: Now a std::vector.
5478         (stop_reply_xfree): Remove.
5479         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
5480         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
5481         (remote_target::discard_pending_stop_replies): Use delete.
5482         (remote_target::remote_parse_stop_reply): Update.
5483         (remote_target::process_stop_reply): Update.
5484         * remote-notif.h (struct notif_event): Add virtual destructor.
5485         Remove "dtr" member.
5486         (struct notif_client) <alloc_event>: Return a unique_ptr.
5487         (notif_event_xfree): Don't declare.
5488         (notif_event_up): New typedef.
5489         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
5490         (notif_event_xfree, do_notif_event_xfree): Remove.
5491         (remote_notif_state_xfree): Update.
5492
5493 2019-03-06  Tom Tromey  <tom@tromey.com>
5494
5495         * infrun.c (displaced_step_clear_cleanup): Now a
5496         forward_scope_exit type.
5497         (displaced_step_prepare_throw): Update.
5498         (displaced_step_fixup): Update.
5499
5500 2019-03-06  Tom Tromey  <tom@tromey.com>
5501
5502         * inferior.h (class inferior): Update comment.
5503         * gdbthread.h (class thread_info): Update comment.
5504
5505 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
5506             Tom Tromey  <tom@tromey.com>
5507
5508         * stabsread.h (struct stab_section_list): Remove.
5509         (coffstab_build_psymtabs): Update.
5510         * dbxread.c (symbuf_sections): Now a std::vector.
5511         (sect_idx): New global.
5512         (fill_symbuf): Update.
5513         (coffstab_build_psymtabs): Change type of stabsects parameter.
5514         Update.
5515         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
5516         std::vector.
5517         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
5518         (coff_locate_sections): Update.
5519         (coff_symfile_read): Remove cleanups.  Update.
5520         (init_stringtab): Add storage parameter.
5521         (free_stringtab, free_stringtab_cleanup): Remove.
5522         (init_lineno): Add storage parameter.
5523         (free_linetab, free_linetab_cleanup): Remove.
5524
5525 2019-03-06  Pedro Alves  <palves@redhat.com>
5526
5527         * linux-fork.c (fork_info::clobber_regs): Delete.
5528         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
5529         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
5530         comment.  Adjust.
5531         (scoped_switch_fork_info::scoped_switch_fork_info)
5532         (checkpoint_command, linux_fork_context): Adjust
5533         fork_save_infrun_state calls.
5534
5535 2019-03-06  Pedro Alves  <palves@redhat.com>
5536
5537         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
5538         (inf_has_multiple_threads): Return 'bool' and rewrite using
5539         inferior_info::threads().
5540
5541 2019-03-06  Pedro Alves  <palves@redhat.com>
5542
5543         * linux-fork.c: Include <list>.
5544         (fork_list): Now a std::list instance.
5545         (fork_info): Add ctor, dtor, and in-class initialize all fields.
5546         (forks_exist_p, find_last_fork): Adjust.
5547         (new_fork): Delete.
5548         (one_fork_p): New.
5549         (add_fork): Adjust.
5550         (free_fork): Delete, folded into fork_info::~fork_info().
5551         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
5552         Adjust.
5553         (init_fork_list): Delete.
5554         (linux_fork_killall, linux_fork_mourn_inferior)
5555         (linux_fork_detach, info_checkpoints_command): Adjust.
5556         (_initialize_linux_fork): No longer call init_fork_list.
5557
5558 2019-03-06  Pedro Alves  <palves@redhat.com>
5559
5560         * linux-fork.c (new_fork): New, split out of ...
5561         (add_fork): ... this.  Return void.  Move "first fork" special
5562         case from here, to ...
5563         (checkpoint_command): ... here.
5564         * linux-linux.h (add_fork): Return void.
5565
5566 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5567
5568         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
5569
5570 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5571             Chris January  <chris.january@arm.com>
5572             David Lecomber  <david.lecomber@arm.com>
5573
5574         * f-exp.y: New token, UNOP_INTRINSIC.
5575         (exp): New pattern using UNOP_INTRINSIC token.
5576         (f77_keywords): Add 'abs' keyword.
5577         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
5578         (value_from_host_double): New function.
5579         (evaluate_subexp_f): Support UNOP_ABS.
5580
5581 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5582
5583         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
5584         types.
5585
5586 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5587
5588         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
5589         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
5590         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
5591
5592 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5593
5594         * f-exp.y (convert_to_kind_type): Handle more type kinds.
5595
5596 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5597             Chris January  <chris.january@arm.com>
5598
5599         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
5600         * f-exp.y: Define 'KIND' token.
5601         (exp): New pattern for KIND expressions.
5602         (ptype): Handle types with a kind extension.
5603         (direct_abs_decl): Extend to spot kind extensions.
5604         (f77_keywords): Add 'kind' to the list.
5605         (push_kind_type): New function.
5606         (convert_to_kind_type): New function.
5607         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
5608         * parse.c (operator_length_standard): Likewise.
5609         * parser-defs.h (enum type_pieces): Add tp_kind.
5610         * std-operator.def: Add UNOP_KIND.
5611
5612 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5613
5614         * f-exp.y (f_parse): Set yydebug.
5615
5616 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5617
5618         * f-lang.c (evaluate_subexp_f): New function.
5619         (exp_descriptor_f): New global.
5620         (f_language_defn): Use exp_descriptor_f instead of
5621         exp_descriptor_standard.
5622
5623 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5624
5625         * f-exp.y (struct token): Add comments.
5626         (dot_ops): Remove uppercase versions and the end marker.
5627         (f77_keywords): Likewise.
5628         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
5629         entries in the dot_ops array are case insensitive, and use
5630         strncasecmp to compare strings.  Also some whitespace cleanup in
5631         this area.  Similar for the f77_keywords array, except entries in
5632         this list might be case sensitive.
5633
5634 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5635
5636         * f-exp.y (struct f77_boolean_val): Add comments.
5637         (boolean_values): Remove uppercase versions, and end marker.
5638         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
5639         and use strncasecmp to achieve case insensitivity.  Additionally,
5640         perform whitespace cleanup around this code.
5641
5642 2019-03-06  Tom Tromey  <tromey@adacore.com>
5643
5644         * remote-sim.c (gdbsim_target_open): Use result of
5645         gdb_argv::release.
5646
5647 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
5648         Dirk Schubert  <dirk.schubert@arm.com>
5649         Chris January  <chris.january@arm.com>
5650
5651         * eval.c (evaluate_subexp_standard): Call Fortran argument
5652         wrapping logic.
5653         * f-lang.c (struct value): A value which can be passed into a
5654         Fortran function call.
5655         (fortran_argument_convert): Wrap Fortran arguments in a pointer
5656         where appropriate.
5657         (struct type): Value ready for a Fortran function call.
5658         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
5659         is needed.
5660         * f-lang.h (fortran_argument_convert): Declaration.
5661         (fortran_preserve_arg_pointer): Declaration.
5662         * infcall.c (value_arg_coerce): Call Fortran argument logic.
5663
5664 2019-03-05  Tom Tromey  <tromey@adacore.com>
5665
5666         * python/py-prettyprint.c (print_string_repr): Remove #if.
5667         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
5668
5669 2019-03-05  Tom Tromey  <tromey@adacore.com>
5670
5671         * target.c (the_dummy_target): Move later.  Change type to
5672         "dummy_target".
5673         (initialize_targets): Don't initialize the_dummy_target.
5674
5675 2019-03-05  Tom Tromey  <tromey@adacore.com>
5676
5677         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
5678         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
5679
5680 2019-03-05  Tom Tromey  <tromey@adacore.com>
5681
5682         * windows-nat.c (windows_nat_target::attach)
5683         (windows_nat_target::detach): Don't call gdb_flush.
5684         * valprint.c (generic_val_print, val_print, val_print_string):
5685         Don't call gdb_flush.
5686         * utils.c (defaulted_query): Don't call gdb_flush.
5687         * typeprint.c (print_type_scalar): Don't call gdb_flush.
5688         * target.c (target_announce_detach): Don't call gdb_flush.
5689         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
5690         * remote.c (extended_remote_target::attach): Don't call
5691         gdb_flush.
5692         * procfs.c (procfs_target::detach): Don't call gdb_flush.
5693         * printcmd.c (do_examine): Don't call gdb_flush.
5694         (info_display_command): Don't call gdb_flush.
5695         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
5696         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
5697         * memattr.c (info_mem_command): Don't call gdb_flush.
5698         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
5699         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
5700         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
5701         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
5702         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
5703         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
5704         (gnu_nat_target::detach): Don't call gdb_flush.
5705         * f-valprint.c (f_val_print): Don't call gdb_flush.
5706         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
5707         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
5708         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
5709         gdb_flush.
5710         * c-valprint.c (c_val_print): Don't call gdb_flush.
5711         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
5712
5713 2019-03-05  Tom Tromey  <tromey@adacore.com>
5714
5715         * varobj.c (update_dynamic_varobj_children): Update.
5716         (install_default_visualizer): Use reset, not release.
5717         * value.c (set_internalvar): Update.
5718         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
5719         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
5720         ATTRIBUTE_UNUSED_RESULT.
5721
5722 2019-03-05  Tom Tromey  <tromey@adacore.com>
5723
5724         * remote.c (class scoped_remote_fd) <release>: Add
5725         ATTRIBUTE_UNUSED_RESULT.
5726
5727 2019-03-05  Tom Tromey  <tromey@adacore.com>
5728
5729         * macroexp.c (struct macro_buffer) <release>: Add
5730         ATTRIBUTE_UNUSED_RESULT.
5731
5732 2019-03-05  Tom Tromey  <tromey@adacore.com>
5733
5734         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
5735         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
5736         ATTRIBUTE_UNUSED_RESULT.
5737
5738 2019-03-05  Tom Tromey  <tromey@adacore.com>
5739
5740         * common/scoped_fd.h (class scoped_fd) <release>: Add
5741         ATTRIBUTE_UNUSED_RESULT.
5742
5743 2019-03-05  Tom Tromey  <tromey@adacore.com>
5744
5745         * parser-defs.h (struct parser_state) <release>: Add
5746         ATTRIBUTE_UNUSED_RESULT.
5747
5748 2019-03-05  Tom Tromey  <tromey@adacore.com>
5749
5750         * utils.h (class gdb_argv) <release>: Add
5751         ATTRIBUTE_UNUSED_RESULT.
5752         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
5753
5754 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
5755
5756         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
5757         for-loop range, to avoid compiler warnings.
5758
5759         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
5760         avoid compiler warnings about unused variables.
5761
5762         * NEWS: Mention end of support for native debugging on MS-Windows
5763         before XP.
5764
5765         PR gdb/24292
5766         * common/netstuff.c:
5767         * gdbserver/gdbreplay.c
5768         * gdbserver/remote-utils.c:
5769         * ser-tcp.c:
5770         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
5771         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
5772         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
5773         'getaddrinfo' and 'freeaddrinfo' were not available before
5774         Windows XP, and mingw.org's MinGW headers by default define
5775         _WIN32_WINNT to 0x500.
5776
5777 2019-03-01  Gary Benson <gbenson@redhat.com>
5778
5779         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
5780
5781 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
5782             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
5783
5784         PR gdb/8527
5785         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
5786         set_sigint_trap, clear_sigint_trap.
5787
5788 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5789
5790         * target.c (target_detach): Clear the regcache and the
5791         frame cache.
5792
5793 2019-02-27  Pedro Alves  <palves@redhat.com>
5794
5795         * utils.c (set_screen_size): When we cap the height/width sizes,
5796         tweak the corresponding command variable to show "unlimited":
5797
5798 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
5799             Pedro Alves  <palves@redhat.com>
5800
5801         * utils.c (set_screen_size): Reduce "infinite" rows and columns
5802         before calling rl_set_screen_size.
5803
5804 2019-02-27  Tom Tromey  <tromey@adacore.com>
5805
5806         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
5807         define.
5808         * python/py-value.c: Remove Python 2.4 workaround.
5809         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
5810         workaround.
5811         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
5812         Python 2.4 workaround.
5813         * python/python-internal.h: Remove Python 2.4 comment.
5814         (Py_ssize_t): Don't define.
5815         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
5816         (gdb_Py_DECREF): Remove Python 2.4 workaround.
5817         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
5818         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
5819         * python/python.c (do_start_initialization): Remove Python 2.4
5820         workaround.
5821         * python/py-prettyprint.c (class dummy_python_frame): Remove.
5822         (print_children): Remove Python 2.4 workaround.
5823         * python/py-inferior.c (buffer_procs): Remove Python 2.4
5824         workaround.
5825         (CHARBUFFERPROC_NAME): Remove.
5826         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
5827         Python 2.4 workaround.
5828
5829 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5830
5831         * NEWS: Note minimum Python version.
5832
5833 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5834
5835         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
5836         code from these functions.  Remove corresponding ifdefs.  Use
5837         Py_buffer_up instead of explicit calls to PyBuffer_Release.
5838         Remove gotos and target of gotos.
5839         (infpy_search_memory): Likewise.
5840
5841 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5842
5843         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
5844         (hppa_gdbarch_init): Don't register deleted functions with
5845         gdbarch.
5846
5847 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5848
5849         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
5850         (h8300_unwind_sp): Delete.
5851         (h8300_dummy_id): Delete.
5852         (h8300_gdbarch_init): Don't register deleted functions with
5853         gdbarch.
5854
5855 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5856
5857         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
5858         (ft32_unwind_pc): Delete.
5859         (ft32_unwind_sp): Delete.
5860         (ft32_gdbarch_init): Don't register deleted functions with
5861         gdbarch.
5862
5863 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5864
5865         * gdb/frv-tdep.c (frv_dummy_id): Delete.
5866         (frv_unwind_pc): Delete.
5867         (frv_unwind_sp): Delete.
5868         (frv_gdbarch_init): Don't register deleted functions with
5869         gdbarch.
5870
5871 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5872
5873         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
5874         (riscv_unwind_pc): Delete.
5875         (riscv_unwind_sp): Delete.
5876         (riscv_gdbarch_init): Don't register deleted functions with
5877         gdbarch.
5878
5879 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5880
5881         * gdb/csky-tdep.c (csky_dummy_id): Delete.
5882         (csky_unwind_pc): Delete.
5883         (csky_unwind_sp): Delete.
5884         (csky_gdbarch_init): Don't register deleted functions with
5885         gdbarch.
5886
5887 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5888
5889         * gdb/cris-tdep.c (cris_dummy_id): Delete.
5890         (cris_unwind_pc): Delete.
5891         (cris_unwind_sp): Delete.
5892         (cris_gdbarch_init): Don't register deleted functions with
5893         gdbarch.
5894
5895 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5896
5897         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
5898         (bfin_unwind_pc): Delete.
5899         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
5900
5901 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5902
5903         * gdb/arm-tdep.c (arm_dummy_id): Delete.
5904         (arm_unwind_pc): Delete.
5905         (arm_unwind_sp): Delete.
5906         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
5907
5908 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5909
5910         * gdb/arc-tdep.c (arc_dummy_id): Delete.
5911         (arc_unwind_pc): Delete.
5912         (arc_unwind_sp): Delete.
5913         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
5914
5915 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5916
5917         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
5918         (alpha_unwind_pc): Delete.
5919         (alpha_gdbarch_init): Don't register deleted functions with
5920         gdbarch.
5921
5922 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5923
5924         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
5925         (aarch64_unwind_pc): Delete.
5926         (aarch64_unwind_sp): Delete.
5927         (aarch64_gdbarch_init): Don't register deleted functions with
5928         gdbarch.
5929
5930 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5931
5932         * gdbtypes.c (type_align): Don't consider static members when
5933         computing structure alignment.
5934
5935 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5936
5937         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
5938         return 0 for other types.
5939         * arch-utils.c (default_type_align): Always return 0.
5940         * gdbarch.h: Regenerate.
5941         * gdbarch.sh (type_align): Extend comment.
5942         * gdbtypes.c (type_align): Add additional comments, always call
5943         gdbarch_type_align before applying the default rules.
5944         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
5945         generic code will then apply a suitable default.
5946         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
5947         types, return 0 for other types.
5948
5949 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5950
5951         * NEWS: Create a new section for the next release branch.
5952         Rename the section of the current branch, now that it has
5953         been cut.
5954
5955 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5956
5957         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
5958         * version.in: Bump version to 8.3.50.DATE-git.
5959
5960 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
5961
5962         * aix-thread.c (ptid_cmp): Remove unused variable.
5963         (get_signaled_thread): Likewise.
5964         (store_regs_user_thread): Likewise.
5965         (store_regs_kernel_thread): Likewise.
5966         (fetch_regs_kernel_thread): Remove shadowed variable.
5967
5968 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5969
5970         * features/riscv/32bit-cpu.xml: Add register numbers.
5971         * features/riscv/32bit-fpu.c: Regenerate.
5972         * features/riscv/32bit-fpu.xml: Add register numbers.
5973         * features/riscv/64bit-cpu.xml: Add register numbers.
5974         * features/riscv/64bit-fpu.c: Regenerate.
5975         * features/riscv/64bit-fpu.xml: Add register numbers.
5976
5977 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
5978
5979         * NEWS: Mention two argument form of gdb.Value constructor.
5980         * python/py-value.c (convert_buffer_and_type_to_value): New
5981         function.
5982         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
5983         Add support for handling an optional second argument.  Call
5984         convert_buffer_and_type_to_value as appropriate.
5985         * python/python-internal.h (Py_buffer_deleter): New struct.
5986         (Py_buffer_up): New typedef.
5987
5988 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
5989
5990         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
5991         instead of releasing ownership.
5992
5993 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
5994
5995         * dwarf2read.c (open_and_init_dwp_file): Call
5996         elf_numsections instead of bfd_count_sections to initialize
5997         dwp_file->num_sections.
5998
5999 2019-02-25  Tom Tromey  <tromey@adacore.com>
6000
6001         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
6002
6003 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
6004
6005         * gcore.in: Add '--readnever' option when invoking GDB.
6006
6007 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6008
6009         * MAINTAINERS: Update my email address.
6010
6011 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6012
6013         * build-id.c (build_id_to_debug_bfd_1): New function.
6014         (build_id_to_debug_bfd): Look for separate debug file in
6015         sysroot.
6016
6017 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6018
6019         * gdbarch.sh: Update the copyright year range that is placed into
6020         generated files.
6021
6022 2019-02-22  Keith Seitz  <keiths@redhat.com>
6023
6024         PR symtab/23853
6025         * linespec.c (create_sals_line_offset): Search for the default
6026         symtab's filename instead of its fullname.
6027
6028 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6029
6030         * NEWS: Update style defaults.
6031
6032 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6033
6034         * main.c (captured_main_1): Disable styling in batch mode.
6035
6036 2019-02-20  Tom Tromey  <tom@tromey.com>
6037
6038         * symtab.c (symtab_symbol_info): Fix typos.
6039
6040 2019-02-20  Tom Tromey  <tromey@adacore.com>
6041
6042         * findcmd.c (_initialize_mem_search): Use upper case for
6043         metasyntactic variables.
6044
6045 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
6046
6047         * aarch64-tdep.c (aarch64_add_reggroups): New function.
6048         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
6049
6050 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
6051
6052         * top.h (source_file_name): Change to std::string.
6053         * top.c (source_file_name): Likewise.
6054         (command_line_input): Adjust.
6055         * cli/cli-script.c (script_from_file): Adjust.
6056
6057 2019-02-19  Tom Tromey  <tromey@adacore.com>
6058
6059         * ravenscar-thread.c
6060         (ravenscar_thread_target::update_thread_list): Don't call
6061         ada_build_task_list.
6062         * ada-lang.h (ada_build_task_list): Don't declare.
6063         * ada-tasks.c (struct ada_tasks_inferior_data)
6064         <task_list_valid_p>: Now bool.
6065         (read_known_tasks, ada_task_list_changed)
6066         (ada_tasks_invalidate_inferior_data): Update.
6067         (read_known_tasks_array): Return bool.
6068         (read_known_tasks_list): Likewise.
6069         (read_known_tasks): Return void.
6070         (ada_build_task_list): Now static.
6071
6072 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6073
6074         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
6075         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
6076
6077 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6078
6079         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
6080         variant for ada_tasks_pspace_data_handle and
6081         ada_tasks_inferior_data_handle.
6082         (ada_tasks_pspace_data_cleanup): New function.
6083         (ada_tasks_inferior_data_cleanup): New function.
6084
6085 2019-02-17  Tom Tromey  <tom@tromey.com>
6086
6087         * macrotab.h (macro_source_fullname): Return a std::string.
6088         * macrotab.c (macro_include, check_for_redefinition)
6089         (macro_undef, macro_lookup_definition, foreach_macro)
6090         (foreach_macro_in_scope): Update.
6091         (macro_source_fullname): Return a std::string.
6092         * macrocmd.c (show_pp_source_pos): Update.
6093
6094 2019-02-17  Tom Tromey  <tom@tromey.com>
6095
6096         * macrocmd.c (show_pp_source_pos): Style the file names.
6097
6098 2019-02-17  Tom Tromey  <tom@tromey.com>
6099
6100         PR tui/24197:
6101         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
6102
6103 2019-02-17  Tom Tromey  <tom@tromey.com>
6104
6105         * ada-lang.c (user_select_syms): Use filtered printing.
6106         * utils.c (wrap_style): New global.
6107         (desired_style): Remove.
6108         (emit_style_escape): Add stream parameter.
6109         (set_output_style, reset_terminal_style, prompt_for_continue):
6110         Update.
6111         (flush_wrap_buffer): Only flush gdb_stdout.
6112         (wrap_here): Set wrap_style.
6113         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
6114         treat escape sequences as a character.  Change when wrap buffer is
6115         flushed.
6116         (fputs_styled): Do not set the output style when the default is
6117         requested.
6118         * ui-style.h (struct ui_file_style) <is_default>: New method.
6119         * source.c (print_source_lines_base): Emit escape sequences in one
6120         piece.
6121
6122 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6123
6124         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
6125         integers and enumeration types.
6126
6127 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6128
6129         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
6130         instead of lookup_symbol_in_language
6131         (do_exact_match): New function.
6132         (ada_get_symbol_name_matcher): Return do_exact_match when
6133         doing a verbatim match.
6134
6135 2019-02-15  Tom Tromey  <tromey@adacore.com>
6136
6137         * ravenscar-thread.c (ravenscar_thread_target::resume)
6138         (ravenscar_thread_target::wait): Special case wildcard requests.
6139
6140 2019-02-15  Tom Tromey  <tromey@adacore.com>
6141
6142         * ravenscar-thread.c (base_ptid): Remove.
6143         (struct ravenscar_thread_target) <close>: New method.
6144         <m_base_ptid>: New member.
6145         <update_inferior_ptid, active_task, task_is_currently_active,
6146         runtime_initialized>: Declare methods.
6147         <ravenscar_thread_target>: Add constructor.
6148         (ravenscar_thread_target::task_is_currently_active)
6149         (ravenscar_thread_target::update_inferior_ptid)
6150         (ravenscar_runtime_initialized): Rename.  Now methods.
6151         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
6152         (ravenscar_thread_target::update_thread_list): Update.
6153         (ravenscar_thread_target::active_task): Now method.
6154         (ravenscar_thread_target::store_registers)
6155         (ravenscar_thread_target::prepare_to_store)
6156         (ravenscar_thread_target::prepare_to_store)
6157         (ravenscar_thread_target::mourn_inferior): Update.
6158         (ravenscar_inferior_created): Use "new" to create target.
6159         (ravenscar_thread_target::get_ada_task_ptid): Update.
6160         (_initialize_ravenscar): Don't initialize base_ptid.
6161         (ravenscar_ops): Remove global.
6162
6163 2019-02-15  Tom Tromey  <tromey@adacore.com>
6164
6165         * target.h (push_target): Declare new overload.
6166         * target.c (push_target): New overload, taking an rvalue reference.
6167         * remote.c (remote_target::open_1): Use push_target overload.
6168         * corelow.c (core_target_open): Use push_target overload.
6169
6170 2019-02-15  Tom Tromey  <tromey@adacore.com>
6171
6172         * ravenscar-thread.c (is_ravenscar_task)
6173         (ravenscar_task_is_currently_active): Return bool.
6174         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
6175         (_initialize_ravenscar): Remove "(void)".
6176         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
6177         Return bool.
6178
6179 2019-02-15  Tom Tromey  <tromey@adacore.com>
6180
6181         * ravenscar-thread.c (ravenscar_runtime_initializer)
6182         (has_ravenscar_runtime, get_running_thread_id)
6183         (ravenscar_thread_target::resume): Fix indentation.
6184
6185 2019-02-15  Tom Tromey  <tromey@adacore.com>
6186
6187         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
6188         from ravenscar_arch_ops.
6189         (sparc_ravenscar_ops::fetch_registers)
6190         (sparc_ravenscar_ops::store_registers): Now methods.
6191         (sparc_ravenscar_prepare_to_store): Remove.
6192         (sparc_ravenscar_ops): Redefine.
6193         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
6194         methods and destructor.  Remove members.
6195         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
6196         (ravenscar_thread_target::store_registers)
6197         (ravenscar_thread_target::prepare_to_store): Update.
6198         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
6199         Remove.
6200         (struct ppc_ravenscar_powerpc_ops): Derive from
6201         ravenscar_arch_ops.
6202         (ppc_ravenscar_powerpc_ops::fetch_registers)
6203         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
6204         (ppc_ravenscar_powerpc_ops): Redefine.
6205         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
6206         (ppc_ravenscar_e500_ops::fetch_registers)
6207         (ppc_ravenscar_e500_ops::store_registers): Now methods.
6208         (ppc_ravenscar_e500_ops): Redefine.
6209         * aarch64-ravenscar-thread.c
6210         (aarch64_ravenscar_generic_prepare_to_store): Remove.
6211         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
6212         (aarch64_ravenscar_fetch_registers)
6213         (aarch64_ravenscar_store_registers): Now methods.
6214         (aarch64_ravenscar_ops): Redefine.
6215
6216 2019-02-15  Tom Tromey  <tromey@adacore.com>
6217
6218         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
6219         (ravenscar_thread_target::stopped_by_hw_breakpoint)
6220         (ravenscar_thread_target::stopped_by_watchpoint)
6221         (ravenscar_thread_target::stopped_data_address)
6222         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
6223
6224 2019-02-15  Tom Tromey  <tromey@adacore.com>
6225
6226         * ravenscar-thread.c: Fix some typos.
6227
6228 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6229             Tom Tromey  <tromey@adacore.com>
6230
6231         * ada-lang.c (ada_exception_sal): Change addr_string to a
6232         std::string.
6233         (create_ada_exception_catchpoint): Update.
6234
6235 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6236             Tom Tromey  <tromey@adacore.com>
6237
6238         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
6239         (bp_location_ops): Remove.
6240         (base_breakpoint_allocate_location): Update.
6241         (free_bp_location): Update.
6242         * ada-lang.c (class ada_catchpoint_location)
6243         <ada_catchpoint_location>: Remove ops parameter.
6244         (ada_catchpoint_location_dtor): Remove.
6245         (ada_catchpoint_location_ops): Remove.
6246         (allocate_location_exception): Update.
6247         * breakpoint.h (struct bp_location_ops): Remove.
6248         (class bp_location) <bp_location>: Remove bp_location_ops
6249         parameter.
6250         <~bp_location>: Add destructor.
6251         <ops>: Remove.
6252
6253 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6254             Pedro Alves  <palves@redhat.com>
6255
6256         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
6257         'PATH_MAX'.
6258
6259 2019-02-14  David Michael  <fedora.dm0@gmail.com>
6260             Samuel Thibault  <samuel.thibault@gnu.org>
6261             Thomas Schwinge  <thomas@codesourcery.com>
6262
6263         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
6264         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
6265
6266 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6267
6268         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
6269         (check_empty): Use "const char *".
6270
6271         * gnu-nat.c (gnu_nat_target::detach): Instead of
6272         'detach_inferior (pid)' call
6273         'detach_inferior (find_inferior_pid (pid))'.
6274
6275         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
6276         'nat/fork-inferior.o'.
6277         * gnu-nat.c: #include "nat/fork-inferior.h".
6278
6279         * gnu-nat.c (gnu_nat_target::detach): Instead of
6280         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
6281         * gnu-nat.h: #include "inf-child.h".
6282         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
6283         'i386_gnu_nat_target::fetch_registers'.
6284         (gnu_store_registers): Rename/move to
6285         'i386_gnu_nat_target::store_registers'.
6286
6287         * config/i386/nm-i386gnu.h: Don't "#include" any files.
6288         * gnu-nat.h (mach_thread_info): New function.
6289         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
6290
6291         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
6292
6293 2019-02-14  Frederic Konrad  <konrad@adacore.com>
6294
6295         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
6296
6297 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
6298
6299         * windows-nat.c (windows_add_thread): Add new parameter
6300         "main_thread_p" with default value set to false.  Update
6301         function documentation as well as all callers.
6302         (windows_delete_thread): Likewise.
6303         (fake_create_process): Update call to windows_add_thread.
6304         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
6305         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
6306         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
6307         call to windows_delete_thread.
6308
6309 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
6310
6311         * MAINTAINERS: Add Andrew Burgess as global maintainer.
6312
6313 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6314
6315         * symfile.c (find_separate_debug_file): Use canonical path of
6316         sysroot with child_path instead of gdb_sysroot if it is valid.
6317
6318 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6319
6320         * symfile.c (find_separate_debug_file): Use child_path to
6321         determine if an object file is under a sysroot.
6322
6323 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6324
6325         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6326         unittests/child-path-selftests.c.
6327         * common/pathstuff.c (child_path): New function.
6328         * common/pathstuff.h (child_path): New prototype.
6329         * unittests/child-path-selftests.c: New file.
6330
6331 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6332
6333         * symfile.c (find_separate_debug_file): Look for separate debug
6334         files in debug directories under the sysroot.
6335
6336 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6337
6338         * symtab.h (struct minimal_symbol data_p): New const method.
6339         (struct minimal_symbol text_p): Likewise.
6340         * symtab.c (output_source_filename): Use file name style
6341         to print file name.
6342         (print_symbol_info): Likewise.
6343         (print_msymbol_info): Use address style to print addresses.
6344         Use function name style to print executable text symbols.
6345         (expand_symtab_containing_pc): Use data_p.
6346         (find_pc_sect_compunit_symtab): Likewise.
6347
6348 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6349
6350         * breakpoint.c (describe_other_breakpoints): Use address style
6351         to print addresses.
6352         (say_where): Likewise.
6353
6354 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6355
6356         * ada-typeprint.c (print_func_type): Print function name
6357         style to print function name.
6358         * c-typeprint.c (c_print_type_1): Likewise.
6359
6360 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
6361
6362         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
6363         for execve.
6364
6365 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6366
6367         * c-exp.y (direct_abs_decl): Use emplace_back to record the
6368         type_stack.
6369
6370 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
6371
6372         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
6373         TYPE_CODE_REF types.
6374
6375 2019-02-08  Jim Wilson  <jimw@sifive.com>
6376
6377         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
6378         (riscv_linux_fregset): New.
6379         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
6380
6381 2019-02-07  Tom Tromey  <tom@tromey.com>
6382
6383         * thread.c (thread_cancel_execution_command): Update.
6384         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
6385         methods.
6386         (struct thread_fsm_ops): Remove.
6387         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
6388         (thread_fsm_should_stop, thread_fsm_return_value)
6389         (thread_fsm_set_finished, thread_fsm_finished_p)
6390         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
6391         Don't declare.
6392         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
6393         * infrun.c (clear_proceed_status_thread)
6394         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
6395         (print_stop_event): Update.
6396         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
6397         Add constructor.
6398         (step_command_fsm_ops): Remove.
6399         (new_step_command_fsm): Remove.
6400         (step_1): Update.
6401         (step_command_fsm::should_stop): Rename from
6402         step_command_fsm_should_stop.
6403         (step_command_fsm::clean_up): Rename from
6404         step_command_fsm_clean_up.
6405         (step_command_fsm::do_async_reply_reason): Rename from
6406         step_command_fsm_async_reply_reason.
6407         (struct until_next_fsm): Inherit from thread_fsm.  Add
6408         constructor.
6409         (until_next_fsm_ops): Remove.
6410         (new_until_next_fsm): Remove.
6411         (until_next_fsm::should_stop): Rename from
6412         until_next_fsm_should_stop.
6413         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
6414         (until_next_fsm::do_async_reply_reason): Rename from
6415         until_next_fsm_async_reply_reason.
6416         (struct finish_command_fsm): Inherit from thread_fsm.  Add
6417         constructor.  Change type of breakpoint.
6418         (finish_command_fsm_ops): Remove.
6419         (new_finish_command_fsm): Remove.
6420         (finish_command_fsm::should_stop): Rename from
6421         finish_command_fsm_should_stop.
6422         (finish_command_fsm::clean_up): Rename from
6423         finish_command_fsm_clean_up.
6424         (finish_command_fsm::return_value): Rename from
6425         finish_command_fsm_return_value.
6426         (finish_command_fsm::do_async_reply_reason): Rename from
6427         finish_command_fsm_async_reply_reason.
6428         (finish_command): Update.
6429         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
6430         Add constructor.
6431         (call_thread_fsm_ops): Remove.
6432         (call_thread_fsm::call_thread_fsm): Rename from
6433         new_call_thread_fsm.
6434         (call_thread_fsm::should_stop): Rename from
6435         call_thread_fsm_should_stop.
6436         (call_thread_fsm::should_notify_stop): Rename from
6437         call_thread_fsm_should_notify_stop.
6438         (run_inferior_call, call_function_by_hand_dummy): Update.
6439         * cli/cli-interp.c (should_print_stop_to_console): Update.
6440         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
6441         Add constructor.  Change type of location_breakpoint,
6442         caller_breakpoint.
6443         (until_break_fsm_ops): Remove.
6444         (new_until_break_fsm): Remove.
6445         (until_break_fsm::should_stop): Rename from
6446         until_break_fsm_should_stop.
6447         (until_break_fsm::clean_up): Rename from
6448         until_break_fsm_clean_up.
6449         (until_break_fsm::do_async_reply_reason): Rename from
6450         until_break_fsm_async_reply_reason.
6451         (until_break_command): Update.
6452         * thread-fsm.c: Remove.
6453         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
6454
6455 2019-02-07  Tom Tromey  <tom@tromey.com>
6456
6457         * yy-remap.h: Add include guard.
6458         * xtensa-tdep.h: Add include guard.
6459         * xcoffread.h: Rename include guard.
6460         * varobj-iter.h: Add include guard.
6461         * tui/tui.h: Rename include guard.
6462         * tui/tui-winsource.h: Rename include guard.
6463         * tui/tui-wingeneral.h: Rename include guard.
6464         * tui/tui-windata.h: Rename include guard.
6465         * tui/tui-win.h: Rename include guard.
6466         * tui/tui-stack.h: Rename include guard.
6467         * tui/tui-source.h: Rename include guard.
6468         * tui/tui-regs.h: Rename include guard.
6469         * tui/tui-out.h: Rename include guard.
6470         * tui/tui-layout.h: Rename include guard.
6471         * tui/tui-io.h: Rename include guard.
6472         * tui/tui-hooks.h: Rename include guard.
6473         * tui/tui-file.h: Rename include guard.
6474         * tui/tui-disasm.h: Rename include guard.
6475         * tui/tui-data.h: Rename include guard.
6476         * tui/tui-command.h: Rename include guard.
6477         * tic6x-tdep.h: Add include guard.
6478         * target/waitstatus.h: Rename include guard.
6479         * target/wait.h: Rename include guard.
6480         * target/target.h: Rename include guard.
6481         * target/resume.h: Rename include guard.
6482         * target-float.h: Rename include guard.
6483         * stabsread.h: Add include guard.
6484         * rs6000-tdep.h: Add include guard.
6485         * riscv-fbsd-tdep.h: Add include guard.
6486         * regformats/regdef.h: Rename include guard.
6487         * record.h: Rename include guard.
6488         * python/python.h: Rename include guard.
6489         * python/python-internal.h: Rename include guard.
6490         * python/py-stopevent.h: Rename include guard.
6491         * python/py-ref.h: Rename include guard.
6492         * python/py-record.h: Rename include guard.
6493         * python/py-record-full.h: Rename include guard.
6494         * python/py-record-btrace.h: Rename include guard.
6495         * python/py-instruction.h: Rename include guard.
6496         * python/py-events.h: Rename include guard.
6497         * python/py-event.h: Rename include guard.
6498         * procfs.h: Add include guard.
6499         * proc-utils.h: Add include guard.
6500         * p-lang.h: Add include guard.
6501         * or1k-tdep.h: Rename include guard.
6502         * observable.h: Rename include guard.
6503         * nto-tdep.h: Rename include guard.
6504         * nat/x86-linux.h: Rename include guard.
6505         * nat/x86-linux-dregs.h: Rename include guard.
6506         * nat/x86-gcc-cpuid.h: Add include guard.
6507         * nat/x86-dregs.h: Rename include guard.
6508         * nat/x86-cpuid.h: Rename include guard.
6509         * nat/ppc-linux.h: Rename include guard.
6510         * nat/mips-linux-watch.h: Rename include guard.
6511         * nat/linux-waitpid.h: Rename include guard.
6512         * nat/linux-ptrace.h: Rename include guard.
6513         * nat/linux-procfs.h: Rename include guard.
6514         * nat/linux-osdata.h: Rename include guard.
6515         * nat/linux-nat.h: Rename include guard.
6516         * nat/linux-namespaces.h: Rename include guard.
6517         * nat/linux-btrace.h: Rename include guard.
6518         * nat/glibc_thread_db.h: Rename include guard.
6519         * nat/gdb_thread_db.h: Rename include guard.
6520         * nat/gdb_ptrace.h: Rename include guard.
6521         * nat/fork-inferior.h: Rename include guard.
6522         * nat/amd64-linux-siginfo.h: Rename include guard.
6523         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
6524         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
6525         * nat/aarch64-linux.h: Rename include guard.
6526         * nat/aarch64-linux-hw-point.h: Rename include guard.
6527         * mn10300-tdep.h: Add include guard.
6528         * mips-linux-tdep.h: Add include guard.
6529         * mi/mi-parse.h: Rename include guard.
6530         * mi/mi-out.h: Rename include guard.
6531         * mi/mi-main.h: Rename include guard.
6532         * mi/mi-interp.h: Rename include guard.
6533         * mi/mi-getopt.h: Rename include guard.
6534         * mi/mi-console.h: Rename include guard.
6535         * mi/mi-common.h: Rename include guard.
6536         * mi/mi-cmds.h: Rename include guard.
6537         * mi/mi-cmd-break.h: Rename include guard.
6538         * m2-lang.h: Add include guard.
6539         * location.h: Rename include guard.
6540         * linux-record.h: Rename include guard.
6541         * linux-nat.h: Add include guard.
6542         * linux-fork.h: Add include guard.
6543         * i386-darwin-tdep.h: Rename include guard.
6544         * hppa-linux-offsets.h: Add include guard.
6545         * guile/guile.h: Rename include guard.
6546         * guile/guile-internal.h: Rename include guard.
6547         * gnu-nat.h: Rename include guard.
6548         * gdb-stabs.h: Rename include guard.
6549         * frv-tdep.h: Add include guard.
6550         * f-lang.h: Add include guard.
6551         * event-loop.h: Add include guard.
6552         * darwin-nat.h: Rename include guard.
6553         * cp-abi.h: Rename include guard.
6554         * config/sparc/nm-sol2.h: Rename include guard.
6555         * config/nm-nto.h: Rename include guard.
6556         * config/nm-linux.h: Add include guard.
6557         * config/i386/nm-i386gnu.h: Rename include guard.
6558         * config/djgpp/nl_types.h: Rename include guard.
6559         * config/djgpp/langinfo.h: Rename include guard.
6560         * compile/gcc-cp-plugin.h: Add include guard.
6561         * compile/gcc-c-plugin.h: Add include guard.
6562         * compile/compile.h: Rename include guard.
6563         * compile/compile-object-run.h: Rename include guard.
6564         * compile/compile-object-load.h: Rename include guard.
6565         * compile/compile-internal.h: Rename include guard.
6566         * compile/compile-cplus.h: Rename include guard.
6567         * compile/compile-c.h: Rename include guard.
6568         * common/xml-utils.h: Rename include guard.
6569         * common/x86-xstate.h: Rename include guard.
6570         * common/version.h: Rename include guard.
6571         * common/vec.h: Rename include guard.
6572         * common/tdesc.h: Rename include guard.
6573         * common/selftest.h: Rename include guard.
6574         * common/scoped_restore.h: Rename include guard.
6575         * common/scoped_mmap.h: Rename include guard.
6576         * common/scoped_fd.h: Rename include guard.
6577         * common/safe-iterator.h: Rename include guard.
6578         * common/run-time-clock.h: Rename include guard.
6579         * common/refcounted-object.h: Rename include guard.
6580         * common/queue.h: Rename include guard.
6581         * common/ptid.h: Rename include guard.
6582         * common/print-utils.h: Rename include guard.
6583         * common/preprocessor.h: Rename include guard.
6584         * common/pathstuff.h: Rename include guard.
6585         * common/observable.h: Rename include guard.
6586         * common/netstuff.h: Rename include guard.
6587         * common/job-control.h: Rename include guard.
6588         * common/host-defs.h: Rename include guard.
6589         * common/gdb_wait.h: Rename include guard.
6590         * common/gdb_vecs.h: Rename include guard.
6591         * common/gdb_unlinker.h: Rename include guard.
6592         * common/gdb_unique_ptr.h: Rename include guard.
6593         * common/gdb_tilde_expand.h: Rename include guard.
6594         * common/gdb_sys_time.h: Rename include guard.
6595         * common/gdb_string_view.h: Rename include guard.
6596         * common/gdb_splay_tree.h: Rename include guard.
6597         * common/gdb_setjmp.h: Rename include guard.
6598         * common/gdb_ref_ptr.h: Rename include guard.
6599         * common/gdb_optional.h: Rename include guard.
6600         * common/gdb_locale.h: Rename include guard.
6601         * common/gdb_assert.h: Rename include guard.
6602         * common/filtered-iterator.h: Rename include guard.
6603         * common/filestuff.h: Rename include guard.
6604         * common/fileio.h: Rename include guard.
6605         * common/environ.h: Rename include guard.
6606         * common/common-utils.h: Rename include guard.
6607         * common/common-types.h: Rename include guard.
6608         * common/common-regcache.h: Rename include guard.
6609         * common/common-inferior.h: Rename include guard.
6610         * common/common-gdbthread.h: Rename include guard.
6611         * common/common-exceptions.h: Rename include guard.
6612         * common/common-defs.h: Rename include guard.
6613         * common/common-debug.h: Rename include guard.
6614         * common/cleanups.h: Rename include guard.
6615         * common/buffer.h: Rename include guard.
6616         * common/btrace-common.h: Rename include guard.
6617         * common/break-common.h: Rename include guard.
6618         * cli/cli-utils.h: Rename include guard.
6619         * cli/cli-style.h: Rename include guard.
6620         * cli/cli-setshow.h: Rename include guard.
6621         * cli/cli-script.h: Rename include guard.
6622         * cli/cli-interp.h: Rename include guard.
6623         * cli/cli-decode.h: Rename include guard.
6624         * cli/cli-cmds.h: Rename include guard.
6625         * charset-list.h: Add include guard.
6626         * buildsym-legacy.h: Rename include guard.
6627         * bfin-tdep.h: Add include guard.
6628         * ax.h: Rename include guard.
6629         * arm-linux-tdep.h: Add include guard.
6630         * arm-fbsd-tdep.h: Add include guard.
6631         * arch/xtensa.h: Rename include guard.
6632         * arch/tic6x.h: Add include guard.
6633         * arch/i386.h: Add include guard.
6634         * arch/arm.h: Rename include guard.
6635         * arch/arm-linux.h: Rename include guard.
6636         * arch/arm-get-next-pcs.h: Rename include guard.
6637         * arch/amd64.h: Add include guard.
6638         * arch/aarch64-insn.h: Rename include guard.
6639         * arch-utils.h: Rename include guard.
6640         * annotate.h: Add include guard.
6641         * amd64-darwin-tdep.h: Rename include guard.
6642         * aarch64-linux-tdep.h: Add include guard.
6643         * aarch64-fbsd-tdep.h: Add include guard.
6644         * aarch32-linux-nat.h: Add include guard.
6645
6646 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6647
6648         * macrotab.c (macro_define_internal): New function that
6649         factorizes macro_define_object_internal and macro_define_function
6650         code.
6651         (macro_define_object_internal): Use macro_define_internal.
6652         (macro_define_function): Likewise.
6653
6654 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6655
6656         * macrocmd.c (extract_identifier): Return
6657         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
6658         callers.
6659
6660 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
6661
6662         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
6663
6664 2019-02-05  Tom Tromey  <tom@tromey.com>
6665
6666         * target.c (target_stack::unpush): Move assertion earlier.
6667
6668 2019-01-30  Tom Tromey  <tom@tromey.com>
6669
6670         PR python/23615:
6671         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
6672         (gdbpy_parse_and_eval): Likewise.
6673         * python/python-internal.h (gdbpy_allow_threads): New class.
6674
6675 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
6676
6677         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
6678         (aarch64_fbsd_fpregmap): Move earlier.
6679         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
6680         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6681         instead of individual calls to trad_frame_set_reg_addr.
6682         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
6683         earlier.
6684         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
6685         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6686         instead of individual calls to trad_frame_set_reg_addr.
6687
6688 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
6689
6690         * CONTRIBUTE: Replace contribution list with wiki link.
6691
6692 2019-01-25  Tom Tromey  <tom@tromey.com>
6693
6694         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
6695
6696 2019-01-25  Tom Tromey  <tom@tromey.com>
6697
6698         * xtensa-linux-nat.c: Fix common/ includes.
6699         * xml-support.h: Fix common/ includes.
6700         * xml-support.c: Fix common/ includes.
6701         * x86-linux-nat.c: Fix common/ includes.
6702         * windows-nat.c: Fix common/ includes.
6703         * varobj.h: Fix common/ includes.
6704         * varobj.c: Fix common/ includes.
6705         * value.c: Fix common/ includes.
6706         * valops.c: Fix common/ includes.
6707         * utils.c: Fix common/ includes.
6708         * unittests/xml-utils-selftests.c: Fix common/ includes.
6709         * unittests/utils-selftests.c: Fix common/ includes.
6710         * unittests/unpack-selftests.c: Fix common/ includes.
6711         * unittests/tracepoint-selftests.c: Fix common/ includes.
6712         * unittests/style-selftests.c: Fix common/ includes.
6713         * unittests/string_view-selftests.c: Fix common/ includes.
6714         * unittests/scoped_restore-selftests.c: Fix common/ includes.
6715         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
6716         * unittests/scoped_fd-selftests.c: Fix common/ includes.
6717         * unittests/rsp-low-selftests.c: Fix common/ includes.
6718         * unittests/parse-connection-spec-selftests.c: Fix common/
6719         includes.
6720         * unittests/optional-selftests.c: Fix common/ includes.
6721         * unittests/offset-type-selftests.c: Fix common/ includes.
6722         * unittests/observable-selftests.c: Fix common/ includes.
6723         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
6724         * unittests/memrange-selftests.c: Fix common/ includes.
6725         * unittests/memory-map-selftests.c: Fix common/ includes.
6726         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
6727         * unittests/function-view-selftests.c: Fix common/ includes.
6728         * unittests/environ-selftests.c: Fix common/ includes.
6729         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
6730         * unittests/common-utils-selftests.c: Fix common/ includes.
6731         * unittests/cli-utils-selftests.c: Fix common/ includes.
6732         * unittests/array-view-selftests.c: Fix common/ includes.
6733         * ui-file.c: Fix common/ includes.
6734         * tui/tui-io.c: Fix common/ includes.
6735         * tracepoint.h: Fix common/ includes.
6736         * tracepoint.c: Fix common/ includes.
6737         * tracefile-tfile.c: Fix common/ includes.
6738         * top.h: Fix common/ includes.
6739         * top.c: Fix common/ includes.
6740         * thread.c: Fix common/ includes.
6741         * target/waitstatus.h: Fix common/ includes.
6742         * target/waitstatus.c: Fix common/ includes.
6743         * target.h: Fix common/ includes.
6744         * target.c: Fix common/ includes.
6745         * target-memory.c: Fix common/ includes.
6746         * target-descriptions.c: Fix common/ includes.
6747         * symtab.h: Fix common/ includes.
6748         * symfile.c: Fix common/ includes.
6749         * stap-probe.c: Fix common/ includes.
6750         * spu-linux-nat.c: Fix common/ includes.
6751         * sparc-nat.c: Fix common/ includes.
6752         * source.c: Fix common/ includes.
6753         * solib.c: Fix common/ includes.
6754         * solib-target.c: Fix common/ includes.
6755         * ser-unix.c: Fix common/ includes.
6756         * ser-tcp.c: Fix common/ includes.
6757         * ser-pipe.c: Fix common/ includes.
6758         * ser-base.c: Fix common/ includes.
6759         * selftest-arch.c: Fix common/ includes.
6760         * s12z-tdep.c: Fix common/ includes.
6761         * rust-exp.y: Fix common/ includes.
6762         * rs6000-aix-tdep.c: Fix common/ includes.
6763         * riscv-tdep.c: Fix common/ includes.
6764         * remote.c: Fix common/ includes.
6765         * remote-notif.h: Fix common/ includes.
6766         * remote-fileio.h: Fix common/ includes.
6767         * remote-fileio.c: Fix common/ includes.
6768         * regcache.h: Fix common/ includes.
6769         * regcache.c: Fix common/ includes.
6770         * record-btrace.c: Fix common/ includes.
6771         * python/python.c: Fix common/ includes.
6772         * python/py-type.c: Fix common/ includes.
6773         * python/py-inferior.c: Fix common/ includes.
6774         * progspace.h: Fix common/ includes.
6775         * producer.c: Fix common/ includes.
6776         * procfs.c: Fix common/ includes.
6777         * proc-api.c: Fix common/ includes.
6778         * printcmd.c: Fix common/ includes.
6779         * ppc-linux-nat.c: Fix common/ includes.
6780         * parser-defs.h: Fix common/ includes.
6781         * osdata.c: Fix common/ includes.
6782         * obsd-nat.c: Fix common/ includes.
6783         * nat/x86-linux.c: Fix common/ includes.
6784         * nat/x86-linux-dregs.c: Fix common/ includes.
6785         * nat/x86-dregs.h: Fix common/ includes.
6786         * nat/x86-dregs.c: Fix common/ includes.
6787         * nat/ppc-linux.c: Fix common/ includes.
6788         * nat/mips-linux-watch.h: Fix common/ includes.
6789         * nat/mips-linux-watch.c: Fix common/ includes.
6790         * nat/linux-waitpid.c: Fix common/ includes.
6791         * nat/linux-ptrace.h: Fix common/ includes.
6792         * nat/linux-ptrace.c: Fix common/ includes.
6793         * nat/linux-procfs.c: Fix common/ includes.
6794         * nat/linux-personality.c: Fix common/ includes.
6795         * nat/linux-osdata.c: Fix common/ includes.
6796         * nat/linux-namespaces.c: Fix common/ includes.
6797         * nat/linux-btrace.h: Fix common/ includes.
6798         * nat/linux-btrace.c: Fix common/ includes.
6799         * nat/fork-inferior.c: Fix common/ includes.
6800         * nat/amd64-linux-siginfo.c: Fix common/ includes.
6801         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
6802         * nat/aarch64-linux.c: Fix common/ includes.
6803         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
6804         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
6805         * namespace.h: Fix common/ includes.
6806         * mips-linux-tdep.c: Fix common/ includes.
6807         * minsyms.c: Fix common/ includes.
6808         * mi/mi-parse.h: Fix common/ includes.
6809         * mi/mi-main.c: Fix common/ includes.
6810         * mi/mi-cmd-env.c: Fix common/ includes.
6811         * memrange.h: Fix common/ includes.
6812         * memattr.c: Fix common/ includes.
6813         * maint.h: Fix common/ includes.
6814         * maint.c: Fix common/ includes.
6815         * main.c: Fix common/ includes.
6816         * machoread.c: Fix common/ includes.
6817         * location.c: Fix common/ includes.
6818         * linux-thread-db.c: Fix common/ includes.
6819         * linux-nat.c: Fix common/ includes.
6820         * linux-fork.c: Fix common/ includes.
6821         * inline-frame.c: Fix common/ includes.
6822         * infrun.c: Fix common/ includes.
6823         * inflow.c: Fix common/ includes.
6824         * inferior.h: Fix common/ includes.
6825         * inferior.c: Fix common/ includes.
6826         * infcmd.c: Fix common/ includes.
6827         * inf-ptrace.c: Fix common/ includes.
6828         * inf-child.c: Fix common/ includes.
6829         * ia64-linux-nat.c: Fix common/ includes.
6830         * i387-tdep.c: Fix common/ includes.
6831         * i386-tdep.c: Fix common/ includes.
6832         * i386-linux-tdep.c: Fix common/ includes.
6833         * i386-linux-nat.c: Fix common/ includes.
6834         * i386-go32-tdep.c: Fix common/ includes.
6835         * i386-fbsd-tdep.c: Fix common/ includes.
6836         * i386-fbsd-nat.c: Fix common/ includes.
6837         * guile/scm-type.c: Fix common/ includes.
6838         * guile/guile.c: Fix common/ includes.
6839         * go32-nat.c: Fix common/ includes.
6840         * gnu-nat.c: Fix common/ includes.
6841         * gdbthread.h: Fix common/ includes.
6842         * gdbarch-selftests.c: Fix common/ includes.
6843         * gdb_usleep.c: Fix common/ includes.
6844         * gdb_select.h: Fix common/ includes.
6845         * gdb_bfd.c: Fix common/ includes.
6846         * gcore.c: Fix common/ includes.
6847         * fork-child.c: Fix common/ includes.
6848         * findvar.c: Fix common/ includes.
6849         * fbsd-nat.c: Fix common/ includes.
6850         * event-top.c: Fix common/ includes.
6851         * event-loop.c: Fix common/ includes.
6852         * dwarf2read.c: Fix common/ includes.
6853         * dwarf2loc.c: Fix common/ includes.
6854         * dwarf2-frame.c: Fix common/ includes.
6855         * dwarf-index-cache.c: Fix common/ includes.
6856         * dtrace-probe.c: Fix common/ includes.
6857         * disasm-selftests.c: Fix common/ includes.
6858         * defs.h: Fix common/ includes.
6859         * csky-tdep.c: Fix common/ includes.
6860         * cp-valprint.c: Fix common/ includes.
6861         * cp-support.h: Fix common/ includes.
6862         * cp-support.c: Fix common/ includes.
6863         * corelow.c: Fix common/ includes.
6864         * completer.h: Fix common/ includes.
6865         * completer.c: Fix common/ includes.
6866         * compile/compile.c: Fix common/ includes.
6867         * compile/compile-loc2c.c: Fix common/ includes.
6868         * compile/compile-cplus-types.c: Fix common/ includes.
6869         * compile/compile-cplus-symbols.c: Fix common/ includes.
6870         * command.h: Fix common/ includes.
6871         * cli/cli-dump.c: Fix common/ includes.
6872         * cli/cli-cmds.c: Fix common/ includes.
6873         * charset.c: Fix common/ includes.
6874         * build-id.c: Fix common/ includes.
6875         * btrace.h: Fix common/ includes.
6876         * btrace.c: Fix common/ includes.
6877         * breakpoint.h: Fix common/ includes.
6878         * breakpoint.c: Fix common/ includes.
6879         * ax.h:
6880         (enum agent_op): Fix common/ includes.
6881         * ax-general.c (struct aop_map): Fix common/ includes.
6882         * ax-gdb.c: Fix common/ includes.
6883         * auxv.c: Fix common/ includes.
6884         * auto-load.c: Fix common/ includes.
6885         * arm-tdep.c: Fix common/ includes.
6886         * arch/riscv.c: Fix common/ includes.
6887         * arch/ppc-linux-common.c: Fix common/ includes.
6888         * arch/i386.c: Fix common/ includes.
6889         * arch/arm.c: Fix common/ includes.
6890         * arch/arm-linux.c: Fix common/ includes.
6891         * arch/arm-get-next-pcs.c: Fix common/ includes.
6892         * arch/amd64.c: Fix common/ includes.
6893         * arch/aarch64.c: Fix common/ includes.
6894         * arch/aarch64-insn.c: Fix common/ includes.
6895         * arch-utils.c: Fix common/ includes.
6896         * amd64-windows-tdep.c: Fix common/ includes.
6897         * amd64-tdep.c: Fix common/ includes.
6898         * amd64-sol2-tdep.c: Fix common/ includes.
6899         * amd64-obsd-tdep.c: Fix common/ includes.
6900         * amd64-nbsd-tdep.c: Fix common/ includes.
6901         * amd64-linux-tdep.c: Fix common/ includes.
6902         * amd64-linux-nat.c: Fix common/ includes.
6903         * amd64-fbsd-tdep.c: Fix common/ includes.
6904         * amd64-fbsd-nat.c: Fix common/ includes.
6905         * amd64-dicos-tdep.c: Fix common/ includes.
6906         * amd64-darwin-tdep.c: Fix common/ includes.
6907         * agent.c: Fix common/ includes.
6908         * ada-lang.h: Fix common/ includes.
6909         * ada-lang.c: Fix common/ includes.
6910         * aarch64-tdep.c: Fix common/ includes.
6911
6912 2019-01-25  Tom Tromey  <tom@tromey.com>
6913
6914         * common/create-version.sh: Use common/version.h.
6915
6916 2019-01-24  Pedro Alves  <palves@redhat.com>
6917
6918         * infrun.c (signal_stop, signal_print, signal_program)
6919         (signal_catch, signal_pass): Now arrays instead of pointers.
6920         (update_signals_program_target, do_target_resume)
6921         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
6922         * linux-nat.c (linux_nat_target::pass_signals)
6923         (linux_nat_target::create_inferior, linux_nat_target::attach):
6924         Adjust.
6925         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
6926         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
6927         * procfs.c (procfs_target::pass_signals): Adjust.
6928         * record-full.c (record_full_target::resume): Adjust.
6929         * remote.c (remote_target::pass_signals)
6930         (remote_target::program_signals): Adjust.
6931         * target-debug.h (target_debug_print_signals): Now takes a
6932         gdb::array_view as parameter.  Adjust.
6933         * target.h (target_ops) <pass_signals, program_signals>: Replace
6934         pointer and length parameters with gdb::array_view.
6935         (target_pass_signals, target_program_signals): Likewise.
6936         * target-delegates.c: Regenerate.
6937
6938 2019-01-24  Pedro Alves  <palves@redhat.com>
6939
6940         * common/forward-scope-exit.h
6941         (forward_scope_exit::forward_scope_exit): Pass arguments to
6942         m_bind_function directly, instead of creating a std::bind and
6943         copying that.
6944
6945 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
6946
6947         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6948         for static members.
6949         (pass_in_v_vfp_candidate): Likewise.
6950
6951 2019-01-23  Tom Tromey  <tom@tromey.com>
6952             Pedro Alves  <palves@redhat.com>
6953
6954         * regcache.c (class regcache_invalidator): Remove.
6955         (regcache::raw_write): Use make_scope_exit.
6956
6957 2019-01-23  Tom Tromey  <tom@tromey.com>
6958
6959         * ui-out.h (class ui_out_emit_type): Update comment.
6960
6961 2019-01-23  Tom Tromey  <tom@tromey.com>
6962
6963         * infrun.c (fetch_inferior_event): Update comment.
6964
6965 2019-01-23  Tom Tromey  <tom@tromey.com>
6966             Pedro Alves  <palves@redhat.com>
6967
6968         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
6969         parameter.
6970         (fetch_inferior_event): Use SCOPE_EXIT.
6971
6972
6973 2019-01-23  Tom Tromey  <tom@tromey.com>
6974             Pedro Alves  <palves@redhat.com>
6975
6976         * infrun.c (disable_thread_events): Delete.
6977         (stop_all_threads): Use SCOPE_EXIT.
6978
6979 2019-01-23  Tom Tromey  <tom@tromey.com>
6980             Pedro Alves  <palves@redhat.com>
6981
6982         * symfile.c: Include forward-scope-exit.h.
6983         (clear_symtab_users_cleanup): Replace forward declaration with
6984         a FORWARD_SCOPE_EXIT.
6985         (syms_from_objfile_1): Use the forward_scope_exit and
6986         gdb::optional instead of cleanup_function.
6987         (reread_symbols): Use the forward_scope_exit instead of
6988         cleanup_function.
6989         (clear_symtab_users_cleanup): Remove function.
6990
6991 2019-01-23  Tom Tromey  <tom@tromey.com>
6992             Pedro Alves  <palves@redhat.com>
6993
6994         * linux-nat.c: Include scope-exit.h.
6995         (cleanup_target_stop): Remove.
6996         (linux_nat_target::static_tracepoint_markers_by_strid): Use
6997         SCOPE_EXIT.
6998
6999 2019-01-23  Tom Tromey  <tom@tromey.com>
7000             Pedro Alves  <palves@redhat.com>
7001
7002         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
7003         (call_function_by_hand_dummy): Use SCOPE_EXIT.
7004
7005 2019-01-23  Tom Tromey  <tom@tromey.com>
7006             Andrew Burgess  <andrew.burgess@embecosm.com>
7007             Pedro Alves  <palves@redhat.com>
7008
7009         * infrun.c (fetch_inferior_event): Use scope_exit.
7010         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
7011         * top.c (execute_command): Use scope_exit.
7012         * breakpoint.c (bpstat_do_actions): Use scope_exit.
7013         * utils.c (do_bpstat_clear_actions_cleanup)
7014         (make_bpstat_clear_actions_cleanup): Remove.
7015
7016 2019-01-23  Tom Tromey  <tom@tromey.com>
7017             Pedro Alves  <palves@redhat.com>
7018
7019         * infrun.c: Include "common/scope-exit.h"
7020         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
7021         (wait_for_inferior): Use SCOPE_EXIT.
7022         (fetch_inferior_event): Use scope_exit.
7023
7024 2019-01-23  Tom Tromey  <tom@tromey.com>
7025             Pedro Alves  <palves@redhat.com>
7026
7027         * breakpoint.c (create_breakpoint): Remove cleanup.
7028
7029 2019-01-23  Tom Tromey  <tom@tromey.com>
7030             Andrew Burgess  <andrew.burgess@embecosm.com>
7031             Pedro Alves  <palves@redhat.com>
7032
7033 2019-01-23  Pedro Alves  <palves@redhat.com>
7034
7035         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
7036
7037 2019-01-23  Pedro Alves  <palves@redhat.com>
7038             Andrew Burgess  <andrew.burgess@embecosm.com>
7039
7040         * gdbthread.h: Include "common/forward-scope-exit.h".
7041         (scoped_finish_thread_state): Redefine custom class in terms of
7042         forward_scope_exit.
7043
7044 2019-01-23  Pedro Alves  <palves@redhat.com>
7045             Andrew Burgess  <andrew.burgess@embecosm.com>
7046
7047         * common/forward-scope-exit.h: New file.
7048
7049 2019-01-23  Pedro Alves  <palves@redhat.com>
7050             Andrew Burgess  <andrew.burgess@embecosm.com>
7051             Tom Tromey  <tom@tromey.com>
7052
7053         * common/scope-exit.h: New file.
7054
7055 2019-01-23  Pedro Alves  <palves@redhat.com>
7056
7057         * common/preprocessor.h (ESC): Rename to ...
7058         (ESC_PARENS): ... this.
7059         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
7060         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
7061
7062 2019-01-23  Tom Tromey  <tom@tromey.com>
7063
7064         * language.h (class scoped_switch_to_sym_language_if_auto):
7065         Initialize m_lang in both cases.
7066
7067 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
7068
7069         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
7070         with XCNEW.
7071
7072 2019-01-22  Tom Tromey  <tom@tromey.com>
7073
7074         * corelow.c: Do not include sys/file.h.
7075
7076 2019-01-22  Tom Tromey  <tom@tromey.com>
7077
7078         * tui/tui-wingeneral.h: Include gdb_curses.h.
7079
7080 2019-01-22  Tom Tromey  <tom@tromey.com>
7081
7082         * source-cache.h (class source_cache) <get_source_lines,
7083         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
7084
7085 2019-01-22  Tom Tromey  <tom@tromey.com>
7086
7087         * remote-fileio.h (struct remote_target): Declare.
7088
7089 2019-01-22  Tom Tromey  <tom@tromey.com>
7090
7091         * python/py-arch.c: Do not include py-ref.h.
7092         * python/py-bpevent.c: Do not include py-ref.h.
7093         * python/py-cmd.c: Do not include py-ref.h.
7094         * python/py-continueevent.c: Do not include py-ref.h.
7095         * python/py-event.h: Do not include py-ref.h.
7096         * python/py-evtregistry.c: Do not include py-ref.h.
7097         * python/py-finishbreakpoint.c: Do not include py-ref.h.
7098         * python/py-frame.c: Do not include py-ref.h.
7099         * python/py-framefilter.c: Do not include py-ref.h.
7100         * python/py-function.c: Do not include py-ref.h.
7101         * python/py-infevents.c: Do not include py-ref.h.
7102         * python/py-linetable.c: Do not include py-ref.h.
7103         * python/py-objfile.c: Do not include py-ref.h.
7104         * python/py-param.c: Do not include py-ref.h.
7105         * python/py-prettyprint.c: Do not include py-ref.h.
7106         * python/py-progspace.c: Do not include py-ref.h.
7107         * python/py-symbol.c: Do not include py-ref.h.
7108         * python/py-symtab.c: Do not include py-ref.h.
7109         * python/py-type.c: Do not include py-ref.h.
7110         * python/py-unwind.c: Do not include py-ref.h.
7111         * python/py-utils.c: Do not include py-ref.h.
7112         * python/py-value.c: Do not include py-ref.h.
7113         * python/py-varobj.c: Do not include py-ref.h.
7114         * python/py-xmethods.c: Do not include py-ref.h.
7115         * python/python.c: Do not include py-ref.h.
7116         * varobj.c: Do not include py-ref.h.
7117
7118 2019-01-22  Tom Tromey  <tom@tromey.com>
7119
7120         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
7121         keyword for bcache.
7122
7123 2019-01-22  Tom Tromey  <tom@tromey.com>
7124
7125         * compile/compile-cplus-types.c: Remove a comment by #include.
7126
7127 2019-01-22  Tom Tromey  <tom@tromey.com>
7128
7129         * compile/gcc-c-plugin.h: Include compile-internal.h.
7130
7131 2019-01-22  Tom Tromey  <tom@tromey.com>
7132
7133         * stabsread.c (EXTERN): Do not define.
7134         (symnum, next_symbol_text_func, processing_gcc_compilation)
7135         (within_function, global_sym_chain, global_stabs)
7136         (previous_stab_code, this_object_header_files)
7137         (n_this_object_header_files)
7138         (n_allocated_this_object_header_files): Define.
7139         * stabsread.h (EXTERN): Never define.  Use "extern".
7140
7141 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7142
7143         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
7144         history_value.
7145
7146 2019-01-21  Tom Tromey  <tom@tromey.com>
7147
7148         * ui-out.c: Fix includes.
7149         * tui/tui-source.c: Fix includes.
7150         * target.c: Fix includes.
7151         * remote.c: Fix includes.
7152         * regcache.c: Fix includes.
7153         * python/py-block.c: Fix includes.
7154         * printcmd.c: Fix includes.
7155         * or1k-tdep.c: Fix includes.
7156         * mi/mi-main.c: Fix includes.
7157         * m32r-tdep.c: Fix includes.
7158         * csky-tdep.c: Fix includes.
7159         * compile/compile-cplus-types.c: Fix includes.
7160         * cli/cli-interp.c: Fix includes.
7161
7162 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
7163
7164         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7165         for padding.
7166
7167 2019-01-16  Tom Tromey  <tom@tromey.com>
7168
7169         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
7170         earlier.
7171         (struct objfile) <msymbols_range>: Move from top level.
7172         <msymbols>: New method.
7173         (class objfile_msymbols): Remove.
7174         * symtab.c (default_collect_symbol_completion_matches_break_on):
7175         Update.
7176         * symmisc.c (dump_msymbols): Update.
7177         * stabsread.c (scan_file_globals): Update.
7178         * objc-lang.c (info_selectors_command, info_classes_command)
7179         (find_methods): Update.
7180         * minsyms.c (find_solib_trampoline_target): Update.
7181         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
7182         * coffread.c (coff_symfile_read): Update.
7183         * ada-lang.c (ada_lookup_simple_minsym)
7184         (ada_collect_symbol_completion_matches): Update.
7185
7186 2019-01-16  Tom Tromey  <tom@tromey.com>
7187
7188         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
7189         type.  Remove no-argument constructor.
7190         <iterator::operator++>: Simplify.
7191         <begin>: Update.
7192         <end>: Use minimal_symbol_count.
7193
7194 2019-01-16  Tom Tromey  <tom@tromey.com>
7195
7196         * objfiles.h (struct objfile) <psymtabs>: New method.
7197         (class objfile_psymtabs): Remove.
7198         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
7199         typedef.
7200         <range>: New method.
7201         (require_partial_symbols): Change return type.
7202         * psymtab.c (require_partial_symbols)
7203         (psym_expand_symtabs_matching): Update.
7204         * mdebugread.c (parse_partial_symbols): Update.
7205         * dbxread.c (dbx_end_psymtab): Update.
7206
7207 2019-01-15  Tom Tromey  <tom@tromey.com>
7208
7209         * symtab.c (lookup_objfile_from_block)
7210         (lookup_symbol_in_objfile_symtabs)
7211         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
7212         (find_line_symtab, info_sources_command)
7213         (default_collect_symbol_completion_matches_break_on)
7214         (make_source_files_completion_list): Update.
7215         * symmisc.c (print_objfile_statistics, dump_objfile)
7216         (maintenance_print_symbols, maintenance_info_symtabs)
7217         (maintenance_check_symtabs, maintenance_info_line_tables):
7218         Update.
7219         * source.c (select_source_symtab)
7220         (forget_cached_source_info_for_objfile): Update.
7221         * objfiles.h (class objfile_compunits): Remove.
7222         (struct objfile) <compunits_range>: New typedef.
7223         (compunits): New method.
7224         * objfiles.c (objfile_relocate1): Update.
7225         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7226         * maint.c (count_symtabs_and_blocks): Update.
7227         * linespec.c (iterate_over_all_matching_symtabs): Update.
7228         * cp-support.c (add_symbol_overload_list_qualified): Update.
7229         * coffread.c (coff_symtab_read): Update.
7230         * ada-lang.c (add_nonlocal_symbols)
7231         (ada_collect_symbol_completion_matches)
7232         (ada_add_global_exceptions): Update.
7233
7234 2019-01-15  Tom Tromey  <tom@tromey.com>
7235
7236         * progspace.h (program_space) <objfiles_safe_range>: New
7237         typedef.
7238         <objfiles_safe>: New method.
7239         * objfiles.h (class all_objfiles_safe): Remove.
7240         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
7241         * jit.c (jit_inferior_exit_hook): Update.
7242
7243 2019-01-17  Tom Tromey  <tom@tromey.com>
7244
7245         * progspace.h (program_space) <objfiles_range>: New typedef.
7246         <objfiles>: New method.
7247         <objfiles_head>: Rename from objfiles.
7248         (object_files): Update.
7249         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
7250         * guile/scm-pretty-print.c
7251         (ppscm_find_pretty_printer_from_objfiles): Update.
7252         * guile/scm-objfile.c (gdbscm_objfiles): Update.
7253         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
7254         Update.
7255         * python/py-progspace.c (pspy_get_objfiles): Update.
7256         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7257         Update.
7258         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7259         (objfpy_lookup_objfile_by_build_id): Update.
7260         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7261         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7262         Update.
7263         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7264         (expand_symtab_containing_pc, lookup_objfile_from_block)
7265         (lookup_static_symbol, basic_lookup_transparent_type)
7266         (find_pc_sect_compunit_symtab, find_symbol_at_address)
7267         (find_line_symtab, info_sources_command)
7268         (default_collect_symbol_completion_matches_break_on)
7269         (make_source_files_completion_list, find_main_name): Update.
7270         * symmisc.c (print_symbol_bcache_statistics)
7271         (print_objfile_statistics, maintenance_print_symbols)
7272         (maintenance_print_msymbols, maintenance_print_objfiles)
7273         (maintenance_info_symtabs, maintenance_check_symtabs)
7274         (maintenance_expand_symtabs, maintenance_info_line_tables):
7275         Update.
7276         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
7277         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
7278         (map_overlay_command, unmap_overlay_command)
7279         (simple_overlay_update, expand_symtabs_matching)
7280         (map_symbol_filenames): Update.
7281         * symfile-debug.c (set_debug_symfile): Update.
7282         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
7283         Update.
7284         * source.c (select_source_symtab, forget_cached_source_info):
7285         Update.
7286         * solib.c (solib_read_symbols): Update.
7287         * solib-spu.c (append_ocl_sos): Update.
7288         * psymtab.c (maintenance_print_psymbols)
7289         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
7290         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
7291         * printcmd.c (info_symbol_command): Update.
7292         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
7293         Update.
7294         * objfiles.h (class all_objfiles): Remove.
7295         * objfiles.c (have_partial_symbols, have_full_symbols)
7296         (have_minimal_symbols, qsort_cmp, update_section_map)
7297         (shared_objfile_contains_address_p)
7298         (default_iterate_over_objfiles_in_search_order): Update.
7299         * objc-lang.c (info_selectors_command, info_classes_command)
7300         (find_methods): Update.
7301         * minsyms.c (find_solib_trampoline_target): Update.
7302         * maint.c (maintenance_info_sections)
7303         (maintenance_translate_address, count_symtabs_and_blocks):
7304         Update.
7305         * main.c (captured_main_1): Update.
7306         * linux-thread-db.c (try_thread_db_load_from_pdir)
7307         (has_libpthread): Update.
7308         * linespec.c (iterate_over_all_matching_symtabs)
7309         (search_minsyms_for_name): Update.
7310         * jit.c (jit_find_objf_with_entry_addr): Update.
7311         * hppa-tdep.c (find_unwind_entry)
7312         (hppa_lookup_stub_minimal_symbol): Update.
7313         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
7314         Update.
7315         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7316         (elf_gnu_ifunc_resolve_by_got): Update.
7317         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
7318         * dwarf-index-write.c (save_gdb_index_command): Update.
7319         * cp-support.c (add_symbol_overload_list_qualified): Update.
7320         * breakpoint.c (create_overlay_event_breakpoint)
7321         (create_longjmp_master_breakpoint)
7322         (create_std_terminate_master_breakpoint)
7323         (create_exception_master_breakpoint): Update.
7324         * blockframe.c (find_pc_partial_function): Update.
7325         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
7326         (ada_collect_symbol_completion_matches)
7327         (ada_add_global_exceptions): Update.
7328
7329 2019-01-17  Tom Tromey  <tom@tromey.com>
7330
7331         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
7332         declare VEC.
7333         (solib_target_parse_libraries): Change return type.
7334         (library_list_start_segment, library_list_start_section)
7335         (library_list_end_library, library_list_start_library); Update.
7336         (solib_target_free_library_list): Remove.
7337         (solib_target_parse_libraries): Remove cleanup.  Change return
7338         type.
7339         (solib_target_current_sos): Update.
7340
7341 2019-01-17  Tom Tromey  <tromey@bapiya>
7342
7343         * valprint.c: Replace "the the" with "the".
7344         * symtab.c: Replace "the the" with "the".
7345         * solib.c: Replace "the the" with "the".
7346         * solib-dsbt.c: Replace "the the" with "the".
7347         * linespec.c: Replace "the the" with "the".
7348         * dwarf2loc.h: Replace "the the" with "the".
7349         * amd64-windows-tdep.c: Replace "the the" with "the".
7350         * aarch64-tdep.c: Replace "the the" with "the".
7351
7352 2019-01-16  Keith Seitz  <keiths@redhat.com>
7353
7354         PR gdb/23773
7355         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
7356         <builder>: Rename to ..
7357         <m_builder>: ... this and make private.
7358         (dwarf2_cu::get_builder): New method.  Change all users of
7359         `builder' to use this method.
7360         (dwarf2_start_symtab): Move to ...
7361         (dwarf2_cu::start_symtab): ... here.  Update all callers
7362         (setup_type_unit_groups): Move to ...
7363         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
7364         callers.
7365         (dwarf2_cu::reset_builder): New method.
7366         (process_full_compunit, process_full_type_unit): Use
7367         dwarf2_cu::reset_builder.
7368         (follow_die_offset): Record the ancestor CU if it is different
7369         from the followed DIE's CU.
7370         (follow_die_sig_1): Likewise.
7371
7372 2019-01-15  Tom Tromey  <tom@tromey.com>
7373
7374         * remote.c (class remote_state) <buf>: Now a char_vector.
7375         <buf_size>: Remove.
7376         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
7377         parameter.
7378         (remote_target::getpkt_or_notif_sane_1)
7379         (remote_target::getpkt_sane)
7380         (remote_target::getpkt_or_notif_sane): Likewise.
7381         (class remote_target) <putpkt>: New overload.
7382         (remote_target::read_frame): Change type of "buf_p".  Remove
7383         sizeof_p parameter.
7384         (packet_ok): New overload.
7385         (packet_check_result): New overload.
7386         Update all uses.
7387
7388 2019-01-14  Tom Tromey  <tom@tromey.com>
7389
7390         * remote-notif.c (handle_notification, remote_notif_ack)
7391         (remote_notif_parse): Make "buf" const.
7392         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
7393         const.
7394         (remote_notif_parse, remote_notif_ack, handle_notification):
7395         Likewise.
7396         * remote.c (remote_notif_stop_parse): Make "buf" const.
7397         (remote_target::remote_parse_stop_reply): Make "buf" const.
7398         (remote_notif_stop_ack): Make "buf" const.
7399
7400 2019-01-14  Tom Tromey  <tom@tromey.com>
7401
7402         * remote.c (remote_console_output): Make parameter const.
7403
7404 2019-01-14  Tom Tromey  <tom@tromey.com>
7405
7406         * target-debug.h (target_debug_print_signals): Constify.
7407         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
7408         * procfs.c (procfs_target::pass_signals): Update.
7409         * linux-nat.c (linux_nat_target::pass_signals): Update.
7410         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
7411         * target-delegates.c: Rebuild.
7412         * remote.c (remote_target::program_signals): Update.
7413         (remote_target::pass_signals): Update.
7414         * target.c (target_pass_signals): Constify argument.
7415         (target_program_signals): Likewise.
7416         * target.h (struct target_ops) <pass_signals, program_signals>:
7417         Constify argument.
7418         (target_pass_signals, target_program_signals): Constify argument.
7419
7420 2019-01-14  Tom Tromey  <tom@tromey.com>
7421
7422         PR tui/28819:
7423         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
7424
7425 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
7426
7427         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
7428         field.
7429         * rs6000-tdep.c: Include reggroups.h.
7430         (IS_V_ALIAS_PSEUDOREG): Define.
7431         (rs6000_register_name): Return names for the "vX" aliases.
7432         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
7433         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
7434         aliases.  Call default_register_reggroup_p for all other
7435         pseudo-registers.
7436         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
7437         New functions.
7438         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
7439         Handle "vX" aliases.
7440         (v_alias_pseudo_register_collect): New function.
7441         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
7442         (rs6000_gdbarch_init): Initialize "vX" aliases as
7443         pseudo-registers.  Restore registration of
7444         rs6000_pseudo_register_reggroup_p with
7445         set_tdesc_pseudo_register_reggroup_p.
7446
7447 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
7448
7449         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
7450         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
7451         set_gdbarch_num_pseudo_regs.
7452
7453 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7454
7455         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
7456         Remove arg prefixname, add do_set and do_show.
7457         Add member functions set_list and show_list.
7458         * cli/cli-style.c (class cli_style_option): Update accordingly.
7459         (style_set_list): Move to file scope.
7460         (style_show_list): Likewise.
7461         (set_style): Call help_list.
7462         (show_style): Call cmd_show_list.
7463         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
7464         Update to use the new macro.
7465
7466 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
7467
7468         * ada-lang.c (_initialize_ada_language): Expand the help text
7469         for the "catch exception" command.
7470
7471 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7472
7473         * symtab.c (matching_obj_sections): Initialize obj,
7474         declare it closer to its usage.
7475
7476 2019-01-10  Tom Tromey  <tom@tromey.com>
7477
7478         * thread-iter.h (inf_threads_iterator): Use next_iterator.
7479         (basic_inf_threads_range): Remove.
7480         (inf_threads_range, inf_non_exited_threads_range)
7481         (safe_inf_threads_range): Use next_adapter.
7482
7483 2019-01-10  Keith Seitz  <keiths@redhat.com>
7484
7485         PR gdb/23712
7486         PR symtab/23010
7487         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
7488         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
7489
7490 2019-01-10  Keith Seitz  <keiths@redhat.com>
7491
7492         PR gdb/23712
7493         PR symtab/23010
7494         * dictionary.c (pending_to_vector): Remove.
7495         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7496         Remove _1 suffix, replacing functions of the same name.  Update
7497         all callers.
7498         (dict_create_hashed, dict_create_hashed_expandable)
7499         (dict_create_linear, dict_create_linear_expandable, dict_free)
7500         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
7501         Make functions static.
7502
7503 2019-01-10  Keith Seitz  <keiths@redhat.com>
7504
7505         PR gdb/23712
7506         PR symtab/23010
7507         * dictionary.h (struct dictionary): Replace declaration with
7508         multidictionary.
7509         (dict_create_hashed, dict_create_hashed_expandable)
7510         (dict_create_linear, dict_create_linear_expandable)
7511         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
7512         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
7513         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
7514         taking multidictionary argument.
7515         [ALL_DICT_SYMBOLS]: Update for multidictionary.
7516         * block.h (struct block) <dict>: Change to multidictionary
7517         and rename `multidict'.
7518         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
7519         symmisc.c: Update all dictionary references to multidictionary.
7520
7521 2019-01-10  Keith Seitz  <keiths@redhat.com>
7522
7523         PR gdb/23712
7524         PR symtab/23010
7525         * dictionary.c: Include unordered_map.
7526         (pending_to_vector): New function.
7527         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7528         Rewrite the non-"_1" functions to take vector instead
7529         of linked list.
7530         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
7531         "new" _1 versions of the same name.
7532         (multidictionary): Define.
7533         (std::hash<enum language): New definition.
7534         (collate_pending_symbols_by_language, mdict_create_hashed)
7535         (mdict_create_hashed_expandable, mdict_create_linear)
7536         (mdict_create_linear_expandable, mdict_free)
7537         (find_language_dictionary, create_new_language_dictionary)
7538         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
7539         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
7540         (mdict_size, mdict_empty): New functions.
7541         * dictionary.h (mdict_iterator): Define.
7542
7543 2019-01-10  Pedro Alves  <palves@redhat.com>
7544
7545         * breakpoint.c (read_uploaded_action)
7546         (create_tracepoint_from_upload): Adjust to use
7547         gdb::unique_xmalloc_ptr.
7548         * ctf.c (ctf_write_uploaded_tp):
7549         (SET_ARRAY_FIELD): Use emplace_back.
7550         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
7551         * tracefile-tfile.c (tfile_write_uploaded_tp):
7552         * tracepoint.c (parse_tracepoint_definition): Adjust to use
7553         gdb::unique_xmalloc_ptr.
7554         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
7555         at_string, cond_string, cmd_strings>: Replace char pointers
7556         with gdb::unique_xmalloc_ptr.
7557
7558 2019-01-10  Pedro Alves  <palves@redhat.com>
7559
7560         * solib-target.c (library_list_start_library): Don't xstrdup name.
7561
7562 2019-01-10  Pedro Alves  <palves@redhat.com>
7563
7564         * mdebugread.c (parse_partial_symbols): Use
7565         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
7566
7567 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7568
7569         * linux-fork.c (scoped_switch_fork_info)
7570         <~scoped_switch_fork_info>: Fix incorrect variable name.
7571
7572 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7573
7574         * linux-fork.c (scoped_switch_fork_info)
7575         <scoped_switch_fork_info>: Make explicit.
7576         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
7577
7578 2019-01-10  Tom Tromey  <tom@tromey.com>
7579
7580         * objfiles.h (objfile::reset_psymtabs): Update.
7581         * objfiles.c (objfile::objfile): Update.
7582         * psymtab.h (psymtab_storage::obstack): Update.
7583         (psymtab_storage::m_obstack): Use gdb::optional.
7584         (class psymtab_storage): Update comment.  Remove objfile
7585         parameter.
7586         * psymtab.c (psymtab_storage::psymtab_storage): Update.
7587
7588 2019-01-10  Tom Tromey  <tom@tromey.com>
7589
7590         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
7591         <free_psymtabs>: Now private.
7592         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
7593         (allocate_psymtab): Use new method.
7594
7595 2019-01-10  Tom Tromey  <tom@tromey.com>
7596
7597         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
7598         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
7599         * mdebugread.c (parse_partial_symbols): Use
7600         allocate_dependencies.
7601         * dwarf2read.c (dwarf2_create_include_psymtab): Use
7602         allocate_dependencies.
7603         (process_psymtab_comp_unit_reader)
7604         (build_type_psymtab_dependencies): Likewise.
7605         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
7606
7607 2019-01-10  Tom Tromey  <tom@tromey.com>
7608
7609         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
7610         PSYMBOL_SET_LANGUAGE.
7611         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
7612
7613 2019-01-10  Tom Tromey  <tom@tromey.com>
7614
7615         * psymtab.h (psymtab_storage::obstack): New method.
7616         <m_obstack>: Rename from obstack; now private.
7617         * psymtab.c (psymtab_storage): Update.
7618         * dwarf2read.c (create_addrmap_from_index)
7619         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
7620         Update.
7621
7622 2019-01-10  Tom Tromey  <tom@tromey.com>
7623
7624         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
7625         * objfiles.h (objfile::reset_psymtabs): New method.
7626
7627 2019-01-10  Tom Tromey  <tom@tromey.com>
7628
7629         * symmisc.c (print_symbol_bcache_statistics): Update.
7630         (print_objfile_statistics): Update.
7631         * symfile.c (reread_symbols): Update.
7632         * psymtab.h (class psymtab_storage): New.
7633         * psymtab.c (psymtab_storage): New constructor.
7634         (~psymtab_storage): New destructor.
7635         (require_partial_symbols): Update.
7636         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
7637         (find_pc_sect_psymtab, find_pc_sect_psymbol)
7638         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
7639         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
7640         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
7641         (start_psymtab_common, end_psymtab_common)
7642         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
7643         (allocate_psymtab): Update.
7644         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
7645         Update.
7646         (dump_psymtab_addrmap, maintenance_print_psymbols)
7647         (maintenance_check_psymtabs): Update.
7648         (class objfile_psymtabs): Move to objfiles.h.
7649         * psympriv.h (discard_psymtab): Now inline.
7650         (psymtab_discarder::psymtab_discarder): Update.
7651         (psymtab_discarder::~psymtab_discarder): Update.
7652         (ALL_OBJFILE_PSYMTABS): Rewrite.
7653         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
7654         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
7655         Remove fields.
7656         <partial_symtabs>: New field.
7657         (class objfile_psymtabs): Move from psymtab.h.  Update.
7658         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
7659         psymbol_cache.
7660         (objfile::~objfile): Don't destroy psymbol_cache.
7661         * mdebugread.c (parse_partial_symbols): Update.
7662         * dwarf2read.c (create_addrmap_from_index)
7663         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
7664         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
7665         (add_partial_subprogram, dwarf2_ranges_read): Update.
7666         * dwarf-index-write.c (write_address_map)
7667         (write_one_signatured_type, recursively_write_psymbols)
7668         (class debug_names, class debug_names, write_psymtabs_to_index):
7669         Update.
7670
7671 2019-01-10  Tom Tromey  <tom@tromey.com>
7672
7673         * symtab.h (SYMBOL_SET_NAMES): Update.
7674         (symbol_set_names): Update.
7675         (MSYMBOL_SET_NAMES): Update.
7676         * symtab.c (symbol_set_names): Change argument to be an
7677         objfile_per_bfd_storage.
7678         * psymtab.c (add_psymbol_to_bcache): Update.
7679         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
7680
7681 2019-01-10  Tom Tromey  <tom@tromey.com>
7682
7683         * symtab.c (create_demangled_names_hash): Change argument to be an
7684         objfile_per_bfd_storage.
7685         (symbol_set_names): Update.
7686
7687 2019-01-10  Tom Tromey  <tom@tromey.com>
7688
7689         * xcoffread.c (xcoff_initial_scan): Unconditionally call
7690         init_psymbol_list.
7691         * psymtab.c (init_psymbol_list): Do nothing if already called.
7692         * psympriv.h (init_psymbol_list): Add comment.
7693         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
7694         init_psymbol_list.
7695         * dbxread.c (dbx_symfile_read): Unconditionally call
7696         init_psymbol_list.
7697
7698 2019-01-10  Tom Tromey  <tom@tromey.com>
7699
7700         * xcoffread.c (scan_xcoff_symtab): Update.
7701         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
7702         "where".
7703         * mdebugread.c (parse_partial_symbols)
7704         (handle_psymbol_enumerators): Update.
7705         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
7706         * dbxread.c (read_dbx_symtab): Update.
7707         * psympriv.h (psymbol_placement): New enum.
7708         (add_psymbol_to_list): Update.
7709
7710 2019-01-10  Tom Tromey  <tom@tromey.com>
7711
7712         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
7713         static_psymbols parameters.
7714         (scan_xcoff_symtab): Update.
7715         * psymtab.c (start_psymtab_common): Remove global_psymbols and
7716         static_psymbols parameters.
7717         * psympriv.h (start_psymtab_common): Update.
7718         * mdebugread.c (parse_partial_symbols): Update.
7719         * dwarf2read.c (create_partial_symtab): Update.
7720         * dbxread.c (read_dbx_symtab): Update.
7721         (start_psymtab): Remove global_psymbols and static_psymbols
7722         parameters.
7723
7724 2019-01-10  Tom Tromey  <tom@tromey.com>
7725
7726         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
7727         * psymtab.c (allocate_psymtab): Add comment.
7728         * psympriv.h (allocate_psymtab): Add comment.
7729         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
7730         initializations.
7731         * dbxread.c (dbx_end_psymtab): Remove some initializations.
7732
7733 2019-01-10  Tom Tromey  <tom@tromey.com>
7734
7735         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7736         Don't declare.
7737         * mipsread.c: Include mdebugread.h.
7738         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7739         Declare.
7740         * elfread.c: Include mdebugread.h.
7741
7742 2019-01-09  Tom Tromey  <tom@tromey.com>
7743
7744         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
7745         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
7746         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
7747         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
7748         (psym_lookup_symbol, psym_find_last_source_symtab)
7749         (psym_forget_cached_source_info, psym_print_stats)
7750         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
7751         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
7752         (psym_map_matching_symbols, psym_expand_symtabs_matching)
7753         (psym_find_compunit_symtab_by_address)
7754         (maintenance_print_psymbols, maintenance_info_psymtabs)
7755         (maintenance_check_psymtabs): Use ranged for.
7756         * psymtab.h (class objfile_psymtabs): New.
7757         (require_partial_symbols): Return objfile_psymtabs.
7758         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
7759
7760 2019-01-09  Tom Tromey  <tom@tromey.com>
7761
7762         * symfile.c (overlay_invalidate_all, find_pc_overlay)
7763         (find_pc_mapped_section, list_overlays_command)
7764         (map_overlay_command, unmap_overlay_command)
7765         (simple_overlay_update): Use all_objfiles.
7766         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
7767         * printcmd.c (info_symbol_command): Use all_objfiles.
7768         * objfiles.h (ALL_OBJSECTIONS): Remove.
7769         * maint.c (maintenance_translate_address): Use all_objfiles.
7770         * gcore.c (gcore_create_callback): Use all_objfiles.
7771         (objfile_find_memory_regions): Likewise.
7772
7773 2019-01-09  Tom Tromey  <tom@tromey.com>
7774
7775         * symtab.c (find_line_symtab, info_sources_command)
7776         (make_source_files_completion_list): Use objfile_compunits.
7777         * source.c (select_source_symtab): Use objfile_compunits.
7778         * objfiles.h (struct objfile): Update comment.
7779         (ALL_OBJFILES): Remove.
7780         (ALL_FILETABS): Remove.
7781         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
7782         objfile_compunits.
7783
7784 2019-01-09  Tom Tromey  <tom@tromey.com>
7785
7786         * symmisc.c (print_objfile_statistics, dump_objfile)
7787         (maintenance_print_symbols): Use compunit_filetabs.
7788         * source.c (forget_cached_source_info_for_objfile): Use
7789         compunit_filetabs.
7790         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
7791         (ALL_FILETABS): Use compunit_filetabs.
7792         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
7793         * coffread.c (coff_symtab_read): Use compunit_filetabs.
7794
7795 2019-01-09  Tom Tromey  <tom@tromey.com>
7796
7797         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
7798         (compunit_filetabs): New.
7799         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
7800         compunit_filetabs.
7801         (info_sources_command, make_source_files_completion_list): Remove
7802         declaration.
7803         * symmisc.c (print_objfile_statistics, dump_objfile)
7804         (maintenance_print_symbols): Remove declaration.
7805         (maintenance_info_symtabs): Use compunit_filetabs.
7806         (maintenance_info_line_tables): Likewise.
7807         * source.c (select_source_symtab): Change local variable name.
7808         (forget_cached_source_info_for_objfile): Remove declaration.
7809         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
7810         * objfiles.c (objfile_relocate1): Remove declaration.
7811         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7812         declaration.
7813         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
7814         * coffread.c (coff_symtab_read): Remove declaration.
7815         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
7816         compunit_filetabs.
7817
7818 2019-01-09  Tom Tromey  <tom@tromey.com>
7819
7820         * symtab.c (lookup_objfile_from_block)
7821         (find_pc_sect_compunit_symtab, search_symbols)
7822         (default_collect_symbol_completion_matches_break_on): Use
7823         objfile_compunits.
7824         * objfiles.h (ALL_COMPUNITS): Remove.
7825         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
7826         * cp-support.c (add_symbol_overload_list_qualified): Use
7827         objfile_compunits.
7828         * ada-lang.c (ada_collect_symbol_completion_matches)
7829         (ada_add_global_exceptions): Use objfile_compunits.
7830
7831 2019-01-09  Tom Tromey  <tom@tromey.com>
7832
7833         * source.c (select_source_symtab)
7834         (forget_cached_source_info_for_objfile): Remove declaration.
7835         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7836         declaration.
7837         * maint.c (count_symtabs_and_blocks): Remove declaration.
7838         * cp-support.c (add_symbol_overload_list_qualified): Remove
7839         declaration.
7840         * coffread.c (coff_symtab_read): Remove declaration.
7841         * symtab.c (lookup_symbol_in_objfile_symtabs)
7842         (basic_lookup_transparent_type_1): Use objfile_compunits.
7843         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
7844         (info_sources_command, search_symbols)
7845         (default_collect_symbol_completion_matches_break_on)
7846         (make_source_files_completion_list): Remove declaration.
7847         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
7848         (ada_collect_symbol_completion_matches)
7849         (ada_add_global_exceptions): Remove declaration.
7850         * linespec.c (iterate_over_all_matching_symtabs): Use
7851         objfile_compunits.
7852         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
7853         (class objfile_compunits): New.
7854         (ALL_COMPUNITS): Use objfile_compunits.
7855         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
7856         (maintenance_check_symtabs, maintenance_info_line_tables): Use
7857         objfile_compunits.
7858         * objfiles.c (objfile_relocate1): Use objfile_compunits.
7859
7860 2019-01-09  Tom Tromey  <tom@tromey.com>
7861
7862         * symtab.c (search_symbols)
7863         (default_collect_symbol_completion_matches_break_on): Use
7864         objfile_msymbols.
7865         * ada-lang.c (ada_lookup_simple_minsym)
7866         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
7867         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
7868         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
7869         objfile_msymbols.
7870         * coffread.c (coff_symfile_read): Use objfile_msymbols.
7871         * symmisc.c (dump_msymbols): Use objfile_msymbols.
7872         * objc-lang.c (find_methods): Use objfile_msymbols.
7873         (info_selectors_command, info_classes_command): Likewise.
7874         * stabsread.c (scan_file_globals): Use objfile_msymbols.
7875         * objfiles.h (class objfile_msymbols): New.
7876         (ALL_OBJFILE_MSYMBOLS): Remove.
7877         (ALL_MSYMBOLS): Remove.
7878
7879 2019-01-09  Tom Tromey  <tom@tromey.com>
7880
7881         * common/next-iterator.h (next_adapter): Add Iterator template
7882         parameter.
7883         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
7884         (class all_objfiles_safe): New.
7885         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
7886         * objfiles.c (put_objfile_before): Update comment.
7887         (add_separate_debug_objfile): Likewise.
7888         (free_all_objfiles): Use all_objfiles_safe.
7889         (objfile_purge_solibs): Likewise.
7890
7891 2019-01-09  Tom Tromey  <tom@tromey.com>
7892
7893         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7894         (expand_symtab_containing_pc, lookup_static_symbol)
7895         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
7896         (find_symbol_at_address, find_line_symtab, find_main_name): Use
7897         all_objfiles.
7898         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
7899         * breakpoint.c (create_overlay_event_breakpoint)
7900         (create_longjmp_master_breakpoint)
7901         (create_std_terminate_master_breakpoint)
7902         (create_exception_master_breakpoint): Use all_objfiles.
7903         * linux-thread-db.c (try_thread_db_load_from_pdir)
7904         (has_libpthread): Use all_objfiles.
7905         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
7906         * linespec.c (iterate_over_all_matching_symtabs)
7907         (search_minsyms_for_name): Use all_objfiles.
7908         * maint.c (maintenance_info_sections): Use all_objfiles.
7909         * main.c (captured_main_1): Use all_objfiles.
7910         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
7911         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
7912         * guile/scm-pretty-print.c
7913         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
7914         * solib-spu.c (append_ocl_sos): Use all_objfiles.
7915         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
7916         (maintenance_print_msymbols): Use all_objfiles.
7917         * source.c (select_source_symtab): Use all_objfiles.
7918         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
7919         * symfile.c (remove_symbol_file_command)
7920         (expand_symtabs_matching, map_symbol_filenames): Use
7921         all_objfiles.
7922         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
7923         all_objfiles.
7924         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
7925         * objc-lang.c (find_methods): Use all_objfiles.
7926         * objfiles.c (have_partial_symbols, have_full_symbols)
7927         (have_minimal_symbols, qsort_cmp)
7928         (default_iterate_over_objfiles_in_search_order): Use
7929         all_objfiles.
7930         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
7931         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
7932         (maintenance_check_psymtabs): Use all_objfiles.
7933         (ALL_PSYMTABS): Remove.
7934         * compile/compile-object-run.c (do_module_cleanup): Use
7935         all_objfiles.
7936         * blockframe.c (find_pc_partial_function): Use all_objfiles.
7937         * cp-support.c (add_symbol_overload_list_qualified): Use
7938         all_objfiles.
7939         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7940         Use all_objfiles.
7941         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
7942         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
7943         all_objfiles.
7944         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7945         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
7946         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7947         Uses all_objfiles.
7948         * solib.c (solib_read_symbols): Use all_objfiles
7949
7950 2019-01-09  Tom Tromey  <tom@tromey.com>
7951
7952         * probe.c (parse_probes_in_pspace): Use all_objfiles.
7953         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
7954         all_objfiles.
7955         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
7956         * symmisc.c (print_symbol_bcache_statistics)
7957         (print_objfile_statistics, maintenance_print_objfiles)
7958         (maintenance_info_symtabs, maintenance_check_symtabs)
7959         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
7960         all_objfiles.
7961         * source.c (forget_cached_source_info): Use all_objfiles.
7962         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
7963         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7964         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
7965         * objfiles.c (update_section_map): Use all_objfiles.
7966         (shared_objfile_contains_address_p): Likewise.
7967         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
7968         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
7969
7970 2019-01-09  Tom Tromey  <tom@tromey.com>
7971
7972         * common/next-iterator.h: New file.
7973         * objfiles.h (class all_objfiles): New.
7974         (struct objfile_iterator): New.
7975
7976 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7977
7978         * NEWS: Move the description of the changed "frame", "select-frame",
7979          and "info frame" commands to the Changed commands section.
7980
7981 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
7982
7983         * gdbtypes.c (check_stub_method_group): Remove handling of old
7984         mangling schemes.
7985         * linespec.c (find_methods): Likewise.
7986         * stabsread.c (read_member_functions): Likewise.
7987         * valops.c (search_struct_method): Likewise.
7988         (value_struct_elt_for_reference): Likewise.
7989         * NEWS: Mention this change.
7990
7991 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7992
7993         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
7994         print_source_lines.
7995         * source.c (print_source_lines_base): Update line number check.
7996         (print_source_lines): New function.
7997         (source_lines_range::source_lines_range): New function.
7998         * source.h (class source_lines_range): New class.
7999         (print_source_lines): New declaration.
8000
8001 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8002
8003         * linespec.c (linespec_state_destructor): Free self->canonical_names.
8004
8005 2019-01-08  Tom Tromey  <tom@tromey.com>
8006             Simon Marchi  <simon.marchi@ericsson.com>
8007
8008         PR gdb/24060
8009         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
8010         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
8011         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8012         * f-exp.y (DOLLAR_VARIABLE): Likewise.
8013         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
8014         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8015
8016 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8017
8018         * source.c (select_source_symtab): Move header comment to
8019         declaration in source.h.
8020         (forget_cached_source_info_for_objfile): Likewise.
8021         (forget_cached_source_info): Likewise.
8022         (identify_source_line): Likewise.
8023         * source.h (identify_source_line): Move declaration from symtab.h
8024         and add comment from source.c
8025         (print_source_lines): Likewise.
8026         (forget_cached_source_info_for_objfile): Likewise.
8027         (forget_cached_source_info): Likewise.
8028         (select_source_symtab): Likewise.
8029         (enum print_source_lines_flag): Move definition from symtab.h.
8030         * symtab.h (identify_source_line): Move declaration to source.h.
8031         (print_source_lines): Likewise.
8032         (forget_cached_source_info_for_objfile): Likewise.
8033         (forget_cached_source_info): Likewise.
8034         (select_source_symtab): Likewise.
8035         (enum print_source_lines_flag): Move definition to source.h.
8036         * tui/tui-hooks.c: Add 'source.h' include.
8037
8038 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8039
8040         * source.c (print_source_lines_base): Handle requests to print
8041         reverse line number sequences, and guard against empty lines
8042         string.
8043
8044 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8045
8046         * source.c (print_source_lines_base): Fix skip of '\r' if next
8047         character is '\n'.
8048
8049 2019-01-06  Tom Tromey  <tom@tromey.com>
8050
8051         * c-exp.y (struct c_parse_state) <macro_original_text,
8052         expansion_obstack>: New member.
8053         (macro_original_text, expansion_obstack): Remove globals.
8054         (scan_macro_expansion, scanning_macro_expansion)
8055         (finished_macro_expansion): Update.
8056         (scan_macro_cleanup): Remove.
8057         (yylex, c_parse): Update.
8058
8059 2019-01-06  Tom Tromey  <tom@tromey.com>
8060
8061         * c-exp.y (struct c_parse_state) <strings>: New member.
8062         (operator_stoken): Update.
8063
8064 2019-01-06  Tom Tromey  <tom@tromey.com>
8065
8066         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
8067         (union type_stack_elt) <typelist_val>: Now a pointer to
8068         std::vector.
8069         (type_stack_cleanup): Don't declare.
8070         (push_typelist): Update.
8071         * parse.c (pop_typelist): Return a std::vector.
8072         (push_typelist): Take a std::vector.
8073         (follow_types): Update.  Do not free args.
8074         (type_stack_cleanup): Remove.
8075         * c-exp.y (struct c_parse_state): New.
8076         (cpstate): New global.
8077         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
8078         (nonempty_typelist): Update.
8079         (func_mod): Create a new vector.
8080         (c_parse): Create a c_parse_state.
8081         (check_parameter_typelist): Do not delete params.
8082         (function_method): Update.  Do not delete type_list.
8083
8084 2019-01-06  Tom Tromey  <tom@tromey.com>
8085
8086         PR gdb/28155:
8087         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
8088         check_typedef.
8089         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
8090         (print_return_value): Likewise.
8091
8092 2019-01-05  Tom Tromey  <tom@tromey.com>
8093
8094         * contrib/cleanup_check.py: Remove.
8095         * contrib/gcc-with-excheck: Remove.
8096         * contrib/exsummary.py: Remove.
8097         * contrib/excheck.py: Remove.
8098
8099 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
8100
8101         * thread.c (delete_thread_1): Add gdb_assert that THR is not
8102         NULL. Initialize tpprev to NULL instead of assigning it
8103         to NULL on the next statement.
8104         * windows-nat.c (windows_delete_thread): Remove check for
8105         main_thread_id before printing thread exit notifications.
8106         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
8107         Remove thread ID check against main_thread_id.
8108         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
8109         windows_delete_thread.
8110         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
8111
8112 2019-01-04  Tom Tromey  <tom@tromey.com>
8113
8114         * compile/compile.c (_initialize_compile): Use upper case for
8115         metasyntactic variables.
8116         * symmisc.c (_initialize_symmisc): Use upper case for
8117         metasyntactic variables.
8118         * psymtab.c (_initialize_psymtab): Use upper case for
8119         metasyntactic variables.
8120         * demangle.c (demangle_command): Use upper case for metasyntactic
8121         variables.
8122         (_initialize_demangler): Likewise.
8123         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
8124         variables.
8125
8126 2019-01-03  Tom Tromey  <tom@tromey.com>
8127
8128         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
8129
8130 2019-01-03  Tom Tromey  <tom@tromey.com>
8131
8132         * python/py-symtab.c (salpy_str): Update.
8133         (struct salpy_sal_object) <symtab>: Now a PyObject.
8134         (salpy_dealloc): Update.
8135         (del_objfile_sal): Use gdbpy_ref.
8136
8137 2019-01-03  Tom Tromey  <tom@tromey.com>
8138
8139         * python/py-type.c (convert_field): Use new_reference.  Return
8140         gdbpy_ref.
8141         (make_fielditem): Return gdbpy_ref.
8142         (typy_fields): Update.
8143         (typy_getitem): Update.
8144         (field_name): Return gdbpy_ref.  Use new_reference.
8145         (typy_iterator_iternext): Update.
8146
8147 2019-01-03  Tom Tromey  <tom@tromey.com>
8148
8149         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
8150
8151 2019-01-03  Tom Tromey  <tom@tromey.com>
8152
8153         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
8154         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
8155         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
8156         (pspy_set_frame_filters, pspy_set_frame_unwinders)
8157         (pspy_set_type_printers): Likewise.
8158         * python/py-function.c (fnpy_init): Use gdbpy_ref.
8159         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
8160         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
8161         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
8162         (objfpy_set_type_printers): Likewise.
8163
8164 2019-01-03  Tom Tromey  <tom@tromey.com>
8165
8166         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
8167         (gdbpy_print_stack): Use gdbpy_err_fetch.
8168         * python/python-internal.h (class gdbpy_err_fetch): New class.
8169         (class gdbpy_enter) <m_error_type, m_error_value,
8170         m_error_traceback>: Remove.
8171         <m_error>: New member.
8172         (gdbpy_exception_to_string): Don't declare.
8173         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
8174         * python/py-value.c (convert_value_from_python): Use
8175         gdbpy_err_fetch.
8176         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
8177         gdbpy_exception_to_string.
8178         (gdbpy_handle_exception): Use gdbpy_err_fetch.
8179         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
8180         gdbpy_err_fetch.
8181
8182 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8183
8184         * linux-nat.c (delete_lwp_cleanup): Delete.
8185         (struct lwp_deleter): New struct.
8186         (lwp_info_up): New typedef.
8187         (linux_nat_target::follow_fork): Delete cleanup, and make use of
8188         lwp_info_up.
8189
8190 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8191
8192         * linux-fork.c (class scoped_switch_fork_info): New class.
8193         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
8194
8195 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8196
8197         * valops.c (find_overload_match): Remove use of null_cleanup, and
8198         calls to do_cleanups.
8199
8200 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8201
8202         * compile/compile-cplus-types.c
8203         (compile_cplus_instance::decl_name): Handle changes to
8204         cp_func_name.
8205         * cp-support.c (cp_func_name): Update header comment, update
8206         return type.
8207         * cp-support.h (cp_func_name): Update return type in declaration.
8208         * valops.c (find_overload_match): Move temp_func local to top
8209         level of function and change its type.  Use temp_func to hold and
8210         delete temporary string obtained from cp_func_name.
8211
8212 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8213
8214         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
8215         gdb::char_vector, remove cleanup, and update uses of `msg`.
8216
8217 2019-01-03  Jim Wilson  <jimw@sifive.com>
8218
8219         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
8220
8221 2019-01-02  Tom Tromey  <tom@tromey.com>
8222
8223         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
8224         (tdesc_parse_xml): Remove cleanups.
8225         * target-descriptions.h (make_cleanup_free_target_description):
8226         Don't declare.
8227         (target_desc_deleter): New struct.
8228         (target_desc_up): New typedef.
8229         * target-descriptions.c (target_desc_deleter::operator()): Rename
8230         from free_target_description.
8231         (make_cleanup_free_target_description): Remove.
8232
8233 2019-01-02  Tom Tromey  <tom@tromey.com>
8234
8235         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
8236         constructor, destructor.
8237         (linespec_parser): Remove typedef.
8238         (~linespec_parser): Rename from linespec_parser_delete.
8239         (linespec_lex_to_end, linespec_complete_label)
8240         (linespec_complete): Update.
8241         (decode_line_full): Remove cleanups.
8242         (decode_line_1): Update.
8243
8244 2019-01-02  Tom Tromey  <tom@tromey.com>
8245
8246         * python/python-internal.h (inferior_to_inferior_object): Change
8247         return type.
8248         * python/py-exitedevent.c (create_exited_event_object): Update.
8249         * python/py-inferior.c (inferior_to_inferior_object): Return
8250         gdbpy_ref.
8251         (python_new_inferior, python_inferior_deleted)
8252         (thread_to_thread_object, delete_thread_object)
8253         (build_inferior_list, gdbpy_selected_inferior): Update.
8254         * python/py-infthread.c (create_thread_object): Update.  Also fail
8255         if inferior_to_inferior_object fails.
8256
8257 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
8258
8259         * inferior.h (class inferior) <displaced_step_state>: New field.
8260         * infrun.h (struct displaced_step_state): Move here from
8261         infrun.c.  Initialize fields, add constructor.
8262         <inf>: Remove field.
8263         <reset>: New method.
8264         * infrun.c (struct displaced_step_inferior_state): Move to
8265         infrun.h.
8266         (displaced_step_inferior_states): Remove.
8267         (get_displaced_stepping_state): Adust.
8268         (displaced_step_in_progress_any_inferior): Adjust.
8269         (displaced_step_in_progress_thread): Adjust.
8270         (displaced_step_in_progress): Adjust.
8271         (add_displaced_stepping_state): Remove.
8272         (get_displaced_step_closure_by_addr): Adjust.
8273         (remove_displaced_stepping_state): Remove.
8274         (infrun_inferior_exit): Call displaced_step_state.reset.
8275         (use_displaced_stepping): Don't check for NULL.
8276         (displaced_step_prepare_throw): Call
8277         get_displaced_stepping_state.
8278         (displaced_step_fixup): Don't check for NULL.
8279         (prepare_for_detach): Don't check for NULL.
8280
8281 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8282
8283         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
8284          in case of call that did not complete.
8285
8286 2019-01-02  Andrey Utkin  <autkin@undo.io>
8287
8288         * symfile.c (find_separate_debug_file): Fix search of debug files for
8289         remote debuggee.
8290
8291 2019-01-02  Tom Tromey  <tom@tromey.com>
8292
8293         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
8294         indentation.
8295         * python/py-frame.c (frapy_older): Remove cast.
8296         (frapy_newer): Likewise.
8297         * python/py-breakpoint.c (local_setattro): Remove cast.
8298         * python/py-arch.c (archpy_name): Remove local variable.
8299         * python/py-type.c (gdbpy_lookup_type): Remove cast.
8300
8301 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
8302
8303         * unittests/basic_string_view/element_access/char/empty.cc:
8304         Fix year range in copyright header.
8305
8306 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8307
8308         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
8309         Delete.
8310         <operator==>: Update with for removed field.
8311         <hash>: Likewise.
8312         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
8313         <isa_features>: ...this.
8314         <abi_features>: New field.
8315         (riscv_isa_flen): Update comment.
8316         (riscv_abi_xlen): New declaration.
8317         (riscv_abi_flen): New declaration.
8318         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
8319         isa_features.
8320         (riscv_abi_xlen): New function.
8321         (riscv_isa_flen): Update to get answer from isa_features.
8322         (riscv_abi_flen): New function.
8323         (riscv_has_fp_abi): Update to get answer from abi_features.
8324         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
8325         xlen and flen.
8326         (riscv_call_info) <xlen, flen>: Update comment.
8327         (riscv_call_arg_struct): Remove invalid assertions
8328         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
8329         is removed.
8330         (riscv_gdbarch_init): Gather isa features and abi features
8331         separately, ensure both match on the gdbarch when reusing an old
8332         gdbarch.  Relax an error check to allow 32-bit abi float to run on
8333         a target with 64-bit float hardware.
8334
8335 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8336
8337         * source.c (search_command_helper): Stop reverse search
8338         when line 1 has been searched.
8339
8340 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8341
8342         * record-full.c (record_full_base_target::close): Rewrite
8343         record_full_core_buf_list free logic.
8344
8345 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8346
8347         * break-catch-syscall.c (print_one_catch_syscall): xfree
8348         the last text.
8349
8350 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8351
8352         * top.c (print_gdb_version): Update Copyright year in version
8353         message.
8354
8355 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8356
8357         Update copyright year range in all GDB files.
8358
8359 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
8360
8361         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
8362
8363 For older changes see ChangeLog-2018.
8364 \f
8365 Local Variables:
8366 mode: change-log
8367 left-margin: 8
8368 fill-column: 74
8369 version-control: never
8370 coding: utf-8
8371 End:
8372