gdb/ChangeLog

   1 2019-06-22  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
   4         declare.
   5         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
   6
   7 2019-06-22  Tom de Vries  <tdevries@suse.de>
   8
   9         * dwarf2read.c (create_addrmap_from_aranges)
  10         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
  11         instead of '%zu'.
  12
  13 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
  14
  15         * dwarf2read.h (dwarf2_section_info_def): Remove.
  16         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
  17         * dwarf2read.c (struct dwo_sections) <types>: Change type to
  18         std::vector<dwarf2_section_info>.
  19         (struct dwo_file) <~dwo_file>: Remove.
  20         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
  21         types field.
  22         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
  23         (dwarf2_read_debug_names): Likewise.
  24         (create_debug_types_hash_table): Change parameter type to
  25         array_view, adjust code accordingly.
  26         (dwarf2_locate_dwo_sections): Adjust to std::vector.
  27         (partial_die_info::fixup): Likewise.
  28         (determine_prefix): Likewise.
  29         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
  30
  31 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
  32
  33         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
  34         gdb_bfd_ref_ptr.
  35         <~dwo_file>: Remove call to gdb_bfd_unref.
  36         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
  37         gdb_bfd_ref_ptr::get.
  38
  39 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
  40
  41         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
  42         type to htab_up.
  43         * dwarf2read.c (struct dwo_file): Initialize fields.
  44         <~dwo_file>: New.
  45         (free_dwo_file): Remove, move content to ~dwo_file.
  46         (struct dwo_file_deleter): Remove.
  47         (dwo_file_up>: Remove custom deleter.
  48         (free_dwo_files): Remove.
  49         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
  50         dwo_files.
  51         (process_skeletonless_type_units): Call unique_ptr::get.
  52         (allocate_dwo_file_hash_table): Add deleter to created hash
  53         table.  Change return type to htab_up.
  54         (lookup_dwo_file_slot): Don't memset dwo_file, call
  55         unique_ptr::get.
  56         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
  57         (create_dwo_unit_in_dwp_v2): Likewise.
  58         (open_and_init_dwo_file): Likewise.
  59         (free_dwo_file_from_slot): Remove.
  60
  61 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
  62
  63         * dwarf2read.h (struct dwarf2_section_info) <readin,
  64         is_virtual>: Change type to bool.
  65         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
  66         true instead of 1.
  67
  68 2019-06-19  Tom Tromey  <tom@tromey.com>
  69
  70         * tui/tui-data.h (tui_init_content_element): Don't declare.
  71
  72 2019-06-19  Tom Tromey  <tom@tromey.com>
  73
  74         * tui/tui-data.h (tui_init_win_info): Don't declare.
  75
  76 2019-06-19  Tom de Vries  <tdevries@suse.de>
  77
  78         * dwarf2read.h (abstract_to_concrete): Change type to
  79         std::unordered_map<sect_offset, std::vector<sect_offset>,
  80         gdb::hash_enum<sect_offset>>.
  81
  82 2019-06-19  Tom Tromey  <tromey@adacore.com>
  83
  84         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
  85         EVAL_AVOID_SIDE_EFFECTS specially.
  86
  87 2019-06-19  Tom Tromey  <tromey@adacore.com>
  88
  89         * source-cache.c (highlighter): New global.
  90         (source_cache::get_source_lines): Create a highlighter on demand.
  91
  92 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
  93
  94         * defs.h (deprecated_interactive_hook): Delete declaration.
  95         * interps.c (clear_interpreter_hooks): Remove use of
  96         deprecated_interactive_hook.
  97         * top.c (deprecated_interactive_hook): Delete definition.
  98         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
  99
 100 2019-06-18  Tom de Vries  <tdevries@suse.de>
 101
 102         PR gdb/24515
 103         * dwarf2read.h (abstract_to_concrete): Change type from
 104         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
 105         std::unordered_map<sect_offset, std::vector<sect_offset>>.
 106         * dwarf2read.c (read_variable): Update.
 107         (dwarf2_fetch_die_loc_sect_off): Update.
 108
 109 2019-06-17  Tom de Vries  <tdevries@suse.de>
 110
 111         PR gdb/24617
 112         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
 113         accessing parent[parent_len - 1].
 114
 115 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
 116
 117         PR gdb/24364
 118         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
 119         call dtrace_process_dof with NULL dof.
 120
 121 2019-06-16  Tom de Vries  <tdevries@suse.de>
 122
 123         PR gdb/24445
 124         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
 125
 126 2019-06-16  Tom Tromey  <tom@tromey.com>
 127
 128         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 129         (make_all_visible): Use address of member.
 130
 131 2019-06-16  Tom Tromey  <tom@tromey.com>
 132
 133         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
 134         (tui_free_window, free_content, free_content_elements): Remove
 135         unnecessary cast.
 136         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
 137         cast.
 138         * tui/tui-regs.c (tui_show_register_group)
 139         (tui_display_registers_from, tui_display_reg_element_at_line):
 140         Remove unnecessary cast.
 141
 142 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
 143
 144         * linux-nat.c (normal_mask): Delete.
 145         (_initialize_linux_nat): Don't initialise normal_mask.
 146
 147 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
 148
 149         PR gdb/24445
 150         * dwarf-index-write.h (write_psymtabs_to_index): Add
 151         dwz_basename parameter.
 152         * dwarf-index-write.c (write_gdbindex): Move file writing to
 153         write_gdbindex_1.  Change return type void.
 154         (assert_file_size): Move up, remove filename parameter.
 155         (write_gdbindex_1): New function.
 156         (write_debug_names): Change return type to void, call
 157         assert_file_size.
 158         (struct index_wip_file): New struct.
 159         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
 160         file logic to index_wip_file.  Write index for dwz file if
 161         needed.
 162         (save_gdb_index_command): Pass basename of dwz file, if present.
 163         * dwarf-index-cache.c (index_cache::store): Obtain and pass
 164         build-id of dwz file, if present.
 165         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
 166         (dwarf2_get_dwz_file): Likewise.
 167         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
 168         (dwarf2_get_dwz_file): Likewise.
 169
 170 2019-06-16  Tom Tromey  <tom@tromey.com>
 171
 172         * coffread.c (process_coff_symbol): Use xstrdup.
 173         * value.c (create_internalvar): Use xstrdup.
 174
 175 2019-06-16  Tom Tromey  <tom@tromey.com>
 176
 177         * valops.c (value_cast, value_slice): Remove unnecessary cast.
 178         * breakpoint.c (stopin_command, stopat_command)
 179         (until_break_command, decode_location_default): Remove unnecessary
 180         cast.
 181         * utils.c (subset_compare): Remove unnecessary cast.
 182         * ada-lang.c (ada_update_initial_language): Remove unnecessary
 183         cast.
 184         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
 185         cast.
 186         * infcmd.c (path_command): Remove unnecessary cast.
 187         * coffread.c (decode_type): Remove unnecessary cast.
 188         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
 189         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
 190         * tui/tui-stack.c (tui_show_locator_content)
 191         (tui_show_frame_info): Remove unnecessary cast.
 192         * tui/tui-win.c (tui_scroll_forward_command)
 193         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
 194         (parse_scrolling_args): Remove unnecessary cast.
 195         * tui/tui-data.c (init_win_info, tui_del_window)
 196         (tui_free_window, tui_del_data_windows, tui_free_data_content)
 197         (free_content_elements): Remove unnecessary cast.
 198         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
 199         unnecessary cast.
 200         * tui/tui-source.c (tui_set_source_content)
 201         (tui_vertical_source_scroll): Remove unnecessary cast.
 202         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
 203         cast.
 204         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
 205         * tui/tui-regs.c (tui_display_registers_from)
 206         (tui_display_register): Remove unnecessary cast.
 207         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
 208         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
 209         (make_visible): Remove unnecessary cast.
 210         * tui/tui-winsource.c (tui_erase_source_content)
 211         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
 212         unnecessary cast.
 213         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
 214         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
 215         * stabsread.c (read_type, read_array_type, read_range_type):
 216         Remove unnecessary cast.
 217         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
 218         (parse_symbol, parse_type, upgrade_type, parse_external)
 219         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
 220         unnecessary cast.
 221         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
 222
 223 2019-06-16  Tom Tromey  <tom@tromey.com>
 224
 225         * tui/tui-data.c (tui_alloc_generic_win_info)
 226         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
 227         checks.
 228
 229 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
 230             Andrew Burgess  <andrew.burgess@embecosm.com>
 231
 232         * f-typeprint.c (f_print_type): Don't return early for not
 233         associated or not allocated types.
 234         (f_type_print_varspec_suffix): Add print_rank parameter and print
 235         ranks of array types in case they dangling.
 236         (f_type_print_base): Add print_rank parameter.
 237
 238 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 239
 240         * NEWS: Mention new MI commands.
 241         * break-catch-throw.c (enum exception_event_kind): Move to
 242         breakpoint.h.
 243         (print_mention_exception_catchpoint): Output text as a single
 244         message.
 245         (catch_exception_command_1): Rename to...
 246         (catch_exception_event): ...this, make non-static, update header
 247         command, and change some parameter types.
 248         (catch_catch_command): Update for changes to
 249         catch_exception_command_1.
 250         (catch_throw_command): Likewise.
 251         (catch_rethrow_command): Likewise.
 252         * breakpoint.c (enum exception_event_kind): Delete.
 253         * breakpoint.h (enum exception_event_kind): Moved here from
 254         break-catch-throw.c.
 255         (catch_exception_event): Declare.
 256         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
 257         (mi_cmd_catch_throw): New function.
 258         (mi_cmd_catch_rethrow): New function.
 259         (mi_cmd_catch_catch): New function.
 260         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
 261         'catch-catch' entries.
 262         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
 263         (mi_cmd_catch_rethrow): Declare.
 264         (mi_cmd_catch_catch): Declare.
 265
 266 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 267
 268         * annotate.c (annotate_source_line): Change return type to void,
 269         update implementation to match.
 270         * annotate.h (annotate_source_line): Change return type to void,
 271         update header comment.
 272         * stack.c (print_frame_info): Don't change what frame information
 273         is printed based on whether annotations are on or not.
 274
 275 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 276
 277         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
 278         (annotate_source): Make static.
 279         (annotate_source_line): Moved from source.c and renamed from
 280         identify_source_line.  Update the return type.
 281         * annotate.h (annotate_source): Delete declaration.
 282         (annotate_source_line): Declaration moved from source.h, and
 283         renamed from identify_source_line.  Return type updated.
 284         * source.c (identify_source_line): Moved to annotate.c and renamed
 285         to annotate_source_line.
 286         (info_line_command): Remove check of annotation_level.
 287         * source.h (identify_source_line): Move declaration to annotate.h
 288         and rename to annotate_source_line.
 289         * stack.c: Add 'annotate.h' include.
 290         (print_frame_info): Remove check of annotation_level before
 291         calling annotate_source_line.
 292
 293 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 294
 295         * source-cache.c (source_cache::get_plain_source_lines): Use
 296         open_source_file_with_line_charpos instead of just
 297         open_source_file, remove call to find_source_lines.
 298         (source_cache::get_source_lines): Likewise.
 299         * source.c (find_source_lines): Make static.
 300         (get_filename_and_charpos): Renamed into...
 301         (open_source_file_with_line_charpos): ..this along with changes to
 302         return a scoped_fd, and some other minor clean ups.
 303         (identify_source_line): Use open_source_file_with_line_charpos.
 304         (search_command_helper): Use open_source_file_with_line_charpos
 305         instead of just open_source_file, remove call to
 306         find_source_lines.
 307         * source.h (open_source_file_with_line_charpos): Declare new
 308         function.
 309         (find_source_lines): Delete declaration.
 310
 311 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 312
 313         * source.c (get_filename_and_charpos): Remove fullname
 314         parameter.
 315         (identify_source_line): Update call to get_filename_and_charpos.
 316
 317 2019-06-14  Tom Tromey  <tromey@adacore.com>
 318
 319         PR gdb/24502:
 320         * ui-style.h (skip_ansi_escape): Update comment.
 321         * ui-file.h (class no_terminal_escape_file): New class.
 322         * ui-file.c (no_terminal_escape_file::write)
 323         (no_terminal_escape_file::puts): New methods.
 324         * cli/cli-logging.c (handle_redirections): Use
 325         no_terminal_escape_file.
 326
 327 2019-06-14  Tom Tromey  <tromey@adacore.com>
 328
 329         * NEWS: Move convenience variable news above Python news.
 330
 331 2019-06-14  Tom Tromey  <tom@tromey.com>
 332
 333         * gnulib: Move directory to top-level.
 334         * configure.ac: Don't configure gnulib.
 335         * configure: Rebuild.
 336         * common/common-defs.h: Use new path to gnulib.
 337         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
 338         (GNULIB_H): Remove.
 339         (INCGNU): Look in new gnulib location.
 340         (HFILES_NO_SRCDIR): Remove gnulib files.
 341         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
 342         (generated_files): Remove GNULIB_H.
 343         ($(LIBGNU), all-lib): Remove targets.
 344         (distclean): Don't mention GNULIB_BUILDDIR.
 345         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
 346
 347 2019-06-14  Tom Tromey  <tromey@adacore.com>
 348
 349         * symfile.c (add_symbol_file_command): Remove obsolete comment.
 350         Warn if symbol file does not provide any symbols.
 351
 352 2019-06-14  Tom Tromey  <tromey@adacore.com>
 353
 354         * source.c (find_and_open_source): Respect basenames_may_differ.
 355
 356 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
 357
 358         * annotate.c (annotate_breakpoints_invalid): Make use of
 359         scoped_restore_terminal_state.
 360         (annotate_frames_invalid): Likewise.
 361
 362 2019-06-14  Tom Tromey  <tromey@adacore.com>
 363
 364         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
 365         allow assignment to an internalvar.
 366
 367 2019-06-14  Tom Tromey  <tromey@adacore.com>
 368
 369         * ada-lex.l: Allow "_" in attribute names.
 370
 371 2019-06-14  Tom Tromey  <tromey@adacore.com>
 372
 373         PR gdb/24653:
 374         * regcache.c (registers_changed): Don't call alloca.
 375         * top.c (execute_command): Don't call alloca.
 376
 377 2019-06-13  Pedro Alves  <palves@redhat.com>
 378
 379         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
 380         'expression'.  When parsing an expression, error out if there's
 381         junk after "unlimited".
 382         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 383         (do_set_command): Adjust calls to is_unlimited_literal.
 384
 385 2019-06-13  Pedro Alves  <palves@redhat.com>
 386
 387         * compile/compile.c (make_compile_options_def_group): Add braces
 388         around array_view initializer.
 389         * thread.c (make_thread_apply_all_options_def_group)
 390         (make_thread_apply_all_options_def_group): Likewise.
 391
 392 2019-06-13  Pedro Alves  <palves@redhat.com>
 393
 394         * NEWS (New commands): Mention "maint test-options
 395         require-delimiter", "maint test-options unknown-is-error", "maint
 396         test-options unknown-is-operand" and "maint show
 397         test-options-completion-result".
 398         (New command options, command completion): New section.
 399         (Completion improvements): New section.
 400         Mention that you can abbreviate "unlimited".
 401
 402 2019-06-13  Pedro Alves  <palves@redhat.com>
 403
 404         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
 405         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
 406         * unittests/cli-utils-selftests.c (test_parse_flags)
 407         (test_parse_flags_qcs): Delete.
 408         (test_cli_utils): Don't call deleted functions.
 409
 410 2019-06-13  Pedro Alves  <palves@redhat.com>
 411
 412         * thread.c: Include "cli/cli-option.h".
 413         (tp_array_compar_ascending): Global.
 414         (tp_array_compar): Delete function.
 415         (tp_array_compar_ascending, tp_array_compar_descending): New
 416         functions.
 417         (ascending_option_def, qcs_flag_option_def)
 418         (thr_qcs_flags_option_defs)
 419         (make_thread_apply_all_options_def_group)
 420         (make_thread_apply_options_def_group): New.
 421         (thread_apply_all_command): Use gdb::option::process_options.
 422         (thread_apply_command_completer)
 423         (thread_apply_all_command_completer): New.
 424         (thread_apply_command): Use gdb::option::process_options.
 425         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
 426         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
 427         to generate help text of "thread apply".  Adjust "taas"'s help.
 428         * tid-parse.c (tid_range_parser::in_thread_range): New method.
 429         * tid-parse.h (tid_range_parser::in_thread_range): New method.
 430
 431 2019-06-13  Pedro Alves  <palves@redhat.com>
 432
 433         * thread.c (thread_apply_command): Check for invalid TID with
 434         isdigit instead of !isalpha.
 435
 436 2019-06-13  Pedro Alves  <palves@redhat.com>
 437
 438         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
 439         (validate_flags_qcs): New.
 440         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
 441         (validate_flags_qcs): Declare.
 442         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
 443         (make_frame_apply_options_def_group): New.
 444         (frame_apply_command_count): Process options with
 445         gdb::option::process_options.
 446         (frame_apply_completer): New.
 447         (frame_apply_level_completer, frame_apply_all_completer)
 448         (frame_apply_completer): New.
 449         (_initialize_stack): Update help of "frame apply", "frame apply
 450         level", "frame apply all" and "faas" to mention supported options
 451         and install command completers.
 452         * stack.h (frame_apply_all_completer): Declare.
 453         * thread.c: Include "stack.h".
 454         (tfaas_command): Add "--".
 455         (_initialize_thread): Update help "tfaas" to mention supported
 456         options and install command completer.
 457
 458 2019-06-13  Pedro Alves  <palves@redhat.com>
 459
 460         * completer.c (complete_nested_command_line): New.
 461         (gdb_completion_word_break_characters_throw): Add assertion.
 462         * completer.h (complete_nested_command_line): Declare.
 463
 464 2019-06-13  Pedro Alves  <palves@redhat.com>
 465
 466         * stack.c (parse_backtrace_qualifiers): New.
 467         (backtrace_command): Use it.
 468         (backtrace_command_completer): Complete on qualifiers.
 469
 470 2019-06-13  Pedro Alves  <palves@redhat.com>
 471
 472         * frame.c: Include "cli/cli-option.h.
 473         (user_set_backtrace_options): New.
 474         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
 475         Delete.
 476         (get_prev_frame): Adjust.
 477         (boolean_option_def, uinteger_option_def)
 478         (set_backtrace_option_defs): New.
 479         (_initialize_frame): Adjust and use
 480         gdb::option::add_setshow_cmds_for_options to install "set
 481         backtrace past-main" and "set backtrace past-entry".
 482         * frame.h: Include "cli/cli-option.h".
 483         (struct frame_print_options): Forward declare.
 484         (print_frame_arguments_all, print_frame_arguments_scalars)
 485         (print_frame_arguments_none): Declare.
 486         (print_entry_values): Delete declaration.
 487         (struct frame_print_options, user_frame_print_options): New.
 488         (struct set_backtrace_options): New.
 489         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
 490         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
 491         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
 492         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
 493         (list_args_or_locals): Add frame_print_options parameter.
 494         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 495         * python/py-framefilter.c (enumerate_args): Pass down
 496         USER_FRAME_PRINT_OPTIONS.
 497         * stack.c: Include "cli/cli-option.h".
 498         (print_frame_arguments_all, print_frame_arguments_scalars)
 499         (print_frame_arguments_none): Declare.
 500         (print_raw_frame_arguments, print_entry_values): Delete.
 501         (user_frame_print_options): New.
 502         (boolean_option_def, enum_option_def, frame_print_option_defs):
 503         New.
 504         (struct backtrace_cmd_options): New.
 505         (bt_flag_option_def): New.
 506         (backtrace_command_option_defs): New.
 507         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 508         (print_frame_arg, read_frame_arg, print_frame_args)
 509         (print_frame_info, print_frame): Add frame_print_options parameter
 510         and use it.
 511         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
 512         (backtrace_command_1): Add frame_print_options and
 513         backtrace_cmd_options parameters and use them.
 514         (make_backtrace_options_def_group): New.
 515         (backtrace_command): Process command options with
 516         gdb::option::process_options.
 517         (backtrace_command_completer): New.
 518         (_initialize_stack): Extend "backtrace"'s help to mention
 519         supported options.  Install completer for "backtrace".
 520         Install some settings commands with add_setshow_cmds_for_options.
 521
 522 2019-06-13  Pedro Alves  <palves@redhat.com>
 523
 524         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
 525         and that "set/show print raw frame-arguments" are now deprecated.
 526
 527         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
 528         command.
 529         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
 530         * stack.c (_initialize_stack): Install "set/show print
 531         raw-frame-arguments", and deprecate "set/show print raw
 532         frame-arguments".
 533         * valprint.c (_initialize_valprint): Deprecate "set/show print
 534         raw".
 535
 536 2019-06-13  Pedro Alves  <palves@redhat.com>
 537
 538         * compile/compile.c (struct compile_options): New.
 539         (compile_flag_option_def, compile_command_option_defs)
 540         (make_compile_options_def_group): New.
 541         (compile_file_command): Handle options with
 542         gdb::option::process_options.
 543         (compile_file_command_completer): New function.
 544         (compile_code_command): Handle options with
 545         gdb::option::process_options.
 546         (compile_code_command_completer): New function.
 547         (_initialize_compiler): Install completers for "compile code" and
 548         "compile file".  Mention available options in "compile code" and
 549         "compile code"'s help.
 550         * completer.c (advance_to_completion_word): New, factored out from
 551         ...
 552         (advance_to_expression_complete_word_point): ... this.
 553         (advance_to_filename_complete_word_point): New.
 554         * completer.h (advance_to_filename_complete_word_point): New
 555         declaration.
 556
 557 2019-06-13  Pedro Alves  <palves@redhat.com>
 558
 559         * compile/compile.c: Include "cli/cli-option.h".
 560         (compile_print_value): Scope data pointer is now a
 561         value_print_options pointer; adjust.
 562         (compile_print_command): Process options.  Scope data pointer is
 563         now a value_print_options pointer; adjust.
 564         (_initialize_compile): Update "compile print"'s help to include
 565         supported options.  Install a completer for "compile print".
 566         * cp-valprint.c (show_vtblprint, show_objectprint)
 567         (show_static_field_print): Delete.
 568         (_initialize_cp_valprint): Don't install "set print
 569         static-members", "set print vtbl", "set print object" here.
 570         * printcmd.c: Include "cli/cli-option.h" and
 571         "common/gdb_optional.h".
 572         (print_command_parse_format): Rework to fill in a
 573         value_print_options instead of a format_data.
 574         (print_value): Change parameter type from format_data pointer to
 575         value_print_options reference.  Adjust.
 576         (print_command_1): Process options.  Adjust to pass down a
 577         value_print_options.
 578         (print_command_completer): New.
 579         (_initialize_printcmd): Install print_command_completer as
 580         handle_brkchars completer for the "print" command.  Update
 581         "print"'s help to include supported options.
 582         * valprint.c: Include "cli/cli-option.h".
 583         (show_vtblprint, show_objectprint, show_static_field_print): Moved
 584         here from cp-valprint.c.
 585         (boolean_option_def, uinteger_option_def)
 586         (value_print_option_defs, make_value_print_options_def_group):
 587         New.  Use gdb::option::add_setshow_cmds_for_options to install
 588         "set print elements", "set print null-stop", "set print repeats",
 589         "set print pretty", "set print union", "set print array", "set
 590         print address", "set print symbol", "set print array-indexes".
 591         * valprint.h: Include <string> and "cli/cli-option.h".
 592         (make_value_print_options_def_group): Declare.
 593         (print_value): Change parameter type from format_data pointer to
 594         value_print_options reference.
 595         (print_command_completer): Declare.
 596
 597 2019-06-13  Pedro Alves  <palves@redhat.com>
 598
 599         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
 600         (COMMON_SFILES): Add maint-test-settings.c.
 601         * cli/cli-decode.c (boolean_enums): New global, factored out from
 602         ...
 603         (add_setshow_boolean_cmd): ... here.
 604         * cli/cli-decode.h (boolean_enums): Declare.
 605         * cli/cli-option.c: New file.
 606         * cli/cli-option.h: New file.
 607         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
 608         factored out from ...
 609         (parse_cli_boolean_value(const char *)): ... this.
 610         (is_unlimited_literal): Change parameter type to pointer to
 611         pointer.  Adjust and advance ARG pointer.
 612         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 613         (parse_cli_var_enum): New, factored out from ...
 614         (do_set_command): ... this.  Adjust.
 615         * cli/cli-setshow.h (parse_cli_boolean_value)
 616         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 617         (parse_cli_var_enum): Declare.
 618         * cli/cli-utils.c: Include "cli/cli-option.h".
 619         (get_ulongest): New.
 620         * cli/cli-utils.h (get_ulongest): Declare.
 621         (check_for_argument): New overloads.
 622         * maint-test-options.c: New file.
 623
 624 2019-06-13  Pedro Alves  <palves@redhat.com>
 625
 626         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
 627         parse a range if "-" is at the end of the string.
 628
 629 2019-06-13  Pedro Alves  <palves@redhat.com>
 630
 631         * cli/cli-setshow.c (parse_auto_binary_operation)
 632         (parse_cli_boolean_value): Don't allow "o".
 633
 634 2019-06-13  Pedro Alves  <palves@redhat.com>
 635
 636         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
 637         * NEWS: Mention maint test-settings KIND.
 638         * maint-test-settings.c: New file.
 639
 640 2019-06-13  Pedro Alves  <palves@redhat.com>
 641
 642         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
 643         completer.
 644         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
 645         "set" completers.
 646
 647 2019-06-13  Pedro Alves  <palves@redhat.com>
 648
 649         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
 650         after item.
 651
 652 2019-06-13  Pedro Alves  <palves@redhat.com>
 653
 654         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
 655
 656 2019-06-13  Pedro Alves <palves@redhat.com>
 657
 658         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
 659         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
 660         call.
 661         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
 662         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
 663         calls.
 664         (check_for_argument): Skip spaces after argument.
 665
 666 2019-06-13  Pedro Alves  <palves@redhat.com>
 667
 668         * thread.c (thread_apply_command): Adjust TID parsing.
 669         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
 670         detected before end of string.
 671         (tid_is_in_list): Error out if LIST is invalid.
 672
 673 2019-06-13  Pedro Alves  <palves@redhat.com>
 674
 675         * completer.c (complete_line_internal_1): Rewind completion word
 676         point.
 677         (completion_tracker::advance_custom_word_point_by): Change
 678         parameter type to int.
 679         * completer.h (completion_tracker::advance_custom_word_point_by):
 680         Likewise.
 681
 682 2019-06-13  Pedro Alves  <palves@redhat.com>
 683
 684         * completer.c (advance_to_completion_word): Handle delimiters.
 685
 686 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
 687
 688         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
 689
 690 2019-06-11  Tom Tromey  <tom@tromey.com>
 691
 692         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
 693         (xmalloc_failed): Move to alloc.c.
 694         * alloc.c: New file.
 695         * Makefile.in (COMMON_SFILES): Add alloc.c.
 696
 697 2019-06-11  Tom Tromey  <tom@tromey.com>
 698
 699         * nat/linux-waitpid.c: Don't include server.h.
 700         (linux_debug): Remove.
 701         (my_waitpid): Update.
 702
 703 2019-06-11  Tom Tromey  <tromey@adacore.com>
 704
 705         * infcall.c (_initialize_infcall): Remove trailing newline from
 706         help.
 707         * user-regs.c (_initialize_user_regs): Remove trailing newline
 708         from help.
 709         * typeprint.c (_initialize_typeprint): Remove trailing newline
 710         from help.
 711         * reverse.c (_initialize_reverse): Remove trailing newlines from
 712         help.
 713         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
 714         from help.
 715         * language.c (add_set_language_command): Remove trailing newline
 716         from help.
 717         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
 718         help.
 719         * disasm.c (_initialize_disasm): Remove trailing newline from
 720         help.
 721         * top.c (init_main): Remove trailing newline from help.
 722         * interps.c (_initialize_interpreter): Remove trailing newline
 723         from help.
 724         * btrace.c (_initialize_btrace): Remove trailing newlines from
 725         help.
 726         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
 727         from help.
 728         * python/python.c (_initialize_python): Remove trailing newline
 729         from help.
 730         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
 731         help.
 732         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
 733         from help.  Reformat some text.
 734         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
 735         from help.
 736         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
 737         newline from help.
 738
 739 2019-06-11  Tom Tromey  <tromey@adacore.com>
 740
 741         * darwin-nat.c (darwin_decode_exception_message)
 742         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
 743
 744 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 745
 746         * valops.c (value_slice): Check for not allocated or not
 747         associated values.
 748
 749 2019-06-10  Tom de Vries  <tdevries@suse.de>
 750
 751         PR gdb/24618
 752         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
 753         sure an empty slot (defined by a 32-bit zero pair) is recognized as
 754         invalid.
 755
 756 2019-06-10  Tom de Vries  <tdevries@suse.de>
 757
 758         PR gdb/24611
 759         * linespec.c (linespec_lexer_lex_string): Remove incorrect
 760         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
 761
 762 2019-06-10  Tom de Vries  <tdevries@suse.de>
 763
 764         PR symtab/24545
 765         * symtab.c (struct demangled_name_entry): Add language field.
 766         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
 767         static minimal symbol".  Set and use language field.
 768
 769 2019-06-10  Tom Tromey  <tromey@adacore.com>
 770
 771         * ada-lang.c (_initialize_ada_language): Update help text.
 772
 773 2019-06-10  Tom Tromey  <tromey@adacore.com>
 774
 775         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
 776         with a newline.
 777         * guile/guile.c (handle_boot_error): Don't end warning with a
 778         newline.
 779         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
 780         warning with a newline.
 781         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
 782         newline.
 783         (s12z_frame_cache): Likewise.
 784         * dwarf-index-cache.c (index_cache::store): Don't end warning with
 785         a newline.
 786         * solib-svr4.c (disable_probes_interface): Don't end warning with
 787         a newline.
 788         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
 789         newline.
 790         * python/python.c (do_finish_initialization): Don't end warning
 791         with a newline.
 792
 793 2019-06-10  Tom Tromey  <tom@tromey.com>
 794
 795         * python/py-breakpoint.c (gdbpy_breakpoint_created)
 796         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
 797         gdbpy_enter.
 798
 799 2019-06-10  Tom Tromey  <tromey@adacore.com>
 800
 801         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
 802         data.
 803         (elf_new_init): Don't call stabsread_new_init.
 804         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
 805         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
 806         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
 807
 808 2019-06-10  Tom de Vries  <tdevries@suse.de>
 809
 810         PR symtab/16264
 811         PR symtab/24517
 812         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
 813
 814 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
 815
 816         * source.c (find_and_open_source): Also rewrite relative file
 817         names.
 818
 819 2019-04-26  Amos Bird  <amosbird@gmail.com>
 820
 821         * annotate.c (annotate_thread_exited): Add "thread-exited"
 822         annotation.
 823
 824 2019-06-06  Tom Tromey  <tromey@adacore.com>
 825
 826         * maint.h (class scoped_command_stats): Use
 827         DISABLE_COPY_AND_ASSIGN.
 828         <print_time>: New method.
 829         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
 830         print_time.
 831         (scoped_command_stats::print_time): New method.
 832
 833 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
 834
 835         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
 836         instructions of lengths 6 or 8 bytes.
 837
 838 2019-06-04  Pedro Alves  <palves@redhat.com>
 839
 840         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
 841
 842         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
 843         * breakpoint.c (condition_completer): Likewise.
 844         * cli/cli-dump.c (scan_expression): Likewise.
 845         * common/filestuff.c (mkdir_recursive): Likewise.
 846         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
 847         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
 848         (gdb_abspath): Likewise.
 849         * compile/compile-cplus-types.c
 850         (compile_cplus_instance::decl_name): Likewise.
 851         * completer.c (complete_explicit_location):
 852         (signal_completer, reg_or_group_completer_1): Likewise.
 853         * cp-support.c (cp_remove_params_if_any): Likewise.
 854         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
 855         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
 856         * infcmd.c (strip_bg_char): Likewise.
 857         * linespec.c (copy_token_string): Likewise.
 858         * mi/mi-main.c (output_cores): Likewise.
 859         * psymtab.c (psymtab_search_name):
 860         * symfile.c (test_set_ext_lang_command): Likewise.
 861         * target.c (target_fileio_read_stralloc): Likewise.
 862         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
 863         * value.c (complete_internalvar): Likewise.
 864
 865 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
 866
 867         Add objfile property to gdb.Type.
 868         * NEWS: Mention Python API addition.
 869         * python/py-type.c (typy_get_objfile): New method.
 870
 871 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 872
 873         * NEWS: Mention the new set|show style [title|highlight].
 874         Mention changes to "show style", "help" and "apropos".
 875
 876 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 877
 878         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
 879         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
 880         instead of print_help_for_command.
 881         (print_doc_of_command): New function.
 882         (help_list): Add 'apropos -v word' suggestion.
 883         (print_help_for_command): Style the command name using title style.
 884         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
 885         (_initialize_cli_cmds): Describe -v in apropos_command help.
 886
 887 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 888
 889         * cli/cli-style.h (cli_style_option): Add name in constructor,
 890         add m_name class member, add constructor with intensity,
 891         add name class function.
 892         (cli_style_option::add_setshow_commands): Remove name argument.
 893         (highlight_style, title_style): New styles.
 894         * cli/cli-style.c (do_show): New function that shows a style
 895         characteristic styling the style name with itself.
 896         (set_style_name): New function.
 897         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
 898         Update all callers according to the changes in cli/cli-style.h.
 899         * utils.h (fputs_highlighted): New function.
 900         * utils.c (fputs_highlighted): Likewise.
 901
 902 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 903
 904         * NEWS: Mention new pipe command and new convenience variables.
 905
 906 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 907
 908         * cli/cli-cmds.c (pipe_command): New function.
 909         (_initialize_cli_cmds): Call add_com for pipe_command.
 910         Define | as an alias for pipe.
 911         (exit_status_set_internal_vars): New function.
 912         (shell_escape): Call exit_status_set_internal_vars.
 913         cli/cli-decode.c (find_command_name_length): Recognize | as
 914         a single character command.
 915
 916 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 917
 918         * gdbcmd.h (execute_command_to_ui_file): New declaration.
 919         top.c (execute_command_to_ui_file): New function, mostly a copy
 920         of execute_command_to_string.
 921         (execute_command_to_string): Implement by calling
 922         execute_command_to_ui_file.
 923
 924 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 925
 926         * top.h (saved_command_line): Remove declaration.
 927         * top.c (previous_saved_command_line, previous_repeat_arguments):
 928         New variables.
 929         (saved_command_line): Make static, define together with other
 930         'repeat variables'.
 931         (dont_repeat): Clear repeat_arguments.
 932         (repeat_previous, get_saved_command_line, save_command_line):
 933         New functions.
 934         (gdb_init): Initialize saved_command_line
 935         and previous_saved_command_line.
 936         * main.c (captured_main_1): Remove saved_command_line initialization.
 937         * event-top.c (handle_line_of_input): Update to use
 938         the new 'repeat' related functions instead of direct access to
 939         saved_command_line.
 940         * command.h (repeat_previous, get_saved_command_line,
 941         save_command_line): New declarations.
 942         (dont_repeat): Add comment.
 943
 944 2019-05-30  Tom Tromey  <tromey@adacore.com>
 945
 946         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
 947         Fix comment.
 948         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
 949
 950 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
 951
 952         PR cli/24587
 953         * completer.c (complete): Initialize variable word.
 954
 955 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
 956
 957         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 958         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
 959         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
 960         'body' is NULL to the outter 'if', protecting the '!is_define'
 961         situation as well.
 962
 963 2019-05-29  Tom Tromey  <tromey@adacore.com>
 964
 965         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
 966         (dwarf_unknown): New function.
 967         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
 968         (dwarf_type_encoding_name): Use dwarf_unknown.
 969
 970 2019-05-29  Tom Tromey  <tromey@adacore.com>
 971
 972         PR c++/20020:
 973         * cp-valprint.c (cp_print_value_fields): Call
 974         cp_print_static_field inside "try".
 975
 976 2019-05-29  Tom Tromey  <tromey@adacore.com>
 977
 978         * inflow.c (struct terminal_info): Add default operator=.
 979         * configure: Rebuild.
 980         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
 981         -Wdeprecated-copy-dtor, -Wredundant-move.
 982
 983 2019-05-29  Tom Tromey  <tromey@adacore.com>
 984
 985         * NEWS: Add entry.
 986         * infcmd.c (print_return_value_1): Handle finish_print
 987         option.
 988         (show_print_finish): New function.
 989         (_initialize_infcmd): Add "set/show print finish" commands.
 990         * valprint.c (user_print_options): Initialize new member.
 991         * valprint.h (struct value_print_options) <finish_print>: New
 992         member.
 993
 994 2019-05-28  Tom Tromey  <tromey@adacore.com>
 995
 996         * ada-lang.c (ada_remove_Xbn_suffix)
 997         (find_old_style_renaming_symbol)
 998         (parse_old_style_renaming): Remove.
 999         (ada_find_renaming_symbol): Don't call
1000         find_old_style_renaming_symbol.
1001         (ada_is_renaming_symbol): Rename from
1002         ada_find_renaming_symbol.  Remove "block" parameter.  Return
1003         bool.  Now static.
1004         (ada_read_var_value): Update and simplify.
1005         * ada-exp.y (write_var_or_type): Remove old code.
1006
1007 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
1008
1009         * event-top.c: Remove include comment.
1010         * inflow.c (class scoped_ignore_sigttou): Move from here...
1011         * inflow.h (class scoped_ignore_sigttou): ...to here.
1012         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
1013         * top.c:  Remove include comment.
1014
1015 2019-05-27  Tom Tromey  <tom@tromey.com>
1016
1017         * NEWS: Fix typo.
1018
1019 2019-05-22  Tom Tromey  <tromey@adacore.com>
1020
1021         * target.c (target_follow_exec): Constify parameter.
1022         * target-delegates.c: Rebuild.
1023         * remote.c (remote_target::follow_exec): Constify parameter.
1024         * infrun.c (follow_exec): Constify parameter.
1025         * target.h (struct target_ops) <follow_exec>: Constify parameter.
1026         (target_follow_exec): Likewise.
1027
1028 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1029
1030         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
1031         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
1032
1033 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1034
1035         * NEWS: Add debugredirect and testsuite sections.
1036
1037 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
1038
1039         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
1040         target descriptions using exclusively floating point register name
1041         aliases.
1042
1043 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1044
1045         PR gdb/18644:
1046         * f-lang.c (build_fortran_types): Handle the case where
1047         gdbarch_floatformat_for_type returns a nullptr.
1048
1049 2019-05-21  Tom de Vries  <tdevries@suse.de>
1050
1051         PR cli/24587
1052         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
1053
1054 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1055
1056         PR gdb/18644:
1057         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
1058         16-byte floats.
1059         * i386-tdep.c (i386_floatformat_for_type): Use
1060         floatformats_ia64_quad for the 16-byte floating point component
1061         within a fortran 32-byte complex number.
1062
1063 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1064
1065         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
1066         delete default constructor.
1067         (find_partial_die): Update to return const struct.
1068         (partial_die_parent_scope): Move variable declaration into scope
1069         of its use and change its type to auto.
1070         (guess_partial_die_structure_name): Likewise.
1071         (partial_die_info::fixup): Likewise.
1072
1073 2019-05-17  Tom Tromey  <tromey@adacore.com>
1074
1075         * source.c (find_and_open_source): Remove cast.
1076
1077 2019-05-17  Tom Tromey  <tromey@adacore.com>
1078
1079         * annotate.c (annotate_source): Make "filename" const.
1080         * annotate.h (annotate_source): Use const.
1081
1082 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1083
1084         * disasm.c (set_disassembler_options): Send errors to stderr.
1085
1086 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1087
1088         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
1089         (cli_interp_base::set_logging): Check debug_redirect.
1090         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
1091         * cli/cli-logging.c (debug_redirect): Add static variable.
1092         (pop_output_files): Add default param.
1093         (handle_redirections): Print debug setting.
1094         (show_logging_command): Likewise.
1095         (_initialize_cli_logging): Add debugredirect command.
1096         * interps.c (current_interp_set_logging): Add debug_redirect
1097         parameter.
1098         * interps.h (set_logging): Add debug_redirect parameter.
1099         (current_interp_set_logging): Likewise.
1100         * mi/mi-common.h: Likewise.
1101         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
1102
1103 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1104             Tom Tromey  <tromey@adacore.com>
1105
1106         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
1107         directly.
1108         * cli/cli-interp.h (make_logging_output): Remove declaration.
1109         * cli/cli-logging.c (make_logging_output): Remove function.
1110         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
1111         directly.
1112         * ui-file.c (tee_file::tee_file): Remove bools.
1113         (tee_file::~tee_file): Remove deletes.
1114         * ui-file.h (tee_file): Remove bools.
1115
1116 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
1117
1118         * mi/mi-cmds.h (mi_cmd_complete): New function.
1119         * mi/mi-main.c (mi_cmd_complete): Likewise.
1120         * mi/mi-cmds.c: Define new MI command -complete.
1121         * NEWS: Mention new -complete command.
1122
1123 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
1124
1125         * completer.h (complete): New function.
1126         * completer.c (complete): Likewise.
1127         * cli/cli-cmds.c: (complete_command): Update to use new complete()
1128         function defined in completer.h.
1129
1130 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
1131
1132         * MAINTAINERS (Write After Approval): Add myself.
1133
1134 2019-05-17  Tom de Vries  <tdevries@suse.de>
1135
1136         PR gdb/24094
1137         * dwarf2read.c (struct cu_partial_die_info): New struct.
1138         (find_partial_die): Return cu_partial_die_info.
1139         (partial_die_parent_scope, guess_partial_die_structure_name)
1140         (partial_die_info::fixup): Handle new return type of find_partial_die.
1141
1142 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1143
1144         * stap-probe.c (stap_parse_register_operand): Make "regname" an
1145         "std::string", simplifying the algorithm.
1146
1147 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1148
1149         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
1150         (stap_static_probe_ops::get_probes): Likewise.
1151
1152 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1153
1154         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
1155         '-')" and "else if".
1156         (stap_parse_single_operand): Join checks for
1157         "gdbarch_stap_parse_special_token_p" and
1158         "gdbarch_stap_parse_special_token" in the same "if" statement.
1159         Invert check when verifying for operation on register
1160         displacement.
1161
1162 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1163
1164         * stap-probe.c (stap_get_opcode): Update comment.
1165         (stap_get_expected_argument_type): Likewise.
1166         (handle_stap_probe): Likewise.
1167
1168 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1169
1170         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
1171         return type to 'bool'.  Adjust comment.  Use 'bool' when
1172         appropriate.
1173         (i386_stap_parse_special_token_three_arg_disp): Likewise.
1174         * stap-probe.c (stap_parse_argument_1): Likewise.
1175         (stap_is_operator): Likewise.
1176         (stap_is_generic_prefix): Likewise.
1177         (stap_is_register_prefix): Likewise.
1178         (stap_is_register_indirection_prefix): Likewise.
1179         (stap_is_integer_prefix): Likewise.
1180         (stap_generic_check_suffix): Likewise.
1181         (stap_check_integer_suffix): Likewise.
1182         (stap_check_register_suffix): Likewise.
1183         (stap_check_register_indirection_suffix): Likewise.
1184         (stap_parse_register_operand): Likewise.
1185         (stap_parse_single_operand): Likewise.
1186         (stap_parse_argument_1): Likewise.
1187         (stap_probe::get_argument_count): Likewise.
1188         (stap_is_operator): Likewise.
1189
1190 2019-05-16  Tom Tromey  <tromey@adacore.com>
1191
1192         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
1193         keyword to foreach.
1194
1195 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
1196
1197         * linux-thread-db.c (try_thread_db_load_1): Change return type
1198         to bool.
1199         (try_thread_db_load): Likewise.
1200         (try_thread_db_load_from_pdir_1): Likewise.
1201         (try_thread_db_load_from_pdir): Likewise.
1202         (try_thread_db_load_from_sdir): Likewise.
1203         (try_thread_db_load_from_dir): Likewise.
1204         (thread_db_load_search): Likewise.
1205         (has_libpthread): Likewise.
1206         (thread_db_load): Likewise.
1207
1208 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
1209
1210         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1211         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
1212         NULL, and complain/return if that's the case.
1213
1214 2019-05-15  John Darrington <john@darrington.wattle.id.au>
1215
1216         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
1217         (advance, posn, abstract_read_memory): New functions.
1218         [struct mem_read_abstraction]: New struct.
1219         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
1220
1221 2019-05-14  Tom Tromey  <tromey@adacore.com>
1222
1223         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
1224         value is not lval_memory.
1225
1226 2019-05-14  Tom Tromey  <tromey@adacore.com>
1227
1228         * solib.c (info_sharedlibrary_command): Style the file name.
1229
1230 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
1231
1232         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
1233         (aarch64_vnv_type): Likewise.
1234         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
1235         * common/tdesc.c: Likewise.
1236         * common/tdesc.h (enum tdesc_type_kind): Likewise.
1237         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
1238         * features/aarch64-fpu.xml: Add ieee half view.
1239         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
1240         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
1241         * gdbtypes.h (struct builtin_type): Likewise.
1242         (struct objfile_type): Likewise.
1243
1244 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
1245
1246         * language.c (language_sniff_from_mangled_name): Fix "langauge"
1247         typo.
1248         * location.h (string_to_event_location): Likewise.
1249
1250 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
1251
1252         GDB 8.3 released.
1253
1254 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1255
1256         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
1257         New variable declaration.
1258         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
1259         New variable.
1260         (print_one_breakpoint): Use ui_out::test_flags and new global
1261         variable to compute use_fixed_output.
1262         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
1263         Remove.
1264         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
1265         (mi_multi_location_breakpoint_output_fixed): Remove.
1266         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
1267         new variable.
1268         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
1269         fix_multi_location_breakpoint_output flag if version >= 3.
1270         * ui-out.h (enum ui_out_flag)
1271         <fix_multi_location_breakpoint_output>: New enumerator.
1272
1273 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1274
1275         * contrib/cc-with-tweaks.sh: Validate dwz's work.
1276
1277 2019-05-10  Tom Tromey  <tromey@adacore.com>
1278
1279         * ada-lang.c (catch_ada_completer): New function.
1280         (_initialize_ada_language): Use it.
1281
1282 2019-05-10  Tom Tromey  <tromey@adacore.com>
1283
1284         * thread.c (print_thread_info): Make "requested_threads" const.
1285         * gdbthread.h (print_thread_info): Make "requested_threads"
1286         const.
1287         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
1288         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
1289
1290 2019-05-08  Tom Tromey  <tom@tromey.com>
1291
1292         * gdbtypes.c (objfile_type_data): Change type.
1293         (objfile_type, _initialize_gdbtypes): Update.
1294
1295 2019-05-08  Tom Tromey  <tom@tromey.com>
1296
1297         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
1298         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
1299         (_initialize_dwarf2_frame): Update.
1300
1301 2019-05-08  Tom Tromey  <tom@tromey.com>
1302
1303         * objc-lang.c (objc_objfile_data): Change type.
1304         (find_methods): Update.
1305         (_initialize_objc_lang): Remove.
1306
1307 2019-05-08  Tom Tromey  <tom@tromey.com>
1308
1309         * stabsread.c (rs6000_builtin_type_data): Change type.
1310         (rs6000_builtin_type, _initialize_stabsread): Update.
1311
1312 2019-05-08  Tom Tromey  <tom@tromey.com>
1313
1314         * mips-tdep.c (mips_pdr_data): Remove.
1315         (_initialize_mips_tdep): Update.
1316
1317 2019-05-08  Tom Tromey  <tom@tromey.com>
1318
1319         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
1320         (hppa_init_objfile_priv_data, read_unwind_info)
1321         (find_unwind_entry, _initialize_hppa_tdep): Update.
1322
1323 2019-05-08  Tom Tromey  <tom@tromey.com>
1324
1325         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
1326         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
1327         on obstack.
1328         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
1329
1330 2019-05-08  Tom Tromey  <tom@tromey.com>
1331
1332         * mdebugread.c (basic_type_data): Change type.
1333         (basic_type, _initialize_mdebugread): Update.
1334
1335 2019-05-08  Tom Tromey  <tom@tromey.com>
1336
1337         * common/gdb_unique_ptr.h (struct noop_deleter): New.
1338
1339 2019-05-08  Tom Tromey  <tom@tromey.com>
1340
1341         * nto-tdep.c (nto_inferior_data_reg): Change type.
1342         (nto_inferior_data): Update.
1343         (nto_inferior_data_cleanup, nto_new_inferior_data)
1344         (_initialize_nto_tdep): Remove.
1345         * nto-tdep.h (struct nto_inferior_data): Add initializers.
1346
1347 2019-05-08  Tom Tromey  <tom@tromey.com>
1348
1349         * ada-lang.c (struct ada_inferior_data): Add initializers.
1350         (ada_inferior_data): Change type.
1351         (ada_inferior_data_cleanup): Remove.
1352         (get_ada_inferior_data, ada_inferior_exit)
1353         (struct ada_pspace_data): Add initializers, destructor.
1354         (ada_pspace_data_handle): Change type.
1355         (get_ada_pspace_data): Update.
1356         (ada_pspace_data_cleanup): Remove.
1357
1358 2019-05-08  Tom Tromey  <tom@tromey.com>
1359
1360         * coffread.c (struct coff_symfile_info): Add initializers.
1361         (coff_objfile_data_key): Move lower.  Change type.
1362         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
1363         Update.
1364         (coff_free_info): Remove.
1365
1366 2019-05-08  Tom Tromey  <tom@tromey.com>
1367
1368         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
1369         (fbsd_pspace_data_handle): Move lower.  Change type.
1370         (get_fbsd_pspace_data): Update.
1371         (fbsd_pspace_data_cleanup): Remove.
1372         (_initialize_fbsd_tdep): Update.
1373
1374 2019-05-08  Tom Tromey  <tom@tromey.com>
1375
1376         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
1377         (get_ada_tasks_pspace_data): Update.
1378         (ada_tasks_pspace_data_cleanup): Remove.
1379         (_initialize_tasks): Update.
1380         (ada_tasks_inferior_data_handle): Change type.
1381         (get_ada_tasks_inferior_data): Update.
1382         (ada_tasks_inferior_data_cleanup): Remove.
1383         (struct ada_tasks_pspace_data): Add initializers.
1384
1385 2019-05-08  Tom Tromey  <tom@tromey.com>
1386
1387         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
1388         * symfile-debug.c (debug_sym_get_probes): Change type.
1389         * stap-probe.c (handle_stap_probe):
1390         (stap_static_probe_ops::get_probes): Change type.
1391         * probe.h (class static_probe_ops) <get_probes>: Change type.
1392         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
1393         (parse_probes_in_pspace): Update.
1394         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
1395         Update.
1396         (any_static_probe_ops::get_probes): Change type.
1397         * elfread.c (elfread_data): New typedef.
1398         (probe_key): Change type.
1399         (elf_get_probes): Likewise.  Update.
1400         (probe_key_free): Remove.
1401         (_initialize_elfread): Update.
1402         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
1403         Change type.
1404         (dtrace_process_dof_probe, dtrace_process_dof)
1405         (dtrace_static_probe_ops::get_probe): Change type.
1406
1407 2019-05-08  Tom Tromey  <tom@tromey.com>
1408
1409         * xcoffread.c (struct xcoff_symfile_info): Rename from
1410         coff_symfile_info.  Add initializers.
1411         (xcoff_objfile_data_key): Move lower.  Change type.
1412         (XCOFF_DATA): Rewrite.
1413         (xcoff_free_info): Remove.
1414         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
1415         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
1416         (xcoff_initial_scan): Update.
1417
1418 2019-05-08  Tom Tromey  <tom@tromey.com>
1419
1420         * solib-svr4.c (struct svr4_info): Add initializers and
1421         destructor.
1422         <probes_table>: Now an htab_up.
1423         (solib_svr4_pspace_data): Change type.
1424         (free_probes_table): Simplify.
1425         (~svr4_info): Rename from svr4_pspace_data_cleanup.
1426         (get_svr4_info, probes_table_htab_remove_objfile_probes)
1427         (probes_table_remove_objfile_probes, register_solib_event_probe)
1428         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
1429         (_initialize_svr4_solib): Update.
1430
1431 2019-05-08  Tom Tromey  <tom@tromey.com>
1432
1433         * remote.c (remote_pspace_data): Change type.
1434         (remote_pspace_data_cleanup): Remove.
1435         (get_remote_exec_file, set_pspace_remote_exec_file)
1436         (_initialize_remote): Update.
1437
1438 2019-05-08  Tom Tromey  <tom@tromey.com>
1439
1440         * breakpoint.c (breakpoint_objfile_key): Change type.
1441         (get_breakpoint_objfile_data): Update.
1442         (free_breakpoint_objfile_data): Remove.
1443         (_initialize_breakpoint): Update.
1444
1445 2019-05-08  Tom Tromey  <tom@tromey.com>
1446
1447         * linux-tdep.c (struct linux_info): Add initializers.
1448         (linux_inferior_data): Move.  Change type.
1449         (invalidate_linux_cache_inf): Update.
1450         (linux_inferior_data_cleanup): Remove.
1451         (get_linux_inferior_data, _initialize_linux_tdep): Update.
1452
1453 2019-05-08  Tom Tromey  <tom@tromey.com>
1454
1455         * auxv.c (auxv_inferior_data): Move.  Change type.
1456         (auxv_inferior_data_cleanup): Remove.
1457         (invalidate_auxv_cache_inf): Rewrite.
1458         (get_auxv_inferior_data, _initialize_auxv): Update.
1459
1460 2019-05-08  Tom Tromey  <tom@tromey.com>
1461
1462         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
1463         (symfile_debug_objfile_data_key): Change type.
1464         (symfile_debug_installed, debug_qf_has_symbols)
1465         (debug_qf_find_last_source_symtab)
1466         (debug_qf_forget_cached_source_info)
1467         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
1468         (debug_qf_print_stats, debug_qf_dump)
1469         (debug_qf_expand_symtabs_for_function)
1470         (debug_qf_expand_all_symtabs)
1471         (debug_qf_expand_symtabs_with_fullname)
1472         (debug_qf_map_matching_symbols)
1473         (debug_qf_expand_symtabs_matching)
1474         (debug_qf_find_pc_sect_compunit_symtab)
1475         (debug_qf_map_symbol_filenames)
1476         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
1477         (debug_sym_new_init, debug_sym_init, debug_sym_read)
1478         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
1479         (debug_sym_read_linetable, debug_sym_relocate): Update.
1480         (symfile_debug_free_objfile): Remove.
1481         (install_symfile_debug_logging, _initialize_symfile_debug):
1482         Update.
1483
1484 2019-05-08  Tom Tromey  <tom@tromey.com>
1485
1486         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
1487         allocate_on_obstack.
1488         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
1489         (get_dwarf2_per_objfile): Update.
1490         (set_dwarf2_per_objfile): Remove.
1491         (dwarf2_has_info, dwarf2_get_section_info): Update.
1492         (dwarf2_free_objfile): Remove.
1493         (_initialize_dwarf2_read): Update.
1494
1495 2019-05-08  Tom Tromey  <tom@tromey.com>
1496
1497         * auto-load.c (struct auto_load_pspace_info): Add destructor and
1498         initializers.
1499         <unsupported_script_warning_printed,
1500         script_not_found_warning_printed>: Now bool.
1501         (auto_load_pspace_data): Change type.
1502         (~auto_load_pspace_info): Rename from
1503         auto_load_pspace_data_cleanup.
1504         (get_auto_load_pspace_data, init_loaded_scripts_info)
1505         (clear_section_scripts, maybe_print_unsupported_script_warning)
1506         (maybe_print_script_not_found_warning, _initialize_auto_load):
1507         Update.
1508
1509 2019-05-08  Tom Tromey  <tom@tromey.com>
1510
1511         * objfiles.c (objfile_pspace_info): Add destructor and
1512         initializers.
1513         (objfiles_pspace_data): Change type.
1514         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
1515         (get_objfile_pspace_data): Update.
1516         (objfiles_bfd_data): Change type.
1517         (get_objfile_bfd_data): Update.
1518         (objfile_bfd_data_free, _initialize_objfiles): Remove.
1519
1520 2019-05-08  Tom Tromey  <tom@tromey.com>
1521
1522         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
1523         Change type.
1524         (get_catch_syscall_inferior_data): Update.
1525         (catch_syscall_inferior_data_cleanup): Remove.
1526         (_initialize_break_catch_syscall): Update.
1527
1528 2019-05-08  Tom Tromey  <tom@tromey.com>
1529
1530         * inflow.c (struct terminal_info): Add destructor and
1531         initializers.
1532         (inflow_inferior_data): Change type.
1533         (~terminal_info): Rename from inflow_inferior_data_cleanup.
1534         (get_inflow_inferior_data, inflow_inferior_exit)
1535         (swap_terminal_info, _initialize_inflow): Update.
1536
1537 2019-05-08  Tom Tromey  <tom@tromey.com>
1538
1539         * target-dcache.c (target_dcache_cleanup): Remove.
1540         (target_dcache_aspace_key): Change type.
1541         (target_dcache_init_p, target_dcache_invalidate)
1542         (target_dcache_get, target_dcache_get_or_init)
1543         (_initialize_target_dcache): Update.
1544         * dcache.h (struct dcache_deleter): New.
1545
1546 2019-05-08  Tom Tromey  <tom@tromey.com>
1547
1548         * symtab.c (struct symbol_cache): Add destructor and
1549         initializers.
1550         (symbol_cache_key): Move.  Change type.
1551         (make_symbol_cache, free_symbol_cache): Remove.
1552         (get_symbol_cache): Update.
1553         (symbol_cache_cleanup): Remove.
1554         (ALL_PSPACES, symbol_cache_flush)
1555         (maintenance_print_symbol_cache)
1556         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
1557         Update.
1558
1559 2019-05-08  Tom Tromey  <tom@tromey.com>
1560
1561         * symtab.c (struct main_info): Add destructor and initializers.
1562         (main_progspace_key): Move.  Change type.
1563         (get_main_info): Update.
1564         (main_info_cleanup): Remove.
1565         (_initialize_symtab): Update.
1566
1567 2019-05-08  Tom Tromey  <tom@tromey.com>
1568
1569         * registry.h (DECLARE_REGISTRY): Define the _key class.
1570
1571 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1572
1573         * NEWS: Merge two 'New commands' sections.
1574
1575 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
1576
1577         * ada-valprint.c (ada_val_print_gnat_array): Remove language
1578         parameter and use Ada language definition instead.
1579         (ada_val_print_ptr): Remove unused language parameter.
1580         (ada_val_print_num): Remove language parameter and use Ada language
1581         definition instead.
1582         (ada_val_print_enum, ada_val_print_flt): Remove unused language
1583         parameter.
1584         (ada_val_print_struct_union, ada_val_print_ref): Remove language
1585         parameter and use Ada language definition instead.
1586         (ada_val_print_1): Update all ada_val_print_xxx calls.
1587         Remove language parameter.
1588         (ada_val_print): Update ada_val_print_1 call.
1589
1590 2019-05-08  Tom Tromey  <tromey@adacore.com>
1591
1592         * remote.c (remote_hw_watchpoint_limit)
1593         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
1594         Now static.
1595
1596 2019-05-08  Tom Tromey  <tromey@adacore.com>
1597
1598         * maint.c (_initialize_maint_cmds): Move initialization code to
1599         remote.c.
1600         (watchdog, show_watchdog): Move to remote.c.
1601         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
1602         "watchdog" static.
1603         (_initialize_remote): Move initialization code from maint.c.
1604         * defs.h (watchdog): Don't declare.
1605
1606 2019-05-08  Tom Tromey  <tromey@adacore.com>
1607
1608         * tui/tui-interp.c: Include main.h.
1609         * interps.c: Include main.h.
1610         * main.h (interpreter_p): Declare.
1611         * defs.h (interpreter_p): Don't declare.
1612
1613 2019-05-08  Tom Tromey  <tromey@adacore.com>
1614
1615         * dwarf2loc.c: Include dwarf2read.h.
1616         * defs.h (read_unsigned_leb128): Don't declare.
1617         * dwarf2read.h (read_unsigned_leb128): Declare.
1618
1619 2019-05-08  Tom Tromey  <tromey@adacore.com>
1620
1621         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
1622         method.
1623
1624 2019-05-08  Tom Tromey  <tromey@adacore.com>
1625
1626         * utils.c (fputs_maybe_filtered): Reset style after paging, even
1627         when no wrap column is set.
1628
1629 2019-05-08  Tom Tromey  <tromey@adacore.com>
1630
1631         * c-lang.c (c_get_string): Handle non-C-style arrays.
1632
1633 2019-05-08  Tom Tromey  <tromey@adacore.com>
1634
1635         * typeprint.c (print_offset_data::update): Print the bit offset,
1636         not the number of bits remaining.
1637
1638 2019-05-08  Tom Tromey  <tromey@adacore.com>
1639
1640         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
1641         padding at end of comment.
1642
1643 2019-05-08  Tom Tromey  <tromey@adacore.com>
1644
1645         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
1646         Compare main types.
1647
1648 2019-05-06  Tom Tromey  <tom@tromey.com>
1649
1650         * common/scoped_mmap.c: Include common-defs.h.
1651         * common/scoped_mmap.h: Don't include config.h.
1652
1653 2019-05-04  Tom Tromey  <tom@tromey.com>
1654
1655         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
1656         (struct aarch64_call_info): Add initializers.
1657         <si>: Now a std::vector.
1658         (pass_on_stack, aarch64_push_dummy_call): Update.
1659
1660 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
1661             Tom Tromey  <tom@tromey.com>
1662
1663         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
1664         (ppc_threads): Now a std::vector.  Now static.
1665         (hwdebug_find_thread_points_by_tid)
1666         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
1667         Update.
1668
1669 2019-05-04  Tom Tromey  <tom@tromey.com>
1670
1671         * arc-tdep.c (arc_tdesc_init): Return bool.
1672
1673 2019-05-04  Tom Tromey  <tom@tromey.com>
1674
1675         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
1676         Use gdb_assert_not_reached.
1677
1678 2019-05-04  Tom Tromey  <tom@tromey.com>
1679
1680         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
1681         "false".
1682
1683 2019-05-04  Tom Tromey  <tom@tromey.com>
1684
1685         * arc-tdep.c (arc_tdesc_init): Use bool.
1686
1687 2019-05-04  Tom Tromey  <tom@tromey.com>
1688
1689         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
1690
1691 2019-05-04  Tom Tromey  <tom@tromey.com>
1692
1693         * cli/cli-cmds.c (valid_command_p): Return bool.
1694
1695 2019-05-04  Tom Tromey  <tom@tromey.com>
1696
1697         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
1698         * command.h (valid_user_defined_cmd_name_p): Channge return type.
1699
1700 2019-05-04  Raul Tambre  <raul@tambre.ee>
1701
1702         * python/lib/gdb/prompt.py (_ExtendedPrompt)
1703         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
1704         operator for comparison.
1705
1706 2019-05-04  Tom Tromey  <tom@tromey.com>
1707
1708         * psymtab.c (psymbol_name_matches, match_partial_symbol)
1709         (lookup_partial_symbol, print_partial_symbols)
1710         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
1711         (psymbol_compare): Update.
1712         (add_psymbol_to_bcache): Clear the entire psymbol.
1713         (maintenance_check_psymtabs): Update.
1714         * psympriv.h (struct partial_symbol): Don't derive from
1715         general_symbol_info.
1716         <obj_section, unrelocated_address, address,
1717         set_unrelocated_address>: Update.
1718         <ginfo>: New member.
1719         * dwarf-index-write.c (write_psymbols, debug_names::insert)
1720         (debug_names::write_psymbols): Update.
1721
1722 2019-05-04  Tom de Vries  <tdevries@suse.de>
1723
1724         * contrib/cc-with-tweaks.sh: Support -n arg.
1725
1726 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1727
1728         * corelow.c (core_target::detach): Ensure frame cache and
1729         register caches are cleared.
1730         inferior.c (exit_inferior_1): Likewise.
1731
1732 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
1733             Tom Tromey  <tom@tromey.com>
1734
1735         * dictionary.c (collate_pending_symbols_by_language): Remove
1736         "struct" from foreach.
1737         * symtab.c (lookup_global_symbol_from_objfile)
1738         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
1739         foreach.
1740         * ser-tcp.c (net_open): Remove "struct" from foreach.
1741         * objfiles.c (objfile_relocate, objfile_rebase)
1742         (objfile_has_symbols): Remove "struct" from foreach.
1743         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
1744         from foreach.
1745         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
1746         foreach.
1747         * darwin-nat.c (thread_info_from_private_thread_info): Remove
1748         "struct" from foreach.
1749         * ada-lang.c (create_excep_cond_exprs)
1750         (ada_exception_catchpoint_cond_string): Remove "struct" from
1751         foreach.
1752
1753 2019-05-03  Tom Tromey  <tromey@adacore.com>
1754
1755         * ada-exp.y (convert_char_literal): Check suffix of each
1756         enumerator.
1757
1758 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
1759
1760         PR ada/21406:
1761         * ada-exp.y (yywrap): Don't define.
1762         * ada-lex.l (%option): Add noyywrap
1763         (yywrap): Remove.
1764
1765 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
1766
1767         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
1768         _WIN32_WINNT to the XP level, unless already defined to a higher
1769         level.
1770
1771         * unittests/parse-connection-spec-selftests.c:
1772         * ser-tcp.c:
1773         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
1774         override.
1775
1776         * symfile.c (find_separate_debug_file): Remove colon from the
1777         drive spec of DOS/Windows file names of the target, so that the
1778         file name produced from DEBUGDIR and the target's directory will
1779         be valid on DOS/Windows systems.
1780
1781 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1782
1783         * rust-lang.c (val_print_struct): Handle printing structures
1784         containing strings.
1785
1786 2019-05-02  Tom Tromey  <tromey@adacore.com>
1787
1788         * valarith.c (_initialize_valarith): Remove.
1789
1790 2019-05-01  Tom Tromey  <tromey@adacore.com>
1791
1792         * ada-lang.c (ada_value_primitive_field): Treat more fields as
1793         bitfields.
1794
1795 2019-05-01  Tom Tromey  <tromey@adacore.com>
1796
1797         * ada-lang.c (ada_value_assign): Correctly compute starting offset
1798         for big-endian copies.
1799
1800 2019-04-30  Ali Tamur  <tamur@google.com>
1801         * gdb/dwarf2read.c (read_3_bytes): New declaration.
1802         (read_attribute_value): Added DW_FORM_strx1-4 cases.
1803         (read_3_bytes): New function.
1804
1805 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1806
1807         * windows-nat.c (main_thread_id): Delete.
1808         (handle_output_debug_string): Replace main_thread_id by
1809         current_event.dwThreadId.
1810         (fake_create_process): Likewise.
1811         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
1812         Do not set main_thread_id.
1813         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
1814         current_event.dwThreadId.
1815         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
1816
1817 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1818
1819         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
1820         Use current_event.dwThreadId instead of main_thread_id.
1821
1822 2019-04-30  Tom Tromey  <tromey@adacore.com>
1823
1824         * ada-lang.c (ada_lookup_simple_minsyms): New function.
1825         (create_excep_cond_exprs): Iterate over program spaces.
1826         (ada_exception_catchpoint_cond_string): Examine all minimal
1827         symbols for exception types.
1828
1829 2019-04-30  Tom Tromey  <tromey@adacore.com>
1830
1831         PR c++/24470:
1832         * dwarf2read.c (process_structure_scope): Handle case where type
1833         has template parameters but no symbol was created.
1834
1835 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1836             Chris January  <chris.january@arm.com>
1837
1838         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
1839         qualifier.
1840         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
1841
1842 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1843
1844         * f-typeprint.c (f_print_type): Update rules for printing
1845         whitespace.
1846         (f_type_print_varspec_suffix): Likewise.
1847
1848 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1849             Chris January  <chris.january@arm.com>
1850
1851         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
1852         function arguments.
1853
1854 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1855
1856         * f-lang.c (build_fortran_types): Change name of void type to
1857         lower case.
1858         * f-typeprint.c (f_type_print_base): Print the name of the void
1859         type, rather than a fixed string.
1860         * f-valprint.c (f_decorations): Use lower case void string.
1861
1862 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1863             Chris January  <chris.january@arm.com>
1864
1865         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
1866         types for Fortran.
1867
1868 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1869             Chris January  <chris.january@arm.com>
1870             David Lecomber  <david.lecomber@arm.com>
1871
1872         * f-exp.y (BINOP_INTRINSIC): New token.
1873         (exp): New parser rule handling BINOP_INTRINSIC.
1874         (f77_keywords): Add new builtin procedures.
1875         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
1876         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1877         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
1878         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1879         (print_unop_subexp_f): New function.
1880         (print_binop_subexp_f): New function.
1881         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1882         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1883         (dump_subexp_body_f): Likewise.
1884         (operator_check_f): Likewise.
1885         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1886         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
1887
1888 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1889
1890         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
1891         UNOP_KIND.
1892         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
1893         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
1894         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
1895         (operator_length_f): New fuction.
1896         (print_subexp_f): New function.
1897         (op_name_f): New function.
1898         (dump_subexp_body_f): New function.
1899         (operator_check_f): New function.
1900         (exp_descriptor_f): Replace standard expression handling functions
1901         with new functions.
1902         * gdb/fortran-operator.def: New file.
1903         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
1904         * gdb/std-operator.def: Remove UNOP_KIND.
1905
1906 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1907
1908         * std-operator.def: Remove unbalanced, stray double quote
1909         character.
1910
1911 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1912             Chris January  <chris.january@arm.com>
1913             Daniel Everett  <daniel.everett@arm.com>
1914             Nick Forrington  <nick.forrington@arm.com>
1915             Richard Bunt  <richard.bunt@arm.com>
1916
1917         * cp-valprint.c (cp_print_value_fields): Allow an additional level
1918         of depth when printing anonymous structs or unions.
1919         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
1920         Don't print either the top-level value, or the children if the
1921         max-depth is exceeded.
1922         (ppscm_print_children): When printing the key of a map, allow one
1923         extra level of depth.
1924         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
1925         print either the top-level value, or the children if the max-depth
1926         is exceeded.
1927         (print_children): When printing the key of a map, allow one extra
1928         level of depth.
1929         * python/py-value.c (valpy_format_string): Add max_depth keyword.
1930         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
1931         (user_print_options): Initialise max_depth field.
1932         (val_print_scalar_or_string_type_p): New function.
1933         (val_print): Check to see if the max depth has been reached.
1934         (val_print_check_max_depth): Define new function.
1935         (show_print_max_depth): New function.
1936         (_initialize_valprint): Add 'print max-depth' option.
1937         * valprint.h (struct value_print_options) <max_depth>: New field.
1938         (val_print_check_max_depth): Declare new function.
1939         * NEWS: Document new feature.
1940
1941 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1942
1943         * ada-lang.c (ada_language_defn): Initialise new field.
1944         * c-lang.c (c_is_string_type_p): New function.
1945         (c_language_defn): Initialise new field.
1946         (cplus_language_defn): Initialise new field.
1947         (asm_language_defn): Initialise new field.
1948         (minimal_language_defn): Initialise new field.
1949         * c-lang.h (c_is_string_type_p): Declare new function.
1950         * d-lang.c (d_language_defn): Initialise new field.
1951         * f-lang.c (f_is_string_type_p): New function.
1952         (f_language_defn): Initialise new field.
1953         * go-lang.c (go_is_string_type_p): New function.
1954         (go_language_defn): Initialise new field.
1955         * language.c (default_is_string_type_p): New function.
1956         (unknown_language_defn): Initialise new field.
1957         (auto_language_defn): Initialise new field.
1958         * language.h (struct language_defn) <la_is_string_type_p>: New
1959         member variable.
1960         (default_is_string_type_p): Declare new function.
1961         * m2-lang.c (m2_language_defn): Initialise new field.
1962         * objc-lang.c (objc_language_defn): Initialise new field.
1963         * opencl-lang.c (opencl_language_defn): Initialise new field.
1964         * p-lang.c (pascal_is_string_type_p): New function.
1965         (pascal_language_defn): Initialise new field.
1966         * rust-lang.c (rust_is_string_type_p): New function.
1967         (rust_language_defn): Initialise new field.
1968
1969 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1970
1971         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
1972         New field.
1973         * ada-lang.c (ada_language_defn): Initialise new field.
1974         * c-lang.c (c_language_defn): Likewise.
1975         (cplus_language_defn): Likewise.
1976         (asm_language_defn): Likewise.
1977         (minimal_language_defn): Likewise.
1978         * d-lang.c (d_language_defn): Likewise.
1979         * f-lang.c (f_language_defn): Likewise.
1980         * go-lang.c (go_language_defn): Likewise.
1981         * language.c (unknown_language_defn): Likewise.
1982         (auto_language_defn): Likewise.
1983         * m2-lang.c (m2_language_defn): Likewise.
1984         * objc-lang.c (objc_language_defn): Likewise.
1985         * opencl-lang.c (opencl_language_defn): Likewise.
1986         * p-lang.c (pascal_language_defn): Likewise.
1987         * rust-lang.c (rust_language_defn): Likewise.
1988
1989 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1990
1991         * ada-lang.c (ada_is_character_type): Change return type to bool.
1992         (ada_is_string_type): Likewise.
1993         * ada-lang.h (ada_is_character_type): Update declaration
1994         (ada_is_string_type): Likewise.
1995
1996 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1997
1998         Support style in 'frame|thread apply'
1999
2000         * gdbcmd.h (execute_command_to_string): New term_out parameter.
2001         * record.c (record_start, record_stop): Update callers of
2002         execute_command_to_string with false.
2003         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
2004         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
2005         methods.
2006         (class string_file): New constructor with term_out parameter.
2007         Override methods term_out and can_emit_style_escape.  New member
2008         term_out.
2009         (class stdio_file): Override can_emit_style_escape.
2010         (class tee_file): Override term_out and can_emit_style_escape.
2011         * utils.h (can_emit_style_escape): Remove.
2012         * utils.c (can_emit_style_escape): Likewise.
2013         Update all callers of can_emit_style_escape (SOMESTREAM) to
2014         SOMESTREAM->can_emit_style_escape.
2015         * source-cache.c (source_cache::get_source_lines): Likewise.
2016         * stack.c (frame_apply_command_count): Call execute_command_to_string
2017         passing the term_out characteristic of the current gdb_stdout.
2018         * thread.c (thr_try_catch_cmd): Likewise.
2019         * top.c (execute_command_to_string): pass term_out parameter
2020         to construct the string_file for the command output.
2021         * ui-file.c (term_cli_styling): New function (most code moved
2022         from utils.c can_emit_style_escape).
2023         (string_file::string_file, string_file::can_emit_style_escape,
2024         stdio_file::can_emit_style_escape, tee_file::term_out,
2025         tee_file::can_emit_style_escape): New functions.
2026
2027 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2028
2029         * NEWS: Mention the new set|show may-call-functions.
2030         * infcall.c (may_call_functions_p): New variable.
2031         (show_may_call_functions_p): New function.
2032         (call_function_by_hand_dummy): Throws an error if not
2033         may-call-functions.
2034         (_initialize_infcall): Call add_setshow_boolean_cmd for
2035         may-call-functions.
2036
2037 2019-04-25  Keith Seitz  <keiths@redhat.com>
2038
2039         PR c++/24367
2040         * cp-support.c (inspect_type): Don't attempt substitutions
2041         of symbol with the same name.
2042
2043 2019-04-25  Tom Tromey  <tromey@adacore.com>
2044
2045         PR gdb/24475:
2046         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
2047         static.
2048
2049 2019-04-25  Tom Tromey  <tromey@adacore.com>
2050
2051         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
2052         rvalue reference.
2053         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
2054         (gdb_xml_parser::parse): Use std::move.
2055         * python/python-internal.h (gdbpy_convert_exception): Take a const
2056         reference.
2057         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
2058         std::move.
2059         * python/py-utils.c (gdbpy_convert_exception): Take a const
2060         reference.
2061         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2062         Use std::move.
2063         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2064         Use std::move.
2065         * mi/mi-main.c (mi_print_exception): Take a const reference.
2066         * main.c (handle_command_errors): Take a const reference.
2067         * linespec.c (parse_linespec): Use std::move.
2068         * infcall.c (run_inferior_call): Use std::move.
2069         (call_function_by_hand_dummy): Use std::move.
2070         * exec.c (try_open_exec_file): Use std::move.
2071         * exceptions.h (exception_print, exception_fprintf)
2072         (exception_print_same): Update.
2073         * exceptions.c (print_exception, exception_print)
2074         (exception_fprintf, exception_print_same): Change parameters to
2075         const reference.
2076         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
2077         * common/new-op.c: Use std::move.
2078         * common/common-exceptions.h (struct gdb_exception): Add move
2079         constructor.
2080         (struct gdb_exception_error, struct gdb_exception_quit, struct
2081         gdb_quit_bad_alloc): Change constructor to move constructor.
2082         (throw_exception): Change parameter to rvalue reference.
2083         * common/common-exceptions.c (throw_exception): Take rvalue
2084         reference.
2085         * cli/cli-interp.c (safe_execute_command): Use std::move.
2086         * breakpoint.c (insert_bp_location, location_to_sals): Use
2087         std::move.
2088
2089 2019-04-25  Tom Tromey  <tromey@adacore.com>
2090
2091         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
2092         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
2093         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
2094         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
2095         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
2096         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
2097         guile/scm-value.c: Use unpack.
2098         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
2099         gdbscm_gdb_exception.
2100         (gdbscm_throw_gdb_exception): Likewise.
2101         (struct gdbscm_gdb_exception): New.
2102         (unpack): New function.
2103         (gdbscm_wrap): Use unpack.
2104
2105 2019-04-25  Tom Tromey  <tromey@adacore.com>
2106
2107         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2108         (gdb_rl_callback_handler): Use std::move.
2109         * common/common-exceptions.h (struct gdb_exception): Add move
2110         assignment operator.
2111         (throw_exception_sjlj): Change "exception" to const reference.
2112         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
2113         (throw_exception_sjlj): Change "exception" to const reference.
2114
2115 2019-04-25  Tom Tromey  <tromey@adacore.com>
2116
2117         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
2118         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
2119         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2120         Update.
2121         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2122         Update.
2123         * mi/mi-interp.c (mi_interp::exec): Update.
2124         * linespec.c (parse_linespec): Update.
2125         * infcall.c (run_inferior_call): Update.
2126         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
2127         * guile/scm-symbol.c (gdbscm_lookup_symbol)
2128         (gdbscm_lookup_global_symbol): Update.
2129         * guile/scm-param.c (gdbscm_parameter_value): Update.
2130         * guile/scm-frame.c (gdbscm_frame_read_register)
2131         (gdbscm_frame_read_var): Update.
2132         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
2133         * exec.c (try_open_exec_file): Update.
2134         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2135         (gdb_rl_callback_handler): Update.
2136         * common/common-exceptions.h (exception_none): Don't declare.
2137         * common/common-exceptions.c (exception_none): Don't define.
2138         (struct catcher) <exception>: Update.
2139         * cli/cli-interp.c (safe_execute_command): Update.
2140         * breakpoint.c (insert_bp_location, location_to_sals): Update.
2141
2142 2019-04-25  Ali Tamur  <tamur@google.com>
2143
2144         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
2145         (read_attribute_value): Likewise.
2146         (dwarf2_read_addr_index): Update comment.
2147         (read_str_index): Add DW_FORM_strx.
2148         (dwarf2_string_attr): Likewise.
2149         (dwarf2_const_value_attr): Likewise.
2150         (dump_die_shallow): Likewise.
2151         (dwarf2_fetch_constant_bytes): Likewise.
2152         (skip_form_bytes): Likewise.
2153         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
2154
2155 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
2156
2157         PR corefiles/11608
2158         PR corefiles/18187
2159         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
2160         OFFSET.  Verify if current mapping contains an ELF header.
2161         (linux_find_memory_regions_full): Adjust call to
2162         dump_mapping_p.
2163
2164 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
2165             Kang Li <kanglictf@gmail.com>
2166
2167         PR gdb/21600
2168
2169         * dwarf2-frame.c (read_initial_length): Be consistent about using
2170         unsigned representation of length.
2171         (decode_frame_entry_1): Likewise.  Check for wraparound of
2172         end pointer as well as buffer overflow.
2173
2174 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
2175
2176         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
2177         "vq".
2178
2179 2019-04-24  Tom Tromey  <tromey@adacore.com>
2180
2181         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
2182
2183 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2184
2185         * s12z-tdep.c (s12z_unwind_pc): Delete.
2186         (s12z_unwind_sp): Delete.
2187         (s12z_gdbarch_init): Don't register deleted functions with
2188         gdbarch.
2189
2190 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2191
2192         * rl78-tdep.c (rl78_unwind_sp): Delete.
2193         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
2194
2195 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2196
2197         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
2198         (xstormy16_unwind_pc): Delete.
2199         (xstormy16_dummy_id): Delete.
2200         (xstormy16_gdbarch_init): Don't register deleted functions with
2201         gdbarch.
2202
2203 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2204
2205         * vax-tdep.c (vax_unwind_pc): Delete.
2206         (vax_gdbarch_init): Don't register deleted function with gdbarch.
2207
2208 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2209
2210         * v850-tdep.c (v850_unwind_sp): Delete.
2211         (v850_unwind_pc): Delete.
2212         (v850_dummy_id): Delete.
2213         (v850_gdbarch_init): Don't register deleted functions with
2214         gdbarch.
2215
2216 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2217
2218         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
2219         (tilegx_unwind_pc): Delete.
2220         (tilegx_unwind_dummy_id): Delete.
2221         (tilegx_gdbarch_init): Don't register deleted functions with
2222         gdbarch.
2223
2224 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2225
2226         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
2227         (tic6x_dummy_id): Delete.
2228         (tic6x_gdbarch_init): Don't register deleted functions with
2229         gdbarch.
2230
2231 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2232
2233         * sparc-tdep.c (sparc_unwind_pc): Delete.
2234         (sparc32_gdbarch_init): Don't register deleted function with
2235         gdbarch.
2236
2237 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2238
2239         * sh-tdep.c (sh_unwind_sp): Delete.
2240         (sh_unwind_pc): Delete.
2241         (sh_dummy_id): Delete.
2242         (sh_gdbarch_init): Don't register deleted functions with
2243         gdbarch.
2244
2245 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2246
2247         * score-tdep.c (score_unwind_sp): Delete.
2248         (score_unwind_pc): Delete.
2249         (score_dummy_id): Delete.
2250         (score_gdbarch_init): Don't register deleted functions with
2251         gdbarch.
2252
2253 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2254
2255         * rx-tdep.c (rx_unwind_pc): Delete.
2256         (rx_unwind_sp): Delete.
2257         (rx_dummy_id): Delete.
2258         (rx_gdbarch_init): Don't register deleted functions with
2259         gdbarch.  Update comment.
2260
2261 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2262
2263         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
2264         (rs6000_dummy_id): Delete.
2265         (rs6000_gdbarch_init): Don't register deleted functions with
2266         gdbarch.
2267
2268 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2269
2270         * or1k-tdep.c (or1k_dummy_id): Delete.
2271         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
2272
2273 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2274
2275         * nios2-tdep.c (nios2_dummy_id): Delete.
2276         (nios2_unwind_sp): Delete.
2277         (nios2_gdbarch_init): Don't register deleted functions with
2278         gdbarch.
2279
2280 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2281
2282         * nds32-tdep.c (nds32_dummy_id): Delete.
2283         (nds32_unwind_pc): Delete.
2284         (nds32_unwind_sp): Delete.
2285         (nds32_gdbarch_init): Don't register deleted functions with
2286         gdbarch.
2287
2288 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2289
2290         * msp430-tdep.c (msp430_unwind_pc): Delete.
2291         (msp430_unwind_sp): Delete.
2292         (msp430_dummy_id): Delete.
2293         (msp430_gdbarch_init): Don't register deleted functions with
2294         gdbarch.
2295
2296 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2297
2298         * moxie-tdep.c (moxie_unwind_sp): Delete.
2299         (moxie_unwind_pc): Delete.
2300         (moxie_dummy_id): Delete.
2301         (moxie_gdbarch_init): Don't register deleted functions with
2302         gdbarch.
2303
2304 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2305
2306         * mn10300-tdep.c (mn10300_dummy_id): Delete.
2307         (mn10300_unwind_pc): Delete.
2308         (mn10300_unwind_sp): Delete.
2309         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
2310         mn10300_unwind_sp.
2311         (mn10300_frame_unwind_init): Don't register deleted functions with
2312         gdbarch.
2313
2314 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2315
2316         * mep-tdep.c (mep_unwind_pc): Delete.
2317         (mep_unwind_sp): Delete.
2318         (mep_dummy_id): Delete.
2319         (mep_gdbarch_init): Don't register deleted functions with
2320         gdbarch.
2321
2322 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2323
2324         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
2325         (m68hc11_unwind_sp): Delete.
2326         (m68hc11_gdbarch_init): Don't register deleted functions with
2327         gdbarch.
2328
2329 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2330
2331         * m32r-tdep.c (m32r_unwind_sp): Delete.
2332         (m32r_unwind_pc): Delete.
2333         (m32r_dummy_id): Delete.
2334         (m32r_gdbarch_init): Don't register deleted functions with
2335         gdbarch.
2336
2337 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2338
2339         * m32c-tdep.c (m32c_unwind_pc): Delete.
2340         (m32c_unwind_sp): Delete.
2341         (m32c_dummy_id): Delete.
2342         (m32c_gdbarch_init): Don't register deleted functions with
2343         gdbarch.
2344
2345 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2346
2347         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
2348         (lm32_unwind_pc): Delete.
2349         (lm32_dummy_id): Delete.
2350         (lm32_gdbarch_init): Don't register deleted functions with
2351         gdbarch.
2352
2353 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2354
2355         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
2356         (iq2000_unwind_pc): Delete.
2357         (iq2000_dummy_id): Delete.
2358         (iq2000_gdbarch_init): Don't register deleted functions with
2359         gdbarch.
2360
2361 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2362
2363         * nds32-tdep.c (nds32_type_align): Delete.
2364         (nds32_push_dummy_call): Use type_align instead.
2365
2366 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2367
2368         * arm-tdep.c (arm_type_align): Only handle vector override case.
2369         (arm_push_dummy_call): Use type_align.
2370         (arm_gdbarch_init): Register arm_type_align gdbarch function.
2371
2372 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2373
2374         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
2375         case.
2376         (pass_on_stack): Use type_align.
2377         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
2378         function.
2379
2380 2019-04-23  Tom Tromey  <tromey@adacore.com>
2381
2382         * dwarf2read.c (line_header::file_name_at): Remove unused
2383         overload.
2384
2385 2019-04-23  Tom de Vries  <tdevries@suse.de>
2386
2387         PR gdb/24438
2388         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
2389         invocation.
2390
2391
2392 2019-03-27  Ali Tamur  <tamur@google.com>
2393
2394         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
2395         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
2396         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
2397         (dwarf_expr_context::get_addr_index): Likewise
2398         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
2399         (symbol_needs_eval_context::get_addr_index): Likewise
2400         (disassemble_dwarf_expression): Add DW_OP_addrx
2401         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
2402         (read_cutu_die_from_dwo): Update comment
2403         (skip_one_die): Add DW_FORM_addrx
2404         (read_attribute_value): Likewise
2405         (var_decode_location): Add DW_OP_addrx
2406         (dwarf2_const_value_attr): Add DW_FORM_addrx
2407         (dump_die_shallow): Likewise
2408         (dwarf2_fetch_constant_bytes): Likewise
2409         (decode_locdesc): Add DW_OP_addrx
2410         (skip_form_bytes): Add DW_FORM_addrx
2411
2412 2019-04-22  Ali Tamur  <tamur@google.com>
2413
2414         * MAINTAINERS (Write After Approval): Add self.
2415
2416 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
2417
2418         * solib-svr4.c (get_svr4_info): Add pspace parameter.
2419         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
2420         (open_symbol_file_object): Likewise.
2421         (svr4_default_sos): Add info parameter.
2422         (svr4_read_so_list): Likewise.
2423         (svr4_current_sos_direct): Adjust functions calls to pass down
2424         info.
2425         (svr4_current_sos_1): Add info parameter.
2426         (svr4_current_sos): Call get_svr4_info, pass info down to
2427         svr4_current_sos_1.
2428         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
2429         get_svr4_info.
2430         (svr4_in_dynsym_resolve_code): Pass current_program_space to
2431         get_svr4_info.
2432         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
2433         to get_svr4_info.
2434         (probes_table_remove_objfile_probes): Likewise.
2435         (register_solib_event_probe): Add info parameter.
2436         (solist_update_incremental): Pass info parameter down to
2437         svr4_read_so_list.
2438         (disable_probes_interface): Add info parameter.
2439         (svr4_handle_solib_event): Pass current_program_space to
2440         get_svr4_info.  Adjust disable_probes_interface cleanup.
2441         (svr4_create_probe_breakpoints): Add info parameter, pass it
2442         down to register_solib_event_probe.
2443         (svr4_create_solib_event_breakpoints): Add info parameter,
2444         pass it down to svr4_create_probe_breakpoints.
2445         (enable_break): Pass info down to
2446         svr4_create_solib_event_breakpoints.
2447         (svr4_solib_create_inferior_hook): Pass current_program_space to
2448         get_svr4_info.
2449         (svr4_clear_solib): Likewise.
2450
2451 2019-04-22  Pedro Alves  <palves@redhat.com>
2452
2453         * solib-svr4.c (svr4_free_objfile_observer): New.
2454         (probe_and_action::objfile): New field.
2455         (probes_table_htab_remove_objfile_probes)
2456         (probes_table_remove_objfile_probes): New functions.
2457         (register_solib_event_probe): Add 'objfile' parameter.  Store it
2458         in the new probe_and_action.  Don't store the probe in 'lookup'.
2459         (svr4_create_probe_breakpoints): Pass objfile to
2460         register_solib_event_probe.
2461         (_initialize_svr4_solib): Register a free_objfile observer.
2462
2463 2019-04-19  Tom Tromey  <tom@tromey.com>
2464
2465         * common/queue.h: Remove.
2466
2467 2019-04-19  Tom Tromey  <tom@tromey.com>
2468
2469         * event-loop.c: Don't include "common/queue.h".
2470
2471 2019-04-19  Tom Tromey  <tom@tromey.com>
2472
2473         * remote.c (remote_target): Use delete.
2474         * remote-notif.h: Include <list>, not "common/queue.h".
2475         (notif_client_p): Remove typedef.
2476         (remote_notif_state): Add constructor, destructor, initializer.
2477         <notif_queue>: Now a std::list.
2478         (remote_notif_state_xfree): Don't declare.
2479         * remote-notif.c (remote_notif_process, handle_notification)
2480         (remote_notif_state_allocate): Update.
2481         (~remote_notif_state): Rename from remote_notif_state_xfree.
2482
2483 2019-04-19  Tom Tromey  <tom@tromey.com>
2484
2485         * symfile.c (reread_symbols): Update.
2486         * objfiles.c (objfile_register_static_link)
2487         (objfile_lookup_static_link): Update
2488         (~objfile) Don't delete static_links.
2489         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
2490
2491 2019-04-19  Tom Tromey  <tom@tromey.com>
2492
2493         * type-stack.h (struct type_stack) <insert>: Constify string.
2494         * type-stack.c (type_stack::insert): Constify string.
2495         * gdbtypes.h (lookup_template_type): Update.
2496         (address_space_name_to_int): Update.
2497         * gdbtypes.c (address_space_name_to_int): Make space_identifier
2498         const.
2499         (lookup_template_type): Make name const.
2500         * c-exp.y: Update rules.
2501         (lex_one_token, classify_name, classify_inner_name)
2502         (c_print_token): Update.
2503         * p-exp.y: Update rules.
2504         (yylex): Update.
2505         * f-exp.y: Update rules.
2506         (yylex): Update.
2507         * d-exp.y: Update rules.
2508         (lex_one_token, classify_name, classify_inner_name): Update.
2509         * parse.c (write_dollar_variable, copy_name): Return std::string.
2510         * parser-defs.h (copy_name): Change return type.
2511         * m2-exp.y: Update rules.
2512         (yylex): Update.
2513         * go-exp.y (lex_one_token): Update.
2514         Update rules.
2515         (classify_unsafe_function, classify_packaged_name)
2516         (classify_name, yylex): Update.
2517
2518 2019-04-19  Sergei Trofimovich <siarheit@google.com>
2519
2520         * configure.ac: add --enable-source-highlight switch.
2521         * configure: Regenerate.
2522         * top.c (print_gdb_version): plumb --enable-source-highlight
2523         status to "show configuration".
2524
2525 2019-04-19  Tom Tromey  <tromey@adacore.com>
2526
2527         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
2528         Check ADA_TYPE_P.
2529         (empty_record, ada_template_to_fixed_record_type_1)
2530         (template_to_static_fixed_type)
2531         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
2532         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
2533         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
2534         macros.
2535
2536 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
2537
2538         PR symtab/24423:
2539         * source.c (print_source_lines_base): Advance "iter" when a
2540         control character is seen.
2541
2542 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2543
2544         * inferior.h (struct infcall_suspend_state_deleter):
2545         Catch exception in destructor to avoid crash.
2546
2547 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2548
2549         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
2550         close to the add_com "shell".
2551
2552 2019-04-18  Tom Tromey  <tromey@adacore.com>
2553
2554         * process-stratum-target.h (class process_stratum_target)
2555         <stratum>: Add "final".
2556
2557 2019-04-17  Tom Tromey  <tromey@adacore.com>
2558
2559         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
2560         against nullptr before use.
2561
2562 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
2563
2564         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
2565
2566 2019-04-17  Jim Wilson  <jimw@sifive.com>
2567             Andrew Burgess  <andrew.burgess@embecosm.com>
2568
2569         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
2570         code read might fail, assume 4-byte breakpoint in that case.
2571
2572 2019-04-15  Leszek Swirski  <leszeks@google.com>
2573
2574         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
2575         rather than a hand-rolled POD check when checking for forced MEMORY
2576         classification.
2577
2578 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2579
2580         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
2581         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
2582         function.
2583         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
2584         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
2585         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
2586         declaration.
2587
2588 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2589
2590         * aarch64-linux-nat.c
2591         (aarch64_linux_nat_target::thread_architecture): Add override.
2592         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
2593         each VQ.
2594
2595 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2596
2597         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
2598
2599 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2600
2601         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
2602         target types of size 96-bits, add some additional comments, and
2603         check that the builtin type we found was the correct size.
2604
2605 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
2606
2607         * utils.c (prompt_for_continue): Don't restore the styling at the
2608         end, as applied_style has the wrong value.  This fixes styling in
2609         long lists of file names that are interrupted by the "Continue?"
2610         prompt.
2611
2612 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2613
2614         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
2615         * c-lang.c (c_language_defn): Likewise.
2616         (cplus_language_defn): Likewise.
2617         (asm_language_defn): Likewise.
2618         (minimal_language_defn): Likewise.
2619         * d-lang.c (d_language_defn): Likewise.
2620         * f-lang.c (f_language_defn): Likewise.
2621         * go-lang.c (go_language_defn): Likewise.
2622         * language.c (unknown_language_defn): Likewise.
2623         (auto_language_defn): Likewise.
2624         * language.h (struct language_defn): Remove la_magic field.
2625         (LANG_MAGIC): Delete.
2626         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
2627         * objc-lang.c (objc_language_defn): Likewise.
2628         * opencl-lang.c (opencl_language_defn): Likewise.
2629         * p-lang.c (pascal_language_defn): Likewise.
2630         * rust-lang.c (rust_language_defn): Likewise.
2631
2632 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2633
2634         * riscv-tdep.c (riscv_type_align): New function.
2635         (riscv_type_alignment): Delete.
2636         (riscv_arg_location): Use 'type_align'.
2637         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
2638
2639 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2640
2641         * gdbtypes.c (type_align): A struct with no non-static fields also
2642         has alignment of 1.
2643
2644 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2645
2646         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
2647         component to 0.
2648         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
2649         member.
2650         (riscv_struct_info::analyse): New implementation using new
2651         analyse_inner member function.
2652         (riscv_struct_info::field_offset): New member function.
2653         (riscv_struct_info::m_offsets): New member variable.
2654         (riscv_struct_info::analyse_inner): New private member function,
2655         takes the old implementation of riscv_struct_info::analyse but
2656         extended to track field offsets.
2657         (riscv_call_arg_struct): Update the struct folding special cases
2658         to handle cases where empty C++ structs, which are non-zero
2659         length, are found.
2660         (riscv_arg_location): Initialise the length of each location, a
2661         non-zero length now indicates the location is in use.
2662         (riscv_push_dummy_call): Allow for the first location having a
2663         non-zero offset when setting up arguments.
2664         (riscv_return_value): Likewise, but for return values.
2665
2666 2019-04-11  Tom Tromey  <tromey@adacore.com>
2667
2668         * utils.c (internal_vproblem): Make "msg" const.
2669
2670 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
2671
2672         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
2673         * trad-frame.c (trad_frame_reset_saved_regs): New function.
2674         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
2675         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
2676
2677 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
2678
2679         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
2680         function.
2681         (fill_gregset): Call amd64_linux_collect_native_gregset instead
2682         of amd64_collect_native_gregset.
2683         (amd64_linux_nat_target::store_registers): Likewise.
2684
2685 2019-04-10  Tom Tromey  <tom@tromey.com>
2686
2687         * symtab.c (lookup_global_symbol_from_objfile)
2688         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
2689         * objfiles.h (class separate_debug_iterator): New.
2690         (class separate_debug_range): New.
2691         (struct objfile) <separate_debug_objfiles>: New method.
2692         (objfile_separate_debug_iterate): Don't declare.
2693         * objfiles.c (separate_debug_iterator::operator++): Rename from
2694         objfile_separate_debug_iterate.
2695         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
2696         iterator.
2697         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
2698         iterator.
2699
2700 2019-04-10  Tom Tromey  <tom@tromey.com>
2701
2702         * symfile.c (reread_symbols): Remove old comment.
2703         * objfiles.c (free_all_objfiles): Fix a typo.
2704
2705 2019-04-10  Tom Tromey  <tom@tromey.com>
2706
2707         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
2708         * minsyms.c (lookup_minimal_symbol): Use foreach.
2709         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
2710         (lookup_minimal_symbol_solib_trampoline): Likewise.
2711         * symfile.c (reread_symbols): Use foreach.
2712
2713 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
2714             Tom Tromey  <tromey@adacore.com>
2715
2716         PR rust/24414:
2717         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
2718         (rust_lex_int_test): Change "value" to be LONGEST.
2719         (rust_lex_tests): Add test for long integer literal.
2720
2721 2019-04-09  Tom Tromey  <tromey@adacore.com>
2722
2723         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
2724         to bool.
2725         (extended_remote_target::attach): Update.
2726         (remote_target::remote_notice_new_inferior): Update.
2727         (remote_target::add_current_inferior_and_thread): Update.
2728         * inferior.c (exit_inferior_1): Use "false".
2729         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
2730
2731 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
2732
2733         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
2734         the "start" command.
2735
2736 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2737
2738         * python/py-inferior.c (infpy_thread_from_thread_handle):
2739         Adjust comments to reflect renaming of thread_from_thread_handle
2740         to thread_from_handle.  Adjust keywords.  Fix type error message.
2741         (inferior_object_methods): Add thread_from_handle.  Retain
2742         thread_from_thread_handle, but mark it as deprecated.
2743
2744 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2745
2746         * gdbthread.h (find_thread_by_handle): Revise declaration.
2747         * thread.c (find_thread_by_handle): Likewise.  Adjust
2748         implementation too.
2749         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
2750         support for buffer objects as handles.
2751
2752 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2753
2754         * python/py-infthread.c (thpy_thread_handle): New function.
2755         (thread_object_methods): Register thpy_thread_handle.
2756
2757 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2758
2759         * gdbthread.h (thread_to_thread_handle): Declare.
2760         * thread.c (gdbtypes.h): Include.
2761         (thread_to_thread_handle): New function.
2762
2763         * target.h (struct target_ops): Add thread_info_to_thread_handle.
2764         (target_thread_info_to_thread_handle): Declare.
2765         * target.c (target_thread_info_to_thread_handle): New function.
2766         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
2767         * target-delegates.c: Regenerate.
2768
2769         * linux-thread-db.c (class thread_db_target): Add method
2770         thread_info_to_thread_handle.
2771         (thread_db_target::thread_info_to_thread_handle): Define.
2772         * remote.c (class remote_target): Add new method
2773         thread_info_to_thread_handle.
2774         (remote_target::thread_info_to_thread_handle): Define.
2775
2776 2019-04-08  Pedro Alves  <palves@redhat.com>
2777
2778         * common/common-exceptions.c (throw_exception): Don't create
2779         named object to throw; throw directly.
2780         (throw_it): Likewise.  Don't initialize gdb_exception::message
2781         here, with new; pass FMT and AP to the ctor instead.
2782         * common/common-exceptions.h: Include <string>.
2783         (gdb_exception::gdb_exception(enum return_reason, enum errors,
2784         const char *, va_list)): New ctor.  Use std::make_shared.
2785         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
2786         errors)): Delete.
2787         (gdb_exception_error::gdb_exception_error(enum errors, const char
2788         *, va_list)): New.
2789         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
2790         Add assertion.
2791         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
2792         errors)): Delete.
2793         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
2794         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
2795         Add assertion.
2796
2797 2019-04-08  Tom Tromey  <tom@tromey.com>
2798
2799         * valops.c (value_rtti_indirect_type): Replace throw_exception
2800         with throw.
2801         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
2802         with throw.
2803         * thread.c (thr_try_catch_cmd): Replace throw_exception with
2804         throw.
2805         * target.c (target_translate_tls_address): Replace throw_exception
2806         with throw.
2807         * stack.c (frame_apply_command_count): Replace throw_exception
2808         with throw.
2809         * solib-spu.c (append_ocl_sos): Replace throw_exception with
2810         throw.
2811         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
2812         with throw.
2813         * rs6000-tdep.c (rs6000_frame_cache)
2814         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
2815         * remote.c: Replace throw_exception with throw.
2816         * record-full.c (record_full_message, record_full_wait_1)
2817         (record_full_restore): Replace throw_exception with throw.
2818         * record-btrace.c:
2819         (get_thread_current_frame_id, record_btrace_start_replaying)
2820         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
2821         (cmd_record_btrace_start): Replace throw_exception with throw.
2822         * parse.c (parse_exp_in_context_1): Replace throw_exception with
2823         throw.
2824         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
2825         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
2826         * linespec.c:
2827         (find_linespec_symbols): Replace throw_exception with throw.
2828         * infrun.c (displaced_step_prepare, resume): Replace
2829         throw_exception with throw.
2830         * infcmd.c (post_create_inferior): Replace throw_exception with
2831         throw.
2832         * inf-loop.c (inferior_event_handler): Replace throw_exception
2833         with throw.
2834         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
2835         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
2836         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
2837         (get_prev_frame_always, get_frame_pc_if_available)
2838         (get_frame_address_in_block_if_available, get_frame_language):
2839         Replace throw_exception with throw.
2840         * frame-unwind.c (frame_unwind_try_unwinder): Replace
2841         throw_exception with throw.
2842         * eval.c (fetch_subexp_value, evaluate_var_value)
2843         (evaluate_funcall, evaluate_subexp_standard): Replace
2844         throw_exception with throw.
2845         * dwarf2loc.c (call_site_find_chain)
2846         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
2847         Replace throw_exception with throw.
2848         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
2849         with throw.
2850         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
2851         throw.
2852         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
2853         * completer.c (complete_line_internal): Replace throw_exception
2854         with throw.
2855         * compile/compile-object-run.c (compile_object_run): Replace
2856         throw_exception with throw.
2857         * cli/cli-script.c (process_next_line): Replace throw_exception
2858         with throw.
2859         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
2860         (btrace_enable, btrace_maint_update_pt_packets): Replace
2861         throw_exception with throw.
2862         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
2863         throw_exception with throw.
2864         * break-catch-throw.c (re_set_exception_catchpoint): Replace
2865         throw_exception with throw.
2866         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
2867         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
2868         * aarch64-tdep.c (aarch64_make_prologue_cache)
2869         (aarch64_make_stub_cache): Replace throw_exception with throw.
2870
2871 2019-04-08  Tom Tromey  <tom@tromey.com>
2872
2873         * common/common-exceptions.c (throw_exception): Rename from
2874         throw_exception_cxx.  Remove old copy.  Make argument const.
2875         (throw_it): Create and throw exception objects directly.
2876         * common/common-exceptions.h (throw_exception): Make argument
2877         const.
2878         (struct gdb_exception_error): Add constructor.
2879         (struct gdb_exception_quit): Add constructor.
2880
2881 2019-04-08  Tom Tromey  <tom@tromey.com>
2882
2883         * common/common-exceptions.h (exception_rethrow): Don't declare.
2884         (TRY_SJLJ): Update comment.
2885         (TRY, CATCH, END_CATCH): Remove.
2886         * common/common-exceptions.c (exception_rethrow): Remove.
2887
2888 2019-04-08  Tom Tromey  <tom@tromey.com>
2889
2890         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
2891         Remove.
2892         (gdb_exception_error): Rename from
2893         gdb_exception_RETURN_MASK_ERROR.
2894         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
2895         (gdb_quit_bad_alloc): Update.
2896         * aarch64-tdep.c: Update.
2897         * ada-lang.c: Update.
2898         * ada-typeprint.c: Update.
2899         * ada-valprint.c: Update.
2900         * amd64-tdep.c: Update.
2901         * arch-utils.c: Update.
2902         * break-catch-throw.c: Update.
2903         * breakpoint.c: Update.
2904         * btrace.c: Update.
2905         * c-varobj.c: Update.
2906         * cli/cli-cmds.c: Update.
2907         * cli/cli-interp.c: Update.
2908         * cli/cli-script.c: Update.
2909         * common/common-exceptions.c: Update.
2910         * common/new-op.c: Update.
2911         * common/selftest.c: Update.
2912         * compile/compile-c-symbols.c: Update.
2913         * compile/compile-cplus-symbols.c: Update.
2914         * compile/compile-object-load.c: Update.
2915         * compile/compile-object-run.c: Update.
2916         * completer.c: Update.
2917         * corelow.c: Update.
2918         * cp-abi.c: Update.
2919         * cp-support.c: Update.
2920         * cp-valprint.c: Update.
2921         * darwin-nat.c: Update.
2922         * disasm-selftests.c: Update.
2923         * dtrace-probe.c: Update.
2924         * dwarf-index-cache.c: Update.
2925         * dwarf-index-write.c: Update.
2926         * dwarf2-frame-tailcall.c: Update.
2927         * dwarf2-frame.c: Update.
2928         * dwarf2loc.c: Update.
2929         * dwarf2read.c: Update.
2930         * eval.c: Update.
2931         * event-loop.c: Update.
2932         * event-top.c: Update.
2933         * exec.c: Update.
2934         * f-valprint.c: Update.
2935         * fbsd-tdep.c: Update.
2936         * frame-unwind.c: Update.
2937         * frame.c: Update.
2938         * gdbtypes.c: Update.
2939         * gnu-v3-abi.c: Update.
2940         * guile/guile-internal.h: Update.
2941         * guile/scm-block.c: Update.
2942         * guile/scm-breakpoint.c: Update.
2943         * guile/scm-cmd.c: Update.
2944         * guile/scm-disasm.c: Update.
2945         * guile/scm-frame.c: Update.
2946         * guile/scm-lazy-string.c: Update.
2947         * guile/scm-math.c: Update.
2948         * guile/scm-param.c: Update.
2949         * guile/scm-ports.c: Update.
2950         * guile/scm-pretty-print.c: Update.
2951         * guile/scm-symbol.c: Update.
2952         * guile/scm-symtab.c: Update.
2953         * guile/scm-type.c: Update.
2954         * guile/scm-value.c: Update.
2955         * i386-linux-tdep.c: Update.
2956         * i386-tdep.c: Update.
2957         * inf-loop.c: Update.
2958         * infcall.c: Update.
2959         * infcmd.c: Update.
2960         * infrun.c: Update.
2961         * jit.c: Update.
2962         * language.c: Update.
2963         * linespec.c: Update.
2964         * linux-fork.c: Update.
2965         * linux-nat.c: Update.
2966         * linux-tdep.c: Update.
2967         * linux-thread-db.c: Update.
2968         * main.c: Update.
2969         * mi/mi-cmd-break.c: Update.
2970         * mi/mi-cmd-stack.c: Update.
2971         * mi/mi-interp.c: Update.
2972         * mi/mi-main.c: Update.
2973         * objc-lang.c: Update.
2974         * p-valprint.c: Update.
2975         * parse.c: Update.
2976         * ppc-linux-tdep.c: Update.
2977         * printcmd.c: Update.
2978         * python/py-arch.c: Update.
2979         * python/py-breakpoint.c: Update.
2980         * python/py-cmd.c: Update.
2981         * python/py-finishbreakpoint.c: Update.
2982         * python/py-frame.c: Update.
2983         * python/py-framefilter.c: Update.
2984         * python/py-gdb-readline.c: Update.
2985         * python/py-inferior.c: Update.
2986         * python/py-infthread.c: Update.
2987         * python/py-lazy-string.c: Update.
2988         * python/py-linetable.c: Update.
2989         * python/py-objfile.c: Update.
2990         * python/py-param.c: Update.
2991         * python/py-prettyprint.c: Update.
2992         * python/py-progspace.c: Update.
2993         * python/py-record-btrace.c: Update.
2994         * python/py-record.c: Update.
2995         * python/py-symbol.c: Update.
2996         * python/py-type.c: Update.
2997         * python/py-unwind.c: Update.
2998         * python/py-utils.c: Update.
2999         * python/py-value.c: Update.
3000         * python/python.c: Update.
3001         * record-btrace.c: Update.
3002         * record-full.c: Update.
3003         * remote-fileio.c: Update.
3004         * remote.c: Update.
3005         * riscv-tdep.c: Update.
3006         * rs6000-aix-tdep.c: Update.
3007         * rs6000-tdep.c: Update.
3008         * rust-exp.y: Update.
3009         * rust-lang.c: Update.
3010         * s390-tdep.c: Update.
3011         * selftest-arch.c: Update.
3012         * solib-dsbt.c: Update.
3013         * solib-frv.c: Update.
3014         * solib-spu.c: Update.
3015         * solib-svr4.c: Update.
3016         * solib.c: Update.
3017         * sparc64-linux-tdep.c: Update.
3018         * stack.c: Update.
3019         * symfile-mem.c: Update.
3020         * symmisc.c: Update.
3021         * target.c: Update.
3022         * thread.c: Update.
3023         * top.c: Update.
3024         * tracefile-tfile.c: Update.
3025         * tui/tui.c: Update.
3026         * typeprint.c: Update.
3027         * unittests/cli-utils-selftests.c: Update.
3028         * unittests/parse-connection-spec-selftests.c: Update.
3029         * valops.c: Update.
3030         * valprint.c: Update.
3031         * value.c: Update.
3032         * varobj.c: Update.
3033         * windows-nat.c: Update.
3034         * x86-linux-nat.c: Update.
3035         * xml-support.c: Update.
3036
3037 2019-04-08  Tom Tromey  <tom@tromey.com>
3038
3039         * xml-support.c: Use C++ exception handling.
3040         * x86-linux-nat.c: Use C++ exception handling.
3041         * windows-nat.c: Use C++ exception handling.
3042         * varobj.c: Use C++ exception handling.
3043         * value.c: Use C++ exception handling.
3044         * valprint.c: Use C++ exception handling.
3045         * valops.c: Use C++ exception handling.
3046         * unittests/parse-connection-spec-selftests.c: Use C++ exception
3047         handling.
3048         * unittests/cli-utils-selftests.c: Use C++ exception handling.
3049         * typeprint.c: Use C++ exception handling.
3050         * tui/tui.c: Use C++ exception handling.
3051         * tracefile-tfile.c: Use C++ exception handling.
3052         * top.c: Use C++ exception handling.
3053         * thread.c: Use C++ exception handling.
3054         * target.c: Use C++ exception handling.
3055         * symmisc.c: Use C++ exception handling.
3056         * symfile-mem.c: Use C++ exception handling.
3057         * stack.c: Use C++ exception handling.
3058         * sparc64-linux-tdep.c: Use C++ exception handling.
3059         * solib.c: Use C++ exception handling.
3060         * solib-svr4.c: Use C++ exception handling.
3061         * solib-spu.c: Use C++ exception handling.
3062         * solib-frv.c: Use C++ exception handling.
3063         * solib-dsbt.c: Use C++ exception handling.
3064         * selftest-arch.c: Use C++ exception handling.
3065         * s390-tdep.c: Use C++ exception handling.
3066         * rust-lang.c: Use C++ exception handling.
3067         * rust-exp.y: Use C++ exception handling.
3068         * rs6000-tdep.c: Use C++ exception handling.
3069         * rs6000-aix-tdep.c: Use C++ exception handling.
3070         * riscv-tdep.c: Use C++ exception handling.
3071         * remote.c: Use C++ exception handling.
3072         * remote-fileio.c: Use C++ exception handling.
3073         * record-full.c: Use C++ exception handling.
3074         * record-btrace.c: Use C++ exception handling.
3075         * python/python.c: Use C++ exception handling.
3076         * python/py-value.c: Use C++ exception handling.
3077         * python/py-utils.c: Use C++ exception handling.
3078         * python/py-unwind.c: Use C++ exception handling.
3079         * python/py-type.c: Use C++ exception handling.
3080         * python/py-symbol.c: Use C++ exception handling.
3081         * python/py-record.c: Use C++ exception handling.
3082         * python/py-record-btrace.c: Use C++ exception handling.
3083         * python/py-progspace.c: Use C++ exception handling.
3084         * python/py-prettyprint.c: Use C++ exception handling.
3085         * python/py-param.c: Use C++ exception handling.
3086         * python/py-objfile.c: Use C++ exception handling.
3087         * python/py-linetable.c: Use C++ exception handling.
3088         * python/py-lazy-string.c: Use C++ exception handling.
3089         * python/py-infthread.c: Use C++ exception handling.
3090         * python/py-inferior.c: Use C++ exception handling.
3091         * python/py-gdb-readline.c: Use C++ exception handling.
3092         * python/py-framefilter.c: Use C++ exception handling.
3093         * python/py-frame.c: Use C++ exception handling.
3094         * python/py-finishbreakpoint.c: Use C++ exception handling.
3095         * python/py-cmd.c: Use C++ exception handling.
3096         * python/py-breakpoint.c: Use C++ exception handling.
3097         * python/py-arch.c: Use C++ exception handling.
3098         * printcmd.c: Use C++ exception handling.
3099         * ppc-linux-tdep.c: Use C++ exception handling.
3100         * parse.c: Use C++ exception handling.
3101         * p-valprint.c: Use C++ exception handling.
3102         * objc-lang.c: Use C++ exception handling.
3103         * mi/mi-main.c: Use C++ exception handling.
3104         * mi/mi-interp.c: Use C++ exception handling.
3105         * mi/mi-cmd-stack.c: Use C++ exception handling.
3106         * mi/mi-cmd-break.c: Use C++ exception handling.
3107         * main.c: Use C++ exception handling.
3108         * linux-thread-db.c: Use C++ exception handling.
3109         * linux-tdep.c: Use C++ exception handling.
3110         * linux-nat.c: Use C++ exception handling.
3111         * linux-fork.c: Use C++ exception handling.
3112         * linespec.c: Use C++ exception handling.
3113         * language.c: Use C++ exception handling.
3114         * jit.c: Use C++ exception handling.
3115         * infrun.c: Use C++ exception handling.
3116         * infcmd.c: Use C++ exception handling.
3117         * infcall.c: Use C++ exception handling.
3118         * inf-loop.c: Use C++ exception handling.
3119         * i386-tdep.c: Use C++ exception handling.
3120         * i386-linux-tdep.c: Use C++ exception handling.
3121         * guile/scm-value.c: Use C++ exception handling.
3122         * guile/scm-type.c: Use C++ exception handling.
3123         * guile/scm-symtab.c: Use C++ exception handling.
3124         * guile/scm-symbol.c: Use C++ exception handling.
3125         * guile/scm-pretty-print.c: Use C++ exception handling.
3126         * guile/scm-ports.c: Use C++ exception handling.
3127         * guile/scm-param.c: Use C++ exception handling.
3128         * guile/scm-math.c: Use C++ exception handling.
3129         * guile/scm-lazy-string.c: Use C++ exception handling.
3130         * guile/scm-frame.c: Use C++ exception handling.
3131         * guile/scm-disasm.c: Use C++ exception handling.
3132         * guile/scm-cmd.c: Use C++ exception handling.
3133         * guile/scm-breakpoint.c: Use C++ exception handling.
3134         * guile/scm-block.c: Use C++ exception handling.
3135         * guile/guile-internal.h: Use C++ exception handling.
3136         * gnu-v3-abi.c: Use C++ exception handling.
3137         * gdbtypes.c: Use C++ exception handling.
3138         * frame.c: Use C++ exception handling.
3139         * frame-unwind.c: Use C++ exception handling.
3140         * fbsd-tdep.c: Use C++ exception handling.
3141         * f-valprint.c: Use C++ exception handling.
3142         * exec.c: Use C++ exception handling.
3143         * event-top.c: Use C++ exception handling.
3144         * event-loop.c: Use C++ exception handling.
3145         * eval.c: Use C++ exception handling.
3146         * dwarf2read.c: Use C++ exception handling.
3147         * dwarf2loc.c: Use C++ exception handling.
3148         * dwarf2-frame.c: Use C++ exception handling.
3149         * dwarf2-frame-tailcall.c: Use C++ exception handling.
3150         * dwarf-index-write.c: Use C++ exception handling.
3151         * dwarf-index-cache.c: Use C++ exception handling.
3152         * dtrace-probe.c: Use C++ exception handling.
3153         * disasm-selftests.c: Use C++ exception handling.
3154         * darwin-nat.c: Use C++ exception handling.
3155         * cp-valprint.c: Use C++ exception handling.
3156         * cp-support.c: Use C++ exception handling.
3157         * cp-abi.c: Use C++ exception handling.
3158         * corelow.c: Use C++ exception handling.
3159         * completer.c: Use C++ exception handling.
3160         * compile/compile-object-run.c: Use C++ exception handling.
3161         * compile/compile-object-load.c: Use C++ exception handling.
3162         * compile/compile-cplus-symbols.c: Use C++ exception handling.
3163         * compile/compile-c-symbols.c: Use C++ exception handling.
3164         * common/selftest.c: Use C++ exception handling.
3165         * common/new-op.c: Use C++ exception handling.
3166         * cli/cli-script.c: Use C++ exception handling.
3167         * cli/cli-interp.c: Use C++ exception handling.
3168         * cli/cli-cmds.c: Use C++ exception handling.
3169         * c-varobj.c: Use C++ exception handling.
3170         * btrace.c: Use C++ exception handling.
3171         * breakpoint.c: Use C++ exception handling.
3172         * break-catch-throw.c: Use C++ exception handling.
3173         * arch-utils.c: Use C++ exception handling.
3174         * amd64-tdep.c: Use C++ exception handling.
3175         * ada-valprint.c: Use C++ exception handling.
3176         * ada-typeprint.c: Use C++ exception handling.
3177         * ada-lang.c: Use C++ exception handling.
3178         * aarch64-tdep.c: Use C++ exception handling.
3179
3180 2019-04-08  Tom Tromey  <tom@tromey.com>
3181
3182         * xml-support.c (gdb_xml_parser::parse): Update.
3183         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3184         * value.c (show_convenience): Update.
3185         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
3186         (test_parse_flags_qcs): Update.
3187         * thread.c (thr_try_catch_cmd): Update.
3188         * target.c (target_translate_tls_address): Update.
3189         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3190         (info_frame_command_core, frame_apply_command_count): Update.
3191         * rust-exp.y (rust_lex_exception_test): Update.
3192         * riscv-tdep.c (riscv_print_one_register_info): Update.
3193         * remote.c (remote_target::enable_btrace): Update.
3194         * record-btrace.c (record_btrace_enable_warn): Update.
3195         * python/py-utils.c (gdbpy_convert_exception): Update.
3196         * printcmd.c (do_one_display, print_variable_and_value): Update.
3197         * mi/mi-main.c (mi_print_exception): Update.
3198         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
3199         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3200         * linux-nat.c (linux_nat_target::attach): Update.
3201         * linux-fork.c (class scoped_switch_fork_info): Update.
3202         * infrun.c (displaced_step_prepare): Update.
3203         * infcall.c (call_function_by_hand_dummy): Update.
3204         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
3205         * gnu-v3-abi.c (print_one_vtable): Update.
3206         * frame.c (get_prev_frame_always): Update.
3207         * f-valprint.c (info_common_command_for_block): Update.
3208         * exec.c (try_open_exec_file): Update.
3209         * exceptions.c (print_exception, exception_print)
3210         (exception_fprintf, exception_print_same): Update.
3211         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
3212         * dwarf-index-cache.c (index_cache::store)
3213         (index_cache::lookup_gdb_index): Update.
3214         * darwin-nat.c (maybe_cache_shell): Update.
3215         * cp-valprint.c (cp_print_value_fields): Update.
3216         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
3217         (gcc_cplus_symbol_address): Update.
3218         * compile/compile-c-symbols.c (gcc_convert_symbol)
3219         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
3220         * common/selftest.c: Update.
3221         * common/common-exceptions.h (struct gdb_exception) <message>: Now
3222         a std::string.
3223         (exception_try_scope_entry, exception_try_scope_exit): Don't
3224         declare.
3225         (struct exception_try_scope): Remove.
3226         (TRY): Don't use exception_try_scope.
3227         (struct gdb_exception): Add constructor, operator=.
3228         <what>: New method.
3229         (struct gdb_exception_RETURN_MASK_ALL)
3230         (struct gdb_exception_RETURN_MASK_ERROR)
3231         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
3232         (struct gdb_quit_bad_alloc): Update.
3233         * common/common-exceptions.c (exception_none): Change
3234         initializer.
3235         (struct catcher) <state, exception>: Initialize inline.
3236         <prev>: Remove member.
3237         (current_catcher): Remove.
3238         (catchers): New global.
3239         (exceptions_state_mc_init): Simplify.
3240         (catcher_pop): Remove.
3241         (exceptions_state_mc, exceptions_state_mc_catch): Update.
3242         (try_scope_depth, exception_try_scope_entry)
3243         (exception_try_scope_exit): Remove.
3244         (throw_exception_sjlj): Update.
3245         (exception_messages, exception_messages_size): Remove.
3246         (throw_it): Simplify.
3247         (gdb_exception_sliced_copy): Remove.
3248         (throw_exception_cxx): Update.
3249         * cli/cli-script.c (script_from_file): Update.
3250         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
3251         Update.
3252         * ada-valprint.c (ada_val_print): Update.
3253         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
3254         (create_excep_cond_exprs): Update.
3255
3256 2019-04-08  Tom Tromey  <tom@tromey.com>
3257
3258         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
3259         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
3260         (TRY, CATCH, END_CATCH): Remove some definitions.
3261         * common/common-exceptions.c: Don't use GDB_XCPT.
3262         (catcher_list_size): Remove.
3263         (throw_exception, throw_it): Simplify.
3264
3265 2019-04-05  Tom Tromey  <tom@tromey.com>
3266
3267         Revert the header-sorting patch.
3268         * ft32-tdep.c: Revert.
3269         * frv-tdep.c: Revert.
3270         * frv-linux-tdep.c: Revert.
3271         * frame.c: Revert.
3272         * frame-unwind.c: Revert.
3273         * frame-base.c: Revert.
3274         * fork-child.c: Revert.
3275         * findvar.c: Revert.
3276         * findcmd.c: Revert.
3277         * filesystem.c: Revert.
3278         * filename-seen-cache.h: Revert.
3279         * filename-seen-cache.c: Revert.
3280         * fbsd-tdep.c: Revert.
3281         * fbsd-nat.h: Revert.
3282         * fbsd-nat.c: Revert.
3283         * f-valprint.c: Revert.
3284         * f-typeprint.c: Revert.
3285         * f-lang.c: Revert.
3286         * extension.h: Revert.
3287         * extension.c: Revert.
3288         * extension-priv.h: Revert.
3289         * expprint.c: Revert.
3290         * exec.h: Revert.
3291         * exec.c: Revert.
3292         * exceptions.c: Revert.
3293         * event-top.c: Revert.
3294         * event-loop.c: Revert.
3295         * eval.c: Revert.
3296         * elfread.c: Revert.
3297         * dwarf2read.h: Revert.
3298         * dwarf2read.c: Revert.
3299         * dwarf2loc.c: Revert.
3300         * dwarf2expr.h: Revert.
3301         * dwarf2expr.c: Revert.
3302         * dwarf2-frame.c: Revert.
3303         * dwarf2-frame-tailcall.c: Revert.
3304         * dwarf-index-write.h: Revert.
3305         * dwarf-index-write.c: Revert.
3306         * dwarf-index-common.c: Revert.
3307         * dwarf-index-cache.h: Revert.
3308         * dwarf-index-cache.c: Revert.
3309         * dummy-frame.c: Revert.
3310         * dtrace-probe.c: Revert.
3311         * disasm.h: Revert.
3312         * disasm.c: Revert.
3313         * disasm-selftests.c: Revert.
3314         * dictionary.c: Revert.
3315         * dicos-tdep.c: Revert.
3316         * demangle.c: Revert.
3317         * dcache.h: Revert.
3318         * dcache.c: Revert.
3319         * darwin-nat.h: Revert.
3320         * darwin-nat.c: Revert.
3321         * darwin-nat-info.c: Revert.
3322         * d-valprint.c: Revert.
3323         * d-namespace.c: Revert.
3324         * d-lang.c: Revert.
3325         * ctf.c: Revert.
3326         * csky-tdep.c: Revert.
3327         * csky-linux-tdep.c: Revert.
3328         * cris-tdep.c: Revert.
3329         * cris-linux-tdep.c: Revert.
3330         * cp-valprint.c: Revert.
3331         * cp-support.c: Revert.
3332         * cp-namespace.c: Revert.
3333         * cp-abi.c: Revert.
3334         * corelow.c: Revert.
3335         * corefile.c: Revert.
3336         * continuations.c: Revert.
3337         * completer.h: Revert.
3338         * completer.c: Revert.
3339         * complaints.c: Revert.
3340         * coffread.c: Revert.
3341         * coff-pe-read.c: Revert.
3342         * cli-out.h: Revert.
3343         * cli-out.c: Revert.
3344         * charset.c: Revert.
3345         * c-varobj.c: Revert.
3346         * c-valprint.c: Revert.
3347         * c-typeprint.c: Revert.
3348         * c-lang.c: Revert.
3349         * buildsym.c: Revert.
3350         * buildsym-legacy.c: Revert.
3351         * build-id.h: Revert.
3352         * build-id.c: Revert.
3353         * btrace.c: Revert.
3354         * bsd-uthread.c: Revert.
3355         * breakpoint.h: Revert.
3356         * breakpoint.c: Revert.
3357         * break-catch-throw.c: Revert.
3358         * break-catch-syscall.c: Revert.
3359         * break-catch-sig.c: Revert.
3360         * blockframe.c: Revert.
3361         * block.c: Revert.
3362         * bfin-tdep.c: Revert.
3363         * bfin-linux-tdep.c: Revert.
3364         * bfd-target.c: Revert.
3365         * bcache.c: Revert.
3366         * ax-general.c: Revert.
3367         * ax-gdb.h: Revert.
3368         * ax-gdb.c: Revert.
3369         * avr-tdep.c: Revert.
3370         * auxv.c: Revert.
3371         * auto-load.c: Revert.
3372         * arm-wince-tdep.c: Revert.
3373         * arm-tdep.c: Revert.
3374         * arm-symbian-tdep.c: Revert.
3375         * arm-pikeos-tdep.c: Revert.
3376         * arm-obsd-tdep.c: Revert.
3377         * arm-nbsd-tdep.c: Revert.
3378         * arm-nbsd-nat.c: Revert.
3379         * arm-linux-tdep.c: Revert.
3380         * arm-linux-nat.c: Revert.
3381         * arm-fbsd-tdep.c: Revert.
3382         * arm-fbsd-nat.c: Revert.
3383         * arm-bsd-tdep.c: Revert.
3384         * arch-utils.c: Revert.
3385         * arc-tdep.c: Revert.
3386         * arc-newlib-tdep.c: Revert.
3387         * annotate.h: Revert.
3388         * annotate.c: Revert.
3389         * amd64-windows-tdep.c: Revert.
3390         * amd64-windows-nat.c: Revert.
3391         * amd64-tdep.c: Revert.
3392         * amd64-sol2-tdep.c: Revert.
3393         * amd64-obsd-tdep.c: Revert.
3394         * amd64-obsd-nat.c: Revert.
3395         * amd64-nbsd-tdep.c: Revert.
3396         * amd64-nbsd-nat.c: Revert.
3397         * amd64-nat.c: Revert.
3398         * amd64-linux-tdep.c: Revert.
3399         * amd64-linux-nat.c: Revert.
3400         * amd64-fbsd-tdep.c: Revert.
3401         * amd64-fbsd-nat.c: Revert.
3402         * amd64-dicos-tdep.c: Revert.
3403         * amd64-darwin-tdep.c: Revert.
3404         * amd64-bsd-nat.c: Revert.
3405         * alpha-tdep.c: Revert.
3406         * alpha-obsd-tdep.c: Revert.
3407         * alpha-nbsd-tdep.c: Revert.
3408         * alpha-mdebug-tdep.c: Revert.
3409         * alpha-linux-tdep.c: Revert.
3410         * alpha-linux-nat.c: Revert.
3411         * alpha-bsd-tdep.c: Revert.
3412         * alpha-bsd-nat.c: Revert.
3413         * aix-thread.c: Revert.
3414         * agent.c: Revert.
3415         * addrmap.c: Revert.
3416         * ada-varobj.c: Revert.
3417         * ada-valprint.c: Revert.
3418         * ada-typeprint.c: Revert.
3419         * ada-tasks.c: Revert.
3420         * ada-lang.c: Revert.
3421         * aarch64-tdep.c: Revert.
3422         * aarch64-ravenscar-thread.c: Revert.
3423         * aarch64-newlib-tdep.c: Revert.
3424         * aarch64-linux-tdep.c: Revert.
3425         * aarch64-linux-nat.c: Revert.
3426         * aarch64-fbsd-tdep.c: Revert.
3427         * aarch64-fbsd-nat.c: Revert.
3428         * aarch32-linux-nat.c: Revert.
3429
3430 2019-04-05  Tom Tromey  <tom@tromey.com>
3431
3432         * ft32-tdep.c: Sort headers.
3433         * frv-tdep.c: Sort headers.
3434         * frv-linux-tdep.c: Sort headers.
3435         * frame.c: Sort headers.
3436         * frame-unwind.c: Sort headers.
3437         * frame-base.c: Sort headers.
3438         * fork-child.c: Sort headers.
3439         * findvar.c: Sort headers.
3440         * findcmd.c: Sort headers.
3441         * filesystem.c: Sort headers.
3442         * filename-seen-cache.h: Sort headers.
3443         * filename-seen-cache.c: Sort headers.
3444         * fbsd-tdep.c: Sort headers.
3445         * fbsd-nat.h: Sort headers.
3446         * fbsd-nat.c: Sort headers.
3447         * f-valprint.c: Sort headers.
3448         * f-typeprint.c: Sort headers.
3449         * f-lang.c: Sort headers.
3450         * extension.h: Sort headers.
3451         * extension.c: Sort headers.
3452         * extension-priv.h: Sort headers.
3453         * expprint.c: Sort headers.
3454         * exec.h: Sort headers.
3455         * exec.c: Sort headers.
3456         * exceptions.c: Sort headers.
3457         * event-top.c: Sort headers.
3458         * event-loop.c: Sort headers.
3459         * eval.c: Sort headers.
3460         * elfread.c: Sort headers.
3461         * dwarf2read.h: Sort headers.
3462         * dwarf2read.c: Sort headers.
3463         * dwarf2loc.c: Sort headers.
3464         * dwarf2expr.h: Sort headers.
3465         * dwarf2expr.c: Sort headers.
3466         * dwarf2-frame.c: Sort headers.
3467         * dwarf2-frame-tailcall.c: Sort headers.
3468         * dwarf-index-write.h: Sort headers.
3469         * dwarf-index-write.c: Sort headers.
3470         * dwarf-index-common.c: Sort headers.
3471         * dwarf-index-cache.h: Sort headers.
3472         * dwarf-index-cache.c: Sort headers.
3473         * dummy-frame.c: Sort headers.
3474         * dtrace-probe.c: Sort headers.
3475         * disasm.h: Sort headers.
3476         * disasm.c: Sort headers.
3477         * disasm-selftests.c: Sort headers.
3478         * dictionary.c: Sort headers.
3479         * dicos-tdep.c: Sort headers.
3480         * demangle.c: Sort headers.
3481         * dcache.h: Sort headers.
3482         * dcache.c: Sort headers.
3483         * darwin-nat.h: Sort headers.
3484         * darwin-nat.c: Sort headers.
3485         * darwin-nat-info.c: Sort headers.
3486         * d-valprint.c: Sort headers.
3487         * d-namespace.c: Sort headers.
3488         * d-lang.c: Sort headers.
3489         * ctf.c: Sort headers.
3490         * csky-tdep.c: Sort headers.
3491         * csky-linux-tdep.c: Sort headers.
3492         * cris-tdep.c: Sort headers.
3493         * cris-linux-tdep.c: Sort headers.
3494         * cp-valprint.c: Sort headers.
3495         * cp-support.c: Sort headers.
3496         * cp-namespace.c: Sort headers.
3497         * cp-abi.c: Sort headers.
3498         * corelow.c: Sort headers.
3499         * corefile.c: Sort headers.
3500         * continuations.c: Sort headers.
3501         * completer.h: Sort headers.
3502         * completer.c: Sort headers.
3503         * complaints.c: Sort headers.
3504         * coffread.c: Sort headers.
3505         * coff-pe-read.c: Sort headers.
3506         * cli-out.h: Sort headers.
3507         * cli-out.c: Sort headers.
3508         * charset.c: Sort headers.
3509         * c-varobj.c: Sort headers.
3510         * c-valprint.c: Sort headers.
3511         * c-typeprint.c: Sort headers.
3512         * c-lang.c: Sort headers.
3513         * buildsym.c: Sort headers.
3514         * buildsym-legacy.c: Sort headers.
3515         * build-id.h: Sort headers.
3516         * build-id.c: Sort headers.
3517         * btrace.c: Sort headers.
3518         * bsd-uthread.c: Sort headers.
3519         * breakpoint.h: Sort headers.
3520         * breakpoint.c: Sort headers.
3521         * break-catch-throw.c: Sort headers.
3522         * break-catch-syscall.c: Sort headers.
3523         * break-catch-sig.c: Sort headers.
3524         * blockframe.c: Sort headers.
3525         * block.c: Sort headers.
3526         * bfin-tdep.c: Sort headers.
3527         * bfin-linux-tdep.c: Sort headers.
3528         * bfd-target.c: Sort headers.
3529         * bcache.c: Sort headers.
3530         * ax-general.c: Sort headers.
3531         * ax-gdb.h: Sort headers.
3532         * ax-gdb.c: Sort headers.
3533         * avr-tdep.c: Sort headers.
3534         * auxv.c: Sort headers.
3535         * auto-load.c: Sort headers.
3536         * arm-wince-tdep.c: Sort headers.
3537         * arm-tdep.c: Sort headers.
3538         * arm-symbian-tdep.c: Sort headers.
3539         * arm-pikeos-tdep.c: Sort headers.
3540         * arm-obsd-tdep.c: Sort headers.
3541         * arm-nbsd-tdep.c: Sort headers.
3542         * arm-nbsd-nat.c: Sort headers.
3543         * arm-linux-tdep.c: Sort headers.
3544         * arm-linux-nat.c: Sort headers.
3545         * arm-fbsd-tdep.c: Sort headers.
3546         * arm-fbsd-nat.c: Sort headers.
3547         * arm-bsd-tdep.c: Sort headers.
3548         * arch-utils.c: Sort headers.
3549         * arc-tdep.c: Sort headers.
3550         * arc-newlib-tdep.c: Sort headers.
3551         * annotate.h: Sort headers.
3552         * annotate.c: Sort headers.
3553         * amd64-windows-tdep.c: Sort headers.
3554         * amd64-windows-nat.c: Sort headers.
3555         * amd64-tdep.c: Sort headers.
3556         * amd64-sol2-tdep.c: Sort headers.
3557         * amd64-obsd-tdep.c: Sort headers.
3558         * amd64-obsd-nat.c: Sort headers.
3559         * amd64-nbsd-tdep.c: Sort headers.
3560         * amd64-nbsd-nat.c: Sort headers.
3561         * amd64-nat.c: Sort headers.
3562         * amd64-linux-tdep.c: Sort headers.
3563         * amd64-linux-nat.c: Sort headers.
3564         * amd64-fbsd-tdep.c: Sort headers.
3565         * amd64-fbsd-nat.c: Sort headers.
3566         * amd64-dicos-tdep.c: Sort headers.
3567         * amd64-darwin-tdep.c: Sort headers.
3568         * amd64-bsd-nat.c: Sort headers.
3569         * alpha-tdep.c: Sort headers.
3570         * alpha-obsd-tdep.c: Sort headers.
3571         * alpha-nbsd-tdep.c: Sort headers.
3572         * alpha-mdebug-tdep.c: Sort headers.
3573         * alpha-linux-tdep.c: Sort headers.
3574         * alpha-linux-nat.c: Sort headers.
3575         * alpha-bsd-tdep.c: Sort headers.
3576         * alpha-bsd-nat.c: Sort headers.
3577         * aix-thread.c: Sort headers.
3578         * agent.c: Sort headers.
3579         * addrmap.c: Sort headers.
3580         * ada-varobj.c: Sort headers.
3581         * ada-valprint.c: Sort headers.
3582         * ada-typeprint.c: Sort headers.
3583         * ada-tasks.c: Sort headers.
3584         * ada-lang.c: Sort headers.
3585         * aarch64-tdep.c: Sort headers.
3586         * aarch64-ravenscar-thread.c: Sort headers.
3587         * aarch64-newlib-tdep.c: Sort headers.
3588         * aarch64-linux-tdep.c: Sort headers.
3589         * aarch64-linux-nat.c: Sort headers.
3590         * aarch64-fbsd-tdep.c: Sort headers.
3591         * aarch64-fbsd-nat.c: Sort headers.
3592         * aarch32-linux-nat.c: Sort headers.
3593
3594 2019-04-04  Tom Tromey  <tom@tromey.com>
3595
3596         * varobj.c (varobj_create): Update.
3597         * rust-exp.y (struct rust_parser) <update_innermost_block,
3598         lookup_symbol>: New methods.
3599         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
3600         Rename.
3601         (rust_parser::rust_lookup_type)
3602         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3603         * printcmd.c (display_command, do_one_display): Update.
3604         * parser-defs.h (struct parser_state) <parser_state>: Add
3605         "tracker" parameter.
3606         (block_tracker): New member.
3607         (class innermost_block_tracker) <innermost_block_tracker>: Add
3608         "types" parameter.
3609         <reset>: Remove method.
3610         (innermost_block): Don't declare.
3611         (null_post_parser): Update.
3612         * parse.c (innermost_block): Remove global.
3613         (write_dollar_variable): Update.
3614         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
3615         Remove "tracker_types" parameter.
3616         (parse_expression): Add "tracker" parameter.
3617         (parse_expression_for_completion): Update.
3618         (null_post_parser): Add "tracker" parameter.
3619         * p-exp.y: Update rules.
3620         * m2-exp.y: Update rules.
3621         * language.h (struct language_defn) <la_post_parser>: Add
3622         "tracker" parameter.
3623         * go-exp.y: Update rules.
3624         * f-exp.y: Update rules.
3625         * expression.h (parse_expression, parse_exp_1): Add "tracker"
3626         parameter.
3627         * d-exp.y: Update rules.
3628         * c-exp.y: Update rules.
3629         * breakpoint.c (set_breakpoint_condition): Create an
3630         innermost_block_tracker.
3631         (watch_command_1): Likewise.
3632         * ada-lang.c (resolve): Add "tracker" parameter.
3633         (resolve_subexp): Likewise.
3634         * ada-exp.y (write_var_from_sym): Update.
3635
3636 2019-04-04  Tom Tromey  <tom@tromey.com>
3637
3638         * type-stack.h: New file.
3639         * type-stack.c: New file.
3640         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
3641         type-stack.h.
3642         (insert_into_type_stack, insert_type, push_type, push_type_int)
3643         (insert_type_address_space, pop_type, pop_type_int)
3644         (pop_typelist, pop_type_stack, append_type_stack)
3645         (push_type_stack, get_type_stack, push_typelist)
3646         (follow_type_instance_flags, follow_types): Don't declare.
3647         * parse.c (type_stack): Remove global.
3648         (parse_exp_in_context): Update.
3649         (insert_into_type_stack, insert_type, push_type, push_type_int)
3650         (insert_type_address_space, pop_type, pop_type_int)
3651         (pop_typelist, pop_type_stack, append_type_stack)
3652         (push_type_stack, get_type_stack, push_typelist)
3653         (follow_type_instance_flags, follow_types): Remove (moved to
3654         type-stack.c).
3655         * f-exp.y (type_stack): New global.
3656         Update rules.
3657         (push_kind_type, f_parse): Update.
3658         * d-exp.y (type_stack): New global.
3659         Update rules.
3660         (d_parse): Update.
3661         * c-exp.y (struct c_parse_state) <type_stack>: New member.
3662         Update rules.
3663         * Makefile.in (COMMON_SFILES): Add type-stack.c.
3664         (HFILES_NO_SRCDIR): Add type-stack.h.
3665
3666 2019-04-04  Tom Tromey  <tom@tromey.com>
3667
3668         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
3669         (rust_parser::convert_ast_to_expression, rust_parse)
3670         (rust_lex_test_completion, rust_lex_tests): Update.
3671         * parser-defs.h (struct expr_completion_state): New.
3672         (struct parser_state) <parser_state>: Add completion parameter.
3673         <mark_struct_expression, mark_completion_tag>: New methods.
3674         <parse_completion, m_completion_state>: New members.
3675         (prefixify_expression, null_post_parser): Update.
3676         (mark_struct_expression, mark_completion_tag): Don't declare.
3677         * parse.c (parse_completion, expout_last_struct)
3678         (expout_tag_completion_type, expout_completion_name): Remove
3679         globals.
3680         (parser_state::mark_struct_expression)
3681         (parser_state::mark_completion_tag): Now methods.
3682         (prefixify_expression): Add last_struct parameter.
3683         (prefixify_subexp): Likewise.
3684         (parse_exp_1): Update.
3685         (parse_exp_in_context): Add cstate parameter.  Update.
3686         (parse_expression_for_completion): Create an
3687         expr_completion_state.
3688         (null_post_parser): Add "completion" parameter.
3689         * p-exp.y: Update rules.
3690         (yylex): Update.
3691         * language.h (struct language_defn) <la_post_parser>: Add
3692         "completing" parameter.
3693         * go-exp.y: Update rules.
3694         (lex_one_token): Update.
3695         * expression.h (parse_completion): Don't declare.
3696         * d-exp.y: Update rules.
3697         (lex_one_token): Update rules.
3698         * c-exp.y: Update rules.
3699         (lex_one_token): Update.
3700         * ada-lang.c (resolve): Add "parse_completion" parameter.
3701         (resolve_subexp): Likewise.
3702         (ada_resolve_function): Likewise.
3703
3704 2019-04-04  Tom Tromey  <tom@tromey.com>
3705
3706         * parser-defs.h (struct parser_state) <start_arglist,
3707         end_arglist>: New methods.
3708         <arglist_len, m_funcall_chain>: New members.
3709         (arglist_len, start_arglist, end_arglist): Don't declare.
3710         * parse.c (arglist_len, funcall_chain): Remove global.
3711         (start_arglist, end_arglist): Remove functions.
3712         (parse_exp_in_context): Update.
3713         * p-exp.y: Update rules.
3714         * m2-exp.y: Update rules.
3715         * go-exp.y: Update rules.
3716         * f-exp.y: Update rules.
3717         * d-exp.y: Update rules.
3718         * c-exp.y: Update rules.
3719
3720 2019-04-04  Tom Tromey  <tom@tromey.com>
3721
3722         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
3723         lex_operator, push_back>: New methods.
3724         Update all rules.
3725         (rust_parser::lex_hex, lex_escape): Rename and update.
3726         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
3727         (rust_parser::lex_operator): Rename and update.
3728         (rust_parser::lex_number, rustyylex, rustyyerror)
3729         (rust_lex_test_init, rust_lex_test_sequence)
3730         (rust_lex_test_push_back, rust_lex_tests): Update.
3731         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
3732         parameter.
3733         <lexptr, prev_lexptr>: New members.
3734         (lexptr, prev_lexptr): Don't declare.
3735         * parse.c (lexptr, prev_lexptr): Remove globals.
3736         (parse_exp_in_context): Update.
3737         * p-exp.y (yylex, yyerror): Update.
3738         * m2-exp.y (parse_number, yylex, yyerror): Update.
3739         * go-exp.y (lex_one_token, yyerror): Update.
3740         * f-exp.y (match_string_literal, yylex, yyerror): Update.
3741         * d-exp.y (lex_one_token, yyerror): Update.
3742         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
3743         (lex_one_token, yyerror): Update.
3744         * ada-lex.l (YY_INPUT): Update.
3745         (rewind_to_char): Update.
3746         * ada-exp.y (yyerror): Update.
3747
3748 2019-04-04  Tom Tromey  <tom@tromey.com>
3749
3750         * rust-exp.y (rustyylex, rust_lex_tests): Update.
3751         * parser-defs.h (struct parser_state) <parser_state>: Add new
3752         parameter.
3753         <comma_terminates>: New member.
3754         (comma_terminates): Don't declare global.
3755         * parse.c (comma_terminates): Remove global.
3756         (parse_exp_in_context): Update.
3757         * p-exp.y (yylex): Update.
3758         * m2-exp.y (yylex): Update.
3759         * go-exp.y (lex_one_token): Update.
3760         * f-exp.y (yylex): Update.
3761         * d-exp.y (lex_one_token): Update.
3762         * c-exp.y (lex_one_token): Update.
3763         * ada-lex.l: Update.
3764
3765 2019-04-04  Tom Tromey  <tom@tromey.com>
3766
3767         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
3768         (rustyylex, rust_lex_test_init, rust_lex_test_one)
3769         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
3770         * parser-defs.h (paren_depth): Don't declare.
3771         * parse.c (paren_depth): Remove global.
3772         (parse_exp_in_context): Update.
3773         * p-exp.y (paren_depth): New global.
3774         (pascal_parse): Initialize it.
3775         * m2-exp.y (paren_depth): New global.
3776         (m2_parse): Initialize it.
3777         * go-exp.y (paren_depth): New global.
3778         (go_parse): Initialize it.
3779         * f-exp.y (paren_depth): New global.
3780         (f_parse): Initialize it.
3781         * d-exp.y (paren_depth): New global.
3782         (d_parse): Initialize it.
3783         * c-exp.y (paren_depth): New global.
3784         (c_parse): Initialize it.
3785         * ada-lex.l (paren_depth): New global.
3786         (lexer_init): Initialize it.
3787
3788 2019-04-04  Tom Tromey  <tom@tromey.com>
3789
3790         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
3791         (rust_parser::convert_ast_to_type)
3792         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3793         * parser-defs.h (struct parser_state) <parser_state>: Add
3794         parameters.  Initialize new members.
3795         <expression_context_block, expression_context_pc>: New members.
3796         * parse.c (expression_context_block, expression_context_pc):
3797         Remove globals.
3798         (parse_exp_in_context): Update.
3799         * p-exp.y: Update all rules.
3800         (yylex): Update.
3801         * m2-exp.y: Update all rules.
3802         (yylex): Update.
3803         * go-exp.y (yylex): Update.
3804         * f-exp.y (yylex): Update.
3805         * d-exp.y: Update all rules.
3806         (yylex): Update.
3807         * c-exp.y: Update all rules.
3808         (lex_one_token, classify_name, yylex, c_parse): Update.
3809         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
3810
3811 2019-04-04  Tom Tromey  <tom@tromey.com>
3812
3813         * gdbarch.h, gdbarch.c: Rebuild.
3814         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
3815         * stap-probe.h:
3816         (struct stap_parse_info): Replace "parser_state" with
3817         "expr_builder".
3818         * parser-defs.h (struct expr_builder): Rename from "parser_state".
3819         (parser_state): New class.
3820         * parse.c (expr_builder): Rename.
3821         (expr_builder::release): Rename.
3822         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
3823         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
3824         (write_exp_elt_longcst, write_exp_elt_floatcst)
3825         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
3826         (write_exp_string_vector, write_exp_bitstring)
3827         (write_exp_msymbol, mark_struct_expression)
3828         (write_dollar_variable)
3829         (insert_type_address_space, increase_expout_size): Replace
3830         "parser_state" with "expr_builder".
3831         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
3832         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
3833         "parser_state" with "expr_builder".
3834
3835 2019-04-04  Tom Tromey  <tom@tromey.com>
3836
3837         * rust-exp.y: Replace "parse_language" with method call.
3838         * p-exp.y:
3839         (yylex): Replace "parse_language" with method call.
3840         * m2-exp.y:
3841         (yylex): Replace "parse_language" with method call.
3842         * go-exp.y (classify_name): Replace "parse_language" with method
3843         call.
3844         * f-exp.y (yylex): Replace "parse_language" with method call.
3845         * d-exp.y (lex_one_token): Replace "parse_language" with method
3846         call.
3847         * c-exp.y:
3848         (lex_one_token, classify_name, yylex): Replace "parse_language"
3849         with method call.
3850         * ada-exp.y (find_primitive_type, type_char)
3851         (type_system_address): Replace "parse_language" with method call.
3852
3853 2019-04-04  Tom Tromey  <tom@tromey.com>
3854
3855         * rust-exp.y: Replace "parse_gdbarch" with method call.
3856         * parse.c (write_dollar_variable, insert_type_address_space):
3857         Replace "parse_gdbarch" with method call.
3858         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
3859         call.
3860         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
3861         call.
3862         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
3863         "parse_gdbarch" with method call.
3864         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
3865         with method call.
3866         * f-exp.y (parse_type, parse_f_type, yylex): Replace
3867         "parse_gdbarch" with method call.
3868         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
3869         "parse_gdbarch" with method call.
3870         * c-exp.y (parse_type, parse_number, classify_name): Replace
3871         "parse_gdbarch" with method call.
3872         * ada-lex.l: Replace "parse_gdbarch" with method call.
3873         * ada-exp.y (parse_type, find_primitive_type, type_char)
3874         (type_system_address): Replace "parse_gdbarch" with method call.
3875
3876 2019-04-04  Tom Tromey  <tom@tromey.com>
3877
3878         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
3879         * stap-probe.c (stap_parse_argument): Update.
3880         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
3881         initial_size parameter.
3882         * rust-exp.y (rust_lex_tests): Update.
3883         * parse.c (parser_state): Update.
3884         (parse_exp_in_context): Update.
3885         * parser-defs.h (struct parser_state) <parser_state>: Remove
3886         "initial_size" parameter.
3887
3888 2019-04-04  Tom Tromey  <tom@tromey.com>
3889
3890         * parser-defs.h (increase_expout_size): Don't declare.
3891         * parse.c (increase_expout_size): Now static.
3892
3893 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
3894
3895         * gnu-nat.c (gnu_nat_target::wait): Fix
3896         target_waitstatus_to_string call.
3897
3898 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3899
3900         * eval.c (evaluate_subexp_standard): Handle internal functions
3901         during Fortran function call handling.
3902
3903 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3904
3905         * NEWS: Mention new internal functions.
3906         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
3907         (read_base_type): Use dwarf2_init_complex_target_type.
3908         * value.c (creal_internal_fn): New function.
3909         (cimag_internal_fn): New function.
3910         (_initialize_values): Register new internal functions.
3911
3912 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3913
3914         * infrun.c (stop_all_threads): If debug_infrun, always
3915         trace the wait status after wait_one, using
3916         target_waitstatus_to_string and target_pid_to_str.
3917         (handle_inferior_event): Replace various trace of
3918         wait status kind by a single trace.
3919         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
3920         wait status kind image by target_waitstatus_to_string.
3921         * target/waitstatus.c (target_waitstatus_to_string): Fix
3922         obsolete comment.
3923
3924 2019-04-01  Tom Tromey  <tromey@adacore.com>
3925
3926         PR symtab/23331:
3927         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
3928
3929 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
3930             Pedro Alves  <palves@redhat.com>
3931
3932         * top.c (quit_force): Call 'finalize_values'.
3933         * value.c (finalize_values): New function.
3934         * value.h (finalize_values): Declare.
3935
3936 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
3937
3938         * NEWS: Announce $_gdb_major and $_gdb_minor.
3939
3940         * top.c (init_gdb_version_vars): New function.
3941         (gdb_init): Call init_gdb_version_vars.
3942
3943 2019-03-29  Tom Tromey  <tromey@adacore.com>
3944
3945         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
3946         help text.  Remove dead code.
3947
3948 2019-03-29  Keith Seitz  <keiths@redhat.com>
3949
3950         From Siddhesh Poyarekar:
3951         * f-lang.h (f77_get_upperbound): Return LONGEST.
3952         (f77_get_lowerbound): Likewise.
3953         * f-typeprint.c (f_type_print_varspec_suffix): Expand
3954         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
3955         print them.
3956         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
3957         plongest to format print it.
3958         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
3959         (f77_get_upperbound): Likewise.
3960         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
3961         LOWER_BOUND to LONGEST.
3962         (f77_create_arrayprint_offset_tbl): Likewise.
3963
3964 2019-03-29  Keith Seitz  <keiths@redhat.com>
3965
3966         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
3967         %s/pulongest for TYPE_LENGTH instead of %d in format
3968         strings.
3969         * ada-typerint.c (ada_print_type): Likewise.
3970         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
3971         * compile/compile-c-support.c (generate_register_struct): Likewise.
3972         * gdbtypes.c (recursive_dump_type): Likewise.
3973         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
3974         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
3975         instead of %d in format strings.
3976         * riscv-tdep.c (riscv_type_alignment): Cast second argument
3977         to std::min to ULONGEST.
3978         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
3979         instead of %d in format strings.
3980         * tracepoint.c (info_scope_command): Likewise.
3981         * typeprint.c (print_offset_data::update)
3982         (print_offset_data::finish): Likewise.
3983         * xtensa-tdep.c (xtensa_store_return_value)
3984         (xtensa_push_dummy_call): Likewise.
3985
3986 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
3987
3988         * windows-nat.c (display_selector): Fixed format specifications
3989         for 64-bit Cygwin.
3990
3991 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3992
3993         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
3994
3995 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
3996
3997         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
3998         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
3999         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
4000         (nios2_linux_init_abi): Install it.
4001
4002 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4003
4004         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
4005
4006 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4007
4008         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
4009
4010 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4011             Tom Tromey  <tromey@adacore.com>
4012
4013         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
4014
4015 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
4016
4017         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
4018         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
4019         method to compute the bounds of range types. Also print "[evaluated]"
4020         if the bounds' values come from a dynamic evaluation.
4021
4022 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4023
4024         * cp-valprint.c (cp_print_value_fields): Don't print trailing
4025         whitespace when pretty printing is on.
4026
4027 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4028
4029         * ppc-linux-nat.c: Add include.
4030
4031 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4032
4033         * NEWS: Mention AArch64 Pointer Authentication.
4034
4035 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4036
4037         * arm-linux-nat.c: Add include.
4038
4039 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
4040
4041         * source-cache.c (source_cache::get_source_lines): Re-read
4042         fullname after calling open_source_file.
4043
4044 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
4045
4046         * NEWS: Mention TLS support for FreeBSD.
4047
4048 2019-03-25  Tom Tromey  <tromey@adacore.com>
4049
4050         * minsyms.c (BUNCH_SIZE): Update comment.
4051         (~minimal_symbol_reader): Remove old comment.
4052         (compact_minimal_symbols): Update comment.
4053         (minimal_symbol_reader::install): Remove old comment.  Update
4054         other comments.
4055
4056 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4057
4058         * s390-linux-nat.c: Add include.
4059
4060 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4061
4062         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4063         Call linux_get_hwcap.
4064         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
4065         Likewise.
4066         (aarch64_linux_get_hwcap): Remove function.
4067         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
4068         declaration.
4069         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
4070         linux_get_hwcap.
4071         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4072         * linux-tdep.c (linux_get_hwcap): Add function.
4073         (linux_get_hwcap2): Likewise.
4074         * linux-tdep.h (linux_get_hwcap): Add declaration.
4075         (linux_get_hwcap2): Likewise.
4076         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
4077         (ppc_linux_get_hwcap2): Likewise.
4078         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
4079         linux_get_hwcap.
4080         (ppc_linux_nat_target::insert_watchpoint): Likewise.
4081         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
4082         (ppc_linux_nat_target::read_description): Likewise.
4083         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
4084         * s390-linux-nat.c: Likewise.
4085         * s390-linux-tdep.c (s390_core_read_description): Likewise.
4086
4087 2019-03-24  Tom Tromey  <tom@tromey.com>
4088
4089         * ada-lang.c (standard_lookup): Simplify initialization.
4090         (ada_lookup_symbol_nonlocal): Simplify return.
4091         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
4092         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
4093         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
4094         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
4095         initialization.
4096         * solib.c (solib_global_lookup): Simplify.
4097         * symtab.c (null_block_symbol): Remove.
4098         (symbol_cache_lookup): Simplify returns.
4099         (lookup_language_this): Simplify returns.
4100         (lookup_symbol_aux): Simplify return.
4101         (lookup_local_symbol): Simplify returns.
4102         (lookup_global_symbol_from_objfile): Simplify return.
4103         (lookup_symbol_in_objfile_symtabs)
4104         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
4105         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
4106         (lookup_static_symbol, lookup_global_symbol): Simplify return.
4107         * cp-namespace.c (cp_lookup_bare_symbol)
4108         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
4109         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
4110         (cp_lookup_nested_symbol): Don't use null_block_symbol.
4111         (cp_lookup_symbol_via_imports): Simplify initialization.
4112         (find_symbol_in_baseclass): Likewise.
4113         * symtab.h (null_block_symbol): Remove.
4114         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
4115         (d_lookup_nested_symbol, d_lookup_symbol_imports)
4116         (d_lookup_symbol_module): Likewise.
4117         (find_symbol_in_baseclass): Simplify initialization.
4118
4119 2019-03-24  Tom Tromey  <tom@tromey.com>
4120
4121         * expression.h: Don't include symtab.h.
4122         (struct block): Forward declare.
4123
4124 2019-03-24  Tom Tromey  <tom@tromey.com>
4125
4126         * c-exp.y (typebase): Remove casts.
4127         * gdbtypes.c (lookup_unsigned_typename, )
4128         (lookup_signed_typename): Remove cast.
4129         * eval.c (parse_to_comma_and_eval): Remove cast.
4130         * parse.c (write_dollar_variable): Remove cast.
4131         * block.h (struct block) <superblock>: Now const.
4132         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
4133         * psymtab.c (psym_map_matching_symbols): Make "block" const.
4134         (map_block): Make "block" const.
4135         * symfile.h (struct quick_symbol_functions)
4136         <map_matching_symbols>: Constify block argument to "callback".
4137         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
4138         const.
4139         (find_pc_sect_compunit_symtab): Make "b" const.
4140         (find_symbol_at_address): Likewise.
4141         (search_symbols): Likewise.
4142         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
4143         (dw2_debug_names_lookup_symbol): Likewise.
4144         (dw2_map_matching_symbols): Update.
4145         * p-valprint.c (pascal_val_print): Remove "block".
4146         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
4147         (aux_add_nonlocal_symbols): Make "block" const.
4148         (resolve_subexp): Remove cast.
4149         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
4150         const.
4151         (iterate_over_file_blocks): Likewise.
4152         * f-exp.y (%union) <bval>: Remove.
4153         * coffread.c (patch_opaque_types): Make "b" const.
4154         * spu-tdep.c (spu_catch_start): Make "block" const.
4155         * c-valprint.c (print_unpacked_pointer): Remove "block".
4156         * symmisc.c (dump_symtab_1): Make "b" const.
4157         (block_depth): Make "block" const.
4158         * d-exp.y (%union) <bval>: Remove.
4159         * cp-support.h (cp_lookup_rtti_type): Update.
4160         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
4161         * psymtab.c (psym_lookup_symbol): Make "block" const.
4162         (maintenance_check_psymtabs): Make "b" const.
4163         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
4164         (enumerate_locals, enumerate_args): Update.
4165         * python/py-symtab.c (stpy_global_block): Make "block" const.
4166         (stpy_static_block): Likewise.
4167         * inline-frame.c (block_starting_point_at): Make "new_block"
4168         const.
4169         * block.c (find_block_in_blockvector): Make return type const.
4170         (blockvector_for_pc_sect): Make "b" const.
4171         (find_block_in_blockvector): Make "b" const.
4172
4173 2019-03-23  Tom Tromey  <tom@tromey.com>
4174
4175         * varobj.c (varobj_create): Update.
4176         * symfile.c (clear_symtab_users): Don't reset innermost_block.
4177         * printcmd.c (display_command, do_one_display): Don't reset
4178         innermost_block.
4179         * parser-defs.h (enum innermost_block_tracker_type): Move to
4180         expression.h.
4181         (innermost_block): Update comment.
4182         * parse.c (parse_exp_1): Add tracker_types parameter.
4183         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
4184         tracker_types parameter.  Reset innermost_block.
4185         (parse_exp_in_context): Remove.
4186         (parse_expression_for_completion): Update.
4187         * objfiles.c (~objfile): Don't reset expression_context_block or
4188         innermost_block.
4189         * expression.h (enum innermost_block_tracker_type): Move from
4190         parser-defs.h.
4191         (parse_exp_1): Add tracker_types parameter.
4192         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
4193         reset innermost_block.
4194
4195 2019-03-23  Tom Tromey  <tom@tromey.com>
4196
4197         * objfiles.h: Include bcache.h.
4198
4199 2019-03-23  Tom Tromey  <tom@tromey.com>
4200
4201         * linespec.c (get_current_search_block): Use
4202         scoped_restore_current_language.
4203         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
4204
4205 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4206             Jiong Wang  <jiong.wang@arm.com>
4207
4208         * aarch64-linux-tdep.c
4209         (aarch64_linux_iterate_over_regset_sections): Check for pauth
4210         section.
4211         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
4212
4213 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4214             Jiong Wang  <jiong.wang@arm.com>
4215
4216         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
4217         instructions.
4218         (aarch64_analyze_prologue_test): Add PACIASP test.
4219         (aarch64_prologue_prev_register): Unmask PC value.
4220
4221 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4222             Jiong Wang  <jiong.wang@arm.com>
4223
4224         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
4225         (aarch64_dwarf2_prev_register): Unmask PC value.
4226         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
4227         (aarch64_execute_dwarf_cfa_vendor_op): Check for
4228         DW_CFA_AARCH64_negate_ra_state.
4229         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
4230
4231 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4232             Jiong Wang  <jiong.wang@arm.com>
4233
4234         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
4235         registers.
4236         (aarch64_pseudo_register_name): Likewise.
4237         (aarch64_pseudo_register_type): Likewise.
4238         (aarch64_pseudo_register_reggroup_p): Likewise.
4239         (aarch64_gdbarch_init): Add pauth registers.
4240         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
4241         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
4242         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
4243         (struct gdbarch_tdep): Add regnum for ra_state.
4244
4245 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4246             Jiong Wang  <jiong.wang@arm.com>
4247
4248         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
4249
4250 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4251             Jiong Wang  <jiong.wang@arm.com>
4252
4253         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
4254         function.
4255         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
4256         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
4257         (aarch64_gdbarch_init): Add puth registers.
4258         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
4259         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
4260         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
4261
4262 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4263             Jiong Wang  <jiong.wang@arm.com>
4264
4265         * aarch64-linux-nat.c
4266         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
4267         * aarch64-linux-tdep.c
4268         (aarch64_linux_core_read_description): Likewise.
4269         (aarch64_linux_get_hwcap): New function.
4270         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
4271         (aarch64_linux_get_hwcap): New declaration.
4272
4273 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4274             Jiong Wang  <jiong.wang@arm.com>
4275
4276         * aarch64-linux-nat.c
4277         (aarch64_linux_nat_target::read_description): Add pauth param.
4278         * aarch64-linux-tdep.c
4279         (aarch64_linux_core_read_description): Likewise.
4280         * aarch64-tdep.c (struct target_desc): Add in pauth.
4281         (aarch64_read_description): Add pauth param.
4282         (aarch64_gdbarch_init): Likewise.
4283         * aarch64-tdep.h (aarch64_read_description): Likewise.
4284         * arch/aarch64.c (aarch64_create_target_description): Likewise.
4285         * arch/aarch64.h (aarch64_create_target_description): Likewise.
4286         * features/Makefile: Add new files.
4287         * features/aarch64-pauth.c: New file.
4288         * features/aarch64-pauth.xml: New file.
4289
4290 2019-03-20  Tom Tromey  <tromey@adacore.com>
4291
4292         * infrun.c (handle_inferior_event): Rename from
4293         handle_inferior_event_1.  Create a scoped_value_mark.
4294         (handle_inferior_event): Remove.
4295
4296 2019-03-19  Tom Tromey  <tromey@adacore.com>
4297
4298         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
4299         * infrun.h (print_stop_event): Add "displays" parameter.
4300         * infrun.c (print_stop_event): Add "displays" parameter.
4301
4302 2019-03-19  Pedro Alves  <palves@redhat.com>
4303
4304         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
4305         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
4306         to -1.  Fix TABs vs spaces.
4307         (tui_ui_out::tui_ui_out): Don't initialize fields here.
4308         * tui/tui-out.h (tui_ui_out) Add intro comments.
4309         <m_line, m_start_of_line>: In-class initialize, and add describing
4310         comment.
4311
4312 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
4313
4314         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
4315         variable names.
4316         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
4317
4318 2019-03-18  Pedro Alves  <palves@redhat.com>
4319             Eli Zaretskii <eliz@gnu.org>
4320
4321         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
4322         m_line and m_start_of_line.
4323
4324 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
4325
4326         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
4327         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
4328         it returns a newline.  This fixes a regression in TU mode, whereby
4329         the next line is output on the same screen line as the user input.
4330
4331 2019-03-18  Tom Tromey  <tromey@adacore.com>
4332
4333         * minsyms.c (minimal_symbol_reader::install): Remove call to
4334         obstack_blank.
4335
4336 2019-03-18  Pedro Alves  <palves@redhat.com>
4337
4338         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
4339         New globals.
4340         (apply_style): New, factored out from ...
4341         (apply_ansi_escape): ... this.  Handle reverse video mode.
4342         (tui_set_reverse_mode): New function.
4343         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
4344         * tui/tui-winsource.c (tui_show_source_line): Use
4345         tui_set_reverse_mode instead of setting A_STANDOUT.
4346         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
4347         New setter methods.
4348
4349 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
4350
4351         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
4352         Handle tabs.
4353
4354 2019-03-18  Tom Tromey  <tromey@adacore.com>
4355
4356         * ada-lang.c (empty_array): Add "high" parameter.
4357         (ada_evaluate_subexp): Update.
4358
4359 2019-03-17  Sergei Trofimovich <siarheit@google.com>
4360
4361         * unittests/string_view-selftests.c: Define
4362         _initialize_string_view_selftests unconditionally.
4363
4364 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4365
4366         PR gdb/24350
4367         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
4368
4369 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4370
4371         PR gdb/24351
4372         * windows-nat.c (display_selector): Fix format specifiers.
4373
4374 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
4375
4376         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
4377         tui_refill_source_window instead of tui_refresh_win, to update the
4378         current execution line.  This fixes redisplay of the current line
4379         when stepping through the code with "next" or "step".
4380
4381 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4382
4383         * source-cache.c (source_cache::get_source_lines): Call
4384         find_source_lines to initialize s->nlines.  This fixes vertical
4385         scrolling of TUI source window when the DOWN arrow is pressed.
4386
4387 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4388
4389         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
4390         linux-thread-db.c (_initialize_thread_db): Likewise.
4391
4392 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4393
4394         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
4395         wclrtoeol in tui_show_source_line".  This reverts changes made in
4396         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
4397
4398 2019-03-15  Tom Tromey  <tom@tromey.com>
4399
4400         * symtab.h (struct minimal_symbol): Derive from
4401         general_symbol_info.
4402         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
4403         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
4404         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
4405         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
4406         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
4407         (MSYMBOL_SEARCH_NAME): Update.
4408         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
4409         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
4410         * minsyms.c (minimal_symbol_reader::record_full): Update.
4411
4412 2019-03-15  Tom Tromey  <tom@tromey.com>
4413
4414         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
4415
4416 2019-03-15  Tom Tromey  <tom@tromey.com>
4417
4418         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
4419         unique_xmalloc_ptr.
4420         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
4421         Update.
4422         * minsyms.c (lookup_minimal_symbol_by_pc_section)
4423         (build_minimal_symbol_hash_tables)
4424         (minimal_symbol_reader::install): Update.
4425
4426 2019-03-15  Tom Tromey  <tom@tromey.com>
4427
4428         * symtab.c (create_demangled_names_hash): Update.
4429         (symbol_set_names): Update.
4430         * objfiles.h (struct objfile_per_bfd_storage)
4431         <demangled_names_hash>: Now an htab_up.
4432         * objfiles.c (objfile_per_bfd_storage): Simplify.
4433
4434 2019-03-15  Tom Tromey  <tom@tromey.com>
4435
4436         * objfiles.h (struct objfile_per_bfd_storage): Declare
4437         destructor.
4438         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
4439         New.
4440         (get_objfile_bfd_data): Use new.  Don't initialize
4441         language_of_main.
4442         (free_objfile_per_bfd_storage): Remove.
4443         (objfile_bfd_data_free, objfile::~objfile): Use delete.
4444
4445 2019-03-15  Tom Tromey  <tom@tromey.com>
4446
4447         * symfile.c (reread_symbols): Update.
4448         * objfiles.c (objfile::objfile): Update.
4449         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
4450         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
4451         comment.
4452         (minimal_symbol_reader::install): Update.
4453         (terminate_minimal_symbol_table): Remove.
4454         * jit.c (jit_object_close_impl): Update.
4455
4456 2019-03-15  Tom Tromey  <tom@tromey.com>
4457
4458         * minsyms.c (minimal_symbol_reader::record_full): Remove some
4459         initializations.
4460
4461 2019-03-15  Tom Tromey  <tom@tromey.com>
4462
4463         * objfiles.h (struct objfile_per_bfd_storage)
4464         <demangled_hash_languages>: Now a bitset.
4465         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
4466         (lookup_minimal_symbol): Update.
4467
4468 2019-03-15  Tom Tromey  <tom@tromey.com>
4469
4470         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
4471         Don't return the symbol.
4472         * coffread.c (record_minimal_symbol): Use record_full.
4473
4474 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
4475
4476         The MS-Windows port of ncurses fails to switch to a color pair if
4477         one or both of the colors are the implicit default colors.  This
4478         change records the default colors when TUI is initialized, and
4479         then specifies them explicitly when a color pair uses the default
4480         colors.  This allows color styling in TUI mode on MS-Windows.
4481
4482         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
4483         ncurses_norm_attr.
4484         (tui_initialize_io) [__MINGW32__]: Record the default terminal
4485         colors in ncurses_norm_attr.
4486         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
4487         "none", replace it with the default color recorded in
4488         ncurses_norm_attr.
4489
4490 2019-03-14  Tom Tromey  <tromey@adacore.com>
4491
4492         * source-cache.h (class source_cache) <get_source_lines>: Return
4493         std::string.
4494         * source-cache.c (source_cache::extract_lines): Handle case where
4495         first_pos==npos.  Return std::string.
4496         (source_cache::get_source_lines): Update.
4497
4498 2019-03-14  Tom Tromey  <tromey@adacore.com>
4499
4500         * NEWS: Add item for "style sources" commands.
4501         * source-cache.c (source_cache::get_source_lines): Check
4502         source_styling.
4503         * cli/cli-style.c (source_styling): New global.
4504         (_initialize_cli_style): Add "style sources" commands.
4505         (show_style_sources): New function.
4506         * cli/cli-style.h (source_styling): Declare.
4507
4508 2019-03-14  Pedro Alves  <palves@redhat.com>
4509             Tom Tromey  <tromey@adacore.com>
4510
4511         * tui/tui-winsource.h (tui_refill_source_window): Declare.
4512         * tui/tui-winsource.c (tui_refill_source_window): New function,
4513         from...
4514         (tui_horizontal_source_scroll): ... here.  Move some logic.
4515         * cli/cli-style.c (set_style_enabled): Notify new observable.
4516         * tui/tui-hooks.c (tui_redisplay_source): New function.
4517         (tui_attach_detach_observers): Attach or detach
4518         tui_redisplay_source.
4519         * observable.h (source_styling_changed): New observable.
4520         * observable.c: Define source_styling_changed observable.
4521
4522 2019-03-13  Tom Tromey  <tromey@adacore.com>
4523
4524         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
4525         (i386_gnu_nat_target::store_registers): Update.
4526         * target-debug.h (target_debug_print_std_string): New macro.
4527         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4528         * windows-tdep.c (display_one_tib): Update.
4529         * tui/tui-stack.c (tui_make_status_line): Update.
4530         * top.c (print_inferior_quit_action): Update.
4531         * thread.c (thr_try_catch_cmd): Update.
4532         (add_thread_with_info): Update.
4533         (thread_target_id_str): Update.
4534         (thr_try_catch_cmd): Update.
4535         (thread_command): Update.
4536         (thread_find_command): Update.
4537         * record-btrace.c (record_btrace_target::info_record)
4538         (record_btrace_resume_thread, record_btrace_target::resume)
4539         (record_btrace_cancel_resume, record_btrace_step_thread)
4540         (record_btrace_target::wait, record_btrace_target::wait)
4541         (record_btrace_target::wait, record_btrace_target::stop): Update.
4542         * progspace.c (print_program_space): Update.
4543         * process-stratum-target.c
4544         (process_stratum_target::thread_address_space): Update.
4545         * linux-fork.c (linux_fork_mourn_inferior)
4546         (detach_checkpoint_command, info_checkpoints_command)
4547         (linux_fork_context): Update.
4548         (linux_fork_detach): Update.
4549         (class scoped_switch_fork_info): Update.
4550         (delete_checkpoint_command): Update.
4551         * infrun.c (follow_fork_inferior): Update.
4552         (follow_fork_inferior): Update.
4553         (proceed_after_vfork_done): Update.
4554         (handle_vfork_child_exec_or_exit): Update.
4555         (follow_exec): Update.
4556         (displaced_step_prepare_throw): Update.
4557         (displaced_step_restore): Update.
4558         (start_step_over): Update.
4559         (resume_1): Update.
4560         (clear_proceed_status_thread): Update.
4561         (proceed): Update.
4562         (print_target_wait_results): Update.
4563         (do_target_wait): Update.
4564         (context_switch): Update.
4565         (stop_all_threads): Update.
4566         (restart_threads): Update.
4567         (finish_step_over): Update.
4568         (handle_signal_stop): Update.
4569         (switch_back_to_stepped_thread): Update.
4570         (keep_going_pass_signal): Update.
4571         (print_exited_reason): Update.
4572         (normal_stop): Update.
4573         * inferior.c (inferior_pid_to_str): Change return type.
4574         (print_selected_inferior): Update.
4575         (add_inferior): Update.
4576         (detach_inferior): Update.
4577         * dummy-frame.c (fprint_dummy_frames): Update.
4578         * dcache.c (dcache_info_1): Update.
4579         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
4580         (btrace_fetch, btrace_clear): Update.
4581         * linux-tdep.c (linux_core_pid_to_str): Change return type.
4582         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
4583         type.
4584         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
4585         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
4586         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
4587         * gdbarch.c, gdbarch.h: Rebuild.
4588         * gdbarch.sh (core_pid_to_str): Change return type.
4589         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
4590         return type.
4591         (windows_nat_target::pid_to_str): Change return type.
4592         (windows_delete_thread): Update.
4593         (windows_nat_target::attach): Update.
4594         (windows_nat_target::files_info): Update.
4595         * target-delegates.c: Rebuild.
4596         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
4597         return type.
4598         (sol_thread_target::pid_to_str): Change return type.
4599         * remote.c (class remote_target) <pid_to_str>: Change return
4600         type.
4601         (remote_target::pid_to_str): Change return type.
4602         (extended_remote_target::attach, remote_target::remote_stop_ns)
4603         (remote_target::remote_notif_remove_queued_reply)
4604         (remote_target::push_stop_reply, remote_target::disable_btrace):
4605         Update.
4606         (extended_remote_target::attach): Update.
4607         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
4608         type.
4609         (gdbsim_target::pid_to_str): Change return type.
4610         * ravenscar-thread.c (struct ravenscar_thread_target)
4611         <pid_to_str>: Change return type.
4612         (ravenscar_thread_target::pid_to_str): Change return type.
4613         * procfs.c (class procfs_target) <pid_to_str>: Change return
4614         type.
4615         (procfs_target::pid_to_str): Change return type.
4616         (procfs_target::attach): Update.
4617         (procfs_target::detach): Update.
4618         (procfs_target::fetch_registers): Update.
4619         (procfs_target::store_registers): Update.
4620         (procfs_target::wait): Update.
4621         (procfs_target::files_info): Update.
4622         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
4623         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
4624         return type.
4625         (nto_procfs_target::pid_to_str): Change return type.
4626         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
4627         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
4628         return type.
4629         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
4630         (exit_lwp): Update.
4631         (attach_proc_task_lwp_callback, get_detach_signal)
4632         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
4633         (linux_nat_target::resume, wait_lwp, stop_callback)
4634         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
4635         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
4636         (linux_nat_wait_1, resume_stopped_resumed_lwps)
4637         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
4638         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
4639         type.
4640         (inf_ptrace_target::attach): Update.
4641         (inf_ptrace_target::files_info): Update.
4642         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
4643         type.
4644         (go32_nat_target::pid_to_str): Change return type.
4645         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
4646         (gnu_nat_target::wait): Update.
4647         (gnu_nat_target::wait): Update.
4648         (gnu_nat_target::resume): Update.
4649         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
4650         (fbsd_nat_target::wait): Update.
4651         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
4652         type.
4653         (darwin_nat_target::attach): Update.
4654         * corelow.c (class core_target) <pid_to_str>: Change return type.
4655         (core_target::pid_to_str): Change return type.
4656         * target.c (normal_pid_to_str): Change return type.
4657         (default_pid_to_str): Likewise.
4658         (target_pid_to_str): Change return type.
4659         (target_translate_tls_address): Update.
4660         (target_announce_detach): Update.
4661         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
4662         return type.
4663         (bsd_uthread_target::pid_to_str): Change return type.
4664         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
4665         type.
4666         (bsd_kvm_target::pid_to_str): Change return type.
4667         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
4668         return type.
4669         (aix_thread_target::pid_to_str): Change return type.
4670         * target.h (struct target_ops) <pid_to_str>: Change return type.
4671         (target_pid_to_str, normal_pid_to_str): Likewise.
4672         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
4673         type.
4674         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
4675         type.
4676         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
4677         return type.
4678         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
4679         type.
4680         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
4681         type.
4682         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
4683         return type.
4684
4685 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
4686
4687         * NEWS: Mention that the new default MI version is 3.  Mention
4688         changes to the output of commands and events that deal with
4689         multi-location breakpoints.
4690         * breakpoint.c: Include "mi/mi-out.h".
4691         (print_one_breakpoint): Change output syntax if using MI version
4692         >= 3.
4693         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
4694         New.
4695         (mi_multi_location_breakpoint_output_fixed): New.
4696         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
4697         (mi_cmd_fix_multi_location_breakpoint_output): New.
4698         (mi_multi_location_breakpoint_output_fixed): New.
4699         * mi/mi-cmds.c (mi_cmds): Register command
4700         -fix-multi-location-breakpoint-output.
4701         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
4702         interpreter "mi".
4703
4704 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
4705
4706         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
4707         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
4708         instantiate mi_ui_out based on interpreter name.
4709         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
4710         * mi/mi-main.c (mi_load_progress): Likewise.
4711
4712 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4713
4714         * NEWS: Combine separate "New targets" sections for 8.3.
4715
4716 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4717
4718         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
4719         (ppcfbsd_init_abi): Install gdbarch
4720         "fetch_tls_load_module_address" and "get_thread_local_address"
4721         methods.
4722
4723 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4724
4725         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
4726         (riscv_fbsd_init_abi): Install gdbarch
4727         "fetch_tls_load_module_address" and "get_thread_local_address"
4728         methods.
4729
4730 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4731
4732         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
4733         (i386fbsd_init_abi): Install gdbarch
4734         "fetch_tls_load_module_address" and "get_thread_local_address"
4735         methods.
4736
4737 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4738
4739         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
4740         (amd64fbsd_init_abi): Install gdbarch
4741         "fetch_tls_load_module_address" and "get_thread_local_address"
4742         methods.
4743
4744 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4745
4746         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
4747         (struct fbsd_pspace_data): New type.
4748         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
4749         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
4750         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
4751         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
4752         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
4753
4754 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4755
4756         * gdbtypes.c (lookup_struct_elt): New function.
4757         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
4758         * gdbtypes.h (struct struct_elt): New type.
4759         (lookup_struct_elt): New prototype.
4760
4761 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4762
4763         * gdbtypes.c (lookup_struct_elt_type): Update comment and
4764         remove disabled code block.
4765
4766 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4767
4768         * gdbarch.sh (get_thread_local_address): New method.
4769         * gdbarch.h, gdbarch.c: Regenerate.
4770         * target.c (target_translate_tls_address): Use
4771         gdbarch_get_thread_local_address if present instead of
4772         target::get_thread_local_address.
4773
4774 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4775
4776         * target.h (target::get_thread_local_address): Update comment.
4777
4778 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4779
4780         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
4781         objfile->separate_debug_objfile_backlink if not NULL.
4782
4783 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4784
4785         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
4786         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
4787         (amd64bsd_store_inferior_registers): Likewise.
4788         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4789         Enable segment base registers.
4790         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
4791         PT_GETFSBASE and PT_GETGSBASE.
4792         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
4793         PT_SETGSBASE.
4794         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
4795         segment base registers.
4796         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4797
4798 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4799
4800         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4801         Update calls to i386_target_description to add 'segments'
4802         parameter.
4803         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
4804         add segment base registers.
4805         * arch/i386.c (i386_create_target_description): Add 'segments'
4806         parameter to enable segment base registers.
4807         * arch/i386.h (i386_create_target_description): Likewise.
4808         * features/i386/32bit-segments.xml: New file.
4809         * features/i386/32bit-segments.c: Generate.
4810         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
4811         call to i386_target_description to add 'segments' parameter.
4812         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4813         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
4814         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
4815         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
4816         if feature is present.
4817         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
4818         Add 'segments' parameter to call to i386_target_description.
4819         (i386_target_description): Add 'segments' parameter to enable
4820         segment base registers.
4821         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
4822         to call to i386_target_description.
4823         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
4824         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
4825         Define I386_NUM_REGS.
4826         (i386_target_description): Add 'segments' parameter to enable
4827         segment base registers.
4828
4829 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
4830
4831         PR/24325
4832         * source-cache.c: #undef open and close, to avoid unresolved
4833         externals during linking.
4834
4835 2019-03-12  Tom Tromey  <tromey@adacore.com>
4836
4837         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
4838         const.  Add initializers.
4839         (_initialize_remote): Don't initialize ptid globals.
4840
4841 2019-03-12  Pedro Alves  <palves@redhat.com>
4842
4843         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
4844
4845 2019-03-12  Pedro Alves  <palves@redhat.com>
4846
4847         * cp-name-parser.y (main): Remove unused 'len' variable.
4848
4849 2019-03-12  Tom Tromey  <tromey@adacore.com>
4850
4851         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
4852         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
4853
4854 2019-03-12  Tom Tromey  <tromey@adacore.com>
4855
4856         * linux-nat.c (iterate_over_lwps): Update.
4857         (stop_callback): Remove parameter.
4858         (stop_wait_callback, detach_callback, resume_set_callback)
4859         (select_singlestep_lwp_callback, set_ignore_sigint)
4860         (status_callback, resumed_callback, resume_clear_callback)
4861         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
4862         data parameter.
4863         (linux_nat_target::detach, linux_nat_target::resume)
4864         (linux_stop_and_wait_all_lwps, select_event_lwp)
4865         (linux_nat_filter_event, linux_nat_wait_1)
4866         (linux_nat_target::kill, linux_nat_target::stop)
4867         (linux_nat_target::stop): Update.
4868         (linux_nat_resume_callback): Change type.
4869         (resume_stopped_resumed_lwps, count_events_callback)
4870         (select_event_lwp_callback): Likewise.
4871         (linux_stop_lwp, linux_nat_stop_lwp): Update.
4872         * arm-linux-nat.c (struct update_registers_data): Remove.
4873         (update_registers_callback): Change type.
4874         (arm_linux_insert_hw_breakpoint1): Update.
4875         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
4876         parameter.
4877         (x86_linux_dr_set_addr): Update.
4878         (x86_linux_dr_set_control): Update.
4879         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
4880         (iterate_over_lwps): Use gdb::function_view.
4881         * nat/aarch64-linux-hw-point.c (struct
4882         aarch64_dr_update_callback_param): Remove.
4883         (debug_reg_change_callback): Change type.
4884         (aarch64_notify_debug_reg_change): Update.
4885         * s390-linux-nat.c (s390_refresh_per_info): Update.
4886
4887 2019-03-11  Tom Tromey  <tromey@adacore.com>
4888
4889         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
4890         redundant assignment to "this_cu".
4891
4892 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4893
4894         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
4895
4896 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4897
4898         * gdbtypes.c (rank_one_type_parm_set): New function extracted
4899         from...
4900         (rank_one_type): ... this.
4901
4902 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4903
4904         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
4905         from...
4906         (rank_one_type): ... this.
4907
4908 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4909
4910         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
4911         from...
4912         (rank_one_type): ... this.
4913
4914 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4915
4916         * gdbtypes.c (rank_one_type_parm_float): New function extracted
4917         from...
4918         (rank_one_type): ... this.
4919
4920 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4921
4922         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
4923         from...
4924         (rank_one_type): ... this.
4925
4926 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4927
4928         * gdbtypes.c (rank_one_type_parm_range): New function extracted
4929         from...
4930         (rank_one_type): ... this.
4931
4932 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4933
4934         * gdbtypes.c (rank_one_type_parm_char): New function extracted
4935         from...
4936         (rank_one_type): ... this.
4937
4938 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4939
4940         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
4941         from...
4942         (rank_one_type): ... this.
4943
4944 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4945
4946         * gdbtypes.c (rank_one_type_parm_int): New function extracted
4947         from...
4948         (rank_one_type): ... this.
4949
4950 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4951
4952         * gdbtypes.c (rank_one_type_parm_func): New function extracted
4953         from...
4954         (rank_one_type): ... this.
4955
4956 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4957
4958         * gdbtypes.c (rank_one_type_parm_array): New function extracted
4959         from...
4960         (rank_one_type): ... this.
4961
4962 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4963
4964         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
4965         from...
4966         (rank_one_type): ... this.
4967
4968 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4969
4970         * inferior.c (initialize_inferiors): Ensure 'help set/show print
4971         inferior-events' shows the example events.
4972
4973 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
4974
4975         Support styling on native MS-Windows console
4976
4977         PR/24315
4978         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
4979         on MS-Windows if $TERM is not defined.
4980
4981         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
4982
4983         * posix-hdep.c (gdb_console_fputs):
4984         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
4985         functions.
4986         * ui-file.h (gdb_console_fputs): Add prototype.
4987
4988         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
4989         back to fputs only if the former returns zero.
4990
4991 2019-03-07  Tom Tromey  <tom@tromey.com>
4992
4993         * symmisc.c (print_symbol_bcache_statistics): Update.
4994         (print_objfile_statistics): Update.
4995         * symfile.c (allocate_symtab): Update.
4996         * stabsread.c: Don't include bcache.h.
4997         * psymtab.h (struct psymbol_bcache): Don't declare.
4998         (class psymtab_storage) <psymbol_cache>: Now a bcache.
4999         (psymbol_bcache_init, psymbol_bcache_free)
5000         (psymbol_bcache_get_bcache): Don't declare.
5001         * psymtab.c (struct psymbol_bcache): Remove.
5002         (psymtab_storage::psymtab_storage): Update.
5003         (psymtab_storage::~psymtab_storage): Update.
5004         (psymbol_bcache_init, psymbol_bcache_free)
5005         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
5006         (add_psymbol_to_bcache): Update.
5007         (allocate_psymtab): Update.
5008         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
5009         macro_cache>: No longer pointers.
5010         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
5011         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
5012         * macrotab.c (macro_bcache): Update.
5013         * macroexp.c: Don't include bcache.h.
5014         * gdbtypes.c (check_types_worklist): Update.
5015         (types_deeply_equal): Remove TRY/CATCH.  Update.
5016         * elfread.c (elf_symtab_read): Update.
5017         * dwarf2read.c: Don't include bcache.h.
5018         * buildsym.c (buildsym_compunit::get_macro_table): Update.
5019         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
5020         (print_bcache_statistics, bcache_memory_used): Don't declare.
5021         (struct bcache): Move from bcache.c.  Add constructor, destructor,
5022         methods.  Rename all data members.
5023         * bcache.c (struct bcache): Move to bcache.h.
5024         (bcache::expand_hash_table): Rename from expand_hash_table.
5025         (bcache): Remove.
5026         (bcache::insert): Rename from bcache_full.
5027         (bcache::compare): Rename from bcache_compare.
5028         (bcache_xmalloc): Remove.
5029         (bcache::~bcache): Rename from bcache_xfree.
5030         (bcache::print_statistics): Rename from print_bcache_statistics.
5031         (bcache::memory_used): Rename from bcache_memory_used.
5032
5033 2019-03-07  Pedro Alves  <palves@redhat.com>
5034
5035         * infrun.c (normal_stop): Also check for
5036         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
5037
5038 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
5039
5040         * f-lang.c (value_from_host_double): Moved to...
5041         * value.c (value_from_host_double): ...here.
5042         * value.h (value_from_host_double): Declare.
5043         * guile/scm-math.c (vlscm_convert_typed_number): Use
5044         value_from_host_double.
5045         (vlscm_convert_number): Likewise.
5046         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
5047         * python/py-value.c (convert_value_from_python): Likewise.
5048
5049 2019-03-06  Tom Tromey  <tom@tromey.com>
5050
5051         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
5052
5053 2019-03-06  Tom Tromey  <tom@tromey.com>
5054
5055         * utils.h (free_current_contents): Don't declare.
5056         * utils.c (free_current_contents): Remove.
5057
5058 2019-03-06  Tom Tromey  <tom@tromey.com>
5059
5060         * top.c (quit_force): Update.
5061         * main.c (captured_command_loop): Update.
5062         * common/new-op.c (operator new): Update.
5063         * common/common-exceptions.c (struct catcher)
5064         <save_cleanup_chain>: Remove member.
5065         (exceptions_state_mc_init): Update.
5066         (exception_try_scope_entry): Return nullptr.
5067         (exception_try_scope_exit, exception_rethrow)
5068         (throw_exception_sjlj, throw_exception_cxx): Update.
5069         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
5070         (all_cleanups, do_cleanups, discard_cleanups)
5071         (discard_final_cleanups, save_cleanups, save_final_cleanups)
5072         (restore_cleanups, restore_final_cleanups): Don't declare.
5073         (do_final_cleanups): Remove parameter.
5074         * common/cleanups.c (cleanup_chain, make_cleanup)
5075         (make_cleanup_dtor, all_cleanups, do_cleanups)
5076         (discard_my_cleanups, discard_cleanups)
5077         (discard_final_cleanups, save_my_cleanups, save_cleanups)
5078         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
5079         (null_cleanup): Remove.
5080         (do_final_cleanups): Remove parameter.
5081
5082 2019-03-06  Tom Tromey  <tom@tromey.com>
5083
5084         * remote.c (remote_target::remote_parse_stop_reply): Use
5085         unique_xmalloc_ptr.
5086
5087 2019-03-06  Tom Tromey  <tom@tromey.com>
5088
5089         * stabsread.c (struct stabs_field_info): Rename from field_info.
5090         <list, fnlist>: Add initializers.
5091         <obstack>: New member.
5092         (read_member_functions, read_struct_fields, read_baseclasses):
5093         Allocate on obstack.  Don't use cleanups.
5094         (read_one_struct_field, read_member_functions, read_struct_fields)
5095         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
5096         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
5097         (read_struct_type): Update.
5098
5099 2019-03-06  Tom Tromey  <tom@tromey.com>
5100
5101         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
5102         * common/filestuff.h (make_cleanup_close): Don't declare.
5103         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
5104         Remove.
5105
5106 2019-03-06  Tom Tromey  <tom@tromey.com>
5107
5108         * solib-aix.c: Use make_scope_exit.
5109
5110 2019-03-06  Tom Tromey  <tom@tromey.com>
5111
5112         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
5113         Use make_scope_exit.
5114
5115 2019-03-06  Tom Tromey  <tom@tromey.com>
5116
5117         * solib-svr4.c (disable_probes_interface): Remove parameter.
5118         (svr4_handle_solib_event): Use make_scope_exit.
5119
5120 2019-03-06  Tom Tromey  <tom@tromey.com>
5121
5122         * remote.c (struct stop_reply_deleter): Remove.
5123         (stop_reply_up): Update.
5124         (struct stop_reply): Derive from notif_event.  Don't typedef.
5125         <regcache>: Now a std::vector.
5126         (stop_reply_xfree): Remove.
5127         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
5128         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
5129         (remote_target::discard_pending_stop_replies): Use delete.
5130         (remote_target::remote_parse_stop_reply): Update.
5131         (remote_target::process_stop_reply): Update.
5132         * remote-notif.h (struct notif_event): Add virtual destructor.
5133         Remove "dtr" member.
5134         (struct notif_client) <alloc_event>: Return a unique_ptr.
5135         (notif_event_xfree): Don't declare.
5136         (notif_event_up): New typedef.
5137         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
5138         (notif_event_xfree, do_notif_event_xfree): Remove.
5139         (remote_notif_state_xfree): Update.
5140
5141 2019-03-06  Tom Tromey  <tom@tromey.com>
5142
5143         * infrun.c (displaced_step_clear_cleanup): Now a
5144         forward_scope_exit type.
5145         (displaced_step_prepare_throw): Update.
5146         (displaced_step_fixup): Update.
5147
5148 2019-03-06  Tom Tromey  <tom@tromey.com>
5149
5150         * inferior.h (class inferior): Update comment.
5151         * gdbthread.h (class thread_info): Update comment.
5152
5153 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
5154             Tom Tromey  <tom@tromey.com>
5155
5156         * stabsread.h (struct stab_section_list): Remove.
5157         (coffstab_build_psymtabs): Update.
5158         * dbxread.c (symbuf_sections): Now a std::vector.
5159         (sect_idx): New global.
5160         (fill_symbuf): Update.
5161         (coffstab_build_psymtabs): Change type of stabsects parameter.
5162         Update.
5163         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
5164         std::vector.
5165         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
5166         (coff_locate_sections): Update.
5167         (coff_symfile_read): Remove cleanups.  Update.
5168         (init_stringtab): Add storage parameter.
5169         (free_stringtab, free_stringtab_cleanup): Remove.
5170         (init_lineno): Add storage parameter.
5171         (free_linetab, free_linetab_cleanup): Remove.
5172
5173 2019-03-06  Pedro Alves  <palves@redhat.com>
5174
5175         * linux-fork.c (fork_info::clobber_regs): Delete.
5176         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
5177         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
5178         comment.  Adjust.
5179         (scoped_switch_fork_info::scoped_switch_fork_info)
5180         (checkpoint_command, linux_fork_context): Adjust
5181         fork_save_infrun_state calls.
5182
5183 2019-03-06  Pedro Alves  <palves@redhat.com>
5184
5185         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
5186         (inf_has_multiple_threads): Return 'bool' and rewrite using
5187         inferior_info::threads().
5188
5189 2019-03-06  Pedro Alves  <palves@redhat.com>
5190
5191         * linux-fork.c: Include <list>.
5192         (fork_list): Now a std::list instance.
5193         (fork_info): Add ctor, dtor, and in-class initialize all fields.
5194         (forks_exist_p, find_last_fork): Adjust.
5195         (new_fork): Delete.
5196         (one_fork_p): New.
5197         (add_fork): Adjust.
5198         (free_fork): Delete, folded into fork_info::~fork_info().
5199         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
5200         Adjust.
5201         (init_fork_list): Delete.
5202         (linux_fork_killall, linux_fork_mourn_inferior)
5203         (linux_fork_detach, info_checkpoints_command): Adjust.
5204         (_initialize_linux_fork): No longer call init_fork_list.
5205
5206 2019-03-06  Pedro Alves  <palves@redhat.com>
5207
5208         * linux-fork.c (new_fork): New, split out of ...
5209         (add_fork): ... this.  Return void.  Move "first fork" special
5210         case from here, to ...
5211         (checkpoint_command): ... here.
5212         * linux-linux.h (add_fork): Return void.
5213
5214 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5215
5216         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
5217
5218 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5219             Chris January  <chris.january@arm.com>
5220             David Lecomber  <david.lecomber@arm.com>
5221
5222         * f-exp.y: New token, UNOP_INTRINSIC.
5223         (exp): New pattern using UNOP_INTRINSIC token.
5224         (f77_keywords): Add 'abs' keyword.
5225         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
5226         (value_from_host_double): New function.
5227         (evaluate_subexp_f): Support UNOP_ABS.
5228
5229 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5230
5231         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
5232         types.
5233
5234 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5235
5236         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
5237         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
5238         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
5239
5240 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5241
5242         * f-exp.y (convert_to_kind_type): Handle more type kinds.
5243
5244 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5245             Chris January  <chris.january@arm.com>
5246
5247         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
5248         * f-exp.y: Define 'KIND' token.
5249         (exp): New pattern for KIND expressions.
5250         (ptype): Handle types with a kind extension.
5251         (direct_abs_decl): Extend to spot kind extensions.
5252         (f77_keywords): Add 'kind' to the list.
5253         (push_kind_type): New function.
5254         (convert_to_kind_type): New function.
5255         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
5256         * parse.c (operator_length_standard): Likewise.
5257         * parser-defs.h (enum type_pieces): Add tp_kind.
5258         * std-operator.def: Add UNOP_KIND.
5259
5260 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5261
5262         * f-exp.y (f_parse): Set yydebug.
5263
5264 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5265
5266         * f-lang.c (evaluate_subexp_f): New function.
5267         (exp_descriptor_f): New global.
5268         (f_language_defn): Use exp_descriptor_f instead of
5269         exp_descriptor_standard.
5270
5271 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5272
5273         * f-exp.y (struct token): Add comments.
5274         (dot_ops): Remove uppercase versions and the end marker.
5275         (f77_keywords): Likewise.
5276         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
5277         entries in the dot_ops array are case insensitive, and use
5278         strncasecmp to compare strings.  Also some whitespace cleanup in
5279         this area.  Similar for the f77_keywords array, except entries in
5280         this list might be case sensitive.
5281
5282 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5283
5284         * f-exp.y (struct f77_boolean_val): Add comments.
5285         (boolean_values): Remove uppercase versions, and end marker.
5286         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
5287         and use strncasecmp to achieve case insensitivity.  Additionally,
5288         perform whitespace cleanup around this code.
5289
5290 2019-03-06  Tom Tromey  <tromey@adacore.com>
5291
5292         * remote-sim.c (gdbsim_target_open): Use result of
5293         gdb_argv::release.
5294
5295 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
5296         Dirk Schubert  <dirk.schubert@arm.com>
5297         Chris January  <chris.january@arm.com>
5298
5299         * eval.c (evaluate_subexp_standard): Call Fortran argument
5300         wrapping logic.
5301         * f-lang.c (struct value): A value which can be passed into a
5302         Fortran function call.
5303         (fortran_argument_convert): Wrap Fortran arguments in a pointer
5304         where appropriate.
5305         (struct type): Value ready for a Fortran function call.
5306         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
5307         is needed.
5308         * f-lang.h (fortran_argument_convert): Declaration.
5309         (fortran_preserve_arg_pointer): Declaration.
5310         * infcall.c (value_arg_coerce): Call Fortran argument logic.
5311
5312 2019-03-05  Tom Tromey  <tromey@adacore.com>
5313
5314         * python/py-prettyprint.c (print_string_repr): Remove #if.
5315         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
5316
5317 2019-03-05  Tom Tromey  <tromey@adacore.com>
5318
5319         * target.c (the_dummy_target): Move later.  Change type to
5320         "dummy_target".
5321         (initialize_targets): Don't initialize the_dummy_target.
5322
5323 2019-03-05  Tom Tromey  <tromey@adacore.com>
5324
5325         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
5326         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
5327
5328 2019-03-05  Tom Tromey  <tromey@adacore.com>
5329
5330         * windows-nat.c (windows_nat_target::attach)
5331         (windows_nat_target::detach): Don't call gdb_flush.
5332         * valprint.c (generic_val_print, val_print, val_print_string):
5333         Don't call gdb_flush.
5334         * utils.c (defaulted_query): Don't call gdb_flush.
5335         * typeprint.c (print_type_scalar): Don't call gdb_flush.
5336         * target.c (target_announce_detach): Don't call gdb_flush.
5337         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
5338         * remote.c (extended_remote_target::attach): Don't call
5339         gdb_flush.
5340         * procfs.c (procfs_target::detach): Don't call gdb_flush.
5341         * printcmd.c (do_examine): Don't call gdb_flush.
5342         (info_display_command): Don't call gdb_flush.
5343         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
5344         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
5345         * memattr.c (info_mem_command): Don't call gdb_flush.
5346         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
5347         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
5348         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
5349         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
5350         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
5351         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
5352         (gnu_nat_target::detach): Don't call gdb_flush.
5353         * f-valprint.c (f_val_print): Don't call gdb_flush.
5354         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
5355         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
5356         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
5357         gdb_flush.
5358         * c-valprint.c (c_val_print): Don't call gdb_flush.
5359         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
5360
5361 2019-03-05  Tom Tromey  <tromey@adacore.com>
5362
5363         * varobj.c (update_dynamic_varobj_children): Update.
5364         (install_default_visualizer): Use reset, not release.
5365         * value.c (set_internalvar): Update.
5366         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
5367         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
5368         ATTRIBUTE_UNUSED_RESULT.
5369
5370 2019-03-05  Tom Tromey  <tromey@adacore.com>
5371
5372         * remote.c (class scoped_remote_fd) <release>: Add
5373         ATTRIBUTE_UNUSED_RESULT.
5374
5375 2019-03-05  Tom Tromey  <tromey@adacore.com>
5376
5377         * macroexp.c (struct macro_buffer) <release>: Add
5378         ATTRIBUTE_UNUSED_RESULT.
5379
5380 2019-03-05  Tom Tromey  <tromey@adacore.com>
5381
5382         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
5383         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
5384         ATTRIBUTE_UNUSED_RESULT.
5385
5386 2019-03-05  Tom Tromey  <tromey@adacore.com>
5387
5388         * common/scoped_fd.h (class scoped_fd) <release>: Add
5389         ATTRIBUTE_UNUSED_RESULT.
5390
5391 2019-03-05  Tom Tromey  <tromey@adacore.com>
5392
5393         * parser-defs.h (struct parser_state) <release>: Add
5394         ATTRIBUTE_UNUSED_RESULT.
5395
5396 2019-03-05  Tom Tromey  <tromey@adacore.com>
5397
5398         * utils.h (class gdb_argv) <release>: Add
5399         ATTRIBUTE_UNUSED_RESULT.
5400         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
5401
5402 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
5403
5404         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
5405         for-loop range, to avoid compiler warnings.
5406
5407         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
5408         avoid compiler warnings about unused variables.
5409
5410         * NEWS: Mention end of support for native debugging on MS-Windows
5411         before XP.
5412
5413         PR gdb/24292
5414         * common/netstuff.c:
5415         * gdbserver/gdbreplay.c
5416         * gdbserver/remote-utils.c:
5417         * ser-tcp.c:
5418         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
5419         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
5420         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
5421         'getaddrinfo' and 'freeaddrinfo' were not available before
5422         Windows XP, and mingw.org's MinGW headers by default define
5423         _WIN32_WINNT to 0x500.
5424
5425 2019-03-01  Gary Benson <gbenson@redhat.com>
5426
5427         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
5428
5429 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
5430             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
5431
5432         PR gdb/8527
5433         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
5434         set_sigint_trap, clear_sigint_trap.
5435
5436 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5437
5438         * target.c (target_detach): Clear the regcache and the
5439         frame cache.
5440
5441 2019-02-27  Pedro Alves  <palves@redhat.com>
5442
5443         * utils.c (set_screen_size): When we cap the height/width sizes,
5444         tweak the corresponding command variable to show "unlimited":
5445
5446 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
5447             Pedro Alves  <palves@redhat.com>
5448
5449         * utils.c (set_screen_size): Reduce "infinite" rows and columns
5450         before calling rl_set_screen_size.
5451
5452 2019-02-27  Tom Tromey  <tromey@adacore.com>
5453
5454         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
5455         define.
5456         * python/py-value.c: Remove Python 2.4 workaround.
5457         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
5458         workaround.
5459         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
5460         Python 2.4 workaround.
5461         * python/python-internal.h: Remove Python 2.4 comment.
5462         (Py_ssize_t): Don't define.
5463         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
5464         (gdb_Py_DECREF): Remove Python 2.4 workaround.
5465         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
5466         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
5467         * python/python.c (do_start_initialization): Remove Python 2.4
5468         workaround.
5469         * python/py-prettyprint.c (class dummy_python_frame): Remove.
5470         (print_children): Remove Python 2.4 workaround.
5471         * python/py-inferior.c (buffer_procs): Remove Python 2.4
5472         workaround.
5473         (CHARBUFFERPROC_NAME): Remove.
5474         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
5475         Python 2.4 workaround.
5476
5477 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5478
5479         * NEWS: Note minimum Python version.
5480
5481 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5482
5483         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
5484         code from these functions.  Remove corresponding ifdefs.  Use
5485         Py_buffer_up instead of explicit calls to PyBuffer_Release.
5486         Remove gotos and target of gotos.
5487         (infpy_search_memory): Likewise.
5488
5489 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5490
5491         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
5492         (hppa_gdbarch_init): Don't register deleted functions with
5493         gdbarch.
5494
5495 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5496
5497         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
5498         (h8300_unwind_sp): Delete.
5499         (h8300_dummy_id): Delete.
5500         (h8300_gdbarch_init): Don't register deleted functions with
5501         gdbarch.
5502
5503 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5504
5505         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
5506         (ft32_unwind_pc): Delete.
5507         (ft32_unwind_sp): Delete.
5508         (ft32_gdbarch_init): Don't register deleted functions with
5509         gdbarch.
5510
5511 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5512
5513         * gdb/frv-tdep.c (frv_dummy_id): Delete.
5514         (frv_unwind_pc): Delete.
5515         (frv_unwind_sp): Delete.
5516         (frv_gdbarch_init): Don't register deleted functions with
5517         gdbarch.
5518
5519 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5520
5521         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
5522         (riscv_unwind_pc): Delete.
5523         (riscv_unwind_sp): Delete.
5524         (riscv_gdbarch_init): Don't register deleted functions with
5525         gdbarch.
5526
5527 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5528
5529         * gdb/csky-tdep.c (csky_dummy_id): Delete.
5530         (csky_unwind_pc): Delete.
5531         (csky_unwind_sp): Delete.
5532         (csky_gdbarch_init): Don't register deleted functions with
5533         gdbarch.
5534
5535 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5536
5537         * gdb/cris-tdep.c (cris_dummy_id): Delete.
5538         (cris_unwind_pc): Delete.
5539         (cris_unwind_sp): Delete.
5540         (cris_gdbarch_init): Don't register deleted functions with
5541         gdbarch.
5542
5543 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5544
5545         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
5546         (bfin_unwind_pc): Delete.
5547         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
5548
5549 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5550
5551         * gdb/arm-tdep.c (arm_dummy_id): Delete.
5552         (arm_unwind_pc): Delete.
5553         (arm_unwind_sp): Delete.
5554         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
5555
5556 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5557
5558         * gdb/arc-tdep.c (arc_dummy_id): Delete.
5559         (arc_unwind_pc): Delete.
5560         (arc_unwind_sp): Delete.
5561         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
5562
5563 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5564
5565         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
5566         (alpha_unwind_pc): Delete.
5567         (alpha_gdbarch_init): Don't register deleted functions with
5568         gdbarch.
5569
5570 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5571
5572         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
5573         (aarch64_unwind_pc): Delete.
5574         (aarch64_unwind_sp): Delete.
5575         (aarch64_gdbarch_init): Don't register deleted functions with
5576         gdbarch.
5577
5578 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5579
5580         * gdbtypes.c (type_align): Don't consider static members when
5581         computing structure alignment.
5582
5583 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5584
5585         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
5586         return 0 for other types.
5587         * arch-utils.c (default_type_align): Always return 0.
5588         * gdbarch.h: Regenerate.
5589         * gdbarch.sh (type_align): Extend comment.
5590         * gdbtypes.c (type_align): Add additional comments, always call
5591         gdbarch_type_align before applying the default rules.
5592         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
5593         generic code will then apply a suitable default.
5594         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
5595         types, return 0 for other types.
5596
5597 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5598
5599         * NEWS: Create a new section for the next release branch.
5600         Rename the section of the current branch, now that it has
5601         been cut.
5602
5603 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5604
5605         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
5606         * version.in: Bump version to 8.3.50.DATE-git.
5607
5608 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
5609
5610         * aix-thread.c (ptid_cmp): Remove unused variable.
5611         (get_signaled_thread): Likewise.
5612         (store_regs_user_thread): Likewise.
5613         (store_regs_kernel_thread): Likewise.
5614         (fetch_regs_kernel_thread): Remove shadowed variable.
5615
5616 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5617
5618         * features/riscv/32bit-cpu.xml: Add register numbers.
5619         * features/riscv/32bit-fpu.c: Regenerate.
5620         * features/riscv/32bit-fpu.xml: Add register numbers.
5621         * features/riscv/64bit-cpu.xml: Add register numbers.
5622         * features/riscv/64bit-fpu.c: Regenerate.
5623         * features/riscv/64bit-fpu.xml: Add register numbers.
5624
5625 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
5626
5627         * NEWS: Mention two argument form of gdb.Value constructor.
5628         * python/py-value.c (convert_buffer_and_type_to_value): New
5629         function.
5630         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
5631         Add support for handling an optional second argument.  Call
5632         convert_buffer_and_type_to_value as appropriate.
5633         * python/python-internal.h (Py_buffer_deleter): New struct.
5634         (Py_buffer_up): New typedef.
5635
5636 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
5637
5638         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
5639         instead of releasing ownership.
5640
5641 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
5642
5643         * dwarf2read.c (open_and_init_dwp_file): Call
5644         elf_numsections instead of bfd_count_sections to initialize
5645         dwp_file->num_sections.
5646
5647 2019-02-25  Tom Tromey  <tromey@adacore.com>
5648
5649         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
5650
5651 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5652
5653         * gcore.in: Add '--readnever' option when invoking GDB.
5654
5655 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5656
5657         * MAINTAINERS: Update my email address.
5658
5659 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5660
5661         * build-id.c (build_id_to_debug_bfd_1): New function.
5662         (build_id_to_debug_bfd): Look for separate debug file in
5663         sysroot.
5664
5665 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5666
5667         * gdbarch.sh: Update the copyright year range that is placed into
5668         generated files.
5669
5670 2019-02-22  Keith Seitz  <keiths@redhat.com>
5671
5672         PR symtab/23853
5673         * linespec.c (create_sals_line_offset): Search for the default
5674         symtab's filename instead of its fullname.
5675
5676 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5677
5678         * NEWS: Update style defaults.
5679
5680 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5681
5682         * main.c (captured_main_1): Disable styling in batch mode.
5683
5684 2019-02-20  Tom Tromey  <tom@tromey.com>
5685
5686         * symtab.c (symtab_symbol_info): Fix typos.
5687
5688 2019-02-20  Tom Tromey  <tromey@adacore.com>
5689
5690         * findcmd.c (_initialize_mem_search): Use upper case for
5691         metasyntactic variables.
5692
5693 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
5694
5695         * aarch64-tdep.c (aarch64_add_reggroups): New function.
5696         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
5697
5698 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
5699
5700         * top.h (source_file_name): Change to std::string.
5701         * top.c (source_file_name): Likewise.
5702         (command_line_input): Adjust.
5703         * cli/cli-script.c (script_from_file): Adjust.
5704
5705 2019-02-19  Tom Tromey  <tromey@adacore.com>
5706
5707         * ravenscar-thread.c
5708         (ravenscar_thread_target::update_thread_list): Don't call
5709         ada_build_task_list.
5710         * ada-lang.h (ada_build_task_list): Don't declare.
5711         * ada-tasks.c (struct ada_tasks_inferior_data)
5712         <task_list_valid_p>: Now bool.
5713         (read_known_tasks, ada_task_list_changed)
5714         (ada_tasks_invalidate_inferior_data): Update.
5715         (read_known_tasks_array): Return bool.
5716         (read_known_tasks_list): Likewise.
5717         (read_known_tasks): Return void.
5718         (ada_build_task_list): Now static.
5719
5720 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5721
5722         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
5723         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
5724
5725 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5726
5727         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
5728         variant for ada_tasks_pspace_data_handle and
5729         ada_tasks_inferior_data_handle.
5730         (ada_tasks_pspace_data_cleanup): New function.
5731         (ada_tasks_inferior_data_cleanup): New function.
5732
5733 2019-02-17  Tom Tromey  <tom@tromey.com>
5734
5735         * macrotab.h (macro_source_fullname): Return a std::string.
5736         * macrotab.c (macro_include, check_for_redefinition)
5737         (macro_undef, macro_lookup_definition, foreach_macro)
5738         (foreach_macro_in_scope): Update.
5739         (macro_source_fullname): Return a std::string.
5740         * macrocmd.c (show_pp_source_pos): Update.
5741
5742 2019-02-17  Tom Tromey  <tom@tromey.com>
5743
5744         * macrocmd.c (show_pp_source_pos): Style the file names.
5745
5746 2019-02-17  Tom Tromey  <tom@tromey.com>
5747
5748         PR tui/24197:
5749         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
5750
5751 2019-02-17  Tom Tromey  <tom@tromey.com>
5752
5753         * ada-lang.c (user_select_syms): Use filtered printing.
5754         * utils.c (wrap_style): New global.
5755         (desired_style): Remove.
5756         (emit_style_escape): Add stream parameter.
5757         (set_output_style, reset_terminal_style, prompt_for_continue):
5758         Update.
5759         (flush_wrap_buffer): Only flush gdb_stdout.
5760         (wrap_here): Set wrap_style.
5761         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
5762         treat escape sequences as a character.  Change when wrap buffer is
5763         flushed.
5764         (fputs_styled): Do not set the output style when the default is
5765         requested.
5766         * ui-style.h (struct ui_file_style) <is_default>: New method.
5767         * source.c (print_source_lines_base): Emit escape sequences in one
5768         piece.
5769
5770 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5771
5772         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
5773         integers and enumeration types.
5774
5775 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5776
5777         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
5778         instead of lookup_symbol_in_language
5779         (do_exact_match): New function.
5780         (ada_get_symbol_name_matcher): Return do_exact_match when
5781         doing a verbatim match.
5782
5783 2019-02-15  Tom Tromey  <tromey@adacore.com>
5784
5785         * ravenscar-thread.c (ravenscar_thread_target::resume)
5786         (ravenscar_thread_target::wait): Special case wildcard requests.
5787
5788 2019-02-15  Tom Tromey  <tromey@adacore.com>
5789
5790         * ravenscar-thread.c (base_ptid): Remove.
5791         (struct ravenscar_thread_target) <close>: New method.
5792         <m_base_ptid>: New member.
5793         <update_inferior_ptid, active_task, task_is_currently_active,
5794         runtime_initialized>: Declare methods.
5795         <ravenscar_thread_target>: Add constructor.
5796         (ravenscar_thread_target::task_is_currently_active)
5797         (ravenscar_thread_target::update_inferior_ptid)
5798         (ravenscar_runtime_initialized): Rename.  Now methods.
5799         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
5800         (ravenscar_thread_target::update_thread_list): Update.
5801         (ravenscar_thread_target::active_task): Now method.
5802         (ravenscar_thread_target::store_registers)
5803         (ravenscar_thread_target::prepare_to_store)
5804         (ravenscar_thread_target::prepare_to_store)
5805         (ravenscar_thread_target::mourn_inferior): Update.
5806         (ravenscar_inferior_created): Use "new" to create target.
5807         (ravenscar_thread_target::get_ada_task_ptid): Update.
5808         (_initialize_ravenscar): Don't initialize base_ptid.
5809         (ravenscar_ops): Remove global.
5810
5811 2019-02-15  Tom Tromey  <tromey@adacore.com>
5812
5813         * target.h (push_target): Declare new overload.
5814         * target.c (push_target): New overload, taking an rvalue reference.
5815         * remote.c (remote_target::open_1): Use push_target overload.
5816         * corelow.c (core_target_open): Use push_target overload.
5817
5818 2019-02-15  Tom Tromey  <tromey@adacore.com>
5819
5820         * ravenscar-thread.c (is_ravenscar_task)
5821         (ravenscar_task_is_currently_active): Return bool.
5822         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
5823         (_initialize_ravenscar): Remove "(void)".
5824         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
5825         Return bool.
5826
5827 2019-02-15  Tom Tromey  <tromey@adacore.com>
5828
5829         * ravenscar-thread.c (ravenscar_runtime_initializer)
5830         (has_ravenscar_runtime, get_running_thread_id)
5831         (ravenscar_thread_target::resume): Fix indentation.
5832
5833 2019-02-15  Tom Tromey  <tromey@adacore.com>
5834
5835         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
5836         from ravenscar_arch_ops.
5837         (sparc_ravenscar_ops::fetch_registers)
5838         (sparc_ravenscar_ops::store_registers): Now methods.
5839         (sparc_ravenscar_prepare_to_store): Remove.
5840         (sparc_ravenscar_ops): Redefine.
5841         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
5842         methods and destructor.  Remove members.
5843         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
5844         (ravenscar_thread_target::store_registers)
5845         (ravenscar_thread_target::prepare_to_store): Update.
5846         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
5847         Remove.
5848         (struct ppc_ravenscar_powerpc_ops): Derive from
5849         ravenscar_arch_ops.
5850         (ppc_ravenscar_powerpc_ops::fetch_registers)
5851         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
5852         (ppc_ravenscar_powerpc_ops): Redefine.
5853         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
5854         (ppc_ravenscar_e500_ops::fetch_registers)
5855         (ppc_ravenscar_e500_ops::store_registers): Now methods.
5856         (ppc_ravenscar_e500_ops): Redefine.
5857         * aarch64-ravenscar-thread.c
5858         (aarch64_ravenscar_generic_prepare_to_store): Remove.
5859         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
5860         (aarch64_ravenscar_fetch_registers)
5861         (aarch64_ravenscar_store_registers): Now methods.
5862         (aarch64_ravenscar_ops): Redefine.
5863
5864 2019-02-15  Tom Tromey  <tromey@adacore.com>
5865
5866         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
5867         (ravenscar_thread_target::stopped_by_hw_breakpoint)
5868         (ravenscar_thread_target::stopped_by_watchpoint)
5869         (ravenscar_thread_target::stopped_data_address)
5870         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
5871
5872 2019-02-15  Tom Tromey  <tromey@adacore.com>
5873
5874         * ravenscar-thread.c: Fix some typos.
5875
5876 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5877             Tom Tromey  <tromey@adacore.com>
5878
5879         * ada-lang.c (ada_exception_sal): Change addr_string to a
5880         std::string.
5881         (create_ada_exception_catchpoint): Update.
5882
5883 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5884             Tom Tromey  <tromey@adacore.com>
5885
5886         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
5887         (bp_location_ops): Remove.
5888         (base_breakpoint_allocate_location): Update.
5889         (free_bp_location): Update.
5890         * ada-lang.c (class ada_catchpoint_location)
5891         <ada_catchpoint_location>: Remove ops parameter.
5892         (ada_catchpoint_location_dtor): Remove.
5893         (ada_catchpoint_location_ops): Remove.
5894         (allocate_location_exception): Update.
5895         * breakpoint.h (struct bp_location_ops): Remove.
5896         (class bp_location) <bp_location>: Remove bp_location_ops
5897         parameter.
5898         <~bp_location>: Add destructor.
5899         <ops>: Remove.
5900
5901 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5902             Pedro Alves  <palves@redhat.com>
5903
5904         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
5905         'PATH_MAX'.
5906
5907 2019-02-14  David Michael  <fedora.dm0@gmail.com>
5908             Samuel Thibault  <samuel.thibault@gnu.org>
5909             Thomas Schwinge  <thomas@codesourcery.com>
5910
5911         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
5912         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
5913
5914 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5915
5916         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
5917         (check_empty): Use "const char *".
5918
5919         * gnu-nat.c (gnu_nat_target::detach): Instead of
5920         'detach_inferior (pid)' call
5921         'detach_inferior (find_inferior_pid (pid))'.
5922
5923         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
5924         'nat/fork-inferior.o'.
5925         * gnu-nat.c: #include "nat/fork-inferior.h".
5926
5927         * gnu-nat.c (gnu_nat_target::detach): Instead of
5928         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
5929         * gnu-nat.h: #include "inf-child.h".
5930         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
5931         'i386_gnu_nat_target::fetch_registers'.
5932         (gnu_store_registers): Rename/move to
5933         'i386_gnu_nat_target::store_registers'.
5934
5935         * config/i386/nm-i386gnu.h: Don't "#include" any files.
5936         * gnu-nat.h (mach_thread_info): New function.
5937         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
5938
5939         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
5940
5941 2019-02-14  Frederic Konrad  <konrad@adacore.com>
5942
5943         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
5944
5945 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
5946
5947         * windows-nat.c (windows_add_thread): Add new parameter
5948         "main_thread_p" with default value set to false.  Update
5949         function documentation as well as all callers.
5950         (windows_delete_thread): Likewise.
5951         (fake_create_process): Update call to windows_add_thread.
5952         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
5953         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
5954         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
5955         call to windows_delete_thread.
5956
5957 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
5958
5959         * MAINTAINERS: Add Andrew Burgess as global maintainer.
5960
5961 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5962
5963         * symfile.c (find_separate_debug_file): Use canonical path of
5964         sysroot with child_path instead of gdb_sysroot if it is valid.
5965
5966 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5967
5968         * symfile.c (find_separate_debug_file): Use child_path to
5969         determine if an object file is under a sysroot.
5970
5971 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5972
5973         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5974         unittests/child-path-selftests.c.
5975         * common/pathstuff.c (child_path): New function.
5976         * common/pathstuff.h (child_path): New prototype.
5977         * unittests/child-path-selftests.c: New file.
5978
5979 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5980
5981         * symfile.c (find_separate_debug_file): Look for separate debug
5982         files in debug directories under the sysroot.
5983
5984 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5985
5986         * symtab.h (struct minimal_symbol data_p): New const method.
5987         (struct minimal_symbol text_p): Likewise.
5988         * symtab.c (output_source_filename): Use file name style
5989         to print file name.
5990         (print_symbol_info): Likewise.
5991         (print_msymbol_info): Use address style to print addresses.
5992         Use function name style to print executable text symbols.
5993         (expand_symtab_containing_pc): Use data_p.
5994         (find_pc_sect_compunit_symtab): Likewise.
5995
5996 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5997
5998         * breakpoint.c (describe_other_breakpoints): Use address style
5999         to print addresses.
6000         (say_where): Likewise.
6001
6002 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6003
6004         * ada-typeprint.c (print_func_type): Print function name
6005         style to print function name.
6006         * c-typeprint.c (c_print_type_1): Likewise.
6007
6008 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
6009
6010         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
6011         for execve.
6012
6013 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6014
6015         * c-exp.y (direct_abs_decl): Use emplace_back to record the
6016         type_stack.
6017
6018 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
6019
6020         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
6021         TYPE_CODE_REF types.
6022
6023 2019-02-08  Jim Wilson  <jimw@sifive.com>
6024
6025         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
6026         (riscv_linux_fregset): New.
6027         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
6028
6029 2019-02-07  Tom Tromey  <tom@tromey.com>
6030
6031         * thread.c (thread_cancel_execution_command): Update.
6032         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
6033         methods.
6034         (struct thread_fsm_ops): Remove.
6035         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
6036         (thread_fsm_should_stop, thread_fsm_return_value)
6037         (thread_fsm_set_finished, thread_fsm_finished_p)
6038         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
6039         Don't declare.
6040         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
6041         * infrun.c (clear_proceed_status_thread)
6042         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
6043         (print_stop_event): Update.
6044         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
6045         Add constructor.
6046         (step_command_fsm_ops): Remove.
6047         (new_step_command_fsm): Remove.
6048         (step_1): Update.
6049         (step_command_fsm::should_stop): Rename from
6050         step_command_fsm_should_stop.
6051         (step_command_fsm::clean_up): Rename from
6052         step_command_fsm_clean_up.
6053         (step_command_fsm::do_async_reply_reason): Rename from
6054         step_command_fsm_async_reply_reason.
6055         (struct until_next_fsm): Inherit from thread_fsm.  Add
6056         constructor.
6057         (until_next_fsm_ops): Remove.
6058         (new_until_next_fsm): Remove.
6059         (until_next_fsm::should_stop): Rename from
6060         until_next_fsm_should_stop.
6061         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
6062         (until_next_fsm::do_async_reply_reason): Rename from
6063         until_next_fsm_async_reply_reason.
6064         (struct finish_command_fsm): Inherit from thread_fsm.  Add
6065         constructor.  Change type of breakpoint.
6066         (finish_command_fsm_ops): Remove.
6067         (new_finish_command_fsm): Remove.
6068         (finish_command_fsm::should_stop): Rename from
6069         finish_command_fsm_should_stop.
6070         (finish_command_fsm::clean_up): Rename from
6071         finish_command_fsm_clean_up.
6072         (finish_command_fsm::return_value): Rename from
6073         finish_command_fsm_return_value.
6074         (finish_command_fsm::do_async_reply_reason): Rename from
6075         finish_command_fsm_async_reply_reason.
6076         (finish_command): Update.
6077         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
6078         Add constructor.
6079         (call_thread_fsm_ops): Remove.
6080         (call_thread_fsm::call_thread_fsm): Rename from
6081         new_call_thread_fsm.
6082         (call_thread_fsm::should_stop): Rename from
6083         call_thread_fsm_should_stop.
6084         (call_thread_fsm::should_notify_stop): Rename from
6085         call_thread_fsm_should_notify_stop.
6086         (run_inferior_call, call_function_by_hand_dummy): Update.
6087         * cli/cli-interp.c (should_print_stop_to_console): Update.
6088         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
6089         Add constructor.  Change type of location_breakpoint,
6090         caller_breakpoint.
6091         (until_break_fsm_ops): Remove.
6092         (new_until_break_fsm): Remove.
6093         (until_break_fsm::should_stop): Rename from
6094         until_break_fsm_should_stop.
6095         (until_break_fsm::clean_up): Rename from
6096         until_break_fsm_clean_up.
6097         (until_break_fsm::do_async_reply_reason): Rename from
6098         until_break_fsm_async_reply_reason.
6099         (until_break_command): Update.
6100         * thread-fsm.c: Remove.
6101         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
6102
6103 2019-02-07  Tom Tromey  <tom@tromey.com>
6104
6105         * yy-remap.h: Add include guard.
6106         * xtensa-tdep.h: Add include guard.
6107         * xcoffread.h: Rename include guard.
6108         * varobj-iter.h: Add include guard.
6109         * tui/tui.h: Rename include guard.
6110         * tui/tui-winsource.h: Rename include guard.
6111         * tui/tui-wingeneral.h: Rename include guard.
6112         * tui/tui-windata.h: Rename include guard.
6113         * tui/tui-win.h: Rename include guard.
6114         * tui/tui-stack.h: Rename include guard.
6115         * tui/tui-source.h: Rename include guard.
6116         * tui/tui-regs.h: Rename include guard.
6117         * tui/tui-out.h: Rename include guard.
6118         * tui/tui-layout.h: Rename include guard.
6119         * tui/tui-io.h: Rename include guard.
6120         * tui/tui-hooks.h: Rename include guard.
6121         * tui/tui-file.h: Rename include guard.
6122         * tui/tui-disasm.h: Rename include guard.
6123         * tui/tui-data.h: Rename include guard.
6124         * tui/tui-command.h: Rename include guard.
6125         * tic6x-tdep.h: Add include guard.
6126         * target/waitstatus.h: Rename include guard.
6127         * target/wait.h: Rename include guard.
6128         * target/target.h: Rename include guard.
6129         * target/resume.h: Rename include guard.
6130         * target-float.h: Rename include guard.
6131         * stabsread.h: Add include guard.
6132         * rs6000-tdep.h: Add include guard.
6133         * riscv-fbsd-tdep.h: Add include guard.
6134         * regformats/regdef.h: Rename include guard.
6135         * record.h: Rename include guard.
6136         * python/python.h: Rename include guard.
6137         * python/python-internal.h: Rename include guard.
6138         * python/py-stopevent.h: Rename include guard.
6139         * python/py-ref.h: Rename include guard.
6140         * python/py-record.h: Rename include guard.
6141         * python/py-record-full.h: Rename include guard.
6142         * python/py-record-btrace.h: Rename include guard.
6143         * python/py-instruction.h: Rename include guard.
6144         * python/py-events.h: Rename include guard.
6145         * python/py-event.h: Rename include guard.
6146         * procfs.h: Add include guard.
6147         * proc-utils.h: Add include guard.
6148         * p-lang.h: Add include guard.
6149         * or1k-tdep.h: Rename include guard.
6150         * observable.h: Rename include guard.
6151         * nto-tdep.h: Rename include guard.
6152         * nat/x86-linux.h: Rename include guard.
6153         * nat/x86-linux-dregs.h: Rename include guard.
6154         * nat/x86-gcc-cpuid.h: Add include guard.
6155         * nat/x86-dregs.h: Rename include guard.
6156         * nat/x86-cpuid.h: Rename include guard.
6157         * nat/ppc-linux.h: Rename include guard.
6158         * nat/mips-linux-watch.h: Rename include guard.
6159         * nat/linux-waitpid.h: Rename include guard.
6160         * nat/linux-ptrace.h: Rename include guard.
6161         * nat/linux-procfs.h: Rename include guard.
6162         * nat/linux-osdata.h: Rename include guard.
6163         * nat/linux-nat.h: Rename include guard.
6164         * nat/linux-namespaces.h: Rename include guard.
6165         * nat/linux-btrace.h: Rename include guard.
6166         * nat/glibc_thread_db.h: Rename include guard.
6167         * nat/gdb_thread_db.h: Rename include guard.
6168         * nat/gdb_ptrace.h: Rename include guard.
6169         * nat/fork-inferior.h: Rename include guard.
6170         * nat/amd64-linux-siginfo.h: Rename include guard.
6171         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
6172         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
6173         * nat/aarch64-linux.h: Rename include guard.
6174         * nat/aarch64-linux-hw-point.h: Rename include guard.
6175         * mn10300-tdep.h: Add include guard.
6176         * mips-linux-tdep.h: Add include guard.
6177         * mi/mi-parse.h: Rename include guard.
6178         * mi/mi-out.h: Rename include guard.
6179         * mi/mi-main.h: Rename include guard.
6180         * mi/mi-interp.h: Rename include guard.
6181         * mi/mi-getopt.h: Rename include guard.
6182         * mi/mi-console.h: Rename include guard.
6183         * mi/mi-common.h: Rename include guard.
6184         * mi/mi-cmds.h: Rename include guard.
6185         * mi/mi-cmd-break.h: Rename include guard.
6186         * m2-lang.h: Add include guard.
6187         * location.h: Rename include guard.
6188         * linux-record.h: Rename include guard.
6189         * linux-nat.h: Add include guard.
6190         * linux-fork.h: Add include guard.
6191         * i386-darwin-tdep.h: Rename include guard.
6192         * hppa-linux-offsets.h: Add include guard.
6193         * guile/guile.h: Rename include guard.
6194         * guile/guile-internal.h: Rename include guard.
6195         * gnu-nat.h: Rename include guard.
6196         * gdb-stabs.h: Rename include guard.
6197         * frv-tdep.h: Add include guard.
6198         * f-lang.h: Add include guard.
6199         * event-loop.h: Add include guard.
6200         * darwin-nat.h: Rename include guard.
6201         * cp-abi.h: Rename include guard.
6202         * config/sparc/nm-sol2.h: Rename include guard.
6203         * config/nm-nto.h: Rename include guard.
6204         * config/nm-linux.h: Add include guard.
6205         * config/i386/nm-i386gnu.h: Rename include guard.
6206         * config/djgpp/nl_types.h: Rename include guard.
6207         * config/djgpp/langinfo.h: Rename include guard.
6208         * compile/gcc-cp-plugin.h: Add include guard.
6209         * compile/gcc-c-plugin.h: Add include guard.
6210         * compile/compile.h: Rename include guard.
6211         * compile/compile-object-run.h: Rename include guard.
6212         * compile/compile-object-load.h: Rename include guard.
6213         * compile/compile-internal.h: Rename include guard.
6214         * compile/compile-cplus.h: Rename include guard.
6215         * compile/compile-c.h: Rename include guard.
6216         * common/xml-utils.h: Rename include guard.
6217         * common/x86-xstate.h: Rename include guard.
6218         * common/version.h: Rename include guard.
6219         * common/vec.h: Rename include guard.
6220         * common/tdesc.h: Rename include guard.
6221         * common/selftest.h: Rename include guard.
6222         * common/scoped_restore.h: Rename include guard.
6223         * common/scoped_mmap.h: Rename include guard.
6224         * common/scoped_fd.h: Rename include guard.
6225         * common/safe-iterator.h: Rename include guard.
6226         * common/run-time-clock.h: Rename include guard.
6227         * common/refcounted-object.h: Rename include guard.
6228         * common/queue.h: Rename include guard.
6229         * common/ptid.h: Rename include guard.
6230         * common/print-utils.h: Rename include guard.
6231         * common/preprocessor.h: Rename include guard.
6232         * common/pathstuff.h: Rename include guard.
6233         * common/observable.h: Rename include guard.
6234         * common/netstuff.h: Rename include guard.
6235         * common/job-control.h: Rename include guard.
6236         * common/host-defs.h: Rename include guard.
6237         * common/gdb_wait.h: Rename include guard.
6238         * common/gdb_vecs.h: Rename include guard.
6239         * common/gdb_unlinker.h: Rename include guard.
6240         * common/gdb_unique_ptr.h: Rename include guard.
6241         * common/gdb_tilde_expand.h: Rename include guard.
6242         * common/gdb_sys_time.h: Rename include guard.
6243         * common/gdb_string_view.h: Rename include guard.
6244         * common/gdb_splay_tree.h: Rename include guard.
6245         * common/gdb_setjmp.h: Rename include guard.
6246         * common/gdb_ref_ptr.h: Rename include guard.
6247         * common/gdb_optional.h: Rename include guard.
6248         * common/gdb_locale.h: Rename include guard.
6249         * common/gdb_assert.h: Rename include guard.
6250         * common/filtered-iterator.h: Rename include guard.
6251         * common/filestuff.h: Rename include guard.
6252         * common/fileio.h: Rename include guard.
6253         * common/environ.h: Rename include guard.
6254         * common/common-utils.h: Rename include guard.
6255         * common/common-types.h: Rename include guard.
6256         * common/common-regcache.h: Rename include guard.
6257         * common/common-inferior.h: Rename include guard.
6258         * common/common-gdbthread.h: Rename include guard.
6259         * common/common-exceptions.h: Rename include guard.
6260         * common/common-defs.h: Rename include guard.
6261         * common/common-debug.h: Rename include guard.
6262         * common/cleanups.h: Rename include guard.
6263         * common/buffer.h: Rename include guard.
6264         * common/btrace-common.h: Rename include guard.
6265         * common/break-common.h: Rename include guard.
6266         * cli/cli-utils.h: Rename include guard.
6267         * cli/cli-style.h: Rename include guard.
6268         * cli/cli-setshow.h: Rename include guard.
6269         * cli/cli-script.h: Rename include guard.
6270         * cli/cli-interp.h: Rename include guard.
6271         * cli/cli-decode.h: Rename include guard.
6272         * cli/cli-cmds.h: Rename include guard.
6273         * charset-list.h: Add include guard.
6274         * buildsym-legacy.h: Rename include guard.
6275         * bfin-tdep.h: Add include guard.
6276         * ax.h: Rename include guard.
6277         * arm-linux-tdep.h: Add include guard.
6278         * arm-fbsd-tdep.h: Add include guard.
6279         * arch/xtensa.h: Rename include guard.
6280         * arch/tic6x.h: Add include guard.
6281         * arch/i386.h: Add include guard.
6282         * arch/arm.h: Rename include guard.
6283         * arch/arm-linux.h: Rename include guard.
6284         * arch/arm-get-next-pcs.h: Rename include guard.
6285         * arch/amd64.h: Add include guard.
6286         * arch/aarch64-insn.h: Rename include guard.
6287         * arch-utils.h: Rename include guard.
6288         * annotate.h: Add include guard.
6289         * amd64-darwin-tdep.h: Rename include guard.
6290         * aarch64-linux-tdep.h: Add include guard.
6291         * aarch64-fbsd-tdep.h: Add include guard.
6292         * aarch32-linux-nat.h: Add include guard.
6293
6294 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6295
6296         * macrotab.c (macro_define_internal): New function that
6297         factorizes macro_define_object_internal and macro_define_function
6298         code.
6299         (macro_define_object_internal): Use macro_define_internal.
6300         (macro_define_function): Likewise.
6301
6302 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6303
6304         * macrocmd.c (extract_identifier): Return
6305         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
6306         callers.
6307
6308 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
6309
6310         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
6311
6312 2019-02-05  Tom Tromey  <tom@tromey.com>
6313
6314         * target.c (target_stack::unpush): Move assertion earlier.
6315
6316 2019-01-30  Tom Tromey  <tom@tromey.com>
6317
6318         PR python/23615:
6319         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
6320         (gdbpy_parse_and_eval): Likewise.
6321         * python/python-internal.h (gdbpy_allow_threads): New class.
6322
6323 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
6324
6325         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
6326         (aarch64_fbsd_fpregmap): Move earlier.
6327         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
6328         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6329         instead of individual calls to trad_frame_set_reg_addr.
6330         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
6331         earlier.
6332         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
6333         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6334         instead of individual calls to trad_frame_set_reg_addr.
6335
6336 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
6337
6338         * CONTRIBUTE: Replace contribution list with wiki link.
6339
6340 2019-01-25  Tom Tromey  <tom@tromey.com>
6341
6342         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
6343
6344 2019-01-25  Tom Tromey  <tom@tromey.com>
6345
6346         * xtensa-linux-nat.c: Fix common/ includes.
6347         * xml-support.h: Fix common/ includes.
6348         * xml-support.c: Fix common/ includes.
6349         * x86-linux-nat.c: Fix common/ includes.
6350         * windows-nat.c: Fix common/ includes.
6351         * varobj.h: Fix common/ includes.
6352         * varobj.c: Fix common/ includes.
6353         * value.c: Fix common/ includes.
6354         * valops.c: Fix common/ includes.
6355         * utils.c: Fix common/ includes.
6356         * unittests/xml-utils-selftests.c: Fix common/ includes.
6357         * unittests/utils-selftests.c: Fix common/ includes.
6358         * unittests/unpack-selftests.c: Fix common/ includes.
6359         * unittests/tracepoint-selftests.c: Fix common/ includes.
6360         * unittests/style-selftests.c: Fix common/ includes.
6361         * unittests/string_view-selftests.c: Fix common/ includes.
6362         * unittests/scoped_restore-selftests.c: Fix common/ includes.
6363         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
6364         * unittests/scoped_fd-selftests.c: Fix common/ includes.
6365         * unittests/rsp-low-selftests.c: Fix common/ includes.
6366         * unittests/parse-connection-spec-selftests.c: Fix common/
6367         includes.
6368         * unittests/optional-selftests.c: Fix common/ includes.
6369         * unittests/offset-type-selftests.c: Fix common/ includes.
6370         * unittests/observable-selftests.c: Fix common/ includes.
6371         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
6372         * unittests/memrange-selftests.c: Fix common/ includes.
6373         * unittests/memory-map-selftests.c: Fix common/ includes.
6374         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
6375         * unittests/function-view-selftests.c: Fix common/ includes.
6376         * unittests/environ-selftests.c: Fix common/ includes.
6377         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
6378         * unittests/common-utils-selftests.c: Fix common/ includes.
6379         * unittests/cli-utils-selftests.c: Fix common/ includes.
6380         * unittests/array-view-selftests.c: Fix common/ includes.
6381         * ui-file.c: Fix common/ includes.
6382         * tui/tui-io.c: Fix common/ includes.
6383         * tracepoint.h: Fix common/ includes.
6384         * tracepoint.c: Fix common/ includes.
6385         * tracefile-tfile.c: Fix common/ includes.
6386         * top.h: Fix common/ includes.
6387         * top.c: Fix common/ includes.
6388         * thread.c: Fix common/ includes.
6389         * target/waitstatus.h: Fix common/ includes.
6390         * target/waitstatus.c: Fix common/ includes.
6391         * target.h: Fix common/ includes.
6392         * target.c: Fix common/ includes.
6393         * target-memory.c: Fix common/ includes.
6394         * target-descriptions.c: Fix common/ includes.
6395         * symtab.h: Fix common/ includes.
6396         * symfile.c: Fix common/ includes.
6397         * stap-probe.c: Fix common/ includes.
6398         * spu-linux-nat.c: Fix common/ includes.
6399         * sparc-nat.c: Fix common/ includes.
6400         * source.c: Fix common/ includes.
6401         * solib.c: Fix common/ includes.
6402         * solib-target.c: Fix common/ includes.
6403         * ser-unix.c: Fix common/ includes.
6404         * ser-tcp.c: Fix common/ includes.
6405         * ser-pipe.c: Fix common/ includes.
6406         * ser-base.c: Fix common/ includes.
6407         * selftest-arch.c: Fix common/ includes.
6408         * s12z-tdep.c: Fix common/ includes.
6409         * rust-exp.y: Fix common/ includes.
6410         * rs6000-aix-tdep.c: Fix common/ includes.
6411         * riscv-tdep.c: Fix common/ includes.
6412         * remote.c: Fix common/ includes.
6413         * remote-notif.h: Fix common/ includes.
6414         * remote-fileio.h: Fix common/ includes.
6415         * remote-fileio.c: Fix common/ includes.
6416         * regcache.h: Fix common/ includes.
6417         * regcache.c: Fix common/ includes.
6418         * record-btrace.c: Fix common/ includes.
6419         * python/python.c: Fix common/ includes.
6420         * python/py-type.c: Fix common/ includes.
6421         * python/py-inferior.c: Fix common/ includes.
6422         * progspace.h: Fix common/ includes.
6423         * producer.c: Fix common/ includes.
6424         * procfs.c: Fix common/ includes.
6425         * proc-api.c: Fix common/ includes.
6426         * printcmd.c: Fix common/ includes.
6427         * ppc-linux-nat.c: Fix common/ includes.
6428         * parser-defs.h: Fix common/ includes.
6429         * osdata.c: Fix common/ includes.
6430         * obsd-nat.c: Fix common/ includes.
6431         * nat/x86-linux.c: Fix common/ includes.
6432         * nat/x86-linux-dregs.c: Fix common/ includes.
6433         * nat/x86-dregs.h: Fix common/ includes.
6434         * nat/x86-dregs.c: Fix common/ includes.
6435         * nat/ppc-linux.c: Fix common/ includes.
6436         * nat/mips-linux-watch.h: Fix common/ includes.
6437         * nat/mips-linux-watch.c: Fix common/ includes.
6438         * nat/linux-waitpid.c: Fix common/ includes.
6439         * nat/linux-ptrace.h: Fix common/ includes.
6440         * nat/linux-ptrace.c: Fix common/ includes.
6441         * nat/linux-procfs.c: Fix common/ includes.
6442         * nat/linux-personality.c: Fix common/ includes.
6443         * nat/linux-osdata.c: Fix common/ includes.
6444         * nat/linux-namespaces.c: Fix common/ includes.
6445         * nat/linux-btrace.h: Fix common/ includes.
6446         * nat/linux-btrace.c: Fix common/ includes.
6447         * nat/fork-inferior.c: Fix common/ includes.
6448         * nat/amd64-linux-siginfo.c: Fix common/ includes.
6449         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
6450         * nat/aarch64-linux.c: Fix common/ includes.
6451         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
6452         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
6453         * namespace.h: Fix common/ includes.
6454         * mips-linux-tdep.c: Fix common/ includes.
6455         * minsyms.c: Fix common/ includes.
6456         * mi/mi-parse.h: Fix common/ includes.
6457         * mi/mi-main.c: Fix common/ includes.
6458         * mi/mi-cmd-env.c: Fix common/ includes.
6459         * memrange.h: Fix common/ includes.
6460         * memattr.c: Fix common/ includes.
6461         * maint.h: Fix common/ includes.
6462         * maint.c: Fix common/ includes.
6463         * main.c: Fix common/ includes.
6464         * machoread.c: Fix common/ includes.
6465         * location.c: Fix common/ includes.
6466         * linux-thread-db.c: Fix common/ includes.
6467         * linux-nat.c: Fix common/ includes.
6468         * linux-fork.c: Fix common/ includes.
6469         * inline-frame.c: Fix common/ includes.
6470         * infrun.c: Fix common/ includes.
6471         * inflow.c: Fix common/ includes.
6472         * inferior.h: Fix common/ includes.
6473         * inferior.c: Fix common/ includes.
6474         * infcmd.c: Fix common/ includes.
6475         * inf-ptrace.c: Fix common/ includes.
6476         * inf-child.c: Fix common/ includes.
6477         * ia64-linux-nat.c: Fix common/ includes.
6478         * i387-tdep.c: Fix common/ includes.
6479         * i386-tdep.c: Fix common/ includes.
6480         * i386-linux-tdep.c: Fix common/ includes.
6481         * i386-linux-nat.c: Fix common/ includes.
6482         * i386-go32-tdep.c: Fix common/ includes.
6483         * i386-fbsd-tdep.c: Fix common/ includes.
6484         * i386-fbsd-nat.c: Fix common/ includes.
6485         * guile/scm-type.c: Fix common/ includes.
6486         * guile/guile.c: Fix common/ includes.
6487         * go32-nat.c: Fix common/ includes.
6488         * gnu-nat.c: Fix common/ includes.
6489         * gdbthread.h: Fix common/ includes.
6490         * gdbarch-selftests.c: Fix common/ includes.
6491         * gdb_usleep.c: Fix common/ includes.
6492         * gdb_select.h: Fix common/ includes.
6493         * gdb_bfd.c: Fix common/ includes.
6494         * gcore.c: Fix common/ includes.
6495         * fork-child.c: Fix common/ includes.
6496         * findvar.c: Fix common/ includes.
6497         * fbsd-nat.c: Fix common/ includes.
6498         * event-top.c: Fix common/ includes.
6499         * event-loop.c: Fix common/ includes.
6500         * dwarf2read.c: Fix common/ includes.
6501         * dwarf2loc.c: Fix common/ includes.
6502         * dwarf2-frame.c: Fix common/ includes.
6503         * dwarf-index-cache.c: Fix common/ includes.
6504         * dtrace-probe.c: Fix common/ includes.
6505         * disasm-selftests.c: Fix common/ includes.
6506         * defs.h: Fix common/ includes.
6507         * csky-tdep.c: Fix common/ includes.
6508         * cp-valprint.c: Fix common/ includes.
6509         * cp-support.h: Fix common/ includes.
6510         * cp-support.c: Fix common/ includes.
6511         * corelow.c: Fix common/ includes.
6512         * completer.h: Fix common/ includes.
6513         * completer.c: Fix common/ includes.
6514         * compile/compile.c: Fix common/ includes.
6515         * compile/compile-loc2c.c: Fix common/ includes.
6516         * compile/compile-cplus-types.c: Fix common/ includes.
6517         * compile/compile-cplus-symbols.c: Fix common/ includes.
6518         * command.h: Fix common/ includes.
6519         * cli/cli-dump.c: Fix common/ includes.
6520         * cli/cli-cmds.c: Fix common/ includes.
6521         * charset.c: Fix common/ includes.
6522         * build-id.c: Fix common/ includes.
6523         * btrace.h: Fix common/ includes.
6524         * btrace.c: Fix common/ includes.
6525         * breakpoint.h: Fix common/ includes.
6526         * breakpoint.c: Fix common/ includes.
6527         * ax.h:
6528         (enum agent_op): Fix common/ includes.
6529         * ax-general.c (struct aop_map): Fix common/ includes.
6530         * ax-gdb.c: Fix common/ includes.
6531         * auxv.c: Fix common/ includes.
6532         * auto-load.c: Fix common/ includes.
6533         * arm-tdep.c: Fix common/ includes.
6534         * arch/riscv.c: Fix common/ includes.
6535         * arch/ppc-linux-common.c: Fix common/ includes.
6536         * arch/i386.c: Fix common/ includes.
6537         * arch/arm.c: Fix common/ includes.
6538         * arch/arm-linux.c: Fix common/ includes.
6539         * arch/arm-get-next-pcs.c: Fix common/ includes.
6540         * arch/amd64.c: Fix common/ includes.
6541         * arch/aarch64.c: Fix common/ includes.
6542         * arch/aarch64-insn.c: Fix common/ includes.
6543         * arch-utils.c: Fix common/ includes.
6544         * amd64-windows-tdep.c: Fix common/ includes.
6545         * amd64-tdep.c: Fix common/ includes.
6546         * amd64-sol2-tdep.c: Fix common/ includes.
6547         * amd64-obsd-tdep.c: Fix common/ includes.
6548         * amd64-nbsd-tdep.c: Fix common/ includes.
6549         * amd64-linux-tdep.c: Fix common/ includes.
6550         * amd64-linux-nat.c: Fix common/ includes.
6551         * amd64-fbsd-tdep.c: Fix common/ includes.
6552         * amd64-fbsd-nat.c: Fix common/ includes.
6553         * amd64-dicos-tdep.c: Fix common/ includes.
6554         * amd64-darwin-tdep.c: Fix common/ includes.
6555         * agent.c: Fix common/ includes.
6556         * ada-lang.h: Fix common/ includes.
6557         * ada-lang.c: Fix common/ includes.
6558         * aarch64-tdep.c: Fix common/ includes.
6559
6560 2019-01-25  Tom Tromey  <tom@tromey.com>
6561
6562         * common/create-version.sh: Use common/version.h.
6563
6564 2019-01-24  Pedro Alves  <palves@redhat.com>
6565
6566         * infrun.c (signal_stop, signal_print, signal_program)
6567         (signal_catch, signal_pass): Now arrays instead of pointers.
6568         (update_signals_program_target, do_target_resume)
6569         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
6570         * linux-nat.c (linux_nat_target::pass_signals)
6571         (linux_nat_target::create_inferior, linux_nat_target::attach):
6572         Adjust.
6573         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
6574         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
6575         * procfs.c (procfs_target::pass_signals): Adjust.
6576         * record-full.c (record_full_target::resume): Adjust.
6577         * remote.c (remote_target::pass_signals)
6578         (remote_target::program_signals): Adjust.
6579         * target-debug.h (target_debug_print_signals): Now takes a
6580         gdb::array_view as parameter.  Adjust.
6581         * target.h (target_ops) <pass_signals, program_signals>: Replace
6582         pointer and length parameters with gdb::array_view.
6583         (target_pass_signals, target_program_signals): Likewise.
6584         * target-delegates.c: Regenerate.
6585
6586 2019-01-24  Pedro Alves  <palves@redhat.com>
6587
6588         * common/forward-scope-exit.h
6589         (forward_scope_exit::forward_scope_exit): Pass arguments to
6590         m_bind_function directly, instead of creating a std::bind and
6591         copying that.
6592
6593 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
6594
6595         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6596         for static members.
6597         (pass_in_v_vfp_candidate): Likewise.
6598
6599 2019-01-23  Tom Tromey  <tom@tromey.com>
6600             Pedro Alves  <palves@redhat.com>
6601
6602         * regcache.c (class regcache_invalidator): Remove.
6603         (regcache::raw_write): Use make_scope_exit.
6604
6605 2019-01-23  Tom Tromey  <tom@tromey.com>
6606
6607         * ui-out.h (class ui_out_emit_type): Update comment.
6608
6609 2019-01-23  Tom Tromey  <tom@tromey.com>
6610
6611         * infrun.c (fetch_inferior_event): Update comment.
6612
6613 2019-01-23  Tom Tromey  <tom@tromey.com>
6614             Pedro Alves  <palves@redhat.com>
6615
6616         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
6617         parameter.
6618         (fetch_inferior_event): Use SCOPE_EXIT.
6619
6620
6621 2019-01-23  Tom Tromey  <tom@tromey.com>
6622             Pedro Alves  <palves@redhat.com>
6623
6624         * infrun.c (disable_thread_events): Delete.
6625         (stop_all_threads): Use SCOPE_EXIT.
6626
6627 2019-01-23  Tom Tromey  <tom@tromey.com>
6628             Pedro Alves  <palves@redhat.com>
6629
6630         * symfile.c: Include forward-scope-exit.h.
6631         (clear_symtab_users_cleanup): Replace forward declaration with
6632         a FORWARD_SCOPE_EXIT.
6633         (syms_from_objfile_1): Use the forward_scope_exit and
6634         gdb::optional instead of cleanup_function.
6635         (reread_symbols): Use the forward_scope_exit instead of
6636         cleanup_function.
6637         (clear_symtab_users_cleanup): Remove function.
6638
6639 2019-01-23  Tom Tromey  <tom@tromey.com>
6640             Pedro Alves  <palves@redhat.com>
6641
6642         * linux-nat.c: Include scope-exit.h.
6643         (cleanup_target_stop): Remove.
6644         (linux_nat_target::static_tracepoint_markers_by_strid): Use
6645         SCOPE_EXIT.
6646
6647 2019-01-23  Tom Tromey  <tom@tromey.com>
6648             Pedro Alves  <palves@redhat.com>
6649
6650         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
6651         (call_function_by_hand_dummy): Use SCOPE_EXIT.
6652
6653 2019-01-23  Tom Tromey  <tom@tromey.com>
6654             Andrew Burgess  <andrew.burgess@embecosm.com>
6655             Pedro Alves  <palves@redhat.com>
6656
6657         * infrun.c (fetch_inferior_event): Use scope_exit.
6658         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
6659         * top.c (execute_command): Use scope_exit.
6660         * breakpoint.c (bpstat_do_actions): Use scope_exit.
6661         * utils.c (do_bpstat_clear_actions_cleanup)
6662         (make_bpstat_clear_actions_cleanup): Remove.
6663
6664 2019-01-23  Tom Tromey  <tom@tromey.com>
6665             Pedro Alves  <palves@redhat.com>
6666
6667         * infrun.c: Include "common/scope-exit.h"
6668         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
6669         (wait_for_inferior): Use SCOPE_EXIT.
6670         (fetch_inferior_event): Use scope_exit.
6671
6672 2019-01-23  Tom Tromey  <tom@tromey.com>
6673             Pedro Alves  <palves@redhat.com>
6674
6675         * breakpoint.c (create_breakpoint): Remove cleanup.
6676
6677 2019-01-23  Tom Tromey  <tom@tromey.com>
6678             Andrew Burgess  <andrew.burgess@embecosm.com>
6679             Pedro Alves  <palves@redhat.com>
6680
6681 2019-01-23  Pedro Alves  <palves@redhat.com>
6682
6683         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
6684
6685 2019-01-23  Pedro Alves  <palves@redhat.com>
6686             Andrew Burgess  <andrew.burgess@embecosm.com>
6687
6688         * gdbthread.h: Include "common/forward-scope-exit.h".
6689         (scoped_finish_thread_state): Redefine custom class in terms of
6690         forward_scope_exit.
6691
6692 2019-01-23  Pedro Alves  <palves@redhat.com>
6693             Andrew Burgess  <andrew.burgess@embecosm.com>
6694
6695         * common/forward-scope-exit.h: New file.
6696
6697 2019-01-23  Pedro Alves  <palves@redhat.com>
6698             Andrew Burgess  <andrew.burgess@embecosm.com>
6699             Tom Tromey  <tom@tromey.com>
6700
6701         * common/scope-exit.h: New file.
6702
6703 2019-01-23  Pedro Alves  <palves@redhat.com>
6704
6705         * common/preprocessor.h (ESC): Rename to ...
6706         (ESC_PARENS): ... this.
6707         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
6708         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
6709
6710 2019-01-23  Tom Tromey  <tom@tromey.com>
6711
6712         * language.h (class scoped_switch_to_sym_language_if_auto):
6713         Initialize m_lang in both cases.
6714
6715 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
6716
6717         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
6718         with XCNEW.
6719
6720 2019-01-22  Tom Tromey  <tom@tromey.com>
6721
6722         * corelow.c: Do not include sys/file.h.
6723
6724 2019-01-22  Tom Tromey  <tom@tromey.com>
6725
6726         * tui/tui-wingeneral.h: Include gdb_curses.h.
6727
6728 2019-01-22  Tom Tromey  <tom@tromey.com>
6729
6730         * source-cache.h (class source_cache) <get_source_lines,
6731         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
6732
6733 2019-01-22  Tom Tromey  <tom@tromey.com>
6734
6735         * remote-fileio.h (struct remote_target): Declare.
6736
6737 2019-01-22  Tom Tromey  <tom@tromey.com>
6738
6739         * python/py-arch.c: Do not include py-ref.h.
6740         * python/py-bpevent.c: Do not include py-ref.h.
6741         * python/py-cmd.c: Do not include py-ref.h.
6742         * python/py-continueevent.c: Do not include py-ref.h.
6743         * python/py-event.h: Do not include py-ref.h.
6744         * python/py-evtregistry.c: Do not include py-ref.h.
6745         * python/py-finishbreakpoint.c: Do not include py-ref.h.
6746         * python/py-frame.c: Do not include py-ref.h.
6747         * python/py-framefilter.c: Do not include py-ref.h.
6748         * python/py-function.c: Do not include py-ref.h.
6749         * python/py-infevents.c: Do not include py-ref.h.
6750         * python/py-linetable.c: Do not include py-ref.h.
6751         * python/py-objfile.c: Do not include py-ref.h.
6752         * python/py-param.c: Do not include py-ref.h.
6753         * python/py-prettyprint.c: Do not include py-ref.h.
6754         * python/py-progspace.c: Do not include py-ref.h.
6755         * python/py-symbol.c: Do not include py-ref.h.
6756         * python/py-symtab.c: Do not include py-ref.h.
6757         * python/py-type.c: Do not include py-ref.h.
6758         * python/py-unwind.c: Do not include py-ref.h.
6759         * python/py-utils.c: Do not include py-ref.h.
6760         * python/py-value.c: Do not include py-ref.h.
6761         * python/py-varobj.c: Do not include py-ref.h.
6762         * python/py-xmethods.c: Do not include py-ref.h.
6763         * python/python.c: Do not include py-ref.h.
6764         * varobj.c: Do not include py-ref.h.
6765
6766 2019-01-22  Tom Tromey  <tom@tromey.com>
6767
6768         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
6769         keyword for bcache.
6770
6771 2019-01-22  Tom Tromey  <tom@tromey.com>
6772
6773         * compile/compile-cplus-types.c: Remove a comment by #include.
6774
6775 2019-01-22  Tom Tromey  <tom@tromey.com>
6776
6777         * compile/gcc-c-plugin.h: Include compile-internal.h.
6778
6779 2019-01-22  Tom Tromey  <tom@tromey.com>
6780
6781         * stabsread.c (EXTERN): Do not define.
6782         (symnum, next_symbol_text_func, processing_gcc_compilation)
6783         (within_function, global_sym_chain, global_stabs)
6784         (previous_stab_code, this_object_header_files)
6785         (n_this_object_header_files)
6786         (n_allocated_this_object_header_files): Define.
6787         * stabsread.h (EXTERN): Never define.  Use "extern".
6788
6789 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6790
6791         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
6792         history_value.
6793
6794 2019-01-21  Tom Tromey  <tom@tromey.com>
6795
6796         * ui-out.c: Fix includes.
6797         * tui/tui-source.c: Fix includes.
6798         * target.c: Fix includes.
6799         * remote.c: Fix includes.
6800         * regcache.c: Fix includes.
6801         * python/py-block.c: Fix includes.
6802         * printcmd.c: Fix includes.
6803         * or1k-tdep.c: Fix includes.
6804         * mi/mi-main.c: Fix includes.
6805         * m32r-tdep.c: Fix includes.
6806         * csky-tdep.c: Fix includes.
6807         * compile/compile-cplus-types.c: Fix includes.
6808         * cli/cli-interp.c: Fix includes.
6809
6810 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
6811
6812         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6813         for padding.
6814
6815 2019-01-16  Tom Tromey  <tom@tromey.com>
6816
6817         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
6818         earlier.
6819         (struct objfile) <msymbols_range>: Move from top level.
6820         <msymbols>: New method.
6821         (class objfile_msymbols): Remove.
6822         * symtab.c (default_collect_symbol_completion_matches_break_on):
6823         Update.
6824         * symmisc.c (dump_msymbols): Update.
6825         * stabsread.c (scan_file_globals): Update.
6826         * objc-lang.c (info_selectors_command, info_classes_command)
6827         (find_methods): Update.
6828         * minsyms.c (find_solib_trampoline_target): Update.
6829         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
6830         * coffread.c (coff_symfile_read): Update.
6831         * ada-lang.c (ada_lookup_simple_minsym)
6832         (ada_collect_symbol_completion_matches): Update.
6833
6834 2019-01-16  Tom Tromey  <tom@tromey.com>
6835
6836         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
6837         type.  Remove no-argument constructor.
6838         <iterator::operator++>: Simplify.
6839         <begin>: Update.
6840         <end>: Use minimal_symbol_count.
6841
6842 2019-01-16  Tom Tromey  <tom@tromey.com>
6843
6844         * objfiles.h (struct objfile) <psymtabs>: New method.
6845         (class objfile_psymtabs): Remove.
6846         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
6847         typedef.
6848         <range>: New method.
6849         (require_partial_symbols): Change return type.
6850         * psymtab.c (require_partial_symbols)
6851         (psym_expand_symtabs_matching): Update.
6852         * mdebugread.c (parse_partial_symbols): Update.
6853         * dbxread.c (dbx_end_psymtab): Update.
6854
6855 2019-01-15  Tom Tromey  <tom@tromey.com>
6856
6857         * symtab.c (lookup_objfile_from_block)
6858         (lookup_symbol_in_objfile_symtabs)
6859         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
6860         (find_line_symtab, info_sources_command)
6861         (default_collect_symbol_completion_matches_break_on)
6862         (make_source_files_completion_list): Update.
6863         * symmisc.c (print_objfile_statistics, dump_objfile)
6864         (maintenance_print_symbols, maintenance_info_symtabs)
6865         (maintenance_check_symtabs, maintenance_info_line_tables):
6866         Update.
6867         * source.c (select_source_symtab)
6868         (forget_cached_source_info_for_objfile): Update.
6869         * objfiles.h (class objfile_compunits): Remove.
6870         (struct objfile) <compunits_range>: New typedef.
6871         (compunits): New method.
6872         * objfiles.c (objfile_relocate1): Update.
6873         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6874         * maint.c (count_symtabs_and_blocks): Update.
6875         * linespec.c (iterate_over_all_matching_symtabs): Update.
6876         * cp-support.c (add_symbol_overload_list_qualified): Update.
6877         * coffread.c (coff_symtab_read): Update.
6878         * ada-lang.c (add_nonlocal_symbols)
6879         (ada_collect_symbol_completion_matches)
6880         (ada_add_global_exceptions): Update.
6881
6882 2019-01-15  Tom Tromey  <tom@tromey.com>
6883
6884         * progspace.h (program_space) <objfiles_safe_range>: New
6885         typedef.
6886         <objfiles_safe>: New method.
6887         * objfiles.h (class all_objfiles_safe): Remove.
6888         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
6889         * jit.c (jit_inferior_exit_hook): Update.
6890
6891 2019-01-17  Tom Tromey  <tom@tromey.com>
6892
6893         * progspace.h (program_space) <objfiles_range>: New typedef.
6894         <objfiles>: New method.
6895         <objfiles_head>: Rename from objfiles.
6896         (object_files): Update.
6897         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
6898         * guile/scm-pretty-print.c
6899         (ppscm_find_pretty_printer_from_objfiles): Update.
6900         * guile/scm-objfile.c (gdbscm_objfiles): Update.
6901         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
6902         Update.
6903         * python/py-progspace.c (pspy_get_objfiles): Update.
6904         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6905         Update.
6906         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6907         (objfpy_lookup_objfile_by_build_id): Update.
6908         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6909         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6910         Update.
6911         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6912         (expand_symtab_containing_pc, lookup_objfile_from_block)
6913         (lookup_static_symbol, basic_lookup_transparent_type)
6914         (find_pc_sect_compunit_symtab, find_symbol_at_address)
6915         (find_line_symtab, info_sources_command)
6916         (default_collect_symbol_completion_matches_break_on)
6917         (make_source_files_completion_list, find_main_name): Update.
6918         * symmisc.c (print_symbol_bcache_statistics)
6919         (print_objfile_statistics, maintenance_print_symbols)
6920         (maintenance_print_msymbols, maintenance_print_objfiles)
6921         (maintenance_info_symtabs, maintenance_check_symtabs)
6922         (maintenance_expand_symtabs, maintenance_info_line_tables):
6923         Update.
6924         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
6925         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
6926         (map_overlay_command, unmap_overlay_command)
6927         (simple_overlay_update, expand_symtabs_matching)
6928         (map_symbol_filenames): Update.
6929         * symfile-debug.c (set_debug_symfile): Update.
6930         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
6931         Update.
6932         * source.c (select_source_symtab, forget_cached_source_info):
6933         Update.
6934         * solib.c (solib_read_symbols): Update.
6935         * solib-spu.c (append_ocl_sos): Update.
6936         * psymtab.c (maintenance_print_psymbols)
6937         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
6938         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
6939         * printcmd.c (info_symbol_command): Update.
6940         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
6941         Update.
6942         * objfiles.h (class all_objfiles): Remove.
6943         * objfiles.c (have_partial_symbols, have_full_symbols)
6944         (have_minimal_symbols, qsort_cmp, update_section_map)
6945         (shared_objfile_contains_address_p)
6946         (default_iterate_over_objfiles_in_search_order): Update.
6947         * objc-lang.c (info_selectors_command, info_classes_command)
6948         (find_methods): Update.
6949         * minsyms.c (find_solib_trampoline_target): Update.
6950         * maint.c (maintenance_info_sections)
6951         (maintenance_translate_address, count_symtabs_and_blocks):
6952         Update.
6953         * main.c (captured_main_1): Update.
6954         * linux-thread-db.c (try_thread_db_load_from_pdir)
6955         (has_libpthread): Update.
6956         * linespec.c (iterate_over_all_matching_symtabs)
6957         (search_minsyms_for_name): Update.
6958         * jit.c (jit_find_objf_with_entry_addr): Update.
6959         * hppa-tdep.c (find_unwind_entry)
6960         (hppa_lookup_stub_minimal_symbol): Update.
6961         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
6962         Update.
6963         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6964         (elf_gnu_ifunc_resolve_by_got): Update.
6965         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
6966         * dwarf-index-write.c (save_gdb_index_command): Update.
6967         * cp-support.c (add_symbol_overload_list_qualified): Update.
6968         * breakpoint.c (create_overlay_event_breakpoint)
6969         (create_longjmp_master_breakpoint)
6970         (create_std_terminate_master_breakpoint)
6971         (create_exception_master_breakpoint): Update.
6972         * blockframe.c (find_pc_partial_function): Update.
6973         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
6974         (ada_collect_symbol_completion_matches)
6975         (ada_add_global_exceptions): Update.
6976
6977 2019-01-17  Tom Tromey  <tom@tromey.com>
6978
6979         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
6980         declare VEC.
6981         (solib_target_parse_libraries): Change return type.
6982         (library_list_start_segment, library_list_start_section)
6983         (library_list_end_library, library_list_start_library); Update.
6984         (solib_target_free_library_list): Remove.
6985         (solib_target_parse_libraries): Remove cleanup.  Change return
6986         type.
6987         (solib_target_current_sos): Update.
6988
6989 2019-01-17  Tom Tromey  <tromey@bapiya>
6990
6991         * valprint.c: Replace "the the" with "the".
6992         * symtab.c: Replace "the the" with "the".
6993         * solib.c: Replace "the the" with "the".
6994         * solib-dsbt.c: Replace "the the" with "the".
6995         * linespec.c: Replace "the the" with "the".
6996         * dwarf2loc.h: Replace "the the" with "the".
6997         * amd64-windows-tdep.c: Replace "the the" with "the".
6998         * aarch64-tdep.c: Replace "the the" with "the".
6999
7000 2019-01-16  Keith Seitz  <keiths@redhat.com>
7001
7002         PR gdb/23773
7003         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
7004         <builder>: Rename to ..
7005         <m_builder>: ... this and make private.
7006         (dwarf2_cu::get_builder): New method.  Change all users of
7007         `builder' to use this method.
7008         (dwarf2_start_symtab): Move to ...
7009         (dwarf2_cu::start_symtab): ... here.  Update all callers
7010         (setup_type_unit_groups): Move to ...
7011         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
7012         callers.
7013         (dwarf2_cu::reset_builder): New method.
7014         (process_full_compunit, process_full_type_unit): Use
7015         dwarf2_cu::reset_builder.
7016         (follow_die_offset): Record the ancestor CU if it is different
7017         from the followed DIE's CU.
7018         (follow_die_sig_1): Likewise.
7019
7020 2019-01-15  Tom Tromey  <tom@tromey.com>
7021
7022         * remote.c (class remote_state) <buf>: Now a char_vector.
7023         <buf_size>: Remove.
7024         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
7025         parameter.
7026         (remote_target::getpkt_or_notif_sane_1)
7027         (remote_target::getpkt_sane)
7028         (remote_target::getpkt_or_notif_sane): Likewise.
7029         (class remote_target) <putpkt>: New overload.
7030         (remote_target::read_frame): Change type of "buf_p".  Remove
7031         sizeof_p parameter.
7032         (packet_ok): New overload.
7033         (packet_check_result): New overload.
7034         Update all uses.
7035
7036 2019-01-14  Tom Tromey  <tom@tromey.com>
7037
7038         * remote-notif.c (handle_notification, remote_notif_ack)
7039         (remote_notif_parse): Make "buf" const.
7040         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
7041         const.
7042         (remote_notif_parse, remote_notif_ack, handle_notification):
7043         Likewise.
7044         * remote.c (remote_notif_stop_parse): Make "buf" const.
7045         (remote_target::remote_parse_stop_reply): Make "buf" const.
7046         (remote_notif_stop_ack): Make "buf" const.
7047
7048 2019-01-14  Tom Tromey  <tom@tromey.com>
7049
7050         * remote.c (remote_console_output): Make parameter const.
7051
7052 2019-01-14  Tom Tromey  <tom@tromey.com>
7053
7054         * target-debug.h (target_debug_print_signals): Constify.
7055         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
7056         * procfs.c (procfs_target::pass_signals): Update.
7057         * linux-nat.c (linux_nat_target::pass_signals): Update.
7058         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
7059         * target-delegates.c: Rebuild.
7060         * remote.c (remote_target::program_signals): Update.
7061         (remote_target::pass_signals): Update.
7062         * target.c (target_pass_signals): Constify argument.
7063         (target_program_signals): Likewise.
7064         * target.h (struct target_ops) <pass_signals, program_signals>:
7065         Constify argument.
7066         (target_pass_signals, target_program_signals): Constify argument.
7067
7068 2019-01-14  Tom Tromey  <tom@tromey.com>
7069
7070         PR tui/28819:
7071         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
7072
7073 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
7074
7075         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
7076         field.
7077         * rs6000-tdep.c: Include reggroups.h.
7078         (IS_V_ALIAS_PSEUDOREG): Define.
7079         (rs6000_register_name): Return names for the "vX" aliases.
7080         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
7081         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
7082         aliases.  Call default_register_reggroup_p for all other
7083         pseudo-registers.
7084         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
7085         New functions.
7086         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
7087         Handle "vX" aliases.
7088         (v_alias_pseudo_register_collect): New function.
7089         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
7090         (rs6000_gdbarch_init): Initialize "vX" aliases as
7091         pseudo-registers.  Restore registration of
7092         rs6000_pseudo_register_reggroup_p with
7093         set_tdesc_pseudo_register_reggroup_p.
7094
7095 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
7096
7097         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
7098         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
7099         set_gdbarch_num_pseudo_regs.
7100
7101 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7102
7103         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
7104         Remove arg prefixname, add do_set and do_show.
7105         Add member functions set_list and show_list.
7106         * cli/cli-style.c (class cli_style_option): Update accordingly.
7107         (style_set_list): Move to file scope.
7108         (style_show_list): Likewise.
7109         (set_style): Call help_list.
7110         (show_style): Call cmd_show_list.
7111         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
7112         Update to use the new macro.
7113
7114 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
7115
7116         * ada-lang.c (_initialize_ada_language): Expand the help text
7117         for the "catch exception" command.
7118
7119 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7120
7121         * symtab.c (matching_obj_sections): Initialize obj,
7122         declare it closer to its usage.
7123
7124 2019-01-10  Tom Tromey  <tom@tromey.com>
7125
7126         * thread-iter.h (inf_threads_iterator): Use next_iterator.
7127         (basic_inf_threads_range): Remove.
7128         (inf_threads_range, inf_non_exited_threads_range)
7129         (safe_inf_threads_range): Use next_adapter.
7130
7131 2019-01-10  Keith Seitz  <keiths@redhat.com>
7132
7133         PR gdb/23712
7134         PR symtab/23010
7135         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
7136         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
7137
7138 2019-01-10  Keith Seitz  <keiths@redhat.com>
7139
7140         PR gdb/23712
7141         PR symtab/23010
7142         * dictionary.c (pending_to_vector): Remove.
7143         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7144         Remove _1 suffix, replacing functions of the same name.  Update
7145         all callers.
7146         (dict_create_hashed, dict_create_hashed_expandable)
7147         (dict_create_linear, dict_create_linear_expandable, dict_free)
7148         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
7149         Make functions static.
7150
7151 2019-01-10  Keith Seitz  <keiths@redhat.com>
7152
7153         PR gdb/23712
7154         PR symtab/23010
7155         * dictionary.h (struct dictionary): Replace declaration with
7156         multidictionary.
7157         (dict_create_hashed, dict_create_hashed_expandable)
7158         (dict_create_linear, dict_create_linear_expandable)
7159         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
7160         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
7161         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
7162         taking multidictionary argument.
7163         [ALL_DICT_SYMBOLS]: Update for multidictionary.
7164         * block.h (struct block) <dict>: Change to multidictionary
7165         and rename `multidict'.
7166         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
7167         symmisc.c: Update all dictionary references to multidictionary.
7168
7169 2019-01-10  Keith Seitz  <keiths@redhat.com>
7170
7171         PR gdb/23712
7172         PR symtab/23010
7173         * dictionary.c: Include unordered_map.
7174         (pending_to_vector): New function.
7175         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7176         Rewrite the non-"_1" functions to take vector instead
7177         of linked list.
7178         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
7179         "new" _1 versions of the same name.
7180         (multidictionary): Define.
7181         (std::hash<enum language): New definition.
7182         (collate_pending_symbols_by_language, mdict_create_hashed)
7183         (mdict_create_hashed_expandable, mdict_create_linear)
7184         (mdict_create_linear_expandable, mdict_free)
7185         (find_language_dictionary, create_new_language_dictionary)
7186         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
7187         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
7188         (mdict_size, mdict_empty): New functions.
7189         * dictionary.h (mdict_iterator): Define.
7190
7191 2019-01-10  Pedro Alves  <palves@redhat.com>
7192
7193         * breakpoint.c (read_uploaded_action)
7194         (create_tracepoint_from_upload): Adjust to use
7195         gdb::unique_xmalloc_ptr.
7196         * ctf.c (ctf_write_uploaded_tp):
7197         (SET_ARRAY_FIELD): Use emplace_back.
7198         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
7199         * tracefile-tfile.c (tfile_write_uploaded_tp):
7200         * tracepoint.c (parse_tracepoint_definition): Adjust to use
7201         gdb::unique_xmalloc_ptr.
7202         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
7203         at_string, cond_string, cmd_strings>: Replace char pointers
7204         with gdb::unique_xmalloc_ptr.
7205
7206 2019-01-10  Pedro Alves  <palves@redhat.com>
7207
7208         * solib-target.c (library_list_start_library): Don't xstrdup name.
7209
7210 2019-01-10  Pedro Alves  <palves@redhat.com>
7211
7212         * mdebugread.c (parse_partial_symbols): Use
7213         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
7214
7215 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7216
7217         * linux-fork.c (scoped_switch_fork_info)
7218         <~scoped_switch_fork_info>: Fix incorrect variable name.
7219
7220 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7221
7222         * linux-fork.c (scoped_switch_fork_info)
7223         <scoped_switch_fork_info>: Make explicit.
7224         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
7225
7226 2019-01-10  Tom Tromey  <tom@tromey.com>
7227
7228         * objfiles.h (objfile::reset_psymtabs): Update.
7229         * objfiles.c (objfile::objfile): Update.
7230         * psymtab.h (psymtab_storage::obstack): Update.
7231         (psymtab_storage::m_obstack): Use gdb::optional.
7232         (class psymtab_storage): Update comment.  Remove objfile
7233         parameter.
7234         * psymtab.c (psymtab_storage::psymtab_storage): Update.
7235
7236 2019-01-10  Tom Tromey  <tom@tromey.com>
7237
7238         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
7239         <free_psymtabs>: Now private.
7240         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
7241         (allocate_psymtab): Use new method.
7242
7243 2019-01-10  Tom Tromey  <tom@tromey.com>
7244
7245         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
7246         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
7247         * mdebugread.c (parse_partial_symbols): Use
7248         allocate_dependencies.
7249         * dwarf2read.c (dwarf2_create_include_psymtab): Use
7250         allocate_dependencies.
7251         (process_psymtab_comp_unit_reader)
7252         (build_type_psymtab_dependencies): Likewise.
7253         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
7254
7255 2019-01-10  Tom Tromey  <tom@tromey.com>
7256
7257         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
7258         PSYMBOL_SET_LANGUAGE.
7259         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
7260
7261 2019-01-10  Tom Tromey  <tom@tromey.com>
7262
7263         * psymtab.h (psymtab_storage::obstack): New method.
7264         <m_obstack>: Rename from obstack; now private.
7265         * psymtab.c (psymtab_storage): Update.
7266         * dwarf2read.c (create_addrmap_from_index)
7267         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
7268         Update.
7269
7270 2019-01-10  Tom Tromey  <tom@tromey.com>
7271
7272         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
7273         * objfiles.h (objfile::reset_psymtabs): New method.
7274
7275 2019-01-10  Tom Tromey  <tom@tromey.com>
7276
7277         * symmisc.c (print_symbol_bcache_statistics): Update.
7278         (print_objfile_statistics): Update.
7279         * symfile.c (reread_symbols): Update.
7280         * psymtab.h (class psymtab_storage): New.
7281         * psymtab.c (psymtab_storage): New constructor.
7282         (~psymtab_storage): New destructor.
7283         (require_partial_symbols): Update.
7284         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
7285         (find_pc_sect_psymtab, find_pc_sect_psymbol)
7286         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
7287         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
7288         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
7289         (start_psymtab_common, end_psymtab_common)
7290         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
7291         (allocate_psymtab): Update.
7292         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
7293         Update.
7294         (dump_psymtab_addrmap, maintenance_print_psymbols)
7295         (maintenance_check_psymtabs): Update.
7296         (class objfile_psymtabs): Move to objfiles.h.
7297         * psympriv.h (discard_psymtab): Now inline.
7298         (psymtab_discarder::psymtab_discarder): Update.
7299         (psymtab_discarder::~psymtab_discarder): Update.
7300         (ALL_OBJFILE_PSYMTABS): Rewrite.
7301         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
7302         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
7303         Remove fields.
7304         <partial_symtabs>: New field.
7305         (class objfile_psymtabs): Move from psymtab.h.  Update.
7306         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
7307         psymbol_cache.
7308         (objfile::~objfile): Don't destroy psymbol_cache.
7309         * mdebugread.c (parse_partial_symbols): Update.
7310         * dwarf2read.c (create_addrmap_from_index)
7311         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
7312         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
7313         (add_partial_subprogram, dwarf2_ranges_read): Update.
7314         * dwarf-index-write.c (write_address_map)
7315         (write_one_signatured_type, recursively_write_psymbols)
7316         (class debug_names, class debug_names, write_psymtabs_to_index):
7317         Update.
7318
7319 2019-01-10  Tom Tromey  <tom@tromey.com>
7320
7321         * symtab.h (SYMBOL_SET_NAMES): Update.
7322         (symbol_set_names): Update.
7323         (MSYMBOL_SET_NAMES): Update.
7324         * symtab.c (symbol_set_names): Change argument to be an
7325         objfile_per_bfd_storage.
7326         * psymtab.c (add_psymbol_to_bcache): Update.
7327         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
7328
7329 2019-01-10  Tom Tromey  <tom@tromey.com>
7330
7331         * symtab.c (create_demangled_names_hash): Change argument to be an
7332         objfile_per_bfd_storage.
7333         (symbol_set_names): Update.
7334
7335 2019-01-10  Tom Tromey  <tom@tromey.com>
7336
7337         * xcoffread.c (xcoff_initial_scan): Unconditionally call
7338         init_psymbol_list.
7339         * psymtab.c (init_psymbol_list): Do nothing if already called.
7340         * psympriv.h (init_psymbol_list): Add comment.
7341         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
7342         init_psymbol_list.
7343         * dbxread.c (dbx_symfile_read): Unconditionally call
7344         init_psymbol_list.
7345
7346 2019-01-10  Tom Tromey  <tom@tromey.com>
7347
7348         * xcoffread.c (scan_xcoff_symtab): Update.
7349         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
7350         "where".
7351         * mdebugread.c (parse_partial_symbols)
7352         (handle_psymbol_enumerators): Update.
7353         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
7354         * dbxread.c (read_dbx_symtab): Update.
7355         * psympriv.h (psymbol_placement): New enum.
7356         (add_psymbol_to_list): Update.
7357
7358 2019-01-10  Tom Tromey  <tom@tromey.com>
7359
7360         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
7361         static_psymbols parameters.
7362         (scan_xcoff_symtab): Update.
7363         * psymtab.c (start_psymtab_common): Remove global_psymbols and
7364         static_psymbols parameters.
7365         * psympriv.h (start_psymtab_common): Update.
7366         * mdebugread.c (parse_partial_symbols): Update.
7367         * dwarf2read.c (create_partial_symtab): Update.
7368         * dbxread.c (read_dbx_symtab): Update.
7369         (start_psymtab): Remove global_psymbols and static_psymbols
7370         parameters.
7371
7372 2019-01-10  Tom Tromey  <tom@tromey.com>
7373
7374         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
7375         * psymtab.c (allocate_psymtab): Add comment.
7376         * psympriv.h (allocate_psymtab): Add comment.
7377         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
7378         initializations.
7379         * dbxread.c (dbx_end_psymtab): Remove some initializations.
7380
7381 2019-01-10  Tom Tromey  <tom@tromey.com>
7382
7383         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7384         Don't declare.
7385         * mipsread.c: Include mdebugread.h.
7386         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7387         Declare.
7388         * elfread.c: Include mdebugread.h.
7389
7390 2019-01-09  Tom Tromey  <tom@tromey.com>
7391
7392         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
7393         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
7394         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
7395         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
7396         (psym_lookup_symbol, psym_find_last_source_symtab)
7397         (psym_forget_cached_source_info, psym_print_stats)
7398         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
7399         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
7400         (psym_map_matching_symbols, psym_expand_symtabs_matching)
7401         (psym_find_compunit_symtab_by_address)
7402         (maintenance_print_psymbols, maintenance_info_psymtabs)
7403         (maintenance_check_psymtabs): Use ranged for.
7404         * psymtab.h (class objfile_psymtabs): New.
7405         (require_partial_symbols): Return objfile_psymtabs.
7406         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
7407
7408 2019-01-09  Tom Tromey  <tom@tromey.com>
7409
7410         * symfile.c (overlay_invalidate_all, find_pc_overlay)
7411         (find_pc_mapped_section, list_overlays_command)
7412         (map_overlay_command, unmap_overlay_command)
7413         (simple_overlay_update): Use all_objfiles.
7414         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
7415         * printcmd.c (info_symbol_command): Use all_objfiles.
7416         * objfiles.h (ALL_OBJSECTIONS): Remove.
7417         * maint.c (maintenance_translate_address): Use all_objfiles.
7418         * gcore.c (gcore_create_callback): Use all_objfiles.
7419         (objfile_find_memory_regions): Likewise.
7420
7421 2019-01-09  Tom Tromey  <tom@tromey.com>
7422
7423         * symtab.c (find_line_symtab, info_sources_command)
7424         (make_source_files_completion_list): Use objfile_compunits.
7425         * source.c (select_source_symtab): Use objfile_compunits.
7426         * objfiles.h (struct objfile): Update comment.
7427         (ALL_OBJFILES): Remove.
7428         (ALL_FILETABS): Remove.
7429         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
7430         objfile_compunits.
7431
7432 2019-01-09  Tom Tromey  <tom@tromey.com>
7433
7434         * symmisc.c (print_objfile_statistics, dump_objfile)
7435         (maintenance_print_symbols): Use compunit_filetabs.
7436         * source.c (forget_cached_source_info_for_objfile): Use
7437         compunit_filetabs.
7438         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
7439         (ALL_FILETABS): Use compunit_filetabs.
7440         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
7441         * coffread.c (coff_symtab_read): Use compunit_filetabs.
7442
7443 2019-01-09  Tom Tromey  <tom@tromey.com>
7444
7445         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
7446         (compunit_filetabs): New.
7447         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
7448         compunit_filetabs.
7449         (info_sources_command, make_source_files_completion_list): Remove
7450         declaration.
7451         * symmisc.c (print_objfile_statistics, dump_objfile)
7452         (maintenance_print_symbols): Remove declaration.
7453         (maintenance_info_symtabs): Use compunit_filetabs.
7454         (maintenance_info_line_tables): Likewise.
7455         * source.c (select_source_symtab): Change local variable name.
7456         (forget_cached_source_info_for_objfile): Remove declaration.
7457         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
7458         * objfiles.c (objfile_relocate1): Remove declaration.
7459         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7460         declaration.
7461         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
7462         * coffread.c (coff_symtab_read): Remove declaration.
7463         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
7464         compunit_filetabs.
7465
7466 2019-01-09  Tom Tromey  <tom@tromey.com>
7467
7468         * symtab.c (lookup_objfile_from_block)
7469         (find_pc_sect_compunit_symtab, search_symbols)
7470         (default_collect_symbol_completion_matches_break_on): Use
7471         objfile_compunits.
7472         * objfiles.h (ALL_COMPUNITS): Remove.
7473         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
7474         * cp-support.c (add_symbol_overload_list_qualified): Use
7475         objfile_compunits.
7476         * ada-lang.c (ada_collect_symbol_completion_matches)
7477         (ada_add_global_exceptions): Use objfile_compunits.
7478
7479 2019-01-09  Tom Tromey  <tom@tromey.com>
7480
7481         * source.c (select_source_symtab)
7482         (forget_cached_source_info_for_objfile): Remove declaration.
7483         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7484         declaration.
7485         * maint.c (count_symtabs_and_blocks): Remove declaration.
7486         * cp-support.c (add_symbol_overload_list_qualified): Remove
7487         declaration.
7488         * coffread.c (coff_symtab_read): Remove declaration.
7489         * symtab.c (lookup_symbol_in_objfile_symtabs)
7490         (basic_lookup_transparent_type_1): Use objfile_compunits.
7491         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
7492         (info_sources_command, search_symbols)
7493         (default_collect_symbol_completion_matches_break_on)
7494         (make_source_files_completion_list): Remove declaration.
7495         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
7496         (ada_collect_symbol_completion_matches)
7497         (ada_add_global_exceptions): Remove declaration.
7498         * linespec.c (iterate_over_all_matching_symtabs): Use
7499         objfile_compunits.
7500         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
7501         (class objfile_compunits): New.
7502         (ALL_COMPUNITS): Use objfile_compunits.
7503         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
7504         (maintenance_check_symtabs, maintenance_info_line_tables): Use
7505         objfile_compunits.
7506         * objfiles.c (objfile_relocate1): Use objfile_compunits.
7507
7508 2019-01-09  Tom Tromey  <tom@tromey.com>
7509
7510         * symtab.c (search_symbols)
7511         (default_collect_symbol_completion_matches_break_on): Use
7512         objfile_msymbols.
7513         * ada-lang.c (ada_lookup_simple_minsym)
7514         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
7515         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
7516         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
7517         objfile_msymbols.
7518         * coffread.c (coff_symfile_read): Use objfile_msymbols.
7519         * symmisc.c (dump_msymbols): Use objfile_msymbols.
7520         * objc-lang.c (find_methods): Use objfile_msymbols.
7521         (info_selectors_command, info_classes_command): Likewise.
7522         * stabsread.c (scan_file_globals): Use objfile_msymbols.
7523         * objfiles.h (class objfile_msymbols): New.
7524         (ALL_OBJFILE_MSYMBOLS): Remove.
7525         (ALL_MSYMBOLS): Remove.
7526
7527 2019-01-09  Tom Tromey  <tom@tromey.com>
7528
7529         * common/next-iterator.h (next_adapter): Add Iterator template
7530         parameter.
7531         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
7532         (class all_objfiles_safe): New.
7533         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
7534         * objfiles.c (put_objfile_before): Update comment.
7535         (add_separate_debug_objfile): Likewise.
7536         (free_all_objfiles): Use all_objfiles_safe.
7537         (objfile_purge_solibs): Likewise.
7538
7539 2019-01-09  Tom Tromey  <tom@tromey.com>
7540
7541         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7542         (expand_symtab_containing_pc, lookup_static_symbol)
7543         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
7544         (find_symbol_at_address, find_line_symtab, find_main_name): Use
7545         all_objfiles.
7546         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
7547         * breakpoint.c (create_overlay_event_breakpoint)
7548         (create_longjmp_master_breakpoint)
7549         (create_std_terminate_master_breakpoint)
7550         (create_exception_master_breakpoint): Use all_objfiles.
7551         * linux-thread-db.c (try_thread_db_load_from_pdir)
7552         (has_libpthread): Use all_objfiles.
7553         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
7554         * linespec.c (iterate_over_all_matching_symtabs)
7555         (search_minsyms_for_name): Use all_objfiles.
7556         * maint.c (maintenance_info_sections): Use all_objfiles.
7557         * main.c (captured_main_1): Use all_objfiles.
7558         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
7559         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
7560         * guile/scm-pretty-print.c
7561         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
7562         * solib-spu.c (append_ocl_sos): Use all_objfiles.
7563         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
7564         (maintenance_print_msymbols): Use all_objfiles.
7565         * source.c (select_source_symtab): Use all_objfiles.
7566         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
7567         * symfile.c (remove_symbol_file_command)
7568         (expand_symtabs_matching, map_symbol_filenames): Use
7569         all_objfiles.
7570         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
7571         all_objfiles.
7572         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
7573         * objc-lang.c (find_methods): Use all_objfiles.
7574         * objfiles.c (have_partial_symbols, have_full_symbols)
7575         (have_minimal_symbols, qsort_cmp)
7576         (default_iterate_over_objfiles_in_search_order): Use
7577         all_objfiles.
7578         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
7579         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
7580         (maintenance_check_psymtabs): Use all_objfiles.
7581         (ALL_PSYMTABS): Remove.
7582         * compile/compile-object-run.c (do_module_cleanup): Use
7583         all_objfiles.
7584         * blockframe.c (find_pc_partial_function): Use all_objfiles.
7585         * cp-support.c (add_symbol_overload_list_qualified): Use
7586         all_objfiles.
7587         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7588         Use all_objfiles.
7589         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
7590         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
7591         all_objfiles.
7592         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7593         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
7594         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7595         Uses all_objfiles.
7596         * solib.c (solib_read_symbols): Use all_objfiles
7597
7598 2019-01-09  Tom Tromey  <tom@tromey.com>
7599
7600         * probe.c (parse_probes_in_pspace): Use all_objfiles.
7601         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
7602         all_objfiles.
7603         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
7604         * symmisc.c (print_symbol_bcache_statistics)
7605         (print_objfile_statistics, maintenance_print_objfiles)
7606         (maintenance_info_symtabs, maintenance_check_symtabs)
7607         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
7608         all_objfiles.
7609         * source.c (forget_cached_source_info): Use all_objfiles.
7610         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
7611         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7612         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
7613         * objfiles.c (update_section_map): Use all_objfiles.
7614         (shared_objfile_contains_address_p): Likewise.
7615         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
7616         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
7617
7618 2019-01-09  Tom Tromey  <tom@tromey.com>
7619
7620         * common/next-iterator.h: New file.
7621         * objfiles.h (class all_objfiles): New.
7622         (struct objfile_iterator): New.
7623
7624 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7625
7626         * NEWS: Move the description of the changed "frame", "select-frame",
7627          and "info frame" commands to the Changed commands section.
7628
7629 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
7630
7631         * gdbtypes.c (check_stub_method_group): Remove handling of old
7632         mangling schemes.
7633         * linespec.c (find_methods): Likewise.
7634         * stabsread.c (read_member_functions): Likewise.
7635         * valops.c (search_struct_method): Likewise.
7636         (value_struct_elt_for_reference): Likewise.
7637         * NEWS: Mention this change.
7638
7639 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7640
7641         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
7642         print_source_lines.
7643         * source.c (print_source_lines_base): Update line number check.
7644         (print_source_lines): New function.
7645         (source_lines_range::source_lines_range): New function.
7646         * source.h (class source_lines_range): New class.
7647         (print_source_lines): New declaration.
7648
7649 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7650
7651         * linespec.c (linespec_state_destructor): Free self->canonical_names.
7652
7653 2019-01-08  Tom Tromey  <tom@tromey.com>
7654             Simon Marchi  <simon.marchi@ericsson.com>
7655
7656         PR gdb/24060
7657         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
7658         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
7659         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7660         * f-exp.y (DOLLAR_VARIABLE): Likewise.
7661         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
7662         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7663
7664 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7665
7666         * source.c (select_source_symtab): Move header comment to
7667         declaration in source.h.
7668         (forget_cached_source_info_for_objfile): Likewise.
7669         (forget_cached_source_info): Likewise.
7670         (identify_source_line): Likewise.
7671         * source.h (identify_source_line): Move declaration from symtab.h
7672         and add comment from source.c
7673         (print_source_lines): Likewise.
7674         (forget_cached_source_info_for_objfile): Likewise.
7675         (forget_cached_source_info): Likewise.
7676         (select_source_symtab): Likewise.
7677         (enum print_source_lines_flag): Move definition from symtab.h.
7678         * symtab.h (identify_source_line): Move declaration to source.h.
7679         (print_source_lines): Likewise.
7680         (forget_cached_source_info_for_objfile): Likewise.
7681         (forget_cached_source_info): Likewise.
7682         (select_source_symtab): Likewise.
7683         (enum print_source_lines_flag): Move definition to source.h.
7684         * tui/tui-hooks.c: Add 'source.h' include.
7685
7686 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7687
7688         * source.c (print_source_lines_base): Handle requests to print
7689         reverse line number sequences, and guard against empty lines
7690         string.
7691
7692 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7693
7694         * source.c (print_source_lines_base): Fix skip of '\r' if next
7695         character is '\n'.
7696
7697 2019-01-06  Tom Tromey  <tom@tromey.com>
7698
7699         * c-exp.y (struct c_parse_state) <macro_original_text,
7700         expansion_obstack>: New member.
7701         (macro_original_text, expansion_obstack): Remove globals.
7702         (scan_macro_expansion, scanning_macro_expansion)
7703         (finished_macro_expansion): Update.
7704         (scan_macro_cleanup): Remove.
7705         (yylex, c_parse): Update.
7706
7707 2019-01-06  Tom Tromey  <tom@tromey.com>
7708
7709         * c-exp.y (struct c_parse_state) <strings>: New member.
7710         (operator_stoken): Update.
7711
7712 2019-01-06  Tom Tromey  <tom@tromey.com>
7713
7714         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
7715         (union type_stack_elt) <typelist_val>: Now a pointer to
7716         std::vector.
7717         (type_stack_cleanup): Don't declare.
7718         (push_typelist): Update.
7719         * parse.c (pop_typelist): Return a std::vector.
7720         (push_typelist): Take a std::vector.
7721         (follow_types): Update.  Do not free args.
7722         (type_stack_cleanup): Remove.
7723         * c-exp.y (struct c_parse_state): New.
7724         (cpstate): New global.
7725         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
7726         (nonempty_typelist): Update.
7727         (func_mod): Create a new vector.
7728         (c_parse): Create a c_parse_state.
7729         (check_parameter_typelist): Do not delete params.
7730         (function_method): Update.  Do not delete type_list.
7731
7732 2019-01-06  Tom Tromey  <tom@tromey.com>
7733
7734         PR gdb/28155:
7735         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
7736         check_typedef.
7737         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
7738         (print_return_value): Likewise.
7739
7740 2019-01-05  Tom Tromey  <tom@tromey.com>
7741
7742         * contrib/cleanup_check.py: Remove.
7743         * contrib/gcc-with-excheck: Remove.
7744         * contrib/exsummary.py: Remove.
7745         * contrib/excheck.py: Remove.
7746
7747 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
7748
7749         * thread.c (delete_thread_1): Add gdb_assert that THR is not
7750         NULL. Initialize tpprev to NULL instead of assigning it
7751         to NULL on the next statement.
7752         * windows-nat.c (windows_delete_thread): Remove check for
7753         main_thread_id before printing thread exit notifications.
7754         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
7755         Remove thread ID check against main_thread_id.
7756         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
7757         windows_delete_thread.
7758         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
7759
7760 2019-01-04  Tom Tromey  <tom@tromey.com>
7761
7762         * compile/compile.c (_initialize_compile): Use upper case for
7763         metasyntactic variables.
7764         * symmisc.c (_initialize_symmisc): Use upper case for
7765         metasyntactic variables.
7766         * psymtab.c (_initialize_psymtab): Use upper case for
7767         metasyntactic variables.
7768         * demangle.c (demangle_command): Use upper case for metasyntactic
7769         variables.
7770         (_initialize_demangler): Likewise.
7771         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
7772         variables.
7773
7774 2019-01-03  Tom Tromey  <tom@tromey.com>
7775
7776         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
7777
7778 2019-01-03  Tom Tromey  <tom@tromey.com>
7779
7780         * python/py-symtab.c (salpy_str): Update.
7781         (struct salpy_sal_object) <symtab>: Now a PyObject.
7782         (salpy_dealloc): Update.
7783         (del_objfile_sal): Use gdbpy_ref.
7784
7785 2019-01-03  Tom Tromey  <tom@tromey.com>
7786
7787         * python/py-type.c (convert_field): Use new_reference.  Return
7788         gdbpy_ref.
7789         (make_fielditem): Return gdbpy_ref.
7790         (typy_fields): Update.
7791         (typy_getitem): Update.
7792         (field_name): Return gdbpy_ref.  Use new_reference.
7793         (typy_iterator_iternext): Update.
7794
7795 2019-01-03  Tom Tromey  <tom@tromey.com>
7796
7797         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
7798
7799 2019-01-03  Tom Tromey  <tom@tromey.com>
7800
7801         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
7802         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
7803         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
7804         (pspy_set_frame_filters, pspy_set_frame_unwinders)
7805         (pspy_set_type_printers): Likewise.
7806         * python/py-function.c (fnpy_init): Use gdbpy_ref.
7807         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
7808         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
7809         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
7810         (objfpy_set_type_printers): Likewise.
7811
7812 2019-01-03  Tom Tromey  <tom@tromey.com>
7813
7814         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
7815         (gdbpy_print_stack): Use gdbpy_err_fetch.
7816         * python/python-internal.h (class gdbpy_err_fetch): New class.
7817         (class gdbpy_enter) <m_error_type, m_error_value,
7818         m_error_traceback>: Remove.
7819         <m_error>: New member.
7820         (gdbpy_exception_to_string): Don't declare.
7821         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
7822         * python/py-value.c (convert_value_from_python): Use
7823         gdbpy_err_fetch.
7824         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
7825         gdbpy_exception_to_string.
7826         (gdbpy_handle_exception): Use gdbpy_err_fetch.
7827         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
7828         gdbpy_err_fetch.
7829
7830 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7831
7832         * linux-nat.c (delete_lwp_cleanup): Delete.
7833         (struct lwp_deleter): New struct.
7834         (lwp_info_up): New typedef.
7835         (linux_nat_target::follow_fork): Delete cleanup, and make use of
7836         lwp_info_up.
7837
7838 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7839
7840         * linux-fork.c (class scoped_switch_fork_info): New class.
7841         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
7842
7843 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7844
7845         * valops.c (find_overload_match): Remove use of null_cleanup, and
7846         calls to do_cleanups.
7847
7848 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7849
7850         * compile/compile-cplus-types.c
7851         (compile_cplus_instance::decl_name): Handle changes to
7852         cp_func_name.
7853         * cp-support.c (cp_func_name): Update header comment, update
7854         return type.
7855         * cp-support.h (cp_func_name): Update return type in declaration.
7856         * valops.c (find_overload_match): Move temp_func local to top
7857         level of function and change its type.  Use temp_func to hold and
7858         delete temporary string obtained from cp_func_name.
7859
7860 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7861
7862         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
7863         gdb::char_vector, remove cleanup, and update uses of `msg`.
7864
7865 2019-01-03  Jim Wilson  <jimw@sifive.com>
7866
7867         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
7868
7869 2019-01-02  Tom Tromey  <tom@tromey.com>
7870
7871         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
7872         (tdesc_parse_xml): Remove cleanups.
7873         * target-descriptions.h (make_cleanup_free_target_description):
7874         Don't declare.
7875         (target_desc_deleter): New struct.
7876         (target_desc_up): New typedef.
7877         * target-descriptions.c (target_desc_deleter::operator()): Rename
7878         from free_target_description.
7879         (make_cleanup_free_target_description): Remove.
7880
7881 2019-01-02  Tom Tromey  <tom@tromey.com>
7882
7883         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
7884         constructor, destructor.
7885         (linespec_parser): Remove typedef.
7886         (~linespec_parser): Rename from linespec_parser_delete.
7887         (linespec_lex_to_end, linespec_complete_label)
7888         (linespec_complete): Update.
7889         (decode_line_full): Remove cleanups.
7890         (decode_line_1): Update.
7891
7892 2019-01-02  Tom Tromey  <tom@tromey.com>
7893
7894         * python/python-internal.h (inferior_to_inferior_object): Change
7895         return type.
7896         * python/py-exitedevent.c (create_exited_event_object): Update.
7897         * python/py-inferior.c (inferior_to_inferior_object): Return
7898         gdbpy_ref.
7899         (python_new_inferior, python_inferior_deleted)
7900         (thread_to_thread_object, delete_thread_object)
7901         (build_inferior_list, gdbpy_selected_inferior): Update.
7902         * python/py-infthread.c (create_thread_object): Update.  Also fail
7903         if inferior_to_inferior_object fails.
7904
7905 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
7906
7907         * inferior.h (class inferior) <displaced_step_state>: New field.
7908         * infrun.h (struct displaced_step_state): Move here from
7909         infrun.c.  Initialize fields, add constructor.
7910         <inf>: Remove field.
7911         <reset>: New method.
7912         * infrun.c (struct displaced_step_inferior_state): Move to
7913         infrun.h.
7914         (displaced_step_inferior_states): Remove.
7915         (get_displaced_stepping_state): Adust.
7916         (displaced_step_in_progress_any_inferior): Adjust.
7917         (displaced_step_in_progress_thread): Adjust.
7918         (displaced_step_in_progress): Adjust.
7919         (add_displaced_stepping_state): Remove.
7920         (get_displaced_step_closure_by_addr): Adjust.
7921         (remove_displaced_stepping_state): Remove.
7922         (infrun_inferior_exit): Call displaced_step_state.reset.
7923         (use_displaced_stepping): Don't check for NULL.
7924         (displaced_step_prepare_throw): Call
7925         get_displaced_stepping_state.
7926         (displaced_step_fixup): Don't check for NULL.
7927         (prepare_for_detach): Don't check for NULL.
7928
7929 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7930
7931         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
7932          in case of call that did not complete.
7933
7934 2019-01-02  Andrey Utkin  <autkin@undo.io>
7935
7936         * symfile.c (find_separate_debug_file): Fix search of debug files for
7937         remote debuggee.
7938
7939 2019-01-02  Tom Tromey  <tom@tromey.com>
7940
7941         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
7942         indentation.
7943         * python/py-frame.c (frapy_older): Remove cast.
7944         (frapy_newer): Likewise.
7945         * python/py-breakpoint.c (local_setattro): Remove cast.
7946         * python/py-arch.c (archpy_name): Remove local variable.
7947         * python/py-type.c (gdbpy_lookup_type): Remove cast.
7948
7949 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
7950
7951         * unittests/basic_string_view/element_access/char/empty.cc:
7952         Fix year range in copyright header.
7953
7954 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7955
7956         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
7957         Delete.
7958         <operator==>: Update with for removed field.
7959         <hash>: Likewise.
7960         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
7961         <isa_features>: ...this.
7962         <abi_features>: New field.
7963         (riscv_isa_flen): Update comment.
7964         (riscv_abi_xlen): New declaration.
7965         (riscv_abi_flen): New declaration.
7966         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
7967         isa_features.
7968         (riscv_abi_xlen): New function.
7969         (riscv_isa_flen): Update to get answer from isa_features.
7970         (riscv_abi_flen): New function.
7971         (riscv_has_fp_abi): Update to get answer from abi_features.
7972         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
7973         xlen and flen.
7974         (riscv_call_info) <xlen, flen>: Update comment.
7975         (riscv_call_arg_struct): Remove invalid assertions
7976         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
7977         is removed.
7978         (riscv_gdbarch_init): Gather isa features and abi features
7979         separately, ensure both match on the gdbarch when reusing an old
7980         gdbarch.  Relax an error check to allow 32-bit abi float to run on
7981         a target with 64-bit float hardware.
7982
7983 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7984
7985         * source.c (search_command_helper): Stop reverse search
7986         when line 1 has been searched.
7987
7988 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7989
7990         * record-full.c (record_full_base_target::close): Rewrite
7991         record_full_core_buf_list free logic.
7992
7993 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7994
7995         * break-catch-syscall.c (print_one_catch_syscall): xfree
7996         the last text.
7997
7998 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7999
8000         * top.c (print_gdb_version): Update Copyright year in version
8001         message.
8002
8003 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8004
8005         Update copyright year range in all GDB files.
8006
8007 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
8008
8009         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
8010
8011 For older changes see ChangeLog-2018.
8012 \f
8013 Local Variables:
8014 mode: change-log
8015 left-margin: 8
8016 fill-column: 74
8017 version-control: never
8018 coding: utf-8
8019 End:
8020