gdb/ChangeLog

   1 2018-09-18  Alan Hayward  <alan.hayward@arm.com>
   2
   3         * aarch64-tdep.c (pass_in_v): Use register size.
   4         (aarch64_extract_return_value): Likewise.
   5         (aarch64_store_return_value): Likewise.
   6
   7 2018-09-18  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
   8
   9         * utils.c (dump_core) [HAVE_SETRLIMIT]: Cast RLIM_INFINITY to
  10         rlim_t.
  11
  12 2018-09-17  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  13
  14         * python/lib/gdb/command/frame_filters.py (EnableFrameFilter):
  15         Fix short help line.
  16
  17 2018-09-17  Tom Tromey  <tom@tromey.com>
  18
  19         PR python/20445:
  20         * configure: Rebuild.
  21         * configure.ac: Conditionally use -DNDEBUG for Python.
  22
  23 2018-09-17  Tom Tromey  <tom@tromey.com>
  24
  25         * configure: Rebuild.
  26         * configure.ac: Use gmp as a library dependency when checking for
  27         mpfr.
  28
  29 2018-09-17  Pedro Alves  <palves@redhat.com>
  30
  31         * python/py-inferior.c (find_inferior_object): Delete.
  32
  33 2018-09-17  Simon Marchi  <simon.marchi@ericsson.com>
  34
  35         * compile/compile-cplus-types.c
  36         (compile_cplus_instance::enter_scope): Don't use new_scope after
  37         std::move.
  38
  39 2018-09-17  Tom Tromey  <tom@tromey.com>
  40
  41         * common/pathstuff.c (get_standard_cache_dir): Use
  42         ~/Library/Caches on macOS.
  43         * common/pathstuff.h (get_standard_cache_dir): Update comment.
  44
  45 2018-09-17  Simon Marchi  <simon.marchi@polymtl.ca>
  46
  47         PR python/23669
  48         * breakpoint.c (commands_cmd_element): New.
  49         (_initialize_breakpoint): Assign commands_cmd_element.
  50         * breakpoint.h (commands_cmd_element): New.
  51         * cli/cli-script.c (while_cmd_element, if_command,
  52         define_cmd_element): New.
  53         (command_name_equals): Remove.
  54         (process_next_line): Compare commands by pointer, not by name.
  55         (_initialize_cli_script): Assign the various cmd_list_element
  56         variables.
  57         * compile/compile.c (compile_cmd_element): New.
  58         (_initialize_compile): Assign compile_cmd_element.
  59         * compile/compile.h (compile_cmd_element): New.
  60         * guile/guile.c (guile_cmd_element): New.
  61         (install_gdb_commands): Assign guile_cmd_element.
  62         * guile/guile.h (guile_cmd_element): New.
  63         * python/python.c (python_cmd_element): New.
  64         (_initialize_python): Assign python_cmd_element.
  65         * python/python.h (python_cmd_element): New.
  66         * tracepoint.c (while_stepping_cmd_element): New.
  67         (_initialize_tracepoint): Assign while_stepping_cmd_element.
  68         * tracepoint.h (while_stepping_cmd_element): New.
  69
  70 2018-09-17  Tom Tromey  <tom@tromey.com>
  71
  72         * infrun.c (save_infcall_suspend_state): Return
  73         infcall_suspend_state_up.
  74         (save_infcall_control_state): Return infcall_control_state_up.
  75         * inferior.h (save_infcall_suspend_state)
  76         (save_infcall_control_state): Declare later.  Return unique
  77         pointers.
  78
  79 2018-09-17  Tom Tromey  <tom@tromey.com>
  80
  81         * infrun.c (struct stop_context): Declare constructor,
  82         destructor, "changed" method.
  83         (stop_context::stop_context): Rename from save_stop_context.
  84         (stop_context::~stop_context): Rename from
  85         release_stop_context_cleanup.
  86         (normal_stop): Update.
  87         (stop_context::changed): Rename from stop_context_changed.  Return
  88         bool.
  89
  90 2018-09-17  Tom Tromey  <tom@tromey.com>
  91
  92         * inferior.h (struct infcall_suspend_state_deleter): New.
  93         (infcall_suspend_state_up): New typedef.
  94         (struct infcall_control_state_deleter): New.
  95         (infcall_control_state_up): New typedef.
  96         (make_cleanup_restore_infcall_suspend_state)
  97         (make_cleanup_restore_infcall_control_state): Don't declare.
  98         * infcall.c (call_function_by_hand_dummy): Update.
  99         * infrun.c (do_restore_infcall_suspend_state_cleanup)
 100         (make_cleanup_restore_infcall_suspend_state): Remove.
 101         (do_restore_infcall_control_state_cleanup)
 102         (make_cleanup_restore_infcall_control_state): Remove.
 103
 104 2018-09-17  Tom Tromey  <tom@tromey.com>
 105
 106         * gdbthread.h (struct thread_control_state): Add initializer.
 107         (class thread_info) <control>: Remove initializer.
 108         * inferior.h (struct inferior_control_state): Add initializer.
 109         (class inferior) <control>: Remove initializer.
 110         (exit_inferior_1): Update.
 111         * infrun.c (struct infcall_control_state): Add constructors.
 112         (save_infcall_control_state): Use new.
 113         (restore_infcall_control_state, discard_infcall_control_state):
 114         Use delete.
 115
 116 2018-09-17  Tom Tromey  <tom@tromey.com>
 117
 118         * infrun.c (struct infcall_suspend_state) <registers>: Now a
 119         unique_ptr.
 120         <siginfo_data>: Now a unique_xmalloc_ptr.
 121         (save_infcall_suspend_state, restore_infcall_suspend_state)
 122         (discard_infcall_suspend_state)
 123         (get_infcall_suspend_state_regcache): Update.
 124
 125 2018-09-17  Tom Tromey  <tom@tromey.com>
 126
 127         * gdbthread.h (struct thread_suspend_state): Add initializers.
 128         (class thread_info) <suspend>: Remove initializer.
 129         * infrun.c (struct infcall_suspend_state): Add initializers.
 130         (save_infcall_suspend_state): Use new.
 131         (discard_infcall_suspend_state): Use delete.
 132
 133 2018-09-16  Tom Tromey  <tom@tromey.com>
 134
 135         * python/python-internal.h (CPYCHECKER_STEALS_REFERENCE_TO_ARG):
 136         Remove.
 137         * python/py-varobj.c (py_varobj_iter_ctor): Change pyiter to
 138         rvalue reference.  Remove CPYCHECKER_STEALS_REFERENCE_TO_ARG.
 139         (py_varobj_iter_new): Likewise.
 140         (py_varobj_get_iterator): Use gdbpy_ref.
 141
 142 2018-09-16  Tom Tromey  <tom@tromey.com>
 143
 144         * python/py-threadevent.c (py_get_event_thread): Simplify.
 145         * python/py-inferior.c (infpy_thread_from_thread_handle):
 146         Return immediately after calling thread_to_thread_object.  Use
 147         Py_RETURN_NONE.
 148         (thread_to_thread_object): Set the exception on a NULL return.
 149
 150 2018-09-16  Simon Marchi  <simon.marchi@polymtl.ca>
 151
 152         * Makefile.in (LIBGDB_OBS): Sort COMMON_OBS.
 153
 154 2018-09-16  Tom Tromey  <tom@tromey.com>
 155
 156         * python/python-internal.h (CPYCHECKER_RETURNS_BORROWED_REF):
 157         Remove.
 158
 159 2018-09-16  Tom Tromey  <tom@tromey.com>
 160
 161         * python/python-internal.h (thread_to_thread_object): Change
 162         return type.
 163         * python/py-inferior.c (thread_to_thread_object): Return a new
 164         reference.
 165         (infpy_thread_from_thread_handle): Update.
 166         * python/py-infthread.c (gdbpy_selected_thread): Update.
 167         * python/py-stopevent.c (create_stop_event_object): Update.
 168         * python/py-threadevent.c (py_get_event_thread): Return a new
 169         reference.
 170         (py_get_event_thread): Update.
 171         * python/py-event.h (py_get_event_thread): Change return type.
 172         * python/py-continueevent.c (create_continue_event_object):
 173         Update.
 174
 175 2018-09-16  Tom Tromey  <tom@tromey.com>
 176
 177         * python/py-progspace.c (pspy_get_objfiles): Update.
 178         * python/python-internal.h (objfile_to_objfile_object): Change
 179         return type.
 180         * python/py-newobjfileevent.c (create_new_objfile_event_object):
 181         Update.
 182         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
 183         Update.
 184         * python/python.c (gdbpy_get_current_objfile): Update.
 185         (gdbpy_objfiles): Update.
 186         * python/py-objfile.c (objfpy_get_owner, gdbpy_lookup_objfile):
 187         Update.
 188         (objfile_to_objfile_object): Return a new reference.
 189         * python/py-symtab.c (stpy_get_objfile): Update.
 190         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 191         Update.
 192
 193 2018-09-16  Tom Tromey  <tom@tromey.com>
 194
 195         * python/py-inferior.c (infpy_get_progspace): Update.
 196         * python/python-internal.h (pspace_to_pspace_object): Change
 197         return type.
 198         * python/py-newobjfileevent.c
 199         (create_clear_objfiles_event_object): Update.
 200         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
 201         Update.
 202         * python/python.c (gdbpy_get_current_progspace): Update.
 203         (gdbpy_progspaces): Update.
 204         * python/py-progspace.c (pspace_to_pspace_object): Return a new
 205         reference.
 206         * python/py-objfile.c (objfpy_get_progspace): Update.
 207         * python/py-prettyprint.c (find_pretty_printer_from_progspace):
 208         Update.
 209
 210 2018-09-16  Tom Tromey  <tom@tromey.com>
 211
 212         * python/lib/gdb/__init__.py (current_progspace, objfiles)
 213         (solib_name, block_for_pc, find_pc_line): New functions.
 214         (execute_unwinders): Update.
 215         * python/py-block.c (gdbpy_block_for_pc): Remove.
 216         * python/py-inferior.c (infpy_get_progspace): New function.
 217         (inferior_object_getset) <progspace>: Add.
 218         * python/py-progspace.c (pspy_objfiles): Rewrite.
 219         (pspy_solib_name, pspy_block_for_pc)
 220         (pspy_find_pc_line, pspy_is_valid): New functions.
 221         (progspace_object_methods): Add entries for solib_name,
 222         block_for_pc, find_pc_line, is_valid.
 223         * python/python-internal.h (gdbpy_block_for_pc)
 224         (build_objfiles_list): Don't declare.
 225         * python/python.c: Don't include solib.h.
 226         (gdbpy_solib_name, gdbpy_find_pc_line)
 227         (gdbpy_get_current_progspace, build_objfiles_list)
 228         (gdbpy_objfiles): Remove.
 229         (GdbMethods) <current_progspace, objfiles, block_for_pc,
 230         solib_name, find_pc_line>: Remove entries.
 231
 232 2018-09-16  Tom Tromey  <tom@tromey.com>
 233
 234         * top.c (new_ui_command): Use GNU style for metasyntactic
 235         variables.
 236         * breakpoint.c (stopat_command): Use GNU style for metasyntactic
 237         variables.
 238         * maint.c (maintenance_translate_address): Remove "<>" around
 239         text.
 240         * interps.c (interpreter_exec_cmd): Use GNU style for
 241         metasyntactic variables.
 242         * nto-procfs.c (nto_procfs_target_info): Use GNU style for
 243         metasyntactic variables.
 244         * tracepoint.c (tfind_range_command): Use GNU style for
 245         metasyntactic variables.
 246         (tfind_outside_command): Likewise.
 247         (_initialize_tracepoint): Likewise.
 248         * remote.c (extended_remote_target::create_inferior): Use GNU
 249         style for metasyntactic variables.
 250         * sparc64-tdep.c (adi_examine_command): Use GNU style for
 251         metasyntactic variables.
 252         (adi_assign_command): Likewise.
 253
 254 2018-09-16  Tom Tromey  <tom@tromey.com>
 255
 256         * disasm.c (show_disassembler_options_sfunc): Use GNU style for
 257         metasyntactic variables.  Print message if no disassembler options
 258         are available.
 259
 260 2018-09-15  Tom Tromey  <tom@tromey.com>
 261
 262         * infcmd.c (get_inferior_args): Return const char *.
 263         * inferior.h (get_inferior_args): Return type now const.
 264         * linux-tdep.c (linux_fill_prpsinfo): Update.
 265         * procfs.c (procfs_target::make_corefile_notes): Update.
 266
 267 2018-09-07  Tom Tromey  <tom@tromey.com>
 268
 269         * python/python.c (execute_gdb_command): Call bpstat_do_actions
 270         inside the TRY.
 271
 272 2018-09-14  Sandra Loosemore  <sandra@codesourcery.com>
 273
 274         * nios2-tdep.c (nios2_type_align): New.
 275         (nios2_gdb_arch_init): Install type_align hook.
 276
 277 2018-09-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 278
 279         * eval.c (fake_method::fake_method): Call xzalloc directly for a
 280         type that is neither object file owned, nor gdbarch owned.
 281         * gdbtypes.c (get_type_gdbarch): Add an assert that returned
 282         gdbarch is non-NULL.
 283         (alloc_type_instance): Allocate non-objfile owned types on the
 284         gdbarch obstack.
 285         (copy_type_recursive): Allocate TYPE_FIELDS and TYPE_RANGE_DATA
 286         using TYPE_ALLOC to ensure memory is allocated on the correct
 287         obstack.
 288         * gdbtypes.h (TYPE_ALLOC): Allocate space on either the objfile
 289         obstack, or the gdbarch obstack.
 290         (TYPE_ZALLOC): Rewrite using TYPE_ALLOC.
 291
 292 2018-09-14  Tom Tromey  <tom@tromey.com>
 293
 294         * infcall.c (call_function_by_hand_dummy): Remove unnecessary
 295         block.
 296
 297 2018-09-14  Tom Tromey  <tom@tromey.com>
 298
 299         * nat/fork-inferior.c (get_startup_shell): Remove "static".
 300
 301 2018-09-13  Tom Tromey  <tom@tromey.com>
 302
 303         * python/py-inferior.c (infpy_thread_from_thread_handle): Now
 304         static.
 305
 306 2018-09-13  Tom Tromey  <tom@tromey.com>
 307
 308         * exec.c (try_open_exec_file): Use std::string.
 309
 310 2018-09-13  Tom Tromey  <tom@tromey.com>
 311
 312         * utils.h (gdb_bfd_errmsg): Return std::string.
 313         * exec.c (exec_file_attach): Update.
 314         * compile/compile-object-load.c (compile_object_load): Update.
 315         * utils.c (gdb_bfd_errmsg): Return std::string.
 316
 317 2018-09-13  Tom Tromey  <tom@tromey.com>
 318
 319         * procfs.c (struct procinfo_deleter): New.
 320         (procinfo_up): New typedef.
 321         (do_destroy_procinfo_cleanup): Remove.
 322         (procfs_target::info_proc): Use procinfo_up.  Remove cleanups.
 323
 324 2018-09-13  Tom Tromey  <tom@tromey.com>
 325
 326         * source.c (add_path): Use gdb::unique_xmalloc_ptr.
 327
 328 2018-09-13  Simon Marchi  <simon.marchi@ericsson.com>
 329 2018-09-13  Tom Tromey  <tom@tromey.com>
 330
 331         * python/py-progspace.c (PSPY_REQUIRE_VALID): New macro.
 332         (pspy_get_objfiles): New function.
 333         (progspace_object_methods): New.
 334         (pspace_object_type): Add tp_methods callback.
 335         * python/python-internal.h (build_objfiles_list): New
 336         declaration.
 337         * python/python.c (build_objfiles_list): New function.
 338         (gdbpy_objfiles): Implement using build_objfiles_list.
 339         * NEWS: Mention the Progspace.objfiles method.
 340
 341 2018-09-13  Simon Marchi  <simon.marchi@ericsson.com>
 342
 343         * python/py-inferior.c (infpy_get_progspace): New function.
 344         (inferior_object_getset): Add progspace property.
 345         * NEWS: Mention the new property.
 346
 347 2018-09-13  Tom Tromey  <tom@tromey.com>
 348
 349         PR rust/23650:
 350         * rust-lang.c (rust_evaluate_subexp): Use field name, not "foo".
 351
 352 2018-09-13  Tom Tromey  <tom@tromey.com>
 353
 354         PR rust/23626:
 355         * rust-lang.c (rust_enum_variant): Now static.
 356         (rust_empty_enum_p): New function.
 357         (rust_print_enum, rust_evaluate_subexp, rust_print_struct_def):
 358         Handle empty enum.
 359
 360 2018-09-13  Simon Marchi  <simon.marchi@ericsson.com>
 361
 362         * python/py-inferior.c (infpy_repr): New.
 363         (inferior_object_type): Register infpy_repr.
 364         * python/py-objfile.c (objfpy_repr): New.
 365         (objfile_object_type): Register objfpy_repr.
 366
 367 2018-09-12  John Baldwin  <jhb@FreeBSD.org>
 368
 369         * fbsd-nat.c (fbsd_nat_target::info_proc): Remove unused variable.
 370
 371 2018-09-12  John Baldwin  <jhb@FreeBSD.org>
 372
 373         * aarch64-fbsd-tdep.h (AARCH64_FBSD_SIZEOF_GREGSET): Fix comment
 374         typo.
 375
 376 2018-09-12  Sergio Durigan Junior  <sergiodj@redhat.com>
 377
 378         * common/common-utils.c: Don't include '<sys/stat.h>'.
 379         (is_regular_file): Move to...
 380         * common/filestuff.c (is_regular_file): ... here.
 381         * common/common-utils.h (is_regular_file): Move to...
 382         * common/filestuff.h (is_regular_file): ... here.
 383
 384 2018-09-12  Simon Marchi  <simon.marchi@ericsson.com>
 385
 386         * skip.c (debug_skip): New variable.
 387         (skiplist_entry::do_skip_file_p): Add debug output.
 388         (skiplist_entry::do_skip_gfile_p): Likewise.
 389         (skiplist_entry::skip_function_p): Likewise.
 390         (_initialize_step_skip): Create debug command.
 391         * NEWS: Mention set/show debug skip.
 392
 393 2018-09-11  Xavier Roirand  <roirand@adacore.com>
 394
 395         * darwin-nat.c (should_disable_startup_with_shell):
 396         New function.
 397         (darwin_nat_target::create_inferior): Add call.
 398
 399 2018-09-11  Xavier Roirand  <roirand@adacore.com>
 400
 401         * darwin-nat.h (struct darwin_thread_info) <gdb_port,
 402         inf_port, msg_state>: Initialize.
 403         (struct darwin_thread_info) <signaled, single_step>: Change
 404         type and initialize.
 405         (struct darwin_thread_info) <event>: Initialize.
 406
 407 2018-09-10  Sergio Durigan Junior  <sergiodj@redhat.com>
 408
 409         PR gdb/23555
 410         PR gdb/23558
 411         * gnulib/import/m4/getcwd-path-max.m4: Add cross-compilation
 412         guesses.
 413
 414 2018-09-10  Sergio Durigan Junior  <sergiodj@redhat.com>
 415
 416         Revert:
 417         2018-08-29  Sergio Durigan Junior  <sergiodj@redhat.com>
 418
 419         PR gdb/23555
 420         PR gdb/23558
 421         * gnulib/aclocal.m4: Regenerate.
 422         * gnulib/config.in: Regenerate.
 423         * gnulib/configure: Regenerate.
 424         * gnulib/import/Makefile.am: Update.
 425         * gnulib/import/Makefile.in: Update.
 426         * gnulib/import/extra/snippet/_Noreturn.h: Rename to...
 427         * gnulib/import/_Noreturn.h: ... this.
 428         * gnulib/import/alloca.in.h: Update.
 429         * gnulib/import/extra/snippet/arg-nonnull.h: Rename to...
 430         * gnulib/import/arg-nonnull.h: ... this.
 431         * gnulib/import/assure.h: Update.
 432         * gnulib/import/at-func.c: Update.
 433         * gnulib/import/basename-lgpl.c: Update.
 434         * gnulib/import/extra/snippet/c++defs.h: Rename to...
 435         * gnulib/import/c++defs.h: ... this.
 436         * gnulib/import/canonicalize-lgpl.c: Update.
 437         * gnulib/import/cdefs.h: Update.
 438         * gnulib/import/chdir-long.c: Update.
 439         * gnulib/import/chdir-long.h: Update.
 440         * gnulib/import/cloexec.c: Update.
 441         * gnulib/import/cloexec.h: Update.
 442         * gnulib/import/close.c: Update.
 443         * gnulib/import/closedir.c: Update.
 444         * gnulib/import/config.charset: Update.
 445         * gnulib/import/dirent-private.h: Update.
 446         * gnulib/import/dirent.in.h: Update.
 447         * gnulib/import/dirfd.c: Update.
 448         * gnulib/import/dirname-lgpl.c: Update.
 449         * gnulib/import/dirname.h: Update.
 450         * gnulib/import/dosname.h: Update.
 451         * gnulib/import/dup-safer-flag.c: Update.
 452         * gnulib/import/dup-safer.c: Update.
 453         * gnulib/import/dup.c: Update.
 454         * gnulib/import/dup2.c: Update.
 455         * gnulib/import/errno.in.h: Update.
 456         * gnulib/import/error.c: Update.
 457         * gnulib/import/error.h: Update.
 458         * gnulib/import/exitfail.c: Update.
 459         * gnulib/import/exitfail.h: Update.
 460         * gnulib/import/extra/update-copyright: Update.
 461         * gnulib/import/fchdir.c: Update.
 462         * gnulib/import/fcntl.c: Update.
 463         * gnulib/import/fcntl.in.h: Update.
 464         * gnulib/import/fd-hook.c: Update.
 465         * gnulib/import/fd-hook.h: Update.
 466         * gnulib/import/fd-safer-flag.c: Update.
 467         * gnulib/import/fd-safer.c: Update.
 468         * gnulib/import/fdopendir.c: Update.
 469         * gnulib/import/filename.h: Update.
 470         * gnulib/import/filenamecat-lgpl.c: Update.
 471         * gnulib/import/filenamecat.h: Update.
 472         * gnulib/import/flexmember.h: Update.
 473         * gnulib/import/float+.h: Update.
 474         * gnulib/import/float.c: Update.
 475         * gnulib/import/float.in.h: Update.
 476         * gnulib/import/fnmatch.c: Update.
 477         * gnulib/import/fnmatch.in.h: Update.
 478         * gnulib/import/fnmatch_loop.c: Update.
 479         * gnulib/import/fpucw.h: Update.
 480         * gnulib/import/frexp.c: Update.
 481         * gnulib/import/frexpl.c: Update.
 482         * gnulib/import/fstat.c: Update.
 483         * gnulib/import/fstatat.c: Update.
 484         * gnulib/import/getcwd-lgpl.c: Update.
 485         * gnulib/import/getcwd.c: Update.
 486         * gnulib/import/getdtablesize.c: Update.
 487         * gnulib/import/getlogin_r.c: Update.
 488         * gnulib/import/getprogname.c: Update.
 489         * gnulib/import/getprogname.h: Update.
 490         * gnulib/import/gettext.h: Update.
 491         * gnulib/import/gettimeofday.c: Update.
 492         * gnulib/import/glob-libc.h: Update.
 493         * gnulib/import/glob.c: Update.
 494         * gnulib/import/glob.in.h: Update.
 495         * gnulib/import/glob_internal.h: Update.
 496         * gnulib/import/glob_pattern_p.c: Update.
 497         * gnulib/import/globfree.c: Update.
 498         * gnulib/import/hard-locale.c: Update.
 499         * gnulib/import/hard-locale.h: Update.
 500         * gnulib/import/intprops.h: Update.
 501         * gnulib/import/inttypes.in.h: Update.
 502         * gnulib/import/isnan.c: Update.
 503         * gnulib/import/isnand-nolibm.h: Update.
 504         * gnulib/import/isnand.c: Update.
 505         * gnulib/import/isnanl-nolibm.h: Update.
 506         * gnulib/import/isnanl.c: Update.
 507         * gnulib/import/itold.c: Update.
 508         * gnulib/import/libc-config.h: Update.
 509         * gnulib/import/limits.in.h: Update.
 510         * gnulib/import/localcharset.c: Update.
 511         * gnulib/import/localcharset.h: Update.
 512         * gnulib/import/localtime-buffer.c: Update.
 513         * gnulib/import/localtime-buffer.h: Update.
 514         * gnulib/import/lstat.c: Update.
 515         * gnulib/import/m4/00gnulib.m4: Update.
 516         * gnulib/import/m4/__inline.m4: Update.
 517         * gnulib/import/m4/absolute-header.m4: Update.
 518         * gnulib/import/m4/alloca.m4: Update.
 519         * gnulib/import/m4/builtin-expect.m4: Update.
 520         * gnulib/import/m4/canonicalize.m4: Update.
 521         * gnulib/import/m4/chdir-long.m4: Update.
 522         * gnulib/import/m4/close.m4: Update.
 523         * gnulib/import/m4/closedir.m4: Update.
 524         * gnulib/import/m4/configmake.m4: Update.
 525         * gnulib/import/m4/d-ino.m4: Update.
 526         * gnulib/import/m4/d-type.m4: Update.
 527         * gnulib/import/m4/dirent_h.m4: Update.
 528         * gnulib/import/m4/dirfd.m4: Update.
 529         * gnulib/import/m4/dirname.m4: Update.
 530         * gnulib/import/m4/double-slash-root.m4: Update.
 531         * gnulib/import/m4/dup.m4: Update.
 532         * gnulib/import/m4/dup2.m4: Update.
 533         * gnulib/import/m4/eealloc.m4: Update.
 534         * gnulib/import/m4/environ.m4: Update.
 535         * gnulib/import/m4/errno_h.m4: Update.
 536         * gnulib/import/m4/error.m4: Update.
 537         * gnulib/import/m4/exponentd.m4: Update.
 538         * gnulib/import/m4/exponentl.m4: Update.
 539         * gnulib/import/m4/extensions.m4: Update.
 540         * gnulib/import/m4/extern-inline.m4: Update.
 541         * gnulib/import/m4/fchdir.m4: Update.
 542         * gnulib/import/m4/fcntl-o.m4: Update.
 543         * gnulib/import/m4/fcntl.m4: Update.
 544         * gnulib/import/m4/fcntl_h.m4: Update.
 545         * gnulib/import/m4/fdopendir.m4: Update.
 546         * gnulib/import/m4/filenamecat.m4: Update.
 547         * gnulib/import/m4/flexmember.m4: Update.
 548         * gnulib/import/m4/float_h.m4: Update.
 549         * gnulib/import/m4/fnmatch.m4: Update.
 550         * gnulib/import/m4/fnmatch_h.m4: Update.
 551         * gnulib/import/m4/fpieee.m4: Update.
 552         * gnulib/import/m4/frexp.m4: Update.
 553         * gnulib/import/m4/frexpl.m4: Update.
 554         * gnulib/import/m4/fstat.m4: Update.
 555         * gnulib/import/m4/fstatat.m4: Update.
 556         * gnulib/import/m4/getcwd-abort-bug.m4: Update.
 557         * gnulib/import/m4/getcwd-path-max.m4: Update.
 558         * gnulib/import/m4/getcwd.m4: Update.
 559         * gnulib/import/m4/getdtablesize.m4: Update.
 560         * gnulib/import/m4/getlogin.m4: Update.
 561         * gnulib/import/m4/getlogin_r.m4: Update.
 562         * gnulib/import/m4/getpagesize.m4: Update.
 563         * gnulib/import/m4/getprogname.m4: Update.
 564         * gnulib/import/m4/gettimeofday.m4: Update.
 565         * gnulib/import/m4/glibc21.m4: Update.
 566         * gnulib/import/m4/glob.m4: Update.
 567         * gnulib/import/m4/glob_h.m4: Update.
 568         * gnulib/import/m4/gnulib-cache.m4: Update.
 569         * gnulib/import/m4/gnulib-common.m4: Update.
 570         * gnulib/import/m4/gnulib-comp.m4: Update.
 571         * gnulib/import/m4/gnulib-tool.m4: Update.
 572         * gnulib/import/m4/hard-locale.m4: Update.
 573         * gnulib/import/m4/include_next.m4: Update.
 574         * gnulib/import/m4/inttypes-pri.m4: Update.
 575         * gnulib/import/m4/inttypes.m4: Update.
 576         * gnulib/import/m4/isnand.m4: Update.
 577         * gnulib/import/m4/isnanl.m4: Update.
 578         * gnulib/import/m4/largefile.m4: Update.
 579         * gnulib/import/m4/limits-h.m4: Update.
 580         * gnulib/import/m4/localcharset.m4: Update.
 581         * gnulib/import/m4/locale-fr.m4: Update.
 582         * gnulib/import/m4/locale-ja.m4: Update.
 583         * gnulib/import/m4/locale-zh.m4: Update.
 584         * gnulib/import/m4/localtime-buffer.m4: Update.
 585         * gnulib/import/m4/longlong.m4: Update.
 586         * gnulib/import/m4/lstat.m4: Update.
 587         * gnulib/import/m4/malloc.m4: Update.
 588         * gnulib/import/m4/malloca.m4: Update.
 589         * gnulib/import/m4/math_h.m4: Update.
 590         * gnulib/import/m4/mbrtowc.m4: Update.
 591         * gnulib/import/m4/mbsinit.m4: Update.
 592         * gnulib/import/m4/mbsrtowcs.m4: Update.
 593         * gnulib/import/m4/mbstate_t.m4: Update.
 594         * gnulib/import/m4/memchr.m4: Update.
 595         * gnulib/import/m4/memmem.m4: Update.
 596         * gnulib/import/m4/mempcpy.m4: Update.
 597         * gnulib/import/m4/memrchr.m4: Update.
 598         * gnulib/import/m4/mkdir.m4: Update.
 599         * gnulib/import/m4/mkstemp.m4: Update.
 600         * gnulib/import/m4/mmap-anon.m4: Update.
 601         * gnulib/import/m4/mode_t.m4: Update.
 602         * gnulib/import/m4/msvc-inval.m4: Update.
 603         * gnulib/import/m4/msvc-nothrow.m4: Update.
 604         * gnulib/import/m4/multiarch.m4: Update.
 605         * gnulib/import/m4/nocrash.m4: Update.
 606         * gnulib/import/m4/off_t.m4: Update.
 607         * gnulib/import/m4/onceonly.m4: Update.
 608         * gnulib/import/m4/open-cloexec.m4: Update.
 609         * gnulib/import/m4/open.m4: Update.
 610         * gnulib/import/m4/openat.m4: Update.
 611         * gnulib/import/m4/opendir.m4: Update.
 612         * gnulib/import/m4/pathmax.m4: Update.
 613         * gnulib/import/m4/rawmemchr.m4: Update.
 614         * gnulib/import/m4/readdir.m4: Update.
 615         * gnulib/import/m4/readlink.m4: Update.
 616         * gnulib/import/m4/realloc.m4: Update.
 617         * gnulib/import/m4/rename.m4: Update.
 618         * gnulib/import/m4/rewinddir.m4: Update.
 619         * gnulib/import/m4/rmdir.m4: Update.
 620         * gnulib/import/m4/save-cwd.m4: Update.
 621         * gnulib/import/m4/secure_getenv.m4: Update.
 622         * gnulib/import/m4/setenv.m4: Update.
 623         * gnulib/import/m4/signal_h.m4: Update.
 624         * gnulib/import/m4/ssize_t.m4: Update.
 625         * gnulib/import/m4/stat-time.m4: Update.
 626         * gnulib/import/m4/stat.m4: Update.
 627         * gnulib/import/m4/std-gnu11.m4: Update.
 628         * gnulib/import/m4/stdbool.m4: Update.
 629         * gnulib/import/m4/stddef_h.m4: Update.
 630         * gnulib/import/m4/stdint.m4: Update.
 631         * gnulib/import/m4/stdio_h.m4: Update.
 632         * gnulib/import/m4/stdlib_h.m4: Update.
 633         * gnulib/import/m4/strchrnul.m4: Update.
 634         * gnulib/import/m4/strdup.m4: Update.
 635         * gnulib/import/m4/strerror.m4: Update.
 636         * gnulib/import/m4/string_h.m4: Update.
 637         * gnulib/import/m4/strstr.m4: Update.
 638         * gnulib/import/m4/strtok_r.m4: Update.
 639         * gnulib/import/m4/sys_socket_h.m4: Update.
 640         * gnulib/import/m4/sys_stat_h.m4: Update.
 641         * gnulib/import/m4/sys_time_h.m4: Update.
 642         * gnulib/import/m4/sys_types_h.m4: Update.
 643         * gnulib/import/m4/tempname.m4: Update.
 644         * gnulib/import/m4/time_h.m4: Update.
 645         * gnulib/import/m4/unistd-safer.m4: Update.
 646         * gnulib/import/m4/unistd_h.m4: Update.
 647         * gnulib/import/m4/warn-on-use.m4: Update.
 648         * gnulib/import/m4/wchar_h.m4: Update.
 649         * gnulib/import/m4/wchar_t.m4: Update.
 650         * gnulib/import/m4/wctype_h.m4: Update.
 651         * gnulib/import/m4/wint_t.m4: Update.
 652         * gnulib/import/malloc.c: Update.
 653         * gnulib/import/malloc/scratch_buffer.h: Update.
 654         * gnulib/import/malloc/scratch_buffer_grow.c: Update.
 655         * gnulib/import/malloc/scratch_buffer_grow_preserve.c: Update.
 656         * gnulib/import/malloc/scratch_buffer_set_array_size.c: Update.
 657         * gnulib/import/malloca.c: Update.
 658         * gnulib/import/malloca.h: Update.
 659         * gnulib/import/malloca.valgrind: Update.
 660         * gnulib/import/math.in.h: Update.
 661         * gnulib/import/mbrtowc.c: Update.
 662         * gnulib/import/mbsinit.c: Update.
 663         * gnulib/import/mbsrtowcs-impl.h: Update.
 664         * gnulib/import/mbsrtowcs-state.c: Update.
 665         * gnulib/import/mbsrtowcs.c: Update.
 666         * gnulib/import/memchr.c: Update.
 667         * gnulib/import/memmem.c: Update.
 668         * gnulib/import/mempcpy.c: Update.
 669         * gnulib/import/memrchr.c: Update.
 670         * gnulib/import/mkdir.c: Update.
 671         * gnulib/import/mkstemp.c: Update.
 672         * gnulib/import/msvc-inval.c: Update.
 673         * gnulib/import/msvc-inval.h: Update.
 674         * gnulib/import/msvc-nothrow.c: Update.
 675         * gnulib/import/msvc-nothrow.h: Update.
 676         * gnulib/import/open.c: Update.
 677         * gnulib/import/openat-die.c: Update.
 678         * gnulib/import/openat-priv.h: Update.
 679         * gnulib/import/openat-proc.c: Update.
 680         * gnulib/import/openat.c: Update.
 681         * gnulib/import/openat.h: Update.
 682         * gnulib/import/opendir.c: Update.
 683         * gnulib/import/pathmax.h: Update.
 684         * gnulib/import/pipe-safer.c: Update.
 685         * gnulib/import/rawmemchr.c: Update.
 686         * gnulib/import/readdir.c: Update.
 687         * gnulib/import/readlink.c: Update.
 688         * gnulib/import/realloc.c: Update.
 689         * gnulib/import/ref-add.sin: Update.
 690         * gnulib/import/ref-del.sin: Update.
 691         * gnulib/import/rename.c: Update.
 692         * gnulib/import/rewinddir.c: Update.
 693         * gnulib/import/rmdir.c: Update.
 694         * gnulib/import/same-inode.h: Update.
 695         * gnulib/import/save-cwd.c: Update.
 696         * gnulib/import/save-cwd.h: Update.
 697         * gnulib/import/scratch_buffer.h: Update.
 698         * gnulib/import/secure_getenv.c: Update.
 699         * gnulib/import/setenv.c: Update.
 700         * gnulib/import/signal.in.h: Update.
 701         * gnulib/import/stat-time.c: Update.
 702         * gnulib/import/stat-time.h: Update.
 703         * gnulib/import/stat-w32.c: Update.
 704         * gnulib/import/stat-w32.h: Update.
 705         * gnulib/import/stat.c: Update.
 706         * gnulib/import/stdbool.in.h: Update.
 707         * gnulib/import/stddef.in.h: Update.
 708         * gnulib/import/stdint.in.h: Update.
 709         * gnulib/import/stdio.in.h: Update.
 710         * gnulib/import/stdlib.in.h: Update.
 711         * gnulib/import/str-two-way.h: Update.
 712         * gnulib/import/strchrnul.c: Update.
 713         * gnulib/import/strdup.c: Update.
 714         * gnulib/import/streq.h: Update.
 715         * gnulib/import/strerror-override.c: Update.
 716         * gnulib/import/strerror-override.h: Update.
 717         * gnulib/import/strerror.c: Update.
 718         * gnulib/import/string.in.h: Update.
 719         * gnulib/import/stripslash.c: Update.
 720         * gnulib/import/strnlen1.c: Update.
 721         * gnulib/import/strnlen1.h: Update.
 722         * gnulib/import/strstr.c: Update.
 723         * gnulib/import/strtok_r.c: Update.
 724         * gnulib/import/sys_stat.in.h: Update.
 725         * gnulib/import/sys_time.in.h: Update.
 726         * gnulib/import/sys_types.in.h: Update.
 727         * gnulib/import/tempname.c: Update.
 728         * gnulib/import/tempname.h: Update.
 729         * gnulib/import/time.in.h: Update.
 730         * gnulib/import/unistd--.h: Update.
 731         * gnulib/import/unistd-safer.h: Update.
 732         * gnulib/import/unistd.in.h: Update.
 733         * gnulib/import/unsetenv.c: Update.
 734         * gnulib/import/verify.h: Update.
 735         * gnulib/import/extra/snippet/warn-on-use.h: Update.
 736         * gnulib/import/wchar.in.h: Update.
 737         * gnulib/import/wctype.in.h: Update.
 738         * gnulib/import/xalloc-oversized.h: Update.
 739         * gnulib/update-gnulib.sh (GNULIB_COMMIT_SHA1): Set to
 740         "53e2c179f26a890fa6685af4b6c1397ee370433b".
 741
 742 2018-09-10  Simon Marchi  <simon.marchi@ericsson.com>
 743
 744         * record-btrace.c (get_thread_current_frame): Remove
 745         old_inferior_ptid.
 746
 747 2018-09-10  Jerome Guitton  <guitton@adacore.com>
 748
 749         * ada-lang.c (ada_value_struct_elt): Call ada_to_fixed_type
 750         with check_tag to 1 if and only if the type is tagged and the
 751         component being searched cannot been found in the current
 752         view. Otherwise, always call ada_to_fixed_type with
 753         check_tag to 0.
 754
 755 2018-09-10  Xavier Roirand  <roirand@adacore.com>
 756
 757         * ada-lang.c (ada_is_access_to_unconstrained_array): Remove static
 758         declaration.
 759         * ada-lang.h: add ada_is_access_to_unconstrained_array prototype.
 760         * ada-varobj.c (ada_varobj_get_number_of_children,
 761         ada_varobj_describe_child, ada_value_is_changeable_p): Cleanup code.
 762
 763 2018-09-10  Xavier Roirand  <roirand@adacore.com>
 764
 765         * ada-valprint.c (ada_value_print): Use type instead of
 766         enclosing type.
 767
 768 2018-09-10  Xavier Roirand  <roirand@adacore.com>
 769
 770         * ada-lang.c (ada_value_subscript): Handle case when parameter is
 771         an array of access to unconstrained array.
 772
 773 2018-09-10  Xavier Roirand  <roirand@adacore.com>
 774
 775         * ada-lang.c (ada_is_access_to_unconstrained_array): New function.
 776         (ada_check_typedef): Use it.
 777
 778 2018-09-10  Xavier Roirand  <roirand@adacore.com>
 779
 780         * ada-varobj.c (ada_varobj_describe_struct_child)
 781         (ada_varobj_describe_child): Handle union case like struct one.
 782
 783 2018-09-10  Tom Tromey  <tom@tromey.com>
 784
 785         PR python/18380:
 786         * python/python.c (_initialize_python): Make example in "python"
 787         help work in Python 3.
 788
 789 2018-09-10  Eli Zaretskii  <eliz@gnu.org>
 790
 791         * Makefile.in (transformed_name): Use INSTALL_SCRIPT instead of
 792         INSTALL_PROGRAM to install gdb-add-index.sh.  Don't append
 793         $(EXEEXT) to the script, as it is not a program.
 794
 795 2018-09-09  Simon Marchi  <simon.marchi@ericsson.com>
 796
 797         * python/py-prettyprint.c (pretty_print_one_value): Return
 798         gdbpy_ref<>.
 799         (print_string_repr): Adjust.
 800         (apply_varobj_pretty_printer): Return gdbpy_ref<>.
 801         * python/python-internal.h (apply_varobj_pretty_printer): Return
 802         gdbpy_ref<>.
 803         * varobj.c (varobj_value_get_print_value): Adjust.
 804
 805 2018-09-08  Tom Tromey  <tom@tromey.com>
 806
 807         PR python/16047:
 808         * python/py-prettyprint.c (pretty_print_one_value): Check for
 809         to_string method.
 810
 811 2018-09-08  Joel Brobecker  <brobecker@adacore.com>
 812
 813         * ada-lang.c (resolve_subexp): Pass correct OPLEN in call to
 814         replace_operator_with_call.
 815
 816 2018-09-08  Joel Brobecker  <brobecker@adacore.com>
 817
 818         * ada-lang.c (ada_value_cast): Remove unnecessary parentheses.
 819
 820 2018-09-08  Joel Brobecker  <brobecker@adacore.com>
 821
 822         * ada-typeprint.c (print_range): Print the bounds using TYPE
 823         rather than its TYPE_TARGET_TYPE.
 824
 825 2018-09-08  Joel Brobecker  <brobecker@adacore.com>
 826
 827         * ada-lang.c (ada_to_fixed_value): Minor reformatting in
 828         call to ada_to_fixed_value_create.
 829
 830 2018-09-08  Jerome Guitton  <guitton@adacore.com>
 831
 832         * ada-lang.c (ada_decode): strip dot prefix in symbol name.
 833
 834 2018-09-08  Joel Brobecker  <brobecker@adacore.com>
 835
 836         * ada-lang.c (ada_exception_sal): Replace gdb_assert calls
 837         by calls to error.
 838
 839 2018-09-08  Joel Brobecker  <brobecker@adacore.com>
 840
 841         * ada-lang.c (ada_unhandled_exception_name_addr_from_raise):
 842         Move update of loop variable "fi".
 843
 844 2018-09-08  Joel Brobecker  <brobecker@adacore.com>
 845
 846         * ada-lang.c (value_assign_to_component): In the case of
 847         big-endian targets, extract the bits of the given VAL
 848         using an src_offset of zero if container is not a scalar.
 849
 850 2018-09-06  Simon Ser  <contact@emersion.fr>
 851
 852         PR gdb/23105
 853         * fbsd-nat.c (fbsd_nat_target::xfer_partial): Add support for
 854         TARGET_OBJECT_FREEBSD_VMMAP and TARGET_OBJECT_FREEBSD_PS_STRINGS.
 855         * fbsd-tdep.c (fbsd_make_note_desc): New.
 856         (fbsd_make_corefile_notes): Write NT_PROCSTAT_AUXV,
 857         NT_PROCSTAT_VMMAP and NT_PROCSTAT_PS_STRINGS notes.
 858         * target.h (enum target_object) Add FreeBSD-specific
 859         TARGET_OBJECT_FREEBSD_VMMAP and TARGET_OBJECT_FREEBSD_PS_STRINGS.
 860
 861 2018-09-06  Simon Marchi  <simon.marchi@ericsson.com>
 862
 863         * compile/compile-c.h (generate_c_for_variable_locations):
 864         Change reference to pointer.
 865         * compile/compile-c-support.c (compile_program) <compute>:
 866         Likewise.
 867         * compile/compile-c-symbols.c (generate_vla_size): Likewise.
 868         (generate_c_for_for_one_variable): Likewise
 869         (generate_c_for_variable_locations): Likewise
 870         * compile/compile-c-types.c (compile_c_instance::convert_type):
 871         Likewise
 872         * compile/compile-cplus-symbols.c (convert_one_symbol):
 873         std::move the scope passed to enter_scope.
 874         * compile/compile-cplus-types.c
 875         (compile_cplus_instance::enter_scope): Make parameter
 876         rvalue-reference.
 877         (compile_cplus_instance::new_scope): Change reference to
 878         pointer.
 879         (compile_cplus_instance::convert_type): Likewise
 880         (compile_cplus_convert_typedef): std::move the scope passed to
 881         enter_scope.
 882         (compile_cplus_convert_struct_or_union): Likewise.
 883         (compile_cplus_convert_enum): Likewise.
 884         (compile_cplus_convert_namespace): Likewise.
 885         * compile/compile-cplus.h (compile_cplus_instance)
 886         <enter_scope>: Make parameter rvalue-reference.
 887         * compile/compile-internal.h (compile_instance)
 888         <get_cached_type>: Likewise
 889         * compile/compile-loc2c.c (push): Likewise
 890         (pushf): Likewise
 891         (unary): Likewise
 892         (binary): Likewise
 893         (print_label): Likewise
 894         (pushf_register_address): Likewise
 895         (pushf_register): Likewise
 896         (do_compile_dwarf_expr_to_c): Likewise
 897         (compile_dwarf_expr_to_c): Likewise
 898         (compile_dwarf_bounds_to_c): Likewise
 899         * compile/compile.c (compile_instance::get_cached_type):
 900         Likewise
 901         * compile/compile.h (compile_dwarf_expr_to_c): Likewise.
 902         (compile_dwarf_bounds_to_c): Likewise
 903         * dwarf2loc.c (locexpr_generate_c_location): Likewise.
 904         (dwarf2_compile_property_to_c): Likewise
 905         * dwarf2loc.h (dwarf2_compile_property_to_c): Likewise
 906         * symtab.h (struct symbol_computed_ops) <generate_c_location>:
 907         Likewise
 908
 909 2018-09-06  Simon Marchi  <simon.marchi@ericsson.com>
 910
 911         * tui/tui-data.h (struct tui_win_element) <highlight>: Remove.
 912         * tui/tui-data.c (init_content_element): Don't initialize it.
 913
 914 2018-09-06  Simon Marchi  <simon.marchi@ericsson.com>
 915
 916         * tui/tui-data.h (struct tui_win_info)
 917         <detail::opaque>: Remove.
 918         * tui/tui-data.c (init_win_info): Remove assignment.
 919
 920 2018-09-05  Tom Tromey  <tom@tromey.com>
 921
 922         * warning.m4 (AM_GDB_WARNINGS): Add -Wformat when testing
 923         -Wformat-nonliteral.
 924         * target-float.c (host_float_ops<T>::to_string)
 925         (host_float_ops<T>::from_string): Use
 926         DIAGNOSTIC_IGNORE_FORMAT_NONLITERAL.
 927         * configure: Rebuild.
 928
 929 2018-09-05  Simon Marchi  <simon.marchi@ericsson.com>
 930
 931         * printcmd.c (printf_c_string): Use
 932         DIAGNOSTIC_IGNORE_FORMAT_NONLITERAL.
 933         (printf_wide_c_string, printf_pointer, ui_printf): Likewise.
 934
 935 2018-09-05  Tom Tromey  <tom@tromey.com>
 936
 937         * cli/cli-cmds.c (shell_escape, edit_command): Remove cast.
 938
 939 2018-09-05  Tom de Vries  <tdevries@suse.de>
 940
 941         * dwarf2loc.c (sect_variable_value): Call indirect_synthetic_pointer
 942         with resolve_abstract_p == true.
 943         (indirect_synthetic_pointer): Add resolve_abstract_p parameter,
 944         defaulting to false. Propagate resolve_abstract_p to
 945         dwarf2_fetch_die_loc_sect_off.
 946         * dwarf2loc.h (dwarf2_fetch_die_loc_sect_off): Add resolve_abstract_p
 947         parameter, defaulting to false.
 948         * dwarf2read.c (read_variable): Add variable to abstract_to_concrete.
 949         (dwarf2_fetch_die_loc_sect_off): Add and handle resolve_abstract_p
 950         parameter.
 951         * dwarf2read.h (struct die_info): Forward-declare.
 952         (die_info_ptr): New typedef.
 953         (struct dwarf2_per_objfile): Add abstract_to_concrete field.
 954
 955 2018-09-05  Joel Brobecker  <brobecker@adacore.com>
 956
 957         GDB 8.2 released.
 958
 959 2018-09-04  Sergio Durigan Junior  <sergiodj@redhat.com>
 960             Pedro Alves  <palves@redhat.com>
 961
 962         * gnulib/Makefile.in (aclocal_m4_deps): Move to
 963         "aclocal-m4-deps.mk".  Include file here.
 964         $(srcdir)/aclocal.m4: Add "configure.ac".
 965         * gnulib/aclocal-m4-deps.mk: New file.
 966         * gnulib/update-gnulib.sh: Automatically update
 967         "aclocal-m4-deps.mk".
 968
 969 2018-09-04  Tom Tromey  <tom@tromey.com>
 970
 971         * configure: Rebuild.
 972         * configure.ac: Remove multi-ice code.
 973
 974 2018-09-04  Tom Tromey  <tom@tromey.com>
 975
 976         * Makefile.in (GDB_WARN_CFLAGS_NO_DEFS): Remove.
 977         (ada-exp.o): Update.
 978
 979 2018-09-04  Tom Tromey  <tom@tromey.com>
 980
 981         * Makefile.in (printcmd.o, target-float.o): Remove.
 982         (GDB_WARN_CFLAGS_NO_FORMAT): Remove.
 983
 984 2018-09-04  Tom Tromey  <tom@tromey.com>
 985
 986         * gnulib/Makefile.in: Remove obsolete comment.
 987         * Makefile.in: Remove obsolete comment.
 988
 989 2018-09-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 990
 991         * riscv-tdep.c (riscv_frame_cache): Fix ARI warning, don't end a
 992         line with '+'.
 993
 994 2018-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 995
 996         * riscv-tdep.c: Add 'prologue-value.h' include.
 997         (struct riscv_unwind_cache): New struct.
 998         (riscv_debug_unwinder): New global.
 999         (riscv_scan_prologue): Update arguments, capture register details
1000         from prologue scan.
1001         (riscv_skip_prologue): Reformat arguments line, move end of
1002         prologue calculation into riscv_scan_prologue.
1003         (riscv_frame_cache): Update return type, create
1004         riscv_unwind_cache, scan the prologue, and fill in remaining cache
1005         details.
1006         (riscv_frame_this_id): Use frame id computed in riscv_frame_cache.
1007         (riscv_frame_prev_register): Use the trad_frame within the
1008         riscv_unwind_cache.
1009         (_initialize_riscv_tdep): Add 'set/show debug riscv unwinder'
1010         flag.
1011
1012 2018-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1013
1014         * trad-frame.h (trad_frame_set_realreg): Declare.
1015         (trad_frame_set_addr): Declare.
1016         * trad-frame.c (trad_frame_set_realreg): Define new function.
1017         (trad_frame_set_addr): Define new function.
1018         (trad_frame_set_reg_realreg): Use new function.
1019         (trad_frame_set_reg_addr): Use new function.
1020
1021 2018-09-01  Keith Seitz  <keiths@redhat.com>
1022
1023         * compile/compile-cplus-types.c (compile_cplus_debug_output_1): Use
1024         pulongest instead of "%lld".
1025         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol): Remove
1026         ATTRIBUTE_UNUSED.
1027
1028 2018-08-31  Tom Tromey  <tom@tromey.com>
1029
1030         * dwarf2read.c (dwarf2_add_field): Set the TYPE_LENGTH of the
1031         variant part type.
1032
1033 2018-08-31  Pedro Alves  <palves@redhat.com>
1034
1035         * gdbarch.h: Regenerate.
1036
1037 2018-08-31  Pedro Alves  <palves@redhat.com>
1038
1039         * gdbarch.sh (have_nonsteppable_watchpoint): Add comment.
1040         * target.h (Hardware watchpoint interfaces): Describe
1041         continuable/steppable/non-steppable watchpoints.
1042         * gdbarch.h, gdbarch.c: Regenerate.
1043
1044 2018-08-31  Pedro Alves  <palves@redhat.com>
1045
1046         * nto-procfs.c (nto_procfs_target::have_continuable_watchpoint):
1047         Delete.
1048         * s390-linux-nat.c
1049         (s390_linux_nat_target::have_continuable_watchpoint): Delete.
1050         * target.h (target_ops::have_continuable_watchpoint): Delete.
1051         (target_have_continuable_watchpoint): Delete.
1052         * x86-nat.h (x86_nat_target::have_continuable_watchpoint): Delete.
1053         * target-delegates.c: Regenerate.
1054
1055 2018-08-31  Sergio Durigan Junior  <sergiodj@redhat.com>
1056
1057         * gnulib/Makefile.in (aclocal_m4_deps): Update according to
1058         the files present in "gnulib/import/m4/".
1059
1060 2018-08-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1061
1062         * riscv-tdep.c (riscv_insn::decode): Decode c.addi4spn, c.sd,
1063         c.sw, c.swsp, and c.sdsp.
1064
1065 2018-08-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1066
1067         * riscv-tdep.c (struct riscv_inferior_data): Delete.
1068         (riscv_read_misa_reg): Don't cache value read into inferior data.
1069         (riscv_new_inferior_data): Delete.
1070         (riscv_inferior_data_cleanup): Delete.
1071         (riscv_inferior_data): Delete.
1072         (riscv_invalidate_inferior_data): Delete.
1073         (_initialize_riscv_tdep): Remove initialisation of inferior data.
1074
1075 2018-08-30  Simon Marchi  <simon.marchi@ericsson.com>
1076
1077         * compile/compile-cplus-types.c
1078         (compile_cplus_instance::leave_scope): Take the address of scope
1079         object.
1080         (compile_cplus_instance::convert_qualified_base): Compare quals
1081         to 0.
1082
1083 2018-08-30  Keith Seitz  <keiths@redhat.com>
1084
1085         * compile/compile-cplus-types.c (compile_cplus_instance::enter_scope):
1086         Use "%s" and host_address_to_string instead of "%p" in printf.
1087
1088 2018-08-29  Keith Seitz  <keiths@redhat.com>
1089
1090         * Makefile.in (SUBDIR_GCC_COMPILE_SRCS): Add compile-cplus-symbols.c
1091         and compile-cplus-types.c.
1092         (HFILES_NO_SRCDIR): Add gcc-cp-plugin.h.
1093         * c-lang.c (cplus_language_defn): Set C++ compile functions.
1094         * c-lang.h (cplus_get_compile_context, cplus_compute_program):
1095         Declare.
1096         * compile/compile-c-support.c: Include compile-cplus.h.
1097         (load_libcompile): Templatize.
1098         (get_compile_context): "New" function.
1099         (c_get_compile_context): Use get_compile_context.
1100         (cplus_get_compile_context): New function.
1101         (cplus_push_user_expression, cplus_pop_user_expression)
1102         (cplus_add_code_header, cplus_add_input, cplus_compile_program)
1103         (cplus_compute_program): Define new structs/functions.
1104         * compile/compile-cplus-symmbols.c: New file.
1105         * compile/compile-cplus-types.c: New file.
1106         * compile/compile-cplus.h: New file.
1107         * compile/compile-internal.h (debug_compile_oracle, GCC_TYPE_NONE):
1108         Declare.
1109         * compile/compile-object-load.c (get_out_value_type): Use
1110         strncmp_iw when comparing symbol names.
1111         (compile_object_load): Add mst_bss and mst_data.
1112         * compile/compile.c (_initialize_compile): Remove
1113         -Wno-implicit-function-declaration from `compile_args'.
1114         * compile/gcc-cp-plugin.h: New file.
1115         * NEWS: Mention C++ compile support and new debug options.
1116
1117 2018-08-29  Keith Seitz  <keiths@redhat.com>
1118
1119         * linespec.c (collect_info::add_symbol): Make virtual.
1120         (struct symbol_searcher_collect_info): New struct.
1121         (symbol_searcher::find_all_symbols): New method.
1122         * symtab.h (class symbol_searcher): New class.
1123
1124 2018-08-29  Keith Seitz  <keiths@redhat.com>
1125
1126         * linespec.c (struct linespec) <function_symbols, label_symbols>:
1127         Change to vector of block_symbol.  Update all users.
1128         (struct collect_info) <symbols>: Likewise.
1129         (collect_info::add_symbol): Take block_symbol as argument.
1130         Update all callers.
1131         (decode_compound_collector) <m_symbols>: Change type to vector
1132         of block_symbol.  Update all users.
1133         (decode_compound_collector::operator ()): Change parameter type
1134         to block_symbol.
1135         (find_method, find_function_symbols, find_linespec_symbols)
1136         (find_label_symbols_in_block, find_label_symbols): Change symbol
1137         vectors to block_symbol vectors.
1138         * symtab.h (symbol_found_callback_ftype): Change parameter type to
1139         block_symbol.
1140
1141 2018-08-29  Keith Seitz  <keiths@redhat.com>
1142
1143         * linespec.c (symbolp): Remove typedef and VEC definitions.
1144         (bound_minimal_symbol_d): Likewise.
1145
1146 2018-08-29  Keith Seitz  <keiths@redhat.com>
1147
1148         * linespec.c (decode_compound_collector::decode_compound_collector):
1149         Remove initialization for `m_symtabs'.
1150         (decode_compound_collector::release_symbols): Change return type
1151         to std::vector.  Update all callers.
1152         (class decode_compound_collector) <m_symbols>: Change type to
1153         std::vector.
1154         (lookup_prefix_sym): Change return type to std::vector.  Update all
1155         callers.
1156         (compare_symbols): Remove.
1157         (std_compare_symbols): Rename to `compare_symbols'.
1158         (find_method): Change `sym_classes' parameter to std::vector.
1159         Update all callers.  Use std::sort to sort sym_classes.
1160         (find_linespec_symbols): Remove cleanup.
1161
1162 2018-08-29  Keith Seitz  <keiths@redhat.com>
1163
1164         * linespec.c (struct linespec) <minimal_symbols>: Change type to
1165         std::vector.  Update all users.
1166         (convert_linespec_to_sals): Use std::sort to sort minimal symbols.
1167         (struct collect_info) <minimal_symbols>: Likewise.
1168         (compare_msymbols): Return bool.  Change parameters to const
1169         bound_minimal_symbol references.
1170         (find_method, find_function_symbols, find_linespec_symbols): Change
1171         `minsyms' parameter to std::vector.  Update all callers.
1172
1173 2018-08-29  Keith Seitz  <keiths@redhat.com>
1174
1175         * linespec.c (struct linespec) <label_symbols>: Change type to
1176         std::vector.  Update all users.
1177         (find_label_symbols_in_block): Change `result' parameter to
1178         std::vector.  Update all callers.
1179         (find_label_symbols): Return std::vector.  Update all callers.
1180
1181 2018-08-29  Keith Seitz  <keiths@redhat.com>
1182
1183         * linespec.c (struct linespec) <function_symbols>: Change type to
1184         std::vector.  Update all users.
1185         (struct collect_info) <function_symbols>: Likewise.
1186         (convert_linespec_to_sals): Use std::sort to sort function_symbols.
1187         (std_compare_symbols): New function.
1188         (find_method, find_function_symbols, find_linespec_symbols)
1189         (find_label_symbols_in_block): Change `symbols' parameter to
1190         std::vector.  Update all callers.
1191         (find_label_symbols): Likewise for `function_symbols' and
1192         `label_funcs_ret'.
1193
1194 2018-08-29  Keith Seitz  <keiths@redhat.com>
1195
1196         * linespec.c (symtab_vector_up): Define.
1197         (struct linespec) <file_symtabs>: Change type to std::vector *.
1198         Update all uses.
1199         (struct collect_info) <file_symtabs>: Likewise.
1200         (collect_symtabs_from_filename): Return symtab_vector_up.
1201         Update all callers.
1202         (decode_objc): Remove cleanup.
1203         (symtab_collector::symtab_collector): Initialize `m_symtabs'.
1204         (symtab_collector::release_symtabs): Return symtab_vector_up.
1205         Update all callers.
1206         (class symtab_collector) <m_symtabs>: Change type to symtab_vector_up.
1207         Update all users.
1208         (collect_symtabs_from_filename, symtabs_from_filename): Return
1209         symtab_vector_up.  Update all callers.
1210
1211 2018-08-29  Tom Tromey  <tom@tromey.com>
1212
1213         * csky-tdep.c (csky_analyze_prologue): Use
1214         core_addr_to_string_nz.
1215
1216 2018-08-29  Tom Tromey  <tom@tromey.com>
1217
1218         * windows-nat.c (struct xlate_exception) <them>: Change type to
1219         DWORD.
1220         (xlate): Fix formatting.  Remove last entry.
1221         (struct xlate_exception, xlate): Comment out.
1222         (windows_nat_target::resume): Use ranged for.
1223
1224 2018-08-29  Jim Wilson  <jimw@sifive.com>
1225
1226         * riscv-linux-nat.c: Include elf/common.h instead of elf.h.
1227         (riscv_linux_nat_target::fetch_registers): Use NT_FPREGSET instead
1228         of NT_PRFPREG.
1229         (riscv_linux_nat_target::store_registers): Likewise.
1230
1231 2018-08-29  Sergio Durigan Junior  <sergiodj@redhat.com>
1232
1233         PR gdb/23555
1234         PR gdb/23558
1235         * gnulib/aclocal.m4: Regenerate.
1236         * gnulib/config.in: Regenerate.
1237         * gnulib/configure: Regenerate.
1238         * gnulib/import/Makefile.am: Update.
1239         * gnulib/import/Makefile.in: Update.
1240         * gnulib/import/extra/snippet/_Noreturn.h: Rename to...
1241         * gnulib/import/_Noreturn.h: ... this.
1242         * gnulib/import/alloca.in.h: Update.
1243         * gnulib/import/extra/snippet/arg-nonnull.h: Rename to...
1244         * gnulib/import/arg-nonnull.h: ... this.
1245         * gnulib/import/assure.h: Update.
1246         * gnulib/import/at-func.c: Update.
1247         * gnulib/import/basename-lgpl.c: Update.
1248         * gnulib/import/extra/snippet/c++defs.h: Rename to...
1249         * gnulib/import/c++defs.h: ... this.
1250         * gnulib/import/canonicalize-lgpl.c: Update.
1251         * gnulib/import/cdefs.h: Update.
1252         * gnulib/import/chdir-long.c: Update.
1253         * gnulib/import/chdir-long.h: Update.
1254         * gnulib/import/cloexec.c: Update.
1255         * gnulib/import/cloexec.h: Update.
1256         * gnulib/import/close.c: Update.
1257         * gnulib/import/closedir.c: Update.
1258         * gnulib/import/config.charset: Update.
1259         * gnulib/import/dirent-private.h: Update.
1260         * gnulib/import/dirent.in.h: Update.
1261         * gnulib/import/dirfd.c: Update.
1262         * gnulib/import/dirname-lgpl.c: Update.
1263         * gnulib/import/dirname.h: Update.
1264         * gnulib/import/dosname.h: Update.
1265         * gnulib/import/dup-safer-flag.c: Update.
1266         * gnulib/import/dup-safer.c: Update.
1267         * gnulib/import/dup.c: Update.
1268         * gnulib/import/dup2.c: Update.
1269         * gnulib/import/errno.in.h: Update.
1270         * gnulib/import/error.c: Update.
1271         * gnulib/import/error.h: Update.
1272         * gnulib/import/exitfail.c: Update.
1273         * gnulib/import/exitfail.h: Update.
1274         * gnulib/import/extra/update-copyright: Update.
1275         * gnulib/import/fchdir.c: Update.
1276         * gnulib/import/fcntl.c: Update.
1277         * gnulib/import/fcntl.in.h: Update.
1278         * gnulib/import/fd-hook.c: Update.
1279         * gnulib/import/fd-hook.h: Update.
1280         * gnulib/import/fd-safer-flag.c: Update.
1281         * gnulib/import/fd-safer.c: Update.
1282         * gnulib/import/fdopendir.c: Update.
1283         * gnulib/import/filename.h: Update.
1284         * gnulib/import/filenamecat-lgpl.c: Update.
1285         * gnulib/import/filenamecat.h: Update.
1286         * gnulib/import/flexmember.h: Update.
1287         * gnulib/import/float+.h: Update.
1288         * gnulib/import/float.c: Update.
1289         * gnulib/import/float.in.h: Update.
1290         * gnulib/import/fnmatch.c: Update.
1291         * gnulib/import/fnmatch.in.h: Update.
1292         * gnulib/import/fnmatch_loop.c: Update.
1293         * gnulib/import/fpucw.h: Update.
1294         * gnulib/import/frexp.c: Update.
1295         * gnulib/import/frexpl.c: Update.
1296         * gnulib/import/fstat.c: Update.
1297         * gnulib/import/fstatat.c: Update.
1298         * gnulib/import/getcwd-lgpl.c: Update.
1299         * gnulib/import/getcwd.c: Update.
1300         * gnulib/import/getdtablesize.c: Update.
1301         * gnulib/import/getlogin_r.c: Update.
1302         * gnulib/import/getprogname.c: Update.
1303         * gnulib/import/getprogname.h: Update.
1304         * gnulib/import/gettext.h: Update.
1305         * gnulib/import/gettimeofday.c: Update.
1306         * gnulib/import/glob-libc.h: Update.
1307         * gnulib/import/glob.c: Update.
1308         * gnulib/import/glob.in.h: Update.
1309         * gnulib/import/glob_internal.h: Update.
1310         * gnulib/import/glob_pattern_p.c: Update.
1311         * gnulib/import/globfree.c: Update.
1312         * gnulib/import/hard-locale.c: Update.
1313         * gnulib/import/hard-locale.h: Update.
1314         * gnulib/import/intprops.h: Update.
1315         * gnulib/import/inttypes.in.h: Update.
1316         * gnulib/import/isnan.c: Update.
1317         * gnulib/import/isnand-nolibm.h: Update.
1318         * gnulib/import/isnand.c: Update.
1319         * gnulib/import/isnanl-nolibm.h: Update.
1320         * gnulib/import/isnanl.c: Update.
1321         * gnulib/import/itold.c: Update.
1322         * gnulib/import/libc-config.h: Update.
1323         * gnulib/import/limits.in.h: Update.
1324         * gnulib/import/localcharset.c: Update.
1325         * gnulib/import/localcharset.h: Update.
1326         * gnulib/import/localtime-buffer.c: Update.
1327         * gnulib/import/localtime-buffer.h: Update.
1328         * gnulib/import/lstat.c: Update.
1329         * gnulib/import/m4/00gnulib.m4: Update.
1330         * gnulib/import/m4/__inline.m4: Update.
1331         * gnulib/import/m4/absolute-header.m4: Update.
1332         * gnulib/import/m4/alloca.m4: Update.
1333         * gnulib/import/m4/builtin-expect.m4: Update.
1334         * gnulib/import/m4/canonicalize.m4: Update.
1335         * gnulib/import/m4/chdir-long.m4: Update.
1336         * gnulib/import/m4/close.m4: Update.
1337         * gnulib/import/m4/closedir.m4: Update.
1338         * gnulib/import/m4/configmake.m4: Update.
1339         * gnulib/import/m4/d-ino.m4: Update.
1340         * gnulib/import/m4/d-type.m4: Update.
1341         * gnulib/import/m4/dirent_h.m4: Update.
1342         * gnulib/import/m4/dirfd.m4: Update.
1343         * gnulib/import/m4/dirname.m4: Update.
1344         * gnulib/import/m4/double-slash-root.m4: Update.
1345         * gnulib/import/m4/dup.m4: Update.
1346         * gnulib/import/m4/dup2.m4: Update.
1347         * gnulib/import/m4/eealloc.m4: Update.
1348         * gnulib/import/m4/environ.m4: Update.
1349         * gnulib/import/m4/errno_h.m4: Update.
1350         * gnulib/import/m4/error.m4: Update.
1351         * gnulib/import/m4/exponentd.m4: Update.
1352         * gnulib/import/m4/exponentl.m4: Update.
1353         * gnulib/import/m4/extensions.m4: Update.
1354         * gnulib/import/m4/extern-inline.m4: Update.
1355         * gnulib/import/m4/fchdir.m4: Update.
1356         * gnulib/import/m4/fcntl-o.m4: Update.
1357         * gnulib/import/m4/fcntl.m4: Update.
1358         * gnulib/import/m4/fcntl_h.m4: Update.
1359         * gnulib/import/m4/fdopendir.m4: Update.
1360         * gnulib/import/m4/filenamecat.m4: Update.
1361         * gnulib/import/m4/flexmember.m4: Update.
1362         * gnulib/import/m4/float_h.m4: Update.
1363         * gnulib/import/m4/fnmatch.m4: Update.
1364         * gnulib/import/m4/fnmatch_h.m4: Update.
1365         * gnulib/import/m4/fpieee.m4: Update.
1366         * gnulib/import/m4/frexp.m4: Update.
1367         * gnulib/import/m4/frexpl.m4: Update.
1368         * gnulib/import/m4/fstat.m4: Update.
1369         * gnulib/import/m4/fstatat.m4: Update.
1370         * gnulib/import/m4/getcwd-abort-bug.m4: Update.
1371         * gnulib/import/m4/getcwd-path-max.m4: Update.
1372         * gnulib/import/m4/getcwd.m4: Update.
1373         * gnulib/import/m4/getdtablesize.m4: Update.
1374         * gnulib/import/m4/getlogin.m4: Update.
1375         * gnulib/import/m4/getlogin_r.m4: Update.
1376         * gnulib/import/m4/getpagesize.m4: Update.
1377         * gnulib/import/m4/getprogname.m4: Update.
1378         * gnulib/import/m4/gettimeofday.m4: Update.
1379         * gnulib/import/m4/glibc21.m4: Update.
1380         * gnulib/import/m4/glob.m4: Update.
1381         * gnulib/import/m4/glob_h.m4: Update.
1382         * gnulib/import/m4/gnulib-cache.m4: Update.
1383         * gnulib/import/m4/gnulib-common.m4: Update.
1384         * gnulib/import/m4/gnulib-comp.m4: Update.
1385         * gnulib/import/m4/gnulib-tool.m4: Update.
1386         * gnulib/import/m4/hard-locale.m4: Update.
1387         * gnulib/import/m4/include_next.m4: Update.
1388         * gnulib/import/m4/inttypes-pri.m4: Update.
1389         * gnulib/import/m4/inttypes.m4: Update.
1390         * gnulib/import/m4/isnand.m4: Update.
1391         * gnulib/import/m4/isnanl.m4: Update.
1392         * gnulib/import/m4/largefile.m4: Update.
1393         * gnulib/import/m4/limits-h.m4: Update.
1394         * gnulib/import/m4/localcharset.m4: Update.
1395         * gnulib/import/m4/locale-fr.m4: Update.
1396         * gnulib/import/m4/locale-ja.m4: Update.
1397         * gnulib/import/m4/locale-zh.m4: Update.
1398         * gnulib/import/m4/localtime-buffer.m4: Update.
1399         * gnulib/import/m4/longlong.m4: Update.
1400         * gnulib/import/m4/lstat.m4: Update.
1401         * gnulib/import/m4/malloc.m4: Update.
1402         * gnulib/import/m4/malloca.m4: Update.
1403         * gnulib/import/m4/math_h.m4: Update.
1404         * gnulib/import/m4/mbrtowc.m4: Update.
1405         * gnulib/import/m4/mbsinit.m4: Update.
1406         * gnulib/import/m4/mbsrtowcs.m4: Update.
1407         * gnulib/import/m4/mbstate_t.m4: Update.
1408         * gnulib/import/m4/memchr.m4: Update.
1409         * gnulib/import/m4/memmem.m4: Update.
1410         * gnulib/import/m4/mempcpy.m4: Update.
1411         * gnulib/import/m4/memrchr.m4: Update.
1412         * gnulib/import/m4/mkdir.m4: Update.
1413         * gnulib/import/m4/mkstemp.m4: Update.
1414         * gnulib/import/m4/mmap-anon.m4: Update.
1415         * gnulib/import/m4/mode_t.m4: Update.
1416         * gnulib/import/m4/msvc-inval.m4: Update.
1417         * gnulib/import/m4/msvc-nothrow.m4: Update.
1418         * gnulib/import/m4/multiarch.m4: Update.
1419         * gnulib/import/m4/nocrash.m4: Update.
1420         * gnulib/import/m4/off_t.m4: Update.
1421         * gnulib/import/m4/onceonly.m4: Update.
1422         * gnulib/import/m4/open-cloexec.m4: Update.
1423         * gnulib/import/m4/open.m4: Update.
1424         * gnulib/import/m4/openat.m4: Update.
1425         * gnulib/import/m4/opendir.m4: Update.
1426         * gnulib/import/m4/pathmax.m4: Update.
1427         * gnulib/import/m4/rawmemchr.m4: Update.
1428         * gnulib/import/m4/readdir.m4: Update.
1429         * gnulib/import/m4/readlink.m4: Update.
1430         * gnulib/import/m4/realloc.m4: Update.
1431         * gnulib/import/m4/rename.m4: Update.
1432         * gnulib/import/m4/rewinddir.m4: Update.
1433         * gnulib/import/m4/rmdir.m4: Update.
1434         * gnulib/import/m4/save-cwd.m4: Update.
1435         * gnulib/import/m4/secure_getenv.m4: Update.
1436         * gnulib/import/m4/setenv.m4: Update.
1437         * gnulib/import/m4/signal_h.m4: Update.
1438         * gnulib/import/m4/ssize_t.m4: Update.
1439         * gnulib/import/m4/stat-time.m4: Update.
1440         * gnulib/import/m4/stat.m4: Update.
1441         * gnulib/import/m4/std-gnu11.m4: Update.
1442         * gnulib/import/m4/stdbool.m4: Update.
1443         * gnulib/import/m4/stddef_h.m4: Update.
1444         * gnulib/import/m4/stdint.m4: Update.
1445         * gnulib/import/m4/stdio_h.m4: Update.
1446         * gnulib/import/m4/stdlib_h.m4: Update.
1447         * gnulib/import/m4/strchrnul.m4: Update.
1448         * gnulib/import/m4/strdup.m4: Update.
1449         * gnulib/import/m4/strerror.m4: Update.
1450         * gnulib/import/m4/string_h.m4: Update.
1451         * gnulib/import/m4/strstr.m4: Update.
1452         * gnulib/import/m4/strtok_r.m4: Update.
1453         * gnulib/import/m4/sys_socket_h.m4: Update.
1454         * gnulib/import/m4/sys_stat_h.m4: Update.
1455         * gnulib/import/m4/sys_time_h.m4: Update.
1456         * gnulib/import/m4/sys_types_h.m4: Update.
1457         * gnulib/import/m4/tempname.m4: Update.
1458         * gnulib/import/m4/time_h.m4: Update.
1459         * gnulib/import/m4/unistd-safer.m4: Update.
1460         * gnulib/import/m4/unistd_h.m4: Update.
1461         * gnulib/import/m4/warn-on-use.m4: Update.
1462         * gnulib/import/m4/wchar_h.m4: Update.
1463         * gnulib/import/m4/wchar_t.m4: Update.
1464         * gnulib/import/m4/wctype_h.m4: Update.
1465         * gnulib/import/m4/wint_t.m4: Update.
1466         * gnulib/import/malloc.c: Update.
1467         * gnulib/import/malloc/scratch_buffer.h: Update.
1468         * gnulib/import/malloc/scratch_buffer_grow.c: Update.
1469         * gnulib/import/malloc/scratch_buffer_grow_preserve.c: Update.
1470         * gnulib/import/malloc/scratch_buffer_set_array_size.c: Update.
1471         * gnulib/import/malloca.c: Update.
1472         * gnulib/import/malloca.h: Update.
1473         * gnulib/import/malloca.valgrind: Update.
1474         * gnulib/import/math.in.h: Update.
1475         * gnulib/import/mbrtowc.c: Update.
1476         * gnulib/import/mbsinit.c: Update.
1477         * gnulib/import/mbsrtowcs-impl.h: Update.
1478         * gnulib/import/mbsrtowcs-state.c: Update.
1479         * gnulib/import/mbsrtowcs.c: Update.
1480         * gnulib/import/memchr.c: Update.
1481         * gnulib/import/memmem.c: Update.
1482         * gnulib/import/mempcpy.c: Update.
1483         * gnulib/import/memrchr.c: Update.
1484         * gnulib/import/mkdir.c: Update.
1485         * gnulib/import/mkstemp.c: Update.
1486         * gnulib/import/msvc-inval.c: Update.
1487         * gnulib/import/msvc-inval.h: Update.
1488         * gnulib/import/msvc-nothrow.c: Update.
1489         * gnulib/import/msvc-nothrow.h: Update.
1490         * gnulib/import/open.c: Update.
1491         * gnulib/import/openat-die.c: Update.
1492         * gnulib/import/openat-priv.h: Update.
1493         * gnulib/import/openat-proc.c: Update.
1494         * gnulib/import/openat.c: Update.
1495         * gnulib/import/openat.h: Update.
1496         * gnulib/import/opendir.c: Update.
1497         * gnulib/import/pathmax.h: Update.
1498         * gnulib/import/pipe-safer.c: Update.
1499         * gnulib/import/rawmemchr.c: Update.
1500         * gnulib/import/readdir.c: Update.
1501         * gnulib/import/readlink.c: Update.
1502         * gnulib/import/realloc.c: Update.
1503         * gnulib/import/ref-add.sin: Update.
1504         * gnulib/import/ref-del.sin: Update.
1505         * gnulib/import/rename.c: Update.
1506         * gnulib/import/rewinddir.c: Update.
1507         * gnulib/import/rmdir.c: Update.
1508         * gnulib/import/same-inode.h: Update.
1509         * gnulib/import/save-cwd.c: Update.
1510         * gnulib/import/save-cwd.h: Update.
1511         * gnulib/import/scratch_buffer.h: Update.
1512         * gnulib/import/secure_getenv.c: Update.
1513         * gnulib/import/setenv.c: Update.
1514         * gnulib/import/signal.in.h: Update.
1515         * gnulib/import/stat-time.c: Update.
1516         * gnulib/import/stat-time.h: Update.
1517         * gnulib/import/stat-w32.c: Update.
1518         * gnulib/import/stat-w32.h: Update.
1519         * gnulib/import/stat.c: Update.
1520         * gnulib/import/stdbool.in.h: Update.
1521         * gnulib/import/stddef.in.h: Update.
1522         * gnulib/import/stdint.in.h: Update.
1523         * gnulib/import/stdio.in.h: Update.
1524         * gnulib/import/stdlib.in.h: Update.
1525         * gnulib/import/str-two-way.h: Update.
1526         * gnulib/import/strchrnul.c: Update.
1527         * gnulib/import/strdup.c: Update.
1528         * gnulib/import/streq.h: Update.
1529         * gnulib/import/strerror-override.c: Update.
1530         * gnulib/import/strerror-override.h: Update.
1531         * gnulib/import/strerror.c: Update.
1532         * gnulib/import/string.in.h: Update.
1533         * gnulib/import/stripslash.c: Update.
1534         * gnulib/import/strnlen1.c: Update.
1535         * gnulib/import/strnlen1.h: Update.
1536         * gnulib/import/strstr.c: Update.
1537         * gnulib/import/strtok_r.c: Update.
1538         * gnulib/import/sys_stat.in.h: Update.
1539         * gnulib/import/sys_time.in.h: Update.
1540         * gnulib/import/sys_types.in.h: Update.
1541         * gnulib/import/tempname.c: Update.
1542         * gnulib/import/tempname.h: Update.
1543         * gnulib/import/time.in.h: Update.
1544         * gnulib/import/unistd--.h: Update.
1545         * gnulib/import/unistd-safer.h: Update.
1546         * gnulib/import/unistd.in.h: Update.
1547         * gnulib/import/unsetenv.c: Update.
1548         * gnulib/import/verify.h: Update.
1549         * gnulib/import/extra/snippet/warn-on-use.h: Update.
1550         * gnulib/import/wchar.in.h: Update.
1551         * gnulib/import/wctype.in.h: Update.
1552         * gnulib/import/xalloc-oversized.h: Update.
1553         * gnulib/update-gnulib.sh (GNULIB_COMMIT_SHA1): Set to
1554         "53e2c179f26a890fa6685af4b6c1397ee370433b".
1555
1556 2018-08-16  Gary Benson <gbenson@redhat.com>
1557
1558         PR gdb/13000:
1559         * gdb/main.c (captured_main_1): Exit with nonzero status
1560         in batch mode if the last command to be executed failed.
1561         * NEWS: Mention the above.
1562
1563 2018-08-29  Simon Marchi  <simon.marchi@ericsson.com>
1564
1565         * csky-tdep.c (csky_memory_insert_breakpoint): Remove newline at
1566         end of warning message.
1567
1568 2018-08-29  Alan Hayward  <alan.hayward@arm.com>
1569
1570         PR gdb/22943:
1571         * aarch64-tdep.c (is_hfa_or_hva): Remove function.
1572         (aarch64_extract_return_value): Use
1573         aapcs_is_vfp_call_or_return_candidate.
1574         (aarch64_return_in_memory): Likewise.
1575         (aarch64_store_return_value): Likewise.
1576
1577 2018-08-29  Alan Hayward  <alan.hayward@arm.com>
1578
1579         * aarch64-tdep.c
1580         (aapcs_is_vfp_call_or_return_candidate): Make static
1581         (pass_in_v_or_stack): Remove function.
1582         (pass_in_v_vfp_candidate): New function.
1583         (aarch64_push_dummy_call): Check for float register candidates.
1584
1585 2018-08-29  Alan Hayward  <alan.hayward@arm.com>
1586
1587         * aarch64-tdep.c (HA_MAX_NUM_FLDS): New macro.
1588         (aapcs_is_vfp_call_or_return_candidate_1): New function.
1589         (aapcs_is_vfp_call_or_return_candidate): Likewise.
1590
1591 2018-08-28  Simon Marchi  <simon.marchi@polymtl.ca>
1592
1593         PR build/23399
1594         * common/agent.c (IPA_SYM_STRUCT_NAME): Define.
1595         (struct ipa_sym_addresses): Rename to...
1596         (struct ipa_sym_addresses_common): ... this.
1597         * common/agent.h (IPA_SYM): Use IPA_SYM_STRUCT_NAME.
1598
1599 2018-08-28  Tom Tromey  <tom@tromey.com>
1600
1601         * c-exp.y (struct token_and_value): Remove typedef and DEF_VEC.
1602         (token_fifo): Now a std::vector.
1603         (yylex, c_parse): Update.
1604         * d-exp.y (struct token_and_value): Remove typedef and DEF_VEC.
1605         (token_fifo): Now a std::vector.
1606         (yylex, d_parse): Update.
1607         * go-exp.y (struct token_and_value): Remove typedef and DEF_VEC.
1608         (token_fifo): Now a std::vector.
1609         (yylex, go_parse): Update.
1610
1611 2018-08-28  Simon Marchi  <simon.marchi@ericsson.com>
1612
1613         * parser-defs.h (struct type_stack) <elements>: Change type to
1614         std::vector<union type_stack_elt>.
1615         <depth, size>: Remove.
1616         * parse.c (parse_exp_in_context_1): Adjust.
1617         (type_stack_reserve): Remove.
1618         (check_type_stack_depth): Remove.
1619         (insert_into_type_stack): Adjust to std::vector.
1620         (insert_type): Likewise.
1621         (push_type): Likewise.
1622         (push_type_int): Likewise.
1623         (insert_type_address_space): Likewise.
1624         (pop_type): Likewise.
1625         (pop_type_int): Likewise.
1626         (pop_typelist): Likewise.
1627         (pop_type_stack): Likewise.
1628         (append_type_stack): Likewise.
1629         (push_type_stack): Likewise.
1630         (get_type_stack): Likewise.
1631         (type_stack_cleanup): Likewise.
1632         (push_typelist): Likewise.
1633         (follow_types): Likewise.
1634         (_initialize_parse): Likewise.
1635
1636 2018-08-28  Hafiz Abid Qadeer  <abidh@codesourcery.com>
1637
1638         * NEWS: Mention csky target.
1639
1640 2018-08-28  Jiangshuai Li  <jiangshuai_li@c-sky.com>
1641             Hafiz Abid Qadeer  <abidh@codesourcery.com>
1642             Don Breazeal  <donb@codesourcery.com>
1643
1644         * csky-linux-tdep.c: New file.
1645         * csky-tdep.c: Likewise.
1646         * csky-tdep.h: Likewise.
1647         * Makefile.in (ALL_TARGET_OBS): Add csky-linux-tdep.o and
1648         csky-tdep.o.
1649         (HFILES_NO_SRCDIR): Add csky-tdep.h.
1650         (ALLDEPFILES): Add csky-linux-tdep.c and csky-tdep.c
1651         * configure.tgt: Add csky support.
1652
1653 2018-08-27  Jan Vrany  <jan.vrany@fit.cvut.cz>
1654
1655         * python/py-framefilter.c (py_print_frame): Print frame architecture
1656         when printing on an MI output.
1657
1658 2018-08-27  Tom Tromey  <tom@tromey.com>
1659
1660         PR build/23087:
1661         * configure: Rebuild.
1662         * warning.m4 (AM_GDB_WARNINGS): Remove -Wno-narrowing.
1663
1664 2018-08-27  Tom Tromey  <tom@tromey.com>
1665
1666         * aarch64-linux-tdep.c
1667         (aarch64_linux_iterate_over_regset_sections) <sve_regmap>: Add
1668         casts to int.
1669
1670 2018-08-27  Tom Tromey  <tom@tromey.com>
1671
1672         * ppc64-tdep.c (insn_d, insn_ds, insn_xfx): Add casts to
1673         unsigned.
1674         (ppc64_standard_linkage1, ppc64_standard_linkage2)
1675         (ppc64_standard_linkage3, ppc64_standard_linkage4)
1676         (ppc64_standard_linkage5, ppc64_standard_linkage6)
1677         (ppc64_standard_linkage7, ppc64_standard_linkage8): Add casts to
1678         unsigned.
1679
1680 2018-08-27  Tom Tromey  <tom@tromey.com>
1681
1682         * xtensa-tdep.h (XTREG_END): Add cast to unsigned.
1683         (XTENSA_GDBARCH_TDEP_INSTANTIATE): Likewise.
1684
1685 2018-08-27  Tom Tromey  <tom@tromey.com>
1686
1687         * tramp-frame.h (TRAMP_SENTINEL_INSN): Redefine.
1688         * tilegx-linux-tdep.c (tilegx_linux_rt_sigframe): Use
1689         ULONGEST_MAX.
1690         * tic6x-linux-tdep.c (tic6x_linux_rt_sigreturn_tramp_frame): Use
1691         ULONGEST_MAX.
1692         * sparc64-linux-tdep.c (sparc64_linux_rt_sigframe): Use
1693         ULONGEST_MAX.
1694         * sparc-linux-tdep.c (sparc32_linux_sigframe)
1695         (sparc32_linux_rt_sigframe): Use ULONGEST_MAX.
1696         * ppc-nbsd-tdep.c (ppcnbsd_sigtramp, ppcnbsd2_sigtramp): Use
1697         ULONGEST_MAX.
1698         * ppc-linux-tdep.c (ppc32_linux_sigaction_tramp_frame)
1699         (ppc64_linux_sigaction_tramp_frame)
1700         (ppc32_linux_sighandler_tramp_frame)
1701         (ppc64_linux_sighandler_tramp_frame): Use ULONGEST_MAX.
1702         * nios2-linux-tdep.c (nios2_r1_linux_rt_sigreturn_tramp_frame)
1703         (nios2_r2_linux_rt_sigreturn_tramp_frame): Use ULONGEST_MAX.
1704         * mn10300-linux-tdep.c (am33_linux_sigframe)
1705         (am33_linux_rt_sigframe): Use ULONGEST_MAX.
1706         * mips64-obsd-tdep.c (mips64obsd_sigframe): Use ULONGEST_MAX.
1707         * mips-linux-tdep.c (mips_linux_o32_sigframe)
1708         (mips_linux_o32_rt_sigframe, mips_linux_n32_rt_sigframe)
1709         (mips_linux_n64_rt_sigframe, micromips_linux_o32_sigframe)
1710         (micromips_linux_o32_rt_sigframe, micromips_linux_n32_rt_sigframe)
1711         (micromips_linux_n64_rt_sigframe): Use ULONGEST_MAX.
1712         * mips-fbsd-tdep.c (mips_fbsd_sigframe, mipsn32_fbsd_sigframe)
1713         (mips64_fbsd_sigframe): Use ULONGEST_MAX.
1714         * microblaze-linux-tdep.c
1715         (microblaze_linux_sighandler_tramp_frame): Use ULONGEST_MAX.
1716         * i386-nbsd-tdep.c (i386nbsd_sigtramp_sc16, i386nbsd_sigtramp_sc2)
1717         (i386nbsd_sigtramp_si2, i386nbsd_sigtramp_si31)
1718         (i386nbsd_sigtramp_si4): Use ULONGEST_MAX.
1719         * hppa-nbsd-tdep.c (hppanbsd_sigtramp_si4): Use ULONGEST_MAX.
1720         * common/common-types.h (ULONGEST_MAX): New define.
1721         (CORE_ADDR_MAX): Fix formatting.
1722         * bfin-linux-tdep.c (bfin_linux_sigframe): Use ULONGEST_MAX.
1723         * arm-obsd-tdep.c (armobsd_sigframe): Use ULONGEST_MAX.
1724         * arm-linux-tdep.c (arm_linux_sigreturn_tramp_frame)
1725         (arm_linux_rt_sigreturn_tramp_frame)
1726         (arm_eabi_linux_sigreturn_tramp_frame)
1727         (arm_eabi_linux_rt_sigreturn_tramp_frame)
1728         (thumb2_eabi_linux_sigreturn_tramp_frame)
1729         (thumb2_eabi_linux_rt_sigreturn_tramp_frame)
1730         (arm_linux_restart_syscall_tramp_frame)
1731         (arm_kernel_linux_restart_syscall_tramp_frame): Use ULONGEST_MAX.
1732         * arm-fbsd-tdep.c (arm_fbsd_sigframe): Use ULONGEST_MAX.
1733         * aarch64-linux-tdep.c (aarch64_linux_rt_sigframe): Use
1734         ULONGEST_MAX.
1735         * aarch64-fbsd-tdep.c (aarch64_fbsd_sigframe): Use ULONGEST_MAX.
1736
1737 2018-08-27  Tom Tromey  <tom@tromey.com>
1738
1739         * rs6000-tdep.c (ppc_deal_with_atomic_sequence): Use
1740         CORE_ADDR_MAX.
1741         * mips-tdep.c (mips_deal_with_atomic_sequence)
1742         (micromips_deal_with_atomic_sequence): Use CORE_ADDR_MAX.
1743         * arch/arm-get-next-pcs.c (thumb_deal_with_atomic_sequence_raw)
1744         (arm_deal_with_atomic_sequence_raw): Use CORE_ADDR_MAX.
1745         * alpha-tdep.c (alpha_deal_with_atomic_sequence): Use
1746         CORE_ADDR_MAX.
1747         * aarch64-tdep.c (aarch64_software_single_step): Use
1748         CORE_ADDR_MAX.
1749
1750 2018-08-27  Tom Tromey  <tom@tromey.com>
1751
1752         * linespec.c (complete_linespec_component): Add cast to "char".
1753         * completer.c (completion_tracker::build_completion_result): Add
1754         cast to "char".
1755
1756 2018-08-26  Simon Marchi  <simon.marchi@polymtl.ca>
1757
1758         * solist.h (struct solist, struct target_so_ops): Fix
1759         indentation.
1760
1761 2018-08-26  Simon Marchi  <simon.marchi@polymtl.ca>
1762
1763         * ada-tasks.c (ada_task_info_s): Remove typedef.
1764         (DEF_VEC_O(ada_task_info_s)): Remove.
1765         (struct ada_tasks_inferior_data): Initialize fields.
1766         <task_list>: Make an std::vector.
1767         (get_ada_tasks_inferior_data): Allocate with new.
1768         (ada_get_task_number): Adjust.
1769         (get_task_number_from_id): Likewise.
1770         (valid_task_id): Likewise.
1771         (ada_get_task_info_from_ptid): Likewise.
1772         (iterate_over_live_ada_tasks): Likewise.
1773         (add_ada_task): Likewise.
1774         (read_known_tasks): Likewise.
1775         (ada_build_task_list): Likewise.
1776         (print_ada_task_info): Likewise.
1777         (info_task): Likewise.
1778         (task_command_1): Likewise.
1779
1780 2018-08-26  Simon Marchi  <simon.marchi@polymtl.ca>
1781
1782         * ada-lang.c (add_angle_brackets): Return std::string.
1783
1784 2018-08-25  Simon Marchi  <simon.marchi@polymtl.ca>
1785
1786         * python/py-threadevent.c (py_get_event_thread): Initialize
1787         pythread.
1788
1789 2018-08-24  Pedro Alves  <palves@redhat.com>
1790
1791         * python/py-bpevent.c (create_breakpoint_event_object): Use
1792         copy-initialization.
1793         * python/py-continueevent.c (emit_continue_event): Use
1794         copy-initialization.
1795         * python/py-exitedevent.c (create_exited_event_object): Return a
1796         gdbpy_ref<>.
1797         (emit_exited_event): Use copy-initialization.
1798         * python/py-inferior.c (python_new_inferior)
1799         (python_inferior_deleted, add_thread_object): Use
1800         copy-initialization.
1801         * python/py-infevents.c (create_inferior_call_event_object)
1802         (create_register_changed_event_object)
1803         (create_memory_changed_event_object): Return a gdbpy_ref<>.
1804         (emit_inferior_call_event, emit_memory_changed_event)
1805         (emit_register_changed_event): Use copy-initialization.
1806         * python/py-newobjfileevent.c (create_new_objfile_event_object):
1807         Return a gdbpy_ref<>.
1808         (emit_new_objfile_event): Use copy-initialization.
1809         (create_clear_objfiles_event_object): Return a gdbpy_ref<>.
1810         (emit_clear_objfiles_event): Use copy-initialization.
1811         * python/py-signalevent.c (create_signal_event_object): Use
1812         copy-initialization.
1813         * python/py-threadevent.c (create_thread_event_object): Use
1814         copy-initialization.
1815
1816 2018-08-24  Pedro Alves  <palves@redhat.com>
1817             Simon Marchi  <simon.marchi@ericsson.com>
1818
1819         PR gdb/23379
1820         * python/py-continueevent.c: Include "gdbthread.h".
1821         (create_continue_event_object): Add intro comment.  Add 'ptid'
1822         parameter.  Use it to find thread to pass to
1823         create_thread_event_object.
1824         (emit_continue_event): Pass PTID down to
1825         create_continue_event_object.
1826         * python/py-event.h (py_get_event_thread): Declare.
1827         (create_thread_event_object): Remove default from 'thread'
1828         parameter.
1829         * python/py-stopevent.c (create_stop_event_object): Use
1830         py_get_event_thread.
1831         * python/py-threadevent.c (get_event_thread): Rename to ...
1832         (py_get_event_thread): ... this, make extern, add 'ptid' parameter
1833         and use it to find the thread.
1834         (create_thread_event_object): Assert that THREAD isn't null.
1835         Don't find the event thread here.
1836
1837 2018-08-23  Kevin Buettner  <kevinb@redhat.com>
1838
1839         * block.h (blockrange, blockranges): New struct declarations.
1840         (struct block): Add new field named `ranges'.
1841         (BLOCK_RANGES, BLOCK_NRANGES, BLOCK_RANGE, BLOCK_CONTIGUOUS_P)
1842         (BLOCK_RANGE_START, BLOCK_RANGE_END, BLOCK_ENTRY_PC): New
1843         macros for accessing ranges in struct block.
1844         (make_blockranges): New declaration.
1845         block.c (make_blockranges): New function.
1846         * dwarf2read.c (dwarf2_record_block_ranges): Fill in BLOCK_RANGES
1847         for block.
1848         * symtab.h (find_pc_partial_function): Add new parameter `block'.
1849         * blockframe.c (cache_pc_function_block): New static global.
1850         (clear_pc_function_cache): Clear cache_pc_function_block.
1851         (find_pc_partial_function): Move comment to symtab.h.  Add
1852         support for non-contiguous blocks.
1853         * cli/cli-cmds.c (block.h): Include.
1854         (print_disassembly): Handle printing of non-contiguous blocks.
1855         (disassemble_current_function): Likewise.
1856         (disassemble_command): Likewise.
1857
1858         * ax-gdb.c (gen_var_ref): Use BLOCK_ENTRY_PC in place of
1859         BLOCK_START.
1860         * blockframe.c (get_pc_function_start): Likewise.
1861         * compile/compile-c-symbols.c (convert_one_symbol): Likewise.
1862         (gcc_symbol_address): Likewise.
1863         * compile/compile-object-run.c (compile_object_run): Likewise.
1864         * compile/compile.c (get_expr_block_and_pc): Likewise.
1865         * dwarf2loc.c (dwarf2_find_location_expression): Likewise.
1866         (func_addr_to_tail_call_list): Likewise.
1867         * findvar.c (default_read_var_value): Likewise.
1868         * inline-frame.c (inline_frame_this_id): Likewise.
1869         (skip-inline_frames): Likewise.
1870         * infcmd.c (until_next_command): Likewise.
1871         * linespec.c (convert_linespec_to_sals): Likewise.
1872         * parse.c (parse_exp_in_context_1): Likewise.
1873         * printcmd.c (build_address_symbolic): likewise.
1874         (info_address_command): Likewise.
1875         symtab.c (find_function_start_sal): Likewise.
1876         (skip_prologue_sal): Likewise.
1877         (find_function_alias_target): Likewise.
1878         (find_gnu_ifunc): Likewise.
1879         * stack.c (find_frame_funname): Likewise.
1880         * symtab.c (fixup_symbol_section): Likewise.
1881         (find_function_start_sal): Likewise.
1882         (skip_prologue_sal): Likewsie.
1883         (find_function_alias_target): Likewise.
1884         (find_gnu_ifunc): Likewise.
1885         * tracepoint.c (info_scope_command): Likewise.
1886         * value.c (value_fn_field): Likewise.
1887
1888         * infrun.c (fill_in_stop_func): Use find_function_entry_range_from_pc
1889         in place of find_pc_partial_function.
1890         * blockframe.c (find_function_entry_range_from_pc): New function.
1891         * symtab.h (find_function_entry_range_from_pc): Declare and document.
1892         * objfiles.c (objfile_relocate1): Relocate start and end addresses
1893         for each range in a block.
1894
1895
1896 2018-08-23  Xavier Roirand  <roirand@adacore.com>
1897
1898         * machoread.c (macho_symfile_read_all_oso): Remove uneeded
1899         incrementation.
1900
1901 2018-08-22  Simon Marchi  <simon.marchi@polymtl.ca>
1902
1903         * solib-svr4.c (read_program_headers_from_bfd): Return
1904         gdb::optional<gdb::byte_vector>.
1905         (svr4_exec_displacement): Adjust.
1906
1907 2018-08-22  Simon Marchi  <simon.marchi@polymtl.ca>
1908
1909         * solib-svr4.c (read_program_header): Return
1910         gdb::optional<gdb::byte_vector>, remove p_sect_size param.
1911         (find_program_interpreter): Return
1912         gdb::optional<gdb::byte_vector>.
1913         (scan_dyntag_auxv): Adjust.
1914         (enable_break): Adjust.
1915         (svr4_exec_displacement): Adjust.
1916
1917 2018-08-22  Simon Marchi  <simon.marchi@polymtl.ca>
1918
1919         * inf-child.h (inf_child_target) <terminal_save_inferior>: New.
1920         * inf-child.c (inf_child_target::terminal_save_inferior): New.
1921
1922 2018-08-22  Simon Marchi  <simon.marchi@polymtl.ca>
1923
1924         * guile/scm-string.c (gdbscm_scm_from_printf): Use
1925         string_vprintf.
1926         * guile/scm-utils.c (gdbscm_printf): Likewise.
1927         * serial.c (serial_printf): Likewise.
1928         * xml-support.c (gdb_xml_parser::vdebug): Likewise.
1929
1930 2018-08-22  Jan Vrany  <jan.vrany@fit.cvut.cz>
1931
1932         * stack.c (print_frame): Print frame architecture when printing on
1933         an MI output.
1934         * NEWS: Mention new "arch" attribute in frame output.
1935
1936 2018-08-21  Alan Hayward  <alan.hayward@arm.com>
1937
1938         * arch/aarch64.h (aarch64_regnum): Update comment.
1939
1940 2018-08-21  Alan Hayward  <alan.hayward@arm.com>
1941
1942         * NEWS: Add SVE to 8.2 section.
1943
1944 2018-08-21  Pedro Alves  <palves@redhat.com>
1945
1946         * guile/scm-utils.c (gdbscm_parse_function_args_1): New, factored
1947         out from gdbscm_parse_function_args.
1948         (gdbscm_parse_function_args): Rework to use gdbscm_wrap and
1949         gdbscm_parse_function_args_1.
1950
1951 2018-08-21  Simon Marchi  <simon.marchi@ericsson.com>
1952
1953         PR gdb/17816
1954         * m32c-tdep.c (m32c_decode_srcdest4): Remove unnecessary ternary
1955         operator.
1956
1957 2018-08-19  Simon Marchi  <simon.marchi@polymtl.ca>
1958
1959         * solib-svr4.c (svr4_exec_displacement): Fix formatting.
1960
1961 2018-08-19  Michael Spang  <spang@google.com>
1962
1963         PR gdb/11786
1964         * solib-svr4.c (svr4_exec_displacement): Ignore memsz fields
1965         for PT_TLS segments.
1966
1967 2018-08-18  Kevin Buettner  <kevinb@redhat.com>
1968
1969         * dwarf2expr.h (struct dwarf_expr_context): Add virtual method
1970         dwarf_variable_value.
1971         * dwarf2-frame.c (class dwarf_expr_executor):
1972         Add override for dwarf_variable_value.
1973         * dwarf2loc.c (class dwarf_evaluate_loc_desc): Likewise.
1974         (class symbol_needs_eval_context): Likewise.
1975         (indirect_synthetic_pointer): Add forward declaration.
1976         (sect_variable_value): New function.
1977         (dwarf2_compile_expr_to_ax): Add case for DW_OP_GNU_variable_value.
1978         * dwarf2expr.c (dwarf_expr_context::execute_stack_op): Add case
1979         for DW_OP_GNU_variable_value.
1980
1981 2018-08-16  Tom Tromey  <tom@tromey.com>
1982
1983         * top.c (read_command_file): Update.
1984         (command_line_input): Remove "repeat" argument.
1985         * ada-lang.c (get_selections): Update.
1986         * linespec.c (decode_line_2): Update.
1987         * defs.h (command_line_input): Remove argument.
1988         * cli/cli-script.c (read_next_line): Update.
1989         * python/py-gdb-readline.c: Update.
1990
1991 2018-08-17  Tom Tromey  <tom@tromey.com>
1992
1993         * cli/cli-script.c (read_next_line): Pass 0 as repeat argument to
1994         command_line_input.
1995
1996 2018-08-15  Tom Tromey  <tom@tromey.com>
1997
1998         * aarch64-linux-tdep.c (aarch64_linux_core_read_vq): Use pulongest.
1999
2000 2018-08-14  Jan Vrany  <jan.vrany@fit.cvut.cz>
2001
2002         * mi/mi-cmd-disas.c (mi_cmd_disassemble): Add -a option.
2003         If used, use find_pc_partial_function to find address range
2004         to disassemble.
2005         * mi/mi-main.c (mi_cmd_list_features): Report
2006         "data-disassemble-a-option" feature.
2007         * NEWS: Mention new -data-disassemble option -a.
2008
2009 2018-08-13  Tom Tromey  <tom@tromey.com>
2010
2011         * common/common-defs.h (_FORTIFY_SOURCE): Define.
2012
2013 2018-08-13  Alan Hayward  <alan.hayward@arm.com>
2014
2015         * aarch64-linux-tdep.c (aarch64_linux_supply_sve_regset): New function.
2016         (aarch64_linux_collect_sve_regset): Likewise.
2017         (aarch64_linux_iterate_over_regset_sections): Check for SVE.
2018         * regcache.h (regcache_map_entry_size): New function.
2019
2020 2018-08-13  Alan Hayward  <alan.hayward@arm.com>
2021
2022         * aarch64-linux-tdep.c (SVE_HEADER_SIZE_LENGTH): Add define.
2023         (SVE_HEADER_MAX_SIZE_LENGTH): Likewise.
2024         (SVE_HEADER_VL_LENGTH): Likewise.
2025         (SVE_HEADER_MAX_VL_LENGTH): Likewise.
2026         (SVE_HEADER_FLAGS_LENGTH): Likewise.
2027         (SVE_HEADER_RESERVED_LENGTH): Likewise.
2028         (SVE_HEADER_SIZE_OFFSET): Likewise.
2029         (SVE_HEADER_MAX_SIZE_OFFSET): Likewise.
2030         (SVE_HEADER_VL_OFFSET): Likewise.
2031         (SVE_HEADER_MAX_VL_OFFSET): Likewise.
2032         (SVE_HEADER_FLAGS_OFFSET): Likewise.
2033         (SVE_HEADER_RESERVED_OFFSET): Likewise.
2034         (SVE_HEADER_SIZE): Likewise.
2035         (aarch64_linux_core_read_vq): Add function.
2036         (aarch64_linux_core_read_description): Check for SVE section.
2037
2038 2018-08-13  Alan Hayward  <alan.hayward@arm.com>
2039
2040         * aarch64-fbsd-tdep.c
2041         (aarch64_fbsd_iterate_over_regset_sections): Add supply_size and
2042         collect_size.
2043         * aarch64-linux-tdep.c
2044         (aarch64_linux_iterate_over_regset_sections): Likewise.
2045         * alpha-linux-tdep.c
2046         (alpha_linux_iterate_over_regset_sections):
2047         * alpha-nbsd-tdep.c
2048         (alphanbsd_iterate_over_regset_sections): Likewise.
2049         * amd64-fbsd-tdep.c
2050         (amd64fbsd_iterate_over_regset_sections): Likewise.
2051         * amd64-linux-tdep.c
2052         (amd64_linux_iterate_over_regset_sections): Likewise.
2053         * arm-bsd-tdep.c
2054         (armbsd_iterate_over_regset_sections): Likewise.
2055         * arm-fbsd-tdep.c
2056         (arm_fbsd_iterate_over_regset_sections): Likewise.
2057         * arm-linux-tdep.c
2058         (arm_linux_iterate_over_regset_sections): Likewise.
2059         * corelow.c (get_core_registers_cb): Likewise.
2060         (core_target::fetch_registers): Likewise.
2061         * fbsd-tdep.c (fbsd_collect_regset_section_cb): Likewise.
2062         * frv-linux-tdep.c (frv_linux_iterate_over_regset_sections): Likewise.
2063         * gdbarch.h (void): Regenerate.
2064         * gdbarch.sh: Add supply_size and collect_size.
2065         * hppa-linux-tdep.c (hppa_linux_iterate_over_regset_sections): Likewise.
2066         * hppa-nbsd-tdep.c (hppanbsd_iterate_over_regset_sections): Likewise.
2067         * hppa-obsd-tdep.c (hppaobsd_iterate_over_regset_sections): Likewise.
2068         * i386-fbsd-tdep.c (i386fbsd_iterate_over_regset_sections): Likewise.
2069         * i386-linux-tdep.c (i386_linux_iterate_over_regset_sections): Likewise.
2070         * i386-tdep.c (i386_iterate_over_regset_sections): Likewise.
2071         * ia64-linux-tdep.c (ia64_linux_iterate_over_regset_sections): Likewise.
2072         * linux-tdep.c (linux_collect_regset_section_cb): Likewise.
2073         * m32r-linux-tdep.c (m32r_linux_iterate_over_regset_sections): Likewise.
2074         * m68k-bsd-tdep.c (m68kbsd_iterate_over_regset_sections): Likewise.
2075         * m68k-linux-tdep.c (m68k_linux_iterate_over_regset_sections): Likewise.
2076         * mips-fbsd-tdep.c (mips_fbsd_iterate_over_regset_sections): Likewise.
2077         * mips-linux-tdep.c (mips_linux_iterate_over_regset_sections): Likewise.
2078         * mips-nbsd-tdep.c (mipsnbsd_iterate_over_regset_sections): Likewise.
2079         * mips64-obsd-tdep.c (mips64obsd_iterate_over_regset_sections): Likewise.
2080         * mn10300-linux-tdep.c (am33_iterate_over_regset_sections): Likewise.
2081         * nios2-linux-tdep.c (nios2_iterate_over_regset_sections): Likewise.
2082         * ppc-fbsd-tdep.c (ppcfbsd_iterate_over_regset_sections): Likewise.
2083         * ppc-linux-tdep.c (ppc_linux_iterate_over_regset_sections): Likewise.
2084         * ppc-nbsd-tdep.c (ppcnbsd_iterate_over_regset_sections): Likewise.
2085         * ppc-obsd-tdep.c (ppcobsd_iterate_over_regset_sections): Likewise.
2086         * riscv-linux-tdep.c (riscv_linux_iterate_over_regset_sections): Likewise.
2087         * rs6000-aix-tdep.c (rs6000_aix_iterate_over_regset_sections): Likewise.
2088         * s390-linux-tdep.c (s390_iterate_over_regset_sections): Likewise.
2089         * score-tdep.c (score7_linux_iterate_over_regset_sections): Likewise.
2090         * sh-tdep.c (sh_iterate_over_regset_sections): Likewise.
2091         * sparc-tdep.c (sparc_iterate_over_regset_sections): Likewise.
2092         * tilegx-linux-tdep.c (tilegx_iterate_over_regset_sections): Likewise.
2093         * vax-tdep.c (vax_iterate_over_regset_sections): Likewise.
2094         * xtensa-tdep.c (xtensa_iterate_over_regset_sections): Likewise.
2095
2096 2018-08-10  Simon Marchi  <simon.marchi@ericsson.com>
2097
2098         * nat/linux-osdata.c (commandline_from_pid): Replace xstrprintf
2099         with string_printf.
2100
2101 2018-08-10  Keith Seitz  <keiths@redhat.com>
2102
2103         * compile/compile-c-support.c (add_code_header, add_code_footer):
2104         Move into policy class.
2105         (c_push_user_expression, pop_user_expression_nop)
2106         (c_add_code_header, c_add_code_footer, c_add_input): New policy class.
2107         (compile_program): New host class.
2108         (c_compile_program): New typedef.
2109         (c_compute_porgram): Use c_compile_program.
2110
2111 2018-08-10  Keith Seitz  <keiths@redhat.com>
2112
2113         * compile/compile-internal.h (compile_instance::~compile_instance):
2114         Remove calls to htab_delete.
2115         <m_type_map, m_symbol_err_map>: Switch type to htab_up.
2116         * compile.c (compile_instance::compile_instance): Initialize
2117         htab unique pointers.
2118         (compile_instance::get_cached_type, compile_instance::insert_type)
2119         (compile_instance::error_symbol_once): Update for unique_ptr.
2120
2121 2018-08-10  Keith Seitz  <keiths@redhat.com>
2122
2123         * compile/compile-c-symbols.c (struct symbol_error)
2124         (hash_symbol_error, eq_symbol_error, del_symbol_error)
2125         (compile_instance::insert_symbol_error)
2126         (compile_instance::error_symbol_once): Move to ...
2127         * compile/compile.c: ... here.
2128
2129 2018-08-10  Keith Seitz  <keiths@redhat.com>
2130
2131         * compile/compile-c-support.c (c_get_compile_context): Use `new'
2132         instead of `new_compile_instance'.
2133         * compile/compile-c-symbols.c (compile_instance::insert_symbol_error):
2134         Update description.
2135         If the symbol error map is not initialized, create it.
2136         (generate_c_for_for_one_symbol): Do not check/initialize
2137         the symbol error map.
2138         * compile/compile-c-types.c (compile_c_instance): Make a class.
2139         Update all callers.
2140         (compile_instance::compile_instance): Initialize the type cache.
2141         (get_cached_type): New function.
2142         (insert_type): Update description.
2143         (compile_c_instance::m_default_cflags): Define.
2144         (convert_type): Update description.  Use get_cached_type.
2145         (delete_instance): Moved to destructor.
2146         (new_compile_instance): Moved to constructor.
2147         * compile/compile-c.h (compile_c_instance): Make class inheriting
2148         from compile_instance.
2149         <base>: Remove field.
2150         <type_map, symbol_err_map>: Move to base class.
2151         <c_plugin>: Rename to `m_plugin' and remove pointer type.
2152         * compile/compile-internal.h (compile_instance): Make class.
2153         <type_map_t, symbol_err_map_t>: Define.
2154         <fe>: Rename to `m_gcc_fe'.
2155         <scope, block, gcc_target_options>: Add `m_' prefix.
2156         <m_type_map, m_symbol_err_map>: New fields, moved from
2157         compile_c_instance.
2158         <destroy>: Remove.
2159         (convert_type, new_compile_instance): Remove.
2160         * compile/compile.c (cleanup_compile_instance): Remove.
2161         (compile_to_object): Use unique_ptr to eliminate cleanups.
2162         (compile_instance::set_print_callback, compile_instance::version)
2163         (compile_instance::set_verbose)
2164         (compile_instance::set_driver_filename)
2165         (compile_instance::set_triplet_regexp)
2166         (compile_instance::set_arguments)
2167         (compile_instance::set_source_file)
2168         (compile_instance::compile): Define.
2169
2170 2018-08-10  Keith Seitz  <keiths@redhat.com>
2171
2172         * Makefile.in (HFILES_NO_SRCDIR): Add compile/gcc-c-plugin.h.
2173         * compile/compile-c-types.c: Define GCC_METHODN macros and include
2174         gcc-c-fe.def to define C plugin.
2175         (delete_instance): Delete `c_plugin'.
2176         (new_compile_instance): Initialize `c_plugin'.
2177         * compile/compile-c.h: Include gcc_c_plugin.h.
2178         (struct compile_c_instance) <c_plugin>: New member.
2179         * gcc-c-plugin.h: New file.
2180         Update all callers with API change.
2181
2182 2018-08-10  Keith Seitz  <keiths@redhat.com>
2183
2184         * Makefile.in (SUBDIR_GCC_COMPILE_SRCS): Move header files ...
2185         (HFILES_NO_SRCDIR): ... to here.
2186         Add compile-internal.h and compile-c.h.
2187         * compile/compile-c-support.c: Include compile-c.h.
2188         * compile/compile-c-symbols.c: Include compile-c.h.
2189         (generate_c_for_variable_locations): Update comment.
2190         * compile/compile-c-types.c: Include compile-c.h.
2191         * compile/compile-c.h: New file -- moved C language declarations
2192         from other files here.
2193         * compile/compile-internal.h: Do not include hashtab.h or
2194         common/enum-flags.h.
2195         (gcc_qualifiers_flags, struct compile_c_instance, C_CTX)
2196         (gcc_convert_symbol, gcc_symbol_address)
2197         (generate_c_for_variable_locations, c_get_mode_for_size)
2198         (c_get_range_decl_name): Definitions moved to compile-c.h.
2199         * compile/compile-loc2c.c: Include compile-c.h.
2200
2201 2018-08-10  Keith Seitz  <keiths@redhat.com>
2202
2203         * compile/compile-c-symbols.c (symbol_substitution_name): Rename to ...
2204         (c_symbol_substitution_name): ... this.
2205         Update all callers.
2206
2207 2018-08-10  Keith Seitz  <keiths@redhat.com>
2208
2209         * compile/compile-c-support.c (c_compute_program): Use
2210         unique_xmalloc_ptr to eliminate cleanup.
2211         * compile/compile-c-symbols.c (generate_c_for_variable_locations):
2212         Return a unique_xmalloc_ptr and eliminate cleanup.
2213         * compile/compile-internal.h (generate_c_for_variable_locations):
2214         Return unique_xmalloc_ptr and update description.
2215
2216 2018-08-10  Alan Hayward  <alan.hayward@arm.com>
2217
2218         * corelow.c (core_target::get_core_register_section): Rename
2219         min_size to section_min_size.
2220
2221 2018-08-09  Jim Wilson  <jimw@sifive.com>
2222
2223         * Makefile.in (ALL_TARGET_OBS): Add riscv-linux-tdep.c.
2224         (ALLDEPFILES): Add riscv-linux-nat.c, and riscv-linux-tdep.c.
2225         * NEWS: Mention new GNU/Linux RISC-V target.
2226         * configure.host: Add riscv*-*-linux*.
2227         * configure.nat: Add riscv*.
2228         * configure.tgt: Add riscv*-*-linux*.
2229         * riscv-linux-nat.c: New file.
2230         * riscv-linux-tdep.c: New file.
2231
2232 2018-08-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2233
2234         * infrun.c (resume): Make static, add forward declaration.
2235         (proceed): Update header comment.
2236         * infrun.h (resume): Delete declaration.
2237
2238 2018-08-09  Tom Tromey  <tom@tromey.com>
2239
2240         * riscv-tdep.h: Minor formatting fixes.
2241
2242 2018-08-09  Simon Marchi  <simon.marchi@ericsson.com>
2243
2244         * common/scoped_mmap.c (mmap_file): Silence ARI warning.
2245         * dwarf-index-cache.c (create_dir_and_check): Likewise.
2246         (test_mkdir_recursive): Likewise.
2247         * dwarf-index-write.c (write_psymtabs_to_index): Likewise.
2248
2249 2018-08-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2250
2251         * valarith.c (value_subscripted_rvalue): If an array is not in
2252         memory, and we don't know the upper bound, then we can't know that
2253         the requested element exists or not.
2254
2255 2018-08-08  Simon Marchi  <simon.marchi@ericsson.com>
2256
2257         * target.c (str_comma_list_concat_elem): Fix typo in comment.
2258         (target_options_to_string): Add comment.
2259
2260 2018-08-08  Tom Tromey  <tom@tromey.com>
2261
2262         * unittests/scoped_mmap-selftests.c: Check result of "write".
2263
2264 2018-08-08  Jim Wilson  <jimw@sifive.com>
2265
2266         * riscv-tdep.c (enum opcode): Add jump, branch, lr, and sc opcodes.
2267         (decode_register_index_short): New.
2268         (decode_j_type_insn, decode_cj_type_insn): New.
2269         (decode_b_type_insn, decode_cb_type_insn): New.
2270         (riscv_insn::decode): Add support for jumps, branches, lr, and sc.  New
2271         local xlen.  Check xlen when decoding ambiguous compressed insns.  In
2272         compressed decode, use is_c_lui_insn instead of is_lui_insn, and
2273         is_c_sw_insn instead of is_sw_insn.
2274         (riscv_next_pc, riscv_next_pc_atomic_sequence): New.
2275         (riscv_software_single_step): New.
2276         * riscv-tdep.h (riscv_software_single_step): Declare.
2277
2278         * riscv-tdep.c (riscv_isa_xlen): Drop static.
2279         * riscv-tdep.h (riscv_isa_xlen): Add extern declaration.
2280
2281 2018-08-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2282
2283         PR gdb/18050:
2284         * target.c (dispose_inferior): Don't dispose of inferiors that are
2285         already killed.
2286
2287 2018-08-08  Szabolcs Nagy  <szabolcs.nagy@arm.com>
2288
2289         * remote.c (remote_target::download_tracepoint): Change char* to
2290         const char*.
2291
2292 2018-08-07  Simon Marchi  <simon.marchi@polymtl.ca>
2293
2294         * target.h (target_options_to_string): Return an std::string.
2295         * target.c (str_comma_list_concat_elem): Return void, use
2296         std::string.
2297         (do_option): Likewise.
2298         (target_options_to_string): Return an std::string.
2299         * linux-nat.c (linux_nat_target::wait): Adjust.
2300         * target-debug.h (target_debug_print_options): Adjust.
2301
2302 2018-08-07  Tom Tromey  <tom@tromey.com>
2303
2304         * Makefile.in (CPPFLAGS): New variable.
2305         (INTERNAL_CPPFLAGS): Use it.
2306
2307 2018-08-07  Simon Marchi  <simon.marchi@ericsson.com>
2308
2309         * NEWS: Mention the index cache.
2310
2311 2018-08-07  Simon Marchi  <simon.marchi@ericsson.com>
2312
2313         * common/pathstuff.h (get_standard_cache_dir): New.
2314         * common/pathstuff.c (get_standard_cache_dir): New.
2315         * build-id.h (build_id_to_string): New.
2316         * dwarf-index-common.h (INDEX4_SUFFIX, INDEX5_SUFFIX,
2317         DEBUG_STR_SUFFIX): Move to here.
2318         * dwarf-index-write.c (INDEX4_SUFFIX, INDEX5_SUFFIX,
2319         DEBUG_STR_SUFFIX): Move from there.
2320         (write_psymtabs_to_index): Make non-static, add basename
2321         parameter.  Write to temporary files, rename when done.
2322         (save_gdb_index_command): Adjust call to
2323         write_psymtabs_to_index.
2324         * dwarf2read.h (dwarf2_per_objfile) <index_cache_res>: New
2325         field.
2326         * dwarf2read.c (dwz_file) <index_cache_res>: New field.
2327         (get_gdb_index_contents_from_cache): New.
2328         (get_gdb_index_contents_from_cache_dwz): New.
2329         (dwarf2_initialize_objfile): Read index from cache.
2330         (dwarf2_build_psymtabs): Save to index.
2331         * dwarf-index-cache.h: New file.
2332         * dwarf-index-cache.c: New file.
2333         * dwarf-index-write.h: New file.
2334
2335 2018-08-07  Simon Marchi  <simon.marchi@ericsson.com>
2336
2337         * gnulib/aclocal.m4: Re-generate.
2338         * gnulib/config.in: Re-generate.
2339         * gnulib/configure: Re-generate.
2340         * gnulib/import/Makefile.am: Re-generate.
2341         * gnulib/import/Makefile.in: Re-generate.
2342         * gnulib/import/m4/gnulib-cache.m4: Re-generate.
2343         * gnulib/import/m4/gnulib-comp.m4: Re-generate.
2344         * gnulib/import/m4/mkdir.m4: New file.
2345         * gnulib/import/mkdir.c: New file.
2346         * gnulib/update-gnulib.sh (IMPORTED_GNULIB_MODULES): Add mkdir
2347         module.
2348
2349 2018-08-07  Simon Marchi  <simon.marchi@ericsson.com>
2350
2351         * Makefile.in (COMMON_SFILES): Add common/scoped_mmap.c.
2352         * common/scoped_mmap.c: New file.
2353         * common/scoped_mmap.h (destroy): New method.
2354         (~scoped_mmap, reset): Use destroy.
2355         (scoped_mmap): New move constructor.
2356         (mmap_file): New declaration.
2357         * unittests/scoped_mmap-selftests.c (test_normal,
2358         test_invalid_filename, run_tests): New functions.
2359         (_initialize_scoped_mmap_selftests): Register selftest.
2360
2361 2018-08-07  Simon Marchi  <simon.marchi@ericsson.com>
2362
2363         * dwarf2read.c (read_gdb_index_from_section): Rename to...
2364         (read_gdb_index_from_buffer): ... this.  Remove section
2365         parameter, add buffer parameter.
2366         (get_gdb_index_contents_ftype,
2367         get_gdb_index_contents_dwz_ftype): New typedefs.
2368         (dwarf2_read_gdb_index): Add callback parameters to get the
2369         index contents.
2370         (get_gdb_index_contents_from_section): New.
2371         (dwarf2_initialize_objfile): Update call to
2372         dwarf2_read_gdb_index.
2373
2374 2018-08-07  Simon Marchi  <simon.marchi@ericsson.com>
2375
2376         * common/filestuff.h (gdb_fopen_cloexec): New overload.
2377         (gdb_open_cloexec): Likewise.
2378         * nat/linux-osdata.c (command_from_pid): Use string_printf.
2379         (commandline_from_pid): Likewise.
2380         (linux_xfer_osdata_threads): Likewise.
2381         (linux_xfer_osdata_fds): Likewise.
2382         * ada-lang.c (is_package_name): Likewise.
2383         * auxv.c (procfs_xfer_auxv): Likewise.
2384         * breakpoint.c (print_one_breakpoint_location): Use
2385         uiout::field_fmt.
2386         (print_one_catch_solib): Use string_printf.
2387         * coff-pe-read.c (add_pe_exported_sym): Likewise.
2388         (add_pe_forwarded_sym): Likewise.
2389         * dwarf2read.c (create_type_unit_group): Likewise.
2390         (build_error_marker_type): Likewise.
2391         * infcall.c (get_function_name): Likewise.
2392         * valprint.c (print_converted_chars_to_obstack): Likewise.
2393         * xtensa-tdep.c (xtensa_register_type): Likewise.
2394
2395 2018-08-06  Simon Marchi  <simon.marchi@ericsson.com>
2396
2397         * remote.c (remote_target::download_tracepoint): Fix format
2398         string errors.
2399
2400 2018-08-06  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2401
2402         * tracefile.c: Include common/byte-vector.h.
2403         (trace_save): Change type of buf to gdb::byte_vector.  Initialize
2404         with trace_regblock_size if needed.  Update uses of buf.
2405
2406 2018-08-06  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2407
2408         * tracepoint.h (collection_list) <m_regs_mask>: Change type to
2409         std::vector<unsigned char>.
2410         * tracepoint.c (collection_list::collection_list): Remove
2411         m_regs_mask initializer from initializer list.  Resize
2412         m_regs_mask using the largest remote register number.
2413         (collection_list::add_remote_register): Remove size check on
2414         m_regs_mask.  Use at to access element.
2415         (collection_list::stringify): Change type of temp_buf to
2416         gdb::char_vector.  Update uses of temp_buf.  Resize if needed to
2417         stringify the register mask.  Use pack_hex_byte for the register
2418         mask.
2419
2420 2018-08-06  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2421
2422         * tracepoint.h (class collection_list) <add_register>: Remove.
2423         <add_remote_register, add_ax_registers, add_local_register>:
2424         Declare.
2425         <add_memrange>: Add scope parameter.
2426         * tracepoint.c (encode_actions_1): Likewise.
2427         (collection_list::add_register): Rename to ...
2428         (collection_list::add_remote_register): ... this.  Update
2429         comment.
2430         (collection_list::add_ax_registers, add_local_register): New
2431         methods.
2432         (collection_list::add_memrange): Add scope parameter.  Call
2433         add_local_register instead of add_register.
2434         (finalize_tracepoint_aexpr): New function.
2435         (collection_list::collect_symbol): Update calls to add_memrange.
2436         Call add_local_register instead of add_register.  Call
2437         add_ax_registers.  Call finalize_tracepoint_aexpr.
2438         (encode_actions_1): Get remote regnos for $reg action.  Call
2439         add_remote_register, add_ax_registers, and add_local_register.
2440         Update call to add_memrange.  Call finalize_tracepoint_aexpr.
2441         (validate_actionline): Call finalize_tracepoint_aexpr.
2442
2443 2018-08-06  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2444
2445         * remote.c (remote_target::download_tracepoint): Remove BUF_SIZE.
2446         Replace array buf with gdb::char_vector buf, of size
2447         get_remote_packet_size ().  Replace references to buf and
2448         BUF_SIZE to buf.data () and buf.size ().  Replace strcpy, strcat
2449         and xsnprintf with snprintf.  Raise errors if the buffer is too
2450         small.
2451
2452 2018-08-06  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2453
2454         * remote.c (remote_target::download_tracepoint): Fix the has_more
2455         predicate in the QTDP action list iteration.
2456
2457 2018-08-06  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2458
2459         * remote.c (remote_target::download_tracepoint): Fix indentation
2460         in for block.
2461
2462 2018-08-06  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2463
2464         * proc-api.c (_initialize_proc_api): Remove c, unused.
2465         * procfs.c (procfs_init_inferior): Remove signals, unused.
2466         (procfs_target::make_corefile_notes): Remove old_chain, fpregs,
2467         unused.
2468
2469 2018-08-06  Sergey Korolev  <s.korolev@ndmsystems.com>
2470             Andrew Burgess  <andrew.burgess@embecosm.com>
2471
2472         * linux-nat.c (linux_nat_target::follow_fork): Avoid using
2473         'W_STOPCODE (0)' as this could be ambiguous.
2474
2475 2018-08-03  Sergio Durigan Junior  <sergiodj@redhat.com>
2476
2477         * ser-tcp.c (net_open): Fix thinko when deciding whether to
2478         disable TCP's Nagle algorithm (use "ai_protocol" instead of
2479         "ai_socktype").
2480
2481 2018-08-02  Tom Tromey  <tom@tromey.com>
2482
2483         PR symtab/16842.
2484         * dwarf2read.c (read_func_scope): Set symtab on template parameter
2485         symbols.
2486         (process_structure_scope): Likewise.
2487
2488 2018-08-02  Xavier Roirand  <roirand@adacore.com>
2489
2490         PR gdb/22629:
2491         * darwin-nat.c (darwin_kill_inferior): Fix handling of
2492         kill inferior.
2493
2494 2018-08-02  Tom Tromey  <tom@tromey.com>
2495
2496         * darwin-nat.c (find_inferior_task_it, darwin_find_thread)
2497         (darwin_suspend_inferior, darwin_resume_inferior)
2498         (darwin_decode_notify_message, darwin_resume_inferior_threads)
2499         (darwin_check_new_threads): Check result of get_darwin_inferior.
2500
2501 2018-07-31  Joel Brobecker  <brobecker@adacore.com>
2502
2503         GDB 8.1.1 released.
2504
2505 2018-07-31  Jan Vrany  <jan.vrany@fit.cvut.cz>
2506
2507         * varobj.c (varobj_get_path_expr_parent): Report an error if
2508         parent is a dynamic varobj.
2509
2510 2018-07-31  Simon Marchi  <simon.marchi@ericsson.com>
2511
2512         * gnulib/aclocal.m4: Re-generate.
2513         * gnulib/config.in: Re-generate.
2514         * gnulib/configure: Re-generate.
2515         * gnulib/import/Makefile.in: Re-generate.
2516         * gnulib/import/m4/gnulib-comp.m4: Re-generate.
2517         * gnulib/import/m4/onceonly.m4: Re-generate.
2518
2519 2018-07-31  Simon Marchi  <simon.marchi@ericsson.com>
2520
2521         * target-descriptions.c (struct xml_test_tdesc): New.
2522         (xml_tdesc): Change type to std::vector<xml_test_tdesc>.
2523         (record_xml_tdesc): Update.
2524         (maintenance_check_xml_descriptions): Update.
2525         * target-descriptions.h (record_xml_tdesc): Update comment.
2526
2527 2018-07-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2528
2529         * eval.c (evaluate_subexp_for_sizeof): Check for array type before
2530         checking array bounds are defined.
2531
2532 2018-07-30  Tom Tromey  <tom@tromey.com>
2533
2534         * nat/linux-osdata.c (pid_pgid_entry::operator<): Fix
2535         irreflexivity violation.
2536
2537 2018-07-30  Tom Tromey  <tom@tromey.com>
2538
2539         * cli/cli-decode.c (lookup_cmd): Remove lint code.
2540         * value.c (unpack_long): Remove lint code.
2541         * valops.c (value_ind): Remove lint code.
2542         * valarith.c (value_x_binop, value_x_unop, value_equal)
2543         (value_pos): Remove lint code.
2544
2545 2018-07-28  Tom de Vries  <tdevries@suse.de>
2546
2547         * eval.c (evaluate_subexp_for_sizeof): Interpret size of dynamic type
2548         with undefined upper bound as <optimized out>.
2549
2550 2018-07-27  Sergio Durigan Junior  <sergiodj@redhat.com>
2551
2552         * gcore.in: Rename variable "name" to "prefix".  Expand
2553         "usage" text.
2554
2555 2018-07-14  Jon Turney  <jon.turney@dronecode.org.uk>
2556
2557         * windows-nat.c (windows_nat_target::create_inferior): Update to
2558         call close() in global namespace.
2559
2560 2018-07-26  Tom Tromey  <tom@tromey.com>
2561
2562         * dwarf-index-write.c (add_address_entry): Don't add objfile
2563         offsets.
2564         * dbxread.c (find_stab_function): Rename from
2565         find_stab_function_addr.  Return a bound_minimal_symbol.
2566         (read_dbx_symtab): Use raw_text_low, raw_text_high.
2567         Don't add objfile offsets.
2568         (end_psymtab): Use raw_text_low, raw_text_high,
2569         MSYMBOL_VALUE_RAW_ADDRESS.
2570         (read_ofile_symtab): Update.
2571         (process_one_symbol): Update.
2572         * dwarf2read.c (create_addrmap_from_index): Don't add objfile
2573         offsets.
2574         (dw2_relocate): Remove.
2575         (dw2_find_pc_sect_symtab): Bias PC by the text offset before
2576         searching addrmap.
2577         (dwarf2_gdb_index_functions, dwarf2_debug_names_functions):
2578         Update.
2579         (process_psymtab_comp_unit_reader, add_partial_symbol)
2580         (add_partial_subprogram, dwarf2_ranges_read): Update.
2581         (load_partial_dies): Update.
2582         (add_address_entry): Don't add objfile offsets.
2583         (dwarf2_build_include_psymtabs): Update.
2584         (create_addrmap_from_aranges): Don't add objfile offsets.
2585         (dw2_find_pc_sect_compunit_symtab): Update.
2586         * mdebugread.c (parse_symbol): Don't add objfile offsets.
2587         (parse_lines): Remove 'pst' parameter, replace with 'textlow'.
2588         Update.
2589         (parse_partial_symbols): Don't add objfile offsets.  Use
2590         raw_text_low, raw_text_high.  Update.
2591         (handle_psymbol_enumerators, psymtab_to_symtab_1): Update.
2592         * objfiles.c (objfile_relocate1): Don't relocate psymtabs_addrmap
2593         or call 'relocate' quick function.  Clear psymbol_map.
2594         * psympriv.h (struct partial_symbol) <address>: Add section
2595         offset.
2596         <set_unrelocated_address>: Rename from set_address.
2597         <raw_text_low, raw_text_high>: New methods.
2598         <text_low, text_high>: Add objfile parameter.
2599         (add_psymbol_to_bcache): Add 'section' parameter.  Call
2600         set_unrelocated_address.
2601         * psymtab.c (find_pc_sect_psymtab_closer, find_pc_sect_psymtab)
2602         (find_pc_psymbol): Update.
2603         (fixup_psymbol_section, relocate_psymtabs): Remove.
2604         (dump_psymtab, psym_functions): Update.
2605         (add_psymbol_to_bcache, add_psymbol_to_list): Add 'section'
2606         parameter.
2607         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
2608         (start_psymtab_common): Update.
2609         * symfile-debug.c (debug_qf_relocate): Remove.
2610         (debug_sym_quick_functions): Update.
2611         * symfile.h (struct quick_symbol_functions) <relocate>: Remove.
2612         * xcoffread.c (scan_xcoff_symtab): Don't add objfile offsets.
2613         Update.
2614
2615 2018-07-26  Tom Tromey  <tromey@redhat.com>
2616
2617         * dbxread.c (end_psymtab): Use text_high_valid and
2618         text_low_valid.
2619         * mdebugread.c (parse_partial_symbols): Use text_low_valid.
2620         (psymtab_to_symtab_1): Use text_high_valid and text_low_valid.
2621         * psympriv.h (struct partial_symtab) <m_text_low, m_text_high>:
2622         Update comment.
2623         <text_low_valid, text_high_valid>: New fields.
2624         <set_text_low, set_text_high>: Update.
2625         * xcoffread.c (scan_xcoff_symtab): Use text_low_valid.
2626
2627 2018-07-26  Tom Tromey  <tom@tromey.com>
2628
2629         * dbxread.c (read_dbx_symtab, end_psymtab, read_ofile_symtab):
2630         Update.
2631         * dwarf2read.c (dwarf2_create_include_psymtab): Don't initialize
2632         textlow and texthigh fields.
2633         (process_psymtab_comp_unit_reader, dwarf2_build_include_psymtabs):
2634         Update.
2635         * mdebugread.c (parse_lines, parse_partial_symbols)
2636         (psymtab_to_symtab_1): Update.
2637         * psympriv.h (struct partial_symtab) <m_text_low, m_text_high>:
2638         Rename fields.  Update comment.  Now private.
2639         <text_low, text_high, set_text_low, set_text_high>: New methods.
2640         * psymtab.c (find_pc_sect_psymtab_closer, find_pc_sect_psymtab)
2641         (find_pc_sect_psymbol, relocate_psymtabs, dump_psymtab)
2642         (start_psymtab_common, maintenance_info_psymtabs)
2643         (maintenance_check_psymtabs): Update.
2644         * xcoffread.c (xcoff_end_psymtab): Don't initialize textlow and
2645         texthigh fields.
2646         (scan_xcoff_symtab): Update.
2647
2648 2018-07-26  Tom Tromey  <tromey@redhat.com>
2649
2650         * psympriv.h (struct partial_symbol) <unrelocated_address,
2651         address, set_address>: New methods.
2652         * psymtab.c (find_pc_sect_psymtab_closer, find_pc_sect_psymbol)
2653         (fixup_psymbol_section, relocate_psymtabs): Update.
2654         (print_partial_symbols): Add 'objfile' parameter.  Update.
2655         (dump_psymtab, add_psymbol_to_bcache, psym_fill_psymbol_map):
2656         Update.
2657
2658 2018-07-26  Tom Tromey  <tom@tromey.com>
2659
2660         * dwarf-index-write.c (write_psymbols, debug_names::insert)
2661         (debug_names::write_psymbols): Update.
2662         * psympriv.h (struct partial_symbol): Derive from
2663         general_symbol_info.
2664         <obj_section>: New method.
2665         (PSYMBOL_DOMAIN, PSYMBOL_CLASS): Remove.n
2666         * psymtab.c (find_pc_sect_psymtab_closer, find_pc_sect_psymtab)
2667         (find_pc_sect_psymbol, fixup_psymbol_section)
2668         (match_partial_symbol, lookup_partial_symbol, relocate_psymtabs)
2669         (print_partial_symbols, recursively_search_psymtabs)
2670         (compare_psymbols, psymbol_hash, psymbol_compare)
2671         (add_psymbol_to_bcache, maintenance_check_psymtabs)
2672         (psymbol_name_matches, psym_fill_psymbol_map): Update.
2673
2674 2018-07-26  Tom Tromey  <tromey@redhat.com>
2675
2676         * dbxread.c (end_psymtab): Remove dead code.
2677
2678 2018-07-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2679
2680         * dwarf2-frame-tailcall.c (tailcall_frame_sniffer): Exit early if
2681         DWARF unwinders are disabled.
2682         * dwarf2-frame.c: Add dwarf2read.h include.
2683         (dwarf2_frame_sniffer): Exit early if DWARF unwinders are
2684         disabled.
2685         (dwarf2_frame_unwinders_enabled_p): Define.
2686         (show_dwarf_unwinders_enabled_p): New function.
2687         (_initialize_dwarf2_frame): Register switch to control DWARF
2688         unwinder use.
2689         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Declare.
2690         * dwarf2read.c (set_dwarf_cmdlist): Remove static keyword.
2691         (show_dwarf_cmdlist): Remove static keyword.
2692         * dwarf2read.h (set_dwarf_cmdlist): Declare.
2693         (show_dwarf_cmdlist): Declare.
2694         * NEWS: Document new feature.
2695
2696 2018-07-26  Tom de Vries  <tdevries@suse.de>
2697
2698         PR breakpoints/23366
2699         * infcmd.c (info_program_command): Handle ptid == minus_one_ptid.
2700
2701 2018-07-26  Tom de Vries  <tdevries@suse.de>
2702
2703         * dwarf2read.c (read_subrange_type): Warn if DW_AT_upper_bound or
2704         DW_AT_count can't be translated to a dynamic prop.
2705
2706 2018-07-25  Tom de Vries  <tdevries@suse.de>
2707
2708         * dwarf2loc.c (dwarf2_locexpr_baton_eval): Wrap ctx.eval call in
2709         try/catch.
2710
2711 2018-07-25  Jan Vrany  <jan.vrany@fit.cvut.cz>
2712
2713         * breakpoint.c (enable_disable_bp_num_loc): Notify observers.
2714
2715 2018-07-25  Joel Brobecker  <brobecker@adacore.com>
2716
2717         * MAINTAINERS (Global Maintainers): Add Tom Tromey.
2718
2719 2018-07-24  Keith Seitz  <keiths@redhat.comt
2720
2721         PR symtab/23010
2722         * dwarf2read.c (dw2_add_symbol_to_list): New function.
2723         (fixup_go_packaging, new_symbol): Use dw2_add_symbol_to_list
2724         instead of add_symbol_to_list.
2725         (read_file_scope): Call prepare_one_comp_unit before reading
2726         any other DIEs.
2727
2728 2018-07-24  Simon Marchi  <simon.marchi@ericsson.com>
2729
2730         * common/scoped_mmap.h (class scoped_mmap): Fix indentation.
2731
2732 2018-07-24  Tom Tromey  <tom@tromey.com>
2733
2734         * utils.c (malloc, realloc, free): Don't declare.
2735         * configure, config.in: Rebuild.
2736         * configure.ac: Don't check for declarations of free, malloc, or
2737         realloc.
2738
2739 2018-07-22  Simon Marchi  <simon.marchi@polymtl.ca>
2740
2741         * aarch64-linux-nat.c
2742         (aarch64_linux_nat_target::stopped_data_address): Remove unused
2743         variable.
2744         * arm-linux-nat.c (fetch_regs): Likewise.
2745         (store_regs): Likewise.
2746         (fetch_vfp_regs): Likewise.
2747         (store_vfp_regs): Likewise.
2748         (arm_linux_nat_target::insert_hw_breakpoint): Likewise.
2749         (arm_linux_nat_target::remove_hw_breakpoint): Likewise.
2750         (arm_linux_nat_target::insert_watchpoint): Likewise.
2751         (arm_linux_nat_target::remove_watchpoint): Likewise.
2752         * mips-linux-nat.c (mips_linux_nat_target::insert_watchpoint):
2753         Likewise.
2754         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_get_sveregs):
2755         Likewise.
2756         * ppc-linux-nat.c (fetch_register): Likewise.
2757         (fetch_all_gp_regs): Likewise.
2758         (fetch_ppc_registers): Likewise.
2759         (store_all_gp_regs): Likewise.
2760         (store_ppc_registers): Likewise.
2761         (hwdebug_insert_point): Likewise.
2762         (can_use_watchpoint_cond_accel): Likewise.
2763         * remote-sim.c (gdb_os_write_stdout): Likewise.
2764
2765 2018-07-22  Simon Marchi  <simon.marchi@polymtl.ca>
2766             Tom Tromey  <tom@tromey.com>
2767
2768         * warning.m4 (AM_GDB_WARNINGS): Add -Wunused-variable and special
2769         test for it.
2770         * configure: Rebuild.
2771
2772 2018-07-22  Tom Tromey  <tom@tromey.com>
2773
2774         * regformats/regdat.sh: Define xmltarget_${name} inside
2775         #ifndef IN_PROCESS_AGENT.
2776
2777 2018-07-22  Tom Tromey  <tom@tromey.com>
2778
2779         * value.c (value_fetch_lazy_bitfield): Remove unused variable.
2780
2781 2018-07-22  Tom Tromey  <tom@tromey.com>
2782
2783         * symfile.c (reread_symbols): Notify iter, not objfile.
2784
2785 2018-07-22  Tom Tromey  <tom@tromey.com>
2786
2787         * ravenscar-thread.c (ravenscar_thread_target::store_registers):
2788         Use arch_ops.
2789         (ravenscar_thread_target::prepare_to_store): Likewise.
2790
2791 2018-07-22  Tom Tromey  <tom@tromey.com>
2792
2793         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Remove
2794         unused variable.  Call value_fetch_lazy when needed.
2795         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
2796         Remove unused variable.  Call value_fetch_lazy when needed.
2797
2798 2018-07-22  Tom Tromey  <tom@tromey.com>
2799
2800         * m32c-tdep.c (mark_dma): Return void.
2801         (make_regs): Remove unused declarations.
2802
2803 2018-07-22  Tom Tromey  <tom@tromey.com>
2804
2805         * guile/scm-cmd.c (gdbscm_dont_repeat): Call
2806         cmdscm_get_valid_command_smob_arg_unsafe for effect.
2807         * guile/scm-block.c (gdbscm_make_block_syms_iter): Call
2808         bkscm_get_valid_block_smob_arg_unsafe for effect.
2809
2810 2018-07-22  Tom Tromey  <tom@tromey.com>
2811
2812         * bfin-tdep.c (bfin_push_dummy_call): Use arg_type, not
2813         value_type.
2814
2815 2018-07-22  Tom Tromey  <tom@tromey.com>
2816
2817         * windows-nat.c (saved_context): Conditionally define.
2818         * remote.c (remote_target::remote_btrace_maybe_reopen):
2819         Conditionally declare "warned".
2820         * inflow.c (sigquit_ours): Conditionally define.
2821         (new_tty): Move "tty" declaration inside #if.
2822         * guile/guile.c (guile_datadir): Conditionally define.
2823         * charset.c (set_be_le_names): Move some declarations inside #if.
2824         * btrace.c (parse_xml_btrace): Move "errcode" declaration inside
2825         #if.
2826         (parse_xml_btrace_conf): Likewise.
2827
2828 2018-07-22  Tom Tromey  <tom@tromey.com>
2829
2830         * spu-tdep.c (spu_get_overlay_table): Remove unused variable.
2831
2832 2018-07-22  Tom Tromey  <tom@tromey.com>
2833
2834         * guile/scm-value.c (gdbscm_value_call): Remove unused variables.
2835         * guile/scm-math.c (vlscm_unop_gdbthrow, vlscm_binop_gdbthrow)
2836         (vlscm_convert_typed_value_from_scheme): Remove unused variable.
2837         * buildsym-legacy.c (get_macro_table): Remove unused variable.
2838         * stack.c (frame_apply_level_command): Remove unused variable.
2839         * tic6x-tdep.c (tic6x_push_dummy_call): Remove unused variable.
2840         * sparc64-tdep.c (adi_examine_command): Remove unused variable.
2841         * rs6000-lynx178-tdep.c (rs6000_lynx178_push_dummy_call): Remove
2842         unused variable.
2843         * nios2-tdep.c (nios2_push_dummy_call): Remove unused variable.
2844         * mep-tdep.c (mep_push_dummy_call): Remove unused variable.
2845         * ada-lang.c (ada_lookup_symbol_list_worker): Remove unused
2846         variable.
2847         * amd64-tdep.c (amd64_supply_xsave): Remove unused variable.
2848         * arm-tdep.c (arm_record_data_proc_misc_ld_str): Remove unused
2849         variable.
2850         * breakpoint.c (check_no_tracepoint_commands, update_watchpoint):
2851         Remove unused variable.
2852         * cli/cli-script.c (recurse_read_control_structure): Remove unused
2853         variable.
2854         * common/tdesc.c (print_xml_feature::visit): Remove unused
2855         variable.
2856         * compile/compile-object-load.c (store_regs): Remove unused
2857         variables.
2858         * complaints.c (clear_complaints): Remove unused variable.
2859         * corelow.c (core_target_open): Remove unused variable.
2860         * fbsd-tdep.c (fbsd_core_info_proc_status): Remove unused
2861         variable.
2862         * guile/scm-frame.c (gdbscm_frame_read_var): Remove unused
2863         variable.
2864         * guile/scm-symtab.c (stscm_print_sal_smob): Remove unused
2865         variable.
2866         * guile/scm-type.c (gdbscm_field_baseclass_p): Remove unused
2867         variable.
2868         * guile/scm-utils.c (gdbscm_parse_function_args): Remove unused
2869         variable.
2870         * hppa-tdep.c (hppa_stub_frame_unwind_cache): Remove unused
2871         variable.
2872         * ia64-tdep.c (examine_prologue): Remove unused variable.
2873         * infcall.c (run_inferior_call): Remove unused variable.
2874         * inferior.c (exit_inferior): Remove unused variable.
2875         * infrun.c (infrun_thread_ptid_changed): Remove unused variable.
2876         * linespec.c (decode_line_2): Remove unused variable.
2877         * linux-nat.c (super_close): Remove.
2878         * linux-tdep.c (linux_info_proc): Remove unused variable.
2879         * mi/mi-main.c (mi_execute_command): Remove unused variable.
2880         * microblaze-linux-tdep.c (microblaze_linux_sigtramp_cache):
2881         Remove unused variable.
2882         * parse.c (find_minsym_type_and_address): Remove unused variable.
2883         * printcmd.c (info_symbol_command, printf_floating): Remove unused
2884         variable.
2885         * python/py-breakpoint.c (bppy_set_commands): Remove unused
2886         variable.
2887         * python/py-unwind.c (unwind_infopy_dealloc): Remove unused
2888         variables.
2889         * record-btrace.c (record_btrace_target::store_registers): Remove
2890         unused variable.
2891         (cmd_show_record_btrace_cpu): Remove unused variable.
2892         * riscv-tdep.c (riscv_register_reggroup_p)
2893         (riscv_push_dummy_call, riscv_return_value): Remove unused
2894         variable.
2895         * rust-exp.y (literal): Remove unused variable.
2896         * rust-lang.c (rust_evaluate_subexp) <OP_RUST_ARARAY>: Remove
2897         unused variable.
2898         <STRUCTOP_ANONYMOUS>: Likewise.
2899         * s390-linux-tdep.c (s390_linux_init_abi_31)
2900         (s390_linux_init_abi_64): Remove unused variable.
2901         * ser-ming2.c (ser_windows_read_prim, pipe_select_thread)
2902         (file_select_thread, net_windows_open, _initialize_ser_windows):
2903         Remove unused variables.
2904         * symtab.c (find_pc_sect_line): Remove unused variable.
2905         * target-memory.c (compute_garbled_blocks): Remove unused
2906         variable.
2907         (target_write_memory_blocks): Remove unused variable.
2908         * target.c (target_stack::unpush): Remove unused variables.
2909         * tracepoint.c (start_tracing, all_tracepoint_actions)
2910         (merge_uploaded_trace_state_variables)
2911         (print_one_static_tracepoint_marker): Remove unused variable.
2912         * unittests/basic_string_view/element_access/char/1.cc (test01):
2913         Remove unused variable.
2914         * windows-nat.c (windows_continue, windows_add_all_dlls)
2915         (do_initial_windows_stuff, windows_nat_target::create_inferior):
2916         Remove unused variables.
2917
2918 2018-07-21  Simon Marchi  <simon.marchi@polymtl.ca>
2919
2920         * arm-tdep.c (arm_gdbarch_init): Declare attr_arch and
2921         attr_profile in HAVE_ELF.
2922         * rs6000-tdep.c (bfd_uses_spe_extensions): Declare vector_abi in
2923         HAVE_ELF.
2924
2925 2018-07-20  Simon Marchi  <simon.marchi@polymtl.ca>
2926
2927         * frame.c (frame_register_unwind): Change parameter name.
2928         (frame_unwind_register): Likewise.
2929         (frame_unwind_register_value): Likewise.
2930         (frame_unwind_register_signed): Likewise.
2931         (frame_unwind_register_unsigned): Likewise.
2932         * frame.h (frame_register_unwind): Likewise.
2933         (frame_unwind_register): Likewise.
2934         (frame_unwind_register_value): Likewise.
2935         (frame_unwind_register_signed): Likewise.
2936         (frame_unwind_register_unsigned): Likewise.
2937         (frame_unwind_arch): Likewise.
2938
2939 2018-07-20  Maciej W. Rozycki  <macro@mips.com>
2940
2941         * MAINTAINERS: Update my e-mail address, downgrade to MIPS I-IV
2942         ISA maintenance.
2943
2944 2018-07-20  Maciej W. Rozycki  <macro@mips.com>
2945
2946         * mips-linux-nat.c (mips_linux_nat_target::read_description):
2947         Call `get_ptrace_pid' rather than extracting the ptrace PID by
2948         hand.
2949
2950 2018-07-20  Keith Seitz  <keiths@redhat.com>
2951
2952         * buildsym.h (struct buildsym_compunit) <m_objfile, m_subfiles,
2953         m_main_subfile, m_comp_dir, m_producer, m_debugformat,
2954         m_compunit_symtab, m_language>: Add "m_" prefix.
2955         Update all uses.
2956         * buildsym.c: Update all uses.
2957
2958 2018-07-20  Tom Tromey  <tom@tromey.com>
2959
2960         * buildsym-legacy.h (record_line): Don't use record_line_ftype.
2961         * buildsym.h (record_line_ftype): Remove typedef.
2962
2963 2018-07-20  Tom Tromey  <tom@tromey.com>
2964
2965         * buildsym-legacy.h (augment_type_symtab): Don't declare.
2966         (end_expandable_symtab): Likewise.
2967         (end_symtab_get_static_block): Likewise.
2968         (end_symtab_from_static_block): Likewise.
2969         * buildsym-legacy.c (augment_type_symtab): Remove.
2970         (end_expandable_symtab): Remove.
2971         (end_symtab_get_static_block): Remove.
2972         (end_symtab_from_static_block): Remove.
2973
2974 2018-07-20  Tom Tromey  <tom@tromey.com>
2975
2976         * dwarf2read.c: Include buildsym.h.
2977         (struct dwarf2_cu) <builder>: New method.
2978         (fixup_go_packaging): Update.
2979         (process_full_comp_unit, process_full_type_unit): Update.  Don't
2980         use scoped_free_pendings.
2981         (using_directives): Add "cu" parameter, remove "language".
2982         (read_import_statement, setup_type_unit_groups, )
2983         (read_func_scope, read_lexical_block_scope)
2984         (dwarf2_record_block_ranges, read_namespace): Update.
2985         (lnp_state_machine::lnp_state_machine): Add cu parameter.
2986         (lnp_state_machine::handle_end_sequence): Update.
2987         (class lnp_state_machine) <m_cu>: New member.
2988         <m_record_line_callback>: Remove.
2989         <m_currently_recording_lines>: New member.
2990         (lnp_state_machine::handle_set_file): Update.
2991         (noop_record_line): Remove.
2992         (dwarf_record_line_p): Add cu parameter.
2993         (dwarf_record_line_1, dwarf_finish_line): Likewise.
2994         (lnp_state_machine::record_line)
2995         (lnp_state_machine::lnp_state_machine)
2996         (lnp_state_machine::check_line_address, dwarf_decode_lines_1)
2997         (dwarf_decode_lines): Update.
2998         (dwarf2_start_subfile): Add cu parameter.
2999         (dwarf2_start_symtab, new_symbol): Update.
3000         (macro_start_file, dwarf_decode_macro_bytes): Add cu parameter.
3001         Remove dwarf2_per_objfile parameter.
3002         (dwarf_decode_macros): Update.
3003
3004 2018-07-20  Tom Tromey  <tom@tromey.com>
3005
3006         * stabsread.c (define_symbol): Update.
3007         * buildsym-legacy.h (get_buildsym_compunit): Declare.
3008         * dwarf2read.c (new_symbol): Update.
3009         * cp-support.h (cp_scan_for_anonymous_namespaces): Update.
3010         * cp-namespace.c: Include buildsym.h.
3011         (cp_scan_for_anonymous_namespaces): Add "compunit" parameter.
3012         * buildsym-legacy.c (get_buildsym_compunit): New function.
3013
3014 2018-07-20  Tom Tromey  <tom@tromey.com>
3015
3016         * xcoffread.c: Include buildsym-legacy.h.
3017         * windows-nat.c: Include buildsym-legacy.h.
3018         * stabsread.c: Include buildsym-legacy.h.
3019         * mdebugread.c: Include buildsym-legacy.h.
3020         * buildsym-legacy.h: New file.
3021         * buildsym-legacy.c: New file, from buildsym.c.
3022         * go32-nat.c: Include buildsym-legacy.h.
3023         * dwarf2read.c: Include buildsym-legacy.h.
3024         * dbxread.c: Include buildsym-legacy.h.
3025         * cp-namespace.c: Include buildsym-legacy.h.
3026         * coffread.c: Include buildsym-legacy.h.
3027         * buildsym.h: Move some contents to buildsym-legacy.h.
3028         * buildsym.c: Include buildsym-legacy.h.  Move many functions to
3029         buildsym-legacy.c.
3030         * Makefile.in (HFILES_NO_SRCDIR): Add buildsym-legacy.h.
3031
3032 2018-07-20  Tom Tromey  <tom@tromey.com>
3033
3034         * buildsym.h (struct buildsym_compunit): Move from buildsym.c.
3035         * buildsym.c (struct buildsym_compunit): Move to buildsym.h.
3036         (buildsym_compunit::buildsym_compunit)
3037         (buildsym_compunit::~buildsym_compunit)
3038         (buildsym_compunit::get_macro_table): Define.
3039
3040 2018-07-20  Tom Tromey  <tom@tromey.com>
3041
3042         * buildsym.c (reset_symtab_globals): Remove.
3043         (buildsym_compunit::end_symtab_from_static_block): Update.
3044         (buildsym_compunit::augment_type_symtab): Update.
3045         (end_symtab_from_static_block): Call free_buildsym_compunit.
3046         (augment_type_symtab, end_symtab, end_expandable_symtab):
3047         Likewise.
3048
3049 2018-07-20  Tom Tromey  <tom@tromey.com>
3050
3051         * arch-utils.c: Do not include buildsym.h.
3052         * mipsread.c: Do not include buildsym.h.
3053         * machoread.c: Do not include buildsym.h.
3054         * elfread.c: Do not include buildsym.h.
3055
3056 2018-07-20  Tom Tromey  <tom@tromey.com>
3057
3058         * buildsym.c (buildsym_compunit::buildsym_compunit): Do more
3059         initialization.
3060         (buildsym_compunit): Add new constructor.
3061         (struct buildsym_compunit) <get_last_source_file, finish_block,
3062         record_block_range, start_subfile, patch_subfile_names,
3063         push_subfile, pop_subfile, record_line, get_compunit_symtab,
3064         set_last_source_start_addr, get_last_source_start_addr,
3065         get_local_using_directives, set_local_using_directives,
3066         get_global_using_directives, outermost_context_p,
3067         get_current_context_stack, get_context_stack_depth,
3068         get_current_subfile, get_local_symbols, get_file_symbols,
3069         get_global_symbols, record_debugformat, record_producer,
3070         push_context, pop_context, end_symtab_get_static_block,
3071         end_symtab_from_static_block, end_symtab, end_expandable_symtab>:
3072         New public methods.
3073         <record_pending_block, finish_block_internal, make_blockvector,
3074         watch_main_source_file_lossage, end_symtab_with_blockvector>: New
3075         private methods.
3076         Update all users.
3077
3078 2018-05-22  Tom Tromey  <tom@tromey.com>
3079
3080         * buildsym.c (record_pending_block): Move earlier.  Remove objfile
3081         parameter.
3082         (finish_block_internal): Update.
3083
3084 2018-07-20  Tom Tromey  <tom@tromey.com>
3085
3086         * buildsym.c (record_pending_block): Move earlier.  Remove objfile
3087         parameter.
3088         (finish_block_internal): Update.
3089
3090 2018-07-20  Tom Tromey  <tom@tromey.com>
3091
3092         * buildsym.h (EXTERN): Don't define or undef.
3093         * buildsym.c (EXTERN): Don't define.
3094
3095 2018-07-20  Tom Tromey  <tom@tromey.com>
3096
3097         * buildsym.c: Remove TODO comment.
3098
3099 2018-07-20  Tom Tromey  <tom@tromey.com>
3100
3101         * coffread.c (coff_symtab_read): Update.
3102         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
3103         (xcoff_new_init): Update.
3104         * mipsread.c (mipscoff_new_init): Update.
3105         * mdebugread.c (mdebug_build_psymtabs): Update.
3106         * elfread.c (elf_new_init): Update.
3107         * dwarf2read.c (process_full_comp_unit, process_full_type_unit):
3108         Update.
3109         * dbxread.c (dbx_new_init, dbx_psymtab_to_symtab_1)
3110         (coffstab_build_psymtabs, elfstab_build_psymtabs)
3111         (stabsect_build_psymtabs): Update.
3112         * buildsym.h (buildsym_init): Don't declare.
3113         * buildsym.c: Update comment.
3114         (prepare_for_building): Remove.
3115         (start_symtab, restart_symtab): Update.
3116         (reset_symtab_globals): Update comment.
3117         (buildsym_init): Remove.
3118
3119 2018-07-20  Tom Tromey  <tom@tromey.com>
3120
3121         * xcoffread.c (read_xcoff_symtab, process_xcoff_symbol): Update.
3122         * stabsread.c (patch_block_stabs, define_symbol, read_type)
3123         (read_enum_type, common_block_start, common_block_end)
3124         (cleanup_undefined_types_1, finish_global_stabs): Update.
3125         * mdebugread.c (psymtab_to_symtab_1): Update.
3126         * dwarf2read.c (fixup_go_packaging, read_func_scope)
3127         (read_lexical_block_scope, new_symbol): Update.
3128         * dbxread.c (process_one_symbol): Update.
3129         * coffread.c (coff_symtab_read, process_coff_symbol)
3130         (coff_read_enum_type): Update.
3131         * buildsym.h (file_symbols, global_symbols, local_symbols): Don't
3132         declare.
3133         (get_local_symbols, get_file_symbols, get_global_symbols): New
3134         functions.
3135         * buildsym.c (~buildsym_compunit): Clean up m_file_symbols and
3136         m_global_symbols.
3137         <m_file_symbols, m_local_symbols, m_global_symbols>: New members.
3138         (~scoped_free_pendings): Update.
3139         (finish_block, prepare_for_building, reset_symtab_globals)
3140         (end_symtab_get_static_block, end_symtab_with_blockvector)
3141         (augment_type_symtab, push_context): Update.
3142         (get_local_symbols, get_file_symbols, get_global_symbols): New
3143         functions.
3144         (buildsym_init): Update.
3145
3146 2018-07-20  Tom Tromey  <tom@tromey.com>
3147
3148         * dwarf2read.c (process_full_comp_unit): Do not set list_in_scope.
3149         (process_full_type_unit): Likewise.
3150         (dwarf2_start_symtab): Set list_in_scope.
3151
3152 2018-07-20  Tom Tromey  <tom@tromey.com>
3153
3154         * dwarf2read.c (process_psymtab_comp_unit_reader)
3155         (build_type_psymtabs_reader): Do not set list_in_scope.
3156
3157 2018-07-20  Tom Tromey  <tom@tromey.com>
3158
3159         * buildsym.c (free_pendings): Remove.
3160         (add_symbol_to_list, scoped_free_pendings)
3161         (finish_block_internal, buildsym_init): Update.
3162
3163 2018-07-20  Tom Tromey  <tom@tromey.com>
3164
3165         * xcoffread.c (read_xcoff_symtab): Update.
3166         * dwarf2read.c (read_func_scope, read_lexical_block_scope):
3167         Update.
3168         * dbxread.c (process_one_symbol): Update.
3169         * coffread.c (coff_symtab_read): Update.
3170         * buildsym.h (finish_block): Update.
3171         * buildsym.c (finish_block): Remove "listhead" argument.
3172         (end_symtab_get_static_block): Update.
3173
3174 2018-07-20  Tom Tromey  <tom@tromey.com>
3175
3176         * buildsym.h (class scoped_free_pendings): Remove constructor.
3177         * buildsym.c (struct buildsym_compunit) <free_pending_blocks>: New
3178         method.
3179         <m_pending_block_obstack, m_pending_blocks>: New members.
3180         (pending_block_obstack, pending_blocks): Remove.
3181         (scoped_free_pendings::scoped_free_pendings): Default.
3182         (~scoped_free_pendings): Update.
3183         (free_pending_blocks): Remove.
3184         (finish_block_internal, record_pending_block, make_blockvector)
3185         (end_symtab_get_static_block, augment_type_symtab, push_context)
3186         (buildsym_init): Update.
3187
3188 2018-07-20  Tom Tromey  <tom@tromey.com>
3189
3190         * buildsym.c (struct buildsym_compunit) <m_pending_addrmap,
3191         m_pending_addrmap_obstack, m_pending_addrmap_interesting>: New
3192         members.
3193         (pending_addrmap, pending_addrmap_obstack)
3194         (pending_addrmap_interesting): Remove.
3195         (scoped_free_pendings, record_block_range, make_blockvector)
3196         (prepare_for_building, reset_symtab_globals, buildsym_init):
3197         Update.
3198
3199 2018-07-20  Tom Tromey  <tom@tromey.com>
3200
3201         * xcoffread.c (process_linenos): Update.
3202         * stabsread.c (define_symbol, read_type, read_enum_type): Update.
3203         * mdebugread.c (psymtab_to_symtab_1): Update.
3204         * dwarf2read.c (setup_type_unit_groups)
3205         (lnp_state_machine::handle_set_file, dwarf_record_line_p)
3206         (lnp_state_machine::record_line, dwarf_decode_lines): Update.
3207         * dbxread.c (process_one_symbol): Update.
3208         * coffread.c (coff_symtab_read, enter_linenos)
3209         (process_coff_symbol): Update.
3210         * buildsym.h (current_subfile): Don't declare.
3211         (get_current_subfile): Declare.
3212         * buildsym.c (struct buildsym_compunit) <m_current_subfile>: New
3213         member.
3214         (start_subfile, free_buildsym_compunit, push_subfile)
3215         (prepare_for_building, start_symtab): Update.
3216         (get_current_subfile): New function.
3217
3218 2018-07-20  Tom Tromey  <tom@tromey.com>
3219
3220         * coffread.c (coff_symtab_read): Update.
3221         * xcoffread.c (read_xcoff_symtab): Update.
3222         * dwarf2read.c (new_symbol): Update.
3223         (read_func_scope, read_lexical_block_scope): Update.
3224         * dbxread.c (process_one_symbol): Update.
3225         * buildsym.h (context_stack, context_stack_depth): Don't declare.
3226         (outermost_context_p): Remove macro.
3227         (outermost_context_p, get_current_context_stack)
3228         (get_context_stack_depth): Declare.
3229         (pop_context): Return struct context_stack.
3230         * buildsym.c (struct buildsym_compunit) <m_context_stack: New
3231         member.
3232         (context_stack_size): Remove.
3233         (INITIAL_CONTEXT_STACK_SIZE): Remove.
3234         (prepare_for_building, end_symtab_get_static_block)
3235         (augment_type_symtab, push_context): Update.
3236         (pop_context): Return struct context_stack.
3237         (outermost_context_p, get_current_context_stack)
3238         (get_context_stack_depth): New functions.
3239         (buildsym_init): Update.
3240
3241 2018-07-20  Tom Tromey  <tom@tromey.com>
3242
3243         * rust-exp.y: Now a pure parser.  Update all rules.
3244         (%union): Move earlier.
3245         (current_parser, work_obstack): Remove globals.
3246         (rust_parser, ~rust_parser): Update.
3247         (class rust_parser) <copy_name, concat3, crate_name, super_name,
3248         lex_character, lex_number, lex_string, lex_identifier,
3249         rust_lookup_type, convert_params_to_types, convert_ast_to_type,
3250         convert_name, convert_params_to_expression,
3251         convert_ast_to_expression, ast_basic_type, ast_operation,
3252         ast_compound_assignment, rust_op, ast_literal, ast_dliteral,
3253         ast_structop, ast_structop_anonymous, ast_unary, ast_cast,
3254         ast_call_ish, ast_path, ast_string, ast_struct, ast_range,
3255         ast_array_type, ast_slice_type, ast_reference_type,
3256         ast_pointer_type, ast_function_type, ast_tuple_type>: New methods.
3257         (rust_parse): Update.
3258         (rustyyerror, rustyylex): Add parser parameter.
3259         (rust_lex_test_one, rust_lex_int_test, rust_lex_exception_test)
3260         (rust_lex_stringish_test, rust_lex_test_sequence)
3261         (rust_lex_test_trailing_dot, rust_lex_test_completion)
3262         (rust_lex_test_push_back, rust_lex_tests): Update.
3263
3264 2018-07-19  Pedro Alves  <palves@redhat.com>
3265
3266         * guile/guile-internal.h (gdbscm_scm_to_c_string): Now returns a
3267         gdb::unique_xmalloc_ptr.
3268         * guile/scm-breakpoint.c (gdbscm_set_breakpoint_condition_x):
3269         Adjust to use dbscm_wrap and gdb::unique_xmalloc_ptr.
3270         * guile/scm-exception.c (gdbscm_exception_message_to_string): Use
3271         copy-initialization.
3272         * guile/scm-pretty-print.c (ppscm_print_children): Use
3273         gdb::unique_xmalloc_ptr instead of cleanups.
3274         (gdbscm_apply_val_pretty_printer): Remove cleanups.
3275         * guile/scm-string.c (gdbscm_scm_to_c_string): Now returns a
3276         gdb::unique_xmalloc_ptr.
3277         * guile/scm-type.c (gdbscm_type_field, gdbscm_type_has_field_p):
3278         Adjust to use gdb::unique_xmalloc_ptr.
3279         * guile/scm-utils.c (extract_arg): Adjust.
3280         * guile/scm-value.c (gdbscm_value_field): Adjust to use
3281         gdb::unique_xmalloc_ptr instead of a cleanup.
3282
3283 2018-07-19  Tom Tromey  <tom@tromey.com>
3284
3285         * utils.c (do_value_free_to_mark)
3286         (make_cleanup_value_free_to_mark): Remove.
3287         * utils.h (make_cleanup_value_free_to_mark): Remove.
3288
3289 2018-07-19  Pedro Alves  <palves@redhat.com>
3290
3291         * guile/guile-internal.h (gdbscm_wrap): Really make 'args' a
3292         forwarding reference.
3293
3294 2018-07-18  Pedro Alves  <palves@redhat.com>
3295
3296         * guile/guile.c (gdbscm_execute_gdb_command): Adjust to use
3297         gdbscm_wrap.  Use gdb::unique_xmalloc_ptr<char> instead of a
3298         cleanup.
3299
3300 2018-07-18  Pedro Alves  <palves@redhat.com>
3301
3302         * guile/guile-internal.h: Add comment about mixing GDB and Scheme
3303         exceptions.
3304         (GDBSCM_HANDLE_GDB_EXCEPTION_WITH_CLEANUPS): Delete.
3305         (gdbscm_wrap): New.
3306         * guile/scm-frame.c (gdbscm_frame_read_register): Use xfree
3307         directly instead of a cleanup.
3308         * guile/scm-math.c (vlscm_unop_gdbthrow): New, factored out from ...
3309         (vlscm_unop): ... this.  Reimplement using gdbscm_wrap.
3310         (vlscm_binop_gdbthrow): New, factored out from ...
3311         (vlscm_binop): ... this.  Reimplement using gdbscm_wrap.
3312         (vlscm_rich_compare): Use gdbscm_wrap.
3313         * guile/scm-symbol.c (gdbscm_lookup_symbol): Use xfree directly
3314         instead of a cleanup.
3315         (gdbscm_lookup_global_symbol): Use xfree directly instead of a
3316         cleanup.
3317         * guile/scm-type.c (gdbscm_type_field, gdbscm_type_has_field_p):
3318         Use xfree directly instead of a cleanup.
3319         * guile/scm-value.c (gdbscm_make_value, gdbscm_make_lazy_value):
3320         Adjust to use gdbscm_wrap and scoped_value_mark.
3321         (gdbscm_value_optimized_out_p): Adjust to use gdbscm_wrap.
3322         (gdbscm_value_address, gdbscm_value_dereference)
3323         (gdbscm_value_referenced_value): Adjust to use gdbscm_wrap and
3324         scoped_value_mark.
3325         (gdbscm_value_dynamic_type): Use scoped_value_mark.
3326         (vlscm_do_cast, gdbscm_value_field): Adjust to use gdbscm_wrap and
3327         scoped_value_mark.
3328         (gdbscm_value_subscript, gdbscm_value_call): Adjust to use
3329         gdbscm_wrap and scoped_value_mark.
3330         (gdbscm_value_to_string): Use xfree directly instead of a
3331         cleanup.  Move 'buffer' unique_ptr to TRY scope.
3332         (gdbscm_value_to_lazy_string): Use xfree directly instead of a
3333         cleanup.  Move 'buffer' unique_ptr to TRY scope.  Use
3334         scoped_value_mark.
3335         (gdbscm_value_fetch_lazy_x): Use gdbscm_wrap.
3336         (gdbscm_parse_and_eval): Adjust to use gdbscm_wrap and
3337         scoped_value_mark.
3338         (gdbscm_history_ref, gdbscm_history_append_x): Adjust to use
3339         gdbscm_wrap.
3340
3341 2018-07-18  Tom de Vries  <tdevries@suse.de>
3342
3343         * findvar.c (default_read_var_value): Also resolve dynamic type for
3344         LOC_OPTIMIZED_OUT vars.
3345
3346 2018-07-18  Maciej W. Rozycki  <macro@mips.com>
3347
3348         * mips-tdep.c (micromips_next_pc): Add SYSCALL instruction
3349         decoding.
3350
3351 2018-07-17  Tom Tromey  <tom@tromey.com>
3352
3353         * guile/scm-param.c (pascm_set_func, pascm_show_func)
3354         (compute_enum_list, pascm_set_param_value_x)
3355         (gdbscm_parameter_value): Update.
3356         * guile/guile-internal.h (gdbscm_scm_to_string): Update.
3357         (gdbscm_scm_to_host_string): Update.
3358         * guile/scm-math.c (vlscm_convert_typed_value_from_scheme):
3359         Update.
3360         * guile/scm-cmd.c (cmdscm_add_completion): Update.
3361         * guile/scm-pretty-print.c (ppscm_print_string_repr): Update.
3362         * guile/scm-string.c (gdbscm_scm_to_string): Return
3363         unique_xmalloc_ptr.
3364         (gdbscm_scm_to_host_string): Likewise.
3365
3366 2018-07-17  Tom Tromey  <tom@tromey.com>
3367
3368         * guile/guile.c (gdbscm_eval_from_control_command): Update.
3369         * guile/guile-internal.h (gdbscm_safe_eval_string): Update.
3370         * guile/scm-objfile.c (gdbscm_execute_objfile_script): Update.
3371         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Return
3372         unique_xmalloc_ptr.
3373
3374 2018-07-17  Tom Tromey  <tom@tromey.com>
3375
3376         * guile/scm-param.c (pascm_signal_setshow_error): Update.
3377         * guile/guile-internal.h (gdbscm_exception_message_to_string):
3378         Update.
3379         * guile/scm-cmd.c (cmdscm_function): Update.
3380         * guile/scm-pretty-print.c
3381         (ppscm_print_exception_unless_memory_error): Update.
3382         * guile/scm-exception.c (gdbscm_exception_message_to_string):
3383         Return unique_xmalloc_ptr.
3384
3385 2018-07-17  Tom Tromey  <tom@tromey.com>
3386
3387         * guile/scm-pretty-print.c (ppscm_make_pp_type_error_exception):
3388         Use string_printf.
3389
3390 2018-07-17  Jim Wilson  <jimw@sifive.com>
3391
3392         * riscv-tdep.c (riscv_has_feature): Delete comment that refers to
3393         set_gdbarch_decr_pc_after_break.  Call riscv_read_misa_reg always.
3394         (riscv_gdbarch_init): Delete local has_compressed_isa.  Delete now
3395         unecessary braces after EF_RISCV_RVC test.  Delete call to
3396         set_gdbarch_decr_pc_after_break.
3397
3398         * riscv-tdep.h (DECLARE_CSR): Use RISCV_FIRST_CSR_REGNUM instead of
3399         RISCV_LAST_FP_REGNUM + 1.
3400         (RSICV_CSR_LEGACY_MISA_REGNUM): Add RISCV_FIRST_CSR_REGNUM.
3401
3402 2018-07-17  Tom Tromey  <tom@tromey.com>
3403
3404         * configure.ac: Remove --disable-gdbcli.
3405         * configure: Rebuild.
3406         * Makefile.in (SUBDIR_CLI_DEPS, SUBDIR_CLI_LDFLAGS)
3407         (SUBDIR_CLI_CFLAGS): Remove.
3408         (SFILES): Use SUBDIR_CLI_SRCS.
3409         (COMMON_OBS): Use SUBDIR_CLI_OBS.
3410
3411 2018-07-17  Tom Tromey  <tom@tromey.com>
3412
3413         PR gdb/18624:
3414         * coffread.c (coff_symtab_read): Use scoped_free_pendings.
3415
3416 2018-07-16  Jim Wilson  <jimw@sifive.com>
3417
3418         * riscv-tdep.c (riscv_gdbarch_init): Call gdbarch_init_osabi.
3419
3420 2018-07-16  Simon Marchi  <simon.marchi@ericsson.com>
3421
3422         * ia64-libunwind-tdep.c (libunwind_frame_cache): Remove unused
3423         variable.
3424         (libunwind_frame_sniffer): Likewise.
3425         (libunwind_frame_prev_register): Likewise.
3426         (libunwind_sigtramp_frame_sniffer): Likewise.
3427         * ia64-tdep.c (ia64_access_reg): Likewise.
3428         (ia64_access_rse_reg): Likewise.
3429         (ia64_libunwind_sigtramp_frame_this_id): Likewise.
3430         * ia64-vms-tdep.c (ia64_vms_find_proc_info_x): Likewise.
3431
3432 2018-07-16  Simon Marchi  <simon.marchi@ericsson.com>
3433
3434         * ia64-vms-tdep.c (ia64_vms_find_proc_info_x): Add cast.
3435
3436 2018-07-16  Simon Marchi  <simon.marchi@ericsson.com>
3437
3438         * remote-sim.c (gdbsim_target::close,
3439         gdbsim_target::mourn_inferior): Remove unused variables.
3440
3441 2018-07-16  Simon Marchi  <simon.marchi@polymtl.ca>
3442
3443         * ia64-tdep.c (ktab_buf): New global.
3444         (getunwind_table): Return a gdb::optional<gdb::byte_vector>.
3445         (get_kernel_table): Adjust.
3446
3447 2018-07-16  Tom Tromey  <tom@tromey.com>
3448
3449         * xcoffread.c (read_xcoff_symtab): Use outermost_context_p.
3450         * dwarf2read.c (using_directives, new_symbol): Use
3451         outermost_context_p.
3452         * dbxread.c (process_one_symbol): Use outermost_context_p.
3453         * coffread.c (coff_symtab_read): Use outermost_context_p.
3454
3455 2018-07-16  Tom Tromey  <tom@tromey.com>
3456
3457         * dwarf2read.c (using_directives, read_func_scope)
3458         (read_lexical_block_scope): Update.
3459         * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
3460         * buildsym.h (local_using_directives, global_using_directives):
3461         Don't declare.
3462         (get_local_using_directives, set_local_using_directives)
3463         (get_global_using_directives): Declare.
3464         * buildsym.c (struct buildsym_compunit) <m_local_using_directives,
3465         m_global_using_directives>: New members.
3466         (finish_block_internal, prepare_for_building)
3467         (reset_symtab_globals, end_symtab_get_static_block)
3468         (push_context): Update.
3469         (get_local_using_directives, set_local_using_directives)
3470         (get_global_using_directives): New functions.
3471         (buildsym_init): Update.
3472
3473 2018-07-16  Tom Tromey  <tom@tromey.com>
3474
3475         * xcoffread.c (xcoff_initial_scan): Don't call
3476         free_pending_blocks.
3477         * dbxread.c (dbx_symfile_read): Don't call free_pending_blocks.
3478         * buildsym.h (class scoped_free_pendings): Add constructor.
3479         (free_pending_blocks): Don't declare.
3480         * buildsym.c (scoped_free_pendings::scoped_free_pendings): New.
3481         (free_pending_blocks): Now static.
3482
3483 2018-07-16  Tom Tromey  <tom@tromey.com>
3484
3485         * buildsym.h (push_subfile, pop_subfile): Update declarations.
3486         * buildsym.c (struct buildsym_compunit) <m_subfile_stack>: New
3487         member.
3488         (struct subfile_stack): Remove.
3489         (subfile_stack): Remove.
3490         (push_subfile, pop_subfile, buildsym_init): Update.
3491
3492 2018-07-16  Tom Tromey  <tom@tromey.com>
3493
3494         * buildsym.c (push_subfile): Use gdb_assert.
3495         (pop_subfile): Use gdb_assert.
3496
3497 2018-07-16  Tom Tromey  <tom@tromey.com>
3498
3499         * buildsym.h (merge_symbol_lists): Remove.
3500         * buildsym.c (merge_symbol_lists): Remove.
3501
3502 2018-07-16  Tom Tromey  <tom@tromey.com>
3503
3504         * stabsread.c (scan_file_globals): Update comment.
3505         * stabsread.h (scan_file_globals): Move from buildsym.h.
3506         * buildsym.h (scan_file_globals): Move to stabsread.h.
3507
3508 2018-07-16  Tom Tromey  <tom@tromey.com>
3509
3510         * xcoffread.c (xcoff_new_init): Update.
3511         * mipsread.c (mipscoff_new_init): Update.
3512         * mdebugread.c (mdebug_build_psymtabs): Update.
3513         * elfread.c (elf_new_init): Update.
3514         * dbxread.c (dbx_new_init, coffstab_build_psymtabs)
3515         (elfstab_build_psymtabs, stabsect_build_psymtabs): Update.
3516         * buildsym.h (buildsym_new_init): Don't declare.
3517         * buildsym.c (buildsym_new_init): Remove.
3518
3519 2018-07-16  Tom Tromey  <tom@tromey.com>
3520
3521         * stabsread.h (within_function): Move from buildsym.h.
3522         * stabsread.c (start_stabs): Clear within_function.
3523         * coffread.c (coff_start_symtab): Clear within_function.
3524         * buildsym.h (within_function): Move to stabsread.h.
3525         * buildsym.c (prepare_for_building): Update.
3526
3527 2018-07-16  Tom Tromey  <tom@tromey.com>
3528
3529         * stabsread.h (processing_gcc_compilation): Move from buildsym.h.
3530         * dwarf2read.c (dwarf2_start_symtab): Don't set
3531         processing_gcc_compilation.
3532         * buildsym.h (processing_gcc_compilation): Move to stabsread.h.
3533
3534 2018-07-16  Tom Tromey  <tom@tromey.com>
3535
3536         * stabsread.h (HASHSIZE, hashname, symnum, next_symbol_text)
3537         (next_symbol_text_func): Move from buildsym.h.
3538         * stabsread.c (hashname): Move from buildsym.c.
3539         * buildsym.h (HASHSIZE, symnum, next_symbol_text)
3540         (next_symbol_text_func, hashname): Move to stabsread.h.
3541         * buildsym.c: Don't include bcache.h
3542         (hashname): Move to stasbread.c.
3543
3544 2018-07-16  Tom Tromey  <tom@tromey.com>
3545
3546         * buildsym.h (context_stack_size): Don't declare.
3547         * buildsym.c (context_stack_size): New global.
3548
3549 2018-07-16  Tom Tromey  <tom@tromey.com>
3550
3551         * dbxread.c (processing_acc_compilation): New global.
3552         * buildsym.h (processing_acc_compilation): Don't declare.
3553
3554 2018-07-16  Tom Tromey  <tom@tromey.com>
3555
3556         * xcoffread.c (aix_process_linenos, complete_symtab): Update.
3557         * dbxread.c (read_ofile_symtab): Update.
3558         * coffread.c (coff_start_symtab, coff_end_symtab): Update.
3559         * buildsym.h (last_source_start_addr): Remove.
3560         (set_last_source_start_addr, get_last_source_start_addr):
3561         Declare.
3562         * buildsym.c (buildsym_compunit::buildsym_compunit): Add last_addr
3563         parameter.
3564         (struct buildsym_compunit) <m_last_source_start_addr>: New
3565         member.
3566         (prepare_for_building): Remove start_addr parameter.
3567         (start_symtab, restart_symtab, end_symtab_get_static_block)
3568         (end_symtab_with_blockvector): Update.
3569         (set_last_source_start_addr, get_last_source_start_addr): New
3570         functions.
3571
3572 2018-07-16  Tom Tromey  <tom@tromey.com>
3573
3574         * buildsym.c (struct buildsym_compunit) <m_have_line_numbers>: New
3575         member.
3576         (have_line_numbers): Remove.
3577         (record_line, prepare_for_building, end_symtab_get_static_block)
3578         (augment_type_symtab): Update.
3579
3580 2018-07-16  Tom Tromey  <tom@tromey.com>
3581
3582         * buildsym.c (~buildsym_compunit): Free the macro table.
3583         (struct buildsym_compunit) <get_macro_table, release_macros>: New
3584         methods.
3585         <m_pending_macros>: New member.
3586         (pending_macros): Remove.
3587         (~scoped_free_pendings, get_macro_table, prepare_for_building)
3588         (reset_symtab_globals, end_symtab_get_static_block)
3589         (end_symtab_with_blockvector, augment_type_symtab)
3590         (buildsym_init): Update.
3591
3592 2018-07-16  Tom Tromey  <tom@tromey.com>
3593
3594         * buildsym.c (buildsym_compunit::buildsym_compunit): Add name
3595         parameter.
3596         (buildsym_compunit::set_last_source_file): New method.
3597         <m_last_source_file>: New member.
3598         (prepare_for_building): Remove "name" parameter.
3599         (start_symtab, restart_symtab, reset_symtab_globals): Update.
3600         (last_source_file): Remove.
3601         (set_last_source_file, get_last_source_file): Update.
3602
3603 2018-07-16  Tom Tromey  <tom@tromey.com>
3604
3605         * buildsym.c (prepare_for_building): Add assert.
3606
3607 2018-07-16  Tom Tromey  <tom@tromey.com>
3608
3609         * buildsym.c (~buildsym_compunit): Update.
3610         (struct buildsym_compunit) <comp_unit>: Now a unique_xmalloc_ptr.
3611         (start_subfile, patch_subfile_names)
3612         (end_symtab_with_blockvector): Update.
3613
3614 2018-07-16  Tom Tromey  <tom@tromey.com>
3615
3616         * buildsym.c (struct buildsym_compunit): Add constructor,
3617         destructor, initializers.
3618         (start_buildsym_compunit): Remove.
3619         (free_buildsym_compunit): Use "delete".
3620         (start_symtab, restart_symtab): Use "new".
3621
3622 2018-07-13  Simon Marchi  <simon.marchi@polymtl.ca>
3623
3624         * symfile.c (set_objfile_default_section_offset): Remove struct
3625         keyword.
3626
3627 2018-07-14  Stafford Horne  <shorne@gmail.com>
3628
3629         * (Responsible Maintainers): Add myself as or1k maintainer.
3630
3631 2018-07-13  Tom Tromey  <tom@tromey.com>
3632
3633         * symfile.c (set_objfile_default_section_offset): Use extra braces
3634         around initializer.
3635
3636 2018-07-13  Andreas Arnez  <arnez@linux.vnet.ibm.com>
3637
3638         * s390-tdep.c (s390_displaced_step_fixup): Adjust PC for a
3639         non-branching basr.
3640
3641 2018-07-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3642
3643         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
3644         unittests/cli-utils-selftests.c
3645         * unittests/cli-utils-selftests.c: New file.
3646
3647 2018-07-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3648
3649         * NEWS: Mention new commands. Mention change to 'thread apply'.
3650
3651 2018-07-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3652
3653         * thread.c (thr_try_catch_cmd): New function.
3654         (thread_apply_all_command): Handle qcs flags.
3655         (thread_apply_command): Handle qcs flags.
3656         (taas_command): New function.
3657         (tfaas_command): New function.
3658         (_initialize_thread): Update to setup the new commands 'taas
3659         and 'tfaas'. Change doc string for 'thread apply'.
3660
3661 2018-07-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3662
3663         * stack.c: (trailing_outermost_frame): New function, mostly
3664         extracted from backtrace_command_1.
3665         (leading_innermost_frame): New function.
3666         (backtrace_command_1): Update to call trailing_outermost_frame.
3667         (frame_apply_command_count): New function.
3668         (frame_apply_level_command): New function.
3669         (frame_apply_all_command): New function.
3670         (frame_apply_command): New function.
3671         (faas_command): New function.
3672         (frame_cmd_list): New variable.
3673         (_initialize_stack): Update to setup the new commands 'frame apply'
3674         and 'faas'.
3675
3676 2018-07-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3677
3678         * cli-utils.c (number_or_range_parser::get_number): Only handle
3679         numbers or convenience var as numbers.
3680         (parse_flags): New function.
3681         (parse_flags_qcs): New function.
3682         (number_or_range_parser::finished): Ensure parsing end is detected
3683         before end of string.
3684         * cli-utils.h (parse_flags): New function.
3685         (parse_flags_qcs): New function.
3686         (number_or_range_parser): Remove m_finished bool.
3687         (number_or_range_parser::skip_range): Set m_in_range to false.
3688
3689 2018-07-12  Sergio Durigan Junior  <sergiodj@redhat.com>
3690
3691         * ser-tcp.c (try_connect): Declare 'ioarg' as 'u_long' if building
3692         on Windows.
3693
3694 2018-07-11  Sergio Durigan Junior  <sergiodj@redhat.com>
3695             Jan Kratochvil  <jan.kratochvil@redhat.com>
3696             Paul Fertser  <fercerpav@gmail.com>
3697             Tsutomu Seki  <sekiriki@gmail.com>
3698             Pedro Alves  <palves@redhat.com>
3699
3700         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
3701         'unittests/parse-connection-spec-selftests.c'.
3702         (COMMON_SFILES): Add 'common/netstuff.c'.
3703         (HFILES_NO_SRCDIR): Add 'common/netstuff.h'.
3704         * NEWS (Changes since GDB 8.2): Mention IPv6 support.
3705         * common/netstuff.c: New file.
3706         * common/netstuff.h: New file.
3707         * ser-tcp.c: Include 'netstuff.h' and 'wspiapi.h'.
3708         (wait_for_connect): Update comment.  New parameter
3709         'gdb::optional<int> sock' instead of 'struct serial *scb'.
3710         Use 'sock' directly instead of 'scb->fd'.
3711         (try_connect): New function, with code from 'net_open'.
3712         (net_open): Rewrite main loop to deal with multiple
3713         sockets/addresses.  Handle IPv6-style hostnames; implement
3714         support for IPv6 connections.
3715         * unittests/parse-connection-spec-selftests.c: New file.
3716
3717 2018-07-11  Pedro Alves  <palves@redhat.com>
3718
3719         PR gdb/23377
3720         * remote.c (remote_target::remote_detach_pid): Call
3721         set_current_process.
3722
3723 2018-07-11  Pedro Alves  <palves@redhat.com>
3724
3725         * h8300-tdep.c (h8300_gdbarch_init): Remove
3726         set_gdbarch_ecoff_reg_to_regnum calls.
3727
3728 2018-07-11  Sergio Durigan Junior  <sergiodj@redhat.com>
3729
3730         PR c++/23373
3731         * c-typeprint.c (c_type_print_base_struct_union): Don't print
3732         offsets/sizes for static members of a class/struct.
3733
3734 2018-07-11  Alan Hayward  <alan.hayward@arm.com>
3735
3736         * target-descriptions.c (tdesc_register_bitsize): Rename.
3737         * target-descriptions.h (tdesc_register_bitsize): Likewise.
3738         * rs6000-tdep.c (rs6000_gdbarch_init): Use new name.
3739         * aarch64-tdep.c (aarch64_get_tdesc_vq): Convert size.
3740
3741 2018-07-10  Tom Tromey  <tom@tromey.com>
3742
3743         * breakpoint.c (moribund_locations): Now static and a
3744         std::vector.
3745         (breakpoint_init_inferior, moribund_breakpoint_here_p)
3746         (build_bpstat_chain, update_global_location_list)
3747         (breakpoint_retire_moribund): Update.
3748         * breakpoint.h (bp_location_p): Remove typedef.  Don't declare
3749         VEC.
3750
3751 2018-07-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3752
3753         * riscv-tdep.c (riscv_is_fp_regno_p): New function.
3754         (riscv_register_reggroup_p): Use new function, remove unneeded
3755         parenthesis.
3756         (riscv_push_dummy_call): Extend assert to compare against xlen or
3757         flen based on register type.
3758
3759 2018-07-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3760
3761         * riscv-tdep.c (riscv_print_arg_location): Use TYPE_SAFE_NAME.
3762
3763 2018-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3764
3765         * remote.c (show_hardware_watchpoint_limit): New function.
3766         (show_hardware_watchpoint_length_limit): New function.
3767         (show_hardware_breakpoint_limit): New function.
3768         (_initialize_remote): Use add_setshow_zuinteger_unlimited_cmd
3769         where appropriate, update help text.
3770
3771 2018-07-09  Tom Tromey  <tom@tromey.com>
3772
3773         * Makefile.in (CDEPS): Don't mention XM_CDEPS.
3774         (CLIBS): Don't mention NAT_CLIBS.
3775
3776 2018-07-09  Tom Tromey  <tom@tromey.com>
3777
3778         * Makefile.in (ADD_FILES, ADD_DEPS): Remove.
3779         (LIBGDB_OBS, clean mostlyclean): Update.
3780         (gdb$(EXEEXT), insight$(EXEEXT)): Update.
3781
3782 2018-07-09  Tom Tromey  <tom@tromey.com>
3783
3784         * Makefile.in (%.c: %.y): Use ECHO_YACC.
3785         (%.c: %.l): Use ECHO_LEX.  Just fail if flex not available.
3786         * silent-rules.mk (ECHO_YACC, ECHO_LEX): New variables.
3787
3788 2018-07-09  Tom Tromey  <tom@tromey.com>
3789
3790         * Makefile.in (ALLDEPFILES): Remove exec.c.
3791         (COMMON_OBS): Remove exec.o.
3792         (COMMON_SFILES): Add exec.c.
3793
3794 2018-07-09  Tom Tromey  <tom@tromey.com>
3795
3796         * Makefile.in (LINT, LINTFLAGS, LINTFILES, lint): Remove.
3797
3798 2018-07-09  Tom Tromey  <tom@tromey.com>
3799
3800         * Makefile.in (clean mostlyclean): Remove stamp-version.
3801         (version.c): Depend on stamp-version.
3802         (stamp-version): New rule, from version.c rule.
3803
3804 2018-07-09  Tom Tromey  <tom@tromey.com>
3805
3806         * Makefile.in (init.c): Depend on stamp-init.
3807         (stamp-init): New rule, from init.c rule.
3808         (clean mostlyclean): Remove stamp-init.
3809
3810 2018-07-09  Tom Tromey  <tom@tromey.com>
3811
3812         * Makefile.in (INIT_FILES): Remove CONFIG_SRCS,
3813         SUBDIR_GCC_COMPILE_SRCS.
3814
3815 2018-07-09  Tom Tromey  <tom@tromey.com>
3816
3817         * Makefile.in (init.c): Remove some unused sed rules.
3818
3819 2018-07-09  Tom Tromey  <tom@tromey.com>
3820
3821         * Makefile.in (TSOBS): Remove.
3822         (INIT_FILES): Update.
3823         (LIBGDB_OBS): Update.
3824         (COMMON_SFILES): Add inflow.c.
3825         (SFILES): Remove inflow.c.
3826
3827 2018-07-07  Jan Kratochvil  <jan.kratochvil@redhat.com>
3828
3829         * contrib/gdb-add-index.sh ($dwarf5): New, use it.
3830
3831 2018-07-07  Simon Marchi  <simon.marchi@polymtl.ca>
3832
3833         * ia64-libunwind-tdep.c (get_reg_name, get_fpreg_name,
3834         get_saveloc_name, is_signal_frame_name, step_name,
3835         init_remote_name, create_addr_space_name,
3836         destroy_addr_space_name, search_unwind_table_name,
3837         find_dyn_list_name): Constify.
3838
3839 2018-07-05  Simon Marchi  <simon.marchi@polymtl.ca>
3840
3841         * darwin-nat.c (darwin_pthread_kill): New function.
3842         (darwin_resume_thread): Use darwin_pthread_kill.
3843
3844 2018-07-05  Tom de Vries  <tdevries@suse.de>
3845
3846         * macroexp.c (macro_buffer) <operator=>: New member function.
3847
3848 2018-07-04  Tom Tromey  <tom@tromey.com>
3849
3850         * darwin-nat.c (darwin_attach_pid): Use exit_inferior.
3851
3852 2018-07-04  Simon Marchi  <simon.marchi@polymtl.ca>
3853
3854         * common/common-defs.h (HAVE_USEFUL_SBRK): Define.
3855         * main.c: Use HAVE_USEFUL_SBRK instead of HAVE_SBRK.
3856         * maint.c: Likewise.
3857         * top.c: Likewise.
3858
3859 2018-07-04  Joel Brobecker  <brobecker@adacore.com>
3860
3861         * NEWS: Create a new section for the next release branch.
3862         Rename the section of the current branch, now that it has
3863         been cut.
3864
3865 2018-07-04  Joel Brobecker  <brobecker@adacore.com>
3866
3867         GDB 8.2 branch created (1b919490e8ba30bf1d6941df0ed112b0e557017e):
3868         * version.in: Bump version to 8.2.50.DATE-git.
3869
3870 2018-07-04  Vyacheslav Barinov  <v.barinov@samsung.com>
3871             Pedro Alves  <palves@redhat.com>
3872
3873         * linux-nat.c (linux_init_ptrace): Rename to ...
3874         (linux_init_ptrace_procfs): ... this.  Call
3875         linux_proc_init_warnings.
3876         (linux_nat_target::post_attach)
3877         (linux_nat_target::post_startup_inferior): Adjust.
3878         * nat/linux-procfs.c (linux_proc_init_warnings): Define function.
3879         * nat/linux-procfs.h (linux_proc_init_warnings): Declare function.
3880
3881 2018-07-04  Tom de Vries  <tdevries@suse.de>
3882
3883         * dwarf2read.c (error_check_comp_unit_head): Move dwarf version
3884         check ...
3885         (read_comp_unit_head): ... here.
3886
3887 2018-07-03  Tom Tromey  <tom@tromey.com>
3888
3889         * tracepoint.c (process_tracepoint_on_disconnect, start_tracing)
3890         (stop_tracing, tstatus_command)
3891         (find_matching_tracepoint_location, merge_uploaded_tracepoints)
3892         (print_one_static_tracepoint_marker): Update.
3893         * breakpoint.c (static_tracepoints_here, all_tracepoints): Return
3894         std::vector.
3895         * breakpoint.h (breakpoint_p): Remove typedef.  Don't declare
3896         VEC.
3897         (all_tracepoints, static_tracepoints_here): Return std::vector.
3898
3899 2018-07-03  Tom Tromey  <tom@tromey.com>
3900
3901         * common/ptid.c (ptid_equal): Remove.
3902         * common/ptid.h (ptid_equal): Don't declare.
3903         * ada-tasks.c: Update.
3904         * breakpoint.c: Update.
3905         * common/agent.c: Update.
3906         * corelow.c: Update.
3907         * darwin-nat-info.c: Update.
3908         * darwin-nat.c: Update.
3909         * dcache.c: Update.
3910         * dtrace-probe.c: Update.
3911         * dummy-frame.c: Update.
3912         * fbsd-nat.c: Update.
3913         * frame.c: Update.
3914         * gdbthread.h: Update.
3915         * gnu-nat.c: Update.
3916         * go32-nat.c: Update.
3917         * inf-loop.c: Update.
3918         * inf-ptrace.c: Update.
3919         * infcall.c: Update.
3920         * infcmd.c: Update.
3921         * inflow.c: Update.
3922         * infrun.c: Update.
3923         * linux-fork.c: Update.
3924         * linux-nat.c: Update.
3925         * linux-thread-db.c: Update.
3926         * mi/mi-cmd-var.c: Update.
3927         * mi/mi-interp.c: Update.
3928         * mi/mi-main.c: Update.
3929         * nto-procfs.c: Update.
3930         * ppc-linux-tdep.c: Update.
3931         * procfs.c: Update.
3932         * python/py-inferior.c: Update.
3933         * python/py-record-btrace.c: Update.
3934         * python/py-record.c: Update.
3935         * ravenscar-thread.c: Update.
3936         * regcache.c: Update.
3937         * remote-sim.c: Update.
3938         * remote.c: Update.
3939         * sol-thread.c: Update.
3940         * solib.c: Update.
3941         * target.c: Update.
3942         * tui/tui-stack.c: Update.
3943         * varobj.c: Update.
3944         * windows-nat.c: Update.
3945         * windows-tdep.c: Update.
3946
3947 2018-07-03  Tom Tromey  <tom@tromey.com>
3948
3949         * common/ptid.c (ptid_match): Remove.
3950         * common/ptid.h (ptid_match): Don't declare.
3951         * fbsd-nat.c: Update.
3952         * infcmd.c: Update.
3953         * infrun.c: Update.
3954         * linux-nat.c: Update.
3955         * record-btrace.c: Update.
3956         * regcache.c: Update.
3957         * remote.c: Update.
3958
3959 2018-07-03  Tom Tromey  <tom@tromey.com>
3960
3961         * common/ptid.c (ptid_tid_p): Remove.
3962         * common/ptid.h (ptid_tid_p): Don't declare.
3963         * sol-thread.c: Update.
3964
3965 2018-07-03  Tom Tromey  <tom@tromey.com>
3966
3967         * common/ptid.c (ptid_lwp_p): Remove.
3968         * common/ptid.h (ptid_lwp_p): Don't declare.
3969         * fbsd-nat.c: Update.
3970         * linux-nat.c: Update.
3971         * nat/linux-procfs.c: Update.
3972         * nat/x86-linux-dregs.c: Update.
3973         * sol-thread.c: Update.
3974
3975 2018-07-03  Tom Tromey  <tom@tromey.com>
3976
3977         * common/ptid.c (ptid_is_pid): Remove.
3978         * common/ptid.h (ptid_is_pid): Don't declare.
3979         * infrun.c: Update.
3980         * linux-nat.c: Update.
3981         * mi/mi-interp.c: Update.
3982         * remote.c: Update.
3983         * thread.c: Update.
3984
3985 2018-07-03  Tom Tromey  <tom@tromey.com>
3986
3987         * common/ptid.c (ptid_get_tid): Remove.
3988         * common/ptid.h (ptid_get_tid): Don't declare.
3989         * ada-tasks.c: Update.
3990         * aix-thread.c: Update.
3991         * bsd-uthread.c: Update.
3992         * darwin-nat.c: Update.
3993         * fbsd-nat.c: Update.
3994         * i386-darwin-nat.c: Update.
3995         * infrun.c: Update.
3996         * linux-tdep.c: Update.
3997         * nto-procfs.c: Update.
3998         * ppc-ravenscar-thread.c: Update.
3999         * python/py-infthread.c: Update.
4000         * ravenscar-thread.c: Update.
4001         * sol-thread.c: Update.
4002         * sparc-ravenscar-thread.c: Update.
4003         * windows-nat.c: Update.
4004
4005 2018-07-03  Tom Tromey  <tom@tromey.com>
4006
4007         * common/ptid.c (ptid_get_lwp): Remove.
4008         * common/ptid.h (ptid_get_lwp): Don't declare.
4009         * aarch64-linux-nat.c: Update.
4010         * ada-tasks.c: Update.
4011         * aix-thread.c: Update.
4012         * amd64-linux-nat.c: Update.
4013         * arm-linux-nat.c: Update.
4014         * corelow.c: Update.
4015         * fbsd-nat.c: Update.
4016         * fbsd-tdep.c: Update.
4017         * gnu-nat.c: Update.
4018         * i386-cygwin-tdep.c: Update.
4019         * i386-gnu-nat.c: Update.
4020         * i386-linux-nat.c: Update.
4021         * ia64-linux-nat.c: Update.
4022         * inf-ptrace.c: Update.
4023         * infrun.c: Update.
4024         * linux-fork.c: Update.
4025         * linux-nat.c: Update.
4026         * linux-tdep.c: Update.
4027         * linux-thread-db.c: Update.
4028         * mips-linux-nat.c: Update.
4029         * nat/aarch64-linux-hw-point.c: Update.
4030         * nat/aarch64-linux.c: Update.
4031         * nat/linux-btrace.c: Update.
4032         * nat/linux-osdata.c: Update.
4033         * nat/linux-procfs.c: Update.
4034         * nat/x86-linux-dregs.c: Update.
4035         * obsd-nat.c: Update.
4036         * ppc-fbsd-nat.c: Update.
4037         * ppc-linux-nat.c: Update.
4038         * procfs.c: Update.
4039         * python/py-infthread.c: Update.
4040         * ravenscar-thread.c: Update.
4041         * remote.c: Update.
4042         * s390-linux-nat.c: Update.
4043         * sol-thread.c: Update.
4044         * sol2-tdep.c: Update.
4045         * spu-linux-nat.c: Update.
4046         * x86-linux-nat.c: Update.
4047         * xtensa-linux-nat.c: Update.
4048
4049 2018-07-03  Tom Tromey  <tom@tromey.com>
4050
4051         * common/ptid.c (ptid_get_pid): Remove.
4052         * common/ptid.h (ptid_get_pid): Don't declare.
4053         * aarch64-linux-nat.c: Update.
4054         * ada-lang.c: Update.
4055         * aix-thread.c: Update.
4056         * alpha-bsd-nat.c: Update.
4057         * amd64-fbsd-nat.c: Update.
4058         * amd64-linux-nat.c: Update.
4059         * arm-linux-nat.c: Update.
4060         * arm-nbsd-nat.c: Update.
4061         * auxv.c: Update.
4062         * break-catch-syscall.c: Update.
4063         * breakpoint.c: Update.
4064         * bsd-uthread.c: Update.
4065         * corelow.c: Update.
4066         * ctf.c: Update.
4067         * darwin-nat.c: Update.
4068         * fbsd-nat.c: Update.
4069         * fbsd-tdep.c: Update.
4070         * gcore.c: Update.
4071         * gnu-nat.c: Update.
4072         * hppa-nbsd-nat.c: Update.
4073         * hppa-obsd-nat.c: Update.
4074         * i386-fbsd-nat.c: Update.
4075         * ia64-linux-nat.c: Update.
4076         * inf-ptrace.c: Update.
4077         * infcmd.c: Update.
4078         * inferior.c: Update.
4079         * inferior.h: Update.
4080         * inflow.c: Update.
4081         * infrun.c: Update.
4082         * linux-fork.c: Update.
4083         * linux-nat.c: Update.
4084         * linux-tdep.c: Update.
4085         * linux-thread-db.c: Update.
4086         * m68k-bsd-nat.c: Update.
4087         * mi/mi-interp.c: Update.
4088         * mi/mi-main.c: Update.
4089         * mips-linux-nat.c: Update.
4090         * mips-nbsd-nat.c: Update.
4091         * mips64-obsd-nat.c: Update.
4092         * nat/aarch64-linux-hw-point.c: Update.
4093         * nat/aarch64-linux.c: Update.
4094         * nat/linux-btrace.c: Update.
4095         * nat/linux-osdata.c: Update.
4096         * nat/linux-procfs.c: Update.
4097         * nat/x86-linux-dregs.c: Update.
4098         * nto-procfs.c: Update.
4099         * obsd-nat.c: Update.
4100         * ppc-linux-nat.c: Update.
4101         * ppc-nbsd-nat.c: Update.
4102         * ppc-obsd-nat.c: Update.
4103         * proc-service.c: Update.
4104         * procfs.c: Update.
4105         * python/py-inferior.c: Update.
4106         * python/py-infthread.c: Update.
4107         * ravenscar-thread.c: Update.
4108         * record.c: Update.
4109         * remote-sim.c: Update.
4110         * remote.c: Update.
4111         * rs6000-nat.c: Update.
4112         * s390-linux-nat.c: Update.
4113         * sh-nbsd-nat.c: Update.
4114         * sol-thread.c: Update.
4115         * sparc-nat.c: Update.
4116         * sparc64-tdep.c: Update.
4117         * spu-linux-nat.c: Update.
4118         * spu-tdep.c: Update.
4119         * target-debug.h: Update.
4120         * target.c: Update.
4121         * thread.c: Update.
4122         * tid-parse.c: Update.
4123         * tracefile-tfile.c: Update.
4124         * vax-bsd-nat.c: Update.
4125         * windows-nat.c: Update.
4126         * x86-linux-nat.c: Update.
4127         * x86-nat.c: Update.
4128
4129 2018-07-03  Tom Tromey  <tom@tromey.com>
4130
4131         * common/ptid.c (pid_to_ptid): Remove.
4132         * common/ptid.h (pid_to_ptid): Don't declare.
4133         * aix-thread.c: Update.
4134         * arm-linux-nat.c: Update.
4135         * common/ptid.c: Update.
4136         * common/ptid.h: Update.
4137         * corelow.c: Update.
4138         * ctf.c: Update.
4139         * darwin-nat.c: Update.
4140         * fbsd-nat.c: Update.
4141         * fork-child.c: Update.
4142         * gnu-nat.c: Update.
4143         * go32-nat.c: Update.
4144         * inf-ptrace.c: Update.
4145         * infcmd.c: Update.
4146         * inferior.c: Update.
4147         * infrun.c: Update.
4148         * linux-fork.c: Update.
4149         * linux-nat.c: Update.
4150         * nat/aarch64-linux-hw-point.c: Update.
4151         * nat/fork-inferior.c: Update.
4152         * nat/x86-linux-dregs.c: Update.
4153         * nto-procfs.c: Update.
4154         * obsd-nat.c: Update.
4155         * procfs.c: Update.
4156         * progspace.c: Update.
4157         * remote.c: Update.
4158         * rs6000-nat.c: Update.
4159         * s390-linux-nat.c: Update.
4160         * sol-thread.c: Update.
4161         * spu-linux-nat.c: Update.
4162         * target.c: Update.
4163         * top.c: Update.
4164         * tracefile-tfile.c: Update.
4165         * windows-nat.c: Update.
4166
4167 2018-07-03  Tom Tromey  <tom@tromey.com>
4168
4169         * common/ptid.h (ptid_build): Don't declare.
4170         * common/ptid.c (ptid_build): Remove.
4171         * aix-thread.c: Update.
4172         * bsd-kvm.c: Update.
4173         * bsd-uthread.c: Update.
4174         * common/agent.c: Update.
4175         * common/ptid.c: Update.
4176         * common/ptid.h: Update.
4177         * corelow.c: Update.
4178         * darwin-nat.c: Update.
4179         * fbsd-nat.c: Update.
4180         * gnu-nat.c: Update.
4181         * linux-fork.c: Update.
4182         * linux-nat.c: Update.
4183         * linux-thread-db.c: Update.
4184         * nat/linux-osdata.c: Update.
4185         * nat/linux-procfs.c: Update.
4186         * nto-procfs.c: Update.
4187         * obsd-nat.c: Update.
4188         * proc-service.c: Update.
4189         * procfs.c: Update.
4190         * ravenscar-thread.c: Update.
4191         * remote-sim.c: Update.
4192         * remote.c: Update.
4193         * sol-thread.c: Update.
4194         * target.c: Update.
4195         * windows-nat.c: Update.
4196
4197 2018-07-03  Tom Tromey  <tom@tromey.com>
4198
4199         * infrun.c (follow_exec): Use exit_inferior_silent.
4200         * inferior.c (exit_inferior_num_silent): Remove.
4201         * inferior.h (exit_inferior_num_silent): Don't declare.
4202
4203 2018-07-03  Tom Tromey  <tom@tromey.com>
4204
4205         PR cli/23340:
4206         * darwin-nat.c (darwin_attach_pid): Reset inferior and
4207         inferior_ptid on error.
4208
4209 2018-07-02  Maciej W. Rozycki  <macro@mips.com>
4210             Simon Marchi  <simon.marchi@polymtl.ca>
4211
4212         PR tdep/8282
4213         * disasm.h (gdb_disassembler): Add
4214         `m_disassembler_options_holder'. member
4215         * disasm.c (get_all_disassembler_options): New function.
4216         (gdb_disassembler::gdb_disassembler): Use it.
4217         (gdb_buffered_insn_length_init_dis): Likewise.
4218         (gdb_buffered_insn_length): Adjust accordingly.
4219         (set_disassembler_options): Handle options with arguments.
4220         (show_disassembler_options_sfunc): Likewise.  Add a leading new
4221         line if showing options with descriptions.
4222         (disassembler_options_completer): Adapt to using the
4223         `disasm_options_and_args_t' structure.
4224         * mips-tdep.c (mips_disassembler_options): New variable.
4225         (mips_disassembler_options_o32): Likewise.
4226         (mips_disassembler_options_n32): Likewise.
4227         (mips_disassembler_options_n64): Likewise.
4228         (gdb_print_insn_mips): Don't set `disassembler_options'.
4229         (gdb_print_insn_mips_n32, gdb_print_insn_mips_n64): Remove
4230         functions.
4231         (mips_gdbarch_init): Always set `gdbarch_print_insn' to
4232         `gdb_print_insn_mips'.  Set `gdbarch_disassembler_options',
4233         `gdbarch_disassembler_options_implicit' and
4234         `gdbarch_valid_disassembler_options'.
4235         * arm-tdep.c (_initialize_arm_tdep): Adapt to using the
4236         `disasm_options_and_args_t' structure.
4237         * gdbarch.sh (disassembler_options_implicit): New `gdbarch'
4238         method.
4239         (valid_disassembler_options): Switch from `disasm_options_t' to
4240         the `disasm_options_and_args_t' structure.
4241         * NEWS: Document `set disassembler-options' support for the MIPS
4242         target.
4243         * gdbarch.h: Regenerate.
4244         * gdbarch.c: Regenerate.
4245
4246 2018-07-02  Sebastian Huber  <sebastian.huber@embedded-brains.de>
4247
4248         * riscv-tdep.c (riscv_register_aliases): Swap "fp" and "s0" entries.
4249
4250 2018-06-29  Joel Brobecker  <brobecker@adacore.com>
4251
4252         * amd64-darwin-tdep.c (x86_darwin_init_abi_64): Add missing
4253         parameter in call to amd64_target_description.
4254         * amd64-dicos-tdep.c (amd64_dicos_init_abi): Likewise.
4255         * amd64-fbsd-tdep.c (amd64fbsd_core_read_description)
4256         (amd64fbsd_init_abi): Likewise.
4257         * amd64-nbsd-tdep.c (amd64nbsd_init_abi): Likewise.
4258         * amd64-obsd-tdep.c (amd64obsd_init_abi): Likewise.
4259         * amd64-sol2-tdep.c (amd64_sol2_init_abi): Likewise.
4260         * amd64-fbsd-nat.c (amd64_fbsd_nat_target): Likewise.
4261
4262 2018-06-29  Pedro Alves  <palves@redhat.com>
4263
4264         * gdb/amd64-tdep.h (amd64_create_target_description): Add
4265         "segments" parameter.
4266         * gdb/amd64-tdep.c (amd64_none_init_abi, amd64_x32_none_init_abi)
4267         (_initialize_amd64_tdep): Update call to
4268         amd64_create_target_description.
4269         (amd64_target_description): Add "segments" parameter.  Adjust
4270         the implementation to use it.
4271         * gdb/amd64-linux-tdep.c (amd64_linux_read_description): Update
4272         call to amd64_create_target_description.
4273         * gdb/amd64-windows-tdep.c (amd64_windows_init_abi): Likewise.
4274         * gdb/arch/amd64.h (amd64_create_target_description): Add
4275         "segments" register.
4276         * gdb/arch/amd64.c (amd64_create_target_description): Add
4277         "segments" parameter.  Call create_feature_i386_64bit_segments
4278         only if SEGMENTS is true.
4279         * gdb/gdbserver/win32-i386-low.c (i386_arch_setup): Update
4280         call to amd64_create_target_description.
4281
4282 2018-06-29  Pedro Alves  <palves@redhat.com>
4283
4284         * thread.c (thread_target_id_str): New, factored out from ...
4285         (print_thread_info_1): ... here.  Use it to compute the max
4286         "Target Id" column width.
4287
4288 2018-06-29  Pedro Alves  <palves@redhat.com>
4289
4290         * remote.c (remote_target::extra_thread_info): Delete
4291         'display_buf' and 'n' locals.  from the cache, regardless of
4292         packet mechanims is in use.  Use cache for qThreadExtra and qP
4293         methods too.
4294
4295 2018-06-29  Pedro Alves  <palves@redhat.com>
4296
4297         * blockframe.c (find_pc_sect_containing_function): New function.
4298         * breakpoint.c (print_breakpoint_location): Don't call
4299         find_pc_sect_function.
4300         * linespec.c (create_sals_line_offset): Record the location's
4301         symbol in the sal.
4302         * linespec.c (convert_address_location_to_sals): Fill in sal's
4303         symbol with find_pc_sect_containing_function.
4304         * symtab.c (find_function_start_sal): Rename to ...
4305         (find_function_start_sal_1): ... this.
4306         (find_function_start_sal): Reimplement as wrapper around
4307         find_function_start_sal_1, and use
4308         find_pc_sect_containing_function to fill in the sal's symbol.
4309         (find_function_start_sal(symbol*, bool)): Adjust.
4310         * symtab.h (find_pc_function, find_pc_sect_function): Adjust
4311         comments.
4312         (find_pc_sect_containing_function): Declare.
4313
4314 2018-06-29  Pedro Alves  <palves@redhat.com>
4315
4316         * inline-frame.c (stopped_by_user_bp_inline_frame): Return
4317         true if the the location has no symbol.
4318
4319 2018-06-28  Tom Tromey  <tom@tromey.com>
4320
4321         * NEWS: Mention --enable-codesign.
4322         * silent-rules.mk (ECHO_SIGN): New variable.
4323         * configure.ac: Add --enable-codesign.
4324         * configure: Rebuild.
4325         * Makefile.in (CODESIGN, CODESIGN_CERT): New variables.
4326         (gdb$(EXEEXT)): Optionally invoke codesign.
4327
4328 2018-06-28  Pedro Alves  <palves@redhat.com>
4329
4330         * gdbthread.h (struct thread_suspend_state) <stop_pc>: Extend
4331         comments.
4332         (switch_to_thread_no_regs): Adjust comment.
4333         * infcmd.c (stop_pc): Delete.
4334         (post_create_inferior, info_program_command): Replace references
4335         to stop_pc with references to thread_info->suspend.stop_pc.
4336         * inferior.h (stop_pc): Delete declaration.
4337         * infrun.c (proceed, handle_syscall_event, fill_in_stop_func)
4338         (handle_inferior_event_1, handle_signal_stop)
4339         (process_event_stop_test, keep_going_stepped_thread)
4340         (handle_step_into_function, handle_step_into_function_backward)
4341         (print_stop_location): Replace references to stop_pc with
4342         references to thread_info->suspend.stop_pc.
4343         (struct infcall_suspend_state) <stop_pc>: Delete field.
4344         (save_infcall_suspend_state, restore_infcall_suspend_state):
4345         Remove references to inf_stat->stop_pc.
4346         * linux-fork.c (fork_load_infrun_state): Likewise.
4347         * record-btrace.c (record_btrace_set_replay): Likewise.
4348         * record-full.c (record_full_goto_entry): Likewise.
4349         * remote.c (print_one_stopped_thread): Likewise.
4350         * target.c (target_resume): Extend comment.
4351         * thread.c (set_executing_thread): New.
4352         (set_executing): Use it.
4353         (switch_to_thread_no_regs, switch_to_no_thread, switch_to_thread):
4354         Remove references to stop_pc.
4355
4356 2018-06-28  Pedro Alves  <palves@redhat.com>
4357
4358         * infrun.c (handle_inferior_event_1) <TARGET_WAITKIND_EXECD>:
4359         Moving fetching stop_pc until after ecs->event_thread is refreshed.
4360
4361 2018-06-28  Tom Tromey  <tom@tromey.com>
4362
4363         * coffread.c (coff_symfile_finish): Update.
4364         * xcoffread.c (xcoff_symfile_finish): Update.
4365         * elfread.c (elf_symfile_finish): Update.
4366         * symfile.h (dwarf2_free_objfile): Don't declare.
4367         * dwarf2read.c (_initialize_dwarf2_read): Use
4368         register_objfile_data_with_cleanup.
4369         (dwarf2_free_objfile): Now static.  Change signature.
4370
4371 2018-06-28  Petr Tesarik  <ptesarik@suse.cz>
4372
4373         * symfile.c (add_symbol_file_command, _initialize_symfile): Add
4374         option "-o" to add-symbol-file-load to add an offset to each
4375         section's load address.
4376         * symfile.c (set_objfile_default_section_offset): New function.
4377
4378 2018-06-28  Petr Tesarik  <ptesarik@suse.cz>
4379
4380         * symfile.c (add_symbol_file_command): Make sure that sections
4381         with the same name are sorted in the same order.
4382
4383 2018-06-28  Petr Tesarik  <ptesarik@suse.cz>
4384
4385         * symfile.c (add_symbol_file_command, _initialize_symfile): Do not
4386         require the second argument.  If omitted, load sections at the
4387         addresses specified in the file.
4388
4389 2018-06-28  Petr Tesarik  <ptesarik@suse.cz>
4390
4391         * symfile.c (symbol_file_command, symbol_file_add_main_1)
4392         (_initialize_symfile): Add option "-o" to symbol-file to add an
4393         offset to each section of the symbol file.
4394
4395 2018-06-28  Petr Tesarik  <ptesarik@suse.cz>
4396
4397         * MAINTAINERS (Write After Approval): Add Petr Tesarik.
4398
4399 2018-06-27  Tom Tromey  <tom@tromey.com>
4400
4401         * stack.c (_initialize_stack): Update "func" help text.
4402
4403 2018-06-27  Tom Tromey  <tom@tromey.com>
4404
4405         * python/py-unwind.c (unwind_info_object) <saved_regs>: Now a
4406         std::vector.
4407         (unwind_infopy_str, pyuw_create_unwind_info)
4408         (unwind_infopy_add_saved_register, pyuw_sniffer)
4409         (unwind_infopy_dealloc, unwind_infopy_add_saved_register):
4410         Update.
4411         (struct saved_reg): Add constructor.
4412         <value>: Now a gdbpy_ref<>.
4413
4414 2018-06-27  Tom Tromey  <tom@tromey.com>
4415
4416         * machoread.c (macho_symfile_read): Define "symbol_table" earlier.
4417
4418 2018-06-27  Simon Marchi  <simon.marchi@ericsson.com>
4419
4420         * gdb-gdb.py.in: Format using autopep8.
4421
4422 2018-06-27  Simon Marchi  <simon.marchi@ericsson.com>
4423
4424         * gdb-gdb.py.in (CoreAddrPrettyPrinter): New class.
4425         (type_lookup_function): Recognize CORE_ADDR values.
4426
4427 2018-06-27  Simon Marchi  <simon.marchi@ericsson.com>
4428
4429         * gdb-gdb.py.in (StructMainTypePrettyPrinter) <to_string>: Don't
4430         print tag_name.
4431
4432 2018-06-27  Simon Marchi  <simon.marchi@ericsson.com>
4433
4434         * gdb-gdb.py.in (TypeFlag) <__cmp__>: Remove.
4435         <__lt__>: Add.
4436
4437 2018-06-27  Simon Marchi  <simon.marchi@ericsson.com>
4438
4439         * gdb-gdb.py: Move to...
4440         * gdb-gdb.py.in: ... here.
4441         * configure.ac (AC_CONFIG_FILES): Add gdb-gdb.py.
4442         * Makefile.in (all): Add gdb-gdb.gdb and gdb-gdb.py as
4443         dependencies.
4444         (distclean): Remove gdb-gdb.py when cleaning.
4445         (gdb-gdb.py, gdb-gdb.gdb): New rules.
4446         * configure: Re-generate.
4447
4448 2018-06-27  Pedro Alves  <palves@redhat.com>
4449
4450         * proc-service.c (get_ps_regcache): New.
4451         (ps_lgetregs, ps_lsetregs, ps_lgetfpregs)
4452         (ps_lsetfpregs): Use it.
4453
4454 2018-06-27  Omair Javaid  <omair.javaid@linaro.org>
4455
4456         PR gdb/21695
4457         * dwarf2read.c (lnp_state_machine::check_line_address): Update declaration.
4458         (dwarf_decode_lines_1): Adjust.
4459
4460 2018-06-27  Simon Marchi  <simon.marchi@ericsson.com>
4461
4462         * fbsd-nat.h (class fbsd_nat_target) <find_memory_regions>: Add
4463         override.
4464         <info_proc>: Likewise.
4465
4466 2018-06-26  Joel Brobecker  <brobecker@adacore.com>
4467
4468         * windows-nat.c (do_windows_fetch_inferior_registers): Rename
4469         to windows_fetch_one_register, and only handle the case of
4470         fetching one register.  Move the code that reloads the context
4471         and iterates over all registers if R is negative to...
4472         (windows_nat_target::fetch_registers): ... here.
4473         (do_windows_store_inferior_registers): Rename to
4474         windows_store_one_register, and only handle the case of storing
4475         one register.  Move the code that handles the case where r is
4476         negative to...
4477         (windows_nat_target::store_registers) ... here.
4478
4479 2018-06-26  Tom Tromey  <tom@tromey.com>
4480
4481         PR rust/22574:
4482         * typeprint.c (whatis_exp): Allow ptype/o for Rust.
4483         * rust-lang.c (rust_print_struct_def): Add podata parameter.
4484         Update.
4485         (rust_internal_print_type): Add podata parameter.
4486         (rust_print_type): Update.
4487
4488 2018-06-26  Tom Tromey  <tom@tromey.com>
4489
4490         * typeprint.h (struct print_offset_data) <update, finish,
4491         maybe_print_hole>: New methods.
4492         <indentation>: New constant.
4493         * typeprint.c (print_offset_data::indentation): Define.
4494         (print_offset_data::maybe_print_hole, print_offset_data::update)
4495         (print_offset_data::finish): Move from c-typeprint.c and rename.
4496         * c-typeprint.c (OFFSET_SPC_LEN): Remove.
4497         (print_spaces_filtered_with_print_options): Update.
4498         (c_print_type_union_field_offset, maybe_print_hole)
4499         (c_print_type_struct_field_offset): Move to typeprint.c and
4500         rename.
4501         (c_type_print_base_struct_union): Update.
4502
4503 2018-06-25  Pedro Alves  <palves@redhat.com>
4504
4505         * gdbthread.h (thread_info_ref, delete_thread)
4506         (delete_thread_silent, first_thread_of_inferior)
4507         (any_thread_of_inferior, switch_to_thread)
4508         (enable_thread_stack_temporaries)
4509         (thread_stack_temporaries_enabled_p, push_thread_stack_temporary)
4510         (get_last_thread_stack_temporary)
4511         (value_in_thread_stack_temporaries, can_access_registers_thread):
4512         Spell out "struct thread_info" instead of just "thread_info".
4513         * inferior.h (notice_new_inferior): Likewise.
4514
4515 2018-06-25  Pedro Alves  <palves@redhat.com>
4516
4517         * windows-nat.c (windows_delete_thread): Use find_thread_ptid and
4518         pass thread_info pointer to delete_thread.
4519         (windows_nat_target::detach): Pass inferior pointer to
4520         detach_inferior.
4521         * aix-thread.c (sync_threadlists): Pass thread_info pointer to
4522         delete_thread.
4523         * bsd-kvm.c (bsd_kvm_target::close): Use discard_all_inferiors.
4524         * darwin-nat.c (darwin_check_new_threads): Use find_thread_ptid
4525         and pass a thread_info pointer to delete_thread.
4526         * fbsd-nat.c (fbsd_nat_target::wait): Use find_thread_ptid and
4527         pass thread_info pointer to delete_thread.
4528         * go32-nat.c (go32_nat_target::mourn_inferior): Remove
4529         delete_thread_silent call.
4530         * procfs.c (procfs_target::detach): Pass inferior pointer to
4531         detach_inferior.
4532         (procfs_target::wait): Pass thread_info pointer to delete_thread.
4533         * remote-sim.c (gdbsim_target::mourn_inferior): Remove
4534         delete_thread_silent call.
4535         * windows-nat.c (windows_delete_thread): Use find_thread_ptid and
4536         pass thread_info pointer to delete_thread.
4537         (windows_nat_target::detach): Pass inferior pointer to
4538         delete_inferior.
4539
4540 2018-06-22  Alan Hayward  <alan.hayward@arm.com>
4541
4542         * regcache.c (readable_regcache::read_part): Fix asserts.
4543         (reg_buffer::raw_collect_part): New function.
4544         (regcache::write_part): Fix asserts.
4545         (reg_buffer::raw_supply_part): New function.
4546         (regcache::transfer_regset_register): New helper function.
4547         (regcache::transfer_regset): Call new functions.
4548         (regcache_supply_regset): Use gdb_byte*.
4549         (regcache::supply_regset): Likewise.
4550         (regcache_collect_regset): Likewise.
4551         (regcache::collect_regset): Likewise.
4552         * regcache.h (reg_buffer::raw_collect_part): New declaration.
4553         (reg_buffer::raw_supply_part): Likewise.
4554         (regcache::transfer_regset_register): Likewise.
4555         (regcache::transfer_regset): Use gdb_byte*.
4556
4557 2018-06-22  Alan Hayward  <alan.hayward@arm.com>
4558
4559         * nat/aarch64-sve-linux-ptrace.h (HAS_SVE_STATE): Use &.
4560
4561 2018-06-21  Pedro Alves  <palves@redhat.com>
4562
4563         * ada-lang.h (ada_get_task_number): Take a thread_info pointer
4564         instead of a ptid_t.  All callers adjusted.
4565         * ada-tasks.c (ada_get_task_number): Likewise.  All callers
4566         adjusted.
4567         (print_ada_task_info, display_current_task_id, task_command_1):
4568         Adjust.
4569         * breakpoint.c (watchpoint_in_thread_scope): Adjust to use
4570         inferior_thread.
4571         (breakpoint_kind): Adjust.
4572         (remove_breakpoints_pid): Rename to ...
4573         (remove_breakpoints_inf): ... this.  Adjust to take an inferior
4574         pointer.  All callers adjusted.
4575         (bpstat_clear_actions): Use inferior_thread.
4576         (get_bpstat_thread): New.
4577         (bpstat_do_actions): Use it.
4578         (bpstat_check_breakpoint_conditions, bpstat_stop_status): Adjust
4579         to take a thread_info pointer.  All callers adjusted.
4580         (set_longjmp_breakpoint_for_call_dummy, set_momentary_breakpoint)
4581         (breakpoint_re_set_thread): Use inferior_thread.
4582         * breakpoint.h (struct inferior): Forward declare.
4583         (bpstat_stop_status): Update.
4584         (remove_breakpoints_pid): Delete.
4585         (remove_breakpoints_inf): New.
4586         * bsd-uthread.c (bsd_uthread_target::wait)
4587         (bsd_uthread_target::update_thread_list): Use find_thread_ptid.
4588         * btrace.c (btrace_add_pc, btrace_enable, btrace_fetch)
4589         (maint_btrace_packet_history_cmd)
4590         (maint_btrace_clear_packet_history_cmd): Adjust.
4591         (maint_btrace_clear_cmd, maint_info_btrace_cmd): Adjust to use
4592         inferior_thread.
4593         * cli/cli-interp.c: Include "inferior.h".
4594         * common/refcounted-object.h (struct
4595         refcounted_object_ref_policy): New.
4596         * compile/compile-object-load.c: Include gdbthread.h.
4597         (store_regs): Use inferior_thread.
4598         * corelow.c (core_target::close): Use current_inferior.
4599         (core_target_open): Adjust to use first_thread_of_inferior and use
4600         the current inferior.
4601         * ctf.c (ctf_target::close): Adjust to use current_inferior.
4602         * dummy-frame.c (dummy_frame_id) <ptid>: Delete, replaced by ...
4603         <thread>: ... this new field.  All references adjusted.
4604         (dummy_frame_pop, dummy_frame_discard, register_dummy_frame_dtor):
4605         Take a thread_info pointer instead of a ptid_t.
4606         * dummy-frame.h (dummy_frame_push, dummy_frame_pop)
4607         (dummy_frame_discard, register_dummy_frame_dtor): Take a
4608         thread_info pointer instead of a ptid_t.
4609         * elfread.c: Include "inferior.h".
4610         (elf_gnu_ifunc_resolver_stop, elf_gnu_ifunc_resolver_return_stop):
4611         Use inferior_thread.
4612         * eval.c (evaluate_subexp): Likewise.
4613         * frame.c (frame_pop, has_stack_frames, find_frame_sal): Use
4614         inferior_thread.
4615         * gdb_proc_service.h (struct thread_info): Forward declare.
4616         (struct ps_prochandle) <ptid>: Delete, replaced by ...
4617         <thread>: ... this new field.  All references adjusted.
4618         * gdbarch.h, gdbarch.c: Regenerate.
4619         * gdbarch.sh (get_syscall_number): Replace 'ptid' parameter with a
4620         'thread' parameter.  All implementations and callers adjusted.
4621         * gdbthread.h (thread_info) <set_running>: New method.
4622         (delete_thread, delete_thread_silent): Take a thread_info pointer
4623         instead of a ptid.
4624         (global_thread_id_to_ptid, ptid_to_global_thread_id): Delete.
4625         (first_thread_of_process): Delete, replaced by ...
4626         (first_thread_of_inferior): ... this new function.  All callers
4627         adjusted.
4628         (any_live_thread_of_process): Delete, replaced by ...
4629         (any_live_thread_of_inferior): ... this new function.  All callers
4630         adjusted.
4631         (switch_to_thread, switch_to_no_thread): Declare.
4632         (is_executing): Delete.
4633         (enable_thread_stack_temporaries): Update comment.
4634         <enable_thread_stack_temporaries>: Take a thread_info pointer
4635         instead of a ptid_t.  Incref the thread.
4636         <~enable_thread_stack_temporaries>: Decref the thread.
4637         <m_ptid>: Delete
4638         <m_thr>: New.
4639         (thread_stack_temporaries_enabled_p, push_thread_stack_temporary)
4640         (get_last_thread_stack_temporary)
4641         (value_in_thread_stack_temporaries, can_access_registers_thread):
4642         Take a thread_info pointer instead of a ptid_t.  All callers
4643         adjusted.
4644         * infcall.c (get_call_return_value): Use inferior_thread.
4645         (run_inferior_call): Work with thread pointers instead of ptid_t.
4646         (call_function_by_hand_dummy): Work with thread pointers instead
4647         of ptid_t.  Use thread_info_ref.
4648         * infcmd.c (proceed_thread_callback): Access thread's state
4649         directly.
4650         (ensure_valid_thread, ensure_not_running): Use inferior_thread,
4651         access thread's state directly.
4652         (continue_command): Use inferior_thread.
4653         (info_program_command): Use find_thread_ptid and access thread
4654         state directly.
4655         (proceed_after_attach_callback): Use thread state directly.
4656         (notice_new_inferior): Take a thread_info pointer instead of a
4657         ptid_t.  All callers adjusted.
4658         (exit_inferior): Take an inferior pointer instead of a pid.  All
4659         callers adjusted.
4660         (exit_inferior_silent): New.
4661         (detach_inferior): Delete.
4662         (valid_gdb_inferior_id, pid_to_gdb_inferior_id)
4663         (gdb_inferior_id_to_pid, in_inferior_list): Delete.
4664         (detach_inferior_command, kill_inferior_command): Use
4665         find_inferior_id instead of valid_gdb_inferior_id and
4666         gdb_inferior_id_to_pid.
4667         (inferior_command): Use inferior and thread pointers.
4668         * inferior.h (struct thread_info): Forward declare.
4669         (notice_new_inferior): Take a thread_info pointer instead of a
4670         ptid_t.  All callers adjusted.
4671         (detach_inferior): Delete declaration.
4672         (exit_inferior, exit_inferior_silent): Take an inferior pointer
4673         instead of a pid.  All callers adjusted.
4674         (gdb_inferior_id_to_pid, pid_to_gdb_inferior_id, in_inferior_list)
4675         (valid_gdb_inferior_id): Delete.
4676         * infrun.c (follow_fork_inferior, proceed_after_vfork_done)
4677         (handle_vfork_child_exec_or_exit, follow_exec): Adjust.
4678         (struct displaced_step_inferior_state) <pid>: Delete, replaced by
4679         ...
4680         <inf>: ... this new field.
4681         <step_ptid>: Delete, replaced by ...
4682         <step_thread>: ... this new field.
4683         (get_displaced_stepping_state): Take an inferior pointer instead
4684         of a pid.  All callers adjusted.
4685         (displaced_step_in_progress_any_inferior): Adjust.
4686         (displaced_step_in_progress_thread): Take a thread pointer instead
4687         of a ptid_t.  All callers adjusted.
4688         (displaced_step_in_progress, add_displaced_stepping_state): Take
4689         an inferior pointer instead of a pid.  All callers adjusted.
4690         (get_displaced_step_closure_by_addr): Adjust.
4691         (remove_displaced_stepping_state): Take an inferior pointer
4692         instead of a pid.  All callers adjusted.
4693         (displaced_step_prepare_throw, displaced_step_prepare)
4694         (displaced_step_fixup): Take a thread pointer instead of a ptid_t.
4695         All callers adjusted.
4696         (start_step_over): Adjust.
4697         (infrun_thread_ptid_changed): Remove bit updating ptids in the
4698         displaced step queue.
4699         (do_target_resume): Adjust.
4700         (fetch_inferior_event): Use inferior_thread.
4701         (context_switch, get_inferior_stop_soon): Take an
4702         execution_control_state pointer instead of a ptid_t.  All callers
4703         adjusted.
4704         (switch_to_thread_cleanup): Delete.
4705         (stop_all_threads): Use scoped_restore_current_thread.
4706         * inline-frame.c: Include "gdbthread.h".
4707         (inline_state) <inline_state>: Take a thread pointer instead of a
4708         ptid_t.  All callers adjusted.
4709         <ptid>: Delete, replaced by ...
4710         <thread>: ... this new field.
4711         (find_inline_frame_state): Take a thread pointer instead of a
4712         ptid_t.  All callers adjusted.
4713         (skip_inline_frames, step_into_inline_frame)
4714         (inline_skipped_frames, inline_skipped_symbol): Take a thread
4715         pointer instead of a ptid_t.  All callers adjusted.
4716         * inline-frame.h (skip_inline_frames, step_into_inline_frame)
4717         (inline_skipped_frames, inline_skipped_symbol): Likewise.
4718         * linux-fork.c (delete_checkpoint_command): Adjust to use thread
4719         pointers directly.
4720         * linux-nat.c (get_detach_signal): Likewise.
4721         * linux-thread-db.c (thread_from_lwp): New 'stopped' parameter.
4722         (thread_db_notice_clone): Adjust.
4723         (thread_db_find_new_threads_silently)
4724         (thread_db_find_new_threads_2, thread_db_find_new_threads_1): Take
4725         a thread pointer instead of a ptid_t.  All callers adjusted.
4726         * mi/mi-cmd-var.c: Include "inferior.h".
4727         (mi_cmd_var_update_iter): Update to use thread pointers.
4728         * mi/mi-interp.c (mi_new_thread): Update to use the thread's
4729         inferior directly.
4730         (mi_output_running_pid, mi_inferior_count): Delete, bits factored
4731         out to ...
4732         (mi_output_running): ... this new function.
4733         (mi_on_resume_1): Adjust to use it.
4734         (mi_user_selected_context_changed): Adjust to use inferior_thread.
4735         * mi/mi-main.c (proceed_thread): Adjust to use thread pointers
4736         directly.
4737         (interrupt_thread_callback): : Adjust to use thread and inferior
4738         pointers.
4739         * proc-service.c: Include "gdbthread.h".
4740         (ps_pglobal_lookup): Adjust to use the thread's inferior directly.
4741         * progspace-and-thread.c: Include "inferior.h".
4742         * progspace.c: Include "inferior.h".
4743         * python/py-exitedevent.c (create_exited_event_object): Adjust to
4744         hold a reference to an inferior_object.
4745         * python/py-finishbreakpoint.c (bpfinishpy_init): Adjust to use
4746         inferior_thread.
4747         * python/py-inferior.c (struct inferior_object): Give the type a
4748         tag name instead of a typedef.
4749         (python_on_normal_stop): No need to check if the current thread is
4750         listed.
4751         (inferior_to_inferior_object): Change return type to
4752         inferior_object.  All callers adjusted.
4753         (find_thread_object): Delete, bits factored out to ...
4754         (thread_to_thread_object): ... this new function.
4755         * python/py-infthread.c (create_thread_object): Use
4756         inferior_to_inferior_object.
4757         (thpy_is_stopped): Use thread pointer directly.
4758         (gdbpy_selected_thread): Use inferior_thread.
4759         * python/py-record-btrace.c (btpy_list_object) <ptid>: Delete
4760         field, replaced with ...
4761         <thread>: ... this new field.  All users adjusted.
4762         (btpy_insn_or_gap_new): Drop const.
4763         (btpy_list_new): Take a thread pointer instead of a ptid_t.  All
4764         callers adjusted.
4765         * python/py-record.c: Include "gdbthread.h".
4766         (recpy_insn_new, recpy_func_new): Take a thread pointer instead of
4767         a ptid_t.  All callers adjusted.
4768         (gdbpy_current_recording): Use inferior_thread.
4769         * python/py-record.h (recpy_record_object) <ptid>: Delete
4770         field, replaced with ...
4771         <thread>: ... this new field.  All users adjusted.
4772         (recpy_element_object) <ptid>: Delete
4773         field, replaced with ...
4774         <thread>: ... this new field.  All users adjusted.
4775         (recpy_insn_new, recpy_func_new): Take a thread pointer instead of
4776         a ptid_t.  All callers adjusted.
4777         * python/py-threadevent.c: Include "gdbthread.h".
4778         (get_event_thread): Use thread_to_thread_object.
4779         * python/python-internal.h (struct inferior_object): Forward
4780         declare.
4781         (find_thread_object, find_inferior_object): Delete declarations.
4782         (thread_to_thread_object, inferior_to_inferior_object): New
4783         declarations.
4784         * record-btrace.c: Include "inferior.h".
4785         (require_btrace_thread): Use inferior_thread.
4786         (record_btrace_frame_sniffer)
4787         (record_btrace_tailcall_frame_sniffer): Use inferior_thread.
4788         (get_thread_current_frame): Use scoped_restore_current_thread and
4789         switch_to_thread.
4790         (get_thread_current_frame): Use thread pointer directly.
4791         (record_btrace_replay_at_breakpoint): Use thread's inferior
4792         pointer directly.
4793         * record-full.c: Include "inferior.h".
4794         * regcache.c: Include "gdbthread.h".
4795         (get_thread_arch_regcache): Use the inferior's address space
4796         directly.
4797         (get_thread_regcache, registers_changed_thread): New.
4798         * regcache.h (get_thread_regcache(thread_info *thread)): New
4799         overload.
4800         (registers_changed_thread): New.
4801         (remote_target) <remote_detach_1>: Swap order of parameters.
4802         (remote_add_thread): <remote_add_thread>: Return the new thread.
4803         (get_remote_thread_info(ptid_t)): New overload.
4804         (remote_target::remote_notice_new_inferior): Use thread pointers
4805         directly.
4806         (remote_target::process_initial_stop_replies): Use
4807         thread_info::set_running.
4808         (remote_target::remote_detach_1, remote_target::detach)
4809         (extended_remote_target::detach): Adjust.
4810         * stack.c (frame_show_address): Use inferior_thread.
4811         * target-debug.h (target_debug_print_thread_info_pp): New.
4812         * target-delegates.c: Regenerate.
4813         * target.c (default_thread_address_space): Delete.
4814         (memory_xfer_partial_1): Use current_inferior.
4815         (target_detach): Use current_inferior.
4816         (target_thread_address_space): Delete.
4817         (generic_mourn_inferior): Use current_inferior.
4818         * target.h (struct target_ops) <thread_address_space>: Delete.
4819         (target_thread_address_space): Delete.
4820         * thread.c (init_thread_list): Use ALL_THREADS_SAFE.  Use thread
4821         pointers directly.
4822         (delete_thread_1, delete_thread, delete_thread_silent): Take a
4823         thread pointer instead of a ptid_t.  Adjust all callers.
4824         (ptid_to_global_thread_id, global_thread_id_to_ptid): Delete.
4825         (first_thread_of_process): Delete, replaced by ...
4826         (first_thread_of_inferior): ... this new function.  All callers
4827         adjusted.
4828         (any_thread_of_process): Rename to ...
4829         (any_thread_of_inferior): ... this, and take an inferior pointer.
4830         (any_live_thread_of_process): Rename to ...
4831         (any_live_thread_of_inferior): ... this, and take an inferior
4832         pointer.
4833         (thread_stack_temporaries_enabled_p, push_thread_stack_temporary)
4834         (value_in_thread_stack_temporaries)
4835         (get_last_thread_stack_temporary): Take a thread pointer instead
4836         of a ptid_t.  Adjust all callers.
4837         (thread_info::set_running): New.
4838         (validate_registers_access): Use inferior_thread.
4839         (can_access_registers_ptid): Rename to ...
4840         (can_access_registers_thread): ... this, and take a thread
4841         pointer.
4842         (print_thread_info_1): Adjust to compare thread pointers instead
4843         of ptids.
4844         (switch_to_no_thread, switch_to_thread): Make extern.
4845         (scoped_restore_current_thread::~scoped_restore_current_thread):
4846         Use m_thread pointer directly.
4847         (scoped_restore_current_thread::scoped_restore_current_thread):
4848         Use inferior_thread.
4849         (thread_command): Use thread pointer directly.
4850         (thread_num_make_value_helper): Use inferior_thread.
4851         * top.c (execute_command): Use inferior_thread.
4852         * tui/tui-interp.c: Include "inferior.h".
4853         * varobj.c (varobj_create): Use inferior_thread.
4854         (value_of_root_1): Use find_thread_global_id instead of
4855         global_thread_id_to_ptid.
4856
4857 2018-06-21  Alan Hayward  <alan.hayward@arm.com>
4858
4859         * regcache.c (readable_regcache::read_part): Avoid memcpy when
4860         possible.
4861         (regcache::write_part): Likewise.
4862         (readable_regcache::cooked_read_part): Update comment.
4863         (readable_regcache::cooked_write_part): Likewise.
4864         * regcache.h: (readable_regcache::read_part): Likewise.
4865         (regcache::write_part): Likewise.
4866
4867 2018-06-21  Richard Bunt  <richard.bunt@arm.com>
4868             Dirk Schubert  <dirk.schubert@arm.com>
4869
4870         * aarch64-linux-nat.c (post_attach): New.
4871         (aarch64_linux_nat_target::post_attach): Override post_attach to
4872         record the number of hardware debug registers.
4873
4874 2018-06-20  Tom Tromey  <tom@tromey.com>
4875
4876         * python/py-param.c (add_setshow_generic): Make parameters const.
4877         (parmpy_init): Update.
4878
4879 2018-06-20  Simon Marchi  <simon.marchi@polymtl.ca>
4880
4881         * regcache.h (regcache_cooked_read_ftype): Rename to...
4882         (register_read_ftype): ...this, change type to function_view.
4883         (class reg_buffer) <save>: Remove src parameter.
4884         (readonly_detached_regcache) <readonly_detached_regcache>: Make
4885         parameter non-const in first overload.  Remove src parameter in
4886         second overload.
4887         * regcache.c (do_cooked_read): Remove.
4888         (readonly_detached_regcache::readonly_detached_regcache): Make
4889         parameter non-const, adjust call to other constructor.
4890         (reg_buffer::save): Remove src parameter.
4891         * frame.c (do_frame_register_read): Remove.
4892         (frame_save_as_regcache): Use lambda function.
4893         * ppc-linux-tdep.c (ppu2spu_unwind_register): Change type of src
4894         parameter to ppu2spu_data *.
4895         (ppu2spu_sniffer): Use lambda function.
4896
4897 2018-06-20  Simon Marchi  <simon.marchi@polymtl.ca>
4898
4899         * record-full.c (record_full_target::insert_breakpoint): Remove
4900         "struct" keyword, add const.
4901
4902 2018-06-19  Simon Marchi  <simon.marchi@ericsson.com>
4903
4904         * common/common-defs.h (PACKAGE_NAME, PACKAGE_VERSION,
4905         PACKAGE_STRING, PACKAGE_TARNAME): Undefine.
4906         * configure.ac: Remove AC_PREREQ, add missing quoting.
4907         * gnulib/configure.ac: Modernize usage of
4908         AC_INIT/AM_INIT_AUTOMAKE.  Remove AC_PREREQ.
4909         * gnulib/update-gnulib.sh (AUTOCONF_VERSION): Bump to 2.69.
4910         (AUTOMAKE_VERSION): Bump to 1.15.1.
4911         * configure: Re-generate.
4912         * config.in: Re-generate.
4913         * aclocal.m4: Re-generate.
4914         * gnulib/aclocal.m4: Re-generate.
4915         * gnulib/config.in: Re-generate.
4916         * gnulib/configure: Re-generate.
4917         * gnulib/import/Makefile.in: Re-generate.
4918
4919 2018-06-19  Pedro Alves  <palves@redhat.com>
4920
4921         * minsyms.c (msym_prefer_to_msym_type): New, factored out from ...
4922         (lookup_minimal_symbol_by_pc_section): ... here with
4923         gdb_assert_not_reached added.
4924
4925 2018-06-19  Pedro Alves  <palves@redhat.com>
4926
4927         * inline-frame.c (stopped_by_user_bp_inline_frame): Replace PC
4928         parameter with a block parameter.  Compare location's block symbol
4929         with the frame's block instead of addresses.
4930         (skip_inline_frames): Pass the current block instead of the
4931         frame's address.  Break out as soon as we determine the frame
4932         should not be skipped.
4933
4934 2018-06-18  Tom Tromey  <tom@tromey.com>
4935
4936         * solib-aix.c (solib_aix_get_section_offsets): Return
4937         unique_xmalloc_ptr.
4938         (solib_aix_solib_create_inferior_hook): Update.
4939
4940 2018-06-18  Tom Tromey  <tom@tromey.com>
4941
4942         * solib-darwin.c (darwin_current_sos): Use unique_xmalloc_ptr.
4943
4944 2018-06-18  Tom Tromey  <tom@tromey.com>
4945
4946         * solib-frv.c (frv_relocate_main_executable): Use
4947         unique_xmalloc_ptr.
4948         * solib-dsbt.c (dsbt_relocate_main_executable): Use
4949         unique_xmalloc_ptr.
4950
4951 2018-06-18  Tom Tromey  <tom@tromey.com>
4952
4953         * objfiles.h (inhibit_section_map_updates): Update.
4954         (resume_section_map_updates, resume_section_map_updates_cleanup):
4955         Remove.
4956         * solib-svr4.c (svr4_handle_solib_event): Update.
4957         * objfiles.c (inhibit_section_map_updates): Return
4958         scoped_restore_tmpl<int>.
4959         (resume_section_map_updates, resume_section_map_updates_cleanup):
4960         Remove.
4961
4962 2018-06-18  Tom Tromey  <tom@tromey.com>
4963
4964         * valprint.h (read_string): Update.
4965         * valprint.c (read_string): Change type of "buffer".
4966         (val_print_string): Update.
4967         * python/py-value.c (valpy_string): Update.
4968         * language.h (struct language_defn) <la_get_string>: Change
4969         type of "buffer".
4970         (default_get_string, c_get_string): Update.
4971         * language.c (default_get_string): Change type of "buffer".
4972         * guile/scm-value.c (gdbscm_value_to_string): Update.
4973         * c-lang.c (c_get_string): Change type of "buffer".
4974
4975 2018-06-18  Tom Tromey  <tom@tromey.com>
4976
4977         * ser-mingw.c (struct pipe_state_destroyer): New.
4978         (pipe_state_up): New typedef.
4979         (cleanup_pipe_state): Remove.
4980         (pipe_windows_open): Use pipe_state_up.  Don't release argv.
4981
4982 2018-06-18  Tom Tromey  <tom@tromey.com>
4983
4984         * rust-lang.h (rust_yyerror): Don't declare.
4985         * rust-lang.c (rust_language_defn): Update.
4986         * rust-exp.y (yyerror): Now static.
4987         * parse.c (parse_exp_in_context_1): Update.
4988         * p-lang.h (p_yyerror): Don't declare.
4989         * p-lang.c (p_language_defn): Update.
4990         * p-exp.y (yyerror): Now static.
4991         * opencl-lang.c (opencl_language_defn): Update.
4992         * objc-lang.c (objc_language_defn): Update.
4993         * m2-lang.h (m2_yyerror): Don't declare.
4994         * m2-lang.c (m2_language_defn): Update.
4995         * m2-exp.y (yyerror): Now static.
4996         * language.h (struct language_defn) <la_error>: Remove.
4997         * language.c (unk_lang_error): Remove.
4998         (unknown_language_defn, auto_language_defn): Remove.
4999         * go-lang.h (go_yyerror): Don't declare.
5000         * go-lang.c (go_language_defn): Update.
5001         * go-exp.y (yyerror): Now static.
5002         * f-lang.h (f_yyerror): Don't declare.
5003         * f-lang.c (f_language_defn): Update.
5004         * f-exp.y (yyerror): Now static.
5005         * d-lang.h (d_yyerror): Don't declare.
5006         * d-lang.c (d_language_defn): Update.
5007         * d-exp.y (yyerror): Now static.
5008         * c-lang.h (c_yyerror): Don't declare.
5009         * c-lang.c (c_language_defn, cplus_language_defn)
5010         (asm_language_defn, minimal_language_defn): Update.
5011         * c-exp.y (yyerror): Now static.
5012         * ada-lang.h (ada_yyerror): Don't declare.
5013         * ada-lang.c (ada_language_defn): Update.
5014         * ada-exp.y (yyerror): Now static.
5015
5016 2018-06-18  Alan Hayward  <alan.hayward@arm.com>
5017
5018         * aarch64-linux-nat.c (fetch_sveregs_from_thread): New function.
5019         (store_sveregs_to_thread): Likewise.
5020         (aarch64_linux_fetch_inferior_registers): Check for SVE.
5021         (aarch64_linux_store_inferior_registers): Likewise.
5022         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_get_sveregs): New
5023         function.
5024         (aarch64_sve_regs_copy_to_regcache): Likewise.
5025         (aarch64_sve_regs_copy_from_regcache): Likewise.
5026         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_get_sveregs): New
5027         declaration.
5028         (aarch64_sve_regs_copy_to_regcache): Likewise.
5029         (aarch64_sve_regs_copy_from_regcache): Likewise.
5030         (sve_context): Structure from Linux headers.
5031         (SVE_SIG_ZREGS_SIZE): Define from Linux headers.
5032         (SVE_SIG_ZREG_SIZE): Likewise.
5033         (SVE_SIG_PREG_SIZE): Likewise.
5034         (SVE_SIG_FFR_SIZE): Likewise.
5035         (SVE_SIG_REGS_OFFSET): Likewise.
5036         (SVE_SIG_ZREGS_OFFSET): Likewise.
5037         (SVE_SIG_ZREG_OFFSET): Likewise.
5038         (SVE_SIG_ZREGS_SIZE): Likewise.
5039         (SVE_SIG_PREGS_OFFSET): Likewise.
5040         (SVE_SIG_PREG_OFFSET): Likewise.
5041         (SVE_SIG_PREGS_SIZE): Likewise.
5042         (SVE_SIG_FFR_OFFSET): Likewise.
5043         (SVE_SIG_REGS_SIZE): Likewise.
5044         (SVE_SIG_CONTEXT_SIZE): Likewise.
5045         (SVE_PT_REGS_MASK): Likewise.
5046         (SVE_PT_REGS_FPSIMD): Likewise.
5047         (SVE_PT_REGS_SVE): Likewise.
5048         (SVE_PT_VL_INHERIT): Likewise.
5049         (SVE_PT_VL_ONEXEC): Likewise.
5050         (SVE_PT_REGS_OFFSET): Likewise.
5051         (SVE_PT_FPSIMD_OFFSET): Likewise.
5052         (SVE_PT_FPSIMD_SIZE): Likewise.
5053         (SVE_PT_SVE_ZREG_SIZE): Likewise.
5054         (SVE_PT_SVE_PREG_SIZE): Likewise.
5055         (SVE_PT_SVE_FFR_SIZE): Likewise.
5056         (SVE_PT_SVE_FPSR_SIZE): Likewise.
5057         (SVE_PT_SVE_FPCR_SIZE): Likewise.
5058         (__SVE_SIG_TO_PT): Likewise.
5059         (SVE_PT_SVE_OFFSET): Likewise.
5060         (SVE_PT_SVE_ZREGS_OFFSET): Likewise.
5061         (SVE_PT_SVE_ZREG_OFFSET): Likewise.
5062         (SVE_PT_SVE_ZREGS_SIZE): Likewise.
5063         (SVE_PT_SVE_PREGS_OFFSET): Likewise.
5064         (SVE_PT_SVE_PREG_OFFSET): Likewise.
5065         (SVE_PT_SVE_PREGS_SIZE): Likewise.
5066         (SVE_PT_SVE_FFR_OFFSET): Likewise.
5067         (SVE_PT_SVE_FPSR_OFFSET): Likewise.
5068         (SVE_PT_SVE_FPCR_OFFSET): Likewise.
5069         (SVE_PT_SVE_SIZE): Likewise.
5070         (SVE_PT_SIZE): Likewise.
5071         (HAS_SVE_STATE): New define.
5072
5073 2018-06-18  Alan Hayward  <alan.hayward@arm.com>
5074
5075         * nat/aarch64-sve-linux-sigcontext.h: New file.
5076         * nat/aarch64-sve-linux-ptrace.h (SVE_VQ_BYTES): Move to
5077         new files.
5078         (SVE_VQ_MIN): Likewise.
5079         (SVE_VQ_MAX): Likewise.
5080         (SVE_VL_MIN): Likewise.
5081         (SVE_VL_MAX): Likewise.
5082         (SVE_NUM_ZREGS): Likewise.
5083         (SVE_NUM_PREGS): Likewise.
5084         (sve_vl_valid): Likewise.
5085         (struct user_sve_header): Likewise.
5086
5087 2018-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
5088             Richard Bunt <Richard.Bunt@arm.com>
5089
5090         * linux-nat.c (stop_wait_callback): Don't discard SIGSTOP if it
5091         was requested by GDB.
5092
5093 2018-06-15  Tom de Vries  <tdevries@suse.de>
5094
5095         * MAINTAINERS (Write After Approval): Add Tom de Vries.
5096
5097 2018-06-14  Simon Marchi  <simon.marchi@polymtl.ca>
5098
5099         * gnulib/update-gnulib.sh: Print expected versions of
5100         autoconf/aclocal.
5101
5102 2018-06-14  Simon Marchi  <simon.marchi@ericsson.com>
5103
5104         * arch-utils.c (default_type_align): Use type_length_units.
5105         * gdbtypes.c (type_align): Use type_length_units.
5106
5107 2018-06-14  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5108
5109         * cli/cli-script.c (_initialize_cli_script): Fix online documentation
5110         of 'define' command.
5111
5112 2018-06-14  Tom de Vries  <tdevries@suse.de>
5113
5114         PR cli/22573
5115         * infcmd.c (print_return_value_1): Use get_user_print_options instead of
5116         get_no_prettyformat_print_options.
5117
5118 2018-06-13  Simon Marchi  <simon.marchi@ericsson.com>
5119
5120         * sparc-nat.h: Include target.h.
5121         * sparc64-linux-nat.c (class sparc64_linux_nat_target)
5122         <fetch_registers>: Remove this argument in function call.
5123         <store_registers>: Remove this argument in function call, remove
5124         extra semicolon.
5125         <low_forget_process>: Call sparc64_forget_process instead of
5126         sparc_forget_process.
5127
5128 2018-06-13  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
5129
5130         * procfs.c (_initialize_procfs): Use add_inf_child_target.
5131         (procfs_target::make_corefile_notes): Adjust to new
5132         target_read_alloc return type.
5133
5134 2018-06-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5135             Stephen Roberts  <stephen.roberts@arm.com>
5136
5137         PR gdb/22882
5138         * infrun.c (fetch_inferior_event): If GDB is not proceeding then
5139         run INF_EXEC_COMPLETE handler, even when not calling normal_stop.
5140         Move should_notify_stop local into more inner scope.
5141
5142 2018-06-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5143             Stephen Roberts  <stephen.roberts@arm.com>
5144
5145         PR gdb/22882
5146         * infrun.c (resume_1): Add call to mark_async_event_handler.
5147
5148 2018-06-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5149
5150         * infrun.c (do_target_wait): Change old version of $pc printed.
5151
5152 2018-06-11  Simon Marchi  <simon.marchi@ericsson.com>
5153
5154         * dwarf2read.c (read_index_from_section): Rename to...
5155         (read_gdb_index_from_section): ... this, update all callers.
5156         (dwarf2_read_index): Rename to...
5157         (dwarf2_read_gdb_index): ... this, update all callers.
5158
5159 2018-06-11  John David Anglin  <danglin@gcc.gnu.org>
5160
5161         * gdb/hppa-linux-nat.c
5162         (hppa_linux_nat_target::fetch_inferior_registers): Rename to
5163         hppa_linux_nat_target::fetch_registers.
5164
5165 2018-06-11  Alan Hayward  <alan.hayward@arm.com>
5166
5167         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Add mappings.
5168         * aarch64-tdep.h (AARCH64_DWARF_SVE_VG): Add define.
5169         (AARCH64_DWARF_SVE_FFR): Likewise.
5170         (AARCH64_DWARF_SVE_P0): Likewise.
5171         (AARCH64_DWARF_SVE_Z0): Likewise.
5172
5173 2018-06-11  Alan Hayward  <alan.hayward@arm.com>
5174
5175         * common/common-regcache.h (raw_compare): New function.
5176         * regcache.c (regcache::raw_compare): Likewise.
5177         * regcache.h (regcache::raw_compare): New declaration.
5178
5179 2018-06-11  Alan Hayward  <alan.hayward@arm.com>
5180
5181         * common/common-regcache.h (reg_buffer_common): New structure.
5182         * regcache.c (reg_buffer::invalidate): Move from detached_regcache.
5183         (reg_buffer::raw_supply): Likewise.
5184         (reg_buffer::raw_supply_integer): Likewise.
5185         (reg_buffer::raw_supply_zeroed): Likewise.
5186         (reg_buffer::raw_collect): Likewise.
5187         (reg_buffer::raw_collect_integer): Likewise.
5188         * regcache.h (reg_buffer::invalidate): Move from detached_regcache.
5189         (reg_buffer::raw_supply): Likewise.
5190         (reg_buffer::raw_supply_integer): Likewise.
5191         (reg_buffer::raw_supply_zeroed): Likewise.
5192         (reg_buffer::raw_collect): Likewise.
5193         (reg_buffer::raw_collect_integer): Likewise.
5194
5195 2018-06-10  Tom Tromey  <tom@tromey.com>
5196
5197         * remote.c (stop_reply_p): Remove typedef.  Don't declare queue.
5198         (class remote_state) <stop_reply_queue>: Now std::vector.
5199         (remote_state::~remote_state)
5200         (remote_target::stop_reply_queue_length): Update.
5201         (struct queue_iter_param, remove_child_of_pending_fork)
5202         (struct check_pending_event_prevents_wildcard_vcont_callback_data)
5203         (check_pending_event_prevents_wildcard_vcont_callback)
5204         (remove_stop_reply_for_inferior)
5205         (remove_stop_reply_of_remote_state)
5206         (remote_notif_remove_once_on_match)
5207         (stop_reply_match_ptid_and_ws)
5208         (remote_kill_child_of_pending_fork): Remove.
5209         (remote_target::remove_new_fork_children)
5210         (remote_target::check_pending_events_prevent_wildcard_vcont)
5211         (remote_target::discard_pending_stop_replies)
5212         (remote_target::discard_pending_stop_replies_in_queue)
5213         (remote_target::remote_notif_remove_queued_reply)
5214         (remote_target::queued_stop_reply)
5215         (remote_target::push_stop_reply, remote_target::peek_stop_reply)
5216         (remote_target::wait, remote_target::kill_new_fork_children)
5217         (remote_target::async): Update.
5218
5219 2018-06-10  Tom Tromey  <tom@tromey.com>
5220
5221         * record-full.c (record_full_arch_list_cleanups): Remove.
5222         (record_full_message): Use try/catch.
5223         (record_full_wait_cleanups): Remove.
5224         (record_full_wait_1): Use try/catch.
5225         (record_full_restore): Likewise.
5226
5227 2018-06-10  Tom Tromey  <tom@tromey.com>
5228
5229         * record-full.c (record_full_breakpoint_p): Remove typedef.  Don't
5230         declare VEC.  Add constructor.
5231         <in_target_beneath>: Now bool.
5232         (record_full_breakpoints): Now a std::vector, static.
5233         (record_full_sync_record_breakpoints)
5234         (record_full_init_record_breakpoints)
5235         (record_full_target::insert_breakpoint)
5236         (record_full_target::remove_breakpoint): Update.  Don't use XNEW.
5237
5238 2018-06-10  Simon Marchi  <simon.marchi@polymtl.ca>
5239
5240         * dwarf2read.c (process_cu_includes): Remove struct keyword.
5241         * serial.c (serial_interface_lookup): Remove struct keyword.
5242
5243 2018-06-10  Tom Tromey  <tom@tromey.com>
5244
5245         * procfs.c (procfs_target::xfer_partial): Use "beneath" as a
5246         method.
5247         * nto-procfs.c (nto_procfs_target::xfer_partial): Use "beneath" as
5248         a method.
5249         * go32-nat.c (go32_nat_target::xfer_partial): Use "beneath" as a
5250         method.
5251         * arm-linux-nat.c (arm_linux_nat_target::read_description): Use
5252         "beneath" as a method.
5253         * arm-fbsd-nat.c (arm_fbsd_nat_target::read_description):
5254         Use "beneath" as a method.
5255
5256 2018-06-10  Tom Tromey  <tom@tromey.com>
5257
5258         * tracefile.c (struct trace_file_writer_deleter): New.
5259         <operator()>: Rename from trace_file_writer_xfree.
5260         (trace_file_writer_up): New typedef.
5261         (tsave_command, trace_save_tfile, trace_save_ctf): Update.
5262
5263 2018-06-09  Simon Marchi  <simon.marchi@ericsson.com>
5264
5265         * regcache.h (reg_buffer) <~reg_buffer>: Use default destructor.
5266         <m_registers, m_register_status>: Change type to
5267         std::unique_ptr.
5268         * regcache.c (reg_buffer::reg_buffer): Use new instead of
5269         XCNEWVEC.
5270
5271 2018-06-09  Simon Marchi  <simon.marchi@ericsson.com>
5272
5273         * common/common-regcache.h (enum register_status): Add
5274         underlying type "signed char".
5275         * regcache.h (reg_buffer) <m_register_status>: Change type to
5276         register_status *.
5277         * regcache.c (reg_buffer::reg_buffer): Alocate arrays of
5278         register_status instead of signed char.
5279         (reg_buffer::save): Use REG_UNKNOWN instead of 0.
5280         (reg_buffer::get_register_status): Remove cast.
5281         (readable_regcache::raw_read): Remove cast.
5282         (readable_regcache::cooked_read): Remove cast.
5283
5284 2018-06-09  Tom Tromey  <tom@tromey.com>
5285
5286         * source.c (reverse_search_command, forward_search_command): Use
5287         scoped_fd.
5288
5289 2018-06-09  Tom Tromey  <tom@tromey.com>
5290
5291         * serial.c (serial_ops_p): Remove typedef.  Don't declare VEC.
5292         (serial_ops_list): Now static, std::vector.
5293         (serial_interface_lookup, serial_add_interface): Update.
5294
5295 2018-06-09  Tom Tromey  <tom@tromey.com>
5296
5297         * dwarf2read.c (process_cu_includes): Update.
5298         (process_full_comp_unit): Update.
5299         * dwarf2read.h (struct dwarf2_per_objfile) <just_read_cus>: Now a
5300         std::vector.
5301
5302 2018-06-08  Paul Koning  <paul_koning@dell.com>
5303
5304         PR gdb/23252
5305
5306         * python/python.c (do_start_initialization):
5307         Avoid call to internal Python API.
5308         (init__gdb_module): New function.
5309
5310 2018-06-08  Gary Benson <gbenson@redhat.com>
5311
5312         * linux-thread-db.c (valprint.h): New include.
5313         (struct check_thread_db_info): New structure.
5314         (check_thread_db_on_load, tdb_testinfo): New static globals.
5315         (check_thread_db, check_thread_db_callback): New functions.
5316         (try_thread_db_load_1): Run integrity checks if requested.
5317         (maintenance_check_libthread_db): New function.
5318         (_initialize_thread_db): Register "maint check libthread-db"
5319         and "maint set/show check-libthread-db".
5320         * NEWS: Mention the above new commands.
5321
5322 2018-06-08  Tom Tromey  <tom@tromey.com>
5323
5324         * windows-nat.c (windows_nat_target::xfer_partial): "beneath" is
5325         now a method.
5326
5327 2018-06-08  Tom Tromey  <tom@tromey.com>
5328
5329         * btrace.c (parse_xml_raw): Use gdb::unique_xmalloc_ptr.
5330
5331 2018-06-08  Tom Tromey  <tom@tromey.com>
5332
5333         * common/btrace-common.h (struct btrace_data): Add constructor,
5334         destructor, move assignment operator.
5335         <empty, clear, fini>: New methods.
5336         <format>: Initialize.
5337         (btrace_data_init, btrace_data_fini, btrace_data_clear)
5338         (btrace_data_empty): Don't declare.
5339         * common/btrace-common.c (btrace_data_init): Remove.
5340         (btrace_data::fini): Rename from btrace_data_fini.
5341         (btrace_data::empty): Rename from btrace_data_empty.
5342         (btrace_data::clear): Rename from btrace_data_clear.  Return
5343         bool.
5344         * btrace.h (make_cleanup_btrace_data): Don't declare.
5345         * btrace.c (btrace_add_pc, btrace_stitch_trace, btrace_clear)
5346         (parse_xml_btrace): Update.
5347         (do_btrace_data_cleanup, make_cleanup_btrace_data): Remove.
5348         (maint_btrace_clear_packet_history_cmd): Update.
5349
5350 2018-06-07  Pedro Alves  <palves@redhat.com>
5351
5352         * target.h (target_ops) <beneath>: Now a method.  All references
5353         updated.
5354         (class target_stack): New.
5355         * target.c (g_target_stack): New.
5356         (g_current_top_target): Delete.
5357         (current_top_target): Get the top target out of g_target_stack.
5358         (target_stack::push, target_stack::unpush): New.
5359         (push_target, unpush_target): Reimplement.
5360         (target_is_pushed): Reimplement in terms of g_target_stack.
5361         (target_ops::beneath, target_stack::find_beneath): New.
5362
5363 2018-06-07  Pedro Alves  <palves@redhat.com>
5364
5365         * target.h (find_target_beneath): Delete declaration.
5366         * target.c (find_target_beneath): Delete definition.
5367         * aix-thread.c: All callers of find_target_beneath adjusted to
5368         call target_ops::beneath instead.
5369         * bsd-uthread.c: Likewise.
5370         * linux-thread-db.c: Likewise.
5371         * ravenscar-thread.c: Likewise.
5372         * sol-thread.c: Likewise.
5373         * spu-multiarch.c: Likewise.
5374
5375 2018-06-07  Pedro Alves  <palves@redhat.com>
5376
5377         * target.h (target_ops) <beneath>: Now a method.  All references
5378         updated.
5379         (target_ops) <m_beneath>: New.
5380         * target.c (target_ops::beneath): New.
5381         * corelow.c: Adjust all references to target_ops::beneath.
5382         * linux-thread-db.c: Likewise.
5383         * make-target-delegates: Likewise.
5384         * record-btrace.c: Likewise.
5385         * record-full.c: Likewise.
5386         * remote.c: Likewise.
5387         * target.c: Likewise.
5388         * target-delegates.c: Regenerate.
5389
5390 2018-06-07  Pedro Alves  <palves@redhat.com>
5391
5392         * target.h (target_stack): Delete.
5393         (current_top_target): Declare function.
5394         * target.c (target_stack): Delete.
5395         (g_current_top_target): New.
5396         (current_top_target): New function.
5397         * auxv.c: Use current_top_target instead of target_stack
5398         throughout.
5399         * avr-tdep.c: Likewise.
5400         * breakpoint.c: Likewise.
5401         * corefile.c: Likewise.
5402         * elfread.c: Likewise.
5403         * eval.c: Likewise.
5404         * exceptions.c: Likewise.
5405         * frame.c: Likewise.
5406         * gdbarch-selftests.c: Likewise.
5407         * gnu-v3-abi.c: Likewise.
5408         * ia64-tdep.c: Likewise.
5409         * ia64-vms-tdep.c: Likewise.
5410         * infcall.c: Likewise.
5411         * infcmd.c: Likewise.
5412         * infrun.c: Likewise.
5413         * linespec.c: Likewise.
5414         * linux-tdep.c: Likewise.
5415         * minsyms.c: Likewise.
5416         * ppc-linux-nat.c: Likewise.
5417         * ppc-linux-tdep.c: Likewise.
5418         * procfs.c: Likewise.
5419         * regcache.c: Likewise.
5420         * remote.c: Likewise.
5421         * rs6000-tdep.c: Likewise.
5422         * s390-linux-nat.c: Likewise.
5423         * s390-tdep.c: Likewise.
5424         * solib-aix.c: Likewise.
5425         * solib-darwin.c: Likewise.
5426         * solib-dsbt.c: Likewise.
5427         * solib-spu.c: Likewise.
5428         * solib-svr4.c: Likewise.
5429         * solib-target.c: Likewise.
5430         * sparc-tdep.c: Likewise.
5431         * sparc64-tdep.c: Likewise.
5432         * spu-tdep.c: Likewise.
5433         * symfile.c: Likewise.
5434         * symtab.c: Likewise.
5435         * target-descriptions.c: Likewise.
5436         * target-memory.c: Likewise.
5437         * target.c: Likewise.
5438         * target.h: Likewise.
5439         * tracefile-tfile.c: Likewise.
5440         * tracepoint.c: Likewise.
5441         * valops.c: Likewise.
5442         * valprint.c: Likewise.
5443         * value.c: Likewise.
5444         * windows-tdep.c: Likewise.
5445         * mi/mi-main.c: Likewise.
5446
5447 2018-06-07  Tom Tromey  <tom@tromey.com>
5448
5449         * valprint.h (build_address_symbolic): Declare.
5450         * printcmd.c (print_address_symbolic): Update.
5451         (build_address_symbolic): Change "name" and "filename" to
5452         std::string.
5453         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5454         Update.
5455         * defs.h (build_address_symbolic): Remove declaration.
5456
5457 2018-06-07  Alan Hayward  <alan.hayward@arm.com>
5458
5459         * aarch64-tdep.c (AARCH64_SVE_V0_REGNUM): Add define.
5460         (aarch64_vnv_type): Add function.
5461         (aarch64_pseudo_register_name): Add V regs for SVE.
5462         (aarch64_pseudo_register_type): Likewise.
5463         (aarch64_pseudo_register_reggroup_p): Likewise.
5464         (aarch64_pseudo_read_value_2): Use V0 offset for SVE
5465         (aarch64_pseudo_read_value): Add V regs for SVE.
5466         (aarch64_pseudo_write_2): Use V0 offset for SVE
5467         (aarch64_pseudo_write): Add V regs for SVE.
5468         * aarch64-tdep.h (struct gdbarch_tdep): Add vnv_type.
5469
5470 2018-06-06  Sergio Durigan Junior  <sergiodj@redhat.com>
5471
5472         * arch/aarch64.h (sve_vq_from_vl): Guard with #ifndef.
5473         (sve_vl_from_vq): Likewise.
5474
5475 2018-06-05  Tom Tromey  <tom@tromey.com>
5476
5477         * cli/cli-cmds.c (show_version): Update.
5478         * top.c (print_gdb_version): Add "interactive" parameter.
5479         Update.
5480         * main.c (captured_main_1): Update.
5481         * top.h (print_gdb_version): Add "interactive" parameter and a
5482         comment.
5483
5484 2018-06-05  David Malcolm  <dmalcolm@redhat.com>
5485
5486         * common/enum-flags.h: Add trailing semicolon to example in
5487         comment.
5488
5489 2018-06-05  Tom Tromey  <tom@tromey.com>
5490
5491         PR cli/12326:
5492         * NEWS: Add entry about pager.
5493         * utils.c (pagination_disabled_for_command): New global.
5494         (prompt_for_continue): Allow "c" response to prompt.
5495         (reinitialize_more_filter): Clear
5496         pagination_disabled_for_command.
5497         (fputs_maybe_filtered): Check pagination_disabled_for_command.
5498
5499 2018-06-04  Tom Tromey  <tom@tromey.com>
5500
5501         * ada-lang.h (ada_lookup_symbol_list): Update.
5502         * ada-lang.c (resolve_subexp): Update.
5503         (symbols_are_identical_enums): Change type of syms.  Remove nsyms
5504         parameter.
5505         (remove_extra_symbols, remove_irrelevant_renamings): Likewise.
5506         (ada_lookup_symbol_list_worker, ada_lookup_symbol_list): Change
5507         results parameter to std::vector.
5508         (ada_iterate_over_symbols, ada_lookup_symbol, get_var_value):
5509         Update.
5510         * ada-exp.y (block_lookup): Update.
5511         (select_possible_type_sym): Change type of syms.  Remove nsyms
5512         parameter.
5513         (write_var_or_type, write_name_assoc): Update.
5514
5515 2018-06-04  Joel Brobecker  <brobecker@adacore.com>
5516
5517         * windows-nat.c (windows_nat_target::xfer_partial): Return
5518         TARGET_XFER_E_IO if we need to delegate to the target beneath
5519         but BENEATH is NULL.
5520
5521 2018-06-04  Simon Marchi  <simon.marchi@ericsson.com>
5522
5523         * Makefile.in (config.status): Add configure.nat as a
5524         dependency.
5525
5526 2018-06-04  Tom Tromey  <tom@tromey.com>
5527
5528         * cp-name-parser.y (cpname_state): Add method declarations.
5529         (HANDLE_QUAL): Update.
5530         (cpname_state::d_grab, cpname_state::fill_comp)
5531         (cpname_state::make_operator, cpname_state::make_dtor)
5532         (cpname_state::make_builtin_type, cpname_state::make_name)
5533         (cpname_state::d_qualify, cpname_state::d_int_type)
5534         (cpname_state::d_unary, cpname_state::d_binary): Now methods.
5535         (%union): Move earlier.
5536
5537 2018-06-04  Alan Hayward  <alan.hayward@arm.com>
5538
5539         * elfread.c (elf_symfile_segments): Use ELF_SECTION_IN_SEGMENT.
5540
5541 2018-06-04  Alan Hayward  <alan.hayward@arm.com>
5542
5543         * aarch64-tdep.c (aarch64_pseudo_read_value_1): New helper func.
5544         (aarch64_pseudo_write_1): Likewise.
5545         (aarch64_pseudo_read_value): Use helper.
5546         (aarch64_pseudo_write): Likewise.
5547
5548 2018-06-04  Pedro Alves  <palves@redhat.com>
5549
5550         * darwin-nat.c (darwin_ops): Delete.
5551         (darwin_attach_pid): Use get_native_target.
5552
5553 2018-06-04  Alan Hayward  <alan.hayward@arm.com>
5554
5555         * aarch64-tdep.c (aarch64_get_tdesc_vq): Use uint64_t for VQ.
5556         * aarch64-tdep.h (struct gdbarch_tdep): Likewise.
5557
5558 2018-06-04  Alan Hayward  <alan.hayward@arm.com>
5559
5560         * aarch64-linux-nat.c (aarch64_linux_read_description): Support SVE.
5561         * aarch64-tdep.c (aarch64_get_tdesc_vq): New function.
5562         (aarch64_gdbarch_init): Check for SVE.
5563         * aarch64-tdep.h (gdbarch_tdep::has_sve): New function.
5564
5565 2018-06-04  Alan Hayward  <alan.hayward@arm.com>
5566
5567         * aarch64-tdep.c (aarch64_read_description): Use uint64_t for VQ.
5568         * aarch64-tdep.h (aarch64_read_description): Likewise.
5569         * arch/aarch64.c (aarch64_create_target_description): Likewise.
5570         * arch/aarch64.h (aarch64_create_target_description): Likewise.
5571         * features/aarch64-sve.c (create_feature_aarch64_sve): Likewise.
5572         * nat/aarch64-sve-linux-ptrace.c(aarch64_sve_get_vq): Likewise.
5573         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_get_vq): Likewise.
5574
5575 2018-06-02  Simon Marchi  <simon.marchi@ericsson.com>
5576
5577         * value.c (value_fetch_lazy_bitfield): New.
5578         (value_fetch_lazy_memory): New.
5579         (value_fetch_lazy_register): New.
5580         (value_fetch_lazy): Factor out to smaller functions.
5581
5582 2018-06-01  Tom Tromey  <tom@tromey.com>
5583
5584         * cp-name-parser.y (backslashable, represented): Now const.
5585
5586 2018-06-01  Tom Tromey  <tom@tromey.com>
5587
5588         * cp-name-parser.y: Include parser-defs.h.
5589         (parser_fprintf): Remove declaration.
5590
5591 2018-06-01  Tom Tromey  <tom@tromey.com>
5592
5593         * cp-name-parser.y: Use %pure-parser, %lex-param, and
5594         %parse-param.
5595         (lexptr, prev_lexptr, error_lexptr, global_errmsg, demangle_info)
5596         (global_result): Remove globals.
5597         (struct cpname_state): New.
5598         (yyparse): Don't declare.
5599         (yylex, yyerror): Move declarations after %union.
5600         (d_grab, fill_comp, make_operator, make_dtor, make_builtin_type)
5601         (make_name): Add state parameter.
5602         Update all callers.
5603         (d_qualify, d_int_type, d_unary, d_binary, parse_number) Add state
5604         parameter.
5605         (HANDLE_QUAL, HANDLE_SPECIAL, HANDLE_TOKEN2, HANDLE_TOKEN3):
5606         Update.
5607         (yylex): Add lvalp, state parameters.
5608         (yyerror): Add state parameter.
5609         (cp_demangled_name_to_comp): Update.
5610
5611 2018-06-01  Tom Tromey  <tom@tromey.com>
5612
5613         * cp-name-parser.y (parser_fprintf): Declare.
5614         (GDB_YY_REMAP_PREFIX): Define.
5615         Include yy-remap.h.  Don't redefine yy* identifiers.
5616
5617 2018-06-01  Tom Tromey  <tom@tromey.com>
5618
5619         * python/py-type.c (typy_legacy_template_argument): Update.
5620         * cp-support.h (cp_demangled_name_to_comp): Update.
5621         * cp-name-parser.y (cp_demangled_name_to_comp): Change errmsg
5622         parameter to be a "std::string *".
5623         (main): Update.
5624
5625 2018-06-01  H.J. Lu  <hongjiu.lu@intel.com>
5626
5627         * ada-lex.l: Include "diagnostics.h" instead of
5628         "common/diagnostics.h".
5629         * unittests/environ-selftests.c: Likewise.
5630         * common/diagnostics.h: Moved to ../include.
5631
5632 2018-06-01  Joel Brobecker  <brobecker@adacore.com>
5633
5634         * breakpoint.c (breakpoint_re_set): Temporarily force language_mode
5635         to language_mode_manual while calling breakpoint_re_set_one.
5636
5637 2018-06-01  Tom Tromey  <tom@tromey.com>
5638
5639         * valops.c (value_cast_structs, destructor_name_p): Update.
5640         * symtab.c (gdb_mangle_name): Update.
5641         * stabsread.c (define_symbol, read_cpp_abbrev, read_baseclasses):
5642         Update.
5643         * p-valprint.c (pascal_object_is_vtbl_ptr_type)
5644         (pascal_object_print_value_fields, pascal_object_print_value):
5645         Update.
5646         * p-typeprint.c (pascal_type_print_derivation_info): Update.
5647         * linespec.c (find_methods): Update.
5648         * gdbtypes.h (type_name_no_tag): Remove.
5649         (type_name_or_error): Rename from type_name_no_tag_or_error.
5650         * gdbtypes.c (type_name_no_tag): Remove.
5651         (type_name_or_error): Rename from type_name_no_tag_or_error.
5652         (lookup_struct_elt_type, check_typedef): Update.
5653         * expprint.c (print_subexp_standard): Update.
5654         * dwarf2read.c (dwarf2_add_field, load_partial_dies): Update.
5655         * d-namespace.c (d_lookup_nested_symbol): Update.
5656         * cp-valprint.c (cp_is_vtbl_ptr_type, cp_print_value_fields)
5657         (cp_print_class_member): Update.
5658         * cp-namespace.c (cp_lookup_nested_symbol): Update.
5659         * completer.c (add_struct_fields): Update.
5660         * c-typeprint.c (cp_type_print_derivation_info)
5661         (c_type_print_varspec_prefix, c_type_print_base_struct_union):
5662         Update.
5663         * ada-lang.c (parse_old_style_renaming, xget_renaming_scope)
5664         (ada_prefer_type, ada_is_exception_sym): Update.
5665
5666 2018-06-01  Tom Tromey  <tom@tromey.com>
5667
5668         * valops.c (enum_constant_from_type, value_namespace_elt)
5669         (value_maybe_namespace_elt): Update.
5670         * valarith.c (find_size_for_pointer_math): Update.
5671         * target-descriptions.c (make_gdb_type): Update.
5672         * symmisc.c (print_symbol): Update.
5673         * stabsread.c (define_symbol, read_type)
5674         (complain_about_struct_wipeout, add_undefined_type)
5675         (cleanup_undefined_types_1): Update.
5676         * rust-lang.c (rust_tuple_type_p, rust_slice_type_p)
5677         (rust_range_type_p, val_print_struct, rust_print_struct_def)
5678         (rust_internal_print_type, rust_composite_type)
5679         (rust_evaluate_funcall, rust_evaluate_subexp)
5680         (rust_inclusive_range_type_p): Update.
5681         * python/py-type.c (typy_get_tag): Update.
5682         * p-typeprint.c (pascal_type_print_base): Update.
5683         * mdebugread.c (parse_symbol, parse_type): Update.
5684         * m2-typeprint.c (m2_long_set, m2_record_fields, m2_enum):
5685         Update.
5686         * guile/scm-type.c (gdbscm_type_tag): Update.
5687         * go-lang.c (sixg_string_p): Update.
5688         * gnu-v3-abi.c (build_gdb_vtable_type, build_std_type_info_type):
5689         Update.
5690         * gdbtypes.h (struct main_type) <tag_name>: Remove.
5691         (TYPE_TAG_NAME): Remove.
5692         * gdbtypes.c (type_name_no_tag): Simplify.
5693         (check_typedef, check_types_equal, recursive_dump_type)
5694         (copy_type_recursive, arch_composite_type): Update.
5695         * f-typeprint.c (f_type_print_base): Update.  Print "Type" prefix
5696         in summary mode when needed.
5697         * eval.c (evaluate_funcall): Update.
5698         * dwarf2read.c (fixup_go_packaging, read_structure_type)
5699         (process_structure_scope, read_enumeration_type)
5700         (read_namespace_type, read_module_type, determine_prefix): Update.
5701         * cp-support.c (inspect_type): Update.
5702         * coffread.c (process_coff_symbol, decode_base_type): Update.
5703         * c-varobj.c (c_is_path_expr_parent): Update.
5704         * c-typeprint.c (c_type_print_base_struct_union): Update.
5705         (c_type_print_base_1): Update.  Print struct/class/union/enum in
5706         summary when using C language.
5707         * ax-gdb.c (gen_struct_ref, gen_namespace_elt)
5708         (gen_maybe_namespace_elt): Update.
5709         * ada-lang.c (ada_type_name): Simplify.
5710         (empty_record, ada_template_to_fixed_record_type_1)
5711         (template_to_static_fixed_type)
5712         (to_record_with_fixed_variant_part, ada_check_typedef): Update.
5713
5714 2018-06-01  Tom Tromey  <tom@tromey.com>
5715
5716         * dwarf2read.c (dwarf2_compute_name): Pass CU's language to
5717         c_print_type.
5718         * c-typeprint.c (c_print_type_1): Add "language" parameter.
5719         (c_print_type): Update.
5720         (c_print_type): New overload.
5721         (c_type_print_varspec_prefix, c_type_print_args)
5722         (c_type_print_varspec_suffix, c_print_type_no_offsets)
5723         (c_type_print_base_struct_union, c_type_print_base_1)
5724         (cp_type_print_method_args): Add "language" parameter.
5725         (c_type_print_base): Update.
5726         * c-lang.h (c_print_type): Add new overload.
5727
5728 2018-06-01  Tom Tromey  <tom@tromey.com>
5729
5730         * typeprint.h (c_type_print_varspec_suffix): Don't declare.
5731         * c-typeprint.c (c_type_print_varspec_suffix): Now static.
5732
5733 2018-06-01  Alan Hayward  <alan.hayward@arm.com>
5734
5735         * aarch64-tdep.c (aarch64_sve_register_names): New const
5736         var.
5737         * arch/aarch64.h (enum aarch64_regnum): Add SVE entries.
5738         (AARCH64_SVE_Z_REGS_NUM): New define.
5739         (AARCH64_SVE_P_REGS_NUM): Likewise.
5740         (AARCH64_SVE_NUM_REGS): Likewise.
5741
5742 2018-05-31  Uros Bizjak  <ubizjak@gmail.com>
5743
5744         * nat/linux-ptrace.h [__alpha__]
5745         (GDB_ARCH_IS_TRAP_BRKPT, GDB_ARCH_IS_TRAP_HWBKPT): Remove
5746         definitions.
5747
5748 2018-05-31  Maciej W. Rozycki  <macro@mips.com>
5749
5750         * arch-utils.c (gdbarch_info_fill): Set `default_byte_order' to
5751         the endianness selected.
5752         * NEWS: Document `set endian auto' mode operation update.
5753
5754 2018-05-31  Alan Hayward  <alan.hayward@arm.com>
5755
5756         * Makefile.in: Add new header.
5757         * gdb/arch/aarch64.h (sve_vg_from_vl): New macro.
5758         (sve_vl_from_vg): Likewise.
5759         (sve_vq_from_vl): Likewise.
5760         (sve_vl_from_vq): Likewise.
5761         (sve_vq_from_vg): Likewise.
5762         (sve_vg_from_vq): Likewise.
5763         * configure.nat: Add new c file.
5764         * nat/aarch64-sve-linux-ptrace.c: New file.
5765         * nat/aarch64-sve-linux-ptrace.h: New file.
5766
5767 2018-05-31  Alan Hayward  <alan.hayward@arm.com>
5768
5769         * aarch64-linux-nat.c (aarch64_linux_read_description):
5770         Add parmeter zero.
5771         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
5772         Likewise.
5773         * aarch64-tdep.c (tdesc_aarch64_list): Add.
5774         (aarch64_read_description): Use VQ to index tdesc_aarch64_list.
5775         (aarch64_gdbarch_init): Add parmeter zero.
5776         * aarch64-tdep.h (aarch64_read_description): Add VQ parmeter.
5777         * arch/aarch64.c (aarch64_create_target_description): Check VQ.
5778         * arch/aarch64.h (aarch64_create_target_description): Add VQ.
5779         parmeter.
5780         * doc/gdb.texinfo: Describe SVE feature
5781         * features/aarch64-sve.c: New file.
5782
5783 2018-05-31  Omair Javaid  <omair.javaid@linaro.org>
5784
5785         PR gdb/23210
5786         * gdbarch.sh (significant_addr_bit): Default to zero when
5787         not set by target architecture.
5788         * gdbarch.c: Re-generated.
5789         * utils.c (address_significant): Update.
5790
5791 2018-05-30  Joel Brobecker  <brobecker@adacore.com>
5792
5793         * stack.c (func_command): Remove trailing newline in call to error.
5794
5795 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
5796
5797         * regcache.h (regcache_raw_collect): Remove, update callers to
5798         use regcache::raw_collect.
5799         * regcache.c (regcache_raw_collect): Remove.
5800
5801 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
5802
5803         * regcache.h (regcache_raw_supply): Remove, update callers to
5804         use detached_regcache::raw_supply.
5805         * regcache.c (regcache_raw_supply): Remove.
5806
5807 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
5808
5809         * regcache.h (regcache_cooked_write_part): Remove, update
5810         callers to use regcache::cooked_write_part.
5811         * regcache.c (regcache_cooked_write_part): Remove.
5812
5813 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
5814
5815         * regcache.h (regcache_cooked_read_part): Remove, update callers
5816         to use readable_regcache::cooked_read_part.
5817         * regcache.c (regcache_cooked_read_part): Remove.
5818
5819 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
5820
5821         * regcache.h (regcache_cooked_read_value): Remove, update
5822         callers to use readable_regcache::cooked_read_value.
5823         * regcache.c (regcache_cooked_read_value): Remove.
5824
5825 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
5826
5827         * regcache.h (regcache_cooked_write): Remove, update callers to
5828         use regcache::cooked_write.
5829         * regcache.c (regcache_cooked_write): Remove.
5830
5831 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
5832
5833         * regcache.h (regcache_invalidate): Remove, update callers to
5834         use detached_regcache::invalidate instead.
5835         * regcache.c (regcache_invalidate): Remove.
5836
5837 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
5838
5839         * regcache.h (regcache_raw_write_part): Remove, update callers
5840         to use regcache::raw_write_part instead.
5841         * regcache.c (regcache_raw_write_part): Remove.
5842
5843 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
5844
5845         * regcache.h (regcache_raw_read_part): Remove, update callers to
5846         use readable_regcache::raw_read_part instead.
5847         * regcache.c (regcache_raw_read_part): Remove.
5848
5849 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
5850
5851         * regcache.h (regcache_cooked_read): Remove, update callers to
5852         use readable_regcache::cooked_read instead.
5853         * regcache.c (regcache_cooked_read): Remove.
5854
5855 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
5856
5857         * regcache.h (regcache_raw_write): Remove, update callers to use
5858         regcache::raw_write instead.
5859         * regcache.c (regcache_raw_write): Remove.
5860
5861 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
5862
5863         * regcache.h (regcache_raw_read): Remove, update callers to use
5864         readable_regcache::raw_read instead.
5865         * regcache.c (regcache_raw_read): Remove.
5866
5867 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
5868
5869         * regcache.h (regcache_raw_update): Remove, update callers to
5870         use readable_regcache::raw_update instead.
5871         * regcache.c (regcache_raw_update): Remove.
5872
5873 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
5874
5875         * regcache.h (regcache_register_status): Remove, update callers
5876         to use reg_buffer::get_register_status directly instead.
5877         * regcache.c (regcache_register_status): Remove.
5878
5879 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
5880
5881         * regcache.h (regcache_get_ptid): Remove, update all callers to
5882         call regcache::ptid instead.
5883         * regcache.c (regcache_get_ptid): Remove.
5884
5885 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
5886
5887         * Makefile.in (ALL_TARGET_OBS): Add or1k-tdep.o.
5888
5889 2018-05-30  Pedro Alves  <palves@redhat.com>
5890
5891         * common/common-exceptions.h (exception_rethrow): Use
5892         ATTRIBUTE_NORETURN.
5893
5894 2018-05-29  Simon Marchi  <simon.marchi@polymtl.ca>
5895
5896         * breakpoint.c (print_solib_event, check_status_catch_solib):
5897         Remove struct keyword in range-based for loops.
5898         * dbxread.c (find_corresponding_bincl_psymtab): Likewise.
5899         * dwarf2read.c (compute_delayed_physnames, rust_union_quirks);
5900         Likewise.
5901         * linespec.c (find_superclass_methods, search_minsyms_for_name):
5902         Likewise.
5903         * symfile.c (addr_info_make_relative): Likewise.
5904         * thread.c (value_in_thread_stack_temporaries): Likewise.
5905
5906 2018-06-12  Weimin Pan  <weimin.pan@oracle.com>
5907
5908         PR gdb/16841
5909         * valops.c (value_struct_elt_for_reference): Call check_typedef on
5910         aggregate type to get its real type before accessing it.
5911
5912 2018-05-29  Weimin Pan  <weimin.pan@oracle.com>
5913
5914         * minsyms.h (lookup_minimal_symbol_and_objfile): Remove declaration.
5915         * minsyms.c (lookup_minimal_symbol_and_objfile): Remove definition.
5916         * coff-pe-read.c (add_pe_forwarded_sym): Replace
5917         lookup_minimal_symbol_and_objfile with lookup_bound_minimal_symbol.
5918         * glibc-tdep.c (glibc_skip_solib_resolver): Likewise.
5919         * jit.c (jit_breakpoint_re_set_internal): Likewise.
5920         * printcmd.c (info_address_command): Likewise.
5921
5922 2018-05-29  Tom Tromey  <tom@tromey.com>
5923
5924         * windows-nat.c (handle_exception): Update fall-through comment.
5925
5926 2018-05-29  Tom Tromey  <tom@tromey.com>
5927
5928         * progspace.h (so_list_ptr): Remove typedef.  Don't declare VEC.
5929         (struct program_space) <added_solibs>: Now a std::vector.
5930         * breakpoint.c (print_solib_event): Update.
5931         (check_status_catch_solib): Update.
5932         * progspace.c (clear_program_space_solib_cache): Update.
5933         * solib.c (update_solib_list): Update.
5934
5935 2018-05-29  Tom Tromey  <tom@tromey.com>
5936
5937         * python/py-type.c (typy_richcompare): Update.
5938         * guile/scm-type.c (tyscm_equal_p_type_smob): Update.
5939         * gdbtypes.h (types_deeply_equal): Return bool.
5940         (types_equal): Likewise.
5941         * gdbtypes.c (type_equality_entry_d): Remove typedef.  Don't
5942         declare VEC.
5943         (check_types_equal): Change worklist to std::vector.  Return
5944         bool.
5945         (struct type_equality_entry): Add constructor.
5946         (compare_maybe_null_strings): Return bool.
5947         (check_types_worklist): Return bool.  Change worklist to
5948         std::vector.
5949         (types_deeply_equal): Use std::vector.
5950         (types_equal): Return bool.
5951         (compare_maybe_null_strings): Simplify.
5952
5953 2018-05-29  Tom Tromey  <tom@tromey.com>
5954
5955         * record-btrace.c (tp_t): Remove typedef.  Don't declare VEC.
5956
5957 2018-05-29  Tom Tromey  <tom@tromey.com>
5958
5959         * objc-lang.h: Don't include cp-support.h.
5960         * common/gdb_vecs.h (const_char_ptr): Remove typedef.  Don't
5961         declare VEC.
5962
5963 2018-05-27  Tom Tromey  <tom@tromey.com>
5964
5965         * Makefile.in (DEPFILES): Don't reference REMOTE_OBS.
5966
5967 2018-05-25  Tom Tromey  <tom@tromey.com>
5968
5969         * value.c (value::location): Initialize.
5970
5971 2018-05-25  Tom Tromey  <tom@tromey.com>
5972
5973         * dbxread.c (init_bincl_list): Remove.
5974         (bincl_list): Now a std::vector.
5975         (bincls_allocated, next_bincl): Remove.
5976         (free_bincl_list, do_free_bincl_list_cleanup)
5977         (make_cleanup_free_bincl_list): Remove.
5978         (dbx_read_symtab, elfstab_build_psymtabs): Use scoped_restore,
5979         unique_xmalloc_ptr.
5980         (find_corresponding_bincl_psymtab, read_dbx_symtab): Update.
5981         (struct header_file_location): Add constructor.
5982         (add_bincl_to_list): Remove.
5983
5984 2018-05-25  Tom Tromey  <tom@tromey.com>
5985
5986         * tui/tui.c (tui_enable): Update.
5987         * mi/mi-interp.c (mi_interp::init): Update.
5988         * interps.h (class interp) <name>: New method.
5989         <m_name>: Rename from name.
5990         (~scoped_restore_interp): Update.
5991         * interps.c (interp::interp): Update.
5992         (interp_add, interp_set, interp_lookup_existing)
5993         (current_interp_named_p): Update.
5994
5995 2018-05-25  Tom Tromey  <tom@tromey.com>
5996
5997         * interps.c (interp_name): Remove.
5998         * mi/mi-interp.c (mi_interp::init): Update.
5999         * interps.h (interp_name): Remove.
6000         (~scoped_restore_interp): Update.
6001         * tui/tui.c (tui_enable): Update.
6002
6003 2018-05-25  Tom Tromey  <tom@tromey.com>
6004
6005         * utils.c (fputs_maybe_filtered): Update.
6006         * linespec.c (decode_line_full): Update.
6007         * mi/mi-interp.c (mi_on_normal_stop_1, mi_tsv_modified)
6008         (mi_print_breakpoint_for_event, mi_solib_loaded)
6009         (mi_solib_unloaded, mi_command_param_changed, mi_memory_changed)
6010         (mi_user_selected_context_changed): Update.
6011         * mi/mi-main.c (mi_execute_command): Update.
6012         * cli/cli-script.c (execute_control_command): Update.
6013         * python/python.c (execute_gdb_command): Update.
6014         * solib.c (info_sharedlibrary_command): Update.
6015         * interps.c (interp_ui_out): Remove.
6016         * interps.h (interp_ui_out): Remove.
6017
6018 2018-05-25  Tom Tromey  <tom@tromey.com>
6019
6020         * tui/tui-interp.c (as_tui_interp): Use dynamic_cast.
6021         * mi/mi-interp.c (as_mi_interp): Use dynamic_cast.
6022         * cli/cli-interp.c (as_cli_interp): Use dynamic_cast.
6023
6024 2018-05-25  Tom Tromey  <tom@tromey.com>
6025
6026         * cli/cli-interp.c (safe_execute_command): Use scoped_restore.
6027         * interps.c (interp_exec): Use scoped_restore.
6028
6029 2018-05-25  Tom Tromey  <tom@tromey.com>
6030
6031         * remote.c (remote_target::remote_file_get): Use
6032         gdb::byte_vector.
6033         (remote_target::remote_file_put): Likewise.
6034
6035 2018-05-25  Tom Tromey  <tom@tromey.com>
6036
6037         * coff-pe-read.c (struct read_pe_section_data) <section_name>: Now
6038         a std::string.
6039         (get_pe_section_index, add_pe_exported_sym): Update.
6040         (read_pe_exported_syms): Use gdb::def_vector.
6041
6042 2018-05-25  Tom Tromey  <tom@tromey.com>
6043
6044         * frame.c (remove_prev_frame): Remove.
6045         (get_prev_frame_if_no_cycle): Use TRY/CATCH.
6046
6047 2018-05-25  Maciej W. Rozycki  <macro@mips.com>
6048
6049         * mips-linux-tdep.h (mips_supply_fpregset, mips_fill_fpregset):
6050         Remove prototypes.
6051         * mips-linux-nat.c (supply_fpregset): Always call
6052         `mips64_supply_fpregset' rather than `mips_supply_fpregset'.
6053         (fill_fpregset): Always call `mips64_fill_fpregset' rather than
6054         `mips_fill_fpregset'.
6055         * mips-linux-tdep.c (mips_supply_fpregset)
6056         (mips_supply_fpregset_wrapper, mips_fill_fpregset)
6057         (mips_fill_fpregset_wrapper): Remove functions.
6058         (mips64_supply_fpregset, mips64_fill_fpregset): Update comments.
6059         (mips_linux_fpregset): Remove variable.
6060         (mips_linux_iterate_over_regset_sections): Use
6061         `mips64_linux_fpregset' in place of `mips_linux_fpregset'.
6062         (mips_linux_o32_sigframe_init): Remove comment.
6063
6064 2018-05-25  Pedro Alves  <palves@redhat.com>
6065
6066         * remote.c (struct vCont_action_support, MAXTHREADLISTRESULTS)
6067         (struct readahead_cache, struct packet_reg, struct
6068         remote_arch_state, class remote_state): Move higher up in the
6069         file.
6070         (remote_target::m_remote_state): Now an object instead of a pointer.
6071         (remote_target::get_remote_state): Adjust.
6072
6073 2018-05-24  Andrew Burgess  <andrew.burgess@embecosm.com>
6074
6075         * stack.c (select_and_print_frame): Delete.
6076         (struct function_bounds): Move struct within function.
6077         (func_command): Most content moved into new function
6078         find_frame_for_function, use new function, print result, add
6079         function comment.
6080         (find_frame_for_function): New function, now returns a result.
6081
6082 2018-05-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6083
6084         * stack.c (iterate_over_block_arg_vars): Fix comment.
6085         (print_frame_arg_vars): Pass stream in cb_data, not gdb_stdout.
6086
6087 2018-05-24  Andrew Burgess  <andrew.burgess@embecosm.com>
6088
6089         PR gdb/23203
6090         * frame.c
6091         (scoped_restore_selected_frame::scoped_restore_selected_frame):
6092         Define.
6093         (scoped_restore_selected_frame::~scoped_restore_selected_frame):
6094         Define.
6095         * frame.h (class scoped_restore_selected_frame): New class.
6096         * stack.c (print_frame_local_vars): Remove catching and rethrowing
6097         of any exception, use scoped_restore_selected_frame to restore the
6098         frame instead.
6099
6100 2018-05-24  Pedro Alves  <palves@redhat.com>
6101
6102         * darwin-nat.h (darwin_nat_target::create_inferior): Mark with
6103         override.
6104
6105 2018-05-23  Tom Tromey  <tom@tromey.com>
6106
6107         * complaints.c (struct complaints): Remove.
6108         (symfile_complaint_book): Remove.
6109         (series): New global.
6110         (complaint_internal): Update.
6111         (clear_complaints): Update.
6112
6113 2018-05-23  Tom Tromey  <tom@tromey.com>
6114
6115         * complaints.c (counters): New global.
6116         (struct complain): Remove.
6117         (struct complaints) <root>: Remove.
6118         (complaint_sentinel): Remove.
6119         (symfile_complaint_book): Update.
6120         (find_complaint) Remove.
6121         (complaint_internal, clear_complaints): Update.
6122
6123 2018-05-23  Tom Tromey  <tom@tromey.com>
6124
6125         * complaints.c (struct complain) <file, line>: Remove.
6126         (find_complaint): Remove file, line parameters.
6127         (complaint_internal): Update.
6128
6129 2018-05-23  Tom Tromey  <tom@tromey.com>
6130
6131         * complaints.c (vcomplaint): Remove.
6132         (complaint_internal) Merge in contents of vcomplaint.
6133
6134 2018-05-23  Tom Tromey  <tom@tromey.com>
6135
6136         * complaints.c (struct complaints) <explanation>: Remove.
6137         (symfile_explanations): Remove.
6138         (symfile_complaint_book): Update.
6139         (vcomplaint): Update.
6140         (struct explanation): Remove.
6141
6142 2018-05-23  Tom Tromey  <tom@tromey.com>
6143
6144         * complaints.c (symfile_complaints): Remove.
6145         (complaint_internal): Remove "complaints" parameter.
6146         (clear_complaints, vcomplaint): Remove "c" parameter.
6147         (get_complaints): Remove.
6148         * dwarf2read.c (dwarf2_statement_list_fits_in_line_number_section_complaint)
6149         (dwarf2_debug_line_missing_file_complaint)
6150         (dwarf2_debug_line_missing_end_sequence_complaint)
6151         (dwarf2_complex_location_expr_complaint)
6152         (dwarf2_const_value_length_mismatch_complaint)
6153         (dwarf2_section_buffer_overflow_complaint)
6154         (dwarf2_macro_malformed_definition_complaint)
6155         (dwarf2_invalid_attrib_class_complaint)
6156         (create_addrmap_from_index, dw2_symtab_iter_next)
6157         (dw2_expand_marked_cus)
6158         (dw2_debug_names_iterator::find_vec_in_debug_names)
6159         (dw2_debug_names_iterator::next, dw2_debug_names_iterator::next)
6160         (create_debug_type_hash_table, init_cutu_and_read_dies)
6161         (partial_die_parent_scope, add_partial_enumeration)
6162         (skip_one_die, fixup_go_packaging, quirk_rust_enum, process_die)
6163         (dwarf2_compute_name, dwarf2_physname, read_namespace_alias)
6164         (read_import_statement, read_file_scope, create_dwo_cu_reader)
6165         (create_cus_hash_table, create_dwp_hash_table)
6166         (inherit_abstract_dies, read_func_scope, read_call_site_scope)
6167         (dwarf2_rnglists_process, dwarf2_ranges_process)
6168         (dwarf2_add_type_defn, dwarf2_attach_fields_to_type)
6169         (dwarf2_add_member_fn, get_alignment, maybe_set_alignment)
6170         (handle_struct_member_die, process_structure_scope)
6171         (read_array_type, read_common_block, read_module_type)
6172         (read_tag_pointer_type, read_typedef, read_base_type)
6173         (read_subrange_type, load_partial_dies, partial_die_info::read)
6174         (partial_die_info::read, partial_die_info::read)
6175         (partial_die_info::read, read_checked_initial_length_and_offset)
6176         (dwarf2_string_attr, read_formatted_entries)
6177         (dwarf_decode_line_header)
6178         (lnp_state_machine::check_line_address, dwarf_decode_lines_1)
6179         (new_symbol, dwarf2_const_value_attr, lookup_die_type)
6180         (read_type_die_1, determine_prefix, dwarf2_get_ref_die_offset)
6181         (dwarf2_get_attr_constant_value, dwarf2_fetch_constant_bytes)
6182         (get_signatured_type, get_DW_AT_signature_type)
6183         (decode_locdesc, file_file_name, consume_improper_spaces)
6184         (skip_form_bytes, skip_unknown_opcode, dwarf_parse_macro_header)
6185         (dwarf_decode_macro_bytes, dwarf_decode_macros)
6186         (dwarf2_symbol_mark_computed, set_die_type)
6187         (read_attribute_value): Update.
6188         * stap-probe.c (handle_stap_probe, get_stap_base_address):
6189         Update.
6190         * dbxread.c (unknown_symtype_complaint)
6191         (lbrac_mismatch_complaint, repeated_header_complaint)
6192         (set_namestring, function_outside_compilation_unit_complaint)
6193         (read_dbx_symtab, process_one_symbol): Update.
6194         * gdbtypes.c (stub_noname_complaint): Update.
6195         * windows-nat.c (handle_unload_dll): Update.
6196         * coffread.c (coff_symtab_read, enter_linenos, decode_type)
6197         (decode_base_type): Update.
6198         * xcoffread.c (bf_notfound_complaint, ef_complaint)
6199         (eb_complaint, record_include_begin, record_include_end)
6200         (enter_line_range, xcoff_next_symbol_text, read_xcoff_symtab)
6201         (process_xcoff_symbol, read_symbol)
6202         (function_outside_compilation_unit_complaint)
6203         (scan_xcoff_symtab): Update.
6204         * machoread.c (macho_symtab_read, macho_add_oso_symfile): Update.
6205         * buildsym.c (finish_block_internal, make_blockvector)
6206         (end_symtab_get_static_block, augment_type_symtab): Update.
6207         * dtrace-probe.c (dtrace_process_dof)
6208         (dtrace_static_probe_ops::get_probes): Update.
6209         * complaints.h (struct complaint): Don't declare.
6210         (symfile_complaints): Remove.
6211         (complaint_internal): Remove "complaints" parameter.
6212         (complaint): Likewise.
6213         (clear_complaints): Likewise.
6214         * symfile.c (syms_from_objfile_1, finish_new_objfile)
6215         (reread_symbols): Update.
6216         * dwarf2-frame.c (dwarf2_restore_rule, execute_cfa_program)
6217         (dwarf2_frame_cache, decode_frame_entry): Update.
6218         * dwarf2loc.c (dwarf_reg_to_regnum): Update.
6219         * objc-lang.c (lookup_objc_class, lookup_child_selector)
6220         (info_selectors_command): Update.
6221         * macrotab.c (macro_include, check_for_redefinition)
6222         (macro_undef): Update.
6223         * objfiles.c (filter_overlapping_sections): Update.
6224         * stabsread.c (invalid_cpp_abbrev_complaint)
6225         (reg_value_complaint, stabs_general_complaint, dbx_lookup_type)
6226         (define_symbol, error_type, read_type, rs6000_builtin_type)
6227         (stabs_method_name_from_physname, read_member_functions)
6228         (read_cpp_abbrev, read_baseclasses, read_tilde_fields)
6229         (attach_fields_to_type, complain_about_struct_wipeout)
6230         (read_range_type, read_args, common_block_start)
6231         (common_block_end, cleanup_undefined_types_1, scan_file_globals):
6232         Update.
6233         * mdebugread.c (index_complaint, unknown_ext_complaint)
6234         (basic_type_complaint, bad_tag_guess_complaint)
6235         (bad_rfd_entry_complaint, unexpected_type_code_complaint)
6236         (reg_value_complaint, parse_symbol, parse_type, upgrade_type)
6237         (parse_procedure, parse_lines)
6238         (function_outside_compilation_unit_complaint)
6239         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref)
6240         (bad_tag_guess_complaint, reg_value_complaint): Update.
6241         * cp-support.c (demangled_name_complaint): Update.
6242         * macroscope.c (sal_macro_scope): Update.
6243         * dwarf-index-write.c (class debug_names): Update.
6244
6245 2018-05-23  Tom Tromey  <tom@tromey.com>
6246
6247         * complaints.c (clear_complaints): Remove "noisy" parameter.
6248         * complaints.h (clear_complaints): Update.
6249         * symfile.c (syms_from_objfile_1, finish_new_objfile)
6250         (reread_symbols): Update.
6251
6252 2018-05-23  Tom Tromey  <tom@tromey.com>
6253
6254         * complaints.c (enum complaint_series): Remove FIRST_MESSAGE,
6255         SUBSEQUENT_MESSAGE.
6256         (vcomplaint, clear_complaints): Update.
6257         (symfile_explanations): Remove some messages.
6258
6259 2018-05-23  Tom Tromey  <tom@tromey.com>
6260
6261         * complaints.c (internal_complaint): Remove.
6262         * complaints.h (internal_complaint): Remove.
6263
6264 2018-05-22  Maciej W. Rozycki  <macro@mips.com>
6265
6266         * i387-tdep.c (i387_collect_xsave): Make `i' unsigned.
6267
6268 2018-05-22  Pedro Alves  <palves@redhat.com>
6269
6270         * remote-fileio.c (remote_fileio_reply, remote_fileio_ioerror)
6271         (remote_fileio_badfd, remote_fileio_return_errno)
6272         (remote_fileio_return_success, remote_fileio_func_open)
6273         (remote_fileio_func_open, remote_fileio_func_close)
6274         (remote_fileio_func_read, remote_fileio_func_write)
6275         (remote_fileio_func_lseek, remote_fileio_func_rename)
6276         (remote_fileio_func_unlink, remote_fileio_func_stat)
6277         (remote_fileio_func_fstat, remote_fileio_func_gettimeofday)
6278         (remote_fileio_func_isatty, remote_fileio_func_system): Add
6279         remote_target parameter.
6280         (remote_fio_func_map) <func>: Add remote_target parameter.
6281         (do_remote_fileio_request, remote_fileio_request):
6282         * remote-fileio.h (remote_fileio_request):
6283         * remote-notif.c (remote_notif_ack, remote_notif_parse, ): Add
6284         remote_target parameter.
6285         (remote_notif_process, handle_notification): Adjust to pass down
6286         the remote.
6287         (remote_notif_state_allocate): Add remote_target parameter.  Save
6288         it.
6289         * remote-notif.h (struct remote_target): Forward declare.
6290         (struct notif_client) <parse, ack, can_get_pending_events>: Add
6291         remote_target parameter.
6292         (struct remote_notif_state) <remote>: New field.
6293         (remote_notif_ack, remote_notif_parse): Add remote_target
6294         parameter.
6295         (remote_notif_state_allocate, remote_notif_state_allocate): Add
6296         remote_target parameter.
6297         * remote.c (OPAQUETHREADBYTES, threadref, gdb_ext_thread_info)
6298         (threads_listing_context, rmt_thread_action, protocol_feature)
6299         (packet_reg, stop_reply, stop_reply_p, enum packet_support)
6300         (packet_result, struct threads_listing_context, remote_state):
6301         Move definitions and declarations higher up.
6302         (remote_target) <~remote_target>: Declare.
6303         (remote_download_command_source, remote_file_put, remote_file_get)
6304         (remote_file_delete, remote_hostio_pread, remote_hostio_pwrite)
6305         (remote_hostio_pread_vFile, remote_hostio_send_command)
6306         (remote_hostio_set_filesystem, remote_hostio_open)
6307         (remote_hostio_close, remote_hostio_unlink, remote_state)
6308         (get_remote_state, get_remote_packet_size, get_memory_packet_size)
6309         (get_memory_write_packet_size, get_memory_read_packet_size)
6310         (append_pending_thread_resumptions, remote_detach_1)
6311         (append_resumption, remote_resume_with_vcont)
6312         (add_current_inferior_and_thread, wait_ns, wait_as)
6313         (process_stop_reply, remote_notice_new_inferior)
6314         (process_initial_stop_replies, remote_add_thread)
6315         (btrace_sync_conf, remote_btrace_maybe_reopen)
6316         (remove_new_fork_children, kill_new_fork_children)
6317         (discard_pending_stop_replies, stop_reply_queue_length)
6318         (check_pending_events_prevent_wildcard_vcont)
6319         (discard_pending_stop_replies_in_queue, stop_reply)
6320         (remote_notif_remove_queued_reply, stop_reply *queued_stop_reply)
6321         (peek_stop_reply, remote_parse_stop_reply, remote_stop_ns)
6322         (remote_interrupt_as, remote_interrupt_ns)
6323         (remote_get_noisy_reply, remote_query_attached)
6324         (remote_add_inferior, remote_current_thread, get_current_thread)
6325         (set_thread, set_general_thread, set_continue_thread)
6326         (set_general_process, write_ptid)
6327         (remote_unpack_thread_info_response, remote_get_threadinfo)
6328         (parse_threadlist_response, remote_get_threadlist)
6329         (remote_threadlist_iterator, remote_get_threads_with_ql)
6330         (remote_get_threads_with_qxfer)
6331         (remote_get_threads_with_qthreadinfo, extended_remote_restart)
6332         (get_offsets, remote_check_symbols, remote_supported_packet)
6333         (remote_query_supported, remote_packet_size)
6334         (remote_serial_quit_handler, remote_detach_pid)
6335         (remote_vcont_probe, remote_resume_with_hc)
6336         (send_interrupt_sequence, interrupt_query)
6337         (remote_notif_get_pending_events, fetch_register_using_p)
6338         (send_g_packet, process_g_packet, fetch_registers_using_g)
6339         (store_register_using_P, store_registers_using_G)
6340         (set_remote_traceframe, check_binary_download)
6341         (remote_write_bytes_aux, remote_write_bytes, remote_read_bytes_1)
6342         (remote_xfer_live_readonly_partial, remote_read_bytes)
6343         (remote_send_printf, remote_flash_write, readchar)
6344         (remote_serial_write, putpkt, putpkt_binary, skip_frame)
6345         (read_frame, getpkt, getpkt_or_notif_sane_1, getpkt_sane)
6346         (getpkt_or_notif_sane, remote_vkill, remote_kill_k)
6347         (extended_remote_disable_randomization, extended_remote_run)
6348         (send_environment_packet, extended_remote_environment_support)
6349         (extended_remote_set_inferior_cwd, remote_write_qxfer)
6350         (remote_read_qxfer, push_stop_reply, vcont_r_supported)
6351         (packet_command): Now methods of ...
6352         (remote_target): ... this class.
6353         (m_remote_state) <remote_target>: New field.
6354         (struct remote_state) <stop_reply_queue,
6355         remote_async_inferior_event_token, wait_forever_enabled_p>: New
6356         fields.
6357         (remote_state::remote_state): Allocate stop_reply_queue.
6358         (remote_state): Delete global.
6359         (get_remote_state_raw): Delete.
6360         (remote_target::get_remote_state): Allocate m_remote_state on
6361         demand.
6362         (get_current_remote_target): New.
6363         (remote_ops, extended_remote_ops): Delete.
6364         (wait_forever_enabled_p, remote_async_inferior_event_token):
6365         Delete, moved to struct remote_state.
6366         (remote_target::close): Delete self.  Destruction bits split to
6367         ...
6368         (remote_target::~remote_target): ... this.
6369         (show_memory_packet_size): Adjust to use
6370         get_current_remote_target.
6371         (struct protocol_feature) <func>: Add remote_target parameter.
6372         All callers adjusted.
6373         (curr_quit_handler_target): New.
6374         (remote_serial_quit_handler): Reimplement.
6375         (remote_target::open_1): Adjust to use get_current_remote_target.
6376         Heap-allocate remote_target/extended_remote_target instances.
6377         (vcont_builder::vcont_builder): Add remote_target parameter, and
6378         save it in m_remote.  All callers adjusted.
6379         (vcont_builder::m_remote): New field.
6380         (vcont_builder::restart, vcont_builder::flush)
6381         (vcont_builder::push_action): Use it.
6382         (remote_target::commit_resume): Use it.
6383         (struct queue_iter_param) <remote>: New field.
6384         (remote_target::remove_new_fork_children): Fill in 'remote' field.
6385         (check_pending_event_prevents_wildcard_vcont_callback_data): New.
6386         (check_pending_event_prevents_wildcard_vcont_callback)
6387         (remote_target::check_pending_events_prevent_wildcard_vcont)
6388         (remote_target::discard_pending_stop_replies)
6389         (remote_target::discard_pending_stop_replies_in_queue)
6390         (remote_target::remote_notif_remove_queued_reply): Fill in
6391         'remote' field.
6392         (remote_notif_get_pending_events): New.
6393         (remote_target::readchar, remote_target::remote_serial_write):
6394         Save/restore curr_quit_handler_target.
6395         (putpkt): New.
6396         (kill_new_fork_children): Fill in 'remote' field.
6397         (packet_command): Use get_current_remote_target, defer to
6398         remote_target method of same name.
6399         (scoped_remote_fd::scoped_remote_fd): Add 'remote_target'
6400         parameter, and save it in m_remote.  All callers adjusted.
6401         (scoped_remote_fd::release): Use m_remote.
6402         (scoped_remote_fd::m_remote): New field.
6403         (remote_file_put, remote_file_get, remote_file_delete): Use
6404         get_current_remote_target, defer to remote_target method of same
6405         name.
6406         (remote_btrace_reset): Add remote_state paremeter.  Update all
6407         callers.
6408         (remote_async_inferior_event_handler). Pass down 'data'.
6409         (remote_new_objfile): Use get_current_remote_target.
6410         (remote_target::vcont_r_supported): New.
6411         (set_range_stepping): Use get_current_remote_target and
6412         remote_target::vcont_r_supported.
6413         (_initialize_remote): Don't allocate 'remote_state' and
6414         'stop_reply_queue' globals.
6415         * remote.h (struct remote_target): Forward declare.
6416         (getpkt, putpkt, remote_notif_get_pending_events): Add
6417         'remote_target' parameter.
6418
6419 2018-05-22  Pedro Alves  <palves@redhat.com>
6420
6421         * remote.c (vcont_builder): Now a class.  Make all data members
6422         private.
6423         (vcont_builder) <vcont_builder, restart, flush, push_action>:
6424         Declare methods.
6425         (vcont_builder_restart): Rename to ...
6426         (vcont_builder::restart): ... this.
6427         (vcont_builder_flush): Rename to ...
6428         (vcont_builder::flush): ... this.
6429         (vcont_builder_push_action): Rename to ...
6430         (vcont_builder::push_action): ... this.
6431         (remote_target::commit_resume): Adjust.
6432
6433 2018-05-22  Pedro Alves  <palves@redhat.com>
6434
6435         * remote.c (DEFAULT_MAX_MEMORY_PACKET_SIZE): Rename to ...
6436         (DEFAULT_MAX_MEMORY_PACKET_SIZE_FIXED): ... this.
6437         (get_fixed_memory_packet_size): New.
6438         (get_memory_packet_size): Use it.
6439         (set_memory_packet_size): Don't override the config size with
6440         DEFAULT_MAX_MEMORY_PACKET_SIZE.
6441         (show_memory_packet_size): Use get_fixed_memory_packet_size.
6442         Don't refer to get_memory_packet_size if not connected to a remote
6443         target.  Show "(default)" if configured size is 0.
6444
6445 2018-05-22  Pedro Alves  <palves@redhat.com>
6446
6447         * remote.c (remote_target::mourn_inferior): Move
6448         discard_pending_stop_replies call here from ...
6449         (_initialize_remote): ... here.
6450
6451 2018-05-22  Pedro Alves  <palves@redhat.com>
6452
6453         * remote.c (compare_section_command): Remove set_general_process
6454         call.
6455
6456 2018-05-22  Pedro Alves  <palves@redhat.com>
6457
6458         * remote.c (struct packet_reg, struct remote_arch_state):
6459         Move higher up in the file.
6460         (remote_state) <m_arch_states>: Store remote_arch_state values
6461         instead of remote_arch_state pointers.
6462         (remote_state::get_remote_arch_state): Adjust.
6463
6464 2018-05-22  Pedro Alves  <palves@redhat.com>
6465
6466         * remote.c: Include <unordered_map>.
6467         (remote_state): Now a class.
6468         (remote_state) <get_remote_arch_state>: Declare method.
6469         <get_remote_arch_state>: New field.
6470         (remote_arch_state) <remote_arch_state>: Declare ctor.
6471         <regs>: Now a unique_ptr.
6472         (remote_gdbarch_data_handle): Delete.
6473         (get_remote_arch_state): Delete.
6474         (remote_state::get_remote_arch_state): New.
6475         (get_remote_state): Adjust to call remote_state's
6476         get_remote_arch_state method.
6477         (init_remote_state): Delete, bits factored out to ...
6478         (remote_arch_state::remote_arch_state): ... this new method.
6479         (get_remote_packet_size, get_memory_packet_size)
6480         (process_g_packet, remote_target::fetch_registers)
6481         (remote_target::prepare_to_store, store_registers_using_G)
6482         (remote_target::store_registers, remote_target::get_trace_status):
6483         Adjust to call remote_state's method.
6484         (_initialize_remote): Remove reference to
6485         remote_gdbarch_data_handle.
6486
6487 2018-05-22  Pedro Alves  <palves@redhat.com>
6488
6489         * remote.c (struct readahead_cache) <invalidate, invalidate_fd,
6490         pread>: New method declarations.
6491         (remote_target::open_1): Adjust.
6492         (readahead_cache_invalidate): Rename to ...
6493         (readahead_cache::invalidate): ... this, and adjust to be a class
6494         method.
6495         (readahead_cache_invalidate_fd): Rename to ...
6496         (readahead_cache::invalidate_fd): ... this, and adjust to be a
6497         class method.
6498         (remote_hostio_pwrite): Adjust.
6499         (remote_hostio_pread_from_cache): Rename to ...
6500         (readahead_cache::pread): ... this, and adjust to be a class
6501         method.
6502         (remote_hostio_close): Adjust.
6503
6504 2018-05-22  Pedro Alves  <palves@redhat.com>
6505
6506         * remote.c (remote_hostio_close_cleanup): Delete.
6507         (class scoped_remote_fd): New.
6508         (remote_file_put, remote_file_get): Use it.
6509
6510 2018-05-22  Pedro Alves  <palves@redhat.com>
6511
6512         (struct vCont_action_support): Use bool and initialize all fields.
6513         (struct readahead_cache): Initialize all fields.
6514         (remote_state): Use bool and initialize all fields.
6515         (remote_state::remote_state, remote_state::~remote_state): New.
6516         (new_remote_state): Delete.
6517         (_initialize_remote): Use new to allocate remote_state.
6518
6519 2018-05-22  Pedro Alves  <palves@redhat.com>
6520             張俊芝  <zjz@zjz.name>
6521
6522         PR gdb/22973
6523         * c-exp.y: Include "c-support.h".
6524         (parse_number, c_parse_escape, lex_one_token): Use TOLOWER instead
6525         of tolower.  Use c_ident_is_alpha to scan names.
6526         * c-lang.c: Include "c-support.h".
6527         (convert_ucn, convert_octal, convert_hex, convert_escape): Use
6528         ISXDIGIT instead of isxdigit and ISDIGIT instead of isdigit.
6529         * c-support.h: New file, with bits factored out from ...
6530         * cp-name-parser.y: ... this file.
6531         Include "c-support.h".
6532         (cp_ident_is_alpha, cp_ident_is_alnum): Deleted, moved to
6533         c-support.h and renamed.
6534         (symbol_end, yylex): Adjust.
6535
6536 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
6537
6538         * arch/ppc-linux-common.c (ppc_linux_has_isa205): Change the
6539         parameter type to CORE_ADDR.
6540         * arch/ppc-linux-common.h (ppc_linux_has_isa205): Change the
6541         parameter type in declaration to CORE_ADDR.
6542         * ppc-linux-tdep.c (ppc_linux_core_read_description): Call
6543         target_auxv_search to get AT_HWCAP and use the result to get the
6544         target description.
6545         * ppc-linux-nat.c (ppc_linux_get_hwcap): Change the return type
6546         to CORE_ADDR. Remove the cast of the return value to unsigned
6547         long. Fix error predicate of target_auxv_search.
6548         (ppc_linux_nat_target::read_description): Change the type of the
6549         hwcap variable to CORE_ADDR.
6550
6551 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
6552
6553         * rs6000-tdep.c (rs6000_gdbarch_init): Assign 1 to have_dfp only
6554         if the size of fpscr is larger than 32 bits.
6555
6556 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
6557
6558         * ppc-linux-tdep.c (ppc_linux_vsxregset): New function.
6559         (ppc32_linux_vsxregmap): New global.
6560         (ppc32_linux_vsxregset): Initialize with ppc32_linux_vsxregmap,
6561         regcache_supply_regset, and regcache_collect_regset.
6562         * ppc-linux-tdep.h (ppc_linux_vsxregset): Declare.
6563         * ppc-linux-nat.c (supply_vsxregset, fill_vsxregset): Remove.
6564         (fetch_vsx_register, store_vsx_register): Remove.
6565         (fetch_vsx_registers): Add regno parameter. Get regset using
6566         ppc_linux_vsxregset. Use regset to supply registers.
6567         (store_vsx_registers): Add regno parameter. Get regset using
6568         ppc_linux_vsxregset. Use regset to collect registers.
6569         (fetch_register): Call fetch_vsx_registers instead of
6570         fetch_vsx_register.
6571         (store_register): Call store_vsx_registers instead of
6572         store_vsx_register.
6573         (fetch_ppc_registers): Call fetch_vsx_registers with -1 for the
6574         new regno parameter.
6575         (store_ppc_registers): Call store_vsx_registers with -1 for the
6576         new regno parameter.
6577         * rs6000-tdep.c (ppc_vsx_support_p, ppc_supply_vsxreget)
6578         (ppc_collect_vsxregset): Remove.
6579
6580 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
6581
6582         * ppc-tdep.h (struct ppc_reg_offsets): Remove vector register
6583         offset fields.
6584         * ppc-fbsd-tdep.c (ppc32_fbsd_reg_offsets): Remove initializers
6585         for vector register offset fields.
6586         (ppc64_fbsd_reg_offsets): Likewise.
6587         * ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Remove assignment
6588         to vector register offset fields.
6589         * ppc-obsd-tdep.c (_initialize_ppcnbsd_tdep): Remove assignment
6590         to vector register offset fields.
6591         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Remove assignment to
6592         vector register offset fields.
6593         * rs6000-aix-tdep.c (rs6000_aix32_reg_offsets): Remove
6594         initializers for vector register offset fields.
6595         (rs6000_aix64_reg_offsets): Likewise.
6596         * rs6000-tdep.c (ppc_vrreg_offset): Remove.
6597         (ppc_supply_vrregset): Remove.
6598         (ppc_collect_vrregset): Remove.
6599         * ppc-linux-tdep.c (ppc_linux_collect_vrregset): New function.
6600         (ppc_linux_vrregset) : New function.
6601         (ppc32_le_linux_vrregmap, ppc32_be_linux_vrregmap)
6602         (ppc32_le_linux_vrregset, ppc32_be_linux_vrregset): New globals.
6603         (ppc32_linux_vrregset): Remove.
6604         (ppc_linux_iterate_over_regset_sections): Call ppc_linux_vrregset
6605         and use result instead of ppc32_linux_vrregset.
6606         (ppc32_linux_reg_offsets): Remove initializers for vector register
6607         offset fields.
6608         (ppc64_linux_reg_offsets): Likewise.
6609         * ppc-linux-tdep.h (ppc_linux_vrregset): New declaration.
6610         * ppc-linux-nat.c: Include regset.h.
6611         (gdb_vrregset_t): Adjust comment to account for little-endian
6612         mode.
6613         (supply_vrregset, fill_vrregset): Remove.
6614         (fetch_altivec_register, store_altivec_register): Remove.
6615         (fetch_altivec_registers): Add regno parameter. Get regset using
6616         ppc_linux_vrregset. Use regset to supply registers.
6617         (store_altivec_registers): Add regno parameter. Get regset using
6618         ppc_linux_vrregset. Use regset to collect registers.
6619         (fetch_register): Call fetch_altivec_registers instead of
6620         fetch_altivec_register.
6621         (store_register): Call store_altivec_registers instead of
6622         store_altivec_register.
6623         (fetch_ppc_registers): Call fetch_altivec_registers with -1 for
6624         the new regno parameter.
6625         (store_ppc_registers): Call store_altivec_registers with -1 for
6626         the new regno parameter.
6627
6628 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
6629
6630         * arch/ppc-linux-common.h (PPC_LINUX_SIZEOF_VRREGSET)
6631         (PPC_LINUX_SIZEOF_VSXREGSET): Define.
6632         * ppc-linux-nat.c (SIZEOF_VSXREGS, SIZEOF_VRREGS): Remove.
6633         (gdb_vrregset_t): Change array type size to
6634         PPC_LINUX_SIZEOF_VRREGSET.
6635         (gdb_vsxregset_t): Change array type size to
6636         PPC_LINUX_SIZEOF_VSXREGSET.
6637         * ppc-linux-tdep.c (ppc_linux_iterate_over_regset_sections):
6638         Change integer literals to PPC_LINUX_SIZEOF_VRREGSET and
6639         PPC_LINUX_SIZEOF_VSXREGSET.
6640
6641 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
6642
6643         * configure.nat <linux powerpc>: Add ppc-linux.o to NATDEPFILES.
6644         * ppc-linux-nat.c (ppc_linux_target_wordsize): Move to
6645         nat/ppc-linux.c.
6646         (ppc_linux_nat_target::auxv_parse): Get thread id tid. Call
6647         ppc_linux_target_wordsize with tid.
6648         (ppc_linux_nat_target::read_description): Call ppc_linux_target
6649         wordsize with tid.
6650         * nat/ppc-linux.c: Include nat/gdb_ptrace.h.
6651         (ppc64_64bit_inferior_p): Add static and inline specifiers.
6652         (ppc_linux_target_wordsize): Move here from ppc-linux-nat.c. Add
6653         tid parameter. Remove static specifier.
6654         * nat/ppc-linux.h (ppc64_64bit_inferior_p): Remove declaration.
6655         (ppc_linux_target_wordsize): New declaration.
6656
6657 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
6658
6659         * arch/ppc-linux-common.c: New file.
6660         * arch/ppc-linux-common.h: New file.
6661         * arch/ppc-linux-tdesc.h: New file.
6662         * configure.tgt (powerpc*-*-linux*): Add arch/ppc-linux-common.o.
6663         * Makefile.in (ALL_TARGET_OBS): Add arch/ppc-linux-common.o.
6664         (HFILES_NO_SRCDIR): Add arch/ppc-linux-common.h and
6665         arch/ppc-linux-tdesc.h.
6666         * ppc-linux-nat.c: Include arch/ppc-linux-common.h and
6667         arch/ppc-linux-tdesc.h.
6668         (ppc_linux_nat_target::read_description): Remove target
6669         description matching code. Fill a ppc_linux_features struct and
6670         call ppc_linux_match_description with it. Move comment about ISA
6671         2.05 to ppc-linux-common.c.
6672         * ppc-linux-tdep.c: Include arch/ppc-linux-common.h and
6673         arch/ppc-linux-tdesc.h.
6674         (ppc_linux_core_read_description): Remove target description
6675         matching code. Fill a ppc_linux_features struct and call
6676         ppc_linux_match_description with it.
6677         * ppc-linux-tdep.h (tdesc_powerpc_32l, tdesc_powerpc_64l)
6678         (tdesc_powerpc_altivec32l, tdesc_powerpc_altivec64l)
6679         (tdesc_powerpc_cell32l, tdesc_powerpc_cell64l)
6680         (tdesc_powerpc_vsx32l, tdesc_powerpc_vsx64l)
6681         (tdesc_powerpc_isa205_32l, tdesc_powerpc_isa205_64l)
6682         (tdesc_powerpc_isa205_altivec32l, tdesc_powerpc_isa205_altivec64l)
6683         (tdesc_powerpc_isa205_vsx32l, tdesc_powerpc_isa205_vsx64l)
6684         (tdesc_powerpc_e500l): Remove.
6685
6686 2018-05-22  Joel Brobecker  <brobecker@adacore.com>
6687
6688         * ada-lang.c (catch_assert_command): Pass empty string instead
6689         of NULL for excep_string argument.
6690
6691 2018-05-22  Maciej W. Rozycki  <macro@mips.com>
6692
6693         * mips-linux-nat.c (mips64_linux_register_addr): Return -1 if
6694         the width of the requested register exceeds the width of the
6695         `ptrace' data type.
6696
6697 2018-05-21  Tom Tromey  <tom@tromey.com>
6698
6699         * printcmd.c (output_command): Remove.
6700         (output_command_const): Rename to output_command.
6701         * valprint.h (output_command): Rename from output_command_const.
6702         * tracepoint.c (trace_dump_actions): Call output_command.
6703
6704 2018-05-21  Tom Tromey  <tom@tromey.com>
6705
6706         * mi/mi-cmd-catch.c (mi_cmd_catch_assert)
6707         (mi_cmd_catch_exception, mi_cmd_catch_handlers): Update.
6708         * ada-lang.h (create_ada_exception_catchpoint): Update.
6709         * ada-lang.c (struct ada_catchpoint) <excep_string>: Now a
6710         std::string.
6711         (create_excep_cond_exprs, ~ada_catchpoint)
6712         (should_stop_exception, print_one_exception)
6713         (print_mention_exception, print_recreate_exception): Update.
6714         (ada_get_next_arg): Remove.
6715         (catch_ada_exception_command_split): Use std::string.  Change type
6716         of "excep_string", "cond_string".
6717         (catch_ada_exception_command): Update.
6718         (create_ada_exception_catchpoint): Change type of excep_string.
6719         (ada_exception_sal): Remove excep_string parameter.
6720         (~ada_catchpoint): Remove.
6721
6722 2018-05-21  Tom Tromey  <tom@tromey.com>
6723
6724         * ada-lang.c (ada_collect_symbol_completion_matches): Remove
6725         cleanup.
6726
6727 2018-05-21  Tom Tromey  <tom@tromey.com>
6728
6729         * ada-lang.c (ada_exception_message_1, ada_exception_message):
6730         Return unique_xmalloc_ptr.
6731         (print_it_exception): Update.
6732
6733 2018-05-21  Tom Tromey  <tom@tromey.com>
6734
6735         * tracepoint.c (trace_dump_actions): Use std::string.
6736
6737 2018-05-21  Tom Tromey  <tom@tromey.com>
6738
6739         * symfile.c (reread_symbols): Use std::string for original_name.
6740
6741 2018-05-21  Tom Tromey  <tom@tromey.com>
6742
6743         * dwarf2read.c (dwarf2_read_debug_names): Use std::unique_ptr.
6744         (mapped_index_base): Use DISABLE_COPY_AND_ASSIGN.  Default
6745         constructor.
6746
6747 2018-05-20  Simon Marchi  <simon.marchi@polymtl.ca>
6748
6749         * common/traits.h (HAVE_IS_TRIVIALLY_COPYABLE): Rename the wrong
6750         instance to...
6751         (HAVE_IS_TRIVIALLY_CONSTRUCTIBLE): ... this.
6752         * objfiles.c (get_objfile_bfd_data): Allocate
6753         objfile_per_bfd_storage with obstack_new when allocating on
6754         obstack.
6755
6756 2018-05-20  Simon Marchi  <simon.marchi@ericsson.com>
6757
6758         * ada-lang.c (cache_symbol): Use XOBNEW and/or XOBNEWVEC and/or
6759         OBSTACK_ZALLOC.
6760         * dwarf2-frame.c (dwarf2_build_frame_info): Likewise.
6761         * hppa-tdep.c (hppa_init_objfile_priv_data): Likewise.
6762         * mdebugread.c (mdebug_build_psymtabs): Likewise.
6763         (add_pending): Likewise.
6764         (parse_symbol): Likewise.
6765         (parse_partial_symbols): Likewise.
6766         (psymtab_to_symtab_1): Likewise.
6767         (new_psymtab): Likewise.
6768         (elfmdebug_build_psymtabs): Likewise.
6769         * minsyms.c (terminate_minimal_symbol_table): Likewise.
6770         * objfiles.c (get_objfile_bfd_data): Likewise.
6771         (objfile_register_static_link): Likewise.
6772         * psymtab.c (allocate_psymtab): Likewise.
6773         * stabsread.c (read_member_functions): Likewise.
6774         * xcoffread.c (xcoff_end_psymtab): Likewise.
6775
6776 2018-05-20  Simon Marchi  <simon.marchi@ericsson.com>
6777
6778         * common/traits.h (HAVE_IS_TRIVIALLY_COPYABLE): Define if
6779         compiler supports std::is_trivially_constructible.
6780         * common/poison.h: Include obstack.h.
6781         (IsMallocable): Define to is_trivially_constructible if the
6782         compiler supports it, define to true_type otherwise.
6783         (xobnew): New.
6784         (XOBNEW): Redefine.
6785         (xobnewvec): New.
6786         (XOBNEWVEC): Redefine.
6787         * gdb_obstack.h (obstack_zalloc): New.
6788         (OBSTACK_ZALLOC): Redefine.
6789         (obstack_calloc): New.
6790         (OBSTACK_CALLOC): Redefine.
6791         (obstack_new): New.
6792         * gdbarch.sh: Include gdb_obstack in gdbarch.h.
6793         (gdbarch_obstack): New declaration in gdbarch.h, definition in
6794         gdbarch.c.
6795         (GDBARCH_OBSTACK_CALLOC, GDBARCH_OBSTACK_ZALLOC): Use
6796         obstack_calloc/obstack_zalloc.
6797         (gdbarch_obstack_zalloc): Remove.
6798         * target-descriptions.c (tdesc_data_init): Use obstack_new.
6799
6800 2018-05-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6801
6802         * stack.c (backtrace_command_1): Remove useless variable int i.
6803
6804 2018-05-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6805
6806         * stack.c (print_frame_info): Fix comment.
6807
6808 2018-05-18  Tom Tromey  <tom@tromey.com>
6809
6810         * dwarf2read.c (struct dwz_file): Add constructor, initializers.
6811         <dwz_bfd>: Now a gdb_bfd_ref_ptr.
6812         (~dwarf2_per_objfile): Update
6813         (dwarf2_get_dwz_file): Use new.
6814         * dwarf2read.h (struct dwarf2_per_objfile) <dwz_file>: Now a
6815         unique_ptr.
6816
6817 2018-05-18  Tom Tromey  <tom@tromey.com>
6818
6819         * dwarf2read.h (struct dwarf2_per_objfile) <dwp_file>: Now a
6820         unique_ptr.
6821         * dwarf2read.c (struct dwp_file): Add constructor and
6822         initializers.
6823         (open_and_init_dwp_file): Return a unique_ptr.
6824         (dwarf2_per_objfile, create_dwp_hash_table)
6825         (create_dwo_unit_in_dwp_v1, create_dwo_unit_in_dwp_v2)
6826         (lookup_dwo_unit_in_dwp): Update.
6827         (open_and_init_dwp_file, get_dwp_file): Update.
6828
6829 2018-05-18  Tom Tromey  <tom@tromey.com>
6830
6831         * dwarf2read.c (dwarf2_per_objfile): Update.
6832         (struct mapped_index): Add initializers.
6833         (dwarf2_read_index): Use new.
6834         (dw2_symtab_iter_init): Update.
6835         * dwarf2read.h (struct dwarf2_per_objfile) <index_table>: Now a
6836         unique_ptr.
6837
6838 2018-05-18  Simon Marchi  <simon.marchi@ericsson.com>
6839
6840         * dwarf2read.c (mapped_index) <total_size>: Remove.
6841
6842 2018-05-18  Simon Marchi  <simon.marchi@ericsson.com>
6843
6844         * unittests/format_pieces-selftests.c (test_format_specifier):
6845         Add ARI comments.
6846
6847 2018-05-18  Tom Tromey  <tom@tromey.com>
6848
6849         * c-typeprint.c (maybe_print_hole): New function.
6850         (c_print_type_struct_field_offset): Update.
6851         (c_type_print_base_struct_union): Call maybe_print_hole.
6852
6853 2018-05-17  Keith Seitz  <keiths@redhat.com>
6854
6855         * breakpoint.c (build_bpstat_chain): New function, moved from
6856         bpstat_stop_status.
6857         (bpstat_stop_status): Add optional parameter, `stop_chain'.
6858         If no stop chain is passed, call build_bpstat_chain to build it.
6859         * breakpoint.h (build_bpstat_chain): Declare.
6860         (bpstat_stop_status): Move documentation here from breakpoint.c.
6861         * infrun.c (handle_signal_stop): Before eliding inlined frames,
6862         build the stop chain and pass it to skip_inline_frames.
6863         Pass this stop chain to bpstat_stop_status.
6864         * inline-frame.c: Include breakpoint.h.
6865         (stopped_by_user_bp_inline_frame): New function.
6866         (skip_inline_frames): Add parameter `stop_chain'.
6867         Move documention to inline-frame.h.
6868         If non-NULL, use stopped_by_user_bp_inline_frame to determine
6869         whether the frame should be elided.
6870         * inline-frame.h (skip_inline_frames): Add parameter `stop_chain'.
6871         Add moved documentation and update for new parameter.
6872
6873 2018-05-17  Simon Marchi  <simon.marchi@ericsson.com>
6874
6875         PR cli/14975
6876         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6877         unittests/format_pieces-selftests.c.
6878         * common/format.h (format_piece) <operator==>: New.
6879         (format_pieces) <operator[]>: Remove.
6880         * common/format.c (format_pieces::format_pieces): Handle \e.
6881         * unittests/format_pieces-selftests.c: New.
6882
6883 2018-05-17  Tom Tromey  <tom@tromey.com>
6884
6885         PR symtab/23010:
6886         * dwarf2read.c (load_cu, dw2_do_instantiate_symtab)
6887         (dw2_instantiate_symtab): Add skip_partial parameter.
6888         (dw2_find_last_source_symtab, dw2_map_expand_apply)
6889         (dw2_lookup_symbol, dw2_expand_symtabs_for_function)
6890         (dw2_expand_all_symtabs, dw2_expand_symtabs_with_fullname)
6891         (dw2_expand_symtabs_matching_one)
6892         (dw2_find_pc_sect_compunit_symtab)
6893         (dw2_debug_names_lookup_symbol)
6894         (dw2_debug_names_expand_symtabs_for_function): Update.
6895         (init_cutu_and_read_dies): Add skip_partial parameter.
6896         (process_psymtab_comp_unit, build_type_psymtabs_1)
6897         (process_skeletonless_type_unit, load_partial_comp_unit)
6898         (psymtab_to_symtab_1): Update.
6899         (load_full_comp_unit): Add skip_partial parameter.
6900         (process_imported_unit_die, dwarf2_read_addr_index)
6901         (follow_die_offset, dwarf2_fetch_die_loc_sect_off)
6902         (dwarf2_fetch_constant_bytes, dwarf2_fetch_die_type_sect_off)
6903         (read_signatured_type): Update.
6904
6905 2018-05-17  Simon Marchi  <simon.marchi@ericsson.com>
6906
6907         * value.c (release_value): Remove unused variable.
6908         (record_latest_value): Likewise.
6909         (access_value_history): Likewise.
6910         (preserve_values): Likewise.
6911
6912 2018-05-17  Tom Tromey  <tom@tromey.com>
6913
6914         * extension.h (struct ext_lang_type_printers) <py_type_printers>:
6915         Initialize.
6916
6917 2018-05-16  Maciej W. Rozycki  <macro@mips.com>
6918
6919         PR gdb/22286
6920         * linux-nat-trad.c (linux_nat_trad_target::fetch_register):
6921         Also handle registers whose width is not a multiple of
6922         PTRACE_TYPE_RET.
6923         (linux_nat_trad_target::store_register): Likewise.
6924
6925 2018-05-16  Tom Tromey  <tom@tromey.com>
6926
6927         * gdbcore.h (core_bfd): Redefine.
6928         * corelow.c (core_target::close): Update.
6929         (core_target_open): Update.
6930         * progspace.h (struct program_space) <cbfd>: Now a
6931         gdb_bfd_ref_ptr.
6932
6933 2018-05-16  Tom Tromey  <tom@tromey.com>
6934
6935         PR cli/19551:
6936         * symfile-add-flags.h (enum symfile_add_flags)
6937         <SYMFILE_NOT_FILENAME>: New constant.
6938         * symfile.c (read_symbols): Use SYMFILE_NOT_FILENAME.  Get
6939         objfile name from BFD.
6940         (symbol_file_add_with_addrs): Check SYMFILE_NOT_FILENAME.
6941         * minidebug.c (find_separate_debug_file_in_section): Put
6942         ".gnu_debugdata" into BFD's file name.
6943
6944 2018-05-16  Simon Marchi  <simon.marchi@ericsson.com>
6945
6946         * regcache.c (regcache_read_ftype, regcache_write_ftype):
6947         Remove.
6948
6949 2018-05-15  Tamar Christina  <tamar.christina@arm.com>
6950
6951         PR binutils/21446
6952         * aarch64-tdep.c (aarch64_analyze_prologue,
6953         aarch64_software_single_step, aarch64_displaced_step_copy_insn):
6954         Indicate not interested in errors.
6955
6956 2018-05-15  Maciej W. Rozycki  <macro@mips.com>
6957
6958         * mips-linux-nat.c (mips_linux_nat_target::fetch_registers):
6959         Supply the MIPS_ZERO_REGNUM register.
6960
6961 2018-05-15  Maciej W. Rozycki  <macro@mips.com>
6962
6963         * mips-tdep.c (mask_address_var): Make variable static.
6964
6965 2018-05-14  Tom Tromey  <tom@tromey.com>
6966
6967         * dwarf2read.c (rust_union_quirks): Clear rust_unions.
6968
6969 2018-05-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6970
6971         * i387-tdep.c (i387_collect_xsave): Use FXSAVE_MXCSR_ADDR not
6972         FXSAVE_ADDR for the mxcsr register.
6973
6974 2018-05-11  Max Filippov  <jcmvbkbc@gmail.com>
6975
6976         * configure.tgt (xtensa*-*-linux*): Drop gdb_target definition.
6977
6978 2018-05-11  Pedro Alves  <palves@redhat.com>
6979
6980         * corelow.c (core_target) <core_target>: No longer inline.
6981         Initialize m_core_gdbarch, m_core_vec and build the section table
6982         here.
6983         <~core_target>: New.
6984         <core_gdbarch, get_core_register_section>: New methods.
6985         <m_core_section_table, m_core_vec, m_core_gdbarch>: New fields,
6986         factored out from ...
6987         <core_data, core_vec, core_gdbarch>: ... these deleted globals.
6988         (core_ops): Delete.
6989         (sniff_core_bfd): Add gdbarch parameter.
6990         (core_close): Delete, merged into ...
6991         (core_target::close): ... here.  Delete self.
6992         (core_close_cleanup): Delete.
6993         (core_target_open): Allocate a core_target on the heap.  Use a
6994         unique_ptr instead of a cleanup.  Bits moved into the core_target
6995         ctor.  Adjust to use core_target methods instead of globals.
6996         (get_core_register_section): Rename to ...
6997         (core_target::get_core_register_section): ... this and adjust.
6998         (struct get_core_registers_cb_data): New.
6999         (get_core_registers_cb): Use it.  Use bool.
7000         (core_target::fetch_registers, core_target::files_info)
7001         (core_target::xfer_partial, core_target::read_description)
7002         (core_target::pid_to, core_target::thread_name): Adjust to
7003         reference class fields instead of globals.
7004         * target.h (struct target_ops_deleter, target_ops_up): New.
7005
7006 2018-05-11  Pedro Alves  <palves@redhat.com>
7007
7008         * corefile.c (core_file_command): Move to corelow.c.
7009         * corelow.c (the_core_target): Delete.
7010         (core_file_command): Moved from corefile.c.  Check exec_bfd
7011         instead of the_core_target.  Use target_detach instead of calling
7012         into the_core_target directly.
7013         (maybe_say_no_core_file_now): New.
7014         (core_target::detach): Use it.
7015         (_initialize_corelow): Remove references to the_core_target.
7016         * gdbcore.h (the_core_target): Delete.
7017
7018 2018-05-11  Tom Tromey  <tromey@redhat.com>
7019             Pedro Alves  <palves@redhat.com>
7020
7021         * corefile.c (core_bfd): Remove.
7022         * gdbcore.h (core_bfd): Now a macro.
7023         * progspace.h (struct program_space) <cbfd>: New field.
7024
7025 2018-05-11  Tom Tromey  <tom@tromey.com>
7026
7027         * mdebugread.c (parse_partial_symbols, psymtab_to_symtab_1): Use
7028         gdb::def_vector.
7029
7030 2018-05-10  Tom Tromey  <tom@tromey.com>
7031
7032         * configure: Rebuild.
7033         * warning.m4 (AM_GDB_WARNINGS): Use -Wimplicit-fallthrough=3.
7034
7035 2018-05-10  Joel Brobecker  <brobecker@adacore.com>
7036
7037         PR server/23158:
7038         * regformats/regdat.sh: Adjust script, following the addition
7039         of the new expedite_regs parameter to init_target_desc.
7040
7041 2018-05-10  Omair Javaid  <omair.javaid@linaro.org>
7042
7043         PR gdb/23127
7044         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Add call to
7045         set_gdbarch_significant_addr_bit.
7046         * aarch64-tdep.c (aarch64_gdbarch_init): Remove call to
7047         set_gdbarch_significant_addr_bit.
7048         * utils.c (address_significant): Update to sign extend addr.
7049
7050 2018-05-09  Max Filippov  <jcmvbkbc@gmail.com>
7051
7052         * xtensa-linux-tdep.c (xtensa-tdep.h): New include.
7053         (xtensa_linux_init_abi): Limit tdep->num_regs by
7054         tdep->num_nopriv_regs.
7055         * xtensa-tdep.c (xtensa_derive_tdep): Calculate
7056         tdep->num_nopriv_regs and only copy it to tdep->num_regs if it's
7057         not initialized.
7058
7059 2018-05-08  Simon Marchi  <simon.marchi@ericsson.com>
7060
7061         * unittests/string_view-selftests.c: Define GNULIB_NAMESPACE.
7062
7063 2018-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7064
7065         * common/x86-xstate.h (I387_FCTRL_INIT_VAL): New constant.
7066         (I387_MXCSR_INIT_VAL): New constant.
7067         * amd64-tdep.c (amd64_supply_xsave): Only read state from xsave
7068         buffer if it was supplied by the inferior.
7069         * i387-tdep.c (i387_supply_fsave): Use I387_MXCSR_INIT_VAL.
7070         (i387_xsave_get_clear_bv): New function.
7071         (i387_supply_xsave): Only read x87 control registers from the
7072         xsave buffer if the feature is enabled, and the state will have
7073         been written, otherwise, provide a suitable default.
7074         (i387_collect_xsave): Pre-clear all registers in xsave buffer,
7075         including x87 control registers.  Update control registers if they
7076         have changed from the default value, and mark features as enabled
7077         as required.
7078         * i387-tdep.h (i387_xsave_get_clear_bv): Declare.
7079
7080 2018-05-08  Ulrich Weigand  <uweigand@de.ibm.com>
7081
7082         * spu-tdep.c (info_spu_event_command): Fix output formatting.
7083
7084 2018-05-07  Tom Tromey  <tom@tromey.com>
7085
7086         * configure: Rebuild.
7087         * warning.m4 (AM_GDB_WARNINGS): Add -Wduplicated-cond.
7088
7089 2018-05-07  Tom Tromey  <tom@tromey.com>
7090
7091         PR tdep/20362:
7092         * arm-tdep.c (arm_record_vfp_data_proc_insn): Properly mask off D
7093         bit.  Use correct value for VDIV.
7094
7095 2018-05-04  Tom Tromey  <tom@tromey.com>
7096
7097         * configure: Rebuild.
7098         * warning.m4 (AM_GDB_WARNINGS): Add -Wimplicit-fallthrough.
7099
7100 2018-05-04  Tom Tromey  <tom@tromey.com>
7101
7102         * linux-record.c (record_linux_system_call) <case
7103         RECORD_SYS_RECVFROM>: Add "break".
7104
7105 2018-05-04  Tom Tromey  <tom@tromey.com>
7106
7107         * mi/mi-main.c (mi_cmd_trace_frame_collected) <REGISTERS_FORMAT>:
7108         Add missing "break".
7109         * mi/mi-cmd-stack.c (mi_cmd_stack_list_locals) <NO_FRAME_FILTERS>:
7110         Add missing "break".
7111
7112 2018-05-04  Tom Tromey  <tom@tromey.com>
7113
7114         * rs6000-tdep.c (ppc_process_record_op4)
7115         (ppc_process_record_op63): Add fall-through comment.
7116
7117 2018-05-04  Tom Tromey  <tom@tromey.com>
7118
7119         * i386-tdep.c (i386_process_record): Add fall-through comment.
7120
7121 2018-05-04  Tom Tromey  <tom@tromey.com>
7122
7123         * stabsread.c (define_symbol) <case 'p'>: Add fall-through
7124         comment.
7125
7126 2018-05-04  Tom Tromey  <tom@tromey.com>
7127
7128         * riscv-tdep.c (riscv_isa_xlen): Add fall-through comment.
7129         * utils.c (can_dump_core) <LIMIT_CUR>: Add fall-through comment.
7130         * eval.c (fetch_subexp_value) <MEMORY_ERROR>: Add fall-through
7131         comment.
7132         * d-valprint.c (d_val_print) <TYPE_CODE_STRUCT>: Add fall-through
7133         comment.
7134         * coffread.c (coff_symtab_read) <C_LABEL>: Add fall-through
7135         comment.
7136
7137 2018-05-04  Tom Tromey  <tom@tromey.com>
7138
7139         * dwarf2loc.c (unimplemented): Add ATTRIBUTE_NORETURN.
7140
7141 2018-05-04  Tom Tromey  <tom@tromey.com>
7142
7143         * s390-tdep.c (s390_process_record): Fix fall-through comments.
7144         * xcoffread.c (scan_xcoff_symtab): Move comment later.
7145         * symfile.c (section_is_mapped): Fix fall-through comment.
7146         * stabsread.c (define_symbol, read_member_functions): Fix
7147         fall-through comment.
7148         * s390-linux-tdep.c (s390_process_record): Fix fall-through
7149         comment.
7150         * remote.c (remote_wait_as): Fix fall-through comment.
7151         * p-exp.y (yylex): Fix fall-through comment.
7152         * nat/x86-dregs.c (x86_length_and_rw_bits): Fix fall-through
7153         comment.
7154         * msp430-tdep.c (msp430_gdbarch_init): Fix fall-through comment.
7155         * mdebugread.c (parse_partial_symbols): Fix fall-through comment.
7156         * jv-exp.y (yylex): Fix fall-through comment.
7157         * go-exp.y (lex_one_token): Fix fall-through comment.
7158         * gdbtypes.c (get_discrete_bounds, rank_one_type): Fix
7159         fall-through comment.
7160         * f-exp.y (yylex): Fix fall-through comment.
7161         * dwarf2read.c (process_die): Fix fall-through comments.
7162         * dbxread.c (process_one_symbol): Fix fall-through comment.
7163         * d-exp.y (lex_one_token): Fix fall-through comment.
7164         * cp-name-parser.y (yylex): Fix fall-through comment.
7165         * coffread.c (coff_symtab_read): Fix fall-through comment.
7166         * c-exp.y (lex_one_token): Fix fall-through comment.
7167         * arm-tdep.c (arm_decode_miscellaneous): Fix fall-through
7168         comment.
7169         * arch/arm.c (arm_instruction_changes_pc): Fix fall-through
7170         comment.
7171
7172 2018-05-04  Tom Tromey  <tom@tromey.com>
7173
7174         PR python/22730:
7175         * NEWS: Mention gdb.execute change.
7176         * gdbcmd.h (execute_control_command): Don't declare.
7177         * python/python.c (execute_gdb_command): Use read_command_lines_1,
7178         execute_control_commands, execute_control_commands_to_string.
7179         * cli/cli-script.h (execute_control_commands)
7180         (execute_control_commands_to_string): Declare.
7181         (execute_control_command): Add from_tty parameter.
7182         * cli/cli-script.c (execute_control_commands)
7183         (execute_control_commands_to_string): New functions.
7184         (execute_user_command): Use execute_control_commands.
7185         (execute_control_command_1): Add "from_tty" parameter.  Update.
7186         (execute_control_command): Likewise.
7187
7188 2018-05-04  Tom Tromey  <tom@tromey.com>
7189
7190         PR python/22731:
7191         * NEWS: Mention that breakpoint commands are writable.
7192         * python/py-breakpoint.c (bppy_set_commands): New function.
7193         (breakpoint_object_getset) <"commands">: Use it.
7194
7195 2018-05-04  Tom Tromey  <tom@tromey.com>
7196
7197         * tracepoint.c (actions_command): Update.
7198         * mi/mi-cmd-break.c (mi_command_line_array)
7199         (mi_command_line_array_cnt, mi_command_line_array_ptr)
7200         (mi_read_next_line): Remove.
7201         (mi_cmd_break_commands): Update.
7202         * cli/cli-script.h (read_command_lines, read_command_lines_1): Use
7203         function_view.
7204         * cli/cli-script.c (get_command_line): Update.
7205         (process_next_line): Use function_view.  Constify.
7206         (recurse_read_control_structure, read_command_lines)
7207         (read_command_lines_1): Change argument types to function_view.
7208         (do_define_command, document_command): Update.
7209         * breakpoint.h (check_tracepoint_command): Don't declare.
7210         * breakpoint.c (check_tracepoint_command): Remove.
7211         (commands_command_1, create_tracepoint_from_upload): Update.
7212
7213 2018-05-04  Tom Tromey  <tom@tromey.com>
7214
7215         PR gdb/11750:
7216         * cli/cli-script.h (enum command_control_type) <define_control>:
7217         New constant.
7218         * cli/cli-script.c (multi_line_command_p): Handle define_control.
7219         (build_command_line, execute_control_command_1)
7220         (process_next_line): Likewise.
7221         (do_define_command): New function, extracted from define_command.
7222         (define_command): Use it.
7223
7224 2018-05-04  Tom Tromey  <tom@tromey.com>
7225
7226         * tracepoint.c (actions_command): Update.
7227         * cli/cli-script.h (read_command_lines): Update.
7228         * cli/cli-script.c (read_command_lines): Constify prompt_arg.
7229         (MAX_TMPBUF): Remove define.
7230         (define_command): Use string_printf.
7231         (document_command): Likewise.
7232         * breakpoint.c (commands_command_1): Update.
7233
7234 2018-05-04  Tom Tromey  <tom@tromey.com>
7235
7236         * top.c (execute_command): Update.
7237         * cli/cli-script.h (print_command_lines): Now varargs.
7238         * cli/cli-script.c (print_command_lines): Now varargs.
7239         (execute_control_command_1) <case while_control, case if_control>:
7240         Update.
7241
7242 2018-05-04  Tom Tromey  <tom@tromey.com>
7243
7244         * tracepoint.c (all_tracepoint_actions): Rename from
7245         all_tracepoint_actions_and_cleanup.  Change return type.
7246         (actions_command, encode_actions_1, encode_actions)
7247         (trace_dump_actions, tdump_command): Update.
7248         * remote.c (remote_download_command_source): Update.
7249         * python/python.c (gdbpy_eval_from_control_command)
7250         (python_command, python_interactive_command): Update.
7251         * mi/mi-cmd-break.c (mi_cmd_break_commands): Update.
7252         * guile/guile.c (guile_command)
7253         (gdbscm_eval_from_control_command, guile_command): Update.
7254         * compile/compile.c (compile_code_command)
7255         (compile_print_command, compile_to_object): Update.
7256         * cli/cli-script.h (struct command_lines_deleter): New.
7257         (counted_command_line): New typedef.
7258         (struct command_line): Add constructor, destructor.
7259         <body_list>: Remove.
7260         <body_list_0, body_list_1>: New members.
7261         (command_line_up): Remove typedef.
7262         (read_command_lines, read_command_lines_1, get_command_line):
7263         Update.
7264         (copy_command_lines): Don't declare.
7265         * cli/cli-script.c (build_command_line): Use "new".
7266         (get_command_line): Return counted_command_line.
7267         (print_command_lines, execute_user_command)
7268         (execute_control_command_1, while_command, if_command): Update.
7269         (realloc_body_list): Remove.
7270         (process_next_line, recurse_read_control_structure): Update.
7271         (read_command_lines, read_command_lines_1): Return counted_command_line.
7272         (free_command_lines): Use "delete".
7273         (copy_command_lines): Remove.
7274         (define_command, document_command, show_user_1): Update.
7275         * cli/cli-decode.h (struct cmd_list_element) <user_commands>: Now
7276         a counted_command_line.
7277         * breakpoint.h (counted_command_line): Remove typedef.
7278         (breakpoint_set_commands): Update.
7279         * breakpoint.c (check_no_tracepoint_commands)
7280         (validate_commands_for_breakpoint): Update.
7281         (breakpoint_set_commands): Change commands to be a
7282         counted_command_line.
7283         (commands_command_1, update_dprintf_command_list)
7284         (create_tracepoint_from_upload): Update.
7285
7286 2018-05-04  Tom Tromey  <tom@tromey.com>
7287
7288         * cli/cli-decode.h (cmd_list_element): New constructor.
7289         (~cmd_list_element): New destructor.
7290         (struct cmd_list_element): Add initializers.
7291         * cli/cli-decode.c (do_add_cmd): Use "new".
7292         (delete_cmd): Use "delete".
7293
7294 2018-05-04  Jan Kratochvil  <jan.kratochvil@redhat.com>
7295             Pedro Alves <palves@redhat.com>
7296
7297         PR breakpoints/19806 and support for PR external/20207.
7298         * NEWS: Mention Aarch64 watchpoint improvements.
7299         * aarch64-linux-nat.c (aarch64_linux_stopped_data_address): Fix missed
7300         watchpoints and PR external/20207 watchpoints.
7301         * nat/aarch64-linux-hw-point.c
7302         (kernel_supports_any_contiguous_range): New.
7303         (aarch64_watchpoint_offset): New.
7304         (aarch64_watchpoint_length): Support PR external/20207 watchpoints.
7305         (aarch64_point_encode_ctrl_reg): New parameter offset, new asserts.
7306         (aarch64_point_is_aligned): Support PR external/20207 watchpoints.
7307         (aarch64_align_watchpoint): New parameters aligned_offset_p and
7308         next_addr_orig_p.  Support PR external/20207 watchpoints.
7309         (aarch64_downgrade_regs): New.
7310         (aarch64_dr_state_insert_one_point): New parameters offset and
7311         addr_orig.
7312         (aarch64_dr_state_remove_one_point): Likewise.
7313         (aarch64_handle_breakpoint): Update caller.
7314         (aarch64_handle_aligned_watchpoint): Likewise.
7315         (aarch64_handle_unaligned_watchpoint): Support addr_orig and
7316         aligned_offset.
7317         (aarch64_linux_set_debug_regs): Remove const from state.  Call
7318         aarch64_downgrade_regs.
7319         (aarch64_show_debug_reg_state): Print also dr_addr_orig_wp.
7320         * nat/aarch64-linux-hw-point.h (DR_CONTROL_LENGTH): Rename to ...
7321         (DR_CONTROL_MASK): ... this.
7322         (struct aarch64_debug_reg_state): New field dr_addr_orig_wp.
7323         (unsigned int aarch64_watchpoint_offset): New prototype.
7324         (aarch64_linux_set_debug_regs): Remove const from state.
7325         * utils.c (align_up, align_down): Move to ...
7326         * common/common-utils.c (align_up, align_down): ... here.
7327         * utils.h (align_up, align_down): Move to ...
7328         * common/common-utils.h (align_up, align_down): ... here.
7329
7330 2018-05-04  Joel Brobecker  <brobecker@adacore.com>
7331
7332         * sparc-tdep.c (sparc_structure_return_p): Re-implement to
7333         match the ABI as summarized in GCC's gcc/config/sparc/sparc.c.
7334         (sparc_arg_by_memory_p): Renamed from sparc_arg_on_registers_p.
7335         Re-implement to match the ABI as summarized in GCC's
7336         gcc/config/sparc/sparc.c.  All callers updated.
7337         (sparc32_store_arguments): Remove assertion.
7338
7339 2018-05-04  Tom Tromey  <tom@tromey.com>
7340
7341         * printcmd.c: Don't include tui.h.
7342         (decode_format): Use skip_spaces.
7343
7344 2018-05-04  Tom Tromey  <tom@tromey.com>
7345
7346         PR gdb/22619:
7347         * printcmd.c (last_count): New global.
7348         (x_command): Use saved count when repeating.
7349
7350 2018-05-04  Tom Tromey  <tom@tromey.com>
7351
7352         * nto-procfs.c (do_closedir_cleanup): Remove.
7353         (procfs_pidlist): Use gdb_dir_up.
7354         * procfs.c (do_closedir_cleanup): Remove.
7355         (proc_update_threads): Use gdb_dir_up.
7356         * common/filestuff.h (struct gdb_dir_deleter): New.
7357         (gdb_dir_up): New typedef.
7358
7359 2018-05-04  Tom Tromey  <tom@tromey.com>
7360
7361         * ada-lang.c (print_mention_exception): Use std::string.
7362
7363 2018-05-04  Tom Tromey  <tom@tromey.com>
7364
7365         * ada-lang.c (create_excep_cond_exprs): Update.
7366         (ada_exception_catchpoint_cond_string): Use std::string.
7367
7368 2018-05-04  Tom Tromey  <tom@tromey.com>
7369
7370         * ada-lang.c (xget_renaming_scope): Return std::string.
7371         (old_renaming_is_invisible): Update.
7372
7373 2018-05-04  Tom Tromey  <tom@tromey.com>
7374
7375         * bfd-target.c (target_bfd::m_bfd): Now a gdb_bfd_ref_ptr.
7376         (target_bfd::target_bfd, target_bfd::~target_bfd): Update.
7377
7378 2018-05-04  Ulrich Weigand  <uweigand@de.ibm.com>
7379
7380         * spu-linux-nat.c (spu_linux_nat_target::wait): Fix syntax error.
7381
7382 2018-05-04  Tom Tromey  <tom@tromey.com>
7383
7384         * remote.c (remote_query_supported_append): Change type.
7385         (remote_check_symbols): Update.
7386
7387 2018-05-04  Paul Pluzhnikov  <ppluzhnikov@google.com>
7388
7389         PR gdb/11420
7390         * configure.ac: Prepend libpython.
7391         * python/python-config.py: Likewise.
7392         * configure: Regenerate.
7393
7394 2018-05-03  Simon Marchi  <simon.marchi@ericsson.com>
7395
7396         * Makefile.in (%.c: %.l): Use -t instead of --stdout.
7397
7398 2018-05-03  Pedro Alves  <palves@redhat.com>
7399
7400         * s390-linux-nat.c
7401         (s390_linux_nat_target::have_continuable_watchpoint): Mark with
7402         override.  Write 'true' instead of '1'.
7403         (s390_linux_nat_target::watchpoint_addr_within_range): Remove
7404         declaration.
7405
7406 2018-05-02  Pedro Alves  <palves@redhat.com>
7407
7408         * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Use
7409         add_inf_child_target.
7410         * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Use
7411         add_inf_child_target.
7412         * aix-thread.c (aix_thread_target_info): New.
7413         (aix_thread_target) <shortname, longname, doc>: Delete.
7414         <info>: New.
7415         * alpha-bsd-nat.c (_initialize_alphabsd_nat): Use
7416         add_inf_child_target.
7417         * alpha-linux-nat.c (_initialize_alpha_linux_nat): Use
7418         add_inf_child_target.
7419         * amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Use
7420         add_inf_child_target.
7421         * amd64-linux-nat.c (_initialize_amd64_linux_nat): Use
7422         add_inf_child_target.
7423         * amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Use
7424         add_inf_child_target.
7425         * amd64-obsd-nat.c (_initialize_amd64obsd_nat): Use
7426         add_inf_child_target.
7427         * arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Use
7428         add_inf_child_target.
7429         * arm-linux-nat.c (_initialize_arm_linux_nat): Use
7430         add_inf_child_target.
7431         * arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Use
7432         add_inf_child_target.
7433         * bfd-target.c (target_bfd_target_info): New.
7434         (target_bfd) <shortname, longname, doc>: Delete.
7435         <info>: New.
7436         * bsd-kvm.c (bsd_kvm_target_info): New.
7437         (bsd_kvm_target) <shortname, longname, doc>: Delete.
7438         <info>: New.
7439         (bsd_kvm_target::open): Rename to ...
7440         (bsd_kvm_target_open): ... this.  Adjust.
7441         * bsd-uthread.c (bsd_uthread_target_info): New.
7442         (bsd_uthread_target) <shortname, longname, doc>: Delete.
7443         <info>: New.
7444         * corefile.c (core_file_command): Adjust.
7445         * corelow.c (core_target_info): New.
7446         (core_target) <shortname, longname, doc>: Delete.
7447         <info>: New.
7448         (core_target::open): Rename to ...
7449         (core_target_open): ... this.  Adjust.
7450         * ctf.c (ctf_target_info): New.
7451         (ctf_target) <shortname, longname, doc>: Delete.
7452         <info>: New.
7453         (ctf_target::open): Rename to ...
7454         (ctf_target_open): ... this.
7455         (_initialize_ctf): Adjust.
7456         * exec.c (exec_target_info): New.
7457         (exec_target) <shortname, longname, doc>: Delete.
7458         <info>: New.
7459         (exec_target::open): Rename to ...
7460         (exec_target_open): ... this.
7461         * gdbcore.h (core_target_open): Declare.
7462         * go32-nat.c (_initialize_go32_nat): Use add_inf_child_target.
7463         * hppa-linux-nat.c (_initialize_hppa_linux_nat): Use
7464         add_inf_child_target.
7465         * hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Use
7466         add_inf_child_target.
7467         * hppa-obsd-nat.c (_initialize_hppaobsd_nat): Use
7468         add_inf_child_target.
7469         * i386-darwin-nat.c (_initialize_i386_darwin_nat): Use
7470         add_inf_child_target.
7471         * i386-fbsd-nat.c (_initialize_i386fbsd_nat): Use
7472         add_inf_child_target.
7473         * i386-gnu-nat.c (_initialize_i386gnu_nat): Use
7474         add_inf_child_target.
7475         * i386-linux-nat.c (_initialize_i386_linux_nat): Use
7476         add_inf_child_target.
7477         * i386-nbsd-nat.c (_initialize_i386nbsd_nat): Use
7478         add_inf_child_target.
7479         * i386-obsd-nat.c (_initialize_i386obsd_nat): Use
7480         add_inf_child_target.
7481         * ia64-linux-nat.c (_initialize_ia64_linux_nat): Use
7482         add_inf_child_target.
7483         * inf-child.c (inf_child_target_info): New.
7484         (inf_child_target::info): New.
7485         (inf_child_open_target): Remove 'target' parameter.  Use
7486         get_native_target instead.
7487         (inf_child_target::open): Delete.
7488         (add_inf_child_target): New.
7489         * inf-child.h (inf_child_target) <shortname, longname, doc, open>:
7490         Delete.
7491         <info>: New.
7492         (add_inf_child_target): Declare.
7493         (inf_child_open_target): Declare.
7494         * linux-thread-db.c (thread_db_target_info): New.
7495         (thread_db_target) <shortname, longname, doc>: Delete.
7496         <info>: New.
7497         * m32r-linux-nat.c (_initialize_m32r_linux_nat): Use
7498         add_inf_child_target.
7499         * m68k-bsd-nat.c (_initialize_m68kbsd_nat): Use
7500         add_inf_child_target.
7501         * m68k-linux-nat.c (_initialize_m68k_linux_nat): Use
7502         add_inf_child_target.
7503         * m88k-bsd-nat.c (_initialize_m88kbsd_nat): Use
7504         add_inf_child_target.
7505         * make-target-delegates (print_class): Adjust.
7506         * mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Use
7507         add_inf_child_target.
7508         * mips-linux-nat.c (_initialize_mips_linux_nat): Use
7509         add_inf_child_target.
7510         * mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Use
7511         add_inf_child_target.
7512         * mips64-obsd-nat.c (_initialize_mips64obsd_nat): Use
7513         add_inf_child_target.
7514         * nto-procfs.c (nto_native_target_info): New.
7515         (nto_procfs_target_native) <shortname, longname, doc>:
7516         Delete.
7517         <info>: New.
7518         (nto_procfs_target_info): New.
7519         (nto_procfs_target_procfs) <shortname, longname, doc>:
7520         Delete.
7521         <info>: New.
7522         (init_procfs_targets): Adjust.
7523         * ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Use
7524         add_inf_child_target.
7525         * ppc-linux-nat.c (_initialize_ppc_linux_nat): Use
7526         add_inf_child_target.
7527         * ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Use
7528         add_inf_child_target.
7529         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Use
7530         add_inf_child_target.
7531         * ravenscar-thread.c (ravenscar_target_info): New.
7532         (ravenscar_thread_target) <shortname, longname, doc>:
7533         Delete.
7534         <info>: New.
7535         * record-btrace.c (record_btrace_target_info):
7536         (record_btrace_target) <shortname, longname, doc>: Delete.
7537         <info>: New.
7538         (record_btrace_target::open): Rename to ...
7539         (record_btrace_target_open): ... this.  Adjust.
7540         * record-full.c (record_longname, record_doc): New.
7541         (record_full_base_target) <shortname, longname, doc>: Delete.
7542         <info>: New.
7543         (record_full_target_info): New.
7544         (record_full_target): <shortname>: Delete.
7545         <info>: New.
7546         (record_full_core_open_1, record_full_open_1): Update comments.
7547         (record_full_base_target::open): Rename to ...
7548         (record_full_open): ... this.
7549         (cmd_record_full_restore): Update.
7550         (_initialize_record_full): Update.
7551         * remote-sim.c (remote_sim_target_info): New.
7552         (gdbsim_target) <shortname, longname, doc>: Delete.
7553         <info>: New.
7554         (gdbsim_target::open): Rename to ...
7555         (gdbsim_target_open): ... this.
7556         (_initialize_remote_sim): Adjust.
7557         * remote.c (remote_doc): New.
7558         (remote_target_info): New.
7559         (remote_target) <shortname, longname, doc>: Delete.
7560         <info>: New.
7561         (extended_remote_target_info): New.
7562         (extended_remote_target) <shortname, longname, doc>: Delete.
7563         <info>: New.
7564         (remote_target::open_1): Make static.  Adjust.
7565         * rs6000-nat.c (_initialize_rs6000_nat): Use add_inf_child_target.
7566         * s390-linux-nat.c (_initialize_s390_nat): Use
7567         add_inf_child_target.
7568         * sh-nbsd-nat.c (_initialize_shnbsd_nat): Use
7569         add_inf_child_target.
7570         * sol-thread.c (thread_db_target_info): New.
7571         (sol_thread_target) <shortname, longname, doc>: Delete.
7572         <info>: New.
7573         * sparc-linux-nat.c (_initialize_sparc_linux_nat): Use
7574         add_inf_child_target.
7575         * sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Use
7576         add_inf_child_target.
7577         * sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Use
7578         add_inf_child_target.
7579         * sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Use
7580         add_inf_child_target.
7581         * sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Use
7582         add_inf_child_target.
7583         * sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Use
7584         add_inf_child_target.
7585         * spu-linux-nat.c (_initialize_spu_nat): Use
7586         add_inf_child_target.
7587         * spu-multiarch.c (spu_multiarch_target_info): New.
7588         (spu_multiarch_target) <shortname, longname, doc>: Delete.
7589         <info>: New.
7590         * target-delegates.c: Regenerate.
7591         * target.c: Include <unordered_map>.
7592         (target_ops_p): Delete.
7593         (DEF_VEC_P(target_ops_p)): Delete.
7594         (target_factories): New.
7595         (test_target_info): New.
7596         (test_target_ops::info): New.
7597         (open_target): Adjust to use target_factories.
7598         (add_target_with_completer): Rename to ...
7599         (add_target): ... this.  Change prototype.  Register target_info
7600         and open callback in target_factories.  Register target_info in
7601         command context instead of target_ops.
7602         (add_target): Delete old implementation.
7603         (add_deprecated_target_alias): Change prototype.  Adjust.
7604         (the_native_target): New.
7605         (set_native_target, get_native_target): New.
7606         (find_default_run_target): Use the_native_target.
7607         (find_attach_target, find_run_target): Simplify.
7608         (target_ops::open): Delete.
7609         (dummy_target_info): New.
7610         (dummy_target::shortname, dummy_target::longname)
7611         (dummy_target::doc): Delete.
7612         (dummy_target::info): New.
7613         (debug_target::shortname, debug_target::longname)
7614         (debug_target::doc): Delete.
7615         (debug_target::info): New.
7616         * target.h (struct target_info): New.
7617         (target_ops::~target_ops): Add comment.
7618         (target_ops::info): New.
7619         (target_ops::shortname, target_ops::longname, target_ops::doc): No
7620         longer virtual.  Implement in terms of target_info.
7621         (set_native_target, get_native_target): Declare.
7622         (target_open_ftype): New.
7623         (add_target, add_target_with_completer)
7624         (add_deprecated_target_alias): Change prototype.
7625         (test_target) <shortname, longname, doc>: Delete.
7626         <info>: New.
7627         * tilegx-linux-nat.c (_initialize_tile_linux_nat): Use
7628         add_inf_child_target.
7629         * tracefile-tfile.c (tfile_target_info): New.
7630         (tfile_target) <shortname, longname, doc>: Delete.
7631         <info>: New.
7632         (tfile_target::open): Rename to ...
7633         (tfile_target_open): ... this.
7634         (_initialize_tracefile_tfile): Adjust.
7635         * vax-bsd-nat.c (_initialize_vaxbsd_nat): Use
7636         add_inf_child_target.
7637         * windows-nat.c (_initialize_windows_nat): Use
7638         add_inf_child_target.
7639         * xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Use
7640         add_inf_child_target.
7641
7642 2018-05-02  Pedro Alves  <palves@redhat.com>
7643
7644         * linux-nat.h (linux_nat_target) <low_new_thread,
7645         low_delete_thread, low_new_fork, low_forget_process,
7646         low_prepare_to_resume, low_siginfo_fixup, low_status_is_event>:
7647         New virtual methods.
7648         (linux_nat_set_new_thread, linux_nat_set_delete_thread)
7649         (linux_nat_new_fork_ftype, linux_nat_set_new_fork)
7650         (linux_nat_forget_process_ftype, linux_nat_set_forget_process)
7651         (linux_nat_forget_process, linux_nat_set_siginfo_fixup)
7652         (linux_nat_set_prepare_to_resume, linux_nat_set_status_is_event):
7653         Delete.
7654         * linux-fork.c (delete_fork): Adjust to call low method.
7655         * linux-nat.c (linux_nat_new_thread, linux_nat_delete_thread)
7656         (linux_nat_new_fork, linux_nat_forget_process_hook)
7657         (linux_nat_prepare_to_resume, linux_nat_siginfo_fixup)
7658         (linux_nat_status_is_event):
7659         (linux_nat_target::follow_fork, lwp_free, add_lwp, detach_one_lwp)
7660         (linux_resume_one_lwp_throw, linux_handle_extended_wait): Adjust
7661         to call low method.
7662         (sigtrap_is_event): Rename to ...
7663         (linux_nat_target::low_status_is_event): ... this.
7664         (linux_nat_set_status_is_event): Delete.
7665         (save_stop_reason, linux_nat_wait_1)
7666         (linux_nat_target::mourn_inferior, siginfo_fixup): Adjust to call
7667         low methods.
7668         (linux_nat_set_new_thread, linux_nat_set_delete_thread)
7669         (linux_nat_set_new_fork, linux_nat_set_forget_process)
7670         (linux_nat_forget_process, linux_nat_set_siginfo_fixup)
7671         (linux_nat_set_prepare_to_resume): Delete.
7672         * aarch64-linux-nat.c: All linux_nat_set_* callbacks converted to
7673         low virtual methods.
7674         * amd64-linux-nat.c: Likewise.
7675         * arm-linux-nat.c: Likewise.
7676         * i386-linux-nat.c: Likewise.
7677         * ia64-linux-nat.c: Likewise.
7678         * mips-linux-nat.c: Likewise.
7679         * ppc-linux-nat.c: Likewise.
7680         * s390-linux-nat.c: Likewise.
7681         * sparc64-linux-nat.c: Likewise.
7682         * x86-linux-nat.c: Likewise.
7683         * x86-linux-nat.h: Include "nat/x86-linux.h".
7684         (x86_linux_nat_target) <low_new_fork, low_forget_process,
7685         low_prepare_to_resume, low_new_thread, low_delete_thread>:
7686         Override methods.
7687
7688 2018-05-02  Pedro Alves  <palves@redhat.com>
7689
7690         * target.h (target_ops)
7691         <stopped_by_sw_breakpoint, supports_stopped_by_sw_breakpoint,
7692         stopped_by_hw_breakpoint, supports_stopped_by_hw_breakpoint,
7693         stopped_by_watchpoint, have_continuable_watchpoint,
7694         stopped_data_address, watchpoint_addr_within_range,
7695         can_accel_watchpoint_condition, can_run, thread_alive,
7696         has_all_memory, has_memory, has_stack, has_registers,
7697         has_execution, can_async_p, is_async_p, supports_non_stop,
7698         always_non_stop_p, can_execute_reverse, supports_multi_process,
7699         supports_enable_disable_tracepoint,
7700         supports_disable_randomization, supports_string_tracing,
7701         supports_evaluation_of_breakpoint_conditions,
7702         can_run_breakpoint_commands, filesystem_is_local,
7703         can_download_tracepoint, get_trace_state_variable_value,
7704         set_trace_notes, get_tib_address, use_agent, can_use_agent,
7705         record_is_replaying, record_will_replay,
7706         augmented_libraries_svr4_read>: Adjust to return bool.
7707         * aarch64-linux-nat.c: All implementations adjusted.
7708         * aix-thread.c: All implementations adjusted.
7709         * arm-linux-nat.c: All implementations adjusted.
7710         * breakpoint.c: All implementations adjusted.
7711         * bsd-kvm.c: All implementations adjusted.
7712         * bsd-uthread.c: All implementations adjusted.
7713         * corelow.c: All implementations adjusted.
7714         * ctf.c: All implementations adjusted.
7715         * darwin-nat.c: All implementations adjusted.
7716         * darwin-nat.h: All implementations adjusted.
7717         * exec.c: All implementations adjusted.
7718         * fbsd-nat.c: All implementations adjusted.
7719         * fbsd-nat.h: All implementations adjusted.
7720         * gnu-nat.c: All implementations adjusted.
7721         * gnu-nat.h: All implementations adjusted.
7722         * go32-nat.c: All implementations adjusted.
7723         * ia64-linux-nat.c: All implementations adjusted.
7724         * inf-child.c: All implementations adjusted.
7725         * inf-child.h: All implementations adjusted.
7726         * inf-ptrace.c: All implementations adjusted.
7727         * inf-ptrace.h: All implementations adjusted.
7728         * linux-nat.c: All implementations adjusted.
7729         * linux-nat.h: All implementations adjusted.
7730         * mips-linux-nat.c: All implementations adjusted.
7731         * nto-procfs.c: All implementations adjusted.
7732         * ppc-linux-nat.c: All implementations adjusted.
7733         * procfs.c: All implementations adjusted.
7734         * ravenscar-thread.c: All implementations adjusted.
7735         * record-btrace.c: All implementations adjusted.
7736         * record-full.c: All implementations adjusted.
7737         * remote-sim.c: All implementations adjusted.
7738         * remote.c: All implementations adjusted.
7739         * s390-linux-nat.c: All implementations adjusted.
7740         * sol-thread.c: All implementations adjusted.
7741         * spu-multiarch.c: All implementations adjusted.
7742         * target-delegates.c: All implementations adjusted.
7743         * target.c: All implementations adjusted.
7744         * target.h: All implementations adjusted.
7745         * tracefile-tfile.c: All implementations adjusted.
7746         * tracefile.c: All implementations adjusted.
7747         * tracefile.h: All implementations adjusted.
7748         * windows-nat.c: All implementations adjusted.
7749         * x86-linux-nat.h: All implementations adjusted.
7750         * x86-nat.h: All implementations adjusted.
7751
7752 2018-05-02  Pedro Alves  <palves@redhat.com>
7753
7754         * make-target-delegates (scan_target_h): Don't trim lines here.
7755         Replace sequences of tabs and/or whitespace with a single
7756         whitespace.
7757         (top level, parsing methods): Trim each line before processing it
7758         here.
7759
7760 2018-05-02  Pedro Alves  <palves@redhat.com>
7761             John Baldwin  <jhb@freebsd.org>
7762
7763         * target.h (enum strata) <debug_stratum>: New.
7764         (struct target_ops) <all delegation methods>: Replace by C++
7765         virtual methods, and drop "to_" prefix.  All references updated
7766         throughout.
7767         <to_shortname, to_longname, to_doc, to_data,
7768         to_have_steppable_watchpoint, to_have_continuable_watchpoint,
7769         to_has_thread_control, to_attach_no_wait>: Delete, replaced by
7770         virtual methods.  All references updated throughout.
7771         <can_attach, supports_terminal_ours, can_create_inferior,
7772         get_thread_control_capabilities, attach_no_wait>: New
7773         virtual methods.
7774         <insert_breakpoint, remove_breakpoint>: Now
7775         TARGET_DEFAULT_NORETURN methods.
7776         <info_proc>: Now returns bool.
7777         <to_magic>: Delete.
7778         (OPS_MAGIC): Delete.
7779         (current_target): Delete.  All references replaced by references
7780         to ...
7781         (target_stack): ... this.  New.
7782         (target_shortname, target_longname): Adjust.
7783         (target_can_run): Now a function declaration.
7784         (default_child_has_all_memory, default_child_has_memory)
7785         (default_child_has_stack, default_child_has_registers)
7786         (default_child_has_execution): Remove target_ops parameter.
7787         (complete_target_initialization): Delete.
7788         (memory_breakpoint_target): New template class.
7789         (test_target_ops): Refactor as a C++ class with virtual methods.
7790         * make-target-delegates (NAME_PART): Tighten.
7791         (POINTER_PART, CP_SYMBOL): New.
7792         (SIMPLE_RETURN_PART): Reimplement.
7793         (VEC_RETURN_PART): Expect less.
7794         (RETURN_PART, VIRTUAL_PART): New.
7795         (METHOD): Adjust to C++ virtual methods.
7796         (scan_target_h): Remove reference to C99.
7797         (dname): Output "target_ops::" prefix.
7798         (write_function_header): Adjust to output a C++ class method.
7799         (write_declaration): New.
7800         (write_delegator): Adjust to output a C++ class method.
7801         (tdname): Output "dummy_target::" prefix.
7802         (write_tdefault, write_debugmethod): Adjust to output a C++ class
7803         method.
7804         (tdefault_names, debug_names): Delete.
7805         (return_types, tdefaults, styles, argtypes_array): New.
7806         (top level): All methods are delegators.
7807         (print_class): New.
7808         (top level): Print dummy_target and debug_target classes.
7809         * target-delegates.c: Regenerate.
7810         * target-debug.h (target_debug_print_enum_info_proc_what)
7811         (target_debug_print_thread_control_capabilities)
7812         (target_debug_print_thread_info_p): New.
7813         * target.c (dummy_target): Delete.
7814         (the_dummy_target, the_debug_target): New.
7815         (target_stack): Now extern.
7816         (set_targetdebug): Push/unpush debug target.
7817         (default_child_has_all_memory, default_child_has_memory)
7818         (default_child_has_stack, default_child_has_registers)
7819         (default_child_has_execution): Remove target_ops parameter.
7820         (complete_target_initialization): Delete.
7821         (add_target_with_completer): No longer call
7822         complete_target_initialization.
7823         (target_supports_terminal_ours): Use regular delegation.
7824         (update_current_target): Delete.
7825         (push_target): No longer check magic number.  Don't call
7826         update_current_target.
7827         (unpush_target): Don't call update_current_target.
7828         (target_is_pushed): No longer check magic number.
7829         (target_require_runnable): Skip for all stratums over
7830         process_stratum.
7831         (target_ops::info_proc): New.
7832         (target_info_proc): Use find_target_at and
7833         find_default_run_target.
7834         (target_supports_disable_randomization): Use regular delegation.
7835         (target_get_osdata): Use find_target_at.
7836         (target_ops::open, target_ops::close, target_ops::can_attach)
7837         (target_ops::attach, target_ops::can_create_inferior)
7838         (target_ops::create_inferior, target_ops::can_run)
7839         (target_can_run): New.
7840         (default_fileio_target): Use regular delegation.
7841         (target_ops::fileio_open, target_ops::fileio_pwrite)
7842         (target_ops::fileio_pread, target_ops::fileio_fstat)
7843         (target_ops::fileio_close, target_ops::fileio_unlink)
7844         (target_ops::fileio_readlink): New.
7845         (target_fileio_open_1, target_fileio_unlink)
7846         (target_fileio_readlink): Always call the target method.  Handle
7847         FILEIO_ENOSYS.
7848         (return_zero, return_zero_has_execution): Delete.
7849         (init_dummy_target): Delete.
7850         (dummy_target::dummy_target, dummy_target::shortname)
7851         (dummy_target::longname, dummy_target::doc)
7852         (debug_target::debug_target, debug_target::shortname)
7853         (debug_target::longname, debug_target::doc): New.
7854         (target_supports_delete_record): Use regular delegation.
7855         (setup_target_debug): Delete.
7856         (maintenance_print_target_stack): Skip debug_stratum.
7857         (initialize_targets): Instantiate the_dummy_target and
7858         the_debug_target.
7859         * auxv.c (target_auxv_parse): Remove 'ops' parameter.  Adjust to
7860         use target_stack.
7861         (target_auxv_search, fprint_target_auxv): Adjust.
7862         (info_auxv_command): Adjust to use target_stack.
7863         * auxv.h (target_auxv_parse): Remove 'ops' parameter.
7864         * exceptions.c (print_flush): Handle a NULL target_stack.
7865         * regcache.c (target_ops_no_register): Refactor as class with
7866         virtual methods.
7867
7868         * exec.c (exec_target): New class.
7869         (exec_ops): Now an exec_target.
7870         (exec_open, exec_close_1, exec_get_section_table)
7871         (exec_xfer_partial, exec_files_info, exec_has_memory)
7872         (exec_make_note_section): Refactor as exec_target methods.
7873         (exec_file_clear, ignore, exec_remove_breakpoint, init_exec_ops):
7874         Delete.
7875         (exec_target::find_memory_regions): New.
7876         (_initialize_exec): Don't call init_exec_ops.
7877         * gdbcore.h (exec_file_clear): Delete.
7878
7879         * corefile.c (core_target): Delete.
7880         (core_file_command): Adjust.
7881         * corelow.c (core_target): New class.
7882         (the_core_target): New.
7883         (core_close): Remove target_ops parameter.
7884         (core_close_cleanup): Adjust.
7885         (core_target::close): New.
7886         (core_open, core_detach, get_core_registers, core_files_info)
7887         (core_xfer_partial, core_thread_alive, core_read_description)
7888         (core_pid_to_str, core_thread_name, core_has_memory)
7889         (core_has_stack, core_has_registers, core_info_proc): Rework as
7890         core_target methods.
7891         (ignore, core_remove_breakpoint, init_core_ops): Delete.
7892         (_initialize_corelow): Initialize the_core_target.
7893         * gdbcore.h (core_target): Delete.
7894         (the_core_target): New.
7895
7896         * ctf.c: (ctf_target): New class.
7897         (ctf_ops): Now a ctf_target.
7898         (ctf_open, ctf_close, ctf_files_info, ctf_fetch_registers)
7899         (ctf_xfer_partial, ctf_get_trace_state_variable_value)
7900         (ctf_trace_find, ctf_traceframe_info): Refactor as ctf_target
7901         methods.
7902         (init_ctf_ops): Delete.
7903         (_initialize_ctf): Don't call it.
7904         * tracefile-tfile.c (tfile_target): New class.
7905         (tfile_ops): Now a tfile_target.
7906         (tfile_open, tfile_close, tfile_files_info)
7907         (tfile_get_tracepoint_status, tfile_trace_find)
7908         (tfile_fetch_registers, tfile_xfer_partial)
7909         (tfile_get_trace_state_variable_value, tfile_traceframe_info):
7910         Refactor as tfile_target methods.
7911         (tfile_xfer_partial_features): Remove target_ops parameter.
7912         (init_tfile_ops): Delete.
7913         (_initialize_tracefile_tfile): Don't call it.
7914         * tracefile.c (tracefile_has_all_memory, tracefile_has_memory)
7915         (tracefile_has_stack, tracefile_has_registers)
7916         (tracefile_thread_alive, tracefile_get_trace_status): Refactor as
7917         tracefile_target methods.
7918         (init_tracefile_ops): Delete.
7919         (tracefile_target::tracefile_target): New.
7920         * tracefile.h: Include "target.h".
7921         (tracefile_target): New class.
7922         (init_tracefile_ops): Delete.
7923
7924         * spu-multiarch.c (spu_multiarch_target): New class.
7925         (spu_ops): Now a spu_multiarch_target.
7926         (spu_thread_architecture, spu_region_ok_for_hw_watchpoint)
7927         (spu_fetch_registers, spu_store_registers, spu_xfer_partial)
7928         (spu_search_memory, spu_mourn_inferior): Refactor as
7929         spu_multiarch_target methods.
7930         (init_spu_ops): Delete.
7931         (_initialize_spu_multiarch): Remove references to init_spu_ops,
7932         complete_target_initialization.
7933
7934         * ravenscar-thread.c (ravenscar_thread_target): New class.
7935         (ravenscar_ops): Now a ravenscar_thread_target.
7936         (ravenscar_resume, ravenscar_wait, ravenscar_update_thread_list)
7937         (ravenscar_thread_alive, ravenscar_pid_to_str)
7938         (ravenscar_fetch_registers, ravenscar_store_registers)
7939         (ravenscar_prepare_to_store, ravenscar_stopped_by_sw_breakpoint)
7940         (ravenscar_stopped_by_hw_breakpoint)
7941         (ravenscar_stopped_by_watchpoint, ravenscar_stopped_data_address)
7942         (ravenscar_mourn_inferior, ravenscar_core_of_thread)
7943         (ravenscar_get_ada_task_ptid): Refactor as ravenscar_thread_target
7944         methods.
7945         (init_ravenscar_thread_ops): Delete.
7946         (_initialize_ravenscar): Remove references to
7947         init_ravenscar_thread_ops and complete_target_initialization.
7948
7949         * bsd-uthread.c (bsd_uthread_ops_hack): Delete.
7950         (bsd_uthread_target): New class.
7951         (bsd_uthread_ops): Now a bsd_uthread_target.
7952         (bsd_uthread_activate): Adjust to refer to bsd_uthread_ops.
7953         (bsd_uthread_close, bsd_uthread_mourn_inferior)
7954         (bsd_uthread_fetch_registers, bsd_uthread_store_registers)
7955         (bsd_uthread_wait, bsd_uthread_resume, bsd_uthread_thread_alive)
7956         (bsd_uthread_update_thread_list, bsd_uthread_extra_thread_info)
7957         (bsd_uthread_pid_to_str): Refactor as bsd_uthread_target methods.
7958         (bsd_uthread_target): Delete function.
7959         (_initialize_bsd_uthread): Remove reference to
7960         complete_target_initialization.
7961
7962         * bfd-target.c (target_bfd_data): Delete.  Fields folded into ...
7963         (target_bfd): ... this new class.
7964         (target_bfd_xfer_partial, target_bfd_get_section_table)
7965         (target_bfd_close): Refactor as target_bfd methods.
7966         (target_bfd::~target_bfd): New.
7967         (target_bfd_reopen): Adjust.
7968         (target_bfd::close): New.
7969
7970         * record-btrace.c (record_btrace_target): New class.
7971         (record_btrace_ops): Now a record_btrace_target.
7972         (record_btrace_open, record_btrace_stop_recording)
7973         (record_btrace_disconnect, record_btrace_close)
7974         (record_btrace_async, record_btrace_info)
7975         (record_btrace_insn_history, record_btrace_insn_history_range)
7976         (record_btrace_insn_history_from, record_btrace_call_history)
7977         (record_btrace_call_history_range)
7978         (record_btrace_call_history_from, record_btrace_record_method)
7979         (record_btrace_is_replaying, record_btrace_will_replay)
7980         (record_btrace_xfer_partial, record_btrace_insert_breakpoint)
7981         (record_btrace_remove_breakpoint, record_btrace_fetch_registers)
7982         (record_btrace_store_registers, record_btrace_prepare_to_store)
7983         (record_btrace_to_get_unwinder)
7984         (record_btrace_to_get_tailcall_unwinder, record_btrace_resume)
7985         (record_btrace_commit_resume, record_btrace_wait)
7986         (record_btrace_stop, record_btrace_can_execute_reverse)
7987         (record_btrace_stopped_by_sw_breakpoint)
7988         (record_btrace_supports_stopped_by_sw_breakpoint)
7989         (record_btrace_stopped_by_hw_breakpoint)
7990         (record_btrace_supports_stopped_by_hw_breakpoint)
7991         (record_btrace_update_thread_list, record_btrace_thread_alive)
7992         (record_btrace_goto_begin, record_btrace_goto_end)
7993         (record_btrace_goto, record_btrace_stop_replaying_all)
7994         (record_btrace_execution_direction)
7995         (record_btrace_prepare_to_generate_core)
7996         (record_btrace_done_generating_core): Refactor as
7997         record_btrace_target methods.
7998         (init_record_btrace_ops): Delete.
7999         (_initialize_record_btrace): Remove reference to
8000         init_record_btrace_ops.
8001         * record-full.c (RECORD_FULL_IS_REPLAY): Adjust to always refer to
8002         the execution_direction global.
8003         (record_full_base_target, record_full_target)
8004         (record_full_core_target): New classes.
8005         (record_full_ops): Now a record_full_target.
8006         (record_full_core_ops): Now a record_full_core_target.
8007         (record_full_target::detach, record_full_target::disconnect)
8008         (record_full_core_target::disconnect)
8009         (record_full_target::mourn_inferior, record_full_target::kill):
8010         New.
8011         (record_full_open, record_full_close, record_full_async): Refactor
8012         as methods of the record_full_base_target class.
8013         (record_full_resume, record_full_commit_resume): Refactor
8014         as methods of the record_full_target class.
8015         (record_full_wait, record_full_stopped_by_watchpoint)
8016         (record_full_stopped_data_address)
8017         (record_full_stopped_by_sw_breakpoint)
8018         (record_full_supports_stopped_by_sw_breakpoint)
8019         (record_full_stopped_by_hw_breakpoint)
8020         (record_full_supports_stopped_by_hw_breakpoint): Refactor as
8021         methods of the record_full_base_target class.
8022         (record_full_store_registers, record_full_xfer_partial)
8023         (record_full_insert_breakpoint, record_full_remove_breakpoint):
8024         Refactor as methods of the record_full_target class.
8025         (record_full_can_execute_reverse, record_full_get_bookmark)
8026         (record_full_goto_bookmark, record_full_execution_direction)
8027         (record_full_record_method, record_full_info, record_full_delete)
8028         (record_full_is_replaying, record_full_will_replay)
8029         (record_full_goto_begin, record_full_goto_end, record_full_goto)
8030         (record_full_stop_replaying): Refactor as methods of the
8031         record_full_base_target class.
8032         (record_full_core_resume, record_full_core_kill)
8033         (record_full_core_fetch_registers)
8034         (record_full_core_prepare_to_store)
8035         (record_full_core_store_registers, record_full_core_xfer_partial)
8036         (record_full_core_insert_breakpoint)
8037         (record_full_core_remove_breakpoint)
8038         (record_full_core_has_execution): Refactor
8039         as methods of the record_full_core_target class.
8040         (record_full_base_target::supports_delete_record): New.
8041         (init_record_full_ops): Delete.
8042         (init_record_full_core_ops): Delete.
8043         (record_full_save): Refactor as method of the
8044         record_full_base_target class.
8045         (_initialize_record_full): Remove references to
8046         init_record_full_ops and init_record_full_core_ops.
8047
8048         * remote.c (remote_target, extended_remote_target): New classes.
8049         (remote_ops): Now a remote_target.
8050         (extended_remote_ops): Now an extended_remote_target.
8051         (remote_insert_fork_catchpoint, remote_remove_fork_catchpoint)
8052         (remote_insert_vfork_catchpoint, remote_remove_vfork_catchpoint)
8053         (remote_insert_exec_catchpoint, remote_remove_exec_catchpoint)
8054         (remote_pass_signals, remote_set_syscall_catchpoint)
8055         (remote_program_signals, )
8056         (remote_thread_always_alive): Remove target_ops parameter.
8057         (remote_thread_alive, remote_thread_name)
8058         (remote_update_thread_list, remote_threads_extra_info)
8059         (remote_static_tracepoint_marker_at)
8060         (remote_static_tracepoint_markers_by_strid)
8061         (remote_get_ada_task_ptid, remote_close, remote_start_remote)
8062         (remote_open): Refactor as methods of remote_target.
8063         (extended_remote_open, extended_remote_detach)
8064         (extended_remote_attach, extended_remote_post_attach):
8065         (extended_remote_supports_disable_randomization)
8066         (extended_remote_create_inferior): : Refactor as method of
8067         extended_remote_target.
8068         (remote_set_permissions, remote_open_1, remote_detach)
8069         (remote_follow_fork, remote_follow_exec, remote_disconnect)
8070         (remote_resume, remote_commit_resume, remote_stop)
8071         (remote_interrupt, remote_pass_ctrlc, remote_terminal_inferior)
8072         (remote_terminal_ours, remote_wait, remote_fetch_registers)
8073         (remote_prepare_to_store, remote_store_registers)
8074         (remote_flash_erase, remote_flash_done, remote_files_info)
8075         (remote_kill, remote_mourn, remote_insert_breakpoint)
8076         (remote_remove_breakpoint, remote_insert_watchpoint)
8077         (remote_watchpoint_addr_within_range)
8078         (remote_remove_watchpoint, remote_region_ok_for_hw_watchpoint)
8079         (remote_check_watch_resources, remote_stopped_by_sw_breakpoint)
8080         (remote_supports_stopped_by_sw_breakpoint)
8081         (remote_stopped_by_hw_breakpoint)
8082         (remote_supports_stopped_by_hw_breakpoint)
8083         (remote_stopped_by_watchpoint, remote_stopped_data_address)
8084         (remote_insert_hw_breakpoint, remote_remove_hw_breakpoint)
8085         (remote_verify_memory): Refactor as methods of remote_target.
8086         (remote_write_qxfer, remote_read_qxfer): Remove target_ops
8087         parameter.
8088         (remote_xfer_partial, remote_get_memory_xfer_limit)
8089         (remote_search_memory, remote_rcmd, remote_memory_map)
8090         (remote_pid_to_str, remote_get_thread_local_address)
8091         (remote_get_tib_address, remote_read_description): Refactor as
8092         methods of remote_target.
8093         (remote_target::fileio_open, remote_target::fileio_pwrite)
8094         (remote_target::fileio_pread, remote_target::fileio_close): New.
8095         (remote_hostio_readlink, remote_hostio_fstat)
8096         (remote_filesystem_is_local, remote_can_execute_reverse)
8097         (remote_supports_non_stop, remote_supports_disable_randomization)
8098         (remote_supports_multi_process, remote_supports_cond_breakpoints)
8099         (remote_supports_enable_disable_tracepoint)
8100         (remote_supports_string_tracing)
8101         (remote_can_run_breakpoint_commands, remote_trace_init)
8102         (remote_download_tracepoint, remote_can_download_tracepoint)
8103         (remote_download_trace_state_variable, remote_enable_tracepoint)
8104         (remote_disable_tracepoint, remote_trace_set_readonly_regions)
8105         (remote_trace_start, remote_get_trace_status)
8106         (remote_get_tracepoint_status, remote_trace_stop)
8107         (remote_trace_find, remote_get_trace_state_variable_value)
8108         (remote_save_trace_data, remote_get_raw_trace_data)
8109         (remote_set_disconnected_tracing, remote_core_of_thread)
8110         (remote_set_circular_trace_buffer, remote_traceframe_info)
8111         (remote_get_min_fast_tracepoint_insn_len)
8112         (remote_set_trace_buffer_size, remote_set_trace_notes)
8113         (remote_use_agent, remote_can_use_agent, remote_enable_btrace)
8114         (remote_disable_btrace, remote_teardown_btrace)
8115         (remote_read_btrace, remote_btrace_conf)
8116         (remote_augmented_libraries_svr4_read, remote_load)
8117         (remote_pid_to_exec_file, remote_can_do_single_step)
8118         (remote_execution_direction, remote_thread_handle_to_thread_info):
8119         Refactor as methods of remote_target.
8120         (init_remote_ops, init_extended_remote_ops): Delete.
8121         (remote_can_async_p, remote_is_async_p, remote_async)
8122         (remote_thread_events, remote_upload_tracepoints)
8123         (remote_upload_trace_state_variables): Refactor as methods of
8124         remote_target.
8125         (_initialize_remote): Remove references to init_remote_ops and
8126         init_extended_remote_ops.
8127
8128         * remote-sim.c (gdbsim_target): New class.
8129         (gdbsim_fetch_register, gdbsim_store_register, gdbsim_kill)
8130         (gdbsim_load, gdbsim_create_inferior, gdbsim_open, gdbsim_close)
8131         (gdbsim_detach, gdbsim_resume, gdbsim_interrupt)
8132         (gdbsim_wait, gdbsim_prepare_to_store, gdbsim_xfer_partial)
8133         (gdbsim_files_info, gdbsim_mourn_inferior, gdbsim_thread_alive)
8134         (gdbsim_pid_to_str, gdbsim_has_all_memory, gdbsim_has_memory):
8135         Refactor as methods of gdbsim_target.
8136         (gdbsim_ops): Now a gdbsim_target.
8137         (init_gdbsim_ops): Delete.
8138         (gdbsim_cntrl_c): Adjust.
8139         (_initialize_remote_sim): Remove reference to init_gdbsim_ops.
8140
8141         * amd64-linux-nat.c (amd64_linux_nat_target): New class.
8142         (the_amd64_linux_nat_target): New.
8143         (amd64_linux_fetch_inferior_registers)
8144         (amd64_linux_store_inferior_registers): Refactor as methods of
8145         amd64_linux_nat_target.
8146         (_initialize_amd64_linux_nat): Adjust.  Set linux_target.
8147         * i386-linux-nat.c: Don't include "linux-nat.h".
8148         (i386_linux_nat_target): New class.
8149         (the_i386_linux_nat_target): New.
8150         (i386_linux_fetch_inferior_registers)
8151         (i386_linux_store_inferior_registers, i386_linux_resume): Refactor
8152         as methods of i386_linux_nat_target.
8153         (_initialize_i386_linux_nat): Adjust.  Set linux_target.
8154         * inf-child.c (inf_child_ops): Delete.
8155         (inf_child_fetch_inferior_registers)
8156         (inf_child_store_inferior_registers): Delete.
8157         (inf_child_post_attach, inf_child_prepare_to_store): Refactor as
8158         methods of inf_child_target.
8159         (inf_child_target::supports_terminal_ours)
8160         (inf_child_target::terminal_init)
8161         (inf_child_target::terminal_inferior)
8162         (inf_child_target::terminal_ours_for_output)
8163         (inf_child_target::terminal_ours, inf_child_target::interrupt)
8164         (inf_child_target::pass_ctrlc, inf_child_target::terminal_info):
8165         New.
8166         (inf_child_open, inf_child_disconnect, inf_child_close)
8167         (inf_child_mourn_inferior, inf_child_maybe_unpush_target)
8168         (inf_child_post_startup_inferior, inf_child_can_run)
8169         (inf_child_pid_to_exec_file): Refactor as methods of
8170         inf_child_target.
8171         (inf_child_follow_fork): Delete.
8172         (inf_child_target::can_create_inferior)
8173         (inf_child_target::can_attach): New.
8174         (inf_child_target::has_all_memory, inf_child_target::has_memory)
8175         (inf_child_target::has_stack, inf_child_target::has_registers)
8176         (inf_child_target::has_execution): New.
8177         (inf_child_fileio_open, inf_child_fileio_pwrite)
8178         (inf_child_fileio_pread, inf_child_fileio_fstat)
8179         (inf_child_fileio_close, inf_child_fileio_unlink)
8180         (inf_child_fileio_readlink, inf_child_use_agent)
8181         (inf_child_can_use_agent): Refactor as methods of
8182         inf_child_target.
8183         (return_zero, inf_child_target): Delete.
8184         (inf_child_target::inf_child_target): New.
8185         * inf-child.h: Include "target.h".
8186         (inf_child_target): Delete function prototype.
8187         (inf_child_target): New class.
8188         (inf_child_open_target, inf_child_mourn_inferior)
8189         (inf_child_maybe_unpush_target): Delete.
8190         * inf-ptrace.c (inf_ptrace_target::~inf_ptrace_target): New.
8191         (inf_ptrace_follow_fork, inf_ptrace_insert_fork_catchpoint)
8192         (inf_ptrace_remove_fork_catchpoint, inf_ptrace_create_inferior)
8193         (inf_ptrace_post_startup_inferior, inf_ptrace_mourn_inferior)
8194         (inf_ptrace_attach, inf_ptrace_post_attach, inf_ptrace_detach)
8195         (inf_ptrace_detach_success, inf_ptrace_kill, inf_ptrace_resume)
8196         (inf_ptrace_wait, inf_ptrace_xfer_partial)
8197         (inf_ptrace_thread_alive, inf_ptrace_files_info)
8198         (inf_ptrace_pid_to_str, inf_ptrace_auxv_parse): Refactor as
8199         methods of inf_ptrace_target.
8200         (inf_ptrace_target): Delete function.
8201         * inf-ptrace.h: Include "inf-child.h".
8202         (inf_ptrace_target): Delete function declaration.
8203         (inf_ptrace_target): New class.
8204         (inf_ptrace_trad_target, inf_ptrace_detach_success): Delete.
8205         * linux-nat.c (linux_target): New.
8206         (linux_ops, linux_ops_saved, super_xfer_partial): Delete.
8207         (linux_nat_target::~linux_nat_target): New.
8208         (linux_child_post_attach, linux_child_post_startup_inferior)
8209         (linux_child_follow_fork, linux_child_insert_fork_catchpoint)
8210         (linux_child_remove_fork_catchpoint)
8211         (linux_child_insert_vfork_catchpoint)
8212         (linux_child_remove_vfork_catchpoint)
8213         (linux_child_insert_exec_catchpoint)
8214         (linux_child_remove_exec_catchpoint)
8215         (linux_child_set_syscall_catchpoint, linux_nat_pass_signals)
8216         (linux_nat_create_inferior, linux_nat_attach, linux_nat_detach)
8217         (linux_nat_resume, linux_nat_stopped_by_watchpoint)
8218         (linux_nat_stopped_data_address)
8219         (linux_nat_stopped_by_sw_breakpoint)
8220         (linux_nat_supports_stopped_by_sw_breakpoint)
8221         (linux_nat_stopped_by_hw_breakpoint)
8222         (linux_nat_supports_stopped_by_hw_breakpoint, linux_nat_wait)
8223         (linux_nat_kill, linux_nat_mourn_inferior)
8224         (linux_nat_xfer_partial, linux_nat_thread_alive)
8225         (linux_nat_update_thread_list, linux_nat_pid_to_str)
8226         (linux_nat_thread_name, linux_child_pid_to_exec_file)
8227         (linux_child_static_tracepoint_markers_by_strid)
8228         (linux_nat_is_async_p, linux_nat_can_async_p)
8229         (linux_nat_supports_non_stop, linux_nat_always_non_stop_p)
8230         (linux_nat_supports_multi_process)
8231         (linux_nat_supports_disable_randomization, linux_nat_async)
8232         (linux_nat_stop, linux_nat_close, linux_nat_thread_address_space)
8233         (linux_nat_core_of_thread, linux_nat_filesystem_is_local)
8234         (linux_nat_fileio_open, linux_nat_fileio_readlink)
8235         (linux_nat_fileio_unlink, linux_nat_thread_events): Refactor as
8236         methods of linux_nat_target.
8237         (linux_nat_wait_1, linux_xfer_siginfo, linux_proc_xfer_partial)
8238         (linux_proc_xfer_spu, linux_nat_xfer_osdata): Remove target_ops
8239         parameter.
8240         (check_stopped_by_watchpoint): Adjust.
8241         (linux_xfer_partial): Delete.
8242         (linux_target_install_ops, linux_target, linux_nat_add_target):
8243         Delete.
8244         (linux_nat_target::linux_nat_target): New.
8245         * linux-nat.h: Include "inf-ptrace.h".
8246         (linux_nat_target): New.
8247         (linux_target, linux_target_install_ops, linux_nat_add_target):
8248         Delete function declarations.
8249         (linux_target): Declare global.
8250         * linux-thread-db.c (thread_db_target): New.
8251         (thread_db_target::thread_db_target): New.
8252         (thread_db_ops): Delete.
8253         (the_thread_db_target): New.
8254         (thread_db_detach, thread_db_wait, thread_db_mourn_inferior)
8255         (thread_db_update_thread_list, thread_db_pid_to_str)
8256         (thread_db_extra_thread_info)
8257         (thread_db_thread_handle_to_thread_info)
8258         (thread_db_get_thread_local_address, thread_db_get_ada_task_ptid)
8259         (thread_db_resume): Refactor as methods of thread_db_target.
8260         (init_thread_db_ops): Delete.
8261         (_initialize_thread_db): Remove reference to init_thread_db_ops.
8262         * x86-linux-nat.c: Don't include "linux-nat.h".
8263         (super_post_startup_inferior): Delete.
8264         (x86_linux_nat_target::~x86_linux_nat_target): New.
8265         (x86_linux_child_post_startup_inferior)
8266         (x86_linux_read_description, x86_linux_enable_btrace)
8267         (x86_linux_disable_btrace, x86_linux_teardown_btrace)
8268         (x86_linux_read_btrace, x86_linux_btrace_conf): Refactor as
8269         methods of x86_linux_nat_target.
8270         (x86_linux_create_target): Delete.  Bits folded ...
8271         (x86_linux_add_target): ... here.  Now takes a linux_nat_target
8272         pointer.
8273         * x86-linux-nat.h: Include "linux-nat.h" and "x86-nat.h".
8274         (x86_linux_nat_target): New class.
8275         (x86_linux_create_target): Delete.
8276         (x86_linux_add_target): Now takes a linux_nat_target pointer.
8277         * x86-nat.c (x86_insert_watchpoint, x86_remove_watchpoint)
8278         (x86_region_ok_for_watchpoint, x86_stopped_data_address)
8279         (x86_stopped_by_watchpoint, x86_insert_hw_breakpoint)
8280         (x86_remove_hw_breakpoint, x86_can_use_hw_breakpoint)
8281         (x86_stopped_by_hw_breakpoint): Remove target_ops parameter and
8282         make extern.
8283         (x86_use_watchpoints): Delete.
8284         * x86-nat.h: Include "breakpoint.h" and "target.h".
8285         (x86_use_watchpoints): Delete.
8286         (x86_can_use_hw_breakpoint, x86_region_ok_for_hw_watchpoint)
8287         (x86_stopped_by_watchpoint, x86_stopped_data_address)
8288         (x86_insert_watchpoint, x86_remove_watchpoint)
8289         (x86_insert_hw_breakpoint, x86_remove_hw_breakpoint)
8290         (x86_stopped_by_hw_breakpoint): New declarations.
8291         (x86_nat_target): New template class.
8292
8293         * ppc-linux-nat.c (ppc_linux_nat_target): New class.
8294         (the_ppc_linux_nat_target): New.
8295         (ppc_linux_fetch_inferior_registers)
8296         (ppc_linux_can_use_hw_breakpoint)
8297         (ppc_linux_region_ok_for_hw_watchpoint)
8298         (ppc_linux_ranged_break_num_registers)
8299         (ppc_linux_insert_hw_breakpoint, ppc_linux_remove_hw_breakpoint)
8300         (ppc_linux_insert_mask_watchpoint)
8301         (ppc_linux_remove_mask_watchpoint)
8302         (ppc_linux_can_accel_watchpoint_condition)
8303         (ppc_linux_insert_watchpoint, ppc_linux_remove_watchpoint)
8304         (ppc_linux_stopped_data_address, ppc_linux_stopped_by_watchpoint)
8305         (ppc_linux_watchpoint_addr_within_range)
8306         (ppc_linux_masked_watch_num_registers)
8307         (ppc_linux_store_inferior_registers, ppc_linux_auxv_parse)
8308         (ppc_linux_read_description): Refactor as methods of
8309         ppc_linux_nat_target.
8310         (_initialize_ppc_linux_nat): Adjust.  Set linux_target.
8311
8312         * procfs.c (procfs_xfer_partial): Delete forward declaration.
8313         (procfs_target): New class.
8314         (the_procfs_target): New.
8315         (procfs_target): Delete function.
8316         (procfs_auxv_parse, procfs_attach, procfs_detach)
8317         (procfs_fetch_registers, procfs_store_registers, procfs_wait)
8318         (procfs_xfer_partial, procfs_resume, procfs_pass_signals)
8319         (procfs_files_info, procfs_kill_inferior, procfs_mourn_inferior)
8320         (procfs_create_inferior, procfs_update_thread_list)
8321         (procfs_thread_alive, procfs_pid_to_str)
8322         (procfs_can_use_hw_breakpoint, procfs_stopped_by_watchpoint)
8323         (procfs_stopped_data_address, procfs_insert_watchpoint)
8324         (procfs_remove_watchpoint, procfs_region_ok_for_hw_watchpoint)
8325         (proc_find_memory_regions, procfs_info_proc)
8326         (procfs_make_note_section): Refactor as methods of procfs_target.
8327         (_initialize_procfs): Adjust.
8328         * sol-thread.c (sol_thread_target): New class.
8329         (sol_thread_ops): Now a sol_thread_target.
8330         (sol_thread_detach, sol_thread_resume, sol_thread_wait)
8331         (sol_thread_fetch_registers, sol_thread_store_registers)
8332         (sol_thread_xfer_partial, sol_thread_mourn_inferior)
8333         (sol_thread_alive, solaris_pid_to_str, sol_update_thread_list)
8334         (sol_get_ada_task_ptid): Refactor as methods of sol_thread_target.
8335         (init_sol_thread_ops): Delete.
8336         (_initialize_sol_thread): Adjust.  Remove references to
8337         init_sol_thread_ops and complete_target_initialization.
8338
8339         * windows-nat.c (windows_nat_target): New class.
8340         (windows_fetch_inferior_registers)
8341         (windows_store_inferior_registers, windows_resume, windows_wait)
8342         (windows_attach, windows_detach, windows_pid_to_exec_file)
8343         (windows_files_info, windows_create_inferior)
8344         (windows_mourn_inferior, windows_interrupt, windows_kill_inferior)
8345         (windows_close, windows_pid_to_str, windows_xfer_partial)
8346         (windows_get_tib_address, windows_get_ada_task_ptid)
8347         (windows_thread_name, windows_thread_alive): Refactor as
8348         windows_nat_target methods.
8349         (do_initial_windows_stuff): Adjust.
8350         (windows_target): Delete function.
8351         (_initialize_windows_nat): Adjust.
8352
8353         * darwin-nat.c (darwin_resume, darwin_wait_to, darwin_interrupt)
8354         (darwin_mourn_inferior, darwin_kill_inferior)
8355         (darwin_create_inferior, darwin_attach, darwin_detach)
8356         (darwin_pid_to_str, darwin_thread_alive, darwin_xfer_partial)
8357         (darwin_pid_to_exec_file, darwin_get_ada_task_ptid)
8358         (darwin_supports_multi_process): Refactor as darwin_nat_target
8359         methods.
8360         (darwin_resume_to, darwin_files_info): Delete.
8361         (_initialize_darwin_inferior): Rename to ...
8362         (_initialize_darwin_nat): ... this.  Adjust to C++ification.
8363         * darwin-nat.h: Include "inf-child.h".
8364         (darwin_nat_target): New class.
8365         (darwin_complete_target): Delete.
8366         * i386-darwin-nat.c (i386_darwin_nat_target): New class.
8367         (darwin_target): New.
8368         (i386_darwin_fetch_inferior_registers)
8369         (i386_darwin_store_inferior_registers): Refactor as methods of
8370         darwin_nat_target.
8371         (darwin_complete_target): Delete, with ...
8372         (_initialize_i386_darwin_nat): ... bits factored out here.
8373
8374         * alpha-linux-nat.c (alpha_linux_nat_target): New class.
8375         (the_alpha_linux_nat_target): New.
8376         (alpha_linux_register_u_offset): Refactor as
8377         alpha_linux_nat_target method.
8378         (_initialize_alpha_linux_nat): Adjust.
8379         * linux-nat-trad.c (inf_ptrace_register_u_offset): Delete.
8380         (inf_ptrace_fetch_register, inf_ptrace_fetch_registers)
8381         (inf_ptrace_store_register, inf_ptrace_store_registers): Refact as
8382         methods of linux_nat_trad_target.
8383         (linux_trad_target): Delete.
8384         * linux-nat-trad.h (linux_trad_target): Delete function.
8385         (linux_nat_trad_target): New class.
8386         * mips-linux-nat.c (mips_linux_nat_target): New class.
8387         (super_fetch_registers, super_store_registers, super_close):
8388         Delete.
8389         (the_mips_linux_nat_target): New.
8390         (mips64_linux_regsets_fetch_registers)
8391         (mips64_linux_regsets_store_registers)
8392         (mips64_linux_fetch_registers, mips64_linux_store_registers)
8393         (mips_linux_register_u_offset, mips_linux_read_description)
8394         (mips_linux_can_use_hw_breakpoint)
8395         (mips_linux_stopped_by_watchpoint)
8396         (mips_linux_stopped_data_address)
8397         (mips_linux_region_ok_for_hw_watchpoint)
8398         (mips_linux_insert_watchpoint, mips_linux_remove_watchpoint)
8399         (mips_linux_close): Refactor as methods of mips_linux_nat.
8400         (_initialize_mips_linux_nat): Adjust to C++ification.
8401
8402         * aix-thread.c (aix_thread_target): New class.
8403         (aix_thread_ops): Now an aix_thread_target.
8404         (aix_thread_detach, aix_thread_resume, aix_thread_wait)
8405         (aix_thread_fetch_registers, aix_thread_store_registers)
8406         (aix_thread_xfer_partial, aix_thread_mourn_inferior)
8407         (aix_thread_thread_alive, aix_thread_pid_to_str)
8408         (aix_thread_extra_thread_info, aix_thread_get_ada_task_ptid):
8409         Refactor as methods of aix_thread_target.
8410         (init_aix_thread_ops): Delete.
8411         (_initialize_aix_thread): Remove references to init_aix_thread_ops
8412         and complete_target_initialization.
8413         * rs6000-nat.c (rs6000_xfer_shared_libraries): Delete.
8414         (rs6000_nat_target): New class.
8415         (the_rs6000_nat_target): New.
8416         (rs6000_fetch_inferior_registers, rs6000_store_inferior_registers)
8417         (rs6000_xfer_partial, rs6000_wait, rs6000_create_inferior)
8418         (rs6000_xfer_shared_libraries): Refactor as rs6000_nat_target methods.
8419         (super_create_inferior): Delete.
8420         (_initialize_rs6000_nat): Adjust to C++ification.
8421
8422         * arm-linux-nat.c (arm_linux_nat_target): New class.
8423         (the_arm_linux_nat_target): New.
8424         (arm_linux_fetch_inferior_registers)
8425         (arm_linux_store_inferior_registers, arm_linux_read_description)
8426         (arm_linux_can_use_hw_breakpoint, arm_linux_insert_hw_breakpoint)
8427         (arm_linux_remove_hw_breakpoint)
8428         (arm_linux_region_ok_for_hw_watchpoint)
8429         (arm_linux_insert_watchpoint, arm_linux_remove_watchpoint)
8430         (arm_linux_stopped_data_address, arm_linux_stopped_by_watchpoint)
8431         (arm_linux_watchpoint_addr_within_range): Refactor as methods of
8432         arm_linux_nat_target.
8433         (_initialize_arm_linux_nat): Adjust to C++ification.
8434
8435         * aarch64-linux-nat.c (aarch64_linux_nat_target): New class.
8436         (the_aarch64_linux_nat_target): New.
8437         (aarch64_linux_fetch_inferior_registers)
8438         (aarch64_linux_store_inferior_registers)
8439         (aarch64_linux_child_post_startup_inferior)
8440         (aarch64_linux_read_description)
8441         (aarch64_linux_can_use_hw_breakpoint)
8442         (aarch64_linux_insert_hw_breakpoint)
8443         (aarch64_linux_remove_hw_breakpoint)
8444         (aarch64_linux_insert_watchpoint, aarch64_linux_remove_watchpoint)
8445         (aarch64_linux_region_ok_for_hw_watchpoint)
8446         (aarch64_linux_stopped_data_address)
8447         (aarch64_linux_stopped_by_watchpoint)
8448         (aarch64_linux_watchpoint_addr_within_range)
8449         (aarch64_linux_can_do_single_step): Refactor as methods of
8450         aarch64_linux_nat_target.
8451         (super_post_startup_inferior): Delete.
8452         (_initialize_aarch64_linux_nat): Adjust to C++ification.
8453
8454         * hppa-linux-nat.c (hppa_linux_nat_target): New class.
8455         (the_hppa_linux_nat_target): New.
8456         (hppa_linux_fetch_inferior_registers)
8457         (hppa_linux_store_inferior_registers): Refactor as methods of
8458         hppa_linux_nat_target.
8459         (_initialize_hppa_linux_nat): Adjust to C++ification.
8460
8461         * ia64-linux-nat.c (ia64_linux_nat_target): New class.
8462         (the_ia64_linux_nat_target): New.
8463         (ia64_linux_insert_watchpoint, ia64_linux_remove_watchpoint)
8464         (ia64_linux_stopped_data_address)
8465         (ia64_linux_stopped_by_watchpoint, ia64_linux_fetch_registers)
8466         (ia64_linux_store_registers, ia64_linux_xfer_partial): Refactor as
8467         ia64_linux_nat_target methods.
8468         (super_xfer_partial): Delete.
8469         (_initialize_ia64_linux_nat): Adjust to C++ification.
8470
8471         * m32r-linux-nat.c (m32r_linux_nat_target): New class.
8472         (the_m32r_linux_nat_target): New.
8473         (m32r_linux_fetch_inferior_registers)
8474         (m32r_linux_store_inferior_registers): Refactor as
8475         m32r_linux_nat_target methods.
8476         (_initialize_m32r_linux_nat): Adjust to C++ification.
8477
8478         * m68k-linux-nat.c (m68k_linux_nat_target): New class.
8479         (the_m68k_linux_nat_target): New.
8480         (m68k_linux_fetch_inferior_registers)
8481         (m68k_linux_store_inferior_registers): Refactor as
8482         m68k_linux_nat_target methods.
8483         (_initialize_m68k_linux_nat): Adjust to C++ification.
8484
8485         * s390-linux-nat.c (s390_linux_nat_target): New class.
8486         (the_s390_linux_nat_target): New.
8487         (s390_linux_fetch_inferior_registers)
8488         (s390_linux_store_inferior_registers, s390_stopped_by_watchpoint)
8489         (s390_insert_watchpoint, s390_remove_watchpoint)
8490         (s390_can_use_hw_breakpoint, s390_insert_hw_breakpoint)
8491         (s390_remove_hw_breakpoint, s390_region_ok_for_hw_watchpoint)
8492         (s390_auxv_parse, s390_read_description): Refactor as methods of
8493         s390_linux_nat_target.
8494         (_initialize_s390_nat): Adjust to C++ification.
8495
8496         * sparc-linux-nat.c (sparc_linux_nat_target): New class.
8497         (the_sparc_linux_nat_target): New.
8498         (_initialize_sparc_linux_nat): Adjust to C++ification.
8499         * sparc-nat.c (sparc_fetch_inferior_registers)
8500         (sparc_store_inferior_registers): Remove target_ops parameter.
8501         * sparc-nat.h (sparc_fetch_inferior_registers)
8502         (sparc_store_inferior_registers): Remove target_ops parameter.
8503         * sparc64-linux-nat.c (sparc64_linux_nat_target): New class.
8504         (the_sparc64_linux_nat_target): New.
8505         (_initialize_sparc64_linux_nat): Adjust to C++ification.
8506
8507         * spu-linux-nat.c (spu_linux_nat_target): New class.
8508         (the_spu_linux_nat_target): New.
8509         (spu_child_post_startup_inferior, spu_child_post_attach)
8510         (spu_child_wait, spu_fetch_inferior_registers)
8511         (spu_store_inferior_registers, spu_xfer_partial)
8512         (spu_can_use_hw_breakpoint): Refactor as spu_linux_nat_target
8513         methods.
8514         (_initialize_spu_nat): Adjust to C++ification.
8515
8516         * tilegx-linux-nat.c (tilegx_linux_nat_target): New class.
8517         (the_tilegx_linux_nat_target): New.
8518         (fetch_inferior_registers, store_inferior_registers):
8519         Refactor as methods.
8520         (_initialize_tile_linux_nat): Adjust to C++ification.
8521
8522         * xtensa-linux-nat.c (xtensa_linux_nat_target): New class.
8523         (the_xtensa_linux_nat_target): New.
8524         (xtensa_linux_fetch_inferior_registers)
8525         (xtensa_linux_store_inferior_registers): Refactor as
8526         xtensa_linux_nat_target methods.
8527         (_initialize_xtensa_linux_nat): Adjust to C++ification.
8528
8529         * fbsd-nat.c (USE_SIGTRAP_SIGINFO): Delete.
8530         (fbsd_pid_to_exec_file, fbsd_find_memory_regions)
8531         (fbsd_find_memory_regions, fbsd_info_proc, fbsd_xfer_partial)
8532         (fbsd_thread_alive, fbsd_pid_to_str, fbsd_thread_name)
8533         (fbsd_update_thread_list, fbsd_resume, fbsd_wait)
8534         (fbsd_stopped_by_sw_breakpoint)
8535         (fbsd_supports_stopped_by_sw_breakpoint, fbsd_follow_fork)
8536         (fbsd_insert_fork_catchpoint, fbsd_remove_fork_catchpoint)
8537         (fbsd_insert_vfork_catchpoint, fbsd_remove_vfork_catchpoint)
8538         (fbsd_post_startup_inferior, fbsd_post_attach)
8539         (fbsd_insert_exec_catchpoint, fbsd_remove_exec_catchpoint)
8540         (fbsd_set_syscall_catchpoint)
8541         (super_xfer_partial, super_resume, super_wait)
8542         (fbsd_supports_stopped_by_hw_breakpoint): Delete.
8543         (fbsd_handle_debug_trap): Remove target_ops parameter.
8544         (fbsd_nat_add_target): Delete.
8545         * fbsd-nat.h: Include "inf-ptrace.h".
8546         (fbsd_nat_add_target): Delete.
8547         (USE_SIGTRAP_SIGINFO): Define.
8548         (fbsd_nat_target): New class.
8549
8550         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers)
8551         (amd64bsd_store_inferior_registers): Remove target_ops parameter.
8552         (amd64bsd_target): Delete.
8553         * amd64-bsd-nat.h: New file.
8554         * amd64-fbsd-nat.c: Include "amd64-bsd-nat.h" instead of
8555         "x86-bsd-nat.h".
8556         (amd64_fbsd_nat_target): New class.
8557         (the_amd64_fbsd_nat_target): New.
8558         (amd64fbsd_read_description): Refactor as method of
8559         amd64_fbsd_nat_target.
8560         (amd64_fbsd_nat_target::supports_stopped_by_hw_breakpoint): New.
8561         (_initialize_amd64fbsd_nat): Adjust to C++ification.
8562         * amd64-nat.h (amd64bsd_target): Delete function declaration.
8563         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers)
8564         (i386bsd_store_inferior_registers): Remove target_ops parameter.
8565         (i386bsd_target): Delete.
8566         * i386-bsd-nat.h (i386bsd_target): Delete function declaration.
8567         (i386bsd_fetch_inferior_registers)
8568         (i386bsd_store_inferior_registers): Declare.
8569         (i386_bsd_nat_target): New class.
8570         * i386-fbsd-nat.c (i386_fbsd_nat_target): New class.
8571         (the_i386_fbsd_nat_target): New.
8572         (i386fbsd_resume, i386fbsd_read_description): Refactor as
8573         i386_fbsd_nat_target methods.
8574         (i386_fbsd_nat_target::supports_stopped_by_hw_breakpoint): New.
8575         (_initialize_i386fbsd_nat): Adjust to C++ification.
8576         * x86-bsd-nat.c (super_mourn_inferior): Delete.
8577         (x86bsd_mourn_inferior, x86bsd_target): Delete.
8578         (_initialize_x86_bsd_nat): Adjust to C++ification.
8579         * x86-bsd-nat.h: Include "x86-nat.h".
8580         (x86bsd_target): Delete declaration.
8581         (x86bsd_nat_target): New class.
8582
8583         * aarch64-fbsd-nat.c (aarch64_fbsd_nat_target): New class.
8584         (the_aarch64_fbsd_nat_target): New.
8585         (aarch64_fbsd_fetch_inferior_registers)
8586         (aarch64_fbsd_store_inferior_registers): Refactor as methods of
8587         aarch64_fbsd_nat_target.
8588         (_initialize_aarch64_fbsd_nat): Adjust to C++ification.
8589         * alpha-bsd-nat.c (alpha_bsd_nat_target): New class.
8590         (the_alpha_bsd_nat_target): New.
8591         (alphabsd_fetch_inferior_registers)
8592         (alphabsd_store_inferior_registers): Refactor as
8593         alpha_bsd_nat_target methods.
8594         (_initialize_alphabsd_nat): Refactor as methods of
8595         alpha_bsd_nat_target.
8596         * amd64-nbsd-nat.c: Include "amd64-bsd-nat.h".
8597         (the_amd64_nbsd_nat_target): New.
8598         (_initialize_amd64nbsd_nat): Adjust to C++ification.
8599         * amd64-obsd-nat.c: Include "amd64-bsd-nat.h".
8600         (the_amd64_obsd_nat_target): New.
8601         (_initialize_amd64obsd_nat): Adjust to C++ification.
8602         * arm-fbsd-nat.c (arm_fbsd_nat_target): New.
8603         (the_arm_fbsd_nat_target): New.
8604         (arm_fbsd_fetch_inferior_registers)
8605         (arm_fbsd_store_inferior_registers, arm_fbsd_read_description):
8606         (_initialize_arm_fbsd_nat): Refactor as methods of
8607         arm_fbsd_nat_target.
8608         (_initialize_arm_fbsd_nat): Adjust to C++ification.
8609         * arm-nbsd-nat.c (arm_netbsd_nat_target): New class.
8610         (the_arm_netbsd_nat_target): New.
8611         (armnbsd_fetch_registers, armnbsd_store_registers): Refactor as
8612         arm_netbsd_nat_target.
8613         (_initialize_arm_netbsd_nat): Adjust to C++ification.
8614         * hppa-nbsd-nat.c (hppa_nbsd_nat_target): New class.
8615         (the_hppa_nbsd_nat_target): New.
8616         (hppanbsd_fetch_registers, hppanbsd_store_registers): Refactor as
8617         hppa_nbsd_nat_target methods.
8618         (_initialize_hppanbsd_nat): Adjust to C++ification.
8619         * hppa-obsd-nat.c (hppa_obsd_nat_target): New class.
8620         (the_hppa_obsd_nat_target): New.
8621         (hppaobsd_fetch_registers, hppaobsd_store_registers): Refactor as
8622         methods of hppa_obsd_nat_target.
8623         (_initialize_hppaobsd_nat): Adjust to C++ification.  Use
8624         add_target.
8625         * i386-nbsd-nat.c (the_i386_nbsd_nat_target): New.
8626         (_initialize_i386nbsd_nat): Adjust to C++ification.  Use
8627         add_target.
8628         * i386-obsd-nat.c (the_i386_obsd_nat_target): New.
8629         (_initialize_i386obsd_nat): Use add_target.
8630         * m68k-bsd-nat.c (m68k_bsd_nat_target): New class.
8631         (the_m68k_bsd_nat_target): New.
8632         (m68kbsd_fetch_inferior_registers)
8633         (m68kbsd_store_inferior_registers): Refactor as methods of
8634         m68k_bsd_nat_target.
8635         (_initialize_m68kbsd_nat): Adjust to C++ification.
8636         * mips-fbsd-nat.c (mips_fbsd_nat_target): New class.
8637         (the_mips_fbsd_nat_target): New.
8638         (mips_fbsd_fetch_inferior_registers)
8639         (mips_fbsd_store_inferior_registers): Refactor as methods of
8640         mips_fbsd_nat_target.
8641         (_initialize_mips_fbsd_nat): Adjust to C++ification.  Use
8642         add_target.
8643         * mips-nbsd-nat.c (mips_nbsd_nat_target): New class.
8644         (the_mips_nbsd_nat_target): New.
8645         (mipsnbsd_fetch_inferior_registers)
8646         (mipsnbsd_store_inferior_registers): Refactor as methods of
8647         mips_nbsd_nat_target.
8648         (_initialize_mipsnbsd_nat): Adjust to C++ification.
8649         * mips64-obsd-nat.c (mips64_obsd_nat_target): New class.
8650         (the_mips64_obsd_nat_target): New.
8651         (mips64obsd_fetch_inferior_registers)
8652         (mips64obsd_store_inferior_registers): Refactor as methods of
8653         mips64_obsd_nat_target.
8654         (_initialize_mips64obsd_nat): Adjust to C++ification.  Use
8655         add_target.
8656         * nbsd-nat.c (nbsd_pid_to_exec_file): Refactor as method of
8657         nbsd_nat_target.
8658         * nbsd-nat.h: Include "inf-ptrace.h".
8659         (nbsd_nat_target): New class.
8660         * obsd-nat.c (obsd_pid_to_str, obsd_update_thread_list)
8661         (obsd_wait): Refactor as methods of obsd_nat_target.
8662         (obsd_add_target): Delete.
8663         * obsd-nat.h: Include "inf-ptrace.h".
8664         (obsd_nat_target): New class.
8665         * ppc-fbsd-nat.c (ppc_fbsd_nat_target): New class.
8666         (the_ppc_fbsd_nat_target): New.
8667         (ppcfbsd_fetch_inferior_registers)
8668         (ppcfbsd_store_inferior_registers): Refactor as methods of
8669         ppc_fbsd_nat_target.
8670         (_initialize_ppcfbsd_nat): Adjust to C++ification.  Use
8671         add_target.
8672         * ppc-nbsd-nat.c (ppc_nbsd_nat_target): New class.
8673         (the_ppc_nbsd_nat_target): New.
8674         (ppcnbsd_fetch_inferior_registers)
8675         (ppcnbsd_store_inferior_registers): Refactor as methods of
8676         ppc_nbsd_nat_target.
8677         (_initialize_ppcnbsd_nat): Adjust to C++ification.
8678         * ppc-obsd-nat.c (ppc_obsd_nat_target): New class.
8679         (the_ppc_obsd_nat_target): New.
8680         (ppcobsd_fetch_registers, ppcobsd_store_registers): Refactor as
8681         methods of ppc_obsd_nat_target.
8682         (_initialize_ppcobsd_nat): Adjust to C++ification.  Use
8683         add_target.
8684         * sh-nbsd-nat.c (sh_nbsd_nat_target): New class.
8685         (the_sh_nbsd_nat_target): New.
8686         (shnbsd_fetch_inferior_registers)
8687         (shnbsd_store_inferior_registers): Refactor as methods of
8688         sh_nbsd_nat_target.
8689         (_initialize_shnbsd_nat): Adjust to C++ification.
8690         * sparc-nat.c (sparc_xfer_wcookie): Make extern.
8691         (inf_ptrace_xfer_partial): Delete.
8692         (sparc_xfer_partial, sparc_target): Delete.
8693         * sparc-nat.h (sparc_fetch_inferior_registers)
8694         (sparc_store_inferior_registers, sparc_xfer_wcookie): Declare.
8695         (sparc_target): Delete function declaration.
8696         (sparc_target): New template class.
8697         * sparc-nbsd-nat.c (the_sparc_nbsd_nat_target): New.
8698         (_initialize_sparcnbsd_nat): Adjust to C++ification.
8699         * sparc64-fbsd-nat.c (the_sparc64_fbsd_nat_target): New.
8700         (_initialize_sparc64fbsd_nat): Adjust to C++ification.  Use
8701         add_target.
8702         * sparc64-nbsd-nat.c (the_sparc64_nbsd_nat_target): New.
8703         (_initialize_sparc64nbsd_nat): Adjust to C++ification.
8704         * sparc64-obsd-nat.c (the_sparc64_obsd_nat_target): New.
8705         (_initialize_sparc64obsd_nat): Adjust to C++ification.  Use
8706         add_target.
8707         * vax-bsd-nat.c (vax_bsd_nat_target): New class.
8708         (the_vax_bsd_nat_target): New.
8709         (vaxbsd_fetch_inferior_registers)
8710         (vaxbsd_store_inferior_registers): Refactor as vax_bsd_nat_target
8711         methods.
8712         (_initialize_vaxbsd_nat): Adjust to C++ification.
8713
8714         * bsd-kvm.c (bsd_kvm_target): New class.
8715         (bsd_kvm_ops): Now a bsd_kvm_target.
8716         (bsd_kvm_open, bsd_kvm_close, bsd_kvm_xfer_partial)
8717         (bsd_kvm_files_info, bsd_kvm_fetch_registers)
8718         (bsd_kvm_thread_alive, bsd_kvm_pid_to_str): Refactor as methods of
8719         bsd_kvm_target.
8720         (bsd_kvm_return_one): Delete.
8721         (bsd_kvm_add_target): Adjust to C++ification.
8722
8723         * nto-procfs.c (nto_procfs_target, nto_procfs_target_native)
8724         (nto_procfs_target_procfs): New classes.
8725         (procfs_open_1, procfs_thread_alive, procfs_update_thread_list)
8726         (procfs_files_info, procfs_pid_to_exec_file, procfs_attach)
8727         (procfs_post_attach, procfs_wait, procfs_fetch_registers)
8728         (procfs_xfer_partial, procfs_detach, procfs_insert_breakpoint)
8729         (procfs_remove_breakpoint, procfs_insert_hw_breakpoint)
8730         (procfs_remove_hw_breakpoint, procfs_resume)
8731         (procfs_mourn_inferior, procfs_create_inferior, procfs_interrupt)
8732         (procfs_kill_inferior, procfs_store_registers)
8733         (procfs_pass_signals, procfs_pid_to_str, procfs_can_run): Refactor
8734         as methods of nto_procfs_target.
8735         (nto_procfs_ops): Now an nto_procfs_target_procfs.
8736         (nto_native_ops): Delete.
8737         (procfs_open, procfs_native_open): Delete.
8738         (nto_native_ops): Now an nto_procfs_target_native.
8739         (init_procfs_targets): Adjust to C++ification.
8740         (procfs_can_use_hw_breakpoint, procfs_remove_hw_watchpoint)
8741         (procfs_insert_hw_watchpoint, procfs_stopped_by_watchpoint):
8742         Refactor as methods of nto_procfs_target.
8743
8744         * go32-nat.c (go32_nat_target): New class.
8745         (the_go32_nat_target): New.
8746         (go32_attach, go32_resume, go32_wait, go32_fetch_registers)
8747         (go32_store_registers, go32_xfer_partial, go32_files_info)
8748         (go32_kill_inferior, go32_create_inferior, go32_mourn_inferior)
8749         (go32_terminal_init, go32_terminal_info, go32_terminal_inferior)
8750         (go32_terminal_ours, go32_pass_ctrlc, go32_thread_alive)
8751         (go32_pid_to_str): Refactor as methods of go32_nat_target.
8752         (go32_target): Delete.
8753         (_initialize_go32_nat): Adjust to C++ification.
8754
8755         * gnu-nat.c (gnu_wait, gnu_resume, gnu_kill_inferior)
8756         (gnu_mourn_inferior, gnu_create_inferior, gnu_attach, gnu_detach)
8757         (gnu_stop, gnu_thread_alive, gnu_xfer_partial)
8758         (gnu_find_memory_regions, gnu_pid_to_str): Refactor as methods of
8759         gnu_nat_target.
8760         (gnu_target): Delete.
8761         * gnu-nat.h (gnu_target): Delete.
8762         (gnu_nat_target): New class.
8763         * i386-gnu-nat.c (gnu_base_target): New.
8764         (i386_gnu_nat_target): New class.
8765         (the_i386_gnu_nat_target): New.
8766         (_initialize_i386gnu_nat): Adjust to C++ification.
8767
8768 2018-05-02  Pedro Alves  <palves@redhat.com>
8769
8770         * bfd-target.c (target_bfd_xclose): Rename to ...
8771         (target_bfd_close): ... this.
8772         (target_bfd_reopen): Adjust.
8773         * target.c (target_close): Remove references to to_xclose.
8774         * target.h (target_ops::to_xclose): Delete.
8775         (target_ops::to_close): Update comments.
8776
8777 2018-05-02  Pedro Alves  <palves@redhat.com>
8778
8779         * alpha-linux-nat.c: Include "linux-nat-trad.h" instead of
8780         "linux-nat.h".
8781         * configure.nat (alpha-linux, linux-mips): Add linux-nat-trad.o.
8782         * inf-ptrace.c (inf_ptrace_register_u_offset)
8783         (inf_ptrace_fetch_register, inf_ptrace_fetch_registers)
8784         (inf_ptrace_store_register, inf_ptrace_store_registers)
8785         (inf_ptrace_trad_target): Move to ...
8786         * linux-nat-trad.c: ... this new file.
8787         * linux-nat-trad.h: New file.
8788         * linux-nat.c (linux_target_install_ops): Make extern.
8789         (linux_trad_target): Delete.
8790         * linux-nat.h (linux_trad_target): Delete declaration.
8791         (linux_target_install_ops): Declare.
8792         * mips-linux-nat.c: Include "linux-nat-trad.h" instead of
8793         "linux-nat.h".
8794
8795 2018-05-02  Pedro Alves  <palves@redhat.com>
8796
8797         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Don't call
8798         procfs_target/add_target here.
8799         * procfs.c (procfs_target): Make static.
8800         (_initialize_procfs): Call add_target here.
8801         * procfs.h (struct target_ops): Remove forward declaration.
8802         (procfs_target): Remove declaration.
8803         * sparc-sol2-nat.c (_initialize_sparc_sol2_nat): Delete.
8804
8805 2018-05-02  Pedro Alves  <palves@redhat.com>
8806
8807         * procfs.c (procfs_stopped_by_watchpoint)
8808         (procfs_insert_watchpoint, procfs_remove_watchpoint)
8809         (procfs_region_ok_for_hw_watchpoint, procfs_stopped_data_address):
8810         Forward declare.
8811         (procfs_use_watchpoints): Delete, move contents...
8812         (procfs_target): ... here.
8813         * procfs.h (procfs_use_watchpoints): Delete declaration.
8814         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Don't call
8815         procfs_use_watchpoints.
8816         * sparc-sol2-nat.c (_initialize_sparc_sol2_nat): Don't call
8817         procfs_use_watchpoints.
8818
8819 2018-05-02  Tom Tromey  <tom@tromey.com>
8820
8821         PR python/20084:
8822         * python/python.c (gdbpy_parameter_value): Handle var_zuinteger
8823         and var_zuinteger_unlimited.
8824         * python/py-param.c (struct parm_constant): Add PARAM_ZUINTEGER
8825         and PARAM_ZUINTEGER_UNLIMITED.
8826         (set_parameter_value): Handle var_zuinteger and
8827         var_zuinteger_unlimited.
8828         (add_setshow_generic): Likewise.
8829         (parmpy_init): Likewise.
8830
8831 2018-04-28  Dan Robertson  <danlrobertson89@gmail.com>
8832
8833         PR rust/23124
8834         * gdb/rust-exp.y (convert_params_to_types): Ensure that the params
8835         pointer is not null before dereferencing it.
8836
8837 2018-04-30  Tom Tromey  <tom@tromey.com>
8838
8839         * darwin-nat-info.c (darwin_debug_regions_recurse): Remove use of
8840         is_mi_like_p.
8841
8842 2018-04-30  Tom Tromey  <tom@tromey.com>
8843
8844         * breakpoint.c (mention): Remove use of is_mi_like_p.
8845         (print_mention_ranged_breakpoint): Likewise.
8846         * break-catch-throw.c (print_it_exception_catchpoint): Remove use
8847         of is_mi_like_p.
8848
8849 2018-04-30  Tom Tromey  <tom@tromey.com>
8850
8851         * tracepoint.c (tvariables_info_1): Remove use of is_mi_like_p.
8852
8853 2018-04-30  Tom Tromey  <tom@tromey.com>
8854
8855         * spu-tdep.c (info_spu_mailbox_list, info_spu_dma_cmdlist)
8856         (info_spu_event_command): Remove some uses of is_mi_like_p.
8857
8858 2018-04-30  Tom Tromey  <tom@tromey.com>
8859
8860         * python/py-framefilter.c (py_print_single_arg)
8861         (enumerate_locals, py_print_args, py_print_frame): Remove some
8862         uses of is_mi_like_p.
8863
8864 2018-04-30  Tom Tromey  <tom@tromey.com>
8865
8866         * ui-out.c: Update.
8867         * cli-out.h (cli_ui_out::do_is_mi_like_p): Update.
8868         * ui-out.h (ui_out::is_mi_like_p): Now const.
8869         (ui_out::do_is_mi_like_p): Now const.
8870         * mi/mi-out.h (mi_ui_out::do_is_mi_like_p): Update.
8871
8872 2018-04-30  Tom Tromey  <tom@tromey.com>
8873
8874         * varobj.c (varobj_set_visualizer): Use new_reference.
8875         * python/python.c (gdbpy_decode_line): Use new_reference.
8876         * python/py-cmd.c (cmdpy_function, cmdpy_completer_helper): Use
8877         new_reference.
8878
8879 2018-04-30  Tom Tromey  <tom@tromey.com>
8880
8881         * varobj.c (install_new_value): Use new_reference.
8882         * value.h (value_incref): Return void.  Swap intro comment with
8883         value_decref.
8884         * value.c (set_value_parent): Use new_reference.
8885         (value_incref): Return void.  Update intro comment.
8886         (release_value): Use new_reference.
8887         * dwarf2loc.c (dwarf2_evaluate_loc_desc_full): Use new_reference.
8888
8889 2018-04-30  Tom Tromey  <tom@tromey.com>
8890
8891         * symfile-mem.c (symbol_file_add_from_memory): Use new_reference.
8892         * gdb_bfd.h (new_bfd_ref): Remove.
8893         (gdb_bfd_open): Update comment.
8894         * gdb_bfd.c (gdb_bfd_open, gdb_bfd_fopen, gdb_bfd_openr)
8895         (gdb_bfd_openw, gdb_bfd_openr_iovec, gdb_bfd_record_inclusion)
8896         (gdb_bfd_fdopenr): Use new_reference.
8897         * exec.c (exec_file_attach): Use new_reference.
8898
8899 2018-04-30  Tom Tromey  <tom@tromey.com>
8900
8901         * common/gdb_ref_ptr.h (ref_ptr::new_reference): New static
8902         method.
8903
8904 2018-04-30  Tom Tromey  <tom@tromey.com>
8905
8906         * jit.c (jit_read_code_entry): Use type_align.
8907         * i386-tdep.c (i386_gdbarch_init): Don't call
8908         set_gdbarch_long_long_align_bit.
8909         * gdbarch.sh: Remove long_long_align_bit.
8910         * gdbarch.c, gdbarch.h: Rebuild.
8911         * arc-tdep.c (arc_type_align): New function.
8912         (arc_gdbarch_init): Use arc_type_align.  Don't call
8913         set_gdbarch_long_long_align_bit.
8914
8915 2018-04-30  Tom Tromey  <tom@tromey.com>
8916
8917         * rust-lang.c (rust_type_alignment): Remove.
8918         (rust_composite_type): Use type_align.
8919
8920 2018-04-30  Tom Tromey  <tom@tromey.com>
8921
8922         * NEWS: Mention Type.align.
8923         * python/py-type.c (typy_get_alignof): New function.
8924         (type_object_getset): Add "alignof".
8925
8926 2018-04-30  Tom Tromey  <tom@tromey.com>
8927
8928         PR exp/17095:
8929         * NEWS: Update.
8930         * std-operator.def (UNOP_ALIGNOF): New operator.
8931         * expprint.c (dump_subexp_body_standard) <case UNOP_ALIGNOF>:
8932         New.
8933         * eval.c (evaluate_subexp_standard) <case UNOP_ALIGNOF>: New.
8934         * c-lang.c (c_op_print_tab): Add alignof.
8935         * c-exp.y (ALIGNOF): New token.
8936         (exp): Add "ALIGNOF" production.
8937         (ident_tokens): Add _Alignof and alignof.
8938
8939 2018-04-30  Tom Tromey  <tom@tromey.com>
8940
8941         * i386-tdep.c (i386_type_align): New function.
8942         (i386_gdbarch_init): Update.
8943         * gdbarch.sh (type_align): New method.
8944         * gdbarch.c, gdbarch.h: Rebuild.
8945         * arch-utils.h (default_type_align): Declare.
8946         * arch-utils.c (default_type_align): New function.
8947         * gdbtypes.h (TYPE_ALIGN_BITS): New define.
8948         (struct type) <align_log2>: New field.
8949         <instance_flags>: Now a bitfield.
8950         (TYPE_RAW_ALIGN): New macro.
8951         (type_align, type_raw_align, set_type_align): Declare.
8952         * gdbtypes.c (type_align, type_raw_align, set_type_align): New
8953         functions.
8954         * dwarf2read.c (quirk_rust_enum): Set type alignment.
8955         (get_alignment, maybe_set_alignment): New functions.
8956         (read_structure_type, read_enumeration_type, read_array_type)
8957         (read_set_type, read_tag_pointer_type, read_tag_reference_type)
8958         (read_subrange_type, read_base_type): Set type alignment.
8959
8960 2018-04-30  Simon Marchi  <simon.marchi@ericsson.com>
8961
8962         * dwarf2read.c (read_index_from_section): Use bool.
8963
8964 2018-04-29  Fabian Groffen  <grobian@gentoo.org>
8965
8966         PR gdb/22950
8967         * proc-events.c (init_syscall_table): Guard usage os SYS_uuidsys
8968         with #ifdef.
8969
8970 2018-04-29  John Reiser  <jreiser@BitWagon.com>
8971
8972         PR build/22873
8973         * gdb/Makefile.in: (.c:.l, .c:.y): Write the target only in the
8974         last step, and do it atomically.
8975
8976 2018-04-27  Alexandre Oliva  <aoliva@redhat.com>
8977
8978         * compile/compile-c-types.c (convert_int, convert_float):
8979         Update for C FE v1.
8980
8981 2018-04-27  Tom Tromey  <tom@tromey.com>
8982
8983         PR rust/22545:
8984         * rust-lang.c (rust_inclusive_range_type_p): New function.
8985         (rust_range): Handle inclusive ranges.
8986         (rust_compute_range): Likewise.
8987         * rust-exp.y (struct rust_op) <inclusive>: New field.
8988         (DOTDOTEQ): New constant.
8989         (range_expr): Add "..=" productions.
8990         (operator_tokens): Add "..=" token.
8991         (ast_range): Add "inclusive" parameter.
8992         (convert_ast_to_expression) <case OP_RANGE>: Handle inclusive
8993         ranges.
8994         * parse.c (operator_length_standard) <case OP_RANGE>: Handle new
8995         bounds values.
8996         * expression.h (enum range_type) <NONE_BOUND_DEFAULT_EXCLUSIVE,
8997         LOW_BOUND_DEFAULT_EXCLUSIVE>: New constants.
8998         Update comments.
8999         * expprint.c (print_subexp_standard): Handle new bounds values.
9000         (dump_subexp_body_standard): Likewise.
9001
9002 2018-04-27  Tom Tromey  <tom@tromey.com>
9003
9004         * configure: Rebuild.
9005         * warning.m4 (AM_GDB_WARNINGS): Add -Wsuggest-override.
9006         * dwarf2loc.c (class dwarf_evaluate_loc_desc): Use "override", not
9007         "OVERRIDE".
9008         (class symbol_needs_eval_context): Likewise.
9009         * dwarf2read.c (mock_mapped_index::symbol_name_count)
9010         (mock_mapped_index::symbol_name_at): Use "override".  Remove
9011         "virtual".
9012         * dwarf2-frame.c (dwarf_expr_executor::get_addr_index): Use
9013         "override".
9014         (class dwarf_expr_executor): Use "override", not "OVERRIDE".
9015         * aarch64-tdep.c (instruction_reader::read): Use "override".
9016         (instruction_reader_test::read): Likewise.
9017         * arm-tdep.c (instruction_reader::read): Use "override".
9018         (instruction_reader_thumb::read): Likewise.
9019
9020 2018-04-26  Andrzej Kaczmarek  <andrzej.kaczmarek@codecoup.pl>
9021
9022         PR remote/9665
9023         * remote.c (send_g_packet): Use putpkt/getpkt/packet_check_result
9024         instead of remote_send.
9025         (remote_send): Remove.
9026
9027 2018-04-26  Pedro Alves  <palves@redhat.com>
9028
9029         * elfread.c (elf_gnu_ifunc_resolver_return_stop): Use
9030         find_function_start_sal instead of find_pc_line.
9031
9032 2018-04-26  Pedro Alves  <palves@redhat.com>
9033
9034         * breakpoint.c (set_breakpoint_location_function): Handle
9035         mst_data_gnu_ifunc.
9036         * c-exp.y (variable production): Handle mst_data_gnu_ifunc.
9037         * elfread.c (elf_symtab_read): Give data symbols with
9038         BSF_GNU_INDIRECT_FUNCTION set mst_data_gnu_ifunc type.
9039         (elf_rel_plt_read): Update comment.
9040         * linespec.c (convert_linespec_to_sals): Handle
9041         mst_data_gnu_ifunc.
9042         (minsym_found): Handle mst_data_gnu_ifunc.
9043         * minsyms.c (msymbol_is_function, minimal_symbol_reader::record)
9044         (find_solib_trampoline_target): Handle mst_data_gnu_ifunc.
9045         * parse.c (find_minsym_type_and_address): Handle
9046         mst_data_gnu_ifunc.
9047         * symmisc.c (dump_msymbols): Handle mst_data_gnu_ifunc.
9048         * symtab.c (find_gnu_ifunc): Handle mst_data_gnu_ifunc.
9049         * symtab.h (minimal_symbol_type) <mst_text_gnu_ifunc>: Update
9050         comment.
9051         <mst_data_gnu_ifunc>: New enumerator.
9052
9053 2018-04-26  Pedro Alves  <palves@redhat.com>
9054
9055         * minsyms.c (lookup_minimal_symbol_by_pc_section_1): Rename to ...
9056         (lookup_minimal_symbol_by_pc_section): ... this.  Replace
9057         'want_trampoline' parameter by a lookup_msym_prefer parameter.
9058         Handle it.
9059         (lookup_minimal_symbol_by_pc_section): Delete old implementation.
9060         (lookup_minimal_symbol_by_pc): Adjust.
9061         (in_gnu_ifunc_stub): Prefer GNU ifunc symbols.
9062         (lookup_solib_trampoline_symbol_by_pc): Adjust.
9063         * minsyms.h (lookup_msym_prefer): New enum.
9064         (lookup_minimal_symbol_by_pc_section): Replace 'want_trampoline'
9065         parameter by a lookup_msym_prefer parameter.
9066
9067 2018-04-26  Pedro Alves  <palves@redhat.com>
9068
9069         * elfread.c (elf_gnu_ifunc_record_cache): Check if the symbol name
9070         ends in "@plt" instead of looking at the symbol's section.
9071
9072 2018-04-26  Pedro Alves  <palves@redhat.com>
9073
9074         * blockframe.c (cache_pc_function_is_gnu_ifunc): Delete.  Remove
9075         all references.
9076         (find_pc_partial_function_gnu_ifunc): Rename to ...
9077         (find_pc_partial_function): ... this, and remove references to
9078         'is_gnu_ifunc_p'.
9079         (find_pc_partial_function): Delete old implementation.
9080         * symtab.h (find_pc_partial_function_gnu_ifunc): Delete.
9081
9082 2018-04-26  Pedro Alves  <palves@redhat.com>
9083
9084         * linespec.c (struct bound_minimal_symbol_search_key): New.
9085         (convert_linespec_to_sals): Sort minimal symbols earlier.  Don't
9086         skip first line if we found a GNU ifunc minimal symbol by name.
9087         (compare_msymbols): Change parameters to work with a destructured
9088         lhs minsym.
9089         (compare_msymbols_for_qsort, compare_msymbols_for_bsearch): New
9090         functions.
9091
9092 2018-04-26  Pedro Alves  <palves@redhat.com>
9093
9094         * breakpoint.c (set_breakpoint_location_function): Don't resolve
9095         ifunc targets here.  Instead, if we have an ifunc minsym, use its
9096         address/name.
9097         (add_location_to_breakpoint): Store the minsym and the objfile in
9098         the breakpoint location.
9099         * breakpoint.h (bp_location) <msymbol, objfile>: New fields.
9100         * linespec.c (minsym_found): Resolve GNU ifunc targets here.
9101         Record the minsym in the sal.
9102         * symtab.h (symtab_and_line) <msymbol>: New field.
9103
9104 2018-04-26  Pedro Alves  <palves@redhat.com>
9105
9106         * elfread.c (elf_gnu_ifunc_resolve_by_got): Don't write to *ADDR_P
9107         unless we actually resolved the ifunc.
9108
9109 2018-04-26  Pedro Alves  <palves@redhat.com>
9110
9111         * c-exp.y (variable production): Prefer ifunc minsyms over
9112         regular function symbols.
9113         * symtab.c (find_gnu_ifunc): New function.
9114         * minsyms.h (lookup_msym_prefer): New enum.
9115         (lookup_minimal_symbol_by_pc_section): Replace 'want_trampoline'
9116         parameter by a lookup_msym_prefer parameter.
9117         * symtab.h (find_gnu_ifunc): New declaration.
9118
9119 2018-04-26  Pedro Alves  <palves@redhat.com>
9120
9121         * blockframe.c (find_gnu_ifunc_target_type): New function.
9122         (find_function_type): New.
9123         * eval.c (evaluate_var_msym_value): For GNU ifunc types, always
9124         return a value with a memory address.
9125         (eval_call): For calls to GNU ifunc functions, try to find the
9126         type of the target function from the type that the resolver
9127         returns.
9128         * gdbtypes.c (objfile_type): Don't install a return type for ifunc
9129         symbols.
9130         * infcall.c (find_function_return_type): Delete.
9131         (find_function_addr): Add 'function_type' parameter.  For calls to
9132         GNU ifunc functions, try to find the type of the target function
9133         from the type that the resolver returns, and return it via
9134         FUNCTION_TYPE.
9135         (call_function_by_hand_dummy): Adjust to use the function type
9136         returned by find_function_addr.
9137         (find_function_addr): Add 'function_type' parameter and move
9138         description here.
9139         * symtab.h (find_function_type, find_gnu_ifunc_target_type): New
9140         declarations.
9141
9142 2018-04-26  Pedro Alves  <palves@redhat.com>
9143
9144         * c-exp.y (variable production): Skip finding an alias for ifunc
9145         symbols.
9146
9147 2018-04-26  Pedro Alves  <palves@redhat.com>
9148
9149         * elfread.c (elf_rel_plt_read): Look for relocations for .got.plt too.
9150
9151 2018-04-25  Pedro Alves  <palves@redhat.com>
9152
9153         * infcmd.c (kill_command): Print the pid as string, not the whole
9154         thread's ptid.  Add comment.  s/has been killed/killed/ in output
9155         message.
9156         * remote.c (remote_detach_1): Print the pid as string, not the
9157         whole thread's ptid.
9158
9159 2018-04-24  Jan Kratochvil  <jan.kratochvil@redhat.com>
9160             Sergio Durigan Junior  <sergiodj@redhat.com>
9161             Pedro Alves  <palves@redhat.com>
9162
9163         * infcmd.c (kill_command): Print message when inferior has
9164         been killed.
9165         * inferior.c (print_inferior_events): Remove 'static'.  Set as
9166         '1'.
9167         (add_inferior): Improve message printed when
9168         'print_inferior_events' is on.
9169         (exit_inferior): Remove message printed when
9170         'print_inferior_events' is on.
9171         (detach_inferior): Improve message printed when
9172         'print_inferior_events' is on.
9173         (initialize_inferiors): Use 'add_inferior_silent' to set
9174         'current_inferior_'.
9175         * inferior.h (print_inferior_events): Declare here as
9176         'extern'.
9177         * infrun.c (follow_fork_inferior): Print '[Attaching...]' or
9178         '[Detaching...]' messages when 'print_inferior_events' is on.
9179         Use 'add_thread_silent' instead of 'add_thread'.  Add '[' and ']'
9180         as prefix/suffix for messages.  Remove periods.  Fix erroneous
9181         'Detaching after fork from child...', replace it by '... from
9182         parent...'.
9183         (handle_vfork_child_exec_or_exit): Add '[' and ']' as
9184         prefix/suffix when printing 'Detaching...' messages.  Print
9185         them when 'print_inferior_events' is on.
9186         * remote.c (remote_detach_1): Print message when detaching
9187         from inferior and '!is_fork_parent'.
9188
9189 2018-04-24  Tom Tromey  <tom@tromey.com>
9190
9191         * cli-out.h: Reindent.
9192
9193 2018-04-24  Tom Tromey  <tom@tromey.com>
9194
9195         * cli-out.c (cli_ui_out::out_field_fmt): Remove.
9196         (cli_ui_out::do_field_string): Use fputs_filtered.
9197         * cli-out.h (class cli_ui_out) <out_field_fmt>: Remove.
9198
9199 2018-04-23  Tom Tromey  <tom@tromey.com>
9200
9201         * guile/scm-frame.c (gdbscm_frame_read_var): Use
9202         gdb::unique_xmalloc_ptr.
9203
9204 2018-04-23  Tom Tromey  <tom@tromey.com>
9205
9206         * configure: Rebuild.
9207
9208 2018-04-22  Rajendra SY  <rajendra.sy@gmail.com>
9209
9210         PR gdb/23095
9211         * gdb/testsuite/gdb.base/break-probes.exp: Pass shlib_load to
9212         prepare_for_testing.  Set normal_bp to r_debug_state if target
9213         is bsd.
9214
9215 2018-04-21  Pedro Alves  <palves@redhat.com>
9216             Rajendra SY  <rajendra.sy@gmail.com>
9217
9218         * inf-ptrace.c (inf_ptrace_attach): Mark the thread as executing.
9219         * remote.c (extended_remote_attach): In all-stop mode, mark the
9220         thread as executing.
9221
9222 2018-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9223
9224         * thread.c (thread_apply_all_command): Fix comment.
9225         (thread_command): Fix comment.
9226
9227 2018-04-10  Alan Hayward  <alan.hayward@arm.com>
9228
9229         * common/tdesc.h (tdesc_create_feature): Remove xml filename
9230         parameter.
9231         * features/aarch64-core.c (create_feature_aarch64_core):
9232         Regenerate.
9233         * features/aarch64-fpu.c (create_feature_aarch64_fpu):
9234         Likewise.
9235         * features/i386/32bit-avx.c (create_feature_i386_32bit_avx):
9236         Likewise.
9237         * features/i386/32bit-avx512.c
9238         (create_feature_i386_32bit_avx512): Likewise.
9239         * features/i386/32bit-core.c (create_feature_i386_32bit_core):
9240         Likewise.
9241         * features/i386/32bit-linux.c (create_feature_i386_32bit_linux):
9242         Likewise.
9243         * features/i386/32bit-mpx.c (create_feature_i386_32bit_mpx):
9244         Likewise.
9245         * features/i386/32bit-pkeys.c (create_feature_i386_32bit_pkeys):
9246         Likewise.
9247         * features/i386/32bit-sse.c (create_feature_i386_32bit_sse):
9248         Likewise.
9249         * features/i386/64bit-avx.c (create_feature_i386_64bit_avx):
9250         Likewise.
9251         * features/i386/64bit-avx512.c
9252         (create_feature_i386_64bit_avx512): Likewise.
9253         * features/i386/64bit-core.c (create_feature_i386_64bit_core):
9254         Likewise.
9255         * features/i386/64bit-linux.c (create_feature_i386_64bit_linux):
9256         Likewise.
9257         * features/i386/64bit-mpx.c (create_feature_i386_64bit_mpx):
9258         Likewise.
9259         * features/i386/64bit-pkeys.c (create_feature_i386_64bit_pkeys):
9260         Likewise.
9261         * features/i386/64bit-segments.c
9262         (create_feature_i386_64bit_segments): Likewise.
9263         * features/i386/64bit-sse.c (create_feature_i386_64bit_sse):
9264         Likewise.
9265         * features/i386/x32-core.c
9266         (create_feature_i386_x32_core): Likewise.
9267         * features/tic6x-c6xp.c (create_feature_tic6x_c6xp): Likewise.
9268         * features/tic6x-core.c (create_feature_tic6x_core): Likewise.
9269         * features/tic6x-gp.c (create_feature_tic6x_gp): Likewise.
9270         * target-descriptions.c: In generated code, don't pass xml
9271         filename.
9272
9273 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
9274
9275         * common/tdesc.c (print_xml_feature::visit_pre): Add xml parsing.
9276         (print_xml_feature::visit_post): Likewise.
9277         (print_xml_feature::visit): Likewise.
9278         * common/tdesc.h (tdesc_get_features_xml): Use const tdesc.
9279         (print_xml_feature): Add new class.
9280         * regformats/regdat.sh: Null xmltarget on feature targets.
9281         * target-descriptions.c (struct target_desc): Add xmltarget.
9282         (maintenance_check_tdesc_xml_convert): Add unittest function.
9283         (tdesc_get_features_xml): Add function to get xml.
9284         (maintenance_check_xml_descriptions): Test xml generation.
9285         * xml-tdesc.c (string_read_description_xml): Add function.
9286         * xml-tdesc.h (string_read_description_xml): Add declaration.
9287
9288 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
9289
9290         * features/Makefile: Add feature marker to targets with new style
9291         target descriptions.
9292         * regformats/aarch64.dat: Regenerate.
9293         * regformats/i386/amd64-avx-avx512-linux.dat: Likewise.
9294         * regformats/i386/amd64-avx-linux.dat: Likewise.
9295         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Likewise.
9296         * regformats/i386/amd64-avx-mpx-linux.dat: Likewise.
9297         * regformats/i386/amd64-linux.dat: Likewise.
9298         * regformats/i386/amd64-mpx-linux.dat: Likewise.
9299         * regformats/i386/amd64.dat: Likewise.
9300         * regformats/i386/i386-avx-avx512-linux.dat: Likewise.
9301         * regformats/i386/i386-avx-linux.dat: Likewise.
9302         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Likewise.
9303         * regformats/i386/i386-avx-mpx-linux.dat: Likewise.
9304         * regformats/i386/i386-linux.dat: Likewise.
9305         * regformats/i386/i386-mmx-linux.dat: Likewise.
9306         * regformats/i386/i386-mpx-linux.dat: Likewise.
9307         * regformats/i386/i386.dat: Likewise.
9308         * regformats/i386/x32-avx-avx512-linux.dat: Likewise.
9309         * regformats/i386/x32-avx-linux.dat: Likewise.
9310         * regformats/i386/x32-linux.dat: Likewise.
9311         * regformats/tic6x-c62x-linux.dat: Likewise.
9312         * regformats/tic6x-c64x-linux.dat: Likewise.
9313         * regformats/tic6x-c64xp-linux.dat: Likewise.
9314         * regformats/regdat.sh: Parse feature marker.
9315
9316 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
9317
9318         * common/tdesc.h (tdesc_architecture_name): Add new declaration.
9319         (tdesc_osabi_name): Likewise.
9320         * target-descriptions.c (tdesc_architecture_name): Add new
9321         function.
9322         (tdesc_osabi_name): Likewise.
9323
9324 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
9325
9326         * common/tdesc.c (tdesc_predefined_type): Move to here.
9327         (tdesc_named_type): Likewise.
9328         (tdesc_create_vector): Likewise.
9329         (tdesc_create_struct): Likewise.
9330         (tdesc_set_struct_size): Likewise.
9331         (tdesc_create_union): Likewise.
9332         (tdesc_create_flags): Likewise.
9333         (tdesc_create_enum): Likewise.
9334         (tdesc_add_field): Likewise.
9335         (tdesc_add_typed_bitfield): Likewise.
9336         (tdesc_add_bitfield): Likewise.
9337         (tdesc_add_flag): Likewise.
9338         (tdesc_add_enum_value): Likewise.
9339         * common/tdesc.h (struct tdesc_type_builtin): Likewise.
9340         (struct tdesc_type_vector): Likewise.
9341         (struct tdesc_type_field): Likewise.
9342         (struct tdesc_type_with_fields): Likewise.
9343         (tdesc_create_enum): Add declaration.
9344         (tdesc_add_typed_bitfield): Likewise.
9345         (tdesc_add_enum_value): Likewise.
9346         * target-descriptions.c (tdesc_type_field): Move from here.
9347         (tdesc_type_builtin): Likewise.
9348         (tdesc_type_vector): Likewise.
9349         (tdesc_type_with_fields): Likewise.
9350         (tdesc_predefined_types): Likewise.
9351         (tdesc_named_type): Likewise.
9352         (tdesc_create_vector): Likewise.
9353         (tdesc_create_struct): Likewise.
9354         (tdesc_set_struct_size): Likewise.
9355         (tdesc_create_union): Likewise.
9356         (tdesc_create_flags): Likewise.
9357         (tdesc_create_enum): Likewise.
9358         (tdesc_add_field): Likewise.
9359         (tdesc_add_typed_bitfield): Likewise.
9360         (tdesc_add_bitfield): Likewise.
9361         (tdesc_add_flag): Likewise.
9362         (tdesc_add_enum_value): Likewise.
9363         * gdb/target-descriptions.h (tdesc_create_enum): Likewise.
9364         (tdesc_add_typed_bitfield): Likewise.
9365         (tdesc_add_enum_value): Likewise.
9366
9367 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
9368
9369         * common/tdesc.c (tdesc_feature::accept): Move to here.
9370         (tdesc_feature::operator==): Likewise.
9371         (tdesc_create_reg): Likewise.
9372         * common/tdesc.h (tdesc_type_kind): Likewise.
9373         (struct tdesc_type): Likewise.
9374         (struct tdesc_feature): Likewise.
9375         * regformats/regdat.sh: Create a feature.
9376         * target-descriptions.c (tdesc_type_kind): Move from here.
9377         (tdesc_type): Likewise.
9378         (tdesc_type_up): Likewise.
9379         (tdesc_feature): Likewise.
9380         (tdesc_create_reg): Likewise.
9381
9382 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
9383
9384         * Makefile.in: Add arch/tdesc.c
9385         * common/tdesc.c: New file.
9386         * common/tdesc.h (tdesc_element_visitor): Move to here.
9387         (tdesc_element): Likewise.
9388         (tdesc_reg): Likewise.
9389         (tdesc_reg_up): Likewise.
9390         * regformats/regdef.h (reg): Add offset to constructors.
9391         * target-descriptions.c (tdesc_element_visitor): Move from here.
9392         (tdesc_element): Likewise.
9393         (tdesc_reg): Likewise.
9394         (tdesc_reg_up): Likewise.
9395
9396 2018-04-17  Tom Tromey  <tom@tromey.com>
9397
9398         * dwarf2read.c (quirk_rust_enum): Conditionally drop the
9399         discriminant field.
9400
9401 2018-04-17  Tom Tromey  <tom@tromey.com>
9402
9403         * dwarf2read.c (quirk_rust_enum): Handle unions correctly.
9404
9405 2018-04-17  Andreas Arnez  <arnez@linux.vnet.ibm.com>
9406
9407         * symtab.c (print_symbol_info): Skip printing filename and line
9408         number when `last' is NULL.
9409         (symtab_symbol_info): Use empty string instead of NULL for first
9410         invocation of print_symbol_info.
9411         (rbreak_command): Pass NULL to `last' parameter of
9412         print_symbol_info.
9413
9414 2018-04-16  Simon Marchi  <simon.marchi@ericsson.com>
9415
9416         * linux-tdep.c (linux_spu_make_corefile_notes): Return note_data
9417         instead of nullptr.
9418
9419 2018-04-16  Pedro Alves  <palves@redhat.com>
9420
9421         * MAINTAINERS (sh): Remove.
9422         * Makefile.in (ALL_TARGET_OBS): Remove sh64-tdep.o.
9423         (HFILES_NO_SRCDIR): Remove sh64-tdep.h.
9424         (ALLDEPFILES): Remove sh64-tdep.c.
9425         * NEWS: Mentions that support for SH-5/SH64 is removed.
9426         * configure.tgt (sh*-*-linux*): Remove reference to sh64-tdep.o.
9427         (sh*-*-openbsd*): Ditto.
9428         (sh64-*-elf*): Remove.
9429         (sh*): Remove.
9430         * regcache.c (cooked_write_test): Remove bfd_mach_sh5 case.
9431         * sh-linux-tdep.c: Remove reference to bfd_mach_sh5.
9432         * sh-tdep.c: No longer include "sh64-tdep.h".
9433         (sh_gdbarch_init): Remove reference to bfd_mach_sh5.
9434         * sh64-tdep.c, sh64-tdep.h: Remove files.
9435
9436 2018-04-16  Pedro Alves  <palves@redhat.com>
9437
9438         * MAINTAINERS: Remove m88k.
9439         * Makefile.in (ALL_TARGET_OBS): Remove m88k-tdep.o.
9440         (HFILES_NO_SRCDIR): Remove m88k-tdep.h.
9441         (ALLDEPFILES): Remove m88k-bsd-nat.c and m88k-tdep.c.
9442         * NEWS: Mention that support for m88k was removed.
9443         * configure.host (m88*-*-*): Remove support.
9444         * configure.nat (m88k-*-*): Remove support.
9445         * configure.tgt (m88*-*-openbsd*): Remove.
9446         * m88k-bsd-nat.c, m88k-tdep.c, m88k-tdep.h: Delete.
9447
9448 2018-04-15  Simon Marchi  <simon.marchi@polymtl.ca>
9449
9450         * configure.tgt (x86_tobjs): New variable.
9451         (amd64_tobjs, i386_tobjs): Use it.
9452
9453 2018-04-13  Andreas Arnez  <arnez@linux.vnet.ibm.com>
9454
9455         * symtab.c (print_symbol_info): Precede the symbol definition by
9456         the line number when available.
9457         * NEWS: Advertise this enhancement.
9458
9459 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
9460
9461         * NEWS (New options): announce set/show record btrace cpu.
9462         * btrace.c: Include record-btrace.h.
9463         (btrace_compute_ftrace_pt): Skip enabling errata workarounds if
9464         the vendor is unknown.
9465         (btrace_compute_ftrace_1): Add cpu parameter.  Update callers.
9466         Maybe overwrite the btrace configuration's cpu.
9467         (btrace_compute_ftrace): Add cpu parameter.  Update callers.
9468         (btrace_fetch): Add cpu parameter.  Update callers.
9469         (btrace_maint_update_pt_packets): Call record_btrace_get_cpu.
9470         Maybe overwrite the btrace configuration's cpu.  Skip enabling
9471         errata workarounds if the vendor is unknown.
9472         * python/py-record-btrace.c: Include record-btrace.h.
9473         (recpy_bt_begin, recpy_bt_end, recpy_bt_instruction_history)
9474         (recpy_bt_function_call_history): Call record_btrace_get_cpu.
9475         * record-btrace.c (record_btrace_cpu_state_kind): New.
9476         (record_btrace_cpu): New.
9477         (set_record_btrace_cpu_cmdlist): New.
9478         (record_btrace_get_cpu): New.
9479         (require_btrace_thread, record_btrace_info)
9480         (record_btrace_resume_thread): Call record_btrace_get_cpu.
9481         (cmd_set_record_btrace_cpu_none): New.
9482         (cmd_set_record_btrace_cpu_auto): New.
9483         (cmd_set_record_btrace_cpu): New.
9484         (cmd_show_record_btrace_cpu): New.
9485         (_initialize_record_btrace): Initialize set/show record btrace cpu
9486         commands.
9487         * record-btrace.h (record_btrace_get_cpu): New.
9488
9489 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
9490
9491         * record.c (set_record_command): Fix typo in message.
9492
9493 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
9494
9495         * record-btrace.c (cmd_set_record_btrace): Print sub-commands.
9496
9497 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
9498
9499         * infrun.c (process_event_stop_test): Call
9500         gdbarch_in_indirect_branch_thunk.
9501         * gdbarch.sh (in_indirect_branch_thunk): New.
9502         * gdbarch.c: Regenerated.
9503         * gdbarch.h: Regenerated.
9504         * x86-tdep.h: New.
9505         * x86-tdep.c: New.
9506         * Makefile.in (ALL_TARGET_OBS): Add x86-tdep.o.
9507         (HFILES_NO_SRCDIR): Add x86-tdep.h.
9508         (ALLDEPFILES): Add x86-tdep.c.
9509         * arch-utils.h (default_in_indirect_branch_thunk): New.
9510         * arch-utils.c (default_in_indirect_branch_thunk): New.
9511         * i386-tdep: Include x86-tdep.h.
9512         (i386_in_indirect_branch_thunk): New.
9513         (i386_elf_init_abi): Set in_indirect_branch_thunk gdbarch
9514         function.
9515         * amd64-tdep: Include x86-tdep.h.
9516         (amd64_in_indirect_branch_thunk): New.
9517         (amd64_init_abi): Set in_indirect_branch_thunk gdbarch function.
9518
9519 2018-04-12  Jan Kratochvil  <jan.kratochvil@redhat.com>
9520
9521         PR gdb/23053
9522         * dwarf-index-write.c (data_buf::grow) (write_one_signatured_type)
9523         (recursively_write_psymbols) (debug_names::recursively_write_psymbols)
9524         (debug_names::write_one_signatured_type): Fix -D_GLIBCXX_DEBUG
9525         regression.
9526
9527 2018-04-12  Tom Tromey  <tom@tromey.com>
9528
9529         * rust-lang.c (rust_print_struct_def): Remove univariant code.
9530         (rust_evaluate_subexp): Likewise.
9531
9532 2018-04-12  Pedro Alves  <palves@redhat.com>
9533
9534         * procfs.c (procfs_detach): Make forward declaration's prototype
9535         match definition's protototype.
9536         (proc_get_LDT_entry): Remove stale do_cleanups call.
9537
9538 2018-04-12  Pedro Alves  <palves@redhat.com>
9539
9540         * target.h (target_ops::to_has_exited): Delete.
9541         (target_has_exited): Delete.
9542         * target-delegates.c: Regenerate.
9543
9544 2018-04-11  Pedro Alves  <palves@redhat.com>
9545
9546         * target.c (fileio_fh_t::t): Add comment.
9547         (target_fileio_pwrite, target_fileio_pread, target_fileio_fstat)
9548         (target_fileio_close): Handle a NULL target.
9549         (invalidate_fileio_fh): New.
9550         (target_close): Call it.
9551         * remote.c (remote_hostio_send_command): No longer check whether
9552         remote_desc is open.
9553
9554 2018-04-11  Pedro Alves  <palves@redhat.com>
9555
9556         * target.c (fileio_fh_t): Make it a named struct instead of a
9557         typedef.
9558         (fileio_fh_t::is_closed): New method.
9559         (DEF_VEC_O (fileio_fh_t)): Remove.
9560         (fileio_fhandles): Now a std::vector.
9561         (is_closed_fileio_fh): Delete.
9562         (acquire_fileio_fd): Adjust.  Rename parameters.
9563         (release_fileio_fd): Adjust.
9564         (fileio_fd_to_fh): Reimplement as a function instead of a macro.
9565         (target_fileio_pwrite, target_fileio_pread, target_fileio_fstat)
9566         (target_fileio_close): Adjust.
9567
9568 2018-04-10  Simon Marchi  <simon.marchi@ericsson.com>
9569
9570         * auto-load.c (auto_load_safe_path_vec_update): Iterate by
9571         index.
9572
9573 2018-04-10  Pedro Alves  <palves@redhat.com>
9574
9575         * gdbthread.h (finish_thread_state_cleanup): Delete declaration.
9576         (scoped_finish_thread_state): New class.
9577         * infcmd.c (run_command_1): Use it instead of finish_thread_state
9578         cleanup.
9579         * infrun.c (proceed, prepare_for_detach, wait_for_inferior)
9580         (fetch_inferior_event, normal_stop): Likewise.
9581         * thread.c (finish_thread_state_cleanup): Delete.
9582
9583 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
9584             Pedro Alves  <palves@redhat.com>
9585
9586         * value.c: Include "selftest.h" and "common/array-view.h".
9587         (struct range) <operator ==>: New.
9588         (test_ranges_contain): New.
9589         (check_ranges_vector): New.
9590         (test_insert_into_bit_range_vector): New.
9591         (_initialize_values): Register selftests.
9592         * common/array-view.h (operator==, operator!=): New.
9593
9594 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
9595
9596         * common/gdb_vecs.h (unordered_remove): Add overload that takes
9597         an iterator.
9598         * inline-frame.c: Include <algorithm>.
9599         (struct inline_state): Add constructor.
9600         (inline_state_s): Remove.
9601         (DEF_VEC_O(inline_state_s)): Remove.
9602         (inline_states): Change type to std::vector.
9603         (find_inline_frame_state): Adjust to std::vector.
9604         (allocate_inline_frame_state): Remove.
9605         (clear_inline_frame_state): Adjust to std::vector.
9606         (skip_inline_frames): Adjust to std::vector.
9607
9608 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
9609
9610         * tracepoint.h (struct trace_state_variable): Add constructor.
9611         <name>: Change type to std::string.
9612         * tracepoint.c (tsv_s): Remove.
9613         (DEF_VEC_O(tsv_s)): Remove.
9614         (tvariables): Change to std::vector.
9615         (create_trace_state_variable): Adjust to std::vector.
9616         (find_trace_state_variable): Likewise.
9617         (find_trace_state_variable_by_number): Likewise.
9618         (delete_trace_state_variable): Likewise.
9619         (trace_variable_command): Adjust to std::string.
9620         (delete_trace_variable_command): Likewise.
9621         (tvariables_info_1): Adjust to std::vector.
9622         (save_trace_state_variables): Likewise.
9623         (start_tracing): Likewise.
9624         (merge_uploaded_trace_state_variables): Adjust to std::vector
9625         and std::string.
9626         * target.h (struct target_ops)
9627         <to_download_trace_state_variable>: Pass reference to
9628         trace_state_variable.
9629         * target-debug.h (target_debug_print_const_trace_state_variable_r): New.
9630         * target-delegates.c: Re-generate.
9631         * mi/mi-interp.c (mi_tsv_created): Adjust to std::string.
9632         (mi_tsv_deleted): Likewise.
9633         * mi/mi-main.c (mi_cmd_trace_frame_collected): Likewise.
9634         * remote.c (remote_download_trace_state_variable): Change
9635         pointer to reference and adjust.
9636         * make-target-delegates (parse_argtypes): Handle references.
9637         (write_function_header): Likewise.
9638         (munge_type): Likewise.
9639
9640 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
9641
9642         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9643         string_view-selftests.c.
9644         * unittests/basic_string_view/capacity/1.cc: Adapt to GDB
9645         testsuite.
9646         * unittests/basic_string_view/cons/char/1.cc: Likewise.
9647         * unittests/basic_string_view/cons/char/2.cc: Likewise.
9648         * unittests/basic_string_view/cons/char/3.cc: Likewise.
9649         * unittests/basic_string_view/element_access/char/1.cc:
9650         Likewise.
9651         * unittests/basic_string_view/element_access/char/empty.cc:
9652         Likewise.
9653         * unittests/basic_string_view/element_access/char/front_back.cc:
9654         Likewise.
9655         * unittests/basic_string_view/inserters/char/2.cc: Likewise.
9656         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc:
9657         Likewise.
9658         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc:
9659         Likewise.
9660         * unittests/basic_string_view/modifiers/swap/char/1.cc:
9661         Likewise.
9662         * unittests/basic_string_view/operations/compare/char/1.cc:
9663         Likewise.
9664         * unittests/basic_string_view/operations/compare/char/13650.cc:
9665         Likewise.
9666         * unittests/basic_string_view/operations/copy/char/1.cc:
9667         Likewise.
9668         * unittests/basic_string_view/operations/data/char/1.cc:
9669         Likewise.
9670         * unittests/basic_string_view/operations/find/char/1.cc:
9671         Likewise.
9672         * unittests/basic_string_view/operations/find/char/2.cc:
9673         Likewise.
9674         * unittests/basic_string_view/operations/find/char/3.cc:
9675         Likewise.
9676         * unittests/basic_string_view/operations/find/char/4.cc:
9677         Likewise.
9678         * unittests/basic_string_view/operations/rfind/char/1.cc:
9679         Likewise.
9680         * unittests/basic_string_view/operations/rfind/char/2.cc:
9681         Likewise.
9682         * unittests/basic_string_view/operations/rfind/char/3.cc:
9683         Likewise.
9684         * unittests/basic_string_view/operations/substr/char/1.cc:
9685         Likewise.
9686         * unittests/basic_string_view/operators/char/2.cc: Likewise.
9687         * unittests/string_view-selftests.c: New file.
9688
9689 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
9690
9691         * unittests/basic_string_view/capacity/1.cc: New file.
9692         * unittests/basic_string_view/capacity/empty_neg.cc: New file.
9693         * unittests/basic_string_view/cons/char/1.cc: New file.
9694         * unittests/basic_string_view/cons/char/2.cc: New file.
9695         * unittests/basic_string_view/cons/char/3.cc: New file.
9696         * unittests/basic_string_view/cons/wchar_t/1.cc: New file.
9697         * unittests/basic_string_view/cons/wchar_t/2.cc: New file.
9698         * unittests/basic_string_view/cons/wchar_t/3.cc: New file.
9699         * unittests/basic_string_view/element_access/char/1.cc: New file.
9700         * unittests/basic_string_view/element_access/char/2.cc: New file.
9701         * unittests/basic_string_view/element_access/char/empty.cc: New file.
9702         * unittests/basic_string_view/element_access/char/front_back.cc: New file.
9703         * unittests/basic_string_view/element_access/wchar_t/1.cc: New file.
9704         * unittests/basic_string_view/element_access/wchar_t/2.cc: New file.
9705         * unittests/basic_string_view/element_access/wchar_t/empty.cc: New file.
9706         * unittests/basic_string_view/element_access/wchar_t/front_back.cc: New file.
9707         * unittests/basic_string_view/include.cc: New file.
9708         * unittests/basic_string_view/inserters/char/1.cc: New file.
9709         * unittests/basic_string_view/inserters/char/2.cc: New file.
9710         * unittests/basic_string_view/inserters/char/3.cc: New file.
9711         * unittests/basic_string_view/inserters/pod/10081-out.cc: New file.
9712         * unittests/basic_string_view/inserters/wchar_t/1.cc: New file.
9713         * unittests/basic_string_view/inserters/wchar_t/2.cc: New file.
9714         * unittests/basic_string_view/inserters/wchar_t/3.cc: New file.
9715         * unittests/basic_string_view/literals/types.cc: New file.
9716         * unittests/basic_string_view/literals/values.cc: New file.
9717         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc: New file.
9718         * unittests/basic_string_view/modifiers/remove_prefix/wchar_t/1.cc: New file.
9719         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc: New file.
9720         * unittests/basic_string_view/modifiers/remove_suffix/wchar_t/1.cc: New file.
9721         * unittests/basic_string_view/modifiers/swap/char/1.cc: New file.
9722         * unittests/basic_string_view/modifiers/swap/wchar_t/1.cc: New file.
9723         * unittests/basic_string_view/operations/compare/char/1.cc: New file.
9724         * unittests/basic_string_view/operations/compare/char/13650.cc: New file.
9725         * unittests/basic_string_view/operations/compare/char/2.cc: New file.
9726         * unittests/basic_string_view/operations/compare/char/70483.cc: New file.
9727         * unittests/basic_string_view/operations/compare/wchar_t/1.cc: New file.
9728         * unittests/basic_string_view/operations/compare/wchar_t/13650.cc: New file.
9729         * unittests/basic_string_view/operations/compare/wchar_t/2.cc: New file.
9730         * unittests/basic_string_view/operations/copy/char/1.cc: New file.
9731         * unittests/basic_string_view/operations/copy/wchar_t/1.cc: New file.
9732         * unittests/basic_string_view/operations/data/char/1.cc: New file.
9733         * unittests/basic_string_view/operations/data/wchar_t/1.cc: New file.
9734         * unittests/basic_string_view/operations/find/char/1.cc: New file.
9735         * unittests/basic_string_view/operations/find/char/2.cc: New file.
9736         * unittests/basic_string_view/operations/find/char/3.cc: New file.
9737         * unittests/basic_string_view/operations/find/char/4.cc: New file.
9738         * unittests/basic_string_view/operations/find/wchar_t/1.cc: New file.
9739         * unittests/basic_string_view/operations/find/wchar_t/2.cc: New file.
9740         * unittests/basic_string_view/operations/find/wchar_t/3.cc: New file.
9741         * unittests/basic_string_view/operations/find/wchar_t/4.cc: New file.
9742         * unittests/basic_string_view/operations/rfind/char/1.cc: New file.
9743         * unittests/basic_string_view/operations/rfind/char/2.cc: New file.
9744         * unittests/basic_string_view/operations/rfind/char/3.cc: New file.
9745         * unittests/basic_string_view/operations/rfind/wchar_t/1.cc: New file.
9746         * unittests/basic_string_view/operations/rfind/wchar_t/2.cc: New file.
9747         * unittests/basic_string_view/operations/rfind/wchar_t/3.cc: New file.
9748         * unittests/basic_string_view/operations/string_conversion/1.cc: New file.
9749         * unittests/basic_string_view/operations/substr/char/1.cc: New file.
9750         * unittests/basic_string_view/operations/substr/wchar_t/1.cc: New file.
9751         * unittests/basic_string_view/operators/char/2.cc: New file.
9752         * unittests/basic_string_view/operators/wchar_t/2.cc: New file.
9753         * unittests/basic_string_view/range_access/char/1.cc: New file.
9754         * unittests/basic_string_view/range_access/wchar_t/1.cc: New file.
9755         * unittests/basic_string_view/requirements/explicit_instantiation/1.cc: New file.
9756         * unittests/basic_string_view/requirements/explicit_instantiation/char/1.cc: New file.
9757         * unittests/basic_string_view/requirements/explicit_instantiation/char16_t/1.cc: New file.
9758         * unittests/basic_string_view/requirements/explicit_instantiation/char32_t/1.cc: New file.
9759         * unittests/basic_string_view/requirements/explicit_instantiation/wchar_t/1.cc: New file.
9760         * unittests/basic_string_view/requirements/typedefs.cc: New file.
9761         * unittests/basic_string_view/typedefs.cc: New file.
9762         * unittests/basic_string_view/types/1.cc: New file.
9763
9764 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
9765
9766         * common/gdb_string_view.h: Remove libstdc++ implementation
9767         details, adjust to gdb reality.
9768         * common/gdb_string_view.tcc: Likewise.
9769         * cli/cli-script.c (struct string_view): Remove.
9770         (user_args) <m_args>: Change element type to gdb::string_view.
9771         (user_args::insert_args): Adjust.
9772
9773 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
9774
9775         * common/gdb_string_view.h: New file.
9776         * common/gdb_string_view.tcc: New file.
9777
9778 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
9779
9780         * ax_cxx_compile_stdcxx.m4: Sync with upstream.
9781         * configure: Re-generate.
9782
9783 2018-04-09  Pedro Alves  <palves@redhat.com>
9784
9785         * gdbarch.sh: Include "observable.h" instead of "observer.h".
9786         (set_target_gdbarch): Call
9787         gdb::observers::architecture_changed.notify instead of
9788         observer_notify_architecture_changed.
9789
9790 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
9791
9792         * tracepoint.c (struct current_traceframe_cleanup): Remove.
9793         (do_restore_current_traceframe_cleanup): Remove.
9794         (restore_current_traceframe_cleanup_dtor): Remove.
9795         (make_cleanup_restore_current_traceframe): Remove.
9796         (scoped_restore_current_traceframe::scoped_restore_current_traceframe):
9797         New.
9798         * tracepoint.h (struct scoped_restore_current_traceframe): New.
9799         * infrun.c (fetch_inferior_event): Use
9800         scoped_restore_current_traceframe.
9801
9802 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
9803
9804         * dwarf2read.h (struct dwarf2_per_objfile) <n_type_units>:
9805         Remove.
9806         <n_allocated_type_units>: Remove.
9807         <all_type_units>: Change to std::vector.
9808         * dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile): Adjust
9809         to std::vector change.
9810         (dwarf2_per_objfile::get_cutu): Likewise.
9811         (dwarf2_per_objfile::get_tu): Likewise.
9812         (create_signatured_type_table_from_index): Likewise.
9813         (create_signatured_type_table_from_debug_names): Likewise.
9814         (dw2_symtab_iter_next): Likewise.
9815         (dw2_print_stats): Likewise.
9816         (dw2_expand_all_symtabs): Likewise.
9817         (dw2_expand_marked_cus): Likewise.
9818         (dw2_debug_names_iterator::next): Likewise.
9819         (dwarf2_initialize_objfile): Likewise.
9820         (add_signatured_type_cu_to_table): Likewise.
9821         (create_all_type_units): Likewise.
9822         (add_type_unit): Likewise.
9823         (struct tu_abbrev_offset): Add constructor.
9824         (build_type_psymtabs_1): Adjust to std::vector change.
9825         (print_tu_stats): Likewise.
9826         * dwarf-index-write.c (check_dwarf64_offsets): Likewise.
9827         (write_debug_names): Likewise.
9828
9829 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
9830
9831         * dwarf2read.h (struct dwarf2_per_objfile) <all_comp_units>: Likewise.
9832         Make an std::vector.
9833         <n_comp_units>: Remove.
9834         * dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile): Adjust
9835         to std::vector change.
9836         (dwarf2_per_objfile::get_cutu): Likewise.
9837         (dwarf2_per_objfile::get_cu): Likewise.
9838         (create_cus_from_index): Likewise.
9839         (create_addrmap_from_index): Likewise.
9840         (create_addrmap_from_aranges): Likewise.
9841         (dwarf2_read_index): Likewise.
9842         (dw2_find_last_source_symtab): Likewise.
9843         (dw2_map_symtabs_matching_filename): Likewise.
9844         (dw2_symtab_iter_next): Likewise.
9845         (dw2_print_stats): Likewise.
9846         (dw2_expand_all_symtabs): Likewise.
9847         (dw2_expand_symtabs_with_fullname): Likewise.
9848         (dw2_expand_marked_cus): Likewise.
9849         (dw2_map_symbol_filenames): Likewise.
9850         (create_cus_from_debug_names): Likewise.
9851         (dwarf2_read_debug_names): Likewise.
9852         (dw2_debug_names_iterator::next): Likewise.
9853         (dwarf2_initialize_objfile): Likewise.
9854         (set_partial_user): Likewise.
9855         (dwarf2_build_psymtabs_hard): Likewise.
9856         (read_comp_units_from_section): Remove arguments, adjust to
9857         std::vector change.
9858         (create_all_comp_units): Adjust to std::vector and
9859         read_comp_units_from_section changes.
9860         (dwarf2_find_containing_comp_unit): Adjust to std::vector
9861         change.
9862         * dwarf-index-write.c (check_dwarf64_offsets): Likewise.
9863         (psyms_seen_size): Likewise.
9864         (write_gdbindex): Likewise.
9865         (write_debug_names): Likewise.
9866
9867 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
9868
9869         * dwarf2read.c (create_cus_from_index_list): Replace objfile arg
9870         with dwarf2_per_objfile.
9871         (create_cus_from_index): Likewise.
9872         (create_signatured_type_table_from_index): Likewise.
9873         (dwarf2_read_index): Likewise.
9874         (dwarf2_initialize_objfile): Likewise.
9875         (dwarf2_fetch_die_loc_sect_off):  Get dwarf2_per_objfile from
9876         per_cu rather than get_dwarf2_per_objfile.
9877
9878 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
9879
9880         * dwarf2read.h (struct signatured_type): Forward declare.
9881         (struct dwarf2_per_objfile) <get_cutu, get_cu, get_tu>:
9882         New methods.
9883         * dwarf2read.c (dwarf2_per_objfile::get_cutu): Rename from...
9884         (dw2_get_cutu): ...this.
9885         (dwarf2_per_objfile::get_cu): Rename from...
9886         (dw2_get_cu): ...this.
9887         (dwarf2_per_objfile::get_tu): New.
9888         (create_addrmap_from_index): Adjust.
9889         (create_addrmap_from_aranges): Adjust.
9890         (dw2_find_last_source_symtab): Adjust.
9891         (dw2_map_symtabs_matching_filename): Adjust.
9892         (dw2_symtab_iter_next): Adjust.
9893         (dw2_print_stats): Adjust.
9894         (dw2_expand_all_symtabs): Adjust.
9895         (dw2_expand_symtabs_with_fullname): Adjust.
9896         (dw2_expand_marked_cus): Adjust.
9897         (dw_expand_symtabs_matching_file_matcher): Adjust.
9898         (dw2_map_symbol_filenames): Adjust.
9899         (dw2_debug_names_iterator::next): Adjust.
9900         (dwarf2_initialize_objfile): Adjust.
9901         (set_partial_user): Adjust.
9902         (dwarf2_build_psymtabs_hard): Adjust.
9903
9904 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
9905
9906         * dwarf2read.c (create_signatured_type_table_from_debug_names):
9907         Remove unused variables.
9908         (dw2_map_symtabs_matching_filename): Likewise.
9909         (dwarf2_record_block_ranges): Likewise.
9910         (dwarf2_read_addr_index): Likewise.
9911         (follow_die_offset): Likewise.
9912
9913 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
9914
9915         * progspace.c (clone_program_space): Pass SYMFILE_DEFER_BP_RESET
9916         to symbol_file_add_main.
9917
9918 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
9919
9920         PR mi/22299
9921         * mi/mi-console.c (do_fputc_async_safe): New.
9922         (mi_console_file::write_async_safe): New.
9923         (mi_console_file::flush): Adjust calls to fputstrn_unfiltered.
9924         * mi/mi-console.h (class mi_console_file) <write_async_safe>:
9925         New.
9926         * ui-file.c (ui_file::putstrn): Adjust call to
9927         fputstrn_unfiltered.
9928         * utils.c (printchar): Replace do_fputs and do_fprintf
9929         parameters by do_fputc.
9930         (fputstr_filtered): Adjust call to printchar.
9931         (fputstr_unfiltered): Likewise.
9932         (fputstrn_filtered): Likewise.
9933         (fputstrn_unfiltered): Add do_fputc parameter, pass to
9934         printchar.
9935         * utils.h (do_fputc_ftype): New typedef.
9936         (fputstrn_unfiltered): Add do_fputc parameter.
9937
9938 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
9939
9940         * regformats/i386/i386-avx.dat: Remove.
9941
9942 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
9943
9944         PR gdb/22979
9945         * amd64-tdep.c (amd64_none_init_abi): New function.
9946         (amd64_x32_none_init_abi): New function.
9947         (_initialize_amd64_tdep): Register handlers for x86-64 and
9948         x64_32 with GDB_OSABI_NONE.
9949         * osabi.c (gdbarch_init_osabi): Allow running handlers for the
9950         GDB_OSABI_NONE osabi.
9951
9952 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
9953
9954         PR gdb/22980
9955         * defs.h (enum gdb_osabi): Remove GDB_OSABI_UNINITIALIZED, add
9956         GDB_OSABI_NONE.
9957         * arch-utils.c (gdbarch_info_init): Don't set info->osabi.
9958         * osabi.c (gdb_osabi_names): Add "unknown" entry.
9959
9960 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
9961
9962         * common/byte-vector.h (char_vector): New type.
9963         * target.h (target_read_alloc): Return
9964         gdb::optional<byte_vector>.
9965         (target_read_stralloc): Return gdb::optional<char_vector>.
9966         (target_get_osdata): Return gdb::optional<char_vector>.
9967         * target.c (target_read_alloc_1): Templatize.  Replacement
9968         manual memory management with vector.
9969         (target_read_alloc): Change return type, adjust.
9970         (target_read_stralloc): Change return type, adjust.
9971         (target_get_osdata): Change return type, adjust.
9972         * auxv.c (struct auxv_info) <length>: Remove.
9973         <data>: Change type to gdb::optional<byte_vector>.
9974         (auxv_inferior_data_cleanup): Free auxv_info with delete.
9975         (get_auxv_inferior_data): Allocate auxv_info with new, adjust.
9976         (target_auxv_search): Adjust.
9977         (fprint_target_auxv): Adjust.
9978         * avr-tdep.c (avr_io_reg_read_command): Adjust.
9979         * linux-tdep.c (linux_spu_make_corefile_notes): Adjust.
9980         (linux_make_corefile_notes): Adjust.
9981         * osdata.c (get_osdata): Adjust.
9982         * remote.c (remote_get_threads_with_qxfer): Adjust.
9983         (remote_memory_map): Adjust.
9984         (remote_traceframe_info): Adjust.
9985         (btrace_read_config): Adjust.
9986         (remote_read_btrace): Adjust.
9987         (remote_pid_to_exec_file): Adjust.
9988         * solib-aix.c (solib_aix_get_library_list): Adjust.
9989         * solib-dsbt.c (decode_loadmap): Don't free buf.
9990         (dsbt_get_initial_loadmaps): Adjust.
9991         * solib-svr4.c (svr4_current_sos_via_xfer_libraries): Adjust.
9992         * solib-target.c (solib_target_current_sos): Adjust.
9993         * tracepoint.c (sdata_make_value): Adjust.
9994         * xml-support.c (xinclude_start_include): Adjust.
9995         (xml_fetch_content_from_file): Adjust.
9996         * xml-support.h (xml_fetch_another): Change return type.
9997         (xml_fetch_content_from_file): Change return type.
9998         * xml-syscall.c (xml_init_syscalls_info): Adjust.
9999         * xml-tdesc.c (file_read_description_xml): Adjust.
10000         (fetch_available_features_from_target): Change return type.
10001         (target_fetch_description_xml): Adjust.
10002         (target_read_description_xml): Adjust.
10003
10004 2018-04-06  Tom Tromey  <tom@tromey.com>
10005
10006         * value.c (~value): Update.
10007         (struct value) <contents>: Now unique_xmalloc_ptr.
10008         (value_contents_bits_eq, allocate_value_contents)
10009         (value_contents_raw, value_contents_all_raw)
10010         (value_contents_for_printing, value_contents_for_printing_const)
10011         (set_value_enclosing_type): Update.
10012
10013 2018-04-06  Tom Tromey  <tom@tromey.com>
10014
10015         * value.c (range_s): Remove typedef, VEC.
10016         (struct range): Add operator<.
10017         (range_lessthan): Remove.
10018         (ranges_contain): Change type.
10019         (~value): Update.
10020         (struct value) <unavailable, optimized_out>: Now std::vector.
10021         (value_entirely_available)
10022         (value_entirely_covered_by_range_vector)
10023         (value_entirely_unavailable, value_entirely_optimized_out):
10024         Update.
10025         (insert_into_bit_range_vector): Change argument type.
10026         (find_first_range_overlap): Likewise.
10027         (struct ranges_and_idx, value_contents_bits_eq)
10028         (require_not_optimized_out, require_available): Update.
10029         (ranges_copy_adjusted): Change argument types.
10030         (value_optimized_out, value_copy, value_fetch_lazy): Update.
10031
10032 2018-04-06  Tom Tromey  <tom@tromey.com>
10033
10034         * value.c (~value): Update.
10035         (struct value) <parent>: Now a value_ref_ptr.
10036         (value_parent, set_value_parent, value_address, value_copy):
10037         Update.
10038
10039 2018-04-06  Tom Tromey  <tom@tromey.com>
10040
10041         * value.c (struct value): Add constructor, destructor, and member
10042         initializers.
10043         (allocate_value_lazy, value_decref): Update.
10044
10045 2018-04-06  Tom Tromey  <tom@tromey.com>
10046
10047         * value.c (struct value) <released, next>: Remove.
10048         (all_values): Now a std::vector.
10049         (allocate_value_lazy): Update.
10050         (value_next): Remove.
10051         (value_mark, value_free_to_mark, release_value)
10052         (value_release_to_mark): Update.
10053
10054 2018-04-06  Tom Tromey  <tom@tromey.com>
10055
10056         * value.h (fetch_subexp_value, value_release_to_mark): Update.
10057         (free_value_chain): Remove.
10058         * value.c (free_value_chain): Remove.
10059         (value_release_to_mark): Return a std::vector.
10060         * ppc-linux-nat.c (num_memory_accesses): Change "chain" to a
10061         std::vector.
10062         (check_condition): Update.
10063         * eval.c (fetch_subexp_value): Change "val_chain" to a
10064         std::vector.
10065         * breakpoint.c (update_watchpoint): Update.
10066         (can_use_hardware_watchpoint): Change "vals" to a std::vector.
10067
10068 2018-04-06  Tom Tromey  <tom@tromey.com>
10069
10070         * value.h (free_all_values): Remove.
10071         * value.c (free_all_values): Remove.
10072
10073 2018-04-06  Tom Tromey  <tom@tromey.com>
10074
10075         * value.c (VALUE_HISTORY_CHUNK, struct value_history_chunk)
10076         (value_history_chain, value_history_count): Remove.
10077         (value_history): New global.
10078         (record_latest_value, access_value_history, show_values)
10079         (preserve_values): Update.
10080
10081 2018-04-06  Tom Tromey  <tom@tromey.com>
10082
10083         * varobj.h (struct varobj) <value>: Now a value_ref_ptr.
10084         * varobj.c (varobj_set_display_format, varobj_set_value)
10085         (install_default_visualizer, construct_visualizer)
10086         (install_new_value, ~varobj, varobj_get_value_type)
10087         (my_value_of_variable, varobj_editable_p): Update.
10088         * c-varobj.c (c_describe_child, c_value_of_variable)
10089         (cplus_number_of_children, cplus_describe_child): Update.
10090         * ada-varobj.c (ada_number_of_children, ada_name_of_child)
10091         (ada_path_expr_of_child, ada_value_of_child, ada_type_of_child)
10092         (ada_value_of_variable, ada_value_is_changeable_p): Update.
10093
10094 2018-04-06  Tom Tromey  <tom@tromey.com>
10095
10096         * printcmd.c (last_examine_address): Change type to
10097         value_ref_ptr.
10098         (do_examine, x_command): Update.
10099
10100 2018-04-06  Tom Tromey  <tom@tromey.com>
10101
10102         * value.c (release_value): Update.
10103         * breakpoint.h (struct watchpoint) <val>: Now a value_ref_ptr.
10104         (struct bpstats) <val>: Now a value_ref_ptr.
10105         * breakpoint.c (update_watchpoint, breakpoint_init_inferior)
10106         (~bpstats, bpstats, bpstat_clear_actions, watchpoint_check)
10107         (~watchpoint, print_it_watchpoint, watch_command_1)
10108         (invalidate_bp_value_on_memory_change): Update.
10109
10110 2018-04-06  Tom Tromey  <tom@tromey.com>
10111
10112         * varobj.c (varobj_clear_saved_item)
10113         (update_dynamic_varobj_children, install_new_value, ~varobj):
10114         Update.
10115         * value.h (value_incref): Move declaration earlier.
10116         (value_decref): Rename from value_free.
10117         (struct value_ref_policy): New.
10118         (value_ref_ptr): New typedef.
10119         (struct value_deleter): Remove.
10120         (gdb_value_up): Remove typedef.
10121         (release_value): Change return type.
10122         (release_value_or_incref): Remove.
10123         * value.c (set_value_parent): Update.
10124         (value_incref): Change return type.
10125         (value_decref): Rename from value_free.
10126         (value_free_to_mark, free_all_values, free_value_chain): Update.
10127         (release_value): Return value_ref_ptr.
10128         (release_value_or_incref): Remove.
10129         (record_latest_value, set_internalvar, clear_internalvar):
10130         Update.
10131         * stack.c (info_frame_command): Don't call value_free.
10132         * python/py-value.c (valpy_dealloc, valpy_new)
10133         (value_to_value_object): Update.
10134         * printcmd.c (do_examine): Update.
10135         * opencl-lang.c (lval_func_free_closure): Update.
10136         * mi/mi-main.c (register_changed_p): Don't call value_free.
10137         * mep-tdep.c (mep_frame_prev_register): Don't call value_free.
10138         * m88k-tdep.c (m88k_frame_prev_register): Don't call value_free.
10139         * m68hc11-tdep.c (m68hc11_frame_prev_register): Don't call
10140         value_free.
10141         * guile/scm-value.c (vlscm_free_value_smob)
10142         (vlscm_scm_from_value): Update.
10143         * frame.c (frame_register_unwind, frame_unwind_register_signed)
10144         (frame_unwind_register_unsigned, get_frame_register_bytes)
10145         (put_frame_register_bytes): Don't call value_free.
10146         * findvar.c (address_from_register): Don't call value_free.
10147         * dwarf2read.c (dwarf2_compute_name): Don't call value_free.
10148         * dwarf2loc.c (entry_data_value_free_closure)
10149         (value_of_dwarf_reg_entry, free_pieced_value_closure)
10150         (dwarf2_evaluate_loc_desc_full): Update.
10151         * breakpoint.c (update_watchpoint, breakpoint_init_inferior)
10152         (~bpstats, bpstats, bpstat_clear_actions, watchpoint_check)
10153         (~watchpoint, watch_command_1)
10154         (invalidate_bp_value_on_memory_change): Update.
10155         * alpha-tdep.c (alpha_register_to_value): Don't call value_free.
10156
10157 2018-04-06  Simon Marchi  <simon.marchi@polymtl.ca>
10158
10159         PR gdb/23022
10160         * warning.m4: Add -Wno-error=deprecated-register.
10161         * configure: Re-generate.
10162
10163 2018-04-05  Tom Tromey  <tom@tromey.com>
10164
10165         * linespec.h: Remove include of "vec.h".
10166
10167 2018-04-05  Tom Tromey  <tom@tromey.com>
10168
10169         * linespec.c (typep): Remove typedef.
10170         (find_methods, find_superclass_methods): Take a std::vector.
10171         (find_method): Use std::vector.
10172
10173 2018-04-05  Tom Tromey  <tom@tromey.com>
10174
10175         * utils.c (compare_strings): Remove.
10176         * utils.h (compare_strings): Remove.
10177         * objc-lang.h (find_imps): Update.
10178         * objc-lang.c (find_methods): Take a std::vector.
10179         (uniquify_strings, find_imps): Likewise.
10180         * linespec.c (find_methods): Take a std::vector.
10181         (decode_objc): Use std::vector.
10182         (add_all_symbol_names_from_pspace, find_superclass_methods): Take
10183         a std::vector.
10184         (find_method, find_function_symbols): Use std::vector.
10185
10186 2018-04-05  Tom Tromey  <tom@tromey.com>
10187
10188         * completer.c (completion_tracker::completion_tracker): Remove
10189         cast.
10190         (completion_tracker::discard_completions): Likewise.
10191         * breakpoint.c (ambiguous_names_p): Remove cast.
10192         * ada-lang.c (_initialize_ada_language): Remove cast.
10193         * utils.h (streq): Update.
10194         (streq_hash): Add new declaration.
10195         * utils.c (streq): Return bool.
10196         (streq_hash): New function.
10197
10198 2018-04-05  Tom Tromey  <tom@tromey.com>
10199
10200         * linespec.c (event_location_to_sals) <case ADDRESS_LOCATION>:
10201         Remove a string copy.
10202
10203 2018-04-05  Tom Tromey  <tom@tromey.com>
10204
10205         * linespec.c (filter_results): Use std::vector.
10206         (decode_line_2, decode_line_full): Update.
10207
10208 2018-04-05  Tom Tromey  <tom@tromey.com>
10209
10210         * linespec.c (canonical_to_fullform): Return std::string.
10211         (filter_results): Update.
10212         (struct decode_line_2_item): Add constructor.
10213         <fullform, displayform>: Now std::string.
10214         (decode_line_2_compare_items): Now a std::sort comparator.
10215         (decode_line_2): Update.
10216
10217 2018-04-05  Tom Tromey  <tom@tromey.com>
10218
10219         * linespec.c (copy_token_string): Return a unique_xmalloc_ptr.
10220         (unexpected_linespec_error): Update.
10221         (linespec_parse_basic, parse_linespec): Update.
10222
10223 2018-04-05  Tom Tromey  <tom@tromey.com>
10224
10225         * linespec.c (linespec_parse_basic): Reindent.
10226
10227 2018-04-05  Tom Tromey  <tom@tromey.com>
10228
10229         * minsyms.h (iterate_over_minimal_symbols): Update.
10230         * minsyms.c (iterate_over_minimal_symbols): Take a
10231         gdb::function_view.
10232         * linespec.c (struct collect_minsyms): Remove.
10233         (compare_msyms): Now a std::sort comparator.
10234         (add_minsym): Add parameters.
10235         (search_minsyms_for_name): Update.  Use std::vector.
10236
10237 2018-04-03  Tom Tromey  <tom@tromey.com>
10238
10239         * mipsread.c (read_alphacoff_dynamic_symtab): Use
10240         gdb::byte_vector.
10241
10242 2018-04-02  Weimin Pan  <weimin.pan@oracle.com>
10243
10244         * MAINTAINERS (Write After Approval): Add Weimin Pan.
10245
10246 2018-04-02  Weimin Pan  <weimin.pan@oracle.com>
10247
10248         PR gdb/16959
10249         * cp-valprint.c: (cp_print_static_field) Fix infinite recursion when
10250         printing static type.
10251
10252 2018-04-01  Tom Tromey  <tom@tromey.com>
10253
10254         * rs6000-nat.c (rs6000_ptrace_ldinfo): Return a byte_vector.
10255         (rs6000_xfer_shared_libraries): Update.
10256
10257 2018-04-01  Simon Marchi  <simon.marchi@polymtl.ca>
10258
10259         * common/gdb_vecs.h (char_ptr): Remove.
10260         * tracepoint.c (encode_actions_1): Remove usage of char_ptr.
10261
10262 2018-03-30  Simon Marchi  <simon.marchi@polymtl.ca>
10263
10264         * guile/scm-utils.c (gdbscm_parse_function_args): Replace VEC
10265         with std::vector.
10266         * common/gdb_vecs.h (DEF_VEC_P (char_ptr)): Remove.
10267
10268 2018-03-30  Simon Marchi  <simon.marchi@polymtl.ca>
10269
10270         * tracepoint.h (struct uploaded_tp): Initialize fields.
10271         <actions, step_actions, cmd_strings>: Change type to
10272         std::vector<char *>.
10273         * tracepoint.c (get_uploaded_tp): Allocate with new.
10274         (free_uploaded_tps): Free with delete.
10275         (parse_tracepoint_definition): Adjust to std::vector change.
10276         * breakpoint.c (read_uploaded_action): Likewise.
10277         (create_tracepoint_from_upload): Likewise.
10278         * ctf.c (ctf_write_uploaded_tp): Likewise.
10279         (SET_ARRAY_FIELD): Likewise.
10280         * tracefile-tfile.c (tfile_write_uploaded_tp): Likewise.
10281
10282 2018-03-30  Tom Tromey  <tom@tromey.com>
10283
10284         * solib-svr4.c (lm_info_read): Use gdb::byte_vector.  Return
10285         std::unique_ptr.
10286         (svr4_keep_data_in_core): Update.
10287         (svr4_read_so_list): Update.
10288
10289 2018-03-30  Tom Tromey  <tom@tromey.com>
10290
10291         * windows-nat.c (handle_output_debug_string, handle_exception):
10292         Update.
10293         * target.h (target_read_string): Update.
10294         * target.c (target_read_string): Change "string" to
10295         unique_xmalloc_ptr.
10296         * solib-svr4.c (open_symbol_file_object, svr4_read_so_list):
10297         Update.
10298         * solib-frv.c (frv_current_sos): Update.
10299         * solib-dsbt.c (dsbt_current_sos): Update.
10300         * solib-darwin.c (darwin_current_sos): Update.
10301         * linux-thread-db.c (inferior_has_bug): Update.
10302         * expprint.c (print_subexp_standard) <case OP_OBJC_MSGCALL>:
10303         Update.  Remove alloca.
10304         * ada-lang.c (ada_main_name): Update.
10305
10306 2018-03-30  Tom Tromey  <tom@tromey.com>
10307
10308         * dwarf2read.c (struct free_dwo_file_cleanup_data): Remove.
10309         (struct dwo_file_deleter): New.
10310         (dwo_file_up): New typedef.
10311         (open_and_init_dwo_file): Use dwo_file_up.
10312         (free_dwo_file_cleanup): Remove.
10313
10314 2018-03-30  Tom Tromey  <tom@tromey.com>
10315
10316         * dwarf2read.c (free_dwo_file): Remove "objfile" parameter.
10317         (free_dwo_file_cleanup, free_dwo_file_from_slot): Update.
10318
10319 2018-03-30  Tom Tromey  <tom@tromey.com>
10320
10321         * dwarf2read.c (class free_cached_comp_units): New class.
10322         (dw2_instantiate_symtab, dwarf2_build_psymtabs_hard): Use it.
10323         (free_cached_comp_units): Remove function.
10324
10325 2018-03-30  Tom Tromey  <tom@tromey.com>
10326
10327         * utils.h (make_cleanup_unpush_target): Remove.
10328         * inf-ptrace.c (struct target_unpusher): New.
10329         (target_unpush_up) New typedef.
10330         (inf_ptrace_create_inferior, inf_ptrace_attach): Use
10331         target_unpush_up.
10332         * utils.c (do_unpush_target, make_cleanup_unpush_target): Remove.
10333
10334 2018-03-27  Tom Tromey  <tom@tromey.com>
10335
10336         * utils.c (prompt_for_continue): Use unique_xmalloc_ptr.
10337
10338 2018-03-27  Pedro Alves  <palves@redhat.com>
10339             Tom Tromey  <tom@tromey.com>
10340
10341         * top.c (class gdb_readline_wrapper_cleanup): Add constructor,
10342         destructor.  Now a class.
10343         (gdb_readline_wrapper_cleanup): Remove function.
10344         (gdb_readline_wrapper): Remove cleanups.
10345
10346 2018-03-27  Tom Tromey  <tom@tromey.com>
10347
10348         * typeprint.h (struct type_print_options) <local_typedefs,
10349         global_typedefs>: Remove "struct" keyword.
10350         (class typedef_hash_table): New class.
10351         (recursively_update_typedef_hash, add_template_parameters)
10352         (create_typedef_hash, free_typedef_hash, copy_typedef_hash)
10353         (find_typedef_in_hash): Don't declare.
10354         * typeprint.c (struct typedef_hash_table): Move to typeprint.h.
10355         (typedef_hash_table::recursively_update): Rename from
10356         recursively_update_typedef_hash.  Now a member.
10357         (typedef_hash_table::add_template_parameters): Rename from
10358         add_template_parameters.  Now a member.
10359         (typedef_hash_table::typedef_hash_table): Now a constructor;
10360         rename from create_typedef_hash.
10361         (typedef_hash_table::~typedef_hash_table): Now a destructor;
10362         rename from free_typedef_hash.
10363         (do_free_typedef_hash, make_cleanup_free_typedef_hash)
10364         (do_free_global_table): Remove.
10365         (typedef_hash_table::typedef_hash_table): New constructor; renamed
10366         from copy_type_recursive.
10367         (create_global_typedef_table): Remove.
10368         (typedef_hash_table::find_global_typedef): Now a member of
10369         typedef_hash_table.
10370         (typedef_hash_table::find_typedef): Rename from
10371         find_typedef_in_hash; now a member.
10372         (whatis_exp): Update.
10373         * extension.h (struct ext_lang_type_printers): Add constructor and
10374         destructor.
10375         (start_ext_lang_type_printers, free_ext_lang_type_printers): Don't
10376         declare.
10377         * extension.c (ext_lang_type_printers::ext_lang_type_printers):
10378         Now a constructor; rename from start_ext_lang_type_printers.
10379         (ext_lang_type_printers): Now a destructor; rename from
10380         free_ext_lang_type_printers.
10381         * c-typeprint.c (find_typedef_for_canonicalize, c_print_type_1):
10382         Update.
10383         (c_type_print_base_struct_union): Update.  Remove cleanups.
10384
10385 2018-03-27  Tom Tromey  <tom@tromey.com>
10386
10387         * dwarf-index-write.c: Include <cmath>.
10388
10389 2018-03-27  Joel Brobecker  <brobecker@adacore.com>
10390
10391         * NEWS: Add entry describing new "set|show varsize-limit" command.
10392         * ada-lang.c (_initialize_ada_language): Add "set/show varsize-limit"
10393         command.
10394         * printcmd.c (_initialize_printcmd): Add "set var" alias of
10395         "set variable".
10396
10397 2018-03-27  Simon Marchi  <simon.marchi@ericsson.com>
10398
10399         * Makefile.in (COMMON_SFILES): Add dwarf-index-common.c and
10400         dwarf-index-write.c
10401         (HFILES_NO_SRCDIR): Add dwarf-index-common.h and dwarf2read.h.
10402         * dwarf-index-common.c: New file.
10403         * dwarf-index-common.h: New file.
10404         * dwarf-index-write.c: New file.
10405         * dwarf2read.c: Include dwarf2read.h and dwarf-index-common.h.
10406         (struct dwarf2_section_info): Move from here.
10407         (dwarf2_section_info_def): Likewise.
10408         (DEF_VEC_O (dwarf2_section_info_def)): Likewise.
10409         (offset_type): Likewise.
10410         (DW2_GDB_INDEX_SYMBOL_STATIC_SET_VALUE): Likewise.
10411         (DW2_GDB_INDEX_SYMBOL_KIND_SET_VALUE): Likewise.
10412         (DW2_GDB_INDEX_CU_SET_VALUE): Likewise.
10413         (byte_swap): Likewise.
10414         (MAYBE_SWAP): Likewise.
10415         (dwarf2_per_cu_ptr): Likewise.
10416         (DEF_VEC_P (dwarf2_per_cu_ptr)): Likewise.
10417         (struct tu_stats): Likewise.
10418         (struct dwarf2_per_objfile): Likewise.
10419         (struct dwarf2_per_cu_data): Likewise.
10420         (struct signatured_type): Likewise.
10421         (sig_type_ptr): Likewise.
10422         (DEF_VEC_P (sig_type_ptr)): Likewise.
10423         (INDEX4_SUFFIX): Likewise.
10424         (INDEX5_SUFFIX): Likewise.
10425         (DEBUG_STR_SUFFIX): Likewise.
10426         (dwarf2_read_section): Make non-static.
10427         (mapped_index_string_hash): Move from here.
10428         (dwarf5_djb_hash): Likewise.
10429         (file_write): Likewise.
10430         (class data_buf): Likewise.
10431         (struct symtab_index_entry): Likewise.
10432         (struct mapped_symtab): Likewise.
10433         (find_slot): Likewise.
10434         (hash_expand): Likewise.
10435         (add_index_entry): Likewise.
10436         (uniquify_cu_indices): Likewise.
10437         (class c_str_view): Likewise.
10438         (class c_str_view_hasher): Likewise.
10439         (class vector_hasher): Likewise.
10440         (write_hash_table): Likewise.
10441         (psym_index_map): Likewise.
10442         (struct addrmap_index_data): Likewise.
10443         (add_address_entry): Likewise.
10444         (add_address_entry_worker): Likewise.
10445         (write_address_map): Likewise.
10446         (symbol_kind): Likewise.
10447         (write_psymbols): Likewise.
10448         (struct signatured_type_index_data): Likewise.
10449         (write_one_signatured_type): Likewise.
10450         (recursively_count_psymbols): Likewise.
10451         (recursively_write_psymbols): Likewise.
10452         (class debug_names): Likewise.
10453         (check_dwarf64_offsets): Likewise.
10454         (psyms_seen_size): Likewise.
10455         (write_gdbindex): Likewise.
10456         (write_debug_names): Likewise.
10457         (assert_file_size): Likewise.
10458         (write_psymtabs_to_index): Likewise.
10459         (save_gdb_index_command): Likewise.
10460         (_initialize_dwarf2_read): Don't register the "save gdb-index"
10461         command.
10462         * dwarf2read.h: New file.
10463
10464 2018-03-27  Joel Brobecker  <brobecker@adacore.com>
10465
10466         PR gdb/22670
10467         * dwarf2read.c (dwarf2_physname): Do not return the demangled
10468         symbol name if the CU's language stores symbol names in linkage
10469         format.
10470         * language.h (struct language_defn)
10471         <la_store_sym_names_in_linkage_form_p>: New field.  Adjust
10472         all instances of this struct.
10473
10474 2018-03-26  Tom Tromey  <tom@tromey.com>
10475
10476         * stack.c (backtrace_command_1): Remove verbose code.
10477
10478 2018-03-26  Tom Tromey  <tom@tromey.com>
10479
10480         * python/py-framefilter.c (py_print_type): Don't catch
10481         exceptions.  Return void.
10482         (py_print_value): Likewise.
10483         (py_print_single_arg): Likewise.
10484         (enumerate_args): Don't catch exceptions.
10485         (py_print_args): Likewise.
10486         (py_print_frame): Likewise.
10487         (gdbpy_apply_frame_filter): Catch exceptions here.
10488
10489 2018-03-26  Tom Tromey  <tom@tromey.com>
10490
10491         * stack.c (_initialize_stack): Remove trailing newlines from help
10492         text.  Add "Usage" line to "backtrace" help.
10493
10494 2018-03-26  Tom Tromey  <tom@tromey.com>
10495
10496         PR python/16486:
10497         * python/py-framefilter.c (py_print_args): Call wrap_hint.
10498
10499 2018-03-26  Tom Tromey  <tom@tromey.com>
10500
10501         * python/py-framefilter.c (py_print_single_arg): Return
10502         EXT_LANG_BT_ERROR from catch.
10503
10504 2018-03-26  Tom Tromey  <tom@tromey.com>
10505
10506         PR backtrace/15584:
10507         * stack.c (backtrace_command_1): Move some code into no-filters
10508         "if".
10509
10510 2018-03-26  Tom Tromey  <tom@tromey.com>
10511
10512         * python/py-framefilter.c (throw_quit_or_print_exception): New
10513         function.
10514         (gdbpy_apply_frame_filter): Use it.
10515
10516 2018-03-26  Tom Tromey  <tom@tromey.com>
10517
10518         PR cli/17716:
10519         * python/py-framefilter.c (py_print_type, py_print_value)
10520         (enumerate_args, py_print_args, gdbpy_apply_frame_filter): Use
10521         RETURN_MASK_ERROR.
10522
10523 2018-03-26  Tom Tromey  <tom@tromey.com>
10524
10525         * python/py-framefilter.c (enumerate_args): Use
10526         gdb::unique_xmalloc_ptr.
10527
10528 2018-03-26  Tom Tromey  <tom@tromey.com>
10529
10530         * python/py-framefilter.c (py_print_frame): Return
10531         EXT_LANG_BT_OK.
10532         (gdbpy_apply_frame_filter): Update comment.
10533         * extension.h (enum ext_lang_bt_status) <EXT_LANG_BT_COMPLETED>:
10534         Remove.
10535         <EXT_LANG_BT_NO_FILTERS>: Change value.
10536
10537 2018-03-26  Tom Tromey  <tom@tromey.com>
10538
10539         PR backtrace/15582:
10540         * stack.c (backtrace_command): Parse "hide" argument.
10541         * python/py-framefilter.c (py_print_frame): Handle PRINT_HIDE.
10542         * extension.h (enum frame_filter_flags) <PRINT_HIDE>: New
10543         constant.
10544
10545 2018-03-26  Tom Tromey  <tom@tromey.com>
10546
10547         * stack.c (backtrace_command_1): Remove "show_locals" parameter,
10548         add "flags".
10549         (backtrace_command): Remove "fulltrace", add "flags".
10550
10551 2018-03-26  Tom Tromey  <tom@tromey.com>
10552
10553         * stack.c (backtrace_command): Rewrite command line parsing.
10554
10555 2018-03-26  Simon Marchi  <simon.marchi@ericsson.com>
10556
10557         * dwarf2read.c (DEF_VEC_I(offset_type)): Remove.
10558
10559 2018-03-26  Simon Marchi  <simon.marchi@ericsson.com>
10560
10561         * filename-seen-cache.h: Add include guard.
10562
10563 2018-03-26  Keith Seitz  <keiths@redhat.com>
10564
10565         * symfile.c (place_section): Remove "struct" from section_addr_info
10566         in comment.
10567         * windows-nat.c (struct safe_symbol_file_add_args) <addrs>: Remove
10568         "struct" keyword from section_addr_info.
10569
10570 2018-03-26  Alan Hayward  <alan.hayward@arm.com>
10571
10572         * regformats/regdef.h (reg): Add constructors.
10573
10574 2018-03-25  Pedro Alves  <palves@redhat.com>
10575
10576         * eval.c (evaluate_funcall): Swap OP_VAR_MSYM_VALUE/OP_VAR_VALUE
10577         if then/else bodies in var_func_name extraction.
10578
10579 2018-03-23  Weimin Pan  <weimin.pan@oracle.com>
10580
10581         * minsyms.c (lookup_minimal_symbol_and_objfile): Use
10582         lookup_minimal_symbol() to find symbol entry.
10583         * minsyms.h (lookup_minimal_symbol_and_objfile): Update comment.
10584
10585 2018-03-23  Keith Seitz  <keiths@redhat.com>
10586
10587         PR c++/22968
10588         * dwarf2read.c (scan_partial_symbols): Scan structs/classes for
10589         nested type definitions for C++, too.
10590
10591 2018-03-23  Tom Tromey  <tom@tromey.com>
10592
10593         * machoread.c (struct oso_el): Add a constructor.  Don't define as
10594         a typedef.
10595         (macho_register_oso): Remove.
10596         (macho_symtab_read): Take a std::vector.
10597         (oso_el_compare_name): Now a std::sort comparator.
10598         (macho_symfile_read_all_oso): Take a std::vector.
10599         (macho_symfile_read): Use std::vector.  Remove cleanups.
10600
10601 2018-03-22  Tom Tromey  <tom@tromey.com>
10602
10603         * record-full.c (record_full_exec_insn): Use gdb::byte_vector.
10604         (record_full_goto_bookmark): Use std::string.
10605
10606 2018-03-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
10607
10608         PR tdep/18295
10609         * rs6000-tdep.c (skip_prologue): Match both stwux and stdux
10610         a single mask.
10611
10612 2018-03-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
10613
10614         * rs6000-tdep.c (store_insn_p): New function.
10615         (skip_prologue): New variable alloca_reg_offset. Set lr_reg
10616         and cr_reg to their unshifted values. Use store_insn_p to
10617         match LR saves using either R1 or fdata->alloca_reg. Use
10618         store_insn_p to match CR saves. Set alloca_reg_offset
10619         when alloca_reg and framep are set. Remove lr_reg shift
10620         when assigning to fdata->lr_register.
10621
10622 2018-03-22  Andreas Arnez  <arnez@linux.vnet.ibm.com>
10623
10624         * linux-tdep.c (linux_info_proc): For "info proc cmdline", print
10625         command line args instead of emitting a warning.
10626
10627 2018-03-22  Simon Marchi  <simon.marchi@polymtl.ca>
10628
10629         * tracepoint.h (struct static_tracepoint_marker): Initialize
10630         fields, define default constructor, move constructor and move
10631         assignment, disable the rest.
10632         <str_id, extra>: Make std::string.
10633         (release_static_tracepoint_marker): Remove.
10634         (free_current_marker): Remove.
10635         * tracepoint.c (free_current_marker): Remove.
10636         (parse_static_tracepoint_marker_definition): Adjust to
10637         std::string, use new hex2str overload.
10638         (release_static_tracepoint_marker): Remove.
10639         (print_one_static_tracepoint_marker): Get marker by reference
10640         and adjust to std::string.
10641         (info_static_tracepoint_markers_command): Adjust to std::vector
10642         changes
10643         * target.h (static_tracepoint_marker_p): Remove typedef.
10644         (DEF_VEC_P(static_tracepoint_marker_p)): Remove.
10645         (struct target_ops) <to_static_tracepoint_marker_at>: Return
10646         bool.
10647         <to_static_tracepoint_markers_by_strid>: Return std::vector.
10648         * target-debug.h
10649         (target_debug_print_VEC_static_tracepoint_marker_p_p): Remove.
10650         (target_debug_print_std_vector_static_tracepoint_marker): New.
10651         (target_debug_print_struct_static_tracepoint_marker_p): Rename
10652         to...
10653         (target_debug_print_static_tracepoint_marker_p): ... this.
10654         * target-delegates.c: Re-generate.
10655         * breakpoint.h (struct tracepoint) <static_trace_marker_id>:
10656         Make std::string.
10657         * breakpoint.c (init_breakpoint_sal): Adjust to std::string.
10658         (decode_static_tracepoint_spec): Adjust to std::vector.
10659         (tracepoint_print_one_detail): Adjust to std::string.
10660         (strace_marker_decode_location): Adjust to std::string.
10661         (update_static_tracepoint): Adjust to std::string, remove call
10662         to release_static_tracepoint_marker.
10663         * linux-nat.c (linux_child_static_tracepoint_markers_by_strid):
10664         Adjust to std::vector.
10665         * remote.c (remote_static_tracepoint_marker_at): Return bool.
10666         (remote_static_tracepoint_markers_by_strid): Adjust to
10667         std::vector.
10668         * common/rsp-low.h (hex2str): New overload with explicit count
10669         of bytes.
10670         * common/rsp-low.c (hex2str): New overload with explicit count
10671         of bytes.
10672         * unittests/rsp-low-selftests.c (test_hex2str): New function.
10673         (_initialize_rsp_low_selftests): Add test_hex2str test.
10674         * unittests/tracepoint-selftests.c
10675         (test_parse_static_tracepoint_marker_definition): Adjust to
10676         std::string.
10677
10678 2018-03-22  Simon Marchi  <simon.marchi@polymtl.ca>
10679
10680         * tracepoint.c (parse_static_tracepoint_marker_definition):
10681         Consider case where the definition is followed by more
10682         definitions.
10683         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
10684         tracepoint-selftests.c.
10685         * unittests/tracepoint-selftests.c: New.
10686
10687 2018-03-21  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
10688
10689         * MAINTAINERS (Write After Approval): Add Pedro Franco de
10690         Carvalho.
10691
10692 2018-03-20  Stephen Roberts  <stephen.roberts@arm.com>
10693
10694         * symtab.c (find_pc_sect_line): fixed indentation.
10695
10696 2018-03-20  Stephen Roberts  <stephen.roberts@arm.com>
10697
10698         * symtab.c (find_pc_sect_line): now uses binary search.
10699
10700 2018-03-19  Tom Tromey  <tom@tromey.com>
10701
10702         * rust-exp.y (struct_expr_tail, struct_expr_list): Add plain
10703         "IDENT" production.
10704
10705 2018-03-19  Pedro Alves  <palves@redhat.com>
10706             Tom Tromey  <tom@tromey.com>
10707
10708         * unittests/observable-selftests.c: New file.
10709         * common/observable.h: New file.
10710         * observable.h: New file.
10711         * ada-lang.c, ada-tasks.c, agent.c, aix-thread.c, annotate.c,
10712         arm-tdep.c, auto-load.c, auxv.c, break-catch-syscall.c,
10713         breakpoint.c, bsd-uthread.c, cli/cli-interp.c, cli/cli-setshow.c,
10714         corefile.c, dummy-frame.c, event-loop.c, event-top.c, exec.c,
10715         extension.c, frame.c, gdbarch.c, guile/scm-breakpoint.c,
10716         infcall.c, infcmd.c, inferior.c, inflow.c, infrun.c, jit.c,
10717         linux-tdep.c, linux-thread-db.c, m68klinux-tdep.c,
10718         mi/mi-cmd-break.c, mi/mi-interp.c, mi/mi-main.c, objfiles.c,
10719         ppc-linux-nat.c, ppc-linux-tdep.c, printcmd.c, procfs.c,
10720         python/py-breakpoint.c, python/py-finishbreakpoint.c,
10721         python/py-inferior.c, python/py-unwind.c, ravenscar-thread.c,
10722         record-btrace.c, record-full.c, record.c, regcache.c, remote.c,
10723         riscv-tdep.c, sol-thread.c, solib-aix.c, solib-spu.c, solib.c,
10724         spu-multiarch.c, spu-tdep.c, stack.c, symfile-mem.c, symfile.c,
10725         symtab.c, thread.c, top.c, tracepoint.c, tui/tui-hooks.c,
10726         tui/tui-interp.c, valops.c: Update all users.
10727         * tui/tui-hooks.c (tui_bp_created_observer)
10728         (tui_bp_deleted_observer, tui_bp_modified_observer)
10729         (tui_inferior_exit_observer, tui_before_prompt_observer)
10730         (tui_normal_stop_observer, tui_register_changed_observer):
10731         Remove.
10732         (tui_observers_token): New global.
10733         (attach_or_detach, tui_attach_detach_observers): New functions.
10734         (tui_install_hooks, tui_remove_hooks): Use
10735         tui_attach_detach_observers.
10736         * record-btrace.c (record_btrace_thread_observer): Remove.
10737         (record_btrace_thread_observer_token): New global.
10738         * observer.sh: Remove.
10739         * observer.c: Rename to observable.c.
10740         * observable.c (namespace gdb_observers): Define new objects.
10741         (observer_debug): Move into gdb_observers namespace.
10742         (struct observer, struct observer_list, xalloc_observer_list_node)
10743         (xfree_observer_list_node, generic_observer_attach)
10744         (generic_observer_detach, generic_observer_notify): Remove.
10745         (_initialize_observer): Update.
10746         Don't include observer.inc.
10747         * Makefile.in (generated_files): Remove observer.h, observer.inc.
10748         (clean mostlyclean): Likewise.
10749         (observer.h, observer.inc): Remove targets.
10750         (SUBDIR_UNITTESTS_SRCS): Add observable-selftests.c.
10751         (COMMON_SFILES): Use observable.c, not observer.c.
10752         * .gitignore: Remove observer.h.
10753
10754 2018-03-18  Tom Tromey  <tom@tromey.com>
10755
10756         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Use
10757         gdb::def_vector.
10758         (bfd_lookup_symbol_from_dyn_symtab): Likewise.
10759
10760 2018-03-17  Tom Tromey  <tom@tromey.com>
10761
10762         * auto-load.c (auto_load_objfile_script_1): Use std::string.
10763
10764 2018-03-17  Tom Tromey  <tom@tromey.com>
10765
10766         * target.c (class scoped_target_fd): New.
10767         (target_fileio_close_cleanup): Remove.
10768         (target_fileio_read_alloc_1): Use scoped_target_fd.
10769
10770 2018-03-16  Simon Marchi  <simon.marchi@polymtl.ca>
10771
10772         * silent-rules.mk: New.
10773         * Makefile.in: Include silent-rules.mk
10774         (srcdir, VPATH, top_srcdir): Move up.
10775         (COMPILE): Add ECHO_CXX.
10776         (test-cp-name-parser$(EXEEXT)): Add ECHO_CXXLD.
10777         (init.c): Add ECHO_INIT_C.
10778         (gdb$(EXEEXT)): Add SILENCE and ECHO_CXXLD.
10779         (version.c): Add ECHO_GEN.
10780         (printcmd.o): Add ECHO_CXX.
10781         (target-float.o): Add ECHO_CXX.
10782         (ada-exp.o): Add ECHO_CXX.
10783         (stamp-xml): Add SILENCE and ECHO_GEN_XML_BUILTIN.
10784         (insight$(EXEEXT)): Add ECHO_CXXLD.
10785         * gnulib/configure.ac: Add AM_SILENT_RULES.
10786         * gnulib/aclocal.m4: Re-generate.
10787         * gnulib/configure: Re-generate.
10788         * gnulib/import/Makefile.in: Re-generate.
10789
10790 2018-03-16  Tom Tromey  <tom@tromey.com>
10791
10792         * xcoffread.c (xcoff_symfile_offsets): Change type of "addrs".
10793         * utils.h (make_cleanup_free_section_addr_info): Don't declare.
10794         * utils.c (do_free_section_addr_info)
10795         (make_cleanup_free_section_addr_info): Remove.
10796         * symfile.h (struct other_sections): Add constructor.
10797         (struct section_addr_info): Remove.
10798         (section_addr_info): New typedef.
10799         (struct sym_fns) <sym_offsets>: Change type of parameter.
10800         (build_section_addr_info_from_objfile)
10801         (relative_addr_info_to_section_offsets, addr_info_make_relative)
10802         (default_symfile_offsets, symbol_file_add)
10803         (symbol_file_add_from_bfd)
10804         (build_section_addr_info_from_section_table): Update.
10805         (alloc_section_addr_info, free_section_addr_info): Don't declare.
10806         * symfile.c (alloc_section_addr_info): Remove.
10807         (build_section_addr_info_from_section_table): Change return type.
10808         Update.
10809         (build_section_addr_info_from_bfd)
10810         (build_section_addr_info_from_objfile): Likewise.
10811         (free_section_addr_info): Remove.
10812         (relative_addr_info_to_section_offsets): Change type of "addrs".
10813         (addrs_section_compar): Now a std::sort comparator.
10814         (addrs_section_sort): Change return type.
10815         (addr_info_make_relative): Change type of "addrs".  Update.
10816         (default_symfile_offsets, syms_from_objfile_1)
10817         (syms_from_objfile, symbol_file_add_with_addrs): Likewise.
10818         (symbol_file_add_separate): Update.
10819         (symbol_file_add): Change type of "addrs".  Update.
10820         (add_symbol_file_command): Update.  Remove cleanups.
10821         * symfile-mem.c (symbol_file_add_from_memory): Update.  Remove
10822         cleanups.
10823         * symfile-debug.c (debug_sym_offsets): Change type of "info".
10824         * solib.c (solib_read_symbols): Update.
10825         * objfiles.c (objfile_relocate): Update.  Remove cleanups.
10826         * machoread.c (macho_symfile_offsets): Update.
10827         * jit.c (jit_bfd_try_read_symtab): Update.
10828
10829 2018-03-15  Simon Marchi  <simon.marchi@polymtl.ca>
10830
10831         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
10832         unittests/utils-selftests.c.
10833         * unittests/utils-selftests.c: New file.
10834
10835 2018-03-14  Tom Tromey  <tom@tromey.com>
10836
10837         PR cli/14977:
10838         * printcmd.c (printf_c_string, printf_wide_c_string): Special case
10839         for NULL.
10840
10841 2018-03-14  Tom Tromey  <tom@tromey.com>
10842
10843         PR cli/19918:
10844         * printcmd.c (printf_pointer): Allow "-" in format.
10845
10846 2018-03-14  Tom Tromey  <tom@tromey.com>
10847
10848         * printcmd.c (_initialize_printcmd): Add usage to printf.
10849
10850 2018-03-14  Yao Qi  <qiyao@sourceware.org>
10851
10852         * MAINTAINERS: Update my email address.
10853
10854 2018-03-13  Tom Tromey  <tom@tromey.com>
10855
10856         * machoread.c (macho_check_dsym): Change filenamep to a
10857         std::string*.
10858         (macho_symfile_read): Update.
10859         * symfile.c (load_command): Use std::string.
10860
10861 2018-03-12  Andrew Burgess  <andrew.burgess@embecosm.com>
10862
10863         * riscv-tdep.c (riscv_sw_breakpoint_from_kind): Add localization
10864         to error message string.
10865         (riscv_register_name): Use xsnprintf instead of sprintf.
10866         (riscv_insn::fetch_instruction): Use gdb_assert instead of
10867         internal_error.
10868         (riscv_print_arg_location): Use gdb_assert_not_reached instead of
10869         error.
10870         (riscv_push_dummy_call): Likewise.
10871
10872 2018-03-12  Tom Tromey  <tom@tromey.com>
10873
10874         * rs6000-aix-tdep.c (rs6000_aix_core_xfer_shared_libraries_aix):
10875         Use gdb::byte_vector.
10876         * arm-tdep.c (arm_exidx_new_objfile): Use gdb::byte_vector.
10877
10878 2018-03-12  Yao Qi  <yao.qi@linaro.org>
10879
10880         * ia64-libunwind-tdep.c (libunwind_get_reg_special): Change
10881         parameter type to readable_regcache.
10882         * ia64-libunwind-tdep.h (libunwind_get_reg_special): Update
10883         the declaration.
10884
10885 2018-03-11  Tom Tromey  <tom@tromey.com>
10886
10887         * dwarf2read.c (struct nextfield): Add initializers.
10888         (struct nextfnfield): Remove.
10889         (struct fnfieldlist): Add initializers.  Remove "length" and
10890         "head", use std::vector.
10891         (struct decl_field_list): Remove.
10892         (struct field_info): Add initializers.
10893         <fields, baseclasses>: Now std::vector.
10894         <nbaseclasses, nfnfields, typedef_field_list_count,
10895         nested_types_list_count>: Remove.
10896         (dwarf2_add_field, dwarf2_add_type_defn)
10897         (dwarf2_attach_fields_to_type, dwarf2_add_member_fn)
10898         (dwarf2_attach_fn_fields_to_type, handle_struct_member_die)
10899         (process_structure_scope): Update.
10900
10901 2018-03-11  Tom Tromey  <tom@tromey.com>
10902
10903         * dwarf2read.c (sort_tu_by_abbrev_offset): Change to be suitable
10904         for use by std::sort.
10905         (build_type_psymtabs_1): Use std::vector.
10906
10907 2018-03-09  Eli Zaretskii  <eliz@gnu.org>
10908
10909         * top.c (print_gdb_configuration): Reflect LIBIPT, LIBMEMCHECK,
10910         and LIBMPFR in the printed configuration.
10911
10912 2018-03-08  Tom Tromey  <tom@tromey.com>
10913
10914         * source.c (get_filename_and_charpos): Use scoped_fd.
10915         * nto-procfs.c (procfs_open_1): Use scoped_fd.
10916         (procfs_pidlist): Likewise.
10917         * procfs.c (proc_get_LDT_entry): Use scoped_fd.
10918         (iterate_over_mappings): Likewise.
10919
10920 2018-03-08  Tom Tromey  <tom@tromey.com>
10921
10922         * infcall.c (struct call_return_meta_info)
10923         <stack_temporaries_enabled>: Remove.
10924         (get_call_return_value, call_function_by_hand_dummy): Update.
10925         * thread.c (disable_thread_stack_temporaries): Remove.
10926         (enable_thread_stack_temporaries): Remove.
10927         (thread_stack_temporaries_enabled_p): Return bool.
10928         (push_thread_stack_temporary, value_in_thread_stack_temporaries)
10929         (get_last_thread_stack_temporary): Update.
10930         * eval.c (evaluate_subexp): Update.
10931         * gdbthread.h (class enable_thread_stack_temporaries): Now a
10932         class, not a function.
10933         (value_ptr, value_vec): Remove typedefs.
10934         (class thread_info) <stack_temporaries_enabled>: Now bool.
10935         <stack_temporaries>: Now a std::vector.
10936         (thread_stack_temporaries_enabled_p)
10937         (value_in_thread_stack_temporaries): Return bool.
10938
10939 2018-03-08  Simon Marchi  <simon.marchi@ericsson.com>
10940
10941         * remote.c (putpkt_binary): Fix omitted bytes reporting.
10942         (getpkt_or_notif_sane_1): Likewise.
10943
10944 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
10945
10946         * build-id.c (build_id_to_debug_bfd): Use std::string.
10947
10948 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
10949
10950         * build-id.c (find_separate_debug_file_by_buildid): Return
10951         std::string.
10952         * build-id.h (find_separate_debug_file_by_buildid): Return
10953         std::string.
10954         * coffread.c (coff_symfile_read): Adjust to std::string.
10955         * elfread.c (elf_symfile_read): Adjust to std::string.
10956         * symfile.c (separate_debug_file_exists): Change parameter to
10957         std::string.
10958         (find_separate_debug_file): Return std::string.
10959         (find_separate_debug_file_by_debuglink): Return std::string.
10960         * symfile.h (find_separate_debug_file_by_debuglink): Return
10961         std::string.
10962
10963 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
10964
10965         * common/xml-utils.c (xml_escape_text): Move code to...
10966         (xml_escape_text_append): ... this new function.
10967         * common/xml-utils.h (xml_escape_text_append): New declaration.
10968         * unittests/xml-utils-selftests.c (test_xml_escape_text_append):
10969         New function.
10970         (_initialize_xml_utils): register test_xml_escape_text_append as
10971         a selftest.
10972
10973 2018-03-07  Alan Hayward  <alan.hayward@arm.com>
10974
10975         * defs.h: Remove MAX_REGISTER_SIZE.
10976         * regcache.c (init_regcache_descr): Remove MAX_REGISTER_SIZE
10977         asserts.
10978         * python/py-unwind.c (pyuw_sniffer): Likewise.
10979
10980 2018-03-07  Tom Tromey  <tom@tromey.com>
10981
10982         * linux-tdep.c (linux_info_proc): Update.
10983         * target.h (struct target_ops) <to_fileio_readlink>: Return
10984         optional<string>.
10985         (target_fileio_readlink): Return optional<string>.
10986         * remote.c (remote_hostio_readlink): Return optional<string>.
10987         * inf-child.c (inf_child_fileio_readlink): Return
10988         optional<string>.
10989         * target.c (target_fileio_readlink): Return optional<string>.
10990
10991 2018-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
10992
10993         * regcache.c (cooked_read_test): Add riscv to the list of
10994         architectures that have a save_reggroup.
10995
10996 2018-03-07  Andreas Arnez  <arnez@linux.vnet.ibm.com>
10997
10998         * gnu-v3-abi.c (gnuv3_rtti_type): Add early exit if the given
10999         value is not a dynamic class object.
11000
11001 2018-03-06  Tom Tromey  <tom@tromey.com>
11002
11003         * rust-exp.y: Formatting fixes.
11004
11005 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11006
11007         * riscv-tdep.c (riscv_register_name): Remove target description
11008         support.
11009         (riscv_gdbarch_init): Remove target description check.
11010
11011 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11012
11013         * riscv-tdep.c: Remove 'Contributed by ...' lines from header
11014         comment.
11015         * riscv-tdep.h: Likewise.
11016
11017 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11018
11019         * riscv-tdep.c (riscv_pseudo_register_read): Delete.
11020         (riscv_pseudo_register_write): Delete.
11021         (riscv_gdbarch_init): Remove all use of pseudo registers.
11022
11023 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
11024
11025         * record-btrace.c (btrace_print_lines): Replace cleanup
11026         parameter with RAII equivalents.
11027         (btrace_insn_history): Replace cleanup with RAII equivalents.
11028         * ui-out.h (make_cleanup_ui_out_list_begin_end,
11029         make_cleanup_ui_out_tuple_begin_end): Remove.
11030         * ui-out.c (struct ui_out_end_cleanup_data, do_cleanup_end,
11031         make_cleanup_ui_out_end, make_cleanup_ui_out_tuple_begin_end,
11032         make_cleanup_ui_out_list_begin_end): Remove.
11033
11034 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
11035
11036         * record-btrace.c (record_btrace_maybe_mark_async_event): Change
11037         parameter types to std::vector.  Use bool.
11038         (record_btrace_wait): Replace VEC(tp_t) with
11039         std::vector<thread_info *>.
11040         * common/gdb_vecs.h (unordered_remove, ordered_remove): New.
11041
11042 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
11043
11044         * record-btrace.c (record_btrace_disable_callback): Remove.
11045         (struct scoped_btrace_disable): New.
11046         (record_btrace_open): Use scoped_btrace_disable.
11047
11048 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11049
11050         * riscv-tdep.c (riscv_return_value): Change type to ULONGEST for
11051         reading values from registers.
11052
11053 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11054
11055         * riscv-tdep.c (riscv_push_dummy_call): Use core_addr_to_string_nz
11056         where appropriate.
11057
11058 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11059
11060         * riscv-tdep.c (riscv_print_arg_location): Add header comment,
11061         change parameter type.  Use GDB's print functions, and use
11062         core_addr_to_string where appropriate.
11063         (riscv_push_dummy_call): Use core_addr_to_string where
11064         appropriate, update call to riscv_print_arg_location, and reindent
11065         a few lines.
11066         (riscv_return_value): Update call to riscv_print_arg_location.
11067
11068 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11069             Tim Newsome <tim@sifive.com>
11070             Albert Ou <a0u@eecs.berkeley.edu>
11071             Darius Rad <darius@bluespec.com>
11072
11073         * Makefile.in (ALL_TARGET_OBS): Add riscv-tdep.o
11074         (HFILES_NO_SRCDIR): Add riscv-tdep.h.
11075         (ALLDEPFILES): Add riscv-tdep.c
11076         * configure.tgt: Add riscv support.
11077         * riscv-tdep.c: New file.
11078         * riscv-tdep.h: New file.
11079         * NEWS: Mention new target.
11080         * MAINTAINERS: Add entry for riscv.
11081
11082 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11083
11084         * amd64-tdep.c (amd64_classify_aggregate): Ignore zero sized
11085         fields within aggregates.
11086
11087 2018-03-04  Simon Marchi  <simon.marchi@polymtl.ca>
11088
11089         * record-btrace.c (btrace_print_lines): Change type of flags to
11090         gdb_disassembly_flags.
11091
11092 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
11093
11094         * fbsd-nat.c: Include "inf-ptrace.h".
11095         (USE_SIGTRAP_SIGINFO): Conditionally define.
11096         [USE_SIGTRAP_SIGINFO] (fbsd_handle_debug_trap): New function.
11097         (fbsd_wait) [USE_SIGTRAP_SIGINFO]: Call "fbsd_handle_debug_trap".
11098         [USE_SIGTRAP_SIGINFO] (fbsd_stopped_by_sw_breakpoint): New
11099         function.
11100         [USE_SIGTRAP_SIGINFO] (fbsd_supports_stopped_by_sw_breakpoint):
11101         Likewise.
11102         [USE_SIGTRAP_SIGINFO] (fbsd_supports_stopped_by_hw_breakpoint):
11103         Likewise.
11104         (fbsd_nat_add_target) [USE_SIGTRAP_SIGINFO]: Set
11105         "stopped_by_sw_breakpoint", "supports_stopped_by_sw_breakpoint",
11106         "supports_stopped_by_hw_breakpoint" target methods.
11107
11108 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
11109
11110         * NEWS (Changes since GDB 8.1): Add "set/show debug fbsd-nat".
11111         * fbsd-nat.c (debug_fbsd_nat): New variable.
11112         (show_fbsd_nat_debug): New function.
11113         (fbsd_wait): Log LWP info if "debug_fbsd_nat" is enabled.
11114         (_initialize_fbsd_nat): Add "fbsd-nat" debug boolean command.
11115
11116 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
11117
11118         * nat/x86-dregs.c (x86_dr_stopped_by_hw_breakpoint): New function.
11119         * nat/x86-dregs.h (x86_dr_stopped_by_hw_breakpoint): New
11120         prototype.
11121         * x86-nat.c (x86_stopped_by_hw_breakpoint): New function.
11122         (x86_use_watchpoints): Set "stopped_by_hw_breakpoint" target
11123         method.
11124
11125 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
11126
11127         * common/gdb_vecs.c (free_char_ptr_vec): Remove.
11128         * common/gdb_vecs.h (free_char_ptr_vec): Remove.
11129
11130 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
11131
11132         * charset.c (struct charset_vector): New.
11133         (charsets): Change type to charset_vector.
11134         (find_charset_names): Adjust.
11135         (add_one): Adjust.
11136         (_initialize_charset): Adjust.
11137
11138 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
11139
11140         * progspace.h (struct program_space) <deleted_solibs>: Change
11141         type to std::vector<std::string>.
11142         * progspace.c (clear_program_space_solib_cache): Adjust.
11143         * breakpoint.c (print_solib_event): Adjust.
11144         (check_status_catch_solib): Adjust.
11145         * solib.c (update_solib_list): Adjust.
11146         * ui-out.h (class ui_out) <field_string>: New overload.
11147         * ui-out.c (ui_out::field_string): New overload.
11148
11149 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
11150
11151         * progspace.h (struct program_space): Add constructor and
11152         destructor, initialize fields.
11153         (add_program_space): Remove.
11154         * progspace.c (add_program_space): Rename to...
11155         (program_space::program_space): ... this.
11156         (release_program_space): Rename to...
11157         (program_space::~program_space): ... this.
11158         (delete_program_space): Use delete to delete program_space.
11159         (initialize_progspace): Use new to allocate program_space.
11160         * inferior.c (add_inferior_with_spaces): Likewise.
11161         (clone_inferior_command): Likewise.
11162         * infrun.c (follow_fork_inferior): Likewise.
11163         (handle_vfork_child_exec_or_exit): Likewise.
11164
11165 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
11166
11167         * common/gdb_vecs.h (make_cleanup_free_char_ptr_vec): Remove.
11168         (delim_string_to_char_ptr_vec): Return std::vector of
11169         gdb::unique_xmalloc_ptr.
11170         (dirnames_to_char_ptr_vec_append): Take std::vector of
11171         gdb::unique_xmalloc_ptr.
11172         (dirnames_to_char_ptr_vec): Return std::vector of
11173         gdb::unique_xmalloc_ptr.
11174         * common/gdb_vecs.c (delim_string_to_char_ptr_vec_append):
11175         Take std::vector of gdb::unique_xmalloc_ptr, adjust the code.
11176         (delim_string_to_char_ptr_vec): Return an std::vector of
11177         gdb::unique_xmalloc_ptr, adjust the code.
11178         (dirnames_to_char_ptr_vec_append): Take an std::vector of
11179         gdb::unique_xmalloc_ptr, adjust the code.
11180         (dirnames_to_char_ptr_vec): Return an std::vector of
11181         gdb::unique_xmalloc_ptr, adjust the code.
11182         * auto-load.c (auto_load_safe_path_vec): Change type to
11183         std::vector of gdb::unique_xmalloc_ptr.
11184         (auto_load_expand_dir_vars): Return an std::vector of
11185         gdb::unique_xmalloc_ptr, adjust the code.
11186         (auto_load_safe_path_vec_update): Adjust.
11187         (filename_is_in_auto_load_safe_path_vec): Adjust.
11188         (auto_load_objfile_script_1): Adjust.
11189         * build-id.c (build_id_to_debug_bfd): Adjust.
11190         * linux-thread-db.c (thread_db_load_search): Adjust.
11191         * source.c (add_path): Adjust.
11192         (openp): Adjust.
11193         * symfile.c (find_separate_debug_file): Adjust.
11194         * utils.c (do_free_char_ptr_vec): Remove.
11195         (make_cleanup_free_char_ptr_vec): Remove.
11196
11197 2018-03-01  Sergio Durigan Junior  <sergiodj@redhat.com>
11198
11199         PR gdb/22907
11200         * common/pathstuff.c: Conditionally include "<windows.h>".
11201
11202 2018-03-01  Georg Sauthoff  <mail@georg.so>
11203
11204         PR gdb/22888
11205         * gcore.in: Quote variables and switch interpreter to bash.
11206
11207 2018-03-01  Tom Tromey  <tom@tromey.com>
11208
11209         * dwarf2read.c (alloc_discriminant_info): Fix default_index
11210         assertion.  Add assertion for discriminant_index.
11211         (quirk_rust_enum): Use correct base type name in univariant case.
11212
11213 2018-03-01  Simon Marchi  <simon.marchi@ericsson.com>
11214
11215         * record.c (get_call_history_modifiers): Return a
11216         record_print_flags.
11217         (cmd_record_call_history): Adjust.
11218         * record-btrace.c (record_btrace_call_history): Adjust.
11219         (record_btrace_call_history_range): Adjust.
11220         (record_btrace_call_history_from): Adjust.
11221         * target-debug.h (target_debug_print_record_print_flags): New.
11222         * target-delegates.c: Re-generate.
11223         * target.c (target_call_history): Change flags type.
11224         (target_call_history_from): Likewise.
11225         (target_call_history_range): Likewise.
11226         * target.h (struct target_ops) <target_call_history>: Likewise.
11227         (target_call_history_from): Likewise.
11228         (target_call_history_range): Likewise.
11229
11230 2018-02-28  Sergio Durigan Junior  <sergiodj@redhat.com>
11231             Simon Marchi  <simon.marchi@polymtl.ca>
11232
11233         * common/common-utils.c: Include "sys/stat.h".
11234         (is_regular_file): Move here from "source.c"; change return
11235         type to "bool".
11236         * common/common-utils.h (is_regular_file): New prototype.
11237         * common/pathstuff.c (contains_dir_separator): New function.
11238         * common/pathstuff.h (contains_dir_separator): New prototype.
11239         * source.c: Don't include "sys/stat.h".
11240         (is_regular_file): Move to "common/common-utils.c".
11241
11242 2018-02-28  Sergio Durigan Junior  <sergiodj@redhat.com>
11243
11244         * Makefile.in (COMMON_SFILES): Add "common/pathstuff.c".
11245         (HFILES_NO_SRCDIR): Add "common/pathstuff.h".
11246         * auto-load.c: Include "common/pathstuff.h".
11247         * common/common-def.h (current_directory): Move here.
11248         * common/gdb_tilde_expand.c (gdb_tilde_expand_up): New
11249         function.
11250         * common/gdb_tilde_expand.h (gdb_tilde_expand_up): New
11251         prototype.
11252         * common/pathstuff.c: New file.
11253         * common/pathstuff.h: New file.
11254         * compile/compile.c: Include "common/pathstuff.h".
11255         * defs.h (current_directory): Move to "common/common-defs.h".
11256         * dwarf2read.c: Include "common/pathstuff.h".
11257         * exec.c: Likewise.
11258         * guile/scm-safe-call.c: Likewise.
11259         * linux-thread-db.c: Likewise.
11260         * main.c: Likewise.
11261         * nto-tdep.c: Likewise.
11262         * objfiles.c: Likewise.
11263         * source.c: Likewise.
11264         * symtab.c: Likewise.
11265         * utils.c: Include "common/pathstuff.h".
11266         (gdb_realpath): Move to "common/pathstuff.c".
11267         (gdb_realpath_keepfile): Likewise.
11268         (gdb_abspath): Likewise.
11269         * utils.h (gdb_realpath): Move to "common/pathstuff.h".
11270         (gdb_realpath_keepfile): Likewise.
11271         (gdb_abspath): Likewise.
11272
11273 2018-02-28  John Baldwin  <jhb@FreeBSD.org>
11274
11275         * fbsd-nat.c (fbsd_resume): Use PT_SETSTEP for stepping and a
11276         wildcard process pid for super_resume for kernels with a
11277         specific bug.
11278
11279 2018-02-27  Phil Muldoon  <pmuldoon@redhat.com>
11280
11281         * compile/compile.c (get_args): Add additional comments
11282         explaining function.
11283
11284 2018-02-27  Simon Marchi  <simon.marchi@polymtl.ca>
11285             Tom Tromey  <tom@tromey.com>
11286
11287         * target.h (memory_write_request_s): Remove typedef.  Don't define
11288         VEC.
11289         (target_write_memory_blocks): Change argument to std::vector.
11290         (struct memory_write_request): Add constructor.
11291         * target-memory.c (compare_block_starting_address): Return bool.
11292         Change argument types.
11293         (claim_memory): Change arguments to use std::vector.
11294         (split_regular_and_flash_blocks, blocks_to_erase)
11295         (compute_garbled_blocks): Likewise.
11296         (cleanup_request_data, cleanup_write_requests_vector): Remove.
11297         (target_write_memory_blocks): Change argument to std::vector.
11298         * symfile.c (struct load_section_data): Add constructor and
11299         destructor.  Use std::vector for "requests".
11300         (struct load_progress_data): Add initializers.
11301         (load_section_callback): Update.  Use "new".
11302         (clear_memory_write_data): Remove.
11303         (generic_load): Update.
11304
11305 2018-02-27  Alan Hayward  <alan.hayward@arm.com>
11306
11307         * arch/aarch64.h: Use common/tdesc.h.
11308
11309 2018-02-26  Maciej W. Rozycki  <macro@mips.com>
11310
11311         * mips-tdep.c (mips_gdbarch_init): Don't use a 32-bit BFD
11312         architecture with a 64-bit ABI.
11313
11314 2018-02-26  Maciej W. Rozycki  <macro@mips.com>
11315
11316         * gdb/mips-tdep.c (mips_gdbarch_init): Reorder ABI determination
11317         ahead of target description loading.
11318
11319 2018-02-26  Tom Tromey  <tom@tromey.com>
11320
11321         * stack.c (backtrace_command_1): Update.
11322         * python/python-internal.h (gdbpy_apply_frame_filter): Change type
11323         of "flags".
11324         * python/py-framefilter.c (py_print_frame)
11325         (gdbpy_apply_frame_filter): Change type of "flags".
11326         * mi/mi-cmd-stack.c (mi_apply_ext_lang_frame_filter): Change type
11327         of "flags".
11328         (mi_cmd_stack_list_frames, mi_cmd_stack_list_locals)
11329         (mi_cmd_stack_list_args, mi_cmd_stack_list_variables): Update.
11330         * extension.h (enum frame_filter_flag): Rename from
11331         frame_filter_flags.
11332         (frame_filter_flags): Define using DEF_ENUM_FLAGS_TYPE.
11333         (apply_ext_lang_frame_filter): Change type of "flags".
11334         * extension.c (apply_ext_lang_frame_filter): Change type of
11335         "flags".
11336         * extension-priv.h (struct extension_language_ops)
11337         <apply_frame_filter>: Change type of "flags".
11338
11339 2018-02-26  Tom Tromey  <tom@tromey.com>
11340
11341         PR python/16497:
11342         * stack.c (backtrace_command_1): Set PRINT_MORE_FRAMES flag.  Fix
11343         off-by-one in py_end computation.
11344         * python/py-framefilter.c (gdbpy_apply_frame_filter): Handle
11345         PRINT_MORE_FRAMES.
11346         * extension.h (enum frame_filter_flags) <PRINT_MORE_FRAMES>: New
11347         constant.
11348
11349 2018-02-26  Tom Tromey  <tom@tromey.com>
11350
11351         * dwarf2read.c (struct variant_field): New.
11352         (struct nextfield) <variant>: New field.
11353         (dwarf2_add_field): Handle DW_TAG_variant_part.
11354         (dwarf2_attach_fields_to_type): Attach a discriminant_info to a
11355         discriminated union.
11356         (read_structure_type): Handle DW_TAG_variant_part.
11357         (handle_struct_member_die): New function, extracted from
11358         process_structure_scope.  Handle DW_TAG_variant.
11359         (process_structure_scope): Handle discriminated unions.  Call
11360         handle_struct_member_die.
11361
11362 2018-02-26  Tom Tromey  <tom@tromey.com>
11363
11364         * rust-lang.h (rust_last_path_segment): Declare.
11365         * rust-lang.c (rust_last_path_segment): Now public.  Change
11366         contract.
11367         (struct disr_info): Remove.
11368         (RUST_ENUM_PREFIX, RUST_ENCODED_ENUM_REAL)
11369         (RUST_ENCODED_ENUM_HIDDEN, rust_union_is_untagged)
11370         (rust_get_disr_info, rust_tuple_variant_type_p): Remove.
11371         (rust_enum_p, rust_enum_variant): New function.
11372         (rust_underscore_fields): Remove "offset" parameter.
11373         (rust_print_enum): New function.
11374         (rust_val_print) <TYPE_CODE_UNION>: Remove enum code.
11375         <TYPE_CODE_STRUCT>: Call rust_print_enum when appropriate.
11376         (rust_print_struct_def): Add "for_rust_enum" parameter.  Handle
11377         enums.
11378         (rust_internal_print_type): New function, from rust_print_type.
11379         Remove enum code.
11380         (rust_print_type): Call rust_internal_print_type.
11381         (rust_evaluate_subexp) <STRUCTOP_ANONYMOUS, STRUCTOP_STRUCT>:
11382         Update enum handling.
11383         * dwarf2read.c (struct dwarf2_cu) <rust_unions>: New field.
11384         (rust_fully_qualify, alloc_discriminant_info, quirk_rust_enum)
11385         (rust_union_quirks): New functions.
11386         (process_full_comp_unit, process_full_type_unit): Call
11387         rust_union_quirks.
11388         (process_structure_scope): Update rust_unions if necessary.
11389
11390 2018-02-26  Tom Tromey  <tom@tromey.com>
11391
11392         * value.h (value_union_variant): Declare.
11393         * valops.c (value_union_variant): New function.
11394         * gdbtypes.h (TYPE_FLAG_DISCRIMINATED_UNION): New macro.
11395         (struct discriminant_info): New.
11396         (enum dynamic_prop_node_kind) <DYN_PROP_DISCRIMINATED>: New
11397         enumerator.
11398         (struct main_type) <flag_discriminated_union>: New field.
11399
11400 2018-02-26  Tom Tromey  <tom@tromey.com>
11401
11402         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
11403         unittests/unpack-selftests.c.
11404         * unittests/unpack-selftests.c: New file.
11405         * value.c (unpack_bits_as_long): Fix bugs in non-bitfield cases.
11406
11407 2018-02-26  Yao Qi  <yao.qi@linaro.org>
11408
11409         * dwarf2read.c (struct partial_die_info) <read>: New method.
11410         (read_partial_die): Remove the declaration.
11411         (load_partial_dies): Update.
11412         (partial_die_info::partial_die_info):
11413         (read_partial_die): Change it to partial_die_info::read.
11414
11415 2018-02-26  Yao Qi  <yao.qi@linaro.org>
11416
11417         * dwarf2read.c (struct partial_die_info) <fixup>: New method.
11418         (fixup_partial_die): Remove declaration.
11419         (scan_partial_symbols): Update.
11420         (partial_die_parent_scope): Likewise.
11421         (partial_die_full_name): Likewise.
11422         (fixup_partial_die): Change it to partial_die_info::fixup.
11423
11424 2018-02-26  Yao Qi  <yao.qi@linaro.org>
11425
11426         * dwarf2read.c (read_partial_die): Update the declaration.
11427         (load_partial_dies): Caller update.
11428         (read_partial_die): Remove one argument abbrev_len.
11429
11430 2018-02-26  Yao Qi  <yao.qi@linaro.org>
11431
11432         * dwarf2read.c (struct partial_die_info): Add ctor, delete
11433         assignment operator.
11434         (load_partial_dies): Use ctor and copy ctor.
11435         (read_partial_die): Update.
11436         (dwarf2_cu::find_partial_die): Use ctor.
11437
11438 2018-02-26  Yao Qi  <yao.qi@linaro.org>
11439
11440         * dwarf2read.c (struct dwarf2_cu) <find_partial_die>: New method.
11441         (find_partial_die_in_comp_unit): Change it to
11442         dwarf2_cu::find_partial_die.
11443         (find_partial_die): Update.
11444
11445 2018-02-26  Yao Qi  <yao.qi@linaro.org>
11446
11447         * dwarf2read.c (read_partial_die): Remove the code checking abbrev
11448         is NULL.
11449
11450 2018-02-26  Yao Qi  <yao.qi@linaro.org>
11451
11452         * dwarf2read.c (load_partial_dies): Move the location of XOBNEW.
11453
11454 2018-02-26  Alan Hayward  <alan.hayward@arm.com>
11455
11456         * arch/amd64.h: Use common/tdesc.h.
11457         * arch/i386.c: Likewise.
11458         * arch/i386.h: Likewise.
11459         * arch/tic6x.c: Likewise.
11460         * arch/tdesc.h: Move file from here...
11461         * common/tdesc.h: ...to here.
11462         * features/aarch64-core.c: Regenerate.
11463         * features/aarch64-fpu.c: Regenerate.
11464         * features/i386/32bit-avx.c: Regenerate.
11465         * features/i386/32bit-avx512.c: Regenerate.
11466         * features/i386/32bit-core.c: Regenerate.
11467         * features/i386/32bit-linux.c: Regenerate.
11468         * features/i386/32bit-mpx.c: Regenerate.
11469         * features/i386/32bit-pkeys.c: Regenerate.
11470         * features/i386/32bit-sse.c: Regenerate.
11471         * features/i386/64bit-avx.c: Regenerate.
11472         * features/i386/64bit-avx512.c: Regenerate.
11473         * features/i386/64bit-core.c: Regenerate.
11474         * features/i386/64bit-linux.c: Regenerate.
11475         * features/i386/64bit-mpx.c: Regenerate.
11476         * features/i386/64bit-pkeys.c: Regenerate.
11477         * features/i386/64bit-segments.c: Regenerate.
11478         * features/i386/64bit-sse.c: Regenerate.
11479         * features/i386/x32-core.c: Regenerate.
11480         * features/tic6x-c6xp.c: Regenerate.
11481         * features/tic6x-core.c: Regenerate.
11482         * features/tic6x-gp.c: Regenerate.
11483         * target-descriptions.c: Use common/tdesc.h.
11484         * target-descriptions.h: Likewise.
11485
11486 2018-02-24  Tom Tromey  <tom@tromey.com>
11487
11488         * linux-thread-db.c (try_thread_db_load_from_pdir_1)
11489         (try_thread_db_load_from_dir, thread_db_load_search): Use
11490         std::string.
11491         (info_auto_load_libthread_db_compare): Return bool.  Change
11492         argument types.
11493         (info_auto_load_libthread_db): Use std::vector, std::string.
11494         Remove cleanups.
11495
11496 2018-02-24  Tom Tromey  <tom@tromey.com>
11497
11498         * i386-tdep.c (i386_fast_tracepoint_valid_at): "msg" now a
11499         std::string.
11500         * gdbarch.sh (fast_tracepoint_valid_at): Change "msg" to a
11501         std::string*.
11502         * gdbarch.c: Rebuild.
11503         * gdbarch.h: Rebuild.
11504         * breakpoint.c (check_fast_tracepoint_sals): Use std::string.
11505         * arch-utils.h (default_fast_tracepoint_valid_at): Update.
11506         * arch-utils.c (default_fast_tracepoint_valid_at): "msg" now a
11507         std::string*.
11508
11509 2018-02-23  Simon Marchi  <simon.marchi@polymtl.ca>
11510
11511         * gdbtypes.h (sect_offset): Change type to uint64_t.
11512         (sect_offset_str): New function.
11513         * dwarf2read.c (create_addrmap_from_aranges): Use
11514         sect_offset_str.
11515         (error_check_comp_unit_head): Likewise.
11516         (create_debug_type_hash_table): Likewise.
11517         (read_cutu_die_from_dwo): Likewise.
11518         (init_cutu_and_read_dies): Likewise.
11519         (init_cutu_and_read_dies_no_follow): Likewise.
11520         (process_psymtab_comp_unit_reader): Likewise.
11521         (partial_die_parent_scope): Likewise.
11522         (peek_die_abbrev): Likewise.
11523         (process_queue): Likewise.
11524         (dwarf2_physname): Likewise.
11525         (read_namespace_alias): Likewise.
11526         (read_import_statement): Likewise.
11527         (create_dwo_cu_reader): Likewise.
11528         (create_cus_hash_table): Likewise.
11529         (lookup_dwo_cutu): Likewise.
11530         (inherit_abstract_dies): Likewise.
11531         (read_func_scope): Likewise.
11532         (read_call_site_scope): Likewise.
11533         (dwarf2_add_member_fn): Likewise.
11534         (read_common_block): Likewise.
11535         (read_module_type): Likewise.
11536         (read_typedef): Likewise.
11537         (read_subrange_type): Likewise.
11538         (load_partial_dies): Likewise.
11539         (read_partial_die): Likewise.
11540         (find_partial_die): Likewise.
11541         (read_str_index): Likewise.
11542         (dwarf2_string_attr): Likewise.
11543         (build_error_marker_type): Likewise.
11544         (lookup_die_type): Likewise.
11545         (dump_die_shallow): Likewise.
11546         (follow_die_ref): Likewise.
11547         (dwarf2_fetch_die_loc_sect_off): Likewise.
11548         (dwarf2_fetch_constant_bytes): Likewise.
11549         (follow_die_sig): Likewise.
11550         (get_signatured_type): Likewise.
11551         (get_DW_AT_signature_type): Likewise.
11552         (dwarf2_find_containing_comp_unit): Likewise.
11553         (set_die_type): Likewise.
11554
11555 2018-02-21  John Baldwin  <jhb@FreeBSD.org>
11556
11557         * arch/aarch64.c: Include "common-defs.h".
11558         * arch/amd64.c: Likewise.
11559         * arch/i386.c: Likewise.
11560
11561 2018-02-21  Tom Tromey  <tom@tromey.com>
11562
11563         * value.h: (extract_field_op): Update.
11564         * eval.c (extract_field_op): Return a const char *.
11565         * expression.h (parse_expression_for_completion): Update.
11566         * completer.c (complete_expression): Update.
11567         (add_struct_fields): Make fieldname const.
11568         * parse.c (expout_completion_name): Now a unique_xmalloc_ptr.
11569         (mark_completion_tag, parse_exp_in_context_1): Update.
11570         (parse_expression_for_completion): Change "name" to
11571         unique_xmalloc_ptr*.
11572
11573 2018-02-21  Tom Tromey  <tom@tromey.com>
11574
11575         * infcall.c (call_function_by_hand_dummy): Use std::vector.
11576
11577 2018-02-21  Yao Qi  <yao.qi@linaro.org>
11578
11579         * avr-tdep.c (avr_read_pc): Change parameter type to
11580         readable_regcache.
11581         * gdbarch.sh (read_pc): Likewise.
11582         * gdbarch.c: Re-generated.
11583         * gdbarch.h: Re-generated.
11584         * hppa-tdep.c (hppa_read_pc): Change parameter type to
11585         readable_regcache.
11586         * ia64-tdep.c (ia64_read_pc): Likewise.
11587         * mips-tdep.c (mips_read_pc): Likewise.
11588         * spu-tdep.c (spu_read_pc): Likewise.
11589
11590 2018-02-21  Yao Qi  <yao.qi@linaro.org>
11591
11592         * Makefile.in (COMMON_SFILES): Add regcache-dump.c
11593         * regcache-dump.c: New file.
11594         * regcache.c: Move register_dump to regcache-dump.c.
11595         (maintenance_print_registers): Likewise.
11596         (maintenance_print_raw_registers): Likewise.
11597         (maintenance_print_cooked_registers): Likewise.
11598         (maintenance_print_register_groups): Likewise.
11599         (maintenance_print_remote_registers): Likewise.
11600         (_initialize_regcache): Likewise.
11601         * regcache.h (register_dump): Moved from regcache.c.
11602
11603 2018-02-21  Yao Qi  <yao.qi@linaro.org>
11604
11605         * regcache.c (regcache::regcache): Update.
11606         (regcache::invalidate): Move it to detached_regcache::invalidate.
11607         (get_thread_arch_aspace_regcache): Update.
11608         (regcache::raw_update): Update.
11609         (regcache::cooked_read): Remove some code.
11610         (regcache::cooked_read_value): Likewise.
11611         (regcache::raw_write): Remove assert on m_readonly_p.
11612         (regcache::raw_supply_integer): Move it to
11613         detached_regcache::raw_supply_integer.
11614         (regcache::raw_supply_zeroed): Likewise.
11615         * regcache.h (detached_regcache) <raw_supply_integer>: New
11616         declaration.
11617         <raw_supply_zeroed, invalidate>: Likewise.
11618         (regcache) <raw_supply_integer, raw_supply_zeroed>: Removed.
11619         <invalidate>: Likewise.
11620         <m_readonly_p>: Removed.
11621
11622 2018-02-21  Yao Qi  <yao.qi@linaro.org>
11623
11624         * infcmd.c (get_return_value): Let stop_regs point to
11625         get_current_regcache.
11626         * regcache.c (regcache::regcache): Remove.
11627         (register_dump_reg_buffer): New class.
11628         (regcache_print): Adjust.
11629         * regcache.h (regcache): Remove constructors.
11630
11631 2018-02-21  Yao Qi  <yao.qi@linaro.org>
11632
11633         * regcache.c (class register_dump): New class.
11634         (register_dump_regcache, register_dump_none): New class.
11635         (register_dump_remote, register_dump_groups): New class.
11636         (regcache_print): Update.
11637         * regcache.h (regcache_dump_what): Move it to regcache.c.
11638         (regcache) <dump>: Remove.
11639
11640 2018-02-21  Yao Qi  <yao.qi@linaro.org>
11641
11642         * jit.c (struct jit_unwind_private) <regcache>: Change its type to
11643          reg_buffer_rw *.
11644         (jit_unwind_reg_set_impl): Call raw_supply.
11645         (jit_frame_sniffer): Use reg_buffer_rw.
11646         * record-full.c (record_full_core_regbuf): Change its type.
11647         (record_full_core_open_1): Use reg_buffer_rw.
11648         (record_full_close): Likewise.
11649         (record_full_core_fetch_registers): Use regcache->raw_supply.
11650         (record_full_core_store_registers): Likewise.
11651         * regcache.c (regcache::get_register_status): Move it to
11652         reg_buffer.
11653         (regcache_raw_set_cached_value): Remove.
11654         (regcache::raw_set_cached_value): Remove.
11655         (regcache::raw_write): Call raw_supply.
11656         (regcache::raw_supply): Move it to reg_buffer_rw.
11657         * regcache.h (regcache_raw_set_cached_value): Remove.
11658         (reg_buffer_rw): New class.
11659
11660 2018-02-21  Yao Qi  <yao.qi@linaro.org>
11661
11662         * dummy-frame.c (dummy_frame_cache) <prev_regcache>: Use
11663         readonly_detached_regcache.
11664         (dummy_frame_prev_register): Use regcache->cooked_read.
11665         * frame.c (frame_save_as_regcache): Change return type.
11666         (frame_pop): Update.
11667         * frame.h (frame_save_as_regcache): Update declaration.
11668         * inferior.h (get_infcall_suspend_state_regcache): Update
11669         declaration.
11670         * infrun.c (infcall_suspend_state) <registers>: use
11671         readonly_detached_regcache.
11672         (save_infcall_suspend_state): Don't use regcache_dup.
11673         (get_infcall_suspend_state_regcache): Change return type.
11674         * linux-fork.c (struct fork_info) <savedregs>: Change to
11675         readonly_detached_regcache.
11676         <pc>: New field.
11677         (fork_save_infrun_state): Don't use regcache_dup.
11678         (info_checkpoints_command): Adjust.
11679         * mi/mi-main.c (register_changed_p): Update declaration.
11680         (mi_cmd_data_list_changed_registers): Use
11681         readonly_detached_regcache.
11682         (register_changed_p): Change parameter type to
11683         readonly_detached_regcache.
11684         * ppc-linux-tdep.c (ppu2spu_cache) <regcache>: Use
11685         readonly_detached_regcache.
11686         (ppu2spu_sniffer): Construct a new readonly_detached_regcache.
11687         * regcache.c (readonly_detached_regcache::readonly_detached_regcache):
11688         New.
11689         (regcache::save): Move it to reg_buffer.
11690         (regcache::restore): Change parameter type.
11691         (regcache_dup): Remove.
11692         * regcache.h (reg_buffer) <save>: New method.
11693         (readonly_detached_regcache): New class.
11694         * spu-tdep.c (spu2ppu_cache) <regcache>: Use
11695         readonly_detached_regcache.
11696         (spu2ppu_sniffer): Construct a new readonly_detached_regcache.
11697
11698 2018-02-21  Yao Qi  <yao.qi@linaro.org>
11699
11700         * frame.c (frame_save_as_regcache): Use regcache method save.
11701         (frame_pop): Use regcache method restore.
11702         * infrun.c (restore_infcall_suspend_state): Likewise.
11703         * linux-fork.c (fork_load_infrun_state): Likewise.
11704         * ppc-linux-tdep.c (ppu2spu_sniffer): User regcache method
11705         save.
11706         * regcache.c (regcache_save): Remove.
11707         (regcache::restore): More asserts.
11708         (regcache_cpy): Remove.
11709         * regcache.h (regcache_save): Remove the declaration.
11710         (regcache::restore): Move from private to public.
11711         Remove the friend declaration of regcache_cpy.
11712         (regcache_cpy): Remove declaration.
11713
11714 2018-02-21  Yao Qi  <yao.qi@linaro.org>
11715
11716         * aarch64-tdep.c (aarch64_pseudo_register_read_value): Change
11717         parameter type to 'readable_regcache *'.
11718         * amd64-tdep.c (amd64_pseudo_register_read_value): Likewise.
11719         * arm-tdep.c (arm_neon_quad_read): Likewise.
11720         (arm_pseudo_read): Likewise.
11721         * avr-tdep.c (avr_pseudo_register_read): Likewise.
11722         * bfin-tdep.c (bfin_pseudo_register_read): Likewise.
11723         * frv-tdep.c (frv_pseudo_register_read): Likewise.
11724         * gdbarch.c: Re-generated.
11725         * gdbarch.h: Re-generated.
11726         * gdbarch.sh (pseudo_register_read): Change parameter type to
11727         'readable_regcache *'.
11728         (pseudo_register_read_value): Likewise.
11729         * h8300-tdep.c (pseudo_from_raw_register): Likewise.
11730         (h8300_pseudo_register_read): Likewise.
11731         * hppa-tdep.c (hppa_pseudo_register_read): Likewise.
11732         * i386-tdep.c (i386_mmx_regnum_to_fp_regnum): Likewise.
11733         (i386_pseudo_register_read_into_value): Likewise.
11734         (i386_pseudo_register_read_value): Likewise.
11735         * i386-tdep.h (i386_pseudo_register_read_into_value): Update
11736         declaration.
11737         * ia64-tdep.c (ia64_pseudo_register_read): Likewise.
11738         * m32c-tdep.c (m32c_raw_read): Likewise.
11739         (m32c_read_flg): Likewise.
11740         (m32c_banked_register): Likewise.
11741         (m32c_banked_read): Likewise.
11742         (m32c_sb_read): Likewise.
11743         (m32c_part_read): Likewise.
11744         (m32c_cat_read): Likewise.
11745         (m32c_r3r2r1r0_read): Likewise.
11746         (m32c_pseudo_register_read): Likewise.
11747         * m68hc11-tdep.c (m68hc11_pseudo_register_read): Likewise.
11748         * mep-tdep.c (mep_pseudo_cr32_read): Likewise.
11749         (mep_pseudo_cr64_read): Likewise.
11750         (mep_pseudo_register_read): Likewise.
11751         * mips-tdep.c (mips_pseudo_register_read): Likewise.
11752         * msp430-tdep.c (msp430_pseudo_register_read): Likewise.
11753         * nds32-tdep.c (nds32_pseudo_register_read): Likewise.
11754         * regcache.c (regcache::raw_read): Move it to readable_regcache.
11755         (regcache::cooked_read): Likewise.
11756         (regcache::cooked_read_value): Likewise.
11757         (regcache_cooked_read_signed):
11758         (regcache::cooked_read): Likewise.
11759         * regcache.h (readable_regcache): New class.
11760         (regcache): Inherit readable_regcache.  Move some methods to
11761         readable_regcache.
11762         * rl78-tdep.c (rl78_pseudo_register_read): Change
11763         parameter type to 'readable_regcache *'.
11764         * rs6000-tdep.c (do_regcache_raw_read): Remove.
11765         (e500_pseudo_register_read): Change parameter type to
11766         'readable_regcache *'.
11767         (dfp_pseudo_register_read): Likewise.
11768         (vsx_pseudo_register_read): Likewise.
11769         (efpr_pseudo_register_read): Likewise.
11770         * s390-tdep.c (s390_pseudo_register_read): Likewise.
11771         * sh-tdep.c (sh_pseudo_register_read): Likewise.
11772         * sh64-tdep.c (pseudo_register_read_portions): Likewise.
11773         (sh64_pseudo_register_read): Likewise.
11774         * sparc-tdep.c (sparc32_pseudo_register_read): Likewise.
11775         * sparc64-tdep.c (sparc64_pseudo_register_read): Likewise.
11776         * spu-tdep.c (spu_pseudo_register_read_spu): Likewise.
11777         (spu_pseudo_register_read): Likewise.
11778         * xtensa-tdep.c (xtensa_register_read_masked): Likewise.
11779         (xtensa_pseudo_register_read): Likewise.
11780
11781 2018-02-21  Yao Qi  <yao.qi@linaro.org>
11782
11783         * regcache.c (regcache::regcache): Call reg_buffer ctor.
11784         (regcache::arch): Move it to reg_buffer::arch.
11785         (regcache::register_buffer): Likewise.
11786         (regcache::assert_regnum): Likewise.
11787         (regcache::num_raw_registers): Likewise.
11788         * regcache.h (reg_buffer): New class.
11789         (regcache): Inherit reg_buffer.
11790
11791 2018-02-20  Simon Marchi  <simon.marchi@ericsson.com>
11792
11793         * remote-sim.c (gdb_os_printf_filtered, gdb_os_vprintf_filtered,
11794         gdb_os_evprintf_filtered, gdb_os_error): Add ATTRIBUTE_PRINTF.
11795
11796 2018-02-20  Markus Metzger  <markus.t.metzger@intel.com>
11797
11798         * gnulib/update-gnulib.sh (IMPORTED_GNULIB_MODULES): Add mkstemp.
11799
11800 2018-02-19  Alan Hayward  <alan.hayward@arm.com>
11801
11802         * Makefile.in: (COMMON_SFILES): Add common/*.c files.
11803         (SFILES): Remove common/*.c files.
11804         (COMMON_OBS): Remove some *.o files built from common/*.c files.
11805         * common/common.host: Add common reference.
11806         * configure.ac: Likewise.
11807         * configure: Regenerate.
11808
11809 2018-02-16  Yao Qi  <yao.qi@linaro.org>
11810
11811         * block.c (block_namespace_info): Inherit allocate_on_obstack.
11812         (block_initialize_namespace): Use new.
11813         * dwarf2read.c (dwarf2_per_objfile): Inherit allocate_on_obstack.
11814         (dwarf2_free_objfile): Use delete.
11815         * gdbtypes.c (type_pair): Inherit allocate_on_obstack.
11816         (copy_type_recursive): Use new.
11817         * gdb_obstack.h (allocate_on_obstack): New.
11818
11819 2018-02-15  Yao Qi  <yao.qi@linaro.org>
11820
11821         PR gdb/22849
11822         * inferior.c (exit_inferior_1): Reset inf->control.
11823
11824 2018-02-15  Joel Brobecker  <brobecker@adacore.com>
11825
11826         * ada-lang.c (ada_to_fixed_value_create): Delete advance
11827         declaration.
11828
11829 2018-02-14  Pedro Alves  <palves@redhat.com>
11830
11831         * frame-unwind.c (frame_unwind_try_unwinder): Always call
11832         frame_cleanup_after_sniffer on exception.
11833
11834 2018-02-14  Tom Tromey  <tom@tromey.com>
11835
11836         * solist.h (struct target_so_ops) <bfd_open>: Make pathname
11837         const.
11838         (solib_bfd_open): Make pathname const.
11839         * solib.c (solib_bfd_open): Make pathname const.
11840         * solib-spu.c (spu_bfd_fopen): Make name const.
11841         (spu_bfd_open): Make pathname const.
11842         * solib-darwin.c (darwin_bfd_open): Make pathname const.
11843         * solib-aix.c (solib_aix_bfd_open): Make pathname const.
11844
11845 2018-02-14  Tom Tromey  <tom@tromey.com>
11846
11847         * symfile.c (symfile_bfd_open): Update.
11848         * source.h (openp, source_full_path_of, find_and_open_source):
11849         Change argument type to unique_xmalloc_ptr.
11850         * source.c (openp): Take a unique_xmalloc_ptr.
11851         (source_full_path_of, find_and_open_source): Likewise.
11852         (open_source_file, symtab_to_fullname): Update.
11853         * solist.h (struct target_so_ops) <find_and_open_solib>: Take a
11854         unique_xmalloc_ptr.
11855         * solib.c (solib_find_1): Use unique_xmalloc_ptr.
11856         (exec_file_find): Update.
11857         * psymtab.c (psymtab_to_fullname): Update.
11858         * nto-tdep.h (nto_find_and_open_solib): Update.
11859         * nto-tdep.c (nto_find_and_open_solib): Change temp_path to a
11860         unique_xmalloc_ptr.
11861         * exec.c (exec_file_attach): Update.
11862         * dwarf2read.c (try_open_dwop_file): Use unique_xmalloc_ptr.
11863         * cli/cli-cmds.c (find_and_open_script): Use unique_xmalloc_ptr.
11864
11865 2018-02-14  Tom Tromey  <tom@tromey.com>
11866
11867         * solib.c: Include source.h.
11868         * nto-tdep.c: Include source.h.
11869         * mi/mi-cmd-env.c: Include source.h.
11870         * infcmd.c: Include source.h.
11871         * exec.c: Include source.h.
11872         * defs.h (enum openp_flag, openp, source_full_path_of, mod_path)
11873         (add_path, directory_switch, source_path, init_source_path): Move
11874         declarations...
11875         * source.h (enum openp_flag, openp, source_full_path_of, mod_path)
11876         (add_path, directory_switch, source_path, init_source_path):
11877         ...here.
11878
11879 2018-02-14  Tom Tromey  <tom@tromey.com>
11880
11881         * solist.h (exec_file_find, solib_find): Return
11882         unique_xmalloc_ptr.
11883         (solib_bfd_fopen): Take a const char *.
11884         * solib.c (solib_find_1): Return unique_xmalloc_ptr.
11885         (exec_file_find, solib_find): Likewise.
11886         (solib_bfd_fopen): Do not take ownership of "pathname".
11887         (solib_bfd_open): Use unique_xmalloc_ptr.
11888         * solib-darwin.c (darwin_bfd_open): Use unique_xmalloc_ptr.
11889         * solib-aix.c (solib_aix_bfd_open): Use unique_xmalloc_ptr.
11890         * infrun.c (follow_exec): Use unique_xmalloc_ptr.
11891         * exec.c (exec_file_locate_attach): Use unique_xmalloc_ptr.
11892
11893 2018-02-14  Joel Brobecker  <brobecker@adacore.com>
11894
11895         * ada-lang.c (name_match_type_from_name): Remove reference to
11896         ada_name_for_lookup in function's documentation.
11897         * ada-lang.h (ada_name_for_lookup): Delete declaration.
11898
11899 2018-02-13  Simon Marchi  <simon.marchi@polymtl.ca>
11900
11901         * defs.h (enum openp_flags): New enum.
11902         (OPF_TRY_CWD_FIRST, OPF_SEARCH_IN_PATH, OPF_RETURN_REALPATH):
11903         Move to enum openp_flags.
11904         (openp_flags): New enum flags.
11905         (openp): Change parameter type to openp_flags.
11906         * source.c (openp): Change parameter type to openp_flags.
11907         * cli/cli-cmds.c (find_and_open_script): Use openp_flags.
11908         * dwarf2read.c (try_open_dwop_file): Use openp_flags.
11909
11910 2018-02-13  Simon Marchi  <simon.marchi@polymtl.ca>
11911
11912         * maint.c (_initialize_maint_cmds): Fix prefix of maint set/show
11913         per-command.
11914
11915 2018-02-12  Andrew Burgess  <andrew.burgess@embecosm.com>
11916
11917         * dwarf2read.c (dwarf2_release_queue): Delete function, move body
11918         into...
11919         (class dwarf2_queue_guard): ...the destructor of this new class.
11920         (dw2_do_instantiate_symtab): Create instance of the new class
11921         dwarf2_queue_guard, remove cleanup.
11922
11923 2018-02-09  Tom Tromey  <tom@tromey.com>
11924
11925         * source.c (find_source_lines): Don't reference past the end of
11926         the vector.
11927
11928 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
11929
11930         * remote.c (remote_btrace_maybe_reopen): Change error message.
11931         * btrace.c (btrace_enable): Likewise.
11932         (parse_xml_btrace): Likewise.
11933         (parse_xml_btrace_conf): Likewise.
11934
11935 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
11936
11937         * nat/linux-btrace.c (diagnose_perf_event_open_fail): New.
11938         (linux_enable_pt, linux_enable_bts): Call
11939         diagnose_perf_event_open_fail.
11940
11941 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
11942
11943         * nat/linux-btrace.c (perf_event_pt_event_type): Improve error message.
11944         Remove parameter and change return type.  Update callers.  Move it.
11945         (linux_enable_bts, linux_enable_pt): Improve error message.
11946         (linux_enable_pt): Remove zero buffer size check.
11947         (linux_enable_btrace): Improve error messages.  Remove NULL return
11948         check.
11949
11950 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
11951
11952         * btrace.c (btrace_enable): Remove target_supports_btrace call.
11953         * nat/linux-btrace.c (perf_event_pt_event_type): Move.
11954         (kernel_supports_bts, kernel_supports_pt, linux_supports_bts)
11955         (linux_supports_pt, linux_supports_btrace): Remove.
11956         (linux_enable_bts): Call cpu_supports_bts.
11957         * nat/linux-btrace.h (linux_supports_btrace): Remove.
11958         * remote.c (remote_supports_btrace): Remove.
11959         (init_remote_ops): Remove remote_supports_btrace.
11960         * target-delegates.c: Regenerated.
11961         * target.c (target_supports_btrace): Remove.
11962         * target.h (target_ops) <to_supports_btrace>: Remove
11963         (target_supports_btrace): Remove.
11964         * x86-linux-nat.c (x86_linux_create_target): Remove
11965         linux_supports_btrace.
11966
11967 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
11968
11969         * nat/linux-btrace.c (linux_enable_btrace): Throw exception if enabling
11970         btrace failed.
11971         * x86-linux-nat.c (x86_linux_enable_btrace): Catch btrace enabling
11972         exception and use message in own exception.
11973
11974 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
11975
11976         * nat/linux-btrace.c: Include scoped_fd.h and scoped_mmap.h.
11977         (perf_event_pt_event_type): Use gdb_file_up.
11978         (linux_enable_bts, linux_enable_pt): Use gdb::unique_xmalloc_ptr,
11979         scoped_fd, and scoped_mmap.
11980
11981 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
11982
11983         * common/scoped_mmap.h: New.
11984         * unittests/scoped_mmap-selftest.c: New.
11985         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
11986         unittests/scoped_mmap-selftest.c.
11987
11988 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
11989
11990         * common/scoped_fd.h: New.
11991         * unittests/scoped_fd-selftest.c: New.
11992         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
11993         unittests/scoped_fd-selftest.c.
11994
11995 2018-02-09  Tom Tromey  <tom@tromey.com>
11996
11997         * auto-load.c (auto_load_section_scripts): Use
11998         gdb::unique_xmalloc_ptr.
11999
12000 2018-02-09  Tom Tromey  <tom@tromey.com>
12001
12002         * auto-load.c (execute_script_contents): Use std::string.
12003
12004 2018-02-09  Joel Brobecker  <brobecker@adacore.com>
12005
12006         * NEWS <Changes in GDB 8.1>: Clarify that "rbreak" is a new
12007         Python function, rather than a new command.
12008
12009 2018-02-08  Tom Tromey  <tom@tromey.com>
12010
12011         * solib.c (solib_find_1): Use std::string.
12012         (solib_bfd_fopen): Use unique_xmalloc_ptr.
12013
12014 2018-02-08  Tom Tromey  <tom@tromey.com>
12015
12016         * build-id.c (build_id_to_debug_bfd): Use unique_xmalloc_ptr.
12017
12018 2018-02-08  Tom Tromey  <tom@tromey.com>
12019
12020         * source.c (find_source_lines): Use gdb::def_vector.
12021
12022 2018-02-08  Tom Tromey  <tom@tromey.com>
12023
12024         * macrocmd.c (struct temporary_macro_definition): New.
12025         (macro_define_command): Use temporary_macro_definition.  Remove
12026         cleanups.
12027         (free_macro_definition_ptr): Remove.
12028
12029 2018-02-08  Tom Tromey  <tom@tromey.com>
12030
12031         * macroexp.c (maybe_expand): Use std::string.
12032
12033 2018-02-08  Tom Tromey  <tom@tromey.com>
12034
12035         * macroexp.c (struct macro_buffer): Add initializers for some
12036         members.
12037         (init_buffer, init_shared_buffer, free_buffer)
12038         (free_buffer_return_text): Remove.
12039         (macro_buffer): New constructors.
12040         (~macro_buffer): New destructor.
12041         (macro_buffer::set_shared): New method.
12042         (macro_buffer::resize_buffer, macro_buffer::appendc)
12043         (macro_buffer::appendmem): Now methods, not free functions.
12044         (set_token, append_tokens_without_splicing, stringify)
12045         (macro_stringify): Update.
12046         (gather_arguments): Change return type.  Remove argc_p argument,
12047         add args_ptr argument.  Use std::vector.
12048         (substitute_args): Remove argc argument.  Accept std::vector.
12049         (expand): Update.  Use std::vector.
12050         (scan, macro_expand, macro_expand_next): Update.
12051
12052 2018-02-08  Tom Tromey  <tom@tromey.com>
12053
12054         * symtab.c (default_collect_symbol_completion_matches_break_on):
12055         Use unique_xmalloc_ptr.
12056         * macroscope.h: (sal_macro_scope, user_macro_scope)
12057         (default_macro_scope): Return unique_xmalloc_ptr.
12058         * macroscope.c (sal_macro_scope, user_macro_scope)
12059         (default_macro_scope): Return unique_xmalloc_ptr.
12060         * macroexp.h (macro_expand, macro_expand_once): Return
12061         unique_xmalloc_ptr.
12062         * macroexp.c (macro_expand, macro_expand_once): Return
12063         unique_xmalloc_ptr.
12064         * macrocmd.c (macro_expand_command, macro_expand_once_command)
12065         (info_macro_command, info_macros_command): Use
12066         unique_xmalloc_ptr.
12067         * compile/compile-c-support.c (write_macro_definitions): Use
12068         unique_xmalloc_ptr.
12069         * c-exp.y (c_parse): Use unique_xmalloc_ptr.
12070
12071 2018-02-07  Simon Marchi  <simon.marchi@ericsson.com>
12072
12073         * value.c (value_static_field): Assign field type instead of
12074         containing type when returning an optimized out value.
12075
12076 2018-02-06  Yao Qi  <yao.qi@linaro.org>
12077
12078         * ft32-tdep.c (ft32_read_pc): Remove.
12079         (ft32_write_pc): Remove.
12080         (ft32_gdbarch_init): Update.
12081         * m32r-tdep.c (m32r_read_pc): Remove.
12082         (m32r_gdbarch_init): Update.
12083         * mep-tdep.c (mep_read_pc): Remove.
12084         (mep_gdbarch_init): Update.
12085         * microblaze-tdep.c (microblaze_write_pc): Remove.
12086         (microblaze_gdbarch_init): Update.
12087         * mn10300-tdep.c (mn10300_read_pc): Remove.
12088         (mn10300_write_pc): Remove.
12089         (mn10300_gdbarch_init): Update.
12090         * moxie-tdep.c (moxie_read_pc): Remove.
12091         (moxie_write_pc): Remove.
12092         (moxie_gdbarch_init): Update.
12093
12094 2018-02-06  Yao Qi  <yao.qi@linaro.org>
12095
12096         * expprint.c (print_subexp_standard): Handle
12097         OP_F77_UNDETERMINED_ARGLIST.
12098         (dump_subexp_body_standard): Likewise.
12099
12100 2018-02-05  Alan Hayward  <alan.hayward@arm.com>
12101
12102         * target-descriptions.c (tdesc_element_visitor) Add empty
12103         implementations.
12104         (tdesc_type): Move make_gdb_type from here.
12105         (tdesc_type_builtin): Likewise.
12106         (tdesc_type_vector): Likewise.
12107         (tdesc_type_with_fields): Move make_gdb_type_ functions from here.
12108         (make_gdb_type_struct): Move from tdesc_type_with_fields.
12109         (make_gdb_type_union): Likewise.
12110         (make_gdb_type_flags): Likewise.
12111         (make_gdb_type_enum): Likewise.
12112         (make_gdb_type): New function.
12113         (tdesc_register_type): Use static make_gdb_type.
12114
12115 2018-02-05  Ruslan Kabatsayev <b7.10110111@gmail.com>
12116
12117         * infcmd.c (default_print_one_register_info): Align natural-format
12118         column values consistently one under another.
12119         (pad_to_column): New function.
12120
12121 2018-02-05  Joel Brobecker  <brobecker@adacore.com>
12122
12123         * dwarf2read.c (dwarf2_physname): Move commment.
12124
12125 2018-02-01  Leszek Swirski  <leszeks@google.com>
12126
12127         * varobj.c (varobj_formatted_print_options): Allow recursive
12128         pretty printing if pretty printing is enabled.
12129
12130 2018-02-01  Leszek Swirski  <leszeks@google.com>
12131
12132         * c-exp.y (lex_one_token, classify_name, yylex): Don't classify
12133         names after a structop as a filename.
12134
12135 2018-02-01  Yao Qi  <yao.qi@linaro.org>
12136
12137         * arm-tdep.c (arm_record_data_proc_misc_ld_str): Rewrite it.
12138         (arm_record_coproc_data_proc): Likewise.
12139
12140 2018-02-01  Yao Qi  <yao.qi@linaro.org>
12141
12142         * arm-tdep.c (arm_record_extension_space): Change ret to signed.
12143
12144 2018-01-31  Nikola Prica  <nikola.prica@rt-rk.com>
12145
12146         * rs6000-tdep.c (skip_prologue): Remove shifting for lr_reg and
12147         assign shifted lr_reg to fdata->lr_register when lr_reg is set.
12148
12149 2018-01-31  Pedro Alves  <palves@redhat.com>
12150
12151         * darwin-nat.c (darwin_interrupt): Remove ptid_t parameter.
12152         * inflow.c (child_terminal_save_inferior): Wrap reference to
12153         tcgetpgrp in HAVE_TERMIOS_H.
12154         (child_interrupt, child_pass_ctrlc): Wrap references to signal in
12155         _WIN32.
12156         * remote-sim.c (gdbsim_interrupt): Remove ptid_t parameter and
12157         always iterate over all inferiors.
12158         (gdbsim_cntrl_c): Adjust.
12159         * windows-nat.c (windows_interrupt): Remove 'ptid_t' parameter.
12160
12161 2018-01-31  Joel Brobecker  <brobecker@adacore.com>
12162
12163         * gdbtypes.c (lookup_array_range_type): Make sure the array's
12164         index type is objfile-owned if the element type is as well.
12165
12166 2018-01-31  Joel Brobecker  <brobecker@adacore.com>
12167
12168         GDB 8.1 released.
12169
12170 2018-01-30  Philipp Rudo  <prudo@linux.vnet.ibm.com>
12171
12172         * s390-linux-tdep.c: Remove includes "features/s390-linux32.c" and
12173         "features/s390x-linux64.c".
12174         (_initialize_s390_linux_tdep): Remove initialization of tdescs
12175         s390_linux32 and s390x_linux64.
12176         (s390_linux_init_abi_31, s390_linux_init_abi_64): Don't set
12177         default tdesc.
12178         * s390-tdep.c: Include "features/s390-linux32.c" and
12179         "features/s390x-linux64.c".
12180         (s390_tdesc_valid): Add check for tdesc_has_registers.
12181         (s390_gdbarch_init): Make sure there is always a valid tdesc.
12182         (_initialize_s390_tdep): Initialize tdesc_s390_linux32 and
12183         tdesc_s390x_linux64.
12184         * s390-linux-tdep.h: Move export of tdesc_s390_linux32 and
12185         tdesc_s390x_linux64 to...
12186         * s390-tdep.h: ...here.
12187
12188 2018-01-30  Pedro Alves  <palves@redhat.com>
12189
12190         PR gdb/13211
12191         * config.in, configure: Regenerate.
12192         * configure.ac: Check for getpgid.
12193         * go32-nat.c (go32_pass_ctrlc): New.
12194         (go32_target): Install it.
12195         * inf-child.c (inf_child_target): Install
12196         child_terminal_save_inferior, child_pass_ctrlc and
12197         child_interrupt.
12198         * inf-ptrace.c (inf_ptrace_interrupt): Delete.
12199         (inf_ptrace_target): No longer install it.
12200         * infcmd.c (interrupt_target_1): Adjust.
12201         * inferior.h (child_terminal_save_inferior, child_pass_ctrlc)
12202         (child_interrupt): Declare.
12203         (inferior::terminal_state): New.
12204         * inflow.c (struct terminal_info): Update comments.
12205         (inferior_process_group): Delete.
12206         (terminal_is_ours): Delete.
12207         (gdb_tty_state): New.
12208         (child_terminal_init): Adjust.
12209         (is_gdb_terminal, sharing_input_terminal_1)
12210         (sharing_input_terminal): New functions.
12211         (child_terminal_inferior): Adjust.  Use sharing_input_terminal.
12212         Set the process's actual process group in the foreground if
12213         possible.  Handle is_ours_for_output/is_ours distinction.  Don't
12214         mark terminal as the inferior's if not sharing GDB's terminal.
12215         Don't check attach_flag.
12216         (child_terminal_ours_for_output, child_terminal_ours): Adjust to
12217         pass down a target_terminal_state.
12218         (child_terminal_save_inferior): New, factored out from ...
12219         (child_terminal_ours_1): ... this.  Handle
12220         target_terminal_state::is_ours_for_output.
12221         (child_interrupt, child_pass_ctrlc): New.
12222         (inflow_inferior_exit): Clear the inferior's terminal_state.
12223         (copy_terminal_info): Copy the inferior's terminal state.
12224         (_initialize_inflow): Remove reference to terminal_is_ours.
12225         * inflow.h (inferior_process_group): Delete.
12226         * nto-procfs.c (nto_handle_sigint, procfs_interrupt): Adjust.
12227         * procfs.c (procfs_target): Don't install procfs_interrupt.
12228         (procfs_interrupt): Delete.
12229         * remote.c (remote_serial_quit_handler): Adjust.
12230         (remote_interrupt): Remove ptid parameter.  Adjust.
12231         * target-delegates.c: Regenerate.
12232         * target.c: Include "terminal.h".
12233         (target_terminal::terminal_state): Rename to ...
12234         (target_terminal::m_terminal_state): ... this.
12235         (target_terminal::init): Adjust.
12236         (target_terminal::inferior): Adjust to per-inferior
12237         terminal_state.
12238         (target_terminal::restore_inferior, target_terminal_is_ours_kind): New.
12239         (target_terminal::ours, target_terminal::ours_for_output): Use
12240         target_terminal_is_ours_kind.
12241         (target_interrupt): Remove ptid parameter.  Adjust.
12242         (default_target_pass_ctrlc): Adjust.
12243         * target.h (target_ops::to_terminal_save_inferior): New field.
12244         (target_ops::to_interrupt): Remove ptid_t parameter.
12245         (target_interrupt): Remove ptid_t parameter.  Update comment.
12246         (target_pass_ctrlc): Update comment.
12247         * target/target.h (target_terminal_state): New scoped enum,
12248         factored out of ...
12249         (target_terminal::terminal_state): ... here.
12250         (target_terminal::inferior): Update comments.
12251         (target_terminal::restore_inferior): New.
12252         (target_terminal::is_inferior, target_terminal::is_ours)
12253         (target_terminal::is_ours_for_output): Adjust.
12254         (target_terminal::scoped_restore_terminal_state): Adjust to
12255         rename, and call restore_inferior() instead of inferior().
12256         (target_terminal::scoped_restore_terminal_state::m_state): Change
12257         type.
12258         (target_terminal::terminal_state): Rename to ...
12259         (target_terminal::m_terminal_state): ... this and change type.
12260
12261 2018-01-30  Pedro Alves  <palves@redhat.com>
12262
12263         * linux-nat.c (wait_for_signal): New function.
12264         (wait_lwp, linux_nat_wait_1): Use it instead of calling sigsuspend
12265         directly.
12266         (async_terminal_is_ours)
12267         (linux_nat_terminal_inferior, linux_nat_terminal_ours): Delete.
12268         (linux_nat_add_target): Don't override
12269         to_terminal_inferior/to_terminal_ours.
12270
12271 2018-01-29  Sergio Durigan Junior  <sergiodj@redhat.com>
12272
12273         * remote.c (remote_follow_fork): Don't call "detach_inferior".
12274
12275 2018-01-28  Simon Marchi  <simon.marchi@ericsson.com>
12276
12277         * dwarf2read.c (free_dwo_files): Add forward-declaration.
12278         (dwarf2_per_objfile::~dwarf2_per_objfile): Move content from
12279         dwarf2_per_objfile_free here.
12280         (dwarf2_per_objfile_free): Remove.
12281         (_initialize_dwarf2_read): Don't register
12282         dwarf2_per_objfile_free as a registry cleanup.
12283
12284 2018-01-27  Eli Zaretskii  <eliz@gnu.org>
12285
12286         Avoid compilation errors in MinGW native builds
12287
12288         The error is triggered by including python-internal.h, and the
12289         error message is:
12290
12291              In file included from d:\usr\lib\gcc\mingw32\6.3.0\include\c++\math.h:36:0,
12292                       from build-gnulib/import/math.h:27,
12293                       from d:/usr/Python26/include/pyport.h:235,
12294                       from d:/usr/Python26/include/Python.h:58,
12295                       from python/python-internal.h:94,
12296                       from python/py-arch.c:24:
12297              d:\usr\lib\gcc\mingw32\6.3.0\include\c++\cmath:1157:11: error: '::hypot' has not been declared
12298         using ::hypot;
12299                 ^~~~~
12300
12301         This happens because Python headers define 'hypot' to expand t
12302         '_hypot' in the Windows builds.
12303         * python/python-internal.h (_hypot) [__MINGW32__]: Define back to
12304         'hypoth'.  This avoids a compilation error.
12305
12306 2018-01-26  Alan Hayward  <alan.hayward@arm.com>
12307
12308         * MAINTAINERS (Write After Approval): Fix ordering.
12309
12310 2018-01-26  Alan Hayward  <alan.hayward@arm.com>
12311
12312         * MAINTAINERS (Write After Approval): Add Alan Hayward.
12313
12314 2018-01-26  Alan Modra  <amodra@gmail.com>
12315
12316         * ppc-linux-tdep.c (powerpc32_plt_stub): Make const.
12317         (powerpc32_plt_stub_so_1): Rename from powerpc32_plt_stub_so.
12318         Remove nop.  Make const.  Comment.
12319         (powerpc32_plt_stub_so_2): New.
12320         (POWERPC32_PLT_CHECK_LEN): Rename from POWERPC32_PLT_STUB_LEN.
12321         Correct count.  Update uses.
12322         (ppc_skip_trampoline_code): Match powerpc32_plt_stub_so_2 too.
12323         Move common code reading PLT entry word.  Correct
12324         powerpc32_plt_stub PLT address calculation.
12325         * ppc64-tdep.c (ppc64_standard_linkage1): Make const.
12326         (ppc64_standard_linkage2, ppc64_standard_linkage3): Likewise.
12327         (ppc64_standard_linkage4, ppc64_standard_linkage5): Likewise.
12328         (ppc64_standard_linkage6, ppc64_standard_linkage7): Likewise.
12329         (ppc64_standard_linkage8): Likewise.
12330         * rs6000-tdep.c (ppc_insns_match_pattern): Make pattern const.
12331         Correct insns description.
12332         * ppc-tdep.h (ppc_insns_match_pattern): Update prototype.
12333
12334 2018-01-24  Pedro Alves  <palves@redhat.com>
12335
12336         GCC PR libstdc++/83906
12337         * gdbtypes.c (operator==(const dynamic_prop &,
12338         const dynamic_prop &)): New.
12339         (operator==(const range_bounds &, const range_bounds &)): New.
12340         (check_types_equal): Use them instead of memcmp.
12341         * gdbtypes.h (operator==(const dynamic_prop &,
12342         const dynamic_prop &)): Declare.
12343         (operator!=(const dynamic_prop &, const dynamic_prop &)): Declare.
12344         (operator==(const range_bounds &, const range_bounds &)): Declare.
12345         (operator!=(const range_bounds &, const range_bounds &)): Declare.
12346
12347 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
12348
12349         * s390-linux-tdep.c (s390_record_address_mask)
12350         (s390_record_calc_disp_common, s390_record_calc_disp)
12351         (s390_record_calc_disp_vsce, s390_record_calc_rl, s390_popcnt)
12352         (s390_record_gpr_g, s390_record_gpr_h, s390_record_vr)
12353         (s390_process_record): Move to s390-tdep.c.
12354         (s390_linux_init_abi_any): Adjust.
12355         * s390-tdep.c (s390_record_address_mask)
12356         (s390_record_calc_disp_common, s390_record_calc_disp)
12357         (s390_record_calc_disp_vsce, s390_record_calc_rl, s390_popcnt)
12358         (s390_record_gpr_g, s390_record_gpr_h, s390_record_vr)
12359         (s390_process_record): Moved from s390-linux-tdep.c
12360         (s390_gdbarch_init): Adjust.
12361
12362 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
12363
12364         * s390-linux-nat.c (s390-tdep.h): New include.
12365         * Makefile.in (ALL_TARGET_OBS): Add s390-tdep.o.
12366         (HFILES_NO_SRCDIR): Add s390-tdep.h.
12367         (ALLDEPFILES): Add s390-tdep.c.
12368         * configure.tgt (s390*-*-linux*): Add s390-tdep.o.
12369         * s390-linux-tdep.h (HWCAP_S390_*, S390_*_REGNUM): Move to...
12370         * s390-tdep.h: ...this.  New file.
12371         * s390-linux-tdep.c (s390-tdep.h): New include.
12372         (_initialize_s390_tdep): Rename to...
12373         (_initialize_s390_linux_tdep): ...this and adjust.
12374         (s390_abi_kind, s390_vector_abi_kind, gdbarch_tdep)
12375         (enum named opcodes, S390_NUM_GPRS, S390_NUM_FPRS): Move to
12376         s390-tdep.h.
12377         (s390_break_insn, s390_breakpoint, s390_readinstruction, is_ri)
12378         (is_ril, is_rr, is_rre, is_rs, is_rsy, is_rx, is_rxy)
12379         (s390_is_partial_instruction, s390_software_single_step)
12380         (is_non_branch_ril, s390_displaced_step_copy_insn)
12381         (s390_displaced_step_fixup, s390_displaced_step_hw_singlestep)
12382         (s390_prologue_data, s390_addr, s390_store, s390_load)
12383         (s390_check_for_saved, s390_analyze_prologue, s390_skip_prologue)
12384         (s390_register_call_saved, s390_guess_tracepoint_registers)
12385         (s390_register_name, s390_dwarf_regmap, s390_dwarf_reg_to_regnum)
12386         (regnum_is_gpr_full, regnum_is_vxr_full, s390_value_from_register)
12387         (s390_pseudo_register_name, s390_pseudo_register_type)
12388         (s390_pseudo_register_read, s390_pseudo_register_write)
12389         (s390_pseudo_register_reggroup_p, s390_ax_pseudo_register_collect)
12390         (s390_ax_pseudo_register_push_stack, s390_gen_return_address)
12391         (s390_addr_bits_remove, s390_address_class_type_flags)
12392         (s390_address_class_type_flags_to_name)
12393         (s390_address_class_name_to_type_flags, s390_effective_inner_type)
12394         (s390_function_arg_float, s390_function_arg_vector)
12395         (is_power_of_two, s390_function_arg_integer, s390_arg_state)
12396         (s390_handle_arg, s390_push_dummy_call, s390_dummy_id)
12397         (s390_frame_align, s390_register_return_value, s390_return_value)
12398         (s390_stack_frame_destroyed_p, s390_unwind_pc, s390_unwind_sp)
12399         (s390_unwind_pseudo_register, s390_adjust_frame_regnum)
12400         (s390_dwarf2_prev_register, s390_dwarf2_frame_init_reg)
12401         (s390_trad_frame_prev_register, s390_unwind_cache)
12402         (s390_prologue_frame_unwind_cache)
12403         (s390_backchain_frame_unwind_cache, s390_frame_unwind_cache)
12404         (s390_frame_this_id, s390_frame_prev_register, s390_frame_unwind)
12405         (s390_stub_unwind_cache, s390_stub_frame_unwind_cache)
12406         (s390_stub_frame_this_id, s390_stub_frame_prev_register)
12407         (s390_stub_frame_sniffer, s390_stub_frame_unwind)
12408         (s390_frame_base_address, s390_local_base_address)
12409         (s390_frame_base, s390_gcc_target_options)
12410         (s390_gnu_triplet_regexp, s390_stap_is_single_operand)
12411         (s390_validate_reg_range, s390_tdesc_valid)
12412         (s390_gdbarch_tdep_alloc, s390_gdbarch_init): Move to...
12413         * s390-tdep.c: ...this.  New file.
12414
12415 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
12416
12417         * s390-linux-tdep.c (gdbarch_tdep.s390_syscall_record): New hook.
12418         (s390_process_record, s390_gdbarch_tdep_alloc)
12419         (s390_linux_init_abi_any): Use/set new hook.
12420
12421 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
12422
12423         * s390-linux-tdep.c (osabi.h): New include.
12424         (s390_linux_init_abi_31, s390_linux_init_abi_64)
12425         (s390_linux_init_abi_any): New functions.
12426         (s390_gdbarch_init, _initialize_s390_tdep): Adjust.
12427
12428 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
12429
12430         * s390-linux-tdep.c (s390_gdbarch_init): Use gdb_assert for
12431         tdesc_has_registers check
12432
12433 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
12434
12435         * s390-linux-tdep.c (s390_tdesc_valid): New function.
12436         (s390_validate_reg_range): New macro.
12437         (s390_gdbarch_init): Adjust.
12438
12439 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
12440
12441         * s390-linux-tdep.c (gdbarch_tdep) <tdesc>: New field.
12442         (s390_gdbarch_tdep_alloc): Adjust.
12443         (s390_gdbarch_init): Adjust.
12444
12445 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
12446
12447         * s390-linux-tdep.c (gdbarch_tdep) <have_linux_v1, have_linux_v2>
12448         <have_tdb>: Change type to bool.
12449         (s390_gdbarch_tdep_alloc): Adjust.
12450         (s390_gdbarch_init): Adjust.
12451
12452 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
12453
12454         * s390-linux-tdep (s390_abi_kind) <ABI_NONE>: New default field.
12455         (gdbarch_tdep) <have_upper, have_vx>: New fields.
12456         (s390_gdbarch_tdep_alloc): New function.
12457         (s390_gdbarch_init): Allocate tdep at start and use its fields
12458         instead of separate variables.
12459
12460 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
12461
12462         * s390-linux-tdep.c (s390_gdbarch_init): Remove duplicate checks
12463         when looking for cached gdbarch and add comment for remaining.
12464
12465 2018-01-22  Pedro Alves  <palves@redhat.com>
12466             Sergio Durigan Junior  <sergiodj@redhat.com>
12467
12468         * typeprint.c (whatis_exp): Initialize "val" in the "whatis type"
12469         case.
12470
12471 2018-01-22  Maciej W. Rozycki  <macro@mips.com>
12472
12473         * MAINTAINERS: Update my company e-mail address.
12474
12475 2018-01-22  Yao Qi  <yao.qi@linaro.org>
12476
12477         * regcache.c (cooked_write_test): New function.
12478         (_initialize_regcache): Register the test.
12479
12480 2018-01-22  Yao Qi  <yao.qi@linaro.org>
12481
12482         * ia64-tdep.c (ia64_pseudo_register_read): Call
12483         regcache->cooked_read instead of regcache_cooked_read_unsigned.
12484         * m32c-tdep.c (m32c_cat_read): Likewise.
12485         (m32c_r3r2r1r0_read): Likewise.
12486         * m68hc11-tdep.c (m68hc11_pseudo_register_read): Likewise.
12487         * xtensa-tdep.c (xtensa_register_read_masked): Likewise.
12488
12489 2018-01-22  Yao Qi  <yao.qi@linaro.org>
12490
12491         * aarch64-tdep.c (aarch64_pseudo_read_value): Call regcache
12492         method raw_read instead of regcache_raw_read.
12493         * amd64-tdep.c (amd64_pseudo_register_read_value): Likewise.
12494         * arm-tdep.c (arm_neon_quad_read): Likewise.
12495         * avr-tdep.c (avr_pseudo_register_read): Likewise.
12496         * bfin-tdep.c (bfin_pseudo_register_read): Likewise.
12497         * frv-tdep.c (frv_pseudo_register_read): Likewise.
12498         * h8300-tdep.c (h8300_pseudo_register_read): Likewise.
12499         * i386-tdep.c (i386_mmx_regnum_to_fp_regnum): Likewise.
12500         (i386_pseudo_register_read_into_value): Likewise.
12501         * mep-tdep.c (mep_pseudo_cr32_read): Likewise.
12502         * msp430-tdep.c (msp430_pseudo_register_read): Likewise.
12503         * nds32-tdep.c (nds32_pseudo_register_read): Likewise.
12504         * rl78-tdep.c (rl78_pseudo_register_read): Likewise.
12505         * s390-linux-tdep.c (s390_pseudo_register_read): Likewise.
12506         * sparc-tdep.c (sparc32_pseudo_register_read):  Likewise.
12507         * sparc64-tdep.c (sparc64_pseudo_register_read): Likewise.
12508         * spu-tdep.c (spu_pseudo_register_read_spu):  Likewise.
12509         * xtensa-tdep.c (xtensa_pseudo_register_read): Likewise.
12510
12511 2018-01-22  Yao Qi  <yao.qi@linaro.org>
12512
12513         * Makefile.in (ALL_TARGET_OBS): Remove mt-tdep.o.
12514         * configure.tgt: Remove target mt.
12515         * mt-tdep.c: Remove.
12516         * regcache.c (cooked_read_test): Remove the check for mt.
12517
12518 2018-01-22  Yao Qi  <yao.qi@linaro.org>
12519
12520         * jit.c (jit_frame_prev_register): Call regcache::cooked_read
12521         instead of gdbarch_pseudo_register_read_value.
12522
12523 2018-01-22  Joel Brobecker  <brobecker@adacore.com>
12524
12525         * dwarf2read.c (need_gnat_info): Return nonzero if the cu's
12526         language is Ada.
12527
12528 2018-01-22  Joel Brobecker  <brobecker@adacore.com>
12529
12530         * linespec.c (create_sals_line_offset): Remove code that preserved
12531         the symtab_and_line's line number.
12532
12533 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
12534
12535         * varobj.c (varobj_create): Don't set valid_block when creating a
12536         floating varobj.
12537
12538 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
12539
12540         * varobj.c (varobj_create): Remove out of date comment.
12541
12542 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
12543
12544         PR mi/20395
12545         * ada-exp.y (write_var_from_sym): Pass extra parameter when
12546         updating innermost block.
12547         * parse.c (innermost_block_tracker::update): Take extra type
12548         parameter, and check types match before updating innermost block.
12549         (write_dollar_variable): Update innermost block for registers.
12550         * parser-defs.h (enum innermost_block_tracker_type): New enum.
12551         (innermost_block_tracker::innermost_block_tracker): Initialise
12552         m_types member.
12553         (innermost_block_tracker::reset): Take type parameter.
12554         (innermost_block_tracker::update): Take type parameter, and pass
12555         type through as needed.
12556         (innermost_block_tracker::m_types): New member.
12557         * varobj.c (varobj_create): Pass type when reseting innermost
12558         block.
12559
12560 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
12561
12562         * ada-exp.y (write_var_from_sym): Switch to innermost_block API.
12563         * ada-lang.c (resolve_subexp): Likewise.
12564         * breakpoint.c (set_breakpoint_condition) Likewise.
12565         (watch_command_1) Likewise.
12566         * c-exp.y (variable): Likewise.
12567         * d-exp.y (PrimaryExpression): Likewise.
12568         * f-exp.y (variable): Likewise.
12569         * go-exp.y (variable): Likewise.
12570         * m2-exp.y (variable): Likewise.
12571         * objfiles.c (objfile::~objfile): Likewise.
12572         * p-exp.y (variable): Likewise.
12573         * parse.c (innermost_block): Change type.
12574         * parser-defs.h (class innermost_block_tracker): New.
12575         (innermost_block): Change to innermost_block_tracker.
12576         * printcmd.c (display_command): Switch to innermost_block API.
12577         (do_one_display): Likewise.
12578         * rust-exp.y (do_one_display): Likewise.
12579         * symfile.c (clear_symtab_users): Likewise.
12580         * varobj.c (varobj_create): Switch to innermost_block API, replace
12581         use of innermost_block with block stored on varobj object.
12582
12583 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
12584
12585         * expression.h (innermost_block): Remove declaration.
12586         * varobj.c: Add 'parser-defs.h' include.
12587
12588 2018-01-19  Tom Tromey  <tom@tromey.com>
12589
12590         * rust-lang.c (rust_lookup_symbol_nonlocal): Look up qualified
12591         symbols in the static and global blocks.
12592
12593 2018-01-19  James Clarke  <jrtc27@jrtc27.com>
12594
12595         * nat/linux-ptrace.c: Remove unnecessary reinclusion of
12596         gdb_ptrace.h, and move including gdb_wait.h ...
12597         * nat/linux-ptrace.h: ... to here.
12598
12599 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
12600
12601         * inf-ptrace.c (inf_ptrace_detach): Adjust call to
12602         inf_ptrace_detach_success.
12603         (inf_ptrace_detach_success): Add inferior parameter, use it
12604         instead of inferior_ptid, pass it to detach_inferior.
12605         * inf-ptrace.h (inf_ptrace_detach_success): Add inferior
12606         parameter.
12607         * inferior.c (detach_inferior): Add overload that takes an
12608         inferior object.
12609         * inferior.h (detach_inferior): Likewise.
12610         * linux-nat.c (linux_nat_detach): Use the inf parameter, don't
12611         use inferior_ptid, adjust call to inf_ptrace_detach_success.
12612         * linux-thread-db.c (thread_db_detach): Use inf parameter.
12613
12614 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
12615
12616         * target.h (struct target_ops) <to_detach>: Add inferior
12617         parameter.
12618         (target_detach): Likewise.
12619         * target.c (dispose_inferior): Pass inferior down.
12620         (target_detach): Pass inferior down.  Assert that it is equal to
12621         the current inferior.
12622         * aix-thread.c (aix_thread_detach): Pass inferior down.
12623         * corefile.c (core_file_command): Pass current_inferior() down.
12624         * corelow.c (core_detach): Add inferior parameter.
12625         * darwin-nat.c (darwin_detach): Likewise.
12626         * gnu-nat.c (gnu_detach): Likewise.
12627         * inf-ptrace.c (inf_ptrace_detach): Likewise.
12628         * infcmd.c (detach_command): Pass current_inferior() down to
12629         target_detach.
12630         * infrun.c (follow_fork_inferior): Pass parent_inf to
12631         target_detach.
12632         (handle_vfork_child_exec_or_exit): Pass inf->vfork_parent to
12633         target_detach.
12634         * linux-nat.c (linux_nat_detach): Add inferior parameter.
12635         * linux-thread-db.c (thread_db_detach): Likewise.
12636         * nto-procfs.c (procfs_detach): Likewise.
12637         * procfs.c (procfs_detach): Likewise.
12638         * record.c (record_detach): Likewise.
12639         * record.h (struct inferior): Forward-declare.
12640         (record_detach): Add inferior parameter.
12641         * remote-sim.c (gdbsim_detach): Likewise.
12642         * remote.c (remote_detach_1): Likewise.
12643         (remote_detach): Likewise.
12644         (extended_remote_detach): Likewise.
12645         * sol-thread.c (sol_thread_detach): Likewise.
12646         * target-debug.h (target_debug_print_inferior_p): New macro.
12647         * target-delegates.c: Re-generate.
12648         * top.c (kill_or_detach): Pass inferior down to target_detach.
12649         * windows-nat.c (windows_detach): Add inferior parameter.
12650
12651 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
12652
12653         * target.h (struct target_ops) <to_detach>: Remove args
12654         parameter.
12655         (target_detach): Likewise.
12656         * target.c (dispose_inferior): Adjust.
12657         (target_detach): Remove args parameter, adjust.
12658         * aix-thread.c (aix_thread_detach): Adjust.
12659         * corefile.c (core_file_command): Adjust.
12660         * corelow.c (core_detach): Adjust.
12661         * darwin-nat.c (darwin_detach): Adjust.
12662         * gnu-nat.c (gnu_detach): Adjust.
12663         * inf-ptrace.c (inf_ptrace_detach): Adjust.
12664         * infcmd.c (detach_command): Adjust
12665         * infrun.c (follow_fork_inferior): Adjust.
12666         (handle_vfork_child_exec_or_exit): Adjust.
12667         * linux-fork.c (linux_fork_detach): Remove args parameter.
12668         * linux-fork.h (linux_fork_detach): Likewise.
12669         * linux-nat.c (linux_nat_detach): Likewise, and adjust.
12670         * linux-thread-db.c (thread_db_detach): Likewise.
12671         * nto-procfs.c (procfs_detach): Likewise.
12672         * procfs.c (procfs_detach): Likewise.
12673         (do_detach): Remove signo parameter.
12674         * record.c (record_detach): Remove args parameter.
12675         * record.h (record_detach): Likewise.
12676         * remote-sim.c (gdbsim_detach): Likewise.
12677         * remote.c (remote_detach_1): Likewise.
12678         (remote_detach): Likewise.
12679         (extended_remote_detach): Likewise.
12680         * sol-thread.c (sol_thread_detach): Likewise.
12681         * target-delegates.c: Re-generate.
12682         * top.c (struct qt_args) <args>: Remove field.
12683         (kill_or_detach): Don't pass args.
12684         (quit_force): Don't set args.
12685         * windows-nat.c (windows_detach): Remove args parameter.
12686
12687 2018-01-19  Yao Qi  <yao.qi@linaro.org>
12688
12689         * arm-linux-tdep.c (arm_linux_gcc_target_options): New function.
12690         (arm_linux_init_abi): Install it.
12691
12692 2018-01-19  Yao Qi  <yao.qi@linaro.org>
12693
12694         * osabi.c (gdb_osabi_names): Extend the regexp for
12695         arm-linux-gnueabihf.
12696
12697 2018-01-18  Yao Qi  <yao.qi@linaro.org>
12698
12699         * dwarf2read.c (abbrev_table) <abbrevs>: Rename it to
12700         m_abbrevs.
12701         (abbrev_table::add_abbrev): Update.
12702         (abbrev_table::lookup_abbrev): Update.
12703
12704 2018-01-18  Yao Qi  <yao.qi@linaro.org>
12705
12706         * ppc-linux-tdep.c (ppu2spu_prev_register): Call cooked_read.
12707
12708 2018-01-17  Sergio Durigan Junior  <sergiodj@redhat.com>
12709
12710         * compile/compile.c (compile_to_object): Convert "triplet_rx"
12711         to "std::string".
12712
12713 2018-01-17  Tom Tromey  <tom@tromey.com>
12714
12715         * dwarf2read.c (symbolp): Remove typedef.  Don't instantiate VEC.
12716
12717 2018-01-17  Tom Tromey  <tom@tromey.com>
12718
12719         * gdbtypes.h (add_dyn_prop): Remove objfile parameter.
12720         * gdbtypes.c (add_dyn_prop): Remove objfile parameter.
12721         (create_array_type_with_stride): Update.
12722         * dwarf2read.c (set_die_type): Update.
12723
12724 2018-01-17  Tom Tromey  <tom@tromey.com>
12725
12726         * dwarf2read.c (delayed_method_info): Remove typedef.
12727         (dwarf2_cu::method_info): Now a std::vector.
12728         (add_to_method_list): Update.
12729         (free_delayed_list): Remove.
12730         (compute_delayed_physnames): Update.
12731         (process_full_comp_unit, process_full_type_unit): Clear the method
12732         list.  Remove cleanups.
12733         (psymtab_include_file_name): Add name_holder parameter.  Use
12734         unique_xmalloc_ptr.
12735         (dwarf_decode_lines): Update.
12736
12737 2018-01-17  Tom Tromey  <tom@tromey.com>
12738             Simon Marchi  <simon.marchi@ericsson.com>
12739
12740         * dwarf2read.c (struct dwarf2_cu): Add constructor, destructor.
12741         (dwarf2_per_objfile::free_cached_comp_units)
12742         (init_tu_and_read_dwo_dies, init_cutu_and_read_dies)
12743         (init_cutu_and_read_dies_no_follow): Update.
12744         (dwarf2_cu::dwarf2_cu): Rename from init_one_comp_unit.
12745         (dwarf2_cu::~dwarf2_cu): New.
12746         (free_heap_comp_unit, free_stack_comp_unit): Remove.
12747         (age_cached_comp_units, free_one_cached_comp_unit): Update.
12748
12749 2018-01-17  Tom Tromey  <tom@tromey.com>
12750             Simon Marchi  <simon.marchi@ericsson.com>
12751
12752         * dwarf2read.c (struct dwarf2_cu) <abbrev_table>: Remove.
12753         (struct die_reader_specs) <abbrev_table>: New member.
12754         (struct abbrev_table): Add constructor.
12755         <alloc_abbrev, add_abbrev, lookup_abbrev>: Declare.
12756         <abbrev_obstack>: Now an auto_obstack.
12757         (abbrev_table_up): New typedef.
12758         (init_cu_die_reader): Add abbrev_table parameter.
12759         (read_cutu_die_from_dwo): Remove abbrev_table_provided parameter.
12760         Add result_dwo_abbrev_table.
12761         (init_tu_and_read_dwo_dies, init_cutu_and_read_dies)
12762         (init_cutu_and_read_dies_no_follow, build_type_psymtabs_1):
12763         Update.
12764         (peek_die_abbrev): Take die_reader_specs, not dwarf_cu as
12765         parameter.
12766         (skip_children): Update.
12767         (abbrev_table::alloc_abbrev): Rename from
12768         abbrev_table_alloc_abbrev.
12769         (abbrev_table::add_abbrev): Rename from abbrev_table_add_abbrev.
12770         (abbrev_table::lookup_abbrev): Rename from
12771         abbrev_table_lookup_abbrev.
12772         (abbrev_table_read_table): Return abbrev_table_up.
12773         (abbrev_table_free, abbrev_table_free_cleanup)
12774         (dwarf2_read_abbrevs, dwarf2_free_abbrev_table): Remove.
12775         (load_partial_dies): Update.
12776
12777 2018-01-17  Tom Tromey  <tom@tromey.com>
12778
12779         * dwarf2read.c (dwarf2_compute_name): Update comment.
12780         (read_func_scope, read_variable): Update.
12781         (new_symbol): Remove.
12782         (new_symbol_full): Rename to new_symbol.
12783
12784 2018-01-17  Mike Gulick  <mgulick@mathworks.com>
12785
12786         PR gdb/16577
12787         * gdb_bfd.c (gdb_bfd_map_section): If unable to read object file, issue
12788         a warning instead of throwing an error, set section size to 0 and return
12789         NULL.
12790         * gdb_bfd.h (gdb_bfd_map_section): Update description.
12791
12792 2018-01-17  Simon Marchi  <simon.marchi@ericsson.com>
12793
12794         * nat/linux-ptrace.h (linux_ptrace_attach_fail_reason): Return
12795         std::string.
12796         (linux_ptrace_attach_fail_reason_string): Likewise.
12797         * nat/linux-ptrace.c (linux_ptrace_attach_fail_reason):
12798         Likewise.
12799         (linux_ptrace_attach_fail_reason_string): Likewise.
12800         * linux-nat.c (attach_proc_task_lwp_callback): Adjust.
12801
12802 2018-01-17  Simon Marchi  <simon.marchi@ericsson.com>
12803
12804         * linux-nat.c (linux_nat_attach): Remove xstrdup.
12805
12806 2018-01-17  Eldar Abusalimov  <eldar.abusalimov@jetbrains.com>
12807
12808         PR gdb/21559
12809         * configure.ac: Include <sys/types.h> prior to <sys/user.h> when
12810         checking for fs_base/gs_base fields in struct user_regs_struct.
12811         * configure: Regenerate.
12812
12813 2018-01-17  Yao Qi  <yao.qi@linaro.org>
12814
12815         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): New
12816         function.
12817         (aarch64_linux_init_abi): Install it to gdbarch hook
12818         gcc_target_options.
12819
12820 2018-01-15  Pedro Alves  <palves@redhat.com>
12821
12822         * common/signals-state-save-restore.c
12823         (save_original_signals_state): Fix typos.
12824
12825 2017-01-12  Tom Tromey  <tom@tromey.com>
12826             Sergio Durigan Junior  <sergiodj@redhat.com>
12827
12828         * Makefile.in (install-only): Install gdb-add-index.
12829
12830 2018-01-12  John Baldwin  <jhb@FreeBSD.org>
12831
12832         * fbsd-tdep.c (KVE_PROTECTION): Correct value.
12833
12834 2018-01-12  Andreas Arnez  <arnez@linux.vnet.ibm.com>
12835
12836         * infrun.c (keep_going_pass_signal): Clear step-over info when
12837         insert_breakpoints fails.
12838
12839 2018-01-11  Pedro Alves  <palves@redhat.com>
12840
12841         PR gdb/22583
12842         * infrun.c (resume): Rename to ...
12843         (resume_1): ... this.
12844         (resume): Reimplement as wrapper around resume_1.
12845
12846 2018-01-11  Pedro Alves  <palves@redhat.com>
12847
12848         PR remote/22597
12849         * remote.c (remote_parse_stop_reply): Default to the last-set
12850         general thread instead of to 'magic_null_ptid'.
12851
12852 2018-01-10  Pedro Alves  <palves@redhat.com>
12853
12854         * language.h (language_get_symbol_name_matcher): Rename ...
12855         (get_symbol_name_matcher): ... this.
12856         * language.c (language_get_symbol_name_matcher): Ditto.
12857         * dictionary.c, linespec.c, minsyms.c, psymtab.c, symtab.c: All
12858         callers adjusted.
12859
12860 2018-01-10  Pedro Alves  <palves@redhat.com>
12861
12862         PR gdb/22670
12863         * dwarf2read.c
12864         (gdb_index_symbol_name_matcher::gdb_index_symbol_name_matcher):
12865         Adjust to use language_get_symbol_name_matcher instead of
12866         language_defn::la_get_symbol_name_matcher.
12867         * language.c (language_get_symbol_name_matcher): If in Ada mode
12868         and the lookup name is a verbatim match, return Ada's matcher.
12869         * language.h (language_get_symbol_name_matcher): Adjust comment.
12870         (ada_lookup_name_info::verbatim_p):: New method.
12871
12872 2018-01-10  Pedro Alves  <palves@redhat.com>
12873
12874         PR gdb/22670
12875         * ada-lang.c (ada_collect_symbol_completion_matches): If the
12876         minsym's language is language_auto or language_cplus, pass down
12877         language_ada instead.
12878         * symtab.c (compare_symbol_name): Don't frob symbol language here.
12879
12880 2018-01-10  Pedro Alves  <palves@redhat.com>
12881
12882         PR gdb/22670
12883         * minsyms.c (linkage_name_str): New function.
12884         (iterate_over_minimal_symbols): Use it.
12885
12886 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
12887
12888         * NEWS: Document that 'info proc' now works on FreeBSD.
12889
12890 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
12891
12892         * configure.ac: Check for kinfo_getfile in libutil.
12893         * configure: Regenerate.
12894         * config.in: Regenerate.
12895         * fbsd-nat.c: Include "fbsd-tdep.h".
12896         (fbsd_fetch_cmdline): New.
12897         (fbsd_fetch_kinfo_proc): Move earlier and change to return a bool
12898         rather than calling error.
12899         (fbsd_info_proc): New.
12900         (fbsd_thread_name): Report error if fbsd_fetch_kinfo_proc fails.
12901         (fbsd_wait): Report warning if fbsd_fetch_kinfo_proc fails.
12902         (fbsd_nat_add_target): Set "to_info_proc" to "fbsd_info_proc".
12903
12904 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
12905
12906         * fbsd-nat.c (struct free_deleter): Remove.
12907         (fbsd_find_memory_regions): Use gdb::unique_xmalloc_ptr<>.
12908
12909 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
12910
12911         * fbsd-nat.c (fbsd_pid_to_exec_file) [KERN_PROC_PATHNAME]: Return
12912         NULL for an empty pathname.
12913
12914 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
12915
12916         * fbsd-tdep.c (KVE_STRUCTSIZE, KVE_START, KVE_END, KVE_OFFSET)
12917         (KVE_FLAGS, KVE_PROTECTION, KVE_PATH, KINFO_VME_PROT_READ)
12918         (KINFO_VME_PROT_WRITE, KINFO_VME_PROT_EXEC, KINFO_VME_FLAG_COW)
12919         (KINFO_VME_FLAG_NEEDS_COPY, KINFO_VME_FLAG_NOCOREDUMP)
12920         (KINFO_VME_FLAG_SUPER, KINFO_VME_FLAG_GROWS_UP)
12921         (KINFO_VME_FLAG_GROWS_DOWN, KF_STRUCTSIZE, KF_TYPE, KF_FD)
12922         (KF_PATH, KINFO_FILE_TYPE_VNODE, KINFO_FILE_FD_TYPE_CWD)
12923         (KINFO_FILE_FD_TYPE_TEXT, SIG_WORDS, struct kinfo_proc_layout)
12924         (kinfo_proc_layout_32, kinfo_proc_layout_i386)
12925         (kinfo_proc_layout_64, fbsd_vm_map_entry_flags)
12926         (fbsd_core_info_proc_mappings, fbsd_core_vnode_path)
12927         (fbsd_core_fetch_timeval, fbsd_print_sigset)
12928         (fbsd_core_info_proc_status, fbsd_core_info_proc): New.
12929         (fbsd_init_abi):  Install gdbarch "core_info_proc" method.
12930         * fbsd-tdep.h (fbsd_vm_map_entry_flags): New.
12931
12932 2018-01-08  Samuel Thibault  <samuel.thibault@ens-lyon.org>
12933
12934         * gdb/gnu-nat.c: Include <elf.h> and <link.h>.
12935         (gnu_xfer_auxv): New function.
12936         (gnu_xfer_partial): Call gnu_xfer_auxv when `object' is
12937         TARGET_OBJECT_AUXV.
12938
12939 2018-01-08  Yao Qi  <yao.qi@linaro.org>
12940             Simon Marchi  <simon.marchi@ericsson.com>
12941
12942         * Makefile.in (COMMON_SFILES): Remove selftest-arch.c and
12943         common/selftest.c.
12944         (COMMON_OBS): Remove selftest.o.
12945         * configure.ac: Append selftest-arch.c and common/selftest.c to
12946         CONFIG_SRCS.  Append selftest-arch.o and selftest.o to COMMON_OBS.
12947         * configure: Re-generated.
12948         * maint.c (maintenance_selftest): Wrap selftests::run_tests with
12949         GDB_SELF_TEST.
12950         (maintenance_info_selftests): Likewise.
12951
12952 2018-01-08  Xavier Roirand  <roirand@adacore.com>
12953
12954         * ada-valprint.c (val_print_packed_array_elements): Use
12955         proper number of elements when printing an array indexed
12956         by an enumeration type.
12957
12958 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
12959
12960         * dwarf2read.c (struct dwarf2_cu) <dwarf2_per_objfile>: Remove.
12961         (dw2_get_file_names_reader): Adjust.
12962         (lookup_dwo_signatured_type): Adjust.
12963         (lookup_dwp_signatured_type): Adjust.
12964         (lookup_signatured_type): Adjust.
12965         (create_type_unit_group): Adjust.
12966         (get_type_unit_group): Adjust.
12967         (process_psymtab_comp_unit_reader): Adjust.
12968         (build_type_psymtabs_reader): Adjust.
12969         (scan_partial_symbols): Adjust.
12970         (add_partial_symbol): Adjust.
12971         (add_partial_subprogram): Adjust.
12972         (peek_die_abbrev): Adjust.
12973         (fixup_go_packaging): Adjust.
12974         (process_imported_unit_die): Adjust.
12975         (dwarf2_compute_name): Adjust.
12976         (dwarf2_physname): Adjust.
12977         (read_import_statement): Adjust.
12978         (handle_DW_AT_stmt_list): Adjust.
12979         (read_file_scope): Adjust.
12980         (read_func_scope): Adjust.
12981         (read_lexical_block_scope): Adjust.
12982         (read_call_site_scope): Adjust.
12983         (read_variable): Adjust.
12984         (dwarf2_rnglists_process): Adjust.
12985         (dwarf2_ranges_process): Adjust.
12986         (dwarf2_ranges_read): Adjust.
12987         (dwarf2_get_pc_bounds): Adjust.
12988         (dwarf2_record_block_ranges): Adjust.
12989         (dwarf2_add_field): Adjust.
12990         (dwarf2_add_member_fn): Adjust.
12991         (read_structure_type): Adjust.
12992         (process_structure_scope): Adjust.
12993         (read_enumeration_type): Adjust.
12994         (read_array_type): Adjust.
12995         (mark_common_block_symbol_computed): Adjust.
12996         (read_common_block): Adjust.
12997         (read_namespace_type): Adjust.
12998         (read_namespace): Adjust.
12999         (read_module_type): Adjust.
13000         (read_tag_pointer_type): Adjust.
13001         (read_tag_ptr_to_member_type): Adjust.
13002         (read_tag_string_type): Adjust.
13003         (read_subroutine_type): Adjust.
13004         (read_typedef): Adjust.
13005         (read_base_type): Adjust.
13006         (attr_to_dynamic_prop): Adjust.
13007         (read_subrange_type): Adjust.
13008         (read_unspecified_type): Adjust.
13009         (dwarf2_read_abbrevs): Adjust.
13010         (load_partial_dies): Adjust.
13011         (read_partial_die): Adjust.
13012         (find_partial_die): Adjust.
13013         (guess_partial_die_structure_name): Adjust.
13014         (fixup_partial_die): Adjust.
13015         (read_attribute_value): Adjust.
13016         (read_addr_index): Adjust.
13017         (read_addr_index_from_leb128): Adjust.
13018         (read_str_index): Adjust.
13019         (dwarf2_string_attr): Adjust.
13020         (get_debug_line_section): Adjust.
13021         (dwarf_decode_line_header): Adjust.
13022         (lnp_state_machine::check_line_address): Adjust.
13023         (dwarf_decode_lines_1): Adjust.
13024         (dwarf_decode_lines): Adjust.
13025         (dwarf2_start_symtab): Adjust.
13026         (var_decode_location): Adjust.
13027         (new_symbol_full): Adjust.
13028         (dwarf2_const_value_data): Adjust.
13029         (dwarf2_const_value_attr): Adjust.
13030         (dwarf2_const_value): Adjust.
13031         (die_type): Adjust.
13032         (die_containing_type): Adjust.
13033         (build_error_marker_type): Adjust.
13034         (lookup_die_type): Adjust.
13035         (guess_full_die_structure_name): Adjust.
13036         (anonymous_struct_prefix): Adjust.
13037         (determine_prefix): Adjust.
13038         (dwarf2_name): Adjust.
13039         (follow_die_ref_or_sig): Adjust.
13040         (follow_die_offset): Adjust.
13041         (follow_die_ref): Adjust.
13042         (follow_die_sig_1): Adjust.
13043         (follow_die_sig): Adjust.
13044         (get_signatured_type): Adjust.
13045         (get_DW_AT_signature_type): Adjust.
13046         (decode_locdesc): Adjust.
13047         (dwarf_decode_macros): Adjust.
13048         (cu_debug_loc_section): Adjust.
13049         (fill_in_loclist_baton): Adjust.
13050         (dwarf2_symbol_mark_computed): Adjust.
13051         (init_one_comp_unit): Don't assign
13052         dwarf2_cu::dwarf2_per_objfile.
13053         (set_die_type): Adjust.
13054
13055 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
13056
13057         * dwarf2read.c (struct mapped_debug_names): Add constructor.
13058         <dwarf2_per_objfile>: New field.
13059         (dwarf2_per_objfile): Remove global.
13060         (get_dwarf2_per_objfile): New function.
13061         (set_dwarf2_per_objfile): New function.
13062         (dwarf2_build_psymtabs_hard): Change objfile parameter to
13063         dwarf2_per_objfile.
13064         (abbrev_table_read_table): Add dwarf2_per_objfile parameter.
13065         (read_abbrev_offset): Likewise.
13066         (read_indirect_string): Likewise.
13067         (read_indirect_line_string): Likewise.
13068         (read_indirect_string_at_offset): Likewise.
13069         (read_indirect_string_from_dwz): Likewise.
13070         (dwarf2_find_containing_comp_unit): Change objfile parameter to
13071         dwarf2_per_objfile.
13072         (age_cached_comp_units): Add dwarf2_per_objfile parameter.
13073         (create_all_comp_units): Change objfile parameter to
13074         dwarf2_per_objfile.
13075         (create_all_type_units): Likewise.
13076         (process_queue): Add dwarf2_per_objfile parameter.
13077         (read_and_check_comp_unit_head): Likewise.
13078         (lookup_dwo_unit_in_dwp): Likewise.
13079         (get_dwp_file): Likewise.
13080         (process_cu_includes): Likewise.
13081         (struct free_dwo_file_cleanup_data): New struct.
13082         (dwarf2_has_info): Use get_dwarf2_per_objfile and
13083         set_dwarf2_per_objfile.
13084         (dwarf2_get_dwz_file): Add dwarf2_per_objfile parameter.
13085         (dw2_do_instantiate_symtab): Get dwarf2_per_objfile from
13086         context, adjust calls.
13087         (dw2_instantiate_symtab): Likewise.
13088         (dw2_get_cutu): Add dwarf2_per_objfile parameter.
13089         (dw2_get_cu): Likewise.
13090         (create_cu_from_index_list): Change objfile parameter to
13091         dwarf2_per_objfile.
13092         (create_cus_from_index_list): Get dwarf2_per_objfile from
13093         context, adjust calls.
13094         (create_cus_from_index): Likewise.
13095         (create_signatured_type_table_from_index): Change objfile
13096         parameter to dwarf2_per_objfile.
13097         (create_signatured_type_table_from_debug_names): Change objfile
13098         parameter to dwarf2_per_objfile.
13099         (create_addrmap_from_index): Likewise.
13100         (create_addrmap_from_aranges): Likewise.
13101         (dwarf2_read_index): Use get_dwarf2_per_objfile, adjust calls.
13102         (dw2_setup): Remove.
13103         (dw2_get_file_names_reader): Get dwarf2_per_objfile from
13104         context.
13105         (dw2_find_last_source_symtab): Get dwarf2_per_objfile using
13106         get_dwarf2_per_objfile.
13107         (dw2_forget_cached_source_info): Likewise.
13108         (dw2_map_symtabs_matching_filename): Likewise.
13109         (struct dw2_symtab_iterator) <index>: Remove.
13110         <dwarf2_per_objfile>: New field.
13111         (dw2_symtab_iter_init): Replace index parameter with
13112         dwarf2_per_objfile.
13113         (dw2_symtab_iter_next): Use dwarf2_per_objfile from iter.
13114         (dw2_lookup_symbol): Use get_dwarf2_per_objfile and adjust.
13115         (dw2_print_stats): Likewise.
13116         (dw2_dump): Likewise.
13117         (dw2_expand_symtabs_for_function): Likewise.
13118         (dw2_expand_all_symtabs): Likewise.
13119         (dw2_expand_symtabs_with_fullname): Likewise.
13120         (dw2_expand_marked_cus): Replace index and objfile parameters
13121         with dwarf2_per_objfile.
13122         (dw_expand_symtabs_matching_file_matcher): Add
13123         dwarf2_per_objfile parameter and adjust calls.
13124         (dw2_expand_symtabs_matching): Use get_dwarf2_per_objfile and
13125         adjust calls.
13126         (dw2_find_pc_sect_compunit_symtab): Don't call dw2_setup.
13127         (dw2_map_symbol_filenames): Use get_dwarf2_per_objfile and
13128         adjust calls.
13129         (create_cus_from_debug_names_list): Replace objfile parameter
13130         with dwarf2_per_objfile and adjust calls.
13131         (create_cus_from_debug_names): Likewise.
13132         (dwarf2_read_debug_names): Likewise.
13133         (mapped_debug_names::namei_to_name): Adjust call.
13134         (dw2_debug_names_iterator::next): Likewise.
13135         (dw2_debug_names_iterator::find_vec_in_debug_names): Likewise.
13136         (dw2_debug_names_lookup_symbol): Use get_dwarf2_per_objfile.
13137         (dw2_debug_names_dump): Likewise.
13138         (dw2_debug_names_expand_symtabs_for_function): Likewise.
13139         (dw2_debug_names_expand_symtabs_matching): Likewise.
13140         (dwarf2_initialize_objfile): Likewise.
13141         (dwarf2_build_psymtabs): Likewise.
13142         (get_abbrev_section_for_cu): Get dwarf2_per_objfile from
13143         this_cu.
13144         (error_check_comp_unit_head): Add dwarf2_per_objfile parameter.
13145         (read_and_check_comp_unit_head): Likewise.
13146         (read_abbrev_offset): Likewise.
13147         (create_debug_type_hash_table): Likewise.
13148         (create_debug_types_hash_table): Likewise.
13149         (create_all_type_units): Replace objfile parameter with
13150         dwarf2_per_objfile.
13151         (add_type_unit): Add dwarf2_per_objfile parameter.
13152         (fill_in_sig_entry_from_dwo_entry): Replace objfile parameter
13153         with dwarf2_per_objfile.
13154         (lookup_dwo_signatured_type): Get dwarf2_per_objfile from cu.
13155         (lookup_dwp_signatured_type): Likewise.
13156         (lookup_signatured_type): Likewise.
13157         (read_cutu_die_from_dwo): Likewise.
13158         (init_tu_and_read_dwo_dies): Likewise.
13159         (init_cutu_and_read_dies): Likewise.
13160         (init_cutu_and_read_dies_no_follow): Likewise.
13161         (allocate_type_unit_groups_table): Add objfile parameter.
13162         (create_type_unit_group): Use dwarf2_per_objfile from cu.
13163         (get_type_unit_group): Likewise.
13164         (process_psymtab_comp_unit): Update call.
13165         (build_type_psymtabs_reader): Use dwarf2_per_objfile from cu.
13166         (build_type_psymtabs_1): Add dwarf2_per_objfile parameter.
13167         (print_tu_stats): Likewise.
13168         (build_type_psymtab_dependencies): Use dwarf2_per_objfile passed
13169         in void* parameter.
13170         (build_type_psymtabs): Change objfile parameter to
13171         dwarf2_per_objfile.
13172         (process_skeletonless_type_unit): Use dwarf2_per_objfile
13173         passed in void* parameter.
13174         (process_skeletonless_type_units): Change objfile parameter to
13175         dwarf2_per_objfile.
13176         (set_partial_user): Likewise.
13177         (dwarf2_build_psymtabs_hard): Likewise.
13178         (read_comp_units_from_section): Likewise.
13179         (create_all_comp_units): Likewise.
13180         (scan_partial_symbols): Update calls.
13181         (add_partial_symbol): Likewise.
13182         (dwarf2_read_symtab): Use get_dwarf2_per_objfile.
13183         (maybe_queue_comp_unit): Use dwarf2_read_symtab from cu.
13184         (process_queue): Add dwarf2_per_objfile parameter.
13185         (get_compunit_symtab): Use dwarf2_per_objfile from cu.
13186         (compute_compunit_symtab_includes): Likewise.
13187         (process_cu_includes): Add dwarf2_per_objfile parameter.
13188         (process_full_comp_unit): Use dwarf2_per_objfile from cu.
13189         (process_full_type_unit): Likewise.
13190         (process_imported_unit_die): Update call.
13191         (handle_DW_AT_stmt_list): Use dwarf2_per_objfile from cu.
13192         (read_file_scope): Likewise.
13193         (allocate_dwo_file_hash_table): Add objfile parameter.
13194         (lookup_dwo_file_slot): Add dwarf2_per_objfile parameter.
13195         (create_cus_hash_table): Likewise.
13196         (create_dwp_hash_table): Likewise.
13197         (create_dwo_unit_in_dwp_v1): Likewise.
13198         (create_dwp_v2_section): Likewise.
13199         (create_dwo_unit_in_dwp_v2): Likewise.
13200         (lookup_dwo_unit_in_dwp): Likewise.
13201         (try_open_dwop_file): Likewise.
13202         (open_dwo_file): Likewise. Use dwarf2_per_objfile from cu.
13203         (open_and_init_dwo_file): Use dwarf2_per_objfile from cu, update
13204         cleanup to include a reference to dwarf2_per_objfile.
13205         (open_dwp_file): Add dwarf2_per_objfile parameter.
13206         (open_and_init_dwp_file): Likewise.
13207         (get_dwp_file): Likewise.
13208         (lookup_dwo_cutu): Use dwarf2_per_objfile from cu.
13209         (queue_and_load_all_dwo_tus): Update call.
13210         (free_dwo_file_cleanup): Use dwarf2_per_objfile from cleanup
13211         data.
13212         (dwarf2_rnglists_process): Use dwarf2_per_objfile from cu.
13213         (dwarf2_ranges_process): Likewise.
13214         (dwarf2_get_pc_bounds): Likewise.
13215         (mark_common_block_symbol_computed): Likewise.
13216         (abbrev_table_read_table): Add dwarf2_per_objfile parameter.
13217         (dwarf2_read_abbrevs): Update call.
13218         (read_partial_die): Use dwarf2_per_objfile from cu.
13219         (find_partial_die): Likewise.
13220         (fixup_partial_die): Likewise.
13221         (read_attribute_value): Likewise.
13222         (read_indirect_string_at_offset_from): Add objfile parameter.
13223         (read_indirect_string_at_offset): Add dwarf2_per_objfile
13224         parameter.
13225         (read_indirect_string_from_dwz): Add objfile parameter.
13226         (read_indirect_string): Add objfile parameter.
13227         (read_addr_index_1): Add dwarf2_per_objfile parameter.
13228         (read_addr_index): Use dwarf2_per_objfile from cu.
13229         (dwarf2_read_addr_index): Use dwarf2_per_objfile from cu, don't
13230         call dw2_setup.
13231         (read_str_index): Use dwarf2_per_objfile from cu.
13232         (get_debug_line_section): Likewise.
13233         (read_formatted_entries): Add dwarf2_per_objfile parameter.
13234         (dwarf_decode_line_header): Use dwarf2_per_objfile from cu.
13235         (new_symbol_full): Use dwarf2_per_objfile from cu.
13236         (build_error_marker_type): Likewise.
13237         (lookup_die_type): Likewise.
13238         (determine_prefix): Likewise.
13239         (follow_die_offset): Likewise.
13240         (dwarf2_fetch_die_loc_sect_off): Use get_dwarf2_per_objfile.
13241         (dwarf2_fetch_constant_bytes): Don't call dw2_setup.
13242         (dwarf2_fetch_die_type_sect_off): Likewise.
13243         (dwarf2_get_die_type): Likewise.
13244         (follow_die_sig_1): Use dwarf2_per_objfile from cu.
13245         (get_signatured_type): Likewise.
13246         (get_DW_AT_signature_type): Likewise.
13247         (dwarf_decode_macro_bytes): Add dwarf2_per_objfile parameter.
13248         (dwarf_decode_macros): Use dwarf2_per_objfile from cu.
13249         (cu_debug_loc_section): Likewise.
13250         (fill_in_loclist_baton): Likewise.
13251         (dwarf2_symbol_mark_computed): Likewise.
13252         (dwarf2_find_containing_comp_unit): Change objfile parameter to
13253         dwarf2_per_objfile.
13254         (free_cached_comp_units): Use dwarf2_per_objfile passed in void*
13255         parameter.
13256         (age_cached_comp_units): Add dwarf2_per_objfile parameter.
13257         (free_one_cached_comp_unit): Use dwarf2_per_objfile from cu.
13258         (dwarf2_free_objfile): Use get_dwarf2_per_objfile.
13259         (set_die_type): Use dwarf2_free_objfile from cu.
13260         (get_die_type_at_offset): Likewise.
13261         (dwarf2_per_objfile_free): Don't assign global variable.
13262         (debug_names) <constructor>: Add dwarf2_per_objfile
13263         parameter, update m_debugstrlookup construction.
13264         (debug_names::debug_str_lookup): Add dwarf2_per_objfile
13265         parameter.
13266         <m_dwarf2_per_objfile>: New field.
13267         <lookup>: Use m_dwarf2_per_objfile.
13268         (check_dwarf64_offsets): Add dwarf2_per_objfile parameter.
13269         (psyms_seen_size): Likewise.
13270         (write_gdbindex): Replace objfile parameter with
13271         dwarf2_per_objfile.
13272         (write_debug_names): Likewise.
13273         (write_psymtabs_to_index): Likewise.
13274         (save_gdb_index_command): Use get_dwarf2_per_objfile, update
13275         calls.
13276
13277 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
13278
13279         * dwarf2read.c (struct dwarf2_cu) <objfile>: Remove.
13280         <dwarf2_per_objfile>: New field.
13281         (struct dwarf2_per_cu_data) <objfile>: Remove.
13282         <dwarf2_per_objfile>: New field.
13283         (create_cu_from_index_list): Assign dwarf2_per_objfile instead
13284         of objfile.
13285         (create_signatured_type_table_from_index): Likewise.
13286         (create_debug_type_hash_table): Likewise.
13287         (fill_in_sig_entry_from_dwo_entry): Likewise.
13288         (lookup_dwo_unit): Access objfile through dwarf2_per_objfile.
13289         (create_type_unit_group): Assign dwarf2_per_objfile instead of
13290         objfile.
13291         (create_partial_symtab): Access objfile through
13292         dwarf2_per_objfile.
13293         (process_psymtab_comp_unit_reader): Likewise.
13294         (read_comp_units_from_section): Likewise.
13295         (scan_partial_symbols): Likewise.
13296         (add_partial_symbol): Likewise.
13297         (add_partial_subprogram): Likewise.
13298         (peek_die_abbrev): Likewise.
13299         (fixup_go_packaging): Likewise.
13300         (process_full_comp_unit): Likewise.
13301         (process_full_type_unit): Likewise.
13302         (process_imported_unit_die): Likewise.
13303         (dwarf2_compute_name): Likewise.
13304         (dwarf2_physname): Likewise.
13305         (read_import_statement): Likewise.
13306         (create_cus_hash_table): Assign dwarf2_physname instead of
13307         objfile.
13308         (read_func_scope): Access objfile through dwarf2_per_objfile.
13309         (read_lexical_block_scope): Likewise.
13310         (read_call_site_scope): Likewise.
13311         (read_variable): Likewise.
13312         (dwarf2_rnglists_process): Likewise.
13313         (dwarf2_ranges_process): Likewise.
13314         (dwarf2_ranges_read): Likewise.
13315         (dwarf2_record_block_ranges): Likewise.
13316         (dwarf2_add_field): Likewise.
13317         (dwarf2_add_member_fn): Likewise.
13318         (read_structure_type): Likewise.
13319         (process_structure_scope): Likewise.
13320         (read_enumeration_type): Likewise.
13321         (read_array_type): Likewise.
13322         (read_common_block): Likewise.
13323         (read_namespace_type): Likewise.
13324         (read_namespace): Likewise.
13325         (read_module_type): Likewise.
13326         (read_tag_pointer_type): Likewise.
13327         (read_tag_ptr_to_member_type): Likewise.
13328         (read_tag_string_type): Likewise.
13329         (read_subroutine_type): Likewise.
13330         (read_typedef): Likewise.
13331         (read_base_type): Likewise.
13332         (attr_to_dynamic_prop): Likewise.
13333         (read_subrange_type): Likewise.
13334         (read_unspecified_type): Likewise.
13335         (load_partial_dies): Likewise.
13336         (read_partial_die): Likewise.
13337         (find_partial_die): Likewise.
13338         (guess_partial_die_structure_name): Likewise.
13339         (fixup_partial_die): Likewise.
13340         (read_attribute_value): Likewise.
13341         (read_addr_index_from_leb128): Likewise.
13342         (dwarf2_read_addr_index): Likewise.
13343         (dwarf2_string_attr): Likewise.
13344         (lnp_state_machine::check_line_address): Likewise.
13345         (dwarf_decode_lines_1): Likewise.
13346         (dwarf_decode_lines): Likewise.
13347         (dwarf2_start_symtab): Likewise.
13348         (var_decode_location): Likewise.
13349         (new_symbol_full): Likewise.
13350         (dwarf2_const_value_data): Likewise.
13351         (dwarf2_const_value_attr): Likewise.
13352         (dwarf2_const_value): Likewise.
13353         (die_type): Likewise.
13354         (die_containing_type): Likewise.
13355         (lookup_die_type): Likewise.
13356         (guess_full_die_structure_name): Likewise.
13357         (anonymous_struct_prefix): Likewise.
13358         (dwarf2_name): Likewise.
13359         (follow_die_ref_or_sig): Likewise.
13360         (follow_die_offset): Likewise.
13361         (follow_die_ref): Likewise.
13362         (dwarf2_fetch_die_loc_sect_off): Likewise.
13363         (dwarf2_fetch_constant_bytes): Likewise.
13364         (dwarf2_fetch_die_type_sect_off): Likewise.
13365         (dwarf2_get_die_type): Likewise.
13366         (follow_die_sig): Likewise.
13367         (decode_locdesc): Likewise.
13368         (dwarf2_per_cu_objfile): Likewise.
13369         (dwarf2_per_cu_text_offset): Likewise.
13370         (init_one_comp_unit): Assign dwarf2_per_objfile instead of
13371         objfile.
13372         (set_die_type): Access objfile through
13373         dwarf2_per_objfile.
13374
13375 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
13376
13377         * valprint.c (converted_character_d): Remove typedef.
13378         (DEF_VEC_O (converted_character_d)): Remove.
13379         (count_next_character): Use std::vector.
13380         (print_converted_chars_to_obstack): Likewise.
13381         (generic_printstr): Likewise.
13382
13383 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
13384
13385         * xml-support.h (struct gdb_xml_value): Add constructor.
13386         <value>: Change type to unique_xmalloc_ptr.
13387         (gdb_xml_value_s): Remove typedef.
13388         (DEF_VEC_O (gdb_xml_value_s)): Remove.
13389         (gdb_xml_element_start_handler): Change parameter type to
13390         std::vector.
13391         (xml_find_attribute): Likewise.
13392         * xml-support.c (xml_find_attribute): Change parameter type to
13393         std::vector and adjust.
13394         (gdb_xml_values_cleanup): Remove.
13395         (gdb_xml_parser::start_element): Adjust to std::vector.
13396         (xinclude_start_include): Change paraeter type to std::vector
13397         and adjust.
13398         * btrace.c (check_xml_btrace_version): Likewise.
13399         (parse_xml_btrace_block): Likewise.
13400         (parse_xml_btrace_pt_config_cpu): Likewise.
13401         (parse_xml_btrace_pt): Likewise.
13402         (parse_xml_btrace_conf_bts): Likewise.
13403         (parse_xml_btrace_conf_pt): Likewise.
13404         * memory-map.c (memory_map_start_memory): Likewise.
13405         (memory_map_start_property): Likewise.
13406         * osdata.c (osdata_start_osdata): Likewise.
13407         (osdata_start_item): Likewise.
13408         (osdata_start_column): Likewise.
13409         * remote.c (start_thread): Likewise.
13410         * solib-aix.c (library_list_start_library): Likewise.
13411         (library_list_start_list): Likewise.
13412         * solib-svr4.c (library_list_start_library): Likewise.
13413         (svr4_library_list_start_list): Likewise.
13414         * solib-target.c (library_list_start_segment): Likewise.
13415         (library_list_start_section): Likewise.
13416         (library_list_start_library): Likewise.
13417         (library_list_start_list): Likewise.
13418         * tracepoint.c (traceframe_info_start_memory): Likewise.
13419         (traceframe_info_start_tvar): Likewise.
13420         * xml-syscall.c (syscall_start_syscall): Likewise.
13421         * xml-tdesc.c (tdesc_start_target): Likewise.
13422         (tdesc_start_feature): Likewise.
13423         (tdesc_start_reg): Likewise.
13424         (tdesc_start_union): Likewise.
13425         (tdesc_start_struct): Likewise.
13426         (tdesc_start_flags): Likewise.
13427         (tdesc_start_enum): Likewise.
13428         (tdesc_start_field): Likewise.
13429         (tdesc_start_enum_value): Likewise.
13430         (tdesc_start_vector): Likewise.
13431
13432 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
13433
13434         * extension.h (struct xmethod_worker) <clone>: Remove.
13435         * python/py-xmethods.c (struct python_xmethod_worker) <clone>:
13436         Remove.
13437         (python_xmethod_worker::clone): Remove.
13438         * valops.c (find_overload_match): Use std::move instead of
13439         clone.
13440
13441 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
13442
13443         * extension-priv.h (enum ext_lang_rc): Remove, move to extension.h.
13444         (struct extension_language_ops) <clone_xmethod_worker_data>: Remove.
13445         <free_xmethod_worker_data>: Remove.
13446         <get_matching_xmethod_workers>: Chance VEC to std::vector.
13447         <get_xmethod_arg_types>: Remove.
13448         <get_xmethod_result_type>: Remove.
13449         <invoke_xmethod>: Remove.
13450         * extension.c (new_xmethod_worker): Remove.
13451         (clone_xmethod_worker): Remove.
13452         (get_matching_xmethod_workers): Return void, pass std::vector by
13453         pointer.
13454         (get_xmethod_arg_types): Rename to...
13455         (xmethod_worker::get_arg_types): ... this, and adjust.
13456         (get_xmethod_result_type): Rename to...
13457         (xmethod_worker::get_result_type): ... this, and adjust.
13458         (invoke_xmethod): Remove.
13459         (free_xmethod_worker): Remove.
13460         (free_xmethod_worker_vec): Remove.
13461         * extension.h (enum ext_lang_rc): Move here from
13462         extension-priv.h.
13463         (struct xmethod_worker): Add constructor and destructor.
13464         <data>: Remove.
13465         <value>: Remove.
13466         <invoke, clone, do_get_result_type, do_get_arg_types>: New
13467         virtual pure methods.
13468         <get_arg_types, get_result_type>: New methods.
13469         (xmethod_worker_ptr): Remove typedef.
13470         (DEF_VEC_P (xmethod_worker_ptr)): Remove.
13471         (xmethod_worker_vec): Remove typedef.
13472         (xmethod_worker_up): New typedef.
13473         (invoke_xmethod): Remove.
13474         (clone_xmethod_worker): Remove.
13475         (free_xmethod_worker): Remove.
13476         (free_xmethod_worker_vec): Remove.
13477         (get_xmethod_arg_types): Remove.
13478         (get_xmethod_result_type): Remove.
13479         * valops.c (find_method_list): Use std::vector, don't use
13480         intermediate vector.
13481         (value_find_oload_method_list): Use std::vector.
13482         (find_overload_match): Use std::vector.
13483         (find_oload_champ): Use std::vector.
13484         * value.c (value_free): Use operator delete.
13485         (value_of_xmethod): Rename to...
13486         (value_from_xmethod): ... this.  Don't assign
13487         xmethod_worker::value, take rvalue-reference.
13488         (result_type_of_xmethod): Adjust.
13489         (call_xmethod): Adjust.
13490         * value.h: Include extension.h.
13491         (struct xmethod_worker): Don't forward-declare.
13492         (value_of_xmethod): Rename to...
13493         (value_from_xmethod): ... this, take rvalue-reference.
13494         * python/py-xmethods.c (struct gdbpy_worker_data): Rename to...
13495         (struct python_xmethod_worker): ... this, add constructor and
13496         destructor.
13497         <invoke, clone, do_get_arg_types, do_get_result_type>: Implement.
13498         (gdbpy_free_xmethod_worker_data): Rename to...
13499         (python_xmethod_worker::~python_xmethod_worker): ... this and
13500         adjust.
13501         (gdbpy_clone_xmethod_worker_data): Rename to...
13502         (python_xmethod_worker::clone): ... this and adjust.
13503         (gdbpy_get_matching_xmethod_workers): Use std::vector, don't use
13504         temporary vector.
13505         (gdbpy_get_xmethod_arg_types): Rename to...
13506         (python_xmethod_worker::do_get_arg_types): ... this and adjust.
13507         (gdbpy_get_xmethod_result_type): Rename to...
13508         (python_xmethod_worker::do_get_result_type): ... this and
13509         adjust.
13510         (gdbpy_invoke_xmethod): Rename to...
13511         (python_xmethod_worker::invoke): ... this and adjust.
13512         (new_python_xmethod_worker): Rename to...
13513         (python_xmethod_worker::python_xmethod_worker): ... this and
13514         adjust.
13515         * python/python-internal.h (gdbpy_clone_xmethod_worker_data):
13516         Remove.
13517         (gdbpy_free_xmethod_worker_data): Remove.
13518         (gdbpy_get_matching_xmethod_workers): Use std::vector.
13519         (gdbpy_get_xmethod_arg_types): Remove.
13520         (gdbpy_get_xmethod_result_type): Remove.
13521         (gdbpy_invoke_xmethod): Remove.
13522         * python/python.c (python_extension_ops): Remove obsolete
13523         callbacks.
13524
13525 2018-01-05  Pedro Alves  <palves@redhat.com>
13526
13527         PR gdb/18653
13528         * common/signals-state-save-restore.c
13529         (save_original_signals_state): New parameter 'quiet'.  Warn if we
13530         find a custom handler preinstalled, instead of internal erroring.
13531         But only warn if !quiet.
13532         * common/signals-state-save-restore.h
13533         (save_original_signals_state): New parameter 'quiet'.
13534         * main.c (captured_main_1): Move save_original_signals_state call
13535         after option handling, and pass QUIET.
13536
13537 2018-01-05  Pedro Alves  <palves@redhat.com>
13538
13539         * spu-tdep.c (spu_catch_start): Pass
13540         symbol_name_match_type::SEARCH_NAME to block_lookup_symbol.
13541
13542 2018-01-05  Pedro Alves  <palves@redhat.com>
13543
13544         PR gdb/22670
13545         * ada-lang.c (literal_symbol_name_matcher): New function.
13546         (ada_get_symbol_name_matcher): Use it for
13547         symbol_name_match_type::SEARCH_NAME.
13548         * block.c (block_lookup_symbol): New parameter 'match_type'.  Pass
13549         it down instead of assuming symbol_name_match_type::FULL.
13550         * block.h (block_lookup_symbol): New parameter 'match_type'.
13551         * c-valprint.c (print_unpacked_pointer): Use
13552         lookup_symbol_search_name instead of lookup_symbol.
13553         * compile/compile-object-load.c (get_out_value_type): Pass down
13554         symbol_name_match_type::SEARCH_NAME.
13555         * cp-namespace.c (cp_basic_lookup_symbol): Pass down
13556         symbol_name_match_type::FULL.
13557         * cp-support.c (cp_get_symbol_name_matcher): Handle
13558         symbol_name_match_type::SEARCH_NAME.
13559         * infrun.c (insert_exception_resume_breakpoint): Use
13560         lookup_symbol_search_name.
13561         * p-valprint.c (pascal_val_print): Use lookup_symbol_search_name.
13562         * psymtab.c (maintenance_check_psymtabs): Use
13563         symbol_name_match_type::SEARCH_NAME and SYMBOL_SEARCH_NAME.
13564         * stack.c (print_frame_args): Use lookup_symbol_search_name and
13565         SYMBOL_SEARCH_NAME.
13566         * symtab.c (lookup_local_symbol): Don't demangle the lookup name
13567         if symbol_name_match_type::SEARCH_NAME.
13568         (lookup_symbol_in_language): Pass down
13569         symbol_name_match_type::FULL.
13570         (lookup_symbol_search_name): New.
13571         (lookup_language_this): Pass down
13572         symbol_name_match_type::SEARCH_NAME.
13573         (lookup_symbol_aux, lookup_local_symbol): New parameter
13574         'match_type'.  Pass it down.
13575         * symtab.h (symbol_name_match_type::SEARCH_NAME): New enumerator.
13576         (lookup_symbol_search_name): New declaration.
13577         (lookup_symbol_in_block): New 'match_type' parameter.
13578
13579 2018-01-05  Pedro Alves  <palves@redhat.com>
13580
13581         PR gdb/22670
13582         * ada-lang.c (ada_lookup_encoded_symbol): Reimplement in terms of
13583         ada_lookup_symbol.
13584         (ada_lookup_symbol): Reimplement in terms of
13585         ada_lookup_symbol_list, bits factored out from
13586         ada_lookup_encoded_symbol.
13587
13588 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
13589
13590         * ada-exp.y (write_object_renaming): When subscripting an array
13591         using a symbol as the index, pass the block in call to
13592         ada_lookup_encoded_symbol when looking that symbol up.
13593
13594 2018-01-05  Jerome Guitton  <guitton@adacore.com>
13595
13596         * ada-lang.c (ada_array_length): Use ada_index_type instead of
13597         TYPE_INDEX_TYPE.
13598
13599 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
13600
13601         * ada-lang.c (ada_to_fixed_value_create): Add handling of
13602         the case where VALUE_LVAL (val0) is not lval_memory.
13603
13604 2018-01-05  Xavier Roirand  <roirand@adacore.com>
13605
13606         * ada-valprint.c (print_optional_low_bound): Handle
13607         character-indexed array printing like boolean-indexed array
13608         printing.
13609
13610 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
13611
13612         * NEWS: Create a new section for the next release branch.
13613         Rename the section of the current branch, now that it has
13614         been cut.
13615
13616 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
13617
13618         GDB 8.1 branch created (5219ac6237c272b938c28517bf371429260c71e7):
13619         * version.in: Bump version to 8.1.50.DATE-git.
13620
13621 2018-01-03  Xavier Roirand  <roirand@adacore.com>
13622
13623         * ada-lang.h (ada_exception_catchpoint_kind) <ada_catch_handlers>:
13624         Add field.
13625         * ada-lang.c (struct exception_support_info) <catch_handlers_sym>:
13626         Add field.
13627         (default_exception_support_info) <catch_handlers_sym>: Add field.
13628         (exception_support_info_fallback) <catch_handlers_sym>: Add field.
13629         (ada_exception_name_addr_1): Add "catch handlers" handling.
13630         (ada_exception_catchpoint_cond_string) <ex>: New parameter.
13631         Update all callers.
13632         (create_excep_cond_exprs) <ex>: Add parameter.
13633         (re_set_exception): Update create_excep_cond_exprs call.
13634         (print_it_exception, print_one_exception, print_mention_exception)
13635         (print_recreate_exception): Add "catch handler" handling.
13636         (allocate_location_catch_handlers, re_set_catch_handlers)
13637         (check_status_catch_handlers, print_it_catch_handlers)
13638         (print_one_catch_handlers, print_mention_catch_handlers)
13639         (print_recreate_catch_handlers): New function.
13640         (catch_handlers_breakpoint_ops): New variable.
13641         (catch_ada_exception_command_split) <is_catch_handlers_cmd>:
13642         Add parameter.  Add "catch handler" handling.
13643         (ada_exception_sym_name, ada_exception_breakpoint_ops):
13644         Add "catch handler" handling.
13645         (ada_exception_catchpoint_cond_string): Add "catch handler"
13646         handling.
13647         (create_ada_exception_catchpoint): Update create_excep_cond_exprs
13648         call.
13649         (catch_ada_handlers_command): New function.
13650         (initialize_ada_catchpoint_ops): Initialize "catch handlers"
13651         operations structure.
13652         (_initialize_ada_language): Add "catch handlers" command entry.
13653         * NEWS: Document "catch handlers" feature.
13654
13655 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
13656
13657         * ada-lang.c (ada_value_slice_from_ptr): Take array stride into
13658         account when creating the array type of the slice.
13659         (ada_value_slice): Likewise.
13660
13661 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
13662
13663         * gdbtypes.h (enum dynamic_prop_node_kind) <DYN_PROP_BYTE_STRIDE>:
13664         New enum value.
13665         (create_array_type_with_stride): Add byte_stride_prop parameter.
13666         * gdbtypes.c (create_array_type_with_stride) <byte_stride_prop>:
13667         New parameter.  Update all callers in this file.
13668         (array_type_has_dynamic_stride): New function.
13669         (is_dynamic_type_internal, resolve_dynamic_array): Add handling
13670         of arrays with dynamic byte strides.
13671         * dwarf2read.c (read_array_type): Add support for dynamic
13672         DW_AT_byte_stride attributes.
13673
13674 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
13675
13676         * dwarf2read.c (read_unspecified_type): Treat
13677         DW_TAG_enumeration_type DIEs from Ada units as stubs.
13678
13679 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
13680
13681         Update copyright year range in all GDB files.
13682
13683 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
13684
13685         * copyright.py (BY_HAND): Remove gdb/testsuite/gdb.base/step-line.inp
13686         and gdb/testsuite/gdb.base/step-line.c.
13687
13688 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
13689
13690         * copyright.py (main): Dump the contents of
13691         MULTIPLE_COPYRIGHT_HEADERS (separately) from BY_HAND,
13692         even if BY_HAND is empty.
13693
13694 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
13695
13696         * top.c (print_gdb_version): Update Copyright year in version
13697         message.
13698
13699 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
13700
13701         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2017.
13702
13703 For older changes see ChangeLog-2017.
13704 \f
13705 Local Variables:
13706 mode: change-log
13707 left-margin: 8
13708 fill-column: 74
13709 version-control: never
13710 coding: utf-8
13711 End: