gdb/ChangeLog

   1 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
   2
   3         * ada-valprint.c (ada_val_print_gnat_array): Remove language
   4         parameter and use Ada language definition instead.
   5         (ada_val_print_ptr): Remove unused language parameter.
   6         (ada_val_print_num): Remove language parameter and use Ada language
   7         definition instead.
   8         (ada_val_print_enum, ada_val_print_flt): Remove unused language
   9         parameter.
  10         (ada_val_print_struct_union, ada_val_print_ref): Remove language
  11         parameter and use Ada language definition instead.
  12         (ada_val_print_1): Update all ada_val_print_xxx calls.
  13         Remove language parameter.
  14         (ada_val_print): Update ada_val_print_1 call.
  15
  16 2019-05-08  Tom Tromey  <tromey@adacore.com>
  17
  18         * remote.c (remote_hw_watchpoint_limit)
  19         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
  20         Now static.
  21
  22 2019-05-08  Tom Tromey  <tromey@adacore.com>
  23
  24         * maint.c (_initialize_maint_cmds): Move initialization code to
  25         remote.c.
  26         (watchdog, show_watchdog): Move to remote.c.
  27         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
  28         "watchdog" static.
  29         (_initialize_remote): Move initialization code from maint.c.
  30         * defs.h (watchdog): Don't declare.
  31
  32 2019-05-08  Tom Tromey  <tromey@adacore.com>
  33
  34         * tui/tui-interp.c: Include main.h.
  35         * interps.c: Include main.h.
  36         * main.h (interpreter_p): Declare.
  37         * defs.h (interpreter_p): Don't declare.
  38
  39 2019-05-08  Tom Tromey  <tromey@adacore.com>
  40
  41         * dwarf2loc.c: Include dwarf2read.h.
  42         * defs.h (read_unsigned_leb128): Don't declare.
  43         * dwarf2read.h (read_unsigned_leb128): Declare.
  44
  45 2019-05-08  Tom Tromey  <tromey@adacore.com>
  46
  47         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
  48         method.
  49
  50 2019-05-08  Tom Tromey  <tromey@adacore.com>
  51
  52         * utils.c (fputs_maybe_filtered): Reset style after paging, even
  53         when no wrap column is set.
  54
  55 2019-05-08  Tom Tromey  <tromey@adacore.com>
  56
  57         * c-lang.c (c_get_string): Handle non-C-style arrays.
  58
  59 2019-05-08  Tom Tromey  <tromey@adacore.com>
  60
  61         * typeprint.c (print_offset_data::update): Print the bit offset,
  62         not the number of bits remaining.
  63
  64 2019-05-08  Tom Tromey  <tromey@adacore.com>
  65
  66         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
  67         padding at end of comment.
  68
  69 2019-05-08  Tom Tromey  <tromey@adacore.com>
  70
  71         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
  72         Compare main types.
  73
  74 2019-05-06  Tom Tromey  <tom@tromey.com>
  75
  76         * common/scoped_mmap.c: Include common-defs.h.
  77         * common/scoped_mmap.h: Don't include config.h.
  78
  79 2019-05-04  Tom Tromey  <tom@tromey.com>
  80
  81         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
  82         (struct aarch64_call_info): Add initializers.
  83         <si>: Now a std::vector.
  84         (pass_on_stack, aarch64_push_dummy_call): Update.
  85
  86 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
  87             Tom Tromey  <tom@tromey.com>
  88
  89         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
  90         (ppc_threads): Now a std::vector.  Now static.
  91         (hwdebug_find_thread_points_by_tid)
  92         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
  93         Update.
  94
  95 2019-05-04  Tom Tromey  <tom@tromey.com>
  96
  97         * arc-tdep.c (arc_tdesc_init): Return bool.
  98
  99 2019-05-04  Tom Tromey  <tom@tromey.com>
 100
 101         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
 102         Use gdb_assert_not_reached.
 103
 104 2019-05-04  Tom Tromey  <tom@tromey.com>
 105
 106         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
 107         "false".
 108
 109 2019-05-04  Tom Tromey  <tom@tromey.com>
 110
 111         * arc-tdep.c (arc_tdesc_init): Use bool.
 112
 113 2019-05-04  Tom Tromey  <tom@tromey.com>
 114
 115         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
 116
 117 2019-05-04  Tom Tromey  <tom@tromey.com>
 118
 119         * cli/cli-cmds.c (valid_command_p): Return bool.
 120
 121 2019-05-04  Tom Tromey  <tom@tromey.com>
 122
 123         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
 124         * command.h (valid_user_defined_cmd_name_p): Channge return type.
 125
 126 2019-05-04  Raul Tambre  <raul@tambre.ee>
 127
 128         * python/lib/gdb/prompt.py (_ExtendedPrompt)
 129         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
 130         operator for comparison.
 131
 132 2019-05-04  Tom Tromey  <tom@tromey.com>
 133
 134         * psymtab.c (psymbol_name_matches, match_partial_symbol)
 135         (lookup_partial_symbol, print_partial_symbols)
 136         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
 137         (psymbol_compare): Update.
 138         (add_psymbol_to_bcache): Clear the entire psymbol.
 139         (maintenance_check_psymtabs): Update.
 140         * psympriv.h (struct partial_symbol): Don't derive from
 141         general_symbol_info.
 142         <obj_section, unrelocated_address, address,
 143         set_unrelocated_address>: Update.
 144         <ginfo>: New member.
 145         * dwarf-index-write.c (write_psymbols, debug_names::insert)
 146         (debug_names::write_psymbols): Update.
 147
 148 2019-05-04  Tom de Vries  <tdevries@suse.de>
 149
 150         * contrib/cc-with-tweaks.sh: Support -n arg.
 151
 152 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 153
 154         * corelow.c (core_target::detach): Ensure frame cache and
 155         register caches are cleared.
 156         inferior.c (exit_inferior_1): Likewise.
 157
 158 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
 159             Tom Tromey  <tom@tromey.com>
 160
 161         * dictionary.c (collate_pending_symbols_by_language): Remove
 162         "struct" from foreach.
 163         * symtab.c (lookup_global_symbol_from_objfile)
 164         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
 165         foreach.
 166         * ser-tcp.c (net_open): Remove "struct" from foreach.
 167         * objfiles.c (objfile_relocate, objfile_rebase)
 168         (objfile_has_symbols): Remove "struct" from foreach.
 169         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
 170         from foreach.
 171         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
 172         foreach.
 173         * darwin-nat.c (thread_info_from_private_thread_info): Remove
 174         "struct" from foreach.
 175         * ada-lang.c (create_excep_cond_exprs)
 176         (ada_exception_catchpoint_cond_string): Remove "struct" from
 177         foreach.
 178
 179 2019-05-03  Tom Tromey  <tromey@adacore.com>
 180
 181         * ada-exp.y (convert_char_literal): Check suffix of each
 182         enumerator.
 183
 184 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
 185
 186         PR ada/21406:
 187         * ada-exp.y (yywrap): Don't define.
 188         * ada-lex.l (%option): Add noyywrap
 189         (yywrap): Remove.
 190
 191 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
 192
 193         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
 194         _WIN32_WINNT to the XP level, unless already defined to a higher
 195         level.
 196
 197         * unittests/parse-connection-spec-selftests.c:
 198         * ser-tcp.c:
 199         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
 200         override.
 201
 202         * symfile.c (find_separate_debug_file): Remove colon from the
 203         drive spec of DOS/Windows file names of the target, so that the
 204         file name produced from DEBUGDIR and the target's directory will
 205         be valid on DOS/Windows systems.
 206
 207 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 208
 209         * rust-lang.c (val_print_struct): Handle printing structures
 210         containing strings.
 211
 212 2019-05-02  Tom Tromey  <tromey@adacore.com>
 213
 214         * valarith.c (_initialize_valarith): Remove.
 215
 216 2019-05-01  Tom Tromey  <tromey@adacore.com>
 217
 218         * ada-lang.c (ada_value_primitive_field): Treat more fields as
 219         bitfields.
 220
 221 2019-05-01  Tom Tromey  <tromey@adacore.com>
 222
 223         * ada-lang.c (ada_value_assign): Correctly compute starting offset
 224         for big-endian copies.
 225
 226 2019-04-30  Ali Tamur  <tamur@google.com>
 227         * gdb/dwarf2read.c (read_3_bytes): New declaration.
 228         (read_attribute_value): Added DW_FORM_strx1-4 cases.
 229         (read_3_bytes): New function.
 230
 231 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 232
 233         * windows-nat.c (main_thread_id): Delete.
 234         (handle_output_debug_string): Replace main_thread_id by
 235         current_event.dwThreadId.
 236         (fake_create_process): Likewise.
 237         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
 238         Do not set main_thread_id.
 239         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
 240         current_event.dwThreadId.
 241         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
 242
 243 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 244
 245         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
 246         Use current_event.dwThreadId instead of main_thread_id.
 247
 248 2019-04-30  Tom Tromey  <tromey@adacore.com>
 249
 250         * ada-lang.c (ada_lookup_simple_minsyms): New function.
 251         (create_excep_cond_exprs): Iterate over program spaces.
 252         (ada_exception_catchpoint_cond_string): Examine all minimal
 253         symbols for exception types.
 254
 255 2019-04-30  Tom Tromey  <tromey@adacore.com>
 256
 257         PR c++/24470:
 258         * dwarf2read.c (process_structure_scope): Handle case where type
 259         has template parameters but no symbol was created.
 260
 261 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 262             Chris January  <chris.january@arm.com>
 263
 264         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
 265         qualifier.
 266         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
 267
 268 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 269
 270         * f-typeprint.c (f_print_type): Update rules for printing
 271         whitespace.
 272         (f_type_print_varspec_suffix): Likewise.
 273
 274 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 275             Chris January  <chris.january@arm.com>
 276
 277         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 278         function arguments.
 279
 280 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 281
 282         * f-lang.c (build_fortran_types): Change name of void type to
 283         lower case.
 284         * f-typeprint.c (f_type_print_base): Print the name of the void
 285         type, rather than a fixed string.
 286         * f-valprint.c (f_decorations): Use lower case void string.
 287
 288 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 289             Chris January  <chris.january@arm.com>
 290
 291         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 292         types for Fortran.
 293
 294 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 295             Chris January  <chris.january@arm.com>
 296             David Lecomber  <david.lecomber@arm.com>
 297
 298         * f-exp.y (BINOP_INTRINSIC): New token.
 299         (exp): New parser rule handling BINOP_INTRINSIC.
 300         (f77_keywords): Add new builtin procedures.
 301         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 302         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 303         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 304         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 305         (print_unop_subexp_f): New function.
 306         (print_binop_subexp_f): New function.
 307         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 308         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 309         (dump_subexp_body_f): Likewise.
 310         (operator_check_f): Likewise.
 311         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 312         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 313
 314 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 315
 316         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 317         UNOP_KIND.
 318         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 319         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 320         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 321         (operator_length_f): New fuction.
 322         (print_subexp_f): New function.
 323         (op_name_f): New function.
 324         (dump_subexp_body_f): New function.
 325         (operator_check_f): New function.
 326         (exp_descriptor_f): Replace standard expression handling functions
 327         with new functions.
 328         * gdb/fortran-operator.def: New file.
 329         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 330         * gdb/std-operator.def: Remove UNOP_KIND.
 331
 332 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 333
 334         * std-operator.def: Remove unbalanced, stray double quote
 335         character.
 336
 337 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 338             Chris January  <chris.january@arm.com>
 339             Daniel Everett  <daniel.everett@arm.com>
 340             Nick Forrington  <nick.forrington@arm.com>
 341             Richard Bunt  <richard.bunt@arm.com>
 342
 343         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 344         of depth when printing anonymous structs or unions.
 345         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 346         Don't print either the top-level value, or the children if the
 347         max-depth is exceeded.
 348         (ppscm_print_children): When printing the key of a map, allow one
 349         extra level of depth.
 350         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 351         print either the top-level value, or the children if the max-depth
 352         is exceeded.
 353         (print_children): When printing the key of a map, allow one extra
 354         level of depth.
 355         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 356         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 357         (user_print_options): Initialise max_depth field.
 358         (val_print_scalar_or_string_type_p): New function.
 359         (val_print): Check to see if the max depth has been reached.
 360         (val_print_check_max_depth): Define new function.
 361         (show_print_max_depth): New function.
 362         (_initialize_valprint): Add 'print max-depth' option.
 363         * valprint.h (struct value_print_options) <max_depth>: New field.
 364         (val_print_check_max_depth): Declare new function.
 365         * NEWS: Document new feature.
 366
 367 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 368
 369         * ada-lang.c (ada_language_defn): Initialise new field.
 370         * c-lang.c (c_is_string_type_p): New function.
 371         (c_language_defn): Initialise new field.
 372         (cplus_language_defn): Initialise new field.
 373         (asm_language_defn): Initialise new field.
 374         (minimal_language_defn): Initialise new field.
 375         * c-lang.h (c_is_string_type_p): Declare new function.
 376         * d-lang.c (d_language_defn): Initialise new field.
 377         * f-lang.c (f_is_string_type_p): New function.
 378         (f_language_defn): Initialise new field.
 379         * go-lang.c (go_is_string_type_p): New function.
 380         (go_language_defn): Initialise new field.
 381         * language.c (default_is_string_type_p): New function.
 382         (unknown_language_defn): Initialise new field.
 383         (auto_language_defn): Initialise new field.
 384         * language.h (struct language_defn) <la_is_string_type_p>: New
 385         member variable.
 386         (default_is_string_type_p): Declare new function.
 387         * m2-lang.c (m2_language_defn): Initialise new field.
 388         * objc-lang.c (objc_language_defn): Initialise new field.
 389         * opencl-lang.c (opencl_language_defn): Initialise new field.
 390         * p-lang.c (pascal_is_string_type_p): New function.
 391         (pascal_language_defn): Initialise new field.
 392         * rust-lang.c (rust_is_string_type_p): New function.
 393         (rust_language_defn): Initialise new field.
 394
 395 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 396
 397         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 398         New field.
 399         * ada-lang.c (ada_language_defn): Initialise new field.
 400         * c-lang.c (c_language_defn): Likewise.
 401         (cplus_language_defn): Likewise.
 402         (asm_language_defn): Likewise.
 403         (minimal_language_defn): Likewise.
 404         * d-lang.c (d_language_defn): Likewise.
 405         * f-lang.c (f_language_defn): Likewise.
 406         * go-lang.c (go_language_defn): Likewise.
 407         * language.c (unknown_language_defn): Likewise.
 408         (auto_language_defn): Likewise.
 409         * m2-lang.c (m2_language_defn): Likewise.
 410         * objc-lang.c (objc_language_defn): Likewise.
 411         * opencl-lang.c (opencl_language_defn): Likewise.
 412         * p-lang.c (pascal_language_defn): Likewise.
 413         * rust-lang.c (rust_language_defn): Likewise.
 414
 415 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 416
 417         * ada-lang.c (ada_is_character_type): Change return type to bool.
 418         (ada_is_string_type): Likewise.
 419         * ada-lang.h (ada_is_character_type): Update declaration
 420         (ada_is_string_type): Likewise.
 421
 422 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 423
 424         Support style in 'frame|thread apply'
 425
 426         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 427         * record.c (record_start, record_stop): Update callers of
 428         execute_command_to_string with false.
 429         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 430         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 431         methods.
 432         (class string_file): New constructor with term_out parameter.
 433         Override methods term_out and can_emit_style_escape.  New member
 434         term_out.
 435         (class stdio_file): Override can_emit_style_escape.
 436         (class tee_file): Override term_out and can_emit_style_escape.
 437         * utils.h (can_emit_style_escape): Remove.
 438         * utils.c (can_emit_style_escape): Likewise.
 439         Update all callers of can_emit_style_escape (SOMESTREAM) to
 440         SOMESTREAM->can_emit_style_escape.
 441         * source-cache.c (source_cache::get_source_lines): Likewise.
 442         * stack.c (frame_apply_command_count): Call execute_command_to_string
 443         passing the term_out characteristic of the current gdb_stdout.
 444         * thread.c (thr_try_catch_cmd): Likewise.
 445         * top.c (execute_command_to_string): pass term_out parameter
 446         to construct the string_file for the command output.
 447         * ui-file.c (term_cli_styling): New function (most code moved
 448         from utils.c can_emit_style_escape).
 449         (string_file::string_file, string_file::can_emit_style_escape,
 450         stdio_file::can_emit_style_escape, tee_file::term_out,
 451         tee_file::can_emit_style_escape): New functions.
 452
 453 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 454
 455         * NEWS: Mention the new set|show may-call-functions.
 456         * infcall.c (may_call_functions_p): New variable.
 457         (show_may_call_functions_p): New function.
 458         (call_function_by_hand_dummy): Throws an error if not
 459         may-call-functions.
 460         (_initialize_infcall): Call add_setshow_boolean_cmd for
 461         may-call-functions.
 462
 463 2019-04-25  Keith Seitz  <keiths@redhat.com>
 464
 465         PR c++/24367
 466         * cp-support.c (inspect_type): Don't attempt substitutions
 467         of symbol with the same name.
 468
 469 2019-04-25  Tom Tromey  <tromey@adacore.com>
 470
 471         PR gdb/24475:
 472         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 473         static.
 474
 475 2019-04-25  Tom Tromey  <tromey@adacore.com>
 476
 477         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
 478         rvalue reference.
 479         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
 480         (gdb_xml_parser::parse): Use std::move.
 481         * python/python-internal.h (gdbpy_convert_exception): Take a const
 482         reference.
 483         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
 484         std::move.
 485         * python/py-utils.c (gdbpy_convert_exception): Take a const
 486         reference.
 487         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 488         Use std::move.
 489         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 490         Use std::move.
 491         * mi/mi-main.c (mi_print_exception): Take a const reference.
 492         * main.c (handle_command_errors): Take a const reference.
 493         * linespec.c (parse_linespec): Use std::move.
 494         * infcall.c (run_inferior_call): Use std::move.
 495         (call_function_by_hand_dummy): Use std::move.
 496         * exec.c (try_open_exec_file): Use std::move.
 497         * exceptions.h (exception_print, exception_fprintf)
 498         (exception_print_same): Update.
 499         * exceptions.c (print_exception, exception_print)
 500         (exception_fprintf, exception_print_same): Change parameters to
 501         const reference.
 502         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
 503         * common/new-op.c: Use std::move.
 504         * common/common-exceptions.h (struct gdb_exception): Add move
 505         constructor.
 506         (struct gdb_exception_error, struct gdb_exception_quit, struct
 507         gdb_quit_bad_alloc): Change constructor to move constructor.
 508         (throw_exception): Change parameter to rvalue reference.
 509         * common/common-exceptions.c (throw_exception): Take rvalue
 510         reference.
 511         * cli/cli-interp.c (safe_execute_command): Use std::move.
 512         * breakpoint.c (insert_bp_location, location_to_sals): Use
 513         std::move.
 514
 515 2019-04-25  Tom Tromey  <tromey@adacore.com>
 516
 517         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
 518         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
 519         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
 520         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
 521         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
 522         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
 523         guile/scm-value.c: Use unpack.
 524         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
 525         gdbscm_gdb_exception.
 526         (gdbscm_throw_gdb_exception): Likewise.
 527         (struct gdbscm_gdb_exception): New.
 528         (unpack): New function.
 529         (gdbscm_wrap): Use unpack.
 530
 531 2019-04-25  Tom Tromey  <tromey@adacore.com>
 532
 533         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 534         (gdb_rl_callback_handler): Use std::move.
 535         * common/common-exceptions.h (struct gdb_exception): Add move
 536         assignment operator.
 537         (throw_exception_sjlj): Change "exception" to const reference.
 538         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
 539         (throw_exception_sjlj): Change "exception" to const reference.
 540
 541 2019-04-25  Tom Tromey  <tromey@adacore.com>
 542
 543         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
 544         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
 545         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 546         Update.
 547         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 548         Update.
 549         * mi/mi-interp.c (mi_interp::exec): Update.
 550         * linespec.c (parse_linespec): Update.
 551         * infcall.c (run_inferior_call): Update.
 552         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
 553         * guile/scm-symbol.c (gdbscm_lookup_symbol)
 554         (gdbscm_lookup_global_symbol): Update.
 555         * guile/scm-param.c (gdbscm_parameter_value): Update.
 556         * guile/scm-frame.c (gdbscm_frame_read_register)
 557         (gdbscm_frame_read_var): Update.
 558         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
 559         * exec.c (try_open_exec_file): Update.
 560         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 561         (gdb_rl_callback_handler): Update.
 562         * common/common-exceptions.h (exception_none): Don't declare.
 563         * common/common-exceptions.c (exception_none): Don't define.
 564         (struct catcher) <exception>: Update.
 565         * cli/cli-interp.c (safe_execute_command): Update.
 566         * breakpoint.c (insert_bp_location, location_to_sals): Update.
 567
 568 2019-04-25  Ali Tamur  <tamur@google.com>
 569
 570         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
 571         (read_attribute_value): Likewise.
 572         (dwarf2_read_addr_index): Update comment.
 573         (read_str_index): Add DW_FORM_strx.
 574         (dwarf2_string_attr): Likewise.
 575         (dwarf2_const_value_attr): Likewise.
 576         (dump_die_shallow): Likewise.
 577         (dwarf2_fetch_constant_bytes): Likewise.
 578         (skip_form_bytes): Likewise.
 579         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
 580
 581 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
 582
 583         PR corefiles/11608
 584         PR corefiles/18187
 585         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
 586         OFFSET.  Verify if current mapping contains an ELF header.
 587         (linux_find_memory_regions_full): Adjust call to
 588         dump_mapping_p.
 589
 590 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
 591             Kang Li <kanglictf@gmail.com>
 592
 593         PR gdb/21600
 594
 595         * dwarf2-frame.c (read_initial_length): Be consistent about using
 596         unsigned representation of length.
 597         (decode_frame_entry_1): Likewise.  Check for wraparound of
 598         end pointer as well as buffer overflow.
 599
 600 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
 601
 602         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
 603         "vq".
 604
 605 2019-04-24  Tom Tromey  <tromey@adacore.com>
 606
 607         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
 608
 609 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 610
 611         * s12z-tdep.c (s12z_unwind_pc): Delete.
 612         (s12z_unwind_sp): Delete.
 613         (s12z_gdbarch_init): Don't register deleted functions with
 614         gdbarch.
 615
 616 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 617
 618         * rl78-tdep.c (rl78_unwind_sp): Delete.
 619         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
 620
 621 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 622
 623         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
 624         (xstormy16_unwind_pc): Delete.
 625         (xstormy16_dummy_id): Delete.
 626         (xstormy16_gdbarch_init): Don't register deleted functions with
 627         gdbarch.
 628
 629 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 630
 631         * vax-tdep.c (vax_unwind_pc): Delete.
 632         (vax_gdbarch_init): Don't register deleted function with gdbarch.
 633
 634 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 635
 636         * v850-tdep.c (v850_unwind_sp): Delete.
 637         (v850_unwind_pc): Delete.
 638         (v850_dummy_id): Delete.
 639         (v850_gdbarch_init): Don't register deleted functions with
 640         gdbarch.
 641
 642 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 643
 644         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
 645         (tilegx_unwind_pc): Delete.
 646         (tilegx_unwind_dummy_id): Delete.
 647         (tilegx_gdbarch_init): Don't register deleted functions with
 648         gdbarch.
 649
 650 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 651
 652         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
 653         (tic6x_dummy_id): Delete.
 654         (tic6x_gdbarch_init): Don't register deleted functions with
 655         gdbarch.
 656
 657 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 658
 659         * sparc-tdep.c (sparc_unwind_pc): Delete.
 660         (sparc32_gdbarch_init): Don't register deleted function with
 661         gdbarch.
 662
 663 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 664
 665         * sh-tdep.c (sh_unwind_sp): Delete.
 666         (sh_unwind_pc): Delete.
 667         (sh_dummy_id): Delete.
 668         (sh_gdbarch_init): Don't register deleted functions with
 669         gdbarch.
 670
 671 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 672
 673         * score-tdep.c (score_unwind_sp): Delete.
 674         (score_unwind_pc): Delete.
 675         (score_dummy_id): Delete.
 676         (score_gdbarch_init): Don't register deleted functions with
 677         gdbarch.
 678
 679 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 680
 681         * rx-tdep.c (rx_unwind_pc): Delete.
 682         (rx_unwind_sp): Delete.
 683         (rx_dummy_id): Delete.
 684         (rx_gdbarch_init): Don't register deleted functions with
 685         gdbarch.  Update comment.
 686
 687 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 688
 689         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
 690         (rs6000_dummy_id): Delete.
 691         (rs6000_gdbarch_init): Don't register deleted functions with
 692         gdbarch.
 693
 694 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 695
 696         * or1k-tdep.c (or1k_dummy_id): Delete.
 697         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
 698
 699 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 700
 701         * nios2-tdep.c (nios2_dummy_id): Delete.
 702         (nios2_unwind_sp): Delete.
 703         (nios2_gdbarch_init): Don't register deleted functions with
 704         gdbarch.
 705
 706 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 707
 708         * nds32-tdep.c (nds32_dummy_id): Delete.
 709         (nds32_unwind_pc): Delete.
 710         (nds32_unwind_sp): Delete.
 711         (nds32_gdbarch_init): Don't register deleted functions with
 712         gdbarch.
 713
 714 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 715
 716         * msp430-tdep.c (msp430_unwind_pc): Delete.
 717         (msp430_unwind_sp): Delete.
 718         (msp430_dummy_id): Delete.
 719         (msp430_gdbarch_init): Don't register deleted functions with
 720         gdbarch.
 721
 722 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 723
 724         * moxie-tdep.c (moxie_unwind_sp): Delete.
 725         (moxie_unwind_pc): Delete.
 726         (moxie_dummy_id): Delete.
 727         (moxie_gdbarch_init): Don't register deleted functions with
 728         gdbarch.
 729
 730 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 731
 732         * mn10300-tdep.c (mn10300_dummy_id): Delete.
 733         (mn10300_unwind_pc): Delete.
 734         (mn10300_unwind_sp): Delete.
 735         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
 736         mn10300_unwind_sp.
 737         (mn10300_frame_unwind_init): Don't register deleted functions with
 738         gdbarch.
 739
 740 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 741
 742         * mep-tdep.c (mep_unwind_pc): Delete.
 743         (mep_unwind_sp): Delete.
 744         (mep_dummy_id): Delete.
 745         (mep_gdbarch_init): Don't register deleted functions with
 746         gdbarch.
 747
 748 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 749
 750         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
 751         (m68hc11_unwind_sp): Delete.
 752         (m68hc11_gdbarch_init): Don't register deleted functions with
 753         gdbarch.
 754
 755 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 756
 757         * m32r-tdep.c (m32r_unwind_sp): Delete.
 758         (m32r_unwind_pc): Delete.
 759         (m32r_dummy_id): Delete.
 760         (m32r_gdbarch_init): Don't register deleted functions with
 761         gdbarch.
 762
 763 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 764
 765         * m32c-tdep.c (m32c_unwind_pc): Delete.
 766         (m32c_unwind_sp): Delete.
 767         (m32c_dummy_id): Delete.
 768         (m32c_gdbarch_init): Don't register deleted functions with
 769         gdbarch.
 770
 771 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 772
 773         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
 774         (lm32_unwind_pc): Delete.
 775         (lm32_dummy_id): Delete.
 776         (lm32_gdbarch_init): Don't register deleted functions with
 777         gdbarch.
 778
 779 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 780
 781         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
 782         (iq2000_unwind_pc): Delete.
 783         (iq2000_dummy_id): Delete.
 784         (iq2000_gdbarch_init): Don't register deleted functions with
 785         gdbarch.
 786
 787 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 788
 789         * nds32-tdep.c (nds32_type_align): Delete.
 790         (nds32_push_dummy_call): Use type_align instead.
 791
 792 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 793
 794         * arm-tdep.c (arm_type_align): Only handle vector override case.
 795         (arm_push_dummy_call): Use type_align.
 796         (arm_gdbarch_init): Register arm_type_align gdbarch function.
 797
 798 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 799
 800         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
 801         case.
 802         (pass_on_stack): Use type_align.
 803         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
 804         function.
 805
 806 2019-04-23  Tom Tromey  <tromey@adacore.com>
 807
 808         * dwarf2read.c (line_header::file_name_at): Remove unused
 809         overload.
 810
 811 2019-04-23  Tom de Vries  <tdevries@suse.de>
 812
 813         PR gdb/24438
 814         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
 815         invocation.
 816
 817
 818 2019-03-27  Ali Tamur  <tamur@google.com>
 819
 820         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
 821         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
 822         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
 823         (dwarf_expr_context::get_addr_index): Likewise
 824         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
 825         (symbol_needs_eval_context::get_addr_index): Likewise
 826         (disassemble_dwarf_expression): Add DW_OP_addrx
 827         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
 828         (read_cutu_die_from_dwo): Update comment
 829         (skip_one_die): Add DW_FORM_addrx
 830         (read_attribute_value): Likewise
 831         (var_decode_location): Add DW_OP_addrx
 832         (dwarf2_const_value_attr): Add DW_FORM_addrx
 833         (dump_die_shallow): Likewise
 834         (dwarf2_fetch_constant_bytes): Likewise
 835         (decode_locdesc): Add DW_OP_addrx
 836         (skip_form_bytes): Add DW_FORM_addrx
 837
 838 2019-04-22  Ali Tamur  <tamur@google.com>
 839
 840         * MAINTAINERS (Write After Approval): Add self.
 841
 842 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
 843
 844         * solib-svr4.c (get_svr4_info): Add pspace parameter.
 845         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
 846         (open_symbol_file_object): Likewise.
 847         (svr4_default_sos): Add info parameter.
 848         (svr4_read_so_list): Likewise.
 849         (svr4_current_sos_direct): Adjust functions calls to pass down
 850         info.
 851         (svr4_current_sos_1): Add info parameter.
 852         (svr4_current_sos): Call get_svr4_info, pass info down to
 853         svr4_current_sos_1.
 854         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
 855         get_svr4_info.
 856         (svr4_in_dynsym_resolve_code): Pass current_program_space to
 857         get_svr4_info.
 858         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
 859         to get_svr4_info.
 860         (probes_table_remove_objfile_probes): Likewise.
 861         (register_solib_event_probe): Add info parameter.
 862         (solist_update_incremental): Pass info parameter down to
 863         svr4_read_so_list.
 864         (disable_probes_interface): Add info parameter.
 865         (svr4_handle_solib_event): Pass current_program_space to
 866         get_svr4_info.  Adjust disable_probes_interface cleanup.
 867         (svr4_create_probe_breakpoints): Add info parameter, pass it
 868         down to register_solib_event_probe.
 869         (svr4_create_solib_event_breakpoints): Add info parameter,
 870         pass it down to svr4_create_probe_breakpoints.
 871         (enable_break): Pass info down to
 872         svr4_create_solib_event_breakpoints.
 873         (svr4_solib_create_inferior_hook): Pass current_program_space to
 874         get_svr4_info.
 875         (svr4_clear_solib): Likewise.
 876
 877 2019-04-22  Pedro Alves  <palves@redhat.com>
 878
 879         * solib-svr4.c (svr4_free_objfile_observer): New.
 880         (probe_and_action::objfile): New field.
 881         (probes_table_htab_remove_objfile_probes)
 882         (probes_table_remove_objfile_probes): New functions.
 883         (register_solib_event_probe): Add 'objfile' parameter.  Store it
 884         in the new probe_and_action.  Don't store the probe in 'lookup'.
 885         (svr4_create_probe_breakpoints): Pass objfile to
 886         register_solib_event_probe.
 887         (_initialize_svr4_solib): Register a free_objfile observer.
 888
 889 2019-04-19  Tom Tromey  <tom@tromey.com>
 890
 891         * common/queue.h: Remove.
 892
 893 2019-04-19  Tom Tromey  <tom@tromey.com>
 894
 895         * event-loop.c: Don't include "common/queue.h".
 896
 897 2019-04-19  Tom Tromey  <tom@tromey.com>
 898
 899         * remote.c (remote_target): Use delete.
 900         * remote-notif.h: Include <list>, not "common/queue.h".
 901         (notif_client_p): Remove typedef.
 902         (remote_notif_state): Add constructor, destructor, initializer.
 903         <notif_queue>: Now a std::list.
 904         (remote_notif_state_xfree): Don't declare.
 905         * remote-notif.c (remote_notif_process, handle_notification)
 906         (remote_notif_state_allocate): Update.
 907         (~remote_notif_state): Rename from remote_notif_state_xfree.
 908
 909 2019-04-19  Tom Tromey  <tom@tromey.com>
 910
 911         * symfile.c (reread_symbols): Update.
 912         * objfiles.c (objfile_register_static_link)
 913         (objfile_lookup_static_link): Update
 914         (~objfile) Don't delete static_links.
 915         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
 916
 917 2019-04-19  Tom Tromey  <tom@tromey.com>
 918
 919         * type-stack.h (struct type_stack) <insert>: Constify string.
 920         * type-stack.c (type_stack::insert): Constify string.
 921         * gdbtypes.h (lookup_template_type): Update.
 922         (address_space_name_to_int): Update.
 923         * gdbtypes.c (address_space_name_to_int): Make space_identifier
 924         const.
 925         (lookup_template_type): Make name const.
 926         * c-exp.y: Update rules.
 927         (lex_one_token, classify_name, classify_inner_name)
 928         (c_print_token): Update.
 929         * p-exp.y: Update rules.
 930         (yylex): Update.
 931         * f-exp.y: Update rules.
 932         (yylex): Update.
 933         * d-exp.y: Update rules.
 934         (lex_one_token, classify_name, classify_inner_name): Update.
 935         * parse.c (write_dollar_variable, copy_name): Return std::string.
 936         * parser-defs.h (copy_name): Change return type.
 937         * m2-exp.y: Update rules.
 938         (yylex): Update.
 939         * go-exp.y (lex_one_token): Update.
 940         Update rules.
 941         (classify_unsafe_function, classify_packaged_name)
 942         (classify_name, yylex): Update.
 943
 944 2019-04-19  Sergei Trofimovich <siarheit@google.com>
 945
 946         * configure.ac: add --enable-source-highlight switch.
 947         * configure: Regenerate.
 948         * top.c (print_gdb_version): plumb --enable-source-highlight
 949         status to "show configuration".
 950
 951 2019-04-19  Tom Tromey  <tromey@adacore.com>
 952
 953         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
 954         Check ADA_TYPE_P.
 955         (empty_record, ada_template_to_fixed_record_type_1)
 956         (template_to_static_fixed_type)
 957         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
 958         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
 959         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
 960         macros.
 961
 962 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
 963
 964         PR symtab/24423:
 965         * source.c (print_source_lines_base): Advance "iter" when a
 966         control character is seen.
 967
 968 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 969
 970         * inferior.h (struct infcall_suspend_state_deleter):
 971         Catch exception in destructor to avoid crash.
 972
 973 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 974
 975         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
 976         close to the add_com "shell".
 977
 978 2019-04-18  Tom Tromey  <tromey@adacore.com>
 979
 980         * process-stratum-target.h (class process_stratum_target)
 981         <stratum>: Add "final".
 982
 983 2019-04-17  Tom Tromey  <tromey@adacore.com>
 984
 985         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
 986         against nullptr before use.
 987
 988 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
 989
 990         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
 991
 992 2019-04-17  Jim Wilson  <jimw@sifive.com>
 993             Andrew Burgess  <andrew.burgess@embecosm.com>
 994
 995         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
 996         code read might fail, assume 4-byte breakpoint in that case.
 997
 998 2019-04-15  Leszek Swirski  <leszeks@google.com>
 999
1000         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
1001         rather than a hand-rolled POD check when checking for forced MEMORY
1002         classification.
1003
1004 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1005
1006         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
1007         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
1008         function.
1009         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
1010         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
1011         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
1012         declaration.
1013
1014 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1015
1016         * aarch64-linux-nat.c
1017         (aarch64_linux_nat_target::thread_architecture): Add override.
1018         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
1019         each VQ.
1020
1021 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1022
1023         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
1024
1025 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
1026
1027         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
1028         target types of size 96-bits, add some additional comments, and
1029         check that the builtin type we found was the correct size.
1030
1031 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
1032
1033         * utils.c (prompt_for_continue): Don't restore the styling at the
1034         end, as applied_style has the wrong value.  This fixes styling in
1035         long lists of file names that are interrupted by the "Continue?"
1036         prompt.
1037
1038 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1039
1040         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
1041         * c-lang.c (c_language_defn): Likewise.
1042         (cplus_language_defn): Likewise.
1043         (asm_language_defn): Likewise.
1044         (minimal_language_defn): Likewise.
1045         * d-lang.c (d_language_defn): Likewise.
1046         * f-lang.c (f_language_defn): Likewise.
1047         * go-lang.c (go_language_defn): Likewise.
1048         * language.c (unknown_language_defn): Likewise.
1049         (auto_language_defn): Likewise.
1050         * language.h (struct language_defn): Remove la_magic field.
1051         (LANG_MAGIC): Delete.
1052         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
1053         * objc-lang.c (objc_language_defn): Likewise.
1054         * opencl-lang.c (opencl_language_defn): Likewise.
1055         * p-lang.c (pascal_language_defn): Likewise.
1056         * rust-lang.c (rust_language_defn): Likewise.
1057
1058 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1059
1060         * riscv-tdep.c (riscv_type_align): New function.
1061         (riscv_type_alignment): Delete.
1062         (riscv_arg_location): Use 'type_align'.
1063         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
1064
1065 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1066
1067         * gdbtypes.c (type_align): A struct with no non-static fields also
1068         has alignment of 1.
1069
1070 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1071
1072         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
1073         component to 0.
1074         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
1075         member.
1076         (riscv_struct_info::analyse): New implementation using new
1077         analyse_inner member function.
1078         (riscv_struct_info::field_offset): New member function.
1079         (riscv_struct_info::m_offsets): New member variable.
1080         (riscv_struct_info::analyse_inner): New private member function,
1081         takes the old implementation of riscv_struct_info::analyse but
1082         extended to track field offsets.
1083         (riscv_call_arg_struct): Update the struct folding special cases
1084         to handle cases where empty C++ structs, which are non-zero
1085         length, are found.
1086         (riscv_arg_location): Initialise the length of each location, a
1087         non-zero length now indicates the location is in use.
1088         (riscv_push_dummy_call): Allow for the first location having a
1089         non-zero offset when setting up arguments.
1090         (riscv_return_value): Likewise, but for return values.
1091
1092 2019-04-11  Tom Tromey  <tromey@adacore.com>
1093
1094         * utils.c (internal_vproblem): Make "msg" const.
1095
1096 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
1097
1098         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
1099         * trad-frame.c (trad_frame_reset_saved_regs): New function.
1100         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
1101         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
1102
1103 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
1104
1105         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
1106         function.
1107         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1108         of amd64_collect_native_gregset.
1109         (amd64_linux_nat_target::store_registers): Likewise.
1110
1111 2019-04-10  Tom Tromey  <tom@tromey.com>
1112
1113         * symtab.c (lookup_global_symbol_from_objfile)
1114         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1115         * objfiles.h (class separate_debug_iterator): New.
1116         (class separate_debug_range): New.
1117         (struct objfile) <separate_debug_objfiles>: New method.
1118         (objfile_separate_debug_iterate): Don't declare.
1119         * objfiles.c (separate_debug_iterator::operator++): Rename from
1120         objfile_separate_debug_iterate.
1121         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1122         iterator.
1123         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1124         iterator.
1125
1126 2019-04-10  Tom Tromey  <tom@tromey.com>
1127
1128         * symfile.c (reread_symbols): Remove old comment.
1129         * objfiles.c (free_all_objfiles): Fix a typo.
1130
1131 2019-04-10  Tom Tromey  <tom@tromey.com>
1132
1133         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1134         * minsyms.c (lookup_minimal_symbol): Use foreach.
1135         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1136         (lookup_minimal_symbol_solib_trampoline): Likewise.
1137         * symfile.c (reread_symbols): Use foreach.
1138
1139 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1140             Tom Tromey  <tromey@adacore.com>
1141
1142         PR rust/24414:
1143         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1144         (rust_lex_int_test): Change "value" to be LONGEST.
1145         (rust_lex_tests): Add test for long integer literal.
1146
1147 2019-04-09  Tom Tromey  <tromey@adacore.com>
1148
1149         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1150         to bool.
1151         (extended_remote_target::attach): Update.
1152         (remote_target::remote_notice_new_inferior): Update.
1153         (remote_target::add_current_inferior_and_thread): Update.
1154         * inferior.c (exit_inferior_1): Use "false".
1155         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1156
1157 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1158
1159         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1160         the "start" command.
1161
1162 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1163
1164         * python/py-inferior.c (infpy_thread_from_thread_handle):
1165         Adjust comments to reflect renaming of thread_from_thread_handle
1166         to thread_from_handle.  Adjust keywords.  Fix type error message.
1167         (inferior_object_methods): Add thread_from_handle.  Retain
1168         thread_from_thread_handle, but mark it as deprecated.
1169
1170 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1171
1172         * gdbthread.h (find_thread_by_handle): Revise declaration.
1173         * thread.c (find_thread_by_handle): Likewise.  Adjust
1174         implementation too.
1175         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1176         support for buffer objects as handles.
1177
1178 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1179
1180         * python/py-infthread.c (thpy_thread_handle): New function.
1181         (thread_object_methods): Register thpy_thread_handle.
1182
1183 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1184
1185         * gdbthread.h (thread_to_thread_handle): Declare.
1186         * thread.c (gdbtypes.h): Include.
1187         (thread_to_thread_handle): New function.
1188
1189         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1190         (target_thread_info_to_thread_handle): Declare.
1191         * target.c (target_thread_info_to_thread_handle): New function.
1192         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1193         * target-delegates.c: Regenerate.
1194
1195         * linux-thread-db.c (class thread_db_target): Add method
1196         thread_info_to_thread_handle.
1197         (thread_db_target::thread_info_to_thread_handle): Define.
1198         * remote.c (class remote_target): Add new method
1199         thread_info_to_thread_handle.
1200         (remote_target::thread_info_to_thread_handle): Define.
1201
1202 2019-04-08  Pedro Alves  <palves@redhat.com>
1203
1204         * common/common-exceptions.c (throw_exception): Don't create
1205         named object to throw; throw directly.
1206         (throw_it): Likewise.  Don't initialize gdb_exception::message
1207         here, with new; pass FMT and AP to the ctor instead.
1208         * common/common-exceptions.h: Include <string>.
1209         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1210         const char *, va_list)): New ctor.  Use std::make_shared.
1211         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1212         errors)): Delete.
1213         (gdb_exception_error::gdb_exception_error(enum errors, const char
1214         *, va_list)): New.
1215         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1216         Add assertion.
1217         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1218         errors)): Delete.
1219         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1220         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1221         Add assertion.
1222
1223 2019-04-08  Tom Tromey  <tom@tromey.com>
1224
1225         * valops.c (value_rtti_indirect_type): Replace throw_exception
1226         with throw.
1227         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1228         with throw.
1229         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1230         throw.
1231         * target.c (target_translate_tls_address): Replace throw_exception
1232         with throw.
1233         * stack.c (frame_apply_command_count): Replace throw_exception
1234         with throw.
1235         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1236         throw.
1237         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1238         with throw.
1239         * rs6000-tdep.c (rs6000_frame_cache)
1240         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1241         * remote.c: Replace throw_exception with throw.
1242         * record-full.c (record_full_message, record_full_wait_1)
1243         (record_full_restore): Replace throw_exception with throw.
1244         * record-btrace.c:
1245         (get_thread_current_frame_id, record_btrace_start_replaying)
1246         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1247         (cmd_record_btrace_start): Replace throw_exception with throw.
1248         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1249         throw.
1250         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1251         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1252         * linespec.c:
1253         (find_linespec_symbols): Replace throw_exception with throw.
1254         * infrun.c (displaced_step_prepare, resume): Replace
1255         throw_exception with throw.
1256         * infcmd.c (post_create_inferior): Replace throw_exception with
1257         throw.
1258         * inf-loop.c (inferior_event_handler): Replace throw_exception
1259         with throw.
1260         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1261         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1262         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1263         (get_prev_frame_always, get_frame_pc_if_available)
1264         (get_frame_address_in_block_if_available, get_frame_language):
1265         Replace throw_exception with throw.
1266         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1267         throw_exception with throw.
1268         * eval.c (fetch_subexp_value, evaluate_var_value)
1269         (evaluate_funcall, evaluate_subexp_standard): Replace
1270         throw_exception with throw.
1271         * dwarf2loc.c (call_site_find_chain)
1272         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1273         Replace throw_exception with throw.
1274         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1275         with throw.
1276         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1277         throw.
1278         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1279         * completer.c (complete_line_internal): Replace throw_exception
1280         with throw.
1281         * compile/compile-object-run.c (compile_object_run): Replace
1282         throw_exception with throw.
1283         * cli/cli-script.c (process_next_line): Replace throw_exception
1284         with throw.
1285         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1286         (btrace_enable, btrace_maint_update_pt_packets): Replace
1287         throw_exception with throw.
1288         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1289         throw_exception with throw.
1290         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1291         throw_exception with throw.
1292         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1293         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1294         * aarch64-tdep.c (aarch64_make_prologue_cache)
1295         (aarch64_make_stub_cache): Replace throw_exception with throw.
1296
1297 2019-04-08  Tom Tromey  <tom@tromey.com>
1298
1299         * common/common-exceptions.c (throw_exception): Rename from
1300         throw_exception_cxx.  Remove old copy.  Make argument const.
1301         (throw_it): Create and throw exception objects directly.
1302         * common/common-exceptions.h (throw_exception): Make argument
1303         const.
1304         (struct gdb_exception_error): Add constructor.
1305         (struct gdb_exception_quit): Add constructor.
1306
1307 2019-04-08  Tom Tromey  <tom@tromey.com>
1308
1309         * common/common-exceptions.h (exception_rethrow): Don't declare.
1310         (TRY_SJLJ): Update comment.
1311         (TRY, CATCH, END_CATCH): Remove.
1312         * common/common-exceptions.c (exception_rethrow): Remove.
1313
1314 2019-04-08  Tom Tromey  <tom@tromey.com>
1315
1316         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1317         Remove.
1318         (gdb_exception_error): Rename from
1319         gdb_exception_RETURN_MASK_ERROR.
1320         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1321         (gdb_quit_bad_alloc): Update.
1322         * aarch64-tdep.c: Update.
1323         * ada-lang.c: Update.
1324         * ada-typeprint.c: Update.
1325         * ada-valprint.c: Update.
1326         * amd64-tdep.c: Update.
1327         * arch-utils.c: Update.
1328         * break-catch-throw.c: Update.
1329         * breakpoint.c: Update.
1330         * btrace.c: Update.
1331         * c-varobj.c: Update.
1332         * cli/cli-cmds.c: Update.
1333         * cli/cli-interp.c: Update.
1334         * cli/cli-script.c: Update.
1335         * common/common-exceptions.c: Update.
1336         * common/new-op.c: Update.
1337         * common/selftest.c: Update.
1338         * compile/compile-c-symbols.c: Update.
1339         * compile/compile-cplus-symbols.c: Update.
1340         * compile/compile-object-load.c: Update.
1341         * compile/compile-object-run.c: Update.
1342         * completer.c: Update.
1343         * corelow.c: Update.
1344         * cp-abi.c: Update.
1345         * cp-support.c: Update.
1346         * cp-valprint.c: Update.
1347         * darwin-nat.c: Update.
1348         * disasm-selftests.c: Update.
1349         * dtrace-probe.c: Update.
1350         * dwarf-index-cache.c: Update.
1351         * dwarf-index-write.c: Update.
1352         * dwarf2-frame-tailcall.c: Update.
1353         * dwarf2-frame.c: Update.
1354         * dwarf2loc.c: Update.
1355         * dwarf2read.c: Update.
1356         * eval.c: Update.
1357         * event-loop.c: Update.
1358         * event-top.c: Update.
1359         * exec.c: Update.
1360         * f-valprint.c: Update.
1361         * fbsd-tdep.c: Update.
1362         * frame-unwind.c: Update.
1363         * frame.c: Update.
1364         * gdbtypes.c: Update.
1365         * gnu-v3-abi.c: Update.
1366         * guile/guile-internal.h: Update.
1367         * guile/scm-block.c: Update.
1368         * guile/scm-breakpoint.c: Update.
1369         * guile/scm-cmd.c: Update.
1370         * guile/scm-disasm.c: Update.
1371         * guile/scm-frame.c: Update.
1372         * guile/scm-lazy-string.c: Update.
1373         * guile/scm-math.c: Update.
1374         * guile/scm-param.c: Update.
1375         * guile/scm-ports.c: Update.
1376         * guile/scm-pretty-print.c: Update.
1377         * guile/scm-symbol.c: Update.
1378         * guile/scm-symtab.c: Update.
1379         * guile/scm-type.c: Update.
1380         * guile/scm-value.c: Update.
1381         * i386-linux-tdep.c: Update.
1382         * i386-tdep.c: Update.
1383         * inf-loop.c: Update.
1384         * infcall.c: Update.
1385         * infcmd.c: Update.
1386         * infrun.c: Update.
1387         * jit.c: Update.
1388         * language.c: Update.
1389         * linespec.c: Update.
1390         * linux-fork.c: Update.
1391         * linux-nat.c: Update.
1392         * linux-tdep.c: Update.
1393         * linux-thread-db.c: Update.
1394         * main.c: Update.
1395         * mi/mi-cmd-break.c: Update.
1396         * mi/mi-cmd-stack.c: Update.
1397         * mi/mi-interp.c: Update.
1398         * mi/mi-main.c: Update.
1399         * objc-lang.c: Update.
1400         * p-valprint.c: Update.
1401         * parse.c: Update.
1402         * ppc-linux-tdep.c: Update.
1403         * printcmd.c: Update.
1404         * python/py-arch.c: Update.
1405         * python/py-breakpoint.c: Update.
1406         * python/py-cmd.c: Update.
1407         * python/py-finishbreakpoint.c: Update.
1408         * python/py-frame.c: Update.
1409         * python/py-framefilter.c: Update.
1410         * python/py-gdb-readline.c: Update.
1411         * python/py-inferior.c: Update.
1412         * python/py-infthread.c: Update.
1413         * python/py-lazy-string.c: Update.
1414         * python/py-linetable.c: Update.
1415         * python/py-objfile.c: Update.
1416         * python/py-param.c: Update.
1417         * python/py-prettyprint.c: Update.
1418         * python/py-progspace.c: Update.
1419         * python/py-record-btrace.c: Update.
1420         * python/py-record.c: Update.
1421         * python/py-symbol.c: Update.
1422         * python/py-type.c: Update.
1423         * python/py-unwind.c: Update.
1424         * python/py-utils.c: Update.
1425         * python/py-value.c: Update.
1426         * python/python.c: Update.
1427         * record-btrace.c: Update.
1428         * record-full.c: Update.
1429         * remote-fileio.c: Update.
1430         * remote.c: Update.
1431         * riscv-tdep.c: Update.
1432         * rs6000-aix-tdep.c: Update.
1433         * rs6000-tdep.c: Update.
1434         * rust-exp.y: Update.
1435         * rust-lang.c: Update.
1436         * s390-tdep.c: Update.
1437         * selftest-arch.c: Update.
1438         * solib-dsbt.c: Update.
1439         * solib-frv.c: Update.
1440         * solib-spu.c: Update.
1441         * solib-svr4.c: Update.
1442         * solib.c: Update.
1443         * sparc64-linux-tdep.c: Update.
1444         * stack.c: Update.
1445         * symfile-mem.c: Update.
1446         * symmisc.c: Update.
1447         * target.c: Update.
1448         * thread.c: Update.
1449         * top.c: Update.
1450         * tracefile-tfile.c: Update.
1451         * tui/tui.c: Update.
1452         * typeprint.c: Update.
1453         * unittests/cli-utils-selftests.c: Update.
1454         * unittests/parse-connection-spec-selftests.c: Update.
1455         * valops.c: Update.
1456         * valprint.c: Update.
1457         * value.c: Update.
1458         * varobj.c: Update.
1459         * windows-nat.c: Update.
1460         * x86-linux-nat.c: Update.
1461         * xml-support.c: Update.
1462
1463 2019-04-08  Tom Tromey  <tom@tromey.com>
1464
1465         * xml-support.c: Use C++ exception handling.
1466         * x86-linux-nat.c: Use C++ exception handling.
1467         * windows-nat.c: Use C++ exception handling.
1468         * varobj.c: Use C++ exception handling.
1469         * value.c: Use C++ exception handling.
1470         * valprint.c: Use C++ exception handling.
1471         * valops.c: Use C++ exception handling.
1472         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1473         handling.
1474         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1475         * typeprint.c: Use C++ exception handling.
1476         * tui/tui.c: Use C++ exception handling.
1477         * tracefile-tfile.c: Use C++ exception handling.
1478         * top.c: Use C++ exception handling.
1479         * thread.c: Use C++ exception handling.
1480         * target.c: Use C++ exception handling.
1481         * symmisc.c: Use C++ exception handling.
1482         * symfile-mem.c: Use C++ exception handling.
1483         * stack.c: Use C++ exception handling.
1484         * sparc64-linux-tdep.c: Use C++ exception handling.
1485         * solib.c: Use C++ exception handling.
1486         * solib-svr4.c: Use C++ exception handling.
1487         * solib-spu.c: Use C++ exception handling.
1488         * solib-frv.c: Use C++ exception handling.
1489         * solib-dsbt.c: Use C++ exception handling.
1490         * selftest-arch.c: Use C++ exception handling.
1491         * s390-tdep.c: Use C++ exception handling.
1492         * rust-lang.c: Use C++ exception handling.
1493         * rust-exp.y: Use C++ exception handling.
1494         * rs6000-tdep.c: Use C++ exception handling.
1495         * rs6000-aix-tdep.c: Use C++ exception handling.
1496         * riscv-tdep.c: Use C++ exception handling.
1497         * remote.c: Use C++ exception handling.
1498         * remote-fileio.c: Use C++ exception handling.
1499         * record-full.c: Use C++ exception handling.
1500         * record-btrace.c: Use C++ exception handling.
1501         * python/python.c: Use C++ exception handling.
1502         * python/py-value.c: Use C++ exception handling.
1503         * python/py-utils.c: Use C++ exception handling.
1504         * python/py-unwind.c: Use C++ exception handling.
1505         * python/py-type.c: Use C++ exception handling.
1506         * python/py-symbol.c: Use C++ exception handling.
1507         * python/py-record.c: Use C++ exception handling.
1508         * python/py-record-btrace.c: Use C++ exception handling.
1509         * python/py-progspace.c: Use C++ exception handling.
1510         * python/py-prettyprint.c: Use C++ exception handling.
1511         * python/py-param.c: Use C++ exception handling.
1512         * python/py-objfile.c: Use C++ exception handling.
1513         * python/py-linetable.c: Use C++ exception handling.
1514         * python/py-lazy-string.c: Use C++ exception handling.
1515         * python/py-infthread.c: Use C++ exception handling.
1516         * python/py-inferior.c: Use C++ exception handling.
1517         * python/py-gdb-readline.c: Use C++ exception handling.
1518         * python/py-framefilter.c: Use C++ exception handling.
1519         * python/py-frame.c: Use C++ exception handling.
1520         * python/py-finishbreakpoint.c: Use C++ exception handling.
1521         * python/py-cmd.c: Use C++ exception handling.
1522         * python/py-breakpoint.c: Use C++ exception handling.
1523         * python/py-arch.c: Use C++ exception handling.
1524         * printcmd.c: Use C++ exception handling.
1525         * ppc-linux-tdep.c: Use C++ exception handling.
1526         * parse.c: Use C++ exception handling.
1527         * p-valprint.c: Use C++ exception handling.
1528         * objc-lang.c: Use C++ exception handling.
1529         * mi/mi-main.c: Use C++ exception handling.
1530         * mi/mi-interp.c: Use C++ exception handling.
1531         * mi/mi-cmd-stack.c: Use C++ exception handling.
1532         * mi/mi-cmd-break.c: Use C++ exception handling.
1533         * main.c: Use C++ exception handling.
1534         * linux-thread-db.c: Use C++ exception handling.
1535         * linux-tdep.c: Use C++ exception handling.
1536         * linux-nat.c: Use C++ exception handling.
1537         * linux-fork.c: Use C++ exception handling.
1538         * linespec.c: Use C++ exception handling.
1539         * language.c: Use C++ exception handling.
1540         * jit.c: Use C++ exception handling.
1541         * infrun.c: Use C++ exception handling.
1542         * infcmd.c: Use C++ exception handling.
1543         * infcall.c: Use C++ exception handling.
1544         * inf-loop.c: Use C++ exception handling.
1545         * i386-tdep.c: Use C++ exception handling.
1546         * i386-linux-tdep.c: Use C++ exception handling.
1547         * guile/scm-value.c: Use C++ exception handling.
1548         * guile/scm-type.c: Use C++ exception handling.
1549         * guile/scm-symtab.c: Use C++ exception handling.
1550         * guile/scm-symbol.c: Use C++ exception handling.
1551         * guile/scm-pretty-print.c: Use C++ exception handling.
1552         * guile/scm-ports.c: Use C++ exception handling.
1553         * guile/scm-param.c: Use C++ exception handling.
1554         * guile/scm-math.c: Use C++ exception handling.
1555         * guile/scm-lazy-string.c: Use C++ exception handling.
1556         * guile/scm-frame.c: Use C++ exception handling.
1557         * guile/scm-disasm.c: Use C++ exception handling.
1558         * guile/scm-cmd.c: Use C++ exception handling.
1559         * guile/scm-breakpoint.c: Use C++ exception handling.
1560         * guile/scm-block.c: Use C++ exception handling.
1561         * guile/guile-internal.h: Use C++ exception handling.
1562         * gnu-v3-abi.c: Use C++ exception handling.
1563         * gdbtypes.c: Use C++ exception handling.
1564         * frame.c: Use C++ exception handling.
1565         * frame-unwind.c: Use C++ exception handling.
1566         * fbsd-tdep.c: Use C++ exception handling.
1567         * f-valprint.c: Use C++ exception handling.
1568         * exec.c: Use C++ exception handling.
1569         * event-top.c: Use C++ exception handling.
1570         * event-loop.c: Use C++ exception handling.
1571         * eval.c: Use C++ exception handling.
1572         * dwarf2read.c: Use C++ exception handling.
1573         * dwarf2loc.c: Use C++ exception handling.
1574         * dwarf2-frame.c: Use C++ exception handling.
1575         * dwarf2-frame-tailcall.c: Use C++ exception handling.
1576         * dwarf-index-write.c: Use C++ exception handling.
1577         * dwarf-index-cache.c: Use C++ exception handling.
1578         * dtrace-probe.c: Use C++ exception handling.
1579         * disasm-selftests.c: Use C++ exception handling.
1580         * darwin-nat.c: Use C++ exception handling.
1581         * cp-valprint.c: Use C++ exception handling.
1582         * cp-support.c: Use C++ exception handling.
1583         * cp-abi.c: Use C++ exception handling.
1584         * corelow.c: Use C++ exception handling.
1585         * completer.c: Use C++ exception handling.
1586         * compile/compile-object-run.c: Use C++ exception handling.
1587         * compile/compile-object-load.c: Use C++ exception handling.
1588         * compile/compile-cplus-symbols.c: Use C++ exception handling.
1589         * compile/compile-c-symbols.c: Use C++ exception handling.
1590         * common/selftest.c: Use C++ exception handling.
1591         * common/new-op.c: Use C++ exception handling.
1592         * cli/cli-script.c: Use C++ exception handling.
1593         * cli/cli-interp.c: Use C++ exception handling.
1594         * cli/cli-cmds.c: Use C++ exception handling.
1595         * c-varobj.c: Use C++ exception handling.
1596         * btrace.c: Use C++ exception handling.
1597         * breakpoint.c: Use C++ exception handling.
1598         * break-catch-throw.c: Use C++ exception handling.
1599         * arch-utils.c: Use C++ exception handling.
1600         * amd64-tdep.c: Use C++ exception handling.
1601         * ada-valprint.c: Use C++ exception handling.
1602         * ada-typeprint.c: Use C++ exception handling.
1603         * ada-lang.c: Use C++ exception handling.
1604         * aarch64-tdep.c: Use C++ exception handling.
1605
1606 2019-04-08  Tom Tromey  <tom@tromey.com>
1607
1608         * xml-support.c (gdb_xml_parser::parse): Update.
1609         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1610         * value.c (show_convenience): Update.
1611         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
1612         (test_parse_flags_qcs): Update.
1613         * thread.c (thr_try_catch_cmd): Update.
1614         * target.c (target_translate_tls_address): Update.
1615         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1616         (info_frame_command_core, frame_apply_command_count): Update.
1617         * rust-exp.y (rust_lex_exception_test): Update.
1618         * riscv-tdep.c (riscv_print_one_register_info): Update.
1619         * remote.c (remote_target::enable_btrace): Update.
1620         * record-btrace.c (record_btrace_enable_warn): Update.
1621         * python/py-utils.c (gdbpy_convert_exception): Update.
1622         * printcmd.c (do_one_display, print_variable_and_value): Update.
1623         * mi/mi-main.c (mi_print_exception): Update.
1624         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
1625         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1626         * linux-nat.c (linux_nat_target::attach): Update.
1627         * linux-fork.c (class scoped_switch_fork_info): Update.
1628         * infrun.c (displaced_step_prepare): Update.
1629         * infcall.c (call_function_by_hand_dummy): Update.
1630         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
1631         * gnu-v3-abi.c (print_one_vtable): Update.
1632         * frame.c (get_prev_frame_always): Update.
1633         * f-valprint.c (info_common_command_for_block): Update.
1634         * exec.c (try_open_exec_file): Update.
1635         * exceptions.c (print_exception, exception_print)
1636         (exception_fprintf, exception_print_same): Update.
1637         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
1638         * dwarf-index-cache.c (index_cache::store)
1639         (index_cache::lookup_gdb_index): Update.
1640         * darwin-nat.c (maybe_cache_shell): Update.
1641         * cp-valprint.c (cp_print_value_fields): Update.
1642         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
1643         (gcc_cplus_symbol_address): Update.
1644         * compile/compile-c-symbols.c (gcc_convert_symbol)
1645         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
1646         * common/selftest.c: Update.
1647         * common/common-exceptions.h (struct gdb_exception) <message>: Now
1648         a std::string.
1649         (exception_try_scope_entry, exception_try_scope_exit): Don't
1650         declare.
1651         (struct exception_try_scope): Remove.
1652         (TRY): Don't use exception_try_scope.
1653         (struct gdb_exception): Add constructor, operator=.
1654         <what>: New method.
1655         (struct gdb_exception_RETURN_MASK_ALL)
1656         (struct gdb_exception_RETURN_MASK_ERROR)
1657         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
1658         (struct gdb_quit_bad_alloc): Update.
1659         * common/common-exceptions.c (exception_none): Change
1660         initializer.
1661         (struct catcher) <state, exception>: Initialize inline.
1662         <prev>: Remove member.
1663         (current_catcher): Remove.
1664         (catchers): New global.
1665         (exceptions_state_mc_init): Simplify.
1666         (catcher_pop): Remove.
1667         (exceptions_state_mc, exceptions_state_mc_catch): Update.
1668         (try_scope_depth, exception_try_scope_entry)
1669         (exception_try_scope_exit): Remove.
1670         (throw_exception_sjlj): Update.
1671         (exception_messages, exception_messages_size): Remove.
1672         (throw_it): Simplify.
1673         (gdb_exception_sliced_copy): Remove.
1674         (throw_exception_cxx): Update.
1675         * cli/cli-script.c (script_from_file): Update.
1676         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
1677         Update.
1678         * ada-valprint.c (ada_val_print): Update.
1679         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
1680         (create_excep_cond_exprs): Update.
1681
1682 2019-04-08  Tom Tromey  <tom@tromey.com>
1683
1684         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
1685         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
1686         (TRY, CATCH, END_CATCH): Remove some definitions.
1687         * common/common-exceptions.c: Don't use GDB_XCPT.
1688         (catcher_list_size): Remove.
1689         (throw_exception, throw_it): Simplify.
1690
1691 2019-04-05  Tom Tromey  <tom@tromey.com>
1692
1693         Revert the header-sorting patch.
1694         * ft32-tdep.c: Revert.
1695         * frv-tdep.c: Revert.
1696         * frv-linux-tdep.c: Revert.
1697         * frame.c: Revert.
1698         * frame-unwind.c: Revert.
1699         * frame-base.c: Revert.
1700         * fork-child.c: Revert.
1701         * findvar.c: Revert.
1702         * findcmd.c: Revert.
1703         * filesystem.c: Revert.
1704         * filename-seen-cache.h: Revert.
1705         * filename-seen-cache.c: Revert.
1706         * fbsd-tdep.c: Revert.
1707         * fbsd-nat.h: Revert.
1708         * fbsd-nat.c: Revert.
1709         * f-valprint.c: Revert.
1710         * f-typeprint.c: Revert.
1711         * f-lang.c: Revert.
1712         * extension.h: Revert.
1713         * extension.c: Revert.
1714         * extension-priv.h: Revert.
1715         * expprint.c: Revert.
1716         * exec.h: Revert.
1717         * exec.c: Revert.
1718         * exceptions.c: Revert.
1719         * event-top.c: Revert.
1720         * event-loop.c: Revert.
1721         * eval.c: Revert.
1722         * elfread.c: Revert.
1723         * dwarf2read.h: Revert.
1724         * dwarf2read.c: Revert.
1725         * dwarf2loc.c: Revert.
1726         * dwarf2expr.h: Revert.
1727         * dwarf2expr.c: Revert.
1728         * dwarf2-frame.c: Revert.
1729         * dwarf2-frame-tailcall.c: Revert.
1730         * dwarf-index-write.h: Revert.
1731         * dwarf-index-write.c: Revert.
1732         * dwarf-index-common.c: Revert.
1733         * dwarf-index-cache.h: Revert.
1734         * dwarf-index-cache.c: Revert.
1735         * dummy-frame.c: Revert.
1736         * dtrace-probe.c: Revert.
1737         * disasm.h: Revert.
1738         * disasm.c: Revert.
1739         * disasm-selftests.c: Revert.
1740         * dictionary.c: Revert.
1741         * dicos-tdep.c: Revert.
1742         * demangle.c: Revert.
1743         * dcache.h: Revert.
1744         * dcache.c: Revert.
1745         * darwin-nat.h: Revert.
1746         * darwin-nat.c: Revert.
1747         * darwin-nat-info.c: Revert.
1748         * d-valprint.c: Revert.
1749         * d-namespace.c: Revert.
1750         * d-lang.c: Revert.
1751         * ctf.c: Revert.
1752         * csky-tdep.c: Revert.
1753         * csky-linux-tdep.c: Revert.
1754         * cris-tdep.c: Revert.
1755         * cris-linux-tdep.c: Revert.
1756         * cp-valprint.c: Revert.
1757         * cp-support.c: Revert.
1758         * cp-namespace.c: Revert.
1759         * cp-abi.c: Revert.
1760         * corelow.c: Revert.
1761         * corefile.c: Revert.
1762         * continuations.c: Revert.
1763         * completer.h: Revert.
1764         * completer.c: Revert.
1765         * complaints.c: Revert.
1766         * coffread.c: Revert.
1767         * coff-pe-read.c: Revert.
1768         * cli-out.h: Revert.
1769         * cli-out.c: Revert.
1770         * charset.c: Revert.
1771         * c-varobj.c: Revert.
1772         * c-valprint.c: Revert.
1773         * c-typeprint.c: Revert.
1774         * c-lang.c: Revert.
1775         * buildsym.c: Revert.
1776         * buildsym-legacy.c: Revert.
1777         * build-id.h: Revert.
1778         * build-id.c: Revert.
1779         * btrace.c: Revert.
1780         * bsd-uthread.c: Revert.
1781         * breakpoint.h: Revert.
1782         * breakpoint.c: Revert.
1783         * break-catch-throw.c: Revert.
1784         * break-catch-syscall.c: Revert.
1785         * break-catch-sig.c: Revert.
1786         * blockframe.c: Revert.
1787         * block.c: Revert.
1788         * bfin-tdep.c: Revert.
1789         * bfin-linux-tdep.c: Revert.
1790         * bfd-target.c: Revert.
1791         * bcache.c: Revert.
1792         * ax-general.c: Revert.
1793         * ax-gdb.h: Revert.
1794         * ax-gdb.c: Revert.
1795         * avr-tdep.c: Revert.
1796         * auxv.c: Revert.
1797         * auto-load.c: Revert.
1798         * arm-wince-tdep.c: Revert.
1799         * arm-tdep.c: Revert.
1800         * arm-symbian-tdep.c: Revert.
1801         * arm-pikeos-tdep.c: Revert.
1802         * arm-obsd-tdep.c: Revert.
1803         * arm-nbsd-tdep.c: Revert.
1804         * arm-nbsd-nat.c: Revert.
1805         * arm-linux-tdep.c: Revert.
1806         * arm-linux-nat.c: Revert.
1807         * arm-fbsd-tdep.c: Revert.
1808         * arm-fbsd-nat.c: Revert.
1809         * arm-bsd-tdep.c: Revert.
1810         * arch-utils.c: Revert.
1811         * arc-tdep.c: Revert.
1812         * arc-newlib-tdep.c: Revert.
1813         * annotate.h: Revert.
1814         * annotate.c: Revert.
1815         * amd64-windows-tdep.c: Revert.
1816         * amd64-windows-nat.c: Revert.
1817         * amd64-tdep.c: Revert.
1818         * amd64-sol2-tdep.c: Revert.
1819         * amd64-obsd-tdep.c: Revert.
1820         * amd64-obsd-nat.c: Revert.
1821         * amd64-nbsd-tdep.c: Revert.
1822         * amd64-nbsd-nat.c: Revert.
1823         * amd64-nat.c: Revert.
1824         * amd64-linux-tdep.c: Revert.
1825         * amd64-linux-nat.c: Revert.
1826         * amd64-fbsd-tdep.c: Revert.
1827         * amd64-fbsd-nat.c: Revert.
1828         * amd64-dicos-tdep.c: Revert.
1829         * amd64-darwin-tdep.c: Revert.
1830         * amd64-bsd-nat.c: Revert.
1831         * alpha-tdep.c: Revert.
1832         * alpha-obsd-tdep.c: Revert.
1833         * alpha-nbsd-tdep.c: Revert.
1834         * alpha-mdebug-tdep.c: Revert.
1835         * alpha-linux-tdep.c: Revert.
1836         * alpha-linux-nat.c: Revert.
1837         * alpha-bsd-tdep.c: Revert.
1838         * alpha-bsd-nat.c: Revert.
1839         * aix-thread.c: Revert.
1840         * agent.c: Revert.
1841         * addrmap.c: Revert.
1842         * ada-varobj.c: Revert.
1843         * ada-valprint.c: Revert.
1844         * ada-typeprint.c: Revert.
1845         * ada-tasks.c: Revert.
1846         * ada-lang.c: Revert.
1847         * aarch64-tdep.c: Revert.
1848         * aarch64-ravenscar-thread.c: Revert.
1849         * aarch64-newlib-tdep.c: Revert.
1850         * aarch64-linux-tdep.c: Revert.
1851         * aarch64-linux-nat.c: Revert.
1852         * aarch64-fbsd-tdep.c: Revert.
1853         * aarch64-fbsd-nat.c: Revert.
1854         * aarch32-linux-nat.c: Revert.
1855
1856 2019-04-05  Tom Tromey  <tom@tromey.com>
1857
1858         * ft32-tdep.c: Sort headers.
1859         * frv-tdep.c: Sort headers.
1860         * frv-linux-tdep.c: Sort headers.
1861         * frame.c: Sort headers.
1862         * frame-unwind.c: Sort headers.
1863         * frame-base.c: Sort headers.
1864         * fork-child.c: Sort headers.
1865         * findvar.c: Sort headers.
1866         * findcmd.c: Sort headers.
1867         * filesystem.c: Sort headers.
1868         * filename-seen-cache.h: Sort headers.
1869         * filename-seen-cache.c: Sort headers.
1870         * fbsd-tdep.c: Sort headers.
1871         * fbsd-nat.h: Sort headers.
1872         * fbsd-nat.c: Sort headers.
1873         * f-valprint.c: Sort headers.
1874         * f-typeprint.c: Sort headers.
1875         * f-lang.c: Sort headers.
1876         * extension.h: Sort headers.
1877         * extension.c: Sort headers.
1878         * extension-priv.h: Sort headers.
1879         * expprint.c: Sort headers.
1880         * exec.h: Sort headers.
1881         * exec.c: Sort headers.
1882         * exceptions.c: Sort headers.
1883         * event-top.c: Sort headers.
1884         * event-loop.c: Sort headers.
1885         * eval.c: Sort headers.
1886         * elfread.c: Sort headers.
1887         * dwarf2read.h: Sort headers.
1888         * dwarf2read.c: Sort headers.
1889         * dwarf2loc.c: Sort headers.
1890         * dwarf2expr.h: Sort headers.
1891         * dwarf2expr.c: Sort headers.
1892         * dwarf2-frame.c: Sort headers.
1893         * dwarf2-frame-tailcall.c: Sort headers.
1894         * dwarf-index-write.h: Sort headers.
1895         * dwarf-index-write.c: Sort headers.
1896         * dwarf-index-common.c: Sort headers.
1897         * dwarf-index-cache.h: Sort headers.
1898         * dwarf-index-cache.c: Sort headers.
1899         * dummy-frame.c: Sort headers.
1900         * dtrace-probe.c: Sort headers.
1901         * disasm.h: Sort headers.
1902         * disasm.c: Sort headers.
1903         * disasm-selftests.c: Sort headers.
1904         * dictionary.c: Sort headers.
1905         * dicos-tdep.c: Sort headers.
1906         * demangle.c: Sort headers.
1907         * dcache.h: Sort headers.
1908         * dcache.c: Sort headers.
1909         * darwin-nat.h: Sort headers.
1910         * darwin-nat.c: Sort headers.
1911         * darwin-nat-info.c: Sort headers.
1912         * d-valprint.c: Sort headers.
1913         * d-namespace.c: Sort headers.
1914         * d-lang.c: Sort headers.
1915         * ctf.c: Sort headers.
1916         * csky-tdep.c: Sort headers.
1917         * csky-linux-tdep.c: Sort headers.
1918         * cris-tdep.c: Sort headers.
1919         * cris-linux-tdep.c: Sort headers.
1920         * cp-valprint.c: Sort headers.
1921         * cp-support.c: Sort headers.
1922         * cp-namespace.c: Sort headers.
1923         * cp-abi.c: Sort headers.
1924         * corelow.c: Sort headers.
1925         * corefile.c: Sort headers.
1926         * continuations.c: Sort headers.
1927         * completer.h: Sort headers.
1928         * completer.c: Sort headers.
1929         * complaints.c: Sort headers.
1930         * coffread.c: Sort headers.
1931         * coff-pe-read.c: Sort headers.
1932         * cli-out.h: Sort headers.
1933         * cli-out.c: Sort headers.
1934         * charset.c: Sort headers.
1935         * c-varobj.c: Sort headers.
1936         * c-valprint.c: Sort headers.
1937         * c-typeprint.c: Sort headers.
1938         * c-lang.c: Sort headers.
1939         * buildsym.c: Sort headers.
1940         * buildsym-legacy.c: Sort headers.
1941         * build-id.h: Sort headers.
1942         * build-id.c: Sort headers.
1943         * btrace.c: Sort headers.
1944         * bsd-uthread.c: Sort headers.
1945         * breakpoint.h: Sort headers.
1946         * breakpoint.c: Sort headers.
1947         * break-catch-throw.c: Sort headers.
1948         * break-catch-syscall.c: Sort headers.
1949         * break-catch-sig.c: Sort headers.
1950         * blockframe.c: Sort headers.
1951         * block.c: Sort headers.
1952         * bfin-tdep.c: Sort headers.
1953         * bfin-linux-tdep.c: Sort headers.
1954         * bfd-target.c: Sort headers.
1955         * bcache.c: Sort headers.
1956         * ax-general.c: Sort headers.
1957         * ax-gdb.h: Sort headers.
1958         * ax-gdb.c: Sort headers.
1959         * avr-tdep.c: Sort headers.
1960         * auxv.c: Sort headers.
1961         * auto-load.c: Sort headers.
1962         * arm-wince-tdep.c: Sort headers.
1963         * arm-tdep.c: Sort headers.
1964         * arm-symbian-tdep.c: Sort headers.
1965         * arm-pikeos-tdep.c: Sort headers.
1966         * arm-obsd-tdep.c: Sort headers.
1967         * arm-nbsd-tdep.c: Sort headers.
1968         * arm-nbsd-nat.c: Sort headers.
1969         * arm-linux-tdep.c: Sort headers.
1970         * arm-linux-nat.c: Sort headers.
1971         * arm-fbsd-tdep.c: Sort headers.
1972         * arm-fbsd-nat.c: Sort headers.
1973         * arm-bsd-tdep.c: Sort headers.
1974         * arch-utils.c: Sort headers.
1975         * arc-tdep.c: Sort headers.
1976         * arc-newlib-tdep.c: Sort headers.
1977         * annotate.h: Sort headers.
1978         * annotate.c: Sort headers.
1979         * amd64-windows-tdep.c: Sort headers.
1980         * amd64-windows-nat.c: Sort headers.
1981         * amd64-tdep.c: Sort headers.
1982         * amd64-sol2-tdep.c: Sort headers.
1983         * amd64-obsd-tdep.c: Sort headers.
1984         * amd64-obsd-nat.c: Sort headers.
1985         * amd64-nbsd-tdep.c: Sort headers.
1986         * amd64-nbsd-nat.c: Sort headers.
1987         * amd64-nat.c: Sort headers.
1988         * amd64-linux-tdep.c: Sort headers.
1989         * amd64-linux-nat.c: Sort headers.
1990         * amd64-fbsd-tdep.c: Sort headers.
1991         * amd64-fbsd-nat.c: Sort headers.
1992         * amd64-dicos-tdep.c: Sort headers.
1993         * amd64-darwin-tdep.c: Sort headers.
1994         * amd64-bsd-nat.c: Sort headers.
1995         * alpha-tdep.c: Sort headers.
1996         * alpha-obsd-tdep.c: Sort headers.
1997         * alpha-nbsd-tdep.c: Sort headers.
1998         * alpha-mdebug-tdep.c: Sort headers.
1999         * alpha-linux-tdep.c: Sort headers.
2000         * alpha-linux-nat.c: Sort headers.
2001         * alpha-bsd-tdep.c: Sort headers.
2002         * alpha-bsd-nat.c: Sort headers.
2003         * aix-thread.c: Sort headers.
2004         * agent.c: Sort headers.
2005         * addrmap.c: Sort headers.
2006         * ada-varobj.c: Sort headers.
2007         * ada-valprint.c: Sort headers.
2008         * ada-typeprint.c: Sort headers.
2009         * ada-tasks.c: Sort headers.
2010         * ada-lang.c: Sort headers.
2011         * aarch64-tdep.c: Sort headers.
2012         * aarch64-ravenscar-thread.c: Sort headers.
2013         * aarch64-newlib-tdep.c: Sort headers.
2014         * aarch64-linux-tdep.c: Sort headers.
2015         * aarch64-linux-nat.c: Sort headers.
2016         * aarch64-fbsd-tdep.c: Sort headers.
2017         * aarch64-fbsd-nat.c: Sort headers.
2018         * aarch32-linux-nat.c: Sort headers.
2019
2020 2019-04-04  Tom Tromey  <tom@tromey.com>
2021
2022         * varobj.c (varobj_create): Update.
2023         * rust-exp.y (struct rust_parser) <update_innermost_block,
2024         lookup_symbol>: New methods.
2025         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
2026         Rename.
2027         (rust_parser::rust_lookup_type)
2028         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2029         * printcmd.c (display_command, do_one_display): Update.
2030         * parser-defs.h (struct parser_state) <parser_state>: Add
2031         "tracker" parameter.
2032         (block_tracker): New member.
2033         (class innermost_block_tracker) <innermost_block_tracker>: Add
2034         "types" parameter.
2035         <reset>: Remove method.
2036         (innermost_block): Don't declare.
2037         (null_post_parser): Update.
2038         * parse.c (innermost_block): Remove global.
2039         (write_dollar_variable): Update.
2040         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
2041         Remove "tracker_types" parameter.
2042         (parse_expression): Add "tracker" parameter.
2043         (parse_expression_for_completion): Update.
2044         (null_post_parser): Add "tracker" parameter.
2045         * p-exp.y: Update rules.
2046         * m2-exp.y: Update rules.
2047         * language.h (struct language_defn) <la_post_parser>: Add
2048         "tracker" parameter.
2049         * go-exp.y: Update rules.
2050         * f-exp.y: Update rules.
2051         * expression.h (parse_expression, parse_exp_1): Add "tracker"
2052         parameter.
2053         * d-exp.y: Update rules.
2054         * c-exp.y: Update rules.
2055         * breakpoint.c (set_breakpoint_condition): Create an
2056         innermost_block_tracker.
2057         (watch_command_1): Likewise.
2058         * ada-lang.c (resolve): Add "tracker" parameter.
2059         (resolve_subexp): Likewise.
2060         * ada-exp.y (write_var_from_sym): Update.
2061
2062 2019-04-04  Tom Tromey  <tom@tromey.com>
2063
2064         * type-stack.h: New file.
2065         * type-stack.c: New file.
2066         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
2067         type-stack.h.
2068         (insert_into_type_stack, insert_type, push_type, push_type_int)
2069         (insert_type_address_space, pop_type, pop_type_int)
2070         (pop_typelist, pop_type_stack, append_type_stack)
2071         (push_type_stack, get_type_stack, push_typelist)
2072         (follow_type_instance_flags, follow_types): Don't declare.
2073         * parse.c (type_stack): Remove global.
2074         (parse_exp_in_context): Update.
2075         (insert_into_type_stack, insert_type, push_type, push_type_int)
2076         (insert_type_address_space, pop_type, pop_type_int)
2077         (pop_typelist, pop_type_stack, append_type_stack)
2078         (push_type_stack, get_type_stack, push_typelist)
2079         (follow_type_instance_flags, follow_types): Remove (moved to
2080         type-stack.c).
2081         * f-exp.y (type_stack): New global.
2082         Update rules.
2083         (push_kind_type, f_parse): Update.
2084         * d-exp.y (type_stack): New global.
2085         Update rules.
2086         (d_parse): Update.
2087         * c-exp.y (struct c_parse_state) <type_stack>: New member.
2088         Update rules.
2089         * Makefile.in (COMMON_SFILES): Add type-stack.c.
2090         (HFILES_NO_SRCDIR): Add type-stack.h.
2091
2092 2019-04-04  Tom Tromey  <tom@tromey.com>
2093
2094         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
2095         (rust_parser::convert_ast_to_expression, rust_parse)
2096         (rust_lex_test_completion, rust_lex_tests): Update.
2097         * parser-defs.h (struct expr_completion_state): New.
2098         (struct parser_state) <parser_state>: Add completion parameter.
2099         <mark_struct_expression, mark_completion_tag>: New methods.
2100         <parse_completion, m_completion_state>: New members.
2101         (prefixify_expression, null_post_parser): Update.
2102         (mark_struct_expression, mark_completion_tag): Don't declare.
2103         * parse.c (parse_completion, expout_last_struct)
2104         (expout_tag_completion_type, expout_completion_name): Remove
2105         globals.
2106         (parser_state::mark_struct_expression)
2107         (parser_state::mark_completion_tag): Now methods.
2108         (prefixify_expression): Add last_struct parameter.
2109         (prefixify_subexp): Likewise.
2110         (parse_exp_1): Update.
2111         (parse_exp_in_context): Add cstate parameter.  Update.
2112         (parse_expression_for_completion): Create an
2113         expr_completion_state.
2114         (null_post_parser): Add "completion" parameter.
2115         * p-exp.y: Update rules.
2116         (yylex): Update.
2117         * language.h (struct language_defn) <la_post_parser>: Add
2118         "completing" parameter.
2119         * go-exp.y: Update rules.
2120         (lex_one_token): Update.
2121         * expression.h (parse_completion): Don't declare.
2122         * d-exp.y: Update rules.
2123         (lex_one_token): Update rules.
2124         * c-exp.y: Update rules.
2125         (lex_one_token): Update.
2126         * ada-lang.c (resolve): Add "parse_completion" parameter.
2127         (resolve_subexp): Likewise.
2128         (ada_resolve_function): Likewise.
2129
2130 2019-04-04  Tom Tromey  <tom@tromey.com>
2131
2132         * parser-defs.h (struct parser_state) <start_arglist,
2133         end_arglist>: New methods.
2134         <arglist_len, m_funcall_chain>: New members.
2135         (arglist_len, start_arglist, end_arglist): Don't declare.
2136         * parse.c (arglist_len, funcall_chain): Remove global.
2137         (start_arglist, end_arglist): Remove functions.
2138         (parse_exp_in_context): Update.
2139         * p-exp.y: Update rules.
2140         * m2-exp.y: Update rules.
2141         * go-exp.y: Update rules.
2142         * f-exp.y: Update rules.
2143         * d-exp.y: Update rules.
2144         * c-exp.y: Update rules.
2145
2146 2019-04-04  Tom Tromey  <tom@tromey.com>
2147
2148         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2149         lex_operator, push_back>: New methods.
2150         Update all rules.
2151         (rust_parser::lex_hex, lex_escape): Rename and update.
2152         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2153         (rust_parser::lex_operator): Rename and update.
2154         (rust_parser::lex_number, rustyylex, rustyyerror)
2155         (rust_lex_test_init, rust_lex_test_sequence)
2156         (rust_lex_test_push_back, rust_lex_tests): Update.
2157         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2158         parameter.
2159         <lexptr, prev_lexptr>: New members.
2160         (lexptr, prev_lexptr): Don't declare.
2161         * parse.c (lexptr, prev_lexptr): Remove globals.
2162         (parse_exp_in_context): Update.
2163         * p-exp.y (yylex, yyerror): Update.
2164         * m2-exp.y (parse_number, yylex, yyerror): Update.
2165         * go-exp.y (lex_one_token, yyerror): Update.
2166         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2167         * d-exp.y (lex_one_token, yyerror): Update.
2168         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2169         (lex_one_token, yyerror): Update.
2170         * ada-lex.l (YY_INPUT): Update.
2171         (rewind_to_char): Update.
2172         * ada-exp.y (yyerror): Update.
2173
2174 2019-04-04  Tom Tromey  <tom@tromey.com>
2175
2176         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2177         * parser-defs.h (struct parser_state) <parser_state>: Add new
2178         parameter.
2179         <comma_terminates>: New member.
2180         (comma_terminates): Don't declare global.
2181         * parse.c (comma_terminates): Remove global.
2182         (parse_exp_in_context): Update.
2183         * p-exp.y (yylex): Update.
2184         * m2-exp.y (yylex): Update.
2185         * go-exp.y (lex_one_token): Update.
2186         * f-exp.y (yylex): Update.
2187         * d-exp.y (lex_one_token): Update.
2188         * c-exp.y (lex_one_token): Update.
2189         * ada-lex.l: Update.
2190
2191 2019-04-04  Tom Tromey  <tom@tromey.com>
2192
2193         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2194         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2195         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2196         * parser-defs.h (paren_depth): Don't declare.
2197         * parse.c (paren_depth): Remove global.
2198         (parse_exp_in_context): Update.
2199         * p-exp.y (paren_depth): New global.
2200         (pascal_parse): Initialize it.
2201         * m2-exp.y (paren_depth): New global.
2202         (m2_parse): Initialize it.
2203         * go-exp.y (paren_depth): New global.
2204         (go_parse): Initialize it.
2205         * f-exp.y (paren_depth): New global.
2206         (f_parse): Initialize it.
2207         * d-exp.y (paren_depth): New global.
2208         (d_parse): Initialize it.
2209         * c-exp.y (paren_depth): New global.
2210         (c_parse): Initialize it.
2211         * ada-lex.l (paren_depth): New global.
2212         (lexer_init): Initialize it.
2213
2214 2019-04-04  Tom Tromey  <tom@tromey.com>
2215
2216         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2217         (rust_parser::convert_ast_to_type)
2218         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2219         * parser-defs.h (struct parser_state) <parser_state>: Add
2220         parameters.  Initialize new members.
2221         <expression_context_block, expression_context_pc>: New members.
2222         * parse.c (expression_context_block, expression_context_pc):
2223         Remove globals.
2224         (parse_exp_in_context): Update.
2225         * p-exp.y: Update all rules.
2226         (yylex): Update.
2227         * m2-exp.y: Update all rules.
2228         (yylex): Update.
2229         * go-exp.y (yylex): Update.
2230         * f-exp.y (yylex): Update.
2231         * d-exp.y: Update all rules.
2232         (yylex): Update.
2233         * c-exp.y: Update all rules.
2234         (lex_one_token, classify_name, yylex, c_parse): Update.
2235         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2236
2237 2019-04-04  Tom Tromey  <tom@tromey.com>
2238
2239         * gdbarch.h, gdbarch.c: Rebuild.
2240         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2241         * stap-probe.h:
2242         (struct stap_parse_info): Replace "parser_state" with
2243         "expr_builder".
2244         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2245         (parser_state): New class.
2246         * parse.c (expr_builder): Rename.
2247         (expr_builder::release): Rename.
2248         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2249         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2250         (write_exp_elt_longcst, write_exp_elt_floatcst)
2251         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2252         (write_exp_string_vector, write_exp_bitstring)
2253         (write_exp_msymbol, mark_struct_expression)
2254         (write_dollar_variable)
2255         (insert_type_address_space, increase_expout_size): Replace
2256         "parser_state" with "expr_builder".
2257         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2258         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2259         "parser_state" with "expr_builder".
2260
2261 2019-04-04  Tom Tromey  <tom@tromey.com>
2262
2263         * rust-exp.y: Replace "parse_language" with method call.
2264         * p-exp.y:
2265         (yylex): Replace "parse_language" with method call.
2266         * m2-exp.y:
2267         (yylex): Replace "parse_language" with method call.
2268         * go-exp.y (classify_name): Replace "parse_language" with method
2269         call.
2270         * f-exp.y (yylex): Replace "parse_language" with method call.
2271         * d-exp.y (lex_one_token): Replace "parse_language" with method
2272         call.
2273         * c-exp.y:
2274         (lex_one_token, classify_name, yylex): Replace "parse_language"
2275         with method call.
2276         * ada-exp.y (find_primitive_type, type_char)
2277         (type_system_address): Replace "parse_language" with method call.
2278
2279 2019-04-04  Tom Tromey  <tom@tromey.com>
2280
2281         * rust-exp.y: Replace "parse_gdbarch" with method call.
2282         * parse.c (write_dollar_variable, insert_type_address_space):
2283         Replace "parse_gdbarch" with method call.
2284         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2285         call.
2286         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2287         call.
2288         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2289         "parse_gdbarch" with method call.
2290         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2291         with method call.
2292         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2293         "parse_gdbarch" with method call.
2294         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2295         "parse_gdbarch" with method call.
2296         * c-exp.y (parse_type, parse_number, classify_name): Replace
2297         "parse_gdbarch" with method call.
2298         * ada-lex.l: Replace "parse_gdbarch" with method call.
2299         * ada-exp.y (parse_type, find_primitive_type, type_char)
2300         (type_system_address): Replace "parse_gdbarch" with method call.
2301
2302 2019-04-04  Tom Tromey  <tom@tromey.com>
2303
2304         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2305         * stap-probe.c (stap_parse_argument): Update.
2306         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2307         initial_size parameter.
2308         * rust-exp.y (rust_lex_tests): Update.
2309         * parse.c (parser_state): Update.
2310         (parse_exp_in_context): Update.
2311         * parser-defs.h (struct parser_state) <parser_state>: Remove
2312         "initial_size" parameter.
2313
2314 2019-04-04  Tom Tromey  <tom@tromey.com>
2315
2316         * parser-defs.h (increase_expout_size): Don't declare.
2317         * parse.c (increase_expout_size): Now static.
2318
2319 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2320
2321         * gnu-nat.c (gnu_nat_target::wait): Fix
2322         target_waitstatus_to_string call.
2323
2324 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2325
2326         * eval.c (evaluate_subexp_standard): Handle internal functions
2327         during Fortran function call handling.
2328
2329 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2330
2331         * NEWS: Mention new internal functions.
2332         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2333         (read_base_type): Use dwarf2_init_complex_target_type.
2334         * value.c (creal_internal_fn): New function.
2335         (cimag_internal_fn): New function.
2336         (_initialize_values): Register new internal functions.
2337
2338 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2339
2340         * infrun.c (stop_all_threads): If debug_infrun, always
2341         trace the wait status after wait_one, using
2342         target_waitstatus_to_string and target_pid_to_str.
2343         (handle_inferior_event): Replace various trace of
2344         wait status kind by a single trace.
2345         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2346         wait status kind image by target_waitstatus_to_string.
2347         * target/waitstatus.c (target_waitstatus_to_string): Fix
2348         obsolete comment.
2349
2350 2019-04-01  Tom Tromey  <tromey@adacore.com>
2351
2352         PR symtab/23331:
2353         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2354
2355 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2356             Pedro Alves  <palves@redhat.com>
2357
2358         * top.c (quit_force): Call 'finalize_values'.
2359         * value.c (finalize_values): New function.
2360         * value.h (finalize_values): Declare.
2361
2362 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2363
2364         * NEWS: Announce $_gdb_major and $_gdb_minor.
2365
2366         * top.c (init_gdb_version_vars): New function.
2367         (gdb_init): Call init_gdb_version_vars.
2368
2369 2019-03-29  Tom Tromey  <tromey@adacore.com>
2370
2371         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2372         help text.  Remove dead code.
2373
2374 2019-03-29  Keith Seitz  <keiths@redhat.com>
2375
2376         From Siddhesh Poyarekar:
2377         * f-lang.h (f77_get_upperbound): Return LONGEST.
2378         (f77_get_lowerbound): Likewise.
2379         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2380         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2381         print them.
2382         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2383         plongest to format print it.
2384         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2385         (f77_get_upperbound): Likewise.
2386         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2387         LOWER_BOUND to LONGEST.
2388         (f77_create_arrayprint_offset_tbl): Likewise.
2389
2390 2019-03-29  Keith Seitz  <keiths@redhat.com>
2391
2392         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2393         %s/pulongest for TYPE_LENGTH instead of %d in format
2394         strings.
2395         * ada-typerint.c (ada_print_type): Likewise.
2396         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2397         * compile/compile-c-support.c (generate_register_struct): Likewise.
2398         * gdbtypes.c (recursive_dump_type): Likewise.
2399         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2400         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2401         instead of %d in format strings.
2402         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2403         to std::min to ULONGEST.
2404         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2405         instead of %d in format strings.
2406         * tracepoint.c (info_scope_command): Likewise.
2407         * typeprint.c (print_offset_data::update)
2408         (print_offset_data::finish): Likewise.
2409         * xtensa-tdep.c (xtensa_store_return_value)
2410         (xtensa_push_dummy_call): Likewise.
2411
2412 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2413
2414         * windows-nat.c (display_selector): Fixed format specifications
2415         for 64-bit Cygwin.
2416
2417 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2418
2419         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2420
2421 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2422
2423         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2424         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2425         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2426         (nios2_linux_init_abi): Install it.
2427
2428 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2429
2430         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2431
2432 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2433
2434         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2435
2436 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2437             Tom Tromey  <tromey@adacore.com>
2438
2439         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2440
2441 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2442
2443         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2444         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2445         method to compute the bounds of range types. Also print "[evaluated]"
2446         if the bounds' values come from a dynamic evaluation.
2447
2448 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2449
2450         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2451         whitespace when pretty printing is on.
2452
2453 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2454
2455         * ppc-linux-nat.c: Add include.
2456
2457 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2458
2459         * NEWS: Mention AArch64 Pointer Authentication.
2460
2461 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2462
2463         * arm-linux-nat.c: Add include.
2464
2465 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2466
2467         * source-cache.c (source_cache::get_source_lines): Re-read
2468         fullname after calling open_source_file.
2469
2470 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2471
2472         * NEWS: Mention TLS support for FreeBSD.
2473
2474 2019-03-25  Tom Tromey  <tromey@adacore.com>
2475
2476         * minsyms.c (BUNCH_SIZE): Update comment.
2477         (~minimal_symbol_reader): Remove old comment.
2478         (compact_minimal_symbols): Update comment.
2479         (minimal_symbol_reader::install): Remove old comment.  Update
2480         other comments.
2481
2482 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2483
2484         * s390-linux-nat.c: Add include.
2485
2486 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2487
2488         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2489         Call linux_get_hwcap.
2490         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2491         Likewise.
2492         (aarch64_linux_get_hwcap): Remove function.
2493         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2494         declaration.
2495         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2496         linux_get_hwcap.
2497         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2498         * linux-tdep.c (linux_get_hwcap): Add function.
2499         (linux_get_hwcap2): Likewise.
2500         * linux-tdep.h (linux_get_hwcap): Add declaration.
2501         (linux_get_hwcap2): Likewise.
2502         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
2503         (ppc_linux_get_hwcap2): Likewise.
2504         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
2505         linux_get_hwcap.
2506         (ppc_linux_nat_target::insert_watchpoint): Likewise.
2507         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
2508         (ppc_linux_nat_target::read_description): Likewise.
2509         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
2510         * s390-linux-nat.c: Likewise.
2511         * s390-linux-tdep.c (s390_core_read_description): Likewise.
2512
2513 2019-03-24  Tom Tromey  <tom@tromey.com>
2514
2515         * ada-lang.c (standard_lookup): Simplify initialization.
2516         (ada_lookup_symbol_nonlocal): Simplify return.
2517         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
2518         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
2519         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
2520         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
2521         initialization.
2522         * solib.c (solib_global_lookup): Simplify.
2523         * symtab.c (null_block_symbol): Remove.
2524         (symbol_cache_lookup): Simplify returns.
2525         (lookup_language_this): Simplify returns.
2526         (lookup_symbol_aux): Simplify return.
2527         (lookup_local_symbol): Simplify returns.
2528         (lookup_global_symbol_from_objfile): Simplify return.
2529         (lookup_symbol_in_objfile_symtabs)
2530         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
2531         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
2532         (lookup_static_symbol, lookup_global_symbol): Simplify return.
2533         * cp-namespace.c (cp_lookup_bare_symbol)
2534         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
2535         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
2536         (cp_lookup_nested_symbol): Don't use null_block_symbol.
2537         (cp_lookup_symbol_via_imports): Simplify initialization.
2538         (find_symbol_in_baseclass): Likewise.
2539         * symtab.h (null_block_symbol): Remove.
2540         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2541         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2542         (d_lookup_symbol_module): Likewise.
2543         (find_symbol_in_baseclass): Simplify initialization.
2544
2545 2019-03-24  Tom Tromey  <tom@tromey.com>
2546
2547         * expression.h: Don't include symtab.h.
2548         (struct block): Forward declare.
2549
2550 2019-03-24  Tom Tromey  <tom@tromey.com>
2551
2552         * c-exp.y (typebase): Remove casts.
2553         * gdbtypes.c (lookup_unsigned_typename, )
2554         (lookup_signed_typename): Remove cast.
2555         * eval.c (parse_to_comma_and_eval): Remove cast.
2556         * parse.c (write_dollar_variable): Remove cast.
2557         * block.h (struct block) <superblock>: Now const.
2558         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
2559         * psymtab.c (psym_map_matching_symbols): Make "block" const.
2560         (map_block): Make "block" const.
2561         * symfile.h (struct quick_symbol_functions)
2562         <map_matching_symbols>: Constify block argument to "callback".
2563         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
2564         const.
2565         (find_pc_sect_compunit_symtab): Make "b" const.
2566         (find_symbol_at_address): Likewise.
2567         (search_symbols): Likewise.
2568         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
2569         (dw2_debug_names_lookup_symbol): Likewise.
2570         (dw2_map_matching_symbols): Update.
2571         * p-valprint.c (pascal_val_print): Remove "block".
2572         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
2573         (aux_add_nonlocal_symbols): Make "block" const.
2574         (resolve_subexp): Remove cast.
2575         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
2576         const.
2577         (iterate_over_file_blocks): Likewise.
2578         * f-exp.y (%union) <bval>: Remove.
2579         * coffread.c (patch_opaque_types): Make "b" const.
2580         * spu-tdep.c (spu_catch_start): Make "block" const.
2581         * c-valprint.c (print_unpacked_pointer): Remove "block".
2582         * symmisc.c (dump_symtab_1): Make "b" const.
2583         (block_depth): Make "block" const.
2584         * d-exp.y (%union) <bval>: Remove.
2585         * cp-support.h (cp_lookup_rtti_type): Update.
2586         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
2587         * psymtab.c (psym_lookup_symbol): Make "block" const.
2588         (maintenance_check_psymtabs): Make "b" const.
2589         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
2590         (enumerate_locals, enumerate_args): Update.
2591         * python/py-symtab.c (stpy_global_block): Make "block" const.
2592         (stpy_static_block): Likewise.
2593         * inline-frame.c (block_starting_point_at): Make "new_block"
2594         const.
2595         * block.c (find_block_in_blockvector): Make return type const.
2596         (blockvector_for_pc_sect): Make "b" const.
2597         (find_block_in_blockvector): Make "b" const.
2598
2599 2019-03-23  Tom Tromey  <tom@tromey.com>
2600
2601         * varobj.c (varobj_create): Update.
2602         * symfile.c (clear_symtab_users): Don't reset innermost_block.
2603         * printcmd.c (display_command, do_one_display): Don't reset
2604         innermost_block.
2605         * parser-defs.h (enum innermost_block_tracker_type): Move to
2606         expression.h.
2607         (innermost_block): Update comment.
2608         * parse.c (parse_exp_1): Add tracker_types parameter.
2609         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
2610         tracker_types parameter.  Reset innermost_block.
2611         (parse_exp_in_context): Remove.
2612         (parse_expression_for_completion): Update.
2613         * objfiles.c (~objfile): Don't reset expression_context_block or
2614         innermost_block.
2615         * expression.h (enum innermost_block_tracker_type): Move from
2616         parser-defs.h.
2617         (parse_exp_1): Add tracker_types parameter.
2618         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
2619         reset innermost_block.
2620
2621 2019-03-23  Tom Tromey  <tom@tromey.com>
2622
2623         * objfiles.h: Include bcache.h.
2624
2625 2019-03-23  Tom Tromey  <tom@tromey.com>
2626
2627         * linespec.c (get_current_search_block): Use
2628         scoped_restore_current_language.
2629         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
2630
2631 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2632             Jiong Wang  <jiong.wang@arm.com>
2633
2634         * aarch64-linux-tdep.c
2635         (aarch64_linux_iterate_over_regset_sections): Check for pauth
2636         section.
2637         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
2638
2639 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2640             Jiong Wang  <jiong.wang@arm.com>
2641
2642         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
2643         instructions.
2644         (aarch64_analyze_prologue_test): Add PACIASP test.
2645         (aarch64_prologue_prev_register): Unmask PC value.
2646
2647 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2648             Jiong Wang  <jiong.wang@arm.com>
2649
2650         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
2651         (aarch64_dwarf2_prev_register): Unmask PC value.
2652         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
2653         (aarch64_execute_dwarf_cfa_vendor_op): Check for
2654         DW_CFA_AARCH64_negate_ra_state.
2655         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
2656
2657 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2658             Jiong Wang  <jiong.wang@arm.com>
2659
2660         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
2661         registers.
2662         (aarch64_pseudo_register_name): Likewise.
2663         (aarch64_pseudo_register_type): Likewise.
2664         (aarch64_pseudo_register_reggroup_p): Likewise.
2665         (aarch64_gdbarch_init): Add pauth registers.
2666         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
2667         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
2668         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
2669         (struct gdbarch_tdep): Add regnum for ra_state.
2670
2671 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2672             Jiong Wang  <jiong.wang@arm.com>
2673
2674         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
2675
2676 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2677             Jiong Wang  <jiong.wang@arm.com>
2678
2679         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
2680         function.
2681         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
2682         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
2683         (aarch64_gdbarch_init): Add puth registers.
2684         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
2685         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
2686         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
2687
2688 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2689             Jiong Wang  <jiong.wang@arm.com>
2690
2691         * aarch64-linux-nat.c
2692         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
2693         * aarch64-linux-tdep.c
2694         (aarch64_linux_core_read_description): Likewise.
2695         (aarch64_linux_get_hwcap): New function.
2696         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
2697         (aarch64_linux_get_hwcap): New declaration.
2698
2699 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2700             Jiong Wang  <jiong.wang@arm.com>
2701
2702         * aarch64-linux-nat.c
2703         (aarch64_linux_nat_target::read_description): Add pauth param.
2704         * aarch64-linux-tdep.c
2705         (aarch64_linux_core_read_description): Likewise.
2706         * aarch64-tdep.c (struct target_desc): Add in pauth.
2707         (aarch64_read_description): Add pauth param.
2708         (aarch64_gdbarch_init): Likewise.
2709         * aarch64-tdep.h (aarch64_read_description): Likewise.
2710         * arch/aarch64.c (aarch64_create_target_description): Likewise.
2711         * arch/aarch64.h (aarch64_create_target_description): Likewise.
2712         * features/Makefile: Add new files.
2713         * features/aarch64-pauth.c: New file.
2714         * features/aarch64-pauth.xml: New file.
2715
2716 2019-03-20  Tom Tromey  <tromey@adacore.com>
2717
2718         * infrun.c (handle_inferior_event): Rename from
2719         handle_inferior_event_1.  Create a scoped_value_mark.
2720         (handle_inferior_event): Remove.
2721
2722 2019-03-19  Tom Tromey  <tromey@adacore.com>
2723
2724         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
2725         * infrun.h (print_stop_event): Add "displays" parameter.
2726         * infrun.c (print_stop_event): Add "displays" parameter.
2727
2728 2019-03-19  Pedro Alves  <palves@redhat.com>
2729
2730         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
2731         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
2732         to -1.  Fix TABs vs spaces.
2733         (tui_ui_out::tui_ui_out): Don't initialize fields here.
2734         * tui/tui-out.h (tui_ui_out) Add intro comments.
2735         <m_line, m_start_of_line>: In-class initialize, and add describing
2736         comment.
2737
2738 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
2739
2740         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
2741         variable names.
2742         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
2743
2744 2019-03-18  Pedro Alves  <palves@redhat.com>
2745             Eli Zaretskii <eliz@gnu.org>
2746
2747         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
2748         m_line and m_start_of_line.
2749
2750 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
2751
2752         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
2753         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
2754         it returns a newline.  This fixes a regression in TU mode, whereby
2755         the next line is output on the same screen line as the user input.
2756
2757 2019-03-18  Tom Tromey  <tromey@adacore.com>
2758
2759         * minsyms.c (minimal_symbol_reader::install): Remove call to
2760         obstack_blank.
2761
2762 2019-03-18  Pedro Alves  <palves@redhat.com>
2763
2764         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
2765         New globals.
2766         (apply_style): New, factored out from ...
2767         (apply_ansi_escape): ... this.  Handle reverse video mode.
2768         (tui_set_reverse_mode): New function.
2769         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
2770         * tui/tui-winsource.c (tui_show_source_line): Use
2771         tui_set_reverse_mode instead of setting A_STANDOUT.
2772         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
2773         New setter methods.
2774
2775 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
2776
2777         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
2778         Handle tabs.
2779
2780 2019-03-18  Tom Tromey  <tromey@adacore.com>
2781
2782         * ada-lang.c (empty_array): Add "high" parameter.
2783         (ada_evaluate_subexp): Update.
2784
2785 2019-03-17  Sergei Trofimovich <siarheit@google.com>
2786
2787         * unittests/string_view-selftests.c: Define
2788         _initialize_string_view_selftests unconditionally.
2789
2790 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2791
2792         PR gdb/24350
2793         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
2794
2795 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2796
2797         PR gdb/24351
2798         * windows-nat.c (display_selector): Fix format specifiers.
2799
2800 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
2801
2802         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
2803         tui_refill_source_window instead of tui_refresh_win, to update the
2804         current execution line.  This fixes redisplay of the current line
2805         when stepping through the code with "next" or "step".
2806
2807 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2808
2809         * source-cache.c (source_cache::get_source_lines): Call
2810         find_source_lines to initialize s->nlines.  This fixes vertical
2811         scrolling of TUI source window when the DOWN arrow is pressed.
2812
2813 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2814
2815         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
2816         linux-thread-db.c (_initialize_thread_db): Likewise.
2817
2818 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2819
2820         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
2821         wclrtoeol in tui_show_source_line".  This reverts changes made in
2822         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
2823
2824 2019-03-15  Tom Tromey  <tom@tromey.com>
2825
2826         * symtab.h (struct minimal_symbol): Derive from
2827         general_symbol_info.
2828         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
2829         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
2830         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
2831         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
2832         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
2833         (MSYMBOL_SEARCH_NAME): Update.
2834         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
2835         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
2836         * minsyms.c (minimal_symbol_reader::record_full): Update.
2837
2838 2019-03-15  Tom Tromey  <tom@tromey.com>
2839
2840         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
2841
2842 2019-03-15  Tom Tromey  <tom@tromey.com>
2843
2844         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
2845         unique_xmalloc_ptr.
2846         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
2847         Update.
2848         * minsyms.c (lookup_minimal_symbol_by_pc_section)
2849         (build_minimal_symbol_hash_tables)
2850         (minimal_symbol_reader::install): Update.
2851
2852 2019-03-15  Tom Tromey  <tom@tromey.com>
2853
2854         * symtab.c (create_demangled_names_hash): Update.
2855         (symbol_set_names): Update.
2856         * objfiles.h (struct objfile_per_bfd_storage)
2857         <demangled_names_hash>: Now an htab_up.
2858         * objfiles.c (objfile_per_bfd_storage): Simplify.
2859
2860 2019-03-15  Tom Tromey  <tom@tromey.com>
2861
2862         * objfiles.h (struct objfile_per_bfd_storage): Declare
2863         destructor.
2864         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
2865         New.
2866         (get_objfile_bfd_data): Use new.  Don't initialize
2867         language_of_main.
2868         (free_objfile_per_bfd_storage): Remove.
2869         (objfile_bfd_data_free, objfile::~objfile): Use delete.
2870
2871 2019-03-15  Tom Tromey  <tom@tromey.com>
2872
2873         * symfile.c (reread_symbols): Update.
2874         * objfiles.c (objfile::objfile): Update.
2875         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
2876         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
2877         comment.
2878         (minimal_symbol_reader::install): Update.
2879         (terminate_minimal_symbol_table): Remove.
2880         * jit.c (jit_object_close_impl): Update.
2881
2882 2019-03-15  Tom Tromey  <tom@tromey.com>
2883
2884         * minsyms.c (minimal_symbol_reader::record_full): Remove some
2885         initializations.
2886
2887 2019-03-15  Tom Tromey  <tom@tromey.com>
2888
2889         * objfiles.h (struct objfile_per_bfd_storage)
2890         <demangled_hash_languages>: Now a bitset.
2891         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
2892         (lookup_minimal_symbol): Update.
2893
2894 2019-03-15  Tom Tromey  <tom@tromey.com>
2895
2896         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
2897         Don't return the symbol.
2898         * coffread.c (record_minimal_symbol): Use record_full.
2899
2900 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
2901
2902         The MS-Windows port of ncurses fails to switch to a color pair if
2903         one or both of the colors are the implicit default colors.  This
2904         change records the default colors when TUI is initialized, and
2905         then specifies them explicitly when a color pair uses the default
2906         colors.  This allows color styling in TUI mode on MS-Windows.
2907
2908         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
2909         ncurses_norm_attr.
2910         (tui_initialize_io) [__MINGW32__]: Record the default terminal
2911         colors in ncurses_norm_attr.
2912         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
2913         "none", replace it with the default color recorded in
2914         ncurses_norm_attr.
2915
2916 2019-03-14  Tom Tromey  <tromey@adacore.com>
2917
2918         * source-cache.h (class source_cache) <get_source_lines>: Return
2919         std::string.
2920         * source-cache.c (source_cache::extract_lines): Handle case where
2921         first_pos==npos.  Return std::string.
2922         (source_cache::get_source_lines): Update.
2923
2924 2019-03-14  Tom Tromey  <tromey@adacore.com>
2925
2926         * NEWS: Add item for "style sources" commands.
2927         * source-cache.c (source_cache::get_source_lines): Check
2928         source_styling.
2929         * cli/cli-style.c (source_styling): New global.
2930         (_initialize_cli_style): Add "style sources" commands.
2931         (show_style_sources): New function.
2932         * cli/cli-style.h (source_styling): Declare.
2933
2934 2019-03-14  Pedro Alves  <palves@redhat.com>
2935             Tom Tromey  <tromey@adacore.com>
2936
2937         * tui/tui-winsource.h (tui_refill_source_window): Declare.
2938         * tui/tui-winsource.c (tui_refill_source_window): New function,
2939         from...
2940         (tui_horizontal_source_scroll): ... here.  Move some logic.
2941         * cli/cli-style.c (set_style_enabled): Notify new observable.
2942         * tui/tui-hooks.c (tui_redisplay_source): New function.
2943         (tui_attach_detach_observers): Attach or detach
2944         tui_redisplay_source.
2945         * observable.h (source_styling_changed): New observable.
2946         * observable.c: Define source_styling_changed observable.
2947
2948 2019-03-13  Tom Tromey  <tromey@adacore.com>
2949
2950         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
2951         (i386_gnu_nat_target::store_registers): Update.
2952         * target-debug.h (target_debug_print_std_string): New macro.
2953         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2954         * windows-tdep.c (display_one_tib): Update.
2955         * tui/tui-stack.c (tui_make_status_line): Update.
2956         * top.c (print_inferior_quit_action): Update.
2957         * thread.c (thr_try_catch_cmd): Update.
2958         (add_thread_with_info): Update.
2959         (thread_target_id_str): Update.
2960         (thr_try_catch_cmd): Update.
2961         (thread_command): Update.
2962         (thread_find_command): Update.
2963         * record-btrace.c (record_btrace_target::info_record)
2964         (record_btrace_resume_thread, record_btrace_target::resume)
2965         (record_btrace_cancel_resume, record_btrace_step_thread)
2966         (record_btrace_target::wait, record_btrace_target::wait)
2967         (record_btrace_target::wait, record_btrace_target::stop): Update.
2968         * progspace.c (print_program_space): Update.
2969         * process-stratum-target.c
2970         (process_stratum_target::thread_address_space): Update.
2971         * linux-fork.c (linux_fork_mourn_inferior)
2972         (detach_checkpoint_command, info_checkpoints_command)
2973         (linux_fork_context): Update.
2974         (linux_fork_detach): Update.
2975         (class scoped_switch_fork_info): Update.
2976         (delete_checkpoint_command): Update.
2977         * infrun.c (follow_fork_inferior): Update.
2978         (follow_fork_inferior): Update.
2979         (proceed_after_vfork_done): Update.
2980         (handle_vfork_child_exec_or_exit): Update.
2981         (follow_exec): Update.
2982         (displaced_step_prepare_throw): Update.
2983         (displaced_step_restore): Update.
2984         (start_step_over): Update.
2985         (resume_1): Update.
2986         (clear_proceed_status_thread): Update.
2987         (proceed): Update.
2988         (print_target_wait_results): Update.
2989         (do_target_wait): Update.
2990         (context_switch): Update.
2991         (stop_all_threads): Update.
2992         (restart_threads): Update.
2993         (finish_step_over): Update.
2994         (handle_signal_stop): Update.
2995         (switch_back_to_stepped_thread): Update.
2996         (keep_going_pass_signal): Update.
2997         (print_exited_reason): Update.
2998         (normal_stop): Update.
2999         * inferior.c (inferior_pid_to_str): Change return type.
3000         (print_selected_inferior): Update.
3001         (add_inferior): Update.
3002         (detach_inferior): Update.
3003         * dummy-frame.c (fprint_dummy_frames): Update.
3004         * dcache.c (dcache_info_1): Update.
3005         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
3006         (btrace_fetch, btrace_clear): Update.
3007         * linux-tdep.c (linux_core_pid_to_str): Change return type.
3008         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
3009         type.
3010         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
3011         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
3012         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
3013         * gdbarch.c, gdbarch.h: Rebuild.
3014         * gdbarch.sh (core_pid_to_str): Change return type.
3015         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
3016         return type.
3017         (windows_nat_target::pid_to_str): Change return type.
3018         (windows_delete_thread): Update.
3019         (windows_nat_target::attach): Update.
3020         (windows_nat_target::files_info): Update.
3021         * target-delegates.c: Rebuild.
3022         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
3023         return type.
3024         (sol_thread_target::pid_to_str): Change return type.
3025         * remote.c (class remote_target) <pid_to_str>: Change return
3026         type.
3027         (remote_target::pid_to_str): Change return type.
3028         (extended_remote_target::attach, remote_target::remote_stop_ns)
3029         (remote_target::remote_notif_remove_queued_reply)
3030         (remote_target::push_stop_reply, remote_target::disable_btrace):
3031         Update.
3032         (extended_remote_target::attach): Update.
3033         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
3034         type.
3035         (gdbsim_target::pid_to_str): Change return type.
3036         * ravenscar-thread.c (struct ravenscar_thread_target)
3037         <pid_to_str>: Change return type.
3038         (ravenscar_thread_target::pid_to_str): Change return type.
3039         * procfs.c (class procfs_target) <pid_to_str>: Change return
3040         type.
3041         (procfs_target::pid_to_str): Change return type.
3042         (procfs_target::attach): Update.
3043         (procfs_target::detach): Update.
3044         (procfs_target::fetch_registers): Update.
3045         (procfs_target::store_registers): Update.
3046         (procfs_target::wait): Update.
3047         (procfs_target::files_info): Update.
3048         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
3049         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
3050         return type.
3051         (nto_procfs_target::pid_to_str): Change return type.
3052         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
3053         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
3054         return type.
3055         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
3056         (exit_lwp): Update.
3057         (attach_proc_task_lwp_callback, get_detach_signal)
3058         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
3059         (linux_nat_target::resume, wait_lwp, stop_callback)
3060         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
3061         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
3062         (linux_nat_wait_1, resume_stopped_resumed_lwps)
3063         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
3064         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
3065         type.
3066         (inf_ptrace_target::attach): Update.
3067         (inf_ptrace_target::files_info): Update.
3068         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
3069         type.
3070         (go32_nat_target::pid_to_str): Change return type.
3071         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
3072         (gnu_nat_target::wait): Update.
3073         (gnu_nat_target::wait): Update.
3074         (gnu_nat_target::resume): Update.
3075         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
3076         (fbsd_nat_target::wait): Update.
3077         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
3078         type.
3079         (darwin_nat_target::attach): Update.
3080         * corelow.c (class core_target) <pid_to_str>: Change return type.
3081         (core_target::pid_to_str): Change return type.
3082         * target.c (normal_pid_to_str): Change return type.
3083         (default_pid_to_str): Likewise.
3084         (target_pid_to_str): Change return type.
3085         (target_translate_tls_address): Update.
3086         (target_announce_detach): Update.
3087         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
3088         return type.
3089         (bsd_uthread_target::pid_to_str): Change return type.
3090         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
3091         type.
3092         (bsd_kvm_target::pid_to_str): Change return type.
3093         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
3094         return type.
3095         (aix_thread_target::pid_to_str): Change return type.
3096         * target.h (struct target_ops) <pid_to_str>: Change return type.
3097         (target_pid_to_str, normal_pid_to_str): Likewise.
3098         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
3099         type.
3100         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
3101         type.
3102         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
3103         return type.
3104         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
3105         type.
3106         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
3107         type.
3108         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3109         return type.
3110
3111 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3112
3113         * NEWS: Mention that the new default MI version is 3.  Mention
3114         changes to the output of commands and events that deal with
3115         multi-location breakpoints.
3116         * breakpoint.c: Include "mi/mi-out.h".
3117         (print_one_breakpoint): Change output syntax if using MI version
3118         >= 3.
3119         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3120         New.
3121         (mi_multi_location_breakpoint_output_fixed): New.
3122         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3123         (mi_cmd_fix_multi_location_breakpoint_output): New.
3124         (mi_multi_location_breakpoint_output_fixed): New.
3125         * mi/mi-cmds.c (mi_cmds): Register command
3126         -fix-multi-location-breakpoint-output.
3127         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3128         interpreter "mi".
3129
3130 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3131
3132         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3133         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3134         instantiate mi_ui_out based on interpreter name.
3135         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3136         * mi/mi-main.c (mi_load_progress): Likewise.
3137
3138 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3139
3140         * NEWS: Combine separate "New targets" sections for 8.3.
3141
3142 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3143
3144         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3145         (ppcfbsd_init_abi): Install gdbarch
3146         "fetch_tls_load_module_address" and "get_thread_local_address"
3147         methods.
3148
3149 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3150
3151         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3152         (riscv_fbsd_init_abi): Install gdbarch
3153         "fetch_tls_load_module_address" and "get_thread_local_address"
3154         methods.
3155
3156 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3157
3158         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3159         (i386fbsd_init_abi): Install gdbarch
3160         "fetch_tls_load_module_address" and "get_thread_local_address"
3161         methods.
3162
3163 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3164
3165         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3166         (amd64fbsd_init_abi): Install gdbarch
3167         "fetch_tls_load_module_address" and "get_thread_local_address"
3168         methods.
3169
3170 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3171
3172         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3173         (struct fbsd_pspace_data): New type.
3174         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3175         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3176         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3177         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3178         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3179
3180 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3181
3182         * gdbtypes.c (lookup_struct_elt): New function.
3183         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3184         * gdbtypes.h (struct struct_elt): New type.
3185         (lookup_struct_elt): New prototype.
3186
3187 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3188
3189         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3190         remove disabled code block.
3191
3192 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3193
3194         * gdbarch.sh (get_thread_local_address): New method.
3195         * gdbarch.h, gdbarch.c: Regenerate.
3196         * target.c (target_translate_tls_address): Use
3197         gdbarch_get_thread_local_address if present instead of
3198         target::get_thread_local_address.
3199
3200 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3201
3202         * target.h (target::get_thread_local_address): Update comment.
3203
3204 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3205
3206         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3207         objfile->separate_debug_objfile_backlink if not NULL.
3208
3209 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3210
3211         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3212         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3213         (amd64bsd_store_inferior_registers): Likewise.
3214         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3215         Enable segment base registers.
3216         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3217         PT_GETFSBASE and PT_GETGSBASE.
3218         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3219         PT_SETGSBASE.
3220         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3221         segment base registers.
3222         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3223
3224 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3225
3226         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3227         Update calls to i386_target_description to add 'segments'
3228         parameter.
3229         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3230         add segment base registers.
3231         * arch/i386.c (i386_create_target_description): Add 'segments'
3232         parameter to enable segment base registers.
3233         * arch/i386.h (i386_create_target_description): Likewise.
3234         * features/i386/32bit-segments.xml: New file.
3235         * features/i386/32bit-segments.c: Generate.
3236         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3237         call to i386_target_description to add 'segments' parameter.
3238         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3239         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3240         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3241         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3242         if feature is present.
3243         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3244         Add 'segments' parameter to call to i386_target_description.
3245         (i386_target_description): Add 'segments' parameter to enable
3246         segment base registers.
3247         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3248         to call to i386_target_description.
3249         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3250         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3251         Define I386_NUM_REGS.
3252         (i386_target_description): Add 'segments' parameter to enable
3253         segment base registers.
3254
3255 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3256
3257         PR/24325
3258         * source-cache.c: #undef open and close, to avoid unresolved
3259         externals during linking.
3260
3261 2019-03-12  Tom Tromey  <tromey@adacore.com>
3262
3263         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3264         const.  Add initializers.
3265         (_initialize_remote): Don't initialize ptid globals.
3266
3267 2019-03-12  Pedro Alves  <palves@redhat.com>
3268
3269         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3270
3271 2019-03-12  Pedro Alves  <palves@redhat.com>
3272
3273         * cp-name-parser.y (main): Remove unused 'len' variable.
3274
3275 2019-03-12  Tom Tromey  <tromey@adacore.com>
3276
3277         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3278         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3279
3280 2019-03-12  Tom Tromey  <tromey@adacore.com>
3281
3282         * linux-nat.c (iterate_over_lwps): Update.
3283         (stop_callback): Remove parameter.
3284         (stop_wait_callback, detach_callback, resume_set_callback)
3285         (select_singlestep_lwp_callback, set_ignore_sigint)
3286         (status_callback, resumed_callback, resume_clear_callback)
3287         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3288         data parameter.
3289         (linux_nat_target::detach, linux_nat_target::resume)
3290         (linux_stop_and_wait_all_lwps, select_event_lwp)
3291         (linux_nat_filter_event, linux_nat_wait_1)
3292         (linux_nat_target::kill, linux_nat_target::stop)
3293         (linux_nat_target::stop): Update.
3294         (linux_nat_resume_callback): Change type.
3295         (resume_stopped_resumed_lwps, count_events_callback)
3296         (select_event_lwp_callback): Likewise.
3297         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3298         * arm-linux-nat.c (struct update_registers_data): Remove.
3299         (update_registers_callback): Change type.
3300         (arm_linux_insert_hw_breakpoint1): Update.
3301         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3302         parameter.
3303         (x86_linux_dr_set_addr): Update.
3304         (x86_linux_dr_set_control): Update.
3305         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3306         (iterate_over_lwps): Use gdb::function_view.
3307         * nat/aarch64-linux-hw-point.c (struct
3308         aarch64_dr_update_callback_param): Remove.
3309         (debug_reg_change_callback): Change type.
3310         (aarch64_notify_debug_reg_change): Update.
3311         * s390-linux-nat.c (s390_refresh_per_info): Update.
3312
3313 2019-03-11  Tom Tromey  <tromey@adacore.com>
3314
3315         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3316         redundant assignment to "this_cu".
3317
3318 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3319
3320         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3321
3322 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3323
3324         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3325         from...
3326         (rank_one_type): ... this.
3327
3328 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3329
3330         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3331         from...
3332         (rank_one_type): ... this.
3333
3334 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3335
3336         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3337         from...
3338         (rank_one_type): ... this.
3339
3340 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3341
3342         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3343         from...
3344         (rank_one_type): ... this.
3345
3346 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3347
3348         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3349         from...
3350         (rank_one_type): ... this.
3351
3352 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3353
3354         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3355         from...
3356         (rank_one_type): ... this.
3357
3358 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3359
3360         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3361         from...
3362         (rank_one_type): ... this.
3363
3364 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3365
3366         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3367         from...
3368         (rank_one_type): ... this.
3369
3370 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3371
3372         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3373         from...
3374         (rank_one_type): ... this.
3375
3376 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3377
3378         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3379         from...
3380         (rank_one_type): ... this.
3381
3382 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3383
3384         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3385         from...
3386         (rank_one_type): ... this.
3387
3388 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3389
3390         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3391         from...
3392         (rank_one_type): ... this.
3393
3394 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3395
3396         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3397         inferior-events' shows the example events.
3398
3399 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3400
3401         Support styling on native MS-Windows console
3402
3403         PR/24315
3404         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3405         on MS-Windows if $TERM is not defined.
3406
3407         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3408
3409         * posix-hdep.c (gdb_console_fputs):
3410         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3411         functions.
3412         * ui-file.h (gdb_console_fputs): Add prototype.
3413
3414         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3415         back to fputs only if the former returns zero.
3416
3417 2019-03-07  Tom Tromey  <tom@tromey.com>
3418
3419         * symmisc.c (print_symbol_bcache_statistics): Update.
3420         (print_objfile_statistics): Update.
3421         * symfile.c (allocate_symtab): Update.
3422         * stabsread.c: Don't include bcache.h.
3423         * psymtab.h (struct psymbol_bcache): Don't declare.
3424         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3425         (psymbol_bcache_init, psymbol_bcache_free)
3426         (psymbol_bcache_get_bcache): Don't declare.
3427         * psymtab.c (struct psymbol_bcache): Remove.
3428         (psymtab_storage::psymtab_storage): Update.
3429         (psymtab_storage::~psymtab_storage): Update.
3430         (psymbol_bcache_init, psymbol_bcache_free)
3431         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3432         (add_psymbol_to_bcache): Update.
3433         (allocate_psymtab): Update.
3434         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3435         macro_cache>: No longer pointers.
3436         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3437         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3438         * macrotab.c (macro_bcache): Update.
3439         * macroexp.c: Don't include bcache.h.
3440         * gdbtypes.c (check_types_worklist): Update.
3441         (types_deeply_equal): Remove TRY/CATCH.  Update.
3442         * elfread.c (elf_symtab_read): Update.
3443         * dwarf2read.c: Don't include bcache.h.
3444         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3445         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3446         (print_bcache_statistics, bcache_memory_used): Don't declare.
3447         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3448         methods.  Rename all data members.
3449         * bcache.c (struct bcache): Move to bcache.h.
3450         (bcache::expand_hash_table): Rename from expand_hash_table.
3451         (bcache): Remove.
3452         (bcache::insert): Rename from bcache_full.
3453         (bcache::compare): Rename from bcache_compare.
3454         (bcache_xmalloc): Remove.
3455         (bcache::~bcache): Rename from bcache_xfree.
3456         (bcache::print_statistics): Rename from print_bcache_statistics.
3457         (bcache::memory_used): Rename from bcache_memory_used.
3458
3459 2019-03-07  Pedro Alves  <palves@redhat.com>
3460
3461         * infrun.c (normal_stop): Also check for
3462         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3463
3464 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3465
3466         * f-lang.c (value_from_host_double): Moved to...
3467         * value.c (value_from_host_double): ...here.
3468         * value.h (value_from_host_double): Declare.
3469         * guile/scm-math.c (vlscm_convert_typed_number): Use
3470         value_from_host_double.
3471         (vlscm_convert_number): Likewise.
3472         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3473         * python/py-value.c (convert_value_from_python): Likewise.
3474
3475 2019-03-06  Tom Tromey  <tom@tromey.com>
3476
3477         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3478
3479 2019-03-06  Tom Tromey  <tom@tromey.com>
3480
3481         * utils.h (free_current_contents): Don't declare.
3482         * utils.c (free_current_contents): Remove.
3483
3484 2019-03-06  Tom Tromey  <tom@tromey.com>
3485
3486         * top.c (quit_force): Update.
3487         * main.c (captured_command_loop): Update.
3488         * common/new-op.c (operator new): Update.
3489         * common/common-exceptions.c (struct catcher)
3490         <save_cleanup_chain>: Remove member.
3491         (exceptions_state_mc_init): Update.
3492         (exception_try_scope_entry): Return nullptr.
3493         (exception_try_scope_exit, exception_rethrow)
3494         (throw_exception_sjlj, throw_exception_cxx): Update.
3495         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3496         (all_cleanups, do_cleanups, discard_cleanups)
3497         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3498         (restore_cleanups, restore_final_cleanups): Don't declare.
3499         (do_final_cleanups): Remove parameter.
3500         * common/cleanups.c (cleanup_chain, make_cleanup)
3501         (make_cleanup_dtor, all_cleanups, do_cleanups)
3502         (discard_my_cleanups, discard_cleanups)
3503         (discard_final_cleanups, save_my_cleanups, save_cleanups)
3504         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
3505         (null_cleanup): Remove.
3506         (do_final_cleanups): Remove parameter.
3507
3508 2019-03-06  Tom Tromey  <tom@tromey.com>
3509
3510         * remote.c (remote_target::remote_parse_stop_reply): Use
3511         unique_xmalloc_ptr.
3512
3513 2019-03-06  Tom Tromey  <tom@tromey.com>
3514
3515         * stabsread.c (struct stabs_field_info): Rename from field_info.
3516         <list, fnlist>: Add initializers.
3517         <obstack>: New member.
3518         (read_member_functions, read_struct_fields, read_baseclasses):
3519         Allocate on obstack.  Don't use cleanups.
3520         (read_one_struct_field, read_member_functions, read_struct_fields)
3521         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
3522         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
3523         (read_struct_type): Update.
3524
3525 2019-03-06  Tom Tromey  <tom@tromey.com>
3526
3527         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
3528         * common/filestuff.h (make_cleanup_close): Don't declare.
3529         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
3530         Remove.
3531
3532 2019-03-06  Tom Tromey  <tom@tromey.com>
3533
3534         * solib-aix.c: Use make_scope_exit.
3535
3536 2019-03-06  Tom Tromey  <tom@tromey.com>
3537
3538         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
3539         Use make_scope_exit.
3540
3541 2019-03-06  Tom Tromey  <tom@tromey.com>
3542
3543         * solib-svr4.c (disable_probes_interface): Remove parameter.
3544         (svr4_handle_solib_event): Use make_scope_exit.
3545
3546 2019-03-06  Tom Tromey  <tom@tromey.com>
3547
3548         * remote.c (struct stop_reply_deleter): Remove.
3549         (stop_reply_up): Update.
3550         (struct stop_reply): Derive from notif_event.  Don't typedef.
3551         <regcache>: Now a std::vector.
3552         (stop_reply_xfree): Remove.
3553         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
3554         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
3555         (remote_target::discard_pending_stop_replies): Use delete.
3556         (remote_target::remote_parse_stop_reply): Update.
3557         (remote_target::process_stop_reply): Update.
3558         * remote-notif.h (struct notif_event): Add virtual destructor.
3559         Remove "dtr" member.
3560         (struct notif_client) <alloc_event>: Return a unique_ptr.
3561         (notif_event_xfree): Don't declare.
3562         (notif_event_up): New typedef.
3563         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
3564         (notif_event_xfree, do_notif_event_xfree): Remove.
3565         (remote_notif_state_xfree): Update.
3566
3567 2019-03-06  Tom Tromey  <tom@tromey.com>
3568
3569         * infrun.c (displaced_step_clear_cleanup): Now a
3570         forward_scope_exit type.
3571         (displaced_step_prepare_throw): Update.
3572         (displaced_step_fixup): Update.
3573
3574 2019-03-06  Tom Tromey  <tom@tromey.com>
3575
3576         * inferior.h (class inferior): Update comment.
3577         * gdbthread.h (class thread_info): Update comment.
3578
3579 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
3580             Tom Tromey  <tom@tromey.com>
3581
3582         * stabsread.h (struct stab_section_list): Remove.
3583         (coffstab_build_psymtabs): Update.
3584         * dbxread.c (symbuf_sections): Now a std::vector.
3585         (sect_idx): New global.
3586         (fill_symbuf): Update.
3587         (coffstab_build_psymtabs): Change type of stabsects parameter.
3588         Update.
3589         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
3590         std::vector.
3591         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
3592         (coff_locate_sections): Update.
3593         (coff_symfile_read): Remove cleanups.  Update.
3594         (init_stringtab): Add storage parameter.
3595         (free_stringtab, free_stringtab_cleanup): Remove.
3596         (init_lineno): Add storage parameter.
3597         (free_linetab, free_linetab_cleanup): Remove.
3598
3599 2019-03-06  Pedro Alves  <palves@redhat.com>
3600
3601         * linux-fork.c (fork_info::clobber_regs): Delete.
3602         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
3603         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
3604         comment.  Adjust.
3605         (scoped_switch_fork_info::scoped_switch_fork_info)
3606         (checkpoint_command, linux_fork_context): Adjust
3607         fork_save_infrun_state calls.
3608
3609 2019-03-06  Pedro Alves  <palves@redhat.com>
3610
3611         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
3612         (inf_has_multiple_threads): Return 'bool' and rewrite using
3613         inferior_info::threads().
3614
3615 2019-03-06  Pedro Alves  <palves@redhat.com>
3616
3617         * linux-fork.c: Include <list>.
3618         (fork_list): Now a std::list instance.
3619         (fork_info): Add ctor, dtor, and in-class initialize all fields.
3620         (forks_exist_p, find_last_fork): Adjust.
3621         (new_fork): Delete.
3622         (one_fork_p): New.
3623         (add_fork): Adjust.
3624         (free_fork): Delete, folded into fork_info::~fork_info().
3625         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
3626         Adjust.
3627         (init_fork_list): Delete.
3628         (linux_fork_killall, linux_fork_mourn_inferior)
3629         (linux_fork_detach, info_checkpoints_command): Adjust.
3630         (_initialize_linux_fork): No longer call init_fork_list.
3631
3632 2019-03-06  Pedro Alves  <palves@redhat.com>
3633
3634         * linux-fork.c (new_fork): New, split out of ...
3635         (add_fork): ... this.  Return void.  Move "first fork" special
3636         case from here, to ...
3637         (checkpoint_command): ... here.
3638         * linux-linux.h (add_fork): Return void.
3639
3640 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3641
3642         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
3643
3644 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3645             Chris January  <chris.january@arm.com>
3646             David Lecomber  <david.lecomber@arm.com>
3647
3648         * f-exp.y: New token, UNOP_INTRINSIC.
3649         (exp): New pattern using UNOP_INTRINSIC token.
3650         (f77_keywords): Add 'abs' keyword.
3651         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
3652         (value_from_host_double): New function.
3653         (evaluate_subexp_f): Support UNOP_ABS.
3654
3655 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3656
3657         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
3658         types.
3659
3660 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3661
3662         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
3663         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
3664         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
3665
3666 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3667
3668         * f-exp.y (convert_to_kind_type): Handle more type kinds.
3669
3670 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3671             Chris January  <chris.january@arm.com>
3672
3673         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
3674         * f-exp.y: Define 'KIND' token.
3675         (exp): New pattern for KIND expressions.
3676         (ptype): Handle types with a kind extension.
3677         (direct_abs_decl): Extend to spot kind extensions.
3678         (f77_keywords): Add 'kind' to the list.
3679         (push_kind_type): New function.
3680         (convert_to_kind_type): New function.
3681         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
3682         * parse.c (operator_length_standard): Likewise.
3683         * parser-defs.h (enum type_pieces): Add tp_kind.
3684         * std-operator.def: Add UNOP_KIND.
3685
3686 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3687
3688         * f-exp.y (f_parse): Set yydebug.
3689
3690 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3691
3692         * f-lang.c (evaluate_subexp_f): New function.
3693         (exp_descriptor_f): New global.
3694         (f_language_defn): Use exp_descriptor_f instead of
3695         exp_descriptor_standard.
3696
3697 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3698
3699         * f-exp.y (struct token): Add comments.
3700         (dot_ops): Remove uppercase versions and the end marker.
3701         (f77_keywords): Likewise.
3702         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
3703         entries in the dot_ops array are case insensitive, and use
3704         strncasecmp to compare strings.  Also some whitespace cleanup in
3705         this area.  Similar for the f77_keywords array, except entries in
3706         this list might be case sensitive.
3707
3708 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3709
3710         * f-exp.y (struct f77_boolean_val): Add comments.
3711         (boolean_values): Remove uppercase versions, and end marker.
3712         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
3713         and use strncasecmp to achieve case insensitivity.  Additionally,
3714         perform whitespace cleanup around this code.
3715
3716 2019-03-06  Tom Tromey  <tromey@adacore.com>
3717
3718         * remote-sim.c (gdbsim_target_open): Use result of
3719         gdb_argv::release.
3720
3721 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
3722         Dirk Schubert  <dirk.schubert@arm.com>
3723         Chris January  <chris.january@arm.com>
3724
3725         * eval.c (evaluate_subexp_standard): Call Fortran argument
3726         wrapping logic.
3727         * f-lang.c (struct value): A value which can be passed into a
3728         Fortran function call.
3729         (fortran_argument_convert): Wrap Fortran arguments in a pointer
3730         where appropriate.
3731         (struct type): Value ready for a Fortran function call.
3732         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
3733         is needed.
3734         * f-lang.h (fortran_argument_convert): Declaration.
3735         (fortran_preserve_arg_pointer): Declaration.
3736         * infcall.c (value_arg_coerce): Call Fortran argument logic.
3737
3738 2019-03-05  Tom Tromey  <tromey@adacore.com>
3739
3740         * python/py-prettyprint.c (print_string_repr): Remove #if.
3741         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
3742
3743 2019-03-05  Tom Tromey  <tromey@adacore.com>
3744
3745         * target.c (the_dummy_target): Move later.  Change type to
3746         "dummy_target".
3747         (initialize_targets): Don't initialize the_dummy_target.
3748
3749 2019-03-05  Tom Tromey  <tromey@adacore.com>
3750
3751         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
3752         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
3753
3754 2019-03-05  Tom Tromey  <tromey@adacore.com>
3755
3756         * windows-nat.c (windows_nat_target::attach)
3757         (windows_nat_target::detach): Don't call gdb_flush.
3758         * valprint.c (generic_val_print, val_print, val_print_string):
3759         Don't call gdb_flush.
3760         * utils.c (defaulted_query): Don't call gdb_flush.
3761         * typeprint.c (print_type_scalar): Don't call gdb_flush.
3762         * target.c (target_announce_detach): Don't call gdb_flush.
3763         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
3764         * remote.c (extended_remote_target::attach): Don't call
3765         gdb_flush.
3766         * procfs.c (procfs_target::detach): Don't call gdb_flush.
3767         * printcmd.c (do_examine): Don't call gdb_flush.
3768         (info_display_command): Don't call gdb_flush.
3769         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
3770         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
3771         * memattr.c (info_mem_command): Don't call gdb_flush.
3772         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
3773         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
3774         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
3775         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
3776         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
3777         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
3778         (gnu_nat_target::detach): Don't call gdb_flush.
3779         * f-valprint.c (f_val_print): Don't call gdb_flush.
3780         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
3781         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
3782         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
3783         gdb_flush.
3784         * c-valprint.c (c_val_print): Don't call gdb_flush.
3785         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
3786
3787 2019-03-05  Tom Tromey  <tromey@adacore.com>
3788
3789         * varobj.c (update_dynamic_varobj_children): Update.
3790         (install_default_visualizer): Use reset, not release.
3791         * value.c (set_internalvar): Update.
3792         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
3793         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
3794         ATTRIBUTE_UNUSED_RESULT.
3795
3796 2019-03-05  Tom Tromey  <tromey@adacore.com>
3797
3798         * remote.c (class scoped_remote_fd) <release>: Add
3799         ATTRIBUTE_UNUSED_RESULT.
3800
3801 2019-03-05  Tom Tromey  <tromey@adacore.com>
3802
3803         * macroexp.c (struct macro_buffer) <release>: Add
3804         ATTRIBUTE_UNUSED_RESULT.
3805
3806 2019-03-05  Tom Tromey  <tromey@adacore.com>
3807
3808         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
3809         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
3810         ATTRIBUTE_UNUSED_RESULT.
3811
3812 2019-03-05  Tom Tromey  <tromey@adacore.com>
3813
3814         * common/scoped_fd.h (class scoped_fd) <release>: Add
3815         ATTRIBUTE_UNUSED_RESULT.
3816
3817 2019-03-05  Tom Tromey  <tromey@adacore.com>
3818
3819         * parser-defs.h (struct parser_state) <release>: Add
3820         ATTRIBUTE_UNUSED_RESULT.
3821
3822 2019-03-05  Tom Tromey  <tromey@adacore.com>
3823
3824         * utils.h (class gdb_argv) <release>: Add
3825         ATTRIBUTE_UNUSED_RESULT.
3826         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
3827
3828 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
3829
3830         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
3831         for-loop range, to avoid compiler warnings.
3832
3833         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
3834         avoid compiler warnings about unused variables.
3835
3836         * NEWS: Mention end of support for native debugging on MS-Windows
3837         before XP.
3838
3839         PR gdb/24292
3840         * common/netstuff.c:
3841         * gdbserver/gdbreplay.c
3842         * gdbserver/remote-utils.c:
3843         * ser-tcp.c:
3844         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
3845         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
3846         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
3847         'getaddrinfo' and 'freeaddrinfo' were not available before
3848         Windows XP, and mingw.org's MinGW headers by default define
3849         _WIN32_WINNT to 0x500.
3850
3851 2019-03-01  Gary Benson <gbenson@redhat.com>
3852
3853         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
3854
3855 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
3856             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3857
3858         PR gdb/8527
3859         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
3860         set_sigint_trap, clear_sigint_trap.
3861
3862 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3863
3864         * target.c (target_detach): Clear the regcache and the
3865         frame cache.
3866
3867 2019-02-27  Pedro Alves  <palves@redhat.com>
3868
3869         * utils.c (set_screen_size): When we cap the height/width sizes,
3870         tweak the corresponding command variable to show "unlimited":
3871
3872 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
3873             Pedro Alves  <palves@redhat.com>
3874
3875         * utils.c (set_screen_size): Reduce "infinite" rows and columns
3876         before calling rl_set_screen_size.
3877
3878 2019-02-27  Tom Tromey  <tromey@adacore.com>
3879
3880         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
3881         define.
3882         * python/py-value.c: Remove Python 2.4 workaround.
3883         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
3884         workaround.
3885         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
3886         Python 2.4 workaround.
3887         * python/python-internal.h: Remove Python 2.4 comment.
3888         (Py_ssize_t): Don't define.
3889         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
3890         (gdb_Py_DECREF): Remove Python 2.4 workaround.
3891         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
3892         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
3893         * python/python.c (do_start_initialization): Remove Python 2.4
3894         workaround.
3895         * python/py-prettyprint.c (class dummy_python_frame): Remove.
3896         (print_children): Remove Python 2.4 workaround.
3897         * python/py-inferior.c (buffer_procs): Remove Python 2.4
3898         workaround.
3899         (CHARBUFFERPROC_NAME): Remove.
3900         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
3901         Python 2.4 workaround.
3902
3903 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3904
3905         * NEWS: Note minimum Python version.
3906
3907 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3908
3909         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
3910         code from these functions.  Remove corresponding ifdefs.  Use
3911         Py_buffer_up instead of explicit calls to PyBuffer_Release.
3912         Remove gotos and target of gotos.
3913         (infpy_search_memory): Likewise.
3914
3915 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3916
3917         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
3918         (hppa_gdbarch_init): Don't register deleted functions with
3919         gdbarch.
3920
3921 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3922
3923         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
3924         (h8300_unwind_sp): Delete.
3925         (h8300_dummy_id): Delete.
3926         (h8300_gdbarch_init): Don't register deleted functions with
3927         gdbarch.
3928
3929 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3930
3931         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
3932         (ft32_unwind_pc): Delete.
3933         (ft32_unwind_sp): Delete.
3934         (ft32_gdbarch_init): Don't register deleted functions with
3935         gdbarch.
3936
3937 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3938
3939         * gdb/frv-tdep.c (frv_dummy_id): Delete.
3940         (frv_unwind_pc): Delete.
3941         (frv_unwind_sp): Delete.
3942         (frv_gdbarch_init): Don't register deleted functions with
3943         gdbarch.
3944
3945 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3946
3947         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
3948         (riscv_unwind_pc): Delete.
3949         (riscv_unwind_sp): Delete.
3950         (riscv_gdbarch_init): Don't register deleted functions with
3951         gdbarch.
3952
3953 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3954
3955         * gdb/csky-tdep.c (csky_dummy_id): Delete.
3956         (csky_unwind_pc): Delete.
3957         (csky_unwind_sp): Delete.
3958         (csky_gdbarch_init): Don't register deleted functions with
3959         gdbarch.
3960
3961 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3962
3963         * gdb/cris-tdep.c (cris_dummy_id): Delete.
3964         (cris_unwind_pc): Delete.
3965         (cris_unwind_sp): Delete.
3966         (cris_gdbarch_init): Don't register deleted functions with
3967         gdbarch.
3968
3969 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3970
3971         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
3972         (bfin_unwind_pc): Delete.
3973         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
3974
3975 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3976
3977         * gdb/arm-tdep.c (arm_dummy_id): Delete.
3978         (arm_unwind_pc): Delete.
3979         (arm_unwind_sp): Delete.
3980         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
3981
3982 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3983
3984         * gdb/arc-tdep.c (arc_dummy_id): Delete.
3985         (arc_unwind_pc): Delete.
3986         (arc_unwind_sp): Delete.
3987         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
3988
3989 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3990
3991         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
3992         (alpha_unwind_pc): Delete.
3993         (alpha_gdbarch_init): Don't register deleted functions with
3994         gdbarch.
3995
3996 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3997
3998         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
3999         (aarch64_unwind_pc): Delete.
4000         (aarch64_unwind_sp): Delete.
4001         (aarch64_gdbarch_init): Don't register deleted functions with
4002         gdbarch.
4003
4004 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4005
4006         * gdbtypes.c (type_align): Don't consider static members when
4007         computing structure alignment.
4008
4009 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4010
4011         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
4012         return 0 for other types.
4013         * arch-utils.c (default_type_align): Always return 0.
4014         * gdbarch.h: Regenerate.
4015         * gdbarch.sh (type_align): Extend comment.
4016         * gdbtypes.c (type_align): Add additional comments, always call
4017         gdbarch_type_align before applying the default rules.
4018         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
4019         generic code will then apply a suitable default.
4020         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
4021         types, return 0 for other types.
4022
4023 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4024
4025         * NEWS: Create a new section for the next release branch.
4026         Rename the section of the current branch, now that it has
4027         been cut.
4028
4029 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4030
4031         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
4032         * version.in: Bump version to 8.3.50.DATE-git.
4033
4034 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
4035
4036         * aix-thread.c (ptid_cmp): Remove unused variable.
4037         (get_signaled_thread): Likewise.
4038         (store_regs_user_thread): Likewise.
4039         (store_regs_kernel_thread): Likewise.
4040         (fetch_regs_kernel_thread): Remove shadowed variable.
4041
4042 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4043
4044         * features/riscv/32bit-cpu.xml: Add register numbers.
4045         * features/riscv/32bit-fpu.c: Regenerate.
4046         * features/riscv/32bit-fpu.xml: Add register numbers.
4047         * features/riscv/64bit-cpu.xml: Add register numbers.
4048         * features/riscv/64bit-fpu.c: Regenerate.
4049         * features/riscv/64bit-fpu.xml: Add register numbers.
4050
4051 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
4052
4053         * NEWS: Mention two argument form of gdb.Value constructor.
4054         * python/py-value.c (convert_buffer_and_type_to_value): New
4055         function.
4056         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
4057         Add support for handling an optional second argument.  Call
4058         convert_buffer_and_type_to_value as appropriate.
4059         * python/python-internal.h (Py_buffer_deleter): New struct.
4060         (Py_buffer_up): New typedef.
4061
4062 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
4063
4064         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
4065         instead of releasing ownership.
4066
4067 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
4068
4069         * dwarf2read.c (open_and_init_dwp_file): Call
4070         elf_numsections instead of bfd_count_sections to initialize
4071         dwp_file->num_sections.
4072
4073 2019-02-25  Tom Tromey  <tromey@adacore.com>
4074
4075         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
4076
4077 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4078
4079         * gcore.in: Add '--readnever' option when invoking GDB.
4080
4081 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4082
4083         * MAINTAINERS: Update my email address.
4084
4085 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4086
4087         * build-id.c (build_id_to_debug_bfd_1): New function.
4088         (build_id_to_debug_bfd): Look for separate debug file in
4089         sysroot.
4090
4091 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4092
4093         * gdbarch.sh: Update the copyright year range that is placed into
4094         generated files.
4095
4096 2019-02-22  Keith Seitz  <keiths@redhat.com>
4097
4098         PR symtab/23853
4099         * linespec.c (create_sals_line_offset): Search for the default
4100         symtab's filename instead of its fullname.
4101
4102 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4103
4104         * NEWS: Update style defaults.
4105
4106 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4107
4108         * main.c (captured_main_1): Disable styling in batch mode.
4109
4110 2019-02-20  Tom Tromey  <tom@tromey.com>
4111
4112         * symtab.c (symtab_symbol_info): Fix typos.
4113
4114 2019-02-20  Tom Tromey  <tromey@adacore.com>
4115
4116         * findcmd.c (_initialize_mem_search): Use upper case for
4117         metasyntactic variables.
4118
4119 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4120
4121         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4122         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4123
4124 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4125
4126         * top.h (source_file_name): Change to std::string.
4127         * top.c (source_file_name): Likewise.
4128         (command_line_input): Adjust.
4129         * cli/cli-script.c (script_from_file): Adjust.
4130
4131 2019-02-19  Tom Tromey  <tromey@adacore.com>
4132
4133         * ravenscar-thread.c
4134         (ravenscar_thread_target::update_thread_list): Don't call
4135         ada_build_task_list.
4136         * ada-lang.h (ada_build_task_list): Don't declare.
4137         * ada-tasks.c (struct ada_tasks_inferior_data)
4138         <task_list_valid_p>: Now bool.
4139         (read_known_tasks, ada_task_list_changed)
4140         (ada_tasks_invalidate_inferior_data): Update.
4141         (read_known_tasks_array): Return bool.
4142         (read_known_tasks_list): Likewise.
4143         (read_known_tasks): Return void.
4144         (ada_build_task_list): Now static.
4145
4146 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4147
4148         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4149         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4150
4151 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4152
4153         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4154         variant for ada_tasks_pspace_data_handle and
4155         ada_tasks_inferior_data_handle.
4156         (ada_tasks_pspace_data_cleanup): New function.
4157         (ada_tasks_inferior_data_cleanup): New function.
4158
4159 2019-02-17  Tom Tromey  <tom@tromey.com>
4160
4161         * macrotab.h (macro_source_fullname): Return a std::string.
4162         * macrotab.c (macro_include, check_for_redefinition)
4163         (macro_undef, macro_lookup_definition, foreach_macro)
4164         (foreach_macro_in_scope): Update.
4165         (macro_source_fullname): Return a std::string.
4166         * macrocmd.c (show_pp_source_pos): Update.
4167
4168 2019-02-17  Tom Tromey  <tom@tromey.com>
4169
4170         * macrocmd.c (show_pp_source_pos): Style the file names.
4171
4172 2019-02-17  Tom Tromey  <tom@tromey.com>
4173
4174         PR tui/24197:
4175         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4176
4177 2019-02-17  Tom Tromey  <tom@tromey.com>
4178
4179         * ada-lang.c (user_select_syms): Use filtered printing.
4180         * utils.c (wrap_style): New global.
4181         (desired_style): Remove.
4182         (emit_style_escape): Add stream parameter.
4183         (set_output_style, reset_terminal_style, prompt_for_continue):
4184         Update.
4185         (flush_wrap_buffer): Only flush gdb_stdout.
4186         (wrap_here): Set wrap_style.
4187         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4188         treat escape sequences as a character.  Change when wrap buffer is
4189         flushed.
4190         (fputs_styled): Do not set the output style when the default is
4191         requested.
4192         * ui-style.h (struct ui_file_style) <is_default>: New method.
4193         * source.c (print_source_lines_base): Emit escape sequences in one
4194         piece.
4195
4196 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4197
4198         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4199         integers and enumeration types.
4200
4201 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4202
4203         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4204         instead of lookup_symbol_in_language
4205         (do_exact_match): New function.
4206         (ada_get_symbol_name_matcher): Return do_exact_match when
4207         doing a verbatim match.
4208
4209 2019-02-15  Tom Tromey  <tromey@adacore.com>
4210
4211         * ravenscar-thread.c (ravenscar_thread_target::resume)
4212         (ravenscar_thread_target::wait): Special case wildcard requests.
4213
4214 2019-02-15  Tom Tromey  <tromey@adacore.com>
4215
4216         * ravenscar-thread.c (base_ptid): Remove.
4217         (struct ravenscar_thread_target) <close>: New method.
4218         <m_base_ptid>: New member.
4219         <update_inferior_ptid, active_task, task_is_currently_active,
4220         runtime_initialized>: Declare methods.
4221         <ravenscar_thread_target>: Add constructor.
4222         (ravenscar_thread_target::task_is_currently_active)
4223         (ravenscar_thread_target::update_inferior_ptid)
4224         (ravenscar_runtime_initialized): Rename.  Now methods.
4225         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4226         (ravenscar_thread_target::update_thread_list): Update.
4227         (ravenscar_thread_target::active_task): Now method.
4228         (ravenscar_thread_target::store_registers)
4229         (ravenscar_thread_target::prepare_to_store)
4230         (ravenscar_thread_target::prepare_to_store)
4231         (ravenscar_thread_target::mourn_inferior): Update.
4232         (ravenscar_inferior_created): Use "new" to create target.
4233         (ravenscar_thread_target::get_ada_task_ptid): Update.
4234         (_initialize_ravenscar): Don't initialize base_ptid.
4235         (ravenscar_ops): Remove global.
4236
4237 2019-02-15  Tom Tromey  <tromey@adacore.com>
4238
4239         * target.h (push_target): Declare new overload.
4240         * target.c (push_target): New overload, taking an rvalue reference.
4241         * remote.c (remote_target::open_1): Use push_target overload.
4242         * corelow.c (core_target_open): Use push_target overload.
4243
4244 2019-02-15  Tom Tromey  <tromey@adacore.com>
4245
4246         * ravenscar-thread.c (is_ravenscar_task)
4247         (ravenscar_task_is_currently_active): Return bool.
4248         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4249         (_initialize_ravenscar): Remove "(void)".
4250         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4251         Return bool.
4252
4253 2019-02-15  Tom Tromey  <tromey@adacore.com>
4254
4255         * ravenscar-thread.c (ravenscar_runtime_initializer)
4256         (has_ravenscar_runtime, get_running_thread_id)
4257         (ravenscar_thread_target::resume): Fix indentation.
4258
4259 2019-02-15  Tom Tromey  <tromey@adacore.com>
4260
4261         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4262         from ravenscar_arch_ops.
4263         (sparc_ravenscar_ops::fetch_registers)
4264         (sparc_ravenscar_ops::store_registers): Now methods.
4265         (sparc_ravenscar_prepare_to_store): Remove.
4266         (sparc_ravenscar_ops): Redefine.
4267         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4268         methods and destructor.  Remove members.
4269         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4270         (ravenscar_thread_target::store_registers)
4271         (ravenscar_thread_target::prepare_to_store): Update.
4272         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4273         Remove.
4274         (struct ppc_ravenscar_powerpc_ops): Derive from
4275         ravenscar_arch_ops.
4276         (ppc_ravenscar_powerpc_ops::fetch_registers)
4277         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4278         (ppc_ravenscar_powerpc_ops): Redefine.
4279         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4280         (ppc_ravenscar_e500_ops::fetch_registers)
4281         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4282         (ppc_ravenscar_e500_ops): Redefine.
4283         * aarch64-ravenscar-thread.c
4284         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4285         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4286         (aarch64_ravenscar_fetch_registers)
4287         (aarch64_ravenscar_store_registers): Now methods.
4288         (aarch64_ravenscar_ops): Redefine.
4289
4290 2019-02-15  Tom Tromey  <tromey@adacore.com>
4291
4292         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4293         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4294         (ravenscar_thread_target::stopped_by_watchpoint)
4295         (ravenscar_thread_target::stopped_data_address)
4296         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4297
4298 2019-02-15  Tom Tromey  <tromey@adacore.com>
4299
4300         * ravenscar-thread.c: Fix some typos.
4301
4302 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4303             Tom Tromey  <tromey@adacore.com>
4304
4305         * ada-lang.c (ada_exception_sal): Change addr_string to a
4306         std::string.
4307         (create_ada_exception_catchpoint): Update.
4308
4309 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4310             Tom Tromey  <tromey@adacore.com>
4311
4312         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4313         (bp_location_ops): Remove.
4314         (base_breakpoint_allocate_location): Update.
4315         (free_bp_location): Update.
4316         * ada-lang.c (class ada_catchpoint_location)
4317         <ada_catchpoint_location>: Remove ops parameter.
4318         (ada_catchpoint_location_dtor): Remove.
4319         (ada_catchpoint_location_ops): Remove.
4320         (allocate_location_exception): Update.
4321         * breakpoint.h (struct bp_location_ops): Remove.
4322         (class bp_location) <bp_location>: Remove bp_location_ops
4323         parameter.
4324         <~bp_location>: Add destructor.
4325         <ops>: Remove.
4326
4327 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4328             Pedro Alves  <palves@redhat.com>
4329
4330         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4331         'PATH_MAX'.
4332
4333 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4334             Samuel Thibault  <samuel.thibault@gnu.org>
4335             Thomas Schwinge  <thomas@codesourcery.com>
4336
4337         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4338         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4339
4340 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4341
4342         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4343         (check_empty): Use "const char *".
4344
4345         * gnu-nat.c (gnu_nat_target::detach): Instead of
4346         'detach_inferior (pid)' call
4347         'detach_inferior (find_inferior_pid (pid))'.
4348
4349         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4350         'nat/fork-inferior.o'.
4351         * gnu-nat.c: #include "nat/fork-inferior.h".
4352
4353         * gnu-nat.c (gnu_nat_target::detach): Instead of
4354         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4355         * gnu-nat.h: #include "inf-child.h".
4356         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4357         'i386_gnu_nat_target::fetch_registers'.
4358         (gnu_store_registers): Rename/move to
4359         'i386_gnu_nat_target::store_registers'.
4360
4361         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4362         * gnu-nat.h (mach_thread_info): New function.
4363         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4364
4365         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4366
4367 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4368
4369         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4370
4371 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4372
4373         * windows-nat.c (windows_add_thread): Add new parameter
4374         "main_thread_p" with default value set to false.  Update
4375         function documentation as well as all callers.
4376         (windows_delete_thread): Likewise.
4377         (fake_create_process): Update call to windows_add_thread.
4378         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4379         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4380         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4381         call to windows_delete_thread.
4382
4383 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4384
4385         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4386
4387 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4388
4389         * symfile.c (find_separate_debug_file): Use canonical path of
4390         sysroot with child_path instead of gdb_sysroot if it is valid.
4391
4392 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4393
4394         * symfile.c (find_separate_debug_file): Use child_path to
4395         determine if an object file is under a sysroot.
4396
4397 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4398
4399         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4400         unittests/child-path-selftests.c.
4401         * common/pathstuff.c (child_path): New function.
4402         * common/pathstuff.h (child_path): New prototype.
4403         * unittests/child-path-selftests.c: New file.
4404
4405 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4406
4407         * symfile.c (find_separate_debug_file): Look for separate debug
4408         files in debug directories under the sysroot.
4409
4410 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4411
4412         * symtab.h (struct minimal_symbol data_p): New const method.
4413         (struct minimal_symbol text_p): Likewise.
4414         * symtab.c (output_source_filename): Use file name style
4415         to print file name.
4416         (print_symbol_info): Likewise.
4417         (print_msymbol_info): Use address style to print addresses.
4418         Use function name style to print executable text symbols.
4419         (expand_symtab_containing_pc): Use data_p.
4420         (find_pc_sect_compunit_symtab): Likewise.
4421
4422 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4423
4424         * breakpoint.c (describe_other_breakpoints): Use address style
4425         to print addresses.
4426         (say_where): Likewise.
4427
4428 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4429
4430         * ada-typeprint.c (print_func_type): Print function name
4431         style to print function name.
4432         * c-typeprint.c (c_print_type_1): Likewise.
4433
4434 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4435
4436         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4437         for execve.
4438
4439 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4440
4441         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4442         type_stack.
4443
4444 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4445
4446         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4447         TYPE_CODE_REF types.
4448
4449 2019-02-08  Jim Wilson  <jimw@sifive.com>
4450
4451         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4452         (riscv_linux_fregset): New.
4453         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4454
4455 2019-02-07  Tom Tromey  <tom@tromey.com>
4456
4457         * thread.c (thread_cancel_execution_command): Update.
4458         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4459         methods.
4460         (struct thread_fsm_ops): Remove.
4461         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4462         (thread_fsm_should_stop, thread_fsm_return_value)
4463         (thread_fsm_set_finished, thread_fsm_finished_p)
4464         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4465         Don't declare.
4466         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4467         * infrun.c (clear_proceed_status_thread)
4468         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4469         (print_stop_event): Update.
4470         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4471         Add constructor.
4472         (step_command_fsm_ops): Remove.
4473         (new_step_command_fsm): Remove.
4474         (step_1): Update.
4475         (step_command_fsm::should_stop): Rename from
4476         step_command_fsm_should_stop.
4477         (step_command_fsm::clean_up): Rename from
4478         step_command_fsm_clean_up.
4479         (step_command_fsm::do_async_reply_reason): Rename from
4480         step_command_fsm_async_reply_reason.
4481         (struct until_next_fsm): Inherit from thread_fsm.  Add
4482         constructor.
4483         (until_next_fsm_ops): Remove.
4484         (new_until_next_fsm): Remove.
4485         (until_next_fsm::should_stop): Rename from
4486         until_next_fsm_should_stop.
4487         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4488         (until_next_fsm::do_async_reply_reason): Rename from
4489         until_next_fsm_async_reply_reason.
4490         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4491         constructor.  Change type of breakpoint.
4492         (finish_command_fsm_ops): Remove.
4493         (new_finish_command_fsm): Remove.
4494         (finish_command_fsm::should_stop): Rename from
4495         finish_command_fsm_should_stop.
4496         (finish_command_fsm::clean_up): Rename from
4497         finish_command_fsm_clean_up.
4498         (finish_command_fsm::return_value): Rename from
4499         finish_command_fsm_return_value.
4500         (finish_command_fsm::do_async_reply_reason): Rename from
4501         finish_command_fsm_async_reply_reason.
4502         (finish_command): Update.
4503         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
4504         Add constructor.
4505         (call_thread_fsm_ops): Remove.
4506         (call_thread_fsm::call_thread_fsm): Rename from
4507         new_call_thread_fsm.
4508         (call_thread_fsm::should_stop): Rename from
4509         call_thread_fsm_should_stop.
4510         (call_thread_fsm::should_notify_stop): Rename from
4511         call_thread_fsm_should_notify_stop.
4512         (run_inferior_call, call_function_by_hand_dummy): Update.
4513         * cli/cli-interp.c (should_print_stop_to_console): Update.
4514         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
4515         Add constructor.  Change type of location_breakpoint,
4516         caller_breakpoint.
4517         (until_break_fsm_ops): Remove.
4518         (new_until_break_fsm): Remove.
4519         (until_break_fsm::should_stop): Rename from
4520         until_break_fsm_should_stop.
4521         (until_break_fsm::clean_up): Rename from
4522         until_break_fsm_clean_up.
4523         (until_break_fsm::do_async_reply_reason): Rename from
4524         until_break_fsm_async_reply_reason.
4525         (until_break_command): Update.
4526         * thread-fsm.c: Remove.
4527         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
4528
4529 2019-02-07  Tom Tromey  <tom@tromey.com>
4530
4531         * yy-remap.h: Add include guard.
4532         * xtensa-tdep.h: Add include guard.
4533         * xcoffread.h: Rename include guard.
4534         * varobj-iter.h: Add include guard.
4535         * tui/tui.h: Rename include guard.
4536         * tui/tui-winsource.h: Rename include guard.
4537         * tui/tui-wingeneral.h: Rename include guard.
4538         * tui/tui-windata.h: Rename include guard.
4539         * tui/tui-win.h: Rename include guard.
4540         * tui/tui-stack.h: Rename include guard.
4541         * tui/tui-source.h: Rename include guard.
4542         * tui/tui-regs.h: Rename include guard.
4543         * tui/tui-out.h: Rename include guard.
4544         * tui/tui-layout.h: Rename include guard.
4545         * tui/tui-io.h: Rename include guard.
4546         * tui/tui-hooks.h: Rename include guard.
4547         * tui/tui-file.h: Rename include guard.
4548         * tui/tui-disasm.h: Rename include guard.
4549         * tui/tui-data.h: Rename include guard.
4550         * tui/tui-command.h: Rename include guard.
4551         * tic6x-tdep.h: Add include guard.
4552         * target/waitstatus.h: Rename include guard.
4553         * target/wait.h: Rename include guard.
4554         * target/target.h: Rename include guard.
4555         * target/resume.h: Rename include guard.
4556         * target-float.h: Rename include guard.
4557         * stabsread.h: Add include guard.
4558         * rs6000-tdep.h: Add include guard.
4559         * riscv-fbsd-tdep.h: Add include guard.
4560         * regformats/regdef.h: Rename include guard.
4561         * record.h: Rename include guard.
4562         * python/python.h: Rename include guard.
4563         * python/python-internal.h: Rename include guard.
4564         * python/py-stopevent.h: Rename include guard.
4565         * python/py-ref.h: Rename include guard.
4566         * python/py-record.h: Rename include guard.
4567         * python/py-record-full.h: Rename include guard.
4568         * python/py-record-btrace.h: Rename include guard.
4569         * python/py-instruction.h: Rename include guard.
4570         * python/py-events.h: Rename include guard.
4571         * python/py-event.h: Rename include guard.
4572         * procfs.h: Add include guard.
4573         * proc-utils.h: Add include guard.
4574         * p-lang.h: Add include guard.
4575         * or1k-tdep.h: Rename include guard.
4576         * observable.h: Rename include guard.
4577         * nto-tdep.h: Rename include guard.
4578         * nat/x86-linux.h: Rename include guard.
4579         * nat/x86-linux-dregs.h: Rename include guard.
4580         * nat/x86-gcc-cpuid.h: Add include guard.
4581         * nat/x86-dregs.h: Rename include guard.
4582         * nat/x86-cpuid.h: Rename include guard.
4583         * nat/ppc-linux.h: Rename include guard.
4584         * nat/mips-linux-watch.h: Rename include guard.
4585         * nat/linux-waitpid.h: Rename include guard.
4586         * nat/linux-ptrace.h: Rename include guard.
4587         * nat/linux-procfs.h: Rename include guard.
4588         * nat/linux-osdata.h: Rename include guard.
4589         * nat/linux-nat.h: Rename include guard.
4590         * nat/linux-namespaces.h: Rename include guard.
4591         * nat/linux-btrace.h: Rename include guard.
4592         * nat/glibc_thread_db.h: Rename include guard.
4593         * nat/gdb_thread_db.h: Rename include guard.
4594         * nat/gdb_ptrace.h: Rename include guard.
4595         * nat/fork-inferior.h: Rename include guard.
4596         * nat/amd64-linux-siginfo.h: Rename include guard.
4597         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
4598         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
4599         * nat/aarch64-linux.h: Rename include guard.
4600         * nat/aarch64-linux-hw-point.h: Rename include guard.
4601         * mn10300-tdep.h: Add include guard.
4602         * mips-linux-tdep.h: Add include guard.
4603         * mi/mi-parse.h: Rename include guard.
4604         * mi/mi-out.h: Rename include guard.
4605         * mi/mi-main.h: Rename include guard.
4606         * mi/mi-interp.h: Rename include guard.
4607         * mi/mi-getopt.h: Rename include guard.
4608         * mi/mi-console.h: Rename include guard.
4609         * mi/mi-common.h: Rename include guard.
4610         * mi/mi-cmds.h: Rename include guard.
4611         * mi/mi-cmd-break.h: Rename include guard.
4612         * m2-lang.h: Add include guard.
4613         * location.h: Rename include guard.
4614         * linux-record.h: Rename include guard.
4615         * linux-nat.h: Add include guard.
4616         * linux-fork.h: Add include guard.
4617         * i386-darwin-tdep.h: Rename include guard.
4618         * hppa-linux-offsets.h: Add include guard.
4619         * guile/guile.h: Rename include guard.
4620         * guile/guile-internal.h: Rename include guard.
4621         * gnu-nat.h: Rename include guard.
4622         * gdb-stabs.h: Rename include guard.
4623         * frv-tdep.h: Add include guard.
4624         * f-lang.h: Add include guard.
4625         * event-loop.h: Add include guard.
4626         * darwin-nat.h: Rename include guard.
4627         * cp-abi.h: Rename include guard.
4628         * config/sparc/nm-sol2.h: Rename include guard.
4629         * config/nm-nto.h: Rename include guard.
4630         * config/nm-linux.h: Add include guard.
4631         * config/i386/nm-i386gnu.h: Rename include guard.
4632         * config/djgpp/nl_types.h: Rename include guard.
4633         * config/djgpp/langinfo.h: Rename include guard.
4634         * compile/gcc-cp-plugin.h: Add include guard.
4635         * compile/gcc-c-plugin.h: Add include guard.
4636         * compile/compile.h: Rename include guard.
4637         * compile/compile-object-run.h: Rename include guard.
4638         * compile/compile-object-load.h: Rename include guard.
4639         * compile/compile-internal.h: Rename include guard.
4640         * compile/compile-cplus.h: Rename include guard.
4641         * compile/compile-c.h: Rename include guard.
4642         * common/xml-utils.h: Rename include guard.
4643         * common/x86-xstate.h: Rename include guard.
4644         * common/version.h: Rename include guard.
4645         * common/vec.h: Rename include guard.
4646         * common/tdesc.h: Rename include guard.
4647         * common/selftest.h: Rename include guard.
4648         * common/scoped_restore.h: Rename include guard.
4649         * common/scoped_mmap.h: Rename include guard.
4650         * common/scoped_fd.h: Rename include guard.
4651         * common/safe-iterator.h: Rename include guard.
4652         * common/run-time-clock.h: Rename include guard.
4653         * common/refcounted-object.h: Rename include guard.
4654         * common/queue.h: Rename include guard.
4655         * common/ptid.h: Rename include guard.
4656         * common/print-utils.h: Rename include guard.
4657         * common/preprocessor.h: Rename include guard.
4658         * common/pathstuff.h: Rename include guard.
4659         * common/observable.h: Rename include guard.
4660         * common/netstuff.h: Rename include guard.
4661         * common/job-control.h: Rename include guard.
4662         * common/host-defs.h: Rename include guard.
4663         * common/gdb_wait.h: Rename include guard.
4664         * common/gdb_vecs.h: Rename include guard.
4665         * common/gdb_unlinker.h: Rename include guard.
4666         * common/gdb_unique_ptr.h: Rename include guard.
4667         * common/gdb_tilde_expand.h: Rename include guard.
4668         * common/gdb_sys_time.h: Rename include guard.
4669         * common/gdb_string_view.h: Rename include guard.
4670         * common/gdb_splay_tree.h: Rename include guard.
4671         * common/gdb_setjmp.h: Rename include guard.
4672         * common/gdb_ref_ptr.h: Rename include guard.
4673         * common/gdb_optional.h: Rename include guard.
4674         * common/gdb_locale.h: Rename include guard.
4675         * common/gdb_assert.h: Rename include guard.
4676         * common/filtered-iterator.h: Rename include guard.
4677         * common/filestuff.h: Rename include guard.
4678         * common/fileio.h: Rename include guard.
4679         * common/environ.h: Rename include guard.
4680         * common/common-utils.h: Rename include guard.
4681         * common/common-types.h: Rename include guard.
4682         * common/common-regcache.h: Rename include guard.
4683         * common/common-inferior.h: Rename include guard.
4684         * common/common-gdbthread.h: Rename include guard.
4685         * common/common-exceptions.h: Rename include guard.
4686         * common/common-defs.h: Rename include guard.
4687         * common/common-debug.h: Rename include guard.
4688         * common/cleanups.h: Rename include guard.
4689         * common/buffer.h: Rename include guard.
4690         * common/btrace-common.h: Rename include guard.
4691         * common/break-common.h: Rename include guard.
4692         * cli/cli-utils.h: Rename include guard.
4693         * cli/cli-style.h: Rename include guard.
4694         * cli/cli-setshow.h: Rename include guard.
4695         * cli/cli-script.h: Rename include guard.
4696         * cli/cli-interp.h: Rename include guard.
4697         * cli/cli-decode.h: Rename include guard.
4698         * cli/cli-cmds.h: Rename include guard.
4699         * charset-list.h: Add include guard.
4700         * buildsym-legacy.h: Rename include guard.
4701         * bfin-tdep.h: Add include guard.
4702         * ax.h: Rename include guard.
4703         * arm-linux-tdep.h: Add include guard.
4704         * arm-fbsd-tdep.h: Add include guard.
4705         * arch/xtensa.h: Rename include guard.
4706         * arch/tic6x.h: Add include guard.
4707         * arch/i386.h: Add include guard.
4708         * arch/arm.h: Rename include guard.
4709         * arch/arm-linux.h: Rename include guard.
4710         * arch/arm-get-next-pcs.h: Rename include guard.
4711         * arch/amd64.h: Add include guard.
4712         * arch/aarch64-insn.h: Rename include guard.
4713         * arch-utils.h: Rename include guard.
4714         * annotate.h: Add include guard.
4715         * amd64-darwin-tdep.h: Rename include guard.
4716         * aarch64-linux-tdep.h: Add include guard.
4717         * aarch64-fbsd-tdep.h: Add include guard.
4718         * aarch32-linux-nat.h: Add include guard.
4719
4720 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4721
4722         * macrotab.c (macro_define_internal): New function that
4723         factorizes macro_define_object_internal and macro_define_function
4724         code.
4725         (macro_define_object_internal): Use macro_define_internal.
4726         (macro_define_function): Likewise.
4727
4728 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4729
4730         * macrocmd.c (extract_identifier): Return
4731         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
4732         callers.
4733
4734 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
4735
4736         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
4737
4738 2019-02-05  Tom Tromey  <tom@tromey.com>
4739
4740         * target.c (target_stack::unpush): Move assertion earlier.
4741
4742 2019-01-30  Tom Tromey  <tom@tromey.com>
4743
4744         PR python/23615:
4745         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
4746         (gdbpy_parse_and_eval): Likewise.
4747         * python/python-internal.h (gdbpy_allow_threads): New class.
4748
4749 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
4750
4751         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
4752         (aarch64_fbsd_fpregmap): Move earlier.
4753         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
4754         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4755         instead of individual calls to trad_frame_set_reg_addr.
4756         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
4757         earlier.
4758         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
4759         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4760         instead of individual calls to trad_frame_set_reg_addr.
4761
4762 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
4763
4764         * CONTRIBUTE: Replace contribution list with wiki link.
4765
4766 2019-01-25  Tom Tromey  <tom@tromey.com>
4767
4768         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
4769
4770 2019-01-25  Tom Tromey  <tom@tromey.com>
4771
4772         * xtensa-linux-nat.c: Fix common/ includes.
4773         * xml-support.h: Fix common/ includes.
4774         * xml-support.c: Fix common/ includes.
4775         * x86-linux-nat.c: Fix common/ includes.
4776         * windows-nat.c: Fix common/ includes.
4777         * varobj.h: Fix common/ includes.
4778         * varobj.c: Fix common/ includes.
4779         * value.c: Fix common/ includes.
4780         * valops.c: Fix common/ includes.
4781         * utils.c: Fix common/ includes.
4782         * unittests/xml-utils-selftests.c: Fix common/ includes.
4783         * unittests/utils-selftests.c: Fix common/ includes.
4784         * unittests/unpack-selftests.c: Fix common/ includes.
4785         * unittests/tracepoint-selftests.c: Fix common/ includes.
4786         * unittests/style-selftests.c: Fix common/ includes.
4787         * unittests/string_view-selftests.c: Fix common/ includes.
4788         * unittests/scoped_restore-selftests.c: Fix common/ includes.
4789         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
4790         * unittests/scoped_fd-selftests.c: Fix common/ includes.
4791         * unittests/rsp-low-selftests.c: Fix common/ includes.
4792         * unittests/parse-connection-spec-selftests.c: Fix common/
4793         includes.
4794         * unittests/optional-selftests.c: Fix common/ includes.
4795         * unittests/offset-type-selftests.c: Fix common/ includes.
4796         * unittests/observable-selftests.c: Fix common/ includes.
4797         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
4798         * unittests/memrange-selftests.c: Fix common/ includes.
4799         * unittests/memory-map-selftests.c: Fix common/ includes.
4800         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
4801         * unittests/function-view-selftests.c: Fix common/ includes.
4802         * unittests/environ-selftests.c: Fix common/ includes.
4803         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
4804         * unittests/common-utils-selftests.c: Fix common/ includes.
4805         * unittests/cli-utils-selftests.c: Fix common/ includes.
4806         * unittests/array-view-selftests.c: Fix common/ includes.
4807         * ui-file.c: Fix common/ includes.
4808         * tui/tui-io.c: Fix common/ includes.
4809         * tracepoint.h: Fix common/ includes.
4810         * tracepoint.c: Fix common/ includes.
4811         * tracefile-tfile.c: Fix common/ includes.
4812         * top.h: Fix common/ includes.
4813         * top.c: Fix common/ includes.
4814         * thread.c: Fix common/ includes.
4815         * target/waitstatus.h: Fix common/ includes.
4816         * target/waitstatus.c: Fix common/ includes.
4817         * target.h: Fix common/ includes.
4818         * target.c: Fix common/ includes.
4819         * target-memory.c: Fix common/ includes.
4820         * target-descriptions.c: Fix common/ includes.
4821         * symtab.h: Fix common/ includes.
4822         * symfile.c: Fix common/ includes.
4823         * stap-probe.c: Fix common/ includes.
4824         * spu-linux-nat.c: Fix common/ includes.
4825         * sparc-nat.c: Fix common/ includes.
4826         * source.c: Fix common/ includes.
4827         * solib.c: Fix common/ includes.
4828         * solib-target.c: Fix common/ includes.
4829         * ser-unix.c: Fix common/ includes.
4830         * ser-tcp.c: Fix common/ includes.
4831         * ser-pipe.c: Fix common/ includes.
4832         * ser-base.c: Fix common/ includes.
4833         * selftest-arch.c: Fix common/ includes.
4834         * s12z-tdep.c: Fix common/ includes.
4835         * rust-exp.y: Fix common/ includes.
4836         * rs6000-aix-tdep.c: Fix common/ includes.
4837         * riscv-tdep.c: Fix common/ includes.
4838         * remote.c: Fix common/ includes.
4839         * remote-notif.h: Fix common/ includes.
4840         * remote-fileio.h: Fix common/ includes.
4841         * remote-fileio.c: Fix common/ includes.
4842         * regcache.h: Fix common/ includes.
4843         * regcache.c: Fix common/ includes.
4844         * record-btrace.c: Fix common/ includes.
4845         * python/python.c: Fix common/ includes.
4846         * python/py-type.c: Fix common/ includes.
4847         * python/py-inferior.c: Fix common/ includes.
4848         * progspace.h: Fix common/ includes.
4849         * producer.c: Fix common/ includes.
4850         * procfs.c: Fix common/ includes.
4851         * proc-api.c: Fix common/ includes.
4852         * printcmd.c: Fix common/ includes.
4853         * ppc-linux-nat.c: Fix common/ includes.
4854         * parser-defs.h: Fix common/ includes.
4855         * osdata.c: Fix common/ includes.
4856         * obsd-nat.c: Fix common/ includes.
4857         * nat/x86-linux.c: Fix common/ includes.
4858         * nat/x86-linux-dregs.c: Fix common/ includes.
4859         * nat/x86-dregs.h: Fix common/ includes.
4860         * nat/x86-dregs.c: Fix common/ includes.
4861         * nat/ppc-linux.c: Fix common/ includes.
4862         * nat/mips-linux-watch.h: Fix common/ includes.
4863         * nat/mips-linux-watch.c: Fix common/ includes.
4864         * nat/linux-waitpid.c: Fix common/ includes.
4865         * nat/linux-ptrace.h: Fix common/ includes.
4866         * nat/linux-ptrace.c: Fix common/ includes.
4867         * nat/linux-procfs.c: Fix common/ includes.
4868         * nat/linux-personality.c: Fix common/ includes.
4869         * nat/linux-osdata.c: Fix common/ includes.
4870         * nat/linux-namespaces.c: Fix common/ includes.
4871         * nat/linux-btrace.h: Fix common/ includes.
4872         * nat/linux-btrace.c: Fix common/ includes.
4873         * nat/fork-inferior.c: Fix common/ includes.
4874         * nat/amd64-linux-siginfo.c: Fix common/ includes.
4875         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
4876         * nat/aarch64-linux.c: Fix common/ includes.
4877         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
4878         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
4879         * namespace.h: Fix common/ includes.
4880         * mips-linux-tdep.c: Fix common/ includes.
4881         * minsyms.c: Fix common/ includes.
4882         * mi/mi-parse.h: Fix common/ includes.
4883         * mi/mi-main.c: Fix common/ includes.
4884         * mi/mi-cmd-env.c: Fix common/ includes.
4885         * memrange.h: Fix common/ includes.
4886         * memattr.c: Fix common/ includes.
4887         * maint.h: Fix common/ includes.
4888         * maint.c: Fix common/ includes.
4889         * main.c: Fix common/ includes.
4890         * machoread.c: Fix common/ includes.
4891         * location.c: Fix common/ includes.
4892         * linux-thread-db.c: Fix common/ includes.
4893         * linux-nat.c: Fix common/ includes.
4894         * linux-fork.c: Fix common/ includes.
4895         * inline-frame.c: Fix common/ includes.
4896         * infrun.c: Fix common/ includes.
4897         * inflow.c: Fix common/ includes.
4898         * inferior.h: Fix common/ includes.
4899         * inferior.c: Fix common/ includes.
4900         * infcmd.c: Fix common/ includes.
4901         * inf-ptrace.c: Fix common/ includes.
4902         * inf-child.c: Fix common/ includes.
4903         * ia64-linux-nat.c: Fix common/ includes.
4904         * i387-tdep.c: Fix common/ includes.
4905         * i386-tdep.c: Fix common/ includes.
4906         * i386-linux-tdep.c: Fix common/ includes.
4907         * i386-linux-nat.c: Fix common/ includes.
4908         * i386-go32-tdep.c: Fix common/ includes.
4909         * i386-fbsd-tdep.c: Fix common/ includes.
4910         * i386-fbsd-nat.c: Fix common/ includes.
4911         * guile/scm-type.c: Fix common/ includes.
4912         * guile/guile.c: Fix common/ includes.
4913         * go32-nat.c: Fix common/ includes.
4914         * gnu-nat.c: Fix common/ includes.
4915         * gdbthread.h: Fix common/ includes.
4916         * gdbarch-selftests.c: Fix common/ includes.
4917         * gdb_usleep.c: Fix common/ includes.
4918         * gdb_select.h: Fix common/ includes.
4919         * gdb_bfd.c: Fix common/ includes.
4920         * gcore.c: Fix common/ includes.
4921         * fork-child.c: Fix common/ includes.
4922         * findvar.c: Fix common/ includes.
4923         * fbsd-nat.c: Fix common/ includes.
4924         * event-top.c: Fix common/ includes.
4925         * event-loop.c: Fix common/ includes.
4926         * dwarf2read.c: Fix common/ includes.
4927         * dwarf2loc.c: Fix common/ includes.
4928         * dwarf2-frame.c: Fix common/ includes.
4929         * dwarf-index-cache.c: Fix common/ includes.
4930         * dtrace-probe.c: Fix common/ includes.
4931         * disasm-selftests.c: Fix common/ includes.
4932         * defs.h: Fix common/ includes.
4933         * csky-tdep.c: Fix common/ includes.
4934         * cp-valprint.c: Fix common/ includes.
4935         * cp-support.h: Fix common/ includes.
4936         * cp-support.c: Fix common/ includes.
4937         * corelow.c: Fix common/ includes.
4938         * completer.h: Fix common/ includes.
4939         * completer.c: Fix common/ includes.
4940         * compile/compile.c: Fix common/ includes.
4941         * compile/compile-loc2c.c: Fix common/ includes.
4942         * compile/compile-cplus-types.c: Fix common/ includes.
4943         * compile/compile-cplus-symbols.c: Fix common/ includes.
4944         * command.h: Fix common/ includes.
4945         * cli/cli-dump.c: Fix common/ includes.
4946         * cli/cli-cmds.c: Fix common/ includes.
4947         * charset.c: Fix common/ includes.
4948         * build-id.c: Fix common/ includes.
4949         * btrace.h: Fix common/ includes.
4950         * btrace.c: Fix common/ includes.
4951         * breakpoint.h: Fix common/ includes.
4952         * breakpoint.c: Fix common/ includes.
4953         * ax.h:
4954         (enum agent_op): Fix common/ includes.
4955         * ax-general.c (struct aop_map): Fix common/ includes.
4956         * ax-gdb.c: Fix common/ includes.
4957         * auxv.c: Fix common/ includes.
4958         * auto-load.c: Fix common/ includes.
4959         * arm-tdep.c: Fix common/ includes.
4960         * arch/riscv.c: Fix common/ includes.
4961         * arch/ppc-linux-common.c: Fix common/ includes.
4962         * arch/i386.c: Fix common/ includes.
4963         * arch/arm.c: Fix common/ includes.
4964         * arch/arm-linux.c: Fix common/ includes.
4965         * arch/arm-get-next-pcs.c: Fix common/ includes.
4966         * arch/amd64.c: Fix common/ includes.
4967         * arch/aarch64.c: Fix common/ includes.
4968         * arch/aarch64-insn.c: Fix common/ includes.
4969         * arch-utils.c: Fix common/ includes.
4970         * amd64-windows-tdep.c: Fix common/ includes.
4971         * amd64-tdep.c: Fix common/ includes.
4972         * amd64-sol2-tdep.c: Fix common/ includes.
4973         * amd64-obsd-tdep.c: Fix common/ includes.
4974         * amd64-nbsd-tdep.c: Fix common/ includes.
4975         * amd64-linux-tdep.c: Fix common/ includes.
4976         * amd64-linux-nat.c: Fix common/ includes.
4977         * amd64-fbsd-tdep.c: Fix common/ includes.
4978         * amd64-fbsd-nat.c: Fix common/ includes.
4979         * amd64-dicos-tdep.c: Fix common/ includes.
4980         * amd64-darwin-tdep.c: Fix common/ includes.
4981         * agent.c: Fix common/ includes.
4982         * ada-lang.h: Fix common/ includes.
4983         * ada-lang.c: Fix common/ includes.
4984         * aarch64-tdep.c: Fix common/ includes.
4985
4986 2019-01-25  Tom Tromey  <tom@tromey.com>
4987
4988         * common/create-version.sh: Use common/version.h.
4989
4990 2019-01-24  Pedro Alves  <palves@redhat.com>
4991
4992         * infrun.c (signal_stop, signal_print, signal_program)
4993         (signal_catch, signal_pass): Now arrays instead of pointers.
4994         (update_signals_program_target, do_target_resume)
4995         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
4996         * linux-nat.c (linux_nat_target::pass_signals)
4997         (linux_nat_target::create_inferior, linux_nat_target::attach):
4998         Adjust.
4999         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
5000         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
5001         * procfs.c (procfs_target::pass_signals): Adjust.
5002         * record-full.c (record_full_target::resume): Adjust.
5003         * remote.c (remote_target::pass_signals)
5004         (remote_target::program_signals): Adjust.
5005         * target-debug.h (target_debug_print_signals): Now takes a
5006         gdb::array_view as parameter.  Adjust.
5007         * target.h (target_ops) <pass_signals, program_signals>: Replace
5008         pointer and length parameters with gdb::array_view.
5009         (target_pass_signals, target_program_signals): Likewise.
5010         * target-delegates.c: Regenerate.
5011
5012 2019-01-24  Pedro Alves  <palves@redhat.com>
5013
5014         * common/forward-scope-exit.h
5015         (forward_scope_exit::forward_scope_exit): Pass arguments to
5016         m_bind_function directly, instead of creating a std::bind and
5017         copying that.
5018
5019 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
5020
5021         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5022         for static members.
5023         (pass_in_v_vfp_candidate): Likewise.
5024
5025 2019-01-23  Tom Tromey  <tom@tromey.com>
5026             Pedro Alves  <palves@redhat.com>
5027
5028         * regcache.c (class regcache_invalidator): Remove.
5029         (regcache::raw_write): Use make_scope_exit.
5030
5031 2019-01-23  Tom Tromey  <tom@tromey.com>
5032
5033         * ui-out.h (class ui_out_emit_type): Update comment.
5034
5035 2019-01-23  Tom Tromey  <tom@tromey.com>
5036
5037         * infrun.c (fetch_inferior_event): Update comment.
5038
5039 2019-01-23  Tom Tromey  <tom@tromey.com>
5040             Pedro Alves  <palves@redhat.com>
5041
5042         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
5043         parameter.
5044         (fetch_inferior_event): Use SCOPE_EXIT.
5045
5046
5047 2019-01-23  Tom Tromey  <tom@tromey.com>
5048             Pedro Alves  <palves@redhat.com>
5049
5050         * infrun.c (disable_thread_events): Delete.
5051         (stop_all_threads): Use SCOPE_EXIT.
5052
5053 2019-01-23  Tom Tromey  <tom@tromey.com>
5054             Pedro Alves  <palves@redhat.com>
5055
5056         * symfile.c: Include forward-scope-exit.h.
5057         (clear_symtab_users_cleanup): Replace forward declaration with
5058         a FORWARD_SCOPE_EXIT.
5059         (syms_from_objfile_1): Use the forward_scope_exit and
5060         gdb::optional instead of cleanup_function.
5061         (reread_symbols): Use the forward_scope_exit instead of
5062         cleanup_function.
5063         (clear_symtab_users_cleanup): Remove function.
5064
5065 2019-01-23  Tom Tromey  <tom@tromey.com>
5066             Pedro Alves  <palves@redhat.com>
5067
5068         * linux-nat.c: Include scope-exit.h.
5069         (cleanup_target_stop): Remove.
5070         (linux_nat_target::static_tracepoint_markers_by_strid): Use
5071         SCOPE_EXIT.
5072
5073 2019-01-23  Tom Tromey  <tom@tromey.com>
5074             Pedro Alves  <palves@redhat.com>
5075
5076         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
5077         (call_function_by_hand_dummy): Use SCOPE_EXIT.
5078
5079 2019-01-23  Tom Tromey  <tom@tromey.com>
5080             Andrew Burgess  <andrew.burgess@embecosm.com>
5081             Pedro Alves  <palves@redhat.com>
5082
5083         * infrun.c (fetch_inferior_event): Use scope_exit.
5084         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
5085         * top.c (execute_command): Use scope_exit.
5086         * breakpoint.c (bpstat_do_actions): Use scope_exit.
5087         * utils.c (do_bpstat_clear_actions_cleanup)
5088         (make_bpstat_clear_actions_cleanup): Remove.
5089
5090 2019-01-23  Tom Tromey  <tom@tromey.com>
5091             Pedro Alves  <palves@redhat.com>
5092
5093         * infrun.c: Include "common/scope-exit.h"
5094         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
5095         (wait_for_inferior): Use SCOPE_EXIT.
5096         (fetch_inferior_event): Use scope_exit.
5097
5098 2019-01-23  Tom Tromey  <tom@tromey.com>
5099             Pedro Alves  <palves@redhat.com>
5100
5101         * breakpoint.c (create_breakpoint): Remove cleanup.
5102
5103 2019-01-23  Tom Tromey  <tom@tromey.com>
5104             Andrew Burgess  <andrew.burgess@embecosm.com>
5105             Pedro Alves  <palves@redhat.com>
5106
5107 2019-01-23  Pedro Alves  <palves@redhat.com>
5108
5109         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5110
5111 2019-01-23  Pedro Alves  <palves@redhat.com>
5112             Andrew Burgess  <andrew.burgess@embecosm.com>
5113
5114         * gdbthread.h: Include "common/forward-scope-exit.h".
5115         (scoped_finish_thread_state): Redefine custom class in terms of
5116         forward_scope_exit.
5117
5118 2019-01-23  Pedro Alves  <palves@redhat.com>
5119             Andrew Burgess  <andrew.burgess@embecosm.com>
5120
5121         * common/forward-scope-exit.h: New file.
5122
5123 2019-01-23  Pedro Alves  <palves@redhat.com>
5124             Andrew Burgess  <andrew.burgess@embecosm.com>
5125             Tom Tromey  <tom@tromey.com>
5126
5127         * common/scope-exit.h: New file.
5128
5129 2019-01-23  Pedro Alves  <palves@redhat.com>
5130
5131         * common/preprocessor.h (ESC): Rename to ...
5132         (ESC_PARENS): ... this.
5133         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5134         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5135
5136 2019-01-23  Tom Tromey  <tom@tromey.com>
5137
5138         * language.h (class scoped_switch_to_sym_language_if_auto):
5139         Initialize m_lang in both cases.
5140
5141 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5142
5143         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5144         with XCNEW.
5145
5146 2019-01-22  Tom Tromey  <tom@tromey.com>
5147
5148         * corelow.c: Do not include sys/file.h.
5149
5150 2019-01-22  Tom Tromey  <tom@tromey.com>
5151
5152         * tui/tui-wingeneral.h: Include gdb_curses.h.
5153
5154 2019-01-22  Tom Tromey  <tom@tromey.com>
5155
5156         * source-cache.h (class source_cache) <get_source_lines,
5157         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5158
5159 2019-01-22  Tom Tromey  <tom@tromey.com>
5160
5161         * remote-fileio.h (struct remote_target): Declare.
5162
5163 2019-01-22  Tom Tromey  <tom@tromey.com>
5164
5165         * python/py-arch.c: Do not include py-ref.h.
5166         * python/py-bpevent.c: Do not include py-ref.h.
5167         * python/py-cmd.c: Do not include py-ref.h.
5168         * python/py-continueevent.c: Do not include py-ref.h.
5169         * python/py-event.h: Do not include py-ref.h.
5170         * python/py-evtregistry.c: Do not include py-ref.h.
5171         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5172         * python/py-frame.c: Do not include py-ref.h.
5173         * python/py-framefilter.c: Do not include py-ref.h.
5174         * python/py-function.c: Do not include py-ref.h.
5175         * python/py-infevents.c: Do not include py-ref.h.
5176         * python/py-linetable.c: Do not include py-ref.h.
5177         * python/py-objfile.c: Do not include py-ref.h.
5178         * python/py-param.c: Do not include py-ref.h.
5179         * python/py-prettyprint.c: Do not include py-ref.h.
5180         * python/py-progspace.c: Do not include py-ref.h.
5181         * python/py-symbol.c: Do not include py-ref.h.
5182         * python/py-symtab.c: Do not include py-ref.h.
5183         * python/py-type.c: Do not include py-ref.h.
5184         * python/py-unwind.c: Do not include py-ref.h.
5185         * python/py-utils.c: Do not include py-ref.h.
5186         * python/py-value.c: Do not include py-ref.h.
5187         * python/py-varobj.c: Do not include py-ref.h.
5188         * python/py-xmethods.c: Do not include py-ref.h.
5189         * python/python.c: Do not include py-ref.h.
5190         * varobj.c: Do not include py-ref.h.
5191
5192 2019-01-22  Tom Tromey  <tom@tromey.com>
5193
5194         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5195         keyword for bcache.
5196
5197 2019-01-22  Tom Tromey  <tom@tromey.com>
5198
5199         * compile/compile-cplus-types.c: Remove a comment by #include.
5200
5201 2019-01-22  Tom Tromey  <tom@tromey.com>
5202
5203         * compile/gcc-c-plugin.h: Include compile-internal.h.
5204
5205 2019-01-22  Tom Tromey  <tom@tromey.com>
5206
5207         * stabsread.c (EXTERN): Do not define.
5208         (symnum, next_symbol_text_func, processing_gcc_compilation)
5209         (within_function, global_sym_chain, global_stabs)
5210         (previous_stab_code, this_object_header_files)
5211         (n_this_object_header_files)
5212         (n_allocated_this_object_header_files): Define.
5213         * stabsread.h (EXTERN): Never define.  Use "extern".
5214
5215 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5216
5217         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5218         history_value.
5219
5220 2019-01-21  Tom Tromey  <tom@tromey.com>
5221
5222         * ui-out.c: Fix includes.
5223         * tui/tui-source.c: Fix includes.
5224         * target.c: Fix includes.
5225         * remote.c: Fix includes.
5226         * regcache.c: Fix includes.
5227         * python/py-block.c: Fix includes.
5228         * printcmd.c: Fix includes.
5229         * or1k-tdep.c: Fix includes.
5230         * mi/mi-main.c: Fix includes.
5231         * m32r-tdep.c: Fix includes.
5232         * csky-tdep.c: Fix includes.
5233         * compile/compile-cplus-types.c: Fix includes.
5234         * cli/cli-interp.c: Fix includes.
5235
5236 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5237
5238         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5239         for padding.
5240
5241 2019-01-16  Tom Tromey  <tom@tromey.com>
5242
5243         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5244         earlier.
5245         (struct objfile) <msymbols_range>: Move from top level.
5246         <msymbols>: New method.
5247         (class objfile_msymbols): Remove.
5248         * symtab.c (default_collect_symbol_completion_matches_break_on):
5249         Update.
5250         * symmisc.c (dump_msymbols): Update.
5251         * stabsread.c (scan_file_globals): Update.
5252         * objc-lang.c (info_selectors_command, info_classes_command)
5253         (find_methods): Update.
5254         * minsyms.c (find_solib_trampoline_target): Update.
5255         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5256         * coffread.c (coff_symfile_read): Update.
5257         * ada-lang.c (ada_lookup_simple_minsym)
5258         (ada_collect_symbol_completion_matches): Update.
5259
5260 2019-01-16  Tom Tromey  <tom@tromey.com>
5261
5262         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5263         type.  Remove no-argument constructor.
5264         <iterator::operator++>: Simplify.
5265         <begin>: Update.
5266         <end>: Use minimal_symbol_count.
5267
5268 2019-01-16  Tom Tromey  <tom@tromey.com>
5269
5270         * objfiles.h (struct objfile) <psymtabs>: New method.
5271         (class objfile_psymtabs): Remove.
5272         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5273         typedef.
5274         <range>: New method.
5275         (require_partial_symbols): Change return type.
5276         * psymtab.c (require_partial_symbols)
5277         (psym_expand_symtabs_matching): Update.
5278         * mdebugread.c (parse_partial_symbols): Update.
5279         * dbxread.c (dbx_end_psymtab): Update.
5280
5281 2019-01-15  Tom Tromey  <tom@tromey.com>
5282
5283         * symtab.c (lookup_objfile_from_block)
5284         (lookup_symbol_in_objfile_symtabs)
5285         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5286         (find_line_symtab, info_sources_command)
5287         (default_collect_symbol_completion_matches_break_on)
5288         (make_source_files_completion_list): Update.
5289         * symmisc.c (print_objfile_statistics, dump_objfile)
5290         (maintenance_print_symbols, maintenance_info_symtabs)
5291         (maintenance_check_symtabs, maintenance_info_line_tables):
5292         Update.
5293         * source.c (select_source_symtab)
5294         (forget_cached_source_info_for_objfile): Update.
5295         * objfiles.h (class objfile_compunits): Remove.
5296         (struct objfile) <compunits_range>: New typedef.
5297         (compunits): New method.
5298         * objfiles.c (objfile_relocate1): Update.
5299         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5300         * maint.c (count_symtabs_and_blocks): Update.
5301         * linespec.c (iterate_over_all_matching_symtabs): Update.
5302         * cp-support.c (add_symbol_overload_list_qualified): Update.
5303         * coffread.c (coff_symtab_read): Update.
5304         * ada-lang.c (add_nonlocal_symbols)
5305         (ada_collect_symbol_completion_matches)
5306         (ada_add_global_exceptions): Update.
5307
5308 2019-01-15  Tom Tromey  <tom@tromey.com>
5309
5310         * progspace.h (program_space) <objfiles_safe_range>: New
5311         typedef.
5312         <objfiles_safe>: New method.
5313         * objfiles.h (class all_objfiles_safe): Remove.
5314         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5315         * jit.c (jit_inferior_exit_hook): Update.
5316
5317 2019-01-17  Tom Tromey  <tom@tromey.com>
5318
5319         * progspace.h (program_space) <objfiles_range>: New typedef.
5320         <objfiles>: New method.
5321         <objfiles_head>: Rename from objfiles.
5322         (object_files): Update.
5323         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5324         * guile/scm-pretty-print.c
5325         (ppscm_find_pretty_printer_from_objfiles): Update.
5326         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5327         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5328         Update.
5329         * python/py-progspace.c (pspy_get_objfiles): Update.
5330         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5331         Update.
5332         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5333         (objfpy_lookup_objfile_by_build_id): Update.
5334         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5335         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5336         Update.
5337         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5338         (expand_symtab_containing_pc, lookup_objfile_from_block)
5339         (lookup_static_symbol, basic_lookup_transparent_type)
5340         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5341         (find_line_symtab, info_sources_command)
5342         (default_collect_symbol_completion_matches_break_on)
5343         (make_source_files_completion_list, find_main_name): Update.
5344         * symmisc.c (print_symbol_bcache_statistics)
5345         (print_objfile_statistics, maintenance_print_symbols)
5346         (maintenance_print_msymbols, maintenance_print_objfiles)
5347         (maintenance_info_symtabs, maintenance_check_symtabs)
5348         (maintenance_expand_symtabs, maintenance_info_line_tables):
5349         Update.
5350         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5351         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5352         (map_overlay_command, unmap_overlay_command)
5353         (simple_overlay_update, expand_symtabs_matching)
5354         (map_symbol_filenames): Update.
5355         * symfile-debug.c (set_debug_symfile): Update.
5356         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5357         Update.
5358         * source.c (select_source_symtab, forget_cached_source_info):
5359         Update.
5360         * solib.c (solib_read_symbols): Update.
5361         * solib-spu.c (append_ocl_sos): Update.
5362         * psymtab.c (maintenance_print_psymbols)
5363         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5364         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5365         * printcmd.c (info_symbol_command): Update.
5366         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5367         Update.
5368         * objfiles.h (class all_objfiles): Remove.
5369         * objfiles.c (have_partial_symbols, have_full_symbols)
5370         (have_minimal_symbols, qsort_cmp, update_section_map)
5371         (shared_objfile_contains_address_p)
5372         (default_iterate_over_objfiles_in_search_order): Update.
5373         * objc-lang.c (info_selectors_command, info_classes_command)
5374         (find_methods): Update.
5375         * minsyms.c (find_solib_trampoline_target): Update.
5376         * maint.c (maintenance_info_sections)
5377         (maintenance_translate_address, count_symtabs_and_blocks):
5378         Update.
5379         * main.c (captured_main_1): Update.
5380         * linux-thread-db.c (try_thread_db_load_from_pdir)
5381         (has_libpthread): Update.
5382         * linespec.c (iterate_over_all_matching_symtabs)
5383         (search_minsyms_for_name): Update.
5384         * jit.c (jit_find_objf_with_entry_addr): Update.
5385         * hppa-tdep.c (find_unwind_entry)
5386         (hppa_lookup_stub_minimal_symbol): Update.
5387         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5388         Update.
5389         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5390         (elf_gnu_ifunc_resolve_by_got): Update.
5391         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5392         * dwarf-index-write.c (save_gdb_index_command): Update.
5393         * cp-support.c (add_symbol_overload_list_qualified): Update.
5394         * breakpoint.c (create_overlay_event_breakpoint)
5395         (create_longjmp_master_breakpoint)
5396         (create_std_terminate_master_breakpoint)
5397         (create_exception_master_breakpoint): Update.
5398         * blockframe.c (find_pc_partial_function): Update.
5399         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5400         (ada_collect_symbol_completion_matches)
5401         (ada_add_global_exceptions): Update.
5402
5403 2019-01-17  Tom Tromey  <tom@tromey.com>
5404
5405         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5406         declare VEC.
5407         (solib_target_parse_libraries): Change return type.
5408         (library_list_start_segment, library_list_start_section)
5409         (library_list_end_library, library_list_start_library); Update.
5410         (solib_target_free_library_list): Remove.
5411         (solib_target_parse_libraries): Remove cleanup.  Change return
5412         type.
5413         (solib_target_current_sos): Update.
5414
5415 2019-01-17  Tom Tromey  <tromey@bapiya>
5416
5417         * valprint.c: Replace "the the" with "the".
5418         * symtab.c: Replace "the the" with "the".
5419         * solib.c: Replace "the the" with "the".
5420         * solib-dsbt.c: Replace "the the" with "the".
5421         * linespec.c: Replace "the the" with "the".
5422         * dwarf2loc.h: Replace "the the" with "the".
5423         * amd64-windows-tdep.c: Replace "the the" with "the".
5424         * aarch64-tdep.c: Replace "the the" with "the".
5425
5426 2019-01-16  Keith Seitz  <keiths@redhat.com>
5427
5428         PR gdb/23773
5429         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5430         <builder>: Rename to ..
5431         <m_builder>: ... this and make private.
5432         (dwarf2_cu::get_builder): New method.  Change all users of
5433         `builder' to use this method.
5434         (dwarf2_start_symtab): Move to ...
5435         (dwarf2_cu::start_symtab): ... here.  Update all callers
5436         (setup_type_unit_groups): Move to ...
5437         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5438         callers.
5439         (dwarf2_cu::reset_builder): New method.
5440         (process_full_compunit, process_full_type_unit): Use
5441         dwarf2_cu::reset_builder.
5442         (follow_die_offset): Record the ancestor CU if it is different
5443         from the followed DIE's CU.
5444         (follow_die_sig_1): Likewise.
5445
5446 2019-01-15  Tom Tromey  <tom@tromey.com>
5447
5448         * remote.c (class remote_state) <buf>: Now a char_vector.
5449         <buf_size>: Remove.
5450         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5451         parameter.
5452         (remote_target::getpkt_or_notif_sane_1)
5453         (remote_target::getpkt_sane)
5454         (remote_target::getpkt_or_notif_sane): Likewise.
5455         (class remote_target) <putpkt>: New overload.
5456         (remote_target::read_frame): Change type of "buf_p".  Remove
5457         sizeof_p parameter.
5458         (packet_ok): New overload.
5459         (packet_check_result): New overload.
5460         Update all uses.
5461
5462 2019-01-14  Tom Tromey  <tom@tromey.com>
5463
5464         * remote-notif.c (handle_notification, remote_notif_ack)
5465         (remote_notif_parse): Make "buf" const.
5466         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5467         const.
5468         (remote_notif_parse, remote_notif_ack, handle_notification):
5469         Likewise.
5470         * remote.c (remote_notif_stop_parse): Make "buf" const.
5471         (remote_target::remote_parse_stop_reply): Make "buf" const.
5472         (remote_notif_stop_ack): Make "buf" const.
5473
5474 2019-01-14  Tom Tromey  <tom@tromey.com>
5475
5476         * remote.c (remote_console_output): Make parameter const.
5477
5478 2019-01-14  Tom Tromey  <tom@tromey.com>
5479
5480         * target-debug.h (target_debug_print_signals): Constify.
5481         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5482         * procfs.c (procfs_target::pass_signals): Update.
5483         * linux-nat.c (linux_nat_target::pass_signals): Update.
5484         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5485         * target-delegates.c: Rebuild.
5486         * remote.c (remote_target::program_signals): Update.
5487         (remote_target::pass_signals): Update.
5488         * target.c (target_pass_signals): Constify argument.
5489         (target_program_signals): Likewise.
5490         * target.h (struct target_ops) <pass_signals, program_signals>:
5491         Constify argument.
5492         (target_pass_signals, target_program_signals): Constify argument.
5493
5494 2019-01-14  Tom Tromey  <tom@tromey.com>
5495
5496         PR tui/28819:
5497         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5498
5499 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5500
5501         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
5502         field.
5503         * rs6000-tdep.c: Include reggroups.h.
5504         (IS_V_ALIAS_PSEUDOREG): Define.
5505         (rs6000_register_name): Return names for the "vX" aliases.
5506         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
5507         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
5508         aliases.  Call default_register_reggroup_p for all other
5509         pseudo-registers.
5510         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
5511         New functions.
5512         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
5513         Handle "vX" aliases.
5514         (v_alias_pseudo_register_collect): New function.
5515         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
5516         (rs6000_gdbarch_init): Initialize "vX" aliases as
5517         pseudo-registers.  Restore registration of
5518         rs6000_pseudo_register_reggroup_p with
5519         set_tdesc_pseudo_register_reggroup_p.
5520
5521 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
5522
5523         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
5524         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
5525         set_gdbarch_num_pseudo_regs.
5526
5527 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5528
5529         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
5530         Remove arg prefixname, add do_set and do_show.
5531         Add member functions set_list and show_list.
5532         * cli/cli-style.c (class cli_style_option): Update accordingly.
5533         (style_set_list): Move to file scope.
5534         (style_show_list): Likewise.
5535         (set_style): Call help_list.
5536         (show_style): Call cmd_show_list.
5537         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
5538         Update to use the new macro.
5539
5540 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5541
5542         * ada-lang.c (_initialize_ada_language): Expand the help text
5543         for the "catch exception" command.
5544
5545 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5546
5547         * symtab.c (matching_obj_sections): Initialize obj,
5548         declare it closer to its usage.
5549
5550 2019-01-10  Tom Tromey  <tom@tromey.com>
5551
5552         * thread-iter.h (inf_threads_iterator): Use next_iterator.
5553         (basic_inf_threads_range): Remove.
5554         (inf_threads_range, inf_non_exited_threads_range)
5555         (safe_inf_threads_range): Use next_adapter.
5556
5557 2019-01-10  Keith Seitz  <keiths@redhat.com>
5558
5559         PR gdb/23712
5560         PR symtab/23010
5561         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
5562         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
5563
5564 2019-01-10  Keith Seitz  <keiths@redhat.com>
5565
5566         PR gdb/23712
5567         PR symtab/23010
5568         * dictionary.c (pending_to_vector): Remove.
5569         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5570         Remove _1 suffix, replacing functions of the same name.  Update
5571         all callers.
5572         (dict_create_hashed, dict_create_hashed_expandable)
5573         (dict_create_linear, dict_create_linear_expandable, dict_free)
5574         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
5575         Make functions static.
5576
5577 2019-01-10  Keith Seitz  <keiths@redhat.com>
5578
5579         PR gdb/23712
5580         PR symtab/23010
5581         * dictionary.h (struct dictionary): Replace declaration with
5582         multidictionary.
5583         (dict_create_hashed, dict_create_hashed_expandable)
5584         (dict_create_linear, dict_create_linear_expandable)
5585         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
5586         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
5587         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
5588         taking multidictionary argument.
5589         [ALL_DICT_SYMBOLS]: Update for multidictionary.
5590         * block.h (struct block) <dict>: Change to multidictionary
5591         and rename `multidict'.
5592         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
5593         symmisc.c: Update all dictionary references to multidictionary.
5594
5595 2019-01-10  Keith Seitz  <keiths@redhat.com>
5596
5597         PR gdb/23712
5598         PR symtab/23010
5599         * dictionary.c: Include unordered_map.
5600         (pending_to_vector): New function.
5601         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5602         Rewrite the non-"_1" functions to take vector instead
5603         of linked list.
5604         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
5605         "new" _1 versions of the same name.
5606         (multidictionary): Define.
5607         (std::hash<enum language): New definition.
5608         (collate_pending_symbols_by_language, mdict_create_hashed)
5609         (mdict_create_hashed_expandable, mdict_create_linear)
5610         (mdict_create_linear_expandable, mdict_free)
5611         (find_language_dictionary, create_new_language_dictionary)
5612         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
5613         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
5614         (mdict_size, mdict_empty): New functions.
5615         * dictionary.h (mdict_iterator): Define.
5616
5617 2019-01-10  Pedro Alves  <palves@redhat.com>
5618
5619         * breakpoint.c (read_uploaded_action)
5620         (create_tracepoint_from_upload): Adjust to use
5621         gdb::unique_xmalloc_ptr.
5622         * ctf.c (ctf_write_uploaded_tp):
5623         (SET_ARRAY_FIELD): Use emplace_back.
5624         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
5625         * tracefile-tfile.c (tfile_write_uploaded_tp):
5626         * tracepoint.c (parse_tracepoint_definition): Adjust to use
5627         gdb::unique_xmalloc_ptr.
5628         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
5629         at_string, cond_string, cmd_strings>: Replace char pointers
5630         with gdb::unique_xmalloc_ptr.
5631
5632 2019-01-10  Pedro Alves  <palves@redhat.com>
5633
5634         * solib-target.c (library_list_start_library): Don't xstrdup name.
5635
5636 2019-01-10  Pedro Alves  <palves@redhat.com>
5637
5638         * mdebugread.c (parse_partial_symbols): Use
5639         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
5640
5641 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5642
5643         * linux-fork.c (scoped_switch_fork_info)
5644         <~scoped_switch_fork_info>: Fix incorrect variable name.
5645
5646 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5647
5648         * linux-fork.c (scoped_switch_fork_info)
5649         <scoped_switch_fork_info>: Make explicit.
5650         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
5651
5652 2019-01-10  Tom Tromey  <tom@tromey.com>
5653
5654         * objfiles.h (objfile::reset_psymtabs): Update.
5655         * objfiles.c (objfile::objfile): Update.
5656         * psymtab.h (psymtab_storage::obstack): Update.
5657         (psymtab_storage::m_obstack): Use gdb::optional.
5658         (class psymtab_storage): Update comment.  Remove objfile
5659         parameter.
5660         * psymtab.c (psymtab_storage::psymtab_storage): Update.
5661
5662 2019-01-10  Tom Tromey  <tom@tromey.com>
5663
5664         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
5665         <free_psymtabs>: Now private.
5666         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
5667         (allocate_psymtab): Use new method.
5668
5669 2019-01-10  Tom Tromey  <tom@tromey.com>
5670
5671         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
5672         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
5673         * mdebugread.c (parse_partial_symbols): Use
5674         allocate_dependencies.
5675         * dwarf2read.c (dwarf2_create_include_psymtab): Use
5676         allocate_dependencies.
5677         (process_psymtab_comp_unit_reader)
5678         (build_type_psymtab_dependencies): Likewise.
5679         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
5680
5681 2019-01-10  Tom Tromey  <tom@tromey.com>
5682
5683         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
5684         PSYMBOL_SET_LANGUAGE.
5685         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
5686
5687 2019-01-10  Tom Tromey  <tom@tromey.com>
5688
5689         * psymtab.h (psymtab_storage::obstack): New method.
5690         <m_obstack>: Rename from obstack; now private.
5691         * psymtab.c (psymtab_storage): Update.
5692         * dwarf2read.c (create_addrmap_from_index)
5693         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
5694         Update.
5695
5696 2019-01-10  Tom Tromey  <tom@tromey.com>
5697
5698         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
5699         * objfiles.h (objfile::reset_psymtabs): New method.
5700
5701 2019-01-10  Tom Tromey  <tom@tromey.com>
5702
5703         * symmisc.c (print_symbol_bcache_statistics): Update.
5704         (print_objfile_statistics): Update.
5705         * symfile.c (reread_symbols): Update.
5706         * psymtab.h (class psymtab_storage): New.
5707         * psymtab.c (psymtab_storage): New constructor.
5708         (~psymtab_storage): New destructor.
5709         (require_partial_symbols): Update.
5710         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
5711         (find_pc_sect_psymtab, find_pc_sect_psymbol)
5712         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
5713         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
5714         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
5715         (start_psymtab_common, end_psymtab_common)
5716         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
5717         (allocate_psymtab): Update.
5718         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
5719         Update.
5720         (dump_psymtab_addrmap, maintenance_print_psymbols)
5721         (maintenance_check_psymtabs): Update.
5722         (class objfile_psymtabs): Move to objfiles.h.
5723         * psympriv.h (discard_psymtab): Now inline.
5724         (psymtab_discarder::psymtab_discarder): Update.
5725         (psymtab_discarder::~psymtab_discarder): Update.
5726         (ALL_OBJFILE_PSYMTABS): Rewrite.
5727         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
5728         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
5729         Remove fields.
5730         <partial_symtabs>: New field.
5731         (class objfile_psymtabs): Move from psymtab.h.  Update.
5732         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
5733         psymbol_cache.
5734         (objfile::~objfile): Don't destroy psymbol_cache.
5735         * mdebugread.c (parse_partial_symbols): Update.
5736         * dwarf2read.c (create_addrmap_from_index)
5737         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5738         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
5739         (add_partial_subprogram, dwarf2_ranges_read): Update.
5740         * dwarf-index-write.c (write_address_map)
5741         (write_one_signatured_type, recursively_write_psymbols)
5742         (class debug_names, class debug_names, write_psymtabs_to_index):
5743         Update.
5744
5745 2019-01-10  Tom Tromey  <tom@tromey.com>
5746
5747         * symtab.h (SYMBOL_SET_NAMES): Update.
5748         (symbol_set_names): Update.
5749         (MSYMBOL_SET_NAMES): Update.
5750         * symtab.c (symbol_set_names): Change argument to be an
5751         objfile_per_bfd_storage.
5752         * psymtab.c (add_psymbol_to_bcache): Update.
5753         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
5754
5755 2019-01-10  Tom Tromey  <tom@tromey.com>
5756
5757         * symtab.c (create_demangled_names_hash): Change argument to be an
5758         objfile_per_bfd_storage.
5759         (symbol_set_names): Update.
5760
5761 2019-01-10  Tom Tromey  <tom@tromey.com>
5762
5763         * xcoffread.c (xcoff_initial_scan): Unconditionally call
5764         init_psymbol_list.
5765         * psymtab.c (init_psymbol_list): Do nothing if already called.
5766         * psympriv.h (init_psymbol_list): Add comment.
5767         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
5768         init_psymbol_list.
5769         * dbxread.c (dbx_symfile_read): Unconditionally call
5770         init_psymbol_list.
5771
5772 2019-01-10  Tom Tromey  <tom@tromey.com>
5773
5774         * xcoffread.c (scan_xcoff_symtab): Update.
5775         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
5776         "where".
5777         * mdebugread.c (parse_partial_symbols)
5778         (handle_psymbol_enumerators): Update.
5779         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
5780         * dbxread.c (read_dbx_symtab): Update.
5781         * psympriv.h (psymbol_placement): New enum.
5782         (add_psymbol_to_list): Update.
5783
5784 2019-01-10  Tom Tromey  <tom@tromey.com>
5785
5786         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
5787         static_psymbols parameters.
5788         (scan_xcoff_symtab): Update.
5789         * psymtab.c (start_psymtab_common): Remove global_psymbols and
5790         static_psymbols parameters.
5791         * psympriv.h (start_psymtab_common): Update.
5792         * mdebugread.c (parse_partial_symbols): Update.
5793         * dwarf2read.c (create_partial_symtab): Update.
5794         * dbxread.c (read_dbx_symtab): Update.
5795         (start_psymtab): Remove global_psymbols and static_psymbols
5796         parameters.
5797
5798 2019-01-10  Tom Tromey  <tom@tromey.com>
5799
5800         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
5801         * psymtab.c (allocate_psymtab): Add comment.
5802         * psympriv.h (allocate_psymtab): Add comment.
5803         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
5804         initializations.
5805         * dbxread.c (dbx_end_psymtab): Remove some initializations.
5806
5807 2019-01-10  Tom Tromey  <tom@tromey.com>
5808
5809         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5810         Don't declare.
5811         * mipsread.c: Include mdebugread.h.
5812         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5813         Declare.
5814         * elfread.c: Include mdebugread.h.
5815
5816 2019-01-09  Tom Tromey  <tom@tromey.com>
5817
5818         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
5819         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
5820         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
5821         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
5822         (psym_lookup_symbol, psym_find_last_source_symtab)
5823         (psym_forget_cached_source_info, psym_print_stats)
5824         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
5825         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
5826         (psym_map_matching_symbols, psym_expand_symtabs_matching)
5827         (psym_find_compunit_symtab_by_address)
5828         (maintenance_print_psymbols, maintenance_info_psymtabs)
5829         (maintenance_check_psymtabs): Use ranged for.
5830         * psymtab.h (class objfile_psymtabs): New.
5831         (require_partial_symbols): Return objfile_psymtabs.
5832         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
5833
5834 2019-01-09  Tom Tromey  <tom@tromey.com>
5835
5836         * symfile.c (overlay_invalidate_all, find_pc_overlay)
5837         (find_pc_mapped_section, list_overlays_command)
5838         (map_overlay_command, unmap_overlay_command)
5839         (simple_overlay_update): Use all_objfiles.
5840         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
5841         * printcmd.c (info_symbol_command): Use all_objfiles.
5842         * objfiles.h (ALL_OBJSECTIONS): Remove.
5843         * maint.c (maintenance_translate_address): Use all_objfiles.
5844         * gcore.c (gcore_create_callback): Use all_objfiles.
5845         (objfile_find_memory_regions): Likewise.
5846
5847 2019-01-09  Tom Tromey  <tom@tromey.com>
5848
5849         * symtab.c (find_line_symtab, info_sources_command)
5850         (make_source_files_completion_list): Use objfile_compunits.
5851         * source.c (select_source_symtab): Use objfile_compunits.
5852         * objfiles.h (struct objfile): Update comment.
5853         (ALL_OBJFILES): Remove.
5854         (ALL_FILETABS): Remove.
5855         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
5856         objfile_compunits.
5857
5858 2019-01-09  Tom Tromey  <tom@tromey.com>
5859
5860         * symmisc.c (print_objfile_statistics, dump_objfile)
5861         (maintenance_print_symbols): Use compunit_filetabs.
5862         * source.c (forget_cached_source_info_for_objfile): Use
5863         compunit_filetabs.
5864         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
5865         (ALL_FILETABS): Use compunit_filetabs.
5866         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
5867         * coffread.c (coff_symtab_read): Use compunit_filetabs.
5868
5869 2019-01-09  Tom Tromey  <tom@tromey.com>
5870
5871         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
5872         (compunit_filetabs): New.
5873         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
5874         compunit_filetabs.
5875         (info_sources_command, make_source_files_completion_list): Remove
5876         declaration.
5877         * symmisc.c (print_objfile_statistics, dump_objfile)
5878         (maintenance_print_symbols): Remove declaration.
5879         (maintenance_info_symtabs): Use compunit_filetabs.
5880         (maintenance_info_line_tables): Likewise.
5881         * source.c (select_source_symtab): Change local variable name.
5882         (forget_cached_source_info_for_objfile): Remove declaration.
5883         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
5884         * objfiles.c (objfile_relocate1): Remove declaration.
5885         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5886         declaration.
5887         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
5888         * coffread.c (coff_symtab_read): Remove declaration.
5889         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5890         compunit_filetabs.
5891
5892 2019-01-09  Tom Tromey  <tom@tromey.com>
5893
5894         * symtab.c (lookup_objfile_from_block)
5895         (find_pc_sect_compunit_symtab, search_symbols)
5896         (default_collect_symbol_completion_matches_break_on): Use
5897         objfile_compunits.
5898         * objfiles.h (ALL_COMPUNITS): Remove.
5899         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
5900         * cp-support.c (add_symbol_overload_list_qualified): Use
5901         objfile_compunits.
5902         * ada-lang.c (ada_collect_symbol_completion_matches)
5903         (ada_add_global_exceptions): Use objfile_compunits.
5904
5905 2019-01-09  Tom Tromey  <tom@tromey.com>
5906
5907         * source.c (select_source_symtab)
5908         (forget_cached_source_info_for_objfile): Remove declaration.
5909         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5910         declaration.
5911         * maint.c (count_symtabs_and_blocks): Remove declaration.
5912         * cp-support.c (add_symbol_overload_list_qualified): Remove
5913         declaration.
5914         * coffread.c (coff_symtab_read): Remove declaration.
5915         * symtab.c (lookup_symbol_in_objfile_symtabs)
5916         (basic_lookup_transparent_type_1): Use objfile_compunits.
5917         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
5918         (info_sources_command, search_symbols)
5919         (default_collect_symbol_completion_matches_break_on)
5920         (make_source_files_completion_list): Remove declaration.
5921         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
5922         (ada_collect_symbol_completion_matches)
5923         (ada_add_global_exceptions): Remove declaration.
5924         * linespec.c (iterate_over_all_matching_symtabs): Use
5925         objfile_compunits.
5926         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
5927         (class objfile_compunits): New.
5928         (ALL_COMPUNITS): Use objfile_compunits.
5929         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
5930         (maintenance_check_symtabs, maintenance_info_line_tables): Use
5931         objfile_compunits.
5932         * objfiles.c (objfile_relocate1): Use objfile_compunits.
5933
5934 2019-01-09  Tom Tromey  <tom@tromey.com>
5935
5936         * symtab.c (search_symbols)
5937         (default_collect_symbol_completion_matches_break_on): Use
5938         objfile_msymbols.
5939         * ada-lang.c (ada_lookup_simple_minsym)
5940         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
5941         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
5942         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
5943         objfile_msymbols.
5944         * coffread.c (coff_symfile_read): Use objfile_msymbols.
5945         * symmisc.c (dump_msymbols): Use objfile_msymbols.
5946         * objc-lang.c (find_methods): Use objfile_msymbols.
5947         (info_selectors_command, info_classes_command): Likewise.
5948         * stabsread.c (scan_file_globals): Use objfile_msymbols.
5949         * objfiles.h (class objfile_msymbols): New.
5950         (ALL_OBJFILE_MSYMBOLS): Remove.
5951         (ALL_MSYMBOLS): Remove.
5952
5953 2019-01-09  Tom Tromey  <tom@tromey.com>
5954
5955         * common/next-iterator.h (next_adapter): Add Iterator template
5956         parameter.
5957         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
5958         (class all_objfiles_safe): New.
5959         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
5960         * objfiles.c (put_objfile_before): Update comment.
5961         (add_separate_debug_objfile): Likewise.
5962         (free_all_objfiles): Use all_objfiles_safe.
5963         (objfile_purge_solibs): Likewise.
5964
5965 2019-01-09  Tom Tromey  <tom@tromey.com>
5966
5967         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5968         (expand_symtab_containing_pc, lookup_static_symbol)
5969         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
5970         (find_symbol_at_address, find_line_symtab, find_main_name): Use
5971         all_objfiles.
5972         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
5973         * breakpoint.c (create_overlay_event_breakpoint)
5974         (create_longjmp_master_breakpoint)
5975         (create_std_terminate_master_breakpoint)
5976         (create_exception_master_breakpoint): Use all_objfiles.
5977         * linux-thread-db.c (try_thread_db_load_from_pdir)
5978         (has_libpthread): Use all_objfiles.
5979         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
5980         * linespec.c (iterate_over_all_matching_symtabs)
5981         (search_minsyms_for_name): Use all_objfiles.
5982         * maint.c (maintenance_info_sections): Use all_objfiles.
5983         * main.c (captured_main_1): Use all_objfiles.
5984         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
5985         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
5986         * guile/scm-pretty-print.c
5987         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
5988         * solib-spu.c (append_ocl_sos): Use all_objfiles.
5989         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
5990         (maintenance_print_msymbols): Use all_objfiles.
5991         * source.c (select_source_symtab): Use all_objfiles.
5992         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
5993         * symfile.c (remove_symbol_file_command)
5994         (expand_symtabs_matching, map_symbol_filenames): Use
5995         all_objfiles.
5996         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
5997         all_objfiles.
5998         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
5999         * objc-lang.c (find_methods): Use all_objfiles.
6000         * objfiles.c (have_partial_symbols, have_full_symbols)
6001         (have_minimal_symbols, qsort_cmp)
6002         (default_iterate_over_objfiles_in_search_order): Use
6003         all_objfiles.
6004         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
6005         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
6006         (maintenance_check_psymtabs): Use all_objfiles.
6007         (ALL_PSYMTABS): Remove.
6008         * compile/compile-object-run.c (do_module_cleanup): Use
6009         all_objfiles.
6010         * blockframe.c (find_pc_partial_function): Use all_objfiles.
6011         * cp-support.c (add_symbol_overload_list_qualified): Use
6012         all_objfiles.
6013         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6014         Use all_objfiles.
6015         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
6016         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
6017         all_objfiles.
6018         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6019         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
6020         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6021         Uses all_objfiles.
6022         * solib.c (solib_read_symbols): Use all_objfiles
6023
6024 2019-01-09  Tom Tromey  <tom@tromey.com>
6025
6026         * probe.c (parse_probes_in_pspace): Use all_objfiles.
6027         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
6028         all_objfiles.
6029         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
6030         * symmisc.c (print_symbol_bcache_statistics)
6031         (print_objfile_statistics, maintenance_print_objfiles)
6032         (maintenance_info_symtabs, maintenance_check_symtabs)
6033         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
6034         all_objfiles.
6035         * source.c (forget_cached_source_info): Use all_objfiles.
6036         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
6037         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6038         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
6039         * objfiles.c (update_section_map): Use all_objfiles.
6040         (shared_objfile_contains_address_p): Likewise.
6041         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
6042         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
6043
6044 2019-01-09  Tom Tromey  <tom@tromey.com>
6045
6046         * common/next-iterator.h: New file.
6047         * objfiles.h (class all_objfiles): New.
6048         (struct objfile_iterator): New.
6049
6050 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6051
6052         * NEWS: Move the description of the changed "frame", "select-frame",
6053          and "info frame" commands to the Changed commands section.
6054
6055 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
6056
6057         * gdbtypes.c (check_stub_method_group): Remove handling of old
6058         mangling schemes.
6059         * linespec.c (find_methods): Likewise.
6060         * stabsread.c (read_member_functions): Likewise.
6061         * valops.c (search_struct_method): Likewise.
6062         (value_struct_elt_for_reference): Likewise.
6063         * NEWS: Mention this change.
6064
6065 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6066
6067         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
6068         print_source_lines.
6069         * source.c (print_source_lines_base): Update line number check.
6070         (print_source_lines): New function.
6071         (source_lines_range::source_lines_range): New function.
6072         * source.h (class source_lines_range): New class.
6073         (print_source_lines): New declaration.
6074
6075 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6076
6077         * linespec.c (linespec_state_destructor): Free self->canonical_names.
6078
6079 2019-01-08  Tom Tromey  <tom@tromey.com>
6080             Simon Marchi  <simon.marchi@ericsson.com>
6081
6082         PR gdb/24060
6083         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
6084         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
6085         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6086         * f-exp.y (DOLLAR_VARIABLE): Likewise.
6087         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
6088         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6089
6090 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6091
6092         * source.c (select_source_symtab): Move header comment to
6093         declaration in source.h.
6094         (forget_cached_source_info_for_objfile): Likewise.
6095         (forget_cached_source_info): Likewise.
6096         (identify_source_line): Likewise.
6097         * source.h (identify_source_line): Move declaration from symtab.h
6098         and add comment from source.c
6099         (print_source_lines): Likewise.
6100         (forget_cached_source_info_for_objfile): Likewise.
6101         (forget_cached_source_info): Likewise.
6102         (select_source_symtab): Likewise.
6103         (enum print_source_lines_flag): Move definition from symtab.h.
6104         * symtab.h (identify_source_line): Move declaration to source.h.
6105         (print_source_lines): Likewise.
6106         (forget_cached_source_info_for_objfile): Likewise.
6107         (forget_cached_source_info): Likewise.
6108         (select_source_symtab): Likewise.
6109         (enum print_source_lines_flag): Move definition to source.h.
6110         * tui/tui-hooks.c: Add 'source.h' include.
6111
6112 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6113
6114         * source.c (print_source_lines_base): Handle requests to print
6115         reverse line number sequences, and guard against empty lines
6116         string.
6117
6118 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6119
6120         * source.c (print_source_lines_base): Fix skip of '\r' if next
6121         character is '\n'.
6122
6123 2019-01-06  Tom Tromey  <tom@tromey.com>
6124
6125         * c-exp.y (struct c_parse_state) <macro_original_text,
6126         expansion_obstack>: New member.
6127         (macro_original_text, expansion_obstack): Remove globals.
6128         (scan_macro_expansion, scanning_macro_expansion)
6129         (finished_macro_expansion): Update.
6130         (scan_macro_cleanup): Remove.
6131         (yylex, c_parse): Update.
6132
6133 2019-01-06  Tom Tromey  <tom@tromey.com>
6134
6135         * c-exp.y (struct c_parse_state) <strings>: New member.
6136         (operator_stoken): Update.
6137
6138 2019-01-06  Tom Tromey  <tom@tromey.com>
6139
6140         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6141         (union type_stack_elt) <typelist_val>: Now a pointer to
6142         std::vector.
6143         (type_stack_cleanup): Don't declare.
6144         (push_typelist): Update.
6145         * parse.c (pop_typelist): Return a std::vector.
6146         (push_typelist): Take a std::vector.
6147         (follow_types): Update.  Do not free args.
6148         (type_stack_cleanup): Remove.
6149         * c-exp.y (struct c_parse_state): New.
6150         (cpstate): New global.
6151         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6152         (nonempty_typelist): Update.
6153         (func_mod): Create a new vector.
6154         (c_parse): Create a c_parse_state.
6155         (check_parameter_typelist): Do not delete params.
6156         (function_method): Update.  Do not delete type_list.
6157
6158 2019-01-06  Tom Tromey  <tom@tromey.com>
6159
6160         PR gdb/28155:
6161         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6162         check_typedef.
6163         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6164         (print_return_value): Likewise.
6165
6166 2019-01-05  Tom Tromey  <tom@tromey.com>
6167
6168         * contrib/cleanup_check.py: Remove.
6169         * contrib/gcc-with-excheck: Remove.
6170         * contrib/exsummary.py: Remove.
6171         * contrib/excheck.py: Remove.
6172
6173 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6174
6175         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6176         NULL. Initialize tpprev to NULL instead of assigning it
6177         to NULL on the next statement.
6178         * windows-nat.c (windows_delete_thread): Remove check for
6179         main_thread_id before printing thread exit notifications.
6180         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6181         Remove thread ID check against main_thread_id.
6182         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6183         windows_delete_thread.
6184         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6185
6186 2019-01-04  Tom Tromey  <tom@tromey.com>
6187
6188         * compile/compile.c (_initialize_compile): Use upper case for
6189         metasyntactic variables.
6190         * symmisc.c (_initialize_symmisc): Use upper case for
6191         metasyntactic variables.
6192         * psymtab.c (_initialize_psymtab): Use upper case for
6193         metasyntactic variables.
6194         * demangle.c (demangle_command): Use upper case for metasyntactic
6195         variables.
6196         (_initialize_demangler): Likewise.
6197         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6198         variables.
6199
6200 2019-01-03  Tom Tromey  <tom@tromey.com>
6201
6202         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6203
6204 2019-01-03  Tom Tromey  <tom@tromey.com>
6205
6206         * python/py-symtab.c (salpy_str): Update.
6207         (struct salpy_sal_object) <symtab>: Now a PyObject.
6208         (salpy_dealloc): Update.
6209         (del_objfile_sal): Use gdbpy_ref.
6210
6211 2019-01-03  Tom Tromey  <tom@tromey.com>
6212
6213         * python/py-type.c (convert_field): Use new_reference.  Return
6214         gdbpy_ref.
6215         (make_fielditem): Return gdbpy_ref.
6216         (typy_fields): Update.
6217         (typy_getitem): Update.
6218         (field_name): Return gdbpy_ref.  Use new_reference.
6219         (typy_iterator_iternext): Update.
6220
6221 2019-01-03  Tom Tromey  <tom@tromey.com>
6222
6223         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6224
6225 2019-01-03  Tom Tromey  <tom@tromey.com>
6226
6227         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6228         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6229         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6230         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6231         (pspy_set_type_printers): Likewise.
6232         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6233         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6234         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6235         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6236         (objfpy_set_type_printers): Likewise.
6237
6238 2019-01-03  Tom Tromey  <tom@tromey.com>
6239
6240         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6241         (gdbpy_print_stack): Use gdbpy_err_fetch.
6242         * python/python-internal.h (class gdbpy_err_fetch): New class.
6243         (class gdbpy_enter) <m_error_type, m_error_value,
6244         m_error_traceback>: Remove.
6245         <m_error>: New member.
6246         (gdbpy_exception_to_string): Don't declare.
6247         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6248         * python/py-value.c (convert_value_from_python): Use
6249         gdbpy_err_fetch.
6250         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6251         gdbpy_exception_to_string.
6252         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6253         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6254         gdbpy_err_fetch.
6255
6256 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6257
6258         * linux-nat.c (delete_lwp_cleanup): Delete.
6259         (struct lwp_deleter): New struct.
6260         (lwp_info_up): New typedef.
6261         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6262         lwp_info_up.
6263
6264 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6265
6266         * linux-fork.c (class scoped_switch_fork_info): New class.
6267         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6268
6269 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6270
6271         * valops.c (find_overload_match): Remove use of null_cleanup, and
6272         calls to do_cleanups.
6273
6274 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6275
6276         * compile/compile-cplus-types.c
6277         (compile_cplus_instance::decl_name): Handle changes to
6278         cp_func_name.
6279         * cp-support.c (cp_func_name): Update header comment, update
6280         return type.
6281         * cp-support.h (cp_func_name): Update return type in declaration.
6282         * valops.c (find_overload_match): Move temp_func local to top
6283         level of function and change its type.  Use temp_func to hold and
6284         delete temporary string obtained from cp_func_name.
6285
6286 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6287
6288         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6289         gdb::char_vector, remove cleanup, and update uses of `msg`.
6290
6291 2019-01-03  Jim Wilson  <jimw@sifive.com>
6292
6293         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6294
6295 2019-01-02  Tom Tromey  <tom@tromey.com>
6296
6297         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6298         (tdesc_parse_xml): Remove cleanups.
6299         * target-descriptions.h (make_cleanup_free_target_description):
6300         Don't declare.
6301         (target_desc_deleter): New struct.
6302         (target_desc_up): New typedef.
6303         * target-descriptions.c (target_desc_deleter::operator()): Rename
6304         from free_target_description.
6305         (make_cleanup_free_target_description): Remove.
6306
6307 2019-01-02  Tom Tromey  <tom@tromey.com>
6308
6309         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6310         constructor, destructor.
6311         (linespec_parser): Remove typedef.
6312         (~linespec_parser): Rename from linespec_parser_delete.
6313         (linespec_lex_to_end, linespec_complete_label)
6314         (linespec_complete): Update.
6315         (decode_line_full): Remove cleanups.
6316         (decode_line_1): Update.
6317
6318 2019-01-02  Tom Tromey  <tom@tromey.com>
6319
6320         * python/python-internal.h (inferior_to_inferior_object): Change
6321         return type.
6322         * python/py-exitedevent.c (create_exited_event_object): Update.
6323         * python/py-inferior.c (inferior_to_inferior_object): Return
6324         gdbpy_ref.
6325         (python_new_inferior, python_inferior_deleted)
6326         (thread_to_thread_object, delete_thread_object)
6327         (build_inferior_list, gdbpy_selected_inferior): Update.
6328         * python/py-infthread.c (create_thread_object): Update.  Also fail
6329         if inferior_to_inferior_object fails.
6330
6331 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6332
6333         * inferior.h (class inferior) <displaced_step_state>: New field.
6334         * infrun.h (struct displaced_step_state): Move here from
6335         infrun.c.  Initialize fields, add constructor.
6336         <inf>: Remove field.
6337         <reset>: New method.
6338         * infrun.c (struct displaced_step_inferior_state): Move to
6339         infrun.h.
6340         (displaced_step_inferior_states): Remove.
6341         (get_displaced_stepping_state): Adust.
6342         (displaced_step_in_progress_any_inferior): Adjust.
6343         (displaced_step_in_progress_thread): Adjust.
6344         (displaced_step_in_progress): Adjust.
6345         (add_displaced_stepping_state): Remove.
6346         (get_displaced_step_closure_by_addr): Adjust.
6347         (remove_displaced_stepping_state): Remove.
6348         (infrun_inferior_exit): Call displaced_step_state.reset.
6349         (use_displaced_stepping): Don't check for NULL.
6350         (displaced_step_prepare_throw): Call
6351         get_displaced_stepping_state.
6352         (displaced_step_fixup): Don't check for NULL.
6353         (prepare_for_detach): Don't check for NULL.
6354
6355 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6356
6357         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6358          in case of call that did not complete.
6359
6360 2019-01-02  Andrey Utkin  <autkin@undo.io>
6361
6362         * symfile.c (find_separate_debug_file): Fix search of debug files for
6363         remote debuggee.
6364
6365 2019-01-02  Tom Tromey  <tom@tromey.com>
6366
6367         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6368         indentation.
6369         * python/py-frame.c (frapy_older): Remove cast.
6370         (frapy_newer): Likewise.
6371         * python/py-breakpoint.c (local_setattro): Remove cast.
6372         * python/py-arch.c (archpy_name): Remove local variable.
6373         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6374
6375 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6376
6377         * unittests/basic_string_view/element_access/char/empty.cc:
6378         Fix year range in copyright header.
6379
6380 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6381
6382         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6383         Delete.
6384         <operator==>: Update with for removed field.
6385         <hash>: Likewise.
6386         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6387         <isa_features>: ...this.
6388         <abi_features>: New field.
6389         (riscv_isa_flen): Update comment.
6390         (riscv_abi_xlen): New declaration.
6391         (riscv_abi_flen): New declaration.
6392         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6393         isa_features.
6394         (riscv_abi_xlen): New function.
6395         (riscv_isa_flen): Update to get answer from isa_features.
6396         (riscv_abi_flen): New function.
6397         (riscv_has_fp_abi): Update to get answer from abi_features.
6398         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6399         xlen and flen.
6400         (riscv_call_info) <xlen, flen>: Update comment.
6401         (riscv_call_arg_struct): Remove invalid assertions
6402         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6403         is removed.
6404         (riscv_gdbarch_init): Gather isa features and abi features
6405         separately, ensure both match on the gdbarch when reusing an old
6406         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6407         a target with 64-bit float hardware.
6408
6409 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6410
6411         * source.c (search_command_helper): Stop reverse search
6412         when line 1 has been searched.
6413
6414 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6415
6416         * record-full.c (record_full_base_target::close): Rewrite
6417         record_full_core_buf_list free logic.
6418
6419 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6420
6421         * break-catch-syscall.c (print_one_catch_syscall): xfree
6422         the last text.
6423
6424 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6425
6426         * top.c (print_gdb_version): Update Copyright year in version
6427         message.
6428
6429 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6430
6431         Update copyright year range in all GDB files.
6432
6433 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6434
6435         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6436
6437 For older changes see ChangeLog-2018.
6438 \f
6439 Local Variables:
6440 mode: change-log
6441 left-margin: 8
6442 fill-column: 74
6443 version-control: never
6444 coding: utf-8
6445 End:
6446