gdb/ChangeLog

   1 2019-05-10  Tom Tromey  <tromey@adacore.com>
   2
   3         * thread.c (print_thread_info): Make "requested_threads" const.
   4         * gdbthread.h (print_thread_info): Make "requested_threads"
   5         const.
   6         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
   7         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
   8
   9 2019-05-08  Tom Tromey  <tom@tromey.com>
  10
  11         * gdbtypes.c (objfile_type_data): Change type.
  12         (objfile_type, _initialize_gdbtypes): Update.
  13
  14 2019-05-08  Tom Tromey  <tom@tromey.com>
  15
  16         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
  17         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
  18         (_initialize_dwarf2_frame): Update.
  19
  20 2019-05-08  Tom Tromey  <tom@tromey.com>
  21
  22         * objc-lang.c (objc_objfile_data): Change type.
  23         (find_methods): Update.
  24         (_initialize_objc_lang): Remove.
  25
  26 2019-05-08  Tom Tromey  <tom@tromey.com>
  27
  28         * stabsread.c (rs6000_builtin_type_data): Change type.
  29         (rs6000_builtin_type, _initialize_stabsread): Update.
  30
  31 2019-05-08  Tom Tromey  <tom@tromey.com>
  32
  33         * mips-tdep.c (mips_pdr_data): Remove.
  34         (_initialize_mips_tdep): Update.
  35
  36 2019-05-08  Tom Tromey  <tom@tromey.com>
  37
  38         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
  39         (hppa_init_objfile_priv_data, read_unwind_info)
  40         (find_unwind_entry, _initialize_hppa_tdep): Update.
  41
  42 2019-05-08  Tom Tromey  <tom@tromey.com>
  43
  44         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
  45         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
  46         on obstack.
  47         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
  48
  49 2019-05-08  Tom Tromey  <tom@tromey.com>
  50
  51         * mdebugread.c (basic_type_data): Change type.
  52         (basic_type, _initialize_mdebugread): Update.
  53
  54 2019-05-08  Tom Tromey  <tom@tromey.com>
  55
  56         * common/gdb_unique_ptr.h (struct noop_deleter): New.
  57
  58 2019-05-08  Tom Tromey  <tom@tromey.com>
  59
  60         * nto-tdep.c (nto_inferior_data_reg): Change type.
  61         (nto_inferior_data): Update.
  62         (nto_inferior_data_cleanup, nto_new_inferior_data)
  63         (_initialize_nto_tdep): Remove.
  64         * nto-tdep.h (struct nto_inferior_data): Add initializers.
  65
  66 2019-05-08  Tom Tromey  <tom@tromey.com>
  67
  68         * ada-lang.c (struct ada_inferior_data): Add initializers.
  69         (ada_inferior_data): Change type.
  70         (ada_inferior_data_cleanup): Remove.
  71         (get_ada_inferior_data, ada_inferior_exit)
  72         (struct ada_pspace_data): Add initializers, destructor.
  73         (ada_pspace_data_handle): Change type.
  74         (get_ada_pspace_data): Update.
  75         (ada_pspace_data_cleanup): Remove.
  76
  77 2019-05-08  Tom Tromey  <tom@tromey.com>
  78
  79         * coffread.c (struct coff_symfile_info): Add initializers.
  80         (coff_objfile_data_key): Move lower.  Change type.
  81         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
  82         Update.
  83         (coff_free_info): Remove.
  84
  85 2019-05-08  Tom Tromey  <tom@tromey.com>
  86
  87         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
  88         (fbsd_pspace_data_handle): Move lower.  Change type.
  89         (get_fbsd_pspace_data): Update.
  90         (fbsd_pspace_data_cleanup): Remove.
  91         (_initialize_fbsd_tdep): Update.
  92
  93 2019-05-08  Tom Tromey  <tom@tromey.com>
  94
  95         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
  96         (get_ada_tasks_pspace_data): Update.
  97         (ada_tasks_pspace_data_cleanup): Remove.
  98         (_initialize_tasks): Update.
  99         (ada_tasks_inferior_data_handle): Change type.
 100         (get_ada_tasks_inferior_data): Update.
 101         (ada_tasks_inferior_data_cleanup): Remove.
 102         (struct ada_tasks_pspace_data): Add initializers.
 103
 104 2019-05-08  Tom Tromey  <tom@tromey.com>
 105
 106         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
 107         * symfile-debug.c (debug_sym_get_probes): Change type.
 108         * stap-probe.c (handle_stap_probe):
 109         (stap_static_probe_ops::get_probes): Change type.
 110         * probe.h (class static_probe_ops) <get_probes>: Change type.
 111         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
 112         (parse_probes_in_pspace): Update.
 113         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
 114         Update.
 115         (any_static_probe_ops::get_probes): Change type.
 116         * elfread.c (elfread_data): New typedef.
 117         (probe_key): Change type.
 118         (elf_get_probes): Likewise.  Update.
 119         (probe_key_free): Remove.
 120         (_initialize_elfread): Update.
 121         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
 122         Change type.
 123         (dtrace_process_dof_probe, dtrace_process_dof)
 124         (dtrace_static_probe_ops::get_probe): Change type.
 125
 126 2019-05-08  Tom Tromey  <tom@tromey.com>
 127
 128         * xcoffread.c (struct xcoff_symfile_info): Rename from
 129         coff_symfile_info.  Add initializers.
 130         (xcoff_objfile_data_key): Move lower.  Change type.
 131         (XCOFF_DATA): Rewrite.
 132         (xcoff_free_info): Remove.
 133         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
 134         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
 135         (xcoff_initial_scan): Update.
 136
 137 2019-05-08  Tom Tromey  <tom@tromey.com>
 138
 139         * solib-svr4.c (struct svr4_info): Add initializers and
 140         destructor.
 141         <probes_table>: Now an htab_up.
 142         (solib_svr4_pspace_data): Change type.
 143         (free_probes_table): Simplify.
 144         (~svr4_info): Rename from svr4_pspace_data_cleanup.
 145         (get_svr4_info, probes_table_htab_remove_objfile_probes)
 146         (probes_table_remove_objfile_probes, register_solib_event_probe)
 147         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
 148         (_initialize_svr4_solib): Update.
 149
 150 2019-05-08  Tom Tromey  <tom@tromey.com>
 151
 152         * remote.c (remote_pspace_data): Change type.
 153         (remote_pspace_data_cleanup): Remove.
 154         (get_remote_exec_file, set_pspace_remote_exec_file)
 155         (_initialize_remote): Update.
 156
 157 2019-05-08  Tom Tromey  <tom@tromey.com>
 158
 159         * breakpoint.c (breakpoint_objfile_key): Change type.
 160         (get_breakpoint_objfile_data): Update.
 161         (free_breakpoint_objfile_data): Remove.
 162         (_initialize_breakpoint): Update.
 163
 164 2019-05-08  Tom Tromey  <tom@tromey.com>
 165
 166         * linux-tdep.c (struct linux_info): Add initializers.
 167         (linux_inferior_data): Move.  Change type.
 168         (invalidate_linux_cache_inf): Update.
 169         (linux_inferior_data_cleanup): Remove.
 170         (get_linux_inferior_data, _initialize_linux_tdep): Update.
 171
 172 2019-05-08  Tom Tromey  <tom@tromey.com>
 173
 174         * auxv.c (auxv_inferior_data): Move.  Change type.
 175         (auxv_inferior_data_cleanup): Remove.
 176         (invalidate_auxv_cache_inf): Rewrite.
 177         (get_auxv_inferior_data, _initialize_auxv): Update.
 178
 179 2019-05-08  Tom Tromey  <tom@tromey.com>
 180
 181         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
 182         (symfile_debug_objfile_data_key): Change type.
 183         (symfile_debug_installed, debug_qf_has_symbols)
 184         (debug_qf_find_last_source_symtab)
 185         (debug_qf_forget_cached_source_info)
 186         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
 187         (debug_qf_print_stats, debug_qf_dump)
 188         (debug_qf_expand_symtabs_for_function)
 189         (debug_qf_expand_all_symtabs)
 190         (debug_qf_expand_symtabs_with_fullname)
 191         (debug_qf_map_matching_symbols)
 192         (debug_qf_expand_symtabs_matching)
 193         (debug_qf_find_pc_sect_compunit_symtab)
 194         (debug_qf_map_symbol_filenames)
 195         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
 196         (debug_sym_new_init, debug_sym_init, debug_sym_read)
 197         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
 198         (debug_sym_read_linetable, debug_sym_relocate): Update.
 199         (symfile_debug_free_objfile): Remove.
 200         (install_symfile_debug_logging, _initialize_symfile_debug):
 201         Update.
 202
 203 2019-05-08  Tom Tromey  <tom@tromey.com>
 204
 205         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
 206         allocate_on_obstack.
 207         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
 208         (get_dwarf2_per_objfile): Update.
 209         (set_dwarf2_per_objfile): Remove.
 210         (dwarf2_has_info, dwarf2_get_section_info): Update.
 211         (dwarf2_free_objfile): Remove.
 212         (_initialize_dwarf2_read): Update.
 213
 214 2019-05-08  Tom Tromey  <tom@tromey.com>
 215
 216         * auto-load.c (struct auto_load_pspace_info): Add destructor and
 217         initializers.
 218         <unsupported_script_warning_printed,
 219         script_not_found_warning_printed>: Now bool.
 220         (auto_load_pspace_data): Change type.
 221         (~auto_load_pspace_info): Rename from
 222         auto_load_pspace_data_cleanup.
 223         (get_auto_load_pspace_data, init_loaded_scripts_info)
 224         (clear_section_scripts, maybe_print_unsupported_script_warning)
 225         (maybe_print_script_not_found_warning, _initialize_auto_load):
 226         Update.
 227
 228 2019-05-08  Tom Tromey  <tom@tromey.com>
 229
 230         * objfiles.c (objfile_pspace_info): Add destructor and
 231         initializers.
 232         (objfiles_pspace_data): Change type.
 233         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
 234         (get_objfile_pspace_data): Update.
 235         (objfiles_bfd_data): Change type.
 236         (get_objfile_bfd_data): Update.
 237         (objfile_bfd_data_free, _initialize_objfiles): Remove.
 238
 239 2019-05-08  Tom Tromey  <tom@tromey.com>
 240
 241         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
 242         Change type.
 243         (get_catch_syscall_inferior_data): Update.
 244         (catch_syscall_inferior_data_cleanup): Remove.
 245         (_initialize_break_catch_syscall): Update.
 246
 247 2019-05-08  Tom Tromey  <tom@tromey.com>
 248
 249         * inflow.c (struct terminal_info): Add destructor and
 250         initializers.
 251         (inflow_inferior_data): Change type.
 252         (~terminal_info): Rename from inflow_inferior_data_cleanup.
 253         (get_inflow_inferior_data, inflow_inferior_exit)
 254         (swap_terminal_info, _initialize_inflow): Update.
 255
 256 2019-05-08  Tom Tromey  <tom@tromey.com>
 257
 258         * target-dcache.c (target_dcache_cleanup): Remove.
 259         (target_dcache_aspace_key): Change type.
 260         (target_dcache_init_p, target_dcache_invalidate)
 261         (target_dcache_get, target_dcache_get_or_init)
 262         (_initialize_target_dcache): Update.
 263         * dcache.h (struct dcache_deleter): New.
 264
 265 2019-05-08  Tom Tromey  <tom@tromey.com>
 266
 267         * symtab.c (struct symbol_cache): Add destructor and
 268         initializers.
 269         (symbol_cache_key): Move.  Change type.
 270         (make_symbol_cache, free_symbol_cache): Remove.
 271         (get_symbol_cache): Update.
 272         (symbol_cache_cleanup): Remove.
 273         (ALL_PSPACES, symbol_cache_flush)
 274         (maintenance_print_symbol_cache)
 275         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
 276         Update.
 277
 278 2019-05-08  Tom Tromey  <tom@tromey.com>
 279
 280         * symtab.c (struct main_info): Add destructor and initializers.
 281         (main_progspace_key): Move.  Change type.
 282         (get_main_info): Update.
 283         (main_info_cleanup): Remove.
 284         (_initialize_symtab): Update.
 285
 286 2019-05-08  Tom Tromey  <tom@tromey.com>
 287
 288         * registry.h (DECLARE_REGISTRY): Define the _key class.
 289
 290 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 291
 292         * NEWS: Merge two 'New commands' sections.
 293
 294 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
 295
 296         * ada-valprint.c (ada_val_print_gnat_array): Remove language
 297         parameter and use Ada language definition instead.
 298         (ada_val_print_ptr): Remove unused language parameter.
 299         (ada_val_print_num): Remove language parameter and use Ada language
 300         definition instead.
 301         (ada_val_print_enum, ada_val_print_flt): Remove unused language
 302         parameter.
 303         (ada_val_print_struct_union, ada_val_print_ref): Remove language
 304         parameter and use Ada language definition instead.
 305         (ada_val_print_1): Update all ada_val_print_xxx calls.
 306         Remove language parameter.
 307         (ada_val_print): Update ada_val_print_1 call.
 308
 309 2019-05-08  Tom Tromey  <tromey@adacore.com>
 310
 311         * remote.c (remote_hw_watchpoint_limit)
 312         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
 313         Now static.
 314
 315 2019-05-08  Tom Tromey  <tromey@adacore.com>
 316
 317         * maint.c (_initialize_maint_cmds): Move initialization code to
 318         remote.c.
 319         (watchdog, show_watchdog): Move to remote.c.
 320         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
 321         "watchdog" static.
 322         (_initialize_remote): Move initialization code from maint.c.
 323         * defs.h (watchdog): Don't declare.
 324
 325 2019-05-08  Tom Tromey  <tromey@adacore.com>
 326
 327         * tui/tui-interp.c: Include main.h.
 328         * interps.c: Include main.h.
 329         * main.h (interpreter_p): Declare.
 330         * defs.h (interpreter_p): Don't declare.
 331
 332 2019-05-08  Tom Tromey  <tromey@adacore.com>
 333
 334         * dwarf2loc.c: Include dwarf2read.h.
 335         * defs.h (read_unsigned_leb128): Don't declare.
 336         * dwarf2read.h (read_unsigned_leb128): Declare.
 337
 338 2019-05-08  Tom Tromey  <tromey@adacore.com>
 339
 340         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
 341         method.
 342
 343 2019-05-08  Tom Tromey  <tromey@adacore.com>
 344
 345         * utils.c (fputs_maybe_filtered): Reset style after paging, even
 346         when no wrap column is set.
 347
 348 2019-05-08  Tom Tromey  <tromey@adacore.com>
 349
 350         * c-lang.c (c_get_string): Handle non-C-style arrays.
 351
 352 2019-05-08  Tom Tromey  <tromey@adacore.com>
 353
 354         * typeprint.c (print_offset_data::update): Print the bit offset,
 355         not the number of bits remaining.
 356
 357 2019-05-08  Tom Tromey  <tromey@adacore.com>
 358
 359         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
 360         padding at end of comment.
 361
 362 2019-05-08  Tom Tromey  <tromey@adacore.com>
 363
 364         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
 365         Compare main types.
 366
 367 2019-05-06  Tom Tromey  <tom@tromey.com>
 368
 369         * common/scoped_mmap.c: Include common-defs.h.
 370         * common/scoped_mmap.h: Don't include config.h.
 371
 372 2019-05-04  Tom Tromey  <tom@tromey.com>
 373
 374         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
 375         (struct aarch64_call_info): Add initializers.
 376         <si>: Now a std::vector.
 377         (pass_on_stack, aarch64_push_dummy_call): Update.
 378
 379 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
 380             Tom Tromey  <tom@tromey.com>
 381
 382         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
 383         (ppc_threads): Now a std::vector.  Now static.
 384         (hwdebug_find_thread_points_by_tid)
 385         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
 386         Update.
 387
 388 2019-05-04  Tom Tromey  <tom@tromey.com>
 389
 390         * arc-tdep.c (arc_tdesc_init): Return bool.
 391
 392 2019-05-04  Tom Tromey  <tom@tromey.com>
 393
 394         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
 395         Use gdb_assert_not_reached.
 396
 397 2019-05-04  Tom Tromey  <tom@tromey.com>
 398
 399         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
 400         "false".
 401
 402 2019-05-04  Tom Tromey  <tom@tromey.com>
 403
 404         * arc-tdep.c (arc_tdesc_init): Use bool.
 405
 406 2019-05-04  Tom Tromey  <tom@tromey.com>
 407
 408         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
 409
 410 2019-05-04  Tom Tromey  <tom@tromey.com>
 411
 412         * cli/cli-cmds.c (valid_command_p): Return bool.
 413
 414 2019-05-04  Tom Tromey  <tom@tromey.com>
 415
 416         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
 417         * command.h (valid_user_defined_cmd_name_p): Channge return type.
 418
 419 2019-05-04  Raul Tambre  <raul@tambre.ee>
 420
 421         * python/lib/gdb/prompt.py (_ExtendedPrompt)
 422         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
 423         operator for comparison.
 424
 425 2019-05-04  Tom Tromey  <tom@tromey.com>
 426
 427         * psymtab.c (psymbol_name_matches, match_partial_symbol)
 428         (lookup_partial_symbol, print_partial_symbols)
 429         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
 430         (psymbol_compare): Update.
 431         (add_psymbol_to_bcache): Clear the entire psymbol.
 432         (maintenance_check_psymtabs): Update.
 433         * psympriv.h (struct partial_symbol): Don't derive from
 434         general_symbol_info.
 435         <obj_section, unrelocated_address, address,
 436         set_unrelocated_address>: Update.
 437         <ginfo>: New member.
 438         * dwarf-index-write.c (write_psymbols, debug_names::insert)
 439         (debug_names::write_psymbols): Update.
 440
 441 2019-05-04  Tom de Vries  <tdevries@suse.de>
 442
 443         * contrib/cc-with-tweaks.sh: Support -n arg.
 444
 445 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 446
 447         * corelow.c (core_target::detach): Ensure frame cache and
 448         register caches are cleared.
 449         inferior.c (exit_inferior_1): Likewise.
 450
 451 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
 452             Tom Tromey  <tom@tromey.com>
 453
 454         * dictionary.c (collate_pending_symbols_by_language): Remove
 455         "struct" from foreach.
 456         * symtab.c (lookup_global_symbol_from_objfile)
 457         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
 458         foreach.
 459         * ser-tcp.c (net_open): Remove "struct" from foreach.
 460         * objfiles.c (objfile_relocate, objfile_rebase)
 461         (objfile_has_symbols): Remove "struct" from foreach.
 462         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
 463         from foreach.
 464         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
 465         foreach.
 466         * darwin-nat.c (thread_info_from_private_thread_info): Remove
 467         "struct" from foreach.
 468         * ada-lang.c (create_excep_cond_exprs)
 469         (ada_exception_catchpoint_cond_string): Remove "struct" from
 470         foreach.
 471
 472 2019-05-03  Tom Tromey  <tromey@adacore.com>
 473
 474         * ada-exp.y (convert_char_literal): Check suffix of each
 475         enumerator.
 476
 477 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
 478
 479         PR ada/21406:
 480         * ada-exp.y (yywrap): Don't define.
 481         * ada-lex.l (%option): Add noyywrap
 482         (yywrap): Remove.
 483
 484 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
 485
 486         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
 487         _WIN32_WINNT to the XP level, unless already defined to a higher
 488         level.
 489
 490         * unittests/parse-connection-spec-selftests.c:
 491         * ser-tcp.c:
 492         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
 493         override.
 494
 495         * symfile.c (find_separate_debug_file): Remove colon from the
 496         drive spec of DOS/Windows file names of the target, so that the
 497         file name produced from DEBUGDIR and the target's directory will
 498         be valid on DOS/Windows systems.
 499
 500 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 501
 502         * rust-lang.c (val_print_struct): Handle printing structures
 503         containing strings.
 504
 505 2019-05-02  Tom Tromey  <tromey@adacore.com>
 506
 507         * valarith.c (_initialize_valarith): Remove.
 508
 509 2019-05-01  Tom Tromey  <tromey@adacore.com>
 510
 511         * ada-lang.c (ada_value_primitive_field): Treat more fields as
 512         bitfields.
 513
 514 2019-05-01  Tom Tromey  <tromey@adacore.com>
 515
 516         * ada-lang.c (ada_value_assign): Correctly compute starting offset
 517         for big-endian copies.
 518
 519 2019-04-30  Ali Tamur  <tamur@google.com>
 520         * gdb/dwarf2read.c (read_3_bytes): New declaration.
 521         (read_attribute_value): Added DW_FORM_strx1-4 cases.
 522         (read_3_bytes): New function.
 523
 524 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 525
 526         * windows-nat.c (main_thread_id): Delete.
 527         (handle_output_debug_string): Replace main_thread_id by
 528         current_event.dwThreadId.
 529         (fake_create_process): Likewise.
 530         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
 531         Do not set main_thread_id.
 532         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
 533         current_event.dwThreadId.
 534         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
 535
 536 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 537
 538         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
 539         Use current_event.dwThreadId instead of main_thread_id.
 540
 541 2019-04-30  Tom Tromey  <tromey@adacore.com>
 542
 543         * ada-lang.c (ada_lookup_simple_minsyms): New function.
 544         (create_excep_cond_exprs): Iterate over program spaces.
 545         (ada_exception_catchpoint_cond_string): Examine all minimal
 546         symbols for exception types.
 547
 548 2019-04-30  Tom Tromey  <tromey@adacore.com>
 549
 550         PR c++/24470:
 551         * dwarf2read.c (process_structure_scope): Handle case where type
 552         has template parameters but no symbol was created.
 553
 554 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 555             Chris January  <chris.january@arm.com>
 556
 557         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
 558         qualifier.
 559         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
 560
 561 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 562
 563         * f-typeprint.c (f_print_type): Update rules for printing
 564         whitespace.
 565         (f_type_print_varspec_suffix): Likewise.
 566
 567 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 568             Chris January  <chris.january@arm.com>
 569
 570         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 571         function arguments.
 572
 573 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 574
 575         * f-lang.c (build_fortran_types): Change name of void type to
 576         lower case.
 577         * f-typeprint.c (f_type_print_base): Print the name of the void
 578         type, rather than a fixed string.
 579         * f-valprint.c (f_decorations): Use lower case void string.
 580
 581 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 582             Chris January  <chris.january@arm.com>
 583
 584         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 585         types for Fortran.
 586
 587 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 588             Chris January  <chris.january@arm.com>
 589             David Lecomber  <david.lecomber@arm.com>
 590
 591         * f-exp.y (BINOP_INTRINSIC): New token.
 592         (exp): New parser rule handling BINOP_INTRINSIC.
 593         (f77_keywords): Add new builtin procedures.
 594         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 595         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 596         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 597         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 598         (print_unop_subexp_f): New function.
 599         (print_binop_subexp_f): New function.
 600         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 601         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 602         (dump_subexp_body_f): Likewise.
 603         (operator_check_f): Likewise.
 604         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 605         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 606
 607 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 608
 609         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 610         UNOP_KIND.
 611         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 612         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 613         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 614         (operator_length_f): New fuction.
 615         (print_subexp_f): New function.
 616         (op_name_f): New function.
 617         (dump_subexp_body_f): New function.
 618         (operator_check_f): New function.
 619         (exp_descriptor_f): Replace standard expression handling functions
 620         with new functions.
 621         * gdb/fortran-operator.def: New file.
 622         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 623         * gdb/std-operator.def: Remove UNOP_KIND.
 624
 625 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 626
 627         * std-operator.def: Remove unbalanced, stray double quote
 628         character.
 629
 630 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 631             Chris January  <chris.january@arm.com>
 632             Daniel Everett  <daniel.everett@arm.com>
 633             Nick Forrington  <nick.forrington@arm.com>
 634             Richard Bunt  <richard.bunt@arm.com>
 635
 636         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 637         of depth when printing anonymous structs or unions.
 638         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 639         Don't print either the top-level value, or the children if the
 640         max-depth is exceeded.
 641         (ppscm_print_children): When printing the key of a map, allow one
 642         extra level of depth.
 643         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 644         print either the top-level value, or the children if the max-depth
 645         is exceeded.
 646         (print_children): When printing the key of a map, allow one extra
 647         level of depth.
 648         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 649         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 650         (user_print_options): Initialise max_depth field.
 651         (val_print_scalar_or_string_type_p): New function.
 652         (val_print): Check to see if the max depth has been reached.
 653         (val_print_check_max_depth): Define new function.
 654         (show_print_max_depth): New function.
 655         (_initialize_valprint): Add 'print max-depth' option.
 656         * valprint.h (struct value_print_options) <max_depth>: New field.
 657         (val_print_check_max_depth): Declare new function.
 658         * NEWS: Document new feature.
 659
 660 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 661
 662         * ada-lang.c (ada_language_defn): Initialise new field.
 663         * c-lang.c (c_is_string_type_p): New function.
 664         (c_language_defn): Initialise new field.
 665         (cplus_language_defn): Initialise new field.
 666         (asm_language_defn): Initialise new field.
 667         (minimal_language_defn): Initialise new field.
 668         * c-lang.h (c_is_string_type_p): Declare new function.
 669         * d-lang.c (d_language_defn): Initialise new field.
 670         * f-lang.c (f_is_string_type_p): New function.
 671         (f_language_defn): Initialise new field.
 672         * go-lang.c (go_is_string_type_p): New function.
 673         (go_language_defn): Initialise new field.
 674         * language.c (default_is_string_type_p): New function.
 675         (unknown_language_defn): Initialise new field.
 676         (auto_language_defn): Initialise new field.
 677         * language.h (struct language_defn) <la_is_string_type_p>: New
 678         member variable.
 679         (default_is_string_type_p): Declare new function.
 680         * m2-lang.c (m2_language_defn): Initialise new field.
 681         * objc-lang.c (objc_language_defn): Initialise new field.
 682         * opencl-lang.c (opencl_language_defn): Initialise new field.
 683         * p-lang.c (pascal_is_string_type_p): New function.
 684         (pascal_language_defn): Initialise new field.
 685         * rust-lang.c (rust_is_string_type_p): New function.
 686         (rust_language_defn): Initialise new field.
 687
 688 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 689
 690         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 691         New field.
 692         * ada-lang.c (ada_language_defn): Initialise new field.
 693         * c-lang.c (c_language_defn): Likewise.
 694         (cplus_language_defn): Likewise.
 695         (asm_language_defn): Likewise.
 696         (minimal_language_defn): Likewise.
 697         * d-lang.c (d_language_defn): Likewise.
 698         * f-lang.c (f_language_defn): Likewise.
 699         * go-lang.c (go_language_defn): Likewise.
 700         * language.c (unknown_language_defn): Likewise.
 701         (auto_language_defn): Likewise.
 702         * m2-lang.c (m2_language_defn): Likewise.
 703         * objc-lang.c (objc_language_defn): Likewise.
 704         * opencl-lang.c (opencl_language_defn): Likewise.
 705         * p-lang.c (pascal_language_defn): Likewise.
 706         * rust-lang.c (rust_language_defn): Likewise.
 707
 708 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 709
 710         * ada-lang.c (ada_is_character_type): Change return type to bool.
 711         (ada_is_string_type): Likewise.
 712         * ada-lang.h (ada_is_character_type): Update declaration
 713         (ada_is_string_type): Likewise.
 714
 715 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 716
 717         Support style in 'frame|thread apply'
 718
 719         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 720         * record.c (record_start, record_stop): Update callers of
 721         execute_command_to_string with false.
 722         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 723         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 724         methods.
 725         (class string_file): New constructor with term_out parameter.
 726         Override methods term_out and can_emit_style_escape.  New member
 727         term_out.
 728         (class stdio_file): Override can_emit_style_escape.
 729         (class tee_file): Override term_out and can_emit_style_escape.
 730         * utils.h (can_emit_style_escape): Remove.
 731         * utils.c (can_emit_style_escape): Likewise.
 732         Update all callers of can_emit_style_escape (SOMESTREAM) to
 733         SOMESTREAM->can_emit_style_escape.
 734         * source-cache.c (source_cache::get_source_lines): Likewise.
 735         * stack.c (frame_apply_command_count): Call execute_command_to_string
 736         passing the term_out characteristic of the current gdb_stdout.
 737         * thread.c (thr_try_catch_cmd): Likewise.
 738         * top.c (execute_command_to_string): pass term_out parameter
 739         to construct the string_file for the command output.
 740         * ui-file.c (term_cli_styling): New function (most code moved
 741         from utils.c can_emit_style_escape).
 742         (string_file::string_file, string_file::can_emit_style_escape,
 743         stdio_file::can_emit_style_escape, tee_file::term_out,
 744         tee_file::can_emit_style_escape): New functions.
 745
 746 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 747
 748         * NEWS: Mention the new set|show may-call-functions.
 749         * infcall.c (may_call_functions_p): New variable.
 750         (show_may_call_functions_p): New function.
 751         (call_function_by_hand_dummy): Throws an error if not
 752         may-call-functions.
 753         (_initialize_infcall): Call add_setshow_boolean_cmd for
 754         may-call-functions.
 755
 756 2019-04-25  Keith Seitz  <keiths@redhat.com>
 757
 758         PR c++/24367
 759         * cp-support.c (inspect_type): Don't attempt substitutions
 760         of symbol with the same name.
 761
 762 2019-04-25  Tom Tromey  <tromey@adacore.com>
 763
 764         PR gdb/24475:
 765         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 766         static.
 767
 768 2019-04-25  Tom Tromey  <tromey@adacore.com>
 769
 770         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
 771         rvalue reference.
 772         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
 773         (gdb_xml_parser::parse): Use std::move.
 774         * python/python-internal.h (gdbpy_convert_exception): Take a const
 775         reference.
 776         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
 777         std::move.
 778         * python/py-utils.c (gdbpy_convert_exception): Take a const
 779         reference.
 780         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 781         Use std::move.
 782         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 783         Use std::move.
 784         * mi/mi-main.c (mi_print_exception): Take a const reference.
 785         * main.c (handle_command_errors): Take a const reference.
 786         * linespec.c (parse_linespec): Use std::move.
 787         * infcall.c (run_inferior_call): Use std::move.
 788         (call_function_by_hand_dummy): Use std::move.
 789         * exec.c (try_open_exec_file): Use std::move.
 790         * exceptions.h (exception_print, exception_fprintf)
 791         (exception_print_same): Update.
 792         * exceptions.c (print_exception, exception_print)
 793         (exception_fprintf, exception_print_same): Change parameters to
 794         const reference.
 795         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
 796         * common/new-op.c: Use std::move.
 797         * common/common-exceptions.h (struct gdb_exception): Add move
 798         constructor.
 799         (struct gdb_exception_error, struct gdb_exception_quit, struct
 800         gdb_quit_bad_alloc): Change constructor to move constructor.
 801         (throw_exception): Change parameter to rvalue reference.
 802         * common/common-exceptions.c (throw_exception): Take rvalue
 803         reference.
 804         * cli/cli-interp.c (safe_execute_command): Use std::move.
 805         * breakpoint.c (insert_bp_location, location_to_sals): Use
 806         std::move.
 807
 808 2019-04-25  Tom Tromey  <tromey@adacore.com>
 809
 810         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
 811         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
 812         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
 813         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
 814         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
 815         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
 816         guile/scm-value.c: Use unpack.
 817         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
 818         gdbscm_gdb_exception.
 819         (gdbscm_throw_gdb_exception): Likewise.
 820         (struct gdbscm_gdb_exception): New.
 821         (unpack): New function.
 822         (gdbscm_wrap): Use unpack.
 823
 824 2019-04-25  Tom Tromey  <tromey@adacore.com>
 825
 826         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 827         (gdb_rl_callback_handler): Use std::move.
 828         * common/common-exceptions.h (struct gdb_exception): Add move
 829         assignment operator.
 830         (throw_exception_sjlj): Change "exception" to const reference.
 831         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
 832         (throw_exception_sjlj): Change "exception" to const reference.
 833
 834 2019-04-25  Tom Tromey  <tromey@adacore.com>
 835
 836         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
 837         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
 838         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 839         Update.
 840         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 841         Update.
 842         * mi/mi-interp.c (mi_interp::exec): Update.
 843         * linespec.c (parse_linespec): Update.
 844         * infcall.c (run_inferior_call): Update.
 845         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
 846         * guile/scm-symbol.c (gdbscm_lookup_symbol)
 847         (gdbscm_lookup_global_symbol): Update.
 848         * guile/scm-param.c (gdbscm_parameter_value): Update.
 849         * guile/scm-frame.c (gdbscm_frame_read_register)
 850         (gdbscm_frame_read_var): Update.
 851         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
 852         * exec.c (try_open_exec_file): Update.
 853         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 854         (gdb_rl_callback_handler): Update.
 855         * common/common-exceptions.h (exception_none): Don't declare.
 856         * common/common-exceptions.c (exception_none): Don't define.
 857         (struct catcher) <exception>: Update.
 858         * cli/cli-interp.c (safe_execute_command): Update.
 859         * breakpoint.c (insert_bp_location, location_to_sals): Update.
 860
 861 2019-04-25  Ali Tamur  <tamur@google.com>
 862
 863         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
 864         (read_attribute_value): Likewise.
 865         (dwarf2_read_addr_index): Update comment.
 866         (read_str_index): Add DW_FORM_strx.
 867         (dwarf2_string_attr): Likewise.
 868         (dwarf2_const_value_attr): Likewise.
 869         (dump_die_shallow): Likewise.
 870         (dwarf2_fetch_constant_bytes): Likewise.
 871         (skip_form_bytes): Likewise.
 872         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
 873
 874 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
 875
 876         PR corefiles/11608
 877         PR corefiles/18187
 878         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
 879         OFFSET.  Verify if current mapping contains an ELF header.
 880         (linux_find_memory_regions_full): Adjust call to
 881         dump_mapping_p.
 882
 883 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
 884             Kang Li <kanglictf@gmail.com>
 885
 886         PR gdb/21600
 887
 888         * dwarf2-frame.c (read_initial_length): Be consistent about using
 889         unsigned representation of length.
 890         (decode_frame_entry_1): Likewise.  Check for wraparound of
 891         end pointer as well as buffer overflow.
 892
 893 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
 894
 895         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
 896         "vq".
 897
 898 2019-04-24  Tom Tromey  <tromey@adacore.com>
 899
 900         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
 901
 902 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 903
 904         * s12z-tdep.c (s12z_unwind_pc): Delete.
 905         (s12z_unwind_sp): Delete.
 906         (s12z_gdbarch_init): Don't register deleted functions with
 907         gdbarch.
 908
 909 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 910
 911         * rl78-tdep.c (rl78_unwind_sp): Delete.
 912         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
 913
 914 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 915
 916         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
 917         (xstormy16_unwind_pc): Delete.
 918         (xstormy16_dummy_id): Delete.
 919         (xstormy16_gdbarch_init): Don't register deleted functions with
 920         gdbarch.
 921
 922 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 923
 924         * vax-tdep.c (vax_unwind_pc): Delete.
 925         (vax_gdbarch_init): Don't register deleted function with gdbarch.
 926
 927 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 928
 929         * v850-tdep.c (v850_unwind_sp): Delete.
 930         (v850_unwind_pc): Delete.
 931         (v850_dummy_id): Delete.
 932         (v850_gdbarch_init): Don't register deleted functions with
 933         gdbarch.
 934
 935 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 936
 937         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
 938         (tilegx_unwind_pc): Delete.
 939         (tilegx_unwind_dummy_id): Delete.
 940         (tilegx_gdbarch_init): Don't register deleted functions with
 941         gdbarch.
 942
 943 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 944
 945         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
 946         (tic6x_dummy_id): Delete.
 947         (tic6x_gdbarch_init): Don't register deleted functions with
 948         gdbarch.
 949
 950 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 951
 952         * sparc-tdep.c (sparc_unwind_pc): Delete.
 953         (sparc32_gdbarch_init): Don't register deleted function with
 954         gdbarch.
 955
 956 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 957
 958         * sh-tdep.c (sh_unwind_sp): Delete.
 959         (sh_unwind_pc): Delete.
 960         (sh_dummy_id): Delete.
 961         (sh_gdbarch_init): Don't register deleted functions with
 962         gdbarch.
 963
 964 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 965
 966         * score-tdep.c (score_unwind_sp): Delete.
 967         (score_unwind_pc): Delete.
 968         (score_dummy_id): Delete.
 969         (score_gdbarch_init): Don't register deleted functions with
 970         gdbarch.
 971
 972 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 973
 974         * rx-tdep.c (rx_unwind_pc): Delete.
 975         (rx_unwind_sp): Delete.
 976         (rx_dummy_id): Delete.
 977         (rx_gdbarch_init): Don't register deleted functions with
 978         gdbarch.  Update comment.
 979
 980 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 981
 982         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
 983         (rs6000_dummy_id): Delete.
 984         (rs6000_gdbarch_init): Don't register deleted functions with
 985         gdbarch.
 986
 987 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 988
 989         * or1k-tdep.c (or1k_dummy_id): Delete.
 990         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
 991
 992 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 993
 994         * nios2-tdep.c (nios2_dummy_id): Delete.
 995         (nios2_unwind_sp): Delete.
 996         (nios2_gdbarch_init): Don't register deleted functions with
 997         gdbarch.
 998
 999 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1000
1001         * nds32-tdep.c (nds32_dummy_id): Delete.
1002         (nds32_unwind_pc): Delete.
1003         (nds32_unwind_sp): Delete.
1004         (nds32_gdbarch_init): Don't register deleted functions with
1005         gdbarch.
1006
1007 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1008
1009         * msp430-tdep.c (msp430_unwind_pc): Delete.
1010         (msp430_unwind_sp): Delete.
1011         (msp430_dummy_id): Delete.
1012         (msp430_gdbarch_init): Don't register deleted functions with
1013         gdbarch.
1014
1015 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1016
1017         * moxie-tdep.c (moxie_unwind_sp): Delete.
1018         (moxie_unwind_pc): Delete.
1019         (moxie_dummy_id): Delete.
1020         (moxie_gdbarch_init): Don't register deleted functions with
1021         gdbarch.
1022
1023 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1024
1025         * mn10300-tdep.c (mn10300_dummy_id): Delete.
1026         (mn10300_unwind_pc): Delete.
1027         (mn10300_unwind_sp): Delete.
1028         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
1029         mn10300_unwind_sp.
1030         (mn10300_frame_unwind_init): Don't register deleted functions with
1031         gdbarch.
1032
1033 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1034
1035         * mep-tdep.c (mep_unwind_pc): Delete.
1036         (mep_unwind_sp): Delete.
1037         (mep_dummy_id): Delete.
1038         (mep_gdbarch_init): Don't register deleted functions with
1039         gdbarch.
1040
1041 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1042
1043         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
1044         (m68hc11_unwind_sp): Delete.
1045         (m68hc11_gdbarch_init): Don't register deleted functions with
1046         gdbarch.
1047
1048 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1049
1050         * m32r-tdep.c (m32r_unwind_sp): Delete.
1051         (m32r_unwind_pc): Delete.
1052         (m32r_dummy_id): Delete.
1053         (m32r_gdbarch_init): Don't register deleted functions with
1054         gdbarch.
1055
1056 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1057
1058         * m32c-tdep.c (m32c_unwind_pc): Delete.
1059         (m32c_unwind_sp): Delete.
1060         (m32c_dummy_id): Delete.
1061         (m32c_gdbarch_init): Don't register deleted functions with
1062         gdbarch.
1063
1064 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1065
1066         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
1067         (lm32_unwind_pc): Delete.
1068         (lm32_dummy_id): Delete.
1069         (lm32_gdbarch_init): Don't register deleted functions with
1070         gdbarch.
1071
1072 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1073
1074         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
1075         (iq2000_unwind_pc): Delete.
1076         (iq2000_dummy_id): Delete.
1077         (iq2000_gdbarch_init): Don't register deleted functions with
1078         gdbarch.
1079
1080 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1081
1082         * nds32-tdep.c (nds32_type_align): Delete.
1083         (nds32_push_dummy_call): Use type_align instead.
1084
1085 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1086
1087         * arm-tdep.c (arm_type_align): Only handle vector override case.
1088         (arm_push_dummy_call): Use type_align.
1089         (arm_gdbarch_init): Register arm_type_align gdbarch function.
1090
1091 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1092
1093         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
1094         case.
1095         (pass_on_stack): Use type_align.
1096         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
1097         function.
1098
1099 2019-04-23  Tom Tromey  <tromey@adacore.com>
1100
1101         * dwarf2read.c (line_header::file_name_at): Remove unused
1102         overload.
1103
1104 2019-04-23  Tom de Vries  <tdevries@suse.de>
1105
1106         PR gdb/24438
1107         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
1108         invocation.
1109
1110
1111 2019-03-27  Ali Tamur  <tamur@google.com>
1112
1113         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
1114         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
1115         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
1116         (dwarf_expr_context::get_addr_index): Likewise
1117         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
1118         (symbol_needs_eval_context::get_addr_index): Likewise
1119         (disassemble_dwarf_expression): Add DW_OP_addrx
1120         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
1121         (read_cutu_die_from_dwo): Update comment
1122         (skip_one_die): Add DW_FORM_addrx
1123         (read_attribute_value): Likewise
1124         (var_decode_location): Add DW_OP_addrx
1125         (dwarf2_const_value_attr): Add DW_FORM_addrx
1126         (dump_die_shallow): Likewise
1127         (dwarf2_fetch_constant_bytes): Likewise
1128         (decode_locdesc): Add DW_OP_addrx
1129         (skip_form_bytes): Add DW_FORM_addrx
1130
1131 2019-04-22  Ali Tamur  <tamur@google.com>
1132
1133         * MAINTAINERS (Write After Approval): Add self.
1134
1135 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
1136
1137         * solib-svr4.c (get_svr4_info): Add pspace parameter.
1138         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
1139         (open_symbol_file_object): Likewise.
1140         (svr4_default_sos): Add info parameter.
1141         (svr4_read_so_list): Likewise.
1142         (svr4_current_sos_direct): Adjust functions calls to pass down
1143         info.
1144         (svr4_current_sos_1): Add info parameter.
1145         (svr4_current_sos): Call get_svr4_info, pass info down to
1146         svr4_current_sos_1.
1147         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
1148         get_svr4_info.
1149         (svr4_in_dynsym_resolve_code): Pass current_program_space to
1150         get_svr4_info.
1151         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
1152         to get_svr4_info.
1153         (probes_table_remove_objfile_probes): Likewise.
1154         (register_solib_event_probe): Add info parameter.
1155         (solist_update_incremental): Pass info parameter down to
1156         svr4_read_so_list.
1157         (disable_probes_interface): Add info parameter.
1158         (svr4_handle_solib_event): Pass current_program_space to
1159         get_svr4_info.  Adjust disable_probes_interface cleanup.
1160         (svr4_create_probe_breakpoints): Add info parameter, pass it
1161         down to register_solib_event_probe.
1162         (svr4_create_solib_event_breakpoints): Add info parameter,
1163         pass it down to svr4_create_probe_breakpoints.
1164         (enable_break): Pass info down to
1165         svr4_create_solib_event_breakpoints.
1166         (svr4_solib_create_inferior_hook): Pass current_program_space to
1167         get_svr4_info.
1168         (svr4_clear_solib): Likewise.
1169
1170 2019-04-22  Pedro Alves  <palves@redhat.com>
1171
1172         * solib-svr4.c (svr4_free_objfile_observer): New.
1173         (probe_and_action::objfile): New field.
1174         (probes_table_htab_remove_objfile_probes)
1175         (probes_table_remove_objfile_probes): New functions.
1176         (register_solib_event_probe): Add 'objfile' parameter.  Store it
1177         in the new probe_and_action.  Don't store the probe in 'lookup'.
1178         (svr4_create_probe_breakpoints): Pass objfile to
1179         register_solib_event_probe.
1180         (_initialize_svr4_solib): Register a free_objfile observer.
1181
1182 2019-04-19  Tom Tromey  <tom@tromey.com>
1183
1184         * common/queue.h: Remove.
1185
1186 2019-04-19  Tom Tromey  <tom@tromey.com>
1187
1188         * event-loop.c: Don't include "common/queue.h".
1189
1190 2019-04-19  Tom Tromey  <tom@tromey.com>
1191
1192         * remote.c (remote_target): Use delete.
1193         * remote-notif.h: Include <list>, not "common/queue.h".
1194         (notif_client_p): Remove typedef.
1195         (remote_notif_state): Add constructor, destructor, initializer.
1196         <notif_queue>: Now a std::list.
1197         (remote_notif_state_xfree): Don't declare.
1198         * remote-notif.c (remote_notif_process, handle_notification)
1199         (remote_notif_state_allocate): Update.
1200         (~remote_notif_state): Rename from remote_notif_state_xfree.
1201
1202 2019-04-19  Tom Tromey  <tom@tromey.com>
1203
1204         * symfile.c (reread_symbols): Update.
1205         * objfiles.c (objfile_register_static_link)
1206         (objfile_lookup_static_link): Update
1207         (~objfile) Don't delete static_links.
1208         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
1209
1210 2019-04-19  Tom Tromey  <tom@tromey.com>
1211
1212         * type-stack.h (struct type_stack) <insert>: Constify string.
1213         * type-stack.c (type_stack::insert): Constify string.
1214         * gdbtypes.h (lookup_template_type): Update.
1215         (address_space_name_to_int): Update.
1216         * gdbtypes.c (address_space_name_to_int): Make space_identifier
1217         const.
1218         (lookup_template_type): Make name const.
1219         * c-exp.y: Update rules.
1220         (lex_one_token, classify_name, classify_inner_name)
1221         (c_print_token): Update.
1222         * p-exp.y: Update rules.
1223         (yylex): Update.
1224         * f-exp.y: Update rules.
1225         (yylex): Update.
1226         * d-exp.y: Update rules.
1227         (lex_one_token, classify_name, classify_inner_name): Update.
1228         * parse.c (write_dollar_variable, copy_name): Return std::string.
1229         * parser-defs.h (copy_name): Change return type.
1230         * m2-exp.y: Update rules.
1231         (yylex): Update.
1232         * go-exp.y (lex_one_token): Update.
1233         Update rules.
1234         (classify_unsafe_function, classify_packaged_name)
1235         (classify_name, yylex): Update.
1236
1237 2019-04-19  Sergei Trofimovich <siarheit@google.com>
1238
1239         * configure.ac: add --enable-source-highlight switch.
1240         * configure: Regenerate.
1241         * top.c (print_gdb_version): plumb --enable-source-highlight
1242         status to "show configuration".
1243
1244 2019-04-19  Tom Tromey  <tromey@adacore.com>
1245
1246         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
1247         Check ADA_TYPE_P.
1248         (empty_record, ada_template_to_fixed_record_type_1)
1249         (template_to_static_fixed_type)
1250         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
1251         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
1252         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
1253         macros.
1254
1255 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
1256
1257         PR symtab/24423:
1258         * source.c (print_source_lines_base): Advance "iter" when a
1259         control character is seen.
1260
1261 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1262
1263         * inferior.h (struct infcall_suspend_state_deleter):
1264         Catch exception in destructor to avoid crash.
1265
1266 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1267
1268         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
1269         close to the add_com "shell".
1270
1271 2019-04-18  Tom Tromey  <tromey@adacore.com>
1272
1273         * process-stratum-target.h (class process_stratum_target)
1274         <stratum>: Add "final".
1275
1276 2019-04-17  Tom Tromey  <tromey@adacore.com>
1277
1278         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
1279         against nullptr before use.
1280
1281 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
1282
1283         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
1284
1285 2019-04-17  Jim Wilson  <jimw@sifive.com>
1286             Andrew Burgess  <andrew.burgess@embecosm.com>
1287
1288         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
1289         code read might fail, assume 4-byte breakpoint in that case.
1290
1291 2019-04-15  Leszek Swirski  <leszeks@google.com>
1292
1293         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
1294         rather than a hand-rolled POD check when checking for forced MEMORY
1295         classification.
1296
1297 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1298
1299         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
1300         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
1301         function.
1302         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
1303         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
1304         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
1305         declaration.
1306
1307 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1308
1309         * aarch64-linux-nat.c
1310         (aarch64_linux_nat_target::thread_architecture): Add override.
1311         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
1312         each VQ.
1313
1314 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1315
1316         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
1317
1318 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
1319
1320         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
1321         target types of size 96-bits, add some additional comments, and
1322         check that the builtin type we found was the correct size.
1323
1324 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
1325
1326         * utils.c (prompt_for_continue): Don't restore the styling at the
1327         end, as applied_style has the wrong value.  This fixes styling in
1328         long lists of file names that are interrupted by the "Continue?"
1329         prompt.
1330
1331 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1332
1333         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
1334         * c-lang.c (c_language_defn): Likewise.
1335         (cplus_language_defn): Likewise.
1336         (asm_language_defn): Likewise.
1337         (minimal_language_defn): Likewise.
1338         * d-lang.c (d_language_defn): Likewise.
1339         * f-lang.c (f_language_defn): Likewise.
1340         * go-lang.c (go_language_defn): Likewise.
1341         * language.c (unknown_language_defn): Likewise.
1342         (auto_language_defn): Likewise.
1343         * language.h (struct language_defn): Remove la_magic field.
1344         (LANG_MAGIC): Delete.
1345         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
1346         * objc-lang.c (objc_language_defn): Likewise.
1347         * opencl-lang.c (opencl_language_defn): Likewise.
1348         * p-lang.c (pascal_language_defn): Likewise.
1349         * rust-lang.c (rust_language_defn): Likewise.
1350
1351 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1352
1353         * riscv-tdep.c (riscv_type_align): New function.
1354         (riscv_type_alignment): Delete.
1355         (riscv_arg_location): Use 'type_align'.
1356         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
1357
1358 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1359
1360         * gdbtypes.c (type_align): A struct with no non-static fields also
1361         has alignment of 1.
1362
1363 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1364
1365         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
1366         component to 0.
1367         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
1368         member.
1369         (riscv_struct_info::analyse): New implementation using new
1370         analyse_inner member function.
1371         (riscv_struct_info::field_offset): New member function.
1372         (riscv_struct_info::m_offsets): New member variable.
1373         (riscv_struct_info::analyse_inner): New private member function,
1374         takes the old implementation of riscv_struct_info::analyse but
1375         extended to track field offsets.
1376         (riscv_call_arg_struct): Update the struct folding special cases
1377         to handle cases where empty C++ structs, which are non-zero
1378         length, are found.
1379         (riscv_arg_location): Initialise the length of each location, a
1380         non-zero length now indicates the location is in use.
1381         (riscv_push_dummy_call): Allow for the first location having a
1382         non-zero offset when setting up arguments.
1383         (riscv_return_value): Likewise, but for return values.
1384
1385 2019-04-11  Tom Tromey  <tromey@adacore.com>
1386
1387         * utils.c (internal_vproblem): Make "msg" const.
1388
1389 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
1390
1391         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
1392         * trad-frame.c (trad_frame_reset_saved_regs): New function.
1393         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
1394         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
1395
1396 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
1397
1398         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
1399         function.
1400         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1401         of amd64_collect_native_gregset.
1402         (amd64_linux_nat_target::store_registers): Likewise.
1403
1404 2019-04-10  Tom Tromey  <tom@tromey.com>
1405
1406         * symtab.c (lookup_global_symbol_from_objfile)
1407         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1408         * objfiles.h (class separate_debug_iterator): New.
1409         (class separate_debug_range): New.
1410         (struct objfile) <separate_debug_objfiles>: New method.
1411         (objfile_separate_debug_iterate): Don't declare.
1412         * objfiles.c (separate_debug_iterator::operator++): Rename from
1413         objfile_separate_debug_iterate.
1414         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1415         iterator.
1416         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1417         iterator.
1418
1419 2019-04-10  Tom Tromey  <tom@tromey.com>
1420
1421         * symfile.c (reread_symbols): Remove old comment.
1422         * objfiles.c (free_all_objfiles): Fix a typo.
1423
1424 2019-04-10  Tom Tromey  <tom@tromey.com>
1425
1426         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1427         * minsyms.c (lookup_minimal_symbol): Use foreach.
1428         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1429         (lookup_minimal_symbol_solib_trampoline): Likewise.
1430         * symfile.c (reread_symbols): Use foreach.
1431
1432 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1433             Tom Tromey  <tromey@adacore.com>
1434
1435         PR rust/24414:
1436         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1437         (rust_lex_int_test): Change "value" to be LONGEST.
1438         (rust_lex_tests): Add test for long integer literal.
1439
1440 2019-04-09  Tom Tromey  <tromey@adacore.com>
1441
1442         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1443         to bool.
1444         (extended_remote_target::attach): Update.
1445         (remote_target::remote_notice_new_inferior): Update.
1446         (remote_target::add_current_inferior_and_thread): Update.
1447         * inferior.c (exit_inferior_1): Use "false".
1448         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1449
1450 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1451
1452         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1453         the "start" command.
1454
1455 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1456
1457         * python/py-inferior.c (infpy_thread_from_thread_handle):
1458         Adjust comments to reflect renaming of thread_from_thread_handle
1459         to thread_from_handle.  Adjust keywords.  Fix type error message.
1460         (inferior_object_methods): Add thread_from_handle.  Retain
1461         thread_from_thread_handle, but mark it as deprecated.
1462
1463 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1464
1465         * gdbthread.h (find_thread_by_handle): Revise declaration.
1466         * thread.c (find_thread_by_handle): Likewise.  Adjust
1467         implementation too.
1468         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1469         support for buffer objects as handles.
1470
1471 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1472
1473         * python/py-infthread.c (thpy_thread_handle): New function.
1474         (thread_object_methods): Register thpy_thread_handle.
1475
1476 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1477
1478         * gdbthread.h (thread_to_thread_handle): Declare.
1479         * thread.c (gdbtypes.h): Include.
1480         (thread_to_thread_handle): New function.
1481
1482         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1483         (target_thread_info_to_thread_handle): Declare.
1484         * target.c (target_thread_info_to_thread_handle): New function.
1485         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1486         * target-delegates.c: Regenerate.
1487
1488         * linux-thread-db.c (class thread_db_target): Add method
1489         thread_info_to_thread_handle.
1490         (thread_db_target::thread_info_to_thread_handle): Define.
1491         * remote.c (class remote_target): Add new method
1492         thread_info_to_thread_handle.
1493         (remote_target::thread_info_to_thread_handle): Define.
1494
1495 2019-04-08  Pedro Alves  <palves@redhat.com>
1496
1497         * common/common-exceptions.c (throw_exception): Don't create
1498         named object to throw; throw directly.
1499         (throw_it): Likewise.  Don't initialize gdb_exception::message
1500         here, with new; pass FMT and AP to the ctor instead.
1501         * common/common-exceptions.h: Include <string>.
1502         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1503         const char *, va_list)): New ctor.  Use std::make_shared.
1504         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1505         errors)): Delete.
1506         (gdb_exception_error::gdb_exception_error(enum errors, const char
1507         *, va_list)): New.
1508         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1509         Add assertion.
1510         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1511         errors)): Delete.
1512         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1513         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1514         Add assertion.
1515
1516 2019-04-08  Tom Tromey  <tom@tromey.com>
1517
1518         * valops.c (value_rtti_indirect_type): Replace throw_exception
1519         with throw.
1520         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1521         with throw.
1522         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1523         throw.
1524         * target.c (target_translate_tls_address): Replace throw_exception
1525         with throw.
1526         * stack.c (frame_apply_command_count): Replace throw_exception
1527         with throw.
1528         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1529         throw.
1530         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1531         with throw.
1532         * rs6000-tdep.c (rs6000_frame_cache)
1533         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1534         * remote.c: Replace throw_exception with throw.
1535         * record-full.c (record_full_message, record_full_wait_1)
1536         (record_full_restore): Replace throw_exception with throw.
1537         * record-btrace.c:
1538         (get_thread_current_frame_id, record_btrace_start_replaying)
1539         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1540         (cmd_record_btrace_start): Replace throw_exception with throw.
1541         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1542         throw.
1543         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1544         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1545         * linespec.c:
1546         (find_linespec_symbols): Replace throw_exception with throw.
1547         * infrun.c (displaced_step_prepare, resume): Replace
1548         throw_exception with throw.
1549         * infcmd.c (post_create_inferior): Replace throw_exception with
1550         throw.
1551         * inf-loop.c (inferior_event_handler): Replace throw_exception
1552         with throw.
1553         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1554         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1555         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1556         (get_prev_frame_always, get_frame_pc_if_available)
1557         (get_frame_address_in_block_if_available, get_frame_language):
1558         Replace throw_exception with throw.
1559         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1560         throw_exception with throw.
1561         * eval.c (fetch_subexp_value, evaluate_var_value)
1562         (evaluate_funcall, evaluate_subexp_standard): Replace
1563         throw_exception with throw.
1564         * dwarf2loc.c (call_site_find_chain)
1565         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1566         Replace throw_exception with throw.
1567         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1568         with throw.
1569         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1570         throw.
1571         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1572         * completer.c (complete_line_internal): Replace throw_exception
1573         with throw.
1574         * compile/compile-object-run.c (compile_object_run): Replace
1575         throw_exception with throw.
1576         * cli/cli-script.c (process_next_line): Replace throw_exception
1577         with throw.
1578         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1579         (btrace_enable, btrace_maint_update_pt_packets): Replace
1580         throw_exception with throw.
1581         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1582         throw_exception with throw.
1583         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1584         throw_exception with throw.
1585         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1586         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1587         * aarch64-tdep.c (aarch64_make_prologue_cache)
1588         (aarch64_make_stub_cache): Replace throw_exception with throw.
1589
1590 2019-04-08  Tom Tromey  <tom@tromey.com>
1591
1592         * common/common-exceptions.c (throw_exception): Rename from
1593         throw_exception_cxx.  Remove old copy.  Make argument const.
1594         (throw_it): Create and throw exception objects directly.
1595         * common/common-exceptions.h (throw_exception): Make argument
1596         const.
1597         (struct gdb_exception_error): Add constructor.
1598         (struct gdb_exception_quit): Add constructor.
1599
1600 2019-04-08  Tom Tromey  <tom@tromey.com>
1601
1602         * common/common-exceptions.h (exception_rethrow): Don't declare.
1603         (TRY_SJLJ): Update comment.
1604         (TRY, CATCH, END_CATCH): Remove.
1605         * common/common-exceptions.c (exception_rethrow): Remove.
1606
1607 2019-04-08  Tom Tromey  <tom@tromey.com>
1608
1609         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1610         Remove.
1611         (gdb_exception_error): Rename from
1612         gdb_exception_RETURN_MASK_ERROR.
1613         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1614         (gdb_quit_bad_alloc): Update.
1615         * aarch64-tdep.c: Update.
1616         * ada-lang.c: Update.
1617         * ada-typeprint.c: Update.
1618         * ada-valprint.c: Update.
1619         * amd64-tdep.c: Update.
1620         * arch-utils.c: Update.
1621         * break-catch-throw.c: Update.
1622         * breakpoint.c: Update.
1623         * btrace.c: Update.
1624         * c-varobj.c: Update.
1625         * cli/cli-cmds.c: Update.
1626         * cli/cli-interp.c: Update.
1627         * cli/cli-script.c: Update.
1628         * common/common-exceptions.c: Update.
1629         * common/new-op.c: Update.
1630         * common/selftest.c: Update.
1631         * compile/compile-c-symbols.c: Update.
1632         * compile/compile-cplus-symbols.c: Update.
1633         * compile/compile-object-load.c: Update.
1634         * compile/compile-object-run.c: Update.
1635         * completer.c: Update.
1636         * corelow.c: Update.
1637         * cp-abi.c: Update.
1638         * cp-support.c: Update.
1639         * cp-valprint.c: Update.
1640         * darwin-nat.c: Update.
1641         * disasm-selftests.c: Update.
1642         * dtrace-probe.c: Update.
1643         * dwarf-index-cache.c: Update.
1644         * dwarf-index-write.c: Update.
1645         * dwarf2-frame-tailcall.c: Update.
1646         * dwarf2-frame.c: Update.
1647         * dwarf2loc.c: Update.
1648         * dwarf2read.c: Update.
1649         * eval.c: Update.
1650         * event-loop.c: Update.
1651         * event-top.c: Update.
1652         * exec.c: Update.
1653         * f-valprint.c: Update.
1654         * fbsd-tdep.c: Update.
1655         * frame-unwind.c: Update.
1656         * frame.c: Update.
1657         * gdbtypes.c: Update.
1658         * gnu-v3-abi.c: Update.
1659         * guile/guile-internal.h: Update.
1660         * guile/scm-block.c: Update.
1661         * guile/scm-breakpoint.c: Update.
1662         * guile/scm-cmd.c: Update.
1663         * guile/scm-disasm.c: Update.
1664         * guile/scm-frame.c: Update.
1665         * guile/scm-lazy-string.c: Update.
1666         * guile/scm-math.c: Update.
1667         * guile/scm-param.c: Update.
1668         * guile/scm-ports.c: Update.
1669         * guile/scm-pretty-print.c: Update.
1670         * guile/scm-symbol.c: Update.
1671         * guile/scm-symtab.c: Update.
1672         * guile/scm-type.c: Update.
1673         * guile/scm-value.c: Update.
1674         * i386-linux-tdep.c: Update.
1675         * i386-tdep.c: Update.
1676         * inf-loop.c: Update.
1677         * infcall.c: Update.
1678         * infcmd.c: Update.
1679         * infrun.c: Update.
1680         * jit.c: Update.
1681         * language.c: Update.
1682         * linespec.c: Update.
1683         * linux-fork.c: Update.
1684         * linux-nat.c: Update.
1685         * linux-tdep.c: Update.
1686         * linux-thread-db.c: Update.
1687         * main.c: Update.
1688         * mi/mi-cmd-break.c: Update.
1689         * mi/mi-cmd-stack.c: Update.
1690         * mi/mi-interp.c: Update.
1691         * mi/mi-main.c: Update.
1692         * objc-lang.c: Update.
1693         * p-valprint.c: Update.
1694         * parse.c: Update.
1695         * ppc-linux-tdep.c: Update.
1696         * printcmd.c: Update.
1697         * python/py-arch.c: Update.
1698         * python/py-breakpoint.c: Update.
1699         * python/py-cmd.c: Update.
1700         * python/py-finishbreakpoint.c: Update.
1701         * python/py-frame.c: Update.
1702         * python/py-framefilter.c: Update.
1703         * python/py-gdb-readline.c: Update.
1704         * python/py-inferior.c: Update.
1705         * python/py-infthread.c: Update.
1706         * python/py-lazy-string.c: Update.
1707         * python/py-linetable.c: Update.
1708         * python/py-objfile.c: Update.
1709         * python/py-param.c: Update.
1710         * python/py-prettyprint.c: Update.
1711         * python/py-progspace.c: Update.
1712         * python/py-record-btrace.c: Update.
1713         * python/py-record.c: Update.
1714         * python/py-symbol.c: Update.
1715         * python/py-type.c: Update.
1716         * python/py-unwind.c: Update.
1717         * python/py-utils.c: Update.
1718         * python/py-value.c: Update.
1719         * python/python.c: Update.
1720         * record-btrace.c: Update.
1721         * record-full.c: Update.
1722         * remote-fileio.c: Update.
1723         * remote.c: Update.
1724         * riscv-tdep.c: Update.
1725         * rs6000-aix-tdep.c: Update.
1726         * rs6000-tdep.c: Update.
1727         * rust-exp.y: Update.
1728         * rust-lang.c: Update.
1729         * s390-tdep.c: Update.
1730         * selftest-arch.c: Update.
1731         * solib-dsbt.c: Update.
1732         * solib-frv.c: Update.
1733         * solib-spu.c: Update.
1734         * solib-svr4.c: Update.
1735         * solib.c: Update.
1736         * sparc64-linux-tdep.c: Update.
1737         * stack.c: Update.
1738         * symfile-mem.c: Update.
1739         * symmisc.c: Update.
1740         * target.c: Update.
1741         * thread.c: Update.
1742         * top.c: Update.
1743         * tracefile-tfile.c: Update.
1744         * tui/tui.c: Update.
1745         * typeprint.c: Update.
1746         * unittests/cli-utils-selftests.c: Update.
1747         * unittests/parse-connection-spec-selftests.c: Update.
1748         * valops.c: Update.
1749         * valprint.c: Update.
1750         * value.c: Update.
1751         * varobj.c: Update.
1752         * windows-nat.c: Update.
1753         * x86-linux-nat.c: Update.
1754         * xml-support.c: Update.
1755
1756 2019-04-08  Tom Tromey  <tom@tromey.com>
1757
1758         * xml-support.c: Use C++ exception handling.
1759         * x86-linux-nat.c: Use C++ exception handling.
1760         * windows-nat.c: Use C++ exception handling.
1761         * varobj.c: Use C++ exception handling.
1762         * value.c: Use C++ exception handling.
1763         * valprint.c: Use C++ exception handling.
1764         * valops.c: Use C++ exception handling.
1765         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1766         handling.
1767         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1768         * typeprint.c: Use C++ exception handling.
1769         * tui/tui.c: Use C++ exception handling.
1770         * tracefile-tfile.c: Use C++ exception handling.
1771         * top.c: Use C++ exception handling.
1772         * thread.c: Use C++ exception handling.
1773         * target.c: Use C++ exception handling.
1774         * symmisc.c: Use C++ exception handling.
1775         * symfile-mem.c: Use C++ exception handling.
1776         * stack.c: Use C++ exception handling.
1777         * sparc64-linux-tdep.c: Use C++ exception handling.
1778         * solib.c: Use C++ exception handling.
1779         * solib-svr4.c: Use C++ exception handling.
1780         * solib-spu.c: Use C++ exception handling.
1781         * solib-frv.c: Use C++ exception handling.
1782         * solib-dsbt.c: Use C++ exception handling.
1783         * selftest-arch.c: Use C++ exception handling.
1784         * s390-tdep.c: Use C++ exception handling.
1785         * rust-lang.c: Use C++ exception handling.
1786         * rust-exp.y: Use C++ exception handling.
1787         * rs6000-tdep.c: Use C++ exception handling.
1788         * rs6000-aix-tdep.c: Use C++ exception handling.
1789         * riscv-tdep.c: Use C++ exception handling.
1790         * remote.c: Use C++ exception handling.
1791         * remote-fileio.c: Use C++ exception handling.
1792         * record-full.c: Use C++ exception handling.
1793         * record-btrace.c: Use C++ exception handling.
1794         * python/python.c: Use C++ exception handling.
1795         * python/py-value.c: Use C++ exception handling.
1796         * python/py-utils.c: Use C++ exception handling.
1797         * python/py-unwind.c: Use C++ exception handling.
1798         * python/py-type.c: Use C++ exception handling.
1799         * python/py-symbol.c: Use C++ exception handling.
1800         * python/py-record.c: Use C++ exception handling.
1801         * python/py-record-btrace.c: Use C++ exception handling.
1802         * python/py-progspace.c: Use C++ exception handling.
1803         * python/py-prettyprint.c: Use C++ exception handling.
1804         * python/py-param.c: Use C++ exception handling.
1805         * python/py-objfile.c: Use C++ exception handling.
1806         * python/py-linetable.c: Use C++ exception handling.
1807         * python/py-lazy-string.c: Use C++ exception handling.
1808         * python/py-infthread.c: Use C++ exception handling.
1809         * python/py-inferior.c: Use C++ exception handling.
1810         * python/py-gdb-readline.c: Use C++ exception handling.
1811         * python/py-framefilter.c: Use C++ exception handling.
1812         * python/py-frame.c: Use C++ exception handling.
1813         * python/py-finishbreakpoint.c: Use C++ exception handling.
1814         * python/py-cmd.c: Use C++ exception handling.
1815         * python/py-breakpoint.c: Use C++ exception handling.
1816         * python/py-arch.c: Use C++ exception handling.
1817         * printcmd.c: Use C++ exception handling.
1818         * ppc-linux-tdep.c: Use C++ exception handling.
1819         * parse.c: Use C++ exception handling.
1820         * p-valprint.c: Use C++ exception handling.
1821         * objc-lang.c: Use C++ exception handling.
1822         * mi/mi-main.c: Use C++ exception handling.
1823         * mi/mi-interp.c: Use C++ exception handling.
1824         * mi/mi-cmd-stack.c: Use C++ exception handling.
1825         * mi/mi-cmd-break.c: Use C++ exception handling.
1826         * main.c: Use C++ exception handling.
1827         * linux-thread-db.c: Use C++ exception handling.
1828         * linux-tdep.c: Use C++ exception handling.
1829         * linux-nat.c: Use C++ exception handling.
1830         * linux-fork.c: Use C++ exception handling.
1831         * linespec.c: Use C++ exception handling.
1832         * language.c: Use C++ exception handling.
1833         * jit.c: Use C++ exception handling.
1834         * infrun.c: Use C++ exception handling.
1835         * infcmd.c: Use C++ exception handling.
1836         * infcall.c: Use C++ exception handling.
1837         * inf-loop.c: Use C++ exception handling.
1838         * i386-tdep.c: Use C++ exception handling.
1839         * i386-linux-tdep.c: Use C++ exception handling.
1840         * guile/scm-value.c: Use C++ exception handling.
1841         * guile/scm-type.c: Use C++ exception handling.
1842         * guile/scm-symtab.c: Use C++ exception handling.
1843         * guile/scm-symbol.c: Use C++ exception handling.
1844         * guile/scm-pretty-print.c: Use C++ exception handling.
1845         * guile/scm-ports.c: Use C++ exception handling.
1846         * guile/scm-param.c: Use C++ exception handling.
1847         * guile/scm-math.c: Use C++ exception handling.
1848         * guile/scm-lazy-string.c: Use C++ exception handling.
1849         * guile/scm-frame.c: Use C++ exception handling.
1850         * guile/scm-disasm.c: Use C++ exception handling.
1851         * guile/scm-cmd.c: Use C++ exception handling.
1852         * guile/scm-breakpoint.c: Use C++ exception handling.
1853         * guile/scm-block.c: Use C++ exception handling.
1854         * guile/guile-internal.h: Use C++ exception handling.
1855         * gnu-v3-abi.c: Use C++ exception handling.
1856         * gdbtypes.c: Use C++ exception handling.
1857         * frame.c: Use C++ exception handling.
1858         * frame-unwind.c: Use C++ exception handling.
1859         * fbsd-tdep.c: Use C++ exception handling.
1860         * f-valprint.c: Use C++ exception handling.
1861         * exec.c: Use C++ exception handling.
1862         * event-top.c: Use C++ exception handling.
1863         * event-loop.c: Use C++ exception handling.
1864         * eval.c: Use C++ exception handling.
1865         * dwarf2read.c: Use C++ exception handling.
1866         * dwarf2loc.c: Use C++ exception handling.
1867         * dwarf2-frame.c: Use C++ exception handling.
1868         * dwarf2-frame-tailcall.c: Use C++ exception handling.
1869         * dwarf-index-write.c: Use C++ exception handling.
1870         * dwarf-index-cache.c: Use C++ exception handling.
1871         * dtrace-probe.c: Use C++ exception handling.
1872         * disasm-selftests.c: Use C++ exception handling.
1873         * darwin-nat.c: Use C++ exception handling.
1874         * cp-valprint.c: Use C++ exception handling.
1875         * cp-support.c: Use C++ exception handling.
1876         * cp-abi.c: Use C++ exception handling.
1877         * corelow.c: Use C++ exception handling.
1878         * completer.c: Use C++ exception handling.
1879         * compile/compile-object-run.c: Use C++ exception handling.
1880         * compile/compile-object-load.c: Use C++ exception handling.
1881         * compile/compile-cplus-symbols.c: Use C++ exception handling.
1882         * compile/compile-c-symbols.c: Use C++ exception handling.
1883         * common/selftest.c: Use C++ exception handling.
1884         * common/new-op.c: Use C++ exception handling.
1885         * cli/cli-script.c: Use C++ exception handling.
1886         * cli/cli-interp.c: Use C++ exception handling.
1887         * cli/cli-cmds.c: Use C++ exception handling.
1888         * c-varobj.c: Use C++ exception handling.
1889         * btrace.c: Use C++ exception handling.
1890         * breakpoint.c: Use C++ exception handling.
1891         * break-catch-throw.c: Use C++ exception handling.
1892         * arch-utils.c: Use C++ exception handling.
1893         * amd64-tdep.c: Use C++ exception handling.
1894         * ada-valprint.c: Use C++ exception handling.
1895         * ada-typeprint.c: Use C++ exception handling.
1896         * ada-lang.c: Use C++ exception handling.
1897         * aarch64-tdep.c: Use C++ exception handling.
1898
1899 2019-04-08  Tom Tromey  <tom@tromey.com>
1900
1901         * xml-support.c (gdb_xml_parser::parse): Update.
1902         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1903         * value.c (show_convenience): Update.
1904         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
1905         (test_parse_flags_qcs): Update.
1906         * thread.c (thr_try_catch_cmd): Update.
1907         * target.c (target_translate_tls_address): Update.
1908         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1909         (info_frame_command_core, frame_apply_command_count): Update.
1910         * rust-exp.y (rust_lex_exception_test): Update.
1911         * riscv-tdep.c (riscv_print_one_register_info): Update.
1912         * remote.c (remote_target::enable_btrace): Update.
1913         * record-btrace.c (record_btrace_enable_warn): Update.
1914         * python/py-utils.c (gdbpy_convert_exception): Update.
1915         * printcmd.c (do_one_display, print_variable_and_value): Update.
1916         * mi/mi-main.c (mi_print_exception): Update.
1917         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
1918         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1919         * linux-nat.c (linux_nat_target::attach): Update.
1920         * linux-fork.c (class scoped_switch_fork_info): Update.
1921         * infrun.c (displaced_step_prepare): Update.
1922         * infcall.c (call_function_by_hand_dummy): Update.
1923         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
1924         * gnu-v3-abi.c (print_one_vtable): Update.
1925         * frame.c (get_prev_frame_always): Update.
1926         * f-valprint.c (info_common_command_for_block): Update.
1927         * exec.c (try_open_exec_file): Update.
1928         * exceptions.c (print_exception, exception_print)
1929         (exception_fprintf, exception_print_same): Update.
1930         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
1931         * dwarf-index-cache.c (index_cache::store)
1932         (index_cache::lookup_gdb_index): Update.
1933         * darwin-nat.c (maybe_cache_shell): Update.
1934         * cp-valprint.c (cp_print_value_fields): Update.
1935         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
1936         (gcc_cplus_symbol_address): Update.
1937         * compile/compile-c-symbols.c (gcc_convert_symbol)
1938         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
1939         * common/selftest.c: Update.
1940         * common/common-exceptions.h (struct gdb_exception) <message>: Now
1941         a std::string.
1942         (exception_try_scope_entry, exception_try_scope_exit): Don't
1943         declare.
1944         (struct exception_try_scope): Remove.
1945         (TRY): Don't use exception_try_scope.
1946         (struct gdb_exception): Add constructor, operator=.
1947         <what>: New method.
1948         (struct gdb_exception_RETURN_MASK_ALL)
1949         (struct gdb_exception_RETURN_MASK_ERROR)
1950         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
1951         (struct gdb_quit_bad_alloc): Update.
1952         * common/common-exceptions.c (exception_none): Change
1953         initializer.
1954         (struct catcher) <state, exception>: Initialize inline.
1955         <prev>: Remove member.
1956         (current_catcher): Remove.
1957         (catchers): New global.
1958         (exceptions_state_mc_init): Simplify.
1959         (catcher_pop): Remove.
1960         (exceptions_state_mc, exceptions_state_mc_catch): Update.
1961         (try_scope_depth, exception_try_scope_entry)
1962         (exception_try_scope_exit): Remove.
1963         (throw_exception_sjlj): Update.
1964         (exception_messages, exception_messages_size): Remove.
1965         (throw_it): Simplify.
1966         (gdb_exception_sliced_copy): Remove.
1967         (throw_exception_cxx): Update.
1968         * cli/cli-script.c (script_from_file): Update.
1969         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
1970         Update.
1971         * ada-valprint.c (ada_val_print): Update.
1972         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
1973         (create_excep_cond_exprs): Update.
1974
1975 2019-04-08  Tom Tromey  <tom@tromey.com>
1976
1977         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
1978         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
1979         (TRY, CATCH, END_CATCH): Remove some definitions.
1980         * common/common-exceptions.c: Don't use GDB_XCPT.
1981         (catcher_list_size): Remove.
1982         (throw_exception, throw_it): Simplify.
1983
1984 2019-04-05  Tom Tromey  <tom@tromey.com>
1985
1986         Revert the header-sorting patch.
1987         * ft32-tdep.c: Revert.
1988         * frv-tdep.c: Revert.
1989         * frv-linux-tdep.c: Revert.
1990         * frame.c: Revert.
1991         * frame-unwind.c: Revert.
1992         * frame-base.c: Revert.
1993         * fork-child.c: Revert.
1994         * findvar.c: Revert.
1995         * findcmd.c: Revert.
1996         * filesystem.c: Revert.
1997         * filename-seen-cache.h: Revert.
1998         * filename-seen-cache.c: Revert.
1999         * fbsd-tdep.c: Revert.
2000         * fbsd-nat.h: Revert.
2001         * fbsd-nat.c: Revert.
2002         * f-valprint.c: Revert.
2003         * f-typeprint.c: Revert.
2004         * f-lang.c: Revert.
2005         * extension.h: Revert.
2006         * extension.c: Revert.
2007         * extension-priv.h: Revert.
2008         * expprint.c: Revert.
2009         * exec.h: Revert.
2010         * exec.c: Revert.
2011         * exceptions.c: Revert.
2012         * event-top.c: Revert.
2013         * event-loop.c: Revert.
2014         * eval.c: Revert.
2015         * elfread.c: Revert.
2016         * dwarf2read.h: Revert.
2017         * dwarf2read.c: Revert.
2018         * dwarf2loc.c: Revert.
2019         * dwarf2expr.h: Revert.
2020         * dwarf2expr.c: Revert.
2021         * dwarf2-frame.c: Revert.
2022         * dwarf2-frame-tailcall.c: Revert.
2023         * dwarf-index-write.h: Revert.
2024         * dwarf-index-write.c: Revert.
2025         * dwarf-index-common.c: Revert.
2026         * dwarf-index-cache.h: Revert.
2027         * dwarf-index-cache.c: Revert.
2028         * dummy-frame.c: Revert.
2029         * dtrace-probe.c: Revert.
2030         * disasm.h: Revert.
2031         * disasm.c: Revert.
2032         * disasm-selftests.c: Revert.
2033         * dictionary.c: Revert.
2034         * dicos-tdep.c: Revert.
2035         * demangle.c: Revert.
2036         * dcache.h: Revert.
2037         * dcache.c: Revert.
2038         * darwin-nat.h: Revert.
2039         * darwin-nat.c: Revert.
2040         * darwin-nat-info.c: Revert.
2041         * d-valprint.c: Revert.
2042         * d-namespace.c: Revert.
2043         * d-lang.c: Revert.
2044         * ctf.c: Revert.
2045         * csky-tdep.c: Revert.
2046         * csky-linux-tdep.c: Revert.
2047         * cris-tdep.c: Revert.
2048         * cris-linux-tdep.c: Revert.
2049         * cp-valprint.c: Revert.
2050         * cp-support.c: Revert.
2051         * cp-namespace.c: Revert.
2052         * cp-abi.c: Revert.
2053         * corelow.c: Revert.
2054         * corefile.c: Revert.
2055         * continuations.c: Revert.
2056         * completer.h: Revert.
2057         * completer.c: Revert.
2058         * complaints.c: Revert.
2059         * coffread.c: Revert.
2060         * coff-pe-read.c: Revert.
2061         * cli-out.h: Revert.
2062         * cli-out.c: Revert.
2063         * charset.c: Revert.
2064         * c-varobj.c: Revert.
2065         * c-valprint.c: Revert.
2066         * c-typeprint.c: Revert.
2067         * c-lang.c: Revert.
2068         * buildsym.c: Revert.
2069         * buildsym-legacy.c: Revert.
2070         * build-id.h: Revert.
2071         * build-id.c: Revert.
2072         * btrace.c: Revert.
2073         * bsd-uthread.c: Revert.
2074         * breakpoint.h: Revert.
2075         * breakpoint.c: Revert.
2076         * break-catch-throw.c: Revert.
2077         * break-catch-syscall.c: Revert.
2078         * break-catch-sig.c: Revert.
2079         * blockframe.c: Revert.
2080         * block.c: Revert.
2081         * bfin-tdep.c: Revert.
2082         * bfin-linux-tdep.c: Revert.
2083         * bfd-target.c: Revert.
2084         * bcache.c: Revert.
2085         * ax-general.c: Revert.
2086         * ax-gdb.h: Revert.
2087         * ax-gdb.c: Revert.
2088         * avr-tdep.c: Revert.
2089         * auxv.c: Revert.
2090         * auto-load.c: Revert.
2091         * arm-wince-tdep.c: Revert.
2092         * arm-tdep.c: Revert.
2093         * arm-symbian-tdep.c: Revert.
2094         * arm-pikeos-tdep.c: Revert.
2095         * arm-obsd-tdep.c: Revert.
2096         * arm-nbsd-tdep.c: Revert.
2097         * arm-nbsd-nat.c: Revert.
2098         * arm-linux-tdep.c: Revert.
2099         * arm-linux-nat.c: Revert.
2100         * arm-fbsd-tdep.c: Revert.
2101         * arm-fbsd-nat.c: Revert.
2102         * arm-bsd-tdep.c: Revert.
2103         * arch-utils.c: Revert.
2104         * arc-tdep.c: Revert.
2105         * arc-newlib-tdep.c: Revert.
2106         * annotate.h: Revert.
2107         * annotate.c: Revert.
2108         * amd64-windows-tdep.c: Revert.
2109         * amd64-windows-nat.c: Revert.
2110         * amd64-tdep.c: Revert.
2111         * amd64-sol2-tdep.c: Revert.
2112         * amd64-obsd-tdep.c: Revert.
2113         * amd64-obsd-nat.c: Revert.
2114         * amd64-nbsd-tdep.c: Revert.
2115         * amd64-nbsd-nat.c: Revert.
2116         * amd64-nat.c: Revert.
2117         * amd64-linux-tdep.c: Revert.
2118         * amd64-linux-nat.c: Revert.
2119         * amd64-fbsd-tdep.c: Revert.
2120         * amd64-fbsd-nat.c: Revert.
2121         * amd64-dicos-tdep.c: Revert.
2122         * amd64-darwin-tdep.c: Revert.
2123         * amd64-bsd-nat.c: Revert.
2124         * alpha-tdep.c: Revert.
2125         * alpha-obsd-tdep.c: Revert.
2126         * alpha-nbsd-tdep.c: Revert.
2127         * alpha-mdebug-tdep.c: Revert.
2128         * alpha-linux-tdep.c: Revert.
2129         * alpha-linux-nat.c: Revert.
2130         * alpha-bsd-tdep.c: Revert.
2131         * alpha-bsd-nat.c: Revert.
2132         * aix-thread.c: Revert.
2133         * agent.c: Revert.
2134         * addrmap.c: Revert.
2135         * ada-varobj.c: Revert.
2136         * ada-valprint.c: Revert.
2137         * ada-typeprint.c: Revert.
2138         * ada-tasks.c: Revert.
2139         * ada-lang.c: Revert.
2140         * aarch64-tdep.c: Revert.
2141         * aarch64-ravenscar-thread.c: Revert.
2142         * aarch64-newlib-tdep.c: Revert.
2143         * aarch64-linux-tdep.c: Revert.
2144         * aarch64-linux-nat.c: Revert.
2145         * aarch64-fbsd-tdep.c: Revert.
2146         * aarch64-fbsd-nat.c: Revert.
2147         * aarch32-linux-nat.c: Revert.
2148
2149 2019-04-05  Tom Tromey  <tom@tromey.com>
2150
2151         * ft32-tdep.c: Sort headers.
2152         * frv-tdep.c: Sort headers.
2153         * frv-linux-tdep.c: Sort headers.
2154         * frame.c: Sort headers.
2155         * frame-unwind.c: Sort headers.
2156         * frame-base.c: Sort headers.
2157         * fork-child.c: Sort headers.
2158         * findvar.c: Sort headers.
2159         * findcmd.c: Sort headers.
2160         * filesystem.c: Sort headers.
2161         * filename-seen-cache.h: Sort headers.
2162         * filename-seen-cache.c: Sort headers.
2163         * fbsd-tdep.c: Sort headers.
2164         * fbsd-nat.h: Sort headers.
2165         * fbsd-nat.c: Sort headers.
2166         * f-valprint.c: Sort headers.
2167         * f-typeprint.c: Sort headers.
2168         * f-lang.c: Sort headers.
2169         * extension.h: Sort headers.
2170         * extension.c: Sort headers.
2171         * extension-priv.h: Sort headers.
2172         * expprint.c: Sort headers.
2173         * exec.h: Sort headers.
2174         * exec.c: Sort headers.
2175         * exceptions.c: Sort headers.
2176         * event-top.c: Sort headers.
2177         * event-loop.c: Sort headers.
2178         * eval.c: Sort headers.
2179         * elfread.c: Sort headers.
2180         * dwarf2read.h: Sort headers.
2181         * dwarf2read.c: Sort headers.
2182         * dwarf2loc.c: Sort headers.
2183         * dwarf2expr.h: Sort headers.
2184         * dwarf2expr.c: Sort headers.
2185         * dwarf2-frame.c: Sort headers.
2186         * dwarf2-frame-tailcall.c: Sort headers.
2187         * dwarf-index-write.h: Sort headers.
2188         * dwarf-index-write.c: Sort headers.
2189         * dwarf-index-common.c: Sort headers.
2190         * dwarf-index-cache.h: Sort headers.
2191         * dwarf-index-cache.c: Sort headers.
2192         * dummy-frame.c: Sort headers.
2193         * dtrace-probe.c: Sort headers.
2194         * disasm.h: Sort headers.
2195         * disasm.c: Sort headers.
2196         * disasm-selftests.c: Sort headers.
2197         * dictionary.c: Sort headers.
2198         * dicos-tdep.c: Sort headers.
2199         * demangle.c: Sort headers.
2200         * dcache.h: Sort headers.
2201         * dcache.c: Sort headers.
2202         * darwin-nat.h: Sort headers.
2203         * darwin-nat.c: Sort headers.
2204         * darwin-nat-info.c: Sort headers.
2205         * d-valprint.c: Sort headers.
2206         * d-namespace.c: Sort headers.
2207         * d-lang.c: Sort headers.
2208         * ctf.c: Sort headers.
2209         * csky-tdep.c: Sort headers.
2210         * csky-linux-tdep.c: Sort headers.
2211         * cris-tdep.c: Sort headers.
2212         * cris-linux-tdep.c: Sort headers.
2213         * cp-valprint.c: Sort headers.
2214         * cp-support.c: Sort headers.
2215         * cp-namespace.c: Sort headers.
2216         * cp-abi.c: Sort headers.
2217         * corelow.c: Sort headers.
2218         * corefile.c: Sort headers.
2219         * continuations.c: Sort headers.
2220         * completer.h: Sort headers.
2221         * completer.c: Sort headers.
2222         * complaints.c: Sort headers.
2223         * coffread.c: Sort headers.
2224         * coff-pe-read.c: Sort headers.
2225         * cli-out.h: Sort headers.
2226         * cli-out.c: Sort headers.
2227         * charset.c: Sort headers.
2228         * c-varobj.c: Sort headers.
2229         * c-valprint.c: Sort headers.
2230         * c-typeprint.c: Sort headers.
2231         * c-lang.c: Sort headers.
2232         * buildsym.c: Sort headers.
2233         * buildsym-legacy.c: Sort headers.
2234         * build-id.h: Sort headers.
2235         * build-id.c: Sort headers.
2236         * btrace.c: Sort headers.
2237         * bsd-uthread.c: Sort headers.
2238         * breakpoint.h: Sort headers.
2239         * breakpoint.c: Sort headers.
2240         * break-catch-throw.c: Sort headers.
2241         * break-catch-syscall.c: Sort headers.
2242         * break-catch-sig.c: Sort headers.
2243         * blockframe.c: Sort headers.
2244         * block.c: Sort headers.
2245         * bfin-tdep.c: Sort headers.
2246         * bfin-linux-tdep.c: Sort headers.
2247         * bfd-target.c: Sort headers.
2248         * bcache.c: Sort headers.
2249         * ax-general.c: Sort headers.
2250         * ax-gdb.h: Sort headers.
2251         * ax-gdb.c: Sort headers.
2252         * avr-tdep.c: Sort headers.
2253         * auxv.c: Sort headers.
2254         * auto-load.c: Sort headers.
2255         * arm-wince-tdep.c: Sort headers.
2256         * arm-tdep.c: Sort headers.
2257         * arm-symbian-tdep.c: Sort headers.
2258         * arm-pikeos-tdep.c: Sort headers.
2259         * arm-obsd-tdep.c: Sort headers.
2260         * arm-nbsd-tdep.c: Sort headers.
2261         * arm-nbsd-nat.c: Sort headers.
2262         * arm-linux-tdep.c: Sort headers.
2263         * arm-linux-nat.c: Sort headers.
2264         * arm-fbsd-tdep.c: Sort headers.
2265         * arm-fbsd-nat.c: Sort headers.
2266         * arm-bsd-tdep.c: Sort headers.
2267         * arch-utils.c: Sort headers.
2268         * arc-tdep.c: Sort headers.
2269         * arc-newlib-tdep.c: Sort headers.
2270         * annotate.h: Sort headers.
2271         * annotate.c: Sort headers.
2272         * amd64-windows-tdep.c: Sort headers.
2273         * amd64-windows-nat.c: Sort headers.
2274         * amd64-tdep.c: Sort headers.
2275         * amd64-sol2-tdep.c: Sort headers.
2276         * amd64-obsd-tdep.c: Sort headers.
2277         * amd64-obsd-nat.c: Sort headers.
2278         * amd64-nbsd-tdep.c: Sort headers.
2279         * amd64-nbsd-nat.c: Sort headers.
2280         * amd64-nat.c: Sort headers.
2281         * amd64-linux-tdep.c: Sort headers.
2282         * amd64-linux-nat.c: Sort headers.
2283         * amd64-fbsd-tdep.c: Sort headers.
2284         * amd64-fbsd-nat.c: Sort headers.
2285         * amd64-dicos-tdep.c: Sort headers.
2286         * amd64-darwin-tdep.c: Sort headers.
2287         * amd64-bsd-nat.c: Sort headers.
2288         * alpha-tdep.c: Sort headers.
2289         * alpha-obsd-tdep.c: Sort headers.
2290         * alpha-nbsd-tdep.c: Sort headers.
2291         * alpha-mdebug-tdep.c: Sort headers.
2292         * alpha-linux-tdep.c: Sort headers.
2293         * alpha-linux-nat.c: Sort headers.
2294         * alpha-bsd-tdep.c: Sort headers.
2295         * alpha-bsd-nat.c: Sort headers.
2296         * aix-thread.c: Sort headers.
2297         * agent.c: Sort headers.
2298         * addrmap.c: Sort headers.
2299         * ada-varobj.c: Sort headers.
2300         * ada-valprint.c: Sort headers.
2301         * ada-typeprint.c: Sort headers.
2302         * ada-tasks.c: Sort headers.
2303         * ada-lang.c: Sort headers.
2304         * aarch64-tdep.c: Sort headers.
2305         * aarch64-ravenscar-thread.c: Sort headers.
2306         * aarch64-newlib-tdep.c: Sort headers.
2307         * aarch64-linux-tdep.c: Sort headers.
2308         * aarch64-linux-nat.c: Sort headers.
2309         * aarch64-fbsd-tdep.c: Sort headers.
2310         * aarch64-fbsd-nat.c: Sort headers.
2311         * aarch32-linux-nat.c: Sort headers.
2312
2313 2019-04-04  Tom Tromey  <tom@tromey.com>
2314
2315         * varobj.c (varobj_create): Update.
2316         * rust-exp.y (struct rust_parser) <update_innermost_block,
2317         lookup_symbol>: New methods.
2318         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
2319         Rename.
2320         (rust_parser::rust_lookup_type)
2321         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2322         * printcmd.c (display_command, do_one_display): Update.
2323         * parser-defs.h (struct parser_state) <parser_state>: Add
2324         "tracker" parameter.
2325         (block_tracker): New member.
2326         (class innermost_block_tracker) <innermost_block_tracker>: Add
2327         "types" parameter.
2328         <reset>: Remove method.
2329         (innermost_block): Don't declare.
2330         (null_post_parser): Update.
2331         * parse.c (innermost_block): Remove global.
2332         (write_dollar_variable): Update.
2333         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
2334         Remove "tracker_types" parameter.
2335         (parse_expression): Add "tracker" parameter.
2336         (parse_expression_for_completion): Update.
2337         (null_post_parser): Add "tracker" parameter.
2338         * p-exp.y: Update rules.
2339         * m2-exp.y: Update rules.
2340         * language.h (struct language_defn) <la_post_parser>: Add
2341         "tracker" parameter.
2342         * go-exp.y: Update rules.
2343         * f-exp.y: Update rules.
2344         * expression.h (parse_expression, parse_exp_1): Add "tracker"
2345         parameter.
2346         * d-exp.y: Update rules.
2347         * c-exp.y: Update rules.
2348         * breakpoint.c (set_breakpoint_condition): Create an
2349         innermost_block_tracker.
2350         (watch_command_1): Likewise.
2351         * ada-lang.c (resolve): Add "tracker" parameter.
2352         (resolve_subexp): Likewise.
2353         * ada-exp.y (write_var_from_sym): Update.
2354
2355 2019-04-04  Tom Tromey  <tom@tromey.com>
2356
2357         * type-stack.h: New file.
2358         * type-stack.c: New file.
2359         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
2360         type-stack.h.
2361         (insert_into_type_stack, insert_type, push_type, push_type_int)
2362         (insert_type_address_space, pop_type, pop_type_int)
2363         (pop_typelist, pop_type_stack, append_type_stack)
2364         (push_type_stack, get_type_stack, push_typelist)
2365         (follow_type_instance_flags, follow_types): Don't declare.
2366         * parse.c (type_stack): Remove global.
2367         (parse_exp_in_context): Update.
2368         (insert_into_type_stack, insert_type, push_type, push_type_int)
2369         (insert_type_address_space, pop_type, pop_type_int)
2370         (pop_typelist, pop_type_stack, append_type_stack)
2371         (push_type_stack, get_type_stack, push_typelist)
2372         (follow_type_instance_flags, follow_types): Remove (moved to
2373         type-stack.c).
2374         * f-exp.y (type_stack): New global.
2375         Update rules.
2376         (push_kind_type, f_parse): Update.
2377         * d-exp.y (type_stack): New global.
2378         Update rules.
2379         (d_parse): Update.
2380         * c-exp.y (struct c_parse_state) <type_stack>: New member.
2381         Update rules.
2382         * Makefile.in (COMMON_SFILES): Add type-stack.c.
2383         (HFILES_NO_SRCDIR): Add type-stack.h.
2384
2385 2019-04-04  Tom Tromey  <tom@tromey.com>
2386
2387         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
2388         (rust_parser::convert_ast_to_expression, rust_parse)
2389         (rust_lex_test_completion, rust_lex_tests): Update.
2390         * parser-defs.h (struct expr_completion_state): New.
2391         (struct parser_state) <parser_state>: Add completion parameter.
2392         <mark_struct_expression, mark_completion_tag>: New methods.
2393         <parse_completion, m_completion_state>: New members.
2394         (prefixify_expression, null_post_parser): Update.
2395         (mark_struct_expression, mark_completion_tag): Don't declare.
2396         * parse.c (parse_completion, expout_last_struct)
2397         (expout_tag_completion_type, expout_completion_name): Remove
2398         globals.
2399         (parser_state::mark_struct_expression)
2400         (parser_state::mark_completion_tag): Now methods.
2401         (prefixify_expression): Add last_struct parameter.
2402         (prefixify_subexp): Likewise.
2403         (parse_exp_1): Update.
2404         (parse_exp_in_context): Add cstate parameter.  Update.
2405         (parse_expression_for_completion): Create an
2406         expr_completion_state.
2407         (null_post_parser): Add "completion" parameter.
2408         * p-exp.y: Update rules.
2409         (yylex): Update.
2410         * language.h (struct language_defn) <la_post_parser>: Add
2411         "completing" parameter.
2412         * go-exp.y: Update rules.
2413         (lex_one_token): Update.
2414         * expression.h (parse_completion): Don't declare.
2415         * d-exp.y: Update rules.
2416         (lex_one_token): Update rules.
2417         * c-exp.y: Update rules.
2418         (lex_one_token): Update.
2419         * ada-lang.c (resolve): Add "parse_completion" parameter.
2420         (resolve_subexp): Likewise.
2421         (ada_resolve_function): Likewise.
2422
2423 2019-04-04  Tom Tromey  <tom@tromey.com>
2424
2425         * parser-defs.h (struct parser_state) <start_arglist,
2426         end_arglist>: New methods.
2427         <arglist_len, m_funcall_chain>: New members.
2428         (arglist_len, start_arglist, end_arglist): Don't declare.
2429         * parse.c (arglist_len, funcall_chain): Remove global.
2430         (start_arglist, end_arglist): Remove functions.
2431         (parse_exp_in_context): Update.
2432         * p-exp.y: Update rules.
2433         * m2-exp.y: Update rules.
2434         * go-exp.y: Update rules.
2435         * f-exp.y: Update rules.
2436         * d-exp.y: Update rules.
2437         * c-exp.y: Update rules.
2438
2439 2019-04-04  Tom Tromey  <tom@tromey.com>
2440
2441         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2442         lex_operator, push_back>: New methods.
2443         Update all rules.
2444         (rust_parser::lex_hex, lex_escape): Rename and update.
2445         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2446         (rust_parser::lex_operator): Rename and update.
2447         (rust_parser::lex_number, rustyylex, rustyyerror)
2448         (rust_lex_test_init, rust_lex_test_sequence)
2449         (rust_lex_test_push_back, rust_lex_tests): Update.
2450         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2451         parameter.
2452         <lexptr, prev_lexptr>: New members.
2453         (lexptr, prev_lexptr): Don't declare.
2454         * parse.c (lexptr, prev_lexptr): Remove globals.
2455         (parse_exp_in_context): Update.
2456         * p-exp.y (yylex, yyerror): Update.
2457         * m2-exp.y (parse_number, yylex, yyerror): Update.
2458         * go-exp.y (lex_one_token, yyerror): Update.
2459         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2460         * d-exp.y (lex_one_token, yyerror): Update.
2461         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2462         (lex_one_token, yyerror): Update.
2463         * ada-lex.l (YY_INPUT): Update.
2464         (rewind_to_char): Update.
2465         * ada-exp.y (yyerror): Update.
2466
2467 2019-04-04  Tom Tromey  <tom@tromey.com>
2468
2469         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2470         * parser-defs.h (struct parser_state) <parser_state>: Add new
2471         parameter.
2472         <comma_terminates>: New member.
2473         (comma_terminates): Don't declare global.
2474         * parse.c (comma_terminates): Remove global.
2475         (parse_exp_in_context): Update.
2476         * p-exp.y (yylex): Update.
2477         * m2-exp.y (yylex): Update.
2478         * go-exp.y (lex_one_token): Update.
2479         * f-exp.y (yylex): Update.
2480         * d-exp.y (lex_one_token): Update.
2481         * c-exp.y (lex_one_token): Update.
2482         * ada-lex.l: Update.
2483
2484 2019-04-04  Tom Tromey  <tom@tromey.com>
2485
2486         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2487         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2488         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2489         * parser-defs.h (paren_depth): Don't declare.
2490         * parse.c (paren_depth): Remove global.
2491         (parse_exp_in_context): Update.
2492         * p-exp.y (paren_depth): New global.
2493         (pascal_parse): Initialize it.
2494         * m2-exp.y (paren_depth): New global.
2495         (m2_parse): Initialize it.
2496         * go-exp.y (paren_depth): New global.
2497         (go_parse): Initialize it.
2498         * f-exp.y (paren_depth): New global.
2499         (f_parse): Initialize it.
2500         * d-exp.y (paren_depth): New global.
2501         (d_parse): Initialize it.
2502         * c-exp.y (paren_depth): New global.
2503         (c_parse): Initialize it.
2504         * ada-lex.l (paren_depth): New global.
2505         (lexer_init): Initialize it.
2506
2507 2019-04-04  Tom Tromey  <tom@tromey.com>
2508
2509         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2510         (rust_parser::convert_ast_to_type)
2511         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2512         * parser-defs.h (struct parser_state) <parser_state>: Add
2513         parameters.  Initialize new members.
2514         <expression_context_block, expression_context_pc>: New members.
2515         * parse.c (expression_context_block, expression_context_pc):
2516         Remove globals.
2517         (parse_exp_in_context): Update.
2518         * p-exp.y: Update all rules.
2519         (yylex): Update.
2520         * m2-exp.y: Update all rules.
2521         (yylex): Update.
2522         * go-exp.y (yylex): Update.
2523         * f-exp.y (yylex): Update.
2524         * d-exp.y: Update all rules.
2525         (yylex): Update.
2526         * c-exp.y: Update all rules.
2527         (lex_one_token, classify_name, yylex, c_parse): Update.
2528         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2529
2530 2019-04-04  Tom Tromey  <tom@tromey.com>
2531
2532         * gdbarch.h, gdbarch.c: Rebuild.
2533         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2534         * stap-probe.h:
2535         (struct stap_parse_info): Replace "parser_state" with
2536         "expr_builder".
2537         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2538         (parser_state): New class.
2539         * parse.c (expr_builder): Rename.
2540         (expr_builder::release): Rename.
2541         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2542         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2543         (write_exp_elt_longcst, write_exp_elt_floatcst)
2544         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2545         (write_exp_string_vector, write_exp_bitstring)
2546         (write_exp_msymbol, mark_struct_expression)
2547         (write_dollar_variable)
2548         (insert_type_address_space, increase_expout_size): Replace
2549         "parser_state" with "expr_builder".
2550         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2551         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2552         "parser_state" with "expr_builder".
2553
2554 2019-04-04  Tom Tromey  <tom@tromey.com>
2555
2556         * rust-exp.y: Replace "parse_language" with method call.
2557         * p-exp.y:
2558         (yylex): Replace "parse_language" with method call.
2559         * m2-exp.y:
2560         (yylex): Replace "parse_language" with method call.
2561         * go-exp.y (classify_name): Replace "parse_language" with method
2562         call.
2563         * f-exp.y (yylex): Replace "parse_language" with method call.
2564         * d-exp.y (lex_one_token): Replace "parse_language" with method
2565         call.
2566         * c-exp.y:
2567         (lex_one_token, classify_name, yylex): Replace "parse_language"
2568         with method call.
2569         * ada-exp.y (find_primitive_type, type_char)
2570         (type_system_address): Replace "parse_language" with method call.
2571
2572 2019-04-04  Tom Tromey  <tom@tromey.com>
2573
2574         * rust-exp.y: Replace "parse_gdbarch" with method call.
2575         * parse.c (write_dollar_variable, insert_type_address_space):
2576         Replace "parse_gdbarch" with method call.
2577         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2578         call.
2579         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2580         call.
2581         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2582         "parse_gdbarch" with method call.
2583         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2584         with method call.
2585         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2586         "parse_gdbarch" with method call.
2587         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2588         "parse_gdbarch" with method call.
2589         * c-exp.y (parse_type, parse_number, classify_name): Replace
2590         "parse_gdbarch" with method call.
2591         * ada-lex.l: Replace "parse_gdbarch" with method call.
2592         * ada-exp.y (parse_type, find_primitive_type, type_char)
2593         (type_system_address): Replace "parse_gdbarch" with method call.
2594
2595 2019-04-04  Tom Tromey  <tom@tromey.com>
2596
2597         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2598         * stap-probe.c (stap_parse_argument): Update.
2599         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2600         initial_size parameter.
2601         * rust-exp.y (rust_lex_tests): Update.
2602         * parse.c (parser_state): Update.
2603         (parse_exp_in_context): Update.
2604         * parser-defs.h (struct parser_state) <parser_state>: Remove
2605         "initial_size" parameter.
2606
2607 2019-04-04  Tom Tromey  <tom@tromey.com>
2608
2609         * parser-defs.h (increase_expout_size): Don't declare.
2610         * parse.c (increase_expout_size): Now static.
2611
2612 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2613
2614         * gnu-nat.c (gnu_nat_target::wait): Fix
2615         target_waitstatus_to_string call.
2616
2617 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2618
2619         * eval.c (evaluate_subexp_standard): Handle internal functions
2620         during Fortran function call handling.
2621
2622 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2623
2624         * NEWS: Mention new internal functions.
2625         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2626         (read_base_type): Use dwarf2_init_complex_target_type.
2627         * value.c (creal_internal_fn): New function.
2628         (cimag_internal_fn): New function.
2629         (_initialize_values): Register new internal functions.
2630
2631 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2632
2633         * infrun.c (stop_all_threads): If debug_infrun, always
2634         trace the wait status after wait_one, using
2635         target_waitstatus_to_string and target_pid_to_str.
2636         (handle_inferior_event): Replace various trace of
2637         wait status kind by a single trace.
2638         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2639         wait status kind image by target_waitstatus_to_string.
2640         * target/waitstatus.c (target_waitstatus_to_string): Fix
2641         obsolete comment.
2642
2643 2019-04-01  Tom Tromey  <tromey@adacore.com>
2644
2645         PR symtab/23331:
2646         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2647
2648 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2649             Pedro Alves  <palves@redhat.com>
2650
2651         * top.c (quit_force): Call 'finalize_values'.
2652         * value.c (finalize_values): New function.
2653         * value.h (finalize_values): Declare.
2654
2655 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2656
2657         * NEWS: Announce $_gdb_major and $_gdb_minor.
2658
2659         * top.c (init_gdb_version_vars): New function.
2660         (gdb_init): Call init_gdb_version_vars.
2661
2662 2019-03-29  Tom Tromey  <tromey@adacore.com>
2663
2664         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2665         help text.  Remove dead code.
2666
2667 2019-03-29  Keith Seitz  <keiths@redhat.com>
2668
2669         From Siddhesh Poyarekar:
2670         * f-lang.h (f77_get_upperbound): Return LONGEST.
2671         (f77_get_lowerbound): Likewise.
2672         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2673         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2674         print them.
2675         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2676         plongest to format print it.
2677         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2678         (f77_get_upperbound): Likewise.
2679         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2680         LOWER_BOUND to LONGEST.
2681         (f77_create_arrayprint_offset_tbl): Likewise.
2682
2683 2019-03-29  Keith Seitz  <keiths@redhat.com>
2684
2685         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2686         %s/pulongest for TYPE_LENGTH instead of %d in format
2687         strings.
2688         * ada-typerint.c (ada_print_type): Likewise.
2689         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2690         * compile/compile-c-support.c (generate_register_struct): Likewise.
2691         * gdbtypes.c (recursive_dump_type): Likewise.
2692         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2693         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2694         instead of %d in format strings.
2695         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2696         to std::min to ULONGEST.
2697         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2698         instead of %d in format strings.
2699         * tracepoint.c (info_scope_command): Likewise.
2700         * typeprint.c (print_offset_data::update)
2701         (print_offset_data::finish): Likewise.
2702         * xtensa-tdep.c (xtensa_store_return_value)
2703         (xtensa_push_dummy_call): Likewise.
2704
2705 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2706
2707         * windows-nat.c (display_selector): Fixed format specifications
2708         for 64-bit Cygwin.
2709
2710 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2711
2712         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2713
2714 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2715
2716         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2717         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2718         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2719         (nios2_linux_init_abi): Install it.
2720
2721 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2722
2723         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2724
2725 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2726
2727         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2728
2729 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2730             Tom Tromey  <tromey@adacore.com>
2731
2732         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2733
2734 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2735
2736         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2737         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2738         method to compute the bounds of range types. Also print "[evaluated]"
2739         if the bounds' values come from a dynamic evaluation.
2740
2741 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2742
2743         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2744         whitespace when pretty printing is on.
2745
2746 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2747
2748         * ppc-linux-nat.c: Add include.
2749
2750 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2751
2752         * NEWS: Mention AArch64 Pointer Authentication.
2753
2754 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2755
2756         * arm-linux-nat.c: Add include.
2757
2758 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2759
2760         * source-cache.c (source_cache::get_source_lines): Re-read
2761         fullname after calling open_source_file.
2762
2763 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2764
2765         * NEWS: Mention TLS support for FreeBSD.
2766
2767 2019-03-25  Tom Tromey  <tromey@adacore.com>
2768
2769         * minsyms.c (BUNCH_SIZE): Update comment.
2770         (~minimal_symbol_reader): Remove old comment.
2771         (compact_minimal_symbols): Update comment.
2772         (minimal_symbol_reader::install): Remove old comment.  Update
2773         other comments.
2774
2775 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2776
2777         * s390-linux-nat.c: Add include.
2778
2779 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2780
2781         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2782         Call linux_get_hwcap.
2783         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2784         Likewise.
2785         (aarch64_linux_get_hwcap): Remove function.
2786         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2787         declaration.
2788         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2789         linux_get_hwcap.
2790         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2791         * linux-tdep.c (linux_get_hwcap): Add function.
2792         (linux_get_hwcap2): Likewise.
2793         * linux-tdep.h (linux_get_hwcap): Add declaration.
2794         (linux_get_hwcap2): Likewise.
2795         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
2796         (ppc_linux_get_hwcap2): Likewise.
2797         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
2798         linux_get_hwcap.
2799         (ppc_linux_nat_target::insert_watchpoint): Likewise.
2800         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
2801         (ppc_linux_nat_target::read_description): Likewise.
2802         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
2803         * s390-linux-nat.c: Likewise.
2804         * s390-linux-tdep.c (s390_core_read_description): Likewise.
2805
2806 2019-03-24  Tom Tromey  <tom@tromey.com>
2807
2808         * ada-lang.c (standard_lookup): Simplify initialization.
2809         (ada_lookup_symbol_nonlocal): Simplify return.
2810         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
2811         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
2812         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
2813         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
2814         initialization.
2815         * solib.c (solib_global_lookup): Simplify.
2816         * symtab.c (null_block_symbol): Remove.
2817         (symbol_cache_lookup): Simplify returns.
2818         (lookup_language_this): Simplify returns.
2819         (lookup_symbol_aux): Simplify return.
2820         (lookup_local_symbol): Simplify returns.
2821         (lookup_global_symbol_from_objfile): Simplify return.
2822         (lookup_symbol_in_objfile_symtabs)
2823         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
2824         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
2825         (lookup_static_symbol, lookup_global_symbol): Simplify return.
2826         * cp-namespace.c (cp_lookup_bare_symbol)
2827         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
2828         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
2829         (cp_lookup_nested_symbol): Don't use null_block_symbol.
2830         (cp_lookup_symbol_via_imports): Simplify initialization.
2831         (find_symbol_in_baseclass): Likewise.
2832         * symtab.h (null_block_symbol): Remove.
2833         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2834         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2835         (d_lookup_symbol_module): Likewise.
2836         (find_symbol_in_baseclass): Simplify initialization.
2837
2838 2019-03-24  Tom Tromey  <tom@tromey.com>
2839
2840         * expression.h: Don't include symtab.h.
2841         (struct block): Forward declare.
2842
2843 2019-03-24  Tom Tromey  <tom@tromey.com>
2844
2845         * c-exp.y (typebase): Remove casts.
2846         * gdbtypes.c (lookup_unsigned_typename, )
2847         (lookup_signed_typename): Remove cast.
2848         * eval.c (parse_to_comma_and_eval): Remove cast.
2849         * parse.c (write_dollar_variable): Remove cast.
2850         * block.h (struct block) <superblock>: Now const.
2851         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
2852         * psymtab.c (psym_map_matching_symbols): Make "block" const.
2853         (map_block): Make "block" const.
2854         * symfile.h (struct quick_symbol_functions)
2855         <map_matching_symbols>: Constify block argument to "callback".
2856         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
2857         const.
2858         (find_pc_sect_compunit_symtab): Make "b" const.
2859         (find_symbol_at_address): Likewise.
2860         (search_symbols): Likewise.
2861         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
2862         (dw2_debug_names_lookup_symbol): Likewise.
2863         (dw2_map_matching_symbols): Update.
2864         * p-valprint.c (pascal_val_print): Remove "block".
2865         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
2866         (aux_add_nonlocal_symbols): Make "block" const.
2867         (resolve_subexp): Remove cast.
2868         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
2869         const.
2870         (iterate_over_file_blocks): Likewise.
2871         * f-exp.y (%union) <bval>: Remove.
2872         * coffread.c (patch_opaque_types): Make "b" const.
2873         * spu-tdep.c (spu_catch_start): Make "block" const.
2874         * c-valprint.c (print_unpacked_pointer): Remove "block".
2875         * symmisc.c (dump_symtab_1): Make "b" const.
2876         (block_depth): Make "block" const.
2877         * d-exp.y (%union) <bval>: Remove.
2878         * cp-support.h (cp_lookup_rtti_type): Update.
2879         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
2880         * psymtab.c (psym_lookup_symbol): Make "block" const.
2881         (maintenance_check_psymtabs): Make "b" const.
2882         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
2883         (enumerate_locals, enumerate_args): Update.
2884         * python/py-symtab.c (stpy_global_block): Make "block" const.
2885         (stpy_static_block): Likewise.
2886         * inline-frame.c (block_starting_point_at): Make "new_block"
2887         const.
2888         * block.c (find_block_in_blockvector): Make return type const.
2889         (blockvector_for_pc_sect): Make "b" const.
2890         (find_block_in_blockvector): Make "b" const.
2891
2892 2019-03-23  Tom Tromey  <tom@tromey.com>
2893
2894         * varobj.c (varobj_create): Update.
2895         * symfile.c (clear_symtab_users): Don't reset innermost_block.
2896         * printcmd.c (display_command, do_one_display): Don't reset
2897         innermost_block.
2898         * parser-defs.h (enum innermost_block_tracker_type): Move to
2899         expression.h.
2900         (innermost_block): Update comment.
2901         * parse.c (parse_exp_1): Add tracker_types parameter.
2902         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
2903         tracker_types parameter.  Reset innermost_block.
2904         (parse_exp_in_context): Remove.
2905         (parse_expression_for_completion): Update.
2906         * objfiles.c (~objfile): Don't reset expression_context_block or
2907         innermost_block.
2908         * expression.h (enum innermost_block_tracker_type): Move from
2909         parser-defs.h.
2910         (parse_exp_1): Add tracker_types parameter.
2911         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
2912         reset innermost_block.
2913
2914 2019-03-23  Tom Tromey  <tom@tromey.com>
2915
2916         * objfiles.h: Include bcache.h.
2917
2918 2019-03-23  Tom Tromey  <tom@tromey.com>
2919
2920         * linespec.c (get_current_search_block): Use
2921         scoped_restore_current_language.
2922         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
2923
2924 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2925             Jiong Wang  <jiong.wang@arm.com>
2926
2927         * aarch64-linux-tdep.c
2928         (aarch64_linux_iterate_over_regset_sections): Check for pauth
2929         section.
2930         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
2931
2932 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2933             Jiong Wang  <jiong.wang@arm.com>
2934
2935         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
2936         instructions.
2937         (aarch64_analyze_prologue_test): Add PACIASP test.
2938         (aarch64_prologue_prev_register): Unmask PC value.
2939
2940 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2941             Jiong Wang  <jiong.wang@arm.com>
2942
2943         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
2944         (aarch64_dwarf2_prev_register): Unmask PC value.
2945         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
2946         (aarch64_execute_dwarf_cfa_vendor_op): Check for
2947         DW_CFA_AARCH64_negate_ra_state.
2948         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
2949
2950 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2951             Jiong Wang  <jiong.wang@arm.com>
2952
2953         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
2954         registers.
2955         (aarch64_pseudo_register_name): Likewise.
2956         (aarch64_pseudo_register_type): Likewise.
2957         (aarch64_pseudo_register_reggroup_p): Likewise.
2958         (aarch64_gdbarch_init): Add pauth registers.
2959         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
2960         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
2961         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
2962         (struct gdbarch_tdep): Add regnum for ra_state.
2963
2964 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2965             Jiong Wang  <jiong.wang@arm.com>
2966
2967         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
2968
2969 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2970             Jiong Wang  <jiong.wang@arm.com>
2971
2972         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
2973         function.
2974         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
2975         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
2976         (aarch64_gdbarch_init): Add puth registers.
2977         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
2978         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
2979         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
2980
2981 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2982             Jiong Wang  <jiong.wang@arm.com>
2983
2984         * aarch64-linux-nat.c
2985         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
2986         * aarch64-linux-tdep.c
2987         (aarch64_linux_core_read_description): Likewise.
2988         (aarch64_linux_get_hwcap): New function.
2989         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
2990         (aarch64_linux_get_hwcap): New declaration.
2991
2992 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2993             Jiong Wang  <jiong.wang@arm.com>
2994
2995         * aarch64-linux-nat.c
2996         (aarch64_linux_nat_target::read_description): Add pauth param.
2997         * aarch64-linux-tdep.c
2998         (aarch64_linux_core_read_description): Likewise.
2999         * aarch64-tdep.c (struct target_desc): Add in pauth.
3000         (aarch64_read_description): Add pauth param.
3001         (aarch64_gdbarch_init): Likewise.
3002         * aarch64-tdep.h (aarch64_read_description): Likewise.
3003         * arch/aarch64.c (aarch64_create_target_description): Likewise.
3004         * arch/aarch64.h (aarch64_create_target_description): Likewise.
3005         * features/Makefile: Add new files.
3006         * features/aarch64-pauth.c: New file.
3007         * features/aarch64-pauth.xml: New file.
3008
3009 2019-03-20  Tom Tromey  <tromey@adacore.com>
3010
3011         * infrun.c (handle_inferior_event): Rename from
3012         handle_inferior_event_1.  Create a scoped_value_mark.
3013         (handle_inferior_event): Remove.
3014
3015 2019-03-19  Tom Tromey  <tromey@adacore.com>
3016
3017         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
3018         * infrun.h (print_stop_event): Add "displays" parameter.
3019         * infrun.c (print_stop_event): Add "displays" parameter.
3020
3021 2019-03-19  Pedro Alves  <palves@redhat.com>
3022
3023         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
3024         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
3025         to -1.  Fix TABs vs spaces.
3026         (tui_ui_out::tui_ui_out): Don't initialize fields here.
3027         * tui/tui-out.h (tui_ui_out) Add intro comments.
3028         <m_line, m_start_of_line>: In-class initialize, and add describing
3029         comment.
3030
3031 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
3032
3033         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
3034         variable names.
3035         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
3036
3037 2019-03-18  Pedro Alves  <palves@redhat.com>
3038             Eli Zaretskii <eliz@gnu.org>
3039
3040         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
3041         m_line and m_start_of_line.
3042
3043 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
3044
3045         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
3046         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
3047         it returns a newline.  This fixes a regression in TU mode, whereby
3048         the next line is output on the same screen line as the user input.
3049
3050 2019-03-18  Tom Tromey  <tromey@adacore.com>
3051
3052         * minsyms.c (minimal_symbol_reader::install): Remove call to
3053         obstack_blank.
3054
3055 2019-03-18  Pedro Alves  <palves@redhat.com>
3056
3057         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
3058         New globals.
3059         (apply_style): New, factored out from ...
3060         (apply_ansi_escape): ... this.  Handle reverse video mode.
3061         (tui_set_reverse_mode): New function.
3062         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
3063         * tui/tui-winsource.c (tui_show_source_line): Use
3064         tui_set_reverse_mode instead of setting A_STANDOUT.
3065         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
3066         New setter methods.
3067
3068 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
3069
3070         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
3071         Handle tabs.
3072
3073 2019-03-18  Tom Tromey  <tromey@adacore.com>
3074
3075         * ada-lang.c (empty_array): Add "high" parameter.
3076         (ada_evaluate_subexp): Update.
3077
3078 2019-03-17  Sergei Trofimovich <siarheit@google.com>
3079
3080         * unittests/string_view-selftests.c: Define
3081         _initialize_string_view_selftests unconditionally.
3082
3083 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3084
3085         PR gdb/24350
3086         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
3087
3088 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3089
3090         PR gdb/24351
3091         * windows-nat.c (display_selector): Fix format specifiers.
3092
3093 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
3094
3095         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
3096         tui_refill_source_window instead of tui_refresh_win, to update the
3097         current execution line.  This fixes redisplay of the current line
3098         when stepping through the code with "next" or "step".
3099
3100 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3101
3102         * source-cache.c (source_cache::get_source_lines): Call
3103         find_source_lines to initialize s->nlines.  This fixes vertical
3104         scrolling of TUI source window when the DOWN arrow is pressed.
3105
3106 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3107
3108         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
3109         linux-thread-db.c (_initialize_thread_db): Likewise.
3110
3111 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3112
3113         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
3114         wclrtoeol in tui_show_source_line".  This reverts changes made in
3115         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
3116
3117 2019-03-15  Tom Tromey  <tom@tromey.com>
3118
3119         * symtab.h (struct minimal_symbol): Derive from
3120         general_symbol_info.
3121         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
3122         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
3123         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
3124         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
3125         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
3126         (MSYMBOL_SEARCH_NAME): Update.
3127         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
3128         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
3129         * minsyms.c (minimal_symbol_reader::record_full): Update.
3130
3131 2019-03-15  Tom Tromey  <tom@tromey.com>
3132
3133         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
3134
3135 2019-03-15  Tom Tromey  <tom@tromey.com>
3136
3137         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
3138         unique_xmalloc_ptr.
3139         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
3140         Update.
3141         * minsyms.c (lookup_minimal_symbol_by_pc_section)
3142         (build_minimal_symbol_hash_tables)
3143         (minimal_symbol_reader::install): Update.
3144
3145 2019-03-15  Tom Tromey  <tom@tromey.com>
3146
3147         * symtab.c (create_demangled_names_hash): Update.
3148         (symbol_set_names): Update.
3149         * objfiles.h (struct objfile_per_bfd_storage)
3150         <demangled_names_hash>: Now an htab_up.
3151         * objfiles.c (objfile_per_bfd_storage): Simplify.
3152
3153 2019-03-15  Tom Tromey  <tom@tromey.com>
3154
3155         * objfiles.h (struct objfile_per_bfd_storage): Declare
3156         destructor.
3157         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
3158         New.
3159         (get_objfile_bfd_data): Use new.  Don't initialize
3160         language_of_main.
3161         (free_objfile_per_bfd_storage): Remove.
3162         (objfile_bfd_data_free, objfile::~objfile): Use delete.
3163
3164 2019-03-15  Tom Tromey  <tom@tromey.com>
3165
3166         * symfile.c (reread_symbols): Update.
3167         * objfiles.c (objfile::objfile): Update.
3168         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
3169         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
3170         comment.
3171         (minimal_symbol_reader::install): Update.
3172         (terminate_minimal_symbol_table): Remove.
3173         * jit.c (jit_object_close_impl): Update.
3174
3175 2019-03-15  Tom Tromey  <tom@tromey.com>
3176
3177         * minsyms.c (minimal_symbol_reader::record_full): Remove some
3178         initializations.
3179
3180 2019-03-15  Tom Tromey  <tom@tromey.com>
3181
3182         * objfiles.h (struct objfile_per_bfd_storage)
3183         <demangled_hash_languages>: Now a bitset.
3184         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
3185         (lookup_minimal_symbol): Update.
3186
3187 2019-03-15  Tom Tromey  <tom@tromey.com>
3188
3189         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
3190         Don't return the symbol.
3191         * coffread.c (record_minimal_symbol): Use record_full.
3192
3193 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
3194
3195         The MS-Windows port of ncurses fails to switch to a color pair if
3196         one or both of the colors are the implicit default colors.  This
3197         change records the default colors when TUI is initialized, and
3198         then specifies them explicitly when a color pair uses the default
3199         colors.  This allows color styling in TUI mode on MS-Windows.
3200
3201         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
3202         ncurses_norm_attr.
3203         (tui_initialize_io) [__MINGW32__]: Record the default terminal
3204         colors in ncurses_norm_attr.
3205         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
3206         "none", replace it with the default color recorded in
3207         ncurses_norm_attr.
3208
3209 2019-03-14  Tom Tromey  <tromey@adacore.com>
3210
3211         * source-cache.h (class source_cache) <get_source_lines>: Return
3212         std::string.
3213         * source-cache.c (source_cache::extract_lines): Handle case where
3214         first_pos==npos.  Return std::string.
3215         (source_cache::get_source_lines): Update.
3216
3217 2019-03-14  Tom Tromey  <tromey@adacore.com>
3218
3219         * NEWS: Add item for "style sources" commands.
3220         * source-cache.c (source_cache::get_source_lines): Check
3221         source_styling.
3222         * cli/cli-style.c (source_styling): New global.
3223         (_initialize_cli_style): Add "style sources" commands.
3224         (show_style_sources): New function.
3225         * cli/cli-style.h (source_styling): Declare.
3226
3227 2019-03-14  Pedro Alves  <palves@redhat.com>
3228             Tom Tromey  <tromey@adacore.com>
3229
3230         * tui/tui-winsource.h (tui_refill_source_window): Declare.
3231         * tui/tui-winsource.c (tui_refill_source_window): New function,
3232         from...
3233         (tui_horizontal_source_scroll): ... here.  Move some logic.
3234         * cli/cli-style.c (set_style_enabled): Notify new observable.
3235         * tui/tui-hooks.c (tui_redisplay_source): New function.
3236         (tui_attach_detach_observers): Attach or detach
3237         tui_redisplay_source.
3238         * observable.h (source_styling_changed): New observable.
3239         * observable.c: Define source_styling_changed observable.
3240
3241 2019-03-13  Tom Tromey  <tromey@adacore.com>
3242
3243         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
3244         (i386_gnu_nat_target::store_registers): Update.
3245         * target-debug.h (target_debug_print_std_string): New macro.
3246         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3247         * windows-tdep.c (display_one_tib): Update.
3248         * tui/tui-stack.c (tui_make_status_line): Update.
3249         * top.c (print_inferior_quit_action): Update.
3250         * thread.c (thr_try_catch_cmd): Update.
3251         (add_thread_with_info): Update.
3252         (thread_target_id_str): Update.
3253         (thr_try_catch_cmd): Update.
3254         (thread_command): Update.
3255         (thread_find_command): Update.
3256         * record-btrace.c (record_btrace_target::info_record)
3257         (record_btrace_resume_thread, record_btrace_target::resume)
3258         (record_btrace_cancel_resume, record_btrace_step_thread)
3259         (record_btrace_target::wait, record_btrace_target::wait)
3260         (record_btrace_target::wait, record_btrace_target::stop): Update.
3261         * progspace.c (print_program_space): Update.
3262         * process-stratum-target.c
3263         (process_stratum_target::thread_address_space): Update.
3264         * linux-fork.c (linux_fork_mourn_inferior)
3265         (detach_checkpoint_command, info_checkpoints_command)
3266         (linux_fork_context): Update.
3267         (linux_fork_detach): Update.
3268         (class scoped_switch_fork_info): Update.
3269         (delete_checkpoint_command): Update.
3270         * infrun.c (follow_fork_inferior): Update.
3271         (follow_fork_inferior): Update.
3272         (proceed_after_vfork_done): Update.
3273         (handle_vfork_child_exec_or_exit): Update.
3274         (follow_exec): Update.
3275         (displaced_step_prepare_throw): Update.
3276         (displaced_step_restore): Update.
3277         (start_step_over): Update.
3278         (resume_1): Update.
3279         (clear_proceed_status_thread): Update.
3280         (proceed): Update.
3281         (print_target_wait_results): Update.
3282         (do_target_wait): Update.
3283         (context_switch): Update.
3284         (stop_all_threads): Update.
3285         (restart_threads): Update.
3286         (finish_step_over): Update.
3287         (handle_signal_stop): Update.
3288         (switch_back_to_stepped_thread): Update.
3289         (keep_going_pass_signal): Update.
3290         (print_exited_reason): Update.
3291         (normal_stop): Update.
3292         * inferior.c (inferior_pid_to_str): Change return type.
3293         (print_selected_inferior): Update.
3294         (add_inferior): Update.
3295         (detach_inferior): Update.
3296         * dummy-frame.c (fprint_dummy_frames): Update.
3297         * dcache.c (dcache_info_1): Update.
3298         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
3299         (btrace_fetch, btrace_clear): Update.
3300         * linux-tdep.c (linux_core_pid_to_str): Change return type.
3301         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
3302         type.
3303         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
3304         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
3305         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
3306         * gdbarch.c, gdbarch.h: Rebuild.
3307         * gdbarch.sh (core_pid_to_str): Change return type.
3308         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
3309         return type.
3310         (windows_nat_target::pid_to_str): Change return type.
3311         (windows_delete_thread): Update.
3312         (windows_nat_target::attach): Update.
3313         (windows_nat_target::files_info): Update.
3314         * target-delegates.c: Rebuild.
3315         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
3316         return type.
3317         (sol_thread_target::pid_to_str): Change return type.
3318         * remote.c (class remote_target) <pid_to_str>: Change return
3319         type.
3320         (remote_target::pid_to_str): Change return type.
3321         (extended_remote_target::attach, remote_target::remote_stop_ns)
3322         (remote_target::remote_notif_remove_queued_reply)
3323         (remote_target::push_stop_reply, remote_target::disable_btrace):
3324         Update.
3325         (extended_remote_target::attach): Update.
3326         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
3327         type.
3328         (gdbsim_target::pid_to_str): Change return type.
3329         * ravenscar-thread.c (struct ravenscar_thread_target)
3330         <pid_to_str>: Change return type.
3331         (ravenscar_thread_target::pid_to_str): Change return type.
3332         * procfs.c (class procfs_target) <pid_to_str>: Change return
3333         type.
3334         (procfs_target::pid_to_str): Change return type.
3335         (procfs_target::attach): Update.
3336         (procfs_target::detach): Update.
3337         (procfs_target::fetch_registers): Update.
3338         (procfs_target::store_registers): Update.
3339         (procfs_target::wait): Update.
3340         (procfs_target::files_info): Update.
3341         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
3342         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
3343         return type.
3344         (nto_procfs_target::pid_to_str): Change return type.
3345         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
3346         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
3347         return type.
3348         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
3349         (exit_lwp): Update.
3350         (attach_proc_task_lwp_callback, get_detach_signal)
3351         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
3352         (linux_nat_target::resume, wait_lwp, stop_callback)
3353         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
3354         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
3355         (linux_nat_wait_1, resume_stopped_resumed_lwps)
3356         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
3357         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
3358         type.
3359         (inf_ptrace_target::attach): Update.
3360         (inf_ptrace_target::files_info): Update.
3361         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
3362         type.
3363         (go32_nat_target::pid_to_str): Change return type.
3364         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
3365         (gnu_nat_target::wait): Update.
3366         (gnu_nat_target::wait): Update.
3367         (gnu_nat_target::resume): Update.
3368         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
3369         (fbsd_nat_target::wait): Update.
3370         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
3371         type.
3372         (darwin_nat_target::attach): Update.
3373         * corelow.c (class core_target) <pid_to_str>: Change return type.
3374         (core_target::pid_to_str): Change return type.
3375         * target.c (normal_pid_to_str): Change return type.
3376         (default_pid_to_str): Likewise.
3377         (target_pid_to_str): Change return type.
3378         (target_translate_tls_address): Update.
3379         (target_announce_detach): Update.
3380         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
3381         return type.
3382         (bsd_uthread_target::pid_to_str): Change return type.
3383         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
3384         type.
3385         (bsd_kvm_target::pid_to_str): Change return type.
3386         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
3387         return type.
3388         (aix_thread_target::pid_to_str): Change return type.
3389         * target.h (struct target_ops) <pid_to_str>: Change return type.
3390         (target_pid_to_str, normal_pid_to_str): Likewise.
3391         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
3392         type.
3393         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
3394         type.
3395         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
3396         return type.
3397         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
3398         type.
3399         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
3400         type.
3401         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3402         return type.
3403
3404 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3405
3406         * NEWS: Mention that the new default MI version is 3.  Mention
3407         changes to the output of commands and events that deal with
3408         multi-location breakpoints.
3409         * breakpoint.c: Include "mi/mi-out.h".
3410         (print_one_breakpoint): Change output syntax if using MI version
3411         >= 3.
3412         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3413         New.
3414         (mi_multi_location_breakpoint_output_fixed): New.
3415         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3416         (mi_cmd_fix_multi_location_breakpoint_output): New.
3417         (mi_multi_location_breakpoint_output_fixed): New.
3418         * mi/mi-cmds.c (mi_cmds): Register command
3419         -fix-multi-location-breakpoint-output.
3420         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3421         interpreter "mi".
3422
3423 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3424
3425         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3426         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3427         instantiate mi_ui_out based on interpreter name.
3428         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3429         * mi/mi-main.c (mi_load_progress): Likewise.
3430
3431 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3432
3433         * NEWS: Combine separate "New targets" sections for 8.3.
3434
3435 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3436
3437         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3438         (ppcfbsd_init_abi): Install gdbarch
3439         "fetch_tls_load_module_address" and "get_thread_local_address"
3440         methods.
3441
3442 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3443
3444         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3445         (riscv_fbsd_init_abi): Install gdbarch
3446         "fetch_tls_load_module_address" and "get_thread_local_address"
3447         methods.
3448
3449 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3450
3451         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3452         (i386fbsd_init_abi): Install gdbarch
3453         "fetch_tls_load_module_address" and "get_thread_local_address"
3454         methods.
3455
3456 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3457
3458         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3459         (amd64fbsd_init_abi): Install gdbarch
3460         "fetch_tls_load_module_address" and "get_thread_local_address"
3461         methods.
3462
3463 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3464
3465         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3466         (struct fbsd_pspace_data): New type.
3467         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3468         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3469         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3470         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3471         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3472
3473 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3474
3475         * gdbtypes.c (lookup_struct_elt): New function.
3476         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3477         * gdbtypes.h (struct struct_elt): New type.
3478         (lookup_struct_elt): New prototype.
3479
3480 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3481
3482         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3483         remove disabled code block.
3484
3485 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3486
3487         * gdbarch.sh (get_thread_local_address): New method.
3488         * gdbarch.h, gdbarch.c: Regenerate.
3489         * target.c (target_translate_tls_address): Use
3490         gdbarch_get_thread_local_address if present instead of
3491         target::get_thread_local_address.
3492
3493 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3494
3495         * target.h (target::get_thread_local_address): Update comment.
3496
3497 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3498
3499         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3500         objfile->separate_debug_objfile_backlink if not NULL.
3501
3502 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3503
3504         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3505         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3506         (amd64bsd_store_inferior_registers): Likewise.
3507         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3508         Enable segment base registers.
3509         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3510         PT_GETFSBASE and PT_GETGSBASE.
3511         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3512         PT_SETGSBASE.
3513         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3514         segment base registers.
3515         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3516
3517 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3518
3519         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3520         Update calls to i386_target_description to add 'segments'
3521         parameter.
3522         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3523         add segment base registers.
3524         * arch/i386.c (i386_create_target_description): Add 'segments'
3525         parameter to enable segment base registers.
3526         * arch/i386.h (i386_create_target_description): Likewise.
3527         * features/i386/32bit-segments.xml: New file.
3528         * features/i386/32bit-segments.c: Generate.
3529         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3530         call to i386_target_description to add 'segments' parameter.
3531         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3532         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3533         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3534         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3535         if feature is present.
3536         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3537         Add 'segments' parameter to call to i386_target_description.
3538         (i386_target_description): Add 'segments' parameter to enable
3539         segment base registers.
3540         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3541         to call to i386_target_description.
3542         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3543         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3544         Define I386_NUM_REGS.
3545         (i386_target_description): Add 'segments' parameter to enable
3546         segment base registers.
3547
3548 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3549
3550         PR/24325
3551         * source-cache.c: #undef open and close, to avoid unresolved
3552         externals during linking.
3553
3554 2019-03-12  Tom Tromey  <tromey@adacore.com>
3555
3556         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3557         const.  Add initializers.
3558         (_initialize_remote): Don't initialize ptid globals.
3559
3560 2019-03-12  Pedro Alves  <palves@redhat.com>
3561
3562         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3563
3564 2019-03-12  Pedro Alves  <palves@redhat.com>
3565
3566         * cp-name-parser.y (main): Remove unused 'len' variable.
3567
3568 2019-03-12  Tom Tromey  <tromey@adacore.com>
3569
3570         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3571         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3572
3573 2019-03-12  Tom Tromey  <tromey@adacore.com>
3574
3575         * linux-nat.c (iterate_over_lwps): Update.
3576         (stop_callback): Remove parameter.
3577         (stop_wait_callback, detach_callback, resume_set_callback)
3578         (select_singlestep_lwp_callback, set_ignore_sigint)
3579         (status_callback, resumed_callback, resume_clear_callback)
3580         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3581         data parameter.
3582         (linux_nat_target::detach, linux_nat_target::resume)
3583         (linux_stop_and_wait_all_lwps, select_event_lwp)
3584         (linux_nat_filter_event, linux_nat_wait_1)
3585         (linux_nat_target::kill, linux_nat_target::stop)
3586         (linux_nat_target::stop): Update.
3587         (linux_nat_resume_callback): Change type.
3588         (resume_stopped_resumed_lwps, count_events_callback)
3589         (select_event_lwp_callback): Likewise.
3590         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3591         * arm-linux-nat.c (struct update_registers_data): Remove.
3592         (update_registers_callback): Change type.
3593         (arm_linux_insert_hw_breakpoint1): Update.
3594         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3595         parameter.
3596         (x86_linux_dr_set_addr): Update.
3597         (x86_linux_dr_set_control): Update.
3598         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3599         (iterate_over_lwps): Use gdb::function_view.
3600         * nat/aarch64-linux-hw-point.c (struct
3601         aarch64_dr_update_callback_param): Remove.
3602         (debug_reg_change_callback): Change type.
3603         (aarch64_notify_debug_reg_change): Update.
3604         * s390-linux-nat.c (s390_refresh_per_info): Update.
3605
3606 2019-03-11  Tom Tromey  <tromey@adacore.com>
3607
3608         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3609         redundant assignment to "this_cu".
3610
3611 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3612
3613         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3614
3615 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3616
3617         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3618         from...
3619         (rank_one_type): ... this.
3620
3621 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3622
3623         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3624         from...
3625         (rank_one_type): ... this.
3626
3627 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3628
3629         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3630         from...
3631         (rank_one_type): ... this.
3632
3633 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3634
3635         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3636         from...
3637         (rank_one_type): ... this.
3638
3639 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3640
3641         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3642         from...
3643         (rank_one_type): ... this.
3644
3645 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3646
3647         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3648         from...
3649         (rank_one_type): ... this.
3650
3651 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3652
3653         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3654         from...
3655         (rank_one_type): ... this.
3656
3657 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3658
3659         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3660         from...
3661         (rank_one_type): ... this.
3662
3663 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3664
3665         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3666         from...
3667         (rank_one_type): ... this.
3668
3669 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3670
3671         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3672         from...
3673         (rank_one_type): ... this.
3674
3675 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3676
3677         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3678         from...
3679         (rank_one_type): ... this.
3680
3681 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3682
3683         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3684         from...
3685         (rank_one_type): ... this.
3686
3687 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3688
3689         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3690         inferior-events' shows the example events.
3691
3692 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3693
3694         Support styling on native MS-Windows console
3695
3696         PR/24315
3697         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3698         on MS-Windows if $TERM is not defined.
3699
3700         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3701
3702         * posix-hdep.c (gdb_console_fputs):
3703         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3704         functions.
3705         * ui-file.h (gdb_console_fputs): Add prototype.
3706
3707         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3708         back to fputs only if the former returns zero.
3709
3710 2019-03-07  Tom Tromey  <tom@tromey.com>
3711
3712         * symmisc.c (print_symbol_bcache_statistics): Update.
3713         (print_objfile_statistics): Update.
3714         * symfile.c (allocate_symtab): Update.
3715         * stabsread.c: Don't include bcache.h.
3716         * psymtab.h (struct psymbol_bcache): Don't declare.
3717         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3718         (psymbol_bcache_init, psymbol_bcache_free)
3719         (psymbol_bcache_get_bcache): Don't declare.
3720         * psymtab.c (struct psymbol_bcache): Remove.
3721         (psymtab_storage::psymtab_storage): Update.
3722         (psymtab_storage::~psymtab_storage): Update.
3723         (psymbol_bcache_init, psymbol_bcache_free)
3724         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3725         (add_psymbol_to_bcache): Update.
3726         (allocate_psymtab): Update.
3727         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3728         macro_cache>: No longer pointers.
3729         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3730         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3731         * macrotab.c (macro_bcache): Update.
3732         * macroexp.c: Don't include bcache.h.
3733         * gdbtypes.c (check_types_worklist): Update.
3734         (types_deeply_equal): Remove TRY/CATCH.  Update.
3735         * elfread.c (elf_symtab_read): Update.
3736         * dwarf2read.c: Don't include bcache.h.
3737         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3738         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3739         (print_bcache_statistics, bcache_memory_used): Don't declare.
3740         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3741         methods.  Rename all data members.
3742         * bcache.c (struct bcache): Move to bcache.h.
3743         (bcache::expand_hash_table): Rename from expand_hash_table.
3744         (bcache): Remove.
3745         (bcache::insert): Rename from bcache_full.
3746         (bcache::compare): Rename from bcache_compare.
3747         (bcache_xmalloc): Remove.
3748         (bcache::~bcache): Rename from bcache_xfree.
3749         (bcache::print_statistics): Rename from print_bcache_statistics.
3750         (bcache::memory_used): Rename from bcache_memory_used.
3751
3752 2019-03-07  Pedro Alves  <palves@redhat.com>
3753
3754         * infrun.c (normal_stop): Also check for
3755         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3756
3757 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3758
3759         * f-lang.c (value_from_host_double): Moved to...
3760         * value.c (value_from_host_double): ...here.
3761         * value.h (value_from_host_double): Declare.
3762         * guile/scm-math.c (vlscm_convert_typed_number): Use
3763         value_from_host_double.
3764         (vlscm_convert_number): Likewise.
3765         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3766         * python/py-value.c (convert_value_from_python): Likewise.
3767
3768 2019-03-06  Tom Tromey  <tom@tromey.com>
3769
3770         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3771
3772 2019-03-06  Tom Tromey  <tom@tromey.com>
3773
3774         * utils.h (free_current_contents): Don't declare.
3775         * utils.c (free_current_contents): Remove.
3776
3777 2019-03-06  Tom Tromey  <tom@tromey.com>
3778
3779         * top.c (quit_force): Update.
3780         * main.c (captured_command_loop): Update.
3781         * common/new-op.c (operator new): Update.
3782         * common/common-exceptions.c (struct catcher)
3783         <save_cleanup_chain>: Remove member.
3784         (exceptions_state_mc_init): Update.
3785         (exception_try_scope_entry): Return nullptr.
3786         (exception_try_scope_exit, exception_rethrow)
3787         (throw_exception_sjlj, throw_exception_cxx): Update.
3788         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3789         (all_cleanups, do_cleanups, discard_cleanups)
3790         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3791         (restore_cleanups, restore_final_cleanups): Don't declare.
3792         (do_final_cleanups): Remove parameter.
3793         * common/cleanups.c (cleanup_chain, make_cleanup)
3794         (make_cleanup_dtor, all_cleanups, do_cleanups)
3795         (discard_my_cleanups, discard_cleanups)
3796         (discard_final_cleanups, save_my_cleanups, save_cleanups)
3797         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
3798         (null_cleanup): Remove.
3799         (do_final_cleanups): Remove parameter.
3800
3801 2019-03-06  Tom Tromey  <tom@tromey.com>
3802
3803         * remote.c (remote_target::remote_parse_stop_reply): Use
3804         unique_xmalloc_ptr.
3805
3806 2019-03-06  Tom Tromey  <tom@tromey.com>
3807
3808         * stabsread.c (struct stabs_field_info): Rename from field_info.
3809         <list, fnlist>: Add initializers.
3810         <obstack>: New member.
3811         (read_member_functions, read_struct_fields, read_baseclasses):
3812         Allocate on obstack.  Don't use cleanups.
3813         (read_one_struct_field, read_member_functions, read_struct_fields)
3814         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
3815         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
3816         (read_struct_type): Update.
3817
3818 2019-03-06  Tom Tromey  <tom@tromey.com>
3819
3820         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
3821         * common/filestuff.h (make_cleanup_close): Don't declare.
3822         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
3823         Remove.
3824
3825 2019-03-06  Tom Tromey  <tom@tromey.com>
3826
3827         * solib-aix.c: Use make_scope_exit.
3828
3829 2019-03-06  Tom Tromey  <tom@tromey.com>
3830
3831         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
3832         Use make_scope_exit.
3833
3834 2019-03-06  Tom Tromey  <tom@tromey.com>
3835
3836         * solib-svr4.c (disable_probes_interface): Remove parameter.
3837         (svr4_handle_solib_event): Use make_scope_exit.
3838
3839 2019-03-06  Tom Tromey  <tom@tromey.com>
3840
3841         * remote.c (struct stop_reply_deleter): Remove.
3842         (stop_reply_up): Update.
3843         (struct stop_reply): Derive from notif_event.  Don't typedef.
3844         <regcache>: Now a std::vector.
3845         (stop_reply_xfree): Remove.
3846         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
3847         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
3848         (remote_target::discard_pending_stop_replies): Use delete.
3849         (remote_target::remote_parse_stop_reply): Update.
3850         (remote_target::process_stop_reply): Update.
3851         * remote-notif.h (struct notif_event): Add virtual destructor.
3852         Remove "dtr" member.
3853         (struct notif_client) <alloc_event>: Return a unique_ptr.
3854         (notif_event_xfree): Don't declare.
3855         (notif_event_up): New typedef.
3856         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
3857         (notif_event_xfree, do_notif_event_xfree): Remove.
3858         (remote_notif_state_xfree): Update.
3859
3860 2019-03-06  Tom Tromey  <tom@tromey.com>
3861
3862         * infrun.c (displaced_step_clear_cleanup): Now a
3863         forward_scope_exit type.
3864         (displaced_step_prepare_throw): Update.
3865         (displaced_step_fixup): Update.
3866
3867 2019-03-06  Tom Tromey  <tom@tromey.com>
3868
3869         * inferior.h (class inferior): Update comment.
3870         * gdbthread.h (class thread_info): Update comment.
3871
3872 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
3873             Tom Tromey  <tom@tromey.com>
3874
3875         * stabsread.h (struct stab_section_list): Remove.
3876         (coffstab_build_psymtabs): Update.
3877         * dbxread.c (symbuf_sections): Now a std::vector.
3878         (sect_idx): New global.
3879         (fill_symbuf): Update.
3880         (coffstab_build_psymtabs): Change type of stabsects parameter.
3881         Update.
3882         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
3883         std::vector.
3884         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
3885         (coff_locate_sections): Update.
3886         (coff_symfile_read): Remove cleanups.  Update.
3887         (init_stringtab): Add storage parameter.
3888         (free_stringtab, free_stringtab_cleanup): Remove.
3889         (init_lineno): Add storage parameter.
3890         (free_linetab, free_linetab_cleanup): Remove.
3891
3892 2019-03-06  Pedro Alves  <palves@redhat.com>
3893
3894         * linux-fork.c (fork_info::clobber_regs): Delete.
3895         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
3896         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
3897         comment.  Adjust.
3898         (scoped_switch_fork_info::scoped_switch_fork_info)
3899         (checkpoint_command, linux_fork_context): Adjust
3900         fork_save_infrun_state calls.
3901
3902 2019-03-06  Pedro Alves  <palves@redhat.com>
3903
3904         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
3905         (inf_has_multiple_threads): Return 'bool' and rewrite using
3906         inferior_info::threads().
3907
3908 2019-03-06  Pedro Alves  <palves@redhat.com>
3909
3910         * linux-fork.c: Include <list>.
3911         (fork_list): Now a std::list instance.
3912         (fork_info): Add ctor, dtor, and in-class initialize all fields.
3913         (forks_exist_p, find_last_fork): Adjust.
3914         (new_fork): Delete.
3915         (one_fork_p): New.
3916         (add_fork): Adjust.
3917         (free_fork): Delete, folded into fork_info::~fork_info().
3918         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
3919         Adjust.
3920         (init_fork_list): Delete.
3921         (linux_fork_killall, linux_fork_mourn_inferior)
3922         (linux_fork_detach, info_checkpoints_command): Adjust.
3923         (_initialize_linux_fork): No longer call init_fork_list.
3924
3925 2019-03-06  Pedro Alves  <palves@redhat.com>
3926
3927         * linux-fork.c (new_fork): New, split out of ...
3928         (add_fork): ... this.  Return void.  Move "first fork" special
3929         case from here, to ...
3930         (checkpoint_command): ... here.
3931         * linux-linux.h (add_fork): Return void.
3932
3933 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3934
3935         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
3936
3937 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3938             Chris January  <chris.january@arm.com>
3939             David Lecomber  <david.lecomber@arm.com>
3940
3941         * f-exp.y: New token, UNOP_INTRINSIC.
3942         (exp): New pattern using UNOP_INTRINSIC token.
3943         (f77_keywords): Add 'abs' keyword.
3944         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
3945         (value_from_host_double): New function.
3946         (evaluate_subexp_f): Support UNOP_ABS.
3947
3948 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3949
3950         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
3951         types.
3952
3953 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3954
3955         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
3956         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
3957         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
3958
3959 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3960
3961         * f-exp.y (convert_to_kind_type): Handle more type kinds.
3962
3963 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3964             Chris January  <chris.january@arm.com>
3965
3966         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
3967         * f-exp.y: Define 'KIND' token.
3968         (exp): New pattern for KIND expressions.
3969         (ptype): Handle types with a kind extension.
3970         (direct_abs_decl): Extend to spot kind extensions.
3971         (f77_keywords): Add 'kind' to the list.
3972         (push_kind_type): New function.
3973         (convert_to_kind_type): New function.
3974         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
3975         * parse.c (operator_length_standard): Likewise.
3976         * parser-defs.h (enum type_pieces): Add tp_kind.
3977         * std-operator.def: Add UNOP_KIND.
3978
3979 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3980
3981         * f-exp.y (f_parse): Set yydebug.
3982
3983 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3984
3985         * f-lang.c (evaluate_subexp_f): New function.
3986         (exp_descriptor_f): New global.
3987         (f_language_defn): Use exp_descriptor_f instead of
3988         exp_descriptor_standard.
3989
3990 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3991
3992         * f-exp.y (struct token): Add comments.
3993         (dot_ops): Remove uppercase versions and the end marker.
3994         (f77_keywords): Likewise.
3995         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
3996         entries in the dot_ops array are case insensitive, and use
3997         strncasecmp to compare strings.  Also some whitespace cleanup in
3998         this area.  Similar for the f77_keywords array, except entries in
3999         this list might be case sensitive.
4000
4001 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4002
4003         * f-exp.y (struct f77_boolean_val): Add comments.
4004         (boolean_values): Remove uppercase versions, and end marker.
4005         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
4006         and use strncasecmp to achieve case insensitivity.  Additionally,
4007         perform whitespace cleanup around this code.
4008
4009 2019-03-06  Tom Tromey  <tromey@adacore.com>
4010
4011         * remote-sim.c (gdbsim_target_open): Use result of
4012         gdb_argv::release.
4013
4014 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
4015         Dirk Schubert  <dirk.schubert@arm.com>
4016         Chris January  <chris.january@arm.com>
4017
4018         * eval.c (evaluate_subexp_standard): Call Fortran argument
4019         wrapping logic.
4020         * f-lang.c (struct value): A value which can be passed into a
4021         Fortran function call.
4022         (fortran_argument_convert): Wrap Fortran arguments in a pointer
4023         where appropriate.
4024         (struct type): Value ready for a Fortran function call.
4025         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
4026         is needed.
4027         * f-lang.h (fortran_argument_convert): Declaration.
4028         (fortran_preserve_arg_pointer): Declaration.
4029         * infcall.c (value_arg_coerce): Call Fortran argument logic.
4030
4031 2019-03-05  Tom Tromey  <tromey@adacore.com>
4032
4033         * python/py-prettyprint.c (print_string_repr): Remove #if.
4034         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
4035
4036 2019-03-05  Tom Tromey  <tromey@adacore.com>
4037
4038         * target.c (the_dummy_target): Move later.  Change type to
4039         "dummy_target".
4040         (initialize_targets): Don't initialize the_dummy_target.
4041
4042 2019-03-05  Tom Tromey  <tromey@adacore.com>
4043
4044         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
4045         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
4046
4047 2019-03-05  Tom Tromey  <tromey@adacore.com>
4048
4049         * windows-nat.c (windows_nat_target::attach)
4050         (windows_nat_target::detach): Don't call gdb_flush.
4051         * valprint.c (generic_val_print, val_print, val_print_string):
4052         Don't call gdb_flush.
4053         * utils.c (defaulted_query): Don't call gdb_flush.
4054         * typeprint.c (print_type_scalar): Don't call gdb_flush.
4055         * target.c (target_announce_detach): Don't call gdb_flush.
4056         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
4057         * remote.c (extended_remote_target::attach): Don't call
4058         gdb_flush.
4059         * procfs.c (procfs_target::detach): Don't call gdb_flush.
4060         * printcmd.c (do_examine): Don't call gdb_flush.
4061         (info_display_command): Don't call gdb_flush.
4062         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
4063         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
4064         * memattr.c (info_mem_command): Don't call gdb_flush.
4065         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
4066         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
4067         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
4068         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
4069         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
4070         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
4071         (gnu_nat_target::detach): Don't call gdb_flush.
4072         * f-valprint.c (f_val_print): Don't call gdb_flush.
4073         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
4074         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
4075         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
4076         gdb_flush.
4077         * c-valprint.c (c_val_print): Don't call gdb_flush.
4078         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
4079
4080 2019-03-05  Tom Tromey  <tromey@adacore.com>
4081
4082         * varobj.c (update_dynamic_varobj_children): Update.
4083         (install_default_visualizer): Use reset, not release.
4084         * value.c (set_internalvar): Update.
4085         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
4086         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
4087         ATTRIBUTE_UNUSED_RESULT.
4088
4089 2019-03-05  Tom Tromey  <tromey@adacore.com>
4090
4091         * remote.c (class scoped_remote_fd) <release>: Add
4092         ATTRIBUTE_UNUSED_RESULT.
4093
4094 2019-03-05  Tom Tromey  <tromey@adacore.com>
4095
4096         * macroexp.c (struct macro_buffer) <release>: Add
4097         ATTRIBUTE_UNUSED_RESULT.
4098
4099 2019-03-05  Tom Tromey  <tromey@adacore.com>
4100
4101         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
4102         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
4103         ATTRIBUTE_UNUSED_RESULT.
4104
4105 2019-03-05  Tom Tromey  <tromey@adacore.com>
4106
4107         * common/scoped_fd.h (class scoped_fd) <release>: Add
4108         ATTRIBUTE_UNUSED_RESULT.
4109
4110 2019-03-05  Tom Tromey  <tromey@adacore.com>
4111
4112         * parser-defs.h (struct parser_state) <release>: Add
4113         ATTRIBUTE_UNUSED_RESULT.
4114
4115 2019-03-05  Tom Tromey  <tromey@adacore.com>
4116
4117         * utils.h (class gdb_argv) <release>: Add
4118         ATTRIBUTE_UNUSED_RESULT.
4119         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
4120
4121 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
4122
4123         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
4124         for-loop range, to avoid compiler warnings.
4125
4126         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
4127         avoid compiler warnings about unused variables.
4128
4129         * NEWS: Mention end of support for native debugging on MS-Windows
4130         before XP.
4131
4132         PR gdb/24292
4133         * common/netstuff.c:
4134         * gdbserver/gdbreplay.c
4135         * gdbserver/remote-utils.c:
4136         * ser-tcp.c:
4137         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
4138         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
4139         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
4140         'getaddrinfo' and 'freeaddrinfo' were not available before
4141         Windows XP, and mingw.org's MinGW headers by default define
4142         _WIN32_WINNT to 0x500.
4143
4144 2019-03-01  Gary Benson <gbenson@redhat.com>
4145
4146         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
4147
4148 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
4149             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4150
4151         PR gdb/8527
4152         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
4153         set_sigint_trap, clear_sigint_trap.
4154
4155 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4156
4157         * target.c (target_detach): Clear the regcache and the
4158         frame cache.
4159
4160 2019-02-27  Pedro Alves  <palves@redhat.com>
4161
4162         * utils.c (set_screen_size): When we cap the height/width sizes,
4163         tweak the corresponding command variable to show "unlimited":
4164
4165 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
4166             Pedro Alves  <palves@redhat.com>
4167
4168         * utils.c (set_screen_size): Reduce "infinite" rows and columns
4169         before calling rl_set_screen_size.
4170
4171 2019-02-27  Tom Tromey  <tromey@adacore.com>
4172
4173         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
4174         define.
4175         * python/py-value.c: Remove Python 2.4 workaround.
4176         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
4177         workaround.
4178         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
4179         Python 2.4 workaround.
4180         * python/python-internal.h: Remove Python 2.4 comment.
4181         (Py_ssize_t): Don't define.
4182         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
4183         (gdb_Py_DECREF): Remove Python 2.4 workaround.
4184         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
4185         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
4186         * python/python.c (do_start_initialization): Remove Python 2.4
4187         workaround.
4188         * python/py-prettyprint.c (class dummy_python_frame): Remove.
4189         (print_children): Remove Python 2.4 workaround.
4190         * python/py-inferior.c (buffer_procs): Remove Python 2.4
4191         workaround.
4192         (CHARBUFFERPROC_NAME): Remove.
4193         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
4194         Python 2.4 workaround.
4195
4196 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4197
4198         * NEWS: Note minimum Python version.
4199
4200 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4201
4202         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
4203         code from these functions.  Remove corresponding ifdefs.  Use
4204         Py_buffer_up instead of explicit calls to PyBuffer_Release.
4205         Remove gotos and target of gotos.
4206         (infpy_search_memory): Likewise.
4207
4208 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4209
4210         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
4211         (hppa_gdbarch_init): Don't register deleted functions with
4212         gdbarch.
4213
4214 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4215
4216         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
4217         (h8300_unwind_sp): Delete.
4218         (h8300_dummy_id): Delete.
4219         (h8300_gdbarch_init): Don't register deleted functions with
4220         gdbarch.
4221
4222 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4223
4224         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
4225         (ft32_unwind_pc): Delete.
4226         (ft32_unwind_sp): Delete.
4227         (ft32_gdbarch_init): Don't register deleted functions with
4228         gdbarch.
4229
4230 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4231
4232         * gdb/frv-tdep.c (frv_dummy_id): Delete.
4233         (frv_unwind_pc): Delete.
4234         (frv_unwind_sp): Delete.
4235         (frv_gdbarch_init): Don't register deleted functions with
4236         gdbarch.
4237
4238 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4239
4240         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
4241         (riscv_unwind_pc): Delete.
4242         (riscv_unwind_sp): Delete.
4243         (riscv_gdbarch_init): Don't register deleted functions with
4244         gdbarch.
4245
4246 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4247
4248         * gdb/csky-tdep.c (csky_dummy_id): Delete.
4249         (csky_unwind_pc): Delete.
4250         (csky_unwind_sp): Delete.
4251         (csky_gdbarch_init): Don't register deleted functions with
4252         gdbarch.
4253
4254 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4255
4256         * gdb/cris-tdep.c (cris_dummy_id): Delete.
4257         (cris_unwind_pc): Delete.
4258         (cris_unwind_sp): Delete.
4259         (cris_gdbarch_init): Don't register deleted functions with
4260         gdbarch.
4261
4262 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4263
4264         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
4265         (bfin_unwind_pc): Delete.
4266         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
4267
4268 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4269
4270         * gdb/arm-tdep.c (arm_dummy_id): Delete.
4271         (arm_unwind_pc): Delete.
4272         (arm_unwind_sp): Delete.
4273         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
4274
4275 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4276
4277         * gdb/arc-tdep.c (arc_dummy_id): Delete.
4278         (arc_unwind_pc): Delete.
4279         (arc_unwind_sp): Delete.
4280         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
4281
4282 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4283
4284         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
4285         (alpha_unwind_pc): Delete.
4286         (alpha_gdbarch_init): Don't register deleted functions with
4287         gdbarch.
4288
4289 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4290
4291         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
4292         (aarch64_unwind_pc): Delete.
4293         (aarch64_unwind_sp): Delete.
4294         (aarch64_gdbarch_init): Don't register deleted functions with
4295         gdbarch.
4296
4297 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4298
4299         * gdbtypes.c (type_align): Don't consider static members when
4300         computing structure alignment.
4301
4302 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4303
4304         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
4305         return 0 for other types.
4306         * arch-utils.c (default_type_align): Always return 0.
4307         * gdbarch.h: Regenerate.
4308         * gdbarch.sh (type_align): Extend comment.
4309         * gdbtypes.c (type_align): Add additional comments, always call
4310         gdbarch_type_align before applying the default rules.
4311         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
4312         generic code will then apply a suitable default.
4313         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
4314         types, return 0 for other types.
4315
4316 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4317
4318         * NEWS: Create a new section for the next release branch.
4319         Rename the section of the current branch, now that it has
4320         been cut.
4321
4322 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4323
4324         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
4325         * version.in: Bump version to 8.3.50.DATE-git.
4326
4327 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
4328
4329         * aix-thread.c (ptid_cmp): Remove unused variable.
4330         (get_signaled_thread): Likewise.
4331         (store_regs_user_thread): Likewise.
4332         (store_regs_kernel_thread): Likewise.
4333         (fetch_regs_kernel_thread): Remove shadowed variable.
4334
4335 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4336
4337         * features/riscv/32bit-cpu.xml: Add register numbers.
4338         * features/riscv/32bit-fpu.c: Regenerate.
4339         * features/riscv/32bit-fpu.xml: Add register numbers.
4340         * features/riscv/64bit-cpu.xml: Add register numbers.
4341         * features/riscv/64bit-fpu.c: Regenerate.
4342         * features/riscv/64bit-fpu.xml: Add register numbers.
4343
4344 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
4345
4346         * NEWS: Mention two argument form of gdb.Value constructor.
4347         * python/py-value.c (convert_buffer_and_type_to_value): New
4348         function.
4349         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
4350         Add support for handling an optional second argument.  Call
4351         convert_buffer_and_type_to_value as appropriate.
4352         * python/python-internal.h (Py_buffer_deleter): New struct.
4353         (Py_buffer_up): New typedef.
4354
4355 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
4356
4357         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
4358         instead of releasing ownership.
4359
4360 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
4361
4362         * dwarf2read.c (open_and_init_dwp_file): Call
4363         elf_numsections instead of bfd_count_sections to initialize
4364         dwp_file->num_sections.
4365
4366 2019-02-25  Tom Tromey  <tromey@adacore.com>
4367
4368         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
4369
4370 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4371
4372         * gcore.in: Add '--readnever' option when invoking GDB.
4373
4374 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4375
4376         * MAINTAINERS: Update my email address.
4377
4378 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4379
4380         * build-id.c (build_id_to_debug_bfd_1): New function.
4381         (build_id_to_debug_bfd): Look for separate debug file in
4382         sysroot.
4383
4384 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4385
4386         * gdbarch.sh: Update the copyright year range that is placed into
4387         generated files.
4388
4389 2019-02-22  Keith Seitz  <keiths@redhat.com>
4390
4391         PR symtab/23853
4392         * linespec.c (create_sals_line_offset): Search for the default
4393         symtab's filename instead of its fullname.
4394
4395 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4396
4397         * NEWS: Update style defaults.
4398
4399 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4400
4401         * main.c (captured_main_1): Disable styling in batch mode.
4402
4403 2019-02-20  Tom Tromey  <tom@tromey.com>
4404
4405         * symtab.c (symtab_symbol_info): Fix typos.
4406
4407 2019-02-20  Tom Tromey  <tromey@adacore.com>
4408
4409         * findcmd.c (_initialize_mem_search): Use upper case for
4410         metasyntactic variables.
4411
4412 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4413
4414         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4415         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4416
4417 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4418
4419         * top.h (source_file_name): Change to std::string.
4420         * top.c (source_file_name): Likewise.
4421         (command_line_input): Adjust.
4422         * cli/cli-script.c (script_from_file): Adjust.
4423
4424 2019-02-19  Tom Tromey  <tromey@adacore.com>
4425
4426         * ravenscar-thread.c
4427         (ravenscar_thread_target::update_thread_list): Don't call
4428         ada_build_task_list.
4429         * ada-lang.h (ada_build_task_list): Don't declare.
4430         * ada-tasks.c (struct ada_tasks_inferior_data)
4431         <task_list_valid_p>: Now bool.
4432         (read_known_tasks, ada_task_list_changed)
4433         (ada_tasks_invalidate_inferior_data): Update.
4434         (read_known_tasks_array): Return bool.
4435         (read_known_tasks_list): Likewise.
4436         (read_known_tasks): Return void.
4437         (ada_build_task_list): Now static.
4438
4439 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4440
4441         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4442         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4443
4444 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4445
4446         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4447         variant for ada_tasks_pspace_data_handle and
4448         ada_tasks_inferior_data_handle.
4449         (ada_tasks_pspace_data_cleanup): New function.
4450         (ada_tasks_inferior_data_cleanup): New function.
4451
4452 2019-02-17  Tom Tromey  <tom@tromey.com>
4453
4454         * macrotab.h (macro_source_fullname): Return a std::string.
4455         * macrotab.c (macro_include, check_for_redefinition)
4456         (macro_undef, macro_lookup_definition, foreach_macro)
4457         (foreach_macro_in_scope): Update.
4458         (macro_source_fullname): Return a std::string.
4459         * macrocmd.c (show_pp_source_pos): Update.
4460
4461 2019-02-17  Tom Tromey  <tom@tromey.com>
4462
4463         * macrocmd.c (show_pp_source_pos): Style the file names.
4464
4465 2019-02-17  Tom Tromey  <tom@tromey.com>
4466
4467         PR tui/24197:
4468         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4469
4470 2019-02-17  Tom Tromey  <tom@tromey.com>
4471
4472         * ada-lang.c (user_select_syms): Use filtered printing.
4473         * utils.c (wrap_style): New global.
4474         (desired_style): Remove.
4475         (emit_style_escape): Add stream parameter.
4476         (set_output_style, reset_terminal_style, prompt_for_continue):
4477         Update.
4478         (flush_wrap_buffer): Only flush gdb_stdout.
4479         (wrap_here): Set wrap_style.
4480         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4481         treat escape sequences as a character.  Change when wrap buffer is
4482         flushed.
4483         (fputs_styled): Do not set the output style when the default is
4484         requested.
4485         * ui-style.h (struct ui_file_style) <is_default>: New method.
4486         * source.c (print_source_lines_base): Emit escape sequences in one
4487         piece.
4488
4489 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4490
4491         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4492         integers and enumeration types.
4493
4494 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4495
4496         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4497         instead of lookup_symbol_in_language
4498         (do_exact_match): New function.
4499         (ada_get_symbol_name_matcher): Return do_exact_match when
4500         doing a verbatim match.
4501
4502 2019-02-15  Tom Tromey  <tromey@adacore.com>
4503
4504         * ravenscar-thread.c (ravenscar_thread_target::resume)
4505         (ravenscar_thread_target::wait): Special case wildcard requests.
4506
4507 2019-02-15  Tom Tromey  <tromey@adacore.com>
4508
4509         * ravenscar-thread.c (base_ptid): Remove.
4510         (struct ravenscar_thread_target) <close>: New method.
4511         <m_base_ptid>: New member.
4512         <update_inferior_ptid, active_task, task_is_currently_active,
4513         runtime_initialized>: Declare methods.
4514         <ravenscar_thread_target>: Add constructor.
4515         (ravenscar_thread_target::task_is_currently_active)
4516         (ravenscar_thread_target::update_inferior_ptid)
4517         (ravenscar_runtime_initialized): Rename.  Now methods.
4518         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4519         (ravenscar_thread_target::update_thread_list): Update.
4520         (ravenscar_thread_target::active_task): Now method.
4521         (ravenscar_thread_target::store_registers)
4522         (ravenscar_thread_target::prepare_to_store)
4523         (ravenscar_thread_target::prepare_to_store)
4524         (ravenscar_thread_target::mourn_inferior): Update.
4525         (ravenscar_inferior_created): Use "new" to create target.
4526         (ravenscar_thread_target::get_ada_task_ptid): Update.
4527         (_initialize_ravenscar): Don't initialize base_ptid.
4528         (ravenscar_ops): Remove global.
4529
4530 2019-02-15  Tom Tromey  <tromey@adacore.com>
4531
4532         * target.h (push_target): Declare new overload.
4533         * target.c (push_target): New overload, taking an rvalue reference.
4534         * remote.c (remote_target::open_1): Use push_target overload.
4535         * corelow.c (core_target_open): Use push_target overload.
4536
4537 2019-02-15  Tom Tromey  <tromey@adacore.com>
4538
4539         * ravenscar-thread.c (is_ravenscar_task)
4540         (ravenscar_task_is_currently_active): Return bool.
4541         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4542         (_initialize_ravenscar): Remove "(void)".
4543         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4544         Return bool.
4545
4546 2019-02-15  Tom Tromey  <tromey@adacore.com>
4547
4548         * ravenscar-thread.c (ravenscar_runtime_initializer)
4549         (has_ravenscar_runtime, get_running_thread_id)
4550         (ravenscar_thread_target::resume): Fix indentation.
4551
4552 2019-02-15  Tom Tromey  <tromey@adacore.com>
4553
4554         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4555         from ravenscar_arch_ops.
4556         (sparc_ravenscar_ops::fetch_registers)
4557         (sparc_ravenscar_ops::store_registers): Now methods.
4558         (sparc_ravenscar_prepare_to_store): Remove.
4559         (sparc_ravenscar_ops): Redefine.
4560         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4561         methods and destructor.  Remove members.
4562         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4563         (ravenscar_thread_target::store_registers)
4564         (ravenscar_thread_target::prepare_to_store): Update.
4565         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4566         Remove.
4567         (struct ppc_ravenscar_powerpc_ops): Derive from
4568         ravenscar_arch_ops.
4569         (ppc_ravenscar_powerpc_ops::fetch_registers)
4570         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4571         (ppc_ravenscar_powerpc_ops): Redefine.
4572         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4573         (ppc_ravenscar_e500_ops::fetch_registers)
4574         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4575         (ppc_ravenscar_e500_ops): Redefine.
4576         * aarch64-ravenscar-thread.c
4577         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4578         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4579         (aarch64_ravenscar_fetch_registers)
4580         (aarch64_ravenscar_store_registers): Now methods.
4581         (aarch64_ravenscar_ops): Redefine.
4582
4583 2019-02-15  Tom Tromey  <tromey@adacore.com>
4584
4585         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4586         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4587         (ravenscar_thread_target::stopped_by_watchpoint)
4588         (ravenscar_thread_target::stopped_data_address)
4589         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4590
4591 2019-02-15  Tom Tromey  <tromey@adacore.com>
4592
4593         * ravenscar-thread.c: Fix some typos.
4594
4595 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4596             Tom Tromey  <tromey@adacore.com>
4597
4598         * ada-lang.c (ada_exception_sal): Change addr_string to a
4599         std::string.
4600         (create_ada_exception_catchpoint): Update.
4601
4602 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4603             Tom Tromey  <tromey@adacore.com>
4604
4605         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4606         (bp_location_ops): Remove.
4607         (base_breakpoint_allocate_location): Update.
4608         (free_bp_location): Update.
4609         * ada-lang.c (class ada_catchpoint_location)
4610         <ada_catchpoint_location>: Remove ops parameter.
4611         (ada_catchpoint_location_dtor): Remove.
4612         (ada_catchpoint_location_ops): Remove.
4613         (allocate_location_exception): Update.
4614         * breakpoint.h (struct bp_location_ops): Remove.
4615         (class bp_location) <bp_location>: Remove bp_location_ops
4616         parameter.
4617         <~bp_location>: Add destructor.
4618         <ops>: Remove.
4619
4620 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4621             Pedro Alves  <palves@redhat.com>
4622
4623         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4624         'PATH_MAX'.
4625
4626 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4627             Samuel Thibault  <samuel.thibault@gnu.org>
4628             Thomas Schwinge  <thomas@codesourcery.com>
4629
4630         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4631         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4632
4633 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4634
4635         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4636         (check_empty): Use "const char *".
4637
4638         * gnu-nat.c (gnu_nat_target::detach): Instead of
4639         'detach_inferior (pid)' call
4640         'detach_inferior (find_inferior_pid (pid))'.
4641
4642         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4643         'nat/fork-inferior.o'.
4644         * gnu-nat.c: #include "nat/fork-inferior.h".
4645
4646         * gnu-nat.c (gnu_nat_target::detach): Instead of
4647         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4648         * gnu-nat.h: #include "inf-child.h".
4649         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4650         'i386_gnu_nat_target::fetch_registers'.
4651         (gnu_store_registers): Rename/move to
4652         'i386_gnu_nat_target::store_registers'.
4653
4654         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4655         * gnu-nat.h (mach_thread_info): New function.
4656         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4657
4658         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4659
4660 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4661
4662         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4663
4664 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4665
4666         * windows-nat.c (windows_add_thread): Add new parameter
4667         "main_thread_p" with default value set to false.  Update
4668         function documentation as well as all callers.
4669         (windows_delete_thread): Likewise.
4670         (fake_create_process): Update call to windows_add_thread.
4671         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4672         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4673         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4674         call to windows_delete_thread.
4675
4676 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4677
4678         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4679
4680 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4681
4682         * symfile.c (find_separate_debug_file): Use canonical path of
4683         sysroot with child_path instead of gdb_sysroot if it is valid.
4684
4685 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4686
4687         * symfile.c (find_separate_debug_file): Use child_path to
4688         determine if an object file is under a sysroot.
4689
4690 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4691
4692         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4693         unittests/child-path-selftests.c.
4694         * common/pathstuff.c (child_path): New function.
4695         * common/pathstuff.h (child_path): New prototype.
4696         * unittests/child-path-selftests.c: New file.
4697
4698 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4699
4700         * symfile.c (find_separate_debug_file): Look for separate debug
4701         files in debug directories under the sysroot.
4702
4703 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4704
4705         * symtab.h (struct minimal_symbol data_p): New const method.
4706         (struct minimal_symbol text_p): Likewise.
4707         * symtab.c (output_source_filename): Use file name style
4708         to print file name.
4709         (print_symbol_info): Likewise.
4710         (print_msymbol_info): Use address style to print addresses.
4711         Use function name style to print executable text symbols.
4712         (expand_symtab_containing_pc): Use data_p.
4713         (find_pc_sect_compunit_symtab): Likewise.
4714
4715 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4716
4717         * breakpoint.c (describe_other_breakpoints): Use address style
4718         to print addresses.
4719         (say_where): Likewise.
4720
4721 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4722
4723         * ada-typeprint.c (print_func_type): Print function name
4724         style to print function name.
4725         * c-typeprint.c (c_print_type_1): Likewise.
4726
4727 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4728
4729         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4730         for execve.
4731
4732 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4733
4734         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4735         type_stack.
4736
4737 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4738
4739         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4740         TYPE_CODE_REF types.
4741
4742 2019-02-08  Jim Wilson  <jimw@sifive.com>
4743
4744         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4745         (riscv_linux_fregset): New.
4746         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4747
4748 2019-02-07  Tom Tromey  <tom@tromey.com>
4749
4750         * thread.c (thread_cancel_execution_command): Update.
4751         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4752         methods.
4753         (struct thread_fsm_ops): Remove.
4754         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4755         (thread_fsm_should_stop, thread_fsm_return_value)
4756         (thread_fsm_set_finished, thread_fsm_finished_p)
4757         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4758         Don't declare.
4759         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4760         * infrun.c (clear_proceed_status_thread)
4761         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4762         (print_stop_event): Update.
4763         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4764         Add constructor.
4765         (step_command_fsm_ops): Remove.
4766         (new_step_command_fsm): Remove.
4767         (step_1): Update.
4768         (step_command_fsm::should_stop): Rename from
4769         step_command_fsm_should_stop.
4770         (step_command_fsm::clean_up): Rename from
4771         step_command_fsm_clean_up.
4772         (step_command_fsm::do_async_reply_reason): Rename from
4773         step_command_fsm_async_reply_reason.
4774         (struct until_next_fsm): Inherit from thread_fsm.  Add
4775         constructor.
4776         (until_next_fsm_ops): Remove.
4777         (new_until_next_fsm): Remove.
4778         (until_next_fsm::should_stop): Rename from
4779         until_next_fsm_should_stop.
4780         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4781         (until_next_fsm::do_async_reply_reason): Rename from
4782         until_next_fsm_async_reply_reason.
4783         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4784         constructor.  Change type of breakpoint.
4785         (finish_command_fsm_ops): Remove.
4786         (new_finish_command_fsm): Remove.
4787         (finish_command_fsm::should_stop): Rename from
4788         finish_command_fsm_should_stop.
4789         (finish_command_fsm::clean_up): Rename from
4790         finish_command_fsm_clean_up.
4791         (finish_command_fsm::return_value): Rename from
4792         finish_command_fsm_return_value.
4793         (finish_command_fsm::do_async_reply_reason): Rename from
4794         finish_command_fsm_async_reply_reason.
4795         (finish_command): Update.
4796         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
4797         Add constructor.
4798         (call_thread_fsm_ops): Remove.
4799         (call_thread_fsm::call_thread_fsm): Rename from
4800         new_call_thread_fsm.
4801         (call_thread_fsm::should_stop): Rename from
4802         call_thread_fsm_should_stop.
4803         (call_thread_fsm::should_notify_stop): Rename from
4804         call_thread_fsm_should_notify_stop.
4805         (run_inferior_call, call_function_by_hand_dummy): Update.
4806         * cli/cli-interp.c (should_print_stop_to_console): Update.
4807         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
4808         Add constructor.  Change type of location_breakpoint,
4809         caller_breakpoint.
4810         (until_break_fsm_ops): Remove.
4811         (new_until_break_fsm): Remove.
4812         (until_break_fsm::should_stop): Rename from
4813         until_break_fsm_should_stop.
4814         (until_break_fsm::clean_up): Rename from
4815         until_break_fsm_clean_up.
4816         (until_break_fsm::do_async_reply_reason): Rename from
4817         until_break_fsm_async_reply_reason.
4818         (until_break_command): Update.
4819         * thread-fsm.c: Remove.
4820         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
4821
4822 2019-02-07  Tom Tromey  <tom@tromey.com>
4823
4824         * yy-remap.h: Add include guard.
4825         * xtensa-tdep.h: Add include guard.
4826         * xcoffread.h: Rename include guard.
4827         * varobj-iter.h: Add include guard.
4828         * tui/tui.h: Rename include guard.
4829         * tui/tui-winsource.h: Rename include guard.
4830         * tui/tui-wingeneral.h: Rename include guard.
4831         * tui/tui-windata.h: Rename include guard.
4832         * tui/tui-win.h: Rename include guard.
4833         * tui/tui-stack.h: Rename include guard.
4834         * tui/tui-source.h: Rename include guard.
4835         * tui/tui-regs.h: Rename include guard.
4836         * tui/tui-out.h: Rename include guard.
4837         * tui/tui-layout.h: Rename include guard.
4838         * tui/tui-io.h: Rename include guard.
4839         * tui/tui-hooks.h: Rename include guard.
4840         * tui/tui-file.h: Rename include guard.
4841         * tui/tui-disasm.h: Rename include guard.
4842         * tui/tui-data.h: Rename include guard.
4843         * tui/tui-command.h: Rename include guard.
4844         * tic6x-tdep.h: Add include guard.
4845         * target/waitstatus.h: Rename include guard.
4846         * target/wait.h: Rename include guard.
4847         * target/target.h: Rename include guard.
4848         * target/resume.h: Rename include guard.
4849         * target-float.h: Rename include guard.
4850         * stabsread.h: Add include guard.
4851         * rs6000-tdep.h: Add include guard.
4852         * riscv-fbsd-tdep.h: Add include guard.
4853         * regformats/regdef.h: Rename include guard.
4854         * record.h: Rename include guard.
4855         * python/python.h: Rename include guard.
4856         * python/python-internal.h: Rename include guard.
4857         * python/py-stopevent.h: Rename include guard.
4858         * python/py-ref.h: Rename include guard.
4859         * python/py-record.h: Rename include guard.
4860         * python/py-record-full.h: Rename include guard.
4861         * python/py-record-btrace.h: Rename include guard.
4862         * python/py-instruction.h: Rename include guard.
4863         * python/py-events.h: Rename include guard.
4864         * python/py-event.h: Rename include guard.
4865         * procfs.h: Add include guard.
4866         * proc-utils.h: Add include guard.
4867         * p-lang.h: Add include guard.
4868         * or1k-tdep.h: Rename include guard.
4869         * observable.h: Rename include guard.
4870         * nto-tdep.h: Rename include guard.
4871         * nat/x86-linux.h: Rename include guard.
4872         * nat/x86-linux-dregs.h: Rename include guard.
4873         * nat/x86-gcc-cpuid.h: Add include guard.
4874         * nat/x86-dregs.h: Rename include guard.
4875         * nat/x86-cpuid.h: Rename include guard.
4876         * nat/ppc-linux.h: Rename include guard.
4877         * nat/mips-linux-watch.h: Rename include guard.
4878         * nat/linux-waitpid.h: Rename include guard.
4879         * nat/linux-ptrace.h: Rename include guard.
4880         * nat/linux-procfs.h: Rename include guard.
4881         * nat/linux-osdata.h: Rename include guard.
4882         * nat/linux-nat.h: Rename include guard.
4883         * nat/linux-namespaces.h: Rename include guard.
4884         * nat/linux-btrace.h: Rename include guard.
4885         * nat/glibc_thread_db.h: Rename include guard.
4886         * nat/gdb_thread_db.h: Rename include guard.
4887         * nat/gdb_ptrace.h: Rename include guard.
4888         * nat/fork-inferior.h: Rename include guard.
4889         * nat/amd64-linux-siginfo.h: Rename include guard.
4890         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
4891         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
4892         * nat/aarch64-linux.h: Rename include guard.
4893         * nat/aarch64-linux-hw-point.h: Rename include guard.
4894         * mn10300-tdep.h: Add include guard.
4895         * mips-linux-tdep.h: Add include guard.
4896         * mi/mi-parse.h: Rename include guard.
4897         * mi/mi-out.h: Rename include guard.
4898         * mi/mi-main.h: Rename include guard.
4899         * mi/mi-interp.h: Rename include guard.
4900         * mi/mi-getopt.h: Rename include guard.
4901         * mi/mi-console.h: Rename include guard.
4902         * mi/mi-common.h: Rename include guard.
4903         * mi/mi-cmds.h: Rename include guard.
4904         * mi/mi-cmd-break.h: Rename include guard.
4905         * m2-lang.h: Add include guard.
4906         * location.h: Rename include guard.
4907         * linux-record.h: Rename include guard.
4908         * linux-nat.h: Add include guard.
4909         * linux-fork.h: Add include guard.
4910         * i386-darwin-tdep.h: Rename include guard.
4911         * hppa-linux-offsets.h: Add include guard.
4912         * guile/guile.h: Rename include guard.
4913         * guile/guile-internal.h: Rename include guard.
4914         * gnu-nat.h: Rename include guard.
4915         * gdb-stabs.h: Rename include guard.
4916         * frv-tdep.h: Add include guard.
4917         * f-lang.h: Add include guard.
4918         * event-loop.h: Add include guard.
4919         * darwin-nat.h: Rename include guard.
4920         * cp-abi.h: Rename include guard.
4921         * config/sparc/nm-sol2.h: Rename include guard.
4922         * config/nm-nto.h: Rename include guard.
4923         * config/nm-linux.h: Add include guard.
4924         * config/i386/nm-i386gnu.h: Rename include guard.
4925         * config/djgpp/nl_types.h: Rename include guard.
4926         * config/djgpp/langinfo.h: Rename include guard.
4927         * compile/gcc-cp-plugin.h: Add include guard.
4928         * compile/gcc-c-plugin.h: Add include guard.
4929         * compile/compile.h: Rename include guard.
4930         * compile/compile-object-run.h: Rename include guard.
4931         * compile/compile-object-load.h: Rename include guard.
4932         * compile/compile-internal.h: Rename include guard.
4933         * compile/compile-cplus.h: Rename include guard.
4934         * compile/compile-c.h: Rename include guard.
4935         * common/xml-utils.h: Rename include guard.
4936         * common/x86-xstate.h: Rename include guard.
4937         * common/version.h: Rename include guard.
4938         * common/vec.h: Rename include guard.
4939         * common/tdesc.h: Rename include guard.
4940         * common/selftest.h: Rename include guard.
4941         * common/scoped_restore.h: Rename include guard.
4942         * common/scoped_mmap.h: Rename include guard.
4943         * common/scoped_fd.h: Rename include guard.
4944         * common/safe-iterator.h: Rename include guard.
4945         * common/run-time-clock.h: Rename include guard.
4946         * common/refcounted-object.h: Rename include guard.
4947         * common/queue.h: Rename include guard.
4948         * common/ptid.h: Rename include guard.
4949         * common/print-utils.h: Rename include guard.
4950         * common/preprocessor.h: Rename include guard.
4951         * common/pathstuff.h: Rename include guard.
4952         * common/observable.h: Rename include guard.
4953         * common/netstuff.h: Rename include guard.
4954         * common/job-control.h: Rename include guard.
4955         * common/host-defs.h: Rename include guard.
4956         * common/gdb_wait.h: Rename include guard.
4957         * common/gdb_vecs.h: Rename include guard.
4958         * common/gdb_unlinker.h: Rename include guard.
4959         * common/gdb_unique_ptr.h: Rename include guard.
4960         * common/gdb_tilde_expand.h: Rename include guard.
4961         * common/gdb_sys_time.h: Rename include guard.
4962         * common/gdb_string_view.h: Rename include guard.
4963         * common/gdb_splay_tree.h: Rename include guard.
4964         * common/gdb_setjmp.h: Rename include guard.
4965         * common/gdb_ref_ptr.h: Rename include guard.
4966         * common/gdb_optional.h: Rename include guard.
4967         * common/gdb_locale.h: Rename include guard.
4968         * common/gdb_assert.h: Rename include guard.
4969         * common/filtered-iterator.h: Rename include guard.
4970         * common/filestuff.h: Rename include guard.
4971         * common/fileio.h: Rename include guard.
4972         * common/environ.h: Rename include guard.
4973         * common/common-utils.h: Rename include guard.
4974         * common/common-types.h: Rename include guard.
4975         * common/common-regcache.h: Rename include guard.
4976         * common/common-inferior.h: Rename include guard.
4977         * common/common-gdbthread.h: Rename include guard.
4978         * common/common-exceptions.h: Rename include guard.
4979         * common/common-defs.h: Rename include guard.
4980         * common/common-debug.h: Rename include guard.
4981         * common/cleanups.h: Rename include guard.
4982         * common/buffer.h: Rename include guard.
4983         * common/btrace-common.h: Rename include guard.
4984         * common/break-common.h: Rename include guard.
4985         * cli/cli-utils.h: Rename include guard.
4986         * cli/cli-style.h: Rename include guard.
4987         * cli/cli-setshow.h: Rename include guard.
4988         * cli/cli-script.h: Rename include guard.
4989         * cli/cli-interp.h: Rename include guard.
4990         * cli/cli-decode.h: Rename include guard.
4991         * cli/cli-cmds.h: Rename include guard.
4992         * charset-list.h: Add include guard.
4993         * buildsym-legacy.h: Rename include guard.
4994         * bfin-tdep.h: Add include guard.
4995         * ax.h: Rename include guard.
4996         * arm-linux-tdep.h: Add include guard.
4997         * arm-fbsd-tdep.h: Add include guard.
4998         * arch/xtensa.h: Rename include guard.
4999         * arch/tic6x.h: Add include guard.
5000         * arch/i386.h: Add include guard.
5001         * arch/arm.h: Rename include guard.
5002         * arch/arm-linux.h: Rename include guard.
5003         * arch/arm-get-next-pcs.h: Rename include guard.
5004         * arch/amd64.h: Add include guard.
5005         * arch/aarch64-insn.h: Rename include guard.
5006         * arch-utils.h: Rename include guard.
5007         * annotate.h: Add include guard.
5008         * amd64-darwin-tdep.h: Rename include guard.
5009         * aarch64-linux-tdep.h: Add include guard.
5010         * aarch64-fbsd-tdep.h: Add include guard.
5011         * aarch32-linux-nat.h: Add include guard.
5012
5013 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5014
5015         * macrotab.c (macro_define_internal): New function that
5016         factorizes macro_define_object_internal and macro_define_function
5017         code.
5018         (macro_define_object_internal): Use macro_define_internal.
5019         (macro_define_function): Likewise.
5020
5021 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5022
5023         * macrocmd.c (extract_identifier): Return
5024         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
5025         callers.
5026
5027 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
5028
5029         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
5030
5031 2019-02-05  Tom Tromey  <tom@tromey.com>
5032
5033         * target.c (target_stack::unpush): Move assertion earlier.
5034
5035 2019-01-30  Tom Tromey  <tom@tromey.com>
5036
5037         PR python/23615:
5038         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
5039         (gdbpy_parse_and_eval): Likewise.
5040         * python/python-internal.h (gdbpy_allow_threads): New class.
5041
5042 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
5043
5044         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
5045         (aarch64_fbsd_fpregmap): Move earlier.
5046         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
5047         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5048         instead of individual calls to trad_frame_set_reg_addr.
5049         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
5050         earlier.
5051         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
5052         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5053         instead of individual calls to trad_frame_set_reg_addr.
5054
5055 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
5056
5057         * CONTRIBUTE: Replace contribution list with wiki link.
5058
5059 2019-01-25  Tom Tromey  <tom@tromey.com>
5060
5061         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
5062
5063 2019-01-25  Tom Tromey  <tom@tromey.com>
5064
5065         * xtensa-linux-nat.c: Fix common/ includes.
5066         * xml-support.h: Fix common/ includes.
5067         * xml-support.c: Fix common/ includes.
5068         * x86-linux-nat.c: Fix common/ includes.
5069         * windows-nat.c: Fix common/ includes.
5070         * varobj.h: Fix common/ includes.
5071         * varobj.c: Fix common/ includes.
5072         * value.c: Fix common/ includes.
5073         * valops.c: Fix common/ includes.
5074         * utils.c: Fix common/ includes.
5075         * unittests/xml-utils-selftests.c: Fix common/ includes.
5076         * unittests/utils-selftests.c: Fix common/ includes.
5077         * unittests/unpack-selftests.c: Fix common/ includes.
5078         * unittests/tracepoint-selftests.c: Fix common/ includes.
5079         * unittests/style-selftests.c: Fix common/ includes.
5080         * unittests/string_view-selftests.c: Fix common/ includes.
5081         * unittests/scoped_restore-selftests.c: Fix common/ includes.
5082         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
5083         * unittests/scoped_fd-selftests.c: Fix common/ includes.
5084         * unittests/rsp-low-selftests.c: Fix common/ includes.
5085         * unittests/parse-connection-spec-selftests.c: Fix common/
5086         includes.
5087         * unittests/optional-selftests.c: Fix common/ includes.
5088         * unittests/offset-type-selftests.c: Fix common/ includes.
5089         * unittests/observable-selftests.c: Fix common/ includes.
5090         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
5091         * unittests/memrange-selftests.c: Fix common/ includes.
5092         * unittests/memory-map-selftests.c: Fix common/ includes.
5093         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
5094         * unittests/function-view-selftests.c: Fix common/ includes.
5095         * unittests/environ-selftests.c: Fix common/ includes.
5096         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
5097         * unittests/common-utils-selftests.c: Fix common/ includes.
5098         * unittests/cli-utils-selftests.c: Fix common/ includes.
5099         * unittests/array-view-selftests.c: Fix common/ includes.
5100         * ui-file.c: Fix common/ includes.
5101         * tui/tui-io.c: Fix common/ includes.
5102         * tracepoint.h: Fix common/ includes.
5103         * tracepoint.c: Fix common/ includes.
5104         * tracefile-tfile.c: Fix common/ includes.
5105         * top.h: Fix common/ includes.
5106         * top.c: Fix common/ includes.
5107         * thread.c: Fix common/ includes.
5108         * target/waitstatus.h: Fix common/ includes.
5109         * target/waitstatus.c: Fix common/ includes.
5110         * target.h: Fix common/ includes.
5111         * target.c: Fix common/ includes.
5112         * target-memory.c: Fix common/ includes.
5113         * target-descriptions.c: Fix common/ includes.
5114         * symtab.h: Fix common/ includes.
5115         * symfile.c: Fix common/ includes.
5116         * stap-probe.c: Fix common/ includes.
5117         * spu-linux-nat.c: Fix common/ includes.
5118         * sparc-nat.c: Fix common/ includes.
5119         * source.c: Fix common/ includes.
5120         * solib.c: Fix common/ includes.
5121         * solib-target.c: Fix common/ includes.
5122         * ser-unix.c: Fix common/ includes.
5123         * ser-tcp.c: Fix common/ includes.
5124         * ser-pipe.c: Fix common/ includes.
5125         * ser-base.c: Fix common/ includes.
5126         * selftest-arch.c: Fix common/ includes.
5127         * s12z-tdep.c: Fix common/ includes.
5128         * rust-exp.y: Fix common/ includes.
5129         * rs6000-aix-tdep.c: Fix common/ includes.
5130         * riscv-tdep.c: Fix common/ includes.
5131         * remote.c: Fix common/ includes.
5132         * remote-notif.h: Fix common/ includes.
5133         * remote-fileio.h: Fix common/ includes.
5134         * remote-fileio.c: Fix common/ includes.
5135         * regcache.h: Fix common/ includes.
5136         * regcache.c: Fix common/ includes.
5137         * record-btrace.c: Fix common/ includes.
5138         * python/python.c: Fix common/ includes.
5139         * python/py-type.c: Fix common/ includes.
5140         * python/py-inferior.c: Fix common/ includes.
5141         * progspace.h: Fix common/ includes.
5142         * producer.c: Fix common/ includes.
5143         * procfs.c: Fix common/ includes.
5144         * proc-api.c: Fix common/ includes.
5145         * printcmd.c: Fix common/ includes.
5146         * ppc-linux-nat.c: Fix common/ includes.
5147         * parser-defs.h: Fix common/ includes.
5148         * osdata.c: Fix common/ includes.
5149         * obsd-nat.c: Fix common/ includes.
5150         * nat/x86-linux.c: Fix common/ includes.
5151         * nat/x86-linux-dregs.c: Fix common/ includes.
5152         * nat/x86-dregs.h: Fix common/ includes.
5153         * nat/x86-dregs.c: Fix common/ includes.
5154         * nat/ppc-linux.c: Fix common/ includes.
5155         * nat/mips-linux-watch.h: Fix common/ includes.
5156         * nat/mips-linux-watch.c: Fix common/ includes.
5157         * nat/linux-waitpid.c: Fix common/ includes.
5158         * nat/linux-ptrace.h: Fix common/ includes.
5159         * nat/linux-ptrace.c: Fix common/ includes.
5160         * nat/linux-procfs.c: Fix common/ includes.
5161         * nat/linux-personality.c: Fix common/ includes.
5162         * nat/linux-osdata.c: Fix common/ includes.
5163         * nat/linux-namespaces.c: Fix common/ includes.
5164         * nat/linux-btrace.h: Fix common/ includes.
5165         * nat/linux-btrace.c: Fix common/ includes.
5166         * nat/fork-inferior.c: Fix common/ includes.
5167         * nat/amd64-linux-siginfo.c: Fix common/ includes.
5168         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
5169         * nat/aarch64-linux.c: Fix common/ includes.
5170         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
5171         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
5172         * namespace.h: Fix common/ includes.
5173         * mips-linux-tdep.c: Fix common/ includes.
5174         * minsyms.c: Fix common/ includes.
5175         * mi/mi-parse.h: Fix common/ includes.
5176         * mi/mi-main.c: Fix common/ includes.
5177         * mi/mi-cmd-env.c: Fix common/ includes.
5178         * memrange.h: Fix common/ includes.
5179         * memattr.c: Fix common/ includes.
5180         * maint.h: Fix common/ includes.
5181         * maint.c: Fix common/ includes.
5182         * main.c: Fix common/ includes.
5183         * machoread.c: Fix common/ includes.
5184         * location.c: Fix common/ includes.
5185         * linux-thread-db.c: Fix common/ includes.
5186         * linux-nat.c: Fix common/ includes.
5187         * linux-fork.c: Fix common/ includes.
5188         * inline-frame.c: Fix common/ includes.
5189         * infrun.c: Fix common/ includes.
5190         * inflow.c: Fix common/ includes.
5191         * inferior.h: Fix common/ includes.
5192         * inferior.c: Fix common/ includes.
5193         * infcmd.c: Fix common/ includes.
5194         * inf-ptrace.c: Fix common/ includes.
5195         * inf-child.c: Fix common/ includes.
5196         * ia64-linux-nat.c: Fix common/ includes.
5197         * i387-tdep.c: Fix common/ includes.
5198         * i386-tdep.c: Fix common/ includes.
5199         * i386-linux-tdep.c: Fix common/ includes.
5200         * i386-linux-nat.c: Fix common/ includes.
5201         * i386-go32-tdep.c: Fix common/ includes.
5202         * i386-fbsd-tdep.c: Fix common/ includes.
5203         * i386-fbsd-nat.c: Fix common/ includes.
5204         * guile/scm-type.c: Fix common/ includes.
5205         * guile/guile.c: Fix common/ includes.
5206         * go32-nat.c: Fix common/ includes.
5207         * gnu-nat.c: Fix common/ includes.
5208         * gdbthread.h: Fix common/ includes.
5209         * gdbarch-selftests.c: Fix common/ includes.
5210         * gdb_usleep.c: Fix common/ includes.
5211         * gdb_select.h: Fix common/ includes.
5212         * gdb_bfd.c: Fix common/ includes.
5213         * gcore.c: Fix common/ includes.
5214         * fork-child.c: Fix common/ includes.
5215         * findvar.c: Fix common/ includes.
5216         * fbsd-nat.c: Fix common/ includes.
5217         * event-top.c: Fix common/ includes.
5218         * event-loop.c: Fix common/ includes.
5219         * dwarf2read.c: Fix common/ includes.
5220         * dwarf2loc.c: Fix common/ includes.
5221         * dwarf2-frame.c: Fix common/ includes.
5222         * dwarf-index-cache.c: Fix common/ includes.
5223         * dtrace-probe.c: Fix common/ includes.
5224         * disasm-selftests.c: Fix common/ includes.
5225         * defs.h: Fix common/ includes.
5226         * csky-tdep.c: Fix common/ includes.
5227         * cp-valprint.c: Fix common/ includes.
5228         * cp-support.h: Fix common/ includes.
5229         * cp-support.c: Fix common/ includes.
5230         * corelow.c: Fix common/ includes.
5231         * completer.h: Fix common/ includes.
5232         * completer.c: Fix common/ includes.
5233         * compile/compile.c: Fix common/ includes.
5234         * compile/compile-loc2c.c: Fix common/ includes.
5235         * compile/compile-cplus-types.c: Fix common/ includes.
5236         * compile/compile-cplus-symbols.c: Fix common/ includes.
5237         * command.h: Fix common/ includes.
5238         * cli/cli-dump.c: Fix common/ includes.
5239         * cli/cli-cmds.c: Fix common/ includes.
5240         * charset.c: Fix common/ includes.
5241         * build-id.c: Fix common/ includes.
5242         * btrace.h: Fix common/ includes.
5243         * btrace.c: Fix common/ includes.
5244         * breakpoint.h: Fix common/ includes.
5245         * breakpoint.c: Fix common/ includes.
5246         * ax.h:
5247         (enum agent_op): Fix common/ includes.
5248         * ax-general.c (struct aop_map): Fix common/ includes.
5249         * ax-gdb.c: Fix common/ includes.
5250         * auxv.c: Fix common/ includes.
5251         * auto-load.c: Fix common/ includes.
5252         * arm-tdep.c: Fix common/ includes.
5253         * arch/riscv.c: Fix common/ includes.
5254         * arch/ppc-linux-common.c: Fix common/ includes.
5255         * arch/i386.c: Fix common/ includes.
5256         * arch/arm.c: Fix common/ includes.
5257         * arch/arm-linux.c: Fix common/ includes.
5258         * arch/arm-get-next-pcs.c: Fix common/ includes.
5259         * arch/amd64.c: Fix common/ includes.
5260         * arch/aarch64.c: Fix common/ includes.
5261         * arch/aarch64-insn.c: Fix common/ includes.
5262         * arch-utils.c: Fix common/ includes.
5263         * amd64-windows-tdep.c: Fix common/ includes.
5264         * amd64-tdep.c: Fix common/ includes.
5265         * amd64-sol2-tdep.c: Fix common/ includes.
5266         * amd64-obsd-tdep.c: Fix common/ includes.
5267         * amd64-nbsd-tdep.c: Fix common/ includes.
5268         * amd64-linux-tdep.c: Fix common/ includes.
5269         * amd64-linux-nat.c: Fix common/ includes.
5270         * amd64-fbsd-tdep.c: Fix common/ includes.
5271         * amd64-fbsd-nat.c: Fix common/ includes.
5272         * amd64-dicos-tdep.c: Fix common/ includes.
5273         * amd64-darwin-tdep.c: Fix common/ includes.
5274         * agent.c: Fix common/ includes.
5275         * ada-lang.h: Fix common/ includes.
5276         * ada-lang.c: Fix common/ includes.
5277         * aarch64-tdep.c: Fix common/ includes.
5278
5279 2019-01-25  Tom Tromey  <tom@tromey.com>
5280
5281         * common/create-version.sh: Use common/version.h.
5282
5283 2019-01-24  Pedro Alves  <palves@redhat.com>
5284
5285         * infrun.c (signal_stop, signal_print, signal_program)
5286         (signal_catch, signal_pass): Now arrays instead of pointers.
5287         (update_signals_program_target, do_target_resume)
5288         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
5289         * linux-nat.c (linux_nat_target::pass_signals)
5290         (linux_nat_target::create_inferior, linux_nat_target::attach):
5291         Adjust.
5292         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
5293         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
5294         * procfs.c (procfs_target::pass_signals): Adjust.
5295         * record-full.c (record_full_target::resume): Adjust.
5296         * remote.c (remote_target::pass_signals)
5297         (remote_target::program_signals): Adjust.
5298         * target-debug.h (target_debug_print_signals): Now takes a
5299         gdb::array_view as parameter.  Adjust.
5300         * target.h (target_ops) <pass_signals, program_signals>: Replace
5301         pointer and length parameters with gdb::array_view.
5302         (target_pass_signals, target_program_signals): Likewise.
5303         * target-delegates.c: Regenerate.
5304
5305 2019-01-24  Pedro Alves  <palves@redhat.com>
5306
5307         * common/forward-scope-exit.h
5308         (forward_scope_exit::forward_scope_exit): Pass arguments to
5309         m_bind_function directly, instead of creating a std::bind and
5310         copying that.
5311
5312 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
5313
5314         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5315         for static members.
5316         (pass_in_v_vfp_candidate): Likewise.
5317
5318 2019-01-23  Tom Tromey  <tom@tromey.com>
5319             Pedro Alves  <palves@redhat.com>
5320
5321         * regcache.c (class regcache_invalidator): Remove.
5322         (regcache::raw_write): Use make_scope_exit.
5323
5324 2019-01-23  Tom Tromey  <tom@tromey.com>
5325
5326         * ui-out.h (class ui_out_emit_type): Update comment.
5327
5328 2019-01-23  Tom Tromey  <tom@tromey.com>
5329
5330         * infrun.c (fetch_inferior_event): Update comment.
5331
5332 2019-01-23  Tom Tromey  <tom@tromey.com>
5333             Pedro Alves  <palves@redhat.com>
5334
5335         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
5336         parameter.
5337         (fetch_inferior_event): Use SCOPE_EXIT.
5338
5339
5340 2019-01-23  Tom Tromey  <tom@tromey.com>
5341             Pedro Alves  <palves@redhat.com>
5342
5343         * infrun.c (disable_thread_events): Delete.
5344         (stop_all_threads): Use SCOPE_EXIT.
5345
5346 2019-01-23  Tom Tromey  <tom@tromey.com>
5347             Pedro Alves  <palves@redhat.com>
5348
5349         * symfile.c: Include forward-scope-exit.h.
5350         (clear_symtab_users_cleanup): Replace forward declaration with
5351         a FORWARD_SCOPE_EXIT.
5352         (syms_from_objfile_1): Use the forward_scope_exit and
5353         gdb::optional instead of cleanup_function.
5354         (reread_symbols): Use the forward_scope_exit instead of
5355         cleanup_function.
5356         (clear_symtab_users_cleanup): Remove function.
5357
5358 2019-01-23  Tom Tromey  <tom@tromey.com>
5359             Pedro Alves  <palves@redhat.com>
5360
5361         * linux-nat.c: Include scope-exit.h.
5362         (cleanup_target_stop): Remove.
5363         (linux_nat_target::static_tracepoint_markers_by_strid): Use
5364         SCOPE_EXIT.
5365
5366 2019-01-23  Tom Tromey  <tom@tromey.com>
5367             Pedro Alves  <palves@redhat.com>
5368
5369         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
5370         (call_function_by_hand_dummy): Use SCOPE_EXIT.
5371
5372 2019-01-23  Tom Tromey  <tom@tromey.com>
5373             Andrew Burgess  <andrew.burgess@embecosm.com>
5374             Pedro Alves  <palves@redhat.com>
5375
5376         * infrun.c (fetch_inferior_event): Use scope_exit.
5377         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
5378         * top.c (execute_command): Use scope_exit.
5379         * breakpoint.c (bpstat_do_actions): Use scope_exit.
5380         * utils.c (do_bpstat_clear_actions_cleanup)
5381         (make_bpstat_clear_actions_cleanup): Remove.
5382
5383 2019-01-23  Tom Tromey  <tom@tromey.com>
5384             Pedro Alves  <palves@redhat.com>
5385
5386         * infrun.c: Include "common/scope-exit.h"
5387         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
5388         (wait_for_inferior): Use SCOPE_EXIT.
5389         (fetch_inferior_event): Use scope_exit.
5390
5391 2019-01-23  Tom Tromey  <tom@tromey.com>
5392             Pedro Alves  <palves@redhat.com>
5393
5394         * breakpoint.c (create_breakpoint): Remove cleanup.
5395
5396 2019-01-23  Tom Tromey  <tom@tromey.com>
5397             Andrew Burgess  <andrew.burgess@embecosm.com>
5398             Pedro Alves  <palves@redhat.com>
5399
5400 2019-01-23  Pedro Alves  <palves@redhat.com>
5401
5402         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5403
5404 2019-01-23  Pedro Alves  <palves@redhat.com>
5405             Andrew Burgess  <andrew.burgess@embecosm.com>
5406
5407         * gdbthread.h: Include "common/forward-scope-exit.h".
5408         (scoped_finish_thread_state): Redefine custom class in terms of
5409         forward_scope_exit.
5410
5411 2019-01-23  Pedro Alves  <palves@redhat.com>
5412             Andrew Burgess  <andrew.burgess@embecosm.com>
5413
5414         * common/forward-scope-exit.h: New file.
5415
5416 2019-01-23  Pedro Alves  <palves@redhat.com>
5417             Andrew Burgess  <andrew.burgess@embecosm.com>
5418             Tom Tromey  <tom@tromey.com>
5419
5420         * common/scope-exit.h: New file.
5421
5422 2019-01-23  Pedro Alves  <palves@redhat.com>
5423
5424         * common/preprocessor.h (ESC): Rename to ...
5425         (ESC_PARENS): ... this.
5426         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5427         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5428
5429 2019-01-23  Tom Tromey  <tom@tromey.com>
5430
5431         * language.h (class scoped_switch_to_sym_language_if_auto):
5432         Initialize m_lang in both cases.
5433
5434 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5435
5436         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5437         with XCNEW.
5438
5439 2019-01-22  Tom Tromey  <tom@tromey.com>
5440
5441         * corelow.c: Do not include sys/file.h.
5442
5443 2019-01-22  Tom Tromey  <tom@tromey.com>
5444
5445         * tui/tui-wingeneral.h: Include gdb_curses.h.
5446
5447 2019-01-22  Tom Tromey  <tom@tromey.com>
5448
5449         * source-cache.h (class source_cache) <get_source_lines,
5450         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5451
5452 2019-01-22  Tom Tromey  <tom@tromey.com>
5453
5454         * remote-fileio.h (struct remote_target): Declare.
5455
5456 2019-01-22  Tom Tromey  <tom@tromey.com>
5457
5458         * python/py-arch.c: Do not include py-ref.h.
5459         * python/py-bpevent.c: Do not include py-ref.h.
5460         * python/py-cmd.c: Do not include py-ref.h.
5461         * python/py-continueevent.c: Do not include py-ref.h.
5462         * python/py-event.h: Do not include py-ref.h.
5463         * python/py-evtregistry.c: Do not include py-ref.h.
5464         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5465         * python/py-frame.c: Do not include py-ref.h.
5466         * python/py-framefilter.c: Do not include py-ref.h.
5467         * python/py-function.c: Do not include py-ref.h.
5468         * python/py-infevents.c: Do not include py-ref.h.
5469         * python/py-linetable.c: Do not include py-ref.h.
5470         * python/py-objfile.c: Do not include py-ref.h.
5471         * python/py-param.c: Do not include py-ref.h.
5472         * python/py-prettyprint.c: Do not include py-ref.h.
5473         * python/py-progspace.c: Do not include py-ref.h.
5474         * python/py-symbol.c: Do not include py-ref.h.
5475         * python/py-symtab.c: Do not include py-ref.h.
5476         * python/py-type.c: Do not include py-ref.h.
5477         * python/py-unwind.c: Do not include py-ref.h.
5478         * python/py-utils.c: Do not include py-ref.h.
5479         * python/py-value.c: Do not include py-ref.h.
5480         * python/py-varobj.c: Do not include py-ref.h.
5481         * python/py-xmethods.c: Do not include py-ref.h.
5482         * python/python.c: Do not include py-ref.h.
5483         * varobj.c: Do not include py-ref.h.
5484
5485 2019-01-22  Tom Tromey  <tom@tromey.com>
5486
5487         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5488         keyword for bcache.
5489
5490 2019-01-22  Tom Tromey  <tom@tromey.com>
5491
5492         * compile/compile-cplus-types.c: Remove a comment by #include.
5493
5494 2019-01-22  Tom Tromey  <tom@tromey.com>
5495
5496         * compile/gcc-c-plugin.h: Include compile-internal.h.
5497
5498 2019-01-22  Tom Tromey  <tom@tromey.com>
5499
5500         * stabsread.c (EXTERN): Do not define.
5501         (symnum, next_symbol_text_func, processing_gcc_compilation)
5502         (within_function, global_sym_chain, global_stabs)
5503         (previous_stab_code, this_object_header_files)
5504         (n_this_object_header_files)
5505         (n_allocated_this_object_header_files): Define.
5506         * stabsread.h (EXTERN): Never define.  Use "extern".
5507
5508 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5509
5510         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5511         history_value.
5512
5513 2019-01-21  Tom Tromey  <tom@tromey.com>
5514
5515         * ui-out.c: Fix includes.
5516         * tui/tui-source.c: Fix includes.
5517         * target.c: Fix includes.
5518         * remote.c: Fix includes.
5519         * regcache.c: Fix includes.
5520         * python/py-block.c: Fix includes.
5521         * printcmd.c: Fix includes.
5522         * or1k-tdep.c: Fix includes.
5523         * mi/mi-main.c: Fix includes.
5524         * m32r-tdep.c: Fix includes.
5525         * csky-tdep.c: Fix includes.
5526         * compile/compile-cplus-types.c: Fix includes.
5527         * cli/cli-interp.c: Fix includes.
5528
5529 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5530
5531         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5532         for padding.
5533
5534 2019-01-16  Tom Tromey  <tom@tromey.com>
5535
5536         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5537         earlier.
5538         (struct objfile) <msymbols_range>: Move from top level.
5539         <msymbols>: New method.
5540         (class objfile_msymbols): Remove.
5541         * symtab.c (default_collect_symbol_completion_matches_break_on):
5542         Update.
5543         * symmisc.c (dump_msymbols): Update.
5544         * stabsread.c (scan_file_globals): Update.
5545         * objc-lang.c (info_selectors_command, info_classes_command)
5546         (find_methods): Update.
5547         * minsyms.c (find_solib_trampoline_target): Update.
5548         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5549         * coffread.c (coff_symfile_read): Update.
5550         * ada-lang.c (ada_lookup_simple_minsym)
5551         (ada_collect_symbol_completion_matches): Update.
5552
5553 2019-01-16  Tom Tromey  <tom@tromey.com>
5554
5555         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5556         type.  Remove no-argument constructor.
5557         <iterator::operator++>: Simplify.
5558         <begin>: Update.
5559         <end>: Use minimal_symbol_count.
5560
5561 2019-01-16  Tom Tromey  <tom@tromey.com>
5562
5563         * objfiles.h (struct objfile) <psymtabs>: New method.
5564         (class objfile_psymtabs): Remove.
5565         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5566         typedef.
5567         <range>: New method.
5568         (require_partial_symbols): Change return type.
5569         * psymtab.c (require_partial_symbols)
5570         (psym_expand_symtabs_matching): Update.
5571         * mdebugread.c (parse_partial_symbols): Update.
5572         * dbxread.c (dbx_end_psymtab): Update.
5573
5574 2019-01-15  Tom Tromey  <tom@tromey.com>
5575
5576         * symtab.c (lookup_objfile_from_block)
5577         (lookup_symbol_in_objfile_symtabs)
5578         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5579         (find_line_symtab, info_sources_command)
5580         (default_collect_symbol_completion_matches_break_on)
5581         (make_source_files_completion_list): Update.
5582         * symmisc.c (print_objfile_statistics, dump_objfile)
5583         (maintenance_print_symbols, maintenance_info_symtabs)
5584         (maintenance_check_symtabs, maintenance_info_line_tables):
5585         Update.
5586         * source.c (select_source_symtab)
5587         (forget_cached_source_info_for_objfile): Update.
5588         * objfiles.h (class objfile_compunits): Remove.
5589         (struct objfile) <compunits_range>: New typedef.
5590         (compunits): New method.
5591         * objfiles.c (objfile_relocate1): Update.
5592         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5593         * maint.c (count_symtabs_and_blocks): Update.
5594         * linespec.c (iterate_over_all_matching_symtabs): Update.
5595         * cp-support.c (add_symbol_overload_list_qualified): Update.
5596         * coffread.c (coff_symtab_read): Update.
5597         * ada-lang.c (add_nonlocal_symbols)
5598         (ada_collect_symbol_completion_matches)
5599         (ada_add_global_exceptions): Update.
5600
5601 2019-01-15  Tom Tromey  <tom@tromey.com>
5602
5603         * progspace.h (program_space) <objfiles_safe_range>: New
5604         typedef.
5605         <objfiles_safe>: New method.
5606         * objfiles.h (class all_objfiles_safe): Remove.
5607         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5608         * jit.c (jit_inferior_exit_hook): Update.
5609
5610 2019-01-17  Tom Tromey  <tom@tromey.com>
5611
5612         * progspace.h (program_space) <objfiles_range>: New typedef.
5613         <objfiles>: New method.
5614         <objfiles_head>: Rename from objfiles.
5615         (object_files): Update.
5616         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5617         * guile/scm-pretty-print.c
5618         (ppscm_find_pretty_printer_from_objfiles): Update.
5619         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5620         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5621         Update.
5622         * python/py-progspace.c (pspy_get_objfiles): Update.
5623         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5624         Update.
5625         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5626         (objfpy_lookup_objfile_by_build_id): Update.
5627         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5628         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5629         Update.
5630         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5631         (expand_symtab_containing_pc, lookup_objfile_from_block)
5632         (lookup_static_symbol, basic_lookup_transparent_type)
5633         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5634         (find_line_symtab, info_sources_command)
5635         (default_collect_symbol_completion_matches_break_on)
5636         (make_source_files_completion_list, find_main_name): Update.
5637         * symmisc.c (print_symbol_bcache_statistics)
5638         (print_objfile_statistics, maintenance_print_symbols)
5639         (maintenance_print_msymbols, maintenance_print_objfiles)
5640         (maintenance_info_symtabs, maintenance_check_symtabs)
5641         (maintenance_expand_symtabs, maintenance_info_line_tables):
5642         Update.
5643         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5644         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5645         (map_overlay_command, unmap_overlay_command)
5646         (simple_overlay_update, expand_symtabs_matching)
5647         (map_symbol_filenames): Update.
5648         * symfile-debug.c (set_debug_symfile): Update.
5649         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5650         Update.
5651         * source.c (select_source_symtab, forget_cached_source_info):
5652         Update.
5653         * solib.c (solib_read_symbols): Update.
5654         * solib-spu.c (append_ocl_sos): Update.
5655         * psymtab.c (maintenance_print_psymbols)
5656         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5657         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5658         * printcmd.c (info_symbol_command): Update.
5659         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5660         Update.
5661         * objfiles.h (class all_objfiles): Remove.
5662         * objfiles.c (have_partial_symbols, have_full_symbols)
5663         (have_minimal_symbols, qsort_cmp, update_section_map)
5664         (shared_objfile_contains_address_p)
5665         (default_iterate_over_objfiles_in_search_order): Update.
5666         * objc-lang.c (info_selectors_command, info_classes_command)
5667         (find_methods): Update.
5668         * minsyms.c (find_solib_trampoline_target): Update.
5669         * maint.c (maintenance_info_sections)
5670         (maintenance_translate_address, count_symtabs_and_blocks):
5671         Update.
5672         * main.c (captured_main_1): Update.
5673         * linux-thread-db.c (try_thread_db_load_from_pdir)
5674         (has_libpthread): Update.
5675         * linespec.c (iterate_over_all_matching_symtabs)
5676         (search_minsyms_for_name): Update.
5677         * jit.c (jit_find_objf_with_entry_addr): Update.
5678         * hppa-tdep.c (find_unwind_entry)
5679         (hppa_lookup_stub_minimal_symbol): Update.
5680         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5681         Update.
5682         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5683         (elf_gnu_ifunc_resolve_by_got): Update.
5684         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5685         * dwarf-index-write.c (save_gdb_index_command): Update.
5686         * cp-support.c (add_symbol_overload_list_qualified): Update.
5687         * breakpoint.c (create_overlay_event_breakpoint)
5688         (create_longjmp_master_breakpoint)
5689         (create_std_terminate_master_breakpoint)
5690         (create_exception_master_breakpoint): Update.
5691         * blockframe.c (find_pc_partial_function): Update.
5692         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5693         (ada_collect_symbol_completion_matches)
5694         (ada_add_global_exceptions): Update.
5695
5696 2019-01-17  Tom Tromey  <tom@tromey.com>
5697
5698         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5699         declare VEC.
5700         (solib_target_parse_libraries): Change return type.
5701         (library_list_start_segment, library_list_start_section)
5702         (library_list_end_library, library_list_start_library); Update.
5703         (solib_target_free_library_list): Remove.
5704         (solib_target_parse_libraries): Remove cleanup.  Change return
5705         type.
5706         (solib_target_current_sos): Update.
5707
5708 2019-01-17  Tom Tromey  <tromey@bapiya>
5709
5710         * valprint.c: Replace "the the" with "the".
5711         * symtab.c: Replace "the the" with "the".
5712         * solib.c: Replace "the the" with "the".
5713         * solib-dsbt.c: Replace "the the" with "the".
5714         * linespec.c: Replace "the the" with "the".
5715         * dwarf2loc.h: Replace "the the" with "the".
5716         * amd64-windows-tdep.c: Replace "the the" with "the".
5717         * aarch64-tdep.c: Replace "the the" with "the".
5718
5719 2019-01-16  Keith Seitz  <keiths@redhat.com>
5720
5721         PR gdb/23773
5722         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5723         <builder>: Rename to ..
5724         <m_builder>: ... this and make private.
5725         (dwarf2_cu::get_builder): New method.  Change all users of
5726         `builder' to use this method.
5727         (dwarf2_start_symtab): Move to ...
5728         (dwarf2_cu::start_symtab): ... here.  Update all callers
5729         (setup_type_unit_groups): Move to ...
5730         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5731         callers.
5732         (dwarf2_cu::reset_builder): New method.
5733         (process_full_compunit, process_full_type_unit): Use
5734         dwarf2_cu::reset_builder.
5735         (follow_die_offset): Record the ancestor CU if it is different
5736         from the followed DIE's CU.
5737         (follow_die_sig_1): Likewise.
5738
5739 2019-01-15  Tom Tromey  <tom@tromey.com>
5740
5741         * remote.c (class remote_state) <buf>: Now a char_vector.
5742         <buf_size>: Remove.
5743         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5744         parameter.
5745         (remote_target::getpkt_or_notif_sane_1)
5746         (remote_target::getpkt_sane)
5747         (remote_target::getpkt_or_notif_sane): Likewise.
5748         (class remote_target) <putpkt>: New overload.
5749         (remote_target::read_frame): Change type of "buf_p".  Remove
5750         sizeof_p parameter.
5751         (packet_ok): New overload.
5752         (packet_check_result): New overload.
5753         Update all uses.
5754
5755 2019-01-14  Tom Tromey  <tom@tromey.com>
5756
5757         * remote-notif.c (handle_notification, remote_notif_ack)
5758         (remote_notif_parse): Make "buf" const.
5759         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5760         const.
5761         (remote_notif_parse, remote_notif_ack, handle_notification):
5762         Likewise.
5763         * remote.c (remote_notif_stop_parse): Make "buf" const.
5764         (remote_target::remote_parse_stop_reply): Make "buf" const.
5765         (remote_notif_stop_ack): Make "buf" const.
5766
5767 2019-01-14  Tom Tromey  <tom@tromey.com>
5768
5769         * remote.c (remote_console_output): Make parameter const.
5770
5771 2019-01-14  Tom Tromey  <tom@tromey.com>
5772
5773         * target-debug.h (target_debug_print_signals): Constify.
5774         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5775         * procfs.c (procfs_target::pass_signals): Update.
5776         * linux-nat.c (linux_nat_target::pass_signals): Update.
5777         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5778         * target-delegates.c: Rebuild.
5779         * remote.c (remote_target::program_signals): Update.
5780         (remote_target::pass_signals): Update.
5781         * target.c (target_pass_signals): Constify argument.
5782         (target_program_signals): Likewise.
5783         * target.h (struct target_ops) <pass_signals, program_signals>:
5784         Constify argument.
5785         (target_pass_signals, target_program_signals): Constify argument.
5786
5787 2019-01-14  Tom Tromey  <tom@tromey.com>
5788
5789         PR tui/28819:
5790         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5791
5792 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5793
5794         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
5795         field.
5796         * rs6000-tdep.c: Include reggroups.h.
5797         (IS_V_ALIAS_PSEUDOREG): Define.
5798         (rs6000_register_name): Return names for the "vX" aliases.
5799         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
5800         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
5801         aliases.  Call default_register_reggroup_p for all other
5802         pseudo-registers.
5803         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
5804         New functions.
5805         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
5806         Handle "vX" aliases.
5807         (v_alias_pseudo_register_collect): New function.
5808         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
5809         (rs6000_gdbarch_init): Initialize "vX" aliases as
5810         pseudo-registers.  Restore registration of
5811         rs6000_pseudo_register_reggroup_p with
5812         set_tdesc_pseudo_register_reggroup_p.
5813
5814 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
5815
5816         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
5817         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
5818         set_gdbarch_num_pseudo_regs.
5819
5820 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5821
5822         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
5823         Remove arg prefixname, add do_set and do_show.
5824         Add member functions set_list and show_list.
5825         * cli/cli-style.c (class cli_style_option): Update accordingly.
5826         (style_set_list): Move to file scope.
5827         (style_show_list): Likewise.
5828         (set_style): Call help_list.
5829         (show_style): Call cmd_show_list.
5830         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
5831         Update to use the new macro.
5832
5833 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5834
5835         * ada-lang.c (_initialize_ada_language): Expand the help text
5836         for the "catch exception" command.
5837
5838 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5839
5840         * symtab.c (matching_obj_sections): Initialize obj,
5841         declare it closer to its usage.
5842
5843 2019-01-10  Tom Tromey  <tom@tromey.com>
5844
5845         * thread-iter.h (inf_threads_iterator): Use next_iterator.
5846         (basic_inf_threads_range): Remove.
5847         (inf_threads_range, inf_non_exited_threads_range)
5848         (safe_inf_threads_range): Use next_adapter.
5849
5850 2019-01-10  Keith Seitz  <keiths@redhat.com>
5851
5852         PR gdb/23712
5853         PR symtab/23010
5854         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
5855         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
5856
5857 2019-01-10  Keith Seitz  <keiths@redhat.com>
5858
5859         PR gdb/23712
5860         PR symtab/23010
5861         * dictionary.c (pending_to_vector): Remove.
5862         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5863         Remove _1 suffix, replacing functions of the same name.  Update
5864         all callers.
5865         (dict_create_hashed, dict_create_hashed_expandable)
5866         (dict_create_linear, dict_create_linear_expandable, dict_free)
5867         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
5868         Make functions static.
5869
5870 2019-01-10  Keith Seitz  <keiths@redhat.com>
5871
5872         PR gdb/23712
5873         PR symtab/23010
5874         * dictionary.h (struct dictionary): Replace declaration with
5875         multidictionary.
5876         (dict_create_hashed, dict_create_hashed_expandable)
5877         (dict_create_linear, dict_create_linear_expandable)
5878         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
5879         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
5880         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
5881         taking multidictionary argument.
5882         [ALL_DICT_SYMBOLS]: Update for multidictionary.
5883         * block.h (struct block) <dict>: Change to multidictionary
5884         and rename `multidict'.
5885         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
5886         symmisc.c: Update all dictionary references to multidictionary.
5887
5888 2019-01-10  Keith Seitz  <keiths@redhat.com>
5889
5890         PR gdb/23712
5891         PR symtab/23010
5892         * dictionary.c: Include unordered_map.
5893         (pending_to_vector): New function.
5894         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5895         Rewrite the non-"_1" functions to take vector instead
5896         of linked list.
5897         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
5898         "new" _1 versions of the same name.
5899         (multidictionary): Define.
5900         (std::hash<enum language): New definition.
5901         (collate_pending_symbols_by_language, mdict_create_hashed)
5902         (mdict_create_hashed_expandable, mdict_create_linear)
5903         (mdict_create_linear_expandable, mdict_free)
5904         (find_language_dictionary, create_new_language_dictionary)
5905         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
5906         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
5907         (mdict_size, mdict_empty): New functions.
5908         * dictionary.h (mdict_iterator): Define.
5909
5910 2019-01-10  Pedro Alves  <palves@redhat.com>
5911
5912         * breakpoint.c (read_uploaded_action)
5913         (create_tracepoint_from_upload): Adjust to use
5914         gdb::unique_xmalloc_ptr.
5915         * ctf.c (ctf_write_uploaded_tp):
5916         (SET_ARRAY_FIELD): Use emplace_back.
5917         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
5918         * tracefile-tfile.c (tfile_write_uploaded_tp):
5919         * tracepoint.c (parse_tracepoint_definition): Adjust to use
5920         gdb::unique_xmalloc_ptr.
5921         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
5922         at_string, cond_string, cmd_strings>: Replace char pointers
5923         with gdb::unique_xmalloc_ptr.
5924
5925 2019-01-10  Pedro Alves  <palves@redhat.com>
5926
5927         * solib-target.c (library_list_start_library): Don't xstrdup name.
5928
5929 2019-01-10  Pedro Alves  <palves@redhat.com>
5930
5931         * mdebugread.c (parse_partial_symbols): Use
5932         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
5933
5934 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5935
5936         * linux-fork.c (scoped_switch_fork_info)
5937         <~scoped_switch_fork_info>: Fix incorrect variable name.
5938
5939 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5940
5941         * linux-fork.c (scoped_switch_fork_info)
5942         <scoped_switch_fork_info>: Make explicit.
5943         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
5944
5945 2019-01-10  Tom Tromey  <tom@tromey.com>
5946
5947         * objfiles.h (objfile::reset_psymtabs): Update.
5948         * objfiles.c (objfile::objfile): Update.
5949         * psymtab.h (psymtab_storage::obstack): Update.
5950         (psymtab_storage::m_obstack): Use gdb::optional.
5951         (class psymtab_storage): Update comment.  Remove objfile
5952         parameter.
5953         * psymtab.c (psymtab_storage::psymtab_storage): Update.
5954
5955 2019-01-10  Tom Tromey  <tom@tromey.com>
5956
5957         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
5958         <free_psymtabs>: Now private.
5959         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
5960         (allocate_psymtab): Use new method.
5961
5962 2019-01-10  Tom Tromey  <tom@tromey.com>
5963
5964         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
5965         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
5966         * mdebugread.c (parse_partial_symbols): Use
5967         allocate_dependencies.
5968         * dwarf2read.c (dwarf2_create_include_psymtab): Use
5969         allocate_dependencies.
5970         (process_psymtab_comp_unit_reader)
5971         (build_type_psymtab_dependencies): Likewise.
5972         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
5973
5974 2019-01-10  Tom Tromey  <tom@tromey.com>
5975
5976         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
5977         PSYMBOL_SET_LANGUAGE.
5978         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
5979
5980 2019-01-10  Tom Tromey  <tom@tromey.com>
5981
5982         * psymtab.h (psymtab_storage::obstack): New method.
5983         <m_obstack>: Rename from obstack; now private.
5984         * psymtab.c (psymtab_storage): Update.
5985         * dwarf2read.c (create_addrmap_from_index)
5986         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
5987         Update.
5988
5989 2019-01-10  Tom Tromey  <tom@tromey.com>
5990
5991         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
5992         * objfiles.h (objfile::reset_psymtabs): New method.
5993
5994 2019-01-10  Tom Tromey  <tom@tromey.com>
5995
5996         * symmisc.c (print_symbol_bcache_statistics): Update.
5997         (print_objfile_statistics): Update.
5998         * symfile.c (reread_symbols): Update.
5999         * psymtab.h (class psymtab_storage): New.
6000         * psymtab.c (psymtab_storage): New constructor.
6001         (~psymtab_storage): New destructor.
6002         (require_partial_symbols): Update.
6003         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
6004         (find_pc_sect_psymtab, find_pc_sect_psymbol)
6005         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
6006         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
6007         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
6008         (start_psymtab_common, end_psymtab_common)
6009         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
6010         (allocate_psymtab): Update.
6011         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
6012         Update.
6013         (dump_psymtab_addrmap, maintenance_print_psymbols)
6014         (maintenance_check_psymtabs): Update.
6015         (class objfile_psymtabs): Move to objfiles.h.
6016         * psympriv.h (discard_psymtab): Now inline.
6017         (psymtab_discarder::psymtab_discarder): Update.
6018         (psymtab_discarder::~psymtab_discarder): Update.
6019         (ALL_OBJFILE_PSYMTABS): Rewrite.
6020         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
6021         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
6022         Remove fields.
6023         <partial_symtabs>: New field.
6024         (class objfile_psymtabs): Move from psymtab.h.  Update.
6025         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
6026         psymbol_cache.
6027         (objfile::~objfile): Don't destroy psymbol_cache.
6028         * mdebugread.c (parse_partial_symbols): Update.
6029         * dwarf2read.c (create_addrmap_from_index)
6030         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
6031         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
6032         (add_partial_subprogram, dwarf2_ranges_read): Update.
6033         * dwarf-index-write.c (write_address_map)
6034         (write_one_signatured_type, recursively_write_psymbols)
6035         (class debug_names, class debug_names, write_psymtabs_to_index):
6036         Update.
6037
6038 2019-01-10  Tom Tromey  <tom@tromey.com>
6039
6040         * symtab.h (SYMBOL_SET_NAMES): Update.
6041         (symbol_set_names): Update.
6042         (MSYMBOL_SET_NAMES): Update.
6043         * symtab.c (symbol_set_names): Change argument to be an
6044         objfile_per_bfd_storage.
6045         * psymtab.c (add_psymbol_to_bcache): Update.
6046         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
6047
6048 2019-01-10  Tom Tromey  <tom@tromey.com>
6049
6050         * symtab.c (create_demangled_names_hash): Change argument to be an
6051         objfile_per_bfd_storage.
6052         (symbol_set_names): Update.
6053
6054 2019-01-10  Tom Tromey  <tom@tromey.com>
6055
6056         * xcoffread.c (xcoff_initial_scan): Unconditionally call
6057         init_psymbol_list.
6058         * psymtab.c (init_psymbol_list): Do nothing if already called.
6059         * psympriv.h (init_psymbol_list): Add comment.
6060         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
6061         init_psymbol_list.
6062         * dbxread.c (dbx_symfile_read): Unconditionally call
6063         init_psymbol_list.
6064
6065 2019-01-10  Tom Tromey  <tom@tromey.com>
6066
6067         * xcoffread.c (scan_xcoff_symtab): Update.
6068         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
6069         "where".
6070         * mdebugread.c (parse_partial_symbols)
6071         (handle_psymbol_enumerators): Update.
6072         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
6073         * dbxread.c (read_dbx_symtab): Update.
6074         * psympriv.h (psymbol_placement): New enum.
6075         (add_psymbol_to_list): Update.
6076
6077 2019-01-10  Tom Tromey  <tom@tromey.com>
6078
6079         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
6080         static_psymbols parameters.
6081         (scan_xcoff_symtab): Update.
6082         * psymtab.c (start_psymtab_common): Remove global_psymbols and
6083         static_psymbols parameters.
6084         * psympriv.h (start_psymtab_common): Update.
6085         * mdebugread.c (parse_partial_symbols): Update.
6086         * dwarf2read.c (create_partial_symtab): Update.
6087         * dbxread.c (read_dbx_symtab): Update.
6088         (start_psymtab): Remove global_psymbols and static_psymbols
6089         parameters.
6090
6091 2019-01-10  Tom Tromey  <tom@tromey.com>
6092
6093         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
6094         * psymtab.c (allocate_psymtab): Add comment.
6095         * psympriv.h (allocate_psymtab): Add comment.
6096         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
6097         initializations.
6098         * dbxread.c (dbx_end_psymtab): Remove some initializations.
6099
6100 2019-01-10  Tom Tromey  <tom@tromey.com>
6101
6102         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6103         Don't declare.
6104         * mipsread.c: Include mdebugread.h.
6105         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6106         Declare.
6107         * elfread.c: Include mdebugread.h.
6108
6109 2019-01-09  Tom Tromey  <tom@tromey.com>
6110
6111         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
6112         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
6113         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
6114         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
6115         (psym_lookup_symbol, psym_find_last_source_symtab)
6116         (psym_forget_cached_source_info, psym_print_stats)
6117         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
6118         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
6119         (psym_map_matching_symbols, psym_expand_symtabs_matching)
6120         (psym_find_compunit_symtab_by_address)
6121         (maintenance_print_psymbols, maintenance_info_psymtabs)
6122         (maintenance_check_psymtabs): Use ranged for.
6123         * psymtab.h (class objfile_psymtabs): New.
6124         (require_partial_symbols): Return objfile_psymtabs.
6125         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
6126
6127 2019-01-09  Tom Tromey  <tom@tromey.com>
6128
6129         * symfile.c (overlay_invalidate_all, find_pc_overlay)
6130         (find_pc_mapped_section, list_overlays_command)
6131         (map_overlay_command, unmap_overlay_command)
6132         (simple_overlay_update): Use all_objfiles.
6133         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
6134         * printcmd.c (info_symbol_command): Use all_objfiles.
6135         * objfiles.h (ALL_OBJSECTIONS): Remove.
6136         * maint.c (maintenance_translate_address): Use all_objfiles.
6137         * gcore.c (gcore_create_callback): Use all_objfiles.
6138         (objfile_find_memory_regions): Likewise.
6139
6140 2019-01-09  Tom Tromey  <tom@tromey.com>
6141
6142         * symtab.c (find_line_symtab, info_sources_command)
6143         (make_source_files_completion_list): Use objfile_compunits.
6144         * source.c (select_source_symtab): Use objfile_compunits.
6145         * objfiles.h (struct objfile): Update comment.
6146         (ALL_OBJFILES): Remove.
6147         (ALL_FILETABS): Remove.
6148         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
6149         objfile_compunits.
6150
6151 2019-01-09  Tom Tromey  <tom@tromey.com>
6152
6153         * symmisc.c (print_objfile_statistics, dump_objfile)
6154         (maintenance_print_symbols): Use compunit_filetabs.
6155         * source.c (forget_cached_source_info_for_objfile): Use
6156         compunit_filetabs.
6157         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
6158         (ALL_FILETABS): Use compunit_filetabs.
6159         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
6160         * coffread.c (coff_symtab_read): Use compunit_filetabs.
6161
6162 2019-01-09  Tom Tromey  <tom@tromey.com>
6163
6164         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
6165         (compunit_filetabs): New.
6166         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
6167         compunit_filetabs.
6168         (info_sources_command, make_source_files_completion_list): Remove
6169         declaration.
6170         * symmisc.c (print_objfile_statistics, dump_objfile)
6171         (maintenance_print_symbols): Remove declaration.
6172         (maintenance_info_symtabs): Use compunit_filetabs.
6173         (maintenance_info_line_tables): Likewise.
6174         * source.c (select_source_symtab): Change local variable name.
6175         (forget_cached_source_info_for_objfile): Remove declaration.
6176         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
6177         * objfiles.c (objfile_relocate1): Remove declaration.
6178         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6179         declaration.
6180         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
6181         * coffread.c (coff_symtab_read): Remove declaration.
6182         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6183         compunit_filetabs.
6184
6185 2019-01-09  Tom Tromey  <tom@tromey.com>
6186
6187         * symtab.c (lookup_objfile_from_block)
6188         (find_pc_sect_compunit_symtab, search_symbols)
6189         (default_collect_symbol_completion_matches_break_on): Use
6190         objfile_compunits.
6191         * objfiles.h (ALL_COMPUNITS): Remove.
6192         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
6193         * cp-support.c (add_symbol_overload_list_qualified): Use
6194         objfile_compunits.
6195         * ada-lang.c (ada_collect_symbol_completion_matches)
6196         (ada_add_global_exceptions): Use objfile_compunits.
6197
6198 2019-01-09  Tom Tromey  <tom@tromey.com>
6199
6200         * source.c (select_source_symtab)
6201         (forget_cached_source_info_for_objfile): Remove declaration.
6202         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6203         declaration.
6204         * maint.c (count_symtabs_and_blocks): Remove declaration.
6205         * cp-support.c (add_symbol_overload_list_qualified): Remove
6206         declaration.
6207         * coffread.c (coff_symtab_read): Remove declaration.
6208         * symtab.c (lookup_symbol_in_objfile_symtabs)
6209         (basic_lookup_transparent_type_1): Use objfile_compunits.
6210         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
6211         (info_sources_command, search_symbols)
6212         (default_collect_symbol_completion_matches_break_on)
6213         (make_source_files_completion_list): Remove declaration.
6214         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
6215         (ada_collect_symbol_completion_matches)
6216         (ada_add_global_exceptions): Remove declaration.
6217         * linespec.c (iterate_over_all_matching_symtabs): Use
6218         objfile_compunits.
6219         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
6220         (class objfile_compunits): New.
6221         (ALL_COMPUNITS): Use objfile_compunits.
6222         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
6223         (maintenance_check_symtabs, maintenance_info_line_tables): Use
6224         objfile_compunits.
6225         * objfiles.c (objfile_relocate1): Use objfile_compunits.
6226
6227 2019-01-09  Tom Tromey  <tom@tromey.com>
6228
6229         * symtab.c (search_symbols)
6230         (default_collect_symbol_completion_matches_break_on): Use
6231         objfile_msymbols.
6232         * ada-lang.c (ada_lookup_simple_minsym)
6233         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
6234         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
6235         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
6236         objfile_msymbols.
6237         * coffread.c (coff_symfile_read): Use objfile_msymbols.
6238         * symmisc.c (dump_msymbols): Use objfile_msymbols.
6239         * objc-lang.c (find_methods): Use objfile_msymbols.
6240         (info_selectors_command, info_classes_command): Likewise.
6241         * stabsread.c (scan_file_globals): Use objfile_msymbols.
6242         * objfiles.h (class objfile_msymbols): New.
6243         (ALL_OBJFILE_MSYMBOLS): Remove.
6244         (ALL_MSYMBOLS): Remove.
6245
6246 2019-01-09  Tom Tromey  <tom@tromey.com>
6247
6248         * common/next-iterator.h (next_adapter): Add Iterator template
6249         parameter.
6250         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
6251         (class all_objfiles_safe): New.
6252         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
6253         * objfiles.c (put_objfile_before): Update comment.
6254         (add_separate_debug_objfile): Likewise.
6255         (free_all_objfiles): Use all_objfiles_safe.
6256         (objfile_purge_solibs): Likewise.
6257
6258 2019-01-09  Tom Tromey  <tom@tromey.com>
6259
6260         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6261         (expand_symtab_containing_pc, lookup_static_symbol)
6262         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
6263         (find_symbol_at_address, find_line_symtab, find_main_name): Use
6264         all_objfiles.
6265         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
6266         * breakpoint.c (create_overlay_event_breakpoint)
6267         (create_longjmp_master_breakpoint)
6268         (create_std_terminate_master_breakpoint)
6269         (create_exception_master_breakpoint): Use all_objfiles.
6270         * linux-thread-db.c (try_thread_db_load_from_pdir)
6271         (has_libpthread): Use all_objfiles.
6272         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
6273         * linespec.c (iterate_over_all_matching_symtabs)
6274         (search_minsyms_for_name): Use all_objfiles.
6275         * maint.c (maintenance_info_sections): Use all_objfiles.
6276         * main.c (captured_main_1): Use all_objfiles.
6277         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
6278         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
6279         * guile/scm-pretty-print.c
6280         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
6281         * solib-spu.c (append_ocl_sos): Use all_objfiles.
6282         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
6283         (maintenance_print_msymbols): Use all_objfiles.
6284         * source.c (select_source_symtab): Use all_objfiles.
6285         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
6286         * symfile.c (remove_symbol_file_command)
6287         (expand_symtabs_matching, map_symbol_filenames): Use
6288         all_objfiles.
6289         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
6290         all_objfiles.
6291         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
6292         * objc-lang.c (find_methods): Use all_objfiles.
6293         * objfiles.c (have_partial_symbols, have_full_symbols)
6294         (have_minimal_symbols, qsort_cmp)
6295         (default_iterate_over_objfiles_in_search_order): Use
6296         all_objfiles.
6297         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
6298         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
6299         (maintenance_check_psymtabs): Use all_objfiles.
6300         (ALL_PSYMTABS): Remove.
6301         * compile/compile-object-run.c (do_module_cleanup): Use
6302         all_objfiles.
6303         * blockframe.c (find_pc_partial_function): Use all_objfiles.
6304         * cp-support.c (add_symbol_overload_list_qualified): Use
6305         all_objfiles.
6306         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6307         Use all_objfiles.
6308         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
6309         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
6310         all_objfiles.
6311         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6312         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
6313         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6314         Uses all_objfiles.
6315         * solib.c (solib_read_symbols): Use all_objfiles
6316
6317 2019-01-09  Tom Tromey  <tom@tromey.com>
6318
6319         * probe.c (parse_probes_in_pspace): Use all_objfiles.
6320         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
6321         all_objfiles.
6322         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
6323         * symmisc.c (print_symbol_bcache_statistics)
6324         (print_objfile_statistics, maintenance_print_objfiles)
6325         (maintenance_info_symtabs, maintenance_check_symtabs)
6326         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
6327         all_objfiles.
6328         * source.c (forget_cached_source_info): Use all_objfiles.
6329         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
6330         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6331         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
6332         * objfiles.c (update_section_map): Use all_objfiles.
6333         (shared_objfile_contains_address_p): Likewise.
6334         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
6335         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
6336
6337 2019-01-09  Tom Tromey  <tom@tromey.com>
6338
6339         * common/next-iterator.h: New file.
6340         * objfiles.h (class all_objfiles): New.
6341         (struct objfile_iterator): New.
6342
6343 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6344
6345         * NEWS: Move the description of the changed "frame", "select-frame",
6346          and "info frame" commands to the Changed commands section.
6347
6348 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
6349
6350         * gdbtypes.c (check_stub_method_group): Remove handling of old
6351         mangling schemes.
6352         * linespec.c (find_methods): Likewise.
6353         * stabsread.c (read_member_functions): Likewise.
6354         * valops.c (search_struct_method): Likewise.
6355         (value_struct_elt_for_reference): Likewise.
6356         * NEWS: Mention this change.
6357
6358 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6359
6360         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
6361         print_source_lines.
6362         * source.c (print_source_lines_base): Update line number check.
6363         (print_source_lines): New function.
6364         (source_lines_range::source_lines_range): New function.
6365         * source.h (class source_lines_range): New class.
6366         (print_source_lines): New declaration.
6367
6368 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6369
6370         * linespec.c (linespec_state_destructor): Free self->canonical_names.
6371
6372 2019-01-08  Tom Tromey  <tom@tromey.com>
6373             Simon Marchi  <simon.marchi@ericsson.com>
6374
6375         PR gdb/24060
6376         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
6377         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
6378         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6379         * f-exp.y (DOLLAR_VARIABLE): Likewise.
6380         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
6381         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6382
6383 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6384
6385         * source.c (select_source_symtab): Move header comment to
6386         declaration in source.h.
6387         (forget_cached_source_info_for_objfile): Likewise.
6388         (forget_cached_source_info): Likewise.
6389         (identify_source_line): Likewise.
6390         * source.h (identify_source_line): Move declaration from symtab.h
6391         and add comment from source.c
6392         (print_source_lines): Likewise.
6393         (forget_cached_source_info_for_objfile): Likewise.
6394         (forget_cached_source_info): Likewise.
6395         (select_source_symtab): Likewise.
6396         (enum print_source_lines_flag): Move definition from symtab.h.
6397         * symtab.h (identify_source_line): Move declaration to source.h.
6398         (print_source_lines): Likewise.
6399         (forget_cached_source_info_for_objfile): Likewise.
6400         (forget_cached_source_info): Likewise.
6401         (select_source_symtab): Likewise.
6402         (enum print_source_lines_flag): Move definition to source.h.
6403         * tui/tui-hooks.c: Add 'source.h' include.
6404
6405 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6406
6407         * source.c (print_source_lines_base): Handle requests to print
6408         reverse line number sequences, and guard against empty lines
6409         string.
6410
6411 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6412
6413         * source.c (print_source_lines_base): Fix skip of '\r' if next
6414         character is '\n'.
6415
6416 2019-01-06  Tom Tromey  <tom@tromey.com>
6417
6418         * c-exp.y (struct c_parse_state) <macro_original_text,
6419         expansion_obstack>: New member.
6420         (macro_original_text, expansion_obstack): Remove globals.
6421         (scan_macro_expansion, scanning_macro_expansion)
6422         (finished_macro_expansion): Update.
6423         (scan_macro_cleanup): Remove.
6424         (yylex, c_parse): Update.
6425
6426 2019-01-06  Tom Tromey  <tom@tromey.com>
6427
6428         * c-exp.y (struct c_parse_state) <strings>: New member.
6429         (operator_stoken): Update.
6430
6431 2019-01-06  Tom Tromey  <tom@tromey.com>
6432
6433         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6434         (union type_stack_elt) <typelist_val>: Now a pointer to
6435         std::vector.
6436         (type_stack_cleanup): Don't declare.
6437         (push_typelist): Update.
6438         * parse.c (pop_typelist): Return a std::vector.
6439         (push_typelist): Take a std::vector.
6440         (follow_types): Update.  Do not free args.
6441         (type_stack_cleanup): Remove.
6442         * c-exp.y (struct c_parse_state): New.
6443         (cpstate): New global.
6444         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6445         (nonempty_typelist): Update.
6446         (func_mod): Create a new vector.
6447         (c_parse): Create a c_parse_state.
6448         (check_parameter_typelist): Do not delete params.
6449         (function_method): Update.  Do not delete type_list.
6450
6451 2019-01-06  Tom Tromey  <tom@tromey.com>
6452
6453         PR gdb/28155:
6454         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6455         check_typedef.
6456         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6457         (print_return_value): Likewise.
6458
6459 2019-01-05  Tom Tromey  <tom@tromey.com>
6460
6461         * contrib/cleanup_check.py: Remove.
6462         * contrib/gcc-with-excheck: Remove.
6463         * contrib/exsummary.py: Remove.
6464         * contrib/excheck.py: Remove.
6465
6466 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6467
6468         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6469         NULL. Initialize tpprev to NULL instead of assigning it
6470         to NULL on the next statement.
6471         * windows-nat.c (windows_delete_thread): Remove check for
6472         main_thread_id before printing thread exit notifications.
6473         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6474         Remove thread ID check against main_thread_id.
6475         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6476         windows_delete_thread.
6477         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6478
6479 2019-01-04  Tom Tromey  <tom@tromey.com>
6480
6481         * compile/compile.c (_initialize_compile): Use upper case for
6482         metasyntactic variables.
6483         * symmisc.c (_initialize_symmisc): Use upper case for
6484         metasyntactic variables.
6485         * psymtab.c (_initialize_psymtab): Use upper case for
6486         metasyntactic variables.
6487         * demangle.c (demangle_command): Use upper case for metasyntactic
6488         variables.
6489         (_initialize_demangler): Likewise.
6490         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6491         variables.
6492
6493 2019-01-03  Tom Tromey  <tom@tromey.com>
6494
6495         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6496
6497 2019-01-03  Tom Tromey  <tom@tromey.com>
6498
6499         * python/py-symtab.c (salpy_str): Update.
6500         (struct salpy_sal_object) <symtab>: Now a PyObject.
6501         (salpy_dealloc): Update.
6502         (del_objfile_sal): Use gdbpy_ref.
6503
6504 2019-01-03  Tom Tromey  <tom@tromey.com>
6505
6506         * python/py-type.c (convert_field): Use new_reference.  Return
6507         gdbpy_ref.
6508         (make_fielditem): Return gdbpy_ref.
6509         (typy_fields): Update.
6510         (typy_getitem): Update.
6511         (field_name): Return gdbpy_ref.  Use new_reference.
6512         (typy_iterator_iternext): Update.
6513
6514 2019-01-03  Tom Tromey  <tom@tromey.com>
6515
6516         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6517
6518 2019-01-03  Tom Tromey  <tom@tromey.com>
6519
6520         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6521         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6522         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6523         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6524         (pspy_set_type_printers): Likewise.
6525         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6526         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6527         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6528         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6529         (objfpy_set_type_printers): Likewise.
6530
6531 2019-01-03  Tom Tromey  <tom@tromey.com>
6532
6533         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6534         (gdbpy_print_stack): Use gdbpy_err_fetch.
6535         * python/python-internal.h (class gdbpy_err_fetch): New class.
6536         (class gdbpy_enter) <m_error_type, m_error_value,
6537         m_error_traceback>: Remove.
6538         <m_error>: New member.
6539         (gdbpy_exception_to_string): Don't declare.
6540         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6541         * python/py-value.c (convert_value_from_python): Use
6542         gdbpy_err_fetch.
6543         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6544         gdbpy_exception_to_string.
6545         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6546         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6547         gdbpy_err_fetch.
6548
6549 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6550
6551         * linux-nat.c (delete_lwp_cleanup): Delete.
6552         (struct lwp_deleter): New struct.
6553         (lwp_info_up): New typedef.
6554         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6555         lwp_info_up.
6556
6557 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6558
6559         * linux-fork.c (class scoped_switch_fork_info): New class.
6560         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6561
6562 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6563
6564         * valops.c (find_overload_match): Remove use of null_cleanup, and
6565         calls to do_cleanups.
6566
6567 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6568
6569         * compile/compile-cplus-types.c
6570         (compile_cplus_instance::decl_name): Handle changes to
6571         cp_func_name.
6572         * cp-support.c (cp_func_name): Update header comment, update
6573         return type.
6574         * cp-support.h (cp_func_name): Update return type in declaration.
6575         * valops.c (find_overload_match): Move temp_func local to top
6576         level of function and change its type.  Use temp_func to hold and
6577         delete temporary string obtained from cp_func_name.
6578
6579 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6580
6581         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6582         gdb::char_vector, remove cleanup, and update uses of `msg`.
6583
6584 2019-01-03  Jim Wilson  <jimw@sifive.com>
6585
6586         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6587
6588 2019-01-02  Tom Tromey  <tom@tromey.com>
6589
6590         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6591         (tdesc_parse_xml): Remove cleanups.
6592         * target-descriptions.h (make_cleanup_free_target_description):
6593         Don't declare.
6594         (target_desc_deleter): New struct.
6595         (target_desc_up): New typedef.
6596         * target-descriptions.c (target_desc_deleter::operator()): Rename
6597         from free_target_description.
6598         (make_cleanup_free_target_description): Remove.
6599
6600 2019-01-02  Tom Tromey  <tom@tromey.com>
6601
6602         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6603         constructor, destructor.
6604         (linespec_parser): Remove typedef.
6605         (~linespec_parser): Rename from linespec_parser_delete.
6606         (linespec_lex_to_end, linespec_complete_label)
6607         (linespec_complete): Update.
6608         (decode_line_full): Remove cleanups.
6609         (decode_line_1): Update.
6610
6611 2019-01-02  Tom Tromey  <tom@tromey.com>
6612
6613         * python/python-internal.h (inferior_to_inferior_object): Change
6614         return type.
6615         * python/py-exitedevent.c (create_exited_event_object): Update.
6616         * python/py-inferior.c (inferior_to_inferior_object): Return
6617         gdbpy_ref.
6618         (python_new_inferior, python_inferior_deleted)
6619         (thread_to_thread_object, delete_thread_object)
6620         (build_inferior_list, gdbpy_selected_inferior): Update.
6621         * python/py-infthread.c (create_thread_object): Update.  Also fail
6622         if inferior_to_inferior_object fails.
6623
6624 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6625
6626         * inferior.h (class inferior) <displaced_step_state>: New field.
6627         * infrun.h (struct displaced_step_state): Move here from
6628         infrun.c.  Initialize fields, add constructor.
6629         <inf>: Remove field.
6630         <reset>: New method.
6631         * infrun.c (struct displaced_step_inferior_state): Move to
6632         infrun.h.
6633         (displaced_step_inferior_states): Remove.
6634         (get_displaced_stepping_state): Adust.
6635         (displaced_step_in_progress_any_inferior): Adjust.
6636         (displaced_step_in_progress_thread): Adjust.
6637         (displaced_step_in_progress): Adjust.
6638         (add_displaced_stepping_state): Remove.
6639         (get_displaced_step_closure_by_addr): Adjust.
6640         (remove_displaced_stepping_state): Remove.
6641         (infrun_inferior_exit): Call displaced_step_state.reset.
6642         (use_displaced_stepping): Don't check for NULL.
6643         (displaced_step_prepare_throw): Call
6644         get_displaced_stepping_state.
6645         (displaced_step_fixup): Don't check for NULL.
6646         (prepare_for_detach): Don't check for NULL.
6647
6648 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6649
6650         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6651          in case of call that did not complete.
6652
6653 2019-01-02  Andrey Utkin  <autkin@undo.io>
6654
6655         * symfile.c (find_separate_debug_file): Fix search of debug files for
6656         remote debuggee.
6657
6658 2019-01-02  Tom Tromey  <tom@tromey.com>
6659
6660         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6661         indentation.
6662         * python/py-frame.c (frapy_older): Remove cast.
6663         (frapy_newer): Likewise.
6664         * python/py-breakpoint.c (local_setattro): Remove cast.
6665         * python/py-arch.c (archpy_name): Remove local variable.
6666         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6667
6668 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6669
6670         * unittests/basic_string_view/element_access/char/empty.cc:
6671         Fix year range in copyright header.
6672
6673 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6674
6675         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6676         Delete.
6677         <operator==>: Update with for removed field.
6678         <hash>: Likewise.
6679         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6680         <isa_features>: ...this.
6681         <abi_features>: New field.
6682         (riscv_isa_flen): Update comment.
6683         (riscv_abi_xlen): New declaration.
6684         (riscv_abi_flen): New declaration.
6685         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6686         isa_features.
6687         (riscv_abi_xlen): New function.
6688         (riscv_isa_flen): Update to get answer from isa_features.
6689         (riscv_abi_flen): New function.
6690         (riscv_has_fp_abi): Update to get answer from abi_features.
6691         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6692         xlen and flen.
6693         (riscv_call_info) <xlen, flen>: Update comment.
6694         (riscv_call_arg_struct): Remove invalid assertions
6695         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6696         is removed.
6697         (riscv_gdbarch_init): Gather isa features and abi features
6698         separately, ensure both match on the gdbarch when reusing an old
6699         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6700         a target with 64-bit float hardware.
6701
6702 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6703
6704         * source.c (search_command_helper): Stop reverse search
6705         when line 1 has been searched.
6706
6707 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6708
6709         * record-full.c (record_full_base_target::close): Rewrite
6710         record_full_core_buf_list free logic.
6711
6712 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6713
6714         * break-catch-syscall.c (print_one_catch_syscall): xfree
6715         the last text.
6716
6717 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6718
6719         * top.c (print_gdb_version): Update Copyright year in version
6720         message.
6721
6722 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6723
6724         Update copyright year range in all GDB files.
6725
6726 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6727
6728         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6729
6730 For older changes see ChangeLog-2018.
6731 \f
6732 Local Variables:
6733 mode: change-log
6734 left-margin: 8
6735 fill-column: 74
6736 version-control: never
6737 coding: utf-8
6738 End:
6739