gdb/ChangeLog

   1 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
   2
   3         * MAINTAINERS (Write After Approval): Add self.
   4
   5 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
   6
   7         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
   8         instruction to the dummy code region.
   9
  10 2019-07-19  Tom Tromey  <tromey@adacore.com>
  11
  12         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
  13         (ARGSUSED, PARAMS, __func__): Remove rules.
  14
  15 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
  16
  17         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
  18         * features/arm/arm-with-iwmmxt.c: Remove.
  19         * features/arm/arm-with-iwmmxt.xml: Remove.
  20         * features/arm/arm-with-m-fpa-layout.c: Remove.
  21         * features/arm/arm-with-m-fpa-layout.xml: Remove.
  22         * features/arm/arm-with-m-vfp-d16.c: Remove.
  23         * features/arm/arm-with-m-vfp-d16.xml: Remove.
  24         * features/arm/arm-with-m.c: Remove.
  25         * features/arm/arm-with-m.xml: Remove.
  26         * features/arm/arm-with-neon.c: Remove.
  27         * features/arm/arm-with-neon.xml: Remove.
  28         * features/arm/arm-with-vfpv2.c: Remove.
  29         * features/arm/arm-with-vfpv2.xml: Remove.
  30         * features/arm/arm-with-vfpv3.c: Remove.
  31         * features/arm/arm-with-vfpv3.xml: Remove.
  32
  33 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
  34
  35         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
  36
  37 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
  38
  39         * arch/aarch32.c (aarch32_create_target_description): Create
  40         target descriptions using features.
  41         * arch/arm.c (arm_create_target_description)
  42         (arm_create_mprofile_target_description): Likewise.
  43         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
  44
  45 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
  46
  47         * Makefile.in: Add new files.
  48         * aarch32-tdep.c: New file.
  49         * aarch32-tdep.h: New file.
  50         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
  51         Call aarch32_read_description.
  52         * arch/aarch32.c: New file.
  53         * arch/aarch32.h: New file.
  54         * arch/arm.c (arm_create_target_description)
  55         (arm_create_mprofile_target_description): New function.
  56         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
  57         (arm_create_target_description)
  58         (arm_create_mprofile_target_description): New declaration.
  59         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
  60         read_description functions.
  61         * arm-linux-nat.c (arm_linux_nat_target::read_description):
  62         Likewise.
  63         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
  64         * arm-tdep.c (tdesc_arm_list): New variable.
  65         (arm_register_g_packet_guesses): Call create description functions.
  66         (arm_read_description) (arm_read_mprofile_description): New
  67         function.
  68         * arm-tdep.h (arm_read_description)
  69         (arm_read_mprofile_description): Add declaration.
  70         * configure.tgt: Add new files.
  71
  72 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
  73
  74         * top.c (new_ui_command): Open specified terminal just once.
  75
  76 2019-07-18  Tom Tromey  <tromey@adacore.com>
  77
  78         * symtab.c (main_name): Constify return type.
  79         * symfile.c (set_initial_language): Update.
  80         * symtab.h (main_name): Constify return type.
  81
  82 2019-07-17  Tom Tromey  <tom@tromey.com>
  83
  84         * tui/tui-winsource.c (tui_update_source_window)
  85         (tui_update_source_window_as_is)
  86         (tui_update_source_windows_with_line): Remove return.
  87         * tui/tui-disasm.c (tui_show_disassem)
  88         (tui_show_disassem_and_update_source): Remove return.
  89         * tui/tui.c (tui_reset): Remove return.
  90         * tui/tui-wingeneral.c
  91         (tui_check_and_display_highlight_if_needed): Remove return.
  92
  93 2019-07-17  Tom Tromey  <tom@tromey.com>
  94
  95         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
  96
  97 2019-07-17  Tom Tromey  <tom@tromey.com>
  98
  99         * tui/tui-winsource.h (struct tui_exec_info_window)
 100         (struct tui_source_window_base): Move from tui-data.h.
 101         * tui/tui-winsource.c: Move many method definitions from
 102         elsewhere.  Remove "structuring" comments.
 103         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
 104         (tui_source_window_base::refresh_window): Move to
 105         tui-winsource.c.
 106         * tui/tui-win.c (tui_source_window_base::refresh_all)
 107         (tui_source_window_base::update_tab_width)
 108         (tui_source_window_base::set_new_height)
 109         (tui_source_window_base::do_make_visible_with_new_height): Move to
 110         tui-winsource.c.
 111         * tui/tui-source.h: Update.
 112         * tui/tui-source.c (tui_source_window_base::reset): Move to
 113         tui-winsource.c.
 114         * tui/tui-disasm.h: Update.
 115         * tui/tui-data.h (struct tui_exec_info_window): Move to
 116         tui-winsource.h.
 117         (struct tui_source_window_base): Likewise.
 118         * tui/tui-data.c (tui_source_window_base::clear_detail)
 119         (tui_source_window_base, ~tui_source_window_base): Move to
 120         tui-winsource.c.
 121
 122 2019-07-17  Tom Tromey  <tom@tromey.com>
 123
 124         * tui/tui-win.c (tui_resize_all)
 125         (tui_source_window_base::update_tab_width)
 126         (tui_adjust_win_heights): Update.
 127         (tui_win_info::make_invisible_and_set_new_height): Rename from
 128         make_invisible_and_set_new_height.
 129         * tui/tui-data.h (struct tui_win_info)
 130         <make_invisible_and_set_new_height>: New method.
 131
 132 2019-07-17  Tom Tromey  <tom@tromey.com>
 133
 134         * tui/tui.c: Update.
 135         * tui/tui-source.h (struct tui_source_window): Move from
 136         tui-data.h.
 137         * tui/tui-layout.c: Update.
 138         * tui/tui-disasm.c: Update.
 139         * tui/tui-data.h (struct tui_source_window): Move to
 140         tui-source.h.
 141
 142 2019-07-17  Tom Tromey  <tom@tromey.com>
 143
 144         * tui/tui-disasm.h (struct tui_disasm_window): Move from
 145         tui-data.h.
 146         * tui/tui-data.h (struct tui_disasm_window): Move to
 147         tui-disasm.h.
 148
 149 2019-07-17  Tom Tromey  <tom@tromey.com>
 150
 151         * tui/tui-regs.h (struct tui_data_item_window): Move from
 152         tui-data.h.
 153         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
 154         * tui/tui-data.h (struct tui_data_item_window): Move to
 155         tui-regs.h.
 156         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
 157
 158 2019-07-17  Tom Tromey  <tom@tromey.com>
 159
 160         * tui/tui.c: Update.
 161         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
 162         (tui_cmd_window::max_height): Move to tui-command.c.
 163         * tui/tui-layout.c: Update.
 164         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
 165         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
 166         tui-command.c.
 167         * tui/tui-command.h (struct tui_cmd_window): Move from
 168         tui-data.h.
 169         * tui/tui-command.c: Remove "structuring" comments.
 170         (tui_cmd_window::clear_detail)
 171         (tui_cmd_window::do_make_visible_with_new_height)
 172         (tui_cmd_window::max_height): Move from elsewhere.
 173
 174 2019-07-17  Tom Tromey  <tom@tromey.com>
 175
 176         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
 177         Now static.
 178         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
 179         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
 180
 181 2019-07-17  Tom Tromey  <tom@tromey.com>
 182
 183         * tui/tui.c: Update.
 184         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
 185         tui-regs.c.
 186         * tui/tui-windata.h: Remove file.
 187         * tui/tui-windata.c: Remove file.
 188         * tui/tui-win.c (tui_data_window::set_new_height)
 189         (tui_data_window::do_make_visible_with_new_height): Move to
 190         tui-regs.c.
 191         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
 192         * tui/tui-regs.c: Remove "structuring" comments.
 193         (tui_data_window::first_data_item_displayed)
 194         (tui_data_window::delete_data_content_windows)
 195         (tui_data_window::erase_data_content)
 196         (tui_data_window::display_all_data)
 197         (tui_data_window::refresh_all)
 198         (tui_data_window::do_scroll_vertical)
 199         (tui_data_window::clear_detail, tui_data_window::set_new_height)
 200         (tui_data_window::do_make_visible_with_new_height)
 201         (tui_data_window::refresh_window): Move from elsewhere.
 202         (_initialize_tui_regs): Move to end of file.
 203         * tui/tui-layout.c: Update.
 204         * tui/tui-hooks.c: Update.
 205         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
 206         * tui/tui-data.c (tui_data_window::clear_detail): Move to
 207         tui-regs.c.
 208         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
 209
 210 2019-07-17  Tom Tromey  <tom@tromey.com>
 211
 212         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
 213         seen.
 214
 215 2019-07-17  Tom Tromey  <tom@tromey.com>
 216
 217         * tui/tui-win.c (tui_source_window_base::set_new_height)
 218         (tui_source_window_base::do_make_visible_with_new_height): Use
 219         m_has_locator field directly.
 220         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
 221         method.
 222         (struct tui_source_window_base) <has_locator>: Likewise.
 223
 224 2019-07-17  Tom Tromey  <tom@tromey.com>
 225
 226         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
 227         Don't declare.
 228         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
 229         Remove.
 230         * tui/tui-win.c (tui_source_window_base::set_new_height)
 231         (tui_source_window_base::set_new_height)
 232         (make_invisible_and_set_new_height)
 233         (tui_source_window_base::do_make_visible_with_new_height)
 234         (tui_source_window_base::do_make_visible_with_new_height):
 235         Update.
 236         * tui/tui-layout.c (show_source_disasm_command, show_data)
 237         (show_source_or_disasm_and_command): Update.
 238         * tui/tui-layout.c (show_layout): Update.
 239
 240 2019-07-17  Tom Tromey  <tom@tromey.com>
 241
 242         * tui/tui-layout.c (make_data_window): Remove.
 243         (show_data): Unify creation and re-initialization cases.
 244
 245 2019-07-17  Tom Tromey  <tom@tromey.com>
 246
 247         * tui/tui-layout.c (make_source_window, make_disasm_window):
 248         Remove.
 249         (show_data): Unify creation and re-initialization cases.
 250
 251 2019-07-17  Tom Tromey  <tom@tromey.com>
 252
 253         * tui/tui-layout.c (make_command_window): Remove.
 254         (show_source_disasm_command, show_source_or_disasm_and_command):
 255         Unify creation and re-initialization cases.
 256
 257 2019-07-17  Tom Tromey  <tom@tromey.com>
 258
 259         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
 260         creation and re-initialization cases.
 261
 262 2019-07-17  Tom Tromey  <tom@tromey.com>
 263
 264         * tui/tui-regs.c (tui_get_register): Return void.
 265
 266 2019-07-17  Tom Tromey  <tom@tromey.com>
 267
 268         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
 269         Simplify.
 270
 271 2019-07-17  Tom Tromey  <tom@tromey.com>
 272
 273         * tui/tui-layout.c (show_source_disasm_command): Simplify window
 274         resetting.
 275
 276 2019-07-17  Tom Tromey  <tom@tromey.com>
 277
 278         * tui/tui.h (tui_set_layout_by_name): Don't declare.
 279         * tui/tui-regs.c (tui_reg_layout): New function.
 280         (tui_show_registers, tui_reg_command): Use it.
 281         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
 282         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
 283         parameters.
 284         (tui_layout_command): Remove.
 285
 286 2019-07-17  Tom Tromey  <tom@tromey.com>
 287
 288         * tui/tui-layout.h (tui/tui-layout): Return void.
 289         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
 290
 291 2019-07-17  Tom Tromey  <tom@tromey.com>
 292
 293         * tui/tui-layout.c (show_source_disasm_command, show_data):
 294         Update.
 295         (reset_locator): Remove.
 296         (show_source_or_disasm_and_command): Update.
 297
 298 2019-07-17  Tom Tromey  <tom@tromey.com>
 299
 300         * tui/tui-source.c (tui_source_window_base::reset): Remove
 301         win_type parameter.
 302         * tui/tui-layout.c (make_command_window, make_source_window)
 303         (make_disasm_window, make_data_window)
 304         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
 305         (reset_locator, show_source_or_disasm_and_command): Update.
 306         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
 307         win_type parameter.
 308         (struct tui_source_window_base) <reset>: Likewise.
 309
 310 2019-07-17  Tom Tromey  <tom@tromey.com>
 311
 312         * tui/tui-layout.c (show_source_disasm_command): Use
 313         reset_locator.
 314         (reset_locator): New function.
 315         (init_and_make_win): Remove.
 316         (show_source_or_disasm_and_command): Use reset_locator.
 317
 318 2019-07-17  Tom Tromey  <tom@tromey.com>
 319
 320         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 321         condition.
 322         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 323         Remove condition.
 324         * tui/tui-source.c (tui_source_window_base::reset): New method.
 325         * tui/tui-layout.c (make_command_window): Don't call
 326         init_and_make_win.
 327         (make_source_window, make_disasm_window): Don't call
 328         make_source_or_disasm_window.
 329         (make_data_window): Don't call init_and_make_win.  Change calling
 330         convention.
 331         (show_source_disasm_command, show_data): Simplify.
 332         (make_source_or_disasm_window): Remove.
 333         (show_source_or_disasm_and_command): Simplify.
 334         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 335         (struct tui_source_window_base) <reset>: Likewise.
 336         <execution_info>: Remove initializer.
 337         * tui/tui-data.c (tui_source_window_base): Initialize
 338         execution_info.
 339
 340 2019-07-17  Tom Tromey  <tom@tromey.com>
 341
 342         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 343         variable.
 344
 345 2019-07-17  Tom Tromey  <tom@tromey.com>
 346
 347         * tui/tui.c (tui_rl_other_window): Update.
 348         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 349         superclass method first.  Always iterate over regs_content.
 350         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 351         method.
 352         * tui/tui-win.c (tui_set_focus_command): Update.
 353
 354 2019-07-17  Tom Tromey  <tom@tromey.com>
 355
 356         * tui/tui-win.c (tui_set_focus_command): Rename from
 357         tui_set_focus.  Call tui_enable.
 358         (tui_set_focus_command): Remove.
 359
 360 2019-07-17  Tom Tromey  <tom@tromey.com>
 361
 362         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 363         refresh_window.
 364         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 365         touchwin.
 366         (tui_data_window::refresh_window): Call refresh_window on data
 367         items.  Always call superclass refresh_window.
 368         (tui_win_info::refresh): Remove.
 369         (tui_source_window_base::refresh_window): Update.
 370         (tui_refresh_all): Update.
 371         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 372         refresh_window.
 373         (show_source_or_disasm_and_command): Likewise.
 374         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 375         (struct tui_source_window_base) <refresh>: Likewise.
 376
 377 2019-07-17  Tom Tromey  <tom@tromey.com>
 378
 379         * tui/tui-winsource.c (tui_clear_source_content)
 380         (tui_show_source_content): Update.
 381         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 382         whether content is empty.
 383         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 384         Remove.
 385
 386 2019-07-17  Tom Tromey  <tom@tromey.com>
 387
 388         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 389         window's contents.
 390         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 391         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 392
 393 2019-07-17  Tom Tromey  <tom@tromey.com>
 394
 395         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 396         (struct tui_data_item_window): Update.
 397
 398 2019-07-17  Tom Tromey  <tom@tromey.com>
 399
 400         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 401         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 402         defines.
 403
 404 2019-07-17  Tom Tromey  <tom@tromey.com>
 405
 406         * tui/tui-winsource.h (tui_erase_source_content)
 407         (tui_clear_source_content): Remove "display_prompt" parameter.
 408         * tui/tui-winsource.c (tui_update_source_window_as_is)
 409         (tui_update_source_windows_with_addr): Update.
 410         (tui_clear_source_content): Remove "display_prompt" parameter.
 411         (tui_erase_source_content): Likewise.  Simplify.
 412         (tui_show_source_content): Update.
 413         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 414         * tui/tui-stack.c (tui_show_frame_info): Update.
 415         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 416         Remove defines.
 417
 418 2019-07-17  Tom Tromey  <tom@tromey.com>
 419
 420         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 421         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 422         parameter.
 423         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 424         parameter.
 425
 426 2019-07-17  Tom Tromey  <tom@tromey.com>
 427
 428         * tui/tui-winsource.c (tui_clear_source_content)
 429         (tui_show_source_content, tui_show_exec_info_content)
 430         (tui_clear_exec_info_content): Update.
 431         * tui/tui-stack.c (tui_show_locator_content): Update.
 432         (tui_show_frame_info): Update.
 433         * tui/tui-source.h (tui_source_window): Don't declare.
 434         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 435         from tui_source_is_displayed.
 436         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 437         Remove field.
 438         (struct tui_source_window_base) <content_in_use>: New field.  Now
 439         bool.
 440         (struct tui_source_window) <showing_source_p>: New method.
 441         (TUI_SRC_WIN): Change cast.
 442         * tui/tui-data.c (tui_initialize_static_data): Update.
 443
 444 2019-07-17  Tom Tromey  <tom@tromey.com>
 445
 446         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 447         location_matches_p.
 448         * tui/tui-source.c (tui_source_window::location_matches_p): New
 449         method.
 450         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 451         method.
 452         * tui/tui-data.h (struct tui_source_window_base)
 453         <location_matches_p>: New method.
 454         (struct tui_source_window, struct tui_disasm_window)
 455         <location_matches_p>: Likewise.
 456
 457 2019-07-17  Tom Tromey  <tom@tromey.com>
 458
 459         * tui/tui-win.c (tui_set_win_height_command): Rename from
 460         tui_set_win_height.
 461         (tui_set_win_height_command): Remove.
 462
 463 2019-07-17  Tom Tromey  <tom@tromey.com>
 464
 465         * tui/tui-source.c (tui_source_window): New constructor.  Add
 466         observer.
 467         (~tui_source_window): New destructor.
 468         (tui_source_window::style_changed): New method.
 469         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 470         (tui_attach_detach_observers): Update.
 471         * tui/tui-data.h (struct tui_source_window): Make constructor not
 472         inline.  Add destructor.
 473         (struct tui_source_window) <style_changed>: New method.
 474         <m_observable>: New member.
 475
 476 2019-07-17  Tom Tromey  <tom@tromey.com>
 477
 478         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 479         * tui/tui-win.c (tui_resize_all): Fix typo.
 480
 481 2019-07-17  Tom Tromey  <tom@tromey.com>
 482
 483         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 484         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 485         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 486         * tui/tui-win.c (window_name_completer): Use foreach.
 487         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 488         (update_tab_width): Likewise.
 489         * tui/tui-layout.c (show_layout): Update.
 490         * tui/tui-data.h (class tui_window_iterator): New.
 491         (struct all_tui_windows): New.
 492         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 493
 494 2019-07-17  Tom Tromey  <tom@tromey.com>
 495
 496         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 497         parameter.  Don't reference globals.
 498         (tui_reg_command): Update.
 499
 500 2019-07-17  Tom Tromey  <tom@tromey.com>
 501
 502         * tui/tui-regs.c (tui_show_registers): Simplify.
 503
 504 2019-07-17  Tom Tromey  <tom@tromey.com>
 505
 506         * tui/tui-regs.c (tui_show_registers): Update.
 507         (tui_show_register_group): Add win_info parameter.
 508
 509 2019-07-17  Tom Tromey  <tom@tromey.com>
 510
 511         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 512         Rename from tui_display_reg_element_at_line.
 513         (tui_data_window::display_registers_from_line): Update.
 514         * tui/tui-data.h (struct tui_data_window)
 515         <display_reg_element_at_line>: New method.
 516
 517 2019-07-17  Tom Tromey  <tom@tromey.com>
 518
 519         * tui/tui-regs.h (tui_display_registers_from)
 520         (tui_display_registers_from_line): Don't declare.
 521         * tui/tui-windata.c (tui_data_window::display_all_data)
 522         (tui_data_window::refresh_all)
 523         (tui_data_window::do_scroll_vertical): Update.
 524         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 525         from tui_display_registers_from.
 526         (tui_display_reg_element_at_line): Update.
 527         (tui_data_window::display_registers_from_line): Rename from
 528         tui_display_registers_from_line.
 529         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 530         display_registers_from_line>: New methods.
 531
 532 2019-07-17  Tom Tromey  <tom@tromey.com>
 533
 534         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 535         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 536         from tui_erase_data_content.
 537         (tui_data_window::display_all_data)
 538         (tui_data_window::refresh_all)
 539         (tui_data_window::do_scroll_vertical): Update.
 540         * tui/tui-regs.c (tui_show_registers): Update.
 541         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 542         New method.
 543
 544 2019-07-17  Tom Tromey  <tom@tromey.com>
 545
 546         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 547         declare.
 548         * tui/tui-windata.c
 549         (tui_data_window::delete_data_content_windows): Rename from
 550         tui_delete_data_content_windows.
 551         (tui_data_window::display_all_data)
 552         (tui_data_window::do_scroll_vertical): Update.
 553         * tui/tui-data.h (struct tui_data_window)
 554         <delete_data_content_windows>: New method.
 555
 556 2019-07-17  Tom Tromey  <tom@tromey.com>
 557
 558         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 559         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 560
 561 2019-07-17  Tom Tromey  <tom@tromey.com>
 562
 563         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 564         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 565         from tui_display_all_data.
 566         * tui/tui-win.c
 567         (tui_data_window::do_make_visible_with_new_height): Update.
 568         * tui/tui-regs.c (tui_show_registers): Update.
 569         * tui/tui-layout.c (tui_set_layout): Update.
 570         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 571         method.
 572
 573 2019-07-17  Tom Tromey  <tom@tromey.com>
 574
 575         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 576         * tui/tui-windata.c (tui_display_data_from): Remove.
 577         (tui_data_window::refresh_all): Update.
 578
 579 2019-07-17  Tom Tromey  <tom@tromey.com>
 580
 581         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 582         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 583         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 584         tui_display_registers_from_line.
 585         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 586         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 587         "force_display" parameter.
 588
 589 2019-07-17  Tom Tromey  <tom@tromey.com>
 590
 591         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 592         declare.
 593         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 594         Rename from tui_first_reg_element_no_inline.
 595         (tui_display_reg_element_at_line)
 596         (tui_display_registers_from_line): Update.
 597         * tui/tui-data.h (struct tui_data_window)
 598         <first_reg_element_no_inline>: New method.
 599
 600 2019-07-17  Tom Tromey  <tom@tromey.com>
 601
 602         * tui/tui-windata.c (tui_display_data_from)
 603         (tui_data_window::do_scroll_vertical): Update.
 604         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 605         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 606         Rename from tui_line_from_reg_element_no.
 607         (tui_display_registers_from_line): Update.
 608         * tui/tui-data.h (struct tui_data_window)
 609         <line_from_reg_element_no>: New method.
 610
 611 2019-07-17  Tom Tromey  <tom@tromey.com>
 612
 613         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 614         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 615         tui_last_regs_line_no.
 616         (tui_display_reg_element_at_line)
 617         (tui_display_registers_from_line): Update.
 618         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 619         method.
 620
 621 2019-07-17  Tom Tromey  <tom@tromey.com>
 622
 623         PR tui/24722:
 624         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 625         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 626         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 627         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 628         (tui_update_breakpoint_info): Likewise.
 629         * tui/tui-hooks.c (tui_event_create_breakpoint)
 630         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 631         Update.
 632
 633 2019-07-17  Tom Tromey  <tom@tromey.com>
 634
 635         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 636
 637 2019-07-17  Tom Tromey  <tom@tromey.com>
 638
 639         * tui/tui-winsource.c (tui_update_source_window_as_is)
 640         (tui_update_source_windows_with_addr): Update.
 641         * tui/tui-source.h (tui_set_source_content)
 642         (tui_show_symtab_source): Add "win_info" parameter.
 643         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 644         parameter.
 645         (tui_show_symtab_source): Likewise.
 646
 647 2019-07-17  Tom Tromey  <tom@tromey.com>
 648
 649         * tui/tui-wingeneral.c
 650         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 651
 652 2019-07-17  Tom Tromey  <tom@tromey.com>
 653
 654         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 655         (struct tui_cmd_window) <can_scroll>: New method.
 656         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 657         method.
 658
 659 2019-07-17  Tom Tromey  <tromey@adacore.com>
 660
 661         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 662         do_field_signed>: Rename.  Change type of "value".
 663         * ui-out.c (ui_out::field_signed): Rename from field_int.
 664         Change type of "value".
 665         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 666         type of "value".
 667         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 668         do_field_int.  Change type of "value".
 669         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 670         do_field_int.  Change type of "value".
 671         * tracepoint.c (trace_status_mi, tfind_1)
 672         (print_one_static_tracepoint_marker): Update.
 673         * thread.c (print_thread_info_1, print_selected_thread_frame):
 674         Update.
 675         * stack.c (print_frame, print_frame_info): Update.
 676         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 677         Update.
 678         * source.c (print_source_lines_base): Update.
 679         * skip.c (info_skip_command): Update.
 680         * record-btrace.c (btrace_ui_out_decode_error)
 681         (btrace_call_history_src_line): Update.
 682         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 683         Update.
 684         * progspace.c (print_program_space): Update.
 685         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 686         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 687         do_field_int.  Change type of "value".
 688         * mi/mi-out.c (mi_ui_out::do_table_begin)
 689         (mi_ui_out::do_table_header): Update.
 690         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 691         type of "value".
 692         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 693         (mi_cmd_data_list_changed_registers, output_register)
 694         (mi_cmd_data_read_memory, mi_load_progress)
 695         (mi_cmd_trace_frame_collected): Update.
 696         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 697         Update.
 698         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 699         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 700         (mi_cmd_var_list_children, varobj_update_one): Update.
 701         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 702         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 703         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 704         * inferior.c (print_inferior): Update.
 705         * gdb_bfd.c (print_one_bfd): Update.
 706         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 707         Update.
 708         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 709         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 710         do_field_int.  Change type of "value".
 711         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 712         do_field_int.  Change type of "value".
 713         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 714         (print_one_breakpoint_location, print_it_catch_fork)
 715         (print_one_catch_fork, print_it_catch_vfork)
 716         (print_one_catch_vfork, print_it_catch_solib)
 717         (print_it_catch_exec, print_it_ranged_breakpoint)
 718         (print_mention_watchpoint, print_mention_masked_watchpoint)
 719         (bkpt_print_it, update_static_tracepoint): Update.
 720         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 721         * break-catch-syscall.c (print_it_catch_syscall): Update.
 722         * ada-tasks.c (print_ada_task_info): Update.
 723         * ada-lang.c (print_it_exception, print_mention_exception):
 724         Update.
 725
 726 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 727
 728         PR breakpoints/24541
 729         * gdbarch.c: Regenerate.
 730         * gdbarch.h: Regenerate.
 731         * gdbarch.sh: Adjust return type and parameter types for
 732         'stap_adjust_register'.
 733         (i386_stap_adjust_register): Adjust signature and return new
 734         register name.
 735         * stap-probe.c (stap_parse_register_operand): Adjust use of
 736         'gdbarch_stap_adjust_register'.
 737
 738 2019-07-17  Tom Tromey  <tromey@adacore.com>
 739
 740         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 741         declare VEC.
 742         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 743         std::vector.
 744         (struct s390_process_info): Add initializers.
 745         (s390_add_process): Use new.
 746         (s390_linux_nat_target::low_forget_process): Use delete.
 747         (s390_linux_nat_target::low_new_fork)
 748         (s390_linux_nat_target::stopped_by_watchpoint)
 749         (s390_linux_nat_target::low_prepare_to_resume)
 750         (s390_linux_nat_target::insert_watchpoint)
 751         (s390_linux_nat_target::insert_hw_breakpoint)
 752         (s390_linux_nat_target::remove_watchpoint)
 753         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 754
 755 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 756
 757         * aarch64-fbsd-nat.c: Include regcache.h.
 758         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 759         argument.
 760         (aarch64_fbsd_nat_target::fetch_registers)
 761         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 762         variable.
 763         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 764
 765 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 766
 767         * fbsd-nat.c: Include gdbarch.h.
 768
 769 2019-07-15  Tom Tromey  <tromey@adacore.com>
 770
 771         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 772
 773 2019-07-15  Tom Tromey  <tromey@adacore.com>
 774
 775         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 776         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 777         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 778         * cli-out.c (cli_ui_out::do_field_int): New method.
 779         * ui-out.c (ui_out::field_unsigned): New method.
 780         * symfile.c (generic_load): Use field_unsigned.
 781         (print_transfer_performance): Likewise.
 782         * record-btrace.c (ui_out_field_uint): Remove.
 783         (btrace_call_history_insn_range, btrace_call_history): Use
 784         field_unsigned.
 785         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 786         field_unsigned.
 787         * ui-out.h (class ui_out) <field_unsigned>: New method.
 788         <do_field_unsigned>: Likewise.
 789
 790 2019-07-15  Tom Tromey  <tromey@adacore.com>
 791
 792         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 793         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 794         * target.c (flash_erase_command): Use field_string.
 795         * infrun.c (print_signal_received_reason): Use field_string.
 796         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 797         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 798         field_string.
 799         * ada-tasks.c (print_ada_task_info): Use field_string.
 800
 801 2019-07-15  Tom Tromey  <tromey@adacore.com>
 802
 803         * target.c (flash_erase_command): Use field_core_addr.
 804         * symfile.c (generic_load): Use field_core_addr.
 805         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 806         Use field_core_addr.
 807         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 808         field_core_addr.
 809
 810 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 811
 812         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 813         value if its desired type is smaller than a CORE_ADDR and signed.
 814
 815 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 816
 817         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 818         of changes to field names, and use new is_reference field to
 819         decide if a property is a reference or not.
 820         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 821         field.
 822         (struct dwarf2_property_baton): Update header comment, rename
 823         'referenced_type' to 'property_type' and update comments.
 824         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 825         default property type, store in property baton, update to take
 826         accound of renamed field.
 827         (read_func_scope): Update call to attr_to_dynamic_prop.
 828         (read_array_type): Likewise.
 829         (dwarf2_per_cu_addr_sized_int_type): New function.
 830         (read_subrange_index_type): Move type finding code to
 831         dwarf2_per_cu_addr_sized_int_type.
 832         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 833         (dwarf2_per_cu_addr_type): New function.
 834         (set_die_type): Update calls to attr_to_dynamic_prop.
 835
 836 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 837
 838         * dwarf2read.c (read_subrange_index_type): New function.
 839         (read_subrange_type): Move code into new function and call it.
 840         * gdbtypes.c (create_range_type): Add some asserts.
 841
 842 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 843
 844         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 845         update return statements.
 846         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 847         declaration, and update comment to match.
 848         * gdbtypes.c (resolve_dynamic_array): Update call to
 849         dwarf2_evaluate_property to match new return type.
 850
 851 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 852
 853         * valarith.c (value_subscripted_rvalue): Change lowerbound
 854         parameter type from int to LONGEST.
 855         * value.h (value_subscripted_rvalue): Likewise in declaration.
 856
 857 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 858
 859         * cli/cli-utils.c (info_print_command_completer): New function.
 860         * cli/cli-utils.h: Add 'completer.h' include, and forward
 861         declaration for 'struct cmd_list_element'.
 862         (info_print_command_completer): Declare.
 863         * stack.c (_initialize_stack): Add completer for 'info locals' and
 864         'info args'.
 865         * symtab.c (_initialize_symtab): Add completer for 'info
 866         variables' and 'info functions'.
 867         * NEWS: Mention completion for additional info commands.
 868
 869 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 870
 871         * cli/cli-utils.c (extract_info_print_args): Delete.
 872         (extract_arg_maybe_quoted): Delete.
 873         (info_print_options_defs): New variable.
 874         (make_info_print_options_def_group): New function.
 875         (extract_info_print_options): Define new function.
 876         * cli/cli-utils.h (extract_info_print_args): Delete.
 877         (struct info_print_options): New structure.
 878         (extract_info_print_options): Declare new function.
 879         * stack.c (info_locals_command): Update to use new
 880         extract_info_print_options, also add a header comment.
 881         (info_args_command): Likewise.
 882         * symtab.c (info_variables_command): Likewise.
 883         (info_functions_command): Likewise.
 884
 885 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 886
 887         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 888         to extract string arguments.
 889         * common/common-utils.c (extract_string_maybe_quoted): New function.
 890         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 891
 892 2019-07-11  Tom Tromey  <tromey@adacore.com>
 893
 894         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 895         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 896         * top.h (gdbinit): Don't declare.
 897         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 898         into...
 899         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 900         * top.c (gdb_init): Don't call init_cli_cmds.
 901         (gdbinit): Remove.
 902         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 903
 904 2019-07-11  Tom Tromey  <tromey@adacore.com>
 905
 906         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 907         after it has been moved.
 908
 909 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 910
 911         * valops.c (value_must_coerce_to_target): Change return type to
 912         bool.
 913         * value.h (value_must_coerce_to_target): Likewise.
 914
 915 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 916
 917         * breakpoint.c (is_hardware_watchpoint): Remove
 918         forward-declaration.
 919         (is_masked_watchpoint): Change return type to bool.
 920         (is_tracepoint): Likewise.
 921         (is_breakpoint): Likewise.
 922         (is_hardware_watchpoint): Likewise.
 923         (is_watchpoint): Likewise.
 924         (is_no_memory_software_watchpoint): Likewise.
 925         (is_catchpoint): Likewise.
 926         (breakpoint_1): Make FILTER parameter's return type bool.
 927         is_masked_watchpoint): Change return type to bool.
 928         (save_breakpoints): Make FILTER parameter's return type bool.
 929         * breakpoint.h (is_breakpoint): Change return type to bool.
 930         (is_watchpoint): Likewise.
 931         (is_catchpoint): Likewise.
 932         (is_tracepoint): Likewise.
 933
 934 2019-07-10  Tom Tromey  <tom@tromey.com>
 935
 936         * defs.h: Don't include gdbarch.h.
 937         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 938         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 939         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 940         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 941         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 942         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 943         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 944         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 945         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 946         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 947         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 948         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 949         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 950         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 951         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 952         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 953         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 954         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 955         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 956         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 957         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 958         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 959         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 960         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 961         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 962         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 963         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 964
 965 2019-07-10  Tom Tromey  <tromey@adacore.com>
 966
 967         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 968         * breakpoint.c (init_ada_exception_breakpoint): Register as
 969         bp_catchpoint.
 970         (print_one_breakpoint_location, print_one_breakpoint): Use
 971         is_ada_exception_catchpoint.
 972         * ada-lang.c (class ada_catchpoint_location): Pass
 973         bp_loc_software_breakpoint to bp_location constructor.
 974         (is_ada_exception_catchpoint): New function.
 975
 976 2019-07-10  Tom Tromey  <tromey@adacore.com>
 977
 978         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 979         VEC.
 980         (struct arm_exidx_entry): New method operator<.
 981         (struct arm_exidx_data) <section_maps>: Change type.
 982         (arm_exidx_data_free): Remove.
 983         (arm_exidx_data_key): Change type.  Move lower.
 984         (arm_exidx_new_objfile): Update.
 985         (arm_compare_exidx_entries): Remove.
 986         (arm_find_exidx_entry, _initialize_arm_tdep)
 987
 988 2019-07-10  Tom Tromey  <tromey@adacore.com>
 989
 990         * solib-spu.c (ocl_program_data_key): Change type.
 991         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 992         Update.
 993
 994 2019-07-10  Tom Tromey  <tromey@adacore.com>
 995
 996         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 997         (struct solib_aix_inferior_data) <library_list>: Change type.
 998         (solib_aix_inferior_data_handle): Change type.
 999         (get_solib_aix_inferior_data): Update.
1000         (solib_aix_free_library_list): Remove.
1001         (library_list_start_library): Update.
1002         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1003         return type.
1004         (solib_aix_get_library_list)
1005         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1006         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1007
1008 2019-07-10  Tom Tromey  <tromey@adacore.com>
1009
1010         * solib-dsbt.c (struct dsbt_info): Add initializers.
1011         (solib_dsbt_pspace_data): Change type.
1012         (dsbt_pspace_data_cleanup): Remove.
1013         (get_dsbt_info, _initialize_dsbt_solib): Update.
1014
1015 2019-07-10  Tom Tromey  <tromey@adacore.com>
1016
1017         * spu-tdep.c (spu_overlay_data): Change type.
1018         (spu_get_overlay_table, spu_overlay_new_objfile)
1019         (_initialize_spu_tdep): Update.
1020
1021 2019-07-10  Tom Tromey  <tromey@adacore.com>
1022
1023         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1024         destructor.
1025         (dbx_objfile_data_key): Change type and declare later.
1026         (DBX_SYMFILE_INFO): Rewrite.
1027         * dbxread.c (dbx_objfile_data_key): Change type.
1028         (dbx_symfile_init): Update.
1029         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1030         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1031         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1032
1033 2019-07-10  Tom Tromey  <tromey@adacore.com>
1034
1035         * jit.c (jit_program_space_key): Change type.  Move lower.
1036         (get_jit_program_space_data): Update.
1037         (jit_program_space_data_cleanup): Remove.
1038         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1039         Update.
1040         (struct jit_program_space_data): Add initializers.
1041
1042 2019-07-10  Tom Tromey  <tromey@adacore.com>
1043
1044         * solib-darwin.c (struct darwin_info): Add initializers.
1045         (solib_darwin_pspace_data): Change type.
1046         (darwin_pspace_data_cleanup): Remove.
1047         (get_darwin_info, _initialize_darwin_solib): Update.
1048
1049 2019-07-10  Tom Tromey  <tromey@adacore.com>
1050
1051         * remote-sim.c (struct sim_inferior_data): Add initializers,
1052         constructor, and destructor.
1053         (sim_inferior_data_key): Change type.  Move lower.
1054         (check_for_duplicate_sim_descriptor): Update.
1055         (get_sim_inferior_data): Use new.  Update.
1056         (~sim_inferior_data_cleanup): Rename from
1057         sim_inferior_data_cleanup.  Simplify.
1058         (gdbsim_close_inferior, simulator_command)
1059         (sim_command_completer, _initialize_remote_sim): Update.
1060         (next_pid, INITIAL_PID): Move earlier.
1061
1062 2019-07-10  Tom Tromey  <tromey@adacore.com>
1063
1064         * python/python-internal.h (create_thread_object): Return
1065         gdbpy_ref.
1066         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1067         * python/py-inferior.c (struct threadlist_entry): Add
1068         constructor.
1069         <thread_obj>: Now a gdbpy_ref.
1070         (thread_to_thread_object): Update.
1071         (add_thread_object): Use new.
1072         (delete_thread_object): Use delete.
1073         (infpy_threads): Update.
1074         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1075         GIL.
1076
1077 2019-07-10  Tom Tromey  <tromey@adacore.com>
1078
1079         * valops.c (value_cast): Specialize error message for Ada.
1080
1081 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1082
1083         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1084
1085 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1086
1087         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1088         bpstat_should_step): Return bool, adjust comments.
1089         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1090         bpstat_should_step): Likewise.
1091
1092 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1093
1094         * features/Makefile: Use feature target descriptions for Arm.
1095         * features/arm/arm-core.c: Generate new file.
1096         * features/arm/arm-fpa.c: Likewise.
1097         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1098         * features/arm/arm-m-profile.c: Likewise.
1099         * features/arm/arm-vfpv2.c: Likewise.
1100         * features/arm/arm-vfpv3.c: Likewise.
1101         * features/arm/xscale-iwmmxt.c: Likewise.
1102         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1103
1104 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1105
1106         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1107         ptrace earlier.
1108
1109 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1110
1111         * features/aarch64-pauth.c: Regenerate.
1112
1113 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1114
1115         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1116         bool.
1117         (bpstat_what): Use false instead of 0.
1118
1119 2019-07-09  Pedro Alves  <palves@redhat.com>
1120
1121         * break-catch-throw.c (is_exception_catchpoint): New.
1122         * breakpoint.c (print_one_breakpoint_location): New parameter
1123         'raw_loc'.  Handle it.  Use
1124         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1125         looking at the breakpoint's type.
1126         (print_one_breakpoint): If handling "maint info breakpoints", also
1127         print locations of exception catchpoints.
1128         * breakpoint.h (is_exception_catchpoint): Declare.
1129
1130 2019-07-09  Pedro Alves  <palves@redhat.com>
1131
1132         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1133         "addr" field.
1134         (allocate_location_exception_catchpoint): New.
1135         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1136         (initialize_throw_catchpoint_ops): Install
1137         allocate_location_exception_catchpoint as allocate_location
1138         method.
1139         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1140         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1141         bp_loc_other.
1142         (breakpoint_address_is_meaningful): Delete.
1143         (bl_address_is_meaningful): New.
1144         (breakpoint_locations_match): Adjust comment.
1145         (bp_location_from_bp_type): New, factored out of...
1146         (bp_location::bp_location(breakpoint *)): ... this.
1147         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1148         factored out of...
1149         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1150         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1151         breakpoint_address_is_meaningful.
1152         (bp_locations_compare): Adjust comment.
1153         (update_global_location_list): Use bl_address_is_meaningful
1154         instead of breakpoint_address_is_meaningful.
1155         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1156         explicit.
1157         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1158         * python/py-breakpoint.c (bppy_get_location): No longer check
1159         whether location is null.
1160
1161 2019-07-09  Pedro Alves  <palves@redhat.com>
1162
1163         PR c++/15468
1164         * breakpoint.c (print_one_breakpoint_location): Remove
1165         single-location assert.
1166
1167 2019-07-09  Tom Tromey  <tom@tromey.com>
1168
1169         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1170         * configure: Rebuild.
1171         * configure.ac: Change common to gdbsupport.
1172         * gdbsupport: Rename from common.
1173         * acinclude.m4: Change common to gdbsupport.
1174         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1175         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1176         gdbsupport.
1177         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1178         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1179         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1180         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1181         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1182         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1183         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1184         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1185         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1186         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1187         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1188         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1189         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1190         coff-pe-read.c, command.h, compile/compile-c-support.c,
1191         compile/compile-c.h, compile/compile-cplus-symbols.c,
1192         compile/compile-cplus-types.c, compile/compile-cplus.h,
1193         compile/compile-loc2c.c, compile/compile.c, completer.c,
1194         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1195         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1196         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1197         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1198         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1199         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1200         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1201         features/aarch64-core.c, features/aarch64-fpu.c,
1202         features/aarch64-pauth.c, features/aarch64-sve.c,
1203         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1204         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1205         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1206         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1207         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1208         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1209         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1210         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1211         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1212         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1213         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1214         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1215         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1216         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1217         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1218         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1219         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1220         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1221         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1222         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1223         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1224         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1225         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1226         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1227         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1228         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1229         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1230         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1231         minsyms.c, mips-linux-tdep.c, namespace.h,
1232         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1233         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1234         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1235         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1236         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1237         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1238         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1239         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1240         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1241         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1242         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1243         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1244         procfs.c, producer.c, progspace.h, psymtab.h,
1245         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1246         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1247         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1248         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1249         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1250         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1251         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1252         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1253         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1254         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1255         target-memory.c, target.c, target.h, target/waitstatus.c,
1256         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1257         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1258         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1259         unittests/array-view-selftests.c,
1260         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1261         unittests/common-utils-selftests.c,
1262         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1263         unittests/format_pieces-selftests.c,
1264         unittests/function-view-selftests.c,
1265         unittests/lookup_name_info-selftests.c,
1266         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1267         unittests/mkdir-recursive-selftests.c,
1268         unittests/observable-selftests.c,
1269         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1270         unittests/parse-connection-spec-selftests.c,
1271         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1272         unittests/scoped_fd-selftests.c,
1273         unittests/scoped_mmap-selftests.c,
1274         unittests/scoped_restore-selftests.c,
1275         unittests/string_view-selftests.c, unittests/style-selftests.c,
1276         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1277         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1278         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1279         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1280         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1281         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1282
1283 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1284
1285         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1286         bool value.
1287         (decode_digits_ordinary): Set explicit_line field in sal.
1288         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1289         symtab_and_line that was set on an explicit line number in
1290         assembler code.  Do always update the recorded symtab and line if
1291         we do skip the prologue.
1292
1293 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1294
1295         * breakpoint.c (set_breakpoint_location_function): Remove
1296         explicit_loc parameter.
1297         (momentary_breakpoint_from_master): Update call to
1298         set_breakpoint_location_function.
1299         (add_location_to_breakpoint): Likewise.
1300
1301 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1302
1303         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1304         required features based on default bfd type when no specific bfd
1305         is present.
1306
1307 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1308
1309         * NEWS: Mention that GDB printf and eval commands can now print
1310         C-style and Ada-style convenience var strings without
1311         calling the inferior.
1312         * printcmd.c (printf_c_string): Locally print GDB internal var
1313         instead of transiting via the inferior.
1314         (printf_wide_c_string): Likewise.
1315
1316 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1317
1318         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1319
1320 2019-07-04  Tom Tromey  <tom@tromey.com>
1321
1322         PR tui/24724:
1323         * tui/tui-winsource.c (tui_clear_source_content): Update.
1324         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1325         (tui_update_breakpoint_info): Update.
1326         (tui_set_exec_info_content): Update.
1327         * tui/tui-source.c (tui_set_source_content_nil): Update.
1328         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1329         has_break.
1330         * tui/tui-data.h (enum tui_bp_flag): New.
1331         (tui_bp_flags): New enum flags type.
1332         (struct tui_source_element) <break_mode>: Change type.  Rename
1333         from has_break.
1334         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1335         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1336         constants.
1337         * tui/tui-winsource.h: Fix comment.
1338
1339 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1340
1341         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1342         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1343         (store_fpregs_to_thread)
1344         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1345         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1346         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1347         (IWMMXT_REGS_SIZE): Add define.
1348         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1349         (fetch_vfp_regs, store_vfp_regs)
1350         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1351         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1352
1353 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1354
1355         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1356         defines.
1357         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1358         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1359         (ARM_INT_REGISTER_SIZE): ...to this.
1360         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1361         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1362         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1363         (arm_linux_collect_gregset, supply_nwfpe_register)
1364         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1365         defines.
1366         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1367         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1368         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1369         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1370         (arm_return_in_memory, arm_store_return_value)
1371         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1372         (arm_record_ld_st_multiple): Likewise.
1373         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1374         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1375
1376 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1377
1378         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1379         AARCH64_DISPLACED_MODIFIED_INSNS.
1380         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1381         (aarch64_displaced_step_copy_insn): Likewise.
1382         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1383         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1384         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1385         ARM_DISPLACED_MODIFIED_INSNS.
1386         * arm-tdep.c (arm_gdbarch_init): Likewise.
1387         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1388         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1389         (struct arm_displaced_step_closure): Use
1390         ARM_DISPLACED_MODIFIED_INSNS.
1391
1392 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1393
1394         * features/Makefile: Remove unused xml files.
1395         * features/aarch64.xml: Remove.
1396         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1397         * features/i386/amd64-avx-avx512.xml: Remove.
1398         * features/i386/amd64-avx-linux.xml: Remove.
1399         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1400         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1401         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1402         * features/i386/amd64-avx-mpx.xml: Remove.
1403         * features/i386/amd64-avx.xml: Remove.
1404         * features/i386/amd64-linux.xml: Remove.
1405         * features/i386/amd64-mpx-linux.xml: Remove.
1406         * features/i386/amd64-mpx.xml: Remove.
1407         * features/i386/amd64.xml: Remove.
1408         * features/i386/i386-avx-avx512-linux.xml: Remove.
1409         * features/i386/i386-avx-avx512.xml: Remove.
1410         * features/i386/i386-avx-linux.xml: Remove.
1411         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1412         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1413         * features/i386/i386-avx-mpx-linux.xml: Remove.
1414         * features/i386/i386-avx-mpx.xml: Remove.
1415         * features/i386/i386-avx.xml: Remove.
1416         * features/i386/i386-linux.xml: Remove.
1417         * features/i386/i386-mmx-linux.xml: Remove.
1418         * features/i386/i386-mmx.xml: Remove.
1419         * features/i386/i386-mpx-linux.xml: Remove.
1420         * features/i386/i386-mpx.xml: Remove.
1421         * features/i386/i386.xml: Remove.
1422         * features/i386/x32-avx-avx512-linux.xml: Remove.
1423         * features/i386/x32-avx-linux.xml: Remove.
1424         * features/i386/x32-linux.xml: Remove.
1425
1426 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1427
1428         * regformats/aarch64.dat: Remove.
1429         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1430         * regformats/i386/amd64-avx-linux.dat: Remove.
1431         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1432         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1433         * regformats/i386/amd64-linux.dat: Remove.
1434         * regformats/i386/amd64-mpx-linux.dat: Remove.
1435         * regformats/i386/amd64.dat: Remove.
1436         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1437         * regformats/i386/i386-avx-linux.dat: Remove.
1438         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1439         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1440         * regformats/i386/i386-linux.dat: Remove.
1441         * regformats/i386/i386-mmx-linux.dat: Remove.
1442         * regformats/i386/i386-mpx-linux.dat: Remove.
1443         * regformats/i386/i386.dat: Remove.
1444         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1445         * regformats/i386/x32-avx-linux.dat: Remove.
1446         * regformats/i386/x32-linux.dat: Remove.
1447
1448 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1449
1450         * aarch64-tdep.c: Remove xml self tests.
1451         * amd64-linux-tdep.c: Likewise.
1452         * amd64-tdep.c: Likewise.
1453         * i386-linux-tdep.c: Likewise.
1454         * i386-tdep.c: Likewise.
1455
1456 2019-07-03  Pedro Alves  <palves@redhat.com>
1457
1458         PR cli/24732
1459         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1460         (pipe_cmd_option_defs): New.
1461         (make_pipe_cmd_options_def_group): New.
1462         (pipe_command): Use gdb::option::process_options.
1463         (pipe_command_completer): New function.
1464         (_initialize_cli_cmds): Install completer for "pipe" command.
1465
1466 2019-07-03  Pedro Alves  <palves@redhat.com>
1467
1468         * cli/cli-option.c (union option_value) <string>: New field.
1469         (struct option_def_and_value): Add ctor, move ctor, dtor and
1470         use DISABLE_COPY_AND_ASSIGN.
1471         (option_def_and_value::clear_value): New.
1472         (parse_option, save_option_value_in_ctx, get_val_type_str)
1473         (add_setshow_cmds_for_options): Handle var_string.
1474         * cli-option.h (union option_def::var_address) <string>: New
1475         field.
1476         (struct string_option_def): New.
1477         * maint-test-options.c (struct test_options_opts): Add default
1478         ctor and use DISABLE_COPY_AND_ASSIGN.
1479         <string_opt>: New field.
1480         (test_options_opts::~test_options_opts): New.
1481         (test_options_opts::dump): Also dump "-string".
1482         (test_options_option_defs): Install "string.
1483
1484 2019-07-03  Pedro Alves  <palves@redhat.com>
1485
1486         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1487         option_value with a null enumeration.
1488         (complete_options): Save the option values in the context.
1489         (save_option_value_in_ctx): New, factored out from ...
1490         (process_options): ... here.
1491         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1492         of the function.
1493         * maint-test-options.c (test_options_opts::dump): New, factored
1494         out from ...
1495         (maintenance_test_options_command_mode): ... here.
1496         (maintenance_test_options_command_completion_result): Delete.
1497         (maintenance_test_options_command_completion_text): Update
1498         comment.
1499         (maintenance_show_test_options_completion_result): Change
1500         prototype.  Just print
1501         maintenance_test_options_command_completion_text.
1502         (save_completion_result): New.
1503         (maintenance_test_options_completer_mode): Pass options context to
1504         complete_options, and then save a dump.
1505         (_initialize_maint_test_options): Use add_cmd to install "maint
1506         show test-options-completion-result".
1507
1508 2019-07-03  Pedro Alves  <palves@redhat.com>
1509
1510         * NEWS (New commands): Mention "with" and "maint with".
1511         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1512         (with_command, with_command_completer): New.
1513         (pipe_command): Adjust to new repeat_previous
1514         interface.
1515         (_initialize_cli_cmds): Install the "with" command and its "w"
1516         alias.
1517         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1518         declarations.
1519         * cli/cli-setshow.c (parse_cli_var_uinteger)
1520         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1521         argument strings for all var_types.
1522         (get_setshow_command_value_string): New, factored out from ...
1523         (do_show_command): ... this.
1524         * cli/cli-setshow.h: Include <string>.
1525         (get_setshow_command_value_string): Declare.
1526         * command.h (repeat_previous): Now returns const char *.  Adjust
1527         comment.
1528         * maint.c: Include "cli/cli-cmds.h".
1529         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1530         (_initialize_maint_cmds): Register the "maintenance with" command.
1531         * top.c (repeat_previous): Move bits from pipe_command here:
1532         Return the saved command line, if any; error out if there's no
1533         command to relaunch.
1534
1535 2019-07-03  Pedro Alves  <palves@redhat.com>
1536
1537         * NEWS (New commands): Mention "maint set/show test-settings"
1538         instead of "maint test-settings".
1539         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1540         (maintenance_test_settings_set_list): Rename to ...
1541         (maintenance_set_test_settings_list): ... this.
1542         (maintenance_test_settings_show_list): Rename to  ...
1543         (maintenance_show_test_settings_list): ... this.
1544         (maintenance_test_settings_cmd): Delete.
1545         (maintenance_test_settings_set_cmd): ...
1546         (maintenance_set_test_settings_cmd): ... this.
1547         (maintenance_test_settings_show_cmd): ...
1548         (maintenance_show_test_settings_cmd): ... this.
1549         (maintenance_test_settings_show_value_cmd):
1550         (maintenance_show_test_settings_value_cmd): ... this.
1551         (_initialize_maint_test_settings): No longer install the "maint
1552         test-settings" prefix command.  Rename "maint test-settings set"
1553         to "maint set test-settings", and "maint test-settings show" to
1554         "maint show test-settings".  Adjust all subcommands.
1555
1556 2019-07-03  Pedro Alves  <palves@redhat.com>
1557
1558         * maint-test-settings.c: Fix file's intro comment.  Replace all
1559         references to "test-options" with references to "test-settings",
1560         in comments.
1561
1562 2019-07-03  Pedro Alves  <palves@redhat.com>
1563
1564         * maint-test-settings.c (maintenance_test_settings_xxx)
1565         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1566         New.
1567         (maintenance_test_settings_enums): Use them.
1568         (maintenance_test_settings_enum): Default to
1569         maintenance_test_settings_xxx.
1570         (_initialize_maint_test_settings): Initialize
1571         MAINTENANCE_TEST_SETTINGS_FILENAME.
1572
1573 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1574
1575         * breakpoint.h (remove_breakpoints_inf): Change return type to
1576         void, move function documentation here.
1577         * breakpoint.c (remove_breakpoints_inf): Change return type to
1578         void, move function documentation to header.
1579
1580 2019-07-02  Pedro Alves  <palves@redhat.com>
1581
1582         * NEWS (Completion improvements): Mention "info threads".
1583         * thread.c (struct info_threads_opts, info_threads_option_defs)
1584         (make_info_threads_options_def_group): New.
1585         (info_threads_command): Use gdb::option::process_options.
1586         (info_threads_command_completer): New.
1587         (_initialize_thread): Use gdb::option::build_help to build the
1588         help text for "info threads".
1589
1590 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1591
1592         * defs.h (generic_load): Move from here...
1593         * symfile.h (generic_load): ... to here.  Rename name parameter
1594         to args.
1595         * symfile.c (generic_load): Add comment.
1596
1597 2019-07-01  Tom Tromey  <tromey@adacore.com>
1598
1599         * dwarf2read.c
1600         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1601         declaration of without_params.  Fix formatting.
1602
1603 2019-07-01  Tom Tromey  <tromey@adacore.com>
1604
1605         * ada-exp.y (find_primitive_type): Update.
1606         * ada-lang.h (ada_lookup_symbol): Update.
1607         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1608         parameter.
1609         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1610
1611 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1612
1613         PR breakpoints/24541
1614         * gdbarch.c: Regenerate.
1615         * gdbarch.h: Regenerate.
1616         * gdbarch.sh: Add 'stap_adjust_register'.
1617         * i386-tdep.c: Include '<unordered_set>'.
1618         (i386_stap_adjust_register): New function.
1619         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1620         * stap-probe.c (stap_parse_register_operand): Call
1621         'gdbarch_stap_adjust_register'.
1622
1623 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1624
1625         PR python/24742
1626         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1627         * python/python.c (do_start_initialization): Use 'xmalloc'
1628         instead of 'PyMem_Malloc'.
1629
1630 2019-06-28  Tom Tromey  <tromey@adacore.com>
1631
1632         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1633         for Ada.
1634
1635 2019-06-27  Tom Tromey  <tromey@adacore.com>
1636
1637         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1638         objfile_key.
1639         (arm_find_mapping_symbol, arm_record_special_symbol)
1640         (_initialize_arm_tdep): Update.
1641         (arm_objfile_data_free): Remove.
1642
1643 2019-06-27  Tom Tromey  <tromey@adacore.com>
1644
1645         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1646         to cp_print_static_field.
1647
1648 2019-06-26  Tom Tromey  <tromey@adacore.com>
1649
1650         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1651         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1652         declare.
1653
1654 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1655
1656         * features/aarch64-core.c (create_feature_aarch64_core):
1657         Regenerate.
1658         * features/aarch64-core.xml: Add cpsr flags.
1659
1660 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1661
1662         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1663         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1664
1665 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1666
1667         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1668         field.
1669         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1670         use.
1671         (arm_record_special_symbol): Don't insert new symbol in sorted
1672         position, push it at the end.
1673
1674 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1675
1676         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1677         (arm_mapping_symbol_s): Remove.
1678         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1679         (arm_mapping_symbol_vec): New typedef.
1680         (struct arm_per_objfile): Add constructor.
1681         <section_maps>: Change type to
1682         std::unique_ptr<arm_mapping_symbol_vec[]>.
1683         (arm_compare_mapping_symbols): Remove.
1684         (arm_find_mapping_symbol): Adjust to section_maps type change.
1685         (arm_objfile_data_free): Call delete on arm_per_objfile.
1686         (arm_record_special_symbol): Adjust to section_maps type change.
1687         Allocate arm_per_objfile with new.
1688
1689 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1690
1691         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1692         with the command prefix.
1693
1694 2019-06-25  Tom Tromey  <tom@tromey.com>
1695
1696         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1697         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1698
1699 2019-06-25  Tom Tromey  <tom@tromey.com>
1700
1701         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1702         type.
1703         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1704         protected.
1705
1706 2019-06-25  Tom Tromey  <tom@tromey.com>
1707
1708         * tui/tui-winsource.c
1709         (tui_source_window_base::set_is_exec_point_at): Add check against
1710         LOA_ADDRESS.
1711
1712 2019-06-25  Tom Tromey  <tom@tromey.com>
1713
1714         * tui/tui-source.c (tui_set_source_content): Don't check before
1715         xfree.
1716         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1717
1718 2019-06-25  Tom Tromey  <tom@tromey.com>
1719
1720         * tui/tui-winsource.h (tui_update_source_window_as_is)
1721         (tui_alloc_source_buffer, tui_line_is_displayed)
1722         (tui_addr_is_displayed): Change type of win_info.
1723         * tui/tui-winsource.c (tui_update_source_window_as_is)
1724         (tui_clear_source_content, tui_show_source_line)
1725         (tui_show_source_content, tui_source_window_base::refill)
1726         (tui_source_window_base::set_is_exec_point_at)
1727         (tui_source_window_base::set_is_exec_point_at)
1728         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1729         (tui_alloc_source_buffer, tui_line_is_displayed)
1730         (tui_addr_is_displayed): Change type of win_info.  Update.
1731         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1732         (tui_source_window_base::do_make_visible_with_new_height):
1733         Update.
1734         * tui/tui-source.c (tui_set_source_content)
1735         (tui_set_source_content_nil)
1736         (tui_source_window::do_scroll_vertical): Update.
1737         * tui/tui-layout.c (show_layout): Update.
1738         * tui/tui-disasm.c (tui_set_disassem_content)
1739         (tui_disasm_window::do_scroll_vertical): Update.
1740         * tui/tui-data.h (tui_win_content): Remove.
1741         (struct tui_gen_win_info) <content, content_size>: Remove.
1742         (struct tui_source_element): Add initializers and destructor.
1743         (union tui_which_element, struct tui_win_element): Remove.
1744         (struct tui_source_window_base) <content>: New field.
1745         (struct tui_data_window): Remove destructor.
1746         (tui_alloc_content, tui_free_win_content)
1747         (tui_free_all_source_wins_content): Don't declare.
1748         * tui/tui-data.c (tui_initialize_static_data): Update.
1749         (init_content_element, tui_alloc_content): Remove.
1750         (~tui_gen_win_info): Update.
1751         (~tui_data_window, tui_free_all_source_wins_content)
1752         (tui_free_win_content, free_content, free_content_elements):
1753         Remove.
1754
1755 2019-06-25  Tom Tromey  <tom@tromey.com>
1756
1757         * tui/tui-winsource.h (tui_clear_source_content)
1758         (tui_erase_source_content, tui_show_source_content): Change type
1759         of win_info.
1760         * tui/tui-winsource.c (tui_clear_source_content)
1761         (tui_erase_source_content, tui_show_source_content): Change type
1762         of win_info.
1763         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1764         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1765         win_info.
1766         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1767         win_info.
1768         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1769
1770 2019-06-25  Tom Tromey  <tom@tromey.com>
1771
1772         * tui/tui-winsource.c (tui_clear_source_content)
1773         (tui_source_window_base::set_is_exec_point_at): Update.
1774         * tui/tui-source.c (tui_set_source_content_nil): Update.
1775         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1776         a bool.
1777         * tui/tui-data.c (init_content_element): Update.
1778
1779 2019-06-25  Tom Tromey  <tom@tromey.com>
1780
1781         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1782         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1783         * tui/tui-layout.c (init_and_make_win): Update.
1784         * tui/tui.h (enum tui_win_type): Update.
1785         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1786         tui_win_is_auxillary.
1787         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1788         tui_win_is_auxillary.
1789
1790 2019-06-25  Tom Tromey  <tom@tromey.com>
1791
1792         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1793         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1794         (tui_delete_data_content_windows, tui_display_all_data)
1795         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1796         Update.
1797         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1798         * tui/tui-regs.c (tui_last_regs_line_no)
1799         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1800         (tui_show_registers): Update.
1801         (tui_show_register_group): Return void.  Update.
1802         (tui_display_registers_from, tui_display_reg_element_at_line)
1803         (tui_display_registers_from_line, tui_check_register_values):
1804         Update.
1805         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1806         member.
1807         (struct tui_data_window) <regs_content>: Now a std::vector.
1808         <regs_content_count>: Remove.
1809         (tui_add_content_elements, tui_free_data_content): Don't declare.
1810         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1811         (init_content_element): Remove DATA_WIN case.  Add assert.
1812         (tui_add_content_elements): Remove.
1813         (tui_data_window): Update.
1814         (tui_free_data_content): Remove.
1815         (free_content_elements): Remove DATA_WIN case.
1816
1817 2019-06-25  Tom Tromey  <tom@tromey.com>
1818
1819         * tui/tui-data.c (tui_data_item_window): Update.
1820         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1821         * tui/tui-windata.c (tui_display_all_data)
1822         (tui_display_data_from_line): Update.
1823         (tui_check_data_values): Remove.
1824         * tui/tui-regs.c (tui_show_register_group)
1825         (tui_display_reg_element_at_line): Update.
1826         * tui/tui-hooks.c (tui_register_changed)
1827         (tui_refresh_frame_and_register_information): Call
1828         tui_check_register_values.
1829         * tui/tui-data.h (struct tui_data_window) <data_content,
1830         data_content_count, data_type>: Remove.
1831         (enum tui_data_type): Remove.
1832
1833         * tui/tui-data.c (tui_data_window::clear_detail)
1834         (~tui_data_window): Update.
1835
1836 2019-06-25  Tom Tromey  <tom@tromey.com>
1837
1838         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1839         declare.
1840         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1841         Rename from tui_first_data_item_displayed.  Update.
1842         (tui_data_window::refresh_all)
1843         (tui_data_window::do_scroll_vertical): Update.
1844         * tui/tui-data.h (struct tui_data_window)
1845         <first_data_item_displayed>: Declare new method.
1846
1847 2019-06-25  Tom Tromey  <tom@tromey.com>
1848
1849         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1850         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1851         contents...
1852         (tui_initialize_static_data): ...here.
1853
1854 2019-06-25  Tom Tromey  <tom@tromey.com>
1855
1856         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1857         (tui_display_registers_from, tui_check_register_values): Update.
1858         (tui_display_register): Remove win_info parameter; update.
1859         (tui_get_register): Change type of parameters.
1860         * tui/tui-data.h (struct tui_data_element): Remove.
1861         (union tui_which_element) <data>: Remove.
1862         <data_window>: Change type.
1863         (struct tui_data_item_window): New.
1864         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1865         case.  Add assert.
1866         (~tui_data_item_window): New destructor.
1867         (free_content_elements): Remove DATA_ITEM_WIN case.
1868
1869 2019-06-25  Tom Tromey  <tom@tromey.com>
1870
1871         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1872         Remove.
1873
1874 2019-06-25  Tom Tromey  <tom@tromey.com>
1875
1876         * tui/tui-data.h (struct tui_command_element): Remove.
1877         (union tui_which_element) <command>: Remove.
1878         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1879         assert.
1880         (free_content_elements): Remove CMD_WIN case.
1881
1882 2019-06-25  Tom Tromey  <tom@tromey.com>
1883
1884         * tui/tui-layout.c (tui_set_layout): Update.
1885         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1886         * tui/tui-data.c (layout_def): Update.
1887
1888 2019-06-25  Tom Tromey  <tom@tromey.com>
1889
1890         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1891         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1892         (tui_source_window_base::set_new_height): Update.
1893         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1894         Update.
1895         (tui_set_locator_fullname, tui_set_locator_info)
1896         (tui_show_frame_info): Update.
1897         * tui/tui-source.c (tui_set_source_content)
1898         (tui_source_is_displayed): Update.
1899         * tui/tui-layout.c (show_source_disasm_command, show_data)
1900         (show_source_or_disasm_and_command): Update.
1901         * tui/tui-disasm.c (tui_set_disassem_content)
1902         (tui_get_begin_asm_address): Update.
1903         * tui/tui-data.h (struct tui_locator_element): Remove.
1904         (union tui_which_element) <locator>: Remove.
1905         (struct tui_locator_window): New.
1906         (tui_locator_win_info_ptr): Change return type.
1907         * tui/tui-data.c (_locator): Change type.
1908         (tui_locator_win_info_ptr): Change return type.
1909         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1910         (tui_alloc_content): Add assert.
1911
1912 2019-06-25  Tom Tromey  <tom@tromey.com>
1913
1914         * tui/tui-winsource.c
1915         (tui_exec_info_window::maybe_allocate_content): New method.
1916         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1917         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1918         (make_source_or_disasm_window): Add cast.
1919         * tui/tui-data.h (union tui_which_element) <simple_string>:
1920         Remove.
1921         (struct tui_source_info): New.
1922         (struct tui_source_window_base) <execution_info>: Change type.
1923         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1924         case, and add assert.
1925         (tui_alloc_content): Add assert.
1926
1927 2019-06-25  Tom Tromey  <tom@tromey.com>
1928
1929         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1930         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1931         * tui/tui-data.c (tui_alloc_win_info): Remove.
1932
1933 2019-06-25  Tom Tromey  <tom@tromey.com>
1934
1935         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1936         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1937         can_highlight.
1938
1939 2019-06-25  Tom Tromey  <tom@tromey.com>
1940
1941         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1942         make_visible_with_new_height method.
1943         (tui_win_info::make_visible_with_new_height): New method.
1944         (tui_source_window_base::do_make_visible_with_new_height)
1945         (tui_data_window::do_make_visible_with_new_height)
1946         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1947         (make_visible_with_new_height): Remove.
1948         (tui_resize_all, tui_adjust_win_heights): Use
1949         make_visible_with_new_height method.
1950         * tui/tui-data.h (struct tui_win_info)
1951         <do_make_visible_with_new_height, make_visible_with_new_height>:
1952         New methods.
1953         (struct tui_source_window_base, struct tui_data_window)
1954         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1955         methods.
1956
1957 2019-06-25  Tom Tromey  <tom@tromey.com>
1958
1959         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1960         method.
1961         (update_tab_width): Call update_tab_width method.
1962         * tui/tui-data.h (struct tui_win_info)
1963         (struct tui_source_window_base) <update_tab_width>: New methods.
1964
1965 2019-06-25  Tom Tromey  <tom@tromey.com>
1966
1967         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1968         parameter.
1969         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1970         parameter.
1971         (tui_gen_win_info::make_visible): Update.
1972         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1973         parameter.
1974         * tui/tui-data.h (enum tui_box): New enum.
1975         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1976
1977 2019-06-25  Tom Tromey  <tom@tromey.com>
1978
1979         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1980         init_and_make_win for EXEC_INFO_WIN.
1981         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1982         longer inline.
1983         (struct tui_win_info) <~tui_win_info>: Inline.
1984         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1985         Don't declare.
1986         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1987         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1988         Remove.
1989         (tui_initialize_static_data): Update.
1990         (~tui_gen_win_info): Handle more cleanup here.
1991         (~tui_source_window_base): Delete "execution_info".
1992         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1993
1994 2019-06-25  Tom Tromey  <tom@tromey.com>
1995
1996         * tui/tui-layout.c (make_command_window): Don't set
1997         can_highlight.
1998         (show_source_disasm_command): Call the reset method.
1999         (show_data): Don't set can_highlight.  Call the reset method.
2000         (tui_gen_win_info::reset): Rename from init_gen_win_info
2001         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2002         (show_source_or_disasm_and_command): Call the reset method.
2003         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2004         (struct tui_cmd_window): Set can_highlight.
2005
2006 2019-06-25  Tom Tromey  <tom@tromey.com>
2007
2008         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2009         from make_visible.
2010         (tui_make_visible, tui_make_invisible): Rewrite.
2011         (tui_win_info::make_visible): Remove.
2012         (tui_source_window_base::make_visible): Update.
2013         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2014         method.  Moved from...
2015         (struct tui_win_info) <make_visible>: ...here.
2016
2017 2019-06-25  Tom Tromey  <tom@tromey.com>
2018
2019         * tui/tui-winsource.c
2020         (tui_source_window_base::do_scroll_horizontal): Remove direction
2021         parameter.
2022         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2023         direction parameter.
2024         * tui/tui-win.c (tui_win_info::forward_scroll)
2025         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2026         (tui_win_info::right_scroll): Update.
2027         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2028         direction parameter.
2029         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2030         direction parameter.
2031         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2032         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2033         Remove direction parameter.
2034         (struct tui_source_window_base, struct tui_source_window)
2035         (struct tui_disasm_window, struct tui_data_window)
2036         (struct tui_cmd_window): Update.
2037
2038 2019-06-25  Tom Tromey  <tom@tromey.com>
2039
2040         * tui/tui-winsource.h (tui_set_exec_info_content)
2041         (tui_show_exec_info_content, tui_erase_exec_info_content)
2042         (tui_clear_exec_info_content, tui_update_exec_info): Change
2043         argument to tui_source_window_base.
2044         * tui/tui-winsource.c (tui_set_exec_info_content)
2045         (tui_show_exec_info_content, tui_erase_exec_info_content)
2046         (tui_clear_exec_info_content, tui_update_exec_info): Change
2047         argument to tui_source_window_base.
2048
2049 2019-06-25  Tom Tromey  <tom@tromey.com>
2050
2051         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2052         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2053
2054 2019-06-25  Tom Tromey  <tom@tromey.com>
2055
2056         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2057         check.
2058
2059 2019-06-25  Tom Tromey  <tom@tromey.com>
2060
2061         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2062         type to void.
2063         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2064         type to void.
2065         * tui/tui-source.c (tui_set_source_content): Update.
2066         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2067
2068 2019-06-25  Tom Tromey  <tom@tromey.com>
2069
2070         * tui/tui-win.c (window_name_completer, tui_set_focus)
2071         (tui_all_windows_info): Use name method.
2072         * tui/tui-data.h (struct tui_gen_win_info)
2073         (struct tui_source_window, struct tui_disasm_window)
2074         (struct tui_data_window, struct tui_cmd_window) <name>: New
2075         method.
2076         (tui_win_name): Don't declare.
2077         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2078         (tui_win_name): Remove.
2079
2080 2019-06-25  Tom Tromey  <tom@tromey.com>
2081
2082         * tui/tui-winsource.h (tui_update_source_window)
2083         (tui_update_source_window_as_is): Change parameter type.
2084         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2085         to be a tui_source_window_base.
2086         (tui_update_source_window_as_is): Likewise.
2087         * tui/tui-win.c (make_visible_with_new_height): Update.
2088
2089 2019-06-25  Tom Tromey  <tom@tromey.com>
2090
2091         * tui/tui-winsource.c (tui_erase_source_content)
2092         (tui_show_source_content, tui_show_exec_info_content)
2093         (tui_erase_exec_info_content): Use refresh_window method.
2094         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2095         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2096         from tui_refresh_win.
2097         (tui_data_window::refresh_window): New method.
2098         (tui_win_info::refresh, tui_source_window_base::refresh)
2099         (tui_refresh_all): Use refresh_window method.
2100         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2101         method.
2102         * tui/tui-regs.c (tui_display_register): Call refresh_window
2103         method.
2104         * tui/tui-layout.c (show_source_disasm_command)
2105         (show_source_or_disasm_and_command): Call refresh_window method.
2106         * tui/tui-data.h (struct tui_gen_win_info)
2107         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2108         New method.
2109
2110 2019-06-25  Tom Tromey  <tom@tromey.com>
2111
2112         * tui/tui.c (tui_rl_other_window, tui_enable)
2113         (tui_is_window_visible, tui_get_command_dimension): Update.
2114         * tui/tui-winsource.c (tui_update_source_window_as_is)
2115         (tui_clear_source_content, tui_erase_source_content)
2116         (tui_show_source_line, tui_source_window_base::refill)
2117         (tui_source_window_base::do_scroll_horizontal)
2118         (tui_source_window_base::set_is_exec_point_at)
2119         (tui_update_breakpoint_info, tui_set_exec_info_content)
2120         (tui_alloc_source_buffer, tui_line_is_displayed)
2121         (tui_addr_is_displayed): Update.
2122         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2123         (tui_check_and_display_highlight_if_needed)
2124         (tui_win_info::make_visible, tui_win_info::refresh)
2125         (tui_refresh_all): Update.
2126         * tui/tui-windata.c (tui_first_data_item_displayed)
2127         (tui_delete_data_content_windows, tui_erase_data_content)
2128         (tui_display_all_data, tui_data_window::refresh_all)
2129         (tui_check_data_values): Update.
2130         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2131         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2132         (tui_win_info::backward_scroll, tui_refresh_all_win)
2133         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2134         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2135         (tui_source_window_base::set_new_height)
2136         (tui_data_window::set_new_height)
2137         (make_invisible_and_set_new_height)
2138         (make_visible_with_new_height, new_height_ok)
2139         (parse_scrolling_args): Update.
2140         * tui/tui-stack.c (tui_show_frame_info): Update.
2141         * tui/tui-source.c (tui_set_source_content)
2142         (tui_set_source_content_nil, tui_source_is_displayed)
2143         (tui_source_window::do_scroll_vertical): Update.
2144         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2145         (tui_display_registers_from, tui_display_reg_element_at_line)
2146         (tui_check_register_values, tui_reg_command): Update.
2147         * tui/tui-layout.c (tui_default_win_height)
2148         (show_source_disasm_command, show_data, init_and_make_win)
2149         (show_source_or_disasm_and_command): Update.
2150         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2151         (tui_redisplay_readline, tui_mld_flush)
2152         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2153         (tui_getc): Update.
2154         * tui/tui-disasm.c (tui_set_disassem_content)
2155         (tui_disasm_window::do_scroll_vertical): Update.
2156         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2157         Now virtual.
2158         (struct tui_win_info): Derive from tui_gen_win_info.
2159         <~tui_win_info>: Mark as override.
2160         <generic>: Remove member.
2161         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2162         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2163         (~tui_data_window, ~tui_win_info)
2164         (tui_free_all_source_wins_content): Update.
2165         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2166
2167 2019-06-25  Tom Tromey  <tom@tromey.com>
2168
2169         * tui/tui-layout.c (init_and_make_win): Use new.
2170         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2171         destructor, initializers.
2172         (tui_alloc_generic_win_info): Don't declare.
2173         * tui/tui-data.c (_locator): Add argument to constructor.
2174         (source_win, disasm_win): New globals.
2175         (exec_info): Remove.
2176         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2177         Update.
2178         (tui_alloc_generic_win_info): Remove.
2179         (init_content_element): Use new.
2180         (tui_win_info::tui_win_info): Update.
2181         (free_content_elements) <case DATA_WIN>: Use delete.
2182
2183 2019-06-25  Tom Tromey  <tom@tromey.com>
2184
2185         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2186         * tui/tui-windata.c (tui_first_data_item_displayed)
2187         (tui_delete_data_content_windows): Update.
2188         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2189         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2190         (tui_display_registers_from, tui_check_register_values): Update.
2191         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2192         pointer.
2193         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2194         window.
2195         (tui_free_data_content): Update.
2196         (free_content_elements) <case DATA_WIN>: Free the window.
2197
2198 2019-06-25  Tom Tromey  <tom@tromey.com>
2199
2200         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2201         Update.
2202         * tui/tui-layout.c (make_command_window)
2203         (show_source_disasm_command, show_data, init_and_make_win)
2204         (show_source_or_disasm_and_command): Update.
2205         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2206         method.
2207         <can_highight, is_highlighted>: Now bool.
2208         (tui_set_win_highlight): Don't declare.
2209         * tui/tui-data.c (tui_set_win_highlight): Remove.
2210
2211 2019-06-25  Tom Tromey  <tom@tromey.com>
2212
2213         * tui/tui-wingeneral.c (make_visible): Remove check of window
2214         type.
2215
2216 2019-06-25  Tom Tromey  <tom@tromey.com>
2217
2218         * tui/tui-win.c (tui_win_info::max_height)
2219         (tui_cmd_window::max_height): New methods.
2220         (new_height_ok): Call max_height.
2221         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2222         <max_height>: New method.
2223
2224 2019-06-25  Tom Tromey  <tom@tromey.com>
2225
2226         * tui/tui-win.c (tui_source_window_base::set_new_height)
2227         (tui_data_window::set_new_height): New methods.
2228         (make_invisible_and_set_new_height): Call set_new_height method.
2229         * tui/tui-data.h (struct tui_win_info)
2230         (struct tui_source_window_base, struct tui_data_window)
2231         <set_new_height>: New method.
2232
2233 2019-06-25  Tom Tromey  <tom@tromey.com>
2234
2235         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2236         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2237         tui_refresh_data_win.
2238         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2239         method.
2240         (tui_refresh_all_win): Call the refresh_all method.
2241         (tui_set_focus): Likewise.
2242         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2243         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2244         Likewise.
2245
2246 2019-06-25  Tom Tromey  <tom@tromey.com>
2247
2248         * tui/tui-winsource.h (tui_refill_source_window)
2249         (tui_set_is_exec_point_at): Don't declare.
2250         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2251         (tui_source_window_base::refill): Rename from
2252         tui_refill_source_window.
2253         (tui_source_window_base::do_scroll_horizontal): Update.
2254         (tui_source_window_base::set_is_exec_point_at): Rename from
2255         tui_set_is_exec_point_at.
2256         (tui_update_all_breakpoint_info): Update.
2257         * tui/tui-stack.c (tui_show_frame_info): Update.
2258         * tui/tui-layout.c (show_data): Add cast.
2259         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2260         * tui/tui-data.h (struct tui_source_window_base) <refill,
2261         set_is_exec_point_at>: New methods.
2262         (tui_source_windows, tui_add_to_source_windows): Update types.
2263         (tui_add_to_source_windows): Remove redundant declaration.
2264         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2265         (tui_source_windows): Change return type.
2266         (tui_clear_source_windows_detail): Update.
2267         (tui_add_to_source_windows): Change type of parameter.
2268         (tui_free_all_source_wins_content): Update.
2269
2270 2019-06-25  Tom Tromey  <tom@tromey.com>
2271
2272         * tui/tui-wingeneral.c (tui_win_info::refresh)
2273         (tui_source_window_base::refresh): New methods.
2274         (tui_refresh_all): Call the refresh method.
2275         * tui/tui-data.h (struct tui_win_info)
2276         (struct tui_source_window_base) <refresh>: New method.
2277
2278 2019-06-25  Tom Tromey  <tom@tromey.com>
2279
2280         * tui/tui.h (tui_is_window_visible): Return bool.
2281         * tui/tui.c (tui_is_window_visible): Return bool.
2282         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2283         (tui_make_visible, tui_make_invisible)
2284         (tui_win_info::make_visible)
2285         (tui_source_window_base::make_visible, make_all_visible)
2286         (tui_make_all_visible, tui_make_all_invisible): Update.
2287         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2288         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2289         bool.
2290         (struct tui_win_info, struct tui_source_window_base)
2291         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2292         * tui/tui-data.c (tui_init_generic_part): Update.
2293
2294 2019-06-25  Tom Tromey  <tom@tromey.com>
2295
2296         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2297         (tui_source_window_base::make_visible): New methods.
2298         (make_all_visible): Make method call.
2299         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2300         (struct tui_source_window_base, struct tui_cmd_window): Override
2301         make_visible.
2302         (tui_win_is_source_type): Don't declare.
2303         * tui/tui-data.c (tui_win_is_source_type): Remove.
2304
2305 2019-06-25  Tom Tromey  <tom@tromey.com>
2306
2307         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2308         NULL check.
2309
2310 2019-06-25  Tom Tromey  <tom@tromey.com>
2311
2312         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2313         Inline constructor.  Add initializers for members.
2314         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2315         constructors; now inline in class.
2316
2317 2019-06-25  Tom Tromey  <tom@tromey.com>
2318
2319         * tui/tui-regs.c (tui_show_registers): Update.
2320         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2321         bool.
2322         * tui/tui-data.c (tui_data_window::clear_detail)
2323         (tui_data_window): Update.
2324
2325 2019-06-25  Tom Tromey  <tom@tromey.com>
2326
2327         * tui/tui-windata.c (tui_display_all_data)
2328         (tui_display_data_from_line, tui_display_data_from)
2329         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2330         Update.
2331         * tui/tui-regs.c (tui_last_regs_line_no)
2332         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2333         (tui_show_registers, tui_show_register_group)
2334         (tui_display_registers_from, tui_display_reg_element_at_line)
2335         (tui_display_registers_from_line, tui_check_register_values)
2336         (tui_reg_next, tui_reg_prev): Update.
2337         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2338         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2339         tui_data_window.
2340         (struct tui_win_info) <detail>: Remove.  Add new fields from
2341         tui_data_info.
2342         (TUI_DATA_WIN): Add cast.
2343         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2344         (~tui_data_window): Simplify.
2345
2346 2019-06-25  Tom Tromey  <tom@tromey.com>
2347
2348         * tui/tui-layout.c (show_source_disasm_command)
2349         (show_source_or_disasm_and_command): Update.
2350         * tui/tui-io.c (update_cmdwin_start_line)
2351         (tui_redisplay_readline): Update.
2352         * tui/tui-data.h (struct tui_command_info): Remove.
2353         (struct tui_win_info) <detail>: Remove command_info member.
2354         (struct tui_data_window) <start_line>: New member, from
2355         tui_command_info.
2356         (TUI_CMD_WIN): Add casts.
2357
2358 2019-06-25  Tom Tromey  <tom@tromey.com>
2359
2360         * tui/tui-winsource.c (tui_update_source_window)
2361         (tui_refill_source_window)
2362         (tui_source_window_base::do_scroll_horizontal)
2363         (tui_update_breakpoint_info, tui_set_exec_info_content)
2364         (tui_show_exec_info_content, tui_erase_exec_info_content)
2365         (tui_clear_exec_info_content): Update.
2366         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2367         Update.
2368         * tui/tui-win.c (make_invisible_and_set_new_height)
2369         (make_visible_with_new_height): Update.
2370         * tui/tui-source.c (tui_set_source_content)
2371         (tui_show_symtab_source): Update.
2372         * tui/tui-layout.c (extract_display_start_addr)
2373         (show_source_disasm_command, show_data)
2374         (make_source_or_disasm_window)
2375         (show_source_or_disasm_and_command): Update.
2376         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2377         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2378         "gdbarch".
2379         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2380         to tui_source_window_base.
2381         (struct tui_win_info) <detail>: Remove source_info member.
2382         (struct tui_source_window_base) <has_locator>: Inline.
2383         Move contents from tui_source_info; rename has_locator member to
2384         m_has_locator.
2385         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2386         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2387         header file.
2388         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2389         Simplify.
2390         (tui_free_all_source_wins_content): Cast to
2391         tui_source_window_base.
2392
2393 2019-06-25  Tom Tromey  <tom@tromey.com>
2394
2395         * tui/tui-win.c (make_invisible_and_set_new_height)
2396         (make_visible_with_new_height): Call has_locator method.
2397         * tui/tui-layout.c (show_source_disasm_command, show_data)
2398         (show_source_or_disasm_and_command): Update for bool change.
2399         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2400         (tui_win_info) <has_locator>: New method.
2401         (struct tui_source_window_base) <has_locator>: New method.
2402         (tui_win_has_locator): Don't declare.
2403         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2404         from tui_win_has_locator.
2405         (tui_source_window_base): Use false, not FALSE.
2406
2407 2019-06-25  Tom Tromey  <tom@tromey.com>
2408
2409         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2410         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2411         clear_detail method directly.
2412         (tui_clear_win_detail): Remove.
2413
2414 2019-06-25  Tom Tromey  <tom@tromey.com>
2415
2416         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2417         "this", not TUI_DISASM_WIN.
2418
2419 2019-06-25  Tom Tromey  <tom@tromey.com>
2420
2421         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2422         declare.
2423         * tui/tui-winsource.c
2424         (tui_source_window_base::do_scroll_horizontal): Rename from
2425         tui_horizontal_source_scroll.
2426         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2427         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2428         from tui_vertical_data_scroll.
2429         * tui/tui-win.h (tui_scroll): Don't declare.
2430         * tui/tui-win.c (tui_win_info::forward_scroll)
2431         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2432         (tui_win_info::right_scroll): Rename and update.
2433         (tui_scroll_forward_command, tui_scroll_backward_command)
2434         (tui_scroll_left_command, tui_scroll_right_command): Update.
2435         (tui_scroll): Remove.
2436         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2437         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2438         from tui_vertical_source_scroll.
2439         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2440         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2441         from tui_vertical_disassem_scroll.
2442         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2443         do_scroll_horizontal>: New methods.
2444         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2445         Likewise.
2446         (struct tui_source_window_base): Add do_scroll_horizontal.
2447         (struct tui_source_window, struct tui_disasm_window): Add
2448         do_scroll_vertical.
2449         (struct tui_data_window, struct tui_cmd_window): Add
2450         do_scroll_horizontal and do_scroll_vertical.
2451         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2452
2453 2019-06-25  Tom Tromey  <tom@tromey.com>
2454
2455         * tui/tui-data.h (struct tui_source_window_base): New struct.
2456         (struct tui_source_window): Derive from tui_source_window_base.
2457         (struct tui_disasm_window): New struct.
2458         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2459         from tui_source_window::clear_detail.
2460         (tui_source_window_base): Rename from tui_source_window.
2461         (~tui_source_window_base): Rename from ~tui_source_window.
2462         (tui_alloc_win_info): Create a tui_disasm_window.
2463
2464 2019-06-25  Tom Tromey  <tom@tromey.com>
2465
2466         * tui/tui-data.h (struct tui_source_window)
2467         (struct tui_data_window): Declare destructors.
2468         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2469         destructors.
2470         (tui_win_info): Simplify.
2471
2472 2019-06-25  Tom Tromey  <tom@tromey.com>
2473
2474         * tui/tui-winsource.c (tui_display_main)
2475         (tui_update_source_windows_with_addr)
2476         (tui_update_all_breakpoint_info): Update.
2477         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2478         (new_height_ok, parse_scrolling_args): Update.
2479         * tui/tui-stack.c (tui_show_frame_info): Update.
2480         * tui/tui-data.h (struct tui_list): Remove.
2481         (tui_source_windows): Return a reference to a std::vector.
2482         * tui/tui-data.c (source_windows): Now a std::vector.
2483         (tui_source_windows): Change return type.
2484         (tui_clear_source_windows): Rewrite.
2485         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2486         (tui_free_all_source_wins_content): Rewrite.
2487
2488 2019-06-25  Tom Tromey  <tom@tromey.com>
2489
2490         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2491         (struct tui_data_window, struct tui_cmd_window): Declare
2492         clear_detail method.
2493         * tui/tui-data.c (tui_source_window::clear_detail)
2494         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2495         methods.
2496         (tui_clear_win_detail): Simplify.
2497
2498 2019-06-25  Tom Tromey  <tom@tromey.com>
2499
2500         * tui/tui-layout.c (make_source_window, make_disasm_window)
2501         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2502         Return the new window.
2503         (show_source_disasm_command, show_data)
2504         (show_source_or_disasm_and_command): Update.
2505
2506 2019-06-25  Tom Tromey  <tom@tromey.com>
2507
2508         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2509         parameter.  Return the new window.
2510         (show_source_disasm_command): Update and remove NULL check.
2511         (show_source_or_disasm_and_command): Update.
2512
2513 2019-06-25  Tom Tromey  <tom@tromey.com>
2514
2515         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2516
2517 2019-06-25  Tom Tromey  <tom@tromey.com>
2518
2519         * tui/tui-data.h (struct tui_win_info): Make constructor
2520         protected.  Make destructor virtual.  Add initializers.
2521         (tui_source_window, tui_data_window, tui_cmd_window): New
2522         classes.
2523         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2524         constructor.  Add "type" parameter.
2525         (tui_source_window, tui_data_window, tui_cmd_window): New
2526         constructors.
2527         (tui_alloc_win_info): Instantiate the appropriate subclass.
2528
2529 2019-06-25  Tom Tromey  <tom@tromey.com>
2530
2531         * tui/tui-win.c (tui_resize_all): Use delete.
2532         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2533         destructor.
2534         (tui_free_window): Don't declare.
2535         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2536         Update.
2537
2538 2019-06-25  Tom Tromey  <tom@tromey.com>
2539
2540         * tui/tui-data.h (struct tui_win_info): Add constructor.
2541         * tui/tui-data.c (tui_alloc_win_info): Use new.
2542         (tui_free_window): Use delete.
2543
2544 2019-06-22  Tom Tromey  <tom@tromey.com>
2545
2546         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2547         declare.
2548         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2549
2550 2019-06-22  Tom Tromey  <tom@tromey.com>
2551
2552         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2553         declare.
2554         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2555
2556 2019-06-22  Tom de Vries  <tdevries@suse.de>
2557
2558         * dwarf2read.c (create_addrmap_from_aranges)
2559         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2560         instead of '%zu'.
2561
2562 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2563
2564         * dwarf2read.h (dwarf2_section_info_def): Remove.
2565         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2566         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2567         std::vector<dwarf2_section_info>.
2568         (struct dwo_file) <~dwo_file>: Remove.
2569         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2570         types field.
2571         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2572         (dwarf2_read_debug_names): Likewise.
2573         (create_debug_types_hash_table): Change parameter type to
2574         array_view, adjust code accordingly.
2575         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2576         (partial_die_info::fixup): Likewise.
2577         (determine_prefix): Likewise.
2578         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2579
2580 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2581
2582         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2583         gdb_bfd_ref_ptr.
2584         <~dwo_file>: Remove call to gdb_bfd_unref.
2585         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2586         gdb_bfd_ref_ptr::get.
2587
2588 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2589
2590         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2591         type to htab_up.
2592         * dwarf2read.c (struct dwo_file): Initialize fields.
2593         <~dwo_file>: New.
2594         (free_dwo_file): Remove, move content to ~dwo_file.
2595         (struct dwo_file_deleter): Remove.
2596         (dwo_file_up>: Remove custom deleter.
2597         (free_dwo_files): Remove.
2598         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2599         dwo_files.
2600         (process_skeletonless_type_units): Call unique_ptr::get.
2601         (allocate_dwo_file_hash_table): Add deleter to created hash
2602         table.  Change return type to htab_up.
2603         (lookup_dwo_file_slot): Don't memset dwo_file, call
2604         unique_ptr::get.
2605         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2606         (create_dwo_unit_in_dwp_v2): Likewise.
2607         (open_and_init_dwo_file): Likewise.
2608         (free_dwo_file_from_slot): Remove.
2609
2610 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2611
2612         * dwarf2read.h (struct dwarf2_section_info) <readin,
2613         is_virtual>: Change type to bool.
2614         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2615         true instead of 1.
2616
2617 2019-06-19  Tom Tromey  <tom@tromey.com>
2618
2619         * tui/tui-data.h (tui_init_content_element): Don't declare.
2620
2621 2019-06-19  Tom Tromey  <tom@tromey.com>
2622
2623         * tui/tui-data.h (tui_init_win_info): Don't declare.
2624
2625 2019-06-19  Tom de Vries  <tdevries@suse.de>
2626
2627         * dwarf2read.h (abstract_to_concrete): Change type to
2628         std::unordered_map<sect_offset, std::vector<sect_offset>,
2629         gdb::hash_enum<sect_offset>>.
2630
2631 2019-06-19  Tom Tromey  <tromey@adacore.com>
2632
2633         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2634         EVAL_AVOID_SIDE_EFFECTS specially.
2635
2636 2019-06-19  Tom Tromey  <tromey@adacore.com>
2637
2638         * source-cache.c (highlighter): New global.
2639         (source_cache::get_source_lines): Create a highlighter on demand.
2640
2641 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2642
2643         * defs.h (deprecated_interactive_hook): Delete declaration.
2644         * interps.c (clear_interpreter_hooks): Remove use of
2645         deprecated_interactive_hook.
2646         * top.c (deprecated_interactive_hook): Delete definition.
2647         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2648
2649 2019-06-18  Tom de Vries  <tdevries@suse.de>
2650
2651         PR gdb/24515
2652         * dwarf2read.h (abstract_to_concrete): Change type from
2653         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2654         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2655         * dwarf2read.c (read_variable): Update.
2656         (dwarf2_fetch_die_loc_sect_off): Update.
2657
2658 2019-06-17  Tom de Vries  <tdevries@suse.de>
2659
2660         PR gdb/24617
2661         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2662         accessing parent[parent_len - 1].
2663
2664 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2665
2666         PR gdb/24364
2667         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2668         call dtrace_process_dof with NULL dof.
2669
2670 2019-06-16  Tom de Vries  <tdevries@suse.de>
2671
2672         PR gdb/24445
2673         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2674
2675 2019-06-16  Tom Tromey  <tom@tromey.com>
2676
2677         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2678         (make_all_visible): Use address of member.
2679
2680 2019-06-16  Tom Tromey  <tom@tromey.com>
2681
2682         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2683         (tui_free_window, free_content, free_content_elements): Remove
2684         unnecessary cast.
2685         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2686         cast.
2687         * tui/tui-regs.c (tui_show_register_group)
2688         (tui_display_registers_from, tui_display_reg_element_at_line):
2689         Remove unnecessary cast.
2690
2691 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2692
2693         * linux-nat.c (normal_mask): Delete.
2694         (_initialize_linux_nat): Don't initialise normal_mask.
2695
2696 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2697
2698         PR gdb/24445
2699         * dwarf-index-write.h (write_psymtabs_to_index): Add
2700         dwz_basename parameter.
2701         * dwarf-index-write.c (write_gdbindex): Move file writing to
2702         write_gdbindex_1.  Change return type void.
2703         (assert_file_size): Move up, remove filename parameter.
2704         (write_gdbindex_1): New function.
2705         (write_debug_names): Change return type to void, call
2706         assert_file_size.
2707         (struct index_wip_file): New struct.
2708         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2709         file logic to index_wip_file.  Write index for dwz file if
2710         needed.
2711         (save_gdb_index_command): Pass basename of dwz file, if present.
2712         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2713         build-id of dwz file, if present.
2714         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2715         (dwarf2_get_dwz_file): Likewise.
2716         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2717         (dwarf2_get_dwz_file): Likewise.
2718
2719 2019-06-16  Tom Tromey  <tom@tromey.com>
2720
2721         * coffread.c (process_coff_symbol): Use xstrdup.
2722         * value.c (create_internalvar): Use xstrdup.
2723
2724 2019-06-16  Tom Tromey  <tom@tromey.com>
2725
2726         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2727         * breakpoint.c (stopin_command, stopat_command)
2728         (until_break_command, decode_location_default): Remove unnecessary
2729         cast.
2730         * utils.c (subset_compare): Remove unnecessary cast.
2731         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2732         cast.
2733         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2734         cast.
2735         * infcmd.c (path_command): Remove unnecessary cast.
2736         * coffread.c (decode_type): Remove unnecessary cast.
2737         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2738         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2739         * tui/tui-stack.c (tui_show_locator_content)
2740         (tui_show_frame_info): Remove unnecessary cast.
2741         * tui/tui-win.c (tui_scroll_forward_command)
2742         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2743         (parse_scrolling_args): Remove unnecessary cast.
2744         * tui/tui-data.c (init_win_info, tui_del_window)
2745         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2746         (free_content_elements): Remove unnecessary cast.
2747         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2748         unnecessary cast.
2749         * tui/tui-source.c (tui_set_source_content)
2750         (tui_vertical_source_scroll): Remove unnecessary cast.
2751         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2752         cast.
2753         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2754         * tui/tui-regs.c (tui_display_registers_from)
2755         (tui_display_register): Remove unnecessary cast.
2756         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2757         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2758         (make_visible): Remove unnecessary cast.
2759         * tui/tui-winsource.c (tui_erase_source_content)
2760         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2761         unnecessary cast.
2762         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2763         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2764         * stabsread.c (read_type, read_array_type, read_range_type):
2765         Remove unnecessary cast.
2766         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2767         (parse_symbol, parse_type, upgrade_type, parse_external)
2768         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2769         unnecessary cast.
2770         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2771
2772 2019-06-16  Tom Tromey  <tom@tromey.com>
2773
2774         * tui/tui-data.c (tui_alloc_generic_win_info)
2775         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2776         checks.
2777
2778 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2779             Andrew Burgess  <andrew.burgess@embecosm.com>
2780
2781         * f-typeprint.c (f_print_type): Don't return early for not
2782         associated or not allocated types.
2783         (f_type_print_varspec_suffix): Add print_rank parameter and print
2784         ranks of array types in case they dangling.
2785         (f_type_print_base): Add print_rank parameter.
2786
2787 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2788
2789         * NEWS: Mention new MI commands.
2790         * break-catch-throw.c (enum exception_event_kind): Move to
2791         breakpoint.h.
2792         (print_mention_exception_catchpoint): Output text as a single
2793         message.
2794         (catch_exception_command_1): Rename to...
2795         (catch_exception_event): ...this, make non-static, update header
2796         command, and change some parameter types.
2797         (catch_catch_command): Update for changes to
2798         catch_exception_command_1.
2799         (catch_throw_command): Likewise.
2800         (catch_rethrow_command): Likewise.
2801         * breakpoint.c (enum exception_event_kind): Delete.
2802         * breakpoint.h (enum exception_event_kind): Moved here from
2803         break-catch-throw.c.
2804         (catch_exception_event): Declare.
2805         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2806         (mi_cmd_catch_throw): New function.
2807         (mi_cmd_catch_rethrow): New function.
2808         (mi_cmd_catch_catch): New function.
2809         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2810         'catch-catch' entries.
2811         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2812         (mi_cmd_catch_rethrow): Declare.
2813         (mi_cmd_catch_catch): Declare.
2814
2815 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2816
2817         * annotate.c (annotate_source_line): Change return type to void,
2818         update implementation to match.
2819         * annotate.h (annotate_source_line): Change return type to void,
2820         update header comment.
2821         * stack.c (print_frame_info): Don't change what frame information
2822         is printed based on whether annotations are on or not.
2823
2824 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2825
2826         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2827         (annotate_source): Make static.
2828         (annotate_source_line): Moved from source.c and renamed from
2829         identify_source_line.  Update the return type.
2830         * annotate.h (annotate_source): Delete declaration.
2831         (annotate_source_line): Declaration moved from source.h, and
2832         renamed from identify_source_line.  Return type updated.
2833         * source.c (identify_source_line): Moved to annotate.c and renamed
2834         to annotate_source_line.
2835         (info_line_command): Remove check of annotation_level.
2836         * source.h (identify_source_line): Move declaration to annotate.h
2837         and rename to annotate_source_line.
2838         * stack.c: Add 'annotate.h' include.
2839         (print_frame_info): Remove check of annotation_level before
2840         calling annotate_source_line.
2841
2842 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2843
2844         * source-cache.c (source_cache::get_plain_source_lines): Use
2845         open_source_file_with_line_charpos instead of just
2846         open_source_file, remove call to find_source_lines.
2847         (source_cache::get_source_lines): Likewise.
2848         * source.c (find_source_lines): Make static.
2849         (get_filename_and_charpos): Renamed into...
2850         (open_source_file_with_line_charpos): ..this along with changes to
2851         return a scoped_fd, and some other minor clean ups.
2852         (identify_source_line): Use open_source_file_with_line_charpos.
2853         (search_command_helper): Use open_source_file_with_line_charpos
2854         instead of just open_source_file, remove call to
2855         find_source_lines.
2856         * source.h (open_source_file_with_line_charpos): Declare new
2857         function.
2858         (find_source_lines): Delete declaration.
2859
2860 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2861
2862         * source.c (get_filename_and_charpos): Remove fullname
2863         parameter.
2864         (identify_source_line): Update call to get_filename_and_charpos.
2865
2866 2019-06-14  Tom Tromey  <tromey@adacore.com>
2867
2868         PR gdb/24502:
2869         * ui-style.h (skip_ansi_escape): Update comment.
2870         * ui-file.h (class no_terminal_escape_file): New class.
2871         * ui-file.c (no_terminal_escape_file::write)
2872         (no_terminal_escape_file::puts): New methods.
2873         * cli/cli-logging.c (handle_redirections): Use
2874         no_terminal_escape_file.
2875
2876 2019-06-14  Tom Tromey  <tromey@adacore.com>
2877
2878         * NEWS: Move convenience variable news above Python news.
2879
2880 2019-06-14  Tom Tromey  <tom@tromey.com>
2881
2882         * gnulib: Move directory to top-level.
2883         * configure.ac: Don't configure gnulib.
2884         * configure: Rebuild.
2885         * common/common-defs.h: Use new path to gnulib.
2886         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2887         (GNULIB_H): Remove.
2888         (INCGNU): Look in new gnulib location.
2889         (HFILES_NO_SRCDIR): Remove gnulib files.
2890         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2891         (generated_files): Remove GNULIB_H.
2892         ($(LIBGNU), all-lib): Remove targets.
2893         (distclean): Don't mention GNULIB_BUILDDIR.
2894         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2895
2896 2019-06-14  Tom Tromey  <tromey@adacore.com>
2897
2898         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2899         Warn if symbol file does not provide any symbols.
2900
2901 2019-06-14  Tom Tromey  <tromey@adacore.com>
2902
2903         * source.c (find_and_open_source): Respect basenames_may_differ.
2904
2905 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2906
2907         * annotate.c (annotate_breakpoints_invalid): Make use of
2908         scoped_restore_terminal_state.
2909         (annotate_frames_invalid): Likewise.
2910
2911 2019-06-14  Tom Tromey  <tromey@adacore.com>
2912
2913         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2914         allow assignment to an internalvar.
2915
2916 2019-06-14  Tom Tromey  <tromey@adacore.com>
2917
2918         * ada-lex.l: Allow "_" in attribute names.
2919
2920 2019-06-14  Tom Tromey  <tromey@adacore.com>
2921
2922         PR gdb/24653:
2923         * regcache.c (registers_changed): Don't call alloca.
2924         * top.c (execute_command): Don't call alloca.
2925
2926 2019-06-13  Pedro Alves  <palves@redhat.com>
2927
2928         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2929         'expression'.  When parsing an expression, error out if there's
2930         junk after "unlimited".
2931         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2932         (do_set_command): Adjust calls to is_unlimited_literal.
2933
2934 2019-06-13  Pedro Alves  <palves@redhat.com>
2935
2936         * compile/compile.c (make_compile_options_def_group): Add braces
2937         around array_view initializer.
2938         * thread.c (make_thread_apply_all_options_def_group)
2939         (make_thread_apply_all_options_def_group): Likewise.
2940
2941 2019-06-13  Pedro Alves  <palves@redhat.com>
2942
2943         * NEWS (New commands): Mention "maint test-options
2944         require-delimiter", "maint test-options unknown-is-error", "maint
2945         test-options unknown-is-operand" and "maint show
2946         test-options-completion-result".
2947         (New command options, command completion): New section.
2948         (Completion improvements): New section.
2949         Mention that you can abbreviate "unlimited".
2950
2951 2019-06-13  Pedro Alves  <palves@redhat.com>
2952
2953         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2954         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2955         * unittests/cli-utils-selftests.c (test_parse_flags)
2956         (test_parse_flags_qcs): Delete.
2957         (test_cli_utils): Don't call deleted functions.
2958
2959 2019-06-13  Pedro Alves  <palves@redhat.com>
2960
2961         * thread.c: Include "cli/cli-option.h".
2962         (tp_array_compar_ascending): Global.
2963         (tp_array_compar): Delete function.
2964         (tp_array_compar_ascending, tp_array_compar_descending): New
2965         functions.
2966         (ascending_option_def, qcs_flag_option_def)
2967         (thr_qcs_flags_option_defs)
2968         (make_thread_apply_all_options_def_group)
2969         (make_thread_apply_options_def_group): New.
2970         (thread_apply_all_command): Use gdb::option::process_options.
2971         (thread_apply_command_completer)
2972         (thread_apply_all_command_completer): New.
2973         (thread_apply_command): Use gdb::option::process_options.
2974         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2975         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2976         to generate help text of "thread apply".  Adjust "taas"'s help.
2977         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2978         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2979
2980 2019-06-13  Pedro Alves  <palves@redhat.com>
2981
2982         * thread.c (thread_apply_command): Check for invalid TID with
2983         isdigit instead of !isalpha.
2984
2985 2019-06-13  Pedro Alves  <palves@redhat.com>
2986
2987         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2988         (validate_flags_qcs): New.
2989         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2990         (validate_flags_qcs): Declare.
2991         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2992         (make_frame_apply_options_def_group): New.
2993         (frame_apply_command_count): Process options with
2994         gdb::option::process_options.
2995         (frame_apply_completer): New.
2996         (frame_apply_level_completer, frame_apply_all_completer)
2997         (frame_apply_completer): New.
2998         (_initialize_stack): Update help of "frame apply", "frame apply
2999         level", "frame apply all" and "faas" to mention supported options
3000         and install command completers.
3001         * stack.h (frame_apply_all_completer): Declare.
3002         * thread.c: Include "stack.h".
3003         (tfaas_command): Add "--".
3004         (_initialize_thread): Update help "tfaas" to mention supported
3005         options and install command completer.
3006
3007 2019-06-13  Pedro Alves  <palves@redhat.com>
3008
3009         * completer.c (complete_nested_command_line): New.
3010         (gdb_completion_word_break_characters_throw): Add assertion.
3011         * completer.h (complete_nested_command_line): Declare.
3012
3013 2019-06-13  Pedro Alves  <palves@redhat.com>
3014
3015         * stack.c (parse_backtrace_qualifiers): New.
3016         (backtrace_command): Use it.
3017         (backtrace_command_completer): Complete on qualifiers.
3018
3019 2019-06-13  Pedro Alves  <palves@redhat.com>
3020
3021         * frame.c: Include "cli/cli-option.h.
3022         (user_set_backtrace_options): New.
3023         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3024         Delete.
3025         (get_prev_frame): Adjust.
3026         (boolean_option_def, uinteger_option_def)
3027         (set_backtrace_option_defs): New.
3028         (_initialize_frame): Adjust and use
3029         gdb::option::add_setshow_cmds_for_options to install "set
3030         backtrace past-main" and "set backtrace past-entry".
3031         * frame.h: Include "cli/cli-option.h".
3032         (struct frame_print_options): Forward declare.
3033         (print_frame_arguments_all, print_frame_arguments_scalars)
3034         (print_frame_arguments_none): Declare.
3035         (print_entry_values): Delete declaration.
3036         (struct frame_print_options, user_frame_print_options): New.
3037         (struct set_backtrace_options): New.
3038         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3039         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3040         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3041         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3042         (list_args_or_locals): Add frame_print_options parameter.
3043         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3044         * python/py-framefilter.c (enumerate_args): Pass down
3045         USER_FRAME_PRINT_OPTIONS.
3046         * stack.c: Include "cli/cli-option.h".
3047         (print_frame_arguments_all, print_frame_arguments_scalars)
3048         (print_frame_arguments_none): Declare.
3049         (print_raw_frame_arguments, print_entry_values): Delete.
3050         (user_frame_print_options): New.
3051         (boolean_option_def, enum_option_def, frame_print_option_defs):
3052         New.
3053         (struct backtrace_cmd_options): New.
3054         (bt_flag_option_def): New.
3055         (backtrace_command_option_defs): New.
3056         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3057         (print_frame_arg, read_frame_arg, print_frame_args)
3058         (print_frame_info, print_frame): Add frame_print_options parameter
3059         and use it.
3060         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3061         (backtrace_command_1): Add frame_print_options and
3062         backtrace_cmd_options parameters and use them.
3063         (make_backtrace_options_def_group): New.
3064         (backtrace_command): Process command options with
3065         gdb::option::process_options.
3066         (backtrace_command_completer): New.
3067         (_initialize_stack): Extend "backtrace"'s help to mention
3068         supported options.  Install completer for "backtrace".
3069         Install some settings commands with add_setshow_cmds_for_options.
3070
3071 2019-06-13  Pedro Alves  <palves@redhat.com>
3072
3073         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3074         and that "set/show print raw frame-arguments" are now deprecated.
3075
3076         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3077         command.
3078         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3079         * stack.c (_initialize_stack): Install "set/show print
3080         raw-frame-arguments", and deprecate "set/show print raw
3081         frame-arguments".
3082         * valprint.c (_initialize_valprint): Deprecate "set/show print
3083         raw".
3084
3085 2019-06-13  Pedro Alves  <palves@redhat.com>
3086
3087         * compile/compile.c (struct compile_options): New.
3088         (compile_flag_option_def, compile_command_option_defs)
3089         (make_compile_options_def_group): New.
3090         (compile_file_command): Handle options with
3091         gdb::option::process_options.
3092         (compile_file_command_completer): New function.
3093         (compile_code_command): Handle options with
3094         gdb::option::process_options.
3095         (compile_code_command_completer): New function.
3096         (_initialize_compiler): Install completers for "compile code" and
3097         "compile file".  Mention available options in "compile code" and
3098         "compile code"'s help.
3099         * completer.c (advance_to_completion_word): New, factored out from
3100         ...
3101         (advance_to_expression_complete_word_point): ... this.
3102         (advance_to_filename_complete_word_point): New.
3103         * completer.h (advance_to_filename_complete_word_point): New
3104         declaration.
3105
3106 2019-06-13  Pedro Alves  <palves@redhat.com>
3107
3108         * compile/compile.c: Include "cli/cli-option.h".
3109         (compile_print_value): Scope data pointer is now a
3110         value_print_options pointer; adjust.
3111         (compile_print_command): Process options.  Scope data pointer is
3112         now a value_print_options pointer; adjust.
3113         (_initialize_compile): Update "compile print"'s help to include
3114         supported options.  Install a completer for "compile print".
3115         * cp-valprint.c (show_vtblprint, show_objectprint)
3116         (show_static_field_print): Delete.
3117         (_initialize_cp_valprint): Don't install "set print
3118         static-members", "set print vtbl", "set print object" here.
3119         * printcmd.c: Include "cli/cli-option.h" and
3120         "common/gdb_optional.h".
3121         (print_command_parse_format): Rework to fill in a
3122         value_print_options instead of a format_data.
3123         (print_value): Change parameter type from format_data pointer to
3124         value_print_options reference.  Adjust.
3125         (print_command_1): Process options.  Adjust to pass down a
3126         value_print_options.
3127         (print_command_completer): New.
3128         (_initialize_printcmd): Install print_command_completer as
3129         handle_brkchars completer for the "print" command.  Update
3130         "print"'s help to include supported options.
3131         * valprint.c: Include "cli/cli-option.h".
3132         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3133         here from cp-valprint.c.
3134         (boolean_option_def, uinteger_option_def)
3135         (value_print_option_defs, make_value_print_options_def_group):
3136         New.  Use gdb::option::add_setshow_cmds_for_options to install
3137         "set print elements", "set print null-stop", "set print repeats",
3138         "set print pretty", "set print union", "set print array", "set
3139         print address", "set print symbol", "set print array-indexes".
3140         * valprint.h: Include <string> and "cli/cli-option.h".
3141         (make_value_print_options_def_group): Declare.
3142         (print_value): Change parameter type from format_data pointer to
3143         value_print_options reference.
3144         (print_command_completer): Declare.
3145
3146 2019-06-13  Pedro Alves  <palves@redhat.com>
3147
3148         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3149         (COMMON_SFILES): Add maint-test-settings.c.
3150         * cli/cli-decode.c (boolean_enums): New global, factored out from
3151         ...
3152         (add_setshow_boolean_cmd): ... here.
3153         * cli/cli-decode.h (boolean_enums): Declare.
3154         * cli/cli-option.c: New file.
3155         * cli/cli-option.h: New file.
3156         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3157         factored out from ...
3158         (parse_cli_boolean_value(const char *)): ... this.
3159         (is_unlimited_literal): Change parameter type to pointer to
3160         pointer.  Adjust and advance ARG pointer.
3161         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3162         (parse_cli_var_enum): New, factored out from ...
3163         (do_set_command): ... this.  Adjust.
3164         * cli/cli-setshow.h (parse_cli_boolean_value)
3165         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3166         (parse_cli_var_enum): Declare.
3167         * cli/cli-utils.c: Include "cli/cli-option.h".
3168         (get_ulongest): New.
3169         * cli/cli-utils.h (get_ulongest): Declare.
3170         (check_for_argument): New overloads.
3171         * maint-test-options.c: New file.
3172
3173 2019-06-13  Pedro Alves  <palves@redhat.com>
3174
3175         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3176         parse a range if "-" is at the end of the string.
3177
3178 2019-06-13  Pedro Alves  <palves@redhat.com>
3179
3180         * cli/cli-setshow.c (parse_auto_binary_operation)
3181         (parse_cli_boolean_value): Don't allow "o".
3182
3183 2019-06-13  Pedro Alves  <palves@redhat.com>
3184
3185         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3186         * NEWS: Mention maint test-settings KIND.
3187         * maint-test-settings.c: New file.
3188
3189 2019-06-13  Pedro Alves  <palves@redhat.com>
3190
3191         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3192         completer.
3193         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3194         "set" completers.
3195
3196 2019-06-13  Pedro Alves  <palves@redhat.com>
3197
3198         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3199         after item.
3200
3201 2019-06-13  Pedro Alves  <palves@redhat.com>
3202
3203         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3204
3205 2019-06-13  Pedro Alves <palves@redhat.com>
3206
3207         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3208         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3209         call.
3210         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3211         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3212         calls.
3213         (check_for_argument): Skip spaces after argument.
3214
3215 2019-06-13  Pedro Alves  <palves@redhat.com>
3216
3217         * thread.c (thread_apply_command): Adjust TID parsing.
3218         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3219         detected before end of string.
3220         (tid_is_in_list): Error out if LIST is invalid.
3221
3222 2019-06-13  Pedro Alves  <palves@redhat.com>
3223
3224         * completer.c (complete_line_internal_1): Rewind completion word
3225         point.
3226         (completion_tracker::advance_custom_word_point_by): Change
3227         parameter type to int.
3228         * completer.h (completion_tracker::advance_custom_word_point_by):
3229         Likewise.
3230
3231 2019-06-13  Pedro Alves  <palves@redhat.com>
3232
3233         * completer.c (advance_to_completion_word): Handle delimiters.
3234
3235 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3236
3237         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3238
3239 2019-06-11  Tom Tromey  <tom@tromey.com>
3240
3241         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3242         (xmalloc_failed): Move to alloc.c.
3243         * alloc.c: New file.
3244         * Makefile.in (COMMON_SFILES): Add alloc.c.
3245
3246 2019-06-11  Tom Tromey  <tom@tromey.com>
3247
3248         * nat/linux-waitpid.c: Don't include server.h.
3249         (linux_debug): Remove.
3250         (my_waitpid): Update.
3251
3252 2019-06-11  Tom Tromey  <tromey@adacore.com>
3253
3254         * infcall.c (_initialize_infcall): Remove trailing newline from
3255         help.
3256         * user-regs.c (_initialize_user_regs): Remove trailing newline
3257         from help.
3258         * typeprint.c (_initialize_typeprint): Remove trailing newline
3259         from help.
3260         * reverse.c (_initialize_reverse): Remove trailing newlines from
3261         help.
3262         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3263         from help.
3264         * language.c (add_set_language_command): Remove trailing newline
3265         from help.
3266         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3267         help.
3268         * disasm.c (_initialize_disasm): Remove trailing newline from
3269         help.
3270         * top.c (init_main): Remove trailing newline from help.
3271         * interps.c (_initialize_interpreter): Remove trailing newline
3272         from help.
3273         * btrace.c (_initialize_btrace): Remove trailing newlines from
3274         help.
3275         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3276         from help.
3277         * python/python.c (_initialize_python): Remove trailing newline
3278         from help.
3279         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3280         help.
3281         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3282         from help.  Reformat some text.
3283         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3284         from help.
3285         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3286         newline from help.
3287
3288 2019-06-11  Tom Tromey  <tromey@adacore.com>
3289
3290         * darwin-nat.c (darwin_decode_exception_message)
3291         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3292
3293 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3294
3295         * valops.c (value_slice): Check for not allocated or not
3296         associated values.
3297
3298 2019-06-10  Tom de Vries  <tdevries@suse.de>
3299
3300         PR gdb/24618
3301         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3302         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3303         invalid.
3304
3305 2019-06-10  Tom de Vries  <tdevries@suse.de>
3306
3307         PR gdb/24611
3308         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3309         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3310
3311 2019-06-10  Tom de Vries  <tdevries@suse.de>
3312
3313         PR symtab/24545
3314         * symtab.c (struct demangled_name_entry): Add language field.
3315         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3316         static minimal symbol".  Set and use language field.
3317
3318 2019-06-10  Tom Tromey  <tromey@adacore.com>
3319
3320         * ada-lang.c (_initialize_ada_language): Update help text.
3321
3322 2019-06-10  Tom Tromey  <tromey@adacore.com>
3323
3324         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3325         with a newline.
3326         * guile/guile.c (handle_boot_error): Don't end warning with a
3327         newline.
3328         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3329         warning with a newline.
3330         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3331         newline.
3332         (s12z_frame_cache): Likewise.
3333         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3334         a newline.
3335         * solib-svr4.c (disable_probes_interface): Don't end warning with
3336         a newline.
3337         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3338         newline.
3339         * python/python.c (do_finish_initialization): Don't end warning
3340         with a newline.
3341
3342 2019-06-10  Tom Tromey  <tom@tromey.com>
3343
3344         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3345         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3346         gdbpy_enter.
3347
3348 2019-06-10  Tom Tromey  <tromey@adacore.com>
3349
3350         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3351         data.
3352         (elf_new_init): Don't call stabsread_new_init.
3353         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3354         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3355         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3356
3357 2019-06-10  Tom de Vries  <tdevries@suse.de>
3358
3359         PR symtab/16264
3360         PR symtab/24517
3361         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3362
3363 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3364
3365         * source.c (find_and_open_source): Also rewrite relative file
3366         names.
3367
3368 2019-04-26  Amos Bird  <amosbird@gmail.com>
3369
3370         * annotate.c (annotate_thread_exited): Add "thread-exited"
3371         annotation.
3372
3373 2019-06-06  Tom Tromey  <tromey@adacore.com>
3374
3375         * maint.h (class scoped_command_stats): Use
3376         DISABLE_COPY_AND_ASSIGN.
3377         <print_time>: New method.
3378         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3379         print_time.
3380         (scoped_command_stats::print_time): New method.
3381
3382 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3383
3384         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3385         instructions of lengths 6 or 8 bytes.
3386
3387 2019-06-04  Pedro Alves  <palves@redhat.com>
3388
3389         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3390
3391         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3392         * breakpoint.c (condition_completer): Likewise.
3393         * cli/cli-dump.c (scan_expression): Likewise.
3394         * common/filestuff.c (mkdir_recursive): Likewise.
3395         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3396         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3397         (gdb_abspath): Likewise.
3398         * compile/compile-cplus-types.c
3399         (compile_cplus_instance::decl_name): Likewise.
3400         * completer.c (complete_explicit_location):
3401         (signal_completer, reg_or_group_completer_1): Likewise.
3402         * cp-support.c (cp_remove_params_if_any): Likewise.
3403         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3404         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3405         * infcmd.c (strip_bg_char): Likewise.
3406         * linespec.c (copy_token_string): Likewise.
3407         * mi/mi-main.c (output_cores): Likewise.
3408         * psymtab.c (psymtab_search_name):
3409         * symfile.c (test_set_ext_lang_command): Likewise.
3410         * target.c (target_fileio_read_stralloc): Likewise.
3411         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3412         * value.c (complete_internalvar): Likewise.
3413
3414 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3415
3416         Add objfile property to gdb.Type.
3417         * NEWS: Mention Python API addition.
3418         * python/py-type.c (typy_get_objfile): New method.
3419
3420 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3421
3422         * NEWS: Mention the new set|show style [title|highlight].
3423         Mention changes to "show style", "help" and "apropos".
3424
3425 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3426
3427         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3428         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3429         instead of print_help_for_command.
3430         (print_doc_of_command): New function.
3431         (help_list): Add 'apropos -v word' suggestion.
3432         (print_help_for_command): Style the command name using title style.
3433         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3434         (_initialize_cli_cmds): Describe -v in apropos_command help.
3435
3436 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3437
3438         * cli/cli-style.h (cli_style_option): Add name in constructor,
3439         add m_name class member, add constructor with intensity,
3440         add name class function.
3441         (cli_style_option::add_setshow_commands): Remove name argument.
3442         (highlight_style, title_style): New styles.
3443         * cli/cli-style.c (do_show): New function that shows a style
3444         characteristic styling the style name with itself.
3445         (set_style_name): New function.
3446         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3447         Update all callers according to the changes in cli/cli-style.h.
3448         * utils.h (fputs_highlighted): New function.
3449         * utils.c (fputs_highlighted): Likewise.
3450
3451 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3452
3453         * NEWS: Mention new pipe command and new convenience variables.
3454
3455 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3456
3457         * cli/cli-cmds.c (pipe_command): New function.
3458         (_initialize_cli_cmds): Call add_com for pipe_command.
3459         Define | as an alias for pipe.
3460         (exit_status_set_internal_vars): New function.
3461         (shell_escape): Call exit_status_set_internal_vars.
3462         cli/cli-decode.c (find_command_name_length): Recognize | as
3463         a single character command.
3464
3465 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3466
3467         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3468         top.c (execute_command_to_ui_file): New function, mostly a copy
3469         of execute_command_to_string.
3470         (execute_command_to_string): Implement by calling
3471         execute_command_to_ui_file.
3472
3473 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3474
3475         * top.h (saved_command_line): Remove declaration.
3476         * top.c (previous_saved_command_line, previous_repeat_arguments):
3477         New variables.
3478         (saved_command_line): Make static, define together with other
3479         'repeat variables'.
3480         (dont_repeat): Clear repeat_arguments.
3481         (repeat_previous, get_saved_command_line, save_command_line):
3482         New functions.
3483         (gdb_init): Initialize saved_command_line
3484         and previous_saved_command_line.
3485         * main.c (captured_main_1): Remove saved_command_line initialization.
3486         * event-top.c (handle_line_of_input): Update to use
3487         the new 'repeat' related functions instead of direct access to
3488         saved_command_line.
3489         * command.h (repeat_previous, get_saved_command_line,
3490         save_command_line): New declarations.
3491         (dont_repeat): Add comment.
3492
3493 2019-05-30  Tom Tromey  <tromey@adacore.com>
3494
3495         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3496         Fix comment.
3497         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3498
3499 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3500
3501         PR cli/24587
3502         * completer.c (complete): Initialize variable word.
3503
3504 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3505
3506         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3507         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3508         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3509         'body' is NULL to the outter 'if', protecting the '!is_define'
3510         situation as well.
3511
3512 2019-05-29  Tom Tromey  <tromey@adacore.com>
3513
3514         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3515         (dwarf_unknown): New function.
3516         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3517         (dwarf_type_encoding_name): Use dwarf_unknown.
3518
3519 2019-05-29  Tom Tromey  <tromey@adacore.com>
3520
3521         PR c++/20020:
3522         * cp-valprint.c (cp_print_value_fields): Call
3523         cp_print_static_field inside "try".
3524
3525 2019-05-29  Tom Tromey  <tromey@adacore.com>
3526
3527         * inflow.c (struct terminal_info): Add default operator=.
3528         * configure: Rebuild.
3529         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3530         -Wdeprecated-copy-dtor, -Wredundant-move.
3531
3532 2019-05-29  Tom Tromey  <tromey@adacore.com>
3533
3534         * NEWS: Add entry.
3535         * infcmd.c (print_return_value_1): Handle finish_print
3536         option.
3537         (show_print_finish): New function.
3538         (_initialize_infcmd): Add "set/show print finish" commands.
3539         * valprint.c (user_print_options): Initialize new member.
3540         * valprint.h (struct value_print_options) <finish_print>: New
3541         member.
3542
3543 2019-05-28  Tom Tromey  <tromey@adacore.com>
3544
3545         * ada-lang.c (ada_remove_Xbn_suffix)
3546         (find_old_style_renaming_symbol)
3547         (parse_old_style_renaming): Remove.
3548         (ada_find_renaming_symbol): Don't call
3549         find_old_style_renaming_symbol.
3550         (ada_is_renaming_symbol): Rename from
3551         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3552         bool.  Now static.
3553         (ada_read_var_value): Update and simplify.
3554         * ada-exp.y (write_var_or_type): Remove old code.
3555
3556 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3557
3558         * event-top.c: Remove include comment.
3559         * inflow.c (class scoped_ignore_sigttou): Move from here...
3560         * inflow.h (class scoped_ignore_sigttou): ...to here.
3561         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3562         * top.c:  Remove include comment.
3563
3564 2019-05-27  Tom Tromey  <tom@tromey.com>
3565
3566         * NEWS: Fix typo.
3567
3568 2019-05-22  Tom Tromey  <tromey@adacore.com>
3569
3570         * target.c (target_follow_exec): Constify parameter.
3571         * target-delegates.c: Rebuild.
3572         * remote.c (remote_target::follow_exec): Constify parameter.
3573         * infrun.c (follow_exec): Constify parameter.
3574         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3575         (target_follow_exec): Likewise.
3576
3577 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3578
3579         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3580         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3581
3582 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3583
3584         * NEWS: Add debugredirect and testsuite sections.
3585
3586 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3587
3588         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3589         target descriptions using exclusively floating point register name
3590         aliases.
3591
3592 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3593
3594         PR gdb/18644:
3595         * f-lang.c (build_fortran_types): Handle the case where
3596         gdbarch_floatformat_for_type returns a nullptr.
3597
3598 2019-05-21  Tom de Vries  <tdevries@suse.de>
3599
3600         PR cli/24587
3601         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3602
3603 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3604
3605         PR gdb/18644:
3606         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3607         16-byte floats.
3608         * i386-tdep.c (i386_floatformat_for_type): Use
3609         floatformats_ia64_quad for the 16-byte floating point component
3610         within a fortran 32-byte complex number.
3611
3612 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3613
3614         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3615         delete default constructor.
3616         (find_partial_die): Update to return const struct.
3617         (partial_die_parent_scope): Move variable declaration into scope
3618         of its use and change its type to auto.
3619         (guess_partial_die_structure_name): Likewise.
3620         (partial_die_info::fixup): Likewise.
3621
3622 2019-05-17  Tom Tromey  <tromey@adacore.com>
3623
3624         * source.c (find_and_open_source): Remove cast.
3625
3626 2019-05-17  Tom Tromey  <tromey@adacore.com>
3627
3628         * annotate.c (annotate_source): Make "filename" const.
3629         * annotate.h (annotate_source): Use const.
3630
3631 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3632
3633         * disasm.c (set_disassembler_options): Send errors to stderr.
3634
3635 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3636
3637         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3638         (cli_interp_base::set_logging): Check debug_redirect.
3639         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3640         * cli/cli-logging.c (debug_redirect): Add static variable.
3641         (pop_output_files): Add default param.
3642         (handle_redirections): Print debug setting.
3643         (show_logging_command): Likewise.
3644         (_initialize_cli_logging): Add debugredirect command.
3645         * interps.c (current_interp_set_logging): Add debug_redirect
3646         parameter.
3647         * interps.h (set_logging): Add debug_redirect parameter.
3648         (current_interp_set_logging): Likewise.
3649         * mi/mi-common.h: Likewise.
3650         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3651
3652 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3653             Tom Tromey  <tromey@adacore.com>
3654
3655         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3656         directly.
3657         * cli/cli-interp.h (make_logging_output): Remove declaration.
3658         * cli/cli-logging.c (make_logging_output): Remove function.
3659         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3660         directly.
3661         * ui-file.c (tee_file::tee_file): Remove bools.
3662         (tee_file::~tee_file): Remove deletes.
3663         * ui-file.h (tee_file): Remove bools.
3664
3665 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3666
3667         * mi/mi-cmds.h (mi_cmd_complete): New function.
3668         * mi/mi-main.c (mi_cmd_complete): Likewise.
3669         * mi/mi-cmds.c: Define new MI command -complete.
3670         * NEWS: Mention new -complete command.
3671
3672 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3673
3674         * completer.h (complete): New function.
3675         * completer.c (complete): Likewise.
3676         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3677         function defined in completer.h.
3678
3679 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3680
3681         * MAINTAINERS (Write After Approval): Add myself.
3682
3683 2019-05-17  Tom de Vries  <tdevries@suse.de>
3684
3685         PR gdb/24094
3686         * dwarf2read.c (struct cu_partial_die_info): New struct.
3687         (find_partial_die): Return cu_partial_die_info.
3688         (partial_die_parent_scope, guess_partial_die_structure_name)
3689         (partial_die_info::fixup): Handle new return type of find_partial_die.
3690
3691 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3692
3693         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3694         "std::string", simplifying the algorithm.
3695
3696 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3697
3698         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3699         (stap_static_probe_ops::get_probes): Likewise.
3700
3701 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3702
3703         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3704         '-')" and "else if".
3705         (stap_parse_single_operand): Join checks for
3706         "gdbarch_stap_parse_special_token_p" and
3707         "gdbarch_stap_parse_special_token" in the same "if" statement.
3708         Invert check when verifying for operation on register
3709         displacement.
3710
3711 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3712
3713         * stap-probe.c (stap_get_opcode): Update comment.
3714         (stap_get_expected_argument_type): Likewise.
3715         (handle_stap_probe): Likewise.
3716
3717 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3718
3719         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3720         return type to 'bool'.  Adjust comment.  Use 'bool' when
3721         appropriate.
3722         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3723         * stap-probe.c (stap_parse_argument_1): Likewise.
3724         (stap_is_operator): Likewise.
3725         (stap_is_generic_prefix): Likewise.
3726         (stap_is_register_prefix): Likewise.
3727         (stap_is_register_indirection_prefix): Likewise.
3728         (stap_is_integer_prefix): Likewise.
3729         (stap_generic_check_suffix): Likewise.
3730         (stap_check_integer_suffix): Likewise.
3731         (stap_check_register_suffix): Likewise.
3732         (stap_check_register_indirection_suffix): Likewise.
3733         (stap_parse_register_operand): Likewise.
3734         (stap_parse_single_operand): Likewise.
3735         (stap_parse_argument_1): Likewise.
3736         (stap_probe::get_argument_count): Likewise.
3737         (stap_is_operator): Likewise.
3738
3739 2019-05-16  Tom Tromey  <tromey@adacore.com>
3740
3741         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3742         keyword to foreach.
3743
3744 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3745
3746         * linux-thread-db.c (try_thread_db_load_1): Change return type
3747         to bool.
3748         (try_thread_db_load): Likewise.
3749         (try_thread_db_load_from_pdir_1): Likewise.
3750         (try_thread_db_load_from_pdir): Likewise.
3751         (try_thread_db_load_from_sdir): Likewise.
3752         (try_thread_db_load_from_dir): Likewise.
3753         (thread_db_load_search): Likewise.
3754         (has_libpthread): Likewise.
3755         (thread_db_load): Likewise.
3756
3757 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3758
3759         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3760         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3761         NULL, and complain/return if that's the case.
3762
3763 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3764
3765         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3766         (advance, posn, abstract_read_memory): New functions.
3767         [struct mem_read_abstraction]: New struct.
3768         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3769
3770 2019-05-14  Tom Tromey  <tromey@adacore.com>
3771
3772         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3773         value is not lval_memory.
3774
3775 2019-05-14  Tom Tromey  <tromey@adacore.com>
3776
3777         * solib.c (info_sharedlibrary_command): Style the file name.
3778
3779 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3780
3781         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3782         (aarch64_vnv_type): Likewise.
3783         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3784         * common/tdesc.c: Likewise.
3785         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3786         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3787         * features/aarch64-fpu.xml: Add ieee half view.
3788         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3789         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3790         * gdbtypes.h (struct builtin_type): Likewise.
3791         (struct objfile_type): Likewise.
3792
3793 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3794
3795         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3796         typo.
3797         * location.h (string_to_event_location): Likewise.
3798
3799 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3800
3801         GDB 8.3 released.
3802
3803 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3804
3805         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3806         New variable declaration.
3807         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3808         New variable.
3809         (print_one_breakpoint): Use ui_out::test_flags and new global
3810         variable to compute use_fixed_output.
3811         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3812         Remove.
3813         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3814         (mi_multi_location_breakpoint_output_fixed): Remove.
3815         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3816         new variable.
3817         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3818         fix_multi_location_breakpoint_output flag if version >= 3.
3819         * ui-out.h (enum ui_out_flag)
3820         <fix_multi_location_breakpoint_output>: New enumerator.
3821
3822 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3823
3824         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3825
3826 2019-05-10  Tom Tromey  <tromey@adacore.com>
3827
3828         * ada-lang.c (catch_ada_completer): New function.
3829         (_initialize_ada_language): Use it.
3830
3831 2019-05-10  Tom Tromey  <tromey@adacore.com>
3832
3833         * thread.c (print_thread_info): Make "requested_threads" const.
3834         * gdbthread.h (print_thread_info): Make "requested_threads"
3835         const.
3836         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3837         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3838
3839 2019-05-08  Tom Tromey  <tom@tromey.com>
3840
3841         * gdbtypes.c (objfile_type_data): Change type.
3842         (objfile_type, _initialize_gdbtypes): Update.
3843
3844 2019-05-08  Tom Tromey  <tom@tromey.com>
3845
3846         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3847         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3848         (_initialize_dwarf2_frame): Update.
3849
3850 2019-05-08  Tom Tromey  <tom@tromey.com>
3851
3852         * objc-lang.c (objc_objfile_data): Change type.
3853         (find_methods): Update.
3854         (_initialize_objc_lang): Remove.
3855
3856 2019-05-08  Tom Tromey  <tom@tromey.com>
3857
3858         * stabsread.c (rs6000_builtin_type_data): Change type.
3859         (rs6000_builtin_type, _initialize_stabsread): Update.
3860
3861 2019-05-08  Tom Tromey  <tom@tromey.com>
3862
3863         * mips-tdep.c (mips_pdr_data): Remove.
3864         (_initialize_mips_tdep): Update.
3865
3866 2019-05-08  Tom Tromey  <tom@tromey.com>
3867
3868         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3869         (hppa_init_objfile_priv_data, read_unwind_info)
3870         (find_unwind_entry, _initialize_hppa_tdep): Update.
3871
3872 2019-05-08  Tom Tromey  <tom@tromey.com>
3873
3874         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3875         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3876         on obstack.
3877         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3878
3879 2019-05-08  Tom Tromey  <tom@tromey.com>
3880
3881         * mdebugread.c (basic_type_data): Change type.
3882         (basic_type, _initialize_mdebugread): Update.
3883
3884 2019-05-08  Tom Tromey  <tom@tromey.com>
3885
3886         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3887
3888 2019-05-08  Tom Tromey  <tom@tromey.com>
3889
3890         * nto-tdep.c (nto_inferior_data_reg): Change type.
3891         (nto_inferior_data): Update.
3892         (nto_inferior_data_cleanup, nto_new_inferior_data)
3893         (_initialize_nto_tdep): Remove.
3894         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3895
3896 2019-05-08  Tom Tromey  <tom@tromey.com>
3897
3898         * ada-lang.c (struct ada_inferior_data): Add initializers.
3899         (ada_inferior_data): Change type.
3900         (ada_inferior_data_cleanup): Remove.
3901         (get_ada_inferior_data, ada_inferior_exit)
3902         (struct ada_pspace_data): Add initializers, destructor.
3903         (ada_pspace_data_handle): Change type.
3904         (get_ada_pspace_data): Update.
3905         (ada_pspace_data_cleanup): Remove.
3906
3907 2019-05-08  Tom Tromey  <tom@tromey.com>
3908
3909         * coffread.c (struct coff_symfile_info): Add initializers.
3910         (coff_objfile_data_key): Move lower.  Change type.
3911         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3912         Update.
3913         (coff_free_info): Remove.
3914
3915 2019-05-08  Tom Tromey  <tom@tromey.com>
3916
3917         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3918         (fbsd_pspace_data_handle): Move lower.  Change type.
3919         (get_fbsd_pspace_data): Update.
3920         (fbsd_pspace_data_cleanup): Remove.
3921         (_initialize_fbsd_tdep): Update.
3922
3923 2019-05-08  Tom Tromey  <tom@tromey.com>
3924
3925         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3926         (get_ada_tasks_pspace_data): Update.
3927         (ada_tasks_pspace_data_cleanup): Remove.
3928         (_initialize_tasks): Update.
3929         (ada_tasks_inferior_data_handle): Change type.
3930         (get_ada_tasks_inferior_data): Update.
3931         (ada_tasks_inferior_data_cleanup): Remove.
3932         (struct ada_tasks_pspace_data): Add initializers.
3933
3934 2019-05-08  Tom Tromey  <tom@tromey.com>
3935
3936         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3937         * symfile-debug.c (debug_sym_get_probes): Change type.
3938         * stap-probe.c (handle_stap_probe):
3939         (stap_static_probe_ops::get_probes): Change type.
3940         * probe.h (class static_probe_ops) <get_probes>: Change type.
3941         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3942         (parse_probes_in_pspace): Update.
3943         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3944         Update.
3945         (any_static_probe_ops::get_probes): Change type.
3946         * elfread.c (elfread_data): New typedef.
3947         (probe_key): Change type.
3948         (elf_get_probes): Likewise.  Update.
3949         (probe_key_free): Remove.
3950         (_initialize_elfread): Update.
3951         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3952         Change type.
3953         (dtrace_process_dof_probe, dtrace_process_dof)
3954         (dtrace_static_probe_ops::get_probe): Change type.
3955
3956 2019-05-08  Tom Tromey  <tom@tromey.com>
3957
3958         * xcoffread.c (struct xcoff_symfile_info): Rename from
3959         coff_symfile_info.  Add initializers.
3960         (xcoff_objfile_data_key): Move lower.  Change type.
3961         (XCOFF_DATA): Rewrite.
3962         (xcoff_free_info): Remove.
3963         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3964         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3965         (xcoff_initial_scan): Update.
3966
3967 2019-05-08  Tom Tromey  <tom@tromey.com>
3968
3969         * solib-svr4.c (struct svr4_info): Add initializers and
3970         destructor.
3971         <probes_table>: Now an htab_up.
3972         (solib_svr4_pspace_data): Change type.
3973         (free_probes_table): Simplify.
3974         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3975         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3976         (probes_table_remove_objfile_probes, register_solib_event_probe)
3977         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3978         (_initialize_svr4_solib): Update.
3979
3980 2019-05-08  Tom Tromey  <tom@tromey.com>
3981
3982         * remote.c (remote_pspace_data): Change type.
3983         (remote_pspace_data_cleanup): Remove.
3984         (get_remote_exec_file, set_pspace_remote_exec_file)
3985         (_initialize_remote): Update.
3986
3987 2019-05-08  Tom Tromey  <tom@tromey.com>
3988
3989         * breakpoint.c (breakpoint_objfile_key): Change type.
3990         (get_breakpoint_objfile_data): Update.
3991         (free_breakpoint_objfile_data): Remove.
3992         (_initialize_breakpoint): Update.
3993
3994 2019-05-08  Tom Tromey  <tom@tromey.com>
3995
3996         * linux-tdep.c (struct linux_info): Add initializers.
3997         (linux_inferior_data): Move.  Change type.
3998         (invalidate_linux_cache_inf): Update.
3999         (linux_inferior_data_cleanup): Remove.
4000         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4001
4002 2019-05-08  Tom Tromey  <tom@tromey.com>
4003
4004         * auxv.c (auxv_inferior_data): Move.  Change type.
4005         (auxv_inferior_data_cleanup): Remove.
4006         (invalidate_auxv_cache_inf): Rewrite.
4007         (get_auxv_inferior_data, _initialize_auxv): Update.
4008
4009 2019-05-08  Tom Tromey  <tom@tromey.com>
4010
4011         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4012         (symfile_debug_objfile_data_key): Change type.
4013         (symfile_debug_installed, debug_qf_has_symbols)
4014         (debug_qf_find_last_source_symtab)
4015         (debug_qf_forget_cached_source_info)
4016         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4017         (debug_qf_print_stats, debug_qf_dump)
4018         (debug_qf_expand_symtabs_for_function)
4019         (debug_qf_expand_all_symtabs)
4020         (debug_qf_expand_symtabs_with_fullname)
4021         (debug_qf_map_matching_symbols)
4022         (debug_qf_expand_symtabs_matching)
4023         (debug_qf_find_pc_sect_compunit_symtab)
4024         (debug_qf_map_symbol_filenames)
4025         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4026         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4027         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4028         (debug_sym_read_linetable, debug_sym_relocate): Update.
4029         (symfile_debug_free_objfile): Remove.
4030         (install_symfile_debug_logging, _initialize_symfile_debug):
4031         Update.
4032
4033 2019-05-08  Tom Tromey  <tom@tromey.com>
4034
4035         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4036         allocate_on_obstack.
4037         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4038         (get_dwarf2_per_objfile): Update.
4039         (set_dwarf2_per_objfile): Remove.
4040         (dwarf2_has_info, dwarf2_get_section_info): Update.
4041         (dwarf2_free_objfile): Remove.
4042         (_initialize_dwarf2_read): Update.
4043
4044 2019-05-08  Tom Tromey  <tom@tromey.com>
4045
4046         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4047         initializers.
4048         <unsupported_script_warning_printed,
4049         script_not_found_warning_printed>: Now bool.
4050         (auto_load_pspace_data): Change type.
4051         (~auto_load_pspace_info): Rename from
4052         auto_load_pspace_data_cleanup.
4053         (get_auto_load_pspace_data, init_loaded_scripts_info)
4054         (clear_section_scripts, maybe_print_unsupported_script_warning)
4055         (maybe_print_script_not_found_warning, _initialize_auto_load):
4056         Update.
4057
4058 2019-05-08  Tom Tromey  <tom@tromey.com>
4059
4060         * objfiles.c (objfile_pspace_info): Add destructor and
4061         initializers.
4062         (objfiles_pspace_data): Change type.
4063         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4064         (get_objfile_pspace_data): Update.
4065         (objfiles_bfd_data): Change type.
4066         (get_objfile_bfd_data): Update.
4067         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4068
4069 2019-05-08  Tom Tromey  <tom@tromey.com>
4070
4071         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4072         Change type.
4073         (get_catch_syscall_inferior_data): Update.
4074         (catch_syscall_inferior_data_cleanup): Remove.
4075         (_initialize_break_catch_syscall): Update.
4076
4077 2019-05-08  Tom Tromey  <tom@tromey.com>
4078
4079         * inflow.c (struct terminal_info): Add destructor and
4080         initializers.
4081         (inflow_inferior_data): Change type.
4082         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4083         (get_inflow_inferior_data, inflow_inferior_exit)
4084         (swap_terminal_info, _initialize_inflow): Update.
4085
4086 2019-05-08  Tom Tromey  <tom@tromey.com>
4087
4088         * target-dcache.c (target_dcache_cleanup): Remove.
4089         (target_dcache_aspace_key): Change type.
4090         (target_dcache_init_p, target_dcache_invalidate)
4091         (target_dcache_get, target_dcache_get_or_init)
4092         (_initialize_target_dcache): Update.
4093         * dcache.h (struct dcache_deleter): New.
4094
4095 2019-05-08  Tom Tromey  <tom@tromey.com>
4096
4097         * symtab.c (struct symbol_cache): Add destructor and
4098         initializers.
4099         (symbol_cache_key): Move.  Change type.
4100         (make_symbol_cache, free_symbol_cache): Remove.
4101         (get_symbol_cache): Update.
4102         (symbol_cache_cleanup): Remove.
4103         (ALL_PSPACES, symbol_cache_flush)
4104         (maintenance_print_symbol_cache)
4105         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4106         Update.
4107
4108 2019-05-08  Tom Tromey  <tom@tromey.com>
4109
4110         * symtab.c (struct main_info): Add destructor and initializers.
4111         (main_progspace_key): Move.  Change type.
4112         (get_main_info): Update.
4113         (main_info_cleanup): Remove.
4114         (_initialize_symtab): Update.
4115
4116 2019-05-08  Tom Tromey  <tom@tromey.com>
4117
4118         * registry.h (DECLARE_REGISTRY): Define the _key class.
4119
4120 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4121
4122         * NEWS: Merge two 'New commands' sections.
4123
4124 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4125
4126         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4127         parameter and use Ada language definition instead.
4128         (ada_val_print_ptr): Remove unused language parameter.
4129         (ada_val_print_num): Remove language parameter and use Ada language
4130         definition instead.
4131         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4132         parameter.
4133         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4134         parameter and use Ada language definition instead.
4135         (ada_val_print_1): Update all ada_val_print_xxx calls.
4136         Remove language parameter.
4137         (ada_val_print): Update ada_val_print_1 call.
4138
4139 2019-05-08  Tom Tromey  <tromey@adacore.com>
4140
4141         * remote.c (remote_hw_watchpoint_limit)
4142         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4143         Now static.
4144
4145 2019-05-08  Tom Tromey  <tromey@adacore.com>
4146
4147         * maint.c (_initialize_maint_cmds): Move initialization code to
4148         remote.c.
4149         (watchdog, show_watchdog): Move to remote.c.
4150         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4151         "watchdog" static.
4152         (_initialize_remote): Move initialization code from maint.c.
4153         * defs.h (watchdog): Don't declare.
4154
4155 2019-05-08  Tom Tromey  <tromey@adacore.com>
4156
4157         * tui/tui-interp.c: Include main.h.
4158         * interps.c: Include main.h.
4159         * main.h (interpreter_p): Declare.
4160         * defs.h (interpreter_p): Don't declare.
4161
4162 2019-05-08  Tom Tromey  <tromey@adacore.com>
4163
4164         * dwarf2loc.c: Include dwarf2read.h.
4165         * defs.h (read_unsigned_leb128): Don't declare.
4166         * dwarf2read.h (read_unsigned_leb128): Declare.
4167
4168 2019-05-08  Tom Tromey  <tromey@adacore.com>
4169
4170         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4171         method.
4172
4173 2019-05-08  Tom Tromey  <tromey@adacore.com>
4174
4175         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4176         when no wrap column is set.
4177
4178 2019-05-08  Tom Tromey  <tromey@adacore.com>
4179
4180         * c-lang.c (c_get_string): Handle non-C-style arrays.
4181
4182 2019-05-08  Tom Tromey  <tromey@adacore.com>
4183
4184         * typeprint.c (print_offset_data::update): Print the bit offset,
4185         not the number of bits remaining.
4186
4187 2019-05-08  Tom Tromey  <tromey@adacore.com>
4188
4189         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4190         padding at end of comment.
4191
4192 2019-05-08  Tom Tromey  <tromey@adacore.com>
4193
4194         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4195         Compare main types.
4196
4197 2019-05-06  Tom Tromey  <tom@tromey.com>
4198
4199         * common/scoped_mmap.c: Include common-defs.h.
4200         * common/scoped_mmap.h: Don't include config.h.
4201
4202 2019-05-04  Tom Tromey  <tom@tromey.com>
4203
4204         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4205         (struct aarch64_call_info): Add initializers.
4206         <si>: Now a std::vector.
4207         (pass_on_stack, aarch64_push_dummy_call): Update.
4208
4209 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4210             Tom Tromey  <tom@tromey.com>
4211
4212         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4213         (ppc_threads): Now a std::vector.  Now static.
4214         (hwdebug_find_thread_points_by_tid)
4215         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4216         Update.
4217
4218 2019-05-04  Tom Tromey  <tom@tromey.com>
4219
4220         * arc-tdep.c (arc_tdesc_init): Return bool.
4221
4222 2019-05-04  Tom Tromey  <tom@tromey.com>
4223
4224         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4225         Use gdb_assert_not_reached.
4226
4227 2019-05-04  Tom Tromey  <tom@tromey.com>
4228
4229         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4230         "false".
4231
4232 2019-05-04  Tom Tromey  <tom@tromey.com>
4233
4234         * arc-tdep.c (arc_tdesc_init): Use bool.
4235
4236 2019-05-04  Tom Tromey  <tom@tromey.com>
4237
4238         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4239
4240 2019-05-04  Tom Tromey  <tom@tromey.com>
4241
4242         * cli/cli-cmds.c (valid_command_p): Return bool.
4243
4244 2019-05-04  Tom Tromey  <tom@tromey.com>
4245
4246         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4247         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4248
4249 2019-05-04  Raul Tambre  <raul@tambre.ee>
4250
4251         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4252         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4253         operator for comparison.
4254
4255 2019-05-04  Tom Tromey  <tom@tromey.com>
4256
4257         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4258         (lookup_partial_symbol, print_partial_symbols)
4259         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4260         (psymbol_compare): Update.
4261         (add_psymbol_to_bcache): Clear the entire psymbol.
4262         (maintenance_check_psymtabs): Update.
4263         * psympriv.h (struct partial_symbol): Don't derive from
4264         general_symbol_info.
4265         <obj_section, unrelocated_address, address,
4266         set_unrelocated_address>: Update.
4267         <ginfo>: New member.
4268         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4269         (debug_names::write_psymbols): Update.
4270
4271 2019-05-04  Tom de Vries  <tdevries@suse.de>
4272
4273         * contrib/cc-with-tweaks.sh: Support -n arg.
4274
4275 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4276
4277         * corelow.c (core_target::detach): Ensure frame cache and
4278         register caches are cleared.
4279         inferior.c (exit_inferior_1): Likewise.
4280
4281 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4282             Tom Tromey  <tom@tromey.com>
4283
4284         * dictionary.c (collate_pending_symbols_by_language): Remove
4285         "struct" from foreach.
4286         * symtab.c (lookup_global_symbol_from_objfile)
4287         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4288         foreach.
4289         * ser-tcp.c (net_open): Remove "struct" from foreach.
4290         * objfiles.c (objfile_relocate, objfile_rebase)
4291         (objfile_has_symbols): Remove "struct" from foreach.
4292         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4293         from foreach.
4294         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4295         foreach.
4296         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4297         "struct" from foreach.
4298         * ada-lang.c (create_excep_cond_exprs)
4299         (ada_exception_catchpoint_cond_string): Remove "struct" from
4300         foreach.
4301
4302 2019-05-03  Tom Tromey  <tromey@adacore.com>
4303
4304         * ada-exp.y (convert_char_literal): Check suffix of each
4305         enumerator.
4306
4307 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4308
4309         PR ada/21406:
4310         * ada-exp.y (yywrap): Don't define.
4311         * ada-lex.l (%option): Add noyywrap
4312         (yywrap): Remove.
4313
4314 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4315
4316         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4317         _WIN32_WINNT to the XP level, unless already defined to a higher
4318         level.
4319
4320         * unittests/parse-connection-spec-selftests.c:
4321         * ser-tcp.c:
4322         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4323         override.
4324
4325         * symfile.c (find_separate_debug_file): Remove colon from the
4326         drive spec of DOS/Windows file names of the target, so that the
4327         file name produced from DEBUGDIR and the target's directory will
4328         be valid on DOS/Windows systems.
4329
4330 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4331
4332         * rust-lang.c (val_print_struct): Handle printing structures
4333         containing strings.
4334
4335 2019-05-02  Tom Tromey  <tromey@adacore.com>
4336
4337         * valarith.c (_initialize_valarith): Remove.
4338
4339 2019-05-01  Tom Tromey  <tromey@adacore.com>
4340
4341         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4342         bitfields.
4343
4344 2019-05-01  Tom Tromey  <tromey@adacore.com>
4345
4346         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4347         for big-endian copies.
4348
4349 2019-04-30  Ali Tamur  <tamur@google.com>
4350         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4351         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4352         (read_3_bytes): New function.
4353
4354 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4355
4356         * windows-nat.c (main_thread_id): Delete.
4357         (handle_output_debug_string): Replace main_thread_id by
4358         current_event.dwThreadId.
4359         (fake_create_process): Likewise.
4360         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4361         Do not set main_thread_id.
4362         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4363         current_event.dwThreadId.
4364         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4365
4366 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4367
4368         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4369         Use current_event.dwThreadId instead of main_thread_id.
4370
4371 2019-04-30  Tom Tromey  <tromey@adacore.com>
4372
4373         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4374         (create_excep_cond_exprs): Iterate over program spaces.
4375         (ada_exception_catchpoint_cond_string): Examine all minimal
4376         symbols for exception types.
4377
4378 2019-04-30  Tom Tromey  <tromey@adacore.com>
4379
4380         PR c++/24470:
4381         * dwarf2read.c (process_structure_scope): Handle case where type
4382         has template parameters but no symbol was created.
4383
4384 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4385             Chris January  <chris.january@arm.com>
4386
4387         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4388         qualifier.
4389         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4390
4391 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4392
4393         * f-typeprint.c (f_print_type): Update rules for printing
4394         whitespace.
4395         (f_type_print_varspec_suffix): Likewise.
4396
4397 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4398             Chris January  <chris.january@arm.com>
4399
4400         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4401         function arguments.
4402
4403 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4404
4405         * f-lang.c (build_fortran_types): Change name of void type to
4406         lower case.
4407         * f-typeprint.c (f_type_print_base): Print the name of the void
4408         type, rather than a fixed string.
4409         * f-valprint.c (f_decorations): Use lower case void string.
4410
4411 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4412             Chris January  <chris.january@arm.com>
4413
4414         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4415         types for Fortran.
4416
4417 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4418             Chris January  <chris.january@arm.com>
4419             David Lecomber  <david.lecomber@arm.com>
4420
4421         * f-exp.y (BINOP_INTRINSIC): New token.
4422         (exp): New parser rule handling BINOP_INTRINSIC.
4423         (f77_keywords): Add new builtin procedures.
4424         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4425         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4426         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4427         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4428         (print_unop_subexp_f): New function.
4429         (print_binop_subexp_f): New function.
4430         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4431         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4432         (dump_subexp_body_f): Likewise.
4433         (operator_check_f): Likewise.
4434         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4435         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4436
4437 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4438
4439         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4440         UNOP_KIND.
4441         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4442         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4443         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4444         (operator_length_f): New fuction.
4445         (print_subexp_f): New function.
4446         (op_name_f): New function.
4447         (dump_subexp_body_f): New function.
4448         (operator_check_f): New function.
4449         (exp_descriptor_f): Replace standard expression handling functions
4450         with new functions.
4451         * gdb/fortran-operator.def: New file.
4452         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4453         * gdb/std-operator.def: Remove UNOP_KIND.
4454
4455 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4456
4457         * std-operator.def: Remove unbalanced, stray double quote
4458         character.
4459
4460 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4461             Chris January  <chris.january@arm.com>
4462             Daniel Everett  <daniel.everett@arm.com>
4463             Nick Forrington  <nick.forrington@arm.com>
4464             Richard Bunt  <richard.bunt@arm.com>
4465
4466         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4467         of depth when printing anonymous structs or unions.
4468         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4469         Don't print either the top-level value, or the children if the
4470         max-depth is exceeded.
4471         (ppscm_print_children): When printing the key of a map, allow one
4472         extra level of depth.
4473         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4474         print either the top-level value, or the children if the max-depth
4475         is exceeded.
4476         (print_children): When printing the key of a map, allow one extra
4477         level of depth.
4478         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4479         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4480         (user_print_options): Initialise max_depth field.
4481         (val_print_scalar_or_string_type_p): New function.
4482         (val_print): Check to see if the max depth has been reached.
4483         (val_print_check_max_depth): Define new function.
4484         (show_print_max_depth): New function.
4485         (_initialize_valprint): Add 'print max-depth' option.
4486         * valprint.h (struct value_print_options) <max_depth>: New field.
4487         (val_print_check_max_depth): Declare new function.
4488         * NEWS: Document new feature.
4489
4490 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4491
4492         * ada-lang.c (ada_language_defn): Initialise new field.
4493         * c-lang.c (c_is_string_type_p): New function.
4494         (c_language_defn): Initialise new field.
4495         (cplus_language_defn): Initialise new field.
4496         (asm_language_defn): Initialise new field.
4497         (minimal_language_defn): Initialise new field.
4498         * c-lang.h (c_is_string_type_p): Declare new function.
4499         * d-lang.c (d_language_defn): Initialise new field.
4500         * f-lang.c (f_is_string_type_p): New function.
4501         (f_language_defn): Initialise new field.
4502         * go-lang.c (go_is_string_type_p): New function.
4503         (go_language_defn): Initialise new field.
4504         * language.c (default_is_string_type_p): New function.
4505         (unknown_language_defn): Initialise new field.
4506         (auto_language_defn): Initialise new field.
4507         * language.h (struct language_defn) <la_is_string_type_p>: New
4508         member variable.
4509         (default_is_string_type_p): Declare new function.
4510         * m2-lang.c (m2_language_defn): Initialise new field.
4511         * objc-lang.c (objc_language_defn): Initialise new field.
4512         * opencl-lang.c (opencl_language_defn): Initialise new field.
4513         * p-lang.c (pascal_is_string_type_p): New function.
4514         (pascal_language_defn): Initialise new field.
4515         * rust-lang.c (rust_is_string_type_p): New function.
4516         (rust_language_defn): Initialise new field.
4517
4518 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4519
4520         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4521         New field.
4522         * ada-lang.c (ada_language_defn): Initialise new field.
4523         * c-lang.c (c_language_defn): Likewise.
4524         (cplus_language_defn): Likewise.
4525         (asm_language_defn): Likewise.
4526         (minimal_language_defn): Likewise.
4527         * d-lang.c (d_language_defn): Likewise.
4528         * f-lang.c (f_language_defn): Likewise.
4529         * go-lang.c (go_language_defn): Likewise.
4530         * language.c (unknown_language_defn): Likewise.
4531         (auto_language_defn): Likewise.
4532         * m2-lang.c (m2_language_defn): Likewise.
4533         * objc-lang.c (objc_language_defn): Likewise.
4534         * opencl-lang.c (opencl_language_defn): Likewise.
4535         * p-lang.c (pascal_language_defn): Likewise.
4536         * rust-lang.c (rust_language_defn): Likewise.
4537
4538 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4539
4540         * ada-lang.c (ada_is_character_type): Change return type to bool.
4541         (ada_is_string_type): Likewise.
4542         * ada-lang.h (ada_is_character_type): Update declaration
4543         (ada_is_string_type): Likewise.
4544
4545 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4546
4547         Support style in 'frame|thread apply'
4548
4549         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4550         * record.c (record_start, record_stop): Update callers of
4551         execute_command_to_string with false.
4552         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4553         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4554         methods.
4555         (class string_file): New constructor with term_out parameter.
4556         Override methods term_out and can_emit_style_escape.  New member
4557         term_out.
4558         (class stdio_file): Override can_emit_style_escape.
4559         (class tee_file): Override term_out and can_emit_style_escape.
4560         * utils.h (can_emit_style_escape): Remove.
4561         * utils.c (can_emit_style_escape): Likewise.
4562         Update all callers of can_emit_style_escape (SOMESTREAM) to
4563         SOMESTREAM->can_emit_style_escape.
4564         * source-cache.c (source_cache::get_source_lines): Likewise.
4565         * stack.c (frame_apply_command_count): Call execute_command_to_string
4566         passing the term_out characteristic of the current gdb_stdout.
4567         * thread.c (thr_try_catch_cmd): Likewise.
4568         * top.c (execute_command_to_string): pass term_out parameter
4569         to construct the string_file for the command output.
4570         * ui-file.c (term_cli_styling): New function (most code moved
4571         from utils.c can_emit_style_escape).
4572         (string_file::string_file, string_file::can_emit_style_escape,
4573         stdio_file::can_emit_style_escape, tee_file::term_out,
4574         tee_file::can_emit_style_escape): New functions.
4575
4576 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4577
4578         * NEWS: Mention the new set|show may-call-functions.
4579         * infcall.c (may_call_functions_p): New variable.
4580         (show_may_call_functions_p): New function.
4581         (call_function_by_hand_dummy): Throws an error if not
4582         may-call-functions.
4583         (_initialize_infcall): Call add_setshow_boolean_cmd for
4584         may-call-functions.
4585
4586 2019-04-25  Keith Seitz  <keiths@redhat.com>
4587
4588         PR c++/24367
4589         * cp-support.c (inspect_type): Don't attempt substitutions
4590         of symbol with the same name.
4591
4592 2019-04-25  Tom Tromey  <tromey@adacore.com>
4593
4594         PR gdb/24475:
4595         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4596         static.
4597
4598 2019-04-25  Tom Tromey  <tromey@adacore.com>
4599
4600         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4601         rvalue reference.
4602         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4603         (gdb_xml_parser::parse): Use std::move.
4604         * python/python-internal.h (gdbpy_convert_exception): Take a const
4605         reference.
4606         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4607         std::move.
4608         * python/py-utils.c (gdbpy_convert_exception): Take a const
4609         reference.
4610         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4611         Use std::move.
4612         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4613         Use std::move.
4614         * mi/mi-main.c (mi_print_exception): Take a const reference.
4615         * main.c (handle_command_errors): Take a const reference.
4616         * linespec.c (parse_linespec): Use std::move.
4617         * infcall.c (run_inferior_call): Use std::move.
4618         (call_function_by_hand_dummy): Use std::move.
4619         * exec.c (try_open_exec_file): Use std::move.
4620         * exceptions.h (exception_print, exception_fprintf)
4621         (exception_print_same): Update.
4622         * exceptions.c (print_exception, exception_print)
4623         (exception_fprintf, exception_print_same): Change parameters to
4624         const reference.
4625         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4626         * common/new-op.c: Use std::move.
4627         * common/common-exceptions.h (struct gdb_exception): Add move
4628         constructor.
4629         (struct gdb_exception_error, struct gdb_exception_quit, struct
4630         gdb_quit_bad_alloc): Change constructor to move constructor.
4631         (throw_exception): Change parameter to rvalue reference.
4632         * common/common-exceptions.c (throw_exception): Take rvalue
4633         reference.
4634         * cli/cli-interp.c (safe_execute_command): Use std::move.
4635         * breakpoint.c (insert_bp_location, location_to_sals): Use
4636         std::move.
4637
4638 2019-04-25  Tom Tromey  <tromey@adacore.com>
4639
4640         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4641         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4642         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4643         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4644         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4645         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4646         guile/scm-value.c: Use unpack.
4647         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4648         gdbscm_gdb_exception.
4649         (gdbscm_throw_gdb_exception): Likewise.
4650         (struct gdbscm_gdb_exception): New.
4651         (unpack): New function.
4652         (gdbscm_wrap): Use unpack.
4653
4654 2019-04-25  Tom Tromey  <tromey@adacore.com>
4655
4656         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4657         (gdb_rl_callback_handler): Use std::move.
4658         * common/common-exceptions.h (struct gdb_exception): Add move
4659         assignment operator.
4660         (throw_exception_sjlj): Change "exception" to const reference.
4661         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4662         (throw_exception_sjlj): Change "exception" to const reference.
4663
4664 2019-04-25  Tom Tromey  <tromey@adacore.com>
4665
4666         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4667         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4668         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4669         Update.
4670         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4671         Update.
4672         * mi/mi-interp.c (mi_interp::exec): Update.
4673         * linespec.c (parse_linespec): Update.
4674         * infcall.c (run_inferior_call): Update.
4675         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4676         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4677         (gdbscm_lookup_global_symbol): Update.
4678         * guile/scm-param.c (gdbscm_parameter_value): Update.
4679         * guile/scm-frame.c (gdbscm_frame_read_register)
4680         (gdbscm_frame_read_var): Update.
4681         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4682         * exec.c (try_open_exec_file): Update.
4683         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4684         (gdb_rl_callback_handler): Update.
4685         * common/common-exceptions.h (exception_none): Don't declare.
4686         * common/common-exceptions.c (exception_none): Don't define.
4687         (struct catcher) <exception>: Update.
4688         * cli/cli-interp.c (safe_execute_command): Update.
4689         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4690
4691 2019-04-25  Ali Tamur  <tamur@google.com>
4692
4693         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4694         (read_attribute_value): Likewise.
4695         (dwarf2_read_addr_index): Update comment.
4696         (read_str_index): Add DW_FORM_strx.
4697         (dwarf2_string_attr): Likewise.
4698         (dwarf2_const_value_attr): Likewise.
4699         (dump_die_shallow): Likewise.
4700         (dwarf2_fetch_constant_bytes): Likewise.
4701         (skip_form_bytes): Likewise.
4702         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4703
4704 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4705
4706         PR corefiles/11608
4707         PR corefiles/18187
4708         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4709         OFFSET.  Verify if current mapping contains an ELF header.
4710         (linux_find_memory_regions_full): Adjust call to
4711         dump_mapping_p.
4712
4713 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4714             Kang Li <kanglictf@gmail.com>
4715
4716         PR gdb/21600
4717
4718         * dwarf2-frame.c (read_initial_length): Be consistent about using
4719         unsigned representation of length.
4720         (decode_frame_entry_1): Likewise.  Check for wraparound of
4721         end pointer as well as buffer overflow.
4722
4723 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4724
4725         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4726         "vq".
4727
4728 2019-04-24  Tom Tromey  <tromey@adacore.com>
4729
4730         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4731
4732 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4733
4734         * s12z-tdep.c (s12z_unwind_pc): Delete.
4735         (s12z_unwind_sp): Delete.
4736         (s12z_gdbarch_init): Don't register deleted functions with
4737         gdbarch.
4738
4739 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4740
4741         * rl78-tdep.c (rl78_unwind_sp): Delete.
4742         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4743
4744 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4745
4746         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4747         (xstormy16_unwind_pc): Delete.
4748         (xstormy16_dummy_id): Delete.
4749         (xstormy16_gdbarch_init): Don't register deleted functions with
4750         gdbarch.
4751
4752 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4753
4754         * vax-tdep.c (vax_unwind_pc): Delete.
4755         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4756
4757 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4758
4759         * v850-tdep.c (v850_unwind_sp): Delete.
4760         (v850_unwind_pc): Delete.
4761         (v850_dummy_id): Delete.
4762         (v850_gdbarch_init): Don't register deleted functions with
4763         gdbarch.
4764
4765 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4766
4767         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4768         (tilegx_unwind_pc): Delete.
4769         (tilegx_unwind_dummy_id): Delete.
4770         (tilegx_gdbarch_init): Don't register deleted functions with
4771         gdbarch.
4772
4773 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4774
4775         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4776         (tic6x_dummy_id): Delete.
4777         (tic6x_gdbarch_init): Don't register deleted functions with
4778         gdbarch.
4779
4780 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4781
4782         * sparc-tdep.c (sparc_unwind_pc): Delete.
4783         (sparc32_gdbarch_init): Don't register deleted function with
4784         gdbarch.
4785
4786 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4787
4788         * sh-tdep.c (sh_unwind_sp): Delete.
4789         (sh_unwind_pc): Delete.
4790         (sh_dummy_id): Delete.
4791         (sh_gdbarch_init): Don't register deleted functions with
4792         gdbarch.
4793
4794 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4795
4796         * score-tdep.c (score_unwind_sp): Delete.
4797         (score_unwind_pc): Delete.
4798         (score_dummy_id): Delete.
4799         (score_gdbarch_init): Don't register deleted functions with
4800         gdbarch.
4801
4802 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4803
4804         * rx-tdep.c (rx_unwind_pc): Delete.
4805         (rx_unwind_sp): Delete.
4806         (rx_dummy_id): Delete.
4807         (rx_gdbarch_init): Don't register deleted functions with
4808         gdbarch.  Update comment.
4809
4810 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4811
4812         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4813         (rs6000_dummy_id): Delete.
4814         (rs6000_gdbarch_init): Don't register deleted functions with
4815         gdbarch.
4816
4817 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4818
4819         * or1k-tdep.c (or1k_dummy_id): Delete.
4820         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4821
4822 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4823
4824         * nios2-tdep.c (nios2_dummy_id): Delete.
4825         (nios2_unwind_sp): Delete.
4826         (nios2_gdbarch_init): Don't register deleted functions with
4827         gdbarch.
4828
4829 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4830
4831         * nds32-tdep.c (nds32_dummy_id): Delete.
4832         (nds32_unwind_pc): Delete.
4833         (nds32_unwind_sp): Delete.
4834         (nds32_gdbarch_init): Don't register deleted functions with
4835         gdbarch.
4836
4837 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4838
4839         * msp430-tdep.c (msp430_unwind_pc): Delete.
4840         (msp430_unwind_sp): Delete.
4841         (msp430_dummy_id): Delete.
4842         (msp430_gdbarch_init): Don't register deleted functions with
4843         gdbarch.
4844
4845 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4846
4847         * moxie-tdep.c (moxie_unwind_sp): Delete.
4848         (moxie_unwind_pc): Delete.
4849         (moxie_dummy_id): Delete.
4850         (moxie_gdbarch_init): Don't register deleted functions with
4851         gdbarch.
4852
4853 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4854
4855         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4856         (mn10300_unwind_pc): Delete.
4857         (mn10300_unwind_sp): Delete.
4858         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4859         mn10300_unwind_sp.
4860         (mn10300_frame_unwind_init): Don't register deleted functions with
4861         gdbarch.
4862
4863 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4864
4865         * mep-tdep.c (mep_unwind_pc): Delete.
4866         (mep_unwind_sp): Delete.
4867         (mep_dummy_id): Delete.
4868         (mep_gdbarch_init): Don't register deleted functions with
4869         gdbarch.
4870
4871 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4872
4873         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4874         (m68hc11_unwind_sp): Delete.
4875         (m68hc11_gdbarch_init): Don't register deleted functions with
4876         gdbarch.
4877
4878 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4879
4880         * m32r-tdep.c (m32r_unwind_sp): Delete.
4881         (m32r_unwind_pc): Delete.
4882         (m32r_dummy_id): Delete.
4883         (m32r_gdbarch_init): Don't register deleted functions with
4884         gdbarch.
4885
4886 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4887
4888         * m32c-tdep.c (m32c_unwind_pc): Delete.
4889         (m32c_unwind_sp): Delete.
4890         (m32c_dummy_id): Delete.
4891         (m32c_gdbarch_init): Don't register deleted functions with
4892         gdbarch.
4893
4894 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4895
4896         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4897         (lm32_unwind_pc): Delete.
4898         (lm32_dummy_id): Delete.
4899         (lm32_gdbarch_init): Don't register deleted functions with
4900         gdbarch.
4901
4902 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4903
4904         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4905         (iq2000_unwind_pc): Delete.
4906         (iq2000_dummy_id): Delete.
4907         (iq2000_gdbarch_init): Don't register deleted functions with
4908         gdbarch.
4909
4910 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4911
4912         * nds32-tdep.c (nds32_type_align): Delete.
4913         (nds32_push_dummy_call): Use type_align instead.
4914
4915 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4916
4917         * arm-tdep.c (arm_type_align): Only handle vector override case.
4918         (arm_push_dummy_call): Use type_align.
4919         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4920
4921 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4922
4923         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4924         case.
4925         (pass_on_stack): Use type_align.
4926         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4927         function.
4928
4929 2019-04-23  Tom Tromey  <tromey@adacore.com>
4930
4931         * dwarf2read.c (line_header::file_name_at): Remove unused
4932         overload.
4933
4934 2019-04-23  Tom de Vries  <tdevries@suse.de>
4935
4936         PR gdb/24438
4937         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4938         invocation.
4939
4940
4941 2019-03-27  Ali Tamur  <tamur@google.com>
4942
4943         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4944         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4945         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4946         (dwarf_expr_context::get_addr_index): Likewise
4947         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4948         (symbol_needs_eval_context::get_addr_index): Likewise
4949         (disassemble_dwarf_expression): Add DW_OP_addrx
4950         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4951         (read_cutu_die_from_dwo): Update comment
4952         (skip_one_die): Add DW_FORM_addrx
4953         (read_attribute_value): Likewise
4954         (var_decode_location): Add DW_OP_addrx
4955         (dwarf2_const_value_attr): Add DW_FORM_addrx
4956         (dump_die_shallow): Likewise
4957         (dwarf2_fetch_constant_bytes): Likewise
4958         (decode_locdesc): Add DW_OP_addrx
4959         (skip_form_bytes): Add DW_FORM_addrx
4960
4961 2019-04-22  Ali Tamur  <tamur@google.com>
4962
4963         * MAINTAINERS (Write After Approval): Add self.
4964
4965 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4966
4967         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4968         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4969         (open_symbol_file_object): Likewise.
4970         (svr4_default_sos): Add info parameter.
4971         (svr4_read_so_list): Likewise.
4972         (svr4_current_sos_direct): Adjust functions calls to pass down
4973         info.
4974         (svr4_current_sos_1): Add info parameter.
4975         (svr4_current_sos): Call get_svr4_info, pass info down to
4976         svr4_current_sos_1.
4977         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4978         get_svr4_info.
4979         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4980         get_svr4_info.
4981         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4982         to get_svr4_info.
4983         (probes_table_remove_objfile_probes): Likewise.
4984         (register_solib_event_probe): Add info parameter.
4985         (solist_update_incremental): Pass info parameter down to
4986         svr4_read_so_list.
4987         (disable_probes_interface): Add info parameter.
4988         (svr4_handle_solib_event): Pass current_program_space to
4989         get_svr4_info.  Adjust disable_probes_interface cleanup.
4990         (svr4_create_probe_breakpoints): Add info parameter, pass it
4991         down to register_solib_event_probe.
4992         (svr4_create_solib_event_breakpoints): Add info parameter,
4993         pass it down to svr4_create_probe_breakpoints.
4994         (enable_break): Pass info down to
4995         svr4_create_solib_event_breakpoints.
4996         (svr4_solib_create_inferior_hook): Pass current_program_space to
4997         get_svr4_info.
4998         (svr4_clear_solib): Likewise.
4999
5000 2019-04-22  Pedro Alves  <palves@redhat.com>
5001
5002         * solib-svr4.c (svr4_free_objfile_observer): New.
5003         (probe_and_action::objfile): New field.
5004         (probes_table_htab_remove_objfile_probes)
5005         (probes_table_remove_objfile_probes): New functions.
5006         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5007         in the new probe_and_action.  Don't store the probe in 'lookup'.
5008         (svr4_create_probe_breakpoints): Pass objfile to
5009         register_solib_event_probe.
5010         (_initialize_svr4_solib): Register a free_objfile observer.
5011
5012 2019-04-19  Tom Tromey  <tom@tromey.com>
5013
5014         * common/queue.h: Remove.
5015
5016 2019-04-19  Tom Tromey  <tom@tromey.com>
5017
5018         * event-loop.c: Don't include "common/queue.h".
5019
5020 2019-04-19  Tom Tromey  <tom@tromey.com>
5021
5022         * remote.c (remote_target): Use delete.
5023         * remote-notif.h: Include <list>, not "common/queue.h".
5024         (notif_client_p): Remove typedef.
5025         (remote_notif_state): Add constructor, destructor, initializer.
5026         <notif_queue>: Now a std::list.
5027         (remote_notif_state_xfree): Don't declare.
5028         * remote-notif.c (remote_notif_process, handle_notification)
5029         (remote_notif_state_allocate): Update.
5030         (~remote_notif_state): Rename from remote_notif_state_xfree.
5031
5032 2019-04-19  Tom Tromey  <tom@tromey.com>
5033
5034         * symfile.c (reread_symbols): Update.
5035         * objfiles.c (objfile_register_static_link)
5036         (objfile_lookup_static_link): Update
5037         (~objfile) Don't delete static_links.
5038         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5039
5040 2019-04-19  Tom Tromey  <tom@tromey.com>
5041
5042         * type-stack.h (struct type_stack) <insert>: Constify string.
5043         * type-stack.c (type_stack::insert): Constify string.
5044         * gdbtypes.h (lookup_template_type): Update.
5045         (address_space_name_to_int): Update.
5046         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5047         const.
5048         (lookup_template_type): Make name const.
5049         * c-exp.y: Update rules.
5050         (lex_one_token, classify_name, classify_inner_name)
5051         (c_print_token): Update.
5052         * p-exp.y: Update rules.
5053         (yylex): Update.
5054         * f-exp.y: Update rules.
5055         (yylex): Update.
5056         * d-exp.y: Update rules.
5057         (lex_one_token, classify_name, classify_inner_name): Update.
5058         * parse.c (write_dollar_variable, copy_name): Return std::string.
5059         * parser-defs.h (copy_name): Change return type.
5060         * m2-exp.y: Update rules.
5061         (yylex): Update.
5062         * go-exp.y (lex_one_token): Update.
5063         Update rules.
5064         (classify_unsafe_function, classify_packaged_name)
5065         (classify_name, yylex): Update.
5066
5067 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5068
5069         * configure.ac: add --enable-source-highlight switch.
5070         * configure: Regenerate.
5071         * top.c (print_gdb_version): plumb --enable-source-highlight
5072         status to "show configuration".
5073
5074 2019-04-19  Tom Tromey  <tromey@adacore.com>
5075
5076         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5077         Check ADA_TYPE_P.
5078         (empty_record, ada_template_to_fixed_record_type_1)
5079         (template_to_static_fixed_type)
5080         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5081         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5082         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5083         macros.
5084
5085 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5086
5087         PR symtab/24423:
5088         * source.c (print_source_lines_base): Advance "iter" when a
5089         control character is seen.
5090
5091 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5092
5093         * inferior.h (struct infcall_suspend_state_deleter):
5094         Catch exception in destructor to avoid crash.
5095
5096 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5097
5098         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5099         close to the add_com "shell".
5100
5101 2019-04-18  Tom Tromey  <tromey@adacore.com>
5102
5103         * process-stratum-target.h (class process_stratum_target)
5104         <stratum>: Add "final".
5105
5106 2019-04-17  Tom Tromey  <tromey@adacore.com>
5107
5108         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5109         against nullptr before use.
5110
5111 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5112
5113         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5114
5115 2019-04-17  Jim Wilson  <jimw@sifive.com>
5116             Andrew Burgess  <andrew.burgess@embecosm.com>
5117
5118         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5119         code read might fail, assume 4-byte breakpoint in that case.
5120
5121 2019-04-15  Leszek Swirski  <leszeks@google.com>
5122
5123         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5124         rather than a hand-rolled POD check when checking for forced MEMORY
5125         classification.
5126
5127 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5128
5129         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5130         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5131         function.
5132         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5133         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5134         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5135         declaration.
5136
5137 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5138
5139         * aarch64-linux-nat.c
5140         (aarch64_linux_nat_target::thread_architecture): Add override.
5141         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5142         each VQ.
5143
5144 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5145
5146         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5147
5148 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5149
5150         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5151         target types of size 96-bits, add some additional comments, and
5152         check that the builtin type we found was the correct size.
5153
5154 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5155
5156         * utils.c (prompt_for_continue): Don't restore the styling at the
5157         end, as applied_style has the wrong value.  This fixes styling in
5158         long lists of file names that are interrupted by the "Continue?"
5159         prompt.
5160
5161 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5162
5163         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5164         * c-lang.c (c_language_defn): Likewise.
5165         (cplus_language_defn): Likewise.
5166         (asm_language_defn): Likewise.
5167         (minimal_language_defn): Likewise.
5168         * d-lang.c (d_language_defn): Likewise.
5169         * f-lang.c (f_language_defn): Likewise.
5170         * go-lang.c (go_language_defn): Likewise.
5171         * language.c (unknown_language_defn): Likewise.
5172         (auto_language_defn): Likewise.
5173         * language.h (struct language_defn): Remove la_magic field.
5174         (LANG_MAGIC): Delete.
5175         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5176         * objc-lang.c (objc_language_defn): Likewise.
5177         * opencl-lang.c (opencl_language_defn): Likewise.
5178         * p-lang.c (pascal_language_defn): Likewise.
5179         * rust-lang.c (rust_language_defn): Likewise.
5180
5181 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5182
5183         * riscv-tdep.c (riscv_type_align): New function.
5184         (riscv_type_alignment): Delete.
5185         (riscv_arg_location): Use 'type_align'.
5186         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5187
5188 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5189
5190         * gdbtypes.c (type_align): A struct with no non-static fields also
5191         has alignment of 1.
5192
5193 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5194
5195         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5196         component to 0.
5197         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5198         member.
5199         (riscv_struct_info::analyse): New implementation using new
5200         analyse_inner member function.
5201         (riscv_struct_info::field_offset): New member function.
5202         (riscv_struct_info::m_offsets): New member variable.
5203         (riscv_struct_info::analyse_inner): New private member function,
5204         takes the old implementation of riscv_struct_info::analyse but
5205         extended to track field offsets.
5206         (riscv_call_arg_struct): Update the struct folding special cases
5207         to handle cases where empty C++ structs, which are non-zero
5208         length, are found.
5209         (riscv_arg_location): Initialise the length of each location, a
5210         non-zero length now indicates the location is in use.
5211         (riscv_push_dummy_call): Allow for the first location having a
5212         non-zero offset when setting up arguments.
5213         (riscv_return_value): Likewise, but for return values.
5214
5215 2019-04-11  Tom Tromey  <tromey@adacore.com>
5216
5217         * utils.c (internal_vproblem): Make "msg" const.
5218
5219 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5220
5221         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5222         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5223         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5224         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5225
5226 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5227
5228         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5229         function.
5230         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5231         of amd64_collect_native_gregset.
5232         (amd64_linux_nat_target::store_registers): Likewise.
5233
5234 2019-04-10  Tom Tromey  <tom@tromey.com>
5235
5236         * symtab.c (lookup_global_symbol_from_objfile)
5237         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5238         * objfiles.h (class separate_debug_iterator): New.
5239         (class separate_debug_range): New.
5240         (struct objfile) <separate_debug_objfiles>: New method.
5241         (objfile_separate_debug_iterate): Don't declare.
5242         * objfiles.c (separate_debug_iterator::operator++): Rename from
5243         objfile_separate_debug_iterate.
5244         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5245         iterator.
5246         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5247         iterator.
5248
5249 2019-04-10  Tom Tromey  <tom@tromey.com>
5250
5251         * symfile.c (reread_symbols): Remove old comment.
5252         * objfiles.c (free_all_objfiles): Fix a typo.
5253
5254 2019-04-10  Tom Tromey  <tom@tromey.com>
5255
5256         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5257         * minsyms.c (lookup_minimal_symbol): Use foreach.
5258         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5259         (lookup_minimal_symbol_solib_trampoline): Likewise.
5260         * symfile.c (reread_symbols): Use foreach.
5261
5262 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5263             Tom Tromey  <tromey@adacore.com>
5264
5265         PR rust/24414:
5266         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5267         (rust_lex_int_test): Change "value" to be LONGEST.
5268         (rust_lex_tests): Add test for long integer literal.
5269
5270 2019-04-09  Tom Tromey  <tromey@adacore.com>
5271
5272         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5273         to bool.
5274         (extended_remote_target::attach): Update.
5275         (remote_target::remote_notice_new_inferior): Update.
5276         (remote_target::add_current_inferior_and_thread): Update.
5277         * inferior.c (exit_inferior_1): Use "false".
5278         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5279
5280 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5281
5282         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5283         the "start" command.
5284
5285 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5286
5287         * python/py-inferior.c (infpy_thread_from_thread_handle):
5288         Adjust comments to reflect renaming of thread_from_thread_handle
5289         to thread_from_handle.  Adjust keywords.  Fix type error message.
5290         (inferior_object_methods): Add thread_from_handle.  Retain
5291         thread_from_thread_handle, but mark it as deprecated.
5292
5293 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5294
5295         * gdbthread.h (find_thread_by_handle): Revise declaration.
5296         * thread.c (find_thread_by_handle): Likewise.  Adjust
5297         implementation too.
5298         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5299         support for buffer objects as handles.
5300
5301 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5302
5303         * python/py-infthread.c (thpy_thread_handle): New function.
5304         (thread_object_methods): Register thpy_thread_handle.
5305
5306 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5307
5308         * gdbthread.h (thread_to_thread_handle): Declare.
5309         * thread.c (gdbtypes.h): Include.
5310         (thread_to_thread_handle): New function.
5311
5312         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5313         (target_thread_info_to_thread_handle): Declare.
5314         * target.c (target_thread_info_to_thread_handle): New function.
5315         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5316         * target-delegates.c: Regenerate.
5317
5318         * linux-thread-db.c (class thread_db_target): Add method
5319         thread_info_to_thread_handle.
5320         (thread_db_target::thread_info_to_thread_handle): Define.
5321         * remote.c (class remote_target): Add new method
5322         thread_info_to_thread_handle.
5323         (remote_target::thread_info_to_thread_handle): Define.
5324
5325 2019-04-08  Pedro Alves  <palves@redhat.com>
5326
5327         * common/common-exceptions.c (throw_exception): Don't create
5328         named object to throw; throw directly.
5329         (throw_it): Likewise.  Don't initialize gdb_exception::message
5330         here, with new; pass FMT and AP to the ctor instead.
5331         * common/common-exceptions.h: Include <string>.
5332         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5333         const char *, va_list)): New ctor.  Use std::make_shared.
5334         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5335         errors)): Delete.
5336         (gdb_exception_error::gdb_exception_error(enum errors, const char
5337         *, va_list)): New.
5338         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5339         Add assertion.
5340         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5341         errors)): Delete.
5342         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5343         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5344         Add assertion.
5345
5346 2019-04-08  Tom Tromey  <tom@tromey.com>
5347
5348         * valops.c (value_rtti_indirect_type): Replace throw_exception
5349         with throw.
5350         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5351         with throw.
5352         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5353         throw.
5354         * target.c (target_translate_tls_address): Replace throw_exception
5355         with throw.
5356         * stack.c (frame_apply_command_count): Replace throw_exception
5357         with throw.
5358         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5359         throw.
5360         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5361         with throw.
5362         * rs6000-tdep.c (rs6000_frame_cache)
5363         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5364         * remote.c: Replace throw_exception with throw.
5365         * record-full.c (record_full_message, record_full_wait_1)
5366         (record_full_restore): Replace throw_exception with throw.
5367         * record-btrace.c:
5368         (get_thread_current_frame_id, record_btrace_start_replaying)
5369         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5370         (cmd_record_btrace_start): Replace throw_exception with throw.
5371         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5372         throw.
5373         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5374         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5375         * linespec.c:
5376         (find_linespec_symbols): Replace throw_exception with throw.
5377         * infrun.c (displaced_step_prepare, resume): Replace
5378         throw_exception with throw.
5379         * infcmd.c (post_create_inferior): Replace throw_exception with
5380         throw.
5381         * inf-loop.c (inferior_event_handler): Replace throw_exception
5382         with throw.
5383         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5384         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5385         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5386         (get_prev_frame_always, get_frame_pc_if_available)
5387         (get_frame_address_in_block_if_available, get_frame_language):
5388         Replace throw_exception with throw.
5389         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5390         throw_exception with throw.
5391         * eval.c (fetch_subexp_value, evaluate_var_value)
5392         (evaluate_funcall, evaluate_subexp_standard): Replace
5393         throw_exception with throw.
5394         * dwarf2loc.c (call_site_find_chain)
5395         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5396         Replace throw_exception with throw.
5397         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5398         with throw.
5399         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5400         throw.
5401         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5402         * completer.c (complete_line_internal): Replace throw_exception
5403         with throw.
5404         * compile/compile-object-run.c (compile_object_run): Replace
5405         throw_exception with throw.
5406         * cli/cli-script.c (process_next_line): Replace throw_exception
5407         with throw.
5408         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5409         (btrace_enable, btrace_maint_update_pt_packets): Replace
5410         throw_exception with throw.
5411         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5412         throw_exception with throw.
5413         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5414         throw_exception with throw.
5415         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5416         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5417         * aarch64-tdep.c (aarch64_make_prologue_cache)
5418         (aarch64_make_stub_cache): Replace throw_exception with throw.
5419
5420 2019-04-08  Tom Tromey  <tom@tromey.com>
5421
5422         * common/common-exceptions.c (throw_exception): Rename from
5423         throw_exception_cxx.  Remove old copy.  Make argument const.
5424         (throw_it): Create and throw exception objects directly.
5425         * common/common-exceptions.h (throw_exception): Make argument
5426         const.
5427         (struct gdb_exception_error): Add constructor.
5428         (struct gdb_exception_quit): Add constructor.
5429
5430 2019-04-08  Tom Tromey  <tom@tromey.com>
5431
5432         * common/common-exceptions.h (exception_rethrow): Don't declare.
5433         (TRY_SJLJ): Update comment.
5434         (TRY, CATCH, END_CATCH): Remove.
5435         * common/common-exceptions.c (exception_rethrow): Remove.
5436
5437 2019-04-08  Tom Tromey  <tom@tromey.com>
5438
5439         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5440         Remove.
5441         (gdb_exception_error): Rename from
5442         gdb_exception_RETURN_MASK_ERROR.
5443         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5444         (gdb_quit_bad_alloc): Update.
5445         * aarch64-tdep.c: Update.
5446         * ada-lang.c: Update.
5447         * ada-typeprint.c: Update.
5448         * ada-valprint.c: Update.
5449         * amd64-tdep.c: Update.
5450         * arch-utils.c: Update.
5451         * break-catch-throw.c: Update.
5452         * breakpoint.c: Update.
5453         * btrace.c: Update.
5454         * c-varobj.c: Update.
5455         * cli/cli-cmds.c: Update.
5456         * cli/cli-interp.c: Update.
5457         * cli/cli-script.c: Update.
5458         * common/common-exceptions.c: Update.
5459         * common/new-op.c: Update.
5460         * common/selftest.c: Update.
5461         * compile/compile-c-symbols.c: Update.
5462         * compile/compile-cplus-symbols.c: Update.
5463         * compile/compile-object-load.c: Update.
5464         * compile/compile-object-run.c: Update.
5465         * completer.c: Update.
5466         * corelow.c: Update.
5467         * cp-abi.c: Update.
5468         * cp-support.c: Update.
5469         * cp-valprint.c: Update.
5470         * darwin-nat.c: Update.
5471         * disasm-selftests.c: Update.
5472         * dtrace-probe.c: Update.
5473         * dwarf-index-cache.c: Update.
5474         * dwarf-index-write.c: Update.
5475         * dwarf2-frame-tailcall.c: Update.
5476         * dwarf2-frame.c: Update.
5477         * dwarf2loc.c: Update.
5478         * dwarf2read.c: Update.
5479         * eval.c: Update.
5480         * event-loop.c: Update.
5481         * event-top.c: Update.
5482         * exec.c: Update.
5483         * f-valprint.c: Update.
5484         * fbsd-tdep.c: Update.
5485         * frame-unwind.c: Update.
5486         * frame.c: Update.
5487         * gdbtypes.c: Update.
5488         * gnu-v3-abi.c: Update.
5489         * guile/guile-internal.h: Update.
5490         * guile/scm-block.c: Update.
5491         * guile/scm-breakpoint.c: Update.
5492         * guile/scm-cmd.c: Update.
5493         * guile/scm-disasm.c: Update.
5494         * guile/scm-frame.c: Update.
5495         * guile/scm-lazy-string.c: Update.
5496         * guile/scm-math.c: Update.
5497         * guile/scm-param.c: Update.
5498         * guile/scm-ports.c: Update.
5499         * guile/scm-pretty-print.c: Update.
5500         * guile/scm-symbol.c: Update.
5501         * guile/scm-symtab.c: Update.
5502         * guile/scm-type.c: Update.
5503         * guile/scm-value.c: Update.
5504         * i386-linux-tdep.c: Update.
5505         * i386-tdep.c: Update.
5506         * inf-loop.c: Update.
5507         * infcall.c: Update.
5508         * infcmd.c: Update.
5509         * infrun.c: Update.
5510         * jit.c: Update.
5511         * language.c: Update.
5512         * linespec.c: Update.
5513         * linux-fork.c: Update.
5514         * linux-nat.c: Update.
5515         * linux-tdep.c: Update.
5516         * linux-thread-db.c: Update.
5517         * main.c: Update.
5518         * mi/mi-cmd-break.c: Update.
5519         * mi/mi-cmd-stack.c: Update.
5520         * mi/mi-interp.c: Update.
5521         * mi/mi-main.c: Update.
5522         * objc-lang.c: Update.
5523         * p-valprint.c: Update.
5524         * parse.c: Update.
5525         * ppc-linux-tdep.c: Update.
5526         * printcmd.c: Update.
5527         * python/py-arch.c: Update.
5528         * python/py-breakpoint.c: Update.
5529         * python/py-cmd.c: Update.
5530         * python/py-finishbreakpoint.c: Update.
5531         * python/py-frame.c: Update.
5532         * python/py-framefilter.c: Update.
5533         * python/py-gdb-readline.c: Update.
5534         * python/py-inferior.c: Update.
5535         * python/py-infthread.c: Update.
5536         * python/py-lazy-string.c: Update.
5537         * python/py-linetable.c: Update.
5538         * python/py-objfile.c: Update.
5539         * python/py-param.c: Update.
5540         * python/py-prettyprint.c: Update.
5541         * python/py-progspace.c: Update.
5542         * python/py-record-btrace.c: Update.
5543         * python/py-record.c: Update.
5544         * python/py-symbol.c: Update.
5545         * python/py-type.c: Update.
5546         * python/py-unwind.c: Update.
5547         * python/py-utils.c: Update.
5548         * python/py-value.c: Update.
5549         * python/python.c: Update.
5550         * record-btrace.c: Update.
5551         * record-full.c: Update.
5552         * remote-fileio.c: Update.
5553         * remote.c: Update.
5554         * riscv-tdep.c: Update.
5555         * rs6000-aix-tdep.c: Update.
5556         * rs6000-tdep.c: Update.
5557         * rust-exp.y: Update.
5558         * rust-lang.c: Update.
5559         * s390-tdep.c: Update.
5560         * selftest-arch.c: Update.
5561         * solib-dsbt.c: Update.
5562         * solib-frv.c: Update.
5563         * solib-spu.c: Update.
5564         * solib-svr4.c: Update.
5565         * solib.c: Update.
5566         * sparc64-linux-tdep.c: Update.
5567         * stack.c: Update.
5568         * symfile-mem.c: Update.
5569         * symmisc.c: Update.
5570         * target.c: Update.
5571         * thread.c: Update.
5572         * top.c: Update.
5573         * tracefile-tfile.c: Update.
5574         * tui/tui.c: Update.
5575         * typeprint.c: Update.
5576         * unittests/cli-utils-selftests.c: Update.
5577         * unittests/parse-connection-spec-selftests.c: Update.
5578         * valops.c: Update.
5579         * valprint.c: Update.
5580         * value.c: Update.
5581         * varobj.c: Update.
5582         * windows-nat.c: Update.
5583         * x86-linux-nat.c: Update.
5584         * xml-support.c: Update.
5585
5586 2019-04-08  Tom Tromey  <tom@tromey.com>
5587
5588         * xml-support.c: Use C++ exception handling.
5589         * x86-linux-nat.c: Use C++ exception handling.
5590         * windows-nat.c: Use C++ exception handling.
5591         * varobj.c: Use C++ exception handling.
5592         * value.c: Use C++ exception handling.
5593         * valprint.c: Use C++ exception handling.
5594         * valops.c: Use C++ exception handling.
5595         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5596         handling.
5597         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5598         * typeprint.c: Use C++ exception handling.
5599         * tui/tui.c: Use C++ exception handling.
5600         * tracefile-tfile.c: Use C++ exception handling.
5601         * top.c: Use C++ exception handling.
5602         * thread.c: Use C++ exception handling.
5603         * target.c: Use C++ exception handling.
5604         * symmisc.c: Use C++ exception handling.
5605         * symfile-mem.c: Use C++ exception handling.
5606         * stack.c: Use C++ exception handling.
5607         * sparc64-linux-tdep.c: Use C++ exception handling.
5608         * solib.c: Use C++ exception handling.
5609         * solib-svr4.c: Use C++ exception handling.
5610         * solib-spu.c: Use C++ exception handling.
5611         * solib-frv.c: Use C++ exception handling.
5612         * solib-dsbt.c: Use C++ exception handling.
5613         * selftest-arch.c: Use C++ exception handling.
5614         * s390-tdep.c: Use C++ exception handling.
5615         * rust-lang.c: Use C++ exception handling.
5616         * rust-exp.y: Use C++ exception handling.
5617         * rs6000-tdep.c: Use C++ exception handling.
5618         * rs6000-aix-tdep.c: Use C++ exception handling.
5619         * riscv-tdep.c: Use C++ exception handling.
5620         * remote.c: Use C++ exception handling.
5621         * remote-fileio.c: Use C++ exception handling.
5622         * record-full.c: Use C++ exception handling.
5623         * record-btrace.c: Use C++ exception handling.
5624         * python/python.c: Use C++ exception handling.
5625         * python/py-value.c: Use C++ exception handling.
5626         * python/py-utils.c: Use C++ exception handling.
5627         * python/py-unwind.c: Use C++ exception handling.
5628         * python/py-type.c: Use C++ exception handling.
5629         * python/py-symbol.c: Use C++ exception handling.
5630         * python/py-record.c: Use C++ exception handling.
5631         * python/py-record-btrace.c: Use C++ exception handling.
5632         * python/py-progspace.c: Use C++ exception handling.
5633         * python/py-prettyprint.c: Use C++ exception handling.
5634         * python/py-param.c: Use C++ exception handling.
5635         * python/py-objfile.c: Use C++ exception handling.
5636         * python/py-linetable.c: Use C++ exception handling.
5637         * python/py-lazy-string.c: Use C++ exception handling.
5638         * python/py-infthread.c: Use C++ exception handling.
5639         * python/py-inferior.c: Use C++ exception handling.
5640         * python/py-gdb-readline.c: Use C++ exception handling.
5641         * python/py-framefilter.c: Use C++ exception handling.
5642         * python/py-frame.c: Use C++ exception handling.
5643         * python/py-finishbreakpoint.c: Use C++ exception handling.
5644         * python/py-cmd.c: Use C++ exception handling.
5645         * python/py-breakpoint.c: Use C++ exception handling.
5646         * python/py-arch.c: Use C++ exception handling.
5647         * printcmd.c: Use C++ exception handling.
5648         * ppc-linux-tdep.c: Use C++ exception handling.
5649         * parse.c: Use C++ exception handling.
5650         * p-valprint.c: Use C++ exception handling.
5651         * objc-lang.c: Use C++ exception handling.
5652         * mi/mi-main.c: Use C++ exception handling.
5653         * mi/mi-interp.c: Use C++ exception handling.
5654         * mi/mi-cmd-stack.c: Use C++ exception handling.
5655         * mi/mi-cmd-break.c: Use C++ exception handling.
5656         * main.c: Use C++ exception handling.
5657         * linux-thread-db.c: Use C++ exception handling.
5658         * linux-tdep.c: Use C++ exception handling.
5659         * linux-nat.c: Use C++ exception handling.
5660         * linux-fork.c: Use C++ exception handling.
5661         * linespec.c: Use C++ exception handling.
5662         * language.c: Use C++ exception handling.
5663         * jit.c: Use C++ exception handling.
5664         * infrun.c: Use C++ exception handling.
5665         * infcmd.c: Use C++ exception handling.
5666         * infcall.c: Use C++ exception handling.
5667         * inf-loop.c: Use C++ exception handling.
5668         * i386-tdep.c: Use C++ exception handling.
5669         * i386-linux-tdep.c: Use C++ exception handling.
5670         * guile/scm-value.c: Use C++ exception handling.
5671         * guile/scm-type.c: Use C++ exception handling.
5672         * guile/scm-symtab.c: Use C++ exception handling.
5673         * guile/scm-symbol.c: Use C++ exception handling.
5674         * guile/scm-pretty-print.c: Use C++ exception handling.
5675         * guile/scm-ports.c: Use C++ exception handling.
5676         * guile/scm-param.c: Use C++ exception handling.
5677         * guile/scm-math.c: Use C++ exception handling.
5678         * guile/scm-lazy-string.c: Use C++ exception handling.
5679         * guile/scm-frame.c: Use C++ exception handling.
5680         * guile/scm-disasm.c: Use C++ exception handling.
5681         * guile/scm-cmd.c: Use C++ exception handling.
5682         * guile/scm-breakpoint.c: Use C++ exception handling.
5683         * guile/scm-block.c: Use C++ exception handling.
5684         * guile/guile-internal.h: Use C++ exception handling.
5685         * gnu-v3-abi.c: Use C++ exception handling.
5686         * gdbtypes.c: Use C++ exception handling.
5687         * frame.c: Use C++ exception handling.
5688         * frame-unwind.c: Use C++ exception handling.
5689         * fbsd-tdep.c: Use C++ exception handling.
5690         * f-valprint.c: Use C++ exception handling.
5691         * exec.c: Use C++ exception handling.
5692         * event-top.c: Use C++ exception handling.
5693         * event-loop.c: Use C++ exception handling.
5694         * eval.c: Use C++ exception handling.
5695         * dwarf2read.c: Use C++ exception handling.
5696         * dwarf2loc.c: Use C++ exception handling.
5697         * dwarf2-frame.c: Use C++ exception handling.
5698         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5699         * dwarf-index-write.c: Use C++ exception handling.
5700         * dwarf-index-cache.c: Use C++ exception handling.
5701         * dtrace-probe.c: Use C++ exception handling.
5702         * disasm-selftests.c: Use C++ exception handling.
5703         * darwin-nat.c: Use C++ exception handling.
5704         * cp-valprint.c: Use C++ exception handling.
5705         * cp-support.c: Use C++ exception handling.
5706         * cp-abi.c: Use C++ exception handling.
5707         * corelow.c: Use C++ exception handling.
5708         * completer.c: Use C++ exception handling.
5709         * compile/compile-object-run.c: Use C++ exception handling.
5710         * compile/compile-object-load.c: Use C++ exception handling.
5711         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5712         * compile/compile-c-symbols.c: Use C++ exception handling.
5713         * common/selftest.c: Use C++ exception handling.
5714         * common/new-op.c: Use C++ exception handling.
5715         * cli/cli-script.c: Use C++ exception handling.
5716         * cli/cli-interp.c: Use C++ exception handling.
5717         * cli/cli-cmds.c: Use C++ exception handling.
5718         * c-varobj.c: Use C++ exception handling.
5719         * btrace.c: Use C++ exception handling.
5720         * breakpoint.c: Use C++ exception handling.
5721         * break-catch-throw.c: Use C++ exception handling.
5722         * arch-utils.c: Use C++ exception handling.
5723         * amd64-tdep.c: Use C++ exception handling.
5724         * ada-valprint.c: Use C++ exception handling.
5725         * ada-typeprint.c: Use C++ exception handling.
5726         * ada-lang.c: Use C++ exception handling.
5727         * aarch64-tdep.c: Use C++ exception handling.
5728
5729 2019-04-08  Tom Tromey  <tom@tromey.com>
5730
5731         * xml-support.c (gdb_xml_parser::parse): Update.
5732         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5733         * value.c (show_convenience): Update.
5734         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5735         (test_parse_flags_qcs): Update.
5736         * thread.c (thr_try_catch_cmd): Update.
5737         * target.c (target_translate_tls_address): Update.
5738         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5739         (info_frame_command_core, frame_apply_command_count): Update.
5740         * rust-exp.y (rust_lex_exception_test): Update.
5741         * riscv-tdep.c (riscv_print_one_register_info): Update.
5742         * remote.c (remote_target::enable_btrace): Update.
5743         * record-btrace.c (record_btrace_enable_warn): Update.
5744         * python/py-utils.c (gdbpy_convert_exception): Update.
5745         * printcmd.c (do_one_display, print_variable_and_value): Update.
5746         * mi/mi-main.c (mi_print_exception): Update.
5747         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5748         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5749         * linux-nat.c (linux_nat_target::attach): Update.
5750         * linux-fork.c (class scoped_switch_fork_info): Update.
5751         * infrun.c (displaced_step_prepare): Update.
5752         * infcall.c (call_function_by_hand_dummy): Update.
5753         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5754         * gnu-v3-abi.c (print_one_vtable): Update.
5755         * frame.c (get_prev_frame_always): Update.
5756         * f-valprint.c (info_common_command_for_block): Update.
5757         * exec.c (try_open_exec_file): Update.
5758         * exceptions.c (print_exception, exception_print)
5759         (exception_fprintf, exception_print_same): Update.
5760         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5761         * dwarf-index-cache.c (index_cache::store)
5762         (index_cache::lookup_gdb_index): Update.
5763         * darwin-nat.c (maybe_cache_shell): Update.
5764         * cp-valprint.c (cp_print_value_fields): Update.
5765         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5766         (gcc_cplus_symbol_address): Update.
5767         * compile/compile-c-symbols.c (gcc_convert_symbol)
5768         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5769         * common/selftest.c: Update.
5770         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5771         a std::string.
5772         (exception_try_scope_entry, exception_try_scope_exit): Don't
5773         declare.
5774         (struct exception_try_scope): Remove.
5775         (TRY): Don't use exception_try_scope.
5776         (struct gdb_exception): Add constructor, operator=.
5777         <what>: New method.
5778         (struct gdb_exception_RETURN_MASK_ALL)
5779         (struct gdb_exception_RETURN_MASK_ERROR)
5780         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5781         (struct gdb_quit_bad_alloc): Update.
5782         * common/common-exceptions.c (exception_none): Change
5783         initializer.
5784         (struct catcher) <state, exception>: Initialize inline.
5785         <prev>: Remove member.
5786         (current_catcher): Remove.
5787         (catchers): New global.
5788         (exceptions_state_mc_init): Simplify.
5789         (catcher_pop): Remove.
5790         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5791         (try_scope_depth, exception_try_scope_entry)
5792         (exception_try_scope_exit): Remove.
5793         (throw_exception_sjlj): Update.
5794         (exception_messages, exception_messages_size): Remove.
5795         (throw_it): Simplify.
5796         (gdb_exception_sliced_copy): Remove.
5797         (throw_exception_cxx): Update.
5798         * cli/cli-script.c (script_from_file): Update.
5799         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5800         Update.
5801         * ada-valprint.c (ada_val_print): Update.
5802         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5803         (create_excep_cond_exprs): Update.
5804
5805 2019-04-08  Tom Tromey  <tom@tromey.com>
5806
5807         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5808         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5809         (TRY, CATCH, END_CATCH): Remove some definitions.
5810         * common/common-exceptions.c: Don't use GDB_XCPT.
5811         (catcher_list_size): Remove.
5812         (throw_exception, throw_it): Simplify.
5813
5814 2019-04-05  Tom Tromey  <tom@tromey.com>
5815
5816         Revert the header-sorting patch.
5817         * ft32-tdep.c: Revert.
5818         * frv-tdep.c: Revert.
5819         * frv-linux-tdep.c: Revert.
5820         * frame.c: Revert.
5821         * frame-unwind.c: Revert.
5822         * frame-base.c: Revert.
5823         * fork-child.c: Revert.
5824         * findvar.c: Revert.
5825         * findcmd.c: Revert.
5826         * filesystem.c: Revert.
5827         * filename-seen-cache.h: Revert.
5828         * filename-seen-cache.c: Revert.
5829         * fbsd-tdep.c: Revert.
5830         * fbsd-nat.h: Revert.
5831         * fbsd-nat.c: Revert.
5832         * f-valprint.c: Revert.
5833         * f-typeprint.c: Revert.
5834         * f-lang.c: Revert.
5835         * extension.h: Revert.
5836         * extension.c: Revert.
5837         * extension-priv.h: Revert.
5838         * expprint.c: Revert.
5839         * exec.h: Revert.
5840         * exec.c: Revert.
5841         * exceptions.c: Revert.
5842         * event-top.c: Revert.
5843         * event-loop.c: Revert.
5844         * eval.c: Revert.
5845         * elfread.c: Revert.
5846         * dwarf2read.h: Revert.
5847         * dwarf2read.c: Revert.
5848         * dwarf2loc.c: Revert.
5849         * dwarf2expr.h: Revert.
5850         * dwarf2expr.c: Revert.
5851         * dwarf2-frame.c: Revert.
5852         * dwarf2-frame-tailcall.c: Revert.
5853         * dwarf-index-write.h: Revert.
5854         * dwarf-index-write.c: Revert.
5855         * dwarf-index-common.c: Revert.
5856         * dwarf-index-cache.h: Revert.
5857         * dwarf-index-cache.c: Revert.
5858         * dummy-frame.c: Revert.
5859         * dtrace-probe.c: Revert.
5860         * disasm.h: Revert.
5861         * disasm.c: Revert.
5862         * disasm-selftests.c: Revert.
5863         * dictionary.c: Revert.
5864         * dicos-tdep.c: Revert.
5865         * demangle.c: Revert.
5866         * dcache.h: Revert.
5867         * dcache.c: Revert.
5868         * darwin-nat.h: Revert.
5869         * darwin-nat.c: Revert.
5870         * darwin-nat-info.c: Revert.
5871         * d-valprint.c: Revert.
5872         * d-namespace.c: Revert.
5873         * d-lang.c: Revert.
5874         * ctf.c: Revert.
5875         * csky-tdep.c: Revert.
5876         * csky-linux-tdep.c: Revert.
5877         * cris-tdep.c: Revert.
5878         * cris-linux-tdep.c: Revert.
5879         * cp-valprint.c: Revert.
5880         * cp-support.c: Revert.
5881         * cp-namespace.c: Revert.
5882         * cp-abi.c: Revert.
5883         * corelow.c: Revert.
5884         * corefile.c: Revert.
5885         * continuations.c: Revert.
5886         * completer.h: Revert.
5887         * completer.c: Revert.
5888         * complaints.c: Revert.
5889         * coffread.c: Revert.
5890         * coff-pe-read.c: Revert.
5891         * cli-out.h: Revert.
5892         * cli-out.c: Revert.
5893         * charset.c: Revert.
5894         * c-varobj.c: Revert.
5895         * c-valprint.c: Revert.
5896         * c-typeprint.c: Revert.
5897         * c-lang.c: Revert.
5898         * buildsym.c: Revert.
5899         * buildsym-legacy.c: Revert.
5900         * build-id.h: Revert.
5901         * build-id.c: Revert.
5902         * btrace.c: Revert.
5903         * bsd-uthread.c: Revert.
5904         * breakpoint.h: Revert.
5905         * breakpoint.c: Revert.
5906         * break-catch-throw.c: Revert.
5907         * break-catch-syscall.c: Revert.
5908         * break-catch-sig.c: Revert.
5909         * blockframe.c: Revert.
5910         * block.c: Revert.
5911         * bfin-tdep.c: Revert.
5912         * bfin-linux-tdep.c: Revert.
5913         * bfd-target.c: Revert.
5914         * bcache.c: Revert.
5915         * ax-general.c: Revert.
5916         * ax-gdb.h: Revert.
5917         * ax-gdb.c: Revert.
5918         * avr-tdep.c: Revert.
5919         * auxv.c: Revert.
5920         * auto-load.c: Revert.
5921         * arm-wince-tdep.c: Revert.
5922         * arm-tdep.c: Revert.
5923         * arm-symbian-tdep.c: Revert.
5924         * arm-pikeos-tdep.c: Revert.
5925         * arm-obsd-tdep.c: Revert.
5926         * arm-nbsd-tdep.c: Revert.
5927         * arm-nbsd-nat.c: Revert.
5928         * arm-linux-tdep.c: Revert.
5929         * arm-linux-nat.c: Revert.
5930         * arm-fbsd-tdep.c: Revert.
5931         * arm-fbsd-nat.c: Revert.
5932         * arm-bsd-tdep.c: Revert.
5933         * arch-utils.c: Revert.
5934         * arc-tdep.c: Revert.
5935         * arc-newlib-tdep.c: Revert.
5936         * annotate.h: Revert.
5937         * annotate.c: Revert.
5938         * amd64-windows-tdep.c: Revert.
5939         * amd64-windows-nat.c: Revert.
5940         * amd64-tdep.c: Revert.
5941         * amd64-sol2-tdep.c: Revert.
5942         * amd64-obsd-tdep.c: Revert.
5943         * amd64-obsd-nat.c: Revert.
5944         * amd64-nbsd-tdep.c: Revert.
5945         * amd64-nbsd-nat.c: Revert.
5946         * amd64-nat.c: Revert.
5947         * amd64-linux-tdep.c: Revert.
5948         * amd64-linux-nat.c: Revert.
5949         * amd64-fbsd-tdep.c: Revert.
5950         * amd64-fbsd-nat.c: Revert.
5951         * amd64-dicos-tdep.c: Revert.
5952         * amd64-darwin-tdep.c: Revert.
5953         * amd64-bsd-nat.c: Revert.
5954         * alpha-tdep.c: Revert.
5955         * alpha-obsd-tdep.c: Revert.
5956         * alpha-nbsd-tdep.c: Revert.
5957         * alpha-mdebug-tdep.c: Revert.
5958         * alpha-linux-tdep.c: Revert.
5959         * alpha-linux-nat.c: Revert.
5960         * alpha-bsd-tdep.c: Revert.
5961         * alpha-bsd-nat.c: Revert.
5962         * aix-thread.c: Revert.
5963         * agent.c: Revert.
5964         * addrmap.c: Revert.
5965         * ada-varobj.c: Revert.
5966         * ada-valprint.c: Revert.
5967         * ada-typeprint.c: Revert.
5968         * ada-tasks.c: Revert.
5969         * ada-lang.c: Revert.
5970         * aarch64-tdep.c: Revert.
5971         * aarch64-ravenscar-thread.c: Revert.
5972         * aarch64-newlib-tdep.c: Revert.
5973         * aarch64-linux-tdep.c: Revert.
5974         * aarch64-linux-nat.c: Revert.
5975         * aarch64-fbsd-tdep.c: Revert.
5976         * aarch64-fbsd-nat.c: Revert.
5977         * aarch32-linux-nat.c: Revert.
5978
5979 2019-04-05  Tom Tromey  <tom@tromey.com>
5980
5981         * ft32-tdep.c: Sort headers.
5982         * frv-tdep.c: Sort headers.
5983         * frv-linux-tdep.c: Sort headers.
5984         * frame.c: Sort headers.
5985         * frame-unwind.c: Sort headers.
5986         * frame-base.c: Sort headers.
5987         * fork-child.c: Sort headers.
5988         * findvar.c: Sort headers.
5989         * findcmd.c: Sort headers.
5990         * filesystem.c: Sort headers.
5991         * filename-seen-cache.h: Sort headers.
5992         * filename-seen-cache.c: Sort headers.
5993         * fbsd-tdep.c: Sort headers.
5994         * fbsd-nat.h: Sort headers.
5995         * fbsd-nat.c: Sort headers.
5996         * f-valprint.c: Sort headers.
5997         * f-typeprint.c: Sort headers.
5998         * f-lang.c: Sort headers.
5999         * extension.h: Sort headers.
6000         * extension.c: Sort headers.
6001         * extension-priv.h: Sort headers.
6002         * expprint.c: Sort headers.
6003         * exec.h: Sort headers.
6004         * exec.c: Sort headers.
6005         * exceptions.c: Sort headers.
6006         * event-top.c: Sort headers.
6007         * event-loop.c: Sort headers.
6008         * eval.c: Sort headers.
6009         * elfread.c: Sort headers.
6010         * dwarf2read.h: Sort headers.
6011         * dwarf2read.c: Sort headers.
6012         * dwarf2loc.c: Sort headers.
6013         * dwarf2expr.h: Sort headers.
6014         * dwarf2expr.c: Sort headers.
6015         * dwarf2-frame.c: Sort headers.
6016         * dwarf2-frame-tailcall.c: Sort headers.
6017         * dwarf-index-write.h: Sort headers.
6018         * dwarf-index-write.c: Sort headers.
6019         * dwarf-index-common.c: Sort headers.
6020         * dwarf-index-cache.h: Sort headers.
6021         * dwarf-index-cache.c: Sort headers.
6022         * dummy-frame.c: Sort headers.
6023         * dtrace-probe.c: Sort headers.
6024         * disasm.h: Sort headers.
6025         * disasm.c: Sort headers.
6026         * disasm-selftests.c: Sort headers.
6027         * dictionary.c: Sort headers.
6028         * dicos-tdep.c: Sort headers.
6029         * demangle.c: Sort headers.
6030         * dcache.h: Sort headers.
6031         * dcache.c: Sort headers.
6032         * darwin-nat.h: Sort headers.
6033         * darwin-nat.c: Sort headers.
6034         * darwin-nat-info.c: Sort headers.
6035         * d-valprint.c: Sort headers.
6036         * d-namespace.c: Sort headers.
6037         * d-lang.c: Sort headers.
6038         * ctf.c: Sort headers.
6039         * csky-tdep.c: Sort headers.
6040         * csky-linux-tdep.c: Sort headers.
6041         * cris-tdep.c: Sort headers.
6042         * cris-linux-tdep.c: Sort headers.
6043         * cp-valprint.c: Sort headers.
6044         * cp-support.c: Sort headers.
6045         * cp-namespace.c: Sort headers.
6046         * cp-abi.c: Sort headers.
6047         * corelow.c: Sort headers.
6048         * corefile.c: Sort headers.
6049         * continuations.c: Sort headers.
6050         * completer.h: Sort headers.
6051         * completer.c: Sort headers.
6052         * complaints.c: Sort headers.
6053         * coffread.c: Sort headers.
6054         * coff-pe-read.c: Sort headers.
6055         * cli-out.h: Sort headers.
6056         * cli-out.c: Sort headers.
6057         * charset.c: Sort headers.
6058         * c-varobj.c: Sort headers.
6059         * c-valprint.c: Sort headers.
6060         * c-typeprint.c: Sort headers.
6061         * c-lang.c: Sort headers.
6062         * buildsym.c: Sort headers.
6063         * buildsym-legacy.c: Sort headers.
6064         * build-id.h: Sort headers.
6065         * build-id.c: Sort headers.
6066         * btrace.c: Sort headers.
6067         * bsd-uthread.c: Sort headers.
6068         * breakpoint.h: Sort headers.
6069         * breakpoint.c: Sort headers.
6070         * break-catch-throw.c: Sort headers.
6071         * break-catch-syscall.c: Sort headers.
6072         * break-catch-sig.c: Sort headers.
6073         * blockframe.c: Sort headers.
6074         * block.c: Sort headers.
6075         * bfin-tdep.c: Sort headers.
6076         * bfin-linux-tdep.c: Sort headers.
6077         * bfd-target.c: Sort headers.
6078         * bcache.c: Sort headers.
6079         * ax-general.c: Sort headers.
6080         * ax-gdb.h: Sort headers.
6081         * ax-gdb.c: Sort headers.
6082         * avr-tdep.c: Sort headers.
6083         * auxv.c: Sort headers.
6084         * auto-load.c: Sort headers.
6085         * arm-wince-tdep.c: Sort headers.
6086         * arm-tdep.c: Sort headers.
6087         * arm-symbian-tdep.c: Sort headers.
6088         * arm-pikeos-tdep.c: Sort headers.
6089         * arm-obsd-tdep.c: Sort headers.
6090         * arm-nbsd-tdep.c: Sort headers.
6091         * arm-nbsd-nat.c: Sort headers.
6092         * arm-linux-tdep.c: Sort headers.
6093         * arm-linux-nat.c: Sort headers.
6094         * arm-fbsd-tdep.c: Sort headers.
6095         * arm-fbsd-nat.c: Sort headers.
6096         * arm-bsd-tdep.c: Sort headers.
6097         * arch-utils.c: Sort headers.
6098         * arc-tdep.c: Sort headers.
6099         * arc-newlib-tdep.c: Sort headers.
6100         * annotate.h: Sort headers.
6101         * annotate.c: Sort headers.
6102         * amd64-windows-tdep.c: Sort headers.
6103         * amd64-windows-nat.c: Sort headers.
6104         * amd64-tdep.c: Sort headers.
6105         * amd64-sol2-tdep.c: Sort headers.
6106         * amd64-obsd-tdep.c: Sort headers.
6107         * amd64-obsd-nat.c: Sort headers.
6108         * amd64-nbsd-tdep.c: Sort headers.
6109         * amd64-nbsd-nat.c: Sort headers.
6110         * amd64-nat.c: Sort headers.
6111         * amd64-linux-tdep.c: Sort headers.
6112         * amd64-linux-nat.c: Sort headers.
6113         * amd64-fbsd-tdep.c: Sort headers.
6114         * amd64-fbsd-nat.c: Sort headers.
6115         * amd64-dicos-tdep.c: Sort headers.
6116         * amd64-darwin-tdep.c: Sort headers.
6117         * amd64-bsd-nat.c: Sort headers.
6118         * alpha-tdep.c: Sort headers.
6119         * alpha-obsd-tdep.c: Sort headers.
6120         * alpha-nbsd-tdep.c: Sort headers.
6121         * alpha-mdebug-tdep.c: Sort headers.
6122         * alpha-linux-tdep.c: Sort headers.
6123         * alpha-linux-nat.c: Sort headers.
6124         * alpha-bsd-tdep.c: Sort headers.
6125         * alpha-bsd-nat.c: Sort headers.
6126         * aix-thread.c: Sort headers.
6127         * agent.c: Sort headers.
6128         * addrmap.c: Sort headers.
6129         * ada-varobj.c: Sort headers.
6130         * ada-valprint.c: Sort headers.
6131         * ada-typeprint.c: Sort headers.
6132         * ada-tasks.c: Sort headers.
6133         * ada-lang.c: Sort headers.
6134         * aarch64-tdep.c: Sort headers.
6135         * aarch64-ravenscar-thread.c: Sort headers.
6136         * aarch64-newlib-tdep.c: Sort headers.
6137         * aarch64-linux-tdep.c: Sort headers.
6138         * aarch64-linux-nat.c: Sort headers.
6139         * aarch64-fbsd-tdep.c: Sort headers.
6140         * aarch64-fbsd-nat.c: Sort headers.
6141         * aarch32-linux-nat.c: Sort headers.
6142
6143 2019-04-04  Tom Tromey  <tom@tromey.com>
6144
6145         * varobj.c (varobj_create): Update.
6146         * rust-exp.y (struct rust_parser) <update_innermost_block,
6147         lookup_symbol>: New methods.
6148         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6149         Rename.
6150         (rust_parser::rust_lookup_type)
6151         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6152         * printcmd.c (display_command, do_one_display): Update.
6153         * parser-defs.h (struct parser_state) <parser_state>: Add
6154         "tracker" parameter.
6155         (block_tracker): New member.
6156         (class innermost_block_tracker) <innermost_block_tracker>: Add
6157         "types" parameter.
6158         <reset>: Remove method.
6159         (innermost_block): Don't declare.
6160         (null_post_parser): Update.
6161         * parse.c (innermost_block): Remove global.
6162         (write_dollar_variable): Update.
6163         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6164         Remove "tracker_types" parameter.
6165         (parse_expression): Add "tracker" parameter.
6166         (parse_expression_for_completion): Update.
6167         (null_post_parser): Add "tracker" parameter.
6168         * p-exp.y: Update rules.
6169         * m2-exp.y: Update rules.
6170         * language.h (struct language_defn) <la_post_parser>: Add
6171         "tracker" parameter.
6172         * go-exp.y: Update rules.
6173         * f-exp.y: Update rules.
6174         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6175         parameter.
6176         * d-exp.y: Update rules.
6177         * c-exp.y: Update rules.
6178         * breakpoint.c (set_breakpoint_condition): Create an
6179         innermost_block_tracker.
6180         (watch_command_1): Likewise.
6181         * ada-lang.c (resolve): Add "tracker" parameter.
6182         (resolve_subexp): Likewise.
6183         * ada-exp.y (write_var_from_sym): Update.
6184
6185 2019-04-04  Tom Tromey  <tom@tromey.com>
6186
6187         * type-stack.h: New file.
6188         * type-stack.c: New file.
6189         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6190         type-stack.h.
6191         (insert_into_type_stack, insert_type, push_type, push_type_int)
6192         (insert_type_address_space, pop_type, pop_type_int)
6193         (pop_typelist, pop_type_stack, append_type_stack)
6194         (push_type_stack, get_type_stack, push_typelist)
6195         (follow_type_instance_flags, follow_types): Don't declare.
6196         * parse.c (type_stack): Remove global.
6197         (parse_exp_in_context): Update.
6198         (insert_into_type_stack, insert_type, push_type, push_type_int)
6199         (insert_type_address_space, pop_type, pop_type_int)
6200         (pop_typelist, pop_type_stack, append_type_stack)
6201         (push_type_stack, get_type_stack, push_typelist)
6202         (follow_type_instance_flags, follow_types): Remove (moved to
6203         type-stack.c).
6204         * f-exp.y (type_stack): New global.
6205         Update rules.
6206         (push_kind_type, f_parse): Update.
6207         * d-exp.y (type_stack): New global.
6208         Update rules.
6209         (d_parse): Update.
6210         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6211         Update rules.
6212         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6213         (HFILES_NO_SRCDIR): Add type-stack.h.
6214
6215 2019-04-04  Tom Tromey  <tom@tromey.com>
6216
6217         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6218         (rust_parser::convert_ast_to_expression, rust_parse)
6219         (rust_lex_test_completion, rust_lex_tests): Update.
6220         * parser-defs.h (struct expr_completion_state): New.
6221         (struct parser_state) <parser_state>: Add completion parameter.
6222         <mark_struct_expression, mark_completion_tag>: New methods.
6223         <parse_completion, m_completion_state>: New members.
6224         (prefixify_expression, null_post_parser): Update.
6225         (mark_struct_expression, mark_completion_tag): Don't declare.
6226         * parse.c (parse_completion, expout_last_struct)
6227         (expout_tag_completion_type, expout_completion_name): Remove
6228         globals.
6229         (parser_state::mark_struct_expression)
6230         (parser_state::mark_completion_tag): Now methods.
6231         (prefixify_expression): Add last_struct parameter.
6232         (prefixify_subexp): Likewise.
6233         (parse_exp_1): Update.
6234         (parse_exp_in_context): Add cstate parameter.  Update.
6235         (parse_expression_for_completion): Create an
6236         expr_completion_state.
6237         (null_post_parser): Add "completion" parameter.
6238         * p-exp.y: Update rules.
6239         (yylex): Update.
6240         * language.h (struct language_defn) <la_post_parser>: Add
6241         "completing" parameter.
6242         * go-exp.y: Update rules.
6243         (lex_one_token): Update.
6244         * expression.h (parse_completion): Don't declare.
6245         * d-exp.y: Update rules.
6246         (lex_one_token): Update rules.
6247         * c-exp.y: Update rules.
6248         (lex_one_token): Update.
6249         * ada-lang.c (resolve): Add "parse_completion" parameter.
6250         (resolve_subexp): Likewise.
6251         (ada_resolve_function): Likewise.
6252
6253 2019-04-04  Tom Tromey  <tom@tromey.com>
6254
6255         * parser-defs.h (struct parser_state) <start_arglist,
6256         end_arglist>: New methods.
6257         <arglist_len, m_funcall_chain>: New members.
6258         (arglist_len, start_arglist, end_arglist): Don't declare.
6259         * parse.c (arglist_len, funcall_chain): Remove global.
6260         (start_arglist, end_arglist): Remove functions.
6261         (parse_exp_in_context): Update.
6262         * p-exp.y: Update rules.
6263         * m2-exp.y: Update rules.
6264         * go-exp.y: Update rules.
6265         * f-exp.y: Update rules.
6266         * d-exp.y: Update rules.
6267         * c-exp.y: Update rules.
6268
6269 2019-04-04  Tom Tromey  <tom@tromey.com>
6270
6271         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6272         lex_operator, push_back>: New methods.
6273         Update all rules.
6274         (rust_parser::lex_hex, lex_escape): Rename and update.
6275         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6276         (rust_parser::lex_operator): Rename and update.
6277         (rust_parser::lex_number, rustyylex, rustyyerror)
6278         (rust_lex_test_init, rust_lex_test_sequence)
6279         (rust_lex_test_push_back, rust_lex_tests): Update.
6280         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6281         parameter.
6282         <lexptr, prev_lexptr>: New members.
6283         (lexptr, prev_lexptr): Don't declare.
6284         * parse.c (lexptr, prev_lexptr): Remove globals.
6285         (parse_exp_in_context): Update.
6286         * p-exp.y (yylex, yyerror): Update.
6287         * m2-exp.y (parse_number, yylex, yyerror): Update.
6288         * go-exp.y (lex_one_token, yyerror): Update.
6289         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6290         * d-exp.y (lex_one_token, yyerror): Update.
6291         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6292         (lex_one_token, yyerror): Update.
6293         * ada-lex.l (YY_INPUT): Update.
6294         (rewind_to_char): Update.
6295         * ada-exp.y (yyerror): Update.
6296
6297 2019-04-04  Tom Tromey  <tom@tromey.com>
6298
6299         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6300         * parser-defs.h (struct parser_state) <parser_state>: Add new
6301         parameter.
6302         <comma_terminates>: New member.
6303         (comma_terminates): Don't declare global.
6304         * parse.c (comma_terminates): Remove global.
6305         (parse_exp_in_context): Update.
6306         * p-exp.y (yylex): Update.
6307         * m2-exp.y (yylex): Update.
6308         * go-exp.y (lex_one_token): Update.
6309         * f-exp.y (yylex): Update.
6310         * d-exp.y (lex_one_token): Update.
6311         * c-exp.y (lex_one_token): Update.
6312         * ada-lex.l: Update.
6313
6314 2019-04-04  Tom Tromey  <tom@tromey.com>
6315
6316         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6317         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6318         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6319         * parser-defs.h (paren_depth): Don't declare.
6320         * parse.c (paren_depth): Remove global.
6321         (parse_exp_in_context): Update.
6322         * p-exp.y (paren_depth): New global.
6323         (pascal_parse): Initialize it.
6324         * m2-exp.y (paren_depth): New global.
6325         (m2_parse): Initialize it.
6326         * go-exp.y (paren_depth): New global.
6327         (go_parse): Initialize it.
6328         * f-exp.y (paren_depth): New global.
6329         (f_parse): Initialize it.
6330         * d-exp.y (paren_depth): New global.
6331         (d_parse): Initialize it.
6332         * c-exp.y (paren_depth): New global.
6333         (c_parse): Initialize it.
6334         * ada-lex.l (paren_depth): New global.
6335         (lexer_init): Initialize it.
6336
6337 2019-04-04  Tom Tromey  <tom@tromey.com>
6338
6339         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6340         (rust_parser::convert_ast_to_type)
6341         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6342         * parser-defs.h (struct parser_state) <parser_state>: Add
6343         parameters.  Initialize new members.
6344         <expression_context_block, expression_context_pc>: New members.
6345         * parse.c (expression_context_block, expression_context_pc):
6346         Remove globals.
6347         (parse_exp_in_context): Update.
6348         * p-exp.y: Update all rules.
6349         (yylex): Update.
6350         * m2-exp.y: Update all rules.
6351         (yylex): Update.
6352         * go-exp.y (yylex): Update.
6353         * f-exp.y (yylex): Update.
6354         * d-exp.y: Update all rules.
6355         (yylex): Update.
6356         * c-exp.y: Update all rules.
6357         (lex_one_token, classify_name, yylex, c_parse): Update.
6358         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6359
6360 2019-04-04  Tom Tromey  <tom@tromey.com>
6361
6362         * gdbarch.h, gdbarch.c: Rebuild.
6363         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6364         * stap-probe.h:
6365         (struct stap_parse_info): Replace "parser_state" with
6366         "expr_builder".
6367         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6368         (parser_state): New class.
6369         * parse.c (expr_builder): Rename.
6370         (expr_builder::release): Rename.
6371         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6372         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6373         (write_exp_elt_longcst, write_exp_elt_floatcst)
6374         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6375         (write_exp_string_vector, write_exp_bitstring)
6376         (write_exp_msymbol, mark_struct_expression)
6377         (write_dollar_variable)
6378         (insert_type_address_space, increase_expout_size): Replace
6379         "parser_state" with "expr_builder".
6380         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6381         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6382         "parser_state" with "expr_builder".
6383
6384 2019-04-04  Tom Tromey  <tom@tromey.com>
6385
6386         * rust-exp.y: Replace "parse_language" with method call.
6387         * p-exp.y:
6388         (yylex): Replace "parse_language" with method call.
6389         * m2-exp.y:
6390         (yylex): Replace "parse_language" with method call.
6391         * go-exp.y (classify_name): Replace "parse_language" with method
6392         call.
6393         * f-exp.y (yylex): Replace "parse_language" with method call.
6394         * d-exp.y (lex_one_token): Replace "parse_language" with method
6395         call.
6396         * c-exp.y:
6397         (lex_one_token, classify_name, yylex): Replace "parse_language"
6398         with method call.
6399         * ada-exp.y (find_primitive_type, type_char)
6400         (type_system_address): Replace "parse_language" with method call.
6401
6402 2019-04-04  Tom Tromey  <tom@tromey.com>
6403
6404         * rust-exp.y: Replace "parse_gdbarch" with method call.
6405         * parse.c (write_dollar_variable, insert_type_address_space):
6406         Replace "parse_gdbarch" with method call.
6407         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6408         call.
6409         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6410         call.
6411         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6412         "parse_gdbarch" with method call.
6413         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6414         with method call.
6415         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6416         "parse_gdbarch" with method call.
6417         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6418         "parse_gdbarch" with method call.
6419         * c-exp.y (parse_type, parse_number, classify_name): Replace
6420         "parse_gdbarch" with method call.
6421         * ada-lex.l: Replace "parse_gdbarch" with method call.
6422         * ada-exp.y (parse_type, find_primitive_type, type_char)
6423         (type_system_address): Replace "parse_gdbarch" with method call.
6424
6425 2019-04-04  Tom Tromey  <tom@tromey.com>
6426
6427         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6428         * stap-probe.c (stap_parse_argument): Update.
6429         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6430         initial_size parameter.
6431         * rust-exp.y (rust_lex_tests): Update.
6432         * parse.c (parser_state): Update.
6433         (parse_exp_in_context): Update.
6434         * parser-defs.h (struct parser_state) <parser_state>: Remove
6435         "initial_size" parameter.
6436
6437 2019-04-04  Tom Tromey  <tom@tromey.com>
6438
6439         * parser-defs.h (increase_expout_size): Don't declare.
6440         * parse.c (increase_expout_size): Now static.
6441
6442 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6443
6444         * gnu-nat.c (gnu_nat_target::wait): Fix
6445         target_waitstatus_to_string call.
6446
6447 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6448
6449         * eval.c (evaluate_subexp_standard): Handle internal functions
6450         during Fortran function call handling.
6451
6452 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6453
6454         * NEWS: Mention new internal functions.
6455         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6456         (read_base_type): Use dwarf2_init_complex_target_type.
6457         * value.c (creal_internal_fn): New function.
6458         (cimag_internal_fn): New function.
6459         (_initialize_values): Register new internal functions.
6460
6461 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6462
6463         * infrun.c (stop_all_threads): If debug_infrun, always
6464         trace the wait status after wait_one, using
6465         target_waitstatus_to_string and target_pid_to_str.
6466         (handle_inferior_event): Replace various trace of
6467         wait status kind by a single trace.
6468         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6469         wait status kind image by target_waitstatus_to_string.
6470         * target/waitstatus.c (target_waitstatus_to_string): Fix
6471         obsolete comment.
6472
6473 2019-04-01  Tom Tromey  <tromey@adacore.com>
6474
6475         PR symtab/23331:
6476         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6477
6478 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6479             Pedro Alves  <palves@redhat.com>
6480
6481         * top.c (quit_force): Call 'finalize_values'.
6482         * value.c (finalize_values): New function.
6483         * value.h (finalize_values): Declare.
6484
6485 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6486
6487         * NEWS: Announce $_gdb_major and $_gdb_minor.
6488
6489         * top.c (init_gdb_version_vars): New function.
6490         (gdb_init): Call init_gdb_version_vars.
6491
6492 2019-03-29  Tom Tromey  <tromey@adacore.com>
6493
6494         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6495         help text.  Remove dead code.
6496
6497 2019-03-29  Keith Seitz  <keiths@redhat.com>
6498
6499         From Siddhesh Poyarekar:
6500         * f-lang.h (f77_get_upperbound): Return LONGEST.
6501         (f77_get_lowerbound): Likewise.
6502         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6503         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6504         print them.
6505         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6506         plongest to format print it.
6507         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6508         (f77_get_upperbound): Likewise.
6509         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6510         LOWER_BOUND to LONGEST.
6511         (f77_create_arrayprint_offset_tbl): Likewise.
6512
6513 2019-03-29  Keith Seitz  <keiths@redhat.com>
6514
6515         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6516         %s/pulongest for TYPE_LENGTH instead of %d in format
6517         strings.
6518         * ada-typerint.c (ada_print_type): Likewise.
6519         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6520         * compile/compile-c-support.c (generate_register_struct): Likewise.
6521         * gdbtypes.c (recursive_dump_type): Likewise.
6522         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6523         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6524         instead of %d in format strings.
6525         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6526         to std::min to ULONGEST.
6527         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6528         instead of %d in format strings.
6529         * tracepoint.c (info_scope_command): Likewise.
6530         * typeprint.c (print_offset_data::update)
6531         (print_offset_data::finish): Likewise.
6532         * xtensa-tdep.c (xtensa_store_return_value)
6533         (xtensa_push_dummy_call): Likewise.
6534
6535 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6536
6537         * windows-nat.c (display_selector): Fixed format specifications
6538         for 64-bit Cygwin.
6539
6540 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6541
6542         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6543
6544 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6545
6546         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6547         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6548         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6549         (nios2_linux_init_abi): Install it.
6550
6551 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6552
6553         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6554
6555 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6556
6557         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6558
6559 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6560             Tom Tromey  <tromey@adacore.com>
6561
6562         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6563
6564 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6565
6566         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6567         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6568         method to compute the bounds of range types. Also print "[evaluated]"
6569         if the bounds' values come from a dynamic evaluation.
6570
6571 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6572
6573         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6574         whitespace when pretty printing is on.
6575
6576 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6577
6578         * ppc-linux-nat.c: Add include.
6579
6580 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6581
6582         * NEWS: Mention AArch64 Pointer Authentication.
6583
6584 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6585
6586         * arm-linux-nat.c: Add include.
6587
6588 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6589
6590         * source-cache.c (source_cache::get_source_lines): Re-read
6591         fullname after calling open_source_file.
6592
6593 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6594
6595         * NEWS: Mention TLS support for FreeBSD.
6596
6597 2019-03-25  Tom Tromey  <tromey@adacore.com>
6598
6599         * minsyms.c (BUNCH_SIZE): Update comment.
6600         (~minimal_symbol_reader): Remove old comment.
6601         (compact_minimal_symbols): Update comment.
6602         (minimal_symbol_reader::install): Remove old comment.  Update
6603         other comments.
6604
6605 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6606
6607         * s390-linux-nat.c: Add include.
6608
6609 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6610
6611         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6612         Call linux_get_hwcap.
6613         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6614         Likewise.
6615         (aarch64_linux_get_hwcap): Remove function.
6616         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6617         declaration.
6618         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6619         linux_get_hwcap.
6620         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6621         * linux-tdep.c (linux_get_hwcap): Add function.
6622         (linux_get_hwcap2): Likewise.
6623         * linux-tdep.h (linux_get_hwcap): Add declaration.
6624         (linux_get_hwcap2): Likewise.
6625         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6626         (ppc_linux_get_hwcap2): Likewise.
6627         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6628         linux_get_hwcap.
6629         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6630         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6631         (ppc_linux_nat_target::read_description): Likewise.
6632         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6633         * s390-linux-nat.c: Likewise.
6634         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6635
6636 2019-03-24  Tom Tromey  <tom@tromey.com>
6637
6638         * ada-lang.c (standard_lookup): Simplify initialization.
6639         (ada_lookup_symbol_nonlocal): Simplify return.
6640         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6641         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6642         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6643         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6644         initialization.
6645         * solib.c (solib_global_lookup): Simplify.
6646         * symtab.c (null_block_symbol): Remove.
6647         (symbol_cache_lookup): Simplify returns.
6648         (lookup_language_this): Simplify returns.
6649         (lookup_symbol_aux): Simplify return.
6650         (lookup_local_symbol): Simplify returns.
6651         (lookup_global_symbol_from_objfile): Simplify return.
6652         (lookup_symbol_in_objfile_symtabs)
6653         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6654         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6655         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6656         * cp-namespace.c (cp_lookup_bare_symbol)
6657         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6658         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6659         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6660         (cp_lookup_symbol_via_imports): Simplify initialization.
6661         (find_symbol_in_baseclass): Likewise.
6662         * symtab.h (null_block_symbol): Remove.
6663         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6664         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6665         (d_lookup_symbol_module): Likewise.
6666         (find_symbol_in_baseclass): Simplify initialization.
6667
6668 2019-03-24  Tom Tromey  <tom@tromey.com>
6669
6670         * expression.h: Don't include symtab.h.
6671         (struct block): Forward declare.
6672
6673 2019-03-24  Tom Tromey  <tom@tromey.com>
6674
6675         * c-exp.y (typebase): Remove casts.
6676         * gdbtypes.c (lookup_unsigned_typename, )
6677         (lookup_signed_typename): Remove cast.
6678         * eval.c (parse_to_comma_and_eval): Remove cast.
6679         * parse.c (write_dollar_variable): Remove cast.
6680         * block.h (struct block) <superblock>: Now const.
6681         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6682         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6683         (map_block): Make "block" const.
6684         * symfile.h (struct quick_symbol_functions)
6685         <map_matching_symbols>: Constify block argument to "callback".
6686         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6687         const.
6688         (find_pc_sect_compunit_symtab): Make "b" const.
6689         (find_symbol_at_address): Likewise.
6690         (search_symbols): Likewise.
6691         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6692         (dw2_debug_names_lookup_symbol): Likewise.
6693         (dw2_map_matching_symbols): Update.
6694         * p-valprint.c (pascal_val_print): Remove "block".
6695         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6696         (aux_add_nonlocal_symbols): Make "block" const.
6697         (resolve_subexp): Remove cast.
6698         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6699         const.
6700         (iterate_over_file_blocks): Likewise.
6701         * f-exp.y (%union) <bval>: Remove.
6702         * coffread.c (patch_opaque_types): Make "b" const.
6703         * spu-tdep.c (spu_catch_start): Make "block" const.
6704         * c-valprint.c (print_unpacked_pointer): Remove "block".
6705         * symmisc.c (dump_symtab_1): Make "b" const.
6706         (block_depth): Make "block" const.
6707         * d-exp.y (%union) <bval>: Remove.
6708         * cp-support.h (cp_lookup_rtti_type): Update.
6709         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6710         * psymtab.c (psym_lookup_symbol): Make "block" const.
6711         (maintenance_check_psymtabs): Make "b" const.
6712         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6713         (enumerate_locals, enumerate_args): Update.
6714         * python/py-symtab.c (stpy_global_block): Make "block" const.
6715         (stpy_static_block): Likewise.
6716         * inline-frame.c (block_starting_point_at): Make "new_block"
6717         const.
6718         * block.c (find_block_in_blockvector): Make return type const.
6719         (blockvector_for_pc_sect): Make "b" const.
6720         (find_block_in_blockvector): Make "b" const.
6721
6722 2019-03-23  Tom Tromey  <tom@tromey.com>
6723
6724         * varobj.c (varobj_create): Update.
6725         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6726         * printcmd.c (display_command, do_one_display): Don't reset
6727         innermost_block.
6728         * parser-defs.h (enum innermost_block_tracker_type): Move to
6729         expression.h.
6730         (innermost_block): Update comment.
6731         * parse.c (parse_exp_1): Add tracker_types parameter.
6732         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6733         tracker_types parameter.  Reset innermost_block.
6734         (parse_exp_in_context): Remove.
6735         (parse_expression_for_completion): Update.
6736         * objfiles.c (~objfile): Don't reset expression_context_block or
6737         innermost_block.
6738         * expression.h (enum innermost_block_tracker_type): Move from
6739         parser-defs.h.
6740         (parse_exp_1): Add tracker_types parameter.
6741         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6742         reset innermost_block.
6743
6744 2019-03-23  Tom Tromey  <tom@tromey.com>
6745
6746         * objfiles.h: Include bcache.h.
6747
6748 2019-03-23  Tom Tromey  <tom@tromey.com>
6749
6750         * linespec.c (get_current_search_block): Use
6751         scoped_restore_current_language.
6752         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6753
6754 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6755             Jiong Wang  <jiong.wang@arm.com>
6756
6757         * aarch64-linux-tdep.c
6758         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6759         section.
6760         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6761
6762 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6763             Jiong Wang  <jiong.wang@arm.com>
6764
6765         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6766         instructions.
6767         (aarch64_analyze_prologue_test): Add PACIASP test.
6768         (aarch64_prologue_prev_register): Unmask PC value.
6769
6770 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6771             Jiong Wang  <jiong.wang@arm.com>
6772
6773         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6774         (aarch64_dwarf2_prev_register): Unmask PC value.
6775         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6776         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6777         DW_CFA_AARCH64_negate_ra_state.
6778         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6779
6780 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6781             Jiong Wang  <jiong.wang@arm.com>
6782
6783         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6784         registers.
6785         (aarch64_pseudo_register_name): Likewise.
6786         (aarch64_pseudo_register_type): Likewise.
6787         (aarch64_pseudo_register_reggroup_p): Likewise.
6788         (aarch64_gdbarch_init): Add pauth registers.
6789         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6790         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6791         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6792         (struct gdbarch_tdep): Add regnum for ra_state.
6793
6794 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6795             Jiong Wang  <jiong.wang@arm.com>
6796
6797         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6798
6799 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6800             Jiong Wang  <jiong.wang@arm.com>
6801
6802         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6803         function.
6804         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6805         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6806         (aarch64_gdbarch_init): Add puth registers.
6807         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6808         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6809         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6810
6811 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6812             Jiong Wang  <jiong.wang@arm.com>
6813
6814         * aarch64-linux-nat.c
6815         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6816         * aarch64-linux-tdep.c
6817         (aarch64_linux_core_read_description): Likewise.
6818         (aarch64_linux_get_hwcap): New function.
6819         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6820         (aarch64_linux_get_hwcap): New declaration.
6821
6822 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6823             Jiong Wang  <jiong.wang@arm.com>
6824
6825         * aarch64-linux-nat.c
6826         (aarch64_linux_nat_target::read_description): Add pauth param.
6827         * aarch64-linux-tdep.c
6828         (aarch64_linux_core_read_description): Likewise.
6829         * aarch64-tdep.c (struct target_desc): Add in pauth.
6830         (aarch64_read_description): Add pauth param.
6831         (aarch64_gdbarch_init): Likewise.
6832         * aarch64-tdep.h (aarch64_read_description): Likewise.
6833         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6834         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6835         * features/Makefile: Add new files.
6836         * features/aarch64-pauth.c: New file.
6837         * features/aarch64-pauth.xml: New file.
6838
6839 2019-03-20  Tom Tromey  <tromey@adacore.com>
6840
6841         * infrun.c (handle_inferior_event): Rename from
6842         handle_inferior_event_1.  Create a scoped_value_mark.
6843         (handle_inferior_event): Remove.
6844
6845 2019-03-19  Tom Tromey  <tromey@adacore.com>
6846
6847         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6848         * infrun.h (print_stop_event): Add "displays" parameter.
6849         * infrun.c (print_stop_event): Add "displays" parameter.
6850
6851 2019-03-19  Pedro Alves  <palves@redhat.com>
6852
6853         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6854         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6855         to -1.  Fix TABs vs spaces.
6856         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6857         * tui/tui-out.h (tui_ui_out) Add intro comments.
6858         <m_line, m_start_of_line>: In-class initialize, and add describing
6859         comment.
6860
6861 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6862
6863         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6864         variable names.
6865         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6866
6867 2019-03-18  Pedro Alves  <palves@redhat.com>
6868             Eli Zaretskii <eliz@gnu.org>
6869
6870         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6871         m_line and m_start_of_line.
6872
6873 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6874
6875         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6876         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6877         it returns a newline.  This fixes a regression in TU mode, whereby
6878         the next line is output on the same screen line as the user input.
6879
6880 2019-03-18  Tom Tromey  <tromey@adacore.com>
6881
6882         * minsyms.c (minimal_symbol_reader::install): Remove call to
6883         obstack_blank.
6884
6885 2019-03-18  Pedro Alves  <palves@redhat.com>
6886
6887         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6888         New globals.
6889         (apply_style): New, factored out from ...
6890         (apply_ansi_escape): ... this.  Handle reverse video mode.
6891         (tui_set_reverse_mode): New function.
6892         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6893         * tui/tui-winsource.c (tui_show_source_line): Use
6894         tui_set_reverse_mode instead of setting A_STANDOUT.
6895         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6896         New setter methods.
6897
6898 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6899
6900         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6901         Handle tabs.
6902
6903 2019-03-18  Tom Tromey  <tromey@adacore.com>
6904
6905         * ada-lang.c (empty_array): Add "high" parameter.
6906         (ada_evaluate_subexp): Update.
6907
6908 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6909
6910         * unittests/string_view-selftests.c: Define
6911         _initialize_string_view_selftests unconditionally.
6912
6913 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6914
6915         PR gdb/24350
6916         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6917
6918 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6919
6920         PR gdb/24351
6921         * windows-nat.c (display_selector): Fix format specifiers.
6922
6923 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6924
6925         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6926         tui_refill_source_window instead of tui_refresh_win, to update the
6927         current execution line.  This fixes redisplay of the current line
6928         when stepping through the code with "next" or "step".
6929
6930 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6931
6932         * source-cache.c (source_cache::get_source_lines): Call
6933         find_source_lines to initialize s->nlines.  This fixes vertical
6934         scrolling of TUI source window when the DOWN arrow is pressed.
6935
6936 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6937
6938         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6939         linux-thread-db.c (_initialize_thread_db): Likewise.
6940
6941 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6942
6943         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6944         wclrtoeol in tui_show_source_line".  This reverts changes made in
6945         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6946
6947 2019-03-15  Tom Tromey  <tom@tromey.com>
6948
6949         * symtab.h (struct minimal_symbol): Derive from
6950         general_symbol_info.
6951         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6952         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6953         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6954         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6955         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6956         (MSYMBOL_SEARCH_NAME): Update.
6957         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6958         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6959         * minsyms.c (minimal_symbol_reader::record_full): Update.
6960
6961 2019-03-15  Tom Tromey  <tom@tromey.com>
6962
6963         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6964
6965 2019-03-15  Tom Tromey  <tom@tromey.com>
6966
6967         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6968         unique_xmalloc_ptr.
6969         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6970         Update.
6971         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6972         (build_minimal_symbol_hash_tables)
6973         (minimal_symbol_reader::install): Update.
6974
6975 2019-03-15  Tom Tromey  <tom@tromey.com>
6976
6977         * symtab.c (create_demangled_names_hash): Update.
6978         (symbol_set_names): Update.
6979         * objfiles.h (struct objfile_per_bfd_storage)
6980         <demangled_names_hash>: Now an htab_up.
6981         * objfiles.c (objfile_per_bfd_storage): Simplify.
6982
6983 2019-03-15  Tom Tromey  <tom@tromey.com>
6984
6985         * objfiles.h (struct objfile_per_bfd_storage): Declare
6986         destructor.
6987         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6988         New.
6989         (get_objfile_bfd_data): Use new.  Don't initialize
6990         language_of_main.
6991         (free_objfile_per_bfd_storage): Remove.
6992         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6993
6994 2019-03-15  Tom Tromey  <tom@tromey.com>
6995
6996         * symfile.c (reread_symbols): Update.
6997         * objfiles.c (objfile::objfile): Update.
6998         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6999         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7000         comment.
7001         (minimal_symbol_reader::install): Update.
7002         (terminate_minimal_symbol_table): Remove.
7003         * jit.c (jit_object_close_impl): Update.
7004
7005 2019-03-15  Tom Tromey  <tom@tromey.com>
7006
7007         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7008         initializations.
7009
7010 2019-03-15  Tom Tromey  <tom@tromey.com>
7011
7012         * objfiles.h (struct objfile_per_bfd_storage)
7013         <demangled_hash_languages>: Now a bitset.
7014         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7015         (lookup_minimal_symbol): Update.
7016
7017 2019-03-15  Tom Tromey  <tom@tromey.com>
7018
7019         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7020         Don't return the symbol.
7021         * coffread.c (record_minimal_symbol): Use record_full.
7022
7023 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7024
7025         The MS-Windows port of ncurses fails to switch to a color pair if
7026         one or both of the colors are the implicit default colors.  This
7027         change records the default colors when TUI is initialized, and
7028         then specifies them explicitly when a color pair uses the default
7029         colors.  This allows color styling in TUI mode on MS-Windows.
7030
7031         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7032         ncurses_norm_attr.
7033         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7034         colors in ncurses_norm_attr.
7035         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7036         "none", replace it with the default color recorded in
7037         ncurses_norm_attr.
7038
7039 2019-03-14  Tom Tromey  <tromey@adacore.com>
7040
7041         * source-cache.h (class source_cache) <get_source_lines>: Return
7042         std::string.
7043         * source-cache.c (source_cache::extract_lines): Handle case where
7044         first_pos==npos.  Return std::string.
7045         (source_cache::get_source_lines): Update.
7046
7047 2019-03-14  Tom Tromey  <tromey@adacore.com>
7048
7049         * NEWS: Add item for "style sources" commands.
7050         * source-cache.c (source_cache::get_source_lines): Check
7051         source_styling.
7052         * cli/cli-style.c (source_styling): New global.
7053         (_initialize_cli_style): Add "style sources" commands.
7054         (show_style_sources): New function.
7055         * cli/cli-style.h (source_styling): Declare.
7056
7057 2019-03-14  Pedro Alves  <palves@redhat.com>
7058             Tom Tromey  <tromey@adacore.com>
7059
7060         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7061         * tui/tui-winsource.c (tui_refill_source_window): New function,
7062         from...
7063         (tui_horizontal_source_scroll): ... here.  Move some logic.
7064         * cli/cli-style.c (set_style_enabled): Notify new observable.
7065         * tui/tui-hooks.c (tui_redisplay_source): New function.
7066         (tui_attach_detach_observers): Attach or detach
7067         tui_redisplay_source.
7068         * observable.h (source_styling_changed): New observable.
7069         * observable.c: Define source_styling_changed observable.
7070
7071 2019-03-13  Tom Tromey  <tromey@adacore.com>
7072
7073         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7074         (i386_gnu_nat_target::store_registers): Update.
7075         * target-debug.h (target_debug_print_std_string): New macro.
7076         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7077         * windows-tdep.c (display_one_tib): Update.
7078         * tui/tui-stack.c (tui_make_status_line): Update.
7079         * top.c (print_inferior_quit_action): Update.
7080         * thread.c (thr_try_catch_cmd): Update.
7081         (add_thread_with_info): Update.
7082         (thread_target_id_str): Update.
7083         (thr_try_catch_cmd): Update.
7084         (thread_command): Update.
7085         (thread_find_command): Update.
7086         * record-btrace.c (record_btrace_target::info_record)
7087         (record_btrace_resume_thread, record_btrace_target::resume)
7088         (record_btrace_cancel_resume, record_btrace_step_thread)
7089         (record_btrace_target::wait, record_btrace_target::wait)
7090         (record_btrace_target::wait, record_btrace_target::stop): Update.
7091         * progspace.c (print_program_space): Update.
7092         * process-stratum-target.c
7093         (process_stratum_target::thread_address_space): Update.
7094         * linux-fork.c (linux_fork_mourn_inferior)
7095         (detach_checkpoint_command, info_checkpoints_command)
7096         (linux_fork_context): Update.
7097         (linux_fork_detach): Update.
7098         (class scoped_switch_fork_info): Update.
7099         (delete_checkpoint_command): Update.
7100         * infrun.c (follow_fork_inferior): Update.
7101         (follow_fork_inferior): Update.
7102         (proceed_after_vfork_done): Update.
7103         (handle_vfork_child_exec_or_exit): Update.
7104         (follow_exec): Update.
7105         (displaced_step_prepare_throw): Update.
7106         (displaced_step_restore): Update.
7107         (start_step_over): Update.
7108         (resume_1): Update.
7109         (clear_proceed_status_thread): Update.
7110         (proceed): Update.
7111         (print_target_wait_results): Update.
7112         (do_target_wait): Update.
7113         (context_switch): Update.
7114         (stop_all_threads): Update.
7115         (restart_threads): Update.
7116         (finish_step_over): Update.
7117         (handle_signal_stop): Update.
7118         (switch_back_to_stepped_thread): Update.
7119         (keep_going_pass_signal): Update.
7120         (print_exited_reason): Update.
7121         (normal_stop): Update.
7122         * inferior.c (inferior_pid_to_str): Change return type.
7123         (print_selected_inferior): Update.
7124         (add_inferior): Update.
7125         (detach_inferior): Update.
7126         * dummy-frame.c (fprint_dummy_frames): Update.
7127         * dcache.c (dcache_info_1): Update.
7128         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7129         (btrace_fetch, btrace_clear): Update.
7130         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7131         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7132         type.
7133         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7134         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7135         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7136         * gdbarch.c, gdbarch.h: Rebuild.
7137         * gdbarch.sh (core_pid_to_str): Change return type.
7138         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7139         return type.
7140         (windows_nat_target::pid_to_str): Change return type.
7141         (windows_delete_thread): Update.
7142         (windows_nat_target::attach): Update.
7143         (windows_nat_target::files_info): Update.
7144         * target-delegates.c: Rebuild.
7145         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7146         return type.
7147         (sol_thread_target::pid_to_str): Change return type.
7148         * remote.c (class remote_target) <pid_to_str>: Change return
7149         type.
7150         (remote_target::pid_to_str): Change return type.
7151         (extended_remote_target::attach, remote_target::remote_stop_ns)
7152         (remote_target::remote_notif_remove_queued_reply)
7153         (remote_target::push_stop_reply, remote_target::disable_btrace):
7154         Update.
7155         (extended_remote_target::attach): Update.
7156         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7157         type.
7158         (gdbsim_target::pid_to_str): Change return type.
7159         * ravenscar-thread.c (struct ravenscar_thread_target)
7160         <pid_to_str>: Change return type.
7161         (ravenscar_thread_target::pid_to_str): Change return type.
7162         * procfs.c (class procfs_target) <pid_to_str>: Change return
7163         type.
7164         (procfs_target::pid_to_str): Change return type.
7165         (procfs_target::attach): Update.
7166         (procfs_target::detach): Update.
7167         (procfs_target::fetch_registers): Update.
7168         (procfs_target::store_registers): Update.
7169         (procfs_target::wait): Update.
7170         (procfs_target::files_info): Update.
7171         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7172         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7173         return type.
7174         (nto_procfs_target::pid_to_str): Change return type.
7175         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7176         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7177         return type.
7178         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7179         (exit_lwp): Update.
7180         (attach_proc_task_lwp_callback, get_detach_signal)
7181         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7182         (linux_nat_target::resume, wait_lwp, stop_callback)
7183         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7184         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7185         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7186         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7187         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7188         type.
7189         (inf_ptrace_target::attach): Update.
7190         (inf_ptrace_target::files_info): Update.
7191         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7192         type.
7193         (go32_nat_target::pid_to_str): Change return type.
7194         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7195         (gnu_nat_target::wait): Update.
7196         (gnu_nat_target::wait): Update.
7197         (gnu_nat_target::resume): Update.
7198         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7199         (fbsd_nat_target::wait): Update.
7200         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7201         type.
7202         (darwin_nat_target::attach): Update.
7203         * corelow.c (class core_target) <pid_to_str>: Change return type.
7204         (core_target::pid_to_str): Change return type.
7205         * target.c (normal_pid_to_str): Change return type.
7206         (default_pid_to_str): Likewise.
7207         (target_pid_to_str): Change return type.
7208         (target_translate_tls_address): Update.
7209         (target_announce_detach): Update.
7210         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7211         return type.
7212         (bsd_uthread_target::pid_to_str): Change return type.
7213         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7214         type.
7215         (bsd_kvm_target::pid_to_str): Change return type.
7216         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7217         return type.
7218         (aix_thread_target::pid_to_str): Change return type.
7219         * target.h (struct target_ops) <pid_to_str>: Change return type.
7220         (target_pid_to_str, normal_pid_to_str): Likewise.
7221         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7222         type.
7223         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7224         type.
7225         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7226         return type.
7227         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7228         type.
7229         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7230         type.
7231         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7232         return type.
7233
7234 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7235
7236         * NEWS: Mention that the new default MI version is 3.  Mention
7237         changes to the output of commands and events that deal with
7238         multi-location breakpoints.
7239         * breakpoint.c: Include "mi/mi-out.h".
7240         (print_one_breakpoint): Change output syntax if using MI version
7241         >= 3.
7242         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7243         New.
7244         (mi_multi_location_breakpoint_output_fixed): New.
7245         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7246         (mi_cmd_fix_multi_location_breakpoint_output): New.
7247         (mi_multi_location_breakpoint_output_fixed): New.
7248         * mi/mi-cmds.c (mi_cmds): Register command
7249         -fix-multi-location-breakpoint-output.
7250         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7251         interpreter "mi".
7252
7253 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7254
7255         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7256         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7257         instantiate mi_ui_out based on interpreter name.
7258         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7259         * mi/mi-main.c (mi_load_progress): Likewise.
7260
7261 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7262
7263         * NEWS: Combine separate "New targets" sections for 8.3.
7264
7265 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7266
7267         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7268         (ppcfbsd_init_abi): Install gdbarch
7269         "fetch_tls_load_module_address" and "get_thread_local_address"
7270         methods.
7271
7272 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7273
7274         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7275         (riscv_fbsd_init_abi): Install gdbarch
7276         "fetch_tls_load_module_address" and "get_thread_local_address"
7277         methods.
7278
7279 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7280
7281         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7282         (i386fbsd_init_abi): Install gdbarch
7283         "fetch_tls_load_module_address" and "get_thread_local_address"
7284         methods.
7285
7286 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7287
7288         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7289         (amd64fbsd_init_abi): Install gdbarch
7290         "fetch_tls_load_module_address" and "get_thread_local_address"
7291         methods.
7292
7293 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7294
7295         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7296         (struct fbsd_pspace_data): New type.
7297         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7298         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7299         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7300         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7301         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7302
7303 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7304
7305         * gdbtypes.c (lookup_struct_elt): New function.
7306         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7307         * gdbtypes.h (struct struct_elt): New type.
7308         (lookup_struct_elt): New prototype.
7309
7310 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7311
7312         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7313         remove disabled code block.
7314
7315 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7316
7317         * gdbarch.sh (get_thread_local_address): New method.
7318         * gdbarch.h, gdbarch.c: Regenerate.
7319         * target.c (target_translate_tls_address): Use
7320         gdbarch_get_thread_local_address if present instead of
7321         target::get_thread_local_address.
7322
7323 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7324
7325         * target.h (target::get_thread_local_address): Update comment.
7326
7327 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7328
7329         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7330         objfile->separate_debug_objfile_backlink if not NULL.
7331
7332 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7333
7334         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7335         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7336         (amd64bsd_store_inferior_registers): Likewise.
7337         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7338         Enable segment base registers.
7339         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7340         PT_GETFSBASE and PT_GETGSBASE.
7341         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7342         PT_SETGSBASE.
7343         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7344         segment base registers.
7345         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7346
7347 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7348
7349         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7350         Update calls to i386_target_description to add 'segments'
7351         parameter.
7352         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7353         add segment base registers.
7354         * arch/i386.c (i386_create_target_description): Add 'segments'
7355         parameter to enable segment base registers.
7356         * arch/i386.h (i386_create_target_description): Likewise.
7357         * features/i386/32bit-segments.xml: New file.
7358         * features/i386/32bit-segments.c: Generate.
7359         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7360         call to i386_target_description to add 'segments' parameter.
7361         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7362         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7363         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7364         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7365         if feature is present.
7366         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7367         Add 'segments' parameter to call to i386_target_description.
7368         (i386_target_description): Add 'segments' parameter to enable
7369         segment base registers.
7370         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7371         to call to i386_target_description.
7372         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7373         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7374         Define I386_NUM_REGS.
7375         (i386_target_description): Add 'segments' parameter to enable
7376         segment base registers.
7377
7378 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7379
7380         PR/24325
7381         * source-cache.c: #undef open and close, to avoid unresolved
7382         externals during linking.
7383
7384 2019-03-12  Tom Tromey  <tromey@adacore.com>
7385
7386         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7387         const.  Add initializers.
7388         (_initialize_remote): Don't initialize ptid globals.
7389
7390 2019-03-12  Pedro Alves  <palves@redhat.com>
7391
7392         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7393
7394 2019-03-12  Pedro Alves  <palves@redhat.com>
7395
7396         * cp-name-parser.y (main): Remove unused 'len' variable.
7397
7398 2019-03-12  Tom Tromey  <tromey@adacore.com>
7399
7400         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7401         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7402
7403 2019-03-12  Tom Tromey  <tromey@adacore.com>
7404
7405         * linux-nat.c (iterate_over_lwps): Update.
7406         (stop_callback): Remove parameter.
7407         (stop_wait_callback, detach_callback, resume_set_callback)
7408         (select_singlestep_lwp_callback, set_ignore_sigint)
7409         (status_callback, resumed_callback, resume_clear_callback)
7410         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7411         data parameter.
7412         (linux_nat_target::detach, linux_nat_target::resume)
7413         (linux_stop_and_wait_all_lwps, select_event_lwp)
7414         (linux_nat_filter_event, linux_nat_wait_1)
7415         (linux_nat_target::kill, linux_nat_target::stop)
7416         (linux_nat_target::stop): Update.
7417         (linux_nat_resume_callback): Change type.
7418         (resume_stopped_resumed_lwps, count_events_callback)
7419         (select_event_lwp_callback): Likewise.
7420         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7421         * arm-linux-nat.c (struct update_registers_data): Remove.
7422         (update_registers_callback): Change type.
7423         (arm_linux_insert_hw_breakpoint1): Update.
7424         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7425         parameter.
7426         (x86_linux_dr_set_addr): Update.
7427         (x86_linux_dr_set_control): Update.
7428         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7429         (iterate_over_lwps): Use gdb::function_view.
7430         * nat/aarch64-linux-hw-point.c (struct
7431         aarch64_dr_update_callback_param): Remove.
7432         (debug_reg_change_callback): Change type.
7433         (aarch64_notify_debug_reg_change): Update.
7434         * s390-linux-nat.c (s390_refresh_per_info): Update.
7435
7436 2019-03-11  Tom Tromey  <tromey@adacore.com>
7437
7438         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7439         redundant assignment to "this_cu".
7440
7441 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7442
7443         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7444
7445 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7446
7447         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7448         from...
7449         (rank_one_type): ... this.
7450
7451 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7452
7453         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7454         from...
7455         (rank_one_type): ... this.
7456
7457 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7458
7459         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7460         from...
7461         (rank_one_type): ... this.
7462
7463 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7464
7465         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7466         from...
7467         (rank_one_type): ... this.
7468
7469 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7470
7471         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7472         from...
7473         (rank_one_type): ... this.
7474
7475 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7476
7477         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7478         from...
7479         (rank_one_type): ... this.
7480
7481 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7482
7483         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7484         from...
7485         (rank_one_type): ... this.
7486
7487 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7488
7489         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7490         from...
7491         (rank_one_type): ... this.
7492
7493 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7494
7495         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7496         from...
7497         (rank_one_type): ... this.
7498
7499 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7500
7501         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7502         from...
7503         (rank_one_type): ... this.
7504
7505 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7506
7507         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7508         from...
7509         (rank_one_type): ... this.
7510
7511 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7512
7513         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7514         from...
7515         (rank_one_type): ... this.
7516
7517 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7518
7519         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7520         inferior-events' shows the example events.
7521
7522 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7523
7524         Support styling on native MS-Windows console
7525
7526         PR/24315
7527         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7528         on MS-Windows if $TERM is not defined.
7529
7530         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7531
7532         * posix-hdep.c (gdb_console_fputs):
7533         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7534         functions.
7535         * ui-file.h (gdb_console_fputs): Add prototype.
7536
7537         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7538         back to fputs only if the former returns zero.
7539
7540 2019-03-07  Tom Tromey  <tom@tromey.com>
7541
7542         * symmisc.c (print_symbol_bcache_statistics): Update.
7543         (print_objfile_statistics): Update.
7544         * symfile.c (allocate_symtab): Update.
7545         * stabsread.c: Don't include bcache.h.
7546         * psymtab.h (struct psymbol_bcache): Don't declare.
7547         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7548         (psymbol_bcache_init, psymbol_bcache_free)
7549         (psymbol_bcache_get_bcache): Don't declare.
7550         * psymtab.c (struct psymbol_bcache): Remove.
7551         (psymtab_storage::psymtab_storage): Update.
7552         (psymtab_storage::~psymtab_storage): Update.
7553         (psymbol_bcache_init, psymbol_bcache_free)
7554         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7555         (add_psymbol_to_bcache): Update.
7556         (allocate_psymtab): Update.
7557         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7558         macro_cache>: No longer pointers.
7559         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7560         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7561         * macrotab.c (macro_bcache): Update.
7562         * macroexp.c: Don't include bcache.h.
7563         * gdbtypes.c (check_types_worklist): Update.
7564         (types_deeply_equal): Remove TRY/CATCH.  Update.
7565         * elfread.c (elf_symtab_read): Update.
7566         * dwarf2read.c: Don't include bcache.h.
7567         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7568         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7569         (print_bcache_statistics, bcache_memory_used): Don't declare.
7570         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7571         methods.  Rename all data members.
7572         * bcache.c (struct bcache): Move to bcache.h.
7573         (bcache::expand_hash_table): Rename from expand_hash_table.
7574         (bcache): Remove.
7575         (bcache::insert): Rename from bcache_full.
7576         (bcache::compare): Rename from bcache_compare.
7577         (bcache_xmalloc): Remove.
7578         (bcache::~bcache): Rename from bcache_xfree.
7579         (bcache::print_statistics): Rename from print_bcache_statistics.
7580         (bcache::memory_used): Rename from bcache_memory_used.
7581
7582 2019-03-07  Pedro Alves  <palves@redhat.com>
7583
7584         * infrun.c (normal_stop): Also check for
7585         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7586
7587 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7588
7589         * f-lang.c (value_from_host_double): Moved to...
7590         * value.c (value_from_host_double): ...here.
7591         * value.h (value_from_host_double): Declare.
7592         * guile/scm-math.c (vlscm_convert_typed_number): Use
7593         value_from_host_double.
7594         (vlscm_convert_number): Likewise.
7595         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7596         * python/py-value.c (convert_value_from_python): Likewise.
7597
7598 2019-03-06  Tom Tromey  <tom@tromey.com>
7599
7600         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7601
7602 2019-03-06  Tom Tromey  <tom@tromey.com>
7603
7604         * utils.h (free_current_contents): Don't declare.
7605         * utils.c (free_current_contents): Remove.
7606
7607 2019-03-06  Tom Tromey  <tom@tromey.com>
7608
7609         * top.c (quit_force): Update.
7610         * main.c (captured_command_loop): Update.
7611         * common/new-op.c (operator new): Update.
7612         * common/common-exceptions.c (struct catcher)
7613         <save_cleanup_chain>: Remove member.
7614         (exceptions_state_mc_init): Update.
7615         (exception_try_scope_entry): Return nullptr.
7616         (exception_try_scope_exit, exception_rethrow)
7617         (throw_exception_sjlj, throw_exception_cxx): Update.
7618         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7619         (all_cleanups, do_cleanups, discard_cleanups)
7620         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7621         (restore_cleanups, restore_final_cleanups): Don't declare.
7622         (do_final_cleanups): Remove parameter.
7623         * common/cleanups.c (cleanup_chain, make_cleanup)
7624         (make_cleanup_dtor, all_cleanups, do_cleanups)
7625         (discard_my_cleanups, discard_cleanups)
7626         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7627         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7628         (null_cleanup): Remove.
7629         (do_final_cleanups): Remove parameter.
7630
7631 2019-03-06  Tom Tromey  <tom@tromey.com>
7632
7633         * remote.c (remote_target::remote_parse_stop_reply): Use
7634         unique_xmalloc_ptr.
7635
7636 2019-03-06  Tom Tromey  <tom@tromey.com>
7637
7638         * stabsread.c (struct stabs_field_info): Rename from field_info.
7639         <list, fnlist>: Add initializers.
7640         <obstack>: New member.
7641         (read_member_functions, read_struct_fields, read_baseclasses):
7642         Allocate on obstack.  Don't use cleanups.
7643         (read_one_struct_field, read_member_functions, read_struct_fields)
7644         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7645         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7646         (read_struct_type): Update.
7647
7648 2019-03-06  Tom Tromey  <tom@tromey.com>
7649
7650         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7651         * common/filestuff.h (make_cleanup_close): Don't declare.
7652         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7653         Remove.
7654
7655 2019-03-06  Tom Tromey  <tom@tromey.com>
7656
7657         * solib-aix.c: Use make_scope_exit.
7658
7659 2019-03-06  Tom Tromey  <tom@tromey.com>
7660
7661         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7662         Use make_scope_exit.
7663
7664 2019-03-06  Tom Tromey  <tom@tromey.com>
7665
7666         * solib-svr4.c (disable_probes_interface): Remove parameter.
7667         (svr4_handle_solib_event): Use make_scope_exit.
7668
7669 2019-03-06  Tom Tromey  <tom@tromey.com>
7670
7671         * remote.c (struct stop_reply_deleter): Remove.
7672         (stop_reply_up): Update.
7673         (struct stop_reply): Derive from notif_event.  Don't typedef.
7674         <regcache>: Now a std::vector.
7675         (stop_reply_xfree): Remove.
7676         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7677         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7678         (remote_target::discard_pending_stop_replies): Use delete.
7679         (remote_target::remote_parse_stop_reply): Update.
7680         (remote_target::process_stop_reply): Update.
7681         * remote-notif.h (struct notif_event): Add virtual destructor.
7682         Remove "dtr" member.
7683         (struct notif_client) <alloc_event>: Return a unique_ptr.
7684         (notif_event_xfree): Don't declare.
7685         (notif_event_up): New typedef.
7686         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7687         (notif_event_xfree, do_notif_event_xfree): Remove.
7688         (remote_notif_state_xfree): Update.
7689
7690 2019-03-06  Tom Tromey  <tom@tromey.com>
7691
7692         * infrun.c (displaced_step_clear_cleanup): Now a
7693         forward_scope_exit type.
7694         (displaced_step_prepare_throw): Update.
7695         (displaced_step_fixup): Update.
7696
7697 2019-03-06  Tom Tromey  <tom@tromey.com>
7698
7699         * inferior.h (class inferior): Update comment.
7700         * gdbthread.h (class thread_info): Update comment.
7701
7702 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7703             Tom Tromey  <tom@tromey.com>
7704
7705         * stabsread.h (struct stab_section_list): Remove.
7706         (coffstab_build_psymtabs): Update.
7707         * dbxread.c (symbuf_sections): Now a std::vector.
7708         (sect_idx): New global.
7709         (fill_symbuf): Update.
7710         (coffstab_build_psymtabs): Change type of stabsects parameter.
7711         Update.
7712         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7713         std::vector.
7714         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7715         (coff_locate_sections): Update.
7716         (coff_symfile_read): Remove cleanups.  Update.
7717         (init_stringtab): Add storage parameter.
7718         (free_stringtab, free_stringtab_cleanup): Remove.
7719         (init_lineno): Add storage parameter.
7720         (free_linetab, free_linetab_cleanup): Remove.
7721
7722 2019-03-06  Pedro Alves  <palves@redhat.com>
7723
7724         * linux-fork.c (fork_info::clobber_regs): Delete.
7725         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7726         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7727         comment.  Adjust.
7728         (scoped_switch_fork_info::scoped_switch_fork_info)
7729         (checkpoint_command, linux_fork_context): Adjust
7730         fork_save_infrun_state calls.
7731
7732 2019-03-06  Pedro Alves  <palves@redhat.com>
7733
7734         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7735         (inf_has_multiple_threads): Return 'bool' and rewrite using
7736         inferior_info::threads().
7737
7738 2019-03-06  Pedro Alves  <palves@redhat.com>
7739
7740         * linux-fork.c: Include <list>.
7741         (fork_list): Now a std::list instance.
7742         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7743         (forks_exist_p, find_last_fork): Adjust.
7744         (new_fork): Delete.
7745         (one_fork_p): New.
7746         (add_fork): Adjust.
7747         (free_fork): Delete, folded into fork_info::~fork_info().
7748         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7749         Adjust.
7750         (init_fork_list): Delete.
7751         (linux_fork_killall, linux_fork_mourn_inferior)
7752         (linux_fork_detach, info_checkpoints_command): Adjust.
7753         (_initialize_linux_fork): No longer call init_fork_list.
7754
7755 2019-03-06  Pedro Alves  <palves@redhat.com>
7756
7757         * linux-fork.c (new_fork): New, split out of ...
7758         (add_fork): ... this.  Return void.  Move "first fork" special
7759         case from here, to ...
7760         (checkpoint_command): ... here.
7761         * linux-linux.h (add_fork): Return void.
7762
7763 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7764
7765         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7766
7767 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7768             Chris January  <chris.january@arm.com>
7769             David Lecomber  <david.lecomber@arm.com>
7770
7771         * f-exp.y: New token, UNOP_INTRINSIC.
7772         (exp): New pattern using UNOP_INTRINSIC token.
7773         (f77_keywords): Add 'abs' keyword.
7774         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7775         (value_from_host_double): New function.
7776         (evaluate_subexp_f): Support UNOP_ABS.
7777
7778 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7779
7780         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7781         types.
7782
7783 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7784
7785         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7786         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7787         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7788
7789 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7790
7791         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7792
7793 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7794             Chris January  <chris.january@arm.com>
7795
7796         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7797         * f-exp.y: Define 'KIND' token.
7798         (exp): New pattern for KIND expressions.
7799         (ptype): Handle types with a kind extension.
7800         (direct_abs_decl): Extend to spot kind extensions.
7801         (f77_keywords): Add 'kind' to the list.
7802         (push_kind_type): New function.
7803         (convert_to_kind_type): New function.
7804         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7805         * parse.c (operator_length_standard): Likewise.
7806         * parser-defs.h (enum type_pieces): Add tp_kind.
7807         * std-operator.def: Add UNOP_KIND.
7808
7809 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7810
7811         * f-exp.y (f_parse): Set yydebug.
7812
7813 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7814
7815         * f-lang.c (evaluate_subexp_f): New function.
7816         (exp_descriptor_f): New global.
7817         (f_language_defn): Use exp_descriptor_f instead of
7818         exp_descriptor_standard.
7819
7820 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7821
7822         * f-exp.y (struct token): Add comments.
7823         (dot_ops): Remove uppercase versions and the end marker.
7824         (f77_keywords): Likewise.
7825         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7826         entries in the dot_ops array are case insensitive, and use
7827         strncasecmp to compare strings.  Also some whitespace cleanup in
7828         this area.  Similar for the f77_keywords array, except entries in
7829         this list might be case sensitive.
7830
7831 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7832
7833         * f-exp.y (struct f77_boolean_val): Add comments.
7834         (boolean_values): Remove uppercase versions, and end marker.
7835         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7836         and use strncasecmp to achieve case insensitivity.  Additionally,
7837         perform whitespace cleanup around this code.
7838
7839 2019-03-06  Tom Tromey  <tromey@adacore.com>
7840
7841         * remote-sim.c (gdbsim_target_open): Use result of
7842         gdb_argv::release.
7843
7844 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7845         Dirk Schubert  <dirk.schubert@arm.com>
7846         Chris January  <chris.january@arm.com>
7847
7848         * eval.c (evaluate_subexp_standard): Call Fortran argument
7849         wrapping logic.
7850         * f-lang.c (struct value): A value which can be passed into a
7851         Fortran function call.
7852         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7853         where appropriate.
7854         (struct type): Value ready for a Fortran function call.
7855         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7856         is needed.
7857         * f-lang.h (fortran_argument_convert): Declaration.
7858         (fortran_preserve_arg_pointer): Declaration.
7859         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7860
7861 2019-03-05  Tom Tromey  <tromey@adacore.com>
7862
7863         * python/py-prettyprint.c (print_string_repr): Remove #if.
7864         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7865
7866 2019-03-05  Tom Tromey  <tromey@adacore.com>
7867
7868         * target.c (the_dummy_target): Move later.  Change type to
7869         "dummy_target".
7870         (initialize_targets): Don't initialize the_dummy_target.
7871
7872 2019-03-05  Tom Tromey  <tromey@adacore.com>
7873
7874         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7875         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7876
7877 2019-03-05  Tom Tromey  <tromey@adacore.com>
7878
7879         * windows-nat.c (windows_nat_target::attach)
7880         (windows_nat_target::detach): Don't call gdb_flush.
7881         * valprint.c (generic_val_print, val_print, val_print_string):
7882         Don't call gdb_flush.
7883         * utils.c (defaulted_query): Don't call gdb_flush.
7884         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7885         * target.c (target_announce_detach): Don't call gdb_flush.
7886         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7887         * remote.c (extended_remote_target::attach): Don't call
7888         gdb_flush.
7889         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7890         * printcmd.c (do_examine): Don't call gdb_flush.
7891         (info_display_command): Don't call gdb_flush.
7892         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7893         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7894         * memattr.c (info_mem_command): Don't call gdb_flush.
7895         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7896         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7897         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7898         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7899         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7900         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7901         (gnu_nat_target::detach): Don't call gdb_flush.
7902         * f-valprint.c (f_val_print): Don't call gdb_flush.
7903         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7904         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7905         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7906         gdb_flush.
7907         * c-valprint.c (c_val_print): Don't call gdb_flush.
7908         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7909
7910 2019-03-05  Tom Tromey  <tromey@adacore.com>
7911
7912         * varobj.c (update_dynamic_varobj_children): Update.
7913         (install_default_visualizer): Use reset, not release.
7914         * value.c (set_internalvar): Update.
7915         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7916         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7917         ATTRIBUTE_UNUSED_RESULT.
7918
7919 2019-03-05  Tom Tromey  <tromey@adacore.com>
7920
7921         * remote.c (class scoped_remote_fd) <release>: Add
7922         ATTRIBUTE_UNUSED_RESULT.
7923
7924 2019-03-05  Tom Tromey  <tromey@adacore.com>
7925
7926         * macroexp.c (struct macro_buffer) <release>: Add
7927         ATTRIBUTE_UNUSED_RESULT.
7928
7929 2019-03-05  Tom Tromey  <tromey@adacore.com>
7930
7931         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7932         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7933         ATTRIBUTE_UNUSED_RESULT.
7934
7935 2019-03-05  Tom Tromey  <tromey@adacore.com>
7936
7937         * common/scoped_fd.h (class scoped_fd) <release>: Add
7938         ATTRIBUTE_UNUSED_RESULT.
7939
7940 2019-03-05  Tom Tromey  <tromey@adacore.com>
7941
7942         * parser-defs.h (struct parser_state) <release>: Add
7943         ATTRIBUTE_UNUSED_RESULT.
7944
7945 2019-03-05  Tom Tromey  <tromey@adacore.com>
7946
7947         * utils.h (class gdb_argv) <release>: Add
7948         ATTRIBUTE_UNUSED_RESULT.
7949         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7950
7951 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7952
7953         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7954         for-loop range, to avoid compiler warnings.
7955
7956         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7957         avoid compiler warnings about unused variables.
7958
7959         * NEWS: Mention end of support for native debugging on MS-Windows
7960         before XP.
7961
7962         PR gdb/24292
7963         * common/netstuff.c:
7964         * gdbserver/gdbreplay.c
7965         * gdbserver/remote-utils.c:
7966         * ser-tcp.c:
7967         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7968         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7969         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7970         'getaddrinfo' and 'freeaddrinfo' were not available before
7971         Windows XP, and mingw.org's MinGW headers by default define
7972         _WIN32_WINNT to 0x500.
7973
7974 2019-03-01  Gary Benson <gbenson@redhat.com>
7975
7976         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7977
7978 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7979             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7980
7981         PR gdb/8527
7982         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7983         set_sigint_trap, clear_sigint_trap.
7984
7985 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7986
7987         * target.c (target_detach): Clear the regcache and the
7988         frame cache.
7989
7990 2019-02-27  Pedro Alves  <palves@redhat.com>
7991
7992         * utils.c (set_screen_size): When we cap the height/width sizes,
7993         tweak the corresponding command variable to show "unlimited":
7994
7995 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7996             Pedro Alves  <palves@redhat.com>
7997
7998         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7999         before calling rl_set_screen_size.
8000
8001 2019-02-27  Tom Tromey  <tromey@adacore.com>
8002
8003         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8004         define.
8005         * python/py-value.c: Remove Python 2.4 workaround.
8006         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8007         workaround.
8008         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8009         Python 2.4 workaround.
8010         * python/python-internal.h: Remove Python 2.4 comment.
8011         (Py_ssize_t): Don't define.
8012         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8013         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8014         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8015         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8016         * python/python.c (do_start_initialization): Remove Python 2.4
8017         workaround.
8018         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8019         (print_children): Remove Python 2.4 workaround.
8020         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8021         workaround.
8022         (CHARBUFFERPROC_NAME): Remove.
8023         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8024         Python 2.4 workaround.
8025
8026 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8027
8028         * NEWS: Note minimum Python version.
8029
8030 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8031
8032         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8033         code from these functions.  Remove corresponding ifdefs.  Use
8034         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8035         Remove gotos and target of gotos.
8036         (infpy_search_memory): Likewise.
8037
8038 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8039
8040         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8041         (hppa_gdbarch_init): Don't register deleted functions with
8042         gdbarch.
8043
8044 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8045
8046         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8047         (h8300_unwind_sp): Delete.
8048         (h8300_dummy_id): Delete.
8049         (h8300_gdbarch_init): Don't register deleted functions with
8050         gdbarch.
8051
8052 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8053
8054         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8055         (ft32_unwind_pc): Delete.
8056         (ft32_unwind_sp): Delete.
8057         (ft32_gdbarch_init): Don't register deleted functions with
8058         gdbarch.
8059
8060 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8061
8062         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8063         (frv_unwind_pc): Delete.
8064         (frv_unwind_sp): Delete.
8065         (frv_gdbarch_init): Don't register deleted functions with
8066         gdbarch.
8067
8068 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8069
8070         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8071         (riscv_unwind_pc): Delete.
8072         (riscv_unwind_sp): Delete.
8073         (riscv_gdbarch_init): Don't register deleted functions with
8074         gdbarch.
8075
8076 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8077
8078         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8079         (csky_unwind_pc): Delete.
8080         (csky_unwind_sp): Delete.
8081         (csky_gdbarch_init): Don't register deleted functions with
8082         gdbarch.
8083
8084 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8085
8086         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8087         (cris_unwind_pc): Delete.
8088         (cris_unwind_sp): Delete.
8089         (cris_gdbarch_init): Don't register deleted functions with
8090         gdbarch.
8091
8092 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8093
8094         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8095         (bfin_unwind_pc): Delete.
8096         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8097
8098 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8099
8100         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8101         (arm_unwind_pc): Delete.
8102         (arm_unwind_sp): Delete.
8103         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8104
8105 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8106
8107         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8108         (arc_unwind_pc): Delete.
8109         (arc_unwind_sp): Delete.
8110         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8111
8112 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8113
8114         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8115         (alpha_unwind_pc): Delete.
8116         (alpha_gdbarch_init): Don't register deleted functions with
8117         gdbarch.
8118
8119 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8120
8121         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8122         (aarch64_unwind_pc): Delete.
8123         (aarch64_unwind_sp): Delete.
8124         (aarch64_gdbarch_init): Don't register deleted functions with
8125         gdbarch.
8126
8127 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8128
8129         * gdbtypes.c (type_align): Don't consider static members when
8130         computing structure alignment.
8131
8132 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8133
8134         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8135         return 0 for other types.
8136         * arch-utils.c (default_type_align): Always return 0.
8137         * gdbarch.h: Regenerate.
8138         * gdbarch.sh (type_align): Extend comment.
8139         * gdbtypes.c (type_align): Add additional comments, always call
8140         gdbarch_type_align before applying the default rules.
8141         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8142         generic code will then apply a suitable default.
8143         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8144         types, return 0 for other types.
8145
8146 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8147
8148         * NEWS: Create a new section for the next release branch.
8149         Rename the section of the current branch, now that it has
8150         been cut.
8151
8152 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8153
8154         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8155         * version.in: Bump version to 8.3.50.DATE-git.
8156
8157 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8158
8159         * aix-thread.c (ptid_cmp): Remove unused variable.
8160         (get_signaled_thread): Likewise.
8161         (store_regs_user_thread): Likewise.
8162         (store_regs_kernel_thread): Likewise.
8163         (fetch_regs_kernel_thread): Remove shadowed variable.
8164
8165 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8166
8167         * features/riscv/32bit-cpu.xml: Add register numbers.
8168         * features/riscv/32bit-fpu.c: Regenerate.
8169         * features/riscv/32bit-fpu.xml: Add register numbers.
8170         * features/riscv/64bit-cpu.xml: Add register numbers.
8171         * features/riscv/64bit-fpu.c: Regenerate.
8172         * features/riscv/64bit-fpu.xml: Add register numbers.
8173
8174 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8175
8176         * NEWS: Mention two argument form of gdb.Value constructor.
8177         * python/py-value.c (convert_buffer_and_type_to_value): New
8178         function.
8179         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8180         Add support for handling an optional second argument.  Call
8181         convert_buffer_and_type_to_value as appropriate.
8182         * python/python-internal.h (Py_buffer_deleter): New struct.
8183         (Py_buffer_up): New typedef.
8184
8185 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8186
8187         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8188         instead of releasing ownership.
8189
8190 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8191
8192         * dwarf2read.c (open_and_init_dwp_file): Call
8193         elf_numsections instead of bfd_count_sections to initialize
8194         dwp_file->num_sections.
8195
8196 2019-02-25  Tom Tromey  <tromey@adacore.com>
8197
8198         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8199
8200 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8201
8202         * gcore.in: Add '--readnever' option when invoking GDB.
8203
8204 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8205
8206         * MAINTAINERS: Update my email address.
8207
8208 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8209
8210         * build-id.c (build_id_to_debug_bfd_1): New function.
8211         (build_id_to_debug_bfd): Look for separate debug file in
8212         sysroot.
8213
8214 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8215
8216         * gdbarch.sh: Update the copyright year range that is placed into
8217         generated files.
8218
8219 2019-02-22  Keith Seitz  <keiths@redhat.com>
8220
8221         PR symtab/23853
8222         * linespec.c (create_sals_line_offset): Search for the default
8223         symtab's filename instead of its fullname.
8224
8225 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8226
8227         * NEWS: Update style defaults.
8228
8229 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8230
8231         * main.c (captured_main_1): Disable styling in batch mode.
8232
8233 2019-02-20  Tom Tromey  <tom@tromey.com>
8234
8235         * symtab.c (symtab_symbol_info): Fix typos.
8236
8237 2019-02-20  Tom Tromey  <tromey@adacore.com>
8238
8239         * findcmd.c (_initialize_mem_search): Use upper case for
8240         metasyntactic variables.
8241
8242 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8243
8244         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8245         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8246
8247 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8248
8249         * top.h (source_file_name): Change to std::string.
8250         * top.c (source_file_name): Likewise.
8251         (command_line_input): Adjust.
8252         * cli/cli-script.c (script_from_file): Adjust.
8253
8254 2019-02-19  Tom Tromey  <tromey@adacore.com>
8255
8256         * ravenscar-thread.c
8257         (ravenscar_thread_target::update_thread_list): Don't call
8258         ada_build_task_list.
8259         * ada-lang.h (ada_build_task_list): Don't declare.
8260         * ada-tasks.c (struct ada_tasks_inferior_data)
8261         <task_list_valid_p>: Now bool.
8262         (read_known_tasks, ada_task_list_changed)
8263         (ada_tasks_invalidate_inferior_data): Update.
8264         (read_known_tasks_array): Return bool.
8265         (read_known_tasks_list): Likewise.
8266         (read_known_tasks): Return void.
8267         (ada_build_task_list): Now static.
8268
8269 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8270
8271         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8272         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8273
8274 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8275
8276         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8277         variant for ada_tasks_pspace_data_handle and
8278         ada_tasks_inferior_data_handle.
8279         (ada_tasks_pspace_data_cleanup): New function.
8280         (ada_tasks_inferior_data_cleanup): New function.
8281
8282 2019-02-17  Tom Tromey  <tom@tromey.com>
8283
8284         * macrotab.h (macro_source_fullname): Return a std::string.
8285         * macrotab.c (macro_include, check_for_redefinition)
8286         (macro_undef, macro_lookup_definition, foreach_macro)
8287         (foreach_macro_in_scope): Update.
8288         (macro_source_fullname): Return a std::string.
8289         * macrocmd.c (show_pp_source_pos): Update.
8290
8291 2019-02-17  Tom Tromey  <tom@tromey.com>
8292
8293         * macrocmd.c (show_pp_source_pos): Style the file names.
8294
8295 2019-02-17  Tom Tromey  <tom@tromey.com>
8296
8297         PR tui/24197:
8298         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8299
8300 2019-02-17  Tom Tromey  <tom@tromey.com>
8301
8302         * ada-lang.c (user_select_syms): Use filtered printing.
8303         * utils.c (wrap_style): New global.
8304         (desired_style): Remove.
8305         (emit_style_escape): Add stream parameter.
8306         (set_output_style, reset_terminal_style, prompt_for_continue):
8307         Update.
8308         (flush_wrap_buffer): Only flush gdb_stdout.
8309         (wrap_here): Set wrap_style.
8310         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8311         treat escape sequences as a character.  Change when wrap buffer is
8312         flushed.
8313         (fputs_styled): Do not set the output style when the default is
8314         requested.
8315         * ui-style.h (struct ui_file_style) <is_default>: New method.
8316         * source.c (print_source_lines_base): Emit escape sequences in one
8317         piece.
8318
8319 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8320
8321         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8322         integers and enumeration types.
8323
8324 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8325
8326         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8327         instead of lookup_symbol_in_language
8328         (do_exact_match): New function.
8329         (ada_get_symbol_name_matcher): Return do_exact_match when
8330         doing a verbatim match.
8331
8332 2019-02-15  Tom Tromey  <tromey@adacore.com>
8333
8334         * ravenscar-thread.c (ravenscar_thread_target::resume)
8335         (ravenscar_thread_target::wait): Special case wildcard requests.
8336
8337 2019-02-15  Tom Tromey  <tromey@adacore.com>
8338
8339         * ravenscar-thread.c (base_ptid): Remove.
8340         (struct ravenscar_thread_target) <close>: New method.
8341         <m_base_ptid>: New member.
8342         <update_inferior_ptid, active_task, task_is_currently_active,
8343         runtime_initialized>: Declare methods.
8344         <ravenscar_thread_target>: Add constructor.
8345         (ravenscar_thread_target::task_is_currently_active)
8346         (ravenscar_thread_target::update_inferior_ptid)
8347         (ravenscar_runtime_initialized): Rename.  Now methods.
8348         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8349         (ravenscar_thread_target::update_thread_list): Update.
8350         (ravenscar_thread_target::active_task): Now method.
8351         (ravenscar_thread_target::store_registers)
8352         (ravenscar_thread_target::prepare_to_store)
8353         (ravenscar_thread_target::prepare_to_store)
8354         (ravenscar_thread_target::mourn_inferior): Update.
8355         (ravenscar_inferior_created): Use "new" to create target.
8356         (ravenscar_thread_target::get_ada_task_ptid): Update.
8357         (_initialize_ravenscar): Don't initialize base_ptid.
8358         (ravenscar_ops): Remove global.
8359
8360 2019-02-15  Tom Tromey  <tromey@adacore.com>
8361
8362         * target.h (push_target): Declare new overload.
8363         * target.c (push_target): New overload, taking an rvalue reference.
8364         * remote.c (remote_target::open_1): Use push_target overload.
8365         * corelow.c (core_target_open): Use push_target overload.
8366
8367 2019-02-15  Tom Tromey  <tromey@adacore.com>
8368
8369         * ravenscar-thread.c (is_ravenscar_task)
8370         (ravenscar_task_is_currently_active): Return bool.
8371         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8372         (_initialize_ravenscar): Remove "(void)".
8373         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8374         Return bool.
8375
8376 2019-02-15  Tom Tromey  <tromey@adacore.com>
8377
8378         * ravenscar-thread.c (ravenscar_runtime_initializer)
8379         (has_ravenscar_runtime, get_running_thread_id)
8380         (ravenscar_thread_target::resume): Fix indentation.
8381
8382 2019-02-15  Tom Tromey  <tromey@adacore.com>
8383
8384         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8385         from ravenscar_arch_ops.
8386         (sparc_ravenscar_ops::fetch_registers)
8387         (sparc_ravenscar_ops::store_registers): Now methods.
8388         (sparc_ravenscar_prepare_to_store): Remove.
8389         (sparc_ravenscar_ops): Redefine.
8390         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8391         methods and destructor.  Remove members.
8392         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8393         (ravenscar_thread_target::store_registers)
8394         (ravenscar_thread_target::prepare_to_store): Update.
8395         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8396         Remove.
8397         (struct ppc_ravenscar_powerpc_ops): Derive from
8398         ravenscar_arch_ops.
8399         (ppc_ravenscar_powerpc_ops::fetch_registers)
8400         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8401         (ppc_ravenscar_powerpc_ops): Redefine.
8402         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8403         (ppc_ravenscar_e500_ops::fetch_registers)
8404         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8405         (ppc_ravenscar_e500_ops): Redefine.
8406         * aarch64-ravenscar-thread.c
8407         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8408         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8409         (aarch64_ravenscar_fetch_registers)
8410         (aarch64_ravenscar_store_registers): Now methods.
8411         (aarch64_ravenscar_ops): Redefine.
8412
8413 2019-02-15  Tom Tromey  <tromey@adacore.com>
8414
8415         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8416         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8417         (ravenscar_thread_target::stopped_by_watchpoint)
8418         (ravenscar_thread_target::stopped_data_address)
8419         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8420
8421 2019-02-15  Tom Tromey  <tromey@adacore.com>
8422
8423         * ravenscar-thread.c: Fix some typos.
8424
8425 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8426             Tom Tromey  <tromey@adacore.com>
8427
8428         * ada-lang.c (ada_exception_sal): Change addr_string to a
8429         std::string.
8430         (create_ada_exception_catchpoint): Update.
8431
8432 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8433             Tom Tromey  <tromey@adacore.com>
8434
8435         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8436         (bp_location_ops): Remove.
8437         (base_breakpoint_allocate_location): Update.
8438         (free_bp_location): Update.
8439         * ada-lang.c (class ada_catchpoint_location)
8440         <ada_catchpoint_location>: Remove ops parameter.
8441         (ada_catchpoint_location_dtor): Remove.
8442         (ada_catchpoint_location_ops): Remove.
8443         (allocate_location_exception): Update.
8444         * breakpoint.h (struct bp_location_ops): Remove.
8445         (class bp_location) <bp_location>: Remove bp_location_ops
8446         parameter.
8447         <~bp_location>: Add destructor.
8448         <ops>: Remove.
8449
8450 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8451             Pedro Alves  <palves@redhat.com>
8452
8453         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8454         'PATH_MAX'.
8455
8456 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8457             Samuel Thibault  <samuel.thibault@gnu.org>
8458             Thomas Schwinge  <thomas@codesourcery.com>
8459
8460         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8461         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8462
8463 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8464
8465         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8466         (check_empty): Use "const char *".
8467
8468         * gnu-nat.c (gnu_nat_target::detach): Instead of
8469         'detach_inferior (pid)' call
8470         'detach_inferior (find_inferior_pid (pid))'.
8471
8472         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8473         'nat/fork-inferior.o'.
8474         * gnu-nat.c: #include "nat/fork-inferior.h".
8475
8476         * gnu-nat.c (gnu_nat_target::detach): Instead of
8477         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8478         * gnu-nat.h: #include "inf-child.h".
8479         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8480         'i386_gnu_nat_target::fetch_registers'.
8481         (gnu_store_registers): Rename/move to
8482         'i386_gnu_nat_target::store_registers'.
8483
8484         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8485         * gnu-nat.h (mach_thread_info): New function.
8486         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8487
8488         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8489
8490 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8491
8492         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8493
8494 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8495
8496         * windows-nat.c (windows_add_thread): Add new parameter
8497         "main_thread_p" with default value set to false.  Update
8498         function documentation as well as all callers.
8499         (windows_delete_thread): Likewise.
8500         (fake_create_process): Update call to windows_add_thread.
8501         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8502         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8503         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8504         call to windows_delete_thread.
8505
8506 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8507
8508         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8509
8510 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8511
8512         * symfile.c (find_separate_debug_file): Use canonical path of
8513         sysroot with child_path instead of gdb_sysroot if it is valid.
8514
8515 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8516
8517         * symfile.c (find_separate_debug_file): Use child_path to
8518         determine if an object file is under a sysroot.
8519
8520 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8521
8522         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8523         unittests/child-path-selftests.c.
8524         * common/pathstuff.c (child_path): New function.
8525         * common/pathstuff.h (child_path): New prototype.
8526         * unittests/child-path-selftests.c: New file.
8527
8528 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8529
8530         * symfile.c (find_separate_debug_file): Look for separate debug
8531         files in debug directories under the sysroot.
8532
8533 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8534
8535         * symtab.h (struct minimal_symbol data_p): New const method.
8536         (struct minimal_symbol text_p): Likewise.
8537         * symtab.c (output_source_filename): Use file name style
8538         to print file name.
8539         (print_symbol_info): Likewise.
8540         (print_msymbol_info): Use address style to print addresses.
8541         Use function name style to print executable text symbols.
8542         (expand_symtab_containing_pc): Use data_p.
8543         (find_pc_sect_compunit_symtab): Likewise.
8544
8545 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8546
8547         * breakpoint.c (describe_other_breakpoints): Use address style
8548         to print addresses.
8549         (say_where): Likewise.
8550
8551 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8552
8553         * ada-typeprint.c (print_func_type): Print function name
8554         style to print function name.
8555         * c-typeprint.c (c_print_type_1): Likewise.
8556
8557 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8558
8559         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8560         for execve.
8561
8562 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8563
8564         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8565         type_stack.
8566
8567 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8568
8569         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8570         TYPE_CODE_REF types.
8571
8572 2019-02-08  Jim Wilson  <jimw@sifive.com>
8573
8574         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8575         (riscv_linux_fregset): New.
8576         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8577
8578 2019-02-07  Tom Tromey  <tom@tromey.com>
8579
8580         * thread.c (thread_cancel_execution_command): Update.
8581         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8582         methods.
8583         (struct thread_fsm_ops): Remove.
8584         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8585         (thread_fsm_should_stop, thread_fsm_return_value)
8586         (thread_fsm_set_finished, thread_fsm_finished_p)
8587         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8588         Don't declare.
8589         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8590         * infrun.c (clear_proceed_status_thread)
8591         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8592         (print_stop_event): Update.
8593         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8594         Add constructor.
8595         (step_command_fsm_ops): Remove.
8596         (new_step_command_fsm): Remove.
8597         (step_1): Update.
8598         (step_command_fsm::should_stop): Rename from
8599         step_command_fsm_should_stop.
8600         (step_command_fsm::clean_up): Rename from
8601         step_command_fsm_clean_up.
8602         (step_command_fsm::do_async_reply_reason): Rename from
8603         step_command_fsm_async_reply_reason.
8604         (struct until_next_fsm): Inherit from thread_fsm.  Add
8605         constructor.
8606         (until_next_fsm_ops): Remove.
8607         (new_until_next_fsm): Remove.
8608         (until_next_fsm::should_stop): Rename from
8609         until_next_fsm_should_stop.
8610         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8611         (until_next_fsm::do_async_reply_reason): Rename from
8612         until_next_fsm_async_reply_reason.
8613         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8614         constructor.  Change type of breakpoint.
8615         (finish_command_fsm_ops): Remove.
8616         (new_finish_command_fsm): Remove.
8617         (finish_command_fsm::should_stop): Rename from
8618         finish_command_fsm_should_stop.
8619         (finish_command_fsm::clean_up): Rename from
8620         finish_command_fsm_clean_up.
8621         (finish_command_fsm::return_value): Rename from
8622         finish_command_fsm_return_value.
8623         (finish_command_fsm::do_async_reply_reason): Rename from
8624         finish_command_fsm_async_reply_reason.
8625         (finish_command): Update.
8626         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8627         Add constructor.
8628         (call_thread_fsm_ops): Remove.
8629         (call_thread_fsm::call_thread_fsm): Rename from
8630         new_call_thread_fsm.
8631         (call_thread_fsm::should_stop): Rename from
8632         call_thread_fsm_should_stop.
8633         (call_thread_fsm::should_notify_stop): Rename from
8634         call_thread_fsm_should_notify_stop.
8635         (run_inferior_call, call_function_by_hand_dummy): Update.
8636         * cli/cli-interp.c (should_print_stop_to_console): Update.
8637         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8638         Add constructor.  Change type of location_breakpoint,
8639         caller_breakpoint.
8640         (until_break_fsm_ops): Remove.
8641         (new_until_break_fsm): Remove.
8642         (until_break_fsm::should_stop): Rename from
8643         until_break_fsm_should_stop.
8644         (until_break_fsm::clean_up): Rename from
8645         until_break_fsm_clean_up.
8646         (until_break_fsm::do_async_reply_reason): Rename from
8647         until_break_fsm_async_reply_reason.
8648         (until_break_command): Update.
8649         * thread-fsm.c: Remove.
8650         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8651
8652 2019-02-07  Tom Tromey  <tom@tromey.com>
8653
8654         * yy-remap.h: Add include guard.
8655         * xtensa-tdep.h: Add include guard.
8656         * xcoffread.h: Rename include guard.
8657         * varobj-iter.h: Add include guard.
8658         * tui/tui.h: Rename include guard.
8659         * tui/tui-winsource.h: Rename include guard.
8660         * tui/tui-wingeneral.h: Rename include guard.
8661         * tui/tui-windata.h: Rename include guard.
8662         * tui/tui-win.h: Rename include guard.
8663         * tui/tui-stack.h: Rename include guard.
8664         * tui/tui-source.h: Rename include guard.
8665         * tui/tui-regs.h: Rename include guard.
8666         * tui/tui-out.h: Rename include guard.
8667         * tui/tui-layout.h: Rename include guard.
8668         * tui/tui-io.h: Rename include guard.
8669         * tui/tui-hooks.h: Rename include guard.
8670         * tui/tui-file.h: Rename include guard.
8671         * tui/tui-disasm.h: Rename include guard.
8672         * tui/tui-data.h: Rename include guard.
8673         * tui/tui-command.h: Rename include guard.
8674         * tic6x-tdep.h: Add include guard.
8675         * target/waitstatus.h: Rename include guard.
8676         * target/wait.h: Rename include guard.
8677         * target/target.h: Rename include guard.
8678         * target/resume.h: Rename include guard.
8679         * target-float.h: Rename include guard.
8680         * stabsread.h: Add include guard.
8681         * rs6000-tdep.h: Add include guard.
8682         * riscv-fbsd-tdep.h: Add include guard.
8683         * regformats/regdef.h: Rename include guard.
8684         * record.h: Rename include guard.
8685         * python/python.h: Rename include guard.
8686         * python/python-internal.h: Rename include guard.
8687         * python/py-stopevent.h: Rename include guard.
8688         * python/py-ref.h: Rename include guard.
8689         * python/py-record.h: Rename include guard.
8690         * python/py-record-full.h: Rename include guard.
8691         * python/py-record-btrace.h: Rename include guard.
8692         * python/py-instruction.h: Rename include guard.
8693         * python/py-events.h: Rename include guard.
8694         * python/py-event.h: Rename include guard.
8695         * procfs.h: Add include guard.
8696         * proc-utils.h: Add include guard.
8697         * p-lang.h: Add include guard.
8698         * or1k-tdep.h: Rename include guard.
8699         * observable.h: Rename include guard.
8700         * nto-tdep.h: Rename include guard.
8701         * nat/x86-linux.h: Rename include guard.
8702         * nat/x86-linux-dregs.h: Rename include guard.
8703         * nat/x86-gcc-cpuid.h: Add include guard.
8704         * nat/x86-dregs.h: Rename include guard.
8705         * nat/x86-cpuid.h: Rename include guard.
8706         * nat/ppc-linux.h: Rename include guard.
8707         * nat/mips-linux-watch.h: Rename include guard.
8708         * nat/linux-waitpid.h: Rename include guard.
8709         * nat/linux-ptrace.h: Rename include guard.
8710         * nat/linux-procfs.h: Rename include guard.
8711         * nat/linux-osdata.h: Rename include guard.
8712         * nat/linux-nat.h: Rename include guard.
8713         * nat/linux-namespaces.h: Rename include guard.
8714         * nat/linux-btrace.h: Rename include guard.
8715         * nat/glibc_thread_db.h: Rename include guard.
8716         * nat/gdb_thread_db.h: Rename include guard.
8717         * nat/gdb_ptrace.h: Rename include guard.
8718         * nat/fork-inferior.h: Rename include guard.
8719         * nat/amd64-linux-siginfo.h: Rename include guard.
8720         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8721         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8722         * nat/aarch64-linux.h: Rename include guard.
8723         * nat/aarch64-linux-hw-point.h: Rename include guard.
8724         * mn10300-tdep.h: Add include guard.
8725         * mips-linux-tdep.h: Add include guard.
8726         * mi/mi-parse.h: Rename include guard.
8727         * mi/mi-out.h: Rename include guard.
8728         * mi/mi-main.h: Rename include guard.
8729         * mi/mi-interp.h: Rename include guard.
8730         * mi/mi-getopt.h: Rename include guard.
8731         * mi/mi-console.h: Rename include guard.
8732         * mi/mi-common.h: Rename include guard.
8733         * mi/mi-cmds.h: Rename include guard.
8734         * mi/mi-cmd-break.h: Rename include guard.
8735         * m2-lang.h: Add include guard.
8736         * location.h: Rename include guard.
8737         * linux-record.h: Rename include guard.
8738         * linux-nat.h: Add include guard.
8739         * linux-fork.h: Add include guard.
8740         * i386-darwin-tdep.h: Rename include guard.
8741         * hppa-linux-offsets.h: Add include guard.
8742         * guile/guile.h: Rename include guard.
8743         * guile/guile-internal.h: Rename include guard.
8744         * gnu-nat.h: Rename include guard.
8745         * gdb-stabs.h: Rename include guard.
8746         * frv-tdep.h: Add include guard.
8747         * f-lang.h: Add include guard.
8748         * event-loop.h: Add include guard.
8749         * darwin-nat.h: Rename include guard.
8750         * cp-abi.h: Rename include guard.
8751         * config/sparc/nm-sol2.h: Rename include guard.
8752         * config/nm-nto.h: Rename include guard.
8753         * config/nm-linux.h: Add include guard.
8754         * config/i386/nm-i386gnu.h: Rename include guard.
8755         * config/djgpp/nl_types.h: Rename include guard.
8756         * config/djgpp/langinfo.h: Rename include guard.
8757         * compile/gcc-cp-plugin.h: Add include guard.
8758         * compile/gcc-c-plugin.h: Add include guard.
8759         * compile/compile.h: Rename include guard.
8760         * compile/compile-object-run.h: Rename include guard.
8761         * compile/compile-object-load.h: Rename include guard.
8762         * compile/compile-internal.h: Rename include guard.
8763         * compile/compile-cplus.h: Rename include guard.
8764         * compile/compile-c.h: Rename include guard.
8765         * common/xml-utils.h: Rename include guard.
8766         * common/x86-xstate.h: Rename include guard.
8767         * common/version.h: Rename include guard.
8768         * common/vec.h: Rename include guard.
8769         * common/tdesc.h: Rename include guard.
8770         * common/selftest.h: Rename include guard.
8771         * common/scoped_restore.h: Rename include guard.
8772         * common/scoped_mmap.h: Rename include guard.
8773         * common/scoped_fd.h: Rename include guard.
8774         * common/safe-iterator.h: Rename include guard.
8775         * common/run-time-clock.h: Rename include guard.
8776         * common/refcounted-object.h: Rename include guard.
8777         * common/queue.h: Rename include guard.
8778         * common/ptid.h: Rename include guard.
8779         * common/print-utils.h: Rename include guard.
8780         * common/preprocessor.h: Rename include guard.
8781         * common/pathstuff.h: Rename include guard.
8782         * common/observable.h: Rename include guard.
8783         * common/netstuff.h: Rename include guard.
8784         * common/job-control.h: Rename include guard.
8785         * common/host-defs.h: Rename include guard.
8786         * common/gdb_wait.h: Rename include guard.
8787         * common/gdb_vecs.h: Rename include guard.
8788         * common/gdb_unlinker.h: Rename include guard.
8789         * common/gdb_unique_ptr.h: Rename include guard.
8790         * common/gdb_tilde_expand.h: Rename include guard.
8791         * common/gdb_sys_time.h: Rename include guard.
8792         * common/gdb_string_view.h: Rename include guard.
8793         * common/gdb_splay_tree.h: Rename include guard.
8794         * common/gdb_setjmp.h: Rename include guard.
8795         * common/gdb_ref_ptr.h: Rename include guard.
8796         * common/gdb_optional.h: Rename include guard.
8797         * common/gdb_locale.h: Rename include guard.
8798         * common/gdb_assert.h: Rename include guard.
8799         * common/filtered-iterator.h: Rename include guard.
8800         * common/filestuff.h: Rename include guard.
8801         * common/fileio.h: Rename include guard.
8802         * common/environ.h: Rename include guard.
8803         * common/common-utils.h: Rename include guard.
8804         * common/common-types.h: Rename include guard.
8805         * common/common-regcache.h: Rename include guard.
8806         * common/common-inferior.h: Rename include guard.
8807         * common/common-gdbthread.h: Rename include guard.
8808         * common/common-exceptions.h: Rename include guard.
8809         * common/common-defs.h: Rename include guard.
8810         * common/common-debug.h: Rename include guard.
8811         * common/cleanups.h: Rename include guard.
8812         * common/buffer.h: Rename include guard.
8813         * common/btrace-common.h: Rename include guard.
8814         * common/break-common.h: Rename include guard.
8815         * cli/cli-utils.h: Rename include guard.
8816         * cli/cli-style.h: Rename include guard.
8817         * cli/cli-setshow.h: Rename include guard.
8818         * cli/cli-script.h: Rename include guard.
8819         * cli/cli-interp.h: Rename include guard.
8820         * cli/cli-decode.h: Rename include guard.
8821         * cli/cli-cmds.h: Rename include guard.
8822         * charset-list.h: Add include guard.
8823         * buildsym-legacy.h: Rename include guard.
8824         * bfin-tdep.h: Add include guard.
8825         * ax.h: Rename include guard.
8826         * arm-linux-tdep.h: Add include guard.
8827         * arm-fbsd-tdep.h: Add include guard.
8828         * arch/xtensa.h: Rename include guard.
8829         * arch/tic6x.h: Add include guard.
8830         * arch/i386.h: Add include guard.
8831         * arch/arm.h: Rename include guard.
8832         * arch/arm-linux.h: Rename include guard.
8833         * arch/arm-get-next-pcs.h: Rename include guard.
8834         * arch/amd64.h: Add include guard.
8835         * arch/aarch64-insn.h: Rename include guard.
8836         * arch-utils.h: Rename include guard.
8837         * annotate.h: Add include guard.
8838         * amd64-darwin-tdep.h: Rename include guard.
8839         * aarch64-linux-tdep.h: Add include guard.
8840         * aarch64-fbsd-tdep.h: Add include guard.
8841         * aarch32-linux-nat.h: Add include guard.
8842
8843 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8844
8845         * macrotab.c (macro_define_internal): New function that
8846         factorizes macro_define_object_internal and macro_define_function
8847         code.
8848         (macro_define_object_internal): Use macro_define_internal.
8849         (macro_define_function): Likewise.
8850
8851 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8852
8853         * macrocmd.c (extract_identifier): Return
8854         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8855         callers.
8856
8857 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8858
8859         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8860
8861 2019-02-05  Tom Tromey  <tom@tromey.com>
8862
8863         * target.c (target_stack::unpush): Move assertion earlier.
8864
8865 2019-01-30  Tom Tromey  <tom@tromey.com>
8866
8867         PR python/23615:
8868         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8869         (gdbpy_parse_and_eval): Likewise.
8870         * python/python-internal.h (gdbpy_allow_threads): New class.
8871
8872 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8873
8874         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8875         (aarch64_fbsd_fpregmap): Move earlier.
8876         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8877         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8878         instead of individual calls to trad_frame_set_reg_addr.
8879         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8880         earlier.
8881         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8882         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8883         instead of individual calls to trad_frame_set_reg_addr.
8884
8885 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8886
8887         * CONTRIBUTE: Replace contribution list with wiki link.
8888
8889 2019-01-25  Tom Tromey  <tom@tromey.com>
8890
8891         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8892
8893 2019-01-25  Tom Tromey  <tom@tromey.com>
8894
8895         * xtensa-linux-nat.c: Fix common/ includes.
8896         * xml-support.h: Fix common/ includes.
8897         * xml-support.c: Fix common/ includes.
8898         * x86-linux-nat.c: Fix common/ includes.
8899         * windows-nat.c: Fix common/ includes.
8900         * varobj.h: Fix common/ includes.
8901         * varobj.c: Fix common/ includes.
8902         * value.c: Fix common/ includes.
8903         * valops.c: Fix common/ includes.
8904         * utils.c: Fix common/ includes.
8905         * unittests/xml-utils-selftests.c: Fix common/ includes.
8906         * unittests/utils-selftests.c: Fix common/ includes.
8907         * unittests/unpack-selftests.c: Fix common/ includes.
8908         * unittests/tracepoint-selftests.c: Fix common/ includes.
8909         * unittests/style-selftests.c: Fix common/ includes.
8910         * unittests/string_view-selftests.c: Fix common/ includes.
8911         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8912         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8913         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8914         * unittests/rsp-low-selftests.c: Fix common/ includes.
8915         * unittests/parse-connection-spec-selftests.c: Fix common/
8916         includes.
8917         * unittests/optional-selftests.c: Fix common/ includes.
8918         * unittests/offset-type-selftests.c: Fix common/ includes.
8919         * unittests/observable-selftests.c: Fix common/ includes.
8920         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8921         * unittests/memrange-selftests.c: Fix common/ includes.
8922         * unittests/memory-map-selftests.c: Fix common/ includes.
8923         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8924         * unittests/function-view-selftests.c: Fix common/ includes.
8925         * unittests/environ-selftests.c: Fix common/ includes.
8926         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8927         * unittests/common-utils-selftests.c: Fix common/ includes.
8928         * unittests/cli-utils-selftests.c: Fix common/ includes.
8929         * unittests/array-view-selftests.c: Fix common/ includes.
8930         * ui-file.c: Fix common/ includes.
8931         * tui/tui-io.c: Fix common/ includes.
8932         * tracepoint.h: Fix common/ includes.
8933         * tracepoint.c: Fix common/ includes.
8934         * tracefile-tfile.c: Fix common/ includes.
8935         * top.h: Fix common/ includes.
8936         * top.c: Fix common/ includes.
8937         * thread.c: Fix common/ includes.
8938         * target/waitstatus.h: Fix common/ includes.
8939         * target/waitstatus.c: Fix common/ includes.
8940         * target.h: Fix common/ includes.
8941         * target.c: Fix common/ includes.
8942         * target-memory.c: Fix common/ includes.
8943         * target-descriptions.c: Fix common/ includes.
8944         * symtab.h: Fix common/ includes.
8945         * symfile.c: Fix common/ includes.
8946         * stap-probe.c: Fix common/ includes.
8947         * spu-linux-nat.c: Fix common/ includes.
8948         * sparc-nat.c: Fix common/ includes.
8949         * source.c: Fix common/ includes.
8950         * solib.c: Fix common/ includes.
8951         * solib-target.c: Fix common/ includes.
8952         * ser-unix.c: Fix common/ includes.
8953         * ser-tcp.c: Fix common/ includes.
8954         * ser-pipe.c: Fix common/ includes.
8955         * ser-base.c: Fix common/ includes.
8956         * selftest-arch.c: Fix common/ includes.
8957         * s12z-tdep.c: Fix common/ includes.
8958         * rust-exp.y: Fix common/ includes.
8959         * rs6000-aix-tdep.c: Fix common/ includes.
8960         * riscv-tdep.c: Fix common/ includes.
8961         * remote.c: Fix common/ includes.
8962         * remote-notif.h: Fix common/ includes.
8963         * remote-fileio.h: Fix common/ includes.
8964         * remote-fileio.c: Fix common/ includes.
8965         * regcache.h: Fix common/ includes.
8966         * regcache.c: Fix common/ includes.
8967         * record-btrace.c: Fix common/ includes.
8968         * python/python.c: Fix common/ includes.
8969         * python/py-type.c: Fix common/ includes.
8970         * python/py-inferior.c: Fix common/ includes.
8971         * progspace.h: Fix common/ includes.
8972         * producer.c: Fix common/ includes.
8973         * procfs.c: Fix common/ includes.
8974         * proc-api.c: Fix common/ includes.
8975         * printcmd.c: Fix common/ includes.
8976         * ppc-linux-nat.c: Fix common/ includes.
8977         * parser-defs.h: Fix common/ includes.
8978         * osdata.c: Fix common/ includes.
8979         * obsd-nat.c: Fix common/ includes.
8980         * nat/x86-linux.c: Fix common/ includes.
8981         * nat/x86-linux-dregs.c: Fix common/ includes.
8982         * nat/x86-dregs.h: Fix common/ includes.
8983         * nat/x86-dregs.c: Fix common/ includes.
8984         * nat/ppc-linux.c: Fix common/ includes.
8985         * nat/mips-linux-watch.h: Fix common/ includes.
8986         * nat/mips-linux-watch.c: Fix common/ includes.
8987         * nat/linux-waitpid.c: Fix common/ includes.
8988         * nat/linux-ptrace.h: Fix common/ includes.
8989         * nat/linux-ptrace.c: Fix common/ includes.
8990         * nat/linux-procfs.c: Fix common/ includes.
8991         * nat/linux-personality.c: Fix common/ includes.
8992         * nat/linux-osdata.c: Fix common/ includes.
8993         * nat/linux-namespaces.c: Fix common/ includes.
8994         * nat/linux-btrace.h: Fix common/ includes.
8995         * nat/linux-btrace.c: Fix common/ includes.
8996         * nat/fork-inferior.c: Fix common/ includes.
8997         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8998         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8999         * nat/aarch64-linux.c: Fix common/ includes.
9000         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9001         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9002         * namespace.h: Fix common/ includes.
9003         * mips-linux-tdep.c: Fix common/ includes.
9004         * minsyms.c: Fix common/ includes.
9005         * mi/mi-parse.h: Fix common/ includes.
9006         * mi/mi-main.c: Fix common/ includes.
9007         * mi/mi-cmd-env.c: Fix common/ includes.
9008         * memrange.h: Fix common/ includes.
9009         * memattr.c: Fix common/ includes.
9010         * maint.h: Fix common/ includes.
9011         * maint.c: Fix common/ includes.
9012         * main.c: Fix common/ includes.
9013         * machoread.c: Fix common/ includes.
9014         * location.c: Fix common/ includes.
9015         * linux-thread-db.c: Fix common/ includes.
9016         * linux-nat.c: Fix common/ includes.
9017         * linux-fork.c: Fix common/ includes.
9018         * inline-frame.c: Fix common/ includes.
9019         * infrun.c: Fix common/ includes.
9020         * inflow.c: Fix common/ includes.
9021         * inferior.h: Fix common/ includes.
9022         * inferior.c: Fix common/ includes.
9023         * infcmd.c: Fix common/ includes.
9024         * inf-ptrace.c: Fix common/ includes.
9025         * inf-child.c: Fix common/ includes.
9026         * ia64-linux-nat.c: Fix common/ includes.
9027         * i387-tdep.c: Fix common/ includes.
9028         * i386-tdep.c: Fix common/ includes.
9029         * i386-linux-tdep.c: Fix common/ includes.
9030         * i386-linux-nat.c: Fix common/ includes.
9031         * i386-go32-tdep.c: Fix common/ includes.
9032         * i386-fbsd-tdep.c: Fix common/ includes.
9033         * i386-fbsd-nat.c: Fix common/ includes.
9034         * guile/scm-type.c: Fix common/ includes.
9035         * guile/guile.c: Fix common/ includes.
9036         * go32-nat.c: Fix common/ includes.
9037         * gnu-nat.c: Fix common/ includes.
9038         * gdbthread.h: Fix common/ includes.
9039         * gdbarch-selftests.c: Fix common/ includes.
9040         * gdb_usleep.c: Fix common/ includes.
9041         * gdb_select.h: Fix common/ includes.
9042         * gdb_bfd.c: Fix common/ includes.
9043         * gcore.c: Fix common/ includes.
9044         * fork-child.c: Fix common/ includes.
9045         * findvar.c: Fix common/ includes.
9046         * fbsd-nat.c: Fix common/ includes.
9047         * event-top.c: Fix common/ includes.
9048         * event-loop.c: Fix common/ includes.
9049         * dwarf2read.c: Fix common/ includes.
9050         * dwarf2loc.c: Fix common/ includes.
9051         * dwarf2-frame.c: Fix common/ includes.
9052         * dwarf-index-cache.c: Fix common/ includes.
9053         * dtrace-probe.c: Fix common/ includes.
9054         * disasm-selftests.c: Fix common/ includes.
9055         * defs.h: Fix common/ includes.
9056         * csky-tdep.c: Fix common/ includes.
9057         * cp-valprint.c: Fix common/ includes.
9058         * cp-support.h: Fix common/ includes.
9059         * cp-support.c: Fix common/ includes.
9060         * corelow.c: Fix common/ includes.
9061         * completer.h: Fix common/ includes.
9062         * completer.c: Fix common/ includes.
9063         * compile/compile.c: Fix common/ includes.
9064         * compile/compile-loc2c.c: Fix common/ includes.
9065         * compile/compile-cplus-types.c: Fix common/ includes.
9066         * compile/compile-cplus-symbols.c: Fix common/ includes.
9067         * command.h: Fix common/ includes.
9068         * cli/cli-dump.c: Fix common/ includes.
9069         * cli/cli-cmds.c: Fix common/ includes.
9070         * charset.c: Fix common/ includes.
9071         * build-id.c: Fix common/ includes.
9072         * btrace.h: Fix common/ includes.
9073         * btrace.c: Fix common/ includes.
9074         * breakpoint.h: Fix common/ includes.
9075         * breakpoint.c: Fix common/ includes.
9076         * ax.h:
9077         (enum agent_op): Fix common/ includes.
9078         * ax-general.c (struct aop_map): Fix common/ includes.
9079         * ax-gdb.c: Fix common/ includes.
9080         * auxv.c: Fix common/ includes.
9081         * auto-load.c: Fix common/ includes.
9082         * arm-tdep.c: Fix common/ includes.
9083         * arch/riscv.c: Fix common/ includes.
9084         * arch/ppc-linux-common.c: Fix common/ includes.
9085         * arch/i386.c: Fix common/ includes.
9086         * arch/arm.c: Fix common/ includes.
9087         * arch/arm-linux.c: Fix common/ includes.
9088         * arch/arm-get-next-pcs.c: Fix common/ includes.
9089         * arch/amd64.c: Fix common/ includes.
9090         * arch/aarch64.c: Fix common/ includes.
9091         * arch/aarch64-insn.c: Fix common/ includes.
9092         * arch-utils.c: Fix common/ includes.
9093         * amd64-windows-tdep.c: Fix common/ includes.
9094         * amd64-tdep.c: Fix common/ includes.
9095         * amd64-sol2-tdep.c: Fix common/ includes.
9096         * amd64-obsd-tdep.c: Fix common/ includes.
9097         * amd64-nbsd-tdep.c: Fix common/ includes.
9098         * amd64-linux-tdep.c: Fix common/ includes.
9099         * amd64-linux-nat.c: Fix common/ includes.
9100         * amd64-fbsd-tdep.c: Fix common/ includes.
9101         * amd64-fbsd-nat.c: Fix common/ includes.
9102         * amd64-dicos-tdep.c: Fix common/ includes.
9103         * amd64-darwin-tdep.c: Fix common/ includes.
9104         * agent.c: Fix common/ includes.
9105         * ada-lang.h: Fix common/ includes.
9106         * ada-lang.c: Fix common/ includes.
9107         * aarch64-tdep.c: Fix common/ includes.
9108
9109 2019-01-25  Tom Tromey  <tom@tromey.com>
9110
9111         * common/create-version.sh: Use common/version.h.
9112
9113 2019-01-24  Pedro Alves  <palves@redhat.com>
9114
9115         * infrun.c (signal_stop, signal_print, signal_program)
9116         (signal_catch, signal_pass): Now arrays instead of pointers.
9117         (update_signals_program_target, do_target_resume)
9118         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9119         * linux-nat.c (linux_nat_target::pass_signals)
9120         (linux_nat_target::create_inferior, linux_nat_target::attach):
9121         Adjust.
9122         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9123         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9124         * procfs.c (procfs_target::pass_signals): Adjust.
9125         * record-full.c (record_full_target::resume): Adjust.
9126         * remote.c (remote_target::pass_signals)
9127         (remote_target::program_signals): Adjust.
9128         * target-debug.h (target_debug_print_signals): Now takes a
9129         gdb::array_view as parameter.  Adjust.
9130         * target.h (target_ops) <pass_signals, program_signals>: Replace
9131         pointer and length parameters with gdb::array_view.
9132         (target_pass_signals, target_program_signals): Likewise.
9133         * target-delegates.c: Regenerate.
9134
9135 2019-01-24  Pedro Alves  <palves@redhat.com>
9136
9137         * common/forward-scope-exit.h
9138         (forward_scope_exit::forward_scope_exit): Pass arguments to
9139         m_bind_function directly, instead of creating a std::bind and
9140         copying that.
9141
9142 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9143
9144         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9145         for static members.
9146         (pass_in_v_vfp_candidate): Likewise.
9147
9148 2019-01-23  Tom Tromey  <tom@tromey.com>
9149             Pedro Alves  <palves@redhat.com>
9150
9151         * regcache.c (class regcache_invalidator): Remove.
9152         (regcache::raw_write): Use make_scope_exit.
9153
9154 2019-01-23  Tom Tromey  <tom@tromey.com>
9155
9156         * ui-out.h (class ui_out_emit_type): Update comment.
9157
9158 2019-01-23  Tom Tromey  <tom@tromey.com>
9159
9160         * infrun.c (fetch_inferior_event): Update comment.
9161
9162 2019-01-23  Tom Tromey  <tom@tromey.com>
9163             Pedro Alves  <palves@redhat.com>
9164
9165         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9166         parameter.
9167         (fetch_inferior_event): Use SCOPE_EXIT.
9168
9169
9170 2019-01-23  Tom Tromey  <tom@tromey.com>
9171             Pedro Alves  <palves@redhat.com>
9172
9173         * infrun.c (disable_thread_events): Delete.
9174         (stop_all_threads): Use SCOPE_EXIT.
9175
9176 2019-01-23  Tom Tromey  <tom@tromey.com>
9177             Pedro Alves  <palves@redhat.com>
9178
9179         * symfile.c: Include forward-scope-exit.h.
9180         (clear_symtab_users_cleanup): Replace forward declaration with
9181         a FORWARD_SCOPE_EXIT.
9182         (syms_from_objfile_1): Use the forward_scope_exit and
9183         gdb::optional instead of cleanup_function.
9184         (reread_symbols): Use the forward_scope_exit instead of
9185         cleanup_function.
9186         (clear_symtab_users_cleanup): Remove function.
9187
9188 2019-01-23  Tom Tromey  <tom@tromey.com>
9189             Pedro Alves  <palves@redhat.com>
9190
9191         * linux-nat.c: Include scope-exit.h.
9192         (cleanup_target_stop): Remove.
9193         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9194         SCOPE_EXIT.
9195
9196 2019-01-23  Tom Tromey  <tom@tromey.com>
9197             Pedro Alves  <palves@redhat.com>
9198
9199         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9200         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9201
9202 2019-01-23  Tom Tromey  <tom@tromey.com>
9203             Andrew Burgess  <andrew.burgess@embecosm.com>
9204             Pedro Alves  <palves@redhat.com>
9205
9206         * infrun.c (fetch_inferior_event): Use scope_exit.
9207         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9208         * top.c (execute_command): Use scope_exit.
9209         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9210         * utils.c (do_bpstat_clear_actions_cleanup)
9211         (make_bpstat_clear_actions_cleanup): Remove.
9212
9213 2019-01-23  Tom Tromey  <tom@tromey.com>
9214             Pedro Alves  <palves@redhat.com>
9215
9216         * infrun.c: Include "common/scope-exit.h"
9217         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9218         (wait_for_inferior): Use SCOPE_EXIT.
9219         (fetch_inferior_event): Use scope_exit.
9220
9221 2019-01-23  Tom Tromey  <tom@tromey.com>
9222             Pedro Alves  <palves@redhat.com>
9223
9224         * breakpoint.c (create_breakpoint): Remove cleanup.
9225
9226 2019-01-23  Tom Tromey  <tom@tromey.com>
9227             Andrew Burgess  <andrew.burgess@embecosm.com>
9228             Pedro Alves  <palves@redhat.com>
9229
9230 2019-01-23  Pedro Alves  <palves@redhat.com>
9231
9232         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9233
9234 2019-01-23  Pedro Alves  <palves@redhat.com>
9235             Andrew Burgess  <andrew.burgess@embecosm.com>
9236
9237         * gdbthread.h: Include "common/forward-scope-exit.h".
9238         (scoped_finish_thread_state): Redefine custom class in terms of
9239         forward_scope_exit.
9240
9241 2019-01-23  Pedro Alves  <palves@redhat.com>
9242             Andrew Burgess  <andrew.burgess@embecosm.com>
9243
9244         * common/forward-scope-exit.h: New file.
9245
9246 2019-01-23  Pedro Alves  <palves@redhat.com>
9247             Andrew Burgess  <andrew.burgess@embecosm.com>
9248             Tom Tromey  <tom@tromey.com>
9249
9250         * common/scope-exit.h: New file.
9251
9252 2019-01-23  Pedro Alves  <palves@redhat.com>
9253
9254         * common/preprocessor.h (ESC): Rename to ...
9255         (ESC_PARENS): ... this.
9256         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9257         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9258
9259 2019-01-23  Tom Tromey  <tom@tromey.com>
9260
9261         * language.h (class scoped_switch_to_sym_language_if_auto):
9262         Initialize m_lang in both cases.
9263
9264 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9265
9266         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9267         with XCNEW.
9268
9269 2019-01-22  Tom Tromey  <tom@tromey.com>
9270
9271         * corelow.c: Do not include sys/file.h.
9272
9273 2019-01-22  Tom Tromey  <tom@tromey.com>
9274
9275         * tui/tui-wingeneral.h: Include gdb_curses.h.
9276
9277 2019-01-22  Tom Tromey  <tom@tromey.com>
9278
9279         * source-cache.h (class source_cache) <get_source_lines,
9280         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9281
9282 2019-01-22  Tom Tromey  <tom@tromey.com>
9283
9284         * remote-fileio.h (struct remote_target): Declare.
9285
9286 2019-01-22  Tom Tromey  <tom@tromey.com>
9287
9288         * python/py-arch.c: Do not include py-ref.h.
9289         * python/py-bpevent.c: Do not include py-ref.h.
9290         * python/py-cmd.c: Do not include py-ref.h.
9291         * python/py-continueevent.c: Do not include py-ref.h.
9292         * python/py-event.h: Do not include py-ref.h.
9293         * python/py-evtregistry.c: Do not include py-ref.h.
9294         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9295         * python/py-frame.c: Do not include py-ref.h.
9296         * python/py-framefilter.c: Do not include py-ref.h.
9297         * python/py-function.c: Do not include py-ref.h.
9298         * python/py-infevents.c: Do not include py-ref.h.
9299         * python/py-linetable.c: Do not include py-ref.h.
9300         * python/py-objfile.c: Do not include py-ref.h.
9301         * python/py-param.c: Do not include py-ref.h.
9302         * python/py-prettyprint.c: Do not include py-ref.h.
9303         * python/py-progspace.c: Do not include py-ref.h.
9304         * python/py-symbol.c: Do not include py-ref.h.
9305         * python/py-symtab.c: Do not include py-ref.h.
9306         * python/py-type.c: Do not include py-ref.h.
9307         * python/py-unwind.c: Do not include py-ref.h.
9308         * python/py-utils.c: Do not include py-ref.h.
9309         * python/py-value.c: Do not include py-ref.h.
9310         * python/py-varobj.c: Do not include py-ref.h.
9311         * python/py-xmethods.c: Do not include py-ref.h.
9312         * python/python.c: Do not include py-ref.h.
9313         * varobj.c: Do not include py-ref.h.
9314
9315 2019-01-22  Tom Tromey  <tom@tromey.com>
9316
9317         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9318         keyword for bcache.
9319
9320 2019-01-22  Tom Tromey  <tom@tromey.com>
9321
9322         * compile/compile-cplus-types.c: Remove a comment by #include.
9323
9324 2019-01-22  Tom Tromey  <tom@tromey.com>
9325
9326         * compile/gcc-c-plugin.h: Include compile-internal.h.
9327
9328 2019-01-22  Tom Tromey  <tom@tromey.com>
9329
9330         * stabsread.c (EXTERN): Do not define.
9331         (symnum, next_symbol_text_func, processing_gcc_compilation)
9332         (within_function, global_sym_chain, global_stabs)
9333         (previous_stab_code, this_object_header_files)
9334         (n_this_object_header_files)
9335         (n_allocated_this_object_header_files): Define.
9336         * stabsread.h (EXTERN): Never define.  Use "extern".
9337
9338 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9339
9340         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9341         history_value.
9342
9343 2019-01-21  Tom Tromey  <tom@tromey.com>
9344
9345         * ui-out.c: Fix includes.
9346         * tui/tui-source.c: Fix includes.
9347         * target.c: Fix includes.
9348         * remote.c: Fix includes.
9349         * regcache.c: Fix includes.
9350         * python/py-block.c: Fix includes.
9351         * printcmd.c: Fix includes.
9352         * or1k-tdep.c: Fix includes.
9353         * mi/mi-main.c: Fix includes.
9354         * m32r-tdep.c: Fix includes.
9355         * csky-tdep.c: Fix includes.
9356         * compile/compile-cplus-types.c: Fix includes.
9357         * cli/cli-interp.c: Fix includes.
9358
9359 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9360
9361         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9362         for padding.
9363
9364 2019-01-16  Tom Tromey  <tom@tromey.com>
9365
9366         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9367         earlier.
9368         (struct objfile) <msymbols_range>: Move from top level.
9369         <msymbols>: New method.
9370         (class objfile_msymbols): Remove.
9371         * symtab.c (default_collect_symbol_completion_matches_break_on):
9372         Update.
9373         * symmisc.c (dump_msymbols): Update.
9374         * stabsread.c (scan_file_globals): Update.
9375         * objc-lang.c (info_selectors_command, info_classes_command)
9376         (find_methods): Update.
9377         * minsyms.c (find_solib_trampoline_target): Update.
9378         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9379         * coffread.c (coff_symfile_read): Update.
9380         * ada-lang.c (ada_lookup_simple_minsym)
9381         (ada_collect_symbol_completion_matches): Update.
9382
9383 2019-01-16  Tom Tromey  <tom@tromey.com>
9384
9385         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9386         type.  Remove no-argument constructor.
9387         <iterator::operator++>: Simplify.
9388         <begin>: Update.
9389         <end>: Use minimal_symbol_count.
9390
9391 2019-01-16  Tom Tromey  <tom@tromey.com>
9392
9393         * objfiles.h (struct objfile) <psymtabs>: New method.
9394         (class objfile_psymtabs): Remove.
9395         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9396         typedef.
9397         <range>: New method.
9398         (require_partial_symbols): Change return type.
9399         * psymtab.c (require_partial_symbols)
9400         (psym_expand_symtabs_matching): Update.
9401         * mdebugread.c (parse_partial_symbols): Update.
9402         * dbxread.c (dbx_end_psymtab): Update.
9403
9404 2019-01-15  Tom Tromey  <tom@tromey.com>
9405
9406         * symtab.c (lookup_objfile_from_block)
9407         (lookup_symbol_in_objfile_symtabs)
9408         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9409         (find_line_symtab, info_sources_command)
9410         (default_collect_symbol_completion_matches_break_on)
9411         (make_source_files_completion_list): Update.
9412         * symmisc.c (print_objfile_statistics, dump_objfile)
9413         (maintenance_print_symbols, maintenance_info_symtabs)
9414         (maintenance_check_symtabs, maintenance_info_line_tables):
9415         Update.
9416         * source.c (select_source_symtab)
9417         (forget_cached_source_info_for_objfile): Update.
9418         * objfiles.h (class objfile_compunits): Remove.
9419         (struct objfile) <compunits_range>: New typedef.
9420         (compunits): New method.
9421         * objfiles.c (objfile_relocate1): Update.
9422         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9423         * maint.c (count_symtabs_and_blocks): Update.
9424         * linespec.c (iterate_over_all_matching_symtabs): Update.
9425         * cp-support.c (add_symbol_overload_list_qualified): Update.
9426         * coffread.c (coff_symtab_read): Update.
9427         * ada-lang.c (add_nonlocal_symbols)
9428         (ada_collect_symbol_completion_matches)
9429         (ada_add_global_exceptions): Update.
9430
9431 2019-01-15  Tom Tromey  <tom@tromey.com>
9432
9433         * progspace.h (program_space) <objfiles_safe_range>: New
9434         typedef.
9435         <objfiles_safe>: New method.
9436         * objfiles.h (class all_objfiles_safe): Remove.
9437         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9438         * jit.c (jit_inferior_exit_hook): Update.
9439
9440 2019-01-17  Tom Tromey  <tom@tromey.com>
9441
9442         * progspace.h (program_space) <objfiles_range>: New typedef.
9443         <objfiles>: New method.
9444         <objfiles_head>: Rename from objfiles.
9445         (object_files): Update.
9446         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9447         * guile/scm-pretty-print.c
9448         (ppscm_find_pretty_printer_from_objfiles): Update.
9449         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9450         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9451         Update.
9452         * python/py-progspace.c (pspy_get_objfiles): Update.
9453         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9454         Update.
9455         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9456         (objfpy_lookup_objfile_by_build_id): Update.
9457         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9458         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9459         Update.
9460         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9461         (expand_symtab_containing_pc, lookup_objfile_from_block)
9462         (lookup_static_symbol, basic_lookup_transparent_type)
9463         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9464         (find_line_symtab, info_sources_command)
9465         (default_collect_symbol_completion_matches_break_on)
9466         (make_source_files_completion_list, find_main_name): Update.
9467         * symmisc.c (print_symbol_bcache_statistics)
9468         (print_objfile_statistics, maintenance_print_symbols)
9469         (maintenance_print_msymbols, maintenance_print_objfiles)
9470         (maintenance_info_symtabs, maintenance_check_symtabs)
9471         (maintenance_expand_symtabs, maintenance_info_line_tables):
9472         Update.
9473         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9474         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9475         (map_overlay_command, unmap_overlay_command)
9476         (simple_overlay_update, expand_symtabs_matching)
9477         (map_symbol_filenames): Update.
9478         * symfile-debug.c (set_debug_symfile): Update.
9479         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9480         Update.
9481         * source.c (select_source_symtab, forget_cached_source_info):
9482         Update.
9483         * solib.c (solib_read_symbols): Update.
9484         * solib-spu.c (append_ocl_sos): Update.
9485         * psymtab.c (maintenance_print_psymbols)
9486         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9487         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9488         * printcmd.c (info_symbol_command): Update.
9489         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9490         Update.
9491         * objfiles.h (class all_objfiles): Remove.
9492         * objfiles.c (have_partial_symbols, have_full_symbols)
9493         (have_minimal_symbols, qsort_cmp, update_section_map)
9494         (shared_objfile_contains_address_p)
9495         (default_iterate_over_objfiles_in_search_order): Update.
9496         * objc-lang.c (info_selectors_command, info_classes_command)
9497         (find_methods): Update.
9498         * minsyms.c (find_solib_trampoline_target): Update.
9499         * maint.c (maintenance_info_sections)
9500         (maintenance_translate_address, count_symtabs_and_blocks):
9501         Update.
9502         * main.c (captured_main_1): Update.
9503         * linux-thread-db.c (try_thread_db_load_from_pdir)
9504         (has_libpthread): Update.
9505         * linespec.c (iterate_over_all_matching_symtabs)
9506         (search_minsyms_for_name): Update.
9507         * jit.c (jit_find_objf_with_entry_addr): Update.
9508         * hppa-tdep.c (find_unwind_entry)
9509         (hppa_lookup_stub_minimal_symbol): Update.
9510         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9511         Update.
9512         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9513         (elf_gnu_ifunc_resolve_by_got): Update.
9514         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9515         * dwarf-index-write.c (save_gdb_index_command): Update.
9516         * cp-support.c (add_symbol_overload_list_qualified): Update.
9517         * breakpoint.c (create_overlay_event_breakpoint)
9518         (create_longjmp_master_breakpoint)
9519         (create_std_terminate_master_breakpoint)
9520         (create_exception_master_breakpoint): Update.
9521         * blockframe.c (find_pc_partial_function): Update.
9522         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9523         (ada_collect_symbol_completion_matches)
9524         (ada_add_global_exceptions): Update.
9525
9526 2019-01-17  Tom Tromey  <tom@tromey.com>
9527
9528         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9529         declare VEC.
9530         (solib_target_parse_libraries): Change return type.
9531         (library_list_start_segment, library_list_start_section)
9532         (library_list_end_library, library_list_start_library); Update.
9533         (solib_target_free_library_list): Remove.
9534         (solib_target_parse_libraries): Remove cleanup.  Change return
9535         type.
9536         (solib_target_current_sos): Update.
9537
9538 2019-01-17  Tom Tromey  <tromey@bapiya>
9539
9540         * valprint.c: Replace "the the" with "the".
9541         * symtab.c: Replace "the the" with "the".
9542         * solib.c: Replace "the the" with "the".
9543         * solib-dsbt.c: Replace "the the" with "the".
9544         * linespec.c: Replace "the the" with "the".
9545         * dwarf2loc.h: Replace "the the" with "the".
9546         * amd64-windows-tdep.c: Replace "the the" with "the".
9547         * aarch64-tdep.c: Replace "the the" with "the".
9548
9549 2019-01-16  Keith Seitz  <keiths@redhat.com>
9550
9551         PR gdb/23773
9552         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9553         <builder>: Rename to ..
9554         <m_builder>: ... this and make private.
9555         (dwarf2_cu::get_builder): New method.  Change all users of
9556         `builder' to use this method.
9557         (dwarf2_start_symtab): Move to ...
9558         (dwarf2_cu::start_symtab): ... here.  Update all callers
9559         (setup_type_unit_groups): Move to ...
9560         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9561         callers.
9562         (dwarf2_cu::reset_builder): New method.
9563         (process_full_compunit, process_full_type_unit): Use
9564         dwarf2_cu::reset_builder.
9565         (follow_die_offset): Record the ancestor CU if it is different
9566         from the followed DIE's CU.
9567         (follow_die_sig_1): Likewise.
9568
9569 2019-01-15  Tom Tromey  <tom@tromey.com>
9570
9571         * remote.c (class remote_state) <buf>: Now a char_vector.
9572         <buf_size>: Remove.
9573         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9574         parameter.
9575         (remote_target::getpkt_or_notif_sane_1)
9576         (remote_target::getpkt_sane)
9577         (remote_target::getpkt_or_notif_sane): Likewise.
9578         (class remote_target) <putpkt>: New overload.
9579         (remote_target::read_frame): Change type of "buf_p".  Remove
9580         sizeof_p parameter.
9581         (packet_ok): New overload.
9582         (packet_check_result): New overload.
9583         Update all uses.
9584
9585 2019-01-14  Tom Tromey  <tom@tromey.com>
9586
9587         * remote-notif.c (handle_notification, remote_notif_ack)
9588         (remote_notif_parse): Make "buf" const.
9589         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9590         const.
9591         (remote_notif_parse, remote_notif_ack, handle_notification):
9592         Likewise.
9593         * remote.c (remote_notif_stop_parse): Make "buf" const.
9594         (remote_target::remote_parse_stop_reply): Make "buf" const.
9595         (remote_notif_stop_ack): Make "buf" const.
9596
9597 2019-01-14  Tom Tromey  <tom@tromey.com>
9598
9599         * remote.c (remote_console_output): Make parameter const.
9600
9601 2019-01-14  Tom Tromey  <tom@tromey.com>
9602
9603         * target-debug.h (target_debug_print_signals): Constify.
9604         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9605         * procfs.c (procfs_target::pass_signals): Update.
9606         * linux-nat.c (linux_nat_target::pass_signals): Update.
9607         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9608         * target-delegates.c: Rebuild.
9609         * remote.c (remote_target::program_signals): Update.
9610         (remote_target::pass_signals): Update.
9611         * target.c (target_pass_signals): Constify argument.
9612         (target_program_signals): Likewise.
9613         * target.h (struct target_ops) <pass_signals, program_signals>:
9614         Constify argument.
9615         (target_pass_signals, target_program_signals): Constify argument.
9616
9617 2019-01-14  Tom Tromey  <tom@tromey.com>
9618
9619         PR tui/28819:
9620         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9621
9622 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9623
9624         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9625         field.
9626         * rs6000-tdep.c: Include reggroups.h.
9627         (IS_V_ALIAS_PSEUDOREG): Define.
9628         (rs6000_register_name): Return names for the "vX" aliases.
9629         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9630         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9631         aliases.  Call default_register_reggroup_p for all other
9632         pseudo-registers.
9633         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9634         New functions.
9635         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9636         Handle "vX" aliases.
9637         (v_alias_pseudo_register_collect): New function.
9638         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9639         (rs6000_gdbarch_init): Initialize "vX" aliases as
9640         pseudo-registers.  Restore registration of
9641         rs6000_pseudo_register_reggroup_p with
9642         set_tdesc_pseudo_register_reggroup_p.
9643
9644 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9645
9646         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9647         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9648         set_gdbarch_num_pseudo_regs.
9649
9650 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9651
9652         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9653         Remove arg prefixname, add do_set and do_show.
9654         Add member functions set_list and show_list.
9655         * cli/cli-style.c (class cli_style_option): Update accordingly.
9656         (style_set_list): Move to file scope.
9657         (style_show_list): Likewise.
9658         (set_style): Call help_list.
9659         (show_style): Call cmd_show_list.
9660         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9661         Update to use the new macro.
9662
9663 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9664
9665         * ada-lang.c (_initialize_ada_language): Expand the help text
9666         for the "catch exception" command.
9667
9668 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9669
9670         * symtab.c (matching_obj_sections): Initialize obj,
9671         declare it closer to its usage.
9672
9673 2019-01-10  Tom Tromey  <tom@tromey.com>
9674
9675         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9676         (basic_inf_threads_range): Remove.
9677         (inf_threads_range, inf_non_exited_threads_range)
9678         (safe_inf_threads_range): Use next_adapter.
9679
9680 2019-01-10  Keith Seitz  <keiths@redhat.com>
9681
9682         PR gdb/23712
9683         PR symtab/23010
9684         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9685         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9686
9687 2019-01-10  Keith Seitz  <keiths@redhat.com>
9688
9689         PR gdb/23712
9690         PR symtab/23010
9691         * dictionary.c (pending_to_vector): Remove.
9692         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9693         Remove _1 suffix, replacing functions of the same name.  Update
9694         all callers.
9695         (dict_create_hashed, dict_create_hashed_expandable)
9696         (dict_create_linear, dict_create_linear_expandable, dict_free)
9697         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9698         Make functions static.
9699
9700 2019-01-10  Keith Seitz  <keiths@redhat.com>
9701
9702         PR gdb/23712
9703         PR symtab/23010
9704         * dictionary.h (struct dictionary): Replace declaration with
9705         multidictionary.
9706         (dict_create_hashed, dict_create_hashed_expandable)
9707         (dict_create_linear, dict_create_linear_expandable)
9708         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9709         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9710         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9711         taking multidictionary argument.
9712         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9713         * block.h (struct block) <dict>: Change to multidictionary
9714         and rename `multidict'.
9715         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9716         symmisc.c: Update all dictionary references to multidictionary.
9717
9718 2019-01-10  Keith Seitz  <keiths@redhat.com>
9719
9720         PR gdb/23712
9721         PR symtab/23010
9722         * dictionary.c: Include unordered_map.
9723         (pending_to_vector): New function.
9724         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9725         Rewrite the non-"_1" functions to take vector instead
9726         of linked list.
9727         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9728         "new" _1 versions of the same name.
9729         (multidictionary): Define.
9730         (std::hash<enum language): New definition.
9731         (collate_pending_symbols_by_language, mdict_create_hashed)
9732         (mdict_create_hashed_expandable, mdict_create_linear)
9733         (mdict_create_linear_expandable, mdict_free)
9734         (find_language_dictionary, create_new_language_dictionary)
9735         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9736         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9737         (mdict_size, mdict_empty): New functions.
9738         * dictionary.h (mdict_iterator): Define.
9739
9740 2019-01-10  Pedro Alves  <palves@redhat.com>
9741
9742         * breakpoint.c (read_uploaded_action)
9743         (create_tracepoint_from_upload): Adjust to use
9744         gdb::unique_xmalloc_ptr.
9745         * ctf.c (ctf_write_uploaded_tp):
9746         (SET_ARRAY_FIELD): Use emplace_back.
9747         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9748         * tracefile-tfile.c (tfile_write_uploaded_tp):
9749         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9750         gdb::unique_xmalloc_ptr.
9751         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9752         at_string, cond_string, cmd_strings>: Replace char pointers
9753         with gdb::unique_xmalloc_ptr.
9754
9755 2019-01-10  Pedro Alves  <palves@redhat.com>
9756
9757         * solib-target.c (library_list_start_library): Don't xstrdup name.
9758
9759 2019-01-10  Pedro Alves  <palves@redhat.com>
9760
9761         * mdebugread.c (parse_partial_symbols): Use
9762         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9763
9764 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9765
9766         * linux-fork.c (scoped_switch_fork_info)
9767         <~scoped_switch_fork_info>: Fix incorrect variable name.
9768
9769 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9770
9771         * linux-fork.c (scoped_switch_fork_info)
9772         <scoped_switch_fork_info>: Make explicit.
9773         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9774
9775 2019-01-10  Tom Tromey  <tom@tromey.com>
9776
9777         * objfiles.h (objfile::reset_psymtabs): Update.
9778         * objfiles.c (objfile::objfile): Update.
9779         * psymtab.h (psymtab_storage::obstack): Update.
9780         (psymtab_storage::m_obstack): Use gdb::optional.
9781         (class psymtab_storage): Update comment.  Remove objfile
9782         parameter.
9783         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9784
9785 2019-01-10  Tom Tromey  <tom@tromey.com>
9786
9787         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9788         <free_psymtabs>: Now private.
9789         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9790         (allocate_psymtab): Use new method.
9791
9792 2019-01-10  Tom Tromey  <tom@tromey.com>
9793
9794         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9795         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9796         * mdebugread.c (parse_partial_symbols): Use
9797         allocate_dependencies.
9798         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9799         allocate_dependencies.
9800         (process_psymtab_comp_unit_reader)
9801         (build_type_psymtab_dependencies): Likewise.
9802         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9803
9804 2019-01-10  Tom Tromey  <tom@tromey.com>
9805
9806         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9807         PSYMBOL_SET_LANGUAGE.
9808         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9809
9810 2019-01-10  Tom Tromey  <tom@tromey.com>
9811
9812         * psymtab.h (psymtab_storage::obstack): New method.
9813         <m_obstack>: Rename from obstack; now private.
9814         * psymtab.c (psymtab_storage): Update.
9815         * dwarf2read.c (create_addrmap_from_index)
9816         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9817         Update.
9818
9819 2019-01-10  Tom Tromey  <tom@tromey.com>
9820
9821         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9822         * objfiles.h (objfile::reset_psymtabs): New method.
9823
9824 2019-01-10  Tom Tromey  <tom@tromey.com>
9825
9826         * symmisc.c (print_symbol_bcache_statistics): Update.
9827         (print_objfile_statistics): Update.
9828         * symfile.c (reread_symbols): Update.
9829         * psymtab.h (class psymtab_storage): New.
9830         * psymtab.c (psymtab_storage): New constructor.
9831         (~psymtab_storage): New destructor.
9832         (require_partial_symbols): Update.
9833         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9834         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9835         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9836         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9837         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9838         (start_psymtab_common, end_psymtab_common)
9839         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9840         (allocate_psymtab): Update.
9841         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9842         Update.
9843         (dump_psymtab_addrmap, maintenance_print_psymbols)
9844         (maintenance_check_psymtabs): Update.
9845         (class objfile_psymtabs): Move to objfiles.h.
9846         * psympriv.h (discard_psymtab): Now inline.
9847         (psymtab_discarder::psymtab_discarder): Update.
9848         (psymtab_discarder::~psymtab_discarder): Update.
9849         (ALL_OBJFILE_PSYMTABS): Rewrite.
9850         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9851         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9852         Remove fields.
9853         <partial_symtabs>: New field.
9854         (class objfile_psymtabs): Move from psymtab.h.  Update.
9855         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9856         psymbol_cache.
9857         (objfile::~objfile): Don't destroy psymbol_cache.
9858         * mdebugread.c (parse_partial_symbols): Update.
9859         * dwarf2read.c (create_addrmap_from_index)
9860         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9861         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9862         (add_partial_subprogram, dwarf2_ranges_read): Update.
9863         * dwarf-index-write.c (write_address_map)
9864         (write_one_signatured_type, recursively_write_psymbols)
9865         (class debug_names, class debug_names, write_psymtabs_to_index):
9866         Update.
9867
9868 2019-01-10  Tom Tromey  <tom@tromey.com>
9869
9870         * symtab.h (SYMBOL_SET_NAMES): Update.
9871         (symbol_set_names): Update.
9872         (MSYMBOL_SET_NAMES): Update.
9873         * symtab.c (symbol_set_names): Change argument to be an
9874         objfile_per_bfd_storage.
9875         * psymtab.c (add_psymbol_to_bcache): Update.
9876         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9877
9878 2019-01-10  Tom Tromey  <tom@tromey.com>
9879
9880         * symtab.c (create_demangled_names_hash): Change argument to be an
9881         objfile_per_bfd_storage.
9882         (symbol_set_names): Update.
9883
9884 2019-01-10  Tom Tromey  <tom@tromey.com>
9885
9886         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9887         init_psymbol_list.
9888         * psymtab.c (init_psymbol_list): Do nothing if already called.
9889         * psympriv.h (init_psymbol_list): Add comment.
9890         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9891         init_psymbol_list.
9892         * dbxread.c (dbx_symfile_read): Unconditionally call
9893         init_psymbol_list.
9894
9895 2019-01-10  Tom Tromey  <tom@tromey.com>
9896
9897         * xcoffread.c (scan_xcoff_symtab): Update.
9898         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9899         "where".
9900         * mdebugread.c (parse_partial_symbols)
9901         (handle_psymbol_enumerators): Update.
9902         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9903         * dbxread.c (read_dbx_symtab): Update.
9904         * psympriv.h (psymbol_placement): New enum.
9905         (add_psymbol_to_list): Update.
9906
9907 2019-01-10  Tom Tromey  <tom@tromey.com>
9908
9909         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9910         static_psymbols parameters.
9911         (scan_xcoff_symtab): Update.
9912         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9913         static_psymbols parameters.
9914         * psympriv.h (start_psymtab_common): Update.
9915         * mdebugread.c (parse_partial_symbols): Update.
9916         * dwarf2read.c (create_partial_symtab): Update.
9917         * dbxread.c (read_dbx_symtab): Update.
9918         (start_psymtab): Remove global_psymbols and static_psymbols
9919         parameters.
9920
9921 2019-01-10  Tom Tromey  <tom@tromey.com>
9922
9923         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9924         * psymtab.c (allocate_psymtab): Add comment.
9925         * psympriv.h (allocate_psymtab): Add comment.
9926         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9927         initializations.
9928         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9929
9930 2019-01-10  Tom Tromey  <tom@tromey.com>
9931
9932         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9933         Don't declare.
9934         * mipsread.c: Include mdebugread.h.
9935         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9936         Declare.
9937         * elfread.c: Include mdebugread.h.
9938
9939 2019-01-09  Tom Tromey  <tom@tromey.com>
9940
9941         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9942         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9943         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9944         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9945         (psym_lookup_symbol, psym_find_last_source_symtab)
9946         (psym_forget_cached_source_info, psym_print_stats)
9947         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9948         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9949         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9950         (psym_find_compunit_symtab_by_address)
9951         (maintenance_print_psymbols, maintenance_info_psymtabs)
9952         (maintenance_check_psymtabs): Use ranged for.
9953         * psymtab.h (class objfile_psymtabs): New.
9954         (require_partial_symbols): Return objfile_psymtabs.
9955         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9956
9957 2019-01-09  Tom Tromey  <tom@tromey.com>
9958
9959         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9960         (find_pc_mapped_section, list_overlays_command)
9961         (map_overlay_command, unmap_overlay_command)
9962         (simple_overlay_update): Use all_objfiles.
9963         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9964         * printcmd.c (info_symbol_command): Use all_objfiles.
9965         * objfiles.h (ALL_OBJSECTIONS): Remove.
9966         * maint.c (maintenance_translate_address): Use all_objfiles.
9967         * gcore.c (gcore_create_callback): Use all_objfiles.
9968         (objfile_find_memory_regions): Likewise.
9969
9970 2019-01-09  Tom Tromey  <tom@tromey.com>
9971
9972         * symtab.c (find_line_symtab, info_sources_command)
9973         (make_source_files_completion_list): Use objfile_compunits.
9974         * source.c (select_source_symtab): Use objfile_compunits.
9975         * objfiles.h (struct objfile): Update comment.
9976         (ALL_OBJFILES): Remove.
9977         (ALL_FILETABS): Remove.
9978         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9979         objfile_compunits.
9980
9981 2019-01-09  Tom Tromey  <tom@tromey.com>
9982
9983         * symmisc.c (print_objfile_statistics, dump_objfile)
9984         (maintenance_print_symbols): Use compunit_filetabs.
9985         * source.c (forget_cached_source_info_for_objfile): Use
9986         compunit_filetabs.
9987         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9988         (ALL_FILETABS): Use compunit_filetabs.
9989         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9990         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9991
9992 2019-01-09  Tom Tromey  <tom@tromey.com>
9993
9994         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9995         (compunit_filetabs): New.
9996         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9997         compunit_filetabs.
9998         (info_sources_command, make_source_files_completion_list): Remove
9999         declaration.
10000         * symmisc.c (print_objfile_statistics, dump_objfile)
10001         (maintenance_print_symbols): Remove declaration.
10002         (maintenance_info_symtabs): Use compunit_filetabs.
10003         (maintenance_info_line_tables): Likewise.
10004         * source.c (select_source_symtab): Change local variable name.
10005         (forget_cached_source_info_for_objfile): Remove declaration.
10006         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10007         * objfiles.c (objfile_relocate1): Remove declaration.
10008         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10009         declaration.
10010         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10011         * coffread.c (coff_symtab_read): Remove declaration.
10012         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10013         compunit_filetabs.
10014
10015 2019-01-09  Tom Tromey  <tom@tromey.com>
10016
10017         * symtab.c (lookup_objfile_from_block)
10018         (find_pc_sect_compunit_symtab, search_symbols)
10019         (default_collect_symbol_completion_matches_break_on): Use
10020         objfile_compunits.
10021         * objfiles.h (ALL_COMPUNITS): Remove.
10022         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10023         * cp-support.c (add_symbol_overload_list_qualified): Use
10024         objfile_compunits.
10025         * ada-lang.c (ada_collect_symbol_completion_matches)
10026         (ada_add_global_exceptions): Use objfile_compunits.
10027
10028 2019-01-09  Tom Tromey  <tom@tromey.com>
10029
10030         * source.c (select_source_symtab)
10031         (forget_cached_source_info_for_objfile): Remove declaration.
10032         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10033         declaration.
10034         * maint.c (count_symtabs_and_blocks): Remove declaration.
10035         * cp-support.c (add_symbol_overload_list_qualified): Remove
10036         declaration.
10037         * coffread.c (coff_symtab_read): Remove declaration.
10038         * symtab.c (lookup_symbol_in_objfile_symtabs)
10039         (basic_lookup_transparent_type_1): Use objfile_compunits.
10040         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10041         (info_sources_command, search_symbols)
10042         (default_collect_symbol_completion_matches_break_on)
10043         (make_source_files_completion_list): Remove declaration.
10044         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10045         (ada_collect_symbol_completion_matches)
10046         (ada_add_global_exceptions): Remove declaration.
10047         * linespec.c (iterate_over_all_matching_symtabs): Use
10048         objfile_compunits.
10049         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10050         (class objfile_compunits): New.
10051         (ALL_COMPUNITS): Use objfile_compunits.
10052         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10053         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10054         objfile_compunits.
10055         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10056
10057 2019-01-09  Tom Tromey  <tom@tromey.com>
10058
10059         * symtab.c (search_symbols)
10060         (default_collect_symbol_completion_matches_break_on): Use
10061         objfile_msymbols.
10062         * ada-lang.c (ada_lookup_simple_minsym)
10063         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10064         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10065         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10066         objfile_msymbols.
10067         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10068         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10069         * objc-lang.c (find_methods): Use objfile_msymbols.
10070         (info_selectors_command, info_classes_command): Likewise.
10071         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10072         * objfiles.h (class objfile_msymbols): New.
10073         (ALL_OBJFILE_MSYMBOLS): Remove.
10074         (ALL_MSYMBOLS): Remove.
10075
10076 2019-01-09  Tom Tromey  <tom@tromey.com>
10077
10078         * common/next-iterator.h (next_adapter): Add Iterator template
10079         parameter.
10080         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10081         (class all_objfiles_safe): New.
10082         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10083         * objfiles.c (put_objfile_before): Update comment.
10084         (add_separate_debug_objfile): Likewise.
10085         (free_all_objfiles): Use all_objfiles_safe.
10086         (objfile_purge_solibs): Likewise.
10087
10088 2019-01-09  Tom Tromey  <tom@tromey.com>
10089
10090         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10091         (expand_symtab_containing_pc, lookup_static_symbol)
10092         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10093         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10094         all_objfiles.
10095         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10096         * breakpoint.c (create_overlay_event_breakpoint)
10097         (create_longjmp_master_breakpoint)
10098         (create_std_terminate_master_breakpoint)
10099         (create_exception_master_breakpoint): Use all_objfiles.
10100         * linux-thread-db.c (try_thread_db_load_from_pdir)
10101         (has_libpthread): Use all_objfiles.
10102         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10103         * linespec.c (iterate_over_all_matching_symtabs)
10104         (search_minsyms_for_name): Use all_objfiles.
10105         * maint.c (maintenance_info_sections): Use all_objfiles.
10106         * main.c (captured_main_1): Use all_objfiles.
10107         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10108         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10109         * guile/scm-pretty-print.c
10110         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10111         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10112         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10113         (maintenance_print_msymbols): Use all_objfiles.
10114         * source.c (select_source_symtab): Use all_objfiles.
10115         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10116         * symfile.c (remove_symbol_file_command)
10117         (expand_symtabs_matching, map_symbol_filenames): Use
10118         all_objfiles.
10119         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10120         all_objfiles.
10121         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10122         * objc-lang.c (find_methods): Use all_objfiles.
10123         * objfiles.c (have_partial_symbols, have_full_symbols)
10124         (have_minimal_symbols, qsort_cmp)
10125         (default_iterate_over_objfiles_in_search_order): Use
10126         all_objfiles.
10127         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10128         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10129         (maintenance_check_psymtabs): Use all_objfiles.
10130         (ALL_PSYMTABS): Remove.
10131         * compile/compile-object-run.c (do_module_cleanup): Use
10132         all_objfiles.
10133         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10134         * cp-support.c (add_symbol_overload_list_qualified): Use
10135         all_objfiles.
10136         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10137         Use all_objfiles.
10138         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10139         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10140         all_objfiles.
10141         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10142         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10143         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10144         Uses all_objfiles.
10145         * solib.c (solib_read_symbols): Use all_objfiles
10146
10147 2019-01-09  Tom Tromey  <tom@tromey.com>
10148
10149         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10150         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10151         all_objfiles.
10152         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10153         * symmisc.c (print_symbol_bcache_statistics)
10154         (print_objfile_statistics, maintenance_print_objfiles)
10155         (maintenance_info_symtabs, maintenance_check_symtabs)
10156         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10157         all_objfiles.
10158         * source.c (forget_cached_source_info): Use all_objfiles.
10159         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10160         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10161         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10162         * objfiles.c (update_section_map): Use all_objfiles.
10163         (shared_objfile_contains_address_p): Likewise.
10164         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10165         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10166
10167 2019-01-09  Tom Tromey  <tom@tromey.com>
10168
10169         * common/next-iterator.h: New file.
10170         * objfiles.h (class all_objfiles): New.
10171         (struct objfile_iterator): New.
10172
10173 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10174
10175         * NEWS: Move the description of the changed "frame", "select-frame",
10176          and "info frame" commands to the Changed commands section.
10177
10178 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10179
10180         * gdbtypes.c (check_stub_method_group): Remove handling of old
10181         mangling schemes.
10182         * linespec.c (find_methods): Likewise.
10183         * stabsread.c (read_member_functions): Likewise.
10184         * valops.c (search_struct_method): Likewise.
10185         (value_struct_elt_for_reference): Likewise.
10186         * NEWS: Mention this change.
10187
10188 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10189
10190         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10191         print_source_lines.
10192         * source.c (print_source_lines_base): Update line number check.
10193         (print_source_lines): New function.
10194         (source_lines_range::source_lines_range): New function.
10195         * source.h (class source_lines_range): New class.
10196         (print_source_lines): New declaration.
10197
10198 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10199
10200         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10201
10202 2019-01-08  Tom Tromey  <tom@tromey.com>
10203             Simon Marchi  <simon.marchi@ericsson.com>
10204
10205         PR gdb/24060
10206         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10207         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10208         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10209         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10210         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10211         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10212
10213 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10214
10215         * source.c (select_source_symtab): Move header comment to
10216         declaration in source.h.
10217         (forget_cached_source_info_for_objfile): Likewise.
10218         (forget_cached_source_info): Likewise.
10219         (identify_source_line): Likewise.
10220         * source.h (identify_source_line): Move declaration from symtab.h
10221         and add comment from source.c
10222         (print_source_lines): Likewise.
10223         (forget_cached_source_info_for_objfile): Likewise.
10224         (forget_cached_source_info): Likewise.
10225         (select_source_symtab): Likewise.
10226         (enum print_source_lines_flag): Move definition from symtab.h.
10227         * symtab.h (identify_source_line): Move declaration to source.h.
10228         (print_source_lines): Likewise.
10229         (forget_cached_source_info_for_objfile): Likewise.
10230         (forget_cached_source_info): Likewise.
10231         (select_source_symtab): Likewise.
10232         (enum print_source_lines_flag): Move definition to source.h.
10233         * tui/tui-hooks.c: Add 'source.h' include.
10234
10235 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10236
10237         * source.c (print_source_lines_base): Handle requests to print
10238         reverse line number sequences, and guard against empty lines
10239         string.
10240
10241 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10242
10243         * source.c (print_source_lines_base): Fix skip of '\r' if next
10244         character is '\n'.
10245
10246 2019-01-06  Tom Tromey  <tom@tromey.com>
10247
10248         * c-exp.y (struct c_parse_state) <macro_original_text,
10249         expansion_obstack>: New member.
10250         (macro_original_text, expansion_obstack): Remove globals.
10251         (scan_macro_expansion, scanning_macro_expansion)
10252         (finished_macro_expansion): Update.
10253         (scan_macro_cleanup): Remove.
10254         (yylex, c_parse): Update.
10255
10256 2019-01-06  Tom Tromey  <tom@tromey.com>
10257
10258         * c-exp.y (struct c_parse_state) <strings>: New member.
10259         (operator_stoken): Update.
10260
10261 2019-01-06  Tom Tromey  <tom@tromey.com>
10262
10263         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10264         (union type_stack_elt) <typelist_val>: Now a pointer to
10265         std::vector.
10266         (type_stack_cleanup): Don't declare.
10267         (push_typelist): Update.
10268         * parse.c (pop_typelist): Return a std::vector.
10269         (push_typelist): Take a std::vector.
10270         (follow_types): Update.  Do not free args.
10271         (type_stack_cleanup): Remove.
10272         * c-exp.y (struct c_parse_state): New.
10273         (cpstate): New global.
10274         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10275         (nonempty_typelist): Update.
10276         (func_mod): Create a new vector.
10277         (c_parse): Create a c_parse_state.
10278         (check_parameter_typelist): Do not delete params.
10279         (function_method): Update.  Do not delete type_list.
10280
10281 2019-01-06  Tom Tromey  <tom@tromey.com>
10282
10283         PR gdb/28155:
10284         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10285         check_typedef.
10286         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10287         (print_return_value): Likewise.
10288
10289 2019-01-05  Tom Tromey  <tom@tromey.com>
10290
10291         * contrib/cleanup_check.py: Remove.
10292         * contrib/gcc-with-excheck: Remove.
10293         * contrib/exsummary.py: Remove.
10294         * contrib/excheck.py: Remove.
10295
10296 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10297
10298         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10299         NULL. Initialize tpprev to NULL instead of assigning it
10300         to NULL on the next statement.
10301         * windows-nat.c (windows_delete_thread): Remove check for
10302         main_thread_id before printing thread exit notifications.
10303         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10304         Remove thread ID check against main_thread_id.
10305         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10306         windows_delete_thread.
10307         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10308
10309 2019-01-04  Tom Tromey  <tom@tromey.com>
10310
10311         * compile/compile.c (_initialize_compile): Use upper case for
10312         metasyntactic variables.
10313         * symmisc.c (_initialize_symmisc): Use upper case for
10314         metasyntactic variables.
10315         * psymtab.c (_initialize_psymtab): Use upper case for
10316         metasyntactic variables.
10317         * demangle.c (demangle_command): Use upper case for metasyntactic
10318         variables.
10319         (_initialize_demangler): Likewise.
10320         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10321         variables.
10322
10323 2019-01-03  Tom Tromey  <tom@tromey.com>
10324
10325         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10326
10327 2019-01-03  Tom Tromey  <tom@tromey.com>
10328
10329         * python/py-symtab.c (salpy_str): Update.
10330         (struct salpy_sal_object) <symtab>: Now a PyObject.
10331         (salpy_dealloc): Update.
10332         (del_objfile_sal): Use gdbpy_ref.
10333
10334 2019-01-03  Tom Tromey  <tom@tromey.com>
10335
10336         * python/py-type.c (convert_field): Use new_reference.  Return
10337         gdbpy_ref.
10338         (make_fielditem): Return gdbpy_ref.
10339         (typy_fields): Update.
10340         (typy_getitem): Update.
10341         (field_name): Return gdbpy_ref.  Use new_reference.
10342         (typy_iterator_iternext): Update.
10343
10344 2019-01-03  Tom Tromey  <tom@tromey.com>
10345
10346         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10347
10348 2019-01-03  Tom Tromey  <tom@tromey.com>
10349
10350         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10351         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10352         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10353         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10354         (pspy_set_type_printers): Likewise.
10355         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10356         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10357         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10358         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10359         (objfpy_set_type_printers): Likewise.
10360
10361 2019-01-03  Tom Tromey  <tom@tromey.com>
10362
10363         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10364         (gdbpy_print_stack): Use gdbpy_err_fetch.
10365         * python/python-internal.h (class gdbpy_err_fetch): New class.
10366         (class gdbpy_enter) <m_error_type, m_error_value,
10367         m_error_traceback>: Remove.
10368         <m_error>: New member.
10369         (gdbpy_exception_to_string): Don't declare.
10370         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10371         * python/py-value.c (convert_value_from_python): Use
10372         gdbpy_err_fetch.
10373         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10374         gdbpy_exception_to_string.
10375         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10376         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10377         gdbpy_err_fetch.
10378
10379 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10380
10381         * linux-nat.c (delete_lwp_cleanup): Delete.
10382         (struct lwp_deleter): New struct.
10383         (lwp_info_up): New typedef.
10384         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10385         lwp_info_up.
10386
10387 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10388
10389         * linux-fork.c (class scoped_switch_fork_info): New class.
10390         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10391
10392 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10393
10394         * valops.c (find_overload_match): Remove use of null_cleanup, and
10395         calls to do_cleanups.
10396
10397 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10398
10399         * compile/compile-cplus-types.c
10400         (compile_cplus_instance::decl_name): Handle changes to
10401         cp_func_name.
10402         * cp-support.c (cp_func_name): Update header comment, update
10403         return type.
10404         * cp-support.h (cp_func_name): Update return type in declaration.
10405         * valops.c (find_overload_match): Move temp_func local to top
10406         level of function and change its type.  Use temp_func to hold and
10407         delete temporary string obtained from cp_func_name.
10408
10409 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10410
10411         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10412         gdb::char_vector, remove cleanup, and update uses of `msg`.
10413
10414 2019-01-03  Jim Wilson  <jimw@sifive.com>
10415
10416         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10417
10418 2019-01-02  Tom Tromey  <tom@tromey.com>
10419
10420         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10421         (tdesc_parse_xml): Remove cleanups.
10422         * target-descriptions.h (make_cleanup_free_target_description):
10423         Don't declare.
10424         (target_desc_deleter): New struct.
10425         (target_desc_up): New typedef.
10426         * target-descriptions.c (target_desc_deleter::operator()): Rename
10427         from free_target_description.
10428         (make_cleanup_free_target_description): Remove.
10429
10430 2019-01-02  Tom Tromey  <tom@tromey.com>
10431
10432         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10433         constructor, destructor.
10434         (linespec_parser): Remove typedef.
10435         (~linespec_parser): Rename from linespec_parser_delete.
10436         (linespec_lex_to_end, linespec_complete_label)
10437         (linespec_complete): Update.
10438         (decode_line_full): Remove cleanups.
10439         (decode_line_1): Update.
10440
10441 2019-01-02  Tom Tromey  <tom@tromey.com>
10442
10443         * python/python-internal.h (inferior_to_inferior_object): Change
10444         return type.
10445         * python/py-exitedevent.c (create_exited_event_object): Update.
10446         * python/py-inferior.c (inferior_to_inferior_object): Return
10447         gdbpy_ref.
10448         (python_new_inferior, python_inferior_deleted)
10449         (thread_to_thread_object, delete_thread_object)
10450         (build_inferior_list, gdbpy_selected_inferior): Update.
10451         * python/py-infthread.c (create_thread_object): Update.  Also fail
10452         if inferior_to_inferior_object fails.
10453
10454 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10455
10456         * inferior.h (class inferior) <displaced_step_state>: New field.
10457         * infrun.h (struct displaced_step_state): Move here from
10458         infrun.c.  Initialize fields, add constructor.
10459         <inf>: Remove field.
10460         <reset>: New method.
10461         * infrun.c (struct displaced_step_inferior_state): Move to
10462         infrun.h.
10463         (displaced_step_inferior_states): Remove.
10464         (get_displaced_stepping_state): Adust.
10465         (displaced_step_in_progress_any_inferior): Adjust.
10466         (displaced_step_in_progress_thread): Adjust.
10467         (displaced_step_in_progress): Adjust.
10468         (add_displaced_stepping_state): Remove.
10469         (get_displaced_step_closure_by_addr): Adjust.
10470         (remove_displaced_stepping_state): Remove.
10471         (infrun_inferior_exit): Call displaced_step_state.reset.
10472         (use_displaced_stepping): Don't check for NULL.
10473         (displaced_step_prepare_throw): Call
10474         get_displaced_stepping_state.
10475         (displaced_step_fixup): Don't check for NULL.
10476         (prepare_for_detach): Don't check for NULL.
10477
10478 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10479
10480         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10481          in case of call that did not complete.
10482
10483 2019-01-02  Andrey Utkin  <autkin@undo.io>
10484
10485         * symfile.c (find_separate_debug_file): Fix search of debug files for
10486         remote debuggee.
10487
10488 2019-01-02  Tom Tromey  <tom@tromey.com>
10489
10490         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10491         indentation.
10492         * python/py-frame.c (frapy_older): Remove cast.
10493         (frapy_newer): Likewise.
10494         * python/py-breakpoint.c (local_setattro): Remove cast.
10495         * python/py-arch.c (archpy_name): Remove local variable.
10496         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10497
10498 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10499
10500         * unittests/basic_string_view/element_access/char/empty.cc:
10501         Fix year range in copyright header.
10502
10503 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10504
10505         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10506         Delete.
10507         <operator==>: Update with for removed field.
10508         <hash>: Likewise.
10509         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10510         <isa_features>: ...this.
10511         <abi_features>: New field.
10512         (riscv_isa_flen): Update comment.
10513         (riscv_abi_xlen): New declaration.
10514         (riscv_abi_flen): New declaration.
10515         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10516         isa_features.
10517         (riscv_abi_xlen): New function.
10518         (riscv_isa_flen): Update to get answer from isa_features.
10519         (riscv_abi_flen): New function.
10520         (riscv_has_fp_abi): Update to get answer from abi_features.
10521         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10522         xlen and flen.
10523         (riscv_call_info) <xlen, flen>: Update comment.
10524         (riscv_call_arg_struct): Remove invalid assertions
10525         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10526         is removed.
10527         (riscv_gdbarch_init): Gather isa features and abi features
10528         separately, ensure both match on the gdbarch when reusing an old
10529         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10530         a target with 64-bit float hardware.
10531
10532 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10533
10534         * source.c (search_command_helper): Stop reverse search
10535         when line 1 has been searched.
10536
10537 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10538
10539         * record-full.c (record_full_base_target::close): Rewrite
10540         record_full_core_buf_list free logic.
10541
10542 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10543
10544         * break-catch-syscall.c (print_one_catch_syscall): xfree
10545         the last text.
10546
10547 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10548
10549         * top.c (print_gdb_version): Update Copyright year in version
10550         message.
10551
10552 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10553
10554         Update copyright year range in all GDB files.
10555
10556 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10557
10558         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10559
10560 For older changes see ChangeLog-2018.
10561 \f
10562 Local Variables:
10563 mode: change-log
10564 left-margin: 8
10565 fill-column: 74
10566 version-control: never
10567 coding: utf-8
10568 End:
10569