gdb/ChangeLog

   1 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
   2
   3         * NEWS: Mention that the new default MI version is 3.  Mention
   4         changes to the output of commands and events that deal with
   5         multi-location breakpoints.
   6         * breakpoint.c: Include "mi/mi-out.h".
   7         (print_one_breakpoint): Change output syntax if using MI version
   8         >= 3.
   9         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
  10         New.
  11         (mi_multi_location_breakpoint_output_fixed): New.
  12         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
  13         (mi_cmd_fix_multi_location_breakpoint_output): New.
  14         (mi_multi_location_breakpoint_output_fixed): New.
  15         * mi/mi-cmds.c (mi_cmds): Register command
  16         -fix-multi-location-breakpoint-output.
  17         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
  18         interpreter "mi".
  19
  20 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
  21
  22         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
  23         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
  24         instantiate mi_ui_out based on interpreter name.
  25         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
  26         * mi/mi-main.c (mi_load_progress): Likewise.
  27
  28 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
  29
  30         * NEWS: Combine separate "New targets" sections for 8.3.
  31
  32 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
  33
  34         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
  35         (ppcfbsd_init_abi): Install gdbarch
  36         "fetch_tls_load_module_address" and "get_thread_local_address"
  37         methods.
  38
  39 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
  40
  41         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
  42         (riscv_fbsd_init_abi): Install gdbarch
  43         "fetch_tls_load_module_address" and "get_thread_local_address"
  44         methods.
  45
  46 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
  47
  48         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
  49         (i386fbsd_init_abi): Install gdbarch
  50         "fetch_tls_load_module_address" and "get_thread_local_address"
  51         methods.
  52
  53 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
  54
  55         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
  56         (amd64fbsd_init_abi): Install gdbarch
  57         "fetch_tls_load_module_address" and "get_thread_local_address"
  58         methods.
  59
  60 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
  61
  62         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
  63         (struct fbsd_pspace_data): New type.
  64         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
  65         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
  66         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
  67         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
  68         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
  69
  70 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
  71
  72         * gdbtypes.c (lookup_struct_elt): New function.
  73         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
  74         * gdbtypes.h (struct struct_elt): New type.
  75         (lookup_struct_elt): New prototype.
  76
  77 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
  78
  79         * gdbtypes.c (lookup_struct_elt_type): Update comment and
  80         remove disabled code block.
  81
  82 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
  83
  84         * gdbarch.sh (get_thread_local_address): New method.
  85         * gdbarch.h, gdbarch.c: Regenerate.
  86         * target.c (target_translate_tls_address): Use
  87         gdbarch_get_thread_local_address if present instead of
  88         target::get_thread_local_address.
  89
  90 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
  91
  92         * target.h (target::get_thread_local_address): Update comment.
  93
  94 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
  95
  96         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
  97         objfile->separate_debug_objfile_backlink if not NULL.
  98
  99 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 100
 101         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
 102         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
 103         (amd64bsd_store_inferior_registers): Likewise.
 104         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 105         Enable segment base registers.
 106         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
 107         PT_GETFSBASE and PT_GETGSBASE.
 108         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
 109         PT_SETGSBASE.
 110         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
 111         segment base registers.
 112         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 113
 114 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 115
 116         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 117         Update calls to i386_target_description to add 'segments'
 118         parameter.
 119         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
 120         add segment base registers.
 121         * arch/i386.c (i386_create_target_description): Add 'segments'
 122         parameter to enable segment base registers.
 123         * arch/i386.h (i386_create_target_description): Likewise.
 124         * features/i386/32bit-segments.xml: New file.
 125         * features/i386/32bit-segments.c: Generate.
 126         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
 127         call to i386_target_description to add 'segments' parameter.
 128         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 129         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
 130         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
 131         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
 132         if feature is present.
 133         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
 134         Add 'segments' parameter to call to i386_target_description.
 135         (i386_target_description): Add 'segments' parameter to enable
 136         segment base registers.
 137         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
 138         to call to i386_target_description.
 139         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
 140         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
 141         Define I386_NUM_REGS.
 142         (i386_target_description): Add 'segments' parameter to enable
 143         segment base registers.
 144
 145 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
 146
 147         PR/24325
 148         * source-cache.c: #undef open and close, to avoid unresolved
 149         externals during linking.
 150
 151 2019-03-12  Tom Tromey  <tromey@adacore.com>
 152
 153         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
 154         const.  Add initializers.
 155         (_initialize_remote): Don't initialize ptid globals.
 156
 157 2019-03-12  Pedro Alves  <palves@redhat.com>
 158
 159         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
 160
 161 2019-03-12  Pedro Alves  <palves@redhat.com>
 162
 163         * cp-name-parser.y (main): Remove unused 'len' variable.
 164
 165 2019-03-12  Tom Tromey  <tromey@adacore.com>
 166
 167         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
 168         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
 169
 170 2019-03-12  Tom Tromey  <tromey@adacore.com>
 171
 172         * linux-nat.c (iterate_over_lwps): Update.
 173         (stop_callback): Remove parameter.
 174         (stop_wait_callback, detach_callback, resume_set_callback)
 175         (select_singlestep_lwp_callback, set_ignore_sigint)
 176         (status_callback, resumed_callback, resume_clear_callback)
 177         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
 178         data parameter.
 179         (linux_nat_target::detach, linux_nat_target::resume)
 180         (linux_stop_and_wait_all_lwps, select_event_lwp)
 181         (linux_nat_filter_event, linux_nat_wait_1)
 182         (linux_nat_target::kill, linux_nat_target::stop)
 183         (linux_nat_target::stop): Update.
 184         (linux_nat_resume_callback): Change type.
 185         (resume_stopped_resumed_lwps, count_events_callback)
 186         (select_event_lwp_callback): Likewise.
 187         (linux_stop_lwp, linux_nat_stop_lwp): Update.
 188         * arm-linux-nat.c (struct update_registers_data): Remove.
 189         (update_registers_callback): Change type.
 190         (arm_linux_insert_hw_breakpoint1): Update.
 191         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
 192         parameter.
 193         (x86_linux_dr_set_addr): Update.
 194         (x86_linux_dr_set_control): Update.
 195         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
 196         (iterate_over_lwps): Use gdb::function_view.
 197         * nat/aarch64-linux-hw-point.c (struct
 198         aarch64_dr_update_callback_param): Remove.
 199         (debug_reg_change_callback): Change type.
 200         (aarch64_notify_debug_reg_change): Update.
 201         * s390-linux-nat.c (s390_refresh_per_info): Update.
 202
 203 2019-03-11  Tom Tromey  <tromey@adacore.com>
 204
 205         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
 206         redundant assignment to "this_cu".
 207
 208 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 209
 210         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
 211
 212 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 213
 214         * gdbtypes.c (rank_one_type_parm_set): New function extracted
 215         from...
 216         (rank_one_type): ... this.
 217
 218 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 219
 220         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
 221         from...
 222         (rank_one_type): ... this.
 223
 224 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 225
 226         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
 227         from...
 228         (rank_one_type): ... this.
 229
 230 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 231
 232         * gdbtypes.c (rank_one_type_parm_float): New function extracted
 233         from...
 234         (rank_one_type): ... this.
 235
 236 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 237
 238         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
 239         from...
 240         (rank_one_type): ... this.
 241
 242 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 243
 244         * gdbtypes.c (rank_one_type_parm_range): New function extracted
 245         from...
 246         (rank_one_type): ... this.
 247
 248 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 249
 250         * gdbtypes.c (rank_one_type_parm_char): New function extracted
 251         from...
 252         (rank_one_type): ... this.
 253
 254 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 255
 256         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
 257         from...
 258         (rank_one_type): ... this.
 259
 260 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 261
 262         * gdbtypes.c (rank_one_type_parm_int): New function extracted
 263         from...
 264         (rank_one_type): ... this.
 265
 266 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 267
 268         * gdbtypes.c (rank_one_type_parm_func): New function extracted
 269         from...
 270         (rank_one_type): ... this.
 271
 272 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 273
 274         * gdbtypes.c (rank_one_type_parm_array): New function extracted
 275         from...
 276         (rank_one_type): ... this.
 277
 278 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 279
 280         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
 281         from...
 282         (rank_one_type): ... this.
 283
 284 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 285
 286         * inferior.c (initialize_inferiors): Ensure 'help set/show print
 287         inferior-events' shows the example events.
 288
 289 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
 290
 291         Support styling on native MS-Windows console
 292
 293         PR/24315
 294         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
 295         on MS-Windows if $TERM is not defined.
 296
 297         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
 298
 299         * posix-hdep.c (gdb_console_fputs):
 300         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
 301         functions.
 302         * ui-file.h (gdb_console_fputs): Add prototype.
 303
 304         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
 305         back to fputs only if the former returns zero.
 306
 307 2019-03-07  Tom Tromey  <tom@tromey.com>
 308
 309         * symmisc.c (print_symbol_bcache_statistics): Update.
 310         (print_objfile_statistics): Update.
 311         * symfile.c (allocate_symtab): Update.
 312         * stabsread.c: Don't include bcache.h.
 313         * psymtab.h (struct psymbol_bcache): Don't declare.
 314         (class psymtab_storage) <psymbol_cache>: Now a bcache.
 315         (psymbol_bcache_init, psymbol_bcache_free)
 316         (psymbol_bcache_get_bcache): Don't declare.
 317         * psymtab.c (struct psymbol_bcache): Remove.
 318         (psymtab_storage::psymtab_storage): Update.
 319         (psymtab_storage::~psymtab_storage): Update.
 320         (psymbol_bcache_init, psymbol_bcache_free)
 321         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
 322         (add_psymbol_to_bcache): Update.
 323         (allocate_psymtab): Update.
 324         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
 325         macro_cache>: No longer pointers.
 326         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
 327         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
 328         * macrotab.c (macro_bcache): Update.
 329         * macroexp.c: Don't include bcache.h.
 330         * gdbtypes.c (check_types_worklist): Update.
 331         (types_deeply_equal): Remove TRY/CATCH.  Update.
 332         * elfread.c (elf_symtab_read): Update.
 333         * dwarf2read.c: Don't include bcache.h.
 334         * buildsym.c (buildsym_compunit::get_macro_table): Update.
 335         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
 336         (print_bcache_statistics, bcache_memory_used): Don't declare.
 337         (struct bcache): Move from bcache.c.  Add constructor, destructor,
 338         methods.  Rename all data members.
 339         * bcache.c (struct bcache): Move to bcache.h.
 340         (bcache::expand_hash_table): Rename from expand_hash_table.
 341         (bcache): Remove.
 342         (bcache::insert): Rename from bcache_full.
 343         (bcache::compare): Rename from bcache_compare.
 344         (bcache_xmalloc): Remove.
 345         (bcache::~bcache): Rename from bcache_xfree.
 346         (bcache::print_statistics): Rename from print_bcache_statistics.
 347         (bcache::memory_used): Rename from bcache_memory_used.
 348
 349 2019-03-07  Pedro Alves  <palves@redhat.com>
 350
 351         * infrun.c (normal_stop): Also check for
 352         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
 353
 354 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 355
 356         * f-lang.c (value_from_host_double): Moved to...
 357         * value.c (value_from_host_double): ...here.
 358         * value.h (value_from_host_double): Declare.
 359         * guile/scm-math.c (vlscm_convert_typed_number): Use
 360         value_from_host_double.
 361         (vlscm_convert_number): Likewise.
 362         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
 363         * python/py-value.c (convert_value_from_python): Likewise.
 364
 365 2019-03-06  Tom Tromey  <tom@tromey.com>
 366
 367         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
 368
 369 2019-03-06  Tom Tromey  <tom@tromey.com>
 370
 371         * utils.h (free_current_contents): Don't declare.
 372         * utils.c (free_current_contents): Remove.
 373
 374 2019-03-06  Tom Tromey  <tom@tromey.com>
 375
 376         * top.c (quit_force): Update.
 377         * main.c (captured_command_loop): Update.
 378         * common/new-op.c (operator new): Update.
 379         * common/common-exceptions.c (struct catcher)
 380         <save_cleanup_chain>: Remove member.
 381         (exceptions_state_mc_init): Update.
 382         (exception_try_scope_entry): Return nullptr.
 383         (exception_try_scope_exit, exception_rethrow)
 384         (throw_exception_sjlj, throw_exception_cxx): Update.
 385         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
 386         (all_cleanups, do_cleanups, discard_cleanups)
 387         (discard_final_cleanups, save_cleanups, save_final_cleanups)
 388         (restore_cleanups, restore_final_cleanups): Don't declare.
 389         (do_final_cleanups): Remove parameter.
 390         * common/cleanups.c (cleanup_chain, make_cleanup)
 391         (make_cleanup_dtor, all_cleanups, do_cleanups)
 392         (discard_my_cleanups, discard_cleanups)
 393         (discard_final_cleanups, save_my_cleanups, save_cleanups)
 394         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
 395         (null_cleanup): Remove.
 396         (do_final_cleanups): Remove parameter.
 397
 398 2019-03-06  Tom Tromey  <tom@tromey.com>
 399
 400         * remote.c (remote_target::remote_parse_stop_reply): Use
 401         unique_xmalloc_ptr.
 402
 403 2019-03-06  Tom Tromey  <tom@tromey.com>
 404
 405         * stabsread.c (struct stabs_field_info): Rename from field_info.
 406         <list, fnlist>: Add initializers.
 407         <obstack>: New member.
 408         (read_member_functions, read_struct_fields, read_baseclasses):
 409         Allocate on obstack.  Don't use cleanups.
 410         (read_one_struct_field, read_member_functions, read_struct_fields)
 411         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
 412         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
 413         (read_struct_type): Update.
 414
 415 2019-03-06  Tom Tromey  <tom@tromey.com>
 416
 417         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
 418         * common/filestuff.h (make_cleanup_close): Don't declare.
 419         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
 420         Remove.
 421
 422 2019-03-06  Tom Tromey  <tom@tromey.com>
 423
 424         * solib-aix.c: Use make_scope_exit.
 425
 426 2019-03-06  Tom Tromey  <tom@tromey.com>
 427
 428         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
 429         Use make_scope_exit.
 430
 431 2019-03-06  Tom Tromey  <tom@tromey.com>
 432
 433         * solib-svr4.c (disable_probes_interface): Remove parameter.
 434         (svr4_handle_solib_event): Use make_scope_exit.
 435
 436 2019-03-06  Tom Tromey  <tom@tromey.com>
 437
 438         * remote.c (struct stop_reply_deleter): Remove.
 439         (stop_reply_up): Update.
 440         (struct stop_reply): Derive from notif_event.  Don't typedef.
 441         <regcache>: Now a std::vector.
 442         (stop_reply_xfree): Remove.
 443         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
 444         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
 445         (remote_target::discard_pending_stop_replies): Use delete.
 446         (remote_target::remote_parse_stop_reply): Update.
 447         (remote_target::process_stop_reply): Update.
 448         * remote-notif.h (struct notif_event): Add virtual destructor.
 449         Remove "dtr" member.
 450         (struct notif_client) <alloc_event>: Return a unique_ptr.
 451         (notif_event_xfree): Don't declare.
 452         (notif_event_up): New typedef.
 453         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
 454         (notif_event_xfree, do_notif_event_xfree): Remove.
 455         (remote_notif_state_xfree): Update.
 456
 457 2019-03-06  Tom Tromey  <tom@tromey.com>
 458
 459         * infrun.c (displaced_step_clear_cleanup): Now a
 460         forward_scope_exit type.
 461         (displaced_step_prepare_throw): Update.
 462         (displaced_step_fixup): Update.
 463
 464 2019-03-06  Tom Tromey  <tom@tromey.com>
 465
 466         * inferior.h (class inferior): Update comment.
 467         * gdbthread.h (class thread_info): Update comment.
 468
 469 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
 470             Tom Tromey  <tom@tromey.com>
 471
 472         * stabsread.h (struct stab_section_list): Remove.
 473         (coffstab_build_psymtabs): Update.
 474         * dbxread.c (symbuf_sections): Now a std::vector.
 475         (sect_idx): New global.
 476         (fill_symbuf): Update.
 477         (coffstab_build_psymtabs): Change type of stabsects parameter.
 478         Update.
 479         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
 480         std::vector.
 481         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
 482         (coff_locate_sections): Update.
 483         (coff_symfile_read): Remove cleanups.  Update.
 484         (init_stringtab): Add storage parameter.
 485         (free_stringtab, free_stringtab_cleanup): Remove.
 486         (init_lineno): Add storage parameter.
 487         (free_linetab, free_linetab_cleanup): Remove.
 488
 489 2019-03-06  Pedro Alves  <palves@redhat.com>
 490
 491         * linux-fork.c (fork_info::clobber_regs): Delete.
 492         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
 493         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
 494         comment.  Adjust.
 495         (scoped_switch_fork_info::scoped_switch_fork_info)
 496         (checkpoint_command, linux_fork_context): Adjust
 497         fork_save_infrun_state calls.
 498
 499 2019-03-06  Pedro Alves  <palves@redhat.com>
 500
 501         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
 502         (inf_has_multiple_threads): Return 'bool' and rewrite using
 503         inferior_info::threads().
 504
 505 2019-03-06  Pedro Alves  <palves@redhat.com>
 506
 507         * linux-fork.c: Include <list>.
 508         (fork_list): Now a std::list instance.
 509         (fork_info): Add ctor, dtor, and in-class initialize all fields.
 510         (forks_exist_p, find_last_fork): Adjust.
 511         (new_fork): Delete.
 512         (one_fork_p): New.
 513         (add_fork): Adjust.
 514         (free_fork): Delete, folded into fork_info::~fork_info().
 515         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
 516         Adjust.
 517         (init_fork_list): Delete.
 518         (linux_fork_killall, linux_fork_mourn_inferior)
 519         (linux_fork_detach, info_checkpoints_command): Adjust.
 520         (_initialize_linux_fork): No longer call init_fork_list.
 521
 522 2019-03-06  Pedro Alves  <palves@redhat.com>
 523
 524         * linux-fork.c (new_fork): New, split out of ...
 525         (add_fork): ... this.  Return void.  Move "first fork" special
 526         case from here, to ...
 527         (checkpoint_command): ... here.
 528         * linux-linux.h (add_fork): Return void.
 529
 530 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 531
 532         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
 533
 534 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 535             Chris January  <chris.january@arm.com>
 536             David Lecomber  <david.lecomber@arm.com>
 537
 538         * f-exp.y: New token, UNOP_INTRINSIC.
 539         (exp): New pattern using UNOP_INTRINSIC token.
 540         (f77_keywords): Add 'abs' keyword.
 541         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
 542         (value_from_host_double): New function.
 543         (evaluate_subexp_f): Support UNOP_ABS.
 544
 545 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 546
 547         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
 548         types.
 549
 550 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 551
 552         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
 553         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
 554         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
 555
 556 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 557
 558         * f-exp.y (convert_to_kind_type): Handle more type kinds.
 559
 560 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 561             Chris January  <chris.january@arm.com>
 562
 563         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
 564         * f-exp.y: Define 'KIND' token.
 565         (exp): New pattern for KIND expressions.
 566         (ptype): Handle types with a kind extension.
 567         (direct_abs_decl): Extend to spot kind extensions.
 568         (f77_keywords): Add 'kind' to the list.
 569         (push_kind_type): New function.
 570         (convert_to_kind_type): New function.
 571         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
 572         * parse.c (operator_length_standard): Likewise.
 573         * parser-defs.h (enum type_pieces): Add tp_kind.
 574         * std-operator.def: Add UNOP_KIND.
 575
 576 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 577
 578         * f-exp.y (f_parse): Set yydebug.
 579
 580 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 581
 582         * f-lang.c (evaluate_subexp_f): New function.
 583         (exp_descriptor_f): New global.
 584         (f_language_defn): Use exp_descriptor_f instead of
 585         exp_descriptor_standard.
 586
 587 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 588
 589         * f-exp.y (struct token): Add comments.
 590         (dot_ops): Remove uppercase versions and the end marker.
 591         (f77_keywords): Likewise.
 592         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
 593         entries in the dot_ops array are case insensitive, and use
 594         strncasecmp to compare strings.  Also some whitespace cleanup in
 595         this area.  Similar for the f77_keywords array, except entries in
 596         this list might be case sensitive.
 597
 598 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 599
 600         * f-exp.y (struct f77_boolean_val): Add comments.
 601         (boolean_values): Remove uppercase versions, and end marker.
 602         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
 603         and use strncasecmp to achieve case insensitivity.  Additionally,
 604         perform whitespace cleanup around this code.
 605
 606 2019-03-06  Tom Tromey  <tromey@adacore.com>
 607
 608         * remote-sim.c (gdbsim_target_open): Use result of
 609         gdb_argv::release.
 610
 611 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
 612         Dirk Schubert  <dirk.schubert@arm.com>
 613         Chris January  <chris.january@arm.com>
 614
 615         * eval.c (evaluate_subexp_standard): Call Fortran argument
 616         wrapping logic.
 617         * f-lang.c (struct value): A value which can be passed into a
 618         Fortran function call.
 619         (fortran_argument_convert): Wrap Fortran arguments in a pointer
 620         where appropriate.
 621         (struct type): Value ready for a Fortran function call.
 622         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
 623         is needed.
 624         * f-lang.h (fortran_argument_convert): Declaration.
 625         (fortran_preserve_arg_pointer): Declaration.
 626         * infcall.c (value_arg_coerce): Call Fortran argument logic.
 627
 628 2019-03-05  Tom Tromey  <tromey@adacore.com>
 629
 630         * python/py-prettyprint.c (print_string_repr): Remove #if.
 631         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
 632
 633 2019-03-05  Tom Tromey  <tromey@adacore.com>
 634
 635         * target.c (the_dummy_target): Move later.  Change type to
 636         "dummy_target".
 637         (initialize_targets): Don't initialize the_dummy_target.
 638
 639 2019-03-05  Tom Tromey  <tromey@adacore.com>
 640
 641         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
 642         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
 643
 644 2019-03-05  Tom Tromey  <tromey@adacore.com>
 645
 646         * windows-nat.c (windows_nat_target::attach)
 647         (windows_nat_target::detach): Don't call gdb_flush.
 648         * valprint.c (generic_val_print, val_print, val_print_string):
 649         Don't call gdb_flush.
 650         * utils.c (defaulted_query): Don't call gdb_flush.
 651         * typeprint.c (print_type_scalar): Don't call gdb_flush.
 652         * target.c (target_announce_detach): Don't call gdb_flush.
 653         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
 654         * remote.c (extended_remote_target::attach): Don't call
 655         gdb_flush.
 656         * procfs.c (procfs_target::detach): Don't call gdb_flush.
 657         * printcmd.c (do_examine): Don't call gdb_flush.
 658         (info_display_command): Don't call gdb_flush.
 659         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
 660         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
 661         * memattr.c (info_mem_command): Don't call gdb_flush.
 662         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
 663         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
 664         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
 665         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
 666         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
 667         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
 668         (gnu_nat_target::detach): Don't call gdb_flush.
 669         * f-valprint.c (f_val_print): Don't call gdb_flush.
 670         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
 671         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
 672         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
 673         gdb_flush.
 674         * c-valprint.c (c_val_print): Don't call gdb_flush.
 675         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
 676
 677 2019-03-05  Tom Tromey  <tromey@adacore.com>
 678
 679         * varobj.c (update_dynamic_varobj_children): Update.
 680         (install_default_visualizer): Use reset, not release.
 681         * value.c (set_internalvar): Update.
 682         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
 683         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
 684         ATTRIBUTE_UNUSED_RESULT.
 685
 686 2019-03-05  Tom Tromey  <tromey@adacore.com>
 687
 688         * remote.c (class scoped_remote_fd) <release>: Add
 689         ATTRIBUTE_UNUSED_RESULT.
 690
 691 2019-03-05  Tom Tromey  <tromey@adacore.com>
 692
 693         * macroexp.c (struct macro_buffer) <release>: Add
 694         ATTRIBUTE_UNUSED_RESULT.
 695
 696 2019-03-05  Tom Tromey  <tromey@adacore.com>
 697
 698         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
 699         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
 700         ATTRIBUTE_UNUSED_RESULT.
 701
 702 2019-03-05  Tom Tromey  <tromey@adacore.com>
 703
 704         * common/scoped_fd.h (class scoped_fd) <release>: Add
 705         ATTRIBUTE_UNUSED_RESULT.
 706
 707 2019-03-05  Tom Tromey  <tromey@adacore.com>
 708
 709         * parser-defs.h (struct parser_state) <release>: Add
 710         ATTRIBUTE_UNUSED_RESULT.
 711
 712 2019-03-05  Tom Tromey  <tromey@adacore.com>
 713
 714         * utils.h (class gdb_argv) <release>: Add
 715         ATTRIBUTE_UNUSED_RESULT.
 716         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
 717
 718 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
 719
 720         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
 721         for-loop range, to avoid compiler warnings.
 722
 723         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
 724         avoid compiler warnings about unused variables.
 725
 726         * NEWS: Mention end of support for native debugging on MS-Windows
 727         before XP.
 728
 729         PR gdb/24292
 730         * common/netstuff.c:
 731         * gdbserver/gdbreplay.c
 732         * gdbserver/remote-utils.c:
 733         * ser-tcp.c:
 734         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
 735         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
 736         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
 737         'getaddrinfo' and 'freeaddrinfo' were not available before
 738         Windows XP, and mingw.org's MinGW headers by default define
 739         _WIN32_WINNT to 0x500.
 740
 741 2019-03-01  Gary Benson <gbenson@redhat.com>
 742
 743         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
 744
 745 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
 746             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 747
 748         PR gdb/8527
 749         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
 750         set_sigint_trap, clear_sigint_trap.
 751
 752 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 753
 754         * target.c (target_detach): Clear the regcache and the
 755         frame cache.
 756
 757 2019-02-27  Pedro Alves  <palves@redhat.com>
 758
 759         * utils.c (set_screen_size): When we cap the height/width sizes,
 760         tweak the corresponding command variable to show "unlimited":
 761
 762 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
 763             Pedro Alves  <palves@redhat.com>
 764
 765         * utils.c (set_screen_size): Reduce "infinite" rows and columns
 766         before calling rl_set_screen_size.
 767
 768 2019-02-27  Tom Tromey  <tromey@adacore.com>
 769
 770         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
 771         define.
 772         * python/py-value.c: Remove Python 2.4 workaround.
 773         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
 774         workaround.
 775         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
 776         Python 2.4 workaround.
 777         * python/python-internal.h: Remove Python 2.4 comment.
 778         (Py_ssize_t): Don't define.
 779         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
 780         (gdb_Py_DECREF): Remove Python 2.4 workaround.
 781         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
 782         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
 783         * python/python.c (do_start_initialization): Remove Python 2.4
 784         workaround.
 785         * python/py-prettyprint.c (class dummy_python_frame): Remove.
 786         (print_children): Remove Python 2.4 workaround.
 787         * python/py-inferior.c (buffer_procs): Remove Python 2.4
 788         workaround.
 789         (CHARBUFFERPROC_NAME): Remove.
 790         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
 791         Python 2.4 workaround.
 792
 793 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
 794
 795         * NEWS: Note minimum Python version.
 796
 797 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
 798
 799         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
 800         code from these functions.  Remove corresponding ifdefs.  Use
 801         Py_buffer_up instead of explicit calls to PyBuffer_Release.
 802         Remove gotos and target of gotos.
 803         (infpy_search_memory): Likewise.
 804
 805 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 806
 807         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
 808         (hppa_gdbarch_init): Don't register deleted functions with
 809         gdbarch.
 810
 811 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 812
 813         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
 814         (h8300_unwind_sp): Delete.
 815         (h8300_dummy_id): Delete.
 816         (h8300_gdbarch_init): Don't register deleted functions with
 817         gdbarch.
 818
 819 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 820
 821         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
 822         (ft32_unwind_pc): Delete.
 823         (ft32_unwind_sp): Delete.
 824         (ft32_gdbarch_init): Don't register deleted functions with
 825         gdbarch.
 826
 827 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 828
 829         * gdb/frv-tdep.c (frv_dummy_id): Delete.
 830         (frv_unwind_pc): Delete.
 831         (frv_unwind_sp): Delete.
 832         (frv_gdbarch_init): Don't register deleted functions with
 833         gdbarch.
 834
 835 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 836
 837         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
 838         (riscv_unwind_pc): Delete.
 839         (riscv_unwind_sp): Delete.
 840         (riscv_gdbarch_init): Don't register deleted functions with
 841         gdbarch.
 842
 843 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 844
 845         * gdb/csky-tdep.c (csky_dummy_id): Delete.
 846         (csky_unwind_pc): Delete.
 847         (csky_unwind_sp): Delete.
 848         (csky_gdbarch_init): Don't register deleted functions with
 849         gdbarch.
 850
 851 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 852
 853         * gdb/cris-tdep.c (cris_dummy_id): Delete.
 854         (cris_unwind_pc): Delete.
 855         (cris_unwind_sp): Delete.
 856         (cris_gdbarch_init): Don't register deleted functions with
 857         gdbarch.
 858
 859 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 860
 861         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
 862         (bfin_unwind_pc): Delete.
 863         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
 864
 865 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 866
 867         * gdb/arm-tdep.c (arm_dummy_id): Delete.
 868         (arm_unwind_pc): Delete.
 869         (arm_unwind_sp): Delete.
 870         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
 871
 872 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 873
 874         * gdb/arc-tdep.c (arc_dummy_id): Delete.
 875         (arc_unwind_pc): Delete.
 876         (arc_unwind_sp): Delete.
 877         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
 878
 879 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 880
 881         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
 882         (alpha_unwind_pc): Delete.
 883         (alpha_gdbarch_init): Don't register deleted functions with
 884         gdbarch.
 885
 886 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 887
 888         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
 889         (aarch64_unwind_pc): Delete.
 890         (aarch64_unwind_sp): Delete.
 891         (aarch64_gdbarch_init): Don't register deleted functions with
 892         gdbarch.
 893
 894 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 895
 896         * gdbtypes.c (type_align): Don't consider static members when
 897         computing structure alignment.
 898
 899 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 900
 901         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
 902         return 0 for other types.
 903         * arch-utils.c (default_type_align): Always return 0.
 904         * gdbarch.h: Regenerate.
 905         * gdbarch.sh (type_align): Extend comment.
 906         * gdbtypes.c (type_align): Add additional comments, always call
 907         gdbarch_type_align before applying the default rules.
 908         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
 909         generic code will then apply a suitable default.
 910         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
 911         types, return 0 for other types.
 912
 913 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 914
 915         * NEWS: Create a new section for the next release branch.
 916         Rename the section of the current branch, now that it has
 917         been cut.
 918
 919 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 920
 921         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
 922         * version.in: Bump version to 8.3.50.DATE-git.
 923
 924 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
 925
 926         * aix-thread.c (ptid_cmp): Remove unused variable.
 927         (get_signaled_thread): Likewise.
 928         (store_regs_user_thread): Likewise.
 929         (store_regs_kernel_thread): Likewise.
 930         (fetch_regs_kernel_thread): Remove shadowed variable.
 931
 932 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
 933
 934         * features/riscv/32bit-cpu.xml: Add register numbers.
 935         * features/riscv/32bit-fpu.c: Regenerate.
 936         * features/riscv/32bit-fpu.xml: Add register numbers.
 937         * features/riscv/64bit-cpu.xml: Add register numbers.
 938         * features/riscv/64bit-fpu.c: Regenerate.
 939         * features/riscv/64bit-fpu.xml: Add register numbers.
 940
 941 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
 942
 943         * NEWS: Mention two argument form of gdb.Value constructor.
 944         * python/py-value.c (convert_buffer_and_type_to_value): New
 945         function.
 946         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
 947         Add support for handling an optional second argument.  Call
 948         convert_buffer_and_type_to_value as appropriate.
 949         * python/python-internal.h (Py_buffer_deleter): New struct.
 950         (Py_buffer_up): New typedef.
 951
 952 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
 953
 954         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
 955         instead of releasing ownership.
 956
 957 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
 958
 959         * dwarf2read.c (open_and_init_dwp_file): Call
 960         elf_numsections instead of bfd_count_sections to initialize
 961         dwp_file->num_sections.
 962
 963 2019-02-25  Tom Tromey  <tromey@adacore.com>
 964
 965         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
 966
 967 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 968
 969         * gcore.in: Add '--readnever' option when invoking GDB.
 970
 971 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 972
 973         * MAINTAINERS: Update my email address.
 974
 975 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 976
 977         * build-id.c (build_id_to_debug_bfd_1): New function.
 978         (build_id_to_debug_bfd): Look for separate debug file in
 979         sysroot.
 980
 981 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 982
 983         * gdbarch.sh: Update the copyright year range that is placed into
 984         generated files.
 985
 986 2019-02-22  Keith Seitz  <keiths@redhat.com>
 987
 988         PR symtab/23853
 989         * linespec.c (create_sals_line_offset): Search for the default
 990         symtab's filename instead of its fullname.
 991
 992 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 993
 994         * NEWS: Update style defaults.
 995
 996 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 997
 998         * main.c (captured_main_1): Disable styling in batch mode.
 999
1000 2019-02-20  Tom Tromey  <tom@tromey.com>
1001
1002         * symtab.c (symtab_symbol_info): Fix typos.
1003
1004 2019-02-20  Tom Tromey  <tromey@adacore.com>
1005
1006         * findcmd.c (_initialize_mem_search): Use upper case for
1007         metasyntactic variables.
1008
1009 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
1010
1011         * aarch64-tdep.c (aarch64_add_reggroups): New function.
1012         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
1013
1014 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
1015
1016         * top.h (source_file_name): Change to std::string.
1017         * top.c (source_file_name): Likewise.
1018         (command_line_input): Adjust.
1019         * cli/cli-script.c (script_from_file): Adjust.
1020
1021 2019-02-19  Tom Tromey  <tromey@adacore.com>
1022
1023         * ravenscar-thread.c
1024         (ravenscar_thread_target::update_thread_list): Don't call
1025         ada_build_task_list.
1026         * ada-lang.h (ada_build_task_list): Don't declare.
1027         * ada-tasks.c (struct ada_tasks_inferior_data)
1028         <task_list_valid_p>: Now bool.
1029         (read_known_tasks, ada_task_list_changed)
1030         (ada_tasks_invalidate_inferior_data): Update.
1031         (read_known_tasks_array): Return bool.
1032         (read_known_tasks_list): Likewise.
1033         (read_known_tasks): Return void.
1034         (ada_build_task_list): Now static.
1035
1036 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1037
1038         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
1039         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
1040
1041 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1042
1043         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
1044         variant for ada_tasks_pspace_data_handle and
1045         ada_tasks_inferior_data_handle.
1046         (ada_tasks_pspace_data_cleanup): New function.
1047         (ada_tasks_inferior_data_cleanup): New function.
1048
1049 2019-02-17  Tom Tromey  <tom@tromey.com>
1050
1051         * macrotab.h (macro_source_fullname): Return a std::string.
1052         * macrotab.c (macro_include, check_for_redefinition)
1053         (macro_undef, macro_lookup_definition, foreach_macro)
1054         (foreach_macro_in_scope): Update.
1055         (macro_source_fullname): Return a std::string.
1056         * macrocmd.c (show_pp_source_pos): Update.
1057
1058 2019-02-17  Tom Tromey  <tom@tromey.com>
1059
1060         * macrocmd.c (show_pp_source_pos): Style the file names.
1061
1062 2019-02-17  Tom Tromey  <tom@tromey.com>
1063
1064         PR tui/24197:
1065         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
1066
1067 2019-02-17  Tom Tromey  <tom@tromey.com>
1068
1069         * ada-lang.c (user_select_syms): Use filtered printing.
1070         * utils.c (wrap_style): New global.
1071         (desired_style): Remove.
1072         (emit_style_escape): Add stream parameter.
1073         (set_output_style, reset_terminal_style, prompt_for_continue):
1074         Update.
1075         (flush_wrap_buffer): Only flush gdb_stdout.
1076         (wrap_here): Set wrap_style.
1077         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
1078         treat escape sequences as a character.  Change when wrap buffer is
1079         flushed.
1080         (fputs_styled): Do not set the output style when the default is
1081         requested.
1082         * ui-style.h (struct ui_file_style) <is_default>: New method.
1083         * source.c (print_source_lines_base): Emit escape sequences in one
1084         piece.
1085
1086 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1087
1088         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
1089         integers and enumeration types.
1090
1091 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1092
1093         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
1094         instead of lookup_symbol_in_language
1095         (do_exact_match): New function.
1096         (ada_get_symbol_name_matcher): Return do_exact_match when
1097         doing a verbatim match.
1098
1099 2019-02-15  Tom Tromey  <tromey@adacore.com>
1100
1101         * ravenscar-thread.c (ravenscar_thread_target::resume)
1102         (ravenscar_thread_target::wait): Special case wildcard requests.
1103
1104 2019-02-15  Tom Tromey  <tromey@adacore.com>
1105
1106         * ravenscar-thread.c (base_ptid): Remove.
1107         (struct ravenscar_thread_target) <close>: New method.
1108         <m_base_ptid>: New member.
1109         <update_inferior_ptid, active_task, task_is_currently_active,
1110         runtime_initialized>: Declare methods.
1111         <ravenscar_thread_target>: Add constructor.
1112         (ravenscar_thread_target::task_is_currently_active)
1113         (ravenscar_thread_target::update_inferior_ptid)
1114         (ravenscar_runtime_initialized): Rename.  Now methods.
1115         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
1116         (ravenscar_thread_target::update_thread_list): Update.
1117         (ravenscar_thread_target::active_task): Now method.
1118         (ravenscar_thread_target::store_registers)
1119         (ravenscar_thread_target::prepare_to_store)
1120         (ravenscar_thread_target::prepare_to_store)
1121         (ravenscar_thread_target::mourn_inferior): Update.
1122         (ravenscar_inferior_created): Use "new" to create target.
1123         (ravenscar_thread_target::get_ada_task_ptid): Update.
1124         (_initialize_ravenscar): Don't initialize base_ptid.
1125         (ravenscar_ops): Remove global.
1126
1127 2019-02-15  Tom Tromey  <tromey@adacore.com>
1128
1129         * target.h (push_target): Declare new overload.
1130         * target.c (push_target): New overload, taking an rvalue reference.
1131         * remote.c (remote_target::open_1): Use push_target overload.
1132         * corelow.c (core_target_open): Use push_target overload.
1133
1134 2019-02-15  Tom Tromey  <tromey@adacore.com>
1135
1136         * ravenscar-thread.c (is_ravenscar_task)
1137         (ravenscar_task_is_currently_active): Return bool.
1138         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
1139         (_initialize_ravenscar): Remove "(void)".
1140         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
1141         Return bool.
1142
1143 2019-02-15  Tom Tromey  <tromey@adacore.com>
1144
1145         * ravenscar-thread.c (ravenscar_runtime_initializer)
1146         (has_ravenscar_runtime, get_running_thread_id)
1147         (ravenscar_thread_target::resume): Fix indentation.
1148
1149 2019-02-15  Tom Tromey  <tromey@adacore.com>
1150
1151         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
1152         from ravenscar_arch_ops.
1153         (sparc_ravenscar_ops::fetch_registers)
1154         (sparc_ravenscar_ops::store_registers): Now methods.
1155         (sparc_ravenscar_prepare_to_store): Remove.
1156         (sparc_ravenscar_ops): Redefine.
1157         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
1158         methods and destructor.  Remove members.
1159         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
1160         (ravenscar_thread_target::store_registers)
1161         (ravenscar_thread_target::prepare_to_store): Update.
1162         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
1163         Remove.
1164         (struct ppc_ravenscar_powerpc_ops): Derive from
1165         ravenscar_arch_ops.
1166         (ppc_ravenscar_powerpc_ops::fetch_registers)
1167         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
1168         (ppc_ravenscar_powerpc_ops): Redefine.
1169         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
1170         (ppc_ravenscar_e500_ops::fetch_registers)
1171         (ppc_ravenscar_e500_ops::store_registers): Now methods.
1172         (ppc_ravenscar_e500_ops): Redefine.
1173         * aarch64-ravenscar-thread.c
1174         (aarch64_ravenscar_generic_prepare_to_store): Remove.
1175         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
1176         (aarch64_ravenscar_fetch_registers)
1177         (aarch64_ravenscar_store_registers): Now methods.
1178         (aarch64_ravenscar_ops): Redefine.
1179
1180 2019-02-15  Tom Tromey  <tromey@adacore.com>
1181
1182         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
1183         (ravenscar_thread_target::stopped_by_hw_breakpoint)
1184         (ravenscar_thread_target::stopped_by_watchpoint)
1185         (ravenscar_thread_target::stopped_data_address)
1186         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
1187
1188 2019-02-15  Tom Tromey  <tromey@adacore.com>
1189
1190         * ravenscar-thread.c: Fix some typos.
1191
1192 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1193             Tom Tromey  <tromey@adacore.com>
1194
1195         * ada-lang.c (ada_exception_sal): Change addr_string to a
1196         std::string.
1197         (create_ada_exception_catchpoint): Update.
1198
1199 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1200             Tom Tromey  <tromey@adacore.com>
1201
1202         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
1203         (bp_location_ops): Remove.
1204         (base_breakpoint_allocate_location): Update.
1205         (free_bp_location): Update.
1206         * ada-lang.c (class ada_catchpoint_location)
1207         <ada_catchpoint_location>: Remove ops parameter.
1208         (ada_catchpoint_location_dtor): Remove.
1209         (ada_catchpoint_location_ops): Remove.
1210         (allocate_location_exception): Update.
1211         * breakpoint.h (struct bp_location_ops): Remove.
1212         (class bp_location) <bp_location>: Remove bp_location_ops
1213         parameter.
1214         <~bp_location>: Add destructor.
1215         <ops>: Remove.
1216
1217 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1218             Pedro Alves  <palves@redhat.com>
1219
1220         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
1221         'PATH_MAX'.
1222
1223 2019-02-14  David Michael  <fedora.dm0@gmail.com>
1224             Samuel Thibault  <samuel.thibault@gnu.org>
1225             Thomas Schwinge  <thomas@codesourcery.com>
1226
1227         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
1228         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
1229
1230 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1231
1232         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
1233         (check_empty): Use "const char *".
1234
1235         * gnu-nat.c (gnu_nat_target::detach): Instead of
1236         'detach_inferior (pid)' call
1237         'detach_inferior (find_inferior_pid (pid))'.
1238
1239         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
1240         'nat/fork-inferior.o'.
1241         * gnu-nat.c: #include "nat/fork-inferior.h".
1242
1243         * gnu-nat.c (gnu_nat_target::detach): Instead of
1244         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
1245         * gnu-nat.h: #include "inf-child.h".
1246         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
1247         'i386_gnu_nat_target::fetch_registers'.
1248         (gnu_store_registers): Rename/move to
1249         'i386_gnu_nat_target::store_registers'.
1250
1251         * config/i386/nm-i386gnu.h: Don't "#include" any files.
1252         * gnu-nat.h (mach_thread_info): New function.
1253         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
1254
1255         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
1256
1257 2019-02-14  Frederic Konrad  <konrad@adacore.com>
1258
1259         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
1260
1261 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
1262
1263         * windows-nat.c (windows_add_thread): Add new parameter
1264         "main_thread_p" with default value set to false.  Update
1265         function documentation as well as all callers.
1266         (windows_delete_thread): Likewise.
1267         (fake_create_process): Update call to windows_add_thread.
1268         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
1269         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
1270         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
1271         call to windows_delete_thread.
1272
1273 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
1274
1275         * MAINTAINERS: Add Andrew Burgess as global maintainer.
1276
1277 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1278
1279         * symfile.c (find_separate_debug_file): Use canonical path of
1280         sysroot with child_path instead of gdb_sysroot if it is valid.
1281
1282 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1283
1284         * symfile.c (find_separate_debug_file): Use child_path to
1285         determine if an object file is under a sysroot.
1286
1287 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1288
1289         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1290         unittests/child-path-selftests.c.
1291         * common/pathstuff.c (child_path): New function.
1292         * common/pathstuff.h (child_path): New prototype.
1293         * unittests/child-path-selftests.c: New file.
1294
1295 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1296
1297         * symfile.c (find_separate_debug_file): Look for separate debug
1298         files in debug directories under the sysroot.
1299
1300 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1301
1302         * symtab.h (struct minimal_symbol data_p): New const method.
1303         (struct minimal_symbol text_p): Likewise.
1304         * symtab.c (output_source_filename): Use file name style
1305         to print file name.
1306         (print_symbol_info): Likewise.
1307         (print_msymbol_info): Use address style to print addresses.
1308         Use function name style to print executable text symbols.
1309         (expand_symtab_containing_pc): Use data_p.
1310         (find_pc_sect_compunit_symtab): Likewise.
1311
1312 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1313
1314         * breakpoint.c (describe_other_breakpoints): Use address style
1315         to print addresses.
1316         (say_where): Likewise.
1317
1318 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1319
1320         * ada-typeprint.c (print_func_type): Print function name
1321         style to print function name.
1322         * c-typeprint.c (c_print_type_1): Likewise.
1323
1324 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
1325
1326         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
1327         for execve.
1328
1329 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1330
1331         * c-exp.y (direct_abs_decl): Use emplace_back to record the
1332         type_stack.
1333
1334 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
1335
1336         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
1337         TYPE_CODE_REF types.
1338
1339 2019-02-08  Jim Wilson  <jimw@sifive.com>
1340
1341         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
1342         (riscv_linux_fregset): New.
1343         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
1344
1345 2019-02-07  Tom Tromey  <tom@tromey.com>
1346
1347         * thread.c (thread_cancel_execution_command): Update.
1348         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
1349         methods.
1350         (struct thread_fsm_ops): Remove.
1351         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
1352         (thread_fsm_should_stop, thread_fsm_return_value)
1353         (thread_fsm_set_finished, thread_fsm_finished_p)
1354         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
1355         Don't declare.
1356         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
1357         * infrun.c (clear_proceed_status_thread)
1358         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
1359         (print_stop_event): Update.
1360         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
1361         Add constructor.
1362         (step_command_fsm_ops): Remove.
1363         (new_step_command_fsm): Remove.
1364         (step_1): Update.
1365         (step_command_fsm::should_stop): Rename from
1366         step_command_fsm_should_stop.
1367         (step_command_fsm::clean_up): Rename from
1368         step_command_fsm_clean_up.
1369         (step_command_fsm::do_async_reply_reason): Rename from
1370         step_command_fsm_async_reply_reason.
1371         (struct until_next_fsm): Inherit from thread_fsm.  Add
1372         constructor.
1373         (until_next_fsm_ops): Remove.
1374         (new_until_next_fsm): Remove.
1375         (until_next_fsm::should_stop): Rename from
1376         until_next_fsm_should_stop.
1377         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
1378         (until_next_fsm::do_async_reply_reason): Rename from
1379         until_next_fsm_async_reply_reason.
1380         (struct finish_command_fsm): Inherit from thread_fsm.  Add
1381         constructor.  Change type of breakpoint.
1382         (finish_command_fsm_ops): Remove.
1383         (new_finish_command_fsm): Remove.
1384         (finish_command_fsm::should_stop): Rename from
1385         finish_command_fsm_should_stop.
1386         (finish_command_fsm::clean_up): Rename from
1387         finish_command_fsm_clean_up.
1388         (finish_command_fsm::return_value): Rename from
1389         finish_command_fsm_return_value.
1390         (finish_command_fsm::do_async_reply_reason): Rename from
1391         finish_command_fsm_async_reply_reason.
1392         (finish_command): Update.
1393         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
1394         Add constructor.
1395         (call_thread_fsm_ops): Remove.
1396         (call_thread_fsm::call_thread_fsm): Rename from
1397         new_call_thread_fsm.
1398         (call_thread_fsm::should_stop): Rename from
1399         call_thread_fsm_should_stop.
1400         (call_thread_fsm::should_notify_stop): Rename from
1401         call_thread_fsm_should_notify_stop.
1402         (run_inferior_call, call_function_by_hand_dummy): Update.
1403         * cli/cli-interp.c (should_print_stop_to_console): Update.
1404         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
1405         Add constructor.  Change type of location_breakpoint,
1406         caller_breakpoint.
1407         (until_break_fsm_ops): Remove.
1408         (new_until_break_fsm): Remove.
1409         (until_break_fsm::should_stop): Rename from
1410         until_break_fsm_should_stop.
1411         (until_break_fsm::clean_up): Rename from
1412         until_break_fsm_clean_up.
1413         (until_break_fsm::do_async_reply_reason): Rename from
1414         until_break_fsm_async_reply_reason.
1415         (until_break_command): Update.
1416         * thread-fsm.c: Remove.
1417         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
1418
1419 2019-02-07  Tom Tromey  <tom@tromey.com>
1420
1421         * yy-remap.h: Add include guard.
1422         * xtensa-tdep.h: Add include guard.
1423         * xcoffread.h: Rename include guard.
1424         * varobj-iter.h: Add include guard.
1425         * tui/tui.h: Rename include guard.
1426         * tui/tui-winsource.h: Rename include guard.
1427         * tui/tui-wingeneral.h: Rename include guard.
1428         * tui/tui-windata.h: Rename include guard.
1429         * tui/tui-win.h: Rename include guard.
1430         * tui/tui-stack.h: Rename include guard.
1431         * tui/tui-source.h: Rename include guard.
1432         * tui/tui-regs.h: Rename include guard.
1433         * tui/tui-out.h: Rename include guard.
1434         * tui/tui-layout.h: Rename include guard.
1435         * tui/tui-io.h: Rename include guard.
1436         * tui/tui-hooks.h: Rename include guard.
1437         * tui/tui-file.h: Rename include guard.
1438         * tui/tui-disasm.h: Rename include guard.
1439         * tui/tui-data.h: Rename include guard.
1440         * tui/tui-command.h: Rename include guard.
1441         * tic6x-tdep.h: Add include guard.
1442         * target/waitstatus.h: Rename include guard.
1443         * target/wait.h: Rename include guard.
1444         * target/target.h: Rename include guard.
1445         * target/resume.h: Rename include guard.
1446         * target-float.h: Rename include guard.
1447         * stabsread.h: Add include guard.
1448         * rs6000-tdep.h: Add include guard.
1449         * riscv-fbsd-tdep.h: Add include guard.
1450         * regformats/regdef.h: Rename include guard.
1451         * record.h: Rename include guard.
1452         * python/python.h: Rename include guard.
1453         * python/python-internal.h: Rename include guard.
1454         * python/py-stopevent.h: Rename include guard.
1455         * python/py-ref.h: Rename include guard.
1456         * python/py-record.h: Rename include guard.
1457         * python/py-record-full.h: Rename include guard.
1458         * python/py-record-btrace.h: Rename include guard.
1459         * python/py-instruction.h: Rename include guard.
1460         * python/py-events.h: Rename include guard.
1461         * python/py-event.h: Rename include guard.
1462         * procfs.h: Add include guard.
1463         * proc-utils.h: Add include guard.
1464         * p-lang.h: Add include guard.
1465         * or1k-tdep.h: Rename include guard.
1466         * observable.h: Rename include guard.
1467         * nto-tdep.h: Rename include guard.
1468         * nat/x86-linux.h: Rename include guard.
1469         * nat/x86-linux-dregs.h: Rename include guard.
1470         * nat/x86-gcc-cpuid.h: Add include guard.
1471         * nat/x86-dregs.h: Rename include guard.
1472         * nat/x86-cpuid.h: Rename include guard.
1473         * nat/ppc-linux.h: Rename include guard.
1474         * nat/mips-linux-watch.h: Rename include guard.
1475         * nat/linux-waitpid.h: Rename include guard.
1476         * nat/linux-ptrace.h: Rename include guard.
1477         * nat/linux-procfs.h: Rename include guard.
1478         * nat/linux-osdata.h: Rename include guard.
1479         * nat/linux-nat.h: Rename include guard.
1480         * nat/linux-namespaces.h: Rename include guard.
1481         * nat/linux-btrace.h: Rename include guard.
1482         * nat/glibc_thread_db.h: Rename include guard.
1483         * nat/gdb_thread_db.h: Rename include guard.
1484         * nat/gdb_ptrace.h: Rename include guard.
1485         * nat/fork-inferior.h: Rename include guard.
1486         * nat/amd64-linux-siginfo.h: Rename include guard.
1487         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
1488         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
1489         * nat/aarch64-linux.h: Rename include guard.
1490         * nat/aarch64-linux-hw-point.h: Rename include guard.
1491         * mn10300-tdep.h: Add include guard.
1492         * mips-linux-tdep.h: Add include guard.
1493         * mi/mi-parse.h: Rename include guard.
1494         * mi/mi-out.h: Rename include guard.
1495         * mi/mi-main.h: Rename include guard.
1496         * mi/mi-interp.h: Rename include guard.
1497         * mi/mi-getopt.h: Rename include guard.
1498         * mi/mi-console.h: Rename include guard.
1499         * mi/mi-common.h: Rename include guard.
1500         * mi/mi-cmds.h: Rename include guard.
1501         * mi/mi-cmd-break.h: Rename include guard.
1502         * m2-lang.h: Add include guard.
1503         * location.h: Rename include guard.
1504         * linux-record.h: Rename include guard.
1505         * linux-nat.h: Add include guard.
1506         * linux-fork.h: Add include guard.
1507         * i386-darwin-tdep.h: Rename include guard.
1508         * hppa-linux-offsets.h: Add include guard.
1509         * guile/guile.h: Rename include guard.
1510         * guile/guile-internal.h: Rename include guard.
1511         * gnu-nat.h: Rename include guard.
1512         * gdb-stabs.h: Rename include guard.
1513         * frv-tdep.h: Add include guard.
1514         * f-lang.h: Add include guard.
1515         * event-loop.h: Add include guard.
1516         * darwin-nat.h: Rename include guard.
1517         * cp-abi.h: Rename include guard.
1518         * config/sparc/nm-sol2.h: Rename include guard.
1519         * config/nm-nto.h: Rename include guard.
1520         * config/nm-linux.h: Add include guard.
1521         * config/i386/nm-i386gnu.h: Rename include guard.
1522         * config/djgpp/nl_types.h: Rename include guard.
1523         * config/djgpp/langinfo.h: Rename include guard.
1524         * compile/gcc-cp-plugin.h: Add include guard.
1525         * compile/gcc-c-plugin.h: Add include guard.
1526         * compile/compile.h: Rename include guard.
1527         * compile/compile-object-run.h: Rename include guard.
1528         * compile/compile-object-load.h: Rename include guard.
1529         * compile/compile-internal.h: Rename include guard.
1530         * compile/compile-cplus.h: Rename include guard.
1531         * compile/compile-c.h: Rename include guard.
1532         * common/xml-utils.h: Rename include guard.
1533         * common/x86-xstate.h: Rename include guard.
1534         * common/version.h: Rename include guard.
1535         * common/vec.h: Rename include guard.
1536         * common/tdesc.h: Rename include guard.
1537         * common/selftest.h: Rename include guard.
1538         * common/scoped_restore.h: Rename include guard.
1539         * common/scoped_mmap.h: Rename include guard.
1540         * common/scoped_fd.h: Rename include guard.
1541         * common/safe-iterator.h: Rename include guard.
1542         * common/run-time-clock.h: Rename include guard.
1543         * common/refcounted-object.h: Rename include guard.
1544         * common/queue.h: Rename include guard.
1545         * common/ptid.h: Rename include guard.
1546         * common/print-utils.h: Rename include guard.
1547         * common/preprocessor.h: Rename include guard.
1548         * common/pathstuff.h: Rename include guard.
1549         * common/observable.h: Rename include guard.
1550         * common/netstuff.h: Rename include guard.
1551         * common/job-control.h: Rename include guard.
1552         * common/host-defs.h: Rename include guard.
1553         * common/gdb_wait.h: Rename include guard.
1554         * common/gdb_vecs.h: Rename include guard.
1555         * common/gdb_unlinker.h: Rename include guard.
1556         * common/gdb_unique_ptr.h: Rename include guard.
1557         * common/gdb_tilde_expand.h: Rename include guard.
1558         * common/gdb_sys_time.h: Rename include guard.
1559         * common/gdb_string_view.h: Rename include guard.
1560         * common/gdb_splay_tree.h: Rename include guard.
1561         * common/gdb_setjmp.h: Rename include guard.
1562         * common/gdb_ref_ptr.h: Rename include guard.
1563         * common/gdb_optional.h: Rename include guard.
1564         * common/gdb_locale.h: Rename include guard.
1565         * common/gdb_assert.h: Rename include guard.
1566         * common/filtered-iterator.h: Rename include guard.
1567         * common/filestuff.h: Rename include guard.
1568         * common/fileio.h: Rename include guard.
1569         * common/environ.h: Rename include guard.
1570         * common/common-utils.h: Rename include guard.
1571         * common/common-types.h: Rename include guard.
1572         * common/common-regcache.h: Rename include guard.
1573         * common/common-inferior.h: Rename include guard.
1574         * common/common-gdbthread.h: Rename include guard.
1575         * common/common-exceptions.h: Rename include guard.
1576         * common/common-defs.h: Rename include guard.
1577         * common/common-debug.h: Rename include guard.
1578         * common/cleanups.h: Rename include guard.
1579         * common/buffer.h: Rename include guard.
1580         * common/btrace-common.h: Rename include guard.
1581         * common/break-common.h: Rename include guard.
1582         * cli/cli-utils.h: Rename include guard.
1583         * cli/cli-style.h: Rename include guard.
1584         * cli/cli-setshow.h: Rename include guard.
1585         * cli/cli-script.h: Rename include guard.
1586         * cli/cli-interp.h: Rename include guard.
1587         * cli/cli-decode.h: Rename include guard.
1588         * cli/cli-cmds.h: Rename include guard.
1589         * charset-list.h: Add include guard.
1590         * buildsym-legacy.h: Rename include guard.
1591         * bfin-tdep.h: Add include guard.
1592         * ax.h: Rename include guard.
1593         * arm-linux-tdep.h: Add include guard.
1594         * arm-fbsd-tdep.h: Add include guard.
1595         * arch/xtensa.h: Rename include guard.
1596         * arch/tic6x.h: Add include guard.
1597         * arch/i386.h: Add include guard.
1598         * arch/arm.h: Rename include guard.
1599         * arch/arm-linux.h: Rename include guard.
1600         * arch/arm-get-next-pcs.h: Rename include guard.
1601         * arch/amd64.h: Add include guard.
1602         * arch/aarch64-insn.h: Rename include guard.
1603         * arch-utils.h: Rename include guard.
1604         * annotate.h: Add include guard.
1605         * amd64-darwin-tdep.h: Rename include guard.
1606         * aarch64-linux-tdep.h: Add include guard.
1607         * aarch64-fbsd-tdep.h: Add include guard.
1608         * aarch32-linux-nat.h: Add include guard.
1609
1610 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1611
1612         * macrotab.c (macro_define_internal): New function that
1613         factorizes macro_define_object_internal and macro_define_function
1614         code.
1615         (macro_define_object_internal): Use macro_define_internal.
1616         (macro_define_function): Likewise.
1617
1618 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1619
1620         * macrocmd.c (extract_identifier): Return
1621         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
1622         callers.
1623
1624 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
1625
1626         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
1627
1628 2019-02-05  Tom Tromey  <tom@tromey.com>
1629
1630         * target.c (target_stack::unpush): Move assertion earlier.
1631
1632 2019-01-30  Tom Tromey  <tom@tromey.com>
1633
1634         PR python/23615:
1635         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
1636         (gdbpy_parse_and_eval): Likewise.
1637         * python/python-internal.h (gdbpy_allow_threads): New class.
1638
1639 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
1640
1641         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
1642         (aarch64_fbsd_fpregmap): Move earlier.
1643         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
1644         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1645         instead of individual calls to trad_frame_set_reg_addr.
1646         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
1647         earlier.
1648         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
1649         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1650         instead of individual calls to trad_frame_set_reg_addr.
1651
1652 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
1653
1654         * CONTRIBUTE: Replace contribution list with wiki link.
1655
1656 2019-01-25  Tom Tromey  <tom@tromey.com>
1657
1658         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
1659
1660 2019-01-25  Tom Tromey  <tom@tromey.com>
1661
1662         * xtensa-linux-nat.c: Fix common/ includes.
1663         * xml-support.h: Fix common/ includes.
1664         * xml-support.c: Fix common/ includes.
1665         * x86-linux-nat.c: Fix common/ includes.
1666         * windows-nat.c: Fix common/ includes.
1667         * varobj.h: Fix common/ includes.
1668         * varobj.c: Fix common/ includes.
1669         * value.c: Fix common/ includes.
1670         * valops.c: Fix common/ includes.
1671         * utils.c: Fix common/ includes.
1672         * unittests/xml-utils-selftests.c: Fix common/ includes.
1673         * unittests/utils-selftests.c: Fix common/ includes.
1674         * unittests/unpack-selftests.c: Fix common/ includes.
1675         * unittests/tracepoint-selftests.c: Fix common/ includes.
1676         * unittests/style-selftests.c: Fix common/ includes.
1677         * unittests/string_view-selftests.c: Fix common/ includes.
1678         * unittests/scoped_restore-selftests.c: Fix common/ includes.
1679         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
1680         * unittests/scoped_fd-selftests.c: Fix common/ includes.
1681         * unittests/rsp-low-selftests.c: Fix common/ includes.
1682         * unittests/parse-connection-spec-selftests.c: Fix common/
1683         includes.
1684         * unittests/optional-selftests.c: Fix common/ includes.
1685         * unittests/offset-type-selftests.c: Fix common/ includes.
1686         * unittests/observable-selftests.c: Fix common/ includes.
1687         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
1688         * unittests/memrange-selftests.c: Fix common/ includes.
1689         * unittests/memory-map-selftests.c: Fix common/ includes.
1690         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
1691         * unittests/function-view-selftests.c: Fix common/ includes.
1692         * unittests/environ-selftests.c: Fix common/ includes.
1693         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
1694         * unittests/common-utils-selftests.c: Fix common/ includes.
1695         * unittests/cli-utils-selftests.c: Fix common/ includes.
1696         * unittests/array-view-selftests.c: Fix common/ includes.
1697         * ui-file.c: Fix common/ includes.
1698         * tui/tui-io.c: Fix common/ includes.
1699         * tracepoint.h: Fix common/ includes.
1700         * tracepoint.c: Fix common/ includes.
1701         * tracefile-tfile.c: Fix common/ includes.
1702         * top.h: Fix common/ includes.
1703         * top.c: Fix common/ includes.
1704         * thread.c: Fix common/ includes.
1705         * target/waitstatus.h: Fix common/ includes.
1706         * target/waitstatus.c: Fix common/ includes.
1707         * target.h: Fix common/ includes.
1708         * target.c: Fix common/ includes.
1709         * target-memory.c: Fix common/ includes.
1710         * target-descriptions.c: Fix common/ includes.
1711         * symtab.h: Fix common/ includes.
1712         * symfile.c: Fix common/ includes.
1713         * stap-probe.c: Fix common/ includes.
1714         * spu-linux-nat.c: Fix common/ includes.
1715         * sparc-nat.c: Fix common/ includes.
1716         * source.c: Fix common/ includes.
1717         * solib.c: Fix common/ includes.
1718         * solib-target.c: Fix common/ includes.
1719         * ser-unix.c: Fix common/ includes.
1720         * ser-tcp.c: Fix common/ includes.
1721         * ser-pipe.c: Fix common/ includes.
1722         * ser-base.c: Fix common/ includes.
1723         * selftest-arch.c: Fix common/ includes.
1724         * s12z-tdep.c: Fix common/ includes.
1725         * rust-exp.y: Fix common/ includes.
1726         * rs6000-aix-tdep.c: Fix common/ includes.
1727         * riscv-tdep.c: Fix common/ includes.
1728         * remote.c: Fix common/ includes.
1729         * remote-notif.h: Fix common/ includes.
1730         * remote-fileio.h: Fix common/ includes.
1731         * remote-fileio.c: Fix common/ includes.
1732         * regcache.h: Fix common/ includes.
1733         * regcache.c: Fix common/ includes.
1734         * record-btrace.c: Fix common/ includes.
1735         * python/python.c: Fix common/ includes.
1736         * python/py-type.c: Fix common/ includes.
1737         * python/py-inferior.c: Fix common/ includes.
1738         * progspace.h: Fix common/ includes.
1739         * producer.c: Fix common/ includes.
1740         * procfs.c: Fix common/ includes.
1741         * proc-api.c: Fix common/ includes.
1742         * printcmd.c: Fix common/ includes.
1743         * ppc-linux-nat.c: Fix common/ includes.
1744         * parser-defs.h: Fix common/ includes.
1745         * osdata.c: Fix common/ includes.
1746         * obsd-nat.c: Fix common/ includes.
1747         * nat/x86-linux.c: Fix common/ includes.
1748         * nat/x86-linux-dregs.c: Fix common/ includes.
1749         * nat/x86-dregs.h: Fix common/ includes.
1750         * nat/x86-dregs.c: Fix common/ includes.
1751         * nat/ppc-linux.c: Fix common/ includes.
1752         * nat/mips-linux-watch.h: Fix common/ includes.
1753         * nat/mips-linux-watch.c: Fix common/ includes.
1754         * nat/linux-waitpid.c: Fix common/ includes.
1755         * nat/linux-ptrace.h: Fix common/ includes.
1756         * nat/linux-ptrace.c: Fix common/ includes.
1757         * nat/linux-procfs.c: Fix common/ includes.
1758         * nat/linux-personality.c: Fix common/ includes.
1759         * nat/linux-osdata.c: Fix common/ includes.
1760         * nat/linux-namespaces.c: Fix common/ includes.
1761         * nat/linux-btrace.h: Fix common/ includes.
1762         * nat/linux-btrace.c: Fix common/ includes.
1763         * nat/fork-inferior.c: Fix common/ includes.
1764         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1765         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1766         * nat/aarch64-linux.c: Fix common/ includes.
1767         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1768         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1769         * namespace.h: Fix common/ includes.
1770         * mips-linux-tdep.c: Fix common/ includes.
1771         * minsyms.c: Fix common/ includes.
1772         * mi/mi-parse.h: Fix common/ includes.
1773         * mi/mi-main.c: Fix common/ includes.
1774         * mi/mi-cmd-env.c: Fix common/ includes.
1775         * memrange.h: Fix common/ includes.
1776         * memattr.c: Fix common/ includes.
1777         * maint.h: Fix common/ includes.
1778         * maint.c: Fix common/ includes.
1779         * main.c: Fix common/ includes.
1780         * machoread.c: Fix common/ includes.
1781         * location.c: Fix common/ includes.
1782         * linux-thread-db.c: Fix common/ includes.
1783         * linux-nat.c: Fix common/ includes.
1784         * linux-fork.c: Fix common/ includes.
1785         * inline-frame.c: Fix common/ includes.
1786         * infrun.c: Fix common/ includes.
1787         * inflow.c: Fix common/ includes.
1788         * inferior.h: Fix common/ includes.
1789         * inferior.c: Fix common/ includes.
1790         * infcmd.c: Fix common/ includes.
1791         * inf-ptrace.c: Fix common/ includes.
1792         * inf-child.c: Fix common/ includes.
1793         * ia64-linux-nat.c: Fix common/ includes.
1794         * i387-tdep.c: Fix common/ includes.
1795         * i386-tdep.c: Fix common/ includes.
1796         * i386-linux-tdep.c: Fix common/ includes.
1797         * i386-linux-nat.c: Fix common/ includes.
1798         * i386-go32-tdep.c: Fix common/ includes.
1799         * i386-fbsd-tdep.c: Fix common/ includes.
1800         * i386-fbsd-nat.c: Fix common/ includes.
1801         * guile/scm-type.c: Fix common/ includes.
1802         * guile/guile.c: Fix common/ includes.
1803         * go32-nat.c: Fix common/ includes.
1804         * gnu-nat.c: Fix common/ includes.
1805         * gdbthread.h: Fix common/ includes.
1806         * gdbarch-selftests.c: Fix common/ includes.
1807         * gdb_usleep.c: Fix common/ includes.
1808         * gdb_select.h: Fix common/ includes.
1809         * gdb_bfd.c: Fix common/ includes.
1810         * gcore.c: Fix common/ includes.
1811         * fork-child.c: Fix common/ includes.
1812         * findvar.c: Fix common/ includes.
1813         * fbsd-nat.c: Fix common/ includes.
1814         * event-top.c: Fix common/ includes.
1815         * event-loop.c: Fix common/ includes.
1816         * dwarf2read.c: Fix common/ includes.
1817         * dwarf2loc.c: Fix common/ includes.
1818         * dwarf2-frame.c: Fix common/ includes.
1819         * dwarf-index-cache.c: Fix common/ includes.
1820         * dtrace-probe.c: Fix common/ includes.
1821         * disasm-selftests.c: Fix common/ includes.
1822         * defs.h: Fix common/ includes.
1823         * csky-tdep.c: Fix common/ includes.
1824         * cp-valprint.c: Fix common/ includes.
1825         * cp-support.h: Fix common/ includes.
1826         * cp-support.c: Fix common/ includes.
1827         * corelow.c: Fix common/ includes.
1828         * completer.h: Fix common/ includes.
1829         * completer.c: Fix common/ includes.
1830         * compile/compile.c: Fix common/ includes.
1831         * compile/compile-loc2c.c: Fix common/ includes.
1832         * compile/compile-cplus-types.c: Fix common/ includes.
1833         * compile/compile-cplus-symbols.c: Fix common/ includes.
1834         * command.h: Fix common/ includes.
1835         * cli/cli-dump.c: Fix common/ includes.
1836         * cli/cli-cmds.c: Fix common/ includes.
1837         * charset.c: Fix common/ includes.
1838         * build-id.c: Fix common/ includes.
1839         * btrace.h: Fix common/ includes.
1840         * btrace.c: Fix common/ includes.
1841         * breakpoint.h: Fix common/ includes.
1842         * breakpoint.c: Fix common/ includes.
1843         * ax.h:
1844         (enum agent_op): Fix common/ includes.
1845         * ax-general.c (struct aop_map): Fix common/ includes.
1846         * ax-gdb.c: Fix common/ includes.
1847         * auxv.c: Fix common/ includes.
1848         * auto-load.c: Fix common/ includes.
1849         * arm-tdep.c: Fix common/ includes.
1850         * arch/riscv.c: Fix common/ includes.
1851         * arch/ppc-linux-common.c: Fix common/ includes.
1852         * arch/i386.c: Fix common/ includes.
1853         * arch/arm.c: Fix common/ includes.
1854         * arch/arm-linux.c: Fix common/ includes.
1855         * arch/arm-get-next-pcs.c: Fix common/ includes.
1856         * arch/amd64.c: Fix common/ includes.
1857         * arch/aarch64.c: Fix common/ includes.
1858         * arch/aarch64-insn.c: Fix common/ includes.
1859         * arch-utils.c: Fix common/ includes.
1860         * amd64-windows-tdep.c: Fix common/ includes.
1861         * amd64-tdep.c: Fix common/ includes.
1862         * amd64-sol2-tdep.c: Fix common/ includes.
1863         * amd64-obsd-tdep.c: Fix common/ includes.
1864         * amd64-nbsd-tdep.c: Fix common/ includes.
1865         * amd64-linux-tdep.c: Fix common/ includes.
1866         * amd64-linux-nat.c: Fix common/ includes.
1867         * amd64-fbsd-tdep.c: Fix common/ includes.
1868         * amd64-fbsd-nat.c: Fix common/ includes.
1869         * amd64-dicos-tdep.c: Fix common/ includes.
1870         * amd64-darwin-tdep.c: Fix common/ includes.
1871         * agent.c: Fix common/ includes.
1872         * ada-lang.h: Fix common/ includes.
1873         * ada-lang.c: Fix common/ includes.
1874         * aarch64-tdep.c: Fix common/ includes.
1875
1876 2019-01-25  Tom Tromey  <tom@tromey.com>
1877
1878         * common/create-version.sh: Use common/version.h.
1879
1880 2019-01-24  Pedro Alves  <palves@redhat.com>
1881
1882         * infrun.c (signal_stop, signal_print, signal_program)
1883         (signal_catch, signal_pass): Now arrays instead of pointers.
1884         (update_signals_program_target, do_target_resume)
1885         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1886         * linux-nat.c (linux_nat_target::pass_signals)
1887         (linux_nat_target::create_inferior, linux_nat_target::attach):
1888         Adjust.
1889         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1890         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1891         * procfs.c (procfs_target::pass_signals): Adjust.
1892         * record-full.c (record_full_target::resume): Adjust.
1893         * remote.c (remote_target::pass_signals)
1894         (remote_target::program_signals): Adjust.
1895         * target-debug.h (target_debug_print_signals): Now takes a
1896         gdb::array_view as parameter.  Adjust.
1897         * target.h (target_ops) <pass_signals, program_signals>: Replace
1898         pointer and length parameters with gdb::array_view.
1899         (target_pass_signals, target_program_signals): Likewise.
1900         * target-delegates.c: Regenerate.
1901
1902 2019-01-24  Pedro Alves  <palves@redhat.com>
1903
1904         * common/forward-scope-exit.h
1905         (forward_scope_exit::forward_scope_exit): Pass arguments to
1906         m_bind_function directly, instead of creating a std::bind and
1907         copying that.
1908
1909 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1910
1911         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1912         for static members.
1913         (pass_in_v_vfp_candidate): Likewise.
1914
1915 2019-01-23  Tom Tromey  <tom@tromey.com>
1916             Pedro Alves  <palves@redhat.com>
1917
1918         * regcache.c (class regcache_invalidator): Remove.
1919         (regcache::raw_write): Use make_scope_exit.
1920
1921 2019-01-23  Tom Tromey  <tom@tromey.com>
1922
1923         * ui-out.h (class ui_out_emit_type): Update comment.
1924
1925 2019-01-23  Tom Tromey  <tom@tromey.com>
1926
1927         * infrun.c (fetch_inferior_event): Update comment.
1928
1929 2019-01-23  Tom Tromey  <tom@tromey.com>
1930             Pedro Alves  <palves@redhat.com>
1931
1932         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1933         parameter.
1934         (fetch_inferior_event): Use SCOPE_EXIT.
1935
1936
1937 2019-01-23  Tom Tromey  <tom@tromey.com>
1938             Pedro Alves  <palves@redhat.com>
1939
1940         * infrun.c (disable_thread_events): Delete.
1941         (stop_all_threads): Use SCOPE_EXIT.
1942
1943 2019-01-23  Tom Tromey  <tom@tromey.com>
1944             Pedro Alves  <palves@redhat.com>
1945
1946         * symfile.c: Include forward-scope-exit.h.
1947         (clear_symtab_users_cleanup): Replace forward declaration with
1948         a FORWARD_SCOPE_EXIT.
1949         (syms_from_objfile_1): Use the forward_scope_exit and
1950         gdb::optional instead of cleanup_function.
1951         (reread_symbols): Use the forward_scope_exit instead of
1952         cleanup_function.
1953         (clear_symtab_users_cleanup): Remove function.
1954
1955 2019-01-23  Tom Tromey  <tom@tromey.com>
1956             Pedro Alves  <palves@redhat.com>
1957
1958         * linux-nat.c: Include scope-exit.h.
1959         (cleanup_target_stop): Remove.
1960         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1961         SCOPE_EXIT.
1962
1963 2019-01-23  Tom Tromey  <tom@tromey.com>
1964             Pedro Alves  <palves@redhat.com>
1965
1966         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1967         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1968
1969 2019-01-23  Tom Tromey  <tom@tromey.com>
1970             Andrew Burgess  <andrew.burgess@embecosm.com>
1971             Pedro Alves  <palves@redhat.com>
1972
1973         * infrun.c (fetch_inferior_event): Use scope_exit.
1974         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1975         * top.c (execute_command): Use scope_exit.
1976         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1977         * utils.c (do_bpstat_clear_actions_cleanup)
1978         (make_bpstat_clear_actions_cleanup): Remove.
1979
1980 2019-01-23  Tom Tromey  <tom@tromey.com>
1981             Pedro Alves  <palves@redhat.com>
1982
1983         * infrun.c: Include "common/scope-exit.h"
1984         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1985         (wait_for_inferior): Use SCOPE_EXIT.
1986         (fetch_inferior_event): Use scope_exit.
1987
1988 2019-01-23  Tom Tromey  <tom@tromey.com>
1989             Pedro Alves  <palves@redhat.com>
1990
1991         * breakpoint.c (create_breakpoint): Remove cleanup.
1992
1993 2019-01-23  Tom Tromey  <tom@tromey.com>
1994             Andrew Burgess  <andrew.burgess@embecosm.com>
1995             Pedro Alves  <palves@redhat.com>
1996
1997 2019-01-23  Pedro Alves  <palves@redhat.com>
1998
1999         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
2000
2001 2019-01-23  Pedro Alves  <palves@redhat.com>
2002             Andrew Burgess  <andrew.burgess@embecosm.com>
2003
2004         * gdbthread.h: Include "common/forward-scope-exit.h".
2005         (scoped_finish_thread_state): Redefine custom class in terms of
2006         forward_scope_exit.
2007
2008 2019-01-23  Pedro Alves  <palves@redhat.com>
2009             Andrew Burgess  <andrew.burgess@embecosm.com>
2010
2011         * common/forward-scope-exit.h: New file.
2012
2013 2019-01-23  Pedro Alves  <palves@redhat.com>
2014             Andrew Burgess  <andrew.burgess@embecosm.com>
2015             Tom Tromey  <tom@tromey.com>
2016
2017         * common/scope-exit.h: New file.
2018
2019 2019-01-23  Pedro Alves  <palves@redhat.com>
2020
2021         * common/preprocessor.h (ESC): Rename to ...
2022         (ESC_PARENS): ... this.
2023         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
2024         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
2025
2026 2019-01-23  Tom Tromey  <tom@tromey.com>
2027
2028         * language.h (class scoped_switch_to_sym_language_if_auto):
2029         Initialize m_lang in both cases.
2030
2031 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
2032
2033         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
2034         with XCNEW.
2035
2036 2019-01-22  Tom Tromey  <tom@tromey.com>
2037
2038         * corelow.c: Do not include sys/file.h.
2039
2040 2019-01-22  Tom Tromey  <tom@tromey.com>
2041
2042         * tui/tui-wingeneral.h: Include gdb_curses.h.
2043
2044 2019-01-22  Tom Tromey  <tom@tromey.com>
2045
2046         * source-cache.h (class source_cache) <get_source_lines,
2047         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
2048
2049 2019-01-22  Tom Tromey  <tom@tromey.com>
2050
2051         * remote-fileio.h (struct remote_target): Declare.
2052
2053 2019-01-22  Tom Tromey  <tom@tromey.com>
2054
2055         * python/py-arch.c: Do not include py-ref.h.
2056         * python/py-bpevent.c: Do not include py-ref.h.
2057         * python/py-cmd.c: Do not include py-ref.h.
2058         * python/py-continueevent.c: Do not include py-ref.h.
2059         * python/py-event.h: Do not include py-ref.h.
2060         * python/py-evtregistry.c: Do not include py-ref.h.
2061         * python/py-finishbreakpoint.c: Do not include py-ref.h.
2062         * python/py-frame.c: Do not include py-ref.h.
2063         * python/py-framefilter.c: Do not include py-ref.h.
2064         * python/py-function.c: Do not include py-ref.h.
2065         * python/py-infevents.c: Do not include py-ref.h.
2066         * python/py-linetable.c: Do not include py-ref.h.
2067         * python/py-objfile.c: Do not include py-ref.h.
2068         * python/py-param.c: Do not include py-ref.h.
2069         * python/py-prettyprint.c: Do not include py-ref.h.
2070         * python/py-progspace.c: Do not include py-ref.h.
2071         * python/py-symbol.c: Do not include py-ref.h.
2072         * python/py-symtab.c: Do not include py-ref.h.
2073         * python/py-type.c: Do not include py-ref.h.
2074         * python/py-unwind.c: Do not include py-ref.h.
2075         * python/py-utils.c: Do not include py-ref.h.
2076         * python/py-value.c: Do not include py-ref.h.
2077         * python/py-varobj.c: Do not include py-ref.h.
2078         * python/py-xmethods.c: Do not include py-ref.h.
2079         * python/python.c: Do not include py-ref.h.
2080         * varobj.c: Do not include py-ref.h.
2081
2082 2019-01-22  Tom Tromey  <tom@tromey.com>
2083
2084         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
2085         keyword for bcache.
2086
2087 2019-01-22  Tom Tromey  <tom@tromey.com>
2088
2089         * compile/compile-cplus-types.c: Remove a comment by #include.
2090
2091 2019-01-22  Tom Tromey  <tom@tromey.com>
2092
2093         * compile/gcc-c-plugin.h: Include compile-internal.h.
2094
2095 2019-01-22  Tom Tromey  <tom@tromey.com>
2096
2097         * stabsread.c (EXTERN): Do not define.
2098         (symnum, next_symbol_text_func, processing_gcc_compilation)
2099         (within_function, global_sym_chain, global_stabs)
2100         (previous_stab_code, this_object_header_files)
2101         (n_this_object_header_files)
2102         (n_allocated_this_object_header_files): Define.
2103         * stabsread.h (EXTERN): Never define.  Use "extern".
2104
2105 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2106
2107         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
2108         history_value.
2109
2110 2019-01-21  Tom Tromey  <tom@tromey.com>
2111
2112         * ui-out.c: Fix includes.
2113         * tui/tui-source.c: Fix includes.
2114         * target.c: Fix includes.
2115         * remote.c: Fix includes.
2116         * regcache.c: Fix includes.
2117         * python/py-block.c: Fix includes.
2118         * printcmd.c: Fix includes.
2119         * or1k-tdep.c: Fix includes.
2120         * mi/mi-main.c: Fix includes.
2121         * m32r-tdep.c: Fix includes.
2122         * csky-tdep.c: Fix includes.
2123         * compile/compile-cplus-types.c: Fix includes.
2124         * cli/cli-interp.c: Fix includes.
2125
2126 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
2127
2128         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2129         for padding.
2130
2131 2019-01-16  Tom Tromey  <tom@tromey.com>
2132
2133         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
2134         earlier.
2135         (struct objfile) <msymbols_range>: Move from top level.
2136         <msymbols>: New method.
2137         (class objfile_msymbols): Remove.
2138         * symtab.c (default_collect_symbol_completion_matches_break_on):
2139         Update.
2140         * symmisc.c (dump_msymbols): Update.
2141         * stabsread.c (scan_file_globals): Update.
2142         * objc-lang.c (info_selectors_command, info_classes_command)
2143         (find_methods): Update.
2144         * minsyms.c (find_solib_trampoline_target): Update.
2145         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2146         * coffread.c (coff_symfile_read): Update.
2147         * ada-lang.c (ada_lookup_simple_minsym)
2148         (ada_collect_symbol_completion_matches): Update.
2149
2150 2019-01-16  Tom Tromey  <tom@tromey.com>
2151
2152         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
2153         type.  Remove no-argument constructor.
2154         <iterator::operator++>: Simplify.
2155         <begin>: Update.
2156         <end>: Use minimal_symbol_count.
2157
2158 2019-01-16  Tom Tromey  <tom@tromey.com>
2159
2160         * objfiles.h (struct objfile) <psymtabs>: New method.
2161         (class objfile_psymtabs): Remove.
2162         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
2163         typedef.
2164         <range>: New method.
2165         (require_partial_symbols): Change return type.
2166         * psymtab.c (require_partial_symbols)
2167         (psym_expand_symtabs_matching): Update.
2168         * mdebugread.c (parse_partial_symbols): Update.
2169         * dbxread.c (dbx_end_psymtab): Update.
2170
2171 2019-01-15  Tom Tromey  <tom@tromey.com>
2172
2173         * symtab.c (lookup_objfile_from_block)
2174         (lookup_symbol_in_objfile_symtabs)
2175         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
2176         (find_line_symtab, info_sources_command)
2177         (default_collect_symbol_completion_matches_break_on)
2178         (make_source_files_completion_list): Update.
2179         * symmisc.c (print_objfile_statistics, dump_objfile)
2180         (maintenance_print_symbols, maintenance_info_symtabs)
2181         (maintenance_check_symtabs, maintenance_info_line_tables):
2182         Update.
2183         * source.c (select_source_symtab)
2184         (forget_cached_source_info_for_objfile): Update.
2185         * objfiles.h (class objfile_compunits): Remove.
2186         (struct objfile) <compunits_range>: New typedef.
2187         (compunits): New method.
2188         * objfiles.c (objfile_relocate1): Update.
2189         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2190         * maint.c (count_symtabs_and_blocks): Update.
2191         * linespec.c (iterate_over_all_matching_symtabs): Update.
2192         * cp-support.c (add_symbol_overload_list_qualified): Update.
2193         * coffread.c (coff_symtab_read): Update.
2194         * ada-lang.c (add_nonlocal_symbols)
2195         (ada_collect_symbol_completion_matches)
2196         (ada_add_global_exceptions): Update.
2197
2198 2019-01-15  Tom Tromey  <tom@tromey.com>
2199
2200         * progspace.h (program_space) <objfiles_safe_range>: New
2201         typedef.
2202         <objfiles_safe>: New method.
2203         * objfiles.h (class all_objfiles_safe): Remove.
2204         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
2205         * jit.c (jit_inferior_exit_hook): Update.
2206
2207 2019-01-17  Tom Tromey  <tom@tromey.com>
2208
2209         * progspace.h (program_space) <objfiles_range>: New typedef.
2210         <objfiles>: New method.
2211         <objfiles_head>: Rename from objfiles.
2212         (object_files): Update.
2213         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
2214         * guile/scm-pretty-print.c
2215         (ppscm_find_pretty_printer_from_objfiles): Update.
2216         * guile/scm-objfile.c (gdbscm_objfiles): Update.
2217         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
2218         Update.
2219         * python/py-progspace.c (pspy_get_objfiles): Update.
2220         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2221         Update.
2222         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2223         (objfpy_lookup_objfile_by_build_id): Update.
2224         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2225         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2226         Update.
2227         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2228         (expand_symtab_containing_pc, lookup_objfile_from_block)
2229         (lookup_static_symbol, basic_lookup_transparent_type)
2230         (find_pc_sect_compunit_symtab, find_symbol_at_address)
2231         (find_line_symtab, info_sources_command)
2232         (default_collect_symbol_completion_matches_break_on)
2233         (make_source_files_completion_list, find_main_name): Update.
2234         * symmisc.c (print_symbol_bcache_statistics)
2235         (print_objfile_statistics, maintenance_print_symbols)
2236         (maintenance_print_msymbols, maintenance_print_objfiles)
2237         (maintenance_info_symtabs, maintenance_check_symtabs)
2238         (maintenance_expand_symtabs, maintenance_info_line_tables):
2239         Update.
2240         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
2241         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
2242         (map_overlay_command, unmap_overlay_command)
2243         (simple_overlay_update, expand_symtabs_matching)
2244         (map_symbol_filenames): Update.
2245         * symfile-debug.c (set_debug_symfile): Update.
2246         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
2247         Update.
2248         * source.c (select_source_symtab, forget_cached_source_info):
2249         Update.
2250         * solib.c (solib_read_symbols): Update.
2251         * solib-spu.c (append_ocl_sos): Update.
2252         * psymtab.c (maintenance_print_psymbols)
2253         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
2254         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
2255         * printcmd.c (info_symbol_command): Update.
2256         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
2257         Update.
2258         * objfiles.h (class all_objfiles): Remove.
2259         * objfiles.c (have_partial_symbols, have_full_symbols)
2260         (have_minimal_symbols, qsort_cmp, update_section_map)
2261         (shared_objfile_contains_address_p)
2262         (default_iterate_over_objfiles_in_search_order): Update.
2263         * objc-lang.c (info_selectors_command, info_classes_command)
2264         (find_methods): Update.
2265         * minsyms.c (find_solib_trampoline_target): Update.
2266         * maint.c (maintenance_info_sections)
2267         (maintenance_translate_address, count_symtabs_and_blocks):
2268         Update.
2269         * main.c (captured_main_1): Update.
2270         * linux-thread-db.c (try_thread_db_load_from_pdir)
2271         (has_libpthread): Update.
2272         * linespec.c (iterate_over_all_matching_symtabs)
2273         (search_minsyms_for_name): Update.
2274         * jit.c (jit_find_objf_with_entry_addr): Update.
2275         * hppa-tdep.c (find_unwind_entry)
2276         (hppa_lookup_stub_minimal_symbol): Update.
2277         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
2278         Update.
2279         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2280         (elf_gnu_ifunc_resolve_by_got): Update.
2281         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
2282         * dwarf-index-write.c (save_gdb_index_command): Update.
2283         * cp-support.c (add_symbol_overload_list_qualified): Update.
2284         * breakpoint.c (create_overlay_event_breakpoint)
2285         (create_longjmp_master_breakpoint)
2286         (create_std_terminate_master_breakpoint)
2287         (create_exception_master_breakpoint): Update.
2288         * blockframe.c (find_pc_partial_function): Update.
2289         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
2290         (ada_collect_symbol_completion_matches)
2291         (ada_add_global_exceptions): Update.
2292
2293 2019-01-17  Tom Tromey  <tom@tromey.com>
2294
2295         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
2296         declare VEC.
2297         (solib_target_parse_libraries): Change return type.
2298         (library_list_start_segment, library_list_start_section)
2299         (library_list_end_library, library_list_start_library); Update.
2300         (solib_target_free_library_list): Remove.
2301         (solib_target_parse_libraries): Remove cleanup.  Change return
2302         type.
2303         (solib_target_current_sos): Update.
2304
2305 2019-01-17  Tom Tromey  <tromey@bapiya>
2306
2307         * valprint.c: Replace "the the" with "the".
2308         * symtab.c: Replace "the the" with "the".
2309         * solib.c: Replace "the the" with "the".
2310         * solib-dsbt.c: Replace "the the" with "the".
2311         * linespec.c: Replace "the the" with "the".
2312         * dwarf2loc.h: Replace "the the" with "the".
2313         * amd64-windows-tdep.c: Replace "the the" with "the".
2314         * aarch64-tdep.c: Replace "the the" with "the".
2315
2316 2019-01-16  Keith Seitz  <keiths@redhat.com>
2317
2318         PR gdb/23773
2319         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
2320         <builder>: Rename to ..
2321         <m_builder>: ... this and make private.
2322         (dwarf2_cu::get_builder): New method.  Change all users of
2323         `builder' to use this method.
2324         (dwarf2_start_symtab): Move to ...
2325         (dwarf2_cu::start_symtab): ... here.  Update all callers
2326         (setup_type_unit_groups): Move to ...
2327         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
2328         callers.
2329         (dwarf2_cu::reset_builder): New method.
2330         (process_full_compunit, process_full_type_unit): Use
2331         dwarf2_cu::reset_builder.
2332         (follow_die_offset): Record the ancestor CU if it is different
2333         from the followed DIE's CU.
2334         (follow_die_sig_1): Likewise.
2335
2336 2019-01-15  Tom Tromey  <tom@tromey.com>
2337
2338         * remote.c (class remote_state) <buf>: Now a char_vector.
2339         <buf_size>: Remove.
2340         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
2341         parameter.
2342         (remote_target::getpkt_or_notif_sane_1)
2343         (remote_target::getpkt_sane)
2344         (remote_target::getpkt_or_notif_sane): Likewise.
2345         (class remote_target) <putpkt>: New overload.
2346         (remote_target::read_frame): Change type of "buf_p".  Remove
2347         sizeof_p parameter.
2348         (packet_ok): New overload.
2349         (packet_check_result): New overload.
2350         Update all uses.
2351
2352 2019-01-14  Tom Tromey  <tom@tromey.com>
2353
2354         * remote-notif.c (handle_notification, remote_notif_ack)
2355         (remote_notif_parse): Make "buf" const.
2356         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
2357         const.
2358         (remote_notif_parse, remote_notif_ack, handle_notification):
2359         Likewise.
2360         * remote.c (remote_notif_stop_parse): Make "buf" const.
2361         (remote_target::remote_parse_stop_reply): Make "buf" const.
2362         (remote_notif_stop_ack): Make "buf" const.
2363
2364 2019-01-14  Tom Tromey  <tom@tromey.com>
2365
2366         * remote.c (remote_console_output): Make parameter const.
2367
2368 2019-01-14  Tom Tromey  <tom@tromey.com>
2369
2370         * target-debug.h (target_debug_print_signals): Constify.
2371         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
2372         * procfs.c (procfs_target::pass_signals): Update.
2373         * linux-nat.c (linux_nat_target::pass_signals): Update.
2374         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
2375         * target-delegates.c: Rebuild.
2376         * remote.c (remote_target::program_signals): Update.
2377         (remote_target::pass_signals): Update.
2378         * target.c (target_pass_signals): Constify argument.
2379         (target_program_signals): Likewise.
2380         * target.h (struct target_ops) <pass_signals, program_signals>:
2381         Constify argument.
2382         (target_pass_signals, target_program_signals): Constify argument.
2383
2384 2019-01-14  Tom Tromey  <tom@tromey.com>
2385
2386         PR tui/28819:
2387         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
2388
2389 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2390
2391         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
2392         field.
2393         * rs6000-tdep.c: Include reggroups.h.
2394         (IS_V_ALIAS_PSEUDOREG): Define.
2395         (rs6000_register_name): Return names for the "vX" aliases.
2396         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
2397         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
2398         aliases.  Call default_register_reggroup_p for all other
2399         pseudo-registers.
2400         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
2401         New functions.
2402         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
2403         Handle "vX" aliases.
2404         (v_alias_pseudo_register_collect): New function.
2405         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
2406         (rs6000_gdbarch_init): Initialize "vX" aliases as
2407         pseudo-registers.  Restore registration of
2408         rs6000_pseudo_register_reggroup_p with
2409         set_tdesc_pseudo_register_reggroup_p.
2410
2411 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
2412
2413         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
2414         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
2415         set_gdbarch_num_pseudo_regs.
2416
2417 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2418
2419         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
2420         Remove arg prefixname, add do_set and do_show.
2421         Add member functions set_list and show_list.
2422         * cli/cli-style.c (class cli_style_option): Update accordingly.
2423         (style_set_list): Move to file scope.
2424         (style_show_list): Likewise.
2425         (set_style): Call help_list.
2426         (show_style): Call cmd_show_list.
2427         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
2428         Update to use the new macro.
2429
2430 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
2431
2432         * ada-lang.c (_initialize_ada_language): Expand the help text
2433         for the "catch exception" command.
2434
2435 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2436
2437         * symtab.c (matching_obj_sections): Initialize obj,
2438         declare it closer to its usage.
2439
2440 2019-01-10  Tom Tromey  <tom@tromey.com>
2441
2442         * thread-iter.h (inf_threads_iterator): Use next_iterator.
2443         (basic_inf_threads_range): Remove.
2444         (inf_threads_range, inf_non_exited_threads_range)
2445         (safe_inf_threads_range): Use next_adapter.
2446
2447 2019-01-10  Keith Seitz  <keiths@redhat.com>
2448
2449         PR gdb/23712
2450         PR symtab/23010
2451         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
2452         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
2453
2454 2019-01-10  Keith Seitz  <keiths@redhat.com>
2455
2456         PR gdb/23712
2457         PR symtab/23010
2458         * dictionary.c (pending_to_vector): Remove.
2459         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2460         Remove _1 suffix, replacing functions of the same name.  Update
2461         all callers.
2462         (dict_create_hashed, dict_create_hashed_expandable)
2463         (dict_create_linear, dict_create_linear_expandable, dict_free)
2464         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
2465         Make functions static.
2466
2467 2019-01-10  Keith Seitz  <keiths@redhat.com>
2468
2469         PR gdb/23712
2470         PR symtab/23010
2471         * dictionary.h (struct dictionary): Replace declaration with
2472         multidictionary.
2473         (dict_create_hashed, dict_create_hashed_expandable)
2474         (dict_create_linear, dict_create_linear_expandable)
2475         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
2476         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
2477         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
2478         taking multidictionary argument.
2479         [ALL_DICT_SYMBOLS]: Update for multidictionary.
2480         * block.h (struct block) <dict>: Change to multidictionary
2481         and rename `multidict'.
2482         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
2483         symmisc.c: Update all dictionary references to multidictionary.
2484
2485 2019-01-10  Keith Seitz  <keiths@redhat.com>
2486
2487         PR gdb/23712
2488         PR symtab/23010
2489         * dictionary.c: Include unordered_map.
2490         (pending_to_vector): New function.
2491         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2492         Rewrite the non-"_1" functions to take vector instead
2493         of linked list.
2494         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
2495         "new" _1 versions of the same name.
2496         (multidictionary): Define.
2497         (std::hash<enum language): New definition.
2498         (collate_pending_symbols_by_language, mdict_create_hashed)
2499         (mdict_create_hashed_expandable, mdict_create_linear)
2500         (mdict_create_linear_expandable, mdict_free)
2501         (find_language_dictionary, create_new_language_dictionary)
2502         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
2503         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
2504         (mdict_size, mdict_empty): New functions.
2505         * dictionary.h (mdict_iterator): Define.
2506
2507 2019-01-10  Pedro Alves  <palves@redhat.com>
2508
2509         * breakpoint.c (read_uploaded_action)
2510         (create_tracepoint_from_upload): Adjust to use
2511         gdb::unique_xmalloc_ptr.
2512         * ctf.c (ctf_write_uploaded_tp):
2513         (SET_ARRAY_FIELD): Use emplace_back.
2514         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
2515         * tracefile-tfile.c (tfile_write_uploaded_tp):
2516         * tracepoint.c (parse_tracepoint_definition): Adjust to use
2517         gdb::unique_xmalloc_ptr.
2518         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
2519         at_string, cond_string, cmd_strings>: Replace char pointers
2520         with gdb::unique_xmalloc_ptr.
2521
2522 2019-01-10  Pedro Alves  <palves@redhat.com>
2523
2524         * solib-target.c (library_list_start_library): Don't xstrdup name.
2525
2526 2019-01-10  Pedro Alves  <palves@redhat.com>
2527
2528         * mdebugread.c (parse_partial_symbols): Use
2529         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
2530
2531 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2532
2533         * linux-fork.c (scoped_switch_fork_info)
2534         <~scoped_switch_fork_info>: Fix incorrect variable name.
2535
2536 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2537
2538         * linux-fork.c (scoped_switch_fork_info)
2539         <scoped_switch_fork_info>: Make explicit.
2540         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
2541
2542 2019-01-10  Tom Tromey  <tom@tromey.com>
2543
2544         * objfiles.h (objfile::reset_psymtabs): Update.
2545         * objfiles.c (objfile::objfile): Update.
2546         * psymtab.h (psymtab_storage::obstack): Update.
2547         (psymtab_storage::m_obstack): Use gdb::optional.
2548         (class psymtab_storage): Update comment.  Remove objfile
2549         parameter.
2550         * psymtab.c (psymtab_storage::psymtab_storage): Update.
2551
2552 2019-01-10  Tom Tromey  <tom@tromey.com>
2553
2554         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
2555         <free_psymtabs>: Now private.
2556         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
2557         (allocate_psymtab): Use new method.
2558
2559 2019-01-10  Tom Tromey  <tom@tromey.com>
2560
2561         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
2562         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
2563         * mdebugread.c (parse_partial_symbols): Use
2564         allocate_dependencies.
2565         * dwarf2read.c (dwarf2_create_include_psymtab): Use
2566         allocate_dependencies.
2567         (process_psymtab_comp_unit_reader)
2568         (build_type_psymtab_dependencies): Likewise.
2569         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
2570
2571 2019-01-10  Tom Tromey  <tom@tromey.com>
2572
2573         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
2574         PSYMBOL_SET_LANGUAGE.
2575         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
2576
2577 2019-01-10  Tom Tromey  <tom@tromey.com>
2578
2579         * psymtab.h (psymtab_storage::obstack): New method.
2580         <m_obstack>: Rename from obstack; now private.
2581         * psymtab.c (psymtab_storage): Update.
2582         * dwarf2read.c (create_addrmap_from_index)
2583         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
2584         Update.
2585
2586 2019-01-10  Tom Tromey  <tom@tromey.com>
2587
2588         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
2589         * objfiles.h (objfile::reset_psymtabs): New method.
2590
2591 2019-01-10  Tom Tromey  <tom@tromey.com>
2592
2593         * symmisc.c (print_symbol_bcache_statistics): Update.
2594         (print_objfile_statistics): Update.
2595         * symfile.c (reread_symbols): Update.
2596         * psymtab.h (class psymtab_storage): New.
2597         * psymtab.c (psymtab_storage): New constructor.
2598         (~psymtab_storage): New destructor.
2599         (require_partial_symbols): Update.
2600         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
2601         (find_pc_sect_psymtab, find_pc_sect_psymbol)
2602         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
2603         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
2604         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
2605         (start_psymtab_common, end_psymtab_common)
2606         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
2607         (allocate_psymtab): Update.
2608         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
2609         Update.
2610         (dump_psymtab_addrmap, maintenance_print_psymbols)
2611         (maintenance_check_psymtabs): Update.
2612         (class objfile_psymtabs): Move to objfiles.h.
2613         * psympriv.h (discard_psymtab): Now inline.
2614         (psymtab_discarder::psymtab_discarder): Update.
2615         (psymtab_discarder::~psymtab_discarder): Update.
2616         (ALL_OBJFILE_PSYMTABS): Rewrite.
2617         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
2618         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
2619         Remove fields.
2620         <partial_symtabs>: New field.
2621         (class objfile_psymtabs): Move from psymtab.h.  Update.
2622         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
2623         psymbol_cache.
2624         (objfile::~objfile): Don't destroy psymbol_cache.
2625         * mdebugread.c (parse_partial_symbols): Update.
2626         * dwarf2read.c (create_addrmap_from_index)
2627         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
2628         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
2629         (add_partial_subprogram, dwarf2_ranges_read): Update.
2630         * dwarf-index-write.c (write_address_map)
2631         (write_one_signatured_type, recursively_write_psymbols)
2632         (class debug_names, class debug_names, write_psymtabs_to_index):
2633         Update.
2634
2635 2019-01-10  Tom Tromey  <tom@tromey.com>
2636
2637         * symtab.h (SYMBOL_SET_NAMES): Update.
2638         (symbol_set_names): Update.
2639         (MSYMBOL_SET_NAMES): Update.
2640         * symtab.c (symbol_set_names): Change argument to be an
2641         objfile_per_bfd_storage.
2642         * psymtab.c (add_psymbol_to_bcache): Update.
2643         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
2644
2645 2019-01-10  Tom Tromey  <tom@tromey.com>
2646
2647         * symtab.c (create_demangled_names_hash): Change argument to be an
2648         objfile_per_bfd_storage.
2649         (symbol_set_names): Update.
2650
2651 2019-01-10  Tom Tromey  <tom@tromey.com>
2652
2653         * xcoffread.c (xcoff_initial_scan): Unconditionally call
2654         init_psymbol_list.
2655         * psymtab.c (init_psymbol_list): Do nothing if already called.
2656         * psympriv.h (init_psymbol_list): Add comment.
2657         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
2658         init_psymbol_list.
2659         * dbxread.c (dbx_symfile_read): Unconditionally call
2660         init_psymbol_list.
2661
2662 2019-01-10  Tom Tromey  <tom@tromey.com>
2663
2664         * xcoffread.c (scan_xcoff_symtab): Update.
2665         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
2666         "where".
2667         * mdebugread.c (parse_partial_symbols)
2668         (handle_psymbol_enumerators): Update.
2669         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
2670         * dbxread.c (read_dbx_symtab): Update.
2671         * psympriv.h (psymbol_placement): New enum.
2672         (add_psymbol_to_list): Update.
2673
2674 2019-01-10  Tom Tromey  <tom@tromey.com>
2675
2676         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
2677         static_psymbols parameters.
2678         (scan_xcoff_symtab): Update.
2679         * psymtab.c (start_psymtab_common): Remove global_psymbols and
2680         static_psymbols parameters.
2681         * psympriv.h (start_psymtab_common): Update.
2682         * mdebugread.c (parse_partial_symbols): Update.
2683         * dwarf2read.c (create_partial_symtab): Update.
2684         * dbxread.c (read_dbx_symtab): Update.
2685         (start_psymtab): Remove global_psymbols and static_psymbols
2686         parameters.
2687
2688 2019-01-10  Tom Tromey  <tom@tromey.com>
2689
2690         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
2691         * psymtab.c (allocate_psymtab): Add comment.
2692         * psympriv.h (allocate_psymtab): Add comment.
2693         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
2694         initializations.
2695         * dbxread.c (dbx_end_psymtab): Remove some initializations.
2696
2697 2019-01-10  Tom Tromey  <tom@tromey.com>
2698
2699         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2700         Don't declare.
2701         * mipsread.c: Include mdebugread.h.
2702         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2703         Declare.
2704         * elfread.c: Include mdebugread.h.
2705
2706 2019-01-09  Tom Tromey  <tom@tromey.com>
2707
2708         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
2709         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
2710         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
2711         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
2712         (psym_lookup_symbol, psym_find_last_source_symtab)
2713         (psym_forget_cached_source_info, psym_print_stats)
2714         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
2715         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
2716         (psym_map_matching_symbols, psym_expand_symtabs_matching)
2717         (psym_find_compunit_symtab_by_address)
2718         (maintenance_print_psymbols, maintenance_info_psymtabs)
2719         (maintenance_check_psymtabs): Use ranged for.
2720         * psymtab.h (class objfile_psymtabs): New.
2721         (require_partial_symbols): Return objfile_psymtabs.
2722         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
2723
2724 2019-01-09  Tom Tromey  <tom@tromey.com>
2725
2726         * symfile.c (overlay_invalidate_all, find_pc_overlay)
2727         (find_pc_mapped_section, list_overlays_command)
2728         (map_overlay_command, unmap_overlay_command)
2729         (simple_overlay_update): Use all_objfiles.
2730         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
2731         * printcmd.c (info_symbol_command): Use all_objfiles.
2732         * objfiles.h (ALL_OBJSECTIONS): Remove.
2733         * maint.c (maintenance_translate_address): Use all_objfiles.
2734         * gcore.c (gcore_create_callback): Use all_objfiles.
2735         (objfile_find_memory_regions): Likewise.
2736
2737 2019-01-09  Tom Tromey  <tom@tromey.com>
2738
2739         * symtab.c (find_line_symtab, info_sources_command)
2740         (make_source_files_completion_list): Use objfile_compunits.
2741         * source.c (select_source_symtab): Use objfile_compunits.
2742         * objfiles.h (struct objfile): Update comment.
2743         (ALL_OBJFILES): Remove.
2744         (ALL_FILETABS): Remove.
2745         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
2746         objfile_compunits.
2747
2748 2019-01-09  Tom Tromey  <tom@tromey.com>
2749
2750         * symmisc.c (print_objfile_statistics, dump_objfile)
2751         (maintenance_print_symbols): Use compunit_filetabs.
2752         * source.c (forget_cached_source_info_for_objfile): Use
2753         compunit_filetabs.
2754         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
2755         (ALL_FILETABS): Use compunit_filetabs.
2756         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2757         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2758
2759 2019-01-09  Tom Tromey  <tom@tromey.com>
2760
2761         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2762         (compunit_filetabs): New.
2763         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2764         compunit_filetabs.
2765         (info_sources_command, make_source_files_completion_list): Remove
2766         declaration.
2767         * symmisc.c (print_objfile_statistics, dump_objfile)
2768         (maintenance_print_symbols): Remove declaration.
2769         (maintenance_info_symtabs): Use compunit_filetabs.
2770         (maintenance_info_line_tables): Likewise.
2771         * source.c (select_source_symtab): Change local variable name.
2772         (forget_cached_source_info_for_objfile): Remove declaration.
2773         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2774         * objfiles.c (objfile_relocate1): Remove declaration.
2775         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2776         declaration.
2777         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2778         * coffread.c (coff_symtab_read): Remove declaration.
2779         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2780         compunit_filetabs.
2781
2782 2019-01-09  Tom Tromey  <tom@tromey.com>
2783
2784         * symtab.c (lookup_objfile_from_block)
2785         (find_pc_sect_compunit_symtab, search_symbols)
2786         (default_collect_symbol_completion_matches_break_on): Use
2787         objfile_compunits.
2788         * objfiles.h (ALL_COMPUNITS): Remove.
2789         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2790         * cp-support.c (add_symbol_overload_list_qualified): Use
2791         objfile_compunits.
2792         * ada-lang.c (ada_collect_symbol_completion_matches)
2793         (ada_add_global_exceptions): Use objfile_compunits.
2794
2795 2019-01-09  Tom Tromey  <tom@tromey.com>
2796
2797         * source.c (select_source_symtab)
2798         (forget_cached_source_info_for_objfile): Remove declaration.
2799         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2800         declaration.
2801         * maint.c (count_symtabs_and_blocks): Remove declaration.
2802         * cp-support.c (add_symbol_overload_list_qualified): Remove
2803         declaration.
2804         * coffread.c (coff_symtab_read): Remove declaration.
2805         * symtab.c (lookup_symbol_in_objfile_symtabs)
2806         (basic_lookup_transparent_type_1): Use objfile_compunits.
2807         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2808         (info_sources_command, search_symbols)
2809         (default_collect_symbol_completion_matches_break_on)
2810         (make_source_files_completion_list): Remove declaration.
2811         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2812         (ada_collect_symbol_completion_matches)
2813         (ada_add_global_exceptions): Remove declaration.
2814         * linespec.c (iterate_over_all_matching_symtabs): Use
2815         objfile_compunits.
2816         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2817         (class objfile_compunits): New.
2818         (ALL_COMPUNITS): Use objfile_compunits.
2819         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2820         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2821         objfile_compunits.
2822         * objfiles.c (objfile_relocate1): Use objfile_compunits.
2823
2824 2019-01-09  Tom Tromey  <tom@tromey.com>
2825
2826         * symtab.c (search_symbols)
2827         (default_collect_symbol_completion_matches_break_on): Use
2828         objfile_msymbols.
2829         * ada-lang.c (ada_lookup_simple_minsym)
2830         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2831         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2832         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2833         objfile_msymbols.
2834         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2835         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2836         * objc-lang.c (find_methods): Use objfile_msymbols.
2837         (info_selectors_command, info_classes_command): Likewise.
2838         * stabsread.c (scan_file_globals): Use objfile_msymbols.
2839         * objfiles.h (class objfile_msymbols): New.
2840         (ALL_OBJFILE_MSYMBOLS): Remove.
2841         (ALL_MSYMBOLS): Remove.
2842
2843 2019-01-09  Tom Tromey  <tom@tromey.com>
2844
2845         * common/next-iterator.h (next_adapter): Add Iterator template
2846         parameter.
2847         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2848         (class all_objfiles_safe): New.
2849         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2850         * objfiles.c (put_objfile_before): Update comment.
2851         (add_separate_debug_objfile): Likewise.
2852         (free_all_objfiles): Use all_objfiles_safe.
2853         (objfile_purge_solibs): Likewise.
2854
2855 2019-01-09  Tom Tromey  <tom@tromey.com>
2856
2857         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2858         (expand_symtab_containing_pc, lookup_static_symbol)
2859         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2860         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2861         all_objfiles.
2862         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2863         * breakpoint.c (create_overlay_event_breakpoint)
2864         (create_longjmp_master_breakpoint)
2865         (create_std_terminate_master_breakpoint)
2866         (create_exception_master_breakpoint): Use all_objfiles.
2867         * linux-thread-db.c (try_thread_db_load_from_pdir)
2868         (has_libpthread): Use all_objfiles.
2869         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2870         * linespec.c (iterate_over_all_matching_symtabs)
2871         (search_minsyms_for_name): Use all_objfiles.
2872         * maint.c (maintenance_info_sections): Use all_objfiles.
2873         * main.c (captured_main_1): Use all_objfiles.
2874         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2875         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2876         * guile/scm-pretty-print.c
2877         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2878         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2879         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2880         (maintenance_print_msymbols): Use all_objfiles.
2881         * source.c (select_source_symtab): Use all_objfiles.
2882         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2883         * symfile.c (remove_symbol_file_command)
2884         (expand_symtabs_matching, map_symbol_filenames): Use
2885         all_objfiles.
2886         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2887         all_objfiles.
2888         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2889         * objc-lang.c (find_methods): Use all_objfiles.
2890         * objfiles.c (have_partial_symbols, have_full_symbols)
2891         (have_minimal_symbols, qsort_cmp)
2892         (default_iterate_over_objfiles_in_search_order): Use
2893         all_objfiles.
2894         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2895         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2896         (maintenance_check_psymtabs): Use all_objfiles.
2897         (ALL_PSYMTABS): Remove.
2898         * compile/compile-object-run.c (do_module_cleanup): Use
2899         all_objfiles.
2900         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2901         * cp-support.c (add_symbol_overload_list_qualified): Use
2902         all_objfiles.
2903         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2904         Use all_objfiles.
2905         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2906         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2907         all_objfiles.
2908         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2909         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2910         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2911         Uses all_objfiles.
2912         * solib.c (solib_read_symbols): Use all_objfiles
2913
2914 2019-01-09  Tom Tromey  <tom@tromey.com>
2915
2916         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2917         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2918         all_objfiles.
2919         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2920         * symmisc.c (print_symbol_bcache_statistics)
2921         (print_objfile_statistics, maintenance_print_objfiles)
2922         (maintenance_info_symtabs, maintenance_check_symtabs)
2923         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2924         all_objfiles.
2925         * source.c (forget_cached_source_info): Use all_objfiles.
2926         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2927         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2928         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2929         * objfiles.c (update_section_map): Use all_objfiles.
2930         (shared_objfile_contains_address_p): Likewise.
2931         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2932         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2933
2934 2019-01-09  Tom Tromey  <tom@tromey.com>
2935
2936         * common/next-iterator.h: New file.
2937         * objfiles.h (class all_objfiles): New.
2938         (struct objfile_iterator): New.
2939
2940 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2941
2942         * NEWS: Move the description of the changed "frame", "select-frame",
2943          and "info frame" commands to the Changed commands section.
2944
2945 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2946
2947         * gdbtypes.c (check_stub_method_group): Remove handling of old
2948         mangling schemes.
2949         * linespec.c (find_methods): Likewise.
2950         * stabsread.c (read_member_functions): Likewise.
2951         * valops.c (search_struct_method): Likewise.
2952         (value_struct_elt_for_reference): Likewise.
2953         * NEWS: Mention this change.
2954
2955 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2956
2957         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2958         print_source_lines.
2959         * source.c (print_source_lines_base): Update line number check.
2960         (print_source_lines): New function.
2961         (source_lines_range::source_lines_range): New function.
2962         * source.h (class source_lines_range): New class.
2963         (print_source_lines): New declaration.
2964
2965 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2966
2967         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2968
2969 2019-01-08  Tom Tromey  <tom@tromey.com>
2970             Simon Marchi  <simon.marchi@ericsson.com>
2971
2972         PR gdb/24060
2973         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2974         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2975         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2976         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2977         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2978         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2979
2980 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2981
2982         * source.c (select_source_symtab): Move header comment to
2983         declaration in source.h.
2984         (forget_cached_source_info_for_objfile): Likewise.
2985         (forget_cached_source_info): Likewise.
2986         (identify_source_line): Likewise.
2987         * source.h (identify_source_line): Move declaration from symtab.h
2988         and add comment from source.c
2989         (print_source_lines): Likewise.
2990         (forget_cached_source_info_for_objfile): Likewise.
2991         (forget_cached_source_info): Likewise.
2992         (select_source_symtab): Likewise.
2993         (enum print_source_lines_flag): Move definition from symtab.h.
2994         * symtab.h (identify_source_line): Move declaration to source.h.
2995         (print_source_lines): Likewise.
2996         (forget_cached_source_info_for_objfile): Likewise.
2997         (forget_cached_source_info): Likewise.
2998         (select_source_symtab): Likewise.
2999         (enum print_source_lines_flag): Move definition to source.h.
3000         * tui/tui-hooks.c: Add 'source.h' include.
3001
3002 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3003
3004         * source.c (print_source_lines_base): Handle requests to print
3005         reverse line number sequences, and guard against empty lines
3006         string.
3007
3008 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3009
3010         * source.c (print_source_lines_base): Fix skip of '\r' if next
3011         character is '\n'.
3012
3013 2019-01-06  Tom Tromey  <tom@tromey.com>
3014
3015         * c-exp.y (struct c_parse_state) <macro_original_text,
3016         expansion_obstack>: New member.
3017         (macro_original_text, expansion_obstack): Remove globals.
3018         (scan_macro_expansion, scanning_macro_expansion)
3019         (finished_macro_expansion): Update.
3020         (scan_macro_cleanup): Remove.
3021         (yylex, c_parse): Update.
3022
3023 2019-01-06  Tom Tromey  <tom@tromey.com>
3024
3025         * c-exp.y (struct c_parse_state) <strings>: New member.
3026         (operator_stoken): Update.
3027
3028 2019-01-06  Tom Tromey  <tom@tromey.com>
3029
3030         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
3031         (union type_stack_elt) <typelist_val>: Now a pointer to
3032         std::vector.
3033         (type_stack_cleanup): Don't declare.
3034         (push_typelist): Update.
3035         * parse.c (pop_typelist): Return a std::vector.
3036         (push_typelist): Take a std::vector.
3037         (follow_types): Update.  Do not free args.
3038         (type_stack_cleanup): Remove.
3039         * c-exp.y (struct c_parse_state): New.
3040         (cpstate): New global.
3041         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
3042         (nonempty_typelist): Update.
3043         (func_mod): Create a new vector.
3044         (c_parse): Create a c_parse_state.
3045         (check_parameter_typelist): Do not delete params.
3046         (function_method): Update.  Do not delete type_list.
3047
3048 2019-01-06  Tom Tromey  <tom@tromey.com>
3049
3050         PR gdb/28155:
3051         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
3052         check_typedef.
3053         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
3054         (print_return_value): Likewise.
3055
3056 2019-01-05  Tom Tromey  <tom@tromey.com>
3057
3058         * contrib/cleanup_check.py: Remove.
3059         * contrib/gcc-with-excheck: Remove.
3060         * contrib/exsummary.py: Remove.
3061         * contrib/excheck.py: Remove.
3062
3063 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
3064
3065         * thread.c (delete_thread_1): Add gdb_assert that THR is not
3066         NULL. Initialize tpprev to NULL instead of assigning it
3067         to NULL on the next statement.
3068         * windows-nat.c (windows_delete_thread): Remove check for
3069         main_thread_id before printing thread exit notifications.
3070         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
3071         Remove thread ID check against main_thread_id.
3072         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
3073         windows_delete_thread.
3074         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
3075
3076 2019-01-04  Tom Tromey  <tom@tromey.com>
3077
3078         * compile/compile.c (_initialize_compile): Use upper case for
3079         metasyntactic variables.
3080         * symmisc.c (_initialize_symmisc): Use upper case for
3081         metasyntactic variables.
3082         * psymtab.c (_initialize_psymtab): Use upper case for
3083         metasyntactic variables.
3084         * demangle.c (demangle_command): Use upper case for metasyntactic
3085         variables.
3086         (_initialize_demangler): Likewise.
3087         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
3088         variables.
3089
3090 2019-01-03  Tom Tromey  <tom@tromey.com>
3091
3092         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
3093
3094 2019-01-03  Tom Tromey  <tom@tromey.com>
3095
3096         * python/py-symtab.c (salpy_str): Update.
3097         (struct salpy_sal_object) <symtab>: Now a PyObject.
3098         (salpy_dealloc): Update.
3099         (del_objfile_sal): Use gdbpy_ref.
3100
3101 2019-01-03  Tom Tromey  <tom@tromey.com>
3102
3103         * python/py-type.c (convert_field): Use new_reference.  Return
3104         gdbpy_ref.
3105         (make_fielditem): Return gdbpy_ref.
3106         (typy_fields): Update.
3107         (typy_getitem): Update.
3108         (field_name): Return gdbpy_ref.  Use new_reference.
3109         (typy_iterator_iternext): Update.
3110
3111 2019-01-03  Tom Tromey  <tom@tromey.com>
3112
3113         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
3114
3115 2019-01-03  Tom Tromey  <tom@tromey.com>
3116
3117         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
3118         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
3119         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
3120         (pspy_set_frame_filters, pspy_set_frame_unwinders)
3121         (pspy_set_type_printers): Likewise.
3122         * python/py-function.c (fnpy_init): Use gdbpy_ref.
3123         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
3124         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
3125         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
3126         (objfpy_set_type_printers): Likewise.
3127
3128 2019-01-03  Tom Tromey  <tom@tromey.com>
3129
3130         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
3131         (gdbpy_print_stack): Use gdbpy_err_fetch.
3132         * python/python-internal.h (class gdbpy_err_fetch): New class.
3133         (class gdbpy_enter) <m_error_type, m_error_value,
3134         m_error_traceback>: Remove.
3135         <m_error>: New member.
3136         (gdbpy_exception_to_string): Don't declare.
3137         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
3138         * python/py-value.c (convert_value_from_python): Use
3139         gdbpy_err_fetch.
3140         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
3141         gdbpy_exception_to_string.
3142         (gdbpy_handle_exception): Use gdbpy_err_fetch.
3143         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3144         gdbpy_err_fetch.
3145
3146 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3147
3148         * linux-nat.c (delete_lwp_cleanup): Delete.
3149         (struct lwp_deleter): New struct.
3150         (lwp_info_up): New typedef.
3151         (linux_nat_target::follow_fork): Delete cleanup, and make use of
3152         lwp_info_up.
3153
3154 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3155
3156         * linux-fork.c (class scoped_switch_fork_info): New class.
3157         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
3158
3159 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3160
3161         * valops.c (find_overload_match): Remove use of null_cleanup, and
3162         calls to do_cleanups.
3163
3164 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3165
3166         * compile/compile-cplus-types.c
3167         (compile_cplus_instance::decl_name): Handle changes to
3168         cp_func_name.
3169         * cp-support.c (cp_func_name): Update header comment, update
3170         return type.
3171         * cp-support.h (cp_func_name): Update return type in declaration.
3172         * valops.c (find_overload_match): Move temp_func local to top
3173         level of function and change its type.  Use temp_func to hold and
3174         delete temporary string obtained from cp_func_name.
3175
3176 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3177
3178         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
3179         gdb::char_vector, remove cleanup, and update uses of `msg`.
3180
3181 2019-01-03  Jim Wilson  <jimw@sifive.com>
3182
3183         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
3184
3185 2019-01-02  Tom Tromey  <tom@tromey.com>
3186
3187         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
3188         (tdesc_parse_xml): Remove cleanups.
3189         * target-descriptions.h (make_cleanup_free_target_description):
3190         Don't declare.
3191         (target_desc_deleter): New struct.
3192         (target_desc_up): New typedef.
3193         * target-descriptions.c (target_desc_deleter::operator()): Rename
3194         from free_target_description.
3195         (make_cleanup_free_target_description): Remove.
3196
3197 2019-01-02  Tom Tromey  <tom@tromey.com>
3198
3199         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
3200         constructor, destructor.
3201         (linespec_parser): Remove typedef.
3202         (~linespec_parser): Rename from linespec_parser_delete.
3203         (linespec_lex_to_end, linespec_complete_label)
3204         (linespec_complete): Update.
3205         (decode_line_full): Remove cleanups.
3206         (decode_line_1): Update.
3207
3208 2019-01-02  Tom Tromey  <tom@tromey.com>
3209
3210         * python/python-internal.h (inferior_to_inferior_object): Change
3211         return type.
3212         * python/py-exitedevent.c (create_exited_event_object): Update.
3213         * python/py-inferior.c (inferior_to_inferior_object): Return
3214         gdbpy_ref.
3215         (python_new_inferior, python_inferior_deleted)
3216         (thread_to_thread_object, delete_thread_object)
3217         (build_inferior_list, gdbpy_selected_inferior): Update.
3218         * python/py-infthread.c (create_thread_object): Update.  Also fail
3219         if inferior_to_inferior_object fails.
3220
3221 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
3222
3223         * inferior.h (class inferior) <displaced_step_state>: New field.
3224         * infrun.h (struct displaced_step_state): Move here from
3225         infrun.c.  Initialize fields, add constructor.
3226         <inf>: Remove field.
3227         <reset>: New method.
3228         * infrun.c (struct displaced_step_inferior_state): Move to
3229         infrun.h.
3230         (displaced_step_inferior_states): Remove.
3231         (get_displaced_stepping_state): Adust.
3232         (displaced_step_in_progress_any_inferior): Adjust.
3233         (displaced_step_in_progress_thread): Adjust.
3234         (displaced_step_in_progress): Adjust.
3235         (add_displaced_stepping_state): Remove.
3236         (get_displaced_step_closure_by_addr): Adjust.
3237         (remove_displaced_stepping_state): Remove.
3238         (infrun_inferior_exit): Call displaced_step_state.reset.
3239         (use_displaced_stepping): Don't check for NULL.
3240         (displaced_step_prepare_throw): Call
3241         get_displaced_stepping_state.
3242         (displaced_step_fixup): Don't check for NULL.
3243         (prepare_for_detach): Don't check for NULL.
3244
3245 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3246
3247         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
3248          in case of call that did not complete.
3249
3250 2019-01-02  Andrey Utkin  <autkin@undo.io>
3251
3252         * symfile.c (find_separate_debug_file): Fix search of debug files for
3253         remote debuggee.
3254
3255 2019-01-02  Tom Tromey  <tom@tromey.com>
3256
3257         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
3258         indentation.
3259         * python/py-frame.c (frapy_older): Remove cast.
3260         (frapy_newer): Likewise.
3261         * python/py-breakpoint.c (local_setattro): Remove cast.
3262         * python/py-arch.c (archpy_name): Remove local variable.
3263         * python/py-type.c (gdbpy_lookup_type): Remove cast.
3264
3265 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
3266
3267         * unittests/basic_string_view/element_access/char/empty.cc:
3268         Fix year range in copyright header.
3269
3270 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3271
3272         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
3273         Delete.
3274         <operator==>: Update with for removed field.
3275         <hash>: Likewise.
3276         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
3277         <isa_features>: ...this.
3278         <abi_features>: New field.
3279         (riscv_isa_flen): Update comment.
3280         (riscv_abi_xlen): New declaration.
3281         (riscv_abi_flen): New declaration.
3282         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
3283         isa_features.
3284         (riscv_abi_xlen): New function.
3285         (riscv_isa_flen): Update to get answer from isa_features.
3286         (riscv_abi_flen): New function.
3287         (riscv_has_fp_abi): Update to get answer from abi_features.
3288         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
3289         xlen and flen.
3290         (riscv_call_info) <xlen, flen>: Update comment.
3291         (riscv_call_arg_struct): Remove invalid assertions
3292         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
3293         is removed.
3294         (riscv_gdbarch_init): Gather isa features and abi features
3295         separately, ensure both match on the gdbarch when reusing an old
3296         gdbarch.  Relax an error check to allow 32-bit abi float to run on
3297         a target with 64-bit float hardware.
3298
3299 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3300
3301         * source.c (search_command_helper): Stop reverse search
3302         when line 1 has been searched.
3303
3304 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3305
3306         * record-full.c (record_full_base_target::close): Rewrite
3307         record_full_core_buf_list free logic.
3308
3309 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3310
3311         * break-catch-syscall.c (print_one_catch_syscall): xfree
3312         the last text.
3313
3314 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3315
3316         * top.c (print_gdb_version): Update Copyright year in version
3317         message.
3318
3319 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3320
3321         Update copyright year range in all GDB files.
3322
3323 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
3324
3325         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
3326
3327 For older changes see ChangeLog-2018.
3328 \f
3329 Local Variables:
3330 mode: change-log
3331 left-margin: 8
3332 fill-column: 74
3333 version-control: never
3334 coding: utf-8
3335 End:
3336