gdb/ChangeLog

   1 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
   2
   3         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
   4         * psympriv.h (add_psymbol_to_list): Move comment here and update
   5         it.
   6
   7 2019-09-29  Tom de Vries  <tdevries@suse.de>
   8
   9         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
  10         Use $tmpdir/$(basename "$output_file").dwz instead of
  11         "${output_file}.dwz".
  12
  13 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
  14
  15         PR gdb/25045
  16         * hppa-linux-nat.c: Include gdbarch.h.
  17
  18 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
  19
  20         * blockframe.c (find_pc_partial_function): Change return type to bool.
  21         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
  22         * minsyms.c (in_gnu_ifunc_stub): Likewise.
  23         (stub_gnu_ifunc_resolve_name): Likewise.
  24         * symtab.c (compare_filenames_for_search): Likewise.
  25         (compare_glob_filenames_for_search): Likewise.
  26         (matching_obj_sections): Likewise.
  27         (symbol_matches_domain): Likewise.
  28         (find_line_symtab): Change out param EXACT_MATCH to bool *.
  29         (find_line_pc): Change return type to bool.
  30         (find_line_pc_range): Likewise.
  31         (producer_is_realview): Likewise.
  32         * symtab.h (symbol_matches_domain): Likewise.
  33         (find_pc_partial_function): Likewise.
  34         (find_pc_line_pc_range): Likewise.
  35         (in_gnu_ifunc_stub): Likewise.
  36         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
  37         (find_line_pc): Likewise.
  38         (find_line_pc_range): Likewise.
  39         (matching_obj_sections): Likewise.
  40         (find_line_symtab): Change out parameter to bool.
  41         (producer_is_realview): Change return type to bool.
  42         (compare_filenames_for_search): Likewise.
  43         (compare_glob_filenames_for_search): Likewise.
  44
  45 2019-09-26  Tom Tromey  <tom@tromey.com>
  46
  47         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
  48         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
  49         * gdb_usleep.h: Remove.
  50         * gdb_usleep.c: Remove.
  51         * utils.c: Don't include gdb_usleep.h.
  52
  53 2019-09-26  Tom Tromey  <tromey@adacore.com>
  54
  55         * python/py-type.c (type_to_type_object): Call check_typedef
  56         for stub types.
  57
  58 2019-09-26  Tom Tromey  <tom@tromey.com>
  59
  60         * utils.h (initialize_utils): Don't declare.
  61         * top.c (gdb_init): Don't call initialize_utils.
  62         * utils.c (initialize_utils): Remove.  Move contents...
  63         (_initialize_utils): ... here.
  64
  65 2019-09-25  Tom Tromey  <tom@tromey.com>
  66
  67         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
  68         * utils.h (make_hex_string): Don't declare.
  69         * utils.c (make_hex_string): Remove.
  70
  71 2019-09-24  Tom de Vries  <tdevries@suse.de>
  72
  73         PR gdb/23815
  74         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
  75         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
  76
  77 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
  78
  79         * NEWS: Mention new simulator port for PRU.
  80
  81 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
  82
  83         * ada-exp.y (write_object_remaining): Update.
  84         * ada-lang.c (ada_decode): Return a std::string instead of a char*
  85         and eliminate the static buffer.
  86         (ada_decode_symbol): Update.
  87         (ada_la_decode): Update.
  88         (ada_sniff_from_mangled_name): Update.
  89         (is_valid_name_for_wild_match): Update.
  90         (ada_lookup_name_info::matches): Update and simplify.
  91         (name_matches_regex): Update.
  92         (ada_add_global_exceptions): Update.
  93         * ada-lang.h (ada_decode): Update signature.
  94         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
  95         * dwarf-index-write.c (debug_names::insert): Update.
  96
  97 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
  98
  99         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
 100         formatting.
 101
 102 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 103
 104         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
 105         Change "nonzero" to "true" in documentation.
 106
 107 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
 108
 109         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
 110         (_initialize_darwin_solib): Don't set
 111         darwin_so_ops.lookup_lib_global_symbol.
 112         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
 113         set_gdbarch_iterate_over_objfiles_in_search_order.
 114         (elf_lookup_lib_symbol): Rename to...
 115         (svr4_iterate_over_objfiles_in_search_order): this, and update
 116         to iterate semantics.
 117         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
 118         * solib.c (solib_global_lookup): Remove.
 119         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
 120         (solib_global_lookup): Remove.
 121         * symtab.c (lookup_global_or_static_symbol): Remove call to
 122         solib_global_lookup.
 123
 124 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 125
 126         * NEWS: Move entries about default MI version now being
 127         version 3, and about the GDB/MI fix for multi-location
 128         breakpoints to the "since GDB 8.3" section.
 129
 130 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 131
 132         GDB 8.3.1 released.
 133
 134 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
 135
 136         * NEWS: Mention that Cell/B.E. debugging support was removed.
 137         * MAINTAINERS: Remove spu target.
 138
 139         * config/djgpp/fnchange.lst: Remove entries for removed files.
 140
 141         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
 142         spu-multiarch.o, and spu-tdep.o.
 143         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
 144         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
 145         spu-multiarch.c, and spu-tdep.c.
 146         * spu-linux-nat.c: Remove file.
 147         * spu-multiarch.c: Remove file.
 148         * spu-tdep.c: Remove file.
 149         * spu-tdep.h: Remove file.
 150         * solib-spu.c: Remove file.
 151         * solib-spu.h: Remove file.
 152
 153         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
 154         * configure.nat (spu-linux): Remove.
 155         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
 156         solib-multiarch.o from gdb_target_obs.
 157         (spu*-*-*): Remove.
 158
 159         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
 160         feature flag.
 161         (ppc_linux_no_features): Update.
 162         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
 163         Cell/B.E. support.
 164         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
 165         (tdesc_powerpc_cell64l): Likewise.
 166         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
 167         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
 168         Cell/B.E. support.
 169         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
 170         Do not include "features/rs6000/powerpc-cell32l.c" or
 171         "features/rs6000/powerpc-cell64l.c".
 172         (ppc_linux_spu_section): Remove.
 173         (ppc_linux_core_read_description): Remove Cell/B.E. support.
 174         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
 175         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
 176         (ppc_linux_spe_context_lookup): Remove.
 177         (ppc_linux_spe_context_inferior_created): Remove.
 178         (ppc_linux_spe_context_solib_loaded): Remove.
 179         (ppc_linux_spe_context_solib_unloaded): Remove.
 180         (ppc_linux_spe_context): Remove.
 181         (struct ppu2spu_cache): Remove.
 182         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
 183         (struct ppu2spu_data): Remove.
 184         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
 185         ppu2spu_unwind): Remove.
 186         (ppc_linux_init_abi): Remove Cell/B.E. support.
 187         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
 188
 189         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
 190         (rs6000/powerpc-cell64l-expedite): Likewise
 191         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
 192         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
 193         rs6000/powerpc-cell64l.xml.
 194         * features/rs6000/powerpc-cell32l.xml: Remove.
 195         * features/rs6000/powerpc-cell64l.xml: Likewise.
 196         * features/rs6000/powerpc-cell32l.c: Remove generated file.
 197         * features/rs6000/powerpc-cell64l.c: Likewise.
 198         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
 199         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
 200         * regformats/reg-spu.dat: Remove.
 201
 202         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
 203         * corelow.c (struct spuid_list): Remove.
 204         (add_to_spuid_list): Remove.
 205         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 206         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
 207         (remote_protocol_features): Remove associated entries.
 208         (_initialize_remote): No longer initialize them.
 209         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 210         * linux-nat.c (SPUFS_MAGIC): Remove.
 211         (linux_proc_xfer_spu): Remove.
 212         (spu_enumerate_spu_ids): Remove.
 213         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 214         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
 215         (linux_make_corefile_notes): No longer call it.
 216
 217         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
 218         (cooked_write_test): Likewise.
 219
 220 2019-09-20  Tom Tromey  <tom@tromey.com>
 221
 222         * NEWS: Mention case-sensitivity of TUI commands.
 223         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
 224         (tui_set_win_height_command, parse_scrolling_args): Likewise.
 225         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
 226
 227 2019-09-20  Tom Tromey  <tom@tromey.com>
 228
 229         * tui/tui-source.c (tui_source_window::set_contents): Use
 230         make_unique_xstrdup.
 231         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
 232         make_unique_xstrdup.
 233
 234 2019-09-20  Tom Tromey  <tom@tromey.com>
 235
 236         * tui/tui-data.c: Remove separator comments.
 237         * tui/tui-layout.c: Remove separator comments.
 238         * tui/tui-win.c: Remove separator comments.
 239         * tui/tui-wingeneral.c: Remove separator comments.
 240
 241 2019-09-20  Tom Tromey  <tom@tromey.com>
 242
 243         * tui/tui.h (strcat_to_buf): Don't declare.
 244         * tui/tui.c (strcat_to_buf): Remove.
 245
 246 2019-09-20  Tom Tromey  <tom@tromey.com>
 247
 248         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
 249         from "fullname".
 250         * tui/tui-source.c (tui_source_window::set_contents)
 251         (tui_source_window::location_matches_p)
 252         (tui_source_window::maybe_update): Update.
 253
 254 2019-09-20  Tom Tromey  <tom@tromey.com>
 255
 256         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
 257         Update.
 258         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
 259         prefix.
 260         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 261         (tui_data_window::line_from_reg_element_no)
 262         (tui_data_window::first_reg_element_no_inline)
 263         (tui_data_window::show_registers)
 264         (tui_data_window::show_register_group)
 265         (tui_data_window::display_registers_from)
 266         (tui_data_window::display_registers_from_line)
 267         (tui_data_window::first_data_item_displayed)
 268         (tui_data_window::delete_data_content_windows)
 269         (tui_data_window::erase_data_content)
 270         (tui_data_window::do_scroll_vertical)
 271         (tui_data_window::refresh_window)
 272         (tui_data_window::check_register_values): Update.
 273
 274 2019-09-20  Tom Tromey  <tom@tromey.com>
 275
 276         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
 277         (struct tui_locator_window) <full_name, proc_name>: Now
 278         std::string.
 279         * tui/tui-stack.c (tui_locator_window::make_status_line)
 280         (tui_locator_window::set_locator_fullname)
 281         (tui_locator_window::set_locator_info): Update.
 282         * tui/tui-source.c (tui_source_window::set_contents)
 283         (tui_source_window::showing_source_p): Update.
 284
 285 2019-09-20  Tom Tromey  <tom@tromey.com>
 286
 287         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
 288         Don't call tui_locator_win_info_ptr.
 289
 290 2019-09-20  Tom Tromey  <tom@tromey.com>
 291
 292         * tui/tui-win.c (tui_resize_all): Don't call refresh.
 293
 294 2019-09-20  Tom Tromey  <tom@tromey.com>
 295
 296         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
 297         height for locator.
 298         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
 299         * tui/tui-layout.c (show_source_disasm_command, show_data)
 300         (show_source_or_disasm_and_command): Use 1 as height for locator.
 301
 302 2019-09-20  Tom Tromey  <tom@tromey.com>
 303
 304         * tui/tui.c (tui_enable): Update.
 305         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
 306         Update.
 307         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
 308         Update.
 309         * tui/tui-data.c (win_resized): Now bool.
 310         (tui_win_resized): Return bool.
 311         (tui_set_win_resized_to): Accept a bool.
 312
 313 2019-09-20  Tom Tromey  <tom@tromey.com>
 314
 315         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
 316         Change type of "refresh_values_only".
 317         * tui/tui-regs.c (tui_data_window::show_register_group): Change
 318         type of "refresh_values_only".
 319
 320 2019-09-20  Tom Tromey  <tom@tromey.com>
 321
 322         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
 323         std::string.
 324         (tui_disassemble): Add "pos" parameter.
 325         (tui_disasm_window::set_contents): Simplify.
 326
 327 2019-09-20  Tom Tromey  <tom@tromey.com>
 328
 329         * tui/tui-winsource.h (struct tui_source_window_base)
 330         <show_source_content>: Now private.
 331         * tui/tui-winsource.c
 332         (tui_source_window_base::show_source_content): Don't handle empty
 333         content case.
 334
 335 2019-09-20  Tom Tromey  <tom@tromey.com>
 336
 337         * tui/tui-layout.c (show_source_disasm_command)
 338         (show_source_or_disasm_and_command): Don't call
 339         show_source_content.
 340
 341 2019-09-20  Tom Tromey  <tom@tromey.com>
 342
 343         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
 344         Declare.
 345         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
 346         from tui_make_status_line.
 347         (tui_locator_window::rerender): Update.
 348
 349 2019-09-20  Tom Tromey  <tom@tromey.com>
 350
 351         * tui/tui-stack.c (tui_make_status_line): Return std::string.
 352         (tui_locator_window::rerender): Update.
 353
 354 2019-09-20  Tom Tromey  <tom@tromey.com>
 355
 356         * tui/tui-winsource.h (struct tui_source_window_base)
 357         <~tui_source_window_base>: Don't declare.
 358         <fullname>: Remove.
 359         * tui/tui-winsource.c (~tui_source_window_base): Remove.
 360         * tui/tui-source.h (struct tui_source_window) <fullname>: New
 361         member.
 362         * tui/tui-source.c (tui_source_window::set_contents): Update.
 363         (tui_source_window::location_matches_p)
 364         (tui_source_window::maybe_update): Update.
 365
 366 2019-09-20  Tom Tromey  <tom@tromey.com>
 367
 368         * tui/tui-winsource.h (~tui_source_element): Remove.
 369         (tui_source_element): Update.
 370         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
 371         * tui/tui-winsource.c (tui_show_source_line): Update.
 372         * tui/tui-source.c (tui_source_window::set_contents): Update.
 373         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 374
 375 2019-09-20  Tom Tromey  <tom@tromey.com>
 376
 377         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
 378         declare.
 379         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
 380         tui_clear_source_windows_detail.
 381         * tui/tui-winsource.h (struct tui_source_window_base)
 382         <clear_detail>: Don't declare.
 383         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
 384         Remove.
 385         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
 386
 387 2019-09-20  Tom Tromey  <tromey@adacore.com>
 388
 389         PR ada/24919:
 390         * block.c (contained_in): Fix final return value.
 391
 392 2019-09-20  Alan Modra  <amodra@gmail.com>
 393
 394         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
 395         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
 396         (read_indirect_string_from_dwz): Use bfd accessor.
 397         * dwarf2read.h (struct dwz_file <filename>): Likewise.
 398         * machoread.c (macho_symfile_read_all_oso): Likewise.
 399         * solib.c (solib_bfd_open): Likewise.
 400
 401 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 402
 403         * eval.c: Move declaration of overload_resolution to...
 404         * value.h: ...here.
 405
 406 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 407
 408         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
 409         * arm-linux-tdep.c: Likewise.
 410         * arm-nbsd-nat.c: Likewise.
 411         * arm-tdep.h: Declare arm_apcs_32.
 412         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
 413
 414 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 415
 416         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
 417         * dwarf2read.h: Declare dwarf_always_disassemble.
 418
 419 2019-09-19  Tom de Vries  <tdevries@suse.de>
 420
 421         PR gdb/25009
 422         * source-cache.c (source_cache::ensure): Catch exception thrown during
 423         construction of the highlighter.
 424
 425 2019-09-18  Alan Modra  <amodra@gmail.com>
 426
 427         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
 428         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
 429         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
 430         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
 431         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
 432         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
 433         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
 434         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
 435         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
 436         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
 437         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
 438         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
 439         * solib-spu.c, * solib-svr4.c, * solib-target.c,
 440         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
 441         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
 442         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
 443         * mi/mi-interp.c: Update throughout for bfd section macro and
 444         function changes.
 445         * gcore (gcore_create_callback): Use bfd_set_section_lma.
 446         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
 447
 448 2019-09-18  Tom Tromey  <tom@tromey.com>
 449
 450         * NEWS: Add entry.
 451         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
 452         call rl_initialize.
 453         (tui_enable): Do not call rl_initialize.
 454
 455 2019-09-18  Christian Groessler  <chris@groessler.org>
 456
 457         * alpha-linux-nat.c: Include gdbarch.h.
 458
 459 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
 460
 461         * ui-file.c: Include cli/cli-style.h.
 462         (term_cli_styling): Remove cli_styling declaration.
 463
 464 2019-09-18  Alan Modra  <amodra@gmail.com>
 465
 466         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
 467         to bfd_asymbol_section.
 468
 469 2019-09-18  Alan Modra  <amodra@gmail.com>
 470
 471         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
 472         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
 473         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
 474
 475 2019-09-18  Alan Modra  <amodra@gmail.com>
 476
 477         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
 478         * spu-linux-nat.c (spu_bfd_open): Likewise.
 479
 480 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
 481
 482         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
 483         to bool to match definition in dwarf2read.c.
 484
 485 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
 486
 487         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
 488         (print_signatures): Likewise.
 489         (trust_pad_over_xvs): Likewise.
 490         * arch/aarch64-insn.c (aarch64_debug): Likewise.
 491         * arch/aarch64-insn.h (aarch64_debug): Likewise.
 492         * arm-linux-nat.c (arm_apcs_32): Likewise.
 493         * arm-linux-tdep.c (arm_apcs_32): Likewise.
 494         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
 495         * arm-tdep.c (arm_debug): Likewise.
 496         (arm_apcs_32): Likewise.
 497         * auto-load.c (debug_auto_load): Likewise.
 498         (auto_load_gdb_scripts): Likewise.
 499         (global_auto_load): Likewise.
 500         (auto_load_local_gdbinit): Likewise.
 501         (auto_load_local_gdbinit_loaded): Likewise.
 502         * auto-load.h (global_auto_load): Likewise.
 503         (auto_load_local_gdbinit): Likewise.
 504         (auto_load_local_gdbinit_loaded): Likewise.
 505         * breakpoint.c (disconnected_dprintf): Likewise.
 506         (breakpoint_proceeded): Likewise.
 507         (automatic_hardware_breakpoints): Likewise.
 508         (always_inserted_mode): Likewise.
 509         (target_exact_watchpoints): Likewise.
 510         (_initialize_breakpoint): Update.
 511         * breakpoint.h (target_exact_watchpoints): Change to bool.
 512         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
 513         * cli/cli-cmds.c (trace_commands): Likewise.
 514         * cli/cli-cmds.h (trace_commands): Likewise.
 515         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
 516         to bool*.
 517         * cli/cli-logging.c (logging_overwrite): Change to bool.
 518         (logging_redirect): Likewise.
 519         (debug_redirect): Likewise.
 520         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
 521         (struct boolean_option_def) <get_var_address_cb_>: Change return type
 522         to bool.
 523         <boolean_option_def>: Update.
 524         (struct flag_option_def): Change default type of Context to bool
 525         from int.
 526         <flag_option_def>: Change return type of var_address_cb_ to bool*.
 527         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
 528         (get_setshow_command_value_string): Likewise.
 529         * cli/cli-style.c (cli_styling): Change to bool.
 530         (source_styling): Likewise.
 531         * cli/cli-style.h (source_styling): Likewise.
 532         (cli_styling): Likewise.
 533         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
 534         to bool.
 535         * command.h (var_types): Update comment.
 536         (add_setshow_boolean_cmd): Change int* var argument to bool*.
 537         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
 538         bool.
 539         (debug_compile_cplus_scopes): Likewise.
 540         * compile/compile-internal.h (compile_debug): Likewise.
 541         * compile/compile.c (compile_debug): Likewise.
 542         (struct compile_options) <raw>: Likewise.
 543         * cp-support.c (catch_demangler_crashes): Likewise.
 544         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
 545         (usr_cmd_cris_dwarf2_cfi): Likewise.
 546         * csky-tdep.c (csky_debug): Likewise.
 547         * darwin-nat.c (enable_mach_exceptions): Likewise.
 548         * dcache.c (dcache_enabled_p): Likewise.
 549         * defs.h (info_verbose): Likewise.
 550         * demangle.c (demangle): Likewise.
 551         (asm_demangle): Likewise.
 552         * dwarf-index-cache.c (debug_index_cache): Likewise.
 553         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
 554         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
 555         * dwarf2read.c (check_physname): Likewise.
 556         (use_deprecated_index_sections): Likewise.
 557         (dwarf_always_disassemble): Likewise.
 558         * eval.c (overload_resolution): Likewise.
 559         * event-top.c (set_editing_cmd_var): Likewise.
 560         (exec_done_display_p): Likewise.
 561         * event-top.h (set_editing_cmd_var): Likewise.
 562         (exec_done_display_p): Likewise.
 563         * exec.c (write_files): Likewise.
 564         * fbsd-nat.c (debug_fbsd_lwp): Likewise
 565         (debug_fbsd_nat): Likewise.
 566         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
 567         Likewise.
 568         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
 569         <backtrace_past_entry> Likewise.
 570         * gdb-demangle.h (demangle): Likewise.
 571         (asm_demangle): Likewise.
 572         * gdb_bfd.c (bfd_sharing): Likewise.
 573         * gdbcore.h (write_files): Likewise.
 574         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
 575         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
 576         * gdbthread.h (print_thread_events): Likewise.
 577         * gdbtypes.c (opaque_type_resolution): Likewise.
 578         (strict_type_checking): Likewise.
 579         * gnu-nat.c (gnu_debug_flag): Likewise.
 580         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
 581         * guile/scm-param.c (pascm_variable): Add boolval.
 582         (add_setshow_generic): Update.
 583         (pascm_param_value): Update.
 584         (pascm_set_param_value_x): Update.
 585         * hppa-tdep.c (hppa_debug): Change to bool..
 586         * infcall.c (may_call_functions_p): Likewise.
 587         (coerce_float_to_double_p): Likewise.
 588         (unwind_on_signal_p): Likewise.
 589         (unwind_on_terminating_exception_p): Likewise.
 590         * infcmd.c (startup_with_shell): Likewise.
 591         * inferior.c (print_inferior_events): Likewise.
 592         * inferior.h (startup_with_shell): Likewise.
 593         (print_inferior_events): Likewise.
 594         * infrun.c (step_stop_if_no_debug): Likewise.
 595         (detach_fork): Likewise.
 596         (debug_displaced): Likewise.
 597         (disable_randomization): Likewise.
 598         (non_stop): Likewise.
 599         (non_stop_1): Likewise.
 600         (observer_mode): Likewise.
 601         (observer_mode_1): Likewise.
 602         (set_observer_mode): Update.
 603         (sched_multi): Change to bool.
 604         * infrun.h (debug_displaced): Likewise.
 605         (sched_multi): Likewise.
 606         (step_stop_if_no_debug): Likewise.
 607         (non_stop): Likewise.
 608         (disable_randomization): Likewise.
 609         * linux-tdep.c (use_coredump_filter): Likewise.
 610         (dump_excluded_mappings): Likewise.
 611         * linux-thread-db.c (auto_load_thread_db): Likewise.
 612         (check_thread_db_on_load): Likewise.
 613         * main.c (captured_main_1): Update.
 614         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
 615         xx2_opt, boolean_opt>: Change to bool.
 616         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
 617         * maint.c (maintenance_profile_p): Likewise.
 618         (per_command_time): Likewise.
 619         (per_command_space): Likewise.
 620         (per_command_symtab): Likewise.
 621         * memattr.c (inaccessible_by_default): Likewise.
 622         * mi/mi-main.c (mi_async): Likewise.
 623         (mi_async_1): Likewise.
 624         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
 625         * nat/fork-inferior.h (startup_with_shell): Likewise.
 626         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
 627         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
 628         * nios2-tdep.c (nios2_debug): Likewise.
 629         * or1k-tdep.c (or1k_debug): Likewise.
 630         * parse.c (parser_debug): Likewise.
 631         * parser-defs.h (parser_debug): Likewise.
 632         * printcmd.c (print_symbol_filename): Likewise.
 633         * proc-api.c (procfs_trace): Likewise.
 634         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
 635         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
 636         (set_parameter_value): Update.
 637         (add_setshow_generic): Update.
 638         * python/py-value.c (copy_py_bool_obj): Change argument from int*
 639         to bool*.
 640         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
 641         int*.
 642         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
 643         * record-btrace.c (record_btrace_target::store_registers): Update.
 644         * record-full.c (record_full_memory_query): Change to bool.
 645         (record_full_stop_at_limit): Likewise.
 646         * record-full.h (record_full_memory_query): Likewise.
 647         * remote-notif.c (notif_debug): Likewise.
 648         * remote-notif.h (notif_debug): Likewise.
 649         * remote.c (use_range_stepping): Likewise.
 650         (interrupt_on_connect): Likewise.
 651         (remote_break): Likewise.
 652         * ser-tcp.c (tcp_auto_retry): Likewise.
 653         * ser-unix.c (serial_hwflow): Likewise.
 654         * skip.c (debug_skip): Likewise.
 655         * solib-aix.c (solib_aix_debug): Likewise.
 656         * spu-tdep.c (spu_stop_on_load_p): Likewise.
 657         (spu_auto_flush_cache_p): Likewise.
 658         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
 659         Likewise.
 660         (struct info_print_options) <quiet>: Likewise.
 661         * symfile-debug.c (debug_symfile): Likewise.
 662         * symfile.c (auto_solib_add): Likewise.
 663         (separate_debug_file_debug): Likewise.
 664         * symfile.h (auto_solib_add): Likewise.
 665         (separate_debug_file_debug): Likewise.
 666         * symtab.c (basenames_may_differ): Likewise.
 667         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
 668         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
 669         (struct info_types_options) <quiet>: Likewise.
 670         * symtab.h (demangle): Likewise.
 671         (basenames_may_differ): Likewise.
 672         * target-dcache.c (stack_cache_enabled_1): Likewise.
 673         (code_cache_enabled_1): Likewise.
 674         * target.c (trust_readonly): Likewise.
 675         (may_write_registers): Likewise.
 676         (may_write_memory): Likewise.
 677         (may_insert_breakpoints): Likewise.
 678         (may_insert_tracepoints): Likewise.
 679         (may_insert_fast_tracepoints): Likewise.
 680         (may_stop): Likewise.
 681         (auto_connect_native_target): Likewise.
 682         (target_stop_and_wait): Update.
 683         (target_async_permitted): Change to bool.
 684         (target_async_permitted_1): Likewise.
 685         (may_write_registers_1): Likewise.
 686         (may_write_memory_1): Likewise.
 687         (may_insert_breakpoints_1): Likewise.
 688         (may_insert_tracepoints_1): Likewise.
 689         (may_insert_fast_tracepoints_1): Likewise.
 690         (may_stop_1): Likewise.
 691         * target.h (target_async_permitted): Likewise.
 692         (may_write_registers): Likewise.
 693         (may_write_memory): Likewise.
 694         (may_insert_breakpoints): Likewise.
 695         (may_insert_tracepoints): Likewise.
 696         (may_insert_fast_tracepoints): Likewise.
 697         (may_stop): Likewise.
 698         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
 699         (make_thread_apply_all_options_def_group): Change argument from int*
 700         to bool*.
 701         (thread_apply_all_command): Update.
 702         (print_thread_events): Change to bool.
 703         * top.c (confirm): Likewise.
 704         (command_editing_p): Likewise.
 705         (history_expansion_p): Likewise.
 706         (write_history_p): Likewise.
 707         (info_verbose): Likewise.
 708         * top.h (confirm): Likewise.
 709         (history_expansion_p): Likewise.
 710         * tracepoint.c (disconnected_tracing): Likewise.
 711         (circular_trace_buffer): Likewise.
 712         * typeprint.c (print_methods): Likewise.
 713         (print_typedefs): Likewise.
 714         * utils.c (debug_timestamp): Likewise.
 715         (sevenbit_strings): Likewise.
 716         (pagination_enabled): Likewise.
 717         * utils.h (sevenbit_strings): Likewise.
 718         (pagination_enabled): Likewise.
 719         * valops.c (overload_resolution): Likewise.
 720         * valprint.h (struct value_print_options) <prettyformat_arrays,
 721         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
 722         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
 723         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
 724         Likewise.
 725         * windows-nat.c (new_console): Likewise.
 726         (cygwin_exceptions): Likewise.
 727         (new_group): Likewise.
 728         (debug_exec): Likewise.
 729         (debug_events): Likewise.
 730         (debug_memory): Likewise.
 731         (debug_exceptions): Likewise.
 732         (useshell): Likewise.
 733         * windows-tdep.c (maint_display_all_tib): Likewise.
 734         * xml-support.c (debug_xml): Likewise.
 735
 736 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
 737
 738         * source.c (prepare_path_for_appending): New function.
 739         (openp): Make use of new function.
 740         (find_and_open_source): Search for the compilation directory and
 741         source file as a relative path beneath the directory search path.
 742
 743 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 744
 745         * source-cache.c (source_cache::get_line_charpos): Catch
 746         exceptions and return false, this matches the behaviour documented
 747         in the header file.
 748
 749 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
 750
 751         * ada-tasks.c (info_task): Remove quoting of the task's name.
 752
 753 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
 754
 755         * symfile.c (auto_solib_add): Replace comment with a reference
 756         to the header file.
 757
 758 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
 759
 760         * NEWS: Mention that gdb can now be compiled with Python 3
 761         on Windows.
 762
 763 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 764
 765         * maint.c (maint_print_section_data::maint_print_section_data):
 766         Force use of 'float log10 (float)' by casting the argument to
 767         float.
 768
 769 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 770
 771         * maint.c: Add 'cmath' include.
 772         (struct maint_print_section_data): New structure.
 773         (print_section_index): New function.
 774         (print_bfd_section_info): Add header comment, small whitespace
 775         cleanup, and update to call new print_section_index function.
 776         (print_objfile_section_info): Likewise.
 777         (maint_obj_section_from_bfd_section): New function.
 778         (print_bfd_section_info_maybe_relocated): New function.
 779         (maintenance_info_sections): Add header comment, always use
 780         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
 781
 782 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 783
 784         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
 785         inner scope, add check that the objfile has psymtabs before
 786         checking psymtabs_addrmap.
 787         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
 788
 789 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 790
 791         * NEWS: Announce that Ada task names are now shown at more places,
 792         and between quotes (except in info task output).
 793         * gdb/ada-tasks.c (task_to_str): New function.
 794         (display_current_task_id): Call task_to_str.
 795         (task_command_1): Likewise.
 796         (print_ada_task_info): In non-mi mode, Properly align headers and data
 797         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
 798
 799 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 800
 801         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
 802         prstatus.pr_lwp.pr_info instead of making it up.
 803
 804 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 805
 806         * auto-load.c (auto_load_expand_dir_vars): Update.
 807         * defs.h (gdb_datadir): Change to std::string.
 808         (python_libdir): Likewise.
 809         (relocate_gdb_directory): Change return type to std::string.
 810         * guile/guile.c (gdbscm_data_directory): Update.
 811         (initialize_scheme_side): Update.
 812         * jit.c (jit_reader_dir): Change to std::string.
 813         (jit_reader_load_command): Update.
 814         * main.c (gdb_datadir): Change to std::string.
 815         (python_libdir): Likewise.
 816         (set_gdb_data_directory): Update.
 817         (relocate_path): Change to return std::string.
 818         (relocate_gdb_directory): Change to return std::string.
 819         (relocate_gdbinit_path_maybe_in_datadir): Update.
 820         (captured_main_1): Update.
 821         * python/python.c (do_start_initialization): Update.
 822         * top.c (show_gdb_datadir): Update.
 823         * xml-syscall.c (xml_init_syscalls_info): Update.
 824         (init_syscalls_info): Update.
 825
 826 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 827
 828         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
 829         out of get_init_files.
 830         (get_init_files): Update.
 831
 832 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 833
 834         * main.c (get_init_files): Change to use std::string.
 835         (captured_main_1): Update.
 836         (print_gdb_help): Update.
 837
 838 2019-09-11  Ali Tamur  <tamur@google.com>
 839
 840         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
 841         implementation.
 842
 843 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 844
 845         * dbxread.c (read_dbx_symtab): Update.
 846         * dwarf2read.c (load_partial_dies): Update.
 847         * mdebugread.c (parse_partial_symbols): Update.
 848         (handle_psymbol_enumerators): Update.
 849         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
 850         * psymtab.c (add_psymbol_to_bcache): Likewise.
 851         (add_psymbol_to_list): Likewise.
 852         * symtab.c (symbol_set_names): Likewise.
 853         * symtab.h (symbol_set_names): Likewise.
 854         * xcoffread.c (scan_xcoff_symtab): Update.
 855
 856 2019-09-11  Tom Tromey  <tom@tromey.com>
 857
 858         * symfile-mem.c (symbol_file_add_from_memory): Use
 859         bfd_set_filename.
 860         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
 861         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
 862
 863 2019-09-10  Tom Tromey  <tromey@adacore.com>
 864
 865         * dwarf-index-write.c (write_psymbols): Extend error message.
 866         (debug_names::insert): Add Ada code.
 867         (debug_names::write_psymbols): Remove Ada check.
 868         (debug_names) <m_string_obstack>: New member.
 869         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
 870         (gdb_index_symbol_name_matcher::matches): Remove.
 871         (mapped_index_base::find_name_components_bounds): Add "lang"
 872         parameter.
 873         (mapped_index_base::build_name_components): Also split names
 874         according to Ada syntax.
 875         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
 876         type of "match_callback".
 877         (check_match, check_find_bounds_finds)
 878         (dw2_expand_symtabs_matching): Update.
 879         (dw2_debug_names_iterator): Add new constructor.
 880         (dw2_debug_names_map_matching_symbols): New function.
 881         (dw2_debug_names_expand_symtabs_matching): Update.
 882         (dwarf2_debug_names_functions): Use
 883         dw2_debug_names_map_matching_symbols.
 884
 885 2019-09-10  Tom Tromey  <tromey@adacore.com>
 886
 887         * dwarf2read.c (dw2_get_file_names_reader): Add the
 888         CU's file name to the results.
 889
 890 2019-09-10  Tom Tromey  <tromey@adacore.com>
 891
 892         * ada-lang.c (add_nonlocal_symbols): Combine calls to
 893         map_matching_symbols.  Update.
 894         * dwarf2read.c (dw2_map_matching_symbols): Update.
 895         * psymtab.c (match_partial_symbol): Change type; update.
 896         (psym_map_matching_symbols): Likewise.
 897         * symfile-debug.c (debug_qf_map_matching_symbols): Change
 898         type; update.
 899         * symfile.h (struct quick_symbol_functions)
 900         <map_matching_symbols>: Change "name" to be a lookup_name_info.
 901         Remove "match".
 902
 903 2019-09-10  Tom Tromey  <tromey@adacore.com>
 904
 905         * psymtab.c (map_block): Remove.
 906         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
 907         * symtab.c (iterate_over_symbols_terminated): New function.
 908         * symtab.c (iterate_over_symbols_terminated): Declare.
 909
 910 2019-09-10  Tom Tromey  <tromey@adacore.com>
 911
 912         * ada-lang.c (ada_iterate_over_symbols): Return bool.
 913         * language.h (struct language_defn) <la_iterate_over_symbols>:
 914         Return bool.
 915         * symtab.c (iterate_over_symbols): Return bool.
 916         * symtab.h (iterate_over_symbols): Return bool.
 917
 918 2019-09-10  Tom Tromey  <tromey@adacore.com>
 919
 920         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
 921         (add_nonlocal_symbols): Update.
 922         * dwarf2read.c (dw2_map_matching_symbols): Change type.
 923         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
 924         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
 925         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
 926         Change type of "callback".  Remove "data".
 927
 928
 929 2019-09-09  Ali Tamur  <tamur@google.com>
 930
 931         * dwarf2read.c (comp_unit_head): Update comment.
 932         (dwarf2_dwo_name): New function declaration.
 933         (dwarf_unit_type_name): New function declaration.
 934         (read_comp_unit_head): Add support for new compilation units,
 935         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
 936         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
 937         (currently named as "signature") in their header. Also clarify error
 938         messages.
 939         (lookup_dwo_id): New function. Returns the dwo id of the given
 940         compile unit.
 941         (lookup_dwo_unit): Use the new lookup_dwo_id function.
 942         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
 943         functions.
 944         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
 945         (dwarf2_dwo_name): Get the dwo name if present.
 946         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
 947         purposes.
 948
 949 2019-09-09  Tom Tromey  <tom@tromey.com>
 950
 951         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
 952
 953 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 954
 955         * python/python.c (do_start_initialization): Make progname_copy static,
 956         to avoid a leak report.
 957
 958 2019-09-08  Tom Tromey  <tom@tromey.com>
 959
 960         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
 961
 962 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
 963
 964         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
 965         Change type to gdb::optional<block_enum>.
 966         (dw2_symtab_iter_init): Change block_index parameter type
 967         to gdb::optional<block_enum>.
 968         (dw2_lookup_symbol): Change block_index parameter
 969         type to block_enum.c
 970         (dw2_debug_names_lookup_symbol): Likewise.
 971         * psymtab.c (psym_lookup_symbol): Likewise.
 972         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
 973         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
 974         Likewise.
 975
 976 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
 977
 978         * defs.h (relocate_gdb_directory): Change int to bool in
 979         signature and rename flag to relocatable.
 980         * main.c (relocate_path): Likewise.
 981         (relocate_gdb_directory): Likewise.
 982
 983 2019-09-06  Alan Modra  <amodra@gmail.com>
 984
 985         * coffread.c (coff_symfile_read): Constify filename variable.
 986         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
 987         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
 988         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
 989         * solib.c (reload_shared_libraries_1): Likewise.
 990         * symfile.c (reread_symbols): Likewise.
 991         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
 992         * solib-darwin.c (darwin_bfd_open): Likewise.
 993         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
 994
 995 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 996
 997         * psymtab.c (print_partial_symbols): Handle missing domain_enum
 998         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
 999
1000 2019-09-03  Tom Tromey  <tromey@adacore.com>
1001
1002         * ada-valprint.c (ada_val_print_num): Don't recurse for range
1003         types.
1004         (has_negatives): Unbias a range type bound.
1005         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
1006         * gdbtypes.c (operator==): Handle new field.
1007         (create_range_type): Add "bias" parameter.
1008         (create_static_range_type, resolve_dynamic_range): Update.
1009         * gdbtypes.h (struct range_bounds) <bias>: New member.
1010         (create_range_type): Add bias parameter.
1011         * printcmd.c (print_scalar_formatted): Unbias range types.
1012         * value.c (unpack_long): Unbias range types.
1013         (pack_long): Bias range types.
1014
1015 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1016
1017         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
1018         probe arguments.
1019
1020 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1021
1022         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
1023         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
1024         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
1025         (compile_probe_arg): Likewise.
1026         * probe.h (get_argument_count): Likewise.
1027         * solib-svr4.c (solib_event_probe_action): Likewise.
1028         * stap-probe.c (stap_probe::get_argument_count): Likewise.
1029
1030 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1031
1032         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
1033         code to here...
1034         (svr4_create_solib_event_breakpoints): ...from here.
1035
1036 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
1037
1038         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
1039         suffix from warning message.
1040
1041 2019-08-30  Tom Tromey  <tom@tromey.com>
1042
1043         * tui/tui-winsource.h (struct tui_source_window_base)
1044         <refresh_all>: Don't declare.
1045         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
1046         Remove.
1047         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
1048         tui_show_locator_content.
1049         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
1050         declare.
1051         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
1052         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
1053         declare.
1054
1055 2019-08-30  Tom Tromey  <tom@tromey.com>
1056
1057         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
1058
1059 2019-08-30  Tom Tromey  <tom@tromey.com>
1060
1061         * tui/tui-stack.c (_initialize_tui_stack): Move later.
1062         Remove unnecessary forward declarations.
1063
1064 2019-08-30  Tom Tromey  <tom@tromey.com>
1065
1066         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
1067         rerender.
1068         (tui_update_locator_fullname, tui_show_frame_info): Don't call
1069         tui_show_locator_content.
1070
1071 2019-08-30  Tom Tromey  <tom@tromey.com>
1072
1073         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
1074         (tui_locator_window::rerender): Rewrite using body of previous
1075         tui_show_locator_content.
1076
1077 2019-08-30  Tom Tromey  <tom@tromey.com>
1078
1079         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
1080         set_locator_fullname>: New methods.
1081         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1082         Rename from tui_set_locator_fullname.
1083         (tui_locator_window::set_locator_info): Rename from
1084         tui_set_locator_info.  Return bool.
1085         (tui_update_locator_fullname, tui_show_frame_info): Update.
1086
1087 2019-08-30  Tom Tromey  <tom@tromey.com>
1088
1089         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
1090
1091 2019-08-30  Tom Tromey  <tom@tromey.com>
1092
1093         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
1094         call touchwin.
1095
1096 2019-08-30  Tom Tromey  <tom@tromey.com>
1097
1098         * tui/tui-wingeneral.c (box_win): Assume win_info and
1099         win_info->handle cannot be NULL.
1100
1101 2019-08-30  Tom Tromey  <tom@tromey.com>
1102
1103         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
1104         refresh_window>: Declare.
1105         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
1106         resize.
1107         (tui_data_item_window::rerender): Rename from
1108         tui_display_register.
1109         (tui_data_item_window::refresh_window): New method.
1110         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
1111         no-op.
1112
1113 2019-08-30  Tom Tromey  <tom@tromey.com>
1114
1115         * tui/tui-regs.h (struct tui_data_window) <regs_content,
1116         regs_column_count, current_group>: Move later.  Now private.
1117         <get_current_group>: New method.
1118         * tui/tui-regs.c (tui_reg_command): Update.
1119         * tui/tui-layout.c (tui_set_layout): Update.
1120
1121 2019-08-30  Tom Tromey  <tom@tromey.com>
1122
1123         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1124         (tui_data_window::rerender): Don't call
1125         check_and_display_highlight_if_needed.
1126         (tui_data_window::refresh_all): Remove call to
1127         erase_data_content.
1128
1129 2019-08-30  Tom Tromey  <tom@tromey.com>
1130
1131         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1132         (tui_data_window::display_registers_from)
1133         (tui_data_window::display_reg_element_at_line)
1134         (tui_data_window::display_registers_from_line): Remove checks of
1135         "empty".
1136
1137 2019-08-30  Tom Tromey  <tom@tromey.com>
1138
1139         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
1140         Don't declare.
1141         * tui/tui-regs.c (tui_data_window::show_registers): Call
1142         rerender.
1143         (tui_data_window::rerender): Rename from display_all_data.
1144         (tui_data_window::rerender): Remove old implementation.
1145
1146 2019-08-30  Tom Tromey  <tom@tromey.com>
1147
1148         * tui/tui-regs.c (tui_data_window::display_all_data): Change
1149         text.
1150         * tui/tui-data.h (NO_DATA_STRING): Remove define.
1151
1152 2019-08-29  Bernhard Wodok  <barto@gmx.net>
1153             Sergio Durigan Junior  <sergiodj@redhat.com>
1154
1155         PR win32/24284
1156         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
1157
1158 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1159
1160         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
1161         when searching for types.
1162
1163 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1164
1165         * f-lang.c (f_language_defn): Use f_print_typedef.
1166         * f-lang.h (f_print_typedef): Declare.
1167         * f-typeprint.c (f_print_typedef): Define.
1168
1169 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
1170
1171         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
1172
1173 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1174
1175         * cli/cli-utils.c (info_print_options_defs): Delete.
1176         (make_info_print_options_def_group): Delete.
1177         (extract_info_print_options): Delete.
1178         (info_print_command_completer): Delete.
1179         (info_print_args_help): Add extra parameter, and optionally
1180         include text about -n flag.
1181         * cli/cli-utils.h (struct info_print_options): Delete.
1182         (extract_info_print_options): Delete declaration.
1183         (info_print_command_completer): Delete declaration.
1184         (info_print_args_help): Add extra parameter, extend header
1185         comment.
1186         * python/python.c (gdbpy_rbreak): Pass additional parameter to
1187         search_symbols.
1188         * stack.c (struct info_print_options): New type.
1189         (info_print_options_defs): New file scoped variable.
1190         (make_info_print_options_def_group): New static function.
1191         (info_print_command_completer): New static function.
1192         (info_locals_command): Update to use new local functions.
1193         (info_args_command): Likewise.
1194         (_initialize_stack): Add extra parameter to calls to
1195         info_print_args_help.
1196         * symtab.c (search_symbols): Add extra parameter, use this to
1197         possibly excluse non-debug symbols.
1198         (symtab_symbol_info): Add extra parameter, which is passed on to
1199         search_symbols.
1200         (struct info_print_options): New type.
1201         (info_print_options_defs): New file scoped variable.
1202         (make_info_print_options_def_group): New static function.
1203         (info_print_command_completer): New static function.
1204         (info_variables_command): Update to use local functions, and pass
1205         extra parameter through to symtab_symbol_info.
1206         (info_functions_command): Likewise.
1207         (info_types_command): Pass additional argument through to
1208         symtab_symbol_info.
1209         (rbreak_command): Pass extra argument to search_symbols.
1210         (_initialize_symtab): Add extra arguments for calls to
1211         info_print_args_help, and update help text for 'info variables',
1212         'whereis', and 'info functions' commands.
1213         * symtab.h (search_symbols): Add extra argument to declaration.
1214         * NEWS: Mention new flags.
1215
1216 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
1217
1218         * symtab.c (lookup_static_symbol): Call the new function (and move
1219         it down to be next to lookup_global_symbol).
1220         (struct global_sym_lookup_data): Add block_enum member and rename to...
1221         (struct global_or_static_sym_lookup_data): ...this.
1222         (lookup_symbol_global_iterator_cb): Pass block_index instead of
1223         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
1224         (lookup_symbol_global_or_static_iterator_cb): ...this.
1225         (lookup_global_or_static_symbol): New function.
1226         (lookup_global_symbol): Call new function.
1227
1228 2019-08-26  Tom de Vries  <tdevries@suse.de>
1229
1230         PR c++/24852
1231         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
1232         when pc_probe.prob == NULL.
1233
1234 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1235
1236         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
1237         variable symbol_linkage to symbol_linkage_.
1238
1239 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1240
1241         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
1242         represent whether the symbol is static, dynamic, or we don't
1243         know.
1244
1245 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
1246
1247         * gdb/rx-tdep.c (rx_register_names): New.
1248         (rx_register_name): Delete.
1249         (rx_psw_type): Delete.
1250         (rx_fpsw_type): Delete.
1251         (rx_register_type): Delete.
1252         (rx_gdbarch_init): Convert target-descriptions.
1253         (_initialize_rx_tdep): Add initialize_tdesc_rx.
1254         * gdb/features/Makefile: Add rx.xml.
1255         * gdb/features/rx.xml: New.
1256         * gdb/features/rx.c: Generated.
1257         * gdb/NEWS: Mention target description support.
1258
1259 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1260
1261         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
1262         *slot_ptr.
1263
1264 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1265
1266         * configure.ac: Don't check for 'dlfcn.h' (moved to
1267         gdbsupport/common.m4).
1268         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
1269         'gdbsupport/'.
1270         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
1271         * compile/compile-c-support.c: Include
1272         'gdbsupport/gdb-dlfcn.h'.
1273         * gdbsupport/common.m4: Check for 'dlfcn.h'.
1274         * gdb-dlfcn.c: Move to...
1275         * gdbsupport/gdb-dlfcn.c: ... here.
1276         * gdb-dlfcn.h: Move to...
1277         * gdbsupport/gdb-dlfcn.h: ... here.
1278
1279 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
1280
1281         * nios2-tdep.c (struct reg_value): Improve comments.  Make
1282         the offset field signed.
1283
1284 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1285
1286         * python/lib/gdb/__init__.py (_execute_file): New function.
1287         * python/python.c (python_run_simple_file): Call gdb._execute_file
1288         on Windows.
1289
1290 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1291
1292         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
1293         all uses as this was never set to anything but a zero value.
1294
1295 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
1296
1297         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
1298
1299 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
1300
1301         * tui/tui-data.h (tui_gen_win_info): Add an =default
1302         move constructor, required by some GCC versions.
1303
1304 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
1305
1306         * go32-nat.c (go32_sysinfo): Add hygon_p.
1307
1308 2019-08-20  Tom Tromey  <tom@tromey.com>
1309
1310         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
1311         line_from_reg_element_no, first_reg_element_no_inline,
1312         display_all_data, delete_data_content_windows,
1313         erase_data_content>: Now private.
1314
1315 2019-08-20  Tom Tromey  <tom@tromey.com>
1316
1317         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
1318         (tui_unhighlight_win, tui_highlight_win)
1319         (tui_win_info::make_window): Update.
1320         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
1321
1322 2019-08-20  Tom Tromey  <tom@tromey.com>
1323
1324         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1325         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1326         (MAX_PID_WIDTH): Move to tui-stack.c.
1327         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1328         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1329         (MAX_PID_WIDTH): Move from tui-data.h.
1330
1331 2019-08-20  Tom Tromey  <tom@tromey.com>
1332
1333         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
1334         * tui/tui-wingeneral.c (box_win): Change type of win_info.
1335         (box_win): Update.
1336         (tui_gen_win_info::make_window): Rename from tui_make_window.
1337         (tui_win_info::make_window): New method.
1338         (tui_gen_win_info::make_visible): Update.
1339         * tui/tui-source.c (tui_source_window::set_contents): Update.
1340         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
1341         (tui_data_window::display_registers_from): Update.
1342         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1343         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
1344         Declare.
1345         <can_box>: Remove.
1346         <title>: Remove.
1347         (struct tui_win_info) <make_window>: Declare.
1348         <can_box>: Now virtual.
1349         <title>: New member.
1350         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
1351         * tui/tui-command.c (tui_cmd_window::resize): Update.
1352
1353 2019-08-20  Tom Tromey  <tom@tromey.com>
1354
1355         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
1356         * tui/tui-regs.c (tui_data_window::show_registers): Update.
1357         (tui_data_window::check_register_values): Update.
1358
1359 2019-08-20  Tom Tromey  <tom@tromey.com>
1360
1361         * tui/tui-regs.h (struct tui_data_window): Use
1362         DISABLE_COPY_AND_ASSIGN.
1363         <regs_content>: Change type, removing unique_ptr.
1364         <tui_data_window>: Add move constructor.
1365         * tui/tui-regs.c (tui_data_window::show_registers)
1366         (tui_data_window::show_register_group)
1367         (tui_data_window::display_registers_from)
1368         (tui_data_window::display_registers_from)
1369         (tui_data_window::first_data_item_displayed)
1370         (tui_data_window::delete_data_content_windows)
1371         (tui_data_window::rerender, tui_data_window::refresh_window)
1372         (tui_data_window::check_register_values): Update.
1373
1374 2019-08-20  Tom Tromey  <tom@tromey.com>
1375
1376         * tui/tui-regs.h (struct tui_data_window) <show_registers,
1377         show_register_group>: Declare.
1378         (tui_show_register_group): Don't declare.
1379         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
1380         tui_show_registers.
1381         (tui_data_window::show_register_group): Rename from
1382         tui_show_register_group.
1383         (tui_data_window::check_register_values, tui_reg_command):
1384         Update.
1385         * tui/tui-layout.c (tui_set_layout): Update.
1386
1387 2019-08-20  Tom Tromey  <tom@tromey.com>
1388
1389         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
1390         Declare.
1391         (tui_check_register_values): Don't declare.
1392         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
1393         from tui_check_register_values.
1394         * tui/tui-hooks.c (tui_register_changed): Update.
1395
1396 2019-08-20  Tom Tromey  <tom@tromey.com>
1397
1398         * tui/tui-regs.c (tui_reg_layout): Move later.
1399         (tui_show_registers): Don't enable TUI mode or change layout.
1400
1401 2019-08-20  Tom Tromey  <tom@tromey.com>
1402
1403         * tui/tui-regs.h (struct tui_data_item_window)
1404         <~tui_data_item_window>: Remove.
1405         <content>: Now a unique_xmalloc_ptr.
1406         * tui/tui-regs.c (tui_register_format): Return a
1407         unique_xmalloc_ptr.
1408         (tui_get_register): Update.
1409         (~tui_data_item_window): Remove.
1410         (tui_data_window::display_registers_from, tui_display_register):
1411         Update.
1412         * tui/tui-io.h (tui_expand_tabs): Update.
1413         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
1414         Remove "col" parameter.
1415
1416 2019-08-20  Tom Tromey  <tom@tromey.com>
1417
1418         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
1419         field.
1420         * tui/tui-regs.c (~tui_data_item_window): Update.
1421
1422 2019-08-20  Tom Tromey  <tom@tromey.com>
1423
1424         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
1425         earlier.
1426
1427 2019-08-20  Tom Tromey  <tom@tromey.com>
1428
1429         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
1430
1431 2019-08-20  Tom Tromey  <tom@tromey.com>
1432
1433         * tui/tui-source.h (struct tui_source_window): Update.
1434         * tui/tui-regs.c (tui_show_registers): Update.
1435         * tui/tui-disasm.h (struct tui_disasm_window): Update.
1436         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
1437         (NO_REGS_STRING): Remove defines.
1438
1439 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
1440
1441         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
1442         unnecessary thread walk if remote doesn't support the packet.
1443
1444 2019-08-19  Tom Tromey  <tromey@adacore.com>
1445
1446         * python/py-value.c (value_has_field): Fix indentation.
1447
1448 2019-08-19  Tom Tromey  <tromey@adacore.com>
1449
1450         * printcmd.c (do_one_display, info_display_command): Update.
1451         * block.h (contained_in): Return bool.  Add allow_nested
1452         parameter.
1453         * block.c (contained_in): Return bool.  Add allow_nested
1454         parameter.
1455
1456 2019-08-19  Tom Tromey  <tom@tromey.com>
1457
1458         * configure: Rebuild.
1459         * configure.ac: Disallow the combination of -static-libstdc++ and
1460         source highlight.
1461         * source-cache.c (get_language_name): Handle rust.
1462         (source_cache::get_source_lines): Ignore highlighting exceptions.
1463
1464 2019-08-16  Tom Tromey  <tom@tromey.com>
1465
1466         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
1467         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
1468         (struct tui_source_window_base) <make_visible, refresh_window,
1469         resize>: Remove methods.
1470         <execution_info>: Remove field.
1471         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
1472         (tui_show_source_line, tui_source_window_base)
1473         (~tui_source_window_base): Update.
1474         (tui_source_window_base::resize)
1475         (tui_source_window_base::make_visible)
1476         (tui_source_window_base::refresh_window): Remove.
1477         (tui_source_window_base::update_exec_info): Update.
1478         * tui/tui-source.c (tui_source_window::set_contents): Update.
1479         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1480
1481 2019-08-16  Tom Tromey  <tom@tromey.com>
1482
1483         * tui/tui-hooks.c (tui_remove_hooks): Don't set
1484         deprecated_query_hook.
1485
1486 2019-08-16  Tom Tromey  <tom@tromey.com>
1487
1488         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1489         (tui_update_source_windows_with_line): Update.
1490         * tui/tui-source.h (struct tui_source_window)
1491         <show_symtab_source>: Declare.
1492         (tui_show_symtab_source): Don't declare.
1493         * tui/tui-source.c (tui_show_symtab_source): Rename from
1494         tui_show_symtab_source.
1495
1496 2019-08-16  Tom Tromey  <tom@tromey.com>
1497
1498         * tui/tui-winsource.h (struct tui_source_window_base)
1499         <set_contents>: Declare.
1500         * tui/tui-winsource.c
1501         (tui_source_window_base::update_source_window_as_is): Update.
1502         * tui/tui-source.h (struct tui_source_window) <set_contents>:
1503         Declare.
1504         (tui_set_source_content): Don't declare.
1505         * tui/tui-source.c (tui_source_window::set_contents): Rename from
1506         tui_set_source_content.
1507         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
1508         Declare.
1509         (tui_set_disassem_content): Don't declare.
1510         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
1511         tui_set_disassem_content.
1512
1513 2019-08-16  Tom Tromey  <tom@tromey.com>
1514
1515         * tui/tui-winsource.h (struct tui_source_window_base)
1516         <update_breakpoint_info>: Declare.
1517         (tui_update_breakpoint_info): Don't declare.
1518         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
1519         (tui_update_all_breakpoint_info): Update.
1520         (tui_source_window_base::update_breakpoint_info): Rename from
1521         tui_update_breakpoint_info.
1522         (tui_source_window_base::update_exec_info): Update.
1523
1524 2019-08-16  Tom Tromey  <tom@tromey.com>
1525
1526         * tui/tui-winsource.h (struct tui_source_window_base)
1527         <update_source_window>: Declare.
1528         (tui_update_source_window): Don't declare.
1529         * tui/tui-winsource.c
1530         (tui_source_window_base::update_source_window): Rename from
1531         tui_update_source_window.
1532         (tui_source_window_base::rerender): Update.
1533         * tui/tui-source.c (tui_source_window::maybe_update): Update.
1534         * tui/tui-disasm.c (tui_show_disassem)
1535         (tui_show_disassem_and_update_source)
1536         (tui_disasm_window::maybe_update): Update.
1537
1538 2019-08-16  Tom Tromey  <tom@tromey.com>
1539
1540         * tui/tui-winsource.h (struct tui_source_window_base)
1541         <update_source_window_as_is>: Declare.
1542         (tui_update_source_window_as_is): Don't declare.
1543         * tui/tui-winsource.c (tui_update_source_window): Update
1544         (tui_source_window_base::update_source_window_as_is): Rename from
1545         tui_update_source_window_as_is.
1546         (tui_source_window_base::refill): Update.
1547         * tui/tui-source.c (tui_show_symtab_source): Update.
1548         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
1549         Update.
1550
1551 2019-08-16  Tom Tromey  <tom@tromey.com>
1552
1553         * tui/tui-winsource.h (tui_update_source_window)
1554         (tui_update_source_window_as_is): Remove "noerror" parameter.
1555         * tui/tui-winsource.c (tui_update_source_window)
1556         (tui_update_source_window_as_is): Remove "noerror" parameter.
1557         (tui_update_source_windows_with_addr)
1558         (tui_update_source_windows_with_line)
1559         (tui_source_window_base::rerender)
1560         (tui_source_window_base::refill): Update.
1561         * tui/tui-source.h (tui_set_source_content)
1562         (tui_show_symtab_source): Remove "noerror" parameter.
1563         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
1564         parameter.
1565         (tui_show_symtab_source): Likewise.
1566         (tui_source_window::maybe_update): Update.
1567         * tui/tui-disasm.c (tui_show_disassem)
1568         (tui_show_disassem_and_update_source)
1569         (tui_disasm_window::do_scroll_vertical)
1570         (tui_disasm_window::maybe_update): Update.
1571
1572 2019-08-16  Tom Tromey  <tom@tromey.com>
1573
1574         * tui/tui.c (tui_is_window_visible): Update.
1575         * tui/tui-wingeneral.c (tui_make_window)
1576         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
1577         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
1578         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
1579         (tui_set_win_height_command, parse_scrolling_args): Update.
1580         * tui/tui-source.c (tui_source_window::style_changed): Update.
1581         * tui/tui-regs.c (tui_show_registers)
1582         (tui_data_window::first_data_item_displayed)
1583         (tui_data_window::delete_data_content_windows)
1584         (tui_check_register_values, tui_reg_command): Update.
1585         * tui/tui-disasm.c (tui_show_disassem): Update.
1586         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
1587         method.
1588         <is_visible>: Remove field.
1589         * tui/tui-data.c (tui_next_win, tui_prev_win)
1590         (tui_delete_invisible_windows): Update.
1591
1592 2019-08-16  Tom Tromey  <tom@tromey.com>
1593
1594         * tui/tui-winsource.h (struct tui_source_window_base)
1595         <m_has_locator>: Remove.
1596         * tui/tui-layout.c (show_source_disasm_command, show_data)
1597         (show_source_or_disasm_and_command): Update.
1598
1599 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
1600
1601         * NEWS (Other MI changes): New subsection.
1602         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
1603         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
1604         * arch-utils.c (default_get_pc_address_flags): New function.
1605         * arch-utils.h (default_get_pc_address_flags): New declaration.
1606         * gdbarch.sh: Add get_pc_address_flags.
1607         * gdbarch.c: Regenerate.
1608         * gdbarch.h: Likewise.
1609         * stack.c (print_pc): New function.
1610         (print_frame_info) (print_frame): Call print_pc.
1611
1612 2019-08-16  Tom de Vries  <tdevries@suse.de>
1613
1614         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
1615         print_objfile_section_info.
1616
1617 2019-08-15  Tom Tromey  <tom@tromey.com>
1618
1619         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
1620         calling update_cmdwin_start_line.
1621         * tui/tui-winsource.h (struct tui_source_window_base)
1622         <do_make_visible_with_new_height, set_new_height>: Don't declare.
1623         <rerender>: Declare.
1624         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
1625         Call rerender.
1626         (tui_source_window_base::set_new_height): Remove.
1627         (tui_source_window_base::rerender): Rename from
1628         do_make_visible_with_new_height.
1629         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
1630         resize method.
1631         (tui_win_info::make_invisible_and_set_new_height)
1632         (tui_win_info::make_visible_with_new_height): Remove.
1633         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
1634         Declare.
1635         * tui/tui-stack.c (tui_locator_window::rerender): New method.
1636         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
1637         do_make_visible_with_new_height>: Don't declare.
1638         <rerender>: Declare.
1639         * tui/tui-regs.c (tui_data_window::rerender): Rename from
1640         set_new_height.
1641         (tui_data_window::do_make_visible_with_new_height): Remove.
1642         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
1643         call tui_show_locator_content.
1644         (tui_gen_win_info::resize): Call rerender.
1645         (show_source_or_disasm_and_command): Don't call
1646         tui_show_locator_content.
1647         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
1648         method.
1649         (struct tui_win_info) <rerender>: Declare.
1650         <set_new_height, make_invisible_and_set_new_height,
1651         make_visible_with_new_height>: Don't declare.
1652         * tui/tui-data.c (tui_win_list::rerender): New method.
1653         * tui/tui-command.h (struct tui_cmd_window)
1654         <do_make_visible_with_new_height>: Don't declare.
1655         * tui/tui-command.c
1656         (tui_cmd_window::do_make_visible_with_new_height): Remove.
1657
1658 2019-08-15  Tom Tromey  <tromey@adacore.com>
1659
1660         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
1661         * ada-lang.c (ada_enum_name): Likewise.
1662
1663 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
1664
1665         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
1666         leading underscore.
1667         (GdbOutputErrorFile): Likewise.
1668         (global scope): Adjust constructor calls to GdbOutput{,Error}File
1669         accordingly.
1670         (execute_unwinders): Rename to have a leading underscore.
1671         (auto_load_packages): Likewise.
1672         (global scope): Adjust call to auto_load_packages accordingly.
1673         (GdbSetPythonDirectory): Likewise.
1674         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
1675         instead of execute_unwinders.
1676
1677 2019-08-15  Tom Tromey  <tom@tromey.com>
1678
1679         * tui/tui-layout.c (show_layout, show_source_disasm_command)
1680         (show_data): Don't change window visibility.
1681         (tui_gen_win_info::resize): Remove special case for command
1682         window.  Use wresize, when available.
1683         (show_source_or_disasm_and_command): Don't change window
1684         visibility.
1685         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
1686         <make_visible>: New method.
1687         * tui/tui-command.c (tui_cmd_window::resize): New method.
1688
1689 2019-08-15  Tom Tromey  <tom@tromey.com>
1690
1691         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
1692         (struct tui_source_windows): New.
1693         * tui/tui-winsource.c (tui_display_main): Update.
1694         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1695         (new_height_ok, parse_scrolling_args): Update.
1696         * tui/tui-layout.c (show_layout, show_data): Update.
1697         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
1698         (tui_add_to_source_windows): Don't declare.
1699         * tui/tui-data.c (source_windows, tui_source_windows)
1700         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
1701
1702 2019-08-15  Tom Tromey  <tom@tromey.com>
1703
1704         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
1705         Rename from reset.
1706         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
1707         * tui/tui-layout.c (show_source_disasm_command, show_data):
1708         Update.
1709         (tui_gen_win_info::resize): Rename.
1710         (show_source_or_disasm_and_command): Update.
1711         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
1712         reset.
1713
1714 2019-08-15  Tom Tromey  <tom@tromey.com>
1715
1716         * tui/tui-stack.c (tui_initialize_static_data): Remove.
1717         * tui/tui-interp.c (tui_interp::init): Don't call
1718         tui_initialize_static_data.
1719         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
1720
1721 2019-08-15  Tom Tromey  <tom@tromey.com>
1722
1723         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
1724         examine tui_win_list.
1725
1726 2019-08-15  Tom Tromey  <tom@tromey.com>
1727
1728         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
1729         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
1730         tui_clear_source_content.
1731         (tui_clear_source_content): Remove.
1732         (tui_source_window_base::do_erase_source_content): Hoist call to
1733         content.clear().
1734         * tui/tui-stack.c (tui_show_frame_info): Don't call
1735         tui_clear_source_content.
1736
1737 2019-08-15  Tom Tromey  <tom@tromey.com>
1738
1739         * tui/tui-winsource.h (struct tui_source_window_base)
1740         <do_erase_source_content>: New method.
1741         <erase_source_content>: New method.
1742         (tui_erase_source_content): Don't declare.
1743         * tui/tui-winsource.c (tui_clear_source_content): Update.
1744         (tui_source_window_base::do_erase_source_content): Rename from
1745         tui_erase_source_content.
1746         (tui_source_window_base::show_source_content): Update.
1747         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1748         * tui/tui-source.h (struct tui_source_window)
1749         <erase_source_content>: New method.
1750         * tui/tui-disasm.h (struct tui_disasm_window)
1751         <erase_source_content>: New method.
1752
1753 2019-08-15  Tom Tromey  <tom@tromey.com>
1754
1755         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
1756         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
1757         constructor.
1758         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
1759         * tui/tui-source.c (tui_set_source_content): Update.
1760         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1761
1762 2019-08-15  Tom Tromey  <tom@tromey.com>
1763
1764         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
1765         * tui/tui-winsource.c (tui_line_is_displayed): Move to
1766         tui-source.c.
1767         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
1768         Declare.
1769         * tui/tui-source.c (tui_source_window::line_is_displayed): New
1770         method.
1771         (tui_source_window::maybe_update): Update.
1772
1773 2019-08-15  Tom Tromey  <tom@tromey.com>
1774
1775         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
1776         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
1777         tui-disasm.c.
1778         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
1779         Declare.
1780         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
1781         method.
1782         (tui_disasm_window::maybe_update): Update.
1783
1784 2019-08-15  Tom Tromey  <tom@tromey.com>
1785
1786         * tui/tui-winsource.h (struct tui_source_window_base)
1787         <maybe_update>: Declare.
1788         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
1789         method.
1790         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
1791         Declare.
1792         * tui/tui-source.c (tui_source_window::maybe_update): New method.
1793         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
1794         Declare.
1795         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
1796
1797 2019-08-15  Tom Tromey  <tom@tromey.com>
1798
1799         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
1800
1801 2019-08-15  Tom Tromey  <tom@tromey.com>
1802
1803         * tui/tui-wingeneral.c: Include tui-stack.h.
1804         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
1805         (struct tui_locator_window): Move from tui-data.h.
1806         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
1807         (tui_initialize_static_data): Move from tui-data.c.
1808         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
1809         (struct tui_locator_window): Move to tui-stack.c.
1810         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
1811         (tui_initialize_static_data): Move to tui-stack.c.
1812
1813 2019-08-15  Tom Tromey  <tom@tromey.com>
1814
1815         * tui/tui-layout.c (show_source_disasm_command)
1816         (show_source_or_disasm_and_command): Use make_visible method, not
1817         tui_make_window.
1818         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
1819         Remove.
1820
1821 2019-08-15  Tom Tromey  <tom@tromey.com>
1822
1823         * tui/tui-wingeneral.h (tui_make_window): Update.
1824         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
1825         parameter.
1826         (tui_gen_win_info::make_visible): Update.
1827         * tui/tui-regs.c (tui_data_window::display_registers_from):
1828         Update.
1829         * tui/tui-layout.c (show_source_disasm_command)
1830         (show_source_or_disasm_and_command): Update.
1831         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
1832         (enum tui_box): Remove.
1833         (struct tui_win_info) <can_box>: New method.
1834         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
1835         method.
1836
1837 2019-08-15  Tom de Vries  <tdevries@suse.de>
1838
1839         * linux-nat-trad.c: Include gdbarch.h.
1840
1841 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
1842
1843         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
1844         register sizes.
1845
1846 2019-08-14  Tom Tromey  <tromey@adacore.com>
1847
1848         * darwin-nat.c: Include gdbarch.h.
1849         * darwin-nat-info.c: Include gdbarch.h.
1850
1851 2019-08-13  Tom Tromey  <tom@tromey.com>
1852
1853         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
1854         Remove.
1855         * tui/tui-data.c (tui_initialize_static_data): Update.
1856
1857 2019-08-13  Tom Tromey  <tom@tromey.com>
1858
1859         * tui/tui-winsource.h (struct tui_exec_info_window)
1860         <~tui_exec_info_window, maybe_allocate_content, get_content,
1861         m_content>: Remove.
1862         (struct tui_source_window_base) <set_exec_info_content,
1863         show_exec_info_content>: Don't declare.
1864         * tui/tui-winsource.c
1865         (tui_exec_info_window::maybe_allocate_content): Remove.
1866         (tui_source_window_base::update_exec_info): Rename from
1867         set_exec_info_content.
1868         (tui_source_window_base::show_exec_info_content)
1869         (tui_source_window_base::update_exec_info): Remove.
1870
1871 2019-08-13  Tom Tromey  <tom@tromey.com>
1872
1873         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
1874         declare.
1875         * tui/tui-winsource.c (tui_update_source_window_as_is)
1876         (tui_update_source_windows_with_addr, tui_erase_source_content):
1877         Update.
1878         (tui_clear_exec_info_content): Remove.
1879
1880 2019-08-13  Tom Tromey  <tom@tromey.com>
1881
1882         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
1883         declare.
1884         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
1885         call tui_erase_exec_info_content.
1886         (tui_clear_exec_info_content): Rename from
1887         tui_erase_exec_info_content.
1888         (tui_clear_exec_info_content): Delete.
1889
1890 2019-08-13  Tom Tromey  <tom@tromey.com>
1891
1892         * tui/tui-winsource.h (struct tui_source_window_base)
1893         <show_exec_info_content>: Declare.
1894         (tui_show_exec_info_content): Don't declare.
1895         * tui/tui-winsource.c
1896         (tui_source_window_base::show_exec_info_content): Rename from
1897         tui_show_exec_info_content.
1898         (tui_source_window_base::update_exec_info): Update.
1899
1900 2019-08-13  Tom Tromey  <tom@tromey.com>
1901
1902         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
1903         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
1904         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
1905         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
1906         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
1907         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
1908         ... here.
1909
1910 2019-08-13  Tom Tromey  <tom@tromey.com>
1911
1912         * tui/tui-winsource.h (struct tui_source_window_base)
1913         <update_exec_info>: Declare.
1914         (tui_update_exec_info): Don't declare.
1915         * tui/tui-winsource.c (tui_update_source_window_as_is)
1916         (tui_source_window_base::refresh_all)
1917         (tui_update_all_breakpoint_info): Update.
1918         (tui_source_window_base::update_exec_info): Rename from
1919         tui_update_exec_info.
1920         * tui/tui-stack.c (tui_show_frame_info): Update.
1921
1922 2019-08-13  Tom Tromey  <tom@tromey.com>
1923
1924         * tui/tui-winsource.h (struct tui_source_window_base)
1925         <set_exec_info_content>: Declare.
1926         (tui_set_exec_info_content): Don't declare.
1927         * tui/tui-winsource.c
1928         (tui_source_window_base::set_exec_info_content): Rename from
1929         tui_set_exec_info_content.
1930         (tui_update_exec_info): Update.
1931
1932 2019-08-13  Tom Tromey  <tom@tromey.com>
1933
1934         * tui/tui-winsource.h (struct tui_source_window_base)
1935         <show_source_content>: Declare.
1936         (tui_show_source_content): Don't declare.
1937         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1938         (tui_source_window_base::show_source_content): Rename from
1939         tui_show_source_content.
1940         (tui_source_window_base::refresh_all): Update.
1941         * tui/tui-layout.c (show_source_disasm_command)
1942         (show_source_or_disasm_and_command): Update.
1943
1944 2019-08-13  Tom Tromey  <tom@tromey.com>
1945
1946         * tui/tui-winsource.c (tui_erase_source_content)
1947         (tui_show_source_content, tui_source_window_base::refresh_all):
1948         Update.
1949         * tui/tui-wingeneral.h
1950         (tui_check_and_display_highlight_if_needed): Don't declare.
1951         * tui/tui-wingeneral.c
1952         (tui_win_info::check_and_display_highlight_if_needed): Rename from
1953         check_and_display_highlight_if_needed.
1954         * tui/tui-win.c (tui_rehighlight_all)
1955         (tui_win_info::make_visible_with_new_height): Update.
1956         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1957         (tui_data_window::erase_data_content)
1958         (tui_data_window::display_all_data): Update.
1959         * tui/tui-data.h (struct tui_win_info)
1960         <check_and_display_highlight_if_needed>: Declare.
1961
1962 2019-08-13  Tom Tromey  <tom@tromey.com>
1963
1964         * tui/tui-win.c (tui_resize_all): Call
1965         tui_delete_invisible_windows.
1966         * tui/tui-layout.c (show_layout): Call
1967         tui_delete_invisible_windows.
1968         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
1969         * tui/tui-data.c (tui_delete_invisible_windows): New function.
1970
1971 2019-08-13  Tom Tromey  <tom@tromey.com>
1972
1973         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
1974         tui_add_win_to_layout.
1975
1976 2019-08-13  Tom Tromey  <tom@tromey.com>
1977
1978         * tui/tui-layout.h (tui_default_win_height): Don't declare.
1979         * tui/tui-layout.c (tui_default_win_height): Now static.
1980
1981 2019-08-13  Tom Tromey  <tom@tromey.com>
1982
1983         * tui/tui-layout.c (show_layout): Unify all layout cases into a
1984         single switch.
1985         (show_source_disasm_command, show_source_or_disasm_and_command):
1986         Don't check current layout.
1987
1988 2019-08-13  Tom Tromey  <tom@tromey.com>
1989
1990         * tui/tui-wingeneral.c (make_all_visible): Remove.
1991         (tui_make_all_invisible): Simplify.
1992         * tui/tui-layout.c (tui_make_all_invisible): Move from
1993         tui-wingeneral.c; simplify.
1994         (show_layout): Hoist call to tui_make_all_invisible.
1995         (show_data): Don't call tui_make_all_invisible.
1996
1997 2019-08-13  Tom Tromey  <tom@tromey.com>
1998
1999         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
2000         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
2001
2002 2019-08-13  Tom Tromey  <tom@tromey.com>
2003
2004         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
2005         tui-data.c.
2006         (show_source_disasm_command, show_data)
2007         (show_source_or_disasm_and_command): Don't use
2008         tui_set_current_layout_to.
2009         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
2010         * tui/tui-data.c (current_layout, tui_current_layout): Move to
2011         tui-layout.c.
2012         (tui_set_current_layout_to): Remove.
2013
2014 2019-08-13  Tom Tromey  <tom@tromey.com>
2015
2016         * tui/tui-layout.c (tui_set_layout): Update.
2017         * tui/tui-data.h (struct tui_layout_def): Remove.
2018         (tui_layout_def): Don't declare.
2019         * tui/tui-data.c (layout_def): Remove.
2020         (tui_layout_def): Remove.
2021
2022 2019-08-13  Tom Tromey  <tom@tromey.com>
2023
2024         * tui/tui-winsource.h (struct tui_source_window_base)
2025         <clear_detail>: No longer "override".
2026         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
2027         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
2028         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
2029         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
2030         Remove.
2031         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
2032
2033 2019-08-13  Tom Tromey  <tromey@adacore.com>
2034
2035         * tracepoint.c: Don't include readline.h or history.h.
2036
2037 2019-08-12  Tom Tromey  <tom@tromey.com>
2038
2039         * configure: Rebuild.
2040         * configure.ac: Check for readline 7.
2041         * NEWS: Mention readline 7 requirement.
2042         * README: Update.
2043
2044 2019-08-12  Tom Tromey  <tom@tromey.com>
2045
2046         * mingw-hdep.c (gdb_select): Remove readline hack.
2047
2048 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2049
2050         * blockframe.c (find_pc_partial_function): Set *block to nullptr
2051         when the function fails.
2052
2053 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
2054
2055         * s390-tdep.c (s390_type_align): New function.
2056         (s390_gdbarch_init): Set it as type_align gdbarch method.
2057
2058 2019-08-09  Tom de Vries  <tdevries@suse.de>
2059
2060         PR gdb/24591
2061         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
2062         pc_low with relocation offset.
2063
2064 2019-08-07  Tom Tromey  <tromey@adacore.com>
2065
2066         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2067         (print_frame_args): Update.
2068         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
2069         Update.
2070         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2071         * frame.h (struct frame_arg): Add initializers.
2072         <error>: Now a unique_xmalloc_ptr.
2073
2074 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
2075
2076         * NEWS: Expand the Pointer Authentication entry.
2077         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
2078         (aarch64_frame_unmask_lr): ... to this.
2079         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
2080         Call aarch64_frame_unmask_lr.
2081         * frame.c (struct frame_info): Add "masked" variable.
2082         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
2083         (fprint_frame): Check for masked pc.
2084         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
2085         declarations.
2086         * python/py-framefilter.c (py_print_frame): Check for masked pc.
2087         * stack.c (print_frame): Check for masked pc.
2088
2089 2019-08-06  Tom Tromey  <tom@tromey.com>
2090
2091         * stabsread.c (patch_block_stabs, read_one_struct_field)
2092         (read_enum_type): Use obstack_strndup.
2093         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
2094         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
2095         * dwarf2read.c (guess_full_die_structure_name)
2096         (anonymous_struct_prefix): Use obstack_strndup.
2097         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
2098         * c-exp.y (yylex): Use obstack_strndup.
2099         * ada-exp.y (write_object_renaming, write_ambiguous_var)
2100         (write_var_or_type): Use obstack_strndup.
2101
2102 2019-08-06  Tom Tromey  <tom@tromey.com>
2103
2104         * symfile.c (reread_symbols): Use obstack_strdup.
2105         * stabsread.c (read_type): Use obstack_strdup.
2106         * gdb_obstack.h (obstack_strdup): New overload.
2107         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
2108         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
2109         (dwarf2_canonicalize_name): Use obstack_strdup.
2110         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
2111         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
2112         Use obstack_strdup.
2113
2114 2019-08-06  Tom Tromey  <tom@tromey.com>
2115
2116         * gdb_obstack.h (obstack_strdup): Define.
2117         * gdb_obstack.c (obstack_strdup): Don't define.
2118
2119 2019-08-06  Tom Tromey  <tom@tromey.com>
2120
2121         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
2122         obstack_strdup.
2123         * typeprint.c (typedef_hash_table::find_global_typedef): Use
2124         obstack_strdup.
2125         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
2126         * stabsread.c (common_block_start): Use obstack_strdup.
2127         * objfiles.c (set_objfile_main_name, objfile): Use
2128         obstack_strdup.
2129         * namespace.c (add_using_directive): Use obstack_strdup.
2130         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
2131         * jit.c (finalize_symtab): Use obstack_strdup.
2132         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
2133         (guess_partial_die_structure_name, partial_die_info::fixup)
2134         (dwarf2_name): Use obstack_strdup.
2135         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
2136         obstack_strdup.
2137         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
2138         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2139         obstack_strdup.
2140         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
2141
2142 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2143
2144         * unittests/help-doc-selftests.c: New file.
2145         * Makefile.in: Add the new file.
2146
2147 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2148
2149         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
2150         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
2151         the full first line, except when FOR_VALUE_PREFIX.  In this case,
2152         the trailing '.' is not output, and the first character is uppercased.
2153         (print_help_for_command): Update call to print_doc_line.
2154         (print_doc_of_command): Likewise.
2155         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
2156         * cli/cli-option.c (append_indented_doc): Do not append newline.
2157         (build_help_option): Append newline after first appended_indented_doc
2158         only if a second call is done.
2159         (build_help): Append 2 new lines before each option, except the first
2160         one.
2161         * compile/compile.c (_initialize_compile): Add new lines after
2162         %OPTIONS%, when not at the end of the help.
2163         Change help doc or code
2164         producing the help doc to respect the invariants.
2165         * maint-test-options.c (_initialize_maint_test_options): Likewise.
2166         Also removed the new line after 'Options:', as all other commands
2167         do not put an empty line between 'Options:' and the first option.
2168         * printcmd.c (_initialize_printcmd): Likewise.
2169         * stack.c (_initialize_stack): Likewise.
2170         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
2171         incorrectly telling COMMAND is optional.
2172         * ada-lang.c (_initialize_ada_language): Change help doc or code
2173         producing the help doc to respect the invariants.
2174         * ada-tasks.c (_initialize_ada_tasks): Likewise.
2175         * breakpoint.c (_initialize_breakpoint): Likewise.
2176         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
2177         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
2178         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
2179         * cli/cli-style.c (cli_style_option::add_setshow_commands,
2180         _initialize_cli_style): Likewise.
2181         * corelow.c (core_target_info): Likewise.
2182         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
2183         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
2184         * filesystem.c (_initialize_filesystem): Likewise.
2185         * frame.c (_initialize_frame): Likewise.
2186         * gnu-nat.c (add_task_commands): Likewise.
2187         * infcall.c (_initialize_infcall): Likewise.
2188         * infcmd.c (_initialize_infcmd): Likewise.
2189         * interps.c (_initialize_interpreter): Likewise.
2190         * language.c (_initialize_language): Likewise.
2191         * linux-fork.c (_initialize_linux_fork): Likewise.
2192         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
2193         * maint.c (_initialize_maint_cmds): Likewise.
2194         * memattr.c (_initialize_mem): Likewise.
2195         * printcmd.c (_initialize_printcmd): Likewise.
2196         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
2197         _RegEx): Likewise.
2198         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
2199         * record-btrace.c (_initialize_record_btrace): Likewise.
2200         * record-full.c (_initialize_record_full): Likewise.
2201         * record.c (_initialize_record): Likewise.
2202         * regcache-dump.c (_initialize_regcache_dump): Likewise.
2203         * regcache.c (_initialize_regcache): Likewise.
2204         * remote.c (add_packet_config_cmd, init_remote_threadtests,
2205         _initialize_remote): Likewise.
2206         * ser-tcp.c (_initialize_ser_tcp): Likewise.
2207         * serial.c (_initialize_serial): Likewise.
2208         * skip.c (_initialize_step_skip): Likewise.
2209         * source.c (_initialize_source): Likewise.
2210         * stack.c (_initialize_stack): Likewise.
2211         * symfile.c (_initialize_symfile): Likewise.
2212         * symtab.c (_initialize_symtab): Likewise.
2213         * target-descriptions.c (_initialize_target_descriptions): Likewise.
2214         * top.c (init_main): Likewise.
2215         * tracefile-tfile.c (tfile_target_info): Likewise.
2216         * tracepoint.c (_initialize_tracepoint): Likewise.
2217         * tui/tui-win.c (_initialize_tui_win): Likewise.
2218         * utils.c (add_internal_problem_command): Likewise.
2219         * valprint.c (value_print_option_defs): Likewise.
2220
2221 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
2222
2223         PR build/24886
2224         * configure.ac: Drop enable-libmcheck support.
2225         * configure, config.in: Rebuild.
2226         * libmcheck.m4: Remove.
2227         * acinclude.m4: Don't include it.
2228         * Makefile.in: Don't distribute it.
2229         * top.c (print_gdb_configuration): Don't mention it.
2230
2231 2019-08-06  Tom Tromey  <tom@tromey.com>
2232
2233         * utils.c (set_output_style): Sometimes pass stream to
2234         emit_style_escape.
2235         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
2236         * record-btrace.c (btrace_insn_history): Update.
2237         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
2238         method.
2239         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
2240         Update initializers.
2241         <m_uiout>: New field.
2242         <m_di>: Move lower.
2243         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2244         Remove "uiout" parameter.
2245         (dump_insns): Update.
2246         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
2247         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
2248
2249 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
2250
2251         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
2252         (error_in_psymtab_expansion): Likewise.
2253         (lookup_symbol_via_quick_fns): Likewise.
2254         (basic_lookup_transparent_type_quick): Likewise.
2255         (basic_lookup_transparent_type_1): Likewise.
2256
2257 2019-08-06  Tom Tromey  <tromey@adacore.com>
2258
2259         * source.c (last_source_error): Now bool.
2260         (print_source_lines_base): Make "noprint" bool.  Only open
2261         source file when last_source_visited changes.
2262
2263 2019-08-06  Tom Tromey  <tromey@adacore.com>
2264
2265         * annotate.c (annotate_source_line): Use g_source_cache.
2266         * source-cache.c (source_cache::get_plain_source_lines): Change
2267         parameters.  Populate m_offset_cache.
2268         (source_cache::ensure): New method.
2269         (source_cache::get_line_charpos): New method.
2270         (extract_lines): Move lower.  Change parameters.
2271         (source_cache::get_source_lines): Move lower.
2272         * source-cache.h (class source_cache): Update comment.
2273         <get_line_charpos>: New method.
2274         <get_source_lines>: Update comment.
2275         <clear>: Clear m_offset_cache.
2276         <get_plain_source_lines>: Change parameters.
2277         <ensure>: New method
2278         <m_offset_cache>: New member.
2279         * source.c (forget_cached_source_info_for_objfile): Update.
2280         (info_source_command): Use g_source_cache.
2281         (find_source_lines, open_source_file_with_line_charpos): Remove.
2282         (print_source_lines_base, search_command_helper): Use g_source_cache.
2283         * source.h (open_source_file_with_line_charpos): Don't declare.
2284         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
2285         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
2286         Use g_source_cache.
2287
2288 2019-08-06  Tom Tromey  <tromey@adacore.com>
2289
2290         * source-cache.c (source_cache::get_plain_source_lines):
2291         Remove "first_line" and "last_line" parameters.
2292         (source_cache::get_source_lines): Cache plain text.
2293         * source-cache.h (class source_cache)
2294         <get_plain_source_lines>: Update.
2295
2296 2019-08-06  Tom Tromey  <tromey@adacore.com>
2297
2298         * source-cache.c (extract_lines): No longer a method.
2299         Changed type of parameter.  Include final newline.
2300         (selftests::extract_lines_test): New function.
2301         (_initialize_source_cache): Likewise.
2302         * source-cache.h (class source_cache)
2303         <extract_lines>: Don't declare.
2304
2305 2019-08-06  Tom Tromey  <tromey@adacore.com>
2306
2307         * breakpoint.c (init_breakpoint_sal): Update.
2308         (breakpoint): Update.
2309         * breakpoint.h (struct breakpoint) <filter>: Now a
2310         unique_xmalloc_ptr.
2311
2312 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2313
2314         * NEWS: Mention dictionary access on blocks.
2315         * python/py-block.c (blpy_getitem): New function.
2316         (block_object_as_mapping): New struct.
2317         (block_object_type): Use new struct for tp_as_mapping field.
2318
2319 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2320
2321         * objfiles.h (objfile): Add a comment describing partial symbols.
2322
2323 2019-08-05  Tom Tromey  <tromey@adacore.com>
2324
2325         * compile/compile.c (_initialize_compile): Use _(), not N_().
2326         * thread.c (_initialize_thread): Use _(), not N_().
2327         * stack.c (_initialize_stack): Use _(), not N_().
2328         * printcmd.c (_initialize_printcmd): Use _(), not N_().
2329
2330 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
2331
2332         * dwarf2read.c (struct dw2_symtab_iterator):
2333         <want_specific_block>: Remove.
2334         <block_index>: Change type to gdb::optional.
2335         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
2336         change type of BLOCK_INDEX parameter to gdb::optional.
2337         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
2338         (dw2_lookup_symbol): Don't pass argument for
2339         WANT_SPECIFIC_BLOCK.
2340         (dw2_expand_symtabs_for_function): Don't pass argument for
2341         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
2342         (class dw2_debug_names_iterator)
2343         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
2344         parameter, change BLOCK_INDEX type to gdb::optional.
2345         <m_want_specific_block>: Remove.
2346         <m_block_index>: Change type to gdb::optional.
2347         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
2348         gdb::optional.  Re-write in function of gdb::optional.
2349         (dw2_debug_names_lookup_symbol): Don't pass argument for
2350         WANT_SPECIFIC_BLOCK.
2351         (dw2_debug_names_expand_symtabs_for_function): Don't pass
2352         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
2353         BLOCK_INDEX.
2354
2355 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2356
2357         * NEWS: Mention changes to "info sources" command.
2358
2359 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2360
2361         * symtab.c (filename_partial_match_opts): New struct type.
2362         (struct output_source_filename_data): New members
2363         regexp, c_regexp, partial_match.
2364         (output_source_filename): Use new members to decide to print file.
2365         (info_sources_option_defs): New variable.
2366         (make_info_sources_options_def_group, print_info_sources_header,
2367         info_sources_command_completer):
2368         New functions.
2369         (info_sources_command): Read new optional arguments.
2370         (_initialize_symtab): Update info sources help.
2371
2372 2019-08-02  Alexandre Oliva <oliva@adacore.com>
2373
2374         * ada-lang.c (exception_support_info_v0): Renamed from...
2375         (default_exception_support_info): ... this.  Create new
2376         definition for v1.
2377         (ada_has_this_exception_support): Look up catch_handlers_sym.
2378         (ada_exception_support_info_sniffer): Try v0 after default.
2379
2380 2019-08-01  Tom Tromey  <tromey@adacore.com>
2381
2382         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
2383         gdbarch.h.
2384
2385 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
2386
2387         * s12z-tdep.c: Fix include path for s12z-opc.h.
2388
2389 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
2390
2391         * NEWS: Require GNU make 3.82.
2392
2393 2019-07-16  Tom Tromey  <tom@tromey.com>
2394
2395         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
2396         declare.
2397
2398 2019-07-30  Tom Tromey  <tromey@adacore.com>
2399
2400         * block.c (contained_in): Remove BLOCK_FUNCTION check.
2401
2402 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
2403
2404         * printcmd.c (print_address_symbolic): Print negative offsets.
2405         (build_address_symbolic): Force signed arithmetic when computing
2406         offset.
2407
2408 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
2409
2410         PR/24474: Add a function to lookup static variables.
2411         * NEWS: Mention this new function.
2412         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
2413         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
2414         * python/python.c (python_GdbMethods): Add new function.
2415
2416 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
2417
2418         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
2419         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
2420         (objfpy_lookup_static_symbol): New function.
2421         (objfile_object_methods): Add new functions.
2422
2423 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2424
2425         * NEWS: Mention 'set|show print frame-info'.  Mention new
2426         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
2427         backtrace argument.  Mention that python frame filtering code
2428         is now consistent with what 'backtrace' command prints.
2429
2430 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2431
2432         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
2433         comments.
2434         (print_frame_info_auto, print_frame_info_source_line,
2435         print_frame_info_location, print_frame_info_source_and_location,
2436         print_frame_info_location_and_address, print_frame_info_short_location):
2437         New declarations.
2438         (struct frame_print_options): New member print_frame_info.
2439         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
2440         * stack.h (get_user_print_what_frame_info): New declaration.
2441         (frame_show_address): New declaration.
2442         * stack.c (print_frame_arguments_choices): New value 'presence'.
2443         (print_frame_info_auto, print_frame_info_source_line,
2444         print_frame_info_location, print_frame_info_source_and_location,
2445         print_frame_info_location_and_address, print_frame_info_short_location,
2446         print_frame_info_choices, print_frame_info_print_what): New definitions.
2447         (print_frame_args): Only print dots for args if print frame-arguments
2448         is 'presence'.
2449         (frame_print_option_defs): New element for "frame-info".
2450         (get_user_print_what_frame_info): New function.
2451         (frame_show_address): Make non static.  Move comment to stack.h.
2452         (print_frame_info_to_print_what): New function.
2453         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
2454         to decide what to print.
2455         (backtrace_command_1): Handle the new print_frame_arguments_presence
2456         value.
2457         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
2458         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
2459         (py_print_frame): In non-mi mode, use LOCATION as default for
2460         print_what, similarly to frame information printed directly by
2461         backtrace command. Handle frame-info user option in non MI mode.
2462
2463 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2464
2465         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
2466         Add case for debugging 32-bit target on 64-bit host.  Revise
2467         comment.
2468
2469 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2470
2471         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
2472         instead of find_function_entry_range_from_pc.
2473
2474 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2475
2476         * stack.c (find_frame_funname): Remove code which preferred
2477         minsym over symtab sym in "certain pathological cases".
2478
2479         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
2480         parameter.  Change type of "do_demangle" to bool.
2481         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2482         Pass suitable "prefer_sym_over_minsym" flag to
2483         build_address_symbolic().  Don't output "+" for negative offsets.
2484         * printcmd.c (print_address_symbolic): Update invocation of
2485         build_address_symbolic to include a "prefer_sym_over_minsym"
2486         flag.
2487         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
2488         Restrict cases in which use of minimal symbol is preferred to that
2489         of a found symbol.  Update comments.
2490
2491         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
2492         for entry pc when entry pc is out of range for that FDE.
2493
2494 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
2495
2496         PR gdb/24839:
2497         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
2498         type.
2499
2500 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
2501
2502         * python/py-objfile.c (add_separate_debug_file): Fix comment about
2503         this function's Python signature.
2504
2505
2506 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
2507
2508         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
2509         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2510         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2511         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
2512         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
2513
2514
2515 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
2516
2517         * h8300-tdep.c (h8300_register_name_common): New.
2518         h8300_register_name): Use h8300_register_name_common.
2519         (h8300s_register_name): Likewise.
2520         (h8300sx_register_name): Likewise.
2521         (h8300h_register_nam): New.
2522         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
2523
2524
2525 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
2526
2527         * arm-tdep.c (arm_skip_cmse_entry): New function.
2528         (arm_is_sgstubs_section): New function.
2529         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
2530
2531 2019-07-22  Tom Tromey  <tom@tromey.com>
2532
2533         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
2534         Don't self-assign.
2535
2536 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2537
2538         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
2539         type_print.
2540
2541 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2542
2543         * symtab.c (search_symbols): Adjust msymbol matching type arrays
2544         so that GDB doesn't match any msymbols when searching in the
2545         TYPES_DOMAIN.
2546         (print_symbol_info): Print using typedef_print or type_print based
2547         on the type of the symbol.  Add updated FIXME comment moved from...
2548         (_initialize_symtab): ... move and update FIXME comment to above.
2549
2550 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2551
2552         * NEWS: Mention adding -q option to "info types".
2553         * symtab.c (struct info_types_options): New struct.
2554         (info_types_options_defs): New variable.
2555         (make_info_types_options_def_group): New function.
2556         (info_types_command): Use gdb::option framework to parse options.
2557         (info_types_command_completer): New function.
2558         (_initialize_symtab): Extend the help text on "info types" and
2559         register command completer.
2560
2561 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
2562
2563         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
2564         (lookup_symbol_in_objfile): Change int to block_enum and add a
2565         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
2566
2567 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
2568
2569         * MAINTAINERS (Write After Approval): Add self.
2570
2571 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2572
2573         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
2574         instruction to the dummy code region.
2575
2576 2019-07-19  Tom Tromey  <tromey@adacore.com>
2577
2578         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
2579         (ARGSUSED, PARAMS, __func__): Remove rules.
2580
2581 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2582
2583         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
2584         * features/arm/arm-with-iwmmxt.c: Remove.
2585         * features/arm/arm-with-iwmmxt.xml: Remove.
2586         * features/arm/arm-with-m-fpa-layout.c: Remove.
2587         * features/arm/arm-with-m-fpa-layout.xml: Remove.
2588         * features/arm/arm-with-m-vfp-d16.c: Remove.
2589         * features/arm/arm-with-m-vfp-d16.xml: Remove.
2590         * features/arm/arm-with-m.c: Remove.
2591         * features/arm/arm-with-m.xml: Remove.
2592         * features/arm/arm-with-neon.c: Remove.
2593         * features/arm/arm-with-neon.xml: Remove.
2594         * features/arm/arm-with-vfpv2.c: Remove.
2595         * features/arm/arm-with-vfpv2.xml: Remove.
2596         * features/arm/arm-with-vfpv3.c: Remove.
2597         * features/arm/arm-with-vfpv3.xml: Remove.
2598
2599 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2600
2601         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
2602
2603 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2604
2605         * arch/aarch32.c (aarch32_create_target_description): Create
2606         target descriptions using features.
2607         * arch/arm.c (arm_create_target_description)
2608         (arm_create_mprofile_target_description): Likewise.
2609         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
2610
2611 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2612
2613         * Makefile.in: Add new files.
2614         * aarch32-tdep.c: New file.
2615         * aarch32-tdep.h: New file.
2616         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2617         Call aarch32_read_description.
2618         * arch/aarch32.c: New file.
2619         * arch/aarch32.h: New file.
2620         * arch/arm.c (arm_create_target_description)
2621         (arm_create_mprofile_target_description): New function.
2622         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
2623         (arm_create_target_description)
2624         (arm_create_mprofile_target_description): New declaration.
2625         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
2626         read_description functions.
2627         * arm-linux-nat.c (arm_linux_nat_target::read_description):
2628         Likewise.
2629         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2630         * arm-tdep.c (tdesc_arm_list): New variable.
2631         (arm_register_g_packet_guesses): Call create description functions.
2632         (arm_read_description) (arm_read_mprofile_description): New
2633         function.
2634         * arm-tdep.h (arm_read_description)
2635         (arm_read_mprofile_description): Add declaration.
2636         * configure.tgt: Add new files.
2637
2638 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
2639
2640         * top.c (new_ui_command): Open specified terminal just once.
2641
2642 2019-07-18  Tom Tromey  <tromey@adacore.com>
2643
2644         * symtab.c (main_name): Constify return type.
2645         * symfile.c (set_initial_language): Update.
2646         * symtab.h (main_name): Constify return type.
2647
2648 2019-07-17  Tom Tromey  <tom@tromey.com>
2649
2650         * tui/tui-winsource.c (tui_update_source_window)
2651         (tui_update_source_window_as_is)
2652         (tui_update_source_windows_with_line): Remove return.
2653         * tui/tui-disasm.c (tui_show_disassem)
2654         (tui_show_disassem_and_update_source): Remove return.
2655         * tui/tui.c (tui_reset): Remove return.
2656         * tui/tui-wingeneral.c
2657         (tui_check_and_display_highlight_if_needed): Remove return.
2658
2659 2019-07-17  Tom Tromey  <tom@tromey.com>
2660
2661         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
2662
2663 2019-07-17  Tom Tromey  <tom@tromey.com>
2664
2665         * tui/tui-winsource.h (struct tui_exec_info_window)
2666         (struct tui_source_window_base): Move from tui-data.h.
2667         * tui/tui-winsource.c: Move many method definitions from
2668         elsewhere.  Remove "structuring" comments.
2669         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
2670         (tui_source_window_base::refresh_window): Move to
2671         tui-winsource.c.
2672         * tui/tui-win.c (tui_source_window_base::refresh_all)
2673         (tui_source_window_base::update_tab_width)
2674         (tui_source_window_base::set_new_height)
2675         (tui_source_window_base::do_make_visible_with_new_height): Move to
2676         tui-winsource.c.
2677         * tui/tui-source.h: Update.
2678         * tui/tui-source.c (tui_source_window_base::reset): Move to
2679         tui-winsource.c.
2680         * tui/tui-disasm.h: Update.
2681         * tui/tui-data.h (struct tui_exec_info_window): Move to
2682         tui-winsource.h.
2683         (struct tui_source_window_base): Likewise.
2684         * tui/tui-data.c (tui_source_window_base::clear_detail)
2685         (tui_source_window_base, ~tui_source_window_base): Move to
2686         tui-winsource.c.
2687
2688 2019-07-17  Tom Tromey  <tom@tromey.com>
2689
2690         * tui/tui-win.c (tui_resize_all)
2691         (tui_source_window_base::update_tab_width)
2692         (tui_adjust_win_heights): Update.
2693         (tui_win_info::make_invisible_and_set_new_height): Rename from
2694         make_invisible_and_set_new_height.
2695         * tui/tui-data.h (struct tui_win_info)
2696         <make_invisible_and_set_new_height>: New method.
2697
2698 2019-07-17  Tom Tromey  <tom@tromey.com>
2699
2700         * tui/tui.c: Update.
2701         * tui/tui-source.h (struct tui_source_window): Move from
2702         tui-data.h.
2703         * tui/tui-layout.c: Update.
2704         * tui/tui-disasm.c: Update.
2705         * tui/tui-data.h (struct tui_source_window): Move to
2706         tui-source.h.
2707
2708 2019-07-17  Tom Tromey  <tom@tromey.com>
2709
2710         * tui/tui-disasm.h (struct tui_disasm_window): Move from
2711         tui-data.h.
2712         * tui/tui-data.h (struct tui_disasm_window): Move to
2713         tui-disasm.h.
2714
2715 2019-07-17  Tom Tromey  <tom@tromey.com>
2716
2717         * tui/tui-regs.h (struct tui_data_item_window): Move from
2718         tui-data.h.
2719         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
2720         * tui/tui-data.h (struct tui_data_item_window): Move to
2721         tui-regs.h.
2722         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
2723
2724 2019-07-17  Tom Tromey  <tom@tromey.com>
2725
2726         * tui/tui.c: Update.
2727         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
2728         (tui_cmd_window::max_height): Move to tui-command.c.
2729         * tui/tui-layout.c: Update.
2730         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
2731         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
2732         tui-command.c.
2733         * tui/tui-command.h (struct tui_cmd_window): Move from
2734         tui-data.h.
2735         * tui/tui-command.c: Remove "structuring" comments.
2736         (tui_cmd_window::clear_detail)
2737         (tui_cmd_window::do_make_visible_with_new_height)
2738         (tui_cmd_window::max_height): Move from elsewhere.
2739
2740 2019-07-17  Tom Tromey  <tom@tromey.com>
2741
2742         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
2743         Now static.
2744         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
2745         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
2746
2747 2019-07-17  Tom Tromey  <tom@tromey.com>
2748
2749         * tui/tui.c: Update.
2750         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
2751         tui-regs.c.
2752         * tui/tui-windata.h: Remove file.
2753         * tui/tui-windata.c: Remove file.
2754         * tui/tui-win.c (tui_data_window::set_new_height)
2755         (tui_data_window::do_make_visible_with_new_height): Move to
2756         tui-regs.c.
2757         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
2758         * tui/tui-regs.c: Remove "structuring" comments.
2759         (tui_data_window::first_data_item_displayed)
2760         (tui_data_window::delete_data_content_windows)
2761         (tui_data_window::erase_data_content)
2762         (tui_data_window::display_all_data)
2763         (tui_data_window::refresh_all)
2764         (tui_data_window::do_scroll_vertical)
2765         (tui_data_window::clear_detail, tui_data_window::set_new_height)
2766         (tui_data_window::do_make_visible_with_new_height)
2767         (tui_data_window::refresh_window): Move from elsewhere.
2768         (_initialize_tui_regs): Move to end of file.
2769         * tui/tui-layout.c: Update.
2770         * tui/tui-hooks.c: Update.
2771         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
2772         * tui/tui-data.c (tui_data_window::clear_detail): Move to
2773         tui-regs.c.
2774         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
2775
2776 2019-07-17  Tom Tromey  <tom@tromey.com>
2777
2778         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
2779         seen.
2780
2781 2019-07-17  Tom Tromey  <tom@tromey.com>
2782
2783         * tui/tui-win.c (tui_source_window_base::set_new_height)
2784         (tui_source_window_base::do_make_visible_with_new_height): Use
2785         m_has_locator field directly.
2786         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
2787         method.
2788         (struct tui_source_window_base) <has_locator>: Likewise.
2789
2790 2019-07-17  Tom Tromey  <tom@tromey.com>
2791
2792         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
2793         Don't declare.
2794         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
2795         Remove.
2796         * tui/tui-win.c (tui_source_window_base::set_new_height)
2797         (tui_source_window_base::set_new_height)
2798         (make_invisible_and_set_new_height)
2799         (tui_source_window_base::do_make_visible_with_new_height)
2800         (tui_source_window_base::do_make_visible_with_new_height):
2801         Update.
2802         * tui/tui-layout.c (show_source_disasm_command, show_data)
2803         (show_source_or_disasm_and_command): Update.
2804         * tui/tui-layout.c (show_layout): Update.
2805
2806 2019-07-17  Tom Tromey  <tom@tromey.com>
2807
2808         * tui/tui-layout.c (make_data_window): Remove.
2809         (show_data): Unify creation and re-initialization cases.
2810
2811 2019-07-17  Tom Tromey  <tom@tromey.com>
2812
2813         * tui/tui-layout.c (make_source_window, make_disasm_window):
2814         Remove.
2815         (show_data): Unify creation and re-initialization cases.
2816
2817 2019-07-17  Tom Tromey  <tom@tromey.com>
2818
2819         * tui/tui-layout.c (make_command_window): Remove.
2820         (show_source_disasm_command, show_source_or_disasm_and_command):
2821         Unify creation and re-initialization cases.
2822
2823 2019-07-17  Tom Tromey  <tom@tromey.com>
2824
2825         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
2826         creation and re-initialization cases.
2827
2828 2019-07-17  Tom Tromey  <tom@tromey.com>
2829
2830         * tui/tui-regs.c (tui_get_register): Return void.
2831
2832 2019-07-17  Tom Tromey  <tom@tromey.com>
2833
2834         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
2835         Simplify.
2836
2837 2019-07-17  Tom Tromey  <tom@tromey.com>
2838
2839         * tui/tui-layout.c (show_source_disasm_command): Simplify window
2840         resetting.
2841
2842 2019-07-17  Tom Tromey  <tom@tromey.com>
2843
2844         * tui/tui.h (tui_set_layout_by_name): Don't declare.
2845         * tui/tui-regs.c (tui_reg_layout): New function.
2846         (tui_show_registers, tui_reg_command): Use it.
2847         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
2848         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
2849         parameters.
2850         (tui_layout_command): Remove.
2851
2852 2019-07-17  Tom Tromey  <tom@tromey.com>
2853
2854         * tui/tui-layout.h (tui/tui-layout): Return void.
2855         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
2856
2857 2019-07-17  Tom Tromey  <tom@tromey.com>
2858
2859         * tui/tui-layout.c (show_source_disasm_command, show_data):
2860         Update.
2861         (reset_locator): Remove.
2862         (show_source_or_disasm_and_command): Update.
2863
2864 2019-07-17  Tom Tromey  <tom@tromey.com>
2865
2866         * tui/tui-source.c (tui_source_window_base::reset): Remove
2867         win_type parameter.
2868         * tui/tui-layout.c (make_command_window, make_source_window)
2869         (make_disasm_window, make_data_window)
2870         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
2871         (reset_locator, show_source_or_disasm_and_command): Update.
2872         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
2873         win_type parameter.
2874         (struct tui_source_window_base) <reset>: Likewise.
2875
2876 2019-07-17  Tom Tromey  <tom@tromey.com>
2877
2878         * tui/tui-layout.c (show_source_disasm_command): Use
2879         reset_locator.
2880         (reset_locator): New function.
2881         (init_and_make_win): Remove.
2882         (show_source_or_disasm_and_command): Use reset_locator.
2883
2884 2019-07-17  Tom Tromey  <tom@tromey.com>
2885
2886         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
2887         condition.
2888         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
2889         Remove condition.
2890         * tui/tui-source.c (tui_source_window_base::reset): New method.
2891         * tui/tui-layout.c (make_command_window): Don't call
2892         init_and_make_win.
2893         (make_source_window, make_disasm_window): Don't call
2894         make_source_or_disasm_window.
2895         (make_data_window): Don't call init_and_make_win.  Change calling
2896         convention.
2897         (show_source_disasm_command, show_data): Simplify.
2898         (make_source_or_disasm_window): Remove.
2899         (show_source_or_disasm_and_command): Simplify.
2900         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
2901         (struct tui_source_window_base) <reset>: Likewise.
2902         <execution_info>: Remove initializer.
2903         * tui/tui-data.c (tui_source_window_base): Initialize
2904         execution_info.
2905
2906 2019-07-17  Tom Tromey  <tom@tromey.com>
2907
2908         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
2909         variable.
2910
2911 2019-07-17  Tom Tromey  <tom@tromey.com>
2912
2913         * tui/tui.c (tui_rl_other_window): Update.
2914         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
2915         superclass method first.  Always iterate over regs_content.
2916         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
2917         method.
2918         * tui/tui-win.c (tui_set_focus_command): Update.
2919
2920 2019-07-17  Tom Tromey  <tom@tromey.com>
2921
2922         * tui/tui-win.c (tui_set_focus_command): Rename from
2923         tui_set_focus.  Call tui_enable.
2924         (tui_set_focus_command): Remove.
2925
2926 2019-07-17  Tom Tromey  <tom@tromey.com>
2927
2928         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
2929         refresh_window.
2930         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
2931         touchwin.
2932         (tui_data_window::refresh_window): Call refresh_window on data
2933         items.  Always call superclass refresh_window.
2934         (tui_win_info::refresh): Remove.
2935         (tui_source_window_base::refresh_window): Update.
2936         (tui_refresh_all): Update.
2937         * tui/tui-layout.c (show_source_disasm_command): Remove call to
2938         refresh_window.
2939         (show_source_or_disasm_and_command): Likewise.
2940         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
2941         (struct tui_source_window_base) <refresh>: Likewise.
2942
2943 2019-07-17  Tom Tromey  <tom@tromey.com>
2944
2945         * tui/tui-winsource.c (tui_clear_source_content)
2946         (tui_show_source_content): Update.
2947         * tui/tui-source.c (tui_source_window::showing_source_p): Check
2948         whether content is empty.
2949         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
2950         Remove.
2951
2952 2019-07-17  Tom Tromey  <tom@tromey.com>
2953
2954         * tui/tui-winsource.c (tui_erase_source_content): Clear the
2955         window's contents.
2956         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
2957         * tui/tui-source.c (tui_set_source_content_nil): Remove.
2958
2959 2019-07-17  Tom Tromey  <tom@tromey.com>
2960
2961         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
2962         (struct tui_data_item_window): Update.
2963
2964 2019-07-17  Tom Tromey  <tom@tromey.com>
2965
2966         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
2967         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
2968         defines.
2969
2970 2019-07-17  Tom Tromey  <tom@tromey.com>
2971
2972         * tui/tui-winsource.h (tui_erase_source_content)
2973         (tui_clear_source_content): Remove "display_prompt" parameter.
2974         * tui/tui-winsource.c (tui_update_source_window_as_is)
2975         (tui_update_source_windows_with_addr): Update.
2976         (tui_clear_source_content): Remove "display_prompt" parameter.
2977         (tui_erase_source_content): Likewise.  Simplify.
2978         (tui_show_source_content): Update.
2979         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2980         * tui/tui-stack.c (tui_show_frame_info): Update.
2981         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
2982         Remove defines.
2983
2984 2019-07-17  Tom Tromey  <tom@tromey.com>
2985
2986         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2987         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
2988         parameter.
2989         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
2990         parameter.
2991
2992 2019-07-17  Tom Tromey  <tom@tromey.com>
2993
2994         * tui/tui-winsource.c (tui_clear_source_content)
2995         (tui_show_source_content, tui_show_exec_info_content)
2996         (tui_clear_exec_info_content): Update.
2997         * tui/tui-stack.c (tui_show_locator_content): Update.
2998         (tui_show_frame_info): Update.
2999         * tui/tui-source.h (tui_source_window): Don't declare.
3000         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
3001         from tui_source_is_displayed.
3002         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
3003         Remove field.
3004         (struct tui_source_window_base) <content_in_use>: New field.  Now
3005         bool.
3006         (struct tui_source_window) <showing_source_p>: New method.
3007         (TUI_SRC_WIN): Change cast.
3008         * tui/tui-data.c (tui_initialize_static_data): Update.
3009
3010 2019-07-17  Tom Tromey  <tom@tromey.com>
3011
3012         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
3013         location_matches_p.
3014         * tui/tui-source.c (tui_source_window::location_matches_p): New
3015         method.
3016         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
3017         method.
3018         * tui/tui-data.h (struct tui_source_window_base)
3019         <location_matches_p>: New method.
3020         (struct tui_source_window, struct tui_disasm_window)
3021         <location_matches_p>: Likewise.
3022
3023 2019-07-17  Tom Tromey  <tom@tromey.com>
3024
3025         * tui/tui-win.c (tui_set_win_height_command): Rename from
3026         tui_set_win_height.
3027         (tui_set_win_height_command): Remove.
3028
3029 2019-07-17  Tom Tromey  <tom@tromey.com>
3030
3031         * tui/tui-source.c (tui_source_window): New constructor.  Add
3032         observer.
3033         (~tui_source_window): New destructor.
3034         (tui_source_window::style_changed): New method.
3035         * tui/tui-hooks.c (tui_redisplay_source): Remove.
3036         (tui_attach_detach_observers): Update.
3037         * tui/tui-data.h (struct tui_source_window): Make constructor not
3038         inline.  Add destructor.
3039         (struct tui_source_window) <style_changed>: New method.
3040         <m_observable>: New member.
3041
3042 2019-07-17  Tom Tromey  <tom@tromey.com>
3043
3044         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
3045         * tui/tui-win.c (tui_resize_all): Fix typo.
3046
3047 2019-07-17  Tom Tromey  <tom@tromey.com>
3048
3049         * tui/tui-wingeneral.h (tui_refresh_all): Update.
3050         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
3051         (tui_refresh_all): Remove "list" parameter.  Use foreach.
3052         * tui/tui-win.c (window_name_completer): Use foreach.
3053         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
3054         (update_tab_width): Likewise.
3055         * tui/tui-layout.c (show_layout): Update.
3056         * tui/tui-data.h (class tui_window_iterator): New.
3057         (struct all_tui_windows): New.
3058         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
3059
3060 2019-07-17  Tom Tromey  <tom@tromey.com>
3061
3062         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
3063         parameter.  Don't reference globals.
3064         (tui_reg_command): Update.
3065
3066 2019-07-17  Tom Tromey  <tom@tromey.com>
3067
3068         * tui/tui-regs.c (tui_show_registers): Simplify.
3069
3070 2019-07-17  Tom Tromey  <tom@tromey.com>
3071
3072         * tui/tui-regs.c (tui_show_registers): Update.
3073         (tui_show_register_group): Add win_info parameter.
3074
3075 2019-07-17  Tom Tromey  <tom@tromey.com>
3076
3077         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
3078         Rename from tui_display_reg_element_at_line.
3079         (tui_data_window::display_registers_from_line): Update.
3080         * tui/tui-data.h (struct tui_data_window)
3081         <display_reg_element_at_line>: New method.
3082
3083 2019-07-17  Tom Tromey  <tom@tromey.com>
3084
3085         * tui/tui-regs.h (tui_display_registers_from)
3086         (tui_display_registers_from_line): Don't declare.
3087         * tui/tui-windata.c (tui_data_window::display_all_data)
3088         (tui_data_window::refresh_all)
3089         (tui_data_window::do_scroll_vertical): Update.
3090         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
3091         from tui_display_registers_from.
3092         (tui_display_reg_element_at_line): Update.
3093         (tui_data_window::display_registers_from_line): Rename from
3094         tui_display_registers_from_line.
3095         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
3096         display_registers_from_line>: New methods.
3097
3098 2019-07-17  Tom Tromey  <tom@tromey.com>
3099
3100         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
3101         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
3102         from tui_erase_data_content.
3103         (tui_data_window::display_all_data)
3104         (tui_data_window::refresh_all)
3105         (tui_data_window::do_scroll_vertical): Update.
3106         * tui/tui-regs.c (tui_show_registers): Update.
3107         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
3108         New method.
3109
3110 2019-07-17  Tom Tromey  <tom@tromey.com>
3111
3112         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
3113         declare.
3114         * tui/tui-windata.c
3115         (tui_data_window::delete_data_content_windows): Rename from
3116         tui_delete_data_content_windows.
3117         (tui_data_window::display_all_data)
3118         (tui_data_window::do_scroll_vertical): Update.
3119         * tui/tui-data.h (struct tui_data_window)
3120         <delete_data_content_windows>: New method.
3121
3122 2019-07-17  Tom Tromey  <tom@tromey.com>
3123
3124         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
3125         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
3126
3127 2019-07-17  Tom Tromey  <tom@tromey.com>
3128
3129         * tui/tui-windata.h (tui_display_all_data): Don't declare.
3130         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
3131         from tui_display_all_data.
3132         * tui/tui-win.c
3133         (tui_data_window::do_make_visible_with_new_height): Update.
3134         * tui/tui-regs.c (tui_show_registers): Update.
3135         * tui/tui-layout.c (tui_set_layout): Update.
3136         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
3137         method.
3138
3139 2019-07-17  Tom Tromey  <tom@tromey.com>
3140
3141         * tui/tui-windata.h (tui_display_data_from): Don't declare.
3142         * tui/tui-windata.c (tui_display_data_from): Remove.
3143         (tui_data_window::refresh_all): Update.
3144
3145 2019-07-17  Tom Tromey  <tom@tromey.com>
3146
3147         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
3148         * tui/tui-windata.c (tui_display_data_from_line): Remove.
3149         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
3150         tui_display_registers_from_line.
3151         * tui/tui-regs.h (tui_display_registers_from_line): Update.
3152         * tui/tui-regs.c (tui_display_registers_from_line): Remove
3153         "force_display" parameter.
3154
3155 2019-07-17  Tom Tromey  <tom@tromey.com>
3156
3157         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
3158         declare.
3159         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
3160         Rename from tui_first_reg_element_no_inline.
3161         (tui_display_reg_element_at_line)
3162         (tui_display_registers_from_line): Update.
3163         * tui/tui-data.h (struct tui_data_window)
3164         <first_reg_element_no_inline>: New method.
3165
3166 2019-07-17  Tom Tromey  <tom@tromey.com>
3167
3168         * tui/tui-windata.c (tui_display_data_from)
3169         (tui_data_window::do_scroll_vertical): Update.
3170         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
3171         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
3172         Rename from tui_line_from_reg_element_no.
3173         (tui_display_registers_from_line): Update.
3174         * tui/tui-data.h (struct tui_data_window)
3175         <line_from_reg_element_no>: New method.
3176
3177 2019-07-17  Tom Tromey  <tom@tromey.com>
3178
3179         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
3180         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
3181         tui_last_regs_line_no.
3182         (tui_display_reg_element_at_line)
3183         (tui_display_registers_from_line): Update.
3184         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
3185         method.
3186
3187 2019-07-17  Tom Tromey  <tom@tromey.com>
3188
3189         PR tui/24722:
3190         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
3191         (tui_update_breakpoint_info): Add "being_deleted" parameter.
3192         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3193         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
3194         (tui_update_breakpoint_info): Likewise.
3195         * tui/tui-hooks.c (tui_event_create_breakpoint)
3196         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
3197         Update.
3198
3199 2019-07-17  Tom Tromey  <tom@tromey.com>
3200
3201         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
3202
3203 2019-07-17  Tom Tromey  <tom@tromey.com>
3204
3205         * tui/tui-winsource.c (tui_update_source_window_as_is)
3206         (tui_update_source_windows_with_addr): Update.
3207         * tui/tui-source.h (tui_set_source_content)
3208         (tui_show_symtab_source): Add "win_info" parameter.
3209         * tui/tui-source.c (tui_set_source_content): Add "win_info"
3210         parameter.
3211         (tui_show_symtab_source): Likewise.
3212
3213 2019-07-17  Tom Tromey  <tom@tromey.com>
3214
3215         * tui/tui-wingeneral.c
3216         (tui_check_and_display_highlight_if_needed): Check can_highlight.
3217
3218 2019-07-17  Tom Tromey  <tom@tromey.com>
3219
3220         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
3221         (struct tui_cmd_window) <can_scroll>: New method.
3222         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
3223         method.
3224
3225 2019-07-17  Tom Tromey  <tromey@adacore.com>
3226
3227         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
3228         do_field_signed>: Rename.  Change type of "value".
3229         * ui-out.c (ui_out::field_signed): Rename from field_int.
3230         Change type of "value".
3231         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
3232         type of "value".
3233         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
3234         do_field_int.  Change type of "value".
3235         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
3236         do_field_int.  Change type of "value".
3237         * tracepoint.c (trace_status_mi, tfind_1)
3238         (print_one_static_tracepoint_marker): Update.
3239         * thread.c (print_thread_info_1, print_selected_thread_frame):
3240         Update.
3241         * stack.c (print_frame, print_frame_info): Update.
3242         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
3243         Update.
3244         * source.c (print_source_lines_base): Update.
3245         * skip.c (info_skip_command): Update.
3246         * record-btrace.c (btrace_ui_out_decode_error)
3247         (btrace_call_history_src_line): Update.
3248         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
3249         Update.
3250         * progspace.c (print_program_space): Update.
3251         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
3252         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
3253         do_field_int.  Change type of "value".
3254         * mi/mi-out.c (mi_ui_out::do_table_begin)
3255         (mi_ui_out::do_table_header): Update.
3256         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
3257         type of "value".
3258         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
3259         (mi_cmd_data_list_changed_registers, output_register)
3260         (mi_cmd_data_read_memory, mi_load_progress)
3261         (mi_cmd_trace_frame_collected): Update.
3262         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
3263         Update.
3264         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
3265         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
3266         (mi_cmd_var_list_children, varobj_update_one): Update.
3267         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
3268         (mi_cmd_stack_list_args, list_arg_or_local): Update.
3269         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
3270         * inferior.c (print_inferior): Update.
3271         * gdb_bfd.c (print_one_bfd): Update.
3272         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3273         Update.
3274         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
3275         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
3276         do_field_int.  Change type of "value".
3277         * cli-out.c (cli_ui_out::do_field_signed): Rename from
3278         do_field_int.  Change type of "value".
3279         * breakpoint.c (watchpoint_check, print_breakpoint_location)
3280         (print_one_breakpoint_location, print_it_catch_fork)
3281         (print_one_catch_fork, print_it_catch_vfork)
3282         (print_one_catch_vfork, print_it_catch_solib)
3283         (print_it_catch_exec, print_it_ranged_breakpoint)
3284         (print_mention_watchpoint, print_mention_masked_watchpoint)
3285         (bkpt_print_it, update_static_tracepoint): Update.
3286         * break-catch-throw.c (print_it_exception_catchpoint): Update.
3287         * break-catch-syscall.c (print_it_catch_syscall): Update.
3288         * ada-tasks.c (print_ada_task_info): Update.
3289         * ada-lang.c (print_it_exception, print_mention_exception):
3290         Update.
3291
3292 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
3293
3294         PR breakpoints/24541
3295         * gdbarch.c: Regenerate.
3296         * gdbarch.h: Regenerate.
3297         * gdbarch.sh: Adjust return type and parameter types for
3298         'stap_adjust_register'.
3299         (i386_stap_adjust_register): Adjust signature and return new
3300         register name.
3301         * stap-probe.c (stap_parse_register_operand): Adjust use of
3302         'gdbarch_stap_adjust_register'.
3303
3304 2019-07-17  Tom Tromey  <tromey@adacore.com>
3305
3306         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
3307         declare VEC.
3308         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
3309         std::vector.
3310         (struct s390_process_info): Add initializers.
3311         (s390_add_process): Use new.
3312         (s390_linux_nat_target::low_forget_process): Use delete.
3313         (s390_linux_nat_target::low_new_fork)
3314         (s390_linux_nat_target::stopped_by_watchpoint)
3315         (s390_linux_nat_target::low_prepare_to_resume)
3316         (s390_linux_nat_target::insert_watchpoint)
3317         (s390_linux_nat_target::insert_hw_breakpoint)
3318         (s390_linux_nat_target::remove_watchpoint)
3319         (s390_linux_nat_target::remove_hw_breakpoint): Update.
3320
3321 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3322
3323         * aarch64-fbsd-nat.c: Include regcache.h.
3324         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
3325         argument.
3326         (aarch64_fbsd_nat_target::fetch_registers)
3327         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
3328         variable.
3329         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
3330
3331 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3332
3333         * fbsd-nat.c: Include gdbarch.h.
3334
3335 2019-07-15  Tom Tromey  <tromey@adacore.com>
3336
3337         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
3338
3339 2019-07-15  Tom Tromey  <tromey@adacore.com>
3340
3341         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
3342         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
3343         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
3344         * cli-out.c (cli_ui_out::do_field_int): New method.
3345         * ui-out.c (ui_out::field_unsigned): New method.
3346         * symfile.c (generic_load): Use field_unsigned.
3347         (print_transfer_performance): Likewise.
3348         * record-btrace.c (ui_out_field_uint): Remove.
3349         (btrace_call_history_insn_range, btrace_call_history): Use
3350         field_unsigned.
3351         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
3352         field_unsigned.
3353         * ui-out.h (class ui_out) <field_unsigned>: New method.
3354         <do_field_unsigned>: Likewise.
3355
3356 2019-07-15  Tom Tromey  <tromey@adacore.com>
3357
3358         * mi/mi-main.c (list_available_thread_groups): Use field_string.
3359         * mi/mi-interp.c (mi_memory_changed): Use field_string.
3360         * target.c (flash_erase_command): Use field_string.
3361         * infrun.c (print_signal_received_reason): Use field_string.
3362         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
3363         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
3364         field_string.
3365         * ada-tasks.c (print_ada_task_info): Use field_string.
3366
3367 2019-07-15  Tom Tromey  <tromey@adacore.com>
3368
3369         * target.c (flash_erase_command): Use field_core_addr.
3370         * symfile.c (generic_load): Use field_core_addr.
3371         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
3372         Use field_core_addr.
3373         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
3374         field_core_addr.
3375
3376 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3377
3378         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
3379         value if its desired type is smaller than a CORE_ADDR and signed.
3380
3381 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3382
3383         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
3384         of changes to field names, and use new is_reference field to
3385         decide if a property is a reference or not.
3386         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
3387         field.
3388         (struct dwarf2_property_baton): Update header comment, rename
3389         'referenced_type' to 'property_type' and update comments.
3390         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
3391         default property type, store in property baton, update to take
3392         accound of renamed field.
3393         (read_func_scope): Update call to attr_to_dynamic_prop.
3394         (read_array_type): Likewise.
3395         (dwarf2_per_cu_addr_sized_int_type): New function.
3396         (read_subrange_index_type): Move type finding code to
3397         dwarf2_per_cu_addr_sized_int_type.
3398         (read_subrange_type): Update calls to attr_to_dynamic_prop.
3399         (dwarf2_per_cu_addr_type): New function.
3400         (set_die_type): Update calls to attr_to_dynamic_prop.
3401
3402 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3403
3404         * dwarf2read.c (read_subrange_index_type): New function.
3405         (read_subrange_type): Move code into new function and call it.
3406         * gdbtypes.c (create_range_type): Add some asserts.
3407
3408 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3409
3410         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
3411         update return statements.
3412         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
3413         declaration, and update comment to match.
3414         * gdbtypes.c (resolve_dynamic_array): Update call to
3415         dwarf2_evaluate_property to match new return type.
3416
3417 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3418
3419         * valarith.c (value_subscripted_rvalue): Change lowerbound
3420         parameter type from int to LONGEST.
3421         * value.h (value_subscripted_rvalue): Likewise in declaration.
3422
3423 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3424
3425         * cli/cli-utils.c (info_print_command_completer): New function.
3426         * cli/cli-utils.h: Add 'completer.h' include, and forward
3427         declaration for 'struct cmd_list_element'.
3428         (info_print_command_completer): Declare.
3429         * stack.c (_initialize_stack): Add completer for 'info locals' and
3430         'info args'.
3431         * symtab.c (_initialize_symtab): Add completer for 'info
3432         variables' and 'info functions'.
3433         * NEWS: Mention completion for additional info commands.
3434
3435 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3436
3437         * cli/cli-utils.c (extract_info_print_args): Delete.
3438         (extract_arg_maybe_quoted): Delete.
3439         (info_print_options_defs): New variable.
3440         (make_info_print_options_def_group): New function.
3441         (extract_info_print_options): Define new function.
3442         * cli/cli-utils.h (extract_info_print_args): Delete.
3443         (struct info_print_options): New structure.
3444         (extract_info_print_options): Declare new function.
3445         * stack.c (info_locals_command): Update to use new
3446         extract_info_print_options, also add a header comment.
3447         (info_args_command): Likewise.
3448         * symtab.c (info_variables_command): Likewise.
3449         (info_functions_command): Likewise.
3450
3451 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3452
3453         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
3454         to extract string arguments.
3455         * common/common-utils.c (extract_string_maybe_quoted): New function.
3456         * common/common-utils.h (extract_string_maybe_quoted): Declare.
3457
3458 2019-07-11  Tom Tromey  <tromey@adacore.com>
3459
3460         * main.c (get_init_files): Use GDBINIT, not gdbinit.
3461         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
3462         * top.h (gdbinit): Don't declare.
3463         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
3464         into...
3465         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
3466         * top.c (gdb_init): Don't call init_cli_cmds.
3467         (gdbinit): Remove.
3468         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
3469
3470 2019-07-11  Tom Tromey  <tromey@adacore.com>
3471
3472         * python/py-inferior.c (add_thread_object): Don't use thread_obj
3473         after it has been moved.
3474
3475 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3476
3477         * valops.c (value_must_coerce_to_target): Change return type to
3478         bool.
3479         * value.h (value_must_coerce_to_target): Likewise.
3480
3481 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
3482
3483         * breakpoint.c (is_hardware_watchpoint): Remove
3484         forward-declaration.
3485         (is_masked_watchpoint): Change return type to bool.
3486         (is_tracepoint): Likewise.
3487         (is_breakpoint): Likewise.
3488         (is_hardware_watchpoint): Likewise.
3489         (is_watchpoint): Likewise.
3490         (is_no_memory_software_watchpoint): Likewise.
3491         (is_catchpoint): Likewise.
3492         (breakpoint_1): Make FILTER parameter's return type bool.
3493         is_masked_watchpoint): Change return type to bool.
3494         (save_breakpoints): Make FILTER parameter's return type bool.
3495         * breakpoint.h (is_breakpoint): Change return type to bool.
3496         (is_watchpoint): Likewise.
3497         (is_catchpoint): Likewise.
3498         (is_tracepoint): Likewise.
3499
3500 2019-07-10  Tom Tromey  <tom@tromey.com>
3501
3502         * defs.h: Don't include gdbarch.h.
3503         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
3504         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
3505         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
3506         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
3507         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
3508         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
3509         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
3510         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
3511         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
3512         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
3513         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
3514         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
3515         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
3516         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
3517         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
3518         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
3519         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
3520         record-btrace.c, record.h, regcache-dump.c, regcache.h,
3521         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
3522         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
3523         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
3524         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
3525         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
3526         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
3527         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
3528         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
3529         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
3530
3531 2019-07-10  Tom Tromey  <tromey@adacore.com>
3532
3533         * ada-lang.h (is_ada_exception_catchpoint): Declare.
3534         * breakpoint.c (init_ada_exception_breakpoint): Register as
3535         bp_catchpoint.
3536         (print_one_breakpoint_location, print_one_breakpoint): Use
3537         is_ada_exception_catchpoint.
3538         * ada-lang.c (class ada_catchpoint_location): Pass
3539         bp_loc_software_breakpoint to bp_location constructor.
3540         (is_ada_exception_catchpoint): New function.
3541
3542 2019-07-10  Tom Tromey  <tromey@adacore.com>
3543
3544         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
3545         VEC.
3546         (struct arm_exidx_entry): New method operator<.
3547         (struct arm_exidx_data) <section_maps>: Change type.
3548         (arm_exidx_data_free): Remove.
3549         (arm_exidx_data_key): Change type.  Move lower.
3550         (arm_exidx_new_objfile): Update.
3551         (arm_compare_exidx_entries): Remove.
3552         (arm_find_exidx_entry, _initialize_arm_tdep)
3553
3554 2019-07-10  Tom Tromey  <tromey@adacore.com>
3555
3556         * solib-spu.c (ocl_program_data_key): Change type.
3557         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
3558         Update.
3559
3560 2019-07-10  Tom Tromey  <tromey@adacore.com>
3561
3562         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
3563         (struct solib_aix_inferior_data) <library_list>: Change type.
3564         (solib_aix_inferior_data_handle): Change type.
3565         (get_solib_aix_inferior_data): Update.
3566         (solib_aix_free_library_list): Remove.
3567         (library_list_start_library): Update.
3568         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
3569         return type.
3570         (solib_aix_get_library_list)
3571         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
3572         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
3573
3574 2019-07-10  Tom Tromey  <tromey@adacore.com>
3575
3576         * solib-dsbt.c (struct dsbt_info): Add initializers.
3577         (solib_dsbt_pspace_data): Change type.
3578         (dsbt_pspace_data_cleanup): Remove.
3579         (get_dsbt_info, _initialize_dsbt_solib): Update.
3580
3581 2019-07-10  Tom Tromey  <tromey@adacore.com>
3582
3583         * spu-tdep.c (spu_overlay_data): Change type.
3584         (spu_get_overlay_table, spu_overlay_new_objfile)
3585         (_initialize_spu_tdep): Update.
3586
3587 2019-07-10  Tom Tromey  <tromey@adacore.com>
3588
3589         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
3590         destructor.
3591         (dbx_objfile_data_key): Change type and declare later.
3592         (DBX_SYMFILE_INFO): Rewrite.
3593         * dbxread.c (dbx_objfile_data_key): Change type.
3594         (dbx_symfile_init): Update.
3595         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
3596         (coffstab_build_psymtabs, elfstab_build_psymtabs)
3597         (stabsect_build_psymtabs, _initialize_dbxread): Update.
3598
3599 2019-07-10  Tom Tromey  <tromey@adacore.com>
3600
3601         * jit.c (jit_program_space_key): Change type.  Move lower.
3602         (get_jit_program_space_data): Update.
3603         (jit_program_space_data_cleanup): Remove.
3604         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
3605         Update.
3606         (struct jit_program_space_data): Add initializers.
3607
3608 2019-07-10  Tom Tromey  <tromey@adacore.com>
3609
3610         * solib-darwin.c (struct darwin_info): Add initializers.
3611         (solib_darwin_pspace_data): Change type.
3612         (darwin_pspace_data_cleanup): Remove.
3613         (get_darwin_info, _initialize_darwin_solib): Update.
3614
3615 2019-07-10  Tom Tromey  <tromey@adacore.com>
3616
3617         * remote-sim.c (struct sim_inferior_data): Add initializers,
3618         constructor, and destructor.
3619         (sim_inferior_data_key): Change type.  Move lower.
3620         (check_for_duplicate_sim_descriptor): Update.
3621         (get_sim_inferior_data): Use new.  Update.
3622         (~sim_inferior_data_cleanup): Rename from
3623         sim_inferior_data_cleanup.  Simplify.
3624         (gdbsim_close_inferior, simulator_command)
3625         (sim_command_completer, _initialize_remote_sim): Update.
3626         (next_pid, INITIAL_PID): Move earlier.
3627
3628 2019-07-10  Tom Tromey  <tromey@adacore.com>
3629
3630         * python/python-internal.h (create_thread_object): Return
3631         gdbpy_ref.
3632         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
3633         * python/py-inferior.c (struct threadlist_entry): Add
3634         constructor.
3635         <thread_obj>: Now a gdbpy_ref.
3636         (thread_to_thread_object): Update.
3637         (add_thread_object): Use new.
3638         (delete_thread_object): Use delete.
3639         (infpy_threads): Update.
3640         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
3641         GIL.
3642
3643 2019-07-10  Tom Tromey  <tromey@adacore.com>
3644
3645         * valops.c (value_cast): Specialize error message for Ada.
3646
3647 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3648
3649         * breakpoint.c (breakpoint_1): Update doc and parameter names.
3650
3651 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3652
3653         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
3654         bpstat_should_step): Return bool, adjust comments.
3655         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
3656         bpstat_should_step): Likewise.
3657
3658 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3659
3660         * features/Makefile: Use feature target descriptions for Arm.
3661         * features/arm/arm-core.c: Generate new file.
3662         * features/arm/arm-fpa.c: Likewise.
3663         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
3664         * features/arm/arm-m-profile.c: Likewise.
3665         * features/arm/arm-vfpv2.c: Likewise.
3666         * features/arm/arm-vfpv3.c: Likewise.
3667         * features/arm/xscale-iwmmxt.c: Likewise.
3668         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
3669
3670 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3671
3672         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
3673         ptrace earlier.
3674
3675 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3676
3677         * features/aarch64-pauth.c: Regenerate.
3678
3679 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
3680
3681         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
3682         bool.
3683         (bpstat_what): Use false instead of 0.
3684
3685 2019-07-09  Pedro Alves  <palves@redhat.com>
3686
3687         * break-catch-throw.c (is_exception_catchpoint): New.
3688         * breakpoint.c (print_one_breakpoint_location): New parameter
3689         'raw_loc'.  Handle it.  Use
3690         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
3691         looking at the breakpoint's type.
3692         (print_one_breakpoint): If handling "maint info breakpoints", also
3693         print locations of exception catchpoints.
3694         * breakpoint.h (is_exception_catchpoint): Declare.
3695
3696 2019-07-09  Pedro Alves  <palves@redhat.com>
3697
3698         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
3699         "addr" field.
3700         (allocate_location_exception_catchpoint): New.
3701         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
3702         (initialize_throw_catchpoint_ops): Install
3703         allocate_location_exception_catchpoint as allocate_location
3704         method.
3705         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
3706         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
3707         bp_loc_other.
3708         (breakpoint_address_is_meaningful): Delete.
3709         (bl_address_is_meaningful): New.
3710         (breakpoint_locations_match): Adjust comment.
3711         (bp_location_from_bp_type): New, factored out of...
3712         (bp_location::bp_location(breakpoint *)): ... this.
3713         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
3714         factored out of...
3715         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
3716         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
3717         breakpoint_address_is_meaningful.
3718         (bp_locations_compare): Adjust comment.
3719         (update_global_location_list): Use bl_address_is_meaningful
3720         instead of breakpoint_address_is_meaningful.
3721         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
3722         explicit.
3723         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
3724         * python/py-breakpoint.c (bppy_get_location): No longer check
3725         whether location is null.
3726
3727 2019-07-09  Pedro Alves  <palves@redhat.com>
3728
3729         PR c++/15468
3730         * breakpoint.c (print_one_breakpoint_location): Remove
3731         single-location assert.
3732
3733 2019-07-09  Tom Tromey  <tom@tromey.com>
3734
3735         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
3736         * configure: Rebuild.
3737         * configure.ac: Change common to gdbsupport.
3738         * gdbsupport: Rename from common.
3739         * acinclude.m4: Change common to gdbsupport.
3740         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
3741         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
3742         gdbsupport.
3743         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
3744         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
3745         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
3746         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
3747         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
3748         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
3749         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
3750         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
3751         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
3752         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
3753         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
3754         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
3755         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
3756         coff-pe-read.c, command.h, compile/compile-c-support.c,
3757         compile/compile-c.h, compile/compile-cplus-symbols.c,
3758         compile/compile-cplus-types.c, compile/compile-cplus.h,
3759         compile/compile-loc2c.c, compile/compile.c, completer.c,
3760         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
3761         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
3762         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
3763         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
3764         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
3765         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
3766         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
3767         features/aarch64-core.c, features/aarch64-fpu.c,
3768         features/aarch64-pauth.c, features/aarch64-sve.c,
3769         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
3770         features/i386/32bit-core.c, features/i386/32bit-linux.c,
3771         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
3772         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
3773         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
3774         features/i386/64bit-core.c, features/i386/64bit-linux.c,
3775         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
3776         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
3777         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
3778         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
3779         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
3780         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
3781         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
3782         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
3783         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
3784         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
3785         go32-nat.c, guile/guile.c, guile/scm-ports.c,
3786         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
3787         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
3788         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
3789         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
3790         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
3791         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
3792         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
3793         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
3794         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
3795         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
3796         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
3797         minsyms.c, mips-linux-tdep.c, namespace.h,
3798         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
3799         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
3800         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
3801         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
3802         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
3803         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
3804         nat/linux-waitpid.c, nat/mips-linux-watch.c,
3805         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
3806         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
3807         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
3808         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
3809         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
3810         procfs.c, producer.c, progspace.h, psymtab.h,
3811         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
3812         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
3813         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
3814         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
3815         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
3816         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
3817         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
3818         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
3819         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
3820         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
3821         target-memory.c, target.c, target.h, target/waitstatus.c,
3822         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
3823         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
3824         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
3825         unittests/array-view-selftests.c,
3826         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
3827         unittests/common-utils-selftests.c,
3828         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
3829         unittests/format_pieces-selftests.c,
3830         unittests/function-view-selftests.c,
3831         unittests/lookup_name_info-selftests.c,
3832         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
3833         unittests/mkdir-recursive-selftests.c,
3834         unittests/observable-selftests.c,
3835         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
3836         unittests/parse-connection-spec-selftests.c,
3837         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
3838         unittests/scoped_fd-selftests.c,
3839         unittests/scoped_mmap-selftests.c,
3840         unittests/scoped_restore-selftests.c,
3841         unittests/string_view-selftests.c, unittests/style-selftests.c,
3842         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
3843         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
3844         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
3845         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
3846         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
3847         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
3848
3849 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3850
3851         * linespec.c (decode_digits_list_mode): Set explicit_line to a
3852         bool value.
3853         (decode_digits_ordinary): Set explicit_line field in sal.
3854         * symtab.c (skip_prologue_sal): Don't skip prologue for a
3855         symtab_and_line that was set on an explicit line number in
3856         assembler code.  Do always update the recorded symtab and line if
3857         we do skip the prologue.
3858
3859 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3860
3861         * breakpoint.c (set_breakpoint_location_function): Remove
3862         explicit_loc parameter.
3863         (momentary_breakpoint_from_master): Update call to
3864         set_breakpoint_location_function.
3865         (add_location_to_breakpoint): Likewise.
3866
3867 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3868
3869         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
3870         required features based on default bfd type when no specific bfd
3871         is present.
3872
3873 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3874
3875         * NEWS: Mention that GDB printf and eval commands can now print
3876         C-style and Ada-style convenience var strings without
3877         calling the inferior.
3878         * printcmd.c (printf_c_string): Locally print GDB internal var
3879         instead of transiting via the inferior.
3880         (printf_wide_c_string): Likewise.
3881
3882 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3883
3884         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
3885
3886 2019-07-04  Tom Tromey  <tom@tromey.com>
3887
3888         PR tui/24724:
3889         * tui/tui-winsource.c (tui_clear_source_content): Update.
3890         (tui_source_window_base::set_is_exec_point_at): Fix comment.
3891         (tui_update_breakpoint_info): Update.
3892         (tui_set_exec_info_content): Update.
3893         * tui/tui-source.c (tui_set_source_content_nil): Update.
3894         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
3895         has_break.
3896         * tui/tui-data.h (enum tui_bp_flag): New.
3897         (tui_bp_flags): New enum flags type.
3898         (struct tui_source_element) <break_mode>: Change type.  Rename
3899         from has_break.
3900         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
3901         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
3902         constants.
3903         * tui/tui-winsource.h: Fix comment.
3904
3905 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3906
3907         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
3908         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
3909         (store_fpregs_to_thread)
3910         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3911         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
3912         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
3913         (IWMMXT_REGS_SIZE): Add define.
3914         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
3915         (fetch_vfp_regs, store_vfp_regs)
3916         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3917         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
3918
3919 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3920
3921         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
3922         defines.
3923         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
3924         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
3925         (ARM_INT_REGISTER_SIZE): ...to this.
3926         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
3927         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
3928         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
3929         (arm_linux_collect_gregset, supply_nwfpe_register)
3930         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
3931         defines.
3932         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
3933         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
3934         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
3935         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
3936         (arm_return_in_memory, arm_store_return_value)
3937         (arm_get_longjmp_target, arm_register_g_packet_guesses)
3938         (arm_record_ld_st_multiple): Likewise.
3939         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
3940         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
3941
3942 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3943
3944         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
3945         AARCH64_DISPLACED_MODIFIED_INSNS.
3946         * aarch64-tdep.c (struct aarch64_displaced_step_data)
3947         (aarch64_displaced_step_copy_insn): Likewise.
3948         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3949         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
3950         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
3951         ARM_DISPLACED_MODIFIED_INSNS.
3952         * arm-tdep.c (arm_gdbarch_init): Likewise.
3953         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3954         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
3955         (struct arm_displaced_step_closure): Use
3956         ARM_DISPLACED_MODIFIED_INSNS.
3957
3958 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3959
3960         * features/Makefile: Remove unused xml files.
3961         * features/aarch64.xml: Remove.
3962         * features/i386/amd64-avx-avx512-linux.xml: Remove.
3963         * features/i386/amd64-avx-avx512.xml: Remove.
3964         * features/i386/amd64-avx-linux.xml: Remove.
3965         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
3966         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
3967         * features/i386/amd64-avx-mpx-linux.xml: Remove.
3968         * features/i386/amd64-avx-mpx.xml: Remove.
3969         * features/i386/amd64-avx.xml: Remove.
3970         * features/i386/amd64-linux.xml: Remove.
3971         * features/i386/amd64-mpx-linux.xml: Remove.
3972         * features/i386/amd64-mpx.xml: Remove.
3973         * features/i386/amd64.xml: Remove.
3974         * features/i386/i386-avx-avx512-linux.xml: Remove.
3975         * features/i386/i386-avx-avx512.xml: Remove.
3976         * features/i386/i386-avx-linux.xml: Remove.
3977         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
3978         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
3979         * features/i386/i386-avx-mpx-linux.xml: Remove.
3980         * features/i386/i386-avx-mpx.xml: Remove.
3981         * features/i386/i386-avx.xml: Remove.
3982         * features/i386/i386-linux.xml: Remove.
3983         * features/i386/i386-mmx-linux.xml: Remove.
3984         * features/i386/i386-mmx.xml: Remove.
3985         * features/i386/i386-mpx-linux.xml: Remove.
3986         * features/i386/i386-mpx.xml: Remove.
3987         * features/i386/i386.xml: Remove.
3988         * features/i386/x32-avx-avx512-linux.xml: Remove.
3989         * features/i386/x32-avx-linux.xml: Remove.
3990         * features/i386/x32-linux.xml: Remove.
3991
3992 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3993
3994         * regformats/aarch64.dat: Remove.
3995         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
3996         * regformats/i386/amd64-avx-linux.dat: Remove.
3997         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
3998         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
3999         * regformats/i386/amd64-linux.dat: Remove.
4000         * regformats/i386/amd64-mpx-linux.dat: Remove.
4001         * regformats/i386/amd64.dat: Remove.
4002         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
4003         * regformats/i386/i386-avx-linux.dat: Remove.
4004         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
4005         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
4006         * regformats/i386/i386-linux.dat: Remove.
4007         * regformats/i386/i386-mmx-linux.dat: Remove.
4008         * regformats/i386/i386-mpx-linux.dat: Remove.
4009         * regformats/i386/i386.dat: Remove.
4010         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
4011         * regformats/i386/x32-avx-linux.dat: Remove.
4012         * regformats/i386/x32-linux.dat: Remove.
4013
4014 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4015
4016         * aarch64-tdep.c: Remove xml self tests.
4017         * amd64-linux-tdep.c: Likewise.
4018         * amd64-tdep.c: Likewise.
4019         * i386-linux-tdep.c: Likewise.
4020         * i386-tdep.c: Likewise.
4021
4022 2019-07-03  Pedro Alves  <palves@redhat.com>
4023
4024         PR cli/24732
4025         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
4026         (pipe_cmd_option_defs): New.
4027         (make_pipe_cmd_options_def_group): New.
4028         (pipe_command): Use gdb::option::process_options.
4029         (pipe_command_completer): New function.
4030         (_initialize_cli_cmds): Install completer for "pipe" command.
4031
4032 2019-07-03  Pedro Alves  <palves@redhat.com>
4033
4034         * cli/cli-option.c (union option_value) <string>: New field.
4035         (struct option_def_and_value): Add ctor, move ctor, dtor and
4036         use DISABLE_COPY_AND_ASSIGN.
4037         (option_def_and_value::clear_value): New.
4038         (parse_option, save_option_value_in_ctx, get_val_type_str)
4039         (add_setshow_cmds_for_options): Handle var_string.
4040         * cli-option.h (union option_def::var_address) <string>: New
4041         field.
4042         (struct string_option_def): New.
4043         * maint-test-options.c (struct test_options_opts): Add default
4044         ctor and use DISABLE_COPY_AND_ASSIGN.
4045         <string_opt>: New field.
4046         (test_options_opts::~test_options_opts): New.
4047         (test_options_opts::dump): Also dump "-string".
4048         (test_options_option_defs): Install "string.
4049
4050 2019-07-03  Pedro Alves  <palves@redhat.com>
4051
4052         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
4053         option_value with a null enumeration.
4054         (complete_options): Save the option values in the context.
4055         (save_option_value_in_ctx): New, factored out from ...
4056         (process_options): ... here.
4057         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
4058         of the function.
4059         * maint-test-options.c (test_options_opts::dump): New, factored
4060         out from ...
4061         (maintenance_test_options_command_mode): ... here.
4062         (maintenance_test_options_command_completion_result): Delete.
4063         (maintenance_test_options_command_completion_text): Update
4064         comment.
4065         (maintenance_show_test_options_completion_result): Change
4066         prototype.  Just print
4067         maintenance_test_options_command_completion_text.
4068         (save_completion_result): New.
4069         (maintenance_test_options_completer_mode): Pass options context to
4070         complete_options, and then save a dump.
4071         (_initialize_maint_test_options): Use add_cmd to install "maint
4072         show test-options-completion-result".
4073
4074 2019-07-03  Pedro Alves  <palves@redhat.com>
4075
4076         * NEWS (New commands): Mention "with" and "maint with".
4077         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
4078         (with_command, with_command_completer): New.
4079         (pipe_command): Adjust to new repeat_previous
4080         interface.
4081         (_initialize_cli_cmds): Install the "with" command and its "w"
4082         alias.
4083         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
4084         declarations.
4085         * cli/cli-setshow.c (parse_cli_var_uinteger)
4086         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
4087         argument strings for all var_types.
4088         (get_setshow_command_value_string): New, factored out from ...
4089         (do_show_command): ... this.
4090         * cli/cli-setshow.h: Include <string>.
4091         (get_setshow_command_value_string): Declare.
4092         * command.h (repeat_previous): Now returns const char *.  Adjust
4093         comment.
4094         * maint.c: Include "cli/cli-cmds.h".
4095         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
4096         (_initialize_maint_cmds): Register the "maintenance with" command.
4097         * top.c (repeat_previous): Move bits from pipe_command here:
4098         Return the saved command line, if any; error out if there's no
4099         command to relaunch.
4100
4101 2019-07-03  Pedro Alves  <palves@redhat.com>
4102
4103         * NEWS (New commands): Mention "maint set/show test-settings"
4104         instead of "maint test-settings".
4105         * maint-test-settings.c (maintenance_test_settings_list): Delete.
4106         (maintenance_test_settings_set_list): Rename to ...
4107         (maintenance_set_test_settings_list): ... this.
4108         (maintenance_test_settings_show_list): Rename to  ...
4109         (maintenance_show_test_settings_list): ... this.
4110         (maintenance_test_settings_cmd): Delete.
4111         (maintenance_test_settings_set_cmd): ...
4112         (maintenance_set_test_settings_cmd): ... this.
4113         (maintenance_test_settings_show_cmd): ...
4114         (maintenance_show_test_settings_cmd): ... this.
4115         (maintenance_test_settings_show_value_cmd):
4116         (maintenance_show_test_settings_value_cmd): ... this.
4117         (_initialize_maint_test_settings): No longer install the "maint
4118         test-settings" prefix command.  Rename "maint test-settings set"
4119         to "maint set test-settings", and "maint test-settings show" to
4120         "maint show test-settings".  Adjust all subcommands.
4121
4122 2019-07-03  Pedro Alves  <palves@redhat.com>
4123
4124         * maint-test-settings.c: Fix file's intro comment.  Replace all
4125         references to "test-options" with references to "test-settings",
4126         in comments.
4127
4128 2019-07-03  Pedro Alves  <palves@redhat.com>
4129
4130         * maint-test-settings.c (maintenance_test_settings_xxx)
4131         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
4132         New.
4133         (maintenance_test_settings_enums): Use them.
4134         (maintenance_test_settings_enum): Default to
4135         maintenance_test_settings_xxx.
4136         (_initialize_maint_test_settings): Initialize
4137         MAINTENANCE_TEST_SETTINGS_FILENAME.
4138
4139 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4140
4141         * breakpoint.h (remove_breakpoints_inf): Change return type to
4142         void, move function documentation here.
4143         * breakpoint.c (remove_breakpoints_inf): Change return type to
4144         void, move function documentation to header.
4145
4146 2019-07-02  Pedro Alves  <palves@redhat.com>
4147
4148         * NEWS (Completion improvements): Mention "info threads".
4149         * thread.c (struct info_threads_opts, info_threads_option_defs)
4150         (make_info_threads_options_def_group): New.
4151         (info_threads_command): Use gdb::option::process_options.
4152         (info_threads_command_completer): New.
4153         (_initialize_thread): Use gdb::option::build_help to build the
4154         help text for "info threads".
4155
4156 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4157
4158         * defs.h (generic_load): Move from here...
4159         * symfile.h (generic_load): ... to here.  Rename name parameter
4160         to args.
4161         * symfile.c (generic_load): Add comment.
4162
4163 2019-07-01  Tom Tromey  <tromey@adacore.com>
4164
4165         * dwarf2read.c
4166         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
4167         declaration of without_params.  Fix formatting.
4168
4169 2019-07-01  Tom Tromey  <tromey@adacore.com>
4170
4171         * ada-exp.y (find_primitive_type): Update.
4172         * ada-lang.h (ada_lookup_symbol): Update.
4173         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
4174         parameter.
4175         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
4176
4177 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4178
4179         PR breakpoints/24541
4180         * gdbarch.c: Regenerate.
4181         * gdbarch.h: Regenerate.
4182         * gdbarch.sh: Add 'stap_adjust_register'.
4183         * i386-tdep.c: Include '<unordered_set>'.
4184         (i386_stap_adjust_register): New function.
4185         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
4186         * stap-probe.c (stap_parse_register_operand): Call
4187         'gdbarch_stap_adjust_register'.
4188
4189 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4190
4191         PR python/24742
4192         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
4193         * python/python.c (do_start_initialization): Use 'xmalloc'
4194         instead of 'PyMem_Malloc'.
4195
4196 2019-06-28  Tom Tromey  <tromey@adacore.com>
4197
4198         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
4199         for Ada.
4200
4201 2019-06-27  Tom Tromey  <tromey@adacore.com>
4202
4203         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
4204         objfile_key.
4205         (arm_find_mapping_symbol, arm_record_special_symbol)
4206         (_initialize_arm_tdep): Update.
4207         (arm_objfile_data_free): Remove.
4208
4209 2019-06-27  Tom Tromey  <tromey@adacore.com>
4210
4211         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
4212         to cp_print_static_field.
4213
4214 2019-06-26  Tom Tromey  <tromey@adacore.com>
4215
4216         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
4217         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
4218         declare.
4219
4220 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4221
4222         * features/aarch64-core.c (create_feature_aarch64_core):
4223         Regenerate.
4224         * features/aarch64-core.xml: Add cpsr flags.
4225
4226 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4227
4228         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
4229         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
4230
4231 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4232
4233         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
4234         field.
4235         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
4236         use.
4237         (arm_record_special_symbol): Don't insert new symbol in sorted
4238         position, push it at the end.
4239
4240 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4241
4242         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
4243         (arm_mapping_symbol_s): Remove.
4244         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
4245         (arm_mapping_symbol_vec): New typedef.
4246         (struct arm_per_objfile): Add constructor.
4247         <section_maps>: Change type to
4248         std::unique_ptr<arm_mapping_symbol_vec[]>.
4249         (arm_compare_mapping_symbols): Remove.
4250         (arm_find_mapping_symbol): Adjust to section_maps type change.
4251         (arm_objfile_data_free): Call delete on arm_per_objfile.
4252         (arm_record_special_symbol): Adjust to section_maps type change.
4253         Allocate arm_per_objfile with new.
4254
4255 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4256
4257         * cli/cli-cmds.c (alias_command): Compare the alias prefix
4258         with the command prefix.
4259
4260 2019-06-25  Tom Tromey  <tom@tromey.com>
4261
4262         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
4263         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
4264
4265 2019-06-25  Tom Tromey  <tom@tromey.com>
4266
4267         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
4268         type.
4269         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
4270         protected.
4271
4272 2019-06-25  Tom Tromey  <tom@tromey.com>
4273
4274         * tui/tui-winsource.c
4275         (tui_source_window_base::set_is_exec_point_at): Add check against
4276         LOA_ADDRESS.
4277
4278 2019-06-25  Tom Tromey  <tom@tromey.com>
4279
4280         * tui/tui-source.c (tui_set_source_content): Don't check before
4281         xfree.
4282         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
4283
4284 2019-06-25  Tom Tromey  <tom@tromey.com>
4285
4286         * tui/tui-winsource.h (tui_update_source_window_as_is)
4287         (tui_alloc_source_buffer, tui_line_is_displayed)
4288         (tui_addr_is_displayed): Change type of win_info.
4289         * tui/tui-winsource.c (tui_update_source_window_as_is)
4290         (tui_clear_source_content, tui_show_source_line)
4291         (tui_show_source_content, tui_source_window_base::refill)
4292         (tui_source_window_base::set_is_exec_point_at)
4293         (tui_source_window_base::set_is_exec_point_at)
4294         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
4295         (tui_alloc_source_buffer, tui_line_is_displayed)
4296         (tui_addr_is_displayed): Change type of win_info.  Update.
4297         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4298         (tui_source_window_base::do_make_visible_with_new_height):
4299         Update.
4300         * tui/tui-source.c (tui_set_source_content)
4301         (tui_set_source_content_nil)
4302         (tui_source_window::do_scroll_vertical): Update.
4303         * tui/tui-layout.c (show_layout): Update.
4304         * tui/tui-disasm.c (tui_set_disassem_content)
4305         (tui_disasm_window::do_scroll_vertical): Update.
4306         * tui/tui-data.h (tui_win_content): Remove.
4307         (struct tui_gen_win_info) <content, content_size>: Remove.
4308         (struct tui_source_element): Add initializers and destructor.
4309         (union tui_which_element, struct tui_win_element): Remove.
4310         (struct tui_source_window_base) <content>: New field.
4311         (struct tui_data_window): Remove destructor.
4312         (tui_alloc_content, tui_free_win_content)
4313         (tui_free_all_source_wins_content): Don't declare.
4314         * tui/tui-data.c (tui_initialize_static_data): Update.
4315         (init_content_element, tui_alloc_content): Remove.
4316         (~tui_gen_win_info): Update.
4317         (~tui_data_window, tui_free_all_source_wins_content)
4318         (tui_free_win_content, free_content, free_content_elements):
4319         Remove.
4320
4321 2019-06-25  Tom Tromey  <tom@tromey.com>
4322
4323         * tui/tui-winsource.h (tui_clear_source_content)
4324         (tui_erase_source_content, tui_show_source_content): Change type
4325         of win_info.
4326         * tui/tui-winsource.c (tui_clear_source_content)
4327         (tui_erase_source_content, tui_show_source_content): Change type
4328         of win_info.
4329         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4330         * tui/tui-source.h (tui_set_source_content_nil): Change type of
4331         win_info.
4332         * tui/tui-source.c (tui_set_source_content_nil): Change type of
4333         win_info.
4334         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
4335
4336 2019-06-25  Tom Tromey  <tom@tromey.com>
4337
4338         * tui/tui-winsource.c (tui_clear_source_content)
4339         (tui_source_window_base::set_is_exec_point_at): Update.
4340         * tui/tui-source.c (tui_set_source_content_nil): Update.
4341         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
4342         a bool.
4343         * tui/tui-data.c (init_content_element): Update.
4344
4345 2019-06-25  Tom Tromey  <tom@tromey.com>
4346
4347         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
4348         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
4349         * tui/tui-layout.c (init_and_make_win): Update.
4350         * tui/tui.h (enum tui_win_type): Update.
4351         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
4352         tui_win_is_auxillary.
4353         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
4354         tui_win_is_auxillary.
4355
4356 2019-06-25  Tom Tromey  <tom@tromey.com>
4357
4358         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
4359         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
4360         (tui_delete_data_content_windows, tui_display_all_data)
4361         (tui_data_window::do_scroll_vertical, tui_display_data_from):
4362         Update.
4363         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
4364         * tui/tui-regs.c (tui_last_regs_line_no)
4365         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4366         (tui_show_registers): Update.
4367         (tui_show_register_group): Return void.  Update.
4368         (tui_display_registers_from, tui_display_reg_element_at_line)
4369         (tui_display_registers_from_line, tui_check_register_values):
4370         Update.
4371         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
4372         member.
4373         (struct tui_data_window) <regs_content>: Now a std::vector.
4374         <regs_content_count>: Remove.
4375         (tui_add_content_elements, tui_free_data_content): Don't declare.
4376         * tui/tui-data.c (tui_data_window::clear_detail): Update.
4377         (init_content_element): Remove DATA_WIN case.  Add assert.
4378         (tui_add_content_elements): Remove.
4379         (tui_data_window): Update.
4380         (tui_free_data_content): Remove.
4381         (free_content_elements): Remove DATA_WIN case.
4382
4383 2019-06-25  Tom Tromey  <tom@tromey.com>
4384
4385         * tui/tui-data.c (tui_data_item_window): Update.
4386         * tui/tui-windata.h (tui_check_data_values): Don't declare.
4387         * tui/tui-windata.c (tui_display_all_data)
4388         (tui_display_data_from_line): Update.
4389         (tui_check_data_values): Remove.
4390         * tui/tui-regs.c (tui_show_register_group)
4391         (tui_display_reg_element_at_line): Update.
4392         * tui/tui-hooks.c (tui_register_changed)
4393         (tui_refresh_frame_and_register_information): Call
4394         tui_check_register_values.
4395         * tui/tui-data.h (struct tui_data_window) <data_content,
4396         data_content_count, data_type>: Remove.
4397         (enum tui_data_type): Remove.
4398
4399         * tui/tui-data.c (tui_data_window::clear_detail)
4400         (~tui_data_window): Update.
4401
4402 2019-06-25  Tom Tromey  <tom@tromey.com>
4403
4404         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
4405         declare.
4406         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
4407         Rename from tui_first_data_item_displayed.  Update.
4408         (tui_data_window::refresh_all)
4409         (tui_data_window::do_scroll_vertical): Update.
4410         * tui/tui-data.h (struct tui_data_window)
4411         <first_data_item_displayed>: Declare new method.
4412
4413 2019-06-25  Tom Tromey  <tom@tromey.com>
4414
4415         * tui/tui-data.h (tui_init_generic_part): Don't declare.
4416         * tui/tui-data.c (tui_init_generic_part): Remove, moving
4417         contents...
4418         (tui_initialize_static_data): ...here.
4419
4420 2019-06-25  Tom Tromey  <tom@tromey.com>
4421
4422         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4423         (tui_display_registers_from, tui_check_register_values): Update.
4424         (tui_display_register): Remove win_info parameter; update.
4425         (tui_get_register): Change type of parameters.
4426         * tui/tui-data.h (struct tui_data_element): Remove.
4427         (union tui_which_element) <data>: Remove.
4428         <data_window>: Change type.
4429         (struct tui_data_item_window): New.
4430         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
4431         case.  Add assert.
4432         (~tui_data_item_window): New destructor.
4433         (free_content_elements): Remove DATA_ITEM_WIN case.
4434
4435 2019-06-25  Tom Tromey  <tom@tromey.com>
4436
4437         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
4438         Remove.
4439
4440 2019-06-25  Tom Tromey  <tom@tromey.com>
4441
4442         * tui/tui-data.h (struct tui_command_element): Remove.
4443         (union tui_which_element) <command>: Remove.
4444         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
4445         assert.
4446         (free_content_elements): Remove CMD_WIN case.
4447
4448 2019-06-25  Tom Tromey  <tom@tromey.com>
4449
4450         * tui/tui-layout.c (tui_set_layout): Update.
4451         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
4452         * tui/tui-data.c (layout_def): Update.
4453
4454 2019-06-25  Tom Tromey  <tom@tromey.com>
4455
4456         * tui/tui-wingeneral.c (tui_refresh_all): Update.
4457         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4458         (tui_source_window_base::set_new_height): Update.
4459         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
4460         Update.
4461         (tui_set_locator_fullname, tui_set_locator_info)
4462         (tui_show_frame_info): Update.
4463         * tui/tui-source.c (tui_set_source_content)
4464         (tui_source_is_displayed): Update.
4465         * tui/tui-layout.c (show_source_disasm_command, show_data)
4466         (show_source_or_disasm_and_command): Update.
4467         * tui/tui-disasm.c (tui_set_disassem_content)
4468         (tui_get_begin_asm_address): Update.
4469         * tui/tui-data.h (struct tui_locator_element): Remove.
4470         (union tui_which_element) <locator>: Remove.
4471         (struct tui_locator_window): New.
4472         (tui_locator_win_info_ptr): Change return type.
4473         * tui/tui-data.c (_locator): Change type.
4474         (tui_locator_win_info_ptr): Change return type.
4475         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
4476         (tui_alloc_content): Add assert.
4477
4478 2019-06-25  Tom Tromey  <tom@tromey.com>
4479
4480         * tui/tui-winsource.c
4481         (tui_exec_info_window::maybe_allocate_content): New method.
4482         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
4483         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
4484         (make_source_or_disasm_window): Add cast.
4485         * tui/tui-data.h (union tui_which_element) <simple_string>:
4486         Remove.
4487         (struct tui_source_info): New.
4488         (struct tui_source_window_base) <execution_info>: Change type.
4489         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
4490         case, and add assert.
4491         (tui_alloc_content): Add assert.
4492
4493 2019-06-25  Tom Tromey  <tom@tromey.com>
4494
4495         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
4496         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
4497         * tui/tui-data.c (tui_alloc_win_info): Remove.
4498
4499 2019-06-25  Tom Tromey  <tom@tromey.com>
4500
4501         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
4502         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
4503         can_highlight.
4504
4505 2019-06-25  Tom Tromey  <tom@tromey.com>
4506
4507         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
4508         make_visible_with_new_height method.
4509         (tui_win_info::make_visible_with_new_height): New method.
4510         (tui_source_window_base::do_make_visible_with_new_height)
4511         (tui_data_window::do_make_visible_with_new_height)
4512         (tui_cmd_window::do_make_visible_with_new_height): New methods.
4513         (make_visible_with_new_height): Remove.
4514         (tui_resize_all, tui_adjust_win_heights): Use
4515         make_visible_with_new_height method.
4516         * tui/tui-data.h (struct tui_win_info)
4517         <do_make_visible_with_new_height, make_visible_with_new_height>:
4518         New methods.
4519         (struct tui_source_window_base, struct tui_data_window)
4520         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
4521         methods.
4522
4523 2019-06-25  Tom Tromey  <tom@tromey.com>
4524
4525         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
4526         method.
4527         (update_tab_width): Call update_tab_width method.
4528         * tui/tui-data.h (struct tui_win_info)
4529         (struct tui_source_window_base) <update_tab_width>: New methods.
4530
4531 2019-06-25  Tom Tromey  <tom@tromey.com>
4532
4533         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
4534         parameter.
4535         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
4536         parameter.
4537         (tui_gen_win_info::make_visible): Update.
4538         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
4539         parameter.
4540         * tui/tui-data.h (enum tui_box): New enum.
4541         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
4542
4543 2019-06-25  Tom Tromey  <tom@tromey.com>
4544
4545         * tui/tui-layout.c (make_source_or_disasm_window): Always use
4546         init_and_make_win for EXEC_INFO_WIN.
4547         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
4548         longer inline.
4549         (struct tui_win_info) <~tui_win_info>: Inline.
4550         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4551         Don't declare.
4552         * tui/tui-data.c (source_win, disasm_win): Remove globals.
4553         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4554         Remove.
4555         (tui_initialize_static_data): Update.
4556         (~tui_gen_win_info): Handle more cleanup here.
4557         (~tui_source_window_base): Delete "execution_info".
4558         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
4559
4560 2019-06-25  Tom Tromey  <tom@tromey.com>
4561
4562         * tui/tui-layout.c (make_command_window): Don't set
4563         can_highlight.
4564         (show_source_disasm_command): Call the reset method.
4565         (show_data): Don't set can_highlight.  Call the reset method.
4566         (tui_gen_win_info::reset): Rename from init_gen_win_info
4567         (init_and_make_win): Simplify.  Return tui_gen_win_info.
4568         (show_source_or_disasm_and_command): Call the reset method.
4569         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
4570         (struct tui_cmd_window): Set can_highlight.
4571
4572 2019-06-25  Tom Tromey  <tom@tromey.com>
4573
4574         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
4575         from make_visible.
4576         (tui_make_visible, tui_make_invisible): Rewrite.
4577         (tui_win_info::make_visible): Remove.
4578         (tui_source_window_base::make_visible): Update.
4579         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
4580         method.  Moved from...
4581         (struct tui_win_info) <make_visible>: ...here.
4582
4583 2019-06-25  Tom Tromey  <tom@tromey.com>
4584
4585         * tui/tui-winsource.c
4586         (tui_source_window_base::do_scroll_horizontal): Remove direction
4587         parameter.
4588         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
4589         direction parameter.
4590         * tui/tui-win.c (tui_win_info::forward_scroll)
4591         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4592         (tui_win_info::right_scroll): Update.
4593         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
4594         direction parameter.
4595         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
4596         direction parameter.
4597         * tui/tui-data.h (enum tui_scroll_direction): Remove.
4598         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
4599         Remove direction parameter.
4600         (struct tui_source_window_base, struct tui_source_window)
4601         (struct tui_disasm_window, struct tui_data_window)
4602         (struct tui_cmd_window): Update.
4603
4604 2019-06-25  Tom Tromey  <tom@tromey.com>
4605
4606         * tui/tui-winsource.h (tui_set_exec_info_content)
4607         (tui_show_exec_info_content, tui_erase_exec_info_content)
4608         (tui_clear_exec_info_content, tui_update_exec_info): Change
4609         argument to tui_source_window_base.
4610         * tui/tui-winsource.c (tui_set_exec_info_content)
4611         (tui_show_exec_info_content, tui_erase_exec_info_content)
4612         (tui_clear_exec_info_content, tui_update_exec_info): Change
4613         argument to tui_source_window_base.
4614
4615 2019-06-25  Tom Tromey  <tom@tromey.com>
4616
4617         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
4618         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
4619
4620 2019-06-25  Tom Tromey  <tom@tromey.com>
4621
4622         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
4623         check.
4624
4625 2019-06-25  Tom Tromey  <tom@tromey.com>
4626
4627         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
4628         type to void.
4629         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
4630         type to void.
4631         * tui/tui-source.c (tui_set_source_content): Update.
4632         * tui/tui-disasm.c (tui_set_disassem_content): Update.
4633
4634 2019-06-25  Tom Tromey  <tom@tromey.com>
4635
4636         * tui/tui-win.c (window_name_completer, tui_set_focus)
4637         (tui_all_windows_info): Use name method.
4638         * tui/tui-data.h (struct tui_gen_win_info)
4639         (struct tui_source_window, struct tui_disasm_window)
4640         (struct tui_data_window, struct tui_cmd_window) <name>: New
4641         method.
4642         (tui_win_name): Don't declare.
4643         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
4644         (tui_win_name): Remove.
4645
4646 2019-06-25  Tom Tromey  <tom@tromey.com>
4647
4648         * tui/tui-winsource.h (tui_update_source_window)
4649         (tui_update_source_window_as_is): Change parameter type.
4650         * tui/tui-winsource.c (tui_update_source_window): Change win_info
4651         to be a tui_source_window_base.
4652         (tui_update_source_window_as_is): Likewise.
4653         * tui/tui-win.c (make_visible_with_new_height): Update.
4654
4655 2019-06-25  Tom Tromey  <tom@tromey.com>
4656
4657         * tui/tui-winsource.c (tui_erase_source_content)
4658         (tui_show_source_content, tui_show_exec_info_content)
4659         (tui_erase_exec_info_content): Use refresh_window method.
4660         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
4661         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
4662         from tui_refresh_win.
4663         (tui_data_window::refresh_window): New method.
4664         (tui_win_info::refresh, tui_source_window_base::refresh)
4665         (tui_refresh_all): Use refresh_window method.
4666         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
4667         method.
4668         * tui/tui-regs.c (tui_display_register): Call refresh_window
4669         method.
4670         * tui/tui-layout.c (show_source_disasm_command)
4671         (show_source_or_disasm_and_command): Call refresh_window method.
4672         * tui/tui-data.h (struct tui_gen_win_info)
4673         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
4674         New method.
4675
4676 2019-06-25  Tom Tromey  <tom@tromey.com>
4677
4678         * tui/tui.c (tui_rl_other_window, tui_enable)
4679         (tui_is_window_visible, tui_get_command_dimension): Update.
4680         * tui/tui-winsource.c (tui_update_source_window_as_is)
4681         (tui_clear_source_content, tui_erase_source_content)
4682         (tui_show_source_line, tui_source_window_base::refill)
4683         (tui_source_window_base::do_scroll_horizontal)
4684         (tui_source_window_base::set_is_exec_point_at)
4685         (tui_update_breakpoint_info, tui_set_exec_info_content)
4686         (tui_alloc_source_buffer, tui_line_is_displayed)
4687         (tui_addr_is_displayed): Update.
4688         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4689         (tui_check_and_display_highlight_if_needed)
4690         (tui_win_info::make_visible, tui_win_info::refresh)
4691         (tui_refresh_all): Update.
4692         * tui/tui-windata.c (tui_first_data_item_displayed)
4693         (tui_delete_data_content_windows, tui_erase_data_content)
4694         (tui_display_all_data, tui_data_window::refresh_all)
4695         (tui_check_data_values): Update.
4696         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
4697         (tui_set_win_focus_to, tui_win_info::forward_scroll)
4698         (tui_win_info::backward_scroll, tui_refresh_all_win)
4699         (tui_resize_all, tui_set_focus, tui_all_windows_info)
4700         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
4701         (tui_source_window_base::set_new_height)
4702         (tui_data_window::set_new_height)
4703         (make_invisible_and_set_new_height)
4704         (make_visible_with_new_height, new_height_ok)
4705         (parse_scrolling_args): Update.
4706         * tui/tui-stack.c (tui_show_frame_info): Update.
4707         * tui/tui-source.c (tui_set_source_content)
4708         (tui_set_source_content_nil, tui_source_is_displayed)
4709         (tui_source_window::do_scroll_vertical): Update.
4710         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4711         (tui_display_registers_from, tui_display_reg_element_at_line)
4712         (tui_check_register_values, tui_reg_command): Update.
4713         * tui/tui-layout.c (tui_default_win_height)
4714         (show_source_disasm_command, show_data, init_and_make_win)
4715         (show_source_or_disasm_and_command): Update.
4716         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
4717         (tui_redisplay_readline, tui_mld_flush)
4718         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
4719         (tui_getc): Update.
4720         * tui/tui-disasm.c (tui_set_disassem_content)
4721         (tui_disasm_window::do_scroll_vertical): Update.
4722         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
4723         Now virtual.
4724         (struct tui_win_info): Derive from tui_gen_win_info.
4725         <~tui_win_info>: Mark as override.
4726         <generic>: Remove member.
4727         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
4728         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
4729         (~tui_data_window, ~tui_win_info)
4730         (tui_free_all_source_wins_content): Update.
4731         * tui/tui-command.c (tui_refresh_cmd_win): Update.
4732
4733 2019-06-25  Tom Tromey  <tom@tromey.com>
4734
4735         * tui/tui-layout.c (init_and_make_win): Use new.
4736         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
4737         destructor, initializers.
4738         (tui_alloc_generic_win_info): Don't declare.
4739         * tui/tui-data.c (_locator): Add argument to constructor.
4740         (source_win, disasm_win): New globals.
4741         (exec_info): Remove.
4742         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4743         Update.
4744         (tui_alloc_generic_win_info): Remove.
4745         (init_content_element): Use new.
4746         (tui_win_info::tui_win_info): Update.
4747         (free_content_elements) <case DATA_WIN>: Use delete.
4748
4749 2019-06-25  Tom Tromey  <tom@tromey.com>
4750
4751         * tui/tui-wingeneral.c (tui_refresh_win): Update.
4752         * tui/tui-windata.c (tui_first_data_item_displayed)
4753         (tui_delete_data_content_windows): Update.
4754         * tui/tui-win.c (tui_data_window::set_new_height): Update.
4755         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4756         (tui_display_registers_from, tui_check_register_values): Update.
4757         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
4758         pointer.
4759         * tui/tui-data.c (init_content_element): Update.  Allocate the new
4760         window.
4761         (tui_free_data_content): Update.
4762         (free_content_elements) <case DATA_WIN>: Free the window.
4763
4764 2019-06-25  Tom Tromey  <tom@tromey.com>
4765
4766         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
4767         Update.
4768         * tui/tui-layout.c (make_command_window)
4769         (show_source_disasm_command, show_data, init_and_make_win)
4770         (show_source_or_disasm_and_command): Update.
4771         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
4772         method.
4773         <can_highight, is_highlighted>: Now bool.
4774         (tui_set_win_highlight): Don't declare.
4775         * tui/tui-data.c (tui_set_win_highlight): Remove.
4776
4777 2019-06-25  Tom Tromey  <tom@tromey.com>
4778
4779         * tui/tui-wingeneral.c (make_visible): Remove check of window
4780         type.
4781
4782 2019-06-25  Tom Tromey  <tom@tromey.com>
4783
4784         * tui/tui-win.c (tui_win_info::max_height)
4785         (tui_cmd_window::max_height): New methods.
4786         (new_height_ok): Call max_height.
4787         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
4788         <max_height>: New method.
4789
4790 2019-06-25  Tom Tromey  <tom@tromey.com>
4791
4792         * tui/tui-win.c (tui_source_window_base::set_new_height)
4793         (tui_data_window::set_new_height): New methods.
4794         (make_invisible_and_set_new_height): Call set_new_height method.
4795         * tui/tui-data.h (struct tui_win_info)
4796         (struct tui_source_window_base, struct tui_data_window)
4797         <set_new_height>: New method.
4798
4799 2019-06-25  Tom Tromey  <tom@tromey.com>
4800
4801         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
4802         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
4803         tui_refresh_data_win.
4804         * tui/tui-win.c (tui_source_window_base::refresh_all): New
4805         method.
4806         (tui_refresh_all_win): Call the refresh_all method.
4807         (tui_set_focus): Likewise.
4808         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
4809         (struct tui_source_window_base, struct tui_data_window) <refresh>:
4810         Likewise.
4811
4812 2019-06-25  Tom Tromey  <tom@tromey.com>
4813
4814         * tui/tui-winsource.h (tui_refill_source_window)
4815         (tui_set_is_exec_point_at): Don't declare.
4816         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4817         (tui_source_window_base::refill): Rename from
4818         tui_refill_source_window.
4819         (tui_source_window_base::do_scroll_horizontal): Update.
4820         (tui_source_window_base::set_is_exec_point_at): Rename from
4821         tui_set_is_exec_point_at.
4822         (tui_update_all_breakpoint_info): Update.
4823         * tui/tui-stack.c (tui_show_frame_info): Update.
4824         * tui/tui-layout.c (show_data): Add cast.
4825         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
4826         * tui/tui-data.h (struct tui_source_window_base) <refill,
4827         set_is_exec_point_at>: New methods.
4828         (tui_source_windows, tui_add_to_source_windows): Update types.
4829         (tui_add_to_source_windows): Remove redundant declaration.
4830         * tui/tui-data.c (source_windows): Store tui_source_window_base.
4831         (tui_source_windows): Change return type.
4832         (tui_clear_source_windows_detail): Update.
4833         (tui_add_to_source_windows): Change type of parameter.
4834         (tui_free_all_source_wins_content): Update.
4835
4836 2019-06-25  Tom Tromey  <tom@tromey.com>
4837
4838         * tui/tui-wingeneral.c (tui_win_info::refresh)
4839         (tui_source_window_base::refresh): New methods.
4840         (tui_refresh_all): Call the refresh method.
4841         * tui/tui-data.h (struct tui_win_info)
4842         (struct tui_source_window_base) <refresh>: New method.
4843
4844 2019-06-25  Tom Tromey  <tom@tromey.com>
4845
4846         * tui/tui.h (tui_is_window_visible): Return bool.
4847         * tui/tui.c (tui_is_window_visible): Return bool.
4848         * tui/tui-wingeneral.c (tui_make_window, make_visible)
4849         (tui_make_visible, tui_make_invisible)
4850         (tui_win_info::make_visible)
4851         (tui_source_window_base::make_visible, make_all_visible)
4852         (tui_make_all_visible, tui_make_all_invisible): Update.
4853         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
4854         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
4855         bool.
4856         (struct tui_win_info, struct tui_source_window_base)
4857         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
4858         * tui/tui-data.c (tui_init_generic_part): Update.
4859
4860 2019-06-25  Tom Tromey  <tom@tromey.com>
4861
4862         * tui/tui-wingeneral.c (tui_win_info::make_visible)
4863         (tui_source_window_base::make_visible): New methods.
4864         (make_all_visible): Make method call.
4865         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
4866         (struct tui_source_window_base, struct tui_cmd_window): Override
4867         make_visible.
4868         (tui_win_is_source_type): Don't declare.
4869         * tui/tui-data.c (tui_win_is_source_type): Remove.
4870
4871 2019-06-25  Tom Tromey  <tom@tromey.com>
4872
4873         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
4874         NULL check.
4875
4876 2019-06-25  Tom Tromey  <tom@tromey.com>
4877
4878         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
4879         Inline constructor.  Add initializers for members.
4880         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
4881         constructors; now inline in class.
4882
4883 2019-06-25  Tom Tromey  <tom@tromey.com>
4884
4885         * tui/tui-regs.c (tui_show_registers): Update.
4886         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
4887         bool.
4888         * tui/tui-data.c (tui_data_window::clear_detail)
4889         (tui_data_window): Update.
4890
4891 2019-06-25  Tom Tromey  <tom@tromey.com>
4892
4893         * tui/tui-windata.c (tui_display_all_data)
4894         (tui_display_data_from_line, tui_display_data_from)
4895         (tui_check_data_values, tui_data_window::do_scroll_vertical):
4896         Update.
4897         * tui/tui-regs.c (tui_last_regs_line_no)
4898         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4899         (tui_show_registers, tui_show_register_group)
4900         (tui_display_registers_from, tui_display_reg_element_at_line)
4901         (tui_display_registers_from_line, tui_check_register_values)
4902         (tui_reg_next, tui_reg_prev): Update.
4903         * tui/tui-layout.c (tui_set_layout, show_data): Update.
4904         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
4905         tui_data_window.
4906         (struct tui_win_info) <detail>: Remove.  Add new fields from
4907         tui_data_info.
4908         (TUI_DATA_WIN): Add cast.
4909         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
4910         (~tui_data_window): Simplify.
4911
4912 2019-06-25  Tom Tromey  <tom@tromey.com>
4913
4914         * tui/tui-layout.c (show_source_disasm_command)
4915         (show_source_or_disasm_and_command): Update.
4916         * tui/tui-io.c (update_cmdwin_start_line)
4917         (tui_redisplay_readline): Update.
4918         * tui/tui-data.h (struct tui_command_info): Remove.
4919         (struct tui_win_info) <detail>: Remove command_info member.
4920         (struct tui_data_window) <start_line>: New member, from
4921         tui_command_info.
4922         (TUI_CMD_WIN): Add casts.
4923
4924 2019-06-25  Tom Tromey  <tom@tromey.com>
4925
4926         * tui/tui-winsource.c (tui_update_source_window)
4927         (tui_refill_source_window)
4928         (tui_source_window_base::do_scroll_horizontal)
4929         (tui_update_breakpoint_info, tui_set_exec_info_content)
4930         (tui_show_exec_info_content, tui_erase_exec_info_content)
4931         (tui_clear_exec_info_content): Update.
4932         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
4933         Update.
4934         * tui/tui-win.c (make_invisible_and_set_new_height)
4935         (make_visible_with_new_height): Update.
4936         * tui/tui-source.c (tui_set_source_content)
4937         (tui_show_symtab_source): Update.
4938         * tui/tui-layout.c (extract_display_start_addr)
4939         (show_source_disasm_command, show_data)
4940         (make_source_or_disasm_window)
4941         (show_source_or_disasm_and_command): Update.
4942         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
4943         (tui_disasm_window::do_scroll_vertical): Remove shadowing
4944         "gdbarch".
4945         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
4946         to tui_source_window_base.
4947         (struct tui_win_info) <detail>: Remove source_info member.
4948         (struct tui_source_window_base) <has_locator>: Inline.
4949         Move contents from tui_source_info; rename has_locator member to
4950         m_has_locator.
4951         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
4952         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
4953         header file.
4954         (tui_source_window_base::clear_detail, ~tui_source_window_base):
4955         Simplify.
4956         (tui_free_all_source_wins_content): Cast to
4957         tui_source_window_base.
4958
4959 2019-06-25  Tom Tromey  <tom@tromey.com>
4960
4961         * tui/tui-win.c (make_invisible_and_set_new_height)
4962         (make_visible_with_new_height): Call has_locator method.
4963         * tui/tui-layout.c (show_source_disasm_command, show_data)
4964         (show_source_or_disasm_and_command): Update for bool change.
4965         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
4966         (tui_win_info) <has_locator>: New method.
4967         (struct tui_source_window_base) <has_locator>: New method.
4968         (tui_win_has_locator): Don't declare.
4969         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
4970         from tui_win_has_locator.
4971         (tui_source_window_base): Use false, not FALSE.
4972
4973 2019-06-25  Tom Tromey  <tom@tromey.com>
4974
4975         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
4976         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
4977         clear_detail method directly.
4978         (tui_clear_win_detail): Remove.
4979
4980 2019-06-25  Tom Tromey  <tom@tromey.com>
4981
4982         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
4983         "this", not TUI_DISASM_WIN.
4984
4985 2019-06-25  Tom Tromey  <tom@tromey.com>
4986
4987         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
4988         declare.
4989         * tui/tui-winsource.c
4990         (tui_source_window_base::do_scroll_horizontal): Rename from
4991         tui_horizontal_source_scroll.
4992         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
4993         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
4994         from tui_vertical_data_scroll.
4995         * tui/tui-win.h (tui_scroll): Don't declare.
4996         * tui/tui-win.c (tui_win_info::forward_scroll)
4997         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4998         (tui_win_info::right_scroll): Rename and update.
4999         (tui_scroll_forward_command, tui_scroll_backward_command)
5000         (tui_scroll_left_command, tui_scroll_right_command): Update.
5001         (tui_scroll): Remove.
5002         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
5003         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
5004         from tui_vertical_source_scroll.
5005         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
5006         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
5007         from tui_vertical_disassem_scroll.
5008         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
5009         do_scroll_horizontal>: New methods.
5010         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
5011         Likewise.
5012         (struct tui_source_window_base): Add do_scroll_horizontal.
5013         (struct tui_source_window, struct tui_disasm_window): Add
5014         do_scroll_vertical.
5015         (struct tui_data_window, struct tui_cmd_window): Add
5016         do_scroll_horizontal and do_scroll_vertical.
5017         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
5018
5019 2019-06-25  Tom Tromey  <tom@tromey.com>
5020
5021         * tui/tui-data.h (struct tui_source_window_base): New struct.
5022         (struct tui_source_window): Derive from tui_source_window_base.
5023         (struct tui_disasm_window): New struct.
5024         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
5025         from tui_source_window::clear_detail.
5026         (tui_source_window_base): Rename from tui_source_window.
5027         (~tui_source_window_base): Rename from ~tui_source_window.
5028         (tui_alloc_win_info): Create a tui_disasm_window.
5029
5030 2019-06-25  Tom Tromey  <tom@tromey.com>
5031
5032         * tui/tui-data.h (struct tui_source_window)
5033         (struct tui_data_window): Declare destructors.
5034         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
5035         destructors.
5036         (tui_win_info): Simplify.
5037
5038 2019-06-25  Tom Tromey  <tom@tromey.com>
5039
5040         * tui/tui-winsource.c (tui_display_main)
5041         (tui_update_source_windows_with_addr)
5042         (tui_update_all_breakpoint_info): Update.
5043         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5044         (new_height_ok, parse_scrolling_args): Update.
5045         * tui/tui-stack.c (tui_show_frame_info): Update.
5046         * tui/tui-data.h (struct tui_list): Remove.
5047         (tui_source_windows): Return a reference to a std::vector.
5048         * tui/tui-data.c (source_windows): Now a std::vector.
5049         (tui_source_windows): Change return type.
5050         (tui_clear_source_windows): Rewrite.
5051         (tui_clear_source_windows_detail, tui_add_to_source_windows)
5052         (tui_free_all_source_wins_content): Rewrite.
5053
5054 2019-06-25  Tom Tromey  <tom@tromey.com>
5055
5056         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
5057         (struct tui_data_window, struct tui_cmd_window): Declare
5058         clear_detail method.
5059         * tui/tui-data.c (tui_source_window::clear_detail)
5060         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
5061         methods.
5062         (tui_clear_win_detail): Simplify.
5063
5064 2019-06-25  Tom Tromey  <tom@tromey.com>
5065
5066         * tui/tui-layout.c (make_source_window, make_disasm_window)
5067         (make_source_or_disasm_window): Remove win_info_ptr parameter.
5068         Return the new window.
5069         (show_source_disasm_command, show_data)
5070         (show_source_or_disasm_and_command): Update.
5071
5072 2019-06-25  Tom Tromey  <tom@tromey.com>
5073
5074         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
5075         parameter.  Return the new window.
5076         (show_source_disasm_command): Update and remove NULL check.
5077         (show_source_or_disasm_and_command): Update.
5078
5079 2019-06-25  Tom Tromey  <tom@tromey.com>
5080
5081         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
5082
5083 2019-06-25  Tom Tromey  <tom@tromey.com>
5084
5085         * tui/tui-data.h (struct tui_win_info): Make constructor
5086         protected.  Make destructor virtual.  Add initializers.
5087         (tui_source_window, tui_data_window, tui_cmd_window): New
5088         classes.
5089         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
5090         constructor.  Add "type" parameter.
5091         (tui_source_window, tui_data_window, tui_cmd_window): New
5092         constructors.
5093         (tui_alloc_win_info): Instantiate the appropriate subclass.
5094
5095 2019-06-25  Tom Tromey  <tom@tromey.com>
5096
5097         * tui/tui-win.c (tui_resize_all): Use delete.
5098         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
5099         destructor.
5100         (tui_free_window): Don't declare.
5101         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
5102         Update.
5103
5104 2019-06-25  Tom Tromey  <tom@tromey.com>
5105
5106         * tui/tui-data.h (struct tui_win_info): Add constructor.
5107         * tui/tui-data.c (tui_alloc_win_info): Use new.
5108         (tui_free_window): Use delete.
5109
5110 2019-06-22  Tom Tromey  <tom@tromey.com>
5111
5112         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
5113         declare.
5114         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
5115
5116 2019-06-22  Tom Tromey  <tom@tromey.com>
5117
5118         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
5119         declare.
5120         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
5121
5122 2019-06-22  Tom de Vries  <tdevries@suse.de>
5123
5124         * dwarf2read.c (create_addrmap_from_aranges)
5125         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
5126         instead of '%zu'.
5127
5128 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
5129
5130         * dwarf2read.h (dwarf2_section_info_def): Remove.
5131         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
5132         * dwarf2read.c (struct dwo_sections) <types>: Change type to
5133         std::vector<dwarf2_section_info>.
5134         (struct dwo_file) <~dwo_file>: Remove.
5135         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
5136         types field.
5137         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
5138         (dwarf2_read_debug_names): Likewise.
5139         (create_debug_types_hash_table): Change parameter type to
5140         array_view, adjust code accordingly.
5141         (dwarf2_locate_dwo_sections): Adjust to std::vector.
5142         (partial_die_info::fixup): Likewise.
5143         (determine_prefix): Likewise.
5144         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
5145
5146 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5147
5148         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
5149         gdb_bfd_ref_ptr.
5150         <~dwo_file>: Remove call to gdb_bfd_unref.
5151         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
5152         gdb_bfd_ref_ptr::get.
5153
5154 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5155
5156         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
5157         type to htab_up.
5158         * dwarf2read.c (struct dwo_file): Initialize fields.
5159         <~dwo_file>: New.
5160         (free_dwo_file): Remove, move content to ~dwo_file.
5161         (struct dwo_file_deleter): Remove.
5162         (dwo_file_up>: Remove custom deleter.
5163         (free_dwo_files): Remove.
5164         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
5165         dwo_files.
5166         (process_skeletonless_type_units): Call unique_ptr::get.
5167         (allocate_dwo_file_hash_table): Add deleter to created hash
5168         table.  Change return type to htab_up.
5169         (lookup_dwo_file_slot): Don't memset dwo_file, call
5170         unique_ptr::get.
5171         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
5172         (create_dwo_unit_in_dwp_v2): Likewise.
5173         (open_and_init_dwo_file): Likewise.
5174         (free_dwo_file_from_slot): Remove.
5175
5176 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5177
5178         * dwarf2read.h (struct dwarf2_section_info) <readin,
5179         is_virtual>: Change type to bool.
5180         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
5181         true instead of 1.
5182
5183 2019-06-19  Tom Tromey  <tom@tromey.com>
5184
5185         * tui/tui-data.h (tui_init_content_element): Don't declare.
5186
5187 2019-06-19  Tom Tromey  <tom@tromey.com>
5188
5189         * tui/tui-data.h (tui_init_win_info): Don't declare.
5190
5191 2019-06-19  Tom de Vries  <tdevries@suse.de>
5192
5193         * dwarf2read.h (abstract_to_concrete): Change type to
5194         std::unordered_map<sect_offset, std::vector<sect_offset>,
5195         gdb::hash_enum<sect_offset>>.
5196
5197 2019-06-19  Tom Tromey  <tromey@adacore.com>
5198
5199         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
5200         EVAL_AVOID_SIDE_EFFECTS specially.
5201
5202 2019-06-19  Tom Tromey  <tromey@adacore.com>
5203
5204         * source-cache.c (highlighter): New global.
5205         (source_cache::get_source_lines): Create a highlighter on demand.
5206
5207 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5208
5209         * defs.h (deprecated_interactive_hook): Delete declaration.
5210         * interps.c (clear_interpreter_hooks): Remove use of
5211         deprecated_interactive_hook.
5212         * top.c (deprecated_interactive_hook): Delete definition.
5213         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
5214
5215 2019-06-18  Tom de Vries  <tdevries@suse.de>
5216
5217         PR gdb/24515
5218         * dwarf2read.h (abstract_to_concrete): Change type from
5219         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
5220         std::unordered_map<sect_offset, std::vector<sect_offset>>.
5221         * dwarf2read.c (read_variable): Update.
5222         (dwarf2_fetch_die_loc_sect_off): Update.
5223
5224 2019-06-17  Tom de Vries  <tdevries@suse.de>
5225
5226         PR gdb/24617
5227         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
5228         accessing parent[parent_len - 1].
5229
5230 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
5231
5232         PR gdb/24364
5233         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
5234         call dtrace_process_dof with NULL dof.
5235
5236 2019-06-16  Tom de Vries  <tdevries@suse.de>
5237
5238         PR gdb/24445
5239         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
5240
5241 2019-06-16  Tom Tromey  <tom@tromey.com>
5242
5243         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5244         (make_all_visible): Use address of member.
5245
5246 2019-06-16  Tom Tromey  <tom@tromey.com>
5247
5248         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
5249         (tui_free_window, free_content, free_content_elements): Remove
5250         unnecessary cast.
5251         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
5252         cast.
5253         * tui/tui-regs.c (tui_show_register_group)
5254         (tui_display_registers_from, tui_display_reg_element_at_line):
5255         Remove unnecessary cast.
5256
5257 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
5258
5259         * linux-nat.c (normal_mask): Delete.
5260         (_initialize_linux_nat): Don't initialise normal_mask.
5261
5262 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
5263
5264         PR gdb/24445
5265         * dwarf-index-write.h (write_psymtabs_to_index): Add
5266         dwz_basename parameter.
5267         * dwarf-index-write.c (write_gdbindex): Move file writing to
5268         write_gdbindex_1.  Change return type void.
5269         (assert_file_size): Move up, remove filename parameter.
5270         (write_gdbindex_1): New function.
5271         (write_debug_names): Change return type to void, call
5272         assert_file_size.
5273         (struct index_wip_file): New struct.
5274         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
5275         file logic to index_wip_file.  Write index for dwz file if
5276         needed.
5277         (save_gdb_index_command): Pass basename of dwz file, if present.
5278         * dwarf-index-cache.c (index_cache::store): Obtain and pass
5279         build-id of dwz file, if present.
5280         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
5281         (dwarf2_get_dwz_file): Likewise.
5282         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
5283         (dwarf2_get_dwz_file): Likewise.
5284
5285 2019-06-16  Tom Tromey  <tom@tromey.com>
5286
5287         * coffread.c (process_coff_symbol): Use xstrdup.
5288         * value.c (create_internalvar): Use xstrdup.
5289
5290 2019-06-16  Tom Tromey  <tom@tromey.com>
5291
5292         * valops.c (value_cast, value_slice): Remove unnecessary cast.
5293         * breakpoint.c (stopin_command, stopat_command)
5294         (until_break_command, decode_location_default): Remove unnecessary
5295         cast.
5296         * utils.c (subset_compare): Remove unnecessary cast.
5297         * ada-lang.c (ada_update_initial_language): Remove unnecessary
5298         cast.
5299         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
5300         cast.
5301         * infcmd.c (path_command): Remove unnecessary cast.
5302         * coffread.c (decode_type): Remove unnecessary cast.
5303         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
5304         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
5305         * tui/tui-stack.c (tui_show_locator_content)
5306         (tui_show_frame_info): Remove unnecessary cast.
5307         * tui/tui-win.c (tui_scroll_forward_command)
5308         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
5309         (parse_scrolling_args): Remove unnecessary cast.
5310         * tui/tui-data.c (init_win_info, tui_del_window)
5311         (tui_free_window, tui_del_data_windows, tui_free_data_content)
5312         (free_content_elements): Remove unnecessary cast.
5313         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
5314         unnecessary cast.
5315         * tui/tui-source.c (tui_set_source_content)
5316         (tui_vertical_source_scroll): Remove unnecessary cast.
5317         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
5318         cast.
5319         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
5320         * tui/tui-regs.c (tui_display_registers_from)
5321         (tui_display_register): Remove unnecessary cast.
5322         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
5323         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
5324         (make_visible): Remove unnecessary cast.
5325         * tui/tui-winsource.c (tui_erase_source_content)
5326         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
5327         unnecessary cast.
5328         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
5329         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
5330         * stabsread.c (read_type, read_array_type, read_range_type):
5331         Remove unnecessary cast.
5332         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
5333         (parse_symbol, parse_type, upgrade_type, parse_external)
5334         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
5335         unnecessary cast.
5336         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
5337
5338 2019-06-16  Tom Tromey  <tom@tromey.com>
5339
5340         * tui/tui-data.c (tui_alloc_generic_win_info)
5341         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
5342         checks.
5343
5344 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
5345             Andrew Burgess  <andrew.burgess@embecosm.com>
5346
5347         * f-typeprint.c (f_print_type): Don't return early for not
5348         associated or not allocated types.
5349         (f_type_print_varspec_suffix): Add print_rank parameter and print
5350         ranks of array types in case they dangling.
5351         (f_type_print_base): Add print_rank parameter.
5352
5353 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5354
5355         * NEWS: Mention new MI commands.
5356         * break-catch-throw.c (enum exception_event_kind): Move to
5357         breakpoint.h.
5358         (print_mention_exception_catchpoint): Output text as a single
5359         message.
5360         (catch_exception_command_1): Rename to...
5361         (catch_exception_event): ...this, make non-static, update header
5362         command, and change some parameter types.
5363         (catch_catch_command): Update for changes to
5364         catch_exception_command_1.
5365         (catch_throw_command): Likewise.
5366         (catch_rethrow_command): Likewise.
5367         * breakpoint.c (enum exception_event_kind): Delete.
5368         * breakpoint.h (enum exception_event_kind): Moved here from
5369         break-catch-throw.c.
5370         (catch_exception_event): Declare.
5371         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
5372         (mi_cmd_catch_throw): New function.
5373         (mi_cmd_catch_rethrow): New function.
5374         (mi_cmd_catch_catch): New function.
5375         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
5376         'catch-catch' entries.
5377         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
5378         (mi_cmd_catch_rethrow): Declare.
5379         (mi_cmd_catch_catch): Declare.
5380
5381 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5382
5383         * annotate.c (annotate_source_line): Change return type to void,
5384         update implementation to match.
5385         * annotate.h (annotate_source_line): Change return type to void,
5386         update header comment.
5387         * stack.c (print_frame_info): Don't change what frame information
5388         is printed based on whether annotations are on or not.
5389
5390 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5391
5392         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
5393         (annotate_source): Make static.
5394         (annotate_source_line): Moved from source.c and renamed from
5395         identify_source_line.  Update the return type.
5396         * annotate.h (annotate_source): Delete declaration.
5397         (annotate_source_line): Declaration moved from source.h, and
5398         renamed from identify_source_line.  Return type updated.
5399         * source.c (identify_source_line): Moved to annotate.c and renamed
5400         to annotate_source_line.
5401         (info_line_command): Remove check of annotation_level.
5402         * source.h (identify_source_line): Move declaration to annotate.h
5403         and rename to annotate_source_line.
5404         * stack.c: Add 'annotate.h' include.
5405         (print_frame_info): Remove check of annotation_level before
5406         calling annotate_source_line.
5407
5408 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5409
5410         * source-cache.c (source_cache::get_plain_source_lines): Use
5411         open_source_file_with_line_charpos instead of just
5412         open_source_file, remove call to find_source_lines.
5413         (source_cache::get_source_lines): Likewise.
5414         * source.c (find_source_lines): Make static.
5415         (get_filename_and_charpos): Renamed into...
5416         (open_source_file_with_line_charpos): ..this along with changes to
5417         return a scoped_fd, and some other minor clean ups.
5418         (identify_source_line): Use open_source_file_with_line_charpos.
5419         (search_command_helper): Use open_source_file_with_line_charpos
5420         instead of just open_source_file, remove call to
5421         find_source_lines.
5422         * source.h (open_source_file_with_line_charpos): Declare new
5423         function.
5424         (find_source_lines): Delete declaration.
5425
5426 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5427
5428         * source.c (get_filename_and_charpos): Remove fullname
5429         parameter.
5430         (identify_source_line): Update call to get_filename_and_charpos.
5431
5432 2019-06-14  Tom Tromey  <tromey@adacore.com>
5433
5434         PR gdb/24502:
5435         * ui-style.h (skip_ansi_escape): Update comment.
5436         * ui-file.h (class no_terminal_escape_file): New class.
5437         * ui-file.c (no_terminal_escape_file::write)
5438         (no_terminal_escape_file::puts): New methods.
5439         * cli/cli-logging.c (handle_redirections): Use
5440         no_terminal_escape_file.
5441
5442 2019-06-14  Tom Tromey  <tromey@adacore.com>
5443
5444         * NEWS: Move convenience variable news above Python news.
5445
5446 2019-06-14  Tom Tromey  <tom@tromey.com>
5447
5448         * gnulib: Move directory to top-level.
5449         * configure.ac: Don't configure gnulib.
5450         * configure: Rebuild.
5451         * common/common-defs.h: Use new path to gnulib.
5452         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
5453         (GNULIB_H): Remove.
5454         (INCGNU): Look in new gnulib location.
5455         (HFILES_NO_SRCDIR): Remove gnulib files.
5456         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
5457         (generated_files): Remove GNULIB_H.
5458         ($(LIBGNU), all-lib): Remove targets.
5459         (distclean): Don't mention GNULIB_BUILDDIR.
5460         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
5461
5462 2019-06-14  Tom Tromey  <tromey@adacore.com>
5463
5464         * symfile.c (add_symbol_file_command): Remove obsolete comment.
5465         Warn if symbol file does not provide any symbols.
5466
5467 2019-06-14  Tom Tromey  <tromey@adacore.com>
5468
5469         * source.c (find_and_open_source): Respect basenames_may_differ.
5470
5471 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
5472
5473         * annotate.c (annotate_breakpoints_invalid): Make use of
5474         scoped_restore_terminal_state.
5475         (annotate_frames_invalid): Likewise.
5476
5477 2019-06-14  Tom Tromey  <tromey@adacore.com>
5478
5479         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
5480         allow assignment to an internalvar.
5481
5482 2019-06-14  Tom Tromey  <tromey@adacore.com>
5483
5484         * ada-lex.l: Allow "_" in attribute names.
5485
5486 2019-06-14  Tom Tromey  <tromey@adacore.com>
5487
5488         PR gdb/24653:
5489         * regcache.c (registers_changed): Don't call alloca.
5490         * top.c (execute_command): Don't call alloca.
5491
5492 2019-06-13  Pedro Alves  <palves@redhat.com>
5493
5494         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
5495         'expression'.  When parsing an expression, error out if there's
5496         junk after "unlimited".
5497         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5498         (do_set_command): Adjust calls to is_unlimited_literal.
5499
5500 2019-06-13  Pedro Alves  <palves@redhat.com>
5501
5502         * compile/compile.c (make_compile_options_def_group): Add braces
5503         around array_view initializer.
5504         * thread.c (make_thread_apply_all_options_def_group)
5505         (make_thread_apply_all_options_def_group): Likewise.
5506
5507 2019-06-13  Pedro Alves  <palves@redhat.com>
5508
5509         * NEWS (New commands): Mention "maint test-options
5510         require-delimiter", "maint test-options unknown-is-error", "maint
5511         test-options unknown-is-operand" and "maint show
5512         test-options-completion-result".
5513         (New command options, command completion): New section.
5514         (Completion improvements): New section.
5515         Mention that you can abbreviate "unlimited".
5516
5517 2019-06-13  Pedro Alves  <palves@redhat.com>
5518
5519         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
5520         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
5521         * unittests/cli-utils-selftests.c (test_parse_flags)
5522         (test_parse_flags_qcs): Delete.
5523         (test_cli_utils): Don't call deleted functions.
5524
5525 2019-06-13  Pedro Alves  <palves@redhat.com>
5526
5527         * thread.c: Include "cli/cli-option.h".
5528         (tp_array_compar_ascending): Global.
5529         (tp_array_compar): Delete function.
5530         (tp_array_compar_ascending, tp_array_compar_descending): New
5531         functions.
5532         (ascending_option_def, qcs_flag_option_def)
5533         (thr_qcs_flags_option_defs)
5534         (make_thread_apply_all_options_def_group)
5535         (make_thread_apply_options_def_group): New.
5536         (thread_apply_all_command): Use gdb::option::process_options.
5537         (thread_apply_command_completer)
5538         (thread_apply_all_command_completer): New.
5539         (thread_apply_command): Use gdb::option::process_options.
5540         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
5541         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
5542         to generate help text of "thread apply".  Adjust "taas"'s help.
5543         * tid-parse.c (tid_range_parser::in_thread_range): New method.
5544         * tid-parse.h (tid_range_parser::in_thread_range): New method.
5545
5546 2019-06-13  Pedro Alves  <palves@redhat.com>
5547
5548         * thread.c (thread_apply_command): Check for invalid TID with
5549         isdigit instead of !isalpha.
5550
5551 2019-06-13  Pedro Alves  <palves@redhat.com>
5552
5553         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
5554         (validate_flags_qcs): New.
5555         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
5556         (validate_flags_qcs): Declare.
5557         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
5558         (make_frame_apply_options_def_group): New.
5559         (frame_apply_command_count): Process options with
5560         gdb::option::process_options.
5561         (frame_apply_completer): New.
5562         (frame_apply_level_completer, frame_apply_all_completer)
5563         (frame_apply_completer): New.
5564         (_initialize_stack): Update help of "frame apply", "frame apply
5565         level", "frame apply all" and "faas" to mention supported options
5566         and install command completers.
5567         * stack.h (frame_apply_all_completer): Declare.
5568         * thread.c: Include "stack.h".
5569         (tfaas_command): Add "--".
5570         (_initialize_thread): Update help "tfaas" to mention supported
5571         options and install command completer.
5572
5573 2019-06-13  Pedro Alves  <palves@redhat.com>
5574
5575         * completer.c (complete_nested_command_line): New.
5576         (gdb_completion_word_break_characters_throw): Add assertion.
5577         * completer.h (complete_nested_command_line): Declare.
5578
5579 2019-06-13  Pedro Alves  <palves@redhat.com>
5580
5581         * stack.c (parse_backtrace_qualifiers): New.
5582         (backtrace_command): Use it.
5583         (backtrace_command_completer): Complete on qualifiers.
5584
5585 2019-06-13  Pedro Alves  <palves@redhat.com>
5586
5587         * frame.c: Include "cli/cli-option.h.
5588         (user_set_backtrace_options): New.
5589         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
5590         Delete.
5591         (get_prev_frame): Adjust.
5592         (boolean_option_def, uinteger_option_def)
5593         (set_backtrace_option_defs): New.
5594         (_initialize_frame): Adjust and use
5595         gdb::option::add_setshow_cmds_for_options to install "set
5596         backtrace past-main" and "set backtrace past-entry".
5597         * frame.h: Include "cli/cli-option.h".
5598         (struct frame_print_options): Forward declare.
5599         (print_frame_arguments_all, print_frame_arguments_scalars)
5600         (print_frame_arguments_none): Declare.
5601         (print_entry_values): Delete declaration.
5602         (struct frame_print_options, user_frame_print_options): New.
5603         (struct set_backtrace_options): New.
5604         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
5605         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
5606         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
5607         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
5608         (list_args_or_locals): Add frame_print_options parameter.
5609         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5610         * python/py-framefilter.c (enumerate_args): Pass down
5611         USER_FRAME_PRINT_OPTIONS.
5612         * stack.c: Include "cli/cli-option.h".
5613         (print_frame_arguments_all, print_frame_arguments_scalars)
5614         (print_frame_arguments_none): Declare.
5615         (print_raw_frame_arguments, print_entry_values): Delete.
5616         (user_frame_print_options): New.
5617         (boolean_option_def, enum_option_def, frame_print_option_defs):
5618         New.
5619         (struct backtrace_cmd_options): New.
5620         (bt_flag_option_def): New.
5621         (backtrace_command_option_defs): New.
5622         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5623         (print_frame_arg, read_frame_arg, print_frame_args)
5624         (print_frame_info, print_frame): Add frame_print_options parameter
5625         and use it.
5626         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
5627         (backtrace_command_1): Add frame_print_options and
5628         backtrace_cmd_options parameters and use them.
5629         (make_backtrace_options_def_group): New.
5630         (backtrace_command): Process command options with
5631         gdb::option::process_options.
5632         (backtrace_command_completer): New.
5633         (_initialize_stack): Extend "backtrace"'s help to mention
5634         supported options.  Install completer for "backtrace".
5635         Install some settings commands with add_setshow_cmds_for_options.
5636
5637 2019-06-13  Pedro Alves  <palves@redhat.com>
5638
5639         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
5640         and that "set/show print raw frame-arguments" are now deprecated.
5641
5642         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
5643         command.
5644         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
5645         * stack.c (_initialize_stack): Install "set/show print
5646         raw-frame-arguments", and deprecate "set/show print raw
5647         frame-arguments".
5648         * valprint.c (_initialize_valprint): Deprecate "set/show print
5649         raw".
5650
5651 2019-06-13  Pedro Alves  <palves@redhat.com>
5652
5653         * compile/compile.c (struct compile_options): New.
5654         (compile_flag_option_def, compile_command_option_defs)
5655         (make_compile_options_def_group): New.
5656         (compile_file_command): Handle options with
5657         gdb::option::process_options.
5658         (compile_file_command_completer): New function.
5659         (compile_code_command): Handle options with
5660         gdb::option::process_options.
5661         (compile_code_command_completer): New function.
5662         (_initialize_compiler): Install completers for "compile code" and
5663         "compile file".  Mention available options in "compile code" and
5664         "compile code"'s help.
5665         * completer.c (advance_to_completion_word): New, factored out from
5666         ...
5667         (advance_to_expression_complete_word_point): ... this.
5668         (advance_to_filename_complete_word_point): New.
5669         * completer.h (advance_to_filename_complete_word_point): New
5670         declaration.
5671
5672 2019-06-13  Pedro Alves  <palves@redhat.com>
5673
5674         * compile/compile.c: Include "cli/cli-option.h".
5675         (compile_print_value): Scope data pointer is now a
5676         value_print_options pointer; adjust.
5677         (compile_print_command): Process options.  Scope data pointer is
5678         now a value_print_options pointer; adjust.
5679         (_initialize_compile): Update "compile print"'s help to include
5680         supported options.  Install a completer for "compile print".
5681         * cp-valprint.c (show_vtblprint, show_objectprint)
5682         (show_static_field_print): Delete.
5683         (_initialize_cp_valprint): Don't install "set print
5684         static-members", "set print vtbl", "set print object" here.
5685         * printcmd.c: Include "cli/cli-option.h" and
5686         "common/gdb_optional.h".
5687         (print_command_parse_format): Rework to fill in a
5688         value_print_options instead of a format_data.
5689         (print_value): Change parameter type from format_data pointer to
5690         value_print_options reference.  Adjust.
5691         (print_command_1): Process options.  Adjust to pass down a
5692         value_print_options.
5693         (print_command_completer): New.
5694         (_initialize_printcmd): Install print_command_completer as
5695         handle_brkchars completer for the "print" command.  Update
5696         "print"'s help to include supported options.
5697         * valprint.c: Include "cli/cli-option.h".
5698         (show_vtblprint, show_objectprint, show_static_field_print): Moved
5699         here from cp-valprint.c.
5700         (boolean_option_def, uinteger_option_def)
5701         (value_print_option_defs, make_value_print_options_def_group):
5702         New.  Use gdb::option::add_setshow_cmds_for_options to install
5703         "set print elements", "set print null-stop", "set print repeats",
5704         "set print pretty", "set print union", "set print array", "set
5705         print address", "set print symbol", "set print array-indexes".
5706         * valprint.h: Include <string> and "cli/cli-option.h".
5707         (make_value_print_options_def_group): Declare.
5708         (print_value): Change parameter type from format_data pointer to
5709         value_print_options reference.
5710         (print_command_completer): Declare.
5711
5712 2019-06-13  Pedro Alves  <palves@redhat.com>
5713
5714         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
5715         (COMMON_SFILES): Add maint-test-settings.c.
5716         * cli/cli-decode.c (boolean_enums): New global, factored out from
5717         ...
5718         (add_setshow_boolean_cmd): ... here.
5719         * cli/cli-decode.h (boolean_enums): Declare.
5720         * cli/cli-option.c: New file.
5721         * cli/cli-option.h: New file.
5722         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
5723         factored out from ...
5724         (parse_cli_boolean_value(const char *)): ... this.
5725         (is_unlimited_literal): Change parameter type to pointer to
5726         pointer.  Adjust and advance ARG pointer.
5727         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5728         (parse_cli_var_enum): New, factored out from ...
5729         (do_set_command): ... this.  Adjust.
5730         * cli/cli-setshow.h (parse_cli_boolean_value)
5731         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5732         (parse_cli_var_enum): Declare.
5733         * cli/cli-utils.c: Include "cli/cli-option.h".
5734         (get_ulongest): New.
5735         * cli/cli-utils.h (get_ulongest): Declare.
5736         (check_for_argument): New overloads.
5737         * maint-test-options.c: New file.
5738
5739 2019-06-13  Pedro Alves  <palves@redhat.com>
5740
5741         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
5742         parse a range if "-" is at the end of the string.
5743
5744 2019-06-13  Pedro Alves  <palves@redhat.com>
5745
5746         * cli/cli-setshow.c (parse_auto_binary_operation)
5747         (parse_cli_boolean_value): Don't allow "o".
5748
5749 2019-06-13  Pedro Alves  <palves@redhat.com>
5750
5751         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
5752         * NEWS: Mention maint test-settings KIND.
5753         * maint-test-settings.c: New file.
5754
5755 2019-06-13  Pedro Alves  <palves@redhat.com>
5756
5757         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
5758         completer.
5759         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
5760         "set" completers.
5761
5762 2019-06-13  Pedro Alves  <palves@redhat.com>
5763
5764         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
5765         after item.
5766
5767 2019-06-13  Pedro Alves  <palves@redhat.com>
5768
5769         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
5770
5771 2019-06-13  Pedro Alves <palves@redhat.com>
5772
5773         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
5774         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
5775         call.
5776         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
5777         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
5778         calls.
5779         (check_for_argument): Skip spaces after argument.
5780
5781 2019-06-13  Pedro Alves  <palves@redhat.com>
5782
5783         * thread.c (thread_apply_command): Adjust TID parsing.
5784         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
5785         detected before end of string.
5786         (tid_is_in_list): Error out if LIST is invalid.
5787
5788 2019-06-13  Pedro Alves  <palves@redhat.com>
5789
5790         * completer.c (complete_line_internal_1): Rewind completion word
5791         point.
5792         (completion_tracker::advance_custom_word_point_by): Change
5793         parameter type to int.
5794         * completer.h (completion_tracker::advance_custom_word_point_by):
5795         Likewise.
5796
5797 2019-06-13  Pedro Alves  <palves@redhat.com>
5798
5799         * completer.c (advance_to_completion_word): Handle delimiters.
5800
5801 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
5802
5803         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
5804
5805 2019-06-11  Tom Tromey  <tom@tromey.com>
5806
5807         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
5808         (xmalloc_failed): Move to alloc.c.
5809         * alloc.c: New file.
5810         * Makefile.in (COMMON_SFILES): Add alloc.c.
5811
5812 2019-06-11  Tom Tromey  <tom@tromey.com>
5813
5814         * nat/linux-waitpid.c: Don't include server.h.
5815         (linux_debug): Remove.
5816         (my_waitpid): Update.
5817
5818 2019-06-11  Tom Tromey  <tromey@adacore.com>
5819
5820         * infcall.c (_initialize_infcall): Remove trailing newline from
5821         help.
5822         * user-regs.c (_initialize_user_regs): Remove trailing newline
5823         from help.
5824         * typeprint.c (_initialize_typeprint): Remove trailing newline
5825         from help.
5826         * reverse.c (_initialize_reverse): Remove trailing newlines from
5827         help.
5828         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
5829         from help.
5830         * language.c (add_set_language_command): Remove trailing newline
5831         from help.
5832         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
5833         help.
5834         * disasm.c (_initialize_disasm): Remove trailing newline from
5835         help.
5836         * top.c (init_main): Remove trailing newline from help.
5837         * interps.c (_initialize_interpreter): Remove trailing newline
5838         from help.
5839         * btrace.c (_initialize_btrace): Remove trailing newlines from
5840         help.
5841         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
5842         from help.
5843         * python/python.c (_initialize_python): Remove trailing newline
5844         from help.
5845         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
5846         help.
5847         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
5848         from help.  Reformat some text.
5849         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
5850         from help.
5851         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
5852         newline from help.
5853
5854 2019-06-11  Tom Tromey  <tromey@adacore.com>
5855
5856         * darwin-nat.c (darwin_decode_exception_message)
5857         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
5858
5859 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5860
5861         * valops.c (value_slice): Check for not allocated or not
5862         associated values.
5863
5864 2019-06-10  Tom de Vries  <tdevries@suse.de>
5865
5866         PR gdb/24618
5867         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
5868         sure an empty slot (defined by a 32-bit zero pair) is recognized as
5869         invalid.
5870
5871 2019-06-10  Tom de Vries  <tdevries@suse.de>
5872
5873         PR gdb/24611
5874         * linespec.c (linespec_lexer_lex_string): Remove incorrect
5875         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
5876
5877 2019-06-10  Tom de Vries  <tdevries@suse.de>
5878
5879         PR symtab/24545
5880         * symtab.c (struct demangled_name_entry): Add language field.
5881         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
5882         static minimal symbol".  Set and use language field.
5883
5884 2019-06-10  Tom Tromey  <tromey@adacore.com>
5885
5886         * ada-lang.c (_initialize_ada_language): Update help text.
5887
5888 2019-06-10  Tom Tromey  <tromey@adacore.com>
5889
5890         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
5891         with a newline.
5892         * guile/guile.c (handle_boot_error): Don't end warning with a
5893         newline.
5894         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
5895         warning with a newline.
5896         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
5897         newline.
5898         (s12z_frame_cache): Likewise.
5899         * dwarf-index-cache.c (index_cache::store): Don't end warning with
5900         a newline.
5901         * solib-svr4.c (disable_probes_interface): Don't end warning with
5902         a newline.
5903         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
5904         newline.
5905         * python/python.c (do_finish_initialization): Don't end warning
5906         with a newline.
5907
5908 2019-06-10  Tom Tromey  <tom@tromey.com>
5909
5910         * python/py-breakpoint.c (gdbpy_breakpoint_created)
5911         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
5912         gdbpy_enter.
5913
5914 2019-06-10  Tom Tromey  <tromey@adacore.com>
5915
5916         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
5917         data.
5918         (elf_new_init): Don't call stabsread_new_init.
5919         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
5920         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
5921         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
5922
5923 2019-06-10  Tom de Vries  <tdevries@suse.de>
5924
5925         PR symtab/16264
5926         PR symtab/24517
5927         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
5928
5929 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
5930
5931         * source.c (find_and_open_source): Also rewrite relative file
5932         names.
5933
5934 2019-04-26  Amos Bird  <amosbird@gmail.com>
5935
5936         * annotate.c (annotate_thread_exited): Add "thread-exited"
5937         annotation.
5938
5939 2019-06-06  Tom Tromey  <tromey@adacore.com>
5940
5941         * maint.h (class scoped_command_stats): Use
5942         DISABLE_COPY_AND_ASSIGN.
5943         <print_time>: New method.
5944         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
5945         print_time.
5946         (scoped_command_stats::print_time): New method.
5947
5948 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
5949
5950         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
5951         instructions of lengths 6 or 8 bytes.
5952
5953 2019-06-04  Pedro Alves  <palves@redhat.com>
5954
5955         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
5956
5957         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
5958         * breakpoint.c (condition_completer): Likewise.
5959         * cli/cli-dump.c (scan_expression): Likewise.
5960         * common/filestuff.c (mkdir_recursive): Likewise.
5961         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
5962         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
5963         (gdb_abspath): Likewise.
5964         * compile/compile-cplus-types.c
5965         (compile_cplus_instance::decl_name): Likewise.
5966         * completer.c (complete_explicit_location):
5967         (signal_completer, reg_or_group_completer_1): Likewise.
5968         * cp-support.c (cp_remove_params_if_any): Likewise.
5969         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
5970         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
5971         * infcmd.c (strip_bg_char): Likewise.
5972         * linespec.c (copy_token_string): Likewise.
5973         * mi/mi-main.c (output_cores): Likewise.
5974         * psymtab.c (psymtab_search_name):
5975         * symfile.c (test_set_ext_lang_command): Likewise.
5976         * target.c (target_fileio_read_stralloc): Likewise.
5977         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
5978         * value.c (complete_internalvar): Likewise.
5979
5980 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
5981
5982         Add objfile property to gdb.Type.
5983         * NEWS: Mention Python API addition.
5984         * python/py-type.c (typy_get_objfile): New method.
5985
5986 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5987
5988         * NEWS: Mention the new set|show style [title|highlight].
5989         Mention changes to "show style", "help" and "apropos".
5990
5991 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5992
5993         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
5994         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
5995         instead of print_help_for_command.
5996         (print_doc_of_command): New function.
5997         (help_list): Add 'apropos -v word' suggestion.
5998         (print_help_for_command): Style the command name using title style.
5999         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
6000         (_initialize_cli_cmds): Describe -v in apropos_command help.
6001
6002 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6003
6004         * cli/cli-style.h (cli_style_option): Add name in constructor,
6005         add m_name class member, add constructor with intensity,
6006         add name class function.
6007         (cli_style_option::add_setshow_commands): Remove name argument.
6008         (highlight_style, title_style): New styles.
6009         * cli/cli-style.c (do_show): New function that shows a style
6010         characteristic styling the style name with itself.
6011         (set_style_name): New function.
6012         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
6013         Update all callers according to the changes in cli/cli-style.h.
6014         * utils.h (fputs_highlighted): New function.
6015         * utils.c (fputs_highlighted): Likewise.
6016
6017 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6018
6019         * NEWS: Mention new pipe command and new convenience variables.
6020
6021 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6022
6023         * cli/cli-cmds.c (pipe_command): New function.
6024         (_initialize_cli_cmds): Call add_com for pipe_command.
6025         Define | as an alias for pipe.
6026         (exit_status_set_internal_vars): New function.
6027         (shell_escape): Call exit_status_set_internal_vars.
6028         cli/cli-decode.c (find_command_name_length): Recognize | as
6029         a single character command.
6030
6031 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6032
6033         * gdbcmd.h (execute_command_to_ui_file): New declaration.
6034         top.c (execute_command_to_ui_file): New function, mostly a copy
6035         of execute_command_to_string.
6036         (execute_command_to_string): Implement by calling
6037         execute_command_to_ui_file.
6038
6039 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6040
6041         * top.h (saved_command_line): Remove declaration.
6042         * top.c (previous_saved_command_line, previous_repeat_arguments):
6043         New variables.
6044         (saved_command_line): Make static, define together with other
6045         'repeat variables'.
6046         (dont_repeat): Clear repeat_arguments.
6047         (repeat_previous, get_saved_command_line, save_command_line):
6048         New functions.
6049         (gdb_init): Initialize saved_command_line
6050         and previous_saved_command_line.
6051         * main.c (captured_main_1): Remove saved_command_line initialization.
6052         * event-top.c (handle_line_of_input): Update to use
6053         the new 'repeat' related functions instead of direct access to
6054         saved_command_line.
6055         * command.h (repeat_previous, get_saved_command_line,
6056         save_command_line): New declarations.
6057         (dont_repeat): Add comment.
6058
6059 2019-05-30  Tom Tromey  <tromey@adacore.com>
6060
6061         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
6062         Fix comment.
6063         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
6064
6065 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
6066
6067         PR cli/24587
6068         * completer.c (complete): Initialize variable word.
6069
6070 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
6071
6072         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6073         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
6074         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
6075         'body' is NULL to the outter 'if', protecting the '!is_define'
6076         situation as well.
6077
6078 2019-05-29  Tom Tromey  <tromey@adacore.com>
6079
6080         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
6081         (dwarf_unknown): New function.
6082         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
6083         (dwarf_type_encoding_name): Use dwarf_unknown.
6084
6085 2019-05-29  Tom Tromey  <tromey@adacore.com>
6086
6087         PR c++/20020:
6088         * cp-valprint.c (cp_print_value_fields): Call
6089         cp_print_static_field inside "try".
6090
6091 2019-05-29  Tom Tromey  <tromey@adacore.com>
6092
6093         * inflow.c (struct terminal_info): Add default operator=.
6094         * configure: Rebuild.
6095         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
6096         -Wdeprecated-copy-dtor, -Wredundant-move.
6097
6098 2019-05-29  Tom Tromey  <tromey@adacore.com>
6099
6100         * NEWS: Add entry.
6101         * infcmd.c (print_return_value_1): Handle finish_print
6102         option.
6103         (show_print_finish): New function.
6104         (_initialize_infcmd): Add "set/show print finish" commands.
6105         * valprint.c (user_print_options): Initialize new member.
6106         * valprint.h (struct value_print_options) <finish_print>: New
6107         member.
6108
6109 2019-05-28  Tom Tromey  <tromey@adacore.com>
6110
6111         * ada-lang.c (ada_remove_Xbn_suffix)
6112         (find_old_style_renaming_symbol)
6113         (parse_old_style_renaming): Remove.
6114         (ada_find_renaming_symbol): Don't call
6115         find_old_style_renaming_symbol.
6116         (ada_is_renaming_symbol): Rename from
6117         ada_find_renaming_symbol.  Remove "block" parameter.  Return
6118         bool.  Now static.
6119         (ada_read_var_value): Update and simplify.
6120         * ada-exp.y (write_var_or_type): Remove old code.
6121
6122 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
6123
6124         * event-top.c: Remove include comment.
6125         * inflow.c (class scoped_ignore_sigttou): Move from here...
6126         * inflow.h (class scoped_ignore_sigttou): ...to here.
6127         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
6128         * top.c:  Remove include comment.
6129
6130 2019-05-27  Tom Tromey  <tom@tromey.com>
6131
6132         * NEWS: Fix typo.
6133
6134 2019-05-22  Tom Tromey  <tromey@adacore.com>
6135
6136         * target.c (target_follow_exec): Constify parameter.
6137         * target-delegates.c: Rebuild.
6138         * remote.c (remote_target::follow_exec): Constify parameter.
6139         * infrun.c (follow_exec): Constify parameter.
6140         * target.h (struct target_ops) <follow_exec>: Constify parameter.
6141         (target_follow_exec): Likewise.
6142
6143 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6144
6145         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
6146         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
6147
6148 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6149
6150         * NEWS: Add debugredirect and testsuite sections.
6151
6152 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
6153
6154         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
6155         target descriptions using exclusively floating point register name
6156         aliases.
6157
6158 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6159
6160         PR gdb/18644:
6161         * f-lang.c (build_fortran_types): Handle the case where
6162         gdbarch_floatformat_for_type returns a nullptr.
6163
6164 2019-05-21  Tom de Vries  <tdevries@suse.de>
6165
6166         PR cli/24587
6167         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
6168
6169 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6170
6171         PR gdb/18644:
6172         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
6173         16-byte floats.
6174         * i386-tdep.c (i386_floatformat_for_type): Use
6175         floatformats_ia64_quad for the 16-byte floating point component
6176         within a fortran 32-byte complex number.
6177
6178 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6179
6180         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
6181         delete default constructor.
6182         (find_partial_die): Update to return const struct.
6183         (partial_die_parent_scope): Move variable declaration into scope
6184         of its use and change its type to auto.
6185         (guess_partial_die_structure_name): Likewise.
6186         (partial_die_info::fixup): Likewise.
6187
6188 2019-05-17  Tom Tromey  <tromey@adacore.com>
6189
6190         * source.c (find_and_open_source): Remove cast.
6191
6192 2019-05-17  Tom Tromey  <tromey@adacore.com>
6193
6194         * annotate.c (annotate_source): Make "filename" const.
6195         * annotate.h (annotate_source): Use const.
6196
6197 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6198
6199         * disasm.c (set_disassembler_options): Send errors to stderr.
6200
6201 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6202
6203         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
6204         (cli_interp_base::set_logging): Check debug_redirect.
6205         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
6206         * cli/cli-logging.c (debug_redirect): Add static variable.
6207         (pop_output_files): Add default param.
6208         (handle_redirections): Print debug setting.
6209         (show_logging_command): Likewise.
6210         (_initialize_cli_logging): Add debugredirect command.
6211         * interps.c (current_interp_set_logging): Add debug_redirect
6212         parameter.
6213         * interps.h (set_logging): Add debug_redirect parameter.
6214         (current_interp_set_logging): Likewise.
6215         * mi/mi-common.h: Likewise.
6216         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
6217
6218 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6219             Tom Tromey  <tromey@adacore.com>
6220
6221         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
6222         directly.
6223         * cli/cli-interp.h (make_logging_output): Remove declaration.
6224         * cli/cli-logging.c (make_logging_output): Remove function.
6225         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
6226         directly.
6227         * ui-file.c (tee_file::tee_file): Remove bools.
6228         (tee_file::~tee_file): Remove deletes.
6229         * ui-file.h (tee_file): Remove bools.
6230
6231 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
6232
6233         * mi/mi-cmds.h (mi_cmd_complete): New function.
6234         * mi/mi-main.c (mi_cmd_complete): Likewise.
6235         * mi/mi-cmds.c: Define new MI command -complete.
6236         * NEWS: Mention new -complete command.
6237
6238 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
6239
6240         * completer.h (complete): New function.
6241         * completer.c (complete): Likewise.
6242         * cli/cli-cmds.c: (complete_command): Update to use new complete()
6243         function defined in completer.h.
6244
6245 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
6246
6247         * MAINTAINERS (Write After Approval): Add myself.
6248
6249 2019-05-17  Tom de Vries  <tdevries@suse.de>
6250
6251         PR gdb/24094
6252         * dwarf2read.c (struct cu_partial_die_info): New struct.
6253         (find_partial_die): Return cu_partial_die_info.
6254         (partial_die_parent_scope, guess_partial_die_structure_name)
6255         (partial_die_info::fixup): Handle new return type of find_partial_die.
6256
6257 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6258
6259         PR breakpoints/24541
6260         * stap-probe.c (stap_parse_register_operand): Make "regname" an
6261         "std::string", simplifying the algorithm.
6262
6263 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6264
6265         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
6266         (stap_static_probe_ops::get_probes): Likewise.
6267
6268 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6269
6270         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
6271         '-')" and "else if".
6272         (stap_parse_single_operand): Join checks for
6273         "gdbarch_stap_parse_special_token_p" and
6274         "gdbarch_stap_parse_special_token" in the same "if" statement.
6275         Invert check when verifying for operation on register
6276         displacement.
6277
6278 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6279
6280         * stap-probe.c (stap_get_opcode): Update comment.
6281         (stap_get_expected_argument_type): Likewise.
6282         (handle_stap_probe): Likewise.
6283
6284 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6285
6286         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
6287         return type to 'bool'.  Adjust comment.  Use 'bool' when
6288         appropriate.
6289         (i386_stap_parse_special_token_three_arg_disp): Likewise.
6290         * stap-probe.c (stap_parse_argument_1): Likewise.
6291         (stap_is_operator): Likewise.
6292         (stap_is_generic_prefix): Likewise.
6293         (stap_is_register_prefix): Likewise.
6294         (stap_is_register_indirection_prefix): Likewise.
6295         (stap_is_integer_prefix): Likewise.
6296         (stap_generic_check_suffix): Likewise.
6297         (stap_check_integer_suffix): Likewise.
6298         (stap_check_register_suffix): Likewise.
6299         (stap_check_register_indirection_suffix): Likewise.
6300         (stap_parse_register_operand): Likewise.
6301         (stap_parse_single_operand): Likewise.
6302         (stap_parse_argument_1): Likewise.
6303         (stap_probe::get_argument_count): Likewise.
6304         (stap_is_operator): Likewise.
6305
6306 2019-05-16  Tom Tromey  <tromey@adacore.com>
6307
6308         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
6309         keyword to foreach.
6310
6311 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
6312
6313         * linux-thread-db.c (try_thread_db_load_1): Change return type
6314         to bool.
6315         (try_thread_db_load): Likewise.
6316         (try_thread_db_load_from_pdir_1): Likewise.
6317         (try_thread_db_load_from_pdir): Likewise.
6318         (try_thread_db_load_from_sdir): Likewise.
6319         (try_thread_db_load_from_dir): Likewise.
6320         (thread_db_load_search): Likewise.
6321         (has_libpthread): Likewise.
6322         (thread_db_load): Likewise.
6323
6324 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
6325
6326         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6327         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
6328         NULL, and complain/return if that's the case.
6329
6330 2019-05-15  John Darrington <john@darrington.wattle.id.au>
6331
6332         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
6333         (advance, posn, abstract_read_memory): New functions.
6334         [struct mem_read_abstraction]: New struct.
6335         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
6336
6337 2019-05-14  Tom Tromey  <tromey@adacore.com>
6338
6339         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
6340         value is not lval_memory.
6341
6342 2019-05-14  Tom Tromey  <tromey@adacore.com>
6343
6344         * solib.c (info_sharedlibrary_command): Style the file name.
6345
6346 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
6347
6348         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
6349         (aarch64_vnv_type): Likewise.
6350         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
6351         * common/tdesc.c: Likewise.
6352         * common/tdesc.h (enum tdesc_type_kind): Likewise.
6353         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
6354         * features/aarch64-fpu.xml: Add ieee half view.
6355         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
6356         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
6357         * gdbtypes.h (struct builtin_type): Likewise.
6358         (struct objfile_type): Likewise.
6359
6360 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
6361
6362         * language.c (language_sniff_from_mangled_name): Fix "langauge"
6363         typo.
6364         * location.h (string_to_event_location): Likewise.
6365
6366 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
6367
6368         GDB 8.3 released.
6369
6370 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6371
6372         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
6373         New variable declaration.
6374         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
6375         New variable.
6376         (print_one_breakpoint): Use ui_out::test_flags and new global
6377         variable to compute use_fixed_output.
6378         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
6379         Remove.
6380         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
6381         (mi_multi_location_breakpoint_output_fixed): Remove.
6382         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
6383         new variable.
6384         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
6385         fix_multi_location_breakpoint_output flag if version >= 3.
6386         * ui-out.h (enum ui_out_flag)
6387         <fix_multi_location_breakpoint_output>: New enumerator.
6388
6389 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6390
6391         * contrib/cc-with-tweaks.sh: Validate dwz's work.
6392
6393 2019-05-10  Tom Tromey  <tromey@adacore.com>
6394
6395         * ada-lang.c (catch_ada_completer): New function.
6396         (_initialize_ada_language): Use it.
6397
6398 2019-05-10  Tom Tromey  <tromey@adacore.com>
6399
6400         * thread.c (print_thread_info): Make "requested_threads" const.
6401         * gdbthread.h (print_thread_info): Make "requested_threads"
6402         const.
6403         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
6404         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
6405
6406 2019-05-08  Tom Tromey  <tom@tromey.com>
6407
6408         * gdbtypes.c (objfile_type_data): Change type.
6409         (objfile_type, _initialize_gdbtypes): Update.
6410
6411 2019-05-08  Tom Tromey  <tom@tromey.com>
6412
6413         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
6414         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
6415         (_initialize_dwarf2_frame): Update.
6416
6417 2019-05-08  Tom Tromey  <tom@tromey.com>
6418
6419         * objc-lang.c (objc_objfile_data): Change type.
6420         (find_methods): Update.
6421         (_initialize_objc_lang): Remove.
6422
6423 2019-05-08  Tom Tromey  <tom@tromey.com>
6424
6425         * stabsread.c (rs6000_builtin_type_data): Change type.
6426         (rs6000_builtin_type, _initialize_stabsread): Update.
6427
6428 2019-05-08  Tom Tromey  <tom@tromey.com>
6429
6430         * mips-tdep.c (mips_pdr_data): Remove.
6431         (_initialize_mips_tdep): Update.
6432
6433 2019-05-08  Tom Tromey  <tom@tromey.com>
6434
6435         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
6436         (hppa_init_objfile_priv_data, read_unwind_info)
6437         (find_unwind_entry, _initialize_hppa_tdep): Update.
6438
6439 2019-05-08  Tom Tromey  <tom@tromey.com>
6440
6441         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
6442         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
6443         on obstack.
6444         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
6445
6446 2019-05-08  Tom Tromey  <tom@tromey.com>
6447
6448         * mdebugread.c (basic_type_data): Change type.
6449         (basic_type, _initialize_mdebugread): Update.
6450
6451 2019-05-08  Tom Tromey  <tom@tromey.com>
6452
6453         * common/gdb_unique_ptr.h (struct noop_deleter): New.
6454
6455 2019-05-08  Tom Tromey  <tom@tromey.com>
6456
6457         * nto-tdep.c (nto_inferior_data_reg): Change type.
6458         (nto_inferior_data): Update.
6459         (nto_inferior_data_cleanup, nto_new_inferior_data)
6460         (_initialize_nto_tdep): Remove.
6461         * nto-tdep.h (struct nto_inferior_data): Add initializers.
6462
6463 2019-05-08  Tom Tromey  <tom@tromey.com>
6464
6465         * ada-lang.c (struct ada_inferior_data): Add initializers.
6466         (ada_inferior_data): Change type.
6467         (ada_inferior_data_cleanup): Remove.
6468         (get_ada_inferior_data, ada_inferior_exit)
6469         (struct ada_pspace_data): Add initializers, destructor.
6470         (ada_pspace_data_handle): Change type.
6471         (get_ada_pspace_data): Update.
6472         (ada_pspace_data_cleanup): Remove.
6473
6474 2019-05-08  Tom Tromey  <tom@tromey.com>
6475
6476         * coffread.c (struct coff_symfile_info): Add initializers.
6477         (coff_objfile_data_key): Move lower.  Change type.
6478         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
6479         Update.
6480         (coff_free_info): Remove.
6481
6482 2019-05-08  Tom Tromey  <tom@tromey.com>
6483
6484         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
6485         (fbsd_pspace_data_handle): Move lower.  Change type.
6486         (get_fbsd_pspace_data): Update.
6487         (fbsd_pspace_data_cleanup): Remove.
6488         (_initialize_fbsd_tdep): Update.
6489
6490 2019-05-08  Tom Tromey  <tom@tromey.com>
6491
6492         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
6493         (get_ada_tasks_pspace_data): Update.
6494         (ada_tasks_pspace_data_cleanup): Remove.
6495         (_initialize_tasks): Update.
6496         (ada_tasks_inferior_data_handle): Change type.
6497         (get_ada_tasks_inferior_data): Update.
6498         (ada_tasks_inferior_data_cleanup): Remove.
6499         (struct ada_tasks_pspace_data): Add initializers.
6500
6501 2019-05-08  Tom Tromey  <tom@tromey.com>
6502
6503         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
6504         * symfile-debug.c (debug_sym_get_probes): Change type.
6505         * stap-probe.c (handle_stap_probe):
6506         (stap_static_probe_ops::get_probes): Change type.
6507         * probe.h (class static_probe_ops) <get_probes>: Change type.
6508         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
6509         (parse_probes_in_pspace): Update.
6510         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
6511         Update.
6512         (any_static_probe_ops::get_probes): Change type.
6513         * elfread.c (elfread_data): New typedef.
6514         (probe_key): Change type.
6515         (elf_get_probes): Likewise.  Update.
6516         (probe_key_free): Remove.
6517         (_initialize_elfread): Update.
6518         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
6519         Change type.
6520         (dtrace_process_dof_probe, dtrace_process_dof)
6521         (dtrace_static_probe_ops::get_probe): Change type.
6522
6523 2019-05-08  Tom Tromey  <tom@tromey.com>
6524
6525         * xcoffread.c (struct xcoff_symfile_info): Rename from
6526         coff_symfile_info.  Add initializers.
6527         (xcoff_objfile_data_key): Move lower.  Change type.
6528         (XCOFF_DATA): Rewrite.
6529         (xcoff_free_info): Remove.
6530         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
6531         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
6532         (xcoff_initial_scan): Update.
6533
6534 2019-05-08  Tom Tromey  <tom@tromey.com>
6535
6536         * solib-svr4.c (struct svr4_info): Add initializers and
6537         destructor.
6538         <probes_table>: Now an htab_up.
6539         (solib_svr4_pspace_data): Change type.
6540         (free_probes_table): Simplify.
6541         (~svr4_info): Rename from svr4_pspace_data_cleanup.
6542         (get_svr4_info, probes_table_htab_remove_objfile_probes)
6543         (probes_table_remove_objfile_probes, register_solib_event_probe)
6544         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
6545         (_initialize_svr4_solib): Update.
6546
6547 2019-05-08  Tom Tromey  <tom@tromey.com>
6548
6549         * remote.c (remote_pspace_data): Change type.
6550         (remote_pspace_data_cleanup): Remove.
6551         (get_remote_exec_file, set_pspace_remote_exec_file)
6552         (_initialize_remote): Update.
6553
6554 2019-05-08  Tom Tromey  <tom@tromey.com>
6555
6556         * breakpoint.c (breakpoint_objfile_key): Change type.
6557         (get_breakpoint_objfile_data): Update.
6558         (free_breakpoint_objfile_data): Remove.
6559         (_initialize_breakpoint): Update.
6560
6561 2019-05-08  Tom Tromey  <tom@tromey.com>
6562
6563         * linux-tdep.c (struct linux_info): Add initializers.
6564         (linux_inferior_data): Move.  Change type.
6565         (invalidate_linux_cache_inf): Update.
6566         (linux_inferior_data_cleanup): Remove.
6567         (get_linux_inferior_data, _initialize_linux_tdep): Update.
6568
6569 2019-05-08  Tom Tromey  <tom@tromey.com>
6570
6571         * auxv.c (auxv_inferior_data): Move.  Change type.
6572         (auxv_inferior_data_cleanup): Remove.
6573         (invalidate_auxv_cache_inf): Rewrite.
6574         (get_auxv_inferior_data, _initialize_auxv): Update.
6575
6576 2019-05-08  Tom Tromey  <tom@tromey.com>
6577
6578         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
6579         (symfile_debug_objfile_data_key): Change type.
6580         (symfile_debug_installed, debug_qf_has_symbols)
6581         (debug_qf_find_last_source_symtab)
6582         (debug_qf_forget_cached_source_info)
6583         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
6584         (debug_qf_print_stats, debug_qf_dump)
6585         (debug_qf_expand_symtabs_for_function)
6586         (debug_qf_expand_all_symtabs)
6587         (debug_qf_expand_symtabs_with_fullname)
6588         (debug_qf_map_matching_symbols)
6589         (debug_qf_expand_symtabs_matching)
6590         (debug_qf_find_pc_sect_compunit_symtab)
6591         (debug_qf_map_symbol_filenames)
6592         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
6593         (debug_sym_new_init, debug_sym_init, debug_sym_read)
6594         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
6595         (debug_sym_read_linetable, debug_sym_relocate): Update.
6596         (symfile_debug_free_objfile): Remove.
6597         (install_symfile_debug_logging, _initialize_symfile_debug):
6598         Update.
6599
6600 2019-05-08  Tom Tromey  <tom@tromey.com>
6601
6602         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
6603         allocate_on_obstack.
6604         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
6605         (get_dwarf2_per_objfile): Update.
6606         (set_dwarf2_per_objfile): Remove.
6607         (dwarf2_has_info, dwarf2_get_section_info): Update.
6608         (dwarf2_free_objfile): Remove.
6609         (_initialize_dwarf2_read): Update.
6610
6611 2019-05-08  Tom Tromey  <tom@tromey.com>
6612
6613         * auto-load.c (struct auto_load_pspace_info): Add destructor and
6614         initializers.
6615         <unsupported_script_warning_printed,
6616         script_not_found_warning_printed>: Now bool.
6617         (auto_load_pspace_data): Change type.
6618         (~auto_load_pspace_info): Rename from
6619         auto_load_pspace_data_cleanup.
6620         (get_auto_load_pspace_data, init_loaded_scripts_info)
6621         (clear_section_scripts, maybe_print_unsupported_script_warning)
6622         (maybe_print_script_not_found_warning, _initialize_auto_load):
6623         Update.
6624
6625 2019-05-08  Tom Tromey  <tom@tromey.com>
6626
6627         * objfiles.c (objfile_pspace_info): Add destructor and
6628         initializers.
6629         (objfiles_pspace_data): Change type.
6630         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
6631         (get_objfile_pspace_data): Update.
6632         (objfiles_bfd_data): Change type.
6633         (get_objfile_bfd_data): Update.
6634         (objfile_bfd_data_free, _initialize_objfiles): Remove.
6635
6636 2019-05-08  Tom Tromey  <tom@tromey.com>
6637
6638         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
6639         Change type.
6640         (get_catch_syscall_inferior_data): Update.
6641         (catch_syscall_inferior_data_cleanup): Remove.
6642         (_initialize_break_catch_syscall): Update.
6643
6644 2019-05-08  Tom Tromey  <tom@tromey.com>
6645
6646         * inflow.c (struct terminal_info): Add destructor and
6647         initializers.
6648         (inflow_inferior_data): Change type.
6649         (~terminal_info): Rename from inflow_inferior_data_cleanup.
6650         (get_inflow_inferior_data, inflow_inferior_exit)
6651         (swap_terminal_info, _initialize_inflow): Update.
6652
6653 2019-05-08  Tom Tromey  <tom@tromey.com>
6654
6655         * target-dcache.c (target_dcache_cleanup): Remove.
6656         (target_dcache_aspace_key): Change type.
6657         (target_dcache_init_p, target_dcache_invalidate)
6658         (target_dcache_get, target_dcache_get_or_init)
6659         (_initialize_target_dcache): Update.
6660         * dcache.h (struct dcache_deleter): New.
6661
6662 2019-05-08  Tom Tromey  <tom@tromey.com>
6663
6664         * symtab.c (struct symbol_cache): Add destructor and
6665         initializers.
6666         (symbol_cache_key): Move.  Change type.
6667         (make_symbol_cache, free_symbol_cache): Remove.
6668         (get_symbol_cache): Update.
6669         (symbol_cache_cleanup): Remove.
6670         (ALL_PSPACES, symbol_cache_flush)
6671         (maintenance_print_symbol_cache)
6672         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
6673         Update.
6674
6675 2019-05-08  Tom Tromey  <tom@tromey.com>
6676
6677         * symtab.c (struct main_info): Add destructor and initializers.
6678         (main_progspace_key): Move.  Change type.
6679         (get_main_info): Update.
6680         (main_info_cleanup): Remove.
6681         (_initialize_symtab): Update.
6682
6683 2019-05-08  Tom Tromey  <tom@tromey.com>
6684
6685         * registry.h (DECLARE_REGISTRY): Define the _key class.
6686
6687 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6688
6689         * NEWS: Merge two 'New commands' sections.
6690
6691 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
6692
6693         * ada-valprint.c (ada_val_print_gnat_array): Remove language
6694         parameter and use Ada language definition instead.
6695         (ada_val_print_ptr): Remove unused language parameter.
6696         (ada_val_print_num): Remove language parameter and use Ada language
6697         definition instead.
6698         (ada_val_print_enum, ada_val_print_flt): Remove unused language
6699         parameter.
6700         (ada_val_print_struct_union, ada_val_print_ref): Remove language
6701         parameter and use Ada language definition instead.
6702         (ada_val_print_1): Update all ada_val_print_xxx calls.
6703         Remove language parameter.
6704         (ada_val_print): Update ada_val_print_1 call.
6705
6706 2019-05-08  Tom Tromey  <tromey@adacore.com>
6707
6708         * remote.c (remote_hw_watchpoint_limit)
6709         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
6710         Now static.
6711
6712 2019-05-08  Tom Tromey  <tromey@adacore.com>
6713
6714         * maint.c (_initialize_maint_cmds): Move initialization code to
6715         remote.c.
6716         (watchdog, show_watchdog): Move to remote.c.
6717         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
6718         "watchdog" static.
6719         (_initialize_remote): Move initialization code from maint.c.
6720         * defs.h (watchdog): Don't declare.
6721
6722 2019-05-08  Tom Tromey  <tromey@adacore.com>
6723
6724         * tui/tui-interp.c: Include main.h.
6725         * interps.c: Include main.h.
6726         * main.h (interpreter_p): Declare.
6727         * defs.h (interpreter_p): Don't declare.
6728
6729 2019-05-08  Tom Tromey  <tromey@adacore.com>
6730
6731         * dwarf2loc.c: Include dwarf2read.h.
6732         * defs.h (read_unsigned_leb128): Don't declare.
6733         * dwarf2read.h (read_unsigned_leb128): Declare.
6734
6735 2019-05-08  Tom Tromey  <tromey@adacore.com>
6736
6737         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
6738         method.
6739
6740 2019-05-08  Tom Tromey  <tromey@adacore.com>
6741
6742         * utils.c (fputs_maybe_filtered): Reset style after paging, even
6743         when no wrap column is set.
6744
6745 2019-05-08  Tom Tromey  <tromey@adacore.com>
6746
6747         * c-lang.c (c_get_string): Handle non-C-style arrays.
6748
6749 2019-05-08  Tom Tromey  <tromey@adacore.com>
6750
6751         * typeprint.c (print_offset_data::update): Print the bit offset,
6752         not the number of bits remaining.
6753
6754 2019-05-08  Tom Tromey  <tromey@adacore.com>
6755
6756         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
6757         padding at end of comment.
6758
6759 2019-05-08  Tom Tromey  <tromey@adacore.com>
6760
6761         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
6762         Compare main types.
6763
6764 2019-05-06  Tom Tromey  <tom@tromey.com>
6765
6766         * common/scoped_mmap.c: Include common-defs.h.
6767         * common/scoped_mmap.h: Don't include config.h.
6768
6769 2019-05-04  Tom Tromey  <tom@tromey.com>
6770
6771         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
6772         (struct aarch64_call_info): Add initializers.
6773         <si>: Now a std::vector.
6774         (pass_on_stack, aarch64_push_dummy_call): Update.
6775
6776 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
6777             Tom Tromey  <tom@tromey.com>
6778
6779         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
6780         (ppc_threads): Now a std::vector.  Now static.
6781         (hwdebug_find_thread_points_by_tid)
6782         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
6783         Update.
6784
6785 2019-05-04  Tom Tromey  <tom@tromey.com>
6786
6787         * arc-tdep.c (arc_tdesc_init): Return bool.
6788
6789 2019-05-04  Tom Tromey  <tom@tromey.com>
6790
6791         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
6792         Use gdb_assert_not_reached.
6793
6794 2019-05-04  Tom Tromey  <tom@tromey.com>
6795
6796         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
6797         "false".
6798
6799 2019-05-04  Tom Tromey  <tom@tromey.com>
6800
6801         * arc-tdep.c (arc_tdesc_init): Use bool.
6802
6803 2019-05-04  Tom Tromey  <tom@tromey.com>
6804
6805         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
6806
6807 2019-05-04  Tom Tromey  <tom@tromey.com>
6808
6809         * cli/cli-cmds.c (valid_command_p): Return bool.
6810
6811 2019-05-04  Tom Tromey  <tom@tromey.com>
6812
6813         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
6814         * command.h (valid_user_defined_cmd_name_p): Channge return type.
6815
6816 2019-05-04  Raul Tambre  <raul@tambre.ee>
6817
6818         * python/lib/gdb/prompt.py (_ExtendedPrompt)
6819         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
6820         operator for comparison.
6821
6822 2019-05-04  Tom Tromey  <tom@tromey.com>
6823
6824         * psymtab.c (psymbol_name_matches, match_partial_symbol)
6825         (lookup_partial_symbol, print_partial_symbols)
6826         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
6827         (psymbol_compare): Update.
6828         (add_psymbol_to_bcache): Clear the entire psymbol.
6829         (maintenance_check_psymtabs): Update.
6830         * psympriv.h (struct partial_symbol): Don't derive from
6831         general_symbol_info.
6832         <obj_section, unrelocated_address, address,
6833         set_unrelocated_address>: Update.
6834         <ginfo>: New member.
6835         * dwarf-index-write.c (write_psymbols, debug_names::insert)
6836         (debug_names::write_psymbols): Update.
6837
6838 2019-05-04  Tom de Vries  <tdevries@suse.de>
6839
6840         * contrib/cc-with-tweaks.sh: Support -n arg.
6841
6842 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6843
6844         * corelow.c (core_target::detach): Ensure frame cache and
6845         register caches are cleared.
6846         inferior.c (exit_inferior_1): Likewise.
6847
6848 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
6849             Tom Tromey  <tom@tromey.com>
6850
6851         * dictionary.c (collate_pending_symbols_by_language): Remove
6852         "struct" from foreach.
6853         * symtab.c (lookup_global_symbol_from_objfile)
6854         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
6855         foreach.
6856         * ser-tcp.c (net_open): Remove "struct" from foreach.
6857         * objfiles.c (objfile_relocate, objfile_rebase)
6858         (objfile_has_symbols): Remove "struct" from foreach.
6859         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
6860         from foreach.
6861         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
6862         foreach.
6863         * darwin-nat.c (thread_info_from_private_thread_info): Remove
6864         "struct" from foreach.
6865         * ada-lang.c (create_excep_cond_exprs)
6866         (ada_exception_catchpoint_cond_string): Remove "struct" from
6867         foreach.
6868
6869 2019-05-03  Tom Tromey  <tromey@adacore.com>
6870
6871         * ada-exp.y (convert_char_literal): Check suffix of each
6872         enumerator.
6873
6874 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
6875
6876         PR ada/21406:
6877         * ada-exp.y (yywrap): Don't define.
6878         * ada-lex.l (%option): Add noyywrap
6879         (yywrap): Remove.
6880
6881 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
6882
6883         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
6884         _WIN32_WINNT to the XP level, unless already defined to a higher
6885         level.
6886
6887         * unittests/parse-connection-spec-selftests.c:
6888         * ser-tcp.c:
6889         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
6890         override.
6891
6892         * symfile.c (find_separate_debug_file): Remove colon from the
6893         drive spec of DOS/Windows file names of the target, so that the
6894         file name produced from DEBUGDIR and the target's directory will
6895         be valid on DOS/Windows systems.
6896
6897 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
6898
6899         * rust-lang.c (val_print_struct): Handle printing structures
6900         containing strings.
6901
6902 2019-05-02  Tom Tromey  <tromey@adacore.com>
6903
6904         * valarith.c (_initialize_valarith): Remove.
6905
6906 2019-05-01  Tom Tromey  <tromey@adacore.com>
6907
6908         * ada-lang.c (ada_value_primitive_field): Treat more fields as
6909         bitfields.
6910
6911 2019-05-01  Tom Tromey  <tromey@adacore.com>
6912
6913         * ada-lang.c (ada_value_assign): Correctly compute starting offset
6914         for big-endian copies.
6915
6916 2019-04-30  Ali Tamur  <tamur@google.com>
6917         * gdb/dwarf2read.c (read_3_bytes): New declaration.
6918         (read_attribute_value): Added DW_FORM_strx1-4 cases.
6919         (read_3_bytes): New function.
6920
6921 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6922
6923         * windows-nat.c (main_thread_id): Delete.
6924         (handle_output_debug_string): Replace main_thread_id by
6925         current_event.dwThreadId.
6926         (fake_create_process): Likewise.
6927         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
6928         Do not set main_thread_id.
6929         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
6930         current_event.dwThreadId.
6931         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
6932
6933 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6934
6935         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
6936         Use current_event.dwThreadId instead of main_thread_id.
6937
6938 2019-04-30  Tom Tromey  <tromey@adacore.com>
6939
6940         * ada-lang.c (ada_lookup_simple_minsyms): New function.
6941         (create_excep_cond_exprs): Iterate over program spaces.
6942         (ada_exception_catchpoint_cond_string): Examine all minimal
6943         symbols for exception types.
6944
6945 2019-04-30  Tom Tromey  <tromey@adacore.com>
6946
6947         PR c++/24470:
6948         * dwarf2read.c (process_structure_scope): Handle case where type
6949         has template parameters but no symbol was created.
6950
6951 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6952             Chris January  <chris.january@arm.com>
6953
6954         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
6955         qualifier.
6956         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
6957
6958 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6959
6960         * f-typeprint.c (f_print_type): Update rules for printing
6961         whitespace.
6962         (f_type_print_varspec_suffix): Likewise.
6963
6964 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6965             Chris January  <chris.january@arm.com>
6966
6967         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
6968         function arguments.
6969
6970 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6971
6972         * f-lang.c (build_fortran_types): Change name of void type to
6973         lower case.
6974         * f-typeprint.c (f_type_print_base): Print the name of the void
6975         type, rather than a fixed string.
6976         * f-valprint.c (f_decorations): Use lower case void string.
6977
6978 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6979             Chris January  <chris.january@arm.com>
6980
6981         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
6982         types for Fortran.
6983
6984 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6985             Chris January  <chris.january@arm.com>
6986             David Lecomber  <david.lecomber@arm.com>
6987
6988         * f-exp.y (BINOP_INTRINSIC): New token.
6989         (exp): New parser rule handling BINOP_INTRINSIC.
6990         (f77_keywords): Add new builtin procedures.
6991         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
6992         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6993         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
6994         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6995         (print_unop_subexp_f): New function.
6996         (print_binop_subexp_f): New function.
6997         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6998         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6999         (dump_subexp_body_f): Likewise.
7000         (operator_check_f): Likewise.
7001         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7002         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
7003
7004 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7005
7006         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
7007         UNOP_KIND.
7008         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
7009         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
7010         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
7011         (operator_length_f): New fuction.
7012         (print_subexp_f): New function.
7013         (op_name_f): New function.
7014         (dump_subexp_body_f): New function.
7015         (operator_check_f): New function.
7016         (exp_descriptor_f): Replace standard expression handling functions
7017         with new functions.
7018         * gdb/fortran-operator.def: New file.
7019         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
7020         * gdb/std-operator.def: Remove UNOP_KIND.
7021
7022 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7023
7024         * std-operator.def: Remove unbalanced, stray double quote
7025         character.
7026
7027 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7028             Chris January  <chris.january@arm.com>
7029             Daniel Everett  <daniel.everett@arm.com>
7030             Nick Forrington  <nick.forrington@arm.com>
7031             Richard Bunt  <richard.bunt@arm.com>
7032
7033         * cp-valprint.c (cp_print_value_fields): Allow an additional level
7034         of depth when printing anonymous structs or unions.
7035         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
7036         Don't print either the top-level value, or the children if the
7037         max-depth is exceeded.
7038         (ppscm_print_children): When printing the key of a map, allow one
7039         extra level of depth.
7040         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
7041         print either the top-level value, or the children if the max-depth
7042         is exceeded.
7043         (print_children): When printing the key of a map, allow one extra
7044         level of depth.
7045         * python/py-value.c (valpy_format_string): Add max_depth keyword.
7046         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
7047         (user_print_options): Initialise max_depth field.
7048         (val_print_scalar_or_string_type_p): New function.
7049         (val_print): Check to see if the max depth has been reached.
7050         (val_print_check_max_depth): Define new function.
7051         (show_print_max_depth): New function.
7052         (_initialize_valprint): Add 'print max-depth' option.
7053         * valprint.h (struct value_print_options) <max_depth>: New field.
7054         (val_print_check_max_depth): Declare new function.
7055         * NEWS: Document new feature.
7056
7057 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7058
7059         * ada-lang.c (ada_language_defn): Initialise new field.
7060         * c-lang.c (c_is_string_type_p): New function.
7061         (c_language_defn): Initialise new field.
7062         (cplus_language_defn): Initialise new field.
7063         (asm_language_defn): Initialise new field.
7064         (minimal_language_defn): Initialise new field.
7065         * c-lang.h (c_is_string_type_p): Declare new function.
7066         * d-lang.c (d_language_defn): Initialise new field.
7067         * f-lang.c (f_is_string_type_p): New function.
7068         (f_language_defn): Initialise new field.
7069         * go-lang.c (go_is_string_type_p): New function.
7070         (go_language_defn): Initialise new field.
7071         * language.c (default_is_string_type_p): New function.
7072         (unknown_language_defn): Initialise new field.
7073         (auto_language_defn): Initialise new field.
7074         * language.h (struct language_defn) <la_is_string_type_p>: New
7075         member variable.
7076         (default_is_string_type_p): Declare new function.
7077         * m2-lang.c (m2_language_defn): Initialise new field.
7078         * objc-lang.c (objc_language_defn): Initialise new field.
7079         * opencl-lang.c (opencl_language_defn): Initialise new field.
7080         * p-lang.c (pascal_is_string_type_p): New function.
7081         (pascal_language_defn): Initialise new field.
7082         * rust-lang.c (rust_is_string_type_p): New function.
7083         (rust_language_defn): Initialise new field.
7084
7085 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7086
7087         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
7088         New field.
7089         * ada-lang.c (ada_language_defn): Initialise new field.
7090         * c-lang.c (c_language_defn): Likewise.
7091         (cplus_language_defn): Likewise.
7092         (asm_language_defn): Likewise.
7093         (minimal_language_defn): Likewise.
7094         * d-lang.c (d_language_defn): Likewise.
7095         * f-lang.c (f_language_defn): Likewise.
7096         * go-lang.c (go_language_defn): Likewise.
7097         * language.c (unknown_language_defn): Likewise.
7098         (auto_language_defn): Likewise.
7099         * m2-lang.c (m2_language_defn): Likewise.
7100         * objc-lang.c (objc_language_defn): Likewise.
7101         * opencl-lang.c (opencl_language_defn): Likewise.
7102         * p-lang.c (pascal_language_defn): Likewise.
7103         * rust-lang.c (rust_language_defn): Likewise.
7104
7105 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7106
7107         * ada-lang.c (ada_is_character_type): Change return type to bool.
7108         (ada_is_string_type): Likewise.
7109         * ada-lang.h (ada_is_character_type): Update declaration
7110         (ada_is_string_type): Likewise.
7111
7112 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7113
7114         Support style in 'frame|thread apply'
7115
7116         * gdbcmd.h (execute_command_to_string): New term_out parameter.
7117         * record.c (record_start, record_stop): Update callers of
7118         execute_command_to_string with false.
7119         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
7120         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
7121         methods.
7122         (class string_file): New constructor with term_out parameter.
7123         Override methods term_out and can_emit_style_escape.  New member
7124         term_out.
7125         (class stdio_file): Override can_emit_style_escape.
7126         (class tee_file): Override term_out and can_emit_style_escape.
7127         * utils.h (can_emit_style_escape): Remove.
7128         * utils.c (can_emit_style_escape): Likewise.
7129         Update all callers of can_emit_style_escape (SOMESTREAM) to
7130         SOMESTREAM->can_emit_style_escape.
7131         * source-cache.c (source_cache::get_source_lines): Likewise.
7132         * stack.c (frame_apply_command_count): Call execute_command_to_string
7133         passing the term_out characteristic of the current gdb_stdout.
7134         * thread.c (thr_try_catch_cmd): Likewise.
7135         * top.c (execute_command_to_string): pass term_out parameter
7136         to construct the string_file for the command output.
7137         * ui-file.c (term_cli_styling): New function (most code moved
7138         from utils.c can_emit_style_escape).
7139         (string_file::string_file, string_file::can_emit_style_escape,
7140         stdio_file::can_emit_style_escape, tee_file::term_out,
7141         tee_file::can_emit_style_escape): New functions.
7142
7143 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7144
7145         * NEWS: Mention the new set|show may-call-functions.
7146         * infcall.c (may_call_functions_p): New variable.
7147         (show_may_call_functions_p): New function.
7148         (call_function_by_hand_dummy): Throws an error if not
7149         may-call-functions.
7150         (_initialize_infcall): Call add_setshow_boolean_cmd for
7151         may-call-functions.
7152
7153 2019-04-25  Keith Seitz  <keiths@redhat.com>
7154
7155         PR c++/24367
7156         * cp-support.c (inspect_type): Don't attempt substitutions
7157         of symbol with the same name.
7158
7159 2019-04-25  Tom Tromey  <tromey@adacore.com>
7160
7161         PR gdb/24475:
7162         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
7163         static.
7164
7165 2019-04-25  Tom Tromey  <tromey@adacore.com>
7166
7167         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
7168         rvalue reference.
7169         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
7170         (gdb_xml_parser::parse): Use std::move.
7171         * python/python-internal.h (gdbpy_convert_exception): Take a const
7172         reference.
7173         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
7174         std::move.
7175         * python/py-utils.c (gdbpy_convert_exception): Take a const
7176         reference.
7177         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7178         Use std::move.
7179         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7180         Use std::move.
7181         * mi/mi-main.c (mi_print_exception): Take a const reference.
7182         * main.c (handle_command_errors): Take a const reference.
7183         * linespec.c (parse_linespec): Use std::move.
7184         * infcall.c (run_inferior_call): Use std::move.
7185         (call_function_by_hand_dummy): Use std::move.
7186         * exec.c (try_open_exec_file): Use std::move.
7187         * exceptions.h (exception_print, exception_fprintf)
7188         (exception_print_same): Update.
7189         * exceptions.c (print_exception, exception_print)
7190         (exception_fprintf, exception_print_same): Change parameters to
7191         const reference.
7192         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
7193         * common/new-op.c: Use std::move.
7194         * common/common-exceptions.h (struct gdb_exception): Add move
7195         constructor.
7196         (struct gdb_exception_error, struct gdb_exception_quit, struct
7197         gdb_quit_bad_alloc): Change constructor to move constructor.
7198         (throw_exception): Change parameter to rvalue reference.
7199         * common/common-exceptions.c (throw_exception): Take rvalue
7200         reference.
7201         * cli/cli-interp.c (safe_execute_command): Use std::move.
7202         * breakpoint.c (insert_bp_location, location_to_sals): Use
7203         std::move.
7204
7205 2019-04-25  Tom Tromey  <tromey@adacore.com>
7206
7207         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
7208         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
7209         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
7210         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
7211         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
7212         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
7213         guile/scm-value.c: Use unpack.
7214         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
7215         gdbscm_gdb_exception.
7216         (gdbscm_throw_gdb_exception): Likewise.
7217         (struct gdbscm_gdb_exception): New.
7218         (unpack): New function.
7219         (gdbscm_wrap): Use unpack.
7220
7221 2019-04-25  Tom Tromey  <tromey@adacore.com>
7222
7223         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7224         (gdb_rl_callback_handler): Use std::move.
7225         * common/common-exceptions.h (struct gdb_exception): Add move
7226         assignment operator.
7227         (throw_exception_sjlj): Change "exception" to const reference.
7228         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
7229         (throw_exception_sjlj): Change "exception" to const reference.
7230
7231 2019-04-25  Tom Tromey  <tromey@adacore.com>
7232
7233         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
7234         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
7235         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7236         Update.
7237         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7238         Update.
7239         * mi/mi-interp.c (mi_interp::exec): Update.
7240         * linespec.c (parse_linespec): Update.
7241         * infcall.c (run_inferior_call): Update.
7242         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
7243         * guile/scm-symbol.c (gdbscm_lookup_symbol)
7244         (gdbscm_lookup_global_symbol): Update.
7245         * guile/scm-param.c (gdbscm_parameter_value): Update.
7246         * guile/scm-frame.c (gdbscm_frame_read_register)
7247         (gdbscm_frame_read_var): Update.
7248         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
7249         * exec.c (try_open_exec_file): Update.
7250         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7251         (gdb_rl_callback_handler): Update.
7252         * common/common-exceptions.h (exception_none): Don't declare.
7253         * common/common-exceptions.c (exception_none): Don't define.
7254         (struct catcher) <exception>: Update.
7255         * cli/cli-interp.c (safe_execute_command): Update.
7256         * breakpoint.c (insert_bp_location, location_to_sals): Update.
7257
7258 2019-04-25  Ali Tamur  <tamur@google.com>
7259
7260         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
7261         (read_attribute_value): Likewise.
7262         (dwarf2_read_addr_index): Update comment.
7263         (read_str_index): Add DW_FORM_strx.
7264         (dwarf2_string_attr): Likewise.
7265         (dwarf2_const_value_attr): Likewise.
7266         (dump_die_shallow): Likewise.
7267         (dwarf2_fetch_constant_bytes): Likewise.
7268         (skip_form_bytes): Likewise.
7269         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
7270
7271 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
7272
7273         PR corefiles/11608
7274         PR corefiles/18187
7275         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
7276         OFFSET.  Verify if current mapping contains an ELF header.
7277         (linux_find_memory_regions_full): Adjust call to
7278         dump_mapping_p.
7279
7280 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
7281             Kang Li <kanglictf@gmail.com>
7282
7283         PR gdb/21600
7284
7285         * dwarf2-frame.c (read_initial_length): Be consistent about using
7286         unsigned representation of length.
7287         (decode_frame_entry_1): Likewise.  Check for wraparound of
7288         end pointer as well as buffer overflow.
7289
7290 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
7291
7292         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
7293         "vq".
7294
7295 2019-04-24  Tom Tromey  <tromey@adacore.com>
7296
7297         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
7298
7299 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7300
7301         * s12z-tdep.c (s12z_unwind_pc): Delete.
7302         (s12z_unwind_sp): Delete.
7303         (s12z_gdbarch_init): Don't register deleted functions with
7304         gdbarch.
7305
7306 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7307
7308         * rl78-tdep.c (rl78_unwind_sp): Delete.
7309         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
7310
7311 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7312
7313         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
7314         (xstormy16_unwind_pc): Delete.
7315         (xstormy16_dummy_id): Delete.
7316         (xstormy16_gdbarch_init): Don't register deleted functions with
7317         gdbarch.
7318
7319 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7320
7321         * vax-tdep.c (vax_unwind_pc): Delete.
7322         (vax_gdbarch_init): Don't register deleted function with gdbarch.
7323
7324 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7325
7326         * v850-tdep.c (v850_unwind_sp): Delete.
7327         (v850_unwind_pc): Delete.
7328         (v850_dummy_id): Delete.
7329         (v850_gdbarch_init): Don't register deleted functions with
7330         gdbarch.
7331
7332 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7333
7334         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
7335         (tilegx_unwind_pc): Delete.
7336         (tilegx_unwind_dummy_id): Delete.
7337         (tilegx_gdbarch_init): Don't register deleted functions with
7338         gdbarch.
7339
7340 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7341
7342         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
7343         (tic6x_dummy_id): Delete.
7344         (tic6x_gdbarch_init): Don't register deleted functions with
7345         gdbarch.
7346
7347 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7348
7349         * sparc-tdep.c (sparc_unwind_pc): Delete.
7350         (sparc32_gdbarch_init): Don't register deleted function with
7351         gdbarch.
7352
7353 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7354
7355         * sh-tdep.c (sh_unwind_sp): Delete.
7356         (sh_unwind_pc): Delete.
7357         (sh_dummy_id): Delete.
7358         (sh_gdbarch_init): Don't register deleted functions with
7359         gdbarch.
7360
7361 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7362
7363         * score-tdep.c (score_unwind_sp): Delete.
7364         (score_unwind_pc): Delete.
7365         (score_dummy_id): Delete.
7366         (score_gdbarch_init): Don't register deleted functions with
7367         gdbarch.
7368
7369 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7370
7371         * rx-tdep.c (rx_unwind_pc): Delete.
7372         (rx_unwind_sp): Delete.
7373         (rx_dummy_id): Delete.
7374         (rx_gdbarch_init): Don't register deleted functions with
7375         gdbarch.  Update comment.
7376
7377 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7378
7379         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
7380         (rs6000_dummy_id): Delete.
7381         (rs6000_gdbarch_init): Don't register deleted functions with
7382         gdbarch.
7383
7384 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7385
7386         * or1k-tdep.c (or1k_dummy_id): Delete.
7387         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
7388
7389 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7390
7391         * nios2-tdep.c (nios2_dummy_id): Delete.
7392         (nios2_unwind_sp): Delete.
7393         (nios2_gdbarch_init): Don't register deleted functions with
7394         gdbarch.
7395
7396 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7397
7398         * nds32-tdep.c (nds32_dummy_id): Delete.
7399         (nds32_unwind_pc): Delete.
7400         (nds32_unwind_sp): Delete.
7401         (nds32_gdbarch_init): Don't register deleted functions with
7402         gdbarch.
7403
7404 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7405
7406         * msp430-tdep.c (msp430_unwind_pc): Delete.
7407         (msp430_unwind_sp): Delete.
7408         (msp430_dummy_id): Delete.
7409         (msp430_gdbarch_init): Don't register deleted functions with
7410         gdbarch.
7411
7412 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7413
7414         * moxie-tdep.c (moxie_unwind_sp): Delete.
7415         (moxie_unwind_pc): Delete.
7416         (moxie_dummy_id): Delete.
7417         (moxie_gdbarch_init): Don't register deleted functions with
7418         gdbarch.
7419
7420 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7421
7422         * mn10300-tdep.c (mn10300_dummy_id): Delete.
7423         (mn10300_unwind_pc): Delete.
7424         (mn10300_unwind_sp): Delete.
7425         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
7426         mn10300_unwind_sp.
7427         (mn10300_frame_unwind_init): Don't register deleted functions with
7428         gdbarch.
7429
7430 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7431
7432         * mep-tdep.c (mep_unwind_pc): Delete.
7433         (mep_unwind_sp): Delete.
7434         (mep_dummy_id): Delete.
7435         (mep_gdbarch_init): Don't register deleted functions with
7436         gdbarch.
7437
7438 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7439
7440         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
7441         (m68hc11_unwind_sp): Delete.
7442         (m68hc11_gdbarch_init): Don't register deleted functions with
7443         gdbarch.
7444
7445 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7446
7447         * m32r-tdep.c (m32r_unwind_sp): Delete.
7448         (m32r_unwind_pc): Delete.
7449         (m32r_dummy_id): Delete.
7450         (m32r_gdbarch_init): Don't register deleted functions with
7451         gdbarch.
7452
7453 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7454
7455         * m32c-tdep.c (m32c_unwind_pc): Delete.
7456         (m32c_unwind_sp): Delete.
7457         (m32c_dummy_id): Delete.
7458         (m32c_gdbarch_init): Don't register deleted functions with
7459         gdbarch.
7460
7461 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7462
7463         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
7464         (lm32_unwind_pc): Delete.
7465         (lm32_dummy_id): Delete.
7466         (lm32_gdbarch_init): Don't register deleted functions with
7467         gdbarch.
7468
7469 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7470
7471         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
7472         (iq2000_unwind_pc): Delete.
7473         (iq2000_dummy_id): Delete.
7474         (iq2000_gdbarch_init): Don't register deleted functions with
7475         gdbarch.
7476
7477 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7478
7479         * nds32-tdep.c (nds32_type_align): Delete.
7480         (nds32_push_dummy_call): Use type_align instead.
7481
7482 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7483
7484         * arm-tdep.c (arm_type_align): Only handle vector override case.
7485         (arm_push_dummy_call): Use type_align.
7486         (arm_gdbarch_init): Register arm_type_align gdbarch function.
7487
7488 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7489
7490         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
7491         case.
7492         (pass_on_stack): Use type_align.
7493         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
7494         function.
7495
7496 2019-04-23  Tom Tromey  <tromey@adacore.com>
7497
7498         * dwarf2read.c (line_header::file_name_at): Remove unused
7499         overload.
7500
7501 2019-04-23  Tom de Vries  <tdevries@suse.de>
7502
7503         PR gdb/24438
7504         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
7505         invocation.
7506
7507
7508 2019-03-27  Ali Tamur  <tamur@google.com>
7509
7510         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
7511         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
7512         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
7513         (dwarf_expr_context::get_addr_index): Likewise
7514         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
7515         (symbol_needs_eval_context::get_addr_index): Likewise
7516         (disassemble_dwarf_expression): Add DW_OP_addrx
7517         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
7518         (read_cutu_die_from_dwo): Update comment
7519         (skip_one_die): Add DW_FORM_addrx
7520         (read_attribute_value): Likewise
7521         (var_decode_location): Add DW_OP_addrx
7522         (dwarf2_const_value_attr): Add DW_FORM_addrx
7523         (dump_die_shallow): Likewise
7524         (dwarf2_fetch_constant_bytes): Likewise
7525         (decode_locdesc): Add DW_OP_addrx
7526         (skip_form_bytes): Add DW_FORM_addrx
7527
7528 2019-04-22  Ali Tamur  <tamur@google.com>
7529
7530         * MAINTAINERS (Write After Approval): Add self.
7531
7532 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
7533
7534         * solib-svr4.c (get_svr4_info): Add pspace parameter.
7535         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
7536         (open_symbol_file_object): Likewise.
7537         (svr4_default_sos): Add info parameter.
7538         (svr4_read_so_list): Likewise.
7539         (svr4_current_sos_direct): Adjust functions calls to pass down
7540         info.
7541         (svr4_current_sos_1): Add info parameter.
7542         (svr4_current_sos): Call get_svr4_info, pass info down to
7543         svr4_current_sos_1.
7544         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
7545         get_svr4_info.
7546         (svr4_in_dynsym_resolve_code): Pass current_program_space to
7547         get_svr4_info.
7548         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
7549         to get_svr4_info.
7550         (probes_table_remove_objfile_probes): Likewise.
7551         (register_solib_event_probe): Add info parameter.
7552         (solist_update_incremental): Pass info parameter down to
7553         svr4_read_so_list.
7554         (disable_probes_interface): Add info parameter.
7555         (svr4_handle_solib_event): Pass current_program_space to
7556         get_svr4_info.  Adjust disable_probes_interface cleanup.
7557         (svr4_create_probe_breakpoints): Add info parameter, pass it
7558         down to register_solib_event_probe.
7559         (svr4_create_solib_event_breakpoints): Add info parameter,
7560         pass it down to svr4_create_probe_breakpoints.
7561         (enable_break): Pass info down to
7562         svr4_create_solib_event_breakpoints.
7563         (svr4_solib_create_inferior_hook): Pass current_program_space to
7564         get_svr4_info.
7565         (svr4_clear_solib): Likewise.
7566
7567 2019-04-22  Pedro Alves  <palves@redhat.com>
7568
7569         * solib-svr4.c (svr4_free_objfile_observer): New.
7570         (probe_and_action::objfile): New field.
7571         (probes_table_htab_remove_objfile_probes)
7572         (probes_table_remove_objfile_probes): New functions.
7573         (register_solib_event_probe): Add 'objfile' parameter.  Store it
7574         in the new probe_and_action.  Don't store the probe in 'lookup'.
7575         (svr4_create_probe_breakpoints): Pass objfile to
7576         register_solib_event_probe.
7577         (_initialize_svr4_solib): Register a free_objfile observer.
7578
7579 2019-04-19  Tom Tromey  <tom@tromey.com>
7580
7581         * common/queue.h: Remove.
7582
7583 2019-04-19  Tom Tromey  <tom@tromey.com>
7584
7585         * event-loop.c: Don't include "common/queue.h".
7586
7587 2019-04-19  Tom Tromey  <tom@tromey.com>
7588
7589         * remote.c (remote_target): Use delete.
7590         * remote-notif.h: Include <list>, not "common/queue.h".
7591         (notif_client_p): Remove typedef.
7592         (remote_notif_state): Add constructor, destructor, initializer.
7593         <notif_queue>: Now a std::list.
7594         (remote_notif_state_xfree): Don't declare.
7595         * remote-notif.c (remote_notif_process, handle_notification)
7596         (remote_notif_state_allocate): Update.
7597         (~remote_notif_state): Rename from remote_notif_state_xfree.
7598
7599 2019-04-19  Tom Tromey  <tom@tromey.com>
7600
7601         * symfile.c (reread_symbols): Update.
7602         * objfiles.c (objfile_register_static_link)
7603         (objfile_lookup_static_link): Update
7604         (~objfile) Don't delete static_links.
7605         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
7606
7607 2019-04-19  Tom Tromey  <tom@tromey.com>
7608
7609         * type-stack.h (struct type_stack) <insert>: Constify string.
7610         * type-stack.c (type_stack::insert): Constify string.
7611         * gdbtypes.h (lookup_template_type): Update.
7612         (address_space_name_to_int): Update.
7613         * gdbtypes.c (address_space_name_to_int): Make space_identifier
7614         const.
7615         (lookup_template_type): Make name const.
7616         * c-exp.y: Update rules.
7617         (lex_one_token, classify_name, classify_inner_name)
7618         (c_print_token): Update.
7619         * p-exp.y: Update rules.
7620         (yylex): Update.
7621         * f-exp.y: Update rules.
7622         (yylex): Update.
7623         * d-exp.y: Update rules.
7624         (lex_one_token, classify_name, classify_inner_name): Update.
7625         * parse.c (write_dollar_variable, copy_name): Return std::string.
7626         * parser-defs.h (copy_name): Change return type.
7627         * m2-exp.y: Update rules.
7628         (yylex): Update.
7629         * go-exp.y (lex_one_token): Update.
7630         Update rules.
7631         (classify_unsafe_function, classify_packaged_name)
7632         (classify_name, yylex): Update.
7633
7634 2019-04-19  Sergei Trofimovich <siarheit@google.com>
7635
7636         * configure.ac: add --enable-source-highlight switch.
7637         * configure: Regenerate.
7638         * top.c (print_gdb_version): plumb --enable-source-highlight
7639         status to "show configuration".
7640
7641 2019-04-19  Tom Tromey  <tromey@adacore.com>
7642
7643         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
7644         Check ADA_TYPE_P.
7645         (empty_record, ada_template_to_fixed_record_type_1)
7646         (template_to_static_fixed_type)
7647         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
7648         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
7649         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
7650         macros.
7651
7652 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
7653
7654         PR symtab/24423:
7655         * source.c (print_source_lines_base): Advance "iter" when a
7656         control character is seen.
7657
7658 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7659
7660         * inferior.h (struct infcall_suspend_state_deleter):
7661         Catch exception in destructor to avoid crash.
7662
7663 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7664
7665         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
7666         close to the add_com "shell".
7667
7668 2019-04-18  Tom Tromey  <tromey@adacore.com>
7669
7670         * process-stratum-target.h (class process_stratum_target)
7671         <stratum>: Add "final".
7672
7673 2019-04-17  Tom Tromey  <tromey@adacore.com>
7674
7675         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
7676         against nullptr before use.
7677
7678 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
7679
7680         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
7681
7682 2019-04-17  Jim Wilson  <jimw@sifive.com>
7683             Andrew Burgess  <andrew.burgess@embecosm.com>
7684
7685         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
7686         code read might fail, assume 4-byte breakpoint in that case.
7687
7688 2019-04-15  Leszek Swirski  <leszeks@google.com>
7689
7690         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
7691         rather than a hand-rolled POD check when checking for forced MEMORY
7692         classification.
7693
7694 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7695
7696         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
7697         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
7698         function.
7699         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
7700         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
7701         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
7702         declaration.
7703
7704 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7705
7706         * aarch64-linux-nat.c
7707         (aarch64_linux_nat_target::thread_architecture): Add override.
7708         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
7709         each VQ.
7710
7711 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7712
7713         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
7714
7715 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
7716
7717         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
7718         target types of size 96-bits, add some additional comments, and
7719         check that the builtin type we found was the correct size.
7720
7721 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
7722
7723         * utils.c (prompt_for_continue): Don't restore the styling at the
7724         end, as applied_style has the wrong value.  This fixes styling in
7725         long lists of file names that are interrupted by the "Continue?"
7726         prompt.
7727
7728 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7729
7730         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
7731         * c-lang.c (c_language_defn): Likewise.
7732         (cplus_language_defn): Likewise.
7733         (asm_language_defn): Likewise.
7734         (minimal_language_defn): Likewise.
7735         * d-lang.c (d_language_defn): Likewise.
7736         * f-lang.c (f_language_defn): Likewise.
7737         * go-lang.c (go_language_defn): Likewise.
7738         * language.c (unknown_language_defn): Likewise.
7739         (auto_language_defn): Likewise.
7740         * language.h (struct language_defn): Remove la_magic field.
7741         (LANG_MAGIC): Delete.
7742         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
7743         * objc-lang.c (objc_language_defn): Likewise.
7744         * opencl-lang.c (opencl_language_defn): Likewise.
7745         * p-lang.c (pascal_language_defn): Likewise.
7746         * rust-lang.c (rust_language_defn): Likewise.
7747
7748 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7749
7750         * riscv-tdep.c (riscv_type_align): New function.
7751         (riscv_type_alignment): Delete.
7752         (riscv_arg_location): Use 'type_align'.
7753         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
7754
7755 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7756
7757         * gdbtypes.c (type_align): A struct with no non-static fields also
7758         has alignment of 1.
7759
7760 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7761
7762         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
7763         component to 0.
7764         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
7765         member.
7766         (riscv_struct_info::analyse): New implementation using new
7767         analyse_inner member function.
7768         (riscv_struct_info::field_offset): New member function.
7769         (riscv_struct_info::m_offsets): New member variable.
7770         (riscv_struct_info::analyse_inner): New private member function,
7771         takes the old implementation of riscv_struct_info::analyse but
7772         extended to track field offsets.
7773         (riscv_call_arg_struct): Update the struct folding special cases
7774         to handle cases where empty C++ structs, which are non-zero
7775         length, are found.
7776         (riscv_arg_location): Initialise the length of each location, a
7777         non-zero length now indicates the location is in use.
7778         (riscv_push_dummy_call): Allow for the first location having a
7779         non-zero offset when setting up arguments.
7780         (riscv_return_value): Likewise, but for return values.
7781
7782 2019-04-11  Tom Tromey  <tromey@adacore.com>
7783
7784         * utils.c (internal_vproblem): Make "msg" const.
7785
7786 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
7787
7788         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
7789         * trad-frame.c (trad_frame_reset_saved_regs): New function.
7790         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
7791         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
7792
7793 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
7794
7795         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
7796         function.
7797         (fill_gregset): Call amd64_linux_collect_native_gregset instead
7798         of amd64_collect_native_gregset.
7799         (amd64_linux_nat_target::store_registers): Likewise.
7800
7801 2019-04-10  Tom Tromey  <tom@tromey.com>
7802
7803         * symtab.c (lookup_global_symbol_from_objfile)
7804         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
7805         * objfiles.h (class separate_debug_iterator): New.
7806         (class separate_debug_range): New.
7807         (struct objfile) <separate_debug_objfiles>: New method.
7808         (objfile_separate_debug_iterate): Don't declare.
7809         * objfiles.c (separate_debug_iterator::operator++): Rename from
7810         objfile_separate_debug_iterate.
7811         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
7812         iterator.
7813         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
7814         iterator.
7815
7816 2019-04-10  Tom Tromey  <tom@tromey.com>
7817
7818         * symfile.c (reread_symbols): Remove old comment.
7819         * objfiles.c (free_all_objfiles): Fix a typo.
7820
7821 2019-04-10  Tom Tromey  <tom@tromey.com>
7822
7823         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
7824         * minsyms.c (lookup_minimal_symbol): Use foreach.
7825         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
7826         (lookup_minimal_symbol_solib_trampoline): Likewise.
7827         * symfile.c (reread_symbols): Use foreach.
7828
7829 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
7830             Tom Tromey  <tromey@adacore.com>
7831
7832         PR rust/24414:
7833         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
7834         (rust_lex_int_test): Change "value" to be LONGEST.
7835         (rust_lex_tests): Add test for long integer literal.
7836
7837 2019-04-09  Tom Tromey  <tromey@adacore.com>
7838
7839         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
7840         to bool.
7841         (extended_remote_target::attach): Update.
7842         (remote_target::remote_notice_new_inferior): Update.
7843         (remote_target::add_current_inferior_and_thread): Update.
7844         * inferior.c (exit_inferior_1): Use "false".
7845         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
7846
7847 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
7848
7849         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
7850         the "start" command.
7851
7852 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7853
7854         * python/py-inferior.c (infpy_thread_from_thread_handle):
7855         Adjust comments to reflect renaming of thread_from_thread_handle
7856         to thread_from_handle.  Adjust keywords.  Fix type error message.
7857         (inferior_object_methods): Add thread_from_handle.  Retain
7858         thread_from_thread_handle, but mark it as deprecated.
7859
7860 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7861
7862         * gdbthread.h (find_thread_by_handle): Revise declaration.
7863         * thread.c (find_thread_by_handle): Likewise.  Adjust
7864         implementation too.
7865         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
7866         support for buffer objects as handles.
7867
7868 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7869
7870         * python/py-infthread.c (thpy_thread_handle): New function.
7871         (thread_object_methods): Register thpy_thread_handle.
7872
7873 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7874
7875         * gdbthread.h (thread_to_thread_handle): Declare.
7876         * thread.c (gdbtypes.h): Include.
7877         (thread_to_thread_handle): New function.
7878
7879         * target.h (struct target_ops): Add thread_info_to_thread_handle.
7880         (target_thread_info_to_thread_handle): Declare.
7881         * target.c (target_thread_info_to_thread_handle): New function.
7882         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
7883         * target-delegates.c: Regenerate.
7884
7885         * linux-thread-db.c (class thread_db_target): Add method
7886         thread_info_to_thread_handle.
7887         (thread_db_target::thread_info_to_thread_handle): Define.
7888         * remote.c (class remote_target): Add new method
7889         thread_info_to_thread_handle.
7890         (remote_target::thread_info_to_thread_handle): Define.
7891
7892 2019-04-08  Pedro Alves  <palves@redhat.com>
7893
7894         * common/common-exceptions.c (throw_exception): Don't create
7895         named object to throw; throw directly.
7896         (throw_it): Likewise.  Don't initialize gdb_exception::message
7897         here, with new; pass FMT and AP to the ctor instead.
7898         * common/common-exceptions.h: Include <string>.
7899         (gdb_exception::gdb_exception(enum return_reason, enum errors,
7900         const char *, va_list)): New ctor.  Use std::make_shared.
7901         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
7902         errors)): Delete.
7903         (gdb_exception_error::gdb_exception_error(enum errors, const char
7904         *, va_list)): New.
7905         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
7906         Add assertion.
7907         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
7908         errors)): Delete.
7909         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
7910         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
7911         Add assertion.
7912
7913 2019-04-08  Tom Tromey  <tom@tromey.com>
7914
7915         * valops.c (value_rtti_indirect_type): Replace throw_exception
7916         with throw.
7917         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
7918         with throw.
7919         * thread.c (thr_try_catch_cmd): Replace throw_exception with
7920         throw.
7921         * target.c (target_translate_tls_address): Replace throw_exception
7922         with throw.
7923         * stack.c (frame_apply_command_count): Replace throw_exception
7924         with throw.
7925         * solib-spu.c (append_ocl_sos): Replace throw_exception with
7926         throw.
7927         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
7928         with throw.
7929         * rs6000-tdep.c (rs6000_frame_cache)
7930         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
7931         * remote.c: Replace throw_exception with throw.
7932         * record-full.c (record_full_message, record_full_wait_1)
7933         (record_full_restore): Replace throw_exception with throw.
7934         * record-btrace.c:
7935         (get_thread_current_frame_id, record_btrace_start_replaying)
7936         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
7937         (cmd_record_btrace_start): Replace throw_exception with throw.
7938         * parse.c (parse_exp_in_context_1): Replace throw_exception with
7939         throw.
7940         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
7941         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
7942         * linespec.c:
7943         (find_linespec_symbols): Replace throw_exception with throw.
7944         * infrun.c (displaced_step_prepare, resume): Replace
7945         throw_exception with throw.
7946         * infcmd.c (post_create_inferior): Replace throw_exception with
7947         throw.
7948         * inf-loop.c (inferior_event_handler): Replace throw_exception
7949         with throw.
7950         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
7951         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
7952         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
7953         (get_prev_frame_always, get_frame_pc_if_available)
7954         (get_frame_address_in_block_if_available, get_frame_language):
7955         Replace throw_exception with throw.
7956         * frame-unwind.c (frame_unwind_try_unwinder): Replace
7957         throw_exception with throw.
7958         * eval.c (fetch_subexp_value, evaluate_var_value)
7959         (evaluate_funcall, evaluate_subexp_standard): Replace
7960         throw_exception with throw.
7961         * dwarf2loc.c (call_site_find_chain)
7962         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
7963         Replace throw_exception with throw.
7964         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
7965         with throw.
7966         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
7967         throw.
7968         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
7969         * completer.c (complete_line_internal): Replace throw_exception
7970         with throw.
7971         * compile/compile-object-run.c (compile_object_run): Replace
7972         throw_exception with throw.
7973         * cli/cli-script.c (process_next_line): Replace throw_exception
7974         with throw.
7975         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
7976         (btrace_enable, btrace_maint_update_pt_packets): Replace
7977         throw_exception with throw.
7978         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
7979         throw_exception with throw.
7980         * break-catch-throw.c (re_set_exception_catchpoint): Replace
7981         throw_exception with throw.
7982         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
7983         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
7984         * aarch64-tdep.c (aarch64_make_prologue_cache)
7985         (aarch64_make_stub_cache): Replace throw_exception with throw.
7986
7987 2019-04-08  Tom Tromey  <tom@tromey.com>
7988
7989         * common/common-exceptions.c (throw_exception): Rename from
7990         throw_exception_cxx.  Remove old copy.  Make argument const.
7991         (throw_it): Create and throw exception objects directly.
7992         * common/common-exceptions.h (throw_exception): Make argument
7993         const.
7994         (struct gdb_exception_error): Add constructor.
7995         (struct gdb_exception_quit): Add constructor.
7996
7997 2019-04-08  Tom Tromey  <tom@tromey.com>
7998
7999         * common/common-exceptions.h (exception_rethrow): Don't declare.
8000         (TRY_SJLJ): Update comment.
8001         (TRY, CATCH, END_CATCH): Remove.
8002         * common/common-exceptions.c (exception_rethrow): Remove.
8003
8004 2019-04-08  Tom Tromey  <tom@tromey.com>
8005
8006         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
8007         Remove.
8008         (gdb_exception_error): Rename from
8009         gdb_exception_RETURN_MASK_ERROR.
8010         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
8011         (gdb_quit_bad_alloc): Update.
8012         * aarch64-tdep.c: Update.
8013         * ada-lang.c: Update.
8014         * ada-typeprint.c: Update.
8015         * ada-valprint.c: Update.
8016         * amd64-tdep.c: Update.
8017         * arch-utils.c: Update.
8018         * break-catch-throw.c: Update.
8019         * breakpoint.c: Update.
8020         * btrace.c: Update.
8021         * c-varobj.c: Update.
8022         * cli/cli-cmds.c: Update.
8023         * cli/cli-interp.c: Update.
8024         * cli/cli-script.c: Update.
8025         * common/common-exceptions.c: Update.
8026         * common/new-op.c: Update.
8027         * common/selftest.c: Update.
8028         * compile/compile-c-symbols.c: Update.
8029         * compile/compile-cplus-symbols.c: Update.
8030         * compile/compile-object-load.c: Update.
8031         * compile/compile-object-run.c: Update.
8032         * completer.c: Update.
8033         * corelow.c: Update.
8034         * cp-abi.c: Update.
8035         * cp-support.c: Update.
8036         * cp-valprint.c: Update.
8037         * darwin-nat.c: Update.
8038         * disasm-selftests.c: Update.
8039         * dtrace-probe.c: Update.
8040         * dwarf-index-cache.c: Update.
8041         * dwarf-index-write.c: Update.
8042         * dwarf2-frame-tailcall.c: Update.
8043         * dwarf2-frame.c: Update.
8044         * dwarf2loc.c: Update.
8045         * dwarf2read.c: Update.
8046         * eval.c: Update.
8047         * event-loop.c: Update.
8048         * event-top.c: Update.
8049         * exec.c: Update.
8050         * f-valprint.c: Update.
8051         * fbsd-tdep.c: Update.
8052         * frame-unwind.c: Update.
8053         * frame.c: Update.
8054         * gdbtypes.c: Update.
8055         * gnu-v3-abi.c: Update.
8056         * guile/guile-internal.h: Update.
8057         * guile/scm-block.c: Update.
8058         * guile/scm-breakpoint.c: Update.
8059         * guile/scm-cmd.c: Update.
8060         * guile/scm-disasm.c: Update.
8061         * guile/scm-frame.c: Update.
8062         * guile/scm-lazy-string.c: Update.
8063         * guile/scm-math.c: Update.
8064         * guile/scm-param.c: Update.
8065         * guile/scm-ports.c: Update.
8066         * guile/scm-pretty-print.c: Update.
8067         * guile/scm-symbol.c: Update.
8068         * guile/scm-symtab.c: Update.
8069         * guile/scm-type.c: Update.
8070         * guile/scm-value.c: Update.
8071         * i386-linux-tdep.c: Update.
8072         * i386-tdep.c: Update.
8073         * inf-loop.c: Update.
8074         * infcall.c: Update.
8075         * infcmd.c: Update.
8076         * infrun.c: Update.
8077         * jit.c: Update.
8078         * language.c: Update.
8079         * linespec.c: Update.
8080         * linux-fork.c: Update.
8081         * linux-nat.c: Update.
8082         * linux-tdep.c: Update.
8083         * linux-thread-db.c: Update.
8084         * main.c: Update.
8085         * mi/mi-cmd-break.c: Update.
8086         * mi/mi-cmd-stack.c: Update.
8087         * mi/mi-interp.c: Update.
8088         * mi/mi-main.c: Update.
8089         * objc-lang.c: Update.
8090         * p-valprint.c: Update.
8091         * parse.c: Update.
8092         * ppc-linux-tdep.c: Update.
8093         * printcmd.c: Update.
8094         * python/py-arch.c: Update.
8095         * python/py-breakpoint.c: Update.
8096         * python/py-cmd.c: Update.
8097         * python/py-finishbreakpoint.c: Update.
8098         * python/py-frame.c: Update.
8099         * python/py-framefilter.c: Update.
8100         * python/py-gdb-readline.c: Update.
8101         * python/py-inferior.c: Update.
8102         * python/py-infthread.c: Update.
8103         * python/py-lazy-string.c: Update.
8104         * python/py-linetable.c: Update.
8105         * python/py-objfile.c: Update.
8106         * python/py-param.c: Update.
8107         * python/py-prettyprint.c: Update.
8108         * python/py-progspace.c: Update.
8109         * python/py-record-btrace.c: Update.
8110         * python/py-record.c: Update.
8111         * python/py-symbol.c: Update.
8112         * python/py-type.c: Update.
8113         * python/py-unwind.c: Update.
8114         * python/py-utils.c: Update.
8115         * python/py-value.c: Update.
8116         * python/python.c: Update.
8117         * record-btrace.c: Update.
8118         * record-full.c: Update.
8119         * remote-fileio.c: Update.
8120         * remote.c: Update.
8121         * riscv-tdep.c: Update.
8122         * rs6000-aix-tdep.c: Update.
8123         * rs6000-tdep.c: Update.
8124         * rust-exp.y: Update.
8125         * rust-lang.c: Update.
8126         * s390-tdep.c: Update.
8127         * selftest-arch.c: Update.
8128         * solib-dsbt.c: Update.
8129         * solib-frv.c: Update.
8130         * solib-spu.c: Update.
8131         * solib-svr4.c: Update.
8132         * solib.c: Update.
8133         * sparc64-linux-tdep.c: Update.
8134         * stack.c: Update.
8135         * symfile-mem.c: Update.
8136         * symmisc.c: Update.
8137         * target.c: Update.
8138         * thread.c: Update.
8139         * top.c: Update.
8140         * tracefile-tfile.c: Update.
8141         * tui/tui.c: Update.
8142         * typeprint.c: Update.
8143         * unittests/cli-utils-selftests.c: Update.
8144         * unittests/parse-connection-spec-selftests.c: Update.
8145         * valops.c: Update.
8146         * valprint.c: Update.
8147         * value.c: Update.
8148         * varobj.c: Update.
8149         * windows-nat.c: Update.
8150         * x86-linux-nat.c: Update.
8151         * xml-support.c: Update.
8152
8153 2019-04-08  Tom Tromey  <tom@tromey.com>
8154
8155         * xml-support.c: Use C++ exception handling.
8156         * x86-linux-nat.c: Use C++ exception handling.
8157         * windows-nat.c: Use C++ exception handling.
8158         * varobj.c: Use C++ exception handling.
8159         * value.c: Use C++ exception handling.
8160         * valprint.c: Use C++ exception handling.
8161         * valops.c: Use C++ exception handling.
8162         * unittests/parse-connection-spec-selftests.c: Use C++ exception
8163         handling.
8164         * unittests/cli-utils-selftests.c: Use C++ exception handling.
8165         * typeprint.c: Use C++ exception handling.
8166         * tui/tui.c: Use C++ exception handling.
8167         * tracefile-tfile.c: Use C++ exception handling.
8168         * top.c: Use C++ exception handling.
8169         * thread.c: Use C++ exception handling.
8170         * target.c: Use C++ exception handling.
8171         * symmisc.c: Use C++ exception handling.
8172         * symfile-mem.c: Use C++ exception handling.
8173         * stack.c: Use C++ exception handling.
8174         * sparc64-linux-tdep.c: Use C++ exception handling.
8175         * solib.c: Use C++ exception handling.
8176         * solib-svr4.c: Use C++ exception handling.
8177         * solib-spu.c: Use C++ exception handling.
8178         * solib-frv.c: Use C++ exception handling.
8179         * solib-dsbt.c: Use C++ exception handling.
8180         * selftest-arch.c: Use C++ exception handling.
8181         * s390-tdep.c: Use C++ exception handling.
8182         * rust-lang.c: Use C++ exception handling.
8183         * rust-exp.y: Use C++ exception handling.
8184         * rs6000-tdep.c: Use C++ exception handling.
8185         * rs6000-aix-tdep.c: Use C++ exception handling.
8186         * riscv-tdep.c: Use C++ exception handling.
8187         * remote.c: Use C++ exception handling.
8188         * remote-fileio.c: Use C++ exception handling.
8189         * record-full.c: Use C++ exception handling.
8190         * record-btrace.c: Use C++ exception handling.
8191         * python/python.c: Use C++ exception handling.
8192         * python/py-value.c: Use C++ exception handling.
8193         * python/py-utils.c: Use C++ exception handling.
8194         * python/py-unwind.c: Use C++ exception handling.
8195         * python/py-type.c: Use C++ exception handling.
8196         * python/py-symbol.c: Use C++ exception handling.
8197         * python/py-record.c: Use C++ exception handling.
8198         * python/py-record-btrace.c: Use C++ exception handling.
8199         * python/py-progspace.c: Use C++ exception handling.
8200         * python/py-prettyprint.c: Use C++ exception handling.
8201         * python/py-param.c: Use C++ exception handling.
8202         * python/py-objfile.c: Use C++ exception handling.
8203         * python/py-linetable.c: Use C++ exception handling.
8204         * python/py-lazy-string.c: Use C++ exception handling.
8205         * python/py-infthread.c: Use C++ exception handling.
8206         * python/py-inferior.c: Use C++ exception handling.
8207         * python/py-gdb-readline.c: Use C++ exception handling.
8208         * python/py-framefilter.c: Use C++ exception handling.
8209         * python/py-frame.c: Use C++ exception handling.
8210         * python/py-finishbreakpoint.c: Use C++ exception handling.
8211         * python/py-cmd.c: Use C++ exception handling.
8212         * python/py-breakpoint.c: Use C++ exception handling.
8213         * python/py-arch.c: Use C++ exception handling.
8214         * printcmd.c: Use C++ exception handling.
8215         * ppc-linux-tdep.c: Use C++ exception handling.
8216         * parse.c: Use C++ exception handling.
8217         * p-valprint.c: Use C++ exception handling.
8218         * objc-lang.c: Use C++ exception handling.
8219         * mi/mi-main.c: Use C++ exception handling.
8220         * mi/mi-interp.c: Use C++ exception handling.
8221         * mi/mi-cmd-stack.c: Use C++ exception handling.
8222         * mi/mi-cmd-break.c: Use C++ exception handling.
8223         * main.c: Use C++ exception handling.
8224         * linux-thread-db.c: Use C++ exception handling.
8225         * linux-tdep.c: Use C++ exception handling.
8226         * linux-nat.c: Use C++ exception handling.
8227         * linux-fork.c: Use C++ exception handling.
8228         * linespec.c: Use C++ exception handling.
8229         * language.c: Use C++ exception handling.
8230         * jit.c: Use C++ exception handling.
8231         * infrun.c: Use C++ exception handling.
8232         * infcmd.c: Use C++ exception handling.
8233         * infcall.c: Use C++ exception handling.
8234         * inf-loop.c: Use C++ exception handling.
8235         * i386-tdep.c: Use C++ exception handling.
8236         * i386-linux-tdep.c: Use C++ exception handling.
8237         * guile/scm-value.c: Use C++ exception handling.
8238         * guile/scm-type.c: Use C++ exception handling.
8239         * guile/scm-symtab.c: Use C++ exception handling.
8240         * guile/scm-symbol.c: Use C++ exception handling.
8241         * guile/scm-pretty-print.c: Use C++ exception handling.
8242         * guile/scm-ports.c: Use C++ exception handling.
8243         * guile/scm-param.c: Use C++ exception handling.
8244         * guile/scm-math.c: Use C++ exception handling.
8245         * guile/scm-lazy-string.c: Use C++ exception handling.
8246         * guile/scm-frame.c: Use C++ exception handling.
8247         * guile/scm-disasm.c: Use C++ exception handling.
8248         * guile/scm-cmd.c: Use C++ exception handling.
8249         * guile/scm-breakpoint.c: Use C++ exception handling.
8250         * guile/scm-block.c: Use C++ exception handling.
8251         * guile/guile-internal.h: Use C++ exception handling.
8252         * gnu-v3-abi.c: Use C++ exception handling.
8253         * gdbtypes.c: Use C++ exception handling.
8254         * frame.c: Use C++ exception handling.
8255         * frame-unwind.c: Use C++ exception handling.
8256         * fbsd-tdep.c: Use C++ exception handling.
8257         * f-valprint.c: Use C++ exception handling.
8258         * exec.c: Use C++ exception handling.
8259         * event-top.c: Use C++ exception handling.
8260         * event-loop.c: Use C++ exception handling.
8261         * eval.c: Use C++ exception handling.
8262         * dwarf2read.c: Use C++ exception handling.
8263         * dwarf2loc.c: Use C++ exception handling.
8264         * dwarf2-frame.c: Use C++ exception handling.
8265         * dwarf2-frame-tailcall.c: Use C++ exception handling.
8266         * dwarf-index-write.c: Use C++ exception handling.
8267         * dwarf-index-cache.c: Use C++ exception handling.
8268         * dtrace-probe.c: Use C++ exception handling.
8269         * disasm-selftests.c: Use C++ exception handling.
8270         * darwin-nat.c: Use C++ exception handling.
8271         * cp-valprint.c: Use C++ exception handling.
8272         * cp-support.c: Use C++ exception handling.
8273         * cp-abi.c: Use C++ exception handling.
8274         * corelow.c: Use C++ exception handling.
8275         * completer.c: Use C++ exception handling.
8276         * compile/compile-object-run.c: Use C++ exception handling.
8277         * compile/compile-object-load.c: Use C++ exception handling.
8278         * compile/compile-cplus-symbols.c: Use C++ exception handling.
8279         * compile/compile-c-symbols.c: Use C++ exception handling.
8280         * common/selftest.c: Use C++ exception handling.
8281         * common/new-op.c: Use C++ exception handling.
8282         * cli/cli-script.c: Use C++ exception handling.
8283         * cli/cli-interp.c: Use C++ exception handling.
8284         * cli/cli-cmds.c: Use C++ exception handling.
8285         * c-varobj.c: Use C++ exception handling.
8286         * btrace.c: Use C++ exception handling.
8287         * breakpoint.c: Use C++ exception handling.
8288         * break-catch-throw.c: Use C++ exception handling.
8289         * arch-utils.c: Use C++ exception handling.
8290         * amd64-tdep.c: Use C++ exception handling.
8291         * ada-valprint.c: Use C++ exception handling.
8292         * ada-typeprint.c: Use C++ exception handling.
8293         * ada-lang.c: Use C++ exception handling.
8294         * aarch64-tdep.c: Use C++ exception handling.
8295
8296 2019-04-08  Tom Tromey  <tom@tromey.com>
8297
8298         * xml-support.c (gdb_xml_parser::parse): Update.
8299         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8300         * value.c (show_convenience): Update.
8301         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
8302         (test_parse_flags_qcs): Update.
8303         * thread.c (thr_try_catch_cmd): Update.
8304         * target.c (target_translate_tls_address): Update.
8305         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
8306         (info_frame_command_core, frame_apply_command_count): Update.
8307         * rust-exp.y (rust_lex_exception_test): Update.
8308         * riscv-tdep.c (riscv_print_one_register_info): Update.
8309         * remote.c (remote_target::enable_btrace): Update.
8310         * record-btrace.c (record_btrace_enable_warn): Update.
8311         * python/py-utils.c (gdbpy_convert_exception): Update.
8312         * printcmd.c (do_one_display, print_variable_and_value): Update.
8313         * mi/mi-main.c (mi_print_exception): Update.
8314         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
8315         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
8316         * linux-nat.c (linux_nat_target::attach): Update.
8317         * linux-fork.c (class scoped_switch_fork_info): Update.
8318         * infrun.c (displaced_step_prepare): Update.
8319         * infcall.c (call_function_by_hand_dummy): Update.
8320         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
8321         * gnu-v3-abi.c (print_one_vtable): Update.
8322         * frame.c (get_prev_frame_always): Update.
8323         * f-valprint.c (info_common_command_for_block): Update.
8324         * exec.c (try_open_exec_file): Update.
8325         * exceptions.c (print_exception, exception_print)
8326         (exception_fprintf, exception_print_same): Update.
8327         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
8328         * dwarf-index-cache.c (index_cache::store)
8329         (index_cache::lookup_gdb_index): Update.
8330         * darwin-nat.c (maybe_cache_shell): Update.
8331         * cp-valprint.c (cp_print_value_fields): Update.
8332         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
8333         (gcc_cplus_symbol_address): Update.
8334         * compile/compile-c-symbols.c (gcc_convert_symbol)
8335         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
8336         * common/selftest.c: Update.
8337         * common/common-exceptions.h (struct gdb_exception) <message>: Now
8338         a std::string.
8339         (exception_try_scope_entry, exception_try_scope_exit): Don't
8340         declare.
8341         (struct exception_try_scope): Remove.
8342         (TRY): Don't use exception_try_scope.
8343         (struct gdb_exception): Add constructor, operator=.
8344         <what>: New method.
8345         (struct gdb_exception_RETURN_MASK_ALL)
8346         (struct gdb_exception_RETURN_MASK_ERROR)
8347         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
8348         (struct gdb_quit_bad_alloc): Update.
8349         * common/common-exceptions.c (exception_none): Change
8350         initializer.
8351         (struct catcher) <state, exception>: Initialize inline.
8352         <prev>: Remove member.
8353         (current_catcher): Remove.
8354         (catchers): New global.
8355         (exceptions_state_mc_init): Simplify.
8356         (catcher_pop): Remove.
8357         (exceptions_state_mc, exceptions_state_mc_catch): Update.
8358         (try_scope_depth, exception_try_scope_entry)
8359         (exception_try_scope_exit): Remove.
8360         (throw_exception_sjlj): Update.
8361         (exception_messages, exception_messages_size): Remove.
8362         (throw_it): Simplify.
8363         (gdb_exception_sliced_copy): Remove.
8364         (throw_exception_cxx): Update.
8365         * cli/cli-script.c (script_from_file): Update.
8366         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
8367         Update.
8368         * ada-valprint.c (ada_val_print): Update.
8369         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
8370         (create_excep_cond_exprs): Update.
8371
8372 2019-04-08  Tom Tromey  <tom@tromey.com>
8373
8374         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
8375         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
8376         (TRY, CATCH, END_CATCH): Remove some definitions.
8377         * common/common-exceptions.c: Don't use GDB_XCPT.
8378         (catcher_list_size): Remove.
8379         (throw_exception, throw_it): Simplify.
8380
8381 2019-04-05  Tom Tromey  <tom@tromey.com>
8382
8383         Revert the header-sorting patch.
8384         * ft32-tdep.c: Revert.
8385         * frv-tdep.c: Revert.
8386         * frv-linux-tdep.c: Revert.
8387         * frame.c: Revert.
8388         * frame-unwind.c: Revert.
8389         * frame-base.c: Revert.
8390         * fork-child.c: Revert.
8391         * findvar.c: Revert.
8392         * findcmd.c: Revert.
8393         * filesystem.c: Revert.
8394         * filename-seen-cache.h: Revert.
8395         * filename-seen-cache.c: Revert.
8396         * fbsd-tdep.c: Revert.
8397         * fbsd-nat.h: Revert.
8398         * fbsd-nat.c: Revert.
8399         * f-valprint.c: Revert.
8400         * f-typeprint.c: Revert.
8401         * f-lang.c: Revert.
8402         * extension.h: Revert.
8403         * extension.c: Revert.
8404         * extension-priv.h: Revert.
8405         * expprint.c: Revert.
8406         * exec.h: Revert.
8407         * exec.c: Revert.
8408         * exceptions.c: Revert.
8409         * event-top.c: Revert.
8410         * event-loop.c: Revert.
8411         * eval.c: Revert.
8412         * elfread.c: Revert.
8413         * dwarf2read.h: Revert.
8414         * dwarf2read.c: Revert.
8415         * dwarf2loc.c: Revert.
8416         * dwarf2expr.h: Revert.
8417         * dwarf2expr.c: Revert.
8418         * dwarf2-frame.c: Revert.
8419         * dwarf2-frame-tailcall.c: Revert.
8420         * dwarf-index-write.h: Revert.
8421         * dwarf-index-write.c: Revert.
8422         * dwarf-index-common.c: Revert.
8423         * dwarf-index-cache.h: Revert.
8424         * dwarf-index-cache.c: Revert.
8425         * dummy-frame.c: Revert.
8426         * dtrace-probe.c: Revert.
8427         * disasm.h: Revert.
8428         * disasm.c: Revert.
8429         * disasm-selftests.c: Revert.
8430         * dictionary.c: Revert.
8431         * dicos-tdep.c: Revert.
8432         * demangle.c: Revert.
8433         * dcache.h: Revert.
8434         * dcache.c: Revert.
8435         * darwin-nat.h: Revert.
8436         * darwin-nat.c: Revert.
8437         * darwin-nat-info.c: Revert.
8438         * d-valprint.c: Revert.
8439         * d-namespace.c: Revert.
8440         * d-lang.c: Revert.
8441         * ctf.c: Revert.
8442         * csky-tdep.c: Revert.
8443         * csky-linux-tdep.c: Revert.
8444         * cris-tdep.c: Revert.
8445         * cris-linux-tdep.c: Revert.
8446         * cp-valprint.c: Revert.
8447         * cp-support.c: Revert.
8448         * cp-namespace.c: Revert.
8449         * cp-abi.c: Revert.
8450         * corelow.c: Revert.
8451         * corefile.c: Revert.
8452         * continuations.c: Revert.
8453         * completer.h: Revert.
8454         * completer.c: Revert.
8455         * complaints.c: Revert.
8456         * coffread.c: Revert.
8457         * coff-pe-read.c: Revert.
8458         * cli-out.h: Revert.
8459         * cli-out.c: Revert.
8460         * charset.c: Revert.
8461         * c-varobj.c: Revert.
8462         * c-valprint.c: Revert.
8463         * c-typeprint.c: Revert.
8464         * c-lang.c: Revert.
8465         * buildsym.c: Revert.
8466         * buildsym-legacy.c: Revert.
8467         * build-id.h: Revert.
8468         * build-id.c: Revert.
8469         * btrace.c: Revert.
8470         * bsd-uthread.c: Revert.
8471         * breakpoint.h: Revert.
8472         * breakpoint.c: Revert.
8473         * break-catch-throw.c: Revert.
8474         * break-catch-syscall.c: Revert.
8475         * break-catch-sig.c: Revert.
8476         * blockframe.c: Revert.
8477         * block.c: Revert.
8478         * bfin-tdep.c: Revert.
8479         * bfin-linux-tdep.c: Revert.
8480         * bfd-target.c: Revert.
8481         * bcache.c: Revert.
8482         * ax-general.c: Revert.
8483         * ax-gdb.h: Revert.
8484         * ax-gdb.c: Revert.
8485         * avr-tdep.c: Revert.
8486         * auxv.c: Revert.
8487         * auto-load.c: Revert.
8488         * arm-wince-tdep.c: Revert.
8489         * arm-tdep.c: Revert.
8490         * arm-symbian-tdep.c: Revert.
8491         * arm-pikeos-tdep.c: Revert.
8492         * arm-obsd-tdep.c: Revert.
8493         * arm-nbsd-tdep.c: Revert.
8494         * arm-nbsd-nat.c: Revert.
8495         * arm-linux-tdep.c: Revert.
8496         * arm-linux-nat.c: Revert.
8497         * arm-fbsd-tdep.c: Revert.
8498         * arm-fbsd-nat.c: Revert.
8499         * arm-bsd-tdep.c: Revert.
8500         * arch-utils.c: Revert.
8501         * arc-tdep.c: Revert.
8502         * arc-newlib-tdep.c: Revert.
8503         * annotate.h: Revert.
8504         * annotate.c: Revert.
8505         * amd64-windows-tdep.c: Revert.
8506         * amd64-windows-nat.c: Revert.
8507         * amd64-tdep.c: Revert.
8508         * amd64-sol2-tdep.c: Revert.
8509         * amd64-obsd-tdep.c: Revert.
8510         * amd64-obsd-nat.c: Revert.
8511         * amd64-nbsd-tdep.c: Revert.
8512         * amd64-nbsd-nat.c: Revert.
8513         * amd64-nat.c: Revert.
8514         * amd64-linux-tdep.c: Revert.
8515         * amd64-linux-nat.c: Revert.
8516         * amd64-fbsd-tdep.c: Revert.
8517         * amd64-fbsd-nat.c: Revert.
8518         * amd64-dicos-tdep.c: Revert.
8519         * amd64-darwin-tdep.c: Revert.
8520         * amd64-bsd-nat.c: Revert.
8521         * alpha-tdep.c: Revert.
8522         * alpha-obsd-tdep.c: Revert.
8523         * alpha-nbsd-tdep.c: Revert.
8524         * alpha-mdebug-tdep.c: Revert.
8525         * alpha-linux-tdep.c: Revert.
8526         * alpha-linux-nat.c: Revert.
8527         * alpha-bsd-tdep.c: Revert.
8528         * alpha-bsd-nat.c: Revert.
8529         * aix-thread.c: Revert.
8530         * agent.c: Revert.
8531         * addrmap.c: Revert.
8532         * ada-varobj.c: Revert.
8533         * ada-valprint.c: Revert.
8534         * ada-typeprint.c: Revert.
8535         * ada-tasks.c: Revert.
8536         * ada-lang.c: Revert.
8537         * aarch64-tdep.c: Revert.
8538         * aarch64-ravenscar-thread.c: Revert.
8539         * aarch64-newlib-tdep.c: Revert.
8540         * aarch64-linux-tdep.c: Revert.
8541         * aarch64-linux-nat.c: Revert.
8542         * aarch64-fbsd-tdep.c: Revert.
8543         * aarch64-fbsd-nat.c: Revert.
8544         * aarch32-linux-nat.c: Revert.
8545
8546 2019-04-05  Tom Tromey  <tom@tromey.com>
8547
8548         * ft32-tdep.c: Sort headers.
8549         * frv-tdep.c: Sort headers.
8550         * frv-linux-tdep.c: Sort headers.
8551         * frame.c: Sort headers.
8552         * frame-unwind.c: Sort headers.
8553         * frame-base.c: Sort headers.
8554         * fork-child.c: Sort headers.
8555         * findvar.c: Sort headers.
8556         * findcmd.c: Sort headers.
8557         * filesystem.c: Sort headers.
8558         * filename-seen-cache.h: Sort headers.
8559         * filename-seen-cache.c: Sort headers.
8560         * fbsd-tdep.c: Sort headers.
8561         * fbsd-nat.h: Sort headers.
8562         * fbsd-nat.c: Sort headers.
8563         * f-valprint.c: Sort headers.
8564         * f-typeprint.c: Sort headers.
8565         * f-lang.c: Sort headers.
8566         * extension.h: Sort headers.
8567         * extension.c: Sort headers.
8568         * extension-priv.h: Sort headers.
8569         * expprint.c: Sort headers.
8570         * exec.h: Sort headers.
8571         * exec.c: Sort headers.
8572         * exceptions.c: Sort headers.
8573         * event-top.c: Sort headers.
8574         * event-loop.c: Sort headers.
8575         * eval.c: Sort headers.
8576         * elfread.c: Sort headers.
8577         * dwarf2read.h: Sort headers.
8578         * dwarf2read.c: Sort headers.
8579         * dwarf2loc.c: Sort headers.
8580         * dwarf2expr.h: Sort headers.
8581         * dwarf2expr.c: Sort headers.
8582         * dwarf2-frame.c: Sort headers.
8583         * dwarf2-frame-tailcall.c: Sort headers.
8584         * dwarf-index-write.h: Sort headers.
8585         * dwarf-index-write.c: Sort headers.
8586         * dwarf-index-common.c: Sort headers.
8587         * dwarf-index-cache.h: Sort headers.
8588         * dwarf-index-cache.c: Sort headers.
8589         * dummy-frame.c: Sort headers.
8590         * dtrace-probe.c: Sort headers.
8591         * disasm.h: Sort headers.
8592         * disasm.c: Sort headers.
8593         * disasm-selftests.c: Sort headers.
8594         * dictionary.c: Sort headers.
8595         * dicos-tdep.c: Sort headers.
8596         * demangle.c: Sort headers.
8597         * dcache.h: Sort headers.
8598         * dcache.c: Sort headers.
8599         * darwin-nat.h: Sort headers.
8600         * darwin-nat.c: Sort headers.
8601         * darwin-nat-info.c: Sort headers.
8602         * d-valprint.c: Sort headers.
8603         * d-namespace.c: Sort headers.
8604         * d-lang.c: Sort headers.
8605         * ctf.c: Sort headers.
8606         * csky-tdep.c: Sort headers.
8607         * csky-linux-tdep.c: Sort headers.
8608         * cris-tdep.c: Sort headers.
8609         * cris-linux-tdep.c: Sort headers.
8610         * cp-valprint.c: Sort headers.
8611         * cp-support.c: Sort headers.
8612         * cp-namespace.c: Sort headers.
8613         * cp-abi.c: Sort headers.
8614         * corelow.c: Sort headers.
8615         * corefile.c: Sort headers.
8616         * continuations.c: Sort headers.
8617         * completer.h: Sort headers.
8618         * completer.c: Sort headers.
8619         * complaints.c: Sort headers.
8620         * coffread.c: Sort headers.
8621         * coff-pe-read.c: Sort headers.
8622         * cli-out.h: Sort headers.
8623         * cli-out.c: Sort headers.
8624         * charset.c: Sort headers.
8625         * c-varobj.c: Sort headers.
8626         * c-valprint.c: Sort headers.
8627         * c-typeprint.c: Sort headers.
8628         * c-lang.c: Sort headers.
8629         * buildsym.c: Sort headers.
8630         * buildsym-legacy.c: Sort headers.
8631         * build-id.h: Sort headers.
8632         * build-id.c: Sort headers.
8633         * btrace.c: Sort headers.
8634         * bsd-uthread.c: Sort headers.
8635         * breakpoint.h: Sort headers.
8636         * breakpoint.c: Sort headers.
8637         * break-catch-throw.c: Sort headers.
8638         * break-catch-syscall.c: Sort headers.
8639         * break-catch-sig.c: Sort headers.
8640         * blockframe.c: Sort headers.
8641         * block.c: Sort headers.
8642         * bfin-tdep.c: Sort headers.
8643         * bfin-linux-tdep.c: Sort headers.
8644         * bfd-target.c: Sort headers.
8645         * bcache.c: Sort headers.
8646         * ax-general.c: Sort headers.
8647         * ax-gdb.h: Sort headers.
8648         * ax-gdb.c: Sort headers.
8649         * avr-tdep.c: Sort headers.
8650         * auxv.c: Sort headers.
8651         * auto-load.c: Sort headers.
8652         * arm-wince-tdep.c: Sort headers.
8653         * arm-tdep.c: Sort headers.
8654         * arm-symbian-tdep.c: Sort headers.
8655         * arm-pikeos-tdep.c: Sort headers.
8656         * arm-obsd-tdep.c: Sort headers.
8657         * arm-nbsd-tdep.c: Sort headers.
8658         * arm-nbsd-nat.c: Sort headers.
8659         * arm-linux-tdep.c: Sort headers.
8660         * arm-linux-nat.c: Sort headers.
8661         * arm-fbsd-tdep.c: Sort headers.
8662         * arm-fbsd-nat.c: Sort headers.
8663         * arm-bsd-tdep.c: Sort headers.
8664         * arch-utils.c: Sort headers.
8665         * arc-tdep.c: Sort headers.
8666         * arc-newlib-tdep.c: Sort headers.
8667         * annotate.h: Sort headers.
8668         * annotate.c: Sort headers.
8669         * amd64-windows-tdep.c: Sort headers.
8670         * amd64-windows-nat.c: Sort headers.
8671         * amd64-tdep.c: Sort headers.
8672         * amd64-sol2-tdep.c: Sort headers.
8673         * amd64-obsd-tdep.c: Sort headers.
8674         * amd64-obsd-nat.c: Sort headers.
8675         * amd64-nbsd-tdep.c: Sort headers.
8676         * amd64-nbsd-nat.c: Sort headers.
8677         * amd64-nat.c: Sort headers.
8678         * amd64-linux-tdep.c: Sort headers.
8679         * amd64-linux-nat.c: Sort headers.
8680         * amd64-fbsd-tdep.c: Sort headers.
8681         * amd64-fbsd-nat.c: Sort headers.
8682         * amd64-dicos-tdep.c: Sort headers.
8683         * amd64-darwin-tdep.c: Sort headers.
8684         * amd64-bsd-nat.c: Sort headers.
8685         * alpha-tdep.c: Sort headers.
8686         * alpha-obsd-tdep.c: Sort headers.
8687         * alpha-nbsd-tdep.c: Sort headers.
8688         * alpha-mdebug-tdep.c: Sort headers.
8689         * alpha-linux-tdep.c: Sort headers.
8690         * alpha-linux-nat.c: Sort headers.
8691         * alpha-bsd-tdep.c: Sort headers.
8692         * alpha-bsd-nat.c: Sort headers.
8693         * aix-thread.c: Sort headers.
8694         * agent.c: Sort headers.
8695         * addrmap.c: Sort headers.
8696         * ada-varobj.c: Sort headers.
8697         * ada-valprint.c: Sort headers.
8698         * ada-typeprint.c: Sort headers.
8699         * ada-tasks.c: Sort headers.
8700         * ada-lang.c: Sort headers.
8701         * aarch64-tdep.c: Sort headers.
8702         * aarch64-ravenscar-thread.c: Sort headers.
8703         * aarch64-newlib-tdep.c: Sort headers.
8704         * aarch64-linux-tdep.c: Sort headers.
8705         * aarch64-linux-nat.c: Sort headers.
8706         * aarch64-fbsd-tdep.c: Sort headers.
8707         * aarch64-fbsd-nat.c: Sort headers.
8708         * aarch32-linux-nat.c: Sort headers.
8709
8710 2019-04-04  Tom Tromey  <tom@tromey.com>
8711
8712         * varobj.c (varobj_create): Update.
8713         * rust-exp.y (struct rust_parser) <update_innermost_block,
8714         lookup_symbol>: New methods.
8715         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
8716         Rename.
8717         (rust_parser::rust_lookup_type)
8718         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8719         * printcmd.c (display_command, do_one_display): Update.
8720         * parser-defs.h (struct parser_state) <parser_state>: Add
8721         "tracker" parameter.
8722         (block_tracker): New member.
8723         (class innermost_block_tracker) <innermost_block_tracker>: Add
8724         "types" parameter.
8725         <reset>: Remove method.
8726         (innermost_block): Don't declare.
8727         (null_post_parser): Update.
8728         * parse.c (innermost_block): Remove global.
8729         (write_dollar_variable): Update.
8730         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
8731         Remove "tracker_types" parameter.
8732         (parse_expression): Add "tracker" parameter.
8733         (parse_expression_for_completion): Update.
8734         (null_post_parser): Add "tracker" parameter.
8735         * p-exp.y: Update rules.
8736         * m2-exp.y: Update rules.
8737         * language.h (struct language_defn) <la_post_parser>: Add
8738         "tracker" parameter.
8739         * go-exp.y: Update rules.
8740         * f-exp.y: Update rules.
8741         * expression.h (parse_expression, parse_exp_1): Add "tracker"
8742         parameter.
8743         * d-exp.y: Update rules.
8744         * c-exp.y: Update rules.
8745         * breakpoint.c (set_breakpoint_condition): Create an
8746         innermost_block_tracker.
8747         (watch_command_1): Likewise.
8748         * ada-lang.c (resolve): Add "tracker" parameter.
8749         (resolve_subexp): Likewise.
8750         * ada-exp.y (write_var_from_sym): Update.
8751
8752 2019-04-04  Tom Tromey  <tom@tromey.com>
8753
8754         * type-stack.h: New file.
8755         * type-stack.c: New file.
8756         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
8757         type-stack.h.
8758         (insert_into_type_stack, insert_type, push_type, push_type_int)
8759         (insert_type_address_space, pop_type, pop_type_int)
8760         (pop_typelist, pop_type_stack, append_type_stack)
8761         (push_type_stack, get_type_stack, push_typelist)
8762         (follow_type_instance_flags, follow_types): Don't declare.
8763         * parse.c (type_stack): Remove global.
8764         (parse_exp_in_context): Update.
8765         (insert_into_type_stack, insert_type, push_type, push_type_int)
8766         (insert_type_address_space, pop_type, pop_type_int)
8767         (pop_typelist, pop_type_stack, append_type_stack)
8768         (push_type_stack, get_type_stack, push_typelist)
8769         (follow_type_instance_flags, follow_types): Remove (moved to
8770         type-stack.c).
8771         * f-exp.y (type_stack): New global.
8772         Update rules.
8773         (push_kind_type, f_parse): Update.
8774         * d-exp.y (type_stack): New global.
8775         Update rules.
8776         (d_parse): Update.
8777         * c-exp.y (struct c_parse_state) <type_stack>: New member.
8778         Update rules.
8779         * Makefile.in (COMMON_SFILES): Add type-stack.c.
8780         (HFILES_NO_SRCDIR): Add type-stack.h.
8781
8782 2019-04-04  Tom Tromey  <tom@tromey.com>
8783
8784         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
8785         (rust_parser::convert_ast_to_expression, rust_parse)
8786         (rust_lex_test_completion, rust_lex_tests): Update.
8787         * parser-defs.h (struct expr_completion_state): New.
8788         (struct parser_state) <parser_state>: Add completion parameter.
8789         <mark_struct_expression, mark_completion_tag>: New methods.
8790         <parse_completion, m_completion_state>: New members.
8791         (prefixify_expression, null_post_parser): Update.
8792         (mark_struct_expression, mark_completion_tag): Don't declare.
8793         * parse.c (parse_completion, expout_last_struct)
8794         (expout_tag_completion_type, expout_completion_name): Remove
8795         globals.
8796         (parser_state::mark_struct_expression)
8797         (parser_state::mark_completion_tag): Now methods.
8798         (prefixify_expression): Add last_struct parameter.
8799         (prefixify_subexp): Likewise.
8800         (parse_exp_1): Update.
8801         (parse_exp_in_context): Add cstate parameter.  Update.
8802         (parse_expression_for_completion): Create an
8803         expr_completion_state.
8804         (null_post_parser): Add "completion" parameter.
8805         * p-exp.y: Update rules.
8806         (yylex): Update.
8807         * language.h (struct language_defn) <la_post_parser>: Add
8808         "completing" parameter.
8809         * go-exp.y: Update rules.
8810         (lex_one_token): Update.
8811         * expression.h (parse_completion): Don't declare.
8812         * d-exp.y: Update rules.
8813         (lex_one_token): Update rules.
8814         * c-exp.y: Update rules.
8815         (lex_one_token): Update.
8816         * ada-lang.c (resolve): Add "parse_completion" parameter.
8817         (resolve_subexp): Likewise.
8818         (ada_resolve_function): Likewise.
8819
8820 2019-04-04  Tom Tromey  <tom@tromey.com>
8821
8822         * parser-defs.h (struct parser_state) <start_arglist,
8823         end_arglist>: New methods.
8824         <arglist_len, m_funcall_chain>: New members.
8825         (arglist_len, start_arglist, end_arglist): Don't declare.
8826         * parse.c (arglist_len, funcall_chain): Remove global.
8827         (start_arglist, end_arglist): Remove functions.
8828         (parse_exp_in_context): Update.
8829         * p-exp.y: Update rules.
8830         * m2-exp.y: Update rules.
8831         * go-exp.y: Update rules.
8832         * f-exp.y: Update rules.
8833         * d-exp.y: Update rules.
8834         * c-exp.y: Update rules.
8835
8836 2019-04-04  Tom Tromey  <tom@tromey.com>
8837
8838         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
8839         lex_operator, push_back>: New methods.
8840         Update all rules.
8841         (rust_parser::lex_hex, lex_escape): Rename and update.
8842         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
8843         (rust_parser::lex_operator): Rename and update.
8844         (rust_parser::lex_number, rustyylex, rustyyerror)
8845         (rust_lex_test_init, rust_lex_test_sequence)
8846         (rust_lex_test_push_back, rust_lex_tests): Update.
8847         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
8848         parameter.
8849         <lexptr, prev_lexptr>: New members.
8850         (lexptr, prev_lexptr): Don't declare.
8851         * parse.c (lexptr, prev_lexptr): Remove globals.
8852         (parse_exp_in_context): Update.
8853         * p-exp.y (yylex, yyerror): Update.
8854         * m2-exp.y (parse_number, yylex, yyerror): Update.
8855         * go-exp.y (lex_one_token, yyerror): Update.
8856         * f-exp.y (match_string_literal, yylex, yyerror): Update.
8857         * d-exp.y (lex_one_token, yyerror): Update.
8858         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
8859         (lex_one_token, yyerror): Update.
8860         * ada-lex.l (YY_INPUT): Update.
8861         (rewind_to_char): Update.
8862         * ada-exp.y (yyerror): Update.
8863
8864 2019-04-04  Tom Tromey  <tom@tromey.com>
8865
8866         * rust-exp.y (rustyylex, rust_lex_tests): Update.
8867         * parser-defs.h (struct parser_state) <parser_state>: Add new
8868         parameter.
8869         <comma_terminates>: New member.
8870         (comma_terminates): Don't declare global.
8871         * parse.c (comma_terminates): Remove global.
8872         (parse_exp_in_context): Update.
8873         * p-exp.y (yylex): Update.
8874         * m2-exp.y (yylex): Update.
8875         * go-exp.y (lex_one_token): Update.
8876         * f-exp.y (yylex): Update.
8877         * d-exp.y (lex_one_token): Update.
8878         * c-exp.y (lex_one_token): Update.
8879         * ada-lex.l: Update.
8880
8881 2019-04-04  Tom Tromey  <tom@tromey.com>
8882
8883         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
8884         (rustyylex, rust_lex_test_init, rust_lex_test_one)
8885         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
8886         * parser-defs.h (paren_depth): Don't declare.
8887         * parse.c (paren_depth): Remove global.
8888         (parse_exp_in_context): Update.
8889         * p-exp.y (paren_depth): New global.
8890         (pascal_parse): Initialize it.
8891         * m2-exp.y (paren_depth): New global.
8892         (m2_parse): Initialize it.
8893         * go-exp.y (paren_depth): New global.
8894         (go_parse): Initialize it.
8895         * f-exp.y (paren_depth): New global.
8896         (f_parse): Initialize it.
8897         * d-exp.y (paren_depth): New global.
8898         (d_parse): Initialize it.
8899         * c-exp.y (paren_depth): New global.
8900         (c_parse): Initialize it.
8901         * ada-lex.l (paren_depth): New global.
8902         (lexer_init): Initialize it.
8903
8904 2019-04-04  Tom Tromey  <tom@tromey.com>
8905
8906         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
8907         (rust_parser::convert_ast_to_type)
8908         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8909         * parser-defs.h (struct parser_state) <parser_state>: Add
8910         parameters.  Initialize new members.
8911         <expression_context_block, expression_context_pc>: New members.
8912         * parse.c (expression_context_block, expression_context_pc):
8913         Remove globals.
8914         (parse_exp_in_context): Update.
8915         * p-exp.y: Update all rules.
8916         (yylex): Update.
8917         * m2-exp.y: Update all rules.
8918         (yylex): Update.
8919         * go-exp.y (yylex): Update.
8920         * f-exp.y (yylex): Update.
8921         * d-exp.y: Update all rules.
8922         (yylex): Update.
8923         * c-exp.y: Update all rules.
8924         (lex_one_token, classify_name, yylex, c_parse): Update.
8925         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
8926
8927 2019-04-04  Tom Tromey  <tom@tromey.com>
8928
8929         * gdbarch.h, gdbarch.c: Rebuild.
8930         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
8931         * stap-probe.h:
8932         (struct stap_parse_info): Replace "parser_state" with
8933         "expr_builder".
8934         * parser-defs.h (struct expr_builder): Rename from "parser_state".
8935         (parser_state): New class.
8936         * parse.c (expr_builder): Rename.
8937         (expr_builder::release): Rename.
8938         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
8939         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
8940         (write_exp_elt_longcst, write_exp_elt_floatcst)
8941         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
8942         (write_exp_string_vector, write_exp_bitstring)
8943         (write_exp_msymbol, mark_struct_expression)
8944         (write_dollar_variable)
8945         (insert_type_address_space, increase_expout_size): Replace
8946         "parser_state" with "expr_builder".
8947         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
8948         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
8949         "parser_state" with "expr_builder".
8950
8951 2019-04-04  Tom Tromey  <tom@tromey.com>
8952
8953         * rust-exp.y: Replace "parse_language" with method call.
8954         * p-exp.y:
8955         (yylex): Replace "parse_language" with method call.
8956         * m2-exp.y:
8957         (yylex): Replace "parse_language" with method call.
8958         * go-exp.y (classify_name): Replace "parse_language" with method
8959         call.
8960         * f-exp.y (yylex): Replace "parse_language" with method call.
8961         * d-exp.y (lex_one_token): Replace "parse_language" with method
8962         call.
8963         * c-exp.y:
8964         (lex_one_token, classify_name, yylex): Replace "parse_language"
8965         with method call.
8966         * ada-exp.y (find_primitive_type, type_char)
8967         (type_system_address): Replace "parse_language" with method call.
8968
8969 2019-04-04  Tom Tromey  <tom@tromey.com>
8970
8971         * rust-exp.y: Replace "parse_gdbarch" with method call.
8972         * parse.c (write_dollar_variable, insert_type_address_space):
8973         Replace "parse_gdbarch" with method call.
8974         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
8975         call.
8976         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
8977         call.
8978         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
8979         "parse_gdbarch" with method call.
8980         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
8981         with method call.
8982         * f-exp.y (parse_type, parse_f_type, yylex): Replace
8983         "parse_gdbarch" with method call.
8984         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
8985         "parse_gdbarch" with method call.
8986         * c-exp.y (parse_type, parse_number, classify_name): Replace
8987         "parse_gdbarch" with method call.
8988         * ada-lex.l: Replace "parse_gdbarch" with method call.
8989         * ada-exp.y (parse_type, find_primitive_type, type_char)
8990         (type_system_address): Replace "parse_gdbarch" with method call.
8991
8992 2019-04-04  Tom Tromey  <tom@tromey.com>
8993
8994         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
8995         * stap-probe.c (stap_parse_argument): Update.
8996         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
8997         initial_size parameter.
8998         * rust-exp.y (rust_lex_tests): Update.
8999         * parse.c (parser_state): Update.
9000         (parse_exp_in_context): Update.
9001         * parser-defs.h (struct parser_state) <parser_state>: Remove
9002         "initial_size" parameter.
9003
9004 2019-04-04  Tom Tromey  <tom@tromey.com>
9005
9006         * parser-defs.h (increase_expout_size): Don't declare.
9007         * parse.c (increase_expout_size): Now static.
9008
9009 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
9010
9011         * gnu-nat.c (gnu_nat_target::wait): Fix
9012         target_waitstatus_to_string call.
9013
9014 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9015
9016         * eval.c (evaluate_subexp_standard): Handle internal functions
9017         during Fortran function call handling.
9018
9019 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9020
9021         * NEWS: Mention new internal functions.
9022         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
9023         (read_base_type): Use dwarf2_init_complex_target_type.
9024         * value.c (creal_internal_fn): New function.
9025         (cimag_internal_fn): New function.
9026         (_initialize_values): Register new internal functions.
9027
9028 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9029
9030         * infrun.c (stop_all_threads): If debug_infrun, always
9031         trace the wait status after wait_one, using
9032         target_waitstatus_to_string and target_pid_to_str.
9033         (handle_inferior_event): Replace various trace of
9034         wait status kind by a single trace.
9035         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
9036         wait status kind image by target_waitstatus_to_string.
9037         * target/waitstatus.c (target_waitstatus_to_string): Fix
9038         obsolete comment.
9039
9040 2019-04-01  Tom Tromey  <tromey@adacore.com>
9041
9042         PR symtab/23331:
9043         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
9044
9045 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
9046             Pedro Alves  <palves@redhat.com>
9047
9048         * top.c (quit_force): Call 'finalize_values'.
9049         * value.c (finalize_values): New function.
9050         * value.h (finalize_values): Declare.
9051
9052 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
9053
9054         * NEWS: Announce $_gdb_major and $_gdb_minor.
9055
9056         * top.c (init_gdb_version_vars): New function.
9057         (gdb_init): Call init_gdb_version_vars.
9058
9059 2019-03-29  Tom Tromey  <tromey@adacore.com>
9060
9061         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
9062         help text.  Remove dead code.
9063
9064 2019-03-29  Keith Seitz  <keiths@redhat.com>
9065
9066         From Siddhesh Poyarekar:
9067         * f-lang.h (f77_get_upperbound): Return LONGEST.
9068         (f77_get_lowerbound): Likewise.
9069         * f-typeprint.c (f_type_print_varspec_suffix): Expand
9070         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
9071         print them.
9072         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
9073         plongest to format print it.
9074         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
9075         (f77_get_upperbound): Likewise.
9076         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
9077         LOWER_BOUND to LONGEST.
9078         (f77_create_arrayprint_offset_tbl): Likewise.
9079
9080 2019-03-29  Keith Seitz  <keiths@redhat.com>
9081
9082         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
9083         %s/pulongest for TYPE_LENGTH instead of %d in format
9084         strings.
9085         * ada-typerint.c (ada_print_type): Likewise.
9086         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
9087         * compile/compile-c-support.c (generate_register_struct): Likewise.
9088         * gdbtypes.c (recursive_dump_type): Likewise.
9089         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
9090         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
9091         instead of %d in format strings.
9092         * riscv-tdep.c (riscv_type_alignment): Cast second argument
9093         to std::min to ULONGEST.
9094         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
9095         instead of %d in format strings.
9096         * tracepoint.c (info_scope_command): Likewise.
9097         * typeprint.c (print_offset_data::update)
9098         (print_offset_data::finish): Likewise.
9099         * xtensa-tdep.c (xtensa_store_return_value)
9100         (xtensa_push_dummy_call): Likewise.
9101
9102 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
9103
9104         * windows-nat.c (display_selector): Fixed format specifications
9105         for 64-bit Cygwin.
9106
9107 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9108
9109         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
9110
9111 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
9112
9113         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
9114         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
9115         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
9116         (nios2_linux_init_abi): Install it.
9117
9118 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9119
9120         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
9121
9122 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9123
9124         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
9125
9126 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9127             Tom Tromey  <tromey@adacore.com>
9128
9129         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
9130
9131 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
9132
9133         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
9134         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
9135         method to compute the bounds of range types. Also print "[evaluated]"
9136         if the bounds' values come from a dynamic evaluation.
9137
9138 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9139
9140         * cp-valprint.c (cp_print_value_fields): Don't print trailing
9141         whitespace when pretty printing is on.
9142
9143 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9144
9145         * ppc-linux-nat.c: Add include.
9146
9147 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9148
9149         * NEWS: Mention AArch64 Pointer Authentication.
9150
9151 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9152
9153         * arm-linux-nat.c: Add include.
9154
9155 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
9156
9157         * source-cache.c (source_cache::get_source_lines): Re-read
9158         fullname after calling open_source_file.
9159
9160 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
9161
9162         * NEWS: Mention TLS support for FreeBSD.
9163
9164 2019-03-25  Tom Tromey  <tromey@adacore.com>
9165
9166         * minsyms.c (BUNCH_SIZE): Update comment.
9167         (~minimal_symbol_reader): Remove old comment.
9168         (compact_minimal_symbols): Update comment.
9169         (minimal_symbol_reader::install): Remove old comment.  Update
9170         other comments.
9171
9172 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9173
9174         * s390-linux-nat.c: Add include.
9175
9176 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9177
9178         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
9179         Call linux_get_hwcap.
9180         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
9181         Likewise.
9182         (aarch64_linux_get_hwcap): Remove function.
9183         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
9184         declaration.
9185         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
9186         linux_get_hwcap.
9187         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
9188         * linux-tdep.c (linux_get_hwcap): Add function.
9189         (linux_get_hwcap2): Likewise.
9190         * linux-tdep.h (linux_get_hwcap): Add declaration.
9191         (linux_get_hwcap2): Likewise.
9192         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
9193         (ppc_linux_get_hwcap2): Likewise.
9194         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
9195         linux_get_hwcap.
9196         (ppc_linux_nat_target::insert_watchpoint): Likewise.
9197         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
9198         (ppc_linux_nat_target::read_description): Likewise.
9199         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
9200         * s390-linux-nat.c: Likewise.
9201         * s390-linux-tdep.c (s390_core_read_description): Likewise.
9202
9203 2019-03-24  Tom Tromey  <tom@tromey.com>
9204
9205         * ada-lang.c (standard_lookup): Simplify initialization.
9206         (ada_lookup_symbol_nonlocal): Simplify return.
9207         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
9208         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
9209         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
9210         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
9211         initialization.
9212         * solib.c (solib_global_lookup): Simplify.
9213         * symtab.c (null_block_symbol): Remove.
9214         (symbol_cache_lookup): Simplify returns.
9215         (lookup_language_this): Simplify returns.
9216         (lookup_symbol_aux): Simplify return.
9217         (lookup_local_symbol): Simplify returns.
9218         (lookup_global_symbol_from_objfile): Simplify return.
9219         (lookup_symbol_in_objfile_symtabs)
9220         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
9221         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
9222         (lookup_static_symbol, lookup_global_symbol): Simplify return.
9223         * cp-namespace.c (cp_lookup_bare_symbol)
9224         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
9225         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
9226         (cp_lookup_nested_symbol): Don't use null_block_symbol.
9227         (cp_lookup_symbol_via_imports): Simplify initialization.
9228         (find_symbol_in_baseclass): Likewise.
9229         * symtab.h (null_block_symbol): Remove.
9230         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
9231         (d_lookup_nested_symbol, d_lookup_symbol_imports)
9232         (d_lookup_symbol_module): Likewise.
9233         (find_symbol_in_baseclass): Simplify initialization.
9234
9235 2019-03-24  Tom Tromey  <tom@tromey.com>
9236
9237         * expression.h: Don't include symtab.h.
9238         (struct block): Forward declare.
9239
9240 2019-03-24  Tom Tromey  <tom@tromey.com>
9241
9242         * c-exp.y (typebase): Remove casts.
9243         * gdbtypes.c (lookup_unsigned_typename, )
9244         (lookup_signed_typename): Remove cast.
9245         * eval.c (parse_to_comma_and_eval): Remove cast.
9246         * parse.c (write_dollar_variable): Remove cast.
9247         * block.h (struct block) <superblock>: Now const.
9248         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
9249         * psymtab.c (psym_map_matching_symbols): Make "block" const.
9250         (map_block): Make "block" const.
9251         * symfile.h (struct quick_symbol_functions)
9252         <map_matching_symbols>: Constify block argument to "callback".
9253         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
9254         const.
9255         (find_pc_sect_compunit_symtab): Make "b" const.
9256         (find_symbol_at_address): Likewise.
9257         (search_symbols): Likewise.
9258         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
9259         (dw2_debug_names_lookup_symbol): Likewise.
9260         (dw2_map_matching_symbols): Update.
9261         * p-valprint.c (pascal_val_print): Remove "block".
9262         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
9263         (aux_add_nonlocal_symbols): Make "block" const.
9264         (resolve_subexp): Remove cast.
9265         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
9266         const.
9267         (iterate_over_file_blocks): Likewise.
9268         * f-exp.y (%union) <bval>: Remove.
9269         * coffread.c (patch_opaque_types): Make "b" const.
9270         * spu-tdep.c (spu_catch_start): Make "block" const.
9271         * c-valprint.c (print_unpacked_pointer): Remove "block".
9272         * symmisc.c (dump_symtab_1): Make "b" const.
9273         (block_depth): Make "block" const.
9274         * d-exp.y (%union) <bval>: Remove.
9275         * cp-support.h (cp_lookup_rtti_type): Update.
9276         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
9277         * psymtab.c (psym_lookup_symbol): Make "block" const.
9278         (maintenance_check_psymtabs): Make "b" const.
9279         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
9280         (enumerate_locals, enumerate_args): Update.
9281         * python/py-symtab.c (stpy_global_block): Make "block" const.
9282         (stpy_static_block): Likewise.
9283         * inline-frame.c (block_starting_point_at): Make "new_block"
9284         const.
9285         * block.c (find_block_in_blockvector): Make return type const.
9286         (blockvector_for_pc_sect): Make "b" const.
9287         (find_block_in_blockvector): Make "b" const.
9288
9289 2019-03-23  Tom Tromey  <tom@tromey.com>
9290
9291         * varobj.c (varobj_create): Update.
9292         * symfile.c (clear_symtab_users): Don't reset innermost_block.
9293         * printcmd.c (display_command, do_one_display): Don't reset
9294         innermost_block.
9295         * parser-defs.h (enum innermost_block_tracker_type): Move to
9296         expression.h.
9297         (innermost_block): Update comment.
9298         * parse.c (parse_exp_1): Add tracker_types parameter.
9299         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
9300         tracker_types parameter.  Reset innermost_block.
9301         (parse_exp_in_context): Remove.
9302         (parse_expression_for_completion): Update.
9303         * objfiles.c (~objfile): Don't reset expression_context_block or
9304         innermost_block.
9305         * expression.h (enum innermost_block_tracker_type): Move from
9306         parser-defs.h.
9307         (parse_exp_1): Add tracker_types parameter.
9308         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
9309         reset innermost_block.
9310
9311 2019-03-23  Tom Tromey  <tom@tromey.com>
9312
9313         * objfiles.h: Include bcache.h.
9314
9315 2019-03-23  Tom Tromey  <tom@tromey.com>
9316
9317         * linespec.c (get_current_search_block): Use
9318         scoped_restore_current_language.
9319         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
9320
9321 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9322             Jiong Wang  <jiong.wang@arm.com>
9323
9324         * aarch64-linux-tdep.c
9325         (aarch64_linux_iterate_over_regset_sections): Check for pauth
9326         section.
9327         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
9328
9329 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9330             Jiong Wang  <jiong.wang@arm.com>
9331
9332         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
9333         instructions.
9334         (aarch64_analyze_prologue_test): Add PACIASP test.
9335         (aarch64_prologue_prev_register): Unmask PC value.
9336
9337 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9338             Jiong Wang  <jiong.wang@arm.com>
9339
9340         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
9341         (aarch64_dwarf2_prev_register): Unmask PC value.
9342         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
9343         (aarch64_execute_dwarf_cfa_vendor_op): Check for
9344         DW_CFA_AARCH64_negate_ra_state.
9345         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
9346
9347 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9348             Jiong Wang  <jiong.wang@arm.com>
9349
9350         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
9351         registers.
9352         (aarch64_pseudo_register_name): Likewise.
9353         (aarch64_pseudo_register_type): Likewise.
9354         (aarch64_pseudo_register_reggroup_p): Likewise.
9355         (aarch64_gdbarch_init): Add pauth registers.
9356         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
9357         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
9358         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
9359         (struct gdbarch_tdep): Add regnum for ra_state.
9360
9361 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9362             Jiong Wang  <jiong.wang@arm.com>
9363
9364         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
9365
9366 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9367             Jiong Wang  <jiong.wang@arm.com>
9368
9369         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
9370         function.
9371         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
9372         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
9373         (aarch64_gdbarch_init): Add puth registers.
9374         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
9375         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
9376         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
9377
9378 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9379             Jiong Wang  <jiong.wang@arm.com>
9380
9381         * aarch64-linux-nat.c
9382         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
9383         * aarch64-linux-tdep.c
9384         (aarch64_linux_core_read_description): Likewise.
9385         (aarch64_linux_get_hwcap): New function.
9386         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
9387         (aarch64_linux_get_hwcap): New declaration.
9388
9389 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9390             Jiong Wang  <jiong.wang@arm.com>
9391
9392         * aarch64-linux-nat.c
9393         (aarch64_linux_nat_target::read_description): Add pauth param.
9394         * aarch64-linux-tdep.c
9395         (aarch64_linux_core_read_description): Likewise.
9396         * aarch64-tdep.c (struct target_desc): Add in pauth.
9397         (aarch64_read_description): Add pauth param.
9398         (aarch64_gdbarch_init): Likewise.
9399         * aarch64-tdep.h (aarch64_read_description): Likewise.
9400         * arch/aarch64.c (aarch64_create_target_description): Likewise.
9401         * arch/aarch64.h (aarch64_create_target_description): Likewise.
9402         * features/Makefile: Add new files.
9403         * features/aarch64-pauth.c: New file.
9404         * features/aarch64-pauth.xml: New file.
9405
9406 2019-03-20  Tom Tromey  <tromey@adacore.com>
9407
9408         * infrun.c (handle_inferior_event): Rename from
9409         handle_inferior_event_1.  Create a scoped_value_mark.
9410         (handle_inferior_event): Remove.
9411
9412 2019-03-19  Tom Tromey  <tromey@adacore.com>
9413
9414         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
9415         * infrun.h (print_stop_event): Add "displays" parameter.
9416         * infrun.c (print_stop_event): Add "displays" parameter.
9417
9418 2019-03-19  Pedro Alves  <palves@redhat.com>
9419
9420         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
9421         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
9422         to -1.  Fix TABs vs spaces.
9423         (tui_ui_out::tui_ui_out): Don't initialize fields here.
9424         * tui/tui-out.h (tui_ui_out) Add intro comments.
9425         <m_line, m_start_of_line>: In-class initialize, and add describing
9426         comment.
9427
9428 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
9429
9430         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
9431         variable names.
9432         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
9433
9434 2019-03-18  Pedro Alves  <palves@redhat.com>
9435             Eli Zaretskii <eliz@gnu.org>
9436
9437         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
9438         m_line and m_start_of_line.
9439
9440 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
9441
9442         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
9443         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
9444         it returns a newline.  This fixes a regression in TU mode, whereby
9445         the next line is output on the same screen line as the user input.
9446
9447 2019-03-18  Tom Tromey  <tromey@adacore.com>
9448
9449         * minsyms.c (minimal_symbol_reader::install): Remove call to
9450         obstack_blank.
9451
9452 2019-03-18  Pedro Alves  <palves@redhat.com>
9453
9454         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
9455         New globals.
9456         (apply_style): New, factored out from ...
9457         (apply_ansi_escape): ... this.  Handle reverse video mode.
9458         (tui_set_reverse_mode): New function.
9459         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
9460         * tui/tui-winsource.c (tui_show_source_line): Use
9461         tui_set_reverse_mode instead of setting A_STANDOUT.
9462         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
9463         New setter methods.
9464
9465 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
9466
9467         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
9468         Handle tabs.
9469
9470 2019-03-18  Tom Tromey  <tromey@adacore.com>
9471
9472         * ada-lang.c (empty_array): Add "high" parameter.
9473         (ada_evaluate_subexp): Update.
9474
9475 2019-03-17  Sergei Trofimovich <siarheit@google.com>
9476
9477         * unittests/string_view-selftests.c: Define
9478         _initialize_string_view_selftests unconditionally.
9479
9480 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9481
9482         PR gdb/24350
9483         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
9484
9485 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9486
9487         PR gdb/24351
9488         * windows-nat.c (display_selector): Fix format specifiers.
9489
9490 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
9491
9492         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
9493         tui_refill_source_window instead of tui_refresh_win, to update the
9494         current execution line.  This fixes redisplay of the current line
9495         when stepping through the code with "next" or "step".
9496
9497 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9498
9499         * source-cache.c (source_cache::get_source_lines): Call
9500         find_source_lines to initialize s->nlines.  This fixes vertical
9501         scrolling of TUI source window when the DOWN arrow is pressed.
9502
9503 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9504
9505         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
9506         linux-thread-db.c (_initialize_thread_db): Likewise.
9507
9508 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9509
9510         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
9511         wclrtoeol in tui_show_source_line".  This reverts changes made in
9512         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
9513
9514 2019-03-15  Tom Tromey  <tom@tromey.com>
9515
9516         * symtab.h (struct minimal_symbol): Derive from
9517         general_symbol_info.
9518         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
9519         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
9520         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
9521         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
9522         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
9523         (MSYMBOL_SEARCH_NAME): Update.
9524         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
9525         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
9526         * minsyms.c (minimal_symbol_reader::record_full): Update.
9527
9528 2019-03-15  Tom Tromey  <tom@tromey.com>
9529
9530         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
9531
9532 2019-03-15  Tom Tromey  <tom@tromey.com>
9533
9534         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
9535         unique_xmalloc_ptr.
9536         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
9537         Update.
9538         * minsyms.c (lookup_minimal_symbol_by_pc_section)
9539         (build_minimal_symbol_hash_tables)
9540         (minimal_symbol_reader::install): Update.
9541
9542 2019-03-15  Tom Tromey  <tom@tromey.com>
9543
9544         * symtab.c (create_demangled_names_hash): Update.
9545         (symbol_set_names): Update.
9546         * objfiles.h (struct objfile_per_bfd_storage)
9547         <demangled_names_hash>: Now an htab_up.
9548         * objfiles.c (objfile_per_bfd_storage): Simplify.
9549
9550 2019-03-15  Tom Tromey  <tom@tromey.com>
9551
9552         * objfiles.h (struct objfile_per_bfd_storage): Declare
9553         destructor.
9554         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
9555         New.
9556         (get_objfile_bfd_data): Use new.  Don't initialize
9557         language_of_main.
9558         (free_objfile_per_bfd_storage): Remove.
9559         (objfile_bfd_data_free, objfile::~objfile): Use delete.
9560
9561 2019-03-15  Tom Tromey  <tom@tromey.com>
9562
9563         * symfile.c (reread_symbols): Update.
9564         * objfiles.c (objfile::objfile): Update.
9565         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
9566         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
9567         comment.
9568         (minimal_symbol_reader::install): Update.
9569         (terminate_minimal_symbol_table): Remove.
9570         * jit.c (jit_object_close_impl): Update.
9571
9572 2019-03-15  Tom Tromey  <tom@tromey.com>
9573
9574         * minsyms.c (minimal_symbol_reader::record_full): Remove some
9575         initializations.
9576
9577 2019-03-15  Tom Tromey  <tom@tromey.com>
9578
9579         * objfiles.h (struct objfile_per_bfd_storage)
9580         <demangled_hash_languages>: Now a bitset.
9581         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
9582         (lookup_minimal_symbol): Update.
9583
9584 2019-03-15  Tom Tromey  <tom@tromey.com>
9585
9586         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
9587         Don't return the symbol.
9588         * coffread.c (record_minimal_symbol): Use record_full.
9589
9590 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
9591
9592         The MS-Windows port of ncurses fails to switch to a color pair if
9593         one or both of the colors are the implicit default colors.  This
9594         change records the default colors when TUI is initialized, and
9595         then specifies them explicitly when a color pair uses the default
9596         colors.  This allows color styling in TUI mode on MS-Windows.
9597
9598         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
9599         ncurses_norm_attr.
9600         (tui_initialize_io) [__MINGW32__]: Record the default terminal
9601         colors in ncurses_norm_attr.
9602         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
9603         "none", replace it with the default color recorded in
9604         ncurses_norm_attr.
9605
9606 2019-03-14  Tom Tromey  <tromey@adacore.com>
9607
9608         * source-cache.h (class source_cache) <get_source_lines>: Return
9609         std::string.
9610         * source-cache.c (source_cache::extract_lines): Handle case where
9611         first_pos==npos.  Return std::string.
9612         (source_cache::get_source_lines): Update.
9613
9614 2019-03-14  Tom Tromey  <tromey@adacore.com>
9615
9616         * NEWS: Add item for "style sources" commands.
9617         * source-cache.c (source_cache::get_source_lines): Check
9618         source_styling.
9619         * cli/cli-style.c (source_styling): New global.
9620         (_initialize_cli_style): Add "style sources" commands.
9621         (show_style_sources): New function.
9622         * cli/cli-style.h (source_styling): Declare.
9623
9624 2019-03-14  Pedro Alves  <palves@redhat.com>
9625             Tom Tromey  <tromey@adacore.com>
9626
9627         * tui/tui-winsource.h (tui_refill_source_window): Declare.
9628         * tui/tui-winsource.c (tui_refill_source_window): New function,
9629         from...
9630         (tui_horizontal_source_scroll): ... here.  Move some logic.
9631         * cli/cli-style.c (set_style_enabled): Notify new observable.
9632         * tui/tui-hooks.c (tui_redisplay_source): New function.
9633         (tui_attach_detach_observers): Attach or detach
9634         tui_redisplay_source.
9635         * observable.h (source_styling_changed): New observable.
9636         * observable.c: Define source_styling_changed observable.
9637
9638 2019-03-13  Tom Tromey  <tromey@adacore.com>
9639
9640         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
9641         (i386_gnu_nat_target::store_registers): Update.
9642         * target-debug.h (target_debug_print_std_string): New macro.
9643         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9644         * windows-tdep.c (display_one_tib): Update.
9645         * tui/tui-stack.c (tui_make_status_line): Update.
9646         * top.c (print_inferior_quit_action): Update.
9647         * thread.c (thr_try_catch_cmd): Update.
9648         (add_thread_with_info): Update.
9649         (thread_target_id_str): Update.
9650         (thr_try_catch_cmd): Update.
9651         (thread_command): Update.
9652         (thread_find_command): Update.
9653         * record-btrace.c (record_btrace_target::info_record)
9654         (record_btrace_resume_thread, record_btrace_target::resume)
9655         (record_btrace_cancel_resume, record_btrace_step_thread)
9656         (record_btrace_target::wait, record_btrace_target::wait)
9657         (record_btrace_target::wait, record_btrace_target::stop): Update.
9658         * progspace.c (print_program_space): Update.
9659         * process-stratum-target.c
9660         (process_stratum_target::thread_address_space): Update.
9661         * linux-fork.c (linux_fork_mourn_inferior)
9662         (detach_checkpoint_command, info_checkpoints_command)
9663         (linux_fork_context): Update.
9664         (linux_fork_detach): Update.
9665         (class scoped_switch_fork_info): Update.
9666         (delete_checkpoint_command): Update.
9667         * infrun.c (follow_fork_inferior): Update.
9668         (follow_fork_inferior): Update.
9669         (proceed_after_vfork_done): Update.
9670         (handle_vfork_child_exec_or_exit): Update.
9671         (follow_exec): Update.
9672         (displaced_step_prepare_throw): Update.
9673         (displaced_step_restore): Update.
9674         (start_step_over): Update.
9675         (resume_1): Update.
9676         (clear_proceed_status_thread): Update.
9677         (proceed): Update.
9678         (print_target_wait_results): Update.
9679         (do_target_wait): Update.
9680         (context_switch): Update.
9681         (stop_all_threads): Update.
9682         (restart_threads): Update.
9683         (finish_step_over): Update.
9684         (handle_signal_stop): Update.
9685         (switch_back_to_stepped_thread): Update.
9686         (keep_going_pass_signal): Update.
9687         (print_exited_reason): Update.
9688         (normal_stop): Update.
9689         * inferior.c (inferior_pid_to_str): Change return type.
9690         (print_selected_inferior): Update.
9691         (add_inferior): Update.
9692         (detach_inferior): Update.
9693         * dummy-frame.c (fprint_dummy_frames): Update.
9694         * dcache.c (dcache_info_1): Update.
9695         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
9696         (btrace_fetch, btrace_clear): Update.
9697         * linux-tdep.c (linux_core_pid_to_str): Change return type.
9698         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
9699         type.
9700         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
9701         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
9702         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
9703         * gdbarch.c, gdbarch.h: Rebuild.
9704         * gdbarch.sh (core_pid_to_str): Change return type.
9705         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
9706         return type.
9707         (windows_nat_target::pid_to_str): Change return type.
9708         (windows_delete_thread): Update.
9709         (windows_nat_target::attach): Update.
9710         (windows_nat_target::files_info): Update.
9711         * target-delegates.c: Rebuild.
9712         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
9713         return type.
9714         (sol_thread_target::pid_to_str): Change return type.
9715         * remote.c (class remote_target) <pid_to_str>: Change return
9716         type.
9717         (remote_target::pid_to_str): Change return type.
9718         (extended_remote_target::attach, remote_target::remote_stop_ns)
9719         (remote_target::remote_notif_remove_queued_reply)
9720         (remote_target::push_stop_reply, remote_target::disable_btrace):
9721         Update.
9722         (extended_remote_target::attach): Update.
9723         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
9724         type.
9725         (gdbsim_target::pid_to_str): Change return type.
9726         * ravenscar-thread.c (struct ravenscar_thread_target)
9727         <pid_to_str>: Change return type.
9728         (ravenscar_thread_target::pid_to_str): Change return type.
9729         * procfs.c (class procfs_target) <pid_to_str>: Change return
9730         type.
9731         (procfs_target::pid_to_str): Change return type.
9732         (procfs_target::attach): Update.
9733         (procfs_target::detach): Update.
9734         (procfs_target::fetch_registers): Update.
9735         (procfs_target::store_registers): Update.
9736         (procfs_target::wait): Update.
9737         (procfs_target::files_info): Update.
9738         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
9739         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
9740         return type.
9741         (nto_procfs_target::pid_to_str): Change return type.
9742         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
9743         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
9744         return type.
9745         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
9746         (exit_lwp): Update.
9747         (attach_proc_task_lwp_callback, get_detach_signal)
9748         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
9749         (linux_nat_target::resume, wait_lwp, stop_callback)
9750         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
9751         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
9752         (linux_nat_wait_1, resume_stopped_resumed_lwps)
9753         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
9754         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
9755         type.
9756         (inf_ptrace_target::attach): Update.
9757         (inf_ptrace_target::files_info): Update.
9758         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
9759         type.
9760         (go32_nat_target::pid_to_str): Change return type.
9761         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
9762         (gnu_nat_target::wait): Update.
9763         (gnu_nat_target::wait): Update.
9764         (gnu_nat_target::resume): Update.
9765         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
9766         (fbsd_nat_target::wait): Update.
9767         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
9768         type.
9769         (darwin_nat_target::attach): Update.
9770         * corelow.c (class core_target) <pid_to_str>: Change return type.
9771         (core_target::pid_to_str): Change return type.
9772         * target.c (normal_pid_to_str): Change return type.
9773         (default_pid_to_str): Likewise.
9774         (target_pid_to_str): Change return type.
9775         (target_translate_tls_address): Update.
9776         (target_announce_detach): Update.
9777         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
9778         return type.
9779         (bsd_uthread_target::pid_to_str): Change return type.
9780         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
9781         type.
9782         (bsd_kvm_target::pid_to_str): Change return type.
9783         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
9784         return type.
9785         (aix_thread_target::pid_to_str): Change return type.
9786         * target.h (struct target_ops) <pid_to_str>: Change return type.
9787         (target_pid_to_str, normal_pid_to_str): Likewise.
9788         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
9789         type.
9790         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
9791         type.
9792         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
9793         return type.
9794         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
9795         type.
9796         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
9797         type.
9798         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
9799         return type.
9800
9801 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
9802
9803         * NEWS: Mention that the new default MI version is 3.  Mention
9804         changes to the output of commands and events that deal with
9805         multi-location breakpoints.
9806         * breakpoint.c: Include "mi/mi-out.h".
9807         (print_one_breakpoint): Change output syntax if using MI version
9808         >= 3.
9809         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
9810         New.
9811         (mi_multi_location_breakpoint_output_fixed): New.
9812         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
9813         (mi_cmd_fix_multi_location_breakpoint_output): New.
9814         (mi_multi_location_breakpoint_output_fixed): New.
9815         * mi/mi-cmds.c (mi_cmds): Register command
9816         -fix-multi-location-breakpoint-output.
9817         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
9818         interpreter "mi".
9819
9820 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
9821
9822         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
9823         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
9824         instantiate mi_ui_out based on interpreter name.
9825         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
9826         * mi/mi-main.c (mi_load_progress): Likewise.
9827
9828 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9829
9830         * NEWS: Combine separate "New targets" sections for 8.3.
9831
9832 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9833
9834         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
9835         (ppcfbsd_init_abi): Install gdbarch
9836         "fetch_tls_load_module_address" and "get_thread_local_address"
9837         methods.
9838
9839 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9840
9841         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
9842         (riscv_fbsd_init_abi): Install gdbarch
9843         "fetch_tls_load_module_address" and "get_thread_local_address"
9844         methods.
9845
9846 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9847
9848         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
9849         (i386fbsd_init_abi): Install gdbarch
9850         "fetch_tls_load_module_address" and "get_thread_local_address"
9851         methods.
9852
9853 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9854
9855         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
9856         (amd64fbsd_init_abi): Install gdbarch
9857         "fetch_tls_load_module_address" and "get_thread_local_address"
9858         methods.
9859
9860 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9861
9862         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
9863         (struct fbsd_pspace_data): New type.
9864         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
9865         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
9866         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
9867         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
9868         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
9869
9870 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9871
9872         * gdbtypes.c (lookup_struct_elt): New function.
9873         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
9874         * gdbtypes.h (struct struct_elt): New type.
9875         (lookup_struct_elt): New prototype.
9876
9877 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9878
9879         * gdbtypes.c (lookup_struct_elt_type): Update comment and
9880         remove disabled code block.
9881
9882 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9883
9884         * gdbarch.sh (get_thread_local_address): New method.
9885         * gdbarch.h, gdbarch.c: Regenerate.
9886         * target.c (target_translate_tls_address): Use
9887         gdbarch_get_thread_local_address if present instead of
9888         target::get_thread_local_address.
9889
9890 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9891
9892         * target.h (target::get_thread_local_address): Update comment.
9893
9894 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9895
9896         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
9897         objfile->separate_debug_objfile_backlink if not NULL.
9898
9899 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9900
9901         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
9902         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
9903         (amd64bsd_store_inferior_registers): Likewise.
9904         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9905         Enable segment base registers.
9906         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
9907         PT_GETFSBASE and PT_GETGSBASE.
9908         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
9909         PT_SETGSBASE.
9910         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
9911         segment base registers.
9912         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9913
9914 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9915
9916         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9917         Update calls to i386_target_description to add 'segments'
9918         parameter.
9919         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
9920         add segment base registers.
9921         * arch/i386.c (i386_create_target_description): Add 'segments'
9922         parameter to enable segment base registers.
9923         * arch/i386.h (i386_create_target_description): Likewise.
9924         * features/i386/32bit-segments.xml: New file.
9925         * features/i386/32bit-segments.c: Generate.
9926         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
9927         call to i386_target_description to add 'segments' parameter.
9928         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9929         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
9930         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
9931         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
9932         if feature is present.
9933         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
9934         Add 'segments' parameter to call to i386_target_description.
9935         (i386_target_description): Add 'segments' parameter to enable
9936         segment base registers.
9937         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
9938         to call to i386_target_description.
9939         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
9940         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
9941         Define I386_NUM_REGS.
9942         (i386_target_description): Add 'segments' parameter to enable
9943         segment base registers.
9944
9945 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
9946
9947         PR/24325
9948         * source-cache.c: #undef open and close, to avoid unresolved
9949         externals during linking.
9950
9951 2019-03-12  Tom Tromey  <tromey@adacore.com>
9952
9953         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
9954         const.  Add initializers.
9955         (_initialize_remote): Don't initialize ptid globals.
9956
9957 2019-03-12  Pedro Alves  <palves@redhat.com>
9958
9959         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
9960
9961 2019-03-12  Pedro Alves  <palves@redhat.com>
9962
9963         * cp-name-parser.y (main): Remove unused 'len' variable.
9964
9965 2019-03-12  Tom Tromey  <tromey@adacore.com>
9966
9967         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
9968         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
9969
9970 2019-03-12  Tom Tromey  <tromey@adacore.com>
9971
9972         * linux-nat.c (iterate_over_lwps): Update.
9973         (stop_callback): Remove parameter.
9974         (stop_wait_callback, detach_callback, resume_set_callback)
9975         (select_singlestep_lwp_callback, set_ignore_sigint)
9976         (status_callback, resumed_callback, resume_clear_callback)
9977         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
9978         data parameter.
9979         (linux_nat_target::detach, linux_nat_target::resume)
9980         (linux_stop_and_wait_all_lwps, select_event_lwp)
9981         (linux_nat_filter_event, linux_nat_wait_1)
9982         (linux_nat_target::kill, linux_nat_target::stop)
9983         (linux_nat_target::stop): Update.
9984         (linux_nat_resume_callback): Change type.
9985         (resume_stopped_resumed_lwps, count_events_callback)
9986         (select_event_lwp_callback): Likewise.
9987         (linux_stop_lwp, linux_nat_stop_lwp): Update.
9988         * arm-linux-nat.c (struct update_registers_data): Remove.
9989         (update_registers_callback): Change type.
9990         (arm_linux_insert_hw_breakpoint1): Update.
9991         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
9992         parameter.
9993         (x86_linux_dr_set_addr): Update.
9994         (x86_linux_dr_set_control): Update.
9995         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
9996         (iterate_over_lwps): Use gdb::function_view.
9997         * nat/aarch64-linux-hw-point.c (struct
9998         aarch64_dr_update_callback_param): Remove.
9999         (debug_reg_change_callback): Change type.
10000         (aarch64_notify_debug_reg_change): Update.
10001         * s390-linux-nat.c (s390_refresh_per_info): Update.
10002
10003 2019-03-11  Tom Tromey  <tromey@adacore.com>
10004
10005         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
10006         redundant assignment to "this_cu".
10007
10008 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10009
10010         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
10011
10012 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10013
10014         * gdbtypes.c (rank_one_type_parm_set): New function extracted
10015         from...
10016         (rank_one_type): ... this.
10017
10018 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10019
10020         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
10021         from...
10022         (rank_one_type): ... this.
10023
10024 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10025
10026         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
10027         from...
10028         (rank_one_type): ... this.
10029
10030 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10031
10032         * gdbtypes.c (rank_one_type_parm_float): New function extracted
10033         from...
10034         (rank_one_type): ... this.
10035
10036 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10037
10038         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
10039         from...
10040         (rank_one_type): ... this.
10041
10042 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10043
10044         * gdbtypes.c (rank_one_type_parm_range): New function extracted
10045         from...
10046         (rank_one_type): ... this.
10047
10048 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10049
10050         * gdbtypes.c (rank_one_type_parm_char): New function extracted
10051         from...
10052         (rank_one_type): ... this.
10053
10054 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10055
10056         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
10057         from...
10058         (rank_one_type): ... this.
10059
10060 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10061
10062         * gdbtypes.c (rank_one_type_parm_int): New function extracted
10063         from...
10064         (rank_one_type): ... this.
10065
10066 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10067
10068         * gdbtypes.c (rank_one_type_parm_func): New function extracted
10069         from...
10070         (rank_one_type): ... this.
10071
10072 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10073
10074         * gdbtypes.c (rank_one_type_parm_array): New function extracted
10075         from...
10076         (rank_one_type): ... this.
10077
10078 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10079
10080         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
10081         from...
10082         (rank_one_type): ... this.
10083
10084 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10085
10086         * inferior.c (initialize_inferiors): Ensure 'help set/show print
10087         inferior-events' shows the example events.
10088
10089 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
10090
10091         Support styling on native MS-Windows console
10092
10093         PR/24315
10094         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
10095         on MS-Windows if $TERM is not defined.
10096
10097         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
10098
10099         * posix-hdep.c (gdb_console_fputs):
10100         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
10101         functions.
10102         * ui-file.h (gdb_console_fputs): Add prototype.
10103
10104         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
10105         back to fputs only if the former returns zero.
10106
10107 2019-03-07  Tom Tromey  <tom@tromey.com>
10108
10109         * symmisc.c (print_symbol_bcache_statistics): Update.
10110         (print_objfile_statistics): Update.
10111         * symfile.c (allocate_symtab): Update.
10112         * stabsread.c: Don't include bcache.h.
10113         * psymtab.h (struct psymbol_bcache): Don't declare.
10114         (class psymtab_storage) <psymbol_cache>: Now a bcache.
10115         (psymbol_bcache_init, psymbol_bcache_free)
10116         (psymbol_bcache_get_bcache): Don't declare.
10117         * psymtab.c (struct psymbol_bcache): Remove.
10118         (psymtab_storage::psymtab_storage): Update.
10119         (psymtab_storage::~psymtab_storage): Update.
10120         (psymbol_bcache_init, psymbol_bcache_free)
10121         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
10122         (add_psymbol_to_bcache): Update.
10123         (allocate_psymtab): Update.
10124         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
10125         macro_cache>: No longer pointers.
10126         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
10127         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
10128         * macrotab.c (macro_bcache): Update.
10129         * macroexp.c: Don't include bcache.h.
10130         * gdbtypes.c (check_types_worklist): Update.
10131         (types_deeply_equal): Remove TRY/CATCH.  Update.
10132         * elfread.c (elf_symtab_read): Update.
10133         * dwarf2read.c: Don't include bcache.h.
10134         * buildsym.c (buildsym_compunit::get_macro_table): Update.
10135         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
10136         (print_bcache_statistics, bcache_memory_used): Don't declare.
10137         (struct bcache): Move from bcache.c.  Add constructor, destructor,
10138         methods.  Rename all data members.
10139         * bcache.c (struct bcache): Move to bcache.h.
10140         (bcache::expand_hash_table): Rename from expand_hash_table.
10141         (bcache): Remove.
10142         (bcache::insert): Rename from bcache_full.
10143         (bcache::compare): Rename from bcache_compare.
10144         (bcache_xmalloc): Remove.
10145         (bcache::~bcache): Rename from bcache_xfree.
10146         (bcache::print_statistics): Rename from print_bcache_statistics.
10147         (bcache::memory_used): Rename from bcache_memory_used.
10148
10149 2019-03-07  Pedro Alves  <palves@redhat.com>
10150
10151         * infrun.c (normal_stop): Also check for
10152         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
10153
10154 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
10155
10156         * f-lang.c (value_from_host_double): Moved to...
10157         * value.c (value_from_host_double): ...here.
10158         * value.h (value_from_host_double): Declare.
10159         * guile/scm-math.c (vlscm_convert_typed_number): Use
10160         value_from_host_double.
10161         (vlscm_convert_number): Likewise.
10162         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
10163         * python/py-value.c (convert_value_from_python): Likewise.
10164
10165 2019-03-06  Tom Tromey  <tom@tromey.com>
10166
10167         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
10168
10169 2019-03-06  Tom Tromey  <tom@tromey.com>
10170
10171         * utils.h (free_current_contents): Don't declare.
10172         * utils.c (free_current_contents): Remove.
10173
10174 2019-03-06  Tom Tromey  <tom@tromey.com>
10175
10176         * top.c (quit_force): Update.
10177         * main.c (captured_command_loop): Update.
10178         * common/new-op.c (operator new): Update.
10179         * common/common-exceptions.c (struct catcher)
10180         <save_cleanup_chain>: Remove member.
10181         (exceptions_state_mc_init): Update.
10182         (exception_try_scope_entry): Return nullptr.
10183         (exception_try_scope_exit, exception_rethrow)
10184         (throw_exception_sjlj, throw_exception_cxx): Update.
10185         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
10186         (all_cleanups, do_cleanups, discard_cleanups)
10187         (discard_final_cleanups, save_cleanups, save_final_cleanups)
10188         (restore_cleanups, restore_final_cleanups): Don't declare.
10189         (do_final_cleanups): Remove parameter.
10190         * common/cleanups.c (cleanup_chain, make_cleanup)
10191         (make_cleanup_dtor, all_cleanups, do_cleanups)
10192         (discard_my_cleanups, discard_cleanups)
10193         (discard_final_cleanups, save_my_cleanups, save_cleanups)
10194         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
10195         (null_cleanup): Remove.
10196         (do_final_cleanups): Remove parameter.
10197
10198 2019-03-06  Tom Tromey  <tom@tromey.com>
10199
10200         * remote.c (remote_target::remote_parse_stop_reply): Use
10201         unique_xmalloc_ptr.
10202
10203 2019-03-06  Tom Tromey  <tom@tromey.com>
10204
10205         * stabsread.c (struct stabs_field_info): Rename from field_info.
10206         <list, fnlist>: Add initializers.
10207         <obstack>: New member.
10208         (read_member_functions, read_struct_fields, read_baseclasses):
10209         Allocate on obstack.  Don't use cleanups.
10210         (read_one_struct_field, read_member_functions, read_struct_fields)
10211         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
10212         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
10213         (read_struct_type): Update.
10214
10215 2019-03-06  Tom Tromey  <tom@tromey.com>
10216
10217         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
10218         * common/filestuff.h (make_cleanup_close): Don't declare.
10219         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
10220         Remove.
10221
10222 2019-03-06  Tom Tromey  <tom@tromey.com>
10223
10224         * solib-aix.c: Use make_scope_exit.
10225
10226 2019-03-06  Tom Tromey  <tom@tromey.com>
10227
10228         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
10229         Use make_scope_exit.
10230
10231 2019-03-06  Tom Tromey  <tom@tromey.com>
10232
10233         * solib-svr4.c (disable_probes_interface): Remove parameter.
10234         (svr4_handle_solib_event): Use make_scope_exit.
10235
10236 2019-03-06  Tom Tromey  <tom@tromey.com>
10237
10238         * remote.c (struct stop_reply_deleter): Remove.
10239         (stop_reply_up): Update.
10240         (struct stop_reply): Derive from notif_event.  Don't typedef.
10241         <regcache>: Now a std::vector.
10242         (stop_reply_xfree): Remove.
10243         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
10244         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
10245         (remote_target::discard_pending_stop_replies): Use delete.
10246         (remote_target::remote_parse_stop_reply): Update.
10247         (remote_target::process_stop_reply): Update.
10248         * remote-notif.h (struct notif_event): Add virtual destructor.
10249         Remove "dtr" member.
10250         (struct notif_client) <alloc_event>: Return a unique_ptr.
10251         (notif_event_xfree): Don't declare.
10252         (notif_event_up): New typedef.
10253         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
10254         (notif_event_xfree, do_notif_event_xfree): Remove.
10255         (remote_notif_state_xfree): Update.
10256
10257 2019-03-06  Tom Tromey  <tom@tromey.com>
10258
10259         * infrun.c (displaced_step_clear_cleanup): Now a
10260         forward_scope_exit type.
10261         (displaced_step_prepare_throw): Update.
10262         (displaced_step_fixup): Update.
10263
10264 2019-03-06  Tom Tromey  <tom@tromey.com>
10265
10266         * inferior.h (class inferior): Update comment.
10267         * gdbthread.h (class thread_info): Update comment.
10268
10269 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
10270             Tom Tromey  <tom@tromey.com>
10271
10272         * stabsread.h (struct stab_section_list): Remove.
10273         (coffstab_build_psymtabs): Update.
10274         * dbxread.c (symbuf_sections): Now a std::vector.
10275         (sect_idx): New global.
10276         (fill_symbuf): Update.
10277         (coffstab_build_psymtabs): Change type of stabsects parameter.
10278         Update.
10279         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
10280         std::vector.
10281         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
10282         (coff_locate_sections): Update.
10283         (coff_symfile_read): Remove cleanups.  Update.
10284         (init_stringtab): Add storage parameter.
10285         (free_stringtab, free_stringtab_cleanup): Remove.
10286         (init_lineno): Add storage parameter.
10287         (free_linetab, free_linetab_cleanup): Remove.
10288
10289 2019-03-06  Pedro Alves  <palves@redhat.com>
10290
10291         * linux-fork.c (fork_info::clobber_regs): Delete.
10292         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
10293         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
10294         comment.  Adjust.
10295         (scoped_switch_fork_info::scoped_switch_fork_info)
10296         (checkpoint_command, linux_fork_context): Adjust
10297         fork_save_infrun_state calls.
10298
10299 2019-03-06  Pedro Alves  <palves@redhat.com>
10300
10301         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
10302         (inf_has_multiple_threads): Return 'bool' and rewrite using
10303         inferior_info::threads().
10304
10305 2019-03-06  Pedro Alves  <palves@redhat.com>
10306
10307         * linux-fork.c: Include <list>.
10308         (fork_list): Now a std::list instance.
10309         (fork_info): Add ctor, dtor, and in-class initialize all fields.
10310         (forks_exist_p, find_last_fork): Adjust.
10311         (new_fork): Delete.
10312         (one_fork_p): New.
10313         (add_fork): Adjust.
10314         (free_fork): Delete, folded into fork_info::~fork_info().
10315         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
10316         Adjust.
10317         (init_fork_list): Delete.
10318         (linux_fork_killall, linux_fork_mourn_inferior)
10319         (linux_fork_detach, info_checkpoints_command): Adjust.
10320         (_initialize_linux_fork): No longer call init_fork_list.
10321
10322 2019-03-06  Pedro Alves  <palves@redhat.com>
10323
10324         * linux-fork.c (new_fork): New, split out of ...
10325         (add_fork): ... this.  Return void.  Move "first fork" special
10326         case from here, to ...
10327         (checkpoint_command): ... here.
10328         * linux-linux.h (add_fork): Return void.
10329
10330 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10331
10332         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
10333
10334 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10335             Chris January  <chris.january@arm.com>
10336             David Lecomber  <david.lecomber@arm.com>
10337
10338         * f-exp.y: New token, UNOP_INTRINSIC.
10339         (exp): New pattern using UNOP_INTRINSIC token.
10340         (f77_keywords): Add 'abs' keyword.
10341         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
10342         (value_from_host_double): New function.
10343         (evaluate_subexp_f): Support UNOP_ABS.
10344
10345 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10346
10347         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
10348         types.
10349
10350 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10351
10352         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
10353         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
10354         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
10355
10356 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10357
10358         * f-exp.y (convert_to_kind_type): Handle more type kinds.
10359
10360 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10361             Chris January  <chris.january@arm.com>
10362
10363         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
10364         * f-exp.y: Define 'KIND' token.
10365         (exp): New pattern for KIND expressions.
10366         (ptype): Handle types with a kind extension.
10367         (direct_abs_decl): Extend to spot kind extensions.
10368         (f77_keywords): Add 'kind' to the list.
10369         (push_kind_type): New function.
10370         (convert_to_kind_type): New function.
10371         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
10372         * parse.c (operator_length_standard): Likewise.
10373         * parser-defs.h (enum type_pieces): Add tp_kind.
10374         * std-operator.def: Add UNOP_KIND.
10375
10376 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10377
10378         * f-exp.y (f_parse): Set yydebug.
10379
10380 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10381
10382         * f-lang.c (evaluate_subexp_f): New function.
10383         (exp_descriptor_f): New global.
10384         (f_language_defn): Use exp_descriptor_f instead of
10385         exp_descriptor_standard.
10386
10387 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10388
10389         * f-exp.y (struct token): Add comments.
10390         (dot_ops): Remove uppercase versions and the end marker.
10391         (f77_keywords): Likewise.
10392         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
10393         entries in the dot_ops array are case insensitive, and use
10394         strncasecmp to compare strings.  Also some whitespace cleanup in
10395         this area.  Similar for the f77_keywords array, except entries in
10396         this list might be case sensitive.
10397
10398 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10399
10400         * f-exp.y (struct f77_boolean_val): Add comments.
10401         (boolean_values): Remove uppercase versions, and end marker.
10402         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
10403         and use strncasecmp to achieve case insensitivity.  Additionally,
10404         perform whitespace cleanup around this code.
10405
10406 2019-03-06  Tom Tromey  <tromey@adacore.com>
10407
10408         * remote-sim.c (gdbsim_target_open): Use result of
10409         gdb_argv::release.
10410
10411 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
10412         Dirk Schubert  <dirk.schubert@arm.com>
10413         Chris January  <chris.january@arm.com>
10414
10415         * eval.c (evaluate_subexp_standard): Call Fortran argument
10416         wrapping logic.
10417         * f-lang.c (struct value): A value which can be passed into a
10418         Fortran function call.
10419         (fortran_argument_convert): Wrap Fortran arguments in a pointer
10420         where appropriate.
10421         (struct type): Value ready for a Fortran function call.
10422         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
10423         is needed.
10424         * f-lang.h (fortran_argument_convert): Declaration.
10425         (fortran_preserve_arg_pointer): Declaration.
10426         * infcall.c (value_arg_coerce): Call Fortran argument logic.
10427
10428 2019-03-05  Tom Tromey  <tromey@adacore.com>
10429
10430         * python/py-prettyprint.c (print_string_repr): Remove #if.
10431         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
10432
10433 2019-03-05  Tom Tromey  <tromey@adacore.com>
10434
10435         * target.c (the_dummy_target): Move later.  Change type to
10436         "dummy_target".
10437         (initialize_targets): Don't initialize the_dummy_target.
10438
10439 2019-03-05  Tom Tromey  <tromey@adacore.com>
10440
10441         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
10442         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
10443
10444 2019-03-05  Tom Tromey  <tromey@adacore.com>
10445
10446         * windows-nat.c (windows_nat_target::attach)
10447         (windows_nat_target::detach): Don't call gdb_flush.
10448         * valprint.c (generic_val_print, val_print, val_print_string):
10449         Don't call gdb_flush.
10450         * utils.c (defaulted_query): Don't call gdb_flush.
10451         * typeprint.c (print_type_scalar): Don't call gdb_flush.
10452         * target.c (target_announce_detach): Don't call gdb_flush.
10453         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
10454         * remote.c (extended_remote_target::attach): Don't call
10455         gdb_flush.
10456         * procfs.c (procfs_target::detach): Don't call gdb_flush.
10457         * printcmd.c (do_examine): Don't call gdb_flush.
10458         (info_display_command): Don't call gdb_flush.
10459         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
10460         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
10461         * memattr.c (info_mem_command): Don't call gdb_flush.
10462         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
10463         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
10464         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
10465         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
10466         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
10467         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
10468         (gnu_nat_target::detach): Don't call gdb_flush.
10469         * f-valprint.c (f_val_print): Don't call gdb_flush.
10470         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
10471         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
10472         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
10473         gdb_flush.
10474         * c-valprint.c (c_val_print): Don't call gdb_flush.
10475         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
10476
10477 2019-03-05  Tom Tromey  <tromey@adacore.com>
10478
10479         * varobj.c (update_dynamic_varobj_children): Update.
10480         (install_default_visualizer): Use reset, not release.
10481         * value.c (set_internalvar): Update.
10482         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
10483         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
10484         ATTRIBUTE_UNUSED_RESULT.
10485
10486 2019-03-05  Tom Tromey  <tromey@adacore.com>
10487
10488         * remote.c (class scoped_remote_fd) <release>: Add
10489         ATTRIBUTE_UNUSED_RESULT.
10490
10491 2019-03-05  Tom Tromey  <tromey@adacore.com>
10492
10493         * macroexp.c (struct macro_buffer) <release>: Add
10494         ATTRIBUTE_UNUSED_RESULT.
10495
10496 2019-03-05  Tom Tromey  <tromey@adacore.com>
10497
10498         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
10499         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
10500         ATTRIBUTE_UNUSED_RESULT.
10501
10502 2019-03-05  Tom Tromey  <tromey@adacore.com>
10503
10504         * common/scoped_fd.h (class scoped_fd) <release>: Add
10505         ATTRIBUTE_UNUSED_RESULT.
10506
10507 2019-03-05  Tom Tromey  <tromey@adacore.com>
10508
10509         * parser-defs.h (struct parser_state) <release>: Add
10510         ATTRIBUTE_UNUSED_RESULT.
10511
10512 2019-03-05  Tom Tromey  <tromey@adacore.com>
10513
10514         * utils.h (class gdb_argv) <release>: Add
10515         ATTRIBUTE_UNUSED_RESULT.
10516         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
10517
10518 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
10519
10520         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
10521         for-loop range, to avoid compiler warnings.
10522
10523         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
10524         avoid compiler warnings about unused variables.
10525
10526         * NEWS: Mention end of support for native debugging on MS-Windows
10527         before XP.
10528
10529         PR gdb/24292
10530         * common/netstuff.c:
10531         * gdbserver/gdbreplay.c
10532         * gdbserver/remote-utils.c:
10533         * ser-tcp.c:
10534         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
10535         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
10536         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
10537         'getaddrinfo' and 'freeaddrinfo' were not available before
10538         Windows XP, and mingw.org's MinGW headers by default define
10539         _WIN32_WINNT to 0x500.
10540
10541 2019-03-01  Gary Benson <gbenson@redhat.com>
10542
10543         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
10544
10545 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
10546             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
10547
10548         PR gdb/8527
10549         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
10550         set_sigint_trap, clear_sigint_trap.
10551
10552 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10553
10554         * target.c (target_detach): Clear the regcache and the
10555         frame cache.
10556
10557 2019-02-27  Pedro Alves  <palves@redhat.com>
10558
10559         * utils.c (set_screen_size): When we cap the height/width sizes,
10560         tweak the corresponding command variable to show "unlimited":
10561
10562 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
10563             Pedro Alves  <palves@redhat.com>
10564
10565         * utils.c (set_screen_size): Reduce "infinite" rows and columns
10566         before calling rl_set_screen_size.
10567
10568 2019-02-27  Tom Tromey  <tromey@adacore.com>
10569
10570         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
10571         define.
10572         * python/py-value.c: Remove Python 2.4 workaround.
10573         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
10574         workaround.
10575         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
10576         Python 2.4 workaround.
10577         * python/python-internal.h: Remove Python 2.4 comment.
10578         (Py_ssize_t): Don't define.
10579         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
10580         (gdb_Py_DECREF): Remove Python 2.4 workaround.
10581         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
10582         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
10583         * python/python.c (do_start_initialization): Remove Python 2.4
10584         workaround.
10585         * python/py-prettyprint.c (class dummy_python_frame): Remove.
10586         (print_children): Remove Python 2.4 workaround.
10587         * python/py-inferior.c (buffer_procs): Remove Python 2.4
10588         workaround.
10589         (CHARBUFFERPROC_NAME): Remove.
10590         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
10591         Python 2.4 workaround.
10592
10593 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10594
10595         * NEWS: Note minimum Python version.
10596
10597 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10598
10599         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
10600         code from these functions.  Remove corresponding ifdefs.  Use
10601         Py_buffer_up instead of explicit calls to PyBuffer_Release.
10602         Remove gotos and target of gotos.
10603         (infpy_search_memory): Likewise.
10604
10605 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10606
10607         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
10608         (hppa_gdbarch_init): Don't register deleted functions with
10609         gdbarch.
10610
10611 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10612
10613         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
10614         (h8300_unwind_sp): Delete.
10615         (h8300_dummy_id): Delete.
10616         (h8300_gdbarch_init): Don't register deleted functions with
10617         gdbarch.
10618
10619 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10620
10621         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
10622         (ft32_unwind_pc): Delete.
10623         (ft32_unwind_sp): Delete.
10624         (ft32_gdbarch_init): Don't register deleted functions with
10625         gdbarch.
10626
10627 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10628
10629         * gdb/frv-tdep.c (frv_dummy_id): Delete.
10630         (frv_unwind_pc): Delete.
10631         (frv_unwind_sp): Delete.
10632         (frv_gdbarch_init): Don't register deleted functions with
10633         gdbarch.
10634
10635 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10636
10637         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
10638         (riscv_unwind_pc): Delete.
10639         (riscv_unwind_sp): Delete.
10640         (riscv_gdbarch_init): Don't register deleted functions with
10641         gdbarch.
10642
10643 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10644
10645         * gdb/csky-tdep.c (csky_dummy_id): Delete.
10646         (csky_unwind_pc): Delete.
10647         (csky_unwind_sp): Delete.
10648         (csky_gdbarch_init): Don't register deleted functions with
10649         gdbarch.
10650
10651 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10652
10653         * gdb/cris-tdep.c (cris_dummy_id): Delete.
10654         (cris_unwind_pc): Delete.
10655         (cris_unwind_sp): Delete.
10656         (cris_gdbarch_init): Don't register deleted functions with
10657         gdbarch.
10658
10659 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10660
10661         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
10662         (bfin_unwind_pc): Delete.
10663         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
10664
10665 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10666
10667         * gdb/arm-tdep.c (arm_dummy_id): Delete.
10668         (arm_unwind_pc): Delete.
10669         (arm_unwind_sp): Delete.
10670         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
10671
10672 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10673
10674         * gdb/arc-tdep.c (arc_dummy_id): Delete.
10675         (arc_unwind_pc): Delete.
10676         (arc_unwind_sp): Delete.
10677         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
10678
10679 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10680
10681         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
10682         (alpha_unwind_pc): Delete.
10683         (alpha_gdbarch_init): Don't register deleted functions with
10684         gdbarch.
10685
10686 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10687
10688         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
10689         (aarch64_unwind_pc): Delete.
10690         (aarch64_unwind_sp): Delete.
10691         (aarch64_gdbarch_init): Don't register deleted functions with
10692         gdbarch.
10693
10694 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10695
10696         * gdbtypes.c (type_align): Don't consider static members when
10697         computing structure alignment.
10698
10699 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10700
10701         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
10702         return 0 for other types.
10703         * arch-utils.c (default_type_align): Always return 0.
10704         * gdbarch.h: Regenerate.
10705         * gdbarch.sh (type_align): Extend comment.
10706         * gdbtypes.c (type_align): Add additional comments, always call
10707         gdbarch_type_align before applying the default rules.
10708         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
10709         generic code will then apply a suitable default.
10710         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
10711         types, return 0 for other types.
10712
10713 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
10714
10715         * NEWS: Create a new section for the next release branch.
10716         Rename the section of the current branch, now that it has
10717         been cut.
10718
10719 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
10720
10721         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
10722         * version.in: Bump version to 8.3.50.DATE-git.
10723
10724 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
10725
10726         * aix-thread.c (ptid_cmp): Remove unused variable.
10727         (get_signaled_thread): Likewise.
10728         (store_regs_user_thread): Likewise.
10729         (store_regs_kernel_thread): Likewise.
10730         (fetch_regs_kernel_thread): Remove shadowed variable.
10731
10732 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10733
10734         * features/riscv/32bit-cpu.xml: Add register numbers.
10735         * features/riscv/32bit-fpu.c: Regenerate.
10736         * features/riscv/32bit-fpu.xml: Add register numbers.
10737         * features/riscv/64bit-cpu.xml: Add register numbers.
10738         * features/riscv/64bit-fpu.c: Regenerate.
10739         * features/riscv/64bit-fpu.xml: Add register numbers.
10740
10741 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
10742
10743         * NEWS: Mention two argument form of gdb.Value constructor.
10744         * python/py-value.c (convert_buffer_and_type_to_value): New
10745         function.
10746         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
10747         Add support for handling an optional second argument.  Call
10748         convert_buffer_and_type_to_value as appropriate.
10749         * python/python-internal.h (Py_buffer_deleter): New struct.
10750         (Py_buffer_up): New typedef.
10751
10752 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
10753
10754         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
10755         instead of releasing ownership.
10756
10757 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
10758
10759         * dwarf2read.c (open_and_init_dwp_file): Call
10760         elf_numsections instead of bfd_count_sections to initialize
10761         dwp_file->num_sections.
10762
10763 2019-02-25  Tom Tromey  <tromey@adacore.com>
10764
10765         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
10766
10767 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
10768
10769         * gcore.in: Add '--readnever' option when invoking GDB.
10770
10771 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
10772
10773         * MAINTAINERS: Update my email address.
10774
10775 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
10776
10777         * build-id.c (build_id_to_debug_bfd_1): New function.
10778         (build_id_to_debug_bfd): Look for separate debug file in
10779         sysroot.
10780
10781 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
10782
10783         * gdbarch.sh: Update the copyright year range that is placed into
10784         generated files.
10785
10786 2019-02-22  Keith Seitz  <keiths@redhat.com>
10787
10788         PR symtab/23853
10789         * linespec.c (create_sals_line_offset): Search for the default
10790         symtab's filename instead of its fullname.
10791
10792 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
10793
10794         * NEWS: Update style defaults.
10795
10796 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
10797
10798         * main.c (captured_main_1): Disable styling in batch mode.
10799
10800 2019-02-20  Tom Tromey  <tom@tromey.com>
10801
10802         * symtab.c (symtab_symbol_info): Fix typos.
10803
10804 2019-02-20  Tom Tromey  <tromey@adacore.com>
10805
10806         * findcmd.c (_initialize_mem_search): Use upper case for
10807         metasyntactic variables.
10808
10809 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
10810
10811         * aarch64-tdep.c (aarch64_add_reggroups): New function.
10812         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
10813
10814 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
10815
10816         * top.h (source_file_name): Change to std::string.
10817         * top.c (source_file_name): Likewise.
10818         (command_line_input): Adjust.
10819         * cli/cli-script.c (script_from_file): Adjust.
10820
10821 2019-02-19  Tom Tromey  <tromey@adacore.com>
10822
10823         * ravenscar-thread.c
10824         (ravenscar_thread_target::update_thread_list): Don't call
10825         ada_build_task_list.
10826         * ada-lang.h (ada_build_task_list): Don't declare.
10827         * ada-tasks.c (struct ada_tasks_inferior_data)
10828         <task_list_valid_p>: Now bool.
10829         (read_known_tasks, ada_task_list_changed)
10830         (ada_tasks_invalidate_inferior_data): Update.
10831         (read_known_tasks_array): Return bool.
10832         (read_known_tasks_list): Likewise.
10833         (read_known_tasks): Return void.
10834         (ada_build_task_list): Now static.
10835
10836 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10837
10838         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
10839         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
10840
10841 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10842
10843         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
10844         variant for ada_tasks_pspace_data_handle and
10845         ada_tasks_inferior_data_handle.
10846         (ada_tasks_pspace_data_cleanup): New function.
10847         (ada_tasks_inferior_data_cleanup): New function.
10848
10849 2019-02-17  Tom Tromey  <tom@tromey.com>
10850
10851         * macrotab.h (macro_source_fullname): Return a std::string.
10852         * macrotab.c (macro_include, check_for_redefinition)
10853         (macro_undef, macro_lookup_definition, foreach_macro)
10854         (foreach_macro_in_scope): Update.
10855         (macro_source_fullname): Return a std::string.
10856         * macrocmd.c (show_pp_source_pos): Update.
10857
10858 2019-02-17  Tom Tromey  <tom@tromey.com>
10859
10860         * macrocmd.c (show_pp_source_pos): Style the file names.
10861
10862 2019-02-17  Tom Tromey  <tom@tromey.com>
10863
10864         PR tui/24197:
10865         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
10866
10867 2019-02-17  Tom Tromey  <tom@tromey.com>
10868
10869         * ada-lang.c (user_select_syms): Use filtered printing.
10870         * utils.c (wrap_style): New global.
10871         (desired_style): Remove.
10872         (emit_style_escape): Add stream parameter.
10873         (set_output_style, reset_terminal_style, prompt_for_continue):
10874         Update.
10875         (flush_wrap_buffer): Only flush gdb_stdout.
10876         (wrap_here): Set wrap_style.
10877         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
10878         treat escape sequences as a character.  Change when wrap buffer is
10879         flushed.
10880         (fputs_styled): Do not set the output style when the default is
10881         requested.
10882         * ui-style.h (struct ui_file_style) <is_default>: New method.
10883         * source.c (print_source_lines_base): Emit escape sequences in one
10884         piece.
10885
10886 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10887
10888         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
10889         integers and enumeration types.
10890
10891 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10892
10893         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
10894         instead of lookup_symbol_in_language
10895         (do_exact_match): New function.
10896         (ada_get_symbol_name_matcher): Return do_exact_match when
10897         doing a verbatim match.
10898
10899 2019-02-15  Tom Tromey  <tromey@adacore.com>
10900
10901         * ravenscar-thread.c (ravenscar_thread_target::resume)
10902         (ravenscar_thread_target::wait): Special case wildcard requests.
10903
10904 2019-02-15  Tom Tromey  <tromey@adacore.com>
10905
10906         * ravenscar-thread.c (base_ptid): Remove.
10907         (struct ravenscar_thread_target) <close>: New method.
10908         <m_base_ptid>: New member.
10909         <update_inferior_ptid, active_task, task_is_currently_active,
10910         runtime_initialized>: Declare methods.
10911         <ravenscar_thread_target>: Add constructor.
10912         (ravenscar_thread_target::task_is_currently_active)
10913         (ravenscar_thread_target::update_inferior_ptid)
10914         (ravenscar_runtime_initialized): Rename.  Now methods.
10915         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
10916         (ravenscar_thread_target::update_thread_list): Update.
10917         (ravenscar_thread_target::active_task): Now method.
10918         (ravenscar_thread_target::store_registers)
10919         (ravenscar_thread_target::prepare_to_store)
10920         (ravenscar_thread_target::prepare_to_store)
10921         (ravenscar_thread_target::mourn_inferior): Update.
10922         (ravenscar_inferior_created): Use "new" to create target.
10923         (ravenscar_thread_target::get_ada_task_ptid): Update.
10924         (_initialize_ravenscar): Don't initialize base_ptid.
10925         (ravenscar_ops): Remove global.
10926
10927 2019-02-15  Tom Tromey  <tromey@adacore.com>
10928
10929         * target.h (push_target): Declare new overload.
10930         * target.c (push_target): New overload, taking an rvalue reference.
10931         * remote.c (remote_target::open_1): Use push_target overload.
10932         * corelow.c (core_target_open): Use push_target overload.
10933
10934 2019-02-15  Tom Tromey  <tromey@adacore.com>
10935
10936         * ravenscar-thread.c (is_ravenscar_task)
10937         (ravenscar_task_is_currently_active): Return bool.
10938         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
10939         (_initialize_ravenscar): Remove "(void)".
10940         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
10941         Return bool.
10942
10943 2019-02-15  Tom Tromey  <tromey@adacore.com>
10944
10945         * ravenscar-thread.c (ravenscar_runtime_initializer)
10946         (has_ravenscar_runtime, get_running_thread_id)
10947         (ravenscar_thread_target::resume): Fix indentation.
10948
10949 2019-02-15  Tom Tromey  <tromey@adacore.com>
10950
10951         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
10952         from ravenscar_arch_ops.
10953         (sparc_ravenscar_ops::fetch_registers)
10954         (sparc_ravenscar_ops::store_registers): Now methods.
10955         (sparc_ravenscar_prepare_to_store): Remove.
10956         (sparc_ravenscar_ops): Redefine.
10957         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
10958         methods and destructor.  Remove members.
10959         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
10960         (ravenscar_thread_target::store_registers)
10961         (ravenscar_thread_target::prepare_to_store): Update.
10962         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
10963         Remove.
10964         (struct ppc_ravenscar_powerpc_ops): Derive from
10965         ravenscar_arch_ops.
10966         (ppc_ravenscar_powerpc_ops::fetch_registers)
10967         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
10968         (ppc_ravenscar_powerpc_ops): Redefine.
10969         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
10970         (ppc_ravenscar_e500_ops::fetch_registers)
10971         (ppc_ravenscar_e500_ops::store_registers): Now methods.
10972         (ppc_ravenscar_e500_ops): Redefine.
10973         * aarch64-ravenscar-thread.c
10974         (aarch64_ravenscar_generic_prepare_to_store): Remove.
10975         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
10976         (aarch64_ravenscar_fetch_registers)
10977         (aarch64_ravenscar_store_registers): Now methods.
10978         (aarch64_ravenscar_ops): Redefine.
10979
10980 2019-02-15  Tom Tromey  <tromey@adacore.com>
10981
10982         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
10983         (ravenscar_thread_target::stopped_by_hw_breakpoint)
10984         (ravenscar_thread_target::stopped_by_watchpoint)
10985         (ravenscar_thread_target::stopped_data_address)
10986         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
10987
10988 2019-02-15  Tom Tromey  <tromey@adacore.com>
10989
10990         * ravenscar-thread.c: Fix some typos.
10991
10992 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10993             Tom Tromey  <tromey@adacore.com>
10994
10995         * ada-lang.c (ada_exception_sal): Change addr_string to a
10996         std::string.
10997         (create_ada_exception_catchpoint): Update.
10998
10999 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11000             Tom Tromey  <tromey@adacore.com>
11001
11002         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
11003         (bp_location_ops): Remove.
11004         (base_breakpoint_allocate_location): Update.
11005         (free_bp_location): Update.
11006         * ada-lang.c (class ada_catchpoint_location)
11007         <ada_catchpoint_location>: Remove ops parameter.
11008         (ada_catchpoint_location_dtor): Remove.
11009         (ada_catchpoint_location_ops): Remove.
11010         (allocate_location_exception): Update.
11011         * breakpoint.h (struct bp_location_ops): Remove.
11012         (class bp_location) <bp_location>: Remove bp_location_ops
11013         parameter.
11014         <~bp_location>: Add destructor.
11015         <ops>: Remove.
11016
11017 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11018             Pedro Alves  <palves@redhat.com>
11019
11020         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
11021         'PATH_MAX'.
11022
11023 2019-02-14  David Michael  <fedora.dm0@gmail.com>
11024             Samuel Thibault  <samuel.thibault@gnu.org>
11025             Thomas Schwinge  <thomas@codesourcery.com>
11026
11027         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
11028         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
11029
11030 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11031
11032         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
11033         (check_empty): Use "const char *".
11034
11035         * gnu-nat.c (gnu_nat_target::detach): Instead of
11036         'detach_inferior (pid)' call
11037         'detach_inferior (find_inferior_pid (pid))'.
11038
11039         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
11040         'nat/fork-inferior.o'.
11041         * gnu-nat.c: #include "nat/fork-inferior.h".
11042
11043         * gnu-nat.c (gnu_nat_target::detach): Instead of
11044         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
11045         * gnu-nat.h: #include "inf-child.h".
11046         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
11047         'i386_gnu_nat_target::fetch_registers'.
11048         (gnu_store_registers): Rename/move to
11049         'i386_gnu_nat_target::store_registers'.
11050
11051         * config/i386/nm-i386gnu.h: Don't "#include" any files.
11052         * gnu-nat.h (mach_thread_info): New function.
11053         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
11054
11055         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
11056
11057 2019-02-14  Frederic Konrad  <konrad@adacore.com>
11058
11059         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
11060
11061 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
11062
11063         * windows-nat.c (windows_add_thread): Add new parameter
11064         "main_thread_p" with default value set to false.  Update
11065         function documentation as well as all callers.
11066         (windows_delete_thread): Likewise.
11067         (fake_create_process): Update call to windows_add_thread.
11068         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
11069         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
11070         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
11071         call to windows_delete_thread.
11072
11073 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
11074
11075         * MAINTAINERS: Add Andrew Burgess as global maintainer.
11076
11077 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11078
11079         * symfile.c (find_separate_debug_file): Use canonical path of
11080         sysroot with child_path instead of gdb_sysroot if it is valid.
11081
11082 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11083
11084         * symfile.c (find_separate_debug_file): Use child_path to
11085         determine if an object file is under a sysroot.
11086
11087 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11088
11089         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
11090         unittests/child-path-selftests.c.
11091         * common/pathstuff.c (child_path): New function.
11092         * common/pathstuff.h (child_path): New prototype.
11093         * unittests/child-path-selftests.c: New file.
11094
11095 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11096
11097         * symfile.c (find_separate_debug_file): Look for separate debug
11098         files in debug directories under the sysroot.
11099
11100 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11101
11102         * symtab.h (struct minimal_symbol data_p): New const method.
11103         (struct minimal_symbol text_p): Likewise.
11104         * symtab.c (output_source_filename): Use file name style
11105         to print file name.
11106         (print_symbol_info): Likewise.
11107         (print_msymbol_info): Use address style to print addresses.
11108         Use function name style to print executable text symbols.
11109         (expand_symtab_containing_pc): Use data_p.
11110         (find_pc_sect_compunit_symtab): Likewise.
11111
11112 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11113
11114         * breakpoint.c (describe_other_breakpoints): Use address style
11115         to print addresses.
11116         (say_where): Likewise.
11117
11118 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11119
11120         * ada-typeprint.c (print_func_type): Print function name
11121         style to print function name.
11122         * c-typeprint.c (c_print_type_1): Likewise.
11123
11124 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
11125
11126         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
11127         for execve.
11128
11129 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11130
11131         * c-exp.y (direct_abs_decl): Use emplace_back to record the
11132         type_stack.
11133
11134 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
11135
11136         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
11137         TYPE_CODE_REF types.
11138
11139 2019-02-08  Jim Wilson  <jimw@sifive.com>
11140
11141         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
11142         (riscv_linux_fregset): New.
11143         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
11144
11145 2019-02-07  Tom Tromey  <tom@tromey.com>
11146
11147         * thread.c (thread_cancel_execution_command): Update.
11148         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
11149         methods.
11150         (struct thread_fsm_ops): Remove.
11151         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
11152         (thread_fsm_should_stop, thread_fsm_return_value)
11153         (thread_fsm_set_finished, thread_fsm_finished_p)
11154         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
11155         Don't declare.
11156         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
11157         * infrun.c (clear_proceed_status_thread)
11158         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
11159         (print_stop_event): Update.
11160         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
11161         Add constructor.
11162         (step_command_fsm_ops): Remove.
11163         (new_step_command_fsm): Remove.
11164         (step_1): Update.
11165         (step_command_fsm::should_stop): Rename from
11166         step_command_fsm_should_stop.
11167         (step_command_fsm::clean_up): Rename from
11168         step_command_fsm_clean_up.
11169         (step_command_fsm::do_async_reply_reason): Rename from
11170         step_command_fsm_async_reply_reason.
11171         (struct until_next_fsm): Inherit from thread_fsm.  Add
11172         constructor.
11173         (until_next_fsm_ops): Remove.
11174         (new_until_next_fsm): Remove.
11175         (until_next_fsm::should_stop): Rename from
11176         until_next_fsm_should_stop.
11177         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
11178         (until_next_fsm::do_async_reply_reason): Rename from
11179         until_next_fsm_async_reply_reason.
11180         (struct finish_command_fsm): Inherit from thread_fsm.  Add
11181         constructor.  Change type of breakpoint.
11182         (finish_command_fsm_ops): Remove.
11183         (new_finish_command_fsm): Remove.
11184         (finish_command_fsm::should_stop): Rename from
11185         finish_command_fsm_should_stop.
11186         (finish_command_fsm::clean_up): Rename from
11187         finish_command_fsm_clean_up.
11188         (finish_command_fsm::return_value): Rename from
11189         finish_command_fsm_return_value.
11190         (finish_command_fsm::do_async_reply_reason): Rename from
11191         finish_command_fsm_async_reply_reason.
11192         (finish_command): Update.
11193         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
11194         Add constructor.
11195         (call_thread_fsm_ops): Remove.
11196         (call_thread_fsm::call_thread_fsm): Rename from
11197         new_call_thread_fsm.
11198         (call_thread_fsm::should_stop): Rename from
11199         call_thread_fsm_should_stop.
11200         (call_thread_fsm::should_notify_stop): Rename from
11201         call_thread_fsm_should_notify_stop.
11202         (run_inferior_call, call_function_by_hand_dummy): Update.
11203         * cli/cli-interp.c (should_print_stop_to_console): Update.
11204         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
11205         Add constructor.  Change type of location_breakpoint,
11206         caller_breakpoint.
11207         (until_break_fsm_ops): Remove.
11208         (new_until_break_fsm): Remove.
11209         (until_break_fsm::should_stop): Rename from
11210         until_break_fsm_should_stop.
11211         (until_break_fsm::clean_up): Rename from
11212         until_break_fsm_clean_up.
11213         (until_break_fsm::do_async_reply_reason): Rename from
11214         until_break_fsm_async_reply_reason.
11215         (until_break_command): Update.
11216         * thread-fsm.c: Remove.
11217         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
11218
11219 2019-02-07  Tom Tromey  <tom@tromey.com>
11220
11221         * yy-remap.h: Add include guard.
11222         * xtensa-tdep.h: Add include guard.
11223         * xcoffread.h: Rename include guard.
11224         * varobj-iter.h: Add include guard.
11225         * tui/tui.h: Rename include guard.
11226         * tui/tui-winsource.h: Rename include guard.
11227         * tui/tui-wingeneral.h: Rename include guard.
11228         * tui/tui-windata.h: Rename include guard.
11229         * tui/tui-win.h: Rename include guard.
11230         * tui/tui-stack.h: Rename include guard.
11231         * tui/tui-source.h: Rename include guard.
11232         * tui/tui-regs.h: Rename include guard.
11233         * tui/tui-out.h: Rename include guard.
11234         * tui/tui-layout.h: Rename include guard.
11235         * tui/tui-io.h: Rename include guard.
11236         * tui/tui-hooks.h: Rename include guard.
11237         * tui/tui-file.h: Rename include guard.
11238         * tui/tui-disasm.h: Rename include guard.
11239         * tui/tui-data.h: Rename include guard.
11240         * tui/tui-command.h: Rename include guard.
11241         * tic6x-tdep.h: Add include guard.
11242         * target/waitstatus.h: Rename include guard.
11243         * target/wait.h: Rename include guard.
11244         * target/target.h: Rename include guard.
11245         * target/resume.h: Rename include guard.
11246         * target-float.h: Rename include guard.
11247         * stabsread.h: Add include guard.
11248         * rs6000-tdep.h: Add include guard.
11249         * riscv-fbsd-tdep.h: Add include guard.
11250         * regformats/regdef.h: Rename include guard.
11251         * record.h: Rename include guard.
11252         * python/python.h: Rename include guard.
11253         * python/python-internal.h: Rename include guard.
11254         * python/py-stopevent.h: Rename include guard.
11255         * python/py-ref.h: Rename include guard.
11256         * python/py-record.h: Rename include guard.
11257         * python/py-record-full.h: Rename include guard.
11258         * python/py-record-btrace.h: Rename include guard.
11259         * python/py-instruction.h: Rename include guard.
11260         * python/py-events.h: Rename include guard.
11261         * python/py-event.h: Rename include guard.
11262         * procfs.h: Add include guard.
11263         * proc-utils.h: Add include guard.
11264         * p-lang.h: Add include guard.
11265         * or1k-tdep.h: Rename include guard.
11266         * observable.h: Rename include guard.
11267         * nto-tdep.h: Rename include guard.
11268         * nat/x86-linux.h: Rename include guard.
11269         * nat/x86-linux-dregs.h: Rename include guard.
11270         * nat/x86-gcc-cpuid.h: Add include guard.
11271         * nat/x86-dregs.h: Rename include guard.
11272         * nat/x86-cpuid.h: Rename include guard.
11273         * nat/ppc-linux.h: Rename include guard.
11274         * nat/mips-linux-watch.h: Rename include guard.
11275         * nat/linux-waitpid.h: Rename include guard.
11276         * nat/linux-ptrace.h: Rename include guard.
11277         * nat/linux-procfs.h: Rename include guard.
11278         * nat/linux-osdata.h: Rename include guard.
11279         * nat/linux-nat.h: Rename include guard.
11280         * nat/linux-namespaces.h: Rename include guard.
11281         * nat/linux-btrace.h: Rename include guard.
11282         * nat/glibc_thread_db.h: Rename include guard.
11283         * nat/gdb_thread_db.h: Rename include guard.
11284         * nat/gdb_ptrace.h: Rename include guard.
11285         * nat/fork-inferior.h: Rename include guard.
11286         * nat/amd64-linux-siginfo.h: Rename include guard.
11287         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
11288         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
11289         * nat/aarch64-linux.h: Rename include guard.
11290         * nat/aarch64-linux-hw-point.h: Rename include guard.
11291         * mn10300-tdep.h: Add include guard.
11292         * mips-linux-tdep.h: Add include guard.
11293         * mi/mi-parse.h: Rename include guard.
11294         * mi/mi-out.h: Rename include guard.
11295         * mi/mi-main.h: Rename include guard.
11296         * mi/mi-interp.h: Rename include guard.
11297         * mi/mi-getopt.h: Rename include guard.
11298         * mi/mi-console.h: Rename include guard.
11299         * mi/mi-common.h: Rename include guard.
11300         * mi/mi-cmds.h: Rename include guard.
11301         * mi/mi-cmd-break.h: Rename include guard.
11302         * m2-lang.h: Add include guard.
11303         * location.h: Rename include guard.
11304         * linux-record.h: Rename include guard.
11305         * linux-nat.h: Add include guard.
11306         * linux-fork.h: Add include guard.
11307         * i386-darwin-tdep.h: Rename include guard.
11308         * hppa-linux-offsets.h: Add include guard.
11309         * guile/guile.h: Rename include guard.
11310         * guile/guile-internal.h: Rename include guard.
11311         * gnu-nat.h: Rename include guard.
11312         * gdb-stabs.h: Rename include guard.
11313         * frv-tdep.h: Add include guard.
11314         * f-lang.h: Add include guard.
11315         * event-loop.h: Add include guard.
11316         * darwin-nat.h: Rename include guard.
11317         * cp-abi.h: Rename include guard.
11318         * config/sparc/nm-sol2.h: Rename include guard.
11319         * config/nm-nto.h: Rename include guard.
11320         * config/nm-linux.h: Add include guard.
11321         * config/i386/nm-i386gnu.h: Rename include guard.
11322         * config/djgpp/nl_types.h: Rename include guard.
11323         * config/djgpp/langinfo.h: Rename include guard.
11324         * compile/gcc-cp-plugin.h: Add include guard.
11325         * compile/gcc-c-plugin.h: Add include guard.
11326         * compile/compile.h: Rename include guard.
11327         * compile/compile-object-run.h: Rename include guard.
11328         * compile/compile-object-load.h: Rename include guard.
11329         * compile/compile-internal.h: Rename include guard.
11330         * compile/compile-cplus.h: Rename include guard.
11331         * compile/compile-c.h: Rename include guard.
11332         * common/xml-utils.h: Rename include guard.
11333         * common/x86-xstate.h: Rename include guard.
11334         * common/version.h: Rename include guard.
11335         * common/vec.h: Rename include guard.
11336         * common/tdesc.h: Rename include guard.
11337         * common/selftest.h: Rename include guard.
11338         * common/scoped_restore.h: Rename include guard.
11339         * common/scoped_mmap.h: Rename include guard.
11340         * common/scoped_fd.h: Rename include guard.
11341         * common/safe-iterator.h: Rename include guard.
11342         * common/run-time-clock.h: Rename include guard.
11343         * common/refcounted-object.h: Rename include guard.
11344         * common/queue.h: Rename include guard.
11345         * common/ptid.h: Rename include guard.
11346         * common/print-utils.h: Rename include guard.
11347         * common/preprocessor.h: Rename include guard.
11348         * common/pathstuff.h: Rename include guard.
11349         * common/observable.h: Rename include guard.
11350         * common/netstuff.h: Rename include guard.
11351         * common/job-control.h: Rename include guard.
11352         * common/host-defs.h: Rename include guard.
11353         * common/gdb_wait.h: Rename include guard.
11354         * common/gdb_vecs.h: Rename include guard.
11355         * common/gdb_unlinker.h: Rename include guard.
11356         * common/gdb_unique_ptr.h: Rename include guard.
11357         * common/gdb_tilde_expand.h: Rename include guard.
11358         * common/gdb_sys_time.h: Rename include guard.
11359         * common/gdb_string_view.h: Rename include guard.
11360         * common/gdb_splay_tree.h: Rename include guard.
11361         * common/gdb_setjmp.h: Rename include guard.
11362         * common/gdb_ref_ptr.h: Rename include guard.
11363         * common/gdb_optional.h: Rename include guard.
11364         * common/gdb_locale.h: Rename include guard.
11365         * common/gdb_assert.h: Rename include guard.
11366         * common/filtered-iterator.h: Rename include guard.
11367         * common/filestuff.h: Rename include guard.
11368         * common/fileio.h: Rename include guard.
11369         * common/environ.h: Rename include guard.
11370         * common/common-utils.h: Rename include guard.
11371         * common/common-types.h: Rename include guard.
11372         * common/common-regcache.h: Rename include guard.
11373         * common/common-inferior.h: Rename include guard.
11374         * common/common-gdbthread.h: Rename include guard.
11375         * common/common-exceptions.h: Rename include guard.
11376         * common/common-defs.h: Rename include guard.
11377         * common/common-debug.h: Rename include guard.
11378         * common/cleanups.h: Rename include guard.
11379         * common/buffer.h: Rename include guard.
11380         * common/btrace-common.h: Rename include guard.
11381         * common/break-common.h: Rename include guard.
11382         * cli/cli-utils.h: Rename include guard.
11383         * cli/cli-style.h: Rename include guard.
11384         * cli/cli-setshow.h: Rename include guard.
11385         * cli/cli-script.h: Rename include guard.
11386         * cli/cli-interp.h: Rename include guard.
11387         * cli/cli-decode.h: Rename include guard.
11388         * cli/cli-cmds.h: Rename include guard.
11389         * charset-list.h: Add include guard.
11390         * buildsym-legacy.h: Rename include guard.
11391         * bfin-tdep.h: Add include guard.
11392         * ax.h: Rename include guard.
11393         * arm-linux-tdep.h: Add include guard.
11394         * arm-fbsd-tdep.h: Add include guard.
11395         * arch/xtensa.h: Rename include guard.
11396         * arch/tic6x.h: Add include guard.
11397         * arch/i386.h: Add include guard.
11398         * arch/arm.h: Rename include guard.
11399         * arch/arm-linux.h: Rename include guard.
11400         * arch/arm-get-next-pcs.h: Rename include guard.
11401         * arch/amd64.h: Add include guard.
11402         * arch/aarch64-insn.h: Rename include guard.
11403         * arch-utils.h: Rename include guard.
11404         * annotate.h: Add include guard.
11405         * amd64-darwin-tdep.h: Rename include guard.
11406         * aarch64-linux-tdep.h: Add include guard.
11407         * aarch64-fbsd-tdep.h: Add include guard.
11408         * aarch32-linux-nat.h: Add include guard.
11409
11410 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11411
11412         * macrotab.c (macro_define_internal): New function that
11413         factorizes macro_define_object_internal and macro_define_function
11414         code.
11415         (macro_define_object_internal): Use macro_define_internal.
11416         (macro_define_function): Likewise.
11417
11418 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11419
11420         * macrocmd.c (extract_identifier): Return
11421         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
11422         callers.
11423
11424 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
11425
11426         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
11427
11428 2019-02-05  Tom Tromey  <tom@tromey.com>
11429
11430         * target.c (target_stack::unpush): Move assertion earlier.
11431
11432 2019-01-30  Tom Tromey  <tom@tromey.com>
11433
11434         PR python/23615:
11435         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
11436         (gdbpy_parse_and_eval): Likewise.
11437         * python/python-internal.h (gdbpy_allow_threads): New class.
11438
11439 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
11440
11441         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
11442         (aarch64_fbsd_fpregmap): Move earlier.
11443         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
11444         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11445         instead of individual calls to trad_frame_set_reg_addr.
11446         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
11447         earlier.
11448         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
11449         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11450         instead of individual calls to trad_frame_set_reg_addr.
11451
11452 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
11453
11454         * CONTRIBUTE: Replace contribution list with wiki link.
11455
11456 2019-01-25  Tom Tromey  <tom@tromey.com>
11457
11458         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
11459
11460 2019-01-25  Tom Tromey  <tom@tromey.com>
11461
11462         * xtensa-linux-nat.c: Fix common/ includes.
11463         * xml-support.h: Fix common/ includes.
11464         * xml-support.c: Fix common/ includes.
11465         * x86-linux-nat.c: Fix common/ includes.
11466         * windows-nat.c: Fix common/ includes.
11467         * varobj.h: Fix common/ includes.
11468         * varobj.c: Fix common/ includes.
11469         * value.c: Fix common/ includes.
11470         * valops.c: Fix common/ includes.
11471         * utils.c: Fix common/ includes.
11472         * unittests/xml-utils-selftests.c: Fix common/ includes.
11473         * unittests/utils-selftests.c: Fix common/ includes.
11474         * unittests/unpack-selftests.c: Fix common/ includes.
11475         * unittests/tracepoint-selftests.c: Fix common/ includes.
11476         * unittests/style-selftests.c: Fix common/ includes.
11477         * unittests/string_view-selftests.c: Fix common/ includes.
11478         * unittests/scoped_restore-selftests.c: Fix common/ includes.
11479         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
11480         * unittests/scoped_fd-selftests.c: Fix common/ includes.
11481         * unittests/rsp-low-selftests.c: Fix common/ includes.
11482         * unittests/parse-connection-spec-selftests.c: Fix common/
11483         includes.
11484         * unittests/optional-selftests.c: Fix common/ includes.
11485         * unittests/offset-type-selftests.c: Fix common/ includes.
11486         * unittests/observable-selftests.c: Fix common/ includes.
11487         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
11488         * unittests/memrange-selftests.c: Fix common/ includes.
11489         * unittests/memory-map-selftests.c: Fix common/ includes.
11490         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
11491         * unittests/function-view-selftests.c: Fix common/ includes.
11492         * unittests/environ-selftests.c: Fix common/ includes.
11493         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
11494         * unittests/common-utils-selftests.c: Fix common/ includes.
11495         * unittests/cli-utils-selftests.c: Fix common/ includes.
11496         * unittests/array-view-selftests.c: Fix common/ includes.
11497         * ui-file.c: Fix common/ includes.
11498         * tui/tui-io.c: Fix common/ includes.
11499         * tracepoint.h: Fix common/ includes.
11500         * tracepoint.c: Fix common/ includes.
11501         * tracefile-tfile.c: Fix common/ includes.
11502         * top.h: Fix common/ includes.
11503         * top.c: Fix common/ includes.
11504         * thread.c: Fix common/ includes.
11505         * target/waitstatus.h: Fix common/ includes.
11506         * target/waitstatus.c: Fix common/ includes.
11507         * target.h: Fix common/ includes.
11508         * target.c: Fix common/ includes.
11509         * target-memory.c: Fix common/ includes.
11510         * target-descriptions.c: Fix common/ includes.
11511         * symtab.h: Fix common/ includes.
11512         * symfile.c: Fix common/ includes.
11513         * stap-probe.c: Fix common/ includes.
11514         * spu-linux-nat.c: Fix common/ includes.
11515         * sparc-nat.c: Fix common/ includes.
11516         * source.c: Fix common/ includes.
11517         * solib.c: Fix common/ includes.
11518         * solib-target.c: Fix common/ includes.
11519         * ser-unix.c: Fix common/ includes.
11520         * ser-tcp.c: Fix common/ includes.
11521         * ser-pipe.c: Fix common/ includes.
11522         * ser-base.c: Fix common/ includes.
11523         * selftest-arch.c: Fix common/ includes.
11524         * s12z-tdep.c: Fix common/ includes.
11525         * rust-exp.y: Fix common/ includes.
11526         * rs6000-aix-tdep.c: Fix common/ includes.
11527         * riscv-tdep.c: Fix common/ includes.
11528         * remote.c: Fix common/ includes.
11529         * remote-notif.h: Fix common/ includes.
11530         * remote-fileio.h: Fix common/ includes.
11531         * remote-fileio.c: Fix common/ includes.
11532         * regcache.h: Fix common/ includes.
11533         * regcache.c: Fix common/ includes.
11534         * record-btrace.c: Fix common/ includes.
11535         * python/python.c: Fix common/ includes.
11536         * python/py-type.c: Fix common/ includes.
11537         * python/py-inferior.c: Fix common/ includes.
11538         * progspace.h: Fix common/ includes.
11539         * producer.c: Fix common/ includes.
11540         * procfs.c: Fix common/ includes.
11541         * proc-api.c: Fix common/ includes.
11542         * printcmd.c: Fix common/ includes.
11543         * ppc-linux-nat.c: Fix common/ includes.
11544         * parser-defs.h: Fix common/ includes.
11545         * osdata.c: Fix common/ includes.
11546         * obsd-nat.c: Fix common/ includes.
11547         * nat/x86-linux.c: Fix common/ includes.
11548         * nat/x86-linux-dregs.c: Fix common/ includes.
11549         * nat/x86-dregs.h: Fix common/ includes.
11550         * nat/x86-dregs.c: Fix common/ includes.
11551         * nat/ppc-linux.c: Fix common/ includes.
11552         * nat/mips-linux-watch.h: Fix common/ includes.
11553         * nat/mips-linux-watch.c: Fix common/ includes.
11554         * nat/linux-waitpid.c: Fix common/ includes.
11555         * nat/linux-ptrace.h: Fix common/ includes.
11556         * nat/linux-ptrace.c: Fix common/ includes.
11557         * nat/linux-procfs.c: Fix common/ includes.
11558         * nat/linux-personality.c: Fix common/ includes.
11559         * nat/linux-osdata.c: Fix common/ includes.
11560         * nat/linux-namespaces.c: Fix common/ includes.
11561         * nat/linux-btrace.h: Fix common/ includes.
11562         * nat/linux-btrace.c: Fix common/ includes.
11563         * nat/fork-inferior.c: Fix common/ includes.
11564         * nat/amd64-linux-siginfo.c: Fix common/ includes.
11565         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
11566         * nat/aarch64-linux.c: Fix common/ includes.
11567         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
11568         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
11569         * namespace.h: Fix common/ includes.
11570         * mips-linux-tdep.c: Fix common/ includes.
11571         * minsyms.c: Fix common/ includes.
11572         * mi/mi-parse.h: Fix common/ includes.
11573         * mi/mi-main.c: Fix common/ includes.
11574         * mi/mi-cmd-env.c: Fix common/ includes.
11575         * memrange.h: Fix common/ includes.
11576         * memattr.c: Fix common/ includes.
11577         * maint.h: Fix common/ includes.
11578         * maint.c: Fix common/ includes.
11579         * main.c: Fix common/ includes.
11580         * machoread.c: Fix common/ includes.
11581         * location.c: Fix common/ includes.
11582         * linux-thread-db.c: Fix common/ includes.
11583         * linux-nat.c: Fix common/ includes.
11584         * linux-fork.c: Fix common/ includes.
11585         * inline-frame.c: Fix common/ includes.
11586         * infrun.c: Fix common/ includes.
11587         * inflow.c: Fix common/ includes.
11588         * inferior.h: Fix common/ includes.
11589         * inferior.c: Fix common/ includes.
11590         * infcmd.c: Fix common/ includes.
11591         * inf-ptrace.c: Fix common/ includes.
11592         * inf-child.c: Fix common/ includes.
11593         * ia64-linux-nat.c: Fix common/ includes.
11594         * i387-tdep.c: Fix common/ includes.
11595         * i386-tdep.c: Fix common/ includes.
11596         * i386-linux-tdep.c: Fix common/ includes.
11597         * i386-linux-nat.c: Fix common/ includes.
11598         * i386-go32-tdep.c: Fix common/ includes.
11599         * i386-fbsd-tdep.c: Fix common/ includes.
11600         * i386-fbsd-nat.c: Fix common/ includes.
11601         * guile/scm-type.c: Fix common/ includes.
11602         * guile/guile.c: Fix common/ includes.
11603         * go32-nat.c: Fix common/ includes.
11604         * gnu-nat.c: Fix common/ includes.
11605         * gdbthread.h: Fix common/ includes.
11606         * gdbarch-selftests.c: Fix common/ includes.
11607         * gdb_usleep.c: Fix common/ includes.
11608         * gdb_select.h: Fix common/ includes.
11609         * gdb_bfd.c: Fix common/ includes.
11610         * gcore.c: Fix common/ includes.
11611         * fork-child.c: Fix common/ includes.
11612         * findvar.c: Fix common/ includes.
11613         * fbsd-nat.c: Fix common/ includes.
11614         * event-top.c: Fix common/ includes.
11615         * event-loop.c: Fix common/ includes.
11616         * dwarf2read.c: Fix common/ includes.
11617         * dwarf2loc.c: Fix common/ includes.
11618         * dwarf2-frame.c: Fix common/ includes.
11619         * dwarf-index-cache.c: Fix common/ includes.
11620         * dtrace-probe.c: Fix common/ includes.
11621         * disasm-selftests.c: Fix common/ includes.
11622         * defs.h: Fix common/ includes.
11623         * csky-tdep.c: Fix common/ includes.
11624         * cp-valprint.c: Fix common/ includes.
11625         * cp-support.h: Fix common/ includes.
11626         * cp-support.c: Fix common/ includes.
11627         * corelow.c: Fix common/ includes.
11628         * completer.h: Fix common/ includes.
11629         * completer.c: Fix common/ includes.
11630         * compile/compile.c: Fix common/ includes.
11631         * compile/compile-loc2c.c: Fix common/ includes.
11632         * compile/compile-cplus-types.c: Fix common/ includes.
11633         * compile/compile-cplus-symbols.c: Fix common/ includes.
11634         * command.h: Fix common/ includes.
11635         * cli/cli-dump.c: Fix common/ includes.
11636         * cli/cli-cmds.c: Fix common/ includes.
11637         * charset.c: Fix common/ includes.
11638         * build-id.c: Fix common/ includes.
11639         * btrace.h: Fix common/ includes.
11640         * btrace.c: Fix common/ includes.
11641         * breakpoint.h: Fix common/ includes.
11642         * breakpoint.c: Fix common/ includes.
11643         * ax.h:
11644         (enum agent_op): Fix common/ includes.
11645         * ax-general.c (struct aop_map): Fix common/ includes.
11646         * ax-gdb.c: Fix common/ includes.
11647         * auxv.c: Fix common/ includes.
11648         * auto-load.c: Fix common/ includes.
11649         * arm-tdep.c: Fix common/ includes.
11650         * arch/riscv.c: Fix common/ includes.
11651         * arch/ppc-linux-common.c: Fix common/ includes.
11652         * arch/i386.c: Fix common/ includes.
11653         * arch/arm.c: Fix common/ includes.
11654         * arch/arm-linux.c: Fix common/ includes.
11655         * arch/arm-get-next-pcs.c: Fix common/ includes.
11656         * arch/amd64.c: Fix common/ includes.
11657         * arch/aarch64.c: Fix common/ includes.
11658         * arch/aarch64-insn.c: Fix common/ includes.
11659         * arch-utils.c: Fix common/ includes.
11660         * amd64-windows-tdep.c: Fix common/ includes.
11661         * amd64-tdep.c: Fix common/ includes.
11662         * amd64-sol2-tdep.c: Fix common/ includes.
11663         * amd64-obsd-tdep.c: Fix common/ includes.
11664         * amd64-nbsd-tdep.c: Fix common/ includes.
11665         * amd64-linux-tdep.c: Fix common/ includes.
11666         * amd64-linux-nat.c: Fix common/ includes.
11667         * amd64-fbsd-tdep.c: Fix common/ includes.
11668         * amd64-fbsd-nat.c: Fix common/ includes.
11669         * amd64-dicos-tdep.c: Fix common/ includes.
11670         * amd64-darwin-tdep.c: Fix common/ includes.
11671         * agent.c: Fix common/ includes.
11672         * ada-lang.h: Fix common/ includes.
11673         * ada-lang.c: Fix common/ includes.
11674         * aarch64-tdep.c: Fix common/ includes.
11675
11676 2019-01-25  Tom Tromey  <tom@tromey.com>
11677
11678         * common/create-version.sh: Use common/version.h.
11679
11680 2019-01-24  Pedro Alves  <palves@redhat.com>
11681
11682         * infrun.c (signal_stop, signal_print, signal_program)
11683         (signal_catch, signal_pass): Now arrays instead of pointers.
11684         (update_signals_program_target, do_target_resume)
11685         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
11686         * linux-nat.c (linux_nat_target::pass_signals)
11687         (linux_nat_target::create_inferior, linux_nat_target::attach):
11688         Adjust.
11689         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
11690         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
11691         * procfs.c (procfs_target::pass_signals): Adjust.
11692         * record-full.c (record_full_target::resume): Adjust.
11693         * remote.c (remote_target::pass_signals)
11694         (remote_target::program_signals): Adjust.
11695         * target-debug.h (target_debug_print_signals): Now takes a
11696         gdb::array_view as parameter.  Adjust.
11697         * target.h (target_ops) <pass_signals, program_signals>: Replace
11698         pointer and length parameters with gdb::array_view.
11699         (target_pass_signals, target_program_signals): Likewise.
11700         * target-delegates.c: Regenerate.
11701
11702 2019-01-24  Pedro Alves  <palves@redhat.com>
11703
11704         * common/forward-scope-exit.h
11705         (forward_scope_exit::forward_scope_exit): Pass arguments to
11706         m_bind_function directly, instead of creating a std::bind and
11707         copying that.
11708
11709 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
11710
11711         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11712         for static members.
11713         (pass_in_v_vfp_candidate): Likewise.
11714
11715 2019-01-23  Tom Tromey  <tom@tromey.com>
11716             Pedro Alves  <palves@redhat.com>
11717
11718         * regcache.c (class regcache_invalidator): Remove.
11719         (regcache::raw_write): Use make_scope_exit.
11720
11721 2019-01-23  Tom Tromey  <tom@tromey.com>
11722
11723         * ui-out.h (class ui_out_emit_type): Update comment.
11724
11725 2019-01-23  Tom Tromey  <tom@tromey.com>
11726
11727         * infrun.c (fetch_inferior_event): Update comment.
11728
11729 2019-01-23  Tom Tromey  <tom@tromey.com>
11730             Pedro Alves  <palves@redhat.com>
11731
11732         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
11733         parameter.
11734         (fetch_inferior_event): Use SCOPE_EXIT.
11735
11736
11737 2019-01-23  Tom Tromey  <tom@tromey.com>
11738             Pedro Alves  <palves@redhat.com>
11739
11740         * infrun.c (disable_thread_events): Delete.
11741         (stop_all_threads): Use SCOPE_EXIT.
11742
11743 2019-01-23  Tom Tromey  <tom@tromey.com>
11744             Pedro Alves  <palves@redhat.com>
11745
11746         * symfile.c: Include forward-scope-exit.h.
11747         (clear_symtab_users_cleanup): Replace forward declaration with
11748         a FORWARD_SCOPE_EXIT.
11749         (syms_from_objfile_1): Use the forward_scope_exit and
11750         gdb::optional instead of cleanup_function.
11751         (reread_symbols): Use the forward_scope_exit instead of
11752         cleanup_function.
11753         (clear_symtab_users_cleanup): Remove function.
11754
11755 2019-01-23  Tom Tromey  <tom@tromey.com>
11756             Pedro Alves  <palves@redhat.com>
11757
11758         * linux-nat.c: Include scope-exit.h.
11759         (cleanup_target_stop): Remove.
11760         (linux_nat_target::static_tracepoint_markers_by_strid): Use
11761         SCOPE_EXIT.
11762
11763 2019-01-23  Tom Tromey  <tom@tromey.com>
11764             Pedro Alves  <palves@redhat.com>
11765
11766         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
11767         (call_function_by_hand_dummy): Use SCOPE_EXIT.
11768
11769 2019-01-23  Tom Tromey  <tom@tromey.com>
11770             Andrew Burgess  <andrew.burgess@embecosm.com>
11771             Pedro Alves  <palves@redhat.com>
11772
11773         * infrun.c (fetch_inferior_event): Use scope_exit.
11774         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
11775         * top.c (execute_command): Use scope_exit.
11776         * breakpoint.c (bpstat_do_actions): Use scope_exit.
11777         * utils.c (do_bpstat_clear_actions_cleanup)
11778         (make_bpstat_clear_actions_cleanup): Remove.
11779
11780 2019-01-23  Tom Tromey  <tom@tromey.com>
11781             Pedro Alves  <palves@redhat.com>
11782
11783         * infrun.c: Include "common/scope-exit.h"
11784         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
11785         (wait_for_inferior): Use SCOPE_EXIT.
11786         (fetch_inferior_event): Use scope_exit.
11787
11788 2019-01-23  Tom Tromey  <tom@tromey.com>
11789             Pedro Alves  <palves@redhat.com>
11790
11791         * breakpoint.c (create_breakpoint): Remove cleanup.
11792
11793 2019-01-23  Tom Tromey  <tom@tromey.com>
11794             Andrew Burgess  <andrew.burgess@embecosm.com>
11795             Pedro Alves  <palves@redhat.com>
11796
11797 2019-01-23  Pedro Alves  <palves@redhat.com>
11798
11799         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
11800
11801 2019-01-23  Pedro Alves  <palves@redhat.com>
11802             Andrew Burgess  <andrew.burgess@embecosm.com>
11803
11804         * gdbthread.h: Include "common/forward-scope-exit.h".
11805         (scoped_finish_thread_state): Redefine custom class in terms of
11806         forward_scope_exit.
11807
11808 2019-01-23  Pedro Alves  <palves@redhat.com>
11809             Andrew Burgess  <andrew.burgess@embecosm.com>
11810
11811         * common/forward-scope-exit.h: New file.
11812
11813 2019-01-23  Pedro Alves  <palves@redhat.com>
11814             Andrew Burgess  <andrew.burgess@embecosm.com>
11815             Tom Tromey  <tom@tromey.com>
11816
11817         * common/scope-exit.h: New file.
11818
11819 2019-01-23  Pedro Alves  <palves@redhat.com>
11820
11821         * common/preprocessor.h (ESC): Rename to ...
11822         (ESC_PARENS): ... this.
11823         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
11824         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
11825
11826 2019-01-23  Tom Tromey  <tom@tromey.com>
11827
11828         * language.h (class scoped_switch_to_sym_language_if_auto):
11829         Initialize m_lang in both cases.
11830
11831 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
11832
11833         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
11834         with XCNEW.
11835
11836 2019-01-22  Tom Tromey  <tom@tromey.com>
11837
11838         * corelow.c: Do not include sys/file.h.
11839
11840 2019-01-22  Tom Tromey  <tom@tromey.com>
11841
11842         * tui/tui-wingeneral.h: Include gdb_curses.h.
11843
11844 2019-01-22  Tom Tromey  <tom@tromey.com>
11845
11846         * source-cache.h (class source_cache) <get_source_lines,
11847         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
11848
11849 2019-01-22  Tom Tromey  <tom@tromey.com>
11850
11851         * remote-fileio.h (struct remote_target): Declare.
11852
11853 2019-01-22  Tom Tromey  <tom@tromey.com>
11854
11855         * python/py-arch.c: Do not include py-ref.h.
11856         * python/py-bpevent.c: Do not include py-ref.h.
11857         * python/py-cmd.c: Do not include py-ref.h.
11858         * python/py-continueevent.c: Do not include py-ref.h.
11859         * python/py-event.h: Do not include py-ref.h.
11860         * python/py-evtregistry.c: Do not include py-ref.h.
11861         * python/py-finishbreakpoint.c: Do not include py-ref.h.
11862         * python/py-frame.c: Do not include py-ref.h.
11863         * python/py-framefilter.c: Do not include py-ref.h.
11864         * python/py-function.c: Do not include py-ref.h.
11865         * python/py-infevents.c: Do not include py-ref.h.
11866         * python/py-linetable.c: Do not include py-ref.h.
11867         * python/py-objfile.c: Do not include py-ref.h.
11868         * python/py-param.c: Do not include py-ref.h.
11869         * python/py-prettyprint.c: Do not include py-ref.h.
11870         * python/py-progspace.c: Do not include py-ref.h.
11871         * python/py-symbol.c: Do not include py-ref.h.
11872         * python/py-symtab.c: Do not include py-ref.h.
11873         * python/py-type.c: Do not include py-ref.h.
11874         * python/py-unwind.c: Do not include py-ref.h.
11875         * python/py-utils.c: Do not include py-ref.h.
11876         * python/py-value.c: Do not include py-ref.h.
11877         * python/py-varobj.c: Do not include py-ref.h.
11878         * python/py-xmethods.c: Do not include py-ref.h.
11879         * python/python.c: Do not include py-ref.h.
11880         * varobj.c: Do not include py-ref.h.
11881
11882 2019-01-22  Tom Tromey  <tom@tromey.com>
11883
11884         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
11885         keyword for bcache.
11886
11887 2019-01-22  Tom Tromey  <tom@tromey.com>
11888
11889         * compile/compile-cplus-types.c: Remove a comment by #include.
11890
11891 2019-01-22  Tom Tromey  <tom@tromey.com>
11892
11893         * compile/gcc-c-plugin.h: Include compile-internal.h.
11894
11895 2019-01-22  Tom Tromey  <tom@tromey.com>
11896
11897         * stabsread.c (EXTERN): Do not define.
11898         (symnum, next_symbol_text_func, processing_gcc_compilation)
11899         (within_function, global_sym_chain, global_stabs)
11900         (previous_stab_code, this_object_header_files)
11901         (n_this_object_header_files)
11902         (n_allocated_this_object_header_files): Define.
11903         * stabsread.h (EXTERN): Never define.  Use "extern".
11904
11905 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11906
11907         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
11908         history_value.
11909
11910 2019-01-21  Tom Tromey  <tom@tromey.com>
11911
11912         * ui-out.c: Fix includes.
11913         * tui/tui-source.c: Fix includes.
11914         * target.c: Fix includes.
11915         * remote.c: Fix includes.
11916         * regcache.c: Fix includes.
11917         * python/py-block.c: Fix includes.
11918         * printcmd.c: Fix includes.
11919         * or1k-tdep.c: Fix includes.
11920         * mi/mi-main.c: Fix includes.
11921         * m32r-tdep.c: Fix includes.
11922         * csky-tdep.c: Fix includes.
11923         * compile/compile-cplus-types.c: Fix includes.
11924         * cli/cli-interp.c: Fix includes.
11925
11926 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
11927
11928         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11929         for padding.
11930
11931 2019-01-16  Tom Tromey  <tom@tromey.com>
11932
11933         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
11934         earlier.
11935         (struct objfile) <msymbols_range>: Move from top level.
11936         <msymbols>: New method.
11937         (class objfile_msymbols): Remove.
11938         * symtab.c (default_collect_symbol_completion_matches_break_on):
11939         Update.
11940         * symmisc.c (dump_msymbols): Update.
11941         * stabsread.c (scan_file_globals): Update.
11942         * objc-lang.c (info_selectors_command, info_classes_command)
11943         (find_methods): Update.
11944         * minsyms.c (find_solib_trampoline_target): Update.
11945         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
11946         * coffread.c (coff_symfile_read): Update.
11947         * ada-lang.c (ada_lookup_simple_minsym)
11948         (ada_collect_symbol_completion_matches): Update.
11949
11950 2019-01-16  Tom Tromey  <tom@tromey.com>
11951
11952         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
11953         type.  Remove no-argument constructor.
11954         <iterator::operator++>: Simplify.
11955         <begin>: Update.
11956         <end>: Use minimal_symbol_count.
11957
11958 2019-01-16  Tom Tromey  <tom@tromey.com>
11959
11960         * objfiles.h (struct objfile) <psymtabs>: New method.
11961         (class objfile_psymtabs): Remove.
11962         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
11963         typedef.
11964         <range>: New method.
11965         (require_partial_symbols): Change return type.
11966         * psymtab.c (require_partial_symbols)
11967         (psym_expand_symtabs_matching): Update.
11968         * mdebugread.c (parse_partial_symbols): Update.
11969         * dbxread.c (dbx_end_psymtab): Update.
11970
11971 2019-01-15  Tom Tromey  <tom@tromey.com>
11972
11973         * symtab.c (lookup_objfile_from_block)
11974         (lookup_symbol_in_objfile_symtabs)
11975         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
11976         (find_line_symtab, info_sources_command)
11977         (default_collect_symbol_completion_matches_break_on)
11978         (make_source_files_completion_list): Update.
11979         * symmisc.c (print_objfile_statistics, dump_objfile)
11980         (maintenance_print_symbols, maintenance_info_symtabs)
11981         (maintenance_check_symtabs, maintenance_info_line_tables):
11982         Update.
11983         * source.c (select_source_symtab)
11984         (forget_cached_source_info_for_objfile): Update.
11985         * objfiles.h (class objfile_compunits): Remove.
11986         (struct objfile) <compunits_range>: New typedef.
11987         (compunits): New method.
11988         * objfiles.c (objfile_relocate1): Update.
11989         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11990         * maint.c (count_symtabs_and_blocks): Update.
11991         * linespec.c (iterate_over_all_matching_symtabs): Update.
11992         * cp-support.c (add_symbol_overload_list_qualified): Update.
11993         * coffread.c (coff_symtab_read): Update.
11994         * ada-lang.c (add_nonlocal_symbols)
11995         (ada_collect_symbol_completion_matches)
11996         (ada_add_global_exceptions): Update.
11997
11998 2019-01-15  Tom Tromey  <tom@tromey.com>
11999
12000         * progspace.h (program_space) <objfiles_safe_range>: New
12001         typedef.
12002         <objfiles_safe>: New method.
12003         * objfiles.h (class all_objfiles_safe): Remove.
12004         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
12005         * jit.c (jit_inferior_exit_hook): Update.
12006
12007 2019-01-17  Tom Tromey  <tom@tromey.com>
12008
12009         * progspace.h (program_space) <objfiles_range>: New typedef.
12010         <objfiles>: New method.
12011         <objfiles_head>: Rename from objfiles.
12012         (object_files): Update.
12013         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
12014         * guile/scm-pretty-print.c
12015         (ppscm_find_pretty_printer_from_objfiles): Update.
12016         * guile/scm-objfile.c (gdbscm_objfiles): Update.
12017         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
12018         Update.
12019         * python/py-progspace.c (pspy_get_objfiles): Update.
12020         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12021         Update.
12022         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12023         (objfpy_lookup_objfile_by_build_id): Update.
12024         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12025         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12026         Update.
12027         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12028         (expand_symtab_containing_pc, lookup_objfile_from_block)
12029         (lookup_static_symbol, basic_lookup_transparent_type)
12030         (find_pc_sect_compunit_symtab, find_symbol_at_address)
12031         (find_line_symtab, info_sources_command)
12032         (default_collect_symbol_completion_matches_break_on)
12033         (make_source_files_completion_list, find_main_name): Update.
12034         * symmisc.c (print_symbol_bcache_statistics)
12035         (print_objfile_statistics, maintenance_print_symbols)
12036         (maintenance_print_msymbols, maintenance_print_objfiles)
12037         (maintenance_info_symtabs, maintenance_check_symtabs)
12038         (maintenance_expand_symtabs, maintenance_info_line_tables):
12039         Update.
12040         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
12041         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
12042         (map_overlay_command, unmap_overlay_command)
12043         (simple_overlay_update, expand_symtabs_matching)
12044         (map_symbol_filenames): Update.
12045         * symfile-debug.c (set_debug_symfile): Update.
12046         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
12047         Update.
12048         * source.c (select_source_symtab, forget_cached_source_info):
12049         Update.
12050         * solib.c (solib_read_symbols): Update.
12051         * solib-spu.c (append_ocl_sos): Update.
12052         * psymtab.c (maintenance_print_psymbols)
12053         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
12054         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
12055         * printcmd.c (info_symbol_command): Update.
12056         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
12057         Update.
12058         * objfiles.h (class all_objfiles): Remove.
12059         * objfiles.c (have_partial_symbols, have_full_symbols)
12060         (have_minimal_symbols, qsort_cmp, update_section_map)
12061         (shared_objfile_contains_address_p)
12062         (default_iterate_over_objfiles_in_search_order): Update.
12063         * objc-lang.c (info_selectors_command, info_classes_command)
12064         (find_methods): Update.
12065         * minsyms.c (find_solib_trampoline_target): Update.
12066         * maint.c (maintenance_info_sections)
12067         (maintenance_translate_address, count_symtabs_and_blocks):
12068         Update.
12069         * main.c (captured_main_1): Update.
12070         * linux-thread-db.c (try_thread_db_load_from_pdir)
12071         (has_libpthread): Update.
12072         * linespec.c (iterate_over_all_matching_symtabs)
12073         (search_minsyms_for_name): Update.
12074         * jit.c (jit_find_objf_with_entry_addr): Update.
12075         * hppa-tdep.c (find_unwind_entry)
12076         (hppa_lookup_stub_minimal_symbol): Update.
12077         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
12078         Update.
12079         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12080         (elf_gnu_ifunc_resolve_by_got): Update.
12081         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
12082         * dwarf-index-write.c (save_gdb_index_command): Update.
12083         * cp-support.c (add_symbol_overload_list_qualified): Update.
12084         * breakpoint.c (create_overlay_event_breakpoint)
12085         (create_longjmp_master_breakpoint)
12086         (create_std_terminate_master_breakpoint)
12087         (create_exception_master_breakpoint): Update.
12088         * blockframe.c (find_pc_partial_function): Update.
12089         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
12090         (ada_collect_symbol_completion_matches)
12091         (ada_add_global_exceptions): Update.
12092
12093 2019-01-17  Tom Tromey  <tom@tromey.com>
12094
12095         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
12096         declare VEC.
12097         (solib_target_parse_libraries): Change return type.
12098         (library_list_start_segment, library_list_start_section)
12099         (library_list_end_library, library_list_start_library); Update.
12100         (solib_target_free_library_list): Remove.
12101         (solib_target_parse_libraries): Remove cleanup.  Change return
12102         type.
12103         (solib_target_current_sos): Update.
12104
12105 2019-01-17  Tom Tromey  <tromey@bapiya>
12106
12107         * valprint.c: Replace "the the" with "the".
12108         * symtab.c: Replace "the the" with "the".
12109         * solib.c: Replace "the the" with "the".
12110         * solib-dsbt.c: Replace "the the" with "the".
12111         * linespec.c: Replace "the the" with "the".
12112         * dwarf2loc.h: Replace "the the" with "the".
12113         * amd64-windows-tdep.c: Replace "the the" with "the".
12114         * aarch64-tdep.c: Replace "the the" with "the".
12115
12116 2019-01-16  Keith Seitz  <keiths@redhat.com>
12117
12118         PR gdb/23773
12119         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
12120         <builder>: Rename to ..
12121         <m_builder>: ... this and make private.
12122         (dwarf2_cu::get_builder): New method.  Change all users of
12123         `builder' to use this method.
12124         (dwarf2_start_symtab): Move to ...
12125         (dwarf2_cu::start_symtab): ... here.  Update all callers
12126         (setup_type_unit_groups): Move to ...
12127         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
12128         callers.
12129         (dwarf2_cu::reset_builder): New method.
12130         (process_full_compunit, process_full_type_unit): Use
12131         dwarf2_cu::reset_builder.
12132         (follow_die_offset): Record the ancestor CU if it is different
12133         from the followed DIE's CU.
12134         (follow_die_sig_1): Likewise.
12135
12136 2019-01-15  Tom Tromey  <tom@tromey.com>
12137
12138         * remote.c (class remote_state) <buf>: Now a char_vector.
12139         <buf_size>: Remove.
12140         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
12141         parameter.
12142         (remote_target::getpkt_or_notif_sane_1)
12143         (remote_target::getpkt_sane)
12144         (remote_target::getpkt_or_notif_sane): Likewise.
12145         (class remote_target) <putpkt>: New overload.
12146         (remote_target::read_frame): Change type of "buf_p".  Remove
12147         sizeof_p parameter.
12148         (packet_ok): New overload.
12149         (packet_check_result): New overload.
12150         Update all uses.
12151
12152 2019-01-14  Tom Tromey  <tom@tromey.com>
12153
12154         * remote-notif.c (handle_notification, remote_notif_ack)
12155         (remote_notif_parse): Make "buf" const.
12156         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
12157         const.
12158         (remote_notif_parse, remote_notif_ack, handle_notification):
12159         Likewise.
12160         * remote.c (remote_notif_stop_parse): Make "buf" const.
12161         (remote_target::remote_parse_stop_reply): Make "buf" const.
12162         (remote_notif_stop_ack): Make "buf" const.
12163
12164 2019-01-14  Tom Tromey  <tom@tromey.com>
12165
12166         * remote.c (remote_console_output): Make parameter const.
12167
12168 2019-01-14  Tom Tromey  <tom@tromey.com>
12169
12170         * target-debug.h (target_debug_print_signals): Constify.
12171         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
12172         * procfs.c (procfs_target::pass_signals): Update.
12173         * linux-nat.c (linux_nat_target::pass_signals): Update.
12174         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
12175         * target-delegates.c: Rebuild.
12176         * remote.c (remote_target::program_signals): Update.
12177         (remote_target::pass_signals): Update.
12178         * target.c (target_pass_signals): Constify argument.
12179         (target_program_signals): Likewise.
12180         * target.h (struct target_ops) <pass_signals, program_signals>:
12181         Constify argument.
12182         (target_pass_signals, target_program_signals): Constify argument.
12183
12184 2019-01-14  Tom Tromey  <tom@tromey.com>
12185
12186         PR tui/28819:
12187         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
12188
12189 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
12190
12191         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
12192         field.
12193         * rs6000-tdep.c: Include reggroups.h.
12194         (IS_V_ALIAS_PSEUDOREG): Define.
12195         (rs6000_register_name): Return names for the "vX" aliases.
12196         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
12197         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
12198         aliases.  Call default_register_reggroup_p for all other
12199         pseudo-registers.
12200         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
12201         New functions.
12202         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
12203         Handle "vX" aliases.
12204         (v_alias_pseudo_register_collect): New function.
12205         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
12206         (rs6000_gdbarch_init): Initialize "vX" aliases as
12207         pseudo-registers.  Restore registration of
12208         rs6000_pseudo_register_reggroup_p with
12209         set_tdesc_pseudo_register_reggroup_p.
12210
12211 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
12212
12213         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
12214         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
12215         set_gdbarch_num_pseudo_regs.
12216
12217 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12218
12219         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
12220         Remove arg prefixname, add do_set and do_show.
12221         Add member functions set_list and show_list.
12222         * cli/cli-style.c (class cli_style_option): Update accordingly.
12223         (style_set_list): Move to file scope.
12224         (style_show_list): Likewise.
12225         (set_style): Call help_list.
12226         (show_style): Call cmd_show_list.
12227         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
12228         Update to use the new macro.
12229
12230 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
12231
12232         * ada-lang.c (_initialize_ada_language): Expand the help text
12233         for the "catch exception" command.
12234
12235 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12236
12237         * symtab.c (matching_obj_sections): Initialize obj,
12238         declare it closer to its usage.
12239
12240 2019-01-10  Tom Tromey  <tom@tromey.com>
12241
12242         * thread-iter.h (inf_threads_iterator): Use next_iterator.
12243         (basic_inf_threads_range): Remove.
12244         (inf_threads_range, inf_non_exited_threads_range)
12245         (safe_inf_threads_range): Use next_adapter.
12246
12247 2019-01-10  Keith Seitz  <keiths@redhat.com>
12248
12249         PR gdb/23712
12250         PR symtab/23010
12251         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
12252         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
12253
12254 2019-01-10  Keith Seitz  <keiths@redhat.com>
12255
12256         PR gdb/23712
12257         PR symtab/23010
12258         * dictionary.c (pending_to_vector): Remove.
12259         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12260         Remove _1 suffix, replacing functions of the same name.  Update
12261         all callers.
12262         (dict_create_hashed, dict_create_hashed_expandable)
12263         (dict_create_linear, dict_create_linear_expandable, dict_free)
12264         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
12265         Make functions static.
12266
12267 2019-01-10  Keith Seitz  <keiths@redhat.com>
12268
12269         PR gdb/23712
12270         PR symtab/23010
12271         * dictionary.h (struct dictionary): Replace declaration with
12272         multidictionary.
12273         (dict_create_hashed, dict_create_hashed_expandable)
12274         (dict_create_linear, dict_create_linear_expandable)
12275         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
12276         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
12277         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
12278         taking multidictionary argument.
12279         [ALL_DICT_SYMBOLS]: Update for multidictionary.
12280         * block.h (struct block) <dict>: Change to multidictionary
12281         and rename `multidict'.
12282         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
12283         symmisc.c: Update all dictionary references to multidictionary.
12284
12285 2019-01-10  Keith Seitz  <keiths@redhat.com>
12286
12287         PR gdb/23712
12288         PR symtab/23010
12289         * dictionary.c: Include unordered_map.
12290         (pending_to_vector): New function.
12291         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12292         Rewrite the non-"_1" functions to take vector instead
12293         of linked list.
12294         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
12295         "new" _1 versions of the same name.
12296         (multidictionary): Define.
12297         (std::hash<enum language): New definition.
12298         (collate_pending_symbols_by_language, mdict_create_hashed)
12299         (mdict_create_hashed_expandable, mdict_create_linear)
12300         (mdict_create_linear_expandable, mdict_free)
12301         (find_language_dictionary, create_new_language_dictionary)
12302         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
12303         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
12304         (mdict_size, mdict_empty): New functions.
12305         * dictionary.h (mdict_iterator): Define.
12306
12307 2019-01-10  Pedro Alves  <palves@redhat.com>
12308
12309         * breakpoint.c (read_uploaded_action)
12310         (create_tracepoint_from_upload): Adjust to use
12311         gdb::unique_xmalloc_ptr.
12312         * ctf.c (ctf_write_uploaded_tp):
12313         (SET_ARRAY_FIELD): Use emplace_back.
12314         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
12315         * tracefile-tfile.c (tfile_write_uploaded_tp):
12316         * tracepoint.c (parse_tracepoint_definition): Adjust to use
12317         gdb::unique_xmalloc_ptr.
12318         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
12319         at_string, cond_string, cmd_strings>: Replace char pointers
12320         with gdb::unique_xmalloc_ptr.
12321
12322 2019-01-10  Pedro Alves  <palves@redhat.com>
12323
12324         * solib-target.c (library_list_start_library): Don't xstrdup name.
12325
12326 2019-01-10  Pedro Alves  <palves@redhat.com>
12327
12328         * mdebugread.c (parse_partial_symbols): Use
12329         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
12330
12331 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12332
12333         * linux-fork.c (scoped_switch_fork_info)
12334         <~scoped_switch_fork_info>: Fix incorrect variable name.
12335
12336 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12337
12338         * linux-fork.c (scoped_switch_fork_info)
12339         <scoped_switch_fork_info>: Make explicit.
12340         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
12341
12342 2019-01-10  Tom Tromey  <tom@tromey.com>
12343
12344         * objfiles.h (objfile::reset_psymtabs): Update.
12345         * objfiles.c (objfile::objfile): Update.
12346         * psymtab.h (psymtab_storage::obstack): Update.
12347         (psymtab_storage::m_obstack): Use gdb::optional.
12348         (class psymtab_storage): Update comment.  Remove objfile
12349         parameter.
12350         * psymtab.c (psymtab_storage::psymtab_storage): Update.
12351
12352 2019-01-10  Tom Tromey  <tom@tromey.com>
12353
12354         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
12355         <free_psymtabs>: Now private.
12356         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
12357         (allocate_psymtab): Use new method.
12358
12359 2019-01-10  Tom Tromey  <tom@tromey.com>
12360
12361         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
12362         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
12363         * mdebugread.c (parse_partial_symbols): Use
12364         allocate_dependencies.
12365         * dwarf2read.c (dwarf2_create_include_psymtab): Use
12366         allocate_dependencies.
12367         (process_psymtab_comp_unit_reader)
12368         (build_type_psymtab_dependencies): Likewise.
12369         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
12370
12371 2019-01-10  Tom Tromey  <tom@tromey.com>
12372
12373         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
12374         PSYMBOL_SET_LANGUAGE.
12375         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
12376
12377 2019-01-10  Tom Tromey  <tom@tromey.com>
12378
12379         * psymtab.h (psymtab_storage::obstack): New method.
12380         <m_obstack>: Rename from obstack; now private.
12381         * psymtab.c (psymtab_storage): Update.
12382         * dwarf2read.c (create_addrmap_from_index)
12383         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
12384         Update.
12385
12386 2019-01-10  Tom Tromey  <tom@tromey.com>
12387
12388         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
12389         * objfiles.h (objfile::reset_psymtabs): New method.
12390
12391 2019-01-10  Tom Tromey  <tom@tromey.com>
12392
12393         * symmisc.c (print_symbol_bcache_statistics): Update.
12394         (print_objfile_statistics): Update.
12395         * symfile.c (reread_symbols): Update.
12396         * psymtab.h (class psymtab_storage): New.
12397         * psymtab.c (psymtab_storage): New constructor.
12398         (~psymtab_storage): New destructor.
12399         (require_partial_symbols): Update.
12400         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
12401         (find_pc_sect_psymtab, find_pc_sect_psymbol)
12402         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
12403         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
12404         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
12405         (start_psymtab_common, end_psymtab_common)
12406         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
12407         (allocate_psymtab): Update.
12408         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
12409         Update.
12410         (dump_psymtab_addrmap, maintenance_print_psymbols)
12411         (maintenance_check_psymtabs): Update.
12412         (class objfile_psymtabs): Move to objfiles.h.
12413         * psympriv.h (discard_psymtab): Now inline.
12414         (psymtab_discarder::psymtab_discarder): Update.
12415         (psymtab_discarder::~psymtab_discarder): Update.
12416         (ALL_OBJFILE_PSYMTABS): Rewrite.
12417         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
12418         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
12419         Remove fields.
12420         <partial_symtabs>: New field.
12421         (class objfile_psymtabs): Move from psymtab.h.  Update.
12422         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
12423         psymbol_cache.
12424         (objfile::~objfile): Don't destroy psymbol_cache.
12425         * mdebugread.c (parse_partial_symbols): Update.
12426         * dwarf2read.c (create_addrmap_from_index)
12427         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
12428         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
12429         (add_partial_subprogram, dwarf2_ranges_read): Update.
12430         * dwarf-index-write.c (write_address_map)
12431         (write_one_signatured_type, recursively_write_psymbols)
12432         (class debug_names, class debug_names, write_psymtabs_to_index):
12433         Update.
12434
12435 2019-01-10  Tom Tromey  <tom@tromey.com>
12436
12437         * symtab.h (SYMBOL_SET_NAMES): Update.
12438         (symbol_set_names): Update.
12439         (MSYMBOL_SET_NAMES): Update.
12440         * symtab.c (symbol_set_names): Change argument to be an
12441         objfile_per_bfd_storage.
12442         * psymtab.c (add_psymbol_to_bcache): Update.
12443         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
12444
12445 2019-01-10  Tom Tromey  <tom@tromey.com>
12446
12447         * symtab.c (create_demangled_names_hash): Change argument to be an
12448         objfile_per_bfd_storage.
12449         (symbol_set_names): Update.
12450
12451 2019-01-10  Tom Tromey  <tom@tromey.com>
12452
12453         * xcoffread.c (xcoff_initial_scan): Unconditionally call
12454         init_psymbol_list.
12455         * psymtab.c (init_psymbol_list): Do nothing if already called.
12456         * psympriv.h (init_psymbol_list): Add comment.
12457         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
12458         init_psymbol_list.
12459         * dbxread.c (dbx_symfile_read): Unconditionally call
12460         init_psymbol_list.
12461
12462 2019-01-10  Tom Tromey  <tom@tromey.com>
12463
12464         * xcoffread.c (scan_xcoff_symtab): Update.
12465         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
12466         "where".
12467         * mdebugread.c (parse_partial_symbols)
12468         (handle_psymbol_enumerators): Update.
12469         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
12470         * dbxread.c (read_dbx_symtab): Update.
12471         * psympriv.h (psymbol_placement): New enum.
12472         (add_psymbol_to_list): Update.
12473
12474 2019-01-10  Tom Tromey  <tom@tromey.com>
12475
12476         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
12477         static_psymbols parameters.
12478         (scan_xcoff_symtab): Update.
12479         * psymtab.c (start_psymtab_common): Remove global_psymbols and
12480         static_psymbols parameters.
12481         * psympriv.h (start_psymtab_common): Update.
12482         * mdebugread.c (parse_partial_symbols): Update.
12483         * dwarf2read.c (create_partial_symtab): Update.
12484         * dbxread.c (read_dbx_symtab): Update.
12485         (start_psymtab): Remove global_psymbols and static_psymbols
12486         parameters.
12487
12488 2019-01-10  Tom Tromey  <tom@tromey.com>
12489
12490         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
12491         * psymtab.c (allocate_psymtab): Add comment.
12492         * psympriv.h (allocate_psymtab): Add comment.
12493         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
12494         initializations.
12495         * dbxread.c (dbx_end_psymtab): Remove some initializations.
12496
12497 2019-01-10  Tom Tromey  <tom@tromey.com>
12498
12499         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12500         Don't declare.
12501         * mipsread.c: Include mdebugread.h.
12502         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12503         Declare.
12504         * elfread.c: Include mdebugread.h.
12505
12506 2019-01-09  Tom Tromey  <tom@tromey.com>
12507
12508         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
12509         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
12510         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
12511         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
12512         (psym_lookup_symbol, psym_find_last_source_symtab)
12513         (psym_forget_cached_source_info, psym_print_stats)
12514         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
12515         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
12516         (psym_map_matching_symbols, psym_expand_symtabs_matching)
12517         (psym_find_compunit_symtab_by_address)
12518         (maintenance_print_psymbols, maintenance_info_psymtabs)
12519         (maintenance_check_psymtabs): Use ranged for.
12520         * psymtab.h (class objfile_psymtabs): New.
12521         (require_partial_symbols): Return objfile_psymtabs.
12522         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
12523
12524 2019-01-09  Tom Tromey  <tom@tromey.com>
12525
12526         * symfile.c (overlay_invalidate_all, find_pc_overlay)
12527         (find_pc_mapped_section, list_overlays_command)
12528         (map_overlay_command, unmap_overlay_command)
12529         (simple_overlay_update): Use all_objfiles.
12530         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
12531         * printcmd.c (info_symbol_command): Use all_objfiles.
12532         * objfiles.h (ALL_OBJSECTIONS): Remove.
12533         * maint.c (maintenance_translate_address): Use all_objfiles.
12534         * gcore.c (gcore_create_callback): Use all_objfiles.
12535         (objfile_find_memory_regions): Likewise.
12536
12537 2019-01-09  Tom Tromey  <tom@tromey.com>
12538
12539         * symtab.c (find_line_symtab, info_sources_command)
12540         (make_source_files_completion_list): Use objfile_compunits.
12541         * source.c (select_source_symtab): Use objfile_compunits.
12542         * objfiles.h (struct objfile): Update comment.
12543         (ALL_OBJFILES): Remove.
12544         (ALL_FILETABS): Remove.
12545         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
12546         objfile_compunits.
12547
12548 2019-01-09  Tom Tromey  <tom@tromey.com>
12549
12550         * symmisc.c (print_objfile_statistics, dump_objfile)
12551         (maintenance_print_symbols): Use compunit_filetabs.
12552         * source.c (forget_cached_source_info_for_objfile): Use
12553         compunit_filetabs.
12554         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
12555         (ALL_FILETABS): Use compunit_filetabs.
12556         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
12557         * coffread.c (coff_symtab_read): Use compunit_filetabs.
12558
12559 2019-01-09  Tom Tromey  <tom@tromey.com>
12560
12561         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
12562         (compunit_filetabs): New.
12563         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
12564         compunit_filetabs.
12565         (info_sources_command, make_source_files_completion_list): Remove
12566         declaration.
12567         * symmisc.c (print_objfile_statistics, dump_objfile)
12568         (maintenance_print_symbols): Remove declaration.
12569         (maintenance_info_symtabs): Use compunit_filetabs.
12570         (maintenance_info_line_tables): Likewise.
12571         * source.c (select_source_symtab): Change local variable name.
12572         (forget_cached_source_info_for_objfile): Remove declaration.
12573         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
12574         * objfiles.c (objfile_relocate1): Remove declaration.
12575         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12576         declaration.
12577         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
12578         * coffread.c (coff_symtab_read): Remove declaration.
12579         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
12580         compunit_filetabs.
12581
12582 2019-01-09  Tom Tromey  <tom@tromey.com>
12583
12584         * symtab.c (lookup_objfile_from_block)
12585         (find_pc_sect_compunit_symtab, search_symbols)
12586         (default_collect_symbol_completion_matches_break_on): Use
12587         objfile_compunits.
12588         * objfiles.h (ALL_COMPUNITS): Remove.
12589         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
12590         * cp-support.c (add_symbol_overload_list_qualified): Use
12591         objfile_compunits.
12592         * ada-lang.c (ada_collect_symbol_completion_matches)
12593         (ada_add_global_exceptions): Use objfile_compunits.
12594
12595 2019-01-09  Tom Tromey  <tom@tromey.com>
12596
12597         * source.c (select_source_symtab)
12598         (forget_cached_source_info_for_objfile): Remove declaration.
12599         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12600         declaration.
12601         * maint.c (count_symtabs_and_blocks): Remove declaration.
12602         * cp-support.c (add_symbol_overload_list_qualified): Remove
12603         declaration.
12604         * coffread.c (coff_symtab_read): Remove declaration.
12605         * symtab.c (lookup_symbol_in_objfile_symtabs)
12606         (basic_lookup_transparent_type_1): Use objfile_compunits.
12607         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
12608         (info_sources_command, search_symbols)
12609         (default_collect_symbol_completion_matches_break_on)
12610         (make_source_files_completion_list): Remove declaration.
12611         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
12612         (ada_collect_symbol_completion_matches)
12613         (ada_add_global_exceptions): Remove declaration.
12614         * linespec.c (iterate_over_all_matching_symtabs): Use
12615         objfile_compunits.
12616         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
12617         (class objfile_compunits): New.
12618         (ALL_COMPUNITS): Use objfile_compunits.
12619         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
12620         (maintenance_check_symtabs, maintenance_info_line_tables): Use
12621         objfile_compunits.
12622         * objfiles.c (objfile_relocate1): Use objfile_compunits.
12623
12624 2019-01-09  Tom Tromey  <tom@tromey.com>
12625
12626         * symtab.c (search_symbols)
12627         (default_collect_symbol_completion_matches_break_on): Use
12628         objfile_msymbols.
12629         * ada-lang.c (ada_lookup_simple_minsym)
12630         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
12631         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
12632         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
12633         objfile_msymbols.
12634         * coffread.c (coff_symfile_read): Use objfile_msymbols.
12635         * symmisc.c (dump_msymbols): Use objfile_msymbols.
12636         * objc-lang.c (find_methods): Use objfile_msymbols.
12637         (info_selectors_command, info_classes_command): Likewise.
12638         * stabsread.c (scan_file_globals): Use objfile_msymbols.
12639         * objfiles.h (class objfile_msymbols): New.
12640         (ALL_OBJFILE_MSYMBOLS): Remove.
12641         (ALL_MSYMBOLS): Remove.
12642
12643 2019-01-09  Tom Tromey  <tom@tromey.com>
12644
12645         * common/next-iterator.h (next_adapter): Add Iterator template
12646         parameter.
12647         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
12648         (class all_objfiles_safe): New.
12649         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
12650         * objfiles.c (put_objfile_before): Update comment.
12651         (add_separate_debug_objfile): Likewise.
12652         (free_all_objfiles): Use all_objfiles_safe.
12653         (objfile_purge_solibs): Likewise.
12654
12655 2019-01-09  Tom Tromey  <tom@tromey.com>
12656
12657         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12658         (expand_symtab_containing_pc, lookup_static_symbol)
12659         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
12660         (find_symbol_at_address, find_line_symtab, find_main_name): Use
12661         all_objfiles.
12662         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
12663         * breakpoint.c (create_overlay_event_breakpoint)
12664         (create_longjmp_master_breakpoint)
12665         (create_std_terminate_master_breakpoint)
12666         (create_exception_master_breakpoint): Use all_objfiles.
12667         * linux-thread-db.c (try_thread_db_load_from_pdir)
12668         (has_libpthread): Use all_objfiles.
12669         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
12670         * linespec.c (iterate_over_all_matching_symtabs)
12671         (search_minsyms_for_name): Use all_objfiles.
12672         * maint.c (maintenance_info_sections): Use all_objfiles.
12673         * main.c (captured_main_1): Use all_objfiles.
12674         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
12675         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
12676         * guile/scm-pretty-print.c
12677         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
12678         * solib-spu.c (append_ocl_sos): Use all_objfiles.
12679         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
12680         (maintenance_print_msymbols): Use all_objfiles.
12681         * source.c (select_source_symtab): Use all_objfiles.
12682         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
12683         * symfile.c (remove_symbol_file_command)
12684         (expand_symtabs_matching, map_symbol_filenames): Use
12685         all_objfiles.
12686         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
12687         all_objfiles.
12688         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
12689         * objc-lang.c (find_methods): Use all_objfiles.
12690         * objfiles.c (have_partial_symbols, have_full_symbols)
12691         (have_minimal_symbols, qsort_cmp)
12692         (default_iterate_over_objfiles_in_search_order): Use
12693         all_objfiles.
12694         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
12695         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
12696         (maintenance_check_psymtabs): Use all_objfiles.
12697         (ALL_PSYMTABS): Remove.
12698         * compile/compile-object-run.c (do_module_cleanup): Use
12699         all_objfiles.
12700         * blockframe.c (find_pc_partial_function): Use all_objfiles.
12701         * cp-support.c (add_symbol_overload_list_qualified): Use
12702         all_objfiles.
12703         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12704         Use all_objfiles.
12705         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
12706         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
12707         all_objfiles.
12708         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12709         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
12710         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12711         Uses all_objfiles.
12712         * solib.c (solib_read_symbols): Use all_objfiles
12713
12714 2019-01-09  Tom Tromey  <tom@tromey.com>
12715
12716         * probe.c (parse_probes_in_pspace): Use all_objfiles.
12717         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
12718         all_objfiles.
12719         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
12720         * symmisc.c (print_symbol_bcache_statistics)
12721         (print_objfile_statistics, maintenance_print_objfiles)
12722         (maintenance_info_symtabs, maintenance_check_symtabs)
12723         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
12724         all_objfiles.
12725         * source.c (forget_cached_source_info): Use all_objfiles.
12726         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
12727         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12728         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
12729         * objfiles.c (update_section_map): Use all_objfiles.
12730         (shared_objfile_contains_address_p): Likewise.
12731         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
12732         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
12733
12734 2019-01-09  Tom Tromey  <tom@tromey.com>
12735
12736         * common/next-iterator.h: New file.
12737         * objfiles.h (class all_objfiles): New.
12738         (struct objfile_iterator): New.
12739
12740 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12741
12742         * NEWS: Move the description of the changed "frame", "select-frame",
12743          and "info frame" commands to the Changed commands section.
12744
12745 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
12746
12747         * gdbtypes.c (check_stub_method_group): Remove handling of old
12748         mangling schemes.
12749         * linespec.c (find_methods): Likewise.
12750         * stabsread.c (read_member_functions): Likewise.
12751         * valops.c (search_struct_method): Likewise.
12752         (value_struct_elt_for_reference): Likewise.
12753         * NEWS: Mention this change.
12754
12755 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
12756
12757         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
12758         print_source_lines.
12759         * source.c (print_source_lines_base): Update line number check.
12760         (print_source_lines): New function.
12761         (source_lines_range::source_lines_range): New function.
12762         * source.h (class source_lines_range): New class.
12763         (print_source_lines): New declaration.
12764
12765 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12766
12767         * linespec.c (linespec_state_destructor): Free self->canonical_names.
12768
12769 2019-01-08  Tom Tromey  <tom@tromey.com>
12770             Simon Marchi  <simon.marchi@ericsson.com>
12771
12772         PR gdb/24060
12773         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
12774         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
12775         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12776         * f-exp.y (DOLLAR_VARIABLE): Likewise.
12777         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
12778         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12779
12780 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12781
12782         * source.c (select_source_symtab): Move header comment to
12783         declaration in source.h.
12784         (forget_cached_source_info_for_objfile): Likewise.
12785         (forget_cached_source_info): Likewise.
12786         (identify_source_line): Likewise.
12787         * source.h (identify_source_line): Move declaration from symtab.h
12788         and add comment from source.c
12789         (print_source_lines): Likewise.
12790         (forget_cached_source_info_for_objfile): Likewise.
12791         (forget_cached_source_info): Likewise.
12792         (select_source_symtab): Likewise.
12793         (enum print_source_lines_flag): Move definition from symtab.h.
12794         * symtab.h (identify_source_line): Move declaration to source.h.
12795         (print_source_lines): Likewise.
12796         (forget_cached_source_info_for_objfile): Likewise.
12797         (forget_cached_source_info): Likewise.
12798         (select_source_symtab): Likewise.
12799         (enum print_source_lines_flag): Move definition to source.h.
12800         * tui/tui-hooks.c: Add 'source.h' include.
12801
12802 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12803
12804         * source.c (print_source_lines_base): Handle requests to print
12805         reverse line number sequences, and guard against empty lines
12806         string.
12807
12808 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12809
12810         * source.c (print_source_lines_base): Fix skip of '\r' if next
12811         character is '\n'.
12812
12813 2019-01-06  Tom Tromey  <tom@tromey.com>
12814
12815         * c-exp.y (struct c_parse_state) <macro_original_text,
12816         expansion_obstack>: New member.
12817         (macro_original_text, expansion_obstack): Remove globals.
12818         (scan_macro_expansion, scanning_macro_expansion)
12819         (finished_macro_expansion): Update.
12820         (scan_macro_cleanup): Remove.
12821         (yylex, c_parse): Update.
12822
12823 2019-01-06  Tom Tromey  <tom@tromey.com>
12824
12825         * c-exp.y (struct c_parse_state) <strings>: New member.
12826         (operator_stoken): Update.
12827
12828 2019-01-06  Tom Tromey  <tom@tromey.com>
12829
12830         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
12831         (union type_stack_elt) <typelist_val>: Now a pointer to
12832         std::vector.
12833         (type_stack_cleanup): Don't declare.
12834         (push_typelist): Update.
12835         * parse.c (pop_typelist): Return a std::vector.
12836         (push_typelist): Take a std::vector.
12837         (follow_types): Update.  Do not free args.
12838         (type_stack_cleanup): Remove.
12839         * c-exp.y (struct c_parse_state): New.
12840         (cpstate): New global.
12841         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
12842         (nonempty_typelist): Update.
12843         (func_mod): Create a new vector.
12844         (c_parse): Create a c_parse_state.
12845         (check_parameter_typelist): Do not delete params.
12846         (function_method): Update.  Do not delete type_list.
12847
12848 2019-01-06  Tom Tromey  <tom@tromey.com>
12849
12850         PR gdb/28155:
12851         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
12852         check_typedef.
12853         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
12854         (print_return_value): Likewise.
12855
12856 2019-01-05  Tom Tromey  <tom@tromey.com>
12857
12858         * contrib/cleanup_check.py: Remove.
12859         * contrib/gcc-with-excheck: Remove.
12860         * contrib/exsummary.py: Remove.
12861         * contrib/excheck.py: Remove.
12862
12863 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
12864
12865         * thread.c (delete_thread_1): Add gdb_assert that THR is not
12866         NULL. Initialize tpprev to NULL instead of assigning it
12867         to NULL on the next statement.
12868         * windows-nat.c (windows_delete_thread): Remove check for
12869         main_thread_id before printing thread exit notifications.
12870         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
12871         Remove thread ID check against main_thread_id.
12872         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
12873         windows_delete_thread.
12874         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
12875
12876 2019-01-04  Tom Tromey  <tom@tromey.com>
12877
12878         * compile/compile.c (_initialize_compile): Use upper case for
12879         metasyntactic variables.
12880         * symmisc.c (_initialize_symmisc): Use upper case for
12881         metasyntactic variables.
12882         * psymtab.c (_initialize_psymtab): Use upper case for
12883         metasyntactic variables.
12884         * demangle.c (demangle_command): Use upper case for metasyntactic
12885         variables.
12886         (_initialize_demangler): Likewise.
12887         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
12888         variables.
12889
12890 2019-01-03  Tom Tromey  <tom@tromey.com>
12891
12892         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
12893
12894 2019-01-03  Tom Tromey  <tom@tromey.com>
12895
12896         * python/py-symtab.c (salpy_str): Update.
12897         (struct salpy_sal_object) <symtab>: Now a PyObject.
12898         (salpy_dealloc): Update.
12899         (del_objfile_sal): Use gdbpy_ref.
12900
12901 2019-01-03  Tom Tromey  <tom@tromey.com>
12902
12903         * python/py-type.c (convert_field): Use new_reference.  Return
12904         gdbpy_ref.
12905         (make_fielditem): Return gdbpy_ref.
12906         (typy_fields): Update.
12907         (typy_getitem): Update.
12908         (field_name): Return gdbpy_ref.  Use new_reference.
12909         (typy_iterator_iternext): Update.
12910
12911 2019-01-03  Tom Tromey  <tom@tromey.com>
12912
12913         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
12914
12915 2019-01-03  Tom Tromey  <tom@tromey.com>
12916
12917         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
12918         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
12919         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
12920         (pspy_set_frame_filters, pspy_set_frame_unwinders)
12921         (pspy_set_type_printers): Likewise.
12922         * python/py-function.c (fnpy_init): Use gdbpy_ref.
12923         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
12924         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
12925         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
12926         (objfpy_set_type_printers): Likewise.
12927
12928 2019-01-03  Tom Tromey  <tom@tromey.com>
12929
12930         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
12931         (gdbpy_print_stack): Use gdbpy_err_fetch.
12932         * python/python-internal.h (class gdbpy_err_fetch): New class.
12933         (class gdbpy_enter) <m_error_type, m_error_value,
12934         m_error_traceback>: Remove.
12935         <m_error>: New member.
12936         (gdbpy_exception_to_string): Don't declare.
12937         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
12938         * python/py-value.c (convert_value_from_python): Use
12939         gdbpy_err_fetch.
12940         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
12941         gdbpy_exception_to_string.
12942         (gdbpy_handle_exception): Use gdbpy_err_fetch.
12943         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
12944         gdbpy_err_fetch.
12945
12946 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12947
12948         * linux-nat.c (delete_lwp_cleanup): Delete.
12949         (struct lwp_deleter): New struct.
12950         (lwp_info_up): New typedef.
12951         (linux_nat_target::follow_fork): Delete cleanup, and make use of
12952         lwp_info_up.
12953
12954 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12955
12956         * linux-fork.c (class scoped_switch_fork_info): New class.
12957         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
12958
12959 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12960
12961         * valops.c (find_overload_match): Remove use of null_cleanup, and
12962         calls to do_cleanups.
12963
12964 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12965
12966         * compile/compile-cplus-types.c
12967         (compile_cplus_instance::decl_name): Handle changes to
12968         cp_func_name.
12969         * cp-support.c (cp_func_name): Update header comment, update
12970         return type.
12971         * cp-support.h (cp_func_name): Update return type in declaration.
12972         * valops.c (find_overload_match): Move temp_func local to top
12973         level of function and change its type.  Use temp_func to hold and
12974         delete temporary string obtained from cp_func_name.
12975
12976 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12977
12978         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
12979         gdb::char_vector, remove cleanup, and update uses of `msg`.
12980
12981 2019-01-03  Jim Wilson  <jimw@sifive.com>
12982
12983         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
12984
12985 2019-01-02  Tom Tromey  <tom@tromey.com>
12986
12987         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
12988         (tdesc_parse_xml): Remove cleanups.
12989         * target-descriptions.h (make_cleanup_free_target_description):
12990         Don't declare.
12991         (target_desc_deleter): New struct.
12992         (target_desc_up): New typedef.
12993         * target-descriptions.c (target_desc_deleter::operator()): Rename
12994         from free_target_description.
12995         (make_cleanup_free_target_description): Remove.
12996
12997 2019-01-02  Tom Tromey  <tom@tromey.com>
12998
12999         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
13000         constructor, destructor.
13001         (linespec_parser): Remove typedef.
13002         (~linespec_parser): Rename from linespec_parser_delete.
13003         (linespec_lex_to_end, linespec_complete_label)
13004         (linespec_complete): Update.
13005         (decode_line_full): Remove cleanups.
13006         (decode_line_1): Update.
13007
13008 2019-01-02  Tom Tromey  <tom@tromey.com>
13009
13010         * python/python-internal.h (inferior_to_inferior_object): Change
13011         return type.
13012         * python/py-exitedevent.c (create_exited_event_object): Update.
13013         * python/py-inferior.c (inferior_to_inferior_object): Return
13014         gdbpy_ref.
13015         (python_new_inferior, python_inferior_deleted)
13016         (thread_to_thread_object, delete_thread_object)
13017         (build_inferior_list, gdbpy_selected_inferior): Update.
13018         * python/py-infthread.c (create_thread_object): Update.  Also fail
13019         if inferior_to_inferior_object fails.
13020
13021 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
13022
13023         * inferior.h (class inferior) <displaced_step_state>: New field.
13024         * infrun.h (struct displaced_step_state): Move here from
13025         infrun.c.  Initialize fields, add constructor.
13026         <inf>: Remove field.
13027         <reset>: New method.
13028         * infrun.c (struct displaced_step_inferior_state): Move to
13029         infrun.h.
13030         (displaced_step_inferior_states): Remove.
13031         (get_displaced_stepping_state): Adust.
13032         (displaced_step_in_progress_any_inferior): Adjust.
13033         (displaced_step_in_progress_thread): Adjust.
13034         (displaced_step_in_progress): Adjust.
13035         (add_displaced_stepping_state): Remove.
13036         (get_displaced_step_closure_by_addr): Adjust.
13037         (remove_displaced_stepping_state): Remove.
13038         (infrun_inferior_exit): Call displaced_step_state.reset.
13039         (use_displaced_stepping): Don't check for NULL.
13040         (displaced_step_prepare_throw): Call
13041         get_displaced_stepping_state.
13042         (displaced_step_fixup): Don't check for NULL.
13043         (prepare_for_detach): Don't check for NULL.
13044
13045 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13046
13047         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
13048          in case of call that did not complete.
13049
13050 2019-01-02  Andrey Utkin  <autkin@undo.io>
13051
13052         * symfile.c (find_separate_debug_file): Fix search of debug files for
13053         remote debuggee.
13054
13055 2019-01-02  Tom Tromey  <tom@tromey.com>
13056
13057         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
13058         indentation.
13059         * python/py-frame.c (frapy_older): Remove cast.
13060         (frapy_newer): Likewise.
13061         * python/py-breakpoint.c (local_setattro): Remove cast.
13062         * python/py-arch.c (archpy_name): Remove local variable.
13063         * python/py-type.c (gdbpy_lookup_type): Remove cast.
13064
13065 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
13066
13067         * unittests/basic_string_view/element_access/char/empty.cc:
13068         Fix year range in copyright header.
13069
13070 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
13071
13072         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
13073         Delete.
13074         <operator==>: Update with for removed field.
13075         <hash>: Likewise.
13076         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
13077         <isa_features>: ...this.
13078         <abi_features>: New field.
13079         (riscv_isa_flen): Update comment.
13080         (riscv_abi_xlen): New declaration.
13081         (riscv_abi_flen): New declaration.
13082         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
13083         isa_features.
13084         (riscv_abi_xlen): New function.
13085         (riscv_isa_flen): Update to get answer from isa_features.
13086         (riscv_abi_flen): New function.
13087         (riscv_has_fp_abi): Update to get answer from abi_features.
13088         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
13089         xlen and flen.
13090         (riscv_call_info) <xlen, flen>: Update comment.
13091         (riscv_call_arg_struct): Remove invalid assertions
13092         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
13093         is removed.
13094         (riscv_gdbarch_init): Gather isa features and abi features
13095         separately, ensure both match on the gdbarch when reusing an old
13096         gdbarch.  Relax an error check to allow 32-bit abi float to run on
13097         a target with 64-bit float hardware.
13098
13099 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13100
13101         * source.c (search_command_helper): Stop reverse search
13102         when line 1 has been searched.
13103
13104 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13105
13106         * record-full.c (record_full_base_target::close): Rewrite
13107         record_full_core_buf_list free logic.
13108
13109 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13110
13111         * break-catch-syscall.c (print_one_catch_syscall): xfree
13112         the last text.
13113
13114 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13115
13116         * top.c (print_gdb_version): Update Copyright year in version
13117         message.
13118
13119 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13120
13121         Update copyright year range in all GDB files.
13122
13123 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
13124
13125         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
13126
13127 For older changes see ChangeLog-2018.
13128 \f
13129 Local Variables:
13130 mode: change-log
13131 left-margin: 8
13132 fill-column: 74
13133 version-control: never
13134 coding: utf-8
13135 End:
13136