gdb/ChangeLog

   1 2020-04-21  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
   2
   3         * infrun.c (displaced_step_fixup): Switch to the event_thread
   4         before calling displaced_step_restore, not after.
   5
   6 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
   7
   8         * record-btrace.c (record_btrace_enable_warn): Ignore thread if
   9         its inferior is not recorded by us.
  10         (record_btrace_target_open): Replace call to
  11         all_non_exited_threads () with call to current_inferior
  12         ()->non_exited_threads ().
  13         (record_btrace_target::stop_recording): Likewise.
  14         (record_btrace_target::close): Likewise.
  15         (record_btrace_target::wait): Likewise.
  16         (record_btrace_target::record_stop_replaying): Likewise.
  17
  18 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
  19
  20         * btrace.c (btrace_enable): Throw an error on double enables and
  21         when enabling recording fails.
  22         (btrace_disable): Throw an error if the thread is not recorded.
  23
  24 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
  25
  26         * record-btrace.c (record_btrace_target::fetch_registers): Forward
  27         request if we do not have a thread_info.
  28
  29 2020-04-21  Tom de Vries  <tdevries@suse.de>
  30
  31         PR gdb/25471
  32         * thread.c
  33         (scoped_restore_current_thread::scoped_restore_current_thread): Catch
  34         exception in get_frame_id.
  35
  36 2020-04-20  Tom Tromey  <tromey@adacore.com>
  37
  38         * python/python.c (struct gdbpy_event): Mark move constructor as
  39         noexcept.
  40         * python/py-tui.c (class gdbpy_tui_window_maker): Mark move
  41         constructor as noexcept.
  42         * completer.h (struct completion_result): Mark move constructor as
  43         noexcept.
  44         * completer.c (completion_result::completion_result): Use
  45         initialization style.  Don't call reset_match_list.
  46
  47 2020-04-20  Mihails Strasuns  <mihails.strasuns@intel.com>
  48
  49         * MAINTAINERS (Write After Approval): Add myself.
  50
  51 2020-04-18  Tom Tromey  <tom@tromey.com>
  52
  53         * windows-tdep.c (init_w32_command_list)
  54         (w32_prefix_command_valid): Restore.
  55         (_initialize_windows_tdep): Call init_w32_command_list.
  56
  57 2020-04-18  Tom Tromey  <tom@tromey.com>
  58
  59         * xcoffread.c (enter_line_range, scan_xcoff_symtab): Update.
  60         * value.c (value_fn_field): Update.
  61         * valops.c (find_function_in_inferior)
  62         (value_allocate_space_in_inferior): Update.
  63         * tui/tui-winsource.c (tui_update_source_windows_with_line):
  64         Update.
  65         * tui/tui-source.c (tui_source_window::set_contents): Update.
  66         * symtab.c (lookup_global_or_static_symbol)
  67         (find_function_start_sal_1, skip_prologue_sal)
  68         (print_msymbol_info, find_gnu_ifunc, symbol_arch): Update.
  69         * symmisc.c (dump_msymbols, dump_symtab_1)
  70         (maintenance_print_one_line_table): Update.
  71         * symfile.c (init_entry_point_info, section_is_mapped)
  72         (list_overlays_command, simple_read_overlay_table)
  73         (simple_overlay_update_1): Update.
  74         * stap-probe.c (handle_stap_probe): Update.
  75         * stabsread.c (dbx_init_float_type, define_symbol)
  76         (read_one_struct_field, read_enum_type, read_range_type): Update.
  77         * source.c (info_line_command): Update.
  78         * python/python.c (gdbpy_source_objfile_script)
  79         (gdbpy_execute_objfile_script): Update.
  80         * python/py-type.c (save_objfile_types): Update.
  81         * python/py-objfile.c (py_free_objfile): Update.
  82         * python/py-inferior.c (python_new_objfile): Update.
  83         * psymtab.c (psym_find_pc_sect_compunit_symtab, dump_psymtab)
  84         (dump_psymtab_addrmap_1, maintenance_info_psymtabs)
  85         (maintenance_check_psymtabs): Update.
  86         * printcmd.c (info_address_command): Update.
  87         * objfiles.h (struct objfile) <arch>: New method, from
  88         get_objfile_arch.
  89         (get_objfile_arch): Don't declare.
  90         * objfiles.c (get_objfile_arch): Remove.
  91         (filter_overlapping_sections): Update.
  92         * minsyms.c (msymbol_is_function): Update.
  93         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines)
  94         (output_nondebug_symbol): Update.
  95         * mdebugread.c (parse_symbol, basic_type, parse_partial_symbols)
  96         (mdebug_expand_psymtab): Update.
  97         * machoread.c (macho_add_oso_symfile): Update.
  98         * linux-tdep.c (linux_infcall_mmap, linux_infcall_munmap):
  99         Update.
 100         * linux-fork.c (checkpoint_command): Update.
 101         * linespec.c (convert_linespec_to_sals): Update.
 102         * jit.c (finalize_symtab): Update.
 103         * infrun.c (insert_exception_resume_from_probe): Update.
 104         * ia64-tdep.c (ia64_find_unwind_table): Update.
 105         * hppa-tdep.c (internalize_unwinds): Update.
 106         * gdbtypes.c (get_type_arch, init_float_type, objfile_type):
 107         Update.
 108         * gcore.c (call_target_sbrk): Update.
 109         * elfread.c (record_minimal_symbol, elf_symtab_read)
 110         (elf_rel_plt_read, elf_gnu_ifunc_record_cache)
 111         (elf_gnu_ifunc_resolve_by_got): Update.
 112         * dwarf2/read.c (create_addrmap_from_index)
 113         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
 114         (read_debug_names_from_section)
 115         (process_psymtab_comp_unit_reader, add_partial_symbol)
 116         (add_partial_subprogram, process_full_comp_unit)
 117         (read_file_scope, read_func_scope, read_lexical_block_scope)
 118         (read_call_site_scope, dwarf2_ranges_read)
 119         (dwarf2_record_block_ranges, dwarf2_add_field)
 120         (mark_common_block_symbol_computed, read_tag_pointer_type)
 121         (read_tag_string_type, dwarf2_init_float_type)
 122         (dwarf2_init_complex_target_type, read_base_type)
 123         (partial_die_info::read, partial_die_info::read)
 124         (read_attribute_value, dwarf_decode_lines_1, new_symbol)
 125         (dwarf2_fetch_die_loc_sect_off): Update.
 126         * dwarf2/loc.c (dwarf2_find_location_expression)
 127         (class dwarf_evaluate_loc_desc, rw_pieced_value)
 128         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval)
 129         (dwarf2_loc_desc_get_symbol_read_needs)
 130         (locexpr_describe_location_piece, locexpr_describe_location_1)
 131         (loclist_describe_location): Update.
 132         * dwarf2/index-write.c (write_debug_names): Update.
 133         * dwarf2/frame.c (dwarf2_build_frame_info): Update.
 134         * dtrace-probe.c (dtrace_process_dof): Update.
 135         * dbxread.c (read_dbx_symtab, dbx_end_psymtab)
 136         (process_one_symbol): Update.
 137         * ctfread.c (ctf_init_float_type, read_base_type): Update.
 138         * coffread.c (coff_symtab_read, enter_linenos, decode_base_type)
 139         (coff_read_enum_type): Update.
 140         * cli/cli-cmds.c (edit_command, list_command): Update.
 141         * buildsym.c (buildsym_compunit::finish_block_internal): Update.
 142         * breakpoint.c (create_overlay_event_breakpoint)
 143         (create_longjmp_master_breakpoint)
 144         (create_std_terminate_master_breakpoint)
 145         (create_exception_master_breakpoint, get_sal_arch): Update.
 146         * block.c (block_gdbarch): Update.
 147         * annotate.c (annotate_source_line): Update.
 148
 149 2020-04-17  Tom Tromey  <tromey@adacore.com>
 150
 151         * auto-load.c (show_auto_load_cmd): Remove.
 152         (auto_load_show_cmdlist_get): Use add_show_prefix_cmd.
 153         * arc-tdep.c (_initialize_arc_tdep): Use add_show_prefix_cmd.
 154         (maintenance_print_arc_command): Remove.
 155         * tui/tui-win.c (tui_command): Remove.
 156         (tui_get_cmd_list): Use add_basic_prefix_cmd.
 157         * tui/tui-layout.c (tui_layout_command): Remove.
 158         (_initialize_tui_layout): Use add_basic_prefix_cmd.
 159         * python/python.c (user_set_python, user_show_python): Remove.
 160         (_initialize_python): Use add_basic_prefix_cmd,
 161         add_show_prefix_cmd.
 162         * guile/guile.c (set_guile_command, show_guile_command): Remove.
 163         (install_gdb_commands): Use add_basic_prefix_cmd,
 164         add_show_prefix_cmd.
 165         (info_guile_command): Remove.
 166         * dwarf2/read.c (set_dwarf_cmd, show_dwarf_cmd): Remove.
 167         (_initialize_dwarf2_read): Use add_basic_prefix_cmd,
 168         add_show_prefix_cmd.
 169         * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
 170         Remove do_set and do_show parameters.
 171         * cli/cli-style.c (set_style, show_style): Remove.
 172         (_initialize_cli_style): Use add_basic_prefix_cmd,
 173         add_show_prefix_cmd.
 174         (cli_style_option::add_setshow_commands): Remove do_set and
 175         do_show parameters.
 176         (cli_style_option::add_setshow_commands): Use
 177         add_basic_prefix_cmd, add_show_prefix_cmd.
 178         (STYLE_ADD_SETSHOW_COMMANDS): Remove macro.
 179         (set_style_name): Remove.
 180         * cli/cli-dump.c (dump_command, append_command): Remove.
 181         (srec_dump_command, ihex_dump_command, verilog_dump_command)
 182         (tekhex_dump_command, binary_dump_command)
 183         (binary_append_command): Remove.
 184         (_initialize_cli_dump): Use add_basic_prefix_cmd.
 185         * windows-tdep.c (w32_prefix_command_valid): Remove global.
 186         (init_w32_command_list): Remove; move into ...
 187         (_initialize_windows_tdep): ... here.  Use add_basic_prefix_cmd.
 188         * valprint.c (set_print, show_print, set_print_raw)
 189         (show_print_raw): Remove.
 190         (_initialize_valprint): Use add_basic_prefix_cmd,
 191         add_show_prefix_cmd.
 192         * typeprint.c (set_print_type, show_print_type): Remove.
 193         (_initialize_typeprint): Use add_basic_prefix_cmd,
 194         add_show_prefix_cmd.
 195         * record.c (set_record_command, show_record_command): Remove.
 196         (_initialize_record): Use add_basic_prefix_cmd,
 197         add_show_prefix_cmd.
 198         * cli/cli-cmds.c (_initialize_cli_cmds): Use add_basic_prefix_cmd,
 199         add_show_prefix_cmd.
 200         (info_command, show_command, set_debug, show_debug): Remove.
 201         * top.h (set_history, show_history): Don't declare.
 202         * top.c (set_history, show_history): Remove.
 203         * target-descriptions.c (set_tdesc_cmd, show_tdesc_cmd)
 204         (unset_tdesc_cmd): Remove.
 205         (_initialize_target_descriptions): Use add_basic_prefix_cmd,
 206         add_show_prefix_cmd.
 207         * symtab.c (info_module_command): Remove.
 208         (_initialize_symtab): Use add_basic_prefix_cmd.
 209         * symfile.c (overlay_command): Remove.
 210         (_initialize_symfile): Use add_basic_prefix_cmd.
 211         * sparc64-tdep.c (info_adi_command): Remove.
 212         (_initialize_sparc64_adi_tdep): Use add_basic_prefix_cmd.
 213         * sh-tdep.c (show_sh_command, set_sh_command): Remove.
 214         (_initialize_sh_tdep): Use add_basic_prefix_cmd,
 215         add_show_prefix_cmd.
 216         * serial.c (serial_set_cmd, serial_show_cmd): Remove.
 217         (_initialize_serial): Use add_basic_prefix_cmd,
 218         add_show_prefix_cmd.
 219         * ser-tcp.c (set_tcp_cmd, show_tcp_cmd): Remove.
 220         (_initialize_ser_tcp): Use add_basic_prefix_cmd,
 221         add_show_prefix_cmd.
 222         * rs6000-tdep.c (set_powerpc_command, show_powerpc_command)
 223         (_initialize_rs6000_tdep): Use add_basic_prefix_cmd,
 224         add_show_prefix_cmd.
 225         * riscv-tdep.c (show_riscv_command, set_riscv_command)
 226         (show_debug_riscv_command, set_debug_riscv_command): Remove.
 227         (_initialize_riscv_tdep): Use add_basic_prefix_cmd,
 228         add_show_prefix_cmd.
 229         * remote.c (remote_command, set_remote_cmd): Remove.
 230         (_initialize_remote): Use add_basic_prefix_cmd.
 231         * record-full.c (set_record_full_command)
 232         (show_record_full_command): Remove.
 233         (_initialize_record_full): Use add_basic_prefix_cmd,
 234         add_show_prefix_cmd.
 235         * record-btrace.c (cmd_set_record_btrace)
 236         (cmd_show_record_btrace, cmd_set_record_btrace_bts)
 237         (cmd_show_record_btrace_bts, cmd_set_record_btrace_pt)
 238         (cmd_show_record_btrace_pt): Remove.
 239         (_initialize_record_btrace): Use add_basic_prefix_cmd,
 240         add_show_prefix_cmd.
 241         * ravenscar-thread.c (set_ravenscar_command)
 242         (show_ravenscar_command): Remove.
 243         (_initialize_ravenscar): Use add_basic_prefix_cmd,
 244         add_show_prefix_cmd.
 245         * mips-tdep.c (show_mips_command, set_mips_command)
 246         (_initialize_mips_tdep): Use add_basic_prefix_cmd,
 247         add_show_prefix_cmd.
 248         * maint.c (maintenance_command, maintenance_info_command)
 249         (maintenance_check_command, maintenance_print_command)
 250         (maintenance_set_cmd, maintenance_show_cmd): Remove.
 251         (_initialize_maint_cmds): Use add_basic_prefix_cmd,
 252         add_show_prefix_cmd.
 253         (show_per_command_cmd): Remove.
 254         * maint-test-settings.c (maintenance_set_test_settings_cmd):
 255         Remove.
 256         (maintenance_show_test_settings_cmd): Remove.
 257         (_initialize_maint_test_settings): Use add_basic_prefix_cmd,
 258         add_show_prefix_cmd.
 259         * maint-test-options.c (maintenance_test_options_command):
 260         Remove.
 261         (_initialize_maint_test_options): Use add_basic_prefix_cmd.
 262         * macrocmd.c (macro_command): Remove
 263         (_initialize_macrocmd): Use add_basic_prefix_cmd.
 264         * language.c (set_check, show_check): Remove.
 265         (_initialize_language): Use add_basic_prefix_cmd,
 266         add_show_prefix_cmd.
 267         * infcmd.c (unset_command): Remove.
 268         (_initialize_infcmd): Use add_basic_prefix_cmd.
 269         * i386-tdep.c (set_mpx_cmd, show_mpx_cmd): Remove.
 270         (_initialize_i386_tdep): Use add_basic_prefix_cmd,
 271         add_show_prefix_cmd.
 272         * go32-nat.c (go32_info_dos_command): Remove.
 273         (_initialize_go32_nat): Use add_basic_prefix_cmd.
 274         * cli/cli-decode.c (do_prefix_cmd, add_basic_prefix_cmd)
 275         (do_show_prefix_cmd, add_show_prefix_cmd): New functions.
 276         * frame.c (set_backtrace_cmd, show_backtrace_cmd): Remove.
 277         (_initialize_frame): Use add_basic_prefix_cmd,
 278         add_show_prefix_cmd.
 279         * dcache.c (set_dcache_command, show_dcache_command): Remove.
 280         (_initialize_dcache): Use add_basic_prefix_cmd,
 281         add_show_prefix_cmd.
 282         * cp-support.c (maint_cplus_command): Remove.
 283         (_initialize_cp_support): Use add_basic_prefix_cmd.
 284         * btrace.c (maint_btrace_cmd, maint_btrace_set_cmd)
 285         (maint_btrace_show_cmd, maint_btrace_pt_set_cmd)
 286         (maint_btrace_pt_show_cmd, _initialize_btrace): Use
 287         add_basic_prefix_cmd, add_show_prefix_cmd.
 288         * breakpoint.c (save_command): Remove.
 289         (_initialize_breakpoint): Use add_basic_prefix_cmd.
 290         * arm-tdep.c (set_arm_command, show_arm_command): Remove.
 291         (_initialize_arm_tdep): Use add_basic_prefix_cmd,
 292         add_show_prefix_cmd.
 293         * ada-lang.c (maint_set_ada_cmd, maint_show_ada_cmd)
 294         (set_ada_command, show_ada_command): Remove.
 295         (_initialize_ada_language): Use add_basic_prefix_cmd,
 296         add_show_prefix_cmd.
 297         * command.h (add_basic_prefix_cmd, add_show_prefix_cmd): Declare.
 298
 299 2020-04-16  Kamil Rytarowski  <n54@gmx.com>
 300
 301         * nbsd-nat.c (inf_ptrace_target::auxv_parse): Remove.
 302         * nbsd-nat.h (inf_ptrace_target::auxv_parse): Likewise.
 303
 304 2020-04-16  Simon Marchi  <simon.marchi@polymtl.ca>
 305
 306         * windows-tdep.c (is_linked_with_cygwin_dll): Add filename to
 307         warning messages.
 308
 309 2020-04-16  Simon Marchi  <simon.marchi@polymtl.ca>
 310
 311         * windows-tdep.c (is_linked_with_cygwin_dll): Consider case where
 312         import table is not at beginning of .idata section.
 313
 314 2020-04-16  Pedro Alves  <palves@redhat.com>
 315
 316         * inferior.c (delete_inferior): Use delete operator directly
 317         instead of delete_program_space.
 318         * progspace.c (add_program_space): New, factored out from
 319         program_space::program_space.
 320         (remove_program_space): New, factored out from
 321         delete_program_space.
 322         (program_space::program_space): Remove intro comment.  Rewrite.
 323         (program_space::~program_space): Remove intro comment.  Call
 324         remove_program_space.
 325         (delete_program_space): Delete.
 326         * progspace.h (program_space::program_space): Make explicit.  Move
 327         intro comment here, adjusted.
 328         (program_space::~program_space): Move intro comment here,
 329         adjusted.
 330         (delete_program_space): Remove.
 331
 332 2020-04-16  Tom Tromey  <tromey@adacore.com>
 333
 334         * windows-nat.c (windows_nat::handle_access_violation): New
 335         function.
 336         * nat/windows-nat.h (handle_access_violation): Declare.
 337         * nat/windows-nat.c (handle_exception): Move Cygwin code to
 338         windows-nat.c.  Call handle_access_violation.
 339
 340 2020-04-16  Tom de Vries  <tdevries@suse.de>
 341
 342         PR symtab/25791
 343         * dwarf2/index-write.c (write_gdbindex): Generate CU table entries for
 344         CUs without psymtab.
 345
 346 2020-04-16  Kevin Buettner  <kevinb@redhat.com>
 347
 348         * python/python.c (do_start_initialization): Don't call
 349         PyEval_InitThreads for Python 3.9 and beyond.
 350
 351 2020-04-15  Kamil Rytarowski  <n54@gmx.com>
 352
 353         * obsd-nat.c (obsd_nat_target::update_thread_list): Pass "this" to
 354         thread functions.
 355         (obsd_nat_target::wait): Likewise.
 356
 357 2020-04-15  Tom Tromey  <tromey@adacore.com>
 358
 359         * windows-nat.c (DEBUG_EXEC, DEBUG_EVENTS, DEBUG_MEM)
 360         (DEBUG_EXCEPT): Use debug_printf.
 361
 362 2020-04-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 363
 364         * completer.c (class completion_tracker::completion_hash_entry)
 365         <hash_name>: New member function.
 366         (completion_tracker::discard_completions): New callback to hash a
 367         completion_hash_entry, pass this to htab_create_alloc.
 368
 369 2016-01-20  Jon Turney  <jon.turney@dronecode.org.uk>
 370
 371         * windows-nat.c (windows_make_so): Warn rather than stopping with
 372         an error if realpath() fails.
 373
 374 2020-04-14  Kamil Rytarowski  <n54@gmx.com>
 375
 376         * nbsd-nat.c (nbsd_pid_to_kinfo_proc2): New.
 377         (nbsd_nat_target::info_proc): Add do_status.
 378
 379 2020-04-14  Simon Marchi  <simon.marchi@polymtl.ca>
 380             Tom de Vries  <tdevries@suse.de>
 381
 382         PR symtab/25718
 383         * psympriv.h (struct partial_symtab::read_symtab)
 384         (struct partial_symtab::expand_psymtab)
 385         (struct partial_symtab::read_dependencies): Update comments.
 386         * dwarf2/read.c (struct dwarf2_include_psymtab::read_symtab): Call
 387         read_symtab for includer.
 388         (struct dwarf2_include_psymtab::expand_psymtab): Assert false.
 389         (struct dwarf2_include_psymtab::readin_p): Call readin_p () for includer.
 390         (struct dwarf2_include_psymtab::m_readin): Remove.
 391         (struct dwarf2_include_psymtab::includer): New member function.
 392         (dwarf2_psymtab::expand_psymtab): Assert !readin.
 393
 394 2020-04-14  Tom de Vries  <tdevries@suse.de>
 395
 396         PR symtab/25720
 397         * symmisc.c (maintenance_expand_symtabs): Call expand_symtabs_matching
 398         with NULL symbol_matcher and lookup_name.
 399         * psymtab.c (psym_expand_symtabs_matching): Handle NULL symbol_matcher
 400         and lookup_name.
 401         * dwarf2/read.c (dw2_expand_symtabs_matching)
 402         (dw2_debug_names_expand_symtabs_matching): Same.
 403         * symfile.h (struct quick_symbol_functions::expand_symtabs_matching):
 404         Make lookup_name a pointer.  Update comment.
 405         * symtab.c (global_symbol_searcher::expand_symtabs): Handle
 406         lookup_name being a pointer.
 407         * symfile.c (expand_symtabs_matching): Same.
 408         * symfile-debug.c (debug_qf_expand_symtabs_matching): Same.
 409         * linespec.c (iterate_over_all_matching_symtabs): Same.
 410
 411 2020-04-13  Tom Tromey  <tom@tromey.com>
 412
 413         * run-on-main-thread.c: Update include.
 414         * unittests/main-thread-selftests.c: Update include.
 415         * tui/tui-win.c: Update include.
 416         * tui/tui-io.c: Update include.
 417         * tui/tui-interp.c: Update include.
 418         * tui/tui-hooks.c: Update include.
 419         * top.h: Update include.
 420         * top.c: Update include.
 421         * ser-base.c: Update include.
 422         * remote.c: Update include.
 423         * remote-notif.c: Update include.
 424         * remote-fileio.c: Update include.
 425         * record-full.c: Update include.
 426         * record-btrace.c: Update include.
 427         * python/python.c: Update include.
 428         * posix-hdep.c: Update include.
 429         * mingw-hdep.c: Update include.
 430         * mi/mi-main.c: Update include.
 431         * mi/mi-interp.c: Update include.
 432         * main.c: Update include.
 433         * linux-nat.c: Update include.
 434         * interps.c: Update include.
 435         * infrun.c: Update include.
 436         * inf-loop.c: Update include.
 437         * event-top.c: Update include.
 438         * event-loop.c: Move to ../gdbsupport/.
 439         * event-loop.h: Move to ../gdbsupport/.
 440         * async-event.h: Update include.
 441         * Makefile.in (COMMON_SFILES, HFILES_NO_SRCDIR): Update.
 442
 443 2020-04-13  Tom Tromey  <tom@tromey.com>
 444
 445         * tui/tui-win.c: Include async-event.h.
 446         * remote.c: Include async-event.h.
 447         * remote-notif.c: Include async-event.h.
 448         * record-full.c: Include async-event.h.
 449         * record-btrace.c: Include async-event.h.
 450         * infrun.c: Include async-event.h.
 451         * event-top.c: Include async-event.h.
 452         * event-loop.h: Move some declarations to async-event.h.
 453         * event-loop.c: Don't include ser-event.h or top.h.  Move some
 454         code to async-event.c.
 455         * async-event.h: New file.
 456         * async-event.c: New file.
 457         * Makefile.in (COMMON_SFILES): Add async-event.c.
 458         (HFILES_NO_SRCDIR): Add async-event.h.
 459
 460 2020-04-13  Tom Tromey  <tom@tromey.com>
 461
 462         * utils.c (flush_streams): New function.
 463         * event-loop.c (gdb_wait_for_event): Call flush_streams.
 464
 465 2020-04-13  Tom Tromey  <tom@tromey.com>
 466
 467         * event-loop.c (handle_file_event): Use warning, not
 468         printf_unfiltered.
 469
 470 2020-04-13  Tom Tromey  <tom@tromey.com>
 471
 472         * event-loop.c: Include <chrono>.
 473
 474 2020-04-13  Tom Tromey  <tom@tromey.com>
 475
 476         * gdb_select.h: Move to ../gdbsupport/.
 477         * event-loop.c: Update include path.
 478         * top.c: Update include path.
 479         * ser-base.c: Update include path.
 480         * ui-file.c: Update include path.
 481         * ser-tcp.c: Update include path.
 482         * guile/scm-ports.c: Update include path.
 483         * posix-hdep.c: Update include path.
 484         * ser-unix.c: Update include path.
 485         * gdb_usleep.c: Update include path.
 486         * mingw-hdep.c: Update include path.
 487         * inflow.c: Update include path.
 488         * infrun.c: Update include path.
 489         * event-top.c: Update include path.
 490
 491 2020-04-13  Tom Tromey  <tom@tromey.com>
 492
 493         * configure: Rebuild.
 494         * configure.ac: Remove checks that are now in GDB_AC_COMMON.
 495
 496 2020-04-13  Tom Tromey  <tom@tromey.com>
 497
 498         * event-loop.h (start_event_loop): Don't declare.
 499         * event-loop.c (start_event_loop): Move...
 500         * main.c (start_event_loop): ...here.  Now static.
 501
 502 2020-04-13  Sergio Durigan Junior  <sergiodj@sergiodj.net>
 503
 504         * MAINTAINERS: Update my email address.
 505
 506 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
 507
 508         * nbsd-nat.c (nbsd_nat_target::info_proc): Add IP_MINIMAL and
 509         IP_ALL.
 510
 511 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
 512
 513         * nbsd-nat.c (nbsd_pid_to_cmdline): Add.
 514         (nbsd_nat_target::info_proc): Add do_cmdline.
 515
 516 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
 517
 518         * nbsd-nat.c (nbsd_pid_to_cwd): Add.
 519         (nbsd_nat_target::info_proc): Add do_cwd.
 520
 521 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
 522
 523         * nbsd-nat.c (nbsd_nat_target::info_proc): Add do_exe.
 524
 525 2020-04-11  Kamil Rytarowski  <n54@gmx.com>
 526
 527         * nbsd-nat.c; Include "nbsd-tdep.h" and "gdbarch.h".
 528         * nbsd-nat.c (nbsd_nat_target::find_memory_regions)
 529         (nbsd_nat_target::info_proc): New functions.
 530         * nbsd-nat.c (kinfo_get_vmmap): New function.
 531         * nbsd-nat.c (nbsd_nat_target::info_proc) Use
 532         nbsd_info_proc_mappings_header and nbsd_info_proc_mappings_entry.
 533         * nbsd-tdep.c (nbsd_info_proc_mappings_header)
 534         (nbsd_info_proc_mappings_entry, nbsd_vm_map_entry_flags): New
 535         functions.
 536         * nbsd-tdep.c (KINFO_VME_PROT_READ, KINFO_VME_PROT_WRITE)
 537         (KINFO_VME_PROT_EXEC, KINFO_VME_FLAG_COW)
 538         (KINFO_VME_FLAG_NEEDS_COPY, KINFO_VME_FLAG_NOCOREDUMP)
 539         (KINFO_VME_FLAG_PAGEABLE, KINFO_VME_FLAG_GROWS_UP)
 540         (KINFO_VME_FLAG_GROWS_DOWN): New.
 541
 542 2020-04-10  Artur Shepilko  <nomadbyte@gmail.com>
 543
 544         * utils.c (copy_bitwise): Use unsigned 0 constant as operand of
 545         bit shift.
 546
 547 2020-04-10  Tom Tromey  <tromey@adacore.com>
 548
 549         * symfile.c (symbol_file_add_separate): Preserve OBJF_MAINLINE.
 550
 551 2020-04-10  Tom Tromey  <tromey@adacore.com>
 552
 553         * symtab.c (get_symbol_address, get_msymbol_address): Skip
 554         separate debug files.
 555
 556 2020-04-10  Hannes Domani  <ssbssa@yahoo.de>
 557
 558         * nat/windows-nat.c (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP):
 559         Move to...
 560         * nat/windows-nat.h (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP):
 561         ... here.
 562         * windows-nat.c (windows_nat_target::get_windows_debug_event):
 563         Check for STATUS_WX86_BREAKPOINT.
 564         (windows_nat_target::wait): Same.
 565
 566 2020-04-10  Tom de Vries  <tdevries@suse.de>
 567
 568         PR cli/25808
 569         * python/lib/gdb/__init__.py: Initialize lexer with stripnl=False.
 570
 571 2020-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
 572
 573         * MAINTAINERS (Global Maintainers): Add Tom de Vries.
 574         (Write After Approval): Remove Tom de Vries.
 575
 576 2020-04-09  Bernd Edlinger  <bernd.edlinger@hotmail.de>
 577
 578         revert partially:
 579         2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
 580
 581         * buildsym.c (record_line): Fix undefined behavior and preserve
 582         lines at eof.
 583
 584 2020-04-09  Kamil Rytarowski  <n54@gmx.com>
 585
 586         * auxv.h (svr4_auxv_parse): New.
 587         * auxv.c (default_auxv_parse): Split into default_auxv_parse
 588         and generic_auxv_parse.
 589         (svr4_auxv_parse): Add.
 590         * obsd-tdep.c: Include "auxv.h".
 591         (obsd_auxv_parse): Remove.
 592         (obsd_init_abi): Remove comment.
 593         (obsd_init_abi): Change set_gdbarch_auxv_parse passed argument
 594         from `obsd_auxv_parse' to `svr4_auxv_parse'.
 595         * nbsd-tdep.c: Include "auxv.h".
 596         (nbsd_init_abi): Call set_gdbarch_auxv_parse.
 597
 598 2020-04-08  Tom Tromey  <tromey@adacore.com>
 599
 600         * nat/windows-nat.h (last_wait_event): Don't declare.
 601         (wait_for_debug_event): Update comment.
 602         * nat/windows-nat.c (last_wait_event): Now static.
 603
 604 2020-04-08  Tom Tromey  <tromey@adacore.com>
 605
 606         * windows-nat.c (wait_for_debug_event): Move to
 607         nat/windows-nat.c.
 608         * nat/windows-nat.h (wait_for_debug_event): Declare.
 609         * nat/windows-nat.c (wait_for_debug_event): Move from
 610         windows-nat.c.  No longer static.
 611
 612 2020-04-08  Tom Tromey  <tromey@adacore.com>
 613
 614         * windows-nat.c (get_windows_debug_event): Use
 615         fetch_pending_stop.
 616         * nat/windows-nat.h (fetch_pending_stop): Declare.
 617         * nat/windows-nat.c (fetch_pending_stop): New function.
 618
 619 2020-04-08  Tom Tromey  <tromey@adacore.com>
 620
 621         * windows-nat.c (windows_continue): Use matching_pending_stop and
 622         continue_last_debug_event.
 623         * nat/windows-nat.h (matching_pending_stop)
 624         (continue_last_debug_event): Declare.
 625         * nat/windows-nat.c (DEBUG_EVENTS): New define.
 626         (matching_pending_stop, continue_last_debug_event): New
 627         functions.
 628
 629 2020-04-08  Tom Tromey  <tromey@adacore.com>
 630
 631         * windows-nat.c (MS_VC_EXCEPTION): Move to nat/windows-nat.c.
 632         (handle_exception_result): Move to nat/windows-nat.h.
 633         (DEBUG_EXCEPTION_SIMPLE): Remove.
 634         (windows_nat::handle_ms_vc_exception): New function.
 635         (handle_exception): Move to nat/windows-nat.c.
 636         (get_windows_debug_event): Update.
 637         (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP): Move to
 638         nat/windows-nat.c.
 639         * nat/windows-nat.h (handle_ms_vc_exception): Declare.
 640         (handle_exception_result): Move from windows-nat.c.
 641         (handle_exception): Declare.
 642         * nat/windows-nat.c (MS_VC_EXCEPTION, handle_exception)
 643         (STATUS_WX86_SINGLE_STEP, STATUS_WX86_BREAKPOINT): Move from
 644         windows-nat.c.
 645
 646 2020-04-08  Tom Tromey  <tromey@adacore.com>
 647
 648         * windows-nat.c (exception_count, event_count): Remove.
 649         (handle_exception, get_windows_debug_event)
 650         (do_initial_windows_stuff): Update.
 651
 652 2020-04-08  Tom Tromey  <tromey@adacore.com>
 653
 654         * windows-nat.c (windows_nat::handle_load_dll)
 655         (windows_nat::handle_unload_dll): Rename.  No longer static.
 656         * nat/windows-nat.h (handle_load_dll, handle_unload_dll):
 657         Declare.
 658
 659 2020-04-08  Tom Tromey  <tromey@adacore.com>
 660
 661         * complaints.h (stop_whining): Declare at top-level.
 662         (complaint): Don't declare stop_whining.
 663
 664 2020-04-08  Tom Tromey  <tromey@adacore.com>
 665
 666         * windows-nat.c (windows_nat::handle_output_debug_string):
 667         Rename.  No longer static.
 668         * nat/windows-nat.h (handle_output_debug_string): Declare.
 669
 670 2020-04-08  Tom Tromey  <tromey@adacore.com>
 671
 672         * windows-nat.c (current_process_handle, current_process_id)
 673         (main_thread_id, last_sig, current_event, last_wait_event)
 674         (current_windows_thread, desired_stop_thread_id, pending_stops)
 675         (struct pending_stop, siginfo_er): Move to nat/windows-nat.c.
 676         (display_selectors, fake_create_process)
 677         (get_windows_debug_event): Update.
 678         * nat/windows-nat.h (current_process_handle, current_process_id)
 679         (main_thread_id, last_sig, current_event, last_wait_event)
 680         (current_windows_thread, desired_stop_thread_id, pending_stops)
 681         (struct pending_stop, siginfo_er): Move from windows-nat.c.
 682         * nat/windows-nat.c (current_process_handle, current_process_id)
 683         (main_thread_id, last_sig, current_event, last_wait_event)
 684         (current_windows_thread, desired_stop_thread_id, pending_stops)
 685         (siginfo_er): New globals.  Move from windows-nat.c.
 686
 687 2020-04-08  Tom Tromey  <tromey@adacore.com>
 688
 689         * windows-nat.c (get_image_name): Move to nat/windows-nat.c.
 690         (handle_load_dll): Update.
 691         * nat/windows-nat.c (get_image_name): Move from windows-nat.c.
 692
 693 2020-04-08  Tom Tromey  <tromey@adacore.com>
 694
 695         * windows-nat.c (enum thread_disposition_type): Move to
 696         nat/windows-nat.h.
 697         (windows_nat::thread_rec): Rename from thread_rec.  No longer
 698         static.
 699         (windows_add_thread, windows_nat_target::fetch_registers)
 700         (windows_nat_target::store_registers, handle_exception)
 701         (windows_nat_target::resume, get_windows_debug_event)
 702         (windows_nat_target::get_tib_address)
 703         (windows_nat_target::thread_name)
 704         (windows_nat_target::thread_alive): Update.
 705         * nat/windows-nat.h (enum thread_disposition_type): Move from
 706         windows-nat.c.
 707         (thread_rec): Declare.
 708
 709 2020-04-08  Tom Tromey  <tromey@adacore.com>
 710
 711         * windows-nat.c: Add "using namespace".
 712         * nat/windows-nat.h: Wrap contents in windows_nat namespace.
 713         * nat/windows-nat.c: Wrap contents in windows_nat namespace.
 714
 715 2020-04-08  Tom Tromey  <tromey@adacore.com>
 716
 717         * nat/windows-nat.h (struct windows_thread_info): Declare
 718         destructor.
 719         * nat/windows-nat.c (~windows_thread_info): New.
 720
 721 2020-04-08  Tom Tromey  <tromey@adacore.com>
 722
 723         PR gdb/22992
 724         * windows-nat.c (current_event): Update comment.
 725         (last_wait_event, desired_stop_thread_id): New globals.
 726         (struct pending_stop): New.
 727         (pending_stops): New global.
 728         (windows_nat_target) <stopped_by_sw_breakpoint>
 729         <supports_stopped_by_sw_breakpoint>: New methods.
 730         (windows_fetch_one_register): Add assertions.  Adjust PC.
 731         (windows_continue): Handle pending stops.  Suspend other threads
 732         when stepping.  Use last_wait_event
 733         (wait_for_debug_event): New function.
 734         (get_windows_debug_event): Use wait_for_debug_event.  Handle
 735         pending stops.  Queue spurious stops.
 736         (windows_nat_target::wait): Set stopped_at_software_breakpoint.
 737         (windows_nat_target::kill): Use wait_for_debug_event.
 738         * nat/windows-nat.h (struct windows_thread_info)
 739         <stopped_at_software_breakpoint>: New field.
 740         * nat/windows-nat.c (windows_thread_info::resume): Clear
 741         stopped_at_software_breakpoint.
 742
 743 2020-04-08  Tom Tromey  <tromey@adacore.com>
 744
 745         * windows-nat.c (enum thread_disposition_type): New.
 746         (thread_rec): Replace "get_context" parameter with "disposition";
 747         change type.
 748         (windows_add_thread, windows_nat_target::fetch_registers)
 749         (windows_nat_target::store_registers, handle_exception)
 750         (windows_nat_target::resume, get_windows_debug_event)
 751         (windows_nat_target::get_tib_address)
 752         (windows_nat_target::thread_name)
 753         (windows_nat_target::thread_alive): Update.
 754
 755 2020-04-08  Tom Tromey  <tromey@adacore.com>
 756
 757         * windows-nat.c (thread_rec): Use windows_thread_info::suspend.
 758         (windows_continue): Use windows_continue::resume.
 759         * nat/windows-nat.h (struct windows_thread_info) <suspend,
 760         resume>: Declare new methods.
 761         * nat/windows-nat.c: New file.
 762         * configure.nat (NATDEPFILES): Add nat/windows-nat.o when needed.
 763
 764 2020-04-08  Tom Tromey  <tromey@adacore.com>
 765
 766         * windows-nat.c (windows_add_thread, windows_delete_thread)
 767         (windows_nat_target::fetch_registers)
 768         (windows_nat_target::store_registers, fake_create_process)
 769         (windows_nat_target::resume, windows_nat_target::resume)
 770         (get_windows_debug_event, windows_nat_target::wait)
 771         (windows_nat_target::pid_to_str)
 772         (windows_nat_target::get_tib_address)
 773         (windows_nat_target::get_ada_task_ptid)
 774         (windows_nat_target::thread_name)
 775         (windows_nat_target::thread_alive): Use lwp, not tid.
 776
 777 2020-04-08  Tom Tromey  <tromey@adacore.com>
 778
 779         * windows-nat.c (handle_exception)
 780         (windows_nat_target::thread_name): Update.
 781         * nat/windows-nat.h (windows_thread_info): Remove destructor.
 782         <name>: Now unique_xmalloc_ptr.
 783
 784 2020-04-08  Tom Tromey  <tromey@adacore.com>
 785
 786         * windows-nat.c (thread_rec)
 787         (windows_nat_target::fetch_registers): Update.
 788         * nat/windows-nat.h (struct windows_thread_info) <suspended>:
 789         Update comment.
 790         <debug_registers_changed, reload_context>: Now bool.
 791
 792 2020-04-08  Tom Tromey  <tromey@adacore.com>
 793
 794         * windows-nat.c (windows_add_thread): Use new.
 795         (windows_init_thread_list, windows_delete_thread): Use delete.
 796         (get_windows_debug_event): Update.
 797         * nat/windows-nat.h (struct windows_thread_info): Add constructor,
 798         destructor, and initializers.
 799
 800 2020-04-08  Tom Tromey  <tromey@adacore.com>
 801
 802         * windows-nat.c (struct windows_thread_info): Remove.
 803         * nat/windows-nat.h: New file.
 804
 805 2020-04-08  Tom Tromey  <tromey@adacore.com>
 806
 807         * windows-nat.c (struct windows_thread_info) <tid>: Rename from "id".
 808         (thread_rec, windows_add_thread, windows_delete_thread)
 809         (windows_continue): Update.
 810
 811 2020-04-08  Tom Tromey  <tromey@adacore.com>
 812
 813         * windows-nat.c (struct windows_thread_info): Remove typedef.
 814         (thread_head): Remove.
 815         (thread_list): New global.
 816         (thread_rec, windows_add_thread, windows_init_thread_list)
 817         (windows_delete_thread, windows_continue): Update.
 818
 819 2020-04-08  Simon Marchi  <simon.marchi@polymtl.ca>
 820
 821         * windows-tdep.h (windows_init_abi): Add comment.
 822         (cygwin_init_abi): New declaration.
 823         * windows-tdep.c: Split signal enumeration in two, one for
 824         Windows and one for Cygwin.
 825         (windows_gdb_signal_to_target): Only deal with signal of the
 826         Windows OS ABI.
 827         (cygwin_gdb_signal_to_target): New function.
 828         (windows_init_abi): Rename to windows_init_abi_common, don't set
 829         gdb_signal_to_target gdbarch method.  Add new new function with
 830         this name.
 831         (cygwin_init_abi): New function.
 832         * amd64-windows-tdep.c (amd64_windows_init_abi_common): Add
 833         comment.  Don't call windows_init_abi.
 834         (amd64_windows_init_abi): Add comment, call windows_init_abi.
 835         (amd64_cygwin_init_abi): Add comment, call cygwin_init_abi.
 836         * i386-windows-tdep.c (i386_windows_init_abi): Rename to
 837         i386_windows_init_abi_common, don't call windows_init_abi.  Add
 838         a new function of this name.
 839         (i386_cygwin_init_abi): New function.
 840         (_initialize_i386_windows_tdep): Bind i386_cygwin_init_abi to
 841         OS ABI Cygwin.
 842
 843 2020-04-08  Simon Marchi  <simon.marchi@polymtl.ca>
 844
 845         * dwarf2/read.c (read_gdb_index_from_buffer): Remove objfile
 846         parameter.c.
 847         (dwarf2_read_gdb_index): Update.
 848
 849 2020-04-07  Kamil Rytarowski  <n54@gmx.com>
 850
 851         * nbsd-tdep.c: Include "objfiles.h".
 852         (nbsd_skip_solib_resolver): New.
 853         (nbsd_init_abi): Call set_gdbarch_skip_solib_resolver().
 854
 855 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
 856
 857         * dwarf2/loc.c (loclist_describe_location): Call the function decode_debug_loclists_
 858         addresses if DWARF version is 5 or more because DW_LLE_start* or DW_LLE_offset_pair
 859         with DW_LLE_base_addressx are being emitted in DWARFv5.
 860         Add the newly added kind DW_LOC_OFFSET_PAIR also.
 861         The length of location description is an unsigned ULEB integer in DWARFv5 instead of
 862         unsigned integer.
 863
 864 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
 865
 866         * dwarf2/loc.c (enum debug_loc_kind): Add a new kind DEBUG_LOC_OFFSET_PAIR.
 867         (dwarf2_find_location_expression): Call the function decode_debug_loclists_
 868         addresses if DWARF version is 5 or more. DW_LLE_start* or DW_LLE_offset_pair
 869         with DW_LLE_base_addressx are being emitted in DWARFv5 instead of DW_LLE_GNU*.
 870         Add applicable base address if the entry is DW_LLE_offset_pair from DWO.
 871         (decode_debug_loclists_addresses): Return DEBUG_LOC_OFFSET_PAIR instead of
 872         DEBUG_LOC_START_END in case of DW_LLE_offset_pair.
 873
 874
 875 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
 876
 877         * dwarf2/read.c (cu_debug_loc_section): Added the declaration for the function.
 878         (read_loclist_index): New function definition.
 879         (lookup_loclist_base): New function definition.
 880         (read_loclist_header): New function definition.
 881         (dwarf2_cu): Add loclist_base and loclist_header field.
 882         (dwarf2_locate_dwo_sections): Handle .debug_loclists.dwo section.
 883         (read_full_die_1): Read the value of DW_AT_loclists_base.
 884         (read_attribute_reprocess): Handle DW_FORM_loclistx.
 885         (read_attribute_value): Handle DW_FORM_loclistx.
 886         (skip_one_die): Handle DW_FORM_loclistx.
 887         (loclist_header): New structure declaration.
 888         * dwarf2/attribute.c (form_is_section_offset): Handle DW_FORM_loclistx.
 889
 890 2020-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
 891
 892         * dwarf2/read.h (struct dwarf2_psymtab): Remove two-parameters
 893         constructor.  Remove `addr` parameter from other constructor and
 894         add `per_cu` parameter.
 895         * dwarf2/read.c (create_partial_symtab): Update.
 896
 897 2020-04-07  Tom de Vries  <tdevries@suse.de>
 898
 899         PR symtab/25796
 900         * dwarf2/read.c (can_have_DW_AT_const_value_p): New function.
 901         (partial_die_info::fixup): Inherit has_const_value.
 902
 903 2020-04-07  Tom de Vries  <tdevries@suse.de>
 904
 905         * psymtab.c (maintenance_check_psymtabs): Skip static LOC_BLOCK
 906         symbols without address.
 907
 908 2020-04-06  Kamil Rytarowski  <n54@gmx.com>
 909
 910         * nbsd-nat.h (struct thread_info): Add forward declaration.
 911         (nbsd_nat_target::thread_alive): Add.
 912         (nbsd_nat_target::thread_name): Likewise.
 913         (nbsd_nat_target::update_thread_list): Likewise.
 914         (update_thread_list::post_attach): Likewise.
 915         (post_attach::pid_to_str): Likewise.
 916         * nbsd-nat.c: Include "gdbthread.h" and "inferior.h".
 917         (nbsd_thread_lister): Add.
 918         (nbsd_nat_target::thread_alive): Likewise.
 919         (nbsd_nat_target::thread_name): Likewise.
 920         (nbsd_add_threads): Likewise.
 921         (update_thread_list::post_attach): Likewise.
 922         (nbsd_nat_target::update_thread_list): Likewise.
 923         (post_attach::pid_to_str): Likewise.
 924
 925 2020-04-06  Tom Tromey  <tromey@adacore.com>
 926
 927         * ada-valprint.c (print_variant_part): Extract the variant field.
 928         (print_field_values): Use the field as the outer value when
 929         recursing.
 930
 931 2020-04-06  Tom Tromey  <tromey@adacore.com>
 932
 933         * sh-nbsd-tdep.c: Include nbsd-tdep.h.
 934         * ppc-nbsd-tdep.c: Include nbsd-tdep.h.
 935         * mips-nbsd-tdep.c (mipsnbsd_init_abi): Add missing ";".
 936         * arm-nbsd-tdep.c: Include nbsd-tdep.h.
 937         * hppa-nbsd-tdep.c: Include nbsd-tdep.h.
 938
 939 2020-04-06  Tom Tromey  <tromey@adacore.com>
 940
 941         * dwarf2/read.c (read_base_type) <DW_ATE_complex_float>: Handle
 942         TYPE_CODE_ERROR.
 943
 944 2020-04-06  Kamil Rytarowski  <n54@gmx.com>
 945
 946         * nbsd-tdep.c: Include "gdbarch.h".
 947         Define enum with NetBSD signal numbers.
 948         (nbsd_gdb_signal_from_target, nbsd_gdb_signal_to_target): New.
 949         * alpha-nbsd-tdep.c (alphanbsd_init_abi): Call nbsd_init_abi().
 950         * amd64-nbsd-tdep.c (amd64nbsd_init_abi): Likewise.
 951         * arm-nbsd-tdep.c (arm_netbsd_elf_init_abi): Likewise.
 952         * hppa-nbsd-tdep.c (hppanbsd_init_abi): Likewise.
 953         * i386-nbsd-tdep.c (i386nbsd_init_abi): Likewise.
 954         * mips-nbsd-tdep.c (nbsd_init_abi): Likewise.
 955         * ppc-nbsd-tdep.c (ppcnbsd_init_abi): Likewise.
 956         * sh-nbsd-tdep.c (shnbsd_init_abi): Likewise.
 957         * sparc-nbsd-tdep.c (sparc32nbsd_init_abi): Likewise.
 958         * sparc64-nbsd-tdep.c (sparc64nbsd_init_abi): Likewise.
 959         * vax-nbsd-tdep.c (vaxnbsd_elf_init_abi): Likewise.
 960
 961 2020-04-03  Hannes Domani  <ssbssa@yahoo.de>
 962
 963         PR gdb/25325
 964         * dwarf2/read.c (read_enumeration_type): Fix typed enum attributes.
 965
 966 2020-04-03  Tom Tromey  <tromey@adacore.com>
 967
 968         * dwarf2/loc.c (disassemble_dwarf_expression) <DW_OP_const_type>:
 969         Read constant block.
 970
 971 2020-04-02  Simon Marchi  <simon.marchi@polymtl.ca>
 972
 973         * gdb_bfd.h: Include gdbsupport/byte-vector.h.
 974         (gdb_bfd_get_full_section_contents): New declaration.
 975         * gdb_bfd.c (gdb_bfd_get_full_section_contents): New function.
 976         * windows-tdep.c (is_linked_with_cygwin_dll): Use
 977         gdb_bfd_get_full_section_contents.
 978
 979 2020-04-02  Simon Marchi  <simon.marchi@polymtl.ca>
 980
 981         * exec.c (build_section_table): Replace internal_error with
 982         gdb_assert.
 983         (section_table_xfer_memory_partial): Likewise.
 984         * mdebugread.c (parse_partial_symbols): Likewise.
 985         * psymtab.c (lookup_partial_symbol): Likewise.
 986         * utils.c (wrap_here): Likewise.
 987
 988 2020-04-02  Tom Tromey  <tromey@adacore.com>
 989
 990         * f-lang.c (build_fortran_types): Use arch_type to initialize
 991         builtin_complex_s32 in the TYPE_CODE_ERROR case.
 992
 993 2020-04-02  Tom Tromey  <tromey@adacore.com>
 994
 995         * dwarf2/read.c (partial_die_info::read): Do not create a vector
 996         of attributes.
 997
 998 2020-04-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 999             Bernd Edlinger <bernd.edlinger@hotmail.de>
1000             Tom Tromey  <tromey@adacore.com>
1001
1002         * buildsym.c (buildsym_compunit::record_line): Remove
1003         deduplication code.
1004
1005 2020-04-02  Tom de Vries  <tdevries@suse.de>
1006
1007         PR ada/24671
1008         * dwarf2/read.c (dw2_map_matching_symbols): Handle -readnow.
1009
1010 2020-04-02  Tom de Vries  <tdevries@suse.de>
1011
1012         * dwarf2/read.c (dwarf2_gdb_index_functions,
1013         dwarf2_debug_names_functions): Init lookup_global_symbol_language with
1014         NULL.
1015         * psymtab.c (psym_lookup_global_symbol_language): New function.
1016         (psym_functions): Init psym_lookup_global_symbol_language with
1017         psym_lookup_global_symbol_language.
1018         * symfile-debug.c (debug_sym_quick_functions): Init
1019         lookup_global_symbol_language with NULL.
1020         * symfile.c (set_initial_language): Remove fixme comment.
1021         * symfile.h (struct quick_symbol_functions): Add
1022         lookup_global_symbol_language.
1023         * symtab.c (find_quick_global_symbol_language): New function.
1024         (find_main_name): Use find_quick_global_symbol_language.
1025
1026 2020-04-01  Simon Marchi  <simon.marchi@polymtl.ca>
1027
1028         * windows-tdep.c (is_linked_with_cygwin_dll): Fix style.
1029
1030 2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
1031
1032         * buildsym.c (record_line): Fix undefined behavior and preserve
1033         lines at eof.
1034
1035 2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
1036
1037         * buildsym.c (record_line): Fix the resizing condition.
1038
1039 2020-04-01  Tom Tromey  <tom@tromey.com>
1040
1041         * value.h (value_literal_complex): Add comment.
1042         * valops.c (value_literal_complex): Refer to value.h.
1043
1044 2020-04-01  Tom Tromey  <tom@tromey.com>
1045
1046         * c-exp.y (FLOAT_KEYWORD, COMPLEX): New tokens.
1047         (scalar_type): New rule, from typebase.
1048         (typebase): Use scalar_type.  Recognize complex types.
1049         (field_name): Handle FLOAT_KEYWORD.
1050         (ident_tokens): Add _Complex and __complex__.
1051
1052 2020-04-01  Tom Tromey  <tom@tromey.com>
1053
1054         PR exp/25299:
1055         * valarith.c (promotion_type, complex_binop): New functions.
1056         (scalar_binop): Handle complex numbers.  Use promotion_type.
1057         (value_pos, value_neg, value_complement): Handle complex numbers.
1058
1059 2020-04-01  Tom Tromey  <tom@tromey.com>
1060
1061         * c-exp.y (COMPLEX_INT, COMPLEX_FLOAT): New tokens.
1062         (exp) <COMPLEX_INT, COMPLEX_FLOAT>: New rules.
1063         (parse_number): Handle complex numbers.
1064
1065 2020-04-01  Tom Tromey  <tom@tromey.com>
1066
1067         * c-valprint.c (c_decorations): Change complex suffix to "i".
1068
1069 2020-04-01  Tom Tromey  <tom@tromey.com>
1070
1071         * valprint.c (generic_value_print_complex): Use accessors.
1072         * value.h (value_real_part, value_imaginary_part): Declare.
1073         * valops.c (value_real_part, value_imaginary_part): New
1074         functions.
1075         * value.c (creal_internal_fn, cimag_internal_fn): Use accessors.
1076
1077 2020-04-01  Tom Tromey  <tom@tromey.com>
1078
1079         * stabsread.c (rs6000_builtin_type, read_sun_floating_type)
1080         (read_range_type): Update.
1081         * mdebugread.c (basic_type): Update.
1082         * go-lang.c (build_go_types): Use init_complex_type.
1083         * gdbtypes.h (struct main_type) <complex_type>: New member.
1084         (init_complex_type): Update.
1085         (arch_complex_type): Don't declare.
1086         * gdbtypes.c (init_complex_type): Remove "objfile" parameter.
1087         Make name if none given.  Use alloc_type_copy.  Look for cached
1088         complex type.
1089         (arch_complex_type): Remove.
1090         (gdbtypes_post_init): Use init_complex_type.
1091         * f-lang.c (build_fortran_types): Use init_complex_type.
1092         * dwarf2/read.c (read_base_type): Update.
1093         * d-lang.c (build_d_types): Use init_complex_type.
1094         * ctfread.c (read_base_type): Update.
1095
1096 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1097
1098         * infrun.c (stop_all_threads): Update assertion, plus when
1099         stopping threads, take into account that we might be trying
1100         to stop an all-stop target.
1101         (stop_waiting): Call 'stop_all_threads' if there exists a
1102         non-stop target.
1103
1104 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1105
1106         * target.h (exists_non_stop_target): New function declaration.
1107         * target.c (exists_non_stop_target): New function.
1108
1109 2020-04-01  Hannes Domani  <ssbssa@yahoo.de>
1110
1111         PR gdb/24789
1112         * eval.c (is_integral_or_integral_reference): New function.
1113         (evaluate_subexp_standard): Allow integer references in
1114         pointer arithmetic.
1115
1116 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1117
1118         * remote.c (remote_target::remote_parse_stop_reply): Remove the
1119         check for no ptid in the stop reply when the target is non-stop.
1120
1121 2020-04-01  Tom Tromey  <tromey@adacore.com>
1122
1123         * symtab.h (class lookup_name_info) <lookup_name_info>: Change
1124         "name" parameter to rvalue reference.  Initialize m_name_holder.
1125         <lookup_name_info>: New overloads.
1126         <name>: Return gdb::string_view.
1127         <c_str>: New method.
1128         <make_ignore_params>: Update.
1129         <search_name_hash>: Update.
1130         <language_lookup_name>: Return const char *.
1131         <m_name>: Change type.
1132         * symtab.c (demangle_for_lookup_info::demangle_for_lookup_info)
1133         (demangle_for_lookup_info::demangle_for_lookup_info): Update.
1134         (lookup_name_info::match_any): Update.
1135         * psymtab.c (match_partial_symbol, lookup_partial_symbol):
1136         Update.
1137         * minsyms.c (linkage_name_str): Update.
1138         * language.c (default_symbol_name_matcher): Update.
1139         * dwarf2/read.c (mapped_index_base::find_name_components_bounds):
1140         Update.
1141         * ada-lang.c (ada_fold_name): Change parameter to string_view.
1142         (ada_lookup_name_info::ada_lookup_name_info): Update.
1143         (literal_symbol_name_matcher): Update.
1144
1145 2020-04-01  Tom Tromey  <tromey@adacore.com>
1146
1147         * psymtab.c (psymtab_search_name): Remove function.
1148         (psym_lookup_symbol): Create search name and lookup name here.
1149         (lookup_partial_symbol): Remove "name" parameter; add
1150         lookup_name.
1151         (psym_expand_symtabs_for_function): Update.
1152
1153 2020-03-31  Joel Jones  <joelkevinjones@gmail.com>
1154
1155         PR tui/25597:
1156         * python/py-tui.c: Include gdb_curses.h inside of #ifdef TUI.
1157
1158 2020-03-31  Tom Tromey  <tromey@adacore.com>
1159
1160         * dwarf2/abbrev.c (abbrev_table::read): Conditionally call
1161         memcpy.
1162
1163 2020-03-30  Nelson Chu  <nelson.chu@sifive.com>
1164
1165         * features/riscv/32bit-csr.xml: Regenerated.
1166         * features/riscv/64bit-csr.xml: Regenerated.
1167
1168 2020-03-30  Tom Tromey  <tromey@adacore.com>
1169
1170         * ada-valprint.c (print_variant_part): Update.
1171         * ada-lang.h (ada_which_variant_applies): Update.
1172         * ada-lang.c (ada_which_variant_applies): Remove outer_type and
1173         outer_valaddr parameters; replace with "outer" value parameter.
1174         (to_fixed_variant_branch_type): Update.
1175
1176 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1177
1178         * ppc-linux-nat.c: Include <algorithm>, <unordered_map>, and
1179         <list>.  Remove inclusion of observable.h.
1180         (PPC_DEBUG_CURRENT_VERSION): Move up define.
1181         (struct arch_lwp_info): New struct.
1182         (class ppc_linux_dreg_interface): New class.
1183         (struct ppc_linux_process_info): New struct.
1184         (struct ppc_linux_nat_target) <low_delete_thread, low_new_fork>
1185         <low_new_clone, low_forget_process, low_prepare_to_resume>
1186         <copy_thread_dreg_state, mark_thread_stale>
1187         <mark_debug_registers_changed, register_hw_breakpoint>
1188         <clear_hw_breakpoint, register_wp, clear_wp>
1189         <can_use_watchpoint_cond_accel, calculate_dvc, check_condition>
1190         <num_memory_accesses, get_trigger_type>
1191         <create_watchpoint_request, hwdebug_point_cmp>
1192         <init_arch_lwp_info, get_arch_lwp_info>
1193         <low_stopped_by_watchpoint, low_stopped_data_address>: Declare as
1194         methods.
1195         <struct ptid_hash>: New inner struct.
1196         <m_dreg_interface, m_process_info, m_installed_hw_bps>: Declare
1197         members.
1198         (saved_dabr_value, hwdebug_info, max_slots_number)
1199         (struct hw_break_tuple, struct thread_points, ppc_threads)
1200         (have_ptrace_hwdebug_interface)
1201         (hwdebug_find_thread_points_by_tid)
1202         (hwdebug_insert_point, hwdebug_remove_point): Remove.
1203         (ppc_linux_nat_target::can_use_hw_breakpoint): Use
1204         m_dreg_interface, remove call to PTRACE_SET_DEBUGREG.
1205         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Add comment,
1206         use m_dreg_interface.
1207         (hwdebug_point_cmp): Change to...
1208         (ppc_linux_nat_target::hwdebug_point_cmp): ...this method.  Use
1209         reference arguments instead of pointers.
1210         (ppc_linux_nat_target::ranged_break_num_registers): Use
1211         m_dreg_interface.
1212         (ppc_linux_nat_target::insert_hw_breakpoint): Add comment, use
1213         m_dreg_interface.  Call register_hw_breakpoint.
1214         (ppc_linux_nat_target::remove_hw_breakpoint): Add comment, use
1215         m_dreg_interface.  Call clear_hw_breakpoint.
1216         (get_trigger_type): Change to...
1217         (ppc_linux_nat_target::get_trigger_type): ...this method.  Add
1218         comment.
1219         (ppc_linux_nat_target::insert_mask_watchpoint): Update comment,
1220         use m_dreg_interface.  Call register_hw_breakpoint.
1221         (ppc_linux_nat_target::remove_mask_watchpoint): Update comment,
1222         use m_dreg_interface.  Call clear_hw_breakpoint.
1223         (can_use_watchpoint_cond_accel): Change to...
1224         (ppc_linux_nat_target::can_use_watchpoint_cond_accel): ...this
1225         method.  Update comment, use m_dreg_interface and
1226         m_process_info.
1227         (calculate_dvc): Change to...
1228         (ppc_linux_nat_target::calculate_dvc): ...this method.  Use
1229         m_dreg_interface.
1230         (num_memory_accesses): Change to...
1231         (ppc_linux_nat_target::num_memory_accesses): ...this method.
1232         (check_condition): Change to...
1233         (ppc_linux_nat_target::check_condition): ...this method.
1234         (ppc_linux_nat_target::can_accel_watchpoint_condition): Update
1235         comment, use m_dreg_interface.
1236         (create_watchpoint_request): Change to...
1237         (ppc_linux_nat_target::create_watchpoint_request): ...this
1238         method.  Use m_dreg_interface.
1239         (ppc_linux_nat_target::insert_watchpoint): Add comment, use
1240         m_dreg_interface.  Call register_hw_breakpoint or register_wp.
1241         (ppc_linux_nat_target::remove_watchpoint): Add comment, use
1242         m_dreg_interface.  Call clear_hw_breakpoint or clear_wp.
1243         (ppc_linux_nat_target::low_forget_process)
1244         (ppc_linux_nat_target::low_new_fork)
1245         (ppc_linux_nat_target::low_new_clone)
1246         (ppc_linux_nat_target::low_delete_thread)
1247         (ppc_linux_nat_target::low_prepare_to_resume): New methods.
1248         (ppc_linux_nat_target::low_new_thread): Remove previous logic,
1249         only call mark_thread_stale.
1250         (ppc_linux_thread_exit): Remove.
1251         (ppc_linux_nat_target::stopped_data_address): Change to...
1252         (ppc_linux_nat_target::low_stopped_data_address): This. Add
1253         comment, use m_dreg_interface and m_thread_hw_breakpoints.
1254         (ppc_linux_nat_target::stopped_by_watchpoint): Change to...
1255         (ppc_linux_nat_target::stopped_by_watchpoint): This.  Add
1256         comment.  Call low_stopped_data_address.
1257         (ppc_linux_nat_target::watchpoint_addr_within_range): Use
1258         m_dreg_interface.
1259         (ppc_linux_nat_target::masked_watch_num_registers): Use
1260         m_dreg_interface.
1261         (ppc_linux_nat_target::copy_thread_dreg_state)
1262         (ppc_linux_nat_target::mark_thread_stale)
1263         (ppc_linux_nat_target::mark_debug_registers_changed)
1264         (ppc_linux_nat_target::register_hw_breakpoint)
1265         (ppc_linux_nat_target::clear_hw_breakpoint)
1266         (ppc_linux_nat_target::register_wp)
1267         (ppc_linux_nat_target::clear_wp)
1268         (ppc_linux_nat_target::init_arch_lwp_info)
1269         (ppc_linux_nat_target::get_arch_lwp_info): New methods.
1270         (_initialize_ppc_linux_nat): Remove observer callback.
1271
1272 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1273
1274         * ppc-linux-nat.c (ppc_linux_nat_target::store_registers)
1275         (ppc_linux_nat_target::auxv_parse)
1276         (ppc_linux_nat_target::read_description)
1277         (supply_gregset, fill_gregset, supply_fpregset, fill_fpregset):
1278         Move up.
1279
1280 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1281
1282         * linux-nat.h (low_new_clone): New method.
1283         * linux-nat.c (linux_handle_extended_wait): Call low_new_clone.
1284
1285 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
1286
1287         * dbxread.c (dbx_psymtab_to_symtab_1): Rename to...
1288         (dbx_expand_psymtab): ... this.
1289         (start_psymtab): Update.
1290         * mdebugread.c (psymtab_to_symtab_1): Rename to...
1291         (mdebug_expand_psymtab): ... this.
1292         (parse_partial_symbols): Update.
1293         (new_psymtab): Update.
1294         * xcoffread.c (xcoff_psymtab_to_symtab_1): Rename to...
1295         (xcoff_expand_psymtab): ... this.
1296         (xcoff_start_psymtab): Update.
1297
1298 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
1299
1300         * psympriv.h (partial_symtab) <read_dependencies>: Rename to...
1301         <expand_dependencies>: ... this.
1302         * psymtab.c (partial_symtab::read_dependencies): Rename to...
1303         (partial_symtab::expand_dependencies): ... this.
1304         * dwarf2/read.c (dwarf2_include_psymtab) <expand_psymtab>:
1305         Update.
1306         (dwarf2_psymtab::expand_psymtab): Update.
1307         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
1308         * mdebugread.c (psymtab_to_symtab_1): Update.
1309         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
1310
1311 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
1312
1313         * psympriv.h (discard_psymtab): Remove.
1314         * dbxread.c (dbx_end_psymtab): Update.
1315         * xcoffread.c (xcoff_end_psymtab): Update.
1316
1317 2020-03-28  Tom Tromey  <tom@tromey.com>
1318
1319         * dwarf2/attribute.h (struct attribute) <form_is_constant>: Update
1320         comment.
1321
1322 2020-03-28  Tom Tromey  <tom@tromey.com>
1323
1324         * dwarf2/read.c (read_attribute_reprocess): Fix formatting.
1325
1326 2020-03-27  Hannes Domani  <ssbssa@yahoo.de>
1327
1328         * windows-nat.c (windows_add_all_dlls): Fix system dll paths.
1329
1330 2020-03-26  John Baldwin  <jhb@FreeBSD.org>
1331
1332         * fbsd-tdep.c (fbsd_print_auxv_entry): Handle AT_FREEBSD_BSDFLAGS.
1333
1334 2020-03-26  Tom Tromey  <tom@tromey.com>
1335
1336         * dwarf2/read.c (handle_data_member_location, dwarf2_add_field)
1337         (mark_common_block_symbol_computed, read_tag_string_type)
1338         (attr_to_dynamic_prop, read_subrange_type): Update.
1339         (dwarf2_get_ref_die_offset, dwarf2_get_attr_constant_value): Move
1340         to be methods on struct attribute.
1341         (skip_one_die, process_imported_unit_die, read_namespace_alias)
1342         (read_call_site_scope, partial_die_info::read)
1343         (partial_die_info::read, lookup_die_type, follow_die_ref):
1344         Update.
1345         * dwarf2/attribute.c (attribute::get_ref_die_offset): New method,
1346         from dwarf2_get_ref_die_offset.
1347         (attribute::constant_value): New method, from
1348         dwarf2_get_attr_constant_value.
1349         * dwarf2/attribute.h (struct attribute) <get_ref_die_offset>:
1350         Declare method.
1351         <constant_value>: New method.
1352
1353 2020-03-26  Tom Tromey  <tom@tromey.com>
1354
1355         * dwarf2/read.c (dwarf_unit_type_name, dwarf_tag_name)
1356         (dwarf_attr_name, dwarf_form_name, dwarf_bool_name)
1357         (dwarf_type_encoding_name): Move to stringify.c.
1358         * Makefile.in (COMMON_SFILES): Add dwarf2/stringify.c.
1359         * dwarf2/stringify.c: New file.
1360         * dwarf2/stringify.h: New file.
1361
1362 2020-03-26  Tom Tromey  <tom@tromey.com>
1363
1364         * dwarf2/die.h (struct die_info) <addr_base, ranges_base>:
1365         Rewrite.
1366
1367 2020-03-26  Tom Tromey  <tom@tromey.com>
1368
1369         * dwarf2/die.h (struct die_info) <addr_base, ranges_base>: New
1370         methods.
1371         * dwarf2/read.c (lookup_addr_base): Move to die.h.
1372         (lookup_ranges_base): Likewise.
1373         (read_cutu_die_from_dwo, read_full_die_1): Update.
1374
1375 2020-03-26  Tom Tromey  <tom@tromey.com>
1376
1377         * dwarf2/read.c (read_import_statement, read_file_scope)
1378         (read_type_unit_scope, inherit_abstract_dies, read_func_scope)
1379         (read_lexical_block_scope, read_call_site_scope)
1380         (dwarf2_get_subprogram_pc_bounds, get_scope_pc_bounds)
1381         (handle_struct_member_die, process_structure_scope)
1382         (update_enumeration_type_from_children)
1383         (process_enumeration_scope, read_array_type, read_common_block)
1384         (read_namespace, read_module, read_subroutine_type): Update.
1385         (sibling_die): Remove.
1386
1387 2020-03-26  Tom Tromey  <tom@tromey.com>
1388
1389         * dwarf2/read.c (lookup_addr_base, lookup_ranges_base)
1390         (build_type_psymtabs_reader, read_structure_type)
1391         (read_enumeration_type, read_full_die_1): Update.
1392         (dwarf2_attr_no_follow): Move to die.h.
1393         * dwarf2/die.h (struct die_info) <attr>: New method.
1394
1395 2020-03-26  Tom Tromey  <tom@tromey.com>
1396
1397         * dwarf2/read.c (struct dwarf2_cu) <base_known>: Remove.
1398         <base_address>: Now an optional.
1399         (dwarf2_find_base_address, dwarf2_rnglists_process)
1400         (dwarf2_ranges_process, fill_in_loclist_baton)
1401         (dwarf2_symbol_mark_computed): Update.
1402
1403 2020-03-26  Tom Tromey  <tom@tromey.com>
1404
1405         * dwarf2/read.c (struct die_info): Move to die.h.
1406         * dwarf2/die.h: New file.
1407
1408 2020-03-26  Tom Tromey  <tom@tromey.com>
1409
1410         * dwarf2/line-header.h (dwarf_decode_line_header): Declare.
1411         * dwarf2/read.c
1412         (dwarf2_statement_list_fits_in_line_number_section_complaint):
1413         Move to line-header.c.
1414         (read_checked_initial_length_and_offset, read_formatted_entries):
1415         Likewise.
1416         (dwarf_decode_line_header): Split into two.
1417         * dwarf2/line-header.c
1418         (dwarf2_statement_list_fits_in_line_number_section_complaint):
1419         Move from read.c.
1420         (read_checked_initial_length_and_offset, read_formatted_entries):
1421         Likewise.
1422         (dwarf_decode_line_header): New function, split from read.c.
1423
1424 2020-03-26  Tom Tromey  <tom@tromey.com>
1425
1426         * dwarf2/read.h (struct dwarf2_per_objfile) <read_line_string>:
1427         Declare method.
1428         * dwarf2/read.c (read_attribute_value): Update.
1429         (dwarf2_per_objfile::read_line_string): Rename from
1430         read_indirect_line_string.
1431         (read_formatted_entries): Update.
1432
1433 2020-03-26  Tom Tromey  <tom@tromey.com>
1434
1435         * dwarf2/macro.c (dwarf_decode_macro_bytes): Use objfile local
1436         variable.
1437
1438 2020-03-26  Tom Tromey  <tom@tromey.com>
1439
1440         * dwarf2/macro.h (dwarf_decode_macros): Make section parameter
1441         const.
1442         * dwarf2/macro.c (skip_form_bytes, skip_unknown_opcode)
1443         (dwarf_decode_macro_bytes, dwarf_decode_macros): Make section
1444         parameter const.
1445
1446 2020-03-26  Tom Tromey  <tom@tromey.com>
1447
1448         * dwarf2/read.c (dwarf_decode_macros): Make "lh" const.
1449         * dwarf2/macro.h (dwarf_decode_macros): Constify "lh" parameter.
1450         * dwarf2/macro.c (macro_start_file): Constify "lh" parameter.
1451         (dwarf_decode_macro_bytes, dwarf_decode_macros): Likewise.
1452
1453 2020-03-26  Tom Tromey  <tom@tromey.com>
1454
1455         * dwarf2/line-header.h (struct line_header) <is_valid_file_index,
1456         file_names_size, file_full_name, file_file_name>: Use const.
1457         <file_name_at, file_names>: Add const overload.
1458         * dwarf2/line-header.c (line_header::file_file_name)
1459         (line_header::file_full_name): Update.
1460
1461 2020-03-26  Tom Tromey  <tom@tromey.com>
1462
1463         * dwarf2/read.c (dwarf2_macro_malformed_definition_complaint)
1464         (macro_start_file, consume_improper_spaces)
1465         (parse_macro_definition, skip_form_bytes, skip_unknown_opcode)
1466         (dwarf_parse_macro_header, dwarf_decode_macro_bytes)
1467         (dwarf_decode_macros): Move to macro.c.
1468         * dwarf2/macro.c: New file.
1469         * dwarf2/macro.h: New file.
1470         * Makefile.in (COMMON_SFILES): Add dwarf2/macro.c.
1471
1472 2020-03-26  Tom Tromey  <tom@tromey.com>
1473
1474         * dwarf2/section.h (struct dwarf2_section_info) <read_string>: New
1475         method.
1476         * dwarf2/section.c: New method.  From
1477         read_indirect_string_at_offset_from.
1478         * dwarf2/read.c (mapped_debug_names::namei_to_name): Update.
1479         (read_indirect_string_at_offset_from): Move to section.c.
1480         (read_indirect_string_at_offset): Rewrite.
1481         (read_indirect_line_string_at_offset): Remove.
1482         (read_indirect_string, read_indirect_line_string)
1483         (dwarf_decode_macro_bytes): Update.
1484
1485 2020-03-26  Tom Tromey  <tom@tromey.com>
1486
1487         * dwarf2/section.h (struct dwarf2_section_info)
1488         <overload_complaint>: Declare.
1489         (dwarf2_section_buffer_overflow_complaint): Don't declare.
1490         * dwarf2/section.c (dwarf2_section_info::overflow_complaint):
1491         Rename from dwarf2_section_buffer_overflow_complaint.
1492         * dwarf2/read.c (skip_one_die, partial_die_info::read)
1493         (skip_form_bytes, dwarf_decode_macro_bytes): Update.
1494
1495 2020-03-26  Tom Tromey  <tom@tromey.com>
1496
1497         * dwarf2/section.h (dwarf2_section_buffer_overflow_complaint):
1498         Declare.
1499         * dwarf2/section.c (dwarf2_section_buffer_overflow_complaint):
1500         Move from read.c.
1501         * dwarf2/read.c (dwarf2_section_buffer_overflow_complaint): Move
1502         to section.c.
1503
1504 2020-03-26  Tom Tromey  <tom@tromey.com>
1505
1506         * dwarf2/read.c (dwarf_decode_macros): Split into two overloads.
1507
1508 2020-03-26  Tom Tromey  <tom@tromey.com>
1509
1510         * dwarf2/read.c (macro_start_file): Change "cu" parameter to
1511         "builder".
1512         (dwarf_decode_macro_bytes): Likewise.  Add dwarf2_per_objfile
1513         parameter.
1514         (dwarf_decode_macros): Update.
1515
1516 2020-03-26  Tom Tromey  <tom@tromey.com>
1517
1518         * dwarf2/read.c (read_attribute_value): Update.
1519         (read_indirect_string_from_dwz): Move to dwz.c; change into
1520         method.
1521         (dwarf_decode_macro_bytes): Update.
1522         * dwarf2/dwz.h (struct dwz_file) <read_string>: Declare method.
1523         * dwarf2/dwz.c: New file.
1524         * Makefile.in (COMMON_SFILES): Add dwz.c.
1525
1526 2020-03-26  Tom Tromey  <tom@tromey.com>
1527
1528         * dwarf2/read.h (struct dwz_file): Move to dwz.h.
1529         * dwarf2/read.c: Add include.
1530         * dwarf2/index-write.c: Add include.
1531         * dwarf2/index-cache.c: Add include.
1532         * dwarf2/dwz.h: New file.
1533
1534 2020-03-25  Tom Tromey  <tom@tromey.com>
1535
1536         * compile/compile-object-load.c (get_out_value_type): Mention
1537         correct symbol name in error message.
1538
1539 2020-03-25  Hannes Domani  <ssbssa@yahoo.de>
1540
1541         * windows-nat.c (windows_add_all_dlls): Fix system dll paths.
1542
1543 2020-03-25  Tom de Vries  <tdevries@suse.de>
1544
1545         * symtab.h (is_main_symtab_of_compunit_symtab): New function.
1546         * symmisc.c (dump_symtab_1): Print user and includes fields.
1547         (maintenance_info_symtabs): Same.
1548
1549 2020-03-25  Andrew Burgess  <andrew.burgess@embecosm.com>
1550
1551         PR gdb/25534
1552         * riscv-tdep.c (riscv_arg_info::c_offset): Update comment.
1553         (riscv_regcache_cooked_write): New function.
1554         (riscv_push_dummy_call): Use new function.
1555         (riscv_return_value): Likewise.
1556
1557 2020-03-24  Simon Marchi  <simon.marchi@polymtl.ca>
1558
1559         * fbsd-nat.c (fbsd_nat_target::follow_fork): Change bool to int.
1560         * fbsd-nat.h (class fbsd_nat_target) <follow_fork>: Likewise.
1561         * inf-ptrace.c (inf_ptrace_target::follow_fork): Likewise.
1562         * inf-ptrace.h (struct inf_ptrace_target) <follow_fork>: Likewise.
1563         * infrun.c (follow_fork): Likewise.
1564         (follow_fork_inferior): Likewise.
1565         * linux-nat.c (linux_nat_target::follow_fork): Likewise.
1566         * linux-nat.h (class linux_nat_target): Likewise.
1567         * remote.c (class remote_target) <follow_fork>: Likewise.
1568         (remote_target::follow_fork): Likewise.
1569         * target-delegates.c: Re-generate.
1570         * target.c (default_follow_fork): Likewise.
1571         (target_follow_fork): Likewise.
1572         * target.h (struct target_ops) <follow_fork>: Likewise.
1573         (target_follow_fork): Likewise.
1574
1575 2020-03-24  Tom de Vries  <tdevries@suse.de>
1576
1577         * psymtab.c (maintenance_info_psymtabs): Print user field.
1578
1579 2020-03-20  Tom Tromey  <tromey@adacore.com>
1580
1581         * dwarf2/loc.h (dwarf2_evaluate_property): Make "addr_stack"
1582         const.
1583         * dwarf2/loc.c (dwarf2_evaluate_property): Make "addr_stack"
1584         const.
1585
1586 2020-03-20  Simon Marchi  <simon.marchi@efficios.com>
1587
1588         * ptrace.m4: Don't check for ptrace declaration.
1589         * config.in: Re-generate.
1590         * configure: Re-generate.
1591         * nat/gdb_ptrace.h: Don't declare ptrace if HAVE_DECL_PTRACE is
1592         not defined.
1593
1594 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
1595
1596         * amd64-bsd-nat.c (gdb_ptrace): Change return type from `int' to
1597         `PTRACE_TYPE_RET'.
1598         * i386-bsd-nat.c (gdb_ptrace): Likewise.
1599         * sparc-nat.c (gdb_ptrace): Likewise.
1600         * x86-bsd-nat.c (gdb_ptrace): Likewise.
1601
1602 2020-03-20  Tom Tromey  <tromey@adacore.com>
1603
1604         * c-exp.y (lex_one_token): Fix assert.
1605
1606 2020-03-20  Tom Tromey  <tromey@adacore.com>
1607
1608         * ada-tasks.c (read_atcb): Use smaller length in strncpy call.
1609         * linux-tdep.c (linux_fill_prpsinfo): Use smaller length in
1610         strncpy call.
1611
1612 2020-03-20  Tom Tromey  <tromey@adacore.com>
1613
1614         * symmisc.c (maintenance_print_one_line_table): Use ui_out.
1615
1616 2020-03-20  Tom Tromey  <tromey@adacore.com>
1617
1618         * ada-valprint.c (print_variant_part): Remove parameters; switch
1619         to value-based API.
1620         (print_field_values): Likewise.
1621         (ada_val_print_struct_union): Likewise.
1622         (ada_value_print_1): Update.
1623
1624 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
1625
1626         * ppc-nbsd-nat.c (ppc_nbsd_nat_target): Inherit from
1627         nbsd_nat_target instead of inf_ptrace_target.
1628         * ppc-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
1629         nbsd_nat_target.
1630
1631 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
1632
1633         * hppa-nbsd-nat.c (fetch_registers): New variable lwp and pass
1634         it to the ptrace call.
1635         * (store_registers): Likewise.
1636
1637 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
1638
1639         * ppc-nbsd-nat.c (fetch_registers): New variable lwp and pass
1640         it to the ptrace call.
1641         * (store_registers): Likewise.
1642
1643 2020-03-19  Luis Machado  <luis.machado@linaro.org>
1644
1645         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): If vg is not
1646         valid, fetch vg value from ptrace.
1647
1648 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
1649         * inf-ptrace.h: Disable get_ptrace_pid on NetBSD.
1650         * inf-ptrace.c: Likewise.
1651         * (gdb_ptrace): Add.
1652         * (inf_ptrace_target::resume): Update.
1653         * (inf_ptrace_target::xfer_partial): Likewise.
1654         * (inf_ptrace_peek_poke): Change argument `pid' to `ptid'.
1655         * (inf_ptrace_peek_poke): Update.
1656
1657 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
1658
1659         * x86-bsd-nat.c (gdb_ptrace): New.
1660         * (x86bsd_dr_set): Add new argument `ptid'.
1661         * (x86bsd_dr_get, x86bsd_dr_set, x86bsd_dr_set_control,
1662         x86bsd_dr_set_addr): Update.
1663
1664 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1665
1666         * remote.c (remote_target::process_stop_reply): Handle events for
1667         all threads differently.
1668
1669 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1670
1671         * completer.c (completion_tracker::remove_completion): Define new
1672         function.
1673         * completer.h (completion_tracker::remove_completion): Declare new
1674         function.
1675         * symtab.c (completion_list_add_symbol): Remove aliasing msymbols
1676         when adding a C++ function symbol.
1677
1678 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1679
1680         * completer.c (completion_tracker::completion_hash_entry): Define
1681         new class.
1682         (advance_to_filename_complete_word_point): Call
1683         recompute_lowest_common_denominator.
1684         (completion_tracker::completion_tracker): Call discard_completions
1685         to setup the hash table.
1686         (completion_tracker::discard_completions): Allow for being called
1687         from the constructor, pass new equal function, and element deleter
1688         when constructing the hash table.  Initialise new class member
1689         variables.
1690         (completion_tracker::maybe_add_completion): Remove use of
1691         m_entries_vec, and store more information into m_entries_hash.
1692         (completion_tracker::recompute_lcd_visitor): New function, most
1693         content taken from...
1694         (completion_tracker::recompute_lowest_common_denominator):
1695         ...here, this now just visits each item in the hash calling the
1696         above visitor.
1697         (completion_tracker::build_completion_result): Remove use of
1698         m_entries_vec, call recompute_lowest_common_denominator.
1699         * completer.h (completion_tracker::have_completions): Remove use
1700         of m_entries_vec.
1701         (completion_tracker::completion_hash_entry): Declare new class.
1702         (completion_tracker::recompute_lowest_common_denominator): Change
1703         function signature.
1704         (completion_tracker::recompute_lcd_visitor): Declare new function.
1705         (completion_tracker::m_entries_vec): Delete.
1706         (completion_tracker::m_entries_hash): Initialize to NULL.
1707         (completion_tracker::m_lowest_common_denominator_valid): New
1708         member variable.
1709         (completion_tracker::m_lowest_common_denominator_max_length): New
1710         member variable.
1711
1712 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
1713
1714         * regformats/regdef.h: Put reg in gdb namespace.
1715
1716 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
1717
1718         * i386-bsd-nat.c (gdb_ptrace): New.
1719         * (i386bsd_fetch_inferior_registers,
1720         i386bsd_store_inferior_registers) Switch from pid_t to ptid_t.
1721         * (i386bsd_fetch_inferior_registers,
1722         i386bsd_store_inferior_registers) Use gdb_ptrace.
1723
1724 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
1725
1726         * amd64-bsd-nat.c (gdb_ptrace): New.
1727         * (amd64bsd_fetch_inferior_registers,
1728         amd64bsd_store_inferior_registers) Switch from pid_t to ptid_t.
1729         * (amd64bsd_fetch_inferior_registers,
1730         amd64bsd_store_inferior_registers) Use gdb_ptrace.
1731
1732 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
1733
1734         * user-regs.c (user_reg::read): Rename to...
1735         (user_reg::xread): ...this.
1736         * (append_user_reg): Rename argument `read' to `xread'.
1737         * (user_reg_add_builtin): Likewise.
1738         * (user_reg_add): Likewise.
1739         * (value_of_user_reg): Likewise.
1740
1741 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
1742
1743         * sparc-nat.c (gdb_ptrace): New.
1744         * sparc-nat.c (sparc_fetch_inferior_registers)
1745         (sparc_store_inferior_registers) Remove obsolete comment.
1746         * sparc-nat.c (sparc_fetch_inferior_registers)
1747         (sparc_store_inferior_registers) Switch from pid_t to ptid_t.
1748         * sparc-nat.c (sparc_fetch_inferior_registers)
1749         (sparc_store_inferior_registers) Use gdb_ptrace.
1750
1751 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
1752
1753         * sh-nbsd-nat.c (fetch_registers): New variable lwp and pass
1754         it to the ptrace call.
1755         * sh-nbsd-nat.c (store_registers): Likewise.
1756
1757 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
1758
1759         * sh-nbsd-nat.c (sh_nbsd_nat_target): Inherit from
1760         nbsd_nat_target instead of inf_ptrace_target.
1761         * sh-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
1762         nbsd_nat_target.
1763
1764 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
1765
1766         * amd64-bsd-nat.c: Include amd64-bsd-nat.h".
1767
1768 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
1769
1770         * nbsd-nat.c: Include <sys/types.h>, <sys/ptrace.h> and
1771         <sys/sysctl.h>.
1772         * nbsd-nat.c (nbsd_nat_target::pid_to_exec_file): Rewrite.
1773
1774 2020-03-17  Tom de Vries  <tdevries@suse.de>
1775
1776         PR gdb/23710
1777         * dwarf2/read.h (struct dwarf2_per_cu_data): Add unit_type and lang
1778         fields.
1779         * dwarf2/read.c (process_psymtab_comp_unit): Initialize unit_type and lang
1780         fields.
1781         (process_imported_unit_die): Skip import of c++ CUs.
1782
1783 2020-03-16  Tom Tromey  <tom@tromey.com>
1784
1785         * p-valprint.c (pascal_object_print_value): Initialize
1786         base_value.
1787
1788 2020-03-16  Anton Kolesov  <anton.kolesov@synopsys.com>
1789             Shahab Vahedi  <shahab@synopsys.com>
1790
1791         * Makefile.in: Add arch/arc.o
1792         * configure.tgt: Likewise.
1793         * arc-tdep.c (arc_tdesc_init): Use arc_read_description.
1794         (_initialize_arc_tdep): Don't initialize old target descriptions.
1795         (arc_read_description): New function to cache target descriptions.
1796         * arc-tdep.h (arc_read_description): Add proto type.
1797         * arch/arc.c: New file.
1798         * arch/arc.h: Likewise.
1799         * features/Makefile: Replace old target descriptions with new.
1800         * features/arc-arcompact.c: Remove.
1801         * features/arc-arcompact.xml: Likewise.
1802         * features/arc-v2.c: Likewise
1803         * features/arc-v2.xml: Likewise
1804         * features/arc/aux-arcompact.xml: New file.
1805         * features/arc/aux-v2.xml: Likewise.
1806         * features/arc/core-arcompact.xml: Likewise.
1807         * features/arc/core-v2.xml: Likewise.
1808         * features/arc/aux-arcompact.c: Generate.
1809         * features/arc/aux-v2.c: Likewise.
1810         * features/arc/core-arcompact.c: Likewise.
1811         * features/arc/core-v2.c: Likewise.
1812         * target-descriptions (maint_print_c_tdesc_cmd): Support ARC features.
1813
1814 2020-03-16  Tom Tromey  <tromey@adacore.com>
1815
1816         PR gdb/25663:
1817         * dwarf2/read.c (dwarf2_name): Strip leading namespaces after
1818         putting value into bcache.
1819
1820 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
1821
1822         PR gdb/21500
1823         * amd64-windows-tdep.c (amd64_windows_init_abi): Rename
1824         to...
1825         (amd64_windows_init_abi_common): ... this.  Don't set size of
1826         long type.
1827         (amd64_windows_init_abi): New function.
1828         (amd64_cygwin_init_abi): New function.
1829         (_initialize_amd64_windows_tdep): Use amd64_cygwin_init_abi for
1830         the Cygwin OS ABI.
1831         * i386-windows-tdep.c (_initialize_i386_windows_tdep): Clarify
1832         comment.
1833
1834 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
1835
1836         * windows-tdep.h (is_linked_with_cygwin_dll): New declaration.
1837         * windows-tdep.c (CYGWIN_DLL_NAME): New.
1838         (pe_import_directory_entry): New struct type.
1839         (is_linked_with_cygwin_dll): New function.
1840         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Select
1841         GDB_OSABI_CYGWIN if the BFD is linked with the Cygwin DLL.
1842         * i386-windows-tdep.c (i386_windows_osabi_sniffer): Likewise.
1843
1844 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
1845
1846         * i386-windows-tdep.c: Mass-rename "cygwin" to "windows", except
1847         i386_cygwin_core_osabi_sniffer.
1848
1849 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
1850
1851         * i386-cygwin-tdep.c: Rename to...
1852         * i386-windows-tdep.c: ... this.
1853         * Makefile.in (ALL_TARGET_OBS): Rename i386-cygwin-tdep.c to
1854         i386-windows-tdep.c.
1855         * configure.tgt: Likewise.
1856
1857 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
1858
1859         * osabi.h (enum gdb_osabi): Add GDB_OSABI_WINDOWS.
1860         * osabi.c (gdb_osabi_names): Add "Windows".
1861         * i386-cygwin-tdep.c (i386_cygwin_osabi_sniffer): Return
1862         GDB_OSABI_WINDOWS when the binary's target is "pei-i386".
1863         (i386_cygwin_core_osabi_sniffer): New function, extracted from
1864         i386_cygwin_osabi_sniffer.
1865         (_initialize_i386_cygwin_tdep): Register OS ABI
1866         GDB_OSABI_WINDOWS for i386.
1867         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Return
1868         GDB_OSABI_WINDOWS when the binary's target is "pei-x86-64".
1869         (_initialize_amd64_windows_tdep): Register OS ABI GDB_OSABI_WINDOWS
1870         for x86-64.
1871         * configure.tgt: Use GDB_OSABI_WINDOWS as the default OS ABI
1872         when the target matches '*-*-mingw*'.
1873
1874 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
1875
1876         * defs.h (enum gdb_osabi): Move to...
1877         * osabi.h (enum gdb_osabi): ... here.
1878         * gdbarch.sh: Include osabi.h in gdbarch.h.
1879         * gdbarch.h: Re-generate.
1880
1881 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
1882
1883         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): New
1884         function.
1885         (_initialize_amd64_windows_tdep): Register osabi sniffer.
1886
1887 2020-03-14  Tom Tromey  <tom@tromey.com>
1888
1889         * c-typeprint.c (cp_type_print_method_args): Print "__restrict__"
1890         for C++.
1891         (c_type_print_modifier): Likewise.  Add "language" parameter.
1892         (c_type_print_varspec_prefix, c_type_print_base_struct_union)
1893         (c_type_print_base_1): Update.
1894         * type-stack.h (enum type_pieces) <tp_atomic, tp_restrict>: New
1895         constants.
1896         * type-stack.c (type_stack::insert): Handle tp_atomic and
1897         tp_restrict.
1898         (type_stack::follow_type_instance_flags): Likewise.
1899         (type_stack::follow_types): Likewise.  Merge type-following code.
1900         * c-exp.y (RESTRICT, ATOMIC): New tokens.
1901         (space_identifier, cv_with_space_id)
1902         (const_or_volatile_or_space_identifier_noopt)
1903         (const_or_volatile_or_space_identifier): Remove.
1904         (single_qualifier, qualifier_seq_noopt, qualifier_seq): New
1905         rules.
1906         (ptr_operator, typebase): Update.
1907         (enum token_flag) <FLAG_C>: New constant.
1908         (ident_tokens): Add "restrict", "__restrict__", "__restrict", and
1909         "_Atomic".
1910         (lex_one_token): Handle FLAG_C.
1911
1912 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
1913
1914         * m68k-bsd-nat.c (fetch_registers): New variable lwp and pass
1915         it to the ptrace call.
1916         * m68k-bsd-nat.c (store_registers): Likewise.
1917
1918 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
1919
1920         * m68k-bsd-nat.c (m68kbsd_supply_gregset): Change type of regs to
1921         gdb_byte *.
1922         * m68k-bsd-nat.c (m68kbsd_supply_fpregset): Likewise.
1923         * m68k-bsd-nat.c (m68kbsd_collect_gregset): Likewise.
1924         * m68k-bsd-nat.c (m68kbsd_supply_pcb): Cast &tmp to gdb_byte *.
1925
1926 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
1927
1928         * m68k-bsd-nat.c (m68k_bsd_nat_target): Inherit from
1929         nbsd_nat_target instead of inf_ptrace_target.
1930         * m68k-bsd-nat.c: Include "nbsd-nat.h", as we are now using
1931         nbsd_nat_target.
1932
1933 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
1934
1935         * m68k-bsd-nat.c: Define _KERNTYPES to get the declaration of
1936         register_t.
1937
1938 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
1939
1940         * alpha-bsd-nat.c (fetch_registers): New variable lwp and pass
1941         it to the ptrace call.
1942         * alpha-bsd-nat.c (store_registers): Likewise.
1943
1944 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
1945
1946         * alpha-bsd-nat.c: Remove <sys/procfs.h> and "gregset.h" from
1947         includes.
1948         * alpha-bsd-nat.c (gregset_t, fpregset_t): Remove.
1949         * alpha-bsd-nat.c (supply_gregset, fill_gregset, supply_fpregset,
1950         fill_fpregset): Likewise.
1951
1952 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
1953
1954         * alpha-bsd-nat.c (alpha_netbsd_nat_target): Inherit from
1955         nbsd_nat_target instead of inf_ptrace_target.
1956         * alpha-bsd-nat.c: Include "nbsd-nat.h", as we are now using
1957         nbsd_nat_target.
1958
1959 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
1960
1961         * alpha-bsd-nat.c: Define _KERNTYPES to get the declaration of
1962         register_t.
1963
1964 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
1965
1966         * arm-nbsd-nat.c (fetch_register): New variable lwp and pass
1967         it to the ptrace call.
1968         * arm-nbsd-nat.c (fetch_fp_register): Likewise.
1969         * arm-nbsd-nat.c (fetch_fp_regs): Likewise.
1970         * arm-nbsd-nat.c (store_register): Likewise.
1971         * arm-nbsd-nat.c (store_regs): Likewise.
1972         * arm-nbsd-nat.c (store_fp_register): Likewise.
1973         * arm-nbsd-nat.c (store_fp_regs): Likewise.
1974
1975 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
1976
1977         * arm-nbsd-nat.c (arm_netbsd_nat_target): Inherit from
1978         nbsd_nat_target instead of inf_ptrace_target.
1979         * arm-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
1980         nbsd_nat_target.
1981
1982 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
1983
1984         * x86-bsd-nat.c (x86bsd_dr_get): New variable lwp and pass
1985         it to the ptrace call.
1986         * x86-bsd-nat.c (x86bsd_dr_set): Likewise.
1987
1988 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
1989
1990         * vax-bsd-nat.c (vaxbsd_supply_gregset): New variable lwp and pass
1991         it to the ptrace call.
1992         * vax-bsd-nat.c (vaxbsd_collect_gregset): Likewise.
1993
1994 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
1995
1996         * vax-bsd-nat.c (vaxbsd_supply_gregset): Cast gregs to const
1997         gdb_byte *.
1998         * vax-bsd-nat.c (vaxbsd_collect_gregset): Cast gregs to void *.
1999
2000 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2001
2002         * vax-bsd-nat.c (vax_bsd_nat_target): Inherit from nbsd_nat_target
2003         instead of inf_ptrace_target.
2004         * vax-bsd-nat.c: Include "nbsd-nat.h", as we are now using
2005         nbsd_nat_target.
2006
2007 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2008
2009         * mips-nbsd-nat.c: Define _KERNTYPES to get the declaration of
2010         register_t.
2011
2012 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2013
2014         * ppc-nbsd-nat.c: Define _KERNTYPES to get the declaration of
2015         register_t.
2016
2017 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2018
2019         * vax-bsd-nat.c: Define _KERNTYPES to get the declaration of
2020         register_t.
2021
2022 2020-03-13  Tom Tromey  <tom@tromey.com>
2023
2024         * value.h (val_print): Don't declare.
2025         * valprint.h (val_print_array_elements)
2026         (val_print_scalar_formatted, generic_val_print): Don't declare.
2027         * valprint.c (generic_val_print_array): Take a struct value.
2028         (generic_val_print_ptr, generic_val_print_memberptr)
2029         (generic_val_print_bool, generic_val_print_int)
2030         (generic_val_print_char, generic_val_print_complex)
2031         (generic_val_print): Remove.
2032         (generic_value_print): Update.
2033         (do_val_print): Remove unused parameters.  Don't call
2034         la_val_print.
2035         (val_print): Remove.
2036         (common_val_print): Update.  Don't call value_check_printable.
2037         (val_print_scalar_formatted, val_print_array_elements): Remove.
2038         * rust-lang.c (rust_val_print): Remove.
2039         (rust_language_defn): Update.
2040         * p-valprint.c (pascal_val_print): Remove.
2041         (pascal_value_print_inner): Update.
2042         (pascal_object_print_val_fields, pascal_object_print_val):
2043         Remove.
2044         (pascal_object_print_static_field): Update.
2045         * p-lang.h (pascal_val_print): Don't declare.
2046         * p-lang.c (pascal_language_defn): Update.
2047         * opencl-lang.c (opencl_language_defn): Update.
2048         * objc-lang.c (objc_language_defn): Update.
2049         * m2-valprint.c (m2_print_unbounded_array, m2_val_print): Remove.
2050         * m2-lang.h (m2_val_print): Don't declare.
2051         * m2-lang.c (m2_language_defn): Update.
2052         * language.h (struct language_defn) <la_val_print>: Remove.
2053         * language.c (unk_lang_value_print_inner): Rename.  Change
2054         argument types.
2055         (unknown_language_defn, auto_language_defn): Update.
2056         * go-valprint.c (go_val_print): Remove.
2057         * go-lang.h (go_val_print): Don't declare.
2058         * go-lang.c (go_language_defn): Update.
2059         * f-valprint.c (f_val_print): Remove.
2060         * f-lang.h (f_value_print): Don't declare.
2061         * f-lang.c (f_language_defn): Update.
2062         * d-valprint.c (d_val_print): Remove.
2063         * d-lang.h (d_value_print): Don't declare.
2064         * d-lang.c (d_language_defn): Update.
2065         * cp-valprint.c (cp_print_value_fields)
2066         (cp_print_value_fields_rtti, cp_print_value): Remove.
2067         (cp_print_static_field): Update.
2068         * c-valprint.c (c_val_print_array, c_val_print_ptr)
2069         (c_val_print_struct, c_val_print_union, c_val_print_int)
2070         (c_val_print_memberptr, c_val_print): Remove.
2071         * c-lang.h (c_val_print_array, cp_print_value_fields)
2072         (cp_print_value_fields_rtti): Don't declare.
2073         * c-lang.c (c_language_defn, cplus_language_defn)
2074         (asm_language_defn, minimal_language_defn): Update.
2075         * ada-valprint.c (ada_val_print_ptr, ada_val_print_num): Remove.
2076         (ada_val_print_enum): Take a struct value.
2077         (ada_val_print_flt, ada_val_print_array, ada_val_print_1)
2078         (ada_val_print): Remove.
2079         (ada_value_print_1): Update.
2080         (printable_val_type): Remove.
2081         * ada-lang.h (ada_val_print): Don't declare.
2082         * ada-lang.c (ada_language_defn): Update.
2083
2084 2020-03-13  Tom Tromey  <tom@tromey.com>
2085
2086         * valprint.c (do_val_print): Update.
2087         * python/python-internal.h (gdbpy_apply_val_pretty_printer): Take
2088         a struct value.
2089         (value_to_value_object_no_release): Declare.
2090         * python/py-value.c (value_to_value_object_no_release): New
2091         function.
2092         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Take a
2093         struct value.
2094         * guile/scm-value.c (vlscm_scm_from_value_no_release): New
2095         function.
2096         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer): Take
2097         a struct value.
2098         * guile/guile-internal.h (vlscm_scm_from_value_no_release):
2099         Declare.
2100         (gdbscm_apply_val_pretty_printer): Take a struct value.
2101         * extension.h (apply_ext_lang_val_pretty_printer): Take a struct
2102         value.
2103         * extension.c (apply_ext_lang_val_pretty_printer): Take a struct
2104         value.
2105         * extension-priv.h (struct extension_language_ops)
2106         <apply_val_pretty_printer>: Take a struct value.
2107         * cp-valprint.c (cp_print_value): Create a struct value.
2108         (cp_print_value): Update.
2109
2110 2020-03-13  Tom Tromey  <tom@tromey.com>
2111
2112         * ada-valprint.c (print_field_values): Call common_val_print.
2113
2114 2020-03-13  Tom Tromey  <tom@tromey.com>
2115
2116         * ada-valprint.c (val_print_packed_array_elements): Remove
2117         bitoffset and val parameters.  Call common_val_print.
2118         (ada_val_print_string): Remove offset, address, and original_value
2119         parameters.
2120         (ada_val_print_array): Update.
2121         (ada_value_print_array): New function.
2122         (ada_value_print_1): Call it.
2123
2124 2020-03-13  Tom Tromey  <tom@tromey.com>
2125
2126         * ada-valprint.c (ada_value_print): Use common_val_print.
2127
2128 2020-03-13  Tom Tromey  <tom@tromey.com>
2129
2130         * ada-valprint.c (ada_val_print_ref): Use common_val_print.
2131
2132 2020-03-13  Tom Tromey  <tom@tromey.com>
2133
2134         * ada-valprint.c (ada_value_print_num): New function.
2135         (ada_value_print_1): Use it.
2136
2137 2020-03-13  Tom Tromey  <tom@tromey.com>
2138
2139         * ada-valprint.c (ada_value_print_1) <TYPE_CODE_FLT>: Rewrite.
2140
2141 2020-03-13  Tom Tromey  <tom@tromey.com>
2142
2143         * ada-valprint.c (ada_value_print_ptr): New function.
2144         (ada_value_print_1): Use it.
2145
2146 2020-03-13  Tom Tromey  <tom@tromey.com>
2147
2148         * ada-valprint.c (ada_val_print_gnat_array): Take a struct value;
2149         call common_val_print.
2150         (ada_val_print_1): Update.
2151         (ada_value_print_1): New function.
2152         (ada_value_print_inner): Rewrite.
2153
2154 2020-03-13  Tom Tromey  <tom@tromey.com>
2155
2156         * cp-valprint.c (cp_print_value_fields): Update.
2157         (cp_print_value): New function.
2158
2159 2020-03-13  Tom Tromey  <tom@tromey.com>
2160
2161         * m2-valprint.c (m2_value_print_inner): Use
2162         cp_print_value_fields.
2163         * cp-valprint.c (cp_print_value_fields): New function.
2164         * c-valprint.c (c_value_print_struct): New function.
2165         (c_value_print_inner): Use c_value_print_struct.
2166         * c-lang.h (cp_print_value_fields): Declare.
2167
2168 2020-03-13  Tom Tromey  <tom@tromey.com>
2169
2170         * c-valprint.c (c_value_print_array): New function.
2171         (c_value_print_inner): Use it.
2172
2173 2020-03-13  Tom Tromey  <tom@tromey.com>
2174
2175         * c-valprint.c (c_value_print_memberptr): New function.
2176         (c_value_print_inner): Use it.
2177
2178 2020-03-13  Tom Tromey  <tom@tromey.com>
2179
2180         * c-valprint.c (c_value_print_int): New function.
2181         (c_value_print_inner): Use it.
2182
2183 2020-03-13  Tom Tromey  <tom@tromey.com>
2184
2185         * c-valprint.c (c_value_print_ptr): New function.
2186         (c_value_print_inner): Use it.
2187
2188 2020-03-13  Tom Tromey  <tom@tromey.com>
2189
2190         * c-valprint.c (c_value_print_inner): Rewrite.
2191
2192 2020-03-13  Tom Tromey  <tom@tromey.com>
2193
2194         * valprint.c (generic_value_print_complex): New function.
2195         (generic_value_print): Use it.
2196
2197 2020-03-13  Tom Tromey  <tom@tromey.com>
2198
2199         * valprint.c (generic_val_print_float): Don't call
2200         val_print_scalar_formatted.
2201         (generic_val_print, generic_value_print): Update.
2202
2203 2020-03-13  Tom Tromey  <tom@tromey.com>
2204
2205         * valprint.c (generic_value_print_char): New function
2206         (generic_value_print): Use it.
2207
2208 2020-03-13  Tom Tromey  <tom@tromey.com>
2209
2210         * valprint.c (generic_value_print_int): New function.
2211         (generic_value_print): Use it.
2212
2213 2020-03-13  Tom Tromey  <tom@tromey.com>
2214
2215         * valprint.c (generic_value_print_bool): New function.
2216         (generic_value_print): Use it.
2217
2218 2020-03-13  Tom Tromey  <tom@tromey.com>
2219
2220         * valprint.c (generic_val_print_func): Simplify.
2221         (generic_val_print, generic_value_print): Update.
2222
2223 2020-03-13  Tom Tromey  <tom@tromey.com>
2224
2225         * valprint.c (generic_val_print_flags): Remove.
2226         (generic_val_print, generic_value_print): Update.
2227         (val_print_type_code_flags): Add original_value parameter.
2228
2229 2020-03-13  Tom Tromey  <tom@tromey.com>
2230
2231         * valprint.c (generic_val_print): Update.
2232         (generic_value_print): Update.
2233         * valprint.c (generic_val_print_enum): Don't call
2234         val_print_scalar_formatted.
2235
2236 2020-03-13  Tom Tromey  <tom@tromey.com>
2237
2238         * valprint.c (generic_value_print): Call generic_value_print_ptr.
2239         * valprint.c (generic_value_print_ptr): New function.
2240
2241 2020-03-13  Tom Tromey  <tom@tromey.com>
2242
2243         * valprint.c (generic_value_print): Rewrite.
2244
2245 2020-03-13  Tom Tromey  <tom@tromey.com>
2246
2247         * p-valprint.c (pascal_object_print_value_fields)
2248         (pascal_object_print_value): New functions.
2249
2250 2020-03-13  Tom Tromey  <tom@tromey.com>
2251
2252         * p-valprint.c (pascal_value_print_inner): Rewrite.
2253
2254 2020-03-13  Tom Tromey  <tom@tromey.com>
2255
2256         * f-valprint.c (f_value_print_innner): Rewrite.
2257
2258 2020-03-13  Tom Tromey  <tom@tromey.com>
2259
2260         * m2-valprint.c (m2_print_unbounded_array): New overload.
2261         (m2_print_unbounded_array): Update.
2262         (m2_print_array_contents): Take a struct value.
2263         (m2_value_print_inner): Rewrite.
2264
2265 2020-03-13  Tom Tromey  <tom@tromey.com>
2266
2267         * d-valprint.c (dynamic_array_type): Call d_value_print_inner.
2268         (d_value_print_inner): New function.
2269         * d-lang.h (d_value_print_inner): Declare.
2270         * d-lang.c (d_language_defn): Use d_value_print_inner.
2271
2272 2020-03-13  Tom Tromey  <tom@tromey.com>
2273
2274         * go-valprint.c (go_value_print_inner): New function.
2275         * go-lang.h (go_value_print_inner): Declare.
2276         * go-lang.c (go_language_defn): Use go_value_print_inner.
2277
2278 2020-03-13  Tom Tromey  <tom@tromey.com>
2279
2280         * rust-lang.c (val_print_struct, rust_print_enum): Use the value
2281         API.
2282         (rust_val_print): Rewrite.
2283         (rust_value_print_inner): New function, from rust_val_print.
2284         (rust_language_defn): Use rust_value_print_inner.
2285
2286 2020-03-13  Tom Tromey  <tom@tromey.com>
2287
2288         * ada-valprint.c (ada_value_print_inner): New function.
2289         * ada-lang.h (ada_value_print_inner): Declare.
2290         * ada-lang.c (ada_language_defn): Use ada_value_print_inner.
2291
2292 2020-03-13  Tom Tromey  <tom@tromey.com>
2293
2294         * f-valprint.c (f_value_print_innner): New function.
2295         * f-lang.h (f_value_print_innner): Declare.
2296         * f-lang.c (f_language_defn): Use f_value_print_innner.
2297
2298 2020-03-13  Tom Tromey  <tom@tromey.com>
2299
2300         * p-valprint.c (pascal_value_print_inner): New function.
2301         * p-lang.h (pascal_value_print_inner): Declare.
2302         * p-lang.c (pascal_language_defn): Use pascal_value_print_inner.
2303
2304 2020-03-13  Tom Tromey  <tom@tromey.com>
2305
2306         * m2-valprint.c (m2_value_print_inner): New function.
2307         * m2-lang.h (m2_value_print_inner): Declare.
2308         * m2-lang.c (m2_language_defn): Use m2_value_print_inner.
2309
2310 2020-03-13  Tom Tromey  <tom@tromey.com>
2311
2312         * opencl-lang.c (opencl_language_defn): Use c_value_print_inner.
2313         * objc-lang.c (objc_language_defn): Use c_value_print_inner.
2314         * c-valprint.c (c_value_print_inner): New function.
2315         * c-lang.h (c_value_print_inner): Declare.
2316         * c-lang.c (c_language_defn, cplus_language_defn)
2317         (asm_language_defn, minimal_language_defn): Use
2318         c_value_print_inner.
2319
2320 2020-03-13  Tom Tromey  <tom@tromey.com>
2321
2322         * p-valprint.c (pascal_object_print_value_fields): Now static.
2323         * p-lang.h (pascal_object_print_value_fields): Don't declare.
2324
2325 2020-03-13  Tom Tromey  <tom@tromey.com>
2326
2327         * c-valprint.c (c_val_print_array): Simplify.
2328
2329 2020-03-13  Tom Tromey  <tom@tromey.com>
2330
2331         * valprint.c (value_print_array_elements): New function.
2332         * valprint.h (value_print_array_elements): Declare.
2333
2334 2020-03-13  Tom Tromey  <tom@tromey.com>
2335
2336         * printcmd.c (print_formatted): Use value_print_scalar_formatted.
2337         * mips-tdep.c (mips_print_register): Use
2338         value_print_scalar_formatted.
2339
2340 2020-03-13  Tom Tromey  <tom@tromey.com>
2341
2342         * valprint.h (value_print_scalar_formatted): Declare.
2343         * valprint.c (value_print_scalar_formatted): New function.
2344
2345 2020-03-13  Tom Tromey  <tom@tromey.com>
2346
2347         * valprint.h (generic_value_print): Declare.
2348         * valprint.c (generic_value_print): New function.
2349
2350 2020-03-13  Tom Tromey  <tom@tromey.com>
2351
2352         * valprint.c (do_val_print): Call la_value_print_inner, if
2353         available.
2354         * rust-lang.c (rust_language_defn): Update.
2355         * p-lang.c (pascal_language_defn): Update.
2356         * opencl-lang.c (opencl_language_defn): Update.
2357         * objc-lang.c (objc_language_defn): Update.
2358         * m2-lang.c (m2_language_defn): Update.
2359         * language.h (struct language_defn) <la_value_print_inner>: New
2360         member.
2361         * language.c (unknown_language_defn, auto_language_defn): Update.
2362         * go-lang.c (go_language_defn): Update.
2363         * f-lang.c (f_language_defn): Update.
2364         * d-lang.c (d_language_defn): Update.
2365         * c-lang.c (c_language_defn, cplus_language_defn)
2366         (asm_language_defn, minimal_language_defn): Update.
2367         * ada-lang.c (ada_language_defn): Update.
2368
2369 2020-03-13  Tom Tromey  <tom@tromey.com>
2370
2371         * c-valprint.c (c_value_print): Use common_val_print.
2372
2373 2020-03-13  Tom Tromey  <tom@tromey.com>
2374
2375         * cp-valprint.c (cp_print_static_field): Use common_val_print.
2376
2377 2020-03-13  Tom Tromey  <tom@tromey.com>
2378
2379         * f-valprint.c (f77_print_array_1, f_val_print): Use
2380         common_val_print.
2381
2382 2020-03-13  Tom Tromey  <tom@tromey.com>
2383
2384         * riscv-tdep.c (riscv_print_one_register_info): Use
2385         common_val_print.
2386
2387 2020-03-13  Tom Tromey  <tom@tromey.com>
2388
2389         * mi/mi-main.c (output_register): Use common_val_print.
2390
2391 2020-03-13  Tom Tromey  <tom@tromey.com>
2392
2393         * infcmd.c (default_print_one_register_info): Use
2394         common_val_print.
2395
2396 2020-03-13  Tom Tromey  <tom@tromey.com>
2397
2398         * valprint.h (common_val_print_checked): Declare.
2399         * valprint.c (common_val_print_checked): New function.
2400         * stack.c (print_frame_arg): Use common_val_print_checked.
2401
2402 2020-03-13  Tom Tromey  <tom@tromey.com>
2403
2404         * valprint.c (do_val_print): New function, from val_print.
2405         (val_print): Use do_val_print.
2406         (common_val_print): Use do_val_print.
2407
2408 2020-03-13  Tom Tromey  <tom@tromey.com>
2409
2410         * valprint.c (value_print): Use scoped_value_mark.
2411
2412 2020-03-13  Tom de Vries  <tdevries@suse.de>
2413
2414         PR symtab/25646
2415         * psymtab.c (partial_symtab::partial_symtab): Don't set
2416         globals_offset and statics_offset.  Push element onto
2417         current_global_psymbols and current_static_psymbols stacks.
2418         (concat): New function.
2419         (end_psymtab_common): Set globals_offset and statics_offset.  Pop
2420         element from current_global_psymbols and current_static_psymbols
2421         stacks.  Concat popped elements to global_psymbols and
2422         static_symbols.
2423         (add_psymbol_to_list): Use current_global_psymbols and
2424         current_static_psymbols stacks.
2425         * psymtab.h (class psymtab_storage): Add current_global_psymbols and
2426         current_static_psymbols fields.
2427
2428 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
2429
2430         * corelow.c (sniff_core_bfd): Remove.
2431         (class core_target) <m_core_vec>: Remove.
2432         (core_target::core_target): Update.
2433         (core_file_fns): Remove.
2434         (deprecated_add_core_fns): Remove.
2435         (default_core_sniffer): Remove.
2436         (sniff_core_bfd): Remove.
2437         (default_check_format): Remove.
2438         (gdb_check_format): Remove.
2439         (core_target_open): Update.
2440         (core_target::get_core_register_section): Update.
2441         (get_core_registers_cb): Update.
2442         (core_target::fetch_registers): Update.
2443         * gdbcore.h (struct core_fns): Remove.
2444         (deprecated_add_core_fns): Remove.
2445         (default_core_sniffer): Remove.
2446         (default_check_format): Remove.
2447
2448 2020-03-12  Tom Tromey  <tom@tromey.com>
2449
2450         * arm-tdep.c (struct arm_mapping_symbol) <value>: Now a
2451         CORE_ADDR.
2452         (struct arm_exidx_entry) <addr>: Now a CORE_ADDR.
2453
2454 2020-03-12  Tom Tromey  <tom@tromey.com>
2455
2456         * remote.c (remote_target::download_tracepoint)
2457         (remote_target::enable_tracepoint)
2458         (remote_target::disable_tracepoint): Use phex, not sprintf_vma.
2459         * breakpoint.c (print_recreate_masked_watchpoint): Use phex, not
2460         sprintf_vma.
2461
2462 2020-03-12  Tom Tromey  <tom@tromey.com>
2463
2464         * symfile-mem.c: Update CORE_ADDR size assert.
2465
2466 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
2467
2468         * selftest.m4: Move to gdbsupport/.
2469         * acinclude.m4: Update path to selftest.m4.
2470
2471 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
2472
2473         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Rename to...
2474         (SELFTESTS_SRCS): ... this.  Add disasm-selftests.c,
2475         gdbarch-selfselftests.c and selftest-arch.c.
2476         (SUBDIR_UNITTESTS_OBS): Rename to...
2477         (SELFTESTS_OBS): ... this.
2478         (COMMON_SFILES): Remove disasm-selftests.c and
2479         gdbarch-selftests.c.
2480         * configure.ac: Don't add selftest-arch.{c,o} to
2481         CONFIG_{SRCS,OBS}.
2482         * disasm-selftests.c, gdbarch-selftests.c: Remove GDB_SELF_TEST
2483         preprocessor conditions.
2484
2485 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
2486
2487         * configure.ac: Don't source bfd/development.sh.
2488         * selftest.m4: Modify comment.
2489         * configure: Re-generate.
2490
2491 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
2492
2493         * selftest.m4 (GDB_AC_SELFTEST): Error out if $development is
2494         not "true" or "false".
2495         * configure: Re-generate.
2496
2497 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
2498
2499         * Makefile.in (HFILES_NO_SRCDIR): Add new arm-nbsd-tdep.h file.
2500         * arm-nbsd-nat.c (arm_supply_gregset): Moved to arm-nbsd-tdep and
2501         renamed to arm_nbsd_supply_gregset.
2502         (fetch_register): Update to call arm_nbsd_supply_gregset.
2503         (fetch_regs): Remove in favor of fetch_register with a -1 regno.
2504         (arm_netbsd_nat_target::fetch_registers): Update.
2505         (fetch_elfcore_registers): Removed.
2506         (_initialize_arm_netbsd_nat): Removed call to deprecated_add_core_fns.
2507         * arm-nbsd-tdep.c (struct arm_nbsd_reg): New struct.
2508         (arm_nbsd_supply_gregset): Moved from arm-nbsd-nat.c and updated to
2509         not require NetBSD system headers.
2510         (arm_nbsd_regset): New struct.
2511         (arm_nbsd_iterate_over_regset_sections): New function.
2512         (arm_netbsd_init_abi_common): Updated to call
2513         set_gdbarch_iterate_over_regset_sections.
2514         * arm-nbsd-tdep.h: New file.
2515
2516 2020-03-11  Kevin Buettner  <kevinb@redhat.com>
2517
2518         * symtab.c (find_pc_sect_line): Add check which prevents infinite
2519         recursion.
2520
2521 2020-03-11  Simon Marchi  <simon.marchi@efficios.com>
2522
2523         * configure: Re-generate.
2524
2525 2020-03-11  Tom Tromey  <tromey@adacore.com>
2526
2527         * ada-typeprint.c (print_choices): Fix comment.
2528
2529 2020-03-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2530
2531         * buildsyms.c (buildsym_compunit::record_line): Avoid accessing
2532         previous item in the list, when the list has no items.
2533
2534 2020-03-11  Tom de Vries  <tdevries@suse.de>
2535
2536         * dwarf2/loc.c (dwarf2_evaluate_property): Handle NULL frame in
2537         PROP_LOCLIST handling code.
2538
2539 2020-03-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2540
2541         * buildsym-legacy.c (record_line): Pass extra parameter to
2542         record_line.
2543         * buildsym.c (buildsym_compunit::record_line): Take an extra
2544         parameter, reduce duplication in the line table, and record the
2545         is_stmt flag in the line table.
2546         * buildsym.h (buildsym_compunit::record_line): Add extra
2547         parameter.
2548         * disasm.c (do_mixed_source_and_assembly_deprecated): Ignore
2549         non-statement lines.
2550         * dwarf2/read.c (dwarf_record_line_1): Add extra parameter, pass
2551         this to the symtab builder.
2552         (dwarf_finish_line): Pass extra parameter to dwarf_record_line_1.
2553         (lnp_state_machine::record_line): Pass a suitable is_stmt flag
2554         through to dwarf_record_line_1.
2555         * infrun.c (process_event_stop_test): When stepping, don't stop at
2556         a non-statement instruction, and only refresh the step info when
2557         we land in the middle of a line's range.  Also add an extra
2558         comment.
2559         * jit.c (jit_symtab_line_mapping_add_impl): Initialise is_stmt
2560         field.
2561         * record-btrace.c (btrace_find_line_range): Only record lines
2562         marked as is-statement.
2563         * stack.c (frame_show_address): Show the frame address if we are
2564         in a non-statement sal.
2565         * symmisc.c (dump_symtab_1): Print the is_stmt flag.
2566         (maintenance_print_one_line_table): Print a header for the is_stmt
2567         column, and include is_stmt information in the output.
2568         * symtab.c (find_pc_sect_line): Find lines marked as statements in
2569         preference to non-statements.
2570         (find_pcs_for_symtab_line): Prefer is-statement entries.
2571         (find_line_common): Likewise.
2572         * symtab.h (struct linetable_entry): Add is_stmt field.
2573         (struct symtab_and_line): Likewise.
2574         * xcoffread.c (arrange_linetable): Initialise is_stmt field when
2575         arranging the line table.
2576
2577 2020-03-07  Tom de Vries  <tdevries@suse.de>
2578
2579         * dwarf2/read.c (read_typedef): Treat anonymous typedef as forwarder
2580         DIE.
2581
2582 2020-03-07  Tom Tromey  <tom@tromey.com>
2583
2584         * valops.c (value_literal_complex): Remove obsolete comment.
2585         * gdbtypes.h (enum type_code) <TYPE_CODE_FLT>: Remove obsolete
2586         comment.
2587
2588 2020-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
2589
2590         * infrun.h: Forward-declare thread_info.
2591         (set_step_info): Add thread_info parameter, add doc.
2592         * infrun.c (set_step_info): Add thread_info parameter, move doc
2593         to header.
2594         * infrun.c (process_event_stop_test): Pass thread to
2595         set_step_info call.
2596         * infcmd.c (set_step_frame): Add thread_info pointer, pass it to
2597         set_step_info.
2598         (prepare_one_step): Add thread_info parameter, pass it to
2599         set_step_frame and prepare_one_step (recursive) call.
2600         (step_1): Pass thread to prepare_one_step call.
2601         (step_command_fsm::should_stop): Pass thread to
2602         prepare_one_step.
2603         (until_next_fsm): Pass thread to set_step_frame call.
2604         (finish_command): Pass thread to set_step_info call.
2605
2606 2020-03-06  Hannes Domani  <ssbssa@yahoo.de>
2607
2608         * windows-tdep.c (windows_solib_create_inferior_hook):
2609         Check if inferior is running.
2610
2611 2020-03-06  Tom de Vries  <tdevries@suse.de>
2612
2613         * NEWS: Fix "the the".
2614         * ctfread.c: Same.
2615
2616 2020-03-06  Tom de Vries  <tdevries@suse.de>
2617
2618         * psymtab.c (psymtab_to_symtab): Don't print "done.".
2619
2620 2020-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2621
2622         * .dir-locals.el: Add a comment referencing the other copies of
2623         this file.
2624
2625 2020-03-05  John Baldwin  <jhb@FreeBSD.org>
2626
2627         * fbsd-tdep.c (fbsd_make_corefile_notes): Use std::string for
2628         psargs.
2629
2630 2020-03-05  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2631
2632         * .gitattributes: New file.
2633
2634 2020-03-04  Tom Tromey  <tom@tromey.com>
2635
2636         * symmisc.c (print_symbol_bcache_statistics)
2637         (print_objfile_statistics): Update.
2638         * symfile.c (allocate_symtab): Use intern.
2639         * psymtab.c (partial_symtab::partial_symtab): Use intern.
2640         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
2641         macro_cache>: Remove.
2642         <string_cache>: New member.
2643         (struct objfile) <intern>: New methods.
2644         * elfread.c (elf_symtab_read): Use intern.
2645         * dwarf2/read.c (fixup_go_packaging): Intern package name.
2646         (dwarf2_compute_name, dwarf2_physname)
2647         (create_dwo_unit_in_dwp_v1, create_dwo_unit_in_dwp_v2): Intern
2648         names.
2649         (guess_partial_die_structure_name): Update.
2650         (partial_die_info::fixup): Intern name.
2651         (dwarf2_canonicalize_name): Change parameter to objfile.  Intern
2652         name.
2653         (dwarf2_name): Intern name.  Update.
2654         * buildsym.c (buildsym_compunit::get_macro_table): Use
2655         string_cache.
2656
2657 2020-03-04  Tom Tromey  <tom@tromey.com>
2658
2659         * jit.c (bfd_open_from_target_memory): Make "target" const.
2660         * corefile.c (gnutarget): Now const.
2661         * gdbcore.h (gnutarget): Now const.
2662
2663 2020-03-04  Hannes Domani  <ssbssa@yahoo.de>
2664
2665         * NEWS: Mention support for WOW64 processes.
2666         * amd64-windows-nat.c (amd64_mappings): Rename and remove static.
2667         (amd64_windows_segment_register_p): Remove static.
2668         (_initialize_amd64_windows_nat): Update.
2669         * configure.nat <windows> (NATDEPFILES): Add i386-windows-nat.o.
2670         * i386-windows-nat.c (context_offset): Update.
2671         (i386_mappings): Rename and remove static.
2672         (i386_windows_segment_register_p): Remove static.
2673         (_initialize_i386_windows_nat): Update.
2674         * windows-nat.c (STATUS_WX86_BREAKPOINT): New macro.
2675         (STATUS_WX86_SINGLE_STEP): New macro.
2676         (EnumProcessModulesEx): New macro.
2677         (Wow64SuspendThread): New macro.
2678         (Wow64GetThreadContext): New macro.
2679         (Wow64SetThreadContext): New macro.
2680         (Wow64GetThreadSelectorEntry): New macro.
2681         (windows_set_context_register_offsets): Add static.
2682         (windows_set_segment_register_p): Likewise.
2683         (windows_add_thread): Adapt for WOW64 processes.
2684         (windows_fetch_one_register): Likewise.
2685         (windows_nat_target::fetch_registers): Likewise.
2686         (windows_store_one_register): Likewise.
2687         (display_selector): Likewise.
2688         (display_selectors): Likewise.
2689         (handle_exception): Likewise.
2690         (windows_continue): Likewise.
2691         (windows_nat_target::resume): Likewise.
2692         (windows_add_all_dlls): Likewise.
2693         (do_initial_windows_stuff): Likewise.
2694         (windows_nat_target::attach): Likewise.
2695         (windows_get_exec_module_filename): Likewise.
2696         (windows_nat_target::create_inferior): Likewise.
2697         (windows_xfer_siginfo): Likewise.
2698         (_initialize_loadable): Initialize Wow64SuspendThread,
2699         Wow64GetThreadContext, Wow64SetThreadContext,
2700         Wow64GetThreadSelectorEntry and EnumProcessModulesEx.
2701         * windows-nat.h (windows_set_context_register_offsets):
2702         Remove declaration.
2703         (windows_set_segment_register_p): Likewise.
2704         (i386_windows_segment_register_p): Add declaration.
2705         (amd64_windows_segment_register_p): Likewise.
2706
2707 2020-03-04  Luis Machado  <luis.machado@linaro.org>
2708
2709         Revert aa66aac47b4dd38f9524ddb5546c08cc09930d37 due to regressions
2710         in "info registers" for AArch64/ARM.
2711
2712         The change caused "info registers" to not print GPR's.
2713
2714         gdb/ChangeLog:
2715
2716         2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
2717
2718         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
2719         when reg->group is empty and reggroup is not.
2720
2721 2020-03-03  Tom Tromey  <tromey@adacore.com>
2722
2723         * dwarf2/frame.c (struct dwarf2_frame_cache)
2724         <checked_tailcall_bottom, entry_cfa_sp_offset,
2725         entry_cfa_sp_offset_p>: Remove members.
2726         (dwarf2_frame_cache): Call dwarf2_tailcall_sniffer_first.
2727         (dwarf2_frame_prev_register): Don't call
2728         dwarf2_tailcall_sniffer_first.
2729         (dwarf2_append_unwinders): Don't append tailcall unwinder.
2730         * frame-unwind.c (add_unwinder): New fuction.
2731         (frame_unwind_init): Use it.  Add tailcall unwinder.
2732
2733 2020-03-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2734             Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
2735
2736         * f-valprint.c (f_val_print): Handle TYPE_CODE_BOOL, any non-zero
2737         value should be printed as true.
2738
2739 2020-03-03  Hannes Domani  <ssbssa@yahoo.de>
2740
2741         * windows-tdep.c (windows_solib_create_inferior_hook): New function.
2742         (windows_init_abi): Set and use windows_so_ops.
2743
2744 2020-03-03  Sergio Durigan Junior  <sergiodj@redhat.com>
2745
2746         * printcmd.c (print_c_string): Check also for TYPE_CODE_PTR
2747         when verifying if dealing with a convenience variable.
2748
2749 2020-03-03  Luis Machado  <luis.machado@linaro.org>
2750
2751         * auxv.c (default_print_auxv_entry): Add new AUXV entries.
2752
2753 2020-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
2754
2755         * infrun.c (gdbarch_supports_displaced_stepping): New.
2756         (use_displaced_stepping): Break up conditions in smaller pieces.
2757         Use gdbarch_supports_displaced_stepping.
2758         (displaced_step_prepare_throw): Use
2759         gdbarch_supports_displaced_stepping.
2760
2761 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2762
2763         * NEWS: Mention new behaviour of the history filename.
2764         * top.c (write_history_p): Add comment.
2765         (show_write_history_p): Add header comment, give a different
2766         message when history writing is on, but the history filename is
2767         empty.
2768         (history_filename): Add comment.
2769         (history_filename_empty): New function.
2770         (show_history_filename): Add header comment, give a different
2771         message when the filename is empty.
2772         (init_history): Compare history_filename against nullptr, and only
2773         read history if the filename is not empty.
2774         (set_history_filename): Add header comment, and only make
2775         non-empty filenames absolute.
2776         (init_main): Make the filename argument to 'set history filename'
2777         optional.
2778
2779 2020-03-02  Christian Biesinger  <cbiesinger@google.com>
2780
2781         * arm-nbsd-nat.c (arm_supply_fparegset): Rename to...
2782         (arm_supply_vfpregset): ...this, and update to use VFP registers.
2783         (fetch_fp_register): Update.
2784         (fetch_fp_regs): Update.
2785         (store_fp_register): Update.
2786         (store_fp_regs): Update.
2787         (arm_netbsd_nat_target::read_description): New function.
2788         (fetch_elfcore_registers): Update.
2789
2790 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2791
2792         * remote.c (remote_target::remote_parse_stop_reply): Don't use the
2793         general_thread if the stop reply is missing a thread-id.
2794         (remote_target::process_stop_reply): Use the first non-exited
2795         thread if the target didn't pass a thread-id.
2796         * infrun.c (do_target_wait): Move call to
2797         switch_to_inferior_no_thread to ....
2798         (do_target_wait_1): ... here.
2799
2800 2020-02-29  Jon Turney  <jon.turney@dronecode.org.uk>
2801
2802         * debuginfod-support.c: Include defs.h first.
2803
2804 2020-02-28  Tom de Vries  <tdevries@suse.de>
2805
2806         * symfile.c (set_initial_language): Use default language for lookup.
2807
2808 2020-02-28  Simon Marchi  <simon.marchi@efficios.com>
2809
2810         * dwarf2/read.c (cutu_reader::init_tu_and_read_dwo_dies): Remove
2811         reader variable, pass `this` to read_cutu_die_from_dwo.
2812
2813 2020-02-27  Aaron Merey  <amerey@redhat.com>
2814
2815         * source.c (open_source_file): Check for nullptr when computing
2816         srcpath.
2817
2818 2020-02-27  Tom Tromey  <tromey@adacore.com>
2819
2820         * dwarf2/read.c (struct field_info) <nfields>: Now a method, not a
2821         member.
2822         (dwarf2_add_field): Don't update nfields.
2823         (dwarf2_attach_fields_to_type, process_structure_scope): Update.
2824
2825 2020-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2826
2827         * gdbtypes.c (create_array_type_with_stride): Use std::abs not
2828         abs.
2829
2830 2020-02-26  Tom Tromey  <tom@tromey.com>
2831
2832         * dwarf2/read.c (struct dwarf2_include_psymtab): New.
2833         (dwarf2_create_include_psymtab): Use dwarf2_include_psymtab.
2834         (dwarf2_psymtab::expand_psymtab, dwarf2_psymtab::readin_p)
2835         (dwarf2_psymtab::get_compunit_symtab): Remove null checks for
2836         per_cu_data.
2837
2838 2020-02-26  Tom Tromey  <tom@tromey.com>
2839
2840         * dwarf2/index-write.c (psym_index_map): Change type.
2841         (add_address_entry_worker, write_one_signatured_type)
2842         (recursively_count_psymbols, recursively_write_psymbols)
2843         (class debug_names, psyms_seen_size, write_gdbindex)
2844         (write_debug_names): Use partial_symtab, not dwarf2_psymtab.
2845
2846 2020-02-26  Aaron Merey  <amerey@redhat.com>
2847
2848         * Makefile.in: Handle optional debuginfod support.
2849         * NEWS: Update.
2850         * README: Add --with-debuginfod summary.
2851         * config.in: Regenerate.
2852         * configure: Regenerate.
2853         * configure.ac: Handle optional debuginfod support.
2854         * debuginfod-support.c: debuginfod helper functions.
2855         * debuginfod-support.h: Ditto.
2856         * doc/gdb.texinfo: Add --with-debuginfod to configure options
2857         summary.
2858         * dwarf2/read.c (dwarf2_get_dwz_file): Query debuginfod servers
2859         when a dwz file cannot be found.
2860         * elfread.c (elf_symfile_read): Query debuginfod servers when a
2861         debuginfo file cannot be found.
2862         * source.c (open_source_file): Query debuginfod servers when a
2863         source file cannot be found.
2864         * top.c (print_gdb_configuration): Include
2865         --{with,without}-debuginfod in the output.
2866
2867 2020-02-26  Jérémie Galarneau  <jeremie.galarneau@efficios.com>
2868
2869         * thread.c (thr_try_catch_cmd): Print thread name.
2870
2871 2020-02-26  Simon Marchi  <simon.marchi@efficios.com>
2872
2873         * dwarf2/loc.h (dwarf2_fetch_die_loc_sect_off,
2874         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
2875         dwarf2_fetch_die_type_sect_off): Move to...
2876         * dwarf2/read.h (dwarf2_fetch_die_loc_sect_off,
2877         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
2878         dwarf2_fetch_die_type_sect_off): ... here.
2879         * dwarf2/read.c (dwarf2_fetch_die_loc_sect_off,
2880         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
2881         dwarf2_fetch_die_type_sect_off): Move doc to header file.
2882
2883 2020-02-26  Tom de Vries  <tdevries@suse.de>
2884
2885         PR gdb/25603
2886         * symfile.c (set_initial_language): Exit-early if
2887         language_mode == language_mode_manual.
2888
2889 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
2890
2891         * dwarf2/loc.h (dwarf2_read_addr_index): Move...
2892         * dwarf2/read.h (dwarf2_read_addr_index): ... here.
2893         * dwarf2/read.c (dwarf2_read_addr_index): Move doc to header.
2894
2895 2020-02-25  Andrew Burgess  <andrew.burgess@embecosm.com>
2896
2897         * gdbtypes.c (create_array_type_with_stride): Handle negative
2898         array strides.
2899         * valarith.c (value_subscripted_rvalue): Likewise.
2900
2901 2020-02-25  Luis Machado  <luis.machado@linaro.org>
2902
2903         * aarch64-tdep.c (aarch64_vnv_type): Fix comment typo.
2904
2905 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
2906
2907         * loc.h (dwarf2_get_die_type): Move to...
2908         * read.h (dwarf2_get_die_type): ... here.
2909         * read.c (dwarf2_get_die_type): Move doc to header.
2910
2911 2020-02-25  Joel Brobecker  <brobecker@adacore.com>
2912
2913         * copypright.py (EXCLUDE_LIST): Add 'gnulib/config.in' and
2914         'gnulib/Makefile.in' to the list.
2915
2916 2020-02-24  Tom Tromey  <tom@tromey.com>
2917
2918         * dwarf2/read.h (struct type_unit_unshareable) <num_symtabs>:
2919         Remove.
2920         * dwarf2/read.c (dwarf2_cu::setup_type_unit_groups): Use
2921         XOBNEWVEC.
2922
2923 2020-02-24  Tom Tromey  <tom@tromey.com>
2924
2925         * dwarf2/read.h (struct dwarf2_per_cu_data) <type_unit_group_p>:
2926         New method.
2927         * dwarf2/read.c (IS_TYPE_UNIT_GROUP): Remove.
2928         (dw2_do_instantiate_symtab, dw2_get_file_names)
2929         (build_type_psymtab_dependencies, load_full_type_unit): Update.
2930
2931 2020-02-24  Tom Tromey  <tom@tromey.com>
2932
2933         * dwarf2read.c (dwarf2_build_psymtabs_hard): Use
2934         make_scoped_restore.
2935         (dwarf2_psymtab::read_symtab): Don't clear
2936         reading_partial_symbols.
2937
2938 2020-02-24  Tom de Vries  <tdevries@suse.de>
2939
2940         PR gdb/25592
2941         * stack.c (iterate_over_block_locals): Handle LOC_CONST.
2942
2943 2020-02-24  Tom de Vries  <tdevries@suse.de>
2944
2945         * tui/tui-layout.c (_initialize_tui_layout): Fix help messages for
2946         commands layout next/prev/regs.
2947
2948 2020-02-22  Tom Tromey  <tom@tromey.com>
2949
2950         * dwarf2/loc.h (dwarf2_compile_expr_to_ax): Don't declare.
2951         * dwarf2/loc.c (dwarf2_compile_expr_to_ax): Now static.
2952
2953 2020-02-22  Tom Tromey  <tom@tromey.com>
2954
2955         * tui/tui-data.h (TUI_DISASM_WIN): Cast to tui_disasm_window.
2956
2957 2020-02-22  Tom Tromey  <tom@tromey.com>
2958
2959         * tui/tui-win.c (_initialize_tui_win): Add usage text.
2960         * tui/tui-stack.c (_initialize_tui_stack): Add usage text.
2961         * tui/tui-regs.c (_initialize_tui_regs): Add usage text.
2962         * tui/tui.c (_initialize_tui): Add usage text.
2963
2964 2020-02-22  Tom Tromey  <tom@tromey.com>
2965
2966         * tui/tui-win.c (tui_set_focus_command)
2967         (tui_set_win_height_command): Use error_no_arg.
2968         (_initialize_tui_win): Update help text.
2969         (FOCUS_USAGE, WIN_HEIGHT_USAGE): Don't define.
2970
2971 2020-02-22  Tom Tromey  <tom@tromey.com>
2972
2973         * tui/tui-layout.c (extract_display_start_addr): Rewrite.
2974         * tui/tui-disasm.h (struct tui_disasm_window)
2975         <display_start_addr>: Declare.
2976         * tui/tui-source.h (struct tui_source_window)
2977         <display_start_addr>: Declare.
2978         * tui/tui-winsource.h (struct tui_source_window_base)
2979         <show_source_line, display_start_addr>: New methods.
2980         <m_horizontal_offset, m_start_line_or_addr, m_gdbarch, m_content>:
2981         Rename and move to protected section.
2982         * tui/tui-winsource.c (tui_source_window_base::update_source_window)
2983         (tui_source_window_base::do_erase_source_content): Update.
2984         (tui_source_window_base::show_source_line): Now a method.
2985         (tui_source_window_base::show_source_content)
2986         (tui_source_window_base::tui_source_window_base)
2987         (tui_source_window_base::rerender)
2988         (tui_source_window_base::refill)
2989         (tui_source_window_base::do_scroll_horizontal)
2990         (tui_source_window_base::set_is_exec_point_at)
2991         (tui_source_window_base::update_breakpoint_info)
2992         (tui_source_window_base::update_exec_info): Update.
2993         * tui/tui-source.c (tui_source_window::set_contents)
2994         (tui_source_window::showing_source_p)
2995         (tui_source_window::do_scroll_vertical)
2996         (tui_source_window::location_matches_p)
2997         (tui_source_window::line_is_displayed): Update.
2998         (tui_source_window::display_start_addr): New method.
2999         * tui/tui-disasm.c (tui_disasm_window::set_contents)
3000         (tui_disasm_window::do_scroll_vertical)
3001         (tui_disasm_window::location_matches_p): Update.
3002         (tui_disasm_window::display_start_addr): New method.
3003
3004 2020-02-22  Tom Tromey  <tom@tromey.com>
3005
3006         * NEWS: Add entry for gdb.register_window_type.
3007         * tui/tui-layout.h (window_factory): New typedef.
3008         (tui_register_window): Declare.
3009         * tui/tui-layout.c (saved_tui_windows): New global.
3010         (tui_apply_current_layout): Use it.
3011         (tui_register_window): New function.
3012         * python/python.c (do_start_initialization): Call
3013         gdbpy_initialize_tui.
3014         (python_GdbMethods): Add "register_window_type" function.
3015         * python/python-internal.h (gdbpy_register_tui_window)
3016         (gdbpy_initialize_tui): Declare.
3017         * python/py-tui.c: New file.
3018         * Makefile.in (SUBDIR_PYTHON_SRCS): Add py-tui.c.
3019
3020 2020-02-22  Tom Tromey  <tom@tromey.com>
3021
3022         * tui/tui-io.c (do_tui_putc): Don't omit annotations.
3023
3024 2020-02-22  Tom Tromey  <tom@tromey.com>
3025
3026         * tui/tui-win.c (tui_set_win_focus_to): Move to tui-data.c.
3027         * tui/tui-data.h (tui_set_win_with_focus): Don't declare.
3028         * tui/tui-data.c (tui_set_win_with_focus): Remove.
3029         (tui_set_win_focus_to): Move from tui-win.c.
3030
3031 2020-02-22  Tom Tromey  <tom@tromey.com>
3032
3033         * tui/tui-layout.c (make_standard_window, get_locator_window): New
3034         functions.
3035         (known_window_types): New global.
3036         (tui_get_window_by_name): Reimplement.
3037         (initialize_known_windows): New function.
3038         (validate_window_name): Rewrite.
3039         (_initialize_tui_layout): Call initialize_known_windows.
3040
3041 2020-02-22  Tom Tromey  <tom@tromey.com>
3042
3043         * tui/tui.h (enum tui_win_type) <LOCATOR_WIN, DATA_ITEM_WIN>:
3044         Remove constants.
3045         * tui/tui-winsource.h (struct tui_source_window_base)
3046         <tui_source_window_base>: Remove parameter.
3047         * tui/tui-winsource.c
3048         (tui_source_window_base::tui_source_window_base): Remove
3049         parameter.
3050         (tui_source_window_base::refill): Update.
3051         * tui/tui-stack.h (struct tui_locator_window)
3052         <tui_locator_window>: Update.
3053         * tui/tui-source.h (struct tui_source_window) <tui_source_window>:
3054         Default the constructor.
3055         * tui/tui-regs.h (struct tui_data_item_window)
3056         <tui_data_item_window>: Default the constructor.
3057         (struct tui_data_window) <tui_data_window>: Likewise.
3058         * tui/tui-disasm.h (struct tui_disasm_window) <tui_disasm_window>:
3059         Default the constructor.
3060         * tui/tui-data.h (struct tui_gen_win_info) <tui_gen_win_info>:
3061         Default the constructor.
3062         <type>: Remove.
3063         (struct tui_win_info) <tui_win_info>: Default the constructor.
3064         * tui/tui-data.c (tui_win_info::tui_win_info): Remove.
3065         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
3066         Default the constructor.
3067
3068 2020-02-22  Tom Tromey  <tom@tromey.com>
3069
3070         * tui/tui-wingeneral.h (tui_make_all_invisible): Don't declare.
3071         * tui/tui-wingeneral.c (tui_make_all_invisible): Remove.
3072         * tui/tui-win.c (tui_resize_all): Don't call
3073         tui_delete_invisible_windows.
3074         * tui/tui-layout.c (tui_apply_current_layout): Delete windows when
3075         done.
3076         (tui_set_layout): Update.
3077         (tui_add_win_to_layout): Don't call tui_delete_invisible_windows.
3078         * tui/tui-data.h (tui_delete_invisible_windows): Don't declare.
3079         * tui/tui-data.c (tui_delete_invisible_windows): Remove.
3080
3081 2020-02-22  Tom Tromey  <tom@tromey.com>
3082
3083         * tui/tui-win.c (tui_partial_win_by_name): Handle ambiguity
3084         correctly.
3085
3086 2020-02-22  Tom Tromey  <tom@tromey.com>
3087
3088         * tui/tui-data.c (tui_next_win, tui_prev_win): Reimplement.
3089
3090 2020-02-22  Tom Tromey  <tom@tromey.com>
3091
3092         * tui/tui-winsource.h (struct tui_source_window_iterator)
3093         <inner_iterator>: New etytypedef.
3094         <tui_source_window_iterator>: Take "end" parameter.
3095         <tui_source_window_iterator>: Take iterator.
3096         <operator*, advance>: Update.
3097         <m_iter>: Change type.
3098         <m_end>: New field.
3099         (struct tui_source_windows) <begin, end>: Update.
3100         * tui/tui-layout.c (tui_windows): New global.
3101         (tui_apply_current_layout): Clear tui_windows.
3102         (tui_layout_window::apply): Update tui_windows.
3103         * tui/tui-data.h (tui_windows): Declare.
3104         (all_tui_windows): Now inline function.
3105         (class tui_window_iterator, struct all_tui_windows): Remove.
3106
3107 2020-02-22  Tom Tromey  <tom@tromey.com>
3108
3109         PR tui/17850:
3110         * tui/tui-win.c (tui_gen_win_info::max_width): New method.
3111         * tui/tui-layout.h (class tui_layout_base) <get_sizes>: Add
3112         "height" argument.
3113         (class tui_layout_window) <get_sizes>: Likewise.
3114         (class tui_layout_split) <tui_layout_split>: Add "vertical"
3115         argument.
3116         <get_sizes>: Add "height" argument.
3117         <m_vertical>: New field.
3118         * tui/tui-layout.c (tui_layout_split::clone): Update.
3119         (tui_layout_split::get_sizes): Add "height" argument.
3120         (tui_layout_split::adjust_size, tui_layout_split::apply): Update.
3121         (tui_new_layout_command): Parse "-horizontal".
3122         (_initialize_tui_layout): Update help string.
3123         (tui_layout_split::specification): Add "-horizontal" when needed.
3124         * tui/tui-layout.c (tui_layout_window::get_sizes): Add "height"
3125         argument.
3126         * tui/tui-data.h (struct tui_gen_win_info) <max_width, min_width>:
3127         New methods.
3128
3129 2020-02-22  Tom Tromey  <tom@tromey.com>
3130
3131         * tui/tui-layout.h (enum tui_adjust_result): New.
3132         (class tui_layout_base) <adjust_size>: Return tui_adjust_result.
3133         (class tui_layout_window) <adjust_size>: Return
3134         tui_adjust_result.  Rewrite.
3135         (class tui_layout_split) <adjust_size>: Return tui_adjust_result.
3136         * tui/tui-layout.c (tui_layout_split::adjust_size): Update.
3137
3138 2020-02-22  Tom Tromey  <tom@tromey.com>
3139
3140         * tui/tui-layout.h (class tui_layout_split) <add_split>: Change
3141         parameter and return types.
3142         (class tui_layout_base) <specification>: Add "depth".
3143         (class tui_layout_window) <specification>: Add "depth".
3144         (class tui_layout_split) <specification>: Add "depth".
3145         * tui/tui-layout.c (tui_layout_split::add_split): Change parameter
3146         and return types.
3147         (tui_new_layout_command): Parse sub-layouts.
3148         (_initialize_tui_layout): Update help string.
3149         (tui_layout_window::specification): Add "depth".
3150         (add_layout_command): Update.
3151
3152 2020-02-22  Tom Tromey  <tom@tromey.com>
3153
3154         * NEWS: Add "tui new-layout" item.
3155         * tui/tui-layout.c (add_layout_command): Return cmd_list_element.
3156         Add new-layout command to help text.
3157         (validate_window_name): New function.
3158         (tui_new_layout_command): New function.
3159         (_initialize_tui_layout): Register "new-layout".
3160         (tui_layout_window::specification): New method.
3161         (tui_layout_window::specification): New method.
3162         * tui/tui-layout.h (class tui_layout_base) <specification>: New
3163         method.
3164         (class tui_layout_window) <specification>: New method.
3165         (class tui_layout_split) <specification>: New method.
3166
3167 2020-02-22  Tom Tromey  <tom@tromey.com>
3168
3169         * tui/tui.c (tui_enable): Call tui_set_initial_layout.
3170         * tui/tui-win.c (window_name_completer): Update comment.
3171         * tui/tui-layout.h (class tui_layout_base) <replace_window>:
3172         Declare method.
3173         (class tui_layout_window) <replace_window>: Likewise.
3174         (class tui_layout_split) <replace_window>: Likewise.
3175         (tui_set_layout): Don't declare.
3176         (tui_set_initial_layout): Declare function.
3177         * tui/tui-layout.c (layouts, applied_skeleton, src_regs_layout)
3178         (asm_regs_layout): New globals.
3179         (tui_current_layout, show_layout): Remove.
3180         (tui_set_layout, tui_add_win_to_layout): Rewrite.
3181         (find_layout, tui_apply_layout): New function.
3182         (layout_completer): Remove.
3183         (tui_next_layout): Reimplement.
3184         (tui_next_layout_command): New function.
3185         (tui_set_initial_layout, tui_prev_layout_command): New functions.
3186         (tui_regs_layout): Reimplement.
3187         (tui_regs_layout_command): New function.
3188         (extract_display_start_addr): Rewrite.
3189         (next_layout, prev_layout): Remove.
3190         (tui_layout_window::replace_window): New method.
3191         (tui_layout_split::replace_window): New method.
3192         (destroy_layout): New function.
3193         (layout_list): New global.
3194         (add_layout_command): New function.
3195         (initialize_layouts): Update.
3196         (tui_layout_command): New function.
3197         (_initialize_tui_layout): Install "layout" commands.
3198         * tui/tui-data.h (enum tui_layout_type): Remove.
3199         (tui_current_layout): Don't declare.
3200
3201 2020-02-22  Tom Tromey  <tom@tromey.com>
3202
3203         * tui/tui-regs.c (tui_reg_layout): Remove.
3204         (tui_reg_command): Use tui_regs_layout.
3205         * tui/tui-layout.h (tui_reg_command): Declare.
3206         * tui/tui-layout.c (tui_reg_command): New function.
3207
3208 2020-02-22  Tom Tromey  <tom@tromey.com>
3209
3210         * tui/tui.c (tui_rl_delete_other_windows): Call
3211         tui_remove_some_windows.
3212         * tui/tui-layout.h (class tui_layout_base) <remove_windows>:
3213         Declare method.
3214         (class tui_layout_window) <remove_windows>: New method.
3215         (class tui_layout_split) <remove_windows>: Declare.
3216         (tui_remove_some_windows): Declare.
3217         * tui/tui-layout.c (tui_remove_some_windows): New function.
3218         (tui_layout_split::remove_windows): New method.
3219
3220 2020-02-22  Tom Tromey  <tom@tromey.com>
3221
3222         * tui/tui.c (tui_rl_change_windows): Call tui_next_layout.
3223         * tui/tui-layout.h (tui_next_layout): Declare.
3224         * tui/tui-layout.c (tui_next_layout): New function.
3225
3226 2020-02-22  Tom Tromey  <tom@tromey.com>
3227
3228         * tui/tui-regs.c (tui_data_window::display_registers_from): Use
3229         correct coordinates.
3230
3231 2020-02-22  Tom Tromey  <tom@tromey.com>
3232
3233         * tui/tui-layout.h (tui_add_win_to_layout): Add comment.
3234         * tui/tui-layout.c (tui_add_win_to_layout): Add assert.  Remove
3235         DATA_WIN case.
3236
3237 2020-02-22  Tom Tromey  <tom@tromey.com>
3238
3239         * tui/tui-disasm.c (tui_get_low_disassembly_address): Use
3240         TUI_DISASM_WIN, not tui_win_list.
3241
3242 2020-02-22  Tom Tromey  <tom@tromey.com>
3243
3244         * valprint.c (generic_val_print_enum_1)
3245         (val_print_type_code_flags): Style member names.
3246         * rust-lang.c (val_print_struct, rust_print_enum)
3247         (rust_print_struct_def, rust_internal_print_type): Style member
3248         names.
3249         * p-valprint.c (pascal_object_print_value_fields): Style member
3250         names.  Only call fprintf_symbol_filtered for static members.
3251         * m2-typeprint.c (m2_record_fields, m2_enum): Style member names.
3252         * f-valprint.c (f_val_print): Style member names.
3253         * f-typeprint.c (f_type_print_base): Style member names.
3254         * cp-valprint.c (cp_print_value_fields): Style member names.  Only
3255         call fprintf_symbol_filtered for static members.
3256         (cp_print_class_member): Style member names.
3257         * c-typeprint.c (c_print_type_1, c_type_print_base_1): Style
3258         member names.
3259         * ada-valprint.c (ada_print_scalar): Style enum names.
3260         (ada_val_print_enum): Likewise.
3261         * ada-typeprint.c (print_enum_type): Style enum names.
3262
3263 2020-02-21  Tom Tromey  <tom@tromey.com>
3264
3265         * psympriv.h (struct partial_symtab): Update comment.
3266
3267 2020-02-21  Tom Tromey  <tromey@adacore.com>
3268
3269         * mips-tdep.h (mips_pc_is_mips16, mips_pc_is_micromips): Parameter
3270         type is CORE_ADDR.
3271
3272 2020-02-21  Tom de Vries  <tdevries@suse.de>
3273
3274         PR gdb/25534
3275         * psymtab.c (partial_symtab::read_dependencies): Don't read dependency
3276         if dependencies[i]->user != NULL.
3277
3278 2020-02-21  Ali Tamur  <tamur@google.com>
3279
3280         * dwarf2/read.c (dwarf2_name): Add null check.
3281
3282 2020-02-20  Tom Tromey  <tom@tromey.com>
3283
3284         * dwarf2/read.c (dwarf2_find_containing_comp_unit): Use ">", not
3285         ">=", in binary search.
3286         (dwarf2_find_containing_comp_unit): New overload.
3287         (run_test): New self-test.
3288         (_initialize_dwarf2_read): Register new test.
3289
3290 2020-02-20  Nelson Chu  <nelson.chu@sifive.com>
3291
3292         * riscv-tdep.c: Updated since the DECLARE_CSR is changed.
3293         * riscv-tdep.h: Likewise.
3294         * features/riscv/rebuild-csr-xml.sh: Generate the 64bit-csr.xml without
3295         rv32-only CSR.
3296         * features/riscv/64bit-csr.xml: Regenerated.
3297
3298 2020-02-20  Sergio Durigan Junior  <sergiodj@redhat.com>
3299             Tom Tromey  <tom@tromey.com>
3300
3301         * utils.c (fputs_maybe_filtered): Call 'stream->puts' instead
3302         of 'fputc_unfiltered'.
3303         (putchar_unfiltered): Call 'fputc_unfiltered'.
3304         (fputc_unfiltered): Call 'fputs_unfiltered'.
3305
3306 2020-02-20  Andrew Burgess  <andrew.burgess@embecosm.com>
3307
3308         * config.in: Regenerate.
3309         * configure: Regenerate.
3310         * configure.ac: Add --with-python-libdir option.
3311         * main.c: Use WITH_PYTHON_LIBDIR.
3312
3313 2020-02-19  Tom Tromey  <tom@tromey.com>
3314
3315         * symtab.c (general_symbol_info::compute_and_set_names): Use
3316         obstack_strndup.  Simplify call to symbol_set_demangled_name.
3317
3318 2020-02-19  Simon Marchi  <simon.marchi@efficios.com>
3319
3320         * dwarf2/read.c (allocate_signatured_type_table,
3321         allocate_dwo_unit_table, allocate_type_unit_groups_table,
3322         allocate_dwo_file_hash_table, allocate_dwp_loaded_cutus_table):
3323         Remove objfile parameter, update all callers.
3324
3325 2020-02-19  Doug Evans  <dje@google.com>
3326
3327         PR rust/25535
3328         * rust-lang.c (rust_print_enum): Apply embedded_offset to
3329         rust_enum_variant calculation.
3330
3331 2020-02-19  Tom Tromey  <tromey@adacore.com>
3332
3333         * mips-tdep.h (mips_pc_is_mips): Parameter type is CORE_ADDR.
3334
3335 2020-02-19  Tom Tromey  <tromey@adacore.com>
3336
3337         * ada-lang.c (cache_symbol): Use obstack_strdup.
3338
3339 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
3340
3341         * configure: Regenerate.
3342
3343 2020-02-19  Tom Tromey  <tromey@adacore.com>
3344
3345         * python/python.c (do_start_initialization): Use XNEWVEC.  Remove
3346         NULL check.
3347
3348 2020-02-19  Maciej W. Rozycki  <macro@wdc.com>
3349
3350         * NEWS: Mention RISC-V GNU/Linux GDBserver support.
3351
3352 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
3353
3354         * arch/riscv.c (struct riscv_gdbarch_features_hasher): Only define
3355         if GDBSERVER is not defined.
3356         (riscv_tdesc_cache): Likewise, also store const target_desc.
3357         (STATIC_IN_GDB): Define.
3358         (riscv_create_target_description): Update declaration with
3359         STATIC_IN_GDB.
3360         (riscv_lookup_target_description): New function, only define if
3361         GDBSERVER is not defined.
3362         * arch/riscv.h (riscv_create_target_description): Declare only
3363         when GDBSERVER is defined.
3364         (riscv_lookup_target_description): New declaration when GDBSERVER
3365         is not defined.
3366         * nat/riscv-linux-tdesc.c (riscv_linux_read_description): Rename to...
3367         (riscv_linux_read_features): ...this, and return
3368         riscv_gdbarch_features instead of target_desc.
3369         * nat/riscv-linux-tdesc.h: Include 'arch/riscv.h'.
3370         (riscv_linux_read_description): Rename to...
3371         (riscv_linux_read_features): ...this.
3372         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
3373         Update to use riscv_gdbarch_features and
3374         riscv_lookup_target_description.
3375         * riscv-tdep.c (riscv_find_default_target_description): Use
3376         riscv_lookup_target_description instead of
3377         riscv_create_target_description.
3378
3379 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
3380
3381         * valprint.c (generic_val_print_enum_1): When printing a flag
3382         enum with value 0 and there is no enumerator with value 0, print
3383         just "0" instead of "(unknown: 0x0)".
3384
3385 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
3386
3387         * valprint.c (generic_val_print_enum_1): Print unknown part of
3388         flag enum in hex.
3389
3390 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
3391
3392         * dwarf2/read.c (update_enumeration_type_from_children): Allow
3393         flag enums to contain duplicate enumerators.
3394         * valprint.c (generic_val_print_enum_1): Update comment.
3395
3396 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
3397
3398         * dwarf2/read.c: Include "count-one-bits.h".
3399         (update_enumeration_type_from_children): If an enumerator has
3400         multiple bits set, don't treat the enumeration as a "flag enum".
3401         * valprint.c (generic_val_print_enum_1): Assert that enumerators
3402         of flag enums have 0 or 1 bit set.
3403
3404 2020-02-18  Bernd Edlinger  <bernd.edlinger@hotmail.de>
3405
3406         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use an explicit
3407         conversion.
3408         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
3409         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
3410         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
3411         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
3412         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
3413
3414 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
3415
3416         * MAINTAINERS: Change palmer@sifive.com to palmer@dabbelt.com.
3417
3418 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
3419
3420         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use
3421         displaced_step_closure_up.
3422         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
3423         (struct displaced_step_closure_up):
3424         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
3425         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
3426         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn):
3427         Likewise.
3428         * gdbarch.sh (displaced_step_copy_insn): Likewise.
3429         * gdbarch.c, gdbarch.h: Re-generate.
3430         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Use
3431         displaced_step_closure_up.
3432         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
3433         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
3434         * infrun.h (displaced_step_closure_up): New type alias.
3435         (struct displaced_step_inferior_state) <step_closure>: Change
3436         type to displaced_step_closure_up.
3437         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Use
3438         displaced_step_closure_up.
3439         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
3440
3441 2020-02-14  Tom Tromey  <tom@tromey.com>
3442
3443         * minidebug.c (gnu_debug_key): New global.
3444         (find_separate_debug_file_in_section): Use it.
3445
3446 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
3447
3448         * gdbarch.sh (displaced_step_copy_insn): Change return type to an
3449         std::unique_ptr.
3450         * gdbarch.c: Re-generate.
3451         * gdbarch.h: Re-generate.
3452         * infrun.c (displaced_step_prepare_throw): Adjust to std::unique_ptr
3453         change.
3454         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Change return
3455         type to std::unique_ptr.
3456         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
3457         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
3458         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
3459         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
3460         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Likewise.
3461         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
3462         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
3463         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
3464         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
3465
3466 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
3467
3468         * infrun.c (get_displaced_step_closure_by_addr): Adjust to
3469         std::unique_ptr.
3470         (displaced_step_clear): Rename to...
3471         (displaced_step_reset): ... this.  Just call displaced->reset ().
3472         (displaced_step_clear_cleanup): Rename to...
3473         (displaced_step_reset_cleanup): ... this.
3474         (displaced_step_prepare_throw): Adjust to std::unique_ptr.
3475         (displaced_step_fixup): Likewise.
3476         (resume_1): Likewise.
3477         (handle_inferior_event): Restore child's memory before calling
3478         displaced_step_fixup on the parent.
3479         * infrun.h (displaced_step_inferior_state) <reset>: Adjust
3480         to std::unique_ptr.
3481         <step_closure>: Change type to std::unique_ptr.
3482
3483 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
3484
3485         * arm-tdep.c: Include count-one-bits.h.
3486         (cleanup_block_store_pc): Use count_one_bits.
3487         (cleanup_block_load_pc): Use count_one_bits.
3488         (arm_copy_block_xfer): Use count_one_bits.
3489         (thumb2_copy_block_xfer): Use count_one_bits.
3490         (thumb_copy_pop_pc_16bit): Use count_one_bits.
3491         * arch/arm-get-next-pcs.c: Include count-one-bits.h.
3492         (thumb_get_next_pcs_raw): Use count_one_bits.
3493         (arm_get_next_pcs_raw): Use count_one_bits_l.
3494         * arch/arm.c (bitcount): Remove.
3495         * arch/arm.h (bitcount): Remove.
3496
3497 2020-02-14  Tom Tromey  <tromey@adacore.com>
3498
3499         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first):
3500         Update.
3501         * dwarf2/loc.h (call_site_find_chain): Return unique_xmalloc_ptr.
3502         * dwarf2/loc.c (call_site_find_chain_1): Return
3503         unique_xmalloc_ptr.
3504         (call_site_find_chain): Likewise.
3505
3506 2020-02-14  Richard Biener  <rguenther@suse.de>
3507
3508         * dwarf2/read.c (lnp_state_machine::handle_special_opcode): Apply CSE
3509         on expression with division operators.
3510
3511 2020-02-13  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
3512
3513         * MAINTAINERS (Write After Approval): Adding myself.
3514
3515 2020-02-12  Tom Tromey  <tom@tromey.com>
3516
3517         * event-loop.c (event_data, gdb_event, event_handler_func):
3518         Remove.
3519
3520 2020-02-12  Tom Tromey  <tom@tromey.com>
3521
3522         * dwarf2/frame.c (dwarf2_frame_bfd_data): New global.
3523         (dwarf2_frame_objfile_data): Add comment.
3524         (find_comp_unit, set_comp_unit): New functions.
3525         (dwarf2_frame_find_fde): Use find_comp_unit.
3526         (dwarf2_build_frame_info): Use set_comp_unit.
3527
3528 2020-02-12  Tom Tromey  <tom@tromey.com>
3529
3530         * dwarf2/frame.c (struct comp_unit) <objfile>: Remove.
3531         (comp_unit): Don't initialize objfile.
3532         (execute_cfa_program): Add text_offset parameter.
3533         (execute_cfa_program_test, dwarf2_fetch_cfa_info)
3534         (dwarf2_frame_cache): Update.
3535         (dwarf2_build_frame_info): Don't set "objfile" member.
3536
3537 2020-02-12  Tom Tromey  <tom@tromey.com>
3538
3539         * dwarf2/frame.c (decode_frame_entry_1): Add gdbarch parameter.
3540         (decode_frame_entry): Likewise.
3541         (dwarf2_build_frame_info): Update.
3542
3543 2020-02-12  Tom Tromey  <tom@tromey.com>
3544
3545         * dwarf2/frame.c (struct comp_unit) <obstack>: New member.
3546         (decode_frame_entry_1): Use the comp_unit obstack.
3547
3548 2020-02-12  Tom Tromey  <tom@tromey.com>
3549
3550         * dwarf2/frame.c (struct comp_unit): Add initializers and
3551         constructor.
3552         (dwarf2_frame_objfile_data): Store a comp_unit.
3553         (dwarf2_frame_find_fde): Update.
3554         (dwarf2_build_frame_info): Use "new".
3555
3556 2020-02-12  Tom Tromey  <tom@tromey.com>
3557
3558         * dwarf2/frame.c (struct dwarf2_fde_table): Remove.
3559         (dwarf2_fde_table): Typedef for std::vector.
3560         (dwarf2_frame_objfile_data): Remove the deleter.  Now static.
3561         (dwarf2_frame_find_fde, add_fde, decode_frame_entry_1)
3562         (decode_frame_entry): Update.
3563         (dwarf2_build_frame_info): Use "new".
3564
3565 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
3566
3567         * arm-tdep.c (arm_gdbarch_init): Update.
3568         * arm-tdep.h (struct gdbarch_tdep) <have_fpa_registers,
3569         have_wmmx_registers, have_vfp_pseudos, have_neon_pseudos,
3570         have_neon, is_m>: Change to bool.
3571
3572 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
3573
3574         * arm-tdep.c (arm_dump_tdep): Print more fields of tdep.
3575
3576 2020-02-12  Tom Tromey  <tom@tromey.com>
3577
3578         * dwarf2/loc.c (struct dwarf_expr_baton): Remove.
3579
3580 2020-02-12  Hannes Domani  <ssbssa@yahoo.de>
3581
3582         * windows-tdep.c (struct windows_gdbarch_data): Add tib_ptr_type.
3583         (windows_get_tlb_type): Use windows_gdbarch_data->tib_ptr_type.
3584
3585 2020-02-11  Tom Tromey  <tom@tromey.com>
3586
3587         * psymtab.h: Update comment.
3588
3589 2020-02-11  Tom Tromey  <tom@tromey.com>
3590
3591         * gdb_obstack.h (struct auto_obstack): Use
3592         DISABLE_COPY_AND_ASSIGN.
3593
3594 2020-02-11  Tom Tromey  <tom@tromey.com>
3595
3596         * dwarf2/frame.h (struct objfile): Don't forward declare.
3597
3598 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
3599
3600         * cris-tdep.c (cris_supply_gregset): Change signature to match
3601         what struct regset expects.
3602         (cris_regset): New struct.
3603         (fetch_core_registers): Remove.
3604         (cris_iterate_over_regset_sections): New function.
3605         (_initialize_cris_tdep): Don't call deprecated_add_core_fns.
3606         (cris_gdbarch_init): Call set_gdbarch_iterate_over_regset_sections.
3607
3608 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
3609
3610         * arch/arm.h (enum gdb_regnum): Add comment for the FP0..7
3611         registers.
3612
3613 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
3614
3615         * arm-tdep.c (arm_dump_tdep): Add \n in fprintf.
3616
3617 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
3618
3619         * configure: Re-generate.
3620
3621 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
3622
3623         * configure: Re-generate.
3624
3625 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
3626
3627         * acinclude: Update warning.m4 path.
3628         * warning.m4: Move to gdbsupport.
3629
3630 2020-02-11  Tom Tromey  <tromey@adacore.com>
3631
3632         * remote.c (remote_console_output): Update.
3633         * printcmd.c (printf_command): Update.
3634         * event-loop.c (gdb_wait_for_event): Update.
3635         * linux-nat.c (sigchld_handler): Update.
3636         * remote-sim.c (gdb_os_write_stdout): Update.
3637         (gdb_os_flush_stdout): Update.
3638         (gdb_os_flush_stderr): Update.
3639         (gdb_os_write_stderr): Update.
3640         * exceptions.c (print_exception): Update.
3641         * remote-fileio.c (remote_fileio_func_read): Update.
3642         (remote_fileio_func_write): Update.
3643         * tui/tui.c (tui_enable): Update.
3644         * tui/tui-interp.c (tui_interp::init): Update.
3645         * utils.c (init_page_info): Update.
3646         (putchar_unfiltered, fputc_unfiltered): Update.
3647         (gdb_flush): Update.
3648         (emit_style_escape): Update.
3649         (flush_wrap_buffer, fputs_maybe_filtered): Update.
3650         * ui-file.c (ui_file_isatty, ui_file_read, ui_file_write)
3651         (ui_file_write_async_safe, ui_file_flush, ui_file_puts): Remove.
3652         (stderr_file::write): Update.
3653         (stderr_file::puts): Update.
3654         * ui-file.h (ui_file_isatty, ui_file_write)
3655         (ui_file_write_async_safe, ui_file_read, ui_file_flush)
3656         (ui_file_puts): Don't declare.
3657
3658 2020-02-10  Tom de Vries  <tdevries@suse.de>
3659
3660         * dwarf2/read.c (process_psymtab_comp_unit_reader): Cast concat NULL
3661         sentinel to char *.
3662
3663 2020-02-09  Tom de Vries  <tdevries@suse.de>
3664
3665         * dwarf2read.c (process_psymtab_comp_unit_reader): Append CU offset to
3666         filename if it matches "<artificial>".
3667
3668 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
3669
3670         * windows-tdep.c (struct enum_value_name): New struct.
3671         (create_enum): New function.
3672         (windows_get_siginfo_type): Create and use enum types.
3673
3674 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
3675
3676         * NEWS: Mention $_siginfo support for Windows.
3677         * windows-nat.c (handle_exception): Set siginfo_er.
3678         (windows_nat_target::mourn_inferior): Reset siginfo_er.
3679         (windows_xfer_siginfo): New function.
3680         (windows_nat_target::xfer_partial): Call windows_xfer_siginfo.
3681         * windows-tdep.c (struct windows_gdbarch_data): New struct.
3682         (init_windows_gdbarch_data): New function.
3683         (get_windows_gdbarch_data): New function.
3684         (windows_get_siginfo_type): New function.
3685         (windows_init_abi): Register windows_get_siginfo_type.
3686         (_initialize_windows_tdep): Register init_windows_gdbarch_data.
3687
3688 2020-02-08  Tom Tromey  <tom@tromey.com>
3689
3690         * dwarf2/read.c (class cutu_reader) <cutu_reader,
3691         init_tu_and_read_dwo_dies>: Remove "keep" parameter.
3692         <keep>: Declare method.
3693         <m_keep>: Remove member.
3694         <~cutu_reader>: Remove.
3695         (cutu_reader::init_tu_and_read_dwo_dies): Update.
3696         (cutu_reader::cutu_reader): Update.
3697         (cutu_reader::keep): Rename from ~cutu_reader.
3698         (process_psymtab_comp_unit, build_type_psymtabs_1)
3699         (process_skeletonless_type_unit, load_partial_comp_unit)
3700         (load_full_comp_unit, dwarf2_read_addr_index)
3701         (read_signatured_type): Update.
3702
3703 2020-02-08  Tom Tromey  <tom@tromey.com>
3704
3705         * dwarf2/read.c (process_psymtab_comp_unit_reader): Remove
3706         "want_partial_unit" parameter.
3707         (process_psymtab_comp_unit): Change want_partial_unit to bool.
3708         Inline check for DW_TAG_partial_unit.
3709         (dwarf2_build_psymtabs_hard, scan_partial_symbols): Update.
3710
3711 2020-02-08  Tom Tromey  <tom@tromey.com>
3712
3713         * dwarf2/read.c (read_n_bytes, read_direct_string): Move to
3714         read.c.
3715         * dwarf2/leb.h (read_n_bytes, read_direct_string): Move from
3716         read.c.
3717
3718 2020-02-08  Tom Tromey  <tom@tromey.com>
3719
3720         * dwarf2/read.c (read_address): Move to comp-unit.c.
3721         (dwarf2_rnglists_process, dwarf2_ranges_process)
3722         (read_attribute_value, dwarf_decode_lines_1)
3723         (var_decode_location, decode_locdesc): Update.
3724         * dwarf2/comp-unit.c (comp_unit_head::read_address): Move from
3725         read.c.  Remove "cu" parameter.
3726         * dwarf2/comp-unit.h (struct comp_unit_head) <read_address>: New
3727         method.
3728
3729 2020-02-08  Tom Tromey  <tom@tromey.com>
3730
3731         * dwarf2/read.c (read_attribute_value, read_indirect_string)
3732         (read_indirect_line_string): Update.
3733         * dwarf2/comp-unit.c (read_offset): Remove.
3734         (read_comp_unit_head): Update.
3735         * dwarf2/comp-unit.h (struct comp_unit_head) <read_offset>: New
3736         method.
3737         (read_offset): Don't declare.
3738
3739 2020-02-08  Tom Tromey  <tom@tromey.com>
3740
3741         * Makefile.in (COMMON_SFILES): Add dwarf2/comp-unit.c.
3742         * dwarf2/read.c (struct comp_unit_head): Move to
3743         dwarf2/comp-unit.h.
3744         (enum class rcuh_kind): Move to comp-unit.h.
3745         (get_cu_length, offset_in_cu_p): Now methods on comp_unit_head.
3746         (read_comp_unit_head, error_check_comp_unit_head)
3747         (read_and_check_comp_unit_head): Move to comp-unit.c.
3748         (read_offset, dwarf_unit_type_name): Likewise.
3749         (create_debug_type_hash_table, read_cutu_die_from_dwo)
3750         (cutu_reader::cutu_reader, read_call_site_scope)
3751         (find_partial_die, follow_die_offset): Update.
3752         * dwarf2/comp-unit.h: New file, from dwarf2read.c.
3753
3754 2020-02-08  Tom Tromey  <tom@tromey.com>
3755
3756         * dwarf2/read.c (read_offset_1): Move to leb.c.
3757         (read_abbrev_offset, read_offset, dwarf_decode_line_header)
3758         (dwarf_decode_macro_bytes): Update.
3759         * dwarf2/leb.c (read_offset): Rename; move from read.c.
3760         * dwarf2/leb.h (read_offset): Declare.
3761
3762 2020-02-08  Tom Tromey  <tom@tromey.com>
3763
3764         * dwarf2/read.c (dwarf2_section_size): Remove.
3765         (error_check_comp_unit_head, dwarf2_symbol_mark_computed):
3766         Update.
3767         * dwarf2/section.h (struct dwarf2_section_info) <get_size>: New method.
3768
3769 2020-02-08  Tom Tromey  <tom@tromey.com>
3770
3771         * dwarf2/read.c (read_initial_length): Move to leb.c.
3772         * dwarf2/leb.h (read_initial_length): Declare.
3773         * dwarf2/leb.c (read_initial_length): Move from read.c.  Add
3774         handle_nonstd parameter.
3775         * dwarf2/frame.c (read_initial_length): Remove.
3776         (decode_frame_entry_1): Update.
3777
3778 2020-02-08  Tom Tromey  <tom@tromey.com>
3779
3780         * dwarf2/loc.c (dwarf2_find_location_expression)
3781         (dwarf_evaluate_loc_desc::get_tls_address)
3782         (dwarf_evaluate_loc_desc::push_dwarf_reg_entry_value)
3783         (rw_pieced_value, dwarf2_evaluate_loc_desc_full)
3784         (dwarf2_locexpr_baton_eval, dwarf2_evaluate_property)
3785         (dwarf2_compile_property_to_c)
3786         (dwarf2_loc_desc_get_symbol_read_needs)
3787         (dwarf2_compile_expr_to_ax, locexpr_describe_location)
3788         (locexpr_tracepoint_var_ref, locexpr_generate_c_location)
3789         (loclist_describe_location, loclist_tracepoint_var_ref)
3790         (loclist_generate_c_location): Update.
3791         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
3792         * dwarf2/loc.h (dwarf2_per_cu_objfile, dwarf2_per_cu_addr_size)
3793         (dwarf2_per_cu_ref_addr_size, dwarf2_per_cu_offset_size)
3794         (dwarf2_per_cu_text_offset, dwarf2_version): Don't declare.
3795         * dwarf2/read.c (dwarf2_per_cu_data::objfile)
3796         (dwarf2_per_cu_data::addr_size)
3797         (dwarf2_per_cu_data::ref_addr_size)
3798         (dwarf2_per_cu_data::text_offset)
3799         (dwarf2_per_cu_data::addr_type): Now methods.
3800         (per_cu_header_read_in): Make per_cu "const".
3801         (dwarf2_version): Remove.
3802         (dwarf2_per_cu_data::int_type): Now a method.
3803         (dwarf2_per_cu_data::_addr_sized_int_type): Likewise.
3804         (set_die_type, read_array_type, read_subrange_index_type)
3805         (read_tag_string_type, read_subrange_type): Update.
3806         * dwarf2/read.h (struct dwarf2_per_cu_data) <addr_size,
3807         offset_size, ref_addr_size, text_offset, addr_type, version,
3808         objfile, int_type, addr_sized_int_type>: Declare methods.
3809
3810 2020-02-08  Tom Tromey  <tom@tromey.com>
3811
3812         * dwarf2/read.h (struct dwarf2_per_cu_data) <imported_symtabs>:
3813         Move earlier.
3814
3815 2020-02-08  Tom Tromey  <tom@tromey.com>
3816
3817         * dwarf2/read.h (dwarf_line_debug): Declare.
3818         * Makefile.in (COMMON_SFILES): Add dwarf2/line-header.c.
3819         * dwarf2/read.c: Move line_header code to new files.
3820         (dwarf_line_debug): No longer static.
3821         * dwarf2/line-header.c: New file.
3822         * dwarf2/line-header.h: New file.
3823
3824 2020-02-08  Tom Tromey  <tom@tromey.com>
3825
3826         * dwarf2/read.c (struct line_header) <file_full_name,
3827         file_file_name>: Return unique_xmalloc_ptr.
3828         (line_header::file_file_name): Update.
3829         (line_header::file_full_name): Update.
3830         (dw2_get_file_names_reader): Update.
3831         (macro_start_file): Update.
3832
3833 2020-02-08  Tom Tromey  <tom@tromey.com>
3834
3835         * dwarf2/read.c (struct line_header) <file_full_name,
3836         file_file_name>: Declare methods.
3837         (dw2_get_file_names_reader): Update.
3838         (file_file_name): Now a method.
3839         (file_full_name): Likewise.
3840         (macro_start_file): Update.
3841
3842 2020-02-08  Tom Tromey  <tom@tromey.com>
3843
3844         * dwarf2/read.c (dwarf_always_disassemble)
3845         (show_dwarf_always_disassemble): Move to loc.c.
3846         (_initialize_dwarf2_read): Move "always-disassemble" registration
3847         to loc.c.
3848         * dwarf2/read.h (dwarf_always_disassemble): Don't declare.
3849         * dwarf2/loc.c (dwarf_always_disassemble): Move from read.c.  Now
3850         static.
3851         (show_dwarf_always_disassemble): Move from read.c.
3852         (_initialize_dwarf2loc): Move always-disassemble from read.c.
3853
3854 2020-02-08  Tom Tromey  <tom@tromey.com>
3855
3856         * dwarf2/read.c (~dwarf2_per_objfile): Update.
3857         (create_quick_file_names_table): Return htab_up.
3858         (dw2_get_file_names_reader, dw2_forget_cached_source_info):
3859         Update.
3860         * dwarf2/read.h (struct dwarf2_per_objfile)
3861         <quick_file_names_table>: Now htab_up.
3862
3863 2020-02-08  Tom Tromey  <tom@tromey.com>
3864
3865         * dwarf2/abbrev.c (abbrev_table::read): Simplify.
3866
3867 2020-02-08  Tom Tromey  <tom@tromey.com>
3868
3869         * dwarf2/abbrev.c (abbrev_table): Move constructor from header.
3870         Rewrite.
3871         (abbrev_table::add_abbrev, abbrev_table::lookup_abbrev): Rewrite.
3872         * dwarf2/abbrev.h (struct abbrev_info) <next>: Remove.
3873         (abbrev_table::abbrev_table): No longer inline.
3874         (ABBREV_HASH_SIZE): Remove.
3875         (abbrev_table::m_abbrevs): Now an htab_up.
3876
3877 2020-02-08  Tom Tromey  <tom@tromey.com>
3878
3879         * dwarf2/read.c (read_cutu_die_from_dwo): Update.
3880         (cutu_reader): Update.
3881         (build_type_psymtabs_1): Update.
3882         * dwarf2/abbrev.c (abbrev_table::read): Rename.
3883         (abbrev_table::alloc_abbrev): Update.
3884         * dwarf2/abbrev.h (abbrev_table_up): Move earlier.
3885         (abbrev_table::read): New static method, renamed from
3886         abbrev_table_read_table.
3887         (abbrev_table::alloc_abbrev)
3888         (abbrev_table::add_abbrev): Now private.
3889         (abbrev_table::abbrev_table): Now private.
3890         (abbrev_table::m_abbrev_obstack): Now private.  Rename.
3891
3892 2020-02-08  Tom Tromey  <tom@tromey.com>
3893
3894         * dwarf2/read.c (set_die_type, get_die_type_at_offset): Update.
3895         * dwarf2/read.h (struct dwarf2_per_objfile) <die_type_hash>: Now
3896         htab_up.
3897
3898 2020-02-08  Tom Tromey  <tom@tromey.com>
3899
3900         * dwarf2/read.c (struct dwp_file) <loaded_cus, loaded_tus>: Now
3901         htab_up.
3902         (lookup_dwo_unit_in_dwp): Update.
3903         (allocate_dwp_loaded_cutus_table): Return htab_up.  Don't allocate
3904         on obstack.
3905
3906 2020-02-08  Tom Tromey  <tom@tromey.com>
3907
3908         * dwarf2/read.c (allocate_dwo_file_hash_table): Don't allocate on
3909         obstack.
3910
3911 2020-02-08  Tom Tromey  <tom@tromey.com>
3912
3913         * dwarf2/read.c (~dwarf2_per_objfile): Don't delete
3914         line_header_hash.
3915         (handle_DW_AT_stmt_list): Update.  Don't allocate on obstack.
3916         * dwarf2/read.h (struct dwarf2_per_objfile) <line_header_hash>:
3917         Change type to htab_up.
3918
3919 2020-02-08  Tom Tromey  <tom@tromey.com>
3920
3921         * dwarf2/read.c (allocate_type_unit_groups_table): Return
3922         htab_up.  Don't allocate on obstack.
3923         (get_type_unit_group, dwarf2_build_psymtabs_hard): Update.
3924         * dwarf2/read.h (struct dwarf2_per_objfile) <type_unit_groups>:
3925         Change type to htab_up.
3926
3927 2020-02-08  Tom Tromey  <tom@tromey.com>
3928
3929         * dwarf2/read.h (struct dwarf2_per_objfile) <signatured_types>:
3930         Change type to htab_up.
3931         * dwarf2/read.c (create_signatured_type_table_from_index)
3932         (create_signatured_type_table_from_debug_names)
3933         (create_all_type_units, add_type_unit)
3934         (lookup_dwo_signatured_type, lookup_signatured_type)
3935         (process_skeletonless_type_unit): Update.
3936         (create_debug_type_hash_table, create_debug_types_hash_table):
3937         Change type of types_htab.
3938         (allocate_signatured_type_table, allocate_dwo_unit_table): Return
3939         htab_up.  Don't allocate on obstack.
3940         (create_cus_hash_table): Change type of cus_htab parameter.
3941         (struct dwo_file) <cus, tus>: Now htab_up.
3942         (lookup_dwo_signatured_type, lookup_dwo_cutu)
3943         (process_dwo_file_for_skeletonless_type_units, lookup_dwo_cutu)
3944         (queue_and_load_all_dwo_tus): Update.
3945         * dwarf2/index-write.c (write_gdbindex): Update.
3946         (write_debug_names): Update.
3947
3948 2020-02-08  Tom Tromey  <tom@tromey.com>
3949
3950         * dwarf2/read.h (struct dwarf2_queue_item): Move from
3951         dwarf2/read.c.  Remove "next" member.  Add constructor ntad
3952         destructor.
3953         (struct dwarf2_per_objfile) <queue>: New member.
3954         * dwarf2/read.c (struct dwarf2_queue_item): Move to
3955         dwarf2/read.h.
3956         (dwarf2_queue, dwarf2_queue_tail): Remove.
3957         (class dwarf2_queue_guard): Add parameter to constructor.  Use
3958         DISABLE_COPY_AND_ASSIGN.
3959         <m_per_objfile>: New member.
3960         <~dwarf2_queue_guard>: Rewrite.
3961         (dw2_do_instantiate_symtab, queue_comp_unit, process_queue):
3962         Update.
3963         (~dwarf2_queue_item): New.
3964
3965 2020-02-08  Tom Tromey  <tom@tromey.com>
3966
3967         * dwarf2/read.c (struct die_info) <has_children>: New member.
3968         (dw2_get_file_names_reader): Remove has_children.
3969         (dw2_get_file_names): Update.
3970         (read_cutu_die_from_dwo): Remove has_children.
3971         (cutu_reader::init_tu_and_read_dwo_dies)
3972         (cutu_reader::cutu_reader): Update.
3973         (process_psymtab_comp_unit_reader, build_type_psymtabs_reader):
3974         Remove has_children.
3975         (build_type_psymtabs_1, process_skeletonless_type_unit)
3976         (load_partial_comp_unit, load_full_comp_unit): Update.
3977         (create_dwo_cu_reader): Remove has_children.
3978         (create_cus_hash_table, read_die_and_children): Update.
3979         (read_full_die_1,read_full_die): Remove has_children.
3980         (read_signatured_type): Update.
3981         (class cutu_reader) <has_children>: Remove.
3982
3983 2020-02-08  Tom Tromey  <tom@tromey.com>
3984
3985         * dwarf2/expr.c: Rename from dwarf2expr.c.
3986         * dwarf2/expr.h: Rename from dwarf2expr.h.
3987         * dwarf2/frame-tailcall.c: Rename from dwarf2-frame-tailcall.c.
3988         * dwarf2/frame-tailcall.h: Rename from dwarf2-frame-tailcall.h.
3989         * dwarf2/frame.c: Rename from dwarf2-frame.c.
3990         * dwarf2/frame.h: Rename from dwarf2-frame.h.
3991         * dwarf2/index-cache.c: Rename from dwarf-index-cache.c.
3992         * dwarf2/index-cache.h: Rename from dwarf-index-cache.h.
3993         * dwarf2/index-common.c: Rename from dwarf-index-common.c.
3994         * dwarf2/index-common.h: Rename from dwarf-index-common.h.
3995         * dwarf2/index-write.c: Rename from dwarf-index-write.c.
3996         * dwarf2/index-write.h: Rename from dwarf-index-write.h.
3997         * dwarf2/loc.c: Rename from dwarf2loc.c.
3998         * dwarf2/loc.h: Rename from dwarf2loc.h.
3999         * dwarf2/read.c: Rename from dwarf2read.c.
4000         * dwarf2/read.h: Rename from dwarf2read.h.
4001         * dwarf2/abbrev.c, aarch64-tdep.c, alpha-tdep.c,
4002         amd64-darwin-tdep.c, arc-tdep.c, arm-tdep.c, bfin-tdep.c,
4003         compile/compile-c-symbols.c, compile/compile-cplus-symbols.c,
4004         compile/compile-loc2c.c, cris-tdep.c, csky-tdep.c, findvar.c,
4005         gdbtypes.c, guile/scm-type.c, h8300-tdep.c, hppa-bsd-tdep.c,
4006         hppa-linux-tdep.c, i386-darwin-tdep.c, i386-linux-tdep.c,
4007         i386-tdep.c, iq2000-tdep.c, m32c-tdep.c, m68hc11-tdep.c,
4008         m68k-tdep.c, microblaze-tdep.c, mips-tdep.c, mn10300-tdep.c,
4009         msp430-tdep.c, nds32-tdep.c, nios2-tdep.c, or1k-tdep.c,
4010         riscv-tdep.c, rl78-tdep.c, rs6000-tdep.c, rx-tdep.c, s12z-tdep.c,
4011         s390-tdep.c, score-tdep.c, sh-tdep.c, sparc-linux-tdep.c,
4012         sparc-tdep.c, sparc64-linux-tdep.c, sparc64-tdep.c, tic6x-tdep.c,
4013         tilegx-tdep.c, v850-tdep.c, xstormy16-tdep.c, xtensa-tdep.c:
4014         Update.
4015         * Makefile.in (COMMON_SFILES): Update.
4016         (HFILES_NO_SRCDIR): Update.
4017
4018 2020-02-08  Tom Tromey  <tom@tromey.com>
4019
4020         * dwarf2read.c (struct die_reader_specs) <comp_dir>: Remove.
4021         (init_cu_die_reader, read_cutu_die_from_dwo): Update.
4022
4023 2020-02-08  Tom Tromey  <tom@tromey.com>
4024
4025         * dwarf2read.h (struct die_info): Don't declare.
4026
4027 2020-02-08  Tom Tromey  <tom@tromey.com>
4028
4029         * dwarf2read.h (die_info_ptr): Remove typedef.
4030
4031 2020-02-08  Tom Tromey  <tom@tromey.com>
4032
4033         * dwarf2read.c (read_call_site_scope)
4034         (handle_data_member_location, dwarf2_add_member_fn)
4035         (mark_common_block_symbol_computed, read_common_block)
4036         (attr_to_dynamic_prop, partial_die_info::read)
4037         (var_decode_location, dwarf2_fetch_die_loc_sect_off)
4038         (dwarf2_symbol_mark_computed, set_die_type): Update.
4039         * dwarf2/attribute.h (struct attribute) <form_is_block>: Declare
4040         method.
4041         (attr_form_is_block): Don't declare.
4042         * dwarf2/attribute.c (attribute::form_is_block): Now a method.
4043
4044 2020-02-08  Tom Tromey  <tom@tromey.com>
4045
4046         * dwarf2read.c (dwarf2_find_base_address, )
4047         (read_call_site_scope, rust_containing_type)
4048         (dwarf2_get_pc_bounds, dwarf2_record_block_ranges)
4049         (handle_data_member_location, dwarf2_add_member_fn)
4050         (get_alignment, read_structure_type, process_structure_scope)
4051         (mark_common_block_symbol_computed, read_common_block)
4052         (read_tag_string_type, attr_to_dynamic_prop, read_subrange_type)
4053         (partial_die_info::read, read_attribute_value, new_symbol)
4054         (lookup_die_type, dwarf2_get_ref_die_offset)
4055         (dwarf2_get_attr_constant_value, follow_die_ref_or_sig)
4056         (dwarf2_fetch_die_loc_sect_off, get_DW_AT_signature_type)
4057         (dwarf2_symbol_mark_computed): Update.
4058         * dwarf2/attribute.h (struct attribute) <value_as_address,
4059         form_is_section_offset, form_is_constant, form_is_ref>: Declare
4060         methods.
4061         (value_as_address, attr_form_is_section_offset)
4062         (attr_form_is_constant, attr_form_is_ref): Don't declare.
4063         * dwarf2/attribute.c (attribute::value_as_address)
4064         (attribute::form_is_section_offset, attribute::form_is_constant)
4065         (attribute::form_is_ref): Now methods.
4066
4067 2020-02-08  Tom Tromey  <tom@tromey.com>
4068
4069         * dwarf2read.c (struct attribute, DW_STRING)
4070         (DW_STRING_IS_CANONICAL, DW_UNSND, DW_BLOCK, DW_SND, DW_ADDR)
4071         (DW_SIGNATURE, struct dwarf_block, attr_value_as_address)
4072         (attr_form_is_block, attr_form_is_section_offset)
4073         (attr_form_is_constant, attr_form_is_ref): Move.
4074         * dwarf2/attribute.h: New file.
4075         * dwarf2/attribute.c: New file, from dwarf2read.c.
4076         * Makefile.in (COMMON_SFILES): Add dwarf2/attribute.c.
4077
4078 2020-02-08  Tom Tromey  <tom@tromey.com>
4079
4080         * dwarf2read.c (abbrev_table_up, struct abbrev_info)
4081         (struct attr_abbrev, ABBREV_HASH_SIZE, struct abbrev_table):
4082         Move.
4083         (read_cutu_die_from_dwo, build_type_psymtabs_1): Update.
4084         (abbrev_table::alloc_abbrev, abbrev_table::add_abbrev)
4085         (abbrev_table::lookup_abbrev, abbrev_table_read_table): Move to
4086         abbrev.c.
4087         * dwarf2/abbrev.h: New file.
4088         * dwarf2/abbrev.c: New file, from dwarf2read.c.
4089         * Makefile.in (COMMON_SFILES): Add dwarf2/abbrev.c.
4090
4091 2020-02-08  Tom Tromey  <tom@tromey.com>
4092
4093         * dwarf2read.c (dwarf2_section_buffer_overflow_complaint)
4094         (dwarf2_section_size, dwarf2_get_section_info)
4095         (create_signatured_type_table_from_debug_names)
4096         (create_addrmap_from_aranges, read_debug_names_from_section)
4097         (get_gdb_index_contents_from_section, read_comp_unit_head)
4098         (error_check_comp_unit_head, read_abbrev_offset)
4099         (create_debug_type_hash_table, init_cu_die_reader)
4100         (read_cutu_die_from_dwo, dwarf2_build_psymtabs_hard)
4101         (read_comp_units_from_section, create_cus_hash_table)
4102         (create_dwp_hash_table, create_dwo_unit_in_dwp_v1)
4103         (create_dwp_v2_section, dwarf2_rnglists_process)
4104         (dwarf2_ranges_process, read_die_and_siblings, read_full_die)
4105         (abbrev_table_read_table, read_indirect_string_at_offset_from)
4106         (read_indirect_string_from_dwz, read_addr_index_1)
4107         (read_str_index, dwarf_decode_line_header, skip_form_bytes)
4108         (dwarf_decode_macro_bytes, dwarf_decode_macros)
4109         (fill_in_loclist_baton): Update.
4110         * dwarf2/section.h (struct dwarf2_section_info) <get_name,
4111         get_containing_section, get_bfd_owner, get_bfd_section,
4112         get_file_name, get_id, get_flags, empty, read>: Declare methods.
4113         (dwarf2_read_section, get_section_name, get_section_file_name)
4114         (get_containing_section, get_section_bfd_owner)
4115         (get_section_bfd_section, get_section_name, get_section_file_name)
4116         (get_section_id, get_section_flags, dwarf2_section_empty_p): Don't
4117         declare.
4118         * dwarf2/section.c (dwarf2_section_info::get_containing_section)
4119         (dwarf2_section_info::get_bfd_owner)
4120         (dwarf2_section_info::get_bfd_section)
4121         (dwarf2_section_info::get_name)
4122         (dwarf2_section_info::get_file_name, dwarf2_section_info::get_id)
4123         (dwarf2_section_info::get_flags, dwarf2_section_info::empty)
4124         (dwarf2_section_info::read): Now methods.
4125         * dwarf-index-write.c (class debug_names): Update.
4126
4127 2020-02-08  Tom Tromey  <tom@tromey.com>
4128
4129         * dwarf2read.h (struct dwarf2_section_info, dwarf2_read_section):
4130         Move to dwarf2/section.h.
4131         * dwarf2read.c (get_containing_section, get_section_bfd_owner)
4132         (get_section_bfd_section, get_section_name)
4133         (get_section_file_name, get_section_id, get_section_flags)
4134         (dwarf2_section_empty_p, dwarf2_read_section): Moe to
4135         dwarf2/section.c.
4136         * dwarf2/section.h: New file.
4137         * dwarf2/section.c: New file, from dwarf2read.c.
4138         * Makefile.in (COMMON_SFILES): Add dwarf2/section.c.
4139
4140 2020-02-08  Tom Tromey  <tom@tromey.com>
4141
4142         * dwarf2read.h (read_unsigned_leb128): Don't declare.
4143         * dwarf2read.c (read_1_byte, read_1_signed_byte, read_2_bytes)
4144         (read_2_signed_bytes, read_3_bytes, read_4_bytes)
4145         (read_4_signed_bytes, read_8_bytes): Move to dwarf2/leb.h.
4146         (read_unsigned_leb128, read_signed_leb128): Move to dwarf2/leb.c.
4147         * dwarf2/leb.h: New file, from dwarf2read.c.
4148         * dwarf2/leb.c: New file, from dwarf2read.c.
4149         * dwarf2-frame.c (read_1_byte, read_4_bytes, read_8_bytes):
4150         Remove.
4151         * Makefile.in (CONFIG_SRC_SUBDIR): Add dwarf2.
4152         (COMMON_SFILES): Add dwarf2/leb.c.
4153
4154 2020-02-08  Joel Brobecker  <brobecker@adacore.com>
4155
4156         GDB 9.1 released.
4157
4158 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
4159
4160         PR gdb/25190:
4161         * gdb/remote-sim.c (gdb_os_write_stderr): Update.
4162         * gdb/remote.c (remote_console_output): Update.
4163         * gdb/ui-file.c (fputs_unfiltered): Rename to...
4164         (ui_file_puts): ...this.
4165         * gdb/ui-file.h (ui_file_puts): Add declaration.
4166         * gdb/utils.c (emit_style_escape): Update.
4167         (flush_wrap_buffer): Update.
4168         (fputs_maybe_filtered): Update.
4169         (fputs_unfiltered): Add function.
4170
4171 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
4172
4173         * gdb/event-loop.c (gdb_wait_for_event): Update.
4174         * gdb/printcmd.c (printf_command): Update.
4175         * gdb/remote-fileio.c (remote_fileio_func_write): Update.
4176         * gdb/remote-sim.c (gdb_os_flush_stdout): Update.
4177         (gdb_os_flush_stderr): Update.
4178         * gdb/remote.c (remote_console_output): Update.
4179         * gdb/ui-file.c (gdb_flush): Rename to...
4180         (ui_file_flush): ...this.
4181         (stderr_file::write): Update.
4182         (stderr_file::puts): Update.
4183         * gdb/ui-file.h (gdb_flush): Rename to...
4184         (ui_file_flush): ...this.
4185         * gdb/utils.c (gdb_flush): Add function.
4186         * gdb/utils.h (gdb_flush): Add declaration.
4187
4188 2020-02-07  Tom Tromey  <tromey@adacore.com>
4189
4190         PR breakpoints/24915:
4191         * source.c (find_and_open_source): Do not check basenames_may_differ.
4192
4193 2020-02-07  Tom Tromey  <tom@tromey.com>
4194
4195         * README: Update gdbserver documentation.
4196         * gdbserver: Move to top level.
4197         * configure.tgt (build_gdbserver): Remove.
4198         * configure.ac: Remove --enable-gdbserver.
4199         * configure: Rebuild.
4200         * Makefile.in (distclean): Don't mention gdbserver.
4201
4202 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
4203
4204         * source-cache.c (source_cache::ensure): Surround
4205         get_plain_source_lines with a try/catch.
4206         (source_cache::get_line_charpos): Get rid of try/catch
4207         and only check for the return value of "ensure".
4208         * tui/tui-source.c (tui_source_window::set_contents):
4209         Simplify "nlines" calculation.
4210
4211 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
4212
4213         * MAINTAINERS (Write After Approval): Add myself.
4214
4215 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
4216
4217         * sparc-nat.h (struct sparc_target) <xfer_partial>: Fix base class
4218         function call.
4219
4220 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
4221
4222         * ppc-nbsd-tdep.h: Fix macro name in #endif comment.
4223
4224 2020-02-05  Maciej W. Rozycki  <macro@wdc.com>
4225
4226         * nat/riscv-linux-tdesc.h: New file.
4227         * nat/riscv-linux-tdesc.c: New file, taking code from...
4228         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
4229         ... here.
4230         * configure.nat <linux> <riscv*>: Add nat/riscv-linux-tdesc.o to
4231         NATDEPFILES.
4232
4233 2020-02-04  Andrew Burgess  <andrew.burgess@embecosm.com>
4234
4235         * remote-sim.c (sim_inferior_data::sim_inferior_data): Assert that
4236         we don't set the fake simulator ptid to the null_ptid.
4237
4238 2020-02-03  Simon Marchi  <simon.marchi@efficios.com>
4239
4240         * fork-child.c (gdb_startup_inferior): Use bool instead of int.
4241         * gdbthread.h (class thread_info) <resumed>: Likewise.
4242         * infrun.c (resume_1): Likewise.
4243         (proceed): Likewise.
4244         (infrun_thread_stop_requested): Likewise.
4245         (stop_all_threads): Likewise.
4246         (handle_inferior_event): Likewise.
4247         (restart_threads): Likewise.
4248         (finish_step_over): Likewise.
4249         (keep_going_stepped_thread): Likewise.
4250         * linux-nat.c (attach_proc_task_lwp_callback): Likewise.
4251         (linux_handle_extended_wait): Likewise.
4252         * record-btrace.c (get_thread_current_frame_id): Likewise.
4253         * record-full.c (record_full_wait_1): Likewise.
4254         * remote.c (remote_target::process_initial_stop_replies): Likewise.
4255         * target.c (target_resume): Likewise.
4256         * thread.c (set_running_thread): Likewise.
4257
4258 2020-02-03  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
4259
4260         * f-valprint.c (f77_print_array_1): Changed datatype of index
4261         variable to LONGEST from int to enable it to contain bound
4262         values correctly.
4263
4264 2020-02-03  Maciej W. Rozycki  <macro@wdc.com>
4265
4266         * riscv-linux-nat.c [!NFPREG] (NFPREG): New macro.
4267         (supply_fpregset_regnum, fill_fpregset): Handle regset buffer
4268         offsets according to FLEN determined.
4269         (riscv_linux_nat_target::read_description): Determine FLEN
4270         dynamically.
4271         (riscv_linux_nat_target::fetch_registers): Size regset buffer
4272         according to FLEN determined.
4273         (riscv_linux_nat_target::store_registers): Likewise.
4274
4275 2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
4276
4277         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
4278         when reg->group is empty and reggroup is not.
4279
4280 2020-01-31  Tom Tromey  <tromey@adacore.com>
4281
4282         * ravenscar-thread.c (ravenscar_thread_target::mourn_inferior):
4283         Call beneath target's mourn_inferior after unpushing.
4284
4285 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
4286
4287         PR tui/9765
4288         * tui/tui-disasm.c (tui_find_disassembly_address): If we don't
4289         have enough lines to fill the screen, still return the lowest
4290         address we found.
4291
4292 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
4293
4294         * tui/tui-win.c (_initialize_tui_win): Update help text for '+',
4295         '-', '<', and '>' commands.
4296
4297 2020-01-29  Pedro Alves  <palves@redhat.com>
4298             Sergio Durigan Junior  <sergiodj@redhat.com>
4299
4300         * infcmd.c (construct_inferior_arguments): Assert that
4301         'argc' is greater than 0.
4302
4303 2020-01-29  Luis Machado  <luis.machado@linaro.org>
4304
4305         * aarch64-tdep.c (BRK_INSN_MASK): Define to 0xffe0001f.
4306         (BRK_INSN_MASK): Define to 0xd4200000.
4307         (aarch64_program_breakpoint_here_p): New function.
4308         (aarch64_gdbarch_init): Set gdbarch_program_breakpoint_here_p hook.
4309         * arch-utils.c (default_program_breakpoint_here_p): Moved from
4310         breakpoint.c.
4311         * arch-utils.h (default_program_breakpoint_here_p): Moved from
4312         breakpoint.h
4313         * breakpoint.c (bp_loc_is_permanent): Changed return type to bool and
4314         call gdbarch_program_breakpoint_here_p.
4315         (program_breakpoint_here): Moved to arch-utils.c, renamed to
4316         default_program_breakpoint_here_p, changed return type to bool and
4317         simplified.
4318         * breakpoint.h (program_breakpoint_here): Moved prototype to
4319         arch-utils.h, renamed to default_program_breakpoint_here_p and changed
4320         return type to bool.
4321         * gdbarch.c: Regenerate.
4322         * gdbarch.h: Regenerate.
4323         * gdbarch.sh (program_breakpoint_here_p): New method.
4324         * infrun.c (handle_signal_stop): Call
4325         gdbarch_program_breakpoint_here_p.
4326
4327 2020-01-26  Tom Tromey  <tom@tromey.com>
4328
4329         * ctfread.c (struct ctf_fp_info): Reindent.
4330         (_initialize_ctfread): Remove.
4331
4332 2020-01-26  Tom Tromey  <tom@tromey.com>
4333
4334         * psymtab.c (partial_map_expand_apply)
4335         (psym_find_pc_sect_compunit_symtab, psym_lookup_symbol)
4336         (psymtab_to_symtab, psym_find_last_source_symtab, dump_psymtab)
4337         (psym_print_stats, psym_expand_symtabs_for_function)
4338         (psym_map_symbol_filenames, psym_map_matching_symbols)
4339         (psym_expand_symtabs_matching)
4340         (partial_symtab::read_dependencies, maintenance_info_psymtabs)
4341         (maintenance_check_psymtabs): Use new methods.
4342         * psympriv.h (struct partial_symtab) <readin_p,
4343         get_compunit_symtab>: New methods.
4344         <readin, compunit_symtab>: Remove members.
4345         (struct standard_psymtab): New.
4346         (struct legacy_psymtab): Derive from standard_psymtab.
4347         * dwarf2read.h (struct dwarf2_psymtab): Derive from
4348         standard_psymtab.
4349         * ctfread.c (struct ctf_psymtab): Derive from standard_psymtab.
4350
4351 2020-01-26  Tom Tromey  <tom@tromey.com>
4352
4353         * xcoffread.c (xcoff_psymtab_to_symtab_1): Call
4354         read_dependencies.  Add assert.
4355         * psymtab.c (partial_symtab::read_dependencies): New method.
4356         * psympriv.h (struct partial_symtab) <read_dependencies>: New
4357         method.
4358         * mdebugread.c (psymtab_to_symtab_1): Call read_dependencies.
4359         * dwarf2read.c (dwarf2_psymtab::expand_psymtab): Call
4360         read_dependencies.
4361         * dbxread.c (dbx_psymtab_to_symtab_1): Call read_dependencies.
4362         Add assert.
4363
4364 2020-01-26  Tom Tromey  <tom@tromey.com>
4365
4366         * xcoffread.c (xcoff_psymtab_to_symtab_1): Change argument order.
4367         Call expand_psymtab.
4368         (xcoff_read_symtab): Call expand_psymtab.
4369         (xcoff_start_psymtab, xcoff_end_psymtab): Set
4370         legacy_expand_psymtab.
4371         * psympriv.h (struct partial_symtab) <expand_psymtab>: New
4372         method.
4373         (struct legacy_psymtab) <expand_psymtab>: Implement.
4374         <legacy_expand_psymtab>: New member.
4375         * mdebugread.c (mdebug_read_symtab): Call expand_psymtab.
4376         (parse_partial_symbols): Set legacy_expand_psymtab.
4377         (psymtab_to_symtab_1): Change argument order.  Call
4378         expand_psymtab.
4379         (new_psymtab): Set legacy_expand_psymtab.
4380         * dwarf2read.h (struct dwarf2_psymtab) <expand_psymtab>: Declare.
4381         * dwarf2read.c (dwarf2_psymtab::read_symtab): Call
4382         expand_psymtab.
4383         (dwarf2_psymtab::expand_psymtab): Rename from
4384         psymtab_to_symtab_1.  Call expand_psymtab.
4385         * dbxread.c (start_psymtab): Set legacy_expand_psymtab.
4386         (dbx_end_psymtab): Likewise.
4387         (dbx_psymtab_to_symtab_1): Change argument order. Call
4388         expand_psymtab.
4389         (dbx_read_symtab): Call expand_psymtab.
4390         * ctfread.c (struct ctf_psymtab) <expand_psymtab>: Declare.
4391         (ctf_psymtab::expand_psymtab): Rename from psymtab_to_symtab.
4392         (ctf_psymtab::read_symtab): Call expand_psymtab.
4393
4394 2020-01-26  Tom Tromey  <tom@tromey.com>
4395
4396         * xcoffread.c (xcoff_read_symtab): Remove prints.  Add assert.
4397         * psymtab.c (psymtab_to_symtab): Print verbose "Reading"
4398         messages.
4399         * mdebugread.c (mdebug_read_symtab): Remove prints.
4400         * dwarf2read.c (dwarf2_psymtab::read_symtab): Remove prints.  Add
4401         assert.
4402         * dbxread.c (dbx_read_symtab): Remove prints.  Add assert.
4403
4404 2020-01-26  Tom Tromey  <tom@tromey.com>
4405
4406         * xcoffread.c (this_symtab_psymtab, read_xcoff_symtab)
4407         (xcoff_psymtab_to_symtab_1, xcoff_read_symtab)
4408         (xcoff_start_psymtab, xcoff_end_psymtab, scan_xcoff_symtab): Use
4409         legacy_symtab.
4410         * stabsread.h (dbx_end_psymtab): Use legacy_symtab.
4411         * psymtab.c (psymtab_to_symtab): Call method.
4412         (dump_psymtab): Update.
4413         * psympriv.h (struct partial_symtab): Add virtual destructor.
4414         <read_symtab>: New method.
4415         (struct legacy_symtab): New.
4416         * mdebugread.c (mdebug_read_symtab): Use legacy_psymtab.
4417         (struct pst_map) <pst>: Now a legacy_psymtab.
4418         (parse_procedure, parse_partial_symbols, psymtab_to_symtab_1)
4419         (new_psymtab): Use legacy_psymtab.
4420         * dwarf2read.h (struct dwarf2_psymtab): New.
4421         (struct dwarf2_per_cu_data) <psymtab>: Use it.
4422         * dwarf2read.c (dwarf2_create_include_psymtab)
4423         (dwarf2_build_include_psymtabs, create_type_unit_group)
4424         (create_partial_symtab, process_psymtab_comp_unit_reader)
4425         (build_type_psymtabs_reader, build_type_psymtab_dependencies)
4426         (set_partial_user): Use dwarf2_psymtab.
4427         (dwarf2_psymtab::read_symtab): Rename from dwarf2_read_symtab.
4428         (psymtab_to_symtab_1, process_full_comp_unit)
4429         (process_full_type_unit, dwarf2_ranges_read)
4430         (dwarf2_get_pc_bounds, psymtab_include_file_name)
4431         (dwarf_decode_lines): Use dwarf2_psymtab.
4432         * dwarf-index-write.c (psym_index_map): Use dwarf2_psymtab.
4433         (add_address_entry_worker, write_one_signatured_type)
4434         (recursively_count_psymbols, recursively_write_psymbols)
4435         (write_one_signatured_type, psyms_seen_size, write_gdbindex)
4436         (write_debug_names): Likewise.
4437         * dbxread.c (struct header_file_location): Take a legacy_psymtab.
4438         <pst>: Now a legacy_psymtab.
4439         (find_corresponding_bincl_psymtab): Return a legacy_psymtab.
4440         (read_dbx_symtab, start_psymtab, dbx_end_psymtab)
4441         (dbx_psymtab_to_symtab_1, read_ofile_symtab): Use legacy_psymtab.
4442         * ctfread.c (struct ctf_psymtab): New.
4443         (ctf_start_symtab, ctf_end_symtab, psymtab_to_symtab): Take a
4444         ctf_psymtab.
4445         (ctf_psymtab::read_symtab): Rename from ctf_read_symtab.
4446         (create_partial_symtab): Return a ctf_psymtab.
4447         (scan_partial_symbols): Update.
4448
4449 2020-01-26  Tom Tromey  <tom@tromey.com>
4450
4451         * xcoffread.c (xcoff_start_psymtab): Use new.
4452         * psymtab.c (partial_symtab::partial_symtab): New constructor,
4453         renamed from start_psymtab_common.
4454         * psympriv.h (struct partial_symtab): Add new constructor.
4455         (start_psymtab_common): Don't declare.
4456         * mdebugread.c (parse_partial_symbols): Use new.
4457         * dwarf2read.c (create_partial_symtab): Use new.
4458         * dbxread.c (start_psymtab): Use new.
4459         * ctfread.c (create_partial_symtab): Use new.
4460
4461 2020-01-26  Tom Tromey  <tom@tromey.com>
4462
4463         * xcoffread.c (xcoff_end_psymtab): Use new.
4464         * psymtab.c (start_psymtab_common): Use new.
4465         (partial_symtab::partial_symtab): Rename from allocate_psymtab.
4466         Update.
4467         * psympriv.h (struct partial_symtab): Add parameters to
4468         constructor.  Don't inline.
4469         (allocate_psymtab): Don't declare.
4470         * mdebugread.c (new_psymtab): Use new.
4471         * dwarf2read.c (dwarf2_create_include_psymtab): Use new.
4472         * dbxread.c (dbx_end_psymtab): Use new.
4473
4474 2020-01-26  Tom Tromey  <tom@tromey.com>
4475
4476         * psymtab.h (class psymtab_storage) <install_psymtab>: Rename from
4477         allocate_psymtab.  Update documentation.
4478         * psymtab.c (psymtab_storage::install_psymtab): Rename from
4479         allocate_psymtab.  Do not use new.
4480         (allocate_psymtab): Use new.  Update.
4481
4482 2020-01-26  Tom Tromey  <tom@tromey.com>
4483
4484         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
4485         * psymtab.c (psym_print_stats): Update.
4486         * psympriv.h (struct partial_symtab) <readin,
4487         psymtabs_addrmap_supported, anonymous>: Now bool.
4488         * mdebugread.c (psymtab_to_symtab_1): Update.
4489         * dwarf2read.c (create_type_unit_group, create_partial_symtab)
4490         (build_type_psymtabs_reader, psymtab_to_symtab_1)
4491         (process_full_comp_unit, process_full_type_unit): Update.
4492         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
4493         * ctfread.c (psymtab_to_symtab): Update.
4494
4495 2020-01-26  Tom Tromey  <tom@tromey.com>
4496
4497         * mdebugread.c (parse_partial_symbols): Use discard_psymtab.
4498         * psymtab.h (class psymtab_storage) <free_psymtabs>: Remove.
4499         * psymtab.c (psymtab_storage): Delete psymtabs.
4500         (psymtab_storage::allocate_psymtab): Use new.
4501         (psymtab_storage::discard_psymtab): Use delete.
4502         * psympriv.h (struct partial_symtab): Add constructor and
4503         initializers.
4504
4505 2020-01-26  Tom Tromey  <tom@tromey.com>
4506
4507         * machoread.c: Do not include psympriv.h.
4508
4509 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4510
4511         * NEWS: Mention the new option and the set/show commands.
4512
4513 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4514
4515         * exec.c (exec_file_mismatch_names, exec_file_mismatch_mode)
4516         (show_exec_file_mismatch_command, set_exec_file_mismatch_command)
4517         (validate_exec_file): New variables, enums, functions.
4518         (exec_file_locate_attach, print_section_info): Style the filenames.
4519         (_initialize_exec): Install show_exec_file_mismatch_command and
4520          set_exec_file_mismatch_command.
4521         * gdbcore.h (validate_exec_file): Declare.
4522         * infcmd.c (attach_command): Call validate_exec_file.
4523         * remote.c ( remote_target::remote_add_inferior): Likewise.
4524
4525 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
4526
4527         * frame.c (find_frame_sal): Move call to get_next_frame into more
4528         inner scope.
4529         * inline-frame.c (inilne_state) <inline_state>: Update argument
4530         types.
4531         (inilne_state) <skipped_symbol>: Rename to...
4532         (inilne_state) <skipped_symbols>: ...this, and change to a vector.
4533         (skip_inline_frames): Build vector of skipped symbols and use this
4534         to reate the inline_state.
4535         (inline_skipped_symbol): Add a comment and some assertions, fetch
4536         skipped symbol from the list.
4537
4538 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
4539
4540         * buildsym.c (lte_is_less_than): Delete.
4541         (buildsym_compunit::end_symtab_with_blockvector): Create local
4542         lambda function to sort line table entries, and use
4543         std::stable_sort instead of std::sort.
4544         * symtab.c (find_pc_sect_line): Skip backward over end of sequence
4545         markers when looking for a previous line.
4546
4547 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
4548
4549         * dwarf2read.c (lnp_state_machine::record_line): Include
4550         end_sequence parameter in debug print out.  Record the line if we
4551         are at an end_sequence marker even if it's not the start of a
4552         statement.
4553         * symmisc.c (maintenance_print_one_line_table): Print end of
4554         sequence markers with 'END' not '0'.
4555
4556 2020-01-24  Pedro Alves  <palves@redhat.com>
4557
4558         PR gdb/25410
4559         * thread.c (scoped_restore_current_thread::restore): Use
4560         switch_to_inferior_no_thread.
4561         * exec.c: Include "progspace-and-thread.h".
4562         (add_target_sections, remove_target_sections):
4563         scoped_restore_current_pspace_and_thread instead of
4564         scoped_restore_current_thread.
4565         * infrun.c (handle_vfork_child_exec_or_exit): Assign the pspace
4566         and aspace to the inferior before calling clone_program_space.
4567         Remove stale comment.
4568
4569 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
4570
4571         * arm-nbsd-nat.c (arm_nbsd_nat_target::fetch_registers): Rename to...
4572         (arm_netbsd_nat_target::fetch_registers): ...this.
4573         (arm_nbsd_nat_target::store_registers): Rename to...
4574         (arm_netbsd_nat_target::store_registers): ...this.
4575
4576 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
4577
4578         * arm-nbsd-nat.c: Define _KERNTYPES to get the declaration of
4579         register_t.
4580
4581 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
4582
4583         * aarch64-fbsd-tdep.c (aarch64_fbsd_iterate_over_regset_sections):
4584         Update comment.
4585         * aarch64-linux-tdep.c (aarch64_linux_iterate_over_regset_sections):
4586         Likewise.
4587         * arm-fbsd-tdep.c (arm_fbsd_iterate_over_regset_sections): Likewise.
4588         * gdbcore.h (deprecated_add_core_fns): Update comment to point to
4589         the correct replacement (iterate_over_regset_sections).
4590         * riscv-fbsd-tdep.c (riscv_fbsd_iterate_over_regset_sections):
4591         Update comment.
4592
4593 2020-01-24  Graham Markall  <graham.markall@embecosm.com>
4594
4595         PR gdb/23718
4596         * gdb/python/python.c (execute_gdb_command): Call
4597         async_enable_stdin in catch block.
4598
4599 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
4600
4601         * event-loop.c (start_event_loop): Wrap async_enable_stdin with
4602         SWITCH_THRU_ALL_UIS.
4603
4604 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
4605
4606         PR tui/9765
4607         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update header
4608         comment, add extra parameter, and update to store previous symbol
4609         when appropriate.
4610         * minsyms.h (lookup_minimal_symbol_by_pc_section): Update comment,
4611         add extra parameter.
4612         * tui/tui-disasm.c (tui_disassemble): Update header comment,
4613         remove unneeded parameter, add try/catch around gdb_print_insn,
4614         rewrite to add items to asm_lines vector.
4615         (tui_find_backward_disassembly_start_address): New function.
4616         (tui_find_disassembly_address): Updated throughout.
4617         (tui_disasm_window::set_contents): Update for changes to
4618         tui_disassemble.
4619         (tui_disasm_window::do_scroll_vertical): No need to adjust the
4620         number of lines to scroll.
4621
4622 2020-01-23  Simon Marchi  <simon.marchi@polymtl.ca>
4623
4624         * objfiles.h (ALL_OBJFILE_OSECTIONS): Move up.
4625         (SECT_OFF_DATA): Likewise.
4626         (SECT_OFF_RODATA): Likewise.
4627         (SECT_OFF_TEXT): Likewise.
4628         (SECT_OFF_BSS): Likewise.
4629         (struct objfile) <text_section_offset, data_section_offset>: New
4630         methods.
4631         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Use
4632         objfile::text_section_offset.
4633         * coff-pe-read.c (add_pe_forwarded_sym): Likewise.
4634         * coffread.c (coff_symtab_read): Likewise.
4635         (enter_linenos): Likewise.
4636         (process_coff_symbol): Likewise.
4637         * ctfread.c (get_objfile_text_range): Likewise.
4638         * dtrace-probe.c (dtrace_probe::get_relocated_address):
4639         Use objfile::data_section_offset.
4640         * dwarf2-frame.c (execute_cfa_program): Use
4641         objfile::text_section_offset.
4642         (dwarf2_frame_find_fde): Likewise.
4643         * dwarf2read.c (create_addrmap_from_index): Likewise.
4644         (create_addrmap_from_aranges): Likewise.
4645         (dw2_find_pc_sect_compunit_symtab): Likewise.
4646         (process_psymtab_comp_unit_reader): Likewise.
4647         (add_partial_symbol): Likewise.
4648         (add_partial_subprogram): Likewise.
4649         (process_full_comp_unit): Likewise.
4650         (read_file_scope): Likewise.
4651         (read_func_scope): Likewise.
4652         (read_lexical_block_scope): Likewise.
4653         (read_call_site_scope): Likewise.
4654         (dwarf2_rnglists_process): Likewise.
4655         (dwarf2_ranges_process): Likewise.
4656         (dwarf2_ranges_read): Likewise.
4657         (dwarf_decode_lines_1): Likewise.
4658         (new_symbol): Likewise.
4659         (dwarf2_fetch_die_loc_sect_off): Likewise.
4660         (dwarf2_per_cu_text_offset): Likewise.
4661         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Likewise.
4662         * hppa-tdep.c (read_unwind_info): Likewise.
4663         * ia64-tdep.c (ia64_find_unwind_table): Likewise.
4664         * psympriv.h (struct partial_symtab): Likewise.
4665         * psymtab.c (find_pc_sect_psymtab): Likewise.
4666         * solib-svr4.c (enable_break): Likewise.
4667         * stap-probe.c (relocate_address): Use
4668         objfile::data_section_offset.
4669         * xcoffread.c (enter_line_range): Use
4670         objfile::text_section_offset.
4671         (read_xcoff_symtab): Likewise.
4672
4673 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
4674
4675         * darwin-nat.c (darwin_nat_target::wait_1): Move `inf`
4676         declaration to narrower scopes.
4677
4678 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
4679
4680         * darwin-nat.h (struct darwin_exception_msg, enum
4681         darwin_msg_state, struct darwin_thread_info, darwin_thread_t):
4682         Move up.
4683         (class darwin_nat_target) <wait_1, check_new_threads,
4684         decode_exception_message, decode_message, stop_inferior,
4685         init_thread_list, ptrace_him, cancel_breakpoint>: Declare.
4686         * darwin-nat.c (darwin_check_new_threads): Rename to...
4687         (darwin_nat_target::check_new_threads): ... this.
4688         (darwin_suspend_inferior_it): Remove.
4689         (darwin_decode_exception_message): Rename to...
4690         (darwin_nat_target::decode_exception_message): ... this.
4691         (darwin_nat_target::resume): Pass target to find_inferior_ptid.
4692         (darwin_decode_message): Rename to...
4693         (darwin_nat_target::decode_message): ... this.
4694         (cancel_breakpoint): Rename to...
4695         (darwin_nat_target::cancel_breakpoint): ... this.
4696         (darwin_wait): Rename to...
4697         (darwin_nat_target::wait_1): ... this.  Use range-based for loop
4698         instead of iterate_over_inferiors.
4699         (darwin_nat_target::wait): Call wait_1 instead of darwin_wait.
4700         (darwin_stop_inferior): Rename to...
4701         (darwin_nat_target::stop_inferior): ... this.
4702         (darwin_nat_target::kill): Call wait_1 instead of darwin_wait.
4703         (darwin_init_thread_list): Rename to...
4704         (darwin_nat_target::init_thread_list): ... this.
4705         (darwin_ptrace_him): Rename to...
4706         (darwin_nat_target::ptrace_him): ... this.
4707         (darwin_nat_target::create_inferior): Pass lambda function to
4708         fork_inferior.
4709         (darwin_nat_target::detach): Call stop_inferior instead of
4710         darwin_stop_inferior.
4711         * fork-inferior.h (fork_inferior): Change init_trace_fun
4712         parameter to gdb::function_view.
4713         * fork-inferior.c (fork_inferior): Likewise.
4714
4715 2020-01-23  Hannes Domani  <ssbssa@yahoo.de>
4716
4717         * i386-cygwin-tdep.c (core_process_module_section): Update.
4718         * windows-nat.c (struct lm_info_windows): Add text_offset.
4719         (windows_xfer_shared_libraries): Update.
4720         * windows-tdep.c (windows_xfer_shared_library):
4721         Add text_offset_cached argument.
4722         * windows-tdep.h (windows_xfer_shared_library): Update.
4723
4724 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
4725
4726         * gdbarch.sh: Add declaration for _initialize_gdbarch.
4727
4728 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
4729
4730         * remote-sim.c (check_for_duplicate_sim_descriptor): Remove.
4731         (get_sim_inferior_data): Remove use of iterate_over_inferiors,
4732         replace with range-based for.
4733         (gdbsim_interrupt_inferior): Remove.
4734         (gdbsim_target::interrupt): Replace iterate_over_inferiors use
4735         with a range-based for.  Inline code from
4736         gdbsim_interrupt_inferior.
4737
4738 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
4739
4740         * infrun.c (proceed): Fix indentation.
4741
4742 2020-01-21  Tom Tromey  <tromey@adacore.com>
4743
4744         * source-cache.c (source_cache::ensure): Call ext_lang_colorize.
4745         * python/python.c (python_extension_ops): Update.
4746         (gdbpy_colorize): New function.
4747         * python/lib/gdb/__init__.py (colorize): New function.
4748         * extension.h (ext_lang_colorize): Declare.
4749         * extension.c (ext_lang_colorize): New function.
4750         * extension-priv.h (struct extension_language_ops) <colorize>: New
4751         member.
4752         * cli/cli-style.c (_initialize_cli_style): Update help text.
4753
4754 2020-01-21  Luis Machado  <luis.machado@linaro.org>
4755
4756         * aarch64-tdep.c (struct aarch64_displaced_step_closure)
4757         <cond>: Change type to bool.
4758         (aarch64_displaced_step_b_cond): Update cond to use bool type.
4759         (aarch64_displaced_step_cb): Likewise.
4760         (aarch64_displaced_step_tb): Likewise.
4761
4762 2020-01-21  Luis Machado  <luis.machado@linaro.org>
4763
4764         * aarch64-tdep.c (aarch64_displaced_step_fixup): Add more debugging
4765         output.
4766
4767 2020-01-21  Luis Machado  <luis.machado@linaro.org>
4768
4769         * aarch64-tdep.c (struct aarch64_displaced_step_closure )
4770         <pc_adjust>: Adjust the documentation.
4771         (aarch64_displaced_step_fixup): Check if PC really moved before
4772         adjusting it.
4773
4774 2020-01-19  Tom Tromey  <tom@tromey.com>
4775
4776         * disasm.c (~gdb_disassembler): New destructor.
4777         (gdb_buffered_insn_length): Call disassemble_free_target.
4778         * disasm.h (class gdb_disassembler): Declare destructor.  Use
4779         DISABLE_COPY_AND_ASSIGN.
4780
4781 2020-01-19  Tom Tromey  <tom@tromey.com>
4782
4783         * dwarf2read.c (abbrev_table_up): Move typedef earlier.
4784         (die_reader_func_ftype): Remove.
4785         (cutu_reader): New class.
4786         (dw2_get_file_names_reader): Remove "data" parameter.
4787         (dw2_get_file_names): Use cutu_reader.
4788         (create_debug_type_hash_table): Update.
4789         (read_cutu_die_from_dwo): Update comment.
4790         (lookup_dwo_unit): Add dwo_name parameter.
4791         (cutu_reader::init_tu_and_read_dwo_dies): Now a method.  Remove
4792         die_reader_func_ftype and data parameters.
4793         (cutu_reader::cutu_reader): Rename from init_cutu_and_read_dies.
4794         Remove die_reader_func_ftype and data parameters.
4795         (~cutu_reader): New; from init_cutu_and_read_dies.
4796         (cutu_reader::cutu_reader): Rename from
4797         init_cutu_and_read_dies_no_follow.  Remove die_reader_func_ftype
4798         and data parameters.
4799         (init_cutu_and_read_dies_simple): Remove.
4800         (struct process_psymtab_comp_unit_data): Remove.
4801         (process_psymtab_comp_unit_reader): Remove data parameter; add
4802         want_partial_unit and pretend_language parameters.
4803         (process_psymtab_comp_unit): Use cutu_reader.
4804         (build_type_psymtabs_reader): Remove data parameter.
4805         (build_type_psymtabs_1): Use cutu_reader.
4806         (process_skeletonless_type_unit): Likewise.
4807         (load_partial_comp_unit_reader): Remove.
4808         (load_partial_comp_unit): Use cutu_reader.
4809         (load_full_comp_unit_reader): Remove.
4810         (load_full_comp_unit): Use cutu_reader.
4811         (struct create_dwo_cu_data): Remove.
4812         (create_dwo_cu_reader): Remove datap parameter; add dwo_file and
4813         dwo_unit parameters.
4814         (create_cus_hash_table): Use cutu_reader.
4815         (struct dwarf2_read_addr_index_data): Remove.
4816         (dwarf2_read_addr_index_reader): Remove.
4817         (dwarf2_read_addr_index): Use cutu_reader.
4818         (read_signatured_type_reader): Remove.
4819         (read_signatured_type): Use cutu_reader.
4820
4821 2020-01-19  Tom Tromey  <tom@tromey.com>
4822
4823         * tui/tui.c (tui_show_assembly): Use tui_suppress_output.
4824         * tui/tui-wingeneral.h (class tui_suppress_output): New.
4825         (tui_wrefresh): Declare.
4826         * tui/tui-wingeneral.c (suppress_output): New global.
4827         (tui_suppress_output, ~tui_suppress_output): New constructor and
4828         destructor.
4829         (tui_wrefresh): New function.
4830         (tui_gen_win_info::refresh_window): Use tui_wrefresh.
4831         (tui_gen_win_info::make_window): Call wnoutrefresh when needed.
4832         * tui/tui-regs.h (struct tui_data_window) <no_refresh>: Declare
4833         method.
4834         * tui/tui-regs.c (tui_data_window::erase_data_content): Call
4835         tui_wrefresh.
4836         (tui_data_window::no_refresh): New method.
4837         (tui_data_item_window::refresh_window): Call tui_wrefresh.
4838         (tui_reg_command): Use tui_suppress_output
4839         * tui/tui-layout.c (tui_set_layout): Use tui_suppress_output.
4840         * tui/tui-data.h (struct tui_gen_win_info) <no_refresh>: New
4841         method.
4842         * tui/tui-command.c (tui_refresh_cmd_win): Call tui_wrefresh.
4843
4844 2020-01-19  Tom Tromey  <tom@tromey.com>
4845
4846         * tui/tui-winsource.c (tui_update_source_windows_with_line):
4847         Handle case where symtab is null.
4848
4849 2020-01-19  Simon Marchi  <simon.marchi@polymtl.ca>
4850
4851         * linux-fork.c (one_fork_p): Simplify.
4852
4853 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
4854
4855         * top.c (struct qt_args): Remove.
4856         (kill_or_detach): Change return type to void, replace `void *`
4857         parameter with a proper one.
4858         (print_inferior_quit_action):  Likewise.
4859         (quit_confirm): Use range-based for loop to iterate over inferiors.
4860         (quit_force): Likewise.
4861
4862 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
4863
4864         * mi/mi-main.c (run_one_inferior): Change return type to void, replace
4865         `void *` parameter with proper parameters.
4866         (mi_cmd_exec_run): Use range-based loop to iterate over inferiors.
4867         (print_one_inferior): Change return type to void, replace `void *`
4868         parameter with proper parameters.
4869         (mi_cmd_list_thread_groups): Use range-based loop to iterate over
4870         inferiors.
4871         (get_other_inferior): Remove.
4872         (mi_cmd_remove_inferior): Use range-based loop to iterate over
4873         inferiors.
4874
4875 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
4876
4877         * mi/mi-interp.c (report_initial_inferior): Remove.
4878         (mi_interp::init): Use range-based for to iterate over inferiors.
4879
4880 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
4881
4882         * python/py-inferior.c (build_inferior_list): Remove.
4883         (gdbpy_ref): Use range-based for loop to iterate over inferiors.
4884
4885 2020-01-16  Christian Biesinger  <cbiesinger@google.com>
4886
4887         * btrace.c (btrace_compute_ftrace_1): Fix spelling error (Unkown).
4888         (btrace_stitch_trace): Likewise.
4889         * charset.c (intermediate_encoding): Likewise (vaild).
4890         * nat/linux-btrace.c (linux_read_pt): Likewise (Unkown).
4891         * python/py-record-btrace.c (struct PyMethodDef): Likewise (occurences).
4892         * record-btrace.c (record_btrace_print_conf): Likewise (unkown).
4893
4894 2020-01-16  Hannes Domani  <ssbssa@yahoo.de>
4895
4896         * windows-tdep.c (windows_get_tlb_type):
4897         Add rtl_user_process_parameters type.
4898
4899 2020-01-16  Pedro Alves  <palves@redhat.com>
4900             Norbert Lange  <nolange79@gmail.com>
4901
4902         PR build/24805
4903         * gdbsupport/gdb_proc_service.h (PS_EXPORT): New.
4904         (ps_get_thread_area, ps_getpid, ps_lcontinue, ps_lgetfpregs)
4905         (ps_lgetregs, ps_lsetfpregs, ps_lsetregs, ps_lstop, ps_pcontinue)
4906         (ps_pdread, ps_pdwrite, ps_pglobal_lookup, ps_pstop, ps_ptread)
4907         (ps_ptwrite, ps_lgetxregs, ps_lgetxregsize, ps_lsetxregs)
4908         (ps_plog): Redeclare exported functions with default visibility.
4909
4910 2020-01-16  Nitika Achra  <Nitika.Achra@amd.com>
4911
4912         * dwarf2loc.c (decode_debug_loclists_addresses): Handle
4913         DW_LLE_base_addressx, DW_LLE_startx_length, DW_LLE_start_length.
4914
4915 2020-01-15  Simon Marchi  <simon.marchi@efficios.com>
4916
4917         * infcmd.c (post_create_inferior): Use get_thread_regcache
4918         instead of get_current_regcache.
4919
4920 2020-01-14  Tom Tromey  <tom@tromey.com>
4921
4922         PR symtab/12535:
4923         * python/python.c (gdbpy_decode_line): Treat empty string the same
4924         as no argument.
4925
4926 2020-01-14  Tom Tromey  <tom@tromey.com>
4927
4928         * Makefile.in (CLIBS): Remove second use of $(LIBIBERTY).
4929
4930 2020-01-14  Tom Tromey  <tom@tromey.com>
4931
4932         * nat/linux-btrace.c: Don't include <config.h>.
4933         * nat/linux-ptrace.c: Don't include <config.h>.
4934         * nat/x86-linux-dregs.c: Don't include <config.h>.
4935
4936 2020-01-14  Tom Tromey  <tom@tromey.com>
4937
4938         * configure: Rebuild.
4939         * configure.ac: Move many checks to ../gdbsupport/common.m4.
4940
4941 2020-01-14  Tom Tromey  <tom@tromey.com>
4942
4943         * nat/x86-linux-dregs.c: Include configh.h.
4944         * nat/linux-ptrace.c: Include configh.h.
4945         * nat/linux-btrace.c: Include configh.h.
4946         * defs.h: Include config.h, bfd.h.
4947         * configure.ac: Don't source common.host.
4948         (CONFIG_OBS, CONFIG_SRCS): Remove gdbsupport files.
4949         * configure: Rebuild.
4950         * acinclude.m4: Update path.
4951         * Makefile.in (SUPPORT, LIBSUPPORT, INCSUPPORT): New variables.
4952         (CONFIG_SRC_SUBDIR): Remove gdbsupport.
4953         (INTERNAL_CFLAGS_BASE): Add INCSUPPORT.
4954         (CLIBS): Add LIBSUPPORT.
4955         (CDEPS): Likewise.
4956         (COMMON_SFILES): Remove gdbsupport files.
4957         (HFILES_NO_SRCDIR): Likewise.
4958         (stamp-version): Update path to create-version.sh.
4959         (ALLDEPFILES): Remove gdbsupport files.
4960
4961 2020-01-14  Tom Tromey  <tom@tromey.com>
4962
4963         * gdbsupport/common.m4 (GDB_AC_COMMON): Define WIN32APILIBS and
4964         USE_WIN32API when needed.
4965         * configure.ac (USE_WIN32API): Don't define.
4966         (WIN32LIBS): Use WIN32APILIBS.
4967         * configure: Rebuild.
4968
4969 2020-01-14  Tom Tromey  <tom@tromey.com>
4970
4971         * configure: Rebuild.
4972         * gdbsupport/common.m4 (GDB_AC_COMMON): Fix indentation.
4973
4974 2020-01-14  Bernd Edlinger  <bernd.edlinger@hotmail.de>
4975
4976         * skip.c (skip_function_command): Make skip w/o arguments use the
4977         name of the inlined function if pc is inside any inlined function.
4978
4979 2020-01-14  Luis Machado  <luis.machado@linaro.org>
4980
4981         * inf-ptrace.c (inf_ptrace_target::resume): Update comments.
4982         * infrun.c (resume_1): Likewise.
4983         (handle_inferior_event): Remove stale comment.
4984         * linux-nat.c (linux_nat_target::resume): Update comments.
4985         (save_stop_reason): Likewise.
4986         (linux_nat_filter_event): Likewise.
4987         * linux-nat.h (struct lwp_info) <stop_pc>, <stop_reason>: Likewise.
4988
4989 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4990
4991         * elfread.c (record_minimal_symbol): Set section index to 0 for
4992         non-allocatable sections.
4993
4994
4995 2020-01-13  Ali Tamur <tamur@google.com>
4996
4997         * dwarf2read.c (dwarf2_debug_sections): Add debug_str_offsets sections.
4998         (dwarf2_cu): Add str_offsets_base field.  Change the type of addr_base
4999         to gdb::optional.  Update comments.
5000         (dwo_file): Update comments.
5001         (read_attribute): Update API to take an additional out parameter,
5002         need_reprocess.  This is used to mark attributes that need other
5003         attributes (e.g. str_offsets_base) for correct computation which may not
5004         have been read yet.
5005         (read_attribute_reprocess): New function declaration.
5006         (read_addr_index): Likewise.
5007         (read_dwo_str_index): Likewise.
5008         (read_stub_str_index): Likewise.
5009         (dwarf2_per_objfile::locate_sections): Handle debug_str_offsets section.
5010         (lookup_addr_base): New function definition.
5011         (lookup_ranges_base): Likewise.
5012         (read_cutu_die_from_dwo): Use the new functions: lookup_addr_base,
5013         lookup_ranges_base.
5014         (init_cutu_and_read_dies): Update comments.
5015         (init_cutu_and_read_dies_no_follow): Change API to take parent compile
5016         unit.  This is used to inherit parent's str_offsets_base and addr_base.
5017         Update comments.
5018         (init_cutu_and_read_dies_simple): Reflect API changes.
5019         (skip_one_die): Reflect API changes.  Handle DW_FORM_rnglistx.
5020         (create_cus_hash_table): Change API to take parent compile unit.
5021         Reflect API changes.
5022         (open_and_init_dwo_file): Reflect API changes.
5023         (dwarf2_get_pc_bounds): Update comments.
5024         (dwarf2_record_block_ranges): Likewise.
5025         (read_full_die_1): Change implementation to reprocess attributes that
5026         need str_offsets_base and addr_base.
5027         (partial_die_info::read): Likewise.
5028         (read_attribute_reprocess): New function definition.
5029         (read_attribute_value): Change API to take an additional out parameter,
5030         need_reprocess.  Handle DW_FORM_rnglistx.  No longer trigger an error
5031         when a non-dwo compile unit has index based attributes.
5032         (read_attribute): Reflect API changes.
5033         (read_addr_index_1): Reflect API changes.  Update comments.
5034         (dwarf2_read_addr_index_data): Reflect API changes.
5035         (dwarf2_read_addr_index): Likewise.
5036         (read_str_index): Change API and implementation.  This becomes a helper
5037         to be used by the new string index related methods.  Update error
5038         message and comments.
5039         (read_dwo_str_index): New function definition.
5040         (read_stub_str_index): Likewise.
5041         * dwarf2read.h (dwarf2_per_objfile): Add str_offsets field.
5042         * symfile.h (dwarf2_debug_sections): Likewise.
5043         * xcoffread.c (dwarf2_debug_sections): Likewise.
5044
5045 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
5046
5047         * gdbcore.h (struct core_fns) <core_read_registers>: Change
5048         core_reg_sect type to gdb_byte *.
5049         * arm-nbsd-nat.c (fetch_elfcore_registers): Likewise.
5050         * cris-tdep.c (fetch_core_registers): Likewise.
5051         * corelow.c (core_target::get_core_register_section): Change
5052         type of `contents` to gdb::byte_vector.
5053
5054 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5055
5056         * tui/tui-wingeneral.c (box_win): Position the title in the center
5057         of the border.
5058
5059 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
5060
5061         * corelow.c (core_target::get_core_register_section): Use
5062           std::vector instead of alloca.
5063
5064 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
5065
5066         * warning.m4: Add -Wmissing-declarations to build_warnings.
5067         * configure: Re-generate.
5068
5069 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
5070
5071         * python/python.c (init__gdb_module): Add declaration.
5072
5073 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
5074
5075         * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Add declaration.
5076         * aarch64-fbsd-tdep.c (_initialize_aarch64_fbsd_tdep): Add declaration.
5077         * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Add declaration.
5078         * aarch64-linux-tdep.c (_initialize_aarch64_linux_tdep): Add declaration.
5079         * aarch64-newlib-tdep.c (_initialize_aarch64_newlib_tdep): Add declaration.
5080         * aarch64-tdep.c (_initialize_aarch64_tdep): Add declaration.
5081         * ada-exp.y (_initialize_ada_exp): Add declaration.
5082         * ada-lang.c (_initialize_ada_language): Add declaration.
5083         * ada-tasks.c (_initialize_tasks): Add declaration.
5084         * agent.c (_initialize_agent): Add declaration.
5085         * aix-thread.c (_initialize_aix_thread): Add declaration.
5086         * alpha-bsd-nat.c (_initialize_alphabsd_nat): Add declaration.
5087         * alpha-linux-nat.c (_initialize_alpha_linux_nat): Add declaration.
5088         * alpha-linux-tdep.c (_initialize_alpha_linux_tdep): Add declaration.
5089         * alpha-nbsd-tdep.c (_initialize_alphanbsd_tdep): Add declaration.
5090         * alpha-obsd-tdep.c (_initialize_alphaobsd_tdep): Add declaration.
5091         * alpha-tdep.c (_initialize_alpha_tdep): Add declaration.
5092         * amd64-darwin-tdep.c (_initialize_amd64_darwin_tdep): Add declaration.
5093         * amd64-dicos-tdep.c (_initialize_amd64_dicos_tdep): Add declaration.
5094         * amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Add declaration.
5095         * amd64-fbsd-tdep.c (_initialize_amd64fbsd_tdep): Add declaration.
5096         * amd64-linux-nat.c (_initialize_amd64_linux_nat): Add declaration.
5097         * amd64-linux-tdep.c (_initialize_amd64_linux_tdep): Add declaration.
5098         * amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Add declaration.
5099         * amd64-nbsd-tdep.c (_initialize_amd64nbsd_tdep): Add declaration.
5100         * amd64-obsd-nat.c (_initialize_amd64obsd_nat): Add declaration.
5101         * amd64-obsd-tdep.c (_initialize_amd64obsd_tdep): Add declaration.
5102         * amd64-sol2-tdep.c (_initialize_amd64_sol2_tdep): Add declaration.
5103         * amd64-tdep.c (_initialize_amd64_tdep): Add declaration.
5104         * amd64-windows-nat.c (_initialize_amd64_windows_nat): Add declaration.
5105         * amd64-windows-tdep.c (_initialize_amd64_windows_tdep): Add declaration.
5106         * annotate.c (_initialize_annotate): Add declaration.
5107         * arc-newlib-tdep.c (_initialize_arc_newlib_tdep): Add declaration.
5108         * arc-tdep.c (_initialize_arc_tdep): Add declaration.
5109         * arch-utils.c (_initialize_gdbarch_utils): Add declaration.
5110         * arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Add declaration.
5111         * arm-fbsd-tdep.c (_initialize_arm_fbsd_tdep): Add declaration.
5112         * arm-linux-nat.c (_initialize_arm_linux_nat): Add declaration.
5113         * arm-linux-tdep.c (_initialize_arm_linux_tdep): Add declaration.
5114         * arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Add declaration.
5115         * arm-nbsd-tdep.c (_initialize_arm_netbsd_tdep): Add declaration.
5116         * arm-obsd-tdep.c (_initialize_armobsd_tdep): Add declaration.
5117         * arm-pikeos-tdep.c (_initialize_arm_pikeos_tdep): Add declaration.
5118         * arm-symbian-tdep.c (_initialize_arm_symbian_tdep): Add declaration.
5119         * arm-tdep.c (_initialize_arm_tdep): Add declaration.
5120         * arm-wince-tdep.c (_initialize_arm_wince_tdep): Add declaration.
5121         * auto-load.c (_initialize_auto_load): Add declaration.
5122         * auxv.c (_initialize_auxv): Add declaration.
5123         * avr-tdep.c (_initialize_avr_tdep): Add declaration.
5124         * ax-gdb.c (_initialize_ax_gdb): Add declaration.
5125         * bfin-linux-tdep.c (_initialize_bfin_linux_tdep): Add declaration.
5126         * bfin-tdep.c (_initialize_bfin_tdep): Add declaration.
5127         * break-catch-sig.c (_initialize_break_catch_sig): Add declaration.
5128         * break-catch-syscall.c (_initialize_break_catch_syscall): Add declaration.
5129         * break-catch-throw.c (_initialize_break_catch_throw): Add declaration.
5130         * breakpoint.c (_initialize_breakpoint): Add declaration.
5131         * bsd-uthread.c (_initialize_bsd_uthread): Add declaration.
5132         * btrace.c (_initialize_btrace): Add declaration.
5133         * charset.c (_initialize_charset): Add declaration.
5134         * cli/cli-cmds.c (_initialize_cli_cmds): Add declaration.
5135         * cli/cli-dump.c (_initialize_cli_dump): Add declaration.
5136         * cli/cli-interp.c (_initialize_cli_interp): Add declaration.
5137         * cli/cli-logging.c (_initialize_cli_logging): Add declaration.
5138         * cli/cli-script.c (_initialize_cli_script): Add declaration.
5139         * cli/cli-style.c (_initialize_cli_style): Add declaration.
5140         * coff-pe-read.c (_initialize_coff_pe_read): Add declaration.
5141         * coffread.c (_initialize_coffread): Add declaration.
5142         * compile/compile-cplus-types.c (_initialize_compile_cplus_types): Add declaration.
5143         * compile/compile.c (_initialize_compile): Add declaration.
5144         * complaints.c (_initialize_complaints): Add declaration.
5145         * completer.c (_initialize_completer): Add declaration.
5146         * copying.c (_initialize_copying): Add declaration.
5147         * corefile.c (_initialize_core): Add declaration.
5148         * corelow.c (_initialize_corelow): Add declaration.
5149         * cp-abi.c (_initialize_cp_abi): Add declaration.
5150         * cp-namespace.c (_initialize_cp_namespace): Add declaration.
5151         * cp-support.c (_initialize_cp_support): Add declaration.
5152         * cp-valprint.c (_initialize_cp_valprint): Add declaration.
5153         * cris-linux-tdep.c (_initialize_cris_linux_tdep): Add declaration.
5154         * cris-tdep.c (_initialize_cris_tdep): Add declaration.
5155         * csky-linux-tdep.c (_initialize_csky_linux_tdep): Add declaration.
5156         * csky-tdep.c (_initialize_csky_tdep): Add declaration.
5157         * ctfread.c (_initialize_ctfread): Add declaration.
5158         * d-lang.c (_initialize_d_language): Add declaration.
5159         * darwin-nat-info.c (_initialize_darwin_info_commands): Add declaration.
5160         * darwin-nat.c (_initialize_darwin_nat): Add declaration.
5161         * dbxread.c (_initialize_dbxread): Add declaration.
5162         * dcache.c (_initialize_dcache): Add declaration.
5163         * disasm-selftests.c (_initialize_disasm_selftests): Add declaration.
5164         * disasm.c (_initialize_disasm): Add declaration.
5165         * dtrace-probe.c (_initialize_dtrace_probe): Add declaration.
5166         * dummy-frame.c (_initialize_dummy_frame): Add declaration.
5167         * dwarf-index-cache.c (_initialize_index_cache): Add declaration.
5168         * dwarf-index-write.c (_initialize_dwarf_index_write): Add declaration.
5169         * dwarf2-frame-tailcall.c (_initialize_tailcall_frame): Add declaration.
5170         * dwarf2-frame.c (_initialize_dwarf2_frame): Add declaration.
5171         * dwarf2expr.c (_initialize_dwarf2expr): Add declaration.
5172         * dwarf2loc.c (_initialize_dwarf2loc): Add declaration.
5173         * dwarf2read.c (_initialize_dwarf2_read): Add declaration.
5174         * elfread.c (_initialize_elfread): Add declaration.
5175         * exec.c (_initialize_exec): Add declaration.
5176         * extension.c (_initialize_extension): Add declaration.
5177         * f-lang.c (_initialize_f_language): Add declaration.
5178         * f-valprint.c (_initialize_f_valprint): Add declaration.
5179         * fbsd-nat.c (_initialize_fbsd_nat): Add declaration.
5180         * fbsd-tdep.c (_initialize_fbsd_tdep): Add declaration.
5181         * filesystem.c (_initialize_filesystem): Add declaration.
5182         * findcmd.c (_initialize_mem_search): Add declaration.
5183         * findvar.c (_initialize_findvar): Add declaration.
5184         * fork-child.c (_initialize_fork_child): Add declaration.
5185         * frame-base.c (_initialize_frame_base): Add declaration.
5186         * frame-unwind.c (_initialize_frame_unwind): Add declaration.
5187         * frame.c (_initialize_frame): Add declaration.
5188         * frv-linux-tdep.c (_initialize_frv_linux_tdep): Add declaration.
5189         * frv-tdep.c (_initialize_frv_tdep): Add declaration.
5190         * ft32-tdep.c (_initialize_ft32_tdep): Add declaration.
5191         * gcore.c (_initialize_gcore): Add declaration.
5192         * gdb-demangle.c (_initialize_gdb_demangle): Add declaration.
5193         * gdb_bfd.c (_initialize_gdb_bfd): Add declaration.
5194         * gdbarch-selftests.c (_initialize_gdbarch_selftests): Add declaration.
5195         * gdbarch.c (_initialize_gdbarch): Add declaration.
5196         * gdbtypes.c (_initialize_gdbtypes): Add declaration.
5197         * gnu-nat.c (_initialize_gnu_nat): Add declaration.
5198         * gnu-v2-abi.c (_initialize_gnu_v2_abi): Add declaration.
5199         * gnu-v3-abi.c (_initialize_gnu_v3_abi): Add declaration.
5200         * go-lang.c (_initialize_go_language): Add declaration.
5201         * go32-nat.c (_initialize_go32_nat): Add declaration.
5202         * guile/guile.c (_initialize_guile): Add declaration.
5203         * h8300-tdep.c (_initialize_h8300_tdep): Add declaration.
5204         * hppa-linux-nat.c (_initialize_hppa_linux_nat): Add declaration.
5205         * hppa-linux-tdep.c (_initialize_hppa_linux_tdep): Add declaration.
5206         * hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Add declaration.
5207         * hppa-nbsd-tdep.c (_initialize_hppanbsd_tdep): Add declaration.
5208         * hppa-obsd-nat.c (_initialize_hppaobsd_nat): Add declaration.
5209         * hppa-obsd-tdep.c (_initialize_hppabsd_tdep): Add declaration.
5210         * hppa-tdep.c (_initialize_hppa_tdep): Add declaration.
5211         * i386-bsd-nat.c (_initialize_i386bsd_nat): Add declaration.
5212         * i386-cygwin-tdep.c (_initialize_i386_cygwin_tdep): Add declaration.
5213         * i386-darwin-nat.c (_initialize_i386_darwin_nat): Add declaration.
5214         * i386-darwin-tdep.c (_initialize_i386_darwin_tdep): Add declaration.
5215         * i386-dicos-tdep.c (_initialize_i386_dicos_tdep): Add declaration.
5216         * i386-fbsd-nat.c (_initialize_i386fbsd_nat): Add declaration.
5217         * i386-fbsd-tdep.c (_initialize_i386fbsd_tdep): Add declaration.
5218         * i386-gnu-nat.c (_initialize_i386gnu_nat): Add declaration.
5219         * i386-gnu-tdep.c (_initialize_i386gnu_tdep): Add declaration.
5220         * i386-go32-tdep.c (_initialize_i386_go32_tdep): Add declaration.
5221         * i386-linux-nat.c (_initialize_i386_linux_nat): Add declaration.
5222         * i386-linux-tdep.c (_initialize_i386_linux_tdep): Add declaration.
5223         * i386-nbsd-nat.c (_initialize_i386nbsd_nat): Add declaration.
5224         * i386-nbsd-tdep.c (_initialize_i386nbsd_tdep): Add declaration.
5225         * i386-nto-tdep.c (_initialize_i386nto_tdep): Add declaration.
5226         * i386-obsd-nat.c (_initialize_i386obsd_nat): Add declaration.
5227         * i386-obsd-tdep.c (_initialize_i386obsd_tdep): Add declaration.
5228         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Add declaration.
5229         * i386-sol2-tdep.c (_initialize_i386_sol2_tdep): Add declaration.
5230         * i386-tdep.c (_initialize_i386_tdep): Add declaration.
5231         * i386-windows-nat.c (_initialize_i386_windows_nat): Add declaration.
5232         * ia64-libunwind-tdep.c (_initialize_libunwind_frame): Add declaration.
5233         * ia64-linux-nat.c (_initialize_ia64_linux_nat): Add declaration.
5234         * ia64-linux-tdep.c (_initialize_ia64_linux_tdep): Add declaration.
5235         * ia64-tdep.c (_initialize_ia64_tdep): Add declaration.
5236         * ia64-vms-tdep.c (_initialize_ia64_vms_tdep): Add declaration.
5237         * infcall.c (_initialize_infcall): Add declaration.
5238         * infcmd.c (_initialize_infcmd): Add declaration.
5239         * inflow.c (_initialize_inflow): Add declaration.
5240         * infrun.c (_initialize_infrun): Add declaration.
5241         * interps.c (_initialize_interpreter): Add declaration.
5242         * iq2000-tdep.c (_initialize_iq2000_tdep): Add declaration.
5243         * jit.c (_initialize_jit): Add declaration.
5244         * language.c (_initialize_language): Add declaration.
5245         * linux-fork.c (_initialize_linux_fork): Add declaration.
5246         * linux-nat.c (_initialize_linux_nat): Add declaration.
5247         * linux-tdep.c (_initialize_linux_tdep): Add declaration.
5248         * linux-thread-db.c (_initialize_thread_db): Add declaration.
5249         * lm32-tdep.c (_initialize_lm32_tdep): Add declaration.
5250         * m2-lang.c (_initialize_m2_language): Add declaration.
5251         * m32c-tdep.c (_initialize_m32c_tdep): Add declaration.
5252         * m32r-linux-nat.c (_initialize_m32r_linux_nat): Add declaration.
5253         * m32r-linux-tdep.c (_initialize_m32r_linux_tdep): Add declaration.
5254         * m32r-tdep.c (_initialize_m32r_tdep): Add declaration.
5255         * m68hc11-tdep.c (_initialize_m68hc11_tdep): Add declaration.
5256         * m68k-bsd-nat.c (_initialize_m68kbsd_nat): Add declaration.
5257         * m68k-bsd-tdep.c (_initialize_m68kbsd_tdep): Add declaration.
5258         * m68k-linux-nat.c (_initialize_m68k_linux_nat): Add declaration.
5259         * m68k-linux-tdep.c (_initialize_m68k_linux_tdep): Add declaration.
5260         * m68k-tdep.c (_initialize_m68k_tdep): Add declaration.
5261         * machoread.c (_initialize_machoread): Add declaration.
5262         * macrocmd.c (_initialize_macrocmd): Add declaration.
5263         * macroscope.c (_initialize_macroscope): Add declaration.
5264         * maint-test-options.c (_initialize_maint_test_options): Add declaration.
5265         * maint-test-settings.c (_initialize_maint_test_settings): Add declaration.
5266         * maint.c (_initialize_maint_cmds): Add declaration.
5267         * mdebugread.c (_initialize_mdebugread): Add declaration.
5268         * memattr.c (_initialize_mem): Add declaration.
5269         * mep-tdep.c (_initialize_mep_tdep): Add declaration.
5270         * mi/mi-cmd-env.c (_initialize_mi_cmd_env): Add declaration.
5271         * mi/mi-cmds.c (_initialize_mi_cmds): Add declaration.
5272         * mi/mi-interp.c (_initialize_mi_interp): Add declaration.
5273         * mi/mi-main.c (_initialize_mi_main): Add declaration.
5274         * microblaze-linux-tdep.c (_initialize_microblaze_linux_tdep): Add declaration.
5275         * microblaze-tdep.c (_initialize_microblaze_tdep): Add declaration.
5276         * mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Add declaration.
5277         * mips-fbsd-tdep.c (_initialize_mips_fbsd_tdep): Add declaration.
5278         * mips-linux-nat.c (_initialize_mips_linux_nat): Add declaration.
5279         * mips-linux-tdep.c (_initialize_mips_linux_tdep): Add declaration.
5280         * mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Add declaration.
5281         * mips-nbsd-tdep.c (_initialize_mipsnbsd_tdep): Add declaration.
5282         * mips-sde-tdep.c (_initialize_mips_sde_tdep): Add declaration.
5283         * mips-tdep.c (_initialize_mips_tdep): Add declaration.
5284         * mips64-obsd-nat.c (_initialize_mips64obsd_nat): Add declaration.
5285         * mips64-obsd-tdep.c (_initialize_mips64obsd_tdep): Add declaration.
5286         * mipsread.c (_initialize_mipsread): Add declaration.
5287         * mn10300-linux-tdep.c (_initialize_mn10300_linux_tdep): Add declaration.
5288         * mn10300-tdep.c (_initialize_mn10300_tdep): Add declaration.
5289         * moxie-tdep.c (_initialize_moxie_tdep): Add declaration.
5290         * msp430-tdep.c (_initialize_msp430_tdep): Add declaration.
5291         * nds32-tdep.c (_initialize_nds32_tdep): Add declaration.
5292         * nios2-linux-tdep.c (_initialize_nios2_linux_tdep): Add declaration.
5293         * nios2-tdep.c (_initialize_nios2_tdep): Add declaration.
5294         * nto-procfs.c (_initialize_procfs): Add declaration.
5295         * objc-lang.c (_initialize_objc_language): Add declaration.
5296         * observable.c (_initialize_observer): Add declaration.
5297         * opencl-lang.c (_initialize_opencl_language): Add declaration.
5298         * or1k-linux-tdep.c (_initialize_or1k_linux_tdep): Add declaration.
5299         * or1k-tdep.c (_initialize_or1k_tdep): Add declaration.
5300         * osabi.c (_initialize_gdb_osabi): Add declaration.
5301         * osdata.c (_initialize_osdata): Add declaration.
5302         * p-valprint.c (_initialize_pascal_valprint): Add declaration.
5303         * parse.c (_initialize_parse): Add declaration.
5304         * ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Add declaration.
5305         * ppc-fbsd-tdep.c (_initialize_ppcfbsd_tdep): Add declaration.
5306         * ppc-linux-nat.c (_initialize_ppc_linux_nat): Add declaration.
5307         * ppc-linux-tdep.c (_initialize_ppc_linux_tdep): Add declaration.
5308         * ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Add declaration.
5309         * ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Add declaration.
5310         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Add declaration.
5311         * ppc-obsd-tdep.c (_initialize_ppcobsd_tdep): Add declaration.
5312         * printcmd.c (_initialize_printcmd): Add declaration.
5313         * probe.c (_initialize_probe): Add declaration.
5314         * proc-api.c (_initialize_proc_api): Add declaration.
5315         * proc-events.c (_initialize_proc_events): Add declaration.
5316         * proc-service.c (_initialize_proc_service): Add declaration.
5317         * procfs.c (_initialize_procfs): Add declaration.
5318         * producer.c (_initialize_producer): Add declaration.
5319         * psymtab.c (_initialize_psymtab): Add declaration.
5320         * python/python.c (_initialize_python): Add declaration.
5321         * ravenscar-thread.c (_initialize_ravenscar): Add declaration.
5322         * record-btrace.c (_initialize_record_btrace): Add declaration.
5323         * record-full.c (_initialize_record_full): Add declaration.
5324         * record.c (_initialize_record): Add declaration.
5325         * regcache-dump.c (_initialize_regcache_dump): Add declaration.
5326         * regcache.c (_initialize_regcache): Add declaration.
5327         * reggroups.c (_initialize_reggroup): Add declaration.
5328         * remote-notif.c (_initialize_notif): Add declaration.
5329         * remote-sim.c (_initialize_remote_sim): Add declaration.
5330         * remote.c (_initialize_remote): Add declaration.
5331         * reverse.c (_initialize_reverse): Add declaration.
5332         * riscv-fbsd-nat.c (_initialize_riscv_fbsd_nat): Add declaration.
5333         * riscv-fbsd-tdep.c (_initialize_riscv_fbsd_tdep): Add declaration.
5334         * riscv-linux-nat.c (_initialize_riscv_linux_nat): Add declaration.
5335         * riscv-linux-tdep.c (_initialize_riscv_linux_tdep): Add declaration.
5336         * riscv-tdep.c (_initialize_riscv_tdep): Add declaration.
5337         * rl78-tdep.c (_initialize_rl78_tdep): Add declaration.
5338         * rs6000-aix-tdep.c (_initialize_rs6000_aix_tdep): Add declaration.
5339         * rs6000-lynx178-tdep.c (_initialize_rs6000_lynx178_tdep):
5340         Add declaration.
5341         * rs6000-nat.c (_initialize_rs6000_nat): Add declaration.
5342         * rs6000-tdep.c (_initialize_rs6000_tdep): Add declaration.
5343         * run-on-main-thread.c (_initialize_run_on_main_thread): Add declaration.
5344         * rust-exp.y (_initialize_rust_exp): Add declaration.
5345         * rx-tdep.c (_initialize_rx_tdep): Add declaration.
5346         * s12z-tdep.c (_initialize_s12z_tdep): Add declaration.
5347         * s390-linux-nat.c (_initialize_s390_nat): Add declaration.
5348         * s390-linux-tdep.c (_initialize_s390_linux_tdep): Add declaration.
5349         * s390-tdep.c (_initialize_s390_tdep): Add declaration.
5350         * score-tdep.c (_initialize_score_tdep): Add declaration.
5351         * ser-go32.c (_initialize_ser_dos): Add declaration.
5352         * ser-mingw.c (_initialize_ser_windows): Add declaration.
5353         * ser-pipe.c (_initialize_ser_pipe): Add declaration.
5354         * ser-tcp.c (_initialize_ser_tcp): Add declaration.
5355         * ser-uds.c (_initialize_ser_socket): Add declaration.
5356         * ser-unix.c (_initialize_ser_hardwire): Add declaration.
5357         * serial.c (_initialize_serial): Add declaration.
5358         * sh-linux-tdep.c (_initialize_sh_linux_tdep): Add declaration.
5359         * sh-nbsd-nat.c (_initialize_shnbsd_nat): Add declaration.
5360         * sh-nbsd-tdep.c (_initialize_shnbsd_tdep): Add declaration.
5361         * sh-tdep.c (_initialize_sh_tdep): Add declaration.
5362         * skip.c (_initialize_step_skip): Add declaration.
5363         * sol-thread.c (_initialize_sol_thread): Add declaration.
5364         * solib-aix.c (_initialize_solib_aix): Add declaration.
5365         * solib-darwin.c (_initialize_darwin_solib): Add declaration.
5366         * solib-dsbt.c (_initialize_dsbt_solib): Add declaration.
5367         * solib-frv.c (_initialize_frv_solib): Add declaration.
5368         * solib-svr4.c (_initialize_svr4_solib): Add declaration.
5369         * solib-target.c (_initialize_solib_target): Add declaration.
5370         * solib.c (_initialize_solib): Add declaration.
5371         * source-cache.c (_initialize_source_cache): Add declaration.
5372         * source.c (_initialize_source): Add declaration.
5373         * sparc-linux-nat.c (_initialize_sparc_linux_nat): Add declaration.
5374         * sparc-linux-tdep.c (_initialize_sparc_linux_tdep): Add declaration.
5375         * sparc-nat.c (_initialize_sparc_nat): Add declaration.
5376         * sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Add declaration.
5377         * sparc-nbsd-tdep.c (_initialize_sparcnbsd_tdep): Add declaration.
5378         * sparc-obsd-tdep.c (_initialize_sparc32obsd_tdep): Add declaration.
5379         * sparc-sol2-tdep.c (_initialize_sparc_sol2_tdep): Add declaration.
5380         * sparc-tdep.c (_initialize_sparc_tdep): Add declaration.
5381         * sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Add declaration.
5382         * sparc64-fbsd-tdep.c (_initialize_sparc64fbsd_tdep): Add declaration.
5383         * sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Add declaration.
5384         * sparc64-linux-tdep.c (_initialize_sparc64_linux_tdep): Add declaration.
5385         * sparc64-nat.c (_initialize_sparc64_nat): Add declaration.
5386         * sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Add declaration.
5387         * sparc64-nbsd-tdep.c (_initialize_sparc64nbsd_tdep): Add declaration.
5388         * sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Add declaration.
5389         * sparc64-obsd-tdep.c (_initialize_sparc64obsd_tdep): Add declaration.
5390         * sparc64-sol2-tdep.c (_initialize_sparc64_sol2_tdep): Add declaration.
5391         * sparc64-tdep.c (_initialize_sparc64_adi_tdep): Add declaration.
5392         * stabsread.c (_initialize_stabsread): Add declaration.
5393         * stack.c (_initialize_stack): Add declaration.
5394         * stap-probe.c (_initialize_stap_probe): Add declaration.
5395         * std-regs.c (_initialize_frame_reg): Add declaration.
5396         * symfile-debug.c (_initialize_symfile_debug): Add declaration.
5397         * symfile-mem.c (_initialize_symfile_mem): Add declaration.
5398         * symfile.c (_initialize_symfile): Add declaration.
5399         * symmisc.c (_initialize_symmisc): Add declaration.
5400         * symtab.c (_initialize_symtab): Add declaration.
5401         * target.c (_initialize_target): Add declaration.
5402         * target-connection.c (_initialize_target_connection): Add
5403         declaration.
5404         * target-dcache.c (_initialize_target_dcache): Add declaration.
5405         * target-descriptions.c (_initialize_target_descriptions): Add declaration.
5406         * thread.c (_initialize_thread): Add declaration.
5407         * tic6x-linux-tdep.c (_initialize_tic6x_linux_tdep): Add declaration.
5408         * tic6x-tdep.c (_initialize_tic6x_tdep): Add declaration.
5409         * tilegx-linux-nat.c (_initialize_tile_linux_nat): Add declaration.
5410         * tilegx-linux-tdep.c (_initialize_tilegx_linux_tdep): Add declaration.
5411         * tilegx-tdep.c (_initialize_tilegx_tdep): Add declaration.
5412         * tracectf.c (_initialize_ctf): Add declaration.
5413         * tracefile-tfile.c (_initialize_tracefile_tfile): Add declaration.
5414         * tracefile.c (_initialize_tracefile): Add declaration.
5415         * tracepoint.c (_initialize_tracepoint): Add declaration.
5416         * tui/tui-hooks.c (_initialize_tui_hooks): Add declaration.
5417         * tui/tui-interp.c (_initialize_tui_interp): Add declaration.
5418         * tui/tui-layout.c (_initialize_tui_layout): Add declaration.
5419         * tui/tui-regs.c (_initialize_tui_regs): Add declaration.
5420         * tui/tui-stack.c (_initialize_tui_stack): Add declaration.
5421         * tui/tui-win.c (_initialize_tui_win): Add declaration.
5422         * tui/tui.c (_initialize_tui): Add declaration.
5423         * typeprint.c (_initialize_typeprint): Add declaration.
5424         * ui-style.c (_initialize_ui_style): Add declaration.
5425         * unittests/array-view-selftests.c (_initialize_array_view_selftests): Add declaration.
5426         * unittests/child-path-selftests.c (_initialize_child_path_selftests): Add declaration.
5427         * unittests/cli-utils-selftests.c (_initialize_cli_utils_selftests): Add declaration.
5428         * unittests/common-utils-selftests.c (_initialize_common_utils_selftests): Add declaration.
5429         * unittests/copy_bitwise-selftests.c (_initialize_copy_bitwise_utils_selftests): Add declaration.
5430         * unittests/environ-selftests.c (_initialize_environ_selftests): Add declaration.
5431         * unittests/filtered_iterator-selftests.c
5432         (_initialize_filtered_iterator_selftests): Add declaration.
5433         * unittests/format_pieces-selftests.c (_initialize_format_pieces_selftests): Add declaration.
5434         * unittests/function-view-selftests.c (_initialize_function_view_selftests): Add declaration.
5435         * unittests/help-doc-selftests.c (_initialize_help_doc_selftests): Add declaration.
5436         * unittests/lookup_name_info-selftests.c (_initialize_lookup_name_info_selftests): Add declaration.
5437         * unittests/main-thread-selftests.c
5438         (_initialize_main_thread_selftests): Add declaration.
5439         * unittests/memory-map-selftests.c (_initialize_memory_map_selftests): Add declaration.
5440         * unittests/memrange-selftests.c (_initialize_memrange_selftests): Add declaration.
5441         * unittests/mkdir-recursive-selftests.c (_initialize_mkdir_recursive_selftests): Add declaration.
5442         * unittests/observable-selftests.c (_initialize_observer_selftest): Add declaration.
5443         * unittests/offset-type-selftests.c (_initialize_offset_type_selftests): Add declaration.
5444         * unittests/optional-selftests.c (_initialize_optional_selftests): Add declaration.
5445         * unittests/parse-connection-spec-selftests.c (_initialize_parse_connection_spec_selftests): Add declaration.
5446         * unittests/rsp-low-selftests.c (_initialize_rsp_low_selftests): Add declaration.
5447         * unittests/scoped_fd-selftests.c (_initialize_scoped_fd_selftests): Add declaration.
5448         * unittests/scoped_mmap-selftests.c (_initialize_scoped_mmap_selftests): Add declaration.
5449         * unittests/scoped_restore-selftests.c (_initialize_scoped_restore_selftests): Add declaration.
5450         * unittests/string_view-selftests.c (_initialize_string_view_selftests): Add declaration.
5451         * unittests/style-selftests.c (_initialize_style_selftest): Add declaration.
5452         * unittests/tracepoint-selftests.c (_initialize_tracepoint_selftests): Add declaration.
5453         * unittests/tui-selftests.c (_initialize_tui_selftest): Add
5454         declaration.
5455         * unittests/unpack-selftests.c (_initialize_unpack_selftests): Add declaration.
5456         * unittests/utils-selftests.c (_initialize_utils_selftests): Add declaration.
5457         * unittests/vec-utils-selftests.c (_initialize_vec_utils_selftests): Add declaration.
5458         * unittests/xml-utils-selftests.c (_initialize_xml_utils): Add declaration.
5459         * user-regs.c (_initialize_user_regs): Add declaration.
5460         * utils.c (_initialize_utils): Add declaration.
5461         * v850-tdep.c (_initialize_v850_tdep): Add declaration.
5462         * valops.c (_initialize_valops): Add declaration.
5463         * valprint.c (_initialize_valprint): Add declaration.
5464         * value.c (_initialize_values): Add declaration.
5465         * varobj.c (_initialize_varobj): Add declaration.
5466         * vax-bsd-nat.c (_initialize_vaxbsd_nat): Add declaration.
5467         * vax-nbsd-tdep.c (_initialize_vaxnbsd_tdep): Add declaration.
5468         * vax-tdep.c (_initialize_vax_tdep): Add declaration.
5469         * windows-nat.c (_initialize_windows_nat): Add declaration.
5470         (_initialize_check_for_gdb_ini): Add declaration.
5471         (_initialize_loadable): Add declaration.
5472         * windows-tdep.c (_initialize_windows_tdep): Add declaration.
5473         * x86-bsd-nat.c (_initialize_x86_bsd_nat): Add declaration.
5474         * x86-linux-nat.c (_initialize_x86_linux_nat): Add declaration.
5475         * xcoffread.c (_initialize_xcoffread): Add declaration.
5476         * xml-support.c (_initialize_xml_support): Add declaration.
5477         * xstormy16-tdep.c (_initialize_xstormy16_tdep): Add declaration.
5478         * xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Add declaration.
5479         * xtensa-linux-tdep.c (_initialize_xtensa_linux_tdep): Add declaration.
5480         * xtensa-tdep.c (_initialize_xtensa_tdep): Add declaration.
5481
5482 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
5483
5484         * regformats/regdat.sh: Generate declaration for init function.
5485
5486 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
5487
5488         * remote-sim.c (next_pid, INITIAL_PID, sim_inferior_data): Move
5489         up.
5490         (gdbsim_target) <get_inferior_data_by_ptid, resume_one_inferior,
5491         close_one_inferior>: New methods.
5492         (get_sim_inferior_data_by_ptid): Move to gdbsim_target,
5493         pass down target to find_inferior_pid.
5494         (gdbsim_target::fetch_registers, gdbsim_target::store_registers):
5495         Pass down target to find_inferior_ptid.
5496         (gdbsim_target::create_inferior): Pass down target to
5497         add_thread_silent.
5498         (gdbsim_close_inferior): Move to gdbsim_close_inferior, pass
5499         target down to find_inferior_ptid and switch_to_thread.
5500         (gdbsim_target::close): Update to call close_one_inferior.
5501         (struct resume_data): Remove.
5502         (gdbsim_resume_inferior): Move to gdbsim_target.  Take arguments
5503         directly, rather than through a void pointer.
5504         (gdbsim_target::resume): Update to call resume_one_inferior.
5505
5506 2020-01-12  Simon Marchi  <simon.marchi@polymtl.ca>
5507
5508         * gdbsupport/gdb_wait.c: Include gdb_wait.h.
5509
5510 2020-01-12  Pedro Alves  <palves@redhat.com>
5511
5512         * bsd-kvm.c (bsd_kvm_target::close): Call exit_inferior_silent
5513         directly for the current inferior instead of
5514         discard_all_inferiors.
5515         (discard_all_inferiors): Delete.
5516
5517 2020-01-11  Tom Tromey  <tom@tromey.com>
5518
5519         * tui/tui-wingeneral.c (box_win): Check cli_styling.
5520         * tui/tui-winsource.c (tui_source_window_base::refill): Use
5521         deprecated_safe_get_selected_frame.
5522
5523 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
5524
5525         * inferior.c (print_inferior): Switch inferior before printing it.
5526
5527 2020-01-10  Aleksandar Paunovic  <aleksandar.paunovic@intel.com>
5528             Pedro Alves  <palves@redhat.com>
5529
5530         * progspace-and-thread.c (switch_to_program_space_and_thread):
5531         Assert there's an inferior for PSPACE.  Use
5532         switch_to_inferior_no_thread to switch the inferior too.
5533         * progspace.c (program_space::~program_space): Call
5534         clear_symtab_users here, with SYMFILE_DEFER_BP_RESET.
5535         (program_space::free_all_objfiles): Don't call clear_symtab_users
5536         here.
5537         * symfile.c (symbol_file_clear): Call clear_symtab_users here.
5538
5539 2020-01-10  Pedro Alves  <palves@redhat.com>
5540
5541         * NEWS: Mention multi-target debugging, "info connections", and
5542         "add-inferior -no-connection".
5543
5544 2020-01-10  Pedro Alves  <palves@redhat.com>
5545
5546         * infrun.c: Include "target-connection.h".
5547         (check_multi_target_resumption): New.
5548         (proceed): Call it.
5549         * target-connection.c (make_target_connection_string): Make
5550         extern.
5551         * target-connection.h (make_target_connection_string): Declare.
5552
5553 2020-01-10  Pedro Alves  <palves@redhat.com>
5554
5555         * Makefile.in (COMMON_SFILES): Add target-connection.c.
5556         * inferior.c (uiout_field_connection): New function.
5557         (print_inferior): Add new "connection-id" column.
5558         (add_inferior_command): Show connection number/string of added
5559         inferior.
5560         * process-stratum-target.h
5561         (process_stratum_target::connection_string): New virtual method.
5562         (process_stratum_target::connection_number): New field.
5563         * remote.c (remote_target::connection_string): New override.
5564         * target-connection.c: New file.
5565         * target-connection.h: New file.
5566         * target.c (decref_target): Remove process_stratum targets from
5567         the connection list.
5568         (target_stack::push): Add process_stratum targets to the
5569         connection list.
5570
5571 2020-01-10  Pedro Alves  <palves@redhat.com>
5572
5573         Revert:
5574         2016-04-12  Pedro Alves  <palves@redhat.com>
5575         * serial.c (serial_open, serial_fdopen_ops, do_serial_close):
5576         Remove references to name.
5577         * serial.h (struct serial) <name>: Delete.
5578
5579 2020-01-10  Pedro Alves  <palves@redhat.com>
5580
5581         * gdbarch-selftests.c (register_to_value_test): Remove "target
5582         already pushed" check.
5583
5584 2020-01-10  Pedro Alves  <palves@redhat.com>
5585             John Baldwin  <jhb@FreeBSD.org>
5586
5587         * aarch64-linux-nat.c
5588         (aarch64_linux_nat_target::thread_architecture): Adjust.
5589         * ada-tasks.c (print_ada_task_info): Adjust find_thread_ptid call.
5590         (task_command_1): Likewise.
5591         * aix-thread.c (sync_threadlists, aix_thread_target::resume)
5592         (aix_thread_target::wait, aix_thread_target::fetch_registers)
5593         (aix_thread_target::store_registers)
5594         (aix_thread_target::thread_alive): Adjust.
5595         * amd64-fbsd-tdep.c: Include "inferior.h".
5596         (amd64fbsd_get_thread_local_address): Pass down target.
5597         * amd64-linux-nat.c (ps_get_thread_area): Use ps_prochandle
5598         thread's gdbarch instead of target_gdbarch.
5599         * break-catch-sig.c (signal_catchpoint_print_it): Adjust call to
5600         get_last_target_status.
5601         * break-catch-syscall.c (print_it_catch_syscall): Likewise.
5602         * breakpoint.c (breakpoints_should_be_inserted_now): Consider all
5603         inferiors.
5604         (update_inserted_breakpoint_locations): Skip if inferiors with no
5605         execution.
5606         (update_global_location_list): When handling moribund locations,
5607         find representative inferior for location's pspace, and use thread
5608         count of its process_stratum target.
5609         * bsd-kvm.c (bsd_kvm_target_open): Pass target down.
5610         * bsd-uthread.c (bsd_uthread_target::wait): Use
5611         as_process_stratum_target and adjust thread_change_ptid and
5612         add_thread calls.
5613         (bsd_uthread_target::update_thread_list): Use
5614         as_process_stratum_target and adjust find_thread_ptid,
5615         thread_change_ptid and add_thread calls.
5616         * btrace.c (maint_btrace_packet_history_cmd): Adjust
5617         find_thread_ptid call.
5618         * corelow.c (add_to_thread_list): Adjust add_thread call.
5619         (core_target_open): Adjust add_thread_silent and thread_count
5620         calls.
5621         (core_target::pid_to_str): Adjust find_inferior_ptid call.
5622         * ctf.c (ctf_target_open): Adjust add_thread_silent call.
5623         * event-top.c (async_disconnect): Pop targets from all inferiors.
5624         * exec.c (add_target_sections): Push exec target on all inferiors
5625         sharing the program space.
5626         (remove_target_sections): Remove the exec target from all
5627         inferiors sharing the program space.
5628         (exec_on_vfork): New.
5629         * exec.h (exec_on_vfork): Declare.
5630         * fbsd-nat.c (fbsd_add_threads): Add fbsd_nat_target parameter.
5631         Pass it down.
5632         (fbsd_nat_target::update_thread_list): Adjust.
5633         (fbsd_nat_target::resume): Adjust.
5634         (fbsd_handle_debug_trap): Add fbsd_nat_target parameter.  Pass it
5635         down.
5636         (fbsd_nat_target::wait, fbsd_nat_target::post_attach): Adjust.
5637         * fbsd-tdep.c (fbsd_corefile_thread): Adjust
5638         get_thread_arch_regcache call.
5639         * fork-child.c (gdb_startup_inferior): Pass target down to
5640         startup_inferior and set_executing.
5641         * gdbthread.h (struct process_stratum_target): Forward declare.
5642         (add_thread, add_thread_silent, add_thread_with_info)
5643         (in_thread_list): Add process_stratum_target parameter.
5644         (find_thread_ptid(inferior*, ptid_t)): New overload.
5645         (find_thread_ptid, thread_change_ptid): Add process_stratum_target
5646         parameter.
5647         (all_threads()): Delete overload.
5648         (all_threads, all_non_exited_threads): Add process_stratum_target
5649         parameter.
5650         (all_threads_safe): Use brace initialization.
5651         (thread_count): Add process_stratum_target parameter.
5652         (set_resumed, set_running, set_stop_requested, set_executing)
5653         (threads_are_executing, finish_thread_state): Add
5654         process_stratum_target parameter.
5655         (switch_to_thread): Use is_current_thread.
5656         * i386-fbsd-tdep.c: Include "inferior.h".
5657         (i386fbsd_get_thread_local_address): Pass down target.
5658         * i386-linux-nat.c (i386_linux_nat_target::low_resume): Adjust.
5659         * inf-child.c (inf_child_target::maybe_unpush_target): Remove
5660         have_inferiors check.
5661         * inf-ptrace.c (inf_ptrace_target::create_inferior)
5662         (inf_ptrace_target::attach): Adjust.
5663         * infcall.c (run_inferior_call): Adjust.
5664         * infcmd.c (run_command_1): Pass target to
5665         scoped_finish_thread_state.
5666         (proceed_thread_callback): Skip inferiors with no execution.
5667         (continue_command): Rename 'all_threads' local to avoid hiding
5668         'all_threads' function.  Adjust get_last_target_status call.
5669         (prepare_one_step): Adjust set_running call.
5670         (signal_command): Use user_visible_resume_target.  Compare thread
5671         pointers instead of inferior_ptid.
5672         (info_program_command): Adjust to pass down target.
5673         (attach_command): Mark target's 'thread_executing' flag.
5674         (stop_current_target_threads_ns): New, factored out from ...
5675         (interrupt_target_1): ... this.  Switch inferior before making
5676         target calls.
5677         * inferior-iter.h
5678         (struct all_inferiors_iterator, struct all_inferiors_range)
5679         (struct all_inferiors_safe_range)
5680         (struct all_non_exited_inferiors_range): Filter on
5681         process_stratum_target too.  Remove explicit.
5682         * inferior.c (inferior::inferior): Push dummy target on target
5683         stack.
5684         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors):
5685         Add process_stratum_target parameter, and pass it down.
5686         (have_live_inferiors): Adjust.
5687         (switch_to_inferior_and_push_target): New.
5688         (add_inferior_command, clone_inferior_command): Handle
5689         "-no-connection" parameter.  Use
5690         switch_to_inferior_and_push_target.
5691         (_initialize_inferior): Mention "-no-connection" option in
5692         the help of "add-inferior" and "clone-inferior" commands.
5693         * inferior.h: Include "process-stratum-target.h".
5694         (interrupt_target_1): Use bool.
5695         (struct inferior) <push_target, unpush_target, target_is_pushed,
5696         find_target_beneath, top_target, process_target, target_at,
5697         m_stack>: New.
5698         (discard_all_inferiors): Delete.
5699         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors)
5700         (all_inferiors, all_non_exited_inferiors): Add
5701         process_stratum_target parameter.
5702         * infrun.c: Include "gdb_select.h" and <unordered_map>.
5703         (target_last_proc_target): New global.
5704         (follow_fork_inferior): Push target on new inferior.  Pass target
5705         to add_thread_silent.  Call exec_on_vfork.  Handle target's
5706         reference count.
5707         (follow_fork): Adjust get_last_target_status call.  Also consider
5708         target.
5709         (follow_exec): Push target on new inferior.
5710         (struct execution_control_state) <target>: New field.
5711         (user_visible_resume_target): New.
5712         (do_target_resume): Call target_async.
5713         (resume_1): Set target's threads_executing flag.  Consider resume
5714         target.
5715         (commit_resume_all_targets): New.
5716         (proceed): Also consider resume target.  Skip threads of inferiors
5717         with no execution.  Commit resumtion in all targets.
5718         (start_remote): Pass current inferior to wait_for_inferior.
5719         (infrun_thread_stop_requested): Consider target as well.  Pass
5720         thread_info pointer to clear_inline_frame_state instead of ptid.
5721         (infrun_thread_thread_exit): Consider target as well.
5722         (random_pending_event_thread): New inferior parameter.  Use it.
5723         (do_target_wait): Rename to ...
5724         (do_target_wait_1): ... this.  Add inferior parameter, and pass it
5725         down.
5726         (threads_are_resumed_pending_p, do_target_wait): New.
5727         (prepare_for_detach): Adjust calls.
5728         (wait_for_inferior): New inferior parameter.  Handle it.  Use
5729         do_target_wait_1 instead of do_target_wait.
5730         (fetch_inferior_event): Adjust.  Switch to representative
5731         inferior.  Pass target down.
5732         (set_last_target_status): Add process_stratum_target parameter.
5733         Save target in global.
5734         (get_last_target_status): Add process_stratum_target parameter and
5735         handle it.
5736         (nullify_last_target_wait_ptid): Clear 'target_last_proc_target'.
5737         (context_switch): Check inferior_ptid == null_ptid before calling
5738         inferior_thread().
5739         (get_inferior_stop_soon): Pass down target.
5740         (wait_one): Rename to ...
5741         (poll_one_curr_target): ... this.
5742         (struct wait_one_event): New.
5743         (wait_one): New.
5744         (stop_all_threads): Adjust.
5745         (handle_no_resumed, handle_inferior_event): Adjust to consider the
5746         event's target.
5747         (switch_back_to_stepped_thread): Also consider target.
5748         (print_stop_event): Update.
5749         (normal_stop): Update.  Also consider the resume target.
5750         * infrun.h (wait_for_inferior): Remove declaration.
5751         (user_visible_resume_target): New declaration.
5752         (get_last_target_status, set_last_target_status): New
5753         process_stratum_target parameter.
5754         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
5755         process_stratum_target parameter, and use it.
5756         (clear_inline_frame_state (thread_info*)): New.
5757         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
5758         process_stratum_target parameter.
5759         (clear_inline_frame_state (thread_info*)): Declare.
5760         * linux-fork.c (delete_checkpoint_command): Pass target down to
5761         find_thread_ptid.
5762         (checkpoint_command): Adjust.
5763         * linux-nat.c (linux_nat_target::follow_fork): Switch to thread
5764         instead of just tweaking inferior_ptid.
5765         (linux_nat_switch_fork): Pass target down to thread_change_ptid.
5766         (exit_lwp): Pass target down to find_thread_ptid.
5767         (attach_proc_task_lwp_callback): Pass target down to
5768         add_thread/set_running/set_executing.
5769         (linux_nat_target::attach): Pass target down to
5770         thread_change_ptid.
5771         (get_detach_signal): Pass target down to find_thread_ptid.
5772         Consider last target status's target.
5773         (linux_resume_one_lwp_throw, resume_lwp)
5774         (linux_handle_syscall_trap, linux_handle_extended_wait, wait_lwp)
5775         (stop_wait_callback, save_stop_reason, linux_nat_filter_event)
5776         (linux_nat_wait_1, resume_stopped_resumed_lwps): Pass target down.
5777         (linux_nat_target::async_wait_fd): New.
5778         (linux_nat_stop_lwp, linux_nat_target::thread_address_space): Pass
5779         target down.
5780         * linux-nat.h (linux_nat_target::async_wait_fd): Declare.
5781         * linux-tdep.c (get_thread_arch_regcache): Pass target down.
5782         * linux-thread-db.c (struct thread_db_info::process_target): New
5783         field.
5784         (add_thread_db_info): Save target.
5785         (get_thread_db_info): New process_stratum_target parameter.  Also
5786         match target.
5787         (delete_thread_db_info): New process_stratum_target parameter.
5788         Also match target.
5789         (thread_from_lwp): Adjust to pass down target.
5790         (thread_db_notice_clone): Pass down target.
5791         (check_thread_db_callback): Pass down target.
5792         (try_thread_db_load_1): Always push the thread_db target.
5793         (try_thread_db_load, record_thread): Pass target down.
5794         (thread_db_target::detach): Pass target down.  Always unpush the
5795         thread_db target.
5796         (thread_db_target::wait, thread_db_target::mourn_inferior): Pass
5797         target down.  Always unpush the thread_db target.
5798         (find_new_threads_callback, thread_db_find_new_threads_2)
5799         (thread_db_target::update_thread_list): Pass target down.
5800         (thread_db_target::pid_to_str): Pass current inferior down.
5801         (thread_db_target::get_thread_local_address): Pass target down.
5802         (thread_db_target::resume, maintenance_check_libthread_db): Pass
5803         target down.
5804         * nto-procfs.c (nto_procfs_target::update_thread_list): Adjust.
5805         * procfs.c (procfs_target::procfs_init_inferior): Declare.
5806         (proc_set_current_signal, do_attach, procfs_target::wait): Adjust.
5807         (procfs_init_inferior): Rename to ...
5808         (procfs_target::procfs_init_inferior): ... this and adjust.
5809         (procfs_target::create_inferior, procfs_notice_thread)
5810         (procfs_do_thread_registers): Adjust.
5811         * ppc-fbsd-tdep.c: Include "inferior.h".
5812         (ppcfbsd_get_thread_local_address): Pass down target.
5813         * proc-service.c (ps_xfer_memory): Switch current inferior and
5814         program space as well.
5815         (get_ps_regcache): Pass target down.
5816         * process-stratum-target.c
5817         (process_stratum_target::thread_address_space)
5818         (process_stratum_target::thread_architecture): Pass target down.
5819         * process-stratum-target.h
5820         (process_stratum_target::threads_executing): New field.
5821         (as_process_stratum_target): New.
5822         * ravenscar-thread.c
5823         (ravenscar_thread_target::update_inferior_ptid): Pass target down.
5824         (ravenscar_thread_target::wait, ravenscar_add_thread): Pass target
5825         down.
5826         * record-btrace.c (record_btrace_target::info_record): Adjust.
5827         (record_btrace_target::record_method)
5828         (record_btrace_target::record_is_replaying)
5829         (record_btrace_target::fetch_registers)
5830         (get_thread_current_frame_id, record_btrace_target::resume)
5831         (record_btrace_target::wait, record_btrace_target::stop): Pass
5832         target down.
5833         * record-full.c (record_full_wait_1): Switch to event thread.
5834         Pass target down.
5835         * regcache.c (regcache::regcache)
5836         (get_thread_arch_aspace_regcache, get_thread_arch_regcache): Add
5837         process_stratum_target parameter and handle it.
5838         (current_thread_target): New global.
5839         (get_thread_regcache): Add process_stratum_target parameter and
5840         handle it.  Switch inferior before calling target method.
5841         (get_thread_regcache): Pass target down.
5842         (get_thread_regcache_for_ptid): Pass target down.
5843         (registers_changed_ptid): Add process_stratum_target parameter and
5844         handle it.
5845         (registers_changed_thread, registers_changed): Pass target down.
5846         (test_get_thread_arch_aspace_regcache): New.
5847         (current_regcache_test): Define a couple local test_target_ops
5848         instances and use them for testing.
5849         (readwrite_regcache): Pass process_stratum_target parameter.
5850         (cooked_read_test, cooked_write_test): Pass mock_target down.
5851         * regcache.h (get_thread_regcache, get_thread_arch_regcache)
5852         (get_thread_arch_aspace_regcache): Add process_stratum_target
5853         parameter.
5854         (regcache::target): New method.
5855         (regcache::regcache, regcache::get_thread_arch_aspace_regcache)
5856         (regcache::registers_changed_ptid): Add process_stratum_target
5857         parameter.
5858         (regcache::m_target): New field.
5859         (registers_changed_ptid): Add process_stratum_target parameter.
5860         * remote.c (remote_state::supports_vCont_probed): New field.
5861         (remote_target::async_wait_fd): New method.
5862         (remote_unpush_and_throw): Add remote_target parameter.
5863         (get_current_remote_target): Adjust.
5864         (remote_target::remote_add_inferior): Push target.
5865         (remote_target::remote_add_thread)
5866         (remote_target::remote_notice_new_inferior)
5867         (get_remote_thread_info): Pass target down.
5868         (remote_target::update_thread_list): Skip threads of inferiors
5869         bound to other targets.  (remote_target::close): Don't discard
5870         inferiors.  (remote_target::add_current_inferior_and_thread)
5871         (remote_target::process_initial_stop_replies)
5872         (remote_target::start_remote)
5873         (remote_target::remote_serial_quit_handler): Pass down target.
5874         (remote_target::remote_unpush_target): New remote_target
5875         parameter.  Unpush the target from all inferiors.
5876         (remote_target::remote_unpush_and_throw): New remote_target
5877         parameter.  Pass it down.
5878         (remote_target::open_1): Check whether the current inferior has
5879         execution instead of checking whether any inferior is live.  Pass
5880         target down.
5881         (remote_target::remote_detach_1): Pass down target.  Use
5882         remote_unpush_target.
5883         (extended_remote_target::attach): Pass down target.
5884         (remote_target::remote_vcont_probe): Set supports_vCont_probed.
5885         (remote_target::append_resumption): Pass down target.
5886         (remote_target::append_pending_thread_resumptions)
5887         (remote_target::remote_resume_with_hc, remote_target::resume)
5888         (remote_target::commit_resume): Pass down target.
5889         (remote_target::remote_stop_ns): Check supports_vCont_probed.
5890         (remote_target::interrupt_query)
5891         (remote_target::remove_new_fork_children)
5892         (remote_target::check_pending_events_prevent_wildcard_vcont)
5893         (remote_target::remote_parse_stop_reply)
5894         (remote_target::process_stop_reply): Pass down target.
5895         (first_remote_resumed_thread): New remote_target parameter.  Pass
5896         it down.
5897         (remote_target::wait_as): Pass down target.
5898         (unpush_and_perror): New remote_target parameter.  Pass it down.
5899         (remote_target::readchar, remote_target::remote_serial_write)
5900         (remote_target::getpkt_or_notif_sane_1)
5901         (remote_target::kill_new_fork_children, remote_target::kill): Pass
5902         down target.
5903         (remote_target::mourn_inferior): Pass down target.  Use
5904         remote_unpush_target.
5905         (remote_target::core_of_thread)
5906         (remote_target::remote_btrace_maybe_reopen): Pass down target.
5907         (remote_target::pid_to_exec_file)
5908         (remote_target::thread_handle_to_thread_info): Pass down target.
5909         (remote_target::async_wait_fd): New.
5910         * riscv-fbsd-tdep.c: Include "inferior.h".
5911         (riscv_fbsd_get_thread_local_address): Pass down target.
5912         * sol2-tdep.c (sol2_core_pid_to_str): Pass down target.
5913         * sol-thread.c (sol_thread_target::wait, ps_lgetregs, ps_lsetregs)
5914         (ps_lgetfpregs, ps_lsetfpregs, sol_update_thread_list_callback):
5915         Adjust.
5916         * solib-spu.c (spu_skip_standalone_loader): Pass down target.
5917         * solib-svr4.c (enable_break): Pass down target.
5918         * spu-multiarch.c (parse_spufs_run): Pass down target.
5919         * spu-tdep.c (spu2ppu_sniffer): Pass down target.
5920         * target-delegates.c: Regenerate.
5921         * target.c (g_target_stack): Delete.
5922         (current_top_target): Return the current inferior's top target.
5923         (target_has_execution_1): Refer to the passed-in inferior's top
5924         target.
5925         (target_supports_terminal_ours): Check whether the initial
5926         inferior was already created.
5927         (decref_target): New.
5928         (target_stack::push): Incref/decref the target.
5929         (push_target, push_target, unpush_target): Adjust.
5930         (target_stack::unpush): Defref target.
5931         (target_is_pushed): Return bool.  Adjust to refer to the current
5932         inferior's target stack.
5933         (dispose_inferior): Delete, and inline parts ...
5934         (target_preopen): ... here.  Only dispose of the current inferior.
5935         (target_detach): Hold strong target reference while detaching.
5936         Pass target down.
5937         (target_thread_name): Add assertion.
5938         (target_resume): Pass down target.
5939         (target_ops::beneath, find_target_at): Adjust to refer to the
5940         current inferior's target stack.
5941         (get_dummy_target): New.
5942         (target_pass_ctrlc): Pass the Ctrl-C to the first inferior that
5943         has a thread running.
5944         (initialize_targets): Rename to ...
5945         (_initialize_target): ... this.
5946         * target.h: Include "gdbsupport/refcounted-object.h".
5947         (struct target_ops): Inherit refcounted_object.
5948         (target_ops::shortname, target_ops::longname): Make const.
5949         (target_ops::async_wait_fd): New method.
5950         (decref_target): Declare.
5951         (struct target_ops_ref_policy): New.
5952         (target_ops_ref): New typedef.
5953         (get_dummy_target): Declare function.
5954         (target_is_pushed): Return bool.
5955         * thread-iter.c (all_matching_threads_iterator::m_inf_matches)
5956         (all_matching_threads_iterator::all_matching_threads_iterator):
5957         Handle filter target.
5958         * thread-iter.h (struct all_matching_threads_iterator, struct
5959         all_matching_threads_range, class all_non_exited_threads_range):
5960         Filter by target too.  Remove explicit.
5961         * thread.c (threads_executing): Delete.
5962         (inferior_thread): Pass down current inferior.
5963         (clear_thread_inferior_resources): Pass down thread pointer
5964         instead of ptid_t.
5965         (add_thread_silent, add_thread_with_info, add_thread): Add
5966         process_stratum_target parameter.  Use it for thread and inferior
5967         searches.
5968         (is_current_thread): New.
5969         (thread_info::deletable): Use it.
5970         (find_thread_ptid, thread_count, in_thread_list)
5971         (thread_change_ptid, set_resumed, set_running): New
5972         process_stratum_target parameter.  Pass it down.
5973         (set_executing): New process_stratum_target parameter.  Pass it
5974         down.  Adjust reference to 'threads_executing'.
5975         (threads_are_executing): New process_stratum_target parameter.
5976         Adjust reference to 'threads_executing'.
5977         (set_stop_requested, finish_thread_state): New
5978         process_stratum_target parameter.  Pass it down.
5979         (switch_to_thread): Also match inferior.
5980         (switch_to_thread): New process_stratum_target parameter.  Pass it
5981         down.
5982         (update_threads_executing): Reimplement.
5983         * top.c (quit_force): Pop targets from all inferior.
5984         (gdb_init): Don't call initialize_targets.
5985         * windows-nat.c (windows_nat_target) <get_windows_debug_event>:
5986         Declare.
5987         (windows_add_thread, windows_delete_thread): Adjust.
5988         (get_windows_debug_event): Rename to ...
5989         (windows_nat_target::get_windows_debug_event): ... this.  Adjust.
5990         * tracefile-tfile.c (tfile_target_open): Pass down target.
5991         * gdbsupport/common-gdbthread.h (struct process_stratum_target):
5992         Forward declare.
5993         (switch_to_thread): Add process_stratum_target parameter.
5994         * mi/mi-interp.c (mi_on_resume_1): Add process_stratum_target
5995         parameter.  Use it.
5996         (mi_on_resume): Pass target down.
5997         * nat/fork-inferior.c (startup_inferior): Add
5998         process_stratum_target parameter.  Pass it down.
5999         * nat/fork-inferior.h (startup_inferior): Add
6000         process_stratum_target parameter.
6001         * python/py-threadevent.c (py_get_event_thread): Pass target down.
6002
6003 2020-01-10  Pedro Alves  <palves@redhat.com>
6004
6005         * remote.c (remote_target::start_remote): Don't set inferior_ptid
6006         directly.  Instead find the first thread in the thread list and
6007         use switch_to_thread.
6008
6009 2020-01-10  Pedro Alves  <palves@redhat.com>
6010
6011         * remote.c (remote_target::remote_add_inferior): Don't bind a
6012         process to the current inferior if the current inferior is already
6013         bound to a process.
6014
6015 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
6016             Pedro Alves  <palves@redhat.com>
6017
6018         * remote.c (remote_target::remote_parse_stop_reply) <W/X packets>:
6019         If no process is specified, return null_ptid instead of
6020         inferior_ptid.
6021         (remote_target::wait_as): Handle TARGET_WAITKIND_EXITED /
6022         TARGET_WAITKIND_SIGNALLED with no pid.
6023
6024 2020-01-10  Pedro Alves  <palves@redhat.com>
6025
6026         * remote.c (first_remote_resumed_thread): New.
6027         (remote_target::wait_as): Use it as default event_ptid instead of
6028         inferior_ptid.
6029
6030 2020-01-10  Pedro Alves  <palves@redhat.com>
6031
6032         * infrun.c (handle_no_resumed): Use all_non_exited_inferiors.
6033
6034 2020-01-10  Pedro Alves  <palves@redhat.com>
6035
6036         * tracefile-tfile.c (tfile_target::close): Assert that trace_fd is
6037         not -1.
6038
6039 2020-01-10  Pedro Alves  <palves@redhat.com>
6040
6041         * break-catch-sig.c (signal_catchpoint_print_it): Don't pass a
6042         ptid to get_last_target_status.
6043         * break-catch-syscall.c (print_it_catch_syscall): Don't pass a
6044         ptid to get_last_target_status.
6045         * infcmd.c (continue_command): Don't pass a target_waitstatus to
6046         get_last_target_status.
6047         (info_program_command): Don't pass a target_waitstatus to
6048         get_last_target_status.
6049         * infrun.c (init_wait_for_inferior): Use
6050         nullify_last_target_wait_ptid.
6051         (get_last_target_status): Handle nullptr arguments.
6052         (nullify_last_target_wait_ptid): Clear target_last_waitstatus.
6053         (print_stop_event): Don't pass a ptid to get_last_target_status.
6054         (normal_stop): Don't pass a ptid to get_last_target_status.
6055         * infrun.h (get_last_target_status, set_last_target_status): Move
6056         comments here and update.
6057         (nullify_last_target_wait_ptid): Declare.
6058         * linux-fork.c (fork_load_infrun_state): Remove local extern
6059         declaration of nullify_last_target_wait_ptid.
6060         * linux-nat.c (get_detach_signal): Don't pass a target_waitstatus
6061         to get_last_target_status.
6062
6063 2020-01-10  Pedro Alves  <palves@redhat.com>
6064
6065         * gdbthread.h (scoped_restore_current_thread)
6066         <dont_restore, restore, m_dont_restore>: Declare.
6067         * thread.c (thread_alive): Add assertion.  Return bool.
6068         (switch_to_thread_if_alive): New.
6069         (prune_threads): Switch inferior/thread.
6070         (print_thread_info_1): Switch thread before calling target methods.
6071         (scoped_restore_current_thread::restore): New, factored out from
6072         ...
6073         (scoped_restore_current_thread::~scoped_restore_current_thread):
6074         ... this.
6075         (scoped_restore_current_thread::scoped_restore_current_thread):
6076         Add assertion.
6077         (thread_apply_all_command, thread_select): Use
6078         switch_to_thread_if_alive.
6079         * infrun.c (proceed, restart_threads, handle_signal_stop)
6080         (switch_back_to_stepped_thread): Switch current thread before
6081         calling target methods.
6082
6083 2020-01-10  Pedro Alves <palves@redhat.com>
6084
6085         * inferior.c (switch_to_inferior_no_thread): New function,
6086         factored out from ...
6087         (inferior_command): ... here.
6088         * inferior.h (switch_to_inferior_no_thread): Declare.
6089         * mi/mi-main.c (run_one_inferior): Use
6090         switch_to_inferior_no_thread.
6091
6092 2020-01-10  Pedro Alves  <palves@redhat.com>
6093
6094         * infcmd.c (kill_command): Remove dead code.
6095
6096 2020-01-10  Pedro Alves  <palves@redhat.com>
6097
6098         * remote.c (remote_target::mourn_inferior): No longer check
6099         whether the target is running.
6100
6101 2020-01-10  Pedro Alves  <palves@redhat.com>
6102
6103         * corelow.c (core_target::has_execution): Change parameter type to
6104         inferior pointer.
6105         * inferior.c (number_of_live_inferiors): Use
6106         inferior::has_execution instead of target_has_execution_1.
6107         * inferior.h (inferior::has_execution): New.
6108         * linux-thread-db.c (thread_db_target::update_thread_list): Use
6109         inferior::has_execution instead of target_has_execution_1.
6110         * process-stratum-target.c
6111         (process_stratum_target::has_execution): Change parameter type to
6112         inferior pointer.  Check the inferior's PID instead of
6113         inferior_ptid.
6114         * process-stratum-target.h
6115         (process_stratum_target::has_execution): Change parameter type to
6116         inferior pointer.
6117         * record-full.c (record_full_core_target::has_execution): Change
6118         parameter type to inferior pointer.
6119         * target.c (target_has_execution_1): Change parameter type to
6120         inferior pointer.
6121         (target_has_execution_current): Adjust.
6122         * target.h (target_ops::has_execution): Change parameter type to
6123         inferior pointer.
6124         (target_has_execution_1): Change parameter type to inferior
6125         pointer.  Change return type to bool.
6126         * tracefile.h (tracefile_target::has_execution): Change parameter
6127         type to inferior pointer.
6128
6129 2020-01-10  Pedro Alves  <palves@redhat.com>
6130
6131         * exceptions.c (print_flush): Remove current_top_target() check.
6132
6133 2020-01-10  Pedro Alves  <palves@redhat.com>
6134
6135         * remote.c (show_remote_exec_file): Show the current inferior's
6136         exec-file instead of the command variable's value.
6137
6138 2020-01-10  Pedro Alves  <palves@redhat.com>
6139
6140         * record-full.c (record_full_resume_ptid): New global.
6141         (record_full_target::resume): Set it.
6142         (record_full_wait_1): Use record_full_resume_ptid instead of
6143         inferior_ptid.
6144
6145 2020-01-10  Pedro Alves  <palves@redhat.com>
6146
6147         * gdbthread.h (scoped_restore_current_thread)
6148         <dont_restore, restore, m_dont_restore>: Declare.
6149         * thread.c (thread_alive): Add assertion.  Return bool.
6150         (switch_to_thread_if_alive): New.
6151         (prune_threads): Switch inferior/thread.
6152         (print_thread_info_1): Switch thread before calling target methods.
6153         (scoped_restore_current_thread::restore): New, factored out from
6154         ...
6155         (scoped_restore_current_thread::~scoped_restore_current_thread):
6156         ... this.
6157         (scoped_restore_current_thread::scoped_restore_current_thread):
6158         Add assertion.
6159         (thread_apply_all_command, thread_select): Use
6160         switch_to_thread_if_alive.
6161
6162 2020-01-10  George Barrett  <bob@bob131.so>
6163
6164         * stap-probe.c (stap_modify_semaphore): Don't check for null
6165         semaphores.
6166         (stap_probe::set_semaphore, stap_probe::clear_semaphore): Check
6167         for null semaphores.
6168
6169 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6170
6171         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Update
6172         all source windows, and maintain horizontal scroll status while
6173         doing so.
6174
6175 2020-01-09  Tom Tromey  <tom@tromey.com>
6176
6177         PR tui/18932:
6178         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Call
6179         update_source_window, not print_source_lines.
6180
6181 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6182
6183         * tui/tui.c (tui_enable): Register tui hooks after calling
6184         tui_display_main.
6185
6186 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
6187
6188         * gdbsupport/common-defs.h: Don't define _FORTIFY_SOURCE on MinGW.
6189
6190 2020-01-08  Simon Marchi  <simon.marchi@efficios.com>
6191
6192         * thread.c (print_thread_info_1): Fix indentation.
6193
6194 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
6195
6196         * symtab.c (general_symbol_info::compute_and_set_names): Move the
6197         unique_xmalloc_ptr outside the if to always free the demangled name.
6198
6199 2020-01-08  Tom Tromey  <tromey@adacore.com>
6200
6201         * xcoffread.c (enter_line_range, read_xcoff_symtab)
6202         (process_xcoff_symbol, xcoff_symfile_offsets): Update.
6203         * symtab.h (MSYMBOL_VALUE_ADDRESS): Update.
6204         (struct section_offsets, ANOFFSET, SIZEOF_N_SECTION_OFFSETS):
6205         Remove.
6206         (section_offsets): New typedef.
6207         * symtab.c (fixup_section, get_msymbol_address): Update.
6208         * symmisc.c (dump_msymbols): Update.
6209         * symfile.h (relative_addr_info_to_section_offsets)
6210         (symfile_map_offsets_to_segments): Update.
6211         * symfile.c (build_section_addr_info_from_objfile)
6212         (init_objfile_sect_indices): Update.
6213         (struct place_section_arg): Change type of "offsets".
6214         (place_section): Update.
6215         (relative_addr_info_to_section_offsets): Change type of
6216         "section_offsets".  Remove "num_sections" parameter.
6217         (default_symfile_offsets, syms_from_objfile_1)
6218         (set_objfile_default_section_offset): Update.
6219         (reread_symbols): No need to preserve section offsets by hand.
6220         (symfile_map_offsets_to_segments): Change type of "offsets".
6221         * stap-probe.c (relocate_address): Update.
6222         * stabsread.h (process_one_symbol): Update.
6223         * solib-target.c (struct lm_info_target) <offsets>: Change type.
6224         (solib_target_relocate_section_addresses): Update.
6225         * solib-svr4.c (enable_break, svr4_relocate_main_executable):
6226         Update.
6227         * solib-frv.c (frv_relocate_main_executable): Update.
6228         * solib-dsbt.c (dsbt_relocate_main_executable): Update.
6229         * solib-aix.c (solib_aix_get_section_offsets): Change return
6230         type.
6231         (solib_aix_solib_create_inferior_hook): Update.
6232         * remote.c (remote_target::get_offsets): Update.
6233         * psymtab.c (find_pc_sect_psymtab): Update.
6234         * psympriv.h (struct partial_symbol) <address, text_low,
6235         text_high>: Update.
6236         * objfiles.h (obj_section_offset): Update.
6237         (struct objfile) <section_offsets>: Change type.
6238         <num_sections>: Remove.
6239         (objfile_relocate): Update.
6240         * objfiles.c (entry_point_address_query): Update
6241         (relocate_one_symbol): Change type of "section_offsets".
6242         (objfile_relocate1, objfile_relocate1): Change type of
6243         "new_offsets".
6244         (objfile_rebase1): Update.
6245         * mipsread.c (mipscoff_symfile_read): Update.
6246         (read_alphacoff_dynamic_symtab): Remove "section_offsets"
6247         parameter.
6248         * mdebugread.c (parse_symbol): Change type of "section_offsets".
6249         (parse_external, psymtab_to_symtab_1): Update.
6250         * machoread.c (macho_symfile_offsets): Update.
6251         * ia64-tdep.c (ia64_find_unwind_table): Update.
6252         * hppa-tdep.c (read_unwind_info): Update.
6253         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Update.
6254         * dwarf2read.c (create_addrmap_from_index)
6255         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
6256         (process_psymtab_comp_unit_reader, add_partial_symbol)
6257         (add_partial_subprogram, process_full_comp_unit)
6258         (read_file_scope, read_func_scope, read_lexical_block_scope)
6259         (read_call_site_scope, dwarf2_rnglists_process)
6260         (dwarf2_ranges_process, dwarf2_ranges_read)
6261         (dwarf_decode_lines_1, var_decode_location, new_symbol)
6262         (dwarf2_fetch_die_loc_sect_off, dwarf2_per_cu_text_offset):
6263         Update.
6264         * dwarf2-frame.c (execute_cfa_program, dwarf2_frame_find_fde):
6265         Update.
6266         * dtrace-probe.c (dtrace_probe::get_relocated_address): Update.
6267         * dbxread.c (read_dbx_symtab, read_ofile_symtab): Update.
6268         (process_one_symbol): Change type of "section_offsets".
6269         * ctfread.c (get_objfile_text_range): Update.
6270         * coffread.c (coff_symtab_read, enter_linenos)
6271         (process_coff_symbol): Update.
6272         * coff-pe-read.c (add_pe_forwarded_sym): Update.
6273         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Update.
6274
6275 2020-01-08  Tom Tromey  <tromey@adacore.com>
6276
6277         * dwarf2read.c (parse_macro_definition): Use std::string.
6278         (parse_macro_definition): Likewise.
6279
6280 2020-01-08  Tom Tromey  <tromey@adacore.com>
6281
6282         * dwarf2read.c (abbrev_table_read_table): Use std::vector.
6283         (ATTR_ALLOC_CHUNK): Remove.
6284
6285 2020-01-08  Tom Tromey  <tromey@adacore.com>
6286
6287         * dwarf2read.c (fixup_go_packaging): Use unique_xmalloc_ptr.
6288
6289 2020-01-08  Tom Tromey  <tromey@adacore.com>
6290
6291         * dwarf2read.c (add_partial_symbol): Use unique_xmalloc_ptr.
6292         (dwarf2_compute_name, open_dwo_file): Likewise.
6293         (process_enumeration_scope): Use std::vector.
6294         (guess_partial_die_structure_name): Use unique_xmalloc_ptr.
6295         (partial_die_info::fixup, dwarf2_start_subfile)
6296         (guess_full_die_structure_name, dwarf2_name): Likewise.
6297         (determine_prefix): Update.
6298         (guess_full_die_structure_name): Make return type const.
6299         (partial_die_full_name): Return unique_xmalloc_ptr.
6300         (DW_FIELD_ALLOC_CHUNK): Remove.
6301
6302 2020-01-07  Tom Tromey  <tromey@adacore.com>
6303
6304         PR build/24937:
6305         * stap-probe.c (class stap_static_probe_ops): Add constructor.
6306
6307 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
6308
6309         * cli/cli-style.c: Set cli_styling to 'true' in the Cygwin build.
6310
6311 2020-01-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6312
6313         * stack.c (print_frame_info): Move disassemble_next_line code
6314         inside source_print block.
6315
6316 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
6317
6318         * gdbsupport/gdb_wait.c: Include <signal.h> instead of
6319         gdb/signals.h, as we are now using native signal symbols.
6320
6321 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
6322
6323         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): Avoid
6324         overflow by an early check of content vs threshold.
6325         * tui/tui-source.c (tui_source_window::line_is_displayed):
6326         Likewise.
6327
6328 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
6329
6330         * NEWS: Mention the recent fix of $_exitsignal on MS-Windows.
6331
6332 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
6333
6334         * coff-pe-read.c (read_pe_exported_syms): Don't try to read the
6335         export table if no section contains it's RVA.
6336
6337 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
6338
6339         * windows-tdep.c: Fix a typo in WINDOWS_SIGABRT.
6340
6341 2020-01-06  Hannes Domani  <ssbssa@yahoo.de>
6342
6343         * source.c (print_source_lines_base): Set last_line_listed.
6344
6345 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
6346
6347         * tui/tui-disasm.c: Remove trailing spaces.
6348
6349 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
6350             Pedro Alves  <palves@redhat.com>
6351
6352         * Makefile.in (COMMON_SFILES): Add gdbsupport/gdb_wait.c.
6353         * windows-tdep.c: New enumeration of WINDOWS_SIG* signals.
6354         (windows_gdb_signal_to_target): New function, uses the above
6355         enumeration to convert GDB internal signal codes to equivalent
6356         Windows codes.
6357         (windows_init_abi): Call set_gdbarch_gdb_signal_to_target.
6358         * windows-nat.c: Include "gdb_wait.h".
6359         (get_windows_debug_event): Extract the fatal exception from the
6360         exit status and convert to the equivalent Posix signal number.
6361         * cli/cli-cmds.c (exit_status_set_internal_vars): Account for the
6362         possibility that WTERMSIG returns GDB_SIGNAL_UNKNOWN.
6363         * gdbsupport/gdb_wait.c: New file, implements
6364         windows_status_to_termsig.
6365         * gdbsupport/gdb_wait.h (WIFEXITED, WIFSIGNALED, WEXITSTATUS)
6366         (WTERMSIG) [__MINGW32__]: Separate definitions for MinGW.
6367
6368 2020-01-05  Andrew Burgess  <andrew.burgess@embecosm.com>
6369
6370         * tui/tui-layout.c (tui_add_win_to_layout): Use tui_set_layout not
6371         show_layout.
6372
6373 2020-01-05  Luis Machado  <luis.machado@linaro.org>
6374
6375         * aarch64-linux-nat.c
6376         (aarch64_linux_nat_target::thread_architecture): Use bfd_arch_aarch64
6377         and bfd_mach_aarch64.
6378
6379 2020-01-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6380
6381         * ui-file.c (stdio_file::can_emit_style_escape)
6382         (tee_file::can_emit_style_escape): Ensure style is used also on
6383         gdb_stderr when gdb_stderr is a tty supporting styling, similarly
6384         to gdb_stdout.
6385         * main.c (set_gdb_data_directory): Use file style to output the
6386         warning that the given pathname is not a directory.
6387         * top.c (show_history_filename, gdb_safe_append_history)
6388         (show_gdb_datadir): Use file style.
6389
6390 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
6391
6392         * solib-target.c (struct lm_info_target):
6393         Change offsets to be a unique_xmalloc_ptr.
6394         (solib_target_relocate_section_addresses): Update.
6395
6396 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
6397
6398         * windows-nat.c (windows_clear_solib): Free so_list linked list.
6399
6400 2020-01-03  Bernd Edlinger  <bernd.edlinger@hotmail.de>
6401
6402         * MAINTAINERS (Write After Approval): Add myself.
6403
6404 2020-01-02  Luis Machado  <luis.machado@linaro.org>
6405
6406         * proc-service.c (get_ps_regcache): Remove reference to obsolete
6407         Cell BE architecture.
6408         * target.h (struct target_ops) <thread_architecture>: Likewise.
6409
6410 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
6411
6412         * Makefile.in: Use INSTALL_PROGRAM_ENV.
6413
6414 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
6415
6416         * MAINTAINERS (Write After Approval): Add myself.
6417
6418 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
6419
6420         * gdbarch.sh: Update copyright year range of generated files.
6421
6422 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
6423
6424         Update copyright year range in all GDB files.
6425
6426 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
6427
6428         * copyright.py: Convert to Python 3.
6429
6430 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
6431
6432         * copyright.py: Adapt after move of gnulib directory from gdb
6433         directory to toplevel directory.
6434
6435 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
6436
6437         * copyright.py (main): Exit if run from the wrong directory.
6438
6439 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
6440
6441         * top.c (print_gdb_version): Change copyright year to 2020.
6442
6443 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
6444
6445         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2019.
6446
6447 For older changes see ChangeLog-2019.
6448 \f
6449 Local Variables:
6450 mode: change-log
6451 left-margin: 8
6452 fill-column: 74
6453 version-control: never
6454 coding: utf-8
6455 End: