Set GDB version number to 9.0.90.
[deliverable/binutils-gdb.git] / gdb / ChangeLog
1 2019-12-11 Joel Brobecker <brobecker@adacore.com>
2
3 * version.in: Set GDB version number to 9.0.90.
4
5 2019-12-11 Joel Brobecker <brobecker@adacore.com>
6
7 * NEWS: Change "Changes since GDB 8.3" into "Changes in GDB 9".
8
9 2019-12-11 Joel Brobecker <brobecker@adacore.com>
10
11 GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
12 * version.in: Bump version to 9.0.90.DATE-git.
13
14 2019-12-11 Tom Tromey <tromey@adacore.com>
15
16 PR build/25268:
17 * gdbsupport/thread-pool.c (set_thread_name): New function.
18 (thread_pool::set_thread_count): Don't call pthread_setname_np.
19 (thread_pool::thread_function): Call set_thread_name.
20
21 2019-12-11 Tom Tromey <tromey@adacore.com>
22
23 * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
24 bfd_get_signed_8.
25
26 2019-12-11 Philippe Waroquiers <philippe.waroquiers@skynet.be>
27
28 * NEWS: Document -raw-values option and the related setting commands.
29 * printcmd.c (print_command_parse_format): Do not set opts->raw off,
30 only set it on when /r is given.
31 * valprint.c (value_print_option_defs): New element raw-values.
32 * Makefile.in: Add the new file.
33
34 2019-12-10 Christian Biesinger <cbiesinger@google.com>
35
36 * gdbsupport/safe-strerror.c: Supress the unused function warning
37 for select_strerror_r.
38
39 2019-12-10 Christian Biesinger <cbiesinger@google.com>
40
41 * config.in: Regenerate.
42 * configure: Regenerate.
43 * gdbsupport/agent.c (gdb_connect_sync_socket): Call
44 safe_strerror instead of strerror.
45 * gdbsupport/common.m4: Don't check for strerror.
46 * gdbsupport/safe-strerror.c: Support both the glibc version
47 of strerror_r and the XSI version.
48
49 2019-12-10 Tom Tromey <tromey@adacore.com>
50
51 * ada-typeprint.c (print_choices): Use a single "?".
52 (print_variant_part): Print "?" if the discriminant name
53 is not known.
54
55 2019-12-10 George Barrett <bob@bob131.so>
56
57 Fix scripted probe breakpoints.
58 * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
59 declaration forward.
60 (breakpoint_ops_for_event_location_type)
61 (breakpoint_ops_for_event_location): Add function definitions.
62 (break_command_1, trace_command): Use
63 breakpoint_ops_for_event_location.
64 * breakpoint.h (breakpoint_ops_for_event_location): Add function
65 declarations.
66 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
67 breakpoint_ops_for_event_location.
68 * python/py-breakpoint.c (bppy_init): Use
69 breakpoint_ops_for_event_location.
70
71 2019-12-09 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
72
73 * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
74 when ranking an lvalue argument for an rvalue parameter.
75
76 2019-12-08 Wataru Ashihara <wataash@wataash.com>
77
78 * darwin-nat.c (darwin_nat_target::create_inferior): Fix
79 template argument for scoped_restore_tmpl from bool to int.
80
81 2019-12-07 Keith Seitz <keiths@redhat.com>
82
83 * build-id.c (build_id_bfd_get): Permit bfd_core, too.
84 (build_id_to_debug_bfd): Make static, rewriting to use
85 build_id_to_bfd_suffix.
86 (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
87 adding `suffix' parameter. Append SUFFIX to file names
88 when searching for matching files.
89 (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
90 (build_id_to_exec_bfd): Likewise.
91 * build-id.h (build_id_to_debug_bfd): Clarify that function
92 searches for BFD of debug info file.
93 (build_id_to_exec_bfd): Declare.
94 * corelow.c: Include build-id.h.
95 (locate_exec_from_corefile_build_id): New function.
96 (core_target_open): If no executable BFD is found,
97 search for a core file BFD using build-id.
98
99 2019-12-06 Christian Biesinger <cbiesinger@google.com>
100
101 * bcache.c: Put in namespace gdb.
102 * bcache.h: Likewise.
103 * gdbtypes.c (check_types_worklist): Update.
104 (types_deeply_equal): Update.
105 * macrotab.c (struct macro_table) <bcache>: Update.
106 (new_macro_table): Update.
107 * macrotab.h (struct bcache): Put this forward declaration
108 inside namespace gdb.
109 (new_macro_table): Update.
110 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
111 Update.
112 <macro_cache>: Update.
113 * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
114
115 2019-12-06 Tom de Vries <tdevries@suse.de>
116
117 PR symtab/24971
118 * block.c (best_symbol, better_symbol): New function.
119 (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
120 decl.
121
122 2019-12-06 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
123
124 * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
125 * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
126 for ranking see-through reference cases.
127
128 2019-12-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
129 * stack.c (faas_command): Check a command is provided.
130 * thread.c (taas_command, tfaas_command): Likewise.
131
132 2019-12-05 Philippe Waroquiers <philippe.waroquiers@skynet.be>
133 * inferior.c (prune_inferiors): Only call delete_inferior,
134 Do not modify the inferior list.
135
136 2019-12-05 Simon Marchi <simon.marchi@polymtl.ca>
137
138 * c-exp.y: Update calls to lookup_typename,
139 lookup_signed_typename and lookup_unsigned_typename.
140 * c-lang.c (evaluate_subexp_c): Likewise.
141 * cp-namespace.c (cp_lookup_symbol_imports_or_template):
142 Likewise.
143 * eval.c (binop_promote): Likewise.
144 * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
145 (lookup_unsigned_typename): Likewise.
146 (lookup_signed_typename): Likewise.
147 * gdbtypes.h (lookup_unsigned_typename): Likewise.
148 (lookup_signed_typename): Likewise.
149 (lookup_typename): Likewise.
150 * guile/scm-type.c (tyscm_lookup_typename): Update calls to
151 lookup_typename, lookup_signed_typename,
152 lookup_unsigned_typename.
153 * m2-exp.y: Likewise.
154 * printcmd.c (printf_wide_c_string): Likewise.
155 (ui_printf): Likewise.
156 * python/py-type.c (typy_lookup_typename): Likewise.
157 * python/py-xmethods.c (python_xmethod_worker::invoke):
158 Likewise.
159 * rust-exp.y: Likewise.
160
161 2019-12-04 Christian Biesinger <cbiesinger@google.com>
162
163 * configure.nat (obsd64): Add missing files x86-nat.o and
164 nat/x86-dregs.o.
165
166 2019-12-04 Tom Tromey <tom@tromey.com>
167
168 * valprint.c (val_print_string): Use metadata_style.
169 * go-valprint.c (print_go_string): Use metadata style.
170 * p-valprint.c (pascal_object_print_static_field): Use metadata
171 style.
172 * cp-valprint.c (cp_print_static_field): Use metadata style.
173
174 2019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
175 Chris January <chris.january@arm.com>
176
177 * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
178 tokens.
179 (typebase): New patterns for complex, single/double precision, and
180 single/double complex.
181 (f77_keywords): Change token for complex keyword, and add single,
182 double, and precision keywords.
183
184 2019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
185
186 * avr-tdep.c (_initialize_avr_tdep): Improve help of command
187 "info io_registers".
188
189 2019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
190
191 * regcache.c (cooked_read_test): Initialize thread list of
192 mock_inferior.
193
194 2019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
195
196 * aarch64-linux-tdep.c: Remove includes.
197
198 2019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
199
200 * aarch64-tdep.c: Remove includes.
201
202 2019-12-04 Simon Marchi <simon.marchi@efficios.com>
203
204 * filtered-iterator.h (filtered_iterator) <operator==,
205 operator!=>: Compare wrapped iterators, not wrapped pointers.
206 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
207 unittests/filtered_iterator-selftests.c.
208 * unittests/filtered_iterator-selftests.c: New file.
209
210 2019-12-04 Tom Tromey <tromey@adacore.com>
211
212 * gdbtypes.c (create_range_type): Inherit endianity
213 from base type.
214
215 2019-12-04 Tom Tromey <tromey@adacore.com>
216
217 * ada-lang.c (decode_constrained_packed_array)
218 (ada_value_assign, value_assign_to_component): Update.
219 * dwarf2loc.c (rw_pieced_value, access_memory)
220 (dwarf2_compile_expr_to_ax): Update.
221 * dwarf2read.c (dwarf2_add_field): Update.
222 * eval.c (evaluate_subexp_standard): Update.
223 * gdbarch.c, gdbarch.h: Rebuild.
224 * gdbarch.sh (bits_big_endian): Remove.
225 * gdbtypes.h (union field_location): Update comment.
226 * target-descriptions.c (make_gdb_type): Update.
227 * valarith.c (value_bit_index): Update.
228 * value.c (struct value) <bitpos>: Update comment.
229 (unpack_bits_as_long, modify_field): Update.
230 * value.h (value_bitpos): Update comment.
231
232 2019-12-04 Tom Tromey <tromey@adacore.com>
233
234 * gdbtypes.c (type_byte_order): Move earlier. Assert for unknown
235 endian-ness.
236
237 2019-12-04 Tom Tromey <tromey@adacore.com>
238
239 * dwarf2read.c (dwarf2_init_float_type)
240 (dwarf2_init_complex_target_type): Add byte_order parameter.
241 (read_base_type): Compute byte order earlier.
242 * gdbtypes.c (init_float_type): Add byte_order parameter.
243 * gdbtypes.h (init_float_type): Add byte_order parameter.
244
245 2019-12-04 Tom Tromey <tromey@adacore.com>
246
247 * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
248
249 2019-12-04 Tom Tromey <tromey@adacore.com>
250
251 * dwarf2read.c (process_structure_scope): Initialize
252 "discr_offset".
253
254 2019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
255
256 * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
257 add it into the search spec.
258 (parse_max_results_option): New function.
259 (mi_info_functions_or_variables): Parse -max-results flag and pass
260 it to mi_symbol_info.
261 (mi_cmd_symbol_info_modules): Likewise.
262 (mi_cmd_symbol_info_types): Likewise.
263 * symtab.c (global_symbol_searcher::add_matching_symbols): Change
264 return type to bool, change result container into a set, and don't
265 add new results if we have enough already.
266 (global_symbol_searcher::add_matching_msymbols): Change return
267 type to bool, and don't add new results if we have enough already.
268 (sort_search_symbols_remove_dups): Delete.
269 (global_symbol_searcher::search): Early exit from search loop when
270 we have enough results. Use a std::set to collect the results
271 from calling add_matching_symbols.
272 * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
273 member function.
274 (global_symbol_searcher) <m_max_search_results>: New member
275 variable.
276 (global_symbol_searcher) <add_matching_symbols>: Update header
277 comment and change return type to bool.
278 (global_symbol_searcher) <add_matching_msymbols>: Update header
279 comment and change return type to bool.
280
281 2019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
282
283 * symtab.c (symbol_search::compare_search_syms): Update header
284 comment.
285 (global_symbol_searcher::is_suitable_msymbol): New function.
286 (global_symbol_searcher::expand_symtabs): New function.
287 (global_symbol_searcher::add_matching_symbols): New function.
288 (global_symbol_searcher::add_matching_msymbols): New function.
289 (global_symbol_searcher::search): Move most of the content
290 into the new functions above, and call them as needed.
291 * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
292 function.
293 (global_symbol_searcher) <add_matching_symbols>: New member
294 function.
295 (global_symbol_searcher) <add_matching_msymbols>: New member
296 function.
297 (global_symbol_searcher) <is_suitable_msymbol>: New member
298 function.
299
300 2019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
301
302 * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
303 -symbol-info-module-variables entries.
304 * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
305 (mi_cmd_symbol_info_module_variables): Declare.
306 * mi/mi-symbol-cmds.c
307 (module_symbol_search_iterator): New typedef.
308 (output_module_symbols_in_single_module_and_file): New function.
309 (output_module_symbols_in_single_module): New function.
310 (mi_info_module_functions_or_variables): New function.
311 (mi_cmd_symbol_info_module_functions): New function.
312 (mi_cmd_symbol_info_module_variables): New function.
313 * NEWS: Mention new MI command.
314
315 2019-12-03 Christian Biesinger <cbiesinger@google.com>
316
317 * bcache.c (hash): Remove.
318 (hash_continue): Remove.
319 * bcache.h (hash): Remove.
320 (hash_continue): Remove.
321 (struct bcache) <ctor>: Update.
322 * psymtab.c (psymbol_hash): Update.
323 * stabsread.c (hashname): Update.
324 * utils.h (fast_hash): Add an argument for a start value,
325 defaulting to zero.
326
327 2019-12-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
328 * symtab.c (symbol_cache_clear_slot): Move close to cleared type.
329 (destroy_block_symbol_cache): New function.
330 (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
331 (resize_symbol_cache): Likewise.
332
333 2019-12-02 Tom Tromey <tom@tromey.com>
334
335 * unittests/tui-selftests.c (run_tests): Make conditional.
336 (_initialize_tui_selftest): Make conditional.
337
338 2019-12-02 Christian Biesinger <cbiesinger@google.com>
339
340 * aix-thread.c (debug_aix_thread): Change type to bool.
341
342 2019-12-02 Luis Machado <luis.machado@linaro.org>
343
344 * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
345
346 2019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
347
348 * dwarf2read.c (read_tag_string_type): Read the fields required to
349 make a dynamic string, and possibly create a dynamic range for the
350 string.
351 (attr_to_dynamic_prop): Setup is_reference based on the type of
352 attribute being processed.
353 * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
354 (resolve_dynamic_array): Rename to...
355 (resolve_dynamic_array_or_string): ...this, update header comment,
356 and accept TYPE_CODE_STRING.
357 (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
358
359 2019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
360
361 * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
362 of its implementation from...
363 (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
364 the new function.
365
366 2019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
367
368 * dwarf2read.c (read_subrange_type): Read bit and byte stride and
369 create a range with stride where appropriate.
370 * f-valprint.c: Include 'gdbarch.h'.
371 (f77_print_array_1): Take the stride into account when walking the
372 array. Also convert the stride into addressable units.
373 * gdbtypes.c (create_range_type): Initialise the stride to
374 constant zero.
375 (create_range_type_with_stride): New function, initialise the
376 range as normal, and then setup the stride.
377 (has_static_range): Include the stride here. Also change the
378 return type to bool.
379 (create_array_type_with_stride): Consider the range stride if the
380 array isn't given its own stride.
381 (resolve_dynamic_range): Resolve the stride if needed.
382 * gdbtypes.h (struct range_bounds) <stride>: New member variable.
383 (struct range_bounds) <flag_is_byte_stride>: New member variable.
384 (TYPE_BIT_STRIDE): Define.
385 (TYPE_ARRAY_BIT_STRIDE): Define.
386 (create_range_type_with_stride): Declare.
387 * valarith.c (value_subscripted_rvalue): Take range stride into
388 account when walking the array.
389
390 2019-12-01 Tom Tromey <tom@tromey.com>
391
392 * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
393 specially.
394
395 2019-12-01 Tom Tromey <tom@tromey.com>
396
397 * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
398 \0.
399 * unittests/tui-selftests.c: New file.
400 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
401
402 2019-12-01 Tom Tromey <tom@tromey.com>
403
404 * tui/tui.c (tui_enable): Call tui_update_variables earlier.
405
406 2019-12-01 Tom Tromey <tom@tromey.com>
407
408 * NEWS: Document new settings.
409 * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
410 * tui/tui-win.c (_initialize_tui_win): Add border style
411 observers.
412 * tui/tui-io.h (tui_apply_style): Declare.
413 * tui/tui-io.c (tui_apply_style): Rename from apply_style. No
414 longer static.
415 (apply_ansi_escape, tui_set_reverse_mode): Update.
416 * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
417 Add "skip_intensity" parameter.
418 <changed>: New member.
419 <do_set_value>: Declare.
420 (tui_border_style, tui_active_border_style): Declare.
421 * cli/cli-style.c (tui_border_style, tui_active_border_style): New
422 globals.
423 (cli_style_option): Initialize "changed".
424 (cli_style_option::do_set_value): New function.
425 (cli_style_option::add_setshow_commands): Add "skip_intensity"
426 parameter. Update.
427 (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
428 (_initialize_cli_style): Update. Create TUI border style
429 commands.
430
431 2019-12-01 Tom Tromey <tom@tromey.com>
432
433 * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
434 parameter.
435 * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
436 parameter.
437 * tui/tui-win.h (compact_source): Declare.
438 * tui/tui-win.c (compact_source): New global.
439 (tui_set_compact_source, tui_show_compact_source): New functions.
440 (_initialize_tui_win): Add "compact-source" setting.
441 * tui/tui-source.c (tui_source_window::set_contents): Handle
442 compact_source setting.
443 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
444 * NEWS: Document new setting.
445
446 2019-11-30 Tom Tromey <tom@tromey.com>
447
448 * dwarf2read.c (dwarf2_add_field): Include field offset when
449 computing variant part length.
450
451 2019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
452 * NEWS: Mention define-prefix. Tell that command names can now
453 contain a . character.
454
455 2019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
456
457 * command.h (valid_cmd_char_p): Declare.
458 * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
459 the check of valid command char.
460 (find_command_name_length, valid_user_defined_cmd_name_p): Use
461 valid_cmd_char_p.
462 * cli/cli-script.c (validate_comname): Likewise.
463 * completer.c (gdb_completer_command_word_break_characters):
464 Do not remove . from the word break char, update comments.
465 (complete_line_internal_1): Use valid_cmd_char_p.
466 * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
467 * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
468
469 2019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
470
471 * cli/cli-script.c (do_define_command): Ensure a redefined
472 prefix command is kept as a prefix command.
473 (define_prefix_command): New function.
474 (show_user_1): Report user defined prefixes.
475 (_initialize_cli_script): Create the new 'define-prefix' command.
476 Add completers for 'define' and 'document'.
477 * top.c (execute_command): If command is a user-defined prefix only
478 command, report the list of commands for this prefix command.
479
480 2019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
481
482 * valops.c (find_oload_champ): Improve debug output.
483
484 2019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
485
486 * valops.c (find_oload_champ): Print part of debug messages
487 before the badness vector is std::move'd.
488
489 2019-11-28 Tom Tromey <tom@tromey.com>
490
491 * value.c (creal_internal_fn): Fix comment.
492
493 2019-11-28 Tom Tromey <tom@tromey.com>
494
495 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
496 flag_bound_evaluated>: Now unsigned.
497
498 2019-11-28 Tom Tromey <tom@tromey.com>
499
500 * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
501 declare.
502
503 2019-11-28 Mihails Strasuns <mihails.strasuns@intel.com>
504
505 * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
506 debug output.
507 * jit.c (jit_unregister_code): Add debug print to match
508 `jit_register_code`.
509
510 2019-11-27 Christian Biesinger <cbiesinger@google.com>
511
512 * NEWS: Mention the new multithreaded symbol loading.
513
514 2019-11-27 Christian Biesinger <cbiesinger@google.com>
515
516 * maint.c (n_worker_threads): Default to 0.
517 (worker_threads_disabled): New function.
518 * maint.h (worker_threads_disabled): New function.
519 * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
520 here if worker_threads_disabled () is true.
521 (minimal_symbol_reader::install): Skip all threading if
522 worker_threads_disabled () is true.
523
524 2019-11-27 Christian Biesinger <cbiesinger@google.com>
525
526 * minsyms.c (add_minsym_to_hash_table): Use a previously computed
527 hash code if possible.
528 (add_minsym_to_demangled_hash_table): Likewise.
529 (minimal_symbol_reader::install): Compute the hash codes for msymbol
530 on the background thread.
531 * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
532 Add these fields.
533
534 2019-11-27 Christian Biesinger <cbiesinger@google.com>
535
536 * minsyms.c (minimal_symbol_reader::install): Also compute the hash
537 of the mangled name on the background thread.
538 * symtab.c (symbol_set_names): Allow passing in the hash of the
539 linkage_name.
540 * symtab.h (symbol_set_names): Likewise.
541
542 2019-11-27 Kevin Buettner <kevinb@redhat.com>
543
544 * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
545 physnames are computed for inherited DIEs.
546
547 2019-11-27 Tom Tromey <tromey@adacore.com>
548
549 * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
550 backslashes.
551 * cp-support.c: Remove unnecessary backslashes.
552
553 2019-11-27 Christian Biesinger <cbiesinger@google.com>
554
555 * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
556 with sym->set_linkage_name.
557 * coffread.c (coff_read_enum_type): Likewise.
558 * mdebugread.c (parse_symbol): Likewise.
559 * stabsread.c (patch_block_stabs): Likewise.
560 (define_symbol): Likewise.
561 (read_enum_type): Likewise.
562 (common_block_end): Likewise.
563 * symtab.h (struct general_symbol_info) <set_linkage_name>: New
564 function.
565 (SYMBOL_SET_LINKAGE_NAME): Remove.
566 * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
567 with sym->set_linkage_name.
568
569 2019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
570
571 * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
572 * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
573 * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
574 * NEWS: Mention new MI command.
575
576 2019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
577
578 * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
579 '-symbol-info-types', and '-symbol-info-variables'.
580 * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
581 (mi_cmd_symbol_info_types): Declare.
582 (mi_cmd_symbol_info_variables): Declare.
583 * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
584 (output_debug_symbol): New function.
585 (output_nondebug_symbol): New function.
586 (mi_symbol_info): New function.
587 (mi_info_functions_or_variables): New function.
588 (mi_cmd_symbol_info_functions): New function.
589 (mi_cmd_symbol_info_types): New function.
590 (mi_cmd_symbol_info_variables): New function.
591 * NEWS: Mention new commands.
592
593 2019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
594
595 * symtab.c (symbol_to_info_string): New function, most content
596 moved from print_symbol_info, but updated to return a std::string.
597 (print_symbol_info): Update to use symbol_to_info_string and print
598 returned string.
599 * symtab.h (symbol_to_info_string): Declare new function.
600
601 2019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
602
603 * python/python.c (gdbpy_rbreak): Convert to using
604 global_symbol_searcher.
605 * symtab.c (file_matches): Convert return type to bool, change
606 file list to std::vector, update header comment.
607 (search_symbols): Rename to...
608 (global_symbol_searcher::search): ...this and update now its
609 a member function of global_symbol_searcher. Take account of the
610 changes to file_matches.
611 (symtab_symbol_info): Convert to using global_symbol_searcher.
612 (rbreak_command): Likewise.
613 (search_module_symbols): Likewise.
614 * symtab.h (enum symbol_search): Update comment.
615 (search_symbols): Remove declaration.
616 (class global_symbol_searcher): New class.
617
618 2019-11-26 Tom Tromey <tromey@adacore.com>
619
620 * cp-support.c (_initialize_cp_support): Conditionally initialize
621 gdb_demangle_attempt_core_dump.
622
623 2019-11-26 Tom Tromey <tom@tromey.com>
624
625 * python/py-function.c (fnpy_init): Update.
626 * value.h (add_internal_function): Adjust declaration.
627 * value.c (function_destroyer): Remove.
628 (do_add_internal_function): Don't set destroyer or copy name.
629 (add_internal_function): Take unique_xmalloc_ptr<char> for name.
630 Set name_allocated.
631 * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
632 (cmdpy_init): Set name_allocated.
633 * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
634 member.
635 (~cmd_list_element): Free "name" if needed.
636
637 2019-11-26 Tom Tromey <tom@tromey.com>
638
639 * value.h (add_internal_function): Add new overload. Move
640 documentation from value.h.
641 * value.c (do_add_internal_function): New function.
642 (add_internal_function): Use it. Add new overload.
643 (function_destroyer): Don't free doc.
644 * python/py-function.c (fnpy_init): Update.
645
646 2019-11-26 Tom Tromey <tom@tromey.com>
647
648 * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
649 (cmdpy_init): Set "doc_allocated".
650
651 2019-11-26 Tom Tromey <tom@tromey.com>
652
653 * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
654 name of worker thread.
655 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
656 pthread_setname_np.
657 * configure, config.in: Rebuild.
658
659 2019-11-26 Tom Tromey <tom@tromey.com>
660
661 * python/python.c (class gdbpy_gil): New.
662 (struct gdbpy_event): Add constructor, destructor, operator().
663 (gdbpy_post_event): Use run_on_main_thread.
664 (gdbpy_initialize_events): Remove.
665 (do_start_initialization): Update.
666
667 2019-11-26 Tom Tromey <tom@tromey.com>
668
669 * NEWS: Add entry.
670 * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
671 commands. Call update_thread_pool_size.
672 (update_thread_pool_size, maintenance_set_worker_threads): New
673 functions.
674 (n_worker_threads): New global.
675
676 2019-11-26 Christian Biesinger <cbiesinger@google.com>
677 Tom Tromey <tom@tromey.com>
678
679 * minsyms.c (minimal_symbol_reader::install): Use
680 parallel_for_each.
681 * gdbsupport/parallel-for.h: New file.
682 * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
683
684 2019-11-26 Christian Biesinger <cbiesinger@google.com>
685 Tom Tromey <tom@tromey.com>
686
687 * gdbsupport/thread-pool.h: New file.
688 * gdbsupport/thread-pool.c: New file.
689 * Makefile.in (COMMON_SFILES): Add thread-pool.c.
690 (HFILES_NO_SRCDIR): Add thread-pool.h.
691
692 2019-11-26 Tom Tromey <tom@tromey.com>
693
694 * event-top.h (thread_local_segv_handler): Declare.
695 * event-top.c (thread_local_segv_handler): New global.
696 (install_handle_sigsegv, handle_sigsegv): New functions.
697 (async_init_signals): Install SIGSEGV handler.
698 * cp-support.c (gdb_demangle_jmp_buf): Change type. Now
699 thread-local.
700 (report_failed_demangle): New function.
701 (gdb_demangle): Make core_dump_allowed atomic. Remove signal
702 handler-setting code, instead use segv_handler. Run warning code
703 on main thread.
704
705 2019-11-26 Tom Tromey <tom@tromey.com>
706
707 * run-on-main-thread.c: New file.
708 * run-on-main-thread.h: New file.
709 * unittests/main-thread-selftests.c: New file.
710 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
711 main-thread-selftests.c.
712 (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
713 (COMMON_SFILES): Add run-on-main-thread.c.
714
715 2019-11-26 Tom Tromey <tom@tromey.com>
716
717 * main.c (setup_alternate_signal_stack): Remove.
718 (captured_main_1): Use gdb::alternate_signal_stack.
719 * gdbsupport/alt-stack.h: New file.
720
721 2019-11-26 Tom Tromey <tom@tromey.com>
722
723 * gdbsupport/signals-state-save-restore.c (original_signal_mask):
724 Remove comment.
725 (save_original_signals_state, restore_original_signals_state): Use
726 gdb_sigmask.
727 * linux-nat.c (block_child_signals, restore_child_signals_mask)
728 (_initialize_linux_nat): Use gdb_sigmask.
729 * guile/guile.c (_initialize_guile): Use block_signals.
730 * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
731 * gdbsupport/gdb-sigmask.h: New file.
732 * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
733 * cp-support.c (gdb_demangle): Use gdb_sigmask.
734 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
735 pthread_sigmask.
736 * configure, config.in: Rebuild.
737 * gdbsupport/block-signals.h: New file.
738
739 2019-11-26 Tom Tromey <tom@tromey.com>
740
741 * acinclude.m4: Include ax_pthread.m4.
742 * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
743 (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
744 (CLIBS): Use PTHREAD_LIBS.
745 (aclocal_m4_deps): Add ax_pthread.m4.
746 * config.in, configure: Rebuild.
747 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
748
749 2019-11-26 Tom Tromey <tom@tromey.com>
750
751 * symtab.h (struct minimal_symbol) <name_set>: New member.
752 * minsyms.c (minimal_symbol_reader::record_full): Copy name.
753 Don't call symbol_set_names.
754 (minimal_symbol_reader::install): Call symbol_set_names.
755
756 2019-11-26 Philippe Waroquiers <philippe.waroquiers@skynet.be>
757
758 * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
759 restore_active_ext_lang, as GIL is needed for (indirectly)
760 called PyOS_InterruptOccurred.
761
762 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
763
764 * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
765 definition.
766
767 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
768
769 * remote-sim.c (simulator_command): Make static, remove
770 declaration.
771
772 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
773
774 * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
775 static.
776 * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
777 * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
778 (main): Likewise.
779 * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
780 (main): Likewise.
781 * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
782 (main): Likewise.
783 * unittests/basic_string_view/element_access/char/1.cc (test01):
784 Likewise.
785 (main): Likewise.
786 * unittests/basic_string_view/element_access/char/empty.cc (main):
787 Likewise.
788 * unittests/basic_string_view/element_access/char/front_back.cc
789 (test01): Likewise.
790 (main): Likewise.
791 * unittests/basic_string_view/inserters/char/2.cc (test05):
792 Likewise.
793 (main): Likewise.
794 * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
795 (test01): Likewise.
796 (main): Likewise.
797 * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
798 (test01): Likewise.
799 (main): Likewise.
800 * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
801 Likewise.
802 * unittests/basic_string_view/operations/compare/char/1.cc
803 (test01): Likewise.
804 (main): Likewise.
805 * unittests/basic_string_view/operations/compare/char/13650.cc
806 (test01): Likewise.
807 * unittests/basic_string_view/operations/copy/char/1.cc (test01):
808 Likewise.
809 (main): Likewise.
810 * unittests/basic_string_view/operations/data/char/1.cc (test01):
811 Likewise.
812 (main): Likewise.
813 * unittests/basic_string_view/operations/find/char/1.cc (test01):
814 Likewise.
815 (main): Likewise.
816 * unittests/basic_string_view/operations/find/char/2.cc (test02):
817 Likewise.
818 (main): Likewise.
819 * unittests/basic_string_view/operations/find/char/3.cc (test03):
820 Likewise.
821 (main): Likewise.
822 * unittests/basic_string_view/operations/find/char/4.cc (main):
823 Likewise.
824 * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
825 Likewise.
826 (main): Likewise.
827 * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
828 Likewise.
829 (main): Likewise.
830 * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
831 Likewise.
832 (main): Likewise.
833 * unittests/basic_string_view/operations/substr/char/1.cc
834 (test01): Likewise.
835 (main): Likewise.
836 * unittests/basic_string_view/operators/char/2.cc (main):
837 Likewise.
838 * unittests/optional/assignment/1.cc (test): Likewise.
839 * unittests/optional/assignment/2.cc (test): Likewise.
840 * unittests/optional/assignment/3.cc (test): Likewise.
841 * unittests/optional/assignment/4.cc (test): Likewise.
842 * unittests/optional/assignment/5.cc (test): Likewise.
843 * unittests/optional/assignment/6.cc (test): Likewise.
844 * unittests/optional/assignment/7.cc (test): Likewise.
845 * unittests/optional/cons/copy.cc (test): Likewise.
846 * unittests/optional/cons/default.cc (test): Likewise.
847 * unittests/optional/cons/move.cc (test): Likewise.
848 * unittests/optional/cons/value.cc (test): Likewise.
849 * unittests/optional/in_place.cc (test): Likewise.
850 * unittests/optional/observers/1.cc (test): Likewise.
851 * unittests/optional/observers/2.cc (test): Likewise.
852
853 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
854
855 * tui-win.h (tui_set_var_cmd): Remove.
856 * tui-win.c (tui_set_var_cmd): Make static.
857
858 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
859
860 * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
861 rbreak_command_wrapper): Remove.
862 * symtab.c (rbreak_command_wrapper): Remove.
863
864 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
865
866 * inferior.h (info_terminal_command): Remove declaration.
867 * inflow.c (info_terminal_command): Make static.
868
869 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
870
871 * inferior.c (exit_inferior_silent): Remove.
872
873 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
874
875 * dictionary.c (dict_empty, mdict_empty): Remove.
876 * dictionary.c (mdict_empty): Remove.
877
878 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
879
880 * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
881 (arc_insn_get_memory_offset): Likewise.
882 (arc_insn_dump): Likewise.
883 * cp-support.c (test_cp_symbol_name_matches): Likewise.
884 * csky-linux-tdep.c (csky_supply_fregset): Likewise.
885 * dictionary.c (dict_iterator_next): Likewise.
886 (dict_iter_match_first): Likewise.
887 (dict_iter_match_next): Likewise.
888 * f-lang.c (evaluate_subexp_f): Likewise.
889 * hppa-tdep.c (hppa_read_pc): Likewise.
890 * i386-tdep.c (i386_floatformat_for_type): Likewise.
891 * parse.c (write_exp_elt_msym): Likewise.
892 * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
893 * remote.c (remote_packet_size): Likewise.
894 (remote_notif_stop_parse): Likewise.
895 * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
896 * s12z-tdep.c (s12z_disassemble_info): Likewise.
897 * source.c (prepare_path_for_appending): Likewise.
898 * sparc64-linux-tdep.c
899 (sparc64_linux_handle_segmentation_fault); Likewise.
900 * stack.c (frame_selection_by_function_completer): Likewise.
901
902 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
903
904 * completer.c (set_gdb_completion_word_break_characters):
905 Remove.
906
907 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
908
909 * dwarf-index-write.c: Include dwarf-index-write.h.
910 * mi/mi-interp.c: Include mi/mi-interp.h.
911
912 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
913
914 * aarch32-tdep.c: Include aarch32-tdep.h.
915 * aarch32-tdep.h: Forward-declare struct target_desc.
916
917 2019-11-26 Christian Biesinger <cbiesinger@google.com>
918
919 * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
920 strerror.
921 * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
922 * windows-nat.c (windows_nat_target::create_inferior): Likewise.
923
924 2019-11-25 Tom de Vries <tdevries@suse.de>
925
926 * contrib/words.sh: Add -c option.
927
928 2019-11-25 Christian Biesinger <cbiesinger@google.com>
929
930 * solib.c (solib_find_1): Change int to bool.
931 (exec_file_find): Change int to bool.
932 (solib_find): Change int to bool.
933 (solib_read_symbols): Change int to bool.
934 (solib_used): Change int to bool.
935 (solib_add): Change int to bool.
936 (info_sharedlibrary_command): Change int to bool.
937 (solib_contains_address_p): Change int to bool.
938 (solib_keep_data_in_core): Change int to bool.
939 (in_solib_dynsym_resolve_code): Change int to bool.
940 (reload_shared_libraries_1): Change int to bool.
941 (gdb_sysroot_changed): Change int to bool.
942 * solib.h (solib_read_symbols): Change int to bool.
943 (solib_contains_address_p): Change int to bool.
944 (solib_keep_data_in_core): Change int to bool.
945 (in_solib_dynsym_resolve_code): Change int to bool.
946 (libpthread_name_p): Change int to bool.
947
948 2019-11-25 Luis Machado <luis.machado@linaro.org>
949
950 * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
951 * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
952 (remote_packet_max_chars): New static global.
953 (show_remote_packet_max_chars): New function.
954 (remote_target::putpkt_binary): Adjust to use new
955 remote_packet_max_chars option.
956 (remote_target::getpkt_or_notif_sane_1): Likewise.
957 (_initialize_remote): Register new remote-packet-max-chars option.
958
959 2019-11-24 Simon Marchi <simon.marchi@efficios.com>
960
961 * m68k-linux-nat.c: Include gdbarch.h.
962
963 2019-11-24 Tom Tromey <tom@tromey.com>
964
965 * symfile.c (read_symbols): Update.
966 * psymtab.c (require_partial_symbols): Change type of "verbose" to
967 bool.
968 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
969 (psym_lookup_symbol, psym_find_last_source_symtab)
970 (psym_forget_cached_source_info, psym_print_stats)
971 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
972 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
973 (psym_map_matching_symbols, psym_expand_symtabs_matching)
974 (psym_find_compunit_symtab_by_address)
975 (maintenance_print_psymbols, maintenance_info_psymtabs)
976 (maintenance_check_psymtabs): Update.
977 * psymtab.h (require_partial_symbols): Change type of "verbose" to
978 bool.
979
980 2019-11-22 Tom Tromey <tom@tromey.com>
981
982 * observable.h: Update comments.
983
984 2019-11-22 Tom Tromey <tromey@adacore.com>
985
986 * ada-tasks.c (ada_task_is_alive): Make parameter const.
987 (print_ada_task_info): Don't try to fetch thread id if task is not
988 alive.
989
990 2019-11-22 Christian Biesinger <cbiesinger@google.com>
991
992 * ada-exp.y: Update.
993 * ada-lang.c (sort_choices): Update.
994 (ada_print_symbol_signature): Update.
995 (resolve_subexp): Update.
996 (ada_parse_renaming): Update.
997 (ada_read_renaming_var_value): Update.
998 (lesseq_defined_than): Update.
999 (remove_extra_symbols): Update.
1000 (remove_irrelevant_renamings): Update.
1001 (ada_add_block_symbols): Update.
1002 (ada_collect_symbol_completion_matches): Update.
1003 (ada_is_renaming_symbol): Update.
1004 (aggregate_assign_from_choices): Update.
1005 (ada_evaluate_subexp): Update.
1006 (ada_has_this_exception_support): Update.
1007 (ada_is_non_standard_exception_sym): Update.
1008 (ada_add_exceptions_from_frame): Update.
1009 (ada_add_global_exceptions): Update.
1010 (ada_print_subexp): Update.
1011 * ax-gdb.c (gen_var_ref): Update.
1012 (gen_maybe_namespace_elt): Update.
1013 (gen_expr_for_cast): Update.
1014 (gen_expr): Update.
1015 * block.h: Update.
1016 * blockframe.c (find_pc_partial_function): Update.
1017 * breakpoint.c (print_breakpoint_location): Update.
1018 (update_static_tracepoint): Update.
1019 * btrace.c (ftrace_print_function_name): Update.
1020 (ftrace_function_switched): Update.
1021 * buildsym.c (find_symbol_in_list): Update.
1022 * c-exp.y: Update.
1023 * c-typeprint.c (c_print_typedef): Update.
1024 (c_type_print_template_args): Update.
1025 * cli/cli-cmds.c (edit_command): Update.
1026 (list_command): Update.
1027 (print_sal_location): Update.
1028 * coffread.c (patch_opaque_types): Update.
1029 (process_coff_symbol): Update.
1030 (coff_read_enum_type): Update.
1031 * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1032 (convert_one_symbol): Update.
1033 (hash_symname): Update.
1034 (eq_symname): Update.
1035 * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1036 * compile/compile-cplus-types.c (debug_print_scope): Update.
1037 * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1038 * compile/compile-object-load.c (get_out_value_type): Update.
1039 * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1040 (search_symbol_list): Update.
1041 (cp_lookup_symbol_imports_or_template): Update.
1042 * cp-support.c (overload_list_add_symbol): Update.
1043 * ctfread.c (psymtab_to_symtab): Update.
1044 * dbxread.c (cp_set_block_scope): Update.
1045 * dictionary.c (iter_match_first_hashed): Update.
1046 (iter_match_next_hashed): Update.
1047 (insert_symbol_hashed): Update.
1048 (iter_match_next_linear): Update.
1049 * dictionary.h: Update.
1050 * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1051 (locexpr_describe_location_piece): Update.
1052 (locexpr_describe_location_1): Update.
1053 (locexpr_generate_c_location): Update.
1054 (loclist_describe_location): Update.
1055 (loclist_generate_c_location): Update.
1056 * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1057 (read_func_scope): Update.
1058 (process_enumeration_scope): Update.
1059 (new_symbol): Update.
1060 (dwarf2_const_value): Update.
1061 (dwarf2_symbol_mark_computed): Update.
1062 * eval.c (evaluate_funcall): Update.
1063 (evaluate_subexp_standard): Update.
1064 * expprint.c (print_subexp_standard): Update.
1065 (dump_subexp_body_standard): Update.
1066 * f-valprint.c (info_common_command_for_block): Update.
1067 * findvar.c (get_hosting_frame): Update.
1068 (default_read_var_value): Update.
1069 * go-lang.c (go_symbol_package_name): Update.
1070 * guile/scm-block.c (bkscm_print_block_smob): Update.
1071 * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1072 (gdbscm_symbol_name): Update.
1073 (gdbscm_symbol_linkage_name): Update.
1074 (gdbscm_symbol_print_name): Update.
1075 * infcall.c (get_function_name): Update.
1076 * infcmd.c (jump_command): Update.
1077 (finish_command): Update.
1078 * infrun.c (insert_exception_resume_breakpoint): Update.
1079 * linespec.c (canonicalize_linespec): Update.
1080 (create_sals_line_offset): Update.
1081 (convert_linespec_to_sals): Update.
1082 (complete_label): Update.
1083 (find_label_symbols_in_block): Update.
1084 * m2-typeprint.c (m2_print_typedef): Update.
1085 * mdebugread.c (mdebug_reg_to_regnum): Update.
1086 (parse_symbol): Update.
1087 (mylookup_symbol): Update.
1088 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1089 (list_args_or_locals): Update.
1090 * objc-lang.c (compare_selectors): Update.
1091 (info_selectors_command): Update.
1092 (compare_classes): Update.
1093 (info_classes_command): Update.
1094 (find_imps): Update.
1095 * p-typeprint.c (pascal_print_typedef): Update.
1096 * printcmd.c (build_address_symbolic): Update.
1097 (info_address_command): Update.
1098 (print_variable_and_value): Update.
1099 * python/py-framefilter.c (extract_sym): Update.
1100 (py_print_single_arg): Update.
1101 * python/py-symbol.c (sympy_str): Update.
1102 (sympy_get_name): Update.
1103 (sympy_get_linkage_name): Update.
1104 * python/python.c (gdbpy_rbreak): Update.
1105 * record-btrace.c (btrace_get_bfun_name): Update.
1106 (btrace_call_history): Update.
1107 * rust-lang.c (rust_print_typedef): Update.
1108 * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1109 * stabsread.c (stab_reg_to_regnum): Update.
1110 (define_symbol): Update.
1111 (read_enum_type): Update.
1112 (common_block_end): Update.
1113 (cleanup_undefined_types_1): Update.
1114 (scan_file_globals): Update.
1115 * stack.c (print_frame_arg): Update.
1116 (print_frame_args): Update.
1117 (find_frame_funname): Update.
1118 (info_frame_command_core): Update.
1119 (iterate_over_block_locals): Update.
1120 (print_block_frame_labels): Update.
1121 (do_print_variable_and_value): Update.
1122 (iterate_over_block_arg_vars): Update.
1123 (return_command): Update.
1124 * symmisc.c (dump_symtab_1): Update.
1125 (print_symbol): Update.
1126 * symtab.c (eq_symbol_entry): Update.
1127 (symbol_cache_dump): Update.
1128 (lookup_language_this): Update.
1129 (find_pc_sect_line): Update.
1130 (skip_prologue_sal): Update.
1131 (symbol_search::compare_search_syms): Update.
1132 (treg_matches_sym_type_name): Update.
1133 (search_symbols): Update.
1134 (print_symbol_info): Update.
1135 (rbreak_command): Update.
1136 (completion_list_add_symbol): Update.
1137 (find_gnu_ifunc): Update.
1138 (get_symbol_address): Update.
1139 (search_module_symbols): Update.
1140 (info_module_subcommand): Update.
1141 * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1142 (SYMBOL_LINKAGE_NAME): Remove.
1143 (SYMBOL_DEMANGLED_NAME): Remove.
1144 (SYMBOL_PRINT_NAME): Remove.
1145 (SYMBOL_SEARCH_NAME): Remove.
1146 * tracepoint.c (set_traceframe_context): Update.
1147 (validate_actionline): Update.
1148 (collection_list::collect_symbol): Update.
1149 (encode_actions_1): Update.
1150 (info_scope_command): Update.
1151 (print_one_static_tracepoint_marker): Update.
1152 * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1153 * valops.c (address_of_variable): Update.
1154 (find_overload_match): Update.
1155 (find_oload_champ): Update.
1156
1157 2019-11-22 Christian Biesinger <cbiesinger@google.com>
1158
1159 * ada-lang.c (ada_lookup_simple_minsym): Update.
1160 (ada_collect_symbol_completion_matches): Update.
1161 * ada-tasks.c (read_atcb): Update.
1162 * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1163 (amd64_windows_skip_trampoline_code): Update.
1164 * arm-tdep.c (skip_prologue_function): Update.
1165 (arm_skip_stack_protector): Update.
1166 * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1167 (arm_wince_skip_main_prologue): Update.
1168 * ax-gdb.c (gen_expr): Update.
1169 * block.c (call_site_for_pc): Update.
1170 * blockframe.c (find_pc_partial_function): Update.
1171 * breakpoint.c (set_breakpoint_location_function): Update.
1172 * btrace.c (ftrace_print_function_name): Update.
1173 (ftrace_function_switched): Update.
1174 * c-valprint.c (print_unpacked_pointer): Update.
1175 * coffread.c (coff_symfile_read): Update.
1176 * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1177 * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1178 * dwarf-index-write.c (write_psymbols): Update.
1179 * dwarf2loc.c (call_site_to_target_addr): Update.
1180 (func_verify_no_selftailcall): Update.
1181 (tailcall_dump): Update.
1182 (call_site_find_chain_1): Update.
1183 (dwarf_expr_reg_to_entry_parameter): Update.
1184 * elfread.c (elf_gnu_ifunc_record_cache): Update.
1185 * eval.c (evaluate_funcall): Update.
1186 (evaluate_subexp_standard): Update.
1187 (evaluate_subexp_for_sizeof): Update.
1188 * expprint.c (print_subexp_standard): Update.
1189 (dump_subexp_body_standard): Update.
1190 * frame.c (get_prev_frame_always_1): Update.
1191 * frv-tdep.c (frv_skip_main_prologue): Update.
1192 * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1193 * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1194 (gnuv3_get_typename_from_type_info): Update.
1195 (gnuv3_skip_trampoline): Update.
1196 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1197 * i386-tdep.c (i386_skip_main_prologue): Update.
1198 (i386_pe_skip_trampoline_code): Update.
1199 * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1200 * infcall.c (get_function_name): Update.
1201 * linespec.c (minsym_found): Update.
1202 * linux-fork.c (info_checkpoints_command): Update.
1203 * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1204 (m32c_m16c_pointer_to_address): Update.
1205 * maint.c (maintenance_translate_address): Update.
1206 * minsyms.c (add_minsym_to_hash_table): Update.
1207 (add_minsym_to_demangled_hash_table): Update.
1208 (lookup_minimal_symbol_mangled): Update.
1209 (lookup_minimal_symbol_demangled): Update.
1210 (lookup_minimal_symbol_linkage): Update.
1211 (lookup_minimal_symbol_text): Update.
1212 (lookup_minimal_symbol_by_pc_name): Update.
1213 (minimal_symbol_is_less_than): Update.
1214 (compact_minimal_symbols): Update.
1215 (build_minimal_symbol_hash_tables): Update.
1216 (find_solib_trampoline_target): Update.
1217 * mips-tdep.c (mips_stub_frame_sniffer): Update.
1218 (mips_skip_pic_trampoline_code): Update.
1219 * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1220 * objc-lang.c (info_selectors_command): Update.
1221 (info_classes_command): Update.
1222 (find_methods): Update.
1223 (find_imps): Update.
1224 * p-valprint.c (pascal_val_print): Update.
1225 * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1226 * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1227 * printcmd.c (build_address_symbolic): Update.
1228 (info_symbol_command): Update.
1229 * psymtab.c (psymbol_name_matches): Update.
1230 (match_partial_symbol): Update.
1231 (lookup_partial_symbol): Update.
1232 (print_partial_symbols): Update.
1233 (sort_pst_symbols): Update.
1234 (maintenance_check_psymtabs): Update.
1235 * python/py-framefilter.c (py_print_frame): Update.
1236 * python/python.c (gdbpy_rbreak): Update.
1237 * record-btrace.c (btrace_get_bfun_name): Update.
1238 (btrace_call_history): Update.
1239 * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1240 (rs6000_skip_trampoline_code): Update.
1241 * sol-thread.c (info_cb): Update.
1242 * stabsread.c (scan_file_globals): Update.
1243 * stack.c (find_frame_funname): Update.
1244 (info_frame_command_core): Update.
1245 * symmisc.c (dump_msymbols): Update.
1246 * symtab.c (symbol_natural_name): Rename to..,
1247 (general_symbol_info::natural_name): ...this.
1248 (symbol_demangled_name): Rename to...
1249 (general_symbol_info::demangled_name): ...this.
1250 (symbol_search_name): Rename to...
1251 (general_symbol_info::search_name): ...this.
1252 (symbol_matches_search_name): Update.
1253 (find_pc_sect_line): Update.
1254 (skip_prologue_sal): Update.
1255 (search_symbols): Update.
1256 (print_msymbol_info): Update.
1257 (rbreak_command): Update.
1258 (completion_list_add_msymbol): Update.
1259 (completion_list_objc_symbol): Update.
1260 (get_msymbol_address): Update.
1261 * symtab.h (struct general_symbol_info): Add member functions
1262 natural_name (), linkage_name (), print_name (), demangled_name (),
1263 and search_name ().
1264 (SYMBOL_NATURAL_NAME): Update.
1265 (symbol_natural_name): Move to a member function on general_symbol_info.
1266 (SYMBOL_DEMANGLED_NAME): Update.
1267 (symbol_demangled_name): Move to a member function on
1268 general_symbol_info.
1269 (SYMBOL_SEARCH_NAME): Update.
1270 (symbol_search_name): Move to a member function on general_symbol_info.
1271 (MSYMBOL_NATURAL_NAME): Remove.
1272 (MSYMBOL_LINKAGE_NAME): Remove.
1273 (MSYMBOL_PRINT_NAME): Remove.
1274 (MSYMBOL_DEMANGLED_NAME): Remove.
1275 (MSYMBOL_SEARCH_NAME): Remove.
1276 * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
1277
1278 2019-11-22 Christian Biesinger <cbiesinger@google.com>
1279
1280 * symtab.c (create_demangled_names_hash): Use per_bfd->
1281 minimal_symbol_count for computing the initial size, if greater
1282 than our default size.
1283
1284 2019-11-22 Tom de Vries <tdevries@suse.de>
1285
1286 * contrib/words.sh: Improve words extraction.
1287
1288 2019-11-22 Tom de Vries <tdevries@suse.de>
1289
1290 * contrib/words.sh: Combine sed invocations.
1291
1292 2019-11-21 Christian Biesinger <cbiesinger@google.com>
1293
1294 * Makefile.in: Update.
1295 * demangle.c: Rename to...
1296 * gdb-demangle.c: ..this.
1297 (is_cplus_marker): Change return type to bool.
1298 (_initialize_demangler): Rename to...
1299 (_initialize_gdb_demangle): ...this.
1300 * gdb-demangle.h (is_cplus_marker): Change return type to bool.
1301 * symtab.h (demangle): Remove declaration; instead include
1302 gdb-demangle.h.
1303
1304 2019-11-21 Tom Tromey <tromey@adacore.com>
1305
1306 * gdbsupport/format.c (format_pieces): Parse %I64d.
1307 * unittests/format_pieces-selftests.c (test_windows_formats): New
1308 function.
1309 (run_tests): Call it.
1310
1311 2019-11-21 Peeter Joot <peeter.joot@lzlabs.com>
1312
1313 Byte reverse display of variables with DW_END_big, DW_END_little
1314 (DW_AT_endianity) dwarf attributes if different than the native
1315 byte order.
1316 * ada-lang.c (ada_value_binop):
1317 Use type_byte_order instead of gdbarch_byte_order.
1318 * ada-valprint.c (printstr):
1319 (ada_val_print_string):
1320 * ada-lang.c (value_pointer):
1321 (ada_value_binop):
1322 Use type_byte_order instead of gdbarch_byte_order.
1323 * c-lang.c (c_get_string):
1324 Use type_byte_order instead of gdbarch_byte_order.
1325 * c-valprint.c (c_val_print_array):
1326 Use type_byte_order instead of gdbarch_byte_order.
1327 * cp-valprint.c (cp_print_class_member):
1328 Use type_byte_order instead of gdbarch_byte_order.
1329 * dwarf2loc.c (rw_pieced_value):
1330 Use type_byte_order instead of gdbarch_byte_order.
1331 * dwarf2read.c (read_base_type): Handle DW_END_big,
1332 DW_END_little
1333 * f-lang.c (f_get_encoding):
1334 Use type_byte_order instead of gdbarch_byte_order.
1335 * findvar.c (default_read_var_value):
1336 Use type_byte_order instead of gdbarch_byte_order.
1337 * gdbtypes.c (check_types_equal):
1338 Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
1339 (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
1340 and TYPE_ENDIANITY_LITTLE if set.
1341 (type_byte_order): new function.
1342 * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
1343 (struct main_type) <flag_endianity_not_default>:
1344 New field.
1345 (type_byte_order): New function.
1346 * infcmd.c (default_print_one_register_info):
1347 Use type_byte_order instead of gdbarch_byte_order.
1348 * p-lang.c (pascal_printstr):
1349 Use type_byte_order instead of gdbarch_byte_order.
1350 * p-valprint.c (pascal_val_print):
1351 Use type_byte_order instead of gdbarch_byte_order.
1352 * printcmd.c (print_scalar_formatted):
1353 Use type_byte_order instead of gdbarch_byte_order.
1354 * solib-darwin.c (darwin_current_sos):
1355 Use type_byte_order instead of gdbarch_byte_order.
1356 * solib-svr4.c (solib_svr4_r_ldsomap):
1357 Use type_byte_order instead of gdbarch_byte_order.
1358 * stap-probe.c (stap_modify_semaphore):
1359 Use type_byte_order instead of gdbarch_byte_order.
1360 * target-float.c (target_float_same_format_p):
1361 Use type_byte_order instead of gdbarch_byte_order.
1362 * valarith.c (scalar_binop):
1363 (value_bit_index):
1364 Use type_byte_order instead of gdbarch_byte_order.
1365 * valops.c (value_cast):
1366 Use type_byte_order instead of gdbarch_byte_order.
1367 * valprint.c (generic_emit_char):
1368 (generic_printstr):
1369 (val_print_string):
1370 Use type_byte_order instead of gdbarch_byte_order.
1371 * value.c (unpack_long):
1372 (unpack_bits_as_long):
1373 (unpack_value_bitfield):
1374 (modify_field):
1375 (pack_long):
1376 (pack_unsigned_long):
1377 Use type_byte_order instead of gdbarch_byte_order.
1378 * findvar.c (unsigned_pointer_to_address):
1379 (signed_pointer_to_address):
1380 (unsigned_address_to_pointer):
1381 (address_to_signed_pointer):
1382 (default_read_var_value):
1383 (default_value_from_register):
1384 Use type_byte_order instead of gdbarch_byte_order.
1385 * gnu-v3-abi.c (gnuv3_make_method_ptr):
1386 Use type_byte_order instead of gdbarch_byte_order.
1387 * riscv-tdep.c (riscv_print_one_register_info):
1388 Use type_byte_order instead of gdbarch_byte_order.
1389
1390 2019-11-21 Simon Marchi <simon.marchi@polymtl.ca>
1391
1392 * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
1393 (current_ui_gdb_stdin_ptr): Likewise.
1394 (current_ui_gdb_stderr_ptr): Likewise.
1395 (current_ui_gdb_stdlog_ptr): Likewise.
1396 (current_ui_current_uiout_ptr): Likewise.
1397 (gen_ret_current_ui_field_ptr): Remove.
1398
1399 2019-11-21 Tom de Vries <tdevries@suse.de>
1400
1401 PR gdb/24956
1402 * cli/cli-script.c (execute_control_command): Only switch to
1403 INTERP_CONSOLE's ui_out when INTERP_MI is active.
1404
1405 2019-11-19 Tom Tromey <tom@tromey.com>
1406
1407 * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
1408 Now static. Change type of "name".
1409 (tui_set_win_height_command): Don't copy "arg".
1410 * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
1411 * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
1412
1413 2019-11-19 Ali Tamur <tamur@google.com>
1414
1415 * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
1416 "if (attr != nullptr)".
1417 (dwarf2_find_base_address): Likewise.
1418 (dwarf2_build_include_psymtabs): Likewise.
1419 (read_cutu_die_from_dwo): Likewise.
1420 (read_func_scope): Likewise.
1421 (read_call_site_scope): Likewise.
1422 (dwarf2_get_pc_bounds): Likewise.
1423 (dwarf2_record_block_ranges): Likewise.
1424 (dwarf2_add_field): Likewise.
1425 (dwarf2_add_member_fn): Likewise.
1426 (read_structure_type): Likewise.
1427 (read_enumeration_type): Likewise.
1428 (read_array_type): Likewise.
1429 (read_array_order): Likewise.
1430 (read_set_type): Likewise.
1431 (read_common_block): Likewise.
1432 (read_tag_reference_type): Likewise.
1433 (read_tag_string_type): Likewise.
1434 (read_subroutine_type): Likewise.
1435 (read_base_type): Likewise.
1436 (read_subrange_type): Likewise.
1437 (new_symbol): Likewise.
1438 (prepare_one_comp_unit): Likewise.
1439
1440 2019-11-19 Tom Tromey <tromey@adacore.com>
1441
1442 * windows-nat.c (windows_nat_target::attach): Include GetLastError
1443 result in error when DebugActiveProcess fails.
1444
1445 2019-11-18 Sergio Durigan Junior <sergiodj@redhat.com>
1446 Pedro Alves <palves@redhat.com>
1447
1448 https://bugzilla.redhat.com/show_bug.cgi?id=1765117
1449 * target.c (target_stack::push): Call 'unpush' if there's a
1450 target on top of the stack.
1451
1452 2019-11-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1453
1454 * python/py-block.c (blpy_dealloc): Call tp_free.
1455 (blpy_block_syms_dealloc): Likewise.
1456 * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
1457 * python/py-inferior.c (infpy_dealloc): Likewise.
1458 * python/py-lazy-string.c (stpy_dealloc): Likewise.
1459 * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
1460 * python/py-symbol.c (sympy_dealloc): Likewise.
1461 * python/py-symtab.c (stpy_dealloc): Likewise.
1462 * python/py-type.c (typy_iterator_dealloc): Likewise.
1463
1464 2019-11-18 Christian Biesinger <cbiesinger@google.com>
1465
1466 * symtab.h (struct symbol) <owner>: Initialize explicitly in the
1467 constructor instead of using a class initializer.
1468
1469 2019-11-15 Christian Biesinger <cbiesinger@google.com>
1470
1471 * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
1472 * configure: Regenerate.
1473 * configure.ac: Don't source common.host.
1474 * gdbsupport/common.host: Remove.
1475 * gdbsupport/mingw-strerror.c: Remove.
1476 * gdbsupport/posix-strerror.c: Rename to...
1477 * gdbsupport/safe-strerror.c: ...this.
1478
1479 2019-11-15 Christian Biesinger <cbiesinger@google.com>
1480
1481 * maint.c (scoped_command_stats::print_time): Use localtime_r
1482 instead of localtime (provided through gnulib if necessary).
1483 * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
1484 of ctime.
1485
1486 2019-11-15 Christian Biesinger <cbiesinger@google.com>
1487
1488 * gdbsupport/common-defs.h: Include time.h before pathmax.h to
1489 avoid compile errors.
1490
1491 2019-11-15 Christian Biesinger <cbiesinger@google.com>
1492
1493 * config.in: Regenerate.
1494 * configure: Regenerate.
1495 * gdbsupport/common.m4: No longer check for strerror_r.
1496 * gdbsupport/posix-strerror.c (safe_strerror): Always call the
1497 POSIX version of strerror_r, now that gnulib provides it if
1498 necessary.
1499
1500 2019-11-14 Christian Biesinger <cbiesinger@google.com>
1501
1502 * README (`configure' options): Update.
1503
1504 2019-11-14 Tom Tromey <tromey@adacore.com>
1505
1506 * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
1507 expected type for the RHS if the LHS is a convenience variable.
1508
1509 2019-11-14 Simon Marchi <simon.marchi@polymtl.ca>
1510
1511 * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
1512 Provide explicit default and copy constructor.
1513
1514 2019-11-14 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1515
1516 * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
1517 only call Py_INCREF (newbp) in the bppy_pending_object case.
1518
1519 2019-11-13 Tom Tromey <tromey@adacore.com>
1520
1521 PR build/25182:
1522 * psympriv.h (partial_symbol): Remove static assert.
1523 * symtab.h (general_symbol_info, symbol): Remove static assert.
1524
1525 2019-11-12 Andrew Burgess <andrew.burgess@embecosm.com>
1526
1527 * gdbsupport/format.c (format_pieces::format_pieces): Support
1528 printf 'z' size modifier.
1529 * gdbsupport/format.h (enum argclass): Add size_t_arg.
1530 * printcmd.c (ui_printf): Handle size_t_arg.
1531 * ui-out.c (ui_out::vmessage): Likewise.
1532 * unittests/format_pieces-selftests.c (test_format_int_sizes): New
1533 function.
1534 (run_tests): Call test_format_int_sizes.
1535
1536 2019-11-12 Christian Biesinger <cbiesinger@google.com>
1537
1538 * ada-exp.y (write_ambiguous_var): Update.
1539 * buildsym.c (add_symbol_to_list): Update.
1540 * dwarf2read.c (read_variable): Update.
1541 (new_symbol): Update.
1542 * jit.c (finalize_symtab): Update.
1543 * language.c (language_alloc_type_symbol): Update.
1544 * symtab.c (fixup_symbol_section): Update.
1545 (initialize_objfile_symbol_1): Move code to...
1546 (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
1547 (allocate_symbol): Update.
1548 (allocate_template_symbol): Update.
1549 (get_symbol_address): Update.
1550 * symtab.h (struct symbol): Inherit from general_symbol_info instead
1551 of having as a field, and add a constructor.
1552 (SYMBOL_VALUE): Update.
1553 (SYMBOL_VALUE_ADDRESS): Update.
1554 (SET_SYMBOL_VALUE_ADDRESS): Update.
1555 (SYMBOL_VALUE_BYTES): Update.
1556 (SYMBOL_VALUE_COMMON_BLOCK): Update.
1557 (SYMBOL_BLOCK_VALUE): Update.
1558 (SYMBOL_VALUE_CHAIN): Update.
1559 (SYMBOL_LANGUAGE): Update.
1560 (SYMBOL_SECTION): Update.
1561 (SYMBOL_OBJ_SECTION): Update.
1562 (SYMBOL_SET_LANGUAGE): Update.
1563 (SYMBOL_SET_LINKAGE_NAME): Update.
1564 (SYMBOL_SET_NAMES): Update.
1565 (SYMBOL_NATURAL_NAME): Update.
1566 (SYMBOL_LINKAGE_NAME): Update.
1567 (SYMBOL_DEMANGLED_NAME): Update.
1568 (SYMBOL_SEARCH_NAME): Update.
1569 (SYMBOL_MATCHES_SEARCH_NAME): Update.
1570 (struct symbol): Update.
1571 (struct template_symbol): Update.
1572 (struct rust_vtable_symbol): Update.
1573 * xcoffread.c (SYMBOL_DUP): Update.
1574
1575 2019-11-12 Tom Tromey <tom@tromey.com>
1576
1577 * tui/tui-layout.c (show_layout): Set current_layout.
1578 (show_source_disasm_command, show_data)
1579 (show_source_or_disasm_and_command): Don't set current_layout.
1580
1581 2019-11-12 Tom Tromey <tom@tromey.com>
1582
1583 * tui/tui-layout.c (_initialize_tui_layout): Move to end.
1584
1585 2019-11-12 Tom Tromey <tom@tromey.com>
1586
1587 * tui/tui-win.c (resize_message): New global.
1588 (show_tui_resize_message): New function.
1589 (tui_async_resize_screen): Print message if requested.
1590 (_initialize_tui_win): Add tui-resize-message setting.
1591 * NEWS: Add entry for new commands.
1592
1593 2019-11-11 Tom Tromey <tom@tromey.com>
1594
1595 * tui/tui.c (tui_initialize_readline): Add new bindable readline
1596 functions.
1597
1598 2019-11-11 Christian Biesinger <cbiesinger@google.com>
1599
1600 * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
1601
1602 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1603
1604 * python/py-symbol.c (gdbpy_lookup_static_symbols): New
1605 function.
1606 * python/python-internal.h (gdbpy_lookup_static_symbols):
1607 Declare new function.
1608 * python/python.c (python_GdbMethods): Add
1609 gdb.lookup_static_symbols method.
1610 * NEWS: Mention gdb.lookup_static_symbols.
1611
1612 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1613
1614 * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
1615 static block of current object file first. Also fix typo in
1616 header comment.
1617
1618 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1619
1620 * stack.c (set_last_displayed_sal): Delete.
1621 (last_displayed_sal_valid): Delete.
1622 (last_displayed_pspace): Delete.
1623 (last_displayed_addr): Delete.
1624 (last_displayed_symtab): Delete.
1625 (last_displayed_line): Delete.
1626 (class last_displayed_symtab_info_type): New.
1627 (last_displayed_symtab_info): New static global variable.
1628 (print_frame_info): Call methods on last_displayed_symtab_info.
1629 (clear_last_displayed_sal): Update header comment, and make use of
1630 last_displayed_symtab_info.
1631 (last_displayed_sal_is_valid): Likewise.
1632 (get_last_displayed_pspace): Likewise.
1633 (get_last_displayed_addr): Likewise.
1634 (get_last_displayed_symtab): Likewise.
1635 (get_last_displayed_line): Likewise.
1636 (get_last_displayed_sal): Likewise.
1637 * stack.h (clear_last_displayed_sal): Update header comment.
1638 (last_displayed_sal_is_valid): Likewise.
1639 (get_last_displayed_pspace): Likewise.
1640 (get_last_displayed_addr): Likewise.
1641 (get_last_displayed_symtab): Likewise.
1642 (get_last_displayed_line): Likewise.
1643 (get_last_displayed_sal): Likewise.
1644
1645 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1646
1647 * stack.c (frame_show_address): Convert return type to bool.
1648 * stack.h (frame_show_address): Likewise, and update header
1649 comment.
1650
1651 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1652
1653 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
1654 * unittests/vec-utils-selftests.c: New file.
1655 * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
1656
1657 2019-11-10 Tom Tromey <tom@tromey.com>
1658
1659 * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
1660 (tui_highlight_win): Likewise.
1661 (tui_win_info::check_and_display_highlight_if_needed): Likewise.
1662 * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
1663 * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
1664 Don't set can_highlight.
1665
1666 2019-11-10 Tom Tromey <tom@tromey.com>
1667
1668 * cli/cli-style.h (class cli_style_option) <cli_style_option>:
1669 Remove unused declaration.
1670
1671 2019-11-08 Tom Tromey <tromey@adacore.com>
1672
1673 * top.c (read_command_file): Update.
1674 (command_line_input): Make return type const.
1675 * python/py-gdb-readline.c: Update.
1676 * linespec.c (decode_line_2): Update.
1677 * defs.h (command_line_input): Make return type const.
1678 * cli/cli-script.c (read_next_line): Make return type const.
1679 * ada-lang.c (get_selections): Update.
1680
1681 2019-11-06 Christian Biesinger <cbiesinger@google.com>
1682
1683 * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
1684 * mi/mi-main.c (output_cores): Likewise.
1685 * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
1686 (linux_xfer_osdata_modules): Likewise.
1687 * remote.c (register_remote_support_xml): Likewise.
1688 * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
1689 * xml-syscall.c (syscall_create_syscall_desc): Likewise.
1690
1691 2019-11-06 Tom Tromey <tom@tromey.com>
1692
1693 * tui/tui-interp.c: Don't include readline.h.
1694 * tui/tui-hooks.c: Don't include readline.h.
1695 * symmisc.c: Include tilde.h, not readline.h.
1696 * symfile.c: Include tilde.h, not readline.h.
1697 * source.c: Include tilde.h, not readline.h.
1698 * solib.c: Include tilde.h, not readline.h.
1699 * psymtab.c: Include tilde.h, not readline.h.
1700 * exec.c: Include tilde.h, not readline.h.
1701 * corelow.c: Include tilde.h, not readline.h.
1702 * cli/cli-dump.c: Include tilde.h, not readline.h.
1703 * cli/cli-cmds.c: Don't include readline.h.
1704
1705 2019-11-05 Tom Tromey <tom@tromey.com>
1706
1707 * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
1708 (tui_disassemble): Set addr_size.
1709 (tui_disasm_window::set_contents): Use addr_size.
1710
1711 2019-11-05 Tom Tromey <tom@tromey.com>
1712
1713 * rust-lang.c (rust_language_defn): Update.
1714 * python/py-value.c (valpy_string): Call c_get_string.
1715 * p-lang.c (pascal_language_defn): Update.
1716 * opencl-lang.c (opencl_language_defn): Update.
1717 * objc-lang.c (objc_language_defn): Update.
1718 * m2-lang.c (m2_language_defn): Update.
1719 * language.c (unknown_language_defn, auto_language_defn): Update.
1720 (default_get_string): Remove.
1721 * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
1722 * go-lang.c (go_language_defn): Update.
1723 * f-lang.c (f_language_defn): Update.
1724 * d-lang.c (d_language_defn): Update.
1725 * c-lang.c (c_language_defn, cplus_language_defn)
1726 (asm_language_defn, minimal_language_defn): Update.
1727 * ada-lang.c (ada_language_defn): Update.
1728 * language.h (struct language_defn) <la_get_string>: Remove.
1729 (LA_GET_STRING): Remove.
1730 (default_get_string): Don't declare.
1731
1732 2019-11-05 Tom Tromey <tom@tromey.com>
1733
1734 * tui/tui-source.h (struct tui_source_window): Inline
1735 constructor. Remove destructor.
1736 <style_changed, m_observable>: Move to superclass.
1737 * tui/tui-winsource.h (tui_copy_source_line): Declare.
1738 (struct tui_source_window_base): Move private members to end.
1739 <style_changed, m_observable>: Move from tui_source_window.
1740 * tui/tui-winsource.c (tui_copy_source_line): Move from
1741 tui-source.c. Rename from copy_source_line. Add special handling
1742 for negative line number.
1743 (tui_source_window_base::style_changed): Move from
1744 tui_source_window.
1745 (tui_source_window_base): Register observer.
1746 (~tui_source_window_base): New.
1747 * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
1748 rename.
1749 (tui_source_window::set_contents): Use tui_copy_source_line.
1750 (tui_source_window::tui_source_window): Move to tui-source.h.
1751 (tui_source_window::~tui_source_window): Remove.
1752 (tui_source_window::style_changed): Move to superclass.
1753 * tui/tui-disasm.c (tui_disassemble): Create string file with
1754 styling, when possible. Add "addr_size" parameter.
1755 (tui_disasm_window::set_contents): Use tui_copy_source_line.
1756 Don't compute maximum size.
1757 (len_without_escapes): New function
1758
1759 2019-11-05 Tom Tromey <tom@tromey.com>
1760
1761 * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
1762 std::string.
1763 * tui/tui-winsource.c (tui_show_source_line): Update.
1764 * tui/tui-source.c (tui_source_window::set_contents): Update.
1765 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1766
1767 2019-11-05 Christian Biesinger <cbiesinger@google.com>
1768
1769 * symtab.h (gdb_static_assert): Put && operator at the beginning
1770 of the line instead of the end.
1771
1772 2019-11-04 Christian Biesinger <cbiesinger@google.com>
1773
1774 * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
1775 and sizeof (symbol).
1776 * symtab.h: Add a static_assert for sizeof (partial_symbol).
1777
1778 2019-11-04 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
1779
1780 * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
1781 * configure.host: Mark *-*-solaris2.10* obsolete.
1782 * configure.tgt: Mark Solaris < 11 obsolete.
1783 * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
1784 Update target triplet.
1785
1786 2019-11-01 Tom Tromey <tromey@adacore.com>
1787
1788 * utils.c (print_sys_errmsg): Simplify.
1789
1790 2019-11-01 Tom Tromey <tromey@adacore.com>
1791
1792 * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
1793
1794 2019-11-01 Christian Biesinger <cbiesinger@google.com>
1795
1796 * configure: Regenerate.
1797 * configure.ac: Remove check for strerror_r.
1798 * gdbsupport/common.m4: Check for strerror_r.
1799
1800 2019-11-01 Luis Machado <luis.machado@linaro.org>
1801
1802 PR gdb/25124
1803
1804 * arm-tdep.c (arm_per_objfile): Rename to ...
1805 (arm_per_bfd): ... this.
1806 (arm_objfile_data_key): Rename to ...
1807 (arm_bfd_data_key): ... this.
1808 (arm_find_mapping_symbol): Adjust access to new bfd_key-based
1809 data.
1810 (arm_record_special_symbol): Likewise.
1811
1812 2019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
1813
1814 * ada-typeprint.c (ada_print_typedef): Don't print newline at the
1815 end.
1816 * c-typeprint.c (c_print_typedef): Likewise.
1817 * f-typeprint.c (f_print_typedef): Likewise.
1818 * m2-typeprint.c (m2_print_typedef): Likewise.
1819 * p-typeprint.c (pascal_print_typedef): Likewise.
1820 * rust-lang.c (rust_print_typedef): Likewise.
1821 * symtab.c (print_symbol_info): Print a newline after calling
1822 typedef_print.
1823
1824 2019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
1825
1826 * symtab.c (info_module_cmdlist): New variable.
1827 (info_module_command): New function.
1828 (search_module_symbols): New function.
1829 (info_module_subcommand): New function.
1830 (struct info_modules_var_func_options): New struct.
1831 (info_modules_var_func_options_defs): New variable.
1832 (make_info_modules_var_func_options_def_group): New function.
1833 (info_module_functions_command): New function.
1834 (info_module_variables_command): New function.
1835 (info_module_var_func_command_completer): New function.
1836 (_initialize_symtab): Register new 'info module functions' and
1837 'info module variables' commands.
1838 * symtab.h (typedef symbol_search_in_module): New typedef.
1839 (search_module_symbols): Declare new function.
1840 * NEWS: Mention new commands.
1841
1842 2019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
1843
1844 * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
1845 (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
1846 (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
1847 MODULES_DOMAIN.
1848 (scan_partial_symbols): Only create partial module symbols for non
1849 declarations.
1850 * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
1851 and MODULES_DOMAIN.
1852 * symtab.c (search_domain_name): Likewise.
1853 (search_symbols): Likewise.
1854 (print_symbol_info): Likewise.
1855 (symtab_symbol_info): Likewise.
1856 (info_modules_command): New function.
1857 (_initialize_symtab): Register 'info modules' command.
1858 * symtab.h (enum search_domain): Add MODULES_DOMAIN.
1859 * NEWS: Mention new 'info modules' command.
1860
1861 2019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1862
1863 * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
1864 and $_gdb_maint_setting_str.
1865
1866 2019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1867
1868 * cli/cli-cmds.c (setting_cmd, value_from_setting)
1869 (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
1870 (str_value_from_setting, gdb_setting_str_internal_fn)
1871 (gdb_maint_setting_str_internal_fn): New functions.
1872 (_initialize_cli_cmds): Define the new convenience functions.
1873 * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
1874 * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
1875
1876 2019-10-31 Christian Biesinger <cbiesinger@google.com>
1877
1878 * agent.c (set_can_use_agent): When the setting is turned on,
1879 look up agent symbols if we don't have them yet.
1880 (agent_new_objfile): Don't look up agent symbols when the agent
1881 setting is off.
1882
1883 2019-10-31 Christian Biesinger <cbiesinger@google.com>
1884
1885 * config.in: Regenerate.
1886
1887 2019-10-31 Christian Biesinger <cbiesinger@google.com>
1888
1889 * configure: Regenerate.
1890 * configure.ac: Check for strerror_r.
1891 * gdbsupport/common-utils.h (safe_strerror): Change return value
1892 to const char * and document that this function is now threadsafe.
1893 * gdbsupport/posix-strerror.c (safe_strerror): Make buf
1894 thread_local and call strerror_r, if available.
1895 * utils.c (perror_string): Update.
1896 (print_sys_errmsg): Update.
1897
1898 2019-10-31 Luis Machado <luis.machado@linaro.org>
1899
1900 * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
1901 objfile_key.
1902 (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
1903 objfile to fetch per-bfd data.
1904 (arm_find_exidx_entry): Likewise.
1905
1906 2019-10-31 Christian Biesinger <cbiesinger@google.com>
1907
1908 * gdbsupport/agent.c (debug_agent): Change type to bool.
1909 (use_agent): Likewise.
1910 (all_agent_symbols_look_up): Likewise.
1911 (agent_loaded_p): Change return value to bool.
1912 (agent_look_up_symbols): Update.
1913 (agent_capability_check): Change return value to bool.
1914 * gdbsupport/agent.h (agent_loaded_p): Likewise.
1915 (debug_agent): Change type to bool.
1916 (use_agent): Likewise.
1917 (agent_capability_check): Change return value to bool.
1918
1919 2019-10-30 Christian Biesinger <cbiesinger@google.com>
1920
1921 * minsyms.c (clear_minimal_symbol_hash_tables): New function.
1922 (build_minimal_symbol_hash_tables): Code to clear the table moved
1923 to clear_minimal_symbol_hash_tables.
1924 (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
1925 when needed.
1926
1927 2019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
1928
1929 * infcmd.c: Remove includes.
1930 * infrun.c: Remove includes.
1931
1932 2019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
1933
1934 * ada-lang.h (GROW_VECT): Move to ada-lang.c.
1935 (grow_vect): Remove declaration.
1936 (ada_type_of_array): Remove declaration.
1937 (ada_update_initial_language): Remove declaration.
1938 (ada_fold_name): Remove declaration.
1939 (ada_fill_in_ada_prototype): Remove declaration.
1940 (user_select_syms): Remove declaration.
1941 (get_selections): Remove declaration.
1942 (ada_tag_type): Remove declaration.
1943 (ada_value_tag): Remove declaration.
1944 (ada_is_others_clause): Remove declaration.
1945 (ada_in_variant): Remove declaration.
1946 (ada_value_struct_elt): Remove declaration.
1947 (ada_attribute_name): Remove declaration.
1948 (ada_system_address_type): Remove declaration.
1949 * ada-lang.c (ada_watch_location_expression): Make static.
1950 (GROW_VECT): Move here from ada-lang.h.
1951 (grow_vect): Make static.
1952 (ada_update_initial_language): Make static.
1953 (ada_fold_name): Make static.
1954 (ada_type_of_array): Make static.
1955 (encoded_ordered_before): Move up.
1956 (sort_choices): Move up.
1957 (print_signatures): Move up.
1958 (ada_print_symbol_signature): Move up.
1959 (get_selections): Move up and make static.
1960 (user_select_syms): Move up and make static.
1961 (ada_value_struct_elt): Move up and make static.
1962 (ada_tag_type): Make static.
1963 (ada_value_tag): Make static.
1964 (ada_is_others_clause): Make static.
1965 (ada_in_variant): Make static.
1966 (ada_attribute_name): Make static.
1967
1968 2019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
1969
1970 * ada-lang.c: Remove includes.
1971 * ada-typeprint.c: Remove includes.
1972 * ada-valprint.c: Remove includes.
1973
1974 2019-10-29 Simon Marchi <simon.marchi@efficios.com>
1975
1976 * addrmap.c: Add static assertions of type size, moved from
1977 _initialize_addrmap.
1978 (_initialize_addrmap): Remove.
1979
1980 2019-10-29 Christian Biesinger <cbiesinger@google.com>
1981
1982 * coffread.c (record_minimal_symbol): Update.
1983 (process_coff_symbol): Update.
1984 * dbxread.c (read_dbx_symtab): Update.
1985 * dwarf2read.c (add_partial_symbol): Update.
1986 (fixup_go_packaging): Update.
1987 (load_partial_dies): Update.
1988 (new_symbol): Update.
1989 * elfread.c (record_minimal_symbol): Change signature to use
1990 gdb::string_view instead of name+len.
1991 (elf_symtab_read): Update.
1992 (elf_rel_plt_read): Update.
1993 * mdebugread.c (parse_partial_symbols): Update.
1994 (handle_psymbol_enumerators): Update.
1995 (new_symbol): Update.
1996 * minsyms.c (minimal_symbol_reader::record_full): Change signature
1997 to use gdb::string_view instead of name+len.
1998 * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
1999 * psympriv.h (add_psymbol_to_list): Likewise.
2000 * psymtab.c (add_psymbol_to_bcache): Likewise.
2001 (add_psymbol_to_list): Likewise.
2002 * stabsread.c (define_symbol): Update.
2003 * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2004 * symtab.h (SYMBOL_SET_NAMES): Likewise.
2005 (symbol_set_names): Likewise.
2006 * xcoffread.c (scan_xcoff_symtab): Update.
2007
2008 2019-10-29 Christian Biesinger <cbiesinger@google.com>
2009
2010 * symtab.h (symbol_set_names): Document that copy_name must be
2011 set to true for non-nullterminated strings.
2012 * symtab.c (symbol_set_names): Only make a nullterminated copy of
2013 linkage_name if the entry was not found and we need to demangle.
2014
2015 2019-10-29 Christian Biesinger <cbiesinger@google.com>
2016
2017 * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2018 * dwarf2-frame.c (bsearch_fde_cmp): Update.
2019 (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2020 * gdbsupport/gdb_binary_search.h: New file.
2021
2022 2019-10-29 Christian Biesinger <cbiesinger@google.com>
2023
2024 * NEWS: Mention new --with-system-gdbinit-dir option.
2025 * config.in: Regenerate.
2026 * configure: Regenerate.
2027 * configure.ac: Add new option --with-system-gdbinit-dir.
2028 * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2029 for a ".gdb" suffix.
2030 * main.c (get_init_files): Change system_gdbinit argument to
2031 a vector and return the files in SYSTEM_GDBINIT_DIR in
2032 addition to SYSTEM_GDBINIT.
2033 (captured_main_1): Update.
2034 (print_gdb_help): Update.
2035 * top.c (print_gdb_configuration): Also print the value of
2036 SYSTEM_GDBINIT_DIR.
2037
2038 2019-10-28 Christian Biesinger <cbiesinger@google.com>
2039
2040 * gdbsupport/common-utils.h (startswith): Add an overloaded version
2041 that takes gdb::string_view arguments.
2042
2043 2019-10-26 Tom de Vries <tdevries@suse.de>
2044
2045 * aarch64-linux-tdep.c: Fix typos in comments.
2046 * aarch64-tdep.c: Same.
2047 * ada-lang.c: Same.
2048 * amd64-nat.c: Same.
2049 * arc-tdep.c: Same.
2050 * arch/aarch64-insn.c: Same.
2051 * block.c: Same.
2052 * breakpoint.h: Same.
2053 * btrace.h: Same.
2054 * c-varobj.c: Same.
2055 * cli/cli-decode.c: Same.
2056 * cli/cli-script.c: Same.
2057 * cli/cli-utils.h: Same.
2058 * coff-pe-read.c: Same.
2059 * coffread.c: Same.
2060 * compile/compile-cplus-symbols.c: Same.
2061 * compile/compile-object-run.c: Same.
2062 * completer.c: Same.
2063 * corelow.c: Same.
2064 * cp-support.c: Same.
2065 * demangle.c: Same.
2066 * dwarf-index-write.c: Same.
2067 * dwarf2-frame.c: Same.
2068 * dwarf2-frame.h: Same.
2069 * eval.c: Same.
2070 * frame-base.h: Same.
2071 * frame.h: Same.
2072 * gdbcmd.h: Same.
2073 * gdbtypes.h: Same.
2074 * gnu-nat.c: Same.
2075 * guile/scm-objfile.c: Same.
2076 * i386-tdep.c: Same.
2077 * i386-tdep.h: Same.
2078 * infcall.c: Same.
2079 * infcall.h: Same.
2080 * linux-nat.c: Same.
2081 * m68k-tdep.c: Same.
2082 * macroexp.c: Same.
2083 * memattr.c: Same.
2084 * mi/mi-cmd-disas.c: Same.
2085 * mi/mi-getopt.h: Same.
2086 * mi/mi-main.c: Same.
2087 * minsyms.c: Same.
2088 * nat/aarch64-sve-linux-sigcontext.h: Same.
2089 * objfiles.h: Same.
2090 * ppc-linux-nat.c: Same.
2091 * ppc-linux-tdep.c: Same.
2092 * ppc-tdep.h: Same.
2093 * progspace.h: Same.
2094 * prologue-value.h: Same.
2095 * python/py-evtregistry.c: Same.
2096 * python/py-instruction.h: Same.
2097 * record-btrace.c: Same.
2098 * record-full.c: Same.
2099 * remote.c: Same.
2100 * rs6000-tdep.c: Same.
2101 * ser-tcp.c: Same.
2102 * sol-thread.c: Same.
2103 * sparc-sol2-tdep.c: Same.
2104 * sparc64-tdep.c: Same.
2105 * stabsread.c: Same.
2106 * symfile.c: Same.
2107 * symtab.h: Same.
2108 * target.c: Same.
2109 * tracepoint.c: Same.
2110 * tui/tui-data.h: Same.
2111 * tui/tui-io.c: Same.
2112 * tui/tui-win.c: Same.
2113 * tui/tui.c: Same.
2114 * unittests/rsp-low-selftests.c: Same.
2115 * user-regs.h: Same.
2116 * utils.c: Same.
2117 * utils.h: Same.
2118 * valarith.c: Same.
2119 * valops.c: Same.
2120 * valprint.c: Same.
2121 * valprint.h: Same.
2122 * value.c: Same.
2123 * value.h: Same.
2124 * varobj.c: Same.
2125 * x86-nat.h: Same.
2126 * xtensa-tdep.c: Same.
2127
2128 2019-10-25 Ali Tamur <tamur@google.com>
2129
2130 * charset.c (find_charset_names): Reflect API change.
2131
2132 2019-10-25 Christian Biesinger <cbiesinger@google.com>
2133
2134 * symtab.c (struct demangled_name_entry): Change demangled name
2135 to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2136 part of the struct anymore.
2137 (symbol_set_names): No longer obstack allocate + copy the demangled
2138 name, just store the allocated name from bfd.
2139
2140 2019-10-25 Tom Tromey <tromey@adacore.com>
2141
2142 * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2143 (bsearch_cie_cmp, add_cie): Remove.
2144 (find_cie): Reimplement.
2145 (decode_frame_entry_1, decode_frame_entry): Change type. Update.
2146 (dwarf2_build_frame_info): Update.
2147
2148 2019-10-24 H.J. Lu <hongjiu.lu@intel.com>
2149
2150 PR gdb/25126
2151 * symfile.c (reread_symbols): Call forget_cached_source_info to
2152 clear the stale source cache.
2153
2154 2019-10-24 Christian Biesinger <cbiesinger@google.com>
2155
2156 * configure: Regenerate.
2157 * configure.ac: Remove code that sets python_has_threads.
2158
2159 2019-10-24 Christian Biesinger <cbiesinger@google.com>
2160
2161 * config.in: Regenerate.
2162 * configure: Regenerate.
2163 * configure.ac: Remove the code that uses sed to get the python
2164 version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2165
2166 2019-10-24 Andrew Burgess <andrew.burgess@embecosm.com>
2167
2168 * python/py-progspace.c (pspy_block_for_pc): Return None for all
2169 error paths.
2170
2171 2019-10-23 Tom Tromey <tom@tromey.com>
2172
2173 * arc-tdep.c: Remove ".." from include.
2174 * frv-tdep.c: Remove ".." from include.
2175 * lm32-tdep.c: Remove ".." from include.
2176 * microblaze-tdep.c: Remove ".." from include.
2177 * or1k-tdep.h: Remove ".." from include.
2178 * s12z-tdep.c: Remove ".." from include.
2179 * Makefile.in (OPCODES_CFLAGS): Add comment.
2180 (TOP_CFLAGS): New variable.
2181 (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2182
2183 2019-10-23 Tom Tromey <tom@tromey.com>
2184
2185 * Makefile.in (READLINE_DIR): Update.
2186
2187 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2188
2189 * infcall.c (call_function_by_hand_dummy): Fix the function
2190 comment. And extract out a code section into...
2191 (reserve_stack_space): ...this new function.
2192
2193 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2194
2195 * infcall.c (value_arg_coerce): Remove an unused parameter.
2196 (call_function_by_hand_dummy): Update the call to
2197 'value_arg_coerce'.
2198
2199 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2200
2201 * infcall.c (call_function_by_hand_dummy): Refactor.
2202
2203 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2204
2205 * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2206
2207 2019-10-23 Tom Tromey <tom@tromey.com>
2208
2209 * configure: Rebuild.
2210 * configure.ac: Don't check for sigprocmask.
2211 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2212
2213 2019-10-23 Tom Tromey <tom@tromey.com>
2214
2215 * configure: Rebuild.
2216 * acinclude.m4: Use m4_include, not sinclude.
2217
2218 2019-10-23 Tom de Vries <tdevries@suse.de>
2219
2220 PR breakpoints/24687
2221 * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2222
2223 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2224
2225 * symtab.c (struct demangled_name_entry) <language>: Change from
2226 bitfield to regular variable.
2227
2228 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2229
2230 * symtab.c (struct demangled_name_entry): Add a constructor.
2231 (free_demangled_name_entry): New function to call the destructor
2232 for demangled_name_entry.
2233 (create_demangled_names_hash): Pass free_demangled_name_entry to
2234 htab_create_alloc.
2235 (symbol_set_names): Call placement new for demangled_name_entry.
2236 * utils.c: No longer include xxhash.h here, now that fast_hash
2237 is inlined in the header.
2238 * utils.h: Instead, include it here.
2239
2240 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2241
2242 * Makefile.in: Link with libxxhash.
2243 * config.in: Regenerate.
2244 * configure: Regenerate.
2245 * configure.ac: Search for libxxhash.
2246 * utils.c (fast_hash): Use xxhash if present.
2247
2248 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2249
2250 * utils.h (fast_hash): New function.
2251 * symtab.c (hash_demangled_name_entry): Call new function
2252 fast_hash.
2253
2254 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2255
2256 * symtab.c (struct demangled_name_entry): Change type of mangled
2257 to gdb::string_view. Also adds a constructor that takes the
2258 mangled name.
2259 (hash_demangled_name_entry): Update.
2260 (eq_demangled_name_entry): Update.
2261 (free_demangled_name_entry): New function to call the destructor
2262 now that this is not a POD anymore.
2263 (create_demangled_names_hash): Pass free_demangled_name_entry to
2264 htab_create_alloc.
2265 (symbol_set_names): Update.
2266
2267 2019-10-21 Ali Tamur <tamu@google.com>
2268
2269 * dwarf2read.c (dir_index): Change type.
2270 (file_name_index): Likewise.
2271 (line_header::include_dir_at): Change comment and implementation on
2272 whether it is DWARF 5.
2273 (line_header::is_valid_file_index): New function.
2274 (line_header::file_name_at): Change comment and implementation on
2275 whether it is DWARF 5.
2276 (line_header::file_names): Change to private field renamed as
2277 m_file_names and introduce a new accessor method.
2278 (line_header::file_names_size): New method.
2279 (line_header::include_dirs): Change to private field and rename as
2280 m_include_dirs.
2281 (dw2_get_file_names_reader): Define local var at a smaller scope and
2282 reflect API change.
2283 (dwarf2_cu::setup_type_unit_groups): Reflect API change.
2284 (process_structure_scope): Likewise.
2285 (line_header::add_include_dir): Change message and reflect renaming.
2286 (line_header::add_file_name): Likewise.
2287 (read_formatted_entries): Handle DW_FORM_data16.
2288 (dwarf_decode_line_header): Fix line header length calculation.
2289 (psymtab_include_file_name): Change comment and API.
2290 (lnp_state_machine::m_file): Update comment and reflect type change.
2291 (lnp_state_machine::record_line): Reflect type change.
2292 (dwarf_decode_lines): Reflect API change.
2293 (file_file_name): Likewise.
2294 (file_full_name): Likewise.
2295
2296 2019-10-21 Andrew Burgess <andrew.burgess@embecosm.com>
2297
2298 * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
2299
2300 2019-10-21 Tom Tromey <tom@tromey.com>
2301
2302 * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
2303
2304 2019-10-21 Tom Tromey <tom@tromey.com>
2305
2306 * configure.ac (nm.h): Conditionally create nm.h link. Subst
2307 NM_H. Use AC_CONFIG_LINKS.
2308 * configure: Rebuild.
2309 * Makefile.in (NM_H): New variable.
2310 (generated_files): Add NM_H. Remove gcore.
2311 (nm.h, stamp-nmh): New targets.
2312
2313 2019-10-20 Tom Tromey <tom@tromey.com>
2314
2315 * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
2316 * objfiles.c (unlink_objfile): Move earlier. Now static. Remove
2317 obsolete comment.
2318 (put_objfile_before): Now static.
2319
2320 2019-10-19 Simon Marchi <simon.marchi@polymtl.ca>
2321
2322 * gdbsupport/common-utils.h (startswith): Change return type to
2323 bool.
2324
2325 2019-10-19 Christian Biesinger <cbiesinger@google.com>
2326
2327 * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
2328 * breakpoint.c (bp_locations_compare): Rename to...
2329 (bp_location_is_less_than): ...this, and change to std::sort semantics.
2330 (update_global_location_list): Use std::sort instead of qsort.
2331 * buildsym.c (compare_line_numbers): Rename to...
2332 (lte_is_less_than): ...this, and change to std::sort semantics.
2333 (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
2334 instead of qsort.
2335 * disasm.c (compare_lines): Rename to...
2336 (line_is_less_than): ...this, and change to std::sort semantics.
2337 (do_mixed_source_and_assembly_deprecated): Call std::sort instead
2338 of qsort.
2339 * dwarf2-frame.c (qsort_fde_cmp): Rename to...
2340 (fde_is_less_than): ...this, and change to std::sort semantics.
2341 (dwarf2_build_frame_info): Call std::sort instead of qsort.
2342 * mdebugread.c (compare_blocks):
2343 (block_is_less_than): ...this, and change to std::sort semantics.
2344 (sort_blocks): Call std::sort instead of qsort.
2345 * objfiles.c (qsort_cmp): Rename to...
2346 (sort_cmp): ...this, and change to std::sort semantics.
2347 (update_section_map): Call std::sort instead of qsort.
2348 * remote.c (compare_pnums): Remove.
2349 (map_regcache_remote_table): Call std::sort instead of qsort.
2350 * utils.c (compare_positive_ints): Remove.
2351 * utils.h (compare_positive_ints): Remove.
2352 * xcoffread.c (compare_lte): Remove.
2353 (arrange_linetable): Call std::sort instead of qsort.
2354
2355 2019-10-19 Sergio Durigan Junior <sergiodj@redhat.com>
2356
2357 * symfile.c (init_entry_point_info): Fix typo.
2358 * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
2359
2360 2019-10-18 Tom de Vries <tdevries@suse.de>
2361
2362 * aarch64-tdep.c: Fix typos in comments.
2363 * ada-lang.c: Same.
2364 * ada-tasks.c: Same.
2365 * alpha-tdep.c: Same.
2366 * alpha-tdep.h: Same.
2367 * amd64-nat.c: Same.
2368 * amd64-windows-tdep.c: Same.
2369 * arc-tdep.c: Same.
2370 * arc-tdep.h: Same.
2371 * arch-utils.c: Same.
2372 * arm-nbsd-tdep.c: Same.
2373 * arm-tdep.c: Same.
2374 * ax-gdb.c: Same.
2375 * blockframe.c: Same.
2376 * btrace.c: Same.
2377 * c-varobj.c: Same.
2378 * coff-pe-read.c: Same.
2379 * coffread.c: Same.
2380 * cris-tdep.c: Same.
2381 * darwin-nat.c: Same.
2382 * dbxread.c: Same.
2383 * dcache.c: Same.
2384 * disasm.c: Same.
2385 * dtrace-probe.c: Same.
2386 * dwarf-index-write.c: Same.
2387 * dwarf2-frame-tailcall.c: Same.
2388 * dwarf2-frame.c: Same.
2389 * dwarf2read.c: Same.
2390 * eval.c: Same.
2391 * exceptions.c: Same.
2392 * fbsd-tdep.c: Same.
2393 * findvar.c: Same.
2394 * frame.c: Same.
2395 * frv-tdep.c: Same.
2396 * gnu-v3-abi.c: Same.
2397 * go32-nat.c: Same.
2398 * h8300-tdep.c: Same.
2399 * hppa-tdep.c: Same.
2400 * i386-linux-tdep.c: Same.
2401 * i386-tdep.c: Same.
2402 * ia64-libunwind-tdep.c: Same.
2403 * ia64-tdep.c: Same.
2404 * infcmd.c: Same.
2405 * infrun.c: Same.
2406 * linespec.c: Same.
2407 * linux-nat.c: Same.
2408 * linux-thread-db.c: Same.
2409 * machoread.c: Same.
2410 * mdebugread.c: Same.
2411 * mep-tdep.c: Same.
2412 * mn10300-tdep.c: Same.
2413 * namespace.c: Same.
2414 * objfiles.c: Same.
2415 * opencl-lang.c: Same.
2416 * or1k-tdep.c: Same.
2417 * osabi.c: Same.
2418 * ppc-linux-nat.c: Same.
2419 * ppc-linux-tdep.c: Same.
2420 * ppc-sysv-tdep.c: Same.
2421 * printcmd.c: Same.
2422 * procfs.c: Same.
2423 * record-btrace.c: Same.
2424 * record-full.c: Same.
2425 * remote-fileio.c: Same.
2426 * remote.c: Same.
2427 * rs6000-tdep.c: Same.
2428 * s12z-tdep.c: Same.
2429 * score-tdep.c: Same.
2430 * ser-base.c: Same.
2431 * ser-go32.c: Same.
2432 * skip.c: Same.
2433 * sol-thread.c: Same.
2434 * solib-svr4.c: Same.
2435 * solib.c: Same.
2436 * source.c: Same.
2437 * sparc-nat.c: Same.
2438 * sparc-sol2-tdep.c: Same.
2439 * sparc-tdep.c: Same.
2440 * sparc64-tdep.c: Same.
2441 * stabsread.c: Same.
2442 * stack.c: Same.
2443 * symfile.c: Same.
2444 * symtab.c: Same.
2445 * target-descriptions.c: Same.
2446 * target-float.c: Same.
2447 * thread.c: Same.
2448 * utils.c: Same.
2449 * valops.c: Same.
2450 * valprint.c: Same.
2451 * value.c: Same.
2452 * varobj.c: Same.
2453 * windows-nat.c: Same.
2454 * xcoffread.c: Same.
2455 * xstormy16-tdep.c: Same.
2456 * xtensa-tdep.c: Same.
2457
2458 2019-10-17 Tom Tromey <tromey@adacore.com>
2459
2460 * configure: Rebuild.
2461 * configure.ac: Use AC_CONFIG_HEADERS. Create stamp-h there, not
2462 in AC_CONFIG_FILES invocation.
2463 * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
2464 new-style config.status invocation.
2465
2466 2019-10-17 Tom de Vries <tdevries@suse.de>
2467
2468 * arm-nbsd-nat.c: Fix typos in comments.
2469 * arm-tdep.c: Same.
2470 * darwin-nat-info.c: Same.
2471 * dwarf2read.c: Same.
2472 * elfread.c: Same.
2473 * event-top.c: Same.
2474 * findvar.c: Same.
2475 * gdbtypes.c: Same.
2476 * hppa-tdep.c: Same.
2477 * i386-tdep.c: Same.
2478 * jit.c: Same.
2479 * main.c: Same.
2480 * mdebugread.c: Same.
2481 * moxie-tdep.c: Same.
2482 * nto-procfs.c: Same.
2483 * osabi.c: Same.
2484 * ppc-linux-tdep.c: Same.
2485 * remote.c: Same.
2486 * riscv-tdep.c: Same.
2487 * s390-tdep.c: Same.
2488 * sh-tdep.c: Same.
2489 * sparc-linux-tdep.c: Same.
2490 * sparc-nat.c: Same.
2491 * stack.c: Same.
2492 * target-descriptions.c: Same.
2493 * top.c: Same.
2494 * varobj.c: Same.
2495
2496 2019-10-16 Tom Tromey <tom@tromey.com>
2497
2498 * objfiles.h (struct objfile) <original_name>: Now const.
2499
2500 2019-10-16 Christian Biesinger <cbiesinger@google.com>
2501
2502 * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
2503 pass on to sigsetjmp's second argument.
2504 * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
2505
2506 2019-10-16 Keith Seitz <keiths@redhat.com>
2507
2508 PR gdb/23567
2509 * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
2510 sections whose size is greater than the file size.
2511
2512 2019-10-16 Jim Wilson <jimw@sifive.com>
2513
2514 * riscv-tdep.c (riscv_gcc_target_options): New.
2515 (riscv_gnu_triplet_regexp): New.
2516 (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
2517 set_gdbarch_gnu_triplet_regexp.
2518
2519 2019-10-16 Christian Biesinger <cbiesinger@google.com>
2520
2521 * Makefile.in: Add xml-builtin.h.
2522 * features/feature_to_c.sh: Add an include for xml-builtin.h
2523 to ensure that the compiler checks that the types match.
2524 * xml-builtin.h: New file.
2525 * xml-support.c (fetch_xml_builtin): Add missing const.
2526 * xml-support.h: Remove declaration of xml_builtins.
2527
2528 2019-10-16 Tom de Vries <tdevries@suse.de>
2529
2530 PR tdep/25096
2531 * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
2532 (amd64_classify_aggregate): ... here.
2533 (amd64_classify_aggregate_field): Handled fiels of nested structs
2534 recursively.
2535
2536 2019-10-16 Tom de Vries <tdevries@suse.de>
2537
2538 PR tdep/24104
2539 * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
2540 that handles 'theclass'.
2541
2542 2019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2543
2544 * linespec.c (decode_digits_ordinary): Update comment.
2545 * make-target-delegates: No longer need to handle VEC case.
2546 * memrange.c (normalize_mem_ranges): Update comment.
2547 * namespace.c (add_using_directive): Update comment.
2548 * objc-lang.c (uniquify_strings): Update comment.
2549 * ppc-linux-nat.c (struct thread_points): Update comment.
2550 * probe.h (find_probes_in_objfile): Update comment.
2551 * target.h (enum flash_preserve_mode): Update comment.
2552 * varobj.c (varobj_restrict_range): Update comment.
2553 * varobj.h (varobj_list_children): Update comment.
2554
2555 2019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2556
2557 * Makefile.in: Remove references to vec.h and vec.c.
2558 * aarch64-tdep.c: No longer include vec.h.
2559 * ada-lang.c: Likewise.
2560 * ada-lang.h: Likewise.
2561 * arm-tdep.c: Likewise.
2562 * ax.h: Likewise.
2563 * breakpoint.h: Likewise.
2564 * charset.c: Likewise.
2565 * cp-support.h: Likewise.
2566 * dtrace-probe.c: Likewise.
2567 * dwarf2read.c: Likewise.
2568 * extension.h: Likewise.
2569 * gdb_bfd.c: Likewise.
2570 * gdbsupport/gdb_vecs.h: Likewise.
2571 * gdbsupport/vec.c: Remove.
2572 * gdbsupport/vec.h: Remove.
2573 * gdbthread.h: Likewise.
2574 * guile/scm-type.c: Likewise.
2575 * inline-frame.c: Likewise.
2576 * machoread.c: Likewise.
2577 * memattr.c: Likewise.
2578 * memrange.h: Likewise.
2579 * namespace.h: Likewise.
2580 * nat/linux-btrace.h: Likewise.
2581 * osdata.c: Likewise.
2582 * parser-defs.h: Likewise.
2583 * progspace.h: Likewise.
2584 * python/py-type.c: Likewise.
2585 * record-btrace.c: Likewise.
2586 * rust-exp.y: Likewise.
2587 * solib-target.c: Likewise.
2588 * stap-probe.c: Likewise.
2589 * target-descriptions.c: Likewise.
2590 * target-memory.c: Likewise.
2591 * target.h: Likewise.
2592 * varobj.c: Likewise.
2593 * varobj.h: Likewise.
2594 * xml-support.h: Likewise.
2595
2596 2019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2597
2598 * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
2599 Update for new std::vector based implementation.
2600 (process_psymtab_comp_unit_reader): Likewise.
2601 (scan_partial_symbols): Likewise.
2602 (recursively_compute_inclusions): Likewise.
2603 (compute_compunit_symtab_includes): Likewise.
2604 (process_imported_unit_die): Likewise.
2605 (queue_and_load_dwo_tu): Likewise.
2606 (follow_die_sig_1): Likewise.
2607 * gdb/dwarf2read.h: Remove DEF_VEC_P.
2608 (typedef dwarf2_per_cu_ptr): Remove.
2609 (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
2610 function.
2611 (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
2612 (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
2613 (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
2614 (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
2615 std::vector.
2616
2617 2019-10-15 Tom Tromey <tromey@adacore.com>
2618
2619 * windows-nat.c (windows_nat_target::resume): Use %x when logging
2620 TID.
2621
2622 2019-10-15 Tom Tromey <tromey@adacore.com>
2623
2624 * windows-nat.c (windows_nat_target::fetch_registers)
2625 (windows_nat_target::store_registers): Rename "pid" to "tid".
2626
2627 2019-10-15 Tom Tromey <tromey@adacore.com>
2628
2629 * gdbarch.h, gdbarch.c: Rebuild.
2630 * gdbarch.sh (gcc_target_options): Change return type to
2631 std::string.
2632 * compile/compile.c (get_args): Update.
2633 * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
2634 * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
2635 std::string.
2636 * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
2637 std::string.
2638 * arch-utils.c (default_gcc_target_options): Return std::string.
2639 * arch-utils.h (default_gcc_target_options): Return std::string.
2640 * s390-tdep.c (s390_gcc_target_options): Return std::string.
2641
2642 2019-10-15 Christian Biesinger <cbiesinger@google.com>
2643
2644 * breakpoint.c (breakpoint_chain): Make static.
2645 * tui/tui-winsource.c: Call iterate_over_breakpoints instead
2646 of accessing breakpoint_chain.
2647
2648 2019-10-15 Christian Biesinger <cbiesinger@google.com>
2649
2650 * breakpoint.c (iterate_over_breakpoints): Change function pointer
2651 to a gdb::function_view and return value to bool.
2652 * breakpoint.h (iterate_over_breakpoints): Likewise.
2653 * dummy-frame.c (pop_dummy_frame_bpt): Update.
2654 (pop_dummy_frame): Update.
2655 * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
2656 (gdbscm_breakpoints): Update.
2657 * python/py-breakpoint.c (build_bp_list): Update.
2658 (gdbpy_breakpoints): Update.
2659 * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
2660 Update.
2661 (bpfinishpy_handle_stop): Update.
2662 (bpfinishpy_handle_exit): Update.
2663 * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
2664 (svr4_update_solib_event_breakpoints): Update.
2665
2666 2019-10-15 Andreas Arnez <arnez@linux.ibm.com>
2667
2668 * s390-tdep.c (s390_effective_inner_type): Ignore static fields
2669 when unwrapping single-field structs.
2670
2671 2019-10-14 Simon Marchi <simon.marchi@polymtl.ca>
2672
2673 * dwarf2read.c: Remove includes.
2674
2675 2019-10-13 Simon Marchi <simon.marchi@polymtl.ca>
2676
2677 * ui-out.c (ui_out::call_do_message): Silence
2678 -Wformat-nonliteral warning.
2679
2680 2019-10-12 Simon Marchi <simon.marchi@polymtl.ca>
2681
2682 * breakpoint.c: Remove some includes: continuations.h, skip.h,
2683 mi/mi-main.h, readline/readline.h, readline/history.h. Add
2684 include: readline/tilde.h.
2685
2686 2019-10-12 Christian Biesinger <cbiesinger@google.com>
2687
2688 * remote.c (remote_target::get_trace_status): Remove declaration of
2689 trace_regblock_size.
2690
2691 2019-10-12 Christian Biesinger <cbiesinger@google.com>
2692
2693 * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
2694 (show_user): Remove declaration of cmdlist.
2695 * cli/cli-cmds.h (max_user_call_depth): Declare.
2696 * cli/cli-script.c (execute_user_command): Remove declaration
2697 of max_user_call_depth.
2698
2699 2019-10-11 Jim Wilson <jimw@sifive.com>
2700
2701 * gdbsupport/print-utils.h (pulongest): Fix comment.
2702 (plongest): Likewise.
2703 (phex): Add missing comment, mention leading zeros.
2704 (phex_nz): Add mention of no leading zeros to comment.
2705
2706 * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
2707 plongest instead of unsigned long long cast.
2708
2709 2019-10-10 Christian Biesinger <cbiesinger@google.com>
2710
2711 * main.c (captured_main_1): Include gdbtk.h and remove declarations
2712 for external_editor_command and gdbtk_test.
2713
2714 2019-10-10 Christian Biesinger <cbiesinger@google.com>
2715
2716 * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
2717 * varobj.c (varobjdebug): Move comment to...
2718 * varobj.h (varobjdebug): ...here, and declare.
2719
2720 2019-10-09 Tom Tromey <tom@tromey.com>
2721
2722 * tui/tui-regs.c (tui_data_window::show_registers): Don't call
2723 erase_data_content.
2724
2725 2019-10-09 Tom Tromey <tom@tromey.com>
2726
2727 * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
2728 * tui/tui-stack.c (tui_locator_window::rerender): Update.
2729 * tui/tui-command.c (tui_cmd_window::resize)
2730 (tui_refresh_cmd_win): Update.
2731 * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
2732 * tui/tui.c (tui_rl_other_window, tui_enable): Update.
2733 * tui/tui-data.c (~tui_gen_win_info): Remove.
2734 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2735 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2736 (tui_redisplay_readline, tui_mld_flush)
2737 (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
2738 * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
2739 (tui_data_window::erase_data_content)
2740 (tui_data_item_window::rerender)
2741 (tui_data_item_window::refresh_window): Update.
2742 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
2743 (box_win, tui_gen_win_info::make_window)
2744 (tui_gen_win_info::make_visible): Update.
2745 (tui_delete_win): Remove.
2746 * tui/tui-winsource.c
2747 (tui_source_window_base::do_erase_source_content): Update.
2748 (tui_show_source_line, tui_source_window_base::update_tab_width)
2749 (tui_source_window_base::update_exec_info): Update.
2750 * tui/tui-data.h (struct curses_deleter): New.
2751 (struct tui_gen_win_info) <handle>: Now a unique_ptr.
2752 (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
2753
2754 2019-10-09 Tom Tromey <tom@tromey.com>
2755
2756 * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
2757
2758 2019-10-09 Tom Tromey <tom@tromey.com>
2759
2760 * tui/tui-data.c (tui_win_is_auxiliary): Remove.
2761 * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
2762
2763 2019-10-09 Tom Tromey <tom@tromey.com>
2764
2765 * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
2766 window height directly.
2767 * tui/tui-layout.h (tui_default_win_viewport_height): Don't
2768 declare.
2769 * tui/tui-layout.c (tui_default_win_height): Remove.
2770 (tui_default_win_viewport_height): Remove.
2771
2772 2019-10-09 Tom Tromey <tom@tromey.com>
2773
2774 * tui/tui.h: Remove comments.
2775
2776 2019-10-09 Tom de Vries <tdevries@suse.de>
2777
2778 * python/lib/gdb/printer/bound_registers.py: Use
2779 '^builtin_type_bound128' as regexp argument for
2780 add_builtin_pretty_printer.
2781
2782 2019-10-09 Christian Biesinger <cbiesinger@google.com>
2783
2784 * guile/guile.c (guile_extension_script_ops): Remove forward
2785 declaration and mark as static.
2786 (guile_script_ops): Likewise.
2787 (extension_language_guile): Move further down in the file so
2788 it can reference the definitions for guile_{extension_,}script_ops.
2789
2790 2019-10-09 Andreas Arnez <arnez@linux.ibm.com>
2791
2792 * s390-tdep.c (390_process_record): Handle new arch13 instructions
2793 except SORTL, DFLTCC, and KDSA.
2794
2795 2019-10-08 Tom Tromey <tromey@adacore.com>
2796
2797 * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
2798 (struct safe_symbol_file_add_args): Remove.
2799
2800 2019-10-08 Tom Tromey <tromey@adacore.com>
2801
2802 * windows-nat.c: Don't include buildsym-legacy.h.
2803
2804 2019-10-08 Tom Tromey <tromey@adacore.com>
2805
2806 * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
2807
2808 2019-10-08 Christian Biesinger <cbiesinger@google.com>
2809
2810 * gdbtypes.c (overload_debug): Move comment to header.
2811 * gdbtypes.h (overload_debug): Declare.
2812 * valops.c: Remove declaration of overload_debug, instead
2813 include gdbtypes.h.
2814
2815 2019-10-08 Christian Biesinger <cbiesinger@google.com>
2816
2817 * language.c (show_language_command): Pass lang_frame_mismatch_warn
2818 through _().
2819 (lang_frame_mismatch_warn): Make const, mark with N_(), and
2820 move comment...
2821 * language.h (lang_frame_mismatch_warn): ... here. Also add
2822 declaration.
2823 * top.c (lang_frame_mismatch_warn): Remove declaration.
2824 (check_frame_language_change): Pass lang_frame_mismatch_warn
2825 through _().
2826
2827 2019-10-07 Christian Biesinger <cbiesinger@google.com>
2828
2829 * c-lang.h (vtbl_ptr_name): Declare.
2830 * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
2831 it from the header.
2832 * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
2833
2834 2019-10-07 Christian Biesinger <cbiesinger@google.com>
2835
2836 * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
2837 gdb_static_assert.
2838
2839 2019-10-07 Weimin Pan <weimin.pan@oracle.com>
2840
2841 * ../Makefile.def (dependencies): Add all-libctf to all-gdb
2842 * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
2843 * ctfread.c: New file.
2844 * ctfread.h: New file.
2845 * elfread.c: Include ctfread.h.
2846 (struct elfinfo text_p): New member ctfsect.
2847 (elf_locate_sections): Mark CTF section.
2848 (elf_symfile_read): Call elfctf_build_psymtabs.
2849 * Makefile.in (LIBCTF): Add.
2850 (CLIBS): Use it.
2851 (CDEPS): Likewise.
2852 (DIST): Add ctfread.c.
2853
2854 2019-10-07 Andrew Burgess <andrew.burgess@embecosm.com>
2855
2856 * ctfread.c (struct nextfield): Renamed to ...
2857 (struct ctf_nextfield): ... this.
2858 (struct field_info): Renamed to ...
2859 (strut ctf_field_info): ... this.
2860 (attach_fields_to_type): Update for renamed structures.
2861 (ctf_add_member_cb): Likewise.
2862 (ctf_add_enum_member_cb): Likewise.
2863 (process_struct_members): Likewise.
2864 (process_enum_type): Likewise.
2865
2866 2019-10-07 Weimin Pan <weimin.pan@oracle.com>
2867
2868 * tracectf.h: Rename, was ctf.h.
2869 * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
2870 * tracefile.c: Likewise.
2871 * tracepoint.c: Remove unused include ctf.h.
2872 * mi/mi-main.c: Likewise.
2873 * Makefile.in Replace ctf.c with tracectf.c.
2874
2875 2019-10-06 Joel Brobecker <brobecker@adacore.com>
2876
2877 * version.in: Change version number to "9.0.50.DATE-git".
2878
2879 2019-10-03 Tom Tromey <tom@tromey.com>
2880
2881 PR rust/24976:
2882 * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
2883
2884 2019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
2885
2886 * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
2887 cp_search_name_hash.
2888 * NEWS: Add entry about nested function support.
2889
2890 2019-10-03 Bernhard Heckel <bernhard.heckel@intel.com>
2891 Andrew Burgess <andrew.burgess@embecosm.com>
2892
2893 * cp-namespace.c (cp_search_static_and_baseclasses): Only search
2894 for nested static variables when searchin VAR_DOMAIN.
2895 * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
2896 global scope, update comment.
2897 (add_partial_subprogram): Call add_partial_subprogram recursively
2898 for nested subroutines when processinng Fortran.
2899 (load_partial_dies): Process the child entities of a subprogram
2900 when processing Fortran.
2901 (partial_die_parent_scope): Handle building scope
2902 for Fortran nested functions.
2903 (process_die): Record that nested functions have a scope.
2904 (new_symbol): Always record Fortran subprograms on the global
2905 symbol list.
2906 (determine_prefix): How to build the prefix for Fortran
2907 subprograms.
2908
2909 2019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
2910
2911 * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
2912 have just sent the thread a SIGSTOP and are waiting for it to
2913 arrive.
2914
2915 2019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
2916
2917 * btrace.c (btrace_add_pc): Remove whitespace before the template
2918 parameter in 'std::vector <...>'.
2919 (parse_xml_btrace_block): Likewise.
2920 (btrace_maint_decode_pt): Likewise.
2921 (btrace_maint_update_packets): Likewise.
2922 (btrace_maint_print_packets): Likewise.
2923 * btrace.h (struct btrace_maint_info): Likewise.
2924 * dwarf2read.c (struct type_unit_group): Likewise.
2925 (build_type_psymtabs_reader): Likewise.
2926 * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
2927 * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
2928 * nat/linux-btrace.c (perf_event_read_bts): Likewise.
2929
2930 2019-10-03 Tom de Vries <tdevries@suse.de>
2931
2932 * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
2933 the first line of the help text for set/show style metadata.
2934
2935 2019-10-02 Tom Tromey <tromey@adacore.com>
2936
2937 * Makefile.in (COMMON_SFILES): Add common-inferior.c.
2938 * gdbsupport/common-inferior.c: New file.
2939 * infcmd.c (startup_with_shell): Don't define.
2940 * nat/fork-inferior.h (startup_with_shell): Don't declare.
2941 * gdbsupport/common-inferior.h (startup_with_shell): Declare.
2942 * inferior.h (startup_with_shell): Don't declare.
2943
2944 2019-10-02 Christian Biesinger <cbiesinger@google.com>
2945
2946 * gdbsupport/gdb_assert.h: Include errors.h.
2947 * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
2948
2949 2019-10-02 Tom Tromey <tromey@adacore.com>
2950
2951 * NEWS: Add $_ada_exception entry.
2952 * ada-lang.c (struct ada_catchpoint): Add constructor.
2953 <m_kind>: New member.
2954 (allocate_location_exception, re_set_exception): Remove
2955 "ex" parameter.
2956 (should_stop_exception): Compute $_ada_exception.
2957 (check_status_exception, print_it_exception)
2958 (print_one_exception, print_mention_exception): Remove
2959 "ex" parameter.
2960 (allocate_location_catch_exception, re_set_catch_exception)
2961 (check_status_exception, print_it_catch_exception)
2962 (print_one_catch_exception, print_mention_catch_exception)
2963 (print_recreate_catch_exception)
2964 (allocate_location_catch_exception_unhandled)
2965 (re_set_catch_exception_unhandled)
2966 (check_status_exception, print_it_catch_exception_unhandled)
2967 (print_one_catch_exception_unhandled)
2968 (print_mention_catch_exception_unhandled)
2969 (print_recreate_catch_exception_unhandled)
2970 (allocate_location_catch_assert, re_set_catch_assert)
2971 (check_status_assert, print_it_catch_assert)
2972 (print_one_catch_assert, print_mention_catch_assert)
2973 (print_recreate_catch_assert)
2974 (allocate_location_catch_handlers, re_set_catch_handlers)
2975 (check_status_handlers, print_it_catch_handlers)
2976 (print_one_catch_handlers, print_mention_catch_handlers)
2977 (print_recreate_catch_handlers): Remove.
2978 (create_ada_exception_catchpoint): Update.
2979 (initialize_ada_catchpoint_ops): Update.
2980
2981 2019-10-02 Tom Tromey <tromey@adacore.com>
2982
2983 * ada-lang.c (ada_lookup_simple_minsyms): Remove.
2984 (create_excep_cond_exprs): Simplify exception string computation.
2985 (ada_exception_catchpoint_cond_string): Likewise.
2986
2987 2019-10-02 Tom Tromey <tromey@adacore.com>
2988
2989 * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
2990 * ada-lang.c (lesseq_defined_than): Handle
2991 LOC_STATIC.
2992 * dwarf2read.c (dwarf2_per_objfile): Add can_copy
2993 parameter.
2994 (dwarf2_has_info): Likewise.
2995 (new_symbol): Set maybe_copied on symbol when
2996 appropriate.
2997 * dwarf2read.h (dwarf2_per_objfile): Add can_copy
2998 parameter.
2999 <can_copy>: New member.
3000 * elfread.c (record_minimal_symbol): Set maybe_copied
3001 on symbol when appropriate.
3002 (elf_symfile_read): Update call to dwarf2_has_info.
3003 * minsyms.c (lookup_minimal_symbol_linkage): New
3004 function.
3005 * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3006 * symtab.c (get_symbol_address, get_msymbol_address):
3007 New functions.
3008 * symtab.h (get_symbol_address, get_msymbol_address):
3009 Declare.
3010 (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3011 maybe_copied.
3012 (struct symbol, struct minimal_symbol) <maybe_copied>:
3013 New member.
3014
3015 2019-10-02 Tom Tromey <tromey@adacore.com>
3016
3017 * source.c (struct current_source_location): New.
3018 (current_source_key): New global.
3019 (current_source_symtab, current_source_line)
3020 (current_source_pspace): Remove.
3021 (get_source_location): New function.
3022 (get_current_source_symtab_and_line)
3023 (set_default_source_symtab_and_line)
3024 (set_current_source_symtab_and_line)
3025 (clear_current_source_symtab_and_line, select_source_symtab)
3026 (info_source_command, print_source_lines_base)
3027 (info_line_command, search_command_helper, _initialize_source):
3028 Update.
3029
3030 2019-10-02 Tom Tromey <tromey@adacore.com>
3031
3032 * source.c (select_source_symtab): Don't call
3033 decode_line_with_current_source.
3034
3035 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3036
3037 * symtab.c (lookup_global_symbol): Search global block.
3038
3039 2019-10-02 Tom Tromey <tromey@adacore.com>
3040
3041 * coffread.c (process_coff_symbol): Update.
3042 * dwarf2read.c (var_decode_location, new_symbol): Update.
3043 * mdebugread.c (parse_symbol): Update.
3044 * objfiles.c (relocate_one_symbol): Update.
3045 * stabsread.c (define_symbol, fix_common_block)
3046 (scan_file_globals): Update.
3047 * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3048 (SET_SYMBOL_VALUE_ADDRESS): New macro.
3049 * xcoffread.c (process_xcoff_symbol): Update.
3050
3051 2019-10-02 Andreas Arnez <arnez@linux.ibm.com>
3052
3053 * MAINTAINERS: Update my email address.
3054
3055 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3056
3057 * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3058 std::vector.
3059 (build_type_psymtabs_reader): Update for std::vector.
3060 (build_type_psymtab_dependencies): Likewise.
3061 * dwarf2read.h: Remove use of DEF_VEC_P.
3062 (typedef sig_type_ptr): Delete.
3063
3064 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3065
3066 * btrace.c (btrace_maint_clear): Update to handle change from VEC
3067 to std::vector.
3068 (btrace_maint_decode_pt): Likewise, and move allocation of the
3069 vector outside of the loop.
3070 (btrace_maint_update_packets): Update to handle change from VEC to
3071 std::vector.
3072 (btrace_maint_print_packets): Likewise.
3073 (maint_info_btrace_cmd): Likewise.
3074 * btrace.h: Remove use of DEF_VEC_O.
3075 (typedef btrace_pt_packet_s): Delete.
3076 (struct btrace_maint_info) <packets>: Change fromm VEC to
3077 std::vector.
3078 * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3079
3080 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3081
3082 * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3083 make accesses into the vector constant references.
3084 (btrace_add_pc): Update for std::vector.
3085 (btrace_stitch_bts): Likewise.
3086 (parse_xml_btrace_block): Likewise.
3087 (btrace_maint_update_packets): Likewise.
3088 (btrace_maint_print_packets): Likewise.
3089 (maint_info_btrace_cmd): Likewise.
3090 * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3091 std::vector.
3092 (btrace_data::empty): Likewise.
3093 (btrace_data_append): Likewise.
3094 * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3095 (typedef btrace_block_s): Delete.
3096 (struct btrace_block): Add constructor.
3097 (struct btrace_data_bts) <blocks>: Change to std::vector.
3098 * nat/linux-btrace.c (perf_event_read_bts): Update for
3099 std::vector.
3100 (linux_read_bts): Likewise.
3101
3102 2019-10-01 Tom Tromey <tom@tromey.com>
3103
3104 * cli/cli-logging.c (show_logging_filename): Use styled_string.
3105
3106 2019-10-01 Tom Tromey <tom@tromey.com>
3107
3108 * stack.c (print_frame, info_frame_command_core): Use
3109 styled_string.
3110 * linux-thread-db.c (try_thread_db_load_1)
3111 (try_thread_db_load_from_pdir_1): Use styled_string.
3112 * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3113 (auto_load_section_scripts, info_auto_load_local_gdbinit)
3114 (maybe_print_unsupported_script_warning)
3115 (maybe_print_script_not_found_warning): Use styled_string.
3116 * ada-lang.c (user_select_syms): Use styled_string.
3117
3118 2019-10-01 Tom Tromey <tom@tromey.com>
3119
3120 * p-lang.c (pascal_printstr): Use metadata style.
3121 * value.c (show_convenience): Use metadata style.
3122 * valprint.c (valprint_check_validity, val_print_optimized_out)
3123 (val_print_not_saved, val_print_unavailable)
3124 (val_print_invalid_address, generic_val_print, val_print)
3125 (value_check_printable, val_print_array_elements): Use metadata
3126 style.
3127 * ui-out.h (class ui_out) <field_fmt>: New overload.
3128 <do_field_fmt>: Add style parameter.
3129 * ui-out.c (ui_out::field_fmt): New overload.
3130 * typeprint.c (type_print_unknown_return_type)
3131 (val_print_not_allocated, val_print_not_associated): Use metadata
3132 style.
3133 * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3134 parameter.
3135 * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3136 * tracepoint.c (tvariables_info_1): Use metadata style.
3137 * stack.c (print_frame_arg, print_frame_info, print_frame)
3138 (info_frame_command_core): Use metadata style.
3139 * skip.c (info_skip_command): Use metadata style.
3140 * rust-lang.c (rust_print_enum): Use metadata style.
3141 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3142 metadata style.
3143 * python/py-framefilter.c (py_print_single_arg): Use metadata
3144 style.
3145 * printcmd.c (do_one_display, print_variable_and_value): Use
3146 metadata style.
3147 * p-valprint.c (pascal_val_print)
3148 (pascal_object_print_value_fields): Use metadata style.
3149 * p-typeprint.c (pascal_type_print_base): Use metadata style.
3150 * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3151 parameter.
3152 * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3153 * m2-valprint.c (m2_print_long_set): Use metadata style.
3154 * m2-typeprint.c (m2_print_type): Use metadata style.
3155 * infcmd.c (print_return_value_1): Use metadata style.
3156 * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3157 * f-valprint.c (info_common_command_for_block): Use metadata
3158 style.
3159 * f-typeprint.c (f_type_print_base): Use metadata style.
3160 * expprint.c (print_subexp_standard): Use metadata style.
3161 * cp-valprint.c (cp_print_value_fields): Use metadata style.
3162 * cli/cli-style.h (class cli_style_option): Add constructor.
3163 (metadata_style): Declare.
3164 * cli/cli-style.c (metadata_style): New global.
3165 (_initialize_cli_style): Register metadata style.
3166 * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3167 parameter.
3168 * cli-out.c (cli_ui_out::do_field_fmt): Update.
3169 * c-typeprint.c (c_type_print_base_struct_union)
3170 (c_type_print_base_1): Use metadata style.
3171 * breakpoint.c (watchpoint_value_print)
3172 (print_one_breakpoint_location): Use metadata style.
3173 * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3174 style.
3175 * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3176 style.
3177 * ada-valprint.c (val_print_packed_array_elements, printstr)
3178 (print_field_values, ada_val_print_ref, ada_val_print): Use
3179 metadata style.
3180 * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3181 style.
3182 * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3183 style.
3184 * ada-lang.c (user_select_syms): Use metadata style.
3185
3186 2019-10-01 Tom Tromey <tom@tromey.com>
3187
3188 * cli/cli-cmds.c (pwd_command): Style output.
3189
3190 2019-10-01 Pedro Alves <palves@redhat.com>
3191 Tom Tromey <tom@tromey.com>
3192
3193 * symtab.c (print_symbol_info): Use %ps.
3194 (print_msymbol_info): Use %ps.
3195 * symfile.c (symbol_file_add_with_addrs): Use %ps.
3196 * printcmd.c (print_variable_and_value): Use %ps.
3197 * macrocmd.c (show_pp_source_pos): Use %ps.
3198 * infrun.c (print_exited_reason): Use ui_out::message.
3199 * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3200 (describe_other_breakpoints): Use ui_out::message and new
3201 formats.
3202 (say_where): Use new formats.
3203 (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3204 and new formats.
3205
3206 2019-10-01 Pedro Alves <palves@redhat.com>
3207 Tom Tromey <tom@tromey.com>
3208
3209 * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3210 (test_gdb_formats): New function.
3211 (run_tests): Call it.
3212 (test_format_specifier): Update.
3213 * utils.h (fputs_filtered): Update comment.
3214 (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3215 (fputs_styled_unfiltered): Declare.
3216 * utils.c (fputs_styled_unfiltered): New function.
3217 (vfprintf_maybe_filtered): Add gdbfmt parameter.
3218 (vfprintf_filtered): Update.
3219 (vfprintf_unfiltered, vprintf_filtered): Update.
3220 (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3221 * ui-out.h (enum ui_out_flag) <unfiltered_output,
3222 disallow_ui_out_field>: New constants.
3223 (enum class field_kind): New.
3224 (struct base_field_s, struct signed_field_s): New.
3225 (signed_field): New function.
3226 (struct string_field_s): New.
3227 (string_field): New function.
3228 (struct styled_string_s): New.
3229 (styled_string): New function.
3230 (class ui_out) <message>: Add comment.
3231 <vmessage, call_do_message>: New methods.
3232 <do_message>: Add style parameter.
3233 * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3234 methods.
3235 (ui_out::message): Rewrite.
3236 * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3237 parameter.
3238 * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3239 * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3240 gdb_extensions parameter.
3241 (class format_piece): Add parameter to constructor.
3242 (n_int_args): New field.
3243 * gdbsupport/format.c (format_pieces::format_pieces): Add
3244 gdb_extensions parameter. Handle '*'.
3245 * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3246 * cli-out.c (cli_ui_out::do_message): Add style parameter. Call
3247 vfprintf_styled_no_gdbfmt.
3248 (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3249 (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3250 unfiltered output.
3251 * ui-style.h (struct ui_file_style) <ptr>: New method.
3252
3253 2019-10-01 Tom Tromey <tom@tromey.com>
3254
3255 * unittests/format_pieces-selftests.c: Update. Add final format.
3256 * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3257 empty literal pieces.
3258
3259 2019-10-01 Tom Tromey <tom@tromey.com>
3260
3261 * ui-out.h (enum class ui_out_style_kind): Remove.
3262 (class ui_out) <field_string, field_stsream, do_field_string>:
3263 Change type of "style".
3264 * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3265 (ui_out::field_string): Update.
3266 * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3267 of "style".
3268 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3269 * tracepoint.c (print_one_static_tracepoint_marker): Update.
3270 * stack.c (print_frame_arg, print_frame_info, print_frame):
3271 Update.
3272 * source.c (print_source_lines_base): Update.
3273 * solib.c (info_sharedlibrary_command): Update.
3274 * skip.c (info_skip_command): Update.
3275 * record-btrace.c (btrace_call_history_src_line)
3276 (btrace_call_history): Update.
3277 * python/py-framefilter.c (py_print_frame): Update.
3278 * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
3279 "style".
3280 * mi/mi-out.c (mi_ui_out::do_table_header)
3281 (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
3282 (mi_ui_out::do_field_string): Update.
3283 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3284 Update.
3285 * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
3286 "style".
3287 * cli-out.c (cli_ui_out::do_table_header)
3288 (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
3289 (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
3290 (cli_ui_out::do_field_fmt): Update.
3291 * breakpoint.c (print_breakpoint_location): Update.
3292 (update_static_tracepoint): Update.
3293
3294 2019-10-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3295
3296 * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
3297 conversion of gdb_datadir.
3298 (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
3299 remove not needed c_str ().
3300
3301 2019-09-30 Ali Tamur <tamur@google.com>
3302
3303 * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
3304 (dwarf2_string_attr): Likewise.
3305
3306 2019-09-30 Ali Tamur <tamur@google.com>
3307
3308 * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
3309 (process_full_type_unit): Likewise.
3310 (dump_die_shallow): Likewise.
3311 (cu_debug_loc_section): Likewise.
3312
3313 2019-09-28 Christian Biesinger <cbiesinger@google.com>
3314
3315 * minsyms.c (compare_minimal_symbols): Rename to...
3316 (minimal_symbol_is_less_than): ...this, and adjust to STL
3317 conventions (return bool, take arguments as references)
3318 (minimal_symbol_reader::install): Call std::sort instead
3319 of qsort.
3320
3321 2019-09-29 Christian Biesinger <cbiesinger@google.com>
3322
3323 * minsyms.h (msymbol_hash): Document that this is a case-insensitive
3324 hash and why.
3325 * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
3326 msymbol_hash, msymbol_demangled_hash>: Improve comments.
3327
3328 2019-09-30 Simon Marchi <simon.marchi@polymtl.ca>
3329
3330 * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
3331 * psympriv.h (add_psymbol_to_list): Move comment here and update
3332 it.
3333
3334 2019-09-29 Tom de Vries <tdevries@suse.de>
3335
3336 * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
3337 Use $tmpdir/$(basename "$output_file").dwz instead of
3338 "${output_file}.dwz".
3339
3340 2019-09-28 Simon Marchi <simon.marchi@polymtl.ca>
3341
3342 PR gdb/25045
3343 * hppa-linux-nat.c: Include gdbarch.h.
3344
3345 2019-09-26 Christian Biesinger <cbiesinger@google.com>
3346
3347 * blockframe.c (find_pc_partial_function): Change return type to bool.
3348 * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
3349 * minsyms.c (in_gnu_ifunc_stub): Likewise.
3350 (stub_gnu_ifunc_resolve_name): Likewise.
3351 * symtab.c (compare_filenames_for_search): Likewise.
3352 (compare_glob_filenames_for_search): Likewise.
3353 (matching_obj_sections): Likewise.
3354 (symbol_matches_domain): Likewise.
3355 (find_line_symtab): Change out param EXACT_MATCH to bool *.
3356 (find_line_pc): Change return type to bool.
3357 (find_line_pc_range): Likewise.
3358 (producer_is_realview): Likewise.
3359 * symtab.h (symbol_matches_domain): Likewise.
3360 (find_pc_partial_function): Likewise.
3361 (find_pc_line_pc_range): Likewise.
3362 (in_gnu_ifunc_stub): Likewise.
3363 (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
3364 (find_line_pc): Likewise.
3365 (find_line_pc_range): Likewise.
3366 (matching_obj_sections): Likewise.
3367 (find_line_symtab): Change out parameter to bool.
3368 (producer_is_realview): Change return type to bool.
3369 (compare_filenames_for_search): Likewise.
3370 (compare_glob_filenames_for_search): Likewise.
3371
3372 2019-09-26 Tom Tromey <tom@tromey.com>
3373
3374 * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
3375 (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
3376 * gdb_usleep.h: Remove.
3377 * gdb_usleep.c: Remove.
3378 * utils.c: Don't include gdb_usleep.h.
3379
3380 2019-09-26 Tom Tromey <tromey@adacore.com>
3381
3382 * python/py-type.c (type_to_type_object): Call check_typedef
3383 for stub types.
3384
3385 2019-09-26 Tom Tromey <tom@tromey.com>
3386
3387 * utils.h (initialize_utils): Don't declare.
3388 * top.c (gdb_init): Don't call initialize_utils.
3389 * utils.c (initialize_utils): Remove. Move contents...
3390 (_initialize_utils): ... here.
3391
3392 2019-09-25 Tom Tromey <tom@tromey.com>
3393
3394 * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
3395 * utils.h (make_hex_string): Don't declare.
3396 * utils.c (make_hex_string): Remove.
3397
3398 2019-09-24 Tom de Vries <tdevries@suse.de>
3399
3400 PR gdb/23815
3401 * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
3402 Initialize xstateregs before ptrace PTRACE_GETREGSET call.
3403
3404 2019-09-23 Dimitar Dimitrov <dimitar@dinux.eu>
3405
3406 * NEWS: Mention new simulator port for PRU.
3407
3408 2019-09-23 Christian Biesinger <cbiesinger@google.com>
3409
3410 * ada-exp.y (write_object_remaining): Update.
3411 * ada-lang.c (ada_decode): Return a std::string instead of a char*
3412 and eliminate the static buffer.
3413 (ada_decode_symbol): Update.
3414 (ada_la_decode): Update.
3415 (ada_sniff_from_mangled_name): Update.
3416 (is_valid_name_for_wild_match): Update.
3417 (ada_lookup_name_info::matches): Update and simplify.
3418 (name_matches_regex): Update.
3419 (ada_add_global_exceptions): Update.
3420 * ada-lang.h (ada_decode): Update signature.
3421 * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
3422 * dwarf-index-write.c (debug_names::insert): Update.
3423
3424 2019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
3425
3426 * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
3427 formatting.
3428
3429 2019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
3430
3431 * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
3432 Change "nonzero" to "true" in documentation.
3433
3434 2019-09-20 Christian Biesinger <cbiesinger@google.com>
3435
3436 * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
3437 (_initialize_darwin_solib): Don't set
3438 darwin_so_ops.lookup_lib_global_symbol.
3439 * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
3440 set_gdbarch_iterate_over_objfiles_in_search_order.
3441 (elf_lookup_lib_symbol): Rename to...
3442 (svr4_iterate_over_objfiles_in_search_order): this, and update
3443 to iterate semantics.
3444 (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
3445 * solib.c (solib_global_lookup): Remove.
3446 * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
3447 (solib_global_lookup): Remove.
3448 * symtab.c (lookup_global_or_static_symbol): Remove call to
3449 solib_global_lookup.
3450
3451 2019-09-20 Joel Brobecker <brobecker@adacore.com>
3452
3453 * NEWS: Move entries about default MI version now being
3454 version 3, and about the GDB/MI fix for multi-location
3455 breakpoints to the "since GDB 8.3" section.
3456
3457 2019-09-20 Joel Brobecker <brobecker@adacore.com>
3458
3459 GDB 8.3.1 released.
3460
3461 2019-09-20 Ulrich Weigand <uweigand@de.ibm.com>
3462
3463 * NEWS: Mention that Cell/B.E. debugging support was removed.
3464 * MAINTAINERS: Remove spu target.
3465
3466 * config/djgpp/fnchange.lst: Remove entries for removed files.
3467
3468 * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
3469 spu-multiarch.o, and spu-tdep.o.
3470 (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
3471 (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
3472 spu-multiarch.c, and spu-tdep.c.
3473 * spu-linux-nat.c: Remove file.
3474 * spu-multiarch.c: Remove file.
3475 * spu-tdep.c: Remove file.
3476 * spu-tdep.h: Remove file.
3477 * solib-spu.c: Remove file.
3478 * solib-spu.h: Remove file.
3479
3480 * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
3481 * configure.nat (spu-linux): Remove.
3482 * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
3483 solib-multiarch.o from gdb_target_obs.
3484 (spu*-*-*): Remove.
3485
3486 * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
3487 feature flag.
3488 (ppc_linux_no_features): Update.
3489 * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
3490 Cell/B.E. support.
3491 * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
3492 (tdesc_powerpc_cell64l): Likewise.
3493 * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
3494 * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
3495 Cell/B.E. support.
3496 * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
3497 Do not include "features/rs6000/powerpc-cell32l.c" or
3498 "features/rs6000/powerpc-cell64l.c".
3499 (ppc_linux_spu_section): Remove.
3500 (ppc_linux_core_read_description): Remove Cell/B.E. support.
3501 (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
3502 spe_context_cache_ptid, spe_context_cache_ptid): Remove.
3503 (ppc_linux_spe_context_lookup): Remove.
3504 (ppc_linux_spe_context_inferior_created): Remove.
3505 (ppc_linux_spe_context_solib_loaded): Remove.
3506 (ppc_linux_spe_context_solib_unloaded): Remove.
3507 (ppc_linux_spe_context): Remove.
3508 (struct ppu2spu_cache): Remove.
3509 (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
3510 (struct ppu2spu_data): Remove.
3511 (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
3512 ppu2spu_unwind): Remove.
3513 (ppc_linux_init_abi): Remove Cell/B.E. support.
3514 * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
3515
3516 * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
3517 (rs6000/powerpc-cell64l-expedite): Likewise
3518 (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
3519 (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
3520 rs6000/powerpc-cell64l.xml.
3521 * features/rs6000/powerpc-cell32l.xml: Remove.
3522 * features/rs6000/powerpc-cell64l.xml: Likewise.
3523 * features/rs6000/powerpc-cell32l.c: Remove generated file.
3524 * features/rs6000/powerpc-cell64l.c: Likewise.
3525 * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
3526 * regformats/rs6000/powerpc-cell64l.dat: Likewise.
3527 * regformats/reg-spu.dat: Remove.
3528
3529 * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
3530 * corelow.c (struct spuid_list): Remove.
3531 (add_to_spuid_list): Remove.
3532 (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3533 * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
3534 (remote_protocol_features): Remove associated entries.
3535 (_initialize_remote): No longer initialize them.
3536 (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3537 * linux-nat.c (SPUFS_MAGIC): Remove.
3538 (linux_proc_xfer_spu): Remove.
3539 (spu_enumerate_spu_ids): Remove.
3540 (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3541 * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
3542 (linux_make_corefile_notes): No longer call it.
3543
3544 * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
3545 (cooked_write_test): Likewise.
3546
3547 2019-09-20 Tom Tromey <tom@tromey.com>
3548
3549 * NEWS: Mention case-sensitivity of TUI commands.
3550 * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
3551 (tui_set_win_height_command, parse_scrolling_args): Likewise.
3552 * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
3553
3554 2019-09-20 Tom Tromey <tom@tromey.com>
3555
3556 * tui/tui-source.c (tui_source_window::set_contents): Use
3557 make_unique_xstrdup.
3558 * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
3559 make_unique_xstrdup.
3560
3561 2019-09-20 Tom Tromey <tom@tromey.com>
3562
3563 * tui/tui-data.c: Remove separator comments.
3564 * tui/tui-layout.c: Remove separator comments.
3565 * tui/tui-win.c: Remove separator comments.
3566 * tui/tui-wingeneral.c: Remove separator comments.
3567
3568 2019-09-20 Tom Tromey <tom@tromey.com>
3569
3570 * tui/tui.h (strcat_to_buf): Don't declare.
3571 * tui/tui.c (strcat_to_buf): Remove.
3572
3573 2019-09-20 Tom Tromey <tom@tromey.com>
3574
3575 * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
3576 from "fullname".
3577 * tui/tui-source.c (tui_source_window::set_contents)
3578 (tui_source_window::location_matches_p)
3579 (tui_source_window::maybe_update): Update.
3580
3581 2019-09-20 Tom Tromey <tom@tromey.com>
3582
3583 * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
3584 Update.
3585 <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
3586 prefix.
3587 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
3588 (tui_data_window::line_from_reg_element_no)
3589 (tui_data_window::first_reg_element_no_inline)
3590 (tui_data_window::show_registers)
3591 (tui_data_window::show_register_group)
3592 (tui_data_window::display_registers_from)
3593 (tui_data_window::display_registers_from_line)
3594 (tui_data_window::first_data_item_displayed)
3595 (tui_data_window::delete_data_content_windows)
3596 (tui_data_window::erase_data_content)
3597 (tui_data_window::do_scroll_vertical)
3598 (tui_data_window::refresh_window)
3599 (tui_data_window::check_register_values): Update.
3600
3601 2019-09-20 Tom Tromey <tom@tromey.com>
3602
3603 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
3604 (struct tui_locator_window) <full_name, proc_name>: Now
3605 std::string.
3606 * tui/tui-stack.c (tui_locator_window::make_status_line)
3607 (tui_locator_window::set_locator_fullname)
3608 (tui_locator_window::set_locator_info): Update.
3609 * tui/tui-source.c (tui_source_window::set_contents)
3610 (tui_source_window::showing_source_p): Update.
3611
3612 2019-09-20 Tom Tromey <tom@tromey.com>
3613
3614 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
3615 Don't call tui_locator_win_info_ptr.
3616
3617 2019-09-20 Tom Tromey <tom@tromey.com>
3618
3619 * tui/tui-win.c (tui_resize_all): Don't call refresh.
3620
3621 2019-09-20 Tom Tromey <tom@tromey.com>
3622
3623 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
3624 height for locator.
3625 * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
3626 * tui/tui-layout.c (show_source_disasm_command, show_data)
3627 (show_source_or_disasm_and_command): Use 1 as height for locator.
3628
3629 2019-09-20 Tom Tromey <tom@tromey.com>
3630
3631 * tui/tui.c (tui_enable): Update.
3632 * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
3633 Update.
3634 * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
3635 Update.
3636 * tui/tui-data.c (win_resized): Now bool.
3637 (tui_win_resized): Return bool.
3638 (tui_set_win_resized_to): Accept a bool.
3639
3640 2019-09-20 Tom Tromey <tom@tromey.com>
3641
3642 * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
3643 Change type of "refresh_values_only".
3644 * tui/tui-regs.c (tui_data_window::show_register_group): Change
3645 type of "refresh_values_only".
3646
3647 2019-09-20 Tom Tromey <tom@tromey.com>
3648
3649 * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
3650 std::string.
3651 (tui_disassemble): Add "pos" parameter.
3652 (tui_disasm_window::set_contents): Simplify.
3653
3654 2019-09-20 Tom Tromey <tom@tromey.com>
3655
3656 * tui/tui-winsource.h (struct tui_source_window_base)
3657 <show_source_content>: Now private.
3658 * tui/tui-winsource.c
3659 (tui_source_window_base::show_source_content): Don't handle empty
3660 content case.
3661
3662 2019-09-20 Tom Tromey <tom@tromey.com>
3663
3664 * tui/tui-layout.c (show_source_disasm_command)
3665 (show_source_or_disasm_and_command): Don't call
3666 show_source_content.
3667
3668 2019-09-20 Tom Tromey <tom@tromey.com>
3669
3670 * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
3671 Declare.
3672 * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
3673 from tui_make_status_line.
3674 (tui_locator_window::rerender): Update.
3675
3676 2019-09-20 Tom Tromey <tom@tromey.com>
3677
3678 * tui/tui-stack.c (tui_make_status_line): Return std::string.
3679 (tui_locator_window::rerender): Update.
3680
3681 2019-09-20 Tom Tromey <tom@tromey.com>
3682
3683 * tui/tui-winsource.h (struct tui_source_window_base)
3684 <~tui_source_window_base>: Don't declare.
3685 <fullname>: Remove.
3686 * tui/tui-winsource.c (~tui_source_window_base): Remove.
3687 * tui/tui-source.h (struct tui_source_window) <fullname>: New
3688 member.
3689 * tui/tui-source.c (tui_source_window::set_contents): Update.
3690 (tui_source_window::location_matches_p)
3691 (tui_source_window::maybe_update): Update.
3692
3693 2019-09-20 Tom Tromey <tom@tromey.com>
3694
3695 * tui/tui-winsource.h (~tui_source_element): Remove.
3696 (tui_source_element): Update.
3697 (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
3698 * tui/tui-winsource.c (tui_show_source_line): Update.
3699 * tui/tui-source.c (tui_source_window::set_contents): Update.
3700 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3701
3702 2019-09-20 Tom Tromey <tom@tromey.com>
3703
3704 * tui/tui-data.h (tui_clear_source_windows_detail): Don't
3705 declare.
3706 * tui/tui-layout.c (tui_add_win_to_layout): Don't call
3707 tui_clear_source_windows_detail.
3708 * tui/tui-winsource.h (struct tui_source_window_base)
3709 <clear_detail>: Don't declare.
3710 * tui/tui-winsource.c (tui_source_window_base::clear_detail):
3711 Remove.
3712 * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
3713
3714 2019-09-20 Tom Tromey <tromey@adacore.com>
3715
3716 PR ada/24919:
3717 * block.c (contained_in): Fix final return value.
3718
3719 2019-09-20 Alan Modra <amodra@gmail.com>
3720
3721 * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
3722 * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
3723 (read_indirect_string_from_dwz): Use bfd accessor.
3724 * dwarf2read.h (struct dwz_file <filename>): Likewise.
3725 * machoread.c (macho_symfile_read_all_oso): Likewise.
3726 * solib.c (solib_bfd_open): Likewise.
3727
3728 2019-09-19 Christian Biesinger <cbiesinger@google.com>
3729
3730 * eval.c: Move declaration of overload_resolution to...
3731 * value.h: ...here.
3732
3733 2019-09-19 Christian Biesinger <cbiesinger@google.com>
3734
3735 * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
3736 * arm-linux-tdep.c: Likewise.
3737 * arm-nbsd-nat.c: Likewise.
3738 * arm-tdep.h: Declare arm_apcs_32.
3739 * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
3740
3741 2019-09-19 Christian Biesinger <cbiesinger@google.com>
3742
3743 * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
3744 * dwarf2read.h: Declare dwarf_always_disassemble.
3745
3746 2019-09-19 Tom de Vries <tdevries@suse.de>
3747
3748 PR gdb/25009
3749 * source-cache.c (source_cache::ensure): Catch exception thrown during
3750 construction of the highlighter.
3751
3752 2019-09-18 Alan Modra <amodra@gmail.com>
3753
3754 * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
3755 * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
3756 * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
3757 * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
3758 * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
3759 * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
3760 * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
3761 * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
3762 * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
3763 * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
3764 * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
3765 * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
3766 * solib-spu.c, * solib-svr4.c, * solib-target.c,
3767 * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
3768 * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
3769 * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
3770 * mi/mi-interp.c: Update throughout for bfd section macro and
3771 function changes.
3772 * gcore (gcore_create_callback): Use bfd_set_section_lma.
3773 * spu-tdep.c (spu_overlay_new_objfile): Likewise.
3774
3775 2019-09-18 Tom Tromey <tom@tromey.com>
3776
3777 * NEWS: Add entry.
3778 * tui/tui.c (tui_initialize_readline): Set name of keymap. Do not
3779 call rl_initialize.
3780 (tui_enable): Do not call rl_initialize.
3781
3782 2019-09-18 Christian Groessler <chris@groessler.org>
3783
3784 * alpha-linux-nat.c: Include gdbarch.h.
3785
3786 2019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
3787
3788 * ui-file.c: Include cli/cli-style.h.
3789 (term_cli_styling): Remove cli_styling declaration.
3790
3791 2019-09-18 Alan Modra <amodra@gmail.com>
3792
3793 * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
3794 to bfd_asymbol_section.
3795
3796 2019-09-18 Alan Modra <amodra@gmail.com>
3797
3798 * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
3799 * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
3800 * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
3801
3802 2019-09-18 Alan Modra <amodra@gmail.com>
3803
3804 * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
3805 * spu-linux-nat.c (spu_bfd_open): Likewise.
3806
3807 2019-09-18 Christian Biesinger <cbiesinger@google.com>
3808
3809 * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
3810 to bool to match definition in dwarf2read.c.
3811
3812 2019-09-17 Christian Biesinger <cbiesinger@google.com>
3813
3814 * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
3815 (print_signatures): Likewise.
3816 (trust_pad_over_xvs): Likewise.
3817 * arch/aarch64-insn.c (aarch64_debug): Likewise.
3818 * arch/aarch64-insn.h (aarch64_debug): Likewise.
3819 * arm-linux-nat.c (arm_apcs_32): Likewise.
3820 * arm-linux-tdep.c (arm_apcs_32): Likewise.
3821 * arm-nbsd-nat.c (arm_apcs_32): Likewise.
3822 * arm-tdep.c (arm_debug): Likewise.
3823 (arm_apcs_32): Likewise.
3824 * auto-load.c (debug_auto_load): Likewise.
3825 (auto_load_gdb_scripts): Likewise.
3826 (global_auto_load): Likewise.
3827 (auto_load_local_gdbinit): Likewise.
3828 (auto_load_local_gdbinit_loaded): Likewise.
3829 * auto-load.h (global_auto_load): Likewise.
3830 (auto_load_local_gdbinit): Likewise.
3831 (auto_load_local_gdbinit_loaded): Likewise.
3832 * breakpoint.c (disconnected_dprintf): Likewise.
3833 (breakpoint_proceeded): Likewise.
3834 (automatic_hardware_breakpoints): Likewise.
3835 (always_inserted_mode): Likewise.
3836 (target_exact_watchpoints): Likewise.
3837 (_initialize_breakpoint): Update.
3838 * breakpoint.h (target_exact_watchpoints): Change to bool.
3839 * btrace.c (maint_btrace_pt_skip_pad): Likewise.
3840 * cli/cli-cmds.c (trace_commands): Likewise.
3841 * cli/cli-cmds.h (trace_commands): Likewise.
3842 * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
3843 to bool*.
3844 * cli/cli-logging.c (logging_overwrite): Change to bool.
3845 (logging_redirect): Likewise.
3846 (debug_redirect): Likewise.
3847 * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
3848 (struct boolean_option_def) <get_var_address_cb_>: Change return type
3849 to bool.
3850 <boolean_option_def>: Update.
3851 (struct flag_option_def): Change default type of Context to bool
3852 from int.
3853 <flag_option_def>: Change return type of var_address_cb_ to bool*.
3854 * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
3855 (get_setshow_command_value_string): Likewise.
3856 * cli/cli-style.c (cli_styling): Change to bool.
3857 (source_styling): Likewise.
3858 * cli/cli-style.h (source_styling): Likewise.
3859 (cli_styling): Likewise.
3860 * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
3861 to bool.
3862 * command.h (var_types): Update comment.
3863 (add_setshow_boolean_cmd): Change int* var argument to bool*.
3864 * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
3865 bool.
3866 (debug_compile_cplus_scopes): Likewise.
3867 * compile/compile-internal.h (compile_debug): Likewise.
3868 * compile/compile.c (compile_debug): Likewise.
3869 (struct compile_options) <raw>: Likewise.
3870 * cp-support.c (catch_demangler_crashes): Likewise.
3871 * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
3872 (usr_cmd_cris_dwarf2_cfi): Likewise.
3873 * csky-tdep.c (csky_debug): Likewise.
3874 * darwin-nat.c (enable_mach_exceptions): Likewise.
3875 * dcache.c (dcache_enabled_p): Likewise.
3876 * defs.h (info_verbose): Likewise.
3877 * demangle.c (demangle): Likewise.
3878 (asm_demangle): Likewise.
3879 * dwarf-index-cache.c (debug_index_cache): Likewise.
3880 * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
3881 * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
3882 * dwarf2read.c (check_physname): Likewise.
3883 (use_deprecated_index_sections): Likewise.
3884 (dwarf_always_disassemble): Likewise.
3885 * eval.c (overload_resolution): Likewise.
3886 * event-top.c (set_editing_cmd_var): Likewise.
3887 (exec_done_display_p): Likewise.
3888 * event-top.h (set_editing_cmd_var): Likewise.
3889 (exec_done_display_p): Likewise.
3890 * exec.c (write_files): Likewise.
3891 * fbsd-nat.c (debug_fbsd_lwp): Likewise
3892 (debug_fbsd_nat): Likewise.
3893 * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
3894 Likewise.
3895 (struct set_backtrace_options) <backtrace_past_main>: Likewise.
3896 <backtrace_past_entry> Likewise.
3897 * gdb-demangle.h (demangle): Likewise.
3898 (asm_demangle): Likewise.
3899 * gdb_bfd.c (bfd_sharing): Likewise.
3900 * gdbcore.h (write_files): Likewise.
3901 * gdbsupport/common-debug.c (show_debug_regs): Likewise.
3902 * gdbsupport/common-debug.h (show_debug_regs): Likewise.
3903 * gdbthread.h (print_thread_events): Likewise.
3904 * gdbtypes.c (opaque_type_resolution): Likewise.
3905 (strict_type_checking): Likewise.
3906 * gnu-nat.c (gnu_debug_flag): Likewise.
3907 * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
3908 * guile/scm-param.c (pascm_variable): Add boolval.
3909 (add_setshow_generic): Update.
3910 (pascm_param_value): Update.
3911 (pascm_set_param_value_x): Update.
3912 * hppa-tdep.c (hppa_debug): Change to bool..
3913 * infcall.c (may_call_functions_p): Likewise.
3914 (coerce_float_to_double_p): Likewise.
3915 (unwind_on_signal_p): Likewise.
3916 (unwind_on_terminating_exception_p): Likewise.
3917 * infcmd.c (startup_with_shell): Likewise.
3918 * inferior.c (print_inferior_events): Likewise.
3919 * inferior.h (startup_with_shell): Likewise.
3920 (print_inferior_events): Likewise.
3921 * infrun.c (step_stop_if_no_debug): Likewise.
3922 (detach_fork): Likewise.
3923 (debug_displaced): Likewise.
3924 (disable_randomization): Likewise.
3925 (non_stop): Likewise.
3926 (non_stop_1): Likewise.
3927 (observer_mode): Likewise.
3928 (observer_mode_1): Likewise.
3929 (set_observer_mode): Update.
3930 (sched_multi): Change to bool.
3931 * infrun.h (debug_displaced): Likewise.
3932 (sched_multi): Likewise.
3933 (step_stop_if_no_debug): Likewise.
3934 (non_stop): Likewise.
3935 (disable_randomization): Likewise.
3936 * linux-tdep.c (use_coredump_filter): Likewise.
3937 (dump_excluded_mappings): Likewise.
3938 * linux-thread-db.c (auto_load_thread_db): Likewise.
3939 (check_thread_db_on_load): Likewise.
3940 * main.c (captured_main_1): Update.
3941 * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
3942 xx2_opt, boolean_opt>: Change to bool.
3943 * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
3944 * maint.c (maintenance_profile_p): Likewise.
3945 (per_command_time): Likewise.
3946 (per_command_space): Likewise.
3947 (per_command_symtab): Likewise.
3948 * memattr.c (inaccessible_by_default): Likewise.
3949 * mi/mi-main.c (mi_async): Likewise.
3950 (mi_async_1): Likewise.
3951 * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
3952 * nat/fork-inferior.h (startup_with_shell): Likewise.
3953 * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
3954 * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
3955 * nios2-tdep.c (nios2_debug): Likewise.
3956 * or1k-tdep.c (or1k_debug): Likewise.
3957 * parse.c (parser_debug): Likewise.
3958 * parser-defs.h (parser_debug): Likewise.
3959 * printcmd.c (print_symbol_filename): Likewise.
3960 * proc-api.c (procfs_trace): Likewise.
3961 * python/py-auto-load.c (auto_load_python_scripts): Likewise.
3962 * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
3963 (set_parameter_value): Update.
3964 (add_setshow_generic): Update.
3965 * python/py-value.c (copy_py_bool_obj): Change argument from int*
3966 to bool*.
3967 * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
3968 int*.
3969 * ravenscar-thread.c (ravenscar_task_support): Change to bool.
3970 * record-btrace.c (record_btrace_target::store_registers): Update.
3971 * record-full.c (record_full_memory_query): Change to bool.
3972 (record_full_stop_at_limit): Likewise.
3973 * record-full.h (record_full_memory_query): Likewise.
3974 * remote-notif.c (notif_debug): Likewise.
3975 * remote-notif.h (notif_debug): Likewise.
3976 * remote.c (use_range_stepping): Likewise.
3977 (interrupt_on_connect): Likewise.
3978 (remote_break): Likewise.
3979 * ser-tcp.c (tcp_auto_retry): Likewise.
3980 * ser-unix.c (serial_hwflow): Likewise.
3981 * skip.c (debug_skip): Likewise.
3982 * solib-aix.c (solib_aix_debug): Likewise.
3983 * spu-tdep.c (spu_stop_on_load_p): Likewise.
3984 (spu_auto_flush_cache_p): Likewise.
3985 * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
3986 Likewise.
3987 (struct info_print_options) <quiet>: Likewise.
3988 * symfile-debug.c (debug_symfile): Likewise.
3989 * symfile.c (auto_solib_add): Likewise.
3990 (separate_debug_file_debug): Likewise.
3991 * symfile.h (auto_solib_add): Likewise.
3992 (separate_debug_file_debug): Likewise.
3993 * symtab.c (basenames_may_differ): Likewise.
3994 (struct filename_partial_match_opts) <dirname, basename>: Likewise.
3995 (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
3996 (struct info_types_options) <quiet>: Likewise.
3997 * symtab.h (demangle): Likewise.
3998 (basenames_may_differ): Likewise.
3999 * target-dcache.c (stack_cache_enabled_1): Likewise.
4000 (code_cache_enabled_1): Likewise.
4001 * target.c (trust_readonly): Likewise.
4002 (may_write_registers): Likewise.
4003 (may_write_memory): Likewise.
4004 (may_insert_breakpoints): Likewise.
4005 (may_insert_tracepoints): Likewise.
4006 (may_insert_fast_tracepoints): Likewise.
4007 (may_stop): Likewise.
4008 (auto_connect_native_target): Likewise.
4009 (target_stop_and_wait): Update.
4010 (target_async_permitted): Change to bool.
4011 (target_async_permitted_1): Likewise.
4012 (may_write_registers_1): Likewise.
4013 (may_write_memory_1): Likewise.
4014 (may_insert_breakpoints_1): Likewise.
4015 (may_insert_tracepoints_1): Likewise.
4016 (may_insert_fast_tracepoints_1): Likewise.
4017 (may_stop_1): Likewise.
4018 * target.h (target_async_permitted): Likewise.
4019 (may_write_registers): Likewise.
4020 (may_write_memory): Likewise.
4021 (may_insert_breakpoints): Likewise.
4022 (may_insert_tracepoints): Likewise.
4023 (may_insert_fast_tracepoints): Likewise.
4024 (may_stop): Likewise.
4025 * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4026 (make_thread_apply_all_options_def_group): Change argument from int*
4027 to bool*.
4028 (thread_apply_all_command): Update.
4029 (print_thread_events): Change to bool.
4030 * top.c (confirm): Likewise.
4031 (command_editing_p): Likewise.
4032 (history_expansion_p): Likewise.
4033 (write_history_p): Likewise.
4034 (info_verbose): Likewise.
4035 * top.h (confirm): Likewise.
4036 (history_expansion_p): Likewise.
4037 * tracepoint.c (disconnected_tracing): Likewise.
4038 (circular_trace_buffer): Likewise.
4039 * typeprint.c (print_methods): Likewise.
4040 (print_typedefs): Likewise.
4041 * utils.c (debug_timestamp): Likewise.
4042 (sevenbit_strings): Likewise.
4043 (pagination_enabled): Likewise.
4044 * utils.h (sevenbit_strings): Likewise.
4045 (pagination_enabled): Likewise.
4046 * valops.c (overload_resolution): Likewise.
4047 * valprint.h (struct value_print_options) <prettyformat_arrays,
4048 prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4049 stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4050 pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4051 Likewise.
4052 * windows-nat.c (new_console): Likewise.
4053 (cygwin_exceptions): Likewise.
4054 (new_group): Likewise.
4055 (debug_exec): Likewise.
4056 (debug_events): Likewise.
4057 (debug_memory): Likewise.
4058 (debug_exceptions): Likewise.
4059 (useshell): Likewise.
4060 * windows-tdep.c (maint_display_all_tib): Likewise.
4061 * xml-support.c (debug_xml): Likewise.
4062
4063 2019-09-17 Mike Gulick <mgulick@mathworks.com>
4064
4065 * source.c (prepare_path_for_appending): New function.
4066 (openp): Make use of new function.
4067 (find_and_open_source): Search for the compilation directory and
4068 source file as a relative path beneath the directory search path.
4069
4070 2019-09-17 Andrew Burgess <andrew.burgess@embecosm.com>
4071
4072 * source-cache.c (source_cache::get_line_charpos): Catch
4073 exceptions and return false, this matches the behaviour documented
4074 in the header file.
4075
4076 2019-09-17 Joel Brobecker <brobecker@adacore.com>
4077
4078 * ada-tasks.c (info_task): Remove quoting of the task's name.
4079
4080 2019-09-16 Christian Biesinger <cbiesinger@google.com>
4081
4082 * symfile.c (auto_solib_add): Replace comment with a reference
4083 to the header file.
4084
4085 2019-09-14 Christian Biesinger <cbiesinger@google.com>
4086
4087 * NEWS: Mention that gdb can now be compiled with Python 3
4088 on Windows.
4089
4090 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4091
4092 * maint.c (maint_print_section_data::maint_print_section_data):
4093 Force use of 'float log10 (float)' by casting the argument to
4094 float.
4095
4096 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4097
4098 * maint.c: Add 'cmath' include.
4099 (struct maint_print_section_data): New structure.
4100 (print_section_index): New function.
4101 (print_bfd_section_info): Add header comment, small whitespace
4102 cleanup, and update to call new print_section_index function.
4103 (print_objfile_section_info): Likewise.
4104 (maint_obj_section_from_bfd_section): New function.
4105 (print_bfd_section_info_maybe_relocated): New function.
4106 (maintenance_info_sections): Add header comment, always use
4107 bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4108
4109 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4110
4111 * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4112 inner scope, add check that the objfile has psymtabs before
4113 checking psymtabs_addrmap.
4114 * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4115
4116 2019-09-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4117
4118 * NEWS: Announce that Ada task names are now shown at more places,
4119 and between quotes (except in info task output).
4120 * gdb/ada-tasks.c (task_to_str): New function.
4121 (display_current_task_id): Call task_to_str.
4122 (task_command_1): Likewise.
4123 (print_ada_task_info): In non-mi mode, Properly align headers and data
4124 when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4125
4126 2019-09-12 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
4127
4128 * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4129 prstatus.pr_lwp.pr_info instead of making it up.
4130
4131 2019-09-11 Christian Biesinger <cbiesinger@google.com>
4132
4133 * auto-load.c (auto_load_expand_dir_vars): Update.
4134 * defs.h (gdb_datadir): Change to std::string.
4135 (python_libdir): Likewise.
4136 (relocate_gdb_directory): Change return type to std::string.
4137 * guile/guile.c (gdbscm_data_directory): Update.
4138 (initialize_scheme_side): Update.
4139 * jit.c (jit_reader_dir): Change to std::string.
4140 (jit_reader_load_command): Update.
4141 * main.c (gdb_datadir): Change to std::string.
4142 (python_libdir): Likewise.
4143 (set_gdb_data_directory): Update.
4144 (relocate_path): Change to return std::string.
4145 (relocate_gdb_directory): Change to return std::string.
4146 (relocate_gdbinit_path_maybe_in_datadir): Update.
4147 (captured_main_1): Update.
4148 * python/python.c (do_start_initialization): Update.
4149 * top.c (show_gdb_datadir): Update.
4150 * xml-syscall.c (xml_init_syscalls_info): Update.
4151 (init_syscalls_info): Update.
4152
4153 2019-09-11 Christian Biesinger <cbiesinger@google.com>
4154
4155 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4156 out of get_init_files.
4157 (get_init_files): Update.
4158
4159 2019-09-11 Christian Biesinger <cbiesinger@google.com>
4160
4161 * main.c (get_init_files): Change to use std::string.
4162 (captured_main_1): Update.
4163 (print_gdb_help): Update.
4164
4165 2019-09-11 Ali Tamur <tamur@google.com>
4166
4167 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4168 implementation.
4169
4170 2019-09-11 Christian Biesinger <cbiesinger@google.com>
4171
4172 * dbxread.c (read_dbx_symtab): Update.
4173 * dwarf2read.c (load_partial_dies): Update.
4174 * mdebugread.c (parse_partial_symbols): Update.
4175 (handle_psymbol_enumerators): Update.
4176 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4177 * psymtab.c (add_psymbol_to_bcache): Likewise.
4178 (add_psymbol_to_list): Likewise.
4179 * symtab.c (symbol_set_names): Likewise.
4180 * symtab.h (symbol_set_names): Likewise.
4181 * xcoffread.c (scan_xcoff_symtab): Update.
4182
4183 2019-09-11 Tom Tromey <tom@tromey.com>
4184
4185 * symfile-mem.c (symbol_file_add_from_memory): Use
4186 bfd_set_filename.
4187 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4188 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4189
4190 2019-09-10 Tom Tromey <tromey@adacore.com>
4191
4192 * dwarf-index-write.c (write_psymbols): Extend error message.
4193 (debug_names::insert): Add Ada code.
4194 (debug_names::write_psymbols): Remove Ada check.
4195 (debug_names) <m_string_obstack>: New member.
4196 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4197 (gdb_index_symbol_name_matcher::matches): Remove.
4198 (mapped_index_base::find_name_components_bounds): Add "lang"
4199 parameter.
4200 (mapped_index_base::build_name_components): Also split names
4201 according to Ada syntax.
4202 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
4203 type of "match_callback".
4204 (check_match, check_find_bounds_finds)
4205 (dw2_expand_symtabs_matching): Update.
4206 (dw2_debug_names_iterator): Add new constructor.
4207 (dw2_debug_names_map_matching_symbols): New function.
4208 (dw2_debug_names_expand_symtabs_matching): Update.
4209 (dwarf2_debug_names_functions): Use
4210 dw2_debug_names_map_matching_symbols.
4211
4212 2019-09-10 Tom Tromey <tromey@adacore.com>
4213
4214 * dwarf2read.c (dw2_get_file_names_reader): Add the
4215 CU's file name to the results.
4216
4217 2019-09-10 Tom Tromey <tromey@adacore.com>
4218
4219 * ada-lang.c (add_nonlocal_symbols): Combine calls to
4220 map_matching_symbols. Update.
4221 * dwarf2read.c (dw2_map_matching_symbols): Update.
4222 * psymtab.c (match_partial_symbol): Change type; update.
4223 (psym_map_matching_symbols): Likewise.
4224 * symfile-debug.c (debug_qf_map_matching_symbols): Change
4225 type; update.
4226 * symfile.h (struct quick_symbol_functions)
4227 <map_matching_symbols>: Change "name" to be a lookup_name_info.
4228 Remove "match".
4229
4230 2019-09-10 Tom Tromey <tromey@adacore.com>
4231
4232 * psymtab.c (map_block): Remove.
4233 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4234 * symtab.c (iterate_over_symbols_terminated): New function.
4235 * symtab.c (iterate_over_symbols_terminated): Declare.
4236
4237 2019-09-10 Tom Tromey <tromey@adacore.com>
4238
4239 * ada-lang.c (ada_iterate_over_symbols): Return bool.
4240 * language.h (struct language_defn) <la_iterate_over_symbols>:
4241 Return bool.
4242 * symtab.c (iterate_over_symbols): Return bool.
4243 * symtab.h (iterate_over_symbols): Return bool.
4244
4245 2019-09-10 Tom Tromey <tromey@adacore.com>
4246
4247 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4248 (add_nonlocal_symbols): Update.
4249 * dwarf2read.c (dw2_map_matching_symbols): Change type.
4250 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4251 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4252 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4253 Change type of "callback". Remove "data".
4254
4255
4256 2019-09-09 Ali Tamur <tamur@google.com>
4257
4258 * dwarf2read.c (comp_unit_head): Update comment.
4259 (dwarf2_dwo_name): New function declaration.
4260 (dwarf_unit_type_name): New function declaration.
4261 (read_comp_unit_head): Add support for new compilation units,
4262 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4263 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
4264 (currently named as "signature") in their header. Also clarify error
4265 messages.
4266 (lookup_dwo_id): New function. Returns the dwo id of the given
4267 compile unit.
4268 (lookup_dwo_unit): Use the new lookup_dwo_id function.
4269 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
4270 functions.
4271 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
4272 (dwarf2_dwo_name): Get the dwo name if present.
4273 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
4274 purposes.
4275
4276 2019-09-09 Tom Tromey <tom@tromey.com>
4277
4278 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
4279
4280 2019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4281
4282 * python/python.c (do_start_initialization): Make progname_copy static,
4283 to avoid a leak report.
4284
4285 2019-09-08 Tom Tromey <tom@tromey.com>
4286
4287 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
4288
4289 2019-09-07 Simon Marchi <simon.marchi@efficios.com>
4290
4291 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
4292 Change type to gdb::optional<block_enum>.
4293 (dw2_symtab_iter_init): Change block_index parameter type
4294 to gdb::optional<block_enum>.
4295 (dw2_lookup_symbol): Change block_index parameter
4296 type to block_enum.c
4297 (dw2_debug_names_lookup_symbol): Likewise.
4298 * psymtab.c (psym_lookup_symbol): Likewise.
4299 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
4300 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
4301 Likewise.
4302
4303 2019-09-06 Christian Biesinger <cbiesinger@google.com>
4304
4305 * defs.h (relocate_gdb_directory): Change int to bool in
4306 signature and rename flag to relocatable.
4307 * main.c (relocate_path): Likewise.
4308 (relocate_gdb_directory): Likewise.
4309
4310 2019-09-06 Alan Modra <amodra@gmail.com>
4311
4312 * coffread.c (coff_symfile_read): Constify filename variable.
4313 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
4314 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
4315 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
4316 * solib.c (reload_shared_libraries_1): Likewise.
4317 * symfile.c (reread_symbols): Likewise.
4318 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
4319 * solib-darwin.c (darwin_bfd_open): Likewise.
4320 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
4321
4322 2019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
4323
4324 * psymtab.c (print_partial_symbols): Handle missing domain_enum
4325 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
4326
4327 2019-09-03 Tom Tromey <tromey@adacore.com>
4328
4329 * ada-valprint.c (ada_val_print_num): Don't recurse for range
4330 types.
4331 (has_negatives): Unbias a range type bound.
4332 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
4333 * gdbtypes.c (operator==): Handle new field.
4334 (create_range_type): Add "bias" parameter.
4335 (create_static_range_type, resolve_dynamic_range): Update.
4336 * gdbtypes.h (struct range_bounds) <bias>: New member.
4337 (create_range_type): Add bias parameter.
4338 * printcmd.c (print_scalar_formatted): Unbias range types.
4339 * value.c (unpack_long): Unbias range types.
4340 (pack_long): Bias range types.
4341
4342 2019-09-02 Alan Hayward <alan.hayward@arm.com>
4343
4344 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
4345 probe arguments.
4346
4347 2019-09-02 Alan Hayward <alan.hayward@arm.com>
4348
4349 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
4350 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
4351 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
4352 (compile_probe_arg): Likewise.
4353 * probe.h (get_argument_count): Likewise.
4354 * solib-svr4.c (solib_event_probe_action): Likewise.
4355 * stap-probe.c (stap_probe::get_argument_count): Likewise.
4356
4357 2019-09-02 Alan Hayward <alan.hayward@arm.com>
4358
4359 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
4360 code to here...
4361 (svr4_create_solib_event_breakpoints): ...from here.
4362
4363 2019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
4364
4365 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
4366 suffix from warning message.
4367
4368 2019-08-30 Tom Tromey <tom@tromey.com>
4369
4370 * tui/tui-winsource.h (struct tui_source_window_base)
4371 <refresh_all>: Don't declare.
4372 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
4373 Remove.
4374 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
4375 tui_show_locator_content.
4376 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
4377 declare.
4378 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
4379 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
4380 declare.
4381
4382 2019-08-30 Tom Tromey <tom@tromey.com>
4383
4384 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
4385
4386 2019-08-30 Tom Tromey <tom@tromey.com>
4387
4388 * tui/tui-stack.c (_initialize_tui_stack): Move later.
4389 Remove unnecessary forward declarations.
4390
4391 2019-08-30 Tom Tromey <tom@tromey.com>
4392
4393 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
4394 rerender.
4395 (tui_update_locator_fullname, tui_show_frame_info): Don't call
4396 tui_show_locator_content.
4397
4398 2019-08-30 Tom Tromey <tom@tromey.com>
4399
4400 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
4401 (tui_locator_window::rerender): Rewrite using body of previous
4402 tui_show_locator_content.
4403
4404 2019-08-30 Tom Tromey <tom@tromey.com>
4405
4406 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
4407 set_locator_fullname>: New methods.
4408 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4409 Rename from tui_set_locator_fullname.
4410 (tui_locator_window::set_locator_info): Rename from
4411 tui_set_locator_info. Return bool.
4412 (tui_update_locator_fullname, tui_show_frame_info): Update.
4413
4414 2019-08-30 Tom Tromey <tom@tromey.com>
4415
4416 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
4417
4418 2019-08-30 Tom Tromey <tom@tromey.com>
4419
4420 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
4421 call touchwin.
4422
4423 2019-08-30 Tom Tromey <tom@tromey.com>
4424
4425 * tui/tui-wingeneral.c (box_win): Assume win_info and
4426 win_info->handle cannot be NULL.
4427
4428 2019-08-30 Tom Tromey <tom@tromey.com>
4429
4430 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
4431 refresh_window>: Declare.
4432 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
4433 resize.
4434 (tui_data_item_window::rerender): Rename from
4435 tui_display_register.
4436 (tui_data_item_window::refresh_window): New method.
4437 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
4438 no-op.
4439
4440 2019-08-30 Tom Tromey <tom@tromey.com>
4441
4442 * tui/tui-regs.h (struct tui_data_window) <regs_content,
4443 regs_column_count, current_group>: Move later. Now private.
4444 <get_current_group>: New method.
4445 * tui/tui-regs.c (tui_reg_command): Update.
4446 * tui/tui-layout.c (tui_set_layout): Update.
4447
4448 2019-08-30 Tom Tromey <tom@tromey.com>
4449
4450 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4451 (tui_data_window::rerender): Don't call
4452 check_and_display_highlight_if_needed.
4453 (tui_data_window::refresh_all): Remove call to
4454 erase_data_content.
4455
4456 2019-08-30 Tom Tromey <tom@tromey.com>
4457
4458 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4459 (tui_data_window::display_registers_from)
4460 (tui_data_window::display_reg_element_at_line)
4461 (tui_data_window::display_registers_from_line): Remove checks of
4462 "empty".
4463
4464 2019-08-30 Tom Tromey <tom@tromey.com>
4465
4466 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
4467 Don't declare.
4468 * tui/tui-regs.c (tui_data_window::show_registers): Call
4469 rerender.
4470 (tui_data_window::rerender): Rename from display_all_data.
4471 (tui_data_window::rerender): Remove old implementation.
4472
4473 2019-08-30 Tom Tromey <tom@tromey.com>
4474
4475 * tui/tui-regs.c (tui_data_window::display_all_data): Change
4476 text.
4477 * tui/tui-data.h (NO_DATA_STRING): Remove define.
4478
4479 2019-08-29 Bernhard Wodok <barto@gmx.net>
4480 Sergio Durigan Junior <sergiodj@redhat.com>
4481
4482 PR win32/24284
4483 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
4484
4485 2019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
4486
4487 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
4488 when searching for types.
4489
4490 2019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
4491
4492 * f-lang.c (f_language_defn): Use f_print_typedef.
4493 * f-lang.h (f_print_typedef): Declare.
4494 * f-typeprint.c (f_print_typedef): Define.
4495
4496 2019-08-27 Christian Biesinger <cbiesinger@google.com>
4497
4498 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
4499
4500 2019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
4501
4502 * cli/cli-utils.c (info_print_options_defs): Delete.
4503 (make_info_print_options_def_group): Delete.
4504 (extract_info_print_options): Delete.
4505 (info_print_command_completer): Delete.
4506 (info_print_args_help): Add extra parameter, and optionally
4507 include text about -n flag.
4508 * cli/cli-utils.h (struct info_print_options): Delete.
4509 (extract_info_print_options): Delete declaration.
4510 (info_print_command_completer): Delete declaration.
4511 (info_print_args_help): Add extra parameter, extend header
4512 comment.
4513 * python/python.c (gdbpy_rbreak): Pass additional parameter to
4514 search_symbols.
4515 * stack.c (struct info_print_options): New type.
4516 (info_print_options_defs): New file scoped variable.
4517 (make_info_print_options_def_group): New static function.
4518 (info_print_command_completer): New static function.
4519 (info_locals_command): Update to use new local functions.
4520 (info_args_command): Likewise.
4521 (_initialize_stack): Add extra parameter to calls to
4522 info_print_args_help.
4523 * symtab.c (search_symbols): Add extra parameter, use this to
4524 possibly excluse non-debug symbols.
4525 (symtab_symbol_info): Add extra parameter, which is passed on to
4526 search_symbols.
4527 (struct info_print_options): New type.
4528 (info_print_options_defs): New file scoped variable.
4529 (make_info_print_options_def_group): New static function.
4530 (info_print_command_completer): New static function.
4531 (info_variables_command): Update to use local functions, and pass
4532 extra parameter through to symtab_symbol_info.
4533 (info_functions_command): Likewise.
4534 (info_types_command): Pass additional argument through to
4535 symtab_symbol_info.
4536 (rbreak_command): Pass extra argument to search_symbols.
4537 (_initialize_symtab): Add extra arguments for calls to
4538 info_print_args_help, and update help text for 'info variables',
4539 'whereis', and 'info functions' commands.
4540 * symtab.h (search_symbols): Add extra argument to declaration.
4541 * NEWS: Mention new flags.
4542
4543 2019-08-26 Christian Biesinger <cbiesinger@google.com>
4544
4545 * symtab.c (lookup_static_symbol): Call the new function (and move
4546 it down to be next to lookup_global_symbol).
4547 (struct global_sym_lookup_data): Add block_enum member and rename to...
4548 (struct global_or_static_sym_lookup_data): ...this.
4549 (lookup_symbol_global_iterator_cb): Pass block_index instead of
4550 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
4551 (lookup_symbol_global_or_static_iterator_cb): ...this.
4552 (lookup_global_or_static_symbol): New function.
4553 (lookup_global_symbol): Call new function.
4554
4555 2019-08-26 Tom de Vries <tdevries@suse.de>
4556
4557 PR c++/24852
4558 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
4559 when pc_probe.prob == NULL.
4560
4561 2019-08-25 Simon Marchi <simon.marchi@efficios.com>
4562
4563 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
4564 variable symbol_linkage to symbol_linkage_.
4565
4566 2019-08-25 Simon Marchi <simon.marchi@efficios.com>
4567
4568 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
4569 represent whether the symbol is static, dynamic, or we don't
4570 know.
4571
4572 2019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
4573
4574 * gdb/rx-tdep.c (rx_register_names): New.
4575 (rx_register_name): Delete.
4576 (rx_psw_type): Delete.
4577 (rx_fpsw_type): Delete.
4578 (rx_register_type): Delete.
4579 (rx_gdbarch_init): Convert target-descriptions.
4580 (_initialize_rx_tdep): Add initialize_tdesc_rx.
4581 * gdb/features/Makefile: Add rx.xml.
4582 * gdb/features/rx.xml: New.
4583 * gdb/features/rx.c: Generated.
4584 * gdb/NEWS: Mention target description support.
4585
4586 2019-08-22 Christian Biesinger <cbiesinger@google.com>
4587
4588 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
4589 *slot_ptr.
4590
4591 2019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
4592
4593 * configure.ac: Don't check for 'dlfcn.h' (moved to
4594 gdbsupport/common.m4).
4595 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
4596 'gdbsupport/'.
4597 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
4598 * compile/compile-c-support.c: Include
4599 'gdbsupport/gdb-dlfcn.h'.
4600 * gdbsupport/common.m4: Check for 'dlfcn.h'.
4601 * gdb-dlfcn.c: Move to...
4602 * gdbsupport/gdb-dlfcn.c: ... here.
4603 * gdb-dlfcn.h: Move to...
4604 * gdbsupport/gdb-dlfcn.h: ... here.
4605
4606 2019-08-23 Sandra Loosemore <sandra@codesourcery.com>
4607
4608 * nios2-tdep.c (struct reg_value): Improve comments. Make
4609 the offset field signed.
4610
4611 2019-08-22 Christian Biesinger <cbiesinger@google.com>
4612
4613 * python/lib/gdb/__init__.py (_execute_file): New function.
4614 * python/python.c (python_run_simple_file): Call gdb._execute_file
4615 on Windows.
4616
4617 2019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
4618
4619 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
4620 all uses as this was never set to anything but a zero value.
4621
4622 2019-08-21 Bogdan Harjoc <harjoc@gmail.com>
4623
4624 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
4625
4626 2019-08-21 Christian Biesinger <cbiesinger@google.com>
4627
4628 * tui/tui-data.h (tui_gen_win_info): Add an =default
4629 move constructor, required by some GCC versions.
4630
4631 2019-08-21 Jinke Fan <fanjinke51@yeah.net>
4632
4633 * go32-nat.c (go32_sysinfo): Add hygon_p.
4634
4635 2019-08-20 Tom Tromey <tom@tromey.com>
4636
4637 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
4638 line_from_reg_element_no, first_reg_element_no_inline,
4639 display_all_data, delete_data_content_windows,
4640 erase_data_content>: Now private.
4641
4642 2019-08-20 Tom Tromey <tom@tromey.com>
4643
4644 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
4645 (tui_unhighlight_win, tui_highlight_win)
4646 (tui_win_info::make_window): Update.
4647 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
4648
4649 2019-08-20 Tom Tromey <tom@tromey.com>
4650
4651 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4652 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4653 (MAX_PID_WIDTH): Move to tui-stack.c.
4654 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4655 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4656 (MAX_PID_WIDTH): Move from tui-data.h.
4657
4658 2019-08-20 Tom Tromey <tom@tromey.com>
4659
4660 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
4661 * tui/tui-wingeneral.c (box_win): Change type of win_info.
4662 (box_win): Update.
4663 (tui_gen_win_info::make_window): Rename from tui_make_window.
4664 (tui_win_info::make_window): New method.
4665 (tui_gen_win_info::make_visible): Update.
4666 * tui/tui-source.c (tui_source_window::set_contents): Update.
4667 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
4668 (tui_data_window::display_registers_from): Update.
4669 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
4670 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
4671 Declare.
4672 <can_box>: Remove.
4673 <title>: Remove.
4674 (struct tui_win_info) <make_window>: Declare.
4675 <can_box>: Now virtual.
4676 <title>: New member.
4677 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
4678 * tui/tui-command.c (tui_cmd_window::resize): Update.
4679
4680 2019-08-20 Tom Tromey <tom@tromey.com>
4681
4682 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
4683 * tui/tui-regs.c (tui_data_window::show_registers): Update.
4684 (tui_data_window::check_register_values): Update.
4685
4686 2019-08-20 Tom Tromey <tom@tromey.com>
4687
4688 * tui/tui-regs.h (struct tui_data_window): Use
4689 DISABLE_COPY_AND_ASSIGN.
4690 <regs_content>: Change type, removing unique_ptr.
4691 <tui_data_window>: Add move constructor.
4692 * tui/tui-regs.c (tui_data_window::show_registers)
4693 (tui_data_window::show_register_group)
4694 (tui_data_window::display_registers_from)
4695 (tui_data_window::display_registers_from)
4696 (tui_data_window::first_data_item_displayed)
4697 (tui_data_window::delete_data_content_windows)
4698 (tui_data_window::rerender, tui_data_window::refresh_window)
4699 (tui_data_window::check_register_values): Update.
4700
4701 2019-08-20 Tom Tromey <tom@tromey.com>
4702
4703 * tui/tui-regs.h (struct tui_data_window) <show_registers,
4704 show_register_group>: Declare.
4705 (tui_show_register_group): Don't declare.
4706 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
4707 tui_show_registers.
4708 (tui_data_window::show_register_group): Rename from
4709 tui_show_register_group.
4710 (tui_data_window::check_register_values, tui_reg_command):
4711 Update.
4712 * tui/tui-layout.c (tui_set_layout): Update.
4713
4714 2019-08-20 Tom Tromey <tom@tromey.com>
4715
4716 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
4717 Declare.
4718 (tui_check_register_values): Don't declare.
4719 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
4720 from tui_check_register_values.
4721 * tui/tui-hooks.c (tui_register_changed): Update.
4722
4723 2019-08-20 Tom Tromey <tom@tromey.com>
4724
4725 * tui/tui-regs.c (tui_reg_layout): Move later.
4726 (tui_show_registers): Don't enable TUI mode or change layout.
4727
4728 2019-08-20 Tom Tromey <tom@tromey.com>
4729
4730 * tui/tui-regs.h (struct tui_data_item_window)
4731 <~tui_data_item_window>: Remove.
4732 <content>: Now a unique_xmalloc_ptr.
4733 * tui/tui-regs.c (tui_register_format): Return a
4734 unique_xmalloc_ptr.
4735 (tui_get_register): Update.
4736 (~tui_data_item_window): Remove.
4737 (tui_data_window::display_registers_from, tui_display_register):
4738 Update.
4739 * tui/tui-io.h (tui_expand_tabs): Update.
4740 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
4741 Remove "col" parameter.
4742
4743 2019-08-20 Tom Tromey <tom@tromey.com>
4744
4745 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
4746 field.
4747 * tui/tui-regs.c (~tui_data_item_window): Update.
4748
4749 2019-08-20 Tom Tromey <tom@tromey.com>
4750
4751 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
4752 earlier.
4753
4754 2019-08-20 Tom Tromey <tom@tromey.com>
4755
4756 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
4757
4758 2019-08-20 Tom Tromey <tom@tromey.com>
4759
4760 * tui/tui-source.h (struct tui_source_window): Update.
4761 * tui/tui-regs.c (tui_show_registers): Update.
4762 * tui/tui-disasm.h (struct tui_disasm_window): Update.
4763 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
4764 (NO_REGS_STRING): Remove defines.
4765
4766 2019-08-20 Conrad Meyer <cem@FreeBSD.org>
4767
4768 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
4769 unnecessary thread walk if remote doesn't support the packet.
4770
4771 2019-08-19 Tom Tromey <tromey@adacore.com>
4772
4773 * python/py-value.c (value_has_field): Fix indentation.
4774
4775 2019-08-19 Tom Tromey <tromey@adacore.com>
4776
4777 * printcmd.c (do_one_display, info_display_command): Update.
4778 * block.h (contained_in): Return bool. Add allow_nested
4779 parameter.
4780 * block.c (contained_in): Return bool. Add allow_nested
4781 parameter.
4782
4783 2019-08-19 Tom Tromey <tom@tromey.com>
4784
4785 * configure: Rebuild.
4786 * configure.ac: Disallow the combination of -static-libstdc++ and
4787 source highlight.
4788 * source-cache.c (get_language_name): Handle rust.
4789 (source_cache::get_source_lines): Ignore highlighting exceptions.
4790
4791 2019-08-16 Tom Tromey <tom@tromey.com>
4792
4793 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
4794 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
4795 (struct tui_source_window_base) <make_visible, refresh_window,
4796 resize>: Remove methods.
4797 <execution_info>: Remove field.
4798 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
4799 (tui_show_source_line, tui_source_window_base)
4800 (~tui_source_window_base): Update.
4801 (tui_source_window_base::resize)
4802 (tui_source_window_base::make_visible)
4803 (tui_source_window_base::refresh_window): Remove.
4804 (tui_source_window_base::update_exec_info): Update.
4805 * tui/tui-source.c (tui_source_window::set_contents): Update.
4806 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4807
4808 2019-08-16 Tom Tromey <tom@tromey.com>
4809
4810 * tui/tui-hooks.c (tui_remove_hooks): Don't set
4811 deprecated_query_hook.
4812
4813 2019-08-16 Tom Tromey <tom@tromey.com>
4814
4815 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4816 (tui_update_source_windows_with_line): Update.
4817 * tui/tui-source.h (struct tui_source_window)
4818 <show_symtab_source>: Declare.
4819 (tui_show_symtab_source): Don't declare.
4820 * tui/tui-source.c (tui_show_symtab_source): Rename from
4821 tui_show_symtab_source.
4822
4823 2019-08-16 Tom Tromey <tom@tromey.com>
4824
4825 * tui/tui-winsource.h (struct tui_source_window_base)
4826 <set_contents>: Declare.
4827 * tui/tui-winsource.c
4828 (tui_source_window_base::update_source_window_as_is): Update.
4829 * tui/tui-source.h (struct tui_source_window) <set_contents>:
4830 Declare.
4831 (tui_set_source_content): Don't declare.
4832 * tui/tui-source.c (tui_source_window::set_contents): Rename from
4833 tui_set_source_content.
4834 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
4835 Declare.
4836 (tui_set_disassem_content): Don't declare.
4837 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
4838 tui_set_disassem_content.
4839
4840 2019-08-16 Tom Tromey <tom@tromey.com>
4841
4842 * tui/tui-winsource.h (struct tui_source_window_base)
4843 <update_breakpoint_info>: Declare.
4844 (tui_update_breakpoint_info): Don't declare.
4845 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
4846 (tui_update_all_breakpoint_info): Update.
4847 (tui_source_window_base::update_breakpoint_info): Rename from
4848 tui_update_breakpoint_info.
4849 (tui_source_window_base::update_exec_info): Update.
4850
4851 2019-08-16 Tom Tromey <tom@tromey.com>
4852
4853 * tui/tui-winsource.h (struct tui_source_window_base)
4854 <update_source_window>: Declare.
4855 (tui_update_source_window): Don't declare.
4856 * tui/tui-winsource.c
4857 (tui_source_window_base::update_source_window): Rename from
4858 tui_update_source_window.
4859 (tui_source_window_base::rerender): Update.
4860 * tui/tui-source.c (tui_source_window::maybe_update): Update.
4861 * tui/tui-disasm.c (tui_show_disassem)
4862 (tui_show_disassem_and_update_source)
4863 (tui_disasm_window::maybe_update): Update.
4864
4865 2019-08-16 Tom Tromey <tom@tromey.com>
4866
4867 * tui/tui-winsource.h (struct tui_source_window_base)
4868 <update_source_window_as_is>: Declare.
4869 (tui_update_source_window_as_is): Don't declare.
4870 * tui/tui-winsource.c (tui_update_source_window): Update
4871 (tui_source_window_base::update_source_window_as_is): Rename from
4872 tui_update_source_window_as_is.
4873 (tui_source_window_base::refill): Update.
4874 * tui/tui-source.c (tui_show_symtab_source): Update.
4875 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
4876 Update.
4877
4878 2019-08-16 Tom Tromey <tom@tromey.com>
4879
4880 * tui/tui-winsource.h (tui_update_source_window)
4881 (tui_update_source_window_as_is): Remove "noerror" parameter.
4882 * tui/tui-winsource.c (tui_update_source_window)
4883 (tui_update_source_window_as_is): Remove "noerror" parameter.
4884 (tui_update_source_windows_with_addr)
4885 (tui_update_source_windows_with_line)
4886 (tui_source_window_base::rerender)
4887 (tui_source_window_base::refill): Update.
4888 * tui/tui-source.h (tui_set_source_content)
4889 (tui_show_symtab_source): Remove "noerror" parameter.
4890 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
4891 parameter.
4892 (tui_show_symtab_source): Likewise.
4893 (tui_source_window::maybe_update): Update.
4894 * tui/tui-disasm.c (tui_show_disassem)
4895 (tui_show_disassem_and_update_source)
4896 (tui_disasm_window::do_scroll_vertical)
4897 (tui_disasm_window::maybe_update): Update.
4898
4899 2019-08-16 Tom Tromey <tom@tromey.com>
4900
4901 * tui/tui.c (tui_is_window_visible): Update.
4902 * tui/tui-wingeneral.c (tui_make_window)
4903 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
4904 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
4905 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
4906 (tui_set_win_height_command, parse_scrolling_args): Update.
4907 * tui/tui-source.c (tui_source_window::style_changed): Update.
4908 * tui/tui-regs.c (tui_show_registers)
4909 (tui_data_window::first_data_item_displayed)
4910 (tui_data_window::delete_data_content_windows)
4911 (tui_check_register_values, tui_reg_command): Update.
4912 * tui/tui-disasm.c (tui_show_disassem): Update.
4913 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
4914 method.
4915 <is_visible>: Remove field.
4916 * tui/tui-data.c (tui_next_win, tui_prev_win)
4917 (tui_delete_invisible_windows): Update.
4918
4919 2019-08-16 Tom Tromey <tom@tromey.com>
4920
4921 * tui/tui-winsource.h (struct tui_source_window_base)
4922 <m_has_locator>: Remove.
4923 * tui/tui-layout.c (show_source_disasm_command, show_data)
4924 (show_source_or_disasm_and_command): Update.
4925
4926 2019-08-16 Alan Hayward <alan.hayward@arm.com>
4927
4928 * NEWS (Other MI changes): New subsection.
4929 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
4930 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
4931 * arch-utils.c (default_get_pc_address_flags): New function.
4932 * arch-utils.h (default_get_pc_address_flags): New declaration.
4933 * gdbarch.sh: Add get_pc_address_flags.
4934 * gdbarch.c: Regenerate.
4935 * gdbarch.h: Likewise.
4936 * stack.c (print_pc): New function.
4937 (print_frame_info) (print_frame): Call print_pc.
4938
4939 2019-08-16 Tom de Vries <tdevries@suse.de>
4940
4941 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
4942 print_objfile_section_info.
4943
4944 2019-08-15 Tom Tromey <tom@tromey.com>
4945
4946 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
4947 calling update_cmdwin_start_line.
4948 * tui/tui-winsource.h (struct tui_source_window_base)
4949 <do_make_visible_with_new_height, set_new_height>: Don't declare.
4950 <rerender>: Declare.
4951 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
4952 Call rerender.
4953 (tui_source_window_base::set_new_height): Remove.
4954 (tui_source_window_base::rerender): Rename from
4955 do_make_visible_with_new_height.
4956 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
4957 resize method.
4958 (tui_win_info::make_invisible_and_set_new_height)
4959 (tui_win_info::make_visible_with_new_height): Remove.
4960 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
4961 Declare.
4962 * tui/tui-stack.c (tui_locator_window::rerender): New method.
4963 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
4964 do_make_visible_with_new_height>: Don't declare.
4965 <rerender>: Declare.
4966 * tui/tui-regs.c (tui_data_window::rerender): Rename from
4967 set_new_height.
4968 (tui_data_window::do_make_visible_with_new_height): Remove.
4969 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
4970 call tui_show_locator_content.
4971 (tui_gen_win_info::resize): Call rerender.
4972 (show_source_or_disasm_and_command): Don't call
4973 tui_show_locator_content.
4974 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
4975 method.
4976 (struct tui_win_info) <rerender>: Declare.
4977 <set_new_height, make_invisible_and_set_new_height,
4978 make_visible_with_new_height>: Don't declare.
4979 * tui/tui-data.c (tui_win_list::rerender): New method.
4980 * tui/tui-command.h (struct tui_cmd_window)
4981 <do_make_visible_with_new_height>: Don't declare.
4982 * tui/tui-command.c
4983 (tui_cmd_window::do_make_visible_with_new_height): Remove.
4984
4985 2019-08-15 Tom Tromey <tromey@adacore.com>
4986
4987 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
4988 * ada-lang.c (ada_enum_name): Likewise.
4989
4990 2019-08-15 Christian Biesinger <cbiesinger@google.com>
4991
4992 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
4993 leading underscore.
4994 (GdbOutputErrorFile): Likewise.
4995 (global scope): Adjust constructor calls to GdbOutput{,Error}File
4996 accordingly.
4997 (execute_unwinders): Rename to have a leading underscore.
4998 (auto_load_packages): Likewise.
4999 (global scope): Adjust call to auto_load_packages accordingly.
5000 (GdbSetPythonDirectory): Likewise.
5001 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5002 instead of execute_unwinders.
5003
5004 2019-08-15 Tom Tromey <tom@tromey.com>
5005
5006 * tui/tui-layout.c (show_layout, show_source_disasm_command)
5007 (show_data): Don't change window visibility.
5008 (tui_gen_win_info::resize): Remove special case for command
5009 window. Use wresize, when available.
5010 (show_source_or_disasm_and_command): Don't change window
5011 visibility.
5012 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5013 <make_visible>: New method.
5014 * tui/tui-command.c (tui_cmd_window::resize): New method.
5015
5016 2019-08-15 Tom Tromey <tom@tromey.com>
5017
5018 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5019 (struct tui_source_windows): New.
5020 * tui/tui-winsource.c (tui_display_main): Update.
5021 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5022 (new_height_ok, parse_scrolling_args): Update.
5023 * tui/tui-layout.c (show_layout, show_data): Update.
5024 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5025 (tui_add_to_source_windows): Don't declare.
5026 * tui/tui-data.c (source_windows, tui_source_windows)
5027 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5028
5029 2019-08-15 Tom Tromey <tom@tromey.com>
5030
5031 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5032 Rename from reset.
5033 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5034 * tui/tui-layout.c (show_source_disasm_command, show_data):
5035 Update.
5036 (tui_gen_win_info::resize): Rename.
5037 (show_source_or_disasm_and_command): Update.
5038 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5039 reset.
5040
5041 2019-08-15 Tom Tromey <tom@tromey.com>
5042
5043 * tui/tui-stack.c (tui_initialize_static_data): Remove.
5044 * tui/tui-interp.c (tui_interp::init): Don't call
5045 tui_initialize_static_data.
5046 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5047
5048 2019-08-15 Tom Tromey <tom@tromey.com>
5049
5050 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5051 examine tui_win_list.
5052
5053 2019-08-15 Tom Tromey <tom@tromey.com>
5054
5055 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5056 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5057 tui_clear_source_content.
5058 (tui_clear_source_content): Remove.
5059 (tui_source_window_base::do_erase_source_content): Hoist call to
5060 content.clear().
5061 * tui/tui-stack.c (tui_show_frame_info): Don't call
5062 tui_clear_source_content.
5063
5064 2019-08-15 Tom Tromey <tom@tromey.com>
5065
5066 * tui/tui-winsource.h (struct tui_source_window_base)
5067 <do_erase_source_content>: New method.
5068 <erase_source_content>: New method.
5069 (tui_erase_source_content): Don't declare.
5070 * tui/tui-winsource.c (tui_clear_source_content): Update.
5071 (tui_source_window_base::do_erase_source_content): Rename from
5072 tui_erase_source_content.
5073 (tui_source_window_base::show_source_content): Update.
5074 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5075 * tui/tui-source.h (struct tui_source_window)
5076 <erase_source_content>: New method.
5077 * tui/tui-disasm.h (struct tui_disasm_window)
5078 <erase_source_content>: New method.
5079
5080 2019-08-15 Tom Tromey <tom@tromey.com>
5081
5082 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5083 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5084 constructor.
5085 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5086 * tui/tui-source.c (tui_set_source_content): Update.
5087 * tui/tui-disasm.c (tui_set_disassem_content): Update.
5088
5089 2019-08-15 Tom Tromey <tom@tromey.com>
5090
5091 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5092 * tui/tui-winsource.c (tui_line_is_displayed): Move to
5093 tui-source.c.
5094 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5095 Declare.
5096 * tui/tui-source.c (tui_source_window::line_is_displayed): New
5097 method.
5098 (tui_source_window::maybe_update): Update.
5099
5100 2019-08-15 Tom Tromey <tom@tromey.com>
5101
5102 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5103 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5104 tui-disasm.c.
5105 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5106 Declare.
5107 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5108 method.
5109 (tui_disasm_window::maybe_update): Update.
5110
5111 2019-08-15 Tom Tromey <tom@tromey.com>
5112
5113 * tui/tui-winsource.h (struct tui_source_window_base)
5114 <maybe_update>: Declare.
5115 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5116 method.
5117 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5118 Declare.
5119 * tui/tui-source.c (tui_source_window::maybe_update): New method.
5120 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5121 Declare.
5122 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5123
5124 2019-08-15 Tom Tromey <tom@tromey.com>
5125
5126 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5127
5128 2019-08-15 Tom Tromey <tom@tromey.com>
5129
5130 * tui/tui-wingeneral.c: Include tui-stack.h.
5131 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5132 (struct tui_locator_window): Move from tui-data.h.
5133 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5134 (tui_initialize_static_data): Move from tui-data.c.
5135 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5136 (struct tui_locator_window): Move to tui-stack.c.
5137 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5138 (tui_initialize_static_data): Move to tui-stack.c.
5139
5140 2019-08-15 Tom Tromey <tom@tromey.com>
5141
5142 * tui/tui-layout.c (show_source_disasm_command)
5143 (show_source_or_disasm_and_command): Use make_visible method, not
5144 tui_make_window.
5145 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5146 Remove.
5147
5148 2019-08-15 Tom Tromey <tom@tromey.com>
5149
5150 * tui/tui-wingeneral.h (tui_make_window): Update.
5151 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5152 parameter.
5153 (tui_gen_win_info::make_visible): Update.
5154 * tui/tui-regs.c (tui_data_window::display_registers_from):
5155 Update.
5156 * tui/tui-layout.c (show_source_disasm_command)
5157 (show_source_or_disasm_and_command): Update.
5158 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5159 (enum tui_box): Remove.
5160 (struct tui_win_info) <can_box>: New method.
5161 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5162 method.
5163
5164 2019-08-15 Tom de Vries <tdevries@suse.de>
5165
5166 * linux-nat-trad.c: Include gdbarch.h.
5167
5168 2019-08-14 Alan Hayward <alan.hayward@arm.com>
5169
5170 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5171 register sizes.
5172
5173 2019-08-14 Tom Tromey <tromey@adacore.com>
5174
5175 * darwin-nat.c: Include gdbarch.h.
5176 * darwin-nat-info.c: Include gdbarch.h.
5177
5178 2019-08-13 Tom Tromey <tom@tromey.com>
5179
5180 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5181 Remove.
5182 * tui/tui-data.c (tui_initialize_static_data): Update.
5183
5184 2019-08-13 Tom Tromey <tom@tromey.com>
5185
5186 * tui/tui-winsource.h (struct tui_exec_info_window)
5187 <~tui_exec_info_window, maybe_allocate_content, get_content,
5188 m_content>: Remove.
5189 (struct tui_source_window_base) <set_exec_info_content,
5190 show_exec_info_content>: Don't declare.
5191 * tui/tui-winsource.c
5192 (tui_exec_info_window::maybe_allocate_content): Remove.
5193 (tui_source_window_base::update_exec_info): Rename from
5194 set_exec_info_content.
5195 (tui_source_window_base::show_exec_info_content)
5196 (tui_source_window_base::update_exec_info): Remove.
5197
5198 2019-08-13 Tom Tromey <tom@tromey.com>
5199
5200 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5201 declare.
5202 * tui/tui-winsource.c (tui_update_source_window_as_is)
5203 (tui_update_source_windows_with_addr, tui_erase_source_content):
5204 Update.
5205 (tui_clear_exec_info_content): Remove.
5206
5207 2019-08-13 Tom Tromey <tom@tromey.com>
5208
5209 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5210 declare.
5211 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5212 call tui_erase_exec_info_content.
5213 (tui_clear_exec_info_content): Rename from
5214 tui_erase_exec_info_content.
5215 (tui_clear_exec_info_content): Delete.
5216
5217 2019-08-13 Tom Tromey <tom@tromey.com>
5218
5219 * tui/tui-winsource.h (struct tui_source_window_base)
5220 <show_exec_info_content>: Declare.
5221 (tui_show_exec_info_content): Don't declare.
5222 * tui/tui-winsource.c
5223 (tui_source_window_base::show_exec_info_content): Rename from
5224 tui_show_exec_info_content.
5225 (tui_source_window_base::update_exec_info): Update.
5226
5227 2019-08-13 Tom Tromey <tom@tromey.com>
5228
5229 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5230 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5231 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5232 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5233 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5234 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5235 ... here.
5236
5237 2019-08-13 Tom Tromey <tom@tromey.com>
5238
5239 * tui/tui-winsource.h (struct tui_source_window_base)
5240 <update_exec_info>: Declare.
5241 (tui_update_exec_info): Don't declare.
5242 * tui/tui-winsource.c (tui_update_source_window_as_is)
5243 (tui_source_window_base::refresh_all)
5244 (tui_update_all_breakpoint_info): Update.
5245 (tui_source_window_base::update_exec_info): Rename from
5246 tui_update_exec_info.
5247 * tui/tui-stack.c (tui_show_frame_info): Update.
5248
5249 2019-08-13 Tom Tromey <tom@tromey.com>
5250
5251 * tui/tui-winsource.h (struct tui_source_window_base)
5252 <set_exec_info_content>: Declare.
5253 (tui_set_exec_info_content): Don't declare.
5254 * tui/tui-winsource.c
5255 (tui_source_window_base::set_exec_info_content): Rename from
5256 tui_set_exec_info_content.
5257 (tui_update_exec_info): Update.
5258
5259 2019-08-13 Tom Tromey <tom@tromey.com>
5260
5261 * tui/tui-winsource.h (struct tui_source_window_base)
5262 <show_source_content>: Declare.
5263 (tui_show_source_content): Don't declare.
5264 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5265 (tui_source_window_base::show_source_content): Rename from
5266 tui_show_source_content.
5267 (tui_source_window_base::refresh_all): Update.
5268 * tui/tui-layout.c (show_source_disasm_command)
5269 (show_source_or_disasm_and_command): Update.
5270
5271 2019-08-13 Tom Tromey <tom@tromey.com>
5272
5273 * tui/tui-winsource.c (tui_erase_source_content)
5274 (tui_show_source_content, tui_source_window_base::refresh_all):
5275 Update.
5276 * tui/tui-wingeneral.h
5277 (tui_check_and_display_highlight_if_needed): Don't declare.
5278 * tui/tui-wingeneral.c
5279 (tui_win_info::check_and_display_highlight_if_needed): Rename from
5280 check_and_display_highlight_if_needed.
5281 * tui/tui-win.c (tui_rehighlight_all)
5282 (tui_win_info::make_visible_with_new_height): Update.
5283 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5284 (tui_data_window::erase_data_content)
5285 (tui_data_window::display_all_data): Update.
5286 * tui/tui-data.h (struct tui_win_info)
5287 <check_and_display_highlight_if_needed>: Declare.
5288
5289 2019-08-13 Tom Tromey <tom@tromey.com>
5290
5291 * tui/tui-win.c (tui_resize_all): Call
5292 tui_delete_invisible_windows.
5293 * tui/tui-layout.c (show_layout): Call
5294 tui_delete_invisible_windows.
5295 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
5296 * tui/tui-data.c (tui_delete_invisible_windows): New function.
5297
5298 2019-08-13 Tom Tromey <tom@tromey.com>
5299
5300 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
5301 tui_add_win_to_layout.
5302
5303 2019-08-13 Tom Tromey <tom@tromey.com>
5304
5305 * tui/tui-layout.h (tui_default_win_height): Don't declare.
5306 * tui/tui-layout.c (tui_default_win_height): Now static.
5307
5308 2019-08-13 Tom Tromey <tom@tromey.com>
5309
5310 * tui/tui-layout.c (show_layout): Unify all layout cases into a
5311 single switch.
5312 (show_source_disasm_command, show_source_or_disasm_and_command):
5313 Don't check current layout.
5314
5315 2019-08-13 Tom Tromey <tom@tromey.com>
5316
5317 * tui/tui-wingeneral.c (make_all_visible): Remove.
5318 (tui_make_all_invisible): Simplify.
5319 * tui/tui-layout.c (tui_make_all_invisible): Move from
5320 tui-wingeneral.c; simplify.
5321 (show_layout): Hoist call to tui_make_all_invisible.
5322 (show_data): Don't call tui_make_all_invisible.
5323
5324 2019-08-13 Tom Tromey <tom@tromey.com>
5325
5326 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
5327 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
5328
5329 2019-08-13 Tom Tromey <tom@tromey.com>
5330
5331 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
5332 tui-data.c.
5333 (show_source_disasm_command, show_data)
5334 (show_source_or_disasm_and_command): Don't use
5335 tui_set_current_layout_to.
5336 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
5337 * tui/tui-data.c (current_layout, tui_current_layout): Move to
5338 tui-layout.c.
5339 (tui_set_current_layout_to): Remove.
5340
5341 2019-08-13 Tom Tromey <tom@tromey.com>
5342
5343 * tui/tui-layout.c (tui_set_layout): Update.
5344 * tui/tui-data.h (struct tui_layout_def): Remove.
5345 (tui_layout_def): Don't declare.
5346 * tui/tui-data.c (layout_def): Remove.
5347 (tui_layout_def): Remove.
5348
5349 2019-08-13 Tom Tromey <tom@tromey.com>
5350
5351 * tui/tui-winsource.h (struct tui_source_window_base)
5352 <clear_detail>: No longer "override".
5353 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
5354 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
5355 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
5356 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
5357 Remove.
5358 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
5359
5360 2019-08-13 Tom Tromey <tromey@adacore.com>
5361
5362 * tracepoint.c: Don't include readline.h or history.h.
5363
5364 2019-08-12 Tom Tromey <tom@tromey.com>
5365
5366 * configure: Rebuild.
5367 * configure.ac: Check for readline 7.
5368 * NEWS: Mention readline 7 requirement.
5369 * README: Update.
5370
5371 2019-08-12 Tom Tromey <tom@tromey.com>
5372
5373 * mingw-hdep.c (gdb_select): Remove readline hack.
5374
5375 2019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
5376
5377 * blockframe.c (find_pc_partial_function): Set *block to nullptr
5378 when the function fails.
5379
5380 2019-08-09 Andreas Arnez <arnez@linux.ibm.com>
5381
5382 * s390-tdep.c (s390_type_align): New function.
5383 (s390_gdbarch_init): Set it as type_align gdbarch method.
5384
5385 2019-08-09 Tom de Vries <tdevries@suse.de>
5386
5387 PR gdb/24591
5388 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
5389 pc_low with relocation offset.
5390
5391 2019-08-07 Tom Tromey <tromey@adacore.com>
5392
5393 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5394 (print_frame_args): Update.
5395 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
5396 Update.
5397 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5398 * frame.h (struct frame_arg): Add initializers.
5399 <error>: Now a unique_xmalloc_ptr.
5400
5401 2019-08-07 Alan Hayward <alan.hayward@arm.com>
5402
5403 * NEWS: Expand the Pointer Authentication entry.
5404 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
5405 (aarch64_frame_unmask_lr): ... to this.
5406 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
5407 Call aarch64_frame_unmask_lr.
5408 * frame.c (struct frame_info): Add "masked" variable.
5409 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
5410 (fprint_frame): Check for masked pc.
5411 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
5412 declarations.
5413 * python/py-framefilter.c (py_print_frame): Check for masked pc.
5414 * stack.c (print_frame): Check for masked pc.
5415
5416 2019-08-06 Tom Tromey <tom@tromey.com>
5417
5418 * stabsread.c (patch_block_stabs, read_one_struct_field)
5419 (read_enum_type): Use obstack_strndup.
5420 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
5421 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
5422 * dwarf2read.c (guess_full_die_structure_name)
5423 (anonymous_struct_prefix): Use obstack_strndup.
5424 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
5425 * c-exp.y (yylex): Use obstack_strndup.
5426 * ada-exp.y (write_object_renaming, write_ambiguous_var)
5427 (write_var_or_type): Use obstack_strndup.
5428
5429 2019-08-06 Tom Tromey <tom@tromey.com>
5430
5431 * symfile.c (reread_symbols): Use obstack_strdup.
5432 * stabsread.c (read_type): Use obstack_strdup.
5433 * gdb_obstack.h (obstack_strdup): New overload.
5434 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
5435 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
5436 (dwarf2_canonicalize_name): Use obstack_strdup.
5437 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
5438 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
5439 Use obstack_strdup.
5440
5441 2019-08-06 Tom Tromey <tom@tromey.com>
5442
5443 * gdb_obstack.h (obstack_strdup): Define.
5444 * gdb_obstack.c (obstack_strdup): Don't define.
5445
5446 2019-08-06 Tom Tromey <tom@tromey.com>
5447
5448 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
5449 obstack_strdup.
5450 * typeprint.c (typedef_hash_table::find_global_typedef): Use
5451 obstack_strdup.
5452 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
5453 * stabsread.c (common_block_start): Use obstack_strdup.
5454 * objfiles.c (set_objfile_main_name, objfile): Use
5455 obstack_strdup.
5456 * namespace.c (add_using_directive): Use obstack_strdup.
5457 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
5458 * jit.c (finalize_symtab): Use obstack_strdup.
5459 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
5460 (guess_partial_die_structure_name, partial_die_info::fixup)
5461 (dwarf2_name): Use obstack_strdup.
5462 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
5463 obstack_strdup.
5464 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
5465 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5466 obstack_strdup.
5467 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
5468
5469 2019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5470
5471 * unittests/help-doc-selftests.c: New file.
5472 * Makefile.in: Add the new file.
5473
5474 2019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5475
5476 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
5477 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
5478 the full first line, except when FOR_VALUE_PREFIX. In this case,
5479 the trailing '.' is not output, and the first character is uppercased.
5480 (print_help_for_command): Update call to print_doc_line.
5481 (print_doc_of_command): Likewise.
5482 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
5483 * cli/cli-option.c (append_indented_doc): Do not append newline.
5484 (build_help_option): Append newline after first appended_indented_doc
5485 only if a second call is done.
5486 (build_help): Append 2 new lines before each option, except the first
5487 one.
5488 * compile/compile.c (_initialize_compile): Add new lines after
5489 %OPTIONS%, when not at the end of the help.
5490 Change help doc or code
5491 producing the help doc to respect the invariants.
5492 * maint-test-options.c (_initialize_maint_test_options): Likewise.
5493 Also removed the new line after 'Options:', as all other commands
5494 do not put an empty line between 'Options:' and the first option.
5495 * printcmd.c (_initialize_printcmd): Likewise.
5496 * stack.c (_initialize_stack): Likewise.
5497 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
5498 incorrectly telling COMMAND is optional.
5499 * ada-lang.c (_initialize_ada_language): Change help doc or code
5500 producing the help doc to respect the invariants.
5501 * ada-tasks.c (_initialize_ada_tasks): Likewise.
5502 * breakpoint.c (_initialize_breakpoint): Likewise.
5503 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
5504 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
5505 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
5506 * cli/cli-style.c (cli_style_option::add_setshow_commands,
5507 _initialize_cli_style): Likewise.
5508 * corelow.c (core_target_info): Likewise.
5509 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
5510 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
5511 * filesystem.c (_initialize_filesystem): Likewise.
5512 * frame.c (_initialize_frame): Likewise.
5513 * gnu-nat.c (add_task_commands): Likewise.
5514 * infcall.c (_initialize_infcall): Likewise.
5515 * infcmd.c (_initialize_infcmd): Likewise.
5516 * interps.c (_initialize_interpreter): Likewise.
5517 * language.c (_initialize_language): Likewise.
5518 * linux-fork.c (_initialize_linux_fork): Likewise.
5519 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
5520 * maint.c (_initialize_maint_cmds): Likewise.
5521 * memattr.c (_initialize_mem): Likewise.
5522 * printcmd.c (_initialize_printcmd): Likewise.
5523 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
5524 _RegEx): Likewise.
5525 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
5526 * record-btrace.c (_initialize_record_btrace): Likewise.
5527 * record-full.c (_initialize_record_full): Likewise.
5528 * record.c (_initialize_record): Likewise.
5529 * regcache-dump.c (_initialize_regcache_dump): Likewise.
5530 * regcache.c (_initialize_regcache): Likewise.
5531 * remote.c (add_packet_config_cmd, init_remote_threadtests,
5532 _initialize_remote): Likewise.
5533 * ser-tcp.c (_initialize_ser_tcp): Likewise.
5534 * serial.c (_initialize_serial): Likewise.
5535 * skip.c (_initialize_step_skip): Likewise.
5536 * source.c (_initialize_source): Likewise.
5537 * stack.c (_initialize_stack): Likewise.
5538 * symfile.c (_initialize_symfile): Likewise.
5539 * symtab.c (_initialize_symtab): Likewise.
5540 * target-descriptions.c (_initialize_target_descriptions): Likewise.
5541 * top.c (init_main): Likewise.
5542 * tracefile-tfile.c (tfile_target_info): Likewise.
5543 * tracepoint.c (_initialize_tracepoint): Likewise.
5544 * tui/tui-win.c (_initialize_tui_win): Likewise.
5545 * utils.c (add_internal_problem_command): Likewise.
5546 * valprint.c (value_print_option_defs): Likewise.
5547
5548 2019-08-06 Frank Ch. Eigler <fche@redhat.com>
5549
5550 PR build/24886
5551 * configure.ac: Drop enable-libmcheck support.
5552 * configure, config.in: Rebuild.
5553 * libmcheck.m4: Remove.
5554 * acinclude.m4: Don't include it.
5555 * Makefile.in: Don't distribute it.
5556 * top.c (print_gdb_configuration): Don't mention it.
5557
5558 2019-08-06 Tom Tromey <tom@tromey.com>
5559
5560 * utils.c (set_output_style): Sometimes pass stream to
5561 emit_style_escape.
5562 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
5563 * record-btrace.c (btrace_insn_history): Update.
5564 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
5565 method.
5566 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
5567 Update initializers.
5568 <m_uiout>: New field.
5569 <m_di>: Move lower.
5570 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5571 Remove "uiout" parameter.
5572 (dump_insns): Update.
5573 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
5574 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
5575
5576 2019-08-06 Christian Biesinger <cbiesinger@google.com>
5577
5578 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
5579 (error_in_psymtab_expansion): Likewise.
5580 (lookup_symbol_via_quick_fns): Likewise.
5581 (basic_lookup_transparent_type_quick): Likewise.
5582 (basic_lookup_transparent_type_1): Likewise.
5583
5584 2019-08-06 Tom Tromey <tromey@adacore.com>
5585
5586 * source.c (last_source_error): Now bool.
5587 (print_source_lines_base): Make "noprint" bool. Only open
5588 source file when last_source_visited changes.
5589
5590 2019-08-06 Tom Tromey <tromey@adacore.com>
5591
5592 * annotate.c (annotate_source_line): Use g_source_cache.
5593 * source-cache.c (source_cache::get_plain_source_lines): Change
5594 parameters. Populate m_offset_cache.
5595 (source_cache::ensure): New method.
5596 (source_cache::get_line_charpos): New method.
5597 (extract_lines): Move lower. Change parameters.
5598 (source_cache::get_source_lines): Move lower.
5599 * source-cache.h (class source_cache): Update comment.
5600 <get_line_charpos>: New method.
5601 <get_source_lines>: Update comment.
5602 <clear>: Clear m_offset_cache.
5603 <get_plain_source_lines>: Change parameters.
5604 <ensure>: New method
5605 <m_offset_cache>: New member.
5606 * source.c (forget_cached_source_info_for_objfile): Update.
5607 (info_source_command): Use g_source_cache.
5608 (find_source_lines, open_source_file_with_line_charpos): Remove.
5609 (print_source_lines_base, search_command_helper): Use g_source_cache.
5610 * source.h (open_source_file_with_line_charpos): Don't declare.
5611 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
5612 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
5613 Use g_source_cache.
5614
5615 2019-08-06 Tom Tromey <tromey@adacore.com>
5616
5617 * source-cache.c (source_cache::get_plain_source_lines):
5618 Remove "first_line" and "last_line" parameters.
5619 (source_cache::get_source_lines): Cache plain text.
5620 * source-cache.h (class source_cache)
5621 <get_plain_source_lines>: Update.
5622
5623 2019-08-06 Tom Tromey <tromey@adacore.com>
5624
5625 * source-cache.c (extract_lines): No longer a method.
5626 Changed type of parameter. Include final newline.
5627 (selftests::extract_lines_test): New function.
5628 (_initialize_source_cache): Likewise.
5629 * source-cache.h (class source_cache)
5630 <extract_lines>: Don't declare.
5631
5632 2019-08-06 Tom Tromey <tromey@adacore.com>
5633
5634 * breakpoint.c (init_breakpoint_sal): Update.
5635 (breakpoint): Update.
5636 * breakpoint.h (struct breakpoint) <filter>: Now a
5637 unique_xmalloc_ptr.
5638
5639 2019-08-05 Christian Biesinger <cbiesinger@google.com>
5640
5641 * NEWS: Mention dictionary access on blocks.
5642 * python/py-block.c (blpy_getitem): New function.
5643 (block_object_as_mapping): New struct.
5644 (block_object_type): Use new struct for tp_as_mapping field.
5645
5646 2019-08-05 Christian Biesinger <cbiesinger@google.com>
5647
5648 * objfiles.h (objfile): Add a comment describing partial symbols.
5649
5650 2019-08-05 Tom Tromey <tromey@adacore.com>
5651
5652 * compile/compile.c (_initialize_compile): Use _(), not N_().
5653 * thread.c (_initialize_thread): Use _(), not N_().
5654 * stack.c (_initialize_stack): Use _(), not N_().
5655 * printcmd.c (_initialize_printcmd): Use _(), not N_().
5656
5657 2019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
5658
5659 * dwarf2read.c (struct dw2_symtab_iterator):
5660 <want_specific_block>: Remove.
5661 <block_index>: Change type to gdb::optional.
5662 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
5663 change type of BLOCK_INDEX parameter to gdb::optional.
5664 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
5665 (dw2_lookup_symbol): Don't pass argument for
5666 WANT_SPECIFIC_BLOCK.
5667 (dw2_expand_symtabs_for_function): Don't pass argument for
5668 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
5669 (class dw2_debug_names_iterator)
5670 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
5671 parameter, change BLOCK_INDEX type to gdb::optional.
5672 <m_want_specific_block>: Remove.
5673 <m_block_index>: Change type to gdb::optional.
5674 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
5675 gdb::optional. Re-write in function of gdb::optional.
5676 (dw2_debug_names_lookup_symbol): Don't pass argument for
5677 WANT_SPECIFIC_BLOCK.
5678 (dw2_debug_names_expand_symtabs_for_function): Don't pass
5679 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
5680 BLOCK_INDEX.
5681
5682 2019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5683
5684 * NEWS: Mention changes to "info sources" command.
5685
5686 2019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5687
5688 * symtab.c (filename_partial_match_opts): New struct type.
5689 (struct output_source_filename_data): New members
5690 regexp, c_regexp, partial_match.
5691 (output_source_filename): Use new members to decide to print file.
5692 (info_sources_option_defs): New variable.
5693 (make_info_sources_options_def_group, print_info_sources_header,
5694 info_sources_command_completer):
5695 New functions.
5696 (info_sources_command): Read new optional arguments.
5697 (_initialize_symtab): Update info sources help.
5698
5699 2019-08-02 Alexandre Oliva <oliva@adacore.com>
5700
5701 * ada-lang.c (exception_support_info_v0): Renamed from...
5702 (default_exception_support_info): ... this. Create new
5703 definition for v1.
5704 (ada_has_this_exception_support): Look up catch_handlers_sym.
5705 (ada_exception_support_info_sniffer): Try v0 after default.
5706
5707 2019-08-01 Tom Tromey <tromey@adacore.com>
5708
5709 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
5710 gdbarch.h.
5711
5712 2019-08-01 Christian Biesinger <cbiesinger@google.com>
5713
5714 * s12z-tdep.c: Fix include path for s12z-opc.h.
5715
5716 2019-08-01 Alan Hayward <alan.hayward@arm.com>
5717
5718 * NEWS: Require GNU make 3.82.
5719
5720 2019-07-16 Tom Tromey <tom@tromey.com>
5721
5722 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
5723 declare.
5724
5725 2019-07-30 Tom Tromey <tromey@adacore.com>
5726
5727 * block.c (contained_in): Remove BLOCK_FUNCTION check.
5728
5729 2019-07-30 Kevin Buettner <kevinb@redhat.com>
5730
5731 * printcmd.c (print_address_symbolic): Print negative offsets.
5732 (build_address_symbolic): Force signed arithmetic when computing
5733 offset.
5734
5735 2019-07-30 Christian Biesinger <cbiesinger@google.com>
5736
5737 PR/24474: Add a function to lookup static variables.
5738 * NEWS: Mention this new function.
5739 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
5740 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
5741 * python/python.c (python_GdbMethods): Add new function.
5742
5743 2019-07-29 Christian Biesinger <cbiesinger@google.com>
5744
5745 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
5746 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
5747 (objfpy_lookup_static_symbol): New function.
5748 (objfile_object_methods): Add new functions.
5749
5750 2019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5751
5752 * NEWS: Mention 'set|show print frame-info'. Mention new
5753 'presence' value for 'frame-arguments'. Mention new '-frame-info'
5754 backtrace argument. Mention that python frame filtering code
5755 is now consistent with what 'backtrace' command prints.
5756
5757 2019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5758
5759 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
5760 comments.
5761 (print_frame_info_auto, print_frame_info_source_line,
5762 print_frame_info_location, print_frame_info_source_and_location,
5763 print_frame_info_location_and_address, print_frame_info_short_location):
5764 New declarations.
5765 (struct frame_print_options): New member print_frame_info.
5766 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
5767 * stack.h (get_user_print_what_frame_info): New declaration.
5768 (frame_show_address): New declaration.
5769 * stack.c (print_frame_arguments_choices): New value 'presence'.
5770 (print_frame_info_auto, print_frame_info_source_line,
5771 print_frame_info_location, print_frame_info_source_and_location,
5772 print_frame_info_location_and_address, print_frame_info_short_location,
5773 print_frame_info_choices, print_frame_info_print_what): New definitions.
5774 (print_frame_args): Only print dots for args if print frame-arguments
5775 is 'presence'.
5776 (frame_print_option_defs): New element for "frame-info".
5777 (get_user_print_what_frame_info): New function.
5778 (frame_show_address): Make non static. Move comment to stack.h.
5779 (print_frame_info_to_print_what): New function.
5780 (print_frame_info): Update comment. Use fp_opts.print_frame_info
5781 to decide what to print.
5782 (backtrace_command_1): Handle the new print_frame_arguments_presence
5783 value.
5784 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
5785 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
5786 (py_print_frame): In non-mi mode, use LOCATION as default for
5787 print_what, similarly to frame information printed directly by
5788 backtrace command. Handle frame-info user option in non MI mode.
5789
5790 2019-07-27 Kevin Buettner <kevinb@redhat.com>
5791
5792 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
5793 Add case for debugging 32-bit target on 64-bit host. Revise
5794 comment.
5795
5796 2019-07-27 Kevin Buettner <kevinb@redhat.com>
5797
5798 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
5799 instead of find_function_entry_range_from_pc.
5800
5801 2019-07-27 Kevin Buettner <kevinb@redhat.com>
5802
5803 * stack.c (find_frame_funname): Remove code which preferred
5804 minsym over symtab sym in "certain pathological cases".
5805
5806 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
5807 parameter. Change type of "do_demangle" to bool.
5808 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5809 Pass suitable "prefer_sym_over_minsym" flag to
5810 build_address_symbolic(). Don't output "+" for negative offsets.
5811 * printcmd.c (print_address_symbolic): Update invocation of
5812 build_address_symbolic to include a "prefer_sym_over_minsym"
5813 flag.
5814 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
5815 Restrict cases in which use of minimal symbol is preferred to that
5816 of a found symbol. Update comments.
5817
5818 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
5819 for entry pc when entry pc is out of range for that FDE.
5820
5821 2019-07-26 Brian Callahan <bcallah@openbsd.org>
5822
5823 PR gdb/24839:
5824 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
5825 type.
5826
5827 2019-07-25 Christian Biesinger <cbiesinger@google.com>
5828
5829 * python/py-objfile.c (add_separate_debug_file): Fix comment about
5830 this function's Python signature.
5831
5832
5833 2019-07-24 Christian Biesinger <cbiesinger@google.com>
5834
5835 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
5836 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5837 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5838 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
5839 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
5840
5841
5842 2019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
5843
5844 * h8300-tdep.c (h8300_register_name_common): New.
5845 h8300_register_name): Use h8300_register_name_common.
5846 (h8300s_register_name): Likewise.
5847 (h8300sx_register_name): Likewise.
5848 (h8300h_register_nam): New.
5849 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
5850
5851
5852 2019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
5853
5854 * arm-tdep.c (arm_skip_cmse_entry): New function.
5855 (arm_is_sgstubs_section): New function.
5856 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
5857
5858 2019-07-22 Tom Tromey <tom@tromey.com>
5859
5860 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
5861 Don't self-assign.
5862
5863 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
5864
5865 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
5866 type_print.
5867
5868 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
5869
5870 * symtab.c (search_symbols): Adjust msymbol matching type arrays
5871 so that GDB doesn't match any msymbols when searching in the
5872 TYPES_DOMAIN.
5873 (print_symbol_info): Print using typedef_print or type_print based
5874 on the type of the symbol. Add updated FIXME comment moved from...
5875 (_initialize_symtab): ... move and update FIXME comment to above.
5876
5877 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
5878
5879 * NEWS: Mention adding -q option to "info types".
5880 * symtab.c (struct info_types_options): New struct.
5881 (info_types_options_defs): New variable.
5882 (make_info_types_options_def_group): New function.
5883 (info_types_command): Use gdb::option framework to parse options.
5884 (info_types_command_completer): New function.
5885 (_initialize_symtab): Extend the help text on "info types" and
5886 register command completer.
5887
5888 2019-07-21 Christian Biesinger <cbiesinger@google.com>
5889
5890 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
5891 (lookup_symbol_in_objfile): Change int to block_enum and add a
5892 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
5893
5894 2019-07-20 Christian Biesinger <cbiesinger@google.com>
5895
5896 * MAINTAINERS (Write After Approval): Add self.
5897
5898 2019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
5899
5900 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
5901 instruction to the dummy code region.
5902
5903 2019-07-19 Tom Tromey <tromey@adacore.com>
5904
5905 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
5906 (ARGSUSED, PARAMS, __func__): Remove rules.
5907
5908 2019-07-19 Alan Hayward <alan.hayward@arm.com>
5909
5910 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
5911 * features/arm/arm-with-iwmmxt.c: Remove.
5912 * features/arm/arm-with-iwmmxt.xml: Remove.
5913 * features/arm/arm-with-m-fpa-layout.c: Remove.
5914 * features/arm/arm-with-m-fpa-layout.xml: Remove.
5915 * features/arm/arm-with-m-vfp-d16.c: Remove.
5916 * features/arm/arm-with-m-vfp-d16.xml: Remove.
5917 * features/arm/arm-with-m.c: Remove.
5918 * features/arm/arm-with-m.xml: Remove.
5919 * features/arm/arm-with-neon.c: Remove.
5920 * features/arm/arm-with-neon.xml: Remove.
5921 * features/arm/arm-with-vfpv2.c: Remove.
5922 * features/arm/arm-with-vfpv2.xml: Remove.
5923 * features/arm/arm-with-vfpv3.c: Remove.
5924 * features/arm/arm-with-vfpv3.xml: Remove.
5925
5926 2019-07-19 Alan Hayward <alan.hayward@arm.com>
5927
5928 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
5929
5930 2019-07-19 Alan Hayward <alan.hayward@arm.com>
5931
5932 * arch/aarch32.c (aarch32_create_target_description): Create
5933 target descriptions using features.
5934 * arch/arm.c (arm_create_target_description)
5935 (arm_create_mprofile_target_description): Likewise.
5936 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
5937
5938 2019-07-19 Alan Hayward <alan.hayward@arm.com>
5939
5940 * Makefile.in: Add new files.
5941 * aarch32-tdep.c: New file.
5942 * aarch32-tdep.h: New file.
5943 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5944 Call aarch32_read_description.
5945 * arch/aarch32.c: New file.
5946 * arch/aarch32.h: New file.
5947 * arch/arm.c (arm_create_target_description)
5948 (arm_create_mprofile_target_description): New function.
5949 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
5950 (arm_create_target_description)
5951 (arm_create_mprofile_target_description): New declaration.
5952 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
5953 read_description functions.
5954 * arm-linux-nat.c (arm_linux_nat_target::read_description):
5955 Likewise.
5956 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5957 * arm-tdep.c (tdesc_arm_list): New variable.
5958 (arm_register_g_packet_guesses): Call create description functions.
5959 (arm_read_description) (arm_read_mprofile_description): New
5960 function.
5961 * arm-tdep.h (arm_read_description)
5962 (arm_read_mprofile_description): Add declaration.
5963 * configure.tgt: Add new files.
5964
5965 2019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
5966
5967 * top.c (new_ui_command): Open specified terminal just once.
5968
5969 2019-07-18 Tom Tromey <tromey@adacore.com>
5970
5971 * symtab.c (main_name): Constify return type.
5972 * symfile.c (set_initial_language): Update.
5973 * symtab.h (main_name): Constify return type.
5974
5975 2019-07-17 Tom Tromey <tom@tromey.com>
5976
5977 * tui/tui-winsource.c (tui_update_source_window)
5978 (tui_update_source_window_as_is)
5979 (tui_update_source_windows_with_line): Remove return.
5980 * tui/tui-disasm.c (tui_show_disassem)
5981 (tui_show_disassem_and_update_source): Remove return.
5982 * tui/tui.c (tui_reset): Remove return.
5983 * tui/tui-wingeneral.c
5984 (tui_check_and_display_highlight_if_needed): Remove return.
5985
5986 2019-07-17 Tom Tromey <tom@tromey.com>
5987
5988 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
5989
5990 2019-07-17 Tom Tromey <tom@tromey.com>
5991
5992 * tui/tui-winsource.h (struct tui_exec_info_window)
5993 (struct tui_source_window_base): Move from tui-data.h.
5994 * tui/tui-winsource.c: Move many method definitions from
5995 elsewhere. Remove "structuring" comments.
5996 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
5997 (tui_source_window_base::refresh_window): Move to
5998 tui-winsource.c.
5999 * tui/tui-win.c (tui_source_window_base::refresh_all)
6000 (tui_source_window_base::update_tab_width)
6001 (tui_source_window_base::set_new_height)
6002 (tui_source_window_base::do_make_visible_with_new_height): Move to
6003 tui-winsource.c.
6004 * tui/tui-source.h: Update.
6005 * tui/tui-source.c (tui_source_window_base::reset): Move to
6006 tui-winsource.c.
6007 * tui/tui-disasm.h: Update.
6008 * tui/tui-data.h (struct tui_exec_info_window): Move to
6009 tui-winsource.h.
6010 (struct tui_source_window_base): Likewise.
6011 * tui/tui-data.c (tui_source_window_base::clear_detail)
6012 (tui_source_window_base, ~tui_source_window_base): Move to
6013 tui-winsource.c.
6014
6015 2019-07-17 Tom Tromey <tom@tromey.com>
6016
6017 * tui/tui-win.c (tui_resize_all)
6018 (tui_source_window_base::update_tab_width)
6019 (tui_adjust_win_heights): Update.
6020 (tui_win_info::make_invisible_and_set_new_height): Rename from
6021 make_invisible_and_set_new_height.
6022 * tui/tui-data.h (struct tui_win_info)
6023 <make_invisible_and_set_new_height>: New method.
6024
6025 2019-07-17 Tom Tromey <tom@tromey.com>
6026
6027 * tui/tui.c: Update.
6028 * tui/tui-source.h (struct tui_source_window): Move from
6029 tui-data.h.
6030 * tui/tui-layout.c: Update.
6031 * tui/tui-disasm.c: Update.
6032 * tui/tui-data.h (struct tui_source_window): Move to
6033 tui-source.h.
6034
6035 2019-07-17 Tom Tromey <tom@tromey.com>
6036
6037 * tui/tui-disasm.h (struct tui_disasm_window): Move from
6038 tui-data.h.
6039 * tui/tui-data.h (struct tui_disasm_window): Move to
6040 tui-disasm.h.
6041
6042 2019-07-17 Tom Tromey <tom@tromey.com>
6043
6044 * tui/tui-regs.h (struct tui_data_item_window): Move from
6045 tui-data.h.
6046 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6047 * tui/tui-data.h (struct tui_data_item_window): Move to
6048 tui-regs.h.
6049 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6050
6051 2019-07-17 Tom Tromey <tom@tromey.com>
6052
6053 * tui/tui.c: Update.
6054 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6055 (tui_cmd_window::max_height): Move to tui-command.c.
6056 * tui/tui-layout.c: Update.
6057 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6058 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6059 tui-command.c.
6060 * tui/tui-command.h (struct tui_cmd_window): Move from
6061 tui-data.h.
6062 * tui/tui-command.c: Remove "structuring" comments.
6063 (tui_cmd_window::clear_detail)
6064 (tui_cmd_window::do_make_visible_with_new_height)
6065 (tui_cmd_window::max_height): Move from elsewhere.
6066
6067 2019-07-17 Tom Tromey <tom@tromey.com>
6068
6069 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6070 Now static.
6071 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6072 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6073
6074 2019-07-17 Tom Tromey <tom@tromey.com>
6075
6076 * tui/tui.c: Update.
6077 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6078 tui-regs.c.
6079 * tui/tui-windata.h: Remove file.
6080 * tui/tui-windata.c: Remove file.
6081 * tui/tui-win.c (tui_data_window::set_new_height)
6082 (tui_data_window::do_make_visible_with_new_height): Move to
6083 tui-regs.c.
6084 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6085 * tui/tui-regs.c: Remove "structuring" comments.
6086 (tui_data_window::first_data_item_displayed)
6087 (tui_data_window::delete_data_content_windows)
6088 (tui_data_window::erase_data_content)
6089 (tui_data_window::display_all_data)
6090 (tui_data_window::refresh_all)
6091 (tui_data_window::do_scroll_vertical)
6092 (tui_data_window::clear_detail, tui_data_window::set_new_height)
6093 (tui_data_window::do_make_visible_with_new_height)
6094 (tui_data_window::refresh_window): Move from elsewhere.
6095 (_initialize_tui_regs): Move to end of file.
6096 * tui/tui-layout.c: Update.
6097 * tui/tui-hooks.c: Update.
6098 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6099 * tui/tui-data.c (tui_data_window::clear_detail): Move to
6100 tui-regs.c.
6101 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6102
6103 2019-07-17 Tom Tromey <tom@tromey.com>
6104
6105 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6106 seen.
6107
6108 2019-07-17 Tom Tromey <tom@tromey.com>
6109
6110 * tui/tui-win.c (tui_source_window_base::set_new_height)
6111 (tui_source_window_base::do_make_visible_with_new_height): Use
6112 m_has_locator field directly.
6113 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6114 method.
6115 (struct tui_source_window_base) <has_locator>: Likewise.
6116
6117 2019-07-17 Tom Tromey <tom@tromey.com>
6118
6119 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6120 Don't declare.
6121 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6122 Remove.
6123 * tui/tui-win.c (tui_source_window_base::set_new_height)
6124 (tui_source_window_base::set_new_height)
6125 (make_invisible_and_set_new_height)
6126 (tui_source_window_base::do_make_visible_with_new_height)
6127 (tui_source_window_base::do_make_visible_with_new_height):
6128 Update.
6129 * tui/tui-layout.c (show_source_disasm_command, show_data)
6130 (show_source_or_disasm_and_command): Update.
6131 * tui/tui-layout.c (show_layout): Update.
6132
6133 2019-07-17 Tom Tromey <tom@tromey.com>
6134
6135 * tui/tui-layout.c (make_data_window): Remove.
6136 (show_data): Unify creation and re-initialization cases.
6137
6138 2019-07-17 Tom Tromey <tom@tromey.com>
6139
6140 * tui/tui-layout.c (make_source_window, make_disasm_window):
6141 Remove.
6142 (show_data): Unify creation and re-initialization cases.
6143
6144 2019-07-17 Tom Tromey <tom@tromey.com>
6145
6146 * tui/tui-layout.c (make_command_window): Remove.
6147 (show_source_disasm_command, show_source_or_disasm_and_command):
6148 Unify creation and re-initialization cases.
6149
6150 2019-07-17 Tom Tromey <tom@tromey.com>
6151
6152 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6153 creation and re-initialization cases.
6154
6155 2019-07-17 Tom Tromey <tom@tromey.com>
6156
6157 * tui/tui-regs.c (tui_get_register): Return void.
6158
6159 2019-07-17 Tom Tromey <tom@tromey.com>
6160
6161 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6162 Simplify.
6163
6164 2019-07-17 Tom Tromey <tom@tromey.com>
6165
6166 * tui/tui-layout.c (show_source_disasm_command): Simplify window
6167 resetting.
6168
6169 2019-07-17 Tom Tromey <tom@tromey.com>
6170
6171 * tui/tui.h (tui_set_layout_by_name): Don't declare.
6172 * tui/tui-regs.c (tui_reg_layout): New function.
6173 (tui_show_registers, tui_reg_command): Use it.
6174 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6175 (tui_layout_command): Rename from tui_set_layout_by_name. Change
6176 parameters.
6177 (tui_layout_command): Remove.
6178
6179 2019-07-17 Tom Tromey <tom@tromey.com>
6180
6181 * tui/tui-layout.h (tui/tui-layout): Return void.
6182 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
6183
6184 2019-07-17 Tom Tromey <tom@tromey.com>
6185
6186 * tui/tui-layout.c (show_source_disasm_command, show_data):
6187 Update.
6188 (reset_locator): Remove.
6189 (show_source_or_disasm_and_command): Update.
6190
6191 2019-07-17 Tom Tromey <tom@tromey.com>
6192
6193 * tui/tui-source.c (tui_source_window_base::reset): Remove
6194 win_type parameter.
6195 * tui/tui-layout.c (make_command_window, make_source_window)
6196 (make_disasm_window, make_data_window)
6197 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6198 (reset_locator, show_source_or_disasm_and_command): Update.
6199 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6200 win_type parameter.
6201 (struct tui_source_window_base) <reset>: Likewise.
6202
6203 2019-07-17 Tom Tromey <tom@tromey.com>
6204
6205 * tui/tui-layout.c (show_source_disasm_command): Use
6206 reset_locator.
6207 (reset_locator): New function.
6208 (init_and_make_win): Remove.
6209 (show_source_or_disasm_and_command): Use reset_locator.
6210
6211 2019-07-17 Tom Tromey <tom@tromey.com>
6212
6213 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6214 condition.
6215 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6216 Remove condition.
6217 * tui/tui-source.c (tui_source_window_base::reset): New method.
6218 * tui/tui-layout.c (make_command_window): Don't call
6219 init_and_make_win.
6220 (make_source_window, make_disasm_window): Don't call
6221 make_source_or_disasm_window.
6222 (make_data_window): Don't call init_and_make_win. Change calling
6223 convention.
6224 (show_source_disasm_command, show_data): Simplify.
6225 (make_source_or_disasm_window): Remove.
6226 (show_source_or_disasm_and_command): Simplify.
6227 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6228 (struct tui_source_window_base) <reset>: Likewise.
6229 <execution_info>: Remove initializer.
6230 * tui/tui-data.c (tui_source_window_base): Initialize
6231 execution_info.
6232
6233 2019-07-17 Tom Tromey <tom@tromey.com>
6234
6235 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6236 variable.
6237
6238 2019-07-17 Tom Tromey <tom@tromey.com>
6239
6240 * tui/tui.c (tui_rl_other_window): Update.
6241 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6242 superclass method first. Always iterate over regs_content.
6243 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6244 method.
6245 * tui/tui-win.c (tui_set_focus_command): Update.
6246
6247 2019-07-17 Tom Tromey <tom@tromey.com>
6248
6249 * tui/tui-win.c (tui_set_focus_command): Rename from
6250 tui_set_focus. Call tui_enable.
6251 (tui_set_focus_command): Remove.
6252
6253 2019-07-17 Tom Tromey <tom@tromey.com>
6254
6255 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6256 refresh_window.
6257 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6258 touchwin.
6259 (tui_data_window::refresh_window): Call refresh_window on data
6260 items. Always call superclass refresh_window.
6261 (tui_win_info::refresh): Remove.
6262 (tui_source_window_base::refresh_window): Update.
6263 (tui_refresh_all): Update.
6264 * tui/tui-layout.c (show_source_disasm_command): Remove call to
6265 refresh_window.
6266 (show_source_or_disasm_and_command): Likewise.
6267 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6268 (struct tui_source_window_base) <refresh>: Likewise.
6269
6270 2019-07-17 Tom Tromey <tom@tromey.com>
6271
6272 * tui/tui-winsource.c (tui_clear_source_content)
6273 (tui_show_source_content): Update.
6274 * tui/tui-source.c (tui_source_window::showing_source_p): Check
6275 whether content is empty.
6276 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
6277 Remove.
6278
6279 2019-07-17 Tom Tromey <tom@tromey.com>
6280
6281 * tui/tui-winsource.c (tui_erase_source_content): Clear the
6282 window's contents.
6283 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
6284 * tui/tui-source.c (tui_set_source_content_nil): Remove.
6285
6286 2019-07-17 Tom Tromey <tom@tromey.com>
6287
6288 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
6289 (struct tui_data_item_window): Update.
6290
6291 2019-07-17 Tom Tromey <tom@tromey.com>
6292
6293 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
6294 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
6295 defines.
6296
6297 2019-07-17 Tom Tromey <tom@tromey.com>
6298
6299 * tui/tui-winsource.h (tui_erase_source_content)
6300 (tui_clear_source_content): Remove "display_prompt" parameter.
6301 * tui/tui-winsource.c (tui_update_source_window_as_is)
6302 (tui_update_source_windows_with_addr): Update.
6303 (tui_clear_source_content): Remove "display_prompt" parameter.
6304 (tui_erase_source_content): Likewise. Simplify.
6305 (tui_show_source_content): Update.
6306 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6307 * tui/tui-stack.c (tui_show_frame_info): Update.
6308 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
6309 Remove defines.
6310
6311 2019-07-17 Tom Tromey <tom@tromey.com>
6312
6313 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6314 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
6315 parameter.
6316 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
6317 parameter.
6318
6319 2019-07-17 Tom Tromey <tom@tromey.com>
6320
6321 * tui/tui-winsource.c (tui_clear_source_content)
6322 (tui_show_source_content, tui_show_exec_info_content)
6323 (tui_clear_exec_info_content): Update.
6324 * tui/tui-stack.c (tui_show_locator_content): Update.
6325 (tui_show_frame_info): Update.
6326 * tui/tui-source.h (tui_source_window): Don't declare.
6327 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
6328 from tui_source_is_displayed.
6329 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
6330 Remove field.
6331 (struct tui_source_window_base) <content_in_use>: New field. Now
6332 bool.
6333 (struct tui_source_window) <showing_source_p>: New method.
6334 (TUI_SRC_WIN): Change cast.
6335 * tui/tui-data.c (tui_initialize_static_data): Update.
6336
6337 2019-07-17 Tom Tromey <tom@tromey.com>
6338
6339 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
6340 location_matches_p.
6341 * tui/tui-source.c (tui_source_window::location_matches_p): New
6342 method.
6343 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
6344 method.
6345 * tui/tui-data.h (struct tui_source_window_base)
6346 <location_matches_p>: New method.
6347 (struct tui_source_window, struct tui_disasm_window)
6348 <location_matches_p>: Likewise.
6349
6350 2019-07-17 Tom Tromey <tom@tromey.com>
6351
6352 * tui/tui-win.c (tui_set_win_height_command): Rename from
6353 tui_set_win_height.
6354 (tui_set_win_height_command): Remove.
6355
6356 2019-07-17 Tom Tromey <tom@tromey.com>
6357
6358 * tui/tui-source.c (tui_source_window): New constructor. Add
6359 observer.
6360 (~tui_source_window): New destructor.
6361 (tui_source_window::style_changed): New method.
6362 * tui/tui-hooks.c (tui_redisplay_source): Remove.
6363 (tui_attach_detach_observers): Update.
6364 * tui/tui-data.h (struct tui_source_window): Make constructor not
6365 inline. Add destructor.
6366 (struct tui_source_window) <style_changed>: New method.
6367 <m_observable>: New member.
6368
6369 2019-07-17 Tom Tromey <tom@tromey.com>
6370
6371 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
6372 * tui/tui-win.c (tui_resize_all): Fix typo.
6373
6374 2019-07-17 Tom Tromey <tom@tromey.com>
6375
6376 * tui/tui-wingeneral.h (tui_refresh_all): Update.
6377 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
6378 (tui_refresh_all): Remove "list" parameter. Use foreach.
6379 * tui/tui-win.c (window_name_completer): Use foreach.
6380 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
6381 (update_tab_width): Likewise.
6382 * tui/tui-layout.c (show_layout): Update.
6383 * tui/tui-data.h (class tui_window_iterator): New.
6384 (struct all_tui_windows): New.
6385 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
6386
6387 2019-07-17 Tom Tromey <tom@tromey.com>
6388
6389 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
6390 parameter. Don't reference globals.
6391 (tui_reg_command): Update.
6392
6393 2019-07-17 Tom Tromey <tom@tromey.com>
6394
6395 * tui/tui-regs.c (tui_show_registers): Simplify.
6396
6397 2019-07-17 Tom Tromey <tom@tromey.com>
6398
6399 * tui/tui-regs.c (tui_show_registers): Update.
6400 (tui_show_register_group): Add win_info parameter.
6401
6402 2019-07-17 Tom Tromey <tom@tromey.com>
6403
6404 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
6405 Rename from tui_display_reg_element_at_line.
6406 (tui_data_window::display_registers_from_line): Update.
6407 * tui/tui-data.h (struct tui_data_window)
6408 <display_reg_element_at_line>: New method.
6409
6410 2019-07-17 Tom Tromey <tom@tromey.com>
6411
6412 * tui/tui-regs.h (tui_display_registers_from)
6413 (tui_display_registers_from_line): Don't declare.
6414 * tui/tui-windata.c (tui_data_window::display_all_data)
6415 (tui_data_window::refresh_all)
6416 (tui_data_window::do_scroll_vertical): Update.
6417 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
6418 from tui_display_registers_from.
6419 (tui_display_reg_element_at_line): Update.
6420 (tui_data_window::display_registers_from_line): Rename from
6421 tui_display_registers_from_line.
6422 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
6423 display_registers_from_line>: New methods.
6424
6425 2019-07-17 Tom Tromey <tom@tromey.com>
6426
6427 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
6428 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
6429 from tui_erase_data_content.
6430 (tui_data_window::display_all_data)
6431 (tui_data_window::refresh_all)
6432 (tui_data_window::do_scroll_vertical): Update.
6433 * tui/tui-regs.c (tui_show_registers): Update.
6434 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
6435 New method.
6436
6437 2019-07-17 Tom Tromey <tom@tromey.com>
6438
6439 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
6440 declare.
6441 * tui/tui-windata.c
6442 (tui_data_window::delete_data_content_windows): Rename from
6443 tui_delete_data_content_windows.
6444 (tui_data_window::display_all_data)
6445 (tui_data_window::do_scroll_vertical): Update.
6446 * tui/tui-data.h (struct tui_data_window)
6447 <delete_data_content_windows>: New method.
6448
6449 2019-07-17 Tom Tromey <tom@tromey.com>
6450
6451 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
6452 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
6453
6454 2019-07-17 Tom Tromey <tom@tromey.com>
6455
6456 * tui/tui-windata.h (tui_display_all_data): Don't declare.
6457 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
6458 from tui_display_all_data.
6459 * tui/tui-win.c
6460 (tui_data_window::do_make_visible_with_new_height): Update.
6461 * tui/tui-regs.c (tui_show_registers): Update.
6462 * tui/tui-layout.c (tui_set_layout): Update.
6463 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
6464 method.
6465
6466 2019-07-17 Tom Tromey <tom@tromey.com>
6467
6468 * tui/tui-windata.h (tui_display_data_from): Don't declare.
6469 * tui/tui-windata.c (tui_display_data_from): Remove.
6470 (tui_data_window::refresh_all): Update.
6471
6472 2019-07-17 Tom Tromey <tom@tromey.com>
6473
6474 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
6475 * tui/tui-windata.c (tui_display_data_from_line): Remove.
6476 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
6477 tui_display_registers_from_line.
6478 * tui/tui-regs.h (tui_display_registers_from_line): Update.
6479 * tui/tui-regs.c (tui_display_registers_from_line): Remove
6480 "force_display" parameter.
6481
6482 2019-07-17 Tom Tromey <tom@tromey.com>
6483
6484 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
6485 declare.
6486 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
6487 Rename from tui_first_reg_element_no_inline.
6488 (tui_display_reg_element_at_line)
6489 (tui_display_registers_from_line): Update.
6490 * tui/tui-data.h (struct tui_data_window)
6491 <first_reg_element_no_inline>: New method.
6492
6493 2019-07-17 Tom Tromey <tom@tromey.com>
6494
6495 * tui/tui-windata.c (tui_display_data_from)
6496 (tui_data_window::do_scroll_vertical): Update.
6497 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
6498 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
6499 Rename from tui_line_from_reg_element_no.
6500 (tui_display_registers_from_line): Update.
6501 * tui/tui-data.h (struct tui_data_window)
6502 <line_from_reg_element_no>: New method.
6503
6504 2019-07-17 Tom Tromey <tom@tromey.com>
6505
6506 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
6507 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
6508 tui_last_regs_line_no.
6509 (tui_display_reg_element_at_line)
6510 (tui_display_registers_from_line): Update.
6511 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
6512 method.
6513
6514 2019-07-17 Tom Tromey <tom@tromey.com>
6515
6516 PR tui/24722:
6517 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
6518 (tui_update_breakpoint_info): Add "being_deleted" parameter.
6519 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6520 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
6521 (tui_update_breakpoint_info): Likewise.
6522 * tui/tui-hooks.c (tui_event_create_breakpoint)
6523 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
6524 Update.
6525
6526 2019-07-17 Tom Tromey <tom@tromey.com>
6527
6528 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
6529
6530 2019-07-17 Tom Tromey <tom@tromey.com>
6531
6532 * tui/tui-winsource.c (tui_update_source_window_as_is)
6533 (tui_update_source_windows_with_addr): Update.
6534 * tui/tui-source.h (tui_set_source_content)
6535 (tui_show_symtab_source): Add "win_info" parameter.
6536 * tui/tui-source.c (tui_set_source_content): Add "win_info"
6537 parameter.
6538 (tui_show_symtab_source): Likewise.
6539
6540 2019-07-17 Tom Tromey <tom@tromey.com>
6541
6542 * tui/tui-wingeneral.c
6543 (tui_check_and_display_highlight_if_needed): Check can_highlight.
6544
6545 2019-07-17 Tom Tromey <tom@tromey.com>
6546
6547 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
6548 (struct tui_cmd_window) <can_scroll>: New method.
6549 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
6550 method.
6551
6552 2019-07-17 Tom Tromey <tromey@adacore.com>
6553
6554 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
6555 do_field_signed>: Rename. Change type of "value".
6556 * ui-out.c (ui_out::field_signed): Rename from field_int.
6557 Change type of "value".
6558 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
6559 type of "value".
6560 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
6561 do_field_int. Change type of "value".
6562 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
6563 do_field_int. Change type of "value".
6564 * tracepoint.c (trace_status_mi, tfind_1)
6565 (print_one_static_tracepoint_marker): Update.
6566 * thread.c (print_thread_info_1, print_selected_thread_frame):
6567 Update.
6568 * stack.c (print_frame, print_frame_info): Update.
6569 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
6570 Update.
6571 * source.c (print_source_lines_base): Update.
6572 * skip.c (info_skip_command): Update.
6573 * record-btrace.c (btrace_ui_out_decode_error)
6574 (btrace_call_history_src_line): Update.
6575 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
6576 Update.
6577 * progspace.c (print_program_space): Update.
6578 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
6579 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
6580 do_field_int. Change type of "value".
6581 * mi/mi-out.c (mi_ui_out::do_table_begin)
6582 (mi_ui_out::do_table_header): Update.
6583 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
6584 type of "value".
6585 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
6586 (mi_cmd_data_list_changed_registers, output_register)
6587 (mi_cmd_data_read_memory, mi_load_progress)
6588 (mi_cmd_trace_frame_collected): Update.
6589 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
6590 Update.
6591 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
6592 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
6593 (mi_cmd_var_list_children, varobj_update_one): Update.
6594 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
6595 (mi_cmd_stack_list_args, list_arg_or_local): Update.
6596 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
6597 * inferior.c (print_inferior): Update.
6598 * gdb_bfd.c (print_one_bfd): Update.
6599 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6600 Update.
6601 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
6602 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
6603 do_field_int. Change type of "value".
6604 * cli-out.c (cli_ui_out::do_field_signed): Rename from
6605 do_field_int. Change type of "value".
6606 * breakpoint.c (watchpoint_check, print_breakpoint_location)
6607 (print_one_breakpoint_location, print_it_catch_fork)
6608 (print_one_catch_fork, print_it_catch_vfork)
6609 (print_one_catch_vfork, print_it_catch_solib)
6610 (print_it_catch_exec, print_it_ranged_breakpoint)
6611 (print_mention_watchpoint, print_mention_masked_watchpoint)
6612 (bkpt_print_it, update_static_tracepoint): Update.
6613 * break-catch-throw.c (print_it_exception_catchpoint): Update.
6614 * break-catch-syscall.c (print_it_catch_syscall): Update.
6615 * ada-tasks.c (print_ada_task_info): Update.
6616 * ada-lang.c (print_it_exception, print_mention_exception):
6617 Update.
6618
6619 2019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
6620
6621 PR breakpoints/24541
6622 * gdbarch.c: Regenerate.
6623 * gdbarch.h: Regenerate.
6624 * gdbarch.sh: Adjust return type and parameter types for
6625 'stap_adjust_register'.
6626 (i386_stap_adjust_register): Adjust signature and return new
6627 register name.
6628 * stap-probe.c (stap_parse_register_operand): Adjust use of
6629 'gdbarch_stap_adjust_register'.
6630
6631 2019-07-17 Tom Tromey <tromey@adacore.com>
6632
6633 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
6634 declare VEC.
6635 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
6636 std::vector.
6637 (struct s390_process_info): Add initializers.
6638 (s390_add_process): Use new.
6639 (s390_linux_nat_target::low_forget_process): Use delete.
6640 (s390_linux_nat_target::low_new_fork)
6641 (s390_linux_nat_target::stopped_by_watchpoint)
6642 (s390_linux_nat_target::low_prepare_to_resume)
6643 (s390_linux_nat_target::insert_watchpoint)
6644 (s390_linux_nat_target::insert_hw_breakpoint)
6645 (s390_linux_nat_target::remove_watchpoint)
6646 (s390_linux_nat_target::remove_hw_breakpoint): Update.
6647
6648 2019-07-16 John Baldwin <jhb@FreeBSD.org>
6649
6650 * aarch64-fbsd-nat.c: Include regcache.h.
6651 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
6652 argument.
6653 (aarch64_fbsd_nat_target::fetch_registers)
6654 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
6655 variable.
6656 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
6657
6658 2019-07-16 John Baldwin <jhb@FreeBSD.org>
6659
6660 * fbsd-nat.c: Include gdbarch.h.
6661
6662 2019-07-15 Tom Tromey <tromey@adacore.com>
6663
6664 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
6665
6666 2019-07-15 Tom Tromey <tromey@adacore.com>
6667
6668 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
6669 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
6670 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
6671 * cli-out.c (cli_ui_out::do_field_int): New method.
6672 * ui-out.c (ui_out::field_unsigned): New method.
6673 * symfile.c (generic_load): Use field_unsigned.
6674 (print_transfer_performance): Likewise.
6675 * record-btrace.c (ui_out_field_uint): Remove.
6676 (btrace_call_history_insn_range, btrace_call_history): Use
6677 field_unsigned.
6678 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
6679 field_unsigned.
6680 * ui-out.h (class ui_out) <field_unsigned>: New method.
6681 <do_field_unsigned>: Likewise.
6682
6683 2019-07-15 Tom Tromey <tromey@adacore.com>
6684
6685 * mi/mi-main.c (list_available_thread_groups): Use field_string.
6686 * mi/mi-interp.c (mi_memory_changed): Use field_string.
6687 * target.c (flash_erase_command): Use field_string.
6688 * infrun.c (print_signal_received_reason): Use field_string.
6689 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
6690 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
6691 field_string.
6692 * ada-tasks.c (print_ada_task_info): Use field_string.
6693
6694 2019-07-15 Tom Tromey <tromey@adacore.com>
6695
6696 * target.c (flash_erase_command): Use field_core_addr.
6697 * symfile.c (generic_load): Use field_core_addr.
6698 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
6699 Use field_core_addr.
6700 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
6701 field_core_addr.
6702
6703 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6704
6705 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
6706 value if its desired type is smaller than a CORE_ADDR and signed.
6707
6708 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6709
6710 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
6711 of changes to field names, and use new is_reference field to
6712 decide if a property is a reference or not.
6713 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
6714 field.
6715 (struct dwarf2_property_baton): Update header comment, rename
6716 'referenced_type' to 'property_type' and update comments.
6717 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
6718 default property type, store in property baton, update to take
6719 accound of renamed field.
6720 (read_func_scope): Update call to attr_to_dynamic_prop.
6721 (read_array_type): Likewise.
6722 (dwarf2_per_cu_addr_sized_int_type): New function.
6723 (read_subrange_index_type): Move type finding code to
6724 dwarf2_per_cu_addr_sized_int_type.
6725 (read_subrange_type): Update calls to attr_to_dynamic_prop.
6726 (dwarf2_per_cu_addr_type): New function.
6727 (set_die_type): Update calls to attr_to_dynamic_prop.
6728
6729 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6730
6731 * dwarf2read.c (read_subrange_index_type): New function.
6732 (read_subrange_type): Move code into new function and call it.
6733 * gdbtypes.c (create_range_type): Add some asserts.
6734
6735 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6736
6737 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
6738 update return statements.
6739 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
6740 declaration, and update comment to match.
6741 * gdbtypes.c (resolve_dynamic_array): Update call to
6742 dwarf2_evaluate_property to match new return type.
6743
6744 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6745
6746 * valarith.c (value_subscripted_rvalue): Change lowerbound
6747 parameter type from int to LONGEST.
6748 * value.h (value_subscripted_rvalue): Likewise in declaration.
6749
6750 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
6751
6752 * cli/cli-utils.c (info_print_command_completer): New function.
6753 * cli/cli-utils.h: Add 'completer.h' include, and forward
6754 declaration for 'struct cmd_list_element'.
6755 (info_print_command_completer): Declare.
6756 * stack.c (_initialize_stack): Add completer for 'info locals' and
6757 'info args'.
6758 * symtab.c (_initialize_symtab): Add completer for 'info
6759 variables' and 'info functions'.
6760 * NEWS: Mention completion for additional info commands.
6761
6762 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
6763
6764 * cli/cli-utils.c (extract_info_print_args): Delete.
6765 (extract_arg_maybe_quoted): Delete.
6766 (info_print_options_defs): New variable.
6767 (make_info_print_options_def_group): New function.
6768 (extract_info_print_options): Define new function.
6769 * cli/cli-utils.h (extract_info_print_args): Delete.
6770 (struct info_print_options): New structure.
6771 (extract_info_print_options): Declare new function.
6772 * stack.c (info_locals_command): Update to use new
6773 extract_info_print_options, also add a header comment.
6774 (info_args_command): Likewise.
6775 * symtab.c (info_variables_command): Likewise.
6776 (info_functions_command): Likewise.
6777
6778 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
6779
6780 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
6781 to extract string arguments.
6782 * common/common-utils.c (extract_string_maybe_quoted): New function.
6783 * common/common-utils.h (extract_string_maybe_quoted): Declare.
6784
6785 2019-07-11 Tom Tromey <tromey@adacore.com>
6786
6787 * main.c (get_init_files): Use GDBINIT, not gdbinit.
6788 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
6789 * top.h (gdbinit): Don't declare.
6790 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
6791 into...
6792 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
6793 * top.c (gdb_init): Don't call init_cli_cmds.
6794 (gdbinit): Remove.
6795 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
6796
6797 2019-07-11 Tom Tromey <tromey@adacore.com>
6798
6799 * python/py-inferior.c (add_thread_object): Don't use thread_obj
6800 after it has been moved.
6801
6802 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
6803
6804 * valops.c (value_must_coerce_to_target): Change return type to
6805 bool.
6806 * value.h (value_must_coerce_to_target): Likewise.
6807
6808 2019-07-10 Simon Marchi <simon.marchi@efficios.com>
6809
6810 * breakpoint.c (is_hardware_watchpoint): Remove
6811 forward-declaration.
6812 (is_masked_watchpoint): Change return type to bool.
6813 (is_tracepoint): Likewise.
6814 (is_breakpoint): Likewise.
6815 (is_hardware_watchpoint): Likewise.
6816 (is_watchpoint): Likewise.
6817 (is_no_memory_software_watchpoint): Likewise.
6818 (is_catchpoint): Likewise.
6819 (breakpoint_1): Make FILTER parameter's return type bool.
6820 is_masked_watchpoint): Change return type to bool.
6821 (save_breakpoints): Make FILTER parameter's return type bool.
6822 * breakpoint.h (is_breakpoint): Change return type to bool.
6823 (is_watchpoint): Likewise.
6824 (is_catchpoint): Likewise.
6825 (is_tracepoint): Likewise.
6826
6827 2019-07-10 Tom Tromey <tom@tromey.com>
6828
6829 * defs.h: Don't include gdbarch.h.
6830 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
6831 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
6832 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
6833 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
6834 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
6835 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
6836 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
6837 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
6838 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
6839 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
6840 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
6841 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
6842 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
6843 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
6844 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
6845 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
6846 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
6847 record-btrace.c, record.h, regcache-dump.c, regcache.h,
6848 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
6849 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
6850 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
6851 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
6852 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
6853 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
6854 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
6855 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
6856 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
6857
6858 2019-07-10 Tom Tromey <tromey@adacore.com>
6859
6860 * ada-lang.h (is_ada_exception_catchpoint): Declare.
6861 * breakpoint.c (init_ada_exception_breakpoint): Register as
6862 bp_catchpoint.
6863 (print_one_breakpoint_location, print_one_breakpoint): Use
6864 is_ada_exception_catchpoint.
6865 * ada-lang.c (class ada_catchpoint_location): Pass
6866 bp_loc_software_breakpoint to bp_location constructor.
6867 (is_ada_exception_catchpoint): New function.
6868
6869 2019-07-10 Tom Tromey <tromey@adacore.com>
6870
6871 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
6872 VEC.
6873 (struct arm_exidx_entry): New method operator<.
6874 (struct arm_exidx_data) <section_maps>: Change type.
6875 (arm_exidx_data_free): Remove.
6876 (arm_exidx_data_key): Change type. Move lower.
6877 (arm_exidx_new_objfile): Update.
6878 (arm_compare_exidx_entries): Remove.
6879 (arm_find_exidx_entry, _initialize_arm_tdep)
6880
6881 2019-07-10 Tom Tromey <tromey@adacore.com>
6882
6883 * solib-spu.c (ocl_program_data_key): Change type.
6884 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
6885 Update.
6886
6887 2019-07-10 Tom Tromey <tromey@adacore.com>
6888
6889 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
6890 (struct solib_aix_inferior_data) <library_list>: Change type.
6891 (solib_aix_inferior_data_handle): Change type.
6892 (get_solib_aix_inferior_data): Update.
6893 (solib_aix_free_library_list): Remove.
6894 (library_list_start_library): Update.
6895 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
6896 return type.
6897 (solib_aix_get_library_list)
6898 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
6899 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
6900
6901 2019-07-10 Tom Tromey <tromey@adacore.com>
6902
6903 * solib-dsbt.c (struct dsbt_info): Add initializers.
6904 (solib_dsbt_pspace_data): Change type.
6905 (dsbt_pspace_data_cleanup): Remove.
6906 (get_dsbt_info, _initialize_dsbt_solib): Update.
6907
6908 2019-07-10 Tom Tromey <tromey@adacore.com>
6909
6910 * spu-tdep.c (spu_overlay_data): Change type.
6911 (spu_get_overlay_table, spu_overlay_new_objfile)
6912 (_initialize_spu_tdep): Update.
6913
6914 2019-07-10 Tom Tromey <tromey@adacore.com>
6915
6916 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
6917 destructor.
6918 (dbx_objfile_data_key): Change type and declare later.
6919 (DBX_SYMFILE_INFO): Rewrite.
6920 * dbxread.c (dbx_objfile_data_key): Change type.
6921 (dbx_symfile_init): Update.
6922 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
6923 (coffstab_build_psymtabs, elfstab_build_psymtabs)
6924 (stabsect_build_psymtabs, _initialize_dbxread): Update.
6925
6926 2019-07-10 Tom Tromey <tromey@adacore.com>
6927
6928 * jit.c (jit_program_space_key): Change type. Move lower.
6929 (get_jit_program_space_data): Update.
6930 (jit_program_space_data_cleanup): Remove.
6931 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
6932 Update.
6933 (struct jit_program_space_data): Add initializers.
6934
6935 2019-07-10 Tom Tromey <tromey@adacore.com>
6936
6937 * solib-darwin.c (struct darwin_info): Add initializers.
6938 (solib_darwin_pspace_data): Change type.
6939 (darwin_pspace_data_cleanup): Remove.
6940 (get_darwin_info, _initialize_darwin_solib): Update.
6941
6942 2019-07-10 Tom Tromey <tromey@adacore.com>
6943
6944 * remote-sim.c (struct sim_inferior_data): Add initializers,
6945 constructor, and destructor.
6946 (sim_inferior_data_key): Change type. Move lower.
6947 (check_for_duplicate_sim_descriptor): Update.
6948 (get_sim_inferior_data): Use new. Update.
6949 (~sim_inferior_data_cleanup): Rename from
6950 sim_inferior_data_cleanup. Simplify.
6951 (gdbsim_close_inferior, simulator_command)
6952 (sim_command_completer, _initialize_remote_sim): Update.
6953 (next_pid, INITIAL_PID): Move earlier.
6954
6955 2019-07-10 Tom Tromey <tromey@adacore.com>
6956
6957 * python/python-internal.h (create_thread_object): Return
6958 gdbpy_ref.
6959 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
6960 * python/py-inferior.c (struct threadlist_entry): Add
6961 constructor.
6962 <thread_obj>: Now a gdbpy_ref.
6963 (thread_to_thread_object): Update.
6964 (add_thread_object): Use new.
6965 (delete_thread_object): Use delete.
6966 (infpy_threads): Update.
6967 (py_free_inferior): Update. Construct "inf_obj" after acquiring
6968 GIL.
6969
6970 2019-07-10 Tom Tromey <tromey@adacore.com>
6971
6972 * valops.c (value_cast): Specialize error message for Ada.
6973
6974 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
6975
6976 * breakpoint.c (breakpoint_1): Update doc and parameter names.
6977
6978 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
6979
6980 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
6981 bpstat_should_step): Return bool, adjust comments.
6982 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
6983 bpstat_should_step): Likewise.
6984
6985 2019-07-10 Alan Hayward <alan.hayward@arm.com>
6986
6987 * features/Makefile: Use feature target descriptions for Arm.
6988 * features/arm/arm-core.c: Generate new file.
6989 * features/arm/arm-fpa.c: Likewise.
6990 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
6991 * features/arm/arm-m-profile.c: Likewise.
6992 * features/arm/arm-vfpv2.c: Likewise.
6993 * features/arm/arm-vfpv3.c: Likewise.
6994 * features/arm/xscale-iwmmxt.c: Likewise.
6995 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
6996
6997 2019-07-10 Alan Hayward <alan.hayward@arm.com>
6998
6999 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7000 ptrace earlier.
7001
7002 2019-07-10 Alan Hayward <alan.hayward@arm.com>
7003
7004 * features/aarch64-pauth.c: Regenerate.
7005
7006 2019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
7007
7008 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7009 bool.
7010 (bpstat_what): Use false instead of 0.
7011
7012 2019-07-09 Pedro Alves <palves@redhat.com>
7013
7014 * break-catch-throw.c (is_exception_catchpoint): New.
7015 * breakpoint.c (print_one_breakpoint_location): New parameter
7016 'raw_loc'. Handle it. Use
7017 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7018 looking at the breakpoint's type.
7019 (print_one_breakpoint): If handling "maint info breakpoints", also
7020 print locations of exception catchpoints.
7021 * breakpoint.h (is_exception_catchpoint): Declare.
7022
7023 2019-07-09 Pedro Alves <palves@redhat.com>
7024
7025 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7026 "addr" field.
7027 (allocate_location_exception_catchpoint): New.
7028 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7029 (initialize_throw_catchpoint_ops): Install
7030 allocate_location_exception_catchpoint as allocate_location
7031 method.
7032 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7033 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7034 bp_loc_other.
7035 (breakpoint_address_is_meaningful): Delete.
7036 (bl_address_is_meaningful): New.
7037 (breakpoint_locations_match): Adjust comment.
7038 (bp_location_from_bp_type): New, factored out of...
7039 (bp_location::bp_location(breakpoint *)): ... this.
7040 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7041 factored out of...
7042 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
7043 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7044 breakpoint_address_is_meaningful.
7045 (bp_locations_compare): Adjust comment.
7046 (update_global_location_list): Use bl_address_is_meaningful
7047 instead of breakpoint_address_is_meaningful.
7048 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7049 explicit.
7050 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7051 * python/py-breakpoint.c (bppy_get_location): No longer check
7052 whether location is null.
7053
7054 2019-07-09 Pedro Alves <palves@redhat.com>
7055
7056 PR c++/15468
7057 * breakpoint.c (print_one_breakpoint_location): Remove
7058 single-location assert.
7059
7060 2019-07-09 Tom Tromey <tom@tromey.com>
7061
7062 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7063 * configure: Rebuild.
7064 * configure.ac: Change common to gdbsupport.
7065 * gdbsupport: Rename from common.
7066 * acinclude.m4: Change common to gdbsupport.
7067 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7068 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7069 gdbsupport.
7070 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7071 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7072 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7073 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7074 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7075 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7076 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7077 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7078 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7079 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7080 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7081 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7082 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7083 coff-pe-read.c, command.h, compile/compile-c-support.c,
7084 compile/compile-c.h, compile/compile-cplus-symbols.c,
7085 compile/compile-cplus-types.c, compile/compile-cplus.h,
7086 compile/compile-loc2c.c, compile/compile.c, completer.c,
7087 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7088 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7089 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7090 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7091 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7092 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7093 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7094 features/aarch64-core.c, features/aarch64-fpu.c,
7095 features/aarch64-pauth.c, features/aarch64-sve.c,
7096 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7097 features/i386/32bit-core.c, features/i386/32bit-linux.c,
7098 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7099 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7100 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7101 features/i386/64bit-core.c, features/i386/64bit-linux.c,
7102 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7103 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7104 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7105 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7106 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7107 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7108 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7109 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7110 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7111 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7112 go32-nat.c, guile/guile.c, guile/scm-ports.c,
7113 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7114 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7115 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7116 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7117 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7118 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7119 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7120 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7121 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7122 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7123 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7124 minsyms.c, mips-linux-tdep.c, namespace.h,
7125 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7126 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7127 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7128 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7129 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7130 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7131 nat/linux-waitpid.c, nat/mips-linux-watch.c,
7132 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7133 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7134 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7135 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7136 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7137 procfs.c, producer.c, progspace.h, psymtab.h,
7138 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7139 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7140 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7141 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7142 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7143 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7144 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7145 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7146 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7147 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7148 target-memory.c, target.c, target.h, target/waitstatus.c,
7149 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7150 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7151 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7152 unittests/array-view-selftests.c,
7153 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7154 unittests/common-utils-selftests.c,
7155 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7156 unittests/format_pieces-selftests.c,
7157 unittests/function-view-selftests.c,
7158 unittests/lookup_name_info-selftests.c,
7159 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7160 unittests/mkdir-recursive-selftests.c,
7161 unittests/observable-selftests.c,
7162 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7163 unittests/parse-connection-spec-selftests.c,
7164 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7165 unittests/scoped_fd-selftests.c,
7166 unittests/scoped_mmap-selftests.c,
7167 unittests/scoped_restore-selftests.c,
7168 unittests/string_view-selftests.c, unittests/style-selftests.c,
7169 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7170 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7171 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7172 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7173 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7174 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7175
7176 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7177
7178 * linespec.c (decode_digits_list_mode): Set explicit_line to a
7179 bool value.
7180 (decode_digits_ordinary): Set explicit_line field in sal.
7181 * symtab.c (skip_prologue_sal): Don't skip prologue for a
7182 symtab_and_line that was set on an explicit line number in
7183 assembler code. Do always update the recorded symtab and line if
7184 we do skip the prologue.
7185
7186 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7187
7188 * breakpoint.c (set_breakpoint_location_function): Remove
7189 explicit_loc parameter.
7190 (momentary_breakpoint_from_master): Update call to
7191 set_breakpoint_location_function.
7192 (add_location_to_breakpoint): Likewise.
7193
7194 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7195
7196 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7197 required features based on default bfd type when no specific bfd
7198 is present.
7199
7200 2019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7201
7202 * NEWS: Mention that GDB printf and eval commands can now print
7203 C-style and Ada-style convenience var strings without
7204 calling the inferior.
7205 * printcmd.c (printf_c_string): Locally print GDB internal var
7206 instead of transiting via the inferior.
7207 (printf_wide_c_string): Likewise.
7208
7209 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7210
7211 PR breakpoints/25011
7212 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7213
7214 2019-07-04 Tom Tromey <tom@tromey.com>
7215
7216 PR tui/24724:
7217 * tui/tui-winsource.c (tui_clear_source_content): Update.
7218 (tui_source_window_base::set_is_exec_point_at): Fix comment.
7219 (tui_update_breakpoint_info): Update.
7220 (tui_set_exec_info_content): Update.
7221 * tui/tui-source.c (tui_set_source_content_nil): Update.
7222 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7223 has_break.
7224 * tui/tui-data.h (enum tui_bp_flag): New.
7225 (tui_bp_flags): New enum flags type.
7226 (struct tui_source_element) <break_mode>: Change type. Rename
7227 from has_break.
7228 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7229 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
7230 constants.
7231 * tui/tui-winsource.h: Fix comment.
7232
7233 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7234
7235 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7236 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7237 (store_fpregs_to_thread)
7238 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7239 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7240 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7241 (IWMMXT_REGS_SIZE): Add define.
7242 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7243 (fetch_vfp_regs, store_vfp_regs)
7244 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7245 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7246
7247 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7248
7249 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7250 defines.
7251 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7252 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7253 (ARM_INT_REGISTER_SIZE): ...to this.
7254 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7255 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7256 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7257 (arm_linux_collect_gregset, supply_nwfpe_register)
7258 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7259 defines.
7260 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7261 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7262 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7263 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7264 (arm_return_in_memory, arm_store_return_value)
7265 (arm_get_longjmp_target, arm_register_g_packet_guesses)
7266 (arm_record_ld_st_multiple): Likewise.
7267 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7268 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7269
7270 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7271
7272 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
7273 AARCH64_DISPLACED_MODIFIED_INSNS.
7274 * aarch64-tdep.c (struct aarch64_displaced_step_data)
7275 (aarch64_displaced_step_copy_insn): Likewise.
7276 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7277 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
7278 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
7279 ARM_DISPLACED_MODIFIED_INSNS.
7280 * arm-tdep.c (arm_gdbarch_init): Likewise.
7281 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7282 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
7283 (struct arm_displaced_step_closure): Use
7284 ARM_DISPLACED_MODIFIED_INSNS.
7285
7286 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7287
7288 * features/Makefile: Remove unused xml files.
7289 * features/aarch64.xml: Remove.
7290 * features/i386/amd64-avx-avx512-linux.xml: Remove.
7291 * features/i386/amd64-avx-avx512.xml: Remove.
7292 * features/i386/amd64-avx-linux.xml: Remove.
7293 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
7294 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
7295 * features/i386/amd64-avx-mpx-linux.xml: Remove.
7296 * features/i386/amd64-avx-mpx.xml: Remove.
7297 * features/i386/amd64-avx.xml: Remove.
7298 * features/i386/amd64-linux.xml: Remove.
7299 * features/i386/amd64-mpx-linux.xml: Remove.
7300 * features/i386/amd64-mpx.xml: Remove.
7301 * features/i386/amd64.xml: Remove.
7302 * features/i386/i386-avx-avx512-linux.xml: Remove.
7303 * features/i386/i386-avx-avx512.xml: Remove.
7304 * features/i386/i386-avx-linux.xml: Remove.
7305 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
7306 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
7307 * features/i386/i386-avx-mpx-linux.xml: Remove.
7308 * features/i386/i386-avx-mpx.xml: Remove.
7309 * features/i386/i386-avx.xml: Remove.
7310 * features/i386/i386-linux.xml: Remove.
7311 * features/i386/i386-mmx-linux.xml: Remove.
7312 * features/i386/i386-mmx.xml: Remove.
7313 * features/i386/i386-mpx-linux.xml: Remove.
7314 * features/i386/i386-mpx.xml: Remove.
7315 * features/i386/i386.xml: Remove.
7316 * features/i386/x32-avx-avx512-linux.xml: Remove.
7317 * features/i386/x32-avx-linux.xml: Remove.
7318 * features/i386/x32-linux.xml: Remove.
7319
7320 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7321
7322 * regformats/aarch64.dat: Remove.
7323 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
7324 * regformats/i386/amd64-avx-linux.dat: Remove.
7325 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
7326 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
7327 * regformats/i386/amd64-linux.dat: Remove.
7328 * regformats/i386/amd64-mpx-linux.dat: Remove.
7329 * regformats/i386/amd64.dat: Remove.
7330 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
7331 * regformats/i386/i386-avx-linux.dat: Remove.
7332 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
7333 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
7334 * regformats/i386/i386-linux.dat: Remove.
7335 * regformats/i386/i386-mmx-linux.dat: Remove.
7336 * regformats/i386/i386-mpx-linux.dat: Remove.
7337 * regformats/i386/i386.dat: Remove.
7338 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
7339 * regformats/i386/x32-avx-linux.dat: Remove.
7340 * regformats/i386/x32-linux.dat: Remove.
7341
7342 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7343
7344 * aarch64-tdep.c: Remove xml self tests.
7345 * amd64-linux-tdep.c: Likewise.
7346 * amd64-tdep.c: Likewise.
7347 * i386-linux-tdep.c: Likewise.
7348 * i386-tdep.c: Likewise.
7349
7350 2019-07-03 Pedro Alves <palves@redhat.com>
7351
7352 PR cli/24732
7353 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
7354 (pipe_cmd_option_defs): New.
7355 (make_pipe_cmd_options_def_group): New.
7356 (pipe_command): Use gdb::option::process_options.
7357 (pipe_command_completer): New function.
7358 (_initialize_cli_cmds): Install completer for "pipe" command.
7359
7360 2019-07-03 Pedro Alves <palves@redhat.com>
7361
7362 * cli/cli-option.c (union option_value) <string>: New field.
7363 (struct option_def_and_value): Add ctor, move ctor, dtor and
7364 use DISABLE_COPY_AND_ASSIGN.
7365 (option_def_and_value::clear_value): New.
7366 (parse_option, save_option_value_in_ctx, get_val_type_str)
7367 (add_setshow_cmds_for_options): Handle var_string.
7368 * cli-option.h (union option_def::var_address) <string>: New
7369 field.
7370 (struct string_option_def): New.
7371 * maint-test-options.c (struct test_options_opts): Add default
7372 ctor and use DISABLE_COPY_AND_ASSIGN.
7373 <string_opt>: New field.
7374 (test_options_opts::~test_options_opts): New.
7375 (test_options_opts::dump): Also dump "-string".
7376 (test_options_option_defs): Install "string.
7377
7378 2019-07-03 Pedro Alves <palves@redhat.com>
7379
7380 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
7381 option_value with a null enumeration.
7382 (complete_options): Save the option values in the context.
7383 (save_option_value_in_ctx): New, factored out from ...
7384 (process_options): ... here.
7385 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
7386 of the function.
7387 * maint-test-options.c (test_options_opts::dump): New, factored
7388 out from ...
7389 (maintenance_test_options_command_mode): ... here.
7390 (maintenance_test_options_command_completion_result): Delete.
7391 (maintenance_test_options_command_completion_text): Update
7392 comment.
7393 (maintenance_show_test_options_completion_result): Change
7394 prototype. Just print
7395 maintenance_test_options_command_completion_text.
7396 (save_completion_result): New.
7397 (maintenance_test_options_completer_mode): Pass options context to
7398 complete_options, and then save a dump.
7399 (_initialize_maint_test_options): Use add_cmd to install "maint
7400 show test-options-completion-result".
7401
7402 2019-07-03 Pedro Alves <palves@redhat.com>
7403
7404 * NEWS (New commands): Mention "with" and "maint with".
7405 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
7406 (with_command, with_command_completer): New.
7407 (pipe_command): Adjust to new repeat_previous
7408 interface.
7409 (_initialize_cli_cmds): Install the "with" command and its "w"
7410 alias.
7411 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
7412 declarations.
7413 * cli/cli-setshow.c (parse_cli_var_uinteger)
7414 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
7415 argument strings for all var_types.
7416 (get_setshow_command_value_string): New, factored out from ...
7417 (do_show_command): ... this.
7418 * cli/cli-setshow.h: Include <string>.
7419 (get_setshow_command_value_string): Declare.
7420 * command.h (repeat_previous): Now returns const char *. Adjust
7421 comment.
7422 * maint.c: Include "cli/cli-cmds.h".
7423 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
7424 (_initialize_maint_cmds): Register the "maintenance with" command.
7425 * top.c (repeat_previous): Move bits from pipe_command here:
7426 Return the saved command line, if any; error out if there's no
7427 command to relaunch.
7428
7429 2019-07-03 Pedro Alves <palves@redhat.com>
7430
7431 * NEWS (New commands): Mention "maint set/show test-settings"
7432 instead of "maint test-settings".
7433 * maint-test-settings.c (maintenance_test_settings_list): Delete.
7434 (maintenance_test_settings_set_list): Rename to ...
7435 (maintenance_set_test_settings_list): ... this.
7436 (maintenance_test_settings_show_list): Rename to ...
7437 (maintenance_show_test_settings_list): ... this.
7438 (maintenance_test_settings_cmd): Delete.
7439 (maintenance_test_settings_set_cmd): ...
7440 (maintenance_set_test_settings_cmd): ... this.
7441 (maintenance_test_settings_show_cmd): ...
7442 (maintenance_show_test_settings_cmd): ... this.
7443 (maintenance_test_settings_show_value_cmd):
7444 (maintenance_show_test_settings_value_cmd): ... this.
7445 (_initialize_maint_test_settings): No longer install the "maint
7446 test-settings" prefix command. Rename "maint test-settings set"
7447 to "maint set test-settings", and "maint test-settings show" to
7448 "maint show test-settings". Adjust all subcommands.
7449
7450 2019-07-03 Pedro Alves <palves@redhat.com>
7451
7452 * maint-test-settings.c: Fix file's intro comment. Replace all
7453 references to "test-options" with references to "test-settings",
7454 in comments.
7455
7456 2019-07-03 Pedro Alves <palves@redhat.com>
7457
7458 * maint-test-settings.c (maintenance_test_settings_xxx)
7459 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
7460 New.
7461 (maintenance_test_settings_enums): Use them.
7462 (maintenance_test_settings_enum): Default to
7463 maintenance_test_settings_xxx.
7464 (_initialize_maint_test_settings): Initialize
7465 MAINTENANCE_TEST_SETTINGS_FILENAME.
7466
7467 2019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
7468
7469 * breakpoint.h (remove_breakpoints_inf): Change return type to
7470 void, move function documentation here.
7471 * breakpoint.c (remove_breakpoints_inf): Change return type to
7472 void, move function documentation to header.
7473
7474 2019-07-02 Pedro Alves <palves@redhat.com>
7475
7476 * NEWS (Completion improvements): Mention "info threads".
7477 * thread.c (struct info_threads_opts, info_threads_option_defs)
7478 (make_info_threads_options_def_group): New.
7479 (info_threads_command): Use gdb::option::process_options.
7480 (info_threads_command_completer): New.
7481 (_initialize_thread): Use gdb::option::build_help to build the
7482 help text for "info threads".
7483
7484 2019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
7485
7486 * defs.h (generic_load): Move from here...
7487 * symfile.h (generic_load): ... to here. Rename name parameter
7488 to args.
7489 * symfile.c (generic_load): Add comment.
7490
7491 2019-07-01 Tom Tromey <tromey@adacore.com>
7492
7493 * dwarf2read.c
7494 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
7495 declaration of without_params. Fix formatting.
7496
7497 2019-07-01 Tom Tromey <tromey@adacore.com>
7498
7499 * ada-exp.y (find_primitive_type): Update.
7500 * ada-lang.h (ada_lookup_symbol): Update.
7501 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
7502 parameter.
7503 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
7504
7505 2019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
7506
7507 PR breakpoints/24541
7508 * gdbarch.c: Regenerate.
7509 * gdbarch.h: Regenerate.
7510 * gdbarch.sh: Add 'stap_adjust_register'.
7511 * i386-tdep.c: Include '<unordered_set>'.
7512 (i386_stap_adjust_register): New function.
7513 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
7514 * stap-probe.c (stap_parse_register_operand): Call
7515 'gdbarch_stap_adjust_register'.
7516
7517 2019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
7518
7519 PR python/24742
7520 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
7521 * python/python.c (do_start_initialization): Use 'xmalloc'
7522 instead of 'PyMem_Malloc'.
7523
7524 2019-06-28 Tom Tromey <tromey@adacore.com>
7525
7526 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
7527 for Ada.
7528
7529 2019-06-27 Tom Tromey <tromey@adacore.com>
7530
7531 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
7532 objfile_key.
7533 (arm_find_mapping_symbol, arm_record_special_symbol)
7534 (_initialize_arm_tdep): Update.
7535 (arm_objfile_data_free): Remove.
7536
7537 2019-06-27 Tom Tromey <tromey@adacore.com>
7538
7539 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
7540 to cp_print_static_field.
7541
7542 2019-06-26 Tom Tromey <tromey@adacore.com>
7543
7544 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
7545 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
7546 declare.
7547
7548 2019-06-26 Alan Hayward <alan.hayward@arm.com>
7549
7550 * features/aarch64-core.c (create_feature_aarch64_core):
7551 Regenerate.
7552 * features/aarch64-core.xml: Add cpsr flags.
7553
7554 2019-06-26 Alan Hayward <alan.hayward@arm.com>
7555
7556 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
7557 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
7558
7559 2019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
7560
7561 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
7562 field.
7563 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
7564 use.
7565 (arm_record_special_symbol): Don't insert new symbol in sorted
7566 position, push it at the end.
7567
7568 2019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
7569
7570 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
7571 (arm_mapping_symbol_s): Remove.
7572 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
7573 (arm_mapping_symbol_vec): New typedef.
7574 (struct arm_per_objfile): Add constructor.
7575 <section_maps>: Change type to
7576 std::unique_ptr<arm_mapping_symbol_vec[]>.
7577 (arm_compare_mapping_symbols): Remove.
7578 (arm_find_mapping_symbol): Adjust to section_maps type change.
7579 (arm_objfile_data_free): Call delete on arm_per_objfile.
7580 (arm_record_special_symbol): Adjust to section_maps type change.
7581 Allocate arm_per_objfile with new.
7582
7583 2019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7584
7585 * cli/cli-cmds.c (alias_command): Compare the alias prefix
7586 with the command prefix.
7587
7588 2019-06-25 Tom Tromey <tom@tromey.com>
7589
7590 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
7591 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
7592
7593 2019-06-25 Tom Tromey <tom@tromey.com>
7594
7595 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
7596 type.
7597 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
7598 protected.
7599
7600 2019-06-25 Tom Tromey <tom@tromey.com>
7601
7602 * tui/tui-winsource.c
7603 (tui_source_window_base::set_is_exec_point_at): Add check against
7604 LOA_ADDRESS.
7605
7606 2019-06-25 Tom Tromey <tom@tromey.com>
7607
7608 * tui/tui-source.c (tui_set_source_content): Don't check before
7609 xfree.
7610 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
7611
7612 2019-06-25 Tom Tromey <tom@tromey.com>
7613
7614 * tui/tui-winsource.h (tui_update_source_window_as_is)
7615 (tui_alloc_source_buffer, tui_line_is_displayed)
7616 (tui_addr_is_displayed): Change type of win_info.
7617 * tui/tui-winsource.c (tui_update_source_window_as_is)
7618 (tui_clear_source_content, tui_show_source_line)
7619 (tui_show_source_content, tui_source_window_base::refill)
7620 (tui_source_window_base::set_is_exec_point_at)
7621 (tui_source_window_base::set_is_exec_point_at)
7622 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
7623 (tui_alloc_source_buffer, tui_line_is_displayed)
7624 (tui_addr_is_displayed): Change type of win_info. Update.
7625 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7626 (tui_source_window_base::do_make_visible_with_new_height):
7627 Update.
7628 * tui/tui-source.c (tui_set_source_content)
7629 (tui_set_source_content_nil)
7630 (tui_source_window::do_scroll_vertical): Update.
7631 * tui/tui-layout.c (show_layout): Update.
7632 * tui/tui-disasm.c (tui_set_disassem_content)
7633 (tui_disasm_window::do_scroll_vertical): Update.
7634 * tui/tui-data.h (tui_win_content): Remove.
7635 (struct tui_gen_win_info) <content, content_size>: Remove.
7636 (struct tui_source_element): Add initializers and destructor.
7637 (union tui_which_element, struct tui_win_element): Remove.
7638 (struct tui_source_window_base) <content>: New field.
7639 (struct tui_data_window): Remove destructor.
7640 (tui_alloc_content, tui_free_win_content)
7641 (tui_free_all_source_wins_content): Don't declare.
7642 * tui/tui-data.c (tui_initialize_static_data): Update.
7643 (init_content_element, tui_alloc_content): Remove.
7644 (~tui_gen_win_info): Update.
7645 (~tui_data_window, tui_free_all_source_wins_content)
7646 (tui_free_win_content, free_content, free_content_elements):
7647 Remove.
7648
7649 2019-06-25 Tom Tromey <tom@tromey.com>
7650
7651 * tui/tui-winsource.h (tui_clear_source_content)
7652 (tui_erase_source_content, tui_show_source_content): Change type
7653 of win_info.
7654 * tui/tui-winsource.c (tui_clear_source_content)
7655 (tui_erase_source_content, tui_show_source_content): Change type
7656 of win_info.
7657 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
7658 * tui/tui-source.h (tui_set_source_content_nil): Change type of
7659 win_info.
7660 * tui/tui-source.c (tui_set_source_content_nil): Change type of
7661 win_info.
7662 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
7663
7664 2019-06-25 Tom Tromey <tom@tromey.com>
7665
7666 * tui/tui-winsource.c (tui_clear_source_content)
7667 (tui_source_window_base::set_is_exec_point_at): Update.
7668 * tui/tui-source.c (tui_set_source_content_nil): Update.
7669 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
7670 a bool.
7671 * tui/tui-data.c (init_content_element): Update.
7672
7673 2019-06-25 Tom Tromey <tom@tromey.com>
7674
7675 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
7676 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
7677 * tui/tui-layout.c (init_and_make_win): Update.
7678 * tui/tui.h (enum tui_win_type): Update.
7679 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
7680 tui_win_is_auxillary.
7681 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
7682 tui_win_is_auxillary.
7683
7684 2019-06-25 Tom Tromey <tom@tromey.com>
7685
7686 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
7687 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
7688 (tui_delete_data_content_windows, tui_display_all_data)
7689 (tui_data_window::do_scroll_vertical, tui_display_data_from):
7690 Update.
7691 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
7692 * tui/tui-regs.c (tui_last_regs_line_no)
7693 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
7694 (tui_show_registers): Update.
7695 (tui_show_register_group): Return void. Update.
7696 (tui_display_registers_from, tui_display_reg_element_at_line)
7697 (tui_display_registers_from_line, tui_check_register_values):
7698 Update.
7699 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
7700 member.
7701 (struct tui_data_window) <regs_content>: Now a std::vector.
7702 <regs_content_count>: Remove.
7703 (tui_add_content_elements, tui_free_data_content): Don't declare.
7704 * tui/tui-data.c (tui_data_window::clear_detail): Update.
7705 (init_content_element): Remove DATA_WIN case. Add assert.
7706 (tui_add_content_elements): Remove.
7707 (tui_data_window): Update.
7708 (tui_free_data_content): Remove.
7709 (free_content_elements): Remove DATA_WIN case.
7710
7711 2019-06-25 Tom Tromey <tom@tromey.com>
7712
7713 * tui/tui-data.c (tui_data_item_window): Update.
7714 * tui/tui-windata.h (tui_check_data_values): Don't declare.
7715 * tui/tui-windata.c (tui_display_all_data)
7716 (tui_display_data_from_line): Update.
7717 (tui_check_data_values): Remove.
7718 * tui/tui-regs.c (tui_show_register_group)
7719 (tui_display_reg_element_at_line): Update.
7720 * tui/tui-hooks.c (tui_register_changed)
7721 (tui_refresh_frame_and_register_information): Call
7722 tui_check_register_values.
7723 * tui/tui-data.h (struct tui_data_window) <data_content,
7724 data_content_count, data_type>: Remove.
7725 (enum tui_data_type): Remove.
7726
7727 * tui/tui-data.c (tui_data_window::clear_detail)
7728 (~tui_data_window): Update.
7729
7730 2019-06-25 Tom Tromey <tom@tromey.com>
7731
7732 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
7733 declare.
7734 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
7735 Rename from tui_first_data_item_displayed. Update.
7736 (tui_data_window::refresh_all)
7737 (tui_data_window::do_scroll_vertical): Update.
7738 * tui/tui-data.h (struct tui_data_window)
7739 <first_data_item_displayed>: Declare new method.
7740
7741 2019-06-25 Tom Tromey <tom@tromey.com>
7742
7743 * tui/tui-data.h (tui_init_generic_part): Don't declare.
7744 * tui/tui-data.c (tui_init_generic_part): Remove, moving
7745 contents...
7746 (tui_initialize_static_data): ...here.
7747
7748 2019-06-25 Tom Tromey <tom@tromey.com>
7749
7750 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7751 (tui_display_registers_from, tui_check_register_values): Update.
7752 (tui_display_register): Remove win_info parameter; update.
7753 (tui_get_register): Change type of parameters.
7754 * tui/tui-data.h (struct tui_data_element): Remove.
7755 (union tui_which_element) <data>: Remove.
7756 <data_window>: Change type.
7757 (struct tui_data_item_window): New.
7758 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
7759 case. Add assert.
7760 (~tui_data_item_window): New destructor.
7761 (free_content_elements): Remove DATA_ITEM_WIN case.
7762
7763 2019-06-25 Tom Tromey <tom@tromey.com>
7764
7765 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
7766 Remove.
7767
7768 2019-06-25 Tom Tromey <tom@tromey.com>
7769
7770 * tui/tui-data.h (struct tui_command_element): Remove.
7771 (union tui_which_element) <command>: Remove.
7772 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
7773 assert.
7774 (free_content_elements): Remove CMD_WIN case.
7775
7776 2019-06-25 Tom Tromey <tom@tromey.com>
7777
7778 * tui/tui-layout.c (tui_set_layout): Update.
7779 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
7780 * tui/tui-data.c (layout_def): Update.
7781
7782 2019-06-25 Tom Tromey <tom@tromey.com>
7783
7784 * tui/tui-wingeneral.c (tui_refresh_all): Update.
7785 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7786 (tui_source_window_base::set_new_height): Update.
7787 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
7788 Update.
7789 (tui_set_locator_fullname, tui_set_locator_info)
7790 (tui_show_frame_info): Update.
7791 * tui/tui-source.c (tui_set_source_content)
7792 (tui_source_is_displayed): Update.
7793 * tui/tui-layout.c (show_source_disasm_command, show_data)
7794 (show_source_or_disasm_and_command): Update.
7795 * tui/tui-disasm.c (tui_set_disassem_content)
7796 (tui_get_begin_asm_address): Update.
7797 * tui/tui-data.h (struct tui_locator_element): Remove.
7798 (union tui_which_element) <locator>: Remove.
7799 (struct tui_locator_window): New.
7800 (tui_locator_win_info_ptr): Change return type.
7801 * tui/tui-data.c (_locator): Change type.
7802 (tui_locator_win_info_ptr): Change return type.
7803 (init_content_element): Remove LOCATOR_WIN case. Add assert.
7804 (tui_alloc_content): Add assert.
7805
7806 2019-06-25 Tom Tromey <tom@tromey.com>
7807
7808 * tui/tui-winsource.c
7809 (tui_exec_info_window::maybe_allocate_content): New method.
7810 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
7811 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
7812 (make_source_or_disasm_window): Add cast.
7813 * tui/tui-data.h (union tui_which_element) <simple_string>:
7814 Remove.
7815 (struct tui_source_info): New.
7816 (struct tui_source_window_base) <execution_info>: Change type.
7817 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
7818 case, and add assert.
7819 (tui_alloc_content): Add assert.
7820
7821 2019-06-25 Tom Tromey <tom@tromey.com>
7822
7823 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
7824 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
7825 * tui/tui-data.c (tui_alloc_win_info): Remove.
7826
7827 2019-06-25 Tom Tromey <tom@tromey.com>
7828
7829 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
7830 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
7831 can_highlight.
7832
7833 2019-06-25 Tom Tromey <tom@tromey.com>
7834
7835 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
7836 make_visible_with_new_height method.
7837 (tui_win_info::make_visible_with_new_height): New method.
7838 (tui_source_window_base::do_make_visible_with_new_height)
7839 (tui_data_window::do_make_visible_with_new_height)
7840 (tui_cmd_window::do_make_visible_with_new_height): New methods.
7841 (make_visible_with_new_height): Remove.
7842 (tui_resize_all, tui_adjust_win_heights): Use
7843 make_visible_with_new_height method.
7844 * tui/tui-data.h (struct tui_win_info)
7845 <do_make_visible_with_new_height, make_visible_with_new_height>:
7846 New methods.
7847 (struct tui_source_window_base, struct tui_data_window)
7848 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
7849 methods.
7850
7851 2019-06-25 Tom Tromey <tom@tromey.com>
7852
7853 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
7854 method.
7855 (update_tab_width): Call update_tab_width method.
7856 * tui/tui-data.h (struct tui_win_info)
7857 (struct tui_source_window_base) <update_tab_width>: New methods.
7858
7859 2019-06-25 Tom Tromey <tom@tromey.com>
7860
7861 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
7862 parameter.
7863 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
7864 parameter.
7865 (tui_gen_win_info::make_visible): Update.
7866 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
7867 parameter.
7868 * tui/tui-data.h (enum tui_box): New enum.
7869 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
7870
7871 2019-06-25 Tom Tromey <tom@tromey.com>
7872
7873 * tui/tui-layout.c (make_source_or_disasm_window): Always use
7874 init_and_make_win for EXEC_INFO_WIN.
7875 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
7876 longer inline.
7877 (struct tui_win_info) <~tui_win_info>: Inline.
7878 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7879 Don't declare.
7880 * tui/tui-data.c (source_win, disasm_win): Remove globals.
7881 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7882 Remove.
7883 (tui_initialize_static_data): Update.
7884 (~tui_gen_win_info): Handle more cleanup here.
7885 (~tui_source_window_base): Delete "execution_info".
7886 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
7887
7888 2019-06-25 Tom Tromey <tom@tromey.com>
7889
7890 * tui/tui-layout.c (make_command_window): Don't set
7891 can_highlight.
7892 (show_source_disasm_command): Call the reset method.
7893 (show_data): Don't set can_highlight. Call the reset method.
7894 (tui_gen_win_info::reset): Rename from init_gen_win_info
7895 (init_and_make_win): Simplify. Return tui_gen_win_info.
7896 (show_source_or_disasm_and_command): Call the reset method.
7897 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
7898 (struct tui_cmd_window): Set can_highlight.
7899
7900 2019-06-25 Tom Tromey <tom@tromey.com>
7901
7902 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
7903 from make_visible.
7904 (tui_make_visible, tui_make_invisible): Rewrite.
7905 (tui_win_info::make_visible): Remove.
7906 (tui_source_window_base::make_visible): Update.
7907 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
7908 method. Moved from...
7909 (struct tui_win_info) <make_visible>: ...here.
7910
7911 2019-06-25 Tom Tromey <tom@tromey.com>
7912
7913 * tui/tui-winsource.c
7914 (tui_source_window_base::do_scroll_horizontal): Remove direction
7915 parameter.
7916 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
7917 direction parameter.
7918 * tui/tui-win.c (tui_win_info::forward_scroll)
7919 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
7920 (tui_win_info::right_scroll): Update.
7921 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
7922 direction parameter.
7923 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
7924 direction parameter.
7925 * tui/tui-data.h (enum tui_scroll_direction): Remove.
7926 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
7927 Remove direction parameter.
7928 (struct tui_source_window_base, struct tui_source_window)
7929 (struct tui_disasm_window, struct tui_data_window)
7930 (struct tui_cmd_window): Update.
7931
7932 2019-06-25 Tom Tromey <tom@tromey.com>
7933
7934 * tui/tui-winsource.h (tui_set_exec_info_content)
7935 (tui_show_exec_info_content, tui_erase_exec_info_content)
7936 (tui_clear_exec_info_content, tui_update_exec_info): Change
7937 argument to tui_source_window_base.
7938 * tui/tui-winsource.c (tui_set_exec_info_content)
7939 (tui_show_exec_info_content, tui_erase_exec_info_content)
7940 (tui_clear_exec_info_content, tui_update_exec_info): Change
7941 argument to tui_source_window_base.
7942
7943 2019-06-25 Tom Tromey <tom@tromey.com>
7944
7945 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
7946 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
7947
7948 2019-06-25 Tom Tromey <tom@tromey.com>
7949
7950 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
7951 check.
7952
7953 2019-06-25 Tom Tromey <tom@tromey.com>
7954
7955 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
7956 type to void.
7957 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
7958 type to void.
7959 * tui/tui-source.c (tui_set_source_content): Update.
7960 * tui/tui-disasm.c (tui_set_disassem_content): Update.
7961
7962 2019-06-25 Tom Tromey <tom@tromey.com>
7963
7964 * tui/tui-win.c (window_name_completer, tui_set_focus)
7965 (tui_all_windows_info): Use name method.
7966 * tui/tui-data.h (struct tui_gen_win_info)
7967 (struct tui_source_window, struct tui_disasm_window)
7968 (struct tui_data_window, struct tui_cmd_window) <name>: New
7969 method.
7970 (tui_win_name): Don't declare.
7971 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
7972 (tui_win_name): Remove.
7973
7974 2019-06-25 Tom Tromey <tom@tromey.com>
7975
7976 * tui/tui-winsource.h (tui_update_source_window)
7977 (tui_update_source_window_as_is): Change parameter type.
7978 * tui/tui-winsource.c (tui_update_source_window): Change win_info
7979 to be a tui_source_window_base.
7980 (tui_update_source_window_as_is): Likewise.
7981 * tui/tui-win.c (make_visible_with_new_height): Update.
7982
7983 2019-06-25 Tom Tromey <tom@tromey.com>
7984
7985 * tui/tui-winsource.c (tui_erase_source_content)
7986 (tui_show_source_content, tui_show_exec_info_content)
7987 (tui_erase_exec_info_content): Use refresh_window method.
7988 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
7989 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
7990 from tui_refresh_win.
7991 (tui_data_window::refresh_window): New method.
7992 (tui_win_info::refresh, tui_source_window_base::refresh)
7993 (tui_refresh_all): Use refresh_window method.
7994 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
7995 method.
7996 * tui/tui-regs.c (tui_display_register): Call refresh_window
7997 method.
7998 * tui/tui-layout.c (show_source_disasm_command)
7999 (show_source_or_disasm_and_command): Call refresh_window method.
8000 * tui/tui-data.h (struct tui_gen_win_info)
8001 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8002 New method.
8003
8004 2019-06-25 Tom Tromey <tom@tromey.com>
8005
8006 * tui/tui.c (tui_rl_other_window, tui_enable)
8007 (tui_is_window_visible, tui_get_command_dimension): Update.
8008 * tui/tui-winsource.c (tui_update_source_window_as_is)
8009 (tui_clear_source_content, tui_erase_source_content)
8010 (tui_show_source_line, tui_source_window_base::refill)
8011 (tui_source_window_base::do_scroll_horizontal)
8012 (tui_source_window_base::set_is_exec_point_at)
8013 (tui_update_breakpoint_info, tui_set_exec_info_content)
8014 (tui_alloc_source_buffer, tui_line_is_displayed)
8015 (tui_addr_is_displayed): Update.
8016 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8017 (tui_check_and_display_highlight_if_needed)
8018 (tui_win_info::make_visible, tui_win_info::refresh)
8019 (tui_refresh_all): Update.
8020 * tui/tui-windata.c (tui_first_data_item_displayed)
8021 (tui_delete_data_content_windows, tui_erase_data_content)
8022 (tui_display_all_data, tui_data_window::refresh_all)
8023 (tui_check_data_values): Update.
8024 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8025 (tui_set_win_focus_to, tui_win_info::forward_scroll)
8026 (tui_win_info::backward_scroll, tui_refresh_all_win)
8027 (tui_resize_all, tui_set_focus, tui_all_windows_info)
8028 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8029 (tui_source_window_base::set_new_height)
8030 (tui_data_window::set_new_height)
8031 (make_invisible_and_set_new_height)
8032 (make_visible_with_new_height, new_height_ok)
8033 (parse_scrolling_args): Update.
8034 * tui/tui-stack.c (tui_show_frame_info): Update.
8035 * tui/tui-source.c (tui_set_source_content)
8036 (tui_set_source_content_nil, tui_source_is_displayed)
8037 (tui_source_window::do_scroll_vertical): Update.
8038 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8039 (tui_display_registers_from, tui_display_reg_element_at_line)
8040 (tui_check_register_values, tui_reg_command): Update.
8041 * tui/tui-layout.c (tui_default_win_height)
8042 (show_source_disasm_command, show_data, init_and_make_win)
8043 (show_source_or_disasm_and_command): Update.
8044 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8045 (tui_redisplay_readline, tui_mld_flush)
8046 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8047 (tui_getc): Update.
8048 * tui/tui-disasm.c (tui_set_disassem_content)
8049 (tui_disasm_window::do_scroll_vertical): Update.
8050 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8051 Now virtual.
8052 (struct tui_win_info): Derive from tui_gen_win_info.
8053 <~tui_win_info>: Mark as override.
8054 <generic>: Remove member.
8055 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8056 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8057 (~tui_data_window, ~tui_win_info)
8058 (tui_free_all_source_wins_content): Update.
8059 * tui/tui-command.c (tui_refresh_cmd_win): Update.
8060
8061 2019-06-25 Tom Tromey <tom@tromey.com>
8062
8063 * tui/tui-layout.c (init_and_make_win): Use new.
8064 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8065 destructor, initializers.
8066 (tui_alloc_generic_win_info): Don't declare.
8067 * tui/tui-data.c (_locator): Add argument to constructor.
8068 (source_win, disasm_win): New globals.
8069 (exec_info): Remove.
8070 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8071 Update.
8072 (tui_alloc_generic_win_info): Remove.
8073 (init_content_element): Use new.
8074 (tui_win_info::tui_win_info): Update.
8075 (free_content_elements) <case DATA_WIN>: Use delete.
8076
8077 2019-06-25 Tom Tromey <tom@tromey.com>
8078
8079 * tui/tui-wingeneral.c (tui_refresh_win): Update.
8080 * tui/tui-windata.c (tui_first_data_item_displayed)
8081 (tui_delete_data_content_windows): Update.
8082 * tui/tui-win.c (tui_data_window::set_new_height): Update.
8083 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8084 (tui_display_registers_from, tui_check_register_values): Update.
8085 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8086 pointer.
8087 * tui/tui-data.c (init_content_element): Update. Allocate the new
8088 window.
8089 (tui_free_data_content): Update.
8090 (free_content_elements) <case DATA_WIN>: Free the window.
8091
8092 2019-06-25 Tom Tromey <tom@tromey.com>
8093
8094 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8095 Update.
8096 * tui/tui-layout.c (make_command_window)
8097 (show_source_disasm_command, show_data, init_and_make_win)
8098 (show_source_or_disasm_and_command): Update.
8099 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8100 method.
8101 <can_highight, is_highlighted>: Now bool.
8102 (tui_set_win_highlight): Don't declare.
8103 * tui/tui-data.c (tui_set_win_highlight): Remove.
8104
8105 2019-06-25 Tom Tromey <tom@tromey.com>
8106
8107 * tui/tui-wingeneral.c (make_visible): Remove check of window
8108 type.
8109
8110 2019-06-25 Tom Tromey <tom@tromey.com>
8111
8112 * tui/tui-win.c (tui_win_info::max_height)
8113 (tui_cmd_window::max_height): New methods.
8114 (new_height_ok): Call max_height.
8115 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8116 <max_height>: New method.
8117
8118 2019-06-25 Tom Tromey <tom@tromey.com>
8119
8120 * tui/tui-win.c (tui_source_window_base::set_new_height)
8121 (tui_data_window::set_new_height): New methods.
8122 (make_invisible_and_set_new_height): Call set_new_height method.
8123 * tui/tui-data.h (struct tui_win_info)
8124 (struct tui_source_window_base, struct tui_data_window)
8125 <set_new_height>: New method.
8126
8127 2019-06-25 Tom Tromey <tom@tromey.com>
8128
8129 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8130 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8131 tui_refresh_data_win.
8132 * tui/tui-win.c (tui_source_window_base::refresh_all): New
8133 method.
8134 (tui_refresh_all_win): Call the refresh_all method.
8135 (tui_set_focus): Likewise.
8136 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8137 (struct tui_source_window_base, struct tui_data_window) <refresh>:
8138 Likewise.
8139
8140 2019-06-25 Tom Tromey <tom@tromey.com>
8141
8142 * tui/tui-winsource.h (tui_refill_source_window)
8143 (tui_set_is_exec_point_at): Don't declare.
8144 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8145 (tui_source_window_base::refill): Rename from
8146 tui_refill_source_window.
8147 (tui_source_window_base::do_scroll_horizontal): Update.
8148 (tui_source_window_base::set_is_exec_point_at): Rename from
8149 tui_set_is_exec_point_at.
8150 (tui_update_all_breakpoint_info): Update.
8151 * tui/tui-stack.c (tui_show_frame_info): Update.
8152 * tui/tui-layout.c (show_data): Add cast.
8153 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8154 * tui/tui-data.h (struct tui_source_window_base) <refill,
8155 set_is_exec_point_at>: New methods.
8156 (tui_source_windows, tui_add_to_source_windows): Update types.
8157 (tui_add_to_source_windows): Remove redundant declaration.
8158 * tui/tui-data.c (source_windows): Store tui_source_window_base.
8159 (tui_source_windows): Change return type.
8160 (tui_clear_source_windows_detail): Update.
8161 (tui_add_to_source_windows): Change type of parameter.
8162 (tui_free_all_source_wins_content): Update.
8163
8164 2019-06-25 Tom Tromey <tom@tromey.com>
8165
8166 * tui/tui-wingeneral.c (tui_win_info::refresh)
8167 (tui_source_window_base::refresh): New methods.
8168 (tui_refresh_all): Call the refresh method.
8169 * tui/tui-data.h (struct tui_win_info)
8170 (struct tui_source_window_base) <refresh>: New method.
8171
8172 2019-06-25 Tom Tromey <tom@tromey.com>
8173
8174 * tui/tui.h (tui_is_window_visible): Return bool.
8175 * tui/tui.c (tui_is_window_visible): Return bool.
8176 * tui/tui-wingeneral.c (tui_make_window, make_visible)
8177 (tui_make_visible, tui_make_invisible)
8178 (tui_win_info::make_visible)
8179 (tui_source_window_base::make_visible, make_all_visible)
8180 (tui_make_all_visible, tui_make_all_invisible): Update.
8181 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8182 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8183 bool.
8184 (struct tui_win_info, struct tui_source_window_base)
8185 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8186 * tui/tui-data.c (tui_init_generic_part): Update.
8187
8188 2019-06-25 Tom Tromey <tom@tromey.com>
8189
8190 * tui/tui-wingeneral.c (tui_win_info::make_visible)
8191 (tui_source_window_base::make_visible): New methods.
8192 (make_all_visible): Make method call.
8193 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8194 (struct tui_source_window_base, struct tui_cmd_window): Override
8195 make_visible.
8196 (tui_win_is_source_type): Don't declare.
8197 * tui/tui-data.c (tui_win_is_source_type): Remove.
8198
8199 2019-06-25 Tom Tromey <tom@tromey.com>
8200
8201 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8202 NULL check.
8203
8204 2019-06-25 Tom Tromey <tom@tromey.com>
8205
8206 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8207 Inline constructor. Add initializers for members.
8208 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8209 constructors; now inline in class.
8210
8211 2019-06-25 Tom Tromey <tom@tromey.com>
8212
8213 * tui/tui-regs.c (tui_show_registers): Update.
8214 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8215 bool.
8216 * tui/tui-data.c (tui_data_window::clear_detail)
8217 (tui_data_window): Update.
8218
8219 2019-06-25 Tom Tromey <tom@tromey.com>
8220
8221 * tui/tui-windata.c (tui_display_all_data)
8222 (tui_display_data_from_line, tui_display_data_from)
8223 (tui_check_data_values, tui_data_window::do_scroll_vertical):
8224 Update.
8225 * tui/tui-regs.c (tui_last_regs_line_no)
8226 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8227 (tui_show_registers, tui_show_register_group)
8228 (tui_display_registers_from, tui_display_reg_element_at_line)
8229 (tui_display_registers_from_line, tui_check_register_values)
8230 (tui_reg_next, tui_reg_prev): Update.
8231 * tui/tui-layout.c (tui_set_layout, show_data): Update.
8232 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
8233 tui_data_window.
8234 (struct tui_win_info) <detail>: Remove. Add new fields from
8235 tui_data_info.
8236 (TUI_DATA_WIN): Add cast.
8237 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8238 (~tui_data_window): Simplify.
8239
8240 2019-06-25 Tom Tromey <tom@tromey.com>
8241
8242 * tui/tui-layout.c (show_source_disasm_command)
8243 (show_source_or_disasm_and_command): Update.
8244 * tui/tui-io.c (update_cmdwin_start_line)
8245 (tui_redisplay_readline): Update.
8246 * tui/tui-data.h (struct tui_command_info): Remove.
8247 (struct tui_win_info) <detail>: Remove command_info member.
8248 (struct tui_data_window) <start_line>: New member, from
8249 tui_command_info.
8250 (TUI_CMD_WIN): Add casts.
8251
8252 2019-06-25 Tom Tromey <tom@tromey.com>
8253
8254 * tui/tui-winsource.c (tui_update_source_window)
8255 (tui_refill_source_window)
8256 (tui_source_window_base::do_scroll_horizontal)
8257 (tui_update_breakpoint_info, tui_set_exec_info_content)
8258 (tui_show_exec_info_content, tui_erase_exec_info_content)
8259 (tui_clear_exec_info_content): Update.
8260 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8261 Update.
8262 * tui/tui-win.c (make_invisible_and_set_new_height)
8263 (make_visible_with_new_height): Update.
8264 * tui/tui-source.c (tui_set_source_content)
8265 (tui_show_symtab_source): Update.
8266 * tui/tui-layout.c (extract_display_start_addr)
8267 (show_source_disasm_command, show_data)
8268 (make_source_or_disasm_window)
8269 (show_source_or_disasm_and_command): Update.
8270 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
8271 (tui_disasm_window::do_scroll_vertical): Remove shadowing
8272 "gdbarch".
8273 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
8274 to tui_source_window_base.
8275 (struct tui_win_info) <detail>: Remove source_info member.
8276 (struct tui_source_window_base) <has_locator>: Inline.
8277 Move contents from tui_source_info; rename has_locator member to
8278 m_has_locator.
8279 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
8280 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
8281 header file.
8282 (tui_source_window_base::clear_detail, ~tui_source_window_base):
8283 Simplify.
8284 (tui_free_all_source_wins_content): Cast to
8285 tui_source_window_base.
8286
8287 2019-06-25 Tom Tromey <tom@tromey.com>
8288
8289 * tui/tui-win.c (make_invisible_and_set_new_height)
8290 (make_visible_with_new_height): Call has_locator method.
8291 * tui/tui-layout.c (show_source_disasm_command, show_data)
8292 (show_source_or_disasm_and_command): Update for bool change.
8293 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
8294 (tui_win_info) <has_locator>: New method.
8295 (struct tui_source_window_base) <has_locator>: New method.
8296 (tui_win_has_locator): Don't declare.
8297 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
8298 from tui_win_has_locator.
8299 (tui_source_window_base): Use false, not FALSE.
8300
8301 2019-06-25 Tom Tromey <tom@tromey.com>
8302
8303 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
8304 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
8305 clear_detail method directly.
8306 (tui_clear_win_detail): Remove.
8307
8308 2019-06-25 Tom Tromey <tom@tromey.com>
8309
8310 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
8311 "this", not TUI_DISASM_WIN.
8312
8313 2019-06-25 Tom Tromey <tom@tromey.com>
8314
8315 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
8316 declare.
8317 * tui/tui-winsource.c
8318 (tui_source_window_base::do_scroll_horizontal): Rename from
8319 tui_horizontal_source_scroll.
8320 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
8321 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
8322 from tui_vertical_data_scroll.
8323 * tui/tui-win.h (tui_scroll): Don't declare.
8324 * tui/tui-win.c (tui_win_info::forward_scroll)
8325 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8326 (tui_win_info::right_scroll): Rename and update.
8327 (tui_scroll_forward_command, tui_scroll_backward_command)
8328 (tui_scroll_left_command, tui_scroll_right_command): Update.
8329 (tui_scroll): Remove.
8330 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
8331 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
8332 from tui_vertical_source_scroll.
8333 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
8334 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
8335 from tui_vertical_disassem_scroll.
8336 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
8337 do_scroll_horizontal>: New methods.
8338 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
8339 Likewise.
8340 (struct tui_source_window_base): Add do_scroll_horizontal.
8341 (struct tui_source_window, struct tui_disasm_window): Add
8342 do_scroll_vertical.
8343 (struct tui_data_window, struct tui_cmd_window): Add
8344 do_scroll_horizontal and do_scroll_vertical.
8345 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
8346
8347 2019-06-25 Tom Tromey <tom@tromey.com>
8348
8349 * tui/tui-data.h (struct tui_source_window_base): New struct.
8350 (struct tui_source_window): Derive from tui_source_window_base.
8351 (struct tui_disasm_window): New struct.
8352 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
8353 from tui_source_window::clear_detail.
8354 (tui_source_window_base): Rename from tui_source_window.
8355 (~tui_source_window_base): Rename from ~tui_source_window.
8356 (tui_alloc_win_info): Create a tui_disasm_window.
8357
8358 2019-06-25 Tom Tromey <tom@tromey.com>
8359
8360 * tui/tui-data.h (struct tui_source_window)
8361 (struct tui_data_window): Declare destructors.
8362 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
8363 destructors.
8364 (tui_win_info): Simplify.
8365
8366 2019-06-25 Tom Tromey <tom@tromey.com>
8367
8368 * tui/tui-winsource.c (tui_display_main)
8369 (tui_update_source_windows_with_addr)
8370 (tui_update_all_breakpoint_info): Update.
8371 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8372 (new_height_ok, parse_scrolling_args): Update.
8373 * tui/tui-stack.c (tui_show_frame_info): Update.
8374 * tui/tui-data.h (struct tui_list): Remove.
8375 (tui_source_windows): Return a reference to a std::vector.
8376 * tui/tui-data.c (source_windows): Now a std::vector.
8377 (tui_source_windows): Change return type.
8378 (tui_clear_source_windows): Rewrite.
8379 (tui_clear_source_windows_detail, tui_add_to_source_windows)
8380 (tui_free_all_source_wins_content): Rewrite.
8381
8382 2019-06-25 Tom Tromey <tom@tromey.com>
8383
8384 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
8385 (struct tui_data_window, struct tui_cmd_window): Declare
8386 clear_detail method.
8387 * tui/tui-data.c (tui_source_window::clear_detail)
8388 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
8389 methods.
8390 (tui_clear_win_detail): Simplify.
8391
8392 2019-06-25 Tom Tromey <tom@tromey.com>
8393
8394 * tui/tui-layout.c (make_source_window, make_disasm_window)
8395 (make_source_or_disasm_window): Remove win_info_ptr parameter.
8396 Return the new window.
8397 (show_source_disasm_command, show_data)
8398 (show_source_or_disasm_and_command): Update.
8399
8400 2019-06-25 Tom Tromey <tom@tromey.com>
8401
8402 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
8403 parameter. Return the new window.
8404 (show_source_disasm_command): Update and remove NULL check.
8405 (show_source_or_disasm_and_command): Update.
8406
8407 2019-06-25 Tom Tromey <tom@tromey.com>
8408
8409 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
8410
8411 2019-06-25 Tom Tromey <tom@tromey.com>
8412
8413 * tui/tui-data.h (struct tui_win_info): Make constructor
8414 protected. Make destructor virtual. Add initializers.
8415 (tui_source_window, tui_data_window, tui_cmd_window): New
8416 classes.
8417 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
8418 constructor. Add "type" parameter.
8419 (tui_source_window, tui_data_window, tui_cmd_window): New
8420 constructors.
8421 (tui_alloc_win_info): Instantiate the appropriate subclass.
8422
8423 2019-06-25 Tom Tromey <tom@tromey.com>
8424
8425 * tui/tui-win.c (tui_resize_all): Use delete.
8426 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
8427 destructor.
8428 (tui_free_window): Don't declare.
8429 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
8430 Update.
8431
8432 2019-06-25 Tom Tromey <tom@tromey.com>
8433
8434 * tui/tui-data.h (struct tui_win_info): Add constructor.
8435 * tui/tui-data.c (tui_alloc_win_info): Use new.
8436 (tui_free_window): Use delete.
8437
8438 2019-06-22 Tom Tromey <tom@tromey.com>
8439
8440 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
8441 declare.
8442 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
8443
8444 2019-06-22 Tom Tromey <tom@tromey.com>
8445
8446 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
8447 declare.
8448 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
8449
8450 2019-06-22 Tom de Vries <tdevries@suse.de>
8451
8452 * dwarf2read.c (create_addrmap_from_aranges)
8453 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
8454 instead of '%zu'.
8455
8456 2019-06-21 Simon Marchi <simon.marchi@efficios.com>
8457
8458 * dwarf2read.h (dwarf2_section_info_def): Remove.
8459 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
8460 * dwarf2read.c (struct dwo_sections) <types>: Change type to
8461 std::vector<dwarf2_section_info>.
8462 (struct dwo_file) <~dwo_file>: Remove.
8463 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
8464 types field.
8465 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
8466 (dwarf2_read_debug_names): Likewise.
8467 (create_debug_types_hash_table): Change parameter type to
8468 array_view, adjust code accordingly.
8469 (dwarf2_locate_dwo_sections): Adjust to std::vector.
8470 (partial_die_info::fixup): Likewise.
8471 (determine_prefix): Likewise.
8472 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
8473
8474 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8475
8476 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
8477 gdb_bfd_ref_ptr.
8478 <~dwo_file>: Remove call to gdb_bfd_unref.
8479 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
8480 gdb_bfd_ref_ptr::get.
8481
8482 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8483
8484 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
8485 type to htab_up.
8486 * dwarf2read.c (struct dwo_file): Initialize fields.
8487 <~dwo_file>: New.
8488 (free_dwo_file): Remove, move content to ~dwo_file.
8489 (struct dwo_file_deleter): Remove.
8490 (dwo_file_up>: Remove custom deleter.
8491 (free_dwo_files): Remove.
8492 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
8493 dwo_files.
8494 (process_skeletonless_type_units): Call unique_ptr::get.
8495 (allocate_dwo_file_hash_table): Add deleter to created hash
8496 table. Change return type to htab_up.
8497 (lookup_dwo_file_slot): Don't memset dwo_file, call
8498 unique_ptr::get.
8499 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
8500 (create_dwo_unit_in_dwp_v2): Likewise.
8501 (open_and_init_dwo_file): Likewise.
8502 (free_dwo_file_from_slot): Remove.
8503
8504 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8505
8506 * dwarf2read.h (struct dwarf2_section_info) <readin,
8507 is_virtual>: Change type to bool.
8508 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
8509 true instead of 1.
8510
8511 2019-06-19 Tom Tromey <tom@tromey.com>
8512
8513 * tui/tui-data.h (tui_init_content_element): Don't declare.
8514
8515 2019-06-19 Tom Tromey <tom@tromey.com>
8516
8517 * tui/tui-data.h (tui_init_win_info): Don't declare.
8518
8519 2019-06-19 Tom de Vries <tdevries@suse.de>
8520
8521 * dwarf2read.h (abstract_to_concrete): Change type to
8522 std::unordered_map<sect_offset, std::vector<sect_offset>,
8523 gdb::hash_enum<sect_offset>>.
8524
8525 2019-06-19 Tom Tromey <tromey@adacore.com>
8526
8527 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
8528 EVAL_AVOID_SIDE_EFFECTS specially.
8529
8530 2019-06-19 Tom Tromey <tromey@adacore.com>
8531
8532 * source-cache.c (highlighter): New global.
8533 (source_cache::get_source_lines): Create a highlighter on demand.
8534
8535 2019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
8536
8537 * defs.h (deprecated_interactive_hook): Delete declaration.
8538 * interps.c (clear_interpreter_hooks): Remove use of
8539 deprecated_interactive_hook.
8540 * top.c (deprecated_interactive_hook): Delete definition.
8541 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
8542
8543 2019-06-18 Tom de Vries <tdevries@suse.de>
8544
8545 PR gdb/24515
8546 * dwarf2read.h (abstract_to_concrete): Change type from
8547 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
8548 std::unordered_map<sect_offset, std::vector<sect_offset>>.
8549 * dwarf2read.c (read_variable): Update.
8550 (dwarf2_fetch_die_loc_sect_off): Update.
8551
8552 2019-06-17 Tom de Vries <tdevries@suse.de>
8553
8554 PR gdb/24617
8555 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
8556 accessing parent[parent_len - 1].
8557
8558 2019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
8559
8560 PR gdb/24364
8561 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
8562 call dtrace_process_dof with NULL dof.
8563
8564 2019-06-16 Tom de Vries <tdevries@suse.de>
8565
8566 PR gdb/24445
8567 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
8568
8569 2019-06-16 Tom Tromey <tom@tromey.com>
8570
8571 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8572 (make_all_visible): Use address of member.
8573
8574 2019-06-16 Tom Tromey <tom@tromey.com>
8575
8576 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
8577 (tui_free_window, free_content, free_content_elements): Remove
8578 unnecessary cast.
8579 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
8580 cast.
8581 * tui/tui-regs.c (tui_show_register_group)
8582 (tui_display_registers_from, tui_display_reg_element_at_line):
8583 Remove unnecessary cast.
8584
8585 2019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
8586
8587 * linux-nat.c (normal_mask): Delete.
8588 (_initialize_linux_nat): Don't initialise normal_mask.
8589
8590 2019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
8591
8592 PR gdb/24445
8593 * dwarf-index-write.h (write_psymtabs_to_index): Add
8594 dwz_basename parameter.
8595 * dwarf-index-write.c (write_gdbindex): Move file writing to
8596 write_gdbindex_1. Change return type void.
8597 (assert_file_size): Move up, remove filename parameter.
8598 (write_gdbindex_1): New function.
8599 (write_debug_names): Change return type to void, call
8600 assert_file_size.
8601 (struct index_wip_file): New struct.
8602 (write_psymtabs_to_index): Add dwz_basename parameter. Move
8603 file logic to index_wip_file. Write index for dwz file if
8604 needed.
8605 (save_gdb_index_command): Pass basename of dwz file, if present.
8606 * dwarf-index-cache.c (index_cache::store): Obtain and pass
8607 build-id of dwz file, if present.
8608 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
8609 (dwarf2_get_dwz_file): Likewise.
8610 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
8611 (dwarf2_get_dwz_file): Likewise.
8612
8613 2019-06-16 Tom Tromey <tom@tromey.com>
8614
8615 * coffread.c (process_coff_symbol): Use xstrdup.
8616 * value.c (create_internalvar): Use xstrdup.
8617
8618 2019-06-16 Tom Tromey <tom@tromey.com>
8619
8620 * valops.c (value_cast, value_slice): Remove unnecessary cast.
8621 * breakpoint.c (stopin_command, stopat_command)
8622 (until_break_command, decode_location_default): Remove unnecessary
8623 cast.
8624 * utils.c (subset_compare): Remove unnecessary cast.
8625 * ada-lang.c (ada_update_initial_language): Remove unnecessary
8626 cast.
8627 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
8628 cast.
8629 * infcmd.c (path_command): Remove unnecessary cast.
8630 * coffread.c (decode_type): Remove unnecessary cast.
8631 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
8632 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
8633 * tui/tui-stack.c (tui_show_locator_content)
8634 (tui_show_frame_info): Remove unnecessary cast.
8635 * tui/tui-win.c (tui_scroll_forward_command)
8636 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
8637 (parse_scrolling_args): Remove unnecessary cast.
8638 * tui/tui-data.c (init_win_info, tui_del_window)
8639 (tui_free_window, tui_del_data_windows, tui_free_data_content)
8640 (free_content_elements): Remove unnecessary cast.
8641 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
8642 unnecessary cast.
8643 * tui/tui-source.c (tui_set_source_content)
8644 (tui_vertical_source_scroll): Remove unnecessary cast.
8645 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
8646 cast.
8647 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
8648 * tui/tui-regs.c (tui_display_registers_from)
8649 (tui_display_register): Remove unnecessary cast.
8650 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
8651 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
8652 (make_visible): Remove unnecessary cast.
8653 * tui/tui-winsource.c (tui_erase_source_content)
8654 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
8655 unnecessary cast.
8656 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
8657 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
8658 * stabsread.c (read_type, read_array_type, read_range_type):
8659 Remove unnecessary cast.
8660 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
8661 (parse_symbol, parse_type, upgrade_type, parse_external)
8662 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
8663 unnecessary cast.
8664 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
8665
8666 2019-06-16 Tom Tromey <tom@tromey.com>
8667
8668 * tui/tui-data.c (tui_alloc_generic_win_info)
8669 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
8670 checks.
8671
8672 2019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
8673 Andrew Burgess <andrew.burgess@embecosm.com>
8674
8675 * f-typeprint.c (f_print_type): Don't return early for not
8676 associated or not allocated types.
8677 (f_type_print_varspec_suffix): Add print_rank parameter and print
8678 ranks of array types in case they dangling.
8679 (f_type_print_base): Add print_rank parameter.
8680
8681 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8682
8683 * NEWS: Mention new MI commands.
8684 * break-catch-throw.c (enum exception_event_kind): Move to
8685 breakpoint.h.
8686 (print_mention_exception_catchpoint): Output text as a single
8687 message.
8688 (catch_exception_command_1): Rename to...
8689 (catch_exception_event): ...this, make non-static, update header
8690 command, and change some parameter types.
8691 (catch_catch_command): Update for changes to
8692 catch_exception_command_1.
8693 (catch_throw_command): Likewise.
8694 (catch_rethrow_command): Likewise.
8695 * breakpoint.c (enum exception_event_kind): Delete.
8696 * breakpoint.h (enum exception_event_kind): Moved here from
8697 break-catch-throw.c.
8698 (catch_exception_event): Declare.
8699 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
8700 (mi_cmd_catch_throw): New function.
8701 (mi_cmd_catch_rethrow): New function.
8702 (mi_cmd_catch_catch): New function.
8703 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
8704 'catch-catch' entries.
8705 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
8706 (mi_cmd_catch_rethrow): Declare.
8707 (mi_cmd_catch_catch): Declare.
8708
8709 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8710
8711 * annotate.c (annotate_source_line): Change return type to void,
8712 update implementation to match.
8713 * annotate.h (annotate_source_line): Change return type to void,
8714 update header comment.
8715 * stack.c (print_frame_info): Don't change what frame information
8716 is printed based on whether annotations are on or not.
8717
8718 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8719
8720 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
8721 (annotate_source): Make static.
8722 (annotate_source_line): Moved from source.c and renamed from
8723 identify_source_line. Update the return type.
8724 * annotate.h (annotate_source): Delete declaration.
8725 (annotate_source_line): Declaration moved from source.h, and
8726 renamed from identify_source_line. Return type updated.
8727 * source.c (identify_source_line): Moved to annotate.c and renamed
8728 to annotate_source_line.
8729 (info_line_command): Remove check of annotation_level.
8730 * source.h (identify_source_line): Move declaration to annotate.h
8731 and rename to annotate_source_line.
8732 * stack.c: Add 'annotate.h' include.
8733 (print_frame_info): Remove check of annotation_level before
8734 calling annotate_source_line.
8735
8736 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8737
8738 * source-cache.c (source_cache::get_plain_source_lines): Use
8739 open_source_file_with_line_charpos instead of just
8740 open_source_file, remove call to find_source_lines.
8741 (source_cache::get_source_lines): Likewise.
8742 * source.c (find_source_lines): Make static.
8743 (get_filename_and_charpos): Renamed into...
8744 (open_source_file_with_line_charpos): ..this along with changes to
8745 return a scoped_fd, and some other minor clean ups.
8746 (identify_source_line): Use open_source_file_with_line_charpos.
8747 (search_command_helper): Use open_source_file_with_line_charpos
8748 instead of just open_source_file, remove call to
8749 find_source_lines.
8750 * source.h (open_source_file_with_line_charpos): Declare new
8751 function.
8752 (find_source_lines): Delete declaration.
8753
8754 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8755
8756 * source.c (get_filename_and_charpos): Remove fullname
8757 parameter.
8758 (identify_source_line): Update call to get_filename_and_charpos.
8759
8760 2019-06-14 Tom Tromey <tromey@adacore.com>
8761
8762 PR gdb/24502:
8763 * ui-style.h (skip_ansi_escape): Update comment.
8764 * ui-file.h (class no_terminal_escape_file): New class.
8765 * ui-file.c (no_terminal_escape_file::write)
8766 (no_terminal_escape_file::puts): New methods.
8767 * cli/cli-logging.c (handle_redirections): Use
8768 no_terminal_escape_file.
8769
8770 2019-06-14 Tom Tromey <tromey@adacore.com>
8771
8772 * NEWS: Move convenience variable news above Python news.
8773
8774 2019-06-14 Tom Tromey <tom@tromey.com>
8775
8776 * gnulib: Move directory to top-level.
8777 * configure.ac: Don't configure gnulib.
8778 * configure: Rebuild.
8779 * common/common-defs.h: Use new path to gnulib.
8780 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
8781 (GNULIB_H): Remove.
8782 (INCGNU): Look in new gnulib location.
8783 (HFILES_NO_SRCDIR): Remove gnulib files.
8784 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
8785 (generated_files): Remove GNULIB_H.
8786 ($(LIBGNU), all-lib): Remove targets.
8787 (distclean): Don't mention GNULIB_BUILDDIR.
8788 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
8789
8790 2019-06-14 Tom Tromey <tromey@adacore.com>
8791
8792 * symfile.c (add_symbol_file_command): Remove obsolete comment.
8793 Warn if symbol file does not provide any symbols.
8794
8795 2019-06-14 Tom Tromey <tromey@adacore.com>
8796
8797 * source.c (find_and_open_source): Respect basenames_may_differ.
8798
8799 2019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
8800
8801 * annotate.c (annotate_breakpoints_invalid): Make use of
8802 scoped_restore_terminal_state.
8803 (annotate_frames_invalid): Likewise.
8804
8805 2019-06-14 Tom Tromey <tromey@adacore.com>
8806
8807 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
8808 allow assignment to an internalvar.
8809
8810 2019-06-14 Tom Tromey <tromey@adacore.com>
8811
8812 * ada-lex.l: Allow "_" in attribute names.
8813
8814 2019-06-14 Tom Tromey <tromey@adacore.com>
8815
8816 PR gdb/24653:
8817 * regcache.c (registers_changed): Don't call alloca.
8818 * top.c (execute_command): Don't call alloca.
8819
8820 2019-06-13 Pedro Alves <palves@redhat.com>
8821
8822 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
8823 'expression'. When parsing an expression, error out if there's
8824 junk after "unlimited".
8825 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8826 (do_set_command): Adjust calls to is_unlimited_literal.
8827
8828 2019-06-13 Pedro Alves <palves@redhat.com>
8829
8830 * compile/compile.c (make_compile_options_def_group): Add braces
8831 around array_view initializer.
8832 * thread.c (make_thread_apply_all_options_def_group)
8833 (make_thread_apply_all_options_def_group): Likewise.
8834
8835 2019-06-13 Pedro Alves <palves@redhat.com>
8836
8837 * NEWS (New commands): Mention "maint test-options
8838 require-delimiter", "maint test-options unknown-is-error", "maint
8839 test-options unknown-is-operand" and "maint show
8840 test-options-completion-result".
8841 (New command options, command completion): New section.
8842 (Completion improvements): New section.
8843 Mention that you can abbreviate "unlimited".
8844
8845 2019-06-13 Pedro Alves <palves@redhat.com>
8846
8847 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
8848 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
8849 * unittests/cli-utils-selftests.c (test_parse_flags)
8850 (test_parse_flags_qcs): Delete.
8851 (test_cli_utils): Don't call deleted functions.
8852
8853 2019-06-13 Pedro Alves <palves@redhat.com>
8854
8855 * thread.c: Include "cli/cli-option.h".
8856 (tp_array_compar_ascending): Global.
8857 (tp_array_compar): Delete function.
8858 (tp_array_compar_ascending, tp_array_compar_descending): New
8859 functions.
8860 (ascending_option_def, qcs_flag_option_def)
8861 (thr_qcs_flags_option_defs)
8862 (make_thread_apply_all_options_def_group)
8863 (make_thread_apply_options_def_group): New.
8864 (thread_apply_all_command): Use gdb::option::process_options.
8865 (thread_apply_command_completer)
8866 (thread_apply_all_command_completer): New.
8867 (thread_apply_command): Use gdb::option::process_options.
8868 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
8869 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
8870 to generate help text of "thread apply". Adjust "taas"'s help.
8871 * tid-parse.c (tid_range_parser::in_thread_range): New method.
8872 * tid-parse.h (tid_range_parser::in_thread_range): New method.
8873
8874 2019-06-13 Pedro Alves <palves@redhat.com>
8875
8876 * thread.c (thread_apply_command): Check for invalid TID with
8877 isdigit instead of !isalpha.
8878
8879 2019-06-13 Pedro Alves <palves@redhat.com>
8880
8881 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
8882 (validate_flags_qcs): New.
8883 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
8884 (validate_flags_qcs): Declare.
8885 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
8886 (make_frame_apply_options_def_group): New.
8887 (frame_apply_command_count): Process options with
8888 gdb::option::process_options.
8889 (frame_apply_completer): New.
8890 (frame_apply_level_completer, frame_apply_all_completer)
8891 (frame_apply_completer): New.
8892 (_initialize_stack): Update help of "frame apply", "frame apply
8893 level", "frame apply all" and "faas" to mention supported options
8894 and install command completers.
8895 * stack.h (frame_apply_all_completer): Declare.
8896 * thread.c: Include "stack.h".
8897 (tfaas_command): Add "--".
8898 (_initialize_thread): Update help "tfaas" to mention supported
8899 options and install command completer.
8900
8901 2019-06-13 Pedro Alves <palves@redhat.com>
8902
8903 * completer.c (complete_nested_command_line): New.
8904 (gdb_completion_word_break_characters_throw): Add assertion.
8905 * completer.h (complete_nested_command_line): Declare.
8906
8907 2019-06-13 Pedro Alves <palves@redhat.com>
8908
8909 * stack.c (parse_backtrace_qualifiers): New.
8910 (backtrace_command): Use it.
8911 (backtrace_command_completer): Complete on qualifiers.
8912
8913 2019-06-13 Pedro Alves <palves@redhat.com>
8914
8915 * frame.c: Include "cli/cli-option.h.
8916 (user_set_backtrace_options): New.
8917 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
8918 Delete.
8919 (get_prev_frame): Adjust.
8920 (boolean_option_def, uinteger_option_def)
8921 (set_backtrace_option_defs): New.
8922 (_initialize_frame): Adjust and use
8923 gdb::option::add_setshow_cmds_for_options to install "set
8924 backtrace past-main" and "set backtrace past-entry".
8925 * frame.h: Include "cli/cli-option.h".
8926 (struct frame_print_options): Forward declare.
8927 (print_frame_arguments_all, print_frame_arguments_scalars)
8928 (print_frame_arguments_none): Declare.
8929 (print_entry_values): Delete declaration.
8930 (struct frame_print_options, user_frame_print_options): New.
8931 (struct set_backtrace_options): New.
8932 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
8933 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
8934 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
8935 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
8936 (list_args_or_locals): Add frame_print_options parameter.
8937 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
8938 * python/py-framefilter.c (enumerate_args): Pass down
8939 USER_FRAME_PRINT_OPTIONS.
8940 * stack.c: Include "cli/cli-option.h".
8941 (print_frame_arguments_all, print_frame_arguments_scalars)
8942 (print_frame_arguments_none): Declare.
8943 (print_raw_frame_arguments, print_entry_values): Delete.
8944 (user_frame_print_options): New.
8945 (boolean_option_def, enum_option_def, frame_print_option_defs):
8946 New.
8947 (struct backtrace_cmd_options): New.
8948 (bt_flag_option_def): New.
8949 (backtrace_command_option_defs): New.
8950 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
8951 (print_frame_arg, read_frame_arg, print_frame_args)
8952 (print_frame_info, print_frame): Add frame_print_options parameter
8953 and use it.
8954 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
8955 (backtrace_command_1): Add frame_print_options and
8956 backtrace_cmd_options parameters and use them.
8957 (make_backtrace_options_def_group): New.
8958 (backtrace_command): Process command options with
8959 gdb::option::process_options.
8960 (backtrace_command_completer): New.
8961 (_initialize_stack): Extend "backtrace"'s help to mention
8962 supported options. Install completer for "backtrace".
8963 Install some settings commands with add_setshow_cmds_for_options.
8964
8965 2019-06-13 Pedro Alves <palves@redhat.com>
8966
8967 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
8968 and that "set/show print raw frame-arguments" are now deprecated.
8969
8970 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
8971 command.
8972 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
8973 * stack.c (_initialize_stack): Install "set/show print
8974 raw-frame-arguments", and deprecate "set/show print raw
8975 frame-arguments".
8976 * valprint.c (_initialize_valprint): Deprecate "set/show print
8977 raw".
8978
8979 2019-06-13 Pedro Alves <palves@redhat.com>
8980
8981 * compile/compile.c (struct compile_options): New.
8982 (compile_flag_option_def, compile_command_option_defs)
8983 (make_compile_options_def_group): New.
8984 (compile_file_command): Handle options with
8985 gdb::option::process_options.
8986 (compile_file_command_completer): New function.
8987 (compile_code_command): Handle options with
8988 gdb::option::process_options.
8989 (compile_code_command_completer): New function.
8990 (_initialize_compiler): Install completers for "compile code" and
8991 "compile file". Mention available options in "compile code" and
8992 "compile code"'s help.
8993 * completer.c (advance_to_completion_word): New, factored out from
8994 ...
8995 (advance_to_expression_complete_word_point): ... this.
8996 (advance_to_filename_complete_word_point): New.
8997 * completer.h (advance_to_filename_complete_word_point): New
8998 declaration.
8999
9000 2019-06-13 Pedro Alves <palves@redhat.com>
9001
9002 * compile/compile.c: Include "cli/cli-option.h".
9003 (compile_print_value): Scope data pointer is now a
9004 value_print_options pointer; adjust.
9005 (compile_print_command): Process options. Scope data pointer is
9006 now a value_print_options pointer; adjust.
9007 (_initialize_compile): Update "compile print"'s help to include
9008 supported options. Install a completer for "compile print".
9009 * cp-valprint.c (show_vtblprint, show_objectprint)
9010 (show_static_field_print): Delete.
9011 (_initialize_cp_valprint): Don't install "set print
9012 static-members", "set print vtbl", "set print object" here.
9013 * printcmd.c: Include "cli/cli-option.h" and
9014 "common/gdb_optional.h".
9015 (print_command_parse_format): Rework to fill in a
9016 value_print_options instead of a format_data.
9017 (print_value): Change parameter type from format_data pointer to
9018 value_print_options reference. Adjust.
9019 (print_command_1): Process options. Adjust to pass down a
9020 value_print_options.
9021 (print_command_completer): New.
9022 (_initialize_printcmd): Install print_command_completer as
9023 handle_brkchars completer for the "print" command. Update
9024 "print"'s help to include supported options.
9025 * valprint.c: Include "cli/cli-option.h".
9026 (show_vtblprint, show_objectprint, show_static_field_print): Moved
9027 here from cp-valprint.c.
9028 (boolean_option_def, uinteger_option_def)
9029 (value_print_option_defs, make_value_print_options_def_group):
9030 New. Use gdb::option::add_setshow_cmds_for_options to install
9031 "set print elements", "set print null-stop", "set print repeats",
9032 "set print pretty", "set print union", "set print array", "set
9033 print address", "set print symbol", "set print array-indexes".
9034 * valprint.h: Include <string> and "cli/cli-option.h".
9035 (make_value_print_options_def_group): Declare.
9036 (print_value): Change parameter type from format_data pointer to
9037 value_print_options reference.
9038 (print_command_completer): Declare.
9039
9040 2019-06-13 Pedro Alves <palves@redhat.com>
9041
9042 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9043 (COMMON_SFILES): Add maint-test-settings.c.
9044 * cli/cli-decode.c (boolean_enums): New global, factored out from
9045 ...
9046 (add_setshow_boolean_cmd): ... here.
9047 * cli/cli-decode.h (boolean_enums): Declare.
9048 * cli/cli-option.c: New file.
9049 * cli/cli-option.h: New file.
9050 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9051 factored out from ...
9052 (parse_cli_boolean_value(const char *)): ... this.
9053 (is_unlimited_literal): Change parameter type to pointer to
9054 pointer. Adjust and advance ARG pointer.
9055 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9056 (parse_cli_var_enum): New, factored out from ...
9057 (do_set_command): ... this. Adjust.
9058 * cli/cli-setshow.h (parse_cli_boolean_value)
9059 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9060 (parse_cli_var_enum): Declare.
9061 * cli/cli-utils.c: Include "cli/cli-option.h".
9062 (get_ulongest): New.
9063 * cli/cli-utils.h (get_ulongest): Declare.
9064 (check_for_argument): New overloads.
9065 * maint-test-options.c: New file.
9066
9067 2019-06-13 Pedro Alves <palves@redhat.com>
9068
9069 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9070 parse a range if "-" is at the end of the string.
9071
9072 2019-06-13 Pedro Alves <palves@redhat.com>
9073
9074 * cli/cli-setshow.c (parse_auto_binary_operation)
9075 (parse_cli_boolean_value): Don't allow "o".
9076
9077 2019-06-13 Pedro Alves <palves@redhat.com>
9078
9079 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9080 * NEWS: Mention maint test-settings KIND.
9081 * maint-test-settings.c: New file.
9082
9083 2019-06-13 Pedro Alves <palves@redhat.com>
9084
9085 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9086 completer.
9087 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9088 "set" completers.
9089
9090 2019-06-13 Pedro Alves <palves@redhat.com>
9091
9092 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9093 after item.
9094
9095 2019-06-13 Pedro Alves <palves@redhat.com>
9096
9097 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9098
9099 2019-06-13 Pedro Alves <palves@redhat.com>
9100
9101 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9102 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9103 call.
9104 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9105 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9106 calls.
9107 (check_for_argument): Skip spaces after argument.
9108
9109 2019-06-13 Pedro Alves <palves@redhat.com>
9110
9111 * thread.c (thread_apply_command): Adjust TID parsing.
9112 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9113 detected before end of string.
9114 (tid_is_in_list): Error out if LIST is invalid.
9115
9116 2019-06-13 Pedro Alves <palves@redhat.com>
9117
9118 * completer.c (complete_line_internal_1): Rewind completion word
9119 point.
9120 (completion_tracker::advance_custom_word_point_by): Change
9121 parameter type to int.
9122 * completer.h (completion_tracker::advance_custom_word_point_by):
9123 Likewise.
9124
9125 2019-06-13 Pedro Alves <palves@redhat.com>
9126
9127 * completer.c (advance_to_completion_word): Handle delimiters.
9128
9129 2019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
9130
9131 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9132
9133 2019-06-11 Tom Tromey <tom@tromey.com>
9134
9135 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9136 (xmalloc_failed): Move to alloc.c.
9137 * alloc.c: New file.
9138 * Makefile.in (COMMON_SFILES): Add alloc.c.
9139
9140 2019-06-11 Tom Tromey <tom@tromey.com>
9141
9142 * nat/linux-waitpid.c: Don't include server.h.
9143 (linux_debug): Remove.
9144 (my_waitpid): Update.
9145
9146 2019-06-11 Tom Tromey <tromey@adacore.com>
9147
9148 * infcall.c (_initialize_infcall): Remove trailing newline from
9149 help.
9150 * user-regs.c (_initialize_user_regs): Remove trailing newline
9151 from help.
9152 * typeprint.c (_initialize_typeprint): Remove trailing newline
9153 from help.
9154 * reverse.c (_initialize_reverse): Remove trailing newlines from
9155 help.
9156 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9157 from help.
9158 * language.c (add_set_language_command): Remove trailing newline
9159 from help.
9160 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9161 help.
9162 * disasm.c (_initialize_disasm): Remove trailing newline from
9163 help.
9164 * top.c (init_main): Remove trailing newline from help.
9165 * interps.c (_initialize_interpreter): Remove trailing newline
9166 from help.
9167 * btrace.c (_initialize_btrace): Remove trailing newlines from
9168 help.
9169 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9170 from help.
9171 * python/python.c (_initialize_python): Remove trailing newline
9172 from help.
9173 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9174 help.
9175 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9176 from help. Reformat some text.
9177 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9178 from help.
9179 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9180 newline from help.
9181
9182 2019-06-11 Tom Tromey <tromey@adacore.com>
9183
9184 * darwin-nat.c (darwin_decode_exception_message)
9185 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9186
9187 2019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
9188
9189 * valops.c (value_slice): Check for not allocated or not
9190 associated values.
9191
9192 2019-06-10 Tom de Vries <tdevries@suse.de>
9193
9194 PR gdb/24618
9195 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9196 sure an empty slot (defined by a 32-bit zero pair) is recognized as
9197 invalid.
9198
9199 2019-06-10 Tom de Vries <tdevries@suse.de>
9200
9201 PR gdb/24611
9202 * linespec.c (linespec_lexer_lex_string): Remove incorrect
9203 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
9204
9205 2019-06-10 Tom de Vries <tdevries@suse.de>
9206
9207 PR symtab/24545
9208 * symtab.c (struct demangled_name_entry): Add language field.
9209 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
9210 static minimal symbol". Set and use language field.
9211
9212 2019-06-10 Tom Tromey <tromey@adacore.com>
9213
9214 * ada-lang.c (_initialize_ada_language): Update help text.
9215
9216 2019-06-10 Tom Tromey <tromey@adacore.com>
9217
9218 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9219 with a newline.
9220 * guile/guile.c (handle_boot_error): Don't end warning with a
9221 newline.
9222 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9223 warning with a newline.
9224 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9225 newline.
9226 (s12z_frame_cache): Likewise.
9227 * dwarf-index-cache.c (index_cache::store): Don't end warning with
9228 a newline.
9229 * solib-svr4.c (disable_probes_interface): Don't end warning with
9230 a newline.
9231 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9232 newline.
9233 * python/python.c (do_finish_initialization): Don't end warning
9234 with a newline.
9235
9236 2019-06-10 Tom Tromey <tom@tromey.com>
9237
9238 * python/py-breakpoint.c (gdbpy_breakpoint_created)
9239 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9240 gdbpy_enter.
9241
9242 2019-06-10 Tom Tromey <tromey@adacore.com>
9243
9244 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9245 data.
9246 (elf_new_init): Don't call stabsread_new_init.
9247 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9248 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
9249 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9250
9251 2019-06-10 Tom de Vries <tdevries@suse.de>
9252
9253 PR symtab/16264
9254 PR symtab/24517
9255 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9256
9257 2019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
9258
9259 * source.c (find_and_open_source): Also rewrite relative file
9260 names.
9261
9262 2019-04-26 Amos Bird <amosbird@gmail.com>
9263
9264 * annotate.c (annotate_thread_exited): Add "thread-exited"
9265 annotation.
9266
9267 2019-06-06 Tom Tromey <tromey@adacore.com>
9268
9269 * maint.h (class scoped_command_stats): Use
9270 DISABLE_COPY_AND_ASSIGN.
9271 <print_time>: New method.
9272 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
9273 print_time.
9274 (scoped_command_stats::print_time): New method.
9275
9276 2019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
9277
9278 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
9279 instructions of lengths 6 or 8 bytes.
9280
9281 2019-06-04 Pedro Alves <palves@redhat.com>
9282
9283 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
9284
9285 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
9286 * breakpoint.c (condition_completer): Likewise.
9287 * cli/cli-dump.c (scan_expression): Likewise.
9288 * common/filestuff.c (mkdir_recursive): Likewise.
9289 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
9290 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
9291 (gdb_abspath): Likewise.
9292 * compile/compile-cplus-types.c
9293 (compile_cplus_instance::decl_name): Likewise.
9294 * completer.c (complete_explicit_location):
9295 (signal_completer, reg_or_group_completer_1): Likewise.
9296 * cp-support.c (cp_remove_params_if_any): Likewise.
9297 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
9298 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
9299 * infcmd.c (strip_bg_char): Likewise.
9300 * linespec.c (copy_token_string): Likewise.
9301 * mi/mi-main.c (output_cores): Likewise.
9302 * psymtab.c (psymtab_search_name):
9303 * symfile.c (test_set_ext_lang_command): Likewise.
9304 * target.c (target_fileio_read_stralloc): Likewise.
9305 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
9306 * value.c (complete_internalvar): Likewise.
9307
9308 2019-06-04 Christian Biesinger <cbiesinger@google.com>
9309
9310 Add objfile property to gdb.Type.
9311 * NEWS: Mention Python API addition.
9312 * python/py-type.c (typy_get_objfile): New method.
9313
9314 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9315
9316 * NEWS: Mention the new set|show style [title|highlight].
9317 Mention changes to "show style", "help" and "apropos".
9318
9319 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9320
9321 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
9322 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
9323 instead of print_help_for_command.
9324 (print_doc_of_command): New function.
9325 (help_list): Add 'apropos -v word' suggestion.
9326 (print_help_for_command): Style the command name using title style.
9327 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
9328 (_initialize_cli_cmds): Describe -v in apropos_command help.
9329
9330 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9331
9332 * cli/cli-style.h (cli_style_option): Add name in constructor,
9333 add m_name class member, add constructor with intensity,
9334 add name class function.
9335 (cli_style_option::add_setshow_commands): Remove name argument.
9336 (highlight_style, title_style): New styles.
9337 * cli/cli-style.c (do_show): New function that shows a style
9338 characteristic styling the style name with itself.
9339 (set_style_name): New function.
9340 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
9341 Update all callers according to the changes in cli/cli-style.h.
9342 * utils.h (fputs_highlighted): New function.
9343 * utils.c (fputs_highlighted): Likewise.
9344
9345 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9346
9347 * NEWS: Mention new pipe command and new convenience variables.
9348
9349 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9350
9351 * cli/cli-cmds.c (pipe_command): New function.
9352 (_initialize_cli_cmds): Call add_com for pipe_command.
9353 Define | as an alias for pipe.
9354 (exit_status_set_internal_vars): New function.
9355 (shell_escape): Call exit_status_set_internal_vars.
9356 cli/cli-decode.c (find_command_name_length): Recognize | as
9357 a single character command.
9358
9359 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9360
9361 * gdbcmd.h (execute_command_to_ui_file): New declaration.
9362 top.c (execute_command_to_ui_file): New function, mostly a copy
9363 of execute_command_to_string.
9364 (execute_command_to_string): Implement by calling
9365 execute_command_to_ui_file.
9366
9367 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9368
9369 * top.h (saved_command_line): Remove declaration.
9370 * top.c (previous_saved_command_line, previous_repeat_arguments):
9371 New variables.
9372 (saved_command_line): Make static, define together with other
9373 'repeat variables'.
9374 (dont_repeat): Clear repeat_arguments.
9375 (repeat_previous, get_saved_command_line, save_command_line):
9376 New functions.
9377 (gdb_init): Initialize saved_command_line
9378 and previous_saved_command_line.
9379 * main.c (captured_main_1): Remove saved_command_line initialization.
9380 * event-top.c (handle_line_of_input): Update to use
9381 the new 'repeat' related functions instead of direct access to
9382 saved_command_line.
9383 * command.h (repeat_previous, get_saved_command_line,
9384 save_command_line): New declarations.
9385 (dont_repeat): Add comment.
9386
9387 2019-05-30 Tom Tromey <tromey@adacore.com>
9388
9389 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
9390 Fix comment.
9391 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
9392
9393 2019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
9394
9395 PR cli/24587
9396 * completer.c (complete): Initialize variable word.
9397
9398 2019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
9399
9400 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9401 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
9402 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
9403 'body' is NULL to the outter 'if', protecting the '!is_define'
9404 situation as well.
9405
9406 2019-05-29 Tom Tromey <tromey@adacore.com>
9407
9408 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
9409 (dwarf_unknown): New function.
9410 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
9411 (dwarf_type_encoding_name): Use dwarf_unknown.
9412
9413 2019-05-29 Tom Tromey <tromey@adacore.com>
9414
9415 PR c++/20020:
9416 * cp-valprint.c (cp_print_value_fields): Call
9417 cp_print_static_field inside "try".
9418
9419 2019-05-29 Tom Tromey <tromey@adacore.com>
9420
9421 * inflow.c (struct terminal_info): Add default operator=.
9422 * configure: Rebuild.
9423 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
9424 -Wdeprecated-copy-dtor, -Wredundant-move.
9425
9426 2019-05-29 Tom Tromey <tromey@adacore.com>
9427
9428 * NEWS: Add entry.
9429 * infcmd.c (print_return_value_1): Handle finish_print
9430 option.
9431 (show_print_finish): New function.
9432 (_initialize_infcmd): Add "set/show print finish" commands.
9433 * valprint.c (user_print_options): Initialize new member.
9434 * valprint.h (struct value_print_options) <finish_print>: New
9435 member.
9436
9437 2019-05-28 Tom Tromey <tromey@adacore.com>
9438
9439 * ada-lang.c (ada_remove_Xbn_suffix)
9440 (find_old_style_renaming_symbol)
9441 (parse_old_style_renaming): Remove.
9442 (ada_find_renaming_symbol): Don't call
9443 find_old_style_renaming_symbol.
9444 (ada_is_renaming_symbol): Rename from
9445 ada_find_renaming_symbol. Remove "block" parameter. Return
9446 bool. Now static.
9447 (ada_read_var_value): Update and simplify.
9448 * ada-exp.y (write_var_or_type): Remove old code.
9449
9450 2019-05-28 Alan Hayward <alan.hayward@arm.com>
9451
9452 PR gdb/25010
9453 * event-top.c: Remove include comment.
9454 * inflow.c (class scoped_ignore_sigttou): Move from here...
9455 * inflow.h (class scoped_ignore_sigttou): ...to here.
9456 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
9457 * top.c: Remove include comment.
9458
9459 2019-05-27 Tom Tromey <tom@tromey.com>
9460
9461 * NEWS: Fix typo.
9462
9463 2019-05-22 Tom Tromey <tromey@adacore.com>
9464
9465 * target.c (target_follow_exec): Constify parameter.
9466 * target-delegates.c: Rebuild.
9467 * remote.c (remote_target::follow_exec): Constify parameter.
9468 * infrun.c (follow_exec): Constify parameter.
9469 * target.h (struct target_ops) <follow_exec>: Constify parameter.
9470 (target_follow_exec): Likewise.
9471
9472 2019-05-22 Alan Hayward <alan.hayward@arm.com>
9473
9474 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
9475 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
9476
9477 2019-05-22 Alan Hayward <alan.hayward@arm.com>
9478
9479 * NEWS: Add debugredirect and testsuite sections.
9480
9481 2019-05-22 Simon Cook <simon.cook@embecosm.com>
9482
9483 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
9484 target descriptions using exclusively floating point register name
9485 aliases.
9486
9487 2019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
9488
9489 PR gdb/18644:
9490 * f-lang.c (build_fortran_types): Handle the case where
9491 gdbarch_floatformat_for_type returns a nullptr.
9492
9493 2019-05-21 Tom de Vries <tdevries@suse.de>
9494
9495 PR cli/24587
9496 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
9497
9498 2019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
9499
9500 PR gdb/18644:
9501 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
9502 16-byte floats.
9503 * i386-tdep.c (i386_floatformat_for_type): Use
9504 floatformats_ia64_quad for the 16-byte floating point component
9505 within a fortran 32-byte complex number.
9506
9507 2019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
9508
9509 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
9510 delete default constructor.
9511 (find_partial_die): Update to return const struct.
9512 (partial_die_parent_scope): Move variable declaration into scope
9513 of its use and change its type to auto.
9514 (guess_partial_die_structure_name): Likewise.
9515 (partial_die_info::fixup): Likewise.
9516
9517 2019-05-17 Tom Tromey <tromey@adacore.com>
9518
9519 * source.c (find_and_open_source): Remove cast.
9520
9521 2019-05-17 Tom Tromey <tromey@adacore.com>
9522
9523 * annotate.c (annotate_source): Make "filename" const.
9524 * annotate.h (annotate_source): Use const.
9525
9526 2019-05-17 Alan Hayward <alan.hayward@arm.com>
9527
9528 * disasm.c (set_disassembler_options): Send errors to stderr.
9529
9530 2019-05-17 Alan Hayward <alan.hayward@arm.com>
9531
9532 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
9533 (cli_interp_base::set_logging): Check debug_redirect.
9534 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
9535 * cli/cli-logging.c (debug_redirect): Add static variable.
9536 (pop_output_files): Add default param.
9537 (handle_redirections): Print debug setting.
9538 (show_logging_command): Likewise.
9539 (_initialize_cli_logging): Add debugredirect command.
9540 * interps.c (current_interp_set_logging): Add debug_redirect
9541 parameter.
9542 * interps.h (set_logging): Add debug_redirect parameter.
9543 (current_interp_set_logging): Likewise.
9544 * mi/mi-common.h: Likewise.
9545 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
9546
9547 2019-05-17 Alan Hayward <alan.hayward@arm.com>
9548 Tom Tromey <tromey@adacore.com>
9549
9550 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
9551 directly.
9552 * cli/cli-interp.h (make_logging_output): Remove declaration.
9553 * cli/cli-logging.c (make_logging_output): Remove function.
9554 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
9555 directly.
9556 * ui-file.c (tee_file::tee_file): Remove bools.
9557 (tee_file::~tee_file): Remove deletes.
9558 * ui-file.h (tee_file): Remove bools.
9559
9560 2019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
9561
9562 * mi/mi-cmds.h (mi_cmd_complete): New function.
9563 * mi/mi-main.c (mi_cmd_complete): Likewise.
9564 * mi/mi-cmds.c: Define new MI command -complete.
9565 * NEWS: Mention new -complete command.
9566
9567 2019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
9568
9569 * completer.h (complete): New function.
9570 * completer.c (complete): Likewise.
9571 * cli/cli-cmds.c: (complete_command): Update to use new complete()
9572 function defined in completer.h.
9573
9574 2019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
9575
9576 * MAINTAINERS (Write After Approval): Add myself.
9577
9578 2019-05-17 Tom de Vries <tdevries@suse.de>
9579
9580 PR gdb/24094
9581 * dwarf2read.c (struct cu_partial_die_info): New struct.
9582 (find_partial_die): Return cu_partial_die_info.
9583 (partial_die_parent_scope, guess_partial_die_structure_name)
9584 (partial_die_info::fixup): Handle new return type of find_partial_die.
9585
9586 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9587
9588 PR breakpoints/24541
9589 * stap-probe.c (stap_parse_register_operand): Make "regname" an
9590 "std::string", simplifying the algorithm.
9591
9592 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9593
9594 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
9595 (stap_static_probe_ops::get_probes): Likewise.
9596
9597 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9598
9599 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
9600 '-')" and "else if".
9601 (stap_parse_single_operand): Join checks for
9602 "gdbarch_stap_parse_special_token_p" and
9603 "gdbarch_stap_parse_special_token" in the same "if" statement.
9604 Invert check when verifying for operation on register
9605 displacement.
9606
9607 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9608
9609 * stap-probe.c (stap_get_opcode): Update comment.
9610 (stap_get_expected_argument_type): Likewise.
9611 (handle_stap_probe): Likewise.
9612
9613 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9614
9615 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
9616 return type to 'bool'. Adjust comment. Use 'bool' when
9617 appropriate.
9618 (i386_stap_parse_special_token_three_arg_disp): Likewise.
9619 * stap-probe.c (stap_parse_argument_1): Likewise.
9620 (stap_is_operator): Likewise.
9621 (stap_is_generic_prefix): Likewise.
9622 (stap_is_register_prefix): Likewise.
9623 (stap_is_register_indirection_prefix): Likewise.
9624 (stap_is_integer_prefix): Likewise.
9625 (stap_generic_check_suffix): Likewise.
9626 (stap_check_integer_suffix): Likewise.
9627 (stap_check_register_suffix): Likewise.
9628 (stap_check_register_indirection_suffix): Likewise.
9629 (stap_parse_register_operand): Likewise.
9630 (stap_parse_single_operand): Likewise.
9631 (stap_parse_argument_1): Likewise.
9632 (stap_probe::get_argument_count): Likewise.
9633 (stap_is_operator): Likewise.
9634
9635 2019-05-16 Tom Tromey <tromey@adacore.com>
9636
9637 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
9638 keyword to foreach.
9639
9640 2019-05-15 Simon Marchi <simon.marchi@efficios.com>
9641
9642 * linux-thread-db.c (try_thread_db_load_1): Change return type
9643 to bool.
9644 (try_thread_db_load): Likewise.
9645 (try_thread_db_load_from_pdir_1): Likewise.
9646 (try_thread_db_load_from_pdir): Likewise.
9647 (try_thread_db_load_from_sdir): Likewise.
9648 (try_thread_db_load_from_dir): Likewise.
9649 (thread_db_load_search): Likewise.
9650 (has_libpthread): Likewise.
9651 (thread_db_load): Likewise.
9652
9653 2019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
9654
9655 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9656 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
9657 NULL, and complain/return if that's the case.
9658
9659 2019-05-15 John Darrington <john@darrington.wattle.id.au>
9660
9661 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
9662 (advance, posn, abstract_read_memory): New functions.
9663 [struct mem_read_abstraction]: New struct.
9664 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
9665
9666 2019-05-14 Tom Tromey <tromey@adacore.com>
9667
9668 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
9669 value is not lval_memory.
9670
9671 2019-05-14 Tom Tromey <tromey@adacore.com>
9672
9673 * solib.c (info_sharedlibrary_command): Style the file name.
9674
9675 2019-05-14 Alan Hayward <alan.hayward@arm.com>
9676
9677 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
9678 (aarch64_vnv_type): Likewise.
9679 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
9680 * common/tdesc.c: Likewise.
9681 * common/tdesc.h (enum tdesc_type_kind): Likewise.
9682 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
9683 * features/aarch64-fpu.xml: Add ieee half view.
9684 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
9685 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
9686 * gdbtypes.h (struct builtin_type): Likewise.
9687 (struct objfile_type): Likewise.
9688
9689 2019-05-12 Paul Naert <paul.naert@polymtl.ca>
9690
9691 * language.c (language_sniff_from_mangled_name): Fix "langauge"
9692 typo.
9693 * location.h (string_to_event_location): Likewise.
9694
9695 2019-05-11 Joel Brobecker <brobecker@adacore.com>
9696
9697 GDB 8.3 released.
9698
9699 2019-05-10 Simon Marchi <simon.marchi@efficios.com>
9700
9701 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
9702 New variable declaration.
9703 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
9704 New variable.
9705 (print_one_breakpoint): Use ui_out::test_flags and new global
9706 variable to compute use_fixed_output.
9707 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
9708 Remove.
9709 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
9710 (mi_multi_location_breakpoint_output_fixed): Remove.
9711 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
9712 new variable.
9713 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
9714 fix_multi_location_breakpoint_output flag if version >= 3.
9715 * ui-out.h (enum ui_out_flag)
9716 <fix_multi_location_breakpoint_output>: New enumerator.
9717
9718 2019-05-10 Simon Marchi <simon.marchi@efficios.com>
9719
9720 * contrib/cc-with-tweaks.sh: Validate dwz's work.
9721
9722 2019-05-10 Tom Tromey <tromey@adacore.com>
9723
9724 * ada-lang.c (catch_ada_completer): New function.
9725 (_initialize_ada_language): Use it.
9726
9727 2019-05-10 Tom Tromey <tromey@adacore.com>
9728
9729 * thread.c (print_thread_info): Make "requested_threads" const.
9730 * gdbthread.h (print_thread_info): Make "requested_threads"
9731 const.
9732 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
9733 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
9734
9735 2019-05-08 Tom Tromey <tom@tromey.com>
9736
9737 * gdbtypes.c (objfile_type_data): Change type.
9738 (objfile_type, _initialize_gdbtypes): Update.
9739
9740 2019-05-08 Tom Tromey <tom@tromey.com>
9741
9742 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
9743 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
9744 (_initialize_dwarf2_frame): Update.
9745
9746 2019-05-08 Tom Tromey <tom@tromey.com>
9747
9748 * objc-lang.c (objc_objfile_data): Change type.
9749 (find_methods): Update.
9750 (_initialize_objc_lang): Remove.
9751
9752 2019-05-08 Tom Tromey <tom@tromey.com>
9753
9754 * stabsread.c (rs6000_builtin_type_data): Change type.
9755 (rs6000_builtin_type, _initialize_stabsread): Update.
9756
9757 2019-05-08 Tom Tromey <tom@tromey.com>
9758
9759 * mips-tdep.c (mips_pdr_data): Remove.
9760 (_initialize_mips_tdep): Update.
9761
9762 2019-05-08 Tom Tromey <tom@tromey.com>
9763
9764 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
9765 (hppa_init_objfile_priv_data, read_unwind_info)
9766 (find_unwind_entry, _initialize_hppa_tdep): Update.
9767
9768 2019-05-08 Tom Tromey <tom@tromey.com>
9769
9770 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
9771 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
9772 on obstack.
9773 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
9774
9775 2019-05-08 Tom Tromey <tom@tromey.com>
9776
9777 * mdebugread.c (basic_type_data): Change type.
9778 (basic_type, _initialize_mdebugread): Update.
9779
9780 2019-05-08 Tom Tromey <tom@tromey.com>
9781
9782 * common/gdb_unique_ptr.h (struct noop_deleter): New.
9783
9784 2019-05-08 Tom Tromey <tom@tromey.com>
9785
9786 * nto-tdep.c (nto_inferior_data_reg): Change type.
9787 (nto_inferior_data): Update.
9788 (nto_inferior_data_cleanup, nto_new_inferior_data)
9789 (_initialize_nto_tdep): Remove.
9790 * nto-tdep.h (struct nto_inferior_data): Add initializers.
9791
9792 2019-05-08 Tom Tromey <tom@tromey.com>
9793
9794 * ada-lang.c (struct ada_inferior_data): Add initializers.
9795 (ada_inferior_data): Change type.
9796 (ada_inferior_data_cleanup): Remove.
9797 (get_ada_inferior_data, ada_inferior_exit)
9798 (struct ada_pspace_data): Add initializers, destructor.
9799 (ada_pspace_data_handle): Change type.
9800 (get_ada_pspace_data): Update.
9801 (ada_pspace_data_cleanup): Remove.
9802
9803 2019-05-08 Tom Tromey <tom@tromey.com>
9804
9805 * coffread.c (struct coff_symfile_info): Add initializers.
9806 (coff_objfile_data_key): Move lower. Change type.
9807 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
9808 Update.
9809 (coff_free_info): Remove.
9810
9811 2019-05-08 Tom Tromey <tom@tromey.com>
9812
9813 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
9814 (fbsd_pspace_data_handle): Move lower. Change type.
9815 (get_fbsd_pspace_data): Update.
9816 (fbsd_pspace_data_cleanup): Remove.
9817 (_initialize_fbsd_tdep): Update.
9818
9819 2019-05-08 Tom Tromey <tom@tromey.com>
9820
9821 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
9822 (get_ada_tasks_pspace_data): Update.
9823 (ada_tasks_pspace_data_cleanup): Remove.
9824 (_initialize_tasks): Update.
9825 (ada_tasks_inferior_data_handle): Change type.
9826 (get_ada_tasks_inferior_data): Update.
9827 (ada_tasks_inferior_data_cleanup): Remove.
9828 (struct ada_tasks_pspace_data): Add initializers.
9829
9830 2019-05-08 Tom Tromey <tom@tromey.com>
9831
9832 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
9833 * symfile-debug.c (debug_sym_get_probes): Change type.
9834 * stap-probe.c (handle_stap_probe):
9835 (stap_static_probe_ops::get_probes): Change type.
9836 * probe.h (class static_probe_ops) <get_probes>: Change type.
9837 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
9838 (parse_probes_in_pspace): Update.
9839 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
9840 Update.
9841 (any_static_probe_ops::get_probes): Change type.
9842 * elfread.c (elfread_data): New typedef.
9843 (probe_key): Change type.
9844 (elf_get_probes): Likewise. Update.
9845 (probe_key_free): Remove.
9846 (_initialize_elfread): Update.
9847 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
9848 Change type.
9849 (dtrace_process_dof_probe, dtrace_process_dof)
9850 (dtrace_static_probe_ops::get_probe): Change type.
9851
9852 2019-05-08 Tom Tromey <tom@tromey.com>
9853
9854 * xcoffread.c (struct xcoff_symfile_info): Rename from
9855 coff_symfile_info. Add initializers.
9856 (xcoff_objfile_data_key): Move lower. Change type.
9857 (XCOFF_DATA): Rewrite.
9858 (xcoff_free_info): Remove.
9859 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
9860 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
9861 (xcoff_initial_scan): Update.
9862
9863 2019-05-08 Tom Tromey <tom@tromey.com>
9864
9865 * solib-svr4.c (struct svr4_info): Add initializers and
9866 destructor.
9867 <probes_table>: Now an htab_up.
9868 (solib_svr4_pspace_data): Change type.
9869 (free_probes_table): Simplify.
9870 (~svr4_info): Rename from svr4_pspace_data_cleanup.
9871 (get_svr4_info, probes_table_htab_remove_objfile_probes)
9872 (probes_table_remove_objfile_probes, register_solib_event_probe)
9873 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
9874 (_initialize_svr4_solib): Update.
9875
9876 2019-05-08 Tom Tromey <tom@tromey.com>
9877
9878 * remote.c (remote_pspace_data): Change type.
9879 (remote_pspace_data_cleanup): Remove.
9880 (get_remote_exec_file, set_pspace_remote_exec_file)
9881 (_initialize_remote): Update.
9882
9883 2019-05-08 Tom Tromey <tom@tromey.com>
9884
9885 * breakpoint.c (breakpoint_objfile_key): Change type.
9886 (get_breakpoint_objfile_data): Update.
9887 (free_breakpoint_objfile_data): Remove.
9888 (_initialize_breakpoint): Update.
9889
9890 2019-05-08 Tom Tromey <tom@tromey.com>
9891
9892 * linux-tdep.c (struct linux_info): Add initializers.
9893 (linux_inferior_data): Move. Change type.
9894 (invalidate_linux_cache_inf): Update.
9895 (linux_inferior_data_cleanup): Remove.
9896 (get_linux_inferior_data, _initialize_linux_tdep): Update.
9897
9898 2019-05-08 Tom Tromey <tom@tromey.com>
9899
9900 * auxv.c (auxv_inferior_data): Move. Change type.
9901 (auxv_inferior_data_cleanup): Remove.
9902 (invalidate_auxv_cache_inf): Rewrite.
9903 (get_auxv_inferior_data, _initialize_auxv): Update.
9904
9905 2019-05-08 Tom Tromey <tom@tromey.com>
9906
9907 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
9908 (symfile_debug_objfile_data_key): Change type.
9909 (symfile_debug_installed, debug_qf_has_symbols)
9910 (debug_qf_find_last_source_symtab)
9911 (debug_qf_forget_cached_source_info)
9912 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
9913 (debug_qf_print_stats, debug_qf_dump)
9914 (debug_qf_expand_symtabs_for_function)
9915 (debug_qf_expand_all_symtabs)
9916 (debug_qf_expand_symtabs_with_fullname)
9917 (debug_qf_map_matching_symbols)
9918 (debug_qf_expand_symtabs_matching)
9919 (debug_qf_find_pc_sect_compunit_symtab)
9920 (debug_qf_map_symbol_filenames)
9921 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
9922 (debug_sym_new_init, debug_sym_init, debug_sym_read)
9923 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
9924 (debug_sym_read_linetable, debug_sym_relocate): Update.
9925 (symfile_debug_free_objfile): Remove.
9926 (install_symfile_debug_logging, _initialize_symfile_debug):
9927 Update.
9928
9929 2019-05-08 Tom Tromey <tom@tromey.com>
9930
9931 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
9932 allocate_on_obstack.
9933 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
9934 (get_dwarf2_per_objfile): Update.
9935 (set_dwarf2_per_objfile): Remove.
9936 (dwarf2_has_info, dwarf2_get_section_info): Update.
9937 (dwarf2_free_objfile): Remove.
9938 (_initialize_dwarf2_read): Update.
9939
9940 2019-05-08 Tom Tromey <tom@tromey.com>
9941
9942 * auto-load.c (struct auto_load_pspace_info): Add destructor and
9943 initializers.
9944 <unsupported_script_warning_printed,
9945 script_not_found_warning_printed>: Now bool.
9946 (auto_load_pspace_data): Change type.
9947 (~auto_load_pspace_info): Rename from
9948 auto_load_pspace_data_cleanup.
9949 (get_auto_load_pspace_data, init_loaded_scripts_info)
9950 (clear_section_scripts, maybe_print_unsupported_script_warning)
9951 (maybe_print_script_not_found_warning, _initialize_auto_load):
9952 Update.
9953
9954 2019-05-08 Tom Tromey <tom@tromey.com>
9955
9956 * objfiles.c (objfile_pspace_info): Add destructor and
9957 initializers.
9958 (objfiles_pspace_data): Change type.
9959 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
9960 (get_objfile_pspace_data): Update.
9961 (objfiles_bfd_data): Change type.
9962 (get_objfile_bfd_data): Update.
9963 (objfile_bfd_data_free, _initialize_objfiles): Remove.
9964
9965 2019-05-08 Tom Tromey <tom@tromey.com>
9966
9967 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
9968 Change type.
9969 (get_catch_syscall_inferior_data): Update.
9970 (catch_syscall_inferior_data_cleanup): Remove.
9971 (_initialize_break_catch_syscall): Update.
9972
9973 2019-05-08 Tom Tromey <tom@tromey.com>
9974
9975 * inflow.c (struct terminal_info): Add destructor and
9976 initializers.
9977 (inflow_inferior_data): Change type.
9978 (~terminal_info): Rename from inflow_inferior_data_cleanup.
9979 (get_inflow_inferior_data, inflow_inferior_exit)
9980 (swap_terminal_info, _initialize_inflow): Update.
9981
9982 2019-05-08 Tom Tromey <tom@tromey.com>
9983
9984 * target-dcache.c (target_dcache_cleanup): Remove.
9985 (target_dcache_aspace_key): Change type.
9986 (target_dcache_init_p, target_dcache_invalidate)
9987 (target_dcache_get, target_dcache_get_or_init)
9988 (_initialize_target_dcache): Update.
9989 * dcache.h (struct dcache_deleter): New.
9990
9991 2019-05-08 Tom Tromey <tom@tromey.com>
9992
9993 * symtab.c (struct symbol_cache): Add destructor and
9994 initializers.
9995 (symbol_cache_key): Move. Change type.
9996 (make_symbol_cache, free_symbol_cache): Remove.
9997 (get_symbol_cache): Update.
9998 (symbol_cache_cleanup): Remove.
9999 (ALL_PSPACES, symbol_cache_flush)
10000 (maintenance_print_symbol_cache)
10001 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10002 Update.
10003
10004 2019-05-08 Tom Tromey <tom@tromey.com>
10005
10006 * symtab.c (struct main_info): Add destructor and initializers.
10007 (main_progspace_key): Move. Change type.
10008 (get_main_info): Update.
10009 (main_info_cleanup): Remove.
10010 (_initialize_symtab): Update.
10011
10012 2019-05-08 Tom Tromey <tom@tromey.com>
10013
10014 * registry.h (DECLARE_REGISTRY): Define the _key class.
10015
10016 2019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
10017
10018 * NEWS: Merge two 'New commands' sections.
10019
10020 2019-05-08 Joel Brobecker <brobecker@adacore.com>
10021
10022 * ada-valprint.c (ada_val_print_gnat_array): Remove language
10023 parameter and use Ada language definition instead.
10024 (ada_val_print_ptr): Remove unused language parameter.
10025 (ada_val_print_num): Remove language parameter and use Ada language
10026 definition instead.
10027 (ada_val_print_enum, ada_val_print_flt): Remove unused language
10028 parameter.
10029 (ada_val_print_struct_union, ada_val_print_ref): Remove language
10030 parameter and use Ada language definition instead.
10031 (ada_val_print_1): Update all ada_val_print_xxx calls.
10032 Remove language parameter.
10033 (ada_val_print): Update ada_val_print_1 call.
10034
10035 2019-05-08 Tom Tromey <tromey@adacore.com>
10036
10037 * remote.c (remote_hw_watchpoint_limit)
10038 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10039 Now static.
10040
10041 2019-05-08 Tom Tromey <tromey@adacore.com>
10042
10043 * maint.c (_initialize_maint_cmds): Move initialization code to
10044 remote.c.
10045 (watchdog, show_watchdog): Move to remote.c.
10046 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
10047 "watchdog" static.
10048 (_initialize_remote): Move initialization code from maint.c.
10049 * defs.h (watchdog): Don't declare.
10050
10051 2019-05-08 Tom Tromey <tromey@adacore.com>
10052
10053 * tui/tui-interp.c: Include main.h.
10054 * interps.c: Include main.h.
10055 * main.h (interpreter_p): Declare.
10056 * defs.h (interpreter_p): Don't declare.
10057
10058 2019-05-08 Tom Tromey <tromey@adacore.com>
10059
10060 * dwarf2loc.c: Include dwarf2read.h.
10061 * defs.h (read_unsigned_leb128): Don't declare.
10062 * dwarf2read.h (read_unsigned_leb128): Declare.
10063
10064 2019-05-08 Tom Tromey <tromey@adacore.com>
10065
10066 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10067 method.
10068
10069 2019-05-08 Tom Tromey <tromey@adacore.com>
10070
10071 * utils.c (fputs_maybe_filtered): Reset style after paging, even
10072 when no wrap column is set.
10073
10074 2019-05-08 Tom Tromey <tromey@adacore.com>
10075
10076 * c-lang.c (c_get_string): Handle non-C-style arrays.
10077
10078 2019-05-08 Tom Tromey <tromey@adacore.com>
10079
10080 * typeprint.c (print_offset_data::update): Print the bit offset,
10081 not the number of bits remaining.
10082
10083 2019-05-08 Tom Tromey <tromey@adacore.com>
10084
10085 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10086 padding at end of comment.
10087
10088 2019-05-08 Tom Tromey <tromey@adacore.com>
10089
10090 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10091 Compare main types.
10092
10093 2019-05-06 Tom Tromey <tom@tromey.com>
10094
10095 * common/scoped_mmap.c: Include common-defs.h.
10096 * common/scoped_mmap.h: Don't include config.h.
10097
10098 2019-05-04 Tom Tromey <tom@tromey.com>
10099
10100 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10101 (struct aarch64_call_info): Add initializers.
10102 <si>: Now a std::vector.
10103 (pass_on_stack, aarch64_push_dummy_call): Update.
10104
10105 2019-05-04 Simon Marchi <simon.marchi@efficios.com>
10106 Tom Tromey <tom@tromey.com>
10107
10108 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10109 (ppc_threads): Now a std::vector. Now static.
10110 (hwdebug_find_thread_points_by_tid)
10111 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10112 Update.
10113
10114 2019-05-04 Tom Tromey <tom@tromey.com>
10115
10116 * arc-tdep.c (arc_tdesc_init): Return bool.
10117
10118 2019-05-04 Tom Tromey <tom@tromey.com>
10119
10120 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10121 Use gdb_assert_not_reached.
10122
10123 2019-05-04 Tom Tromey <tom@tromey.com>
10124
10125 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10126 "false".
10127
10128 2019-05-04 Tom Tromey <tom@tromey.com>
10129
10130 * arc-tdep.c (arc_tdesc_init): Use bool.
10131
10132 2019-05-04 Tom Tromey <tom@tromey.com>
10133
10134 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10135
10136 2019-05-04 Tom Tromey <tom@tromey.com>
10137
10138 * cli/cli-cmds.c (valid_command_p): Return bool.
10139
10140 2019-05-04 Tom Tromey <tom@tromey.com>
10141
10142 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10143 * command.h (valid_user_defined_cmd_name_p): Channge return type.
10144
10145 2019-05-04 Raul Tambre <raul@tambre.ee>
10146
10147 * python/lib/gdb/prompt.py (_ExtendedPrompt)
10148 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10149 operator for comparison.
10150
10151 2019-05-04 Tom Tromey <tom@tromey.com>
10152
10153 * psymtab.c (psymbol_name_matches, match_partial_symbol)
10154 (lookup_partial_symbol, print_partial_symbols)
10155 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10156 (psymbol_compare): Update.
10157 (add_psymbol_to_bcache): Clear the entire psymbol.
10158 (maintenance_check_psymtabs): Update.
10159 * psympriv.h (struct partial_symbol): Don't derive from
10160 general_symbol_info.
10161 <obj_section, unrelocated_address, address,
10162 set_unrelocated_address>: Update.
10163 <ginfo>: New member.
10164 * dwarf-index-write.c (write_psymbols, debug_names::insert)
10165 (debug_names::write_psymbols): Update.
10166
10167 2019-05-04 Tom de Vries <tdevries@suse.de>
10168
10169 * contrib/cc-with-tweaks.sh: Support -n arg.
10170
10171 2019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10172
10173 * corelow.c (core_target::detach): Ensure frame cache and
10174 register caches are cleared.
10175 inferior.c (exit_inferior_1): Likewise.
10176
10177 2019-05-03 Sandra Loosemore <sandra@codesourcery.com>
10178 Tom Tromey <tom@tromey.com>
10179
10180 * dictionary.c (collate_pending_symbols_by_language): Remove
10181 "struct" from foreach.
10182 * symtab.c (lookup_global_symbol_from_objfile)
10183 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10184 foreach.
10185 * ser-tcp.c (net_open): Remove "struct" from foreach.
10186 * objfiles.c (objfile_relocate, objfile_rebase)
10187 (objfile_has_symbols): Remove "struct" from foreach.
10188 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10189 from foreach.
10190 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10191 foreach.
10192 * darwin-nat.c (thread_info_from_private_thread_info): Remove
10193 "struct" from foreach.
10194 * ada-lang.c (create_excep_cond_exprs)
10195 (ada_exception_catchpoint_cond_string): Remove "struct" from
10196 foreach.
10197
10198 2019-05-03 Tom Tromey <tromey@adacore.com>
10199
10200 * ada-exp.y (convert_char_literal): Check suffix of each
10201 enumerator.
10202
10203 2019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
10204
10205 PR ada/21406:
10206 * ada-exp.y (yywrap): Don't define.
10207 * ada-lex.l (%option): Add noyywrap
10208 (yywrap): Remove.
10209
10210 2019-05-03 Eli Zaretskii <eliz@gnu.org>
10211
10212 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10213 _WIN32_WINNT to the XP level, unless already defined to a higher
10214 level.
10215
10216 * unittests/parse-connection-spec-selftests.c:
10217 * ser-tcp.c:
10218 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
10219 override.
10220
10221 * symfile.c (find_separate_debug_file): Remove colon from the
10222 drive spec of DOS/Windows file names of the target, so that the
10223 file name produced from DEBUGDIR and the target's directory will
10224 be valid on DOS/Windows systems.
10225
10226 2019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
10227
10228 * rust-lang.c (val_print_struct): Handle printing structures
10229 containing strings.
10230
10231 2019-05-02 Tom Tromey <tromey@adacore.com>
10232
10233 * valarith.c (_initialize_valarith): Remove.
10234
10235 2019-05-01 Tom Tromey <tromey@adacore.com>
10236
10237 * ada-lang.c (ada_value_primitive_field): Treat more fields as
10238 bitfields.
10239
10240 2019-05-01 Tom Tromey <tromey@adacore.com>
10241
10242 * ada-lang.c (ada_value_assign): Correctly compute starting offset
10243 for big-endian copies.
10244
10245 2019-04-30 Ali Tamur <tamur@google.com>
10246 * gdb/dwarf2read.c (read_3_bytes): New declaration.
10247 (read_attribute_value): Added DW_FORM_strx1-4 cases.
10248 (read_3_bytes): New function.
10249
10250 2019-04-30 Joel Brobecker <brobecker@adacore.com>
10251
10252 * windows-nat.c (main_thread_id): Delete.
10253 (handle_output_debug_string): Replace main_thread_id by
10254 current_event.dwThreadId.
10255 (fake_create_process): Likewise.
10256 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10257 Do not set main_thread_id.
10258 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10259 current_event.dwThreadId.
10260 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10261
10262 2019-04-30 Joel Brobecker <brobecker@adacore.com>
10263
10264 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10265 Use current_event.dwThreadId instead of main_thread_id.
10266
10267 2019-04-30 Tom Tromey <tromey@adacore.com>
10268
10269 * ada-lang.c (ada_lookup_simple_minsyms): New function.
10270 (create_excep_cond_exprs): Iterate over program spaces.
10271 (ada_exception_catchpoint_cond_string): Examine all minimal
10272 symbols for exception types.
10273
10274 2019-04-30 Tom Tromey <tromey@adacore.com>
10275
10276 PR c++/24470:
10277 * dwarf2read.c (process_structure_scope): Handle case where type
10278 has template parameters but no symbol was created.
10279
10280 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10281 Chris January <chris.january@arm.com>
10282
10283 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
10284 qualifier.
10285 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
10286
10287 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10288
10289 * f-typeprint.c (f_print_type): Update rules for printing
10290 whitespace.
10291 (f_type_print_varspec_suffix): Likewise.
10292
10293 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10294 Chris January <chris.january@arm.com>
10295
10296 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
10297 function arguments.
10298
10299 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10300
10301 * f-lang.c (build_fortran_types): Change name of void type to
10302 lower case.
10303 * f-typeprint.c (f_type_print_base): Print the name of the void
10304 type, rather than a fixed string.
10305 * f-valprint.c (f_decorations): Use lower case void string.
10306
10307 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10308 Chris January <chris.january@arm.com>
10309
10310 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
10311 types for Fortran.
10312
10313 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10314 Chris January <chris.january@arm.com>
10315 David Lecomber <david.lecomber@arm.com>
10316
10317 * f-exp.y (BINOP_INTRINSIC): New token.
10318 (exp): New parser rule handling BINOP_INTRINSIC.
10319 (f77_keywords): Add new builtin procedures.
10320 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
10321 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10322 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
10323 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10324 (print_unop_subexp_f): New function.
10325 (print_binop_subexp_f): New function.
10326 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10327 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10328 (dump_subexp_body_f): Likewise.
10329 (operator_check_f): Likewise.
10330 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10331 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
10332
10333 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10334
10335 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
10336 UNOP_KIND.
10337 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
10338 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
10339 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
10340 (operator_length_f): New fuction.
10341 (print_subexp_f): New function.
10342 (op_name_f): New function.
10343 (dump_subexp_body_f): New function.
10344 (operator_check_f): New function.
10345 (exp_descriptor_f): Replace standard expression handling functions
10346 with new functions.
10347 * gdb/fortran-operator.def: New file.
10348 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
10349 * gdb/std-operator.def: Remove UNOP_KIND.
10350
10351 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10352
10353 * std-operator.def: Remove unbalanced, stray double quote
10354 character.
10355
10356 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10357 Chris January <chris.january@arm.com>
10358 Daniel Everett <daniel.everett@arm.com>
10359 Nick Forrington <nick.forrington@arm.com>
10360 Richard Bunt <richard.bunt@arm.com>
10361
10362 * cp-valprint.c (cp_print_value_fields): Allow an additional level
10363 of depth when printing anonymous structs or unions.
10364 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
10365 Don't print either the top-level value, or the children if the
10366 max-depth is exceeded.
10367 (ppscm_print_children): When printing the key of a map, allow one
10368 extra level of depth.
10369 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
10370 print either the top-level value, or the children if the max-depth
10371 is exceeded.
10372 (print_children): When printing the key of a map, allow one extra
10373 level of depth.
10374 * python/py-value.c (valpy_format_string): Add max_depth keyword.
10375 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
10376 (user_print_options): Initialise max_depth field.
10377 (val_print_scalar_or_string_type_p): New function.
10378 (val_print): Check to see if the max depth has been reached.
10379 (val_print_check_max_depth): Define new function.
10380 (show_print_max_depth): New function.
10381 (_initialize_valprint): Add 'print max-depth' option.
10382 * valprint.h (struct value_print_options) <max_depth>: New field.
10383 (val_print_check_max_depth): Declare new function.
10384 * NEWS: Document new feature.
10385
10386 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10387
10388 * ada-lang.c (ada_language_defn): Initialise new field.
10389 * c-lang.c (c_is_string_type_p): New function.
10390 (c_language_defn): Initialise new field.
10391 (cplus_language_defn): Initialise new field.
10392 (asm_language_defn): Initialise new field.
10393 (minimal_language_defn): Initialise new field.
10394 * c-lang.h (c_is_string_type_p): Declare new function.
10395 * d-lang.c (d_language_defn): Initialise new field.
10396 * f-lang.c (f_is_string_type_p): New function.
10397 (f_language_defn): Initialise new field.
10398 * go-lang.c (go_is_string_type_p): New function.
10399 (go_language_defn): Initialise new field.
10400 * language.c (default_is_string_type_p): New function.
10401 (unknown_language_defn): Initialise new field.
10402 (auto_language_defn): Initialise new field.
10403 * language.h (struct language_defn) <la_is_string_type_p>: New
10404 member variable.
10405 (default_is_string_type_p): Declare new function.
10406 * m2-lang.c (m2_language_defn): Initialise new field.
10407 * objc-lang.c (objc_language_defn): Initialise new field.
10408 * opencl-lang.c (opencl_language_defn): Initialise new field.
10409 * p-lang.c (pascal_is_string_type_p): New function.
10410 (pascal_language_defn): Initialise new field.
10411 * rust-lang.c (rust_is_string_type_p): New function.
10412 (rust_language_defn): Initialise new field.
10413
10414 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10415
10416 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
10417 New field.
10418 * ada-lang.c (ada_language_defn): Initialise new field.
10419 * c-lang.c (c_language_defn): Likewise.
10420 (cplus_language_defn): Likewise.
10421 (asm_language_defn): Likewise.
10422 (minimal_language_defn): Likewise.
10423 * d-lang.c (d_language_defn): Likewise.
10424 * f-lang.c (f_language_defn): Likewise.
10425 * go-lang.c (go_language_defn): Likewise.
10426 * language.c (unknown_language_defn): Likewise.
10427 (auto_language_defn): Likewise.
10428 * m2-lang.c (m2_language_defn): Likewise.
10429 * objc-lang.c (objc_language_defn): Likewise.
10430 * opencl-lang.c (opencl_language_defn): Likewise.
10431 * p-lang.c (pascal_language_defn): Likewise.
10432 * rust-lang.c (rust_language_defn): Likewise.
10433
10434 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10435
10436 * ada-lang.c (ada_is_character_type): Change return type to bool.
10437 (ada_is_string_type): Likewise.
10438 * ada-lang.h (ada_is_character_type): Update declaration
10439 (ada_is_string_type): Likewise.
10440
10441 2019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10442
10443 Support style in 'frame|thread apply'
10444
10445 * gdbcmd.h (execute_command_to_string): New term_out parameter.
10446 * record.c (record_start, record_stop): Update callers of
10447 execute_command_to_string with false.
10448 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
10449 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
10450 methods.
10451 (class string_file): New constructor with term_out parameter.
10452 Override methods term_out and can_emit_style_escape. New member
10453 term_out.
10454 (class stdio_file): Override can_emit_style_escape.
10455 (class tee_file): Override term_out and can_emit_style_escape.
10456 * utils.h (can_emit_style_escape): Remove.
10457 * utils.c (can_emit_style_escape): Likewise.
10458 Update all callers of can_emit_style_escape (SOMESTREAM) to
10459 SOMESTREAM->can_emit_style_escape.
10460 * source-cache.c (source_cache::get_source_lines): Likewise.
10461 * stack.c (frame_apply_command_count): Call execute_command_to_string
10462 passing the term_out characteristic of the current gdb_stdout.
10463 * thread.c (thr_try_catch_cmd): Likewise.
10464 * top.c (execute_command_to_string): pass term_out parameter
10465 to construct the string_file for the command output.
10466 * ui-file.c (term_cli_styling): New function (most code moved
10467 from utils.c can_emit_style_escape).
10468 (string_file::string_file, string_file::can_emit_style_escape,
10469 stdio_file::can_emit_style_escape, tee_file::term_out,
10470 tee_file::can_emit_style_escape): New functions.
10471
10472 2019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10473
10474 * NEWS: Mention the new set|show may-call-functions.
10475 * infcall.c (may_call_functions_p): New variable.
10476 (show_may_call_functions_p): New function.
10477 (call_function_by_hand_dummy): Throws an error if not
10478 may-call-functions.
10479 (_initialize_infcall): Call add_setshow_boolean_cmd for
10480 may-call-functions.
10481
10482 2019-04-25 Keith Seitz <keiths@redhat.com>
10483
10484 PR c++/24367
10485 * cp-support.c (inspect_type): Don't attempt substitutions
10486 of symbol with the same name.
10487
10488 2019-04-25 Tom Tromey <tromey@adacore.com>
10489
10490 PR gdb/24475:
10491 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
10492 static.
10493
10494 2019-04-25 Tom Tromey <tromey@adacore.com>
10495
10496 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
10497 rvalue reference.
10498 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
10499 (gdb_xml_parser::parse): Use std::move.
10500 * python/python-internal.h (gdbpy_convert_exception): Take a const
10501 reference.
10502 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
10503 std::move.
10504 * python/py-utils.c (gdbpy_convert_exception): Take a const
10505 reference.
10506 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10507 Use std::move.
10508 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10509 Use std::move.
10510 * mi/mi-main.c (mi_print_exception): Take a const reference.
10511 * main.c (handle_command_errors): Take a const reference.
10512 * linespec.c (parse_linespec): Use std::move.
10513 * infcall.c (run_inferior_call): Use std::move.
10514 (call_function_by_hand_dummy): Use std::move.
10515 * exec.c (try_open_exec_file): Use std::move.
10516 * exceptions.h (exception_print, exception_fprintf)
10517 (exception_print_same): Update.
10518 * exceptions.c (print_exception, exception_print)
10519 (exception_fprintf, exception_print_same): Change parameters to
10520 const reference.
10521 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
10522 * common/new-op.c: Use std::move.
10523 * common/common-exceptions.h (struct gdb_exception): Add move
10524 constructor.
10525 (struct gdb_exception_error, struct gdb_exception_quit, struct
10526 gdb_quit_bad_alloc): Change constructor to move constructor.
10527 (throw_exception): Change parameter to rvalue reference.
10528 * common/common-exceptions.c (throw_exception): Take rvalue
10529 reference.
10530 * cli/cli-interp.c (safe_execute_command): Use std::move.
10531 * breakpoint.c (insert_bp_location, location_to_sals): Use
10532 std::move.
10533
10534 2019-04-25 Tom Tromey <tromey@adacore.com>
10535
10536 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
10537 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
10538 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
10539 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
10540 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
10541 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
10542 guile/scm-value.c: Use unpack.
10543 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
10544 gdbscm_gdb_exception.
10545 (gdbscm_throw_gdb_exception): Likewise.
10546 (struct gdbscm_gdb_exception): New.
10547 (unpack): New function.
10548 (gdbscm_wrap): Use unpack.
10549
10550 2019-04-25 Tom Tromey <tromey@adacore.com>
10551
10552 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10553 (gdb_rl_callback_handler): Use std::move.
10554 * common/common-exceptions.h (struct gdb_exception): Add move
10555 assignment operator.
10556 (throw_exception_sjlj): Change "exception" to const reference.
10557 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
10558 (throw_exception_sjlj): Change "exception" to const reference.
10559
10560 2019-04-25 Tom Tromey <tromey@adacore.com>
10561
10562 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
10563 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
10564 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10565 Update.
10566 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10567 Update.
10568 * mi/mi-interp.c (mi_interp::exec): Update.
10569 * linespec.c (parse_linespec): Update.
10570 * infcall.c (run_inferior_call): Update.
10571 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
10572 * guile/scm-symbol.c (gdbscm_lookup_symbol)
10573 (gdbscm_lookup_global_symbol): Update.
10574 * guile/scm-param.c (gdbscm_parameter_value): Update.
10575 * guile/scm-frame.c (gdbscm_frame_read_register)
10576 (gdbscm_frame_read_var): Update.
10577 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
10578 * exec.c (try_open_exec_file): Update.
10579 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10580 (gdb_rl_callback_handler): Update.
10581 * common/common-exceptions.h (exception_none): Don't declare.
10582 * common/common-exceptions.c (exception_none): Don't define.
10583 (struct catcher) <exception>: Update.
10584 * cli/cli-interp.c (safe_execute_command): Update.
10585 * breakpoint.c (insert_bp_location, location_to_sals): Update.
10586
10587 2019-04-25 Ali Tamur <tamur@google.com>
10588
10589 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
10590 (read_attribute_value): Likewise.
10591 (dwarf2_read_addr_index): Update comment.
10592 (read_str_index): Add DW_FORM_strx.
10593 (dwarf2_string_attr): Likewise.
10594 (dwarf2_const_value_attr): Likewise.
10595 (dump_die_shallow): Likewise.
10596 (dwarf2_fetch_constant_bytes): Likewise.
10597 (skip_form_bytes): Likewise.
10598 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
10599
10600 2019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
10601
10602 PR corefiles/11608
10603 PR corefiles/18187
10604 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
10605 OFFSET. Verify if current mapping contains an ELF header.
10606 (linux_find_memory_regions_full): Adjust call to
10607 dump_mapping_p.
10608
10609 2019-04-25 Sandra Loosemore <sandra@codesourcery.com>
10610 Kang Li <kanglictf@gmail.com>
10611
10612 PR gdb/21600
10613
10614 * dwarf2-frame.c (read_initial_length): Be consistent about using
10615 unsigned representation of length.
10616 (decode_frame_entry_1): Likewise. Check for wraparound of
10617 end pointer as well as buffer overflow.
10618
10619 2019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
10620
10621 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
10622 "vq".
10623
10624 2019-04-24 Tom Tromey <tromey@adacore.com>
10625
10626 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
10627
10628 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10629
10630 * s12z-tdep.c (s12z_unwind_pc): Delete.
10631 (s12z_unwind_sp): Delete.
10632 (s12z_gdbarch_init): Don't register deleted functions with
10633 gdbarch.
10634
10635 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10636
10637 * rl78-tdep.c (rl78_unwind_sp): Delete.
10638 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
10639
10640 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10641
10642 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
10643 (xstormy16_unwind_pc): Delete.
10644 (xstormy16_dummy_id): Delete.
10645 (xstormy16_gdbarch_init): Don't register deleted functions with
10646 gdbarch.
10647
10648 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10649
10650 * vax-tdep.c (vax_unwind_pc): Delete.
10651 (vax_gdbarch_init): Don't register deleted function with gdbarch.
10652
10653 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10654
10655 * v850-tdep.c (v850_unwind_sp): Delete.
10656 (v850_unwind_pc): Delete.
10657 (v850_dummy_id): Delete.
10658 (v850_gdbarch_init): Don't register deleted functions with
10659 gdbarch.
10660
10661 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10662
10663 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
10664 (tilegx_unwind_pc): Delete.
10665 (tilegx_unwind_dummy_id): Delete.
10666 (tilegx_gdbarch_init): Don't register deleted functions with
10667 gdbarch.
10668
10669 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10670
10671 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
10672 (tic6x_dummy_id): Delete.
10673 (tic6x_gdbarch_init): Don't register deleted functions with
10674 gdbarch.
10675
10676 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10677
10678 * sparc-tdep.c (sparc_unwind_pc): Delete.
10679 (sparc32_gdbarch_init): Don't register deleted function with
10680 gdbarch.
10681
10682 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10683
10684 * sh-tdep.c (sh_unwind_sp): Delete.
10685 (sh_unwind_pc): Delete.
10686 (sh_dummy_id): Delete.
10687 (sh_gdbarch_init): Don't register deleted functions with
10688 gdbarch.
10689
10690 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10691
10692 * score-tdep.c (score_unwind_sp): Delete.
10693 (score_unwind_pc): Delete.
10694 (score_dummy_id): Delete.
10695 (score_gdbarch_init): Don't register deleted functions with
10696 gdbarch.
10697
10698 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10699
10700 * rx-tdep.c (rx_unwind_pc): Delete.
10701 (rx_unwind_sp): Delete.
10702 (rx_dummy_id): Delete.
10703 (rx_gdbarch_init): Don't register deleted functions with
10704 gdbarch. Update comment.
10705
10706 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10707
10708 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
10709 (rs6000_dummy_id): Delete.
10710 (rs6000_gdbarch_init): Don't register deleted functions with
10711 gdbarch.
10712
10713 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10714
10715 * or1k-tdep.c (or1k_dummy_id): Delete.
10716 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
10717
10718 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10719
10720 * nios2-tdep.c (nios2_dummy_id): Delete.
10721 (nios2_unwind_sp): Delete.
10722 (nios2_gdbarch_init): Don't register deleted functions with
10723 gdbarch.
10724
10725 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10726
10727 * nds32-tdep.c (nds32_dummy_id): Delete.
10728 (nds32_unwind_pc): Delete.
10729 (nds32_unwind_sp): Delete.
10730 (nds32_gdbarch_init): Don't register deleted functions with
10731 gdbarch.
10732
10733 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10734
10735 * msp430-tdep.c (msp430_unwind_pc): Delete.
10736 (msp430_unwind_sp): Delete.
10737 (msp430_dummy_id): Delete.
10738 (msp430_gdbarch_init): Don't register deleted functions with
10739 gdbarch.
10740
10741 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10742
10743 * moxie-tdep.c (moxie_unwind_sp): Delete.
10744 (moxie_unwind_pc): Delete.
10745 (moxie_dummy_id): Delete.
10746 (moxie_gdbarch_init): Don't register deleted functions with
10747 gdbarch.
10748
10749 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10750
10751 * mn10300-tdep.c (mn10300_dummy_id): Delete.
10752 (mn10300_unwind_pc): Delete.
10753 (mn10300_unwind_sp): Delete.
10754 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
10755 mn10300_unwind_sp.
10756 (mn10300_frame_unwind_init): Don't register deleted functions with
10757 gdbarch.
10758
10759 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10760
10761 * mep-tdep.c (mep_unwind_pc): Delete.
10762 (mep_unwind_sp): Delete.
10763 (mep_dummy_id): Delete.
10764 (mep_gdbarch_init): Don't register deleted functions with
10765 gdbarch.
10766
10767 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10768
10769 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
10770 (m68hc11_unwind_sp): Delete.
10771 (m68hc11_gdbarch_init): Don't register deleted functions with
10772 gdbarch.
10773
10774 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10775
10776 * m32r-tdep.c (m32r_unwind_sp): Delete.
10777 (m32r_unwind_pc): Delete.
10778 (m32r_dummy_id): Delete.
10779 (m32r_gdbarch_init): Don't register deleted functions with
10780 gdbarch.
10781
10782 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10783
10784 * m32c-tdep.c (m32c_unwind_pc): Delete.
10785 (m32c_unwind_sp): Delete.
10786 (m32c_dummy_id): Delete.
10787 (m32c_gdbarch_init): Don't register deleted functions with
10788 gdbarch.
10789
10790 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10791
10792 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
10793 (lm32_unwind_pc): Delete.
10794 (lm32_dummy_id): Delete.
10795 (lm32_gdbarch_init): Don't register deleted functions with
10796 gdbarch.
10797
10798 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10799
10800 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
10801 (iq2000_unwind_pc): Delete.
10802 (iq2000_dummy_id): Delete.
10803 (iq2000_gdbarch_init): Don't register deleted functions with
10804 gdbarch.
10805
10806 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10807
10808 * nds32-tdep.c (nds32_type_align): Delete.
10809 (nds32_push_dummy_call): Use type_align instead.
10810
10811 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10812
10813 * arm-tdep.c (arm_type_align): Only handle vector override case.
10814 (arm_push_dummy_call): Use type_align.
10815 (arm_gdbarch_init): Register arm_type_align gdbarch function.
10816
10817 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10818
10819 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
10820 case.
10821 (pass_on_stack): Use type_align.
10822 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
10823 function.
10824
10825 2019-04-23 Tom Tromey <tromey@adacore.com>
10826
10827 * dwarf2read.c (line_header::file_name_at): Remove unused
10828 overload.
10829
10830 2019-04-23 Tom de Vries <tdevries@suse.de>
10831
10832 PR gdb/24438
10833 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
10834 invocation.
10835
10836
10837 2019-03-27 Ali Tamur <tamur@google.com>
10838
10839 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
10840 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
10841 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
10842 (dwarf_expr_context::get_addr_index): Likewise
10843 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
10844 (symbol_needs_eval_context::get_addr_index): Likewise
10845 (disassemble_dwarf_expression): Add DW_OP_addrx
10846 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
10847 (read_cutu_die_from_dwo): Update comment
10848 (skip_one_die): Add DW_FORM_addrx
10849 (read_attribute_value): Likewise
10850 (var_decode_location): Add DW_OP_addrx
10851 (dwarf2_const_value_attr): Add DW_FORM_addrx
10852 (dump_die_shallow): Likewise
10853 (dwarf2_fetch_constant_bytes): Likewise
10854 (decode_locdesc): Add DW_OP_addrx
10855 (skip_form_bytes): Add DW_FORM_addrx
10856
10857 2019-04-22 Ali Tamur <tamur@google.com>
10858
10859 * MAINTAINERS (Write After Approval): Add self.
10860
10861 2019-04-22 Simon Marchi <simon.marchi@efficios.com>
10862
10863 * solib-svr4.c (get_svr4_info): Add pspace parameter.
10864 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
10865 (open_symbol_file_object): Likewise.
10866 (svr4_default_sos): Add info parameter.
10867 (svr4_read_so_list): Likewise.
10868 (svr4_current_sos_direct): Adjust functions calls to pass down
10869 info.
10870 (svr4_current_sos_1): Add info parameter.
10871 (svr4_current_sos): Call get_svr4_info, pass info down to
10872 svr4_current_sos_1.
10873 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
10874 get_svr4_info.
10875 (svr4_in_dynsym_resolve_code): Pass current_program_space to
10876 get_svr4_info.
10877 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
10878 to get_svr4_info.
10879 (probes_table_remove_objfile_probes): Likewise.
10880 (register_solib_event_probe): Add info parameter.
10881 (solist_update_incremental): Pass info parameter down to
10882 svr4_read_so_list.
10883 (disable_probes_interface): Add info parameter.
10884 (svr4_handle_solib_event): Pass current_program_space to
10885 get_svr4_info. Adjust disable_probes_interface cleanup.
10886 (svr4_create_probe_breakpoints): Add info parameter, pass it
10887 down to register_solib_event_probe.
10888 (svr4_create_solib_event_breakpoints): Add info parameter,
10889 pass it down to svr4_create_probe_breakpoints.
10890 (enable_break): Pass info down to
10891 svr4_create_solib_event_breakpoints.
10892 (svr4_solib_create_inferior_hook): Pass current_program_space to
10893 get_svr4_info.
10894 (svr4_clear_solib): Likewise.
10895
10896 2019-04-22 Pedro Alves <palves@redhat.com>
10897
10898 * solib-svr4.c (svr4_free_objfile_observer): New.
10899 (probe_and_action::objfile): New field.
10900 (probes_table_htab_remove_objfile_probes)
10901 (probes_table_remove_objfile_probes): New functions.
10902 (register_solib_event_probe): Add 'objfile' parameter. Store it
10903 in the new probe_and_action. Don't store the probe in 'lookup'.
10904 (svr4_create_probe_breakpoints): Pass objfile to
10905 register_solib_event_probe.
10906 (_initialize_svr4_solib): Register a free_objfile observer.
10907
10908 2019-04-19 Tom Tromey <tom@tromey.com>
10909
10910 * common/queue.h: Remove.
10911
10912 2019-04-19 Tom Tromey <tom@tromey.com>
10913
10914 * event-loop.c: Don't include "common/queue.h".
10915
10916 2019-04-19 Tom Tromey <tom@tromey.com>
10917
10918 * remote.c (remote_target): Use delete.
10919 * remote-notif.h: Include <list>, not "common/queue.h".
10920 (notif_client_p): Remove typedef.
10921 (remote_notif_state): Add constructor, destructor, initializer.
10922 <notif_queue>: Now a std::list.
10923 (remote_notif_state_xfree): Don't declare.
10924 * remote-notif.c (remote_notif_process, handle_notification)
10925 (remote_notif_state_allocate): Update.
10926 (~remote_notif_state): Rename from remote_notif_state_xfree.
10927
10928 2019-04-19 Tom Tromey <tom@tromey.com>
10929
10930 * symfile.c (reread_symbols): Update.
10931 * objfiles.c (objfile_register_static_link)
10932 (objfile_lookup_static_link): Update
10933 (~objfile) Don't delete static_links.
10934 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
10935
10936 2019-04-19 Tom Tromey <tom@tromey.com>
10937
10938 * type-stack.h (struct type_stack) <insert>: Constify string.
10939 * type-stack.c (type_stack::insert): Constify string.
10940 * gdbtypes.h (lookup_template_type): Update.
10941 (address_space_name_to_int): Update.
10942 * gdbtypes.c (address_space_name_to_int): Make space_identifier
10943 const.
10944 (lookup_template_type): Make name const.
10945 * c-exp.y: Update rules.
10946 (lex_one_token, classify_name, classify_inner_name)
10947 (c_print_token): Update.
10948 * p-exp.y: Update rules.
10949 (yylex): Update.
10950 * f-exp.y: Update rules.
10951 (yylex): Update.
10952 * d-exp.y: Update rules.
10953 (lex_one_token, classify_name, classify_inner_name): Update.
10954 * parse.c (write_dollar_variable, copy_name): Return std::string.
10955 * parser-defs.h (copy_name): Change return type.
10956 * m2-exp.y: Update rules.
10957 (yylex): Update.
10958 * go-exp.y (lex_one_token): Update.
10959 Update rules.
10960 (classify_unsafe_function, classify_packaged_name)
10961 (classify_name, yylex): Update.
10962
10963 2019-04-19 Sergei Trofimovich <siarheit@google.com>
10964
10965 * configure.ac: add --enable-source-highlight switch.
10966 * configure: Regenerate.
10967 * top.c (print_gdb_version): plumb --enable-source-highlight
10968 status to "show configuration".
10969
10970 2019-04-19 Tom Tromey <tromey@adacore.com>
10971
10972 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
10973 Check ADA_TYPE_P.
10974 (empty_record, ada_template_to_fixed_record_type_1)
10975 (template_to_static_fixed_type)
10976 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
10977 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
10978 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
10979 macros.
10980
10981 2019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
10982
10983 PR symtab/24423:
10984 * source.c (print_source_lines_base): Advance "iter" when a
10985 control character is seen.
10986
10987 2019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10988
10989 * inferior.h (struct infcall_suspend_state_deleter):
10990 Catch exception in destructor to avoid crash.
10991
10992 2019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10993
10994 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
10995 close to the add_com "shell".
10996
10997 2019-04-18 Tom Tromey <tromey@adacore.com>
10998
10999 * process-stratum-target.h (class process_stratum_target)
11000 <stratum>: Add "final".
11001
11002 2019-04-17 Tom Tromey <tromey@adacore.com>
11003
11004 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11005 against nullptr before use.
11006
11007 2019-04-17 Alan Hayward <alan.hayward@arm.com>
11008
11009 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11010
11011 2019-04-17 Jim Wilson <jimw@sifive.com>
11012 Andrew Burgess <andrew.burgess@embecosm.com>
11013
11014 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11015 code read might fail, assume 4-byte breakpoint in that case.
11016
11017 2019-04-15 Leszek Swirski <leszeks@google.com>
11018
11019 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11020 rather than a hand-rolled POD check when checking for forced MEMORY
11021 classification.
11022
11023 2019-04-15 Alan Hayward <alan.hayward@arm.com>
11024
11025 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11026 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11027 function.
11028 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11029 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11030 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11031 declaration.
11032
11033 2019-04-15 Alan Hayward <alan.hayward@arm.com>
11034
11035 * aarch64-linux-nat.c
11036 (aarch64_linux_nat_target::thread_architecture): Add override.
11037 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11038 each VQ.
11039
11040 2019-04-15 Alan Hayward <alan.hayward@arm.com>
11041
11042 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11043
11044 2019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
11045
11046 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11047 target types of size 96-bits, add some additional comments, and
11048 check that the builtin type we found was the correct size.
11049
11050 2019-04-12 Eli Zaretskii <eliz@gnu.org>
11051
11052 * utils.c (prompt_for_continue): Don't restore the styling at the
11053 end, as applied_style has the wrong value. This fixes styling in
11054 long lists of file names that are interrupted by the "Continue?"
11055 prompt.
11056
11057 2019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
11058
11059 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11060 * c-lang.c (c_language_defn): Likewise.
11061 (cplus_language_defn): Likewise.
11062 (asm_language_defn): Likewise.
11063 (minimal_language_defn): Likewise.
11064 * d-lang.c (d_language_defn): Likewise.
11065 * f-lang.c (f_language_defn): Likewise.
11066 * go-lang.c (go_language_defn): Likewise.
11067 * language.c (unknown_language_defn): Likewise.
11068 (auto_language_defn): Likewise.
11069 * language.h (struct language_defn): Remove la_magic field.
11070 (LANG_MAGIC): Delete.
11071 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11072 * objc-lang.c (objc_language_defn): Likewise.
11073 * opencl-lang.c (opencl_language_defn): Likewise.
11074 * p-lang.c (pascal_language_defn): Likewise.
11075 * rust-lang.c (rust_language_defn): Likewise.
11076
11077 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11078
11079 * riscv-tdep.c (riscv_type_align): New function.
11080 (riscv_type_alignment): Delete.
11081 (riscv_arg_location): Use 'type_align'.
11082 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11083
11084 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11085
11086 * gdbtypes.c (type_align): A struct with no non-static fields also
11087 has alignment of 1.
11088
11089 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11090
11091 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11092 component to 0.
11093 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11094 member.
11095 (riscv_struct_info::analyse): New implementation using new
11096 analyse_inner member function.
11097 (riscv_struct_info::field_offset): New member function.
11098 (riscv_struct_info::m_offsets): New member variable.
11099 (riscv_struct_info::analyse_inner): New private member function,
11100 takes the old implementation of riscv_struct_info::analyse but
11101 extended to track field offsets.
11102 (riscv_call_arg_struct): Update the struct folding special cases
11103 to handle cases where empty C++ structs, which are non-zero
11104 length, are found.
11105 (riscv_arg_location): Initialise the length of each location, a
11106 non-zero length now indicates the location is in use.
11107 (riscv_push_dummy_call): Allow for the first location having a
11108 non-zero offset when setting up arguments.
11109 (riscv_return_value): Likewise, but for return values.
11110
11111 2019-04-11 Tom Tromey <tromey@adacore.com>
11112
11113 * utils.c (internal_vproblem): Make "msg" const.
11114
11115 2019-04-11 Alan Hayward <alan.hayward@arm.com>
11116
11117 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11118 * trad-frame.c (trad_frame_reset_saved_regs): New function.
11119 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11120 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11121
11122 2019-04-10 Kevin Buettner <kevinb@redhat.com>
11123
11124 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11125 function.
11126 (fill_gregset): Call amd64_linux_collect_native_gregset instead
11127 of amd64_collect_native_gregset.
11128 (amd64_linux_nat_target::store_registers): Likewise.
11129
11130 2019-04-10 Tom Tromey <tom@tromey.com>
11131
11132 * symtab.c (lookup_global_symbol_from_objfile)
11133 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11134 * objfiles.h (class separate_debug_iterator): New.
11135 (class separate_debug_range): New.
11136 (struct objfile) <separate_debug_objfiles>: New method.
11137 (objfile_separate_debug_iterate): Don't declare.
11138 * objfiles.c (separate_debug_iterator::operator++): Rename from
11139 objfile_separate_debug_iterate.
11140 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11141 iterator.
11142 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11143 iterator.
11144
11145 2019-04-10 Tom Tromey <tom@tromey.com>
11146
11147 * symfile.c (reread_symbols): Remove old comment.
11148 * objfiles.c (free_all_objfiles): Fix a typo.
11149
11150 2019-04-10 Tom Tromey <tom@tromey.com>
11151
11152 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11153 * minsyms.c (lookup_minimal_symbol): Use foreach.
11154 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11155 (lookup_minimal_symbol_solib_trampoline): Likewise.
11156 * symfile.c (reread_symbols): Use foreach.
11157
11158 2019-04-09 Ivan Begert <ivanbegert@gmail.com>
11159 Tom Tromey <tromey@adacore.com>
11160
11161 PR rust/24414:
11162 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11163 (rust_lex_int_test): Change "value" to be LONGEST.
11164 (rust_lex_tests): Add test for long integer literal.
11165
11166 2019-04-09 Tom Tromey <tromey@adacore.com>
11167
11168 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11169 to bool.
11170 (extended_remote_target::attach): Update.
11171 (remote_target::remote_notice_new_inferior): Update.
11172 (remote_target::add_current_inferior_and_thread): Update.
11173 * inferior.c (exit_inferior_1): Use "false".
11174 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11175
11176 2019-04-09 Simon Marchi <simon.marchi@efficios.com>
11177
11178 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
11179 the "start" command.
11180
11181 2019-04-08 Kevin Buettner <kevinb@redhat.com>
11182
11183 * python/py-inferior.c (infpy_thread_from_thread_handle):
11184 Adjust comments to reflect renaming of thread_from_thread_handle
11185 to thread_from_handle. Adjust keywords. Fix type error message.
11186 (inferior_object_methods): Add thread_from_handle. Retain
11187 thread_from_thread_handle, but mark it as deprecated.
11188
11189 2019-04-08 Kevin Buettner <kevinb@redhat.com>
11190
11191 * gdbthread.h (find_thread_by_handle): Revise declaration.
11192 * thread.c (find_thread_by_handle): Likewise. Adjust
11193 implementation too.
11194 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11195 support for buffer objects as handles.
11196
11197 2019-04-08 Kevin Buettner <kevinb@redhat.com>
11198
11199 * python/py-infthread.c (thpy_thread_handle): New function.
11200 (thread_object_methods): Register thpy_thread_handle.
11201
11202 2019-04-08 Kevin Buettner <kevinb@redhat.com>
11203
11204 * gdbthread.h (thread_to_thread_handle): Declare.
11205 * thread.c (gdbtypes.h): Include.
11206 (thread_to_thread_handle): New function.
11207
11208 * target.h (struct target_ops): Add thread_info_to_thread_handle.
11209 (target_thread_info_to_thread_handle): Declare.
11210 * target.c (target_thread_info_to_thread_handle): New function.
11211 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11212 * target-delegates.c: Regenerate.
11213
11214 * linux-thread-db.c (class thread_db_target): Add method
11215 thread_info_to_thread_handle.
11216 (thread_db_target::thread_info_to_thread_handle): Define.
11217 * remote.c (class remote_target): Add new method
11218 thread_info_to_thread_handle.
11219 (remote_target::thread_info_to_thread_handle): Define.
11220
11221 2019-04-08 Pedro Alves <palves@redhat.com>
11222
11223 * common/common-exceptions.c (throw_exception): Don't create
11224 named object to throw; throw directly.
11225 (throw_it): Likewise. Don't initialize gdb_exception::message
11226 here, with new; pass FMT and AP to the ctor instead.
11227 * common/common-exceptions.h: Include <string>.
11228 (gdb_exception::gdb_exception(enum return_reason, enum errors,
11229 const char *, va_list)): New ctor. Use std::make_shared.
11230 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11231 errors)): Delete.
11232 (gdb_exception_error::gdb_exception_error(enum errors, const char
11233 *, va_list)): New.
11234 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11235 Add assertion.
11236 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11237 errors)): Delete.
11238 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11239 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11240 Add assertion.
11241
11242 2019-04-08 Tom Tromey <tom@tromey.com>
11243
11244 * valops.c (value_rtti_indirect_type): Replace throw_exception
11245 with throw.
11246 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11247 with throw.
11248 * thread.c (thr_try_catch_cmd): Replace throw_exception with
11249 throw.
11250 * target.c (target_translate_tls_address): Replace throw_exception
11251 with throw.
11252 * stack.c (frame_apply_command_count): Replace throw_exception
11253 with throw.
11254 * solib-spu.c (append_ocl_sos): Replace throw_exception with
11255 throw.
11256 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11257 with throw.
11258 * rs6000-tdep.c (rs6000_frame_cache)
11259 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11260 * remote.c: Replace throw_exception with throw.
11261 * record-full.c (record_full_message, record_full_wait_1)
11262 (record_full_restore): Replace throw_exception with throw.
11263 * record-btrace.c:
11264 (get_thread_current_frame_id, record_btrace_start_replaying)
11265 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11266 (cmd_record_btrace_start): Replace throw_exception with throw.
11267 * parse.c (parse_exp_in_context_1): Replace throw_exception with
11268 throw.
11269 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11270 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
11271 * linespec.c:
11272 (find_linespec_symbols): Replace throw_exception with throw.
11273 * infrun.c (displaced_step_prepare, resume): Replace
11274 throw_exception with throw.
11275 * infcmd.c (post_create_inferior): Replace throw_exception with
11276 throw.
11277 * inf-loop.c (inferior_event_handler): Replace throw_exception
11278 with throw.
11279 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
11280 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
11281 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
11282 (get_prev_frame_always, get_frame_pc_if_available)
11283 (get_frame_address_in_block_if_available, get_frame_language):
11284 Replace throw_exception with throw.
11285 * frame-unwind.c (frame_unwind_try_unwinder): Replace
11286 throw_exception with throw.
11287 * eval.c (fetch_subexp_value, evaluate_var_value)
11288 (evaluate_funcall, evaluate_subexp_standard): Replace
11289 throw_exception with throw.
11290 * dwarf2loc.c (call_site_find_chain)
11291 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
11292 Replace throw_exception with throw.
11293 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
11294 with throw.
11295 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
11296 throw.
11297 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
11298 * completer.c (complete_line_internal): Replace throw_exception
11299 with throw.
11300 * compile/compile-object-run.c (compile_object_run): Replace
11301 throw_exception with throw.
11302 * cli/cli-script.c (process_next_line): Replace throw_exception
11303 with throw.
11304 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
11305 (btrace_enable, btrace_maint_update_pt_packets): Replace
11306 throw_exception with throw.
11307 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
11308 throw_exception with throw.
11309 * break-catch-throw.c (re_set_exception_catchpoint): Replace
11310 throw_exception with throw.
11311 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
11312 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
11313 * aarch64-tdep.c (aarch64_make_prologue_cache)
11314 (aarch64_make_stub_cache): Replace throw_exception with throw.
11315
11316 2019-04-08 Tom Tromey <tom@tromey.com>
11317
11318 * common/common-exceptions.c (throw_exception): Rename from
11319 throw_exception_cxx. Remove old copy. Make argument const.
11320 (throw_it): Create and throw exception objects directly.
11321 * common/common-exceptions.h (throw_exception): Make argument
11322 const.
11323 (struct gdb_exception_error): Add constructor.
11324 (struct gdb_exception_quit): Add constructor.
11325
11326 2019-04-08 Tom Tromey <tom@tromey.com>
11327
11328 * common/common-exceptions.h (exception_rethrow): Don't declare.
11329 (TRY_SJLJ): Update comment.
11330 (TRY, CATCH, END_CATCH): Remove.
11331 * common/common-exceptions.c (exception_rethrow): Remove.
11332
11333 2019-04-08 Tom Tromey <tom@tromey.com>
11334
11335 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
11336 Remove.
11337 (gdb_exception_error): Rename from
11338 gdb_exception_RETURN_MASK_ERROR.
11339 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
11340 (gdb_quit_bad_alloc): Update.
11341 * aarch64-tdep.c: Update.
11342 * ada-lang.c: Update.
11343 * ada-typeprint.c: Update.
11344 * ada-valprint.c: Update.
11345 * amd64-tdep.c: Update.
11346 * arch-utils.c: Update.
11347 * break-catch-throw.c: Update.
11348 * breakpoint.c: Update.
11349 * btrace.c: Update.
11350 * c-varobj.c: Update.
11351 * cli/cli-cmds.c: Update.
11352 * cli/cli-interp.c: Update.
11353 * cli/cli-script.c: Update.
11354 * common/common-exceptions.c: Update.
11355 * common/new-op.c: Update.
11356 * common/selftest.c: Update.
11357 * compile/compile-c-symbols.c: Update.
11358 * compile/compile-cplus-symbols.c: Update.
11359 * compile/compile-object-load.c: Update.
11360 * compile/compile-object-run.c: Update.
11361 * completer.c: Update.
11362 * corelow.c: Update.
11363 * cp-abi.c: Update.
11364 * cp-support.c: Update.
11365 * cp-valprint.c: Update.
11366 * darwin-nat.c: Update.
11367 * disasm-selftests.c: Update.
11368 * dtrace-probe.c: Update.
11369 * dwarf-index-cache.c: Update.
11370 * dwarf-index-write.c: Update.
11371 * dwarf2-frame-tailcall.c: Update.
11372 * dwarf2-frame.c: Update.
11373 * dwarf2loc.c: Update.
11374 * dwarf2read.c: Update.
11375 * eval.c: Update.
11376 * event-loop.c: Update.
11377 * event-top.c: Update.
11378 * exec.c: Update.
11379 * f-valprint.c: Update.
11380 * fbsd-tdep.c: Update.
11381 * frame-unwind.c: Update.
11382 * frame.c: Update.
11383 * gdbtypes.c: Update.
11384 * gnu-v3-abi.c: Update.
11385 * guile/guile-internal.h: Update.
11386 * guile/scm-block.c: Update.
11387 * guile/scm-breakpoint.c: Update.
11388 * guile/scm-cmd.c: Update.
11389 * guile/scm-disasm.c: Update.
11390 * guile/scm-frame.c: Update.
11391 * guile/scm-lazy-string.c: Update.
11392 * guile/scm-math.c: Update.
11393 * guile/scm-param.c: Update.
11394 * guile/scm-ports.c: Update.
11395 * guile/scm-pretty-print.c: Update.
11396 * guile/scm-symbol.c: Update.
11397 * guile/scm-symtab.c: Update.
11398 * guile/scm-type.c: Update.
11399 * guile/scm-value.c: Update.
11400 * i386-linux-tdep.c: Update.
11401 * i386-tdep.c: Update.
11402 * inf-loop.c: Update.
11403 * infcall.c: Update.
11404 * infcmd.c: Update.
11405 * infrun.c: Update.
11406 * jit.c: Update.
11407 * language.c: Update.
11408 * linespec.c: Update.
11409 * linux-fork.c: Update.
11410 * linux-nat.c: Update.
11411 * linux-tdep.c: Update.
11412 * linux-thread-db.c: Update.
11413 * main.c: Update.
11414 * mi/mi-cmd-break.c: Update.
11415 * mi/mi-cmd-stack.c: Update.
11416 * mi/mi-interp.c: Update.
11417 * mi/mi-main.c: Update.
11418 * objc-lang.c: Update.
11419 * p-valprint.c: Update.
11420 * parse.c: Update.
11421 * ppc-linux-tdep.c: Update.
11422 * printcmd.c: Update.
11423 * python/py-arch.c: Update.
11424 * python/py-breakpoint.c: Update.
11425 * python/py-cmd.c: Update.
11426 * python/py-finishbreakpoint.c: Update.
11427 * python/py-frame.c: Update.
11428 * python/py-framefilter.c: Update.
11429 * python/py-gdb-readline.c: Update.
11430 * python/py-inferior.c: Update.
11431 * python/py-infthread.c: Update.
11432 * python/py-lazy-string.c: Update.
11433 * python/py-linetable.c: Update.
11434 * python/py-objfile.c: Update.
11435 * python/py-param.c: Update.
11436 * python/py-prettyprint.c: Update.
11437 * python/py-progspace.c: Update.
11438 * python/py-record-btrace.c: Update.
11439 * python/py-record.c: Update.
11440 * python/py-symbol.c: Update.
11441 * python/py-type.c: Update.
11442 * python/py-unwind.c: Update.
11443 * python/py-utils.c: Update.
11444 * python/py-value.c: Update.
11445 * python/python.c: Update.
11446 * record-btrace.c: Update.
11447 * record-full.c: Update.
11448 * remote-fileio.c: Update.
11449 * remote.c: Update.
11450 * riscv-tdep.c: Update.
11451 * rs6000-aix-tdep.c: Update.
11452 * rs6000-tdep.c: Update.
11453 * rust-exp.y: Update.
11454 * rust-lang.c: Update.
11455 * s390-tdep.c: Update.
11456 * selftest-arch.c: Update.
11457 * solib-dsbt.c: Update.
11458 * solib-frv.c: Update.
11459 * solib-spu.c: Update.
11460 * solib-svr4.c: Update.
11461 * solib.c: Update.
11462 * sparc64-linux-tdep.c: Update.
11463 * stack.c: Update.
11464 * symfile-mem.c: Update.
11465 * symmisc.c: Update.
11466 * target.c: Update.
11467 * thread.c: Update.
11468 * top.c: Update.
11469 * tracefile-tfile.c: Update.
11470 * tui/tui.c: Update.
11471 * typeprint.c: Update.
11472 * unittests/cli-utils-selftests.c: Update.
11473 * unittests/parse-connection-spec-selftests.c: Update.
11474 * valops.c: Update.
11475 * valprint.c: Update.
11476 * value.c: Update.
11477 * varobj.c: Update.
11478 * windows-nat.c: Update.
11479 * x86-linux-nat.c: Update.
11480 * xml-support.c: Update.
11481
11482 2019-04-08 Tom Tromey <tom@tromey.com>
11483
11484 * xml-support.c: Use C++ exception handling.
11485 * x86-linux-nat.c: Use C++ exception handling.
11486 * windows-nat.c: Use C++ exception handling.
11487 * varobj.c: Use C++ exception handling.
11488 * value.c: Use C++ exception handling.
11489 * valprint.c: Use C++ exception handling.
11490 * valops.c: Use C++ exception handling.
11491 * unittests/parse-connection-spec-selftests.c: Use C++ exception
11492 handling.
11493 * unittests/cli-utils-selftests.c: Use C++ exception handling.
11494 * typeprint.c: Use C++ exception handling.
11495 * tui/tui.c: Use C++ exception handling.
11496 * tracefile-tfile.c: Use C++ exception handling.
11497 * top.c: Use C++ exception handling.
11498 * thread.c: Use C++ exception handling.
11499 * target.c: Use C++ exception handling.
11500 * symmisc.c: Use C++ exception handling.
11501 * symfile-mem.c: Use C++ exception handling.
11502 * stack.c: Use C++ exception handling.
11503 * sparc64-linux-tdep.c: Use C++ exception handling.
11504 * solib.c: Use C++ exception handling.
11505 * solib-svr4.c: Use C++ exception handling.
11506 * solib-spu.c: Use C++ exception handling.
11507 * solib-frv.c: Use C++ exception handling.
11508 * solib-dsbt.c: Use C++ exception handling.
11509 * selftest-arch.c: Use C++ exception handling.
11510 * s390-tdep.c: Use C++ exception handling.
11511 * rust-lang.c: Use C++ exception handling.
11512 * rust-exp.y: Use C++ exception handling.
11513 * rs6000-tdep.c: Use C++ exception handling.
11514 * rs6000-aix-tdep.c: Use C++ exception handling.
11515 * riscv-tdep.c: Use C++ exception handling.
11516 * remote.c: Use C++ exception handling.
11517 * remote-fileio.c: Use C++ exception handling.
11518 * record-full.c: Use C++ exception handling.
11519 * record-btrace.c: Use C++ exception handling.
11520 * python/python.c: Use C++ exception handling.
11521 * python/py-value.c: Use C++ exception handling.
11522 * python/py-utils.c: Use C++ exception handling.
11523 * python/py-unwind.c: Use C++ exception handling.
11524 * python/py-type.c: Use C++ exception handling.
11525 * python/py-symbol.c: Use C++ exception handling.
11526 * python/py-record.c: Use C++ exception handling.
11527 * python/py-record-btrace.c: Use C++ exception handling.
11528 * python/py-progspace.c: Use C++ exception handling.
11529 * python/py-prettyprint.c: Use C++ exception handling.
11530 * python/py-param.c: Use C++ exception handling.
11531 * python/py-objfile.c: Use C++ exception handling.
11532 * python/py-linetable.c: Use C++ exception handling.
11533 * python/py-lazy-string.c: Use C++ exception handling.
11534 * python/py-infthread.c: Use C++ exception handling.
11535 * python/py-inferior.c: Use C++ exception handling.
11536 * python/py-gdb-readline.c: Use C++ exception handling.
11537 * python/py-framefilter.c: Use C++ exception handling.
11538 * python/py-frame.c: Use C++ exception handling.
11539 * python/py-finishbreakpoint.c: Use C++ exception handling.
11540 * python/py-cmd.c: Use C++ exception handling.
11541 * python/py-breakpoint.c: Use C++ exception handling.
11542 * python/py-arch.c: Use C++ exception handling.
11543 * printcmd.c: Use C++ exception handling.
11544 * ppc-linux-tdep.c: Use C++ exception handling.
11545 * parse.c: Use C++ exception handling.
11546 * p-valprint.c: Use C++ exception handling.
11547 * objc-lang.c: Use C++ exception handling.
11548 * mi/mi-main.c: Use C++ exception handling.
11549 * mi/mi-interp.c: Use C++ exception handling.
11550 * mi/mi-cmd-stack.c: Use C++ exception handling.
11551 * mi/mi-cmd-break.c: Use C++ exception handling.
11552 * main.c: Use C++ exception handling.
11553 * linux-thread-db.c: Use C++ exception handling.
11554 * linux-tdep.c: Use C++ exception handling.
11555 * linux-nat.c: Use C++ exception handling.
11556 * linux-fork.c: Use C++ exception handling.
11557 * linespec.c: Use C++ exception handling.
11558 * language.c: Use C++ exception handling.
11559 * jit.c: Use C++ exception handling.
11560 * infrun.c: Use C++ exception handling.
11561 * infcmd.c: Use C++ exception handling.
11562 * infcall.c: Use C++ exception handling.
11563 * inf-loop.c: Use C++ exception handling.
11564 * i386-tdep.c: Use C++ exception handling.
11565 * i386-linux-tdep.c: Use C++ exception handling.
11566 * guile/scm-value.c: Use C++ exception handling.
11567 * guile/scm-type.c: Use C++ exception handling.
11568 * guile/scm-symtab.c: Use C++ exception handling.
11569 * guile/scm-symbol.c: Use C++ exception handling.
11570 * guile/scm-pretty-print.c: Use C++ exception handling.
11571 * guile/scm-ports.c: Use C++ exception handling.
11572 * guile/scm-param.c: Use C++ exception handling.
11573 * guile/scm-math.c: Use C++ exception handling.
11574 * guile/scm-lazy-string.c: Use C++ exception handling.
11575 * guile/scm-frame.c: Use C++ exception handling.
11576 * guile/scm-disasm.c: Use C++ exception handling.
11577 * guile/scm-cmd.c: Use C++ exception handling.
11578 * guile/scm-breakpoint.c: Use C++ exception handling.
11579 * guile/scm-block.c: Use C++ exception handling.
11580 * guile/guile-internal.h: Use C++ exception handling.
11581 * gnu-v3-abi.c: Use C++ exception handling.
11582 * gdbtypes.c: Use C++ exception handling.
11583 * frame.c: Use C++ exception handling.
11584 * frame-unwind.c: Use C++ exception handling.
11585 * fbsd-tdep.c: Use C++ exception handling.
11586 * f-valprint.c: Use C++ exception handling.
11587 * exec.c: Use C++ exception handling.
11588 * event-top.c: Use C++ exception handling.
11589 * event-loop.c: Use C++ exception handling.
11590 * eval.c: Use C++ exception handling.
11591 * dwarf2read.c: Use C++ exception handling.
11592 * dwarf2loc.c: Use C++ exception handling.
11593 * dwarf2-frame.c: Use C++ exception handling.
11594 * dwarf2-frame-tailcall.c: Use C++ exception handling.
11595 * dwarf-index-write.c: Use C++ exception handling.
11596 * dwarf-index-cache.c: Use C++ exception handling.
11597 * dtrace-probe.c: Use C++ exception handling.
11598 * disasm-selftests.c: Use C++ exception handling.
11599 * darwin-nat.c: Use C++ exception handling.
11600 * cp-valprint.c: Use C++ exception handling.
11601 * cp-support.c: Use C++ exception handling.
11602 * cp-abi.c: Use C++ exception handling.
11603 * corelow.c: Use C++ exception handling.
11604 * completer.c: Use C++ exception handling.
11605 * compile/compile-object-run.c: Use C++ exception handling.
11606 * compile/compile-object-load.c: Use C++ exception handling.
11607 * compile/compile-cplus-symbols.c: Use C++ exception handling.
11608 * compile/compile-c-symbols.c: Use C++ exception handling.
11609 * common/selftest.c: Use C++ exception handling.
11610 * common/new-op.c: Use C++ exception handling.
11611 * cli/cli-script.c: Use C++ exception handling.
11612 * cli/cli-interp.c: Use C++ exception handling.
11613 * cli/cli-cmds.c: Use C++ exception handling.
11614 * c-varobj.c: Use C++ exception handling.
11615 * btrace.c: Use C++ exception handling.
11616 * breakpoint.c: Use C++ exception handling.
11617 * break-catch-throw.c: Use C++ exception handling.
11618 * arch-utils.c: Use C++ exception handling.
11619 * amd64-tdep.c: Use C++ exception handling.
11620 * ada-valprint.c: Use C++ exception handling.
11621 * ada-typeprint.c: Use C++ exception handling.
11622 * ada-lang.c: Use C++ exception handling.
11623 * aarch64-tdep.c: Use C++ exception handling.
11624
11625 2019-04-08 Tom Tromey <tom@tromey.com>
11626
11627 * xml-support.c (gdb_xml_parser::parse): Update.
11628 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11629 * value.c (show_convenience): Update.
11630 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
11631 (test_parse_flags_qcs): Update.
11632 * thread.c (thr_try_catch_cmd): Update.
11633 * target.c (target_translate_tls_address): Update.
11634 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
11635 (info_frame_command_core, frame_apply_command_count): Update.
11636 * rust-exp.y (rust_lex_exception_test): Update.
11637 * riscv-tdep.c (riscv_print_one_register_info): Update.
11638 * remote.c (remote_target::enable_btrace): Update.
11639 * record-btrace.c (record_btrace_enable_warn): Update.
11640 * python/py-utils.c (gdbpy_convert_exception): Update.
11641 * printcmd.c (do_one_display, print_variable_and_value): Update.
11642 * mi/mi-main.c (mi_print_exception): Update.
11643 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
11644 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
11645 * linux-nat.c (linux_nat_target::attach): Update.
11646 * linux-fork.c (class scoped_switch_fork_info): Update.
11647 * infrun.c (displaced_step_prepare): Update.
11648 * infcall.c (call_function_by_hand_dummy): Update.
11649 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
11650 * gnu-v3-abi.c (print_one_vtable): Update.
11651 * frame.c (get_prev_frame_always): Update.
11652 * f-valprint.c (info_common_command_for_block): Update.
11653 * exec.c (try_open_exec_file): Update.
11654 * exceptions.c (print_exception, exception_print)
11655 (exception_fprintf, exception_print_same): Update.
11656 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
11657 * dwarf-index-cache.c (index_cache::store)
11658 (index_cache::lookup_gdb_index): Update.
11659 * darwin-nat.c (maybe_cache_shell): Update.
11660 * cp-valprint.c (cp_print_value_fields): Update.
11661 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
11662 (gcc_cplus_symbol_address): Update.
11663 * compile/compile-c-symbols.c (gcc_convert_symbol)
11664 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
11665 * common/selftest.c: Update.
11666 * common/common-exceptions.h (struct gdb_exception) <message>: Now
11667 a std::string.
11668 (exception_try_scope_entry, exception_try_scope_exit): Don't
11669 declare.
11670 (struct exception_try_scope): Remove.
11671 (TRY): Don't use exception_try_scope.
11672 (struct gdb_exception): Add constructor, operator=.
11673 <what>: New method.
11674 (struct gdb_exception_RETURN_MASK_ALL)
11675 (struct gdb_exception_RETURN_MASK_ERROR)
11676 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
11677 (struct gdb_quit_bad_alloc): Update.
11678 * common/common-exceptions.c (exception_none): Change
11679 initializer.
11680 (struct catcher) <state, exception>: Initialize inline.
11681 <prev>: Remove member.
11682 (current_catcher): Remove.
11683 (catchers): New global.
11684 (exceptions_state_mc_init): Simplify.
11685 (catcher_pop): Remove.
11686 (exceptions_state_mc, exceptions_state_mc_catch): Update.
11687 (try_scope_depth, exception_try_scope_entry)
11688 (exception_try_scope_exit): Remove.
11689 (throw_exception_sjlj): Update.
11690 (exception_messages, exception_messages_size): Remove.
11691 (throw_it): Simplify.
11692 (gdb_exception_sliced_copy): Remove.
11693 (throw_exception_cxx): Update.
11694 * cli/cli-script.c (script_from_file): Update.
11695 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
11696 Update.
11697 * ada-valprint.c (ada_val_print): Update.
11698 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
11699 (create_excep_cond_exprs): Update.
11700
11701 2019-04-08 Tom Tromey <tom@tromey.com>
11702
11703 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
11704 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
11705 (TRY, CATCH, END_CATCH): Remove some definitions.
11706 * common/common-exceptions.c: Don't use GDB_XCPT.
11707 (catcher_list_size): Remove.
11708 (throw_exception, throw_it): Simplify.
11709
11710 2019-04-05 Tom Tromey <tom@tromey.com>
11711
11712 Revert the header-sorting patch.
11713 * ft32-tdep.c: Revert.
11714 * frv-tdep.c: Revert.
11715 * frv-linux-tdep.c: Revert.
11716 * frame.c: Revert.
11717 * frame-unwind.c: Revert.
11718 * frame-base.c: Revert.
11719 * fork-child.c: Revert.
11720 * findvar.c: Revert.
11721 * findcmd.c: Revert.
11722 * filesystem.c: Revert.
11723 * filename-seen-cache.h: Revert.
11724 * filename-seen-cache.c: Revert.
11725 * fbsd-tdep.c: Revert.
11726 * fbsd-nat.h: Revert.
11727 * fbsd-nat.c: Revert.
11728 * f-valprint.c: Revert.
11729 * f-typeprint.c: Revert.
11730 * f-lang.c: Revert.
11731 * extension.h: Revert.
11732 * extension.c: Revert.
11733 * extension-priv.h: Revert.
11734 * expprint.c: Revert.
11735 * exec.h: Revert.
11736 * exec.c: Revert.
11737 * exceptions.c: Revert.
11738 * event-top.c: Revert.
11739 * event-loop.c: Revert.
11740 * eval.c: Revert.
11741 * elfread.c: Revert.
11742 * dwarf2read.h: Revert.
11743 * dwarf2read.c: Revert.
11744 * dwarf2loc.c: Revert.
11745 * dwarf2expr.h: Revert.
11746 * dwarf2expr.c: Revert.
11747 * dwarf2-frame.c: Revert.
11748 * dwarf2-frame-tailcall.c: Revert.
11749 * dwarf-index-write.h: Revert.
11750 * dwarf-index-write.c: Revert.
11751 * dwarf-index-common.c: Revert.
11752 * dwarf-index-cache.h: Revert.
11753 * dwarf-index-cache.c: Revert.
11754 * dummy-frame.c: Revert.
11755 * dtrace-probe.c: Revert.
11756 * disasm.h: Revert.
11757 * disasm.c: Revert.
11758 * disasm-selftests.c: Revert.
11759 * dictionary.c: Revert.
11760 * dicos-tdep.c: Revert.
11761 * demangle.c: Revert.
11762 * dcache.h: Revert.
11763 * dcache.c: Revert.
11764 * darwin-nat.h: Revert.
11765 * darwin-nat.c: Revert.
11766 * darwin-nat-info.c: Revert.
11767 * d-valprint.c: Revert.
11768 * d-namespace.c: Revert.
11769 * d-lang.c: Revert.
11770 * ctf.c: Revert.
11771 * csky-tdep.c: Revert.
11772 * csky-linux-tdep.c: Revert.
11773 * cris-tdep.c: Revert.
11774 * cris-linux-tdep.c: Revert.
11775 * cp-valprint.c: Revert.
11776 * cp-support.c: Revert.
11777 * cp-namespace.c: Revert.
11778 * cp-abi.c: Revert.
11779 * corelow.c: Revert.
11780 * corefile.c: Revert.
11781 * continuations.c: Revert.
11782 * completer.h: Revert.
11783 * completer.c: Revert.
11784 * complaints.c: Revert.
11785 * coffread.c: Revert.
11786 * coff-pe-read.c: Revert.
11787 * cli-out.h: Revert.
11788 * cli-out.c: Revert.
11789 * charset.c: Revert.
11790 * c-varobj.c: Revert.
11791 * c-valprint.c: Revert.
11792 * c-typeprint.c: Revert.
11793 * c-lang.c: Revert.
11794 * buildsym.c: Revert.
11795 * buildsym-legacy.c: Revert.
11796 * build-id.h: Revert.
11797 * build-id.c: Revert.
11798 * btrace.c: Revert.
11799 * bsd-uthread.c: Revert.
11800 * breakpoint.h: Revert.
11801 * breakpoint.c: Revert.
11802 * break-catch-throw.c: Revert.
11803 * break-catch-syscall.c: Revert.
11804 * break-catch-sig.c: Revert.
11805 * blockframe.c: Revert.
11806 * block.c: Revert.
11807 * bfin-tdep.c: Revert.
11808 * bfin-linux-tdep.c: Revert.
11809 * bfd-target.c: Revert.
11810 * bcache.c: Revert.
11811 * ax-general.c: Revert.
11812 * ax-gdb.h: Revert.
11813 * ax-gdb.c: Revert.
11814 * avr-tdep.c: Revert.
11815 * auxv.c: Revert.
11816 * auto-load.c: Revert.
11817 * arm-wince-tdep.c: Revert.
11818 * arm-tdep.c: Revert.
11819 * arm-symbian-tdep.c: Revert.
11820 * arm-pikeos-tdep.c: Revert.
11821 * arm-obsd-tdep.c: Revert.
11822 * arm-nbsd-tdep.c: Revert.
11823 * arm-nbsd-nat.c: Revert.
11824 * arm-linux-tdep.c: Revert.
11825 * arm-linux-nat.c: Revert.
11826 * arm-fbsd-tdep.c: Revert.
11827 * arm-fbsd-nat.c: Revert.
11828 * arm-bsd-tdep.c: Revert.
11829 * arch-utils.c: Revert.
11830 * arc-tdep.c: Revert.
11831 * arc-newlib-tdep.c: Revert.
11832 * annotate.h: Revert.
11833 * annotate.c: Revert.
11834 * amd64-windows-tdep.c: Revert.
11835 * amd64-windows-nat.c: Revert.
11836 * amd64-tdep.c: Revert.
11837 * amd64-sol2-tdep.c: Revert.
11838 * amd64-obsd-tdep.c: Revert.
11839 * amd64-obsd-nat.c: Revert.
11840 * amd64-nbsd-tdep.c: Revert.
11841 * amd64-nbsd-nat.c: Revert.
11842 * amd64-nat.c: Revert.
11843 * amd64-linux-tdep.c: Revert.
11844 * amd64-linux-nat.c: Revert.
11845 * amd64-fbsd-tdep.c: Revert.
11846 * amd64-fbsd-nat.c: Revert.
11847 * amd64-dicos-tdep.c: Revert.
11848 * amd64-darwin-tdep.c: Revert.
11849 * amd64-bsd-nat.c: Revert.
11850 * alpha-tdep.c: Revert.
11851 * alpha-obsd-tdep.c: Revert.
11852 * alpha-nbsd-tdep.c: Revert.
11853 * alpha-mdebug-tdep.c: Revert.
11854 * alpha-linux-tdep.c: Revert.
11855 * alpha-linux-nat.c: Revert.
11856 * alpha-bsd-tdep.c: Revert.
11857 * alpha-bsd-nat.c: Revert.
11858 * aix-thread.c: Revert.
11859 * agent.c: Revert.
11860 * addrmap.c: Revert.
11861 * ada-varobj.c: Revert.
11862 * ada-valprint.c: Revert.
11863 * ada-typeprint.c: Revert.
11864 * ada-tasks.c: Revert.
11865 * ada-lang.c: Revert.
11866 * aarch64-tdep.c: Revert.
11867 * aarch64-ravenscar-thread.c: Revert.
11868 * aarch64-newlib-tdep.c: Revert.
11869 * aarch64-linux-tdep.c: Revert.
11870 * aarch64-linux-nat.c: Revert.
11871 * aarch64-fbsd-tdep.c: Revert.
11872 * aarch64-fbsd-nat.c: Revert.
11873 * aarch32-linux-nat.c: Revert.
11874
11875 2019-04-05 Tom Tromey <tom@tromey.com>
11876
11877 * ft32-tdep.c: Sort headers.
11878 * frv-tdep.c: Sort headers.
11879 * frv-linux-tdep.c: Sort headers.
11880 * frame.c: Sort headers.
11881 * frame-unwind.c: Sort headers.
11882 * frame-base.c: Sort headers.
11883 * fork-child.c: Sort headers.
11884 * findvar.c: Sort headers.
11885 * findcmd.c: Sort headers.
11886 * filesystem.c: Sort headers.
11887 * filename-seen-cache.h: Sort headers.
11888 * filename-seen-cache.c: Sort headers.
11889 * fbsd-tdep.c: Sort headers.
11890 * fbsd-nat.h: Sort headers.
11891 * fbsd-nat.c: Sort headers.
11892 * f-valprint.c: Sort headers.
11893 * f-typeprint.c: Sort headers.
11894 * f-lang.c: Sort headers.
11895 * extension.h: Sort headers.
11896 * extension.c: Sort headers.
11897 * extension-priv.h: Sort headers.
11898 * expprint.c: Sort headers.
11899 * exec.h: Sort headers.
11900 * exec.c: Sort headers.
11901 * exceptions.c: Sort headers.
11902 * event-top.c: Sort headers.
11903 * event-loop.c: Sort headers.
11904 * eval.c: Sort headers.
11905 * elfread.c: Sort headers.
11906 * dwarf2read.h: Sort headers.
11907 * dwarf2read.c: Sort headers.
11908 * dwarf2loc.c: Sort headers.
11909 * dwarf2expr.h: Sort headers.
11910 * dwarf2expr.c: Sort headers.
11911 * dwarf2-frame.c: Sort headers.
11912 * dwarf2-frame-tailcall.c: Sort headers.
11913 * dwarf-index-write.h: Sort headers.
11914 * dwarf-index-write.c: Sort headers.
11915 * dwarf-index-common.c: Sort headers.
11916 * dwarf-index-cache.h: Sort headers.
11917 * dwarf-index-cache.c: Sort headers.
11918 * dummy-frame.c: Sort headers.
11919 * dtrace-probe.c: Sort headers.
11920 * disasm.h: Sort headers.
11921 * disasm.c: Sort headers.
11922 * disasm-selftests.c: Sort headers.
11923 * dictionary.c: Sort headers.
11924 * dicos-tdep.c: Sort headers.
11925 * demangle.c: Sort headers.
11926 * dcache.h: Sort headers.
11927 * dcache.c: Sort headers.
11928 * darwin-nat.h: Sort headers.
11929 * darwin-nat.c: Sort headers.
11930 * darwin-nat-info.c: Sort headers.
11931 * d-valprint.c: Sort headers.
11932 * d-namespace.c: Sort headers.
11933 * d-lang.c: Sort headers.
11934 * ctf.c: Sort headers.
11935 * csky-tdep.c: Sort headers.
11936 * csky-linux-tdep.c: Sort headers.
11937 * cris-tdep.c: Sort headers.
11938 * cris-linux-tdep.c: Sort headers.
11939 * cp-valprint.c: Sort headers.
11940 * cp-support.c: Sort headers.
11941 * cp-namespace.c: Sort headers.
11942 * cp-abi.c: Sort headers.
11943 * corelow.c: Sort headers.
11944 * corefile.c: Sort headers.
11945 * continuations.c: Sort headers.
11946 * completer.h: Sort headers.
11947 * completer.c: Sort headers.
11948 * complaints.c: Sort headers.
11949 * coffread.c: Sort headers.
11950 * coff-pe-read.c: Sort headers.
11951 * cli-out.h: Sort headers.
11952 * cli-out.c: Sort headers.
11953 * charset.c: Sort headers.
11954 * c-varobj.c: Sort headers.
11955 * c-valprint.c: Sort headers.
11956 * c-typeprint.c: Sort headers.
11957 * c-lang.c: Sort headers.
11958 * buildsym.c: Sort headers.
11959 * buildsym-legacy.c: Sort headers.
11960 * build-id.h: Sort headers.
11961 * build-id.c: Sort headers.
11962 * btrace.c: Sort headers.
11963 * bsd-uthread.c: Sort headers.
11964 * breakpoint.h: Sort headers.
11965 * breakpoint.c: Sort headers.
11966 * break-catch-throw.c: Sort headers.
11967 * break-catch-syscall.c: Sort headers.
11968 * break-catch-sig.c: Sort headers.
11969 * blockframe.c: Sort headers.
11970 * block.c: Sort headers.
11971 * bfin-tdep.c: Sort headers.
11972 * bfin-linux-tdep.c: Sort headers.
11973 * bfd-target.c: Sort headers.
11974 * bcache.c: Sort headers.
11975 * ax-general.c: Sort headers.
11976 * ax-gdb.h: Sort headers.
11977 * ax-gdb.c: Sort headers.
11978 * avr-tdep.c: Sort headers.
11979 * auxv.c: Sort headers.
11980 * auto-load.c: Sort headers.
11981 * arm-wince-tdep.c: Sort headers.
11982 * arm-tdep.c: Sort headers.
11983 * arm-symbian-tdep.c: Sort headers.
11984 * arm-pikeos-tdep.c: Sort headers.
11985 * arm-obsd-tdep.c: Sort headers.
11986 * arm-nbsd-tdep.c: Sort headers.
11987 * arm-nbsd-nat.c: Sort headers.
11988 * arm-linux-tdep.c: Sort headers.
11989 * arm-linux-nat.c: Sort headers.
11990 * arm-fbsd-tdep.c: Sort headers.
11991 * arm-fbsd-nat.c: Sort headers.
11992 * arm-bsd-tdep.c: Sort headers.
11993 * arch-utils.c: Sort headers.
11994 * arc-tdep.c: Sort headers.
11995 * arc-newlib-tdep.c: Sort headers.
11996 * annotate.h: Sort headers.
11997 * annotate.c: Sort headers.
11998 * amd64-windows-tdep.c: Sort headers.
11999 * amd64-windows-nat.c: Sort headers.
12000 * amd64-tdep.c: Sort headers.
12001 * amd64-sol2-tdep.c: Sort headers.
12002 * amd64-obsd-tdep.c: Sort headers.
12003 * amd64-obsd-nat.c: Sort headers.
12004 * amd64-nbsd-tdep.c: Sort headers.
12005 * amd64-nbsd-nat.c: Sort headers.
12006 * amd64-nat.c: Sort headers.
12007 * amd64-linux-tdep.c: Sort headers.
12008 * amd64-linux-nat.c: Sort headers.
12009 * amd64-fbsd-tdep.c: Sort headers.
12010 * amd64-fbsd-nat.c: Sort headers.
12011 * amd64-dicos-tdep.c: Sort headers.
12012 * amd64-darwin-tdep.c: Sort headers.
12013 * amd64-bsd-nat.c: Sort headers.
12014 * alpha-tdep.c: Sort headers.
12015 * alpha-obsd-tdep.c: Sort headers.
12016 * alpha-nbsd-tdep.c: Sort headers.
12017 * alpha-mdebug-tdep.c: Sort headers.
12018 * alpha-linux-tdep.c: Sort headers.
12019 * alpha-linux-nat.c: Sort headers.
12020 * alpha-bsd-tdep.c: Sort headers.
12021 * alpha-bsd-nat.c: Sort headers.
12022 * aix-thread.c: Sort headers.
12023 * agent.c: Sort headers.
12024 * addrmap.c: Sort headers.
12025 * ada-varobj.c: Sort headers.
12026 * ada-valprint.c: Sort headers.
12027 * ada-typeprint.c: Sort headers.
12028 * ada-tasks.c: Sort headers.
12029 * ada-lang.c: Sort headers.
12030 * aarch64-tdep.c: Sort headers.
12031 * aarch64-ravenscar-thread.c: Sort headers.
12032 * aarch64-newlib-tdep.c: Sort headers.
12033 * aarch64-linux-tdep.c: Sort headers.
12034 * aarch64-linux-nat.c: Sort headers.
12035 * aarch64-fbsd-tdep.c: Sort headers.
12036 * aarch64-fbsd-nat.c: Sort headers.
12037 * aarch32-linux-nat.c: Sort headers.
12038
12039 2019-04-04 Tom Tromey <tom@tromey.com>
12040
12041 * varobj.c (varobj_create): Update.
12042 * rust-exp.y (struct rust_parser) <update_innermost_block,
12043 lookup_symbol>: New methods.
12044 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12045 Rename.
12046 (rust_parser::rust_lookup_type)
12047 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12048 * printcmd.c (display_command, do_one_display): Update.
12049 * parser-defs.h (struct parser_state) <parser_state>: Add
12050 "tracker" parameter.
12051 (block_tracker): New member.
12052 (class innermost_block_tracker) <innermost_block_tracker>: Add
12053 "types" parameter.
12054 <reset>: Remove method.
12055 (innermost_block): Don't declare.
12056 (null_post_parser): Update.
12057 * parse.c (innermost_block): Remove global.
12058 (write_dollar_variable): Update.
12059 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12060 Remove "tracker_types" parameter.
12061 (parse_expression): Add "tracker" parameter.
12062 (parse_expression_for_completion): Update.
12063 (null_post_parser): Add "tracker" parameter.
12064 * p-exp.y: Update rules.
12065 * m2-exp.y: Update rules.
12066 * language.h (struct language_defn) <la_post_parser>: Add
12067 "tracker" parameter.
12068 * go-exp.y: Update rules.
12069 * f-exp.y: Update rules.
12070 * expression.h (parse_expression, parse_exp_1): Add "tracker"
12071 parameter.
12072 * d-exp.y: Update rules.
12073 * c-exp.y: Update rules.
12074 * breakpoint.c (set_breakpoint_condition): Create an
12075 innermost_block_tracker.
12076 (watch_command_1): Likewise.
12077 * ada-lang.c (resolve): Add "tracker" parameter.
12078 (resolve_subexp): Likewise.
12079 * ada-exp.y (write_var_from_sym): Update.
12080
12081 2019-04-04 Tom Tromey <tom@tromey.com>
12082
12083 * type-stack.h: New file.
12084 * type-stack.c: New file.
12085 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12086 type-stack.h.
12087 (insert_into_type_stack, insert_type, push_type, push_type_int)
12088 (insert_type_address_space, pop_type, pop_type_int)
12089 (pop_typelist, pop_type_stack, append_type_stack)
12090 (push_type_stack, get_type_stack, push_typelist)
12091 (follow_type_instance_flags, follow_types): Don't declare.
12092 * parse.c (type_stack): Remove global.
12093 (parse_exp_in_context): Update.
12094 (insert_into_type_stack, insert_type, push_type, push_type_int)
12095 (insert_type_address_space, pop_type, pop_type_int)
12096 (pop_typelist, pop_type_stack, append_type_stack)
12097 (push_type_stack, get_type_stack, push_typelist)
12098 (follow_type_instance_flags, follow_types): Remove (moved to
12099 type-stack.c).
12100 * f-exp.y (type_stack): New global.
12101 Update rules.
12102 (push_kind_type, f_parse): Update.
12103 * d-exp.y (type_stack): New global.
12104 Update rules.
12105 (d_parse): Update.
12106 * c-exp.y (struct c_parse_state) <type_stack>: New member.
12107 Update rules.
12108 * Makefile.in (COMMON_SFILES): Add type-stack.c.
12109 (HFILES_NO_SRCDIR): Add type-stack.h.
12110
12111 2019-04-04 Tom Tromey <tom@tromey.com>
12112
12113 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12114 (rust_parser::convert_ast_to_expression, rust_parse)
12115 (rust_lex_test_completion, rust_lex_tests): Update.
12116 * parser-defs.h (struct expr_completion_state): New.
12117 (struct parser_state) <parser_state>: Add completion parameter.
12118 <mark_struct_expression, mark_completion_tag>: New methods.
12119 <parse_completion, m_completion_state>: New members.
12120 (prefixify_expression, null_post_parser): Update.
12121 (mark_struct_expression, mark_completion_tag): Don't declare.
12122 * parse.c (parse_completion, expout_last_struct)
12123 (expout_tag_completion_type, expout_completion_name): Remove
12124 globals.
12125 (parser_state::mark_struct_expression)
12126 (parser_state::mark_completion_tag): Now methods.
12127 (prefixify_expression): Add last_struct parameter.
12128 (prefixify_subexp): Likewise.
12129 (parse_exp_1): Update.
12130 (parse_exp_in_context): Add cstate parameter. Update.
12131 (parse_expression_for_completion): Create an
12132 expr_completion_state.
12133 (null_post_parser): Add "completion" parameter.
12134 * p-exp.y: Update rules.
12135 (yylex): Update.
12136 * language.h (struct language_defn) <la_post_parser>: Add
12137 "completing" parameter.
12138 * go-exp.y: Update rules.
12139 (lex_one_token): Update.
12140 * expression.h (parse_completion): Don't declare.
12141 * d-exp.y: Update rules.
12142 (lex_one_token): Update rules.
12143 * c-exp.y: Update rules.
12144 (lex_one_token): Update.
12145 * ada-lang.c (resolve): Add "parse_completion" parameter.
12146 (resolve_subexp): Likewise.
12147 (ada_resolve_function): Likewise.
12148
12149 2019-04-04 Tom Tromey <tom@tromey.com>
12150
12151 * parser-defs.h (struct parser_state) <start_arglist,
12152 end_arglist>: New methods.
12153 <arglist_len, m_funcall_chain>: New members.
12154 (arglist_len, start_arglist, end_arglist): Don't declare.
12155 * parse.c (arglist_len, funcall_chain): Remove global.
12156 (start_arglist, end_arglist): Remove functions.
12157 (parse_exp_in_context): Update.
12158 * p-exp.y: Update rules.
12159 * m2-exp.y: Update rules.
12160 * go-exp.y: Update rules.
12161 * f-exp.y: Update rules.
12162 * d-exp.y: Update rules.
12163 * c-exp.y: Update rules.
12164
12165 2019-04-04 Tom Tromey <tom@tromey.com>
12166
12167 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12168 lex_operator, push_back>: New methods.
12169 Update all rules.
12170 (rust_parser::lex_hex, lex_escape): Rename and update.
12171 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12172 (rust_parser::lex_operator): Rename and update.
12173 (rust_parser::lex_number, rustyylex, rustyyerror)
12174 (rust_lex_test_init, rust_lex_test_sequence)
12175 (rust_lex_test_push_back, rust_lex_tests): Update.
12176 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12177 parameter.
12178 <lexptr, prev_lexptr>: New members.
12179 (lexptr, prev_lexptr): Don't declare.
12180 * parse.c (lexptr, prev_lexptr): Remove globals.
12181 (parse_exp_in_context): Update.
12182 * p-exp.y (yylex, yyerror): Update.
12183 * m2-exp.y (parse_number, yylex, yyerror): Update.
12184 * go-exp.y (lex_one_token, yyerror): Update.
12185 * f-exp.y (match_string_literal, yylex, yyerror): Update.
12186 * d-exp.y (lex_one_token, yyerror): Update.
12187 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12188 (lex_one_token, yyerror): Update.
12189 * ada-lex.l (YY_INPUT): Update.
12190 (rewind_to_char): Update.
12191 * ada-exp.y (yyerror): Update.
12192
12193 2019-04-04 Tom Tromey <tom@tromey.com>
12194
12195 * rust-exp.y (rustyylex, rust_lex_tests): Update.
12196 * parser-defs.h (struct parser_state) <parser_state>: Add new
12197 parameter.
12198 <comma_terminates>: New member.
12199 (comma_terminates): Don't declare global.
12200 * parse.c (comma_terminates): Remove global.
12201 (parse_exp_in_context): Update.
12202 * p-exp.y (yylex): Update.
12203 * m2-exp.y (yylex): Update.
12204 * go-exp.y (lex_one_token): Update.
12205 * f-exp.y (yylex): Update.
12206 * d-exp.y (lex_one_token): Update.
12207 * c-exp.y (lex_one_token): Update.
12208 * ada-lex.l: Update.
12209
12210 2019-04-04 Tom Tromey <tom@tromey.com>
12211
12212 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12213 (rustyylex, rust_lex_test_init, rust_lex_test_one)
12214 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12215 * parser-defs.h (paren_depth): Don't declare.
12216 * parse.c (paren_depth): Remove global.
12217 (parse_exp_in_context): Update.
12218 * p-exp.y (paren_depth): New global.
12219 (pascal_parse): Initialize it.
12220 * m2-exp.y (paren_depth): New global.
12221 (m2_parse): Initialize it.
12222 * go-exp.y (paren_depth): New global.
12223 (go_parse): Initialize it.
12224 * f-exp.y (paren_depth): New global.
12225 (f_parse): Initialize it.
12226 * d-exp.y (paren_depth): New global.
12227 (d_parse): Initialize it.
12228 * c-exp.y (paren_depth): New global.
12229 (c_parse): Initialize it.
12230 * ada-lex.l (paren_depth): New global.
12231 (lexer_init): Initialize it.
12232
12233 2019-04-04 Tom Tromey <tom@tromey.com>
12234
12235 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12236 (rust_parser::convert_ast_to_type)
12237 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12238 * parser-defs.h (struct parser_state) <parser_state>: Add
12239 parameters. Initialize new members.
12240 <expression_context_block, expression_context_pc>: New members.
12241 * parse.c (expression_context_block, expression_context_pc):
12242 Remove globals.
12243 (parse_exp_in_context): Update.
12244 * p-exp.y: Update all rules.
12245 (yylex): Update.
12246 * m2-exp.y: Update all rules.
12247 (yylex): Update.
12248 * go-exp.y (yylex): Update.
12249 * f-exp.y (yylex): Update.
12250 * d-exp.y: Update all rules.
12251 (yylex): Update.
12252 * c-exp.y: Update all rules.
12253 (lex_one_token, classify_name, yylex, c_parse): Update.
12254 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12255
12256 2019-04-04 Tom Tromey <tom@tromey.com>
12257
12258 * gdbarch.h, gdbarch.c: Rebuild.
12259 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12260 * stap-probe.h:
12261 (struct stap_parse_info): Replace "parser_state" with
12262 "expr_builder".
12263 * parser-defs.h (struct expr_builder): Rename from "parser_state".
12264 (parser_state): New class.
12265 * parse.c (expr_builder): Rename.
12266 (expr_builder::release): Rename.
12267 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12268 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12269 (write_exp_elt_longcst, write_exp_elt_floatcst)
12270 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
12271 (write_exp_string_vector, write_exp_bitstring)
12272 (write_exp_msymbol, mark_struct_expression)
12273 (write_dollar_variable)
12274 (insert_type_address_space, increase_expout_size): Replace
12275 "parser_state" with "expr_builder".
12276 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
12277 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
12278 "parser_state" with "expr_builder".
12279
12280 2019-04-04 Tom Tromey <tom@tromey.com>
12281
12282 * rust-exp.y: Replace "parse_language" with method call.
12283 * p-exp.y:
12284 (yylex): Replace "parse_language" with method call.
12285 * m2-exp.y:
12286 (yylex): Replace "parse_language" with method call.
12287 * go-exp.y (classify_name): Replace "parse_language" with method
12288 call.
12289 * f-exp.y (yylex): Replace "parse_language" with method call.
12290 * d-exp.y (lex_one_token): Replace "parse_language" with method
12291 call.
12292 * c-exp.y:
12293 (lex_one_token, classify_name, yylex): Replace "parse_language"
12294 with method call.
12295 * ada-exp.y (find_primitive_type, type_char)
12296 (type_system_address): Replace "parse_language" with method call.
12297
12298 2019-04-04 Tom Tromey <tom@tromey.com>
12299
12300 * rust-exp.y: Replace "parse_gdbarch" with method call.
12301 * parse.c (write_dollar_variable, insert_type_address_space):
12302 Replace "parse_gdbarch" with method call.
12303 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
12304 call.
12305 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
12306 call.
12307 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
12308 "parse_gdbarch" with method call.
12309 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
12310 with method call.
12311 * f-exp.y (parse_type, parse_f_type, yylex): Replace
12312 "parse_gdbarch" with method call.
12313 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
12314 "parse_gdbarch" with method call.
12315 * c-exp.y (parse_type, parse_number, classify_name): Replace
12316 "parse_gdbarch" with method call.
12317 * ada-lex.l: Replace "parse_gdbarch" with method call.
12318 * ada-exp.y (parse_type, find_primitive_type, type_char)
12319 (type_system_address): Replace "parse_gdbarch" with method call.
12320
12321 2019-04-04 Tom Tromey <tom@tromey.com>
12322
12323 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
12324 * stap-probe.c (stap_parse_argument): Update.
12325 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
12326 initial_size parameter.
12327 * rust-exp.y (rust_lex_tests): Update.
12328 * parse.c (parser_state): Update.
12329 (parse_exp_in_context): Update.
12330 * parser-defs.h (struct parser_state) <parser_state>: Remove
12331 "initial_size" parameter.
12332
12333 2019-04-04 Tom Tromey <tom@tromey.com>
12334
12335 * parser-defs.h (increase_expout_size): Don't declare.
12336 * parse.c (increase_expout_size): Now static.
12337
12338 2019-04-04 Thomas Schwinge <thomas@codesourcery.com>
12339
12340 * gnu-nat.c (gnu_nat_target::wait): Fix
12341 target_waitstatus_to_string call.
12342
12343 2019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12344
12345 * eval.c (evaluate_subexp_standard): Handle internal functions
12346 during Fortran function call handling.
12347
12348 2019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12349
12350 * NEWS: Mention new internal functions.
12351 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
12352 (read_base_type): Use dwarf2_init_complex_target_type.
12353 * value.c (creal_internal_fn): New function.
12354 (cimag_internal_fn): New function.
12355 (_initialize_values): Register new internal functions.
12356
12357 2019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12358
12359 * infrun.c (stop_all_threads): If debug_infrun, always
12360 trace the wait status after wait_one, using
12361 target_waitstatus_to_string and target_pid_to_str.
12362 (handle_inferior_event): Replace various trace of
12363 wait status kind by a single trace.
12364 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
12365 wait status kind image by target_waitstatus_to_string.
12366 * target/waitstatus.c (target_waitstatus_to_string): Fix
12367 obsolete comment.
12368
12369 2019-04-01 Tom Tromey <tromey@adacore.com>
12370
12371 PR symtab/23331:
12372 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
12373
12374 2019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
12375 Pedro Alves <palves@redhat.com>
12376
12377 * top.c (quit_force): Call 'finalize_values'.
12378 * value.c (finalize_values): New function.
12379 * value.h (finalize_values): Declare.
12380
12381 2019-03-30 Eli Zaretskii <eliz@gnu.org>
12382
12383 * NEWS: Announce $_gdb_major and $_gdb_minor.
12384
12385 * top.c (init_gdb_version_vars): New function.
12386 (gdb_init): Call init_gdb_version_vars.
12387
12388 2019-03-29 Tom Tromey <tromey@adacore.com>
12389
12390 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
12391 help text. Remove dead code.
12392
12393 2019-03-29 Keith Seitz <keiths@redhat.com>
12394
12395 From Siddhesh Poyarekar:
12396 * f-lang.h (f77_get_upperbound): Return LONGEST.
12397 (f77_get_lowerbound): Likewise.
12398 * f-typeprint.c (f_type_print_varspec_suffix): Expand
12399 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
12400 print them.
12401 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
12402 plongest to format print it.
12403 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
12404 (f77_get_upperbound): Likewise.
12405 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
12406 LOWER_BOUND to LONGEST.
12407 (f77_create_arrayprint_offset_tbl): Likewise.
12408
12409 2019-03-29 Keith Seitz <keiths@redhat.com>
12410
12411 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
12412 %s/pulongest for TYPE_LENGTH instead of %d in format
12413 strings.
12414 * ada-typerint.c (ada_print_type): Likewise.
12415 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
12416 * compile/compile-c-support.c (generate_register_struct): Likewise.
12417 * gdbtypes.c (recursive_dump_type): Likewise.
12418 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
12419 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
12420 instead of %d in format strings.
12421 * riscv-tdep.c (riscv_type_alignment): Cast second argument
12422 to std::min to ULONGEST.
12423 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
12424 instead of %d in format strings.
12425 * tracepoint.c (info_scope_command): Likewise.
12426 * typeprint.c (print_offset_data::update)
12427 (print_offset_data::finish): Likewise.
12428 * xtensa-tdep.c (xtensa_store_return_value)
12429 (xtensa_push_dummy_call): Likewise.
12430
12431 2019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
12432
12433 * windows-nat.c (display_selector): Fixed format specifications
12434 for 64-bit Cygwin.
12435
12436 2019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12437
12438 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
12439
12440 2019-03-28 Sandra Loosemore <sandra@codesourcery.com>
12441
12442 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
12443 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
12444 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
12445 (nios2_linux_init_abi): Install it.
12446
12447 2019-03-28 Alan Hayward <alan.hayward@arm.com>
12448
12449 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
12450
12451 2019-03-28 Alan Hayward <alan.hayward@arm.com>
12452
12453 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
12454
12455 2019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12456 Tom Tromey <tromey@adacore.com>
12457
12458 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
12459
12460 2019-03-26 Joel Brobecker <brobecker@adacore.com>
12461
12462 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
12463 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
12464 method to compute the bounds of range types. Also print "[evaluated]"
12465 if the bounds' values come from a dynamic evaluation.
12466
12467 2019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
12468
12469 * cp-valprint.c (cp_print_value_fields): Don't print trailing
12470 whitespace when pretty printing is on.
12471
12472 2019-03-26 Alan Hayward <alan.hayward@arm.com>
12473
12474 * ppc-linux-nat.c: Add include.
12475
12476 2019-03-26 Alan Hayward <alan.hayward@arm.com>
12477
12478 * NEWS: Mention AArch64 Pointer Authentication.
12479
12480 2019-03-26 Alan Hayward <alan.hayward@arm.com>
12481
12482 * arm-linux-nat.c: Add include.
12483
12484 2019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
12485
12486 * source-cache.c (source_cache::get_source_lines): Re-read
12487 fullname after calling open_source_file.
12488
12489 2019-03-25 John Baldwin <jhb@FreeBSD.org>
12490
12491 * NEWS: Mention TLS support for FreeBSD.
12492
12493 2019-03-25 Tom Tromey <tromey@adacore.com>
12494
12495 * minsyms.c (BUNCH_SIZE): Update comment.
12496 (~minimal_symbol_reader): Remove old comment.
12497 (compact_minimal_symbols): Update comment.
12498 (minimal_symbol_reader::install): Remove old comment. Update
12499 other comments.
12500
12501 2019-03-25 Alan Hayward <alan.hayward@arm.com>
12502
12503 * s390-linux-nat.c: Add include.
12504
12505 2019-03-25 Alan Hayward <alan.hayward@arm.com>
12506
12507 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
12508 Call linux_get_hwcap.
12509 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
12510 Likewise.
12511 (aarch64_linux_get_hwcap): Remove function.
12512 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
12513 declaration.
12514 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
12515 linux_get_hwcap.
12516 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
12517 * linux-tdep.c (linux_get_hwcap): Add function.
12518 (linux_get_hwcap2): Likewise.
12519 * linux-tdep.h (linux_get_hwcap): Add declaration.
12520 (linux_get_hwcap2): Likewise.
12521 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
12522 (ppc_linux_get_hwcap2): Likewise.
12523 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
12524 linux_get_hwcap.
12525 (ppc_linux_nat_target::insert_watchpoint): Likewise.
12526 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
12527 (ppc_linux_nat_target::read_description): Likewise.
12528 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
12529 * s390-linux-nat.c: Likewise.
12530 * s390-linux-tdep.c (s390_core_read_description): Likewise.
12531
12532 2019-03-24 Tom Tromey <tom@tromey.com>
12533
12534 * ada-lang.c (standard_lookup): Simplify initialization.
12535 (ada_lookup_symbol_nonlocal): Simplify return.
12536 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
12537 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
12538 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
12539 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
12540 initialization.
12541 * solib.c (solib_global_lookup): Simplify.
12542 * symtab.c (null_block_symbol): Remove.
12543 (symbol_cache_lookup): Simplify returns.
12544 (lookup_language_this): Simplify returns.
12545 (lookup_symbol_aux): Simplify return.
12546 (lookup_local_symbol): Simplify returns.
12547 (lookup_global_symbol_from_objfile): Simplify return.
12548 (lookup_symbol_in_objfile_symtabs)
12549 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
12550 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
12551 (lookup_static_symbol, lookup_global_symbol): Simplify return.
12552 * cp-namespace.c (cp_lookup_bare_symbol)
12553 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
12554 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
12555 (cp_lookup_nested_symbol): Don't use null_block_symbol.
12556 (cp_lookup_symbol_via_imports): Simplify initialization.
12557 (find_symbol_in_baseclass): Likewise.
12558 * symtab.h (null_block_symbol): Remove.
12559 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
12560 (d_lookup_nested_symbol, d_lookup_symbol_imports)
12561 (d_lookup_symbol_module): Likewise.
12562 (find_symbol_in_baseclass): Simplify initialization.
12563
12564 2019-03-24 Tom Tromey <tom@tromey.com>
12565
12566 * expression.h: Don't include symtab.h.
12567 (struct block): Forward declare.
12568
12569 2019-03-24 Tom Tromey <tom@tromey.com>
12570
12571 * c-exp.y (typebase): Remove casts.
12572 * gdbtypes.c (lookup_unsigned_typename, )
12573 (lookup_signed_typename): Remove cast.
12574 * eval.c (parse_to_comma_and_eval): Remove cast.
12575 * parse.c (write_dollar_variable): Remove cast.
12576 * block.h (struct block) <superblock>: Now const.
12577 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
12578 * psymtab.c (psym_map_matching_symbols): Make "block" const.
12579 (map_block): Make "block" const.
12580 * symfile.h (struct quick_symbol_functions)
12581 <map_matching_symbols>: Constify block argument to "callback".
12582 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
12583 const.
12584 (find_pc_sect_compunit_symtab): Make "b" const.
12585 (find_symbol_at_address): Likewise.
12586 (search_symbols): Likewise.
12587 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
12588 (dw2_debug_names_lookup_symbol): Likewise.
12589 (dw2_map_matching_symbols): Update.
12590 * p-valprint.c (pascal_val_print): Remove "block".
12591 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
12592 (aux_add_nonlocal_symbols): Make "block" const.
12593 (resolve_subexp): Remove cast.
12594 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
12595 const.
12596 (iterate_over_file_blocks): Likewise.
12597 * f-exp.y (%union) <bval>: Remove.
12598 * coffread.c (patch_opaque_types): Make "b" const.
12599 * spu-tdep.c (spu_catch_start): Make "block" const.
12600 * c-valprint.c (print_unpacked_pointer): Remove "block".
12601 * symmisc.c (dump_symtab_1): Make "b" const.
12602 (block_depth): Make "block" const.
12603 * d-exp.y (%union) <bval>: Remove.
12604 * cp-support.h (cp_lookup_rtti_type): Update.
12605 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
12606 * psymtab.c (psym_lookup_symbol): Make "block" const.
12607 (maintenance_check_psymtabs): Make "b" const.
12608 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
12609 (enumerate_locals, enumerate_args): Update.
12610 * python/py-symtab.c (stpy_global_block): Make "block" const.
12611 (stpy_static_block): Likewise.
12612 * inline-frame.c (block_starting_point_at): Make "new_block"
12613 const.
12614 * block.c (find_block_in_blockvector): Make return type const.
12615 (blockvector_for_pc_sect): Make "b" const.
12616 (find_block_in_blockvector): Make "b" const.
12617
12618 2019-03-23 Tom Tromey <tom@tromey.com>
12619
12620 * varobj.c (varobj_create): Update.
12621 * symfile.c (clear_symtab_users): Don't reset innermost_block.
12622 * printcmd.c (display_command, do_one_display): Don't reset
12623 innermost_block.
12624 * parser-defs.h (enum innermost_block_tracker_type): Move to
12625 expression.h.
12626 (innermost_block): Update comment.
12627 * parse.c (parse_exp_1): Add tracker_types parameter.
12628 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
12629 tracker_types parameter. Reset innermost_block.
12630 (parse_exp_in_context): Remove.
12631 (parse_expression_for_completion): Update.
12632 * objfiles.c (~objfile): Don't reset expression_context_block or
12633 innermost_block.
12634 * expression.h (enum innermost_block_tracker_type): Move from
12635 parser-defs.h.
12636 (parse_exp_1): Add tracker_types parameter.
12637 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
12638 reset innermost_block.
12639
12640 2019-03-23 Tom Tromey <tom@tromey.com>
12641
12642 * objfiles.h: Include bcache.h.
12643
12644 2019-03-23 Tom Tromey <tom@tromey.com>
12645
12646 * linespec.c (get_current_search_block): Use
12647 scoped_restore_current_language.
12648 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
12649
12650 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12651 Jiong Wang <jiong.wang@arm.com>
12652
12653 * aarch64-linux-tdep.c
12654 (aarch64_linux_iterate_over_regset_sections): Check for pauth
12655 section.
12656 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
12657
12658 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12659 Jiong Wang <jiong.wang@arm.com>
12660
12661 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
12662 instructions.
12663 (aarch64_analyze_prologue_test): Add PACIASP test.
12664 (aarch64_prologue_prev_register): Unmask PC value.
12665
12666 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12667 Jiong Wang <jiong.wang@arm.com>
12668
12669 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
12670 (aarch64_dwarf2_prev_register): Unmask PC value.
12671 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
12672 (aarch64_execute_dwarf_cfa_vendor_op): Check for
12673 DW_CFA_AARCH64_negate_ra_state.
12674 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
12675
12676 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12677 Jiong Wang <jiong.wang@arm.com>
12678
12679 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
12680 registers.
12681 (aarch64_pseudo_register_name): Likewise.
12682 (aarch64_pseudo_register_type): Likewise.
12683 (aarch64_pseudo_register_reggroup_p): Likewise.
12684 (aarch64_gdbarch_init): Add pauth registers.
12685 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
12686 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
12687 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
12688 (struct gdbarch_tdep): Add regnum for ra_state.
12689
12690 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12691 Jiong Wang <jiong.wang@arm.com>
12692
12693 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
12694
12695 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12696 Jiong Wang <jiong.wang@arm.com>
12697
12698 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
12699 function.
12700 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
12701 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
12702 (aarch64_gdbarch_init): Add puth registers.
12703 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
12704 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
12705 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
12706
12707 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12708 Jiong Wang <jiong.wang@arm.com>
12709
12710 * aarch64-linux-nat.c
12711 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
12712 * aarch64-linux-tdep.c
12713 (aarch64_linux_core_read_description): Likewise.
12714 (aarch64_linux_get_hwcap): New function.
12715 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
12716 (aarch64_linux_get_hwcap): New declaration.
12717
12718 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12719 Jiong Wang <jiong.wang@arm.com>
12720
12721 * aarch64-linux-nat.c
12722 (aarch64_linux_nat_target::read_description): Add pauth param.
12723 * aarch64-linux-tdep.c
12724 (aarch64_linux_core_read_description): Likewise.
12725 * aarch64-tdep.c (struct target_desc): Add in pauth.
12726 (aarch64_read_description): Add pauth param.
12727 (aarch64_gdbarch_init): Likewise.
12728 * aarch64-tdep.h (aarch64_read_description): Likewise.
12729 * arch/aarch64.c (aarch64_create_target_description): Likewise.
12730 * arch/aarch64.h (aarch64_create_target_description): Likewise.
12731 * features/Makefile: Add new files.
12732 * features/aarch64-pauth.c: New file.
12733 * features/aarch64-pauth.xml: New file.
12734
12735 2019-03-20 Tom Tromey <tromey@adacore.com>
12736
12737 * infrun.c (handle_inferior_event): Rename from
12738 handle_inferior_event_1. Create a scoped_value_mark.
12739 (handle_inferior_event): Remove.
12740
12741 2019-03-19 Tom Tromey <tromey@adacore.com>
12742
12743 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
12744 * infrun.h (print_stop_event): Add "displays" parameter.
12745 * infrun.c (print_stop_event): Add "displays" parameter.
12746
12747 2019-03-19 Pedro Alves <palves@redhat.com>
12748
12749 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
12750 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
12751 to -1. Fix TABs vs spaces.
12752 (tui_ui_out::tui_ui_out): Don't initialize fields here.
12753 * tui/tui-out.h (tui_ui_out) Add intro comments.
12754 <m_line, m_start_of_line>: In-class initialize, and add describing
12755 comment.
12756
12757 2019-03-18 Alan Hayward <alan.hayward@arm.com>
12758
12759 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
12760 variable names.
12761 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
12762
12763 2019-03-18 Pedro Alves <palves@redhat.com>
12764 Eli Zaretskii <eliz@gnu.org>
12765
12766 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
12767 m_line and m_start_of_line.
12768
12769 2019-03-18 Eli Zaretskii <eliz@gnu.org>
12770
12771 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
12772 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
12773 it returns a newline. This fixes a regression in TU mode, whereby
12774 the next line is output on the same screen line as the user input.
12775
12776 2019-03-18 Tom Tromey <tromey@adacore.com>
12777
12778 * minsyms.c (minimal_symbol_reader::install): Remove call to
12779 obstack_blank.
12780
12781 2019-03-18 Pedro Alves <palves@redhat.com>
12782
12783 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
12784 New globals.
12785 (apply_style): New, factored out from ...
12786 (apply_ansi_escape): ... this. Handle reverse video mode.
12787 (tui_set_reverse_mode): New function.
12788 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
12789 * tui/tui-winsource.c (tui_show_source_line): Use
12790 tui_set_reverse_mode instead of setting A_STANDOUT.
12791 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
12792 New setter methods.
12793
12794 2019-03-18 Hannes Domani <ssbssa@yahoo.de>
12795
12796 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
12797 Handle tabs.
12798
12799 2019-03-18 Tom Tromey <tromey@adacore.com>
12800
12801 * ada-lang.c (empty_array): Add "high" parameter.
12802 (ada_evaluate_subexp): Update.
12803
12804 2019-03-17 Sergei Trofimovich <siarheit@google.com>
12805
12806 * unittests/string_view-selftests.c: Define
12807 _initialize_string_view_selftests unconditionally.
12808
12809 2019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
12810
12811 PR gdb/24350
12812 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
12813
12814 2019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
12815
12816 PR gdb/24351
12817 * windows-nat.c (display_selector): Fix format specifiers.
12818
12819 2019-03-17 Eli Zaretskii <eliz@gnu.org>
12820
12821 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
12822 tui_refill_source_window instead of tui_refresh_win, to update the
12823 current execution line. This fixes redisplay of the current line
12824 when stepping through the code with "next" or "step".
12825
12826 2019-03-16 Eli Zaretskii <eliz@gnu.org>
12827
12828 * source-cache.c (source_cache::get_source_lines): Call
12829 find_source_lines to initialize s->nlines. This fixes vertical
12830 scrolling of TUI source window when the DOWN arrow is pressed.
12831
12832 2019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12833
12834 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
12835 linux-thread-db.c (_initialize_thread_db): Likewise.
12836
12837 2019-03-16 Eli Zaretskii <eliz@gnu.org>
12838
12839 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
12840 wclrtoeol in tui_show_source_line". This reverts changes made in
12841 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
12842
12843 2019-03-15 Tom Tromey <tom@tromey.com>
12844
12845 * symtab.h (struct minimal_symbol): Derive from
12846 general_symbol_info.
12847 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
12848 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
12849 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
12850 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
12851 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
12852 (MSYMBOL_SEARCH_NAME): Update.
12853 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
12854 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
12855 * minsyms.c (minimal_symbol_reader::record_full): Update.
12856
12857 2019-03-15 Tom Tromey <tom@tromey.com>
12858
12859 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
12860
12861 2019-03-15 Tom Tromey <tom@tromey.com>
12862
12863 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
12864 unique_xmalloc_ptr.
12865 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
12866 Update.
12867 * minsyms.c (lookup_minimal_symbol_by_pc_section)
12868 (build_minimal_symbol_hash_tables)
12869 (minimal_symbol_reader::install): Update.
12870
12871 2019-03-15 Tom Tromey <tom@tromey.com>
12872
12873 * symtab.c (create_demangled_names_hash): Update.
12874 (symbol_set_names): Update.
12875 * objfiles.h (struct objfile_per_bfd_storage)
12876 <demangled_names_hash>: Now an htab_up.
12877 * objfiles.c (objfile_per_bfd_storage): Simplify.
12878
12879 2019-03-15 Tom Tromey <tom@tromey.com>
12880
12881 * objfiles.h (struct objfile_per_bfd_storage): Declare
12882 destructor.
12883 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
12884 New.
12885 (get_objfile_bfd_data): Use new. Don't initialize
12886 language_of_main.
12887 (free_objfile_per_bfd_storage): Remove.
12888 (objfile_bfd_data_free, objfile::~objfile): Use delete.
12889
12890 2019-03-15 Tom Tromey <tom@tromey.com>
12891
12892 * symfile.c (reread_symbols): Update.
12893 * objfiles.c (objfile::objfile): Update.
12894 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
12895 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
12896 comment.
12897 (minimal_symbol_reader::install): Update.
12898 (terminate_minimal_symbol_table): Remove.
12899 * jit.c (jit_object_close_impl): Update.
12900
12901 2019-03-15 Tom Tromey <tom@tromey.com>
12902
12903 * minsyms.c (minimal_symbol_reader::record_full): Remove some
12904 initializations.
12905
12906 2019-03-15 Tom Tromey <tom@tromey.com>
12907
12908 * objfiles.h (struct objfile_per_bfd_storage)
12909 <demangled_hash_languages>: Now a bitset.
12910 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
12911 (lookup_minimal_symbol): Update.
12912
12913 2019-03-15 Tom Tromey <tom@tromey.com>
12914
12915 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
12916 Don't return the symbol.
12917 * coffread.c (record_minimal_symbol): Use record_full.
12918
12919 2019-03-14 Eli Zaretskii <eliz@gnu.org>
12920
12921 The MS-Windows port of ncurses fails to switch to a color pair if
12922 one or both of the colors are the implicit default colors. This
12923 change records the default colors when TUI is initialized, and
12924 then specifies them explicitly when a color pair uses the default
12925 colors. This allows color styling in TUI mode on MS-Windows.
12926
12927 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
12928 ncurses_norm_attr.
12929 (tui_initialize_io) [__MINGW32__]: Record the default terminal
12930 colors in ncurses_norm_attr.
12931 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
12932 "none", replace it with the default color recorded in
12933 ncurses_norm_attr.
12934
12935 2019-03-14 Tom Tromey <tromey@adacore.com>
12936
12937 * source-cache.h (class source_cache) <get_source_lines>: Return
12938 std::string.
12939 * source-cache.c (source_cache::extract_lines): Handle case where
12940 first_pos==npos. Return std::string.
12941 (source_cache::get_source_lines): Update.
12942
12943 2019-03-14 Tom Tromey <tromey@adacore.com>
12944
12945 * NEWS: Add item for "style sources" commands.
12946 * source-cache.c (source_cache::get_source_lines): Check
12947 source_styling.
12948 * cli/cli-style.c (source_styling): New global.
12949 (_initialize_cli_style): Add "style sources" commands.
12950 (show_style_sources): New function.
12951 * cli/cli-style.h (source_styling): Declare.
12952
12953 2019-03-14 Pedro Alves <palves@redhat.com>
12954 Tom Tromey <tromey@adacore.com>
12955
12956 * tui/tui-winsource.h (tui_refill_source_window): Declare.
12957 * tui/tui-winsource.c (tui_refill_source_window): New function,
12958 from...
12959 (tui_horizontal_source_scroll): ... here. Move some logic.
12960 * cli/cli-style.c (set_style_enabled): Notify new observable.
12961 * tui/tui-hooks.c (tui_redisplay_source): New function.
12962 (tui_attach_detach_observers): Attach or detach
12963 tui_redisplay_source.
12964 * observable.h (source_styling_changed): New observable.
12965 * observable.c: Define source_styling_changed observable.
12966
12967 2019-03-13 Tom Tromey <tromey@adacore.com>
12968
12969 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
12970 (i386_gnu_nat_target::store_registers): Update.
12971 * target-debug.h (target_debug_print_std_string): New macro.
12972 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
12973 * windows-tdep.c (display_one_tib): Update.
12974 * tui/tui-stack.c (tui_make_status_line): Update.
12975 * top.c (print_inferior_quit_action): Update.
12976 * thread.c (thr_try_catch_cmd): Update.
12977 (add_thread_with_info): Update.
12978 (thread_target_id_str): Update.
12979 (thr_try_catch_cmd): Update.
12980 (thread_command): Update.
12981 (thread_find_command): Update.
12982 * record-btrace.c (record_btrace_target::info_record)
12983 (record_btrace_resume_thread, record_btrace_target::resume)
12984 (record_btrace_cancel_resume, record_btrace_step_thread)
12985 (record_btrace_target::wait, record_btrace_target::wait)
12986 (record_btrace_target::wait, record_btrace_target::stop): Update.
12987 * progspace.c (print_program_space): Update.
12988 * process-stratum-target.c
12989 (process_stratum_target::thread_address_space): Update.
12990 * linux-fork.c (linux_fork_mourn_inferior)
12991 (detach_checkpoint_command, info_checkpoints_command)
12992 (linux_fork_context): Update.
12993 (linux_fork_detach): Update.
12994 (class scoped_switch_fork_info): Update.
12995 (delete_checkpoint_command): Update.
12996 * infrun.c (follow_fork_inferior): Update.
12997 (follow_fork_inferior): Update.
12998 (proceed_after_vfork_done): Update.
12999 (handle_vfork_child_exec_or_exit): Update.
13000 (follow_exec): Update.
13001 (displaced_step_prepare_throw): Update.
13002 (displaced_step_restore): Update.
13003 (start_step_over): Update.
13004 (resume_1): Update.
13005 (clear_proceed_status_thread): Update.
13006 (proceed): Update.
13007 (print_target_wait_results): Update.
13008 (do_target_wait): Update.
13009 (context_switch): Update.
13010 (stop_all_threads): Update.
13011 (restart_threads): Update.
13012 (finish_step_over): Update.
13013 (handle_signal_stop): Update.
13014 (switch_back_to_stepped_thread): Update.
13015 (keep_going_pass_signal): Update.
13016 (print_exited_reason): Update.
13017 (normal_stop): Update.
13018 * inferior.c (inferior_pid_to_str): Change return type.
13019 (print_selected_inferior): Update.
13020 (add_inferior): Update.
13021 (detach_inferior): Update.
13022 * dummy-frame.c (fprint_dummy_frames): Update.
13023 * dcache.c (dcache_info_1): Update.
13024 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13025 (btrace_fetch, btrace_clear): Update.
13026 * linux-tdep.c (linux_core_pid_to_str): Change return type.
13027 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13028 type.
13029 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13030 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13031 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13032 * gdbarch.c, gdbarch.h: Rebuild.
13033 * gdbarch.sh (core_pid_to_str): Change return type.
13034 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13035 return type.
13036 (windows_nat_target::pid_to_str): Change return type.
13037 (windows_delete_thread): Update.
13038 (windows_nat_target::attach): Update.
13039 (windows_nat_target::files_info): Update.
13040 * target-delegates.c: Rebuild.
13041 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13042 return type.
13043 (sol_thread_target::pid_to_str): Change return type.
13044 * remote.c (class remote_target) <pid_to_str>: Change return
13045 type.
13046 (remote_target::pid_to_str): Change return type.
13047 (extended_remote_target::attach, remote_target::remote_stop_ns)
13048 (remote_target::remote_notif_remove_queued_reply)
13049 (remote_target::push_stop_reply, remote_target::disable_btrace):
13050 Update.
13051 (extended_remote_target::attach): Update.
13052 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13053 type.
13054 (gdbsim_target::pid_to_str): Change return type.
13055 * ravenscar-thread.c (struct ravenscar_thread_target)
13056 <pid_to_str>: Change return type.
13057 (ravenscar_thread_target::pid_to_str): Change return type.
13058 * procfs.c (class procfs_target) <pid_to_str>: Change return
13059 type.
13060 (procfs_target::pid_to_str): Change return type.
13061 (procfs_target::attach): Update.
13062 (procfs_target::detach): Update.
13063 (procfs_target::fetch_registers): Update.
13064 (procfs_target::store_registers): Update.
13065 (procfs_target::wait): Update.
13066 (procfs_target::files_info): Update.
13067 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13068 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13069 return type.
13070 (nto_procfs_target::pid_to_str): Change return type.
13071 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13072 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13073 return type.
13074 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13075 (exit_lwp): Update.
13076 (attach_proc_task_lwp_callback, get_detach_signal)
13077 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13078 (linux_nat_target::resume, wait_lwp, stop_callback)
13079 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13080 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13081 (linux_nat_wait_1, resume_stopped_resumed_lwps)
13082 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13083 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13084 type.
13085 (inf_ptrace_target::attach): Update.
13086 (inf_ptrace_target::files_info): Update.
13087 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13088 type.
13089 (go32_nat_target::pid_to_str): Change return type.
13090 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13091 (gnu_nat_target::wait): Update.
13092 (gnu_nat_target::wait): Update.
13093 (gnu_nat_target::resume): Update.
13094 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13095 (fbsd_nat_target::wait): Update.
13096 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13097 type.
13098 (darwin_nat_target::attach): Update.
13099 * corelow.c (class core_target) <pid_to_str>: Change return type.
13100 (core_target::pid_to_str): Change return type.
13101 * target.c (normal_pid_to_str): Change return type.
13102 (default_pid_to_str): Likewise.
13103 (target_pid_to_str): Change return type.
13104 (target_translate_tls_address): Update.
13105 (target_announce_detach): Update.
13106 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13107 return type.
13108 (bsd_uthread_target::pid_to_str): Change return type.
13109 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13110 type.
13111 (bsd_kvm_target::pid_to_str): Change return type.
13112 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13113 return type.
13114 (aix_thread_target::pid_to_str): Change return type.
13115 * target.h (struct target_ops) <pid_to_str>: Change return type.
13116 (target_pid_to_str, normal_pid_to_str): Likewise.
13117 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13118 type.
13119 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13120 type.
13121 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13122 return type.
13123 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13124 type.
13125 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13126 type.
13127 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13128 return type.
13129
13130 2019-03-13 Simon Marchi <simon.marchi@ericsson.com>
13131
13132 * NEWS: Mention that the new default MI version is 3. Mention
13133 changes to the output of commands and events that deal with
13134 multi-location breakpoints.
13135 * breakpoint.c: Include "mi/mi-out.h".
13136 (print_one_breakpoint): Change output syntax if using MI version
13137 >= 3.
13138 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13139 New.
13140 (mi_multi_location_breakpoint_output_fixed): New.
13141 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13142 (mi_cmd_fix_multi_location_breakpoint_output): New.
13143 (mi_multi_location_breakpoint_output_fixed): New.
13144 * mi/mi-cmds.c (mi_cmds): Register command
13145 -fix-multi-location-breakpoint-output.
13146 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13147 interpreter "mi".
13148
13149 2019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
13150
13151 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13152 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13153 instantiate mi_ui_out based on interpreter name.
13154 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13155 * mi/mi-main.c (mi_load_progress): Likewise.
13156
13157 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13158
13159 * NEWS: Combine separate "New targets" sections for 8.3.
13160
13161 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13162
13163 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13164 (ppcfbsd_init_abi): Install gdbarch
13165 "fetch_tls_load_module_address" and "get_thread_local_address"
13166 methods.
13167
13168 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13169
13170 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13171 (riscv_fbsd_init_abi): Install gdbarch
13172 "fetch_tls_load_module_address" and "get_thread_local_address"
13173 methods.
13174
13175 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13176
13177 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13178 (i386fbsd_init_abi): Install gdbarch
13179 "fetch_tls_load_module_address" and "get_thread_local_address"
13180 methods.
13181
13182 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13183
13184 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13185 (amd64fbsd_init_abi): Install gdbarch
13186 "fetch_tls_load_module_address" and "get_thread_local_address"
13187 methods.
13188
13189 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13190
13191 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13192 (struct fbsd_pspace_data): New type.
13193 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13194 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13195 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13196 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13197 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13198
13199 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13200
13201 * gdbtypes.c (lookup_struct_elt): New function.
13202 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13203 * gdbtypes.h (struct struct_elt): New type.
13204 (lookup_struct_elt): New prototype.
13205
13206 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13207
13208 * gdbtypes.c (lookup_struct_elt_type): Update comment and
13209 remove disabled code block.
13210
13211 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13212
13213 * gdbarch.sh (get_thread_local_address): New method.
13214 * gdbarch.h, gdbarch.c: Regenerate.
13215 * target.c (target_translate_tls_address): Use
13216 gdbarch_get_thread_local_address if present instead of
13217 target::get_thread_local_address.
13218
13219 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13220
13221 * target.h (target::get_thread_local_address): Update comment.
13222
13223 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13224
13225 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13226 objfile->separate_debug_objfile_backlink if not NULL.
13227
13228 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13229
13230 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13231 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13232 (amd64bsd_store_inferior_registers): Likewise.
13233 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13234 Enable segment base registers.
13235 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13236 PT_GETFSBASE and PT_GETGSBASE.
13237 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13238 PT_SETGSBASE.
13239 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13240 segment base registers.
13241 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13242
13243 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13244
13245 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13246 Update calls to i386_target_description to add 'segments'
13247 parameter.
13248 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
13249 add segment base registers.
13250 * arch/i386.c (i386_create_target_description): Add 'segments'
13251 parameter to enable segment base registers.
13252 * arch/i386.h (i386_create_target_description): Likewise.
13253 * features/i386/32bit-segments.xml: New file.
13254 * features/i386/32bit-segments.c: Generate.
13255 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13256 call to i386_target_description to add 'segments' parameter.
13257 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13258 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13259 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13260 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13261 if feature is present.
13262 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13263 Add 'segments' parameter to call to i386_target_description.
13264 (i386_target_description): Add 'segments' parameter to enable
13265 segment base registers.
13266 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13267 to call to i386_target_description.
13268 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13269 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13270 Define I386_NUM_REGS.
13271 (i386_target_description): Add 'segments' parameter to enable
13272 segment base registers.
13273
13274 2019-03-12 Eli Zaretskii <eliz@gnu.org>
13275
13276 PR/24325
13277 * source-cache.c: #undef open and close, to avoid unresolved
13278 externals during linking.
13279
13280 2019-03-12 Tom Tromey <tromey@adacore.com>
13281
13282 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
13283 const. Add initializers.
13284 (_initialize_remote): Don't initialize ptid globals.
13285
13286 2019-03-12 Pedro Alves <palves@redhat.com>
13287
13288 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
13289
13290 2019-03-12 Pedro Alves <palves@redhat.com>
13291
13292 * cp-name-parser.y (main): Remove unused 'len' variable.
13293
13294 2019-03-12 Tom Tromey <tromey@adacore.com>
13295
13296 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
13297 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
13298
13299 2019-03-12 Tom Tromey <tromey@adacore.com>
13300
13301 * linux-nat.c (iterate_over_lwps): Update.
13302 (stop_callback): Remove parameter.
13303 (stop_wait_callback, detach_callback, resume_set_callback)
13304 (select_singlestep_lwp_callback, set_ignore_sigint)
13305 (status_callback, resumed_callback, resume_clear_callback)
13306 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
13307 data parameter.
13308 (linux_nat_target::detach, linux_nat_target::resume)
13309 (linux_stop_and_wait_all_lwps, select_event_lwp)
13310 (linux_nat_filter_event, linux_nat_wait_1)
13311 (linux_nat_target::kill, linux_nat_target::stop)
13312 (linux_nat_target::stop): Update.
13313 (linux_nat_resume_callback): Change type.
13314 (resume_stopped_resumed_lwps, count_events_callback)
13315 (select_event_lwp_callback): Likewise.
13316 (linux_stop_lwp, linux_nat_stop_lwp): Update.
13317 * arm-linux-nat.c (struct update_registers_data): Remove.
13318 (update_registers_callback): Change type.
13319 (arm_linux_insert_hw_breakpoint1): Update.
13320 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
13321 parameter.
13322 (x86_linux_dr_set_addr): Update.
13323 (x86_linux_dr_set_control): Update.
13324 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
13325 (iterate_over_lwps): Use gdb::function_view.
13326 * nat/aarch64-linux-hw-point.c (struct
13327 aarch64_dr_update_callback_param): Remove.
13328 (debug_reg_change_callback): Change type.
13329 (aarch64_notify_debug_reg_change): Update.
13330 * s390-linux-nat.c (s390_refresh_per_info): Update.
13331
13332 2019-03-11 Tom Tromey <tromey@adacore.com>
13333
13334 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
13335 redundant assignment to "this_cu".
13336
13337 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13338
13339 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
13340
13341 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13342
13343 * gdbtypes.c (rank_one_type_parm_set): New function extracted
13344 from...
13345 (rank_one_type): ... this.
13346
13347 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13348
13349 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
13350 from...
13351 (rank_one_type): ... this.
13352
13353 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13354
13355 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
13356 from...
13357 (rank_one_type): ... this.
13358
13359 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13360
13361 * gdbtypes.c (rank_one_type_parm_float): New function extracted
13362 from...
13363 (rank_one_type): ... this.
13364
13365 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13366
13367 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
13368 from...
13369 (rank_one_type): ... this.
13370
13371 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13372
13373 * gdbtypes.c (rank_one_type_parm_range): New function extracted
13374 from...
13375 (rank_one_type): ... this.
13376
13377 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13378
13379 * gdbtypes.c (rank_one_type_parm_char): New function extracted
13380 from...
13381 (rank_one_type): ... this.
13382
13383 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13384
13385 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
13386 from...
13387 (rank_one_type): ... this.
13388
13389 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13390
13391 * gdbtypes.c (rank_one_type_parm_int): New function extracted
13392 from...
13393 (rank_one_type): ... this.
13394
13395 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13396
13397 * gdbtypes.c (rank_one_type_parm_func): New function extracted
13398 from...
13399 (rank_one_type): ... this.
13400
13401 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13402
13403 * gdbtypes.c (rank_one_type_parm_array): New function extracted
13404 from...
13405 (rank_one_type): ... this.
13406
13407 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13408
13409 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
13410 from...
13411 (rank_one_type): ... this.
13412
13413 2019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13414
13415 * inferior.c (initialize_inferiors): Ensure 'help set/show print
13416 inferior-events' shows the example events.
13417
13418 2019-03-08 Eli Zaretskii <eliz@gnu.org>
13419
13420 Support styling on native MS-Windows console
13421
13422 PR/24315
13423 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
13424 on MS-Windows if $TERM is not defined.
13425
13426 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
13427
13428 * posix-hdep.c (gdb_console_fputs):
13429 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
13430 functions.
13431 * ui-file.h (gdb_console_fputs): Add prototype.
13432
13433 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
13434 back to fputs only if the former returns zero.
13435
13436 2019-03-07 Tom Tromey <tom@tromey.com>
13437
13438 * symmisc.c (print_symbol_bcache_statistics): Update.
13439 (print_objfile_statistics): Update.
13440 * symfile.c (allocate_symtab): Update.
13441 * stabsread.c: Don't include bcache.h.
13442 * psymtab.h (struct psymbol_bcache): Don't declare.
13443 (class psymtab_storage) <psymbol_cache>: Now a bcache.
13444 (psymbol_bcache_init, psymbol_bcache_free)
13445 (psymbol_bcache_get_bcache): Don't declare.
13446 * psymtab.c (struct psymbol_bcache): Remove.
13447 (psymtab_storage::psymtab_storage): Update.
13448 (psymtab_storage::~psymtab_storage): Update.
13449 (psymbol_bcache_init, psymbol_bcache_free)
13450 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
13451 (add_psymbol_to_bcache): Update.
13452 (allocate_psymtab): Update.
13453 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
13454 macro_cache>: No longer pointers.
13455 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
13456 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
13457 * macrotab.c (macro_bcache): Update.
13458 * macroexp.c: Don't include bcache.h.
13459 * gdbtypes.c (check_types_worklist): Update.
13460 (types_deeply_equal): Remove TRY/CATCH. Update.
13461 * elfread.c (elf_symtab_read): Update.
13462 * dwarf2read.c: Don't include bcache.h.
13463 * buildsym.c (buildsym_compunit::get_macro_table): Update.
13464 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
13465 (print_bcache_statistics, bcache_memory_used): Don't declare.
13466 (struct bcache): Move from bcache.c. Add constructor, destructor,
13467 methods. Rename all data members.
13468 * bcache.c (struct bcache): Move to bcache.h.
13469 (bcache::expand_hash_table): Rename from expand_hash_table.
13470 (bcache): Remove.
13471 (bcache::insert): Rename from bcache_full.
13472 (bcache::compare): Rename from bcache_compare.
13473 (bcache_xmalloc): Remove.
13474 (bcache::~bcache): Rename from bcache_xfree.
13475 (bcache::print_statistics): Rename from print_bcache_statistics.
13476 (bcache::memory_used): Rename from bcache_memory_used.
13477
13478 2019-03-07 Pedro Alves <palves@redhat.com>
13479
13480 * infrun.c (normal_stop): Also check for
13481 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
13482
13483 2019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
13484
13485 * f-lang.c (value_from_host_double): Moved to...
13486 * value.c (value_from_host_double): ...here.
13487 * value.h (value_from_host_double): Declare.
13488 * guile/scm-math.c (vlscm_convert_typed_number): Use
13489 value_from_host_double.
13490 (vlscm_convert_number): Likewise.
13491 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
13492 * python/py-value.c (convert_value_from_python): Likewise.
13493
13494 2019-03-06 Tom Tromey <tom@tromey.com>
13495
13496 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
13497
13498 2019-03-06 Tom Tromey <tom@tromey.com>
13499
13500 * utils.h (free_current_contents): Don't declare.
13501 * utils.c (free_current_contents): Remove.
13502
13503 2019-03-06 Tom Tromey <tom@tromey.com>
13504
13505 * top.c (quit_force): Update.
13506 * main.c (captured_command_loop): Update.
13507 * common/new-op.c (operator new): Update.
13508 * common/common-exceptions.c (struct catcher)
13509 <save_cleanup_chain>: Remove member.
13510 (exceptions_state_mc_init): Update.
13511 (exception_try_scope_entry): Return nullptr.
13512 (exception_try_scope_exit, exception_rethrow)
13513 (throw_exception_sjlj, throw_exception_cxx): Update.
13514 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
13515 (all_cleanups, do_cleanups, discard_cleanups)
13516 (discard_final_cleanups, save_cleanups, save_final_cleanups)
13517 (restore_cleanups, restore_final_cleanups): Don't declare.
13518 (do_final_cleanups): Remove parameter.
13519 * common/cleanups.c (cleanup_chain, make_cleanup)
13520 (make_cleanup_dtor, all_cleanups, do_cleanups)
13521 (discard_my_cleanups, discard_cleanups)
13522 (discard_final_cleanups, save_my_cleanups, save_cleanups)
13523 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
13524 (null_cleanup): Remove.
13525 (do_final_cleanups): Remove parameter.
13526
13527 2019-03-06 Tom Tromey <tom@tromey.com>
13528
13529 * remote.c (remote_target::remote_parse_stop_reply): Use
13530 unique_xmalloc_ptr.
13531
13532 2019-03-06 Tom Tromey <tom@tromey.com>
13533
13534 * stabsread.c (struct stabs_field_info): Rename from field_info.
13535 <list, fnlist>: Add initializers.
13536 <obstack>: New member.
13537 (read_member_functions, read_struct_fields, read_baseclasses):
13538 Allocate on obstack. Don't use cleanups.
13539 (read_one_struct_field, read_member_functions, read_struct_fields)
13540 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
13541 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
13542 (read_struct_type): Update.
13543
13544 2019-03-06 Tom Tromey <tom@tromey.com>
13545
13546 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
13547 * common/filestuff.h (make_cleanup_close): Don't declare.
13548 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
13549 Remove.
13550
13551 2019-03-06 Tom Tromey <tom@tromey.com>
13552
13553 * solib-aix.c: Use make_scope_exit.
13554
13555 2019-03-06 Tom Tromey <tom@tromey.com>
13556
13557 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
13558 Use make_scope_exit.
13559
13560 2019-03-06 Tom Tromey <tom@tromey.com>
13561
13562 * solib-svr4.c (disable_probes_interface): Remove parameter.
13563 (svr4_handle_solib_event): Use make_scope_exit.
13564
13565 2019-03-06 Tom Tromey <tom@tromey.com>
13566
13567 * remote.c (struct stop_reply_deleter): Remove.
13568 (stop_reply_up): Update.
13569 (struct stop_reply): Derive from notif_event. Don't typedef.
13570 <regcache>: Now a std::vector.
13571 (stop_reply_xfree): Remove.
13572 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
13573 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
13574 (remote_target::discard_pending_stop_replies): Use delete.
13575 (remote_target::remote_parse_stop_reply): Update.
13576 (remote_target::process_stop_reply): Update.
13577 * remote-notif.h (struct notif_event): Add virtual destructor.
13578 Remove "dtr" member.
13579 (struct notif_client) <alloc_event>: Return a unique_ptr.
13580 (notif_event_xfree): Don't declare.
13581 (notif_event_up): New typedef.
13582 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
13583 (notif_event_xfree, do_notif_event_xfree): Remove.
13584 (remote_notif_state_xfree): Update.
13585
13586 2019-03-06 Tom Tromey <tom@tromey.com>
13587
13588 * infrun.c (displaced_step_clear_cleanup): Now a
13589 forward_scope_exit type.
13590 (displaced_step_prepare_throw): Update.
13591 (displaced_step_fixup): Update.
13592
13593 2019-03-06 Tom Tromey <tom@tromey.com>
13594
13595 * inferior.h (class inferior): Update comment.
13596 * gdbthread.h (class thread_info): Update comment.
13597
13598 2019-03-06 Joel Brobecker <brobecker@adacore.com>
13599 Tom Tromey <tom@tromey.com>
13600
13601 * stabsread.h (struct stab_section_list): Remove.
13602 (coffstab_build_psymtabs): Update.
13603 * dbxread.c (symbuf_sections): Now a std::vector.
13604 (sect_idx): New global.
13605 (fill_symbuf): Update.
13606 (coffstab_build_psymtabs): Change type of stabsects parameter.
13607 Update.
13608 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
13609 std::vector.
13610 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
13611 (coff_locate_sections): Update.
13612 (coff_symfile_read): Remove cleanups. Update.
13613 (init_stringtab): Add storage parameter.
13614 (free_stringtab, free_stringtab_cleanup): Remove.
13615 (init_lineno): Add storage parameter.
13616 (free_linetab, free_linetab_cleanup): Remove.
13617
13618 2019-03-06 Pedro Alves <palves@redhat.com>
13619
13620 * linux-fork.c (fork_info::clobber_regs): Delete.
13621 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
13622 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
13623 comment. Adjust.
13624 (scoped_switch_fork_info::scoped_switch_fork_info)
13625 (checkpoint_command, linux_fork_context): Adjust
13626 fork_save_infrun_state calls.
13627
13628 2019-03-06 Pedro Alves <palves@redhat.com>
13629
13630 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
13631 (inf_has_multiple_threads): Return 'bool' and rewrite using
13632 inferior_info::threads().
13633
13634 2019-03-06 Pedro Alves <palves@redhat.com>
13635
13636 * linux-fork.c: Include <list>.
13637 (fork_list): Now a std::list instance.
13638 (fork_info): Add ctor, dtor, and in-class initialize all fields.
13639 (forks_exist_p, find_last_fork): Adjust.
13640 (new_fork): Delete.
13641 (one_fork_p): New.
13642 (add_fork): Adjust.
13643 (free_fork): Delete, folded into fork_info::~fork_info().
13644 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
13645 Adjust.
13646 (init_fork_list): Delete.
13647 (linux_fork_killall, linux_fork_mourn_inferior)
13648 (linux_fork_detach, info_checkpoints_command): Adjust.
13649 (_initialize_linux_fork): No longer call init_fork_list.
13650
13651 2019-03-06 Pedro Alves <palves@redhat.com>
13652
13653 * linux-fork.c (new_fork): New, split out of ...
13654 (add_fork): ... this. Return void. Move "first fork" special
13655 case from here, to ...
13656 (checkpoint_command): ... here.
13657 * linux-linux.h (add_fork): Return void.
13658
13659 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13660
13661 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
13662
13663 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13664 Chris January <chris.january@arm.com>
13665 David Lecomber <david.lecomber@arm.com>
13666
13667 * f-exp.y: New token, UNOP_INTRINSIC.
13668 (exp): New pattern using UNOP_INTRINSIC token.
13669 (f77_keywords): Add 'abs' keyword.
13670 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
13671 (value_from_host_double): New function.
13672 (evaluate_subexp_f): Support UNOP_ABS.
13673
13674 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13675
13676 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
13677 types.
13678
13679 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13680
13681 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
13682 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
13683 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
13684
13685 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13686
13687 * f-exp.y (convert_to_kind_type): Handle more type kinds.
13688
13689 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13690 Chris January <chris.january@arm.com>
13691
13692 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
13693 * f-exp.y: Define 'KIND' token.
13694 (exp): New pattern for KIND expressions.
13695 (ptype): Handle types with a kind extension.
13696 (direct_abs_decl): Extend to spot kind extensions.
13697 (f77_keywords): Add 'kind' to the list.
13698 (push_kind_type): New function.
13699 (convert_to_kind_type): New function.
13700 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
13701 * parse.c (operator_length_standard): Likewise.
13702 * parser-defs.h (enum type_pieces): Add tp_kind.
13703 * std-operator.def: Add UNOP_KIND.
13704
13705 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13706
13707 * f-exp.y (f_parse): Set yydebug.
13708
13709 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13710
13711 * f-lang.c (evaluate_subexp_f): New function.
13712 (exp_descriptor_f): New global.
13713 (f_language_defn): Use exp_descriptor_f instead of
13714 exp_descriptor_standard.
13715
13716 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13717
13718 * f-exp.y (struct token): Add comments.
13719 (dot_ops): Remove uppercase versions and the end marker.
13720 (f77_keywords): Likewise.
13721 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
13722 entries in the dot_ops array are case insensitive, and use
13723 strncasecmp to compare strings. Also some whitespace cleanup in
13724 this area. Similar for the f77_keywords array, except entries in
13725 this list might be case sensitive.
13726
13727 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13728
13729 * f-exp.y (struct f77_boolean_val): Add comments.
13730 (boolean_values): Remove uppercase versions, and end marker.
13731 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
13732 and use strncasecmp to achieve case insensitivity. Additionally,
13733 perform whitespace cleanup around this code.
13734
13735 2019-03-06 Tom Tromey <tromey@adacore.com>
13736
13737 * remote-sim.c (gdbsim_target_open): Use result of
13738 gdb_argv::release.
13739
13740 2019-03-06 Richard Bunt <richard.bunt@arm.com>
13741 Dirk Schubert <dirk.schubert@arm.com>
13742 Chris January <chris.january@arm.com>
13743
13744 * eval.c (evaluate_subexp_standard): Call Fortran argument
13745 wrapping logic.
13746 * f-lang.c (struct value): A value which can be passed into a
13747 Fortran function call.
13748 (fortran_argument_convert): Wrap Fortran arguments in a pointer
13749 where appropriate.
13750 (struct type): Value ready for a Fortran function call.
13751 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
13752 is needed.
13753 * f-lang.h (fortran_argument_convert): Declaration.
13754 (fortran_preserve_arg_pointer): Declaration.
13755 * infcall.c (value_arg_coerce): Call Fortran argument logic.
13756
13757 2019-03-05 Tom Tromey <tromey@adacore.com>
13758
13759 * python/py-prettyprint.c (print_string_repr): Remove #if.
13760 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
13761
13762 2019-03-05 Tom Tromey <tromey@adacore.com>
13763
13764 * target.c (the_dummy_target): Move later. Change type to
13765 "dummy_target".
13766 (initialize_targets): Don't initialize the_dummy_target.
13767
13768 2019-03-05 Tom Tromey <tromey@adacore.com>
13769
13770 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
13771 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
13772
13773 2019-03-05 Tom Tromey <tromey@adacore.com>
13774
13775 * windows-nat.c (windows_nat_target::attach)
13776 (windows_nat_target::detach): Don't call gdb_flush.
13777 * valprint.c (generic_val_print, val_print, val_print_string):
13778 Don't call gdb_flush.
13779 * utils.c (defaulted_query): Don't call gdb_flush.
13780 * typeprint.c (print_type_scalar): Don't call gdb_flush.
13781 * target.c (target_announce_detach): Don't call gdb_flush.
13782 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
13783 * remote.c (extended_remote_target::attach): Don't call
13784 gdb_flush.
13785 * procfs.c (procfs_target::detach): Don't call gdb_flush.
13786 * printcmd.c (do_examine): Don't call gdb_flush.
13787 (info_display_command): Don't call gdb_flush.
13788 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
13789 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
13790 * memattr.c (info_mem_command): Don't call gdb_flush.
13791 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
13792 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
13793 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
13794 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
13795 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
13796 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
13797 (gnu_nat_target::detach): Don't call gdb_flush.
13798 * f-valprint.c (f_val_print): Don't call gdb_flush.
13799 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
13800 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
13801 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
13802 gdb_flush.
13803 * c-valprint.c (c_val_print): Don't call gdb_flush.
13804 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
13805
13806 2019-03-05 Tom Tromey <tromey@adacore.com>
13807
13808 * varobj.c (update_dynamic_varobj_children): Update.
13809 (install_default_visualizer): Use reset, not release.
13810 * value.c (set_internalvar): Update.
13811 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
13812 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
13813 ATTRIBUTE_UNUSED_RESULT.
13814
13815 2019-03-05 Tom Tromey <tromey@adacore.com>
13816
13817 * remote.c (class scoped_remote_fd) <release>: Add
13818 ATTRIBUTE_UNUSED_RESULT.
13819
13820 2019-03-05 Tom Tromey <tromey@adacore.com>
13821
13822 * macroexp.c (struct macro_buffer) <release>: Add
13823 ATTRIBUTE_UNUSED_RESULT.
13824
13825 2019-03-05 Tom Tromey <tromey@adacore.com>
13826
13827 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
13828 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
13829 ATTRIBUTE_UNUSED_RESULT.
13830
13831 2019-03-05 Tom Tromey <tromey@adacore.com>
13832
13833 * common/scoped_fd.h (class scoped_fd) <release>: Add
13834 ATTRIBUTE_UNUSED_RESULT.
13835
13836 2019-03-05 Tom Tromey <tromey@adacore.com>
13837
13838 * parser-defs.h (struct parser_state) <release>: Add
13839 ATTRIBUTE_UNUSED_RESULT.
13840
13841 2019-03-05 Tom Tromey <tromey@adacore.com>
13842
13843 * utils.h (class gdb_argv) <release>: Add
13844 ATTRIBUTE_UNUSED_RESULT.
13845 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
13846
13847 2019-03-02 Eli Zaretskii <eliz@gnu.org>
13848
13849 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
13850 for-loop range, to avoid compiler warnings.
13851
13852 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
13853 avoid compiler warnings about unused variables.
13854
13855 * NEWS: Mention end of support for native debugging on MS-Windows
13856 before XP.
13857
13858 PR gdb/24292
13859 * common/netstuff.c:
13860 * gdbserver/gdbreplay.c
13861 * gdbserver/remote-utils.c:
13862 * ser-tcp.c:
13863 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
13864 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
13865 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
13866 'getaddrinfo' and 'freeaddrinfo' were not available before
13867 Windows XP, and mingw.org's MinGW headers by default define
13868 _WIN32_WINNT to 0x500.
13869
13870 2019-03-01 Gary Benson <gbenson@redhat.com>
13871
13872 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
13873
13874 2019-02-28 Brian Vandenberg <phantall@gmail.com>
13875 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
13876
13877 PR gdb/8527
13878 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
13879 set_sigint_trap, clear_sigint_trap.
13880
13881 2019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13882
13883 * target.c (target_detach): Clear the regcache and the
13884 frame cache.
13885
13886 2019-02-27 Pedro Alves <palves@redhat.com>
13887
13888 * utils.c (set_screen_size): When we cap the height/width sizes,
13889 tweak the corresponding command variable to show "unlimited":
13890
13891 2019-02-27 Saagar Jha <saagar@saagarjha.com>
13892 Pedro Alves <palves@redhat.com>
13893
13894 * utils.c (set_screen_size): Reduce "infinite" rows and columns
13895 before calling rl_set_screen_size.
13896
13897 2019-02-27 Tom Tromey <tromey@adacore.com>
13898
13899 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
13900 define.
13901 * python/py-value.c: Remove Python 2.4 workaround.
13902 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
13903 workaround.
13904 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
13905 Python 2.4 workaround.
13906 * python/python-internal.h: Remove Python 2.4 comment.
13907 (Py_ssize_t): Don't define.
13908 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
13909 (gdb_Py_DECREF): Remove Python 2.4 workaround.
13910 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
13911 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
13912 * python/python.c (do_start_initialization): Remove Python 2.4
13913 workaround.
13914 * python/py-prettyprint.c (class dummy_python_frame): Remove.
13915 (print_children): Remove Python 2.4 workaround.
13916 * python/py-inferior.c (buffer_procs): Remove Python 2.4
13917 workaround.
13918 (CHARBUFFERPROC_NAME): Remove.
13919 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
13920 Python 2.4 workaround.
13921
13922 2019-02-27 Kevin Buettner <kevinb@redhat.com>
13923
13924 * NEWS: Note minimum Python version.
13925
13926 2019-02-27 Kevin Buettner <kevinb@redhat.com>
13927
13928 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
13929 code from these functions. Remove corresponding ifdefs. Use
13930 Py_buffer_up instead of explicit calls to PyBuffer_Release.
13931 Remove gotos and target of gotos.
13932 (infpy_search_memory): Likewise.
13933
13934 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13935
13936 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
13937 (hppa_gdbarch_init): Don't register deleted functions with
13938 gdbarch.
13939
13940 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13941
13942 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
13943 (h8300_unwind_sp): Delete.
13944 (h8300_dummy_id): Delete.
13945 (h8300_gdbarch_init): Don't register deleted functions with
13946 gdbarch.
13947
13948 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13949
13950 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
13951 (ft32_unwind_pc): Delete.
13952 (ft32_unwind_sp): Delete.
13953 (ft32_gdbarch_init): Don't register deleted functions with
13954 gdbarch.
13955
13956 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13957
13958 * gdb/frv-tdep.c (frv_dummy_id): Delete.
13959 (frv_unwind_pc): Delete.
13960 (frv_unwind_sp): Delete.
13961 (frv_gdbarch_init): Don't register deleted functions with
13962 gdbarch.
13963
13964 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13965
13966 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
13967 (riscv_unwind_pc): Delete.
13968 (riscv_unwind_sp): Delete.
13969 (riscv_gdbarch_init): Don't register deleted functions with
13970 gdbarch.
13971
13972 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13973
13974 * gdb/csky-tdep.c (csky_dummy_id): Delete.
13975 (csky_unwind_pc): Delete.
13976 (csky_unwind_sp): Delete.
13977 (csky_gdbarch_init): Don't register deleted functions with
13978 gdbarch.
13979
13980 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13981
13982 * gdb/cris-tdep.c (cris_dummy_id): Delete.
13983 (cris_unwind_pc): Delete.
13984 (cris_unwind_sp): Delete.
13985 (cris_gdbarch_init): Don't register deleted functions with
13986 gdbarch.
13987
13988 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13989
13990 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
13991 (bfin_unwind_pc): Delete.
13992 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
13993
13994 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13995
13996 * gdb/arm-tdep.c (arm_dummy_id): Delete.
13997 (arm_unwind_pc): Delete.
13998 (arm_unwind_sp): Delete.
13999 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14000
14001 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14002
14003 * gdb/arc-tdep.c (arc_dummy_id): Delete.
14004 (arc_unwind_pc): Delete.
14005 (arc_unwind_sp): Delete.
14006 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14007
14008 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14009
14010 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14011 (alpha_unwind_pc): Delete.
14012 (alpha_gdbarch_init): Don't register deleted functions with
14013 gdbarch.
14014
14015 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14016
14017 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14018 (aarch64_unwind_pc): Delete.
14019 (aarch64_unwind_sp): Delete.
14020 (aarch64_gdbarch_init): Don't register deleted functions with
14021 gdbarch.
14022
14023 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14024
14025 * gdbtypes.c (type_align): Don't consider static members when
14026 computing structure alignment.
14027
14028 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14029
14030 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14031 return 0 for other types.
14032 * arch-utils.c (default_type_align): Always return 0.
14033 * gdbarch.h: Regenerate.
14034 * gdbarch.sh (type_align): Extend comment.
14035 * gdbtypes.c (type_align): Add additional comments, always call
14036 gdbarch_type_align before applying the default rules.
14037 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14038 generic code will then apply a suitable default.
14039 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14040 types, return 0 for other types.
14041
14042 2019-02-27 Joel Brobecker <brobecker@adacore.com>
14043
14044 * NEWS: Create a new section for the next release branch.
14045 Rename the section of the current branch, now that it has
14046 been cut.
14047
14048 2019-02-27 Joel Brobecker <brobecker@adacore.com>
14049
14050 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14051 * version.in: Bump version to 8.3.50.DATE-git.
14052
14053 2019-02-26 Simon Marchi <simon.marchi@efficios.com>
14054
14055 * aix-thread.c (ptid_cmp): Remove unused variable.
14056 (get_signaled_thread): Likewise.
14057 (store_regs_user_thread): Likewise.
14058 (store_regs_kernel_thread): Likewise.
14059 (fetch_regs_kernel_thread): Remove shadowed variable.
14060
14061 2019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
14062
14063 * features/riscv/32bit-cpu.xml: Add register numbers.
14064 * features/riscv/32bit-fpu.c: Regenerate.
14065 * features/riscv/32bit-fpu.xml: Add register numbers.
14066 * features/riscv/64bit-cpu.xml: Add register numbers.
14067 * features/riscv/64bit-fpu.c: Regenerate.
14068 * features/riscv/64bit-fpu.xml: Add register numbers.
14069
14070 2019-02-26 Kevin Buettner <kevinb@redhat.com>
14071
14072 * NEWS: Mention two argument form of gdb.Value constructor.
14073 * python/py-value.c (convert_buffer_and_type_to_value): New
14074 function.
14075 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14076 Add support for handling an optional second argument. Call
14077 convert_buffer_and_type_to_value as appropriate.
14078 * python/python-internal.h (Py_buffer_deleter): New struct.
14079 (Py_buffer_up): New typedef.
14080
14081 2019-02-25 John Baldwin <jhb@FreeBSD.org>
14082
14083 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14084 instead of releasing ownership.
14085
14086 2019-02-25 Jordan Rupprecht <rupprecht@google.com>
14087
14088 * dwarf2read.c (open_and_init_dwp_file): Call
14089 elf_numsections instead of bfd_count_sections to initialize
14090 dwp_file->num_sections.
14091
14092 2019-02-25 Tom Tromey <tromey@adacore.com>
14093
14094 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14095
14096 2019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
14097
14098 * gcore.in: Add '--readnever' option when invoking GDB.
14099
14100 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14101
14102 * MAINTAINERS: Update my email address.
14103
14104 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14105
14106 * build-id.c (build_id_to_debug_bfd_1): New function.
14107 (build_id_to_debug_bfd): Look for separate debug file in
14108 sysroot.
14109
14110 2019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
14111
14112 * gdbarch.sh: Update the copyright year range that is placed into
14113 generated files.
14114
14115 2019-02-22 Keith Seitz <keiths@redhat.com>
14116
14117 PR symtab/23853
14118 * linespec.c (create_sals_line_offset): Search for the default
14119 symtab's filename instead of its fullname.
14120
14121 2019-02-21 Alan Hayward <alan.hayward@arm.com>
14122
14123 * NEWS: Update style defaults.
14124
14125 2019-02-21 Alan Hayward <alan.hayward@arm.com>
14126
14127 * main.c (captured_main_1): Disable styling in batch mode.
14128
14129 2019-02-20 Tom Tromey <tom@tromey.com>
14130
14131 * symtab.c (symtab_symbol_info): Fix typos.
14132
14133 2019-02-20 Tom Tromey <tromey@adacore.com>
14134
14135 * findcmd.c (_initialize_mem_search): Use upper case for
14136 metasyntactic variables.
14137
14138 2019-02-20 Alan Hayward <alan.hayward@arm.com>
14139
14140 * aarch64-tdep.c (aarch64_add_reggroups): New function.
14141 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14142
14143 2019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
14144
14145 * top.h (source_file_name): Change to std::string.
14146 * top.c (source_file_name): Likewise.
14147 (command_line_input): Adjust.
14148 * cli/cli-script.c (script_from_file): Adjust.
14149
14150 2019-02-19 Tom Tromey <tromey@adacore.com>
14151
14152 * ravenscar-thread.c
14153 (ravenscar_thread_target::update_thread_list): Don't call
14154 ada_build_task_list.
14155 * ada-lang.h (ada_build_task_list): Don't declare.
14156 * ada-tasks.c (struct ada_tasks_inferior_data)
14157 <task_list_valid_p>: Now bool.
14158 (read_known_tasks, ada_task_list_changed)
14159 (ada_tasks_invalidate_inferior_data): Update.
14160 (read_known_tasks_array): Return bool.
14161 (read_known_tasks_list): Likewise.
14162 (read_known_tasks): Return void.
14163 (ada_build_task_list): Now static.
14164
14165 2019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
14166
14167 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14168 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14169
14170 2019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14171
14172 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14173 variant for ada_tasks_pspace_data_handle and
14174 ada_tasks_inferior_data_handle.
14175 (ada_tasks_pspace_data_cleanup): New function.
14176 (ada_tasks_inferior_data_cleanup): New function.
14177
14178 2019-02-17 Tom Tromey <tom@tromey.com>
14179
14180 * macrotab.h (macro_source_fullname): Return a std::string.
14181 * macrotab.c (macro_include, check_for_redefinition)
14182 (macro_undef, macro_lookup_definition, foreach_macro)
14183 (foreach_macro_in_scope): Update.
14184 (macro_source_fullname): Return a std::string.
14185 * macrocmd.c (show_pp_source_pos): Update.
14186
14187 2019-02-17 Tom Tromey <tom@tromey.com>
14188
14189 * macrocmd.c (show_pp_source_pos): Style the file names.
14190
14191 2019-02-17 Tom Tromey <tom@tromey.com>
14192
14193 PR tui/24197:
14194 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14195
14196 2019-02-17 Tom Tromey <tom@tromey.com>
14197
14198 * ada-lang.c (user_select_syms): Use filtered printing.
14199 * utils.c (wrap_style): New global.
14200 (desired_style): Remove.
14201 (emit_style_escape): Add stream parameter.
14202 (set_output_style, reset_terminal_style, prompt_for_continue):
14203 Update.
14204 (flush_wrap_buffer): Only flush gdb_stdout.
14205 (wrap_here): Set wrap_style.
14206 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
14207 treat escape sequences as a character. Change when wrap buffer is
14208 flushed.
14209 (fputs_styled): Do not set the output style when the default is
14210 requested.
14211 * ui-style.h (struct ui_file_style) <is_default>: New method.
14212 * source.c (print_source_lines_base): Emit escape sequences in one
14213 piece.
14214
14215 2019-02-17 Joel Brobecker <brobecker@adacore.com>
14216
14217 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14218 integers and enumeration types.
14219
14220 2019-02-17 Joel Brobecker <brobecker@adacore.com>
14221
14222 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14223 instead of lookup_symbol_in_language
14224 (do_exact_match): New function.
14225 (ada_get_symbol_name_matcher): Return do_exact_match when
14226 doing a verbatim match.
14227
14228 2019-02-15 Tom Tromey <tromey@adacore.com>
14229
14230 * ravenscar-thread.c (ravenscar_thread_target::resume)
14231 (ravenscar_thread_target::wait): Special case wildcard requests.
14232
14233 2019-02-15 Tom Tromey <tromey@adacore.com>
14234
14235 * ravenscar-thread.c (base_ptid): Remove.
14236 (struct ravenscar_thread_target) <close>: New method.
14237 <m_base_ptid>: New member.
14238 <update_inferior_ptid, active_task, task_is_currently_active,
14239 runtime_initialized>: Declare methods.
14240 <ravenscar_thread_target>: Add constructor.
14241 (ravenscar_thread_target::task_is_currently_active)
14242 (ravenscar_thread_target::update_inferior_ptid)
14243 (ravenscar_runtime_initialized): Rename. Now methods.
14244 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14245 (ravenscar_thread_target::update_thread_list): Update.
14246 (ravenscar_thread_target::active_task): Now method.
14247 (ravenscar_thread_target::store_registers)
14248 (ravenscar_thread_target::prepare_to_store)
14249 (ravenscar_thread_target::prepare_to_store)
14250 (ravenscar_thread_target::mourn_inferior): Update.
14251 (ravenscar_inferior_created): Use "new" to create target.
14252 (ravenscar_thread_target::get_ada_task_ptid): Update.
14253 (_initialize_ravenscar): Don't initialize base_ptid.
14254 (ravenscar_ops): Remove global.
14255
14256 2019-02-15 Tom Tromey <tromey@adacore.com>
14257
14258 * target.h (push_target): Declare new overload.
14259 * target.c (push_target): New overload, taking an rvalue reference.
14260 * remote.c (remote_target::open_1): Use push_target overload.
14261 * corelow.c (core_target_open): Use push_target overload.
14262
14263 2019-02-15 Tom Tromey <tromey@adacore.com>
14264
14265 * ravenscar-thread.c (is_ravenscar_task)
14266 (ravenscar_task_is_currently_active): Return bool.
14267 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14268 (_initialize_ravenscar): Remove "(void)".
14269 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14270 Return bool.
14271
14272 2019-02-15 Tom Tromey <tromey@adacore.com>
14273
14274 * ravenscar-thread.c (ravenscar_runtime_initializer)
14275 (has_ravenscar_runtime, get_running_thread_id)
14276 (ravenscar_thread_target::resume): Fix indentation.
14277
14278 2019-02-15 Tom Tromey <tromey@adacore.com>
14279
14280 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
14281 from ravenscar_arch_ops.
14282 (sparc_ravenscar_ops::fetch_registers)
14283 (sparc_ravenscar_ops::store_registers): Now methods.
14284 (sparc_ravenscar_prepare_to_store): Remove.
14285 (sparc_ravenscar_ops): Redefine.
14286 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
14287 methods and destructor. Remove members.
14288 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
14289 (ravenscar_thread_target::store_registers)
14290 (ravenscar_thread_target::prepare_to_store): Update.
14291 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
14292 Remove.
14293 (struct ppc_ravenscar_powerpc_ops): Derive from
14294 ravenscar_arch_ops.
14295 (ppc_ravenscar_powerpc_ops::fetch_registers)
14296 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
14297 (ppc_ravenscar_powerpc_ops): Redefine.
14298 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
14299 (ppc_ravenscar_e500_ops::fetch_registers)
14300 (ppc_ravenscar_e500_ops::store_registers): Now methods.
14301 (ppc_ravenscar_e500_ops): Redefine.
14302 * aarch64-ravenscar-thread.c
14303 (aarch64_ravenscar_generic_prepare_to_store): Remove.
14304 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
14305 (aarch64_ravenscar_fetch_registers)
14306 (aarch64_ravenscar_store_registers): Now methods.
14307 (aarch64_ravenscar_ops): Redefine.
14308
14309 2019-02-15 Tom Tromey <tromey@adacore.com>
14310
14311 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
14312 (ravenscar_thread_target::stopped_by_hw_breakpoint)
14313 (ravenscar_thread_target::stopped_by_watchpoint)
14314 (ravenscar_thread_target::stopped_data_address)
14315 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
14316
14317 2019-02-15 Tom Tromey <tromey@adacore.com>
14318
14319 * ravenscar-thread.c: Fix some typos.
14320
14321 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14322 Tom Tromey <tromey@adacore.com>
14323
14324 * ada-lang.c (ada_exception_sal): Change addr_string to a
14325 std::string.
14326 (create_ada_exception_catchpoint): Update.
14327
14328 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14329 Tom Tromey <tromey@adacore.com>
14330
14331 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
14332 (bp_location_ops): Remove.
14333 (base_breakpoint_allocate_location): Update.
14334 (free_bp_location): Update.
14335 * ada-lang.c (class ada_catchpoint_location)
14336 <ada_catchpoint_location>: Remove ops parameter.
14337 (ada_catchpoint_location_dtor): Remove.
14338 (ada_catchpoint_location_ops): Remove.
14339 (allocate_location_exception): Update.
14340 * breakpoint.h (struct bp_location_ops): Remove.
14341 (class bp_location) <bp_location>: Remove bp_location_ops
14342 parameter.
14343 <~bp_location>: Add destructor.
14344 <ops>: Remove.
14345
14346 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14347 Pedro Alves <palves@redhat.com>
14348
14349 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
14350 'PATH_MAX'.
14351
14352 2019-02-14 David Michael <fedora.dm0@gmail.com>
14353 Samuel Thibault <samuel.thibault@gnu.org>
14354 Thomas Schwinge <thomas@codesourcery.com>
14355
14356 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
14357 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
14358
14359 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14360
14361 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
14362 (check_empty): Use "const char *".
14363
14364 * gnu-nat.c (gnu_nat_target::detach): Instead of
14365 'detach_inferior (pid)' call
14366 'detach_inferior (find_inferior_pid (pid))'.
14367
14368 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
14369 'nat/fork-inferior.o'.
14370 * gnu-nat.c: #include "nat/fork-inferior.h".
14371
14372 * gnu-nat.c (gnu_nat_target::detach): Instead of
14373 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
14374 * gnu-nat.h: #include "inf-child.h".
14375 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
14376 'i386_gnu_nat_target::fetch_registers'.
14377 (gnu_store_registers): Rename/move to
14378 'i386_gnu_nat_target::store_registers'.
14379
14380 * config/i386/nm-i386gnu.h: Don't "#include" any files.
14381 * gnu-nat.h (mach_thread_info): New function.
14382 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
14383
14384 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
14385
14386 2019-02-14 Frederic Konrad <konrad@adacore.com>
14387
14388 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
14389
14390 2019-02-14 Joel Brobecker <brobecker@adacore.com>
14391
14392 * windows-nat.c (windows_add_thread): Add new parameter
14393 "main_thread_p" with default value set to false. Update
14394 function documentation as well as all callers.
14395 (windows_delete_thread): Likewise.
14396 (fake_create_process): Update call to windows_add_thread.
14397 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
14398 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
14399 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
14400 call to windows_delete_thread.
14401
14402 2019-02-13 Simon Marchi <simon.marchi@ericsson.com>
14403
14404 * MAINTAINERS: Add Andrew Burgess as global maintainer.
14405
14406 2019-02-12 John Baldwin <jhb@FreeBSD.org>
14407
14408 * symfile.c (find_separate_debug_file): Use canonical path of
14409 sysroot with child_path instead of gdb_sysroot if it is valid.
14410
14411 2019-02-12 John Baldwin <jhb@FreeBSD.org>
14412
14413 * symfile.c (find_separate_debug_file): Use child_path to
14414 determine if an object file is under a sysroot.
14415
14416 2019-02-12 John Baldwin <jhb@FreeBSD.org>
14417
14418 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
14419 unittests/child-path-selftests.c.
14420 * common/pathstuff.c (child_path): New function.
14421 * common/pathstuff.h (child_path): New prototype.
14422 * unittests/child-path-selftests.c: New file.
14423
14424 2019-02-12 John Baldwin <jhb@FreeBSD.org>
14425
14426 * symfile.c (find_separate_debug_file): Look for separate debug
14427 files in debug directories under the sysroot.
14428
14429 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14430
14431 * symtab.h (struct minimal_symbol data_p): New const method.
14432 (struct minimal_symbol text_p): Likewise.
14433 * symtab.c (output_source_filename): Use file name style
14434 to print file name.
14435 (print_symbol_info): Likewise.
14436 (print_msymbol_info): Use address style to print addresses.
14437 Use function name style to print executable text symbols.
14438 (expand_symtab_containing_pc): Use data_p.
14439 (find_pc_sect_compunit_symtab): Likewise.
14440
14441 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14442
14443 * breakpoint.c (describe_other_breakpoints): Use address style
14444 to print addresses.
14445 (say_where): Likewise.
14446
14447 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14448
14449 * ada-typeprint.c (print_func_type): Print function name
14450 style to print function name.
14451 * c-typeprint.c (c_print_type_1): Likewise.
14452
14453 2019-02-11 Alan Hayward <alan.hayward@arm.com>
14454
14455 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
14456 for execve.
14457
14458 2019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14459
14460 * c-exp.y (direct_abs_decl): Use emplace_back to record the
14461 type_stack.
14462
14463 2019-02-10 Joel Brobecker <brobecker@adacore.com>
14464
14465 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
14466 TYPE_CODE_REF types.
14467
14468 2019-02-08 Jim Wilson <jimw@sifive.com>
14469
14470 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
14471 (riscv_linux_fregset): New.
14472 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
14473
14474 2019-02-07 Tom Tromey <tom@tromey.com>
14475
14476 * thread.c (thread_cancel_execution_command): Update.
14477 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
14478 methods.
14479 (struct thread_fsm_ops): Remove.
14480 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
14481 (thread_fsm_should_stop, thread_fsm_return_value)
14482 (thread_fsm_set_finished, thread_fsm_finished_p)
14483 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
14484 Don't declare.
14485 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
14486 * infrun.c (clear_proceed_status_thread)
14487 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
14488 (print_stop_event): Update.
14489 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
14490 Add constructor.
14491 (step_command_fsm_ops): Remove.
14492 (new_step_command_fsm): Remove.
14493 (step_1): Update.
14494 (step_command_fsm::should_stop): Rename from
14495 step_command_fsm_should_stop.
14496 (step_command_fsm::clean_up): Rename from
14497 step_command_fsm_clean_up.
14498 (step_command_fsm::do_async_reply_reason): Rename from
14499 step_command_fsm_async_reply_reason.
14500 (struct until_next_fsm): Inherit from thread_fsm. Add
14501 constructor.
14502 (until_next_fsm_ops): Remove.
14503 (new_until_next_fsm): Remove.
14504 (until_next_fsm::should_stop): Rename from
14505 until_next_fsm_should_stop.
14506 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
14507 (until_next_fsm::do_async_reply_reason): Rename from
14508 until_next_fsm_async_reply_reason.
14509 (struct finish_command_fsm): Inherit from thread_fsm. Add
14510 constructor. Change type of breakpoint.
14511 (finish_command_fsm_ops): Remove.
14512 (new_finish_command_fsm): Remove.
14513 (finish_command_fsm::should_stop): Rename from
14514 finish_command_fsm_should_stop.
14515 (finish_command_fsm::clean_up): Rename from
14516 finish_command_fsm_clean_up.
14517 (finish_command_fsm::return_value): Rename from
14518 finish_command_fsm_return_value.
14519 (finish_command_fsm::do_async_reply_reason): Rename from
14520 finish_command_fsm_async_reply_reason.
14521 (finish_command): Update.
14522 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
14523 Add constructor.
14524 (call_thread_fsm_ops): Remove.
14525 (call_thread_fsm::call_thread_fsm): Rename from
14526 new_call_thread_fsm.
14527 (call_thread_fsm::should_stop): Rename from
14528 call_thread_fsm_should_stop.
14529 (call_thread_fsm::should_notify_stop): Rename from
14530 call_thread_fsm_should_notify_stop.
14531 (run_inferior_call, call_function_by_hand_dummy): Update.
14532 * cli/cli-interp.c (should_print_stop_to_console): Update.
14533 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
14534 Add constructor. Change type of location_breakpoint,
14535 caller_breakpoint.
14536 (until_break_fsm_ops): Remove.
14537 (new_until_break_fsm): Remove.
14538 (until_break_fsm::should_stop): Rename from
14539 until_break_fsm_should_stop.
14540 (until_break_fsm::clean_up): Rename from
14541 until_break_fsm_clean_up.
14542 (until_break_fsm::do_async_reply_reason): Rename from
14543 until_break_fsm_async_reply_reason.
14544 (until_break_command): Update.
14545 * thread-fsm.c: Remove.
14546 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
14547
14548 2019-02-07 Tom Tromey <tom@tromey.com>
14549
14550 * yy-remap.h: Add include guard.
14551 * xtensa-tdep.h: Add include guard.
14552 * xcoffread.h: Rename include guard.
14553 * varobj-iter.h: Add include guard.
14554 * tui/tui.h: Rename include guard.
14555 * tui/tui-winsource.h: Rename include guard.
14556 * tui/tui-wingeneral.h: Rename include guard.
14557 * tui/tui-windata.h: Rename include guard.
14558 * tui/tui-win.h: Rename include guard.
14559 * tui/tui-stack.h: Rename include guard.
14560 * tui/tui-source.h: Rename include guard.
14561 * tui/tui-regs.h: Rename include guard.
14562 * tui/tui-out.h: Rename include guard.
14563 * tui/tui-layout.h: Rename include guard.
14564 * tui/tui-io.h: Rename include guard.
14565 * tui/tui-hooks.h: Rename include guard.
14566 * tui/tui-file.h: Rename include guard.
14567 * tui/tui-disasm.h: Rename include guard.
14568 * tui/tui-data.h: Rename include guard.
14569 * tui/tui-command.h: Rename include guard.
14570 * tic6x-tdep.h: Add include guard.
14571 * target/waitstatus.h: Rename include guard.
14572 * target/wait.h: Rename include guard.
14573 * target/target.h: Rename include guard.
14574 * target/resume.h: Rename include guard.
14575 * target-float.h: Rename include guard.
14576 * stabsread.h: Add include guard.
14577 * rs6000-tdep.h: Add include guard.
14578 * riscv-fbsd-tdep.h: Add include guard.
14579 * regformats/regdef.h: Rename include guard.
14580 * record.h: Rename include guard.
14581 * python/python.h: Rename include guard.
14582 * python/python-internal.h: Rename include guard.
14583 * python/py-stopevent.h: Rename include guard.
14584 * python/py-ref.h: Rename include guard.
14585 * python/py-record.h: Rename include guard.
14586 * python/py-record-full.h: Rename include guard.
14587 * python/py-record-btrace.h: Rename include guard.
14588 * python/py-instruction.h: Rename include guard.
14589 * python/py-events.h: Rename include guard.
14590 * python/py-event.h: Rename include guard.
14591 * procfs.h: Add include guard.
14592 * proc-utils.h: Add include guard.
14593 * p-lang.h: Add include guard.
14594 * or1k-tdep.h: Rename include guard.
14595 * observable.h: Rename include guard.
14596 * nto-tdep.h: Rename include guard.
14597 * nat/x86-linux.h: Rename include guard.
14598 * nat/x86-linux-dregs.h: Rename include guard.
14599 * nat/x86-gcc-cpuid.h: Add include guard.
14600 * nat/x86-dregs.h: Rename include guard.
14601 * nat/x86-cpuid.h: Rename include guard.
14602 * nat/ppc-linux.h: Rename include guard.
14603 * nat/mips-linux-watch.h: Rename include guard.
14604 * nat/linux-waitpid.h: Rename include guard.
14605 * nat/linux-ptrace.h: Rename include guard.
14606 * nat/linux-procfs.h: Rename include guard.
14607 * nat/linux-osdata.h: Rename include guard.
14608 * nat/linux-nat.h: Rename include guard.
14609 * nat/linux-namespaces.h: Rename include guard.
14610 * nat/linux-btrace.h: Rename include guard.
14611 * nat/glibc_thread_db.h: Rename include guard.
14612 * nat/gdb_thread_db.h: Rename include guard.
14613 * nat/gdb_ptrace.h: Rename include guard.
14614 * nat/fork-inferior.h: Rename include guard.
14615 * nat/amd64-linux-siginfo.h: Rename include guard.
14616 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
14617 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
14618 * nat/aarch64-linux.h: Rename include guard.
14619 * nat/aarch64-linux-hw-point.h: Rename include guard.
14620 * mn10300-tdep.h: Add include guard.
14621 * mips-linux-tdep.h: Add include guard.
14622 * mi/mi-parse.h: Rename include guard.
14623 * mi/mi-out.h: Rename include guard.
14624 * mi/mi-main.h: Rename include guard.
14625 * mi/mi-interp.h: Rename include guard.
14626 * mi/mi-getopt.h: Rename include guard.
14627 * mi/mi-console.h: Rename include guard.
14628 * mi/mi-common.h: Rename include guard.
14629 * mi/mi-cmds.h: Rename include guard.
14630 * mi/mi-cmd-break.h: Rename include guard.
14631 * m2-lang.h: Add include guard.
14632 * location.h: Rename include guard.
14633 * linux-record.h: Rename include guard.
14634 * linux-nat.h: Add include guard.
14635 * linux-fork.h: Add include guard.
14636 * i386-darwin-tdep.h: Rename include guard.
14637 * hppa-linux-offsets.h: Add include guard.
14638 * guile/guile.h: Rename include guard.
14639 * guile/guile-internal.h: Rename include guard.
14640 * gnu-nat.h: Rename include guard.
14641 * gdb-stabs.h: Rename include guard.
14642 * frv-tdep.h: Add include guard.
14643 * f-lang.h: Add include guard.
14644 * event-loop.h: Add include guard.
14645 * darwin-nat.h: Rename include guard.
14646 * cp-abi.h: Rename include guard.
14647 * config/sparc/nm-sol2.h: Rename include guard.
14648 * config/nm-nto.h: Rename include guard.
14649 * config/nm-linux.h: Add include guard.
14650 * config/i386/nm-i386gnu.h: Rename include guard.
14651 * config/djgpp/nl_types.h: Rename include guard.
14652 * config/djgpp/langinfo.h: Rename include guard.
14653 * compile/gcc-cp-plugin.h: Add include guard.
14654 * compile/gcc-c-plugin.h: Add include guard.
14655 * compile/compile.h: Rename include guard.
14656 * compile/compile-object-run.h: Rename include guard.
14657 * compile/compile-object-load.h: Rename include guard.
14658 * compile/compile-internal.h: Rename include guard.
14659 * compile/compile-cplus.h: Rename include guard.
14660 * compile/compile-c.h: Rename include guard.
14661 * common/xml-utils.h: Rename include guard.
14662 * common/x86-xstate.h: Rename include guard.
14663 * common/version.h: Rename include guard.
14664 * common/vec.h: Rename include guard.
14665 * common/tdesc.h: Rename include guard.
14666 * common/selftest.h: Rename include guard.
14667 * common/scoped_restore.h: Rename include guard.
14668 * common/scoped_mmap.h: Rename include guard.
14669 * common/scoped_fd.h: Rename include guard.
14670 * common/safe-iterator.h: Rename include guard.
14671 * common/run-time-clock.h: Rename include guard.
14672 * common/refcounted-object.h: Rename include guard.
14673 * common/queue.h: Rename include guard.
14674 * common/ptid.h: Rename include guard.
14675 * common/print-utils.h: Rename include guard.
14676 * common/preprocessor.h: Rename include guard.
14677 * common/pathstuff.h: Rename include guard.
14678 * common/observable.h: Rename include guard.
14679 * common/netstuff.h: Rename include guard.
14680 * common/job-control.h: Rename include guard.
14681 * common/host-defs.h: Rename include guard.
14682 * common/gdb_wait.h: Rename include guard.
14683 * common/gdb_vecs.h: Rename include guard.
14684 * common/gdb_unlinker.h: Rename include guard.
14685 * common/gdb_unique_ptr.h: Rename include guard.
14686 * common/gdb_tilde_expand.h: Rename include guard.
14687 * common/gdb_sys_time.h: Rename include guard.
14688 * common/gdb_string_view.h: Rename include guard.
14689 * common/gdb_splay_tree.h: Rename include guard.
14690 * common/gdb_setjmp.h: Rename include guard.
14691 * common/gdb_ref_ptr.h: Rename include guard.
14692 * common/gdb_optional.h: Rename include guard.
14693 * common/gdb_locale.h: Rename include guard.
14694 * common/gdb_assert.h: Rename include guard.
14695 * common/filtered-iterator.h: Rename include guard.
14696 * common/filestuff.h: Rename include guard.
14697 * common/fileio.h: Rename include guard.
14698 * common/environ.h: Rename include guard.
14699 * common/common-utils.h: Rename include guard.
14700 * common/common-types.h: Rename include guard.
14701 * common/common-regcache.h: Rename include guard.
14702 * common/common-inferior.h: Rename include guard.
14703 * common/common-gdbthread.h: Rename include guard.
14704 * common/common-exceptions.h: Rename include guard.
14705 * common/common-defs.h: Rename include guard.
14706 * common/common-debug.h: Rename include guard.
14707 * common/cleanups.h: Rename include guard.
14708 * common/buffer.h: Rename include guard.
14709 * common/btrace-common.h: Rename include guard.
14710 * common/break-common.h: Rename include guard.
14711 * cli/cli-utils.h: Rename include guard.
14712 * cli/cli-style.h: Rename include guard.
14713 * cli/cli-setshow.h: Rename include guard.
14714 * cli/cli-script.h: Rename include guard.
14715 * cli/cli-interp.h: Rename include guard.
14716 * cli/cli-decode.h: Rename include guard.
14717 * cli/cli-cmds.h: Rename include guard.
14718 * charset-list.h: Add include guard.
14719 * buildsym-legacy.h: Rename include guard.
14720 * bfin-tdep.h: Add include guard.
14721 * ax.h: Rename include guard.
14722 * arm-linux-tdep.h: Add include guard.
14723 * arm-fbsd-tdep.h: Add include guard.
14724 * arch/xtensa.h: Rename include guard.
14725 * arch/tic6x.h: Add include guard.
14726 * arch/i386.h: Add include guard.
14727 * arch/arm.h: Rename include guard.
14728 * arch/arm-linux.h: Rename include guard.
14729 * arch/arm-get-next-pcs.h: Rename include guard.
14730 * arch/amd64.h: Add include guard.
14731 * arch/aarch64-insn.h: Rename include guard.
14732 * arch-utils.h: Rename include guard.
14733 * annotate.h: Add include guard.
14734 * amd64-darwin-tdep.h: Rename include guard.
14735 * aarch64-linux-tdep.h: Add include guard.
14736 * aarch64-fbsd-tdep.h: Add include guard.
14737 * aarch32-linux-nat.h: Add include guard.
14738
14739 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14740
14741 * macrotab.c (macro_define_internal): New function that
14742 factorizes macro_define_object_internal and macro_define_function
14743 code.
14744 (macro_define_object_internal): Use macro_define_internal.
14745 (macro_define_function): Likewise.
14746
14747 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14748
14749 * macrocmd.c (extract_identifier): Return
14750 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
14751 callers.
14752
14753 2019-02-06 John Baldwin <jhb@FreeBSD.org>
14754
14755 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
14756
14757 2019-02-05 Tom Tromey <tom@tromey.com>
14758
14759 * target.c (target_stack::unpush): Move assertion earlier.
14760
14761 2019-01-30 Tom Tromey <tom@tromey.com>
14762
14763 PR python/23615:
14764 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
14765 (gdbpy_parse_and_eval): Likewise.
14766 * python/python-internal.h (gdbpy_allow_threads): New class.
14767
14768 2019-01-28 John Baldwin <jhb@FreeBSD.org>
14769
14770 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
14771 (aarch64_fbsd_fpregmap): Move earlier.
14772 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
14773 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14774 instead of individual calls to trad_frame_set_reg_addr.
14775 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
14776 earlier.
14777 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
14778 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14779 instead of individual calls to trad_frame_set_reg_addr.
14780
14781 2019-01-28 Alan Hayward <alan.hayward@arm.com>
14782
14783 * CONTRIBUTE: Replace contribution list with wiki link.
14784
14785 2019-01-25 Tom Tromey <tom@tromey.com>
14786
14787 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
14788
14789 2019-01-25 Tom Tromey <tom@tromey.com>
14790
14791 * xtensa-linux-nat.c: Fix common/ includes.
14792 * xml-support.h: Fix common/ includes.
14793 * xml-support.c: Fix common/ includes.
14794 * x86-linux-nat.c: Fix common/ includes.
14795 * windows-nat.c: Fix common/ includes.
14796 * varobj.h: Fix common/ includes.
14797 * varobj.c: Fix common/ includes.
14798 * value.c: Fix common/ includes.
14799 * valops.c: Fix common/ includes.
14800 * utils.c: Fix common/ includes.
14801 * unittests/xml-utils-selftests.c: Fix common/ includes.
14802 * unittests/utils-selftests.c: Fix common/ includes.
14803 * unittests/unpack-selftests.c: Fix common/ includes.
14804 * unittests/tracepoint-selftests.c: Fix common/ includes.
14805 * unittests/style-selftests.c: Fix common/ includes.
14806 * unittests/string_view-selftests.c: Fix common/ includes.
14807 * unittests/scoped_restore-selftests.c: Fix common/ includes.
14808 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
14809 * unittests/scoped_fd-selftests.c: Fix common/ includes.
14810 * unittests/rsp-low-selftests.c: Fix common/ includes.
14811 * unittests/parse-connection-spec-selftests.c: Fix common/
14812 includes.
14813 * unittests/optional-selftests.c: Fix common/ includes.
14814 * unittests/offset-type-selftests.c: Fix common/ includes.
14815 * unittests/observable-selftests.c: Fix common/ includes.
14816 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
14817 * unittests/memrange-selftests.c: Fix common/ includes.
14818 * unittests/memory-map-selftests.c: Fix common/ includes.
14819 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
14820 * unittests/function-view-selftests.c: Fix common/ includes.
14821 * unittests/environ-selftests.c: Fix common/ includes.
14822 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
14823 * unittests/common-utils-selftests.c: Fix common/ includes.
14824 * unittests/cli-utils-selftests.c: Fix common/ includes.
14825 * unittests/array-view-selftests.c: Fix common/ includes.
14826 * ui-file.c: Fix common/ includes.
14827 * tui/tui-io.c: Fix common/ includes.
14828 * tracepoint.h: Fix common/ includes.
14829 * tracepoint.c: Fix common/ includes.
14830 * tracefile-tfile.c: Fix common/ includes.
14831 * top.h: Fix common/ includes.
14832 * top.c: Fix common/ includes.
14833 * thread.c: Fix common/ includes.
14834 * target/waitstatus.h: Fix common/ includes.
14835 * target/waitstatus.c: Fix common/ includes.
14836 * target.h: Fix common/ includes.
14837 * target.c: Fix common/ includes.
14838 * target-memory.c: Fix common/ includes.
14839 * target-descriptions.c: Fix common/ includes.
14840 * symtab.h: Fix common/ includes.
14841 * symfile.c: Fix common/ includes.
14842 * stap-probe.c: Fix common/ includes.
14843 * spu-linux-nat.c: Fix common/ includes.
14844 * sparc-nat.c: Fix common/ includes.
14845 * source.c: Fix common/ includes.
14846 * solib.c: Fix common/ includes.
14847 * solib-target.c: Fix common/ includes.
14848 * ser-unix.c: Fix common/ includes.
14849 * ser-tcp.c: Fix common/ includes.
14850 * ser-pipe.c: Fix common/ includes.
14851 * ser-base.c: Fix common/ includes.
14852 * selftest-arch.c: Fix common/ includes.
14853 * s12z-tdep.c: Fix common/ includes.
14854 * rust-exp.y: Fix common/ includes.
14855 * rs6000-aix-tdep.c: Fix common/ includes.
14856 * riscv-tdep.c: Fix common/ includes.
14857 * remote.c: Fix common/ includes.
14858 * remote-notif.h: Fix common/ includes.
14859 * remote-fileio.h: Fix common/ includes.
14860 * remote-fileio.c: Fix common/ includes.
14861 * regcache.h: Fix common/ includes.
14862 * regcache.c: Fix common/ includes.
14863 * record-btrace.c: Fix common/ includes.
14864 * python/python.c: Fix common/ includes.
14865 * python/py-type.c: Fix common/ includes.
14866 * python/py-inferior.c: Fix common/ includes.
14867 * progspace.h: Fix common/ includes.
14868 * producer.c: Fix common/ includes.
14869 * procfs.c: Fix common/ includes.
14870 * proc-api.c: Fix common/ includes.
14871 * printcmd.c: Fix common/ includes.
14872 * ppc-linux-nat.c: Fix common/ includes.
14873 * parser-defs.h: Fix common/ includes.
14874 * osdata.c: Fix common/ includes.
14875 * obsd-nat.c: Fix common/ includes.
14876 * nat/x86-linux.c: Fix common/ includes.
14877 * nat/x86-linux-dregs.c: Fix common/ includes.
14878 * nat/x86-dregs.h: Fix common/ includes.
14879 * nat/x86-dregs.c: Fix common/ includes.
14880 * nat/ppc-linux.c: Fix common/ includes.
14881 * nat/mips-linux-watch.h: Fix common/ includes.
14882 * nat/mips-linux-watch.c: Fix common/ includes.
14883 * nat/linux-waitpid.c: Fix common/ includes.
14884 * nat/linux-ptrace.h: Fix common/ includes.
14885 * nat/linux-ptrace.c: Fix common/ includes.
14886 * nat/linux-procfs.c: Fix common/ includes.
14887 * nat/linux-personality.c: Fix common/ includes.
14888 * nat/linux-osdata.c: Fix common/ includes.
14889 * nat/linux-namespaces.c: Fix common/ includes.
14890 * nat/linux-btrace.h: Fix common/ includes.
14891 * nat/linux-btrace.c: Fix common/ includes.
14892 * nat/fork-inferior.c: Fix common/ includes.
14893 * nat/amd64-linux-siginfo.c: Fix common/ includes.
14894 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
14895 * nat/aarch64-linux.c: Fix common/ includes.
14896 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
14897 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
14898 * namespace.h: Fix common/ includes.
14899 * mips-linux-tdep.c: Fix common/ includes.
14900 * minsyms.c: Fix common/ includes.
14901 * mi/mi-parse.h: Fix common/ includes.
14902 * mi/mi-main.c: Fix common/ includes.
14903 * mi/mi-cmd-env.c: Fix common/ includes.
14904 * memrange.h: Fix common/ includes.
14905 * memattr.c: Fix common/ includes.
14906 * maint.h: Fix common/ includes.
14907 * maint.c: Fix common/ includes.
14908 * main.c: Fix common/ includes.
14909 * machoread.c: Fix common/ includes.
14910 * location.c: Fix common/ includes.
14911 * linux-thread-db.c: Fix common/ includes.
14912 * linux-nat.c: Fix common/ includes.
14913 * linux-fork.c: Fix common/ includes.
14914 * inline-frame.c: Fix common/ includes.
14915 * infrun.c: Fix common/ includes.
14916 * inflow.c: Fix common/ includes.
14917 * inferior.h: Fix common/ includes.
14918 * inferior.c: Fix common/ includes.
14919 * infcmd.c: Fix common/ includes.
14920 * inf-ptrace.c: Fix common/ includes.
14921 * inf-child.c: Fix common/ includes.
14922 * ia64-linux-nat.c: Fix common/ includes.
14923 * i387-tdep.c: Fix common/ includes.
14924 * i386-tdep.c: Fix common/ includes.
14925 * i386-linux-tdep.c: Fix common/ includes.
14926 * i386-linux-nat.c: Fix common/ includes.
14927 * i386-go32-tdep.c: Fix common/ includes.
14928 * i386-fbsd-tdep.c: Fix common/ includes.
14929 * i386-fbsd-nat.c: Fix common/ includes.
14930 * guile/scm-type.c: Fix common/ includes.
14931 * guile/guile.c: Fix common/ includes.
14932 * go32-nat.c: Fix common/ includes.
14933 * gnu-nat.c: Fix common/ includes.
14934 * gdbthread.h: Fix common/ includes.
14935 * gdbarch-selftests.c: Fix common/ includes.
14936 * gdb_usleep.c: Fix common/ includes.
14937 * gdb_select.h: Fix common/ includes.
14938 * gdb_bfd.c: Fix common/ includes.
14939 * gcore.c: Fix common/ includes.
14940 * fork-child.c: Fix common/ includes.
14941 * findvar.c: Fix common/ includes.
14942 * fbsd-nat.c: Fix common/ includes.
14943 * event-top.c: Fix common/ includes.
14944 * event-loop.c: Fix common/ includes.
14945 * dwarf2read.c: Fix common/ includes.
14946 * dwarf2loc.c: Fix common/ includes.
14947 * dwarf2-frame.c: Fix common/ includes.
14948 * dwarf-index-cache.c: Fix common/ includes.
14949 * dtrace-probe.c: Fix common/ includes.
14950 * disasm-selftests.c: Fix common/ includes.
14951 * defs.h: Fix common/ includes.
14952 * csky-tdep.c: Fix common/ includes.
14953 * cp-valprint.c: Fix common/ includes.
14954 * cp-support.h: Fix common/ includes.
14955 * cp-support.c: Fix common/ includes.
14956 * corelow.c: Fix common/ includes.
14957 * completer.h: Fix common/ includes.
14958 * completer.c: Fix common/ includes.
14959 * compile/compile.c: Fix common/ includes.
14960 * compile/compile-loc2c.c: Fix common/ includes.
14961 * compile/compile-cplus-types.c: Fix common/ includes.
14962 * compile/compile-cplus-symbols.c: Fix common/ includes.
14963 * command.h: Fix common/ includes.
14964 * cli/cli-dump.c: Fix common/ includes.
14965 * cli/cli-cmds.c: Fix common/ includes.
14966 * charset.c: Fix common/ includes.
14967 * build-id.c: Fix common/ includes.
14968 * btrace.h: Fix common/ includes.
14969 * btrace.c: Fix common/ includes.
14970 * breakpoint.h: Fix common/ includes.
14971 * breakpoint.c: Fix common/ includes.
14972 * ax.h:
14973 (enum agent_op): Fix common/ includes.
14974 * ax-general.c (struct aop_map): Fix common/ includes.
14975 * ax-gdb.c: Fix common/ includes.
14976 * auxv.c: Fix common/ includes.
14977 * auto-load.c: Fix common/ includes.
14978 * arm-tdep.c: Fix common/ includes.
14979 * arch/riscv.c: Fix common/ includes.
14980 * arch/ppc-linux-common.c: Fix common/ includes.
14981 * arch/i386.c: Fix common/ includes.
14982 * arch/arm.c: Fix common/ includes.
14983 * arch/arm-linux.c: Fix common/ includes.
14984 * arch/arm-get-next-pcs.c: Fix common/ includes.
14985 * arch/amd64.c: Fix common/ includes.
14986 * arch/aarch64.c: Fix common/ includes.
14987 * arch/aarch64-insn.c: Fix common/ includes.
14988 * arch-utils.c: Fix common/ includes.
14989 * amd64-windows-tdep.c: Fix common/ includes.
14990 * amd64-tdep.c: Fix common/ includes.
14991 * amd64-sol2-tdep.c: Fix common/ includes.
14992 * amd64-obsd-tdep.c: Fix common/ includes.
14993 * amd64-nbsd-tdep.c: Fix common/ includes.
14994 * amd64-linux-tdep.c: Fix common/ includes.
14995 * amd64-linux-nat.c: Fix common/ includes.
14996 * amd64-fbsd-tdep.c: Fix common/ includes.
14997 * amd64-fbsd-nat.c: Fix common/ includes.
14998 * amd64-dicos-tdep.c: Fix common/ includes.
14999 * amd64-darwin-tdep.c: Fix common/ includes.
15000 * agent.c: Fix common/ includes.
15001 * ada-lang.h: Fix common/ includes.
15002 * ada-lang.c: Fix common/ includes.
15003 * aarch64-tdep.c: Fix common/ includes.
15004
15005 2019-01-25 Tom Tromey <tom@tromey.com>
15006
15007 * common/create-version.sh: Use common/version.h.
15008
15009 2019-01-24 Pedro Alves <palves@redhat.com>
15010
15011 * infrun.c (signal_stop, signal_print, signal_program)
15012 (signal_catch, signal_pass): Now arrays instead of pointers.
15013 (update_signals_program_target, do_target_resume)
15014 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15015 * linux-nat.c (linux_nat_target::pass_signals)
15016 (linux_nat_target::create_inferior, linux_nat_target::attach):
15017 Adjust.
15018 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15019 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15020 * procfs.c (procfs_target::pass_signals): Adjust.
15021 * record-full.c (record_full_target::resume): Adjust.
15022 * remote.c (remote_target::pass_signals)
15023 (remote_target::program_signals): Adjust.
15024 * target-debug.h (target_debug_print_signals): Now takes a
15025 gdb::array_view as parameter. Adjust.
15026 * target.h (target_ops) <pass_signals, program_signals>: Replace
15027 pointer and length parameters with gdb::array_view.
15028 (target_pass_signals, target_program_signals): Likewise.
15029 * target-delegates.c: Regenerate.
15030
15031 2019-01-24 Pedro Alves <palves@redhat.com>
15032
15033 * common/forward-scope-exit.h
15034 (forward_scope_exit::forward_scope_exit): Pass arguments to
15035 m_bind_function directly, instead of creating a std::bind and
15036 copying that.
15037
15038 2019-01-24 Alan Hayward <alan.hayward@arm.com>
15039
15040 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15041 for static members.
15042 (pass_in_v_vfp_candidate): Likewise.
15043
15044 2019-01-23 Tom Tromey <tom@tromey.com>
15045 Pedro Alves <palves@redhat.com>
15046
15047 * regcache.c (class regcache_invalidator): Remove.
15048 (regcache::raw_write): Use make_scope_exit.
15049
15050 2019-01-23 Tom Tromey <tom@tromey.com>
15051
15052 * ui-out.h (class ui_out_emit_type): Update comment.
15053
15054 2019-01-23 Tom Tromey <tom@tromey.com>
15055
15056 * infrun.c (fetch_inferior_event): Update comment.
15057
15058 2019-01-23 Tom Tromey <tom@tromey.com>
15059 Pedro Alves <palves@redhat.com>
15060
15061 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15062 parameter.
15063 (fetch_inferior_event): Use SCOPE_EXIT.
15064
15065
15066 2019-01-23 Tom Tromey <tom@tromey.com>
15067 Pedro Alves <palves@redhat.com>
15068
15069 * infrun.c (disable_thread_events): Delete.
15070 (stop_all_threads): Use SCOPE_EXIT.
15071
15072 2019-01-23 Tom Tromey <tom@tromey.com>
15073 Pedro Alves <palves@redhat.com>
15074
15075 * symfile.c: Include forward-scope-exit.h.
15076 (clear_symtab_users_cleanup): Replace forward declaration with
15077 a FORWARD_SCOPE_EXIT.
15078 (syms_from_objfile_1): Use the forward_scope_exit and
15079 gdb::optional instead of cleanup_function.
15080 (reread_symbols): Use the forward_scope_exit instead of
15081 cleanup_function.
15082 (clear_symtab_users_cleanup): Remove function.
15083
15084 2019-01-23 Tom Tromey <tom@tromey.com>
15085 Pedro Alves <palves@redhat.com>
15086
15087 * linux-nat.c: Include scope-exit.h.
15088 (cleanup_target_stop): Remove.
15089 (linux_nat_target::static_tracepoint_markers_by_strid): Use
15090 SCOPE_EXIT.
15091
15092 2019-01-23 Tom Tromey <tom@tromey.com>
15093 Pedro Alves <palves@redhat.com>
15094
15095 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15096 (call_function_by_hand_dummy): Use SCOPE_EXIT.
15097
15098 2019-01-23 Tom Tromey <tom@tromey.com>
15099 Andrew Burgess <andrew.burgess@embecosm.com>
15100 Pedro Alves <palves@redhat.com>
15101
15102 * infrun.c (fetch_inferior_event): Use scope_exit.
15103 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15104 * top.c (execute_command): Use scope_exit.
15105 * breakpoint.c (bpstat_do_actions): Use scope_exit.
15106 * utils.c (do_bpstat_clear_actions_cleanup)
15107 (make_bpstat_clear_actions_cleanup): Remove.
15108
15109 2019-01-23 Tom Tromey <tom@tromey.com>
15110 Pedro Alves <palves@redhat.com>
15111
15112 * infrun.c: Include "common/scope-exit.h"
15113 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15114 (wait_for_inferior): Use SCOPE_EXIT.
15115 (fetch_inferior_event): Use scope_exit.
15116
15117 2019-01-23 Tom Tromey <tom@tromey.com>
15118 Pedro Alves <palves@redhat.com>
15119
15120 * breakpoint.c (create_breakpoint): Remove cleanup.
15121
15122 2019-01-23 Tom Tromey <tom@tromey.com>
15123 Andrew Burgess <andrew.burgess@embecosm.com>
15124 Pedro Alves <palves@redhat.com>
15125
15126 2019-01-23 Pedro Alves <palves@redhat.com>
15127
15128 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15129
15130 2019-01-23 Pedro Alves <palves@redhat.com>
15131 Andrew Burgess <andrew.burgess@embecosm.com>
15132
15133 * gdbthread.h: Include "common/forward-scope-exit.h".
15134 (scoped_finish_thread_state): Redefine custom class in terms of
15135 forward_scope_exit.
15136
15137 2019-01-23 Pedro Alves <palves@redhat.com>
15138 Andrew Burgess <andrew.burgess@embecosm.com>
15139
15140 * common/forward-scope-exit.h: New file.
15141
15142 2019-01-23 Pedro Alves <palves@redhat.com>
15143 Andrew Burgess <andrew.burgess@embecosm.com>
15144 Tom Tromey <tom@tromey.com>
15145
15146 * common/scope-exit.h: New file.
15147
15148 2019-01-23 Pedro Alves <palves@redhat.com>
15149
15150 * common/preprocessor.h (ESC): Rename to ...
15151 (ESC_PARENS): ... this.
15152 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15153 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15154
15155 2019-01-23 Tom Tromey <tom@tromey.com>
15156
15157 * language.h (class scoped_switch_to_sym_language_if_auto):
15158 Initialize m_lang in both cases.
15159
15160 2019-01-23 Alan Hayward <alan.hayward@arm.com>
15161
15162 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15163 with XCNEW.
15164
15165 2019-01-22 Tom Tromey <tom@tromey.com>
15166
15167 * corelow.c: Do not include sys/file.h.
15168
15169 2019-01-22 Tom Tromey <tom@tromey.com>
15170
15171 * tui/tui-wingeneral.h: Include gdb_curses.h.
15172
15173 2019-01-22 Tom Tromey <tom@tromey.com>
15174
15175 * source-cache.h (class source_cache) <get_source_lines,
15176 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15177
15178 2019-01-22 Tom Tromey <tom@tromey.com>
15179
15180 * remote-fileio.h (struct remote_target): Declare.
15181
15182 2019-01-22 Tom Tromey <tom@tromey.com>
15183
15184 * python/py-arch.c: Do not include py-ref.h.
15185 * python/py-bpevent.c: Do not include py-ref.h.
15186 * python/py-cmd.c: Do not include py-ref.h.
15187 * python/py-continueevent.c: Do not include py-ref.h.
15188 * python/py-event.h: Do not include py-ref.h.
15189 * python/py-evtregistry.c: Do not include py-ref.h.
15190 * python/py-finishbreakpoint.c: Do not include py-ref.h.
15191 * python/py-frame.c: Do not include py-ref.h.
15192 * python/py-framefilter.c: Do not include py-ref.h.
15193 * python/py-function.c: Do not include py-ref.h.
15194 * python/py-infevents.c: Do not include py-ref.h.
15195 * python/py-linetable.c: Do not include py-ref.h.
15196 * python/py-objfile.c: Do not include py-ref.h.
15197 * python/py-param.c: Do not include py-ref.h.
15198 * python/py-prettyprint.c: Do not include py-ref.h.
15199 * python/py-progspace.c: Do not include py-ref.h.
15200 * python/py-symbol.c: Do not include py-ref.h.
15201 * python/py-symtab.c: Do not include py-ref.h.
15202 * python/py-type.c: Do not include py-ref.h.
15203 * python/py-unwind.c: Do not include py-ref.h.
15204 * python/py-utils.c: Do not include py-ref.h.
15205 * python/py-value.c: Do not include py-ref.h.
15206 * python/py-varobj.c: Do not include py-ref.h.
15207 * python/py-xmethods.c: Do not include py-ref.h.
15208 * python/python.c: Do not include py-ref.h.
15209 * varobj.c: Do not include py-ref.h.
15210
15211 2019-01-22 Tom Tromey <tom@tromey.com>
15212
15213 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15214 keyword for bcache.
15215
15216 2019-01-22 Tom Tromey <tom@tromey.com>
15217
15218 * compile/compile-cplus-types.c: Remove a comment by #include.
15219
15220 2019-01-22 Tom Tromey <tom@tromey.com>
15221
15222 * compile/gcc-c-plugin.h: Include compile-internal.h.
15223
15224 2019-01-22 Tom Tromey <tom@tromey.com>
15225
15226 * stabsread.c (EXTERN): Do not define.
15227 (symnum, next_symbol_text_func, processing_gcc_compilation)
15228 (within_function, global_sym_chain, global_stabs)
15229 (previous_stab_code, this_object_header_files)
15230 (n_this_object_header_files)
15231 (n_allocated_this_object_header_files): Define.
15232 * stabsread.h (EXTERN): Never define. Use "extern".
15233
15234 2019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15235
15236 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15237 history_value.
15238
15239 2019-01-21 Tom Tromey <tom@tromey.com>
15240
15241 * ui-out.c: Fix includes.
15242 * tui/tui-source.c: Fix includes.
15243 * target.c: Fix includes.
15244 * remote.c: Fix includes.
15245 * regcache.c: Fix includes.
15246 * python/py-block.c: Fix includes.
15247 * printcmd.c: Fix includes.
15248 * or1k-tdep.c: Fix includes.
15249 * mi/mi-main.c: Fix includes.
15250 * m32r-tdep.c: Fix includes.
15251 * csky-tdep.c: Fix includes.
15252 * compile/compile-cplus-types.c: Fix includes.
15253 * cli/cli-interp.c: Fix includes.
15254
15255 2019-01-21 Alan Hayward <alan.hayward@arm.com>
15256
15257 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15258 for padding.
15259
15260 2019-01-16 Tom Tromey <tom@tromey.com>
15261
15262 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
15263 earlier.
15264 (struct objfile) <msymbols_range>: Move from top level.
15265 <msymbols>: New method.
15266 (class objfile_msymbols): Remove.
15267 * symtab.c (default_collect_symbol_completion_matches_break_on):
15268 Update.
15269 * symmisc.c (dump_msymbols): Update.
15270 * stabsread.c (scan_file_globals): Update.
15271 * objc-lang.c (info_selectors_command, info_classes_command)
15272 (find_methods): Update.
15273 * minsyms.c (find_solib_trampoline_target): Update.
15274 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
15275 * coffread.c (coff_symfile_read): Update.
15276 * ada-lang.c (ada_lookup_simple_minsym)
15277 (ada_collect_symbol_completion_matches): Update.
15278
15279 2019-01-16 Tom Tromey <tom@tromey.com>
15280
15281 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
15282 type. Remove no-argument constructor.
15283 <iterator::operator++>: Simplify.
15284 <begin>: Update.
15285 <end>: Use minimal_symbol_count.
15286
15287 2019-01-16 Tom Tromey <tom@tromey.com>
15288
15289 * objfiles.h (struct objfile) <psymtabs>: New method.
15290 (class objfile_psymtabs): Remove.
15291 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
15292 typedef.
15293 <range>: New method.
15294 (require_partial_symbols): Change return type.
15295 * psymtab.c (require_partial_symbols)
15296 (psym_expand_symtabs_matching): Update.
15297 * mdebugread.c (parse_partial_symbols): Update.
15298 * dbxread.c (dbx_end_psymtab): Update.
15299
15300 2019-01-15 Tom Tromey <tom@tromey.com>
15301
15302 * symtab.c (lookup_objfile_from_block)
15303 (lookup_symbol_in_objfile_symtabs)
15304 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
15305 (find_line_symtab, info_sources_command)
15306 (default_collect_symbol_completion_matches_break_on)
15307 (make_source_files_completion_list): Update.
15308 * symmisc.c (print_objfile_statistics, dump_objfile)
15309 (maintenance_print_symbols, maintenance_info_symtabs)
15310 (maintenance_check_symtabs, maintenance_info_line_tables):
15311 Update.
15312 * source.c (select_source_symtab)
15313 (forget_cached_source_info_for_objfile): Update.
15314 * objfiles.h (class objfile_compunits): Remove.
15315 (struct objfile) <compunits_range>: New typedef.
15316 (compunits): New method.
15317 * objfiles.c (objfile_relocate1): Update.
15318 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15319 * maint.c (count_symtabs_and_blocks): Update.
15320 * linespec.c (iterate_over_all_matching_symtabs): Update.
15321 * cp-support.c (add_symbol_overload_list_qualified): Update.
15322 * coffread.c (coff_symtab_read): Update.
15323 * ada-lang.c (add_nonlocal_symbols)
15324 (ada_collect_symbol_completion_matches)
15325 (ada_add_global_exceptions): Update.
15326
15327 2019-01-15 Tom Tromey <tom@tromey.com>
15328
15329 * progspace.h (program_space) <objfiles_safe_range>: New
15330 typedef.
15331 <objfiles_safe>: New method.
15332 * objfiles.h (class all_objfiles_safe): Remove.
15333 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
15334 * jit.c (jit_inferior_exit_hook): Update.
15335
15336 2019-01-17 Tom Tromey <tom@tromey.com>
15337
15338 * progspace.h (program_space) <objfiles_range>: New typedef.
15339 <objfiles>: New method.
15340 <objfiles_head>: Rename from objfiles.
15341 (object_files): Update.
15342 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
15343 * guile/scm-pretty-print.c
15344 (ppscm_find_pretty_printer_from_objfiles): Update.
15345 * guile/scm-objfile.c (gdbscm_objfiles): Update.
15346 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
15347 Update.
15348 * python/py-progspace.c (pspy_get_objfiles): Update.
15349 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15350 Update.
15351 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15352 (objfpy_lookup_objfile_by_build_id): Update.
15353 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15354 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15355 Update.
15356 * symtab.c (iterate_over_symtabs, matching_obj_sections)
15357 (expand_symtab_containing_pc, lookup_objfile_from_block)
15358 (lookup_static_symbol, basic_lookup_transparent_type)
15359 (find_pc_sect_compunit_symtab, find_symbol_at_address)
15360 (find_line_symtab, info_sources_command)
15361 (default_collect_symbol_completion_matches_break_on)
15362 (make_source_files_completion_list, find_main_name): Update.
15363 * symmisc.c (print_symbol_bcache_statistics)
15364 (print_objfile_statistics, maintenance_print_symbols)
15365 (maintenance_print_msymbols, maintenance_print_objfiles)
15366 (maintenance_info_symtabs, maintenance_check_symtabs)
15367 (maintenance_expand_symtabs, maintenance_info_line_tables):
15368 Update.
15369 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
15370 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
15371 (map_overlay_command, unmap_overlay_command)
15372 (simple_overlay_update, expand_symtabs_matching)
15373 (map_symbol_filenames): Update.
15374 * symfile-debug.c (set_debug_symfile): Update.
15375 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
15376 Update.
15377 * source.c (select_source_symtab, forget_cached_source_info):
15378 Update.
15379 * solib.c (solib_read_symbols): Update.
15380 * solib-spu.c (append_ocl_sos): Update.
15381 * psymtab.c (maintenance_print_psymbols)
15382 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
15383 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
15384 * printcmd.c (info_symbol_command): Update.
15385 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
15386 Update.
15387 * objfiles.h (class all_objfiles): Remove.
15388 * objfiles.c (have_partial_symbols, have_full_symbols)
15389 (have_minimal_symbols, qsort_cmp, update_section_map)
15390 (shared_objfile_contains_address_p)
15391 (default_iterate_over_objfiles_in_search_order): Update.
15392 * objc-lang.c (info_selectors_command, info_classes_command)
15393 (find_methods): Update.
15394 * minsyms.c (find_solib_trampoline_target): Update.
15395 * maint.c (maintenance_info_sections)
15396 (maintenance_translate_address, count_symtabs_and_blocks):
15397 Update.
15398 * main.c (captured_main_1): Update.
15399 * linux-thread-db.c (try_thread_db_load_from_pdir)
15400 (has_libpthread): Update.
15401 * linespec.c (iterate_over_all_matching_symtabs)
15402 (search_minsyms_for_name): Update.
15403 * jit.c (jit_find_objf_with_entry_addr): Update.
15404 * hppa-tdep.c (find_unwind_entry)
15405 (hppa_lookup_stub_minimal_symbol): Update.
15406 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
15407 Update.
15408 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15409 (elf_gnu_ifunc_resolve_by_got): Update.
15410 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
15411 * dwarf-index-write.c (save_gdb_index_command): Update.
15412 * cp-support.c (add_symbol_overload_list_qualified): Update.
15413 * breakpoint.c (create_overlay_event_breakpoint)
15414 (create_longjmp_master_breakpoint)
15415 (create_std_terminate_master_breakpoint)
15416 (create_exception_master_breakpoint): Update.
15417 * blockframe.c (find_pc_partial_function): Update.
15418 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
15419 (ada_collect_symbol_completion_matches)
15420 (ada_add_global_exceptions): Update.
15421
15422 2019-01-17 Tom Tromey <tom@tromey.com>
15423
15424 * solib-target.c (lm_info_target_p): Remove typedef. Don't
15425 declare VEC.
15426 (solib_target_parse_libraries): Change return type.
15427 (library_list_start_segment, library_list_start_section)
15428 (library_list_end_library, library_list_start_library); Update.
15429 (solib_target_free_library_list): Remove.
15430 (solib_target_parse_libraries): Remove cleanup. Change return
15431 type.
15432 (solib_target_current_sos): Update.
15433
15434 2019-01-17 Tom Tromey <tromey@bapiya>
15435
15436 * valprint.c: Replace "the the" with "the".
15437 * symtab.c: Replace "the the" with "the".
15438 * solib.c: Replace "the the" with "the".
15439 * solib-dsbt.c: Replace "the the" with "the".
15440 * linespec.c: Replace "the the" with "the".
15441 * dwarf2loc.h: Replace "the the" with "the".
15442 * amd64-windows-tdep.c: Replace "the the" with "the".
15443 * aarch64-tdep.c: Replace "the the" with "the".
15444
15445 2019-01-16 Keith Seitz <keiths@redhat.com>
15446
15447 PR gdb/23773
15448 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
15449 <builder>: Rename to ..
15450 <m_builder>: ... this and make private.
15451 (dwarf2_cu::get_builder): New method. Change all users of
15452 `builder' to use this method.
15453 (dwarf2_start_symtab): Move to ...
15454 (dwarf2_cu::start_symtab): ... here. Update all callers
15455 (setup_type_unit_groups): Move to ...
15456 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
15457 callers.
15458 (dwarf2_cu::reset_builder): New method.
15459 (process_full_compunit, process_full_type_unit): Use
15460 dwarf2_cu::reset_builder.
15461 (follow_die_offset): Record the ancestor CU if it is different
15462 from the followed DIE's CU.
15463 (follow_die_sig_1): Likewise.
15464
15465 2019-01-15 Tom Tromey <tom@tromey.com>
15466
15467 * remote.c (class remote_state) <buf>: Now a char_vector.
15468 <buf_size>: Remove.
15469 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
15470 parameter.
15471 (remote_target::getpkt_or_notif_sane_1)
15472 (remote_target::getpkt_sane)
15473 (remote_target::getpkt_or_notif_sane): Likewise.
15474 (class remote_target) <putpkt>: New overload.
15475 (remote_target::read_frame): Change type of "buf_p". Remove
15476 sizeof_p parameter.
15477 (packet_ok): New overload.
15478 (packet_check_result): New overload.
15479 Update all uses.
15480
15481 2019-01-14 Tom Tromey <tom@tromey.com>
15482
15483 * remote-notif.c (handle_notification, remote_notif_ack)
15484 (remote_notif_parse): Make "buf" const.
15485 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
15486 const.
15487 (remote_notif_parse, remote_notif_ack, handle_notification):
15488 Likewise.
15489 * remote.c (remote_notif_stop_parse): Make "buf" const.
15490 (remote_target::remote_parse_stop_reply): Make "buf" const.
15491 (remote_notif_stop_ack): Make "buf" const.
15492
15493 2019-01-14 Tom Tromey <tom@tromey.com>
15494
15495 * remote.c (remote_console_output): Make parameter const.
15496
15497 2019-01-14 Tom Tromey <tom@tromey.com>
15498
15499 * target-debug.h (target_debug_print_signals): Constify.
15500 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
15501 * procfs.c (procfs_target::pass_signals): Update.
15502 * linux-nat.c (linux_nat_target::pass_signals): Update.
15503 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
15504 * target-delegates.c: Rebuild.
15505 * remote.c (remote_target::program_signals): Update.
15506 (remote_target::pass_signals): Update.
15507 * target.c (target_pass_signals): Constify argument.
15508 (target_program_signals): Likewise.
15509 * target.h (struct target_ops) <pass_signals, program_signals>:
15510 Constify argument.
15511 (target_pass_signals, target_program_signals): Constify argument.
15512
15513 2019-01-14 Tom Tromey <tom@tromey.com>
15514
15515 PR tui/28819:
15516 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
15517
15518 2019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
15519
15520 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
15521 field.
15522 * rs6000-tdep.c: Include reggroups.h.
15523 (IS_V_ALIAS_PSEUDOREG): Define.
15524 (rs6000_register_name): Return names for the "vX" aliases.
15525 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
15526 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
15527 aliases. Call default_register_reggroup_p for all other
15528 pseudo-registers.
15529 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
15530 New functions.
15531 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
15532 Handle "vX" aliases.
15533 (v_alias_pseudo_register_collect): New function.
15534 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
15535 (rs6000_gdbarch_init): Initialize "vX" aliases as
15536 pseudo-registers. Restore registration of
15537 rs6000_pseudo_register_reggroup_p with
15538 set_tdesc_pseudo_register_reggroup_p.
15539
15540 2019-01-13 Max Filippov <jcmvbkbc@gmail.com>
15541
15542 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
15543 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
15544 set_gdbarch_num_pseudo_regs.
15545
15546 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15547
15548 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
15549 Remove arg prefixname, add do_set and do_show.
15550 Add member functions set_list and show_list.
15551 * cli/cli-style.c (class cli_style_option): Update accordingly.
15552 (style_set_list): Move to file scope.
15553 (style_show_list): Likewise.
15554 (set_style): Call help_list.
15555 (show_style): Call cmd_show_list.
15556 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
15557 Update to use the new macro.
15558
15559 2019-10-12 Joel Brobecker <brobecker@adacore.com>
15560
15561 * ada-lang.c (_initialize_ada_language): Expand the help text
15562 for the "catch exception" command.
15563
15564 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15565
15566 * symtab.c (matching_obj_sections): Initialize obj,
15567 declare it closer to its usage.
15568
15569 2019-01-10 Tom Tromey <tom@tromey.com>
15570
15571 * thread-iter.h (inf_threads_iterator): Use next_iterator.
15572 (basic_inf_threads_range): Remove.
15573 (inf_threads_range, inf_non_exited_threads_range)
15574 (safe_inf_threads_range): Use next_adapter.
15575
15576 2019-01-10 Keith Seitz <keiths@redhat.com>
15577
15578 PR gdb/23712
15579 PR symtab/23010
15580 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
15581 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
15582
15583 2019-01-10 Keith Seitz <keiths@redhat.com>
15584
15585 PR gdb/23712
15586 PR symtab/23010
15587 * dictionary.c (pending_to_vector): Remove.
15588 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15589 Remove _1 suffix, replacing functions of the same name. Update
15590 all callers.
15591 (dict_create_hashed, dict_create_hashed_expandable)
15592 (dict_create_linear, dict_create_linear_expandable, dict_free)
15593 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
15594 Make functions static.
15595
15596 2019-01-10 Keith Seitz <keiths@redhat.com>
15597
15598 PR gdb/23712
15599 PR symtab/23010
15600 * dictionary.h (struct dictionary): Replace declaration with
15601 multidictionary.
15602 (dict_create_hashed, dict_create_hashed_expandable)
15603 (dict_create_linear, dict_create_linear_expandable)
15604 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
15605 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
15606 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
15607 taking multidictionary argument.
15608 [ALL_DICT_SYMBOLS]: Update for multidictionary.
15609 * block.h (struct block) <dict>: Change to multidictionary
15610 and rename `multidict'.
15611 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
15612 symmisc.c: Update all dictionary references to multidictionary.
15613
15614 2019-01-10 Keith Seitz <keiths@redhat.com>
15615
15616 PR gdb/23712
15617 PR symtab/23010
15618 * dictionary.c: Include unordered_map.
15619 (pending_to_vector): New function.
15620 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15621 Rewrite the non-"_1" functions to take vector instead
15622 of linked list.
15623 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
15624 "new" _1 versions of the same name.
15625 (multidictionary): Define.
15626 (std::hash<enum language): New definition.
15627 (collate_pending_symbols_by_language, mdict_create_hashed)
15628 (mdict_create_hashed_expandable, mdict_create_linear)
15629 (mdict_create_linear_expandable, mdict_free)
15630 (find_language_dictionary, create_new_language_dictionary)
15631 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
15632 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
15633 (mdict_size, mdict_empty): New functions.
15634 * dictionary.h (mdict_iterator): Define.
15635
15636 2019-01-10 Pedro Alves <palves@redhat.com>
15637
15638 * breakpoint.c (read_uploaded_action)
15639 (create_tracepoint_from_upload): Adjust to use
15640 gdb::unique_xmalloc_ptr.
15641 * ctf.c (ctf_write_uploaded_tp):
15642 (SET_ARRAY_FIELD): Use emplace_back.
15643 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
15644 * tracefile-tfile.c (tfile_write_uploaded_tp):
15645 * tracepoint.c (parse_tracepoint_definition): Adjust to use
15646 gdb::unique_xmalloc_ptr.
15647 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
15648 at_string, cond_string, cmd_strings>: Replace char pointers
15649 with gdb::unique_xmalloc_ptr.
15650
15651 2019-01-10 Pedro Alves <palves@redhat.com>
15652
15653 * solib-target.c (library_list_start_library): Don't xstrdup name.
15654
15655 2019-01-10 Pedro Alves <palves@redhat.com>
15656
15657 * mdebugread.c (parse_partial_symbols): Use
15658 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
15659
15660 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
15661
15662 * linux-fork.c (scoped_switch_fork_info)
15663 <~scoped_switch_fork_info>: Fix incorrect variable name.
15664
15665 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
15666
15667 * linux-fork.c (scoped_switch_fork_info)
15668 <scoped_switch_fork_info>: Make explicit.
15669 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
15670
15671 2019-01-10 Tom Tromey <tom@tromey.com>
15672
15673 * objfiles.h (objfile::reset_psymtabs): Update.
15674 * objfiles.c (objfile::objfile): Update.
15675 * psymtab.h (psymtab_storage::obstack): Update.
15676 (psymtab_storage::m_obstack): Use gdb::optional.
15677 (class psymtab_storage): Update comment. Remove objfile
15678 parameter.
15679 * psymtab.c (psymtab_storage::psymtab_storage): Update.
15680
15681 2019-01-10 Tom Tromey <tom@tromey.com>
15682
15683 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
15684 <free_psymtabs>: Now private.
15685 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
15686 (allocate_psymtab): Use new method.
15687
15688 2019-01-10 Tom Tromey <tom@tromey.com>
15689
15690 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
15691 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
15692 * mdebugread.c (parse_partial_symbols): Use
15693 allocate_dependencies.
15694 * dwarf2read.c (dwarf2_create_include_psymtab): Use
15695 allocate_dependencies.
15696 (process_psymtab_comp_unit_reader)
15697 (build_type_psymtab_dependencies): Likewise.
15698 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
15699
15700 2019-01-10 Tom Tromey <tom@tromey.com>
15701
15702 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
15703 PSYMBOL_SET_LANGUAGE.
15704 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
15705
15706 2019-01-10 Tom Tromey <tom@tromey.com>
15707
15708 * psymtab.h (psymtab_storage::obstack): New method.
15709 <m_obstack>: Rename from obstack; now private.
15710 * psymtab.c (psymtab_storage): Update.
15711 * dwarf2read.c (create_addrmap_from_index)
15712 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
15713 Update.
15714
15715 2019-01-10 Tom Tromey <tom@tromey.com>
15716
15717 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
15718 * objfiles.h (objfile::reset_psymtabs): New method.
15719
15720 2019-01-10 Tom Tromey <tom@tromey.com>
15721
15722 * symmisc.c (print_symbol_bcache_statistics): Update.
15723 (print_objfile_statistics): Update.
15724 * symfile.c (reread_symbols): Update.
15725 * psymtab.h (class psymtab_storage): New.
15726 * psymtab.c (psymtab_storage): New constructor.
15727 (~psymtab_storage): New destructor.
15728 (require_partial_symbols): Update.
15729 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
15730 (find_pc_sect_psymtab, find_pc_sect_psymbol)
15731 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
15732 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
15733 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
15734 (start_psymtab_common, end_psymtab_common)
15735 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
15736 (allocate_psymtab): Update.
15737 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
15738 Update.
15739 (dump_psymtab_addrmap, maintenance_print_psymbols)
15740 (maintenance_check_psymtabs): Update.
15741 (class objfile_psymtabs): Move to objfiles.h.
15742 * psympriv.h (discard_psymtab): Now inline.
15743 (psymtab_discarder::psymtab_discarder): Update.
15744 (psymtab_discarder::~psymtab_discarder): Update.
15745 (ALL_OBJFILE_PSYMTABS): Rewrite.
15746 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
15747 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
15748 Remove fields.
15749 <partial_symtabs>: New field.
15750 (class objfile_psymtabs): Move from psymtab.h. Update.
15751 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
15752 psymbol_cache.
15753 (objfile::~objfile): Don't destroy psymbol_cache.
15754 * mdebugread.c (parse_partial_symbols): Update.
15755 * dwarf2read.c (create_addrmap_from_index)
15756 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
15757 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
15758 (add_partial_subprogram, dwarf2_ranges_read): Update.
15759 * dwarf-index-write.c (write_address_map)
15760 (write_one_signatured_type, recursively_write_psymbols)
15761 (class debug_names, class debug_names, write_psymtabs_to_index):
15762 Update.
15763
15764 2019-01-10 Tom Tromey <tom@tromey.com>
15765
15766 * symtab.h (SYMBOL_SET_NAMES): Update.
15767 (symbol_set_names): Update.
15768 (MSYMBOL_SET_NAMES): Update.
15769 * symtab.c (symbol_set_names): Change argument to be an
15770 objfile_per_bfd_storage.
15771 * psymtab.c (add_psymbol_to_bcache): Update.
15772 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
15773
15774 2019-01-10 Tom Tromey <tom@tromey.com>
15775
15776 * symtab.c (create_demangled_names_hash): Change argument to be an
15777 objfile_per_bfd_storage.
15778 (symbol_set_names): Update.
15779
15780 2019-01-10 Tom Tromey <tom@tromey.com>
15781
15782 * xcoffread.c (xcoff_initial_scan): Unconditionally call
15783 init_psymbol_list.
15784 * psymtab.c (init_psymbol_list): Do nothing if already called.
15785 * psympriv.h (init_psymbol_list): Add comment.
15786 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
15787 init_psymbol_list.
15788 * dbxread.c (dbx_symfile_read): Unconditionally call
15789 init_psymbol_list.
15790
15791 2019-01-10 Tom Tromey <tom@tromey.com>
15792
15793 * xcoffread.c (scan_xcoff_symtab): Update.
15794 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
15795 "where".
15796 * mdebugread.c (parse_partial_symbols)
15797 (handle_psymbol_enumerators): Update.
15798 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
15799 * dbxread.c (read_dbx_symtab): Update.
15800 * psympriv.h (psymbol_placement): New enum.
15801 (add_psymbol_to_list): Update.
15802
15803 2019-01-10 Tom Tromey <tom@tromey.com>
15804
15805 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
15806 static_psymbols parameters.
15807 (scan_xcoff_symtab): Update.
15808 * psymtab.c (start_psymtab_common): Remove global_psymbols and
15809 static_psymbols parameters.
15810 * psympriv.h (start_psymtab_common): Update.
15811 * mdebugread.c (parse_partial_symbols): Update.
15812 * dwarf2read.c (create_partial_symtab): Update.
15813 * dbxread.c (read_dbx_symtab): Update.
15814 (start_psymtab): Remove global_psymbols and static_psymbols
15815 parameters.
15816
15817 2019-01-10 Tom Tromey <tom@tromey.com>
15818
15819 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
15820 * psymtab.c (allocate_psymtab): Add comment.
15821 * psympriv.h (allocate_psymtab): Add comment.
15822 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
15823 initializations.
15824 * dbxread.c (dbx_end_psymtab): Remove some initializations.
15825
15826 2019-01-10 Tom Tromey <tom@tromey.com>
15827
15828 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15829 Don't declare.
15830 * mipsread.c: Include mdebugread.h.
15831 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15832 Declare.
15833 * elfread.c: Include mdebugread.h.
15834
15835 2019-01-09 Tom Tromey <tom@tromey.com>
15836
15837 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
15838 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
15839 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
15840 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
15841 (psym_lookup_symbol, psym_find_last_source_symtab)
15842 (psym_forget_cached_source_info, psym_print_stats)
15843 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
15844 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
15845 (psym_map_matching_symbols, psym_expand_symtabs_matching)
15846 (psym_find_compunit_symtab_by_address)
15847 (maintenance_print_psymbols, maintenance_info_psymtabs)
15848 (maintenance_check_psymtabs): Use ranged for.
15849 * psymtab.h (class objfile_psymtabs): New.
15850 (require_partial_symbols): Return objfile_psymtabs.
15851 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
15852
15853 2019-01-09 Tom Tromey <tom@tromey.com>
15854
15855 * symfile.c (overlay_invalidate_all, find_pc_overlay)
15856 (find_pc_mapped_section, list_overlays_command)
15857 (map_overlay_command, unmap_overlay_command)
15858 (simple_overlay_update): Use all_objfiles.
15859 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
15860 * printcmd.c (info_symbol_command): Use all_objfiles.
15861 * objfiles.h (ALL_OBJSECTIONS): Remove.
15862 * maint.c (maintenance_translate_address): Use all_objfiles.
15863 * gcore.c (gcore_create_callback): Use all_objfiles.
15864 (objfile_find_memory_regions): Likewise.
15865
15866 2019-01-09 Tom Tromey <tom@tromey.com>
15867
15868 * symtab.c (find_line_symtab, info_sources_command)
15869 (make_source_files_completion_list): Use objfile_compunits.
15870 * source.c (select_source_symtab): Use objfile_compunits.
15871 * objfiles.h (struct objfile): Update comment.
15872 (ALL_OBJFILES): Remove.
15873 (ALL_FILETABS): Remove.
15874 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
15875 objfile_compunits.
15876
15877 2019-01-09 Tom Tromey <tom@tromey.com>
15878
15879 * symmisc.c (print_objfile_statistics, dump_objfile)
15880 (maintenance_print_symbols): Use compunit_filetabs.
15881 * source.c (forget_cached_source_info_for_objfile): Use
15882 compunit_filetabs.
15883 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
15884 (ALL_FILETABS): Use compunit_filetabs.
15885 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
15886 * coffread.c (coff_symtab_read): Use compunit_filetabs.
15887
15888 2019-01-09 Tom Tromey <tom@tromey.com>
15889
15890 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
15891 (compunit_filetabs): New.
15892 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
15893 compunit_filetabs.
15894 (info_sources_command, make_source_files_completion_list): Remove
15895 declaration.
15896 * symmisc.c (print_objfile_statistics, dump_objfile)
15897 (maintenance_print_symbols): Remove declaration.
15898 (maintenance_info_symtabs): Use compunit_filetabs.
15899 (maintenance_info_line_tables): Likewise.
15900 * source.c (select_source_symtab): Change local variable name.
15901 (forget_cached_source_info_for_objfile): Remove declaration.
15902 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
15903 * objfiles.c (objfile_relocate1): Remove declaration.
15904 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
15905 declaration.
15906 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
15907 * coffread.c (coff_symtab_read): Remove declaration.
15908 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
15909 compunit_filetabs.
15910
15911 2019-01-09 Tom Tromey <tom@tromey.com>
15912
15913 * symtab.c (lookup_objfile_from_block)
15914 (find_pc_sect_compunit_symtab, search_symbols)
15915 (default_collect_symbol_completion_matches_break_on): Use
15916 objfile_compunits.
15917 * objfiles.h (ALL_COMPUNITS): Remove.
15918 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
15919 * cp-support.c (add_symbol_overload_list_qualified): Use
15920 objfile_compunits.
15921 * ada-lang.c (ada_collect_symbol_completion_matches)
15922 (ada_add_global_exceptions): Use objfile_compunits.
15923
15924 2019-01-09 Tom Tromey <tom@tromey.com>
15925
15926 * source.c (select_source_symtab)
15927 (forget_cached_source_info_for_objfile): Remove declaration.
15928 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
15929 declaration.
15930 * maint.c (count_symtabs_and_blocks): Remove declaration.
15931 * cp-support.c (add_symbol_overload_list_qualified): Remove
15932 declaration.
15933 * coffread.c (coff_symtab_read): Remove declaration.
15934 * symtab.c (lookup_symbol_in_objfile_symtabs)
15935 (basic_lookup_transparent_type_1): Use objfile_compunits.
15936 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
15937 (info_sources_command, search_symbols)
15938 (default_collect_symbol_completion_matches_break_on)
15939 (make_source_files_completion_list): Remove declaration.
15940 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
15941 (ada_collect_symbol_completion_matches)
15942 (ada_add_global_exceptions): Remove declaration.
15943 * linespec.c (iterate_over_all_matching_symtabs): Use
15944 objfile_compunits.
15945 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
15946 (class objfile_compunits): New.
15947 (ALL_COMPUNITS): Use objfile_compunits.
15948 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
15949 (maintenance_check_symtabs, maintenance_info_line_tables): Use
15950 objfile_compunits.
15951 * objfiles.c (objfile_relocate1): Use objfile_compunits.
15952
15953 2019-01-09 Tom Tromey <tom@tromey.com>
15954
15955 * symtab.c (search_symbols)
15956 (default_collect_symbol_completion_matches_break_on): Use
15957 objfile_msymbols.
15958 * ada-lang.c (ada_lookup_simple_minsym)
15959 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
15960 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
15961 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
15962 objfile_msymbols.
15963 * coffread.c (coff_symfile_read): Use objfile_msymbols.
15964 * symmisc.c (dump_msymbols): Use objfile_msymbols.
15965 * objc-lang.c (find_methods): Use objfile_msymbols.
15966 (info_selectors_command, info_classes_command): Likewise.
15967 * stabsread.c (scan_file_globals): Use objfile_msymbols.
15968 * objfiles.h (class objfile_msymbols): New.
15969 (ALL_OBJFILE_MSYMBOLS): Remove.
15970 (ALL_MSYMBOLS): Remove.
15971
15972 2019-01-09 Tom Tromey <tom@tromey.com>
15973
15974 * common/next-iterator.h (next_adapter): Add Iterator template
15975 parameter.
15976 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
15977 (class all_objfiles_safe): New.
15978 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
15979 * objfiles.c (put_objfile_before): Update comment.
15980 (add_separate_debug_objfile): Likewise.
15981 (free_all_objfiles): Use all_objfiles_safe.
15982 (objfile_purge_solibs): Likewise.
15983
15984 2019-01-09 Tom Tromey <tom@tromey.com>
15985
15986 * symtab.c (iterate_over_symtabs, matching_obj_sections)
15987 (expand_symtab_containing_pc, lookup_static_symbol)
15988 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
15989 (find_symbol_at_address, find_line_symtab, find_main_name): Use
15990 all_objfiles.
15991 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
15992 * breakpoint.c (create_overlay_event_breakpoint)
15993 (create_longjmp_master_breakpoint)
15994 (create_std_terminate_master_breakpoint)
15995 (create_exception_master_breakpoint): Use all_objfiles.
15996 * linux-thread-db.c (try_thread_db_load_from_pdir)
15997 (has_libpthread): Use all_objfiles.
15998 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
15999 * linespec.c (iterate_over_all_matching_symtabs)
16000 (search_minsyms_for_name): Use all_objfiles.
16001 * maint.c (maintenance_info_sections): Use all_objfiles.
16002 * main.c (captured_main_1): Use all_objfiles.
16003 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16004 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16005 * guile/scm-pretty-print.c
16006 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16007 * solib-spu.c (append_ocl_sos): Use all_objfiles.
16008 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16009 (maintenance_print_msymbols): Use all_objfiles.
16010 * source.c (select_source_symtab): Use all_objfiles.
16011 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16012 * symfile.c (remove_symbol_file_command)
16013 (expand_symtabs_matching, map_symbol_filenames): Use
16014 all_objfiles.
16015 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16016 all_objfiles.
16017 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16018 * objc-lang.c (find_methods): Use all_objfiles.
16019 * objfiles.c (have_partial_symbols, have_full_symbols)
16020 (have_minimal_symbols, qsort_cmp)
16021 (default_iterate_over_objfiles_in_search_order): Use
16022 all_objfiles.
16023 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16024 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16025 (maintenance_check_psymtabs): Use all_objfiles.
16026 (ALL_PSYMTABS): Remove.
16027 * compile/compile-object-run.c (do_module_cleanup): Use
16028 all_objfiles.
16029 * blockframe.c (find_pc_partial_function): Use all_objfiles.
16030 * cp-support.c (add_symbol_overload_list_qualified): Use
16031 all_objfiles.
16032 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16033 Use all_objfiles.
16034 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16035 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16036 all_objfiles.
16037 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16038 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16039 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16040 Uses all_objfiles.
16041 * solib.c (solib_read_symbols): Use all_objfiles
16042
16043 2019-01-09 Tom Tromey <tom@tromey.com>
16044
16045 * probe.c (parse_probes_in_pspace): Use all_objfiles.
16046 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16047 all_objfiles.
16048 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16049 * symmisc.c (print_symbol_bcache_statistics)
16050 (print_objfile_statistics, maintenance_print_objfiles)
16051 (maintenance_info_symtabs, maintenance_check_symtabs)
16052 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16053 all_objfiles.
16054 * source.c (forget_cached_source_info): Use all_objfiles.
16055 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16056 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16057 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16058 * objfiles.c (update_section_map): Use all_objfiles.
16059 (shared_objfile_contains_address_p): Likewise.
16060 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16061 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16062
16063 2019-01-09 Tom Tromey <tom@tromey.com>
16064
16065 * common/next-iterator.h: New file.
16066 * objfiles.h (class all_objfiles): New.
16067 (struct objfile_iterator): New.
16068
16069 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16070
16071 * NEWS: Move the description of the changed "frame", "select-frame",
16072 and "info frame" commands to the Changed commands section.
16073
16074 2019-01-09 Simon Marchi <simon.marchi@ericsson.com>
16075
16076 * gdbtypes.c (check_stub_method_group): Remove handling of old
16077 mangling schemes.
16078 * linespec.c (find_methods): Likewise.
16079 * stabsread.c (read_member_functions): Likewise.
16080 * valops.c (search_struct_method): Likewise.
16081 (value_struct_elt_for_reference): Likewise.
16082 * NEWS: Mention this change.
16083
16084 2019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
16085
16086 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16087 print_source_lines.
16088 * source.c (print_source_lines_base): Update line number check.
16089 (print_source_lines): New function.
16090 (source_lines_range::source_lines_range): New function.
16091 * source.h (class source_lines_range): New class.
16092 (print_source_lines): New declaration.
16093
16094 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16095
16096 * linespec.c (linespec_state_destructor): Free self->canonical_names.
16097
16098 2019-01-08 Tom Tromey <tom@tromey.com>
16099 Simon Marchi <simon.marchi@ericsson.com>
16100
16101 PR gdb/24060
16102 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16103 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16104 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16105 * f-exp.y (DOLLAR_VARIABLE): Likewise.
16106 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16107 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16108
16109 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16110
16111 * source.c (select_source_symtab): Move header comment to
16112 declaration in source.h.
16113 (forget_cached_source_info_for_objfile): Likewise.
16114 (forget_cached_source_info): Likewise.
16115 (identify_source_line): Likewise.
16116 * source.h (identify_source_line): Move declaration from symtab.h
16117 and add comment from source.c
16118 (print_source_lines): Likewise.
16119 (forget_cached_source_info_for_objfile): Likewise.
16120 (forget_cached_source_info): Likewise.
16121 (select_source_symtab): Likewise.
16122 (enum print_source_lines_flag): Move definition from symtab.h.
16123 * symtab.h (identify_source_line): Move declaration to source.h.
16124 (print_source_lines): Likewise.
16125 (forget_cached_source_info_for_objfile): Likewise.
16126 (forget_cached_source_info): Likewise.
16127 (select_source_symtab): Likewise.
16128 (enum print_source_lines_flag): Move definition to source.h.
16129 * tui/tui-hooks.c: Add 'source.h' include.
16130
16131 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16132
16133 * source.c (print_source_lines_base): Handle requests to print
16134 reverse line number sequences, and guard against empty lines
16135 string.
16136
16137 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16138
16139 * source.c (print_source_lines_base): Fix skip of '\r' if next
16140 character is '\n'.
16141
16142 2019-01-06 Tom Tromey <tom@tromey.com>
16143
16144 * c-exp.y (struct c_parse_state) <macro_original_text,
16145 expansion_obstack>: New member.
16146 (macro_original_text, expansion_obstack): Remove globals.
16147 (scan_macro_expansion, scanning_macro_expansion)
16148 (finished_macro_expansion): Update.
16149 (scan_macro_cleanup): Remove.
16150 (yylex, c_parse): Update.
16151
16152 2019-01-06 Tom Tromey <tom@tromey.com>
16153
16154 * c-exp.y (struct c_parse_state) <strings>: New member.
16155 (operator_stoken): Update.
16156
16157 2019-01-06 Tom Tromey <tom@tromey.com>
16158
16159 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
16160 (union type_stack_elt) <typelist_val>: Now a pointer to
16161 std::vector.
16162 (type_stack_cleanup): Don't declare.
16163 (push_typelist): Update.
16164 * parse.c (pop_typelist): Return a std::vector.
16165 (push_typelist): Take a std::vector.
16166 (follow_types): Update. Do not free args.
16167 (type_stack_cleanup): Remove.
16168 * c-exp.y (struct c_parse_state): New.
16169 (cpstate): New global.
16170 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16171 (nonempty_typelist): Update.
16172 (func_mod): Create a new vector.
16173 (c_parse): Create a c_parse_state.
16174 (check_parameter_typelist): Do not delete params.
16175 (function_method): Update. Do not delete type_list.
16176
16177 2019-01-06 Tom Tromey <tom@tromey.com>
16178
16179 PR gdb/28155:
16180 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16181 check_typedef.
16182 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16183 (print_return_value): Likewise.
16184
16185 2019-01-05 Tom Tromey <tom@tromey.com>
16186
16187 * contrib/cleanup_check.py: Remove.
16188 * contrib/gcc-with-excheck: Remove.
16189 * contrib/exsummary.py: Remove.
16190 * contrib/excheck.py: Remove.
16191
16192 2019-01-05 Joel Brobecker <brobecker@adacore.com>
16193
16194 * thread.c (delete_thread_1): Add gdb_assert that THR is not
16195 NULL. Initialize tpprev to NULL instead of assigning it
16196 to NULL on the next statement.
16197 * windows-nat.c (windows_delete_thread): Remove check for
16198 main_thread_id before printing thread exit notifications.
16199 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16200 Remove thread ID check against main_thread_id.
16201 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16202 windows_delete_thread.
16203 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16204
16205 2019-01-04 Tom Tromey <tom@tromey.com>
16206
16207 * compile/compile.c (_initialize_compile): Use upper case for
16208 metasyntactic variables.
16209 * symmisc.c (_initialize_symmisc): Use upper case for
16210 metasyntactic variables.
16211 * psymtab.c (_initialize_psymtab): Use upper case for
16212 metasyntactic variables.
16213 * demangle.c (demangle_command): Use upper case for metasyntactic
16214 variables.
16215 (_initialize_demangler): Likewise.
16216 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16217 variables.
16218
16219 2019-01-03 Tom Tromey <tom@tromey.com>
16220
16221 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16222
16223 2019-01-03 Tom Tromey <tom@tromey.com>
16224
16225 * python/py-symtab.c (salpy_str): Update.
16226 (struct salpy_sal_object) <symtab>: Now a PyObject.
16227 (salpy_dealloc): Update.
16228 (del_objfile_sal): Use gdbpy_ref.
16229
16230 2019-01-03 Tom Tromey <tom@tromey.com>
16231
16232 * python/py-type.c (convert_field): Use new_reference. Return
16233 gdbpy_ref.
16234 (make_fielditem): Return gdbpy_ref.
16235 (typy_fields): Update.
16236 (typy_getitem): Update.
16237 (field_name): Return gdbpy_ref. Use new_reference.
16238 (typy_iterator_iternext): Update.
16239
16240 2019-01-03 Tom Tromey <tom@tromey.com>
16241
16242 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16243
16244 2019-01-03 Tom Tromey <tom@tromey.com>
16245
16246 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16247 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16248 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16249 (pspy_set_frame_filters, pspy_set_frame_unwinders)
16250 (pspy_set_type_printers): Likewise.
16251 * python/py-function.c (fnpy_init): Use gdbpy_ref.
16252 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16253 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16254 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16255 (objfpy_set_type_printers): Likewise.
16256
16257 2019-01-03 Tom Tromey <tom@tromey.com>
16258
16259 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16260 (gdbpy_print_stack): Use gdbpy_err_fetch.
16261 * python/python-internal.h (class gdbpy_err_fetch): New class.
16262 (class gdbpy_enter) <m_error_type, m_error_value,
16263 m_error_traceback>: Remove.
16264 <m_error>: New member.
16265 (gdbpy_exception_to_string): Don't declare.
16266 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16267 * python/py-value.c (convert_value_from_python): Use
16268 gdbpy_err_fetch.
16269 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16270 gdbpy_exception_to_string.
16271 (gdbpy_handle_exception): Use gdbpy_err_fetch.
16272 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
16273 gdbpy_err_fetch.
16274
16275 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16276
16277 * linux-nat.c (delete_lwp_cleanup): Delete.
16278 (struct lwp_deleter): New struct.
16279 (lwp_info_up): New typedef.
16280 (linux_nat_target::follow_fork): Delete cleanup, and make use of
16281 lwp_info_up.
16282
16283 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16284
16285 * linux-fork.c (class scoped_switch_fork_info): New class.
16286 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
16287
16288 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16289
16290 * valops.c (find_overload_match): Remove use of null_cleanup, and
16291 calls to do_cleanups.
16292
16293 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16294
16295 * compile/compile-cplus-types.c
16296 (compile_cplus_instance::decl_name): Handle changes to
16297 cp_func_name.
16298 * cp-support.c (cp_func_name): Update header comment, update
16299 return type.
16300 * cp-support.h (cp_func_name): Update return type in declaration.
16301 * valops.c (find_overload_match): Move temp_func local to top
16302 level of function and change its type. Use temp_func to hold and
16303 delete temporary string obtained from cp_func_name.
16304
16305 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16306
16307 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
16308 gdb::char_vector, remove cleanup, and update uses of `msg`.
16309
16310 2019-01-03 Jim Wilson <jimw@sifive.com>
16311
16312 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
16313
16314 2019-01-02 Tom Tromey <tom@tromey.com>
16315
16316 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
16317 (tdesc_parse_xml): Remove cleanups.
16318 * target-descriptions.h (make_cleanup_free_target_description):
16319 Don't declare.
16320 (target_desc_deleter): New struct.
16321 (target_desc_up): New typedef.
16322 * target-descriptions.c (target_desc_deleter::operator()): Rename
16323 from free_target_description.
16324 (make_cleanup_free_target_description): Remove.
16325
16326 2019-01-02 Tom Tromey <tom@tromey.com>
16327
16328 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
16329 constructor, destructor.
16330 (linespec_parser): Remove typedef.
16331 (~linespec_parser): Rename from linespec_parser_delete.
16332 (linespec_lex_to_end, linespec_complete_label)
16333 (linespec_complete): Update.
16334 (decode_line_full): Remove cleanups.
16335 (decode_line_1): Update.
16336
16337 2019-01-02 Tom Tromey <tom@tromey.com>
16338
16339 * python/python-internal.h (inferior_to_inferior_object): Change
16340 return type.
16341 * python/py-exitedevent.c (create_exited_event_object): Update.
16342 * python/py-inferior.c (inferior_to_inferior_object): Return
16343 gdbpy_ref.
16344 (python_new_inferior, python_inferior_deleted)
16345 (thread_to_thread_object, delete_thread_object)
16346 (build_inferior_list, gdbpy_selected_inferior): Update.
16347 * python/py-infthread.c (create_thread_object): Update. Also fail
16348 if inferior_to_inferior_object fails.
16349
16350 2019-01-02 Simon Marchi <simon.marchi@ericsson.com>
16351
16352 * inferior.h (class inferior) <displaced_step_state>: New field.
16353 * infrun.h (struct displaced_step_state): Move here from
16354 infrun.c. Initialize fields, add constructor.
16355 <inf>: Remove field.
16356 <reset>: New method.
16357 * infrun.c (struct displaced_step_inferior_state): Move to
16358 infrun.h.
16359 (displaced_step_inferior_states): Remove.
16360 (get_displaced_stepping_state): Adust.
16361 (displaced_step_in_progress_any_inferior): Adjust.
16362 (displaced_step_in_progress_thread): Adjust.
16363 (displaced_step_in_progress): Adjust.
16364 (add_displaced_stepping_state): Remove.
16365 (get_displaced_step_closure_by_addr): Adjust.
16366 (remove_displaced_stepping_state): Remove.
16367 (infrun_inferior_exit): Call displaced_step_state.reset.
16368 (use_displaced_stepping): Don't check for NULL.
16369 (displaced_step_prepare_throw): Call
16370 get_displaced_stepping_state.
16371 (displaced_step_fixup): Don't check for NULL.
16372 (prepare_for_detach): Don't check for NULL.
16373
16374 2019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16375
16376 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
16377 in case of call that did not complete.
16378
16379 2019-01-02 Andrey Utkin <autkin@undo.io>
16380
16381 * symfile.c (find_separate_debug_file): Fix search of debug files for
16382 remote debuggee.
16383
16384 2019-01-02 Tom Tromey <tom@tromey.com>
16385
16386 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
16387 indentation.
16388 * python/py-frame.c (frapy_older): Remove cast.
16389 (frapy_newer): Likewise.
16390 * python/py-breakpoint.c (local_setattro): Remove cast.
16391 * python/py-arch.c (archpy_name): Remove local variable.
16392 * python/py-type.c (gdbpy_lookup_type): Remove cast.
16393
16394 2019-01-02 Joel Brobecker <brobecker@adacore.com>
16395
16396 * unittests/basic_string_view/element_access/char/empty.cc:
16397 Fix year range in copyright header.
16398
16399 2019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
16400
16401 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
16402 Delete.
16403 <operator==>: Update with for removed field.
16404 <hash>: Likewise.
16405 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
16406 <isa_features>: ...this.
16407 <abi_features>: New field.
16408 (riscv_isa_flen): Update comment.
16409 (riscv_abi_xlen): New declaration.
16410 (riscv_abi_flen): New declaration.
16411 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
16412 isa_features.
16413 (riscv_abi_xlen): New function.
16414 (riscv_isa_flen): Update to get answer from isa_features.
16415 (riscv_abi_flen): New function.
16416 (riscv_has_fp_abi): Update to get answer from abi_features.
16417 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
16418 xlen and flen.
16419 (riscv_call_info) <xlen, flen>: Update comment.
16420 (riscv_call_arg_struct): Remove invalid assertions
16421 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
16422 is removed.
16423 (riscv_gdbarch_init): Gather isa features and abi features
16424 separately, ensure both match on the gdbarch when reusing an old
16425 gdbarch. Relax an error check to allow 32-bit abi float to run on
16426 a target with 64-bit float hardware.
16427
16428 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16429
16430 * source.c (search_command_helper): Stop reverse search
16431 when line 1 has been searched.
16432
16433 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16434
16435 * record-full.c (record_full_base_target::close): Rewrite
16436 record_full_core_buf_list free logic.
16437
16438 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16439
16440 * break-catch-syscall.c (print_one_catch_syscall): xfree
16441 the last text.
16442
16443 2019-01-01 Joel Brobecker <brobecker@adacore.com>
16444
16445 * top.c (print_gdb_version): Update Copyright year in version
16446 message.
16447
16448 2019-01-01 Joel Brobecker <brobecker@adacore.com>
16449
16450 Update copyright year range in all GDB files.
16451
16452 2019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
16453
16454 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
16455
16456 For older changes see ChangeLog-2018.
16457 \f
16458 Local Variables:
16459 mode: change-log
16460 left-margin: 8
16461 fill-column: 74
16462 version-control: never
16463 coding: utf-8
16464 End:
16465
This page took 0.379646 seconds and 4 git commands to generate.