gdb/ChangeLog

   1 2019-03-15  Tom Tromey  <tom@tromey.com>
   2
   3         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
   4
   5 2019-03-15  Tom Tromey  <tom@tromey.com>
   6
   7         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
   8         unique_xmalloc_ptr.
   9         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
  10         Update.
  11         * minsyms.c (lookup_minimal_symbol_by_pc_section)
  12         (build_minimal_symbol_hash_tables)
  13         (minimal_symbol_reader::install): Update.
  14
  15 2019-03-15  Tom Tromey  <tom@tromey.com>
  16
  17         * symtab.c (create_demangled_names_hash): Update.
  18         (symbol_set_names): Update.
  19         * objfiles.h (struct objfile_per_bfd_storage)
  20         <demangled_names_hash>: Now an htab_up.
  21         * objfiles.c (objfile_per_bfd_storage): Simplify.
  22
  23 2019-03-15  Tom Tromey  <tom@tromey.com>
  24
  25         * objfiles.h (struct objfile_per_bfd_storage): Declare
  26         destructor.
  27         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
  28         New.
  29         (get_objfile_bfd_data): Use new.  Don't initialize
  30         language_of_main.
  31         (free_objfile_per_bfd_storage): Remove.
  32         (objfile_bfd_data_free, objfile::~objfile): Use delete.
  33
  34 2019-03-15  Tom Tromey  <tom@tromey.com>
  35
  36         * symfile.c (reread_symbols): Update.
  37         * objfiles.c (objfile::objfile): Update.
  38         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
  39         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
  40         comment.
  41         (minimal_symbol_reader::install): Update.
  42         (terminate_minimal_symbol_table): Remove.
  43         * jit.c (jit_object_close_impl): Update.
  44
  45 2019-03-15  Tom Tromey  <tom@tromey.com>
  46
  47         * minsyms.c (minimal_symbol_reader::record_full): Remove some
  48         initializations.
  49
  50 2019-03-15  Tom Tromey  <tom@tromey.com>
  51
  52         * objfiles.h (struct objfile_per_bfd_storage)
  53         <demangled_hash_languages>: Now a bitset.
  54         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
  55         (lookup_minimal_symbol): Update.
  56
  57 2019-03-15  Tom Tromey  <tom@tromey.com>
  58
  59         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
  60         Don't return the symbol.
  61         * coffread.c (record_minimal_symbol): Use record_full.
  62
  63 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
  64
  65         The MS-Windows port of ncurses fails to switch to a color pair if
  66         one or both of the colors are the implicit default colors.  This
  67         change records the default colors when TUI is initialized, and
  68         then specifies them explicitly when a color pair uses the default
  69         colors.  This allows color styling in TUI mode on MS-Windows.
  70
  71         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
  72         ncurses_norm_attr.
  73         (tui_initialize_io) [__MINGW32__]: Record the default terminal
  74         colors in ncurses_norm_attr.
  75         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
  76         "none", replace it with the default color recorded in
  77         ncurses_norm_attr.
  78
  79 2019-03-14  Tom Tromey  <tromey@adacore.com>
  80
  81         * source-cache.h (class source_cache) <get_source_lines>: Return
  82         std::string.
  83         * source-cache.c (source_cache::extract_lines): Handle case where
  84         first_pos==npos.  Return std::string.
  85         (source_cache::get_source_lines): Update.
  86
  87 2019-03-14  Tom Tromey  <tromey@adacore.com>
  88
  89         * NEWS: Add item for "style sources" commands.
  90         * source-cache.c (source_cache::get_source_lines): Check
  91         source_styling.
  92         * cli/cli-style.c (source_styling): New global.
  93         (_initialize_cli_style): Add "style sources" commands.
  94         (show_style_sources): New function.
  95         * cli/cli-style.h (source_styling): Declare.
  96
  97 2019-03-14  Pedro Alves  <palves@redhat.com>
  98             Tom Tromey  <tromey@adacore.com>
  99
 100         * tui/tui-winsource.h (tui_refill_source_window): Declare.
 101         * tui/tui-winsource.c (tui_refill_source_window): New function,
 102         from...
 103         (tui_horizontal_source_scroll): ... here.  Move some logic.
 104         * cli/cli-style.c (set_style_enabled): Notify new observable.
 105         * tui/tui-hooks.c (tui_redisplay_source): New function.
 106         (tui_attach_detach_observers): Attach or detach
 107         tui_redisplay_source.
 108         * observable.h (source_styling_changed): New observable.
 109         * observable.c: Define source_styling_changed observable.
 110
 111 2019-03-13  Tom Tromey  <tromey@adacore.com>
 112
 113         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
 114         (i386_gnu_nat_target::store_registers): Update.
 115         * target-debug.h (target_debug_print_std_string): New macro.
 116         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
 117         * windows-tdep.c (display_one_tib): Update.
 118         * tui/tui-stack.c (tui_make_status_line): Update.
 119         * top.c (print_inferior_quit_action): Update.
 120         * thread.c (thr_try_catch_cmd): Update.
 121         (add_thread_with_info): Update.
 122         (thread_target_id_str): Update.
 123         (thr_try_catch_cmd): Update.
 124         (thread_command): Update.
 125         (thread_find_command): Update.
 126         * record-btrace.c (record_btrace_target::info_record)
 127         (record_btrace_resume_thread, record_btrace_target::resume)
 128         (record_btrace_cancel_resume, record_btrace_step_thread)
 129         (record_btrace_target::wait, record_btrace_target::wait)
 130         (record_btrace_target::wait, record_btrace_target::stop): Update.
 131         * progspace.c (print_program_space): Update.
 132         * process-stratum-target.c
 133         (process_stratum_target::thread_address_space): Update.
 134         * linux-fork.c (linux_fork_mourn_inferior)
 135         (detach_checkpoint_command, info_checkpoints_command)
 136         (linux_fork_context): Update.
 137         (linux_fork_detach): Update.
 138         (class scoped_switch_fork_info): Update.
 139         (delete_checkpoint_command): Update.
 140         * infrun.c (follow_fork_inferior): Update.
 141         (follow_fork_inferior): Update.
 142         (proceed_after_vfork_done): Update.
 143         (handle_vfork_child_exec_or_exit): Update.
 144         (follow_exec): Update.
 145         (displaced_step_prepare_throw): Update.
 146         (displaced_step_restore): Update.
 147         (start_step_over): Update.
 148         (resume_1): Update.
 149         (clear_proceed_status_thread): Update.
 150         (proceed): Update.
 151         (print_target_wait_results): Update.
 152         (do_target_wait): Update.
 153         (context_switch): Update.
 154         (stop_all_threads): Update.
 155         (restart_threads): Update.
 156         (finish_step_over): Update.
 157         (handle_signal_stop): Update.
 158         (switch_back_to_stepped_thread): Update.
 159         (keep_going_pass_signal): Update.
 160         (print_exited_reason): Update.
 161         (normal_stop): Update.
 162         * inferior.c (inferior_pid_to_str): Change return type.
 163         (print_selected_inferior): Update.
 164         (add_inferior): Update.
 165         (detach_inferior): Update.
 166         * dummy-frame.c (fprint_dummy_frames): Update.
 167         * dcache.c (dcache_info_1): Update.
 168         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
 169         (btrace_fetch, btrace_clear): Update.
 170         * linux-tdep.c (linux_core_pid_to_str): Change return type.
 171         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
 172         type.
 173         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
 174         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
 175         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
 176         * gdbarch.c, gdbarch.h: Rebuild.
 177         * gdbarch.sh (core_pid_to_str): Change return type.
 178         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
 179         return type.
 180         (windows_nat_target::pid_to_str): Change return type.
 181         (windows_delete_thread): Update.
 182         (windows_nat_target::attach): Update.
 183         (windows_nat_target::files_info): Update.
 184         * target-delegates.c: Rebuild.
 185         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
 186         return type.
 187         (sol_thread_target::pid_to_str): Change return type.
 188         * remote.c (class remote_target) <pid_to_str>: Change return
 189         type.
 190         (remote_target::pid_to_str): Change return type.
 191         (extended_remote_target::attach, remote_target::remote_stop_ns)
 192         (remote_target::remote_notif_remove_queued_reply)
 193         (remote_target::push_stop_reply, remote_target::disable_btrace):
 194         Update.
 195         (extended_remote_target::attach): Update.
 196         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
 197         type.
 198         (gdbsim_target::pid_to_str): Change return type.
 199         * ravenscar-thread.c (struct ravenscar_thread_target)
 200         <pid_to_str>: Change return type.
 201         (ravenscar_thread_target::pid_to_str): Change return type.
 202         * procfs.c (class procfs_target) <pid_to_str>: Change return
 203         type.
 204         (procfs_target::pid_to_str): Change return type.
 205         (procfs_target::attach): Update.
 206         (procfs_target::detach): Update.
 207         (procfs_target::fetch_registers): Update.
 208         (procfs_target::store_registers): Update.
 209         (procfs_target::wait): Update.
 210         (procfs_target::files_info): Update.
 211         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
 212         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
 213         return type.
 214         (nto_procfs_target::pid_to_str): Change return type.
 215         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
 216         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
 217         return type.
 218         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
 219         (exit_lwp): Update.
 220         (attach_proc_task_lwp_callback, get_detach_signal)
 221         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
 222         (linux_nat_target::resume, wait_lwp, stop_callback)
 223         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
 224         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
 225         (linux_nat_wait_1, resume_stopped_resumed_lwps)
 226         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
 227         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
 228         type.
 229         (inf_ptrace_target::attach): Update.
 230         (inf_ptrace_target::files_info): Update.
 231         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
 232         type.
 233         (go32_nat_target::pid_to_str): Change return type.
 234         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
 235         (gnu_nat_target::wait): Update.
 236         (gnu_nat_target::wait): Update.
 237         (gnu_nat_target::resume): Update.
 238         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
 239         (fbsd_nat_target::wait): Update.
 240         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
 241         type.
 242         (darwin_nat_target::attach): Update.
 243         * corelow.c (class core_target) <pid_to_str>: Change return type.
 244         (core_target::pid_to_str): Change return type.
 245         * target.c (normal_pid_to_str): Change return type.
 246         (default_pid_to_str): Likewise.
 247         (target_pid_to_str): Change return type.
 248         (target_translate_tls_address): Update.
 249         (target_announce_detach): Update.
 250         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
 251         return type.
 252         (bsd_uthread_target::pid_to_str): Change return type.
 253         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
 254         type.
 255         (bsd_kvm_target::pid_to_str): Change return type.
 256         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
 257         return type.
 258         (aix_thread_target::pid_to_str): Change return type.
 259         * target.h (struct target_ops) <pid_to_str>: Change return type.
 260         (target_pid_to_str, normal_pid_to_str): Likewise.
 261         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
 262         type.
 263         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
 264         type.
 265         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
 266         return type.
 267         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
 268         type.
 269         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
 270         type.
 271         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
 272         return type.
 273
 274 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
 275
 276         * NEWS: Mention that the new default MI version is 3.  Mention
 277         changes to the output of commands and events that deal with
 278         multi-location breakpoints.
 279         * breakpoint.c: Include "mi/mi-out.h".
 280         (print_one_breakpoint): Change output syntax if using MI version
 281         >= 3.
 282         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
 283         New.
 284         (mi_multi_location_breakpoint_output_fixed): New.
 285         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
 286         (mi_cmd_fix_multi_location_breakpoint_output): New.
 287         (mi_multi_location_breakpoint_output_fixed): New.
 288         * mi/mi-cmds.c (mi_cmds): Register command
 289         -fix-multi-location-breakpoint-output.
 290         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
 291         interpreter "mi".
 292
 293 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
 294
 295         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
 296         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
 297         instantiate mi_ui_out based on interpreter name.
 298         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
 299         * mi/mi-main.c (mi_load_progress): Likewise.
 300
 301 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 302
 303         * NEWS: Combine separate "New targets" sections for 8.3.
 304
 305 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 306
 307         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
 308         (ppcfbsd_init_abi): Install gdbarch
 309         "fetch_tls_load_module_address" and "get_thread_local_address"
 310         methods.
 311
 312 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 313
 314         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
 315         (riscv_fbsd_init_abi): Install gdbarch
 316         "fetch_tls_load_module_address" and "get_thread_local_address"
 317         methods.
 318
 319 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 320
 321         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
 322         (i386fbsd_init_abi): Install gdbarch
 323         "fetch_tls_load_module_address" and "get_thread_local_address"
 324         methods.
 325
 326 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 327
 328         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
 329         (amd64fbsd_init_abi): Install gdbarch
 330         "fetch_tls_load_module_address" and "get_thread_local_address"
 331         methods.
 332
 333 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 334
 335         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
 336         (struct fbsd_pspace_data): New type.
 337         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
 338         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
 339         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
 340         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
 341         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
 342
 343 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 344
 345         * gdbtypes.c (lookup_struct_elt): New function.
 346         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
 347         * gdbtypes.h (struct struct_elt): New type.
 348         (lookup_struct_elt): New prototype.
 349
 350 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 351
 352         * gdbtypes.c (lookup_struct_elt_type): Update comment and
 353         remove disabled code block.
 354
 355 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 356
 357         * gdbarch.sh (get_thread_local_address): New method.
 358         * gdbarch.h, gdbarch.c: Regenerate.
 359         * target.c (target_translate_tls_address): Use
 360         gdbarch_get_thread_local_address if present instead of
 361         target::get_thread_local_address.
 362
 363 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 364
 365         * target.h (target::get_thread_local_address): Update comment.
 366
 367 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 368
 369         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
 370         objfile->separate_debug_objfile_backlink if not NULL.
 371
 372 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 373
 374         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
 375         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
 376         (amd64bsd_store_inferior_registers): Likewise.
 377         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 378         Enable segment base registers.
 379         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
 380         PT_GETFSBASE and PT_GETGSBASE.
 381         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
 382         PT_SETGSBASE.
 383         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
 384         segment base registers.
 385         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 386
 387 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 388
 389         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 390         Update calls to i386_target_description to add 'segments'
 391         parameter.
 392         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
 393         add segment base registers.
 394         * arch/i386.c (i386_create_target_description): Add 'segments'
 395         parameter to enable segment base registers.
 396         * arch/i386.h (i386_create_target_description): Likewise.
 397         * features/i386/32bit-segments.xml: New file.
 398         * features/i386/32bit-segments.c: Generate.
 399         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
 400         call to i386_target_description to add 'segments' parameter.
 401         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 402         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
 403         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
 404         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
 405         if feature is present.
 406         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
 407         Add 'segments' parameter to call to i386_target_description.
 408         (i386_target_description): Add 'segments' parameter to enable
 409         segment base registers.
 410         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
 411         to call to i386_target_description.
 412         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
 413         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
 414         Define I386_NUM_REGS.
 415         (i386_target_description): Add 'segments' parameter to enable
 416         segment base registers.
 417
 418 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
 419
 420         PR/24325
 421         * source-cache.c: #undef open and close, to avoid unresolved
 422         externals during linking.
 423
 424 2019-03-12  Tom Tromey  <tromey@adacore.com>
 425
 426         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
 427         const.  Add initializers.
 428         (_initialize_remote): Don't initialize ptid globals.
 429
 430 2019-03-12  Pedro Alves  <palves@redhat.com>
 431
 432         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
 433
 434 2019-03-12  Pedro Alves  <palves@redhat.com>
 435
 436         * cp-name-parser.y (main): Remove unused 'len' variable.
 437
 438 2019-03-12  Tom Tromey  <tromey@adacore.com>
 439
 440         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
 441         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
 442
 443 2019-03-12  Tom Tromey  <tromey@adacore.com>
 444
 445         * linux-nat.c (iterate_over_lwps): Update.
 446         (stop_callback): Remove parameter.
 447         (stop_wait_callback, detach_callback, resume_set_callback)
 448         (select_singlestep_lwp_callback, set_ignore_sigint)
 449         (status_callback, resumed_callback, resume_clear_callback)
 450         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
 451         data parameter.
 452         (linux_nat_target::detach, linux_nat_target::resume)
 453         (linux_stop_and_wait_all_lwps, select_event_lwp)
 454         (linux_nat_filter_event, linux_nat_wait_1)
 455         (linux_nat_target::kill, linux_nat_target::stop)
 456         (linux_nat_target::stop): Update.
 457         (linux_nat_resume_callback): Change type.
 458         (resume_stopped_resumed_lwps, count_events_callback)
 459         (select_event_lwp_callback): Likewise.
 460         (linux_stop_lwp, linux_nat_stop_lwp): Update.
 461         * arm-linux-nat.c (struct update_registers_data): Remove.
 462         (update_registers_callback): Change type.
 463         (arm_linux_insert_hw_breakpoint1): Update.
 464         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
 465         parameter.
 466         (x86_linux_dr_set_addr): Update.
 467         (x86_linux_dr_set_control): Update.
 468         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
 469         (iterate_over_lwps): Use gdb::function_view.
 470         * nat/aarch64-linux-hw-point.c (struct
 471         aarch64_dr_update_callback_param): Remove.
 472         (debug_reg_change_callback): Change type.
 473         (aarch64_notify_debug_reg_change): Update.
 474         * s390-linux-nat.c (s390_refresh_per_info): Update.
 475
 476 2019-03-11  Tom Tromey  <tromey@adacore.com>
 477
 478         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
 479         redundant assignment to "this_cu".
 480
 481 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 482
 483         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
 484
 485 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 486
 487         * gdbtypes.c (rank_one_type_parm_set): New function extracted
 488         from...
 489         (rank_one_type): ... this.
 490
 491 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 492
 493         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
 494         from...
 495         (rank_one_type): ... this.
 496
 497 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 498
 499         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
 500         from...
 501         (rank_one_type): ... this.
 502
 503 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 504
 505         * gdbtypes.c (rank_one_type_parm_float): New function extracted
 506         from...
 507         (rank_one_type): ... this.
 508
 509 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 510
 511         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
 512         from...
 513         (rank_one_type): ... this.
 514
 515 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 516
 517         * gdbtypes.c (rank_one_type_parm_range): New function extracted
 518         from...
 519         (rank_one_type): ... this.
 520
 521 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 522
 523         * gdbtypes.c (rank_one_type_parm_char): New function extracted
 524         from...
 525         (rank_one_type): ... this.
 526
 527 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 528
 529         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
 530         from...
 531         (rank_one_type): ... this.
 532
 533 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 534
 535         * gdbtypes.c (rank_one_type_parm_int): New function extracted
 536         from...
 537         (rank_one_type): ... this.
 538
 539 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 540
 541         * gdbtypes.c (rank_one_type_parm_func): New function extracted
 542         from...
 543         (rank_one_type): ... this.
 544
 545 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 546
 547         * gdbtypes.c (rank_one_type_parm_array): New function extracted
 548         from...
 549         (rank_one_type): ... this.
 550
 551 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 552
 553         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
 554         from...
 555         (rank_one_type): ... this.
 556
 557 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 558
 559         * inferior.c (initialize_inferiors): Ensure 'help set/show print
 560         inferior-events' shows the example events.
 561
 562 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
 563
 564         Support styling on native MS-Windows console
 565
 566         PR/24315
 567         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
 568         on MS-Windows if $TERM is not defined.
 569
 570         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
 571
 572         * posix-hdep.c (gdb_console_fputs):
 573         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
 574         functions.
 575         * ui-file.h (gdb_console_fputs): Add prototype.
 576
 577         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
 578         back to fputs only if the former returns zero.
 579
 580 2019-03-07  Tom Tromey  <tom@tromey.com>
 581
 582         * symmisc.c (print_symbol_bcache_statistics): Update.
 583         (print_objfile_statistics): Update.
 584         * symfile.c (allocate_symtab): Update.
 585         * stabsread.c: Don't include bcache.h.
 586         * psymtab.h (struct psymbol_bcache): Don't declare.
 587         (class psymtab_storage) <psymbol_cache>: Now a bcache.
 588         (psymbol_bcache_init, psymbol_bcache_free)
 589         (psymbol_bcache_get_bcache): Don't declare.
 590         * psymtab.c (struct psymbol_bcache): Remove.
 591         (psymtab_storage::psymtab_storage): Update.
 592         (psymtab_storage::~psymtab_storage): Update.
 593         (psymbol_bcache_init, psymbol_bcache_free)
 594         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
 595         (add_psymbol_to_bcache): Update.
 596         (allocate_psymtab): Update.
 597         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
 598         macro_cache>: No longer pointers.
 599         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
 600         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
 601         * macrotab.c (macro_bcache): Update.
 602         * macroexp.c: Don't include bcache.h.
 603         * gdbtypes.c (check_types_worklist): Update.
 604         (types_deeply_equal): Remove TRY/CATCH.  Update.
 605         * elfread.c (elf_symtab_read): Update.
 606         * dwarf2read.c: Don't include bcache.h.
 607         * buildsym.c (buildsym_compunit::get_macro_table): Update.
 608         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
 609         (print_bcache_statistics, bcache_memory_used): Don't declare.
 610         (struct bcache): Move from bcache.c.  Add constructor, destructor,
 611         methods.  Rename all data members.
 612         * bcache.c (struct bcache): Move to bcache.h.
 613         (bcache::expand_hash_table): Rename from expand_hash_table.
 614         (bcache): Remove.
 615         (bcache::insert): Rename from bcache_full.
 616         (bcache::compare): Rename from bcache_compare.
 617         (bcache_xmalloc): Remove.
 618         (bcache::~bcache): Rename from bcache_xfree.
 619         (bcache::print_statistics): Rename from print_bcache_statistics.
 620         (bcache::memory_used): Rename from bcache_memory_used.
 621
 622 2019-03-07  Pedro Alves  <palves@redhat.com>
 623
 624         * infrun.c (normal_stop): Also check for
 625         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
 626
 627 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 628
 629         * f-lang.c (value_from_host_double): Moved to...
 630         * value.c (value_from_host_double): ...here.
 631         * value.h (value_from_host_double): Declare.
 632         * guile/scm-math.c (vlscm_convert_typed_number): Use
 633         value_from_host_double.
 634         (vlscm_convert_number): Likewise.
 635         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
 636         * python/py-value.c (convert_value_from_python): Likewise.
 637
 638 2019-03-06  Tom Tromey  <tom@tromey.com>
 639
 640         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
 641
 642 2019-03-06  Tom Tromey  <tom@tromey.com>
 643
 644         * utils.h (free_current_contents): Don't declare.
 645         * utils.c (free_current_contents): Remove.
 646
 647 2019-03-06  Tom Tromey  <tom@tromey.com>
 648
 649         * top.c (quit_force): Update.
 650         * main.c (captured_command_loop): Update.
 651         * common/new-op.c (operator new): Update.
 652         * common/common-exceptions.c (struct catcher)
 653         <save_cleanup_chain>: Remove member.
 654         (exceptions_state_mc_init): Update.
 655         (exception_try_scope_entry): Return nullptr.
 656         (exception_try_scope_exit, exception_rethrow)
 657         (throw_exception_sjlj, throw_exception_cxx): Update.
 658         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
 659         (all_cleanups, do_cleanups, discard_cleanups)
 660         (discard_final_cleanups, save_cleanups, save_final_cleanups)
 661         (restore_cleanups, restore_final_cleanups): Don't declare.
 662         (do_final_cleanups): Remove parameter.
 663         * common/cleanups.c (cleanup_chain, make_cleanup)
 664         (make_cleanup_dtor, all_cleanups, do_cleanups)
 665         (discard_my_cleanups, discard_cleanups)
 666         (discard_final_cleanups, save_my_cleanups, save_cleanups)
 667         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
 668         (null_cleanup): Remove.
 669         (do_final_cleanups): Remove parameter.
 670
 671 2019-03-06  Tom Tromey  <tom@tromey.com>
 672
 673         * remote.c (remote_target::remote_parse_stop_reply): Use
 674         unique_xmalloc_ptr.
 675
 676 2019-03-06  Tom Tromey  <tom@tromey.com>
 677
 678         * stabsread.c (struct stabs_field_info): Rename from field_info.
 679         <list, fnlist>: Add initializers.
 680         <obstack>: New member.
 681         (read_member_functions, read_struct_fields, read_baseclasses):
 682         Allocate on obstack.  Don't use cleanups.
 683         (read_one_struct_field, read_member_functions, read_struct_fields)
 684         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
 685         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
 686         (read_struct_type): Update.
 687
 688 2019-03-06  Tom Tromey  <tom@tromey.com>
 689
 690         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
 691         * common/filestuff.h (make_cleanup_close): Don't declare.
 692         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
 693         Remove.
 694
 695 2019-03-06  Tom Tromey  <tom@tromey.com>
 696
 697         * solib-aix.c: Use make_scope_exit.
 698
 699 2019-03-06  Tom Tromey  <tom@tromey.com>
 700
 701         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
 702         Use make_scope_exit.
 703
 704 2019-03-06  Tom Tromey  <tom@tromey.com>
 705
 706         * solib-svr4.c (disable_probes_interface): Remove parameter.
 707         (svr4_handle_solib_event): Use make_scope_exit.
 708
 709 2019-03-06  Tom Tromey  <tom@tromey.com>
 710
 711         * remote.c (struct stop_reply_deleter): Remove.
 712         (stop_reply_up): Update.
 713         (struct stop_reply): Derive from notif_event.  Don't typedef.
 714         <regcache>: Now a std::vector.
 715         (stop_reply_xfree): Remove.
 716         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
 717         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
 718         (remote_target::discard_pending_stop_replies): Use delete.
 719         (remote_target::remote_parse_stop_reply): Update.
 720         (remote_target::process_stop_reply): Update.
 721         * remote-notif.h (struct notif_event): Add virtual destructor.
 722         Remove "dtr" member.
 723         (struct notif_client) <alloc_event>: Return a unique_ptr.
 724         (notif_event_xfree): Don't declare.
 725         (notif_event_up): New typedef.
 726         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
 727         (notif_event_xfree, do_notif_event_xfree): Remove.
 728         (remote_notif_state_xfree): Update.
 729
 730 2019-03-06  Tom Tromey  <tom@tromey.com>
 731
 732         * infrun.c (displaced_step_clear_cleanup): Now a
 733         forward_scope_exit type.
 734         (displaced_step_prepare_throw): Update.
 735         (displaced_step_fixup): Update.
 736
 737 2019-03-06  Tom Tromey  <tom@tromey.com>
 738
 739         * inferior.h (class inferior): Update comment.
 740         * gdbthread.h (class thread_info): Update comment.
 741
 742 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
 743             Tom Tromey  <tom@tromey.com>
 744
 745         * stabsread.h (struct stab_section_list): Remove.
 746         (coffstab_build_psymtabs): Update.
 747         * dbxread.c (symbuf_sections): Now a std::vector.
 748         (sect_idx): New global.
 749         (fill_symbuf): Update.
 750         (coffstab_build_psymtabs): Change type of stabsects parameter.
 751         Update.
 752         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
 753         std::vector.
 754         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
 755         (coff_locate_sections): Update.
 756         (coff_symfile_read): Remove cleanups.  Update.
 757         (init_stringtab): Add storage parameter.
 758         (free_stringtab, free_stringtab_cleanup): Remove.
 759         (init_lineno): Add storage parameter.
 760         (free_linetab, free_linetab_cleanup): Remove.
 761
 762 2019-03-06  Pedro Alves  <palves@redhat.com>
 763
 764         * linux-fork.c (fork_info::clobber_regs): Delete.
 765         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
 766         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
 767         comment.  Adjust.
 768         (scoped_switch_fork_info::scoped_switch_fork_info)
 769         (checkpoint_command, linux_fork_context): Adjust
 770         fork_save_infrun_state calls.
 771
 772 2019-03-06  Pedro Alves  <palves@redhat.com>
 773
 774         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
 775         (inf_has_multiple_threads): Return 'bool' and rewrite using
 776         inferior_info::threads().
 777
 778 2019-03-06  Pedro Alves  <palves@redhat.com>
 779
 780         * linux-fork.c: Include <list>.
 781         (fork_list): Now a std::list instance.
 782         (fork_info): Add ctor, dtor, and in-class initialize all fields.
 783         (forks_exist_p, find_last_fork): Adjust.
 784         (new_fork): Delete.
 785         (one_fork_p): New.
 786         (add_fork): Adjust.
 787         (free_fork): Delete, folded into fork_info::~fork_info().
 788         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
 789         Adjust.
 790         (init_fork_list): Delete.
 791         (linux_fork_killall, linux_fork_mourn_inferior)
 792         (linux_fork_detach, info_checkpoints_command): Adjust.
 793         (_initialize_linux_fork): No longer call init_fork_list.
 794
 795 2019-03-06  Pedro Alves  <palves@redhat.com>
 796
 797         * linux-fork.c (new_fork): New, split out of ...
 798         (add_fork): ... this.  Return void.  Move "first fork" special
 799         case from here, to ...
 800         (checkpoint_command): ... here.
 801         * linux-linux.h (add_fork): Return void.
 802
 803 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 804
 805         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
 806
 807 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 808             Chris January  <chris.january@arm.com>
 809             David Lecomber  <david.lecomber@arm.com>
 810
 811         * f-exp.y: New token, UNOP_INTRINSIC.
 812         (exp): New pattern using UNOP_INTRINSIC token.
 813         (f77_keywords): Add 'abs' keyword.
 814         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
 815         (value_from_host_double): New function.
 816         (evaluate_subexp_f): Support UNOP_ABS.
 817
 818 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 819
 820         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
 821         types.
 822
 823 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 824
 825         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
 826         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
 827         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
 828
 829 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 830
 831         * f-exp.y (convert_to_kind_type): Handle more type kinds.
 832
 833 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 834             Chris January  <chris.january@arm.com>
 835
 836         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
 837         * f-exp.y: Define 'KIND' token.
 838         (exp): New pattern for KIND expressions.
 839         (ptype): Handle types with a kind extension.
 840         (direct_abs_decl): Extend to spot kind extensions.
 841         (f77_keywords): Add 'kind' to the list.
 842         (push_kind_type): New function.
 843         (convert_to_kind_type): New function.
 844         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
 845         * parse.c (operator_length_standard): Likewise.
 846         * parser-defs.h (enum type_pieces): Add tp_kind.
 847         * std-operator.def: Add UNOP_KIND.
 848
 849 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 850
 851         * f-exp.y (f_parse): Set yydebug.
 852
 853 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 854
 855         * f-lang.c (evaluate_subexp_f): New function.
 856         (exp_descriptor_f): New global.
 857         (f_language_defn): Use exp_descriptor_f instead of
 858         exp_descriptor_standard.
 859
 860 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 861
 862         * f-exp.y (struct token): Add comments.
 863         (dot_ops): Remove uppercase versions and the end marker.
 864         (f77_keywords): Likewise.
 865         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
 866         entries in the dot_ops array are case insensitive, and use
 867         strncasecmp to compare strings.  Also some whitespace cleanup in
 868         this area.  Similar for the f77_keywords array, except entries in
 869         this list might be case sensitive.
 870
 871 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 872
 873         * f-exp.y (struct f77_boolean_val): Add comments.
 874         (boolean_values): Remove uppercase versions, and end marker.
 875         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
 876         and use strncasecmp to achieve case insensitivity.  Additionally,
 877         perform whitespace cleanup around this code.
 878
 879 2019-03-06  Tom Tromey  <tromey@adacore.com>
 880
 881         * remote-sim.c (gdbsim_target_open): Use result of
 882         gdb_argv::release.
 883
 884 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
 885         Dirk Schubert  <dirk.schubert@arm.com>
 886         Chris January  <chris.january@arm.com>
 887
 888         * eval.c (evaluate_subexp_standard): Call Fortran argument
 889         wrapping logic.
 890         * f-lang.c (struct value): A value which can be passed into a
 891         Fortran function call.
 892         (fortran_argument_convert): Wrap Fortran arguments in a pointer
 893         where appropriate.
 894         (struct type): Value ready for a Fortran function call.
 895         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
 896         is needed.
 897         * f-lang.h (fortran_argument_convert): Declaration.
 898         (fortran_preserve_arg_pointer): Declaration.
 899         * infcall.c (value_arg_coerce): Call Fortran argument logic.
 900
 901 2019-03-05  Tom Tromey  <tromey@adacore.com>
 902
 903         * python/py-prettyprint.c (print_string_repr): Remove #if.
 904         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
 905
 906 2019-03-05  Tom Tromey  <tromey@adacore.com>
 907
 908         * target.c (the_dummy_target): Move later.  Change type to
 909         "dummy_target".
 910         (initialize_targets): Don't initialize the_dummy_target.
 911
 912 2019-03-05  Tom Tromey  <tromey@adacore.com>
 913
 914         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
 915         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
 916
 917 2019-03-05  Tom Tromey  <tromey@adacore.com>
 918
 919         * windows-nat.c (windows_nat_target::attach)
 920         (windows_nat_target::detach): Don't call gdb_flush.
 921         * valprint.c (generic_val_print, val_print, val_print_string):
 922         Don't call gdb_flush.
 923         * utils.c (defaulted_query): Don't call gdb_flush.
 924         * typeprint.c (print_type_scalar): Don't call gdb_flush.
 925         * target.c (target_announce_detach): Don't call gdb_flush.
 926         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
 927         * remote.c (extended_remote_target::attach): Don't call
 928         gdb_flush.
 929         * procfs.c (procfs_target::detach): Don't call gdb_flush.
 930         * printcmd.c (do_examine): Don't call gdb_flush.
 931         (info_display_command): Don't call gdb_flush.
 932         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
 933         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
 934         * memattr.c (info_mem_command): Don't call gdb_flush.
 935         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
 936         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
 937         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
 938         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
 939         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
 940         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
 941         (gnu_nat_target::detach): Don't call gdb_flush.
 942         * f-valprint.c (f_val_print): Don't call gdb_flush.
 943         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
 944         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
 945         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
 946         gdb_flush.
 947         * c-valprint.c (c_val_print): Don't call gdb_flush.
 948         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
 949
 950 2019-03-05  Tom Tromey  <tromey@adacore.com>
 951
 952         * varobj.c (update_dynamic_varobj_children): Update.
 953         (install_default_visualizer): Use reset, not release.
 954         * value.c (set_internalvar): Update.
 955         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
 956         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
 957         ATTRIBUTE_UNUSED_RESULT.
 958
 959 2019-03-05  Tom Tromey  <tromey@adacore.com>
 960
 961         * remote.c (class scoped_remote_fd) <release>: Add
 962         ATTRIBUTE_UNUSED_RESULT.
 963
 964 2019-03-05  Tom Tromey  <tromey@adacore.com>
 965
 966         * macroexp.c (struct macro_buffer) <release>: Add
 967         ATTRIBUTE_UNUSED_RESULT.
 968
 969 2019-03-05  Tom Tromey  <tromey@adacore.com>
 970
 971         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
 972         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
 973         ATTRIBUTE_UNUSED_RESULT.
 974
 975 2019-03-05  Tom Tromey  <tromey@adacore.com>
 976
 977         * common/scoped_fd.h (class scoped_fd) <release>: Add
 978         ATTRIBUTE_UNUSED_RESULT.
 979
 980 2019-03-05  Tom Tromey  <tromey@adacore.com>
 981
 982         * parser-defs.h (struct parser_state) <release>: Add
 983         ATTRIBUTE_UNUSED_RESULT.
 984
 985 2019-03-05  Tom Tromey  <tromey@adacore.com>
 986
 987         * utils.h (class gdb_argv) <release>: Add
 988         ATTRIBUTE_UNUSED_RESULT.
 989         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
 990
 991 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
 992
 993         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
 994         for-loop range, to avoid compiler warnings.
 995
 996         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
 997         avoid compiler warnings about unused variables.
 998
 999         * NEWS: Mention end of support for native debugging on MS-Windows
1000         before XP.
1001
1002         PR gdb/24292
1003         * common/netstuff.c:
1004         * gdbserver/gdbreplay.c
1005         * gdbserver/remote-utils.c:
1006         * ser-tcp.c:
1007         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
1008         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
1009         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
1010         'getaddrinfo' and 'freeaddrinfo' were not available before
1011         Windows XP, and mingw.org's MinGW headers by default define
1012         _WIN32_WINNT to 0x500.
1013
1014 2019-03-01  Gary Benson <gbenson@redhat.com>
1015
1016         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
1017
1018 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
1019             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1020
1021         PR gdb/8527
1022         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
1023         set_sigint_trap, clear_sigint_trap.
1024
1025 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1026
1027         * target.c (target_detach): Clear the regcache and the
1028         frame cache.
1029
1030 2019-02-27  Pedro Alves  <palves@redhat.com>
1031
1032         * utils.c (set_screen_size): When we cap the height/width sizes,
1033         tweak the corresponding command variable to show "unlimited":
1034
1035 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
1036             Pedro Alves  <palves@redhat.com>
1037
1038         * utils.c (set_screen_size): Reduce "infinite" rows and columns
1039         before calling rl_set_screen_size.
1040
1041 2019-02-27  Tom Tromey  <tromey@adacore.com>
1042
1043         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
1044         define.
1045         * python/py-value.c: Remove Python 2.4 workaround.
1046         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
1047         workaround.
1048         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
1049         Python 2.4 workaround.
1050         * python/python-internal.h: Remove Python 2.4 comment.
1051         (Py_ssize_t): Don't define.
1052         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
1053         (gdb_Py_DECREF): Remove Python 2.4 workaround.
1054         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
1055         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
1056         * python/python.c (do_start_initialization): Remove Python 2.4
1057         workaround.
1058         * python/py-prettyprint.c (class dummy_python_frame): Remove.
1059         (print_children): Remove Python 2.4 workaround.
1060         * python/py-inferior.c (buffer_procs): Remove Python 2.4
1061         workaround.
1062         (CHARBUFFERPROC_NAME): Remove.
1063         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
1064         Python 2.4 workaround.
1065
1066 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1067
1068         * NEWS: Note minimum Python version.
1069
1070 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1071
1072         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
1073         code from these functions.  Remove corresponding ifdefs.  Use
1074         Py_buffer_up instead of explicit calls to PyBuffer_Release.
1075         Remove gotos and target of gotos.
1076         (infpy_search_memory): Likewise.
1077
1078 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1079
1080         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
1081         (hppa_gdbarch_init): Don't register deleted functions with
1082         gdbarch.
1083
1084 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1085
1086         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
1087         (h8300_unwind_sp): Delete.
1088         (h8300_dummy_id): Delete.
1089         (h8300_gdbarch_init): Don't register deleted functions with
1090         gdbarch.
1091
1092 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1093
1094         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
1095         (ft32_unwind_pc): Delete.
1096         (ft32_unwind_sp): Delete.
1097         (ft32_gdbarch_init): Don't register deleted functions with
1098         gdbarch.
1099
1100 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1101
1102         * gdb/frv-tdep.c (frv_dummy_id): Delete.
1103         (frv_unwind_pc): Delete.
1104         (frv_unwind_sp): Delete.
1105         (frv_gdbarch_init): Don't register deleted functions with
1106         gdbarch.
1107
1108 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1109
1110         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
1111         (riscv_unwind_pc): Delete.
1112         (riscv_unwind_sp): Delete.
1113         (riscv_gdbarch_init): Don't register deleted functions with
1114         gdbarch.
1115
1116 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1117
1118         * gdb/csky-tdep.c (csky_dummy_id): Delete.
1119         (csky_unwind_pc): Delete.
1120         (csky_unwind_sp): Delete.
1121         (csky_gdbarch_init): Don't register deleted functions with
1122         gdbarch.
1123
1124 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1125
1126         * gdb/cris-tdep.c (cris_dummy_id): Delete.
1127         (cris_unwind_pc): Delete.
1128         (cris_unwind_sp): Delete.
1129         (cris_gdbarch_init): Don't register deleted functions with
1130         gdbarch.
1131
1132 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1133
1134         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
1135         (bfin_unwind_pc): Delete.
1136         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
1137
1138 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1139
1140         * gdb/arm-tdep.c (arm_dummy_id): Delete.
1141         (arm_unwind_pc): Delete.
1142         (arm_unwind_sp): Delete.
1143         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
1144
1145 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1146
1147         * gdb/arc-tdep.c (arc_dummy_id): Delete.
1148         (arc_unwind_pc): Delete.
1149         (arc_unwind_sp): Delete.
1150         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
1151
1152 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1153
1154         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
1155         (alpha_unwind_pc): Delete.
1156         (alpha_gdbarch_init): Don't register deleted functions with
1157         gdbarch.
1158
1159 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1160
1161         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
1162         (aarch64_unwind_pc): Delete.
1163         (aarch64_unwind_sp): Delete.
1164         (aarch64_gdbarch_init): Don't register deleted functions with
1165         gdbarch.
1166
1167 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1168
1169         * gdbtypes.c (type_align): Don't consider static members when
1170         computing structure alignment.
1171
1172 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1173
1174         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
1175         return 0 for other types.
1176         * arch-utils.c (default_type_align): Always return 0.
1177         * gdbarch.h: Regenerate.
1178         * gdbarch.sh (type_align): Extend comment.
1179         * gdbtypes.c (type_align): Add additional comments, always call
1180         gdbarch_type_align before applying the default rules.
1181         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
1182         generic code will then apply a suitable default.
1183         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
1184         types, return 0 for other types.
1185
1186 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1187
1188         * NEWS: Create a new section for the next release branch.
1189         Rename the section of the current branch, now that it has
1190         been cut.
1191
1192 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1193
1194         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
1195         * version.in: Bump version to 8.3.50.DATE-git.
1196
1197 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
1198
1199         * aix-thread.c (ptid_cmp): Remove unused variable.
1200         (get_signaled_thread): Likewise.
1201         (store_regs_user_thread): Likewise.
1202         (store_regs_kernel_thread): Likewise.
1203         (fetch_regs_kernel_thread): Remove shadowed variable.
1204
1205 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1206
1207         * features/riscv/32bit-cpu.xml: Add register numbers.
1208         * features/riscv/32bit-fpu.c: Regenerate.
1209         * features/riscv/32bit-fpu.xml: Add register numbers.
1210         * features/riscv/64bit-cpu.xml: Add register numbers.
1211         * features/riscv/64bit-fpu.c: Regenerate.
1212         * features/riscv/64bit-fpu.xml: Add register numbers.
1213
1214 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
1215
1216         * NEWS: Mention two argument form of gdb.Value constructor.
1217         * python/py-value.c (convert_buffer_and_type_to_value): New
1218         function.
1219         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
1220         Add support for handling an optional second argument.  Call
1221         convert_buffer_and_type_to_value as appropriate.
1222         * python/python-internal.h (Py_buffer_deleter): New struct.
1223         (Py_buffer_up): New typedef.
1224
1225 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
1226
1227         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
1228         instead of releasing ownership.
1229
1230 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
1231
1232         * dwarf2read.c (open_and_init_dwp_file): Call
1233         elf_numsections instead of bfd_count_sections to initialize
1234         dwp_file->num_sections.
1235
1236 2019-02-25  Tom Tromey  <tromey@adacore.com>
1237
1238         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
1239
1240 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1241
1242         * gcore.in: Add '--readnever' option when invoking GDB.
1243
1244 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1245
1246         * MAINTAINERS: Update my email address.
1247
1248 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1249
1250         * build-id.c (build_id_to_debug_bfd_1): New function.
1251         (build_id_to_debug_bfd): Look for separate debug file in
1252         sysroot.
1253
1254 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1255
1256         * gdbarch.sh: Update the copyright year range that is placed into
1257         generated files.
1258
1259 2019-02-22  Keith Seitz  <keiths@redhat.com>
1260
1261         PR symtab/23853
1262         * linespec.c (create_sals_line_offset): Search for the default
1263         symtab's filename instead of its fullname.
1264
1265 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1266
1267         * NEWS: Update style defaults.
1268
1269 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1270
1271         * main.c (captured_main_1): Disable styling in batch mode.
1272
1273 2019-02-20  Tom Tromey  <tom@tromey.com>
1274
1275         * symtab.c (symtab_symbol_info): Fix typos.
1276
1277 2019-02-20  Tom Tromey  <tromey@adacore.com>
1278
1279         * findcmd.c (_initialize_mem_search): Use upper case for
1280         metasyntactic variables.
1281
1282 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
1283
1284         * aarch64-tdep.c (aarch64_add_reggroups): New function.
1285         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
1286
1287 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
1288
1289         * top.h (source_file_name): Change to std::string.
1290         * top.c (source_file_name): Likewise.
1291         (command_line_input): Adjust.
1292         * cli/cli-script.c (script_from_file): Adjust.
1293
1294 2019-02-19  Tom Tromey  <tromey@adacore.com>
1295
1296         * ravenscar-thread.c
1297         (ravenscar_thread_target::update_thread_list): Don't call
1298         ada_build_task_list.
1299         * ada-lang.h (ada_build_task_list): Don't declare.
1300         * ada-tasks.c (struct ada_tasks_inferior_data)
1301         <task_list_valid_p>: Now bool.
1302         (read_known_tasks, ada_task_list_changed)
1303         (ada_tasks_invalidate_inferior_data): Update.
1304         (read_known_tasks_array): Return bool.
1305         (read_known_tasks_list): Likewise.
1306         (read_known_tasks): Return void.
1307         (ada_build_task_list): Now static.
1308
1309 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1310
1311         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
1312         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
1313
1314 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1315
1316         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
1317         variant for ada_tasks_pspace_data_handle and
1318         ada_tasks_inferior_data_handle.
1319         (ada_tasks_pspace_data_cleanup): New function.
1320         (ada_tasks_inferior_data_cleanup): New function.
1321
1322 2019-02-17  Tom Tromey  <tom@tromey.com>
1323
1324         * macrotab.h (macro_source_fullname): Return a std::string.
1325         * macrotab.c (macro_include, check_for_redefinition)
1326         (macro_undef, macro_lookup_definition, foreach_macro)
1327         (foreach_macro_in_scope): Update.
1328         (macro_source_fullname): Return a std::string.
1329         * macrocmd.c (show_pp_source_pos): Update.
1330
1331 2019-02-17  Tom Tromey  <tom@tromey.com>
1332
1333         * macrocmd.c (show_pp_source_pos): Style the file names.
1334
1335 2019-02-17  Tom Tromey  <tom@tromey.com>
1336
1337         PR tui/24197:
1338         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
1339
1340 2019-02-17  Tom Tromey  <tom@tromey.com>
1341
1342         * ada-lang.c (user_select_syms): Use filtered printing.
1343         * utils.c (wrap_style): New global.
1344         (desired_style): Remove.
1345         (emit_style_escape): Add stream parameter.
1346         (set_output_style, reset_terminal_style, prompt_for_continue):
1347         Update.
1348         (flush_wrap_buffer): Only flush gdb_stdout.
1349         (wrap_here): Set wrap_style.
1350         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
1351         treat escape sequences as a character.  Change when wrap buffer is
1352         flushed.
1353         (fputs_styled): Do not set the output style when the default is
1354         requested.
1355         * ui-style.h (struct ui_file_style) <is_default>: New method.
1356         * source.c (print_source_lines_base): Emit escape sequences in one
1357         piece.
1358
1359 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1360
1361         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
1362         integers and enumeration types.
1363
1364 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1365
1366         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
1367         instead of lookup_symbol_in_language
1368         (do_exact_match): New function.
1369         (ada_get_symbol_name_matcher): Return do_exact_match when
1370         doing a verbatim match.
1371
1372 2019-02-15  Tom Tromey  <tromey@adacore.com>
1373
1374         * ravenscar-thread.c (ravenscar_thread_target::resume)
1375         (ravenscar_thread_target::wait): Special case wildcard requests.
1376
1377 2019-02-15  Tom Tromey  <tromey@adacore.com>
1378
1379         * ravenscar-thread.c (base_ptid): Remove.
1380         (struct ravenscar_thread_target) <close>: New method.
1381         <m_base_ptid>: New member.
1382         <update_inferior_ptid, active_task, task_is_currently_active,
1383         runtime_initialized>: Declare methods.
1384         <ravenscar_thread_target>: Add constructor.
1385         (ravenscar_thread_target::task_is_currently_active)
1386         (ravenscar_thread_target::update_inferior_ptid)
1387         (ravenscar_runtime_initialized): Rename.  Now methods.
1388         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
1389         (ravenscar_thread_target::update_thread_list): Update.
1390         (ravenscar_thread_target::active_task): Now method.
1391         (ravenscar_thread_target::store_registers)
1392         (ravenscar_thread_target::prepare_to_store)
1393         (ravenscar_thread_target::prepare_to_store)
1394         (ravenscar_thread_target::mourn_inferior): Update.
1395         (ravenscar_inferior_created): Use "new" to create target.
1396         (ravenscar_thread_target::get_ada_task_ptid): Update.
1397         (_initialize_ravenscar): Don't initialize base_ptid.
1398         (ravenscar_ops): Remove global.
1399
1400 2019-02-15  Tom Tromey  <tromey@adacore.com>
1401
1402         * target.h (push_target): Declare new overload.
1403         * target.c (push_target): New overload, taking an rvalue reference.
1404         * remote.c (remote_target::open_1): Use push_target overload.
1405         * corelow.c (core_target_open): Use push_target overload.
1406
1407 2019-02-15  Tom Tromey  <tromey@adacore.com>
1408
1409         * ravenscar-thread.c (is_ravenscar_task)
1410         (ravenscar_task_is_currently_active): Return bool.
1411         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
1412         (_initialize_ravenscar): Remove "(void)".
1413         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
1414         Return bool.
1415
1416 2019-02-15  Tom Tromey  <tromey@adacore.com>
1417
1418         * ravenscar-thread.c (ravenscar_runtime_initializer)
1419         (has_ravenscar_runtime, get_running_thread_id)
1420         (ravenscar_thread_target::resume): Fix indentation.
1421
1422 2019-02-15  Tom Tromey  <tromey@adacore.com>
1423
1424         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
1425         from ravenscar_arch_ops.
1426         (sparc_ravenscar_ops::fetch_registers)
1427         (sparc_ravenscar_ops::store_registers): Now methods.
1428         (sparc_ravenscar_prepare_to_store): Remove.
1429         (sparc_ravenscar_ops): Redefine.
1430         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
1431         methods and destructor.  Remove members.
1432         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
1433         (ravenscar_thread_target::store_registers)
1434         (ravenscar_thread_target::prepare_to_store): Update.
1435         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
1436         Remove.
1437         (struct ppc_ravenscar_powerpc_ops): Derive from
1438         ravenscar_arch_ops.
1439         (ppc_ravenscar_powerpc_ops::fetch_registers)
1440         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
1441         (ppc_ravenscar_powerpc_ops): Redefine.
1442         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
1443         (ppc_ravenscar_e500_ops::fetch_registers)
1444         (ppc_ravenscar_e500_ops::store_registers): Now methods.
1445         (ppc_ravenscar_e500_ops): Redefine.
1446         * aarch64-ravenscar-thread.c
1447         (aarch64_ravenscar_generic_prepare_to_store): Remove.
1448         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
1449         (aarch64_ravenscar_fetch_registers)
1450         (aarch64_ravenscar_store_registers): Now methods.
1451         (aarch64_ravenscar_ops): Redefine.
1452
1453 2019-02-15  Tom Tromey  <tromey@adacore.com>
1454
1455         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
1456         (ravenscar_thread_target::stopped_by_hw_breakpoint)
1457         (ravenscar_thread_target::stopped_by_watchpoint)
1458         (ravenscar_thread_target::stopped_data_address)
1459         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
1460
1461 2019-02-15  Tom Tromey  <tromey@adacore.com>
1462
1463         * ravenscar-thread.c: Fix some typos.
1464
1465 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1466             Tom Tromey  <tromey@adacore.com>
1467
1468         * ada-lang.c (ada_exception_sal): Change addr_string to a
1469         std::string.
1470         (create_ada_exception_catchpoint): Update.
1471
1472 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1473             Tom Tromey  <tromey@adacore.com>
1474
1475         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
1476         (bp_location_ops): Remove.
1477         (base_breakpoint_allocate_location): Update.
1478         (free_bp_location): Update.
1479         * ada-lang.c (class ada_catchpoint_location)
1480         <ada_catchpoint_location>: Remove ops parameter.
1481         (ada_catchpoint_location_dtor): Remove.
1482         (ada_catchpoint_location_ops): Remove.
1483         (allocate_location_exception): Update.
1484         * breakpoint.h (struct bp_location_ops): Remove.
1485         (class bp_location) <bp_location>: Remove bp_location_ops
1486         parameter.
1487         <~bp_location>: Add destructor.
1488         <ops>: Remove.
1489
1490 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1491             Pedro Alves  <palves@redhat.com>
1492
1493         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
1494         'PATH_MAX'.
1495
1496 2019-02-14  David Michael  <fedora.dm0@gmail.com>
1497             Samuel Thibault  <samuel.thibault@gnu.org>
1498             Thomas Schwinge  <thomas@codesourcery.com>
1499
1500         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
1501         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
1502
1503 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1504
1505         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
1506         (check_empty): Use "const char *".
1507
1508         * gnu-nat.c (gnu_nat_target::detach): Instead of
1509         'detach_inferior (pid)' call
1510         'detach_inferior (find_inferior_pid (pid))'.
1511
1512         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
1513         'nat/fork-inferior.o'.
1514         * gnu-nat.c: #include "nat/fork-inferior.h".
1515
1516         * gnu-nat.c (gnu_nat_target::detach): Instead of
1517         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
1518         * gnu-nat.h: #include "inf-child.h".
1519         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
1520         'i386_gnu_nat_target::fetch_registers'.
1521         (gnu_store_registers): Rename/move to
1522         'i386_gnu_nat_target::store_registers'.
1523
1524         * config/i386/nm-i386gnu.h: Don't "#include" any files.
1525         * gnu-nat.h (mach_thread_info): New function.
1526         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
1527
1528         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
1529
1530 2019-02-14  Frederic Konrad  <konrad@adacore.com>
1531
1532         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
1533
1534 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
1535
1536         * windows-nat.c (windows_add_thread): Add new parameter
1537         "main_thread_p" with default value set to false.  Update
1538         function documentation as well as all callers.
1539         (windows_delete_thread): Likewise.
1540         (fake_create_process): Update call to windows_add_thread.
1541         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
1542         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
1543         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
1544         call to windows_delete_thread.
1545
1546 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
1547
1548         * MAINTAINERS: Add Andrew Burgess as global maintainer.
1549
1550 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1551
1552         * symfile.c (find_separate_debug_file): Use canonical path of
1553         sysroot with child_path instead of gdb_sysroot if it is valid.
1554
1555 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1556
1557         * symfile.c (find_separate_debug_file): Use child_path to
1558         determine if an object file is under a sysroot.
1559
1560 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1561
1562         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1563         unittests/child-path-selftests.c.
1564         * common/pathstuff.c (child_path): New function.
1565         * common/pathstuff.h (child_path): New prototype.
1566         * unittests/child-path-selftests.c: New file.
1567
1568 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1569
1570         * symfile.c (find_separate_debug_file): Look for separate debug
1571         files in debug directories under the sysroot.
1572
1573 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1574
1575         * symtab.h (struct minimal_symbol data_p): New const method.
1576         (struct minimal_symbol text_p): Likewise.
1577         * symtab.c (output_source_filename): Use file name style
1578         to print file name.
1579         (print_symbol_info): Likewise.
1580         (print_msymbol_info): Use address style to print addresses.
1581         Use function name style to print executable text symbols.
1582         (expand_symtab_containing_pc): Use data_p.
1583         (find_pc_sect_compunit_symtab): Likewise.
1584
1585 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1586
1587         * breakpoint.c (describe_other_breakpoints): Use address style
1588         to print addresses.
1589         (say_where): Likewise.
1590
1591 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1592
1593         * ada-typeprint.c (print_func_type): Print function name
1594         style to print function name.
1595         * c-typeprint.c (c_print_type_1): Likewise.
1596
1597 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
1598
1599         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
1600         for execve.
1601
1602 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1603
1604         * c-exp.y (direct_abs_decl): Use emplace_back to record the
1605         type_stack.
1606
1607 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
1608
1609         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
1610         TYPE_CODE_REF types.
1611
1612 2019-02-08  Jim Wilson  <jimw@sifive.com>
1613
1614         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
1615         (riscv_linux_fregset): New.
1616         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
1617
1618 2019-02-07  Tom Tromey  <tom@tromey.com>
1619
1620         * thread.c (thread_cancel_execution_command): Update.
1621         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
1622         methods.
1623         (struct thread_fsm_ops): Remove.
1624         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
1625         (thread_fsm_should_stop, thread_fsm_return_value)
1626         (thread_fsm_set_finished, thread_fsm_finished_p)
1627         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
1628         Don't declare.
1629         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
1630         * infrun.c (clear_proceed_status_thread)
1631         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
1632         (print_stop_event): Update.
1633         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
1634         Add constructor.
1635         (step_command_fsm_ops): Remove.
1636         (new_step_command_fsm): Remove.
1637         (step_1): Update.
1638         (step_command_fsm::should_stop): Rename from
1639         step_command_fsm_should_stop.
1640         (step_command_fsm::clean_up): Rename from
1641         step_command_fsm_clean_up.
1642         (step_command_fsm::do_async_reply_reason): Rename from
1643         step_command_fsm_async_reply_reason.
1644         (struct until_next_fsm): Inherit from thread_fsm.  Add
1645         constructor.
1646         (until_next_fsm_ops): Remove.
1647         (new_until_next_fsm): Remove.
1648         (until_next_fsm::should_stop): Rename from
1649         until_next_fsm_should_stop.
1650         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
1651         (until_next_fsm::do_async_reply_reason): Rename from
1652         until_next_fsm_async_reply_reason.
1653         (struct finish_command_fsm): Inherit from thread_fsm.  Add
1654         constructor.  Change type of breakpoint.
1655         (finish_command_fsm_ops): Remove.
1656         (new_finish_command_fsm): Remove.
1657         (finish_command_fsm::should_stop): Rename from
1658         finish_command_fsm_should_stop.
1659         (finish_command_fsm::clean_up): Rename from
1660         finish_command_fsm_clean_up.
1661         (finish_command_fsm::return_value): Rename from
1662         finish_command_fsm_return_value.
1663         (finish_command_fsm::do_async_reply_reason): Rename from
1664         finish_command_fsm_async_reply_reason.
1665         (finish_command): Update.
1666         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
1667         Add constructor.
1668         (call_thread_fsm_ops): Remove.
1669         (call_thread_fsm::call_thread_fsm): Rename from
1670         new_call_thread_fsm.
1671         (call_thread_fsm::should_stop): Rename from
1672         call_thread_fsm_should_stop.
1673         (call_thread_fsm::should_notify_stop): Rename from
1674         call_thread_fsm_should_notify_stop.
1675         (run_inferior_call, call_function_by_hand_dummy): Update.
1676         * cli/cli-interp.c (should_print_stop_to_console): Update.
1677         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
1678         Add constructor.  Change type of location_breakpoint,
1679         caller_breakpoint.
1680         (until_break_fsm_ops): Remove.
1681         (new_until_break_fsm): Remove.
1682         (until_break_fsm::should_stop): Rename from
1683         until_break_fsm_should_stop.
1684         (until_break_fsm::clean_up): Rename from
1685         until_break_fsm_clean_up.
1686         (until_break_fsm::do_async_reply_reason): Rename from
1687         until_break_fsm_async_reply_reason.
1688         (until_break_command): Update.
1689         * thread-fsm.c: Remove.
1690         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
1691
1692 2019-02-07  Tom Tromey  <tom@tromey.com>
1693
1694         * yy-remap.h: Add include guard.
1695         * xtensa-tdep.h: Add include guard.
1696         * xcoffread.h: Rename include guard.
1697         * varobj-iter.h: Add include guard.
1698         * tui/tui.h: Rename include guard.
1699         * tui/tui-winsource.h: Rename include guard.
1700         * tui/tui-wingeneral.h: Rename include guard.
1701         * tui/tui-windata.h: Rename include guard.
1702         * tui/tui-win.h: Rename include guard.
1703         * tui/tui-stack.h: Rename include guard.
1704         * tui/tui-source.h: Rename include guard.
1705         * tui/tui-regs.h: Rename include guard.
1706         * tui/tui-out.h: Rename include guard.
1707         * tui/tui-layout.h: Rename include guard.
1708         * tui/tui-io.h: Rename include guard.
1709         * tui/tui-hooks.h: Rename include guard.
1710         * tui/tui-file.h: Rename include guard.
1711         * tui/tui-disasm.h: Rename include guard.
1712         * tui/tui-data.h: Rename include guard.
1713         * tui/tui-command.h: Rename include guard.
1714         * tic6x-tdep.h: Add include guard.
1715         * target/waitstatus.h: Rename include guard.
1716         * target/wait.h: Rename include guard.
1717         * target/target.h: Rename include guard.
1718         * target/resume.h: Rename include guard.
1719         * target-float.h: Rename include guard.
1720         * stabsread.h: Add include guard.
1721         * rs6000-tdep.h: Add include guard.
1722         * riscv-fbsd-tdep.h: Add include guard.
1723         * regformats/regdef.h: Rename include guard.
1724         * record.h: Rename include guard.
1725         * python/python.h: Rename include guard.
1726         * python/python-internal.h: Rename include guard.
1727         * python/py-stopevent.h: Rename include guard.
1728         * python/py-ref.h: Rename include guard.
1729         * python/py-record.h: Rename include guard.
1730         * python/py-record-full.h: Rename include guard.
1731         * python/py-record-btrace.h: Rename include guard.
1732         * python/py-instruction.h: Rename include guard.
1733         * python/py-events.h: Rename include guard.
1734         * python/py-event.h: Rename include guard.
1735         * procfs.h: Add include guard.
1736         * proc-utils.h: Add include guard.
1737         * p-lang.h: Add include guard.
1738         * or1k-tdep.h: Rename include guard.
1739         * observable.h: Rename include guard.
1740         * nto-tdep.h: Rename include guard.
1741         * nat/x86-linux.h: Rename include guard.
1742         * nat/x86-linux-dregs.h: Rename include guard.
1743         * nat/x86-gcc-cpuid.h: Add include guard.
1744         * nat/x86-dregs.h: Rename include guard.
1745         * nat/x86-cpuid.h: Rename include guard.
1746         * nat/ppc-linux.h: Rename include guard.
1747         * nat/mips-linux-watch.h: Rename include guard.
1748         * nat/linux-waitpid.h: Rename include guard.
1749         * nat/linux-ptrace.h: Rename include guard.
1750         * nat/linux-procfs.h: Rename include guard.
1751         * nat/linux-osdata.h: Rename include guard.
1752         * nat/linux-nat.h: Rename include guard.
1753         * nat/linux-namespaces.h: Rename include guard.
1754         * nat/linux-btrace.h: Rename include guard.
1755         * nat/glibc_thread_db.h: Rename include guard.
1756         * nat/gdb_thread_db.h: Rename include guard.
1757         * nat/gdb_ptrace.h: Rename include guard.
1758         * nat/fork-inferior.h: Rename include guard.
1759         * nat/amd64-linux-siginfo.h: Rename include guard.
1760         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
1761         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
1762         * nat/aarch64-linux.h: Rename include guard.
1763         * nat/aarch64-linux-hw-point.h: Rename include guard.
1764         * mn10300-tdep.h: Add include guard.
1765         * mips-linux-tdep.h: Add include guard.
1766         * mi/mi-parse.h: Rename include guard.
1767         * mi/mi-out.h: Rename include guard.
1768         * mi/mi-main.h: Rename include guard.
1769         * mi/mi-interp.h: Rename include guard.
1770         * mi/mi-getopt.h: Rename include guard.
1771         * mi/mi-console.h: Rename include guard.
1772         * mi/mi-common.h: Rename include guard.
1773         * mi/mi-cmds.h: Rename include guard.
1774         * mi/mi-cmd-break.h: Rename include guard.
1775         * m2-lang.h: Add include guard.
1776         * location.h: Rename include guard.
1777         * linux-record.h: Rename include guard.
1778         * linux-nat.h: Add include guard.
1779         * linux-fork.h: Add include guard.
1780         * i386-darwin-tdep.h: Rename include guard.
1781         * hppa-linux-offsets.h: Add include guard.
1782         * guile/guile.h: Rename include guard.
1783         * guile/guile-internal.h: Rename include guard.
1784         * gnu-nat.h: Rename include guard.
1785         * gdb-stabs.h: Rename include guard.
1786         * frv-tdep.h: Add include guard.
1787         * f-lang.h: Add include guard.
1788         * event-loop.h: Add include guard.
1789         * darwin-nat.h: Rename include guard.
1790         * cp-abi.h: Rename include guard.
1791         * config/sparc/nm-sol2.h: Rename include guard.
1792         * config/nm-nto.h: Rename include guard.
1793         * config/nm-linux.h: Add include guard.
1794         * config/i386/nm-i386gnu.h: Rename include guard.
1795         * config/djgpp/nl_types.h: Rename include guard.
1796         * config/djgpp/langinfo.h: Rename include guard.
1797         * compile/gcc-cp-plugin.h: Add include guard.
1798         * compile/gcc-c-plugin.h: Add include guard.
1799         * compile/compile.h: Rename include guard.
1800         * compile/compile-object-run.h: Rename include guard.
1801         * compile/compile-object-load.h: Rename include guard.
1802         * compile/compile-internal.h: Rename include guard.
1803         * compile/compile-cplus.h: Rename include guard.
1804         * compile/compile-c.h: Rename include guard.
1805         * common/xml-utils.h: Rename include guard.
1806         * common/x86-xstate.h: Rename include guard.
1807         * common/version.h: Rename include guard.
1808         * common/vec.h: Rename include guard.
1809         * common/tdesc.h: Rename include guard.
1810         * common/selftest.h: Rename include guard.
1811         * common/scoped_restore.h: Rename include guard.
1812         * common/scoped_mmap.h: Rename include guard.
1813         * common/scoped_fd.h: Rename include guard.
1814         * common/safe-iterator.h: Rename include guard.
1815         * common/run-time-clock.h: Rename include guard.
1816         * common/refcounted-object.h: Rename include guard.
1817         * common/queue.h: Rename include guard.
1818         * common/ptid.h: Rename include guard.
1819         * common/print-utils.h: Rename include guard.
1820         * common/preprocessor.h: Rename include guard.
1821         * common/pathstuff.h: Rename include guard.
1822         * common/observable.h: Rename include guard.
1823         * common/netstuff.h: Rename include guard.
1824         * common/job-control.h: Rename include guard.
1825         * common/host-defs.h: Rename include guard.
1826         * common/gdb_wait.h: Rename include guard.
1827         * common/gdb_vecs.h: Rename include guard.
1828         * common/gdb_unlinker.h: Rename include guard.
1829         * common/gdb_unique_ptr.h: Rename include guard.
1830         * common/gdb_tilde_expand.h: Rename include guard.
1831         * common/gdb_sys_time.h: Rename include guard.
1832         * common/gdb_string_view.h: Rename include guard.
1833         * common/gdb_splay_tree.h: Rename include guard.
1834         * common/gdb_setjmp.h: Rename include guard.
1835         * common/gdb_ref_ptr.h: Rename include guard.
1836         * common/gdb_optional.h: Rename include guard.
1837         * common/gdb_locale.h: Rename include guard.
1838         * common/gdb_assert.h: Rename include guard.
1839         * common/filtered-iterator.h: Rename include guard.
1840         * common/filestuff.h: Rename include guard.
1841         * common/fileio.h: Rename include guard.
1842         * common/environ.h: Rename include guard.
1843         * common/common-utils.h: Rename include guard.
1844         * common/common-types.h: Rename include guard.
1845         * common/common-regcache.h: Rename include guard.
1846         * common/common-inferior.h: Rename include guard.
1847         * common/common-gdbthread.h: Rename include guard.
1848         * common/common-exceptions.h: Rename include guard.
1849         * common/common-defs.h: Rename include guard.
1850         * common/common-debug.h: Rename include guard.
1851         * common/cleanups.h: Rename include guard.
1852         * common/buffer.h: Rename include guard.
1853         * common/btrace-common.h: Rename include guard.
1854         * common/break-common.h: Rename include guard.
1855         * cli/cli-utils.h: Rename include guard.
1856         * cli/cli-style.h: Rename include guard.
1857         * cli/cli-setshow.h: Rename include guard.
1858         * cli/cli-script.h: Rename include guard.
1859         * cli/cli-interp.h: Rename include guard.
1860         * cli/cli-decode.h: Rename include guard.
1861         * cli/cli-cmds.h: Rename include guard.
1862         * charset-list.h: Add include guard.
1863         * buildsym-legacy.h: Rename include guard.
1864         * bfin-tdep.h: Add include guard.
1865         * ax.h: Rename include guard.
1866         * arm-linux-tdep.h: Add include guard.
1867         * arm-fbsd-tdep.h: Add include guard.
1868         * arch/xtensa.h: Rename include guard.
1869         * arch/tic6x.h: Add include guard.
1870         * arch/i386.h: Add include guard.
1871         * arch/arm.h: Rename include guard.
1872         * arch/arm-linux.h: Rename include guard.
1873         * arch/arm-get-next-pcs.h: Rename include guard.
1874         * arch/amd64.h: Add include guard.
1875         * arch/aarch64-insn.h: Rename include guard.
1876         * arch-utils.h: Rename include guard.
1877         * annotate.h: Add include guard.
1878         * amd64-darwin-tdep.h: Rename include guard.
1879         * aarch64-linux-tdep.h: Add include guard.
1880         * aarch64-fbsd-tdep.h: Add include guard.
1881         * aarch32-linux-nat.h: Add include guard.
1882
1883 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1884
1885         * macrotab.c (macro_define_internal): New function that
1886         factorizes macro_define_object_internal and macro_define_function
1887         code.
1888         (macro_define_object_internal): Use macro_define_internal.
1889         (macro_define_function): Likewise.
1890
1891 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1892
1893         * macrocmd.c (extract_identifier): Return
1894         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
1895         callers.
1896
1897 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
1898
1899         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
1900
1901 2019-02-05  Tom Tromey  <tom@tromey.com>
1902
1903         * target.c (target_stack::unpush): Move assertion earlier.
1904
1905 2019-01-30  Tom Tromey  <tom@tromey.com>
1906
1907         PR python/23615:
1908         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
1909         (gdbpy_parse_and_eval): Likewise.
1910         * python/python-internal.h (gdbpy_allow_threads): New class.
1911
1912 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
1913
1914         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
1915         (aarch64_fbsd_fpregmap): Move earlier.
1916         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
1917         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1918         instead of individual calls to trad_frame_set_reg_addr.
1919         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
1920         earlier.
1921         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
1922         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1923         instead of individual calls to trad_frame_set_reg_addr.
1924
1925 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
1926
1927         * CONTRIBUTE: Replace contribution list with wiki link.
1928
1929 2019-01-25  Tom Tromey  <tom@tromey.com>
1930
1931         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
1932
1933 2019-01-25  Tom Tromey  <tom@tromey.com>
1934
1935         * xtensa-linux-nat.c: Fix common/ includes.
1936         * xml-support.h: Fix common/ includes.
1937         * xml-support.c: Fix common/ includes.
1938         * x86-linux-nat.c: Fix common/ includes.
1939         * windows-nat.c: Fix common/ includes.
1940         * varobj.h: Fix common/ includes.
1941         * varobj.c: Fix common/ includes.
1942         * value.c: Fix common/ includes.
1943         * valops.c: Fix common/ includes.
1944         * utils.c: Fix common/ includes.
1945         * unittests/xml-utils-selftests.c: Fix common/ includes.
1946         * unittests/utils-selftests.c: Fix common/ includes.
1947         * unittests/unpack-selftests.c: Fix common/ includes.
1948         * unittests/tracepoint-selftests.c: Fix common/ includes.
1949         * unittests/style-selftests.c: Fix common/ includes.
1950         * unittests/string_view-selftests.c: Fix common/ includes.
1951         * unittests/scoped_restore-selftests.c: Fix common/ includes.
1952         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
1953         * unittests/scoped_fd-selftests.c: Fix common/ includes.
1954         * unittests/rsp-low-selftests.c: Fix common/ includes.
1955         * unittests/parse-connection-spec-selftests.c: Fix common/
1956         includes.
1957         * unittests/optional-selftests.c: Fix common/ includes.
1958         * unittests/offset-type-selftests.c: Fix common/ includes.
1959         * unittests/observable-selftests.c: Fix common/ includes.
1960         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
1961         * unittests/memrange-selftests.c: Fix common/ includes.
1962         * unittests/memory-map-selftests.c: Fix common/ includes.
1963         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
1964         * unittests/function-view-selftests.c: Fix common/ includes.
1965         * unittests/environ-selftests.c: Fix common/ includes.
1966         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
1967         * unittests/common-utils-selftests.c: Fix common/ includes.
1968         * unittests/cli-utils-selftests.c: Fix common/ includes.
1969         * unittests/array-view-selftests.c: Fix common/ includes.
1970         * ui-file.c: Fix common/ includes.
1971         * tui/tui-io.c: Fix common/ includes.
1972         * tracepoint.h: Fix common/ includes.
1973         * tracepoint.c: Fix common/ includes.
1974         * tracefile-tfile.c: Fix common/ includes.
1975         * top.h: Fix common/ includes.
1976         * top.c: Fix common/ includes.
1977         * thread.c: Fix common/ includes.
1978         * target/waitstatus.h: Fix common/ includes.
1979         * target/waitstatus.c: Fix common/ includes.
1980         * target.h: Fix common/ includes.
1981         * target.c: Fix common/ includes.
1982         * target-memory.c: Fix common/ includes.
1983         * target-descriptions.c: Fix common/ includes.
1984         * symtab.h: Fix common/ includes.
1985         * symfile.c: Fix common/ includes.
1986         * stap-probe.c: Fix common/ includes.
1987         * spu-linux-nat.c: Fix common/ includes.
1988         * sparc-nat.c: Fix common/ includes.
1989         * source.c: Fix common/ includes.
1990         * solib.c: Fix common/ includes.
1991         * solib-target.c: Fix common/ includes.
1992         * ser-unix.c: Fix common/ includes.
1993         * ser-tcp.c: Fix common/ includes.
1994         * ser-pipe.c: Fix common/ includes.
1995         * ser-base.c: Fix common/ includes.
1996         * selftest-arch.c: Fix common/ includes.
1997         * s12z-tdep.c: Fix common/ includes.
1998         * rust-exp.y: Fix common/ includes.
1999         * rs6000-aix-tdep.c: Fix common/ includes.
2000         * riscv-tdep.c: Fix common/ includes.
2001         * remote.c: Fix common/ includes.
2002         * remote-notif.h: Fix common/ includes.
2003         * remote-fileio.h: Fix common/ includes.
2004         * remote-fileio.c: Fix common/ includes.
2005         * regcache.h: Fix common/ includes.
2006         * regcache.c: Fix common/ includes.
2007         * record-btrace.c: Fix common/ includes.
2008         * python/python.c: Fix common/ includes.
2009         * python/py-type.c: Fix common/ includes.
2010         * python/py-inferior.c: Fix common/ includes.
2011         * progspace.h: Fix common/ includes.
2012         * producer.c: Fix common/ includes.
2013         * procfs.c: Fix common/ includes.
2014         * proc-api.c: Fix common/ includes.
2015         * printcmd.c: Fix common/ includes.
2016         * ppc-linux-nat.c: Fix common/ includes.
2017         * parser-defs.h: Fix common/ includes.
2018         * osdata.c: Fix common/ includes.
2019         * obsd-nat.c: Fix common/ includes.
2020         * nat/x86-linux.c: Fix common/ includes.
2021         * nat/x86-linux-dregs.c: Fix common/ includes.
2022         * nat/x86-dregs.h: Fix common/ includes.
2023         * nat/x86-dregs.c: Fix common/ includes.
2024         * nat/ppc-linux.c: Fix common/ includes.
2025         * nat/mips-linux-watch.h: Fix common/ includes.
2026         * nat/mips-linux-watch.c: Fix common/ includes.
2027         * nat/linux-waitpid.c: Fix common/ includes.
2028         * nat/linux-ptrace.h: Fix common/ includes.
2029         * nat/linux-ptrace.c: Fix common/ includes.
2030         * nat/linux-procfs.c: Fix common/ includes.
2031         * nat/linux-personality.c: Fix common/ includes.
2032         * nat/linux-osdata.c: Fix common/ includes.
2033         * nat/linux-namespaces.c: Fix common/ includes.
2034         * nat/linux-btrace.h: Fix common/ includes.
2035         * nat/linux-btrace.c: Fix common/ includes.
2036         * nat/fork-inferior.c: Fix common/ includes.
2037         * nat/amd64-linux-siginfo.c: Fix common/ includes.
2038         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
2039         * nat/aarch64-linux.c: Fix common/ includes.
2040         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
2041         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
2042         * namespace.h: Fix common/ includes.
2043         * mips-linux-tdep.c: Fix common/ includes.
2044         * minsyms.c: Fix common/ includes.
2045         * mi/mi-parse.h: Fix common/ includes.
2046         * mi/mi-main.c: Fix common/ includes.
2047         * mi/mi-cmd-env.c: Fix common/ includes.
2048         * memrange.h: Fix common/ includes.
2049         * memattr.c: Fix common/ includes.
2050         * maint.h: Fix common/ includes.
2051         * maint.c: Fix common/ includes.
2052         * main.c: Fix common/ includes.
2053         * machoread.c: Fix common/ includes.
2054         * location.c: Fix common/ includes.
2055         * linux-thread-db.c: Fix common/ includes.
2056         * linux-nat.c: Fix common/ includes.
2057         * linux-fork.c: Fix common/ includes.
2058         * inline-frame.c: Fix common/ includes.
2059         * infrun.c: Fix common/ includes.
2060         * inflow.c: Fix common/ includes.
2061         * inferior.h: Fix common/ includes.
2062         * inferior.c: Fix common/ includes.
2063         * infcmd.c: Fix common/ includes.
2064         * inf-ptrace.c: Fix common/ includes.
2065         * inf-child.c: Fix common/ includes.
2066         * ia64-linux-nat.c: Fix common/ includes.
2067         * i387-tdep.c: Fix common/ includes.
2068         * i386-tdep.c: Fix common/ includes.
2069         * i386-linux-tdep.c: Fix common/ includes.
2070         * i386-linux-nat.c: Fix common/ includes.
2071         * i386-go32-tdep.c: Fix common/ includes.
2072         * i386-fbsd-tdep.c: Fix common/ includes.
2073         * i386-fbsd-nat.c: Fix common/ includes.
2074         * guile/scm-type.c: Fix common/ includes.
2075         * guile/guile.c: Fix common/ includes.
2076         * go32-nat.c: Fix common/ includes.
2077         * gnu-nat.c: Fix common/ includes.
2078         * gdbthread.h: Fix common/ includes.
2079         * gdbarch-selftests.c: Fix common/ includes.
2080         * gdb_usleep.c: Fix common/ includes.
2081         * gdb_select.h: Fix common/ includes.
2082         * gdb_bfd.c: Fix common/ includes.
2083         * gcore.c: Fix common/ includes.
2084         * fork-child.c: Fix common/ includes.
2085         * findvar.c: Fix common/ includes.
2086         * fbsd-nat.c: Fix common/ includes.
2087         * event-top.c: Fix common/ includes.
2088         * event-loop.c: Fix common/ includes.
2089         * dwarf2read.c: Fix common/ includes.
2090         * dwarf2loc.c: Fix common/ includes.
2091         * dwarf2-frame.c: Fix common/ includes.
2092         * dwarf-index-cache.c: Fix common/ includes.
2093         * dtrace-probe.c: Fix common/ includes.
2094         * disasm-selftests.c: Fix common/ includes.
2095         * defs.h: Fix common/ includes.
2096         * csky-tdep.c: Fix common/ includes.
2097         * cp-valprint.c: Fix common/ includes.
2098         * cp-support.h: Fix common/ includes.
2099         * cp-support.c: Fix common/ includes.
2100         * corelow.c: Fix common/ includes.
2101         * completer.h: Fix common/ includes.
2102         * completer.c: Fix common/ includes.
2103         * compile/compile.c: Fix common/ includes.
2104         * compile/compile-loc2c.c: Fix common/ includes.
2105         * compile/compile-cplus-types.c: Fix common/ includes.
2106         * compile/compile-cplus-symbols.c: Fix common/ includes.
2107         * command.h: Fix common/ includes.
2108         * cli/cli-dump.c: Fix common/ includes.
2109         * cli/cli-cmds.c: Fix common/ includes.
2110         * charset.c: Fix common/ includes.
2111         * build-id.c: Fix common/ includes.
2112         * btrace.h: Fix common/ includes.
2113         * btrace.c: Fix common/ includes.
2114         * breakpoint.h: Fix common/ includes.
2115         * breakpoint.c: Fix common/ includes.
2116         * ax.h:
2117         (enum agent_op): Fix common/ includes.
2118         * ax-general.c (struct aop_map): Fix common/ includes.
2119         * ax-gdb.c: Fix common/ includes.
2120         * auxv.c: Fix common/ includes.
2121         * auto-load.c: Fix common/ includes.
2122         * arm-tdep.c: Fix common/ includes.
2123         * arch/riscv.c: Fix common/ includes.
2124         * arch/ppc-linux-common.c: Fix common/ includes.
2125         * arch/i386.c: Fix common/ includes.
2126         * arch/arm.c: Fix common/ includes.
2127         * arch/arm-linux.c: Fix common/ includes.
2128         * arch/arm-get-next-pcs.c: Fix common/ includes.
2129         * arch/amd64.c: Fix common/ includes.
2130         * arch/aarch64.c: Fix common/ includes.
2131         * arch/aarch64-insn.c: Fix common/ includes.
2132         * arch-utils.c: Fix common/ includes.
2133         * amd64-windows-tdep.c: Fix common/ includes.
2134         * amd64-tdep.c: Fix common/ includes.
2135         * amd64-sol2-tdep.c: Fix common/ includes.
2136         * amd64-obsd-tdep.c: Fix common/ includes.
2137         * amd64-nbsd-tdep.c: Fix common/ includes.
2138         * amd64-linux-tdep.c: Fix common/ includes.
2139         * amd64-linux-nat.c: Fix common/ includes.
2140         * amd64-fbsd-tdep.c: Fix common/ includes.
2141         * amd64-fbsd-nat.c: Fix common/ includes.
2142         * amd64-dicos-tdep.c: Fix common/ includes.
2143         * amd64-darwin-tdep.c: Fix common/ includes.
2144         * agent.c: Fix common/ includes.
2145         * ada-lang.h: Fix common/ includes.
2146         * ada-lang.c: Fix common/ includes.
2147         * aarch64-tdep.c: Fix common/ includes.
2148
2149 2019-01-25  Tom Tromey  <tom@tromey.com>
2150
2151         * common/create-version.sh: Use common/version.h.
2152
2153 2019-01-24  Pedro Alves  <palves@redhat.com>
2154
2155         * infrun.c (signal_stop, signal_print, signal_program)
2156         (signal_catch, signal_pass): Now arrays instead of pointers.
2157         (update_signals_program_target, do_target_resume)
2158         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
2159         * linux-nat.c (linux_nat_target::pass_signals)
2160         (linux_nat_target::create_inferior, linux_nat_target::attach):
2161         Adjust.
2162         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
2163         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
2164         * procfs.c (procfs_target::pass_signals): Adjust.
2165         * record-full.c (record_full_target::resume): Adjust.
2166         * remote.c (remote_target::pass_signals)
2167         (remote_target::program_signals): Adjust.
2168         * target-debug.h (target_debug_print_signals): Now takes a
2169         gdb::array_view as parameter.  Adjust.
2170         * target.h (target_ops) <pass_signals, program_signals>: Replace
2171         pointer and length parameters with gdb::array_view.
2172         (target_pass_signals, target_program_signals): Likewise.
2173         * target-delegates.c: Regenerate.
2174
2175 2019-01-24  Pedro Alves  <palves@redhat.com>
2176
2177         * common/forward-scope-exit.h
2178         (forward_scope_exit::forward_scope_exit): Pass arguments to
2179         m_bind_function directly, instead of creating a std::bind and
2180         copying that.
2181
2182 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
2183
2184         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2185         for static members.
2186         (pass_in_v_vfp_candidate): Likewise.
2187
2188 2019-01-23  Tom Tromey  <tom@tromey.com>
2189             Pedro Alves  <palves@redhat.com>
2190
2191         * regcache.c (class regcache_invalidator): Remove.
2192         (regcache::raw_write): Use make_scope_exit.
2193
2194 2019-01-23  Tom Tromey  <tom@tromey.com>
2195
2196         * ui-out.h (class ui_out_emit_type): Update comment.
2197
2198 2019-01-23  Tom Tromey  <tom@tromey.com>
2199
2200         * infrun.c (fetch_inferior_event): Update comment.
2201
2202 2019-01-23  Tom Tromey  <tom@tromey.com>
2203             Pedro Alves  <palves@redhat.com>
2204
2205         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
2206         parameter.
2207         (fetch_inferior_event): Use SCOPE_EXIT.
2208
2209
2210 2019-01-23  Tom Tromey  <tom@tromey.com>
2211             Pedro Alves  <palves@redhat.com>
2212
2213         * infrun.c (disable_thread_events): Delete.
2214         (stop_all_threads): Use SCOPE_EXIT.
2215
2216 2019-01-23  Tom Tromey  <tom@tromey.com>
2217             Pedro Alves  <palves@redhat.com>
2218
2219         * symfile.c: Include forward-scope-exit.h.
2220         (clear_symtab_users_cleanup): Replace forward declaration with
2221         a FORWARD_SCOPE_EXIT.
2222         (syms_from_objfile_1): Use the forward_scope_exit and
2223         gdb::optional instead of cleanup_function.
2224         (reread_symbols): Use the forward_scope_exit instead of
2225         cleanup_function.
2226         (clear_symtab_users_cleanup): Remove function.
2227
2228 2019-01-23  Tom Tromey  <tom@tromey.com>
2229             Pedro Alves  <palves@redhat.com>
2230
2231         * linux-nat.c: Include scope-exit.h.
2232         (cleanup_target_stop): Remove.
2233         (linux_nat_target::static_tracepoint_markers_by_strid): Use
2234         SCOPE_EXIT.
2235
2236 2019-01-23  Tom Tromey  <tom@tromey.com>
2237             Pedro Alves  <palves@redhat.com>
2238
2239         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
2240         (call_function_by_hand_dummy): Use SCOPE_EXIT.
2241
2242 2019-01-23  Tom Tromey  <tom@tromey.com>
2243             Andrew Burgess  <andrew.burgess@embecosm.com>
2244             Pedro Alves  <palves@redhat.com>
2245
2246         * infrun.c (fetch_inferior_event): Use scope_exit.
2247         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
2248         * top.c (execute_command): Use scope_exit.
2249         * breakpoint.c (bpstat_do_actions): Use scope_exit.
2250         * utils.c (do_bpstat_clear_actions_cleanup)
2251         (make_bpstat_clear_actions_cleanup): Remove.
2252
2253 2019-01-23  Tom Tromey  <tom@tromey.com>
2254             Pedro Alves  <palves@redhat.com>
2255
2256         * infrun.c: Include "common/scope-exit.h"
2257         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
2258         (wait_for_inferior): Use SCOPE_EXIT.
2259         (fetch_inferior_event): Use scope_exit.
2260
2261 2019-01-23  Tom Tromey  <tom@tromey.com>
2262             Pedro Alves  <palves@redhat.com>
2263
2264         * breakpoint.c (create_breakpoint): Remove cleanup.
2265
2266 2019-01-23  Tom Tromey  <tom@tromey.com>
2267             Andrew Burgess  <andrew.burgess@embecosm.com>
2268             Pedro Alves  <palves@redhat.com>
2269
2270 2019-01-23  Pedro Alves  <palves@redhat.com>
2271
2272         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
2273
2274 2019-01-23  Pedro Alves  <palves@redhat.com>
2275             Andrew Burgess  <andrew.burgess@embecosm.com>
2276
2277         * gdbthread.h: Include "common/forward-scope-exit.h".
2278         (scoped_finish_thread_state): Redefine custom class in terms of
2279         forward_scope_exit.
2280
2281 2019-01-23  Pedro Alves  <palves@redhat.com>
2282             Andrew Burgess  <andrew.burgess@embecosm.com>
2283
2284         * common/forward-scope-exit.h: New file.
2285
2286 2019-01-23  Pedro Alves  <palves@redhat.com>
2287             Andrew Burgess  <andrew.burgess@embecosm.com>
2288             Tom Tromey  <tom@tromey.com>
2289
2290         * common/scope-exit.h: New file.
2291
2292 2019-01-23  Pedro Alves  <palves@redhat.com>
2293
2294         * common/preprocessor.h (ESC): Rename to ...
2295         (ESC_PARENS): ... this.
2296         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
2297         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
2298
2299 2019-01-23  Tom Tromey  <tom@tromey.com>
2300
2301         * language.h (class scoped_switch_to_sym_language_if_auto):
2302         Initialize m_lang in both cases.
2303
2304 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
2305
2306         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
2307         with XCNEW.
2308
2309 2019-01-22  Tom Tromey  <tom@tromey.com>
2310
2311         * corelow.c: Do not include sys/file.h.
2312
2313 2019-01-22  Tom Tromey  <tom@tromey.com>
2314
2315         * tui/tui-wingeneral.h: Include gdb_curses.h.
2316
2317 2019-01-22  Tom Tromey  <tom@tromey.com>
2318
2319         * source-cache.h (class source_cache) <get_source_lines,
2320         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
2321
2322 2019-01-22  Tom Tromey  <tom@tromey.com>
2323
2324         * remote-fileio.h (struct remote_target): Declare.
2325
2326 2019-01-22  Tom Tromey  <tom@tromey.com>
2327
2328         * python/py-arch.c: Do not include py-ref.h.
2329         * python/py-bpevent.c: Do not include py-ref.h.
2330         * python/py-cmd.c: Do not include py-ref.h.
2331         * python/py-continueevent.c: Do not include py-ref.h.
2332         * python/py-event.h: Do not include py-ref.h.
2333         * python/py-evtregistry.c: Do not include py-ref.h.
2334         * python/py-finishbreakpoint.c: Do not include py-ref.h.
2335         * python/py-frame.c: Do not include py-ref.h.
2336         * python/py-framefilter.c: Do not include py-ref.h.
2337         * python/py-function.c: Do not include py-ref.h.
2338         * python/py-infevents.c: Do not include py-ref.h.
2339         * python/py-linetable.c: Do not include py-ref.h.
2340         * python/py-objfile.c: Do not include py-ref.h.
2341         * python/py-param.c: Do not include py-ref.h.
2342         * python/py-prettyprint.c: Do not include py-ref.h.
2343         * python/py-progspace.c: Do not include py-ref.h.
2344         * python/py-symbol.c: Do not include py-ref.h.
2345         * python/py-symtab.c: Do not include py-ref.h.
2346         * python/py-type.c: Do not include py-ref.h.
2347         * python/py-unwind.c: Do not include py-ref.h.
2348         * python/py-utils.c: Do not include py-ref.h.
2349         * python/py-value.c: Do not include py-ref.h.
2350         * python/py-varobj.c: Do not include py-ref.h.
2351         * python/py-xmethods.c: Do not include py-ref.h.
2352         * python/python.c: Do not include py-ref.h.
2353         * varobj.c: Do not include py-ref.h.
2354
2355 2019-01-22  Tom Tromey  <tom@tromey.com>
2356
2357         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
2358         keyword for bcache.
2359
2360 2019-01-22  Tom Tromey  <tom@tromey.com>
2361
2362         * compile/compile-cplus-types.c: Remove a comment by #include.
2363
2364 2019-01-22  Tom Tromey  <tom@tromey.com>
2365
2366         * compile/gcc-c-plugin.h: Include compile-internal.h.
2367
2368 2019-01-22  Tom Tromey  <tom@tromey.com>
2369
2370         * stabsread.c (EXTERN): Do not define.
2371         (symnum, next_symbol_text_func, processing_gcc_compilation)
2372         (within_function, global_sym_chain, global_stabs)
2373         (previous_stab_code, this_object_header_files)
2374         (n_this_object_header_files)
2375         (n_allocated_this_object_header_files): Define.
2376         * stabsread.h (EXTERN): Never define.  Use "extern".
2377
2378 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2379
2380         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
2381         history_value.
2382
2383 2019-01-21  Tom Tromey  <tom@tromey.com>
2384
2385         * ui-out.c: Fix includes.
2386         * tui/tui-source.c: Fix includes.
2387         * target.c: Fix includes.
2388         * remote.c: Fix includes.
2389         * regcache.c: Fix includes.
2390         * python/py-block.c: Fix includes.
2391         * printcmd.c: Fix includes.
2392         * or1k-tdep.c: Fix includes.
2393         * mi/mi-main.c: Fix includes.
2394         * m32r-tdep.c: Fix includes.
2395         * csky-tdep.c: Fix includes.
2396         * compile/compile-cplus-types.c: Fix includes.
2397         * cli/cli-interp.c: Fix includes.
2398
2399 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
2400
2401         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2402         for padding.
2403
2404 2019-01-16  Tom Tromey  <tom@tromey.com>
2405
2406         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
2407         earlier.
2408         (struct objfile) <msymbols_range>: Move from top level.
2409         <msymbols>: New method.
2410         (class objfile_msymbols): Remove.
2411         * symtab.c (default_collect_symbol_completion_matches_break_on):
2412         Update.
2413         * symmisc.c (dump_msymbols): Update.
2414         * stabsread.c (scan_file_globals): Update.
2415         * objc-lang.c (info_selectors_command, info_classes_command)
2416         (find_methods): Update.
2417         * minsyms.c (find_solib_trampoline_target): Update.
2418         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2419         * coffread.c (coff_symfile_read): Update.
2420         * ada-lang.c (ada_lookup_simple_minsym)
2421         (ada_collect_symbol_completion_matches): Update.
2422
2423 2019-01-16  Tom Tromey  <tom@tromey.com>
2424
2425         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
2426         type.  Remove no-argument constructor.
2427         <iterator::operator++>: Simplify.
2428         <begin>: Update.
2429         <end>: Use minimal_symbol_count.
2430
2431 2019-01-16  Tom Tromey  <tom@tromey.com>
2432
2433         * objfiles.h (struct objfile) <psymtabs>: New method.
2434         (class objfile_psymtabs): Remove.
2435         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
2436         typedef.
2437         <range>: New method.
2438         (require_partial_symbols): Change return type.
2439         * psymtab.c (require_partial_symbols)
2440         (psym_expand_symtabs_matching): Update.
2441         * mdebugread.c (parse_partial_symbols): Update.
2442         * dbxread.c (dbx_end_psymtab): Update.
2443
2444 2019-01-15  Tom Tromey  <tom@tromey.com>
2445
2446         * symtab.c (lookup_objfile_from_block)
2447         (lookup_symbol_in_objfile_symtabs)
2448         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
2449         (find_line_symtab, info_sources_command)
2450         (default_collect_symbol_completion_matches_break_on)
2451         (make_source_files_completion_list): Update.
2452         * symmisc.c (print_objfile_statistics, dump_objfile)
2453         (maintenance_print_symbols, maintenance_info_symtabs)
2454         (maintenance_check_symtabs, maintenance_info_line_tables):
2455         Update.
2456         * source.c (select_source_symtab)
2457         (forget_cached_source_info_for_objfile): Update.
2458         * objfiles.h (class objfile_compunits): Remove.
2459         (struct objfile) <compunits_range>: New typedef.
2460         (compunits): New method.
2461         * objfiles.c (objfile_relocate1): Update.
2462         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2463         * maint.c (count_symtabs_and_blocks): Update.
2464         * linespec.c (iterate_over_all_matching_symtabs): Update.
2465         * cp-support.c (add_symbol_overload_list_qualified): Update.
2466         * coffread.c (coff_symtab_read): Update.
2467         * ada-lang.c (add_nonlocal_symbols)
2468         (ada_collect_symbol_completion_matches)
2469         (ada_add_global_exceptions): Update.
2470
2471 2019-01-15  Tom Tromey  <tom@tromey.com>
2472
2473         * progspace.h (program_space) <objfiles_safe_range>: New
2474         typedef.
2475         <objfiles_safe>: New method.
2476         * objfiles.h (class all_objfiles_safe): Remove.
2477         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
2478         * jit.c (jit_inferior_exit_hook): Update.
2479
2480 2019-01-17  Tom Tromey  <tom@tromey.com>
2481
2482         * progspace.h (program_space) <objfiles_range>: New typedef.
2483         <objfiles>: New method.
2484         <objfiles_head>: Rename from objfiles.
2485         (object_files): Update.
2486         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
2487         * guile/scm-pretty-print.c
2488         (ppscm_find_pretty_printer_from_objfiles): Update.
2489         * guile/scm-objfile.c (gdbscm_objfiles): Update.
2490         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
2491         Update.
2492         * python/py-progspace.c (pspy_get_objfiles): Update.
2493         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2494         Update.
2495         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2496         (objfpy_lookup_objfile_by_build_id): Update.
2497         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2498         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2499         Update.
2500         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2501         (expand_symtab_containing_pc, lookup_objfile_from_block)
2502         (lookup_static_symbol, basic_lookup_transparent_type)
2503         (find_pc_sect_compunit_symtab, find_symbol_at_address)
2504         (find_line_symtab, info_sources_command)
2505         (default_collect_symbol_completion_matches_break_on)
2506         (make_source_files_completion_list, find_main_name): Update.
2507         * symmisc.c (print_symbol_bcache_statistics)
2508         (print_objfile_statistics, maintenance_print_symbols)
2509         (maintenance_print_msymbols, maintenance_print_objfiles)
2510         (maintenance_info_symtabs, maintenance_check_symtabs)
2511         (maintenance_expand_symtabs, maintenance_info_line_tables):
2512         Update.
2513         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
2514         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
2515         (map_overlay_command, unmap_overlay_command)
2516         (simple_overlay_update, expand_symtabs_matching)
2517         (map_symbol_filenames): Update.
2518         * symfile-debug.c (set_debug_symfile): Update.
2519         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
2520         Update.
2521         * source.c (select_source_symtab, forget_cached_source_info):
2522         Update.
2523         * solib.c (solib_read_symbols): Update.
2524         * solib-spu.c (append_ocl_sos): Update.
2525         * psymtab.c (maintenance_print_psymbols)
2526         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
2527         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
2528         * printcmd.c (info_symbol_command): Update.
2529         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
2530         Update.
2531         * objfiles.h (class all_objfiles): Remove.
2532         * objfiles.c (have_partial_symbols, have_full_symbols)
2533         (have_minimal_symbols, qsort_cmp, update_section_map)
2534         (shared_objfile_contains_address_p)
2535         (default_iterate_over_objfiles_in_search_order): Update.
2536         * objc-lang.c (info_selectors_command, info_classes_command)
2537         (find_methods): Update.
2538         * minsyms.c (find_solib_trampoline_target): Update.
2539         * maint.c (maintenance_info_sections)
2540         (maintenance_translate_address, count_symtabs_and_blocks):
2541         Update.
2542         * main.c (captured_main_1): Update.
2543         * linux-thread-db.c (try_thread_db_load_from_pdir)
2544         (has_libpthread): Update.
2545         * linespec.c (iterate_over_all_matching_symtabs)
2546         (search_minsyms_for_name): Update.
2547         * jit.c (jit_find_objf_with_entry_addr): Update.
2548         * hppa-tdep.c (find_unwind_entry)
2549         (hppa_lookup_stub_minimal_symbol): Update.
2550         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
2551         Update.
2552         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2553         (elf_gnu_ifunc_resolve_by_got): Update.
2554         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
2555         * dwarf-index-write.c (save_gdb_index_command): Update.
2556         * cp-support.c (add_symbol_overload_list_qualified): Update.
2557         * breakpoint.c (create_overlay_event_breakpoint)
2558         (create_longjmp_master_breakpoint)
2559         (create_std_terminate_master_breakpoint)
2560         (create_exception_master_breakpoint): Update.
2561         * blockframe.c (find_pc_partial_function): Update.
2562         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
2563         (ada_collect_symbol_completion_matches)
2564         (ada_add_global_exceptions): Update.
2565
2566 2019-01-17  Tom Tromey  <tom@tromey.com>
2567
2568         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
2569         declare VEC.
2570         (solib_target_parse_libraries): Change return type.
2571         (library_list_start_segment, library_list_start_section)
2572         (library_list_end_library, library_list_start_library); Update.
2573         (solib_target_free_library_list): Remove.
2574         (solib_target_parse_libraries): Remove cleanup.  Change return
2575         type.
2576         (solib_target_current_sos): Update.
2577
2578 2019-01-17  Tom Tromey  <tromey@bapiya>
2579
2580         * valprint.c: Replace "the the" with "the".
2581         * symtab.c: Replace "the the" with "the".
2582         * solib.c: Replace "the the" with "the".
2583         * solib-dsbt.c: Replace "the the" with "the".
2584         * linespec.c: Replace "the the" with "the".
2585         * dwarf2loc.h: Replace "the the" with "the".
2586         * amd64-windows-tdep.c: Replace "the the" with "the".
2587         * aarch64-tdep.c: Replace "the the" with "the".
2588
2589 2019-01-16  Keith Seitz  <keiths@redhat.com>
2590
2591         PR gdb/23773
2592         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
2593         <builder>: Rename to ..
2594         <m_builder>: ... this and make private.
2595         (dwarf2_cu::get_builder): New method.  Change all users of
2596         `builder' to use this method.
2597         (dwarf2_start_symtab): Move to ...
2598         (dwarf2_cu::start_symtab): ... here.  Update all callers
2599         (setup_type_unit_groups): Move to ...
2600         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
2601         callers.
2602         (dwarf2_cu::reset_builder): New method.
2603         (process_full_compunit, process_full_type_unit): Use
2604         dwarf2_cu::reset_builder.
2605         (follow_die_offset): Record the ancestor CU if it is different
2606         from the followed DIE's CU.
2607         (follow_die_sig_1): Likewise.
2608
2609 2019-01-15  Tom Tromey  <tom@tromey.com>
2610
2611         * remote.c (class remote_state) <buf>: Now a char_vector.
2612         <buf_size>: Remove.
2613         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
2614         parameter.
2615         (remote_target::getpkt_or_notif_sane_1)
2616         (remote_target::getpkt_sane)
2617         (remote_target::getpkt_or_notif_sane): Likewise.
2618         (class remote_target) <putpkt>: New overload.
2619         (remote_target::read_frame): Change type of "buf_p".  Remove
2620         sizeof_p parameter.
2621         (packet_ok): New overload.
2622         (packet_check_result): New overload.
2623         Update all uses.
2624
2625 2019-01-14  Tom Tromey  <tom@tromey.com>
2626
2627         * remote-notif.c (handle_notification, remote_notif_ack)
2628         (remote_notif_parse): Make "buf" const.
2629         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
2630         const.
2631         (remote_notif_parse, remote_notif_ack, handle_notification):
2632         Likewise.
2633         * remote.c (remote_notif_stop_parse): Make "buf" const.
2634         (remote_target::remote_parse_stop_reply): Make "buf" const.
2635         (remote_notif_stop_ack): Make "buf" const.
2636
2637 2019-01-14  Tom Tromey  <tom@tromey.com>
2638
2639         * remote.c (remote_console_output): Make parameter const.
2640
2641 2019-01-14  Tom Tromey  <tom@tromey.com>
2642
2643         * target-debug.h (target_debug_print_signals): Constify.
2644         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
2645         * procfs.c (procfs_target::pass_signals): Update.
2646         * linux-nat.c (linux_nat_target::pass_signals): Update.
2647         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
2648         * target-delegates.c: Rebuild.
2649         * remote.c (remote_target::program_signals): Update.
2650         (remote_target::pass_signals): Update.
2651         * target.c (target_pass_signals): Constify argument.
2652         (target_program_signals): Likewise.
2653         * target.h (struct target_ops) <pass_signals, program_signals>:
2654         Constify argument.
2655         (target_pass_signals, target_program_signals): Constify argument.
2656
2657 2019-01-14  Tom Tromey  <tom@tromey.com>
2658
2659         PR tui/28819:
2660         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
2661
2662 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2663
2664         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
2665         field.
2666         * rs6000-tdep.c: Include reggroups.h.
2667         (IS_V_ALIAS_PSEUDOREG): Define.
2668         (rs6000_register_name): Return names for the "vX" aliases.
2669         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
2670         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
2671         aliases.  Call default_register_reggroup_p for all other
2672         pseudo-registers.
2673         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
2674         New functions.
2675         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
2676         Handle "vX" aliases.
2677         (v_alias_pseudo_register_collect): New function.
2678         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
2679         (rs6000_gdbarch_init): Initialize "vX" aliases as
2680         pseudo-registers.  Restore registration of
2681         rs6000_pseudo_register_reggroup_p with
2682         set_tdesc_pseudo_register_reggroup_p.
2683
2684 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
2685
2686         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
2687         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
2688         set_gdbarch_num_pseudo_regs.
2689
2690 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2691
2692         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
2693         Remove arg prefixname, add do_set and do_show.
2694         Add member functions set_list and show_list.
2695         * cli/cli-style.c (class cli_style_option): Update accordingly.
2696         (style_set_list): Move to file scope.
2697         (style_show_list): Likewise.
2698         (set_style): Call help_list.
2699         (show_style): Call cmd_show_list.
2700         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
2701         Update to use the new macro.
2702
2703 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
2704
2705         * ada-lang.c (_initialize_ada_language): Expand the help text
2706         for the "catch exception" command.
2707
2708 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2709
2710         * symtab.c (matching_obj_sections): Initialize obj,
2711         declare it closer to its usage.
2712
2713 2019-01-10  Tom Tromey  <tom@tromey.com>
2714
2715         * thread-iter.h (inf_threads_iterator): Use next_iterator.
2716         (basic_inf_threads_range): Remove.
2717         (inf_threads_range, inf_non_exited_threads_range)
2718         (safe_inf_threads_range): Use next_adapter.
2719
2720 2019-01-10  Keith Seitz  <keiths@redhat.com>
2721
2722         PR gdb/23712
2723         PR symtab/23010
2724         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
2725         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
2726
2727 2019-01-10  Keith Seitz  <keiths@redhat.com>
2728
2729         PR gdb/23712
2730         PR symtab/23010
2731         * dictionary.c (pending_to_vector): Remove.
2732         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2733         Remove _1 suffix, replacing functions of the same name.  Update
2734         all callers.
2735         (dict_create_hashed, dict_create_hashed_expandable)
2736         (dict_create_linear, dict_create_linear_expandable, dict_free)
2737         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
2738         Make functions static.
2739
2740 2019-01-10  Keith Seitz  <keiths@redhat.com>
2741
2742         PR gdb/23712
2743         PR symtab/23010
2744         * dictionary.h (struct dictionary): Replace declaration with
2745         multidictionary.
2746         (dict_create_hashed, dict_create_hashed_expandable)
2747         (dict_create_linear, dict_create_linear_expandable)
2748         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
2749         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
2750         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
2751         taking multidictionary argument.
2752         [ALL_DICT_SYMBOLS]: Update for multidictionary.
2753         * block.h (struct block) <dict>: Change to multidictionary
2754         and rename `multidict'.
2755         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
2756         symmisc.c: Update all dictionary references to multidictionary.
2757
2758 2019-01-10  Keith Seitz  <keiths@redhat.com>
2759
2760         PR gdb/23712
2761         PR symtab/23010
2762         * dictionary.c: Include unordered_map.
2763         (pending_to_vector): New function.
2764         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2765         Rewrite the non-"_1" functions to take vector instead
2766         of linked list.
2767         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
2768         "new" _1 versions of the same name.
2769         (multidictionary): Define.
2770         (std::hash<enum language): New definition.
2771         (collate_pending_symbols_by_language, mdict_create_hashed)
2772         (mdict_create_hashed_expandable, mdict_create_linear)
2773         (mdict_create_linear_expandable, mdict_free)
2774         (find_language_dictionary, create_new_language_dictionary)
2775         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
2776         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
2777         (mdict_size, mdict_empty): New functions.
2778         * dictionary.h (mdict_iterator): Define.
2779
2780 2019-01-10  Pedro Alves  <palves@redhat.com>
2781
2782         * breakpoint.c (read_uploaded_action)
2783         (create_tracepoint_from_upload): Adjust to use
2784         gdb::unique_xmalloc_ptr.
2785         * ctf.c (ctf_write_uploaded_tp):
2786         (SET_ARRAY_FIELD): Use emplace_back.
2787         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
2788         * tracefile-tfile.c (tfile_write_uploaded_tp):
2789         * tracepoint.c (parse_tracepoint_definition): Adjust to use
2790         gdb::unique_xmalloc_ptr.
2791         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
2792         at_string, cond_string, cmd_strings>: Replace char pointers
2793         with gdb::unique_xmalloc_ptr.
2794
2795 2019-01-10  Pedro Alves  <palves@redhat.com>
2796
2797         * solib-target.c (library_list_start_library): Don't xstrdup name.
2798
2799 2019-01-10  Pedro Alves  <palves@redhat.com>
2800
2801         * mdebugread.c (parse_partial_symbols): Use
2802         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
2803
2804 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2805
2806         * linux-fork.c (scoped_switch_fork_info)
2807         <~scoped_switch_fork_info>: Fix incorrect variable name.
2808
2809 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2810
2811         * linux-fork.c (scoped_switch_fork_info)
2812         <scoped_switch_fork_info>: Make explicit.
2813         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
2814
2815 2019-01-10  Tom Tromey  <tom@tromey.com>
2816
2817         * objfiles.h (objfile::reset_psymtabs): Update.
2818         * objfiles.c (objfile::objfile): Update.
2819         * psymtab.h (psymtab_storage::obstack): Update.
2820         (psymtab_storage::m_obstack): Use gdb::optional.
2821         (class psymtab_storage): Update comment.  Remove objfile
2822         parameter.
2823         * psymtab.c (psymtab_storage::psymtab_storage): Update.
2824
2825 2019-01-10  Tom Tromey  <tom@tromey.com>
2826
2827         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
2828         <free_psymtabs>: Now private.
2829         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
2830         (allocate_psymtab): Use new method.
2831
2832 2019-01-10  Tom Tromey  <tom@tromey.com>
2833
2834         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
2835         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
2836         * mdebugread.c (parse_partial_symbols): Use
2837         allocate_dependencies.
2838         * dwarf2read.c (dwarf2_create_include_psymtab): Use
2839         allocate_dependencies.
2840         (process_psymtab_comp_unit_reader)
2841         (build_type_psymtab_dependencies): Likewise.
2842         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
2843
2844 2019-01-10  Tom Tromey  <tom@tromey.com>
2845
2846         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
2847         PSYMBOL_SET_LANGUAGE.
2848         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
2849
2850 2019-01-10  Tom Tromey  <tom@tromey.com>
2851
2852         * psymtab.h (psymtab_storage::obstack): New method.
2853         <m_obstack>: Rename from obstack; now private.
2854         * psymtab.c (psymtab_storage): Update.
2855         * dwarf2read.c (create_addrmap_from_index)
2856         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
2857         Update.
2858
2859 2019-01-10  Tom Tromey  <tom@tromey.com>
2860
2861         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
2862         * objfiles.h (objfile::reset_psymtabs): New method.
2863
2864 2019-01-10  Tom Tromey  <tom@tromey.com>
2865
2866         * symmisc.c (print_symbol_bcache_statistics): Update.
2867         (print_objfile_statistics): Update.
2868         * symfile.c (reread_symbols): Update.
2869         * psymtab.h (class psymtab_storage): New.
2870         * psymtab.c (psymtab_storage): New constructor.
2871         (~psymtab_storage): New destructor.
2872         (require_partial_symbols): Update.
2873         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
2874         (find_pc_sect_psymtab, find_pc_sect_psymbol)
2875         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
2876         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
2877         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
2878         (start_psymtab_common, end_psymtab_common)
2879         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
2880         (allocate_psymtab): Update.
2881         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
2882         Update.
2883         (dump_psymtab_addrmap, maintenance_print_psymbols)
2884         (maintenance_check_psymtabs): Update.
2885         (class objfile_psymtabs): Move to objfiles.h.
2886         * psympriv.h (discard_psymtab): Now inline.
2887         (psymtab_discarder::psymtab_discarder): Update.
2888         (psymtab_discarder::~psymtab_discarder): Update.
2889         (ALL_OBJFILE_PSYMTABS): Rewrite.
2890         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
2891         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
2892         Remove fields.
2893         <partial_symtabs>: New field.
2894         (class objfile_psymtabs): Move from psymtab.h.  Update.
2895         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
2896         psymbol_cache.
2897         (objfile::~objfile): Don't destroy psymbol_cache.
2898         * mdebugread.c (parse_partial_symbols): Update.
2899         * dwarf2read.c (create_addrmap_from_index)
2900         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
2901         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
2902         (add_partial_subprogram, dwarf2_ranges_read): Update.
2903         * dwarf-index-write.c (write_address_map)
2904         (write_one_signatured_type, recursively_write_psymbols)
2905         (class debug_names, class debug_names, write_psymtabs_to_index):
2906         Update.
2907
2908 2019-01-10  Tom Tromey  <tom@tromey.com>
2909
2910         * symtab.h (SYMBOL_SET_NAMES): Update.
2911         (symbol_set_names): Update.
2912         (MSYMBOL_SET_NAMES): Update.
2913         * symtab.c (symbol_set_names): Change argument to be an
2914         objfile_per_bfd_storage.
2915         * psymtab.c (add_psymbol_to_bcache): Update.
2916         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
2917
2918 2019-01-10  Tom Tromey  <tom@tromey.com>
2919
2920         * symtab.c (create_demangled_names_hash): Change argument to be an
2921         objfile_per_bfd_storage.
2922         (symbol_set_names): Update.
2923
2924 2019-01-10  Tom Tromey  <tom@tromey.com>
2925
2926         * xcoffread.c (xcoff_initial_scan): Unconditionally call
2927         init_psymbol_list.
2928         * psymtab.c (init_psymbol_list): Do nothing if already called.
2929         * psympriv.h (init_psymbol_list): Add comment.
2930         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
2931         init_psymbol_list.
2932         * dbxread.c (dbx_symfile_read): Unconditionally call
2933         init_psymbol_list.
2934
2935 2019-01-10  Tom Tromey  <tom@tromey.com>
2936
2937         * xcoffread.c (scan_xcoff_symtab): Update.
2938         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
2939         "where".
2940         * mdebugread.c (parse_partial_symbols)
2941         (handle_psymbol_enumerators): Update.
2942         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
2943         * dbxread.c (read_dbx_symtab): Update.
2944         * psympriv.h (psymbol_placement): New enum.
2945         (add_psymbol_to_list): Update.
2946
2947 2019-01-10  Tom Tromey  <tom@tromey.com>
2948
2949         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
2950         static_psymbols parameters.
2951         (scan_xcoff_symtab): Update.
2952         * psymtab.c (start_psymtab_common): Remove global_psymbols and
2953         static_psymbols parameters.
2954         * psympriv.h (start_psymtab_common): Update.
2955         * mdebugread.c (parse_partial_symbols): Update.
2956         * dwarf2read.c (create_partial_symtab): Update.
2957         * dbxread.c (read_dbx_symtab): Update.
2958         (start_psymtab): Remove global_psymbols and static_psymbols
2959         parameters.
2960
2961 2019-01-10  Tom Tromey  <tom@tromey.com>
2962
2963         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
2964         * psymtab.c (allocate_psymtab): Add comment.
2965         * psympriv.h (allocate_psymtab): Add comment.
2966         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
2967         initializations.
2968         * dbxread.c (dbx_end_psymtab): Remove some initializations.
2969
2970 2019-01-10  Tom Tromey  <tom@tromey.com>
2971
2972         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2973         Don't declare.
2974         * mipsread.c: Include mdebugread.h.
2975         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2976         Declare.
2977         * elfread.c: Include mdebugread.h.
2978
2979 2019-01-09  Tom Tromey  <tom@tromey.com>
2980
2981         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
2982         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
2983         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
2984         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
2985         (psym_lookup_symbol, psym_find_last_source_symtab)
2986         (psym_forget_cached_source_info, psym_print_stats)
2987         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
2988         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
2989         (psym_map_matching_symbols, psym_expand_symtabs_matching)
2990         (psym_find_compunit_symtab_by_address)
2991         (maintenance_print_psymbols, maintenance_info_psymtabs)
2992         (maintenance_check_psymtabs): Use ranged for.
2993         * psymtab.h (class objfile_psymtabs): New.
2994         (require_partial_symbols): Return objfile_psymtabs.
2995         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
2996
2997 2019-01-09  Tom Tromey  <tom@tromey.com>
2998
2999         * symfile.c (overlay_invalidate_all, find_pc_overlay)
3000         (find_pc_mapped_section, list_overlays_command)
3001         (map_overlay_command, unmap_overlay_command)
3002         (simple_overlay_update): Use all_objfiles.
3003         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
3004         * printcmd.c (info_symbol_command): Use all_objfiles.
3005         * objfiles.h (ALL_OBJSECTIONS): Remove.
3006         * maint.c (maintenance_translate_address): Use all_objfiles.
3007         * gcore.c (gcore_create_callback): Use all_objfiles.
3008         (objfile_find_memory_regions): Likewise.
3009
3010 2019-01-09  Tom Tromey  <tom@tromey.com>
3011
3012         * symtab.c (find_line_symtab, info_sources_command)
3013         (make_source_files_completion_list): Use objfile_compunits.
3014         * source.c (select_source_symtab): Use objfile_compunits.
3015         * objfiles.h (struct objfile): Update comment.
3016         (ALL_OBJFILES): Remove.
3017         (ALL_FILETABS): Remove.
3018         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
3019         objfile_compunits.
3020
3021 2019-01-09  Tom Tromey  <tom@tromey.com>
3022
3023         * symmisc.c (print_objfile_statistics, dump_objfile)
3024         (maintenance_print_symbols): Use compunit_filetabs.
3025         * source.c (forget_cached_source_info_for_objfile): Use
3026         compunit_filetabs.
3027         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
3028         (ALL_FILETABS): Use compunit_filetabs.
3029         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
3030         * coffread.c (coff_symtab_read): Use compunit_filetabs.
3031
3032 2019-01-09  Tom Tromey  <tom@tromey.com>
3033
3034         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
3035         (compunit_filetabs): New.
3036         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
3037         compunit_filetabs.
3038         (info_sources_command, make_source_files_completion_list): Remove
3039         declaration.
3040         * symmisc.c (print_objfile_statistics, dump_objfile)
3041         (maintenance_print_symbols): Remove declaration.
3042         (maintenance_info_symtabs): Use compunit_filetabs.
3043         (maintenance_info_line_tables): Likewise.
3044         * source.c (select_source_symtab): Change local variable name.
3045         (forget_cached_source_info_for_objfile): Remove declaration.
3046         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
3047         * objfiles.c (objfile_relocate1): Remove declaration.
3048         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3049         declaration.
3050         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
3051         * coffread.c (coff_symtab_read): Remove declaration.
3052         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3053         compunit_filetabs.
3054
3055 2019-01-09  Tom Tromey  <tom@tromey.com>
3056
3057         * symtab.c (lookup_objfile_from_block)
3058         (find_pc_sect_compunit_symtab, search_symbols)
3059         (default_collect_symbol_completion_matches_break_on): Use
3060         objfile_compunits.
3061         * objfiles.h (ALL_COMPUNITS): Remove.
3062         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
3063         * cp-support.c (add_symbol_overload_list_qualified): Use
3064         objfile_compunits.
3065         * ada-lang.c (ada_collect_symbol_completion_matches)
3066         (ada_add_global_exceptions): Use objfile_compunits.
3067
3068 2019-01-09  Tom Tromey  <tom@tromey.com>
3069
3070         * source.c (select_source_symtab)
3071         (forget_cached_source_info_for_objfile): Remove declaration.
3072         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3073         declaration.
3074         * maint.c (count_symtabs_and_blocks): Remove declaration.
3075         * cp-support.c (add_symbol_overload_list_qualified): Remove
3076         declaration.
3077         * coffread.c (coff_symtab_read): Remove declaration.
3078         * symtab.c (lookup_symbol_in_objfile_symtabs)
3079         (basic_lookup_transparent_type_1): Use objfile_compunits.
3080         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
3081         (info_sources_command, search_symbols)
3082         (default_collect_symbol_completion_matches_break_on)
3083         (make_source_files_completion_list): Remove declaration.
3084         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
3085         (ada_collect_symbol_completion_matches)
3086         (ada_add_global_exceptions): Remove declaration.
3087         * linespec.c (iterate_over_all_matching_symtabs): Use
3088         objfile_compunits.
3089         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
3090         (class objfile_compunits): New.
3091         (ALL_COMPUNITS): Use objfile_compunits.
3092         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
3093         (maintenance_check_symtabs, maintenance_info_line_tables): Use
3094         objfile_compunits.
3095         * objfiles.c (objfile_relocate1): Use objfile_compunits.
3096
3097 2019-01-09  Tom Tromey  <tom@tromey.com>
3098
3099         * symtab.c (search_symbols)
3100         (default_collect_symbol_completion_matches_break_on): Use
3101         objfile_msymbols.
3102         * ada-lang.c (ada_lookup_simple_minsym)
3103         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
3104         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
3105         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
3106         objfile_msymbols.
3107         * coffread.c (coff_symfile_read): Use objfile_msymbols.
3108         * symmisc.c (dump_msymbols): Use objfile_msymbols.
3109         * objc-lang.c (find_methods): Use objfile_msymbols.
3110         (info_selectors_command, info_classes_command): Likewise.
3111         * stabsread.c (scan_file_globals): Use objfile_msymbols.
3112         * objfiles.h (class objfile_msymbols): New.
3113         (ALL_OBJFILE_MSYMBOLS): Remove.
3114         (ALL_MSYMBOLS): Remove.
3115
3116 2019-01-09  Tom Tromey  <tom@tromey.com>
3117
3118         * common/next-iterator.h (next_adapter): Add Iterator template
3119         parameter.
3120         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
3121         (class all_objfiles_safe): New.
3122         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
3123         * objfiles.c (put_objfile_before): Update comment.
3124         (add_separate_debug_objfile): Likewise.
3125         (free_all_objfiles): Use all_objfiles_safe.
3126         (objfile_purge_solibs): Likewise.
3127
3128 2019-01-09  Tom Tromey  <tom@tromey.com>
3129
3130         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3131         (expand_symtab_containing_pc, lookup_static_symbol)
3132         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
3133         (find_symbol_at_address, find_line_symtab, find_main_name): Use
3134         all_objfiles.
3135         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
3136         * breakpoint.c (create_overlay_event_breakpoint)
3137         (create_longjmp_master_breakpoint)
3138         (create_std_terminate_master_breakpoint)
3139         (create_exception_master_breakpoint): Use all_objfiles.
3140         * linux-thread-db.c (try_thread_db_load_from_pdir)
3141         (has_libpthread): Use all_objfiles.
3142         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
3143         * linespec.c (iterate_over_all_matching_symtabs)
3144         (search_minsyms_for_name): Use all_objfiles.
3145         * maint.c (maintenance_info_sections): Use all_objfiles.
3146         * main.c (captured_main_1): Use all_objfiles.
3147         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
3148         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
3149         * guile/scm-pretty-print.c
3150         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
3151         * solib-spu.c (append_ocl_sos): Use all_objfiles.
3152         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
3153         (maintenance_print_msymbols): Use all_objfiles.
3154         * source.c (select_source_symtab): Use all_objfiles.
3155         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
3156         * symfile.c (remove_symbol_file_command)
3157         (expand_symtabs_matching, map_symbol_filenames): Use
3158         all_objfiles.
3159         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
3160         all_objfiles.
3161         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
3162         * objc-lang.c (find_methods): Use all_objfiles.
3163         * objfiles.c (have_partial_symbols, have_full_symbols)
3164         (have_minimal_symbols, qsort_cmp)
3165         (default_iterate_over_objfiles_in_search_order): Use
3166         all_objfiles.
3167         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
3168         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
3169         (maintenance_check_psymtabs): Use all_objfiles.
3170         (ALL_PSYMTABS): Remove.
3171         * compile/compile-object-run.c (do_module_cleanup): Use
3172         all_objfiles.
3173         * blockframe.c (find_pc_partial_function): Use all_objfiles.
3174         * cp-support.c (add_symbol_overload_list_qualified): Use
3175         all_objfiles.
3176         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3177         Use all_objfiles.
3178         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
3179         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
3180         all_objfiles.
3181         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3182         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
3183         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3184         Uses all_objfiles.
3185         * solib.c (solib_read_symbols): Use all_objfiles
3186
3187 2019-01-09  Tom Tromey  <tom@tromey.com>
3188
3189         * probe.c (parse_probes_in_pspace): Use all_objfiles.
3190         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
3191         all_objfiles.
3192         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
3193         * symmisc.c (print_symbol_bcache_statistics)
3194         (print_objfile_statistics, maintenance_print_objfiles)
3195         (maintenance_info_symtabs, maintenance_check_symtabs)
3196         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
3197         all_objfiles.
3198         * source.c (forget_cached_source_info): Use all_objfiles.
3199         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
3200         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3201         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
3202         * objfiles.c (update_section_map): Use all_objfiles.
3203         (shared_objfile_contains_address_p): Likewise.
3204         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
3205         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
3206
3207 2019-01-09  Tom Tromey  <tom@tromey.com>
3208
3209         * common/next-iterator.h: New file.
3210         * objfiles.h (class all_objfiles): New.
3211         (struct objfile_iterator): New.
3212
3213 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3214
3215         * NEWS: Move the description of the changed "frame", "select-frame",
3216          and "info frame" commands to the Changed commands section.
3217
3218 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
3219
3220         * gdbtypes.c (check_stub_method_group): Remove handling of old
3221         mangling schemes.
3222         * linespec.c (find_methods): Likewise.
3223         * stabsread.c (read_member_functions): Likewise.
3224         * valops.c (search_struct_method): Likewise.
3225         (value_struct_elt_for_reference): Likewise.
3226         * NEWS: Mention this change.
3227
3228 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3229
3230         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
3231         print_source_lines.
3232         * source.c (print_source_lines_base): Update line number check.
3233         (print_source_lines): New function.
3234         (source_lines_range::source_lines_range): New function.
3235         * source.h (class source_lines_range): New class.
3236         (print_source_lines): New declaration.
3237
3238 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3239
3240         * linespec.c (linespec_state_destructor): Free self->canonical_names.
3241
3242 2019-01-08  Tom Tromey  <tom@tromey.com>
3243             Simon Marchi  <simon.marchi@ericsson.com>
3244
3245         PR gdb/24060
3246         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
3247         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
3248         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3249         * f-exp.y (DOLLAR_VARIABLE): Likewise.
3250         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
3251         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3252
3253 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3254
3255         * source.c (select_source_symtab): Move header comment to
3256         declaration in source.h.
3257         (forget_cached_source_info_for_objfile): Likewise.
3258         (forget_cached_source_info): Likewise.
3259         (identify_source_line): Likewise.
3260         * source.h (identify_source_line): Move declaration from symtab.h
3261         and add comment from source.c
3262         (print_source_lines): Likewise.
3263         (forget_cached_source_info_for_objfile): Likewise.
3264         (forget_cached_source_info): Likewise.
3265         (select_source_symtab): Likewise.
3266         (enum print_source_lines_flag): Move definition from symtab.h.
3267         * symtab.h (identify_source_line): Move declaration to source.h.
3268         (print_source_lines): Likewise.
3269         (forget_cached_source_info_for_objfile): Likewise.
3270         (forget_cached_source_info): Likewise.
3271         (select_source_symtab): Likewise.
3272         (enum print_source_lines_flag): Move definition to source.h.
3273         * tui/tui-hooks.c: Add 'source.h' include.
3274
3275 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3276
3277         * source.c (print_source_lines_base): Handle requests to print
3278         reverse line number sequences, and guard against empty lines
3279         string.
3280
3281 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3282
3283         * source.c (print_source_lines_base): Fix skip of '\r' if next
3284         character is '\n'.
3285
3286 2019-01-06  Tom Tromey  <tom@tromey.com>
3287
3288         * c-exp.y (struct c_parse_state) <macro_original_text,
3289         expansion_obstack>: New member.
3290         (macro_original_text, expansion_obstack): Remove globals.
3291         (scan_macro_expansion, scanning_macro_expansion)
3292         (finished_macro_expansion): Update.
3293         (scan_macro_cleanup): Remove.
3294         (yylex, c_parse): Update.
3295
3296 2019-01-06  Tom Tromey  <tom@tromey.com>
3297
3298         * c-exp.y (struct c_parse_state) <strings>: New member.
3299         (operator_stoken): Update.
3300
3301 2019-01-06  Tom Tromey  <tom@tromey.com>
3302
3303         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
3304         (union type_stack_elt) <typelist_val>: Now a pointer to
3305         std::vector.
3306         (type_stack_cleanup): Don't declare.
3307         (push_typelist): Update.
3308         * parse.c (pop_typelist): Return a std::vector.
3309         (push_typelist): Take a std::vector.
3310         (follow_types): Update.  Do not free args.
3311         (type_stack_cleanup): Remove.
3312         * c-exp.y (struct c_parse_state): New.
3313         (cpstate): New global.
3314         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
3315         (nonempty_typelist): Update.
3316         (func_mod): Create a new vector.
3317         (c_parse): Create a c_parse_state.
3318         (check_parameter_typelist): Do not delete params.
3319         (function_method): Update.  Do not delete type_list.
3320
3321 2019-01-06  Tom Tromey  <tom@tromey.com>
3322
3323         PR gdb/28155:
3324         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
3325         check_typedef.
3326         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
3327         (print_return_value): Likewise.
3328
3329 2019-01-05  Tom Tromey  <tom@tromey.com>
3330
3331         * contrib/cleanup_check.py: Remove.
3332         * contrib/gcc-with-excheck: Remove.
3333         * contrib/exsummary.py: Remove.
3334         * contrib/excheck.py: Remove.
3335
3336 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
3337
3338         * thread.c (delete_thread_1): Add gdb_assert that THR is not
3339         NULL. Initialize tpprev to NULL instead of assigning it
3340         to NULL on the next statement.
3341         * windows-nat.c (windows_delete_thread): Remove check for
3342         main_thread_id before printing thread exit notifications.
3343         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
3344         Remove thread ID check against main_thread_id.
3345         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
3346         windows_delete_thread.
3347         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
3348
3349 2019-01-04  Tom Tromey  <tom@tromey.com>
3350
3351         * compile/compile.c (_initialize_compile): Use upper case for
3352         metasyntactic variables.
3353         * symmisc.c (_initialize_symmisc): Use upper case for
3354         metasyntactic variables.
3355         * psymtab.c (_initialize_psymtab): Use upper case for
3356         metasyntactic variables.
3357         * demangle.c (demangle_command): Use upper case for metasyntactic
3358         variables.
3359         (_initialize_demangler): Likewise.
3360         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
3361         variables.
3362
3363 2019-01-03  Tom Tromey  <tom@tromey.com>
3364
3365         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
3366
3367 2019-01-03  Tom Tromey  <tom@tromey.com>
3368
3369         * python/py-symtab.c (salpy_str): Update.
3370         (struct salpy_sal_object) <symtab>: Now a PyObject.
3371         (salpy_dealloc): Update.
3372         (del_objfile_sal): Use gdbpy_ref.
3373
3374 2019-01-03  Tom Tromey  <tom@tromey.com>
3375
3376         * python/py-type.c (convert_field): Use new_reference.  Return
3377         gdbpy_ref.
3378         (make_fielditem): Return gdbpy_ref.
3379         (typy_fields): Update.
3380         (typy_getitem): Update.
3381         (field_name): Return gdbpy_ref.  Use new_reference.
3382         (typy_iterator_iternext): Update.
3383
3384 2019-01-03  Tom Tromey  <tom@tromey.com>
3385
3386         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
3387
3388 2019-01-03  Tom Tromey  <tom@tromey.com>
3389
3390         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
3391         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
3392         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
3393         (pspy_set_frame_filters, pspy_set_frame_unwinders)
3394         (pspy_set_type_printers): Likewise.
3395         * python/py-function.c (fnpy_init): Use gdbpy_ref.
3396         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
3397         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
3398         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
3399         (objfpy_set_type_printers): Likewise.
3400
3401 2019-01-03  Tom Tromey  <tom@tromey.com>
3402
3403         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
3404         (gdbpy_print_stack): Use gdbpy_err_fetch.
3405         * python/python-internal.h (class gdbpy_err_fetch): New class.
3406         (class gdbpy_enter) <m_error_type, m_error_value,
3407         m_error_traceback>: Remove.
3408         <m_error>: New member.
3409         (gdbpy_exception_to_string): Don't declare.
3410         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
3411         * python/py-value.c (convert_value_from_python): Use
3412         gdbpy_err_fetch.
3413         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
3414         gdbpy_exception_to_string.
3415         (gdbpy_handle_exception): Use gdbpy_err_fetch.
3416         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3417         gdbpy_err_fetch.
3418
3419 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3420
3421         * linux-nat.c (delete_lwp_cleanup): Delete.
3422         (struct lwp_deleter): New struct.
3423         (lwp_info_up): New typedef.
3424         (linux_nat_target::follow_fork): Delete cleanup, and make use of
3425         lwp_info_up.
3426
3427 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3428
3429         * linux-fork.c (class scoped_switch_fork_info): New class.
3430         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
3431
3432 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3433
3434         * valops.c (find_overload_match): Remove use of null_cleanup, and
3435         calls to do_cleanups.
3436
3437 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3438
3439         * compile/compile-cplus-types.c
3440         (compile_cplus_instance::decl_name): Handle changes to
3441         cp_func_name.
3442         * cp-support.c (cp_func_name): Update header comment, update
3443         return type.
3444         * cp-support.h (cp_func_name): Update return type in declaration.
3445         * valops.c (find_overload_match): Move temp_func local to top
3446         level of function and change its type.  Use temp_func to hold and
3447         delete temporary string obtained from cp_func_name.
3448
3449 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3450
3451         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
3452         gdb::char_vector, remove cleanup, and update uses of `msg`.
3453
3454 2019-01-03  Jim Wilson  <jimw@sifive.com>
3455
3456         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
3457
3458 2019-01-02  Tom Tromey  <tom@tromey.com>
3459
3460         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
3461         (tdesc_parse_xml): Remove cleanups.
3462         * target-descriptions.h (make_cleanup_free_target_description):
3463         Don't declare.
3464         (target_desc_deleter): New struct.
3465         (target_desc_up): New typedef.
3466         * target-descriptions.c (target_desc_deleter::operator()): Rename
3467         from free_target_description.
3468         (make_cleanup_free_target_description): Remove.
3469
3470 2019-01-02  Tom Tromey  <tom@tromey.com>
3471
3472         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
3473         constructor, destructor.
3474         (linespec_parser): Remove typedef.
3475         (~linespec_parser): Rename from linespec_parser_delete.
3476         (linespec_lex_to_end, linespec_complete_label)
3477         (linespec_complete): Update.
3478         (decode_line_full): Remove cleanups.
3479         (decode_line_1): Update.
3480
3481 2019-01-02  Tom Tromey  <tom@tromey.com>
3482
3483         * python/python-internal.h (inferior_to_inferior_object): Change
3484         return type.
3485         * python/py-exitedevent.c (create_exited_event_object): Update.
3486         * python/py-inferior.c (inferior_to_inferior_object): Return
3487         gdbpy_ref.
3488         (python_new_inferior, python_inferior_deleted)
3489         (thread_to_thread_object, delete_thread_object)
3490         (build_inferior_list, gdbpy_selected_inferior): Update.
3491         * python/py-infthread.c (create_thread_object): Update.  Also fail
3492         if inferior_to_inferior_object fails.
3493
3494 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
3495
3496         * inferior.h (class inferior) <displaced_step_state>: New field.
3497         * infrun.h (struct displaced_step_state): Move here from
3498         infrun.c.  Initialize fields, add constructor.
3499         <inf>: Remove field.
3500         <reset>: New method.
3501         * infrun.c (struct displaced_step_inferior_state): Move to
3502         infrun.h.
3503         (displaced_step_inferior_states): Remove.
3504         (get_displaced_stepping_state): Adust.
3505         (displaced_step_in_progress_any_inferior): Adjust.
3506         (displaced_step_in_progress_thread): Adjust.
3507         (displaced_step_in_progress): Adjust.
3508         (add_displaced_stepping_state): Remove.
3509         (get_displaced_step_closure_by_addr): Adjust.
3510         (remove_displaced_stepping_state): Remove.
3511         (infrun_inferior_exit): Call displaced_step_state.reset.
3512         (use_displaced_stepping): Don't check for NULL.
3513         (displaced_step_prepare_throw): Call
3514         get_displaced_stepping_state.
3515         (displaced_step_fixup): Don't check for NULL.
3516         (prepare_for_detach): Don't check for NULL.
3517
3518 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3519
3520         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
3521          in case of call that did not complete.
3522
3523 2019-01-02  Andrey Utkin  <autkin@undo.io>
3524
3525         * symfile.c (find_separate_debug_file): Fix search of debug files for
3526         remote debuggee.
3527
3528 2019-01-02  Tom Tromey  <tom@tromey.com>
3529
3530         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
3531         indentation.
3532         * python/py-frame.c (frapy_older): Remove cast.
3533         (frapy_newer): Likewise.
3534         * python/py-breakpoint.c (local_setattro): Remove cast.
3535         * python/py-arch.c (archpy_name): Remove local variable.
3536         * python/py-type.c (gdbpy_lookup_type): Remove cast.
3537
3538 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
3539
3540         * unittests/basic_string_view/element_access/char/empty.cc:
3541         Fix year range in copyright header.
3542
3543 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3544
3545         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
3546         Delete.
3547         <operator==>: Update with for removed field.
3548         <hash>: Likewise.
3549         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
3550         <isa_features>: ...this.
3551         <abi_features>: New field.
3552         (riscv_isa_flen): Update comment.
3553         (riscv_abi_xlen): New declaration.
3554         (riscv_abi_flen): New declaration.
3555         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
3556         isa_features.
3557         (riscv_abi_xlen): New function.
3558         (riscv_isa_flen): Update to get answer from isa_features.
3559         (riscv_abi_flen): New function.
3560         (riscv_has_fp_abi): Update to get answer from abi_features.
3561         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
3562         xlen and flen.
3563         (riscv_call_info) <xlen, flen>: Update comment.
3564         (riscv_call_arg_struct): Remove invalid assertions
3565         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
3566         is removed.
3567         (riscv_gdbarch_init): Gather isa features and abi features
3568         separately, ensure both match on the gdbarch when reusing an old
3569         gdbarch.  Relax an error check to allow 32-bit abi float to run on
3570         a target with 64-bit float hardware.
3571
3572 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3573
3574         * source.c (search_command_helper): Stop reverse search
3575         when line 1 has been searched.
3576
3577 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3578
3579         * record-full.c (record_full_base_target::close): Rewrite
3580         record_full_core_buf_list free logic.
3581
3582 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3583
3584         * break-catch-syscall.c (print_one_catch_syscall): xfree
3585         the last text.
3586
3587 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3588
3589         * top.c (print_gdb_version): Update Copyright year in version
3590         message.
3591
3592 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3593
3594         Update copyright year range in all GDB files.
3595
3596 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
3597
3598         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
3599
3600 For older changes see ChangeLog-2018.
3601 \f
3602 Local Variables:
3603 mode: change-log
3604 left-margin: 8
3605 fill-column: 74
3606 version-control: never
3607 coding: utf-8
3608 End:
3609