gdb/ChangeLog

   1 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
   2
   3         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
   4         (print_signatures): Likewise.
   5         (trust_pad_over_xvs): Likewise.
   6         * arch/aarch64-insn.c (aarch64_debug): Likewise.
   7         * arch/aarch64-insn.h (aarch64_debug): Likewise.
   8         * arm-linux-nat.c (arm_apcs_32): Likewise.
   9         * arm-linux-tdep.c (arm_apcs_32): Likewise.
  10         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
  11         * arm-tdep.c (arm_debug): Likewise.
  12         (arm_apcs_32): Likewise.
  13         * auto-load.c (debug_auto_load): Likewise.
  14         (auto_load_gdb_scripts): Likewise.
  15         (global_auto_load): Likewise.
  16         (auto_load_local_gdbinit): Likewise.
  17         (auto_load_local_gdbinit_loaded): Likewise.
  18         * auto-load.h (global_auto_load): Likewise.
  19         (auto_load_local_gdbinit): Likewise.
  20         (auto_load_local_gdbinit_loaded): Likewise.
  21         * breakpoint.c (disconnected_dprintf): Likewise.
  22         (breakpoint_proceeded): Likewise.
  23         (automatic_hardware_breakpoints): Likewise.
  24         (always_inserted_mode): Likewise.
  25         (target_exact_watchpoints): Likewise.
  26         (_initialize_breakpoint): Update.
  27         * breakpoint.h (target_exact_watchpoints): Change to bool.
  28         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
  29         * cli/cli-cmds.c (trace_commands): Likewise.
  30         * cli/cli-cmds.h (trace_commands): Likewise.
  31         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
  32         to bool*.
  33         * cli/cli-logging.c (logging_overwrite): Change to bool.
  34         (logging_redirect): Likewise.
  35         (debug_redirect): Likewise.
  36         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
  37         (struct boolean_option_def) <get_var_address_cb_>: Change return type
  38         to bool.
  39         <boolean_option_def>: Update.
  40         (struct flag_option_def): Change default type of Context to bool
  41         from int.
  42         <flag_option_def>: Change return type of var_address_cb_ to bool*.
  43         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
  44         (get_setshow_command_value_string): Likewise.
  45         * cli/cli-style.c (cli_styling): Change to bool.
  46         (source_styling): Likewise.
  47         * cli/cli-style.h (source_styling): Likewise.
  48         (cli_styling): Likewise.
  49         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
  50         to bool.
  51         * command.h (var_types): Update comment.
  52         (add_setshow_boolean_cmd): Change int* var argument to bool*.
  53         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
  54         bool.
  55         (debug_compile_cplus_scopes): Likewise.
  56         * compile/compile-internal.h (compile_debug): Likewise.
  57         * compile/compile.c (compile_debug): Likewise.
  58         (struct compile_options) <raw>: Likewise.
  59         * cp-support.c (catch_demangler_crashes): Likewise.
  60         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
  61         (usr_cmd_cris_dwarf2_cfi): Likewise.
  62         * csky-tdep.c (csky_debug): Likewise.
  63         * darwin-nat.c (enable_mach_exceptions): Likewise.
  64         * dcache.c (dcache_enabled_p): Likewise.
  65         * defs.h (info_verbose): Likewise.
  66         * demangle.c (demangle): Likewise.
  67         (asm_demangle): Likewise.
  68         * dwarf-index-cache.c (debug_index_cache): Likewise.
  69         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
  70         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
  71         * dwarf2read.c (check_physname): Likewise.
  72         (use_deprecated_index_sections): Likewise.
  73         (dwarf_always_disassemble): Likewise.
  74         * eval.c (overload_resolution): Likewise.
  75         * event-top.c (set_editing_cmd_var): Likewise.
  76         (exec_done_display_p): Likewise.
  77         * event-top.h (set_editing_cmd_var): Likewise.
  78         (exec_done_display_p): Likewise.
  79         * exec.c (write_files): Likewise.
  80         * fbsd-nat.c (debug_fbsd_lwp): Likewise
  81         (debug_fbsd_nat): Likewise.
  82         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
  83         Likewise.
  84         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
  85         <backtrace_past_entry> Likewise.
  86         * gdb-demangle.h (demangle): Likewise.
  87         (asm_demangle): Likewise.
  88         * gdb_bfd.c (bfd_sharing): Likewise.
  89         * gdbcore.h (write_files): Likewise.
  90         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
  91         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
  92         * gdbthread.h (print_thread_events): Likewise.
  93         * gdbtypes.c (opaque_type_resolution): Likewise.
  94         (strict_type_checking): Likewise.
  95         * gnu-nat.c (gnu_debug_flag): Likewise.
  96         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
  97         * guile/scm-param.c (pascm_variable): Add boolval.
  98         (add_setshow_generic): Update.
  99         (pascm_param_value): Update.
 100         (pascm_set_param_value_x): Update.
 101         * hppa-tdep.c (hppa_debug): Change to bool..
 102         * infcall.c (may_call_functions_p): Likewise.
 103         (coerce_float_to_double_p): Likewise.
 104         (unwind_on_signal_p): Likewise.
 105         (unwind_on_terminating_exception_p): Likewise.
 106         * infcmd.c (startup_with_shell): Likewise.
 107         * inferior.c (print_inferior_events): Likewise.
 108         * inferior.h (startup_with_shell): Likewise.
 109         (print_inferior_events): Likewise.
 110         * infrun.c (step_stop_if_no_debug): Likewise.
 111         (detach_fork): Likewise.
 112         (debug_displaced): Likewise.
 113         (disable_randomization): Likewise.
 114         (non_stop): Likewise.
 115         (non_stop_1): Likewise.
 116         (observer_mode): Likewise.
 117         (observer_mode_1): Likewise.
 118         (set_observer_mode): Update.
 119         (sched_multi): Change to bool.
 120         * infrun.h (debug_displaced): Likewise.
 121         (sched_multi): Likewise.
 122         (step_stop_if_no_debug): Likewise.
 123         (non_stop): Likewise.
 124         (disable_randomization): Likewise.
 125         * linux-tdep.c (use_coredump_filter): Likewise.
 126         (dump_excluded_mappings): Likewise.
 127         * linux-thread-db.c (auto_load_thread_db): Likewise.
 128         (check_thread_db_on_load): Likewise.
 129         * main.c (captured_main_1): Update.
 130         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
 131         xx2_opt, boolean_opt>: Change to bool.
 132         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
 133         * maint.c (maintenance_profile_p): Likewise.
 134         (per_command_time): Likewise.
 135         (per_command_space): Likewise.
 136         (per_command_symtab): Likewise.
 137         * memattr.c (inaccessible_by_default): Likewise.
 138         * mi/mi-main.c (mi_async): Likewise.
 139         (mi_async_1): Likewise.
 140         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
 141         * nat/fork-inferior.h (startup_with_shell): Likewise.
 142         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
 143         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
 144         * nios2-tdep.c (nios2_debug): Likewise.
 145         * or1k-tdep.c (or1k_debug): Likewise.
 146         * parse.c (parser_debug): Likewise.
 147         * parser-defs.h (parser_debug): Likewise.
 148         * printcmd.c (print_symbol_filename): Likewise.
 149         * proc-api.c (procfs_trace): Likewise.
 150         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
 151         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
 152         (set_parameter_value): Update.
 153         (add_setshow_generic): Update.
 154         * python/py-value.c (copy_py_bool_obj): Change argument from int*
 155         to bool*.
 156         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
 157         int*.
 158         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
 159         * record-btrace.c (record_btrace_target::store_registers): Update.
 160         * record-full.c (record_full_memory_query): Change to bool.
 161         (record_full_stop_at_limit): Likewise.
 162         * record-full.h (record_full_memory_query): Likewise.
 163         * remote-notif.c (notif_debug): Likewise.
 164         * remote-notif.h (notif_debug): Likewise.
 165         * remote.c (use_range_stepping): Likewise.
 166         (interrupt_on_connect): Likewise.
 167         (remote_break): Likewise.
 168         * ser-tcp.c (tcp_auto_retry): Likewise.
 169         * ser-unix.c (serial_hwflow): Likewise.
 170         * skip.c (debug_skip): Likewise.
 171         * solib-aix.c (solib_aix_debug): Likewise.
 172         * spu-tdep.c (spu_stop_on_load_p): Likewise.
 173         (spu_auto_flush_cache_p): Likewise.
 174         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
 175         Likewise.
 176         (struct info_print_options) <quiet>: Likewise.
 177         * symfile-debug.c (debug_symfile): Likewise.
 178         * symfile.c (auto_solib_add): Likewise.
 179         (separate_debug_file_debug): Likewise.
 180         * symfile.h (auto_solib_add): Likewise.
 181         (separate_debug_file_debug): Likewise.
 182         * symtab.c (basenames_may_differ): Likewise.
 183         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
 184         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
 185         (struct info_types_options) <quiet>: Likewise.
 186         * symtab.h (demangle): Likewise.
 187         (basenames_may_differ): Likewise.
 188         * target-dcache.c (stack_cache_enabled_1): Likewise.
 189         (code_cache_enabled_1): Likewise.
 190         * target.c (trust_readonly): Likewise.
 191         (may_write_registers): Likewise.
 192         (may_write_memory): Likewise.
 193         (may_insert_breakpoints): Likewise.
 194         (may_insert_tracepoints): Likewise.
 195         (may_insert_fast_tracepoints): Likewise.
 196         (may_stop): Likewise.
 197         (auto_connect_native_target): Likewise.
 198         (target_stop_and_wait): Update.
 199         (target_async_permitted): Change to bool.
 200         (target_async_permitted_1): Likewise.
 201         (may_write_registers_1): Likewise.
 202         (may_write_memory_1): Likewise.
 203         (may_insert_breakpoints_1): Likewise.
 204         (may_insert_tracepoints_1): Likewise.
 205         (may_insert_fast_tracepoints_1): Likewise.
 206         (may_stop_1): Likewise.
 207         * target.h (target_async_permitted): Likewise.
 208         (may_write_registers): Likewise.
 209         (may_write_memory): Likewise.
 210         (may_insert_breakpoints): Likewise.
 211         (may_insert_tracepoints): Likewise.
 212         (may_insert_fast_tracepoints): Likewise.
 213         (may_stop): Likewise.
 214         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
 215         (make_thread_apply_all_options_def_group): Change argument from int*
 216         to bool*.
 217         (thread_apply_all_command): Update.
 218         (print_thread_events): Change to bool.
 219         * top.c (confirm): Likewise.
 220         (command_editing_p): Likewise.
 221         (history_expansion_p): Likewise.
 222         (write_history_p): Likewise.
 223         (info_verbose): Likewise.
 224         * top.h (confirm): Likewise.
 225         (history_expansion_p): Likewise.
 226         * tracepoint.c (disconnected_tracing): Likewise.
 227         (circular_trace_buffer): Likewise.
 228         * typeprint.c (print_methods): Likewise.
 229         (print_typedefs): Likewise.
 230         * utils.c (debug_timestamp): Likewise.
 231         (sevenbit_strings): Likewise.
 232         (pagination_enabled): Likewise.
 233         * utils.h (sevenbit_strings): Likewise.
 234         (pagination_enabled): Likewise.
 235         * valops.c (overload_resolution): Likewise.
 236         * valprint.h (struct value_print_options) <prettyformat_arrays,
 237         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
 238         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
 239         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
 240         Likewise.
 241         * windows-nat.c (new_console): Likewise.
 242         (cygwin_exceptions): Likewise.
 243         (new_group): Likewise.
 244         (debug_exec): Likewise.
 245         (debug_events): Likewise.
 246         (debug_memory): Likewise.
 247         (debug_exceptions): Likewise.
 248         (useshell): Likewise.
 249         * windows-tdep.c (maint_display_all_tib): Likewise.
 250         * xml-support.c (debug_xml): Likewise.
 251
 252 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
 253
 254         * source.c (prepare_path_for_appending): New function.
 255         (openp): Make use of new function.
 256         (find_and_open_source): Search for the compilation directory and
 257         source file as a relative path beneath the directory search path.
 258
 259 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 260
 261         * source-cache.c (source_cache::get_line_charpos): Catch
 262         exceptions and return false, this matches the behaviour documented
 263         in the header file.
 264
 265 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
 266
 267         * ada-tasks.c (info_task): Remove quoting of the task's name.
 268
 269 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
 270
 271         * symfile.c (auto_solib_add): Replace comment with a reference
 272         to the header file.
 273
 274 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
 275
 276         * NEWS: Mention that gdb can now be compiled with Python 3
 277         on Windows.
 278
 279 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 280
 281         * maint.c (maint_print_section_data::maint_print_section_data):
 282         Force use of 'float log10 (float)' by casting the argument to
 283         float.
 284
 285 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 286
 287         * maint.c: Add 'cmath' include.
 288         (struct maint_print_section_data): New structure.
 289         (print_section_index): New function.
 290         (print_bfd_section_info): Add header comment, small whitespace
 291         cleanup, and update to call new print_section_index function.
 292         (print_objfile_section_info): Likewise.
 293         (maint_obj_section_from_bfd_section): New function.
 294         (print_bfd_section_info_maybe_relocated): New function.
 295         (maintenance_info_sections): Add header comment, always use
 296         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
 297
 298 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 299
 300         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
 301         inner scope, add check that the objfile has psymtabs before
 302         checking psymtabs_addrmap.
 303         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
 304
 305 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 306
 307         * NEWS: Announce that Ada task names are now shown at more places,
 308         and between quotes (except in info task output).
 309         * gdb/ada-tasks.c (task_to_str): New function.
 310         (display_current_task_id): Call task_to_str.
 311         (task_command_1): Likewise.
 312         (print_ada_task_info): In non-mi mode, Properly align headers and data
 313         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
 314
 315 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 316
 317         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
 318         prstatus.pr_lwp.pr_info instead of making it up.
 319
 320 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 321
 322         * auto-load.c (auto_load_expand_dir_vars): Update.
 323         * defs.h (gdb_datadir): Change to std::string.
 324         (python_libdir): Likewise.
 325         (relocate_gdb_directory): Change return type to std::string.
 326         * guile/guile.c (gdbscm_data_directory): Update.
 327         (initialize_scheme_side): Update.
 328         * jit.c (jit_reader_dir): Change to std::string.
 329         (jit_reader_load_command): Update.
 330         * main.c (gdb_datadir): Change to std::string.
 331         (python_libdir): Likewise.
 332         (set_gdb_data_directory): Update.
 333         (relocate_path): Change to return std::string.
 334         (relocate_gdb_directory): Change to return std::string.
 335         (relocate_gdbinit_path_maybe_in_datadir): Update.
 336         (captured_main_1): Update.
 337         * python/python.c (do_start_initialization): Update.
 338         * top.c (show_gdb_datadir): Update.
 339         * xml-syscall.c (xml_init_syscalls_info): Update.
 340         (init_syscalls_info): Update.
 341
 342 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 343
 344         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
 345         out of get_init_files.
 346         (get_init_files): Update.
 347
 348 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 349
 350         * main.c (get_init_files): Change to use std::string.
 351         (captured_main_1): Update.
 352         (print_gdb_help): Update.
 353
 354 2019-09-11  Ali Tamur  <tamur@google.com>
 355
 356         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
 357         implementation.
 358
 359 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 360
 361         * dbxread.c (read_dbx_symtab): Update.
 362         * dwarf2read.c (load_partial_dies): Update.
 363         * mdebugread.c (parse_partial_symbols): Update.
 364         (handle_psymbol_enumerators): Update.
 365         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
 366         * psymtab.c (add_psymbol_to_bcache): Likewise.
 367         (add_psymbol_to_list): Likewise.
 368         * symtab.c (symbol_set_names): Likewise.
 369         * symtab.h (symbol_set_names): Likewise.
 370         * xcoffread.c (scan_xcoff_symtab): Update.
 371
 372 2019-09-11  Tom Tromey  <tom@tromey.com>
 373
 374         * symfile-mem.c (symbol_file_add_from_memory): Use
 375         bfd_set_filename.
 376         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
 377         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
 378
 379 2019-09-10  Tom Tromey  <tromey@adacore.com>
 380
 381         * dwarf-index-write.c (write_psymbols): Extend error message.
 382         (debug_names::insert): Add Ada code.
 383         (debug_names::write_psymbols): Remove Ada check.
 384         (debug_names) <m_string_obstack>: New member.
 385         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
 386         (gdb_index_symbol_name_matcher::matches): Remove.
 387         (mapped_index_base::find_name_components_bounds): Add "lang"
 388         parameter.
 389         (mapped_index_base::build_name_components): Also split names
 390         according to Ada syntax.
 391         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
 392         type of "match_callback".
 393         (check_match, check_find_bounds_finds)
 394         (dw2_expand_symtabs_matching): Update.
 395         (dw2_debug_names_iterator): Add new constructor.
 396         (dw2_debug_names_map_matching_symbols): New function.
 397         (dw2_debug_names_expand_symtabs_matching): Update.
 398         (dwarf2_debug_names_functions): Use
 399         dw2_debug_names_map_matching_symbols.
 400
 401 2019-09-10  Tom Tromey  <tromey@adacore.com>
 402
 403         * dwarf2read.c (dw2_get_file_names_reader): Add the
 404         CU's file name to the results.
 405
 406 2019-09-10  Tom Tromey  <tromey@adacore.com>
 407
 408         * ada-lang.c (add_nonlocal_symbols): Combine calls to
 409         map_matching_symbols.  Update.
 410         * dwarf2read.c (dw2_map_matching_symbols): Update.
 411         * psymtab.c (match_partial_symbol): Change type; update.
 412         (psym_map_matching_symbols): Likewise.
 413         * symfile-debug.c (debug_qf_map_matching_symbols): Change
 414         type; update.
 415         * symfile.h (struct quick_symbol_functions)
 416         <map_matching_symbols>: Change "name" to be a lookup_name_info.
 417         Remove "match".
 418
 419 2019-09-10  Tom Tromey  <tromey@adacore.com>
 420
 421         * psymtab.c (map_block): Remove.
 422         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
 423         * symtab.c (iterate_over_symbols_terminated): New function.
 424         * symtab.c (iterate_over_symbols_terminated): Declare.
 425
 426 2019-09-10  Tom Tromey  <tromey@adacore.com>
 427
 428         * ada-lang.c (ada_iterate_over_symbols): Return bool.
 429         * language.h (struct language_defn) <la_iterate_over_symbols>:
 430         Return bool.
 431         * symtab.c (iterate_over_symbols): Return bool.
 432         * symtab.h (iterate_over_symbols): Return bool.
 433
 434 2019-09-10  Tom Tromey  <tromey@adacore.com>
 435
 436         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
 437         (add_nonlocal_symbols): Update.
 438         * dwarf2read.c (dw2_map_matching_symbols): Change type.
 439         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
 440         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
 441         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
 442         Change type of "callback".  Remove "data".
 443
 444
 445 2019-09-09  Ali Tamur  <tamur@google.com>
 446
 447         * dwarf2read.c (comp_unit_head): Update comment.
 448         (dwarf2_dwo_name): New function declaration.
 449         (dwarf_unit_type_name): New function declaration.
 450         (read_comp_unit_head): Add support for new compilation units,
 451         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
 452         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
 453         (currently named as "signature") in their header. Also clarify error
 454         messages.
 455         (lookup_dwo_id): New function. Returns the dwo id of the given
 456         compile unit.
 457         (lookup_dwo_unit): Use the new lookup_dwo_id function.
 458         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
 459         functions.
 460         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
 461         (dwarf2_dwo_name): Get the dwo name if present.
 462         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
 463         purposes.
 464
 465 2019-09-09  Tom Tromey  <tom@tromey.com>
 466
 467         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
 468
 469 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 470
 471         * python/python.c (do_start_initialization): Make progname_copy static,
 472         to avoid a leak report.
 473
 474 2019-09-08  Tom Tromey  <tom@tromey.com>
 475
 476         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
 477
 478 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
 479
 480         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
 481         Change type to gdb::optional<block_enum>.
 482         (dw2_symtab_iter_init): Change block_index parameter type
 483         to gdb::optional<block_enum>.
 484         (dw2_lookup_symbol): Change block_index parameter
 485         type to block_enum.c
 486         (dw2_debug_names_lookup_symbol): Likewise.
 487         * psymtab.c (psym_lookup_symbol): Likewise.
 488         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
 489         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
 490         Likewise.
 491
 492 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
 493
 494         * defs.h (relocate_gdb_directory): Change int to bool in
 495         signature and rename flag to relocatable.
 496         * main.c (relocate_path): Likewise.
 497         (relocate_gdb_directory): Likewise.
 498
 499 2019-09-06  Alan Modra  <amodra@gmail.com>
 500
 501         * coffread.c (coff_symfile_read): Constify filename variable.
 502         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
 503         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
 504         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
 505         * solib.c (reload_shared_libraries_1): Likewise.
 506         * symfile.c (reread_symbols): Likewise.
 507         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
 508         * solib-darwin.c (darwin_bfd_open): Likewise.
 509         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
 510
 511 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 512
 513         * psymtab.c (print_partial_symbols): Handle missing domain_enum
 514         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
 515
 516 2019-09-03  Tom Tromey  <tromey@adacore.com>
 517
 518         * ada-valprint.c (ada_val_print_num): Don't recurse for range
 519         types.
 520         (has_negatives): Unbias a range type bound.
 521         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
 522         * gdbtypes.c (operator==): Handle new field.
 523         (create_range_type): Add "bias" parameter.
 524         (create_static_range_type, resolve_dynamic_range): Update.
 525         * gdbtypes.h (struct range_bounds) <bias>: New member.
 526         (create_range_type): Add bias parameter.
 527         * printcmd.c (print_scalar_formatted): Unbias range types.
 528         * value.c (unpack_long): Unbias range types.
 529         (pack_long): Bias range types.
 530
 531 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 532
 533         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
 534         probe arguments.
 535
 536 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 537
 538         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
 539         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
 540         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
 541         (compile_probe_arg): Likewise.
 542         * probe.h (get_argument_count): Likewise.
 543         * solib-svr4.c (solib_event_probe_action): Likewise.
 544         * stap-probe.c (stap_probe::get_argument_count): Likewise.
 545
 546 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 547
 548         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
 549         code to here...
 550         (svr4_create_solib_event_breakpoints): ...from here.
 551
 552 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
 553
 554         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
 555         suffix from warning message.
 556
 557 2019-08-30  Tom Tromey  <tom@tromey.com>
 558
 559         * tui/tui-winsource.h (struct tui_source_window_base)
 560         <refresh_all>: Don't declare.
 561         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
 562         Remove.
 563         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
 564         tui_show_locator_content.
 565         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
 566         declare.
 567         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
 568         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
 569         declare.
 570
 571 2019-08-30  Tom Tromey  <tom@tromey.com>
 572
 573         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
 574
 575 2019-08-30  Tom Tromey  <tom@tromey.com>
 576
 577         * tui/tui-stack.c (_initialize_tui_stack): Move later.
 578         Remove unnecessary forward declarations.
 579
 580 2019-08-30  Tom Tromey  <tom@tromey.com>
 581
 582         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
 583         rerender.
 584         (tui_update_locator_fullname, tui_show_frame_info): Don't call
 585         tui_show_locator_content.
 586
 587 2019-08-30  Tom Tromey  <tom@tromey.com>
 588
 589         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
 590         (tui_locator_window::rerender): Rewrite using body of previous
 591         tui_show_locator_content.
 592
 593 2019-08-30  Tom Tromey  <tom@tromey.com>
 594
 595         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
 596         set_locator_fullname>: New methods.
 597         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
 598         Rename from tui_set_locator_fullname.
 599         (tui_locator_window::set_locator_info): Rename from
 600         tui_set_locator_info.  Return bool.
 601         (tui_update_locator_fullname, tui_show_frame_info): Update.
 602
 603 2019-08-30  Tom Tromey  <tom@tromey.com>
 604
 605         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
 606
 607 2019-08-30  Tom Tromey  <tom@tromey.com>
 608
 609         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
 610         call touchwin.
 611
 612 2019-08-30  Tom Tromey  <tom@tromey.com>
 613
 614         * tui/tui-wingeneral.c (box_win): Assume win_info and
 615         win_info->handle cannot be NULL.
 616
 617 2019-08-30  Tom Tromey  <tom@tromey.com>
 618
 619         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
 620         refresh_window>: Declare.
 621         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
 622         resize.
 623         (tui_data_item_window::rerender): Rename from
 624         tui_display_register.
 625         (tui_data_item_window::refresh_window): New method.
 626         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
 627         no-op.
 628
 629 2019-08-30  Tom Tromey  <tom@tromey.com>
 630
 631         * tui/tui-regs.h (struct tui_data_window) <regs_content,
 632         regs_column_count, current_group>: Move later.  Now private.
 633         <get_current_group>: New method.
 634         * tui/tui-regs.c (tui_reg_command): Update.
 635         * tui/tui-layout.c (tui_set_layout): Update.
 636
 637 2019-08-30  Tom Tromey  <tom@tromey.com>
 638
 639         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 640         (tui_data_window::rerender): Don't call
 641         check_and_display_highlight_if_needed.
 642         (tui_data_window::refresh_all): Remove call to
 643         erase_data_content.
 644
 645 2019-08-30  Tom Tromey  <tom@tromey.com>
 646
 647         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 648         (tui_data_window::display_registers_from)
 649         (tui_data_window::display_reg_element_at_line)
 650         (tui_data_window::display_registers_from_line): Remove checks of
 651         "empty".
 652
 653 2019-08-30  Tom Tromey  <tom@tromey.com>
 654
 655         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
 656         Don't declare.
 657         * tui/tui-regs.c (tui_data_window::show_registers): Call
 658         rerender.
 659         (tui_data_window::rerender): Rename from display_all_data.
 660         (tui_data_window::rerender): Remove old implementation.
 661
 662 2019-08-30  Tom Tromey  <tom@tromey.com>
 663
 664         * tui/tui-regs.c (tui_data_window::display_all_data): Change
 665         text.
 666         * tui/tui-data.h (NO_DATA_STRING): Remove define.
 667
 668 2019-08-29  Bernhard Wodok  <barto@gmx.net>
 669             Sergio Durigan Junior  <sergiodj@redhat.com>
 670
 671         PR win32/24284
 672         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
 673
 674 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 675
 676         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
 677         when searching for types.
 678
 679 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 680
 681         * f-lang.c (f_language_defn): Use f_print_typedef.
 682         * f-lang.h (f_print_typedef): Declare.
 683         * f-typeprint.c (f_print_typedef): Define.
 684
 685 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
 686
 687         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
 688
 689 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 690
 691         * cli/cli-utils.c (info_print_options_defs): Delete.
 692         (make_info_print_options_def_group): Delete.
 693         (extract_info_print_options): Delete.
 694         (info_print_command_completer): Delete.
 695         (info_print_args_help): Add extra parameter, and optionally
 696         include text about -n flag.
 697         * cli/cli-utils.h (struct info_print_options): Delete.
 698         (extract_info_print_options): Delete declaration.
 699         (info_print_command_completer): Delete declaration.
 700         (info_print_args_help): Add extra parameter, extend header
 701         comment.
 702         * python/python.c (gdbpy_rbreak): Pass additional parameter to
 703         search_symbols.
 704         * stack.c (struct info_print_options): New type.
 705         (info_print_options_defs): New file scoped variable.
 706         (make_info_print_options_def_group): New static function.
 707         (info_print_command_completer): New static function.
 708         (info_locals_command): Update to use new local functions.
 709         (info_args_command): Likewise.
 710         (_initialize_stack): Add extra parameter to calls to
 711         info_print_args_help.
 712         * symtab.c (search_symbols): Add extra parameter, use this to
 713         possibly excluse non-debug symbols.
 714         (symtab_symbol_info): Add extra parameter, which is passed on to
 715         search_symbols.
 716         (struct info_print_options): New type.
 717         (info_print_options_defs): New file scoped variable.
 718         (make_info_print_options_def_group): New static function.
 719         (info_print_command_completer): New static function.
 720         (info_variables_command): Update to use local functions, and pass
 721         extra parameter through to symtab_symbol_info.
 722         (info_functions_command): Likewise.
 723         (info_types_command): Pass additional argument through to
 724         symtab_symbol_info.
 725         (rbreak_command): Pass extra argument to search_symbols.
 726         (_initialize_symtab): Add extra arguments for calls to
 727         info_print_args_help, and update help text for 'info variables',
 728         'whereis', and 'info functions' commands.
 729         * symtab.h (search_symbols): Add extra argument to declaration.
 730         * NEWS: Mention new flags.
 731
 732 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
 733
 734         * symtab.c (lookup_static_symbol): Call the new function (and move
 735         it down to be next to lookup_global_symbol).
 736         (struct global_sym_lookup_data): Add block_enum member and rename to...
 737         (struct global_or_static_sym_lookup_data): ...this.
 738         (lookup_symbol_global_iterator_cb): Pass block_index instead of
 739         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
 740         (lookup_symbol_global_or_static_iterator_cb): ...this.
 741         (lookup_global_or_static_symbol): New function.
 742         (lookup_global_symbol): Call new function.
 743
 744 2019-08-26  Tom de Vries  <tdevries@suse.de>
 745
 746         PR c++/24852
 747         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
 748         when pc_probe.prob == NULL.
 749
 750 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 751
 752         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
 753         variable symbol_linkage to symbol_linkage_.
 754
 755 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 756
 757         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
 758         represent whether the symbol is static, dynamic, or we don't
 759         know.
 760
 761 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
 762
 763         * gdb/rx-tdep.c (rx_register_names): New.
 764         (rx_register_name): Delete.
 765         (rx_psw_type): Delete.
 766         (rx_fpsw_type): Delete.
 767         (rx_register_type): Delete.
 768         (rx_gdbarch_init): Convert target-descriptions.
 769         (_initialize_rx_tdep): Add initialize_tdesc_rx.
 770         * gdb/features/Makefile: Add rx.xml.
 771         * gdb/features/rx.xml: New.
 772         * gdb/features/rx.c: Generated.
 773         * gdb/NEWS: Mention target description support.
 774
 775 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 776
 777         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
 778         *slot_ptr.
 779
 780 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 781
 782         * configure.ac: Don't check for 'dlfcn.h' (moved to
 783         gdbsupport/common.m4).
 784         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
 785         'gdbsupport/'.
 786         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
 787         * compile/compile-c-support.c: Include
 788         'gdbsupport/gdb-dlfcn.h'.
 789         * gdbsupport/common.m4: Check for 'dlfcn.h'.
 790         * gdb-dlfcn.c: Move to...
 791         * gdbsupport/gdb-dlfcn.c: ... here.
 792         * gdb-dlfcn.h: Move to...
 793         * gdbsupport/gdb-dlfcn.h: ... here.
 794
 795 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
 796
 797         * nios2-tdep.c (struct reg_value): Improve comments.  Make
 798         the offset field signed.
 799
 800 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 801
 802         * python/lib/gdb/__init__.py (_execute_file): New function.
 803         * python/python.c (python_run_simple_file): Call gdb._execute_file
 804         on Windows.
 805
 806 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 807
 808         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
 809         all uses as this was never set to anything but a zero value.
 810
 811 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
 812
 813         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
 814
 815 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
 816
 817         * tui/tui-data.h (tui_gen_win_info): Add an =default
 818         move constructor, required by some GCC versions.
 819
 820 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
 821
 822         * go32-nat.c (go32_sysinfo): Add hygon_p.
 823
 824 2019-08-20  Tom Tromey  <tom@tromey.com>
 825
 826         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
 827         line_from_reg_element_no, first_reg_element_no_inline,
 828         display_all_data, delete_data_content_windows,
 829         erase_data_content>: Now private.
 830
 831 2019-08-20  Tom Tromey  <tom@tromey.com>
 832
 833         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
 834         (tui_unhighlight_win, tui_highlight_win)
 835         (tui_win_info::make_window): Update.
 836         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
 837
 838 2019-08-20  Tom Tromey  <tom@tromey.com>
 839
 840         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 841         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 842         (MAX_PID_WIDTH): Move to tui-stack.c.
 843         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 844         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 845         (MAX_PID_WIDTH): Move from tui-data.h.
 846
 847 2019-08-20  Tom Tromey  <tom@tromey.com>
 848
 849         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
 850         * tui/tui-wingeneral.c (box_win): Change type of win_info.
 851         (box_win): Update.
 852         (tui_gen_win_info::make_window): Rename from tui_make_window.
 853         (tui_win_info::make_window): New method.
 854         (tui_gen_win_info::make_visible): Update.
 855         * tui/tui-source.c (tui_source_window::set_contents): Update.
 856         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
 857         (tui_data_window::display_registers_from): Update.
 858         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 859         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
 860         Declare.
 861         <can_box>: Remove.
 862         <title>: Remove.
 863         (struct tui_win_info) <make_window>: Declare.
 864         <can_box>: Now virtual.
 865         <title>: New member.
 866         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
 867         * tui/tui-command.c (tui_cmd_window::resize): Update.
 868
 869 2019-08-20  Tom Tromey  <tom@tromey.com>
 870
 871         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
 872         * tui/tui-regs.c (tui_data_window::show_registers): Update.
 873         (tui_data_window::check_register_values): Update.
 874
 875 2019-08-20  Tom Tromey  <tom@tromey.com>
 876
 877         * tui/tui-regs.h (struct tui_data_window): Use
 878         DISABLE_COPY_AND_ASSIGN.
 879         <regs_content>: Change type, removing unique_ptr.
 880         <tui_data_window>: Add move constructor.
 881         * tui/tui-regs.c (tui_data_window::show_registers)
 882         (tui_data_window::show_register_group)
 883         (tui_data_window::display_registers_from)
 884         (tui_data_window::display_registers_from)
 885         (tui_data_window::first_data_item_displayed)
 886         (tui_data_window::delete_data_content_windows)
 887         (tui_data_window::rerender, tui_data_window::refresh_window)
 888         (tui_data_window::check_register_values): Update.
 889
 890 2019-08-20  Tom Tromey  <tom@tromey.com>
 891
 892         * tui/tui-regs.h (struct tui_data_window) <show_registers,
 893         show_register_group>: Declare.
 894         (tui_show_register_group): Don't declare.
 895         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
 896         tui_show_registers.
 897         (tui_data_window::show_register_group): Rename from
 898         tui_show_register_group.
 899         (tui_data_window::check_register_values, tui_reg_command):
 900         Update.
 901         * tui/tui-layout.c (tui_set_layout): Update.
 902
 903 2019-08-20  Tom Tromey  <tom@tromey.com>
 904
 905         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
 906         Declare.
 907         (tui_check_register_values): Don't declare.
 908         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
 909         from tui_check_register_values.
 910         * tui/tui-hooks.c (tui_register_changed): Update.
 911
 912 2019-08-20  Tom Tromey  <tom@tromey.com>
 913
 914         * tui/tui-regs.c (tui_reg_layout): Move later.
 915         (tui_show_registers): Don't enable TUI mode or change layout.
 916
 917 2019-08-20  Tom Tromey  <tom@tromey.com>
 918
 919         * tui/tui-regs.h (struct tui_data_item_window)
 920         <~tui_data_item_window>: Remove.
 921         <content>: Now a unique_xmalloc_ptr.
 922         * tui/tui-regs.c (tui_register_format): Return a
 923         unique_xmalloc_ptr.
 924         (tui_get_register): Update.
 925         (~tui_data_item_window): Remove.
 926         (tui_data_window::display_registers_from, tui_display_register):
 927         Update.
 928         * tui/tui-io.h (tui_expand_tabs): Update.
 929         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
 930         Remove "col" parameter.
 931
 932 2019-08-20  Tom Tromey  <tom@tromey.com>
 933
 934         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
 935         field.
 936         * tui/tui-regs.c (~tui_data_item_window): Update.
 937
 938 2019-08-20  Tom Tromey  <tom@tromey.com>
 939
 940         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
 941         earlier.
 942
 943 2019-08-20  Tom Tromey  <tom@tromey.com>
 944
 945         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
 946
 947 2019-08-20  Tom Tromey  <tom@tromey.com>
 948
 949         * tui/tui-source.h (struct tui_source_window): Update.
 950         * tui/tui-regs.c (tui_show_registers): Update.
 951         * tui/tui-disasm.h (struct tui_disasm_window): Update.
 952         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
 953         (NO_REGS_STRING): Remove defines.
 954
 955 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
 956
 957         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
 958         unnecessary thread walk if remote doesn't support the packet.
 959
 960 2019-08-19  Tom Tromey  <tromey@adacore.com>
 961
 962         * python/py-value.c (value_has_field): Fix indentation.
 963
 964 2019-08-19  Tom Tromey  <tromey@adacore.com>
 965
 966         * printcmd.c (do_one_display, info_display_command): Update.
 967         * block.h (contained_in): Return bool.  Add allow_nested
 968         parameter.
 969         * block.c (contained_in): Return bool.  Add allow_nested
 970         parameter.
 971
 972 2019-08-19  Tom Tromey  <tom@tromey.com>
 973
 974         * configure: Rebuild.
 975         * configure.ac: Disallow the combination of -static-libstdc++ and
 976         source highlight.
 977         * source-cache.c (get_language_name): Handle rust.
 978         (source_cache::get_source_lines): Ignore highlighting exceptions.
 979
 980 2019-08-16  Tom Tromey  <tom@tromey.com>
 981
 982         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
 983         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
 984         (struct tui_source_window_base) <make_visible, refresh_window,
 985         resize>: Remove methods.
 986         <execution_info>: Remove field.
 987         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
 988         (tui_show_source_line, tui_source_window_base)
 989         (~tui_source_window_base): Update.
 990         (tui_source_window_base::resize)
 991         (tui_source_window_base::make_visible)
 992         (tui_source_window_base::refresh_window): Remove.
 993         (tui_source_window_base::update_exec_info): Update.
 994         * tui/tui-source.c (tui_source_window::set_contents): Update.
 995         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 996
 997 2019-08-16  Tom Tromey  <tom@tromey.com>
 998
 999         * tui/tui-hooks.c (tui_remove_hooks): Don't set
1000         deprecated_query_hook.
1001
1002 2019-08-16  Tom Tromey  <tom@tromey.com>
1003
1004         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1005         (tui_update_source_windows_with_line): Update.
1006         * tui/tui-source.h (struct tui_source_window)
1007         <show_symtab_source>: Declare.
1008         (tui_show_symtab_source): Don't declare.
1009         * tui/tui-source.c (tui_show_symtab_source): Rename from
1010         tui_show_symtab_source.
1011
1012 2019-08-16  Tom Tromey  <tom@tromey.com>
1013
1014         * tui/tui-winsource.h (struct tui_source_window_base)
1015         <set_contents>: Declare.
1016         * tui/tui-winsource.c
1017         (tui_source_window_base::update_source_window_as_is): Update.
1018         * tui/tui-source.h (struct tui_source_window) <set_contents>:
1019         Declare.
1020         (tui_set_source_content): Don't declare.
1021         * tui/tui-source.c (tui_source_window::set_contents): Rename from
1022         tui_set_source_content.
1023         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
1024         Declare.
1025         (tui_set_disassem_content): Don't declare.
1026         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
1027         tui_set_disassem_content.
1028
1029 2019-08-16  Tom Tromey  <tom@tromey.com>
1030
1031         * tui/tui-winsource.h (struct tui_source_window_base)
1032         <update_breakpoint_info>: Declare.
1033         (tui_update_breakpoint_info): Don't declare.
1034         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
1035         (tui_update_all_breakpoint_info): Update.
1036         (tui_source_window_base::update_breakpoint_info): Rename from
1037         tui_update_breakpoint_info.
1038         (tui_source_window_base::update_exec_info): Update.
1039
1040 2019-08-16  Tom Tromey  <tom@tromey.com>
1041
1042         * tui/tui-winsource.h (struct tui_source_window_base)
1043         <update_source_window>: Declare.
1044         (tui_update_source_window): Don't declare.
1045         * tui/tui-winsource.c
1046         (tui_source_window_base::update_source_window): Rename from
1047         tui_update_source_window.
1048         (tui_source_window_base::rerender): Update.
1049         * tui/tui-source.c (tui_source_window::maybe_update): Update.
1050         * tui/tui-disasm.c (tui_show_disassem)
1051         (tui_show_disassem_and_update_source)
1052         (tui_disasm_window::maybe_update): Update.
1053
1054 2019-08-16  Tom Tromey  <tom@tromey.com>
1055
1056         * tui/tui-winsource.h (struct tui_source_window_base)
1057         <update_source_window_as_is>: Declare.
1058         (tui_update_source_window_as_is): Don't declare.
1059         * tui/tui-winsource.c (tui_update_source_window): Update
1060         (tui_source_window_base::update_source_window_as_is): Rename from
1061         tui_update_source_window_as_is.
1062         (tui_source_window_base::refill): Update.
1063         * tui/tui-source.c (tui_show_symtab_source): Update.
1064         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
1065         Update.
1066
1067 2019-08-16  Tom Tromey  <tom@tromey.com>
1068
1069         * tui/tui-winsource.h (tui_update_source_window)
1070         (tui_update_source_window_as_is): Remove "noerror" parameter.
1071         * tui/tui-winsource.c (tui_update_source_window)
1072         (tui_update_source_window_as_is): Remove "noerror" parameter.
1073         (tui_update_source_windows_with_addr)
1074         (tui_update_source_windows_with_line)
1075         (tui_source_window_base::rerender)
1076         (tui_source_window_base::refill): Update.
1077         * tui/tui-source.h (tui_set_source_content)
1078         (tui_show_symtab_source): Remove "noerror" parameter.
1079         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
1080         parameter.
1081         (tui_show_symtab_source): Likewise.
1082         (tui_source_window::maybe_update): Update.
1083         * tui/tui-disasm.c (tui_show_disassem)
1084         (tui_show_disassem_and_update_source)
1085         (tui_disasm_window::do_scroll_vertical)
1086         (tui_disasm_window::maybe_update): Update.
1087
1088 2019-08-16  Tom Tromey  <tom@tromey.com>
1089
1090         * tui/tui.c (tui_is_window_visible): Update.
1091         * tui/tui-wingeneral.c (tui_make_window)
1092         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
1093         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
1094         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
1095         (tui_set_win_height_command, parse_scrolling_args): Update.
1096         * tui/tui-source.c (tui_source_window::style_changed): Update.
1097         * tui/tui-regs.c (tui_show_registers)
1098         (tui_data_window::first_data_item_displayed)
1099         (tui_data_window::delete_data_content_windows)
1100         (tui_check_register_values, tui_reg_command): Update.
1101         * tui/tui-disasm.c (tui_show_disassem): Update.
1102         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
1103         method.
1104         <is_visible>: Remove field.
1105         * tui/tui-data.c (tui_next_win, tui_prev_win)
1106         (tui_delete_invisible_windows): Update.
1107
1108 2019-08-16  Tom Tromey  <tom@tromey.com>
1109
1110         * tui/tui-winsource.h (struct tui_source_window_base)
1111         <m_has_locator>: Remove.
1112         * tui/tui-layout.c (show_source_disasm_command, show_data)
1113         (show_source_or_disasm_and_command): Update.
1114
1115 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
1116
1117         * NEWS (Other MI changes): New subsection.
1118         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
1119         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
1120         * arch-utils.c (default_get_pc_address_flags): New function.
1121         * arch-utils.h (default_get_pc_address_flags): New declaration.
1122         * gdbarch.sh: Add get_pc_address_flags.
1123         * gdbarch.c: Regenerate.
1124         * gdbarch.h: Likewise.
1125         * stack.c (print_pc): New function.
1126         (print_frame_info) (print_frame): Call print_pc.
1127
1128 2019-08-16  Tom de Vries  <tdevries@suse.de>
1129
1130         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
1131         print_objfile_section_info.
1132
1133 2019-08-15  Tom Tromey  <tom@tromey.com>
1134
1135         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
1136         calling update_cmdwin_start_line.
1137         * tui/tui-winsource.h (struct tui_source_window_base)
1138         <do_make_visible_with_new_height, set_new_height>: Don't declare.
1139         <rerender>: Declare.
1140         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
1141         Call rerender.
1142         (tui_source_window_base::set_new_height): Remove.
1143         (tui_source_window_base::rerender): Rename from
1144         do_make_visible_with_new_height.
1145         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
1146         resize method.
1147         (tui_win_info::make_invisible_and_set_new_height)
1148         (tui_win_info::make_visible_with_new_height): Remove.
1149         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
1150         Declare.
1151         * tui/tui-stack.c (tui_locator_window::rerender): New method.
1152         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
1153         do_make_visible_with_new_height>: Don't declare.
1154         <rerender>: Declare.
1155         * tui/tui-regs.c (tui_data_window::rerender): Rename from
1156         set_new_height.
1157         (tui_data_window::do_make_visible_with_new_height): Remove.
1158         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
1159         call tui_show_locator_content.
1160         (tui_gen_win_info::resize): Call rerender.
1161         (show_source_or_disasm_and_command): Don't call
1162         tui_show_locator_content.
1163         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
1164         method.
1165         (struct tui_win_info) <rerender>: Declare.
1166         <set_new_height, make_invisible_and_set_new_height,
1167         make_visible_with_new_height>: Don't declare.
1168         * tui/tui-data.c (tui_win_list::rerender): New method.
1169         * tui/tui-command.h (struct tui_cmd_window)
1170         <do_make_visible_with_new_height>: Don't declare.
1171         * tui/tui-command.c
1172         (tui_cmd_window::do_make_visible_with_new_height): Remove.
1173
1174 2019-08-15  Tom Tromey  <tromey@adacore.com>
1175
1176         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
1177         * ada-lang.c (ada_enum_name): Likewise.
1178
1179 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
1180
1181         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
1182         leading underscore.
1183         (GdbOutputErrorFile): Likewise.
1184         (global scope): Adjust constructor calls to GdbOutput{,Error}File
1185         accordingly.
1186         (execute_unwinders): Rename to have a leading underscore.
1187         (auto_load_packages): Likewise.
1188         (global scope): Adjust call to auto_load_packages accordingly.
1189         (GdbSetPythonDirectory): Likewise.
1190         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
1191         instead of execute_unwinders.
1192
1193 2019-08-15  Tom Tromey  <tom@tromey.com>
1194
1195         * tui/tui-layout.c (show_layout, show_source_disasm_command)
1196         (show_data): Don't change window visibility.
1197         (tui_gen_win_info::resize): Remove special case for command
1198         window.  Use wresize, when available.
1199         (show_source_or_disasm_and_command): Don't change window
1200         visibility.
1201         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
1202         <make_visible>: New method.
1203         * tui/tui-command.c (tui_cmd_window::resize): New method.
1204
1205 2019-08-15  Tom Tromey  <tom@tromey.com>
1206
1207         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
1208         (struct tui_source_windows): New.
1209         * tui/tui-winsource.c (tui_display_main): Update.
1210         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1211         (new_height_ok, parse_scrolling_args): Update.
1212         * tui/tui-layout.c (show_layout, show_data): Update.
1213         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
1214         (tui_add_to_source_windows): Don't declare.
1215         * tui/tui-data.c (source_windows, tui_source_windows)
1216         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
1217
1218 2019-08-15  Tom Tromey  <tom@tromey.com>
1219
1220         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
1221         Rename from reset.
1222         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
1223         * tui/tui-layout.c (show_source_disasm_command, show_data):
1224         Update.
1225         (tui_gen_win_info::resize): Rename.
1226         (show_source_or_disasm_and_command): Update.
1227         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
1228         reset.
1229
1230 2019-08-15  Tom Tromey  <tom@tromey.com>
1231
1232         * tui/tui-stack.c (tui_initialize_static_data): Remove.
1233         * tui/tui-interp.c (tui_interp::init): Don't call
1234         tui_initialize_static_data.
1235         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
1236
1237 2019-08-15  Tom Tromey  <tom@tromey.com>
1238
1239         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
1240         examine tui_win_list.
1241
1242 2019-08-15  Tom Tromey  <tom@tromey.com>
1243
1244         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
1245         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
1246         tui_clear_source_content.
1247         (tui_clear_source_content): Remove.
1248         (tui_source_window_base::do_erase_source_content): Hoist call to
1249         content.clear().
1250         * tui/tui-stack.c (tui_show_frame_info): Don't call
1251         tui_clear_source_content.
1252
1253 2019-08-15  Tom Tromey  <tom@tromey.com>
1254
1255         * tui/tui-winsource.h (struct tui_source_window_base)
1256         <do_erase_source_content>: New method.
1257         <erase_source_content>: New method.
1258         (tui_erase_source_content): Don't declare.
1259         * tui/tui-winsource.c (tui_clear_source_content): Update.
1260         (tui_source_window_base::do_erase_source_content): Rename from
1261         tui_erase_source_content.
1262         (tui_source_window_base::show_source_content): Update.
1263         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1264         * tui/tui-source.h (struct tui_source_window)
1265         <erase_source_content>: New method.
1266         * tui/tui-disasm.h (struct tui_disasm_window)
1267         <erase_source_content>: New method.
1268
1269 2019-08-15  Tom Tromey  <tom@tromey.com>
1270
1271         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
1272         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
1273         constructor.
1274         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
1275         * tui/tui-source.c (tui_set_source_content): Update.
1276         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1277
1278 2019-08-15  Tom Tromey  <tom@tromey.com>
1279
1280         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
1281         * tui/tui-winsource.c (tui_line_is_displayed): Move to
1282         tui-source.c.
1283         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
1284         Declare.
1285         * tui/tui-source.c (tui_source_window::line_is_displayed): New
1286         method.
1287         (tui_source_window::maybe_update): Update.
1288
1289 2019-08-15  Tom Tromey  <tom@tromey.com>
1290
1291         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
1292         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
1293         tui-disasm.c.
1294         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
1295         Declare.
1296         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
1297         method.
1298         (tui_disasm_window::maybe_update): Update.
1299
1300 2019-08-15  Tom Tromey  <tom@tromey.com>
1301
1302         * tui/tui-winsource.h (struct tui_source_window_base)
1303         <maybe_update>: Declare.
1304         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
1305         method.
1306         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
1307         Declare.
1308         * tui/tui-source.c (tui_source_window::maybe_update): New method.
1309         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
1310         Declare.
1311         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
1312
1313 2019-08-15  Tom Tromey  <tom@tromey.com>
1314
1315         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
1316
1317 2019-08-15  Tom Tromey  <tom@tromey.com>
1318
1319         * tui/tui-wingeneral.c: Include tui-stack.h.
1320         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
1321         (struct tui_locator_window): Move from tui-data.h.
1322         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
1323         (tui_initialize_static_data): Move from tui-data.c.
1324         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
1325         (struct tui_locator_window): Move to tui-stack.c.
1326         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
1327         (tui_initialize_static_data): Move to tui-stack.c.
1328
1329 2019-08-15  Tom Tromey  <tom@tromey.com>
1330
1331         * tui/tui-layout.c (show_source_disasm_command)
1332         (show_source_or_disasm_and_command): Use make_visible method, not
1333         tui_make_window.
1334         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
1335         Remove.
1336
1337 2019-08-15  Tom Tromey  <tom@tromey.com>
1338
1339         * tui/tui-wingeneral.h (tui_make_window): Update.
1340         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
1341         parameter.
1342         (tui_gen_win_info::make_visible): Update.
1343         * tui/tui-regs.c (tui_data_window::display_registers_from):
1344         Update.
1345         * tui/tui-layout.c (show_source_disasm_command)
1346         (show_source_or_disasm_and_command): Update.
1347         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
1348         (enum tui_box): Remove.
1349         (struct tui_win_info) <can_box>: New method.
1350         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
1351         method.
1352
1353 2019-08-15  Tom de Vries  <tdevries@suse.de>
1354
1355         * linux-nat-trad.c: Include gdbarch.h.
1356
1357 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
1358
1359         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
1360         register sizes.
1361
1362 2019-08-14  Tom Tromey  <tromey@adacore.com>
1363
1364         * darwin-nat.c: Include gdbarch.h.
1365         * darwin-nat-info.c: Include gdbarch.h.
1366
1367 2019-08-13  Tom Tromey  <tom@tromey.com>
1368
1369         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
1370         Remove.
1371         * tui/tui-data.c (tui_initialize_static_data): Update.
1372
1373 2019-08-13  Tom Tromey  <tom@tromey.com>
1374
1375         * tui/tui-winsource.h (struct tui_exec_info_window)
1376         <~tui_exec_info_window, maybe_allocate_content, get_content,
1377         m_content>: Remove.
1378         (struct tui_source_window_base) <set_exec_info_content,
1379         show_exec_info_content>: Don't declare.
1380         * tui/tui-winsource.c
1381         (tui_exec_info_window::maybe_allocate_content): Remove.
1382         (tui_source_window_base::update_exec_info): Rename from
1383         set_exec_info_content.
1384         (tui_source_window_base::show_exec_info_content)
1385         (tui_source_window_base::update_exec_info): Remove.
1386
1387 2019-08-13  Tom Tromey  <tom@tromey.com>
1388
1389         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
1390         declare.
1391         * tui/tui-winsource.c (tui_update_source_window_as_is)
1392         (tui_update_source_windows_with_addr, tui_erase_source_content):
1393         Update.
1394         (tui_clear_exec_info_content): Remove.
1395
1396 2019-08-13  Tom Tromey  <tom@tromey.com>
1397
1398         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
1399         declare.
1400         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
1401         call tui_erase_exec_info_content.
1402         (tui_clear_exec_info_content): Rename from
1403         tui_erase_exec_info_content.
1404         (tui_clear_exec_info_content): Delete.
1405
1406 2019-08-13  Tom Tromey  <tom@tromey.com>
1407
1408         * tui/tui-winsource.h (struct tui_source_window_base)
1409         <show_exec_info_content>: Declare.
1410         (tui_show_exec_info_content): Don't declare.
1411         * tui/tui-winsource.c
1412         (tui_source_window_base::show_exec_info_content): Rename from
1413         tui_show_exec_info_content.
1414         (tui_source_window_base::update_exec_info): Update.
1415
1416 2019-08-13  Tom Tromey  <tom@tromey.com>
1417
1418         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
1419         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
1420         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
1421         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
1422         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
1423         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
1424         ... here.
1425
1426 2019-08-13  Tom Tromey  <tom@tromey.com>
1427
1428         * tui/tui-winsource.h (struct tui_source_window_base)
1429         <update_exec_info>: Declare.
1430         (tui_update_exec_info): Don't declare.
1431         * tui/tui-winsource.c (tui_update_source_window_as_is)
1432         (tui_source_window_base::refresh_all)
1433         (tui_update_all_breakpoint_info): Update.
1434         (tui_source_window_base::update_exec_info): Rename from
1435         tui_update_exec_info.
1436         * tui/tui-stack.c (tui_show_frame_info): Update.
1437
1438 2019-08-13  Tom Tromey  <tom@tromey.com>
1439
1440         * tui/tui-winsource.h (struct tui_source_window_base)
1441         <set_exec_info_content>: Declare.
1442         (tui_set_exec_info_content): Don't declare.
1443         * tui/tui-winsource.c
1444         (tui_source_window_base::set_exec_info_content): Rename from
1445         tui_set_exec_info_content.
1446         (tui_update_exec_info): Update.
1447
1448 2019-08-13  Tom Tromey  <tom@tromey.com>
1449
1450         * tui/tui-winsource.h (struct tui_source_window_base)
1451         <show_source_content>: Declare.
1452         (tui_show_source_content): Don't declare.
1453         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1454         (tui_source_window_base::show_source_content): Rename from
1455         tui_show_source_content.
1456         (tui_source_window_base::refresh_all): Update.
1457         * tui/tui-layout.c (show_source_disasm_command)
1458         (show_source_or_disasm_and_command): Update.
1459
1460 2019-08-13  Tom Tromey  <tom@tromey.com>
1461
1462         * tui/tui-winsource.c (tui_erase_source_content)
1463         (tui_show_source_content, tui_source_window_base::refresh_all):
1464         Update.
1465         * tui/tui-wingeneral.h
1466         (tui_check_and_display_highlight_if_needed): Don't declare.
1467         * tui/tui-wingeneral.c
1468         (tui_win_info::check_and_display_highlight_if_needed): Rename from
1469         check_and_display_highlight_if_needed.
1470         * tui/tui-win.c (tui_rehighlight_all)
1471         (tui_win_info::make_visible_with_new_height): Update.
1472         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1473         (tui_data_window::erase_data_content)
1474         (tui_data_window::display_all_data): Update.
1475         * tui/tui-data.h (struct tui_win_info)
1476         <check_and_display_highlight_if_needed>: Declare.
1477
1478 2019-08-13  Tom Tromey  <tom@tromey.com>
1479
1480         * tui/tui-win.c (tui_resize_all): Call
1481         tui_delete_invisible_windows.
1482         * tui/tui-layout.c (show_layout): Call
1483         tui_delete_invisible_windows.
1484         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
1485         * tui/tui-data.c (tui_delete_invisible_windows): New function.
1486
1487 2019-08-13  Tom Tromey  <tom@tromey.com>
1488
1489         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
1490         tui_add_win_to_layout.
1491
1492 2019-08-13  Tom Tromey  <tom@tromey.com>
1493
1494         * tui/tui-layout.h (tui_default_win_height): Don't declare.
1495         * tui/tui-layout.c (tui_default_win_height): Now static.
1496
1497 2019-08-13  Tom Tromey  <tom@tromey.com>
1498
1499         * tui/tui-layout.c (show_layout): Unify all layout cases into a
1500         single switch.
1501         (show_source_disasm_command, show_source_or_disasm_and_command):
1502         Don't check current layout.
1503
1504 2019-08-13  Tom Tromey  <tom@tromey.com>
1505
1506         * tui/tui-wingeneral.c (make_all_visible): Remove.
1507         (tui_make_all_invisible): Simplify.
1508         * tui/tui-layout.c (tui_make_all_invisible): Move from
1509         tui-wingeneral.c; simplify.
1510         (show_layout): Hoist call to tui_make_all_invisible.
1511         (show_data): Don't call tui_make_all_invisible.
1512
1513 2019-08-13  Tom Tromey  <tom@tromey.com>
1514
1515         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
1516         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
1517
1518 2019-08-13  Tom Tromey  <tom@tromey.com>
1519
1520         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
1521         tui-data.c.
1522         (show_source_disasm_command, show_data)
1523         (show_source_or_disasm_and_command): Don't use
1524         tui_set_current_layout_to.
1525         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
1526         * tui/tui-data.c (current_layout, tui_current_layout): Move to
1527         tui-layout.c.
1528         (tui_set_current_layout_to): Remove.
1529
1530 2019-08-13  Tom Tromey  <tom@tromey.com>
1531
1532         * tui/tui-layout.c (tui_set_layout): Update.
1533         * tui/tui-data.h (struct tui_layout_def): Remove.
1534         (tui_layout_def): Don't declare.
1535         * tui/tui-data.c (layout_def): Remove.
1536         (tui_layout_def): Remove.
1537
1538 2019-08-13  Tom Tromey  <tom@tromey.com>
1539
1540         * tui/tui-winsource.h (struct tui_source_window_base)
1541         <clear_detail>: No longer "override".
1542         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
1543         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
1544         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
1545         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
1546         Remove.
1547         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
1548
1549 2019-08-13  Tom Tromey  <tromey@adacore.com>
1550
1551         * tracepoint.c: Don't include readline.h or history.h.
1552
1553 2019-08-12  Tom Tromey  <tom@tromey.com>
1554
1555         * configure: Rebuild.
1556         * configure.ac: Check for readline 7.
1557         * NEWS: Mention readline 7 requirement.
1558         * README: Update.
1559
1560 2019-08-12  Tom Tromey  <tom@tromey.com>
1561
1562         * mingw-hdep.c (gdb_select): Remove readline hack.
1563
1564 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1565
1566         * blockframe.c (find_pc_partial_function): Set *block to nullptr
1567         when the function fails.
1568
1569 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
1570
1571         * s390-tdep.c (s390_type_align): New function.
1572         (s390_gdbarch_init): Set it as type_align gdbarch method.
1573
1574 2019-08-09  Tom de Vries  <tdevries@suse.de>
1575
1576         PR gdb/24591
1577         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
1578         pc_low with relocation offset.
1579
1580 2019-08-07  Tom Tromey  <tromey@adacore.com>
1581
1582         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1583         (print_frame_args): Update.
1584         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
1585         Update.
1586         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1587         * frame.h (struct frame_arg): Add initializers.
1588         <error>: Now a unique_xmalloc_ptr.
1589
1590 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
1591
1592         * NEWS: Expand the Pointer Authentication entry.
1593         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
1594         (aarch64_frame_unmask_lr): ... to this.
1595         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
1596         Call aarch64_frame_unmask_lr.
1597         * frame.c (struct frame_info): Add "masked" variable.
1598         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
1599         (fprint_frame): Check for masked pc.
1600         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
1601         declarations.
1602         * python/py-framefilter.c (py_print_frame): Check for masked pc.
1603         * stack.c (print_frame): Check for masked pc.
1604
1605 2019-08-06  Tom Tromey  <tom@tromey.com>
1606
1607         * stabsread.c (patch_block_stabs, read_one_struct_field)
1608         (read_enum_type): Use obstack_strndup.
1609         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
1610         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
1611         * dwarf2read.c (guess_full_die_structure_name)
1612         (anonymous_struct_prefix): Use obstack_strndup.
1613         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
1614         * c-exp.y (yylex): Use obstack_strndup.
1615         * ada-exp.y (write_object_renaming, write_ambiguous_var)
1616         (write_var_or_type): Use obstack_strndup.
1617
1618 2019-08-06  Tom Tromey  <tom@tromey.com>
1619
1620         * symfile.c (reread_symbols): Use obstack_strdup.
1621         * stabsread.c (read_type): Use obstack_strdup.
1622         * gdb_obstack.h (obstack_strdup): New overload.
1623         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
1624         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
1625         (dwarf2_canonicalize_name): Use obstack_strdup.
1626         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
1627         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
1628         Use obstack_strdup.
1629
1630 2019-08-06  Tom Tromey  <tom@tromey.com>
1631
1632         * gdb_obstack.h (obstack_strdup): Define.
1633         * gdb_obstack.c (obstack_strdup): Don't define.
1634
1635 2019-08-06  Tom Tromey  <tom@tromey.com>
1636
1637         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
1638         obstack_strdup.
1639         * typeprint.c (typedef_hash_table::find_global_typedef): Use
1640         obstack_strdup.
1641         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
1642         * stabsread.c (common_block_start): Use obstack_strdup.
1643         * objfiles.c (set_objfile_main_name, objfile): Use
1644         obstack_strdup.
1645         * namespace.c (add_using_directive): Use obstack_strdup.
1646         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
1647         * jit.c (finalize_symtab): Use obstack_strdup.
1648         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
1649         (guess_partial_die_structure_name, partial_die_info::fixup)
1650         (dwarf2_name): Use obstack_strdup.
1651         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
1652         obstack_strdup.
1653         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
1654         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1655         obstack_strdup.
1656         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
1657
1658 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1659
1660         * unittests/help-doc-selftests.c: New file.
1661         * Makefile.in: Add the new file.
1662
1663 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1664
1665         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
1666         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
1667         the full first line, except when FOR_VALUE_PREFIX.  In this case,
1668         the trailing '.' is not output, and the first character is uppercased.
1669         (print_help_for_command): Update call to print_doc_line.
1670         (print_doc_of_command): Likewise.
1671         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
1672         * cli/cli-option.c (append_indented_doc): Do not append newline.
1673         (build_help_option): Append newline after first appended_indented_doc
1674         only if a second call is done.
1675         (build_help): Append 2 new lines before each option, except the first
1676         one.
1677         * compile/compile.c (_initialize_compile): Add new lines after
1678         %OPTIONS%, when not at the end of the help.
1679         Change help doc or code
1680         producing the help doc to respect the invariants.
1681         * maint-test-options.c (_initialize_maint_test_options): Likewise.
1682         Also removed the new line after 'Options:', as all other commands
1683         do not put an empty line between 'Options:' and the first option.
1684         * printcmd.c (_initialize_printcmd): Likewise.
1685         * stack.c (_initialize_stack): Likewise.
1686         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
1687         incorrectly telling COMMAND is optional.
1688         * ada-lang.c (_initialize_ada_language): Change help doc or code
1689         producing the help doc to respect the invariants.
1690         * ada-tasks.c (_initialize_ada_tasks): Likewise.
1691         * breakpoint.c (_initialize_breakpoint): Likewise.
1692         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
1693         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
1694         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
1695         * cli/cli-style.c (cli_style_option::add_setshow_commands,
1696         _initialize_cli_style): Likewise.
1697         * corelow.c (core_target_info): Likewise.
1698         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
1699         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
1700         * filesystem.c (_initialize_filesystem): Likewise.
1701         * frame.c (_initialize_frame): Likewise.
1702         * gnu-nat.c (add_task_commands): Likewise.
1703         * infcall.c (_initialize_infcall): Likewise.
1704         * infcmd.c (_initialize_infcmd): Likewise.
1705         * interps.c (_initialize_interpreter): Likewise.
1706         * language.c (_initialize_language): Likewise.
1707         * linux-fork.c (_initialize_linux_fork): Likewise.
1708         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
1709         * maint.c (_initialize_maint_cmds): Likewise.
1710         * memattr.c (_initialize_mem): Likewise.
1711         * printcmd.c (_initialize_printcmd): Likewise.
1712         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
1713         _RegEx): Likewise.
1714         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
1715         * record-btrace.c (_initialize_record_btrace): Likewise.
1716         * record-full.c (_initialize_record_full): Likewise.
1717         * record.c (_initialize_record): Likewise.
1718         * regcache-dump.c (_initialize_regcache_dump): Likewise.
1719         * regcache.c (_initialize_regcache): Likewise.
1720         * remote.c (add_packet_config_cmd, init_remote_threadtests,
1721         _initialize_remote): Likewise.
1722         * ser-tcp.c (_initialize_ser_tcp): Likewise.
1723         * serial.c (_initialize_serial): Likewise.
1724         * skip.c (_initialize_step_skip): Likewise.
1725         * source.c (_initialize_source): Likewise.
1726         * stack.c (_initialize_stack): Likewise.
1727         * symfile.c (_initialize_symfile): Likewise.
1728         * symtab.c (_initialize_symtab): Likewise.
1729         * target-descriptions.c (_initialize_target_descriptions): Likewise.
1730         * top.c (init_main): Likewise.
1731         * tracefile-tfile.c (tfile_target_info): Likewise.
1732         * tracepoint.c (_initialize_tracepoint): Likewise.
1733         * tui/tui-win.c (_initialize_tui_win): Likewise.
1734         * utils.c (add_internal_problem_command): Likewise.
1735         * valprint.c (value_print_option_defs): Likewise.
1736
1737 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
1738
1739         PR build/24886
1740         * configure.ac: Drop enable-libmcheck support.
1741         * configure, config.in: Rebuild.
1742         * libmcheck.m4: Remove.
1743         * acinclude.m4: Don't include it.
1744         * Makefile.in: Don't distribute it.
1745         * top.c (print_gdb_configuration): Don't mention it.
1746
1747 2019-08-06  Tom Tromey  <tom@tromey.com>
1748
1749         * utils.c (set_output_style): Sometimes pass stream to
1750         emit_style_escape.
1751         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
1752         * record-btrace.c (btrace_insn_history): Update.
1753         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
1754         method.
1755         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
1756         Update initializers.
1757         <m_uiout>: New field.
1758         <m_di>: Move lower.
1759         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1760         Remove "uiout" parameter.
1761         (dump_insns): Update.
1762         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
1763         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
1764
1765 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
1766
1767         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
1768         (error_in_psymtab_expansion): Likewise.
1769         (lookup_symbol_via_quick_fns): Likewise.
1770         (basic_lookup_transparent_type_quick): Likewise.
1771         (basic_lookup_transparent_type_1): Likewise.
1772
1773 2019-08-06  Tom Tromey  <tromey@adacore.com>
1774
1775         * source.c (last_source_error): Now bool.
1776         (print_source_lines_base): Make "noprint" bool.  Only open
1777         source file when last_source_visited changes.
1778
1779 2019-08-06  Tom Tromey  <tromey@adacore.com>
1780
1781         * annotate.c (annotate_source_line): Use g_source_cache.
1782         * source-cache.c (source_cache::get_plain_source_lines): Change
1783         parameters.  Populate m_offset_cache.
1784         (source_cache::ensure): New method.
1785         (source_cache::get_line_charpos): New method.
1786         (extract_lines): Move lower.  Change parameters.
1787         (source_cache::get_source_lines): Move lower.
1788         * source-cache.h (class source_cache): Update comment.
1789         <get_line_charpos>: New method.
1790         <get_source_lines>: Update comment.
1791         <clear>: Clear m_offset_cache.
1792         <get_plain_source_lines>: Change parameters.
1793         <ensure>: New method
1794         <m_offset_cache>: New member.
1795         * source.c (forget_cached_source_info_for_objfile): Update.
1796         (info_source_command): Use g_source_cache.
1797         (find_source_lines, open_source_file_with_line_charpos): Remove.
1798         (print_source_lines_base, search_command_helper): Use g_source_cache.
1799         * source.h (open_source_file_with_line_charpos): Don't declare.
1800         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
1801         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
1802         Use g_source_cache.
1803
1804 2019-08-06  Tom Tromey  <tromey@adacore.com>
1805
1806         * source-cache.c (source_cache::get_plain_source_lines):
1807         Remove "first_line" and "last_line" parameters.
1808         (source_cache::get_source_lines): Cache plain text.
1809         * source-cache.h (class source_cache)
1810         <get_plain_source_lines>: Update.
1811
1812 2019-08-06  Tom Tromey  <tromey@adacore.com>
1813
1814         * source-cache.c (extract_lines): No longer a method.
1815         Changed type of parameter.  Include final newline.
1816         (selftests::extract_lines_test): New function.
1817         (_initialize_source_cache): Likewise.
1818         * source-cache.h (class source_cache)
1819         <extract_lines>: Don't declare.
1820
1821 2019-08-06  Tom Tromey  <tromey@adacore.com>
1822
1823         * breakpoint.c (init_breakpoint_sal): Update.
1824         (breakpoint): Update.
1825         * breakpoint.h (struct breakpoint) <filter>: Now a
1826         unique_xmalloc_ptr.
1827
1828 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1829
1830         * NEWS: Mention dictionary access on blocks.
1831         * python/py-block.c (blpy_getitem): New function.
1832         (block_object_as_mapping): New struct.
1833         (block_object_type): Use new struct for tp_as_mapping field.
1834
1835 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1836
1837         * objfiles.h (objfile): Add a comment describing partial symbols.
1838
1839 2019-08-05  Tom Tromey  <tromey@adacore.com>
1840
1841         * compile/compile.c (_initialize_compile): Use _(), not N_().
1842         * thread.c (_initialize_thread): Use _(), not N_().
1843         * stack.c (_initialize_stack): Use _(), not N_().
1844         * printcmd.c (_initialize_printcmd): Use _(), not N_().
1845
1846 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
1847
1848         * dwarf2read.c (struct dw2_symtab_iterator):
1849         <want_specific_block>: Remove.
1850         <block_index>: Change type to gdb::optional.
1851         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
1852         change type of BLOCK_INDEX parameter to gdb::optional.
1853         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
1854         (dw2_lookup_symbol): Don't pass argument for
1855         WANT_SPECIFIC_BLOCK.
1856         (dw2_expand_symtabs_for_function): Don't pass argument for
1857         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
1858         (class dw2_debug_names_iterator)
1859         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
1860         parameter, change BLOCK_INDEX type to gdb::optional.
1861         <m_want_specific_block>: Remove.
1862         <m_block_index>: Change type to gdb::optional.
1863         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
1864         gdb::optional.  Re-write in function of gdb::optional.
1865         (dw2_debug_names_lookup_symbol): Don't pass argument for
1866         WANT_SPECIFIC_BLOCK.
1867         (dw2_debug_names_expand_symtabs_for_function): Don't pass
1868         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
1869         BLOCK_INDEX.
1870
1871 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1872
1873         * NEWS: Mention changes to "info sources" command.
1874
1875 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1876
1877         * symtab.c (filename_partial_match_opts): New struct type.
1878         (struct output_source_filename_data): New members
1879         regexp, c_regexp, partial_match.
1880         (output_source_filename): Use new members to decide to print file.
1881         (info_sources_option_defs): New variable.
1882         (make_info_sources_options_def_group, print_info_sources_header,
1883         info_sources_command_completer):
1884         New functions.
1885         (info_sources_command): Read new optional arguments.
1886         (_initialize_symtab): Update info sources help.
1887
1888 2019-08-02  Alexandre Oliva <oliva@adacore.com>
1889
1890         * ada-lang.c (exception_support_info_v0): Renamed from...
1891         (default_exception_support_info): ... this.  Create new
1892         definition for v1.
1893         (ada_has_this_exception_support): Look up catch_handlers_sym.
1894         (ada_exception_support_info_sniffer): Try v0 after default.
1895
1896 2019-08-01  Tom Tromey  <tromey@adacore.com>
1897
1898         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
1899         gdbarch.h.
1900
1901 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
1902
1903         * s12z-tdep.c: Fix include path for s12z-opc.h.
1904
1905 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
1906
1907         * NEWS: Require GNU make 3.82.
1908
1909 2019-07-16  Tom Tromey  <tom@tromey.com>
1910
1911         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
1912         declare.
1913
1914 2019-07-30  Tom Tromey  <tromey@adacore.com>
1915
1916         * block.c (contained_in): Remove BLOCK_FUNCTION check.
1917
1918 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
1919
1920         * printcmd.c (print_address_symbolic): Print negative offsets.
1921         (build_address_symbolic): Force signed arithmetic when computing
1922         offset.
1923
1924 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
1925
1926         PR/24474: Add a function to lookup static variables.
1927         * NEWS: Mention this new function.
1928         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
1929         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
1930         * python/python.c (python_GdbMethods): Add new function.
1931
1932 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
1933
1934         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1935         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1936         (objfpy_lookup_static_symbol): New function.
1937         (objfile_object_methods): Add new functions.
1938
1939 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1940
1941         * NEWS: Mention 'set|show print frame-info'.  Mention new
1942         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
1943         backtrace argument.  Mention that python frame filtering code
1944         is now consistent with what 'backtrace' command prints.
1945
1946 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1947
1948         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1949         comments.
1950         (print_frame_info_auto, print_frame_info_source_line,
1951         print_frame_info_location, print_frame_info_source_and_location,
1952         print_frame_info_location_and_address, print_frame_info_short_location):
1953         New declarations.
1954         (struct frame_print_options): New member print_frame_info.
1955         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1956         * stack.h (get_user_print_what_frame_info): New declaration.
1957         (frame_show_address): New declaration.
1958         * stack.c (print_frame_arguments_choices): New value 'presence'.
1959         (print_frame_info_auto, print_frame_info_source_line,
1960         print_frame_info_location, print_frame_info_source_and_location,
1961         print_frame_info_location_and_address, print_frame_info_short_location,
1962         print_frame_info_choices, print_frame_info_print_what): New definitions.
1963         (print_frame_args): Only print dots for args if print frame-arguments
1964         is 'presence'.
1965         (frame_print_option_defs): New element for "frame-info".
1966         (get_user_print_what_frame_info): New function.
1967         (frame_show_address): Make non static.  Move comment to stack.h.
1968         (print_frame_info_to_print_what): New function.
1969         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
1970         to decide what to print.
1971         (backtrace_command_1): Handle the new print_frame_arguments_presence
1972         value.
1973         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1974         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1975         (py_print_frame): In non-mi mode, use LOCATION as default for
1976         print_what, similarly to frame information printed directly by
1977         backtrace command. Handle frame-info user option in non MI mode.
1978
1979 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1980
1981         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1982         Add case for debugging 32-bit target on 64-bit host.  Revise
1983         comment.
1984
1985 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1986
1987         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1988         instead of find_function_entry_range_from_pc.
1989
1990 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1991
1992         * stack.c (find_frame_funname): Remove code which preferred
1993         minsym over symtab sym in "certain pathological cases".
1994
1995         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1996         parameter.  Change type of "do_demangle" to bool.
1997         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1998         Pass suitable "prefer_sym_over_minsym" flag to
1999         build_address_symbolic().  Don't output "+" for negative offsets.
2000         * printcmd.c (print_address_symbolic): Update invocation of
2001         build_address_symbolic to include a "prefer_sym_over_minsym"
2002         flag.
2003         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
2004         Restrict cases in which use of minimal symbol is preferred to that
2005         of a found symbol.  Update comments.
2006
2007         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
2008         for entry pc when entry pc is out of range for that FDE.
2009
2010 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
2011
2012         PR gdb/24839:
2013         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
2014         type.
2015
2016 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
2017
2018         * python/py-objfile.c (add_separate_debug_file): Fix comment about
2019         this function's Python signature.
2020
2021
2022 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
2023
2024         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
2025         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2026         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2027         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
2028         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
2029
2030
2031 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
2032
2033         * h8300-tdep.c (h8300_register_name_common): New.
2034         h8300_register_name): Use h8300_register_name_common.
2035         (h8300s_register_name): Likewise.
2036         (h8300sx_register_name): Likewise.
2037         (h8300h_register_nam): New.
2038         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
2039
2040
2041 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
2042
2043         * arm-tdep.c (arm_skip_cmse_entry): New function.
2044         (arm_is_sgstubs_section): New function.
2045         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
2046
2047 2019-07-22  Tom Tromey  <tom@tromey.com>
2048
2049         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
2050         Don't self-assign.
2051
2052 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2053
2054         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
2055         type_print.
2056
2057 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2058
2059         * symtab.c (search_symbols): Adjust msymbol matching type arrays
2060         so that GDB doesn't match any msymbols when searching in the
2061         TYPES_DOMAIN.
2062         (print_symbol_info): Print using typedef_print or type_print based
2063         on the type of the symbol.  Add updated FIXME comment moved from...
2064         (_initialize_symtab): ... move and update FIXME comment to above.
2065
2066 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2067
2068         * NEWS: Mention adding -q option to "info types".
2069         * symtab.c (struct info_types_options): New struct.
2070         (info_types_options_defs): New variable.
2071         (make_info_types_options_def_group): New function.
2072         (info_types_command): Use gdb::option framework to parse options.
2073         (info_types_command_completer): New function.
2074         (_initialize_symtab): Extend the help text on "info types" and
2075         register command completer.
2076
2077 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
2078
2079         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
2080         (lookup_symbol_in_objfile): Change int to block_enum and add a
2081         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
2082
2083 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
2084
2085         * MAINTAINERS (Write After Approval): Add self.
2086
2087 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2088
2089         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
2090         instruction to the dummy code region.
2091
2092 2019-07-19  Tom Tromey  <tromey@adacore.com>
2093
2094         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
2095         (ARGSUSED, PARAMS, __func__): Remove rules.
2096
2097 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2098
2099         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
2100         * features/arm/arm-with-iwmmxt.c: Remove.
2101         * features/arm/arm-with-iwmmxt.xml: Remove.
2102         * features/arm/arm-with-m-fpa-layout.c: Remove.
2103         * features/arm/arm-with-m-fpa-layout.xml: Remove.
2104         * features/arm/arm-with-m-vfp-d16.c: Remove.
2105         * features/arm/arm-with-m-vfp-d16.xml: Remove.
2106         * features/arm/arm-with-m.c: Remove.
2107         * features/arm/arm-with-m.xml: Remove.
2108         * features/arm/arm-with-neon.c: Remove.
2109         * features/arm/arm-with-neon.xml: Remove.
2110         * features/arm/arm-with-vfpv2.c: Remove.
2111         * features/arm/arm-with-vfpv2.xml: Remove.
2112         * features/arm/arm-with-vfpv3.c: Remove.
2113         * features/arm/arm-with-vfpv3.xml: Remove.
2114
2115 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2116
2117         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
2118
2119 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2120
2121         * arch/aarch32.c (aarch32_create_target_description): Create
2122         target descriptions using features.
2123         * arch/arm.c (arm_create_target_description)
2124         (arm_create_mprofile_target_description): Likewise.
2125         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
2126
2127 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2128
2129         * Makefile.in: Add new files.
2130         * aarch32-tdep.c: New file.
2131         * aarch32-tdep.h: New file.
2132         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2133         Call aarch32_read_description.
2134         * arch/aarch32.c: New file.
2135         * arch/aarch32.h: New file.
2136         * arch/arm.c (arm_create_target_description)
2137         (arm_create_mprofile_target_description): New function.
2138         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
2139         (arm_create_target_description)
2140         (arm_create_mprofile_target_description): New declaration.
2141         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
2142         read_description functions.
2143         * arm-linux-nat.c (arm_linux_nat_target::read_description):
2144         Likewise.
2145         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2146         * arm-tdep.c (tdesc_arm_list): New variable.
2147         (arm_register_g_packet_guesses): Call create description functions.
2148         (arm_read_description) (arm_read_mprofile_description): New
2149         function.
2150         * arm-tdep.h (arm_read_description)
2151         (arm_read_mprofile_description): Add declaration.
2152         * configure.tgt: Add new files.
2153
2154 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
2155
2156         * top.c (new_ui_command): Open specified terminal just once.
2157
2158 2019-07-18  Tom Tromey  <tromey@adacore.com>
2159
2160         * symtab.c (main_name): Constify return type.
2161         * symfile.c (set_initial_language): Update.
2162         * symtab.h (main_name): Constify return type.
2163
2164 2019-07-17  Tom Tromey  <tom@tromey.com>
2165
2166         * tui/tui-winsource.c (tui_update_source_window)
2167         (tui_update_source_window_as_is)
2168         (tui_update_source_windows_with_line): Remove return.
2169         * tui/tui-disasm.c (tui_show_disassem)
2170         (tui_show_disassem_and_update_source): Remove return.
2171         * tui/tui.c (tui_reset): Remove return.
2172         * tui/tui-wingeneral.c
2173         (tui_check_and_display_highlight_if_needed): Remove return.
2174
2175 2019-07-17  Tom Tromey  <tom@tromey.com>
2176
2177         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
2178
2179 2019-07-17  Tom Tromey  <tom@tromey.com>
2180
2181         * tui/tui-winsource.h (struct tui_exec_info_window)
2182         (struct tui_source_window_base): Move from tui-data.h.
2183         * tui/tui-winsource.c: Move many method definitions from
2184         elsewhere.  Remove "structuring" comments.
2185         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
2186         (tui_source_window_base::refresh_window): Move to
2187         tui-winsource.c.
2188         * tui/tui-win.c (tui_source_window_base::refresh_all)
2189         (tui_source_window_base::update_tab_width)
2190         (tui_source_window_base::set_new_height)
2191         (tui_source_window_base::do_make_visible_with_new_height): Move to
2192         tui-winsource.c.
2193         * tui/tui-source.h: Update.
2194         * tui/tui-source.c (tui_source_window_base::reset): Move to
2195         tui-winsource.c.
2196         * tui/tui-disasm.h: Update.
2197         * tui/tui-data.h (struct tui_exec_info_window): Move to
2198         tui-winsource.h.
2199         (struct tui_source_window_base): Likewise.
2200         * tui/tui-data.c (tui_source_window_base::clear_detail)
2201         (tui_source_window_base, ~tui_source_window_base): Move to
2202         tui-winsource.c.
2203
2204 2019-07-17  Tom Tromey  <tom@tromey.com>
2205
2206         * tui/tui-win.c (tui_resize_all)
2207         (tui_source_window_base::update_tab_width)
2208         (tui_adjust_win_heights): Update.
2209         (tui_win_info::make_invisible_and_set_new_height): Rename from
2210         make_invisible_and_set_new_height.
2211         * tui/tui-data.h (struct tui_win_info)
2212         <make_invisible_and_set_new_height>: New method.
2213
2214 2019-07-17  Tom Tromey  <tom@tromey.com>
2215
2216         * tui/tui.c: Update.
2217         * tui/tui-source.h (struct tui_source_window): Move from
2218         tui-data.h.
2219         * tui/tui-layout.c: Update.
2220         * tui/tui-disasm.c: Update.
2221         * tui/tui-data.h (struct tui_source_window): Move to
2222         tui-source.h.
2223
2224 2019-07-17  Tom Tromey  <tom@tromey.com>
2225
2226         * tui/tui-disasm.h (struct tui_disasm_window): Move from
2227         tui-data.h.
2228         * tui/tui-data.h (struct tui_disasm_window): Move to
2229         tui-disasm.h.
2230
2231 2019-07-17  Tom Tromey  <tom@tromey.com>
2232
2233         * tui/tui-regs.h (struct tui_data_item_window): Move from
2234         tui-data.h.
2235         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
2236         * tui/tui-data.h (struct tui_data_item_window): Move to
2237         tui-regs.h.
2238         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
2239
2240 2019-07-17  Tom Tromey  <tom@tromey.com>
2241
2242         * tui/tui.c: Update.
2243         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
2244         (tui_cmd_window::max_height): Move to tui-command.c.
2245         * tui/tui-layout.c: Update.
2246         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
2247         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
2248         tui-command.c.
2249         * tui/tui-command.h (struct tui_cmd_window): Move from
2250         tui-data.h.
2251         * tui/tui-command.c: Remove "structuring" comments.
2252         (tui_cmd_window::clear_detail)
2253         (tui_cmd_window::do_make_visible_with_new_height)
2254         (tui_cmd_window::max_height): Move from elsewhere.
2255
2256 2019-07-17  Tom Tromey  <tom@tromey.com>
2257
2258         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
2259         Now static.
2260         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
2261         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
2262
2263 2019-07-17  Tom Tromey  <tom@tromey.com>
2264
2265         * tui/tui.c: Update.
2266         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
2267         tui-regs.c.
2268         * tui/tui-windata.h: Remove file.
2269         * tui/tui-windata.c: Remove file.
2270         * tui/tui-win.c (tui_data_window::set_new_height)
2271         (tui_data_window::do_make_visible_with_new_height): Move to
2272         tui-regs.c.
2273         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
2274         * tui/tui-regs.c: Remove "structuring" comments.
2275         (tui_data_window::first_data_item_displayed)
2276         (tui_data_window::delete_data_content_windows)
2277         (tui_data_window::erase_data_content)
2278         (tui_data_window::display_all_data)
2279         (tui_data_window::refresh_all)
2280         (tui_data_window::do_scroll_vertical)
2281         (tui_data_window::clear_detail, tui_data_window::set_new_height)
2282         (tui_data_window::do_make_visible_with_new_height)
2283         (tui_data_window::refresh_window): Move from elsewhere.
2284         (_initialize_tui_regs): Move to end of file.
2285         * tui/tui-layout.c: Update.
2286         * tui/tui-hooks.c: Update.
2287         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
2288         * tui/tui-data.c (tui_data_window::clear_detail): Move to
2289         tui-regs.c.
2290         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
2291
2292 2019-07-17  Tom Tromey  <tom@tromey.com>
2293
2294         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
2295         seen.
2296
2297 2019-07-17  Tom Tromey  <tom@tromey.com>
2298
2299         * tui/tui-win.c (tui_source_window_base::set_new_height)
2300         (tui_source_window_base::do_make_visible_with_new_height): Use
2301         m_has_locator field directly.
2302         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
2303         method.
2304         (struct tui_source_window_base) <has_locator>: Likewise.
2305
2306 2019-07-17  Tom Tromey  <tom@tromey.com>
2307
2308         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
2309         Don't declare.
2310         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
2311         Remove.
2312         * tui/tui-win.c (tui_source_window_base::set_new_height)
2313         (tui_source_window_base::set_new_height)
2314         (make_invisible_and_set_new_height)
2315         (tui_source_window_base::do_make_visible_with_new_height)
2316         (tui_source_window_base::do_make_visible_with_new_height):
2317         Update.
2318         * tui/tui-layout.c (show_source_disasm_command, show_data)
2319         (show_source_or_disasm_and_command): Update.
2320         * tui/tui-layout.c (show_layout): Update.
2321
2322 2019-07-17  Tom Tromey  <tom@tromey.com>
2323
2324         * tui/tui-layout.c (make_data_window): Remove.
2325         (show_data): Unify creation and re-initialization cases.
2326
2327 2019-07-17  Tom Tromey  <tom@tromey.com>
2328
2329         * tui/tui-layout.c (make_source_window, make_disasm_window):
2330         Remove.
2331         (show_data): Unify creation and re-initialization cases.
2332
2333 2019-07-17  Tom Tromey  <tom@tromey.com>
2334
2335         * tui/tui-layout.c (make_command_window): Remove.
2336         (show_source_disasm_command, show_source_or_disasm_and_command):
2337         Unify creation and re-initialization cases.
2338
2339 2019-07-17  Tom Tromey  <tom@tromey.com>
2340
2341         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
2342         creation and re-initialization cases.
2343
2344 2019-07-17  Tom Tromey  <tom@tromey.com>
2345
2346         * tui/tui-regs.c (tui_get_register): Return void.
2347
2348 2019-07-17  Tom Tromey  <tom@tromey.com>
2349
2350         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
2351         Simplify.
2352
2353 2019-07-17  Tom Tromey  <tom@tromey.com>
2354
2355         * tui/tui-layout.c (show_source_disasm_command): Simplify window
2356         resetting.
2357
2358 2019-07-17  Tom Tromey  <tom@tromey.com>
2359
2360         * tui/tui.h (tui_set_layout_by_name): Don't declare.
2361         * tui/tui-regs.c (tui_reg_layout): New function.
2362         (tui_show_registers, tui_reg_command): Use it.
2363         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
2364         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
2365         parameters.
2366         (tui_layout_command): Remove.
2367
2368 2019-07-17  Tom Tromey  <tom@tromey.com>
2369
2370         * tui/tui-layout.h (tui/tui-layout): Return void.
2371         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
2372
2373 2019-07-17  Tom Tromey  <tom@tromey.com>
2374
2375         * tui/tui-layout.c (show_source_disasm_command, show_data):
2376         Update.
2377         (reset_locator): Remove.
2378         (show_source_or_disasm_and_command): Update.
2379
2380 2019-07-17  Tom Tromey  <tom@tromey.com>
2381
2382         * tui/tui-source.c (tui_source_window_base::reset): Remove
2383         win_type parameter.
2384         * tui/tui-layout.c (make_command_window, make_source_window)
2385         (make_disasm_window, make_data_window)
2386         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
2387         (reset_locator, show_source_or_disasm_and_command): Update.
2388         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
2389         win_type parameter.
2390         (struct tui_source_window_base) <reset>: Likewise.
2391
2392 2019-07-17  Tom Tromey  <tom@tromey.com>
2393
2394         * tui/tui-layout.c (show_source_disasm_command): Use
2395         reset_locator.
2396         (reset_locator): New function.
2397         (init_and_make_win): Remove.
2398         (show_source_or_disasm_and_command): Use reset_locator.
2399
2400 2019-07-17  Tom Tromey  <tom@tromey.com>
2401
2402         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
2403         condition.
2404         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
2405         Remove condition.
2406         * tui/tui-source.c (tui_source_window_base::reset): New method.
2407         * tui/tui-layout.c (make_command_window): Don't call
2408         init_and_make_win.
2409         (make_source_window, make_disasm_window): Don't call
2410         make_source_or_disasm_window.
2411         (make_data_window): Don't call init_and_make_win.  Change calling
2412         convention.
2413         (show_source_disasm_command, show_data): Simplify.
2414         (make_source_or_disasm_window): Remove.
2415         (show_source_or_disasm_and_command): Simplify.
2416         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
2417         (struct tui_source_window_base) <reset>: Likewise.
2418         <execution_info>: Remove initializer.
2419         * tui/tui-data.c (tui_source_window_base): Initialize
2420         execution_info.
2421
2422 2019-07-17  Tom Tromey  <tom@tromey.com>
2423
2424         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
2425         variable.
2426
2427 2019-07-17  Tom Tromey  <tom@tromey.com>
2428
2429         * tui/tui.c (tui_rl_other_window): Update.
2430         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
2431         superclass method first.  Always iterate over regs_content.
2432         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
2433         method.
2434         * tui/tui-win.c (tui_set_focus_command): Update.
2435
2436 2019-07-17  Tom Tromey  <tom@tromey.com>
2437
2438         * tui/tui-win.c (tui_set_focus_command): Rename from
2439         tui_set_focus.  Call tui_enable.
2440         (tui_set_focus_command): Remove.
2441
2442 2019-07-17  Tom Tromey  <tom@tromey.com>
2443
2444         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
2445         refresh_window.
2446         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
2447         touchwin.
2448         (tui_data_window::refresh_window): Call refresh_window on data
2449         items.  Always call superclass refresh_window.
2450         (tui_win_info::refresh): Remove.
2451         (tui_source_window_base::refresh_window): Update.
2452         (tui_refresh_all): Update.
2453         * tui/tui-layout.c (show_source_disasm_command): Remove call to
2454         refresh_window.
2455         (show_source_or_disasm_and_command): Likewise.
2456         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
2457         (struct tui_source_window_base) <refresh>: Likewise.
2458
2459 2019-07-17  Tom Tromey  <tom@tromey.com>
2460
2461         * tui/tui-winsource.c (tui_clear_source_content)
2462         (tui_show_source_content): Update.
2463         * tui/tui-source.c (tui_source_window::showing_source_p): Check
2464         whether content is empty.
2465         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
2466         Remove.
2467
2468 2019-07-17  Tom Tromey  <tom@tromey.com>
2469
2470         * tui/tui-winsource.c (tui_erase_source_content): Clear the
2471         window's contents.
2472         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
2473         * tui/tui-source.c (tui_set_source_content_nil): Remove.
2474
2475 2019-07-17  Tom Tromey  <tom@tromey.com>
2476
2477         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
2478         (struct tui_data_item_window): Update.
2479
2480 2019-07-17  Tom Tromey  <tom@tromey.com>
2481
2482         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
2483         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
2484         defines.
2485
2486 2019-07-17  Tom Tromey  <tom@tromey.com>
2487
2488         * tui/tui-winsource.h (tui_erase_source_content)
2489         (tui_clear_source_content): Remove "display_prompt" parameter.
2490         * tui/tui-winsource.c (tui_update_source_window_as_is)
2491         (tui_update_source_windows_with_addr): Update.
2492         (tui_clear_source_content): Remove "display_prompt" parameter.
2493         (tui_erase_source_content): Likewise.  Simplify.
2494         (tui_show_source_content): Update.
2495         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2496         * tui/tui-stack.c (tui_show_frame_info): Update.
2497         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
2498         Remove defines.
2499
2500 2019-07-17  Tom Tromey  <tom@tromey.com>
2501
2502         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2503         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
2504         parameter.
2505         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
2506         parameter.
2507
2508 2019-07-17  Tom Tromey  <tom@tromey.com>
2509
2510         * tui/tui-winsource.c (tui_clear_source_content)
2511         (tui_show_source_content, tui_show_exec_info_content)
2512         (tui_clear_exec_info_content): Update.
2513         * tui/tui-stack.c (tui_show_locator_content): Update.
2514         (tui_show_frame_info): Update.
2515         * tui/tui-source.h (tui_source_window): Don't declare.
2516         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
2517         from tui_source_is_displayed.
2518         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
2519         Remove field.
2520         (struct tui_source_window_base) <content_in_use>: New field.  Now
2521         bool.
2522         (struct tui_source_window) <showing_source_p>: New method.
2523         (TUI_SRC_WIN): Change cast.
2524         * tui/tui-data.c (tui_initialize_static_data): Update.
2525
2526 2019-07-17  Tom Tromey  <tom@tromey.com>
2527
2528         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
2529         location_matches_p.
2530         * tui/tui-source.c (tui_source_window::location_matches_p): New
2531         method.
2532         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
2533         method.
2534         * tui/tui-data.h (struct tui_source_window_base)
2535         <location_matches_p>: New method.
2536         (struct tui_source_window, struct tui_disasm_window)
2537         <location_matches_p>: Likewise.
2538
2539 2019-07-17  Tom Tromey  <tom@tromey.com>
2540
2541         * tui/tui-win.c (tui_set_win_height_command): Rename from
2542         tui_set_win_height.
2543         (tui_set_win_height_command): Remove.
2544
2545 2019-07-17  Tom Tromey  <tom@tromey.com>
2546
2547         * tui/tui-source.c (tui_source_window): New constructor.  Add
2548         observer.
2549         (~tui_source_window): New destructor.
2550         (tui_source_window::style_changed): New method.
2551         * tui/tui-hooks.c (tui_redisplay_source): Remove.
2552         (tui_attach_detach_observers): Update.
2553         * tui/tui-data.h (struct tui_source_window): Make constructor not
2554         inline.  Add destructor.
2555         (struct tui_source_window) <style_changed>: New method.
2556         <m_observable>: New member.
2557
2558 2019-07-17  Tom Tromey  <tom@tromey.com>
2559
2560         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
2561         * tui/tui-win.c (tui_resize_all): Fix typo.
2562
2563 2019-07-17  Tom Tromey  <tom@tromey.com>
2564
2565         * tui/tui-wingeneral.h (tui_refresh_all): Update.
2566         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
2567         (tui_refresh_all): Remove "list" parameter.  Use foreach.
2568         * tui/tui-win.c (window_name_completer): Use foreach.
2569         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
2570         (update_tab_width): Likewise.
2571         * tui/tui-layout.c (show_layout): Update.
2572         * tui/tui-data.h (class tui_window_iterator): New.
2573         (struct all_tui_windows): New.
2574         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
2575
2576 2019-07-17  Tom Tromey  <tom@tromey.com>
2577
2578         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
2579         parameter.  Don't reference globals.
2580         (tui_reg_command): Update.
2581
2582 2019-07-17  Tom Tromey  <tom@tromey.com>
2583
2584         * tui/tui-regs.c (tui_show_registers): Simplify.
2585
2586 2019-07-17  Tom Tromey  <tom@tromey.com>
2587
2588         * tui/tui-regs.c (tui_show_registers): Update.
2589         (tui_show_register_group): Add win_info parameter.
2590
2591 2019-07-17  Tom Tromey  <tom@tromey.com>
2592
2593         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
2594         Rename from tui_display_reg_element_at_line.
2595         (tui_data_window::display_registers_from_line): Update.
2596         * tui/tui-data.h (struct tui_data_window)
2597         <display_reg_element_at_line>: New method.
2598
2599 2019-07-17  Tom Tromey  <tom@tromey.com>
2600
2601         * tui/tui-regs.h (tui_display_registers_from)
2602         (tui_display_registers_from_line): Don't declare.
2603         * tui/tui-windata.c (tui_data_window::display_all_data)
2604         (tui_data_window::refresh_all)
2605         (tui_data_window::do_scroll_vertical): Update.
2606         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
2607         from tui_display_registers_from.
2608         (tui_display_reg_element_at_line): Update.
2609         (tui_data_window::display_registers_from_line): Rename from
2610         tui_display_registers_from_line.
2611         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
2612         display_registers_from_line>: New methods.
2613
2614 2019-07-17  Tom Tromey  <tom@tromey.com>
2615
2616         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
2617         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
2618         from tui_erase_data_content.
2619         (tui_data_window::display_all_data)
2620         (tui_data_window::refresh_all)
2621         (tui_data_window::do_scroll_vertical): Update.
2622         * tui/tui-regs.c (tui_show_registers): Update.
2623         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
2624         New method.
2625
2626 2019-07-17  Tom Tromey  <tom@tromey.com>
2627
2628         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
2629         declare.
2630         * tui/tui-windata.c
2631         (tui_data_window::delete_data_content_windows): Rename from
2632         tui_delete_data_content_windows.
2633         (tui_data_window::display_all_data)
2634         (tui_data_window::do_scroll_vertical): Update.
2635         * tui/tui-data.h (struct tui_data_window)
2636         <delete_data_content_windows>: New method.
2637
2638 2019-07-17  Tom Tromey  <tom@tromey.com>
2639
2640         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
2641         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
2642
2643 2019-07-17  Tom Tromey  <tom@tromey.com>
2644
2645         * tui/tui-windata.h (tui_display_all_data): Don't declare.
2646         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
2647         from tui_display_all_data.
2648         * tui/tui-win.c
2649         (tui_data_window::do_make_visible_with_new_height): Update.
2650         * tui/tui-regs.c (tui_show_registers): Update.
2651         * tui/tui-layout.c (tui_set_layout): Update.
2652         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
2653         method.
2654
2655 2019-07-17  Tom Tromey  <tom@tromey.com>
2656
2657         * tui/tui-windata.h (tui_display_data_from): Don't declare.
2658         * tui/tui-windata.c (tui_display_data_from): Remove.
2659         (tui_data_window::refresh_all): Update.
2660
2661 2019-07-17  Tom Tromey  <tom@tromey.com>
2662
2663         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
2664         * tui/tui-windata.c (tui_display_data_from_line): Remove.
2665         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
2666         tui_display_registers_from_line.
2667         * tui/tui-regs.h (tui_display_registers_from_line): Update.
2668         * tui/tui-regs.c (tui_display_registers_from_line): Remove
2669         "force_display" parameter.
2670
2671 2019-07-17  Tom Tromey  <tom@tromey.com>
2672
2673         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
2674         declare.
2675         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
2676         Rename from tui_first_reg_element_no_inline.
2677         (tui_display_reg_element_at_line)
2678         (tui_display_registers_from_line): Update.
2679         * tui/tui-data.h (struct tui_data_window)
2680         <first_reg_element_no_inline>: New method.
2681
2682 2019-07-17  Tom Tromey  <tom@tromey.com>
2683
2684         * tui/tui-windata.c (tui_display_data_from)
2685         (tui_data_window::do_scroll_vertical): Update.
2686         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
2687         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
2688         Rename from tui_line_from_reg_element_no.
2689         (tui_display_registers_from_line): Update.
2690         * tui/tui-data.h (struct tui_data_window)
2691         <line_from_reg_element_no>: New method.
2692
2693 2019-07-17  Tom Tromey  <tom@tromey.com>
2694
2695         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
2696         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
2697         tui_last_regs_line_no.
2698         (tui_display_reg_element_at_line)
2699         (tui_display_registers_from_line): Update.
2700         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
2701         method.
2702
2703 2019-07-17  Tom Tromey  <tom@tromey.com>
2704
2705         PR tui/24722:
2706         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
2707         (tui_update_breakpoint_info): Add "being_deleted" parameter.
2708         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2709         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
2710         (tui_update_breakpoint_info): Likewise.
2711         * tui/tui-hooks.c (tui_event_create_breakpoint)
2712         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
2713         Update.
2714
2715 2019-07-17  Tom Tromey  <tom@tromey.com>
2716
2717         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
2718
2719 2019-07-17  Tom Tromey  <tom@tromey.com>
2720
2721         * tui/tui-winsource.c (tui_update_source_window_as_is)
2722         (tui_update_source_windows_with_addr): Update.
2723         * tui/tui-source.h (tui_set_source_content)
2724         (tui_show_symtab_source): Add "win_info" parameter.
2725         * tui/tui-source.c (tui_set_source_content): Add "win_info"
2726         parameter.
2727         (tui_show_symtab_source): Likewise.
2728
2729 2019-07-17  Tom Tromey  <tom@tromey.com>
2730
2731         * tui/tui-wingeneral.c
2732         (tui_check_and_display_highlight_if_needed): Check can_highlight.
2733
2734 2019-07-17  Tom Tromey  <tom@tromey.com>
2735
2736         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
2737         (struct tui_cmd_window) <can_scroll>: New method.
2738         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
2739         method.
2740
2741 2019-07-17  Tom Tromey  <tromey@adacore.com>
2742
2743         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
2744         do_field_signed>: Rename.  Change type of "value".
2745         * ui-out.c (ui_out::field_signed): Rename from field_int.
2746         Change type of "value".
2747         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
2748         type of "value".
2749         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
2750         do_field_int.  Change type of "value".
2751         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
2752         do_field_int.  Change type of "value".
2753         * tracepoint.c (trace_status_mi, tfind_1)
2754         (print_one_static_tracepoint_marker): Update.
2755         * thread.c (print_thread_info_1, print_selected_thread_frame):
2756         Update.
2757         * stack.c (print_frame, print_frame_info): Update.
2758         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
2759         Update.
2760         * source.c (print_source_lines_base): Update.
2761         * skip.c (info_skip_command): Update.
2762         * record-btrace.c (btrace_ui_out_decode_error)
2763         (btrace_call_history_src_line): Update.
2764         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
2765         Update.
2766         * progspace.c (print_program_space): Update.
2767         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
2768         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
2769         do_field_int.  Change type of "value".
2770         * mi/mi-out.c (mi_ui_out::do_table_begin)
2771         (mi_ui_out::do_table_header): Update.
2772         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
2773         type of "value".
2774         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
2775         (mi_cmd_data_list_changed_registers, output_register)
2776         (mi_cmd_data_read_memory, mi_load_progress)
2777         (mi_cmd_trace_frame_collected): Update.
2778         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
2779         Update.
2780         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
2781         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
2782         (mi_cmd_var_list_children, varobj_update_one): Update.
2783         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
2784         (mi_cmd_stack_list_args, list_arg_or_local): Update.
2785         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
2786         * inferior.c (print_inferior): Update.
2787         * gdb_bfd.c (print_one_bfd): Update.
2788         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2789         Update.
2790         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
2791         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
2792         do_field_int.  Change type of "value".
2793         * cli-out.c (cli_ui_out::do_field_signed): Rename from
2794         do_field_int.  Change type of "value".
2795         * breakpoint.c (watchpoint_check, print_breakpoint_location)
2796         (print_one_breakpoint_location, print_it_catch_fork)
2797         (print_one_catch_fork, print_it_catch_vfork)
2798         (print_one_catch_vfork, print_it_catch_solib)
2799         (print_it_catch_exec, print_it_ranged_breakpoint)
2800         (print_mention_watchpoint, print_mention_masked_watchpoint)
2801         (bkpt_print_it, update_static_tracepoint): Update.
2802         * break-catch-throw.c (print_it_exception_catchpoint): Update.
2803         * break-catch-syscall.c (print_it_catch_syscall): Update.
2804         * ada-tasks.c (print_ada_task_info): Update.
2805         * ada-lang.c (print_it_exception, print_mention_exception):
2806         Update.
2807
2808 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2809
2810         PR breakpoints/24541
2811         * gdbarch.c: Regenerate.
2812         * gdbarch.h: Regenerate.
2813         * gdbarch.sh: Adjust return type and parameter types for
2814         'stap_adjust_register'.
2815         (i386_stap_adjust_register): Adjust signature and return new
2816         register name.
2817         * stap-probe.c (stap_parse_register_operand): Adjust use of
2818         'gdbarch_stap_adjust_register'.
2819
2820 2019-07-17  Tom Tromey  <tromey@adacore.com>
2821
2822         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
2823         declare VEC.
2824         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
2825         std::vector.
2826         (struct s390_process_info): Add initializers.
2827         (s390_add_process): Use new.
2828         (s390_linux_nat_target::low_forget_process): Use delete.
2829         (s390_linux_nat_target::low_new_fork)
2830         (s390_linux_nat_target::stopped_by_watchpoint)
2831         (s390_linux_nat_target::low_prepare_to_resume)
2832         (s390_linux_nat_target::insert_watchpoint)
2833         (s390_linux_nat_target::insert_hw_breakpoint)
2834         (s390_linux_nat_target::remove_watchpoint)
2835         (s390_linux_nat_target::remove_hw_breakpoint): Update.
2836
2837 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2838
2839         * aarch64-fbsd-nat.c: Include regcache.h.
2840         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
2841         argument.
2842         (aarch64_fbsd_nat_target::fetch_registers)
2843         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
2844         variable.
2845         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
2846
2847 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2848
2849         * fbsd-nat.c: Include gdbarch.h.
2850
2851 2019-07-15  Tom Tromey  <tromey@adacore.com>
2852
2853         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
2854
2855 2019-07-15  Tom Tromey  <tromey@adacore.com>
2856
2857         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
2858         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
2859         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
2860         * cli-out.c (cli_ui_out::do_field_int): New method.
2861         * ui-out.c (ui_out::field_unsigned): New method.
2862         * symfile.c (generic_load): Use field_unsigned.
2863         (print_transfer_performance): Likewise.
2864         * record-btrace.c (ui_out_field_uint): Remove.
2865         (btrace_call_history_insn_range, btrace_call_history): Use
2866         field_unsigned.
2867         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
2868         field_unsigned.
2869         * ui-out.h (class ui_out) <field_unsigned>: New method.
2870         <do_field_unsigned>: Likewise.
2871
2872 2019-07-15  Tom Tromey  <tromey@adacore.com>
2873
2874         * mi/mi-main.c (list_available_thread_groups): Use field_string.
2875         * mi/mi-interp.c (mi_memory_changed): Use field_string.
2876         * target.c (flash_erase_command): Use field_string.
2877         * infrun.c (print_signal_received_reason): Use field_string.
2878         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
2879         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
2880         field_string.
2881         * ada-tasks.c (print_ada_task_info): Use field_string.
2882
2883 2019-07-15  Tom Tromey  <tromey@adacore.com>
2884
2885         * target.c (flash_erase_command): Use field_core_addr.
2886         * symfile.c (generic_load): Use field_core_addr.
2887         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
2888         Use field_core_addr.
2889         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
2890         field_core_addr.
2891
2892 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2893
2894         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
2895         value if its desired type is smaller than a CORE_ADDR and signed.
2896
2897 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2898
2899         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
2900         of changes to field names, and use new is_reference field to
2901         decide if a property is a reference or not.
2902         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
2903         field.
2904         (struct dwarf2_property_baton): Update header comment, rename
2905         'referenced_type' to 'property_type' and update comments.
2906         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
2907         default property type, store in property baton, update to take
2908         accound of renamed field.
2909         (read_func_scope): Update call to attr_to_dynamic_prop.
2910         (read_array_type): Likewise.
2911         (dwarf2_per_cu_addr_sized_int_type): New function.
2912         (read_subrange_index_type): Move type finding code to
2913         dwarf2_per_cu_addr_sized_int_type.
2914         (read_subrange_type): Update calls to attr_to_dynamic_prop.
2915         (dwarf2_per_cu_addr_type): New function.
2916         (set_die_type): Update calls to attr_to_dynamic_prop.
2917
2918 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2919
2920         * dwarf2read.c (read_subrange_index_type): New function.
2921         (read_subrange_type): Move code into new function and call it.
2922         * gdbtypes.c (create_range_type): Add some asserts.
2923
2924 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2925
2926         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
2927         update return statements.
2928         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
2929         declaration, and update comment to match.
2930         * gdbtypes.c (resolve_dynamic_array): Update call to
2931         dwarf2_evaluate_property to match new return type.
2932
2933 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2934
2935         * valarith.c (value_subscripted_rvalue): Change lowerbound
2936         parameter type from int to LONGEST.
2937         * value.h (value_subscripted_rvalue): Likewise in declaration.
2938
2939 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2940
2941         * cli/cli-utils.c (info_print_command_completer): New function.
2942         * cli/cli-utils.h: Add 'completer.h' include, and forward
2943         declaration for 'struct cmd_list_element'.
2944         (info_print_command_completer): Declare.
2945         * stack.c (_initialize_stack): Add completer for 'info locals' and
2946         'info args'.
2947         * symtab.c (_initialize_symtab): Add completer for 'info
2948         variables' and 'info functions'.
2949         * NEWS: Mention completion for additional info commands.
2950
2951 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2952
2953         * cli/cli-utils.c (extract_info_print_args): Delete.
2954         (extract_arg_maybe_quoted): Delete.
2955         (info_print_options_defs): New variable.
2956         (make_info_print_options_def_group): New function.
2957         (extract_info_print_options): Define new function.
2958         * cli/cli-utils.h (extract_info_print_args): Delete.
2959         (struct info_print_options): New structure.
2960         (extract_info_print_options): Declare new function.
2961         * stack.c (info_locals_command): Update to use new
2962         extract_info_print_options, also add a header comment.
2963         (info_args_command): Likewise.
2964         * symtab.c (info_variables_command): Likewise.
2965         (info_functions_command): Likewise.
2966
2967 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2968
2969         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2970         to extract string arguments.
2971         * common/common-utils.c (extract_string_maybe_quoted): New function.
2972         * common/common-utils.h (extract_string_maybe_quoted): Declare.
2973
2974 2019-07-11  Tom Tromey  <tromey@adacore.com>
2975
2976         * main.c (get_init_files): Use GDBINIT, not gdbinit.
2977         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2978         * top.h (gdbinit): Don't declare.
2979         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2980         into...
2981         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
2982         * top.c (gdb_init): Don't call init_cli_cmds.
2983         (gdbinit): Remove.
2984         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2985
2986 2019-07-11  Tom Tromey  <tromey@adacore.com>
2987
2988         * python/py-inferior.c (add_thread_object): Don't use thread_obj
2989         after it has been moved.
2990
2991 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2992
2993         * valops.c (value_must_coerce_to_target): Change return type to
2994         bool.
2995         * value.h (value_must_coerce_to_target): Likewise.
2996
2997 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
2998
2999         * breakpoint.c (is_hardware_watchpoint): Remove
3000         forward-declaration.
3001         (is_masked_watchpoint): Change return type to bool.
3002         (is_tracepoint): Likewise.
3003         (is_breakpoint): Likewise.
3004         (is_hardware_watchpoint): Likewise.
3005         (is_watchpoint): Likewise.
3006         (is_no_memory_software_watchpoint): Likewise.
3007         (is_catchpoint): Likewise.
3008         (breakpoint_1): Make FILTER parameter's return type bool.
3009         is_masked_watchpoint): Change return type to bool.
3010         (save_breakpoints): Make FILTER parameter's return type bool.
3011         * breakpoint.h (is_breakpoint): Change return type to bool.
3012         (is_watchpoint): Likewise.
3013         (is_catchpoint): Likewise.
3014         (is_tracepoint): Likewise.
3015
3016 2019-07-10  Tom Tromey  <tom@tromey.com>
3017
3018         * defs.h: Don't include gdbarch.h.
3019         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
3020         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
3021         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
3022         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
3023         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
3024         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
3025         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
3026         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
3027         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
3028         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
3029         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
3030         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
3031         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
3032         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
3033         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
3034         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
3035         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
3036         record-btrace.c, record.h, regcache-dump.c, regcache.h,
3037         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
3038         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
3039         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
3040         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
3041         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
3042         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
3043         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
3044         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
3045         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
3046
3047 2019-07-10  Tom Tromey  <tromey@adacore.com>
3048
3049         * ada-lang.h (is_ada_exception_catchpoint): Declare.
3050         * breakpoint.c (init_ada_exception_breakpoint): Register as
3051         bp_catchpoint.
3052         (print_one_breakpoint_location, print_one_breakpoint): Use
3053         is_ada_exception_catchpoint.
3054         * ada-lang.c (class ada_catchpoint_location): Pass
3055         bp_loc_software_breakpoint to bp_location constructor.
3056         (is_ada_exception_catchpoint): New function.
3057
3058 2019-07-10  Tom Tromey  <tromey@adacore.com>
3059
3060         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
3061         VEC.
3062         (struct arm_exidx_entry): New method operator<.
3063         (struct arm_exidx_data) <section_maps>: Change type.
3064         (arm_exidx_data_free): Remove.
3065         (arm_exidx_data_key): Change type.  Move lower.
3066         (arm_exidx_new_objfile): Update.
3067         (arm_compare_exidx_entries): Remove.
3068         (arm_find_exidx_entry, _initialize_arm_tdep)
3069
3070 2019-07-10  Tom Tromey  <tromey@adacore.com>
3071
3072         * solib-spu.c (ocl_program_data_key): Change type.
3073         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
3074         Update.
3075
3076 2019-07-10  Tom Tromey  <tromey@adacore.com>
3077
3078         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
3079         (struct solib_aix_inferior_data) <library_list>: Change type.
3080         (solib_aix_inferior_data_handle): Change type.
3081         (get_solib_aix_inferior_data): Update.
3082         (solib_aix_free_library_list): Remove.
3083         (library_list_start_library): Update.
3084         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
3085         return type.
3086         (solib_aix_get_library_list)
3087         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
3088         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
3089
3090 2019-07-10  Tom Tromey  <tromey@adacore.com>
3091
3092         * solib-dsbt.c (struct dsbt_info): Add initializers.
3093         (solib_dsbt_pspace_data): Change type.
3094         (dsbt_pspace_data_cleanup): Remove.
3095         (get_dsbt_info, _initialize_dsbt_solib): Update.
3096
3097 2019-07-10  Tom Tromey  <tromey@adacore.com>
3098
3099         * spu-tdep.c (spu_overlay_data): Change type.
3100         (spu_get_overlay_table, spu_overlay_new_objfile)
3101         (_initialize_spu_tdep): Update.
3102
3103 2019-07-10  Tom Tromey  <tromey@adacore.com>
3104
3105         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
3106         destructor.
3107         (dbx_objfile_data_key): Change type and declare later.
3108         (DBX_SYMFILE_INFO): Rewrite.
3109         * dbxread.c (dbx_objfile_data_key): Change type.
3110         (dbx_symfile_init): Update.
3111         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
3112         (coffstab_build_psymtabs, elfstab_build_psymtabs)
3113         (stabsect_build_psymtabs, _initialize_dbxread): Update.
3114
3115 2019-07-10  Tom Tromey  <tromey@adacore.com>
3116
3117         * jit.c (jit_program_space_key): Change type.  Move lower.
3118         (get_jit_program_space_data): Update.
3119         (jit_program_space_data_cleanup): Remove.
3120         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
3121         Update.
3122         (struct jit_program_space_data): Add initializers.
3123
3124 2019-07-10  Tom Tromey  <tromey@adacore.com>
3125
3126         * solib-darwin.c (struct darwin_info): Add initializers.
3127         (solib_darwin_pspace_data): Change type.
3128         (darwin_pspace_data_cleanup): Remove.
3129         (get_darwin_info, _initialize_darwin_solib): Update.
3130
3131 2019-07-10  Tom Tromey  <tromey@adacore.com>
3132
3133         * remote-sim.c (struct sim_inferior_data): Add initializers,
3134         constructor, and destructor.
3135         (sim_inferior_data_key): Change type.  Move lower.
3136         (check_for_duplicate_sim_descriptor): Update.
3137         (get_sim_inferior_data): Use new.  Update.
3138         (~sim_inferior_data_cleanup): Rename from
3139         sim_inferior_data_cleanup.  Simplify.
3140         (gdbsim_close_inferior, simulator_command)
3141         (sim_command_completer, _initialize_remote_sim): Update.
3142         (next_pid, INITIAL_PID): Move earlier.
3143
3144 2019-07-10  Tom Tromey  <tromey@adacore.com>
3145
3146         * python/python-internal.h (create_thread_object): Return
3147         gdbpy_ref.
3148         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
3149         * python/py-inferior.c (struct threadlist_entry): Add
3150         constructor.
3151         <thread_obj>: Now a gdbpy_ref.
3152         (thread_to_thread_object): Update.
3153         (add_thread_object): Use new.
3154         (delete_thread_object): Use delete.
3155         (infpy_threads): Update.
3156         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
3157         GIL.
3158
3159 2019-07-10  Tom Tromey  <tromey@adacore.com>
3160
3161         * valops.c (value_cast): Specialize error message for Ada.
3162
3163 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3164
3165         * breakpoint.c (breakpoint_1): Update doc and parameter names.
3166
3167 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3168
3169         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
3170         bpstat_should_step): Return bool, adjust comments.
3171         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
3172         bpstat_should_step): Likewise.
3173
3174 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3175
3176         * features/Makefile: Use feature target descriptions for Arm.
3177         * features/arm/arm-core.c: Generate new file.
3178         * features/arm/arm-fpa.c: Likewise.
3179         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
3180         * features/arm/arm-m-profile.c: Likewise.
3181         * features/arm/arm-vfpv2.c: Likewise.
3182         * features/arm/arm-vfpv3.c: Likewise.
3183         * features/arm/xscale-iwmmxt.c: Likewise.
3184         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
3185
3186 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3187
3188         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
3189         ptrace earlier.
3190
3191 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3192
3193         * features/aarch64-pauth.c: Regenerate.
3194
3195 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
3196
3197         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
3198         bool.
3199         (bpstat_what): Use false instead of 0.
3200
3201 2019-07-09  Pedro Alves  <palves@redhat.com>
3202
3203         * break-catch-throw.c (is_exception_catchpoint): New.
3204         * breakpoint.c (print_one_breakpoint_location): New parameter
3205         'raw_loc'.  Handle it.  Use
3206         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
3207         looking at the breakpoint's type.
3208         (print_one_breakpoint): If handling "maint info breakpoints", also
3209         print locations of exception catchpoints.
3210         * breakpoint.h (is_exception_catchpoint): Declare.
3211
3212 2019-07-09  Pedro Alves  <palves@redhat.com>
3213
3214         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
3215         "addr" field.
3216         (allocate_location_exception_catchpoint): New.
3217         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
3218         (initialize_throw_catchpoint_ops): Install
3219         allocate_location_exception_catchpoint as allocate_location
3220         method.
3221         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
3222         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
3223         bp_loc_other.
3224         (breakpoint_address_is_meaningful): Delete.
3225         (bl_address_is_meaningful): New.
3226         (breakpoint_locations_match): Adjust comment.
3227         (bp_location_from_bp_type): New, factored out of...
3228         (bp_location::bp_location(breakpoint *)): ... this.
3229         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
3230         factored out of...
3231         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
3232         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
3233         breakpoint_address_is_meaningful.
3234         (bp_locations_compare): Adjust comment.
3235         (update_global_location_list): Use bl_address_is_meaningful
3236         instead of breakpoint_address_is_meaningful.
3237         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
3238         explicit.
3239         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
3240         * python/py-breakpoint.c (bppy_get_location): No longer check
3241         whether location is null.
3242
3243 2019-07-09  Pedro Alves  <palves@redhat.com>
3244
3245         PR c++/15468
3246         * breakpoint.c (print_one_breakpoint_location): Remove
3247         single-location assert.
3248
3249 2019-07-09  Tom Tromey  <tom@tromey.com>
3250
3251         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
3252         * configure: Rebuild.
3253         * configure.ac: Change common to gdbsupport.
3254         * gdbsupport: Rename from common.
3255         * acinclude.m4: Change common to gdbsupport.
3256         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
3257         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
3258         gdbsupport.
3259         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
3260         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
3261         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
3262         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
3263         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
3264         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
3265         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
3266         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
3267         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
3268         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
3269         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
3270         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
3271         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
3272         coff-pe-read.c, command.h, compile/compile-c-support.c,
3273         compile/compile-c.h, compile/compile-cplus-symbols.c,
3274         compile/compile-cplus-types.c, compile/compile-cplus.h,
3275         compile/compile-loc2c.c, compile/compile.c, completer.c,
3276         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
3277         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
3278         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
3279         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
3280         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
3281         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
3282         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
3283         features/aarch64-core.c, features/aarch64-fpu.c,
3284         features/aarch64-pauth.c, features/aarch64-sve.c,
3285         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
3286         features/i386/32bit-core.c, features/i386/32bit-linux.c,
3287         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
3288         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
3289         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
3290         features/i386/64bit-core.c, features/i386/64bit-linux.c,
3291         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
3292         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
3293         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
3294         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
3295         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
3296         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
3297         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
3298         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
3299         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
3300         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
3301         go32-nat.c, guile/guile.c, guile/scm-ports.c,
3302         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
3303         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
3304         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
3305         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
3306         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
3307         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
3308         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
3309         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
3310         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
3311         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
3312         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
3313         minsyms.c, mips-linux-tdep.c, namespace.h,
3314         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
3315         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
3316         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
3317         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
3318         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
3319         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
3320         nat/linux-waitpid.c, nat/mips-linux-watch.c,
3321         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
3322         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
3323         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
3324         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
3325         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
3326         procfs.c, producer.c, progspace.h, psymtab.h,
3327         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
3328         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
3329         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
3330         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
3331         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
3332         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
3333         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
3334         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
3335         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
3336         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
3337         target-memory.c, target.c, target.h, target/waitstatus.c,
3338         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
3339         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
3340         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
3341         unittests/array-view-selftests.c,
3342         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
3343         unittests/common-utils-selftests.c,
3344         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
3345         unittests/format_pieces-selftests.c,
3346         unittests/function-view-selftests.c,
3347         unittests/lookup_name_info-selftests.c,
3348         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
3349         unittests/mkdir-recursive-selftests.c,
3350         unittests/observable-selftests.c,
3351         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
3352         unittests/parse-connection-spec-selftests.c,
3353         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
3354         unittests/scoped_fd-selftests.c,
3355         unittests/scoped_mmap-selftests.c,
3356         unittests/scoped_restore-selftests.c,
3357         unittests/string_view-selftests.c, unittests/style-selftests.c,
3358         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
3359         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
3360         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
3361         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
3362         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
3363         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
3364
3365 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3366
3367         * linespec.c (decode_digits_list_mode): Set explicit_line to a
3368         bool value.
3369         (decode_digits_ordinary): Set explicit_line field in sal.
3370         * symtab.c (skip_prologue_sal): Don't skip prologue for a
3371         symtab_and_line that was set on an explicit line number in
3372         assembler code.  Do always update the recorded symtab and line if
3373         we do skip the prologue.
3374
3375 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3376
3377         * breakpoint.c (set_breakpoint_location_function): Remove
3378         explicit_loc parameter.
3379         (momentary_breakpoint_from_master): Update call to
3380         set_breakpoint_location_function.
3381         (add_location_to_breakpoint): Likewise.
3382
3383 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3384
3385         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
3386         required features based on default bfd type when no specific bfd
3387         is present.
3388
3389 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3390
3391         * NEWS: Mention that GDB printf and eval commands can now print
3392         C-style and Ada-style convenience var strings without
3393         calling the inferior.
3394         * printcmd.c (printf_c_string): Locally print GDB internal var
3395         instead of transiting via the inferior.
3396         (printf_wide_c_string): Likewise.
3397
3398 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3399
3400         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
3401
3402 2019-07-04  Tom Tromey  <tom@tromey.com>
3403
3404         PR tui/24724:
3405         * tui/tui-winsource.c (tui_clear_source_content): Update.
3406         (tui_source_window_base::set_is_exec_point_at): Fix comment.
3407         (tui_update_breakpoint_info): Update.
3408         (tui_set_exec_info_content): Update.
3409         * tui/tui-source.c (tui_set_source_content_nil): Update.
3410         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
3411         has_break.
3412         * tui/tui-data.h (enum tui_bp_flag): New.
3413         (tui_bp_flags): New enum flags type.
3414         (struct tui_source_element) <break_mode>: Change type.  Rename
3415         from has_break.
3416         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
3417         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
3418         constants.
3419         * tui/tui-winsource.h: Fix comment.
3420
3421 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3422
3423         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
3424         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
3425         (store_fpregs_to_thread)
3426         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3427         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
3428         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
3429         (IWMMXT_REGS_SIZE): Add define.
3430         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
3431         (fetch_vfp_regs, store_vfp_regs)
3432         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3433         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
3434
3435 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3436
3437         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
3438         defines.
3439         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
3440         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
3441         (ARM_INT_REGISTER_SIZE): ...to this.
3442         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
3443         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
3444         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
3445         (arm_linux_collect_gregset, supply_nwfpe_register)
3446         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
3447         defines.
3448         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
3449         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
3450         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
3451         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
3452         (arm_return_in_memory, arm_store_return_value)
3453         (arm_get_longjmp_target, arm_register_g_packet_guesses)
3454         (arm_record_ld_st_multiple): Likewise.
3455         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
3456         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
3457
3458 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3459
3460         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
3461         AARCH64_DISPLACED_MODIFIED_INSNS.
3462         * aarch64-tdep.c (struct aarch64_displaced_step_data)
3463         (aarch64_displaced_step_copy_insn): Likewise.
3464         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3465         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
3466         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
3467         ARM_DISPLACED_MODIFIED_INSNS.
3468         * arm-tdep.c (arm_gdbarch_init): Likewise.
3469         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3470         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
3471         (struct arm_displaced_step_closure): Use
3472         ARM_DISPLACED_MODIFIED_INSNS.
3473
3474 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3475
3476         * features/Makefile: Remove unused xml files.
3477         * features/aarch64.xml: Remove.
3478         * features/i386/amd64-avx-avx512-linux.xml: Remove.
3479         * features/i386/amd64-avx-avx512.xml: Remove.
3480         * features/i386/amd64-avx-linux.xml: Remove.
3481         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
3482         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
3483         * features/i386/amd64-avx-mpx-linux.xml: Remove.
3484         * features/i386/amd64-avx-mpx.xml: Remove.
3485         * features/i386/amd64-avx.xml: Remove.
3486         * features/i386/amd64-linux.xml: Remove.
3487         * features/i386/amd64-mpx-linux.xml: Remove.
3488         * features/i386/amd64-mpx.xml: Remove.
3489         * features/i386/amd64.xml: Remove.
3490         * features/i386/i386-avx-avx512-linux.xml: Remove.
3491         * features/i386/i386-avx-avx512.xml: Remove.
3492         * features/i386/i386-avx-linux.xml: Remove.
3493         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
3494         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
3495         * features/i386/i386-avx-mpx-linux.xml: Remove.
3496         * features/i386/i386-avx-mpx.xml: Remove.
3497         * features/i386/i386-avx.xml: Remove.
3498         * features/i386/i386-linux.xml: Remove.
3499         * features/i386/i386-mmx-linux.xml: Remove.
3500         * features/i386/i386-mmx.xml: Remove.
3501         * features/i386/i386-mpx-linux.xml: Remove.
3502         * features/i386/i386-mpx.xml: Remove.
3503         * features/i386/i386.xml: Remove.
3504         * features/i386/x32-avx-avx512-linux.xml: Remove.
3505         * features/i386/x32-avx-linux.xml: Remove.
3506         * features/i386/x32-linux.xml: Remove.
3507
3508 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3509
3510         * regformats/aarch64.dat: Remove.
3511         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
3512         * regformats/i386/amd64-avx-linux.dat: Remove.
3513         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
3514         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
3515         * regformats/i386/amd64-linux.dat: Remove.
3516         * regformats/i386/amd64-mpx-linux.dat: Remove.
3517         * regformats/i386/amd64.dat: Remove.
3518         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
3519         * regformats/i386/i386-avx-linux.dat: Remove.
3520         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
3521         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
3522         * regformats/i386/i386-linux.dat: Remove.
3523         * regformats/i386/i386-mmx-linux.dat: Remove.
3524         * regformats/i386/i386-mpx-linux.dat: Remove.
3525         * regformats/i386/i386.dat: Remove.
3526         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
3527         * regformats/i386/x32-avx-linux.dat: Remove.
3528         * regformats/i386/x32-linux.dat: Remove.
3529
3530 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3531
3532         * aarch64-tdep.c: Remove xml self tests.
3533         * amd64-linux-tdep.c: Likewise.
3534         * amd64-tdep.c: Likewise.
3535         * i386-linux-tdep.c: Likewise.
3536         * i386-tdep.c: Likewise.
3537
3538 2019-07-03  Pedro Alves  <palves@redhat.com>
3539
3540         PR cli/24732
3541         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
3542         (pipe_cmd_option_defs): New.
3543         (make_pipe_cmd_options_def_group): New.
3544         (pipe_command): Use gdb::option::process_options.
3545         (pipe_command_completer): New function.
3546         (_initialize_cli_cmds): Install completer for "pipe" command.
3547
3548 2019-07-03  Pedro Alves  <palves@redhat.com>
3549
3550         * cli/cli-option.c (union option_value) <string>: New field.
3551         (struct option_def_and_value): Add ctor, move ctor, dtor and
3552         use DISABLE_COPY_AND_ASSIGN.
3553         (option_def_and_value::clear_value): New.
3554         (parse_option, save_option_value_in_ctx, get_val_type_str)
3555         (add_setshow_cmds_for_options): Handle var_string.
3556         * cli-option.h (union option_def::var_address) <string>: New
3557         field.
3558         (struct string_option_def): New.
3559         * maint-test-options.c (struct test_options_opts): Add default
3560         ctor and use DISABLE_COPY_AND_ASSIGN.
3561         <string_opt>: New field.
3562         (test_options_opts::~test_options_opts): New.
3563         (test_options_opts::dump): Also dump "-string".
3564         (test_options_option_defs): Install "string.
3565
3566 2019-07-03  Pedro Alves  <palves@redhat.com>
3567
3568         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
3569         option_value with a null enumeration.
3570         (complete_options): Save the option values in the context.
3571         (save_option_value_in_ctx): New, factored out from ...
3572         (process_options): ... here.
3573         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
3574         of the function.
3575         * maint-test-options.c (test_options_opts::dump): New, factored
3576         out from ...
3577         (maintenance_test_options_command_mode): ... here.
3578         (maintenance_test_options_command_completion_result): Delete.
3579         (maintenance_test_options_command_completion_text): Update
3580         comment.
3581         (maintenance_show_test_options_completion_result): Change
3582         prototype.  Just print
3583         maintenance_test_options_command_completion_text.
3584         (save_completion_result): New.
3585         (maintenance_test_options_completer_mode): Pass options context to
3586         complete_options, and then save a dump.
3587         (_initialize_maint_test_options): Use add_cmd to install "maint
3588         show test-options-completion-result".
3589
3590 2019-07-03  Pedro Alves  <palves@redhat.com>
3591
3592         * NEWS (New commands): Mention "with" and "maint with".
3593         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
3594         (with_command, with_command_completer): New.
3595         (pipe_command): Adjust to new repeat_previous
3596         interface.
3597         (_initialize_cli_cmds): Install the "with" command and its "w"
3598         alias.
3599         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
3600         declarations.
3601         * cli/cli-setshow.c (parse_cli_var_uinteger)
3602         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
3603         argument strings for all var_types.
3604         (get_setshow_command_value_string): New, factored out from ...
3605         (do_show_command): ... this.
3606         * cli/cli-setshow.h: Include <string>.
3607         (get_setshow_command_value_string): Declare.
3608         * command.h (repeat_previous): Now returns const char *.  Adjust
3609         comment.
3610         * maint.c: Include "cli/cli-cmds.h".
3611         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
3612         (_initialize_maint_cmds): Register the "maintenance with" command.
3613         * top.c (repeat_previous): Move bits from pipe_command here:
3614         Return the saved command line, if any; error out if there's no
3615         command to relaunch.
3616
3617 2019-07-03  Pedro Alves  <palves@redhat.com>
3618
3619         * NEWS (New commands): Mention "maint set/show test-settings"
3620         instead of "maint test-settings".
3621         * maint-test-settings.c (maintenance_test_settings_list): Delete.
3622         (maintenance_test_settings_set_list): Rename to ...
3623         (maintenance_set_test_settings_list): ... this.
3624         (maintenance_test_settings_show_list): Rename to  ...
3625         (maintenance_show_test_settings_list): ... this.
3626         (maintenance_test_settings_cmd): Delete.
3627         (maintenance_test_settings_set_cmd): ...
3628         (maintenance_set_test_settings_cmd): ... this.
3629         (maintenance_test_settings_show_cmd): ...
3630         (maintenance_show_test_settings_cmd): ... this.
3631         (maintenance_test_settings_show_value_cmd):
3632         (maintenance_show_test_settings_value_cmd): ... this.
3633         (_initialize_maint_test_settings): No longer install the "maint
3634         test-settings" prefix command.  Rename "maint test-settings set"
3635         to "maint set test-settings", and "maint test-settings show" to
3636         "maint show test-settings".  Adjust all subcommands.
3637
3638 2019-07-03  Pedro Alves  <palves@redhat.com>
3639
3640         * maint-test-settings.c: Fix file's intro comment.  Replace all
3641         references to "test-options" with references to "test-settings",
3642         in comments.
3643
3644 2019-07-03  Pedro Alves  <palves@redhat.com>
3645
3646         * maint-test-settings.c (maintenance_test_settings_xxx)
3647         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
3648         New.
3649         (maintenance_test_settings_enums): Use them.
3650         (maintenance_test_settings_enum): Default to
3651         maintenance_test_settings_xxx.
3652         (_initialize_maint_test_settings): Initialize
3653         MAINTENANCE_TEST_SETTINGS_FILENAME.
3654
3655 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3656
3657         * breakpoint.h (remove_breakpoints_inf): Change return type to
3658         void, move function documentation here.
3659         * breakpoint.c (remove_breakpoints_inf): Change return type to
3660         void, move function documentation to header.
3661
3662 2019-07-02  Pedro Alves  <palves@redhat.com>
3663
3664         * NEWS (Completion improvements): Mention "info threads".
3665         * thread.c (struct info_threads_opts, info_threads_option_defs)
3666         (make_info_threads_options_def_group): New.
3667         (info_threads_command): Use gdb::option::process_options.
3668         (info_threads_command_completer): New.
3669         (_initialize_thread): Use gdb::option::build_help to build the
3670         help text for "info threads".
3671
3672 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3673
3674         * defs.h (generic_load): Move from here...
3675         * symfile.h (generic_load): ... to here.  Rename name parameter
3676         to args.
3677         * symfile.c (generic_load): Add comment.
3678
3679 2019-07-01  Tom Tromey  <tromey@adacore.com>
3680
3681         * dwarf2read.c
3682         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
3683         declaration of without_params.  Fix formatting.
3684
3685 2019-07-01  Tom Tromey  <tromey@adacore.com>
3686
3687         * ada-exp.y (find_primitive_type): Update.
3688         * ada-lang.h (ada_lookup_symbol): Update.
3689         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
3690         parameter.
3691         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
3692
3693 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3694
3695         PR breakpoints/24541
3696         * gdbarch.c: Regenerate.
3697         * gdbarch.h: Regenerate.
3698         * gdbarch.sh: Add 'stap_adjust_register'.
3699         * i386-tdep.c: Include '<unordered_set>'.
3700         (i386_stap_adjust_register): New function.
3701         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
3702         * stap-probe.c (stap_parse_register_operand): Call
3703         'gdbarch_stap_adjust_register'.
3704
3705 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3706
3707         PR python/24742
3708         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
3709         * python/python.c (do_start_initialization): Use 'xmalloc'
3710         instead of 'PyMem_Malloc'.
3711
3712 2019-06-28  Tom Tromey  <tromey@adacore.com>
3713
3714         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
3715         for Ada.
3716
3717 2019-06-27  Tom Tromey  <tromey@adacore.com>
3718
3719         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
3720         objfile_key.
3721         (arm_find_mapping_symbol, arm_record_special_symbol)
3722         (_initialize_arm_tdep): Update.
3723         (arm_objfile_data_free): Remove.
3724
3725 2019-06-27  Tom Tromey  <tromey@adacore.com>
3726
3727         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
3728         to cp_print_static_field.
3729
3730 2019-06-26  Tom Tromey  <tromey@adacore.com>
3731
3732         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
3733         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
3734         declare.
3735
3736 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3737
3738         * features/aarch64-core.c (create_feature_aarch64_core):
3739         Regenerate.
3740         * features/aarch64-core.xml: Add cpsr flags.
3741
3742 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3743
3744         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
3745         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
3746
3747 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3748
3749         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
3750         field.
3751         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
3752         use.
3753         (arm_record_special_symbol): Don't insert new symbol in sorted
3754         position, push it at the end.
3755
3756 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3757
3758         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
3759         (arm_mapping_symbol_s): Remove.
3760         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
3761         (arm_mapping_symbol_vec): New typedef.
3762         (struct arm_per_objfile): Add constructor.
3763         <section_maps>: Change type to
3764         std::unique_ptr<arm_mapping_symbol_vec[]>.
3765         (arm_compare_mapping_symbols): Remove.
3766         (arm_find_mapping_symbol): Adjust to section_maps type change.
3767         (arm_objfile_data_free): Call delete on arm_per_objfile.
3768         (arm_record_special_symbol): Adjust to section_maps type change.
3769         Allocate arm_per_objfile with new.
3770
3771 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3772
3773         * cli/cli-cmds.c (alias_command): Compare the alias prefix
3774         with the command prefix.
3775
3776 2019-06-25  Tom Tromey  <tom@tromey.com>
3777
3778         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
3779         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
3780
3781 2019-06-25  Tom Tromey  <tom@tromey.com>
3782
3783         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
3784         type.
3785         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
3786         protected.
3787
3788 2019-06-25  Tom Tromey  <tom@tromey.com>
3789
3790         * tui/tui-winsource.c
3791         (tui_source_window_base::set_is_exec_point_at): Add check against
3792         LOA_ADDRESS.
3793
3794 2019-06-25  Tom Tromey  <tom@tromey.com>
3795
3796         * tui/tui-source.c (tui_set_source_content): Don't check before
3797         xfree.
3798         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
3799
3800 2019-06-25  Tom Tromey  <tom@tromey.com>
3801
3802         * tui/tui-winsource.h (tui_update_source_window_as_is)
3803         (tui_alloc_source_buffer, tui_line_is_displayed)
3804         (tui_addr_is_displayed): Change type of win_info.
3805         * tui/tui-winsource.c (tui_update_source_window_as_is)
3806         (tui_clear_source_content, tui_show_source_line)
3807         (tui_show_source_content, tui_source_window_base::refill)
3808         (tui_source_window_base::set_is_exec_point_at)
3809         (tui_source_window_base::set_is_exec_point_at)
3810         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
3811         (tui_alloc_source_buffer, tui_line_is_displayed)
3812         (tui_addr_is_displayed): Change type of win_info.  Update.
3813         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3814         (tui_source_window_base::do_make_visible_with_new_height):
3815         Update.
3816         * tui/tui-source.c (tui_set_source_content)
3817         (tui_set_source_content_nil)
3818         (tui_source_window::do_scroll_vertical): Update.
3819         * tui/tui-layout.c (show_layout): Update.
3820         * tui/tui-disasm.c (tui_set_disassem_content)
3821         (tui_disasm_window::do_scroll_vertical): Update.
3822         * tui/tui-data.h (tui_win_content): Remove.
3823         (struct tui_gen_win_info) <content, content_size>: Remove.
3824         (struct tui_source_element): Add initializers and destructor.
3825         (union tui_which_element, struct tui_win_element): Remove.
3826         (struct tui_source_window_base) <content>: New field.
3827         (struct tui_data_window): Remove destructor.
3828         (tui_alloc_content, tui_free_win_content)
3829         (tui_free_all_source_wins_content): Don't declare.
3830         * tui/tui-data.c (tui_initialize_static_data): Update.
3831         (init_content_element, tui_alloc_content): Remove.
3832         (~tui_gen_win_info): Update.
3833         (~tui_data_window, tui_free_all_source_wins_content)
3834         (tui_free_win_content, free_content, free_content_elements):
3835         Remove.
3836
3837 2019-06-25  Tom Tromey  <tom@tromey.com>
3838
3839         * tui/tui-winsource.h (tui_clear_source_content)
3840         (tui_erase_source_content, tui_show_source_content): Change type
3841         of win_info.
3842         * tui/tui-winsource.c (tui_clear_source_content)
3843         (tui_erase_source_content, tui_show_source_content): Change type
3844         of win_info.
3845         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3846         * tui/tui-source.h (tui_set_source_content_nil): Change type of
3847         win_info.
3848         * tui/tui-source.c (tui_set_source_content_nil): Change type of
3849         win_info.
3850         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
3851
3852 2019-06-25  Tom Tromey  <tom@tromey.com>
3853
3854         * tui/tui-winsource.c (tui_clear_source_content)
3855         (tui_source_window_base::set_is_exec_point_at): Update.
3856         * tui/tui-source.c (tui_set_source_content_nil): Update.
3857         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
3858         a bool.
3859         * tui/tui-data.c (init_content_element): Update.
3860
3861 2019-06-25  Tom Tromey  <tom@tromey.com>
3862
3863         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
3864         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
3865         * tui/tui-layout.c (init_and_make_win): Update.
3866         * tui/tui.h (enum tui_win_type): Update.
3867         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
3868         tui_win_is_auxillary.
3869         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
3870         tui_win_is_auxillary.
3871
3872 2019-06-25  Tom Tromey  <tom@tromey.com>
3873
3874         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
3875         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
3876         (tui_delete_data_content_windows, tui_display_all_data)
3877         (tui_data_window::do_scroll_vertical, tui_display_data_from):
3878         Update.
3879         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
3880         * tui/tui-regs.c (tui_last_regs_line_no)
3881         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3882         (tui_show_registers): Update.
3883         (tui_show_register_group): Return void.  Update.
3884         (tui_display_registers_from, tui_display_reg_element_at_line)
3885         (tui_display_registers_from_line, tui_check_register_values):
3886         Update.
3887         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
3888         member.
3889         (struct tui_data_window) <regs_content>: Now a std::vector.
3890         <regs_content_count>: Remove.
3891         (tui_add_content_elements, tui_free_data_content): Don't declare.
3892         * tui/tui-data.c (tui_data_window::clear_detail): Update.
3893         (init_content_element): Remove DATA_WIN case.  Add assert.
3894         (tui_add_content_elements): Remove.
3895         (tui_data_window): Update.
3896         (tui_free_data_content): Remove.
3897         (free_content_elements): Remove DATA_WIN case.
3898
3899 2019-06-25  Tom Tromey  <tom@tromey.com>
3900
3901         * tui/tui-data.c (tui_data_item_window): Update.
3902         * tui/tui-windata.h (tui_check_data_values): Don't declare.
3903         * tui/tui-windata.c (tui_display_all_data)
3904         (tui_display_data_from_line): Update.
3905         (tui_check_data_values): Remove.
3906         * tui/tui-regs.c (tui_show_register_group)
3907         (tui_display_reg_element_at_line): Update.
3908         * tui/tui-hooks.c (tui_register_changed)
3909         (tui_refresh_frame_and_register_information): Call
3910         tui_check_register_values.
3911         * tui/tui-data.h (struct tui_data_window) <data_content,
3912         data_content_count, data_type>: Remove.
3913         (enum tui_data_type): Remove.
3914
3915         * tui/tui-data.c (tui_data_window::clear_detail)
3916         (~tui_data_window): Update.
3917
3918 2019-06-25  Tom Tromey  <tom@tromey.com>
3919
3920         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
3921         declare.
3922         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
3923         Rename from tui_first_data_item_displayed.  Update.
3924         (tui_data_window::refresh_all)
3925         (tui_data_window::do_scroll_vertical): Update.
3926         * tui/tui-data.h (struct tui_data_window)
3927         <first_data_item_displayed>: Declare new method.
3928
3929 2019-06-25  Tom Tromey  <tom@tromey.com>
3930
3931         * tui/tui-data.h (tui_init_generic_part): Don't declare.
3932         * tui/tui-data.c (tui_init_generic_part): Remove, moving
3933         contents...
3934         (tui_initialize_static_data): ...here.
3935
3936 2019-06-25  Tom Tromey  <tom@tromey.com>
3937
3938         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3939         (tui_display_registers_from, tui_check_register_values): Update.
3940         (tui_display_register): Remove win_info parameter; update.
3941         (tui_get_register): Change type of parameters.
3942         * tui/tui-data.h (struct tui_data_element): Remove.
3943         (union tui_which_element) <data>: Remove.
3944         <data_window>: Change type.
3945         (struct tui_data_item_window): New.
3946         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3947         case.  Add assert.
3948         (~tui_data_item_window): New destructor.
3949         (free_content_elements): Remove DATA_ITEM_WIN case.
3950
3951 2019-06-25  Tom Tromey  <tom@tromey.com>
3952
3953         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3954         Remove.
3955
3956 2019-06-25  Tom Tromey  <tom@tromey.com>
3957
3958         * tui/tui-data.h (struct tui_command_element): Remove.
3959         (union tui_which_element) <command>: Remove.
3960         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
3961         assert.
3962         (free_content_elements): Remove CMD_WIN case.
3963
3964 2019-06-25  Tom Tromey  <tom@tromey.com>
3965
3966         * tui/tui-layout.c (tui_set_layout): Update.
3967         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3968         * tui/tui-data.c (layout_def): Update.
3969
3970 2019-06-25  Tom Tromey  <tom@tromey.com>
3971
3972         * tui/tui-wingeneral.c (tui_refresh_all): Update.
3973         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3974         (tui_source_window_base::set_new_height): Update.
3975         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3976         Update.
3977         (tui_set_locator_fullname, tui_set_locator_info)
3978         (tui_show_frame_info): Update.
3979         * tui/tui-source.c (tui_set_source_content)
3980         (tui_source_is_displayed): Update.
3981         * tui/tui-layout.c (show_source_disasm_command, show_data)
3982         (show_source_or_disasm_and_command): Update.
3983         * tui/tui-disasm.c (tui_set_disassem_content)
3984         (tui_get_begin_asm_address): Update.
3985         * tui/tui-data.h (struct tui_locator_element): Remove.
3986         (union tui_which_element) <locator>: Remove.
3987         (struct tui_locator_window): New.
3988         (tui_locator_win_info_ptr): Change return type.
3989         * tui/tui-data.c (_locator): Change type.
3990         (tui_locator_win_info_ptr): Change return type.
3991         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
3992         (tui_alloc_content): Add assert.
3993
3994 2019-06-25  Tom Tromey  <tom@tromey.com>
3995
3996         * tui/tui-winsource.c
3997         (tui_exec_info_window::maybe_allocate_content): New method.
3998         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3999         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
4000         (make_source_or_disasm_window): Add cast.
4001         * tui/tui-data.h (union tui_which_element) <simple_string>:
4002         Remove.
4003         (struct tui_source_info): New.
4004         (struct tui_source_window_base) <execution_info>: Change type.
4005         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
4006         case, and add assert.
4007         (tui_alloc_content): Add assert.
4008
4009 2019-06-25  Tom Tromey  <tom@tromey.com>
4010
4011         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
4012         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
4013         * tui/tui-data.c (tui_alloc_win_info): Remove.
4014
4015 2019-06-25  Tom Tromey  <tom@tromey.com>
4016
4017         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
4018         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
4019         can_highlight.
4020
4021 2019-06-25  Tom Tromey  <tom@tromey.com>
4022
4023         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
4024         make_visible_with_new_height method.
4025         (tui_win_info::make_visible_with_new_height): New method.
4026         (tui_source_window_base::do_make_visible_with_new_height)
4027         (tui_data_window::do_make_visible_with_new_height)
4028         (tui_cmd_window::do_make_visible_with_new_height): New methods.
4029         (make_visible_with_new_height): Remove.
4030         (tui_resize_all, tui_adjust_win_heights): Use
4031         make_visible_with_new_height method.
4032         * tui/tui-data.h (struct tui_win_info)
4033         <do_make_visible_with_new_height, make_visible_with_new_height>:
4034         New methods.
4035         (struct tui_source_window_base, struct tui_data_window)
4036         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
4037         methods.
4038
4039 2019-06-25  Tom Tromey  <tom@tromey.com>
4040
4041         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
4042         method.
4043         (update_tab_width): Call update_tab_width method.
4044         * tui/tui-data.h (struct tui_win_info)
4045         (struct tui_source_window_base) <update_tab_width>: New methods.
4046
4047 2019-06-25  Tom Tromey  <tom@tromey.com>
4048
4049         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
4050         parameter.
4051         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
4052         parameter.
4053         (tui_gen_win_info::make_visible): Update.
4054         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
4055         parameter.
4056         * tui/tui-data.h (enum tui_box): New enum.
4057         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
4058
4059 2019-06-25  Tom Tromey  <tom@tromey.com>
4060
4061         * tui/tui-layout.c (make_source_or_disasm_window): Always use
4062         init_and_make_win for EXEC_INFO_WIN.
4063         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
4064         longer inline.
4065         (struct tui_win_info) <~tui_win_info>: Inline.
4066         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4067         Don't declare.
4068         * tui/tui-data.c (source_win, disasm_win): Remove globals.
4069         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4070         Remove.
4071         (tui_initialize_static_data): Update.
4072         (~tui_gen_win_info): Handle more cleanup here.
4073         (~tui_source_window_base): Delete "execution_info".
4074         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
4075
4076 2019-06-25  Tom Tromey  <tom@tromey.com>
4077
4078         * tui/tui-layout.c (make_command_window): Don't set
4079         can_highlight.
4080         (show_source_disasm_command): Call the reset method.
4081         (show_data): Don't set can_highlight.  Call the reset method.
4082         (tui_gen_win_info::reset): Rename from init_gen_win_info
4083         (init_and_make_win): Simplify.  Return tui_gen_win_info.
4084         (show_source_or_disasm_and_command): Call the reset method.
4085         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
4086         (struct tui_cmd_window): Set can_highlight.
4087
4088 2019-06-25  Tom Tromey  <tom@tromey.com>
4089
4090         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
4091         from make_visible.
4092         (tui_make_visible, tui_make_invisible): Rewrite.
4093         (tui_win_info::make_visible): Remove.
4094         (tui_source_window_base::make_visible): Update.
4095         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
4096         method.  Moved from...
4097         (struct tui_win_info) <make_visible>: ...here.
4098
4099 2019-06-25  Tom Tromey  <tom@tromey.com>
4100
4101         * tui/tui-winsource.c
4102         (tui_source_window_base::do_scroll_horizontal): Remove direction
4103         parameter.
4104         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
4105         direction parameter.
4106         * tui/tui-win.c (tui_win_info::forward_scroll)
4107         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4108         (tui_win_info::right_scroll): Update.
4109         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
4110         direction parameter.
4111         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
4112         direction parameter.
4113         * tui/tui-data.h (enum tui_scroll_direction): Remove.
4114         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
4115         Remove direction parameter.
4116         (struct tui_source_window_base, struct tui_source_window)
4117         (struct tui_disasm_window, struct tui_data_window)
4118         (struct tui_cmd_window): Update.
4119
4120 2019-06-25  Tom Tromey  <tom@tromey.com>
4121
4122         * tui/tui-winsource.h (tui_set_exec_info_content)
4123         (tui_show_exec_info_content, tui_erase_exec_info_content)
4124         (tui_clear_exec_info_content, tui_update_exec_info): Change
4125         argument to tui_source_window_base.
4126         * tui/tui-winsource.c (tui_set_exec_info_content)
4127         (tui_show_exec_info_content, tui_erase_exec_info_content)
4128         (tui_clear_exec_info_content, tui_update_exec_info): Change
4129         argument to tui_source_window_base.
4130
4131 2019-06-25  Tom Tromey  <tom@tromey.com>
4132
4133         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
4134         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
4135
4136 2019-06-25  Tom Tromey  <tom@tromey.com>
4137
4138         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
4139         check.
4140
4141 2019-06-25  Tom Tromey  <tom@tromey.com>
4142
4143         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
4144         type to void.
4145         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
4146         type to void.
4147         * tui/tui-source.c (tui_set_source_content): Update.
4148         * tui/tui-disasm.c (tui_set_disassem_content): Update.
4149
4150 2019-06-25  Tom Tromey  <tom@tromey.com>
4151
4152         * tui/tui-win.c (window_name_completer, tui_set_focus)
4153         (tui_all_windows_info): Use name method.
4154         * tui/tui-data.h (struct tui_gen_win_info)
4155         (struct tui_source_window, struct tui_disasm_window)
4156         (struct tui_data_window, struct tui_cmd_window) <name>: New
4157         method.
4158         (tui_win_name): Don't declare.
4159         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
4160         (tui_win_name): Remove.
4161
4162 2019-06-25  Tom Tromey  <tom@tromey.com>
4163
4164         * tui/tui-winsource.h (tui_update_source_window)
4165         (tui_update_source_window_as_is): Change parameter type.
4166         * tui/tui-winsource.c (tui_update_source_window): Change win_info
4167         to be a tui_source_window_base.
4168         (tui_update_source_window_as_is): Likewise.
4169         * tui/tui-win.c (make_visible_with_new_height): Update.
4170
4171 2019-06-25  Tom Tromey  <tom@tromey.com>
4172
4173         * tui/tui-winsource.c (tui_erase_source_content)
4174         (tui_show_source_content, tui_show_exec_info_content)
4175         (tui_erase_exec_info_content): Use refresh_window method.
4176         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
4177         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
4178         from tui_refresh_win.
4179         (tui_data_window::refresh_window): New method.
4180         (tui_win_info::refresh, tui_source_window_base::refresh)
4181         (tui_refresh_all): Use refresh_window method.
4182         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
4183         method.
4184         * tui/tui-regs.c (tui_display_register): Call refresh_window
4185         method.
4186         * tui/tui-layout.c (show_source_disasm_command)
4187         (show_source_or_disasm_and_command): Call refresh_window method.
4188         * tui/tui-data.h (struct tui_gen_win_info)
4189         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
4190         New method.
4191
4192 2019-06-25  Tom Tromey  <tom@tromey.com>
4193
4194         * tui/tui.c (tui_rl_other_window, tui_enable)
4195         (tui_is_window_visible, tui_get_command_dimension): Update.
4196         * tui/tui-winsource.c (tui_update_source_window_as_is)
4197         (tui_clear_source_content, tui_erase_source_content)
4198         (tui_show_source_line, tui_source_window_base::refill)
4199         (tui_source_window_base::do_scroll_horizontal)
4200         (tui_source_window_base::set_is_exec_point_at)
4201         (tui_update_breakpoint_info, tui_set_exec_info_content)
4202         (tui_alloc_source_buffer, tui_line_is_displayed)
4203         (tui_addr_is_displayed): Update.
4204         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4205         (tui_check_and_display_highlight_if_needed)
4206         (tui_win_info::make_visible, tui_win_info::refresh)
4207         (tui_refresh_all): Update.
4208         * tui/tui-windata.c (tui_first_data_item_displayed)
4209         (tui_delete_data_content_windows, tui_erase_data_content)
4210         (tui_display_all_data, tui_data_window::refresh_all)
4211         (tui_check_data_values): Update.
4212         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
4213         (tui_set_win_focus_to, tui_win_info::forward_scroll)
4214         (tui_win_info::backward_scroll, tui_refresh_all_win)
4215         (tui_resize_all, tui_set_focus, tui_all_windows_info)
4216         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
4217         (tui_source_window_base::set_new_height)
4218         (tui_data_window::set_new_height)
4219         (make_invisible_and_set_new_height)
4220         (make_visible_with_new_height, new_height_ok)
4221         (parse_scrolling_args): Update.
4222         * tui/tui-stack.c (tui_show_frame_info): Update.
4223         * tui/tui-source.c (tui_set_source_content)
4224         (tui_set_source_content_nil, tui_source_is_displayed)
4225         (tui_source_window::do_scroll_vertical): Update.
4226         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4227         (tui_display_registers_from, tui_display_reg_element_at_line)
4228         (tui_check_register_values, tui_reg_command): Update.
4229         * tui/tui-layout.c (tui_default_win_height)
4230         (show_source_disasm_command, show_data, init_and_make_win)
4231         (show_source_or_disasm_and_command): Update.
4232         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
4233         (tui_redisplay_readline, tui_mld_flush)
4234         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
4235         (tui_getc): Update.
4236         * tui/tui-disasm.c (tui_set_disassem_content)
4237         (tui_disasm_window::do_scroll_vertical): Update.
4238         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
4239         Now virtual.
4240         (struct tui_win_info): Derive from tui_gen_win_info.
4241         <~tui_win_info>: Mark as override.
4242         <generic>: Remove member.
4243         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
4244         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
4245         (~tui_data_window, ~tui_win_info)
4246         (tui_free_all_source_wins_content): Update.
4247         * tui/tui-command.c (tui_refresh_cmd_win): Update.
4248
4249 2019-06-25  Tom Tromey  <tom@tromey.com>
4250
4251         * tui/tui-layout.c (init_and_make_win): Use new.
4252         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
4253         destructor, initializers.
4254         (tui_alloc_generic_win_info): Don't declare.
4255         * tui/tui-data.c (_locator): Add argument to constructor.
4256         (source_win, disasm_win): New globals.
4257         (exec_info): Remove.
4258         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4259         Update.
4260         (tui_alloc_generic_win_info): Remove.
4261         (init_content_element): Use new.
4262         (tui_win_info::tui_win_info): Update.
4263         (free_content_elements) <case DATA_WIN>: Use delete.
4264
4265 2019-06-25  Tom Tromey  <tom@tromey.com>
4266
4267         * tui/tui-wingeneral.c (tui_refresh_win): Update.
4268         * tui/tui-windata.c (tui_first_data_item_displayed)
4269         (tui_delete_data_content_windows): Update.
4270         * tui/tui-win.c (tui_data_window::set_new_height): Update.
4271         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4272         (tui_display_registers_from, tui_check_register_values): Update.
4273         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
4274         pointer.
4275         * tui/tui-data.c (init_content_element): Update.  Allocate the new
4276         window.
4277         (tui_free_data_content): Update.
4278         (free_content_elements) <case DATA_WIN>: Free the window.
4279
4280 2019-06-25  Tom Tromey  <tom@tromey.com>
4281
4282         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
4283         Update.
4284         * tui/tui-layout.c (make_command_window)
4285         (show_source_disasm_command, show_data, init_and_make_win)
4286         (show_source_or_disasm_and_command): Update.
4287         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
4288         method.
4289         <can_highight, is_highlighted>: Now bool.
4290         (tui_set_win_highlight): Don't declare.
4291         * tui/tui-data.c (tui_set_win_highlight): Remove.
4292
4293 2019-06-25  Tom Tromey  <tom@tromey.com>
4294
4295         * tui/tui-wingeneral.c (make_visible): Remove check of window
4296         type.
4297
4298 2019-06-25  Tom Tromey  <tom@tromey.com>
4299
4300         * tui/tui-win.c (tui_win_info::max_height)
4301         (tui_cmd_window::max_height): New methods.
4302         (new_height_ok): Call max_height.
4303         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
4304         <max_height>: New method.
4305
4306 2019-06-25  Tom Tromey  <tom@tromey.com>
4307
4308         * tui/tui-win.c (tui_source_window_base::set_new_height)
4309         (tui_data_window::set_new_height): New methods.
4310         (make_invisible_and_set_new_height): Call set_new_height method.
4311         * tui/tui-data.h (struct tui_win_info)
4312         (struct tui_source_window_base, struct tui_data_window)
4313         <set_new_height>: New method.
4314
4315 2019-06-25  Tom Tromey  <tom@tromey.com>
4316
4317         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
4318         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
4319         tui_refresh_data_win.
4320         * tui/tui-win.c (tui_source_window_base::refresh_all): New
4321         method.
4322         (tui_refresh_all_win): Call the refresh_all method.
4323         (tui_set_focus): Likewise.
4324         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
4325         (struct tui_source_window_base, struct tui_data_window) <refresh>:
4326         Likewise.
4327
4328 2019-06-25  Tom Tromey  <tom@tromey.com>
4329
4330         * tui/tui-winsource.h (tui_refill_source_window)
4331         (tui_set_is_exec_point_at): Don't declare.
4332         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4333         (tui_source_window_base::refill): Rename from
4334         tui_refill_source_window.
4335         (tui_source_window_base::do_scroll_horizontal): Update.
4336         (tui_source_window_base::set_is_exec_point_at): Rename from
4337         tui_set_is_exec_point_at.
4338         (tui_update_all_breakpoint_info): Update.
4339         * tui/tui-stack.c (tui_show_frame_info): Update.
4340         * tui/tui-layout.c (show_data): Add cast.
4341         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
4342         * tui/tui-data.h (struct tui_source_window_base) <refill,
4343         set_is_exec_point_at>: New methods.
4344         (tui_source_windows, tui_add_to_source_windows): Update types.
4345         (tui_add_to_source_windows): Remove redundant declaration.
4346         * tui/tui-data.c (source_windows): Store tui_source_window_base.
4347         (tui_source_windows): Change return type.
4348         (tui_clear_source_windows_detail): Update.
4349         (tui_add_to_source_windows): Change type of parameter.
4350         (tui_free_all_source_wins_content): Update.
4351
4352 2019-06-25  Tom Tromey  <tom@tromey.com>
4353
4354         * tui/tui-wingeneral.c (tui_win_info::refresh)
4355         (tui_source_window_base::refresh): New methods.
4356         (tui_refresh_all): Call the refresh method.
4357         * tui/tui-data.h (struct tui_win_info)
4358         (struct tui_source_window_base) <refresh>: New method.
4359
4360 2019-06-25  Tom Tromey  <tom@tromey.com>
4361
4362         * tui/tui.h (tui_is_window_visible): Return bool.
4363         * tui/tui.c (tui_is_window_visible): Return bool.
4364         * tui/tui-wingeneral.c (tui_make_window, make_visible)
4365         (tui_make_visible, tui_make_invisible)
4366         (tui_win_info::make_visible)
4367         (tui_source_window_base::make_visible, make_all_visible)
4368         (tui_make_all_visible, tui_make_all_invisible): Update.
4369         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
4370         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
4371         bool.
4372         (struct tui_win_info, struct tui_source_window_base)
4373         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
4374         * tui/tui-data.c (tui_init_generic_part): Update.
4375
4376 2019-06-25  Tom Tromey  <tom@tromey.com>
4377
4378         * tui/tui-wingeneral.c (tui_win_info::make_visible)
4379         (tui_source_window_base::make_visible): New methods.
4380         (make_all_visible): Make method call.
4381         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
4382         (struct tui_source_window_base, struct tui_cmd_window): Override
4383         make_visible.
4384         (tui_win_is_source_type): Don't declare.
4385         * tui/tui-data.c (tui_win_is_source_type): Remove.
4386
4387 2019-06-25  Tom Tromey  <tom@tromey.com>
4388
4389         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
4390         NULL check.
4391
4392 2019-06-25  Tom Tromey  <tom@tromey.com>
4393
4394         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
4395         Inline constructor.  Add initializers for members.
4396         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
4397         constructors; now inline in class.
4398
4399 2019-06-25  Tom Tromey  <tom@tromey.com>
4400
4401         * tui/tui-regs.c (tui_show_registers): Update.
4402         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
4403         bool.
4404         * tui/tui-data.c (tui_data_window::clear_detail)
4405         (tui_data_window): Update.
4406
4407 2019-06-25  Tom Tromey  <tom@tromey.com>
4408
4409         * tui/tui-windata.c (tui_display_all_data)
4410         (tui_display_data_from_line, tui_display_data_from)
4411         (tui_check_data_values, tui_data_window::do_scroll_vertical):
4412         Update.
4413         * tui/tui-regs.c (tui_last_regs_line_no)
4414         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4415         (tui_show_registers, tui_show_register_group)
4416         (tui_display_registers_from, tui_display_reg_element_at_line)
4417         (tui_display_registers_from_line, tui_check_register_values)
4418         (tui_reg_next, tui_reg_prev): Update.
4419         * tui/tui-layout.c (tui_set_layout, show_data): Update.
4420         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
4421         tui_data_window.
4422         (struct tui_win_info) <detail>: Remove.  Add new fields from
4423         tui_data_info.
4424         (TUI_DATA_WIN): Add cast.
4425         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
4426         (~tui_data_window): Simplify.
4427
4428 2019-06-25  Tom Tromey  <tom@tromey.com>
4429
4430         * tui/tui-layout.c (show_source_disasm_command)
4431         (show_source_or_disasm_and_command): Update.
4432         * tui/tui-io.c (update_cmdwin_start_line)
4433         (tui_redisplay_readline): Update.
4434         * tui/tui-data.h (struct tui_command_info): Remove.
4435         (struct tui_win_info) <detail>: Remove command_info member.
4436         (struct tui_data_window) <start_line>: New member, from
4437         tui_command_info.
4438         (TUI_CMD_WIN): Add casts.
4439
4440 2019-06-25  Tom Tromey  <tom@tromey.com>
4441
4442         * tui/tui-winsource.c (tui_update_source_window)
4443         (tui_refill_source_window)
4444         (tui_source_window_base::do_scroll_horizontal)
4445         (tui_update_breakpoint_info, tui_set_exec_info_content)
4446         (tui_show_exec_info_content, tui_erase_exec_info_content)
4447         (tui_clear_exec_info_content): Update.
4448         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
4449         Update.
4450         * tui/tui-win.c (make_invisible_and_set_new_height)
4451         (make_visible_with_new_height): Update.
4452         * tui/tui-source.c (tui_set_source_content)
4453         (tui_show_symtab_source): Update.
4454         * tui/tui-layout.c (extract_display_start_addr)
4455         (show_source_disasm_command, show_data)
4456         (make_source_or_disasm_window)
4457         (show_source_or_disasm_and_command): Update.
4458         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
4459         (tui_disasm_window::do_scroll_vertical): Remove shadowing
4460         "gdbarch".
4461         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
4462         to tui_source_window_base.
4463         (struct tui_win_info) <detail>: Remove source_info member.
4464         (struct tui_source_window_base) <has_locator>: Inline.
4465         Move contents from tui_source_info; rename has_locator member to
4466         m_has_locator.
4467         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
4468         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
4469         header file.
4470         (tui_source_window_base::clear_detail, ~tui_source_window_base):
4471         Simplify.
4472         (tui_free_all_source_wins_content): Cast to
4473         tui_source_window_base.
4474
4475 2019-06-25  Tom Tromey  <tom@tromey.com>
4476
4477         * tui/tui-win.c (make_invisible_and_set_new_height)
4478         (make_visible_with_new_height): Call has_locator method.
4479         * tui/tui-layout.c (show_source_disasm_command, show_data)
4480         (show_source_or_disasm_and_command): Update for bool change.
4481         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
4482         (tui_win_info) <has_locator>: New method.
4483         (struct tui_source_window_base) <has_locator>: New method.
4484         (tui_win_has_locator): Don't declare.
4485         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
4486         from tui_win_has_locator.
4487         (tui_source_window_base): Use false, not FALSE.
4488
4489 2019-06-25  Tom Tromey  <tom@tromey.com>
4490
4491         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
4492         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
4493         clear_detail method directly.
4494         (tui_clear_win_detail): Remove.
4495
4496 2019-06-25  Tom Tromey  <tom@tromey.com>
4497
4498         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
4499         "this", not TUI_DISASM_WIN.
4500
4501 2019-06-25  Tom Tromey  <tom@tromey.com>
4502
4503         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
4504         declare.
4505         * tui/tui-winsource.c
4506         (tui_source_window_base::do_scroll_horizontal): Rename from
4507         tui_horizontal_source_scroll.
4508         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
4509         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
4510         from tui_vertical_data_scroll.
4511         * tui/tui-win.h (tui_scroll): Don't declare.
4512         * tui/tui-win.c (tui_win_info::forward_scroll)
4513         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4514         (tui_win_info::right_scroll): Rename and update.
4515         (tui_scroll_forward_command, tui_scroll_backward_command)
4516         (tui_scroll_left_command, tui_scroll_right_command): Update.
4517         (tui_scroll): Remove.
4518         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
4519         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
4520         from tui_vertical_source_scroll.
4521         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
4522         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
4523         from tui_vertical_disassem_scroll.
4524         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
4525         do_scroll_horizontal>: New methods.
4526         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
4527         Likewise.
4528         (struct tui_source_window_base): Add do_scroll_horizontal.
4529         (struct tui_source_window, struct tui_disasm_window): Add
4530         do_scroll_vertical.
4531         (struct tui_data_window, struct tui_cmd_window): Add
4532         do_scroll_horizontal and do_scroll_vertical.
4533         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
4534
4535 2019-06-25  Tom Tromey  <tom@tromey.com>
4536
4537         * tui/tui-data.h (struct tui_source_window_base): New struct.
4538         (struct tui_source_window): Derive from tui_source_window_base.
4539         (struct tui_disasm_window): New struct.
4540         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
4541         from tui_source_window::clear_detail.
4542         (tui_source_window_base): Rename from tui_source_window.
4543         (~tui_source_window_base): Rename from ~tui_source_window.
4544         (tui_alloc_win_info): Create a tui_disasm_window.
4545
4546 2019-06-25  Tom Tromey  <tom@tromey.com>
4547
4548         * tui/tui-data.h (struct tui_source_window)
4549         (struct tui_data_window): Declare destructors.
4550         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
4551         destructors.
4552         (tui_win_info): Simplify.
4553
4554 2019-06-25  Tom Tromey  <tom@tromey.com>
4555
4556         * tui/tui-winsource.c (tui_display_main)
4557         (tui_update_source_windows_with_addr)
4558         (tui_update_all_breakpoint_info): Update.
4559         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4560         (new_height_ok, parse_scrolling_args): Update.
4561         * tui/tui-stack.c (tui_show_frame_info): Update.
4562         * tui/tui-data.h (struct tui_list): Remove.
4563         (tui_source_windows): Return a reference to a std::vector.
4564         * tui/tui-data.c (source_windows): Now a std::vector.
4565         (tui_source_windows): Change return type.
4566         (tui_clear_source_windows): Rewrite.
4567         (tui_clear_source_windows_detail, tui_add_to_source_windows)
4568         (tui_free_all_source_wins_content): Rewrite.
4569
4570 2019-06-25  Tom Tromey  <tom@tromey.com>
4571
4572         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
4573         (struct tui_data_window, struct tui_cmd_window): Declare
4574         clear_detail method.
4575         * tui/tui-data.c (tui_source_window::clear_detail)
4576         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
4577         methods.
4578         (tui_clear_win_detail): Simplify.
4579
4580 2019-06-25  Tom Tromey  <tom@tromey.com>
4581
4582         * tui/tui-layout.c (make_source_window, make_disasm_window)
4583         (make_source_or_disasm_window): Remove win_info_ptr parameter.
4584         Return the new window.
4585         (show_source_disasm_command, show_data)
4586         (show_source_or_disasm_and_command): Update.
4587
4588 2019-06-25  Tom Tromey  <tom@tromey.com>
4589
4590         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
4591         parameter.  Return the new window.
4592         (show_source_disasm_command): Update and remove NULL check.
4593         (show_source_or_disasm_and_command): Update.
4594
4595 2019-06-25  Tom Tromey  <tom@tromey.com>
4596
4597         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
4598
4599 2019-06-25  Tom Tromey  <tom@tromey.com>
4600
4601         * tui/tui-data.h (struct tui_win_info): Make constructor
4602         protected.  Make destructor virtual.  Add initializers.
4603         (tui_source_window, tui_data_window, tui_cmd_window): New
4604         classes.
4605         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
4606         constructor.  Add "type" parameter.
4607         (tui_source_window, tui_data_window, tui_cmd_window): New
4608         constructors.
4609         (tui_alloc_win_info): Instantiate the appropriate subclass.
4610
4611 2019-06-25  Tom Tromey  <tom@tromey.com>
4612
4613         * tui/tui-win.c (tui_resize_all): Use delete.
4614         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
4615         destructor.
4616         (tui_free_window): Don't declare.
4617         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
4618         Update.
4619
4620 2019-06-25  Tom Tromey  <tom@tromey.com>
4621
4622         * tui/tui-data.h (struct tui_win_info): Add constructor.
4623         * tui/tui-data.c (tui_alloc_win_info): Use new.
4624         (tui_free_window): Use delete.
4625
4626 2019-06-22  Tom Tromey  <tom@tromey.com>
4627
4628         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
4629         declare.
4630         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
4631
4632 2019-06-22  Tom Tromey  <tom@tromey.com>
4633
4634         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
4635         declare.
4636         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
4637
4638 2019-06-22  Tom de Vries  <tdevries@suse.de>
4639
4640         * dwarf2read.c (create_addrmap_from_aranges)
4641         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
4642         instead of '%zu'.
4643
4644 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
4645
4646         * dwarf2read.h (dwarf2_section_info_def): Remove.
4647         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
4648         * dwarf2read.c (struct dwo_sections) <types>: Change type to
4649         std::vector<dwarf2_section_info>.
4650         (struct dwo_file) <~dwo_file>: Remove.
4651         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
4652         types field.
4653         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
4654         (dwarf2_read_debug_names): Likewise.
4655         (create_debug_types_hash_table): Change parameter type to
4656         array_view, adjust code accordingly.
4657         (dwarf2_locate_dwo_sections): Adjust to std::vector.
4658         (partial_die_info::fixup): Likewise.
4659         (determine_prefix): Likewise.
4660         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
4661
4662 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4663
4664         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
4665         gdb_bfd_ref_ptr.
4666         <~dwo_file>: Remove call to gdb_bfd_unref.
4667         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
4668         gdb_bfd_ref_ptr::get.
4669
4670 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4671
4672         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
4673         type to htab_up.
4674         * dwarf2read.c (struct dwo_file): Initialize fields.
4675         <~dwo_file>: New.
4676         (free_dwo_file): Remove, move content to ~dwo_file.
4677         (struct dwo_file_deleter): Remove.
4678         (dwo_file_up>: Remove custom deleter.
4679         (free_dwo_files): Remove.
4680         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
4681         dwo_files.
4682         (process_skeletonless_type_units): Call unique_ptr::get.
4683         (allocate_dwo_file_hash_table): Add deleter to created hash
4684         table.  Change return type to htab_up.
4685         (lookup_dwo_file_slot): Don't memset dwo_file, call
4686         unique_ptr::get.
4687         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
4688         (create_dwo_unit_in_dwp_v2): Likewise.
4689         (open_and_init_dwo_file): Likewise.
4690         (free_dwo_file_from_slot): Remove.
4691
4692 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4693
4694         * dwarf2read.h (struct dwarf2_section_info) <readin,
4695         is_virtual>: Change type to bool.
4696         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
4697         true instead of 1.
4698
4699 2019-06-19  Tom Tromey  <tom@tromey.com>
4700
4701         * tui/tui-data.h (tui_init_content_element): Don't declare.
4702
4703 2019-06-19  Tom Tromey  <tom@tromey.com>
4704
4705         * tui/tui-data.h (tui_init_win_info): Don't declare.
4706
4707 2019-06-19  Tom de Vries  <tdevries@suse.de>
4708
4709         * dwarf2read.h (abstract_to_concrete): Change type to
4710         std::unordered_map<sect_offset, std::vector<sect_offset>,
4711         gdb::hash_enum<sect_offset>>.
4712
4713 2019-06-19  Tom Tromey  <tromey@adacore.com>
4714
4715         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
4716         EVAL_AVOID_SIDE_EFFECTS specially.
4717
4718 2019-06-19  Tom Tromey  <tromey@adacore.com>
4719
4720         * source-cache.c (highlighter): New global.
4721         (source_cache::get_source_lines): Create a highlighter on demand.
4722
4723 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4724
4725         * defs.h (deprecated_interactive_hook): Delete declaration.
4726         * interps.c (clear_interpreter_hooks): Remove use of
4727         deprecated_interactive_hook.
4728         * top.c (deprecated_interactive_hook): Delete definition.
4729         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
4730
4731 2019-06-18  Tom de Vries  <tdevries@suse.de>
4732
4733         PR gdb/24515
4734         * dwarf2read.h (abstract_to_concrete): Change type from
4735         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
4736         std::unordered_map<sect_offset, std::vector<sect_offset>>.
4737         * dwarf2read.c (read_variable): Update.
4738         (dwarf2_fetch_die_loc_sect_off): Update.
4739
4740 2019-06-17  Tom de Vries  <tdevries@suse.de>
4741
4742         PR gdb/24617
4743         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
4744         accessing parent[parent_len - 1].
4745
4746 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
4747
4748         PR gdb/24364
4749         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
4750         call dtrace_process_dof with NULL dof.
4751
4752 2019-06-16  Tom de Vries  <tdevries@suse.de>
4753
4754         PR gdb/24445
4755         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
4756
4757 2019-06-16  Tom Tromey  <tom@tromey.com>
4758
4759         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4760         (make_all_visible): Use address of member.
4761
4762 2019-06-16  Tom Tromey  <tom@tromey.com>
4763
4764         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
4765         (tui_free_window, free_content, free_content_elements): Remove
4766         unnecessary cast.
4767         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
4768         cast.
4769         * tui/tui-regs.c (tui_show_register_group)
4770         (tui_display_registers_from, tui_display_reg_element_at_line):
4771         Remove unnecessary cast.
4772
4773 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
4774
4775         * linux-nat.c (normal_mask): Delete.
4776         (_initialize_linux_nat): Don't initialise normal_mask.
4777
4778 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
4779
4780         PR gdb/24445
4781         * dwarf-index-write.h (write_psymtabs_to_index): Add
4782         dwz_basename parameter.
4783         * dwarf-index-write.c (write_gdbindex): Move file writing to
4784         write_gdbindex_1.  Change return type void.
4785         (assert_file_size): Move up, remove filename parameter.
4786         (write_gdbindex_1): New function.
4787         (write_debug_names): Change return type to void, call
4788         assert_file_size.
4789         (struct index_wip_file): New struct.
4790         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
4791         file logic to index_wip_file.  Write index for dwz file if
4792         needed.
4793         (save_gdb_index_command): Pass basename of dwz file, if present.
4794         * dwarf-index-cache.c (index_cache::store): Obtain and pass
4795         build-id of dwz file, if present.
4796         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
4797         (dwarf2_get_dwz_file): Likewise.
4798         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
4799         (dwarf2_get_dwz_file): Likewise.
4800
4801 2019-06-16  Tom Tromey  <tom@tromey.com>
4802
4803         * coffread.c (process_coff_symbol): Use xstrdup.
4804         * value.c (create_internalvar): Use xstrdup.
4805
4806 2019-06-16  Tom Tromey  <tom@tromey.com>
4807
4808         * valops.c (value_cast, value_slice): Remove unnecessary cast.
4809         * breakpoint.c (stopin_command, stopat_command)
4810         (until_break_command, decode_location_default): Remove unnecessary
4811         cast.
4812         * utils.c (subset_compare): Remove unnecessary cast.
4813         * ada-lang.c (ada_update_initial_language): Remove unnecessary
4814         cast.
4815         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
4816         cast.
4817         * infcmd.c (path_command): Remove unnecessary cast.
4818         * coffread.c (decode_type): Remove unnecessary cast.
4819         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
4820         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
4821         * tui/tui-stack.c (tui_show_locator_content)
4822         (tui_show_frame_info): Remove unnecessary cast.
4823         * tui/tui-win.c (tui_scroll_forward_command)
4824         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
4825         (parse_scrolling_args): Remove unnecessary cast.
4826         * tui/tui-data.c (init_win_info, tui_del_window)
4827         (tui_free_window, tui_del_data_windows, tui_free_data_content)
4828         (free_content_elements): Remove unnecessary cast.
4829         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
4830         unnecessary cast.
4831         * tui/tui-source.c (tui_set_source_content)
4832         (tui_vertical_source_scroll): Remove unnecessary cast.
4833         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
4834         cast.
4835         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
4836         * tui/tui-regs.c (tui_display_registers_from)
4837         (tui_display_register): Remove unnecessary cast.
4838         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
4839         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
4840         (make_visible): Remove unnecessary cast.
4841         * tui/tui-winsource.c (tui_erase_source_content)
4842         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
4843         unnecessary cast.
4844         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
4845         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
4846         * stabsread.c (read_type, read_array_type, read_range_type):
4847         Remove unnecessary cast.
4848         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
4849         (parse_symbol, parse_type, upgrade_type, parse_external)
4850         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
4851         unnecessary cast.
4852         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
4853
4854 2019-06-16  Tom Tromey  <tom@tromey.com>
4855
4856         * tui/tui-data.c (tui_alloc_generic_win_info)
4857         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
4858         checks.
4859
4860 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
4861             Andrew Burgess  <andrew.burgess@embecosm.com>
4862
4863         * f-typeprint.c (f_print_type): Don't return early for not
4864         associated or not allocated types.
4865         (f_type_print_varspec_suffix): Add print_rank parameter and print
4866         ranks of array types in case they dangling.
4867         (f_type_print_base): Add print_rank parameter.
4868
4869 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4870
4871         * NEWS: Mention new MI commands.
4872         * break-catch-throw.c (enum exception_event_kind): Move to
4873         breakpoint.h.
4874         (print_mention_exception_catchpoint): Output text as a single
4875         message.
4876         (catch_exception_command_1): Rename to...
4877         (catch_exception_event): ...this, make non-static, update header
4878         command, and change some parameter types.
4879         (catch_catch_command): Update for changes to
4880         catch_exception_command_1.
4881         (catch_throw_command): Likewise.
4882         (catch_rethrow_command): Likewise.
4883         * breakpoint.c (enum exception_event_kind): Delete.
4884         * breakpoint.h (enum exception_event_kind): Moved here from
4885         break-catch-throw.c.
4886         (catch_exception_event): Declare.
4887         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
4888         (mi_cmd_catch_throw): New function.
4889         (mi_cmd_catch_rethrow): New function.
4890         (mi_cmd_catch_catch): New function.
4891         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
4892         'catch-catch' entries.
4893         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
4894         (mi_cmd_catch_rethrow): Declare.
4895         (mi_cmd_catch_catch): Declare.
4896
4897 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4898
4899         * annotate.c (annotate_source_line): Change return type to void,
4900         update implementation to match.
4901         * annotate.h (annotate_source_line): Change return type to void,
4902         update header comment.
4903         * stack.c (print_frame_info): Don't change what frame information
4904         is printed based on whether annotations are on or not.
4905
4906 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4907
4908         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
4909         (annotate_source): Make static.
4910         (annotate_source_line): Moved from source.c and renamed from
4911         identify_source_line.  Update the return type.
4912         * annotate.h (annotate_source): Delete declaration.
4913         (annotate_source_line): Declaration moved from source.h, and
4914         renamed from identify_source_line.  Return type updated.
4915         * source.c (identify_source_line): Moved to annotate.c and renamed
4916         to annotate_source_line.
4917         (info_line_command): Remove check of annotation_level.
4918         * source.h (identify_source_line): Move declaration to annotate.h
4919         and rename to annotate_source_line.
4920         * stack.c: Add 'annotate.h' include.
4921         (print_frame_info): Remove check of annotation_level before
4922         calling annotate_source_line.
4923
4924 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4925
4926         * source-cache.c (source_cache::get_plain_source_lines): Use
4927         open_source_file_with_line_charpos instead of just
4928         open_source_file, remove call to find_source_lines.
4929         (source_cache::get_source_lines): Likewise.
4930         * source.c (find_source_lines): Make static.
4931         (get_filename_and_charpos): Renamed into...
4932         (open_source_file_with_line_charpos): ..this along with changes to
4933         return a scoped_fd, and some other minor clean ups.
4934         (identify_source_line): Use open_source_file_with_line_charpos.
4935         (search_command_helper): Use open_source_file_with_line_charpos
4936         instead of just open_source_file, remove call to
4937         find_source_lines.
4938         * source.h (open_source_file_with_line_charpos): Declare new
4939         function.
4940         (find_source_lines): Delete declaration.
4941
4942 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4943
4944         * source.c (get_filename_and_charpos): Remove fullname
4945         parameter.
4946         (identify_source_line): Update call to get_filename_and_charpos.
4947
4948 2019-06-14  Tom Tromey  <tromey@adacore.com>
4949
4950         PR gdb/24502:
4951         * ui-style.h (skip_ansi_escape): Update comment.
4952         * ui-file.h (class no_terminal_escape_file): New class.
4953         * ui-file.c (no_terminal_escape_file::write)
4954         (no_terminal_escape_file::puts): New methods.
4955         * cli/cli-logging.c (handle_redirections): Use
4956         no_terminal_escape_file.
4957
4958 2019-06-14  Tom Tromey  <tromey@adacore.com>
4959
4960         * NEWS: Move convenience variable news above Python news.
4961
4962 2019-06-14  Tom Tromey  <tom@tromey.com>
4963
4964         * gnulib: Move directory to top-level.
4965         * configure.ac: Don't configure gnulib.
4966         * configure: Rebuild.
4967         * common/common-defs.h: Use new path to gnulib.
4968         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4969         (GNULIB_H): Remove.
4970         (INCGNU): Look in new gnulib location.
4971         (HFILES_NO_SRCDIR): Remove gnulib files.
4972         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4973         (generated_files): Remove GNULIB_H.
4974         ($(LIBGNU), all-lib): Remove targets.
4975         (distclean): Don't mention GNULIB_BUILDDIR.
4976         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4977
4978 2019-06-14  Tom Tromey  <tromey@adacore.com>
4979
4980         * symfile.c (add_symbol_file_command): Remove obsolete comment.
4981         Warn if symbol file does not provide any symbols.
4982
4983 2019-06-14  Tom Tromey  <tromey@adacore.com>
4984
4985         * source.c (find_and_open_source): Respect basenames_may_differ.
4986
4987 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
4988
4989         * annotate.c (annotate_breakpoints_invalid): Make use of
4990         scoped_restore_terminal_state.
4991         (annotate_frames_invalid): Likewise.
4992
4993 2019-06-14  Tom Tromey  <tromey@adacore.com>
4994
4995         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4996         allow assignment to an internalvar.
4997
4998 2019-06-14  Tom Tromey  <tromey@adacore.com>
4999
5000         * ada-lex.l: Allow "_" in attribute names.
5001
5002 2019-06-14  Tom Tromey  <tromey@adacore.com>
5003
5004         PR gdb/24653:
5005         * regcache.c (registers_changed): Don't call alloca.
5006         * top.c (execute_command): Don't call alloca.
5007
5008 2019-06-13  Pedro Alves  <palves@redhat.com>
5009
5010         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
5011         'expression'.  When parsing an expression, error out if there's
5012         junk after "unlimited".
5013         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5014         (do_set_command): Adjust calls to is_unlimited_literal.
5015
5016 2019-06-13  Pedro Alves  <palves@redhat.com>
5017
5018         * compile/compile.c (make_compile_options_def_group): Add braces
5019         around array_view initializer.
5020         * thread.c (make_thread_apply_all_options_def_group)
5021         (make_thread_apply_all_options_def_group): Likewise.
5022
5023 2019-06-13  Pedro Alves  <palves@redhat.com>
5024
5025         * NEWS (New commands): Mention "maint test-options
5026         require-delimiter", "maint test-options unknown-is-error", "maint
5027         test-options unknown-is-operand" and "maint show
5028         test-options-completion-result".
5029         (New command options, command completion): New section.
5030         (Completion improvements): New section.
5031         Mention that you can abbreviate "unlimited".
5032
5033 2019-06-13  Pedro Alves  <palves@redhat.com>
5034
5035         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
5036         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
5037         * unittests/cli-utils-selftests.c (test_parse_flags)
5038         (test_parse_flags_qcs): Delete.
5039         (test_cli_utils): Don't call deleted functions.
5040
5041 2019-06-13  Pedro Alves  <palves@redhat.com>
5042
5043         * thread.c: Include "cli/cli-option.h".
5044         (tp_array_compar_ascending): Global.
5045         (tp_array_compar): Delete function.
5046         (tp_array_compar_ascending, tp_array_compar_descending): New
5047         functions.
5048         (ascending_option_def, qcs_flag_option_def)
5049         (thr_qcs_flags_option_defs)
5050         (make_thread_apply_all_options_def_group)
5051         (make_thread_apply_options_def_group): New.
5052         (thread_apply_all_command): Use gdb::option::process_options.
5053         (thread_apply_command_completer)
5054         (thread_apply_all_command_completer): New.
5055         (thread_apply_command): Use gdb::option::process_options.
5056         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
5057         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
5058         to generate help text of "thread apply".  Adjust "taas"'s help.
5059         * tid-parse.c (tid_range_parser::in_thread_range): New method.
5060         * tid-parse.h (tid_range_parser::in_thread_range): New method.
5061
5062 2019-06-13  Pedro Alves  <palves@redhat.com>
5063
5064         * thread.c (thread_apply_command): Check for invalid TID with
5065         isdigit instead of !isalpha.
5066
5067 2019-06-13  Pedro Alves  <palves@redhat.com>
5068
5069         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
5070         (validate_flags_qcs): New.
5071         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
5072         (validate_flags_qcs): Declare.
5073         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
5074         (make_frame_apply_options_def_group): New.
5075         (frame_apply_command_count): Process options with
5076         gdb::option::process_options.
5077         (frame_apply_completer): New.
5078         (frame_apply_level_completer, frame_apply_all_completer)
5079         (frame_apply_completer): New.
5080         (_initialize_stack): Update help of "frame apply", "frame apply
5081         level", "frame apply all" and "faas" to mention supported options
5082         and install command completers.
5083         * stack.h (frame_apply_all_completer): Declare.
5084         * thread.c: Include "stack.h".
5085         (tfaas_command): Add "--".
5086         (_initialize_thread): Update help "tfaas" to mention supported
5087         options and install command completer.
5088
5089 2019-06-13  Pedro Alves  <palves@redhat.com>
5090
5091         * completer.c (complete_nested_command_line): New.
5092         (gdb_completion_word_break_characters_throw): Add assertion.
5093         * completer.h (complete_nested_command_line): Declare.
5094
5095 2019-06-13  Pedro Alves  <palves@redhat.com>
5096
5097         * stack.c (parse_backtrace_qualifiers): New.
5098         (backtrace_command): Use it.
5099         (backtrace_command_completer): Complete on qualifiers.
5100
5101 2019-06-13  Pedro Alves  <palves@redhat.com>
5102
5103         * frame.c: Include "cli/cli-option.h.
5104         (user_set_backtrace_options): New.
5105         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
5106         Delete.
5107         (get_prev_frame): Adjust.
5108         (boolean_option_def, uinteger_option_def)
5109         (set_backtrace_option_defs): New.
5110         (_initialize_frame): Adjust and use
5111         gdb::option::add_setshow_cmds_for_options to install "set
5112         backtrace past-main" and "set backtrace past-entry".
5113         * frame.h: Include "cli/cli-option.h".
5114         (struct frame_print_options): Forward declare.
5115         (print_frame_arguments_all, print_frame_arguments_scalars)
5116         (print_frame_arguments_none): Declare.
5117         (print_entry_values): Delete declaration.
5118         (struct frame_print_options, user_frame_print_options): New.
5119         (struct set_backtrace_options): New.
5120         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
5121         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
5122         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
5123         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
5124         (list_args_or_locals): Add frame_print_options parameter.
5125         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5126         * python/py-framefilter.c (enumerate_args): Pass down
5127         USER_FRAME_PRINT_OPTIONS.
5128         * stack.c: Include "cli/cli-option.h".
5129         (print_frame_arguments_all, print_frame_arguments_scalars)
5130         (print_frame_arguments_none): Declare.
5131         (print_raw_frame_arguments, print_entry_values): Delete.
5132         (user_frame_print_options): New.
5133         (boolean_option_def, enum_option_def, frame_print_option_defs):
5134         New.
5135         (struct backtrace_cmd_options): New.
5136         (bt_flag_option_def): New.
5137         (backtrace_command_option_defs): New.
5138         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5139         (print_frame_arg, read_frame_arg, print_frame_args)
5140         (print_frame_info, print_frame): Add frame_print_options parameter
5141         and use it.
5142         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
5143         (backtrace_command_1): Add frame_print_options and
5144         backtrace_cmd_options parameters and use them.
5145         (make_backtrace_options_def_group): New.
5146         (backtrace_command): Process command options with
5147         gdb::option::process_options.
5148         (backtrace_command_completer): New.
5149         (_initialize_stack): Extend "backtrace"'s help to mention
5150         supported options.  Install completer for "backtrace".
5151         Install some settings commands with add_setshow_cmds_for_options.
5152
5153 2019-06-13  Pedro Alves  <palves@redhat.com>
5154
5155         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
5156         and that "set/show print raw frame-arguments" are now deprecated.
5157
5158         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
5159         command.
5160         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
5161         * stack.c (_initialize_stack): Install "set/show print
5162         raw-frame-arguments", and deprecate "set/show print raw
5163         frame-arguments".
5164         * valprint.c (_initialize_valprint): Deprecate "set/show print
5165         raw".
5166
5167 2019-06-13  Pedro Alves  <palves@redhat.com>
5168
5169         * compile/compile.c (struct compile_options): New.
5170         (compile_flag_option_def, compile_command_option_defs)
5171         (make_compile_options_def_group): New.
5172         (compile_file_command): Handle options with
5173         gdb::option::process_options.
5174         (compile_file_command_completer): New function.
5175         (compile_code_command): Handle options with
5176         gdb::option::process_options.
5177         (compile_code_command_completer): New function.
5178         (_initialize_compiler): Install completers for "compile code" and
5179         "compile file".  Mention available options in "compile code" and
5180         "compile code"'s help.
5181         * completer.c (advance_to_completion_word): New, factored out from
5182         ...
5183         (advance_to_expression_complete_word_point): ... this.
5184         (advance_to_filename_complete_word_point): New.
5185         * completer.h (advance_to_filename_complete_word_point): New
5186         declaration.
5187
5188 2019-06-13  Pedro Alves  <palves@redhat.com>
5189
5190         * compile/compile.c: Include "cli/cli-option.h".
5191         (compile_print_value): Scope data pointer is now a
5192         value_print_options pointer; adjust.
5193         (compile_print_command): Process options.  Scope data pointer is
5194         now a value_print_options pointer; adjust.
5195         (_initialize_compile): Update "compile print"'s help to include
5196         supported options.  Install a completer for "compile print".
5197         * cp-valprint.c (show_vtblprint, show_objectprint)
5198         (show_static_field_print): Delete.
5199         (_initialize_cp_valprint): Don't install "set print
5200         static-members", "set print vtbl", "set print object" here.
5201         * printcmd.c: Include "cli/cli-option.h" and
5202         "common/gdb_optional.h".
5203         (print_command_parse_format): Rework to fill in a
5204         value_print_options instead of a format_data.
5205         (print_value): Change parameter type from format_data pointer to
5206         value_print_options reference.  Adjust.
5207         (print_command_1): Process options.  Adjust to pass down a
5208         value_print_options.
5209         (print_command_completer): New.
5210         (_initialize_printcmd): Install print_command_completer as
5211         handle_brkchars completer for the "print" command.  Update
5212         "print"'s help to include supported options.
5213         * valprint.c: Include "cli/cli-option.h".
5214         (show_vtblprint, show_objectprint, show_static_field_print): Moved
5215         here from cp-valprint.c.
5216         (boolean_option_def, uinteger_option_def)
5217         (value_print_option_defs, make_value_print_options_def_group):
5218         New.  Use gdb::option::add_setshow_cmds_for_options to install
5219         "set print elements", "set print null-stop", "set print repeats",
5220         "set print pretty", "set print union", "set print array", "set
5221         print address", "set print symbol", "set print array-indexes".
5222         * valprint.h: Include <string> and "cli/cli-option.h".
5223         (make_value_print_options_def_group): Declare.
5224         (print_value): Change parameter type from format_data pointer to
5225         value_print_options reference.
5226         (print_command_completer): Declare.
5227
5228 2019-06-13  Pedro Alves  <palves@redhat.com>
5229
5230         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
5231         (COMMON_SFILES): Add maint-test-settings.c.
5232         * cli/cli-decode.c (boolean_enums): New global, factored out from
5233         ...
5234         (add_setshow_boolean_cmd): ... here.
5235         * cli/cli-decode.h (boolean_enums): Declare.
5236         * cli/cli-option.c: New file.
5237         * cli/cli-option.h: New file.
5238         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
5239         factored out from ...
5240         (parse_cli_boolean_value(const char *)): ... this.
5241         (is_unlimited_literal): Change parameter type to pointer to
5242         pointer.  Adjust and advance ARG pointer.
5243         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5244         (parse_cli_var_enum): New, factored out from ...
5245         (do_set_command): ... this.  Adjust.
5246         * cli/cli-setshow.h (parse_cli_boolean_value)
5247         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5248         (parse_cli_var_enum): Declare.
5249         * cli/cli-utils.c: Include "cli/cli-option.h".
5250         (get_ulongest): New.
5251         * cli/cli-utils.h (get_ulongest): Declare.
5252         (check_for_argument): New overloads.
5253         * maint-test-options.c: New file.
5254
5255 2019-06-13  Pedro Alves  <palves@redhat.com>
5256
5257         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
5258         parse a range if "-" is at the end of the string.
5259
5260 2019-06-13  Pedro Alves  <palves@redhat.com>
5261
5262         * cli/cli-setshow.c (parse_auto_binary_operation)
5263         (parse_cli_boolean_value): Don't allow "o".
5264
5265 2019-06-13  Pedro Alves  <palves@redhat.com>
5266
5267         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
5268         * NEWS: Mention maint test-settings KIND.
5269         * maint-test-settings.c: New file.
5270
5271 2019-06-13  Pedro Alves  <palves@redhat.com>
5272
5273         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
5274         completer.
5275         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
5276         "set" completers.
5277
5278 2019-06-13  Pedro Alves  <palves@redhat.com>
5279
5280         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
5281         after item.
5282
5283 2019-06-13  Pedro Alves  <palves@redhat.com>
5284
5285         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
5286
5287 2019-06-13  Pedro Alves <palves@redhat.com>
5288
5289         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
5290         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
5291         call.
5292         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
5293         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
5294         calls.
5295         (check_for_argument): Skip spaces after argument.
5296
5297 2019-06-13  Pedro Alves  <palves@redhat.com>
5298
5299         * thread.c (thread_apply_command): Adjust TID parsing.
5300         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
5301         detected before end of string.
5302         (tid_is_in_list): Error out if LIST is invalid.
5303
5304 2019-06-13  Pedro Alves  <palves@redhat.com>
5305
5306         * completer.c (complete_line_internal_1): Rewind completion word
5307         point.
5308         (completion_tracker::advance_custom_word_point_by): Change
5309         parameter type to int.
5310         * completer.h (completion_tracker::advance_custom_word_point_by):
5311         Likewise.
5312
5313 2019-06-13  Pedro Alves  <palves@redhat.com>
5314
5315         * completer.c (advance_to_completion_word): Handle delimiters.
5316
5317 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
5318
5319         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
5320
5321 2019-06-11  Tom Tromey  <tom@tromey.com>
5322
5323         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
5324         (xmalloc_failed): Move to alloc.c.
5325         * alloc.c: New file.
5326         * Makefile.in (COMMON_SFILES): Add alloc.c.
5327
5328 2019-06-11  Tom Tromey  <tom@tromey.com>
5329
5330         * nat/linux-waitpid.c: Don't include server.h.
5331         (linux_debug): Remove.
5332         (my_waitpid): Update.
5333
5334 2019-06-11  Tom Tromey  <tromey@adacore.com>
5335
5336         * infcall.c (_initialize_infcall): Remove trailing newline from
5337         help.
5338         * user-regs.c (_initialize_user_regs): Remove trailing newline
5339         from help.
5340         * typeprint.c (_initialize_typeprint): Remove trailing newline
5341         from help.
5342         * reverse.c (_initialize_reverse): Remove trailing newlines from
5343         help.
5344         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
5345         from help.
5346         * language.c (add_set_language_command): Remove trailing newline
5347         from help.
5348         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
5349         help.
5350         * disasm.c (_initialize_disasm): Remove trailing newline from
5351         help.
5352         * top.c (init_main): Remove trailing newline from help.
5353         * interps.c (_initialize_interpreter): Remove trailing newline
5354         from help.
5355         * btrace.c (_initialize_btrace): Remove trailing newlines from
5356         help.
5357         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
5358         from help.
5359         * python/python.c (_initialize_python): Remove trailing newline
5360         from help.
5361         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
5362         help.
5363         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
5364         from help.  Reformat some text.
5365         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
5366         from help.
5367         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
5368         newline from help.
5369
5370 2019-06-11  Tom Tromey  <tromey@adacore.com>
5371
5372         * darwin-nat.c (darwin_decode_exception_message)
5373         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
5374
5375 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5376
5377         * valops.c (value_slice): Check for not allocated or not
5378         associated values.
5379
5380 2019-06-10  Tom de Vries  <tdevries@suse.de>
5381
5382         PR gdb/24618
5383         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
5384         sure an empty slot (defined by a 32-bit zero pair) is recognized as
5385         invalid.
5386
5387 2019-06-10  Tom de Vries  <tdevries@suse.de>
5388
5389         PR gdb/24611
5390         * linespec.c (linespec_lexer_lex_string): Remove incorrect
5391         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
5392
5393 2019-06-10  Tom de Vries  <tdevries@suse.de>
5394
5395         PR symtab/24545
5396         * symtab.c (struct demangled_name_entry): Add language field.
5397         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
5398         static minimal symbol".  Set and use language field.
5399
5400 2019-06-10  Tom Tromey  <tromey@adacore.com>
5401
5402         * ada-lang.c (_initialize_ada_language): Update help text.
5403
5404 2019-06-10  Tom Tromey  <tromey@adacore.com>
5405
5406         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
5407         with a newline.
5408         * guile/guile.c (handle_boot_error): Don't end warning with a
5409         newline.
5410         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
5411         warning with a newline.
5412         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
5413         newline.
5414         (s12z_frame_cache): Likewise.
5415         * dwarf-index-cache.c (index_cache::store): Don't end warning with
5416         a newline.
5417         * solib-svr4.c (disable_probes_interface): Don't end warning with
5418         a newline.
5419         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
5420         newline.
5421         * python/python.c (do_finish_initialization): Don't end warning
5422         with a newline.
5423
5424 2019-06-10  Tom Tromey  <tom@tromey.com>
5425
5426         * python/py-breakpoint.c (gdbpy_breakpoint_created)
5427         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
5428         gdbpy_enter.
5429
5430 2019-06-10  Tom Tromey  <tromey@adacore.com>
5431
5432         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
5433         data.
5434         (elf_new_init): Don't call stabsread_new_init.
5435         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
5436         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
5437         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
5438
5439 2019-06-10  Tom de Vries  <tdevries@suse.de>
5440
5441         PR symtab/16264
5442         PR symtab/24517
5443         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
5444
5445 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
5446
5447         * source.c (find_and_open_source): Also rewrite relative file
5448         names.
5449
5450 2019-04-26  Amos Bird  <amosbird@gmail.com>
5451
5452         * annotate.c (annotate_thread_exited): Add "thread-exited"
5453         annotation.
5454
5455 2019-06-06  Tom Tromey  <tromey@adacore.com>
5456
5457         * maint.h (class scoped_command_stats): Use
5458         DISABLE_COPY_AND_ASSIGN.
5459         <print_time>: New method.
5460         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
5461         print_time.
5462         (scoped_command_stats::print_time): New method.
5463
5464 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
5465
5466         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
5467         instructions of lengths 6 or 8 bytes.
5468
5469 2019-06-04  Pedro Alves  <palves@redhat.com>
5470
5471         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
5472
5473         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
5474         * breakpoint.c (condition_completer): Likewise.
5475         * cli/cli-dump.c (scan_expression): Likewise.
5476         * common/filestuff.c (mkdir_recursive): Likewise.
5477         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
5478         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
5479         (gdb_abspath): Likewise.
5480         * compile/compile-cplus-types.c
5481         (compile_cplus_instance::decl_name): Likewise.
5482         * completer.c (complete_explicit_location):
5483         (signal_completer, reg_or_group_completer_1): Likewise.
5484         * cp-support.c (cp_remove_params_if_any): Likewise.
5485         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
5486         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
5487         * infcmd.c (strip_bg_char): Likewise.
5488         * linespec.c (copy_token_string): Likewise.
5489         * mi/mi-main.c (output_cores): Likewise.
5490         * psymtab.c (psymtab_search_name):
5491         * symfile.c (test_set_ext_lang_command): Likewise.
5492         * target.c (target_fileio_read_stralloc): Likewise.
5493         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
5494         * value.c (complete_internalvar): Likewise.
5495
5496 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
5497
5498         Add objfile property to gdb.Type.
5499         * NEWS: Mention Python API addition.
5500         * python/py-type.c (typy_get_objfile): New method.
5501
5502 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5503
5504         * NEWS: Mention the new set|show style [title|highlight].
5505         Mention changes to "show style", "help" and "apropos".
5506
5507 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5508
5509         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
5510         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
5511         instead of print_help_for_command.
5512         (print_doc_of_command): New function.
5513         (help_list): Add 'apropos -v word' suggestion.
5514         (print_help_for_command): Style the command name using title style.
5515         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
5516         (_initialize_cli_cmds): Describe -v in apropos_command help.
5517
5518 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5519
5520         * cli/cli-style.h (cli_style_option): Add name in constructor,
5521         add m_name class member, add constructor with intensity,
5522         add name class function.
5523         (cli_style_option::add_setshow_commands): Remove name argument.
5524         (highlight_style, title_style): New styles.
5525         * cli/cli-style.c (do_show): New function that shows a style
5526         characteristic styling the style name with itself.
5527         (set_style_name): New function.
5528         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
5529         Update all callers according to the changes in cli/cli-style.h.
5530         * utils.h (fputs_highlighted): New function.
5531         * utils.c (fputs_highlighted): Likewise.
5532
5533 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5534
5535         * NEWS: Mention new pipe command and new convenience variables.
5536
5537 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5538
5539         * cli/cli-cmds.c (pipe_command): New function.
5540         (_initialize_cli_cmds): Call add_com for pipe_command.
5541         Define | as an alias for pipe.
5542         (exit_status_set_internal_vars): New function.
5543         (shell_escape): Call exit_status_set_internal_vars.
5544         cli/cli-decode.c (find_command_name_length): Recognize | as
5545         a single character command.
5546
5547 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5548
5549         * gdbcmd.h (execute_command_to_ui_file): New declaration.
5550         top.c (execute_command_to_ui_file): New function, mostly a copy
5551         of execute_command_to_string.
5552         (execute_command_to_string): Implement by calling
5553         execute_command_to_ui_file.
5554
5555 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5556
5557         * top.h (saved_command_line): Remove declaration.
5558         * top.c (previous_saved_command_line, previous_repeat_arguments):
5559         New variables.
5560         (saved_command_line): Make static, define together with other
5561         'repeat variables'.
5562         (dont_repeat): Clear repeat_arguments.
5563         (repeat_previous, get_saved_command_line, save_command_line):
5564         New functions.
5565         (gdb_init): Initialize saved_command_line
5566         and previous_saved_command_line.
5567         * main.c (captured_main_1): Remove saved_command_line initialization.
5568         * event-top.c (handle_line_of_input): Update to use
5569         the new 'repeat' related functions instead of direct access to
5570         saved_command_line.
5571         * command.h (repeat_previous, get_saved_command_line,
5572         save_command_line): New declarations.
5573         (dont_repeat): Add comment.
5574
5575 2019-05-30  Tom Tromey  <tromey@adacore.com>
5576
5577         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
5578         Fix comment.
5579         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
5580
5581 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
5582
5583         PR cli/24587
5584         * completer.c (complete): Initialize variable word.
5585
5586 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
5587
5588         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5589         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
5590         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
5591         'body' is NULL to the outter 'if', protecting the '!is_define'
5592         situation as well.
5593
5594 2019-05-29  Tom Tromey  <tromey@adacore.com>
5595
5596         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
5597         (dwarf_unknown): New function.
5598         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
5599         (dwarf_type_encoding_name): Use dwarf_unknown.
5600
5601 2019-05-29  Tom Tromey  <tromey@adacore.com>
5602
5603         PR c++/20020:
5604         * cp-valprint.c (cp_print_value_fields): Call
5605         cp_print_static_field inside "try".
5606
5607 2019-05-29  Tom Tromey  <tromey@adacore.com>
5608
5609         * inflow.c (struct terminal_info): Add default operator=.
5610         * configure: Rebuild.
5611         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
5612         -Wdeprecated-copy-dtor, -Wredundant-move.
5613
5614 2019-05-29  Tom Tromey  <tromey@adacore.com>
5615
5616         * NEWS: Add entry.
5617         * infcmd.c (print_return_value_1): Handle finish_print
5618         option.
5619         (show_print_finish): New function.
5620         (_initialize_infcmd): Add "set/show print finish" commands.
5621         * valprint.c (user_print_options): Initialize new member.
5622         * valprint.h (struct value_print_options) <finish_print>: New
5623         member.
5624
5625 2019-05-28  Tom Tromey  <tromey@adacore.com>
5626
5627         * ada-lang.c (ada_remove_Xbn_suffix)
5628         (find_old_style_renaming_symbol)
5629         (parse_old_style_renaming): Remove.
5630         (ada_find_renaming_symbol): Don't call
5631         find_old_style_renaming_symbol.
5632         (ada_is_renaming_symbol): Rename from
5633         ada_find_renaming_symbol.  Remove "block" parameter.  Return
5634         bool.  Now static.
5635         (ada_read_var_value): Update and simplify.
5636         * ada-exp.y (write_var_or_type): Remove old code.
5637
5638 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
5639
5640         * event-top.c: Remove include comment.
5641         * inflow.c (class scoped_ignore_sigttou): Move from here...
5642         * inflow.h (class scoped_ignore_sigttou): ...to here.
5643         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
5644         * top.c:  Remove include comment.
5645
5646 2019-05-27  Tom Tromey  <tom@tromey.com>
5647
5648         * NEWS: Fix typo.
5649
5650 2019-05-22  Tom Tromey  <tromey@adacore.com>
5651
5652         * target.c (target_follow_exec): Constify parameter.
5653         * target-delegates.c: Rebuild.
5654         * remote.c (remote_target::follow_exec): Constify parameter.
5655         * infrun.c (follow_exec): Constify parameter.
5656         * target.h (struct target_ops) <follow_exec>: Constify parameter.
5657         (target_follow_exec): Likewise.
5658
5659 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5660
5661         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
5662         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
5663
5664 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5665
5666         * NEWS: Add debugredirect and testsuite sections.
5667
5668 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
5669
5670         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
5671         target descriptions using exclusively floating point register name
5672         aliases.
5673
5674 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
5675
5676         PR gdb/18644:
5677         * f-lang.c (build_fortran_types): Handle the case where
5678         gdbarch_floatformat_for_type returns a nullptr.
5679
5680 2019-05-21  Tom de Vries  <tdevries@suse.de>
5681
5682         PR cli/24587
5683         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
5684
5685 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5686
5687         PR gdb/18644:
5688         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
5689         16-byte floats.
5690         * i386-tdep.c (i386_floatformat_for_type): Use
5691         floatformats_ia64_quad for the 16-byte floating point component
5692         within a fortran 32-byte complex number.
5693
5694 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5695
5696         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
5697         delete default constructor.
5698         (find_partial_die): Update to return const struct.
5699         (partial_die_parent_scope): Move variable declaration into scope
5700         of its use and change its type to auto.
5701         (guess_partial_die_structure_name): Likewise.
5702         (partial_die_info::fixup): Likewise.
5703
5704 2019-05-17  Tom Tromey  <tromey@adacore.com>
5705
5706         * source.c (find_and_open_source): Remove cast.
5707
5708 2019-05-17  Tom Tromey  <tromey@adacore.com>
5709
5710         * annotate.c (annotate_source): Make "filename" const.
5711         * annotate.h (annotate_source): Use const.
5712
5713 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5714
5715         * disasm.c (set_disassembler_options): Send errors to stderr.
5716
5717 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5718
5719         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
5720         (cli_interp_base::set_logging): Check debug_redirect.
5721         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
5722         * cli/cli-logging.c (debug_redirect): Add static variable.
5723         (pop_output_files): Add default param.
5724         (handle_redirections): Print debug setting.
5725         (show_logging_command): Likewise.
5726         (_initialize_cli_logging): Add debugredirect command.
5727         * interps.c (current_interp_set_logging): Add debug_redirect
5728         parameter.
5729         * interps.h (set_logging): Add debug_redirect parameter.
5730         (current_interp_set_logging): Likewise.
5731         * mi/mi-common.h: Likewise.
5732         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
5733
5734 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5735             Tom Tromey  <tromey@adacore.com>
5736
5737         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
5738         directly.
5739         * cli/cli-interp.h (make_logging_output): Remove declaration.
5740         * cli/cli-logging.c (make_logging_output): Remove function.
5741         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
5742         directly.
5743         * ui-file.c (tee_file::tee_file): Remove bools.
5744         (tee_file::~tee_file): Remove deletes.
5745         * ui-file.h (tee_file): Remove bools.
5746
5747 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
5748
5749         * mi/mi-cmds.h (mi_cmd_complete): New function.
5750         * mi/mi-main.c (mi_cmd_complete): Likewise.
5751         * mi/mi-cmds.c: Define new MI command -complete.
5752         * NEWS: Mention new -complete command.
5753
5754 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
5755
5756         * completer.h (complete): New function.
5757         * completer.c (complete): Likewise.
5758         * cli/cli-cmds.c: (complete_command): Update to use new complete()
5759         function defined in completer.h.
5760
5761 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
5762
5763         * MAINTAINERS (Write After Approval): Add myself.
5764
5765 2019-05-17  Tom de Vries  <tdevries@suse.de>
5766
5767         PR gdb/24094
5768         * dwarf2read.c (struct cu_partial_die_info): New struct.
5769         (find_partial_die): Return cu_partial_die_info.
5770         (partial_die_parent_scope, guess_partial_die_structure_name)
5771         (partial_die_info::fixup): Handle new return type of find_partial_die.
5772
5773 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5774
5775         * stap-probe.c (stap_parse_register_operand): Make "regname" an
5776         "std::string", simplifying the algorithm.
5777
5778 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5779
5780         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
5781         (stap_static_probe_ops::get_probes): Likewise.
5782
5783 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5784
5785         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
5786         '-')" and "else if".
5787         (stap_parse_single_operand): Join checks for
5788         "gdbarch_stap_parse_special_token_p" and
5789         "gdbarch_stap_parse_special_token" in the same "if" statement.
5790         Invert check when verifying for operation on register
5791         displacement.
5792
5793 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5794
5795         * stap-probe.c (stap_get_opcode): Update comment.
5796         (stap_get_expected_argument_type): Likewise.
5797         (handle_stap_probe): Likewise.
5798
5799 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5800
5801         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
5802         return type to 'bool'.  Adjust comment.  Use 'bool' when
5803         appropriate.
5804         (i386_stap_parse_special_token_three_arg_disp): Likewise.
5805         * stap-probe.c (stap_parse_argument_1): Likewise.
5806         (stap_is_operator): Likewise.
5807         (stap_is_generic_prefix): Likewise.
5808         (stap_is_register_prefix): Likewise.
5809         (stap_is_register_indirection_prefix): Likewise.
5810         (stap_is_integer_prefix): Likewise.
5811         (stap_generic_check_suffix): Likewise.
5812         (stap_check_integer_suffix): Likewise.
5813         (stap_check_register_suffix): Likewise.
5814         (stap_check_register_indirection_suffix): Likewise.
5815         (stap_parse_register_operand): Likewise.
5816         (stap_parse_single_operand): Likewise.
5817         (stap_parse_argument_1): Likewise.
5818         (stap_probe::get_argument_count): Likewise.
5819         (stap_is_operator): Likewise.
5820
5821 2019-05-16  Tom Tromey  <tromey@adacore.com>
5822
5823         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
5824         keyword to foreach.
5825
5826 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
5827
5828         * linux-thread-db.c (try_thread_db_load_1): Change return type
5829         to bool.
5830         (try_thread_db_load): Likewise.
5831         (try_thread_db_load_from_pdir_1): Likewise.
5832         (try_thread_db_load_from_pdir): Likewise.
5833         (try_thread_db_load_from_sdir): Likewise.
5834         (try_thread_db_load_from_dir): Likewise.
5835         (thread_db_load_search): Likewise.
5836         (has_libpthread): Likewise.
5837         (thread_db_load): Likewise.
5838
5839 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
5840
5841         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5842         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
5843         NULL, and complain/return if that's the case.
5844
5845 2019-05-15  John Darrington <john@darrington.wattle.id.au>
5846
5847         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
5848         (advance, posn, abstract_read_memory): New functions.
5849         [struct mem_read_abstraction]: New struct.
5850         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
5851
5852 2019-05-14  Tom Tromey  <tromey@adacore.com>
5853
5854         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
5855         value is not lval_memory.
5856
5857 2019-05-14  Tom Tromey  <tromey@adacore.com>
5858
5859         * solib.c (info_sharedlibrary_command): Style the file name.
5860
5861 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
5862
5863         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
5864         (aarch64_vnv_type): Likewise.
5865         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
5866         * common/tdesc.c: Likewise.
5867         * common/tdesc.h (enum tdesc_type_kind): Likewise.
5868         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
5869         * features/aarch64-fpu.xml: Add ieee half view.
5870         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
5871         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
5872         * gdbtypes.h (struct builtin_type): Likewise.
5873         (struct objfile_type): Likewise.
5874
5875 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
5876
5877         * language.c (language_sniff_from_mangled_name): Fix "langauge"
5878         typo.
5879         * location.h (string_to_event_location): Likewise.
5880
5881 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
5882
5883         GDB 8.3 released.
5884
5885 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5886
5887         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
5888         New variable declaration.
5889         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
5890         New variable.
5891         (print_one_breakpoint): Use ui_out::test_flags and new global
5892         variable to compute use_fixed_output.
5893         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
5894         Remove.
5895         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
5896         (mi_multi_location_breakpoint_output_fixed): Remove.
5897         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
5898         new variable.
5899         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
5900         fix_multi_location_breakpoint_output flag if version >= 3.
5901         * ui-out.h (enum ui_out_flag)
5902         <fix_multi_location_breakpoint_output>: New enumerator.
5903
5904 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5905
5906         * contrib/cc-with-tweaks.sh: Validate dwz's work.
5907
5908 2019-05-10  Tom Tromey  <tromey@adacore.com>
5909
5910         * ada-lang.c (catch_ada_completer): New function.
5911         (_initialize_ada_language): Use it.
5912
5913 2019-05-10  Tom Tromey  <tromey@adacore.com>
5914
5915         * thread.c (print_thread_info): Make "requested_threads" const.
5916         * gdbthread.h (print_thread_info): Make "requested_threads"
5917         const.
5918         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5919         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
5920
5921 2019-05-08  Tom Tromey  <tom@tromey.com>
5922
5923         * gdbtypes.c (objfile_type_data): Change type.
5924         (objfile_type, _initialize_gdbtypes): Update.
5925
5926 2019-05-08  Tom Tromey  <tom@tromey.com>
5927
5928         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
5929         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
5930         (_initialize_dwarf2_frame): Update.
5931
5932 2019-05-08  Tom Tromey  <tom@tromey.com>
5933
5934         * objc-lang.c (objc_objfile_data): Change type.
5935         (find_methods): Update.
5936         (_initialize_objc_lang): Remove.
5937
5938 2019-05-08  Tom Tromey  <tom@tromey.com>
5939
5940         * stabsread.c (rs6000_builtin_type_data): Change type.
5941         (rs6000_builtin_type, _initialize_stabsread): Update.
5942
5943 2019-05-08  Tom Tromey  <tom@tromey.com>
5944
5945         * mips-tdep.c (mips_pdr_data): Remove.
5946         (_initialize_mips_tdep): Update.
5947
5948 2019-05-08  Tom Tromey  <tom@tromey.com>
5949
5950         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5951         (hppa_init_objfile_priv_data, read_unwind_info)
5952         (find_unwind_entry, _initialize_hppa_tdep): Update.
5953
5954 2019-05-08  Tom Tromey  <tom@tromey.com>
5955
5956         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5957         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
5958         on obstack.
5959         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5960
5961 2019-05-08  Tom Tromey  <tom@tromey.com>
5962
5963         * mdebugread.c (basic_type_data): Change type.
5964         (basic_type, _initialize_mdebugread): Update.
5965
5966 2019-05-08  Tom Tromey  <tom@tromey.com>
5967
5968         * common/gdb_unique_ptr.h (struct noop_deleter): New.
5969
5970 2019-05-08  Tom Tromey  <tom@tromey.com>
5971
5972         * nto-tdep.c (nto_inferior_data_reg): Change type.
5973         (nto_inferior_data): Update.
5974         (nto_inferior_data_cleanup, nto_new_inferior_data)
5975         (_initialize_nto_tdep): Remove.
5976         * nto-tdep.h (struct nto_inferior_data): Add initializers.
5977
5978 2019-05-08  Tom Tromey  <tom@tromey.com>
5979
5980         * ada-lang.c (struct ada_inferior_data): Add initializers.
5981         (ada_inferior_data): Change type.
5982         (ada_inferior_data_cleanup): Remove.
5983         (get_ada_inferior_data, ada_inferior_exit)
5984         (struct ada_pspace_data): Add initializers, destructor.
5985         (ada_pspace_data_handle): Change type.
5986         (get_ada_pspace_data): Update.
5987         (ada_pspace_data_cleanup): Remove.
5988
5989 2019-05-08  Tom Tromey  <tom@tromey.com>
5990
5991         * coffread.c (struct coff_symfile_info): Add initializers.
5992         (coff_objfile_data_key): Move lower.  Change type.
5993         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5994         Update.
5995         (coff_free_info): Remove.
5996
5997 2019-05-08  Tom Tromey  <tom@tromey.com>
5998
5999         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
6000         (fbsd_pspace_data_handle): Move lower.  Change type.
6001         (get_fbsd_pspace_data): Update.
6002         (fbsd_pspace_data_cleanup): Remove.
6003         (_initialize_fbsd_tdep): Update.
6004
6005 2019-05-08  Tom Tromey  <tom@tromey.com>
6006
6007         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
6008         (get_ada_tasks_pspace_data): Update.
6009         (ada_tasks_pspace_data_cleanup): Remove.
6010         (_initialize_tasks): Update.
6011         (ada_tasks_inferior_data_handle): Change type.
6012         (get_ada_tasks_inferior_data): Update.
6013         (ada_tasks_inferior_data_cleanup): Remove.
6014         (struct ada_tasks_pspace_data): Add initializers.
6015
6016 2019-05-08  Tom Tromey  <tom@tromey.com>
6017
6018         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
6019         * symfile-debug.c (debug_sym_get_probes): Change type.
6020         * stap-probe.c (handle_stap_probe):
6021         (stap_static_probe_ops::get_probes): Change type.
6022         * probe.h (class static_probe_ops) <get_probes>: Change type.
6023         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
6024         (parse_probes_in_pspace): Update.
6025         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
6026         Update.
6027         (any_static_probe_ops::get_probes): Change type.
6028         * elfread.c (elfread_data): New typedef.
6029         (probe_key): Change type.
6030         (elf_get_probes): Likewise.  Update.
6031         (probe_key_free): Remove.
6032         (_initialize_elfread): Update.
6033         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
6034         Change type.
6035         (dtrace_process_dof_probe, dtrace_process_dof)
6036         (dtrace_static_probe_ops::get_probe): Change type.
6037
6038 2019-05-08  Tom Tromey  <tom@tromey.com>
6039
6040         * xcoffread.c (struct xcoff_symfile_info): Rename from
6041         coff_symfile_info.  Add initializers.
6042         (xcoff_objfile_data_key): Move lower.  Change type.
6043         (XCOFF_DATA): Rewrite.
6044         (xcoff_free_info): Remove.
6045         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
6046         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
6047         (xcoff_initial_scan): Update.
6048
6049 2019-05-08  Tom Tromey  <tom@tromey.com>
6050
6051         * solib-svr4.c (struct svr4_info): Add initializers and
6052         destructor.
6053         <probes_table>: Now an htab_up.
6054         (solib_svr4_pspace_data): Change type.
6055         (free_probes_table): Simplify.
6056         (~svr4_info): Rename from svr4_pspace_data_cleanup.
6057         (get_svr4_info, probes_table_htab_remove_objfile_probes)
6058         (probes_table_remove_objfile_probes, register_solib_event_probe)
6059         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
6060         (_initialize_svr4_solib): Update.
6061
6062 2019-05-08  Tom Tromey  <tom@tromey.com>
6063
6064         * remote.c (remote_pspace_data): Change type.
6065         (remote_pspace_data_cleanup): Remove.
6066         (get_remote_exec_file, set_pspace_remote_exec_file)
6067         (_initialize_remote): Update.
6068
6069 2019-05-08  Tom Tromey  <tom@tromey.com>
6070
6071         * breakpoint.c (breakpoint_objfile_key): Change type.
6072         (get_breakpoint_objfile_data): Update.
6073         (free_breakpoint_objfile_data): Remove.
6074         (_initialize_breakpoint): Update.
6075
6076 2019-05-08  Tom Tromey  <tom@tromey.com>
6077
6078         * linux-tdep.c (struct linux_info): Add initializers.
6079         (linux_inferior_data): Move.  Change type.
6080         (invalidate_linux_cache_inf): Update.
6081         (linux_inferior_data_cleanup): Remove.
6082         (get_linux_inferior_data, _initialize_linux_tdep): Update.
6083
6084 2019-05-08  Tom Tromey  <tom@tromey.com>
6085
6086         * auxv.c (auxv_inferior_data): Move.  Change type.
6087         (auxv_inferior_data_cleanup): Remove.
6088         (invalidate_auxv_cache_inf): Rewrite.
6089         (get_auxv_inferior_data, _initialize_auxv): Update.
6090
6091 2019-05-08  Tom Tromey  <tom@tromey.com>
6092
6093         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
6094         (symfile_debug_objfile_data_key): Change type.
6095         (symfile_debug_installed, debug_qf_has_symbols)
6096         (debug_qf_find_last_source_symtab)
6097         (debug_qf_forget_cached_source_info)
6098         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
6099         (debug_qf_print_stats, debug_qf_dump)
6100         (debug_qf_expand_symtabs_for_function)
6101         (debug_qf_expand_all_symtabs)
6102         (debug_qf_expand_symtabs_with_fullname)
6103         (debug_qf_map_matching_symbols)
6104         (debug_qf_expand_symtabs_matching)
6105         (debug_qf_find_pc_sect_compunit_symtab)
6106         (debug_qf_map_symbol_filenames)
6107         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
6108         (debug_sym_new_init, debug_sym_init, debug_sym_read)
6109         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
6110         (debug_sym_read_linetable, debug_sym_relocate): Update.
6111         (symfile_debug_free_objfile): Remove.
6112         (install_symfile_debug_logging, _initialize_symfile_debug):
6113         Update.
6114
6115 2019-05-08  Tom Tromey  <tom@tromey.com>
6116
6117         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
6118         allocate_on_obstack.
6119         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
6120         (get_dwarf2_per_objfile): Update.
6121         (set_dwarf2_per_objfile): Remove.
6122         (dwarf2_has_info, dwarf2_get_section_info): Update.
6123         (dwarf2_free_objfile): Remove.
6124         (_initialize_dwarf2_read): Update.
6125
6126 2019-05-08  Tom Tromey  <tom@tromey.com>
6127
6128         * auto-load.c (struct auto_load_pspace_info): Add destructor and
6129         initializers.
6130         <unsupported_script_warning_printed,
6131         script_not_found_warning_printed>: Now bool.
6132         (auto_load_pspace_data): Change type.
6133         (~auto_load_pspace_info): Rename from
6134         auto_load_pspace_data_cleanup.
6135         (get_auto_load_pspace_data, init_loaded_scripts_info)
6136         (clear_section_scripts, maybe_print_unsupported_script_warning)
6137         (maybe_print_script_not_found_warning, _initialize_auto_load):
6138         Update.
6139
6140 2019-05-08  Tom Tromey  <tom@tromey.com>
6141
6142         * objfiles.c (objfile_pspace_info): Add destructor and
6143         initializers.
6144         (objfiles_pspace_data): Change type.
6145         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
6146         (get_objfile_pspace_data): Update.
6147         (objfiles_bfd_data): Change type.
6148         (get_objfile_bfd_data): Update.
6149         (objfile_bfd_data_free, _initialize_objfiles): Remove.
6150
6151 2019-05-08  Tom Tromey  <tom@tromey.com>
6152
6153         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
6154         Change type.
6155         (get_catch_syscall_inferior_data): Update.
6156         (catch_syscall_inferior_data_cleanup): Remove.
6157         (_initialize_break_catch_syscall): Update.
6158
6159 2019-05-08  Tom Tromey  <tom@tromey.com>
6160
6161         * inflow.c (struct terminal_info): Add destructor and
6162         initializers.
6163         (inflow_inferior_data): Change type.
6164         (~terminal_info): Rename from inflow_inferior_data_cleanup.
6165         (get_inflow_inferior_data, inflow_inferior_exit)
6166         (swap_terminal_info, _initialize_inflow): Update.
6167
6168 2019-05-08  Tom Tromey  <tom@tromey.com>
6169
6170         * target-dcache.c (target_dcache_cleanup): Remove.
6171         (target_dcache_aspace_key): Change type.
6172         (target_dcache_init_p, target_dcache_invalidate)
6173         (target_dcache_get, target_dcache_get_or_init)
6174         (_initialize_target_dcache): Update.
6175         * dcache.h (struct dcache_deleter): New.
6176
6177 2019-05-08  Tom Tromey  <tom@tromey.com>
6178
6179         * symtab.c (struct symbol_cache): Add destructor and
6180         initializers.
6181         (symbol_cache_key): Move.  Change type.
6182         (make_symbol_cache, free_symbol_cache): Remove.
6183         (get_symbol_cache): Update.
6184         (symbol_cache_cleanup): Remove.
6185         (ALL_PSPACES, symbol_cache_flush)
6186         (maintenance_print_symbol_cache)
6187         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
6188         Update.
6189
6190 2019-05-08  Tom Tromey  <tom@tromey.com>
6191
6192         * symtab.c (struct main_info): Add destructor and initializers.
6193         (main_progspace_key): Move.  Change type.
6194         (get_main_info): Update.
6195         (main_info_cleanup): Remove.
6196         (_initialize_symtab): Update.
6197
6198 2019-05-08  Tom Tromey  <tom@tromey.com>
6199
6200         * registry.h (DECLARE_REGISTRY): Define the _key class.
6201
6202 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6203
6204         * NEWS: Merge two 'New commands' sections.
6205
6206 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
6207
6208         * ada-valprint.c (ada_val_print_gnat_array): Remove language
6209         parameter and use Ada language definition instead.
6210         (ada_val_print_ptr): Remove unused language parameter.
6211         (ada_val_print_num): Remove language parameter and use Ada language
6212         definition instead.
6213         (ada_val_print_enum, ada_val_print_flt): Remove unused language
6214         parameter.
6215         (ada_val_print_struct_union, ada_val_print_ref): Remove language
6216         parameter and use Ada language definition instead.
6217         (ada_val_print_1): Update all ada_val_print_xxx calls.
6218         Remove language parameter.
6219         (ada_val_print): Update ada_val_print_1 call.
6220
6221 2019-05-08  Tom Tromey  <tromey@adacore.com>
6222
6223         * remote.c (remote_hw_watchpoint_limit)
6224         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
6225         Now static.
6226
6227 2019-05-08  Tom Tromey  <tromey@adacore.com>
6228
6229         * maint.c (_initialize_maint_cmds): Move initialization code to
6230         remote.c.
6231         (watchdog, show_watchdog): Move to remote.c.
6232         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
6233         "watchdog" static.
6234         (_initialize_remote): Move initialization code from maint.c.
6235         * defs.h (watchdog): Don't declare.
6236
6237 2019-05-08  Tom Tromey  <tromey@adacore.com>
6238
6239         * tui/tui-interp.c: Include main.h.
6240         * interps.c: Include main.h.
6241         * main.h (interpreter_p): Declare.
6242         * defs.h (interpreter_p): Don't declare.
6243
6244 2019-05-08  Tom Tromey  <tromey@adacore.com>
6245
6246         * dwarf2loc.c: Include dwarf2read.h.
6247         * defs.h (read_unsigned_leb128): Don't declare.
6248         * dwarf2read.h (read_unsigned_leb128): Declare.
6249
6250 2019-05-08  Tom Tromey  <tromey@adacore.com>
6251
6252         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
6253         method.
6254
6255 2019-05-08  Tom Tromey  <tromey@adacore.com>
6256
6257         * utils.c (fputs_maybe_filtered): Reset style after paging, even
6258         when no wrap column is set.
6259
6260 2019-05-08  Tom Tromey  <tromey@adacore.com>
6261
6262         * c-lang.c (c_get_string): Handle non-C-style arrays.
6263
6264 2019-05-08  Tom Tromey  <tromey@adacore.com>
6265
6266         * typeprint.c (print_offset_data::update): Print the bit offset,
6267         not the number of bits remaining.
6268
6269 2019-05-08  Tom Tromey  <tromey@adacore.com>
6270
6271         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
6272         padding at end of comment.
6273
6274 2019-05-08  Tom Tromey  <tromey@adacore.com>
6275
6276         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
6277         Compare main types.
6278
6279 2019-05-06  Tom Tromey  <tom@tromey.com>
6280
6281         * common/scoped_mmap.c: Include common-defs.h.
6282         * common/scoped_mmap.h: Don't include config.h.
6283
6284 2019-05-04  Tom Tromey  <tom@tromey.com>
6285
6286         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
6287         (struct aarch64_call_info): Add initializers.
6288         <si>: Now a std::vector.
6289         (pass_on_stack, aarch64_push_dummy_call): Update.
6290
6291 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
6292             Tom Tromey  <tom@tromey.com>
6293
6294         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
6295         (ppc_threads): Now a std::vector.  Now static.
6296         (hwdebug_find_thread_points_by_tid)
6297         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
6298         Update.
6299
6300 2019-05-04  Tom Tromey  <tom@tromey.com>
6301
6302         * arc-tdep.c (arc_tdesc_init): Return bool.
6303
6304 2019-05-04  Tom Tromey  <tom@tromey.com>
6305
6306         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
6307         Use gdb_assert_not_reached.
6308
6309 2019-05-04  Tom Tromey  <tom@tromey.com>
6310
6311         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
6312         "false".
6313
6314 2019-05-04  Tom Tromey  <tom@tromey.com>
6315
6316         * arc-tdep.c (arc_tdesc_init): Use bool.
6317
6318 2019-05-04  Tom Tromey  <tom@tromey.com>
6319
6320         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
6321
6322 2019-05-04  Tom Tromey  <tom@tromey.com>
6323
6324         * cli/cli-cmds.c (valid_command_p): Return bool.
6325
6326 2019-05-04  Tom Tromey  <tom@tromey.com>
6327
6328         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
6329         * command.h (valid_user_defined_cmd_name_p): Channge return type.
6330
6331 2019-05-04  Raul Tambre  <raul@tambre.ee>
6332
6333         * python/lib/gdb/prompt.py (_ExtendedPrompt)
6334         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
6335         operator for comparison.
6336
6337 2019-05-04  Tom Tromey  <tom@tromey.com>
6338
6339         * psymtab.c (psymbol_name_matches, match_partial_symbol)
6340         (lookup_partial_symbol, print_partial_symbols)
6341         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
6342         (psymbol_compare): Update.
6343         (add_psymbol_to_bcache): Clear the entire psymbol.
6344         (maintenance_check_psymtabs): Update.
6345         * psympriv.h (struct partial_symbol): Don't derive from
6346         general_symbol_info.
6347         <obj_section, unrelocated_address, address,
6348         set_unrelocated_address>: Update.
6349         <ginfo>: New member.
6350         * dwarf-index-write.c (write_psymbols, debug_names::insert)
6351         (debug_names::write_psymbols): Update.
6352
6353 2019-05-04  Tom de Vries  <tdevries@suse.de>
6354
6355         * contrib/cc-with-tweaks.sh: Support -n arg.
6356
6357 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6358
6359         * corelow.c (core_target::detach): Ensure frame cache and
6360         register caches are cleared.
6361         inferior.c (exit_inferior_1): Likewise.
6362
6363 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
6364             Tom Tromey  <tom@tromey.com>
6365
6366         * dictionary.c (collate_pending_symbols_by_language): Remove
6367         "struct" from foreach.
6368         * symtab.c (lookup_global_symbol_from_objfile)
6369         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
6370         foreach.
6371         * ser-tcp.c (net_open): Remove "struct" from foreach.
6372         * objfiles.c (objfile_relocate, objfile_rebase)
6373         (objfile_has_symbols): Remove "struct" from foreach.
6374         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
6375         from foreach.
6376         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
6377         foreach.
6378         * darwin-nat.c (thread_info_from_private_thread_info): Remove
6379         "struct" from foreach.
6380         * ada-lang.c (create_excep_cond_exprs)
6381         (ada_exception_catchpoint_cond_string): Remove "struct" from
6382         foreach.
6383
6384 2019-05-03  Tom Tromey  <tromey@adacore.com>
6385
6386         * ada-exp.y (convert_char_literal): Check suffix of each
6387         enumerator.
6388
6389 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
6390
6391         PR ada/21406:
6392         * ada-exp.y (yywrap): Don't define.
6393         * ada-lex.l (%option): Add noyywrap
6394         (yywrap): Remove.
6395
6396 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
6397
6398         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
6399         _WIN32_WINNT to the XP level, unless already defined to a higher
6400         level.
6401
6402         * unittests/parse-connection-spec-selftests.c:
6403         * ser-tcp.c:
6404         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
6405         override.
6406
6407         * symfile.c (find_separate_debug_file): Remove colon from the
6408         drive spec of DOS/Windows file names of the target, so that the
6409         file name produced from DEBUGDIR and the target's directory will
6410         be valid on DOS/Windows systems.
6411
6412 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
6413
6414         * rust-lang.c (val_print_struct): Handle printing structures
6415         containing strings.
6416
6417 2019-05-02  Tom Tromey  <tromey@adacore.com>
6418
6419         * valarith.c (_initialize_valarith): Remove.
6420
6421 2019-05-01  Tom Tromey  <tromey@adacore.com>
6422
6423         * ada-lang.c (ada_value_primitive_field): Treat more fields as
6424         bitfields.
6425
6426 2019-05-01  Tom Tromey  <tromey@adacore.com>
6427
6428         * ada-lang.c (ada_value_assign): Correctly compute starting offset
6429         for big-endian copies.
6430
6431 2019-04-30  Ali Tamur  <tamur@google.com>
6432         * gdb/dwarf2read.c (read_3_bytes): New declaration.
6433         (read_attribute_value): Added DW_FORM_strx1-4 cases.
6434         (read_3_bytes): New function.
6435
6436 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6437
6438         * windows-nat.c (main_thread_id): Delete.
6439         (handle_output_debug_string): Replace main_thread_id by
6440         current_event.dwThreadId.
6441         (fake_create_process): Likewise.
6442         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
6443         Do not set main_thread_id.
6444         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
6445         current_event.dwThreadId.
6446         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
6447
6448 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6449
6450         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
6451         Use current_event.dwThreadId instead of main_thread_id.
6452
6453 2019-04-30  Tom Tromey  <tromey@adacore.com>
6454
6455         * ada-lang.c (ada_lookup_simple_minsyms): New function.
6456         (create_excep_cond_exprs): Iterate over program spaces.
6457         (ada_exception_catchpoint_cond_string): Examine all minimal
6458         symbols for exception types.
6459
6460 2019-04-30  Tom Tromey  <tromey@adacore.com>
6461
6462         PR c++/24470:
6463         * dwarf2read.c (process_structure_scope): Handle case where type
6464         has template parameters but no symbol was created.
6465
6466 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6467             Chris January  <chris.january@arm.com>
6468
6469         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
6470         qualifier.
6471         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
6472
6473 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6474
6475         * f-typeprint.c (f_print_type): Update rules for printing
6476         whitespace.
6477         (f_type_print_varspec_suffix): Likewise.
6478
6479 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6480             Chris January  <chris.january@arm.com>
6481
6482         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
6483         function arguments.
6484
6485 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6486
6487         * f-lang.c (build_fortran_types): Change name of void type to
6488         lower case.
6489         * f-typeprint.c (f_type_print_base): Print the name of the void
6490         type, rather than a fixed string.
6491         * f-valprint.c (f_decorations): Use lower case void string.
6492
6493 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6494             Chris January  <chris.january@arm.com>
6495
6496         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
6497         types for Fortran.
6498
6499 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6500             Chris January  <chris.january@arm.com>
6501             David Lecomber  <david.lecomber@arm.com>
6502
6503         * f-exp.y (BINOP_INTRINSIC): New token.
6504         (exp): New parser rule handling BINOP_INTRINSIC.
6505         (f77_keywords): Add new builtin procedures.
6506         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
6507         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6508         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
6509         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6510         (print_unop_subexp_f): New function.
6511         (print_binop_subexp_f): New function.
6512         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6513         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6514         (dump_subexp_body_f): Likewise.
6515         (operator_check_f): Likewise.
6516         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6517         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
6518
6519 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6520
6521         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
6522         UNOP_KIND.
6523         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
6524         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
6525         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
6526         (operator_length_f): New fuction.
6527         (print_subexp_f): New function.
6528         (op_name_f): New function.
6529         (dump_subexp_body_f): New function.
6530         (operator_check_f): New function.
6531         (exp_descriptor_f): Replace standard expression handling functions
6532         with new functions.
6533         * gdb/fortran-operator.def: New file.
6534         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
6535         * gdb/std-operator.def: Remove UNOP_KIND.
6536
6537 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6538
6539         * std-operator.def: Remove unbalanced, stray double quote
6540         character.
6541
6542 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6543             Chris January  <chris.january@arm.com>
6544             Daniel Everett  <daniel.everett@arm.com>
6545             Nick Forrington  <nick.forrington@arm.com>
6546             Richard Bunt  <richard.bunt@arm.com>
6547
6548         * cp-valprint.c (cp_print_value_fields): Allow an additional level
6549         of depth when printing anonymous structs or unions.
6550         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
6551         Don't print either the top-level value, or the children if the
6552         max-depth is exceeded.
6553         (ppscm_print_children): When printing the key of a map, allow one
6554         extra level of depth.
6555         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
6556         print either the top-level value, or the children if the max-depth
6557         is exceeded.
6558         (print_children): When printing the key of a map, allow one extra
6559         level of depth.
6560         * python/py-value.c (valpy_format_string): Add max_depth keyword.
6561         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
6562         (user_print_options): Initialise max_depth field.
6563         (val_print_scalar_or_string_type_p): New function.
6564         (val_print): Check to see if the max depth has been reached.
6565         (val_print_check_max_depth): Define new function.
6566         (show_print_max_depth): New function.
6567         (_initialize_valprint): Add 'print max-depth' option.
6568         * valprint.h (struct value_print_options) <max_depth>: New field.
6569         (val_print_check_max_depth): Declare new function.
6570         * NEWS: Document new feature.
6571
6572 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6573
6574         * ada-lang.c (ada_language_defn): Initialise new field.
6575         * c-lang.c (c_is_string_type_p): New function.
6576         (c_language_defn): Initialise new field.
6577         (cplus_language_defn): Initialise new field.
6578         (asm_language_defn): Initialise new field.
6579         (minimal_language_defn): Initialise new field.
6580         * c-lang.h (c_is_string_type_p): Declare new function.
6581         * d-lang.c (d_language_defn): Initialise new field.
6582         * f-lang.c (f_is_string_type_p): New function.
6583         (f_language_defn): Initialise new field.
6584         * go-lang.c (go_is_string_type_p): New function.
6585         (go_language_defn): Initialise new field.
6586         * language.c (default_is_string_type_p): New function.
6587         (unknown_language_defn): Initialise new field.
6588         (auto_language_defn): Initialise new field.
6589         * language.h (struct language_defn) <la_is_string_type_p>: New
6590         member variable.
6591         (default_is_string_type_p): Declare new function.
6592         * m2-lang.c (m2_language_defn): Initialise new field.
6593         * objc-lang.c (objc_language_defn): Initialise new field.
6594         * opencl-lang.c (opencl_language_defn): Initialise new field.
6595         * p-lang.c (pascal_is_string_type_p): New function.
6596         (pascal_language_defn): Initialise new field.
6597         * rust-lang.c (rust_is_string_type_p): New function.
6598         (rust_language_defn): Initialise new field.
6599
6600 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6601
6602         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
6603         New field.
6604         * ada-lang.c (ada_language_defn): Initialise new field.
6605         * c-lang.c (c_language_defn): Likewise.
6606         (cplus_language_defn): Likewise.
6607         (asm_language_defn): Likewise.
6608         (minimal_language_defn): Likewise.
6609         * d-lang.c (d_language_defn): Likewise.
6610         * f-lang.c (f_language_defn): Likewise.
6611         * go-lang.c (go_language_defn): Likewise.
6612         * language.c (unknown_language_defn): Likewise.
6613         (auto_language_defn): Likewise.
6614         * m2-lang.c (m2_language_defn): Likewise.
6615         * objc-lang.c (objc_language_defn): Likewise.
6616         * opencl-lang.c (opencl_language_defn): Likewise.
6617         * p-lang.c (pascal_language_defn): Likewise.
6618         * rust-lang.c (rust_language_defn): Likewise.
6619
6620 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6621
6622         * ada-lang.c (ada_is_character_type): Change return type to bool.
6623         (ada_is_string_type): Likewise.
6624         * ada-lang.h (ada_is_character_type): Update declaration
6625         (ada_is_string_type): Likewise.
6626
6627 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6628
6629         Support style in 'frame|thread apply'
6630
6631         * gdbcmd.h (execute_command_to_string): New term_out parameter.
6632         * record.c (record_start, record_stop): Update callers of
6633         execute_command_to_string with false.
6634         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
6635         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
6636         methods.
6637         (class string_file): New constructor with term_out parameter.
6638         Override methods term_out and can_emit_style_escape.  New member
6639         term_out.
6640         (class stdio_file): Override can_emit_style_escape.
6641         (class tee_file): Override term_out and can_emit_style_escape.
6642         * utils.h (can_emit_style_escape): Remove.
6643         * utils.c (can_emit_style_escape): Likewise.
6644         Update all callers of can_emit_style_escape (SOMESTREAM) to
6645         SOMESTREAM->can_emit_style_escape.
6646         * source-cache.c (source_cache::get_source_lines): Likewise.
6647         * stack.c (frame_apply_command_count): Call execute_command_to_string
6648         passing the term_out characteristic of the current gdb_stdout.
6649         * thread.c (thr_try_catch_cmd): Likewise.
6650         * top.c (execute_command_to_string): pass term_out parameter
6651         to construct the string_file for the command output.
6652         * ui-file.c (term_cli_styling): New function (most code moved
6653         from utils.c can_emit_style_escape).
6654         (string_file::string_file, string_file::can_emit_style_escape,
6655         stdio_file::can_emit_style_escape, tee_file::term_out,
6656         tee_file::can_emit_style_escape): New functions.
6657
6658 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6659
6660         * NEWS: Mention the new set|show may-call-functions.
6661         * infcall.c (may_call_functions_p): New variable.
6662         (show_may_call_functions_p): New function.
6663         (call_function_by_hand_dummy): Throws an error if not
6664         may-call-functions.
6665         (_initialize_infcall): Call add_setshow_boolean_cmd for
6666         may-call-functions.
6667
6668 2019-04-25  Keith Seitz  <keiths@redhat.com>
6669
6670         PR c++/24367
6671         * cp-support.c (inspect_type): Don't attempt substitutions
6672         of symbol with the same name.
6673
6674 2019-04-25  Tom Tromey  <tromey@adacore.com>
6675
6676         PR gdb/24475:
6677         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
6678         static.
6679
6680 2019-04-25  Tom Tromey  <tromey@adacore.com>
6681
6682         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
6683         rvalue reference.
6684         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
6685         (gdb_xml_parser::parse): Use std::move.
6686         * python/python-internal.h (gdbpy_convert_exception): Take a const
6687         reference.
6688         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
6689         std::move.
6690         * python/py-utils.c (gdbpy_convert_exception): Take a const
6691         reference.
6692         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6693         Use std::move.
6694         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6695         Use std::move.
6696         * mi/mi-main.c (mi_print_exception): Take a const reference.
6697         * main.c (handle_command_errors): Take a const reference.
6698         * linespec.c (parse_linespec): Use std::move.
6699         * infcall.c (run_inferior_call): Use std::move.
6700         (call_function_by_hand_dummy): Use std::move.
6701         * exec.c (try_open_exec_file): Use std::move.
6702         * exceptions.h (exception_print, exception_fprintf)
6703         (exception_print_same): Update.
6704         * exceptions.c (print_exception, exception_print)
6705         (exception_fprintf, exception_print_same): Change parameters to
6706         const reference.
6707         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
6708         * common/new-op.c: Use std::move.
6709         * common/common-exceptions.h (struct gdb_exception): Add move
6710         constructor.
6711         (struct gdb_exception_error, struct gdb_exception_quit, struct
6712         gdb_quit_bad_alloc): Change constructor to move constructor.
6713         (throw_exception): Change parameter to rvalue reference.
6714         * common/common-exceptions.c (throw_exception): Take rvalue
6715         reference.
6716         * cli/cli-interp.c (safe_execute_command): Use std::move.
6717         * breakpoint.c (insert_bp_location, location_to_sals): Use
6718         std::move.
6719
6720 2019-04-25  Tom Tromey  <tromey@adacore.com>
6721
6722         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
6723         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
6724         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
6725         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
6726         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
6727         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
6728         guile/scm-value.c: Use unpack.
6729         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
6730         gdbscm_gdb_exception.
6731         (gdbscm_throw_gdb_exception): Likewise.
6732         (struct gdbscm_gdb_exception): New.
6733         (unpack): New function.
6734         (gdbscm_wrap): Use unpack.
6735
6736 2019-04-25  Tom Tromey  <tromey@adacore.com>
6737
6738         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6739         (gdb_rl_callback_handler): Use std::move.
6740         * common/common-exceptions.h (struct gdb_exception): Add move
6741         assignment operator.
6742         (throw_exception_sjlj): Change "exception" to const reference.
6743         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
6744         (throw_exception_sjlj): Change "exception" to const reference.
6745
6746 2019-04-25  Tom Tromey  <tromey@adacore.com>
6747
6748         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
6749         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
6750         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6751         Update.
6752         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6753         Update.
6754         * mi/mi-interp.c (mi_interp::exec): Update.
6755         * linespec.c (parse_linespec): Update.
6756         * infcall.c (run_inferior_call): Update.
6757         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
6758         * guile/scm-symbol.c (gdbscm_lookup_symbol)
6759         (gdbscm_lookup_global_symbol): Update.
6760         * guile/scm-param.c (gdbscm_parameter_value): Update.
6761         * guile/scm-frame.c (gdbscm_frame_read_register)
6762         (gdbscm_frame_read_var): Update.
6763         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
6764         * exec.c (try_open_exec_file): Update.
6765         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6766         (gdb_rl_callback_handler): Update.
6767         * common/common-exceptions.h (exception_none): Don't declare.
6768         * common/common-exceptions.c (exception_none): Don't define.
6769         (struct catcher) <exception>: Update.
6770         * cli/cli-interp.c (safe_execute_command): Update.
6771         * breakpoint.c (insert_bp_location, location_to_sals): Update.
6772
6773 2019-04-25  Ali Tamur  <tamur@google.com>
6774
6775         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
6776         (read_attribute_value): Likewise.
6777         (dwarf2_read_addr_index): Update comment.
6778         (read_str_index): Add DW_FORM_strx.
6779         (dwarf2_string_attr): Likewise.
6780         (dwarf2_const_value_attr): Likewise.
6781         (dump_die_shallow): Likewise.
6782         (dwarf2_fetch_constant_bytes): Likewise.
6783         (skip_form_bytes): Likewise.
6784         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
6785
6786 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
6787
6788         PR corefiles/11608
6789         PR corefiles/18187
6790         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
6791         OFFSET.  Verify if current mapping contains an ELF header.
6792         (linux_find_memory_regions_full): Adjust call to
6793         dump_mapping_p.
6794
6795 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
6796             Kang Li <kanglictf@gmail.com>
6797
6798         PR gdb/21600
6799
6800         * dwarf2-frame.c (read_initial_length): Be consistent about using
6801         unsigned representation of length.
6802         (decode_frame_entry_1): Likewise.  Check for wraparound of
6803         end pointer as well as buffer overflow.
6804
6805 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
6806
6807         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
6808         "vq".
6809
6810 2019-04-24  Tom Tromey  <tromey@adacore.com>
6811
6812         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
6813
6814 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6815
6816         * s12z-tdep.c (s12z_unwind_pc): Delete.
6817         (s12z_unwind_sp): Delete.
6818         (s12z_gdbarch_init): Don't register deleted functions with
6819         gdbarch.
6820
6821 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6822
6823         * rl78-tdep.c (rl78_unwind_sp): Delete.
6824         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
6825
6826 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6827
6828         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
6829         (xstormy16_unwind_pc): Delete.
6830         (xstormy16_dummy_id): Delete.
6831         (xstormy16_gdbarch_init): Don't register deleted functions with
6832         gdbarch.
6833
6834 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6835
6836         * vax-tdep.c (vax_unwind_pc): Delete.
6837         (vax_gdbarch_init): Don't register deleted function with gdbarch.
6838
6839 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6840
6841         * v850-tdep.c (v850_unwind_sp): Delete.
6842         (v850_unwind_pc): Delete.
6843         (v850_dummy_id): Delete.
6844         (v850_gdbarch_init): Don't register deleted functions with
6845         gdbarch.
6846
6847 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6848
6849         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
6850         (tilegx_unwind_pc): Delete.
6851         (tilegx_unwind_dummy_id): Delete.
6852         (tilegx_gdbarch_init): Don't register deleted functions with
6853         gdbarch.
6854
6855 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6856
6857         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
6858         (tic6x_dummy_id): Delete.
6859         (tic6x_gdbarch_init): Don't register deleted functions with
6860         gdbarch.
6861
6862 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6863
6864         * sparc-tdep.c (sparc_unwind_pc): Delete.
6865         (sparc32_gdbarch_init): Don't register deleted function with
6866         gdbarch.
6867
6868 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6869
6870         * sh-tdep.c (sh_unwind_sp): Delete.
6871         (sh_unwind_pc): Delete.
6872         (sh_dummy_id): Delete.
6873         (sh_gdbarch_init): Don't register deleted functions with
6874         gdbarch.
6875
6876 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6877
6878         * score-tdep.c (score_unwind_sp): Delete.
6879         (score_unwind_pc): Delete.
6880         (score_dummy_id): Delete.
6881         (score_gdbarch_init): Don't register deleted functions with
6882         gdbarch.
6883
6884 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6885
6886         * rx-tdep.c (rx_unwind_pc): Delete.
6887         (rx_unwind_sp): Delete.
6888         (rx_dummy_id): Delete.
6889         (rx_gdbarch_init): Don't register deleted functions with
6890         gdbarch.  Update comment.
6891
6892 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6893
6894         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
6895         (rs6000_dummy_id): Delete.
6896         (rs6000_gdbarch_init): Don't register deleted functions with
6897         gdbarch.
6898
6899 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6900
6901         * or1k-tdep.c (or1k_dummy_id): Delete.
6902         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
6903
6904 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6905
6906         * nios2-tdep.c (nios2_dummy_id): Delete.
6907         (nios2_unwind_sp): Delete.
6908         (nios2_gdbarch_init): Don't register deleted functions with
6909         gdbarch.
6910
6911 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6912
6913         * nds32-tdep.c (nds32_dummy_id): Delete.
6914         (nds32_unwind_pc): Delete.
6915         (nds32_unwind_sp): Delete.
6916         (nds32_gdbarch_init): Don't register deleted functions with
6917         gdbarch.
6918
6919 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6920
6921         * msp430-tdep.c (msp430_unwind_pc): Delete.
6922         (msp430_unwind_sp): Delete.
6923         (msp430_dummy_id): Delete.
6924         (msp430_gdbarch_init): Don't register deleted functions with
6925         gdbarch.
6926
6927 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6928
6929         * moxie-tdep.c (moxie_unwind_sp): Delete.
6930         (moxie_unwind_pc): Delete.
6931         (moxie_dummy_id): Delete.
6932         (moxie_gdbarch_init): Don't register deleted functions with
6933         gdbarch.
6934
6935 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6936
6937         * mn10300-tdep.c (mn10300_dummy_id): Delete.
6938         (mn10300_unwind_pc): Delete.
6939         (mn10300_unwind_sp): Delete.
6940         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6941         mn10300_unwind_sp.
6942         (mn10300_frame_unwind_init): Don't register deleted functions with
6943         gdbarch.
6944
6945 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6946
6947         * mep-tdep.c (mep_unwind_pc): Delete.
6948         (mep_unwind_sp): Delete.
6949         (mep_dummy_id): Delete.
6950         (mep_gdbarch_init): Don't register deleted functions with
6951         gdbarch.
6952
6953 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6954
6955         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6956         (m68hc11_unwind_sp): Delete.
6957         (m68hc11_gdbarch_init): Don't register deleted functions with
6958         gdbarch.
6959
6960 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6961
6962         * m32r-tdep.c (m32r_unwind_sp): Delete.
6963         (m32r_unwind_pc): Delete.
6964         (m32r_dummy_id): Delete.
6965         (m32r_gdbarch_init): Don't register deleted functions with
6966         gdbarch.
6967
6968 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6969
6970         * m32c-tdep.c (m32c_unwind_pc): Delete.
6971         (m32c_unwind_sp): Delete.
6972         (m32c_dummy_id): Delete.
6973         (m32c_gdbarch_init): Don't register deleted functions with
6974         gdbarch.
6975
6976 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6977
6978         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6979         (lm32_unwind_pc): Delete.
6980         (lm32_dummy_id): Delete.
6981         (lm32_gdbarch_init): Don't register deleted functions with
6982         gdbarch.
6983
6984 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6985
6986         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6987         (iq2000_unwind_pc): Delete.
6988         (iq2000_dummy_id): Delete.
6989         (iq2000_gdbarch_init): Don't register deleted functions with
6990         gdbarch.
6991
6992 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6993
6994         * nds32-tdep.c (nds32_type_align): Delete.
6995         (nds32_push_dummy_call): Use type_align instead.
6996
6997 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6998
6999         * arm-tdep.c (arm_type_align): Only handle vector override case.
7000         (arm_push_dummy_call): Use type_align.
7001         (arm_gdbarch_init): Register arm_type_align gdbarch function.
7002
7003 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7004
7005         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
7006         case.
7007         (pass_on_stack): Use type_align.
7008         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
7009         function.
7010
7011 2019-04-23  Tom Tromey  <tromey@adacore.com>
7012
7013         * dwarf2read.c (line_header::file_name_at): Remove unused
7014         overload.
7015
7016 2019-04-23  Tom de Vries  <tdevries@suse.de>
7017
7018         PR gdb/24438
7019         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
7020         invocation.
7021
7022
7023 2019-03-27  Ali Tamur  <tamur@google.com>
7024
7025         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
7026         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
7027         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
7028         (dwarf_expr_context::get_addr_index): Likewise
7029         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
7030         (symbol_needs_eval_context::get_addr_index): Likewise
7031         (disassemble_dwarf_expression): Add DW_OP_addrx
7032         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
7033         (read_cutu_die_from_dwo): Update comment
7034         (skip_one_die): Add DW_FORM_addrx
7035         (read_attribute_value): Likewise
7036         (var_decode_location): Add DW_OP_addrx
7037         (dwarf2_const_value_attr): Add DW_FORM_addrx
7038         (dump_die_shallow): Likewise
7039         (dwarf2_fetch_constant_bytes): Likewise
7040         (decode_locdesc): Add DW_OP_addrx
7041         (skip_form_bytes): Add DW_FORM_addrx
7042
7043 2019-04-22  Ali Tamur  <tamur@google.com>
7044
7045         * MAINTAINERS (Write After Approval): Add self.
7046
7047 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
7048
7049         * solib-svr4.c (get_svr4_info): Add pspace parameter.
7050         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
7051         (open_symbol_file_object): Likewise.
7052         (svr4_default_sos): Add info parameter.
7053         (svr4_read_so_list): Likewise.
7054         (svr4_current_sos_direct): Adjust functions calls to pass down
7055         info.
7056         (svr4_current_sos_1): Add info parameter.
7057         (svr4_current_sos): Call get_svr4_info, pass info down to
7058         svr4_current_sos_1.
7059         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
7060         get_svr4_info.
7061         (svr4_in_dynsym_resolve_code): Pass current_program_space to
7062         get_svr4_info.
7063         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
7064         to get_svr4_info.
7065         (probes_table_remove_objfile_probes): Likewise.
7066         (register_solib_event_probe): Add info parameter.
7067         (solist_update_incremental): Pass info parameter down to
7068         svr4_read_so_list.
7069         (disable_probes_interface): Add info parameter.
7070         (svr4_handle_solib_event): Pass current_program_space to
7071         get_svr4_info.  Adjust disable_probes_interface cleanup.
7072         (svr4_create_probe_breakpoints): Add info parameter, pass it
7073         down to register_solib_event_probe.
7074         (svr4_create_solib_event_breakpoints): Add info parameter,
7075         pass it down to svr4_create_probe_breakpoints.
7076         (enable_break): Pass info down to
7077         svr4_create_solib_event_breakpoints.
7078         (svr4_solib_create_inferior_hook): Pass current_program_space to
7079         get_svr4_info.
7080         (svr4_clear_solib): Likewise.
7081
7082 2019-04-22  Pedro Alves  <palves@redhat.com>
7083
7084         * solib-svr4.c (svr4_free_objfile_observer): New.
7085         (probe_and_action::objfile): New field.
7086         (probes_table_htab_remove_objfile_probes)
7087         (probes_table_remove_objfile_probes): New functions.
7088         (register_solib_event_probe): Add 'objfile' parameter.  Store it
7089         in the new probe_and_action.  Don't store the probe in 'lookup'.
7090         (svr4_create_probe_breakpoints): Pass objfile to
7091         register_solib_event_probe.
7092         (_initialize_svr4_solib): Register a free_objfile observer.
7093
7094 2019-04-19  Tom Tromey  <tom@tromey.com>
7095
7096         * common/queue.h: Remove.
7097
7098 2019-04-19  Tom Tromey  <tom@tromey.com>
7099
7100         * event-loop.c: Don't include "common/queue.h".
7101
7102 2019-04-19  Tom Tromey  <tom@tromey.com>
7103
7104         * remote.c (remote_target): Use delete.
7105         * remote-notif.h: Include <list>, not "common/queue.h".
7106         (notif_client_p): Remove typedef.
7107         (remote_notif_state): Add constructor, destructor, initializer.
7108         <notif_queue>: Now a std::list.
7109         (remote_notif_state_xfree): Don't declare.
7110         * remote-notif.c (remote_notif_process, handle_notification)
7111         (remote_notif_state_allocate): Update.
7112         (~remote_notif_state): Rename from remote_notif_state_xfree.
7113
7114 2019-04-19  Tom Tromey  <tom@tromey.com>
7115
7116         * symfile.c (reread_symbols): Update.
7117         * objfiles.c (objfile_register_static_link)
7118         (objfile_lookup_static_link): Update
7119         (~objfile) Don't delete static_links.
7120         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
7121
7122 2019-04-19  Tom Tromey  <tom@tromey.com>
7123
7124         * type-stack.h (struct type_stack) <insert>: Constify string.
7125         * type-stack.c (type_stack::insert): Constify string.
7126         * gdbtypes.h (lookup_template_type): Update.
7127         (address_space_name_to_int): Update.
7128         * gdbtypes.c (address_space_name_to_int): Make space_identifier
7129         const.
7130         (lookup_template_type): Make name const.
7131         * c-exp.y: Update rules.
7132         (lex_one_token, classify_name, classify_inner_name)
7133         (c_print_token): Update.
7134         * p-exp.y: Update rules.
7135         (yylex): Update.
7136         * f-exp.y: Update rules.
7137         (yylex): Update.
7138         * d-exp.y: Update rules.
7139         (lex_one_token, classify_name, classify_inner_name): Update.
7140         * parse.c (write_dollar_variable, copy_name): Return std::string.
7141         * parser-defs.h (copy_name): Change return type.
7142         * m2-exp.y: Update rules.
7143         (yylex): Update.
7144         * go-exp.y (lex_one_token): Update.
7145         Update rules.
7146         (classify_unsafe_function, classify_packaged_name)
7147         (classify_name, yylex): Update.
7148
7149 2019-04-19  Sergei Trofimovich <siarheit@google.com>
7150
7151         * configure.ac: add --enable-source-highlight switch.
7152         * configure: Regenerate.
7153         * top.c (print_gdb_version): plumb --enable-source-highlight
7154         status to "show configuration".
7155
7156 2019-04-19  Tom Tromey  <tromey@adacore.com>
7157
7158         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
7159         Check ADA_TYPE_P.
7160         (empty_record, ada_template_to_fixed_record_type_1)
7161         (template_to_static_fixed_type)
7162         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
7163         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
7164         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
7165         macros.
7166
7167 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
7168
7169         PR symtab/24423:
7170         * source.c (print_source_lines_base): Advance "iter" when a
7171         control character is seen.
7172
7173 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7174
7175         * inferior.h (struct infcall_suspend_state_deleter):
7176         Catch exception in destructor to avoid crash.
7177
7178 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7179
7180         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
7181         close to the add_com "shell".
7182
7183 2019-04-18  Tom Tromey  <tromey@adacore.com>
7184
7185         * process-stratum-target.h (class process_stratum_target)
7186         <stratum>: Add "final".
7187
7188 2019-04-17  Tom Tromey  <tromey@adacore.com>
7189
7190         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
7191         against nullptr before use.
7192
7193 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
7194
7195         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
7196
7197 2019-04-17  Jim Wilson  <jimw@sifive.com>
7198             Andrew Burgess  <andrew.burgess@embecosm.com>
7199
7200         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
7201         code read might fail, assume 4-byte breakpoint in that case.
7202
7203 2019-04-15  Leszek Swirski  <leszeks@google.com>
7204
7205         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
7206         rather than a hand-rolled POD check when checking for forced MEMORY
7207         classification.
7208
7209 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7210
7211         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
7212         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
7213         function.
7214         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
7215         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
7216         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
7217         declaration.
7218
7219 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7220
7221         * aarch64-linux-nat.c
7222         (aarch64_linux_nat_target::thread_architecture): Add override.
7223         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
7224         each VQ.
7225
7226 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7227
7228         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
7229
7230 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
7231
7232         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
7233         target types of size 96-bits, add some additional comments, and
7234         check that the builtin type we found was the correct size.
7235
7236 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
7237
7238         * utils.c (prompt_for_continue): Don't restore the styling at the
7239         end, as applied_style has the wrong value.  This fixes styling in
7240         long lists of file names that are interrupted by the "Continue?"
7241         prompt.
7242
7243 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7244
7245         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
7246         * c-lang.c (c_language_defn): Likewise.
7247         (cplus_language_defn): Likewise.
7248         (asm_language_defn): Likewise.
7249         (minimal_language_defn): Likewise.
7250         * d-lang.c (d_language_defn): Likewise.
7251         * f-lang.c (f_language_defn): Likewise.
7252         * go-lang.c (go_language_defn): Likewise.
7253         * language.c (unknown_language_defn): Likewise.
7254         (auto_language_defn): Likewise.
7255         * language.h (struct language_defn): Remove la_magic field.
7256         (LANG_MAGIC): Delete.
7257         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
7258         * objc-lang.c (objc_language_defn): Likewise.
7259         * opencl-lang.c (opencl_language_defn): Likewise.
7260         * p-lang.c (pascal_language_defn): Likewise.
7261         * rust-lang.c (rust_language_defn): Likewise.
7262
7263 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7264
7265         * riscv-tdep.c (riscv_type_align): New function.
7266         (riscv_type_alignment): Delete.
7267         (riscv_arg_location): Use 'type_align'.
7268         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
7269
7270 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7271
7272         * gdbtypes.c (type_align): A struct with no non-static fields also
7273         has alignment of 1.
7274
7275 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7276
7277         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
7278         component to 0.
7279         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
7280         member.
7281         (riscv_struct_info::analyse): New implementation using new
7282         analyse_inner member function.
7283         (riscv_struct_info::field_offset): New member function.
7284         (riscv_struct_info::m_offsets): New member variable.
7285         (riscv_struct_info::analyse_inner): New private member function,
7286         takes the old implementation of riscv_struct_info::analyse but
7287         extended to track field offsets.
7288         (riscv_call_arg_struct): Update the struct folding special cases
7289         to handle cases where empty C++ structs, which are non-zero
7290         length, are found.
7291         (riscv_arg_location): Initialise the length of each location, a
7292         non-zero length now indicates the location is in use.
7293         (riscv_push_dummy_call): Allow for the first location having a
7294         non-zero offset when setting up arguments.
7295         (riscv_return_value): Likewise, but for return values.
7296
7297 2019-04-11  Tom Tromey  <tromey@adacore.com>
7298
7299         * utils.c (internal_vproblem): Make "msg" const.
7300
7301 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
7302
7303         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
7304         * trad-frame.c (trad_frame_reset_saved_regs): New function.
7305         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
7306         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
7307
7308 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
7309
7310         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
7311         function.
7312         (fill_gregset): Call amd64_linux_collect_native_gregset instead
7313         of amd64_collect_native_gregset.
7314         (amd64_linux_nat_target::store_registers): Likewise.
7315
7316 2019-04-10  Tom Tromey  <tom@tromey.com>
7317
7318         * symtab.c (lookup_global_symbol_from_objfile)
7319         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
7320         * objfiles.h (class separate_debug_iterator): New.
7321         (class separate_debug_range): New.
7322         (struct objfile) <separate_debug_objfiles>: New method.
7323         (objfile_separate_debug_iterate): Don't declare.
7324         * objfiles.c (separate_debug_iterator::operator++): Rename from
7325         objfile_separate_debug_iterate.
7326         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
7327         iterator.
7328         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
7329         iterator.
7330
7331 2019-04-10  Tom Tromey  <tom@tromey.com>
7332
7333         * symfile.c (reread_symbols): Remove old comment.
7334         * objfiles.c (free_all_objfiles): Fix a typo.
7335
7336 2019-04-10  Tom Tromey  <tom@tromey.com>
7337
7338         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
7339         * minsyms.c (lookup_minimal_symbol): Use foreach.
7340         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
7341         (lookup_minimal_symbol_solib_trampoline): Likewise.
7342         * symfile.c (reread_symbols): Use foreach.
7343
7344 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
7345             Tom Tromey  <tromey@adacore.com>
7346
7347         PR rust/24414:
7348         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
7349         (rust_lex_int_test): Change "value" to be LONGEST.
7350         (rust_lex_tests): Add test for long integer literal.
7351
7352 2019-04-09  Tom Tromey  <tromey@adacore.com>
7353
7354         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
7355         to bool.
7356         (extended_remote_target::attach): Update.
7357         (remote_target::remote_notice_new_inferior): Update.
7358         (remote_target::add_current_inferior_and_thread): Update.
7359         * inferior.c (exit_inferior_1): Use "false".
7360         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
7361
7362 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
7363
7364         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
7365         the "start" command.
7366
7367 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7368
7369         * python/py-inferior.c (infpy_thread_from_thread_handle):
7370         Adjust comments to reflect renaming of thread_from_thread_handle
7371         to thread_from_handle.  Adjust keywords.  Fix type error message.
7372         (inferior_object_methods): Add thread_from_handle.  Retain
7373         thread_from_thread_handle, but mark it as deprecated.
7374
7375 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7376
7377         * gdbthread.h (find_thread_by_handle): Revise declaration.
7378         * thread.c (find_thread_by_handle): Likewise.  Adjust
7379         implementation too.
7380         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
7381         support for buffer objects as handles.
7382
7383 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7384
7385         * python/py-infthread.c (thpy_thread_handle): New function.
7386         (thread_object_methods): Register thpy_thread_handle.
7387
7388 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7389
7390         * gdbthread.h (thread_to_thread_handle): Declare.
7391         * thread.c (gdbtypes.h): Include.
7392         (thread_to_thread_handle): New function.
7393
7394         * target.h (struct target_ops): Add thread_info_to_thread_handle.
7395         (target_thread_info_to_thread_handle): Declare.
7396         * target.c (target_thread_info_to_thread_handle): New function.
7397         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
7398         * target-delegates.c: Regenerate.
7399
7400         * linux-thread-db.c (class thread_db_target): Add method
7401         thread_info_to_thread_handle.
7402         (thread_db_target::thread_info_to_thread_handle): Define.
7403         * remote.c (class remote_target): Add new method
7404         thread_info_to_thread_handle.
7405         (remote_target::thread_info_to_thread_handle): Define.
7406
7407 2019-04-08  Pedro Alves  <palves@redhat.com>
7408
7409         * common/common-exceptions.c (throw_exception): Don't create
7410         named object to throw; throw directly.
7411         (throw_it): Likewise.  Don't initialize gdb_exception::message
7412         here, with new; pass FMT and AP to the ctor instead.
7413         * common/common-exceptions.h: Include <string>.
7414         (gdb_exception::gdb_exception(enum return_reason, enum errors,
7415         const char *, va_list)): New ctor.  Use std::make_shared.
7416         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
7417         errors)): Delete.
7418         (gdb_exception_error::gdb_exception_error(enum errors, const char
7419         *, va_list)): New.
7420         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
7421         Add assertion.
7422         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
7423         errors)): Delete.
7424         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
7425         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
7426         Add assertion.
7427
7428 2019-04-08  Tom Tromey  <tom@tromey.com>
7429
7430         * valops.c (value_rtti_indirect_type): Replace throw_exception
7431         with throw.
7432         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
7433         with throw.
7434         * thread.c (thr_try_catch_cmd): Replace throw_exception with
7435         throw.
7436         * target.c (target_translate_tls_address): Replace throw_exception
7437         with throw.
7438         * stack.c (frame_apply_command_count): Replace throw_exception
7439         with throw.
7440         * solib-spu.c (append_ocl_sos): Replace throw_exception with
7441         throw.
7442         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
7443         with throw.
7444         * rs6000-tdep.c (rs6000_frame_cache)
7445         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
7446         * remote.c: Replace throw_exception with throw.
7447         * record-full.c (record_full_message, record_full_wait_1)
7448         (record_full_restore): Replace throw_exception with throw.
7449         * record-btrace.c:
7450         (get_thread_current_frame_id, record_btrace_start_replaying)
7451         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
7452         (cmd_record_btrace_start): Replace throw_exception with throw.
7453         * parse.c (parse_exp_in_context_1): Replace throw_exception with
7454         throw.
7455         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
7456         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
7457         * linespec.c:
7458         (find_linespec_symbols): Replace throw_exception with throw.
7459         * infrun.c (displaced_step_prepare, resume): Replace
7460         throw_exception with throw.
7461         * infcmd.c (post_create_inferior): Replace throw_exception with
7462         throw.
7463         * inf-loop.c (inferior_event_handler): Replace throw_exception
7464         with throw.
7465         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
7466         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
7467         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
7468         (get_prev_frame_always, get_frame_pc_if_available)
7469         (get_frame_address_in_block_if_available, get_frame_language):
7470         Replace throw_exception with throw.
7471         * frame-unwind.c (frame_unwind_try_unwinder): Replace
7472         throw_exception with throw.
7473         * eval.c (fetch_subexp_value, evaluate_var_value)
7474         (evaluate_funcall, evaluate_subexp_standard): Replace
7475         throw_exception with throw.
7476         * dwarf2loc.c (call_site_find_chain)
7477         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
7478         Replace throw_exception with throw.
7479         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
7480         with throw.
7481         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
7482         throw.
7483         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
7484         * completer.c (complete_line_internal): Replace throw_exception
7485         with throw.
7486         * compile/compile-object-run.c (compile_object_run): Replace
7487         throw_exception with throw.
7488         * cli/cli-script.c (process_next_line): Replace throw_exception
7489         with throw.
7490         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
7491         (btrace_enable, btrace_maint_update_pt_packets): Replace
7492         throw_exception with throw.
7493         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
7494         throw_exception with throw.
7495         * break-catch-throw.c (re_set_exception_catchpoint): Replace
7496         throw_exception with throw.
7497         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
7498         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
7499         * aarch64-tdep.c (aarch64_make_prologue_cache)
7500         (aarch64_make_stub_cache): Replace throw_exception with throw.
7501
7502 2019-04-08  Tom Tromey  <tom@tromey.com>
7503
7504         * common/common-exceptions.c (throw_exception): Rename from
7505         throw_exception_cxx.  Remove old copy.  Make argument const.
7506         (throw_it): Create and throw exception objects directly.
7507         * common/common-exceptions.h (throw_exception): Make argument
7508         const.
7509         (struct gdb_exception_error): Add constructor.
7510         (struct gdb_exception_quit): Add constructor.
7511
7512 2019-04-08  Tom Tromey  <tom@tromey.com>
7513
7514         * common/common-exceptions.h (exception_rethrow): Don't declare.
7515         (TRY_SJLJ): Update comment.
7516         (TRY, CATCH, END_CATCH): Remove.
7517         * common/common-exceptions.c (exception_rethrow): Remove.
7518
7519 2019-04-08  Tom Tromey  <tom@tromey.com>
7520
7521         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
7522         Remove.
7523         (gdb_exception_error): Rename from
7524         gdb_exception_RETURN_MASK_ERROR.
7525         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
7526         (gdb_quit_bad_alloc): Update.
7527         * aarch64-tdep.c: Update.
7528         * ada-lang.c: Update.
7529         * ada-typeprint.c: Update.
7530         * ada-valprint.c: Update.
7531         * amd64-tdep.c: Update.
7532         * arch-utils.c: Update.
7533         * break-catch-throw.c: Update.
7534         * breakpoint.c: Update.
7535         * btrace.c: Update.
7536         * c-varobj.c: Update.
7537         * cli/cli-cmds.c: Update.
7538         * cli/cli-interp.c: Update.
7539         * cli/cli-script.c: Update.
7540         * common/common-exceptions.c: Update.
7541         * common/new-op.c: Update.
7542         * common/selftest.c: Update.
7543         * compile/compile-c-symbols.c: Update.
7544         * compile/compile-cplus-symbols.c: Update.
7545         * compile/compile-object-load.c: Update.
7546         * compile/compile-object-run.c: Update.
7547         * completer.c: Update.
7548         * corelow.c: Update.
7549         * cp-abi.c: Update.
7550         * cp-support.c: Update.
7551         * cp-valprint.c: Update.
7552         * darwin-nat.c: Update.
7553         * disasm-selftests.c: Update.
7554         * dtrace-probe.c: Update.
7555         * dwarf-index-cache.c: Update.
7556         * dwarf-index-write.c: Update.
7557         * dwarf2-frame-tailcall.c: Update.
7558         * dwarf2-frame.c: Update.
7559         * dwarf2loc.c: Update.
7560         * dwarf2read.c: Update.
7561         * eval.c: Update.
7562         * event-loop.c: Update.
7563         * event-top.c: Update.
7564         * exec.c: Update.
7565         * f-valprint.c: Update.
7566         * fbsd-tdep.c: Update.
7567         * frame-unwind.c: Update.
7568         * frame.c: Update.
7569         * gdbtypes.c: Update.
7570         * gnu-v3-abi.c: Update.
7571         * guile/guile-internal.h: Update.
7572         * guile/scm-block.c: Update.
7573         * guile/scm-breakpoint.c: Update.
7574         * guile/scm-cmd.c: Update.
7575         * guile/scm-disasm.c: Update.
7576         * guile/scm-frame.c: Update.
7577         * guile/scm-lazy-string.c: Update.
7578         * guile/scm-math.c: Update.
7579         * guile/scm-param.c: Update.
7580         * guile/scm-ports.c: Update.
7581         * guile/scm-pretty-print.c: Update.
7582         * guile/scm-symbol.c: Update.
7583         * guile/scm-symtab.c: Update.
7584         * guile/scm-type.c: Update.
7585         * guile/scm-value.c: Update.
7586         * i386-linux-tdep.c: Update.
7587         * i386-tdep.c: Update.
7588         * inf-loop.c: Update.
7589         * infcall.c: Update.
7590         * infcmd.c: Update.
7591         * infrun.c: Update.
7592         * jit.c: Update.
7593         * language.c: Update.
7594         * linespec.c: Update.
7595         * linux-fork.c: Update.
7596         * linux-nat.c: Update.
7597         * linux-tdep.c: Update.
7598         * linux-thread-db.c: Update.
7599         * main.c: Update.
7600         * mi/mi-cmd-break.c: Update.
7601         * mi/mi-cmd-stack.c: Update.
7602         * mi/mi-interp.c: Update.
7603         * mi/mi-main.c: Update.
7604         * objc-lang.c: Update.
7605         * p-valprint.c: Update.
7606         * parse.c: Update.
7607         * ppc-linux-tdep.c: Update.
7608         * printcmd.c: Update.
7609         * python/py-arch.c: Update.
7610         * python/py-breakpoint.c: Update.
7611         * python/py-cmd.c: Update.
7612         * python/py-finishbreakpoint.c: Update.
7613         * python/py-frame.c: Update.
7614         * python/py-framefilter.c: Update.
7615         * python/py-gdb-readline.c: Update.
7616         * python/py-inferior.c: Update.
7617         * python/py-infthread.c: Update.
7618         * python/py-lazy-string.c: Update.
7619         * python/py-linetable.c: Update.
7620         * python/py-objfile.c: Update.
7621         * python/py-param.c: Update.
7622         * python/py-prettyprint.c: Update.
7623         * python/py-progspace.c: Update.
7624         * python/py-record-btrace.c: Update.
7625         * python/py-record.c: Update.
7626         * python/py-symbol.c: Update.
7627         * python/py-type.c: Update.
7628         * python/py-unwind.c: Update.
7629         * python/py-utils.c: Update.
7630         * python/py-value.c: Update.
7631         * python/python.c: Update.
7632         * record-btrace.c: Update.
7633         * record-full.c: Update.
7634         * remote-fileio.c: Update.
7635         * remote.c: Update.
7636         * riscv-tdep.c: Update.
7637         * rs6000-aix-tdep.c: Update.
7638         * rs6000-tdep.c: Update.
7639         * rust-exp.y: Update.
7640         * rust-lang.c: Update.
7641         * s390-tdep.c: Update.
7642         * selftest-arch.c: Update.
7643         * solib-dsbt.c: Update.
7644         * solib-frv.c: Update.
7645         * solib-spu.c: Update.
7646         * solib-svr4.c: Update.
7647         * solib.c: Update.
7648         * sparc64-linux-tdep.c: Update.
7649         * stack.c: Update.
7650         * symfile-mem.c: Update.
7651         * symmisc.c: Update.
7652         * target.c: Update.
7653         * thread.c: Update.
7654         * top.c: Update.
7655         * tracefile-tfile.c: Update.
7656         * tui/tui.c: Update.
7657         * typeprint.c: Update.
7658         * unittests/cli-utils-selftests.c: Update.
7659         * unittests/parse-connection-spec-selftests.c: Update.
7660         * valops.c: Update.
7661         * valprint.c: Update.
7662         * value.c: Update.
7663         * varobj.c: Update.
7664         * windows-nat.c: Update.
7665         * x86-linux-nat.c: Update.
7666         * xml-support.c: Update.
7667
7668 2019-04-08  Tom Tromey  <tom@tromey.com>
7669
7670         * xml-support.c: Use C++ exception handling.
7671         * x86-linux-nat.c: Use C++ exception handling.
7672         * windows-nat.c: Use C++ exception handling.
7673         * varobj.c: Use C++ exception handling.
7674         * value.c: Use C++ exception handling.
7675         * valprint.c: Use C++ exception handling.
7676         * valops.c: Use C++ exception handling.
7677         * unittests/parse-connection-spec-selftests.c: Use C++ exception
7678         handling.
7679         * unittests/cli-utils-selftests.c: Use C++ exception handling.
7680         * typeprint.c: Use C++ exception handling.
7681         * tui/tui.c: Use C++ exception handling.
7682         * tracefile-tfile.c: Use C++ exception handling.
7683         * top.c: Use C++ exception handling.
7684         * thread.c: Use C++ exception handling.
7685         * target.c: Use C++ exception handling.
7686         * symmisc.c: Use C++ exception handling.
7687         * symfile-mem.c: Use C++ exception handling.
7688         * stack.c: Use C++ exception handling.
7689         * sparc64-linux-tdep.c: Use C++ exception handling.
7690         * solib.c: Use C++ exception handling.
7691         * solib-svr4.c: Use C++ exception handling.
7692         * solib-spu.c: Use C++ exception handling.
7693         * solib-frv.c: Use C++ exception handling.
7694         * solib-dsbt.c: Use C++ exception handling.
7695         * selftest-arch.c: Use C++ exception handling.
7696         * s390-tdep.c: Use C++ exception handling.
7697         * rust-lang.c: Use C++ exception handling.
7698         * rust-exp.y: Use C++ exception handling.
7699         * rs6000-tdep.c: Use C++ exception handling.
7700         * rs6000-aix-tdep.c: Use C++ exception handling.
7701         * riscv-tdep.c: Use C++ exception handling.
7702         * remote.c: Use C++ exception handling.
7703         * remote-fileio.c: Use C++ exception handling.
7704         * record-full.c: Use C++ exception handling.
7705         * record-btrace.c: Use C++ exception handling.
7706         * python/python.c: Use C++ exception handling.
7707         * python/py-value.c: Use C++ exception handling.
7708         * python/py-utils.c: Use C++ exception handling.
7709         * python/py-unwind.c: Use C++ exception handling.
7710         * python/py-type.c: Use C++ exception handling.
7711         * python/py-symbol.c: Use C++ exception handling.
7712         * python/py-record.c: Use C++ exception handling.
7713         * python/py-record-btrace.c: Use C++ exception handling.
7714         * python/py-progspace.c: Use C++ exception handling.
7715         * python/py-prettyprint.c: Use C++ exception handling.
7716         * python/py-param.c: Use C++ exception handling.
7717         * python/py-objfile.c: Use C++ exception handling.
7718         * python/py-linetable.c: Use C++ exception handling.
7719         * python/py-lazy-string.c: Use C++ exception handling.
7720         * python/py-infthread.c: Use C++ exception handling.
7721         * python/py-inferior.c: Use C++ exception handling.
7722         * python/py-gdb-readline.c: Use C++ exception handling.
7723         * python/py-framefilter.c: Use C++ exception handling.
7724         * python/py-frame.c: Use C++ exception handling.
7725         * python/py-finishbreakpoint.c: Use C++ exception handling.
7726         * python/py-cmd.c: Use C++ exception handling.
7727         * python/py-breakpoint.c: Use C++ exception handling.
7728         * python/py-arch.c: Use C++ exception handling.
7729         * printcmd.c: Use C++ exception handling.
7730         * ppc-linux-tdep.c: Use C++ exception handling.
7731         * parse.c: Use C++ exception handling.
7732         * p-valprint.c: Use C++ exception handling.
7733         * objc-lang.c: Use C++ exception handling.
7734         * mi/mi-main.c: Use C++ exception handling.
7735         * mi/mi-interp.c: Use C++ exception handling.
7736         * mi/mi-cmd-stack.c: Use C++ exception handling.
7737         * mi/mi-cmd-break.c: Use C++ exception handling.
7738         * main.c: Use C++ exception handling.
7739         * linux-thread-db.c: Use C++ exception handling.
7740         * linux-tdep.c: Use C++ exception handling.
7741         * linux-nat.c: Use C++ exception handling.
7742         * linux-fork.c: Use C++ exception handling.
7743         * linespec.c: Use C++ exception handling.
7744         * language.c: Use C++ exception handling.
7745         * jit.c: Use C++ exception handling.
7746         * infrun.c: Use C++ exception handling.
7747         * infcmd.c: Use C++ exception handling.
7748         * infcall.c: Use C++ exception handling.
7749         * inf-loop.c: Use C++ exception handling.
7750         * i386-tdep.c: Use C++ exception handling.
7751         * i386-linux-tdep.c: Use C++ exception handling.
7752         * guile/scm-value.c: Use C++ exception handling.
7753         * guile/scm-type.c: Use C++ exception handling.
7754         * guile/scm-symtab.c: Use C++ exception handling.
7755         * guile/scm-symbol.c: Use C++ exception handling.
7756         * guile/scm-pretty-print.c: Use C++ exception handling.
7757         * guile/scm-ports.c: Use C++ exception handling.
7758         * guile/scm-param.c: Use C++ exception handling.
7759         * guile/scm-math.c: Use C++ exception handling.
7760         * guile/scm-lazy-string.c: Use C++ exception handling.
7761         * guile/scm-frame.c: Use C++ exception handling.
7762         * guile/scm-disasm.c: Use C++ exception handling.
7763         * guile/scm-cmd.c: Use C++ exception handling.
7764         * guile/scm-breakpoint.c: Use C++ exception handling.
7765         * guile/scm-block.c: Use C++ exception handling.
7766         * guile/guile-internal.h: Use C++ exception handling.
7767         * gnu-v3-abi.c: Use C++ exception handling.
7768         * gdbtypes.c: Use C++ exception handling.
7769         * frame.c: Use C++ exception handling.
7770         * frame-unwind.c: Use C++ exception handling.
7771         * fbsd-tdep.c: Use C++ exception handling.
7772         * f-valprint.c: Use C++ exception handling.
7773         * exec.c: Use C++ exception handling.
7774         * event-top.c: Use C++ exception handling.
7775         * event-loop.c: Use C++ exception handling.
7776         * eval.c: Use C++ exception handling.
7777         * dwarf2read.c: Use C++ exception handling.
7778         * dwarf2loc.c: Use C++ exception handling.
7779         * dwarf2-frame.c: Use C++ exception handling.
7780         * dwarf2-frame-tailcall.c: Use C++ exception handling.
7781         * dwarf-index-write.c: Use C++ exception handling.
7782         * dwarf-index-cache.c: Use C++ exception handling.
7783         * dtrace-probe.c: Use C++ exception handling.
7784         * disasm-selftests.c: Use C++ exception handling.
7785         * darwin-nat.c: Use C++ exception handling.
7786         * cp-valprint.c: Use C++ exception handling.
7787         * cp-support.c: Use C++ exception handling.
7788         * cp-abi.c: Use C++ exception handling.
7789         * corelow.c: Use C++ exception handling.
7790         * completer.c: Use C++ exception handling.
7791         * compile/compile-object-run.c: Use C++ exception handling.
7792         * compile/compile-object-load.c: Use C++ exception handling.
7793         * compile/compile-cplus-symbols.c: Use C++ exception handling.
7794         * compile/compile-c-symbols.c: Use C++ exception handling.
7795         * common/selftest.c: Use C++ exception handling.
7796         * common/new-op.c: Use C++ exception handling.
7797         * cli/cli-script.c: Use C++ exception handling.
7798         * cli/cli-interp.c: Use C++ exception handling.
7799         * cli/cli-cmds.c: Use C++ exception handling.
7800         * c-varobj.c: Use C++ exception handling.
7801         * btrace.c: Use C++ exception handling.
7802         * breakpoint.c: Use C++ exception handling.
7803         * break-catch-throw.c: Use C++ exception handling.
7804         * arch-utils.c: Use C++ exception handling.
7805         * amd64-tdep.c: Use C++ exception handling.
7806         * ada-valprint.c: Use C++ exception handling.
7807         * ada-typeprint.c: Use C++ exception handling.
7808         * ada-lang.c: Use C++ exception handling.
7809         * aarch64-tdep.c: Use C++ exception handling.
7810
7811 2019-04-08  Tom Tromey  <tom@tromey.com>
7812
7813         * xml-support.c (gdb_xml_parser::parse): Update.
7814         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7815         * value.c (show_convenience): Update.
7816         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
7817         (test_parse_flags_qcs): Update.
7818         * thread.c (thr_try_catch_cmd): Update.
7819         * target.c (target_translate_tls_address): Update.
7820         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
7821         (info_frame_command_core, frame_apply_command_count): Update.
7822         * rust-exp.y (rust_lex_exception_test): Update.
7823         * riscv-tdep.c (riscv_print_one_register_info): Update.
7824         * remote.c (remote_target::enable_btrace): Update.
7825         * record-btrace.c (record_btrace_enable_warn): Update.
7826         * python/py-utils.c (gdbpy_convert_exception): Update.
7827         * printcmd.c (do_one_display, print_variable_and_value): Update.
7828         * mi/mi-main.c (mi_print_exception): Update.
7829         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
7830         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
7831         * linux-nat.c (linux_nat_target::attach): Update.
7832         * linux-fork.c (class scoped_switch_fork_info): Update.
7833         * infrun.c (displaced_step_prepare): Update.
7834         * infcall.c (call_function_by_hand_dummy): Update.
7835         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
7836         * gnu-v3-abi.c (print_one_vtable): Update.
7837         * frame.c (get_prev_frame_always): Update.
7838         * f-valprint.c (info_common_command_for_block): Update.
7839         * exec.c (try_open_exec_file): Update.
7840         * exceptions.c (print_exception, exception_print)
7841         (exception_fprintf, exception_print_same): Update.
7842         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
7843         * dwarf-index-cache.c (index_cache::store)
7844         (index_cache::lookup_gdb_index): Update.
7845         * darwin-nat.c (maybe_cache_shell): Update.
7846         * cp-valprint.c (cp_print_value_fields): Update.
7847         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
7848         (gcc_cplus_symbol_address): Update.
7849         * compile/compile-c-symbols.c (gcc_convert_symbol)
7850         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
7851         * common/selftest.c: Update.
7852         * common/common-exceptions.h (struct gdb_exception) <message>: Now
7853         a std::string.
7854         (exception_try_scope_entry, exception_try_scope_exit): Don't
7855         declare.
7856         (struct exception_try_scope): Remove.
7857         (TRY): Don't use exception_try_scope.
7858         (struct gdb_exception): Add constructor, operator=.
7859         <what>: New method.
7860         (struct gdb_exception_RETURN_MASK_ALL)
7861         (struct gdb_exception_RETURN_MASK_ERROR)
7862         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
7863         (struct gdb_quit_bad_alloc): Update.
7864         * common/common-exceptions.c (exception_none): Change
7865         initializer.
7866         (struct catcher) <state, exception>: Initialize inline.
7867         <prev>: Remove member.
7868         (current_catcher): Remove.
7869         (catchers): New global.
7870         (exceptions_state_mc_init): Simplify.
7871         (catcher_pop): Remove.
7872         (exceptions_state_mc, exceptions_state_mc_catch): Update.
7873         (try_scope_depth, exception_try_scope_entry)
7874         (exception_try_scope_exit): Remove.
7875         (throw_exception_sjlj): Update.
7876         (exception_messages, exception_messages_size): Remove.
7877         (throw_it): Simplify.
7878         (gdb_exception_sliced_copy): Remove.
7879         (throw_exception_cxx): Update.
7880         * cli/cli-script.c (script_from_file): Update.
7881         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
7882         Update.
7883         * ada-valprint.c (ada_val_print): Update.
7884         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
7885         (create_excep_cond_exprs): Update.
7886
7887 2019-04-08  Tom Tromey  <tom@tromey.com>
7888
7889         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
7890         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
7891         (TRY, CATCH, END_CATCH): Remove some definitions.
7892         * common/common-exceptions.c: Don't use GDB_XCPT.
7893         (catcher_list_size): Remove.
7894         (throw_exception, throw_it): Simplify.
7895
7896 2019-04-05  Tom Tromey  <tom@tromey.com>
7897
7898         Revert the header-sorting patch.
7899         * ft32-tdep.c: Revert.
7900         * frv-tdep.c: Revert.
7901         * frv-linux-tdep.c: Revert.
7902         * frame.c: Revert.
7903         * frame-unwind.c: Revert.
7904         * frame-base.c: Revert.
7905         * fork-child.c: Revert.
7906         * findvar.c: Revert.
7907         * findcmd.c: Revert.
7908         * filesystem.c: Revert.
7909         * filename-seen-cache.h: Revert.
7910         * filename-seen-cache.c: Revert.
7911         * fbsd-tdep.c: Revert.
7912         * fbsd-nat.h: Revert.
7913         * fbsd-nat.c: Revert.
7914         * f-valprint.c: Revert.
7915         * f-typeprint.c: Revert.
7916         * f-lang.c: Revert.
7917         * extension.h: Revert.
7918         * extension.c: Revert.
7919         * extension-priv.h: Revert.
7920         * expprint.c: Revert.
7921         * exec.h: Revert.
7922         * exec.c: Revert.
7923         * exceptions.c: Revert.
7924         * event-top.c: Revert.
7925         * event-loop.c: Revert.
7926         * eval.c: Revert.
7927         * elfread.c: Revert.
7928         * dwarf2read.h: Revert.
7929         * dwarf2read.c: Revert.
7930         * dwarf2loc.c: Revert.
7931         * dwarf2expr.h: Revert.
7932         * dwarf2expr.c: Revert.
7933         * dwarf2-frame.c: Revert.
7934         * dwarf2-frame-tailcall.c: Revert.
7935         * dwarf-index-write.h: Revert.
7936         * dwarf-index-write.c: Revert.
7937         * dwarf-index-common.c: Revert.
7938         * dwarf-index-cache.h: Revert.
7939         * dwarf-index-cache.c: Revert.
7940         * dummy-frame.c: Revert.
7941         * dtrace-probe.c: Revert.
7942         * disasm.h: Revert.
7943         * disasm.c: Revert.
7944         * disasm-selftests.c: Revert.
7945         * dictionary.c: Revert.
7946         * dicos-tdep.c: Revert.
7947         * demangle.c: Revert.
7948         * dcache.h: Revert.
7949         * dcache.c: Revert.
7950         * darwin-nat.h: Revert.
7951         * darwin-nat.c: Revert.
7952         * darwin-nat-info.c: Revert.
7953         * d-valprint.c: Revert.
7954         * d-namespace.c: Revert.
7955         * d-lang.c: Revert.
7956         * ctf.c: Revert.
7957         * csky-tdep.c: Revert.
7958         * csky-linux-tdep.c: Revert.
7959         * cris-tdep.c: Revert.
7960         * cris-linux-tdep.c: Revert.
7961         * cp-valprint.c: Revert.
7962         * cp-support.c: Revert.
7963         * cp-namespace.c: Revert.
7964         * cp-abi.c: Revert.
7965         * corelow.c: Revert.
7966         * corefile.c: Revert.
7967         * continuations.c: Revert.
7968         * completer.h: Revert.
7969         * completer.c: Revert.
7970         * complaints.c: Revert.
7971         * coffread.c: Revert.
7972         * coff-pe-read.c: Revert.
7973         * cli-out.h: Revert.
7974         * cli-out.c: Revert.
7975         * charset.c: Revert.
7976         * c-varobj.c: Revert.
7977         * c-valprint.c: Revert.
7978         * c-typeprint.c: Revert.
7979         * c-lang.c: Revert.
7980         * buildsym.c: Revert.
7981         * buildsym-legacy.c: Revert.
7982         * build-id.h: Revert.
7983         * build-id.c: Revert.
7984         * btrace.c: Revert.
7985         * bsd-uthread.c: Revert.
7986         * breakpoint.h: Revert.
7987         * breakpoint.c: Revert.
7988         * break-catch-throw.c: Revert.
7989         * break-catch-syscall.c: Revert.
7990         * break-catch-sig.c: Revert.
7991         * blockframe.c: Revert.
7992         * block.c: Revert.
7993         * bfin-tdep.c: Revert.
7994         * bfin-linux-tdep.c: Revert.
7995         * bfd-target.c: Revert.
7996         * bcache.c: Revert.
7997         * ax-general.c: Revert.
7998         * ax-gdb.h: Revert.
7999         * ax-gdb.c: Revert.
8000         * avr-tdep.c: Revert.
8001         * auxv.c: Revert.
8002         * auto-load.c: Revert.
8003         * arm-wince-tdep.c: Revert.
8004         * arm-tdep.c: Revert.
8005         * arm-symbian-tdep.c: Revert.
8006         * arm-pikeos-tdep.c: Revert.
8007         * arm-obsd-tdep.c: Revert.
8008         * arm-nbsd-tdep.c: Revert.
8009         * arm-nbsd-nat.c: Revert.
8010         * arm-linux-tdep.c: Revert.
8011         * arm-linux-nat.c: Revert.
8012         * arm-fbsd-tdep.c: Revert.
8013         * arm-fbsd-nat.c: Revert.
8014         * arm-bsd-tdep.c: Revert.
8015         * arch-utils.c: Revert.
8016         * arc-tdep.c: Revert.
8017         * arc-newlib-tdep.c: Revert.
8018         * annotate.h: Revert.
8019         * annotate.c: Revert.
8020         * amd64-windows-tdep.c: Revert.
8021         * amd64-windows-nat.c: Revert.
8022         * amd64-tdep.c: Revert.
8023         * amd64-sol2-tdep.c: Revert.
8024         * amd64-obsd-tdep.c: Revert.
8025         * amd64-obsd-nat.c: Revert.
8026         * amd64-nbsd-tdep.c: Revert.
8027         * amd64-nbsd-nat.c: Revert.
8028         * amd64-nat.c: Revert.
8029         * amd64-linux-tdep.c: Revert.
8030         * amd64-linux-nat.c: Revert.
8031         * amd64-fbsd-tdep.c: Revert.
8032         * amd64-fbsd-nat.c: Revert.
8033         * amd64-dicos-tdep.c: Revert.
8034         * amd64-darwin-tdep.c: Revert.
8035         * amd64-bsd-nat.c: Revert.
8036         * alpha-tdep.c: Revert.
8037         * alpha-obsd-tdep.c: Revert.
8038         * alpha-nbsd-tdep.c: Revert.
8039         * alpha-mdebug-tdep.c: Revert.
8040         * alpha-linux-tdep.c: Revert.
8041         * alpha-linux-nat.c: Revert.
8042         * alpha-bsd-tdep.c: Revert.
8043         * alpha-bsd-nat.c: Revert.
8044         * aix-thread.c: Revert.
8045         * agent.c: Revert.
8046         * addrmap.c: Revert.
8047         * ada-varobj.c: Revert.
8048         * ada-valprint.c: Revert.
8049         * ada-typeprint.c: Revert.
8050         * ada-tasks.c: Revert.
8051         * ada-lang.c: Revert.
8052         * aarch64-tdep.c: Revert.
8053         * aarch64-ravenscar-thread.c: Revert.
8054         * aarch64-newlib-tdep.c: Revert.
8055         * aarch64-linux-tdep.c: Revert.
8056         * aarch64-linux-nat.c: Revert.
8057         * aarch64-fbsd-tdep.c: Revert.
8058         * aarch64-fbsd-nat.c: Revert.
8059         * aarch32-linux-nat.c: Revert.
8060
8061 2019-04-05  Tom Tromey  <tom@tromey.com>
8062
8063         * ft32-tdep.c: Sort headers.
8064         * frv-tdep.c: Sort headers.
8065         * frv-linux-tdep.c: Sort headers.
8066         * frame.c: Sort headers.
8067         * frame-unwind.c: Sort headers.
8068         * frame-base.c: Sort headers.
8069         * fork-child.c: Sort headers.
8070         * findvar.c: Sort headers.
8071         * findcmd.c: Sort headers.
8072         * filesystem.c: Sort headers.
8073         * filename-seen-cache.h: Sort headers.
8074         * filename-seen-cache.c: Sort headers.
8075         * fbsd-tdep.c: Sort headers.
8076         * fbsd-nat.h: Sort headers.
8077         * fbsd-nat.c: Sort headers.
8078         * f-valprint.c: Sort headers.
8079         * f-typeprint.c: Sort headers.
8080         * f-lang.c: Sort headers.
8081         * extension.h: Sort headers.
8082         * extension.c: Sort headers.
8083         * extension-priv.h: Sort headers.
8084         * expprint.c: Sort headers.
8085         * exec.h: Sort headers.
8086         * exec.c: Sort headers.
8087         * exceptions.c: Sort headers.
8088         * event-top.c: Sort headers.
8089         * event-loop.c: Sort headers.
8090         * eval.c: Sort headers.
8091         * elfread.c: Sort headers.
8092         * dwarf2read.h: Sort headers.
8093         * dwarf2read.c: Sort headers.
8094         * dwarf2loc.c: Sort headers.
8095         * dwarf2expr.h: Sort headers.
8096         * dwarf2expr.c: Sort headers.
8097         * dwarf2-frame.c: Sort headers.
8098         * dwarf2-frame-tailcall.c: Sort headers.
8099         * dwarf-index-write.h: Sort headers.
8100         * dwarf-index-write.c: Sort headers.
8101         * dwarf-index-common.c: Sort headers.
8102         * dwarf-index-cache.h: Sort headers.
8103         * dwarf-index-cache.c: Sort headers.
8104         * dummy-frame.c: Sort headers.
8105         * dtrace-probe.c: Sort headers.
8106         * disasm.h: Sort headers.
8107         * disasm.c: Sort headers.
8108         * disasm-selftests.c: Sort headers.
8109         * dictionary.c: Sort headers.
8110         * dicos-tdep.c: Sort headers.
8111         * demangle.c: Sort headers.
8112         * dcache.h: Sort headers.
8113         * dcache.c: Sort headers.
8114         * darwin-nat.h: Sort headers.
8115         * darwin-nat.c: Sort headers.
8116         * darwin-nat-info.c: Sort headers.
8117         * d-valprint.c: Sort headers.
8118         * d-namespace.c: Sort headers.
8119         * d-lang.c: Sort headers.
8120         * ctf.c: Sort headers.
8121         * csky-tdep.c: Sort headers.
8122         * csky-linux-tdep.c: Sort headers.
8123         * cris-tdep.c: Sort headers.
8124         * cris-linux-tdep.c: Sort headers.
8125         * cp-valprint.c: Sort headers.
8126         * cp-support.c: Sort headers.
8127         * cp-namespace.c: Sort headers.
8128         * cp-abi.c: Sort headers.
8129         * corelow.c: Sort headers.
8130         * corefile.c: Sort headers.
8131         * continuations.c: Sort headers.
8132         * completer.h: Sort headers.
8133         * completer.c: Sort headers.
8134         * complaints.c: Sort headers.
8135         * coffread.c: Sort headers.
8136         * coff-pe-read.c: Sort headers.
8137         * cli-out.h: Sort headers.
8138         * cli-out.c: Sort headers.
8139         * charset.c: Sort headers.
8140         * c-varobj.c: Sort headers.
8141         * c-valprint.c: Sort headers.
8142         * c-typeprint.c: Sort headers.
8143         * c-lang.c: Sort headers.
8144         * buildsym.c: Sort headers.
8145         * buildsym-legacy.c: Sort headers.
8146         * build-id.h: Sort headers.
8147         * build-id.c: Sort headers.
8148         * btrace.c: Sort headers.
8149         * bsd-uthread.c: Sort headers.
8150         * breakpoint.h: Sort headers.
8151         * breakpoint.c: Sort headers.
8152         * break-catch-throw.c: Sort headers.
8153         * break-catch-syscall.c: Sort headers.
8154         * break-catch-sig.c: Sort headers.
8155         * blockframe.c: Sort headers.
8156         * block.c: Sort headers.
8157         * bfin-tdep.c: Sort headers.
8158         * bfin-linux-tdep.c: Sort headers.
8159         * bfd-target.c: Sort headers.
8160         * bcache.c: Sort headers.
8161         * ax-general.c: Sort headers.
8162         * ax-gdb.h: Sort headers.
8163         * ax-gdb.c: Sort headers.
8164         * avr-tdep.c: Sort headers.
8165         * auxv.c: Sort headers.
8166         * auto-load.c: Sort headers.
8167         * arm-wince-tdep.c: Sort headers.
8168         * arm-tdep.c: Sort headers.
8169         * arm-symbian-tdep.c: Sort headers.
8170         * arm-pikeos-tdep.c: Sort headers.
8171         * arm-obsd-tdep.c: Sort headers.
8172         * arm-nbsd-tdep.c: Sort headers.
8173         * arm-nbsd-nat.c: Sort headers.
8174         * arm-linux-tdep.c: Sort headers.
8175         * arm-linux-nat.c: Sort headers.
8176         * arm-fbsd-tdep.c: Sort headers.
8177         * arm-fbsd-nat.c: Sort headers.
8178         * arm-bsd-tdep.c: Sort headers.
8179         * arch-utils.c: Sort headers.
8180         * arc-tdep.c: Sort headers.
8181         * arc-newlib-tdep.c: Sort headers.
8182         * annotate.h: Sort headers.
8183         * annotate.c: Sort headers.
8184         * amd64-windows-tdep.c: Sort headers.
8185         * amd64-windows-nat.c: Sort headers.
8186         * amd64-tdep.c: Sort headers.
8187         * amd64-sol2-tdep.c: Sort headers.
8188         * amd64-obsd-tdep.c: Sort headers.
8189         * amd64-obsd-nat.c: Sort headers.
8190         * amd64-nbsd-tdep.c: Sort headers.
8191         * amd64-nbsd-nat.c: Sort headers.
8192         * amd64-nat.c: Sort headers.
8193         * amd64-linux-tdep.c: Sort headers.
8194         * amd64-linux-nat.c: Sort headers.
8195         * amd64-fbsd-tdep.c: Sort headers.
8196         * amd64-fbsd-nat.c: Sort headers.
8197         * amd64-dicos-tdep.c: Sort headers.
8198         * amd64-darwin-tdep.c: Sort headers.
8199         * amd64-bsd-nat.c: Sort headers.
8200         * alpha-tdep.c: Sort headers.
8201         * alpha-obsd-tdep.c: Sort headers.
8202         * alpha-nbsd-tdep.c: Sort headers.
8203         * alpha-mdebug-tdep.c: Sort headers.
8204         * alpha-linux-tdep.c: Sort headers.
8205         * alpha-linux-nat.c: Sort headers.
8206         * alpha-bsd-tdep.c: Sort headers.
8207         * alpha-bsd-nat.c: Sort headers.
8208         * aix-thread.c: Sort headers.
8209         * agent.c: Sort headers.
8210         * addrmap.c: Sort headers.
8211         * ada-varobj.c: Sort headers.
8212         * ada-valprint.c: Sort headers.
8213         * ada-typeprint.c: Sort headers.
8214         * ada-tasks.c: Sort headers.
8215         * ada-lang.c: Sort headers.
8216         * aarch64-tdep.c: Sort headers.
8217         * aarch64-ravenscar-thread.c: Sort headers.
8218         * aarch64-newlib-tdep.c: Sort headers.
8219         * aarch64-linux-tdep.c: Sort headers.
8220         * aarch64-linux-nat.c: Sort headers.
8221         * aarch64-fbsd-tdep.c: Sort headers.
8222         * aarch64-fbsd-nat.c: Sort headers.
8223         * aarch32-linux-nat.c: Sort headers.
8224
8225 2019-04-04  Tom Tromey  <tom@tromey.com>
8226
8227         * varobj.c (varobj_create): Update.
8228         * rust-exp.y (struct rust_parser) <update_innermost_block,
8229         lookup_symbol>: New methods.
8230         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
8231         Rename.
8232         (rust_parser::rust_lookup_type)
8233         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8234         * printcmd.c (display_command, do_one_display): Update.
8235         * parser-defs.h (struct parser_state) <parser_state>: Add
8236         "tracker" parameter.
8237         (block_tracker): New member.
8238         (class innermost_block_tracker) <innermost_block_tracker>: Add
8239         "types" parameter.
8240         <reset>: Remove method.
8241         (innermost_block): Don't declare.
8242         (null_post_parser): Update.
8243         * parse.c (innermost_block): Remove global.
8244         (write_dollar_variable): Update.
8245         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
8246         Remove "tracker_types" parameter.
8247         (parse_expression): Add "tracker" parameter.
8248         (parse_expression_for_completion): Update.
8249         (null_post_parser): Add "tracker" parameter.
8250         * p-exp.y: Update rules.
8251         * m2-exp.y: Update rules.
8252         * language.h (struct language_defn) <la_post_parser>: Add
8253         "tracker" parameter.
8254         * go-exp.y: Update rules.
8255         * f-exp.y: Update rules.
8256         * expression.h (parse_expression, parse_exp_1): Add "tracker"
8257         parameter.
8258         * d-exp.y: Update rules.
8259         * c-exp.y: Update rules.
8260         * breakpoint.c (set_breakpoint_condition): Create an
8261         innermost_block_tracker.
8262         (watch_command_1): Likewise.
8263         * ada-lang.c (resolve): Add "tracker" parameter.
8264         (resolve_subexp): Likewise.
8265         * ada-exp.y (write_var_from_sym): Update.
8266
8267 2019-04-04  Tom Tromey  <tom@tromey.com>
8268
8269         * type-stack.h: New file.
8270         * type-stack.c: New file.
8271         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
8272         type-stack.h.
8273         (insert_into_type_stack, insert_type, push_type, push_type_int)
8274         (insert_type_address_space, pop_type, pop_type_int)
8275         (pop_typelist, pop_type_stack, append_type_stack)
8276         (push_type_stack, get_type_stack, push_typelist)
8277         (follow_type_instance_flags, follow_types): Don't declare.
8278         * parse.c (type_stack): Remove global.
8279         (parse_exp_in_context): Update.
8280         (insert_into_type_stack, insert_type, push_type, push_type_int)
8281         (insert_type_address_space, pop_type, pop_type_int)
8282         (pop_typelist, pop_type_stack, append_type_stack)
8283         (push_type_stack, get_type_stack, push_typelist)
8284         (follow_type_instance_flags, follow_types): Remove (moved to
8285         type-stack.c).
8286         * f-exp.y (type_stack): New global.
8287         Update rules.
8288         (push_kind_type, f_parse): Update.
8289         * d-exp.y (type_stack): New global.
8290         Update rules.
8291         (d_parse): Update.
8292         * c-exp.y (struct c_parse_state) <type_stack>: New member.
8293         Update rules.
8294         * Makefile.in (COMMON_SFILES): Add type-stack.c.
8295         (HFILES_NO_SRCDIR): Add type-stack.h.
8296
8297 2019-04-04  Tom Tromey  <tom@tromey.com>
8298
8299         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
8300         (rust_parser::convert_ast_to_expression, rust_parse)
8301         (rust_lex_test_completion, rust_lex_tests): Update.
8302         * parser-defs.h (struct expr_completion_state): New.
8303         (struct parser_state) <parser_state>: Add completion parameter.
8304         <mark_struct_expression, mark_completion_tag>: New methods.
8305         <parse_completion, m_completion_state>: New members.
8306         (prefixify_expression, null_post_parser): Update.
8307         (mark_struct_expression, mark_completion_tag): Don't declare.
8308         * parse.c (parse_completion, expout_last_struct)
8309         (expout_tag_completion_type, expout_completion_name): Remove
8310         globals.
8311         (parser_state::mark_struct_expression)
8312         (parser_state::mark_completion_tag): Now methods.
8313         (prefixify_expression): Add last_struct parameter.
8314         (prefixify_subexp): Likewise.
8315         (parse_exp_1): Update.
8316         (parse_exp_in_context): Add cstate parameter.  Update.
8317         (parse_expression_for_completion): Create an
8318         expr_completion_state.
8319         (null_post_parser): Add "completion" parameter.
8320         * p-exp.y: Update rules.
8321         (yylex): Update.
8322         * language.h (struct language_defn) <la_post_parser>: Add
8323         "completing" parameter.
8324         * go-exp.y: Update rules.
8325         (lex_one_token): Update.
8326         * expression.h (parse_completion): Don't declare.
8327         * d-exp.y: Update rules.
8328         (lex_one_token): Update rules.
8329         * c-exp.y: Update rules.
8330         (lex_one_token): Update.
8331         * ada-lang.c (resolve): Add "parse_completion" parameter.
8332         (resolve_subexp): Likewise.
8333         (ada_resolve_function): Likewise.
8334
8335 2019-04-04  Tom Tromey  <tom@tromey.com>
8336
8337         * parser-defs.h (struct parser_state) <start_arglist,
8338         end_arglist>: New methods.
8339         <arglist_len, m_funcall_chain>: New members.
8340         (arglist_len, start_arglist, end_arglist): Don't declare.
8341         * parse.c (arglist_len, funcall_chain): Remove global.
8342         (start_arglist, end_arglist): Remove functions.
8343         (parse_exp_in_context): Update.
8344         * p-exp.y: Update rules.
8345         * m2-exp.y: Update rules.
8346         * go-exp.y: Update rules.
8347         * f-exp.y: Update rules.
8348         * d-exp.y: Update rules.
8349         * c-exp.y: Update rules.
8350
8351 2019-04-04  Tom Tromey  <tom@tromey.com>
8352
8353         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
8354         lex_operator, push_back>: New methods.
8355         Update all rules.
8356         (rust_parser::lex_hex, lex_escape): Rename and update.
8357         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
8358         (rust_parser::lex_operator): Rename and update.
8359         (rust_parser::lex_number, rustyylex, rustyyerror)
8360         (rust_lex_test_init, rust_lex_test_sequence)
8361         (rust_lex_test_push_back, rust_lex_tests): Update.
8362         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
8363         parameter.
8364         <lexptr, prev_lexptr>: New members.
8365         (lexptr, prev_lexptr): Don't declare.
8366         * parse.c (lexptr, prev_lexptr): Remove globals.
8367         (parse_exp_in_context): Update.
8368         * p-exp.y (yylex, yyerror): Update.
8369         * m2-exp.y (parse_number, yylex, yyerror): Update.
8370         * go-exp.y (lex_one_token, yyerror): Update.
8371         * f-exp.y (match_string_literal, yylex, yyerror): Update.
8372         * d-exp.y (lex_one_token, yyerror): Update.
8373         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
8374         (lex_one_token, yyerror): Update.
8375         * ada-lex.l (YY_INPUT): Update.
8376         (rewind_to_char): Update.
8377         * ada-exp.y (yyerror): Update.
8378
8379 2019-04-04  Tom Tromey  <tom@tromey.com>
8380
8381         * rust-exp.y (rustyylex, rust_lex_tests): Update.
8382         * parser-defs.h (struct parser_state) <parser_state>: Add new
8383         parameter.
8384         <comma_terminates>: New member.
8385         (comma_terminates): Don't declare global.
8386         * parse.c (comma_terminates): Remove global.
8387         (parse_exp_in_context): Update.
8388         * p-exp.y (yylex): Update.
8389         * m2-exp.y (yylex): Update.
8390         * go-exp.y (lex_one_token): Update.
8391         * f-exp.y (yylex): Update.
8392         * d-exp.y (lex_one_token): Update.
8393         * c-exp.y (lex_one_token): Update.
8394         * ada-lex.l: Update.
8395
8396 2019-04-04  Tom Tromey  <tom@tromey.com>
8397
8398         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
8399         (rustyylex, rust_lex_test_init, rust_lex_test_one)
8400         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
8401         * parser-defs.h (paren_depth): Don't declare.
8402         * parse.c (paren_depth): Remove global.
8403         (parse_exp_in_context): Update.
8404         * p-exp.y (paren_depth): New global.
8405         (pascal_parse): Initialize it.
8406         * m2-exp.y (paren_depth): New global.
8407         (m2_parse): Initialize it.
8408         * go-exp.y (paren_depth): New global.
8409         (go_parse): Initialize it.
8410         * f-exp.y (paren_depth): New global.
8411         (f_parse): Initialize it.
8412         * d-exp.y (paren_depth): New global.
8413         (d_parse): Initialize it.
8414         * c-exp.y (paren_depth): New global.
8415         (c_parse): Initialize it.
8416         * ada-lex.l (paren_depth): New global.
8417         (lexer_init): Initialize it.
8418
8419 2019-04-04  Tom Tromey  <tom@tromey.com>
8420
8421         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
8422         (rust_parser::convert_ast_to_type)
8423         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8424         * parser-defs.h (struct parser_state) <parser_state>: Add
8425         parameters.  Initialize new members.
8426         <expression_context_block, expression_context_pc>: New members.
8427         * parse.c (expression_context_block, expression_context_pc):
8428         Remove globals.
8429         (parse_exp_in_context): Update.
8430         * p-exp.y: Update all rules.
8431         (yylex): Update.
8432         * m2-exp.y: Update all rules.
8433         (yylex): Update.
8434         * go-exp.y (yylex): Update.
8435         * f-exp.y (yylex): Update.
8436         * d-exp.y: Update all rules.
8437         (yylex): Update.
8438         * c-exp.y: Update all rules.
8439         (lex_one_token, classify_name, yylex, c_parse): Update.
8440         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
8441
8442 2019-04-04  Tom Tromey  <tom@tromey.com>
8443
8444         * gdbarch.h, gdbarch.c: Rebuild.
8445         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
8446         * stap-probe.h:
8447         (struct stap_parse_info): Replace "parser_state" with
8448         "expr_builder".
8449         * parser-defs.h (struct expr_builder): Rename from "parser_state".
8450         (parser_state): New class.
8451         * parse.c (expr_builder): Rename.
8452         (expr_builder::release): Rename.
8453         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
8454         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
8455         (write_exp_elt_longcst, write_exp_elt_floatcst)
8456         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
8457         (write_exp_string_vector, write_exp_bitstring)
8458         (write_exp_msymbol, mark_struct_expression)
8459         (write_dollar_variable)
8460         (insert_type_address_space, increase_expout_size): Replace
8461         "parser_state" with "expr_builder".
8462         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
8463         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
8464         "parser_state" with "expr_builder".
8465
8466 2019-04-04  Tom Tromey  <tom@tromey.com>
8467
8468         * rust-exp.y: Replace "parse_language" with method call.
8469         * p-exp.y:
8470         (yylex): Replace "parse_language" with method call.
8471         * m2-exp.y:
8472         (yylex): Replace "parse_language" with method call.
8473         * go-exp.y (classify_name): Replace "parse_language" with method
8474         call.
8475         * f-exp.y (yylex): Replace "parse_language" with method call.
8476         * d-exp.y (lex_one_token): Replace "parse_language" with method
8477         call.
8478         * c-exp.y:
8479         (lex_one_token, classify_name, yylex): Replace "parse_language"
8480         with method call.
8481         * ada-exp.y (find_primitive_type, type_char)
8482         (type_system_address): Replace "parse_language" with method call.
8483
8484 2019-04-04  Tom Tromey  <tom@tromey.com>
8485
8486         * rust-exp.y: Replace "parse_gdbarch" with method call.
8487         * parse.c (write_dollar_variable, insert_type_address_space):
8488         Replace "parse_gdbarch" with method call.
8489         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
8490         call.
8491         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
8492         call.
8493         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
8494         "parse_gdbarch" with method call.
8495         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
8496         with method call.
8497         * f-exp.y (parse_type, parse_f_type, yylex): Replace
8498         "parse_gdbarch" with method call.
8499         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
8500         "parse_gdbarch" with method call.
8501         * c-exp.y (parse_type, parse_number, classify_name): Replace
8502         "parse_gdbarch" with method call.
8503         * ada-lex.l: Replace "parse_gdbarch" with method call.
8504         * ada-exp.y (parse_type, find_primitive_type, type_char)
8505         (type_system_address): Replace "parse_gdbarch" with method call.
8506
8507 2019-04-04  Tom Tromey  <tom@tromey.com>
8508
8509         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
8510         * stap-probe.c (stap_parse_argument): Update.
8511         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
8512         initial_size parameter.
8513         * rust-exp.y (rust_lex_tests): Update.
8514         * parse.c (parser_state): Update.
8515         (parse_exp_in_context): Update.
8516         * parser-defs.h (struct parser_state) <parser_state>: Remove
8517         "initial_size" parameter.
8518
8519 2019-04-04  Tom Tromey  <tom@tromey.com>
8520
8521         * parser-defs.h (increase_expout_size): Don't declare.
8522         * parse.c (increase_expout_size): Now static.
8523
8524 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
8525
8526         * gnu-nat.c (gnu_nat_target::wait): Fix
8527         target_waitstatus_to_string call.
8528
8529 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8530
8531         * eval.c (evaluate_subexp_standard): Handle internal functions
8532         during Fortran function call handling.
8533
8534 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8535
8536         * NEWS: Mention new internal functions.
8537         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
8538         (read_base_type): Use dwarf2_init_complex_target_type.
8539         * value.c (creal_internal_fn): New function.
8540         (cimag_internal_fn): New function.
8541         (_initialize_values): Register new internal functions.
8542
8543 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8544
8545         * infrun.c (stop_all_threads): If debug_infrun, always
8546         trace the wait status after wait_one, using
8547         target_waitstatus_to_string and target_pid_to_str.
8548         (handle_inferior_event): Replace various trace of
8549         wait status kind by a single trace.
8550         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
8551         wait status kind image by target_waitstatus_to_string.
8552         * target/waitstatus.c (target_waitstatus_to_string): Fix
8553         obsolete comment.
8554
8555 2019-04-01  Tom Tromey  <tromey@adacore.com>
8556
8557         PR symtab/23331:
8558         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
8559
8560 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
8561             Pedro Alves  <palves@redhat.com>
8562
8563         * top.c (quit_force): Call 'finalize_values'.
8564         * value.c (finalize_values): New function.
8565         * value.h (finalize_values): Declare.
8566
8567 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
8568
8569         * NEWS: Announce $_gdb_major and $_gdb_minor.
8570
8571         * top.c (init_gdb_version_vars): New function.
8572         (gdb_init): Call init_gdb_version_vars.
8573
8574 2019-03-29  Tom Tromey  <tromey@adacore.com>
8575
8576         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
8577         help text.  Remove dead code.
8578
8579 2019-03-29  Keith Seitz  <keiths@redhat.com>
8580
8581         From Siddhesh Poyarekar:
8582         * f-lang.h (f77_get_upperbound): Return LONGEST.
8583         (f77_get_lowerbound): Likewise.
8584         * f-typeprint.c (f_type_print_varspec_suffix): Expand
8585         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
8586         print them.
8587         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
8588         plongest to format print it.
8589         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
8590         (f77_get_upperbound): Likewise.
8591         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
8592         LOWER_BOUND to LONGEST.
8593         (f77_create_arrayprint_offset_tbl): Likewise.
8594
8595 2019-03-29  Keith Seitz  <keiths@redhat.com>
8596
8597         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
8598         %s/pulongest for TYPE_LENGTH instead of %d in format
8599         strings.
8600         * ada-typerint.c (ada_print_type): Likewise.
8601         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
8602         * compile/compile-c-support.c (generate_register_struct): Likewise.
8603         * gdbtypes.c (recursive_dump_type): Likewise.
8604         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
8605         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
8606         instead of %d in format strings.
8607         * riscv-tdep.c (riscv_type_alignment): Cast second argument
8608         to std::min to ULONGEST.
8609         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
8610         instead of %d in format strings.
8611         * tracepoint.c (info_scope_command): Likewise.
8612         * typeprint.c (print_offset_data::update)
8613         (print_offset_data::finish): Likewise.
8614         * xtensa-tdep.c (xtensa_store_return_value)
8615         (xtensa_push_dummy_call): Likewise.
8616
8617 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
8618
8619         * windows-nat.c (display_selector): Fixed format specifications
8620         for 64-bit Cygwin.
8621
8622 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8623
8624         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
8625
8626 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
8627
8628         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
8629         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
8630         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
8631         (nios2_linux_init_abi): Install it.
8632
8633 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8634
8635         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
8636
8637 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8638
8639         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
8640
8641 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8642             Tom Tromey  <tromey@adacore.com>
8643
8644         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
8645
8646 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
8647
8648         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
8649         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
8650         method to compute the bounds of range types. Also print "[evaluated]"
8651         if the bounds' values come from a dynamic evaluation.
8652
8653 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8654
8655         * cp-valprint.c (cp_print_value_fields): Don't print trailing
8656         whitespace when pretty printing is on.
8657
8658 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8659
8660         * ppc-linux-nat.c: Add include.
8661
8662 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8663
8664         * NEWS: Mention AArch64 Pointer Authentication.
8665
8666 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8667
8668         * arm-linux-nat.c: Add include.
8669
8670 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
8671
8672         * source-cache.c (source_cache::get_source_lines): Re-read
8673         fullname after calling open_source_file.
8674
8675 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
8676
8677         * NEWS: Mention TLS support for FreeBSD.
8678
8679 2019-03-25  Tom Tromey  <tromey@adacore.com>
8680
8681         * minsyms.c (BUNCH_SIZE): Update comment.
8682         (~minimal_symbol_reader): Remove old comment.
8683         (compact_minimal_symbols): Update comment.
8684         (minimal_symbol_reader::install): Remove old comment.  Update
8685         other comments.
8686
8687 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8688
8689         * s390-linux-nat.c: Add include.
8690
8691 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8692
8693         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
8694         Call linux_get_hwcap.
8695         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
8696         Likewise.
8697         (aarch64_linux_get_hwcap): Remove function.
8698         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
8699         declaration.
8700         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
8701         linux_get_hwcap.
8702         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
8703         * linux-tdep.c (linux_get_hwcap): Add function.
8704         (linux_get_hwcap2): Likewise.
8705         * linux-tdep.h (linux_get_hwcap): Add declaration.
8706         (linux_get_hwcap2): Likewise.
8707         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
8708         (ppc_linux_get_hwcap2): Likewise.
8709         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
8710         linux_get_hwcap.
8711         (ppc_linux_nat_target::insert_watchpoint): Likewise.
8712         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
8713         (ppc_linux_nat_target::read_description): Likewise.
8714         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
8715         * s390-linux-nat.c: Likewise.
8716         * s390-linux-tdep.c (s390_core_read_description): Likewise.
8717
8718 2019-03-24  Tom Tromey  <tom@tromey.com>
8719
8720         * ada-lang.c (standard_lookup): Simplify initialization.
8721         (ada_lookup_symbol_nonlocal): Simplify return.
8722         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
8723         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
8724         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
8725         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
8726         initialization.
8727         * solib.c (solib_global_lookup): Simplify.
8728         * symtab.c (null_block_symbol): Remove.
8729         (symbol_cache_lookup): Simplify returns.
8730         (lookup_language_this): Simplify returns.
8731         (lookup_symbol_aux): Simplify return.
8732         (lookup_local_symbol): Simplify returns.
8733         (lookup_global_symbol_from_objfile): Simplify return.
8734         (lookup_symbol_in_objfile_symtabs)
8735         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
8736         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
8737         (lookup_static_symbol, lookup_global_symbol): Simplify return.
8738         * cp-namespace.c (cp_lookup_bare_symbol)
8739         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
8740         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
8741         (cp_lookup_nested_symbol): Don't use null_block_symbol.
8742         (cp_lookup_symbol_via_imports): Simplify initialization.
8743         (find_symbol_in_baseclass): Likewise.
8744         * symtab.h (null_block_symbol): Remove.
8745         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
8746         (d_lookup_nested_symbol, d_lookup_symbol_imports)
8747         (d_lookup_symbol_module): Likewise.
8748         (find_symbol_in_baseclass): Simplify initialization.
8749
8750 2019-03-24  Tom Tromey  <tom@tromey.com>
8751
8752         * expression.h: Don't include symtab.h.
8753         (struct block): Forward declare.
8754
8755 2019-03-24  Tom Tromey  <tom@tromey.com>
8756
8757         * c-exp.y (typebase): Remove casts.
8758         * gdbtypes.c (lookup_unsigned_typename, )
8759         (lookup_signed_typename): Remove cast.
8760         * eval.c (parse_to_comma_and_eval): Remove cast.
8761         * parse.c (write_dollar_variable): Remove cast.
8762         * block.h (struct block) <superblock>: Now const.
8763         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
8764         * psymtab.c (psym_map_matching_symbols): Make "block" const.
8765         (map_block): Make "block" const.
8766         * symfile.h (struct quick_symbol_functions)
8767         <map_matching_symbols>: Constify block argument to "callback".
8768         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
8769         const.
8770         (find_pc_sect_compunit_symtab): Make "b" const.
8771         (find_symbol_at_address): Likewise.
8772         (search_symbols): Likewise.
8773         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
8774         (dw2_debug_names_lookup_symbol): Likewise.
8775         (dw2_map_matching_symbols): Update.
8776         * p-valprint.c (pascal_val_print): Remove "block".
8777         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
8778         (aux_add_nonlocal_symbols): Make "block" const.
8779         (resolve_subexp): Remove cast.
8780         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
8781         const.
8782         (iterate_over_file_blocks): Likewise.
8783         * f-exp.y (%union) <bval>: Remove.
8784         * coffread.c (patch_opaque_types): Make "b" const.
8785         * spu-tdep.c (spu_catch_start): Make "block" const.
8786         * c-valprint.c (print_unpacked_pointer): Remove "block".
8787         * symmisc.c (dump_symtab_1): Make "b" const.
8788         (block_depth): Make "block" const.
8789         * d-exp.y (%union) <bval>: Remove.
8790         * cp-support.h (cp_lookup_rtti_type): Update.
8791         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
8792         * psymtab.c (psym_lookup_symbol): Make "block" const.
8793         (maintenance_check_psymtabs): Make "b" const.
8794         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
8795         (enumerate_locals, enumerate_args): Update.
8796         * python/py-symtab.c (stpy_global_block): Make "block" const.
8797         (stpy_static_block): Likewise.
8798         * inline-frame.c (block_starting_point_at): Make "new_block"
8799         const.
8800         * block.c (find_block_in_blockvector): Make return type const.
8801         (blockvector_for_pc_sect): Make "b" const.
8802         (find_block_in_blockvector): Make "b" const.
8803
8804 2019-03-23  Tom Tromey  <tom@tromey.com>
8805
8806         * varobj.c (varobj_create): Update.
8807         * symfile.c (clear_symtab_users): Don't reset innermost_block.
8808         * printcmd.c (display_command, do_one_display): Don't reset
8809         innermost_block.
8810         * parser-defs.h (enum innermost_block_tracker_type): Move to
8811         expression.h.
8812         (innermost_block): Update comment.
8813         * parse.c (parse_exp_1): Add tracker_types parameter.
8814         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
8815         tracker_types parameter.  Reset innermost_block.
8816         (parse_exp_in_context): Remove.
8817         (parse_expression_for_completion): Update.
8818         * objfiles.c (~objfile): Don't reset expression_context_block or
8819         innermost_block.
8820         * expression.h (enum innermost_block_tracker_type): Move from
8821         parser-defs.h.
8822         (parse_exp_1): Add tracker_types parameter.
8823         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
8824         reset innermost_block.
8825
8826 2019-03-23  Tom Tromey  <tom@tromey.com>
8827
8828         * objfiles.h: Include bcache.h.
8829
8830 2019-03-23  Tom Tromey  <tom@tromey.com>
8831
8832         * linespec.c (get_current_search_block): Use
8833         scoped_restore_current_language.
8834         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
8835
8836 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8837             Jiong Wang  <jiong.wang@arm.com>
8838
8839         * aarch64-linux-tdep.c
8840         (aarch64_linux_iterate_over_regset_sections): Check for pauth
8841         section.
8842         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
8843
8844 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8845             Jiong Wang  <jiong.wang@arm.com>
8846
8847         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
8848         instructions.
8849         (aarch64_analyze_prologue_test): Add PACIASP test.
8850         (aarch64_prologue_prev_register): Unmask PC value.
8851
8852 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8853             Jiong Wang  <jiong.wang@arm.com>
8854
8855         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
8856         (aarch64_dwarf2_prev_register): Unmask PC value.
8857         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
8858         (aarch64_execute_dwarf_cfa_vendor_op): Check for
8859         DW_CFA_AARCH64_negate_ra_state.
8860         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
8861
8862 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8863             Jiong Wang  <jiong.wang@arm.com>
8864
8865         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
8866         registers.
8867         (aarch64_pseudo_register_name): Likewise.
8868         (aarch64_pseudo_register_type): Likewise.
8869         (aarch64_pseudo_register_reggroup_p): Likewise.
8870         (aarch64_gdbarch_init): Add pauth registers.
8871         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
8872         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
8873         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
8874         (struct gdbarch_tdep): Add regnum for ra_state.
8875
8876 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8877             Jiong Wang  <jiong.wang@arm.com>
8878
8879         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
8880
8881 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8882             Jiong Wang  <jiong.wang@arm.com>
8883
8884         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
8885         function.
8886         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
8887         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
8888         (aarch64_gdbarch_init): Add puth registers.
8889         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
8890         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
8891         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
8892
8893 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8894             Jiong Wang  <jiong.wang@arm.com>
8895
8896         * aarch64-linux-nat.c
8897         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
8898         * aarch64-linux-tdep.c
8899         (aarch64_linux_core_read_description): Likewise.
8900         (aarch64_linux_get_hwcap): New function.
8901         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
8902         (aarch64_linux_get_hwcap): New declaration.
8903
8904 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8905             Jiong Wang  <jiong.wang@arm.com>
8906
8907         * aarch64-linux-nat.c
8908         (aarch64_linux_nat_target::read_description): Add pauth param.
8909         * aarch64-linux-tdep.c
8910         (aarch64_linux_core_read_description): Likewise.
8911         * aarch64-tdep.c (struct target_desc): Add in pauth.
8912         (aarch64_read_description): Add pauth param.
8913         (aarch64_gdbarch_init): Likewise.
8914         * aarch64-tdep.h (aarch64_read_description): Likewise.
8915         * arch/aarch64.c (aarch64_create_target_description): Likewise.
8916         * arch/aarch64.h (aarch64_create_target_description): Likewise.
8917         * features/Makefile: Add new files.
8918         * features/aarch64-pauth.c: New file.
8919         * features/aarch64-pauth.xml: New file.
8920
8921 2019-03-20  Tom Tromey  <tromey@adacore.com>
8922
8923         * infrun.c (handle_inferior_event): Rename from
8924         handle_inferior_event_1.  Create a scoped_value_mark.
8925         (handle_inferior_event): Remove.
8926
8927 2019-03-19  Tom Tromey  <tromey@adacore.com>
8928
8929         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
8930         * infrun.h (print_stop_event): Add "displays" parameter.
8931         * infrun.c (print_stop_event): Add "displays" parameter.
8932
8933 2019-03-19  Pedro Alves  <palves@redhat.com>
8934
8935         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8936         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
8937         to -1.  Fix TABs vs spaces.
8938         (tui_ui_out::tui_ui_out): Don't initialize fields here.
8939         * tui/tui-out.h (tui_ui_out) Add intro comments.
8940         <m_line, m_start_of_line>: In-class initialize, and add describing
8941         comment.
8942
8943 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
8944
8945         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8946         variable names.
8947         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8948
8949 2019-03-18  Pedro Alves  <palves@redhat.com>
8950             Eli Zaretskii <eliz@gnu.org>
8951
8952         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8953         m_line and m_start_of_line.
8954
8955 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
8956
8957         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8958         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8959         it returns a newline.  This fixes a regression in TU mode, whereby
8960         the next line is output on the same screen line as the user input.
8961
8962 2019-03-18  Tom Tromey  <tromey@adacore.com>
8963
8964         * minsyms.c (minimal_symbol_reader::install): Remove call to
8965         obstack_blank.
8966
8967 2019-03-18  Pedro Alves  <palves@redhat.com>
8968
8969         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8970         New globals.
8971         (apply_style): New, factored out from ...
8972         (apply_ansi_escape): ... this.  Handle reverse video mode.
8973         (tui_set_reverse_mode): New function.
8974         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8975         * tui/tui-winsource.c (tui_show_source_line): Use
8976         tui_set_reverse_mode instead of setting A_STANDOUT.
8977         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8978         New setter methods.
8979
8980 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
8981
8982         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8983         Handle tabs.
8984
8985 2019-03-18  Tom Tromey  <tromey@adacore.com>
8986
8987         * ada-lang.c (empty_array): Add "high" parameter.
8988         (ada_evaluate_subexp): Update.
8989
8990 2019-03-17  Sergei Trofimovich <siarheit@google.com>
8991
8992         * unittests/string_view-selftests.c: Define
8993         _initialize_string_view_selftests unconditionally.
8994
8995 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8996
8997         PR gdb/24350
8998         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8999
9000 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9001
9002         PR gdb/24351
9003         * windows-nat.c (display_selector): Fix format specifiers.
9004
9005 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
9006
9007         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
9008         tui_refill_source_window instead of tui_refresh_win, to update the
9009         current execution line.  This fixes redisplay of the current line
9010         when stepping through the code with "next" or "step".
9011
9012 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9013
9014         * source-cache.c (source_cache::get_source_lines): Call
9015         find_source_lines to initialize s->nlines.  This fixes vertical
9016         scrolling of TUI source window when the DOWN arrow is pressed.
9017
9018 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9019
9020         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
9021         linux-thread-db.c (_initialize_thread_db): Likewise.
9022
9023 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9024
9025         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
9026         wclrtoeol in tui_show_source_line".  This reverts changes made in
9027         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
9028
9029 2019-03-15  Tom Tromey  <tom@tromey.com>
9030
9031         * symtab.h (struct minimal_symbol): Derive from
9032         general_symbol_info.
9033         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
9034         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
9035         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
9036         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
9037         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
9038         (MSYMBOL_SEARCH_NAME): Update.
9039         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
9040         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
9041         * minsyms.c (minimal_symbol_reader::record_full): Update.
9042
9043 2019-03-15  Tom Tromey  <tom@tromey.com>
9044
9045         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
9046
9047 2019-03-15  Tom Tromey  <tom@tromey.com>
9048
9049         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
9050         unique_xmalloc_ptr.
9051         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
9052         Update.
9053         * minsyms.c (lookup_minimal_symbol_by_pc_section)
9054         (build_minimal_symbol_hash_tables)
9055         (minimal_symbol_reader::install): Update.
9056
9057 2019-03-15  Tom Tromey  <tom@tromey.com>
9058
9059         * symtab.c (create_demangled_names_hash): Update.
9060         (symbol_set_names): Update.
9061         * objfiles.h (struct objfile_per_bfd_storage)
9062         <demangled_names_hash>: Now an htab_up.
9063         * objfiles.c (objfile_per_bfd_storage): Simplify.
9064
9065 2019-03-15  Tom Tromey  <tom@tromey.com>
9066
9067         * objfiles.h (struct objfile_per_bfd_storage): Declare
9068         destructor.
9069         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
9070         New.
9071         (get_objfile_bfd_data): Use new.  Don't initialize
9072         language_of_main.
9073         (free_objfile_per_bfd_storage): Remove.
9074         (objfile_bfd_data_free, objfile::~objfile): Use delete.
9075
9076 2019-03-15  Tom Tromey  <tom@tromey.com>
9077
9078         * symfile.c (reread_symbols): Update.
9079         * objfiles.c (objfile::objfile): Update.
9080         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
9081         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
9082         comment.
9083         (minimal_symbol_reader::install): Update.
9084         (terminate_minimal_symbol_table): Remove.
9085         * jit.c (jit_object_close_impl): Update.
9086
9087 2019-03-15  Tom Tromey  <tom@tromey.com>
9088
9089         * minsyms.c (minimal_symbol_reader::record_full): Remove some
9090         initializations.
9091
9092 2019-03-15  Tom Tromey  <tom@tromey.com>
9093
9094         * objfiles.h (struct objfile_per_bfd_storage)
9095         <demangled_hash_languages>: Now a bitset.
9096         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
9097         (lookup_minimal_symbol): Update.
9098
9099 2019-03-15  Tom Tromey  <tom@tromey.com>
9100
9101         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
9102         Don't return the symbol.
9103         * coffread.c (record_minimal_symbol): Use record_full.
9104
9105 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
9106
9107         The MS-Windows port of ncurses fails to switch to a color pair if
9108         one or both of the colors are the implicit default colors.  This
9109         change records the default colors when TUI is initialized, and
9110         then specifies them explicitly when a color pair uses the default
9111         colors.  This allows color styling in TUI mode on MS-Windows.
9112
9113         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
9114         ncurses_norm_attr.
9115         (tui_initialize_io) [__MINGW32__]: Record the default terminal
9116         colors in ncurses_norm_attr.
9117         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
9118         "none", replace it with the default color recorded in
9119         ncurses_norm_attr.
9120
9121 2019-03-14  Tom Tromey  <tromey@adacore.com>
9122
9123         * source-cache.h (class source_cache) <get_source_lines>: Return
9124         std::string.
9125         * source-cache.c (source_cache::extract_lines): Handle case where
9126         first_pos==npos.  Return std::string.
9127         (source_cache::get_source_lines): Update.
9128
9129 2019-03-14  Tom Tromey  <tromey@adacore.com>
9130
9131         * NEWS: Add item for "style sources" commands.
9132         * source-cache.c (source_cache::get_source_lines): Check
9133         source_styling.
9134         * cli/cli-style.c (source_styling): New global.
9135         (_initialize_cli_style): Add "style sources" commands.
9136         (show_style_sources): New function.
9137         * cli/cli-style.h (source_styling): Declare.
9138
9139 2019-03-14  Pedro Alves  <palves@redhat.com>
9140             Tom Tromey  <tromey@adacore.com>
9141
9142         * tui/tui-winsource.h (tui_refill_source_window): Declare.
9143         * tui/tui-winsource.c (tui_refill_source_window): New function,
9144         from...
9145         (tui_horizontal_source_scroll): ... here.  Move some logic.
9146         * cli/cli-style.c (set_style_enabled): Notify new observable.
9147         * tui/tui-hooks.c (tui_redisplay_source): New function.
9148         (tui_attach_detach_observers): Attach or detach
9149         tui_redisplay_source.
9150         * observable.h (source_styling_changed): New observable.
9151         * observable.c: Define source_styling_changed observable.
9152
9153 2019-03-13  Tom Tromey  <tromey@adacore.com>
9154
9155         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
9156         (i386_gnu_nat_target::store_registers): Update.
9157         * target-debug.h (target_debug_print_std_string): New macro.
9158         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9159         * windows-tdep.c (display_one_tib): Update.
9160         * tui/tui-stack.c (tui_make_status_line): Update.
9161         * top.c (print_inferior_quit_action): Update.
9162         * thread.c (thr_try_catch_cmd): Update.
9163         (add_thread_with_info): Update.
9164         (thread_target_id_str): Update.
9165         (thr_try_catch_cmd): Update.
9166         (thread_command): Update.
9167         (thread_find_command): Update.
9168         * record-btrace.c (record_btrace_target::info_record)
9169         (record_btrace_resume_thread, record_btrace_target::resume)
9170         (record_btrace_cancel_resume, record_btrace_step_thread)
9171         (record_btrace_target::wait, record_btrace_target::wait)
9172         (record_btrace_target::wait, record_btrace_target::stop): Update.
9173         * progspace.c (print_program_space): Update.
9174         * process-stratum-target.c
9175         (process_stratum_target::thread_address_space): Update.
9176         * linux-fork.c (linux_fork_mourn_inferior)
9177         (detach_checkpoint_command, info_checkpoints_command)
9178         (linux_fork_context): Update.
9179         (linux_fork_detach): Update.
9180         (class scoped_switch_fork_info): Update.
9181         (delete_checkpoint_command): Update.
9182         * infrun.c (follow_fork_inferior): Update.
9183         (follow_fork_inferior): Update.
9184         (proceed_after_vfork_done): Update.
9185         (handle_vfork_child_exec_or_exit): Update.
9186         (follow_exec): Update.
9187         (displaced_step_prepare_throw): Update.
9188         (displaced_step_restore): Update.
9189         (start_step_over): Update.
9190         (resume_1): Update.
9191         (clear_proceed_status_thread): Update.
9192         (proceed): Update.
9193         (print_target_wait_results): Update.
9194         (do_target_wait): Update.
9195         (context_switch): Update.
9196         (stop_all_threads): Update.
9197         (restart_threads): Update.
9198         (finish_step_over): Update.
9199         (handle_signal_stop): Update.
9200         (switch_back_to_stepped_thread): Update.
9201         (keep_going_pass_signal): Update.
9202         (print_exited_reason): Update.
9203         (normal_stop): Update.
9204         * inferior.c (inferior_pid_to_str): Change return type.
9205         (print_selected_inferior): Update.
9206         (add_inferior): Update.
9207         (detach_inferior): Update.
9208         * dummy-frame.c (fprint_dummy_frames): Update.
9209         * dcache.c (dcache_info_1): Update.
9210         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
9211         (btrace_fetch, btrace_clear): Update.
9212         * linux-tdep.c (linux_core_pid_to_str): Change return type.
9213         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
9214         type.
9215         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
9216         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
9217         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
9218         * gdbarch.c, gdbarch.h: Rebuild.
9219         * gdbarch.sh (core_pid_to_str): Change return type.
9220         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
9221         return type.
9222         (windows_nat_target::pid_to_str): Change return type.
9223         (windows_delete_thread): Update.
9224         (windows_nat_target::attach): Update.
9225         (windows_nat_target::files_info): Update.
9226         * target-delegates.c: Rebuild.
9227         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
9228         return type.
9229         (sol_thread_target::pid_to_str): Change return type.
9230         * remote.c (class remote_target) <pid_to_str>: Change return
9231         type.
9232         (remote_target::pid_to_str): Change return type.
9233         (extended_remote_target::attach, remote_target::remote_stop_ns)
9234         (remote_target::remote_notif_remove_queued_reply)
9235         (remote_target::push_stop_reply, remote_target::disable_btrace):
9236         Update.
9237         (extended_remote_target::attach): Update.
9238         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
9239         type.
9240         (gdbsim_target::pid_to_str): Change return type.
9241         * ravenscar-thread.c (struct ravenscar_thread_target)
9242         <pid_to_str>: Change return type.
9243         (ravenscar_thread_target::pid_to_str): Change return type.
9244         * procfs.c (class procfs_target) <pid_to_str>: Change return
9245         type.
9246         (procfs_target::pid_to_str): Change return type.
9247         (procfs_target::attach): Update.
9248         (procfs_target::detach): Update.
9249         (procfs_target::fetch_registers): Update.
9250         (procfs_target::store_registers): Update.
9251         (procfs_target::wait): Update.
9252         (procfs_target::files_info): Update.
9253         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
9254         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
9255         return type.
9256         (nto_procfs_target::pid_to_str): Change return type.
9257         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
9258         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
9259         return type.
9260         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
9261         (exit_lwp): Update.
9262         (attach_proc_task_lwp_callback, get_detach_signal)
9263         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
9264         (linux_nat_target::resume, wait_lwp, stop_callback)
9265         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
9266         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
9267         (linux_nat_wait_1, resume_stopped_resumed_lwps)
9268         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
9269         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
9270         type.
9271         (inf_ptrace_target::attach): Update.
9272         (inf_ptrace_target::files_info): Update.
9273         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
9274         type.
9275         (go32_nat_target::pid_to_str): Change return type.
9276         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
9277         (gnu_nat_target::wait): Update.
9278         (gnu_nat_target::wait): Update.
9279         (gnu_nat_target::resume): Update.
9280         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
9281         (fbsd_nat_target::wait): Update.
9282         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
9283         type.
9284         (darwin_nat_target::attach): Update.
9285         * corelow.c (class core_target) <pid_to_str>: Change return type.
9286         (core_target::pid_to_str): Change return type.
9287         * target.c (normal_pid_to_str): Change return type.
9288         (default_pid_to_str): Likewise.
9289         (target_pid_to_str): Change return type.
9290         (target_translate_tls_address): Update.
9291         (target_announce_detach): Update.
9292         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
9293         return type.
9294         (bsd_uthread_target::pid_to_str): Change return type.
9295         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
9296         type.
9297         (bsd_kvm_target::pid_to_str): Change return type.
9298         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
9299         return type.
9300         (aix_thread_target::pid_to_str): Change return type.
9301         * target.h (struct target_ops) <pid_to_str>: Change return type.
9302         (target_pid_to_str, normal_pid_to_str): Likewise.
9303         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
9304         type.
9305         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
9306         type.
9307         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
9308         return type.
9309         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
9310         type.
9311         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
9312         type.
9313         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
9314         return type.
9315
9316 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
9317
9318         * NEWS: Mention that the new default MI version is 3.  Mention
9319         changes to the output of commands and events that deal with
9320         multi-location breakpoints.
9321         * breakpoint.c: Include "mi/mi-out.h".
9322         (print_one_breakpoint): Change output syntax if using MI version
9323         >= 3.
9324         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
9325         New.
9326         (mi_multi_location_breakpoint_output_fixed): New.
9327         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
9328         (mi_cmd_fix_multi_location_breakpoint_output): New.
9329         (mi_multi_location_breakpoint_output_fixed): New.
9330         * mi/mi-cmds.c (mi_cmds): Register command
9331         -fix-multi-location-breakpoint-output.
9332         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
9333         interpreter "mi".
9334
9335 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
9336
9337         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
9338         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
9339         instantiate mi_ui_out based on interpreter name.
9340         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
9341         * mi/mi-main.c (mi_load_progress): Likewise.
9342
9343 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9344
9345         * NEWS: Combine separate "New targets" sections for 8.3.
9346
9347 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9348
9349         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
9350         (ppcfbsd_init_abi): Install gdbarch
9351         "fetch_tls_load_module_address" and "get_thread_local_address"
9352         methods.
9353
9354 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9355
9356         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
9357         (riscv_fbsd_init_abi): Install gdbarch
9358         "fetch_tls_load_module_address" and "get_thread_local_address"
9359         methods.
9360
9361 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9362
9363         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
9364         (i386fbsd_init_abi): Install gdbarch
9365         "fetch_tls_load_module_address" and "get_thread_local_address"
9366         methods.
9367
9368 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9369
9370         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
9371         (amd64fbsd_init_abi): Install gdbarch
9372         "fetch_tls_load_module_address" and "get_thread_local_address"
9373         methods.
9374
9375 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9376
9377         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
9378         (struct fbsd_pspace_data): New type.
9379         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
9380         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
9381         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
9382         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
9383         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
9384
9385 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9386
9387         * gdbtypes.c (lookup_struct_elt): New function.
9388         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
9389         * gdbtypes.h (struct struct_elt): New type.
9390         (lookup_struct_elt): New prototype.
9391
9392 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9393
9394         * gdbtypes.c (lookup_struct_elt_type): Update comment and
9395         remove disabled code block.
9396
9397 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9398
9399         * gdbarch.sh (get_thread_local_address): New method.
9400         * gdbarch.h, gdbarch.c: Regenerate.
9401         * target.c (target_translate_tls_address): Use
9402         gdbarch_get_thread_local_address if present instead of
9403         target::get_thread_local_address.
9404
9405 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9406
9407         * target.h (target::get_thread_local_address): Update comment.
9408
9409 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9410
9411         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
9412         objfile->separate_debug_objfile_backlink if not NULL.
9413
9414 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9415
9416         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
9417         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
9418         (amd64bsd_store_inferior_registers): Likewise.
9419         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9420         Enable segment base registers.
9421         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
9422         PT_GETFSBASE and PT_GETGSBASE.
9423         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
9424         PT_SETGSBASE.
9425         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
9426         segment base registers.
9427         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9428
9429 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9430
9431         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9432         Update calls to i386_target_description to add 'segments'
9433         parameter.
9434         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
9435         add segment base registers.
9436         * arch/i386.c (i386_create_target_description): Add 'segments'
9437         parameter to enable segment base registers.
9438         * arch/i386.h (i386_create_target_description): Likewise.
9439         * features/i386/32bit-segments.xml: New file.
9440         * features/i386/32bit-segments.c: Generate.
9441         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
9442         call to i386_target_description to add 'segments' parameter.
9443         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9444         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
9445         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
9446         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
9447         if feature is present.
9448         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
9449         Add 'segments' parameter to call to i386_target_description.
9450         (i386_target_description): Add 'segments' parameter to enable
9451         segment base registers.
9452         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
9453         to call to i386_target_description.
9454         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
9455         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
9456         Define I386_NUM_REGS.
9457         (i386_target_description): Add 'segments' parameter to enable
9458         segment base registers.
9459
9460 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
9461
9462         PR/24325
9463         * source-cache.c: #undef open and close, to avoid unresolved
9464         externals during linking.
9465
9466 2019-03-12  Tom Tromey  <tromey@adacore.com>
9467
9468         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
9469         const.  Add initializers.
9470         (_initialize_remote): Don't initialize ptid globals.
9471
9472 2019-03-12  Pedro Alves  <palves@redhat.com>
9473
9474         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
9475
9476 2019-03-12  Pedro Alves  <palves@redhat.com>
9477
9478         * cp-name-parser.y (main): Remove unused 'len' variable.
9479
9480 2019-03-12  Tom Tromey  <tromey@adacore.com>
9481
9482         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
9483         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
9484
9485 2019-03-12  Tom Tromey  <tromey@adacore.com>
9486
9487         * linux-nat.c (iterate_over_lwps): Update.
9488         (stop_callback): Remove parameter.
9489         (stop_wait_callback, detach_callback, resume_set_callback)
9490         (select_singlestep_lwp_callback, set_ignore_sigint)
9491         (status_callback, resumed_callback, resume_clear_callback)
9492         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
9493         data parameter.
9494         (linux_nat_target::detach, linux_nat_target::resume)
9495         (linux_stop_and_wait_all_lwps, select_event_lwp)
9496         (linux_nat_filter_event, linux_nat_wait_1)
9497         (linux_nat_target::kill, linux_nat_target::stop)
9498         (linux_nat_target::stop): Update.
9499         (linux_nat_resume_callback): Change type.
9500         (resume_stopped_resumed_lwps, count_events_callback)
9501         (select_event_lwp_callback): Likewise.
9502         (linux_stop_lwp, linux_nat_stop_lwp): Update.
9503         * arm-linux-nat.c (struct update_registers_data): Remove.
9504         (update_registers_callback): Change type.
9505         (arm_linux_insert_hw_breakpoint1): Update.
9506         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
9507         parameter.
9508         (x86_linux_dr_set_addr): Update.
9509         (x86_linux_dr_set_control): Update.
9510         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
9511         (iterate_over_lwps): Use gdb::function_view.
9512         * nat/aarch64-linux-hw-point.c (struct
9513         aarch64_dr_update_callback_param): Remove.
9514         (debug_reg_change_callback): Change type.
9515         (aarch64_notify_debug_reg_change): Update.
9516         * s390-linux-nat.c (s390_refresh_per_info): Update.
9517
9518 2019-03-11  Tom Tromey  <tromey@adacore.com>
9519
9520         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
9521         redundant assignment to "this_cu".
9522
9523 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9524
9525         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
9526
9527 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9528
9529         * gdbtypes.c (rank_one_type_parm_set): New function extracted
9530         from...
9531         (rank_one_type): ... this.
9532
9533 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9534
9535         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
9536         from...
9537         (rank_one_type): ... this.
9538
9539 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9540
9541         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
9542         from...
9543         (rank_one_type): ... this.
9544
9545 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9546
9547         * gdbtypes.c (rank_one_type_parm_float): New function extracted
9548         from...
9549         (rank_one_type): ... this.
9550
9551 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9552
9553         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
9554         from...
9555         (rank_one_type): ... this.
9556
9557 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9558
9559         * gdbtypes.c (rank_one_type_parm_range): New function extracted
9560         from...
9561         (rank_one_type): ... this.
9562
9563 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9564
9565         * gdbtypes.c (rank_one_type_parm_char): New function extracted
9566         from...
9567         (rank_one_type): ... this.
9568
9569 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9570
9571         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
9572         from...
9573         (rank_one_type): ... this.
9574
9575 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9576
9577         * gdbtypes.c (rank_one_type_parm_int): New function extracted
9578         from...
9579         (rank_one_type): ... this.
9580
9581 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9582
9583         * gdbtypes.c (rank_one_type_parm_func): New function extracted
9584         from...
9585         (rank_one_type): ... this.
9586
9587 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9588
9589         * gdbtypes.c (rank_one_type_parm_array): New function extracted
9590         from...
9591         (rank_one_type): ... this.
9592
9593 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9594
9595         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
9596         from...
9597         (rank_one_type): ... this.
9598
9599 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9600
9601         * inferior.c (initialize_inferiors): Ensure 'help set/show print
9602         inferior-events' shows the example events.
9603
9604 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
9605
9606         Support styling on native MS-Windows console
9607
9608         PR/24315
9609         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
9610         on MS-Windows if $TERM is not defined.
9611
9612         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
9613
9614         * posix-hdep.c (gdb_console_fputs):
9615         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
9616         functions.
9617         * ui-file.h (gdb_console_fputs): Add prototype.
9618
9619         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
9620         back to fputs only if the former returns zero.
9621
9622 2019-03-07  Tom Tromey  <tom@tromey.com>
9623
9624         * symmisc.c (print_symbol_bcache_statistics): Update.
9625         (print_objfile_statistics): Update.
9626         * symfile.c (allocate_symtab): Update.
9627         * stabsread.c: Don't include bcache.h.
9628         * psymtab.h (struct psymbol_bcache): Don't declare.
9629         (class psymtab_storage) <psymbol_cache>: Now a bcache.
9630         (psymbol_bcache_init, psymbol_bcache_free)
9631         (psymbol_bcache_get_bcache): Don't declare.
9632         * psymtab.c (struct psymbol_bcache): Remove.
9633         (psymtab_storage::psymtab_storage): Update.
9634         (psymtab_storage::~psymtab_storage): Update.
9635         (psymbol_bcache_init, psymbol_bcache_free)
9636         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
9637         (add_psymbol_to_bcache): Update.
9638         (allocate_psymtab): Update.
9639         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
9640         macro_cache>: No longer pointers.
9641         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
9642         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
9643         * macrotab.c (macro_bcache): Update.
9644         * macroexp.c: Don't include bcache.h.
9645         * gdbtypes.c (check_types_worklist): Update.
9646         (types_deeply_equal): Remove TRY/CATCH.  Update.
9647         * elfread.c (elf_symtab_read): Update.
9648         * dwarf2read.c: Don't include bcache.h.
9649         * buildsym.c (buildsym_compunit::get_macro_table): Update.
9650         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
9651         (print_bcache_statistics, bcache_memory_used): Don't declare.
9652         (struct bcache): Move from bcache.c.  Add constructor, destructor,
9653         methods.  Rename all data members.
9654         * bcache.c (struct bcache): Move to bcache.h.
9655         (bcache::expand_hash_table): Rename from expand_hash_table.
9656         (bcache): Remove.
9657         (bcache::insert): Rename from bcache_full.
9658         (bcache::compare): Rename from bcache_compare.
9659         (bcache_xmalloc): Remove.
9660         (bcache::~bcache): Rename from bcache_xfree.
9661         (bcache::print_statistics): Rename from print_bcache_statistics.
9662         (bcache::memory_used): Rename from bcache_memory_used.
9663
9664 2019-03-07  Pedro Alves  <palves@redhat.com>
9665
9666         * infrun.c (normal_stop): Also check for
9667         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
9668
9669 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
9670
9671         * f-lang.c (value_from_host_double): Moved to...
9672         * value.c (value_from_host_double): ...here.
9673         * value.h (value_from_host_double): Declare.
9674         * guile/scm-math.c (vlscm_convert_typed_number): Use
9675         value_from_host_double.
9676         (vlscm_convert_number): Likewise.
9677         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
9678         * python/py-value.c (convert_value_from_python): Likewise.
9679
9680 2019-03-06  Tom Tromey  <tom@tromey.com>
9681
9682         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
9683
9684 2019-03-06  Tom Tromey  <tom@tromey.com>
9685
9686         * utils.h (free_current_contents): Don't declare.
9687         * utils.c (free_current_contents): Remove.
9688
9689 2019-03-06  Tom Tromey  <tom@tromey.com>
9690
9691         * top.c (quit_force): Update.
9692         * main.c (captured_command_loop): Update.
9693         * common/new-op.c (operator new): Update.
9694         * common/common-exceptions.c (struct catcher)
9695         <save_cleanup_chain>: Remove member.
9696         (exceptions_state_mc_init): Update.
9697         (exception_try_scope_entry): Return nullptr.
9698         (exception_try_scope_exit, exception_rethrow)
9699         (throw_exception_sjlj, throw_exception_cxx): Update.
9700         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
9701         (all_cleanups, do_cleanups, discard_cleanups)
9702         (discard_final_cleanups, save_cleanups, save_final_cleanups)
9703         (restore_cleanups, restore_final_cleanups): Don't declare.
9704         (do_final_cleanups): Remove parameter.
9705         * common/cleanups.c (cleanup_chain, make_cleanup)
9706         (make_cleanup_dtor, all_cleanups, do_cleanups)
9707         (discard_my_cleanups, discard_cleanups)
9708         (discard_final_cleanups, save_my_cleanups, save_cleanups)
9709         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
9710         (null_cleanup): Remove.
9711         (do_final_cleanups): Remove parameter.
9712
9713 2019-03-06  Tom Tromey  <tom@tromey.com>
9714
9715         * remote.c (remote_target::remote_parse_stop_reply): Use
9716         unique_xmalloc_ptr.
9717
9718 2019-03-06  Tom Tromey  <tom@tromey.com>
9719
9720         * stabsread.c (struct stabs_field_info): Rename from field_info.
9721         <list, fnlist>: Add initializers.
9722         <obstack>: New member.
9723         (read_member_functions, read_struct_fields, read_baseclasses):
9724         Allocate on obstack.  Don't use cleanups.
9725         (read_one_struct_field, read_member_functions, read_struct_fields)
9726         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
9727         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
9728         (read_struct_type): Update.
9729
9730 2019-03-06  Tom Tromey  <tom@tromey.com>
9731
9732         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
9733         * common/filestuff.h (make_cleanup_close): Don't declare.
9734         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
9735         Remove.
9736
9737 2019-03-06  Tom Tromey  <tom@tromey.com>
9738
9739         * solib-aix.c: Use make_scope_exit.
9740
9741 2019-03-06  Tom Tromey  <tom@tromey.com>
9742
9743         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
9744         Use make_scope_exit.
9745
9746 2019-03-06  Tom Tromey  <tom@tromey.com>
9747
9748         * solib-svr4.c (disable_probes_interface): Remove parameter.
9749         (svr4_handle_solib_event): Use make_scope_exit.
9750
9751 2019-03-06  Tom Tromey  <tom@tromey.com>
9752
9753         * remote.c (struct stop_reply_deleter): Remove.
9754         (stop_reply_up): Update.
9755         (struct stop_reply): Derive from notif_event.  Don't typedef.
9756         <regcache>: Now a std::vector.
9757         (stop_reply_xfree): Remove.
9758         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
9759         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
9760         (remote_target::discard_pending_stop_replies): Use delete.
9761         (remote_target::remote_parse_stop_reply): Update.
9762         (remote_target::process_stop_reply): Update.
9763         * remote-notif.h (struct notif_event): Add virtual destructor.
9764         Remove "dtr" member.
9765         (struct notif_client) <alloc_event>: Return a unique_ptr.
9766         (notif_event_xfree): Don't declare.
9767         (notif_event_up): New typedef.
9768         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
9769         (notif_event_xfree, do_notif_event_xfree): Remove.
9770         (remote_notif_state_xfree): Update.
9771
9772 2019-03-06  Tom Tromey  <tom@tromey.com>
9773
9774         * infrun.c (displaced_step_clear_cleanup): Now a
9775         forward_scope_exit type.
9776         (displaced_step_prepare_throw): Update.
9777         (displaced_step_fixup): Update.
9778
9779 2019-03-06  Tom Tromey  <tom@tromey.com>
9780
9781         * inferior.h (class inferior): Update comment.
9782         * gdbthread.h (class thread_info): Update comment.
9783
9784 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
9785             Tom Tromey  <tom@tromey.com>
9786
9787         * stabsread.h (struct stab_section_list): Remove.
9788         (coffstab_build_psymtabs): Update.
9789         * dbxread.c (symbuf_sections): Now a std::vector.
9790         (sect_idx): New global.
9791         (fill_symbuf): Update.
9792         (coffstab_build_psymtabs): Change type of stabsects parameter.
9793         Update.
9794         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
9795         std::vector.
9796         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
9797         (coff_locate_sections): Update.
9798         (coff_symfile_read): Remove cleanups.  Update.
9799         (init_stringtab): Add storage parameter.
9800         (free_stringtab, free_stringtab_cleanup): Remove.
9801         (init_lineno): Add storage parameter.
9802         (free_linetab, free_linetab_cleanup): Remove.
9803
9804 2019-03-06  Pedro Alves  <palves@redhat.com>
9805
9806         * linux-fork.c (fork_info::clobber_regs): Delete.
9807         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
9808         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
9809         comment.  Adjust.
9810         (scoped_switch_fork_info::scoped_switch_fork_info)
9811         (checkpoint_command, linux_fork_context): Adjust
9812         fork_save_infrun_state calls.
9813
9814 2019-03-06  Pedro Alves  <palves@redhat.com>
9815
9816         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
9817         (inf_has_multiple_threads): Return 'bool' and rewrite using
9818         inferior_info::threads().
9819
9820 2019-03-06  Pedro Alves  <palves@redhat.com>
9821
9822         * linux-fork.c: Include <list>.
9823         (fork_list): Now a std::list instance.
9824         (fork_info): Add ctor, dtor, and in-class initialize all fields.
9825         (forks_exist_p, find_last_fork): Adjust.
9826         (new_fork): Delete.
9827         (one_fork_p): New.
9828         (add_fork): Adjust.
9829         (free_fork): Delete, folded into fork_info::~fork_info().
9830         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
9831         Adjust.
9832         (init_fork_list): Delete.
9833         (linux_fork_killall, linux_fork_mourn_inferior)
9834         (linux_fork_detach, info_checkpoints_command): Adjust.
9835         (_initialize_linux_fork): No longer call init_fork_list.
9836
9837 2019-03-06  Pedro Alves  <palves@redhat.com>
9838
9839         * linux-fork.c (new_fork): New, split out of ...
9840         (add_fork): ... this.  Return void.  Move "first fork" special
9841         case from here, to ...
9842         (checkpoint_command): ... here.
9843         * linux-linux.h (add_fork): Return void.
9844
9845 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9846
9847         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
9848
9849 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9850             Chris January  <chris.january@arm.com>
9851             David Lecomber  <david.lecomber@arm.com>
9852
9853         * f-exp.y: New token, UNOP_INTRINSIC.
9854         (exp): New pattern using UNOP_INTRINSIC token.
9855         (f77_keywords): Add 'abs' keyword.
9856         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
9857         (value_from_host_double): New function.
9858         (evaluate_subexp_f): Support UNOP_ABS.
9859
9860 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9861
9862         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
9863         types.
9864
9865 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9866
9867         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
9868         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
9869         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
9870
9871 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9872
9873         * f-exp.y (convert_to_kind_type): Handle more type kinds.
9874
9875 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9876             Chris January  <chris.january@arm.com>
9877
9878         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
9879         * f-exp.y: Define 'KIND' token.
9880         (exp): New pattern for KIND expressions.
9881         (ptype): Handle types with a kind extension.
9882         (direct_abs_decl): Extend to spot kind extensions.
9883         (f77_keywords): Add 'kind' to the list.
9884         (push_kind_type): New function.
9885         (convert_to_kind_type): New function.
9886         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
9887         * parse.c (operator_length_standard): Likewise.
9888         * parser-defs.h (enum type_pieces): Add tp_kind.
9889         * std-operator.def: Add UNOP_KIND.
9890
9891 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9892
9893         * f-exp.y (f_parse): Set yydebug.
9894
9895 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9896
9897         * f-lang.c (evaluate_subexp_f): New function.
9898         (exp_descriptor_f): New global.
9899         (f_language_defn): Use exp_descriptor_f instead of
9900         exp_descriptor_standard.
9901
9902 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9903
9904         * f-exp.y (struct token): Add comments.
9905         (dot_ops): Remove uppercase versions and the end marker.
9906         (f77_keywords): Likewise.
9907         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
9908         entries in the dot_ops array are case insensitive, and use
9909         strncasecmp to compare strings.  Also some whitespace cleanup in
9910         this area.  Similar for the f77_keywords array, except entries in
9911         this list might be case sensitive.
9912
9913 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9914
9915         * f-exp.y (struct f77_boolean_val): Add comments.
9916         (boolean_values): Remove uppercase versions, and end marker.
9917         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9918         and use strncasecmp to achieve case insensitivity.  Additionally,
9919         perform whitespace cleanup around this code.
9920
9921 2019-03-06  Tom Tromey  <tromey@adacore.com>
9922
9923         * remote-sim.c (gdbsim_target_open): Use result of
9924         gdb_argv::release.
9925
9926 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
9927         Dirk Schubert  <dirk.schubert@arm.com>
9928         Chris January  <chris.january@arm.com>
9929
9930         * eval.c (evaluate_subexp_standard): Call Fortran argument
9931         wrapping logic.
9932         * f-lang.c (struct value): A value which can be passed into a
9933         Fortran function call.
9934         (fortran_argument_convert): Wrap Fortran arguments in a pointer
9935         where appropriate.
9936         (struct type): Value ready for a Fortran function call.
9937         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9938         is needed.
9939         * f-lang.h (fortran_argument_convert): Declaration.
9940         (fortran_preserve_arg_pointer): Declaration.
9941         * infcall.c (value_arg_coerce): Call Fortran argument logic.
9942
9943 2019-03-05  Tom Tromey  <tromey@adacore.com>
9944
9945         * python/py-prettyprint.c (print_string_repr): Remove #if.
9946         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9947
9948 2019-03-05  Tom Tromey  <tromey@adacore.com>
9949
9950         * target.c (the_dummy_target): Move later.  Change type to
9951         "dummy_target".
9952         (initialize_targets): Don't initialize the_dummy_target.
9953
9954 2019-03-05  Tom Tromey  <tromey@adacore.com>
9955
9956         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9957         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9958
9959 2019-03-05  Tom Tromey  <tromey@adacore.com>
9960
9961         * windows-nat.c (windows_nat_target::attach)
9962         (windows_nat_target::detach): Don't call gdb_flush.
9963         * valprint.c (generic_val_print, val_print, val_print_string):
9964         Don't call gdb_flush.
9965         * utils.c (defaulted_query): Don't call gdb_flush.
9966         * typeprint.c (print_type_scalar): Don't call gdb_flush.
9967         * target.c (target_announce_detach): Don't call gdb_flush.
9968         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9969         * remote.c (extended_remote_target::attach): Don't call
9970         gdb_flush.
9971         * procfs.c (procfs_target::detach): Don't call gdb_flush.
9972         * printcmd.c (do_examine): Don't call gdb_flush.
9973         (info_display_command): Don't call gdb_flush.
9974         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9975         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9976         * memattr.c (info_mem_command): Don't call gdb_flush.
9977         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9978         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9979         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9980         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9981         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9982         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9983         (gnu_nat_target::detach): Don't call gdb_flush.
9984         * f-valprint.c (f_val_print): Don't call gdb_flush.
9985         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9986         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9987         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9988         gdb_flush.
9989         * c-valprint.c (c_val_print): Don't call gdb_flush.
9990         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9991
9992 2019-03-05  Tom Tromey  <tromey@adacore.com>
9993
9994         * varobj.c (update_dynamic_varobj_children): Update.
9995         (install_default_visualizer): Use reset, not release.
9996         * value.c (set_internalvar): Update.
9997         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9998         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9999         ATTRIBUTE_UNUSED_RESULT.
10000
10001 2019-03-05  Tom Tromey  <tromey@adacore.com>
10002
10003         * remote.c (class scoped_remote_fd) <release>: Add
10004         ATTRIBUTE_UNUSED_RESULT.
10005
10006 2019-03-05  Tom Tromey  <tromey@adacore.com>
10007
10008         * macroexp.c (struct macro_buffer) <release>: Add
10009         ATTRIBUTE_UNUSED_RESULT.
10010
10011 2019-03-05  Tom Tromey  <tromey@adacore.com>
10012
10013         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
10014         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
10015         ATTRIBUTE_UNUSED_RESULT.
10016
10017 2019-03-05  Tom Tromey  <tromey@adacore.com>
10018
10019         * common/scoped_fd.h (class scoped_fd) <release>: Add
10020         ATTRIBUTE_UNUSED_RESULT.
10021
10022 2019-03-05  Tom Tromey  <tromey@adacore.com>
10023
10024         * parser-defs.h (struct parser_state) <release>: Add
10025         ATTRIBUTE_UNUSED_RESULT.
10026
10027 2019-03-05  Tom Tromey  <tromey@adacore.com>
10028
10029         * utils.h (class gdb_argv) <release>: Add
10030         ATTRIBUTE_UNUSED_RESULT.
10031         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
10032
10033 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
10034
10035         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
10036         for-loop range, to avoid compiler warnings.
10037
10038         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
10039         avoid compiler warnings about unused variables.
10040
10041         * NEWS: Mention end of support for native debugging on MS-Windows
10042         before XP.
10043
10044         PR gdb/24292
10045         * common/netstuff.c:
10046         * gdbserver/gdbreplay.c
10047         * gdbserver/remote-utils.c:
10048         * ser-tcp.c:
10049         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
10050         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
10051         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
10052         'getaddrinfo' and 'freeaddrinfo' were not available before
10053         Windows XP, and mingw.org's MinGW headers by default define
10054         _WIN32_WINNT to 0x500.
10055
10056 2019-03-01  Gary Benson <gbenson@redhat.com>
10057
10058         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
10059
10060 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
10061             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
10062
10063         PR gdb/8527
10064         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
10065         set_sigint_trap, clear_sigint_trap.
10066
10067 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10068
10069         * target.c (target_detach): Clear the regcache and the
10070         frame cache.
10071
10072 2019-02-27  Pedro Alves  <palves@redhat.com>
10073
10074         * utils.c (set_screen_size): When we cap the height/width sizes,
10075         tweak the corresponding command variable to show "unlimited":
10076
10077 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
10078             Pedro Alves  <palves@redhat.com>
10079
10080         * utils.c (set_screen_size): Reduce "infinite" rows and columns
10081         before calling rl_set_screen_size.
10082
10083 2019-02-27  Tom Tromey  <tromey@adacore.com>
10084
10085         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
10086         define.
10087         * python/py-value.c: Remove Python 2.4 workaround.
10088         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
10089         workaround.
10090         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
10091         Python 2.4 workaround.
10092         * python/python-internal.h: Remove Python 2.4 comment.
10093         (Py_ssize_t): Don't define.
10094         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
10095         (gdb_Py_DECREF): Remove Python 2.4 workaround.
10096         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
10097         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
10098         * python/python.c (do_start_initialization): Remove Python 2.4
10099         workaround.
10100         * python/py-prettyprint.c (class dummy_python_frame): Remove.
10101         (print_children): Remove Python 2.4 workaround.
10102         * python/py-inferior.c (buffer_procs): Remove Python 2.4
10103         workaround.
10104         (CHARBUFFERPROC_NAME): Remove.
10105         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
10106         Python 2.4 workaround.
10107
10108 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10109
10110         * NEWS: Note minimum Python version.
10111
10112 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10113
10114         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
10115         code from these functions.  Remove corresponding ifdefs.  Use
10116         Py_buffer_up instead of explicit calls to PyBuffer_Release.
10117         Remove gotos and target of gotos.
10118         (infpy_search_memory): Likewise.
10119
10120 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10121
10122         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
10123         (hppa_gdbarch_init): Don't register deleted functions with
10124         gdbarch.
10125
10126 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10127
10128         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
10129         (h8300_unwind_sp): Delete.
10130         (h8300_dummy_id): Delete.
10131         (h8300_gdbarch_init): Don't register deleted functions with
10132         gdbarch.
10133
10134 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10135
10136         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
10137         (ft32_unwind_pc): Delete.
10138         (ft32_unwind_sp): Delete.
10139         (ft32_gdbarch_init): Don't register deleted functions with
10140         gdbarch.
10141
10142 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10143
10144         * gdb/frv-tdep.c (frv_dummy_id): Delete.
10145         (frv_unwind_pc): Delete.
10146         (frv_unwind_sp): Delete.
10147         (frv_gdbarch_init): Don't register deleted functions with
10148         gdbarch.
10149
10150 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10151
10152         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
10153         (riscv_unwind_pc): Delete.
10154         (riscv_unwind_sp): Delete.
10155         (riscv_gdbarch_init): Don't register deleted functions with
10156         gdbarch.
10157
10158 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10159
10160         * gdb/csky-tdep.c (csky_dummy_id): Delete.
10161         (csky_unwind_pc): Delete.
10162         (csky_unwind_sp): Delete.
10163         (csky_gdbarch_init): Don't register deleted functions with
10164         gdbarch.
10165
10166 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10167
10168         * gdb/cris-tdep.c (cris_dummy_id): Delete.
10169         (cris_unwind_pc): Delete.
10170         (cris_unwind_sp): Delete.
10171         (cris_gdbarch_init): Don't register deleted functions with
10172         gdbarch.
10173
10174 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10175
10176         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
10177         (bfin_unwind_pc): Delete.
10178         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
10179
10180 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10181
10182         * gdb/arm-tdep.c (arm_dummy_id): Delete.
10183         (arm_unwind_pc): Delete.
10184         (arm_unwind_sp): Delete.
10185         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
10186
10187 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10188
10189         * gdb/arc-tdep.c (arc_dummy_id): Delete.
10190         (arc_unwind_pc): Delete.
10191         (arc_unwind_sp): Delete.
10192         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
10193
10194 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10195
10196         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
10197         (alpha_unwind_pc): Delete.
10198         (alpha_gdbarch_init): Don't register deleted functions with
10199         gdbarch.
10200
10201 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10202
10203         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
10204         (aarch64_unwind_pc): Delete.
10205         (aarch64_unwind_sp): Delete.
10206         (aarch64_gdbarch_init): Don't register deleted functions with
10207         gdbarch.
10208
10209 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10210
10211         * gdbtypes.c (type_align): Don't consider static members when
10212         computing structure alignment.
10213
10214 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10215
10216         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
10217         return 0 for other types.
10218         * arch-utils.c (default_type_align): Always return 0.
10219         * gdbarch.h: Regenerate.
10220         * gdbarch.sh (type_align): Extend comment.
10221         * gdbtypes.c (type_align): Add additional comments, always call
10222         gdbarch_type_align before applying the default rules.
10223         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
10224         generic code will then apply a suitable default.
10225         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
10226         types, return 0 for other types.
10227
10228 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
10229
10230         * NEWS: Create a new section for the next release branch.
10231         Rename the section of the current branch, now that it has
10232         been cut.
10233
10234 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
10235
10236         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
10237         * version.in: Bump version to 8.3.50.DATE-git.
10238
10239 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
10240
10241         * aix-thread.c (ptid_cmp): Remove unused variable.
10242         (get_signaled_thread): Likewise.
10243         (store_regs_user_thread): Likewise.
10244         (store_regs_kernel_thread): Likewise.
10245         (fetch_regs_kernel_thread): Remove shadowed variable.
10246
10247 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10248
10249         * features/riscv/32bit-cpu.xml: Add register numbers.
10250         * features/riscv/32bit-fpu.c: Regenerate.
10251         * features/riscv/32bit-fpu.xml: Add register numbers.
10252         * features/riscv/64bit-cpu.xml: Add register numbers.
10253         * features/riscv/64bit-fpu.c: Regenerate.
10254         * features/riscv/64bit-fpu.xml: Add register numbers.
10255
10256 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
10257
10258         * NEWS: Mention two argument form of gdb.Value constructor.
10259         * python/py-value.c (convert_buffer_and_type_to_value): New
10260         function.
10261         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
10262         Add support for handling an optional second argument.  Call
10263         convert_buffer_and_type_to_value as appropriate.
10264         * python/python-internal.h (Py_buffer_deleter): New struct.
10265         (Py_buffer_up): New typedef.
10266
10267 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
10268
10269         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
10270         instead of releasing ownership.
10271
10272 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
10273
10274         * dwarf2read.c (open_and_init_dwp_file): Call
10275         elf_numsections instead of bfd_count_sections to initialize
10276         dwp_file->num_sections.
10277
10278 2019-02-25  Tom Tromey  <tromey@adacore.com>
10279
10280         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
10281
10282 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
10283
10284         * gcore.in: Add '--readnever' option when invoking GDB.
10285
10286 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
10287
10288         * MAINTAINERS: Update my email address.
10289
10290 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
10291
10292         * build-id.c (build_id_to_debug_bfd_1): New function.
10293         (build_id_to_debug_bfd): Look for separate debug file in
10294         sysroot.
10295
10296 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
10297
10298         * gdbarch.sh: Update the copyright year range that is placed into
10299         generated files.
10300
10301 2019-02-22  Keith Seitz  <keiths@redhat.com>
10302
10303         PR symtab/23853
10304         * linespec.c (create_sals_line_offset): Search for the default
10305         symtab's filename instead of its fullname.
10306
10307 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
10308
10309         * NEWS: Update style defaults.
10310
10311 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
10312
10313         * main.c (captured_main_1): Disable styling in batch mode.
10314
10315 2019-02-20  Tom Tromey  <tom@tromey.com>
10316
10317         * symtab.c (symtab_symbol_info): Fix typos.
10318
10319 2019-02-20  Tom Tromey  <tromey@adacore.com>
10320
10321         * findcmd.c (_initialize_mem_search): Use upper case for
10322         metasyntactic variables.
10323
10324 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
10325
10326         * aarch64-tdep.c (aarch64_add_reggroups): New function.
10327         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
10328
10329 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
10330
10331         * top.h (source_file_name): Change to std::string.
10332         * top.c (source_file_name): Likewise.
10333         (command_line_input): Adjust.
10334         * cli/cli-script.c (script_from_file): Adjust.
10335
10336 2019-02-19  Tom Tromey  <tromey@adacore.com>
10337
10338         * ravenscar-thread.c
10339         (ravenscar_thread_target::update_thread_list): Don't call
10340         ada_build_task_list.
10341         * ada-lang.h (ada_build_task_list): Don't declare.
10342         * ada-tasks.c (struct ada_tasks_inferior_data)
10343         <task_list_valid_p>: Now bool.
10344         (read_known_tasks, ada_task_list_changed)
10345         (ada_tasks_invalidate_inferior_data): Update.
10346         (read_known_tasks_array): Return bool.
10347         (read_known_tasks_list): Likewise.
10348         (read_known_tasks): Return void.
10349         (ada_build_task_list): Now static.
10350
10351 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10352
10353         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
10354         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
10355
10356 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10357
10358         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
10359         variant for ada_tasks_pspace_data_handle and
10360         ada_tasks_inferior_data_handle.
10361         (ada_tasks_pspace_data_cleanup): New function.
10362         (ada_tasks_inferior_data_cleanup): New function.
10363
10364 2019-02-17  Tom Tromey  <tom@tromey.com>
10365
10366         * macrotab.h (macro_source_fullname): Return a std::string.
10367         * macrotab.c (macro_include, check_for_redefinition)
10368         (macro_undef, macro_lookup_definition, foreach_macro)
10369         (foreach_macro_in_scope): Update.
10370         (macro_source_fullname): Return a std::string.
10371         * macrocmd.c (show_pp_source_pos): Update.
10372
10373 2019-02-17  Tom Tromey  <tom@tromey.com>
10374
10375         * macrocmd.c (show_pp_source_pos): Style the file names.
10376
10377 2019-02-17  Tom Tromey  <tom@tromey.com>
10378
10379         PR tui/24197:
10380         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
10381
10382 2019-02-17  Tom Tromey  <tom@tromey.com>
10383
10384         * ada-lang.c (user_select_syms): Use filtered printing.
10385         * utils.c (wrap_style): New global.
10386         (desired_style): Remove.
10387         (emit_style_escape): Add stream parameter.
10388         (set_output_style, reset_terminal_style, prompt_for_continue):
10389         Update.
10390         (flush_wrap_buffer): Only flush gdb_stdout.
10391         (wrap_here): Set wrap_style.
10392         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
10393         treat escape sequences as a character.  Change when wrap buffer is
10394         flushed.
10395         (fputs_styled): Do not set the output style when the default is
10396         requested.
10397         * ui-style.h (struct ui_file_style) <is_default>: New method.
10398         * source.c (print_source_lines_base): Emit escape sequences in one
10399         piece.
10400
10401 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10402
10403         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
10404         integers and enumeration types.
10405
10406 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10407
10408         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
10409         instead of lookup_symbol_in_language
10410         (do_exact_match): New function.
10411         (ada_get_symbol_name_matcher): Return do_exact_match when
10412         doing a verbatim match.
10413
10414 2019-02-15  Tom Tromey  <tromey@adacore.com>
10415
10416         * ravenscar-thread.c (ravenscar_thread_target::resume)
10417         (ravenscar_thread_target::wait): Special case wildcard requests.
10418
10419 2019-02-15  Tom Tromey  <tromey@adacore.com>
10420
10421         * ravenscar-thread.c (base_ptid): Remove.
10422         (struct ravenscar_thread_target) <close>: New method.
10423         <m_base_ptid>: New member.
10424         <update_inferior_ptid, active_task, task_is_currently_active,
10425         runtime_initialized>: Declare methods.
10426         <ravenscar_thread_target>: Add constructor.
10427         (ravenscar_thread_target::task_is_currently_active)
10428         (ravenscar_thread_target::update_inferior_ptid)
10429         (ravenscar_runtime_initialized): Rename.  Now methods.
10430         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
10431         (ravenscar_thread_target::update_thread_list): Update.
10432         (ravenscar_thread_target::active_task): Now method.
10433         (ravenscar_thread_target::store_registers)
10434         (ravenscar_thread_target::prepare_to_store)
10435         (ravenscar_thread_target::prepare_to_store)
10436         (ravenscar_thread_target::mourn_inferior): Update.
10437         (ravenscar_inferior_created): Use "new" to create target.
10438         (ravenscar_thread_target::get_ada_task_ptid): Update.
10439         (_initialize_ravenscar): Don't initialize base_ptid.
10440         (ravenscar_ops): Remove global.
10441
10442 2019-02-15  Tom Tromey  <tromey@adacore.com>
10443
10444         * target.h (push_target): Declare new overload.
10445         * target.c (push_target): New overload, taking an rvalue reference.
10446         * remote.c (remote_target::open_1): Use push_target overload.
10447         * corelow.c (core_target_open): Use push_target overload.
10448
10449 2019-02-15  Tom Tromey  <tromey@adacore.com>
10450
10451         * ravenscar-thread.c (is_ravenscar_task)
10452         (ravenscar_task_is_currently_active): Return bool.
10453         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
10454         (_initialize_ravenscar): Remove "(void)".
10455         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
10456         Return bool.
10457
10458 2019-02-15  Tom Tromey  <tromey@adacore.com>
10459
10460         * ravenscar-thread.c (ravenscar_runtime_initializer)
10461         (has_ravenscar_runtime, get_running_thread_id)
10462         (ravenscar_thread_target::resume): Fix indentation.
10463
10464 2019-02-15  Tom Tromey  <tromey@adacore.com>
10465
10466         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
10467         from ravenscar_arch_ops.
10468         (sparc_ravenscar_ops::fetch_registers)
10469         (sparc_ravenscar_ops::store_registers): Now methods.
10470         (sparc_ravenscar_prepare_to_store): Remove.
10471         (sparc_ravenscar_ops): Redefine.
10472         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
10473         methods and destructor.  Remove members.
10474         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
10475         (ravenscar_thread_target::store_registers)
10476         (ravenscar_thread_target::prepare_to_store): Update.
10477         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
10478         Remove.
10479         (struct ppc_ravenscar_powerpc_ops): Derive from
10480         ravenscar_arch_ops.
10481         (ppc_ravenscar_powerpc_ops::fetch_registers)
10482         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
10483         (ppc_ravenscar_powerpc_ops): Redefine.
10484         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
10485         (ppc_ravenscar_e500_ops::fetch_registers)
10486         (ppc_ravenscar_e500_ops::store_registers): Now methods.
10487         (ppc_ravenscar_e500_ops): Redefine.
10488         * aarch64-ravenscar-thread.c
10489         (aarch64_ravenscar_generic_prepare_to_store): Remove.
10490         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
10491         (aarch64_ravenscar_fetch_registers)
10492         (aarch64_ravenscar_store_registers): Now methods.
10493         (aarch64_ravenscar_ops): Redefine.
10494
10495 2019-02-15  Tom Tromey  <tromey@adacore.com>
10496
10497         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
10498         (ravenscar_thread_target::stopped_by_hw_breakpoint)
10499         (ravenscar_thread_target::stopped_by_watchpoint)
10500         (ravenscar_thread_target::stopped_data_address)
10501         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
10502
10503 2019-02-15  Tom Tromey  <tromey@adacore.com>
10504
10505         * ravenscar-thread.c: Fix some typos.
10506
10507 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10508             Tom Tromey  <tromey@adacore.com>
10509
10510         * ada-lang.c (ada_exception_sal): Change addr_string to a
10511         std::string.
10512         (create_ada_exception_catchpoint): Update.
10513
10514 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10515             Tom Tromey  <tromey@adacore.com>
10516
10517         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
10518         (bp_location_ops): Remove.
10519         (base_breakpoint_allocate_location): Update.
10520         (free_bp_location): Update.
10521         * ada-lang.c (class ada_catchpoint_location)
10522         <ada_catchpoint_location>: Remove ops parameter.
10523         (ada_catchpoint_location_dtor): Remove.
10524         (ada_catchpoint_location_ops): Remove.
10525         (allocate_location_exception): Update.
10526         * breakpoint.h (struct bp_location_ops): Remove.
10527         (class bp_location) <bp_location>: Remove bp_location_ops
10528         parameter.
10529         <~bp_location>: Add destructor.
10530         <ops>: Remove.
10531
10532 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10533             Pedro Alves  <palves@redhat.com>
10534
10535         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
10536         'PATH_MAX'.
10537
10538 2019-02-14  David Michael  <fedora.dm0@gmail.com>
10539             Samuel Thibault  <samuel.thibault@gnu.org>
10540             Thomas Schwinge  <thomas@codesourcery.com>
10541
10542         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
10543         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
10544
10545 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10546
10547         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
10548         (check_empty): Use "const char *".
10549
10550         * gnu-nat.c (gnu_nat_target::detach): Instead of
10551         'detach_inferior (pid)' call
10552         'detach_inferior (find_inferior_pid (pid))'.
10553
10554         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
10555         'nat/fork-inferior.o'.
10556         * gnu-nat.c: #include "nat/fork-inferior.h".
10557
10558         * gnu-nat.c (gnu_nat_target::detach): Instead of
10559         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
10560         * gnu-nat.h: #include "inf-child.h".
10561         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
10562         'i386_gnu_nat_target::fetch_registers'.
10563         (gnu_store_registers): Rename/move to
10564         'i386_gnu_nat_target::store_registers'.
10565
10566         * config/i386/nm-i386gnu.h: Don't "#include" any files.
10567         * gnu-nat.h (mach_thread_info): New function.
10568         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
10569
10570         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
10571
10572 2019-02-14  Frederic Konrad  <konrad@adacore.com>
10573
10574         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
10575
10576 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
10577
10578         * windows-nat.c (windows_add_thread): Add new parameter
10579         "main_thread_p" with default value set to false.  Update
10580         function documentation as well as all callers.
10581         (windows_delete_thread): Likewise.
10582         (fake_create_process): Update call to windows_add_thread.
10583         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
10584         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
10585         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
10586         call to windows_delete_thread.
10587
10588 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
10589
10590         * MAINTAINERS: Add Andrew Burgess as global maintainer.
10591
10592 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10593
10594         * symfile.c (find_separate_debug_file): Use canonical path of
10595         sysroot with child_path instead of gdb_sysroot if it is valid.
10596
10597 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10598
10599         * symfile.c (find_separate_debug_file): Use child_path to
10600         determine if an object file is under a sysroot.
10601
10602 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10603
10604         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
10605         unittests/child-path-selftests.c.
10606         * common/pathstuff.c (child_path): New function.
10607         * common/pathstuff.h (child_path): New prototype.
10608         * unittests/child-path-selftests.c: New file.
10609
10610 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10611
10612         * symfile.c (find_separate_debug_file): Look for separate debug
10613         files in debug directories under the sysroot.
10614
10615 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10616
10617         * symtab.h (struct minimal_symbol data_p): New const method.
10618         (struct minimal_symbol text_p): Likewise.
10619         * symtab.c (output_source_filename): Use file name style
10620         to print file name.
10621         (print_symbol_info): Likewise.
10622         (print_msymbol_info): Use address style to print addresses.
10623         Use function name style to print executable text symbols.
10624         (expand_symtab_containing_pc): Use data_p.
10625         (find_pc_sect_compunit_symtab): Likewise.
10626
10627 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10628
10629         * breakpoint.c (describe_other_breakpoints): Use address style
10630         to print addresses.
10631         (say_where): Likewise.
10632
10633 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10634
10635         * ada-typeprint.c (print_func_type): Print function name
10636         style to print function name.
10637         * c-typeprint.c (c_print_type_1): Likewise.
10638
10639 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
10640
10641         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
10642         for execve.
10643
10644 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10645
10646         * c-exp.y (direct_abs_decl): Use emplace_back to record the
10647         type_stack.
10648
10649 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
10650
10651         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
10652         TYPE_CODE_REF types.
10653
10654 2019-02-08  Jim Wilson  <jimw@sifive.com>
10655
10656         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
10657         (riscv_linux_fregset): New.
10658         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
10659
10660 2019-02-07  Tom Tromey  <tom@tromey.com>
10661
10662         * thread.c (thread_cancel_execution_command): Update.
10663         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
10664         methods.
10665         (struct thread_fsm_ops): Remove.
10666         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
10667         (thread_fsm_should_stop, thread_fsm_return_value)
10668         (thread_fsm_set_finished, thread_fsm_finished_p)
10669         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
10670         Don't declare.
10671         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
10672         * infrun.c (clear_proceed_status_thread)
10673         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
10674         (print_stop_event): Update.
10675         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
10676         Add constructor.
10677         (step_command_fsm_ops): Remove.
10678         (new_step_command_fsm): Remove.
10679         (step_1): Update.
10680         (step_command_fsm::should_stop): Rename from
10681         step_command_fsm_should_stop.
10682         (step_command_fsm::clean_up): Rename from
10683         step_command_fsm_clean_up.
10684         (step_command_fsm::do_async_reply_reason): Rename from
10685         step_command_fsm_async_reply_reason.
10686         (struct until_next_fsm): Inherit from thread_fsm.  Add
10687         constructor.
10688         (until_next_fsm_ops): Remove.
10689         (new_until_next_fsm): Remove.
10690         (until_next_fsm::should_stop): Rename from
10691         until_next_fsm_should_stop.
10692         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
10693         (until_next_fsm::do_async_reply_reason): Rename from
10694         until_next_fsm_async_reply_reason.
10695         (struct finish_command_fsm): Inherit from thread_fsm.  Add
10696         constructor.  Change type of breakpoint.
10697         (finish_command_fsm_ops): Remove.
10698         (new_finish_command_fsm): Remove.
10699         (finish_command_fsm::should_stop): Rename from
10700         finish_command_fsm_should_stop.
10701         (finish_command_fsm::clean_up): Rename from
10702         finish_command_fsm_clean_up.
10703         (finish_command_fsm::return_value): Rename from
10704         finish_command_fsm_return_value.
10705         (finish_command_fsm::do_async_reply_reason): Rename from
10706         finish_command_fsm_async_reply_reason.
10707         (finish_command): Update.
10708         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
10709         Add constructor.
10710         (call_thread_fsm_ops): Remove.
10711         (call_thread_fsm::call_thread_fsm): Rename from
10712         new_call_thread_fsm.
10713         (call_thread_fsm::should_stop): Rename from
10714         call_thread_fsm_should_stop.
10715         (call_thread_fsm::should_notify_stop): Rename from
10716         call_thread_fsm_should_notify_stop.
10717         (run_inferior_call, call_function_by_hand_dummy): Update.
10718         * cli/cli-interp.c (should_print_stop_to_console): Update.
10719         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
10720         Add constructor.  Change type of location_breakpoint,
10721         caller_breakpoint.
10722         (until_break_fsm_ops): Remove.
10723         (new_until_break_fsm): Remove.
10724         (until_break_fsm::should_stop): Rename from
10725         until_break_fsm_should_stop.
10726         (until_break_fsm::clean_up): Rename from
10727         until_break_fsm_clean_up.
10728         (until_break_fsm::do_async_reply_reason): Rename from
10729         until_break_fsm_async_reply_reason.
10730         (until_break_command): Update.
10731         * thread-fsm.c: Remove.
10732         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
10733
10734 2019-02-07  Tom Tromey  <tom@tromey.com>
10735
10736         * yy-remap.h: Add include guard.
10737         * xtensa-tdep.h: Add include guard.
10738         * xcoffread.h: Rename include guard.
10739         * varobj-iter.h: Add include guard.
10740         * tui/tui.h: Rename include guard.
10741         * tui/tui-winsource.h: Rename include guard.
10742         * tui/tui-wingeneral.h: Rename include guard.
10743         * tui/tui-windata.h: Rename include guard.
10744         * tui/tui-win.h: Rename include guard.
10745         * tui/tui-stack.h: Rename include guard.
10746         * tui/tui-source.h: Rename include guard.
10747         * tui/tui-regs.h: Rename include guard.
10748         * tui/tui-out.h: Rename include guard.
10749         * tui/tui-layout.h: Rename include guard.
10750         * tui/tui-io.h: Rename include guard.
10751         * tui/tui-hooks.h: Rename include guard.
10752         * tui/tui-file.h: Rename include guard.
10753         * tui/tui-disasm.h: Rename include guard.
10754         * tui/tui-data.h: Rename include guard.
10755         * tui/tui-command.h: Rename include guard.
10756         * tic6x-tdep.h: Add include guard.
10757         * target/waitstatus.h: Rename include guard.
10758         * target/wait.h: Rename include guard.
10759         * target/target.h: Rename include guard.
10760         * target/resume.h: Rename include guard.
10761         * target-float.h: Rename include guard.
10762         * stabsread.h: Add include guard.
10763         * rs6000-tdep.h: Add include guard.
10764         * riscv-fbsd-tdep.h: Add include guard.
10765         * regformats/regdef.h: Rename include guard.
10766         * record.h: Rename include guard.
10767         * python/python.h: Rename include guard.
10768         * python/python-internal.h: Rename include guard.
10769         * python/py-stopevent.h: Rename include guard.
10770         * python/py-ref.h: Rename include guard.
10771         * python/py-record.h: Rename include guard.
10772         * python/py-record-full.h: Rename include guard.
10773         * python/py-record-btrace.h: Rename include guard.
10774         * python/py-instruction.h: Rename include guard.
10775         * python/py-events.h: Rename include guard.
10776         * python/py-event.h: Rename include guard.
10777         * procfs.h: Add include guard.
10778         * proc-utils.h: Add include guard.
10779         * p-lang.h: Add include guard.
10780         * or1k-tdep.h: Rename include guard.
10781         * observable.h: Rename include guard.
10782         * nto-tdep.h: Rename include guard.
10783         * nat/x86-linux.h: Rename include guard.
10784         * nat/x86-linux-dregs.h: Rename include guard.
10785         * nat/x86-gcc-cpuid.h: Add include guard.
10786         * nat/x86-dregs.h: Rename include guard.
10787         * nat/x86-cpuid.h: Rename include guard.
10788         * nat/ppc-linux.h: Rename include guard.
10789         * nat/mips-linux-watch.h: Rename include guard.
10790         * nat/linux-waitpid.h: Rename include guard.
10791         * nat/linux-ptrace.h: Rename include guard.
10792         * nat/linux-procfs.h: Rename include guard.
10793         * nat/linux-osdata.h: Rename include guard.
10794         * nat/linux-nat.h: Rename include guard.
10795         * nat/linux-namespaces.h: Rename include guard.
10796         * nat/linux-btrace.h: Rename include guard.
10797         * nat/glibc_thread_db.h: Rename include guard.
10798         * nat/gdb_thread_db.h: Rename include guard.
10799         * nat/gdb_ptrace.h: Rename include guard.
10800         * nat/fork-inferior.h: Rename include guard.
10801         * nat/amd64-linux-siginfo.h: Rename include guard.
10802         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
10803         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
10804         * nat/aarch64-linux.h: Rename include guard.
10805         * nat/aarch64-linux-hw-point.h: Rename include guard.
10806         * mn10300-tdep.h: Add include guard.
10807         * mips-linux-tdep.h: Add include guard.
10808         * mi/mi-parse.h: Rename include guard.
10809         * mi/mi-out.h: Rename include guard.
10810         * mi/mi-main.h: Rename include guard.
10811         * mi/mi-interp.h: Rename include guard.
10812         * mi/mi-getopt.h: Rename include guard.
10813         * mi/mi-console.h: Rename include guard.
10814         * mi/mi-common.h: Rename include guard.
10815         * mi/mi-cmds.h: Rename include guard.
10816         * mi/mi-cmd-break.h: Rename include guard.
10817         * m2-lang.h: Add include guard.
10818         * location.h: Rename include guard.
10819         * linux-record.h: Rename include guard.
10820         * linux-nat.h: Add include guard.
10821         * linux-fork.h: Add include guard.
10822         * i386-darwin-tdep.h: Rename include guard.
10823         * hppa-linux-offsets.h: Add include guard.
10824         * guile/guile.h: Rename include guard.
10825         * guile/guile-internal.h: Rename include guard.
10826         * gnu-nat.h: Rename include guard.
10827         * gdb-stabs.h: Rename include guard.
10828         * frv-tdep.h: Add include guard.
10829         * f-lang.h: Add include guard.
10830         * event-loop.h: Add include guard.
10831         * darwin-nat.h: Rename include guard.
10832         * cp-abi.h: Rename include guard.
10833         * config/sparc/nm-sol2.h: Rename include guard.
10834         * config/nm-nto.h: Rename include guard.
10835         * config/nm-linux.h: Add include guard.
10836         * config/i386/nm-i386gnu.h: Rename include guard.
10837         * config/djgpp/nl_types.h: Rename include guard.
10838         * config/djgpp/langinfo.h: Rename include guard.
10839         * compile/gcc-cp-plugin.h: Add include guard.
10840         * compile/gcc-c-plugin.h: Add include guard.
10841         * compile/compile.h: Rename include guard.
10842         * compile/compile-object-run.h: Rename include guard.
10843         * compile/compile-object-load.h: Rename include guard.
10844         * compile/compile-internal.h: Rename include guard.
10845         * compile/compile-cplus.h: Rename include guard.
10846         * compile/compile-c.h: Rename include guard.
10847         * common/xml-utils.h: Rename include guard.
10848         * common/x86-xstate.h: Rename include guard.
10849         * common/version.h: Rename include guard.
10850         * common/vec.h: Rename include guard.
10851         * common/tdesc.h: Rename include guard.
10852         * common/selftest.h: Rename include guard.
10853         * common/scoped_restore.h: Rename include guard.
10854         * common/scoped_mmap.h: Rename include guard.
10855         * common/scoped_fd.h: Rename include guard.
10856         * common/safe-iterator.h: Rename include guard.
10857         * common/run-time-clock.h: Rename include guard.
10858         * common/refcounted-object.h: Rename include guard.
10859         * common/queue.h: Rename include guard.
10860         * common/ptid.h: Rename include guard.
10861         * common/print-utils.h: Rename include guard.
10862         * common/preprocessor.h: Rename include guard.
10863         * common/pathstuff.h: Rename include guard.
10864         * common/observable.h: Rename include guard.
10865         * common/netstuff.h: Rename include guard.
10866         * common/job-control.h: Rename include guard.
10867         * common/host-defs.h: Rename include guard.
10868         * common/gdb_wait.h: Rename include guard.
10869         * common/gdb_vecs.h: Rename include guard.
10870         * common/gdb_unlinker.h: Rename include guard.
10871         * common/gdb_unique_ptr.h: Rename include guard.
10872         * common/gdb_tilde_expand.h: Rename include guard.
10873         * common/gdb_sys_time.h: Rename include guard.
10874         * common/gdb_string_view.h: Rename include guard.
10875         * common/gdb_splay_tree.h: Rename include guard.
10876         * common/gdb_setjmp.h: Rename include guard.
10877         * common/gdb_ref_ptr.h: Rename include guard.
10878         * common/gdb_optional.h: Rename include guard.
10879         * common/gdb_locale.h: Rename include guard.
10880         * common/gdb_assert.h: Rename include guard.
10881         * common/filtered-iterator.h: Rename include guard.
10882         * common/filestuff.h: Rename include guard.
10883         * common/fileio.h: Rename include guard.
10884         * common/environ.h: Rename include guard.
10885         * common/common-utils.h: Rename include guard.
10886         * common/common-types.h: Rename include guard.
10887         * common/common-regcache.h: Rename include guard.
10888         * common/common-inferior.h: Rename include guard.
10889         * common/common-gdbthread.h: Rename include guard.
10890         * common/common-exceptions.h: Rename include guard.
10891         * common/common-defs.h: Rename include guard.
10892         * common/common-debug.h: Rename include guard.
10893         * common/cleanups.h: Rename include guard.
10894         * common/buffer.h: Rename include guard.
10895         * common/btrace-common.h: Rename include guard.
10896         * common/break-common.h: Rename include guard.
10897         * cli/cli-utils.h: Rename include guard.
10898         * cli/cli-style.h: Rename include guard.
10899         * cli/cli-setshow.h: Rename include guard.
10900         * cli/cli-script.h: Rename include guard.
10901         * cli/cli-interp.h: Rename include guard.
10902         * cli/cli-decode.h: Rename include guard.
10903         * cli/cli-cmds.h: Rename include guard.
10904         * charset-list.h: Add include guard.
10905         * buildsym-legacy.h: Rename include guard.
10906         * bfin-tdep.h: Add include guard.
10907         * ax.h: Rename include guard.
10908         * arm-linux-tdep.h: Add include guard.
10909         * arm-fbsd-tdep.h: Add include guard.
10910         * arch/xtensa.h: Rename include guard.
10911         * arch/tic6x.h: Add include guard.
10912         * arch/i386.h: Add include guard.
10913         * arch/arm.h: Rename include guard.
10914         * arch/arm-linux.h: Rename include guard.
10915         * arch/arm-get-next-pcs.h: Rename include guard.
10916         * arch/amd64.h: Add include guard.
10917         * arch/aarch64-insn.h: Rename include guard.
10918         * arch-utils.h: Rename include guard.
10919         * annotate.h: Add include guard.
10920         * amd64-darwin-tdep.h: Rename include guard.
10921         * aarch64-linux-tdep.h: Add include guard.
10922         * aarch64-fbsd-tdep.h: Add include guard.
10923         * aarch32-linux-nat.h: Add include guard.
10924
10925 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10926
10927         * macrotab.c (macro_define_internal): New function that
10928         factorizes macro_define_object_internal and macro_define_function
10929         code.
10930         (macro_define_object_internal): Use macro_define_internal.
10931         (macro_define_function): Likewise.
10932
10933 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10934
10935         * macrocmd.c (extract_identifier): Return
10936         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10937         callers.
10938
10939 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
10940
10941         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10942
10943 2019-02-05  Tom Tromey  <tom@tromey.com>
10944
10945         * target.c (target_stack::unpush): Move assertion earlier.
10946
10947 2019-01-30  Tom Tromey  <tom@tromey.com>
10948
10949         PR python/23615:
10950         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10951         (gdbpy_parse_and_eval): Likewise.
10952         * python/python-internal.h (gdbpy_allow_threads): New class.
10953
10954 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
10955
10956         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10957         (aarch64_fbsd_fpregmap): Move earlier.
10958         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10959         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10960         instead of individual calls to trad_frame_set_reg_addr.
10961         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10962         earlier.
10963         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10964         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10965         instead of individual calls to trad_frame_set_reg_addr.
10966
10967 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
10968
10969         * CONTRIBUTE: Replace contribution list with wiki link.
10970
10971 2019-01-25  Tom Tromey  <tom@tromey.com>
10972
10973         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10974
10975 2019-01-25  Tom Tromey  <tom@tromey.com>
10976
10977         * xtensa-linux-nat.c: Fix common/ includes.
10978         * xml-support.h: Fix common/ includes.
10979         * xml-support.c: Fix common/ includes.
10980         * x86-linux-nat.c: Fix common/ includes.
10981         * windows-nat.c: Fix common/ includes.
10982         * varobj.h: Fix common/ includes.
10983         * varobj.c: Fix common/ includes.
10984         * value.c: Fix common/ includes.
10985         * valops.c: Fix common/ includes.
10986         * utils.c: Fix common/ includes.
10987         * unittests/xml-utils-selftests.c: Fix common/ includes.
10988         * unittests/utils-selftests.c: Fix common/ includes.
10989         * unittests/unpack-selftests.c: Fix common/ includes.
10990         * unittests/tracepoint-selftests.c: Fix common/ includes.
10991         * unittests/style-selftests.c: Fix common/ includes.
10992         * unittests/string_view-selftests.c: Fix common/ includes.
10993         * unittests/scoped_restore-selftests.c: Fix common/ includes.
10994         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10995         * unittests/scoped_fd-selftests.c: Fix common/ includes.
10996         * unittests/rsp-low-selftests.c: Fix common/ includes.
10997         * unittests/parse-connection-spec-selftests.c: Fix common/
10998         includes.
10999         * unittests/optional-selftests.c: Fix common/ includes.
11000         * unittests/offset-type-selftests.c: Fix common/ includes.
11001         * unittests/observable-selftests.c: Fix common/ includes.
11002         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
11003         * unittests/memrange-selftests.c: Fix common/ includes.
11004         * unittests/memory-map-selftests.c: Fix common/ includes.
11005         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
11006         * unittests/function-view-selftests.c: Fix common/ includes.
11007         * unittests/environ-selftests.c: Fix common/ includes.
11008         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
11009         * unittests/common-utils-selftests.c: Fix common/ includes.
11010         * unittests/cli-utils-selftests.c: Fix common/ includes.
11011         * unittests/array-view-selftests.c: Fix common/ includes.
11012         * ui-file.c: Fix common/ includes.
11013         * tui/tui-io.c: Fix common/ includes.
11014         * tracepoint.h: Fix common/ includes.
11015         * tracepoint.c: Fix common/ includes.
11016         * tracefile-tfile.c: Fix common/ includes.
11017         * top.h: Fix common/ includes.
11018         * top.c: Fix common/ includes.
11019         * thread.c: Fix common/ includes.
11020         * target/waitstatus.h: Fix common/ includes.
11021         * target/waitstatus.c: Fix common/ includes.
11022         * target.h: Fix common/ includes.
11023         * target.c: Fix common/ includes.
11024         * target-memory.c: Fix common/ includes.
11025         * target-descriptions.c: Fix common/ includes.
11026         * symtab.h: Fix common/ includes.
11027         * symfile.c: Fix common/ includes.
11028         * stap-probe.c: Fix common/ includes.
11029         * spu-linux-nat.c: Fix common/ includes.
11030         * sparc-nat.c: Fix common/ includes.
11031         * source.c: Fix common/ includes.
11032         * solib.c: Fix common/ includes.
11033         * solib-target.c: Fix common/ includes.
11034         * ser-unix.c: Fix common/ includes.
11035         * ser-tcp.c: Fix common/ includes.
11036         * ser-pipe.c: Fix common/ includes.
11037         * ser-base.c: Fix common/ includes.
11038         * selftest-arch.c: Fix common/ includes.
11039         * s12z-tdep.c: Fix common/ includes.
11040         * rust-exp.y: Fix common/ includes.
11041         * rs6000-aix-tdep.c: Fix common/ includes.
11042         * riscv-tdep.c: Fix common/ includes.
11043         * remote.c: Fix common/ includes.
11044         * remote-notif.h: Fix common/ includes.
11045         * remote-fileio.h: Fix common/ includes.
11046         * remote-fileio.c: Fix common/ includes.
11047         * regcache.h: Fix common/ includes.
11048         * regcache.c: Fix common/ includes.
11049         * record-btrace.c: Fix common/ includes.
11050         * python/python.c: Fix common/ includes.
11051         * python/py-type.c: Fix common/ includes.
11052         * python/py-inferior.c: Fix common/ includes.
11053         * progspace.h: Fix common/ includes.
11054         * producer.c: Fix common/ includes.
11055         * procfs.c: Fix common/ includes.
11056         * proc-api.c: Fix common/ includes.
11057         * printcmd.c: Fix common/ includes.
11058         * ppc-linux-nat.c: Fix common/ includes.
11059         * parser-defs.h: Fix common/ includes.
11060         * osdata.c: Fix common/ includes.
11061         * obsd-nat.c: Fix common/ includes.
11062         * nat/x86-linux.c: Fix common/ includes.
11063         * nat/x86-linux-dregs.c: Fix common/ includes.
11064         * nat/x86-dregs.h: Fix common/ includes.
11065         * nat/x86-dregs.c: Fix common/ includes.
11066         * nat/ppc-linux.c: Fix common/ includes.
11067         * nat/mips-linux-watch.h: Fix common/ includes.
11068         * nat/mips-linux-watch.c: Fix common/ includes.
11069         * nat/linux-waitpid.c: Fix common/ includes.
11070         * nat/linux-ptrace.h: Fix common/ includes.
11071         * nat/linux-ptrace.c: Fix common/ includes.
11072         * nat/linux-procfs.c: Fix common/ includes.
11073         * nat/linux-personality.c: Fix common/ includes.
11074         * nat/linux-osdata.c: Fix common/ includes.
11075         * nat/linux-namespaces.c: Fix common/ includes.
11076         * nat/linux-btrace.h: Fix common/ includes.
11077         * nat/linux-btrace.c: Fix common/ includes.
11078         * nat/fork-inferior.c: Fix common/ includes.
11079         * nat/amd64-linux-siginfo.c: Fix common/ includes.
11080         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
11081         * nat/aarch64-linux.c: Fix common/ includes.
11082         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
11083         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
11084         * namespace.h: Fix common/ includes.
11085         * mips-linux-tdep.c: Fix common/ includes.
11086         * minsyms.c: Fix common/ includes.
11087         * mi/mi-parse.h: Fix common/ includes.
11088         * mi/mi-main.c: Fix common/ includes.
11089         * mi/mi-cmd-env.c: Fix common/ includes.
11090         * memrange.h: Fix common/ includes.
11091         * memattr.c: Fix common/ includes.
11092         * maint.h: Fix common/ includes.
11093         * maint.c: Fix common/ includes.
11094         * main.c: Fix common/ includes.
11095         * machoread.c: Fix common/ includes.
11096         * location.c: Fix common/ includes.
11097         * linux-thread-db.c: Fix common/ includes.
11098         * linux-nat.c: Fix common/ includes.
11099         * linux-fork.c: Fix common/ includes.
11100         * inline-frame.c: Fix common/ includes.
11101         * infrun.c: Fix common/ includes.
11102         * inflow.c: Fix common/ includes.
11103         * inferior.h: Fix common/ includes.
11104         * inferior.c: Fix common/ includes.
11105         * infcmd.c: Fix common/ includes.
11106         * inf-ptrace.c: Fix common/ includes.
11107         * inf-child.c: Fix common/ includes.
11108         * ia64-linux-nat.c: Fix common/ includes.
11109         * i387-tdep.c: Fix common/ includes.
11110         * i386-tdep.c: Fix common/ includes.
11111         * i386-linux-tdep.c: Fix common/ includes.
11112         * i386-linux-nat.c: Fix common/ includes.
11113         * i386-go32-tdep.c: Fix common/ includes.
11114         * i386-fbsd-tdep.c: Fix common/ includes.
11115         * i386-fbsd-nat.c: Fix common/ includes.
11116         * guile/scm-type.c: Fix common/ includes.
11117         * guile/guile.c: Fix common/ includes.
11118         * go32-nat.c: Fix common/ includes.
11119         * gnu-nat.c: Fix common/ includes.
11120         * gdbthread.h: Fix common/ includes.
11121         * gdbarch-selftests.c: Fix common/ includes.
11122         * gdb_usleep.c: Fix common/ includes.
11123         * gdb_select.h: Fix common/ includes.
11124         * gdb_bfd.c: Fix common/ includes.
11125         * gcore.c: Fix common/ includes.
11126         * fork-child.c: Fix common/ includes.
11127         * findvar.c: Fix common/ includes.
11128         * fbsd-nat.c: Fix common/ includes.
11129         * event-top.c: Fix common/ includes.
11130         * event-loop.c: Fix common/ includes.
11131         * dwarf2read.c: Fix common/ includes.
11132         * dwarf2loc.c: Fix common/ includes.
11133         * dwarf2-frame.c: Fix common/ includes.
11134         * dwarf-index-cache.c: Fix common/ includes.
11135         * dtrace-probe.c: Fix common/ includes.
11136         * disasm-selftests.c: Fix common/ includes.
11137         * defs.h: Fix common/ includes.
11138         * csky-tdep.c: Fix common/ includes.
11139         * cp-valprint.c: Fix common/ includes.
11140         * cp-support.h: Fix common/ includes.
11141         * cp-support.c: Fix common/ includes.
11142         * corelow.c: Fix common/ includes.
11143         * completer.h: Fix common/ includes.
11144         * completer.c: Fix common/ includes.
11145         * compile/compile.c: Fix common/ includes.
11146         * compile/compile-loc2c.c: Fix common/ includes.
11147         * compile/compile-cplus-types.c: Fix common/ includes.
11148         * compile/compile-cplus-symbols.c: Fix common/ includes.
11149         * command.h: Fix common/ includes.
11150         * cli/cli-dump.c: Fix common/ includes.
11151         * cli/cli-cmds.c: Fix common/ includes.
11152         * charset.c: Fix common/ includes.
11153         * build-id.c: Fix common/ includes.
11154         * btrace.h: Fix common/ includes.
11155         * btrace.c: Fix common/ includes.
11156         * breakpoint.h: Fix common/ includes.
11157         * breakpoint.c: Fix common/ includes.
11158         * ax.h:
11159         (enum agent_op): Fix common/ includes.
11160         * ax-general.c (struct aop_map): Fix common/ includes.
11161         * ax-gdb.c: Fix common/ includes.
11162         * auxv.c: Fix common/ includes.
11163         * auto-load.c: Fix common/ includes.
11164         * arm-tdep.c: Fix common/ includes.
11165         * arch/riscv.c: Fix common/ includes.
11166         * arch/ppc-linux-common.c: Fix common/ includes.
11167         * arch/i386.c: Fix common/ includes.
11168         * arch/arm.c: Fix common/ includes.
11169         * arch/arm-linux.c: Fix common/ includes.
11170         * arch/arm-get-next-pcs.c: Fix common/ includes.
11171         * arch/amd64.c: Fix common/ includes.
11172         * arch/aarch64.c: Fix common/ includes.
11173         * arch/aarch64-insn.c: Fix common/ includes.
11174         * arch-utils.c: Fix common/ includes.
11175         * amd64-windows-tdep.c: Fix common/ includes.
11176         * amd64-tdep.c: Fix common/ includes.
11177         * amd64-sol2-tdep.c: Fix common/ includes.
11178         * amd64-obsd-tdep.c: Fix common/ includes.
11179         * amd64-nbsd-tdep.c: Fix common/ includes.
11180         * amd64-linux-tdep.c: Fix common/ includes.
11181         * amd64-linux-nat.c: Fix common/ includes.
11182         * amd64-fbsd-tdep.c: Fix common/ includes.
11183         * amd64-fbsd-nat.c: Fix common/ includes.
11184         * amd64-dicos-tdep.c: Fix common/ includes.
11185         * amd64-darwin-tdep.c: Fix common/ includes.
11186         * agent.c: Fix common/ includes.
11187         * ada-lang.h: Fix common/ includes.
11188         * ada-lang.c: Fix common/ includes.
11189         * aarch64-tdep.c: Fix common/ includes.
11190
11191 2019-01-25  Tom Tromey  <tom@tromey.com>
11192
11193         * common/create-version.sh: Use common/version.h.
11194
11195 2019-01-24  Pedro Alves  <palves@redhat.com>
11196
11197         * infrun.c (signal_stop, signal_print, signal_program)
11198         (signal_catch, signal_pass): Now arrays instead of pointers.
11199         (update_signals_program_target, do_target_resume)
11200         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
11201         * linux-nat.c (linux_nat_target::pass_signals)
11202         (linux_nat_target::create_inferior, linux_nat_target::attach):
11203         Adjust.
11204         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
11205         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
11206         * procfs.c (procfs_target::pass_signals): Adjust.
11207         * record-full.c (record_full_target::resume): Adjust.
11208         * remote.c (remote_target::pass_signals)
11209         (remote_target::program_signals): Adjust.
11210         * target-debug.h (target_debug_print_signals): Now takes a
11211         gdb::array_view as parameter.  Adjust.
11212         * target.h (target_ops) <pass_signals, program_signals>: Replace
11213         pointer and length parameters with gdb::array_view.
11214         (target_pass_signals, target_program_signals): Likewise.
11215         * target-delegates.c: Regenerate.
11216
11217 2019-01-24  Pedro Alves  <palves@redhat.com>
11218
11219         * common/forward-scope-exit.h
11220         (forward_scope_exit::forward_scope_exit): Pass arguments to
11221         m_bind_function directly, instead of creating a std::bind and
11222         copying that.
11223
11224 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
11225
11226         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11227         for static members.
11228         (pass_in_v_vfp_candidate): Likewise.
11229
11230 2019-01-23  Tom Tromey  <tom@tromey.com>
11231             Pedro Alves  <palves@redhat.com>
11232
11233         * regcache.c (class regcache_invalidator): Remove.
11234         (regcache::raw_write): Use make_scope_exit.
11235
11236 2019-01-23  Tom Tromey  <tom@tromey.com>
11237
11238         * ui-out.h (class ui_out_emit_type): Update comment.
11239
11240 2019-01-23  Tom Tromey  <tom@tromey.com>
11241
11242         * infrun.c (fetch_inferior_event): Update comment.
11243
11244 2019-01-23  Tom Tromey  <tom@tromey.com>
11245             Pedro Alves  <palves@redhat.com>
11246
11247         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
11248         parameter.
11249         (fetch_inferior_event): Use SCOPE_EXIT.
11250
11251
11252 2019-01-23  Tom Tromey  <tom@tromey.com>
11253             Pedro Alves  <palves@redhat.com>
11254
11255         * infrun.c (disable_thread_events): Delete.
11256         (stop_all_threads): Use SCOPE_EXIT.
11257
11258 2019-01-23  Tom Tromey  <tom@tromey.com>
11259             Pedro Alves  <palves@redhat.com>
11260
11261         * symfile.c: Include forward-scope-exit.h.
11262         (clear_symtab_users_cleanup): Replace forward declaration with
11263         a FORWARD_SCOPE_EXIT.
11264         (syms_from_objfile_1): Use the forward_scope_exit and
11265         gdb::optional instead of cleanup_function.
11266         (reread_symbols): Use the forward_scope_exit instead of
11267         cleanup_function.
11268         (clear_symtab_users_cleanup): Remove function.
11269
11270 2019-01-23  Tom Tromey  <tom@tromey.com>
11271             Pedro Alves  <palves@redhat.com>
11272
11273         * linux-nat.c: Include scope-exit.h.
11274         (cleanup_target_stop): Remove.
11275         (linux_nat_target::static_tracepoint_markers_by_strid): Use
11276         SCOPE_EXIT.
11277
11278 2019-01-23  Tom Tromey  <tom@tromey.com>
11279             Pedro Alves  <palves@redhat.com>
11280
11281         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
11282         (call_function_by_hand_dummy): Use SCOPE_EXIT.
11283
11284 2019-01-23  Tom Tromey  <tom@tromey.com>
11285             Andrew Burgess  <andrew.burgess@embecosm.com>
11286             Pedro Alves  <palves@redhat.com>
11287
11288         * infrun.c (fetch_inferior_event): Use scope_exit.
11289         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
11290         * top.c (execute_command): Use scope_exit.
11291         * breakpoint.c (bpstat_do_actions): Use scope_exit.
11292         * utils.c (do_bpstat_clear_actions_cleanup)
11293         (make_bpstat_clear_actions_cleanup): Remove.
11294
11295 2019-01-23  Tom Tromey  <tom@tromey.com>
11296             Pedro Alves  <palves@redhat.com>
11297
11298         * infrun.c: Include "common/scope-exit.h"
11299         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
11300         (wait_for_inferior): Use SCOPE_EXIT.
11301         (fetch_inferior_event): Use scope_exit.
11302
11303 2019-01-23  Tom Tromey  <tom@tromey.com>
11304             Pedro Alves  <palves@redhat.com>
11305
11306         * breakpoint.c (create_breakpoint): Remove cleanup.
11307
11308 2019-01-23  Tom Tromey  <tom@tromey.com>
11309             Andrew Burgess  <andrew.burgess@embecosm.com>
11310             Pedro Alves  <palves@redhat.com>
11311
11312 2019-01-23  Pedro Alves  <palves@redhat.com>
11313
11314         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
11315
11316 2019-01-23  Pedro Alves  <palves@redhat.com>
11317             Andrew Burgess  <andrew.burgess@embecosm.com>
11318
11319         * gdbthread.h: Include "common/forward-scope-exit.h".
11320         (scoped_finish_thread_state): Redefine custom class in terms of
11321         forward_scope_exit.
11322
11323 2019-01-23  Pedro Alves  <palves@redhat.com>
11324             Andrew Burgess  <andrew.burgess@embecosm.com>
11325
11326         * common/forward-scope-exit.h: New file.
11327
11328 2019-01-23  Pedro Alves  <palves@redhat.com>
11329             Andrew Burgess  <andrew.burgess@embecosm.com>
11330             Tom Tromey  <tom@tromey.com>
11331
11332         * common/scope-exit.h: New file.
11333
11334 2019-01-23  Pedro Alves  <palves@redhat.com>
11335
11336         * common/preprocessor.h (ESC): Rename to ...
11337         (ESC_PARENS): ... this.
11338         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
11339         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
11340
11341 2019-01-23  Tom Tromey  <tom@tromey.com>
11342
11343         * language.h (class scoped_switch_to_sym_language_if_auto):
11344         Initialize m_lang in both cases.
11345
11346 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
11347
11348         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
11349         with XCNEW.
11350
11351 2019-01-22  Tom Tromey  <tom@tromey.com>
11352
11353         * corelow.c: Do not include sys/file.h.
11354
11355 2019-01-22  Tom Tromey  <tom@tromey.com>
11356
11357         * tui/tui-wingeneral.h: Include gdb_curses.h.
11358
11359 2019-01-22  Tom Tromey  <tom@tromey.com>
11360
11361         * source-cache.h (class source_cache) <get_source_lines,
11362         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
11363
11364 2019-01-22  Tom Tromey  <tom@tromey.com>
11365
11366         * remote-fileio.h (struct remote_target): Declare.
11367
11368 2019-01-22  Tom Tromey  <tom@tromey.com>
11369
11370         * python/py-arch.c: Do not include py-ref.h.
11371         * python/py-bpevent.c: Do not include py-ref.h.
11372         * python/py-cmd.c: Do not include py-ref.h.
11373         * python/py-continueevent.c: Do not include py-ref.h.
11374         * python/py-event.h: Do not include py-ref.h.
11375         * python/py-evtregistry.c: Do not include py-ref.h.
11376         * python/py-finishbreakpoint.c: Do not include py-ref.h.
11377         * python/py-frame.c: Do not include py-ref.h.
11378         * python/py-framefilter.c: Do not include py-ref.h.
11379         * python/py-function.c: Do not include py-ref.h.
11380         * python/py-infevents.c: Do not include py-ref.h.
11381         * python/py-linetable.c: Do not include py-ref.h.
11382         * python/py-objfile.c: Do not include py-ref.h.
11383         * python/py-param.c: Do not include py-ref.h.
11384         * python/py-prettyprint.c: Do not include py-ref.h.
11385         * python/py-progspace.c: Do not include py-ref.h.
11386         * python/py-symbol.c: Do not include py-ref.h.
11387         * python/py-symtab.c: Do not include py-ref.h.
11388         * python/py-type.c: Do not include py-ref.h.
11389         * python/py-unwind.c: Do not include py-ref.h.
11390         * python/py-utils.c: Do not include py-ref.h.
11391         * python/py-value.c: Do not include py-ref.h.
11392         * python/py-varobj.c: Do not include py-ref.h.
11393         * python/py-xmethods.c: Do not include py-ref.h.
11394         * python/python.c: Do not include py-ref.h.
11395         * varobj.c: Do not include py-ref.h.
11396
11397 2019-01-22  Tom Tromey  <tom@tromey.com>
11398
11399         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
11400         keyword for bcache.
11401
11402 2019-01-22  Tom Tromey  <tom@tromey.com>
11403
11404         * compile/compile-cplus-types.c: Remove a comment by #include.
11405
11406 2019-01-22  Tom Tromey  <tom@tromey.com>
11407
11408         * compile/gcc-c-plugin.h: Include compile-internal.h.
11409
11410 2019-01-22  Tom Tromey  <tom@tromey.com>
11411
11412         * stabsread.c (EXTERN): Do not define.
11413         (symnum, next_symbol_text_func, processing_gcc_compilation)
11414         (within_function, global_sym_chain, global_stabs)
11415         (previous_stab_code, this_object_header_files)
11416         (n_this_object_header_files)
11417         (n_allocated_this_object_header_files): Define.
11418         * stabsread.h (EXTERN): Never define.  Use "extern".
11419
11420 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11421
11422         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
11423         history_value.
11424
11425 2019-01-21  Tom Tromey  <tom@tromey.com>
11426
11427         * ui-out.c: Fix includes.
11428         * tui/tui-source.c: Fix includes.
11429         * target.c: Fix includes.
11430         * remote.c: Fix includes.
11431         * regcache.c: Fix includes.
11432         * python/py-block.c: Fix includes.
11433         * printcmd.c: Fix includes.
11434         * or1k-tdep.c: Fix includes.
11435         * mi/mi-main.c: Fix includes.
11436         * m32r-tdep.c: Fix includes.
11437         * csky-tdep.c: Fix includes.
11438         * compile/compile-cplus-types.c: Fix includes.
11439         * cli/cli-interp.c: Fix includes.
11440
11441 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
11442
11443         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11444         for padding.
11445
11446 2019-01-16  Tom Tromey  <tom@tromey.com>
11447
11448         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
11449         earlier.
11450         (struct objfile) <msymbols_range>: Move from top level.
11451         <msymbols>: New method.
11452         (class objfile_msymbols): Remove.
11453         * symtab.c (default_collect_symbol_completion_matches_break_on):
11454         Update.
11455         * symmisc.c (dump_msymbols): Update.
11456         * stabsread.c (scan_file_globals): Update.
11457         * objc-lang.c (info_selectors_command, info_classes_command)
11458         (find_methods): Update.
11459         * minsyms.c (find_solib_trampoline_target): Update.
11460         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
11461         * coffread.c (coff_symfile_read): Update.
11462         * ada-lang.c (ada_lookup_simple_minsym)
11463         (ada_collect_symbol_completion_matches): Update.
11464
11465 2019-01-16  Tom Tromey  <tom@tromey.com>
11466
11467         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
11468         type.  Remove no-argument constructor.
11469         <iterator::operator++>: Simplify.
11470         <begin>: Update.
11471         <end>: Use minimal_symbol_count.
11472
11473 2019-01-16  Tom Tromey  <tom@tromey.com>
11474
11475         * objfiles.h (struct objfile) <psymtabs>: New method.
11476         (class objfile_psymtabs): Remove.
11477         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
11478         typedef.
11479         <range>: New method.
11480         (require_partial_symbols): Change return type.
11481         * psymtab.c (require_partial_symbols)
11482         (psym_expand_symtabs_matching): Update.
11483         * mdebugread.c (parse_partial_symbols): Update.
11484         * dbxread.c (dbx_end_psymtab): Update.
11485
11486 2019-01-15  Tom Tromey  <tom@tromey.com>
11487
11488         * symtab.c (lookup_objfile_from_block)
11489         (lookup_symbol_in_objfile_symtabs)
11490         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
11491         (find_line_symtab, info_sources_command)
11492         (default_collect_symbol_completion_matches_break_on)
11493         (make_source_files_completion_list): Update.
11494         * symmisc.c (print_objfile_statistics, dump_objfile)
11495         (maintenance_print_symbols, maintenance_info_symtabs)
11496         (maintenance_check_symtabs, maintenance_info_line_tables):
11497         Update.
11498         * source.c (select_source_symtab)
11499         (forget_cached_source_info_for_objfile): Update.
11500         * objfiles.h (class objfile_compunits): Remove.
11501         (struct objfile) <compunits_range>: New typedef.
11502         (compunits): New method.
11503         * objfiles.c (objfile_relocate1): Update.
11504         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11505         * maint.c (count_symtabs_and_blocks): Update.
11506         * linespec.c (iterate_over_all_matching_symtabs): Update.
11507         * cp-support.c (add_symbol_overload_list_qualified): Update.
11508         * coffread.c (coff_symtab_read): Update.
11509         * ada-lang.c (add_nonlocal_symbols)
11510         (ada_collect_symbol_completion_matches)
11511         (ada_add_global_exceptions): Update.
11512
11513 2019-01-15  Tom Tromey  <tom@tromey.com>
11514
11515         * progspace.h (program_space) <objfiles_safe_range>: New
11516         typedef.
11517         <objfiles_safe>: New method.
11518         * objfiles.h (class all_objfiles_safe): Remove.
11519         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
11520         * jit.c (jit_inferior_exit_hook): Update.
11521
11522 2019-01-17  Tom Tromey  <tom@tromey.com>
11523
11524         * progspace.h (program_space) <objfiles_range>: New typedef.
11525         <objfiles>: New method.
11526         <objfiles_head>: Rename from objfiles.
11527         (object_files): Update.
11528         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
11529         * guile/scm-pretty-print.c
11530         (ppscm_find_pretty_printer_from_objfiles): Update.
11531         * guile/scm-objfile.c (gdbscm_objfiles): Update.
11532         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
11533         Update.
11534         * python/py-progspace.c (pspy_get_objfiles): Update.
11535         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11536         Update.
11537         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11538         (objfpy_lookup_objfile_by_build_id): Update.
11539         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11540         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11541         Update.
11542         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11543         (expand_symtab_containing_pc, lookup_objfile_from_block)
11544         (lookup_static_symbol, basic_lookup_transparent_type)
11545         (find_pc_sect_compunit_symtab, find_symbol_at_address)
11546         (find_line_symtab, info_sources_command)
11547         (default_collect_symbol_completion_matches_break_on)
11548         (make_source_files_completion_list, find_main_name): Update.
11549         * symmisc.c (print_symbol_bcache_statistics)
11550         (print_objfile_statistics, maintenance_print_symbols)
11551         (maintenance_print_msymbols, maintenance_print_objfiles)
11552         (maintenance_info_symtabs, maintenance_check_symtabs)
11553         (maintenance_expand_symtabs, maintenance_info_line_tables):
11554         Update.
11555         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
11556         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
11557         (map_overlay_command, unmap_overlay_command)
11558         (simple_overlay_update, expand_symtabs_matching)
11559         (map_symbol_filenames): Update.
11560         * symfile-debug.c (set_debug_symfile): Update.
11561         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
11562         Update.
11563         * source.c (select_source_symtab, forget_cached_source_info):
11564         Update.
11565         * solib.c (solib_read_symbols): Update.
11566         * solib-spu.c (append_ocl_sos): Update.
11567         * psymtab.c (maintenance_print_psymbols)
11568         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
11569         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
11570         * printcmd.c (info_symbol_command): Update.
11571         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
11572         Update.
11573         * objfiles.h (class all_objfiles): Remove.
11574         * objfiles.c (have_partial_symbols, have_full_symbols)
11575         (have_minimal_symbols, qsort_cmp, update_section_map)
11576         (shared_objfile_contains_address_p)
11577         (default_iterate_over_objfiles_in_search_order): Update.
11578         * objc-lang.c (info_selectors_command, info_classes_command)
11579         (find_methods): Update.
11580         * minsyms.c (find_solib_trampoline_target): Update.
11581         * maint.c (maintenance_info_sections)
11582         (maintenance_translate_address, count_symtabs_and_blocks):
11583         Update.
11584         * main.c (captured_main_1): Update.
11585         * linux-thread-db.c (try_thread_db_load_from_pdir)
11586         (has_libpthread): Update.
11587         * linespec.c (iterate_over_all_matching_symtabs)
11588         (search_minsyms_for_name): Update.
11589         * jit.c (jit_find_objf_with_entry_addr): Update.
11590         * hppa-tdep.c (find_unwind_entry)
11591         (hppa_lookup_stub_minimal_symbol): Update.
11592         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
11593         Update.
11594         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11595         (elf_gnu_ifunc_resolve_by_got): Update.
11596         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
11597         * dwarf-index-write.c (save_gdb_index_command): Update.
11598         * cp-support.c (add_symbol_overload_list_qualified): Update.
11599         * breakpoint.c (create_overlay_event_breakpoint)
11600         (create_longjmp_master_breakpoint)
11601         (create_std_terminate_master_breakpoint)
11602         (create_exception_master_breakpoint): Update.
11603         * blockframe.c (find_pc_partial_function): Update.
11604         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
11605         (ada_collect_symbol_completion_matches)
11606         (ada_add_global_exceptions): Update.
11607
11608 2019-01-17  Tom Tromey  <tom@tromey.com>
11609
11610         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
11611         declare VEC.
11612         (solib_target_parse_libraries): Change return type.
11613         (library_list_start_segment, library_list_start_section)
11614         (library_list_end_library, library_list_start_library); Update.
11615         (solib_target_free_library_list): Remove.
11616         (solib_target_parse_libraries): Remove cleanup.  Change return
11617         type.
11618         (solib_target_current_sos): Update.
11619
11620 2019-01-17  Tom Tromey  <tromey@bapiya>
11621
11622         * valprint.c: Replace "the the" with "the".
11623         * symtab.c: Replace "the the" with "the".
11624         * solib.c: Replace "the the" with "the".
11625         * solib-dsbt.c: Replace "the the" with "the".
11626         * linespec.c: Replace "the the" with "the".
11627         * dwarf2loc.h: Replace "the the" with "the".
11628         * amd64-windows-tdep.c: Replace "the the" with "the".
11629         * aarch64-tdep.c: Replace "the the" with "the".
11630
11631 2019-01-16  Keith Seitz  <keiths@redhat.com>
11632
11633         PR gdb/23773
11634         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
11635         <builder>: Rename to ..
11636         <m_builder>: ... this and make private.
11637         (dwarf2_cu::get_builder): New method.  Change all users of
11638         `builder' to use this method.
11639         (dwarf2_start_symtab): Move to ...
11640         (dwarf2_cu::start_symtab): ... here.  Update all callers
11641         (setup_type_unit_groups): Move to ...
11642         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
11643         callers.
11644         (dwarf2_cu::reset_builder): New method.
11645         (process_full_compunit, process_full_type_unit): Use
11646         dwarf2_cu::reset_builder.
11647         (follow_die_offset): Record the ancestor CU if it is different
11648         from the followed DIE's CU.
11649         (follow_die_sig_1): Likewise.
11650
11651 2019-01-15  Tom Tromey  <tom@tromey.com>
11652
11653         * remote.c (class remote_state) <buf>: Now a char_vector.
11654         <buf_size>: Remove.
11655         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
11656         parameter.
11657         (remote_target::getpkt_or_notif_sane_1)
11658         (remote_target::getpkt_sane)
11659         (remote_target::getpkt_or_notif_sane): Likewise.
11660         (class remote_target) <putpkt>: New overload.
11661         (remote_target::read_frame): Change type of "buf_p".  Remove
11662         sizeof_p parameter.
11663         (packet_ok): New overload.
11664         (packet_check_result): New overload.
11665         Update all uses.
11666
11667 2019-01-14  Tom Tromey  <tom@tromey.com>
11668
11669         * remote-notif.c (handle_notification, remote_notif_ack)
11670         (remote_notif_parse): Make "buf" const.
11671         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
11672         const.
11673         (remote_notif_parse, remote_notif_ack, handle_notification):
11674         Likewise.
11675         * remote.c (remote_notif_stop_parse): Make "buf" const.
11676         (remote_target::remote_parse_stop_reply): Make "buf" const.
11677         (remote_notif_stop_ack): Make "buf" const.
11678
11679 2019-01-14  Tom Tromey  <tom@tromey.com>
11680
11681         * remote.c (remote_console_output): Make parameter const.
11682
11683 2019-01-14  Tom Tromey  <tom@tromey.com>
11684
11685         * target-debug.h (target_debug_print_signals): Constify.
11686         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
11687         * procfs.c (procfs_target::pass_signals): Update.
11688         * linux-nat.c (linux_nat_target::pass_signals): Update.
11689         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
11690         * target-delegates.c: Rebuild.
11691         * remote.c (remote_target::program_signals): Update.
11692         (remote_target::pass_signals): Update.
11693         * target.c (target_pass_signals): Constify argument.
11694         (target_program_signals): Likewise.
11695         * target.h (struct target_ops) <pass_signals, program_signals>:
11696         Constify argument.
11697         (target_pass_signals, target_program_signals): Constify argument.
11698
11699 2019-01-14  Tom Tromey  <tom@tromey.com>
11700
11701         PR tui/28819:
11702         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
11703
11704 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
11705
11706         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
11707         field.
11708         * rs6000-tdep.c: Include reggroups.h.
11709         (IS_V_ALIAS_PSEUDOREG): Define.
11710         (rs6000_register_name): Return names for the "vX" aliases.
11711         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
11712         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
11713         aliases.  Call default_register_reggroup_p for all other
11714         pseudo-registers.
11715         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
11716         New functions.
11717         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
11718         Handle "vX" aliases.
11719         (v_alias_pseudo_register_collect): New function.
11720         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
11721         (rs6000_gdbarch_init): Initialize "vX" aliases as
11722         pseudo-registers.  Restore registration of
11723         rs6000_pseudo_register_reggroup_p with
11724         set_tdesc_pseudo_register_reggroup_p.
11725
11726 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
11727
11728         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
11729         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
11730         set_gdbarch_num_pseudo_regs.
11731
11732 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11733
11734         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
11735         Remove arg prefixname, add do_set and do_show.
11736         Add member functions set_list and show_list.
11737         * cli/cli-style.c (class cli_style_option): Update accordingly.
11738         (style_set_list): Move to file scope.
11739         (style_show_list): Likewise.
11740         (set_style): Call help_list.
11741         (show_style): Call cmd_show_list.
11742         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
11743         Update to use the new macro.
11744
11745 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
11746
11747         * ada-lang.c (_initialize_ada_language): Expand the help text
11748         for the "catch exception" command.
11749
11750 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11751
11752         * symtab.c (matching_obj_sections): Initialize obj,
11753         declare it closer to its usage.
11754
11755 2019-01-10  Tom Tromey  <tom@tromey.com>
11756
11757         * thread-iter.h (inf_threads_iterator): Use next_iterator.
11758         (basic_inf_threads_range): Remove.
11759         (inf_threads_range, inf_non_exited_threads_range)
11760         (safe_inf_threads_range): Use next_adapter.
11761
11762 2019-01-10  Keith Seitz  <keiths@redhat.com>
11763
11764         PR gdb/23712
11765         PR symtab/23010
11766         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
11767         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
11768
11769 2019-01-10  Keith Seitz  <keiths@redhat.com>
11770
11771         PR gdb/23712
11772         PR symtab/23010
11773         * dictionary.c (pending_to_vector): Remove.
11774         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11775         Remove _1 suffix, replacing functions of the same name.  Update
11776         all callers.
11777         (dict_create_hashed, dict_create_hashed_expandable)
11778         (dict_create_linear, dict_create_linear_expandable, dict_free)
11779         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
11780         Make functions static.
11781
11782 2019-01-10  Keith Seitz  <keiths@redhat.com>
11783
11784         PR gdb/23712
11785         PR symtab/23010
11786         * dictionary.h (struct dictionary): Replace declaration with
11787         multidictionary.
11788         (dict_create_hashed, dict_create_hashed_expandable)
11789         (dict_create_linear, dict_create_linear_expandable)
11790         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
11791         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
11792         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
11793         taking multidictionary argument.
11794         [ALL_DICT_SYMBOLS]: Update for multidictionary.
11795         * block.h (struct block) <dict>: Change to multidictionary
11796         and rename `multidict'.
11797         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
11798         symmisc.c: Update all dictionary references to multidictionary.
11799
11800 2019-01-10  Keith Seitz  <keiths@redhat.com>
11801
11802         PR gdb/23712
11803         PR symtab/23010
11804         * dictionary.c: Include unordered_map.
11805         (pending_to_vector): New function.
11806         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11807         Rewrite the non-"_1" functions to take vector instead
11808         of linked list.
11809         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
11810         "new" _1 versions of the same name.
11811         (multidictionary): Define.
11812         (std::hash<enum language): New definition.
11813         (collate_pending_symbols_by_language, mdict_create_hashed)
11814         (mdict_create_hashed_expandable, mdict_create_linear)
11815         (mdict_create_linear_expandable, mdict_free)
11816         (find_language_dictionary, create_new_language_dictionary)
11817         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
11818         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
11819         (mdict_size, mdict_empty): New functions.
11820         * dictionary.h (mdict_iterator): Define.
11821
11822 2019-01-10  Pedro Alves  <palves@redhat.com>
11823
11824         * breakpoint.c (read_uploaded_action)
11825         (create_tracepoint_from_upload): Adjust to use
11826         gdb::unique_xmalloc_ptr.
11827         * ctf.c (ctf_write_uploaded_tp):
11828         (SET_ARRAY_FIELD): Use emplace_back.
11829         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
11830         * tracefile-tfile.c (tfile_write_uploaded_tp):
11831         * tracepoint.c (parse_tracepoint_definition): Adjust to use
11832         gdb::unique_xmalloc_ptr.
11833         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
11834         at_string, cond_string, cmd_strings>: Replace char pointers
11835         with gdb::unique_xmalloc_ptr.
11836
11837 2019-01-10  Pedro Alves  <palves@redhat.com>
11838
11839         * solib-target.c (library_list_start_library): Don't xstrdup name.
11840
11841 2019-01-10  Pedro Alves  <palves@redhat.com>
11842
11843         * mdebugread.c (parse_partial_symbols): Use
11844         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
11845
11846 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11847
11848         * linux-fork.c (scoped_switch_fork_info)
11849         <~scoped_switch_fork_info>: Fix incorrect variable name.
11850
11851 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11852
11853         * linux-fork.c (scoped_switch_fork_info)
11854         <scoped_switch_fork_info>: Make explicit.
11855         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
11856
11857 2019-01-10  Tom Tromey  <tom@tromey.com>
11858
11859         * objfiles.h (objfile::reset_psymtabs): Update.
11860         * objfiles.c (objfile::objfile): Update.
11861         * psymtab.h (psymtab_storage::obstack): Update.
11862         (psymtab_storage::m_obstack): Use gdb::optional.
11863         (class psymtab_storage): Update comment.  Remove objfile
11864         parameter.
11865         * psymtab.c (psymtab_storage::psymtab_storage): Update.
11866
11867 2019-01-10  Tom Tromey  <tom@tromey.com>
11868
11869         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
11870         <free_psymtabs>: Now private.
11871         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
11872         (allocate_psymtab): Use new method.
11873
11874 2019-01-10  Tom Tromey  <tom@tromey.com>
11875
11876         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
11877         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
11878         * mdebugread.c (parse_partial_symbols): Use
11879         allocate_dependencies.
11880         * dwarf2read.c (dwarf2_create_include_psymtab): Use
11881         allocate_dependencies.
11882         (process_psymtab_comp_unit_reader)
11883         (build_type_psymtab_dependencies): Likewise.
11884         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
11885
11886 2019-01-10  Tom Tromey  <tom@tromey.com>
11887
11888         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
11889         PSYMBOL_SET_LANGUAGE.
11890         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
11891
11892 2019-01-10  Tom Tromey  <tom@tromey.com>
11893
11894         * psymtab.h (psymtab_storage::obstack): New method.
11895         <m_obstack>: Rename from obstack; now private.
11896         * psymtab.c (psymtab_storage): Update.
11897         * dwarf2read.c (create_addrmap_from_index)
11898         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
11899         Update.
11900
11901 2019-01-10  Tom Tromey  <tom@tromey.com>
11902
11903         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
11904         * objfiles.h (objfile::reset_psymtabs): New method.
11905
11906 2019-01-10  Tom Tromey  <tom@tromey.com>
11907
11908         * symmisc.c (print_symbol_bcache_statistics): Update.
11909         (print_objfile_statistics): Update.
11910         * symfile.c (reread_symbols): Update.
11911         * psymtab.h (class psymtab_storage): New.
11912         * psymtab.c (psymtab_storage): New constructor.
11913         (~psymtab_storage): New destructor.
11914         (require_partial_symbols): Update.
11915         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11916         (find_pc_sect_psymtab, find_pc_sect_psymbol)
11917         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11918         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11919         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
11920         (start_psymtab_common, end_psymtab_common)
11921         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
11922         (allocate_psymtab): Update.
11923         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
11924         Update.
11925         (dump_psymtab_addrmap, maintenance_print_psymbols)
11926         (maintenance_check_psymtabs): Update.
11927         (class objfile_psymtabs): Move to objfiles.h.
11928         * psympriv.h (discard_psymtab): Now inline.
11929         (psymtab_discarder::psymtab_discarder): Update.
11930         (psymtab_discarder::~psymtab_discarder): Update.
11931         (ALL_OBJFILE_PSYMTABS): Rewrite.
11932         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11933         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11934         Remove fields.
11935         <partial_symtabs>: New field.
11936         (class objfile_psymtabs): Move from psymtab.h.  Update.
11937         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11938         psymbol_cache.
11939         (objfile::~objfile): Don't destroy psymbol_cache.
11940         * mdebugread.c (parse_partial_symbols): Update.
11941         * dwarf2read.c (create_addrmap_from_index)
11942         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11943         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11944         (add_partial_subprogram, dwarf2_ranges_read): Update.
11945         * dwarf-index-write.c (write_address_map)
11946         (write_one_signatured_type, recursively_write_psymbols)
11947         (class debug_names, class debug_names, write_psymtabs_to_index):
11948         Update.
11949
11950 2019-01-10  Tom Tromey  <tom@tromey.com>
11951
11952         * symtab.h (SYMBOL_SET_NAMES): Update.
11953         (symbol_set_names): Update.
11954         (MSYMBOL_SET_NAMES): Update.
11955         * symtab.c (symbol_set_names): Change argument to be an
11956         objfile_per_bfd_storage.
11957         * psymtab.c (add_psymbol_to_bcache): Update.
11958         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11959
11960 2019-01-10  Tom Tromey  <tom@tromey.com>
11961
11962         * symtab.c (create_demangled_names_hash): Change argument to be an
11963         objfile_per_bfd_storage.
11964         (symbol_set_names): Update.
11965
11966 2019-01-10  Tom Tromey  <tom@tromey.com>
11967
11968         * xcoffread.c (xcoff_initial_scan): Unconditionally call
11969         init_psymbol_list.
11970         * psymtab.c (init_psymbol_list): Do nothing if already called.
11971         * psympriv.h (init_psymbol_list): Add comment.
11972         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11973         init_psymbol_list.
11974         * dbxread.c (dbx_symfile_read): Unconditionally call
11975         init_psymbol_list.
11976
11977 2019-01-10  Tom Tromey  <tom@tromey.com>
11978
11979         * xcoffread.c (scan_xcoff_symtab): Update.
11980         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11981         "where".
11982         * mdebugread.c (parse_partial_symbols)
11983         (handle_psymbol_enumerators): Update.
11984         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11985         * dbxread.c (read_dbx_symtab): Update.
11986         * psympriv.h (psymbol_placement): New enum.
11987         (add_psymbol_to_list): Update.
11988
11989 2019-01-10  Tom Tromey  <tom@tromey.com>
11990
11991         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11992         static_psymbols parameters.
11993         (scan_xcoff_symtab): Update.
11994         * psymtab.c (start_psymtab_common): Remove global_psymbols and
11995         static_psymbols parameters.
11996         * psympriv.h (start_psymtab_common): Update.
11997         * mdebugread.c (parse_partial_symbols): Update.
11998         * dwarf2read.c (create_partial_symtab): Update.
11999         * dbxread.c (read_dbx_symtab): Update.
12000         (start_psymtab): Remove global_psymbols and static_psymbols
12001         parameters.
12002
12003 2019-01-10  Tom Tromey  <tom@tromey.com>
12004
12005         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
12006         * psymtab.c (allocate_psymtab): Add comment.
12007         * psympriv.h (allocate_psymtab): Add comment.
12008         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
12009         initializations.
12010         * dbxread.c (dbx_end_psymtab): Remove some initializations.
12011
12012 2019-01-10  Tom Tromey  <tom@tromey.com>
12013
12014         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12015         Don't declare.
12016         * mipsread.c: Include mdebugread.h.
12017         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12018         Declare.
12019         * elfread.c: Include mdebugread.h.
12020
12021 2019-01-09  Tom Tromey  <tom@tromey.com>
12022
12023         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
12024         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
12025         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
12026         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
12027         (psym_lookup_symbol, psym_find_last_source_symtab)
12028         (psym_forget_cached_source_info, psym_print_stats)
12029         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
12030         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
12031         (psym_map_matching_symbols, psym_expand_symtabs_matching)
12032         (psym_find_compunit_symtab_by_address)
12033         (maintenance_print_psymbols, maintenance_info_psymtabs)
12034         (maintenance_check_psymtabs): Use ranged for.
12035         * psymtab.h (class objfile_psymtabs): New.
12036         (require_partial_symbols): Return objfile_psymtabs.
12037         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
12038
12039 2019-01-09  Tom Tromey  <tom@tromey.com>
12040
12041         * symfile.c (overlay_invalidate_all, find_pc_overlay)
12042         (find_pc_mapped_section, list_overlays_command)
12043         (map_overlay_command, unmap_overlay_command)
12044         (simple_overlay_update): Use all_objfiles.
12045         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
12046         * printcmd.c (info_symbol_command): Use all_objfiles.
12047         * objfiles.h (ALL_OBJSECTIONS): Remove.
12048         * maint.c (maintenance_translate_address): Use all_objfiles.
12049         * gcore.c (gcore_create_callback): Use all_objfiles.
12050         (objfile_find_memory_regions): Likewise.
12051
12052 2019-01-09  Tom Tromey  <tom@tromey.com>
12053
12054         * symtab.c (find_line_symtab, info_sources_command)
12055         (make_source_files_completion_list): Use objfile_compunits.
12056         * source.c (select_source_symtab): Use objfile_compunits.
12057         * objfiles.h (struct objfile): Update comment.
12058         (ALL_OBJFILES): Remove.
12059         (ALL_FILETABS): Remove.
12060         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
12061         objfile_compunits.
12062
12063 2019-01-09  Tom Tromey  <tom@tromey.com>
12064
12065         * symmisc.c (print_objfile_statistics, dump_objfile)
12066         (maintenance_print_symbols): Use compunit_filetabs.
12067         * source.c (forget_cached_source_info_for_objfile): Use
12068         compunit_filetabs.
12069         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
12070         (ALL_FILETABS): Use compunit_filetabs.
12071         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
12072         * coffread.c (coff_symtab_read): Use compunit_filetabs.
12073
12074 2019-01-09  Tom Tromey  <tom@tromey.com>
12075
12076         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
12077         (compunit_filetabs): New.
12078         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
12079         compunit_filetabs.
12080         (info_sources_command, make_source_files_completion_list): Remove
12081         declaration.
12082         * symmisc.c (print_objfile_statistics, dump_objfile)
12083         (maintenance_print_symbols): Remove declaration.
12084         (maintenance_info_symtabs): Use compunit_filetabs.
12085         (maintenance_info_line_tables): Likewise.
12086         * source.c (select_source_symtab): Change local variable name.
12087         (forget_cached_source_info_for_objfile): Remove declaration.
12088         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
12089         * objfiles.c (objfile_relocate1): Remove declaration.
12090         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12091         declaration.
12092         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
12093         * coffread.c (coff_symtab_read): Remove declaration.
12094         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
12095         compunit_filetabs.
12096
12097 2019-01-09  Tom Tromey  <tom@tromey.com>
12098
12099         * symtab.c (lookup_objfile_from_block)
12100         (find_pc_sect_compunit_symtab, search_symbols)
12101         (default_collect_symbol_completion_matches_break_on): Use
12102         objfile_compunits.
12103         * objfiles.h (ALL_COMPUNITS): Remove.
12104         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
12105         * cp-support.c (add_symbol_overload_list_qualified): Use
12106         objfile_compunits.
12107         * ada-lang.c (ada_collect_symbol_completion_matches)
12108         (ada_add_global_exceptions): Use objfile_compunits.
12109
12110 2019-01-09  Tom Tromey  <tom@tromey.com>
12111
12112         * source.c (select_source_symtab)
12113         (forget_cached_source_info_for_objfile): Remove declaration.
12114         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12115         declaration.
12116         * maint.c (count_symtabs_and_blocks): Remove declaration.
12117         * cp-support.c (add_symbol_overload_list_qualified): Remove
12118         declaration.
12119         * coffread.c (coff_symtab_read): Remove declaration.
12120         * symtab.c (lookup_symbol_in_objfile_symtabs)
12121         (basic_lookup_transparent_type_1): Use objfile_compunits.
12122         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
12123         (info_sources_command, search_symbols)
12124         (default_collect_symbol_completion_matches_break_on)
12125         (make_source_files_completion_list): Remove declaration.
12126         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
12127         (ada_collect_symbol_completion_matches)
12128         (ada_add_global_exceptions): Remove declaration.
12129         * linespec.c (iterate_over_all_matching_symtabs): Use
12130         objfile_compunits.
12131         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
12132         (class objfile_compunits): New.
12133         (ALL_COMPUNITS): Use objfile_compunits.
12134         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
12135         (maintenance_check_symtabs, maintenance_info_line_tables): Use
12136         objfile_compunits.
12137         * objfiles.c (objfile_relocate1): Use objfile_compunits.
12138
12139 2019-01-09  Tom Tromey  <tom@tromey.com>
12140
12141         * symtab.c (search_symbols)
12142         (default_collect_symbol_completion_matches_break_on): Use
12143         objfile_msymbols.
12144         * ada-lang.c (ada_lookup_simple_minsym)
12145         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
12146         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
12147         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
12148         objfile_msymbols.
12149         * coffread.c (coff_symfile_read): Use objfile_msymbols.
12150         * symmisc.c (dump_msymbols): Use objfile_msymbols.
12151         * objc-lang.c (find_methods): Use objfile_msymbols.
12152         (info_selectors_command, info_classes_command): Likewise.
12153         * stabsread.c (scan_file_globals): Use objfile_msymbols.
12154         * objfiles.h (class objfile_msymbols): New.
12155         (ALL_OBJFILE_MSYMBOLS): Remove.
12156         (ALL_MSYMBOLS): Remove.
12157
12158 2019-01-09  Tom Tromey  <tom@tromey.com>
12159
12160         * common/next-iterator.h (next_adapter): Add Iterator template
12161         parameter.
12162         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
12163         (class all_objfiles_safe): New.
12164         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
12165         * objfiles.c (put_objfile_before): Update comment.
12166         (add_separate_debug_objfile): Likewise.
12167         (free_all_objfiles): Use all_objfiles_safe.
12168         (objfile_purge_solibs): Likewise.
12169
12170 2019-01-09  Tom Tromey  <tom@tromey.com>
12171
12172         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12173         (expand_symtab_containing_pc, lookup_static_symbol)
12174         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
12175         (find_symbol_at_address, find_line_symtab, find_main_name): Use
12176         all_objfiles.
12177         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
12178         * breakpoint.c (create_overlay_event_breakpoint)
12179         (create_longjmp_master_breakpoint)
12180         (create_std_terminate_master_breakpoint)
12181         (create_exception_master_breakpoint): Use all_objfiles.
12182         * linux-thread-db.c (try_thread_db_load_from_pdir)
12183         (has_libpthread): Use all_objfiles.
12184         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
12185         * linespec.c (iterate_over_all_matching_symtabs)
12186         (search_minsyms_for_name): Use all_objfiles.
12187         * maint.c (maintenance_info_sections): Use all_objfiles.
12188         * main.c (captured_main_1): Use all_objfiles.
12189         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
12190         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
12191         * guile/scm-pretty-print.c
12192         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
12193         * solib-spu.c (append_ocl_sos): Use all_objfiles.
12194         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
12195         (maintenance_print_msymbols): Use all_objfiles.
12196         * source.c (select_source_symtab): Use all_objfiles.
12197         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
12198         * symfile.c (remove_symbol_file_command)
12199         (expand_symtabs_matching, map_symbol_filenames): Use
12200         all_objfiles.
12201         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
12202         all_objfiles.
12203         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
12204         * objc-lang.c (find_methods): Use all_objfiles.
12205         * objfiles.c (have_partial_symbols, have_full_symbols)
12206         (have_minimal_symbols, qsort_cmp)
12207         (default_iterate_over_objfiles_in_search_order): Use
12208         all_objfiles.
12209         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
12210         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
12211         (maintenance_check_psymtabs): Use all_objfiles.
12212         (ALL_PSYMTABS): Remove.
12213         * compile/compile-object-run.c (do_module_cleanup): Use
12214         all_objfiles.
12215         * blockframe.c (find_pc_partial_function): Use all_objfiles.
12216         * cp-support.c (add_symbol_overload_list_qualified): Use
12217         all_objfiles.
12218         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12219         Use all_objfiles.
12220         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
12221         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
12222         all_objfiles.
12223         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12224         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
12225         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12226         Uses all_objfiles.
12227         * solib.c (solib_read_symbols): Use all_objfiles
12228
12229 2019-01-09  Tom Tromey  <tom@tromey.com>
12230
12231         * probe.c (parse_probes_in_pspace): Use all_objfiles.
12232         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
12233         all_objfiles.
12234         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
12235         * symmisc.c (print_symbol_bcache_statistics)
12236         (print_objfile_statistics, maintenance_print_objfiles)
12237         (maintenance_info_symtabs, maintenance_check_symtabs)
12238         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
12239         all_objfiles.
12240         * source.c (forget_cached_source_info): Use all_objfiles.
12241         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
12242         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12243         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
12244         * objfiles.c (update_section_map): Use all_objfiles.
12245         (shared_objfile_contains_address_p): Likewise.
12246         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
12247         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
12248
12249 2019-01-09  Tom Tromey  <tom@tromey.com>
12250
12251         * common/next-iterator.h: New file.
12252         * objfiles.h (class all_objfiles): New.
12253         (struct objfile_iterator): New.
12254
12255 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12256
12257         * NEWS: Move the description of the changed "frame", "select-frame",
12258          and "info frame" commands to the Changed commands section.
12259
12260 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
12261
12262         * gdbtypes.c (check_stub_method_group): Remove handling of old
12263         mangling schemes.
12264         * linespec.c (find_methods): Likewise.
12265         * stabsread.c (read_member_functions): Likewise.
12266         * valops.c (search_struct_method): Likewise.
12267         (value_struct_elt_for_reference): Likewise.
12268         * NEWS: Mention this change.
12269
12270 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
12271
12272         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
12273         print_source_lines.
12274         * source.c (print_source_lines_base): Update line number check.
12275         (print_source_lines): New function.
12276         (source_lines_range::source_lines_range): New function.
12277         * source.h (class source_lines_range): New class.
12278         (print_source_lines): New declaration.
12279
12280 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12281
12282         * linespec.c (linespec_state_destructor): Free self->canonical_names.
12283
12284 2019-01-08  Tom Tromey  <tom@tromey.com>
12285             Simon Marchi  <simon.marchi@ericsson.com>
12286
12287         PR gdb/24060
12288         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
12289         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
12290         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12291         * f-exp.y (DOLLAR_VARIABLE): Likewise.
12292         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
12293         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12294
12295 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12296
12297         * source.c (select_source_symtab): Move header comment to
12298         declaration in source.h.
12299         (forget_cached_source_info_for_objfile): Likewise.
12300         (forget_cached_source_info): Likewise.
12301         (identify_source_line): Likewise.
12302         * source.h (identify_source_line): Move declaration from symtab.h
12303         and add comment from source.c
12304         (print_source_lines): Likewise.
12305         (forget_cached_source_info_for_objfile): Likewise.
12306         (forget_cached_source_info): Likewise.
12307         (select_source_symtab): Likewise.
12308         (enum print_source_lines_flag): Move definition from symtab.h.
12309         * symtab.h (identify_source_line): Move declaration to source.h.
12310         (print_source_lines): Likewise.
12311         (forget_cached_source_info_for_objfile): Likewise.
12312         (forget_cached_source_info): Likewise.
12313         (select_source_symtab): Likewise.
12314         (enum print_source_lines_flag): Move definition to source.h.
12315         * tui/tui-hooks.c: Add 'source.h' include.
12316
12317 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12318
12319         * source.c (print_source_lines_base): Handle requests to print
12320         reverse line number sequences, and guard against empty lines
12321         string.
12322
12323 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12324
12325         * source.c (print_source_lines_base): Fix skip of '\r' if next
12326         character is '\n'.
12327
12328 2019-01-06  Tom Tromey  <tom@tromey.com>
12329
12330         * c-exp.y (struct c_parse_state) <macro_original_text,
12331         expansion_obstack>: New member.
12332         (macro_original_text, expansion_obstack): Remove globals.
12333         (scan_macro_expansion, scanning_macro_expansion)
12334         (finished_macro_expansion): Update.
12335         (scan_macro_cleanup): Remove.
12336         (yylex, c_parse): Update.
12337
12338 2019-01-06  Tom Tromey  <tom@tromey.com>
12339
12340         * c-exp.y (struct c_parse_state) <strings>: New member.
12341         (operator_stoken): Update.
12342
12343 2019-01-06  Tom Tromey  <tom@tromey.com>
12344
12345         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
12346         (union type_stack_elt) <typelist_val>: Now a pointer to
12347         std::vector.
12348         (type_stack_cleanup): Don't declare.
12349         (push_typelist): Update.
12350         * parse.c (pop_typelist): Return a std::vector.
12351         (push_typelist): Take a std::vector.
12352         (follow_types): Update.  Do not free args.
12353         (type_stack_cleanup): Remove.
12354         * c-exp.y (struct c_parse_state): New.
12355         (cpstate): New global.
12356         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
12357         (nonempty_typelist): Update.
12358         (func_mod): Create a new vector.
12359         (c_parse): Create a c_parse_state.
12360         (check_parameter_typelist): Do not delete params.
12361         (function_method): Update.  Do not delete type_list.
12362
12363 2019-01-06  Tom Tromey  <tom@tromey.com>
12364
12365         PR gdb/28155:
12366         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
12367         check_typedef.
12368         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
12369         (print_return_value): Likewise.
12370
12371 2019-01-05  Tom Tromey  <tom@tromey.com>
12372
12373         * contrib/cleanup_check.py: Remove.
12374         * contrib/gcc-with-excheck: Remove.
12375         * contrib/exsummary.py: Remove.
12376         * contrib/excheck.py: Remove.
12377
12378 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
12379
12380         * thread.c (delete_thread_1): Add gdb_assert that THR is not
12381         NULL. Initialize tpprev to NULL instead of assigning it
12382         to NULL on the next statement.
12383         * windows-nat.c (windows_delete_thread): Remove check for
12384         main_thread_id before printing thread exit notifications.
12385         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
12386         Remove thread ID check against main_thread_id.
12387         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
12388         windows_delete_thread.
12389         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
12390
12391 2019-01-04  Tom Tromey  <tom@tromey.com>
12392
12393         * compile/compile.c (_initialize_compile): Use upper case for
12394         metasyntactic variables.
12395         * symmisc.c (_initialize_symmisc): Use upper case for
12396         metasyntactic variables.
12397         * psymtab.c (_initialize_psymtab): Use upper case for
12398         metasyntactic variables.
12399         * demangle.c (demangle_command): Use upper case for metasyntactic
12400         variables.
12401         (_initialize_demangler): Likewise.
12402         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
12403         variables.
12404
12405 2019-01-03  Tom Tromey  <tom@tromey.com>
12406
12407         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
12408
12409 2019-01-03  Tom Tromey  <tom@tromey.com>
12410
12411         * python/py-symtab.c (salpy_str): Update.
12412         (struct salpy_sal_object) <symtab>: Now a PyObject.
12413         (salpy_dealloc): Update.
12414         (del_objfile_sal): Use gdbpy_ref.
12415
12416 2019-01-03  Tom Tromey  <tom@tromey.com>
12417
12418         * python/py-type.c (convert_field): Use new_reference.  Return
12419         gdbpy_ref.
12420         (make_fielditem): Return gdbpy_ref.
12421         (typy_fields): Update.
12422         (typy_getitem): Update.
12423         (field_name): Return gdbpy_ref.  Use new_reference.
12424         (typy_iterator_iternext): Update.
12425
12426 2019-01-03  Tom Tromey  <tom@tromey.com>
12427
12428         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
12429
12430 2019-01-03  Tom Tromey  <tom@tromey.com>
12431
12432         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
12433         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
12434         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
12435         (pspy_set_frame_filters, pspy_set_frame_unwinders)
12436         (pspy_set_type_printers): Likewise.
12437         * python/py-function.c (fnpy_init): Use gdbpy_ref.
12438         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
12439         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
12440         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
12441         (objfpy_set_type_printers): Likewise.
12442
12443 2019-01-03  Tom Tromey  <tom@tromey.com>
12444
12445         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
12446         (gdbpy_print_stack): Use gdbpy_err_fetch.
12447         * python/python-internal.h (class gdbpy_err_fetch): New class.
12448         (class gdbpy_enter) <m_error_type, m_error_value,
12449         m_error_traceback>: Remove.
12450         <m_error>: New member.
12451         (gdbpy_exception_to_string): Don't declare.
12452         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
12453         * python/py-value.c (convert_value_from_python): Use
12454         gdbpy_err_fetch.
12455         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
12456         gdbpy_exception_to_string.
12457         (gdbpy_handle_exception): Use gdbpy_err_fetch.
12458         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
12459         gdbpy_err_fetch.
12460
12461 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12462
12463         * linux-nat.c (delete_lwp_cleanup): Delete.
12464         (struct lwp_deleter): New struct.
12465         (lwp_info_up): New typedef.
12466         (linux_nat_target::follow_fork): Delete cleanup, and make use of
12467         lwp_info_up.
12468
12469 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12470
12471         * linux-fork.c (class scoped_switch_fork_info): New class.
12472         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
12473
12474 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12475
12476         * valops.c (find_overload_match): Remove use of null_cleanup, and
12477         calls to do_cleanups.
12478
12479 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12480
12481         * compile/compile-cplus-types.c
12482         (compile_cplus_instance::decl_name): Handle changes to
12483         cp_func_name.
12484         * cp-support.c (cp_func_name): Update header comment, update
12485         return type.
12486         * cp-support.h (cp_func_name): Update return type in declaration.
12487         * valops.c (find_overload_match): Move temp_func local to top
12488         level of function and change its type.  Use temp_func to hold and
12489         delete temporary string obtained from cp_func_name.
12490
12491 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12492
12493         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
12494         gdb::char_vector, remove cleanup, and update uses of `msg`.
12495
12496 2019-01-03  Jim Wilson  <jimw@sifive.com>
12497
12498         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
12499
12500 2019-01-02  Tom Tromey  <tom@tromey.com>
12501
12502         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
12503         (tdesc_parse_xml): Remove cleanups.
12504         * target-descriptions.h (make_cleanup_free_target_description):
12505         Don't declare.
12506         (target_desc_deleter): New struct.
12507         (target_desc_up): New typedef.
12508         * target-descriptions.c (target_desc_deleter::operator()): Rename
12509         from free_target_description.
12510         (make_cleanup_free_target_description): Remove.
12511
12512 2019-01-02  Tom Tromey  <tom@tromey.com>
12513
12514         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
12515         constructor, destructor.
12516         (linespec_parser): Remove typedef.
12517         (~linespec_parser): Rename from linespec_parser_delete.
12518         (linespec_lex_to_end, linespec_complete_label)
12519         (linespec_complete): Update.
12520         (decode_line_full): Remove cleanups.
12521         (decode_line_1): Update.
12522
12523 2019-01-02  Tom Tromey  <tom@tromey.com>
12524
12525         * python/python-internal.h (inferior_to_inferior_object): Change
12526         return type.
12527         * python/py-exitedevent.c (create_exited_event_object): Update.
12528         * python/py-inferior.c (inferior_to_inferior_object): Return
12529         gdbpy_ref.
12530         (python_new_inferior, python_inferior_deleted)
12531         (thread_to_thread_object, delete_thread_object)
12532         (build_inferior_list, gdbpy_selected_inferior): Update.
12533         * python/py-infthread.c (create_thread_object): Update.  Also fail
12534         if inferior_to_inferior_object fails.
12535
12536 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
12537
12538         * inferior.h (class inferior) <displaced_step_state>: New field.
12539         * infrun.h (struct displaced_step_state): Move here from
12540         infrun.c.  Initialize fields, add constructor.
12541         <inf>: Remove field.
12542         <reset>: New method.
12543         * infrun.c (struct displaced_step_inferior_state): Move to
12544         infrun.h.
12545         (displaced_step_inferior_states): Remove.
12546         (get_displaced_stepping_state): Adust.
12547         (displaced_step_in_progress_any_inferior): Adjust.
12548         (displaced_step_in_progress_thread): Adjust.
12549         (displaced_step_in_progress): Adjust.
12550         (add_displaced_stepping_state): Remove.
12551         (get_displaced_step_closure_by_addr): Adjust.
12552         (remove_displaced_stepping_state): Remove.
12553         (infrun_inferior_exit): Call displaced_step_state.reset.
12554         (use_displaced_stepping): Don't check for NULL.
12555         (displaced_step_prepare_throw): Call
12556         get_displaced_stepping_state.
12557         (displaced_step_fixup): Don't check for NULL.
12558         (prepare_for_detach): Don't check for NULL.
12559
12560 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12561
12562         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
12563          in case of call that did not complete.
12564
12565 2019-01-02  Andrey Utkin  <autkin@undo.io>
12566
12567         * symfile.c (find_separate_debug_file): Fix search of debug files for
12568         remote debuggee.
12569
12570 2019-01-02  Tom Tromey  <tom@tromey.com>
12571
12572         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
12573         indentation.
12574         * python/py-frame.c (frapy_older): Remove cast.
12575         (frapy_newer): Likewise.
12576         * python/py-breakpoint.c (local_setattro): Remove cast.
12577         * python/py-arch.c (archpy_name): Remove local variable.
12578         * python/py-type.c (gdbpy_lookup_type): Remove cast.
12579
12580 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
12581
12582         * unittests/basic_string_view/element_access/char/empty.cc:
12583         Fix year range in copyright header.
12584
12585 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12586
12587         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
12588         Delete.
12589         <operator==>: Update with for removed field.
12590         <hash>: Likewise.
12591         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
12592         <isa_features>: ...this.
12593         <abi_features>: New field.
12594         (riscv_isa_flen): Update comment.
12595         (riscv_abi_xlen): New declaration.
12596         (riscv_abi_flen): New declaration.
12597         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
12598         isa_features.
12599         (riscv_abi_xlen): New function.
12600         (riscv_isa_flen): Update to get answer from isa_features.
12601         (riscv_abi_flen): New function.
12602         (riscv_has_fp_abi): Update to get answer from abi_features.
12603         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
12604         xlen and flen.
12605         (riscv_call_info) <xlen, flen>: Update comment.
12606         (riscv_call_arg_struct): Remove invalid assertions
12607         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
12608         is removed.
12609         (riscv_gdbarch_init): Gather isa features and abi features
12610         separately, ensure both match on the gdbarch when reusing an old
12611         gdbarch.  Relax an error check to allow 32-bit abi float to run on
12612         a target with 64-bit float hardware.
12613
12614 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12615
12616         * source.c (search_command_helper): Stop reverse search
12617         when line 1 has been searched.
12618
12619 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12620
12621         * record-full.c (record_full_base_target::close): Rewrite
12622         record_full_core_buf_list free logic.
12623
12624 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12625
12626         * break-catch-syscall.c (print_one_catch_syscall): xfree
12627         the last text.
12628
12629 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12630
12631         * top.c (print_gdb_version): Update Copyright year in version
12632         message.
12633
12634 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12635
12636         Update copyright year range in all GDB files.
12637
12638 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
12639
12640         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
12641
12642 For older changes see ChangeLog-2018.
12643 \f
12644 Local Variables:
12645 mode: change-log
12646 left-margin: 8
12647 fill-column: 74
12648 version-control: never
12649 coding: utf-8
12650 End:
12651