gdb/ChangeLog

   1 2019-07-17  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui.c: Update.
   4         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
   5         tui-regs.c.
   6         * tui/tui-windata.h: Remove file.
   7         * tui/tui-windata.c: Remove file.
   8         * tui/tui-win.c (tui_data_window::set_new_height)
   9         (tui_data_window::do_make_visible_with_new_height): Move to
  10         tui-regs.c.
  11         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
  12         * tui/tui-regs.c: Remove "structuring" comments.
  13         (tui_data_window::first_data_item_displayed)
  14         (tui_data_window::delete_data_content_windows)
  15         (tui_data_window::erase_data_content)
  16         (tui_data_window::display_all_data)
  17         (tui_data_window::refresh_all)
  18         (tui_data_window::do_scroll_vertical)
  19         (tui_data_window::clear_detail, tui_data_window::set_new_height)
  20         (tui_data_window::do_make_visible_with_new_height)
  21         (tui_data_window::refresh_window): Move from elsewhere.
  22         (_initialize_tui_regs): Move to end of file.
  23         * tui/tui-layout.c: Update.
  24         * tui/tui-hooks.c: Update.
  25         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
  26         * tui/tui-data.c (tui_data_window::clear_detail): Move to
  27         tui-regs.c.
  28         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
  29
  30 2019-07-17  Tom Tromey  <tom@tromey.com>
  31
  32         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
  33         seen.
  34
  35 2019-07-17  Tom Tromey  <tom@tromey.com>
  36
  37         * tui/tui-win.c (tui_source_window_base::set_new_height)
  38         (tui_source_window_base::do_make_visible_with_new_height): Use
  39         m_has_locator field directly.
  40         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
  41         method.
  42         (struct tui_source_window_base) <has_locator>: Likewise.
  43
  44 2019-07-17  Tom Tromey  <tom@tromey.com>
  45
  46         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
  47         Don't declare.
  48         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
  49         Remove.
  50         * tui/tui-win.c (tui_source_window_base::set_new_height)
  51         (tui_source_window_base::set_new_height)
  52         (make_invisible_and_set_new_height)
  53         (tui_source_window_base::do_make_visible_with_new_height)
  54         (tui_source_window_base::do_make_visible_with_new_height):
  55         Update.
  56         * tui/tui-layout.c (show_source_disasm_command, show_data)
  57         (show_source_or_disasm_and_command): Update.
  58         * tui/tui-layout.c (show_layout): Update.
  59
  60 2019-07-17  Tom Tromey  <tom@tromey.com>
  61
  62         * tui/tui-layout.c (make_data_window): Remove.
  63         (show_data): Unify creation and re-initialization cases.
  64
  65 2019-07-17  Tom Tromey  <tom@tromey.com>
  66
  67         * tui/tui-layout.c (make_source_window, make_disasm_window):
  68         Remove.
  69         (show_data): Unify creation and re-initialization cases.
  70
  71 2019-07-17  Tom Tromey  <tom@tromey.com>
  72
  73         * tui/tui-layout.c (make_command_window): Remove.
  74         (show_source_disasm_command, show_source_or_disasm_and_command):
  75         Unify creation and re-initialization cases.
  76
  77 2019-07-17  Tom Tromey  <tom@tromey.com>
  78
  79         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
  80         creation and re-initialization cases.
  81
  82 2019-07-17  Tom Tromey  <tom@tromey.com>
  83
  84         * tui/tui-regs.c (tui_get_register): Return void.
  85
  86 2019-07-17  Tom Tromey  <tom@tromey.com>
  87
  88         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
  89         Simplify.
  90
  91 2019-07-17  Tom Tromey  <tom@tromey.com>
  92
  93         * tui/tui-layout.c (show_source_disasm_command): Simplify window
  94         resetting.
  95
  96 2019-07-17  Tom Tromey  <tom@tromey.com>
  97
  98         * tui/tui.h (tui_set_layout_by_name): Don't declare.
  99         * tui/tui-regs.c (tui_reg_layout): New function.
 100         (tui_show_registers, tui_reg_command): Use it.
 101         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
 102         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
 103         parameters.
 104         (tui_layout_command): Remove.
 105
 106 2019-07-17  Tom Tromey  <tom@tromey.com>
 107
 108         * tui/tui-layout.h (tui/tui-layout): Return void.
 109         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
 110
 111 2019-07-17  Tom Tromey  <tom@tromey.com>
 112
 113         * tui/tui-layout.c (show_source_disasm_command, show_data):
 114         Update.
 115         (reset_locator): Remove.
 116         (show_source_or_disasm_and_command): Update.
 117
 118 2019-07-17  Tom Tromey  <tom@tromey.com>
 119
 120         * tui/tui-source.c (tui_source_window_base::reset): Remove
 121         win_type parameter.
 122         * tui/tui-layout.c (make_command_window, make_source_window)
 123         (make_disasm_window, make_data_window)
 124         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
 125         (reset_locator, show_source_or_disasm_and_command): Update.
 126         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
 127         win_type parameter.
 128         (struct tui_source_window_base) <reset>: Likewise.
 129
 130 2019-07-17  Tom Tromey  <tom@tromey.com>
 131
 132         * tui/tui-layout.c (show_source_disasm_command): Use
 133         reset_locator.
 134         (reset_locator): New function.
 135         (init_and_make_win): Remove.
 136         (show_source_or_disasm_and_command): Use reset_locator.
 137
 138 2019-07-17  Tom Tromey  <tom@tromey.com>
 139
 140         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 141         condition.
 142         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 143         Remove condition.
 144         * tui/tui-source.c (tui_source_window_base::reset): New method.
 145         * tui/tui-layout.c (make_command_window): Don't call
 146         init_and_make_win.
 147         (make_source_window, make_disasm_window): Don't call
 148         make_source_or_disasm_window.
 149         (make_data_window): Don't call init_and_make_win.  Change calling
 150         convention.
 151         (show_source_disasm_command, show_data): Simplify.
 152         (make_source_or_disasm_window): Remove.
 153         (show_source_or_disasm_and_command): Simplify.
 154         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 155         (struct tui_source_window_base) <reset>: Likewise.
 156         <execution_info>: Remove initializer.
 157         * tui/tui-data.c (tui_source_window_base): Initialize
 158         execution_info.
 159
 160 2019-07-17  Tom Tromey  <tom@tromey.com>
 161
 162         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 163         variable.
 164
 165 2019-07-17  Tom Tromey  <tom@tromey.com>
 166
 167         * tui/tui.c (tui_rl_other_window): Update.
 168         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 169         superclass method first.  Always iterate over regs_content.
 170         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 171         method.
 172         * tui/tui-win.c (tui_set_focus_command): Update.
 173
 174 2019-07-17  Tom Tromey  <tom@tromey.com>
 175
 176         * tui/tui-win.c (tui_set_focus_command): Rename from
 177         tui_set_focus.  Call tui_enable.
 178         (tui_set_focus_command): Remove.
 179
 180 2019-07-17  Tom Tromey  <tom@tromey.com>
 181
 182         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 183         refresh_window.
 184         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 185         touchwin.
 186         (tui_data_window::refresh_window): Call refresh_window on data
 187         items.  Always call superclass refresh_window.
 188         (tui_win_info::refresh): Remove.
 189         (tui_source_window_base::refresh_window): Update.
 190         (tui_refresh_all): Update.
 191         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 192         refresh_window.
 193         (show_source_or_disasm_and_command): Likewise.
 194         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 195         (struct tui_source_window_base) <refresh>: Likewise.
 196
 197 2019-07-17  Tom Tromey  <tom@tromey.com>
 198
 199         * tui/tui-winsource.c (tui_clear_source_content)
 200         (tui_show_source_content): Update.
 201         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 202         whether content is empty.
 203         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 204         Remove.
 205
 206 2019-07-17  Tom Tromey  <tom@tromey.com>
 207
 208         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 209         window's contents.
 210         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 211         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 212
 213 2019-07-17  Tom Tromey  <tom@tromey.com>
 214
 215         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 216         (struct tui_data_item_window): Update.
 217
 218 2019-07-17  Tom Tromey  <tom@tromey.com>
 219
 220         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 221         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 222         defines.
 223
 224 2019-07-17  Tom Tromey  <tom@tromey.com>
 225
 226         * tui/tui-winsource.h (tui_erase_source_content)
 227         (tui_clear_source_content): Remove "display_prompt" parameter.
 228         * tui/tui-winsource.c (tui_update_source_window_as_is)
 229         (tui_update_source_windows_with_addr): Update.
 230         (tui_clear_source_content): Remove "display_prompt" parameter.
 231         (tui_erase_source_content): Likewise.  Simplify.
 232         (tui_show_source_content): Update.
 233         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 234         * tui/tui-stack.c (tui_show_frame_info): Update.
 235         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 236         Remove defines.
 237
 238 2019-07-17  Tom Tromey  <tom@tromey.com>
 239
 240         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 241         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 242         parameter.
 243         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 244         parameter.
 245
 246 2019-07-17  Tom Tromey  <tom@tromey.com>
 247
 248         * tui/tui-winsource.c (tui_clear_source_content)
 249         (tui_show_source_content, tui_show_exec_info_content)
 250         (tui_clear_exec_info_content): Update.
 251         * tui/tui-stack.c (tui_show_locator_content): Update.
 252         (tui_show_frame_info): Update.
 253         * tui/tui-source.h (tui_source_window): Don't declare.
 254         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 255         from tui_source_is_displayed.
 256         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 257         Remove field.
 258         (struct tui_source_window_base) <content_in_use>: New field.  Now
 259         bool.
 260         (struct tui_source_window) <showing_source_p>: New method.
 261         (TUI_SRC_WIN): Change cast.
 262         * tui/tui-data.c (tui_initialize_static_data): Update.
 263
 264 2019-07-17  Tom Tromey  <tom@tromey.com>
 265
 266         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 267         location_matches_p.
 268         * tui/tui-source.c (tui_source_window::location_matches_p): New
 269         method.
 270         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 271         method.
 272         * tui/tui-data.h (struct tui_source_window_base)
 273         <location_matches_p>: New method.
 274         (struct tui_source_window, struct tui_disasm_window)
 275         <location_matches_p>: Likewise.
 276
 277 2019-07-17  Tom Tromey  <tom@tromey.com>
 278
 279         * tui/tui-win.c (tui_set_win_height_command): Rename from
 280         tui_set_win_height.
 281         (tui_set_win_height_command): Remove.
 282
 283 2019-07-17  Tom Tromey  <tom@tromey.com>
 284
 285         * tui/tui-source.c (tui_source_window): New constructor.  Add
 286         observer.
 287         (~tui_source_window): New destructor.
 288         (tui_source_window::style_changed): New method.
 289         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 290         (tui_attach_detach_observers): Update.
 291         * tui/tui-data.h (struct tui_source_window): Make constructor not
 292         inline.  Add destructor.
 293         (struct tui_source_window) <style_changed>: New method.
 294         <m_observable>: New member.
 295
 296 2019-07-17  Tom Tromey  <tom@tromey.com>
 297
 298         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 299         * tui/tui-win.c (tui_resize_all): Fix typo.
 300
 301 2019-07-17  Tom Tromey  <tom@tromey.com>
 302
 303         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 304         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 305         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 306         * tui/tui-win.c (window_name_completer): Use foreach.
 307         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 308         (update_tab_width): Likewise.
 309         * tui/tui-layout.c (show_layout): Update.
 310         * tui/tui-data.h (class tui_window_iterator): New.
 311         (struct all_tui_windows): New.
 312         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 313
 314 2019-07-17  Tom Tromey  <tom@tromey.com>
 315
 316         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 317         parameter.  Don't reference globals.
 318         (tui_reg_command): Update.
 319
 320 2019-07-17  Tom Tromey  <tom@tromey.com>
 321
 322         * tui/tui-regs.c (tui_show_registers): Simplify.
 323
 324 2019-07-17  Tom Tromey  <tom@tromey.com>
 325
 326         * tui/tui-regs.c (tui_show_registers): Update.
 327         (tui_show_register_group): Add win_info parameter.
 328
 329 2019-07-17  Tom Tromey  <tom@tromey.com>
 330
 331         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 332         Rename from tui_display_reg_element_at_line.
 333         (tui_data_window::display_registers_from_line): Update.
 334         * tui/tui-data.h (struct tui_data_window)
 335         <display_reg_element_at_line>: New method.
 336
 337 2019-07-17  Tom Tromey  <tom@tromey.com>
 338
 339         * tui/tui-regs.h (tui_display_registers_from)
 340         (tui_display_registers_from_line): Don't declare.
 341         * tui/tui-windata.c (tui_data_window::display_all_data)
 342         (tui_data_window::refresh_all)
 343         (tui_data_window::do_scroll_vertical): Update.
 344         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 345         from tui_display_registers_from.
 346         (tui_display_reg_element_at_line): Update.
 347         (tui_data_window::display_registers_from_line): Rename from
 348         tui_display_registers_from_line.
 349         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 350         display_registers_from_line>: New methods.
 351
 352 2019-07-17  Tom Tromey  <tom@tromey.com>
 353
 354         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 355         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 356         from tui_erase_data_content.
 357         (tui_data_window::display_all_data)
 358         (tui_data_window::refresh_all)
 359         (tui_data_window::do_scroll_vertical): Update.
 360         * tui/tui-regs.c (tui_show_registers): Update.
 361         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 362         New method.
 363
 364 2019-07-17  Tom Tromey  <tom@tromey.com>
 365
 366         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 367         declare.
 368         * tui/tui-windata.c
 369         (tui_data_window::delete_data_content_windows): Rename from
 370         tui_delete_data_content_windows.
 371         (tui_data_window::display_all_data)
 372         (tui_data_window::do_scroll_vertical): Update.
 373         * tui/tui-data.h (struct tui_data_window)
 374         <delete_data_content_windows>: New method.
 375
 376 2019-07-17  Tom Tromey  <tom@tromey.com>
 377
 378         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 379         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 380
 381 2019-07-17  Tom Tromey  <tom@tromey.com>
 382
 383         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 384         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 385         from tui_display_all_data.
 386         * tui/tui-win.c
 387         (tui_data_window::do_make_visible_with_new_height): Update.
 388         * tui/tui-regs.c (tui_show_registers): Update.
 389         * tui/tui-layout.c (tui_set_layout): Update.
 390         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 391         method.
 392
 393 2019-07-17  Tom Tromey  <tom@tromey.com>
 394
 395         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 396         * tui/tui-windata.c (tui_display_data_from): Remove.
 397         (tui_data_window::refresh_all): Update.
 398
 399 2019-07-17  Tom Tromey  <tom@tromey.com>
 400
 401         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 402         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 403         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 404         tui_display_registers_from_line.
 405         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 406         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 407         "force_display" parameter.
 408
 409 2019-07-17  Tom Tromey  <tom@tromey.com>
 410
 411         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 412         declare.
 413         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 414         Rename from tui_first_reg_element_no_inline.
 415         (tui_display_reg_element_at_line)
 416         (tui_display_registers_from_line): Update.
 417         * tui/tui-data.h (struct tui_data_window)
 418         <first_reg_element_no_inline>: New method.
 419
 420 2019-07-17  Tom Tromey  <tom@tromey.com>
 421
 422         * tui/tui-windata.c (tui_display_data_from)
 423         (tui_data_window::do_scroll_vertical): Update.
 424         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 425         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 426         Rename from tui_line_from_reg_element_no.
 427         (tui_display_registers_from_line): Update.
 428         * tui/tui-data.h (struct tui_data_window)
 429         <line_from_reg_element_no>: New method.
 430
 431 2019-07-17  Tom Tromey  <tom@tromey.com>
 432
 433         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 434         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 435         tui_last_regs_line_no.
 436         (tui_display_reg_element_at_line)
 437         (tui_display_registers_from_line): Update.
 438         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 439         method.
 440
 441 2019-07-17  Tom Tromey  <tom@tromey.com>
 442
 443         PR tui/24722:
 444         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 445         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 446         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 447         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 448         (tui_update_breakpoint_info): Likewise.
 449         * tui/tui-hooks.c (tui_event_create_breakpoint)
 450         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 451         Update.
 452
 453 2019-07-17  Tom Tromey  <tom@tromey.com>
 454
 455         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 456
 457 2019-07-17  Tom Tromey  <tom@tromey.com>
 458
 459         * tui/tui-winsource.c (tui_update_source_window_as_is)
 460         (tui_update_source_windows_with_addr): Update.
 461         * tui/tui-source.h (tui_set_source_content)
 462         (tui_show_symtab_source): Add "win_info" parameter.
 463         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 464         parameter.
 465         (tui_show_symtab_source): Likewise.
 466
 467 2019-07-17  Tom Tromey  <tom@tromey.com>
 468
 469         * tui/tui-wingeneral.c
 470         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 471
 472 2019-07-17  Tom Tromey  <tom@tromey.com>
 473
 474         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 475         (struct tui_cmd_window) <can_scroll>: New method.
 476         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 477         method.
 478
 479 2019-07-17  Tom Tromey  <tromey@adacore.com>
 480
 481         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 482         do_field_signed>: Rename.  Change type of "value".
 483         * ui-out.c (ui_out::field_signed): Rename from field_int.
 484         Change type of "value".
 485         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 486         type of "value".
 487         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 488         do_field_int.  Change type of "value".
 489         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 490         do_field_int.  Change type of "value".
 491         * tracepoint.c (trace_status_mi, tfind_1)
 492         (print_one_static_tracepoint_marker): Update.
 493         * thread.c (print_thread_info_1, print_selected_thread_frame):
 494         Update.
 495         * stack.c (print_frame, print_frame_info): Update.
 496         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 497         Update.
 498         * source.c (print_source_lines_base): Update.
 499         * skip.c (info_skip_command): Update.
 500         * record-btrace.c (btrace_ui_out_decode_error)
 501         (btrace_call_history_src_line): Update.
 502         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 503         Update.
 504         * progspace.c (print_program_space): Update.
 505         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 506         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 507         do_field_int.  Change type of "value".
 508         * mi/mi-out.c (mi_ui_out::do_table_begin)
 509         (mi_ui_out::do_table_header): Update.
 510         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 511         type of "value".
 512         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 513         (mi_cmd_data_list_changed_registers, output_register)
 514         (mi_cmd_data_read_memory, mi_load_progress)
 515         (mi_cmd_trace_frame_collected): Update.
 516         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 517         Update.
 518         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 519         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 520         (mi_cmd_var_list_children, varobj_update_one): Update.
 521         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 522         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 523         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 524         * inferior.c (print_inferior): Update.
 525         * gdb_bfd.c (print_one_bfd): Update.
 526         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 527         Update.
 528         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 529         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 530         do_field_int.  Change type of "value".
 531         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 532         do_field_int.  Change type of "value".
 533         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 534         (print_one_breakpoint_location, print_it_catch_fork)
 535         (print_one_catch_fork, print_it_catch_vfork)
 536         (print_one_catch_vfork, print_it_catch_solib)
 537         (print_it_catch_exec, print_it_ranged_breakpoint)
 538         (print_mention_watchpoint, print_mention_masked_watchpoint)
 539         (bkpt_print_it, update_static_tracepoint): Update.
 540         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 541         * break-catch-syscall.c (print_it_catch_syscall): Update.
 542         * ada-tasks.c (print_ada_task_info): Update.
 543         * ada-lang.c (print_it_exception, print_mention_exception):
 544         Update.
 545
 546 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 547
 548         PR breakpoints/24541
 549         * gdbarch.c: Regenerate.
 550         * gdbarch.h: Regenerate.
 551         * gdbarch.sh: Adjust return type and parameter types for
 552         'stap_adjust_register'.
 553         (i386_stap_adjust_register): Adjust signature and return new
 554         register name.
 555         * stap-probe.c (stap_parse_register_operand): Adjust use of
 556         'gdbarch_stap_adjust_register'.
 557
 558 2019-07-17  Tom Tromey  <tromey@adacore.com>
 559
 560         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 561         declare VEC.
 562         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 563         std::vector.
 564         (struct s390_process_info): Add initializers.
 565         (s390_add_process): Use new.
 566         (s390_linux_nat_target::low_forget_process): Use delete.
 567         (s390_linux_nat_target::low_new_fork)
 568         (s390_linux_nat_target::stopped_by_watchpoint)
 569         (s390_linux_nat_target::low_prepare_to_resume)
 570         (s390_linux_nat_target::insert_watchpoint)
 571         (s390_linux_nat_target::insert_hw_breakpoint)
 572         (s390_linux_nat_target::remove_watchpoint)
 573         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 574
 575 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 576
 577         * aarch64-fbsd-nat.c: Include regcache.h.
 578         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 579         argument.
 580         (aarch64_fbsd_nat_target::fetch_registers)
 581         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 582         variable.
 583         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 584
 585 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 586
 587         * fbsd-nat.c: Include gdbarch.h.
 588
 589 2019-07-15  Tom Tromey  <tromey@adacore.com>
 590
 591         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 592
 593 2019-07-15  Tom Tromey  <tromey@adacore.com>
 594
 595         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 596         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 597         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 598         * cli-out.c (cli_ui_out::do_field_int): New method.
 599         * ui-out.c (ui_out::field_unsigned): New method.
 600         * symfile.c (generic_load): Use field_unsigned.
 601         (print_transfer_performance): Likewise.
 602         * record-btrace.c (ui_out_field_uint): Remove.
 603         (btrace_call_history_insn_range, btrace_call_history): Use
 604         field_unsigned.
 605         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 606         field_unsigned.
 607         * ui-out.h (class ui_out) <field_unsigned>: New method.
 608         <do_field_unsigned>: Likewise.
 609
 610 2019-07-15  Tom Tromey  <tromey@adacore.com>
 611
 612         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 613         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 614         * target.c (flash_erase_command): Use field_string.
 615         * infrun.c (print_signal_received_reason): Use field_string.
 616         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 617         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 618         field_string.
 619         * ada-tasks.c (print_ada_task_info): Use field_string.
 620
 621 2019-07-15  Tom Tromey  <tromey@adacore.com>
 622
 623         * target.c (flash_erase_command): Use field_core_addr.
 624         * symfile.c (generic_load): Use field_core_addr.
 625         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 626         Use field_core_addr.
 627         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 628         field_core_addr.
 629
 630 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 631
 632         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 633         value if its desired type is smaller than a CORE_ADDR and signed.
 634
 635 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 636
 637         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 638         of changes to field names, and use new is_reference field to
 639         decide if a property is a reference or not.
 640         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 641         field.
 642         (struct dwarf2_property_baton): Update header comment, rename
 643         'referenced_type' to 'property_type' and update comments.
 644         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 645         default property type, store in property baton, update to take
 646         accound of renamed field.
 647         (read_func_scope): Update call to attr_to_dynamic_prop.
 648         (read_array_type): Likewise.
 649         (dwarf2_per_cu_addr_sized_int_type): New function.
 650         (read_subrange_index_type): Move type finding code to
 651         dwarf2_per_cu_addr_sized_int_type.
 652         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 653         (dwarf2_per_cu_addr_type): New function.
 654         (set_die_type): Update calls to attr_to_dynamic_prop.
 655
 656 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 657
 658         * dwarf2read.c (read_subrange_index_type): New function.
 659         (read_subrange_type): Move code into new function and call it.
 660         * gdbtypes.c (create_range_type): Add some asserts.
 661
 662 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 663
 664         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 665         update return statements.
 666         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 667         declaration, and update comment to match.
 668         * gdbtypes.c (resolve_dynamic_array): Update call to
 669         dwarf2_evaluate_property to match new return type.
 670
 671 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 672
 673         * valarith.c (value_subscripted_rvalue): Change lowerbound
 674         parameter type from int to LONGEST.
 675         * value.h (value_subscripted_rvalue): Likewise in declaration.
 676
 677 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 678
 679         * cli/cli-utils.c (info_print_command_completer): New function.
 680         * cli/cli-utils.h: Add 'completer.h' include, and forward
 681         declaration for 'struct cmd_list_element'.
 682         (info_print_command_completer): Declare.
 683         * stack.c (_initialize_stack): Add completer for 'info locals' and
 684         'info args'.
 685         * symtab.c (_initialize_symtab): Add completer for 'info
 686         variables' and 'info functions'.
 687         * NEWS: Mention completion for additional info commands.
 688
 689 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 690
 691         * cli/cli-utils.c (extract_info_print_args): Delete.
 692         (extract_arg_maybe_quoted): Delete.
 693         (info_print_options_defs): New variable.
 694         (make_info_print_options_def_group): New function.
 695         (extract_info_print_options): Define new function.
 696         * cli/cli-utils.h (extract_info_print_args): Delete.
 697         (struct info_print_options): New structure.
 698         (extract_info_print_options): Declare new function.
 699         * stack.c (info_locals_command): Update to use new
 700         extract_info_print_options, also add a header comment.
 701         (info_args_command): Likewise.
 702         * symtab.c (info_variables_command): Likewise.
 703         (info_functions_command): Likewise.
 704
 705 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 706
 707         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 708         to extract string arguments.
 709         * common/common-utils.c (extract_string_maybe_quoted): New function.
 710         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 711
 712 2019-07-11  Tom Tromey  <tromey@adacore.com>
 713
 714         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 715         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 716         * top.h (gdbinit): Don't declare.
 717         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 718         into...
 719         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 720         * top.c (gdb_init): Don't call init_cli_cmds.
 721         (gdbinit): Remove.
 722         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 723
 724 2019-07-11  Tom Tromey  <tromey@adacore.com>
 725
 726         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 727         after it has been moved.
 728
 729 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 730
 731         * valops.c (value_must_coerce_to_target): Change return type to
 732         bool.
 733         * value.h (value_must_coerce_to_target): Likewise.
 734
 735 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 736
 737         * breakpoint.c (is_hardware_watchpoint): Remove
 738         forward-declaration.
 739         (is_masked_watchpoint): Change return type to bool.
 740         (is_tracepoint): Likewise.
 741         (is_breakpoint): Likewise.
 742         (is_hardware_watchpoint): Likewise.
 743         (is_watchpoint): Likewise.
 744         (is_no_memory_software_watchpoint): Likewise.
 745         (is_catchpoint): Likewise.
 746         (breakpoint_1): Make FILTER parameter's return type bool.
 747         is_masked_watchpoint): Change return type to bool.
 748         (save_breakpoints): Make FILTER parameter's return type bool.
 749         * breakpoint.h (is_breakpoint): Change return type to bool.
 750         (is_watchpoint): Likewise.
 751         (is_catchpoint): Likewise.
 752         (is_tracepoint): Likewise.
 753
 754 2019-07-10  Tom Tromey  <tom@tromey.com>
 755
 756         * defs.h: Don't include gdbarch.h.
 757         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 758         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 759         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 760         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 761         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 762         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 763         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 764         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 765         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 766         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 767         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 768         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 769         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 770         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 771         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 772         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 773         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 774         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 775         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 776         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 777         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 778         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 779         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 780         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 781         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 782         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 783         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 784
 785 2019-07-10  Tom Tromey  <tromey@adacore.com>
 786
 787         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 788         * breakpoint.c (init_ada_exception_breakpoint): Register as
 789         bp_catchpoint.
 790         (print_one_breakpoint_location, print_one_breakpoint): Use
 791         is_ada_exception_catchpoint.
 792         * ada-lang.c (class ada_catchpoint_location): Pass
 793         bp_loc_software_breakpoint to bp_location constructor.
 794         (is_ada_exception_catchpoint): New function.
 795
 796 2019-07-10  Tom Tromey  <tromey@adacore.com>
 797
 798         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 799         VEC.
 800         (struct arm_exidx_entry): New method operator<.
 801         (struct arm_exidx_data) <section_maps>: Change type.
 802         (arm_exidx_data_free): Remove.
 803         (arm_exidx_data_key): Change type.  Move lower.
 804         (arm_exidx_new_objfile): Update.
 805         (arm_compare_exidx_entries): Remove.
 806         (arm_find_exidx_entry, _initialize_arm_tdep)
 807
 808 2019-07-10  Tom Tromey  <tromey@adacore.com>
 809
 810         * solib-spu.c (ocl_program_data_key): Change type.
 811         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 812         Update.
 813
 814 2019-07-10  Tom Tromey  <tromey@adacore.com>
 815
 816         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 817         (struct solib_aix_inferior_data) <library_list>: Change type.
 818         (solib_aix_inferior_data_handle): Change type.
 819         (get_solib_aix_inferior_data): Update.
 820         (solib_aix_free_library_list): Remove.
 821         (library_list_start_library): Update.
 822         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 823         return type.
 824         (solib_aix_get_library_list)
 825         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 826         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 827
 828 2019-07-10  Tom Tromey  <tromey@adacore.com>
 829
 830         * solib-dsbt.c (struct dsbt_info): Add initializers.
 831         (solib_dsbt_pspace_data): Change type.
 832         (dsbt_pspace_data_cleanup): Remove.
 833         (get_dsbt_info, _initialize_dsbt_solib): Update.
 834
 835 2019-07-10  Tom Tromey  <tromey@adacore.com>
 836
 837         * spu-tdep.c (spu_overlay_data): Change type.
 838         (spu_get_overlay_table, spu_overlay_new_objfile)
 839         (_initialize_spu_tdep): Update.
 840
 841 2019-07-10  Tom Tromey  <tromey@adacore.com>
 842
 843         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 844         destructor.
 845         (dbx_objfile_data_key): Change type and declare later.
 846         (DBX_SYMFILE_INFO): Rewrite.
 847         * dbxread.c (dbx_objfile_data_key): Change type.
 848         (dbx_symfile_init): Update.
 849         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 850         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 851         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 852
 853 2019-07-10  Tom Tromey  <tromey@adacore.com>
 854
 855         * jit.c (jit_program_space_key): Change type.  Move lower.
 856         (get_jit_program_space_data): Update.
 857         (jit_program_space_data_cleanup): Remove.
 858         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 859         Update.
 860         (struct jit_program_space_data): Add initializers.
 861
 862 2019-07-10  Tom Tromey  <tromey@adacore.com>
 863
 864         * solib-darwin.c (struct darwin_info): Add initializers.
 865         (solib_darwin_pspace_data): Change type.
 866         (darwin_pspace_data_cleanup): Remove.
 867         (get_darwin_info, _initialize_darwin_solib): Update.
 868
 869 2019-07-10  Tom Tromey  <tromey@adacore.com>
 870
 871         * remote-sim.c (struct sim_inferior_data): Add initializers,
 872         constructor, and destructor.
 873         (sim_inferior_data_key): Change type.  Move lower.
 874         (check_for_duplicate_sim_descriptor): Update.
 875         (get_sim_inferior_data): Use new.  Update.
 876         (~sim_inferior_data_cleanup): Rename from
 877         sim_inferior_data_cleanup.  Simplify.
 878         (gdbsim_close_inferior, simulator_command)
 879         (sim_command_completer, _initialize_remote_sim): Update.
 880         (next_pid, INITIAL_PID): Move earlier.
 881
 882 2019-07-10  Tom Tromey  <tromey@adacore.com>
 883
 884         * python/python-internal.h (create_thread_object): Return
 885         gdbpy_ref.
 886         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 887         * python/py-inferior.c (struct threadlist_entry): Add
 888         constructor.
 889         <thread_obj>: Now a gdbpy_ref.
 890         (thread_to_thread_object): Update.
 891         (add_thread_object): Use new.
 892         (delete_thread_object): Use delete.
 893         (infpy_threads): Update.
 894         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 895         GIL.
 896
 897 2019-07-10  Tom Tromey  <tromey@adacore.com>
 898
 899         * valops.c (value_cast): Specialize error message for Ada.
 900
 901 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 902
 903         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 904
 905 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 906
 907         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 908         bpstat_should_step): Return bool, adjust comments.
 909         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 910         bpstat_should_step): Likewise.
 911
 912 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 913
 914         * features/Makefile: Use feature target descriptions for Arm.
 915         * features/arm/arm-core.c: Generate new file.
 916         * features/arm/arm-fpa.c: Likewise.
 917         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 918         * features/arm/arm-m-profile.c: Likewise.
 919         * features/arm/arm-vfpv2.c: Likewise.
 920         * features/arm/arm-vfpv3.c: Likewise.
 921         * features/arm/xscale-iwmmxt.c: Likewise.
 922         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 923
 924 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 925
 926         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 927         ptrace earlier.
 928
 929 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 930
 931         * features/aarch64-pauth.c: Regenerate.
 932
 933 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 934
 935         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 936         bool.
 937         (bpstat_what): Use false instead of 0.
 938
 939 2019-07-09  Pedro Alves  <palves@redhat.com>
 940
 941         * break-catch-throw.c (is_exception_catchpoint): New.
 942         * breakpoint.c (print_one_breakpoint_location): New parameter
 943         'raw_loc'.  Handle it.  Use
 944         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 945         looking at the breakpoint's type.
 946         (print_one_breakpoint): If handling "maint info breakpoints", also
 947         print locations of exception catchpoints.
 948         * breakpoint.h (is_exception_catchpoint): Declare.
 949
 950 2019-07-09  Pedro Alves  <palves@redhat.com>
 951
 952         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 953         "addr" field.
 954         (allocate_location_exception_catchpoint): New.
 955         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 956         (initialize_throw_catchpoint_ops): Install
 957         allocate_location_exception_catchpoint as allocate_location
 958         method.
 959         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 960         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 961         bp_loc_other.
 962         (breakpoint_address_is_meaningful): Delete.
 963         (bl_address_is_meaningful): New.
 964         (breakpoint_locations_match): Adjust comment.
 965         (bp_location_from_bp_type): New, factored out of...
 966         (bp_location::bp_location(breakpoint *)): ... this.
 967         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 968         factored out of...
 969         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 970         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 971         breakpoint_address_is_meaningful.
 972         (bp_locations_compare): Adjust comment.
 973         (update_global_location_list): Use bl_address_is_meaningful
 974         instead of breakpoint_address_is_meaningful.
 975         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 976         explicit.
 977         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 978         * python/py-breakpoint.c (bppy_get_location): No longer check
 979         whether location is null.
 980
 981 2019-07-09  Pedro Alves  <palves@redhat.com>
 982
 983         PR c++/15468
 984         * breakpoint.c (print_one_breakpoint_location): Remove
 985         single-location assert.
 986
 987 2019-07-09  Tom Tromey  <tom@tromey.com>
 988
 989         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 990         * configure: Rebuild.
 991         * configure.ac: Change common to gdbsupport.
 992         * gdbsupport: Rename from common.
 993         * acinclude.m4: Change common to gdbsupport.
 994         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 995         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 996         gdbsupport.
 997         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 998         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 999         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1000         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1001         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1002         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1003         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1004         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1005         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1006         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1007         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1008         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1009         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1010         coff-pe-read.c, command.h, compile/compile-c-support.c,
1011         compile/compile-c.h, compile/compile-cplus-symbols.c,
1012         compile/compile-cplus-types.c, compile/compile-cplus.h,
1013         compile/compile-loc2c.c, compile/compile.c, completer.c,
1014         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1015         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1016         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1017         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1018         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1019         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1020         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1021         features/aarch64-core.c, features/aarch64-fpu.c,
1022         features/aarch64-pauth.c, features/aarch64-sve.c,
1023         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1024         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1025         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1026         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1027         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1028         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1029         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1030         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1031         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1032         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1033         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1034         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1035         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1036         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1037         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1038         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1039         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1040         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1041         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1042         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1043         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1044         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1045         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1046         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1047         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1048         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1049         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1050         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1051         minsyms.c, mips-linux-tdep.c, namespace.h,
1052         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1053         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1054         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1055         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1056         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1057         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1058         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1059         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1060         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1061         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1062         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1063         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1064         procfs.c, producer.c, progspace.h, psymtab.h,
1065         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1066         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1067         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1068         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1069         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1070         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1071         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1072         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1073         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1074         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1075         target-memory.c, target.c, target.h, target/waitstatus.c,
1076         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1077         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1078         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1079         unittests/array-view-selftests.c,
1080         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1081         unittests/common-utils-selftests.c,
1082         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1083         unittests/format_pieces-selftests.c,
1084         unittests/function-view-selftests.c,
1085         unittests/lookup_name_info-selftests.c,
1086         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1087         unittests/mkdir-recursive-selftests.c,
1088         unittests/observable-selftests.c,
1089         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1090         unittests/parse-connection-spec-selftests.c,
1091         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1092         unittests/scoped_fd-selftests.c,
1093         unittests/scoped_mmap-selftests.c,
1094         unittests/scoped_restore-selftests.c,
1095         unittests/string_view-selftests.c, unittests/style-selftests.c,
1096         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1097         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1098         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1099         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1100         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1101         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1102
1103 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1104
1105         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1106         bool value.
1107         (decode_digits_ordinary): Set explicit_line field in sal.
1108         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1109         symtab_and_line that was set on an explicit line number in
1110         assembler code.  Do always update the recorded symtab and line if
1111         we do skip the prologue.
1112
1113 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1114
1115         * breakpoint.c (set_breakpoint_location_function): Remove
1116         explicit_loc parameter.
1117         (momentary_breakpoint_from_master): Update call to
1118         set_breakpoint_location_function.
1119         (add_location_to_breakpoint): Likewise.
1120
1121 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1122
1123         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1124         required features based on default bfd type when no specific bfd
1125         is present.
1126
1127 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1128
1129         * NEWS: Mention that GDB printf and eval commands can now print
1130         C-style and Ada-style convenience var strings without
1131         calling the inferior.
1132         * printcmd.c (printf_c_string): Locally print GDB internal var
1133         instead of transiting via the inferior.
1134         (printf_wide_c_string): Likewise.
1135
1136 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1137
1138         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1139
1140 2019-07-04  Tom Tromey  <tom@tromey.com>
1141
1142         PR tui/24724:
1143         * tui/tui-winsource.c (tui_clear_source_content): Update.
1144         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1145         (tui_update_breakpoint_info): Update.
1146         (tui_set_exec_info_content): Update.
1147         * tui/tui-source.c (tui_set_source_content_nil): Update.
1148         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1149         has_break.
1150         * tui/tui-data.h (enum tui_bp_flag): New.
1151         (tui_bp_flags): New enum flags type.
1152         (struct tui_source_element) <break_mode>: Change type.  Rename
1153         from has_break.
1154         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1155         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1156         constants.
1157         * tui/tui-winsource.h: Fix comment.
1158
1159 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1160
1161         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1162         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1163         (store_fpregs_to_thread)
1164         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1165         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1166         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1167         (IWMMXT_REGS_SIZE): Add define.
1168         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1169         (fetch_vfp_regs, store_vfp_regs)
1170         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1171         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1172
1173 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1174
1175         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1176         defines.
1177         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1178         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1179         (ARM_INT_REGISTER_SIZE): ...to this.
1180         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1181         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1182         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1183         (arm_linux_collect_gregset, supply_nwfpe_register)
1184         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1185         defines.
1186         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1187         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1188         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1189         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1190         (arm_return_in_memory, arm_store_return_value)
1191         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1192         (arm_record_ld_st_multiple): Likewise.
1193         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1194         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1195
1196 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1197
1198         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1199         AARCH64_DISPLACED_MODIFIED_INSNS.
1200         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1201         (aarch64_displaced_step_copy_insn): Likewise.
1202         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1203         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1204         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1205         ARM_DISPLACED_MODIFIED_INSNS.
1206         * arm-tdep.c (arm_gdbarch_init): Likewise.
1207         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1208         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1209         (struct arm_displaced_step_closure): Use
1210         ARM_DISPLACED_MODIFIED_INSNS.
1211
1212 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1213
1214         * features/Makefile: Remove unused xml files.
1215         * features/aarch64.xml: Remove.
1216         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1217         * features/i386/amd64-avx-avx512.xml: Remove.
1218         * features/i386/amd64-avx-linux.xml: Remove.
1219         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1220         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1221         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1222         * features/i386/amd64-avx-mpx.xml: Remove.
1223         * features/i386/amd64-avx.xml: Remove.
1224         * features/i386/amd64-linux.xml: Remove.
1225         * features/i386/amd64-mpx-linux.xml: Remove.
1226         * features/i386/amd64-mpx.xml: Remove.
1227         * features/i386/amd64.xml: Remove.
1228         * features/i386/i386-avx-avx512-linux.xml: Remove.
1229         * features/i386/i386-avx-avx512.xml: Remove.
1230         * features/i386/i386-avx-linux.xml: Remove.
1231         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1232         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1233         * features/i386/i386-avx-mpx-linux.xml: Remove.
1234         * features/i386/i386-avx-mpx.xml: Remove.
1235         * features/i386/i386-avx.xml: Remove.
1236         * features/i386/i386-linux.xml: Remove.
1237         * features/i386/i386-mmx-linux.xml: Remove.
1238         * features/i386/i386-mmx.xml: Remove.
1239         * features/i386/i386-mpx-linux.xml: Remove.
1240         * features/i386/i386-mpx.xml: Remove.
1241         * features/i386/i386.xml: Remove.
1242         * features/i386/x32-avx-avx512-linux.xml: Remove.
1243         * features/i386/x32-avx-linux.xml: Remove.
1244         * features/i386/x32-linux.xml: Remove.
1245
1246 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1247
1248         * regformats/aarch64.dat: Remove.
1249         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1250         * regformats/i386/amd64-avx-linux.dat: Remove.
1251         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1252         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1253         * regformats/i386/amd64-linux.dat: Remove.
1254         * regformats/i386/amd64-mpx-linux.dat: Remove.
1255         * regformats/i386/amd64.dat: Remove.
1256         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1257         * regformats/i386/i386-avx-linux.dat: Remove.
1258         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1259         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1260         * regformats/i386/i386-linux.dat: Remove.
1261         * regformats/i386/i386-mmx-linux.dat: Remove.
1262         * regformats/i386/i386-mpx-linux.dat: Remove.
1263         * regformats/i386/i386.dat: Remove.
1264         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1265         * regformats/i386/x32-avx-linux.dat: Remove.
1266         * regformats/i386/x32-linux.dat: Remove.
1267
1268 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1269
1270         * aarch64-tdep.c: Remove xml self tests.
1271         * amd64-linux-tdep.c: Likewise.
1272         * amd64-tdep.c: Likewise.
1273         * i386-linux-tdep.c: Likewise.
1274         * i386-tdep.c: Likewise.
1275
1276 2019-07-03  Pedro Alves  <palves@redhat.com>
1277
1278         PR cli/24732
1279         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1280         (pipe_cmd_option_defs): New.
1281         (make_pipe_cmd_options_def_group): New.
1282         (pipe_command): Use gdb::option::process_options.
1283         (pipe_command_completer): New function.
1284         (_initialize_cli_cmds): Install completer for "pipe" command.
1285
1286 2019-07-03  Pedro Alves  <palves@redhat.com>
1287
1288         * cli/cli-option.c (union option_value) <string>: New field.
1289         (struct option_def_and_value): Add ctor, move ctor, dtor and
1290         use DISABLE_COPY_AND_ASSIGN.
1291         (option_def_and_value::clear_value): New.
1292         (parse_option, save_option_value_in_ctx, get_val_type_str)
1293         (add_setshow_cmds_for_options): Handle var_string.
1294         * cli-option.h (union option_def::var_address) <string>: New
1295         field.
1296         (struct string_option_def): New.
1297         * maint-test-options.c (struct test_options_opts): Add default
1298         ctor and use DISABLE_COPY_AND_ASSIGN.
1299         <string_opt>: New field.
1300         (test_options_opts::~test_options_opts): New.
1301         (test_options_opts::dump): Also dump "-string".
1302         (test_options_option_defs): Install "string.
1303
1304 2019-07-03  Pedro Alves  <palves@redhat.com>
1305
1306         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1307         option_value with a null enumeration.
1308         (complete_options): Save the option values in the context.
1309         (save_option_value_in_ctx): New, factored out from ...
1310         (process_options): ... here.
1311         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1312         of the function.
1313         * maint-test-options.c (test_options_opts::dump): New, factored
1314         out from ...
1315         (maintenance_test_options_command_mode): ... here.
1316         (maintenance_test_options_command_completion_result): Delete.
1317         (maintenance_test_options_command_completion_text): Update
1318         comment.
1319         (maintenance_show_test_options_completion_result): Change
1320         prototype.  Just print
1321         maintenance_test_options_command_completion_text.
1322         (save_completion_result): New.
1323         (maintenance_test_options_completer_mode): Pass options context to
1324         complete_options, and then save a dump.
1325         (_initialize_maint_test_options): Use add_cmd to install "maint
1326         show test-options-completion-result".
1327
1328 2019-07-03  Pedro Alves  <palves@redhat.com>
1329
1330         * NEWS (New commands): Mention "with" and "maint with".
1331         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1332         (with_command, with_command_completer): New.
1333         (pipe_command): Adjust to new repeat_previous
1334         interface.
1335         (_initialize_cli_cmds): Install the "with" command and its "w"
1336         alias.
1337         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1338         declarations.
1339         * cli/cli-setshow.c (parse_cli_var_uinteger)
1340         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1341         argument strings for all var_types.
1342         (get_setshow_command_value_string): New, factored out from ...
1343         (do_show_command): ... this.
1344         * cli/cli-setshow.h: Include <string>.
1345         (get_setshow_command_value_string): Declare.
1346         * command.h (repeat_previous): Now returns const char *.  Adjust
1347         comment.
1348         * maint.c: Include "cli/cli-cmds.h".
1349         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1350         (_initialize_maint_cmds): Register the "maintenance with" command.
1351         * top.c (repeat_previous): Move bits from pipe_command here:
1352         Return the saved command line, if any; error out if there's no
1353         command to relaunch.
1354
1355 2019-07-03  Pedro Alves  <palves@redhat.com>
1356
1357         * NEWS (New commands): Mention "maint set/show test-settings"
1358         instead of "maint test-settings".
1359         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1360         (maintenance_test_settings_set_list): Rename to ...
1361         (maintenance_set_test_settings_list): ... this.
1362         (maintenance_test_settings_show_list): Rename to  ...
1363         (maintenance_show_test_settings_list): ... this.
1364         (maintenance_test_settings_cmd): Delete.
1365         (maintenance_test_settings_set_cmd): ...
1366         (maintenance_set_test_settings_cmd): ... this.
1367         (maintenance_test_settings_show_cmd): ...
1368         (maintenance_show_test_settings_cmd): ... this.
1369         (maintenance_test_settings_show_value_cmd):
1370         (maintenance_show_test_settings_value_cmd): ... this.
1371         (_initialize_maint_test_settings): No longer install the "maint
1372         test-settings" prefix command.  Rename "maint test-settings set"
1373         to "maint set test-settings", and "maint test-settings show" to
1374         "maint show test-settings".  Adjust all subcommands.
1375
1376 2019-07-03  Pedro Alves  <palves@redhat.com>
1377
1378         * maint-test-settings.c: Fix file's intro comment.  Replace all
1379         references to "test-options" with references to "test-settings",
1380         in comments.
1381
1382 2019-07-03  Pedro Alves  <palves@redhat.com>
1383
1384         * maint-test-settings.c (maintenance_test_settings_xxx)
1385         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1386         New.
1387         (maintenance_test_settings_enums): Use them.
1388         (maintenance_test_settings_enum): Default to
1389         maintenance_test_settings_xxx.
1390         (_initialize_maint_test_settings): Initialize
1391         MAINTENANCE_TEST_SETTINGS_FILENAME.
1392
1393 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1394
1395         * breakpoint.h (remove_breakpoints_inf): Change return type to
1396         void, move function documentation here.
1397         * breakpoint.c (remove_breakpoints_inf): Change return type to
1398         void, move function documentation to header.
1399
1400 2019-07-02  Pedro Alves  <palves@redhat.com>
1401
1402         * NEWS (Completion improvements): Mention "info threads".
1403         * thread.c (struct info_threads_opts, info_threads_option_defs)
1404         (make_info_threads_options_def_group): New.
1405         (info_threads_command): Use gdb::option::process_options.
1406         (info_threads_command_completer): New.
1407         (_initialize_thread): Use gdb::option::build_help to build the
1408         help text for "info threads".
1409
1410 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1411
1412         * defs.h (generic_load): Move from here...
1413         * symfile.h (generic_load): ... to here.  Rename name parameter
1414         to args.
1415         * symfile.c (generic_load): Add comment.
1416
1417 2019-07-01  Tom Tromey  <tromey@adacore.com>
1418
1419         * dwarf2read.c
1420         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1421         declaration of without_params.  Fix formatting.
1422
1423 2019-07-01  Tom Tromey  <tromey@adacore.com>
1424
1425         * ada-exp.y (find_primitive_type): Update.
1426         * ada-lang.h (ada_lookup_symbol): Update.
1427         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1428         parameter.
1429         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1430
1431 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1432
1433         PR breakpoints/24541
1434         * gdbarch.c: Regenerate.
1435         * gdbarch.h: Regenerate.
1436         * gdbarch.sh: Add 'stap_adjust_register'.
1437         * i386-tdep.c: Include '<unordered_set>'.
1438         (i386_stap_adjust_register): New function.
1439         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1440         * stap-probe.c (stap_parse_register_operand): Call
1441         'gdbarch_stap_adjust_register'.
1442
1443 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1444
1445         PR python/24742
1446         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1447         * python/python.c (do_start_initialization): Use 'xmalloc'
1448         instead of 'PyMem_Malloc'.
1449
1450 2019-06-28  Tom Tromey  <tromey@adacore.com>
1451
1452         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1453         for Ada.
1454
1455 2019-06-27  Tom Tromey  <tromey@adacore.com>
1456
1457         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1458         objfile_key.
1459         (arm_find_mapping_symbol, arm_record_special_symbol)
1460         (_initialize_arm_tdep): Update.
1461         (arm_objfile_data_free): Remove.
1462
1463 2019-06-27  Tom Tromey  <tromey@adacore.com>
1464
1465         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1466         to cp_print_static_field.
1467
1468 2019-06-26  Tom Tromey  <tromey@adacore.com>
1469
1470         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1471         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1472         declare.
1473
1474 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1475
1476         * features/aarch64-core.c (create_feature_aarch64_core):
1477         Regenerate.
1478         * features/aarch64-core.xml: Add cpsr flags.
1479
1480 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1481
1482         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1483         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1484
1485 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1486
1487         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1488         field.
1489         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1490         use.
1491         (arm_record_special_symbol): Don't insert new symbol in sorted
1492         position, push it at the end.
1493
1494 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1495
1496         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1497         (arm_mapping_symbol_s): Remove.
1498         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1499         (arm_mapping_symbol_vec): New typedef.
1500         (struct arm_per_objfile): Add constructor.
1501         <section_maps>: Change type to
1502         std::unique_ptr<arm_mapping_symbol_vec[]>.
1503         (arm_compare_mapping_symbols): Remove.
1504         (arm_find_mapping_symbol): Adjust to section_maps type change.
1505         (arm_objfile_data_free): Call delete on arm_per_objfile.
1506         (arm_record_special_symbol): Adjust to section_maps type change.
1507         Allocate arm_per_objfile with new.
1508
1509 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1510
1511         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1512         with the command prefix.
1513
1514 2019-06-25  Tom Tromey  <tom@tromey.com>
1515
1516         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1517         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1518
1519 2019-06-25  Tom Tromey  <tom@tromey.com>
1520
1521         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1522         type.
1523         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1524         protected.
1525
1526 2019-06-25  Tom Tromey  <tom@tromey.com>
1527
1528         * tui/tui-winsource.c
1529         (tui_source_window_base::set_is_exec_point_at): Add check against
1530         LOA_ADDRESS.
1531
1532 2019-06-25  Tom Tromey  <tom@tromey.com>
1533
1534         * tui/tui-source.c (tui_set_source_content): Don't check before
1535         xfree.
1536         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1537
1538 2019-06-25  Tom Tromey  <tom@tromey.com>
1539
1540         * tui/tui-winsource.h (tui_update_source_window_as_is)
1541         (tui_alloc_source_buffer, tui_line_is_displayed)
1542         (tui_addr_is_displayed): Change type of win_info.
1543         * tui/tui-winsource.c (tui_update_source_window_as_is)
1544         (tui_clear_source_content, tui_show_source_line)
1545         (tui_show_source_content, tui_source_window_base::refill)
1546         (tui_source_window_base::set_is_exec_point_at)
1547         (tui_source_window_base::set_is_exec_point_at)
1548         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1549         (tui_alloc_source_buffer, tui_line_is_displayed)
1550         (tui_addr_is_displayed): Change type of win_info.  Update.
1551         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1552         (tui_source_window_base::do_make_visible_with_new_height):
1553         Update.
1554         * tui/tui-source.c (tui_set_source_content)
1555         (tui_set_source_content_nil)
1556         (tui_source_window::do_scroll_vertical): Update.
1557         * tui/tui-layout.c (show_layout): Update.
1558         * tui/tui-disasm.c (tui_set_disassem_content)
1559         (tui_disasm_window::do_scroll_vertical): Update.
1560         * tui/tui-data.h (tui_win_content): Remove.
1561         (struct tui_gen_win_info) <content, content_size>: Remove.
1562         (struct tui_source_element): Add initializers and destructor.
1563         (union tui_which_element, struct tui_win_element): Remove.
1564         (struct tui_source_window_base) <content>: New field.
1565         (struct tui_data_window): Remove destructor.
1566         (tui_alloc_content, tui_free_win_content)
1567         (tui_free_all_source_wins_content): Don't declare.
1568         * tui/tui-data.c (tui_initialize_static_data): Update.
1569         (init_content_element, tui_alloc_content): Remove.
1570         (~tui_gen_win_info): Update.
1571         (~tui_data_window, tui_free_all_source_wins_content)
1572         (tui_free_win_content, free_content, free_content_elements):
1573         Remove.
1574
1575 2019-06-25  Tom Tromey  <tom@tromey.com>
1576
1577         * tui/tui-winsource.h (tui_clear_source_content)
1578         (tui_erase_source_content, tui_show_source_content): Change type
1579         of win_info.
1580         * tui/tui-winsource.c (tui_clear_source_content)
1581         (tui_erase_source_content, tui_show_source_content): Change type
1582         of win_info.
1583         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1584         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1585         win_info.
1586         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1587         win_info.
1588         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1589
1590 2019-06-25  Tom Tromey  <tom@tromey.com>
1591
1592         * tui/tui-winsource.c (tui_clear_source_content)
1593         (tui_source_window_base::set_is_exec_point_at): Update.
1594         * tui/tui-source.c (tui_set_source_content_nil): Update.
1595         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1596         a bool.
1597         * tui/tui-data.c (init_content_element): Update.
1598
1599 2019-06-25  Tom Tromey  <tom@tromey.com>
1600
1601         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1602         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1603         * tui/tui-layout.c (init_and_make_win): Update.
1604         * tui/tui.h (enum tui_win_type): Update.
1605         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1606         tui_win_is_auxillary.
1607         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1608         tui_win_is_auxillary.
1609
1610 2019-06-25  Tom Tromey  <tom@tromey.com>
1611
1612         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1613         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1614         (tui_delete_data_content_windows, tui_display_all_data)
1615         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1616         Update.
1617         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1618         * tui/tui-regs.c (tui_last_regs_line_no)
1619         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1620         (tui_show_registers): Update.
1621         (tui_show_register_group): Return void.  Update.
1622         (tui_display_registers_from, tui_display_reg_element_at_line)
1623         (tui_display_registers_from_line, tui_check_register_values):
1624         Update.
1625         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1626         member.
1627         (struct tui_data_window) <regs_content>: Now a std::vector.
1628         <regs_content_count>: Remove.
1629         (tui_add_content_elements, tui_free_data_content): Don't declare.
1630         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1631         (init_content_element): Remove DATA_WIN case.  Add assert.
1632         (tui_add_content_elements): Remove.
1633         (tui_data_window): Update.
1634         (tui_free_data_content): Remove.
1635         (free_content_elements): Remove DATA_WIN case.
1636
1637 2019-06-25  Tom Tromey  <tom@tromey.com>
1638
1639         * tui/tui-data.c (tui_data_item_window): Update.
1640         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1641         * tui/tui-windata.c (tui_display_all_data)
1642         (tui_display_data_from_line): Update.
1643         (tui_check_data_values): Remove.
1644         * tui/tui-regs.c (tui_show_register_group)
1645         (tui_display_reg_element_at_line): Update.
1646         * tui/tui-hooks.c (tui_register_changed)
1647         (tui_refresh_frame_and_register_information): Call
1648         tui_check_register_values.
1649         * tui/tui-data.h (struct tui_data_window) <data_content,
1650         data_content_count, data_type>: Remove.
1651         (enum tui_data_type): Remove.
1652
1653         * tui/tui-data.c (tui_data_window::clear_detail)
1654         (~tui_data_window): Update.
1655
1656 2019-06-25  Tom Tromey  <tom@tromey.com>
1657
1658         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1659         declare.
1660         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1661         Rename from tui_first_data_item_displayed.  Update.
1662         (tui_data_window::refresh_all)
1663         (tui_data_window::do_scroll_vertical): Update.
1664         * tui/tui-data.h (struct tui_data_window)
1665         <first_data_item_displayed>: Declare new method.
1666
1667 2019-06-25  Tom Tromey  <tom@tromey.com>
1668
1669         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1670         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1671         contents...
1672         (tui_initialize_static_data): ...here.
1673
1674 2019-06-25  Tom Tromey  <tom@tromey.com>
1675
1676         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1677         (tui_display_registers_from, tui_check_register_values): Update.
1678         (tui_display_register): Remove win_info parameter; update.
1679         (tui_get_register): Change type of parameters.
1680         * tui/tui-data.h (struct tui_data_element): Remove.
1681         (union tui_which_element) <data>: Remove.
1682         <data_window>: Change type.
1683         (struct tui_data_item_window): New.
1684         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1685         case.  Add assert.
1686         (~tui_data_item_window): New destructor.
1687         (free_content_elements): Remove DATA_ITEM_WIN case.
1688
1689 2019-06-25  Tom Tromey  <tom@tromey.com>
1690
1691         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1692         Remove.
1693
1694 2019-06-25  Tom Tromey  <tom@tromey.com>
1695
1696         * tui/tui-data.h (struct tui_command_element): Remove.
1697         (union tui_which_element) <command>: Remove.
1698         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1699         assert.
1700         (free_content_elements): Remove CMD_WIN case.
1701
1702 2019-06-25  Tom Tromey  <tom@tromey.com>
1703
1704         * tui/tui-layout.c (tui_set_layout): Update.
1705         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1706         * tui/tui-data.c (layout_def): Update.
1707
1708 2019-06-25  Tom Tromey  <tom@tromey.com>
1709
1710         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1711         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1712         (tui_source_window_base::set_new_height): Update.
1713         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1714         Update.
1715         (tui_set_locator_fullname, tui_set_locator_info)
1716         (tui_show_frame_info): Update.
1717         * tui/tui-source.c (tui_set_source_content)
1718         (tui_source_is_displayed): Update.
1719         * tui/tui-layout.c (show_source_disasm_command, show_data)
1720         (show_source_or_disasm_and_command): Update.
1721         * tui/tui-disasm.c (tui_set_disassem_content)
1722         (tui_get_begin_asm_address): Update.
1723         * tui/tui-data.h (struct tui_locator_element): Remove.
1724         (union tui_which_element) <locator>: Remove.
1725         (struct tui_locator_window): New.
1726         (tui_locator_win_info_ptr): Change return type.
1727         * tui/tui-data.c (_locator): Change type.
1728         (tui_locator_win_info_ptr): Change return type.
1729         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1730         (tui_alloc_content): Add assert.
1731
1732 2019-06-25  Tom Tromey  <tom@tromey.com>
1733
1734         * tui/tui-winsource.c
1735         (tui_exec_info_window::maybe_allocate_content): New method.
1736         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1737         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1738         (make_source_or_disasm_window): Add cast.
1739         * tui/tui-data.h (union tui_which_element) <simple_string>:
1740         Remove.
1741         (struct tui_source_info): New.
1742         (struct tui_source_window_base) <execution_info>: Change type.
1743         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1744         case, and add assert.
1745         (tui_alloc_content): Add assert.
1746
1747 2019-06-25  Tom Tromey  <tom@tromey.com>
1748
1749         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1750         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1751         * tui/tui-data.c (tui_alloc_win_info): Remove.
1752
1753 2019-06-25  Tom Tromey  <tom@tromey.com>
1754
1755         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1756         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1757         can_highlight.
1758
1759 2019-06-25  Tom Tromey  <tom@tromey.com>
1760
1761         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1762         make_visible_with_new_height method.
1763         (tui_win_info::make_visible_with_new_height): New method.
1764         (tui_source_window_base::do_make_visible_with_new_height)
1765         (tui_data_window::do_make_visible_with_new_height)
1766         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1767         (make_visible_with_new_height): Remove.
1768         (tui_resize_all, tui_adjust_win_heights): Use
1769         make_visible_with_new_height method.
1770         * tui/tui-data.h (struct tui_win_info)
1771         <do_make_visible_with_new_height, make_visible_with_new_height>:
1772         New methods.
1773         (struct tui_source_window_base, struct tui_data_window)
1774         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1775         methods.
1776
1777 2019-06-25  Tom Tromey  <tom@tromey.com>
1778
1779         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1780         method.
1781         (update_tab_width): Call update_tab_width method.
1782         * tui/tui-data.h (struct tui_win_info)
1783         (struct tui_source_window_base) <update_tab_width>: New methods.
1784
1785 2019-06-25  Tom Tromey  <tom@tromey.com>
1786
1787         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1788         parameter.
1789         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1790         parameter.
1791         (tui_gen_win_info::make_visible): Update.
1792         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1793         parameter.
1794         * tui/tui-data.h (enum tui_box): New enum.
1795         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1796
1797 2019-06-25  Tom Tromey  <tom@tromey.com>
1798
1799         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1800         init_and_make_win for EXEC_INFO_WIN.
1801         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1802         longer inline.
1803         (struct tui_win_info) <~tui_win_info>: Inline.
1804         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1805         Don't declare.
1806         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1807         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1808         Remove.
1809         (tui_initialize_static_data): Update.
1810         (~tui_gen_win_info): Handle more cleanup here.
1811         (~tui_source_window_base): Delete "execution_info".
1812         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1813
1814 2019-06-25  Tom Tromey  <tom@tromey.com>
1815
1816         * tui/tui-layout.c (make_command_window): Don't set
1817         can_highlight.
1818         (show_source_disasm_command): Call the reset method.
1819         (show_data): Don't set can_highlight.  Call the reset method.
1820         (tui_gen_win_info::reset): Rename from init_gen_win_info
1821         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1822         (show_source_or_disasm_and_command): Call the reset method.
1823         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1824         (struct tui_cmd_window): Set can_highlight.
1825
1826 2019-06-25  Tom Tromey  <tom@tromey.com>
1827
1828         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1829         from make_visible.
1830         (tui_make_visible, tui_make_invisible): Rewrite.
1831         (tui_win_info::make_visible): Remove.
1832         (tui_source_window_base::make_visible): Update.
1833         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1834         method.  Moved from...
1835         (struct tui_win_info) <make_visible>: ...here.
1836
1837 2019-06-25  Tom Tromey  <tom@tromey.com>
1838
1839         * tui/tui-winsource.c
1840         (tui_source_window_base::do_scroll_horizontal): Remove direction
1841         parameter.
1842         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1843         direction parameter.
1844         * tui/tui-win.c (tui_win_info::forward_scroll)
1845         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1846         (tui_win_info::right_scroll): Update.
1847         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1848         direction parameter.
1849         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1850         direction parameter.
1851         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1852         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1853         Remove direction parameter.
1854         (struct tui_source_window_base, struct tui_source_window)
1855         (struct tui_disasm_window, struct tui_data_window)
1856         (struct tui_cmd_window): Update.
1857
1858 2019-06-25  Tom Tromey  <tom@tromey.com>
1859
1860         * tui/tui-winsource.h (tui_set_exec_info_content)
1861         (tui_show_exec_info_content, tui_erase_exec_info_content)
1862         (tui_clear_exec_info_content, tui_update_exec_info): Change
1863         argument to tui_source_window_base.
1864         * tui/tui-winsource.c (tui_set_exec_info_content)
1865         (tui_show_exec_info_content, tui_erase_exec_info_content)
1866         (tui_clear_exec_info_content, tui_update_exec_info): Change
1867         argument to tui_source_window_base.
1868
1869 2019-06-25  Tom Tromey  <tom@tromey.com>
1870
1871         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1872         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1873
1874 2019-06-25  Tom Tromey  <tom@tromey.com>
1875
1876         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1877         check.
1878
1879 2019-06-25  Tom Tromey  <tom@tromey.com>
1880
1881         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1882         type to void.
1883         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1884         type to void.
1885         * tui/tui-source.c (tui_set_source_content): Update.
1886         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1887
1888 2019-06-25  Tom Tromey  <tom@tromey.com>
1889
1890         * tui/tui-win.c (window_name_completer, tui_set_focus)
1891         (tui_all_windows_info): Use name method.
1892         * tui/tui-data.h (struct tui_gen_win_info)
1893         (struct tui_source_window, struct tui_disasm_window)
1894         (struct tui_data_window, struct tui_cmd_window) <name>: New
1895         method.
1896         (tui_win_name): Don't declare.
1897         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1898         (tui_win_name): Remove.
1899
1900 2019-06-25  Tom Tromey  <tom@tromey.com>
1901
1902         * tui/tui-winsource.h (tui_update_source_window)
1903         (tui_update_source_window_as_is): Change parameter type.
1904         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1905         to be a tui_source_window_base.
1906         (tui_update_source_window_as_is): Likewise.
1907         * tui/tui-win.c (make_visible_with_new_height): Update.
1908
1909 2019-06-25  Tom Tromey  <tom@tromey.com>
1910
1911         * tui/tui-winsource.c (tui_erase_source_content)
1912         (tui_show_source_content, tui_show_exec_info_content)
1913         (tui_erase_exec_info_content): Use refresh_window method.
1914         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1915         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1916         from tui_refresh_win.
1917         (tui_data_window::refresh_window): New method.
1918         (tui_win_info::refresh, tui_source_window_base::refresh)
1919         (tui_refresh_all): Use refresh_window method.
1920         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1921         method.
1922         * tui/tui-regs.c (tui_display_register): Call refresh_window
1923         method.
1924         * tui/tui-layout.c (show_source_disasm_command)
1925         (show_source_or_disasm_and_command): Call refresh_window method.
1926         * tui/tui-data.h (struct tui_gen_win_info)
1927         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1928         New method.
1929
1930 2019-06-25  Tom Tromey  <tom@tromey.com>
1931
1932         * tui/tui.c (tui_rl_other_window, tui_enable)
1933         (tui_is_window_visible, tui_get_command_dimension): Update.
1934         * tui/tui-winsource.c (tui_update_source_window_as_is)
1935         (tui_clear_source_content, tui_erase_source_content)
1936         (tui_show_source_line, tui_source_window_base::refill)
1937         (tui_source_window_base::do_scroll_horizontal)
1938         (tui_source_window_base::set_is_exec_point_at)
1939         (tui_update_breakpoint_info, tui_set_exec_info_content)
1940         (tui_alloc_source_buffer, tui_line_is_displayed)
1941         (tui_addr_is_displayed): Update.
1942         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1943         (tui_check_and_display_highlight_if_needed)
1944         (tui_win_info::make_visible, tui_win_info::refresh)
1945         (tui_refresh_all): Update.
1946         * tui/tui-windata.c (tui_first_data_item_displayed)
1947         (tui_delete_data_content_windows, tui_erase_data_content)
1948         (tui_display_all_data, tui_data_window::refresh_all)
1949         (tui_check_data_values): Update.
1950         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1951         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1952         (tui_win_info::backward_scroll, tui_refresh_all_win)
1953         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1954         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1955         (tui_source_window_base::set_new_height)
1956         (tui_data_window::set_new_height)
1957         (make_invisible_and_set_new_height)
1958         (make_visible_with_new_height, new_height_ok)
1959         (parse_scrolling_args): Update.
1960         * tui/tui-stack.c (tui_show_frame_info): Update.
1961         * tui/tui-source.c (tui_set_source_content)
1962         (tui_set_source_content_nil, tui_source_is_displayed)
1963         (tui_source_window::do_scroll_vertical): Update.
1964         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1965         (tui_display_registers_from, tui_display_reg_element_at_line)
1966         (tui_check_register_values, tui_reg_command): Update.
1967         * tui/tui-layout.c (tui_default_win_height)
1968         (show_source_disasm_command, show_data, init_and_make_win)
1969         (show_source_or_disasm_and_command): Update.
1970         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1971         (tui_redisplay_readline, tui_mld_flush)
1972         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1973         (tui_getc): Update.
1974         * tui/tui-disasm.c (tui_set_disassem_content)
1975         (tui_disasm_window::do_scroll_vertical): Update.
1976         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1977         Now virtual.
1978         (struct tui_win_info): Derive from tui_gen_win_info.
1979         <~tui_win_info>: Mark as override.
1980         <generic>: Remove member.
1981         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1982         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1983         (~tui_data_window, ~tui_win_info)
1984         (tui_free_all_source_wins_content): Update.
1985         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1986
1987 2019-06-25  Tom Tromey  <tom@tromey.com>
1988
1989         * tui/tui-layout.c (init_and_make_win): Use new.
1990         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1991         destructor, initializers.
1992         (tui_alloc_generic_win_info): Don't declare.
1993         * tui/tui-data.c (_locator): Add argument to constructor.
1994         (source_win, disasm_win): New globals.
1995         (exec_info): Remove.
1996         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1997         Update.
1998         (tui_alloc_generic_win_info): Remove.
1999         (init_content_element): Use new.
2000         (tui_win_info::tui_win_info): Update.
2001         (free_content_elements) <case DATA_WIN>: Use delete.
2002
2003 2019-06-25  Tom Tromey  <tom@tromey.com>
2004
2005         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2006         * tui/tui-windata.c (tui_first_data_item_displayed)
2007         (tui_delete_data_content_windows): Update.
2008         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2009         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2010         (tui_display_registers_from, tui_check_register_values): Update.
2011         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2012         pointer.
2013         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2014         window.
2015         (tui_free_data_content): Update.
2016         (free_content_elements) <case DATA_WIN>: Free the window.
2017
2018 2019-06-25  Tom Tromey  <tom@tromey.com>
2019
2020         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2021         Update.
2022         * tui/tui-layout.c (make_command_window)
2023         (show_source_disasm_command, show_data, init_and_make_win)
2024         (show_source_or_disasm_and_command): Update.
2025         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2026         method.
2027         <can_highight, is_highlighted>: Now bool.
2028         (tui_set_win_highlight): Don't declare.
2029         * tui/tui-data.c (tui_set_win_highlight): Remove.
2030
2031 2019-06-25  Tom Tromey  <tom@tromey.com>
2032
2033         * tui/tui-wingeneral.c (make_visible): Remove check of window
2034         type.
2035
2036 2019-06-25  Tom Tromey  <tom@tromey.com>
2037
2038         * tui/tui-win.c (tui_win_info::max_height)
2039         (tui_cmd_window::max_height): New methods.
2040         (new_height_ok): Call max_height.
2041         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2042         <max_height>: New method.
2043
2044 2019-06-25  Tom Tromey  <tom@tromey.com>
2045
2046         * tui/tui-win.c (tui_source_window_base::set_new_height)
2047         (tui_data_window::set_new_height): New methods.
2048         (make_invisible_and_set_new_height): Call set_new_height method.
2049         * tui/tui-data.h (struct tui_win_info)
2050         (struct tui_source_window_base, struct tui_data_window)
2051         <set_new_height>: New method.
2052
2053 2019-06-25  Tom Tromey  <tom@tromey.com>
2054
2055         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2056         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2057         tui_refresh_data_win.
2058         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2059         method.
2060         (tui_refresh_all_win): Call the refresh_all method.
2061         (tui_set_focus): Likewise.
2062         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2063         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2064         Likewise.
2065
2066 2019-06-25  Tom Tromey  <tom@tromey.com>
2067
2068         * tui/tui-winsource.h (tui_refill_source_window)
2069         (tui_set_is_exec_point_at): Don't declare.
2070         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2071         (tui_source_window_base::refill): Rename from
2072         tui_refill_source_window.
2073         (tui_source_window_base::do_scroll_horizontal): Update.
2074         (tui_source_window_base::set_is_exec_point_at): Rename from
2075         tui_set_is_exec_point_at.
2076         (tui_update_all_breakpoint_info): Update.
2077         * tui/tui-stack.c (tui_show_frame_info): Update.
2078         * tui/tui-layout.c (show_data): Add cast.
2079         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2080         * tui/tui-data.h (struct tui_source_window_base) <refill,
2081         set_is_exec_point_at>: New methods.
2082         (tui_source_windows, tui_add_to_source_windows): Update types.
2083         (tui_add_to_source_windows): Remove redundant declaration.
2084         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2085         (tui_source_windows): Change return type.
2086         (tui_clear_source_windows_detail): Update.
2087         (tui_add_to_source_windows): Change type of parameter.
2088         (tui_free_all_source_wins_content): Update.
2089
2090 2019-06-25  Tom Tromey  <tom@tromey.com>
2091
2092         * tui/tui-wingeneral.c (tui_win_info::refresh)
2093         (tui_source_window_base::refresh): New methods.
2094         (tui_refresh_all): Call the refresh method.
2095         * tui/tui-data.h (struct tui_win_info)
2096         (struct tui_source_window_base) <refresh>: New method.
2097
2098 2019-06-25  Tom Tromey  <tom@tromey.com>
2099
2100         * tui/tui.h (tui_is_window_visible): Return bool.
2101         * tui/tui.c (tui_is_window_visible): Return bool.
2102         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2103         (tui_make_visible, tui_make_invisible)
2104         (tui_win_info::make_visible)
2105         (tui_source_window_base::make_visible, make_all_visible)
2106         (tui_make_all_visible, tui_make_all_invisible): Update.
2107         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2108         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2109         bool.
2110         (struct tui_win_info, struct tui_source_window_base)
2111         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2112         * tui/tui-data.c (tui_init_generic_part): Update.
2113
2114 2019-06-25  Tom Tromey  <tom@tromey.com>
2115
2116         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2117         (tui_source_window_base::make_visible): New methods.
2118         (make_all_visible): Make method call.
2119         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2120         (struct tui_source_window_base, struct tui_cmd_window): Override
2121         make_visible.
2122         (tui_win_is_source_type): Don't declare.
2123         * tui/tui-data.c (tui_win_is_source_type): Remove.
2124
2125 2019-06-25  Tom Tromey  <tom@tromey.com>
2126
2127         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2128         NULL check.
2129
2130 2019-06-25  Tom Tromey  <tom@tromey.com>
2131
2132         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2133         Inline constructor.  Add initializers for members.
2134         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2135         constructors; now inline in class.
2136
2137 2019-06-25  Tom Tromey  <tom@tromey.com>
2138
2139         * tui/tui-regs.c (tui_show_registers): Update.
2140         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2141         bool.
2142         * tui/tui-data.c (tui_data_window::clear_detail)
2143         (tui_data_window): Update.
2144
2145 2019-06-25  Tom Tromey  <tom@tromey.com>
2146
2147         * tui/tui-windata.c (tui_display_all_data)
2148         (tui_display_data_from_line, tui_display_data_from)
2149         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2150         Update.
2151         * tui/tui-regs.c (tui_last_regs_line_no)
2152         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2153         (tui_show_registers, tui_show_register_group)
2154         (tui_display_registers_from, tui_display_reg_element_at_line)
2155         (tui_display_registers_from_line, tui_check_register_values)
2156         (tui_reg_next, tui_reg_prev): Update.
2157         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2158         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2159         tui_data_window.
2160         (struct tui_win_info) <detail>: Remove.  Add new fields from
2161         tui_data_info.
2162         (TUI_DATA_WIN): Add cast.
2163         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2164         (~tui_data_window): Simplify.
2165
2166 2019-06-25  Tom Tromey  <tom@tromey.com>
2167
2168         * tui/tui-layout.c (show_source_disasm_command)
2169         (show_source_or_disasm_and_command): Update.
2170         * tui/tui-io.c (update_cmdwin_start_line)
2171         (tui_redisplay_readline): Update.
2172         * tui/tui-data.h (struct tui_command_info): Remove.
2173         (struct tui_win_info) <detail>: Remove command_info member.
2174         (struct tui_data_window) <start_line>: New member, from
2175         tui_command_info.
2176         (TUI_CMD_WIN): Add casts.
2177
2178 2019-06-25  Tom Tromey  <tom@tromey.com>
2179
2180         * tui/tui-winsource.c (tui_update_source_window)
2181         (tui_refill_source_window)
2182         (tui_source_window_base::do_scroll_horizontal)
2183         (tui_update_breakpoint_info, tui_set_exec_info_content)
2184         (tui_show_exec_info_content, tui_erase_exec_info_content)
2185         (tui_clear_exec_info_content): Update.
2186         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2187         Update.
2188         * tui/tui-win.c (make_invisible_and_set_new_height)
2189         (make_visible_with_new_height): Update.
2190         * tui/tui-source.c (tui_set_source_content)
2191         (tui_show_symtab_source): Update.
2192         * tui/tui-layout.c (extract_display_start_addr)
2193         (show_source_disasm_command, show_data)
2194         (make_source_or_disasm_window)
2195         (show_source_or_disasm_and_command): Update.
2196         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2197         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2198         "gdbarch".
2199         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2200         to tui_source_window_base.
2201         (struct tui_win_info) <detail>: Remove source_info member.
2202         (struct tui_source_window_base) <has_locator>: Inline.
2203         Move contents from tui_source_info; rename has_locator member to
2204         m_has_locator.
2205         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2206         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2207         header file.
2208         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2209         Simplify.
2210         (tui_free_all_source_wins_content): Cast to
2211         tui_source_window_base.
2212
2213 2019-06-25  Tom Tromey  <tom@tromey.com>
2214
2215         * tui/tui-win.c (make_invisible_and_set_new_height)
2216         (make_visible_with_new_height): Call has_locator method.
2217         * tui/tui-layout.c (show_source_disasm_command, show_data)
2218         (show_source_or_disasm_and_command): Update for bool change.
2219         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2220         (tui_win_info) <has_locator>: New method.
2221         (struct tui_source_window_base) <has_locator>: New method.
2222         (tui_win_has_locator): Don't declare.
2223         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2224         from tui_win_has_locator.
2225         (tui_source_window_base): Use false, not FALSE.
2226
2227 2019-06-25  Tom Tromey  <tom@tromey.com>
2228
2229         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2230         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2231         clear_detail method directly.
2232         (tui_clear_win_detail): Remove.
2233
2234 2019-06-25  Tom Tromey  <tom@tromey.com>
2235
2236         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2237         "this", not TUI_DISASM_WIN.
2238
2239 2019-06-25  Tom Tromey  <tom@tromey.com>
2240
2241         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2242         declare.
2243         * tui/tui-winsource.c
2244         (tui_source_window_base::do_scroll_horizontal): Rename from
2245         tui_horizontal_source_scroll.
2246         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2247         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2248         from tui_vertical_data_scroll.
2249         * tui/tui-win.h (tui_scroll): Don't declare.
2250         * tui/tui-win.c (tui_win_info::forward_scroll)
2251         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2252         (tui_win_info::right_scroll): Rename and update.
2253         (tui_scroll_forward_command, tui_scroll_backward_command)
2254         (tui_scroll_left_command, tui_scroll_right_command): Update.
2255         (tui_scroll): Remove.
2256         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2257         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2258         from tui_vertical_source_scroll.
2259         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2260         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2261         from tui_vertical_disassem_scroll.
2262         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2263         do_scroll_horizontal>: New methods.
2264         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2265         Likewise.
2266         (struct tui_source_window_base): Add do_scroll_horizontal.
2267         (struct tui_source_window, struct tui_disasm_window): Add
2268         do_scroll_vertical.
2269         (struct tui_data_window, struct tui_cmd_window): Add
2270         do_scroll_horizontal and do_scroll_vertical.
2271         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2272
2273 2019-06-25  Tom Tromey  <tom@tromey.com>
2274
2275         * tui/tui-data.h (struct tui_source_window_base): New struct.
2276         (struct tui_source_window): Derive from tui_source_window_base.
2277         (struct tui_disasm_window): New struct.
2278         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2279         from tui_source_window::clear_detail.
2280         (tui_source_window_base): Rename from tui_source_window.
2281         (~tui_source_window_base): Rename from ~tui_source_window.
2282         (tui_alloc_win_info): Create a tui_disasm_window.
2283
2284 2019-06-25  Tom Tromey  <tom@tromey.com>
2285
2286         * tui/tui-data.h (struct tui_source_window)
2287         (struct tui_data_window): Declare destructors.
2288         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2289         destructors.
2290         (tui_win_info): Simplify.
2291
2292 2019-06-25  Tom Tromey  <tom@tromey.com>
2293
2294         * tui/tui-winsource.c (tui_display_main)
2295         (tui_update_source_windows_with_addr)
2296         (tui_update_all_breakpoint_info): Update.
2297         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2298         (new_height_ok, parse_scrolling_args): Update.
2299         * tui/tui-stack.c (tui_show_frame_info): Update.
2300         * tui/tui-data.h (struct tui_list): Remove.
2301         (tui_source_windows): Return a reference to a std::vector.
2302         * tui/tui-data.c (source_windows): Now a std::vector.
2303         (tui_source_windows): Change return type.
2304         (tui_clear_source_windows): Rewrite.
2305         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2306         (tui_free_all_source_wins_content): Rewrite.
2307
2308 2019-06-25  Tom Tromey  <tom@tromey.com>
2309
2310         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2311         (struct tui_data_window, struct tui_cmd_window): Declare
2312         clear_detail method.
2313         * tui/tui-data.c (tui_source_window::clear_detail)
2314         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2315         methods.
2316         (tui_clear_win_detail): Simplify.
2317
2318 2019-06-25  Tom Tromey  <tom@tromey.com>
2319
2320         * tui/tui-layout.c (make_source_window, make_disasm_window)
2321         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2322         Return the new window.
2323         (show_source_disasm_command, show_data)
2324         (show_source_or_disasm_and_command): Update.
2325
2326 2019-06-25  Tom Tromey  <tom@tromey.com>
2327
2328         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2329         parameter.  Return the new window.
2330         (show_source_disasm_command): Update and remove NULL check.
2331         (show_source_or_disasm_and_command): Update.
2332
2333 2019-06-25  Tom Tromey  <tom@tromey.com>
2334
2335         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2336
2337 2019-06-25  Tom Tromey  <tom@tromey.com>
2338
2339         * tui/tui-data.h (struct tui_win_info): Make constructor
2340         protected.  Make destructor virtual.  Add initializers.
2341         (tui_source_window, tui_data_window, tui_cmd_window): New
2342         classes.
2343         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2344         constructor.  Add "type" parameter.
2345         (tui_source_window, tui_data_window, tui_cmd_window): New
2346         constructors.
2347         (tui_alloc_win_info): Instantiate the appropriate subclass.
2348
2349 2019-06-25  Tom Tromey  <tom@tromey.com>
2350
2351         * tui/tui-win.c (tui_resize_all): Use delete.
2352         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2353         destructor.
2354         (tui_free_window): Don't declare.
2355         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2356         Update.
2357
2358 2019-06-25  Tom Tromey  <tom@tromey.com>
2359
2360         * tui/tui-data.h (struct tui_win_info): Add constructor.
2361         * tui/tui-data.c (tui_alloc_win_info): Use new.
2362         (tui_free_window): Use delete.
2363
2364 2019-06-22  Tom Tromey  <tom@tromey.com>
2365
2366         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2367         declare.
2368         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2369
2370 2019-06-22  Tom Tromey  <tom@tromey.com>
2371
2372         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2373         declare.
2374         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2375
2376 2019-06-22  Tom de Vries  <tdevries@suse.de>
2377
2378         * dwarf2read.c (create_addrmap_from_aranges)
2379         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2380         instead of '%zu'.
2381
2382 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2383
2384         * dwarf2read.h (dwarf2_section_info_def): Remove.
2385         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2386         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2387         std::vector<dwarf2_section_info>.
2388         (struct dwo_file) <~dwo_file>: Remove.
2389         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2390         types field.
2391         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2392         (dwarf2_read_debug_names): Likewise.
2393         (create_debug_types_hash_table): Change parameter type to
2394         array_view, adjust code accordingly.
2395         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2396         (partial_die_info::fixup): Likewise.
2397         (determine_prefix): Likewise.
2398         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2399
2400 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2401
2402         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2403         gdb_bfd_ref_ptr.
2404         <~dwo_file>: Remove call to gdb_bfd_unref.
2405         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2406         gdb_bfd_ref_ptr::get.
2407
2408 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2409
2410         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2411         type to htab_up.
2412         * dwarf2read.c (struct dwo_file): Initialize fields.
2413         <~dwo_file>: New.
2414         (free_dwo_file): Remove, move content to ~dwo_file.
2415         (struct dwo_file_deleter): Remove.
2416         (dwo_file_up>: Remove custom deleter.
2417         (free_dwo_files): Remove.
2418         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2419         dwo_files.
2420         (process_skeletonless_type_units): Call unique_ptr::get.
2421         (allocate_dwo_file_hash_table): Add deleter to created hash
2422         table.  Change return type to htab_up.
2423         (lookup_dwo_file_slot): Don't memset dwo_file, call
2424         unique_ptr::get.
2425         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2426         (create_dwo_unit_in_dwp_v2): Likewise.
2427         (open_and_init_dwo_file): Likewise.
2428         (free_dwo_file_from_slot): Remove.
2429
2430 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2431
2432         * dwarf2read.h (struct dwarf2_section_info) <readin,
2433         is_virtual>: Change type to bool.
2434         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2435         true instead of 1.
2436
2437 2019-06-19  Tom Tromey  <tom@tromey.com>
2438
2439         * tui/tui-data.h (tui_init_content_element): Don't declare.
2440
2441 2019-06-19  Tom Tromey  <tom@tromey.com>
2442
2443         * tui/tui-data.h (tui_init_win_info): Don't declare.
2444
2445 2019-06-19  Tom de Vries  <tdevries@suse.de>
2446
2447         * dwarf2read.h (abstract_to_concrete): Change type to
2448         std::unordered_map<sect_offset, std::vector<sect_offset>,
2449         gdb::hash_enum<sect_offset>>.
2450
2451 2019-06-19  Tom Tromey  <tromey@adacore.com>
2452
2453         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2454         EVAL_AVOID_SIDE_EFFECTS specially.
2455
2456 2019-06-19  Tom Tromey  <tromey@adacore.com>
2457
2458         * source-cache.c (highlighter): New global.
2459         (source_cache::get_source_lines): Create a highlighter on demand.
2460
2461 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2462
2463         * defs.h (deprecated_interactive_hook): Delete declaration.
2464         * interps.c (clear_interpreter_hooks): Remove use of
2465         deprecated_interactive_hook.
2466         * top.c (deprecated_interactive_hook): Delete definition.
2467         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2468
2469 2019-06-18  Tom de Vries  <tdevries@suse.de>
2470
2471         PR gdb/24515
2472         * dwarf2read.h (abstract_to_concrete): Change type from
2473         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2474         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2475         * dwarf2read.c (read_variable): Update.
2476         (dwarf2_fetch_die_loc_sect_off): Update.
2477
2478 2019-06-17  Tom de Vries  <tdevries@suse.de>
2479
2480         PR gdb/24617
2481         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2482         accessing parent[parent_len - 1].
2483
2484 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2485
2486         PR gdb/24364
2487         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2488         call dtrace_process_dof with NULL dof.
2489
2490 2019-06-16  Tom de Vries  <tdevries@suse.de>
2491
2492         PR gdb/24445
2493         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2494
2495 2019-06-16  Tom Tromey  <tom@tromey.com>
2496
2497         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2498         (make_all_visible): Use address of member.
2499
2500 2019-06-16  Tom Tromey  <tom@tromey.com>
2501
2502         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2503         (tui_free_window, free_content, free_content_elements): Remove
2504         unnecessary cast.
2505         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2506         cast.
2507         * tui/tui-regs.c (tui_show_register_group)
2508         (tui_display_registers_from, tui_display_reg_element_at_line):
2509         Remove unnecessary cast.
2510
2511 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2512
2513         * linux-nat.c (normal_mask): Delete.
2514         (_initialize_linux_nat): Don't initialise normal_mask.
2515
2516 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2517
2518         PR gdb/24445
2519         * dwarf-index-write.h (write_psymtabs_to_index): Add
2520         dwz_basename parameter.
2521         * dwarf-index-write.c (write_gdbindex): Move file writing to
2522         write_gdbindex_1.  Change return type void.
2523         (assert_file_size): Move up, remove filename parameter.
2524         (write_gdbindex_1): New function.
2525         (write_debug_names): Change return type to void, call
2526         assert_file_size.
2527         (struct index_wip_file): New struct.
2528         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2529         file logic to index_wip_file.  Write index for dwz file if
2530         needed.
2531         (save_gdb_index_command): Pass basename of dwz file, if present.
2532         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2533         build-id of dwz file, if present.
2534         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2535         (dwarf2_get_dwz_file): Likewise.
2536         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2537         (dwarf2_get_dwz_file): Likewise.
2538
2539 2019-06-16  Tom Tromey  <tom@tromey.com>
2540
2541         * coffread.c (process_coff_symbol): Use xstrdup.
2542         * value.c (create_internalvar): Use xstrdup.
2543
2544 2019-06-16  Tom Tromey  <tom@tromey.com>
2545
2546         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2547         * breakpoint.c (stopin_command, stopat_command)
2548         (until_break_command, decode_location_default): Remove unnecessary
2549         cast.
2550         * utils.c (subset_compare): Remove unnecessary cast.
2551         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2552         cast.
2553         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2554         cast.
2555         * infcmd.c (path_command): Remove unnecessary cast.
2556         * coffread.c (decode_type): Remove unnecessary cast.
2557         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2558         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2559         * tui/tui-stack.c (tui_show_locator_content)
2560         (tui_show_frame_info): Remove unnecessary cast.
2561         * tui/tui-win.c (tui_scroll_forward_command)
2562         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2563         (parse_scrolling_args): Remove unnecessary cast.
2564         * tui/tui-data.c (init_win_info, tui_del_window)
2565         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2566         (free_content_elements): Remove unnecessary cast.
2567         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2568         unnecessary cast.
2569         * tui/tui-source.c (tui_set_source_content)
2570         (tui_vertical_source_scroll): Remove unnecessary cast.
2571         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2572         cast.
2573         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2574         * tui/tui-regs.c (tui_display_registers_from)
2575         (tui_display_register): Remove unnecessary cast.
2576         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2577         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2578         (make_visible): Remove unnecessary cast.
2579         * tui/tui-winsource.c (tui_erase_source_content)
2580         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2581         unnecessary cast.
2582         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2583         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2584         * stabsread.c (read_type, read_array_type, read_range_type):
2585         Remove unnecessary cast.
2586         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2587         (parse_symbol, parse_type, upgrade_type, parse_external)
2588         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2589         unnecessary cast.
2590         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2591
2592 2019-06-16  Tom Tromey  <tom@tromey.com>
2593
2594         * tui/tui-data.c (tui_alloc_generic_win_info)
2595         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2596         checks.
2597
2598 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2599             Andrew Burgess  <andrew.burgess@embecosm.com>
2600
2601         * f-typeprint.c (f_print_type): Don't return early for not
2602         associated or not allocated types.
2603         (f_type_print_varspec_suffix): Add print_rank parameter and print
2604         ranks of array types in case they dangling.
2605         (f_type_print_base): Add print_rank parameter.
2606
2607 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2608
2609         * NEWS: Mention new MI commands.
2610         * break-catch-throw.c (enum exception_event_kind): Move to
2611         breakpoint.h.
2612         (print_mention_exception_catchpoint): Output text as a single
2613         message.
2614         (catch_exception_command_1): Rename to...
2615         (catch_exception_event): ...this, make non-static, update header
2616         command, and change some parameter types.
2617         (catch_catch_command): Update for changes to
2618         catch_exception_command_1.
2619         (catch_throw_command): Likewise.
2620         (catch_rethrow_command): Likewise.
2621         * breakpoint.c (enum exception_event_kind): Delete.
2622         * breakpoint.h (enum exception_event_kind): Moved here from
2623         break-catch-throw.c.
2624         (catch_exception_event): Declare.
2625         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2626         (mi_cmd_catch_throw): New function.
2627         (mi_cmd_catch_rethrow): New function.
2628         (mi_cmd_catch_catch): New function.
2629         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2630         'catch-catch' entries.
2631         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2632         (mi_cmd_catch_rethrow): Declare.
2633         (mi_cmd_catch_catch): Declare.
2634
2635 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2636
2637         * annotate.c (annotate_source_line): Change return type to void,
2638         update implementation to match.
2639         * annotate.h (annotate_source_line): Change return type to void,
2640         update header comment.
2641         * stack.c (print_frame_info): Don't change what frame information
2642         is printed based on whether annotations are on or not.
2643
2644 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2645
2646         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2647         (annotate_source): Make static.
2648         (annotate_source_line): Moved from source.c and renamed from
2649         identify_source_line.  Update the return type.
2650         * annotate.h (annotate_source): Delete declaration.
2651         (annotate_source_line): Declaration moved from source.h, and
2652         renamed from identify_source_line.  Return type updated.
2653         * source.c (identify_source_line): Moved to annotate.c and renamed
2654         to annotate_source_line.
2655         (info_line_command): Remove check of annotation_level.
2656         * source.h (identify_source_line): Move declaration to annotate.h
2657         and rename to annotate_source_line.
2658         * stack.c: Add 'annotate.h' include.
2659         (print_frame_info): Remove check of annotation_level before
2660         calling annotate_source_line.
2661
2662 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2663
2664         * source-cache.c (source_cache::get_plain_source_lines): Use
2665         open_source_file_with_line_charpos instead of just
2666         open_source_file, remove call to find_source_lines.
2667         (source_cache::get_source_lines): Likewise.
2668         * source.c (find_source_lines): Make static.
2669         (get_filename_and_charpos): Renamed into...
2670         (open_source_file_with_line_charpos): ..this along with changes to
2671         return a scoped_fd, and some other minor clean ups.
2672         (identify_source_line): Use open_source_file_with_line_charpos.
2673         (search_command_helper): Use open_source_file_with_line_charpos
2674         instead of just open_source_file, remove call to
2675         find_source_lines.
2676         * source.h (open_source_file_with_line_charpos): Declare new
2677         function.
2678         (find_source_lines): Delete declaration.
2679
2680 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2681
2682         * source.c (get_filename_and_charpos): Remove fullname
2683         parameter.
2684         (identify_source_line): Update call to get_filename_and_charpos.
2685
2686 2019-06-14  Tom Tromey  <tromey@adacore.com>
2687
2688         PR gdb/24502:
2689         * ui-style.h (skip_ansi_escape): Update comment.
2690         * ui-file.h (class no_terminal_escape_file): New class.
2691         * ui-file.c (no_terminal_escape_file::write)
2692         (no_terminal_escape_file::puts): New methods.
2693         * cli/cli-logging.c (handle_redirections): Use
2694         no_terminal_escape_file.
2695
2696 2019-06-14  Tom Tromey  <tromey@adacore.com>
2697
2698         * NEWS: Move convenience variable news above Python news.
2699
2700 2019-06-14  Tom Tromey  <tom@tromey.com>
2701
2702         * gnulib: Move directory to top-level.
2703         * configure.ac: Don't configure gnulib.
2704         * configure: Rebuild.
2705         * common/common-defs.h: Use new path to gnulib.
2706         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2707         (GNULIB_H): Remove.
2708         (INCGNU): Look in new gnulib location.
2709         (HFILES_NO_SRCDIR): Remove gnulib files.
2710         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2711         (generated_files): Remove GNULIB_H.
2712         ($(LIBGNU), all-lib): Remove targets.
2713         (distclean): Don't mention GNULIB_BUILDDIR.
2714         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2715
2716 2019-06-14  Tom Tromey  <tromey@adacore.com>
2717
2718         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2719         Warn if symbol file does not provide any symbols.
2720
2721 2019-06-14  Tom Tromey  <tromey@adacore.com>
2722
2723         * source.c (find_and_open_source): Respect basenames_may_differ.
2724
2725 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2726
2727         * annotate.c (annotate_breakpoints_invalid): Make use of
2728         scoped_restore_terminal_state.
2729         (annotate_frames_invalid): Likewise.
2730
2731 2019-06-14  Tom Tromey  <tromey@adacore.com>
2732
2733         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2734         allow assignment to an internalvar.
2735
2736 2019-06-14  Tom Tromey  <tromey@adacore.com>
2737
2738         * ada-lex.l: Allow "_" in attribute names.
2739
2740 2019-06-14  Tom Tromey  <tromey@adacore.com>
2741
2742         PR gdb/24653:
2743         * regcache.c (registers_changed): Don't call alloca.
2744         * top.c (execute_command): Don't call alloca.
2745
2746 2019-06-13  Pedro Alves  <palves@redhat.com>
2747
2748         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2749         'expression'.  When parsing an expression, error out if there's
2750         junk after "unlimited".
2751         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2752         (do_set_command): Adjust calls to is_unlimited_literal.
2753
2754 2019-06-13  Pedro Alves  <palves@redhat.com>
2755
2756         * compile/compile.c (make_compile_options_def_group): Add braces
2757         around array_view initializer.
2758         * thread.c (make_thread_apply_all_options_def_group)
2759         (make_thread_apply_all_options_def_group): Likewise.
2760
2761 2019-06-13  Pedro Alves  <palves@redhat.com>
2762
2763         * NEWS (New commands): Mention "maint test-options
2764         require-delimiter", "maint test-options unknown-is-error", "maint
2765         test-options unknown-is-operand" and "maint show
2766         test-options-completion-result".
2767         (New command options, command completion): New section.
2768         (Completion improvements): New section.
2769         Mention that you can abbreviate "unlimited".
2770
2771 2019-06-13  Pedro Alves  <palves@redhat.com>
2772
2773         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2774         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2775         * unittests/cli-utils-selftests.c (test_parse_flags)
2776         (test_parse_flags_qcs): Delete.
2777         (test_cli_utils): Don't call deleted functions.
2778
2779 2019-06-13  Pedro Alves  <palves@redhat.com>
2780
2781         * thread.c: Include "cli/cli-option.h".
2782         (tp_array_compar_ascending): Global.
2783         (tp_array_compar): Delete function.
2784         (tp_array_compar_ascending, tp_array_compar_descending): New
2785         functions.
2786         (ascending_option_def, qcs_flag_option_def)
2787         (thr_qcs_flags_option_defs)
2788         (make_thread_apply_all_options_def_group)
2789         (make_thread_apply_options_def_group): New.
2790         (thread_apply_all_command): Use gdb::option::process_options.
2791         (thread_apply_command_completer)
2792         (thread_apply_all_command_completer): New.
2793         (thread_apply_command): Use gdb::option::process_options.
2794         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2795         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2796         to generate help text of "thread apply".  Adjust "taas"'s help.
2797         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2798         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2799
2800 2019-06-13  Pedro Alves  <palves@redhat.com>
2801
2802         * thread.c (thread_apply_command): Check for invalid TID with
2803         isdigit instead of !isalpha.
2804
2805 2019-06-13  Pedro Alves  <palves@redhat.com>
2806
2807         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2808         (validate_flags_qcs): New.
2809         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2810         (validate_flags_qcs): Declare.
2811         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2812         (make_frame_apply_options_def_group): New.
2813         (frame_apply_command_count): Process options with
2814         gdb::option::process_options.
2815         (frame_apply_completer): New.
2816         (frame_apply_level_completer, frame_apply_all_completer)
2817         (frame_apply_completer): New.
2818         (_initialize_stack): Update help of "frame apply", "frame apply
2819         level", "frame apply all" and "faas" to mention supported options
2820         and install command completers.
2821         * stack.h (frame_apply_all_completer): Declare.
2822         * thread.c: Include "stack.h".
2823         (tfaas_command): Add "--".
2824         (_initialize_thread): Update help "tfaas" to mention supported
2825         options and install command completer.
2826
2827 2019-06-13  Pedro Alves  <palves@redhat.com>
2828
2829         * completer.c (complete_nested_command_line): New.
2830         (gdb_completion_word_break_characters_throw): Add assertion.
2831         * completer.h (complete_nested_command_line): Declare.
2832
2833 2019-06-13  Pedro Alves  <palves@redhat.com>
2834
2835         * stack.c (parse_backtrace_qualifiers): New.
2836         (backtrace_command): Use it.
2837         (backtrace_command_completer): Complete on qualifiers.
2838
2839 2019-06-13  Pedro Alves  <palves@redhat.com>
2840
2841         * frame.c: Include "cli/cli-option.h.
2842         (user_set_backtrace_options): New.
2843         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2844         Delete.
2845         (get_prev_frame): Adjust.
2846         (boolean_option_def, uinteger_option_def)
2847         (set_backtrace_option_defs): New.
2848         (_initialize_frame): Adjust and use
2849         gdb::option::add_setshow_cmds_for_options to install "set
2850         backtrace past-main" and "set backtrace past-entry".
2851         * frame.h: Include "cli/cli-option.h".
2852         (struct frame_print_options): Forward declare.
2853         (print_frame_arguments_all, print_frame_arguments_scalars)
2854         (print_frame_arguments_none): Declare.
2855         (print_entry_values): Delete declaration.
2856         (struct frame_print_options, user_frame_print_options): New.
2857         (struct set_backtrace_options): New.
2858         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2859         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2860         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2861         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2862         (list_args_or_locals): Add frame_print_options parameter.
2863         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2864         * python/py-framefilter.c (enumerate_args): Pass down
2865         USER_FRAME_PRINT_OPTIONS.
2866         * stack.c: Include "cli/cli-option.h".
2867         (print_frame_arguments_all, print_frame_arguments_scalars)
2868         (print_frame_arguments_none): Declare.
2869         (print_raw_frame_arguments, print_entry_values): Delete.
2870         (user_frame_print_options): New.
2871         (boolean_option_def, enum_option_def, frame_print_option_defs):
2872         New.
2873         (struct backtrace_cmd_options): New.
2874         (bt_flag_option_def): New.
2875         (backtrace_command_option_defs): New.
2876         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2877         (print_frame_arg, read_frame_arg, print_frame_args)
2878         (print_frame_info, print_frame): Add frame_print_options parameter
2879         and use it.
2880         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2881         (backtrace_command_1): Add frame_print_options and
2882         backtrace_cmd_options parameters and use them.
2883         (make_backtrace_options_def_group): New.
2884         (backtrace_command): Process command options with
2885         gdb::option::process_options.
2886         (backtrace_command_completer): New.
2887         (_initialize_stack): Extend "backtrace"'s help to mention
2888         supported options.  Install completer for "backtrace".
2889         Install some settings commands with add_setshow_cmds_for_options.
2890
2891 2019-06-13  Pedro Alves  <palves@redhat.com>
2892
2893         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2894         and that "set/show print raw frame-arguments" are now deprecated.
2895
2896         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2897         command.
2898         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2899         * stack.c (_initialize_stack): Install "set/show print
2900         raw-frame-arguments", and deprecate "set/show print raw
2901         frame-arguments".
2902         * valprint.c (_initialize_valprint): Deprecate "set/show print
2903         raw".
2904
2905 2019-06-13  Pedro Alves  <palves@redhat.com>
2906
2907         * compile/compile.c (struct compile_options): New.
2908         (compile_flag_option_def, compile_command_option_defs)
2909         (make_compile_options_def_group): New.
2910         (compile_file_command): Handle options with
2911         gdb::option::process_options.
2912         (compile_file_command_completer): New function.
2913         (compile_code_command): Handle options with
2914         gdb::option::process_options.
2915         (compile_code_command_completer): New function.
2916         (_initialize_compiler): Install completers for "compile code" and
2917         "compile file".  Mention available options in "compile code" and
2918         "compile code"'s help.
2919         * completer.c (advance_to_completion_word): New, factored out from
2920         ...
2921         (advance_to_expression_complete_word_point): ... this.
2922         (advance_to_filename_complete_word_point): New.
2923         * completer.h (advance_to_filename_complete_word_point): New
2924         declaration.
2925
2926 2019-06-13  Pedro Alves  <palves@redhat.com>
2927
2928         * compile/compile.c: Include "cli/cli-option.h".
2929         (compile_print_value): Scope data pointer is now a
2930         value_print_options pointer; adjust.
2931         (compile_print_command): Process options.  Scope data pointer is
2932         now a value_print_options pointer; adjust.
2933         (_initialize_compile): Update "compile print"'s help to include
2934         supported options.  Install a completer for "compile print".
2935         * cp-valprint.c (show_vtblprint, show_objectprint)
2936         (show_static_field_print): Delete.
2937         (_initialize_cp_valprint): Don't install "set print
2938         static-members", "set print vtbl", "set print object" here.
2939         * printcmd.c: Include "cli/cli-option.h" and
2940         "common/gdb_optional.h".
2941         (print_command_parse_format): Rework to fill in a
2942         value_print_options instead of a format_data.
2943         (print_value): Change parameter type from format_data pointer to
2944         value_print_options reference.  Adjust.
2945         (print_command_1): Process options.  Adjust to pass down a
2946         value_print_options.
2947         (print_command_completer): New.
2948         (_initialize_printcmd): Install print_command_completer as
2949         handle_brkchars completer for the "print" command.  Update
2950         "print"'s help to include supported options.
2951         * valprint.c: Include "cli/cli-option.h".
2952         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2953         here from cp-valprint.c.
2954         (boolean_option_def, uinteger_option_def)
2955         (value_print_option_defs, make_value_print_options_def_group):
2956         New.  Use gdb::option::add_setshow_cmds_for_options to install
2957         "set print elements", "set print null-stop", "set print repeats",
2958         "set print pretty", "set print union", "set print array", "set
2959         print address", "set print symbol", "set print array-indexes".
2960         * valprint.h: Include <string> and "cli/cli-option.h".
2961         (make_value_print_options_def_group): Declare.
2962         (print_value): Change parameter type from format_data pointer to
2963         value_print_options reference.
2964         (print_command_completer): Declare.
2965
2966 2019-06-13  Pedro Alves  <palves@redhat.com>
2967
2968         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2969         (COMMON_SFILES): Add maint-test-settings.c.
2970         * cli/cli-decode.c (boolean_enums): New global, factored out from
2971         ...
2972         (add_setshow_boolean_cmd): ... here.
2973         * cli/cli-decode.h (boolean_enums): Declare.
2974         * cli/cli-option.c: New file.
2975         * cli/cli-option.h: New file.
2976         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2977         factored out from ...
2978         (parse_cli_boolean_value(const char *)): ... this.
2979         (is_unlimited_literal): Change parameter type to pointer to
2980         pointer.  Adjust and advance ARG pointer.
2981         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2982         (parse_cli_var_enum): New, factored out from ...
2983         (do_set_command): ... this.  Adjust.
2984         * cli/cli-setshow.h (parse_cli_boolean_value)
2985         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2986         (parse_cli_var_enum): Declare.
2987         * cli/cli-utils.c: Include "cli/cli-option.h".
2988         (get_ulongest): New.
2989         * cli/cli-utils.h (get_ulongest): Declare.
2990         (check_for_argument): New overloads.
2991         * maint-test-options.c: New file.
2992
2993 2019-06-13  Pedro Alves  <palves@redhat.com>
2994
2995         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2996         parse a range if "-" is at the end of the string.
2997
2998 2019-06-13  Pedro Alves  <palves@redhat.com>
2999
3000         * cli/cli-setshow.c (parse_auto_binary_operation)
3001         (parse_cli_boolean_value): Don't allow "o".
3002
3003 2019-06-13  Pedro Alves  <palves@redhat.com>
3004
3005         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3006         * NEWS: Mention maint test-settings KIND.
3007         * maint-test-settings.c: New file.
3008
3009 2019-06-13  Pedro Alves  <palves@redhat.com>
3010
3011         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3012         completer.
3013         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3014         "set" completers.
3015
3016 2019-06-13  Pedro Alves  <palves@redhat.com>
3017
3018         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3019         after item.
3020
3021 2019-06-13  Pedro Alves  <palves@redhat.com>
3022
3023         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3024
3025 2019-06-13  Pedro Alves <palves@redhat.com>
3026
3027         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3028         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3029         call.
3030         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3031         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3032         calls.
3033         (check_for_argument): Skip spaces after argument.
3034
3035 2019-06-13  Pedro Alves  <palves@redhat.com>
3036
3037         * thread.c (thread_apply_command): Adjust TID parsing.
3038         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3039         detected before end of string.
3040         (tid_is_in_list): Error out if LIST is invalid.
3041
3042 2019-06-13  Pedro Alves  <palves@redhat.com>
3043
3044         * completer.c (complete_line_internal_1): Rewind completion word
3045         point.
3046         (completion_tracker::advance_custom_word_point_by): Change
3047         parameter type to int.
3048         * completer.h (completion_tracker::advance_custom_word_point_by):
3049         Likewise.
3050
3051 2019-06-13  Pedro Alves  <palves@redhat.com>
3052
3053         * completer.c (advance_to_completion_word): Handle delimiters.
3054
3055 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3056
3057         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3058
3059 2019-06-11  Tom Tromey  <tom@tromey.com>
3060
3061         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3062         (xmalloc_failed): Move to alloc.c.
3063         * alloc.c: New file.
3064         * Makefile.in (COMMON_SFILES): Add alloc.c.
3065
3066 2019-06-11  Tom Tromey  <tom@tromey.com>
3067
3068         * nat/linux-waitpid.c: Don't include server.h.
3069         (linux_debug): Remove.
3070         (my_waitpid): Update.
3071
3072 2019-06-11  Tom Tromey  <tromey@adacore.com>
3073
3074         * infcall.c (_initialize_infcall): Remove trailing newline from
3075         help.
3076         * user-regs.c (_initialize_user_regs): Remove trailing newline
3077         from help.
3078         * typeprint.c (_initialize_typeprint): Remove trailing newline
3079         from help.
3080         * reverse.c (_initialize_reverse): Remove trailing newlines from
3081         help.
3082         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3083         from help.
3084         * language.c (add_set_language_command): Remove trailing newline
3085         from help.
3086         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3087         help.
3088         * disasm.c (_initialize_disasm): Remove trailing newline from
3089         help.
3090         * top.c (init_main): Remove trailing newline from help.
3091         * interps.c (_initialize_interpreter): Remove trailing newline
3092         from help.
3093         * btrace.c (_initialize_btrace): Remove trailing newlines from
3094         help.
3095         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3096         from help.
3097         * python/python.c (_initialize_python): Remove trailing newline
3098         from help.
3099         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3100         help.
3101         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3102         from help.  Reformat some text.
3103         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3104         from help.
3105         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3106         newline from help.
3107
3108 2019-06-11  Tom Tromey  <tromey@adacore.com>
3109
3110         * darwin-nat.c (darwin_decode_exception_message)
3111         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3112
3113 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3114
3115         * valops.c (value_slice): Check for not allocated or not
3116         associated values.
3117
3118 2019-06-10  Tom de Vries  <tdevries@suse.de>
3119
3120         PR gdb/24618
3121         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3122         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3123         invalid.
3124
3125 2019-06-10  Tom de Vries  <tdevries@suse.de>
3126
3127         PR gdb/24611
3128         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3129         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3130
3131 2019-06-10  Tom de Vries  <tdevries@suse.de>
3132
3133         PR symtab/24545
3134         * symtab.c (struct demangled_name_entry): Add language field.
3135         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3136         static minimal symbol".  Set and use language field.
3137
3138 2019-06-10  Tom Tromey  <tromey@adacore.com>
3139
3140         * ada-lang.c (_initialize_ada_language): Update help text.
3141
3142 2019-06-10  Tom Tromey  <tromey@adacore.com>
3143
3144         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3145         with a newline.
3146         * guile/guile.c (handle_boot_error): Don't end warning with a
3147         newline.
3148         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3149         warning with a newline.
3150         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3151         newline.
3152         (s12z_frame_cache): Likewise.
3153         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3154         a newline.
3155         * solib-svr4.c (disable_probes_interface): Don't end warning with
3156         a newline.
3157         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3158         newline.
3159         * python/python.c (do_finish_initialization): Don't end warning
3160         with a newline.
3161
3162 2019-06-10  Tom Tromey  <tom@tromey.com>
3163
3164         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3165         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3166         gdbpy_enter.
3167
3168 2019-06-10  Tom Tromey  <tromey@adacore.com>
3169
3170         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3171         data.
3172         (elf_new_init): Don't call stabsread_new_init.
3173         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3174         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3175         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3176
3177 2019-06-10  Tom de Vries  <tdevries@suse.de>
3178
3179         PR symtab/16264
3180         PR symtab/24517
3181         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3182
3183 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3184
3185         * source.c (find_and_open_source): Also rewrite relative file
3186         names.
3187
3188 2019-04-26  Amos Bird  <amosbird@gmail.com>
3189
3190         * annotate.c (annotate_thread_exited): Add "thread-exited"
3191         annotation.
3192
3193 2019-06-06  Tom Tromey  <tromey@adacore.com>
3194
3195         * maint.h (class scoped_command_stats): Use
3196         DISABLE_COPY_AND_ASSIGN.
3197         <print_time>: New method.
3198         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3199         print_time.
3200         (scoped_command_stats::print_time): New method.
3201
3202 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3203
3204         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3205         instructions of lengths 6 or 8 bytes.
3206
3207 2019-06-04  Pedro Alves  <palves@redhat.com>
3208
3209         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3210
3211         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3212         * breakpoint.c (condition_completer): Likewise.
3213         * cli/cli-dump.c (scan_expression): Likewise.
3214         * common/filestuff.c (mkdir_recursive): Likewise.
3215         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3216         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3217         (gdb_abspath): Likewise.
3218         * compile/compile-cplus-types.c
3219         (compile_cplus_instance::decl_name): Likewise.
3220         * completer.c (complete_explicit_location):
3221         (signal_completer, reg_or_group_completer_1): Likewise.
3222         * cp-support.c (cp_remove_params_if_any): Likewise.
3223         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3224         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3225         * infcmd.c (strip_bg_char): Likewise.
3226         * linespec.c (copy_token_string): Likewise.
3227         * mi/mi-main.c (output_cores): Likewise.
3228         * psymtab.c (psymtab_search_name):
3229         * symfile.c (test_set_ext_lang_command): Likewise.
3230         * target.c (target_fileio_read_stralloc): Likewise.
3231         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3232         * value.c (complete_internalvar): Likewise.
3233
3234 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3235
3236         Add objfile property to gdb.Type.
3237         * NEWS: Mention Python API addition.
3238         * python/py-type.c (typy_get_objfile): New method.
3239
3240 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3241
3242         * NEWS: Mention the new set|show style [title|highlight].
3243         Mention changes to "show style", "help" and "apropos".
3244
3245 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3246
3247         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3248         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3249         instead of print_help_for_command.
3250         (print_doc_of_command): New function.
3251         (help_list): Add 'apropos -v word' suggestion.
3252         (print_help_for_command): Style the command name using title style.
3253         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3254         (_initialize_cli_cmds): Describe -v in apropos_command help.
3255
3256 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3257
3258         * cli/cli-style.h (cli_style_option): Add name in constructor,
3259         add m_name class member, add constructor with intensity,
3260         add name class function.
3261         (cli_style_option::add_setshow_commands): Remove name argument.
3262         (highlight_style, title_style): New styles.
3263         * cli/cli-style.c (do_show): New function that shows a style
3264         characteristic styling the style name with itself.
3265         (set_style_name): New function.
3266         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3267         Update all callers according to the changes in cli/cli-style.h.
3268         * utils.h (fputs_highlighted): New function.
3269         * utils.c (fputs_highlighted): Likewise.
3270
3271 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3272
3273         * NEWS: Mention new pipe command and new convenience variables.
3274
3275 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3276
3277         * cli/cli-cmds.c (pipe_command): New function.
3278         (_initialize_cli_cmds): Call add_com for pipe_command.
3279         Define | as an alias for pipe.
3280         (exit_status_set_internal_vars): New function.
3281         (shell_escape): Call exit_status_set_internal_vars.
3282         cli/cli-decode.c (find_command_name_length): Recognize | as
3283         a single character command.
3284
3285 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3286
3287         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3288         top.c (execute_command_to_ui_file): New function, mostly a copy
3289         of execute_command_to_string.
3290         (execute_command_to_string): Implement by calling
3291         execute_command_to_ui_file.
3292
3293 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3294
3295         * top.h (saved_command_line): Remove declaration.
3296         * top.c (previous_saved_command_line, previous_repeat_arguments):
3297         New variables.
3298         (saved_command_line): Make static, define together with other
3299         'repeat variables'.
3300         (dont_repeat): Clear repeat_arguments.
3301         (repeat_previous, get_saved_command_line, save_command_line):
3302         New functions.
3303         (gdb_init): Initialize saved_command_line
3304         and previous_saved_command_line.
3305         * main.c (captured_main_1): Remove saved_command_line initialization.
3306         * event-top.c (handle_line_of_input): Update to use
3307         the new 'repeat' related functions instead of direct access to
3308         saved_command_line.
3309         * command.h (repeat_previous, get_saved_command_line,
3310         save_command_line): New declarations.
3311         (dont_repeat): Add comment.
3312
3313 2019-05-30  Tom Tromey  <tromey@adacore.com>
3314
3315         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3316         Fix comment.
3317         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3318
3319 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3320
3321         PR cli/24587
3322         * completer.c (complete): Initialize variable word.
3323
3324 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3325
3326         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3327         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3328         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3329         'body' is NULL to the outter 'if', protecting the '!is_define'
3330         situation as well.
3331
3332 2019-05-29  Tom Tromey  <tromey@adacore.com>
3333
3334         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3335         (dwarf_unknown): New function.
3336         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3337         (dwarf_type_encoding_name): Use dwarf_unknown.
3338
3339 2019-05-29  Tom Tromey  <tromey@adacore.com>
3340
3341         PR c++/20020:
3342         * cp-valprint.c (cp_print_value_fields): Call
3343         cp_print_static_field inside "try".
3344
3345 2019-05-29  Tom Tromey  <tromey@adacore.com>
3346
3347         * inflow.c (struct terminal_info): Add default operator=.
3348         * configure: Rebuild.
3349         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3350         -Wdeprecated-copy-dtor, -Wredundant-move.
3351
3352 2019-05-29  Tom Tromey  <tromey@adacore.com>
3353
3354         * NEWS: Add entry.
3355         * infcmd.c (print_return_value_1): Handle finish_print
3356         option.
3357         (show_print_finish): New function.
3358         (_initialize_infcmd): Add "set/show print finish" commands.
3359         * valprint.c (user_print_options): Initialize new member.
3360         * valprint.h (struct value_print_options) <finish_print>: New
3361         member.
3362
3363 2019-05-28  Tom Tromey  <tromey@adacore.com>
3364
3365         * ada-lang.c (ada_remove_Xbn_suffix)
3366         (find_old_style_renaming_symbol)
3367         (parse_old_style_renaming): Remove.
3368         (ada_find_renaming_symbol): Don't call
3369         find_old_style_renaming_symbol.
3370         (ada_is_renaming_symbol): Rename from
3371         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3372         bool.  Now static.
3373         (ada_read_var_value): Update and simplify.
3374         * ada-exp.y (write_var_or_type): Remove old code.
3375
3376 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3377
3378         * event-top.c: Remove include comment.
3379         * inflow.c (class scoped_ignore_sigttou): Move from here...
3380         * inflow.h (class scoped_ignore_sigttou): ...to here.
3381         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3382         * top.c:  Remove include comment.
3383
3384 2019-05-27  Tom Tromey  <tom@tromey.com>
3385
3386         * NEWS: Fix typo.
3387
3388 2019-05-22  Tom Tromey  <tromey@adacore.com>
3389
3390         * target.c (target_follow_exec): Constify parameter.
3391         * target-delegates.c: Rebuild.
3392         * remote.c (remote_target::follow_exec): Constify parameter.
3393         * infrun.c (follow_exec): Constify parameter.
3394         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3395         (target_follow_exec): Likewise.
3396
3397 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3398
3399         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3400         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3401
3402 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3403
3404         * NEWS: Add debugredirect and testsuite sections.
3405
3406 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3407
3408         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3409         target descriptions using exclusively floating point register name
3410         aliases.
3411
3412 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3413
3414         PR gdb/18644:
3415         * f-lang.c (build_fortran_types): Handle the case where
3416         gdbarch_floatformat_for_type returns a nullptr.
3417
3418 2019-05-21  Tom de Vries  <tdevries@suse.de>
3419
3420         PR cli/24587
3421         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3422
3423 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3424
3425         PR gdb/18644:
3426         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3427         16-byte floats.
3428         * i386-tdep.c (i386_floatformat_for_type): Use
3429         floatformats_ia64_quad for the 16-byte floating point component
3430         within a fortran 32-byte complex number.
3431
3432 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3433
3434         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3435         delete default constructor.
3436         (find_partial_die): Update to return const struct.
3437         (partial_die_parent_scope): Move variable declaration into scope
3438         of its use and change its type to auto.
3439         (guess_partial_die_structure_name): Likewise.
3440         (partial_die_info::fixup): Likewise.
3441
3442 2019-05-17  Tom Tromey  <tromey@adacore.com>
3443
3444         * source.c (find_and_open_source): Remove cast.
3445
3446 2019-05-17  Tom Tromey  <tromey@adacore.com>
3447
3448         * annotate.c (annotate_source): Make "filename" const.
3449         * annotate.h (annotate_source): Use const.
3450
3451 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3452
3453         * disasm.c (set_disassembler_options): Send errors to stderr.
3454
3455 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3456
3457         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3458         (cli_interp_base::set_logging): Check debug_redirect.
3459         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3460         * cli/cli-logging.c (debug_redirect): Add static variable.
3461         (pop_output_files): Add default param.
3462         (handle_redirections): Print debug setting.
3463         (show_logging_command): Likewise.
3464         (_initialize_cli_logging): Add debugredirect command.
3465         * interps.c (current_interp_set_logging): Add debug_redirect
3466         parameter.
3467         * interps.h (set_logging): Add debug_redirect parameter.
3468         (current_interp_set_logging): Likewise.
3469         * mi/mi-common.h: Likewise.
3470         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3471
3472 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3473             Tom Tromey  <tromey@adacore.com>
3474
3475         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3476         directly.
3477         * cli/cli-interp.h (make_logging_output): Remove declaration.
3478         * cli/cli-logging.c (make_logging_output): Remove function.
3479         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3480         directly.
3481         * ui-file.c (tee_file::tee_file): Remove bools.
3482         (tee_file::~tee_file): Remove deletes.
3483         * ui-file.h (tee_file): Remove bools.
3484
3485 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3486
3487         * mi/mi-cmds.h (mi_cmd_complete): New function.
3488         * mi/mi-main.c (mi_cmd_complete): Likewise.
3489         * mi/mi-cmds.c: Define new MI command -complete.
3490         * NEWS: Mention new -complete command.
3491
3492 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3493
3494         * completer.h (complete): New function.
3495         * completer.c (complete): Likewise.
3496         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3497         function defined in completer.h.
3498
3499 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3500
3501         * MAINTAINERS (Write After Approval): Add myself.
3502
3503 2019-05-17  Tom de Vries  <tdevries@suse.de>
3504
3505         PR gdb/24094
3506         * dwarf2read.c (struct cu_partial_die_info): New struct.
3507         (find_partial_die): Return cu_partial_die_info.
3508         (partial_die_parent_scope, guess_partial_die_structure_name)
3509         (partial_die_info::fixup): Handle new return type of find_partial_die.
3510
3511 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3512
3513         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3514         "std::string", simplifying the algorithm.
3515
3516 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3517
3518         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3519         (stap_static_probe_ops::get_probes): Likewise.
3520
3521 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3522
3523         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3524         '-')" and "else if".
3525         (stap_parse_single_operand): Join checks for
3526         "gdbarch_stap_parse_special_token_p" and
3527         "gdbarch_stap_parse_special_token" in the same "if" statement.
3528         Invert check when verifying for operation on register
3529         displacement.
3530
3531 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3532
3533         * stap-probe.c (stap_get_opcode): Update comment.
3534         (stap_get_expected_argument_type): Likewise.
3535         (handle_stap_probe): Likewise.
3536
3537 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3538
3539         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3540         return type to 'bool'.  Adjust comment.  Use 'bool' when
3541         appropriate.
3542         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3543         * stap-probe.c (stap_parse_argument_1): Likewise.
3544         (stap_is_operator): Likewise.
3545         (stap_is_generic_prefix): Likewise.
3546         (stap_is_register_prefix): Likewise.
3547         (stap_is_register_indirection_prefix): Likewise.
3548         (stap_is_integer_prefix): Likewise.
3549         (stap_generic_check_suffix): Likewise.
3550         (stap_check_integer_suffix): Likewise.
3551         (stap_check_register_suffix): Likewise.
3552         (stap_check_register_indirection_suffix): Likewise.
3553         (stap_parse_register_operand): Likewise.
3554         (stap_parse_single_operand): Likewise.
3555         (stap_parse_argument_1): Likewise.
3556         (stap_probe::get_argument_count): Likewise.
3557         (stap_is_operator): Likewise.
3558
3559 2019-05-16  Tom Tromey  <tromey@adacore.com>
3560
3561         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3562         keyword to foreach.
3563
3564 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3565
3566         * linux-thread-db.c (try_thread_db_load_1): Change return type
3567         to bool.
3568         (try_thread_db_load): Likewise.
3569         (try_thread_db_load_from_pdir_1): Likewise.
3570         (try_thread_db_load_from_pdir): Likewise.
3571         (try_thread_db_load_from_sdir): Likewise.
3572         (try_thread_db_load_from_dir): Likewise.
3573         (thread_db_load_search): Likewise.
3574         (has_libpthread): Likewise.
3575         (thread_db_load): Likewise.
3576
3577 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3578
3579         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3580         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3581         NULL, and complain/return if that's the case.
3582
3583 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3584
3585         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3586         (advance, posn, abstract_read_memory): New functions.
3587         [struct mem_read_abstraction]: New struct.
3588         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3589
3590 2019-05-14  Tom Tromey  <tromey@adacore.com>
3591
3592         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3593         value is not lval_memory.
3594
3595 2019-05-14  Tom Tromey  <tromey@adacore.com>
3596
3597         * solib.c (info_sharedlibrary_command): Style the file name.
3598
3599 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3600
3601         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3602         (aarch64_vnv_type): Likewise.
3603         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3604         * common/tdesc.c: Likewise.
3605         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3606         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3607         * features/aarch64-fpu.xml: Add ieee half view.
3608         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3609         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3610         * gdbtypes.h (struct builtin_type): Likewise.
3611         (struct objfile_type): Likewise.
3612
3613 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3614
3615         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3616         typo.
3617         * location.h (string_to_event_location): Likewise.
3618
3619 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3620
3621         GDB 8.3 released.
3622
3623 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3624
3625         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3626         New variable declaration.
3627         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3628         New variable.
3629         (print_one_breakpoint): Use ui_out::test_flags and new global
3630         variable to compute use_fixed_output.
3631         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3632         Remove.
3633         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3634         (mi_multi_location_breakpoint_output_fixed): Remove.
3635         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3636         new variable.
3637         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3638         fix_multi_location_breakpoint_output flag if version >= 3.
3639         * ui-out.h (enum ui_out_flag)
3640         <fix_multi_location_breakpoint_output>: New enumerator.
3641
3642 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3643
3644         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3645
3646 2019-05-10  Tom Tromey  <tromey@adacore.com>
3647
3648         * ada-lang.c (catch_ada_completer): New function.
3649         (_initialize_ada_language): Use it.
3650
3651 2019-05-10  Tom Tromey  <tromey@adacore.com>
3652
3653         * thread.c (print_thread_info): Make "requested_threads" const.
3654         * gdbthread.h (print_thread_info): Make "requested_threads"
3655         const.
3656         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3657         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3658
3659 2019-05-08  Tom Tromey  <tom@tromey.com>
3660
3661         * gdbtypes.c (objfile_type_data): Change type.
3662         (objfile_type, _initialize_gdbtypes): Update.
3663
3664 2019-05-08  Tom Tromey  <tom@tromey.com>
3665
3666         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3667         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3668         (_initialize_dwarf2_frame): Update.
3669
3670 2019-05-08  Tom Tromey  <tom@tromey.com>
3671
3672         * objc-lang.c (objc_objfile_data): Change type.
3673         (find_methods): Update.
3674         (_initialize_objc_lang): Remove.
3675
3676 2019-05-08  Tom Tromey  <tom@tromey.com>
3677
3678         * stabsread.c (rs6000_builtin_type_data): Change type.
3679         (rs6000_builtin_type, _initialize_stabsread): Update.
3680
3681 2019-05-08  Tom Tromey  <tom@tromey.com>
3682
3683         * mips-tdep.c (mips_pdr_data): Remove.
3684         (_initialize_mips_tdep): Update.
3685
3686 2019-05-08  Tom Tromey  <tom@tromey.com>
3687
3688         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3689         (hppa_init_objfile_priv_data, read_unwind_info)
3690         (find_unwind_entry, _initialize_hppa_tdep): Update.
3691
3692 2019-05-08  Tom Tromey  <tom@tromey.com>
3693
3694         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3695         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3696         on obstack.
3697         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3698
3699 2019-05-08  Tom Tromey  <tom@tromey.com>
3700
3701         * mdebugread.c (basic_type_data): Change type.
3702         (basic_type, _initialize_mdebugread): Update.
3703
3704 2019-05-08  Tom Tromey  <tom@tromey.com>
3705
3706         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3707
3708 2019-05-08  Tom Tromey  <tom@tromey.com>
3709
3710         * nto-tdep.c (nto_inferior_data_reg): Change type.
3711         (nto_inferior_data): Update.
3712         (nto_inferior_data_cleanup, nto_new_inferior_data)
3713         (_initialize_nto_tdep): Remove.
3714         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3715
3716 2019-05-08  Tom Tromey  <tom@tromey.com>
3717
3718         * ada-lang.c (struct ada_inferior_data): Add initializers.
3719         (ada_inferior_data): Change type.
3720         (ada_inferior_data_cleanup): Remove.
3721         (get_ada_inferior_data, ada_inferior_exit)
3722         (struct ada_pspace_data): Add initializers, destructor.
3723         (ada_pspace_data_handle): Change type.
3724         (get_ada_pspace_data): Update.
3725         (ada_pspace_data_cleanup): Remove.
3726
3727 2019-05-08  Tom Tromey  <tom@tromey.com>
3728
3729         * coffread.c (struct coff_symfile_info): Add initializers.
3730         (coff_objfile_data_key): Move lower.  Change type.
3731         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3732         Update.
3733         (coff_free_info): Remove.
3734
3735 2019-05-08  Tom Tromey  <tom@tromey.com>
3736
3737         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3738         (fbsd_pspace_data_handle): Move lower.  Change type.
3739         (get_fbsd_pspace_data): Update.
3740         (fbsd_pspace_data_cleanup): Remove.
3741         (_initialize_fbsd_tdep): Update.
3742
3743 2019-05-08  Tom Tromey  <tom@tromey.com>
3744
3745         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3746         (get_ada_tasks_pspace_data): Update.
3747         (ada_tasks_pspace_data_cleanup): Remove.
3748         (_initialize_tasks): Update.
3749         (ada_tasks_inferior_data_handle): Change type.
3750         (get_ada_tasks_inferior_data): Update.
3751         (ada_tasks_inferior_data_cleanup): Remove.
3752         (struct ada_tasks_pspace_data): Add initializers.
3753
3754 2019-05-08  Tom Tromey  <tom@tromey.com>
3755
3756         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3757         * symfile-debug.c (debug_sym_get_probes): Change type.
3758         * stap-probe.c (handle_stap_probe):
3759         (stap_static_probe_ops::get_probes): Change type.
3760         * probe.h (class static_probe_ops) <get_probes>: Change type.
3761         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3762         (parse_probes_in_pspace): Update.
3763         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3764         Update.
3765         (any_static_probe_ops::get_probes): Change type.
3766         * elfread.c (elfread_data): New typedef.
3767         (probe_key): Change type.
3768         (elf_get_probes): Likewise.  Update.
3769         (probe_key_free): Remove.
3770         (_initialize_elfread): Update.
3771         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3772         Change type.
3773         (dtrace_process_dof_probe, dtrace_process_dof)
3774         (dtrace_static_probe_ops::get_probe): Change type.
3775
3776 2019-05-08  Tom Tromey  <tom@tromey.com>
3777
3778         * xcoffread.c (struct xcoff_symfile_info): Rename from
3779         coff_symfile_info.  Add initializers.
3780         (xcoff_objfile_data_key): Move lower.  Change type.
3781         (XCOFF_DATA): Rewrite.
3782         (xcoff_free_info): Remove.
3783         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3784         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3785         (xcoff_initial_scan): Update.
3786
3787 2019-05-08  Tom Tromey  <tom@tromey.com>
3788
3789         * solib-svr4.c (struct svr4_info): Add initializers and
3790         destructor.
3791         <probes_table>: Now an htab_up.
3792         (solib_svr4_pspace_data): Change type.
3793         (free_probes_table): Simplify.
3794         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3795         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3796         (probes_table_remove_objfile_probes, register_solib_event_probe)
3797         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3798         (_initialize_svr4_solib): Update.
3799
3800 2019-05-08  Tom Tromey  <tom@tromey.com>
3801
3802         * remote.c (remote_pspace_data): Change type.
3803         (remote_pspace_data_cleanup): Remove.
3804         (get_remote_exec_file, set_pspace_remote_exec_file)
3805         (_initialize_remote): Update.
3806
3807 2019-05-08  Tom Tromey  <tom@tromey.com>
3808
3809         * breakpoint.c (breakpoint_objfile_key): Change type.
3810         (get_breakpoint_objfile_data): Update.
3811         (free_breakpoint_objfile_data): Remove.
3812         (_initialize_breakpoint): Update.
3813
3814 2019-05-08  Tom Tromey  <tom@tromey.com>
3815
3816         * linux-tdep.c (struct linux_info): Add initializers.
3817         (linux_inferior_data): Move.  Change type.
3818         (invalidate_linux_cache_inf): Update.
3819         (linux_inferior_data_cleanup): Remove.
3820         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3821
3822 2019-05-08  Tom Tromey  <tom@tromey.com>
3823
3824         * auxv.c (auxv_inferior_data): Move.  Change type.
3825         (auxv_inferior_data_cleanup): Remove.
3826         (invalidate_auxv_cache_inf): Rewrite.
3827         (get_auxv_inferior_data, _initialize_auxv): Update.
3828
3829 2019-05-08  Tom Tromey  <tom@tromey.com>
3830
3831         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3832         (symfile_debug_objfile_data_key): Change type.
3833         (symfile_debug_installed, debug_qf_has_symbols)
3834         (debug_qf_find_last_source_symtab)
3835         (debug_qf_forget_cached_source_info)
3836         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3837         (debug_qf_print_stats, debug_qf_dump)
3838         (debug_qf_expand_symtabs_for_function)
3839         (debug_qf_expand_all_symtabs)
3840         (debug_qf_expand_symtabs_with_fullname)
3841         (debug_qf_map_matching_symbols)
3842         (debug_qf_expand_symtabs_matching)
3843         (debug_qf_find_pc_sect_compunit_symtab)
3844         (debug_qf_map_symbol_filenames)
3845         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3846         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3847         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3848         (debug_sym_read_linetable, debug_sym_relocate): Update.
3849         (symfile_debug_free_objfile): Remove.
3850         (install_symfile_debug_logging, _initialize_symfile_debug):
3851         Update.
3852
3853 2019-05-08  Tom Tromey  <tom@tromey.com>
3854
3855         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3856         allocate_on_obstack.
3857         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3858         (get_dwarf2_per_objfile): Update.
3859         (set_dwarf2_per_objfile): Remove.
3860         (dwarf2_has_info, dwarf2_get_section_info): Update.
3861         (dwarf2_free_objfile): Remove.
3862         (_initialize_dwarf2_read): Update.
3863
3864 2019-05-08  Tom Tromey  <tom@tromey.com>
3865
3866         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3867         initializers.
3868         <unsupported_script_warning_printed,
3869         script_not_found_warning_printed>: Now bool.
3870         (auto_load_pspace_data): Change type.
3871         (~auto_load_pspace_info): Rename from
3872         auto_load_pspace_data_cleanup.
3873         (get_auto_load_pspace_data, init_loaded_scripts_info)
3874         (clear_section_scripts, maybe_print_unsupported_script_warning)
3875         (maybe_print_script_not_found_warning, _initialize_auto_load):
3876         Update.
3877
3878 2019-05-08  Tom Tromey  <tom@tromey.com>
3879
3880         * objfiles.c (objfile_pspace_info): Add destructor and
3881         initializers.
3882         (objfiles_pspace_data): Change type.
3883         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3884         (get_objfile_pspace_data): Update.
3885         (objfiles_bfd_data): Change type.
3886         (get_objfile_bfd_data): Update.
3887         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3888
3889 2019-05-08  Tom Tromey  <tom@tromey.com>
3890
3891         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3892         Change type.
3893         (get_catch_syscall_inferior_data): Update.
3894         (catch_syscall_inferior_data_cleanup): Remove.
3895         (_initialize_break_catch_syscall): Update.
3896
3897 2019-05-08  Tom Tromey  <tom@tromey.com>
3898
3899         * inflow.c (struct terminal_info): Add destructor and
3900         initializers.
3901         (inflow_inferior_data): Change type.
3902         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3903         (get_inflow_inferior_data, inflow_inferior_exit)
3904         (swap_terminal_info, _initialize_inflow): Update.
3905
3906 2019-05-08  Tom Tromey  <tom@tromey.com>
3907
3908         * target-dcache.c (target_dcache_cleanup): Remove.
3909         (target_dcache_aspace_key): Change type.
3910         (target_dcache_init_p, target_dcache_invalidate)
3911         (target_dcache_get, target_dcache_get_or_init)
3912         (_initialize_target_dcache): Update.
3913         * dcache.h (struct dcache_deleter): New.
3914
3915 2019-05-08  Tom Tromey  <tom@tromey.com>
3916
3917         * symtab.c (struct symbol_cache): Add destructor and
3918         initializers.
3919         (symbol_cache_key): Move.  Change type.
3920         (make_symbol_cache, free_symbol_cache): Remove.
3921         (get_symbol_cache): Update.
3922         (symbol_cache_cleanup): Remove.
3923         (ALL_PSPACES, symbol_cache_flush)
3924         (maintenance_print_symbol_cache)
3925         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3926         Update.
3927
3928 2019-05-08  Tom Tromey  <tom@tromey.com>
3929
3930         * symtab.c (struct main_info): Add destructor and initializers.
3931         (main_progspace_key): Move.  Change type.
3932         (get_main_info): Update.
3933         (main_info_cleanup): Remove.
3934         (_initialize_symtab): Update.
3935
3936 2019-05-08  Tom Tromey  <tom@tromey.com>
3937
3938         * registry.h (DECLARE_REGISTRY): Define the _key class.
3939
3940 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3941
3942         * NEWS: Merge two 'New commands' sections.
3943
3944 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3945
3946         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3947         parameter and use Ada language definition instead.
3948         (ada_val_print_ptr): Remove unused language parameter.
3949         (ada_val_print_num): Remove language parameter and use Ada language
3950         definition instead.
3951         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3952         parameter.
3953         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3954         parameter and use Ada language definition instead.
3955         (ada_val_print_1): Update all ada_val_print_xxx calls.
3956         Remove language parameter.
3957         (ada_val_print): Update ada_val_print_1 call.
3958
3959 2019-05-08  Tom Tromey  <tromey@adacore.com>
3960
3961         * remote.c (remote_hw_watchpoint_limit)
3962         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3963         Now static.
3964
3965 2019-05-08  Tom Tromey  <tromey@adacore.com>
3966
3967         * maint.c (_initialize_maint_cmds): Move initialization code to
3968         remote.c.
3969         (watchdog, show_watchdog): Move to remote.c.
3970         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3971         "watchdog" static.
3972         (_initialize_remote): Move initialization code from maint.c.
3973         * defs.h (watchdog): Don't declare.
3974
3975 2019-05-08  Tom Tromey  <tromey@adacore.com>
3976
3977         * tui/tui-interp.c: Include main.h.
3978         * interps.c: Include main.h.
3979         * main.h (interpreter_p): Declare.
3980         * defs.h (interpreter_p): Don't declare.
3981
3982 2019-05-08  Tom Tromey  <tromey@adacore.com>
3983
3984         * dwarf2loc.c: Include dwarf2read.h.
3985         * defs.h (read_unsigned_leb128): Don't declare.
3986         * dwarf2read.h (read_unsigned_leb128): Declare.
3987
3988 2019-05-08  Tom Tromey  <tromey@adacore.com>
3989
3990         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3991         method.
3992
3993 2019-05-08  Tom Tromey  <tromey@adacore.com>
3994
3995         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3996         when no wrap column is set.
3997
3998 2019-05-08  Tom Tromey  <tromey@adacore.com>
3999
4000         * c-lang.c (c_get_string): Handle non-C-style arrays.
4001
4002 2019-05-08  Tom Tromey  <tromey@adacore.com>
4003
4004         * typeprint.c (print_offset_data::update): Print the bit offset,
4005         not the number of bits remaining.
4006
4007 2019-05-08  Tom Tromey  <tromey@adacore.com>
4008
4009         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4010         padding at end of comment.
4011
4012 2019-05-08  Tom Tromey  <tromey@adacore.com>
4013
4014         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4015         Compare main types.
4016
4017 2019-05-06  Tom Tromey  <tom@tromey.com>
4018
4019         * common/scoped_mmap.c: Include common-defs.h.
4020         * common/scoped_mmap.h: Don't include config.h.
4021
4022 2019-05-04  Tom Tromey  <tom@tromey.com>
4023
4024         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4025         (struct aarch64_call_info): Add initializers.
4026         <si>: Now a std::vector.
4027         (pass_on_stack, aarch64_push_dummy_call): Update.
4028
4029 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4030             Tom Tromey  <tom@tromey.com>
4031
4032         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4033         (ppc_threads): Now a std::vector.  Now static.
4034         (hwdebug_find_thread_points_by_tid)
4035         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4036         Update.
4037
4038 2019-05-04  Tom Tromey  <tom@tromey.com>
4039
4040         * arc-tdep.c (arc_tdesc_init): Return bool.
4041
4042 2019-05-04  Tom Tromey  <tom@tromey.com>
4043
4044         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4045         Use gdb_assert_not_reached.
4046
4047 2019-05-04  Tom Tromey  <tom@tromey.com>
4048
4049         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4050         "false".
4051
4052 2019-05-04  Tom Tromey  <tom@tromey.com>
4053
4054         * arc-tdep.c (arc_tdesc_init): Use bool.
4055
4056 2019-05-04  Tom Tromey  <tom@tromey.com>
4057
4058         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4059
4060 2019-05-04  Tom Tromey  <tom@tromey.com>
4061
4062         * cli/cli-cmds.c (valid_command_p): Return bool.
4063
4064 2019-05-04  Tom Tromey  <tom@tromey.com>
4065
4066         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4067         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4068
4069 2019-05-04  Raul Tambre  <raul@tambre.ee>
4070
4071         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4072         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4073         operator for comparison.
4074
4075 2019-05-04  Tom Tromey  <tom@tromey.com>
4076
4077         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4078         (lookup_partial_symbol, print_partial_symbols)
4079         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4080         (psymbol_compare): Update.
4081         (add_psymbol_to_bcache): Clear the entire psymbol.
4082         (maintenance_check_psymtabs): Update.
4083         * psympriv.h (struct partial_symbol): Don't derive from
4084         general_symbol_info.
4085         <obj_section, unrelocated_address, address,
4086         set_unrelocated_address>: Update.
4087         <ginfo>: New member.
4088         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4089         (debug_names::write_psymbols): Update.
4090
4091 2019-05-04  Tom de Vries  <tdevries@suse.de>
4092
4093         * contrib/cc-with-tweaks.sh: Support -n arg.
4094
4095 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4096
4097         * corelow.c (core_target::detach): Ensure frame cache and
4098         register caches are cleared.
4099         inferior.c (exit_inferior_1): Likewise.
4100
4101 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4102             Tom Tromey  <tom@tromey.com>
4103
4104         * dictionary.c (collate_pending_symbols_by_language): Remove
4105         "struct" from foreach.
4106         * symtab.c (lookup_global_symbol_from_objfile)
4107         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4108         foreach.
4109         * ser-tcp.c (net_open): Remove "struct" from foreach.
4110         * objfiles.c (objfile_relocate, objfile_rebase)
4111         (objfile_has_symbols): Remove "struct" from foreach.
4112         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4113         from foreach.
4114         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4115         foreach.
4116         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4117         "struct" from foreach.
4118         * ada-lang.c (create_excep_cond_exprs)
4119         (ada_exception_catchpoint_cond_string): Remove "struct" from
4120         foreach.
4121
4122 2019-05-03  Tom Tromey  <tromey@adacore.com>
4123
4124         * ada-exp.y (convert_char_literal): Check suffix of each
4125         enumerator.
4126
4127 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4128
4129         PR ada/21406:
4130         * ada-exp.y (yywrap): Don't define.
4131         * ada-lex.l (%option): Add noyywrap
4132         (yywrap): Remove.
4133
4134 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4135
4136         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4137         _WIN32_WINNT to the XP level, unless already defined to a higher
4138         level.
4139
4140         * unittests/parse-connection-spec-selftests.c:
4141         * ser-tcp.c:
4142         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4143         override.
4144
4145         * symfile.c (find_separate_debug_file): Remove colon from the
4146         drive spec of DOS/Windows file names of the target, so that the
4147         file name produced from DEBUGDIR and the target's directory will
4148         be valid on DOS/Windows systems.
4149
4150 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4151
4152         * rust-lang.c (val_print_struct): Handle printing structures
4153         containing strings.
4154
4155 2019-05-02  Tom Tromey  <tromey@adacore.com>
4156
4157         * valarith.c (_initialize_valarith): Remove.
4158
4159 2019-05-01  Tom Tromey  <tromey@adacore.com>
4160
4161         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4162         bitfields.
4163
4164 2019-05-01  Tom Tromey  <tromey@adacore.com>
4165
4166         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4167         for big-endian copies.
4168
4169 2019-04-30  Ali Tamur  <tamur@google.com>
4170         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4171         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4172         (read_3_bytes): New function.
4173
4174 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4175
4176         * windows-nat.c (main_thread_id): Delete.
4177         (handle_output_debug_string): Replace main_thread_id by
4178         current_event.dwThreadId.
4179         (fake_create_process): Likewise.
4180         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4181         Do not set main_thread_id.
4182         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4183         current_event.dwThreadId.
4184         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4185
4186 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4187
4188         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4189         Use current_event.dwThreadId instead of main_thread_id.
4190
4191 2019-04-30  Tom Tromey  <tromey@adacore.com>
4192
4193         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4194         (create_excep_cond_exprs): Iterate over program spaces.
4195         (ada_exception_catchpoint_cond_string): Examine all minimal
4196         symbols for exception types.
4197
4198 2019-04-30  Tom Tromey  <tromey@adacore.com>
4199
4200         PR c++/24470:
4201         * dwarf2read.c (process_structure_scope): Handle case where type
4202         has template parameters but no symbol was created.
4203
4204 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4205             Chris January  <chris.january@arm.com>
4206
4207         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4208         qualifier.
4209         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4210
4211 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4212
4213         * f-typeprint.c (f_print_type): Update rules for printing
4214         whitespace.
4215         (f_type_print_varspec_suffix): Likewise.
4216
4217 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4218             Chris January  <chris.january@arm.com>
4219
4220         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4221         function arguments.
4222
4223 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4224
4225         * f-lang.c (build_fortran_types): Change name of void type to
4226         lower case.
4227         * f-typeprint.c (f_type_print_base): Print the name of the void
4228         type, rather than a fixed string.
4229         * f-valprint.c (f_decorations): Use lower case void string.
4230
4231 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4232             Chris January  <chris.january@arm.com>
4233
4234         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4235         types for Fortran.
4236
4237 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4238             Chris January  <chris.january@arm.com>
4239             David Lecomber  <david.lecomber@arm.com>
4240
4241         * f-exp.y (BINOP_INTRINSIC): New token.
4242         (exp): New parser rule handling BINOP_INTRINSIC.
4243         (f77_keywords): Add new builtin procedures.
4244         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4245         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4246         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4247         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4248         (print_unop_subexp_f): New function.
4249         (print_binop_subexp_f): New function.
4250         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4251         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4252         (dump_subexp_body_f): Likewise.
4253         (operator_check_f): Likewise.
4254         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4255         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4256
4257 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4258
4259         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4260         UNOP_KIND.
4261         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4262         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4263         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4264         (operator_length_f): New fuction.
4265         (print_subexp_f): New function.
4266         (op_name_f): New function.
4267         (dump_subexp_body_f): New function.
4268         (operator_check_f): New function.
4269         (exp_descriptor_f): Replace standard expression handling functions
4270         with new functions.
4271         * gdb/fortran-operator.def: New file.
4272         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4273         * gdb/std-operator.def: Remove UNOP_KIND.
4274
4275 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4276
4277         * std-operator.def: Remove unbalanced, stray double quote
4278         character.
4279
4280 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4281             Chris January  <chris.january@arm.com>
4282             Daniel Everett  <daniel.everett@arm.com>
4283             Nick Forrington  <nick.forrington@arm.com>
4284             Richard Bunt  <richard.bunt@arm.com>
4285
4286         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4287         of depth when printing anonymous structs or unions.
4288         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4289         Don't print either the top-level value, or the children if the
4290         max-depth is exceeded.
4291         (ppscm_print_children): When printing the key of a map, allow one
4292         extra level of depth.
4293         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4294         print either the top-level value, or the children if the max-depth
4295         is exceeded.
4296         (print_children): When printing the key of a map, allow one extra
4297         level of depth.
4298         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4299         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4300         (user_print_options): Initialise max_depth field.
4301         (val_print_scalar_or_string_type_p): New function.
4302         (val_print): Check to see if the max depth has been reached.
4303         (val_print_check_max_depth): Define new function.
4304         (show_print_max_depth): New function.
4305         (_initialize_valprint): Add 'print max-depth' option.
4306         * valprint.h (struct value_print_options) <max_depth>: New field.
4307         (val_print_check_max_depth): Declare new function.
4308         * NEWS: Document new feature.
4309
4310 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4311
4312         * ada-lang.c (ada_language_defn): Initialise new field.
4313         * c-lang.c (c_is_string_type_p): New function.
4314         (c_language_defn): Initialise new field.
4315         (cplus_language_defn): Initialise new field.
4316         (asm_language_defn): Initialise new field.
4317         (minimal_language_defn): Initialise new field.
4318         * c-lang.h (c_is_string_type_p): Declare new function.
4319         * d-lang.c (d_language_defn): Initialise new field.
4320         * f-lang.c (f_is_string_type_p): New function.
4321         (f_language_defn): Initialise new field.
4322         * go-lang.c (go_is_string_type_p): New function.
4323         (go_language_defn): Initialise new field.
4324         * language.c (default_is_string_type_p): New function.
4325         (unknown_language_defn): Initialise new field.
4326         (auto_language_defn): Initialise new field.
4327         * language.h (struct language_defn) <la_is_string_type_p>: New
4328         member variable.
4329         (default_is_string_type_p): Declare new function.
4330         * m2-lang.c (m2_language_defn): Initialise new field.
4331         * objc-lang.c (objc_language_defn): Initialise new field.
4332         * opencl-lang.c (opencl_language_defn): Initialise new field.
4333         * p-lang.c (pascal_is_string_type_p): New function.
4334         (pascal_language_defn): Initialise new field.
4335         * rust-lang.c (rust_is_string_type_p): New function.
4336         (rust_language_defn): Initialise new field.
4337
4338 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4339
4340         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4341         New field.
4342         * ada-lang.c (ada_language_defn): Initialise new field.
4343         * c-lang.c (c_language_defn): Likewise.
4344         (cplus_language_defn): Likewise.
4345         (asm_language_defn): Likewise.
4346         (minimal_language_defn): Likewise.
4347         * d-lang.c (d_language_defn): Likewise.
4348         * f-lang.c (f_language_defn): Likewise.
4349         * go-lang.c (go_language_defn): Likewise.
4350         * language.c (unknown_language_defn): Likewise.
4351         (auto_language_defn): Likewise.
4352         * m2-lang.c (m2_language_defn): Likewise.
4353         * objc-lang.c (objc_language_defn): Likewise.
4354         * opencl-lang.c (opencl_language_defn): Likewise.
4355         * p-lang.c (pascal_language_defn): Likewise.
4356         * rust-lang.c (rust_language_defn): Likewise.
4357
4358 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4359
4360         * ada-lang.c (ada_is_character_type): Change return type to bool.
4361         (ada_is_string_type): Likewise.
4362         * ada-lang.h (ada_is_character_type): Update declaration
4363         (ada_is_string_type): Likewise.
4364
4365 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4366
4367         Support style in 'frame|thread apply'
4368
4369         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4370         * record.c (record_start, record_stop): Update callers of
4371         execute_command_to_string with false.
4372         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4373         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4374         methods.
4375         (class string_file): New constructor with term_out parameter.
4376         Override methods term_out and can_emit_style_escape.  New member
4377         term_out.
4378         (class stdio_file): Override can_emit_style_escape.
4379         (class tee_file): Override term_out and can_emit_style_escape.
4380         * utils.h (can_emit_style_escape): Remove.
4381         * utils.c (can_emit_style_escape): Likewise.
4382         Update all callers of can_emit_style_escape (SOMESTREAM) to
4383         SOMESTREAM->can_emit_style_escape.
4384         * source-cache.c (source_cache::get_source_lines): Likewise.
4385         * stack.c (frame_apply_command_count): Call execute_command_to_string
4386         passing the term_out characteristic of the current gdb_stdout.
4387         * thread.c (thr_try_catch_cmd): Likewise.
4388         * top.c (execute_command_to_string): pass term_out parameter
4389         to construct the string_file for the command output.
4390         * ui-file.c (term_cli_styling): New function (most code moved
4391         from utils.c can_emit_style_escape).
4392         (string_file::string_file, string_file::can_emit_style_escape,
4393         stdio_file::can_emit_style_escape, tee_file::term_out,
4394         tee_file::can_emit_style_escape): New functions.
4395
4396 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4397
4398         * NEWS: Mention the new set|show may-call-functions.
4399         * infcall.c (may_call_functions_p): New variable.
4400         (show_may_call_functions_p): New function.
4401         (call_function_by_hand_dummy): Throws an error if not
4402         may-call-functions.
4403         (_initialize_infcall): Call add_setshow_boolean_cmd for
4404         may-call-functions.
4405
4406 2019-04-25  Keith Seitz  <keiths@redhat.com>
4407
4408         PR c++/24367
4409         * cp-support.c (inspect_type): Don't attempt substitutions
4410         of symbol with the same name.
4411
4412 2019-04-25  Tom Tromey  <tromey@adacore.com>
4413
4414         PR gdb/24475:
4415         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4416         static.
4417
4418 2019-04-25  Tom Tromey  <tromey@adacore.com>
4419
4420         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4421         rvalue reference.
4422         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4423         (gdb_xml_parser::parse): Use std::move.
4424         * python/python-internal.h (gdbpy_convert_exception): Take a const
4425         reference.
4426         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4427         std::move.
4428         * python/py-utils.c (gdbpy_convert_exception): Take a const
4429         reference.
4430         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4431         Use std::move.
4432         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4433         Use std::move.
4434         * mi/mi-main.c (mi_print_exception): Take a const reference.
4435         * main.c (handle_command_errors): Take a const reference.
4436         * linespec.c (parse_linespec): Use std::move.
4437         * infcall.c (run_inferior_call): Use std::move.
4438         (call_function_by_hand_dummy): Use std::move.
4439         * exec.c (try_open_exec_file): Use std::move.
4440         * exceptions.h (exception_print, exception_fprintf)
4441         (exception_print_same): Update.
4442         * exceptions.c (print_exception, exception_print)
4443         (exception_fprintf, exception_print_same): Change parameters to
4444         const reference.
4445         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4446         * common/new-op.c: Use std::move.
4447         * common/common-exceptions.h (struct gdb_exception): Add move
4448         constructor.
4449         (struct gdb_exception_error, struct gdb_exception_quit, struct
4450         gdb_quit_bad_alloc): Change constructor to move constructor.
4451         (throw_exception): Change parameter to rvalue reference.
4452         * common/common-exceptions.c (throw_exception): Take rvalue
4453         reference.
4454         * cli/cli-interp.c (safe_execute_command): Use std::move.
4455         * breakpoint.c (insert_bp_location, location_to_sals): Use
4456         std::move.
4457
4458 2019-04-25  Tom Tromey  <tromey@adacore.com>
4459
4460         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4461         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4462         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4463         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4464         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4465         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4466         guile/scm-value.c: Use unpack.
4467         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4468         gdbscm_gdb_exception.
4469         (gdbscm_throw_gdb_exception): Likewise.
4470         (struct gdbscm_gdb_exception): New.
4471         (unpack): New function.
4472         (gdbscm_wrap): Use unpack.
4473
4474 2019-04-25  Tom Tromey  <tromey@adacore.com>
4475
4476         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4477         (gdb_rl_callback_handler): Use std::move.
4478         * common/common-exceptions.h (struct gdb_exception): Add move
4479         assignment operator.
4480         (throw_exception_sjlj): Change "exception" to const reference.
4481         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4482         (throw_exception_sjlj): Change "exception" to const reference.
4483
4484 2019-04-25  Tom Tromey  <tromey@adacore.com>
4485
4486         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4487         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4488         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4489         Update.
4490         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4491         Update.
4492         * mi/mi-interp.c (mi_interp::exec): Update.
4493         * linespec.c (parse_linespec): Update.
4494         * infcall.c (run_inferior_call): Update.
4495         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4496         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4497         (gdbscm_lookup_global_symbol): Update.
4498         * guile/scm-param.c (gdbscm_parameter_value): Update.
4499         * guile/scm-frame.c (gdbscm_frame_read_register)
4500         (gdbscm_frame_read_var): Update.
4501         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4502         * exec.c (try_open_exec_file): Update.
4503         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4504         (gdb_rl_callback_handler): Update.
4505         * common/common-exceptions.h (exception_none): Don't declare.
4506         * common/common-exceptions.c (exception_none): Don't define.
4507         (struct catcher) <exception>: Update.
4508         * cli/cli-interp.c (safe_execute_command): Update.
4509         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4510
4511 2019-04-25  Ali Tamur  <tamur@google.com>
4512
4513         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4514         (read_attribute_value): Likewise.
4515         (dwarf2_read_addr_index): Update comment.
4516         (read_str_index): Add DW_FORM_strx.
4517         (dwarf2_string_attr): Likewise.
4518         (dwarf2_const_value_attr): Likewise.
4519         (dump_die_shallow): Likewise.
4520         (dwarf2_fetch_constant_bytes): Likewise.
4521         (skip_form_bytes): Likewise.
4522         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4523
4524 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4525
4526         PR corefiles/11608
4527         PR corefiles/18187
4528         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4529         OFFSET.  Verify if current mapping contains an ELF header.
4530         (linux_find_memory_regions_full): Adjust call to
4531         dump_mapping_p.
4532
4533 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4534             Kang Li <kanglictf@gmail.com>
4535
4536         PR gdb/21600
4537
4538         * dwarf2-frame.c (read_initial_length): Be consistent about using
4539         unsigned representation of length.
4540         (decode_frame_entry_1): Likewise.  Check for wraparound of
4541         end pointer as well as buffer overflow.
4542
4543 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4544
4545         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4546         "vq".
4547
4548 2019-04-24  Tom Tromey  <tromey@adacore.com>
4549
4550         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4551
4552 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4553
4554         * s12z-tdep.c (s12z_unwind_pc): Delete.
4555         (s12z_unwind_sp): Delete.
4556         (s12z_gdbarch_init): Don't register deleted functions with
4557         gdbarch.
4558
4559 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4560
4561         * rl78-tdep.c (rl78_unwind_sp): Delete.
4562         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4563
4564 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4565
4566         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4567         (xstormy16_unwind_pc): Delete.
4568         (xstormy16_dummy_id): Delete.
4569         (xstormy16_gdbarch_init): Don't register deleted functions with
4570         gdbarch.
4571
4572 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4573
4574         * vax-tdep.c (vax_unwind_pc): Delete.
4575         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4576
4577 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4578
4579         * v850-tdep.c (v850_unwind_sp): Delete.
4580         (v850_unwind_pc): Delete.
4581         (v850_dummy_id): Delete.
4582         (v850_gdbarch_init): Don't register deleted functions with
4583         gdbarch.
4584
4585 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4586
4587         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4588         (tilegx_unwind_pc): Delete.
4589         (tilegx_unwind_dummy_id): Delete.
4590         (tilegx_gdbarch_init): Don't register deleted functions with
4591         gdbarch.
4592
4593 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4594
4595         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4596         (tic6x_dummy_id): Delete.
4597         (tic6x_gdbarch_init): Don't register deleted functions with
4598         gdbarch.
4599
4600 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4601
4602         * sparc-tdep.c (sparc_unwind_pc): Delete.
4603         (sparc32_gdbarch_init): Don't register deleted function with
4604         gdbarch.
4605
4606 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4607
4608         * sh-tdep.c (sh_unwind_sp): Delete.
4609         (sh_unwind_pc): Delete.
4610         (sh_dummy_id): Delete.
4611         (sh_gdbarch_init): Don't register deleted functions with
4612         gdbarch.
4613
4614 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4615
4616         * score-tdep.c (score_unwind_sp): Delete.
4617         (score_unwind_pc): Delete.
4618         (score_dummy_id): Delete.
4619         (score_gdbarch_init): Don't register deleted functions with
4620         gdbarch.
4621
4622 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4623
4624         * rx-tdep.c (rx_unwind_pc): Delete.
4625         (rx_unwind_sp): Delete.
4626         (rx_dummy_id): Delete.
4627         (rx_gdbarch_init): Don't register deleted functions with
4628         gdbarch.  Update comment.
4629
4630 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4631
4632         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4633         (rs6000_dummy_id): Delete.
4634         (rs6000_gdbarch_init): Don't register deleted functions with
4635         gdbarch.
4636
4637 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4638
4639         * or1k-tdep.c (or1k_dummy_id): Delete.
4640         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4641
4642 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4643
4644         * nios2-tdep.c (nios2_dummy_id): Delete.
4645         (nios2_unwind_sp): Delete.
4646         (nios2_gdbarch_init): Don't register deleted functions with
4647         gdbarch.
4648
4649 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4650
4651         * nds32-tdep.c (nds32_dummy_id): Delete.
4652         (nds32_unwind_pc): Delete.
4653         (nds32_unwind_sp): Delete.
4654         (nds32_gdbarch_init): Don't register deleted functions with
4655         gdbarch.
4656
4657 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4658
4659         * msp430-tdep.c (msp430_unwind_pc): Delete.
4660         (msp430_unwind_sp): Delete.
4661         (msp430_dummy_id): Delete.
4662         (msp430_gdbarch_init): Don't register deleted functions with
4663         gdbarch.
4664
4665 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4666
4667         * moxie-tdep.c (moxie_unwind_sp): Delete.
4668         (moxie_unwind_pc): Delete.
4669         (moxie_dummy_id): Delete.
4670         (moxie_gdbarch_init): Don't register deleted functions with
4671         gdbarch.
4672
4673 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4674
4675         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4676         (mn10300_unwind_pc): Delete.
4677         (mn10300_unwind_sp): Delete.
4678         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4679         mn10300_unwind_sp.
4680         (mn10300_frame_unwind_init): Don't register deleted functions with
4681         gdbarch.
4682
4683 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4684
4685         * mep-tdep.c (mep_unwind_pc): Delete.
4686         (mep_unwind_sp): Delete.
4687         (mep_dummy_id): Delete.
4688         (mep_gdbarch_init): Don't register deleted functions with
4689         gdbarch.
4690
4691 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4692
4693         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4694         (m68hc11_unwind_sp): Delete.
4695         (m68hc11_gdbarch_init): Don't register deleted functions with
4696         gdbarch.
4697
4698 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4699
4700         * m32r-tdep.c (m32r_unwind_sp): Delete.
4701         (m32r_unwind_pc): Delete.
4702         (m32r_dummy_id): Delete.
4703         (m32r_gdbarch_init): Don't register deleted functions with
4704         gdbarch.
4705
4706 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4707
4708         * m32c-tdep.c (m32c_unwind_pc): Delete.
4709         (m32c_unwind_sp): Delete.
4710         (m32c_dummy_id): Delete.
4711         (m32c_gdbarch_init): Don't register deleted functions with
4712         gdbarch.
4713
4714 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4715
4716         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4717         (lm32_unwind_pc): Delete.
4718         (lm32_dummy_id): Delete.
4719         (lm32_gdbarch_init): Don't register deleted functions with
4720         gdbarch.
4721
4722 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4723
4724         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4725         (iq2000_unwind_pc): Delete.
4726         (iq2000_dummy_id): Delete.
4727         (iq2000_gdbarch_init): Don't register deleted functions with
4728         gdbarch.
4729
4730 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4731
4732         * nds32-tdep.c (nds32_type_align): Delete.
4733         (nds32_push_dummy_call): Use type_align instead.
4734
4735 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4736
4737         * arm-tdep.c (arm_type_align): Only handle vector override case.
4738         (arm_push_dummy_call): Use type_align.
4739         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4740
4741 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4742
4743         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4744         case.
4745         (pass_on_stack): Use type_align.
4746         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4747         function.
4748
4749 2019-04-23  Tom Tromey  <tromey@adacore.com>
4750
4751         * dwarf2read.c (line_header::file_name_at): Remove unused
4752         overload.
4753
4754 2019-04-23  Tom de Vries  <tdevries@suse.de>
4755
4756         PR gdb/24438
4757         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4758         invocation.
4759
4760
4761 2019-03-27  Ali Tamur  <tamur@google.com>
4762
4763         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4764         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4765         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4766         (dwarf_expr_context::get_addr_index): Likewise
4767         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4768         (symbol_needs_eval_context::get_addr_index): Likewise
4769         (disassemble_dwarf_expression): Add DW_OP_addrx
4770         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4771         (read_cutu_die_from_dwo): Update comment
4772         (skip_one_die): Add DW_FORM_addrx
4773         (read_attribute_value): Likewise
4774         (var_decode_location): Add DW_OP_addrx
4775         (dwarf2_const_value_attr): Add DW_FORM_addrx
4776         (dump_die_shallow): Likewise
4777         (dwarf2_fetch_constant_bytes): Likewise
4778         (decode_locdesc): Add DW_OP_addrx
4779         (skip_form_bytes): Add DW_FORM_addrx
4780
4781 2019-04-22  Ali Tamur  <tamur@google.com>
4782
4783         * MAINTAINERS (Write After Approval): Add self.
4784
4785 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4786
4787         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4788         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4789         (open_symbol_file_object): Likewise.
4790         (svr4_default_sos): Add info parameter.
4791         (svr4_read_so_list): Likewise.
4792         (svr4_current_sos_direct): Adjust functions calls to pass down
4793         info.
4794         (svr4_current_sos_1): Add info parameter.
4795         (svr4_current_sos): Call get_svr4_info, pass info down to
4796         svr4_current_sos_1.
4797         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4798         get_svr4_info.
4799         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4800         get_svr4_info.
4801         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4802         to get_svr4_info.
4803         (probes_table_remove_objfile_probes): Likewise.
4804         (register_solib_event_probe): Add info parameter.
4805         (solist_update_incremental): Pass info parameter down to
4806         svr4_read_so_list.
4807         (disable_probes_interface): Add info parameter.
4808         (svr4_handle_solib_event): Pass current_program_space to
4809         get_svr4_info.  Adjust disable_probes_interface cleanup.
4810         (svr4_create_probe_breakpoints): Add info parameter, pass it
4811         down to register_solib_event_probe.
4812         (svr4_create_solib_event_breakpoints): Add info parameter,
4813         pass it down to svr4_create_probe_breakpoints.
4814         (enable_break): Pass info down to
4815         svr4_create_solib_event_breakpoints.
4816         (svr4_solib_create_inferior_hook): Pass current_program_space to
4817         get_svr4_info.
4818         (svr4_clear_solib): Likewise.
4819
4820 2019-04-22  Pedro Alves  <palves@redhat.com>
4821
4822         * solib-svr4.c (svr4_free_objfile_observer): New.
4823         (probe_and_action::objfile): New field.
4824         (probes_table_htab_remove_objfile_probes)
4825         (probes_table_remove_objfile_probes): New functions.
4826         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4827         in the new probe_and_action.  Don't store the probe in 'lookup'.
4828         (svr4_create_probe_breakpoints): Pass objfile to
4829         register_solib_event_probe.
4830         (_initialize_svr4_solib): Register a free_objfile observer.
4831
4832 2019-04-19  Tom Tromey  <tom@tromey.com>
4833
4834         * common/queue.h: Remove.
4835
4836 2019-04-19  Tom Tromey  <tom@tromey.com>
4837
4838         * event-loop.c: Don't include "common/queue.h".
4839
4840 2019-04-19  Tom Tromey  <tom@tromey.com>
4841
4842         * remote.c (remote_target): Use delete.
4843         * remote-notif.h: Include <list>, not "common/queue.h".
4844         (notif_client_p): Remove typedef.
4845         (remote_notif_state): Add constructor, destructor, initializer.
4846         <notif_queue>: Now a std::list.
4847         (remote_notif_state_xfree): Don't declare.
4848         * remote-notif.c (remote_notif_process, handle_notification)
4849         (remote_notif_state_allocate): Update.
4850         (~remote_notif_state): Rename from remote_notif_state_xfree.
4851
4852 2019-04-19  Tom Tromey  <tom@tromey.com>
4853
4854         * symfile.c (reread_symbols): Update.
4855         * objfiles.c (objfile_register_static_link)
4856         (objfile_lookup_static_link): Update
4857         (~objfile) Don't delete static_links.
4858         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4859
4860 2019-04-19  Tom Tromey  <tom@tromey.com>
4861
4862         * type-stack.h (struct type_stack) <insert>: Constify string.
4863         * type-stack.c (type_stack::insert): Constify string.
4864         * gdbtypes.h (lookup_template_type): Update.
4865         (address_space_name_to_int): Update.
4866         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4867         const.
4868         (lookup_template_type): Make name const.
4869         * c-exp.y: Update rules.
4870         (lex_one_token, classify_name, classify_inner_name)
4871         (c_print_token): Update.
4872         * p-exp.y: Update rules.
4873         (yylex): Update.
4874         * f-exp.y: Update rules.
4875         (yylex): Update.
4876         * d-exp.y: Update rules.
4877         (lex_one_token, classify_name, classify_inner_name): Update.
4878         * parse.c (write_dollar_variable, copy_name): Return std::string.
4879         * parser-defs.h (copy_name): Change return type.
4880         * m2-exp.y: Update rules.
4881         (yylex): Update.
4882         * go-exp.y (lex_one_token): Update.
4883         Update rules.
4884         (classify_unsafe_function, classify_packaged_name)
4885         (classify_name, yylex): Update.
4886
4887 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4888
4889         * configure.ac: add --enable-source-highlight switch.
4890         * configure: Regenerate.
4891         * top.c (print_gdb_version): plumb --enable-source-highlight
4892         status to "show configuration".
4893
4894 2019-04-19  Tom Tromey  <tromey@adacore.com>
4895
4896         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4897         Check ADA_TYPE_P.
4898         (empty_record, ada_template_to_fixed_record_type_1)
4899         (template_to_static_fixed_type)
4900         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4901         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4902         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4903         macros.
4904
4905 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4906
4907         PR symtab/24423:
4908         * source.c (print_source_lines_base): Advance "iter" when a
4909         control character is seen.
4910
4911 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4912
4913         * inferior.h (struct infcall_suspend_state_deleter):
4914         Catch exception in destructor to avoid crash.
4915
4916 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4917
4918         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4919         close to the add_com "shell".
4920
4921 2019-04-18  Tom Tromey  <tromey@adacore.com>
4922
4923         * process-stratum-target.h (class process_stratum_target)
4924         <stratum>: Add "final".
4925
4926 2019-04-17  Tom Tromey  <tromey@adacore.com>
4927
4928         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4929         against nullptr before use.
4930
4931 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4932
4933         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4934
4935 2019-04-17  Jim Wilson  <jimw@sifive.com>
4936             Andrew Burgess  <andrew.burgess@embecosm.com>
4937
4938         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4939         code read might fail, assume 4-byte breakpoint in that case.
4940
4941 2019-04-15  Leszek Swirski  <leszeks@google.com>
4942
4943         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4944         rather than a hand-rolled POD check when checking for forced MEMORY
4945         classification.
4946
4947 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4948
4949         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4950         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4951         function.
4952         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4953         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4954         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4955         declaration.
4956
4957 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4958
4959         * aarch64-linux-nat.c
4960         (aarch64_linux_nat_target::thread_architecture): Add override.
4961         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4962         each VQ.
4963
4964 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4965
4966         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4967
4968 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4969
4970         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4971         target types of size 96-bits, add some additional comments, and
4972         check that the builtin type we found was the correct size.
4973
4974 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4975
4976         * utils.c (prompt_for_continue): Don't restore the styling at the
4977         end, as applied_style has the wrong value.  This fixes styling in
4978         long lists of file names that are interrupted by the "Continue?"
4979         prompt.
4980
4981 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4982
4983         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4984         * c-lang.c (c_language_defn): Likewise.
4985         (cplus_language_defn): Likewise.
4986         (asm_language_defn): Likewise.
4987         (minimal_language_defn): Likewise.
4988         * d-lang.c (d_language_defn): Likewise.
4989         * f-lang.c (f_language_defn): Likewise.
4990         * go-lang.c (go_language_defn): Likewise.
4991         * language.c (unknown_language_defn): Likewise.
4992         (auto_language_defn): Likewise.
4993         * language.h (struct language_defn): Remove la_magic field.
4994         (LANG_MAGIC): Delete.
4995         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4996         * objc-lang.c (objc_language_defn): Likewise.
4997         * opencl-lang.c (opencl_language_defn): Likewise.
4998         * p-lang.c (pascal_language_defn): Likewise.
4999         * rust-lang.c (rust_language_defn): Likewise.
5000
5001 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5002
5003         * riscv-tdep.c (riscv_type_align): New function.
5004         (riscv_type_alignment): Delete.
5005         (riscv_arg_location): Use 'type_align'.
5006         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5007
5008 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5009
5010         * gdbtypes.c (type_align): A struct with no non-static fields also
5011         has alignment of 1.
5012
5013 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5014
5015         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5016         component to 0.
5017         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5018         member.
5019         (riscv_struct_info::analyse): New implementation using new
5020         analyse_inner member function.
5021         (riscv_struct_info::field_offset): New member function.
5022         (riscv_struct_info::m_offsets): New member variable.
5023         (riscv_struct_info::analyse_inner): New private member function,
5024         takes the old implementation of riscv_struct_info::analyse but
5025         extended to track field offsets.
5026         (riscv_call_arg_struct): Update the struct folding special cases
5027         to handle cases where empty C++ structs, which are non-zero
5028         length, are found.
5029         (riscv_arg_location): Initialise the length of each location, a
5030         non-zero length now indicates the location is in use.
5031         (riscv_push_dummy_call): Allow for the first location having a
5032         non-zero offset when setting up arguments.
5033         (riscv_return_value): Likewise, but for return values.
5034
5035 2019-04-11  Tom Tromey  <tromey@adacore.com>
5036
5037         * utils.c (internal_vproblem): Make "msg" const.
5038
5039 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5040
5041         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5042         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5043         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5044         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5045
5046 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5047
5048         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5049         function.
5050         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5051         of amd64_collect_native_gregset.
5052         (amd64_linux_nat_target::store_registers): Likewise.
5053
5054 2019-04-10  Tom Tromey  <tom@tromey.com>
5055
5056         * symtab.c (lookup_global_symbol_from_objfile)
5057         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5058         * objfiles.h (class separate_debug_iterator): New.
5059         (class separate_debug_range): New.
5060         (struct objfile) <separate_debug_objfiles>: New method.
5061         (objfile_separate_debug_iterate): Don't declare.
5062         * objfiles.c (separate_debug_iterator::operator++): Rename from
5063         objfile_separate_debug_iterate.
5064         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5065         iterator.
5066         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5067         iterator.
5068
5069 2019-04-10  Tom Tromey  <tom@tromey.com>
5070
5071         * symfile.c (reread_symbols): Remove old comment.
5072         * objfiles.c (free_all_objfiles): Fix a typo.
5073
5074 2019-04-10  Tom Tromey  <tom@tromey.com>
5075
5076         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5077         * minsyms.c (lookup_minimal_symbol): Use foreach.
5078         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5079         (lookup_minimal_symbol_solib_trampoline): Likewise.
5080         * symfile.c (reread_symbols): Use foreach.
5081
5082 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5083             Tom Tromey  <tromey@adacore.com>
5084
5085         PR rust/24414:
5086         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5087         (rust_lex_int_test): Change "value" to be LONGEST.
5088         (rust_lex_tests): Add test for long integer literal.
5089
5090 2019-04-09  Tom Tromey  <tromey@adacore.com>
5091
5092         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5093         to bool.
5094         (extended_remote_target::attach): Update.
5095         (remote_target::remote_notice_new_inferior): Update.
5096         (remote_target::add_current_inferior_and_thread): Update.
5097         * inferior.c (exit_inferior_1): Use "false".
5098         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5099
5100 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5101
5102         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5103         the "start" command.
5104
5105 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5106
5107         * python/py-inferior.c (infpy_thread_from_thread_handle):
5108         Adjust comments to reflect renaming of thread_from_thread_handle
5109         to thread_from_handle.  Adjust keywords.  Fix type error message.
5110         (inferior_object_methods): Add thread_from_handle.  Retain
5111         thread_from_thread_handle, but mark it as deprecated.
5112
5113 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5114
5115         * gdbthread.h (find_thread_by_handle): Revise declaration.
5116         * thread.c (find_thread_by_handle): Likewise.  Adjust
5117         implementation too.
5118         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5119         support for buffer objects as handles.
5120
5121 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5122
5123         * python/py-infthread.c (thpy_thread_handle): New function.
5124         (thread_object_methods): Register thpy_thread_handle.
5125
5126 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5127
5128         * gdbthread.h (thread_to_thread_handle): Declare.
5129         * thread.c (gdbtypes.h): Include.
5130         (thread_to_thread_handle): New function.
5131
5132         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5133         (target_thread_info_to_thread_handle): Declare.
5134         * target.c (target_thread_info_to_thread_handle): New function.
5135         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5136         * target-delegates.c: Regenerate.
5137
5138         * linux-thread-db.c (class thread_db_target): Add method
5139         thread_info_to_thread_handle.
5140         (thread_db_target::thread_info_to_thread_handle): Define.
5141         * remote.c (class remote_target): Add new method
5142         thread_info_to_thread_handle.
5143         (remote_target::thread_info_to_thread_handle): Define.
5144
5145 2019-04-08  Pedro Alves  <palves@redhat.com>
5146
5147         * common/common-exceptions.c (throw_exception): Don't create
5148         named object to throw; throw directly.
5149         (throw_it): Likewise.  Don't initialize gdb_exception::message
5150         here, with new; pass FMT and AP to the ctor instead.
5151         * common/common-exceptions.h: Include <string>.
5152         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5153         const char *, va_list)): New ctor.  Use std::make_shared.
5154         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5155         errors)): Delete.
5156         (gdb_exception_error::gdb_exception_error(enum errors, const char
5157         *, va_list)): New.
5158         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5159         Add assertion.
5160         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5161         errors)): Delete.
5162         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5163         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5164         Add assertion.
5165
5166 2019-04-08  Tom Tromey  <tom@tromey.com>
5167
5168         * valops.c (value_rtti_indirect_type): Replace throw_exception
5169         with throw.
5170         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5171         with throw.
5172         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5173         throw.
5174         * target.c (target_translate_tls_address): Replace throw_exception
5175         with throw.
5176         * stack.c (frame_apply_command_count): Replace throw_exception
5177         with throw.
5178         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5179         throw.
5180         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5181         with throw.
5182         * rs6000-tdep.c (rs6000_frame_cache)
5183         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5184         * remote.c: Replace throw_exception with throw.
5185         * record-full.c (record_full_message, record_full_wait_1)
5186         (record_full_restore): Replace throw_exception with throw.
5187         * record-btrace.c:
5188         (get_thread_current_frame_id, record_btrace_start_replaying)
5189         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5190         (cmd_record_btrace_start): Replace throw_exception with throw.
5191         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5192         throw.
5193         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5194         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5195         * linespec.c:
5196         (find_linespec_symbols): Replace throw_exception with throw.
5197         * infrun.c (displaced_step_prepare, resume): Replace
5198         throw_exception with throw.
5199         * infcmd.c (post_create_inferior): Replace throw_exception with
5200         throw.
5201         * inf-loop.c (inferior_event_handler): Replace throw_exception
5202         with throw.
5203         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5204         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5205         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5206         (get_prev_frame_always, get_frame_pc_if_available)
5207         (get_frame_address_in_block_if_available, get_frame_language):
5208         Replace throw_exception with throw.
5209         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5210         throw_exception with throw.
5211         * eval.c (fetch_subexp_value, evaluate_var_value)
5212         (evaluate_funcall, evaluate_subexp_standard): Replace
5213         throw_exception with throw.
5214         * dwarf2loc.c (call_site_find_chain)
5215         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5216         Replace throw_exception with throw.
5217         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5218         with throw.
5219         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5220         throw.
5221         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5222         * completer.c (complete_line_internal): Replace throw_exception
5223         with throw.
5224         * compile/compile-object-run.c (compile_object_run): Replace
5225         throw_exception with throw.
5226         * cli/cli-script.c (process_next_line): Replace throw_exception
5227         with throw.
5228         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5229         (btrace_enable, btrace_maint_update_pt_packets): Replace
5230         throw_exception with throw.
5231         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5232         throw_exception with throw.
5233         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5234         throw_exception with throw.
5235         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5236         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5237         * aarch64-tdep.c (aarch64_make_prologue_cache)
5238         (aarch64_make_stub_cache): Replace throw_exception with throw.
5239
5240 2019-04-08  Tom Tromey  <tom@tromey.com>
5241
5242         * common/common-exceptions.c (throw_exception): Rename from
5243         throw_exception_cxx.  Remove old copy.  Make argument const.
5244         (throw_it): Create and throw exception objects directly.
5245         * common/common-exceptions.h (throw_exception): Make argument
5246         const.
5247         (struct gdb_exception_error): Add constructor.
5248         (struct gdb_exception_quit): Add constructor.
5249
5250 2019-04-08  Tom Tromey  <tom@tromey.com>
5251
5252         * common/common-exceptions.h (exception_rethrow): Don't declare.
5253         (TRY_SJLJ): Update comment.
5254         (TRY, CATCH, END_CATCH): Remove.
5255         * common/common-exceptions.c (exception_rethrow): Remove.
5256
5257 2019-04-08  Tom Tromey  <tom@tromey.com>
5258
5259         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5260         Remove.
5261         (gdb_exception_error): Rename from
5262         gdb_exception_RETURN_MASK_ERROR.
5263         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5264         (gdb_quit_bad_alloc): Update.
5265         * aarch64-tdep.c: Update.
5266         * ada-lang.c: Update.
5267         * ada-typeprint.c: Update.
5268         * ada-valprint.c: Update.
5269         * amd64-tdep.c: Update.
5270         * arch-utils.c: Update.
5271         * break-catch-throw.c: Update.
5272         * breakpoint.c: Update.
5273         * btrace.c: Update.
5274         * c-varobj.c: Update.
5275         * cli/cli-cmds.c: Update.
5276         * cli/cli-interp.c: Update.
5277         * cli/cli-script.c: Update.
5278         * common/common-exceptions.c: Update.
5279         * common/new-op.c: Update.
5280         * common/selftest.c: Update.
5281         * compile/compile-c-symbols.c: Update.
5282         * compile/compile-cplus-symbols.c: Update.
5283         * compile/compile-object-load.c: Update.
5284         * compile/compile-object-run.c: Update.
5285         * completer.c: Update.
5286         * corelow.c: Update.
5287         * cp-abi.c: Update.
5288         * cp-support.c: Update.
5289         * cp-valprint.c: Update.
5290         * darwin-nat.c: Update.
5291         * disasm-selftests.c: Update.
5292         * dtrace-probe.c: Update.
5293         * dwarf-index-cache.c: Update.
5294         * dwarf-index-write.c: Update.
5295         * dwarf2-frame-tailcall.c: Update.
5296         * dwarf2-frame.c: Update.
5297         * dwarf2loc.c: Update.
5298         * dwarf2read.c: Update.
5299         * eval.c: Update.
5300         * event-loop.c: Update.
5301         * event-top.c: Update.
5302         * exec.c: Update.
5303         * f-valprint.c: Update.
5304         * fbsd-tdep.c: Update.
5305         * frame-unwind.c: Update.
5306         * frame.c: Update.
5307         * gdbtypes.c: Update.
5308         * gnu-v3-abi.c: Update.
5309         * guile/guile-internal.h: Update.
5310         * guile/scm-block.c: Update.
5311         * guile/scm-breakpoint.c: Update.
5312         * guile/scm-cmd.c: Update.
5313         * guile/scm-disasm.c: Update.
5314         * guile/scm-frame.c: Update.
5315         * guile/scm-lazy-string.c: Update.
5316         * guile/scm-math.c: Update.
5317         * guile/scm-param.c: Update.
5318         * guile/scm-ports.c: Update.
5319         * guile/scm-pretty-print.c: Update.
5320         * guile/scm-symbol.c: Update.
5321         * guile/scm-symtab.c: Update.
5322         * guile/scm-type.c: Update.
5323         * guile/scm-value.c: Update.
5324         * i386-linux-tdep.c: Update.
5325         * i386-tdep.c: Update.
5326         * inf-loop.c: Update.
5327         * infcall.c: Update.
5328         * infcmd.c: Update.
5329         * infrun.c: Update.
5330         * jit.c: Update.
5331         * language.c: Update.
5332         * linespec.c: Update.
5333         * linux-fork.c: Update.
5334         * linux-nat.c: Update.
5335         * linux-tdep.c: Update.
5336         * linux-thread-db.c: Update.
5337         * main.c: Update.
5338         * mi/mi-cmd-break.c: Update.
5339         * mi/mi-cmd-stack.c: Update.
5340         * mi/mi-interp.c: Update.
5341         * mi/mi-main.c: Update.
5342         * objc-lang.c: Update.
5343         * p-valprint.c: Update.
5344         * parse.c: Update.
5345         * ppc-linux-tdep.c: Update.
5346         * printcmd.c: Update.
5347         * python/py-arch.c: Update.
5348         * python/py-breakpoint.c: Update.
5349         * python/py-cmd.c: Update.
5350         * python/py-finishbreakpoint.c: Update.
5351         * python/py-frame.c: Update.
5352         * python/py-framefilter.c: Update.
5353         * python/py-gdb-readline.c: Update.
5354         * python/py-inferior.c: Update.
5355         * python/py-infthread.c: Update.
5356         * python/py-lazy-string.c: Update.
5357         * python/py-linetable.c: Update.
5358         * python/py-objfile.c: Update.
5359         * python/py-param.c: Update.
5360         * python/py-prettyprint.c: Update.
5361         * python/py-progspace.c: Update.
5362         * python/py-record-btrace.c: Update.
5363         * python/py-record.c: Update.
5364         * python/py-symbol.c: Update.
5365         * python/py-type.c: Update.
5366         * python/py-unwind.c: Update.
5367         * python/py-utils.c: Update.
5368         * python/py-value.c: Update.
5369         * python/python.c: Update.
5370         * record-btrace.c: Update.
5371         * record-full.c: Update.
5372         * remote-fileio.c: Update.
5373         * remote.c: Update.
5374         * riscv-tdep.c: Update.
5375         * rs6000-aix-tdep.c: Update.
5376         * rs6000-tdep.c: Update.
5377         * rust-exp.y: Update.
5378         * rust-lang.c: Update.
5379         * s390-tdep.c: Update.
5380         * selftest-arch.c: Update.
5381         * solib-dsbt.c: Update.
5382         * solib-frv.c: Update.
5383         * solib-spu.c: Update.
5384         * solib-svr4.c: Update.
5385         * solib.c: Update.
5386         * sparc64-linux-tdep.c: Update.
5387         * stack.c: Update.
5388         * symfile-mem.c: Update.
5389         * symmisc.c: Update.
5390         * target.c: Update.
5391         * thread.c: Update.
5392         * top.c: Update.
5393         * tracefile-tfile.c: Update.
5394         * tui/tui.c: Update.
5395         * typeprint.c: Update.
5396         * unittests/cli-utils-selftests.c: Update.
5397         * unittests/parse-connection-spec-selftests.c: Update.
5398         * valops.c: Update.
5399         * valprint.c: Update.
5400         * value.c: Update.
5401         * varobj.c: Update.
5402         * windows-nat.c: Update.
5403         * x86-linux-nat.c: Update.
5404         * xml-support.c: Update.
5405
5406 2019-04-08  Tom Tromey  <tom@tromey.com>
5407
5408         * xml-support.c: Use C++ exception handling.
5409         * x86-linux-nat.c: Use C++ exception handling.
5410         * windows-nat.c: Use C++ exception handling.
5411         * varobj.c: Use C++ exception handling.
5412         * value.c: Use C++ exception handling.
5413         * valprint.c: Use C++ exception handling.
5414         * valops.c: Use C++ exception handling.
5415         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5416         handling.
5417         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5418         * typeprint.c: Use C++ exception handling.
5419         * tui/tui.c: Use C++ exception handling.
5420         * tracefile-tfile.c: Use C++ exception handling.
5421         * top.c: Use C++ exception handling.
5422         * thread.c: Use C++ exception handling.
5423         * target.c: Use C++ exception handling.
5424         * symmisc.c: Use C++ exception handling.
5425         * symfile-mem.c: Use C++ exception handling.
5426         * stack.c: Use C++ exception handling.
5427         * sparc64-linux-tdep.c: Use C++ exception handling.
5428         * solib.c: Use C++ exception handling.
5429         * solib-svr4.c: Use C++ exception handling.
5430         * solib-spu.c: Use C++ exception handling.
5431         * solib-frv.c: Use C++ exception handling.
5432         * solib-dsbt.c: Use C++ exception handling.
5433         * selftest-arch.c: Use C++ exception handling.
5434         * s390-tdep.c: Use C++ exception handling.
5435         * rust-lang.c: Use C++ exception handling.
5436         * rust-exp.y: Use C++ exception handling.
5437         * rs6000-tdep.c: Use C++ exception handling.
5438         * rs6000-aix-tdep.c: Use C++ exception handling.
5439         * riscv-tdep.c: Use C++ exception handling.
5440         * remote.c: Use C++ exception handling.
5441         * remote-fileio.c: Use C++ exception handling.
5442         * record-full.c: Use C++ exception handling.
5443         * record-btrace.c: Use C++ exception handling.
5444         * python/python.c: Use C++ exception handling.
5445         * python/py-value.c: Use C++ exception handling.
5446         * python/py-utils.c: Use C++ exception handling.
5447         * python/py-unwind.c: Use C++ exception handling.
5448         * python/py-type.c: Use C++ exception handling.
5449         * python/py-symbol.c: Use C++ exception handling.
5450         * python/py-record.c: Use C++ exception handling.
5451         * python/py-record-btrace.c: Use C++ exception handling.
5452         * python/py-progspace.c: Use C++ exception handling.
5453         * python/py-prettyprint.c: Use C++ exception handling.
5454         * python/py-param.c: Use C++ exception handling.
5455         * python/py-objfile.c: Use C++ exception handling.
5456         * python/py-linetable.c: Use C++ exception handling.
5457         * python/py-lazy-string.c: Use C++ exception handling.
5458         * python/py-infthread.c: Use C++ exception handling.
5459         * python/py-inferior.c: Use C++ exception handling.
5460         * python/py-gdb-readline.c: Use C++ exception handling.
5461         * python/py-framefilter.c: Use C++ exception handling.
5462         * python/py-frame.c: Use C++ exception handling.
5463         * python/py-finishbreakpoint.c: Use C++ exception handling.
5464         * python/py-cmd.c: Use C++ exception handling.
5465         * python/py-breakpoint.c: Use C++ exception handling.
5466         * python/py-arch.c: Use C++ exception handling.
5467         * printcmd.c: Use C++ exception handling.
5468         * ppc-linux-tdep.c: Use C++ exception handling.
5469         * parse.c: Use C++ exception handling.
5470         * p-valprint.c: Use C++ exception handling.
5471         * objc-lang.c: Use C++ exception handling.
5472         * mi/mi-main.c: Use C++ exception handling.
5473         * mi/mi-interp.c: Use C++ exception handling.
5474         * mi/mi-cmd-stack.c: Use C++ exception handling.
5475         * mi/mi-cmd-break.c: Use C++ exception handling.
5476         * main.c: Use C++ exception handling.
5477         * linux-thread-db.c: Use C++ exception handling.
5478         * linux-tdep.c: Use C++ exception handling.
5479         * linux-nat.c: Use C++ exception handling.
5480         * linux-fork.c: Use C++ exception handling.
5481         * linespec.c: Use C++ exception handling.
5482         * language.c: Use C++ exception handling.
5483         * jit.c: Use C++ exception handling.
5484         * infrun.c: Use C++ exception handling.
5485         * infcmd.c: Use C++ exception handling.
5486         * infcall.c: Use C++ exception handling.
5487         * inf-loop.c: Use C++ exception handling.
5488         * i386-tdep.c: Use C++ exception handling.
5489         * i386-linux-tdep.c: Use C++ exception handling.
5490         * guile/scm-value.c: Use C++ exception handling.
5491         * guile/scm-type.c: Use C++ exception handling.
5492         * guile/scm-symtab.c: Use C++ exception handling.
5493         * guile/scm-symbol.c: Use C++ exception handling.
5494         * guile/scm-pretty-print.c: Use C++ exception handling.
5495         * guile/scm-ports.c: Use C++ exception handling.
5496         * guile/scm-param.c: Use C++ exception handling.
5497         * guile/scm-math.c: Use C++ exception handling.
5498         * guile/scm-lazy-string.c: Use C++ exception handling.
5499         * guile/scm-frame.c: Use C++ exception handling.
5500         * guile/scm-disasm.c: Use C++ exception handling.
5501         * guile/scm-cmd.c: Use C++ exception handling.
5502         * guile/scm-breakpoint.c: Use C++ exception handling.
5503         * guile/scm-block.c: Use C++ exception handling.
5504         * guile/guile-internal.h: Use C++ exception handling.
5505         * gnu-v3-abi.c: Use C++ exception handling.
5506         * gdbtypes.c: Use C++ exception handling.
5507         * frame.c: Use C++ exception handling.
5508         * frame-unwind.c: Use C++ exception handling.
5509         * fbsd-tdep.c: Use C++ exception handling.
5510         * f-valprint.c: Use C++ exception handling.
5511         * exec.c: Use C++ exception handling.
5512         * event-top.c: Use C++ exception handling.
5513         * event-loop.c: Use C++ exception handling.
5514         * eval.c: Use C++ exception handling.
5515         * dwarf2read.c: Use C++ exception handling.
5516         * dwarf2loc.c: Use C++ exception handling.
5517         * dwarf2-frame.c: Use C++ exception handling.
5518         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5519         * dwarf-index-write.c: Use C++ exception handling.
5520         * dwarf-index-cache.c: Use C++ exception handling.
5521         * dtrace-probe.c: Use C++ exception handling.
5522         * disasm-selftests.c: Use C++ exception handling.
5523         * darwin-nat.c: Use C++ exception handling.
5524         * cp-valprint.c: Use C++ exception handling.
5525         * cp-support.c: Use C++ exception handling.
5526         * cp-abi.c: Use C++ exception handling.
5527         * corelow.c: Use C++ exception handling.
5528         * completer.c: Use C++ exception handling.
5529         * compile/compile-object-run.c: Use C++ exception handling.
5530         * compile/compile-object-load.c: Use C++ exception handling.
5531         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5532         * compile/compile-c-symbols.c: Use C++ exception handling.
5533         * common/selftest.c: Use C++ exception handling.
5534         * common/new-op.c: Use C++ exception handling.
5535         * cli/cli-script.c: Use C++ exception handling.
5536         * cli/cli-interp.c: Use C++ exception handling.
5537         * cli/cli-cmds.c: Use C++ exception handling.
5538         * c-varobj.c: Use C++ exception handling.
5539         * btrace.c: Use C++ exception handling.
5540         * breakpoint.c: Use C++ exception handling.
5541         * break-catch-throw.c: Use C++ exception handling.
5542         * arch-utils.c: Use C++ exception handling.
5543         * amd64-tdep.c: Use C++ exception handling.
5544         * ada-valprint.c: Use C++ exception handling.
5545         * ada-typeprint.c: Use C++ exception handling.
5546         * ada-lang.c: Use C++ exception handling.
5547         * aarch64-tdep.c: Use C++ exception handling.
5548
5549 2019-04-08  Tom Tromey  <tom@tromey.com>
5550
5551         * xml-support.c (gdb_xml_parser::parse): Update.
5552         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5553         * value.c (show_convenience): Update.
5554         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5555         (test_parse_flags_qcs): Update.
5556         * thread.c (thr_try_catch_cmd): Update.
5557         * target.c (target_translate_tls_address): Update.
5558         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5559         (info_frame_command_core, frame_apply_command_count): Update.
5560         * rust-exp.y (rust_lex_exception_test): Update.
5561         * riscv-tdep.c (riscv_print_one_register_info): Update.
5562         * remote.c (remote_target::enable_btrace): Update.
5563         * record-btrace.c (record_btrace_enable_warn): Update.
5564         * python/py-utils.c (gdbpy_convert_exception): Update.
5565         * printcmd.c (do_one_display, print_variable_and_value): Update.
5566         * mi/mi-main.c (mi_print_exception): Update.
5567         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5568         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5569         * linux-nat.c (linux_nat_target::attach): Update.
5570         * linux-fork.c (class scoped_switch_fork_info): Update.
5571         * infrun.c (displaced_step_prepare): Update.
5572         * infcall.c (call_function_by_hand_dummy): Update.
5573         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5574         * gnu-v3-abi.c (print_one_vtable): Update.
5575         * frame.c (get_prev_frame_always): Update.
5576         * f-valprint.c (info_common_command_for_block): Update.
5577         * exec.c (try_open_exec_file): Update.
5578         * exceptions.c (print_exception, exception_print)
5579         (exception_fprintf, exception_print_same): Update.
5580         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5581         * dwarf-index-cache.c (index_cache::store)
5582         (index_cache::lookup_gdb_index): Update.
5583         * darwin-nat.c (maybe_cache_shell): Update.
5584         * cp-valprint.c (cp_print_value_fields): Update.
5585         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5586         (gcc_cplus_symbol_address): Update.
5587         * compile/compile-c-symbols.c (gcc_convert_symbol)
5588         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5589         * common/selftest.c: Update.
5590         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5591         a std::string.
5592         (exception_try_scope_entry, exception_try_scope_exit): Don't
5593         declare.
5594         (struct exception_try_scope): Remove.
5595         (TRY): Don't use exception_try_scope.
5596         (struct gdb_exception): Add constructor, operator=.
5597         <what>: New method.
5598         (struct gdb_exception_RETURN_MASK_ALL)
5599         (struct gdb_exception_RETURN_MASK_ERROR)
5600         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5601         (struct gdb_quit_bad_alloc): Update.
5602         * common/common-exceptions.c (exception_none): Change
5603         initializer.
5604         (struct catcher) <state, exception>: Initialize inline.
5605         <prev>: Remove member.
5606         (current_catcher): Remove.
5607         (catchers): New global.
5608         (exceptions_state_mc_init): Simplify.
5609         (catcher_pop): Remove.
5610         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5611         (try_scope_depth, exception_try_scope_entry)
5612         (exception_try_scope_exit): Remove.
5613         (throw_exception_sjlj): Update.
5614         (exception_messages, exception_messages_size): Remove.
5615         (throw_it): Simplify.
5616         (gdb_exception_sliced_copy): Remove.
5617         (throw_exception_cxx): Update.
5618         * cli/cli-script.c (script_from_file): Update.
5619         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5620         Update.
5621         * ada-valprint.c (ada_val_print): Update.
5622         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5623         (create_excep_cond_exprs): Update.
5624
5625 2019-04-08  Tom Tromey  <tom@tromey.com>
5626
5627         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5628         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5629         (TRY, CATCH, END_CATCH): Remove some definitions.
5630         * common/common-exceptions.c: Don't use GDB_XCPT.
5631         (catcher_list_size): Remove.
5632         (throw_exception, throw_it): Simplify.
5633
5634 2019-04-05  Tom Tromey  <tom@tromey.com>
5635
5636         Revert the header-sorting patch.
5637         * ft32-tdep.c: Revert.
5638         * frv-tdep.c: Revert.
5639         * frv-linux-tdep.c: Revert.
5640         * frame.c: Revert.
5641         * frame-unwind.c: Revert.
5642         * frame-base.c: Revert.
5643         * fork-child.c: Revert.
5644         * findvar.c: Revert.
5645         * findcmd.c: Revert.
5646         * filesystem.c: Revert.
5647         * filename-seen-cache.h: Revert.
5648         * filename-seen-cache.c: Revert.
5649         * fbsd-tdep.c: Revert.
5650         * fbsd-nat.h: Revert.
5651         * fbsd-nat.c: Revert.
5652         * f-valprint.c: Revert.
5653         * f-typeprint.c: Revert.
5654         * f-lang.c: Revert.
5655         * extension.h: Revert.
5656         * extension.c: Revert.
5657         * extension-priv.h: Revert.
5658         * expprint.c: Revert.
5659         * exec.h: Revert.
5660         * exec.c: Revert.
5661         * exceptions.c: Revert.
5662         * event-top.c: Revert.
5663         * event-loop.c: Revert.
5664         * eval.c: Revert.
5665         * elfread.c: Revert.
5666         * dwarf2read.h: Revert.
5667         * dwarf2read.c: Revert.
5668         * dwarf2loc.c: Revert.
5669         * dwarf2expr.h: Revert.
5670         * dwarf2expr.c: Revert.
5671         * dwarf2-frame.c: Revert.
5672         * dwarf2-frame-tailcall.c: Revert.
5673         * dwarf-index-write.h: Revert.
5674         * dwarf-index-write.c: Revert.
5675         * dwarf-index-common.c: Revert.
5676         * dwarf-index-cache.h: Revert.
5677         * dwarf-index-cache.c: Revert.
5678         * dummy-frame.c: Revert.
5679         * dtrace-probe.c: Revert.
5680         * disasm.h: Revert.
5681         * disasm.c: Revert.
5682         * disasm-selftests.c: Revert.
5683         * dictionary.c: Revert.
5684         * dicos-tdep.c: Revert.
5685         * demangle.c: Revert.
5686         * dcache.h: Revert.
5687         * dcache.c: Revert.
5688         * darwin-nat.h: Revert.
5689         * darwin-nat.c: Revert.
5690         * darwin-nat-info.c: Revert.
5691         * d-valprint.c: Revert.
5692         * d-namespace.c: Revert.
5693         * d-lang.c: Revert.
5694         * ctf.c: Revert.
5695         * csky-tdep.c: Revert.
5696         * csky-linux-tdep.c: Revert.
5697         * cris-tdep.c: Revert.
5698         * cris-linux-tdep.c: Revert.
5699         * cp-valprint.c: Revert.
5700         * cp-support.c: Revert.
5701         * cp-namespace.c: Revert.
5702         * cp-abi.c: Revert.
5703         * corelow.c: Revert.
5704         * corefile.c: Revert.
5705         * continuations.c: Revert.
5706         * completer.h: Revert.
5707         * completer.c: Revert.
5708         * complaints.c: Revert.
5709         * coffread.c: Revert.
5710         * coff-pe-read.c: Revert.
5711         * cli-out.h: Revert.
5712         * cli-out.c: Revert.
5713         * charset.c: Revert.
5714         * c-varobj.c: Revert.
5715         * c-valprint.c: Revert.
5716         * c-typeprint.c: Revert.
5717         * c-lang.c: Revert.
5718         * buildsym.c: Revert.
5719         * buildsym-legacy.c: Revert.
5720         * build-id.h: Revert.
5721         * build-id.c: Revert.
5722         * btrace.c: Revert.
5723         * bsd-uthread.c: Revert.
5724         * breakpoint.h: Revert.
5725         * breakpoint.c: Revert.
5726         * break-catch-throw.c: Revert.
5727         * break-catch-syscall.c: Revert.
5728         * break-catch-sig.c: Revert.
5729         * blockframe.c: Revert.
5730         * block.c: Revert.
5731         * bfin-tdep.c: Revert.
5732         * bfin-linux-tdep.c: Revert.
5733         * bfd-target.c: Revert.
5734         * bcache.c: Revert.
5735         * ax-general.c: Revert.
5736         * ax-gdb.h: Revert.
5737         * ax-gdb.c: Revert.
5738         * avr-tdep.c: Revert.
5739         * auxv.c: Revert.
5740         * auto-load.c: Revert.
5741         * arm-wince-tdep.c: Revert.
5742         * arm-tdep.c: Revert.
5743         * arm-symbian-tdep.c: Revert.
5744         * arm-pikeos-tdep.c: Revert.
5745         * arm-obsd-tdep.c: Revert.
5746         * arm-nbsd-tdep.c: Revert.
5747         * arm-nbsd-nat.c: Revert.
5748         * arm-linux-tdep.c: Revert.
5749         * arm-linux-nat.c: Revert.
5750         * arm-fbsd-tdep.c: Revert.
5751         * arm-fbsd-nat.c: Revert.
5752         * arm-bsd-tdep.c: Revert.
5753         * arch-utils.c: Revert.
5754         * arc-tdep.c: Revert.
5755         * arc-newlib-tdep.c: Revert.
5756         * annotate.h: Revert.
5757         * annotate.c: Revert.
5758         * amd64-windows-tdep.c: Revert.
5759         * amd64-windows-nat.c: Revert.
5760         * amd64-tdep.c: Revert.
5761         * amd64-sol2-tdep.c: Revert.
5762         * amd64-obsd-tdep.c: Revert.
5763         * amd64-obsd-nat.c: Revert.
5764         * amd64-nbsd-tdep.c: Revert.
5765         * amd64-nbsd-nat.c: Revert.
5766         * amd64-nat.c: Revert.
5767         * amd64-linux-tdep.c: Revert.
5768         * amd64-linux-nat.c: Revert.
5769         * amd64-fbsd-tdep.c: Revert.
5770         * amd64-fbsd-nat.c: Revert.
5771         * amd64-dicos-tdep.c: Revert.
5772         * amd64-darwin-tdep.c: Revert.
5773         * amd64-bsd-nat.c: Revert.
5774         * alpha-tdep.c: Revert.
5775         * alpha-obsd-tdep.c: Revert.
5776         * alpha-nbsd-tdep.c: Revert.
5777         * alpha-mdebug-tdep.c: Revert.
5778         * alpha-linux-tdep.c: Revert.
5779         * alpha-linux-nat.c: Revert.
5780         * alpha-bsd-tdep.c: Revert.
5781         * alpha-bsd-nat.c: Revert.
5782         * aix-thread.c: Revert.
5783         * agent.c: Revert.
5784         * addrmap.c: Revert.
5785         * ada-varobj.c: Revert.
5786         * ada-valprint.c: Revert.
5787         * ada-typeprint.c: Revert.
5788         * ada-tasks.c: Revert.
5789         * ada-lang.c: Revert.
5790         * aarch64-tdep.c: Revert.
5791         * aarch64-ravenscar-thread.c: Revert.
5792         * aarch64-newlib-tdep.c: Revert.
5793         * aarch64-linux-tdep.c: Revert.
5794         * aarch64-linux-nat.c: Revert.
5795         * aarch64-fbsd-tdep.c: Revert.
5796         * aarch64-fbsd-nat.c: Revert.
5797         * aarch32-linux-nat.c: Revert.
5798
5799 2019-04-05  Tom Tromey  <tom@tromey.com>
5800
5801         * ft32-tdep.c: Sort headers.
5802         * frv-tdep.c: Sort headers.
5803         * frv-linux-tdep.c: Sort headers.
5804         * frame.c: Sort headers.
5805         * frame-unwind.c: Sort headers.
5806         * frame-base.c: Sort headers.
5807         * fork-child.c: Sort headers.
5808         * findvar.c: Sort headers.
5809         * findcmd.c: Sort headers.
5810         * filesystem.c: Sort headers.
5811         * filename-seen-cache.h: Sort headers.
5812         * filename-seen-cache.c: Sort headers.
5813         * fbsd-tdep.c: Sort headers.
5814         * fbsd-nat.h: Sort headers.
5815         * fbsd-nat.c: Sort headers.
5816         * f-valprint.c: Sort headers.
5817         * f-typeprint.c: Sort headers.
5818         * f-lang.c: Sort headers.
5819         * extension.h: Sort headers.
5820         * extension.c: Sort headers.
5821         * extension-priv.h: Sort headers.
5822         * expprint.c: Sort headers.
5823         * exec.h: Sort headers.
5824         * exec.c: Sort headers.
5825         * exceptions.c: Sort headers.
5826         * event-top.c: Sort headers.
5827         * event-loop.c: Sort headers.
5828         * eval.c: Sort headers.
5829         * elfread.c: Sort headers.
5830         * dwarf2read.h: Sort headers.
5831         * dwarf2read.c: Sort headers.
5832         * dwarf2loc.c: Sort headers.
5833         * dwarf2expr.h: Sort headers.
5834         * dwarf2expr.c: Sort headers.
5835         * dwarf2-frame.c: Sort headers.
5836         * dwarf2-frame-tailcall.c: Sort headers.
5837         * dwarf-index-write.h: Sort headers.
5838         * dwarf-index-write.c: Sort headers.
5839         * dwarf-index-common.c: Sort headers.
5840         * dwarf-index-cache.h: Sort headers.
5841         * dwarf-index-cache.c: Sort headers.
5842         * dummy-frame.c: Sort headers.
5843         * dtrace-probe.c: Sort headers.
5844         * disasm.h: Sort headers.
5845         * disasm.c: Sort headers.
5846         * disasm-selftests.c: Sort headers.
5847         * dictionary.c: Sort headers.
5848         * dicos-tdep.c: Sort headers.
5849         * demangle.c: Sort headers.
5850         * dcache.h: Sort headers.
5851         * dcache.c: Sort headers.
5852         * darwin-nat.h: Sort headers.
5853         * darwin-nat.c: Sort headers.
5854         * darwin-nat-info.c: Sort headers.
5855         * d-valprint.c: Sort headers.
5856         * d-namespace.c: Sort headers.
5857         * d-lang.c: Sort headers.
5858         * ctf.c: Sort headers.
5859         * csky-tdep.c: Sort headers.
5860         * csky-linux-tdep.c: Sort headers.
5861         * cris-tdep.c: Sort headers.
5862         * cris-linux-tdep.c: Sort headers.
5863         * cp-valprint.c: Sort headers.
5864         * cp-support.c: Sort headers.
5865         * cp-namespace.c: Sort headers.
5866         * cp-abi.c: Sort headers.
5867         * corelow.c: Sort headers.
5868         * corefile.c: Sort headers.
5869         * continuations.c: Sort headers.
5870         * completer.h: Sort headers.
5871         * completer.c: Sort headers.
5872         * complaints.c: Sort headers.
5873         * coffread.c: Sort headers.
5874         * coff-pe-read.c: Sort headers.
5875         * cli-out.h: Sort headers.
5876         * cli-out.c: Sort headers.
5877         * charset.c: Sort headers.
5878         * c-varobj.c: Sort headers.
5879         * c-valprint.c: Sort headers.
5880         * c-typeprint.c: Sort headers.
5881         * c-lang.c: Sort headers.
5882         * buildsym.c: Sort headers.
5883         * buildsym-legacy.c: Sort headers.
5884         * build-id.h: Sort headers.
5885         * build-id.c: Sort headers.
5886         * btrace.c: Sort headers.
5887         * bsd-uthread.c: Sort headers.
5888         * breakpoint.h: Sort headers.
5889         * breakpoint.c: Sort headers.
5890         * break-catch-throw.c: Sort headers.
5891         * break-catch-syscall.c: Sort headers.
5892         * break-catch-sig.c: Sort headers.
5893         * blockframe.c: Sort headers.
5894         * block.c: Sort headers.
5895         * bfin-tdep.c: Sort headers.
5896         * bfin-linux-tdep.c: Sort headers.
5897         * bfd-target.c: Sort headers.
5898         * bcache.c: Sort headers.
5899         * ax-general.c: Sort headers.
5900         * ax-gdb.h: Sort headers.
5901         * ax-gdb.c: Sort headers.
5902         * avr-tdep.c: Sort headers.
5903         * auxv.c: Sort headers.
5904         * auto-load.c: Sort headers.
5905         * arm-wince-tdep.c: Sort headers.
5906         * arm-tdep.c: Sort headers.
5907         * arm-symbian-tdep.c: Sort headers.
5908         * arm-pikeos-tdep.c: Sort headers.
5909         * arm-obsd-tdep.c: Sort headers.
5910         * arm-nbsd-tdep.c: Sort headers.
5911         * arm-nbsd-nat.c: Sort headers.
5912         * arm-linux-tdep.c: Sort headers.
5913         * arm-linux-nat.c: Sort headers.
5914         * arm-fbsd-tdep.c: Sort headers.
5915         * arm-fbsd-nat.c: Sort headers.
5916         * arm-bsd-tdep.c: Sort headers.
5917         * arch-utils.c: Sort headers.
5918         * arc-tdep.c: Sort headers.
5919         * arc-newlib-tdep.c: Sort headers.
5920         * annotate.h: Sort headers.
5921         * annotate.c: Sort headers.
5922         * amd64-windows-tdep.c: Sort headers.
5923         * amd64-windows-nat.c: Sort headers.
5924         * amd64-tdep.c: Sort headers.
5925         * amd64-sol2-tdep.c: Sort headers.
5926         * amd64-obsd-tdep.c: Sort headers.
5927         * amd64-obsd-nat.c: Sort headers.
5928         * amd64-nbsd-tdep.c: Sort headers.
5929         * amd64-nbsd-nat.c: Sort headers.
5930         * amd64-nat.c: Sort headers.
5931         * amd64-linux-tdep.c: Sort headers.
5932         * amd64-linux-nat.c: Sort headers.
5933         * amd64-fbsd-tdep.c: Sort headers.
5934         * amd64-fbsd-nat.c: Sort headers.
5935         * amd64-dicos-tdep.c: Sort headers.
5936         * amd64-darwin-tdep.c: Sort headers.
5937         * amd64-bsd-nat.c: Sort headers.
5938         * alpha-tdep.c: Sort headers.
5939         * alpha-obsd-tdep.c: Sort headers.
5940         * alpha-nbsd-tdep.c: Sort headers.
5941         * alpha-mdebug-tdep.c: Sort headers.
5942         * alpha-linux-tdep.c: Sort headers.
5943         * alpha-linux-nat.c: Sort headers.
5944         * alpha-bsd-tdep.c: Sort headers.
5945         * alpha-bsd-nat.c: Sort headers.
5946         * aix-thread.c: Sort headers.
5947         * agent.c: Sort headers.
5948         * addrmap.c: Sort headers.
5949         * ada-varobj.c: Sort headers.
5950         * ada-valprint.c: Sort headers.
5951         * ada-typeprint.c: Sort headers.
5952         * ada-tasks.c: Sort headers.
5953         * ada-lang.c: Sort headers.
5954         * aarch64-tdep.c: Sort headers.
5955         * aarch64-ravenscar-thread.c: Sort headers.
5956         * aarch64-newlib-tdep.c: Sort headers.
5957         * aarch64-linux-tdep.c: Sort headers.
5958         * aarch64-linux-nat.c: Sort headers.
5959         * aarch64-fbsd-tdep.c: Sort headers.
5960         * aarch64-fbsd-nat.c: Sort headers.
5961         * aarch32-linux-nat.c: Sort headers.
5962
5963 2019-04-04  Tom Tromey  <tom@tromey.com>
5964
5965         * varobj.c (varobj_create): Update.
5966         * rust-exp.y (struct rust_parser) <update_innermost_block,
5967         lookup_symbol>: New methods.
5968         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5969         Rename.
5970         (rust_parser::rust_lookup_type)
5971         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5972         * printcmd.c (display_command, do_one_display): Update.
5973         * parser-defs.h (struct parser_state) <parser_state>: Add
5974         "tracker" parameter.
5975         (block_tracker): New member.
5976         (class innermost_block_tracker) <innermost_block_tracker>: Add
5977         "types" parameter.
5978         <reset>: Remove method.
5979         (innermost_block): Don't declare.
5980         (null_post_parser): Update.
5981         * parse.c (innermost_block): Remove global.
5982         (write_dollar_variable): Update.
5983         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5984         Remove "tracker_types" parameter.
5985         (parse_expression): Add "tracker" parameter.
5986         (parse_expression_for_completion): Update.
5987         (null_post_parser): Add "tracker" parameter.
5988         * p-exp.y: Update rules.
5989         * m2-exp.y: Update rules.
5990         * language.h (struct language_defn) <la_post_parser>: Add
5991         "tracker" parameter.
5992         * go-exp.y: Update rules.
5993         * f-exp.y: Update rules.
5994         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5995         parameter.
5996         * d-exp.y: Update rules.
5997         * c-exp.y: Update rules.
5998         * breakpoint.c (set_breakpoint_condition): Create an
5999         innermost_block_tracker.
6000         (watch_command_1): Likewise.
6001         * ada-lang.c (resolve): Add "tracker" parameter.
6002         (resolve_subexp): Likewise.
6003         * ada-exp.y (write_var_from_sym): Update.
6004
6005 2019-04-04  Tom Tromey  <tom@tromey.com>
6006
6007         * type-stack.h: New file.
6008         * type-stack.c: New file.
6009         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6010         type-stack.h.
6011         (insert_into_type_stack, insert_type, push_type, push_type_int)
6012         (insert_type_address_space, pop_type, pop_type_int)
6013         (pop_typelist, pop_type_stack, append_type_stack)
6014         (push_type_stack, get_type_stack, push_typelist)
6015         (follow_type_instance_flags, follow_types): Don't declare.
6016         * parse.c (type_stack): Remove global.
6017         (parse_exp_in_context): Update.
6018         (insert_into_type_stack, insert_type, push_type, push_type_int)
6019         (insert_type_address_space, pop_type, pop_type_int)
6020         (pop_typelist, pop_type_stack, append_type_stack)
6021         (push_type_stack, get_type_stack, push_typelist)
6022         (follow_type_instance_flags, follow_types): Remove (moved to
6023         type-stack.c).
6024         * f-exp.y (type_stack): New global.
6025         Update rules.
6026         (push_kind_type, f_parse): Update.
6027         * d-exp.y (type_stack): New global.
6028         Update rules.
6029         (d_parse): Update.
6030         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6031         Update rules.
6032         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6033         (HFILES_NO_SRCDIR): Add type-stack.h.
6034
6035 2019-04-04  Tom Tromey  <tom@tromey.com>
6036
6037         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6038         (rust_parser::convert_ast_to_expression, rust_parse)
6039         (rust_lex_test_completion, rust_lex_tests): Update.
6040         * parser-defs.h (struct expr_completion_state): New.
6041         (struct parser_state) <parser_state>: Add completion parameter.
6042         <mark_struct_expression, mark_completion_tag>: New methods.
6043         <parse_completion, m_completion_state>: New members.
6044         (prefixify_expression, null_post_parser): Update.
6045         (mark_struct_expression, mark_completion_tag): Don't declare.
6046         * parse.c (parse_completion, expout_last_struct)
6047         (expout_tag_completion_type, expout_completion_name): Remove
6048         globals.
6049         (parser_state::mark_struct_expression)
6050         (parser_state::mark_completion_tag): Now methods.
6051         (prefixify_expression): Add last_struct parameter.
6052         (prefixify_subexp): Likewise.
6053         (parse_exp_1): Update.
6054         (parse_exp_in_context): Add cstate parameter.  Update.
6055         (parse_expression_for_completion): Create an
6056         expr_completion_state.
6057         (null_post_parser): Add "completion" parameter.
6058         * p-exp.y: Update rules.
6059         (yylex): Update.
6060         * language.h (struct language_defn) <la_post_parser>: Add
6061         "completing" parameter.
6062         * go-exp.y: Update rules.
6063         (lex_one_token): Update.
6064         * expression.h (parse_completion): Don't declare.
6065         * d-exp.y: Update rules.
6066         (lex_one_token): Update rules.
6067         * c-exp.y: Update rules.
6068         (lex_one_token): Update.
6069         * ada-lang.c (resolve): Add "parse_completion" parameter.
6070         (resolve_subexp): Likewise.
6071         (ada_resolve_function): Likewise.
6072
6073 2019-04-04  Tom Tromey  <tom@tromey.com>
6074
6075         * parser-defs.h (struct parser_state) <start_arglist,
6076         end_arglist>: New methods.
6077         <arglist_len, m_funcall_chain>: New members.
6078         (arglist_len, start_arglist, end_arglist): Don't declare.
6079         * parse.c (arglist_len, funcall_chain): Remove global.
6080         (start_arglist, end_arglist): Remove functions.
6081         (parse_exp_in_context): Update.
6082         * p-exp.y: Update rules.
6083         * m2-exp.y: Update rules.
6084         * go-exp.y: Update rules.
6085         * f-exp.y: Update rules.
6086         * d-exp.y: Update rules.
6087         * c-exp.y: Update rules.
6088
6089 2019-04-04  Tom Tromey  <tom@tromey.com>
6090
6091         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6092         lex_operator, push_back>: New methods.
6093         Update all rules.
6094         (rust_parser::lex_hex, lex_escape): Rename and update.
6095         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6096         (rust_parser::lex_operator): Rename and update.
6097         (rust_parser::lex_number, rustyylex, rustyyerror)
6098         (rust_lex_test_init, rust_lex_test_sequence)
6099         (rust_lex_test_push_back, rust_lex_tests): Update.
6100         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6101         parameter.
6102         <lexptr, prev_lexptr>: New members.
6103         (lexptr, prev_lexptr): Don't declare.
6104         * parse.c (lexptr, prev_lexptr): Remove globals.
6105         (parse_exp_in_context): Update.
6106         * p-exp.y (yylex, yyerror): Update.
6107         * m2-exp.y (parse_number, yylex, yyerror): Update.
6108         * go-exp.y (lex_one_token, yyerror): Update.
6109         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6110         * d-exp.y (lex_one_token, yyerror): Update.
6111         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6112         (lex_one_token, yyerror): Update.
6113         * ada-lex.l (YY_INPUT): Update.
6114         (rewind_to_char): Update.
6115         * ada-exp.y (yyerror): Update.
6116
6117 2019-04-04  Tom Tromey  <tom@tromey.com>
6118
6119         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6120         * parser-defs.h (struct parser_state) <parser_state>: Add new
6121         parameter.
6122         <comma_terminates>: New member.
6123         (comma_terminates): Don't declare global.
6124         * parse.c (comma_terminates): Remove global.
6125         (parse_exp_in_context): Update.
6126         * p-exp.y (yylex): Update.
6127         * m2-exp.y (yylex): Update.
6128         * go-exp.y (lex_one_token): Update.
6129         * f-exp.y (yylex): Update.
6130         * d-exp.y (lex_one_token): Update.
6131         * c-exp.y (lex_one_token): Update.
6132         * ada-lex.l: Update.
6133
6134 2019-04-04  Tom Tromey  <tom@tromey.com>
6135
6136         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6137         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6138         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6139         * parser-defs.h (paren_depth): Don't declare.
6140         * parse.c (paren_depth): Remove global.
6141         (parse_exp_in_context): Update.
6142         * p-exp.y (paren_depth): New global.
6143         (pascal_parse): Initialize it.
6144         * m2-exp.y (paren_depth): New global.
6145         (m2_parse): Initialize it.
6146         * go-exp.y (paren_depth): New global.
6147         (go_parse): Initialize it.
6148         * f-exp.y (paren_depth): New global.
6149         (f_parse): Initialize it.
6150         * d-exp.y (paren_depth): New global.
6151         (d_parse): Initialize it.
6152         * c-exp.y (paren_depth): New global.
6153         (c_parse): Initialize it.
6154         * ada-lex.l (paren_depth): New global.
6155         (lexer_init): Initialize it.
6156
6157 2019-04-04  Tom Tromey  <tom@tromey.com>
6158
6159         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6160         (rust_parser::convert_ast_to_type)
6161         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6162         * parser-defs.h (struct parser_state) <parser_state>: Add
6163         parameters.  Initialize new members.
6164         <expression_context_block, expression_context_pc>: New members.
6165         * parse.c (expression_context_block, expression_context_pc):
6166         Remove globals.
6167         (parse_exp_in_context): Update.
6168         * p-exp.y: Update all rules.
6169         (yylex): Update.
6170         * m2-exp.y: Update all rules.
6171         (yylex): Update.
6172         * go-exp.y (yylex): Update.
6173         * f-exp.y (yylex): Update.
6174         * d-exp.y: Update all rules.
6175         (yylex): Update.
6176         * c-exp.y: Update all rules.
6177         (lex_one_token, classify_name, yylex, c_parse): Update.
6178         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6179
6180 2019-04-04  Tom Tromey  <tom@tromey.com>
6181
6182         * gdbarch.h, gdbarch.c: Rebuild.
6183         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6184         * stap-probe.h:
6185         (struct stap_parse_info): Replace "parser_state" with
6186         "expr_builder".
6187         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6188         (parser_state): New class.
6189         * parse.c (expr_builder): Rename.
6190         (expr_builder::release): Rename.
6191         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6192         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6193         (write_exp_elt_longcst, write_exp_elt_floatcst)
6194         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6195         (write_exp_string_vector, write_exp_bitstring)
6196         (write_exp_msymbol, mark_struct_expression)
6197         (write_dollar_variable)
6198         (insert_type_address_space, increase_expout_size): Replace
6199         "parser_state" with "expr_builder".
6200         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6201         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6202         "parser_state" with "expr_builder".
6203
6204 2019-04-04  Tom Tromey  <tom@tromey.com>
6205
6206         * rust-exp.y: Replace "parse_language" with method call.
6207         * p-exp.y:
6208         (yylex): Replace "parse_language" with method call.
6209         * m2-exp.y:
6210         (yylex): Replace "parse_language" with method call.
6211         * go-exp.y (classify_name): Replace "parse_language" with method
6212         call.
6213         * f-exp.y (yylex): Replace "parse_language" with method call.
6214         * d-exp.y (lex_one_token): Replace "parse_language" with method
6215         call.
6216         * c-exp.y:
6217         (lex_one_token, classify_name, yylex): Replace "parse_language"
6218         with method call.
6219         * ada-exp.y (find_primitive_type, type_char)
6220         (type_system_address): Replace "parse_language" with method call.
6221
6222 2019-04-04  Tom Tromey  <tom@tromey.com>
6223
6224         * rust-exp.y: Replace "parse_gdbarch" with method call.
6225         * parse.c (write_dollar_variable, insert_type_address_space):
6226         Replace "parse_gdbarch" with method call.
6227         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6228         call.
6229         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6230         call.
6231         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6232         "parse_gdbarch" with method call.
6233         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6234         with method call.
6235         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6236         "parse_gdbarch" with method call.
6237         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6238         "parse_gdbarch" with method call.
6239         * c-exp.y (parse_type, parse_number, classify_name): Replace
6240         "parse_gdbarch" with method call.
6241         * ada-lex.l: Replace "parse_gdbarch" with method call.
6242         * ada-exp.y (parse_type, find_primitive_type, type_char)
6243         (type_system_address): Replace "parse_gdbarch" with method call.
6244
6245 2019-04-04  Tom Tromey  <tom@tromey.com>
6246
6247         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6248         * stap-probe.c (stap_parse_argument): Update.
6249         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6250         initial_size parameter.
6251         * rust-exp.y (rust_lex_tests): Update.
6252         * parse.c (parser_state): Update.
6253         (parse_exp_in_context): Update.
6254         * parser-defs.h (struct parser_state) <parser_state>: Remove
6255         "initial_size" parameter.
6256
6257 2019-04-04  Tom Tromey  <tom@tromey.com>
6258
6259         * parser-defs.h (increase_expout_size): Don't declare.
6260         * parse.c (increase_expout_size): Now static.
6261
6262 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6263
6264         * gnu-nat.c (gnu_nat_target::wait): Fix
6265         target_waitstatus_to_string call.
6266
6267 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6268
6269         * eval.c (evaluate_subexp_standard): Handle internal functions
6270         during Fortran function call handling.
6271
6272 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6273
6274         * NEWS: Mention new internal functions.
6275         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6276         (read_base_type): Use dwarf2_init_complex_target_type.
6277         * value.c (creal_internal_fn): New function.
6278         (cimag_internal_fn): New function.
6279         (_initialize_values): Register new internal functions.
6280
6281 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6282
6283         * infrun.c (stop_all_threads): If debug_infrun, always
6284         trace the wait status after wait_one, using
6285         target_waitstatus_to_string and target_pid_to_str.
6286         (handle_inferior_event): Replace various trace of
6287         wait status kind by a single trace.
6288         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6289         wait status kind image by target_waitstatus_to_string.
6290         * target/waitstatus.c (target_waitstatus_to_string): Fix
6291         obsolete comment.
6292
6293 2019-04-01  Tom Tromey  <tromey@adacore.com>
6294
6295         PR symtab/23331:
6296         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6297
6298 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6299             Pedro Alves  <palves@redhat.com>
6300
6301         * top.c (quit_force): Call 'finalize_values'.
6302         * value.c (finalize_values): New function.
6303         * value.h (finalize_values): Declare.
6304
6305 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6306
6307         * NEWS: Announce $_gdb_major and $_gdb_minor.
6308
6309         * top.c (init_gdb_version_vars): New function.
6310         (gdb_init): Call init_gdb_version_vars.
6311
6312 2019-03-29  Tom Tromey  <tromey@adacore.com>
6313
6314         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6315         help text.  Remove dead code.
6316
6317 2019-03-29  Keith Seitz  <keiths@redhat.com>
6318
6319         From Siddhesh Poyarekar:
6320         * f-lang.h (f77_get_upperbound): Return LONGEST.
6321         (f77_get_lowerbound): Likewise.
6322         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6323         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6324         print them.
6325         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6326         plongest to format print it.
6327         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6328         (f77_get_upperbound): Likewise.
6329         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6330         LOWER_BOUND to LONGEST.
6331         (f77_create_arrayprint_offset_tbl): Likewise.
6332
6333 2019-03-29  Keith Seitz  <keiths@redhat.com>
6334
6335         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6336         %s/pulongest for TYPE_LENGTH instead of %d in format
6337         strings.
6338         * ada-typerint.c (ada_print_type): Likewise.
6339         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6340         * compile/compile-c-support.c (generate_register_struct): Likewise.
6341         * gdbtypes.c (recursive_dump_type): Likewise.
6342         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6343         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6344         instead of %d in format strings.
6345         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6346         to std::min to ULONGEST.
6347         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6348         instead of %d in format strings.
6349         * tracepoint.c (info_scope_command): Likewise.
6350         * typeprint.c (print_offset_data::update)
6351         (print_offset_data::finish): Likewise.
6352         * xtensa-tdep.c (xtensa_store_return_value)
6353         (xtensa_push_dummy_call): Likewise.
6354
6355 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6356
6357         * windows-nat.c (display_selector): Fixed format specifications
6358         for 64-bit Cygwin.
6359
6360 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6361
6362         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6363
6364 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6365
6366         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6367         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6368         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6369         (nios2_linux_init_abi): Install it.
6370
6371 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6372
6373         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6374
6375 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6376
6377         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6378
6379 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6380             Tom Tromey  <tromey@adacore.com>
6381
6382         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6383
6384 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6385
6386         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6387         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6388         method to compute the bounds of range types. Also print "[evaluated]"
6389         if the bounds' values come from a dynamic evaluation.
6390
6391 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6392
6393         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6394         whitespace when pretty printing is on.
6395
6396 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6397
6398         * ppc-linux-nat.c: Add include.
6399
6400 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6401
6402         * NEWS: Mention AArch64 Pointer Authentication.
6403
6404 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6405
6406         * arm-linux-nat.c: Add include.
6407
6408 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6409
6410         * source-cache.c (source_cache::get_source_lines): Re-read
6411         fullname after calling open_source_file.
6412
6413 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6414
6415         * NEWS: Mention TLS support for FreeBSD.
6416
6417 2019-03-25  Tom Tromey  <tromey@adacore.com>
6418
6419         * minsyms.c (BUNCH_SIZE): Update comment.
6420         (~minimal_symbol_reader): Remove old comment.
6421         (compact_minimal_symbols): Update comment.
6422         (minimal_symbol_reader::install): Remove old comment.  Update
6423         other comments.
6424
6425 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6426
6427         * s390-linux-nat.c: Add include.
6428
6429 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6430
6431         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6432         Call linux_get_hwcap.
6433         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6434         Likewise.
6435         (aarch64_linux_get_hwcap): Remove function.
6436         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6437         declaration.
6438         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6439         linux_get_hwcap.
6440         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6441         * linux-tdep.c (linux_get_hwcap): Add function.
6442         (linux_get_hwcap2): Likewise.
6443         * linux-tdep.h (linux_get_hwcap): Add declaration.
6444         (linux_get_hwcap2): Likewise.
6445         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6446         (ppc_linux_get_hwcap2): Likewise.
6447         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6448         linux_get_hwcap.
6449         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6450         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6451         (ppc_linux_nat_target::read_description): Likewise.
6452         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6453         * s390-linux-nat.c: Likewise.
6454         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6455
6456 2019-03-24  Tom Tromey  <tom@tromey.com>
6457
6458         * ada-lang.c (standard_lookup): Simplify initialization.
6459         (ada_lookup_symbol_nonlocal): Simplify return.
6460         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6461         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6462         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6463         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6464         initialization.
6465         * solib.c (solib_global_lookup): Simplify.
6466         * symtab.c (null_block_symbol): Remove.
6467         (symbol_cache_lookup): Simplify returns.
6468         (lookup_language_this): Simplify returns.
6469         (lookup_symbol_aux): Simplify return.
6470         (lookup_local_symbol): Simplify returns.
6471         (lookup_global_symbol_from_objfile): Simplify return.
6472         (lookup_symbol_in_objfile_symtabs)
6473         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6474         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6475         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6476         * cp-namespace.c (cp_lookup_bare_symbol)
6477         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6478         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6479         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6480         (cp_lookup_symbol_via_imports): Simplify initialization.
6481         (find_symbol_in_baseclass): Likewise.
6482         * symtab.h (null_block_symbol): Remove.
6483         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6484         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6485         (d_lookup_symbol_module): Likewise.
6486         (find_symbol_in_baseclass): Simplify initialization.
6487
6488 2019-03-24  Tom Tromey  <tom@tromey.com>
6489
6490         * expression.h: Don't include symtab.h.
6491         (struct block): Forward declare.
6492
6493 2019-03-24  Tom Tromey  <tom@tromey.com>
6494
6495         * c-exp.y (typebase): Remove casts.
6496         * gdbtypes.c (lookup_unsigned_typename, )
6497         (lookup_signed_typename): Remove cast.
6498         * eval.c (parse_to_comma_and_eval): Remove cast.
6499         * parse.c (write_dollar_variable): Remove cast.
6500         * block.h (struct block) <superblock>: Now const.
6501         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6502         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6503         (map_block): Make "block" const.
6504         * symfile.h (struct quick_symbol_functions)
6505         <map_matching_symbols>: Constify block argument to "callback".
6506         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6507         const.
6508         (find_pc_sect_compunit_symtab): Make "b" const.
6509         (find_symbol_at_address): Likewise.
6510         (search_symbols): Likewise.
6511         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6512         (dw2_debug_names_lookup_symbol): Likewise.
6513         (dw2_map_matching_symbols): Update.
6514         * p-valprint.c (pascal_val_print): Remove "block".
6515         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6516         (aux_add_nonlocal_symbols): Make "block" const.
6517         (resolve_subexp): Remove cast.
6518         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6519         const.
6520         (iterate_over_file_blocks): Likewise.
6521         * f-exp.y (%union) <bval>: Remove.
6522         * coffread.c (patch_opaque_types): Make "b" const.
6523         * spu-tdep.c (spu_catch_start): Make "block" const.
6524         * c-valprint.c (print_unpacked_pointer): Remove "block".
6525         * symmisc.c (dump_symtab_1): Make "b" const.
6526         (block_depth): Make "block" const.
6527         * d-exp.y (%union) <bval>: Remove.
6528         * cp-support.h (cp_lookup_rtti_type): Update.
6529         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6530         * psymtab.c (psym_lookup_symbol): Make "block" const.
6531         (maintenance_check_psymtabs): Make "b" const.
6532         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6533         (enumerate_locals, enumerate_args): Update.
6534         * python/py-symtab.c (stpy_global_block): Make "block" const.
6535         (stpy_static_block): Likewise.
6536         * inline-frame.c (block_starting_point_at): Make "new_block"
6537         const.
6538         * block.c (find_block_in_blockvector): Make return type const.
6539         (blockvector_for_pc_sect): Make "b" const.
6540         (find_block_in_blockvector): Make "b" const.
6541
6542 2019-03-23  Tom Tromey  <tom@tromey.com>
6543
6544         * varobj.c (varobj_create): Update.
6545         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6546         * printcmd.c (display_command, do_one_display): Don't reset
6547         innermost_block.
6548         * parser-defs.h (enum innermost_block_tracker_type): Move to
6549         expression.h.
6550         (innermost_block): Update comment.
6551         * parse.c (parse_exp_1): Add tracker_types parameter.
6552         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6553         tracker_types parameter.  Reset innermost_block.
6554         (parse_exp_in_context): Remove.
6555         (parse_expression_for_completion): Update.
6556         * objfiles.c (~objfile): Don't reset expression_context_block or
6557         innermost_block.
6558         * expression.h (enum innermost_block_tracker_type): Move from
6559         parser-defs.h.
6560         (parse_exp_1): Add tracker_types parameter.
6561         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6562         reset innermost_block.
6563
6564 2019-03-23  Tom Tromey  <tom@tromey.com>
6565
6566         * objfiles.h: Include bcache.h.
6567
6568 2019-03-23  Tom Tromey  <tom@tromey.com>
6569
6570         * linespec.c (get_current_search_block): Use
6571         scoped_restore_current_language.
6572         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6573
6574 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6575             Jiong Wang  <jiong.wang@arm.com>
6576
6577         * aarch64-linux-tdep.c
6578         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6579         section.
6580         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6581
6582 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6583             Jiong Wang  <jiong.wang@arm.com>
6584
6585         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6586         instructions.
6587         (aarch64_analyze_prologue_test): Add PACIASP test.
6588         (aarch64_prologue_prev_register): Unmask PC value.
6589
6590 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6591             Jiong Wang  <jiong.wang@arm.com>
6592
6593         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6594         (aarch64_dwarf2_prev_register): Unmask PC value.
6595         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6596         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6597         DW_CFA_AARCH64_negate_ra_state.
6598         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6599
6600 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6601             Jiong Wang  <jiong.wang@arm.com>
6602
6603         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6604         registers.
6605         (aarch64_pseudo_register_name): Likewise.
6606         (aarch64_pseudo_register_type): Likewise.
6607         (aarch64_pseudo_register_reggroup_p): Likewise.
6608         (aarch64_gdbarch_init): Add pauth registers.
6609         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6610         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6611         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6612         (struct gdbarch_tdep): Add regnum for ra_state.
6613
6614 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6615             Jiong Wang  <jiong.wang@arm.com>
6616
6617         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6618
6619 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6620             Jiong Wang  <jiong.wang@arm.com>
6621
6622         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6623         function.
6624         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6625         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6626         (aarch64_gdbarch_init): Add puth registers.
6627         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6628         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6629         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6630
6631 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6632             Jiong Wang  <jiong.wang@arm.com>
6633
6634         * aarch64-linux-nat.c
6635         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6636         * aarch64-linux-tdep.c
6637         (aarch64_linux_core_read_description): Likewise.
6638         (aarch64_linux_get_hwcap): New function.
6639         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6640         (aarch64_linux_get_hwcap): New declaration.
6641
6642 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6643             Jiong Wang  <jiong.wang@arm.com>
6644
6645         * aarch64-linux-nat.c
6646         (aarch64_linux_nat_target::read_description): Add pauth param.
6647         * aarch64-linux-tdep.c
6648         (aarch64_linux_core_read_description): Likewise.
6649         * aarch64-tdep.c (struct target_desc): Add in pauth.
6650         (aarch64_read_description): Add pauth param.
6651         (aarch64_gdbarch_init): Likewise.
6652         * aarch64-tdep.h (aarch64_read_description): Likewise.
6653         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6654         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6655         * features/Makefile: Add new files.
6656         * features/aarch64-pauth.c: New file.
6657         * features/aarch64-pauth.xml: New file.
6658
6659 2019-03-20  Tom Tromey  <tromey@adacore.com>
6660
6661         * infrun.c (handle_inferior_event): Rename from
6662         handle_inferior_event_1.  Create a scoped_value_mark.
6663         (handle_inferior_event): Remove.
6664
6665 2019-03-19  Tom Tromey  <tromey@adacore.com>
6666
6667         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6668         * infrun.h (print_stop_event): Add "displays" parameter.
6669         * infrun.c (print_stop_event): Add "displays" parameter.
6670
6671 2019-03-19  Pedro Alves  <palves@redhat.com>
6672
6673         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6674         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6675         to -1.  Fix TABs vs spaces.
6676         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6677         * tui/tui-out.h (tui_ui_out) Add intro comments.
6678         <m_line, m_start_of_line>: In-class initialize, and add describing
6679         comment.
6680
6681 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6682
6683         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6684         variable names.
6685         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6686
6687 2019-03-18  Pedro Alves  <palves@redhat.com>
6688             Eli Zaretskii <eliz@gnu.org>
6689
6690         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6691         m_line and m_start_of_line.
6692
6693 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6694
6695         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6696         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6697         it returns a newline.  This fixes a regression in TU mode, whereby
6698         the next line is output on the same screen line as the user input.
6699
6700 2019-03-18  Tom Tromey  <tromey@adacore.com>
6701
6702         * minsyms.c (minimal_symbol_reader::install): Remove call to
6703         obstack_blank.
6704
6705 2019-03-18  Pedro Alves  <palves@redhat.com>
6706
6707         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6708         New globals.
6709         (apply_style): New, factored out from ...
6710         (apply_ansi_escape): ... this.  Handle reverse video mode.
6711         (tui_set_reverse_mode): New function.
6712         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6713         * tui/tui-winsource.c (tui_show_source_line): Use
6714         tui_set_reverse_mode instead of setting A_STANDOUT.
6715         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6716         New setter methods.
6717
6718 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6719
6720         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6721         Handle tabs.
6722
6723 2019-03-18  Tom Tromey  <tromey@adacore.com>
6724
6725         * ada-lang.c (empty_array): Add "high" parameter.
6726         (ada_evaluate_subexp): Update.
6727
6728 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6729
6730         * unittests/string_view-selftests.c: Define
6731         _initialize_string_view_selftests unconditionally.
6732
6733 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6734
6735         PR gdb/24350
6736         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6737
6738 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6739
6740         PR gdb/24351
6741         * windows-nat.c (display_selector): Fix format specifiers.
6742
6743 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6744
6745         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6746         tui_refill_source_window instead of tui_refresh_win, to update the
6747         current execution line.  This fixes redisplay of the current line
6748         when stepping through the code with "next" or "step".
6749
6750 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6751
6752         * source-cache.c (source_cache::get_source_lines): Call
6753         find_source_lines to initialize s->nlines.  This fixes vertical
6754         scrolling of TUI source window when the DOWN arrow is pressed.
6755
6756 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6757
6758         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6759         linux-thread-db.c (_initialize_thread_db): Likewise.
6760
6761 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6762
6763         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6764         wclrtoeol in tui_show_source_line".  This reverts changes made in
6765         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6766
6767 2019-03-15  Tom Tromey  <tom@tromey.com>
6768
6769         * symtab.h (struct minimal_symbol): Derive from
6770         general_symbol_info.
6771         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6772         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6773         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6774         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6775         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6776         (MSYMBOL_SEARCH_NAME): Update.
6777         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6778         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6779         * minsyms.c (minimal_symbol_reader::record_full): Update.
6780
6781 2019-03-15  Tom Tromey  <tom@tromey.com>
6782
6783         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6784
6785 2019-03-15  Tom Tromey  <tom@tromey.com>
6786
6787         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6788         unique_xmalloc_ptr.
6789         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6790         Update.
6791         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6792         (build_minimal_symbol_hash_tables)
6793         (minimal_symbol_reader::install): Update.
6794
6795 2019-03-15  Tom Tromey  <tom@tromey.com>
6796
6797         * symtab.c (create_demangled_names_hash): Update.
6798         (symbol_set_names): Update.
6799         * objfiles.h (struct objfile_per_bfd_storage)
6800         <demangled_names_hash>: Now an htab_up.
6801         * objfiles.c (objfile_per_bfd_storage): Simplify.
6802
6803 2019-03-15  Tom Tromey  <tom@tromey.com>
6804
6805         * objfiles.h (struct objfile_per_bfd_storage): Declare
6806         destructor.
6807         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6808         New.
6809         (get_objfile_bfd_data): Use new.  Don't initialize
6810         language_of_main.
6811         (free_objfile_per_bfd_storage): Remove.
6812         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6813
6814 2019-03-15  Tom Tromey  <tom@tromey.com>
6815
6816         * symfile.c (reread_symbols): Update.
6817         * objfiles.c (objfile::objfile): Update.
6818         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6819         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6820         comment.
6821         (minimal_symbol_reader::install): Update.
6822         (terminate_minimal_symbol_table): Remove.
6823         * jit.c (jit_object_close_impl): Update.
6824
6825 2019-03-15  Tom Tromey  <tom@tromey.com>
6826
6827         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6828         initializations.
6829
6830 2019-03-15  Tom Tromey  <tom@tromey.com>
6831
6832         * objfiles.h (struct objfile_per_bfd_storage)
6833         <demangled_hash_languages>: Now a bitset.
6834         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6835         (lookup_minimal_symbol): Update.
6836
6837 2019-03-15  Tom Tromey  <tom@tromey.com>
6838
6839         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6840         Don't return the symbol.
6841         * coffread.c (record_minimal_symbol): Use record_full.
6842
6843 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6844
6845         The MS-Windows port of ncurses fails to switch to a color pair if
6846         one or both of the colors are the implicit default colors.  This
6847         change records the default colors when TUI is initialized, and
6848         then specifies them explicitly when a color pair uses the default
6849         colors.  This allows color styling in TUI mode on MS-Windows.
6850
6851         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6852         ncurses_norm_attr.
6853         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6854         colors in ncurses_norm_attr.
6855         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6856         "none", replace it with the default color recorded in
6857         ncurses_norm_attr.
6858
6859 2019-03-14  Tom Tromey  <tromey@adacore.com>
6860
6861         * source-cache.h (class source_cache) <get_source_lines>: Return
6862         std::string.
6863         * source-cache.c (source_cache::extract_lines): Handle case where
6864         first_pos==npos.  Return std::string.
6865         (source_cache::get_source_lines): Update.
6866
6867 2019-03-14  Tom Tromey  <tromey@adacore.com>
6868
6869         * NEWS: Add item for "style sources" commands.
6870         * source-cache.c (source_cache::get_source_lines): Check
6871         source_styling.
6872         * cli/cli-style.c (source_styling): New global.
6873         (_initialize_cli_style): Add "style sources" commands.
6874         (show_style_sources): New function.
6875         * cli/cli-style.h (source_styling): Declare.
6876
6877 2019-03-14  Pedro Alves  <palves@redhat.com>
6878             Tom Tromey  <tromey@adacore.com>
6879
6880         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6881         * tui/tui-winsource.c (tui_refill_source_window): New function,
6882         from...
6883         (tui_horizontal_source_scroll): ... here.  Move some logic.
6884         * cli/cli-style.c (set_style_enabled): Notify new observable.
6885         * tui/tui-hooks.c (tui_redisplay_source): New function.
6886         (tui_attach_detach_observers): Attach or detach
6887         tui_redisplay_source.
6888         * observable.h (source_styling_changed): New observable.
6889         * observable.c: Define source_styling_changed observable.
6890
6891 2019-03-13  Tom Tromey  <tromey@adacore.com>
6892
6893         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6894         (i386_gnu_nat_target::store_registers): Update.
6895         * target-debug.h (target_debug_print_std_string): New macro.
6896         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6897         * windows-tdep.c (display_one_tib): Update.
6898         * tui/tui-stack.c (tui_make_status_line): Update.
6899         * top.c (print_inferior_quit_action): Update.
6900         * thread.c (thr_try_catch_cmd): Update.
6901         (add_thread_with_info): Update.
6902         (thread_target_id_str): Update.
6903         (thr_try_catch_cmd): Update.
6904         (thread_command): Update.
6905         (thread_find_command): Update.
6906         * record-btrace.c (record_btrace_target::info_record)
6907         (record_btrace_resume_thread, record_btrace_target::resume)
6908         (record_btrace_cancel_resume, record_btrace_step_thread)
6909         (record_btrace_target::wait, record_btrace_target::wait)
6910         (record_btrace_target::wait, record_btrace_target::stop): Update.
6911         * progspace.c (print_program_space): Update.
6912         * process-stratum-target.c
6913         (process_stratum_target::thread_address_space): Update.
6914         * linux-fork.c (linux_fork_mourn_inferior)
6915         (detach_checkpoint_command, info_checkpoints_command)
6916         (linux_fork_context): Update.
6917         (linux_fork_detach): Update.
6918         (class scoped_switch_fork_info): Update.
6919         (delete_checkpoint_command): Update.
6920         * infrun.c (follow_fork_inferior): Update.
6921         (follow_fork_inferior): Update.
6922         (proceed_after_vfork_done): Update.
6923         (handle_vfork_child_exec_or_exit): Update.
6924         (follow_exec): Update.
6925         (displaced_step_prepare_throw): Update.
6926         (displaced_step_restore): Update.
6927         (start_step_over): Update.
6928         (resume_1): Update.
6929         (clear_proceed_status_thread): Update.
6930         (proceed): Update.
6931         (print_target_wait_results): Update.
6932         (do_target_wait): Update.
6933         (context_switch): Update.
6934         (stop_all_threads): Update.
6935         (restart_threads): Update.
6936         (finish_step_over): Update.
6937         (handle_signal_stop): Update.
6938         (switch_back_to_stepped_thread): Update.
6939         (keep_going_pass_signal): Update.
6940         (print_exited_reason): Update.
6941         (normal_stop): Update.
6942         * inferior.c (inferior_pid_to_str): Change return type.
6943         (print_selected_inferior): Update.
6944         (add_inferior): Update.
6945         (detach_inferior): Update.
6946         * dummy-frame.c (fprint_dummy_frames): Update.
6947         * dcache.c (dcache_info_1): Update.
6948         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6949         (btrace_fetch, btrace_clear): Update.
6950         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6951         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6952         type.
6953         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6954         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6955         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6956         * gdbarch.c, gdbarch.h: Rebuild.
6957         * gdbarch.sh (core_pid_to_str): Change return type.
6958         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6959         return type.
6960         (windows_nat_target::pid_to_str): Change return type.
6961         (windows_delete_thread): Update.
6962         (windows_nat_target::attach): Update.
6963         (windows_nat_target::files_info): Update.
6964         * target-delegates.c: Rebuild.
6965         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6966         return type.
6967         (sol_thread_target::pid_to_str): Change return type.
6968         * remote.c (class remote_target) <pid_to_str>: Change return
6969         type.
6970         (remote_target::pid_to_str): Change return type.
6971         (extended_remote_target::attach, remote_target::remote_stop_ns)
6972         (remote_target::remote_notif_remove_queued_reply)
6973         (remote_target::push_stop_reply, remote_target::disable_btrace):
6974         Update.
6975         (extended_remote_target::attach): Update.
6976         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6977         type.
6978         (gdbsim_target::pid_to_str): Change return type.
6979         * ravenscar-thread.c (struct ravenscar_thread_target)
6980         <pid_to_str>: Change return type.
6981         (ravenscar_thread_target::pid_to_str): Change return type.
6982         * procfs.c (class procfs_target) <pid_to_str>: Change return
6983         type.
6984         (procfs_target::pid_to_str): Change return type.
6985         (procfs_target::attach): Update.
6986         (procfs_target::detach): Update.
6987         (procfs_target::fetch_registers): Update.
6988         (procfs_target::store_registers): Update.
6989         (procfs_target::wait): Update.
6990         (procfs_target::files_info): Update.
6991         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6992         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6993         return type.
6994         (nto_procfs_target::pid_to_str): Change return type.
6995         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6996         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6997         return type.
6998         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6999         (exit_lwp): Update.
7000         (attach_proc_task_lwp_callback, get_detach_signal)
7001         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7002         (linux_nat_target::resume, wait_lwp, stop_callback)
7003         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7004         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7005         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7006         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7007         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7008         type.
7009         (inf_ptrace_target::attach): Update.
7010         (inf_ptrace_target::files_info): Update.
7011         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7012         type.
7013         (go32_nat_target::pid_to_str): Change return type.
7014         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7015         (gnu_nat_target::wait): Update.
7016         (gnu_nat_target::wait): Update.
7017         (gnu_nat_target::resume): Update.
7018         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7019         (fbsd_nat_target::wait): Update.
7020         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7021         type.
7022         (darwin_nat_target::attach): Update.
7023         * corelow.c (class core_target) <pid_to_str>: Change return type.
7024         (core_target::pid_to_str): Change return type.
7025         * target.c (normal_pid_to_str): Change return type.
7026         (default_pid_to_str): Likewise.
7027         (target_pid_to_str): Change return type.
7028         (target_translate_tls_address): Update.
7029         (target_announce_detach): Update.
7030         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7031         return type.
7032         (bsd_uthread_target::pid_to_str): Change return type.
7033         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7034         type.
7035         (bsd_kvm_target::pid_to_str): Change return type.
7036         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7037         return type.
7038         (aix_thread_target::pid_to_str): Change return type.
7039         * target.h (struct target_ops) <pid_to_str>: Change return type.
7040         (target_pid_to_str, normal_pid_to_str): Likewise.
7041         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7042         type.
7043         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7044         type.
7045         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7046         return type.
7047         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7048         type.
7049         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7050         type.
7051         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7052         return type.
7053
7054 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7055
7056         * NEWS: Mention that the new default MI version is 3.  Mention
7057         changes to the output of commands and events that deal with
7058         multi-location breakpoints.
7059         * breakpoint.c: Include "mi/mi-out.h".
7060         (print_one_breakpoint): Change output syntax if using MI version
7061         >= 3.
7062         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7063         New.
7064         (mi_multi_location_breakpoint_output_fixed): New.
7065         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7066         (mi_cmd_fix_multi_location_breakpoint_output): New.
7067         (mi_multi_location_breakpoint_output_fixed): New.
7068         * mi/mi-cmds.c (mi_cmds): Register command
7069         -fix-multi-location-breakpoint-output.
7070         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7071         interpreter "mi".
7072
7073 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7074
7075         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7076         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7077         instantiate mi_ui_out based on interpreter name.
7078         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7079         * mi/mi-main.c (mi_load_progress): Likewise.
7080
7081 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7082
7083         * NEWS: Combine separate "New targets" sections for 8.3.
7084
7085 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7086
7087         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7088         (ppcfbsd_init_abi): Install gdbarch
7089         "fetch_tls_load_module_address" and "get_thread_local_address"
7090         methods.
7091
7092 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7093
7094         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7095         (riscv_fbsd_init_abi): Install gdbarch
7096         "fetch_tls_load_module_address" and "get_thread_local_address"
7097         methods.
7098
7099 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7100
7101         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7102         (i386fbsd_init_abi): Install gdbarch
7103         "fetch_tls_load_module_address" and "get_thread_local_address"
7104         methods.
7105
7106 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7107
7108         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7109         (amd64fbsd_init_abi): Install gdbarch
7110         "fetch_tls_load_module_address" and "get_thread_local_address"
7111         methods.
7112
7113 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7114
7115         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7116         (struct fbsd_pspace_data): New type.
7117         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7118         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7119         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7120         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7121         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7122
7123 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7124
7125         * gdbtypes.c (lookup_struct_elt): New function.
7126         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7127         * gdbtypes.h (struct struct_elt): New type.
7128         (lookup_struct_elt): New prototype.
7129
7130 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7131
7132         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7133         remove disabled code block.
7134
7135 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7136
7137         * gdbarch.sh (get_thread_local_address): New method.
7138         * gdbarch.h, gdbarch.c: Regenerate.
7139         * target.c (target_translate_tls_address): Use
7140         gdbarch_get_thread_local_address if present instead of
7141         target::get_thread_local_address.
7142
7143 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7144
7145         * target.h (target::get_thread_local_address): Update comment.
7146
7147 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7148
7149         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7150         objfile->separate_debug_objfile_backlink if not NULL.
7151
7152 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7153
7154         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7155         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7156         (amd64bsd_store_inferior_registers): Likewise.
7157         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7158         Enable segment base registers.
7159         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7160         PT_GETFSBASE and PT_GETGSBASE.
7161         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7162         PT_SETGSBASE.
7163         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7164         segment base registers.
7165         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7166
7167 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7168
7169         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7170         Update calls to i386_target_description to add 'segments'
7171         parameter.
7172         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7173         add segment base registers.
7174         * arch/i386.c (i386_create_target_description): Add 'segments'
7175         parameter to enable segment base registers.
7176         * arch/i386.h (i386_create_target_description): Likewise.
7177         * features/i386/32bit-segments.xml: New file.
7178         * features/i386/32bit-segments.c: Generate.
7179         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7180         call to i386_target_description to add 'segments' parameter.
7181         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7182         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7183         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7184         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7185         if feature is present.
7186         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7187         Add 'segments' parameter to call to i386_target_description.
7188         (i386_target_description): Add 'segments' parameter to enable
7189         segment base registers.
7190         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7191         to call to i386_target_description.
7192         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7193         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7194         Define I386_NUM_REGS.
7195         (i386_target_description): Add 'segments' parameter to enable
7196         segment base registers.
7197
7198 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7199
7200         PR/24325
7201         * source-cache.c: #undef open and close, to avoid unresolved
7202         externals during linking.
7203
7204 2019-03-12  Tom Tromey  <tromey@adacore.com>
7205
7206         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7207         const.  Add initializers.
7208         (_initialize_remote): Don't initialize ptid globals.
7209
7210 2019-03-12  Pedro Alves  <palves@redhat.com>
7211
7212         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7213
7214 2019-03-12  Pedro Alves  <palves@redhat.com>
7215
7216         * cp-name-parser.y (main): Remove unused 'len' variable.
7217
7218 2019-03-12  Tom Tromey  <tromey@adacore.com>
7219
7220         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7221         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7222
7223 2019-03-12  Tom Tromey  <tromey@adacore.com>
7224
7225         * linux-nat.c (iterate_over_lwps): Update.
7226         (stop_callback): Remove parameter.
7227         (stop_wait_callback, detach_callback, resume_set_callback)
7228         (select_singlestep_lwp_callback, set_ignore_sigint)
7229         (status_callback, resumed_callback, resume_clear_callback)
7230         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7231         data parameter.
7232         (linux_nat_target::detach, linux_nat_target::resume)
7233         (linux_stop_and_wait_all_lwps, select_event_lwp)
7234         (linux_nat_filter_event, linux_nat_wait_1)
7235         (linux_nat_target::kill, linux_nat_target::stop)
7236         (linux_nat_target::stop): Update.
7237         (linux_nat_resume_callback): Change type.
7238         (resume_stopped_resumed_lwps, count_events_callback)
7239         (select_event_lwp_callback): Likewise.
7240         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7241         * arm-linux-nat.c (struct update_registers_data): Remove.
7242         (update_registers_callback): Change type.
7243         (arm_linux_insert_hw_breakpoint1): Update.
7244         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7245         parameter.
7246         (x86_linux_dr_set_addr): Update.
7247         (x86_linux_dr_set_control): Update.
7248         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7249         (iterate_over_lwps): Use gdb::function_view.
7250         * nat/aarch64-linux-hw-point.c (struct
7251         aarch64_dr_update_callback_param): Remove.
7252         (debug_reg_change_callback): Change type.
7253         (aarch64_notify_debug_reg_change): Update.
7254         * s390-linux-nat.c (s390_refresh_per_info): Update.
7255
7256 2019-03-11  Tom Tromey  <tromey@adacore.com>
7257
7258         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7259         redundant assignment to "this_cu".
7260
7261 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7262
7263         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7264
7265 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7266
7267         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7268         from...
7269         (rank_one_type): ... this.
7270
7271 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7272
7273         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7274         from...
7275         (rank_one_type): ... this.
7276
7277 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7278
7279         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7280         from...
7281         (rank_one_type): ... this.
7282
7283 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7284
7285         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7286         from...
7287         (rank_one_type): ... this.
7288
7289 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7290
7291         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7292         from...
7293         (rank_one_type): ... this.
7294
7295 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7296
7297         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7298         from...
7299         (rank_one_type): ... this.
7300
7301 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7302
7303         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7304         from...
7305         (rank_one_type): ... this.
7306
7307 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7308
7309         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7310         from...
7311         (rank_one_type): ... this.
7312
7313 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7314
7315         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7316         from...
7317         (rank_one_type): ... this.
7318
7319 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7320
7321         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7322         from...
7323         (rank_one_type): ... this.
7324
7325 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7326
7327         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7328         from...
7329         (rank_one_type): ... this.
7330
7331 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7332
7333         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7334         from...
7335         (rank_one_type): ... this.
7336
7337 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7338
7339         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7340         inferior-events' shows the example events.
7341
7342 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7343
7344         Support styling on native MS-Windows console
7345
7346         PR/24315
7347         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7348         on MS-Windows if $TERM is not defined.
7349
7350         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7351
7352         * posix-hdep.c (gdb_console_fputs):
7353         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7354         functions.
7355         * ui-file.h (gdb_console_fputs): Add prototype.
7356
7357         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7358         back to fputs only if the former returns zero.
7359
7360 2019-03-07  Tom Tromey  <tom@tromey.com>
7361
7362         * symmisc.c (print_symbol_bcache_statistics): Update.
7363         (print_objfile_statistics): Update.
7364         * symfile.c (allocate_symtab): Update.
7365         * stabsread.c: Don't include bcache.h.
7366         * psymtab.h (struct psymbol_bcache): Don't declare.
7367         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7368         (psymbol_bcache_init, psymbol_bcache_free)
7369         (psymbol_bcache_get_bcache): Don't declare.
7370         * psymtab.c (struct psymbol_bcache): Remove.
7371         (psymtab_storage::psymtab_storage): Update.
7372         (psymtab_storage::~psymtab_storage): Update.
7373         (psymbol_bcache_init, psymbol_bcache_free)
7374         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7375         (add_psymbol_to_bcache): Update.
7376         (allocate_psymtab): Update.
7377         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7378         macro_cache>: No longer pointers.
7379         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7380         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7381         * macrotab.c (macro_bcache): Update.
7382         * macroexp.c: Don't include bcache.h.
7383         * gdbtypes.c (check_types_worklist): Update.
7384         (types_deeply_equal): Remove TRY/CATCH.  Update.
7385         * elfread.c (elf_symtab_read): Update.
7386         * dwarf2read.c: Don't include bcache.h.
7387         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7388         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7389         (print_bcache_statistics, bcache_memory_used): Don't declare.
7390         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7391         methods.  Rename all data members.
7392         * bcache.c (struct bcache): Move to bcache.h.
7393         (bcache::expand_hash_table): Rename from expand_hash_table.
7394         (bcache): Remove.
7395         (bcache::insert): Rename from bcache_full.
7396         (bcache::compare): Rename from bcache_compare.
7397         (bcache_xmalloc): Remove.
7398         (bcache::~bcache): Rename from bcache_xfree.
7399         (bcache::print_statistics): Rename from print_bcache_statistics.
7400         (bcache::memory_used): Rename from bcache_memory_used.
7401
7402 2019-03-07  Pedro Alves  <palves@redhat.com>
7403
7404         * infrun.c (normal_stop): Also check for
7405         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7406
7407 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7408
7409         * f-lang.c (value_from_host_double): Moved to...
7410         * value.c (value_from_host_double): ...here.
7411         * value.h (value_from_host_double): Declare.
7412         * guile/scm-math.c (vlscm_convert_typed_number): Use
7413         value_from_host_double.
7414         (vlscm_convert_number): Likewise.
7415         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7416         * python/py-value.c (convert_value_from_python): Likewise.
7417
7418 2019-03-06  Tom Tromey  <tom@tromey.com>
7419
7420         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7421
7422 2019-03-06  Tom Tromey  <tom@tromey.com>
7423
7424         * utils.h (free_current_contents): Don't declare.
7425         * utils.c (free_current_contents): Remove.
7426
7427 2019-03-06  Tom Tromey  <tom@tromey.com>
7428
7429         * top.c (quit_force): Update.
7430         * main.c (captured_command_loop): Update.
7431         * common/new-op.c (operator new): Update.
7432         * common/common-exceptions.c (struct catcher)
7433         <save_cleanup_chain>: Remove member.
7434         (exceptions_state_mc_init): Update.
7435         (exception_try_scope_entry): Return nullptr.
7436         (exception_try_scope_exit, exception_rethrow)
7437         (throw_exception_sjlj, throw_exception_cxx): Update.
7438         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7439         (all_cleanups, do_cleanups, discard_cleanups)
7440         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7441         (restore_cleanups, restore_final_cleanups): Don't declare.
7442         (do_final_cleanups): Remove parameter.
7443         * common/cleanups.c (cleanup_chain, make_cleanup)
7444         (make_cleanup_dtor, all_cleanups, do_cleanups)
7445         (discard_my_cleanups, discard_cleanups)
7446         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7447         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7448         (null_cleanup): Remove.
7449         (do_final_cleanups): Remove parameter.
7450
7451 2019-03-06  Tom Tromey  <tom@tromey.com>
7452
7453         * remote.c (remote_target::remote_parse_stop_reply): Use
7454         unique_xmalloc_ptr.
7455
7456 2019-03-06  Tom Tromey  <tom@tromey.com>
7457
7458         * stabsread.c (struct stabs_field_info): Rename from field_info.
7459         <list, fnlist>: Add initializers.
7460         <obstack>: New member.
7461         (read_member_functions, read_struct_fields, read_baseclasses):
7462         Allocate on obstack.  Don't use cleanups.
7463         (read_one_struct_field, read_member_functions, read_struct_fields)
7464         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7465         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7466         (read_struct_type): Update.
7467
7468 2019-03-06  Tom Tromey  <tom@tromey.com>
7469
7470         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7471         * common/filestuff.h (make_cleanup_close): Don't declare.
7472         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7473         Remove.
7474
7475 2019-03-06  Tom Tromey  <tom@tromey.com>
7476
7477         * solib-aix.c: Use make_scope_exit.
7478
7479 2019-03-06  Tom Tromey  <tom@tromey.com>
7480
7481         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7482         Use make_scope_exit.
7483
7484 2019-03-06  Tom Tromey  <tom@tromey.com>
7485
7486         * solib-svr4.c (disable_probes_interface): Remove parameter.
7487         (svr4_handle_solib_event): Use make_scope_exit.
7488
7489 2019-03-06  Tom Tromey  <tom@tromey.com>
7490
7491         * remote.c (struct stop_reply_deleter): Remove.
7492         (stop_reply_up): Update.
7493         (struct stop_reply): Derive from notif_event.  Don't typedef.
7494         <regcache>: Now a std::vector.
7495         (stop_reply_xfree): Remove.
7496         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7497         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7498         (remote_target::discard_pending_stop_replies): Use delete.
7499         (remote_target::remote_parse_stop_reply): Update.
7500         (remote_target::process_stop_reply): Update.
7501         * remote-notif.h (struct notif_event): Add virtual destructor.
7502         Remove "dtr" member.
7503         (struct notif_client) <alloc_event>: Return a unique_ptr.
7504         (notif_event_xfree): Don't declare.
7505         (notif_event_up): New typedef.
7506         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7507         (notif_event_xfree, do_notif_event_xfree): Remove.
7508         (remote_notif_state_xfree): Update.
7509
7510 2019-03-06  Tom Tromey  <tom@tromey.com>
7511
7512         * infrun.c (displaced_step_clear_cleanup): Now a
7513         forward_scope_exit type.
7514         (displaced_step_prepare_throw): Update.
7515         (displaced_step_fixup): Update.
7516
7517 2019-03-06  Tom Tromey  <tom@tromey.com>
7518
7519         * inferior.h (class inferior): Update comment.
7520         * gdbthread.h (class thread_info): Update comment.
7521
7522 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7523             Tom Tromey  <tom@tromey.com>
7524
7525         * stabsread.h (struct stab_section_list): Remove.
7526         (coffstab_build_psymtabs): Update.
7527         * dbxread.c (symbuf_sections): Now a std::vector.
7528         (sect_idx): New global.
7529         (fill_symbuf): Update.
7530         (coffstab_build_psymtabs): Change type of stabsects parameter.
7531         Update.
7532         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7533         std::vector.
7534         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7535         (coff_locate_sections): Update.
7536         (coff_symfile_read): Remove cleanups.  Update.
7537         (init_stringtab): Add storage parameter.
7538         (free_stringtab, free_stringtab_cleanup): Remove.
7539         (init_lineno): Add storage parameter.
7540         (free_linetab, free_linetab_cleanup): Remove.
7541
7542 2019-03-06  Pedro Alves  <palves@redhat.com>
7543
7544         * linux-fork.c (fork_info::clobber_regs): Delete.
7545         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7546         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7547         comment.  Adjust.
7548         (scoped_switch_fork_info::scoped_switch_fork_info)
7549         (checkpoint_command, linux_fork_context): Adjust
7550         fork_save_infrun_state calls.
7551
7552 2019-03-06  Pedro Alves  <palves@redhat.com>
7553
7554         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7555         (inf_has_multiple_threads): Return 'bool' and rewrite using
7556         inferior_info::threads().
7557
7558 2019-03-06  Pedro Alves  <palves@redhat.com>
7559
7560         * linux-fork.c: Include <list>.
7561         (fork_list): Now a std::list instance.
7562         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7563         (forks_exist_p, find_last_fork): Adjust.
7564         (new_fork): Delete.
7565         (one_fork_p): New.
7566         (add_fork): Adjust.
7567         (free_fork): Delete, folded into fork_info::~fork_info().
7568         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7569         Adjust.
7570         (init_fork_list): Delete.
7571         (linux_fork_killall, linux_fork_mourn_inferior)
7572         (linux_fork_detach, info_checkpoints_command): Adjust.
7573         (_initialize_linux_fork): No longer call init_fork_list.
7574
7575 2019-03-06  Pedro Alves  <palves@redhat.com>
7576
7577         * linux-fork.c (new_fork): New, split out of ...
7578         (add_fork): ... this.  Return void.  Move "first fork" special
7579         case from here, to ...
7580         (checkpoint_command): ... here.
7581         * linux-linux.h (add_fork): Return void.
7582
7583 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7584
7585         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7586
7587 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7588             Chris January  <chris.january@arm.com>
7589             David Lecomber  <david.lecomber@arm.com>
7590
7591         * f-exp.y: New token, UNOP_INTRINSIC.
7592         (exp): New pattern using UNOP_INTRINSIC token.
7593         (f77_keywords): Add 'abs' keyword.
7594         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7595         (value_from_host_double): New function.
7596         (evaluate_subexp_f): Support UNOP_ABS.
7597
7598 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7599
7600         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7601         types.
7602
7603 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7604
7605         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7606         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7607         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7608
7609 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7610
7611         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7612
7613 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7614             Chris January  <chris.january@arm.com>
7615
7616         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7617         * f-exp.y: Define 'KIND' token.
7618         (exp): New pattern for KIND expressions.
7619         (ptype): Handle types with a kind extension.
7620         (direct_abs_decl): Extend to spot kind extensions.
7621         (f77_keywords): Add 'kind' to the list.
7622         (push_kind_type): New function.
7623         (convert_to_kind_type): New function.
7624         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7625         * parse.c (operator_length_standard): Likewise.
7626         * parser-defs.h (enum type_pieces): Add tp_kind.
7627         * std-operator.def: Add UNOP_KIND.
7628
7629 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7630
7631         * f-exp.y (f_parse): Set yydebug.
7632
7633 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7634
7635         * f-lang.c (evaluate_subexp_f): New function.
7636         (exp_descriptor_f): New global.
7637         (f_language_defn): Use exp_descriptor_f instead of
7638         exp_descriptor_standard.
7639
7640 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7641
7642         * f-exp.y (struct token): Add comments.
7643         (dot_ops): Remove uppercase versions and the end marker.
7644         (f77_keywords): Likewise.
7645         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7646         entries in the dot_ops array are case insensitive, and use
7647         strncasecmp to compare strings.  Also some whitespace cleanup in
7648         this area.  Similar for the f77_keywords array, except entries in
7649         this list might be case sensitive.
7650
7651 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7652
7653         * f-exp.y (struct f77_boolean_val): Add comments.
7654         (boolean_values): Remove uppercase versions, and end marker.
7655         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7656         and use strncasecmp to achieve case insensitivity.  Additionally,
7657         perform whitespace cleanup around this code.
7658
7659 2019-03-06  Tom Tromey  <tromey@adacore.com>
7660
7661         * remote-sim.c (gdbsim_target_open): Use result of
7662         gdb_argv::release.
7663
7664 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7665         Dirk Schubert  <dirk.schubert@arm.com>
7666         Chris January  <chris.january@arm.com>
7667
7668         * eval.c (evaluate_subexp_standard): Call Fortran argument
7669         wrapping logic.
7670         * f-lang.c (struct value): A value which can be passed into a
7671         Fortran function call.
7672         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7673         where appropriate.
7674         (struct type): Value ready for a Fortran function call.
7675         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7676         is needed.
7677         * f-lang.h (fortran_argument_convert): Declaration.
7678         (fortran_preserve_arg_pointer): Declaration.
7679         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7680
7681 2019-03-05  Tom Tromey  <tromey@adacore.com>
7682
7683         * python/py-prettyprint.c (print_string_repr): Remove #if.
7684         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7685
7686 2019-03-05  Tom Tromey  <tromey@adacore.com>
7687
7688         * target.c (the_dummy_target): Move later.  Change type to
7689         "dummy_target".
7690         (initialize_targets): Don't initialize the_dummy_target.
7691
7692 2019-03-05  Tom Tromey  <tromey@adacore.com>
7693
7694         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7695         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7696
7697 2019-03-05  Tom Tromey  <tromey@adacore.com>
7698
7699         * windows-nat.c (windows_nat_target::attach)
7700         (windows_nat_target::detach): Don't call gdb_flush.
7701         * valprint.c (generic_val_print, val_print, val_print_string):
7702         Don't call gdb_flush.
7703         * utils.c (defaulted_query): Don't call gdb_flush.
7704         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7705         * target.c (target_announce_detach): Don't call gdb_flush.
7706         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7707         * remote.c (extended_remote_target::attach): Don't call
7708         gdb_flush.
7709         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7710         * printcmd.c (do_examine): Don't call gdb_flush.
7711         (info_display_command): Don't call gdb_flush.
7712         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7713         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7714         * memattr.c (info_mem_command): Don't call gdb_flush.
7715         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7716         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7717         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7718         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7719         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7720         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7721         (gnu_nat_target::detach): Don't call gdb_flush.
7722         * f-valprint.c (f_val_print): Don't call gdb_flush.
7723         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7724         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7725         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7726         gdb_flush.
7727         * c-valprint.c (c_val_print): Don't call gdb_flush.
7728         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7729
7730 2019-03-05  Tom Tromey  <tromey@adacore.com>
7731
7732         * varobj.c (update_dynamic_varobj_children): Update.
7733         (install_default_visualizer): Use reset, not release.
7734         * value.c (set_internalvar): Update.
7735         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7736         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7737         ATTRIBUTE_UNUSED_RESULT.
7738
7739 2019-03-05  Tom Tromey  <tromey@adacore.com>
7740
7741         * remote.c (class scoped_remote_fd) <release>: Add
7742         ATTRIBUTE_UNUSED_RESULT.
7743
7744 2019-03-05  Tom Tromey  <tromey@adacore.com>
7745
7746         * macroexp.c (struct macro_buffer) <release>: Add
7747         ATTRIBUTE_UNUSED_RESULT.
7748
7749 2019-03-05  Tom Tromey  <tromey@adacore.com>
7750
7751         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7752         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7753         ATTRIBUTE_UNUSED_RESULT.
7754
7755 2019-03-05  Tom Tromey  <tromey@adacore.com>
7756
7757         * common/scoped_fd.h (class scoped_fd) <release>: Add
7758         ATTRIBUTE_UNUSED_RESULT.
7759
7760 2019-03-05  Tom Tromey  <tromey@adacore.com>
7761
7762         * parser-defs.h (struct parser_state) <release>: Add
7763         ATTRIBUTE_UNUSED_RESULT.
7764
7765 2019-03-05  Tom Tromey  <tromey@adacore.com>
7766
7767         * utils.h (class gdb_argv) <release>: Add
7768         ATTRIBUTE_UNUSED_RESULT.
7769         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7770
7771 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7772
7773         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7774         for-loop range, to avoid compiler warnings.
7775
7776         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7777         avoid compiler warnings about unused variables.
7778
7779         * NEWS: Mention end of support for native debugging on MS-Windows
7780         before XP.
7781
7782         PR gdb/24292
7783         * common/netstuff.c:
7784         * gdbserver/gdbreplay.c
7785         * gdbserver/remote-utils.c:
7786         * ser-tcp.c:
7787         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7788         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7789         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7790         'getaddrinfo' and 'freeaddrinfo' were not available before
7791         Windows XP, and mingw.org's MinGW headers by default define
7792         _WIN32_WINNT to 0x500.
7793
7794 2019-03-01  Gary Benson <gbenson@redhat.com>
7795
7796         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7797
7798 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7799             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7800
7801         PR gdb/8527
7802         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7803         set_sigint_trap, clear_sigint_trap.
7804
7805 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7806
7807         * target.c (target_detach): Clear the regcache and the
7808         frame cache.
7809
7810 2019-02-27  Pedro Alves  <palves@redhat.com>
7811
7812         * utils.c (set_screen_size): When we cap the height/width sizes,
7813         tweak the corresponding command variable to show "unlimited":
7814
7815 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7816             Pedro Alves  <palves@redhat.com>
7817
7818         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7819         before calling rl_set_screen_size.
7820
7821 2019-02-27  Tom Tromey  <tromey@adacore.com>
7822
7823         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7824         define.
7825         * python/py-value.c: Remove Python 2.4 workaround.
7826         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7827         workaround.
7828         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7829         Python 2.4 workaround.
7830         * python/python-internal.h: Remove Python 2.4 comment.
7831         (Py_ssize_t): Don't define.
7832         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7833         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7834         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7835         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7836         * python/python.c (do_start_initialization): Remove Python 2.4
7837         workaround.
7838         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7839         (print_children): Remove Python 2.4 workaround.
7840         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7841         workaround.
7842         (CHARBUFFERPROC_NAME): Remove.
7843         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7844         Python 2.4 workaround.
7845
7846 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7847
7848         * NEWS: Note minimum Python version.
7849
7850 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7851
7852         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7853         code from these functions.  Remove corresponding ifdefs.  Use
7854         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7855         Remove gotos and target of gotos.
7856         (infpy_search_memory): Likewise.
7857
7858 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7859
7860         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7861         (hppa_gdbarch_init): Don't register deleted functions with
7862         gdbarch.
7863
7864 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7865
7866         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7867         (h8300_unwind_sp): Delete.
7868         (h8300_dummy_id): Delete.
7869         (h8300_gdbarch_init): Don't register deleted functions with
7870         gdbarch.
7871
7872 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7873
7874         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7875         (ft32_unwind_pc): Delete.
7876         (ft32_unwind_sp): Delete.
7877         (ft32_gdbarch_init): Don't register deleted functions with
7878         gdbarch.
7879
7880 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7881
7882         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7883         (frv_unwind_pc): Delete.
7884         (frv_unwind_sp): Delete.
7885         (frv_gdbarch_init): Don't register deleted functions with
7886         gdbarch.
7887
7888 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7889
7890         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7891         (riscv_unwind_pc): Delete.
7892         (riscv_unwind_sp): Delete.
7893         (riscv_gdbarch_init): Don't register deleted functions with
7894         gdbarch.
7895
7896 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7897
7898         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7899         (csky_unwind_pc): Delete.
7900         (csky_unwind_sp): Delete.
7901         (csky_gdbarch_init): Don't register deleted functions with
7902         gdbarch.
7903
7904 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7905
7906         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7907         (cris_unwind_pc): Delete.
7908         (cris_unwind_sp): Delete.
7909         (cris_gdbarch_init): Don't register deleted functions with
7910         gdbarch.
7911
7912 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7913
7914         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7915         (bfin_unwind_pc): Delete.
7916         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7917
7918 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7919
7920         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7921         (arm_unwind_pc): Delete.
7922         (arm_unwind_sp): Delete.
7923         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7924
7925 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7926
7927         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7928         (arc_unwind_pc): Delete.
7929         (arc_unwind_sp): Delete.
7930         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7931
7932 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7933
7934         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7935         (alpha_unwind_pc): Delete.
7936         (alpha_gdbarch_init): Don't register deleted functions with
7937         gdbarch.
7938
7939 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7940
7941         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7942         (aarch64_unwind_pc): Delete.
7943         (aarch64_unwind_sp): Delete.
7944         (aarch64_gdbarch_init): Don't register deleted functions with
7945         gdbarch.
7946
7947 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7948
7949         * gdbtypes.c (type_align): Don't consider static members when
7950         computing structure alignment.
7951
7952 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7953
7954         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7955         return 0 for other types.
7956         * arch-utils.c (default_type_align): Always return 0.
7957         * gdbarch.h: Regenerate.
7958         * gdbarch.sh (type_align): Extend comment.
7959         * gdbtypes.c (type_align): Add additional comments, always call
7960         gdbarch_type_align before applying the default rules.
7961         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7962         generic code will then apply a suitable default.
7963         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7964         types, return 0 for other types.
7965
7966 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7967
7968         * NEWS: Create a new section for the next release branch.
7969         Rename the section of the current branch, now that it has
7970         been cut.
7971
7972 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7973
7974         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7975         * version.in: Bump version to 8.3.50.DATE-git.
7976
7977 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7978
7979         * aix-thread.c (ptid_cmp): Remove unused variable.
7980         (get_signaled_thread): Likewise.
7981         (store_regs_user_thread): Likewise.
7982         (store_regs_kernel_thread): Likewise.
7983         (fetch_regs_kernel_thread): Remove shadowed variable.
7984
7985 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7986
7987         * features/riscv/32bit-cpu.xml: Add register numbers.
7988         * features/riscv/32bit-fpu.c: Regenerate.
7989         * features/riscv/32bit-fpu.xml: Add register numbers.
7990         * features/riscv/64bit-cpu.xml: Add register numbers.
7991         * features/riscv/64bit-fpu.c: Regenerate.
7992         * features/riscv/64bit-fpu.xml: Add register numbers.
7993
7994 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7995
7996         * NEWS: Mention two argument form of gdb.Value constructor.
7997         * python/py-value.c (convert_buffer_and_type_to_value): New
7998         function.
7999         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8000         Add support for handling an optional second argument.  Call
8001         convert_buffer_and_type_to_value as appropriate.
8002         * python/python-internal.h (Py_buffer_deleter): New struct.
8003         (Py_buffer_up): New typedef.
8004
8005 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8006
8007         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8008         instead of releasing ownership.
8009
8010 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8011
8012         * dwarf2read.c (open_and_init_dwp_file): Call
8013         elf_numsections instead of bfd_count_sections to initialize
8014         dwp_file->num_sections.
8015
8016 2019-02-25  Tom Tromey  <tromey@adacore.com>
8017
8018         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8019
8020 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8021
8022         * gcore.in: Add '--readnever' option when invoking GDB.
8023
8024 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8025
8026         * MAINTAINERS: Update my email address.
8027
8028 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8029
8030         * build-id.c (build_id_to_debug_bfd_1): New function.
8031         (build_id_to_debug_bfd): Look for separate debug file in
8032         sysroot.
8033
8034 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8035
8036         * gdbarch.sh: Update the copyright year range that is placed into
8037         generated files.
8038
8039 2019-02-22  Keith Seitz  <keiths@redhat.com>
8040
8041         PR symtab/23853
8042         * linespec.c (create_sals_line_offset): Search for the default
8043         symtab's filename instead of its fullname.
8044
8045 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8046
8047         * NEWS: Update style defaults.
8048
8049 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8050
8051         * main.c (captured_main_1): Disable styling in batch mode.
8052
8053 2019-02-20  Tom Tromey  <tom@tromey.com>
8054
8055         * symtab.c (symtab_symbol_info): Fix typos.
8056
8057 2019-02-20  Tom Tromey  <tromey@adacore.com>
8058
8059         * findcmd.c (_initialize_mem_search): Use upper case for
8060         metasyntactic variables.
8061
8062 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8063
8064         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8065         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8066
8067 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8068
8069         * top.h (source_file_name): Change to std::string.
8070         * top.c (source_file_name): Likewise.
8071         (command_line_input): Adjust.
8072         * cli/cli-script.c (script_from_file): Adjust.
8073
8074 2019-02-19  Tom Tromey  <tromey@adacore.com>
8075
8076         * ravenscar-thread.c
8077         (ravenscar_thread_target::update_thread_list): Don't call
8078         ada_build_task_list.
8079         * ada-lang.h (ada_build_task_list): Don't declare.
8080         * ada-tasks.c (struct ada_tasks_inferior_data)
8081         <task_list_valid_p>: Now bool.
8082         (read_known_tasks, ada_task_list_changed)
8083         (ada_tasks_invalidate_inferior_data): Update.
8084         (read_known_tasks_array): Return bool.
8085         (read_known_tasks_list): Likewise.
8086         (read_known_tasks): Return void.
8087         (ada_build_task_list): Now static.
8088
8089 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8090
8091         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8092         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8093
8094 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8095
8096         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8097         variant for ada_tasks_pspace_data_handle and
8098         ada_tasks_inferior_data_handle.
8099         (ada_tasks_pspace_data_cleanup): New function.
8100         (ada_tasks_inferior_data_cleanup): New function.
8101
8102 2019-02-17  Tom Tromey  <tom@tromey.com>
8103
8104         * macrotab.h (macro_source_fullname): Return a std::string.
8105         * macrotab.c (macro_include, check_for_redefinition)
8106         (macro_undef, macro_lookup_definition, foreach_macro)
8107         (foreach_macro_in_scope): Update.
8108         (macro_source_fullname): Return a std::string.
8109         * macrocmd.c (show_pp_source_pos): Update.
8110
8111 2019-02-17  Tom Tromey  <tom@tromey.com>
8112
8113         * macrocmd.c (show_pp_source_pos): Style the file names.
8114
8115 2019-02-17  Tom Tromey  <tom@tromey.com>
8116
8117         PR tui/24197:
8118         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8119
8120 2019-02-17  Tom Tromey  <tom@tromey.com>
8121
8122         * ada-lang.c (user_select_syms): Use filtered printing.
8123         * utils.c (wrap_style): New global.
8124         (desired_style): Remove.
8125         (emit_style_escape): Add stream parameter.
8126         (set_output_style, reset_terminal_style, prompt_for_continue):
8127         Update.
8128         (flush_wrap_buffer): Only flush gdb_stdout.
8129         (wrap_here): Set wrap_style.
8130         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8131         treat escape sequences as a character.  Change when wrap buffer is
8132         flushed.
8133         (fputs_styled): Do not set the output style when the default is
8134         requested.
8135         * ui-style.h (struct ui_file_style) <is_default>: New method.
8136         * source.c (print_source_lines_base): Emit escape sequences in one
8137         piece.
8138
8139 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8140
8141         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8142         integers and enumeration types.
8143
8144 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8145
8146         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8147         instead of lookup_symbol_in_language
8148         (do_exact_match): New function.
8149         (ada_get_symbol_name_matcher): Return do_exact_match when
8150         doing a verbatim match.
8151
8152 2019-02-15  Tom Tromey  <tromey@adacore.com>
8153
8154         * ravenscar-thread.c (ravenscar_thread_target::resume)
8155         (ravenscar_thread_target::wait): Special case wildcard requests.
8156
8157 2019-02-15  Tom Tromey  <tromey@adacore.com>
8158
8159         * ravenscar-thread.c (base_ptid): Remove.
8160         (struct ravenscar_thread_target) <close>: New method.
8161         <m_base_ptid>: New member.
8162         <update_inferior_ptid, active_task, task_is_currently_active,
8163         runtime_initialized>: Declare methods.
8164         <ravenscar_thread_target>: Add constructor.
8165         (ravenscar_thread_target::task_is_currently_active)
8166         (ravenscar_thread_target::update_inferior_ptid)
8167         (ravenscar_runtime_initialized): Rename.  Now methods.
8168         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8169         (ravenscar_thread_target::update_thread_list): Update.
8170         (ravenscar_thread_target::active_task): Now method.
8171         (ravenscar_thread_target::store_registers)
8172         (ravenscar_thread_target::prepare_to_store)
8173         (ravenscar_thread_target::prepare_to_store)
8174         (ravenscar_thread_target::mourn_inferior): Update.
8175         (ravenscar_inferior_created): Use "new" to create target.
8176         (ravenscar_thread_target::get_ada_task_ptid): Update.
8177         (_initialize_ravenscar): Don't initialize base_ptid.
8178         (ravenscar_ops): Remove global.
8179
8180 2019-02-15  Tom Tromey  <tromey@adacore.com>
8181
8182         * target.h (push_target): Declare new overload.
8183         * target.c (push_target): New overload, taking an rvalue reference.
8184         * remote.c (remote_target::open_1): Use push_target overload.
8185         * corelow.c (core_target_open): Use push_target overload.
8186
8187 2019-02-15  Tom Tromey  <tromey@adacore.com>
8188
8189         * ravenscar-thread.c (is_ravenscar_task)
8190         (ravenscar_task_is_currently_active): Return bool.
8191         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8192         (_initialize_ravenscar): Remove "(void)".
8193         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8194         Return bool.
8195
8196 2019-02-15  Tom Tromey  <tromey@adacore.com>
8197
8198         * ravenscar-thread.c (ravenscar_runtime_initializer)
8199         (has_ravenscar_runtime, get_running_thread_id)
8200         (ravenscar_thread_target::resume): Fix indentation.
8201
8202 2019-02-15  Tom Tromey  <tromey@adacore.com>
8203
8204         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8205         from ravenscar_arch_ops.
8206         (sparc_ravenscar_ops::fetch_registers)
8207         (sparc_ravenscar_ops::store_registers): Now methods.
8208         (sparc_ravenscar_prepare_to_store): Remove.
8209         (sparc_ravenscar_ops): Redefine.
8210         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8211         methods and destructor.  Remove members.
8212         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8213         (ravenscar_thread_target::store_registers)
8214         (ravenscar_thread_target::prepare_to_store): Update.
8215         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8216         Remove.
8217         (struct ppc_ravenscar_powerpc_ops): Derive from
8218         ravenscar_arch_ops.
8219         (ppc_ravenscar_powerpc_ops::fetch_registers)
8220         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8221         (ppc_ravenscar_powerpc_ops): Redefine.
8222         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8223         (ppc_ravenscar_e500_ops::fetch_registers)
8224         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8225         (ppc_ravenscar_e500_ops): Redefine.
8226         * aarch64-ravenscar-thread.c
8227         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8228         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8229         (aarch64_ravenscar_fetch_registers)
8230         (aarch64_ravenscar_store_registers): Now methods.
8231         (aarch64_ravenscar_ops): Redefine.
8232
8233 2019-02-15  Tom Tromey  <tromey@adacore.com>
8234
8235         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8236         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8237         (ravenscar_thread_target::stopped_by_watchpoint)
8238         (ravenscar_thread_target::stopped_data_address)
8239         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8240
8241 2019-02-15  Tom Tromey  <tromey@adacore.com>
8242
8243         * ravenscar-thread.c: Fix some typos.
8244
8245 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8246             Tom Tromey  <tromey@adacore.com>
8247
8248         * ada-lang.c (ada_exception_sal): Change addr_string to a
8249         std::string.
8250         (create_ada_exception_catchpoint): Update.
8251
8252 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8253             Tom Tromey  <tromey@adacore.com>
8254
8255         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8256         (bp_location_ops): Remove.
8257         (base_breakpoint_allocate_location): Update.
8258         (free_bp_location): Update.
8259         * ada-lang.c (class ada_catchpoint_location)
8260         <ada_catchpoint_location>: Remove ops parameter.
8261         (ada_catchpoint_location_dtor): Remove.
8262         (ada_catchpoint_location_ops): Remove.
8263         (allocate_location_exception): Update.
8264         * breakpoint.h (struct bp_location_ops): Remove.
8265         (class bp_location) <bp_location>: Remove bp_location_ops
8266         parameter.
8267         <~bp_location>: Add destructor.
8268         <ops>: Remove.
8269
8270 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8271             Pedro Alves  <palves@redhat.com>
8272
8273         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8274         'PATH_MAX'.
8275
8276 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8277             Samuel Thibault  <samuel.thibault@gnu.org>
8278             Thomas Schwinge  <thomas@codesourcery.com>
8279
8280         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8281         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8282
8283 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8284
8285         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8286         (check_empty): Use "const char *".
8287
8288         * gnu-nat.c (gnu_nat_target::detach): Instead of
8289         'detach_inferior (pid)' call
8290         'detach_inferior (find_inferior_pid (pid))'.
8291
8292         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8293         'nat/fork-inferior.o'.
8294         * gnu-nat.c: #include "nat/fork-inferior.h".
8295
8296         * gnu-nat.c (gnu_nat_target::detach): Instead of
8297         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8298         * gnu-nat.h: #include "inf-child.h".
8299         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8300         'i386_gnu_nat_target::fetch_registers'.
8301         (gnu_store_registers): Rename/move to
8302         'i386_gnu_nat_target::store_registers'.
8303
8304         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8305         * gnu-nat.h (mach_thread_info): New function.
8306         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8307
8308         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8309
8310 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8311
8312         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8313
8314 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8315
8316         * windows-nat.c (windows_add_thread): Add new parameter
8317         "main_thread_p" with default value set to false.  Update
8318         function documentation as well as all callers.
8319         (windows_delete_thread): Likewise.
8320         (fake_create_process): Update call to windows_add_thread.
8321         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8322         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8323         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8324         call to windows_delete_thread.
8325
8326 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8327
8328         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8329
8330 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8331
8332         * symfile.c (find_separate_debug_file): Use canonical path of
8333         sysroot with child_path instead of gdb_sysroot if it is valid.
8334
8335 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8336
8337         * symfile.c (find_separate_debug_file): Use child_path to
8338         determine if an object file is under a sysroot.
8339
8340 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8341
8342         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8343         unittests/child-path-selftests.c.
8344         * common/pathstuff.c (child_path): New function.
8345         * common/pathstuff.h (child_path): New prototype.
8346         * unittests/child-path-selftests.c: New file.
8347
8348 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8349
8350         * symfile.c (find_separate_debug_file): Look for separate debug
8351         files in debug directories under the sysroot.
8352
8353 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8354
8355         * symtab.h (struct minimal_symbol data_p): New const method.
8356         (struct minimal_symbol text_p): Likewise.
8357         * symtab.c (output_source_filename): Use file name style
8358         to print file name.
8359         (print_symbol_info): Likewise.
8360         (print_msymbol_info): Use address style to print addresses.
8361         Use function name style to print executable text symbols.
8362         (expand_symtab_containing_pc): Use data_p.
8363         (find_pc_sect_compunit_symtab): Likewise.
8364
8365 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8366
8367         * breakpoint.c (describe_other_breakpoints): Use address style
8368         to print addresses.
8369         (say_where): Likewise.
8370
8371 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8372
8373         * ada-typeprint.c (print_func_type): Print function name
8374         style to print function name.
8375         * c-typeprint.c (c_print_type_1): Likewise.
8376
8377 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8378
8379         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8380         for execve.
8381
8382 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8383
8384         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8385         type_stack.
8386
8387 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8388
8389         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8390         TYPE_CODE_REF types.
8391
8392 2019-02-08  Jim Wilson  <jimw@sifive.com>
8393
8394         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8395         (riscv_linux_fregset): New.
8396         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8397
8398 2019-02-07  Tom Tromey  <tom@tromey.com>
8399
8400         * thread.c (thread_cancel_execution_command): Update.
8401         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8402         methods.
8403         (struct thread_fsm_ops): Remove.
8404         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8405         (thread_fsm_should_stop, thread_fsm_return_value)
8406         (thread_fsm_set_finished, thread_fsm_finished_p)
8407         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8408         Don't declare.
8409         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8410         * infrun.c (clear_proceed_status_thread)
8411         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8412         (print_stop_event): Update.
8413         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8414         Add constructor.
8415         (step_command_fsm_ops): Remove.
8416         (new_step_command_fsm): Remove.
8417         (step_1): Update.
8418         (step_command_fsm::should_stop): Rename from
8419         step_command_fsm_should_stop.
8420         (step_command_fsm::clean_up): Rename from
8421         step_command_fsm_clean_up.
8422         (step_command_fsm::do_async_reply_reason): Rename from
8423         step_command_fsm_async_reply_reason.
8424         (struct until_next_fsm): Inherit from thread_fsm.  Add
8425         constructor.
8426         (until_next_fsm_ops): Remove.
8427         (new_until_next_fsm): Remove.
8428         (until_next_fsm::should_stop): Rename from
8429         until_next_fsm_should_stop.
8430         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8431         (until_next_fsm::do_async_reply_reason): Rename from
8432         until_next_fsm_async_reply_reason.
8433         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8434         constructor.  Change type of breakpoint.
8435         (finish_command_fsm_ops): Remove.
8436         (new_finish_command_fsm): Remove.
8437         (finish_command_fsm::should_stop): Rename from
8438         finish_command_fsm_should_stop.
8439         (finish_command_fsm::clean_up): Rename from
8440         finish_command_fsm_clean_up.
8441         (finish_command_fsm::return_value): Rename from
8442         finish_command_fsm_return_value.
8443         (finish_command_fsm::do_async_reply_reason): Rename from
8444         finish_command_fsm_async_reply_reason.
8445         (finish_command): Update.
8446         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8447         Add constructor.
8448         (call_thread_fsm_ops): Remove.
8449         (call_thread_fsm::call_thread_fsm): Rename from
8450         new_call_thread_fsm.
8451         (call_thread_fsm::should_stop): Rename from
8452         call_thread_fsm_should_stop.
8453         (call_thread_fsm::should_notify_stop): Rename from
8454         call_thread_fsm_should_notify_stop.
8455         (run_inferior_call, call_function_by_hand_dummy): Update.
8456         * cli/cli-interp.c (should_print_stop_to_console): Update.
8457         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8458         Add constructor.  Change type of location_breakpoint,
8459         caller_breakpoint.
8460         (until_break_fsm_ops): Remove.
8461         (new_until_break_fsm): Remove.
8462         (until_break_fsm::should_stop): Rename from
8463         until_break_fsm_should_stop.
8464         (until_break_fsm::clean_up): Rename from
8465         until_break_fsm_clean_up.
8466         (until_break_fsm::do_async_reply_reason): Rename from
8467         until_break_fsm_async_reply_reason.
8468         (until_break_command): Update.
8469         * thread-fsm.c: Remove.
8470         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8471
8472 2019-02-07  Tom Tromey  <tom@tromey.com>
8473
8474         * yy-remap.h: Add include guard.
8475         * xtensa-tdep.h: Add include guard.
8476         * xcoffread.h: Rename include guard.
8477         * varobj-iter.h: Add include guard.
8478         * tui/tui.h: Rename include guard.
8479         * tui/tui-winsource.h: Rename include guard.
8480         * tui/tui-wingeneral.h: Rename include guard.
8481         * tui/tui-windata.h: Rename include guard.
8482         * tui/tui-win.h: Rename include guard.
8483         * tui/tui-stack.h: Rename include guard.
8484         * tui/tui-source.h: Rename include guard.
8485         * tui/tui-regs.h: Rename include guard.
8486         * tui/tui-out.h: Rename include guard.
8487         * tui/tui-layout.h: Rename include guard.
8488         * tui/tui-io.h: Rename include guard.
8489         * tui/tui-hooks.h: Rename include guard.
8490         * tui/tui-file.h: Rename include guard.
8491         * tui/tui-disasm.h: Rename include guard.
8492         * tui/tui-data.h: Rename include guard.
8493         * tui/tui-command.h: Rename include guard.
8494         * tic6x-tdep.h: Add include guard.
8495         * target/waitstatus.h: Rename include guard.
8496         * target/wait.h: Rename include guard.
8497         * target/target.h: Rename include guard.
8498         * target/resume.h: Rename include guard.
8499         * target-float.h: Rename include guard.
8500         * stabsread.h: Add include guard.
8501         * rs6000-tdep.h: Add include guard.
8502         * riscv-fbsd-tdep.h: Add include guard.
8503         * regformats/regdef.h: Rename include guard.
8504         * record.h: Rename include guard.
8505         * python/python.h: Rename include guard.
8506         * python/python-internal.h: Rename include guard.
8507         * python/py-stopevent.h: Rename include guard.
8508         * python/py-ref.h: Rename include guard.
8509         * python/py-record.h: Rename include guard.
8510         * python/py-record-full.h: Rename include guard.
8511         * python/py-record-btrace.h: Rename include guard.
8512         * python/py-instruction.h: Rename include guard.
8513         * python/py-events.h: Rename include guard.
8514         * python/py-event.h: Rename include guard.
8515         * procfs.h: Add include guard.
8516         * proc-utils.h: Add include guard.
8517         * p-lang.h: Add include guard.
8518         * or1k-tdep.h: Rename include guard.
8519         * observable.h: Rename include guard.
8520         * nto-tdep.h: Rename include guard.
8521         * nat/x86-linux.h: Rename include guard.
8522         * nat/x86-linux-dregs.h: Rename include guard.
8523         * nat/x86-gcc-cpuid.h: Add include guard.
8524         * nat/x86-dregs.h: Rename include guard.
8525         * nat/x86-cpuid.h: Rename include guard.
8526         * nat/ppc-linux.h: Rename include guard.
8527         * nat/mips-linux-watch.h: Rename include guard.
8528         * nat/linux-waitpid.h: Rename include guard.
8529         * nat/linux-ptrace.h: Rename include guard.
8530         * nat/linux-procfs.h: Rename include guard.
8531         * nat/linux-osdata.h: Rename include guard.
8532         * nat/linux-nat.h: Rename include guard.
8533         * nat/linux-namespaces.h: Rename include guard.
8534         * nat/linux-btrace.h: Rename include guard.
8535         * nat/glibc_thread_db.h: Rename include guard.
8536         * nat/gdb_thread_db.h: Rename include guard.
8537         * nat/gdb_ptrace.h: Rename include guard.
8538         * nat/fork-inferior.h: Rename include guard.
8539         * nat/amd64-linux-siginfo.h: Rename include guard.
8540         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8541         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8542         * nat/aarch64-linux.h: Rename include guard.
8543         * nat/aarch64-linux-hw-point.h: Rename include guard.
8544         * mn10300-tdep.h: Add include guard.
8545         * mips-linux-tdep.h: Add include guard.
8546         * mi/mi-parse.h: Rename include guard.
8547         * mi/mi-out.h: Rename include guard.
8548         * mi/mi-main.h: Rename include guard.
8549         * mi/mi-interp.h: Rename include guard.
8550         * mi/mi-getopt.h: Rename include guard.
8551         * mi/mi-console.h: Rename include guard.
8552         * mi/mi-common.h: Rename include guard.
8553         * mi/mi-cmds.h: Rename include guard.
8554         * mi/mi-cmd-break.h: Rename include guard.
8555         * m2-lang.h: Add include guard.
8556         * location.h: Rename include guard.
8557         * linux-record.h: Rename include guard.
8558         * linux-nat.h: Add include guard.
8559         * linux-fork.h: Add include guard.
8560         * i386-darwin-tdep.h: Rename include guard.
8561         * hppa-linux-offsets.h: Add include guard.
8562         * guile/guile.h: Rename include guard.
8563         * guile/guile-internal.h: Rename include guard.
8564         * gnu-nat.h: Rename include guard.
8565         * gdb-stabs.h: Rename include guard.
8566         * frv-tdep.h: Add include guard.
8567         * f-lang.h: Add include guard.
8568         * event-loop.h: Add include guard.
8569         * darwin-nat.h: Rename include guard.
8570         * cp-abi.h: Rename include guard.
8571         * config/sparc/nm-sol2.h: Rename include guard.
8572         * config/nm-nto.h: Rename include guard.
8573         * config/nm-linux.h: Add include guard.
8574         * config/i386/nm-i386gnu.h: Rename include guard.
8575         * config/djgpp/nl_types.h: Rename include guard.
8576         * config/djgpp/langinfo.h: Rename include guard.
8577         * compile/gcc-cp-plugin.h: Add include guard.
8578         * compile/gcc-c-plugin.h: Add include guard.
8579         * compile/compile.h: Rename include guard.
8580         * compile/compile-object-run.h: Rename include guard.
8581         * compile/compile-object-load.h: Rename include guard.
8582         * compile/compile-internal.h: Rename include guard.
8583         * compile/compile-cplus.h: Rename include guard.
8584         * compile/compile-c.h: Rename include guard.
8585         * common/xml-utils.h: Rename include guard.
8586         * common/x86-xstate.h: Rename include guard.
8587         * common/version.h: Rename include guard.
8588         * common/vec.h: Rename include guard.
8589         * common/tdesc.h: Rename include guard.
8590         * common/selftest.h: Rename include guard.
8591         * common/scoped_restore.h: Rename include guard.
8592         * common/scoped_mmap.h: Rename include guard.
8593         * common/scoped_fd.h: Rename include guard.
8594         * common/safe-iterator.h: Rename include guard.
8595         * common/run-time-clock.h: Rename include guard.
8596         * common/refcounted-object.h: Rename include guard.
8597         * common/queue.h: Rename include guard.
8598         * common/ptid.h: Rename include guard.
8599         * common/print-utils.h: Rename include guard.
8600         * common/preprocessor.h: Rename include guard.
8601         * common/pathstuff.h: Rename include guard.
8602         * common/observable.h: Rename include guard.
8603         * common/netstuff.h: Rename include guard.
8604         * common/job-control.h: Rename include guard.
8605         * common/host-defs.h: Rename include guard.
8606         * common/gdb_wait.h: Rename include guard.
8607         * common/gdb_vecs.h: Rename include guard.
8608         * common/gdb_unlinker.h: Rename include guard.
8609         * common/gdb_unique_ptr.h: Rename include guard.
8610         * common/gdb_tilde_expand.h: Rename include guard.
8611         * common/gdb_sys_time.h: Rename include guard.
8612         * common/gdb_string_view.h: Rename include guard.
8613         * common/gdb_splay_tree.h: Rename include guard.
8614         * common/gdb_setjmp.h: Rename include guard.
8615         * common/gdb_ref_ptr.h: Rename include guard.
8616         * common/gdb_optional.h: Rename include guard.
8617         * common/gdb_locale.h: Rename include guard.
8618         * common/gdb_assert.h: Rename include guard.
8619         * common/filtered-iterator.h: Rename include guard.
8620         * common/filestuff.h: Rename include guard.
8621         * common/fileio.h: Rename include guard.
8622         * common/environ.h: Rename include guard.
8623         * common/common-utils.h: Rename include guard.
8624         * common/common-types.h: Rename include guard.
8625         * common/common-regcache.h: Rename include guard.
8626         * common/common-inferior.h: Rename include guard.
8627         * common/common-gdbthread.h: Rename include guard.
8628         * common/common-exceptions.h: Rename include guard.
8629         * common/common-defs.h: Rename include guard.
8630         * common/common-debug.h: Rename include guard.
8631         * common/cleanups.h: Rename include guard.
8632         * common/buffer.h: Rename include guard.
8633         * common/btrace-common.h: Rename include guard.
8634         * common/break-common.h: Rename include guard.
8635         * cli/cli-utils.h: Rename include guard.
8636         * cli/cli-style.h: Rename include guard.
8637         * cli/cli-setshow.h: Rename include guard.
8638         * cli/cli-script.h: Rename include guard.
8639         * cli/cli-interp.h: Rename include guard.
8640         * cli/cli-decode.h: Rename include guard.
8641         * cli/cli-cmds.h: Rename include guard.
8642         * charset-list.h: Add include guard.
8643         * buildsym-legacy.h: Rename include guard.
8644         * bfin-tdep.h: Add include guard.
8645         * ax.h: Rename include guard.
8646         * arm-linux-tdep.h: Add include guard.
8647         * arm-fbsd-tdep.h: Add include guard.
8648         * arch/xtensa.h: Rename include guard.
8649         * arch/tic6x.h: Add include guard.
8650         * arch/i386.h: Add include guard.
8651         * arch/arm.h: Rename include guard.
8652         * arch/arm-linux.h: Rename include guard.
8653         * arch/arm-get-next-pcs.h: Rename include guard.
8654         * arch/amd64.h: Add include guard.
8655         * arch/aarch64-insn.h: Rename include guard.
8656         * arch-utils.h: Rename include guard.
8657         * annotate.h: Add include guard.
8658         * amd64-darwin-tdep.h: Rename include guard.
8659         * aarch64-linux-tdep.h: Add include guard.
8660         * aarch64-fbsd-tdep.h: Add include guard.
8661         * aarch32-linux-nat.h: Add include guard.
8662
8663 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8664
8665         * macrotab.c (macro_define_internal): New function that
8666         factorizes macro_define_object_internal and macro_define_function
8667         code.
8668         (macro_define_object_internal): Use macro_define_internal.
8669         (macro_define_function): Likewise.
8670
8671 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8672
8673         * macrocmd.c (extract_identifier): Return
8674         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8675         callers.
8676
8677 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8678
8679         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8680
8681 2019-02-05  Tom Tromey  <tom@tromey.com>
8682
8683         * target.c (target_stack::unpush): Move assertion earlier.
8684
8685 2019-01-30  Tom Tromey  <tom@tromey.com>
8686
8687         PR python/23615:
8688         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8689         (gdbpy_parse_and_eval): Likewise.
8690         * python/python-internal.h (gdbpy_allow_threads): New class.
8691
8692 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8693
8694         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8695         (aarch64_fbsd_fpregmap): Move earlier.
8696         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8697         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8698         instead of individual calls to trad_frame_set_reg_addr.
8699         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8700         earlier.
8701         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8702         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8703         instead of individual calls to trad_frame_set_reg_addr.
8704
8705 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8706
8707         * CONTRIBUTE: Replace contribution list with wiki link.
8708
8709 2019-01-25  Tom Tromey  <tom@tromey.com>
8710
8711         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8712
8713 2019-01-25  Tom Tromey  <tom@tromey.com>
8714
8715         * xtensa-linux-nat.c: Fix common/ includes.
8716         * xml-support.h: Fix common/ includes.
8717         * xml-support.c: Fix common/ includes.
8718         * x86-linux-nat.c: Fix common/ includes.
8719         * windows-nat.c: Fix common/ includes.
8720         * varobj.h: Fix common/ includes.
8721         * varobj.c: Fix common/ includes.
8722         * value.c: Fix common/ includes.
8723         * valops.c: Fix common/ includes.
8724         * utils.c: Fix common/ includes.
8725         * unittests/xml-utils-selftests.c: Fix common/ includes.
8726         * unittests/utils-selftests.c: Fix common/ includes.
8727         * unittests/unpack-selftests.c: Fix common/ includes.
8728         * unittests/tracepoint-selftests.c: Fix common/ includes.
8729         * unittests/style-selftests.c: Fix common/ includes.
8730         * unittests/string_view-selftests.c: Fix common/ includes.
8731         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8732         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8733         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8734         * unittests/rsp-low-selftests.c: Fix common/ includes.
8735         * unittests/parse-connection-spec-selftests.c: Fix common/
8736         includes.
8737         * unittests/optional-selftests.c: Fix common/ includes.
8738         * unittests/offset-type-selftests.c: Fix common/ includes.
8739         * unittests/observable-selftests.c: Fix common/ includes.
8740         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8741         * unittests/memrange-selftests.c: Fix common/ includes.
8742         * unittests/memory-map-selftests.c: Fix common/ includes.
8743         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8744         * unittests/function-view-selftests.c: Fix common/ includes.
8745         * unittests/environ-selftests.c: Fix common/ includes.
8746         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8747         * unittests/common-utils-selftests.c: Fix common/ includes.
8748         * unittests/cli-utils-selftests.c: Fix common/ includes.
8749         * unittests/array-view-selftests.c: Fix common/ includes.
8750         * ui-file.c: Fix common/ includes.
8751         * tui/tui-io.c: Fix common/ includes.
8752         * tracepoint.h: Fix common/ includes.
8753         * tracepoint.c: Fix common/ includes.
8754         * tracefile-tfile.c: Fix common/ includes.
8755         * top.h: Fix common/ includes.
8756         * top.c: Fix common/ includes.
8757         * thread.c: Fix common/ includes.
8758         * target/waitstatus.h: Fix common/ includes.
8759         * target/waitstatus.c: Fix common/ includes.
8760         * target.h: Fix common/ includes.
8761         * target.c: Fix common/ includes.
8762         * target-memory.c: Fix common/ includes.
8763         * target-descriptions.c: Fix common/ includes.
8764         * symtab.h: Fix common/ includes.
8765         * symfile.c: Fix common/ includes.
8766         * stap-probe.c: Fix common/ includes.
8767         * spu-linux-nat.c: Fix common/ includes.
8768         * sparc-nat.c: Fix common/ includes.
8769         * source.c: Fix common/ includes.
8770         * solib.c: Fix common/ includes.
8771         * solib-target.c: Fix common/ includes.
8772         * ser-unix.c: Fix common/ includes.
8773         * ser-tcp.c: Fix common/ includes.
8774         * ser-pipe.c: Fix common/ includes.
8775         * ser-base.c: Fix common/ includes.
8776         * selftest-arch.c: Fix common/ includes.
8777         * s12z-tdep.c: Fix common/ includes.
8778         * rust-exp.y: Fix common/ includes.
8779         * rs6000-aix-tdep.c: Fix common/ includes.
8780         * riscv-tdep.c: Fix common/ includes.
8781         * remote.c: Fix common/ includes.
8782         * remote-notif.h: Fix common/ includes.
8783         * remote-fileio.h: Fix common/ includes.
8784         * remote-fileio.c: Fix common/ includes.
8785         * regcache.h: Fix common/ includes.
8786         * regcache.c: Fix common/ includes.
8787         * record-btrace.c: Fix common/ includes.
8788         * python/python.c: Fix common/ includes.
8789         * python/py-type.c: Fix common/ includes.
8790         * python/py-inferior.c: Fix common/ includes.
8791         * progspace.h: Fix common/ includes.
8792         * producer.c: Fix common/ includes.
8793         * procfs.c: Fix common/ includes.
8794         * proc-api.c: Fix common/ includes.
8795         * printcmd.c: Fix common/ includes.
8796         * ppc-linux-nat.c: Fix common/ includes.
8797         * parser-defs.h: Fix common/ includes.
8798         * osdata.c: Fix common/ includes.
8799         * obsd-nat.c: Fix common/ includes.
8800         * nat/x86-linux.c: Fix common/ includes.
8801         * nat/x86-linux-dregs.c: Fix common/ includes.
8802         * nat/x86-dregs.h: Fix common/ includes.
8803         * nat/x86-dregs.c: Fix common/ includes.
8804         * nat/ppc-linux.c: Fix common/ includes.
8805         * nat/mips-linux-watch.h: Fix common/ includes.
8806         * nat/mips-linux-watch.c: Fix common/ includes.
8807         * nat/linux-waitpid.c: Fix common/ includes.
8808         * nat/linux-ptrace.h: Fix common/ includes.
8809         * nat/linux-ptrace.c: Fix common/ includes.
8810         * nat/linux-procfs.c: Fix common/ includes.
8811         * nat/linux-personality.c: Fix common/ includes.
8812         * nat/linux-osdata.c: Fix common/ includes.
8813         * nat/linux-namespaces.c: Fix common/ includes.
8814         * nat/linux-btrace.h: Fix common/ includes.
8815         * nat/linux-btrace.c: Fix common/ includes.
8816         * nat/fork-inferior.c: Fix common/ includes.
8817         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8818         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8819         * nat/aarch64-linux.c: Fix common/ includes.
8820         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8821         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8822         * namespace.h: Fix common/ includes.
8823         * mips-linux-tdep.c: Fix common/ includes.
8824         * minsyms.c: Fix common/ includes.
8825         * mi/mi-parse.h: Fix common/ includes.
8826         * mi/mi-main.c: Fix common/ includes.
8827         * mi/mi-cmd-env.c: Fix common/ includes.
8828         * memrange.h: Fix common/ includes.
8829         * memattr.c: Fix common/ includes.
8830         * maint.h: Fix common/ includes.
8831         * maint.c: Fix common/ includes.
8832         * main.c: Fix common/ includes.
8833         * machoread.c: Fix common/ includes.
8834         * location.c: Fix common/ includes.
8835         * linux-thread-db.c: Fix common/ includes.
8836         * linux-nat.c: Fix common/ includes.
8837         * linux-fork.c: Fix common/ includes.
8838         * inline-frame.c: Fix common/ includes.
8839         * infrun.c: Fix common/ includes.
8840         * inflow.c: Fix common/ includes.
8841         * inferior.h: Fix common/ includes.
8842         * inferior.c: Fix common/ includes.
8843         * infcmd.c: Fix common/ includes.
8844         * inf-ptrace.c: Fix common/ includes.
8845         * inf-child.c: Fix common/ includes.
8846         * ia64-linux-nat.c: Fix common/ includes.
8847         * i387-tdep.c: Fix common/ includes.
8848         * i386-tdep.c: Fix common/ includes.
8849         * i386-linux-tdep.c: Fix common/ includes.
8850         * i386-linux-nat.c: Fix common/ includes.
8851         * i386-go32-tdep.c: Fix common/ includes.
8852         * i386-fbsd-tdep.c: Fix common/ includes.
8853         * i386-fbsd-nat.c: Fix common/ includes.
8854         * guile/scm-type.c: Fix common/ includes.
8855         * guile/guile.c: Fix common/ includes.
8856         * go32-nat.c: Fix common/ includes.
8857         * gnu-nat.c: Fix common/ includes.
8858         * gdbthread.h: Fix common/ includes.
8859         * gdbarch-selftests.c: Fix common/ includes.
8860         * gdb_usleep.c: Fix common/ includes.
8861         * gdb_select.h: Fix common/ includes.
8862         * gdb_bfd.c: Fix common/ includes.
8863         * gcore.c: Fix common/ includes.
8864         * fork-child.c: Fix common/ includes.
8865         * findvar.c: Fix common/ includes.
8866         * fbsd-nat.c: Fix common/ includes.
8867         * event-top.c: Fix common/ includes.
8868         * event-loop.c: Fix common/ includes.
8869         * dwarf2read.c: Fix common/ includes.
8870         * dwarf2loc.c: Fix common/ includes.
8871         * dwarf2-frame.c: Fix common/ includes.
8872         * dwarf-index-cache.c: Fix common/ includes.
8873         * dtrace-probe.c: Fix common/ includes.
8874         * disasm-selftests.c: Fix common/ includes.
8875         * defs.h: Fix common/ includes.
8876         * csky-tdep.c: Fix common/ includes.
8877         * cp-valprint.c: Fix common/ includes.
8878         * cp-support.h: Fix common/ includes.
8879         * cp-support.c: Fix common/ includes.
8880         * corelow.c: Fix common/ includes.
8881         * completer.h: Fix common/ includes.
8882         * completer.c: Fix common/ includes.
8883         * compile/compile.c: Fix common/ includes.
8884         * compile/compile-loc2c.c: Fix common/ includes.
8885         * compile/compile-cplus-types.c: Fix common/ includes.
8886         * compile/compile-cplus-symbols.c: Fix common/ includes.
8887         * command.h: Fix common/ includes.
8888         * cli/cli-dump.c: Fix common/ includes.
8889         * cli/cli-cmds.c: Fix common/ includes.
8890         * charset.c: Fix common/ includes.
8891         * build-id.c: Fix common/ includes.
8892         * btrace.h: Fix common/ includes.
8893         * btrace.c: Fix common/ includes.
8894         * breakpoint.h: Fix common/ includes.
8895         * breakpoint.c: Fix common/ includes.
8896         * ax.h:
8897         (enum agent_op): Fix common/ includes.
8898         * ax-general.c (struct aop_map): Fix common/ includes.
8899         * ax-gdb.c: Fix common/ includes.
8900         * auxv.c: Fix common/ includes.
8901         * auto-load.c: Fix common/ includes.
8902         * arm-tdep.c: Fix common/ includes.
8903         * arch/riscv.c: Fix common/ includes.
8904         * arch/ppc-linux-common.c: Fix common/ includes.
8905         * arch/i386.c: Fix common/ includes.
8906         * arch/arm.c: Fix common/ includes.
8907         * arch/arm-linux.c: Fix common/ includes.
8908         * arch/arm-get-next-pcs.c: Fix common/ includes.
8909         * arch/amd64.c: Fix common/ includes.
8910         * arch/aarch64.c: Fix common/ includes.
8911         * arch/aarch64-insn.c: Fix common/ includes.
8912         * arch-utils.c: Fix common/ includes.
8913         * amd64-windows-tdep.c: Fix common/ includes.
8914         * amd64-tdep.c: Fix common/ includes.
8915         * amd64-sol2-tdep.c: Fix common/ includes.
8916         * amd64-obsd-tdep.c: Fix common/ includes.
8917         * amd64-nbsd-tdep.c: Fix common/ includes.
8918         * amd64-linux-tdep.c: Fix common/ includes.
8919         * amd64-linux-nat.c: Fix common/ includes.
8920         * amd64-fbsd-tdep.c: Fix common/ includes.
8921         * amd64-fbsd-nat.c: Fix common/ includes.
8922         * amd64-dicos-tdep.c: Fix common/ includes.
8923         * amd64-darwin-tdep.c: Fix common/ includes.
8924         * agent.c: Fix common/ includes.
8925         * ada-lang.h: Fix common/ includes.
8926         * ada-lang.c: Fix common/ includes.
8927         * aarch64-tdep.c: Fix common/ includes.
8928
8929 2019-01-25  Tom Tromey  <tom@tromey.com>
8930
8931         * common/create-version.sh: Use common/version.h.
8932
8933 2019-01-24  Pedro Alves  <palves@redhat.com>
8934
8935         * infrun.c (signal_stop, signal_print, signal_program)
8936         (signal_catch, signal_pass): Now arrays instead of pointers.
8937         (update_signals_program_target, do_target_resume)
8938         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8939         * linux-nat.c (linux_nat_target::pass_signals)
8940         (linux_nat_target::create_inferior, linux_nat_target::attach):
8941         Adjust.
8942         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8943         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8944         * procfs.c (procfs_target::pass_signals): Adjust.
8945         * record-full.c (record_full_target::resume): Adjust.
8946         * remote.c (remote_target::pass_signals)
8947         (remote_target::program_signals): Adjust.
8948         * target-debug.h (target_debug_print_signals): Now takes a
8949         gdb::array_view as parameter.  Adjust.
8950         * target.h (target_ops) <pass_signals, program_signals>: Replace
8951         pointer and length parameters with gdb::array_view.
8952         (target_pass_signals, target_program_signals): Likewise.
8953         * target-delegates.c: Regenerate.
8954
8955 2019-01-24  Pedro Alves  <palves@redhat.com>
8956
8957         * common/forward-scope-exit.h
8958         (forward_scope_exit::forward_scope_exit): Pass arguments to
8959         m_bind_function directly, instead of creating a std::bind and
8960         copying that.
8961
8962 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8963
8964         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8965         for static members.
8966         (pass_in_v_vfp_candidate): Likewise.
8967
8968 2019-01-23  Tom Tromey  <tom@tromey.com>
8969             Pedro Alves  <palves@redhat.com>
8970
8971         * regcache.c (class regcache_invalidator): Remove.
8972         (regcache::raw_write): Use make_scope_exit.
8973
8974 2019-01-23  Tom Tromey  <tom@tromey.com>
8975
8976         * ui-out.h (class ui_out_emit_type): Update comment.
8977
8978 2019-01-23  Tom Tromey  <tom@tromey.com>
8979
8980         * infrun.c (fetch_inferior_event): Update comment.
8981
8982 2019-01-23  Tom Tromey  <tom@tromey.com>
8983             Pedro Alves  <palves@redhat.com>
8984
8985         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8986         parameter.
8987         (fetch_inferior_event): Use SCOPE_EXIT.
8988
8989
8990 2019-01-23  Tom Tromey  <tom@tromey.com>
8991             Pedro Alves  <palves@redhat.com>
8992
8993         * infrun.c (disable_thread_events): Delete.
8994         (stop_all_threads): Use SCOPE_EXIT.
8995
8996 2019-01-23  Tom Tromey  <tom@tromey.com>
8997             Pedro Alves  <palves@redhat.com>
8998
8999         * symfile.c: Include forward-scope-exit.h.
9000         (clear_symtab_users_cleanup): Replace forward declaration with
9001         a FORWARD_SCOPE_EXIT.
9002         (syms_from_objfile_1): Use the forward_scope_exit and
9003         gdb::optional instead of cleanup_function.
9004         (reread_symbols): Use the forward_scope_exit instead of
9005         cleanup_function.
9006         (clear_symtab_users_cleanup): Remove function.
9007
9008 2019-01-23  Tom Tromey  <tom@tromey.com>
9009             Pedro Alves  <palves@redhat.com>
9010
9011         * linux-nat.c: Include scope-exit.h.
9012         (cleanup_target_stop): Remove.
9013         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9014         SCOPE_EXIT.
9015
9016 2019-01-23  Tom Tromey  <tom@tromey.com>
9017             Pedro Alves  <palves@redhat.com>
9018
9019         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9020         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9021
9022 2019-01-23  Tom Tromey  <tom@tromey.com>
9023             Andrew Burgess  <andrew.burgess@embecosm.com>
9024             Pedro Alves  <palves@redhat.com>
9025
9026         * infrun.c (fetch_inferior_event): Use scope_exit.
9027         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9028         * top.c (execute_command): Use scope_exit.
9029         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9030         * utils.c (do_bpstat_clear_actions_cleanup)
9031         (make_bpstat_clear_actions_cleanup): Remove.
9032
9033 2019-01-23  Tom Tromey  <tom@tromey.com>
9034             Pedro Alves  <palves@redhat.com>
9035
9036         * infrun.c: Include "common/scope-exit.h"
9037         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9038         (wait_for_inferior): Use SCOPE_EXIT.
9039         (fetch_inferior_event): Use scope_exit.
9040
9041 2019-01-23  Tom Tromey  <tom@tromey.com>
9042             Pedro Alves  <palves@redhat.com>
9043
9044         * breakpoint.c (create_breakpoint): Remove cleanup.
9045
9046 2019-01-23  Tom Tromey  <tom@tromey.com>
9047             Andrew Burgess  <andrew.burgess@embecosm.com>
9048             Pedro Alves  <palves@redhat.com>
9049
9050 2019-01-23  Pedro Alves  <palves@redhat.com>
9051
9052         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9053
9054 2019-01-23  Pedro Alves  <palves@redhat.com>
9055             Andrew Burgess  <andrew.burgess@embecosm.com>
9056
9057         * gdbthread.h: Include "common/forward-scope-exit.h".
9058         (scoped_finish_thread_state): Redefine custom class in terms of
9059         forward_scope_exit.
9060
9061 2019-01-23  Pedro Alves  <palves@redhat.com>
9062             Andrew Burgess  <andrew.burgess@embecosm.com>
9063
9064         * common/forward-scope-exit.h: New file.
9065
9066 2019-01-23  Pedro Alves  <palves@redhat.com>
9067             Andrew Burgess  <andrew.burgess@embecosm.com>
9068             Tom Tromey  <tom@tromey.com>
9069
9070         * common/scope-exit.h: New file.
9071
9072 2019-01-23  Pedro Alves  <palves@redhat.com>
9073
9074         * common/preprocessor.h (ESC): Rename to ...
9075         (ESC_PARENS): ... this.
9076         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9077         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9078
9079 2019-01-23  Tom Tromey  <tom@tromey.com>
9080
9081         * language.h (class scoped_switch_to_sym_language_if_auto):
9082         Initialize m_lang in both cases.
9083
9084 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9085
9086         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9087         with XCNEW.
9088
9089 2019-01-22  Tom Tromey  <tom@tromey.com>
9090
9091         * corelow.c: Do not include sys/file.h.
9092
9093 2019-01-22  Tom Tromey  <tom@tromey.com>
9094
9095         * tui/tui-wingeneral.h: Include gdb_curses.h.
9096
9097 2019-01-22  Tom Tromey  <tom@tromey.com>
9098
9099         * source-cache.h (class source_cache) <get_source_lines,
9100         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9101
9102 2019-01-22  Tom Tromey  <tom@tromey.com>
9103
9104         * remote-fileio.h (struct remote_target): Declare.
9105
9106 2019-01-22  Tom Tromey  <tom@tromey.com>
9107
9108         * python/py-arch.c: Do not include py-ref.h.
9109         * python/py-bpevent.c: Do not include py-ref.h.
9110         * python/py-cmd.c: Do not include py-ref.h.
9111         * python/py-continueevent.c: Do not include py-ref.h.
9112         * python/py-event.h: Do not include py-ref.h.
9113         * python/py-evtregistry.c: Do not include py-ref.h.
9114         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9115         * python/py-frame.c: Do not include py-ref.h.
9116         * python/py-framefilter.c: Do not include py-ref.h.
9117         * python/py-function.c: Do not include py-ref.h.
9118         * python/py-infevents.c: Do not include py-ref.h.
9119         * python/py-linetable.c: Do not include py-ref.h.
9120         * python/py-objfile.c: Do not include py-ref.h.
9121         * python/py-param.c: Do not include py-ref.h.
9122         * python/py-prettyprint.c: Do not include py-ref.h.
9123         * python/py-progspace.c: Do not include py-ref.h.
9124         * python/py-symbol.c: Do not include py-ref.h.
9125         * python/py-symtab.c: Do not include py-ref.h.
9126         * python/py-type.c: Do not include py-ref.h.
9127         * python/py-unwind.c: Do not include py-ref.h.
9128         * python/py-utils.c: Do not include py-ref.h.
9129         * python/py-value.c: Do not include py-ref.h.
9130         * python/py-varobj.c: Do not include py-ref.h.
9131         * python/py-xmethods.c: Do not include py-ref.h.
9132         * python/python.c: Do not include py-ref.h.
9133         * varobj.c: Do not include py-ref.h.
9134
9135 2019-01-22  Tom Tromey  <tom@tromey.com>
9136
9137         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9138         keyword for bcache.
9139
9140 2019-01-22  Tom Tromey  <tom@tromey.com>
9141
9142         * compile/compile-cplus-types.c: Remove a comment by #include.
9143
9144 2019-01-22  Tom Tromey  <tom@tromey.com>
9145
9146         * compile/gcc-c-plugin.h: Include compile-internal.h.
9147
9148 2019-01-22  Tom Tromey  <tom@tromey.com>
9149
9150         * stabsread.c (EXTERN): Do not define.
9151         (symnum, next_symbol_text_func, processing_gcc_compilation)
9152         (within_function, global_sym_chain, global_stabs)
9153         (previous_stab_code, this_object_header_files)
9154         (n_this_object_header_files)
9155         (n_allocated_this_object_header_files): Define.
9156         * stabsread.h (EXTERN): Never define.  Use "extern".
9157
9158 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9159
9160         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9161         history_value.
9162
9163 2019-01-21  Tom Tromey  <tom@tromey.com>
9164
9165         * ui-out.c: Fix includes.
9166         * tui/tui-source.c: Fix includes.
9167         * target.c: Fix includes.
9168         * remote.c: Fix includes.
9169         * regcache.c: Fix includes.
9170         * python/py-block.c: Fix includes.
9171         * printcmd.c: Fix includes.
9172         * or1k-tdep.c: Fix includes.
9173         * mi/mi-main.c: Fix includes.
9174         * m32r-tdep.c: Fix includes.
9175         * csky-tdep.c: Fix includes.
9176         * compile/compile-cplus-types.c: Fix includes.
9177         * cli/cli-interp.c: Fix includes.
9178
9179 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9180
9181         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9182         for padding.
9183
9184 2019-01-16  Tom Tromey  <tom@tromey.com>
9185
9186         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9187         earlier.
9188         (struct objfile) <msymbols_range>: Move from top level.
9189         <msymbols>: New method.
9190         (class objfile_msymbols): Remove.
9191         * symtab.c (default_collect_symbol_completion_matches_break_on):
9192         Update.
9193         * symmisc.c (dump_msymbols): Update.
9194         * stabsread.c (scan_file_globals): Update.
9195         * objc-lang.c (info_selectors_command, info_classes_command)
9196         (find_methods): Update.
9197         * minsyms.c (find_solib_trampoline_target): Update.
9198         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9199         * coffread.c (coff_symfile_read): Update.
9200         * ada-lang.c (ada_lookup_simple_minsym)
9201         (ada_collect_symbol_completion_matches): Update.
9202
9203 2019-01-16  Tom Tromey  <tom@tromey.com>
9204
9205         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9206         type.  Remove no-argument constructor.
9207         <iterator::operator++>: Simplify.
9208         <begin>: Update.
9209         <end>: Use minimal_symbol_count.
9210
9211 2019-01-16  Tom Tromey  <tom@tromey.com>
9212
9213         * objfiles.h (struct objfile) <psymtabs>: New method.
9214         (class objfile_psymtabs): Remove.
9215         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9216         typedef.
9217         <range>: New method.
9218         (require_partial_symbols): Change return type.
9219         * psymtab.c (require_partial_symbols)
9220         (psym_expand_symtabs_matching): Update.
9221         * mdebugread.c (parse_partial_symbols): Update.
9222         * dbxread.c (dbx_end_psymtab): Update.
9223
9224 2019-01-15  Tom Tromey  <tom@tromey.com>
9225
9226         * symtab.c (lookup_objfile_from_block)
9227         (lookup_symbol_in_objfile_symtabs)
9228         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9229         (find_line_symtab, info_sources_command)
9230         (default_collect_symbol_completion_matches_break_on)
9231         (make_source_files_completion_list): Update.
9232         * symmisc.c (print_objfile_statistics, dump_objfile)
9233         (maintenance_print_symbols, maintenance_info_symtabs)
9234         (maintenance_check_symtabs, maintenance_info_line_tables):
9235         Update.
9236         * source.c (select_source_symtab)
9237         (forget_cached_source_info_for_objfile): Update.
9238         * objfiles.h (class objfile_compunits): Remove.
9239         (struct objfile) <compunits_range>: New typedef.
9240         (compunits): New method.
9241         * objfiles.c (objfile_relocate1): Update.
9242         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9243         * maint.c (count_symtabs_and_blocks): Update.
9244         * linespec.c (iterate_over_all_matching_symtabs): Update.
9245         * cp-support.c (add_symbol_overload_list_qualified): Update.
9246         * coffread.c (coff_symtab_read): Update.
9247         * ada-lang.c (add_nonlocal_symbols)
9248         (ada_collect_symbol_completion_matches)
9249         (ada_add_global_exceptions): Update.
9250
9251 2019-01-15  Tom Tromey  <tom@tromey.com>
9252
9253         * progspace.h (program_space) <objfiles_safe_range>: New
9254         typedef.
9255         <objfiles_safe>: New method.
9256         * objfiles.h (class all_objfiles_safe): Remove.
9257         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9258         * jit.c (jit_inferior_exit_hook): Update.
9259
9260 2019-01-17  Tom Tromey  <tom@tromey.com>
9261
9262         * progspace.h (program_space) <objfiles_range>: New typedef.
9263         <objfiles>: New method.
9264         <objfiles_head>: Rename from objfiles.
9265         (object_files): Update.
9266         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9267         * guile/scm-pretty-print.c
9268         (ppscm_find_pretty_printer_from_objfiles): Update.
9269         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9270         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9271         Update.
9272         * python/py-progspace.c (pspy_get_objfiles): Update.
9273         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9274         Update.
9275         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9276         (objfpy_lookup_objfile_by_build_id): Update.
9277         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9278         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9279         Update.
9280         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9281         (expand_symtab_containing_pc, lookup_objfile_from_block)
9282         (lookup_static_symbol, basic_lookup_transparent_type)
9283         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9284         (find_line_symtab, info_sources_command)
9285         (default_collect_symbol_completion_matches_break_on)
9286         (make_source_files_completion_list, find_main_name): Update.
9287         * symmisc.c (print_symbol_bcache_statistics)
9288         (print_objfile_statistics, maintenance_print_symbols)
9289         (maintenance_print_msymbols, maintenance_print_objfiles)
9290         (maintenance_info_symtabs, maintenance_check_symtabs)
9291         (maintenance_expand_symtabs, maintenance_info_line_tables):
9292         Update.
9293         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9294         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9295         (map_overlay_command, unmap_overlay_command)
9296         (simple_overlay_update, expand_symtabs_matching)
9297         (map_symbol_filenames): Update.
9298         * symfile-debug.c (set_debug_symfile): Update.
9299         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9300         Update.
9301         * source.c (select_source_symtab, forget_cached_source_info):
9302         Update.
9303         * solib.c (solib_read_symbols): Update.
9304         * solib-spu.c (append_ocl_sos): Update.
9305         * psymtab.c (maintenance_print_psymbols)
9306         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9307         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9308         * printcmd.c (info_symbol_command): Update.
9309         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9310         Update.
9311         * objfiles.h (class all_objfiles): Remove.
9312         * objfiles.c (have_partial_symbols, have_full_symbols)
9313         (have_minimal_symbols, qsort_cmp, update_section_map)
9314         (shared_objfile_contains_address_p)
9315         (default_iterate_over_objfiles_in_search_order): Update.
9316         * objc-lang.c (info_selectors_command, info_classes_command)
9317         (find_methods): Update.
9318         * minsyms.c (find_solib_trampoline_target): Update.
9319         * maint.c (maintenance_info_sections)
9320         (maintenance_translate_address, count_symtabs_and_blocks):
9321         Update.
9322         * main.c (captured_main_1): Update.
9323         * linux-thread-db.c (try_thread_db_load_from_pdir)
9324         (has_libpthread): Update.
9325         * linespec.c (iterate_over_all_matching_symtabs)
9326         (search_minsyms_for_name): Update.
9327         * jit.c (jit_find_objf_with_entry_addr): Update.
9328         * hppa-tdep.c (find_unwind_entry)
9329         (hppa_lookup_stub_minimal_symbol): Update.
9330         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9331         Update.
9332         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9333         (elf_gnu_ifunc_resolve_by_got): Update.
9334         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9335         * dwarf-index-write.c (save_gdb_index_command): Update.
9336         * cp-support.c (add_symbol_overload_list_qualified): Update.
9337         * breakpoint.c (create_overlay_event_breakpoint)
9338         (create_longjmp_master_breakpoint)
9339         (create_std_terminate_master_breakpoint)
9340         (create_exception_master_breakpoint): Update.
9341         * blockframe.c (find_pc_partial_function): Update.
9342         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9343         (ada_collect_symbol_completion_matches)
9344         (ada_add_global_exceptions): Update.
9345
9346 2019-01-17  Tom Tromey  <tom@tromey.com>
9347
9348         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9349         declare VEC.
9350         (solib_target_parse_libraries): Change return type.
9351         (library_list_start_segment, library_list_start_section)
9352         (library_list_end_library, library_list_start_library); Update.
9353         (solib_target_free_library_list): Remove.
9354         (solib_target_parse_libraries): Remove cleanup.  Change return
9355         type.
9356         (solib_target_current_sos): Update.
9357
9358 2019-01-17  Tom Tromey  <tromey@bapiya>
9359
9360         * valprint.c: Replace "the the" with "the".
9361         * symtab.c: Replace "the the" with "the".
9362         * solib.c: Replace "the the" with "the".
9363         * solib-dsbt.c: Replace "the the" with "the".
9364         * linespec.c: Replace "the the" with "the".
9365         * dwarf2loc.h: Replace "the the" with "the".
9366         * amd64-windows-tdep.c: Replace "the the" with "the".
9367         * aarch64-tdep.c: Replace "the the" with "the".
9368
9369 2019-01-16  Keith Seitz  <keiths@redhat.com>
9370
9371         PR gdb/23773
9372         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9373         <builder>: Rename to ..
9374         <m_builder>: ... this and make private.
9375         (dwarf2_cu::get_builder): New method.  Change all users of
9376         `builder' to use this method.
9377         (dwarf2_start_symtab): Move to ...
9378         (dwarf2_cu::start_symtab): ... here.  Update all callers
9379         (setup_type_unit_groups): Move to ...
9380         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9381         callers.
9382         (dwarf2_cu::reset_builder): New method.
9383         (process_full_compunit, process_full_type_unit): Use
9384         dwarf2_cu::reset_builder.
9385         (follow_die_offset): Record the ancestor CU if it is different
9386         from the followed DIE's CU.
9387         (follow_die_sig_1): Likewise.
9388
9389 2019-01-15  Tom Tromey  <tom@tromey.com>
9390
9391         * remote.c (class remote_state) <buf>: Now a char_vector.
9392         <buf_size>: Remove.
9393         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9394         parameter.
9395         (remote_target::getpkt_or_notif_sane_1)
9396         (remote_target::getpkt_sane)
9397         (remote_target::getpkt_or_notif_sane): Likewise.
9398         (class remote_target) <putpkt>: New overload.
9399         (remote_target::read_frame): Change type of "buf_p".  Remove
9400         sizeof_p parameter.
9401         (packet_ok): New overload.
9402         (packet_check_result): New overload.
9403         Update all uses.
9404
9405 2019-01-14  Tom Tromey  <tom@tromey.com>
9406
9407         * remote-notif.c (handle_notification, remote_notif_ack)
9408         (remote_notif_parse): Make "buf" const.
9409         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9410         const.
9411         (remote_notif_parse, remote_notif_ack, handle_notification):
9412         Likewise.
9413         * remote.c (remote_notif_stop_parse): Make "buf" const.
9414         (remote_target::remote_parse_stop_reply): Make "buf" const.
9415         (remote_notif_stop_ack): Make "buf" const.
9416
9417 2019-01-14  Tom Tromey  <tom@tromey.com>
9418
9419         * remote.c (remote_console_output): Make parameter const.
9420
9421 2019-01-14  Tom Tromey  <tom@tromey.com>
9422
9423         * target-debug.h (target_debug_print_signals): Constify.
9424         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9425         * procfs.c (procfs_target::pass_signals): Update.
9426         * linux-nat.c (linux_nat_target::pass_signals): Update.
9427         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9428         * target-delegates.c: Rebuild.
9429         * remote.c (remote_target::program_signals): Update.
9430         (remote_target::pass_signals): Update.
9431         * target.c (target_pass_signals): Constify argument.
9432         (target_program_signals): Likewise.
9433         * target.h (struct target_ops) <pass_signals, program_signals>:
9434         Constify argument.
9435         (target_pass_signals, target_program_signals): Constify argument.
9436
9437 2019-01-14  Tom Tromey  <tom@tromey.com>
9438
9439         PR tui/28819:
9440         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9441
9442 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9443
9444         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9445         field.
9446         * rs6000-tdep.c: Include reggroups.h.
9447         (IS_V_ALIAS_PSEUDOREG): Define.
9448         (rs6000_register_name): Return names for the "vX" aliases.
9449         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9450         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9451         aliases.  Call default_register_reggroup_p for all other
9452         pseudo-registers.
9453         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9454         New functions.
9455         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9456         Handle "vX" aliases.
9457         (v_alias_pseudo_register_collect): New function.
9458         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9459         (rs6000_gdbarch_init): Initialize "vX" aliases as
9460         pseudo-registers.  Restore registration of
9461         rs6000_pseudo_register_reggroup_p with
9462         set_tdesc_pseudo_register_reggroup_p.
9463
9464 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9465
9466         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9467         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9468         set_gdbarch_num_pseudo_regs.
9469
9470 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9471
9472         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9473         Remove arg prefixname, add do_set and do_show.
9474         Add member functions set_list and show_list.
9475         * cli/cli-style.c (class cli_style_option): Update accordingly.
9476         (style_set_list): Move to file scope.
9477         (style_show_list): Likewise.
9478         (set_style): Call help_list.
9479         (show_style): Call cmd_show_list.
9480         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9481         Update to use the new macro.
9482
9483 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9484
9485         * ada-lang.c (_initialize_ada_language): Expand the help text
9486         for the "catch exception" command.
9487
9488 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9489
9490         * symtab.c (matching_obj_sections): Initialize obj,
9491         declare it closer to its usage.
9492
9493 2019-01-10  Tom Tromey  <tom@tromey.com>
9494
9495         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9496         (basic_inf_threads_range): Remove.
9497         (inf_threads_range, inf_non_exited_threads_range)
9498         (safe_inf_threads_range): Use next_adapter.
9499
9500 2019-01-10  Keith Seitz  <keiths@redhat.com>
9501
9502         PR gdb/23712
9503         PR symtab/23010
9504         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9505         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9506
9507 2019-01-10  Keith Seitz  <keiths@redhat.com>
9508
9509         PR gdb/23712
9510         PR symtab/23010
9511         * dictionary.c (pending_to_vector): Remove.
9512         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9513         Remove _1 suffix, replacing functions of the same name.  Update
9514         all callers.
9515         (dict_create_hashed, dict_create_hashed_expandable)
9516         (dict_create_linear, dict_create_linear_expandable, dict_free)
9517         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9518         Make functions static.
9519
9520 2019-01-10  Keith Seitz  <keiths@redhat.com>
9521
9522         PR gdb/23712
9523         PR symtab/23010
9524         * dictionary.h (struct dictionary): Replace declaration with
9525         multidictionary.
9526         (dict_create_hashed, dict_create_hashed_expandable)
9527         (dict_create_linear, dict_create_linear_expandable)
9528         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9529         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9530         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9531         taking multidictionary argument.
9532         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9533         * block.h (struct block) <dict>: Change to multidictionary
9534         and rename `multidict'.
9535         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9536         symmisc.c: Update all dictionary references to multidictionary.
9537
9538 2019-01-10  Keith Seitz  <keiths@redhat.com>
9539
9540         PR gdb/23712
9541         PR symtab/23010
9542         * dictionary.c: Include unordered_map.
9543         (pending_to_vector): New function.
9544         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9545         Rewrite the non-"_1" functions to take vector instead
9546         of linked list.
9547         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9548         "new" _1 versions of the same name.
9549         (multidictionary): Define.
9550         (std::hash<enum language): New definition.
9551         (collate_pending_symbols_by_language, mdict_create_hashed)
9552         (mdict_create_hashed_expandable, mdict_create_linear)
9553         (mdict_create_linear_expandable, mdict_free)
9554         (find_language_dictionary, create_new_language_dictionary)
9555         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9556         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9557         (mdict_size, mdict_empty): New functions.
9558         * dictionary.h (mdict_iterator): Define.
9559
9560 2019-01-10  Pedro Alves  <palves@redhat.com>
9561
9562         * breakpoint.c (read_uploaded_action)
9563         (create_tracepoint_from_upload): Adjust to use
9564         gdb::unique_xmalloc_ptr.
9565         * ctf.c (ctf_write_uploaded_tp):
9566         (SET_ARRAY_FIELD): Use emplace_back.
9567         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9568         * tracefile-tfile.c (tfile_write_uploaded_tp):
9569         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9570         gdb::unique_xmalloc_ptr.
9571         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9572         at_string, cond_string, cmd_strings>: Replace char pointers
9573         with gdb::unique_xmalloc_ptr.
9574
9575 2019-01-10  Pedro Alves  <palves@redhat.com>
9576
9577         * solib-target.c (library_list_start_library): Don't xstrdup name.
9578
9579 2019-01-10  Pedro Alves  <palves@redhat.com>
9580
9581         * mdebugread.c (parse_partial_symbols): Use
9582         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9583
9584 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9585
9586         * linux-fork.c (scoped_switch_fork_info)
9587         <~scoped_switch_fork_info>: Fix incorrect variable name.
9588
9589 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9590
9591         * linux-fork.c (scoped_switch_fork_info)
9592         <scoped_switch_fork_info>: Make explicit.
9593         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9594
9595 2019-01-10  Tom Tromey  <tom@tromey.com>
9596
9597         * objfiles.h (objfile::reset_psymtabs): Update.
9598         * objfiles.c (objfile::objfile): Update.
9599         * psymtab.h (psymtab_storage::obstack): Update.
9600         (psymtab_storage::m_obstack): Use gdb::optional.
9601         (class psymtab_storage): Update comment.  Remove objfile
9602         parameter.
9603         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9604
9605 2019-01-10  Tom Tromey  <tom@tromey.com>
9606
9607         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9608         <free_psymtabs>: Now private.
9609         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9610         (allocate_psymtab): Use new method.
9611
9612 2019-01-10  Tom Tromey  <tom@tromey.com>
9613
9614         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9615         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9616         * mdebugread.c (parse_partial_symbols): Use
9617         allocate_dependencies.
9618         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9619         allocate_dependencies.
9620         (process_psymtab_comp_unit_reader)
9621         (build_type_psymtab_dependencies): Likewise.
9622         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9623
9624 2019-01-10  Tom Tromey  <tom@tromey.com>
9625
9626         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9627         PSYMBOL_SET_LANGUAGE.
9628         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9629
9630 2019-01-10  Tom Tromey  <tom@tromey.com>
9631
9632         * psymtab.h (psymtab_storage::obstack): New method.
9633         <m_obstack>: Rename from obstack; now private.
9634         * psymtab.c (psymtab_storage): Update.
9635         * dwarf2read.c (create_addrmap_from_index)
9636         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9637         Update.
9638
9639 2019-01-10  Tom Tromey  <tom@tromey.com>
9640
9641         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9642         * objfiles.h (objfile::reset_psymtabs): New method.
9643
9644 2019-01-10  Tom Tromey  <tom@tromey.com>
9645
9646         * symmisc.c (print_symbol_bcache_statistics): Update.
9647         (print_objfile_statistics): Update.
9648         * symfile.c (reread_symbols): Update.
9649         * psymtab.h (class psymtab_storage): New.
9650         * psymtab.c (psymtab_storage): New constructor.
9651         (~psymtab_storage): New destructor.
9652         (require_partial_symbols): Update.
9653         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9654         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9655         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9656         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9657         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9658         (start_psymtab_common, end_psymtab_common)
9659         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9660         (allocate_psymtab): Update.
9661         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9662         Update.
9663         (dump_psymtab_addrmap, maintenance_print_psymbols)
9664         (maintenance_check_psymtabs): Update.
9665         (class objfile_psymtabs): Move to objfiles.h.
9666         * psympriv.h (discard_psymtab): Now inline.
9667         (psymtab_discarder::psymtab_discarder): Update.
9668         (psymtab_discarder::~psymtab_discarder): Update.
9669         (ALL_OBJFILE_PSYMTABS): Rewrite.
9670         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9671         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9672         Remove fields.
9673         <partial_symtabs>: New field.
9674         (class objfile_psymtabs): Move from psymtab.h.  Update.
9675         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9676         psymbol_cache.
9677         (objfile::~objfile): Don't destroy psymbol_cache.
9678         * mdebugread.c (parse_partial_symbols): Update.
9679         * dwarf2read.c (create_addrmap_from_index)
9680         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9681         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9682         (add_partial_subprogram, dwarf2_ranges_read): Update.
9683         * dwarf-index-write.c (write_address_map)
9684         (write_one_signatured_type, recursively_write_psymbols)
9685         (class debug_names, class debug_names, write_psymtabs_to_index):
9686         Update.
9687
9688 2019-01-10  Tom Tromey  <tom@tromey.com>
9689
9690         * symtab.h (SYMBOL_SET_NAMES): Update.
9691         (symbol_set_names): Update.
9692         (MSYMBOL_SET_NAMES): Update.
9693         * symtab.c (symbol_set_names): Change argument to be an
9694         objfile_per_bfd_storage.
9695         * psymtab.c (add_psymbol_to_bcache): Update.
9696         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9697
9698 2019-01-10  Tom Tromey  <tom@tromey.com>
9699
9700         * symtab.c (create_demangled_names_hash): Change argument to be an
9701         objfile_per_bfd_storage.
9702         (symbol_set_names): Update.
9703
9704 2019-01-10  Tom Tromey  <tom@tromey.com>
9705
9706         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9707         init_psymbol_list.
9708         * psymtab.c (init_psymbol_list): Do nothing if already called.
9709         * psympriv.h (init_psymbol_list): Add comment.
9710         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9711         init_psymbol_list.
9712         * dbxread.c (dbx_symfile_read): Unconditionally call
9713         init_psymbol_list.
9714
9715 2019-01-10  Tom Tromey  <tom@tromey.com>
9716
9717         * xcoffread.c (scan_xcoff_symtab): Update.
9718         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9719         "where".
9720         * mdebugread.c (parse_partial_symbols)
9721         (handle_psymbol_enumerators): Update.
9722         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9723         * dbxread.c (read_dbx_symtab): Update.
9724         * psympriv.h (psymbol_placement): New enum.
9725         (add_psymbol_to_list): Update.
9726
9727 2019-01-10  Tom Tromey  <tom@tromey.com>
9728
9729         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9730         static_psymbols parameters.
9731         (scan_xcoff_symtab): Update.
9732         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9733         static_psymbols parameters.
9734         * psympriv.h (start_psymtab_common): Update.
9735         * mdebugread.c (parse_partial_symbols): Update.
9736         * dwarf2read.c (create_partial_symtab): Update.
9737         * dbxread.c (read_dbx_symtab): Update.
9738         (start_psymtab): Remove global_psymbols and static_psymbols
9739         parameters.
9740
9741 2019-01-10  Tom Tromey  <tom@tromey.com>
9742
9743         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9744         * psymtab.c (allocate_psymtab): Add comment.
9745         * psympriv.h (allocate_psymtab): Add comment.
9746         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9747         initializations.
9748         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9749
9750 2019-01-10  Tom Tromey  <tom@tromey.com>
9751
9752         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9753         Don't declare.
9754         * mipsread.c: Include mdebugread.h.
9755         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9756         Declare.
9757         * elfread.c: Include mdebugread.h.
9758
9759 2019-01-09  Tom Tromey  <tom@tromey.com>
9760
9761         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9762         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9763         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9764         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9765         (psym_lookup_symbol, psym_find_last_source_symtab)
9766         (psym_forget_cached_source_info, psym_print_stats)
9767         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9768         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9769         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9770         (psym_find_compunit_symtab_by_address)
9771         (maintenance_print_psymbols, maintenance_info_psymtabs)
9772         (maintenance_check_psymtabs): Use ranged for.
9773         * psymtab.h (class objfile_psymtabs): New.
9774         (require_partial_symbols): Return objfile_psymtabs.
9775         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9776
9777 2019-01-09  Tom Tromey  <tom@tromey.com>
9778
9779         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9780         (find_pc_mapped_section, list_overlays_command)
9781         (map_overlay_command, unmap_overlay_command)
9782         (simple_overlay_update): Use all_objfiles.
9783         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9784         * printcmd.c (info_symbol_command): Use all_objfiles.
9785         * objfiles.h (ALL_OBJSECTIONS): Remove.
9786         * maint.c (maintenance_translate_address): Use all_objfiles.
9787         * gcore.c (gcore_create_callback): Use all_objfiles.
9788         (objfile_find_memory_regions): Likewise.
9789
9790 2019-01-09  Tom Tromey  <tom@tromey.com>
9791
9792         * symtab.c (find_line_symtab, info_sources_command)
9793         (make_source_files_completion_list): Use objfile_compunits.
9794         * source.c (select_source_symtab): Use objfile_compunits.
9795         * objfiles.h (struct objfile): Update comment.
9796         (ALL_OBJFILES): Remove.
9797         (ALL_FILETABS): Remove.
9798         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9799         objfile_compunits.
9800
9801 2019-01-09  Tom Tromey  <tom@tromey.com>
9802
9803         * symmisc.c (print_objfile_statistics, dump_objfile)
9804         (maintenance_print_symbols): Use compunit_filetabs.
9805         * source.c (forget_cached_source_info_for_objfile): Use
9806         compunit_filetabs.
9807         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9808         (ALL_FILETABS): Use compunit_filetabs.
9809         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9810         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9811
9812 2019-01-09  Tom Tromey  <tom@tromey.com>
9813
9814         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9815         (compunit_filetabs): New.
9816         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9817         compunit_filetabs.
9818         (info_sources_command, make_source_files_completion_list): Remove
9819         declaration.
9820         * symmisc.c (print_objfile_statistics, dump_objfile)
9821         (maintenance_print_symbols): Remove declaration.
9822         (maintenance_info_symtabs): Use compunit_filetabs.
9823         (maintenance_info_line_tables): Likewise.
9824         * source.c (select_source_symtab): Change local variable name.
9825         (forget_cached_source_info_for_objfile): Remove declaration.
9826         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9827         * objfiles.c (objfile_relocate1): Remove declaration.
9828         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9829         declaration.
9830         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9831         * coffread.c (coff_symtab_read): Remove declaration.
9832         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9833         compunit_filetabs.
9834
9835 2019-01-09  Tom Tromey  <tom@tromey.com>
9836
9837         * symtab.c (lookup_objfile_from_block)
9838         (find_pc_sect_compunit_symtab, search_symbols)
9839         (default_collect_symbol_completion_matches_break_on): Use
9840         objfile_compunits.
9841         * objfiles.h (ALL_COMPUNITS): Remove.
9842         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9843         * cp-support.c (add_symbol_overload_list_qualified): Use
9844         objfile_compunits.
9845         * ada-lang.c (ada_collect_symbol_completion_matches)
9846         (ada_add_global_exceptions): Use objfile_compunits.
9847
9848 2019-01-09  Tom Tromey  <tom@tromey.com>
9849
9850         * source.c (select_source_symtab)
9851         (forget_cached_source_info_for_objfile): Remove declaration.
9852         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9853         declaration.
9854         * maint.c (count_symtabs_and_blocks): Remove declaration.
9855         * cp-support.c (add_symbol_overload_list_qualified): Remove
9856         declaration.
9857         * coffread.c (coff_symtab_read): Remove declaration.
9858         * symtab.c (lookup_symbol_in_objfile_symtabs)
9859         (basic_lookup_transparent_type_1): Use objfile_compunits.
9860         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9861         (info_sources_command, search_symbols)
9862         (default_collect_symbol_completion_matches_break_on)
9863         (make_source_files_completion_list): Remove declaration.
9864         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9865         (ada_collect_symbol_completion_matches)
9866         (ada_add_global_exceptions): Remove declaration.
9867         * linespec.c (iterate_over_all_matching_symtabs): Use
9868         objfile_compunits.
9869         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9870         (class objfile_compunits): New.
9871         (ALL_COMPUNITS): Use objfile_compunits.
9872         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9873         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9874         objfile_compunits.
9875         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9876
9877 2019-01-09  Tom Tromey  <tom@tromey.com>
9878
9879         * symtab.c (search_symbols)
9880         (default_collect_symbol_completion_matches_break_on): Use
9881         objfile_msymbols.
9882         * ada-lang.c (ada_lookup_simple_minsym)
9883         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9884         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9885         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9886         objfile_msymbols.
9887         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9888         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9889         * objc-lang.c (find_methods): Use objfile_msymbols.
9890         (info_selectors_command, info_classes_command): Likewise.
9891         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9892         * objfiles.h (class objfile_msymbols): New.
9893         (ALL_OBJFILE_MSYMBOLS): Remove.
9894         (ALL_MSYMBOLS): Remove.
9895
9896 2019-01-09  Tom Tromey  <tom@tromey.com>
9897
9898         * common/next-iterator.h (next_adapter): Add Iterator template
9899         parameter.
9900         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9901         (class all_objfiles_safe): New.
9902         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9903         * objfiles.c (put_objfile_before): Update comment.
9904         (add_separate_debug_objfile): Likewise.
9905         (free_all_objfiles): Use all_objfiles_safe.
9906         (objfile_purge_solibs): Likewise.
9907
9908 2019-01-09  Tom Tromey  <tom@tromey.com>
9909
9910         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9911         (expand_symtab_containing_pc, lookup_static_symbol)
9912         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9913         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9914         all_objfiles.
9915         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9916         * breakpoint.c (create_overlay_event_breakpoint)
9917         (create_longjmp_master_breakpoint)
9918         (create_std_terminate_master_breakpoint)
9919         (create_exception_master_breakpoint): Use all_objfiles.
9920         * linux-thread-db.c (try_thread_db_load_from_pdir)
9921         (has_libpthread): Use all_objfiles.
9922         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9923         * linespec.c (iterate_over_all_matching_symtabs)
9924         (search_minsyms_for_name): Use all_objfiles.
9925         * maint.c (maintenance_info_sections): Use all_objfiles.
9926         * main.c (captured_main_1): Use all_objfiles.
9927         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9928         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9929         * guile/scm-pretty-print.c
9930         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9931         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9932         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9933         (maintenance_print_msymbols): Use all_objfiles.
9934         * source.c (select_source_symtab): Use all_objfiles.
9935         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9936         * symfile.c (remove_symbol_file_command)
9937         (expand_symtabs_matching, map_symbol_filenames): Use
9938         all_objfiles.
9939         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9940         all_objfiles.
9941         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9942         * objc-lang.c (find_methods): Use all_objfiles.
9943         * objfiles.c (have_partial_symbols, have_full_symbols)
9944         (have_minimal_symbols, qsort_cmp)
9945         (default_iterate_over_objfiles_in_search_order): Use
9946         all_objfiles.
9947         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9948         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9949         (maintenance_check_psymtabs): Use all_objfiles.
9950         (ALL_PSYMTABS): Remove.
9951         * compile/compile-object-run.c (do_module_cleanup): Use
9952         all_objfiles.
9953         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9954         * cp-support.c (add_symbol_overload_list_qualified): Use
9955         all_objfiles.
9956         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9957         Use all_objfiles.
9958         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9959         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9960         all_objfiles.
9961         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9962         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9963         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9964         Uses all_objfiles.
9965         * solib.c (solib_read_symbols): Use all_objfiles
9966
9967 2019-01-09  Tom Tromey  <tom@tromey.com>
9968
9969         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9970         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9971         all_objfiles.
9972         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9973         * symmisc.c (print_symbol_bcache_statistics)
9974         (print_objfile_statistics, maintenance_print_objfiles)
9975         (maintenance_info_symtabs, maintenance_check_symtabs)
9976         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9977         all_objfiles.
9978         * source.c (forget_cached_source_info): Use all_objfiles.
9979         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9980         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9981         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9982         * objfiles.c (update_section_map): Use all_objfiles.
9983         (shared_objfile_contains_address_p): Likewise.
9984         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9985         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9986
9987 2019-01-09  Tom Tromey  <tom@tromey.com>
9988
9989         * common/next-iterator.h: New file.
9990         * objfiles.h (class all_objfiles): New.
9991         (struct objfile_iterator): New.
9992
9993 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9994
9995         * NEWS: Move the description of the changed "frame", "select-frame",
9996          and "info frame" commands to the Changed commands section.
9997
9998 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9999
10000         * gdbtypes.c (check_stub_method_group): Remove handling of old
10001         mangling schemes.
10002         * linespec.c (find_methods): Likewise.
10003         * stabsread.c (read_member_functions): Likewise.
10004         * valops.c (search_struct_method): Likewise.
10005         (value_struct_elt_for_reference): Likewise.
10006         * NEWS: Mention this change.
10007
10008 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10009
10010         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10011         print_source_lines.
10012         * source.c (print_source_lines_base): Update line number check.
10013         (print_source_lines): New function.
10014         (source_lines_range::source_lines_range): New function.
10015         * source.h (class source_lines_range): New class.
10016         (print_source_lines): New declaration.
10017
10018 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10019
10020         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10021
10022 2019-01-08  Tom Tromey  <tom@tromey.com>
10023             Simon Marchi  <simon.marchi@ericsson.com>
10024
10025         PR gdb/24060
10026         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10027         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10028         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10029         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10030         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10031         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10032
10033 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10034
10035         * source.c (select_source_symtab): Move header comment to
10036         declaration in source.h.
10037         (forget_cached_source_info_for_objfile): Likewise.
10038         (forget_cached_source_info): Likewise.
10039         (identify_source_line): Likewise.
10040         * source.h (identify_source_line): Move declaration from symtab.h
10041         and add comment from source.c
10042         (print_source_lines): Likewise.
10043         (forget_cached_source_info_for_objfile): Likewise.
10044         (forget_cached_source_info): Likewise.
10045         (select_source_symtab): Likewise.
10046         (enum print_source_lines_flag): Move definition from symtab.h.
10047         * symtab.h (identify_source_line): Move declaration to source.h.
10048         (print_source_lines): Likewise.
10049         (forget_cached_source_info_for_objfile): Likewise.
10050         (forget_cached_source_info): Likewise.
10051         (select_source_symtab): Likewise.
10052         (enum print_source_lines_flag): Move definition to source.h.
10053         * tui/tui-hooks.c: Add 'source.h' include.
10054
10055 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10056
10057         * source.c (print_source_lines_base): Handle requests to print
10058         reverse line number sequences, and guard against empty lines
10059         string.
10060
10061 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10062
10063         * source.c (print_source_lines_base): Fix skip of '\r' if next
10064         character is '\n'.
10065
10066 2019-01-06  Tom Tromey  <tom@tromey.com>
10067
10068         * c-exp.y (struct c_parse_state) <macro_original_text,
10069         expansion_obstack>: New member.
10070         (macro_original_text, expansion_obstack): Remove globals.
10071         (scan_macro_expansion, scanning_macro_expansion)
10072         (finished_macro_expansion): Update.
10073         (scan_macro_cleanup): Remove.
10074         (yylex, c_parse): Update.
10075
10076 2019-01-06  Tom Tromey  <tom@tromey.com>
10077
10078         * c-exp.y (struct c_parse_state) <strings>: New member.
10079         (operator_stoken): Update.
10080
10081 2019-01-06  Tom Tromey  <tom@tromey.com>
10082
10083         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10084         (union type_stack_elt) <typelist_val>: Now a pointer to
10085         std::vector.
10086         (type_stack_cleanup): Don't declare.
10087         (push_typelist): Update.
10088         * parse.c (pop_typelist): Return a std::vector.
10089         (push_typelist): Take a std::vector.
10090         (follow_types): Update.  Do not free args.
10091         (type_stack_cleanup): Remove.
10092         * c-exp.y (struct c_parse_state): New.
10093         (cpstate): New global.
10094         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10095         (nonempty_typelist): Update.
10096         (func_mod): Create a new vector.
10097         (c_parse): Create a c_parse_state.
10098         (check_parameter_typelist): Do not delete params.
10099         (function_method): Update.  Do not delete type_list.
10100
10101 2019-01-06  Tom Tromey  <tom@tromey.com>
10102
10103         PR gdb/28155:
10104         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10105         check_typedef.
10106         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10107         (print_return_value): Likewise.
10108
10109 2019-01-05  Tom Tromey  <tom@tromey.com>
10110
10111         * contrib/cleanup_check.py: Remove.
10112         * contrib/gcc-with-excheck: Remove.
10113         * contrib/exsummary.py: Remove.
10114         * contrib/excheck.py: Remove.
10115
10116 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10117
10118         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10119         NULL. Initialize tpprev to NULL instead of assigning it
10120         to NULL on the next statement.
10121         * windows-nat.c (windows_delete_thread): Remove check for
10122         main_thread_id before printing thread exit notifications.
10123         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10124         Remove thread ID check against main_thread_id.
10125         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10126         windows_delete_thread.
10127         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10128
10129 2019-01-04  Tom Tromey  <tom@tromey.com>
10130
10131         * compile/compile.c (_initialize_compile): Use upper case for
10132         metasyntactic variables.
10133         * symmisc.c (_initialize_symmisc): Use upper case for
10134         metasyntactic variables.
10135         * psymtab.c (_initialize_psymtab): Use upper case for
10136         metasyntactic variables.
10137         * demangle.c (demangle_command): Use upper case for metasyntactic
10138         variables.
10139         (_initialize_demangler): Likewise.
10140         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10141         variables.
10142
10143 2019-01-03  Tom Tromey  <tom@tromey.com>
10144
10145         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10146
10147 2019-01-03  Tom Tromey  <tom@tromey.com>
10148
10149         * python/py-symtab.c (salpy_str): Update.
10150         (struct salpy_sal_object) <symtab>: Now a PyObject.
10151         (salpy_dealloc): Update.
10152         (del_objfile_sal): Use gdbpy_ref.
10153
10154 2019-01-03  Tom Tromey  <tom@tromey.com>
10155
10156         * python/py-type.c (convert_field): Use new_reference.  Return
10157         gdbpy_ref.
10158         (make_fielditem): Return gdbpy_ref.
10159         (typy_fields): Update.
10160         (typy_getitem): Update.
10161         (field_name): Return gdbpy_ref.  Use new_reference.
10162         (typy_iterator_iternext): Update.
10163
10164 2019-01-03  Tom Tromey  <tom@tromey.com>
10165
10166         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10167
10168 2019-01-03  Tom Tromey  <tom@tromey.com>
10169
10170         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10171         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10172         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10173         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10174         (pspy_set_type_printers): Likewise.
10175         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10176         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10177         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10178         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10179         (objfpy_set_type_printers): Likewise.
10180
10181 2019-01-03  Tom Tromey  <tom@tromey.com>
10182
10183         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10184         (gdbpy_print_stack): Use gdbpy_err_fetch.
10185         * python/python-internal.h (class gdbpy_err_fetch): New class.
10186         (class gdbpy_enter) <m_error_type, m_error_value,
10187         m_error_traceback>: Remove.
10188         <m_error>: New member.
10189         (gdbpy_exception_to_string): Don't declare.
10190         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10191         * python/py-value.c (convert_value_from_python): Use
10192         gdbpy_err_fetch.
10193         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10194         gdbpy_exception_to_string.
10195         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10196         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10197         gdbpy_err_fetch.
10198
10199 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10200
10201         * linux-nat.c (delete_lwp_cleanup): Delete.
10202         (struct lwp_deleter): New struct.
10203         (lwp_info_up): New typedef.
10204         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10205         lwp_info_up.
10206
10207 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10208
10209         * linux-fork.c (class scoped_switch_fork_info): New class.
10210         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10211
10212 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10213
10214         * valops.c (find_overload_match): Remove use of null_cleanup, and
10215         calls to do_cleanups.
10216
10217 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10218
10219         * compile/compile-cplus-types.c
10220         (compile_cplus_instance::decl_name): Handle changes to
10221         cp_func_name.
10222         * cp-support.c (cp_func_name): Update header comment, update
10223         return type.
10224         * cp-support.h (cp_func_name): Update return type in declaration.
10225         * valops.c (find_overload_match): Move temp_func local to top
10226         level of function and change its type.  Use temp_func to hold and
10227         delete temporary string obtained from cp_func_name.
10228
10229 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10230
10231         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10232         gdb::char_vector, remove cleanup, and update uses of `msg`.
10233
10234 2019-01-03  Jim Wilson  <jimw@sifive.com>
10235
10236         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10237
10238 2019-01-02  Tom Tromey  <tom@tromey.com>
10239
10240         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10241         (tdesc_parse_xml): Remove cleanups.
10242         * target-descriptions.h (make_cleanup_free_target_description):
10243         Don't declare.
10244         (target_desc_deleter): New struct.
10245         (target_desc_up): New typedef.
10246         * target-descriptions.c (target_desc_deleter::operator()): Rename
10247         from free_target_description.
10248         (make_cleanup_free_target_description): Remove.
10249
10250 2019-01-02  Tom Tromey  <tom@tromey.com>
10251
10252         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10253         constructor, destructor.
10254         (linespec_parser): Remove typedef.
10255         (~linespec_parser): Rename from linespec_parser_delete.
10256         (linespec_lex_to_end, linespec_complete_label)
10257         (linespec_complete): Update.
10258         (decode_line_full): Remove cleanups.
10259         (decode_line_1): Update.
10260
10261 2019-01-02  Tom Tromey  <tom@tromey.com>
10262
10263         * python/python-internal.h (inferior_to_inferior_object): Change
10264         return type.
10265         * python/py-exitedevent.c (create_exited_event_object): Update.
10266         * python/py-inferior.c (inferior_to_inferior_object): Return
10267         gdbpy_ref.
10268         (python_new_inferior, python_inferior_deleted)
10269         (thread_to_thread_object, delete_thread_object)
10270         (build_inferior_list, gdbpy_selected_inferior): Update.
10271         * python/py-infthread.c (create_thread_object): Update.  Also fail
10272         if inferior_to_inferior_object fails.
10273
10274 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10275
10276         * inferior.h (class inferior) <displaced_step_state>: New field.
10277         * infrun.h (struct displaced_step_state): Move here from
10278         infrun.c.  Initialize fields, add constructor.
10279         <inf>: Remove field.
10280         <reset>: New method.
10281         * infrun.c (struct displaced_step_inferior_state): Move to
10282         infrun.h.
10283         (displaced_step_inferior_states): Remove.
10284         (get_displaced_stepping_state): Adust.
10285         (displaced_step_in_progress_any_inferior): Adjust.
10286         (displaced_step_in_progress_thread): Adjust.
10287         (displaced_step_in_progress): Adjust.
10288         (add_displaced_stepping_state): Remove.
10289         (get_displaced_step_closure_by_addr): Adjust.
10290         (remove_displaced_stepping_state): Remove.
10291         (infrun_inferior_exit): Call displaced_step_state.reset.
10292         (use_displaced_stepping): Don't check for NULL.
10293         (displaced_step_prepare_throw): Call
10294         get_displaced_stepping_state.
10295         (displaced_step_fixup): Don't check for NULL.
10296         (prepare_for_detach): Don't check for NULL.
10297
10298 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10299
10300         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10301          in case of call that did not complete.
10302
10303 2019-01-02  Andrey Utkin  <autkin@undo.io>
10304
10305         * symfile.c (find_separate_debug_file): Fix search of debug files for
10306         remote debuggee.
10307
10308 2019-01-02  Tom Tromey  <tom@tromey.com>
10309
10310         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10311         indentation.
10312         * python/py-frame.c (frapy_older): Remove cast.
10313         (frapy_newer): Likewise.
10314         * python/py-breakpoint.c (local_setattro): Remove cast.
10315         * python/py-arch.c (archpy_name): Remove local variable.
10316         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10317
10318 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10319
10320         * unittests/basic_string_view/element_access/char/empty.cc:
10321         Fix year range in copyright header.
10322
10323 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10324
10325         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10326         Delete.
10327         <operator==>: Update with for removed field.
10328         <hash>: Likewise.
10329         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10330         <isa_features>: ...this.
10331         <abi_features>: New field.
10332         (riscv_isa_flen): Update comment.
10333         (riscv_abi_xlen): New declaration.
10334         (riscv_abi_flen): New declaration.
10335         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10336         isa_features.
10337         (riscv_abi_xlen): New function.
10338         (riscv_isa_flen): Update to get answer from isa_features.
10339         (riscv_abi_flen): New function.
10340         (riscv_has_fp_abi): Update to get answer from abi_features.
10341         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10342         xlen and flen.
10343         (riscv_call_info) <xlen, flen>: Update comment.
10344         (riscv_call_arg_struct): Remove invalid assertions
10345         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10346         is removed.
10347         (riscv_gdbarch_init): Gather isa features and abi features
10348         separately, ensure both match on the gdbarch when reusing an old
10349         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10350         a target with 64-bit float hardware.
10351
10352 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10353
10354         * source.c (search_command_helper): Stop reverse search
10355         when line 1 has been searched.
10356
10357 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10358
10359         * record-full.c (record_full_base_target::close): Rewrite
10360         record_full_core_buf_list free logic.
10361
10362 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10363
10364         * break-catch-syscall.c (print_one_catch_syscall): xfree
10365         the last text.
10366
10367 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10368
10369         * top.c (print_gdb_version): Update Copyright year in version
10370         message.
10371
10372 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10373
10374         Update copyright year range in all GDB files.
10375
10376 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10377
10378         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10379
10380 For older changes see ChangeLog-2018.
10381 \f
10382 Local Variables:
10383 mode: change-log
10384 left-margin: 8
10385 fill-column: 74
10386 version-control: never
10387 coding: utf-8
10388 End:
10389