gdb/ChangeLog

   1 2019-09-20  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
   4         (struct tui_locator_window) <full_name, proc_name>: Now
   5         std::string.
   6         * tui/tui-stack.c (tui_locator_window::make_status_line)
   7         (tui_locator_window::set_locator_fullname)
   8         (tui_locator_window::set_locator_info): Update.
   9         * tui/tui-source.c (tui_source_window::set_contents)
  10         (tui_source_window::showing_source_p): Update.
  11
  12 2019-09-20  Tom Tromey  <tom@tromey.com>
  13
  14         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
  15         Don't call tui_locator_win_info_ptr.
  16
  17 2019-09-20  Tom Tromey  <tom@tromey.com>
  18
  19         * tui/tui-win.c (tui_resize_all): Don't call refresh.
  20
  21 2019-09-20  Tom Tromey  <tom@tromey.com>
  22
  23         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
  24         height for locator.
  25         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
  26         * tui/tui-layout.c (show_source_disasm_command, show_data)
  27         (show_source_or_disasm_and_command): Use 1 as height for locator.
  28
  29 2019-09-20  Tom Tromey  <tom@tromey.com>
  30
  31         * tui/tui.c (tui_enable): Update.
  32         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
  33         Update.
  34         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
  35         Update.
  36         * tui/tui-data.c (win_resized): Now bool.
  37         (tui_win_resized): Return bool.
  38         (tui_set_win_resized_to): Accept a bool.
  39
  40 2019-09-20  Tom Tromey  <tom@tromey.com>
  41
  42         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
  43         Change type of "refresh_values_only".
  44         * tui/tui-regs.c (tui_data_window::show_register_group): Change
  45         type of "refresh_values_only".
  46
  47 2019-09-20  Tom Tromey  <tom@tromey.com>
  48
  49         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
  50         std::string.
  51         (tui_disassemble): Add "pos" parameter.
  52         (tui_disasm_window::set_contents): Simplify.
  53
  54 2019-09-20  Tom Tromey  <tom@tromey.com>
  55
  56         * tui/tui-winsource.h (struct tui_source_window_base)
  57         <show_source_content>: Now private.
  58         * tui/tui-winsource.c
  59         (tui_source_window_base::show_source_content): Don't handle empty
  60         content case.
  61
  62 2019-09-20  Tom Tromey  <tom@tromey.com>
  63
  64         * tui/tui-layout.c (show_source_disasm_command)
  65         (show_source_or_disasm_and_command): Don't call
  66         show_source_content.
  67
  68 2019-09-20  Tom Tromey  <tom@tromey.com>
  69
  70         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
  71         Declare.
  72         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
  73         from tui_make_status_line.
  74         (tui_locator_window::rerender): Update.
  75
  76 2019-09-20  Tom Tromey  <tom@tromey.com>
  77
  78         * tui/tui-stack.c (tui_make_status_line): Return std::string.
  79         (tui_locator_window::rerender): Update.
  80
  81 2019-09-20  Tom Tromey  <tom@tromey.com>
  82
  83         * tui/tui-winsource.h (struct tui_source_window_base)
  84         <~tui_source_window_base>: Don't declare.
  85         <fullname>: Remove.
  86         * tui/tui-winsource.c (~tui_source_window_base): Remove.
  87         * tui/tui-source.h (struct tui_source_window) <fullname>: New
  88         member.
  89         * tui/tui-source.c (tui_source_window::set_contents): Update.
  90         (tui_source_window::location_matches_p)
  91         (tui_source_window::maybe_update): Update.
  92
  93 2019-09-20  Tom Tromey  <tom@tromey.com>
  94
  95         * tui/tui-winsource.h (~tui_source_element): Remove.
  96         (tui_source_element): Update.
  97         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
  98         * tui/tui-winsource.c (tui_show_source_line): Update.
  99         * tui/tui-source.c (tui_source_window::set_contents): Update.
 100         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 101
 102 2019-09-20  Tom Tromey  <tom@tromey.com>
 103
 104         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
 105         declare.
 106         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
 107         tui_clear_source_windows_detail.
 108         * tui/tui-winsource.h (struct tui_source_window_base)
 109         <clear_detail>: Don't declare.
 110         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
 111         Remove.
 112         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
 113
 114 2019-09-20  Tom Tromey  <tromey@adacore.com>
 115
 116         PR ada/24919:
 117         * block.c (contained_in): Fix final return value.
 118
 119 2019-09-20  Alan Modra  <amodra@gmail.com>
 120
 121         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
 122         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
 123         (read_indirect_string_from_dwz): Use bfd accessor.
 124         * dwarf2read.h (struct dwz_file <filename>): Likewise.
 125         * machoread.c (macho_symfile_read_all_oso): Likewise.
 126         * solib.c (solib_bfd_open): Likewise.
 127
 128 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 129
 130         * eval.c: Move declaration of overload_resolution to...
 131         * value.h: ...here.
 132
 133 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 134
 135         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
 136         * arm-linux-tdep.c: Likewise.
 137         * arm-nbsd-nat.c: Likewise.
 138         * arm-tdep.h: Declare arm_apcs_32.
 139         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
 140
 141 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 142
 143         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
 144         * dwarf2read.h: Declare dwarf_always_disassemble.
 145
 146 2019-09-19  Tom de Vries  <tdevries@suse.de>
 147
 148         PR gdb/25009
 149         * source-cache.c (source_cache::ensure): Catch exception thrown during
 150         construction of the highlighter.
 151
 152 2019-09-18  Alan Modra  <amodra@gmail.com>
 153
 154         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
 155         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
 156         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
 157         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
 158         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
 159         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
 160         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
 161         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
 162         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
 163         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
 164         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
 165         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
 166         * solib-spu.c, * solib-svr4.c, * solib-target.c,
 167         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
 168         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
 169         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
 170         * mi/mi-interp.c: Update throughout for bfd section macro and
 171         function changes.
 172         * gcore (gcore_create_callback): Use bfd_set_section_lma.
 173         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
 174
 175 2019-09-18  Tom Tromey  <tom@tromey.com>
 176
 177         * NEWS: Add entry.
 178         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
 179         call rl_initialize.
 180         (tui_enable): Do not call rl_initialize.
 181
 182 2019-09-18  Christian Groessler  <chris@groessler.org>
 183
 184         * alpha-linux-nat.c: Include gdbarch.h.
 185
 186 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
 187
 188         * ui-file.c: Include cli/cli-style.h.
 189         (term_cli_styling): Remove cli_styling declaration.
 190
 191 2019-09-18  Alan Modra  <amodra@gmail.com>
 192
 193         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
 194         to bfd_asymbol_section.
 195
 196 2019-09-18  Alan Modra  <amodra@gmail.com>
 197
 198         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
 199         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
 200         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
 201
 202 2019-09-18  Alan Modra  <amodra@gmail.com>
 203
 204         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
 205         * spu-linux-nat.c (spu_bfd_open): Likewise.
 206
 207 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
 208
 209         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
 210         to bool to match definition in dwarf2read.c.
 211
 212 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
 213
 214         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
 215         (print_signatures): Likewise.
 216         (trust_pad_over_xvs): Likewise.
 217         * arch/aarch64-insn.c (aarch64_debug): Likewise.
 218         * arch/aarch64-insn.h (aarch64_debug): Likewise.
 219         * arm-linux-nat.c (arm_apcs_32): Likewise.
 220         * arm-linux-tdep.c (arm_apcs_32): Likewise.
 221         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
 222         * arm-tdep.c (arm_debug): Likewise.
 223         (arm_apcs_32): Likewise.
 224         * auto-load.c (debug_auto_load): Likewise.
 225         (auto_load_gdb_scripts): Likewise.
 226         (global_auto_load): Likewise.
 227         (auto_load_local_gdbinit): Likewise.
 228         (auto_load_local_gdbinit_loaded): Likewise.
 229         * auto-load.h (global_auto_load): Likewise.
 230         (auto_load_local_gdbinit): Likewise.
 231         (auto_load_local_gdbinit_loaded): Likewise.
 232         * breakpoint.c (disconnected_dprintf): Likewise.
 233         (breakpoint_proceeded): Likewise.
 234         (automatic_hardware_breakpoints): Likewise.
 235         (always_inserted_mode): Likewise.
 236         (target_exact_watchpoints): Likewise.
 237         (_initialize_breakpoint): Update.
 238         * breakpoint.h (target_exact_watchpoints): Change to bool.
 239         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
 240         * cli/cli-cmds.c (trace_commands): Likewise.
 241         * cli/cli-cmds.h (trace_commands): Likewise.
 242         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
 243         to bool*.
 244         * cli/cli-logging.c (logging_overwrite): Change to bool.
 245         (logging_redirect): Likewise.
 246         (debug_redirect): Likewise.
 247         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
 248         (struct boolean_option_def) <get_var_address_cb_>: Change return type
 249         to bool.
 250         <boolean_option_def>: Update.
 251         (struct flag_option_def): Change default type of Context to bool
 252         from int.
 253         <flag_option_def>: Change return type of var_address_cb_ to bool*.
 254         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
 255         (get_setshow_command_value_string): Likewise.
 256         * cli/cli-style.c (cli_styling): Change to bool.
 257         (source_styling): Likewise.
 258         * cli/cli-style.h (source_styling): Likewise.
 259         (cli_styling): Likewise.
 260         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
 261         to bool.
 262         * command.h (var_types): Update comment.
 263         (add_setshow_boolean_cmd): Change int* var argument to bool*.
 264         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
 265         bool.
 266         (debug_compile_cplus_scopes): Likewise.
 267         * compile/compile-internal.h (compile_debug): Likewise.
 268         * compile/compile.c (compile_debug): Likewise.
 269         (struct compile_options) <raw>: Likewise.
 270         * cp-support.c (catch_demangler_crashes): Likewise.
 271         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
 272         (usr_cmd_cris_dwarf2_cfi): Likewise.
 273         * csky-tdep.c (csky_debug): Likewise.
 274         * darwin-nat.c (enable_mach_exceptions): Likewise.
 275         * dcache.c (dcache_enabled_p): Likewise.
 276         * defs.h (info_verbose): Likewise.
 277         * demangle.c (demangle): Likewise.
 278         (asm_demangle): Likewise.
 279         * dwarf-index-cache.c (debug_index_cache): Likewise.
 280         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
 281         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
 282         * dwarf2read.c (check_physname): Likewise.
 283         (use_deprecated_index_sections): Likewise.
 284         (dwarf_always_disassemble): Likewise.
 285         * eval.c (overload_resolution): Likewise.
 286         * event-top.c (set_editing_cmd_var): Likewise.
 287         (exec_done_display_p): Likewise.
 288         * event-top.h (set_editing_cmd_var): Likewise.
 289         (exec_done_display_p): Likewise.
 290         * exec.c (write_files): Likewise.
 291         * fbsd-nat.c (debug_fbsd_lwp): Likewise
 292         (debug_fbsd_nat): Likewise.
 293         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
 294         Likewise.
 295         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
 296         <backtrace_past_entry> Likewise.
 297         * gdb-demangle.h (demangle): Likewise.
 298         (asm_demangle): Likewise.
 299         * gdb_bfd.c (bfd_sharing): Likewise.
 300         * gdbcore.h (write_files): Likewise.
 301         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
 302         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
 303         * gdbthread.h (print_thread_events): Likewise.
 304         * gdbtypes.c (opaque_type_resolution): Likewise.
 305         (strict_type_checking): Likewise.
 306         * gnu-nat.c (gnu_debug_flag): Likewise.
 307         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
 308         * guile/scm-param.c (pascm_variable): Add boolval.
 309         (add_setshow_generic): Update.
 310         (pascm_param_value): Update.
 311         (pascm_set_param_value_x): Update.
 312         * hppa-tdep.c (hppa_debug): Change to bool..
 313         * infcall.c (may_call_functions_p): Likewise.
 314         (coerce_float_to_double_p): Likewise.
 315         (unwind_on_signal_p): Likewise.
 316         (unwind_on_terminating_exception_p): Likewise.
 317         * infcmd.c (startup_with_shell): Likewise.
 318         * inferior.c (print_inferior_events): Likewise.
 319         * inferior.h (startup_with_shell): Likewise.
 320         (print_inferior_events): Likewise.
 321         * infrun.c (step_stop_if_no_debug): Likewise.
 322         (detach_fork): Likewise.
 323         (debug_displaced): Likewise.
 324         (disable_randomization): Likewise.
 325         (non_stop): Likewise.
 326         (non_stop_1): Likewise.
 327         (observer_mode): Likewise.
 328         (observer_mode_1): Likewise.
 329         (set_observer_mode): Update.
 330         (sched_multi): Change to bool.
 331         * infrun.h (debug_displaced): Likewise.
 332         (sched_multi): Likewise.
 333         (step_stop_if_no_debug): Likewise.
 334         (non_stop): Likewise.
 335         (disable_randomization): Likewise.
 336         * linux-tdep.c (use_coredump_filter): Likewise.
 337         (dump_excluded_mappings): Likewise.
 338         * linux-thread-db.c (auto_load_thread_db): Likewise.
 339         (check_thread_db_on_load): Likewise.
 340         * main.c (captured_main_1): Update.
 341         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
 342         xx2_opt, boolean_opt>: Change to bool.
 343         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
 344         * maint.c (maintenance_profile_p): Likewise.
 345         (per_command_time): Likewise.
 346         (per_command_space): Likewise.
 347         (per_command_symtab): Likewise.
 348         * memattr.c (inaccessible_by_default): Likewise.
 349         * mi/mi-main.c (mi_async): Likewise.
 350         (mi_async_1): Likewise.
 351         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
 352         * nat/fork-inferior.h (startup_with_shell): Likewise.
 353         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
 354         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
 355         * nios2-tdep.c (nios2_debug): Likewise.
 356         * or1k-tdep.c (or1k_debug): Likewise.
 357         * parse.c (parser_debug): Likewise.
 358         * parser-defs.h (parser_debug): Likewise.
 359         * printcmd.c (print_symbol_filename): Likewise.
 360         * proc-api.c (procfs_trace): Likewise.
 361         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
 362         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
 363         (set_parameter_value): Update.
 364         (add_setshow_generic): Update.
 365         * python/py-value.c (copy_py_bool_obj): Change argument from int*
 366         to bool*.
 367         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
 368         int*.
 369         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
 370         * record-btrace.c (record_btrace_target::store_registers): Update.
 371         * record-full.c (record_full_memory_query): Change to bool.
 372         (record_full_stop_at_limit): Likewise.
 373         * record-full.h (record_full_memory_query): Likewise.
 374         * remote-notif.c (notif_debug): Likewise.
 375         * remote-notif.h (notif_debug): Likewise.
 376         * remote.c (use_range_stepping): Likewise.
 377         (interrupt_on_connect): Likewise.
 378         (remote_break): Likewise.
 379         * ser-tcp.c (tcp_auto_retry): Likewise.
 380         * ser-unix.c (serial_hwflow): Likewise.
 381         * skip.c (debug_skip): Likewise.
 382         * solib-aix.c (solib_aix_debug): Likewise.
 383         * spu-tdep.c (spu_stop_on_load_p): Likewise.
 384         (spu_auto_flush_cache_p): Likewise.
 385         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
 386         Likewise.
 387         (struct info_print_options) <quiet>: Likewise.
 388         * symfile-debug.c (debug_symfile): Likewise.
 389         * symfile.c (auto_solib_add): Likewise.
 390         (separate_debug_file_debug): Likewise.
 391         * symfile.h (auto_solib_add): Likewise.
 392         (separate_debug_file_debug): Likewise.
 393         * symtab.c (basenames_may_differ): Likewise.
 394         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
 395         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
 396         (struct info_types_options) <quiet>: Likewise.
 397         * symtab.h (demangle): Likewise.
 398         (basenames_may_differ): Likewise.
 399         * target-dcache.c (stack_cache_enabled_1): Likewise.
 400         (code_cache_enabled_1): Likewise.
 401         * target.c (trust_readonly): Likewise.
 402         (may_write_registers): Likewise.
 403         (may_write_memory): Likewise.
 404         (may_insert_breakpoints): Likewise.
 405         (may_insert_tracepoints): Likewise.
 406         (may_insert_fast_tracepoints): Likewise.
 407         (may_stop): Likewise.
 408         (auto_connect_native_target): Likewise.
 409         (target_stop_and_wait): Update.
 410         (target_async_permitted): Change to bool.
 411         (target_async_permitted_1): Likewise.
 412         (may_write_registers_1): Likewise.
 413         (may_write_memory_1): Likewise.
 414         (may_insert_breakpoints_1): Likewise.
 415         (may_insert_tracepoints_1): Likewise.
 416         (may_insert_fast_tracepoints_1): Likewise.
 417         (may_stop_1): Likewise.
 418         * target.h (target_async_permitted): Likewise.
 419         (may_write_registers): Likewise.
 420         (may_write_memory): Likewise.
 421         (may_insert_breakpoints): Likewise.
 422         (may_insert_tracepoints): Likewise.
 423         (may_insert_fast_tracepoints): Likewise.
 424         (may_stop): Likewise.
 425         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
 426         (make_thread_apply_all_options_def_group): Change argument from int*
 427         to bool*.
 428         (thread_apply_all_command): Update.
 429         (print_thread_events): Change to bool.
 430         * top.c (confirm): Likewise.
 431         (command_editing_p): Likewise.
 432         (history_expansion_p): Likewise.
 433         (write_history_p): Likewise.
 434         (info_verbose): Likewise.
 435         * top.h (confirm): Likewise.
 436         (history_expansion_p): Likewise.
 437         * tracepoint.c (disconnected_tracing): Likewise.
 438         (circular_trace_buffer): Likewise.
 439         * typeprint.c (print_methods): Likewise.
 440         (print_typedefs): Likewise.
 441         * utils.c (debug_timestamp): Likewise.
 442         (sevenbit_strings): Likewise.
 443         (pagination_enabled): Likewise.
 444         * utils.h (sevenbit_strings): Likewise.
 445         (pagination_enabled): Likewise.
 446         * valops.c (overload_resolution): Likewise.
 447         * valprint.h (struct value_print_options) <prettyformat_arrays,
 448         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
 449         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
 450         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
 451         Likewise.
 452         * windows-nat.c (new_console): Likewise.
 453         (cygwin_exceptions): Likewise.
 454         (new_group): Likewise.
 455         (debug_exec): Likewise.
 456         (debug_events): Likewise.
 457         (debug_memory): Likewise.
 458         (debug_exceptions): Likewise.
 459         (useshell): Likewise.
 460         * windows-tdep.c (maint_display_all_tib): Likewise.
 461         * xml-support.c (debug_xml): Likewise.
 462
 463 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
 464
 465         * source.c (prepare_path_for_appending): New function.
 466         (openp): Make use of new function.
 467         (find_and_open_source): Search for the compilation directory and
 468         source file as a relative path beneath the directory search path.
 469
 470 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 471
 472         * source-cache.c (source_cache::get_line_charpos): Catch
 473         exceptions and return false, this matches the behaviour documented
 474         in the header file.
 475
 476 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
 477
 478         * ada-tasks.c (info_task): Remove quoting of the task's name.
 479
 480 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
 481
 482         * symfile.c (auto_solib_add): Replace comment with a reference
 483         to the header file.
 484
 485 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
 486
 487         * NEWS: Mention that gdb can now be compiled with Python 3
 488         on Windows.
 489
 490 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 491
 492         * maint.c (maint_print_section_data::maint_print_section_data):
 493         Force use of 'float log10 (float)' by casting the argument to
 494         float.
 495
 496 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 497
 498         * maint.c: Add 'cmath' include.
 499         (struct maint_print_section_data): New structure.
 500         (print_section_index): New function.
 501         (print_bfd_section_info): Add header comment, small whitespace
 502         cleanup, and update to call new print_section_index function.
 503         (print_objfile_section_info): Likewise.
 504         (maint_obj_section_from_bfd_section): New function.
 505         (print_bfd_section_info_maybe_relocated): New function.
 506         (maintenance_info_sections): Add header comment, always use
 507         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
 508
 509 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 510
 511         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
 512         inner scope, add check that the objfile has psymtabs before
 513         checking psymtabs_addrmap.
 514         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
 515
 516 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 517
 518         * NEWS: Announce that Ada task names are now shown at more places,
 519         and between quotes (except in info task output).
 520         * gdb/ada-tasks.c (task_to_str): New function.
 521         (display_current_task_id): Call task_to_str.
 522         (task_command_1): Likewise.
 523         (print_ada_task_info): In non-mi mode, Properly align headers and data
 524         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
 525
 526 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 527
 528         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
 529         prstatus.pr_lwp.pr_info instead of making it up.
 530
 531 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 532
 533         * auto-load.c (auto_load_expand_dir_vars): Update.
 534         * defs.h (gdb_datadir): Change to std::string.
 535         (python_libdir): Likewise.
 536         (relocate_gdb_directory): Change return type to std::string.
 537         * guile/guile.c (gdbscm_data_directory): Update.
 538         (initialize_scheme_side): Update.
 539         * jit.c (jit_reader_dir): Change to std::string.
 540         (jit_reader_load_command): Update.
 541         * main.c (gdb_datadir): Change to std::string.
 542         (python_libdir): Likewise.
 543         (set_gdb_data_directory): Update.
 544         (relocate_path): Change to return std::string.
 545         (relocate_gdb_directory): Change to return std::string.
 546         (relocate_gdbinit_path_maybe_in_datadir): Update.
 547         (captured_main_1): Update.
 548         * python/python.c (do_start_initialization): Update.
 549         * top.c (show_gdb_datadir): Update.
 550         * xml-syscall.c (xml_init_syscalls_info): Update.
 551         (init_syscalls_info): Update.
 552
 553 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 554
 555         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
 556         out of get_init_files.
 557         (get_init_files): Update.
 558
 559 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 560
 561         * main.c (get_init_files): Change to use std::string.
 562         (captured_main_1): Update.
 563         (print_gdb_help): Update.
 564
 565 2019-09-11  Ali Tamur  <tamur@google.com>
 566
 567         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
 568         implementation.
 569
 570 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 571
 572         * dbxread.c (read_dbx_symtab): Update.
 573         * dwarf2read.c (load_partial_dies): Update.
 574         * mdebugread.c (parse_partial_symbols): Update.
 575         (handle_psymbol_enumerators): Update.
 576         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
 577         * psymtab.c (add_psymbol_to_bcache): Likewise.
 578         (add_psymbol_to_list): Likewise.
 579         * symtab.c (symbol_set_names): Likewise.
 580         * symtab.h (symbol_set_names): Likewise.
 581         * xcoffread.c (scan_xcoff_symtab): Update.
 582
 583 2019-09-11  Tom Tromey  <tom@tromey.com>
 584
 585         * symfile-mem.c (symbol_file_add_from_memory): Use
 586         bfd_set_filename.
 587         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
 588         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
 589
 590 2019-09-10  Tom Tromey  <tromey@adacore.com>
 591
 592         * dwarf-index-write.c (write_psymbols): Extend error message.
 593         (debug_names::insert): Add Ada code.
 594         (debug_names::write_psymbols): Remove Ada check.
 595         (debug_names) <m_string_obstack>: New member.
 596         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
 597         (gdb_index_symbol_name_matcher::matches): Remove.
 598         (mapped_index_base::find_name_components_bounds): Add "lang"
 599         parameter.
 600         (mapped_index_base::build_name_components): Also split names
 601         according to Ada syntax.
 602         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
 603         type of "match_callback".
 604         (check_match, check_find_bounds_finds)
 605         (dw2_expand_symtabs_matching): Update.
 606         (dw2_debug_names_iterator): Add new constructor.
 607         (dw2_debug_names_map_matching_symbols): New function.
 608         (dw2_debug_names_expand_symtabs_matching): Update.
 609         (dwarf2_debug_names_functions): Use
 610         dw2_debug_names_map_matching_symbols.
 611
 612 2019-09-10  Tom Tromey  <tromey@adacore.com>
 613
 614         * dwarf2read.c (dw2_get_file_names_reader): Add the
 615         CU's file name to the results.
 616
 617 2019-09-10  Tom Tromey  <tromey@adacore.com>
 618
 619         * ada-lang.c (add_nonlocal_symbols): Combine calls to
 620         map_matching_symbols.  Update.
 621         * dwarf2read.c (dw2_map_matching_symbols): Update.
 622         * psymtab.c (match_partial_symbol): Change type; update.
 623         (psym_map_matching_symbols): Likewise.
 624         * symfile-debug.c (debug_qf_map_matching_symbols): Change
 625         type; update.
 626         * symfile.h (struct quick_symbol_functions)
 627         <map_matching_symbols>: Change "name" to be a lookup_name_info.
 628         Remove "match".
 629
 630 2019-09-10  Tom Tromey  <tromey@adacore.com>
 631
 632         * psymtab.c (map_block): Remove.
 633         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
 634         * symtab.c (iterate_over_symbols_terminated): New function.
 635         * symtab.c (iterate_over_symbols_terminated): Declare.
 636
 637 2019-09-10  Tom Tromey  <tromey@adacore.com>
 638
 639         * ada-lang.c (ada_iterate_over_symbols): Return bool.
 640         * language.h (struct language_defn) <la_iterate_over_symbols>:
 641         Return bool.
 642         * symtab.c (iterate_over_symbols): Return bool.
 643         * symtab.h (iterate_over_symbols): Return bool.
 644
 645 2019-09-10  Tom Tromey  <tromey@adacore.com>
 646
 647         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
 648         (add_nonlocal_symbols): Update.
 649         * dwarf2read.c (dw2_map_matching_symbols): Change type.
 650         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
 651         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
 652         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
 653         Change type of "callback".  Remove "data".
 654
 655
 656 2019-09-09  Ali Tamur  <tamur@google.com>
 657
 658         * dwarf2read.c (comp_unit_head): Update comment.
 659         (dwarf2_dwo_name): New function declaration.
 660         (dwarf_unit_type_name): New function declaration.
 661         (read_comp_unit_head): Add support for new compilation units,
 662         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
 663         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
 664         (currently named as "signature") in their header. Also clarify error
 665         messages.
 666         (lookup_dwo_id): New function. Returns the dwo id of the given
 667         compile unit.
 668         (lookup_dwo_unit): Use the new lookup_dwo_id function.
 669         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
 670         functions.
 671         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
 672         (dwarf2_dwo_name): Get the dwo name if present.
 673         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
 674         purposes.
 675
 676 2019-09-09  Tom Tromey  <tom@tromey.com>
 677
 678         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
 679
 680 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 681
 682         * python/python.c (do_start_initialization): Make progname_copy static,
 683         to avoid a leak report.
 684
 685 2019-09-08  Tom Tromey  <tom@tromey.com>
 686
 687         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
 688
 689 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
 690
 691         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
 692         Change type to gdb::optional<block_enum>.
 693         (dw2_symtab_iter_init): Change block_index parameter type
 694         to gdb::optional<block_enum>.
 695         (dw2_lookup_symbol): Change block_index parameter
 696         type to block_enum.c
 697         (dw2_debug_names_lookup_symbol): Likewise.
 698         * psymtab.c (psym_lookup_symbol): Likewise.
 699         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
 700         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
 701         Likewise.
 702
 703 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
 704
 705         * defs.h (relocate_gdb_directory): Change int to bool in
 706         signature and rename flag to relocatable.
 707         * main.c (relocate_path): Likewise.
 708         (relocate_gdb_directory): Likewise.
 709
 710 2019-09-06  Alan Modra  <amodra@gmail.com>
 711
 712         * coffread.c (coff_symfile_read): Constify filename variable.
 713         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
 714         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
 715         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
 716         * solib.c (reload_shared_libraries_1): Likewise.
 717         * symfile.c (reread_symbols): Likewise.
 718         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
 719         * solib-darwin.c (darwin_bfd_open): Likewise.
 720         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
 721
 722 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 723
 724         * psymtab.c (print_partial_symbols): Handle missing domain_enum
 725         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
 726
 727 2019-09-03  Tom Tromey  <tromey@adacore.com>
 728
 729         * ada-valprint.c (ada_val_print_num): Don't recurse for range
 730         types.
 731         (has_negatives): Unbias a range type bound.
 732         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
 733         * gdbtypes.c (operator==): Handle new field.
 734         (create_range_type): Add "bias" parameter.
 735         (create_static_range_type, resolve_dynamic_range): Update.
 736         * gdbtypes.h (struct range_bounds) <bias>: New member.
 737         (create_range_type): Add bias parameter.
 738         * printcmd.c (print_scalar_formatted): Unbias range types.
 739         * value.c (unpack_long): Unbias range types.
 740         (pack_long): Bias range types.
 741
 742 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 743
 744         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
 745         probe arguments.
 746
 747 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 748
 749         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
 750         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
 751         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
 752         (compile_probe_arg): Likewise.
 753         * probe.h (get_argument_count): Likewise.
 754         * solib-svr4.c (solib_event_probe_action): Likewise.
 755         * stap-probe.c (stap_probe::get_argument_count): Likewise.
 756
 757 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 758
 759         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
 760         code to here...
 761         (svr4_create_solib_event_breakpoints): ...from here.
 762
 763 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
 764
 765         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
 766         suffix from warning message.
 767
 768 2019-08-30  Tom Tromey  <tom@tromey.com>
 769
 770         * tui/tui-winsource.h (struct tui_source_window_base)
 771         <refresh_all>: Don't declare.
 772         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
 773         Remove.
 774         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
 775         tui_show_locator_content.
 776         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
 777         declare.
 778         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
 779         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
 780         declare.
 781
 782 2019-08-30  Tom Tromey  <tom@tromey.com>
 783
 784         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
 785
 786 2019-08-30  Tom Tromey  <tom@tromey.com>
 787
 788         * tui/tui-stack.c (_initialize_tui_stack): Move later.
 789         Remove unnecessary forward declarations.
 790
 791 2019-08-30  Tom Tromey  <tom@tromey.com>
 792
 793         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
 794         rerender.
 795         (tui_update_locator_fullname, tui_show_frame_info): Don't call
 796         tui_show_locator_content.
 797
 798 2019-08-30  Tom Tromey  <tom@tromey.com>
 799
 800         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
 801         (tui_locator_window::rerender): Rewrite using body of previous
 802         tui_show_locator_content.
 803
 804 2019-08-30  Tom Tromey  <tom@tromey.com>
 805
 806         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
 807         set_locator_fullname>: New methods.
 808         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
 809         Rename from tui_set_locator_fullname.
 810         (tui_locator_window::set_locator_info): Rename from
 811         tui_set_locator_info.  Return bool.
 812         (tui_update_locator_fullname, tui_show_frame_info): Update.
 813
 814 2019-08-30  Tom Tromey  <tom@tromey.com>
 815
 816         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
 817
 818 2019-08-30  Tom Tromey  <tom@tromey.com>
 819
 820         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
 821         call touchwin.
 822
 823 2019-08-30  Tom Tromey  <tom@tromey.com>
 824
 825         * tui/tui-wingeneral.c (box_win): Assume win_info and
 826         win_info->handle cannot be NULL.
 827
 828 2019-08-30  Tom Tromey  <tom@tromey.com>
 829
 830         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
 831         refresh_window>: Declare.
 832         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
 833         resize.
 834         (tui_data_item_window::rerender): Rename from
 835         tui_display_register.
 836         (tui_data_item_window::refresh_window): New method.
 837         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
 838         no-op.
 839
 840 2019-08-30  Tom Tromey  <tom@tromey.com>
 841
 842         * tui/tui-regs.h (struct tui_data_window) <regs_content,
 843         regs_column_count, current_group>: Move later.  Now private.
 844         <get_current_group>: New method.
 845         * tui/tui-regs.c (tui_reg_command): Update.
 846         * tui/tui-layout.c (tui_set_layout): Update.
 847
 848 2019-08-30  Tom Tromey  <tom@tromey.com>
 849
 850         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 851         (tui_data_window::rerender): Don't call
 852         check_and_display_highlight_if_needed.
 853         (tui_data_window::refresh_all): Remove call to
 854         erase_data_content.
 855
 856 2019-08-30  Tom Tromey  <tom@tromey.com>
 857
 858         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 859         (tui_data_window::display_registers_from)
 860         (tui_data_window::display_reg_element_at_line)
 861         (tui_data_window::display_registers_from_line): Remove checks of
 862         "empty".
 863
 864 2019-08-30  Tom Tromey  <tom@tromey.com>
 865
 866         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
 867         Don't declare.
 868         * tui/tui-regs.c (tui_data_window::show_registers): Call
 869         rerender.
 870         (tui_data_window::rerender): Rename from display_all_data.
 871         (tui_data_window::rerender): Remove old implementation.
 872
 873 2019-08-30  Tom Tromey  <tom@tromey.com>
 874
 875         * tui/tui-regs.c (tui_data_window::display_all_data): Change
 876         text.
 877         * tui/tui-data.h (NO_DATA_STRING): Remove define.
 878
 879 2019-08-29  Bernhard Wodok  <barto@gmx.net>
 880             Sergio Durigan Junior  <sergiodj@redhat.com>
 881
 882         PR win32/24284
 883         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
 884
 885 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 886
 887         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
 888         when searching for types.
 889
 890 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 891
 892         * f-lang.c (f_language_defn): Use f_print_typedef.
 893         * f-lang.h (f_print_typedef): Declare.
 894         * f-typeprint.c (f_print_typedef): Define.
 895
 896 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
 897
 898         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
 899
 900 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 901
 902         * cli/cli-utils.c (info_print_options_defs): Delete.
 903         (make_info_print_options_def_group): Delete.
 904         (extract_info_print_options): Delete.
 905         (info_print_command_completer): Delete.
 906         (info_print_args_help): Add extra parameter, and optionally
 907         include text about -n flag.
 908         * cli/cli-utils.h (struct info_print_options): Delete.
 909         (extract_info_print_options): Delete declaration.
 910         (info_print_command_completer): Delete declaration.
 911         (info_print_args_help): Add extra parameter, extend header
 912         comment.
 913         * python/python.c (gdbpy_rbreak): Pass additional parameter to
 914         search_symbols.
 915         * stack.c (struct info_print_options): New type.
 916         (info_print_options_defs): New file scoped variable.
 917         (make_info_print_options_def_group): New static function.
 918         (info_print_command_completer): New static function.
 919         (info_locals_command): Update to use new local functions.
 920         (info_args_command): Likewise.
 921         (_initialize_stack): Add extra parameter to calls to
 922         info_print_args_help.
 923         * symtab.c (search_symbols): Add extra parameter, use this to
 924         possibly excluse non-debug symbols.
 925         (symtab_symbol_info): Add extra parameter, which is passed on to
 926         search_symbols.
 927         (struct info_print_options): New type.
 928         (info_print_options_defs): New file scoped variable.
 929         (make_info_print_options_def_group): New static function.
 930         (info_print_command_completer): New static function.
 931         (info_variables_command): Update to use local functions, and pass
 932         extra parameter through to symtab_symbol_info.
 933         (info_functions_command): Likewise.
 934         (info_types_command): Pass additional argument through to
 935         symtab_symbol_info.
 936         (rbreak_command): Pass extra argument to search_symbols.
 937         (_initialize_symtab): Add extra arguments for calls to
 938         info_print_args_help, and update help text for 'info variables',
 939         'whereis', and 'info functions' commands.
 940         * symtab.h (search_symbols): Add extra argument to declaration.
 941         * NEWS: Mention new flags.
 942
 943 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
 944
 945         * symtab.c (lookup_static_symbol): Call the new function (and move
 946         it down to be next to lookup_global_symbol).
 947         (struct global_sym_lookup_data): Add block_enum member and rename to...
 948         (struct global_or_static_sym_lookup_data): ...this.
 949         (lookup_symbol_global_iterator_cb): Pass block_index instead of
 950         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
 951         (lookup_symbol_global_or_static_iterator_cb): ...this.
 952         (lookup_global_or_static_symbol): New function.
 953         (lookup_global_symbol): Call new function.
 954
 955 2019-08-26  Tom de Vries  <tdevries@suse.de>
 956
 957         PR c++/24852
 958         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
 959         when pc_probe.prob == NULL.
 960
 961 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 962
 963         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
 964         variable symbol_linkage to symbol_linkage_.
 965
 966 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 967
 968         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
 969         represent whether the symbol is static, dynamic, or we don't
 970         know.
 971
 972 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
 973
 974         * gdb/rx-tdep.c (rx_register_names): New.
 975         (rx_register_name): Delete.
 976         (rx_psw_type): Delete.
 977         (rx_fpsw_type): Delete.
 978         (rx_register_type): Delete.
 979         (rx_gdbarch_init): Convert target-descriptions.
 980         (_initialize_rx_tdep): Add initialize_tdesc_rx.
 981         * gdb/features/Makefile: Add rx.xml.
 982         * gdb/features/rx.xml: New.
 983         * gdb/features/rx.c: Generated.
 984         * gdb/NEWS: Mention target description support.
 985
 986 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 987
 988         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
 989         *slot_ptr.
 990
 991 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 992
 993         * configure.ac: Don't check for 'dlfcn.h' (moved to
 994         gdbsupport/common.m4).
 995         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
 996         'gdbsupport/'.
 997         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
 998         * compile/compile-c-support.c: Include
 999         'gdbsupport/gdb-dlfcn.h'.
1000         * gdbsupport/common.m4: Check for 'dlfcn.h'.
1001         * gdb-dlfcn.c: Move to...
1002         * gdbsupport/gdb-dlfcn.c: ... here.
1003         * gdb-dlfcn.h: Move to...
1004         * gdbsupport/gdb-dlfcn.h: ... here.
1005
1006 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
1007
1008         * nios2-tdep.c (struct reg_value): Improve comments.  Make
1009         the offset field signed.
1010
1011 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1012
1013         * python/lib/gdb/__init__.py (_execute_file): New function.
1014         * python/python.c (python_run_simple_file): Call gdb._execute_file
1015         on Windows.
1016
1017 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1018
1019         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
1020         all uses as this was never set to anything but a zero value.
1021
1022 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
1023
1024         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
1025
1026 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
1027
1028         * tui/tui-data.h (tui_gen_win_info): Add an =default
1029         move constructor, required by some GCC versions.
1030
1031 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
1032
1033         * go32-nat.c (go32_sysinfo): Add hygon_p.
1034
1035 2019-08-20  Tom Tromey  <tom@tromey.com>
1036
1037         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
1038         line_from_reg_element_no, first_reg_element_no_inline,
1039         display_all_data, delete_data_content_windows,
1040         erase_data_content>: Now private.
1041
1042 2019-08-20  Tom Tromey  <tom@tromey.com>
1043
1044         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
1045         (tui_unhighlight_win, tui_highlight_win)
1046         (tui_win_info::make_window): Update.
1047         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
1048
1049 2019-08-20  Tom Tromey  <tom@tromey.com>
1050
1051         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1052         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1053         (MAX_PID_WIDTH): Move to tui-stack.c.
1054         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1055         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1056         (MAX_PID_WIDTH): Move from tui-data.h.
1057
1058 2019-08-20  Tom Tromey  <tom@tromey.com>
1059
1060         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
1061         * tui/tui-wingeneral.c (box_win): Change type of win_info.
1062         (box_win): Update.
1063         (tui_gen_win_info::make_window): Rename from tui_make_window.
1064         (tui_win_info::make_window): New method.
1065         (tui_gen_win_info::make_visible): Update.
1066         * tui/tui-source.c (tui_source_window::set_contents): Update.
1067         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
1068         (tui_data_window::display_registers_from): Update.
1069         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1070         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
1071         Declare.
1072         <can_box>: Remove.
1073         <title>: Remove.
1074         (struct tui_win_info) <make_window>: Declare.
1075         <can_box>: Now virtual.
1076         <title>: New member.
1077         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
1078         * tui/tui-command.c (tui_cmd_window::resize): Update.
1079
1080 2019-08-20  Tom Tromey  <tom@tromey.com>
1081
1082         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
1083         * tui/tui-regs.c (tui_data_window::show_registers): Update.
1084         (tui_data_window::check_register_values): Update.
1085
1086 2019-08-20  Tom Tromey  <tom@tromey.com>
1087
1088         * tui/tui-regs.h (struct tui_data_window): Use
1089         DISABLE_COPY_AND_ASSIGN.
1090         <regs_content>: Change type, removing unique_ptr.
1091         <tui_data_window>: Add move constructor.
1092         * tui/tui-regs.c (tui_data_window::show_registers)
1093         (tui_data_window::show_register_group)
1094         (tui_data_window::display_registers_from)
1095         (tui_data_window::display_registers_from)
1096         (tui_data_window::first_data_item_displayed)
1097         (tui_data_window::delete_data_content_windows)
1098         (tui_data_window::rerender, tui_data_window::refresh_window)
1099         (tui_data_window::check_register_values): Update.
1100
1101 2019-08-20  Tom Tromey  <tom@tromey.com>
1102
1103         * tui/tui-regs.h (struct tui_data_window) <show_registers,
1104         show_register_group>: Declare.
1105         (tui_show_register_group): Don't declare.
1106         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
1107         tui_show_registers.
1108         (tui_data_window::show_register_group): Rename from
1109         tui_show_register_group.
1110         (tui_data_window::check_register_values, tui_reg_command):
1111         Update.
1112         * tui/tui-layout.c (tui_set_layout): Update.
1113
1114 2019-08-20  Tom Tromey  <tom@tromey.com>
1115
1116         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
1117         Declare.
1118         (tui_check_register_values): Don't declare.
1119         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
1120         from tui_check_register_values.
1121         * tui/tui-hooks.c (tui_register_changed): Update.
1122
1123 2019-08-20  Tom Tromey  <tom@tromey.com>
1124
1125         * tui/tui-regs.c (tui_reg_layout): Move later.
1126         (tui_show_registers): Don't enable TUI mode or change layout.
1127
1128 2019-08-20  Tom Tromey  <tom@tromey.com>
1129
1130         * tui/tui-regs.h (struct tui_data_item_window)
1131         <~tui_data_item_window>: Remove.
1132         <content>: Now a unique_xmalloc_ptr.
1133         * tui/tui-regs.c (tui_register_format): Return a
1134         unique_xmalloc_ptr.
1135         (tui_get_register): Update.
1136         (~tui_data_item_window): Remove.
1137         (tui_data_window::display_registers_from, tui_display_register):
1138         Update.
1139         * tui/tui-io.h (tui_expand_tabs): Update.
1140         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
1141         Remove "col" parameter.
1142
1143 2019-08-20  Tom Tromey  <tom@tromey.com>
1144
1145         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
1146         field.
1147         * tui/tui-regs.c (~tui_data_item_window): Update.
1148
1149 2019-08-20  Tom Tromey  <tom@tromey.com>
1150
1151         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
1152         earlier.
1153
1154 2019-08-20  Tom Tromey  <tom@tromey.com>
1155
1156         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
1157
1158 2019-08-20  Tom Tromey  <tom@tromey.com>
1159
1160         * tui/tui-source.h (struct tui_source_window): Update.
1161         * tui/tui-regs.c (tui_show_registers): Update.
1162         * tui/tui-disasm.h (struct tui_disasm_window): Update.
1163         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
1164         (NO_REGS_STRING): Remove defines.
1165
1166 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
1167
1168         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
1169         unnecessary thread walk if remote doesn't support the packet.
1170
1171 2019-08-19  Tom Tromey  <tromey@adacore.com>
1172
1173         * python/py-value.c (value_has_field): Fix indentation.
1174
1175 2019-08-19  Tom Tromey  <tromey@adacore.com>
1176
1177         * printcmd.c (do_one_display, info_display_command): Update.
1178         * block.h (contained_in): Return bool.  Add allow_nested
1179         parameter.
1180         * block.c (contained_in): Return bool.  Add allow_nested
1181         parameter.
1182
1183 2019-08-19  Tom Tromey  <tom@tromey.com>
1184
1185         * configure: Rebuild.
1186         * configure.ac: Disallow the combination of -static-libstdc++ and
1187         source highlight.
1188         * source-cache.c (get_language_name): Handle rust.
1189         (source_cache::get_source_lines): Ignore highlighting exceptions.
1190
1191 2019-08-16  Tom Tromey  <tom@tromey.com>
1192
1193         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
1194         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
1195         (struct tui_source_window_base) <make_visible, refresh_window,
1196         resize>: Remove methods.
1197         <execution_info>: Remove field.
1198         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
1199         (tui_show_source_line, tui_source_window_base)
1200         (~tui_source_window_base): Update.
1201         (tui_source_window_base::resize)
1202         (tui_source_window_base::make_visible)
1203         (tui_source_window_base::refresh_window): Remove.
1204         (tui_source_window_base::update_exec_info): Update.
1205         * tui/tui-source.c (tui_source_window::set_contents): Update.
1206         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1207
1208 2019-08-16  Tom Tromey  <tom@tromey.com>
1209
1210         * tui/tui-hooks.c (tui_remove_hooks): Don't set
1211         deprecated_query_hook.
1212
1213 2019-08-16  Tom Tromey  <tom@tromey.com>
1214
1215         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1216         (tui_update_source_windows_with_line): Update.
1217         * tui/tui-source.h (struct tui_source_window)
1218         <show_symtab_source>: Declare.
1219         (tui_show_symtab_source): Don't declare.
1220         * tui/tui-source.c (tui_show_symtab_source): Rename from
1221         tui_show_symtab_source.
1222
1223 2019-08-16  Tom Tromey  <tom@tromey.com>
1224
1225         * tui/tui-winsource.h (struct tui_source_window_base)
1226         <set_contents>: Declare.
1227         * tui/tui-winsource.c
1228         (tui_source_window_base::update_source_window_as_is): Update.
1229         * tui/tui-source.h (struct tui_source_window) <set_contents>:
1230         Declare.
1231         (tui_set_source_content): Don't declare.
1232         * tui/tui-source.c (tui_source_window::set_contents): Rename from
1233         tui_set_source_content.
1234         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
1235         Declare.
1236         (tui_set_disassem_content): Don't declare.
1237         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
1238         tui_set_disassem_content.
1239
1240 2019-08-16  Tom Tromey  <tom@tromey.com>
1241
1242         * tui/tui-winsource.h (struct tui_source_window_base)
1243         <update_breakpoint_info>: Declare.
1244         (tui_update_breakpoint_info): Don't declare.
1245         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
1246         (tui_update_all_breakpoint_info): Update.
1247         (tui_source_window_base::update_breakpoint_info): Rename from
1248         tui_update_breakpoint_info.
1249         (tui_source_window_base::update_exec_info): Update.
1250
1251 2019-08-16  Tom Tromey  <tom@tromey.com>
1252
1253         * tui/tui-winsource.h (struct tui_source_window_base)
1254         <update_source_window>: Declare.
1255         (tui_update_source_window): Don't declare.
1256         * tui/tui-winsource.c
1257         (tui_source_window_base::update_source_window): Rename from
1258         tui_update_source_window.
1259         (tui_source_window_base::rerender): Update.
1260         * tui/tui-source.c (tui_source_window::maybe_update): Update.
1261         * tui/tui-disasm.c (tui_show_disassem)
1262         (tui_show_disassem_and_update_source)
1263         (tui_disasm_window::maybe_update): Update.
1264
1265 2019-08-16  Tom Tromey  <tom@tromey.com>
1266
1267         * tui/tui-winsource.h (struct tui_source_window_base)
1268         <update_source_window_as_is>: Declare.
1269         (tui_update_source_window_as_is): Don't declare.
1270         * tui/tui-winsource.c (tui_update_source_window): Update
1271         (tui_source_window_base::update_source_window_as_is): Rename from
1272         tui_update_source_window_as_is.
1273         (tui_source_window_base::refill): Update.
1274         * tui/tui-source.c (tui_show_symtab_source): Update.
1275         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
1276         Update.
1277
1278 2019-08-16  Tom Tromey  <tom@tromey.com>
1279
1280         * tui/tui-winsource.h (tui_update_source_window)
1281         (tui_update_source_window_as_is): Remove "noerror" parameter.
1282         * tui/tui-winsource.c (tui_update_source_window)
1283         (tui_update_source_window_as_is): Remove "noerror" parameter.
1284         (tui_update_source_windows_with_addr)
1285         (tui_update_source_windows_with_line)
1286         (tui_source_window_base::rerender)
1287         (tui_source_window_base::refill): Update.
1288         * tui/tui-source.h (tui_set_source_content)
1289         (tui_show_symtab_source): Remove "noerror" parameter.
1290         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
1291         parameter.
1292         (tui_show_symtab_source): Likewise.
1293         (tui_source_window::maybe_update): Update.
1294         * tui/tui-disasm.c (tui_show_disassem)
1295         (tui_show_disassem_and_update_source)
1296         (tui_disasm_window::do_scroll_vertical)
1297         (tui_disasm_window::maybe_update): Update.
1298
1299 2019-08-16  Tom Tromey  <tom@tromey.com>
1300
1301         * tui/tui.c (tui_is_window_visible): Update.
1302         * tui/tui-wingeneral.c (tui_make_window)
1303         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
1304         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
1305         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
1306         (tui_set_win_height_command, parse_scrolling_args): Update.
1307         * tui/tui-source.c (tui_source_window::style_changed): Update.
1308         * tui/tui-regs.c (tui_show_registers)
1309         (tui_data_window::first_data_item_displayed)
1310         (tui_data_window::delete_data_content_windows)
1311         (tui_check_register_values, tui_reg_command): Update.
1312         * tui/tui-disasm.c (tui_show_disassem): Update.
1313         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
1314         method.
1315         <is_visible>: Remove field.
1316         * tui/tui-data.c (tui_next_win, tui_prev_win)
1317         (tui_delete_invisible_windows): Update.
1318
1319 2019-08-16  Tom Tromey  <tom@tromey.com>
1320
1321         * tui/tui-winsource.h (struct tui_source_window_base)
1322         <m_has_locator>: Remove.
1323         * tui/tui-layout.c (show_source_disasm_command, show_data)
1324         (show_source_or_disasm_and_command): Update.
1325
1326 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
1327
1328         * NEWS (Other MI changes): New subsection.
1329         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
1330         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
1331         * arch-utils.c (default_get_pc_address_flags): New function.
1332         * arch-utils.h (default_get_pc_address_flags): New declaration.
1333         * gdbarch.sh: Add get_pc_address_flags.
1334         * gdbarch.c: Regenerate.
1335         * gdbarch.h: Likewise.
1336         * stack.c (print_pc): New function.
1337         (print_frame_info) (print_frame): Call print_pc.
1338
1339 2019-08-16  Tom de Vries  <tdevries@suse.de>
1340
1341         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
1342         print_objfile_section_info.
1343
1344 2019-08-15  Tom Tromey  <tom@tromey.com>
1345
1346         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
1347         calling update_cmdwin_start_line.
1348         * tui/tui-winsource.h (struct tui_source_window_base)
1349         <do_make_visible_with_new_height, set_new_height>: Don't declare.
1350         <rerender>: Declare.
1351         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
1352         Call rerender.
1353         (tui_source_window_base::set_new_height): Remove.
1354         (tui_source_window_base::rerender): Rename from
1355         do_make_visible_with_new_height.
1356         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
1357         resize method.
1358         (tui_win_info::make_invisible_and_set_new_height)
1359         (tui_win_info::make_visible_with_new_height): Remove.
1360         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
1361         Declare.
1362         * tui/tui-stack.c (tui_locator_window::rerender): New method.
1363         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
1364         do_make_visible_with_new_height>: Don't declare.
1365         <rerender>: Declare.
1366         * tui/tui-regs.c (tui_data_window::rerender): Rename from
1367         set_new_height.
1368         (tui_data_window::do_make_visible_with_new_height): Remove.
1369         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
1370         call tui_show_locator_content.
1371         (tui_gen_win_info::resize): Call rerender.
1372         (show_source_or_disasm_and_command): Don't call
1373         tui_show_locator_content.
1374         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
1375         method.
1376         (struct tui_win_info) <rerender>: Declare.
1377         <set_new_height, make_invisible_and_set_new_height,
1378         make_visible_with_new_height>: Don't declare.
1379         * tui/tui-data.c (tui_win_list::rerender): New method.
1380         * tui/tui-command.h (struct tui_cmd_window)
1381         <do_make_visible_with_new_height>: Don't declare.
1382         * tui/tui-command.c
1383         (tui_cmd_window::do_make_visible_with_new_height): Remove.
1384
1385 2019-08-15  Tom Tromey  <tromey@adacore.com>
1386
1387         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
1388         * ada-lang.c (ada_enum_name): Likewise.
1389
1390 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
1391
1392         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
1393         leading underscore.
1394         (GdbOutputErrorFile): Likewise.
1395         (global scope): Adjust constructor calls to GdbOutput{,Error}File
1396         accordingly.
1397         (execute_unwinders): Rename to have a leading underscore.
1398         (auto_load_packages): Likewise.
1399         (global scope): Adjust call to auto_load_packages accordingly.
1400         (GdbSetPythonDirectory): Likewise.
1401         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
1402         instead of execute_unwinders.
1403
1404 2019-08-15  Tom Tromey  <tom@tromey.com>
1405
1406         * tui/tui-layout.c (show_layout, show_source_disasm_command)
1407         (show_data): Don't change window visibility.
1408         (tui_gen_win_info::resize): Remove special case for command
1409         window.  Use wresize, when available.
1410         (show_source_or_disasm_and_command): Don't change window
1411         visibility.
1412         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
1413         <make_visible>: New method.
1414         * tui/tui-command.c (tui_cmd_window::resize): New method.
1415
1416 2019-08-15  Tom Tromey  <tom@tromey.com>
1417
1418         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
1419         (struct tui_source_windows): New.
1420         * tui/tui-winsource.c (tui_display_main): Update.
1421         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1422         (new_height_ok, parse_scrolling_args): Update.
1423         * tui/tui-layout.c (show_layout, show_data): Update.
1424         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
1425         (tui_add_to_source_windows): Don't declare.
1426         * tui/tui-data.c (source_windows, tui_source_windows)
1427         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
1428
1429 2019-08-15  Tom Tromey  <tom@tromey.com>
1430
1431         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
1432         Rename from reset.
1433         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
1434         * tui/tui-layout.c (show_source_disasm_command, show_data):
1435         Update.
1436         (tui_gen_win_info::resize): Rename.
1437         (show_source_or_disasm_and_command): Update.
1438         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
1439         reset.
1440
1441 2019-08-15  Tom Tromey  <tom@tromey.com>
1442
1443         * tui/tui-stack.c (tui_initialize_static_data): Remove.
1444         * tui/tui-interp.c (tui_interp::init): Don't call
1445         tui_initialize_static_data.
1446         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
1447
1448 2019-08-15  Tom Tromey  <tom@tromey.com>
1449
1450         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
1451         examine tui_win_list.
1452
1453 2019-08-15  Tom Tromey  <tom@tromey.com>
1454
1455         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
1456         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
1457         tui_clear_source_content.
1458         (tui_clear_source_content): Remove.
1459         (tui_source_window_base::do_erase_source_content): Hoist call to
1460         content.clear().
1461         * tui/tui-stack.c (tui_show_frame_info): Don't call
1462         tui_clear_source_content.
1463
1464 2019-08-15  Tom Tromey  <tom@tromey.com>
1465
1466         * tui/tui-winsource.h (struct tui_source_window_base)
1467         <do_erase_source_content>: New method.
1468         <erase_source_content>: New method.
1469         (tui_erase_source_content): Don't declare.
1470         * tui/tui-winsource.c (tui_clear_source_content): Update.
1471         (tui_source_window_base::do_erase_source_content): Rename from
1472         tui_erase_source_content.
1473         (tui_source_window_base::show_source_content): Update.
1474         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1475         * tui/tui-source.h (struct tui_source_window)
1476         <erase_source_content>: New method.
1477         * tui/tui-disasm.h (struct tui_disasm_window)
1478         <erase_source_content>: New method.
1479
1480 2019-08-15  Tom Tromey  <tom@tromey.com>
1481
1482         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
1483         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
1484         constructor.
1485         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
1486         * tui/tui-source.c (tui_set_source_content): Update.
1487         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1488
1489 2019-08-15  Tom Tromey  <tom@tromey.com>
1490
1491         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
1492         * tui/tui-winsource.c (tui_line_is_displayed): Move to
1493         tui-source.c.
1494         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
1495         Declare.
1496         * tui/tui-source.c (tui_source_window::line_is_displayed): New
1497         method.
1498         (tui_source_window::maybe_update): Update.
1499
1500 2019-08-15  Tom Tromey  <tom@tromey.com>
1501
1502         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
1503         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
1504         tui-disasm.c.
1505         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
1506         Declare.
1507         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
1508         method.
1509         (tui_disasm_window::maybe_update): Update.
1510
1511 2019-08-15  Tom Tromey  <tom@tromey.com>
1512
1513         * tui/tui-winsource.h (struct tui_source_window_base)
1514         <maybe_update>: Declare.
1515         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
1516         method.
1517         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
1518         Declare.
1519         * tui/tui-source.c (tui_source_window::maybe_update): New method.
1520         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
1521         Declare.
1522         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
1523
1524 2019-08-15  Tom Tromey  <tom@tromey.com>
1525
1526         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
1527
1528 2019-08-15  Tom Tromey  <tom@tromey.com>
1529
1530         * tui/tui-wingeneral.c: Include tui-stack.h.
1531         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
1532         (struct tui_locator_window): Move from tui-data.h.
1533         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
1534         (tui_initialize_static_data): Move from tui-data.c.
1535         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
1536         (struct tui_locator_window): Move to tui-stack.c.
1537         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
1538         (tui_initialize_static_data): Move to tui-stack.c.
1539
1540 2019-08-15  Tom Tromey  <tom@tromey.com>
1541
1542         * tui/tui-layout.c (show_source_disasm_command)
1543         (show_source_or_disasm_and_command): Use make_visible method, not
1544         tui_make_window.
1545         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
1546         Remove.
1547
1548 2019-08-15  Tom Tromey  <tom@tromey.com>
1549
1550         * tui/tui-wingeneral.h (tui_make_window): Update.
1551         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
1552         parameter.
1553         (tui_gen_win_info::make_visible): Update.
1554         * tui/tui-regs.c (tui_data_window::display_registers_from):
1555         Update.
1556         * tui/tui-layout.c (show_source_disasm_command)
1557         (show_source_or_disasm_and_command): Update.
1558         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
1559         (enum tui_box): Remove.
1560         (struct tui_win_info) <can_box>: New method.
1561         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
1562         method.
1563
1564 2019-08-15  Tom de Vries  <tdevries@suse.de>
1565
1566         * linux-nat-trad.c: Include gdbarch.h.
1567
1568 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
1569
1570         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
1571         register sizes.
1572
1573 2019-08-14  Tom Tromey  <tromey@adacore.com>
1574
1575         * darwin-nat.c: Include gdbarch.h.
1576         * darwin-nat-info.c: Include gdbarch.h.
1577
1578 2019-08-13  Tom Tromey  <tom@tromey.com>
1579
1580         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
1581         Remove.
1582         * tui/tui-data.c (tui_initialize_static_data): Update.
1583
1584 2019-08-13  Tom Tromey  <tom@tromey.com>
1585
1586         * tui/tui-winsource.h (struct tui_exec_info_window)
1587         <~tui_exec_info_window, maybe_allocate_content, get_content,
1588         m_content>: Remove.
1589         (struct tui_source_window_base) <set_exec_info_content,
1590         show_exec_info_content>: Don't declare.
1591         * tui/tui-winsource.c
1592         (tui_exec_info_window::maybe_allocate_content): Remove.
1593         (tui_source_window_base::update_exec_info): Rename from
1594         set_exec_info_content.
1595         (tui_source_window_base::show_exec_info_content)
1596         (tui_source_window_base::update_exec_info): Remove.
1597
1598 2019-08-13  Tom Tromey  <tom@tromey.com>
1599
1600         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
1601         declare.
1602         * tui/tui-winsource.c (tui_update_source_window_as_is)
1603         (tui_update_source_windows_with_addr, tui_erase_source_content):
1604         Update.
1605         (tui_clear_exec_info_content): Remove.
1606
1607 2019-08-13  Tom Tromey  <tom@tromey.com>
1608
1609         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
1610         declare.
1611         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
1612         call tui_erase_exec_info_content.
1613         (tui_clear_exec_info_content): Rename from
1614         tui_erase_exec_info_content.
1615         (tui_clear_exec_info_content): Delete.
1616
1617 2019-08-13  Tom Tromey  <tom@tromey.com>
1618
1619         * tui/tui-winsource.h (struct tui_source_window_base)
1620         <show_exec_info_content>: Declare.
1621         (tui_show_exec_info_content): Don't declare.
1622         * tui/tui-winsource.c
1623         (tui_source_window_base::show_exec_info_content): Rename from
1624         tui_show_exec_info_content.
1625         (tui_source_window_base::update_exec_info): Update.
1626
1627 2019-08-13  Tom Tromey  <tom@tromey.com>
1628
1629         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
1630         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
1631         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
1632         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
1633         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
1634         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
1635         ... here.
1636
1637 2019-08-13  Tom Tromey  <tom@tromey.com>
1638
1639         * tui/tui-winsource.h (struct tui_source_window_base)
1640         <update_exec_info>: Declare.
1641         (tui_update_exec_info): Don't declare.
1642         * tui/tui-winsource.c (tui_update_source_window_as_is)
1643         (tui_source_window_base::refresh_all)
1644         (tui_update_all_breakpoint_info): Update.
1645         (tui_source_window_base::update_exec_info): Rename from
1646         tui_update_exec_info.
1647         * tui/tui-stack.c (tui_show_frame_info): Update.
1648
1649 2019-08-13  Tom Tromey  <tom@tromey.com>
1650
1651         * tui/tui-winsource.h (struct tui_source_window_base)
1652         <set_exec_info_content>: Declare.
1653         (tui_set_exec_info_content): Don't declare.
1654         * tui/tui-winsource.c
1655         (tui_source_window_base::set_exec_info_content): Rename from
1656         tui_set_exec_info_content.
1657         (tui_update_exec_info): Update.
1658
1659 2019-08-13  Tom Tromey  <tom@tromey.com>
1660
1661         * tui/tui-winsource.h (struct tui_source_window_base)
1662         <show_source_content>: Declare.
1663         (tui_show_source_content): Don't declare.
1664         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1665         (tui_source_window_base::show_source_content): Rename from
1666         tui_show_source_content.
1667         (tui_source_window_base::refresh_all): Update.
1668         * tui/tui-layout.c (show_source_disasm_command)
1669         (show_source_or_disasm_and_command): Update.
1670
1671 2019-08-13  Tom Tromey  <tom@tromey.com>
1672
1673         * tui/tui-winsource.c (tui_erase_source_content)
1674         (tui_show_source_content, tui_source_window_base::refresh_all):
1675         Update.
1676         * tui/tui-wingeneral.h
1677         (tui_check_and_display_highlight_if_needed): Don't declare.
1678         * tui/tui-wingeneral.c
1679         (tui_win_info::check_and_display_highlight_if_needed): Rename from
1680         check_and_display_highlight_if_needed.
1681         * tui/tui-win.c (tui_rehighlight_all)
1682         (tui_win_info::make_visible_with_new_height): Update.
1683         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1684         (tui_data_window::erase_data_content)
1685         (tui_data_window::display_all_data): Update.
1686         * tui/tui-data.h (struct tui_win_info)
1687         <check_and_display_highlight_if_needed>: Declare.
1688
1689 2019-08-13  Tom Tromey  <tom@tromey.com>
1690
1691         * tui/tui-win.c (tui_resize_all): Call
1692         tui_delete_invisible_windows.
1693         * tui/tui-layout.c (show_layout): Call
1694         tui_delete_invisible_windows.
1695         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
1696         * tui/tui-data.c (tui_delete_invisible_windows): New function.
1697
1698 2019-08-13  Tom Tromey  <tom@tromey.com>
1699
1700         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
1701         tui_add_win_to_layout.
1702
1703 2019-08-13  Tom Tromey  <tom@tromey.com>
1704
1705         * tui/tui-layout.h (tui_default_win_height): Don't declare.
1706         * tui/tui-layout.c (tui_default_win_height): Now static.
1707
1708 2019-08-13  Tom Tromey  <tom@tromey.com>
1709
1710         * tui/tui-layout.c (show_layout): Unify all layout cases into a
1711         single switch.
1712         (show_source_disasm_command, show_source_or_disasm_and_command):
1713         Don't check current layout.
1714
1715 2019-08-13  Tom Tromey  <tom@tromey.com>
1716
1717         * tui/tui-wingeneral.c (make_all_visible): Remove.
1718         (tui_make_all_invisible): Simplify.
1719         * tui/tui-layout.c (tui_make_all_invisible): Move from
1720         tui-wingeneral.c; simplify.
1721         (show_layout): Hoist call to tui_make_all_invisible.
1722         (show_data): Don't call tui_make_all_invisible.
1723
1724 2019-08-13  Tom Tromey  <tom@tromey.com>
1725
1726         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
1727         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
1728
1729 2019-08-13  Tom Tromey  <tom@tromey.com>
1730
1731         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
1732         tui-data.c.
1733         (show_source_disasm_command, show_data)
1734         (show_source_or_disasm_and_command): Don't use
1735         tui_set_current_layout_to.
1736         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
1737         * tui/tui-data.c (current_layout, tui_current_layout): Move to
1738         tui-layout.c.
1739         (tui_set_current_layout_to): Remove.
1740
1741 2019-08-13  Tom Tromey  <tom@tromey.com>
1742
1743         * tui/tui-layout.c (tui_set_layout): Update.
1744         * tui/tui-data.h (struct tui_layout_def): Remove.
1745         (tui_layout_def): Don't declare.
1746         * tui/tui-data.c (layout_def): Remove.
1747         (tui_layout_def): Remove.
1748
1749 2019-08-13  Tom Tromey  <tom@tromey.com>
1750
1751         * tui/tui-winsource.h (struct tui_source_window_base)
1752         <clear_detail>: No longer "override".
1753         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
1754         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
1755         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
1756         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
1757         Remove.
1758         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
1759
1760 2019-08-13  Tom Tromey  <tromey@adacore.com>
1761
1762         * tracepoint.c: Don't include readline.h or history.h.
1763
1764 2019-08-12  Tom Tromey  <tom@tromey.com>
1765
1766         * configure: Rebuild.
1767         * configure.ac: Check for readline 7.
1768         * NEWS: Mention readline 7 requirement.
1769         * README: Update.
1770
1771 2019-08-12  Tom Tromey  <tom@tromey.com>
1772
1773         * mingw-hdep.c (gdb_select): Remove readline hack.
1774
1775 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1776
1777         * blockframe.c (find_pc_partial_function): Set *block to nullptr
1778         when the function fails.
1779
1780 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
1781
1782         * s390-tdep.c (s390_type_align): New function.
1783         (s390_gdbarch_init): Set it as type_align gdbarch method.
1784
1785 2019-08-09  Tom de Vries  <tdevries@suse.de>
1786
1787         PR gdb/24591
1788         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
1789         pc_low with relocation offset.
1790
1791 2019-08-07  Tom Tromey  <tromey@adacore.com>
1792
1793         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1794         (print_frame_args): Update.
1795         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
1796         Update.
1797         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1798         * frame.h (struct frame_arg): Add initializers.
1799         <error>: Now a unique_xmalloc_ptr.
1800
1801 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
1802
1803         * NEWS: Expand the Pointer Authentication entry.
1804         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
1805         (aarch64_frame_unmask_lr): ... to this.
1806         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
1807         Call aarch64_frame_unmask_lr.
1808         * frame.c (struct frame_info): Add "masked" variable.
1809         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
1810         (fprint_frame): Check for masked pc.
1811         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
1812         declarations.
1813         * python/py-framefilter.c (py_print_frame): Check for masked pc.
1814         * stack.c (print_frame): Check for masked pc.
1815
1816 2019-08-06  Tom Tromey  <tom@tromey.com>
1817
1818         * stabsread.c (patch_block_stabs, read_one_struct_field)
1819         (read_enum_type): Use obstack_strndup.
1820         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
1821         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
1822         * dwarf2read.c (guess_full_die_structure_name)
1823         (anonymous_struct_prefix): Use obstack_strndup.
1824         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
1825         * c-exp.y (yylex): Use obstack_strndup.
1826         * ada-exp.y (write_object_renaming, write_ambiguous_var)
1827         (write_var_or_type): Use obstack_strndup.
1828
1829 2019-08-06  Tom Tromey  <tom@tromey.com>
1830
1831         * symfile.c (reread_symbols): Use obstack_strdup.
1832         * stabsread.c (read_type): Use obstack_strdup.
1833         * gdb_obstack.h (obstack_strdup): New overload.
1834         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
1835         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
1836         (dwarf2_canonicalize_name): Use obstack_strdup.
1837         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
1838         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
1839         Use obstack_strdup.
1840
1841 2019-08-06  Tom Tromey  <tom@tromey.com>
1842
1843         * gdb_obstack.h (obstack_strdup): Define.
1844         * gdb_obstack.c (obstack_strdup): Don't define.
1845
1846 2019-08-06  Tom Tromey  <tom@tromey.com>
1847
1848         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
1849         obstack_strdup.
1850         * typeprint.c (typedef_hash_table::find_global_typedef): Use
1851         obstack_strdup.
1852         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
1853         * stabsread.c (common_block_start): Use obstack_strdup.
1854         * objfiles.c (set_objfile_main_name, objfile): Use
1855         obstack_strdup.
1856         * namespace.c (add_using_directive): Use obstack_strdup.
1857         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
1858         * jit.c (finalize_symtab): Use obstack_strdup.
1859         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
1860         (guess_partial_die_structure_name, partial_die_info::fixup)
1861         (dwarf2_name): Use obstack_strdup.
1862         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
1863         obstack_strdup.
1864         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
1865         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1866         obstack_strdup.
1867         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
1868
1869 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1870
1871         * unittests/help-doc-selftests.c: New file.
1872         * Makefile.in: Add the new file.
1873
1874 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1875
1876         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
1877         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
1878         the full first line, except when FOR_VALUE_PREFIX.  In this case,
1879         the trailing '.' is not output, and the first character is uppercased.
1880         (print_help_for_command): Update call to print_doc_line.
1881         (print_doc_of_command): Likewise.
1882         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
1883         * cli/cli-option.c (append_indented_doc): Do not append newline.
1884         (build_help_option): Append newline after first appended_indented_doc
1885         only if a second call is done.
1886         (build_help): Append 2 new lines before each option, except the first
1887         one.
1888         * compile/compile.c (_initialize_compile): Add new lines after
1889         %OPTIONS%, when not at the end of the help.
1890         Change help doc or code
1891         producing the help doc to respect the invariants.
1892         * maint-test-options.c (_initialize_maint_test_options): Likewise.
1893         Also removed the new line after 'Options:', as all other commands
1894         do not put an empty line between 'Options:' and the first option.
1895         * printcmd.c (_initialize_printcmd): Likewise.
1896         * stack.c (_initialize_stack): Likewise.
1897         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
1898         incorrectly telling COMMAND is optional.
1899         * ada-lang.c (_initialize_ada_language): Change help doc or code
1900         producing the help doc to respect the invariants.
1901         * ada-tasks.c (_initialize_ada_tasks): Likewise.
1902         * breakpoint.c (_initialize_breakpoint): Likewise.
1903         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
1904         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
1905         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
1906         * cli/cli-style.c (cli_style_option::add_setshow_commands,
1907         _initialize_cli_style): Likewise.
1908         * corelow.c (core_target_info): Likewise.
1909         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
1910         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
1911         * filesystem.c (_initialize_filesystem): Likewise.
1912         * frame.c (_initialize_frame): Likewise.
1913         * gnu-nat.c (add_task_commands): Likewise.
1914         * infcall.c (_initialize_infcall): Likewise.
1915         * infcmd.c (_initialize_infcmd): Likewise.
1916         * interps.c (_initialize_interpreter): Likewise.
1917         * language.c (_initialize_language): Likewise.
1918         * linux-fork.c (_initialize_linux_fork): Likewise.
1919         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
1920         * maint.c (_initialize_maint_cmds): Likewise.
1921         * memattr.c (_initialize_mem): Likewise.
1922         * printcmd.c (_initialize_printcmd): Likewise.
1923         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
1924         _RegEx): Likewise.
1925         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
1926         * record-btrace.c (_initialize_record_btrace): Likewise.
1927         * record-full.c (_initialize_record_full): Likewise.
1928         * record.c (_initialize_record): Likewise.
1929         * regcache-dump.c (_initialize_regcache_dump): Likewise.
1930         * regcache.c (_initialize_regcache): Likewise.
1931         * remote.c (add_packet_config_cmd, init_remote_threadtests,
1932         _initialize_remote): Likewise.
1933         * ser-tcp.c (_initialize_ser_tcp): Likewise.
1934         * serial.c (_initialize_serial): Likewise.
1935         * skip.c (_initialize_step_skip): Likewise.
1936         * source.c (_initialize_source): Likewise.
1937         * stack.c (_initialize_stack): Likewise.
1938         * symfile.c (_initialize_symfile): Likewise.
1939         * symtab.c (_initialize_symtab): Likewise.
1940         * target-descriptions.c (_initialize_target_descriptions): Likewise.
1941         * top.c (init_main): Likewise.
1942         * tracefile-tfile.c (tfile_target_info): Likewise.
1943         * tracepoint.c (_initialize_tracepoint): Likewise.
1944         * tui/tui-win.c (_initialize_tui_win): Likewise.
1945         * utils.c (add_internal_problem_command): Likewise.
1946         * valprint.c (value_print_option_defs): Likewise.
1947
1948 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
1949
1950         PR build/24886
1951         * configure.ac: Drop enable-libmcheck support.
1952         * configure, config.in: Rebuild.
1953         * libmcheck.m4: Remove.
1954         * acinclude.m4: Don't include it.
1955         * Makefile.in: Don't distribute it.
1956         * top.c (print_gdb_configuration): Don't mention it.
1957
1958 2019-08-06  Tom Tromey  <tom@tromey.com>
1959
1960         * utils.c (set_output_style): Sometimes pass stream to
1961         emit_style_escape.
1962         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
1963         * record-btrace.c (btrace_insn_history): Update.
1964         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
1965         method.
1966         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
1967         Update initializers.
1968         <m_uiout>: New field.
1969         <m_di>: Move lower.
1970         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1971         Remove "uiout" parameter.
1972         (dump_insns): Update.
1973         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
1974         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
1975
1976 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
1977
1978         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
1979         (error_in_psymtab_expansion): Likewise.
1980         (lookup_symbol_via_quick_fns): Likewise.
1981         (basic_lookup_transparent_type_quick): Likewise.
1982         (basic_lookup_transparent_type_1): Likewise.
1983
1984 2019-08-06  Tom Tromey  <tromey@adacore.com>
1985
1986         * source.c (last_source_error): Now bool.
1987         (print_source_lines_base): Make "noprint" bool.  Only open
1988         source file when last_source_visited changes.
1989
1990 2019-08-06  Tom Tromey  <tromey@adacore.com>
1991
1992         * annotate.c (annotate_source_line): Use g_source_cache.
1993         * source-cache.c (source_cache::get_plain_source_lines): Change
1994         parameters.  Populate m_offset_cache.
1995         (source_cache::ensure): New method.
1996         (source_cache::get_line_charpos): New method.
1997         (extract_lines): Move lower.  Change parameters.
1998         (source_cache::get_source_lines): Move lower.
1999         * source-cache.h (class source_cache): Update comment.
2000         <get_line_charpos>: New method.
2001         <get_source_lines>: Update comment.
2002         <clear>: Clear m_offset_cache.
2003         <get_plain_source_lines>: Change parameters.
2004         <ensure>: New method
2005         <m_offset_cache>: New member.
2006         * source.c (forget_cached_source_info_for_objfile): Update.
2007         (info_source_command): Use g_source_cache.
2008         (find_source_lines, open_source_file_with_line_charpos): Remove.
2009         (print_source_lines_base, search_command_helper): Use g_source_cache.
2010         * source.h (open_source_file_with_line_charpos): Don't declare.
2011         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
2012         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
2013         Use g_source_cache.
2014
2015 2019-08-06  Tom Tromey  <tromey@adacore.com>
2016
2017         * source-cache.c (source_cache::get_plain_source_lines):
2018         Remove "first_line" and "last_line" parameters.
2019         (source_cache::get_source_lines): Cache plain text.
2020         * source-cache.h (class source_cache)
2021         <get_plain_source_lines>: Update.
2022
2023 2019-08-06  Tom Tromey  <tromey@adacore.com>
2024
2025         * source-cache.c (extract_lines): No longer a method.
2026         Changed type of parameter.  Include final newline.
2027         (selftests::extract_lines_test): New function.
2028         (_initialize_source_cache): Likewise.
2029         * source-cache.h (class source_cache)
2030         <extract_lines>: Don't declare.
2031
2032 2019-08-06  Tom Tromey  <tromey@adacore.com>
2033
2034         * breakpoint.c (init_breakpoint_sal): Update.
2035         (breakpoint): Update.
2036         * breakpoint.h (struct breakpoint) <filter>: Now a
2037         unique_xmalloc_ptr.
2038
2039 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2040
2041         * NEWS: Mention dictionary access on blocks.
2042         * python/py-block.c (blpy_getitem): New function.
2043         (block_object_as_mapping): New struct.
2044         (block_object_type): Use new struct for tp_as_mapping field.
2045
2046 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2047
2048         * objfiles.h (objfile): Add a comment describing partial symbols.
2049
2050 2019-08-05  Tom Tromey  <tromey@adacore.com>
2051
2052         * compile/compile.c (_initialize_compile): Use _(), not N_().
2053         * thread.c (_initialize_thread): Use _(), not N_().
2054         * stack.c (_initialize_stack): Use _(), not N_().
2055         * printcmd.c (_initialize_printcmd): Use _(), not N_().
2056
2057 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
2058
2059         * dwarf2read.c (struct dw2_symtab_iterator):
2060         <want_specific_block>: Remove.
2061         <block_index>: Change type to gdb::optional.
2062         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
2063         change type of BLOCK_INDEX parameter to gdb::optional.
2064         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
2065         (dw2_lookup_symbol): Don't pass argument for
2066         WANT_SPECIFIC_BLOCK.
2067         (dw2_expand_symtabs_for_function): Don't pass argument for
2068         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
2069         (class dw2_debug_names_iterator)
2070         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
2071         parameter, change BLOCK_INDEX type to gdb::optional.
2072         <m_want_specific_block>: Remove.
2073         <m_block_index>: Change type to gdb::optional.
2074         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
2075         gdb::optional.  Re-write in function of gdb::optional.
2076         (dw2_debug_names_lookup_symbol): Don't pass argument for
2077         WANT_SPECIFIC_BLOCK.
2078         (dw2_debug_names_expand_symtabs_for_function): Don't pass
2079         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
2080         BLOCK_INDEX.
2081
2082 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2083
2084         * NEWS: Mention changes to "info sources" command.
2085
2086 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2087
2088         * symtab.c (filename_partial_match_opts): New struct type.
2089         (struct output_source_filename_data): New members
2090         regexp, c_regexp, partial_match.
2091         (output_source_filename): Use new members to decide to print file.
2092         (info_sources_option_defs): New variable.
2093         (make_info_sources_options_def_group, print_info_sources_header,
2094         info_sources_command_completer):
2095         New functions.
2096         (info_sources_command): Read new optional arguments.
2097         (_initialize_symtab): Update info sources help.
2098
2099 2019-08-02  Alexandre Oliva <oliva@adacore.com>
2100
2101         * ada-lang.c (exception_support_info_v0): Renamed from...
2102         (default_exception_support_info): ... this.  Create new
2103         definition for v1.
2104         (ada_has_this_exception_support): Look up catch_handlers_sym.
2105         (ada_exception_support_info_sniffer): Try v0 after default.
2106
2107 2019-08-01  Tom Tromey  <tromey@adacore.com>
2108
2109         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
2110         gdbarch.h.
2111
2112 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
2113
2114         * s12z-tdep.c: Fix include path for s12z-opc.h.
2115
2116 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
2117
2118         * NEWS: Require GNU make 3.82.
2119
2120 2019-07-16  Tom Tromey  <tom@tromey.com>
2121
2122         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
2123         declare.
2124
2125 2019-07-30  Tom Tromey  <tromey@adacore.com>
2126
2127         * block.c (contained_in): Remove BLOCK_FUNCTION check.
2128
2129 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
2130
2131         * printcmd.c (print_address_symbolic): Print negative offsets.
2132         (build_address_symbolic): Force signed arithmetic when computing
2133         offset.
2134
2135 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
2136
2137         PR/24474: Add a function to lookup static variables.
2138         * NEWS: Mention this new function.
2139         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
2140         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
2141         * python/python.c (python_GdbMethods): Add new function.
2142
2143 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
2144
2145         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
2146         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
2147         (objfpy_lookup_static_symbol): New function.
2148         (objfile_object_methods): Add new functions.
2149
2150 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2151
2152         * NEWS: Mention 'set|show print frame-info'.  Mention new
2153         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
2154         backtrace argument.  Mention that python frame filtering code
2155         is now consistent with what 'backtrace' command prints.
2156
2157 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2158
2159         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
2160         comments.
2161         (print_frame_info_auto, print_frame_info_source_line,
2162         print_frame_info_location, print_frame_info_source_and_location,
2163         print_frame_info_location_and_address, print_frame_info_short_location):
2164         New declarations.
2165         (struct frame_print_options): New member print_frame_info.
2166         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
2167         * stack.h (get_user_print_what_frame_info): New declaration.
2168         (frame_show_address): New declaration.
2169         * stack.c (print_frame_arguments_choices): New value 'presence'.
2170         (print_frame_info_auto, print_frame_info_source_line,
2171         print_frame_info_location, print_frame_info_source_and_location,
2172         print_frame_info_location_and_address, print_frame_info_short_location,
2173         print_frame_info_choices, print_frame_info_print_what): New definitions.
2174         (print_frame_args): Only print dots for args if print frame-arguments
2175         is 'presence'.
2176         (frame_print_option_defs): New element for "frame-info".
2177         (get_user_print_what_frame_info): New function.
2178         (frame_show_address): Make non static.  Move comment to stack.h.
2179         (print_frame_info_to_print_what): New function.
2180         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
2181         to decide what to print.
2182         (backtrace_command_1): Handle the new print_frame_arguments_presence
2183         value.
2184         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
2185         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
2186         (py_print_frame): In non-mi mode, use LOCATION as default for
2187         print_what, similarly to frame information printed directly by
2188         backtrace command. Handle frame-info user option in non MI mode.
2189
2190 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2191
2192         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
2193         Add case for debugging 32-bit target on 64-bit host.  Revise
2194         comment.
2195
2196 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2197
2198         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
2199         instead of find_function_entry_range_from_pc.
2200
2201 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2202
2203         * stack.c (find_frame_funname): Remove code which preferred
2204         minsym over symtab sym in "certain pathological cases".
2205
2206         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
2207         parameter.  Change type of "do_demangle" to bool.
2208         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2209         Pass suitable "prefer_sym_over_minsym" flag to
2210         build_address_symbolic().  Don't output "+" for negative offsets.
2211         * printcmd.c (print_address_symbolic): Update invocation of
2212         build_address_symbolic to include a "prefer_sym_over_minsym"
2213         flag.
2214         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
2215         Restrict cases in which use of minimal symbol is preferred to that
2216         of a found symbol.  Update comments.
2217
2218         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
2219         for entry pc when entry pc is out of range for that FDE.
2220
2221 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
2222
2223         PR gdb/24839:
2224         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
2225         type.
2226
2227 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
2228
2229         * python/py-objfile.c (add_separate_debug_file): Fix comment about
2230         this function's Python signature.
2231
2232
2233 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
2234
2235         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
2236         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2237         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2238         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
2239         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
2240
2241
2242 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
2243
2244         * h8300-tdep.c (h8300_register_name_common): New.
2245         h8300_register_name): Use h8300_register_name_common.
2246         (h8300s_register_name): Likewise.
2247         (h8300sx_register_name): Likewise.
2248         (h8300h_register_nam): New.
2249         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
2250
2251
2252 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
2253
2254         * arm-tdep.c (arm_skip_cmse_entry): New function.
2255         (arm_is_sgstubs_section): New function.
2256         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
2257
2258 2019-07-22  Tom Tromey  <tom@tromey.com>
2259
2260         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
2261         Don't self-assign.
2262
2263 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2264
2265         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
2266         type_print.
2267
2268 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2269
2270         * symtab.c (search_symbols): Adjust msymbol matching type arrays
2271         so that GDB doesn't match any msymbols when searching in the
2272         TYPES_DOMAIN.
2273         (print_symbol_info): Print using typedef_print or type_print based
2274         on the type of the symbol.  Add updated FIXME comment moved from...
2275         (_initialize_symtab): ... move and update FIXME comment to above.
2276
2277 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2278
2279         * NEWS: Mention adding -q option to "info types".
2280         * symtab.c (struct info_types_options): New struct.
2281         (info_types_options_defs): New variable.
2282         (make_info_types_options_def_group): New function.
2283         (info_types_command): Use gdb::option framework to parse options.
2284         (info_types_command_completer): New function.
2285         (_initialize_symtab): Extend the help text on "info types" and
2286         register command completer.
2287
2288 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
2289
2290         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
2291         (lookup_symbol_in_objfile): Change int to block_enum and add a
2292         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
2293
2294 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
2295
2296         * MAINTAINERS (Write After Approval): Add self.
2297
2298 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2299
2300         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
2301         instruction to the dummy code region.
2302
2303 2019-07-19  Tom Tromey  <tromey@adacore.com>
2304
2305         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
2306         (ARGSUSED, PARAMS, __func__): Remove rules.
2307
2308 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2309
2310         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
2311         * features/arm/arm-with-iwmmxt.c: Remove.
2312         * features/arm/arm-with-iwmmxt.xml: Remove.
2313         * features/arm/arm-with-m-fpa-layout.c: Remove.
2314         * features/arm/arm-with-m-fpa-layout.xml: Remove.
2315         * features/arm/arm-with-m-vfp-d16.c: Remove.
2316         * features/arm/arm-with-m-vfp-d16.xml: Remove.
2317         * features/arm/arm-with-m.c: Remove.
2318         * features/arm/arm-with-m.xml: Remove.
2319         * features/arm/arm-with-neon.c: Remove.
2320         * features/arm/arm-with-neon.xml: Remove.
2321         * features/arm/arm-with-vfpv2.c: Remove.
2322         * features/arm/arm-with-vfpv2.xml: Remove.
2323         * features/arm/arm-with-vfpv3.c: Remove.
2324         * features/arm/arm-with-vfpv3.xml: Remove.
2325
2326 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2327
2328         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
2329
2330 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2331
2332         * arch/aarch32.c (aarch32_create_target_description): Create
2333         target descriptions using features.
2334         * arch/arm.c (arm_create_target_description)
2335         (arm_create_mprofile_target_description): Likewise.
2336         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
2337
2338 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2339
2340         * Makefile.in: Add new files.
2341         * aarch32-tdep.c: New file.
2342         * aarch32-tdep.h: New file.
2343         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2344         Call aarch32_read_description.
2345         * arch/aarch32.c: New file.
2346         * arch/aarch32.h: New file.
2347         * arch/arm.c (arm_create_target_description)
2348         (arm_create_mprofile_target_description): New function.
2349         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
2350         (arm_create_target_description)
2351         (arm_create_mprofile_target_description): New declaration.
2352         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
2353         read_description functions.
2354         * arm-linux-nat.c (arm_linux_nat_target::read_description):
2355         Likewise.
2356         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2357         * arm-tdep.c (tdesc_arm_list): New variable.
2358         (arm_register_g_packet_guesses): Call create description functions.
2359         (arm_read_description) (arm_read_mprofile_description): New
2360         function.
2361         * arm-tdep.h (arm_read_description)
2362         (arm_read_mprofile_description): Add declaration.
2363         * configure.tgt: Add new files.
2364
2365 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
2366
2367         * top.c (new_ui_command): Open specified terminal just once.
2368
2369 2019-07-18  Tom Tromey  <tromey@adacore.com>
2370
2371         * symtab.c (main_name): Constify return type.
2372         * symfile.c (set_initial_language): Update.
2373         * symtab.h (main_name): Constify return type.
2374
2375 2019-07-17  Tom Tromey  <tom@tromey.com>
2376
2377         * tui/tui-winsource.c (tui_update_source_window)
2378         (tui_update_source_window_as_is)
2379         (tui_update_source_windows_with_line): Remove return.
2380         * tui/tui-disasm.c (tui_show_disassem)
2381         (tui_show_disassem_and_update_source): Remove return.
2382         * tui/tui.c (tui_reset): Remove return.
2383         * tui/tui-wingeneral.c
2384         (tui_check_and_display_highlight_if_needed): Remove return.
2385
2386 2019-07-17  Tom Tromey  <tom@tromey.com>
2387
2388         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
2389
2390 2019-07-17  Tom Tromey  <tom@tromey.com>
2391
2392         * tui/tui-winsource.h (struct tui_exec_info_window)
2393         (struct tui_source_window_base): Move from tui-data.h.
2394         * tui/tui-winsource.c: Move many method definitions from
2395         elsewhere.  Remove "structuring" comments.
2396         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
2397         (tui_source_window_base::refresh_window): Move to
2398         tui-winsource.c.
2399         * tui/tui-win.c (tui_source_window_base::refresh_all)
2400         (tui_source_window_base::update_tab_width)
2401         (tui_source_window_base::set_new_height)
2402         (tui_source_window_base::do_make_visible_with_new_height): Move to
2403         tui-winsource.c.
2404         * tui/tui-source.h: Update.
2405         * tui/tui-source.c (tui_source_window_base::reset): Move to
2406         tui-winsource.c.
2407         * tui/tui-disasm.h: Update.
2408         * tui/tui-data.h (struct tui_exec_info_window): Move to
2409         tui-winsource.h.
2410         (struct tui_source_window_base): Likewise.
2411         * tui/tui-data.c (tui_source_window_base::clear_detail)
2412         (tui_source_window_base, ~tui_source_window_base): Move to
2413         tui-winsource.c.
2414
2415 2019-07-17  Tom Tromey  <tom@tromey.com>
2416
2417         * tui/tui-win.c (tui_resize_all)
2418         (tui_source_window_base::update_tab_width)
2419         (tui_adjust_win_heights): Update.
2420         (tui_win_info::make_invisible_and_set_new_height): Rename from
2421         make_invisible_and_set_new_height.
2422         * tui/tui-data.h (struct tui_win_info)
2423         <make_invisible_and_set_new_height>: New method.
2424
2425 2019-07-17  Tom Tromey  <tom@tromey.com>
2426
2427         * tui/tui.c: Update.
2428         * tui/tui-source.h (struct tui_source_window): Move from
2429         tui-data.h.
2430         * tui/tui-layout.c: Update.
2431         * tui/tui-disasm.c: Update.
2432         * tui/tui-data.h (struct tui_source_window): Move to
2433         tui-source.h.
2434
2435 2019-07-17  Tom Tromey  <tom@tromey.com>
2436
2437         * tui/tui-disasm.h (struct tui_disasm_window): Move from
2438         tui-data.h.
2439         * tui/tui-data.h (struct tui_disasm_window): Move to
2440         tui-disasm.h.
2441
2442 2019-07-17  Tom Tromey  <tom@tromey.com>
2443
2444         * tui/tui-regs.h (struct tui_data_item_window): Move from
2445         tui-data.h.
2446         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
2447         * tui/tui-data.h (struct tui_data_item_window): Move to
2448         tui-regs.h.
2449         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
2450
2451 2019-07-17  Tom Tromey  <tom@tromey.com>
2452
2453         * tui/tui.c: Update.
2454         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
2455         (tui_cmd_window::max_height): Move to tui-command.c.
2456         * tui/tui-layout.c: Update.
2457         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
2458         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
2459         tui-command.c.
2460         * tui/tui-command.h (struct tui_cmd_window): Move from
2461         tui-data.h.
2462         * tui/tui-command.c: Remove "structuring" comments.
2463         (tui_cmd_window::clear_detail)
2464         (tui_cmd_window::do_make_visible_with_new_height)
2465         (tui_cmd_window::max_height): Move from elsewhere.
2466
2467 2019-07-17  Tom Tromey  <tom@tromey.com>
2468
2469         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
2470         Now static.
2471         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
2472         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
2473
2474 2019-07-17  Tom Tromey  <tom@tromey.com>
2475
2476         * tui/tui.c: Update.
2477         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
2478         tui-regs.c.
2479         * tui/tui-windata.h: Remove file.
2480         * tui/tui-windata.c: Remove file.
2481         * tui/tui-win.c (tui_data_window::set_new_height)
2482         (tui_data_window::do_make_visible_with_new_height): Move to
2483         tui-regs.c.
2484         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
2485         * tui/tui-regs.c: Remove "structuring" comments.
2486         (tui_data_window::first_data_item_displayed)
2487         (tui_data_window::delete_data_content_windows)
2488         (tui_data_window::erase_data_content)
2489         (tui_data_window::display_all_data)
2490         (tui_data_window::refresh_all)
2491         (tui_data_window::do_scroll_vertical)
2492         (tui_data_window::clear_detail, tui_data_window::set_new_height)
2493         (tui_data_window::do_make_visible_with_new_height)
2494         (tui_data_window::refresh_window): Move from elsewhere.
2495         (_initialize_tui_regs): Move to end of file.
2496         * tui/tui-layout.c: Update.
2497         * tui/tui-hooks.c: Update.
2498         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
2499         * tui/tui-data.c (tui_data_window::clear_detail): Move to
2500         tui-regs.c.
2501         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
2502
2503 2019-07-17  Tom Tromey  <tom@tromey.com>
2504
2505         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
2506         seen.
2507
2508 2019-07-17  Tom Tromey  <tom@tromey.com>
2509
2510         * tui/tui-win.c (tui_source_window_base::set_new_height)
2511         (tui_source_window_base::do_make_visible_with_new_height): Use
2512         m_has_locator field directly.
2513         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
2514         method.
2515         (struct tui_source_window_base) <has_locator>: Likewise.
2516
2517 2019-07-17  Tom Tromey  <tom@tromey.com>
2518
2519         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
2520         Don't declare.
2521         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
2522         Remove.
2523         * tui/tui-win.c (tui_source_window_base::set_new_height)
2524         (tui_source_window_base::set_new_height)
2525         (make_invisible_and_set_new_height)
2526         (tui_source_window_base::do_make_visible_with_new_height)
2527         (tui_source_window_base::do_make_visible_with_new_height):
2528         Update.
2529         * tui/tui-layout.c (show_source_disasm_command, show_data)
2530         (show_source_or_disasm_and_command): Update.
2531         * tui/tui-layout.c (show_layout): Update.
2532
2533 2019-07-17  Tom Tromey  <tom@tromey.com>
2534
2535         * tui/tui-layout.c (make_data_window): Remove.
2536         (show_data): Unify creation and re-initialization cases.
2537
2538 2019-07-17  Tom Tromey  <tom@tromey.com>
2539
2540         * tui/tui-layout.c (make_source_window, make_disasm_window):
2541         Remove.
2542         (show_data): Unify creation and re-initialization cases.
2543
2544 2019-07-17  Tom Tromey  <tom@tromey.com>
2545
2546         * tui/tui-layout.c (make_command_window): Remove.
2547         (show_source_disasm_command, show_source_or_disasm_and_command):
2548         Unify creation and re-initialization cases.
2549
2550 2019-07-17  Tom Tromey  <tom@tromey.com>
2551
2552         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
2553         creation and re-initialization cases.
2554
2555 2019-07-17  Tom Tromey  <tom@tromey.com>
2556
2557         * tui/tui-regs.c (tui_get_register): Return void.
2558
2559 2019-07-17  Tom Tromey  <tom@tromey.com>
2560
2561         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
2562         Simplify.
2563
2564 2019-07-17  Tom Tromey  <tom@tromey.com>
2565
2566         * tui/tui-layout.c (show_source_disasm_command): Simplify window
2567         resetting.
2568
2569 2019-07-17  Tom Tromey  <tom@tromey.com>
2570
2571         * tui/tui.h (tui_set_layout_by_name): Don't declare.
2572         * tui/tui-regs.c (tui_reg_layout): New function.
2573         (tui_show_registers, tui_reg_command): Use it.
2574         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
2575         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
2576         parameters.
2577         (tui_layout_command): Remove.
2578
2579 2019-07-17  Tom Tromey  <tom@tromey.com>
2580
2581         * tui/tui-layout.h (tui/tui-layout): Return void.
2582         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
2583
2584 2019-07-17  Tom Tromey  <tom@tromey.com>
2585
2586         * tui/tui-layout.c (show_source_disasm_command, show_data):
2587         Update.
2588         (reset_locator): Remove.
2589         (show_source_or_disasm_and_command): Update.
2590
2591 2019-07-17  Tom Tromey  <tom@tromey.com>
2592
2593         * tui/tui-source.c (tui_source_window_base::reset): Remove
2594         win_type parameter.
2595         * tui/tui-layout.c (make_command_window, make_source_window)
2596         (make_disasm_window, make_data_window)
2597         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
2598         (reset_locator, show_source_or_disasm_and_command): Update.
2599         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
2600         win_type parameter.
2601         (struct tui_source_window_base) <reset>: Likewise.
2602
2603 2019-07-17  Tom Tromey  <tom@tromey.com>
2604
2605         * tui/tui-layout.c (show_source_disasm_command): Use
2606         reset_locator.
2607         (reset_locator): New function.
2608         (init_and_make_win): Remove.
2609         (show_source_or_disasm_and_command): Use reset_locator.
2610
2611 2019-07-17  Tom Tromey  <tom@tromey.com>
2612
2613         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
2614         condition.
2615         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
2616         Remove condition.
2617         * tui/tui-source.c (tui_source_window_base::reset): New method.
2618         * tui/tui-layout.c (make_command_window): Don't call
2619         init_and_make_win.
2620         (make_source_window, make_disasm_window): Don't call
2621         make_source_or_disasm_window.
2622         (make_data_window): Don't call init_and_make_win.  Change calling
2623         convention.
2624         (show_source_disasm_command, show_data): Simplify.
2625         (make_source_or_disasm_window): Remove.
2626         (show_source_or_disasm_and_command): Simplify.
2627         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
2628         (struct tui_source_window_base) <reset>: Likewise.
2629         <execution_info>: Remove initializer.
2630         * tui/tui-data.c (tui_source_window_base): Initialize
2631         execution_info.
2632
2633 2019-07-17  Tom Tromey  <tom@tromey.com>
2634
2635         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
2636         variable.
2637
2638 2019-07-17  Tom Tromey  <tom@tromey.com>
2639
2640         * tui/tui.c (tui_rl_other_window): Update.
2641         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
2642         superclass method first.  Always iterate over regs_content.
2643         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
2644         method.
2645         * tui/tui-win.c (tui_set_focus_command): Update.
2646
2647 2019-07-17  Tom Tromey  <tom@tromey.com>
2648
2649         * tui/tui-win.c (tui_set_focus_command): Rename from
2650         tui_set_focus.  Call tui_enable.
2651         (tui_set_focus_command): Remove.
2652
2653 2019-07-17  Tom Tromey  <tom@tromey.com>
2654
2655         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
2656         refresh_window.
2657         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
2658         touchwin.
2659         (tui_data_window::refresh_window): Call refresh_window on data
2660         items.  Always call superclass refresh_window.
2661         (tui_win_info::refresh): Remove.
2662         (tui_source_window_base::refresh_window): Update.
2663         (tui_refresh_all): Update.
2664         * tui/tui-layout.c (show_source_disasm_command): Remove call to
2665         refresh_window.
2666         (show_source_or_disasm_and_command): Likewise.
2667         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
2668         (struct tui_source_window_base) <refresh>: Likewise.
2669
2670 2019-07-17  Tom Tromey  <tom@tromey.com>
2671
2672         * tui/tui-winsource.c (tui_clear_source_content)
2673         (tui_show_source_content): Update.
2674         * tui/tui-source.c (tui_source_window::showing_source_p): Check
2675         whether content is empty.
2676         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
2677         Remove.
2678
2679 2019-07-17  Tom Tromey  <tom@tromey.com>
2680
2681         * tui/tui-winsource.c (tui_erase_source_content): Clear the
2682         window's contents.
2683         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
2684         * tui/tui-source.c (tui_set_source_content_nil): Remove.
2685
2686 2019-07-17  Tom Tromey  <tom@tromey.com>
2687
2688         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
2689         (struct tui_data_item_window): Update.
2690
2691 2019-07-17  Tom Tromey  <tom@tromey.com>
2692
2693         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
2694         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
2695         defines.
2696
2697 2019-07-17  Tom Tromey  <tom@tromey.com>
2698
2699         * tui/tui-winsource.h (tui_erase_source_content)
2700         (tui_clear_source_content): Remove "display_prompt" parameter.
2701         * tui/tui-winsource.c (tui_update_source_window_as_is)
2702         (tui_update_source_windows_with_addr): Update.
2703         (tui_clear_source_content): Remove "display_prompt" parameter.
2704         (tui_erase_source_content): Likewise.  Simplify.
2705         (tui_show_source_content): Update.
2706         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2707         * tui/tui-stack.c (tui_show_frame_info): Update.
2708         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
2709         Remove defines.
2710
2711 2019-07-17  Tom Tromey  <tom@tromey.com>
2712
2713         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2714         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
2715         parameter.
2716         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
2717         parameter.
2718
2719 2019-07-17  Tom Tromey  <tom@tromey.com>
2720
2721         * tui/tui-winsource.c (tui_clear_source_content)
2722         (tui_show_source_content, tui_show_exec_info_content)
2723         (tui_clear_exec_info_content): Update.
2724         * tui/tui-stack.c (tui_show_locator_content): Update.
2725         (tui_show_frame_info): Update.
2726         * tui/tui-source.h (tui_source_window): Don't declare.
2727         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
2728         from tui_source_is_displayed.
2729         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
2730         Remove field.
2731         (struct tui_source_window_base) <content_in_use>: New field.  Now
2732         bool.
2733         (struct tui_source_window) <showing_source_p>: New method.
2734         (TUI_SRC_WIN): Change cast.
2735         * tui/tui-data.c (tui_initialize_static_data): Update.
2736
2737 2019-07-17  Tom Tromey  <tom@tromey.com>
2738
2739         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
2740         location_matches_p.
2741         * tui/tui-source.c (tui_source_window::location_matches_p): New
2742         method.
2743         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
2744         method.
2745         * tui/tui-data.h (struct tui_source_window_base)
2746         <location_matches_p>: New method.
2747         (struct tui_source_window, struct tui_disasm_window)
2748         <location_matches_p>: Likewise.
2749
2750 2019-07-17  Tom Tromey  <tom@tromey.com>
2751
2752         * tui/tui-win.c (tui_set_win_height_command): Rename from
2753         tui_set_win_height.
2754         (tui_set_win_height_command): Remove.
2755
2756 2019-07-17  Tom Tromey  <tom@tromey.com>
2757
2758         * tui/tui-source.c (tui_source_window): New constructor.  Add
2759         observer.
2760         (~tui_source_window): New destructor.
2761         (tui_source_window::style_changed): New method.
2762         * tui/tui-hooks.c (tui_redisplay_source): Remove.
2763         (tui_attach_detach_observers): Update.
2764         * tui/tui-data.h (struct tui_source_window): Make constructor not
2765         inline.  Add destructor.
2766         (struct tui_source_window) <style_changed>: New method.
2767         <m_observable>: New member.
2768
2769 2019-07-17  Tom Tromey  <tom@tromey.com>
2770
2771         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
2772         * tui/tui-win.c (tui_resize_all): Fix typo.
2773
2774 2019-07-17  Tom Tromey  <tom@tromey.com>
2775
2776         * tui/tui-wingeneral.h (tui_refresh_all): Update.
2777         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
2778         (tui_refresh_all): Remove "list" parameter.  Use foreach.
2779         * tui/tui-win.c (window_name_completer): Use foreach.
2780         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
2781         (update_tab_width): Likewise.
2782         * tui/tui-layout.c (show_layout): Update.
2783         * tui/tui-data.h (class tui_window_iterator): New.
2784         (struct all_tui_windows): New.
2785         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
2786
2787 2019-07-17  Tom Tromey  <tom@tromey.com>
2788
2789         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
2790         parameter.  Don't reference globals.
2791         (tui_reg_command): Update.
2792
2793 2019-07-17  Tom Tromey  <tom@tromey.com>
2794
2795         * tui/tui-regs.c (tui_show_registers): Simplify.
2796
2797 2019-07-17  Tom Tromey  <tom@tromey.com>
2798
2799         * tui/tui-regs.c (tui_show_registers): Update.
2800         (tui_show_register_group): Add win_info parameter.
2801
2802 2019-07-17  Tom Tromey  <tom@tromey.com>
2803
2804         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
2805         Rename from tui_display_reg_element_at_line.
2806         (tui_data_window::display_registers_from_line): Update.
2807         * tui/tui-data.h (struct tui_data_window)
2808         <display_reg_element_at_line>: New method.
2809
2810 2019-07-17  Tom Tromey  <tom@tromey.com>
2811
2812         * tui/tui-regs.h (tui_display_registers_from)
2813         (tui_display_registers_from_line): Don't declare.
2814         * tui/tui-windata.c (tui_data_window::display_all_data)
2815         (tui_data_window::refresh_all)
2816         (tui_data_window::do_scroll_vertical): Update.
2817         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
2818         from tui_display_registers_from.
2819         (tui_display_reg_element_at_line): Update.
2820         (tui_data_window::display_registers_from_line): Rename from
2821         tui_display_registers_from_line.
2822         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
2823         display_registers_from_line>: New methods.
2824
2825 2019-07-17  Tom Tromey  <tom@tromey.com>
2826
2827         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
2828         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
2829         from tui_erase_data_content.
2830         (tui_data_window::display_all_data)
2831         (tui_data_window::refresh_all)
2832         (tui_data_window::do_scroll_vertical): Update.
2833         * tui/tui-regs.c (tui_show_registers): Update.
2834         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
2835         New method.
2836
2837 2019-07-17  Tom Tromey  <tom@tromey.com>
2838
2839         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
2840         declare.
2841         * tui/tui-windata.c
2842         (tui_data_window::delete_data_content_windows): Rename from
2843         tui_delete_data_content_windows.
2844         (tui_data_window::display_all_data)
2845         (tui_data_window::do_scroll_vertical): Update.
2846         * tui/tui-data.h (struct tui_data_window)
2847         <delete_data_content_windows>: New method.
2848
2849 2019-07-17  Tom Tromey  <tom@tromey.com>
2850
2851         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
2852         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
2853
2854 2019-07-17  Tom Tromey  <tom@tromey.com>
2855
2856         * tui/tui-windata.h (tui_display_all_data): Don't declare.
2857         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
2858         from tui_display_all_data.
2859         * tui/tui-win.c
2860         (tui_data_window::do_make_visible_with_new_height): Update.
2861         * tui/tui-regs.c (tui_show_registers): Update.
2862         * tui/tui-layout.c (tui_set_layout): Update.
2863         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
2864         method.
2865
2866 2019-07-17  Tom Tromey  <tom@tromey.com>
2867
2868         * tui/tui-windata.h (tui_display_data_from): Don't declare.
2869         * tui/tui-windata.c (tui_display_data_from): Remove.
2870         (tui_data_window::refresh_all): Update.
2871
2872 2019-07-17  Tom Tromey  <tom@tromey.com>
2873
2874         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
2875         * tui/tui-windata.c (tui_display_data_from_line): Remove.
2876         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
2877         tui_display_registers_from_line.
2878         * tui/tui-regs.h (tui_display_registers_from_line): Update.
2879         * tui/tui-regs.c (tui_display_registers_from_line): Remove
2880         "force_display" parameter.
2881
2882 2019-07-17  Tom Tromey  <tom@tromey.com>
2883
2884         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
2885         declare.
2886         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
2887         Rename from tui_first_reg_element_no_inline.
2888         (tui_display_reg_element_at_line)
2889         (tui_display_registers_from_line): Update.
2890         * tui/tui-data.h (struct tui_data_window)
2891         <first_reg_element_no_inline>: New method.
2892
2893 2019-07-17  Tom Tromey  <tom@tromey.com>
2894
2895         * tui/tui-windata.c (tui_display_data_from)
2896         (tui_data_window::do_scroll_vertical): Update.
2897         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
2898         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
2899         Rename from tui_line_from_reg_element_no.
2900         (tui_display_registers_from_line): Update.
2901         * tui/tui-data.h (struct tui_data_window)
2902         <line_from_reg_element_no>: New method.
2903
2904 2019-07-17  Tom Tromey  <tom@tromey.com>
2905
2906         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
2907         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
2908         tui_last_regs_line_no.
2909         (tui_display_reg_element_at_line)
2910         (tui_display_registers_from_line): Update.
2911         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
2912         method.
2913
2914 2019-07-17  Tom Tromey  <tom@tromey.com>
2915
2916         PR tui/24722:
2917         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
2918         (tui_update_breakpoint_info): Add "being_deleted" parameter.
2919         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2920         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
2921         (tui_update_breakpoint_info): Likewise.
2922         * tui/tui-hooks.c (tui_event_create_breakpoint)
2923         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
2924         Update.
2925
2926 2019-07-17  Tom Tromey  <tom@tromey.com>
2927
2928         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
2929
2930 2019-07-17  Tom Tromey  <tom@tromey.com>
2931
2932         * tui/tui-winsource.c (tui_update_source_window_as_is)
2933         (tui_update_source_windows_with_addr): Update.
2934         * tui/tui-source.h (tui_set_source_content)
2935         (tui_show_symtab_source): Add "win_info" parameter.
2936         * tui/tui-source.c (tui_set_source_content): Add "win_info"
2937         parameter.
2938         (tui_show_symtab_source): Likewise.
2939
2940 2019-07-17  Tom Tromey  <tom@tromey.com>
2941
2942         * tui/tui-wingeneral.c
2943         (tui_check_and_display_highlight_if_needed): Check can_highlight.
2944
2945 2019-07-17  Tom Tromey  <tom@tromey.com>
2946
2947         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
2948         (struct tui_cmd_window) <can_scroll>: New method.
2949         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
2950         method.
2951
2952 2019-07-17  Tom Tromey  <tromey@adacore.com>
2953
2954         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
2955         do_field_signed>: Rename.  Change type of "value".
2956         * ui-out.c (ui_out::field_signed): Rename from field_int.
2957         Change type of "value".
2958         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
2959         type of "value".
2960         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
2961         do_field_int.  Change type of "value".
2962         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
2963         do_field_int.  Change type of "value".
2964         * tracepoint.c (trace_status_mi, tfind_1)
2965         (print_one_static_tracepoint_marker): Update.
2966         * thread.c (print_thread_info_1, print_selected_thread_frame):
2967         Update.
2968         * stack.c (print_frame, print_frame_info): Update.
2969         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
2970         Update.
2971         * source.c (print_source_lines_base): Update.
2972         * skip.c (info_skip_command): Update.
2973         * record-btrace.c (btrace_ui_out_decode_error)
2974         (btrace_call_history_src_line): Update.
2975         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
2976         Update.
2977         * progspace.c (print_program_space): Update.
2978         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
2979         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
2980         do_field_int.  Change type of "value".
2981         * mi/mi-out.c (mi_ui_out::do_table_begin)
2982         (mi_ui_out::do_table_header): Update.
2983         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
2984         type of "value".
2985         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
2986         (mi_cmd_data_list_changed_registers, output_register)
2987         (mi_cmd_data_read_memory, mi_load_progress)
2988         (mi_cmd_trace_frame_collected): Update.
2989         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
2990         Update.
2991         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
2992         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
2993         (mi_cmd_var_list_children, varobj_update_one): Update.
2994         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
2995         (mi_cmd_stack_list_args, list_arg_or_local): Update.
2996         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
2997         * inferior.c (print_inferior): Update.
2998         * gdb_bfd.c (print_one_bfd): Update.
2999         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3000         Update.
3001         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
3002         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
3003         do_field_int.  Change type of "value".
3004         * cli-out.c (cli_ui_out::do_field_signed): Rename from
3005         do_field_int.  Change type of "value".
3006         * breakpoint.c (watchpoint_check, print_breakpoint_location)
3007         (print_one_breakpoint_location, print_it_catch_fork)
3008         (print_one_catch_fork, print_it_catch_vfork)
3009         (print_one_catch_vfork, print_it_catch_solib)
3010         (print_it_catch_exec, print_it_ranged_breakpoint)
3011         (print_mention_watchpoint, print_mention_masked_watchpoint)
3012         (bkpt_print_it, update_static_tracepoint): Update.
3013         * break-catch-throw.c (print_it_exception_catchpoint): Update.
3014         * break-catch-syscall.c (print_it_catch_syscall): Update.
3015         * ada-tasks.c (print_ada_task_info): Update.
3016         * ada-lang.c (print_it_exception, print_mention_exception):
3017         Update.
3018
3019 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
3020
3021         PR breakpoints/24541
3022         * gdbarch.c: Regenerate.
3023         * gdbarch.h: Regenerate.
3024         * gdbarch.sh: Adjust return type and parameter types for
3025         'stap_adjust_register'.
3026         (i386_stap_adjust_register): Adjust signature and return new
3027         register name.
3028         * stap-probe.c (stap_parse_register_operand): Adjust use of
3029         'gdbarch_stap_adjust_register'.
3030
3031 2019-07-17  Tom Tromey  <tromey@adacore.com>
3032
3033         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
3034         declare VEC.
3035         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
3036         std::vector.
3037         (struct s390_process_info): Add initializers.
3038         (s390_add_process): Use new.
3039         (s390_linux_nat_target::low_forget_process): Use delete.
3040         (s390_linux_nat_target::low_new_fork)
3041         (s390_linux_nat_target::stopped_by_watchpoint)
3042         (s390_linux_nat_target::low_prepare_to_resume)
3043         (s390_linux_nat_target::insert_watchpoint)
3044         (s390_linux_nat_target::insert_hw_breakpoint)
3045         (s390_linux_nat_target::remove_watchpoint)
3046         (s390_linux_nat_target::remove_hw_breakpoint): Update.
3047
3048 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3049
3050         * aarch64-fbsd-nat.c: Include regcache.h.
3051         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
3052         argument.
3053         (aarch64_fbsd_nat_target::fetch_registers)
3054         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
3055         variable.
3056         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
3057
3058 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3059
3060         * fbsd-nat.c: Include gdbarch.h.
3061
3062 2019-07-15  Tom Tromey  <tromey@adacore.com>
3063
3064         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
3065
3066 2019-07-15  Tom Tromey  <tromey@adacore.com>
3067
3068         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
3069         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
3070         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
3071         * cli-out.c (cli_ui_out::do_field_int): New method.
3072         * ui-out.c (ui_out::field_unsigned): New method.
3073         * symfile.c (generic_load): Use field_unsigned.
3074         (print_transfer_performance): Likewise.
3075         * record-btrace.c (ui_out_field_uint): Remove.
3076         (btrace_call_history_insn_range, btrace_call_history): Use
3077         field_unsigned.
3078         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
3079         field_unsigned.
3080         * ui-out.h (class ui_out) <field_unsigned>: New method.
3081         <do_field_unsigned>: Likewise.
3082
3083 2019-07-15  Tom Tromey  <tromey@adacore.com>
3084
3085         * mi/mi-main.c (list_available_thread_groups): Use field_string.
3086         * mi/mi-interp.c (mi_memory_changed): Use field_string.
3087         * target.c (flash_erase_command): Use field_string.
3088         * infrun.c (print_signal_received_reason): Use field_string.
3089         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
3090         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
3091         field_string.
3092         * ada-tasks.c (print_ada_task_info): Use field_string.
3093
3094 2019-07-15  Tom Tromey  <tromey@adacore.com>
3095
3096         * target.c (flash_erase_command): Use field_core_addr.
3097         * symfile.c (generic_load): Use field_core_addr.
3098         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
3099         Use field_core_addr.
3100         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
3101         field_core_addr.
3102
3103 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3104
3105         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
3106         value if its desired type is smaller than a CORE_ADDR and signed.
3107
3108 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3109
3110         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
3111         of changes to field names, and use new is_reference field to
3112         decide if a property is a reference or not.
3113         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
3114         field.
3115         (struct dwarf2_property_baton): Update header comment, rename
3116         'referenced_type' to 'property_type' and update comments.
3117         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
3118         default property type, store in property baton, update to take
3119         accound of renamed field.
3120         (read_func_scope): Update call to attr_to_dynamic_prop.
3121         (read_array_type): Likewise.
3122         (dwarf2_per_cu_addr_sized_int_type): New function.
3123         (read_subrange_index_type): Move type finding code to
3124         dwarf2_per_cu_addr_sized_int_type.
3125         (read_subrange_type): Update calls to attr_to_dynamic_prop.
3126         (dwarf2_per_cu_addr_type): New function.
3127         (set_die_type): Update calls to attr_to_dynamic_prop.
3128
3129 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3130
3131         * dwarf2read.c (read_subrange_index_type): New function.
3132         (read_subrange_type): Move code into new function and call it.
3133         * gdbtypes.c (create_range_type): Add some asserts.
3134
3135 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3136
3137         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
3138         update return statements.
3139         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
3140         declaration, and update comment to match.
3141         * gdbtypes.c (resolve_dynamic_array): Update call to
3142         dwarf2_evaluate_property to match new return type.
3143
3144 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3145
3146         * valarith.c (value_subscripted_rvalue): Change lowerbound
3147         parameter type from int to LONGEST.
3148         * value.h (value_subscripted_rvalue): Likewise in declaration.
3149
3150 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3151
3152         * cli/cli-utils.c (info_print_command_completer): New function.
3153         * cli/cli-utils.h: Add 'completer.h' include, and forward
3154         declaration for 'struct cmd_list_element'.
3155         (info_print_command_completer): Declare.
3156         * stack.c (_initialize_stack): Add completer for 'info locals' and
3157         'info args'.
3158         * symtab.c (_initialize_symtab): Add completer for 'info
3159         variables' and 'info functions'.
3160         * NEWS: Mention completion for additional info commands.
3161
3162 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3163
3164         * cli/cli-utils.c (extract_info_print_args): Delete.
3165         (extract_arg_maybe_quoted): Delete.
3166         (info_print_options_defs): New variable.
3167         (make_info_print_options_def_group): New function.
3168         (extract_info_print_options): Define new function.
3169         * cli/cli-utils.h (extract_info_print_args): Delete.
3170         (struct info_print_options): New structure.
3171         (extract_info_print_options): Declare new function.
3172         * stack.c (info_locals_command): Update to use new
3173         extract_info_print_options, also add a header comment.
3174         (info_args_command): Likewise.
3175         * symtab.c (info_variables_command): Likewise.
3176         (info_functions_command): Likewise.
3177
3178 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3179
3180         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
3181         to extract string arguments.
3182         * common/common-utils.c (extract_string_maybe_quoted): New function.
3183         * common/common-utils.h (extract_string_maybe_quoted): Declare.
3184
3185 2019-07-11  Tom Tromey  <tromey@adacore.com>
3186
3187         * main.c (get_init_files): Use GDBINIT, not gdbinit.
3188         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
3189         * top.h (gdbinit): Don't declare.
3190         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
3191         into...
3192         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
3193         * top.c (gdb_init): Don't call init_cli_cmds.
3194         (gdbinit): Remove.
3195         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
3196
3197 2019-07-11  Tom Tromey  <tromey@adacore.com>
3198
3199         * python/py-inferior.c (add_thread_object): Don't use thread_obj
3200         after it has been moved.
3201
3202 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3203
3204         * valops.c (value_must_coerce_to_target): Change return type to
3205         bool.
3206         * value.h (value_must_coerce_to_target): Likewise.
3207
3208 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
3209
3210         * breakpoint.c (is_hardware_watchpoint): Remove
3211         forward-declaration.
3212         (is_masked_watchpoint): Change return type to bool.
3213         (is_tracepoint): Likewise.
3214         (is_breakpoint): Likewise.
3215         (is_hardware_watchpoint): Likewise.
3216         (is_watchpoint): Likewise.
3217         (is_no_memory_software_watchpoint): Likewise.
3218         (is_catchpoint): Likewise.
3219         (breakpoint_1): Make FILTER parameter's return type bool.
3220         is_masked_watchpoint): Change return type to bool.
3221         (save_breakpoints): Make FILTER parameter's return type bool.
3222         * breakpoint.h (is_breakpoint): Change return type to bool.
3223         (is_watchpoint): Likewise.
3224         (is_catchpoint): Likewise.
3225         (is_tracepoint): Likewise.
3226
3227 2019-07-10  Tom Tromey  <tom@tromey.com>
3228
3229         * defs.h: Don't include gdbarch.h.
3230         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
3231         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
3232         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
3233         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
3234         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
3235         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
3236         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
3237         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
3238         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
3239         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
3240         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
3241         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
3242         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
3243         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
3244         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
3245         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
3246         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
3247         record-btrace.c, record.h, regcache-dump.c, regcache.h,
3248         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
3249         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
3250         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
3251         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
3252         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
3253         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
3254         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
3255         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
3256         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
3257
3258 2019-07-10  Tom Tromey  <tromey@adacore.com>
3259
3260         * ada-lang.h (is_ada_exception_catchpoint): Declare.
3261         * breakpoint.c (init_ada_exception_breakpoint): Register as
3262         bp_catchpoint.
3263         (print_one_breakpoint_location, print_one_breakpoint): Use
3264         is_ada_exception_catchpoint.
3265         * ada-lang.c (class ada_catchpoint_location): Pass
3266         bp_loc_software_breakpoint to bp_location constructor.
3267         (is_ada_exception_catchpoint): New function.
3268
3269 2019-07-10  Tom Tromey  <tromey@adacore.com>
3270
3271         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
3272         VEC.
3273         (struct arm_exidx_entry): New method operator<.
3274         (struct arm_exidx_data) <section_maps>: Change type.
3275         (arm_exidx_data_free): Remove.
3276         (arm_exidx_data_key): Change type.  Move lower.
3277         (arm_exidx_new_objfile): Update.
3278         (arm_compare_exidx_entries): Remove.
3279         (arm_find_exidx_entry, _initialize_arm_tdep)
3280
3281 2019-07-10  Tom Tromey  <tromey@adacore.com>
3282
3283         * solib-spu.c (ocl_program_data_key): Change type.
3284         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
3285         Update.
3286
3287 2019-07-10  Tom Tromey  <tromey@adacore.com>
3288
3289         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
3290         (struct solib_aix_inferior_data) <library_list>: Change type.
3291         (solib_aix_inferior_data_handle): Change type.
3292         (get_solib_aix_inferior_data): Update.
3293         (solib_aix_free_library_list): Remove.
3294         (library_list_start_library): Update.
3295         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
3296         return type.
3297         (solib_aix_get_library_list)
3298         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
3299         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
3300
3301 2019-07-10  Tom Tromey  <tromey@adacore.com>
3302
3303         * solib-dsbt.c (struct dsbt_info): Add initializers.
3304         (solib_dsbt_pspace_data): Change type.
3305         (dsbt_pspace_data_cleanup): Remove.
3306         (get_dsbt_info, _initialize_dsbt_solib): Update.
3307
3308 2019-07-10  Tom Tromey  <tromey@adacore.com>
3309
3310         * spu-tdep.c (spu_overlay_data): Change type.
3311         (spu_get_overlay_table, spu_overlay_new_objfile)
3312         (_initialize_spu_tdep): Update.
3313
3314 2019-07-10  Tom Tromey  <tromey@adacore.com>
3315
3316         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
3317         destructor.
3318         (dbx_objfile_data_key): Change type and declare later.
3319         (DBX_SYMFILE_INFO): Rewrite.
3320         * dbxread.c (dbx_objfile_data_key): Change type.
3321         (dbx_symfile_init): Update.
3322         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
3323         (coffstab_build_psymtabs, elfstab_build_psymtabs)
3324         (stabsect_build_psymtabs, _initialize_dbxread): Update.
3325
3326 2019-07-10  Tom Tromey  <tromey@adacore.com>
3327
3328         * jit.c (jit_program_space_key): Change type.  Move lower.
3329         (get_jit_program_space_data): Update.
3330         (jit_program_space_data_cleanup): Remove.
3331         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
3332         Update.
3333         (struct jit_program_space_data): Add initializers.
3334
3335 2019-07-10  Tom Tromey  <tromey@adacore.com>
3336
3337         * solib-darwin.c (struct darwin_info): Add initializers.
3338         (solib_darwin_pspace_data): Change type.
3339         (darwin_pspace_data_cleanup): Remove.
3340         (get_darwin_info, _initialize_darwin_solib): Update.
3341
3342 2019-07-10  Tom Tromey  <tromey@adacore.com>
3343
3344         * remote-sim.c (struct sim_inferior_data): Add initializers,
3345         constructor, and destructor.
3346         (sim_inferior_data_key): Change type.  Move lower.
3347         (check_for_duplicate_sim_descriptor): Update.
3348         (get_sim_inferior_data): Use new.  Update.
3349         (~sim_inferior_data_cleanup): Rename from
3350         sim_inferior_data_cleanup.  Simplify.
3351         (gdbsim_close_inferior, simulator_command)
3352         (sim_command_completer, _initialize_remote_sim): Update.
3353         (next_pid, INITIAL_PID): Move earlier.
3354
3355 2019-07-10  Tom Tromey  <tromey@adacore.com>
3356
3357         * python/python-internal.h (create_thread_object): Return
3358         gdbpy_ref.
3359         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
3360         * python/py-inferior.c (struct threadlist_entry): Add
3361         constructor.
3362         <thread_obj>: Now a gdbpy_ref.
3363         (thread_to_thread_object): Update.
3364         (add_thread_object): Use new.
3365         (delete_thread_object): Use delete.
3366         (infpy_threads): Update.
3367         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
3368         GIL.
3369
3370 2019-07-10  Tom Tromey  <tromey@adacore.com>
3371
3372         * valops.c (value_cast): Specialize error message for Ada.
3373
3374 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3375
3376         * breakpoint.c (breakpoint_1): Update doc and parameter names.
3377
3378 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3379
3380         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
3381         bpstat_should_step): Return bool, adjust comments.
3382         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
3383         bpstat_should_step): Likewise.
3384
3385 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3386
3387         * features/Makefile: Use feature target descriptions for Arm.
3388         * features/arm/arm-core.c: Generate new file.
3389         * features/arm/arm-fpa.c: Likewise.
3390         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
3391         * features/arm/arm-m-profile.c: Likewise.
3392         * features/arm/arm-vfpv2.c: Likewise.
3393         * features/arm/arm-vfpv3.c: Likewise.
3394         * features/arm/xscale-iwmmxt.c: Likewise.
3395         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
3396
3397 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3398
3399         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
3400         ptrace earlier.
3401
3402 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3403
3404         * features/aarch64-pauth.c: Regenerate.
3405
3406 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
3407
3408         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
3409         bool.
3410         (bpstat_what): Use false instead of 0.
3411
3412 2019-07-09  Pedro Alves  <palves@redhat.com>
3413
3414         * break-catch-throw.c (is_exception_catchpoint): New.
3415         * breakpoint.c (print_one_breakpoint_location): New parameter
3416         'raw_loc'.  Handle it.  Use
3417         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
3418         looking at the breakpoint's type.
3419         (print_one_breakpoint): If handling "maint info breakpoints", also
3420         print locations of exception catchpoints.
3421         * breakpoint.h (is_exception_catchpoint): Declare.
3422
3423 2019-07-09  Pedro Alves  <palves@redhat.com>
3424
3425         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
3426         "addr" field.
3427         (allocate_location_exception_catchpoint): New.
3428         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
3429         (initialize_throw_catchpoint_ops): Install
3430         allocate_location_exception_catchpoint as allocate_location
3431         method.
3432         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
3433         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
3434         bp_loc_other.
3435         (breakpoint_address_is_meaningful): Delete.
3436         (bl_address_is_meaningful): New.
3437         (breakpoint_locations_match): Adjust comment.
3438         (bp_location_from_bp_type): New, factored out of...
3439         (bp_location::bp_location(breakpoint *)): ... this.
3440         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
3441         factored out of...
3442         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
3443         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
3444         breakpoint_address_is_meaningful.
3445         (bp_locations_compare): Adjust comment.
3446         (update_global_location_list): Use bl_address_is_meaningful
3447         instead of breakpoint_address_is_meaningful.
3448         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
3449         explicit.
3450         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
3451         * python/py-breakpoint.c (bppy_get_location): No longer check
3452         whether location is null.
3453
3454 2019-07-09  Pedro Alves  <palves@redhat.com>
3455
3456         PR c++/15468
3457         * breakpoint.c (print_one_breakpoint_location): Remove
3458         single-location assert.
3459
3460 2019-07-09  Tom Tromey  <tom@tromey.com>
3461
3462         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
3463         * configure: Rebuild.
3464         * configure.ac: Change common to gdbsupport.
3465         * gdbsupport: Rename from common.
3466         * acinclude.m4: Change common to gdbsupport.
3467         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
3468         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
3469         gdbsupport.
3470         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
3471         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
3472         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
3473         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
3474         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
3475         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
3476         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
3477         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
3478         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
3479         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
3480         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
3481         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
3482         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
3483         coff-pe-read.c, command.h, compile/compile-c-support.c,
3484         compile/compile-c.h, compile/compile-cplus-symbols.c,
3485         compile/compile-cplus-types.c, compile/compile-cplus.h,
3486         compile/compile-loc2c.c, compile/compile.c, completer.c,
3487         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
3488         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
3489         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
3490         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
3491         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
3492         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
3493         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
3494         features/aarch64-core.c, features/aarch64-fpu.c,
3495         features/aarch64-pauth.c, features/aarch64-sve.c,
3496         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
3497         features/i386/32bit-core.c, features/i386/32bit-linux.c,
3498         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
3499         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
3500         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
3501         features/i386/64bit-core.c, features/i386/64bit-linux.c,
3502         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
3503         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
3504         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
3505         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
3506         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
3507         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
3508         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
3509         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
3510         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
3511         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
3512         go32-nat.c, guile/guile.c, guile/scm-ports.c,
3513         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
3514         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
3515         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
3516         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
3517         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
3518         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
3519         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
3520         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
3521         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
3522         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
3523         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
3524         minsyms.c, mips-linux-tdep.c, namespace.h,
3525         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
3526         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
3527         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
3528         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
3529         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
3530         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
3531         nat/linux-waitpid.c, nat/mips-linux-watch.c,
3532         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
3533         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
3534         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
3535         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
3536         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
3537         procfs.c, producer.c, progspace.h, psymtab.h,
3538         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
3539         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
3540         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
3541         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
3542         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
3543         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
3544         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
3545         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
3546         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
3547         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
3548         target-memory.c, target.c, target.h, target/waitstatus.c,
3549         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
3550         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
3551         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
3552         unittests/array-view-selftests.c,
3553         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
3554         unittests/common-utils-selftests.c,
3555         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
3556         unittests/format_pieces-selftests.c,
3557         unittests/function-view-selftests.c,
3558         unittests/lookup_name_info-selftests.c,
3559         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
3560         unittests/mkdir-recursive-selftests.c,
3561         unittests/observable-selftests.c,
3562         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
3563         unittests/parse-connection-spec-selftests.c,
3564         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
3565         unittests/scoped_fd-selftests.c,
3566         unittests/scoped_mmap-selftests.c,
3567         unittests/scoped_restore-selftests.c,
3568         unittests/string_view-selftests.c, unittests/style-selftests.c,
3569         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
3570         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
3571         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
3572         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
3573         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
3574         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
3575
3576 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3577
3578         * linespec.c (decode_digits_list_mode): Set explicit_line to a
3579         bool value.
3580         (decode_digits_ordinary): Set explicit_line field in sal.
3581         * symtab.c (skip_prologue_sal): Don't skip prologue for a
3582         symtab_and_line that was set on an explicit line number in
3583         assembler code.  Do always update the recorded symtab and line if
3584         we do skip the prologue.
3585
3586 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3587
3588         * breakpoint.c (set_breakpoint_location_function): Remove
3589         explicit_loc parameter.
3590         (momentary_breakpoint_from_master): Update call to
3591         set_breakpoint_location_function.
3592         (add_location_to_breakpoint): Likewise.
3593
3594 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3595
3596         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
3597         required features based on default bfd type when no specific bfd
3598         is present.
3599
3600 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3601
3602         * NEWS: Mention that GDB printf and eval commands can now print
3603         C-style and Ada-style convenience var strings without
3604         calling the inferior.
3605         * printcmd.c (printf_c_string): Locally print GDB internal var
3606         instead of transiting via the inferior.
3607         (printf_wide_c_string): Likewise.
3608
3609 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3610
3611         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
3612
3613 2019-07-04  Tom Tromey  <tom@tromey.com>
3614
3615         PR tui/24724:
3616         * tui/tui-winsource.c (tui_clear_source_content): Update.
3617         (tui_source_window_base::set_is_exec_point_at): Fix comment.
3618         (tui_update_breakpoint_info): Update.
3619         (tui_set_exec_info_content): Update.
3620         * tui/tui-source.c (tui_set_source_content_nil): Update.
3621         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
3622         has_break.
3623         * tui/tui-data.h (enum tui_bp_flag): New.
3624         (tui_bp_flags): New enum flags type.
3625         (struct tui_source_element) <break_mode>: Change type.  Rename
3626         from has_break.
3627         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
3628         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
3629         constants.
3630         * tui/tui-winsource.h: Fix comment.
3631
3632 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3633
3634         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
3635         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
3636         (store_fpregs_to_thread)
3637         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3638         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
3639         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
3640         (IWMMXT_REGS_SIZE): Add define.
3641         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
3642         (fetch_vfp_regs, store_vfp_regs)
3643         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3644         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
3645
3646 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3647
3648         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
3649         defines.
3650         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
3651         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
3652         (ARM_INT_REGISTER_SIZE): ...to this.
3653         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
3654         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
3655         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
3656         (arm_linux_collect_gregset, supply_nwfpe_register)
3657         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
3658         defines.
3659         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
3660         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
3661         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
3662         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
3663         (arm_return_in_memory, arm_store_return_value)
3664         (arm_get_longjmp_target, arm_register_g_packet_guesses)
3665         (arm_record_ld_st_multiple): Likewise.
3666         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
3667         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
3668
3669 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3670
3671         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
3672         AARCH64_DISPLACED_MODIFIED_INSNS.
3673         * aarch64-tdep.c (struct aarch64_displaced_step_data)
3674         (aarch64_displaced_step_copy_insn): Likewise.
3675         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3676         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
3677         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
3678         ARM_DISPLACED_MODIFIED_INSNS.
3679         * arm-tdep.c (arm_gdbarch_init): Likewise.
3680         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3681         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
3682         (struct arm_displaced_step_closure): Use
3683         ARM_DISPLACED_MODIFIED_INSNS.
3684
3685 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3686
3687         * features/Makefile: Remove unused xml files.
3688         * features/aarch64.xml: Remove.
3689         * features/i386/amd64-avx-avx512-linux.xml: Remove.
3690         * features/i386/amd64-avx-avx512.xml: Remove.
3691         * features/i386/amd64-avx-linux.xml: Remove.
3692         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
3693         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
3694         * features/i386/amd64-avx-mpx-linux.xml: Remove.
3695         * features/i386/amd64-avx-mpx.xml: Remove.
3696         * features/i386/amd64-avx.xml: Remove.
3697         * features/i386/amd64-linux.xml: Remove.
3698         * features/i386/amd64-mpx-linux.xml: Remove.
3699         * features/i386/amd64-mpx.xml: Remove.
3700         * features/i386/amd64.xml: Remove.
3701         * features/i386/i386-avx-avx512-linux.xml: Remove.
3702         * features/i386/i386-avx-avx512.xml: Remove.
3703         * features/i386/i386-avx-linux.xml: Remove.
3704         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
3705         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
3706         * features/i386/i386-avx-mpx-linux.xml: Remove.
3707         * features/i386/i386-avx-mpx.xml: Remove.
3708         * features/i386/i386-avx.xml: Remove.
3709         * features/i386/i386-linux.xml: Remove.
3710         * features/i386/i386-mmx-linux.xml: Remove.
3711         * features/i386/i386-mmx.xml: Remove.
3712         * features/i386/i386-mpx-linux.xml: Remove.
3713         * features/i386/i386-mpx.xml: Remove.
3714         * features/i386/i386.xml: Remove.
3715         * features/i386/x32-avx-avx512-linux.xml: Remove.
3716         * features/i386/x32-avx-linux.xml: Remove.
3717         * features/i386/x32-linux.xml: Remove.
3718
3719 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3720
3721         * regformats/aarch64.dat: Remove.
3722         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
3723         * regformats/i386/amd64-avx-linux.dat: Remove.
3724         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
3725         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
3726         * regformats/i386/amd64-linux.dat: Remove.
3727         * regformats/i386/amd64-mpx-linux.dat: Remove.
3728         * regformats/i386/amd64.dat: Remove.
3729         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
3730         * regformats/i386/i386-avx-linux.dat: Remove.
3731         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
3732         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
3733         * regformats/i386/i386-linux.dat: Remove.
3734         * regformats/i386/i386-mmx-linux.dat: Remove.
3735         * regformats/i386/i386-mpx-linux.dat: Remove.
3736         * regformats/i386/i386.dat: Remove.
3737         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
3738         * regformats/i386/x32-avx-linux.dat: Remove.
3739         * regformats/i386/x32-linux.dat: Remove.
3740
3741 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3742
3743         * aarch64-tdep.c: Remove xml self tests.
3744         * amd64-linux-tdep.c: Likewise.
3745         * amd64-tdep.c: Likewise.
3746         * i386-linux-tdep.c: Likewise.
3747         * i386-tdep.c: Likewise.
3748
3749 2019-07-03  Pedro Alves  <palves@redhat.com>
3750
3751         PR cli/24732
3752         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
3753         (pipe_cmd_option_defs): New.
3754         (make_pipe_cmd_options_def_group): New.
3755         (pipe_command): Use gdb::option::process_options.
3756         (pipe_command_completer): New function.
3757         (_initialize_cli_cmds): Install completer for "pipe" command.
3758
3759 2019-07-03  Pedro Alves  <palves@redhat.com>
3760
3761         * cli/cli-option.c (union option_value) <string>: New field.
3762         (struct option_def_and_value): Add ctor, move ctor, dtor and
3763         use DISABLE_COPY_AND_ASSIGN.
3764         (option_def_and_value::clear_value): New.
3765         (parse_option, save_option_value_in_ctx, get_val_type_str)
3766         (add_setshow_cmds_for_options): Handle var_string.
3767         * cli-option.h (union option_def::var_address) <string>: New
3768         field.
3769         (struct string_option_def): New.
3770         * maint-test-options.c (struct test_options_opts): Add default
3771         ctor and use DISABLE_COPY_AND_ASSIGN.
3772         <string_opt>: New field.
3773         (test_options_opts::~test_options_opts): New.
3774         (test_options_opts::dump): Also dump "-string".
3775         (test_options_option_defs): Install "string.
3776
3777 2019-07-03  Pedro Alves  <palves@redhat.com>
3778
3779         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
3780         option_value with a null enumeration.
3781         (complete_options): Save the option values in the context.
3782         (save_option_value_in_ctx): New, factored out from ...
3783         (process_options): ... here.
3784         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
3785         of the function.
3786         * maint-test-options.c (test_options_opts::dump): New, factored
3787         out from ...
3788         (maintenance_test_options_command_mode): ... here.
3789         (maintenance_test_options_command_completion_result): Delete.
3790         (maintenance_test_options_command_completion_text): Update
3791         comment.
3792         (maintenance_show_test_options_completion_result): Change
3793         prototype.  Just print
3794         maintenance_test_options_command_completion_text.
3795         (save_completion_result): New.
3796         (maintenance_test_options_completer_mode): Pass options context to
3797         complete_options, and then save a dump.
3798         (_initialize_maint_test_options): Use add_cmd to install "maint
3799         show test-options-completion-result".
3800
3801 2019-07-03  Pedro Alves  <palves@redhat.com>
3802
3803         * NEWS (New commands): Mention "with" and "maint with".
3804         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
3805         (with_command, with_command_completer): New.
3806         (pipe_command): Adjust to new repeat_previous
3807         interface.
3808         (_initialize_cli_cmds): Install the "with" command and its "w"
3809         alias.
3810         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
3811         declarations.
3812         * cli/cli-setshow.c (parse_cli_var_uinteger)
3813         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
3814         argument strings for all var_types.
3815         (get_setshow_command_value_string): New, factored out from ...
3816         (do_show_command): ... this.
3817         * cli/cli-setshow.h: Include <string>.
3818         (get_setshow_command_value_string): Declare.
3819         * command.h (repeat_previous): Now returns const char *.  Adjust
3820         comment.
3821         * maint.c: Include "cli/cli-cmds.h".
3822         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
3823         (_initialize_maint_cmds): Register the "maintenance with" command.
3824         * top.c (repeat_previous): Move bits from pipe_command here:
3825         Return the saved command line, if any; error out if there's no
3826         command to relaunch.
3827
3828 2019-07-03  Pedro Alves  <palves@redhat.com>
3829
3830         * NEWS (New commands): Mention "maint set/show test-settings"
3831         instead of "maint test-settings".
3832         * maint-test-settings.c (maintenance_test_settings_list): Delete.
3833         (maintenance_test_settings_set_list): Rename to ...
3834         (maintenance_set_test_settings_list): ... this.
3835         (maintenance_test_settings_show_list): Rename to  ...
3836         (maintenance_show_test_settings_list): ... this.
3837         (maintenance_test_settings_cmd): Delete.
3838         (maintenance_test_settings_set_cmd): ...
3839         (maintenance_set_test_settings_cmd): ... this.
3840         (maintenance_test_settings_show_cmd): ...
3841         (maintenance_show_test_settings_cmd): ... this.
3842         (maintenance_test_settings_show_value_cmd):
3843         (maintenance_show_test_settings_value_cmd): ... this.
3844         (_initialize_maint_test_settings): No longer install the "maint
3845         test-settings" prefix command.  Rename "maint test-settings set"
3846         to "maint set test-settings", and "maint test-settings show" to
3847         "maint show test-settings".  Adjust all subcommands.
3848
3849 2019-07-03  Pedro Alves  <palves@redhat.com>
3850
3851         * maint-test-settings.c: Fix file's intro comment.  Replace all
3852         references to "test-options" with references to "test-settings",
3853         in comments.
3854
3855 2019-07-03  Pedro Alves  <palves@redhat.com>
3856
3857         * maint-test-settings.c (maintenance_test_settings_xxx)
3858         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
3859         New.
3860         (maintenance_test_settings_enums): Use them.
3861         (maintenance_test_settings_enum): Default to
3862         maintenance_test_settings_xxx.
3863         (_initialize_maint_test_settings): Initialize
3864         MAINTENANCE_TEST_SETTINGS_FILENAME.
3865
3866 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3867
3868         * breakpoint.h (remove_breakpoints_inf): Change return type to
3869         void, move function documentation here.
3870         * breakpoint.c (remove_breakpoints_inf): Change return type to
3871         void, move function documentation to header.
3872
3873 2019-07-02  Pedro Alves  <palves@redhat.com>
3874
3875         * NEWS (Completion improvements): Mention "info threads".
3876         * thread.c (struct info_threads_opts, info_threads_option_defs)
3877         (make_info_threads_options_def_group): New.
3878         (info_threads_command): Use gdb::option::process_options.
3879         (info_threads_command_completer): New.
3880         (_initialize_thread): Use gdb::option::build_help to build the
3881         help text for "info threads".
3882
3883 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3884
3885         * defs.h (generic_load): Move from here...
3886         * symfile.h (generic_load): ... to here.  Rename name parameter
3887         to args.
3888         * symfile.c (generic_load): Add comment.
3889
3890 2019-07-01  Tom Tromey  <tromey@adacore.com>
3891
3892         * dwarf2read.c
3893         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
3894         declaration of without_params.  Fix formatting.
3895
3896 2019-07-01  Tom Tromey  <tromey@adacore.com>
3897
3898         * ada-exp.y (find_primitive_type): Update.
3899         * ada-lang.h (ada_lookup_symbol): Update.
3900         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
3901         parameter.
3902         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
3903
3904 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3905
3906         PR breakpoints/24541
3907         * gdbarch.c: Regenerate.
3908         * gdbarch.h: Regenerate.
3909         * gdbarch.sh: Add 'stap_adjust_register'.
3910         * i386-tdep.c: Include '<unordered_set>'.
3911         (i386_stap_adjust_register): New function.
3912         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
3913         * stap-probe.c (stap_parse_register_operand): Call
3914         'gdbarch_stap_adjust_register'.
3915
3916 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3917
3918         PR python/24742
3919         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
3920         * python/python.c (do_start_initialization): Use 'xmalloc'
3921         instead of 'PyMem_Malloc'.
3922
3923 2019-06-28  Tom Tromey  <tromey@adacore.com>
3924
3925         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
3926         for Ada.
3927
3928 2019-06-27  Tom Tromey  <tromey@adacore.com>
3929
3930         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
3931         objfile_key.
3932         (arm_find_mapping_symbol, arm_record_special_symbol)
3933         (_initialize_arm_tdep): Update.
3934         (arm_objfile_data_free): Remove.
3935
3936 2019-06-27  Tom Tromey  <tromey@adacore.com>
3937
3938         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
3939         to cp_print_static_field.
3940
3941 2019-06-26  Tom Tromey  <tromey@adacore.com>
3942
3943         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
3944         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
3945         declare.
3946
3947 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3948
3949         * features/aarch64-core.c (create_feature_aarch64_core):
3950         Regenerate.
3951         * features/aarch64-core.xml: Add cpsr flags.
3952
3953 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3954
3955         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
3956         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
3957
3958 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3959
3960         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
3961         field.
3962         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
3963         use.
3964         (arm_record_special_symbol): Don't insert new symbol in sorted
3965         position, push it at the end.
3966
3967 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3968
3969         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
3970         (arm_mapping_symbol_s): Remove.
3971         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
3972         (arm_mapping_symbol_vec): New typedef.
3973         (struct arm_per_objfile): Add constructor.
3974         <section_maps>: Change type to
3975         std::unique_ptr<arm_mapping_symbol_vec[]>.
3976         (arm_compare_mapping_symbols): Remove.
3977         (arm_find_mapping_symbol): Adjust to section_maps type change.
3978         (arm_objfile_data_free): Call delete on arm_per_objfile.
3979         (arm_record_special_symbol): Adjust to section_maps type change.
3980         Allocate arm_per_objfile with new.
3981
3982 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3983
3984         * cli/cli-cmds.c (alias_command): Compare the alias prefix
3985         with the command prefix.
3986
3987 2019-06-25  Tom Tromey  <tom@tromey.com>
3988
3989         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
3990         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
3991
3992 2019-06-25  Tom Tromey  <tom@tromey.com>
3993
3994         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
3995         type.
3996         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
3997         protected.
3998
3999 2019-06-25  Tom Tromey  <tom@tromey.com>
4000
4001         * tui/tui-winsource.c
4002         (tui_source_window_base::set_is_exec_point_at): Add check against
4003         LOA_ADDRESS.
4004
4005 2019-06-25  Tom Tromey  <tom@tromey.com>
4006
4007         * tui/tui-source.c (tui_set_source_content): Don't check before
4008         xfree.
4009         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
4010
4011 2019-06-25  Tom Tromey  <tom@tromey.com>
4012
4013         * tui/tui-winsource.h (tui_update_source_window_as_is)
4014         (tui_alloc_source_buffer, tui_line_is_displayed)
4015         (tui_addr_is_displayed): Change type of win_info.
4016         * tui/tui-winsource.c (tui_update_source_window_as_is)
4017         (tui_clear_source_content, tui_show_source_line)
4018         (tui_show_source_content, tui_source_window_base::refill)
4019         (tui_source_window_base::set_is_exec_point_at)
4020         (tui_source_window_base::set_is_exec_point_at)
4021         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
4022         (tui_alloc_source_buffer, tui_line_is_displayed)
4023         (tui_addr_is_displayed): Change type of win_info.  Update.
4024         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4025         (tui_source_window_base::do_make_visible_with_new_height):
4026         Update.
4027         * tui/tui-source.c (tui_set_source_content)
4028         (tui_set_source_content_nil)
4029         (tui_source_window::do_scroll_vertical): Update.
4030         * tui/tui-layout.c (show_layout): Update.
4031         * tui/tui-disasm.c (tui_set_disassem_content)
4032         (tui_disasm_window::do_scroll_vertical): Update.
4033         * tui/tui-data.h (tui_win_content): Remove.
4034         (struct tui_gen_win_info) <content, content_size>: Remove.
4035         (struct tui_source_element): Add initializers and destructor.
4036         (union tui_which_element, struct tui_win_element): Remove.
4037         (struct tui_source_window_base) <content>: New field.
4038         (struct tui_data_window): Remove destructor.
4039         (tui_alloc_content, tui_free_win_content)
4040         (tui_free_all_source_wins_content): Don't declare.
4041         * tui/tui-data.c (tui_initialize_static_data): Update.
4042         (init_content_element, tui_alloc_content): Remove.
4043         (~tui_gen_win_info): Update.
4044         (~tui_data_window, tui_free_all_source_wins_content)
4045         (tui_free_win_content, free_content, free_content_elements):
4046         Remove.
4047
4048 2019-06-25  Tom Tromey  <tom@tromey.com>
4049
4050         * tui/tui-winsource.h (tui_clear_source_content)
4051         (tui_erase_source_content, tui_show_source_content): Change type
4052         of win_info.
4053         * tui/tui-winsource.c (tui_clear_source_content)
4054         (tui_erase_source_content, tui_show_source_content): Change type
4055         of win_info.
4056         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4057         * tui/tui-source.h (tui_set_source_content_nil): Change type of
4058         win_info.
4059         * tui/tui-source.c (tui_set_source_content_nil): Change type of
4060         win_info.
4061         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
4062
4063 2019-06-25  Tom Tromey  <tom@tromey.com>
4064
4065         * tui/tui-winsource.c (tui_clear_source_content)
4066         (tui_source_window_base::set_is_exec_point_at): Update.
4067         * tui/tui-source.c (tui_set_source_content_nil): Update.
4068         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
4069         a bool.
4070         * tui/tui-data.c (init_content_element): Update.
4071
4072 2019-06-25  Tom Tromey  <tom@tromey.com>
4073
4074         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
4075         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
4076         * tui/tui-layout.c (init_and_make_win): Update.
4077         * tui/tui.h (enum tui_win_type): Update.
4078         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
4079         tui_win_is_auxillary.
4080         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
4081         tui_win_is_auxillary.
4082
4083 2019-06-25  Tom Tromey  <tom@tromey.com>
4084
4085         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
4086         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
4087         (tui_delete_data_content_windows, tui_display_all_data)
4088         (tui_data_window::do_scroll_vertical, tui_display_data_from):
4089         Update.
4090         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
4091         * tui/tui-regs.c (tui_last_regs_line_no)
4092         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4093         (tui_show_registers): Update.
4094         (tui_show_register_group): Return void.  Update.
4095         (tui_display_registers_from, tui_display_reg_element_at_line)
4096         (tui_display_registers_from_line, tui_check_register_values):
4097         Update.
4098         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
4099         member.
4100         (struct tui_data_window) <regs_content>: Now a std::vector.
4101         <regs_content_count>: Remove.
4102         (tui_add_content_elements, tui_free_data_content): Don't declare.
4103         * tui/tui-data.c (tui_data_window::clear_detail): Update.
4104         (init_content_element): Remove DATA_WIN case.  Add assert.
4105         (tui_add_content_elements): Remove.
4106         (tui_data_window): Update.
4107         (tui_free_data_content): Remove.
4108         (free_content_elements): Remove DATA_WIN case.
4109
4110 2019-06-25  Tom Tromey  <tom@tromey.com>
4111
4112         * tui/tui-data.c (tui_data_item_window): Update.
4113         * tui/tui-windata.h (tui_check_data_values): Don't declare.
4114         * tui/tui-windata.c (tui_display_all_data)
4115         (tui_display_data_from_line): Update.
4116         (tui_check_data_values): Remove.
4117         * tui/tui-regs.c (tui_show_register_group)
4118         (tui_display_reg_element_at_line): Update.
4119         * tui/tui-hooks.c (tui_register_changed)
4120         (tui_refresh_frame_and_register_information): Call
4121         tui_check_register_values.
4122         * tui/tui-data.h (struct tui_data_window) <data_content,
4123         data_content_count, data_type>: Remove.
4124         (enum tui_data_type): Remove.
4125
4126         * tui/tui-data.c (tui_data_window::clear_detail)
4127         (~tui_data_window): Update.
4128
4129 2019-06-25  Tom Tromey  <tom@tromey.com>
4130
4131         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
4132         declare.
4133         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
4134         Rename from tui_first_data_item_displayed.  Update.
4135         (tui_data_window::refresh_all)
4136         (tui_data_window::do_scroll_vertical): Update.
4137         * tui/tui-data.h (struct tui_data_window)
4138         <first_data_item_displayed>: Declare new method.
4139
4140 2019-06-25  Tom Tromey  <tom@tromey.com>
4141
4142         * tui/tui-data.h (tui_init_generic_part): Don't declare.
4143         * tui/tui-data.c (tui_init_generic_part): Remove, moving
4144         contents...
4145         (tui_initialize_static_data): ...here.
4146
4147 2019-06-25  Tom Tromey  <tom@tromey.com>
4148
4149         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4150         (tui_display_registers_from, tui_check_register_values): Update.
4151         (tui_display_register): Remove win_info parameter; update.
4152         (tui_get_register): Change type of parameters.
4153         * tui/tui-data.h (struct tui_data_element): Remove.
4154         (union tui_which_element) <data>: Remove.
4155         <data_window>: Change type.
4156         (struct tui_data_item_window): New.
4157         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
4158         case.  Add assert.
4159         (~tui_data_item_window): New destructor.
4160         (free_content_elements): Remove DATA_ITEM_WIN case.
4161
4162 2019-06-25  Tom Tromey  <tom@tromey.com>
4163
4164         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
4165         Remove.
4166
4167 2019-06-25  Tom Tromey  <tom@tromey.com>
4168
4169         * tui/tui-data.h (struct tui_command_element): Remove.
4170         (union tui_which_element) <command>: Remove.
4171         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
4172         assert.
4173         (free_content_elements): Remove CMD_WIN case.
4174
4175 2019-06-25  Tom Tromey  <tom@tromey.com>
4176
4177         * tui/tui-layout.c (tui_set_layout): Update.
4178         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
4179         * tui/tui-data.c (layout_def): Update.
4180
4181 2019-06-25  Tom Tromey  <tom@tromey.com>
4182
4183         * tui/tui-wingeneral.c (tui_refresh_all): Update.
4184         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4185         (tui_source_window_base::set_new_height): Update.
4186         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
4187         Update.
4188         (tui_set_locator_fullname, tui_set_locator_info)
4189         (tui_show_frame_info): Update.
4190         * tui/tui-source.c (tui_set_source_content)
4191         (tui_source_is_displayed): Update.
4192         * tui/tui-layout.c (show_source_disasm_command, show_data)
4193         (show_source_or_disasm_and_command): Update.
4194         * tui/tui-disasm.c (tui_set_disassem_content)
4195         (tui_get_begin_asm_address): Update.
4196         * tui/tui-data.h (struct tui_locator_element): Remove.
4197         (union tui_which_element) <locator>: Remove.
4198         (struct tui_locator_window): New.
4199         (tui_locator_win_info_ptr): Change return type.
4200         * tui/tui-data.c (_locator): Change type.
4201         (tui_locator_win_info_ptr): Change return type.
4202         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
4203         (tui_alloc_content): Add assert.
4204
4205 2019-06-25  Tom Tromey  <tom@tromey.com>
4206
4207         * tui/tui-winsource.c
4208         (tui_exec_info_window::maybe_allocate_content): New method.
4209         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
4210         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
4211         (make_source_or_disasm_window): Add cast.
4212         * tui/tui-data.h (union tui_which_element) <simple_string>:
4213         Remove.
4214         (struct tui_source_info): New.
4215         (struct tui_source_window_base) <execution_info>: Change type.
4216         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
4217         case, and add assert.
4218         (tui_alloc_content): Add assert.
4219
4220 2019-06-25  Tom Tromey  <tom@tromey.com>
4221
4222         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
4223         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
4224         * tui/tui-data.c (tui_alloc_win_info): Remove.
4225
4226 2019-06-25  Tom Tromey  <tom@tromey.com>
4227
4228         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
4229         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
4230         can_highlight.
4231
4232 2019-06-25  Tom Tromey  <tom@tromey.com>
4233
4234         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
4235         make_visible_with_new_height method.
4236         (tui_win_info::make_visible_with_new_height): New method.
4237         (tui_source_window_base::do_make_visible_with_new_height)
4238         (tui_data_window::do_make_visible_with_new_height)
4239         (tui_cmd_window::do_make_visible_with_new_height): New methods.
4240         (make_visible_with_new_height): Remove.
4241         (tui_resize_all, tui_adjust_win_heights): Use
4242         make_visible_with_new_height method.
4243         * tui/tui-data.h (struct tui_win_info)
4244         <do_make_visible_with_new_height, make_visible_with_new_height>:
4245         New methods.
4246         (struct tui_source_window_base, struct tui_data_window)
4247         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
4248         methods.
4249
4250 2019-06-25  Tom Tromey  <tom@tromey.com>
4251
4252         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
4253         method.
4254         (update_tab_width): Call update_tab_width method.
4255         * tui/tui-data.h (struct tui_win_info)
4256         (struct tui_source_window_base) <update_tab_width>: New methods.
4257
4258 2019-06-25  Tom Tromey  <tom@tromey.com>
4259
4260         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
4261         parameter.
4262         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
4263         parameter.
4264         (tui_gen_win_info::make_visible): Update.
4265         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
4266         parameter.
4267         * tui/tui-data.h (enum tui_box): New enum.
4268         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
4269
4270 2019-06-25  Tom Tromey  <tom@tromey.com>
4271
4272         * tui/tui-layout.c (make_source_or_disasm_window): Always use
4273         init_and_make_win for EXEC_INFO_WIN.
4274         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
4275         longer inline.
4276         (struct tui_win_info) <~tui_win_info>: Inline.
4277         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4278         Don't declare.
4279         * tui/tui-data.c (source_win, disasm_win): Remove globals.
4280         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4281         Remove.
4282         (tui_initialize_static_data): Update.
4283         (~tui_gen_win_info): Handle more cleanup here.
4284         (~tui_source_window_base): Delete "execution_info".
4285         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
4286
4287 2019-06-25  Tom Tromey  <tom@tromey.com>
4288
4289         * tui/tui-layout.c (make_command_window): Don't set
4290         can_highlight.
4291         (show_source_disasm_command): Call the reset method.
4292         (show_data): Don't set can_highlight.  Call the reset method.
4293         (tui_gen_win_info::reset): Rename from init_gen_win_info
4294         (init_and_make_win): Simplify.  Return tui_gen_win_info.
4295         (show_source_or_disasm_and_command): Call the reset method.
4296         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
4297         (struct tui_cmd_window): Set can_highlight.
4298
4299 2019-06-25  Tom Tromey  <tom@tromey.com>
4300
4301         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
4302         from make_visible.
4303         (tui_make_visible, tui_make_invisible): Rewrite.
4304         (tui_win_info::make_visible): Remove.
4305         (tui_source_window_base::make_visible): Update.
4306         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
4307         method.  Moved from...
4308         (struct tui_win_info) <make_visible>: ...here.
4309
4310 2019-06-25  Tom Tromey  <tom@tromey.com>
4311
4312         * tui/tui-winsource.c
4313         (tui_source_window_base::do_scroll_horizontal): Remove direction
4314         parameter.
4315         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
4316         direction parameter.
4317         * tui/tui-win.c (tui_win_info::forward_scroll)
4318         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4319         (tui_win_info::right_scroll): Update.
4320         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
4321         direction parameter.
4322         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
4323         direction parameter.
4324         * tui/tui-data.h (enum tui_scroll_direction): Remove.
4325         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
4326         Remove direction parameter.
4327         (struct tui_source_window_base, struct tui_source_window)
4328         (struct tui_disasm_window, struct tui_data_window)
4329         (struct tui_cmd_window): Update.
4330
4331 2019-06-25  Tom Tromey  <tom@tromey.com>
4332
4333         * tui/tui-winsource.h (tui_set_exec_info_content)
4334         (tui_show_exec_info_content, tui_erase_exec_info_content)
4335         (tui_clear_exec_info_content, tui_update_exec_info): Change
4336         argument to tui_source_window_base.
4337         * tui/tui-winsource.c (tui_set_exec_info_content)
4338         (tui_show_exec_info_content, tui_erase_exec_info_content)
4339         (tui_clear_exec_info_content, tui_update_exec_info): Change
4340         argument to tui_source_window_base.
4341
4342 2019-06-25  Tom Tromey  <tom@tromey.com>
4343
4344         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
4345         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
4346
4347 2019-06-25  Tom Tromey  <tom@tromey.com>
4348
4349         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
4350         check.
4351
4352 2019-06-25  Tom Tromey  <tom@tromey.com>
4353
4354         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
4355         type to void.
4356         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
4357         type to void.
4358         * tui/tui-source.c (tui_set_source_content): Update.
4359         * tui/tui-disasm.c (tui_set_disassem_content): Update.
4360
4361 2019-06-25  Tom Tromey  <tom@tromey.com>
4362
4363         * tui/tui-win.c (window_name_completer, tui_set_focus)
4364         (tui_all_windows_info): Use name method.
4365         * tui/tui-data.h (struct tui_gen_win_info)
4366         (struct tui_source_window, struct tui_disasm_window)
4367         (struct tui_data_window, struct tui_cmd_window) <name>: New
4368         method.
4369         (tui_win_name): Don't declare.
4370         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
4371         (tui_win_name): Remove.
4372
4373 2019-06-25  Tom Tromey  <tom@tromey.com>
4374
4375         * tui/tui-winsource.h (tui_update_source_window)
4376         (tui_update_source_window_as_is): Change parameter type.
4377         * tui/tui-winsource.c (tui_update_source_window): Change win_info
4378         to be a tui_source_window_base.
4379         (tui_update_source_window_as_is): Likewise.
4380         * tui/tui-win.c (make_visible_with_new_height): Update.
4381
4382 2019-06-25  Tom Tromey  <tom@tromey.com>
4383
4384         * tui/tui-winsource.c (tui_erase_source_content)
4385         (tui_show_source_content, tui_show_exec_info_content)
4386         (tui_erase_exec_info_content): Use refresh_window method.
4387         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
4388         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
4389         from tui_refresh_win.
4390         (tui_data_window::refresh_window): New method.
4391         (tui_win_info::refresh, tui_source_window_base::refresh)
4392         (tui_refresh_all): Use refresh_window method.
4393         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
4394         method.
4395         * tui/tui-regs.c (tui_display_register): Call refresh_window
4396         method.
4397         * tui/tui-layout.c (show_source_disasm_command)
4398         (show_source_or_disasm_and_command): Call refresh_window method.
4399         * tui/tui-data.h (struct tui_gen_win_info)
4400         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
4401         New method.
4402
4403 2019-06-25  Tom Tromey  <tom@tromey.com>
4404
4405         * tui/tui.c (tui_rl_other_window, tui_enable)
4406         (tui_is_window_visible, tui_get_command_dimension): Update.
4407         * tui/tui-winsource.c (tui_update_source_window_as_is)
4408         (tui_clear_source_content, tui_erase_source_content)
4409         (tui_show_source_line, tui_source_window_base::refill)
4410         (tui_source_window_base::do_scroll_horizontal)
4411         (tui_source_window_base::set_is_exec_point_at)
4412         (tui_update_breakpoint_info, tui_set_exec_info_content)
4413         (tui_alloc_source_buffer, tui_line_is_displayed)
4414         (tui_addr_is_displayed): Update.
4415         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4416         (tui_check_and_display_highlight_if_needed)
4417         (tui_win_info::make_visible, tui_win_info::refresh)
4418         (tui_refresh_all): Update.
4419         * tui/tui-windata.c (tui_first_data_item_displayed)
4420         (tui_delete_data_content_windows, tui_erase_data_content)
4421         (tui_display_all_data, tui_data_window::refresh_all)
4422         (tui_check_data_values): Update.
4423         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
4424         (tui_set_win_focus_to, tui_win_info::forward_scroll)
4425         (tui_win_info::backward_scroll, tui_refresh_all_win)
4426         (tui_resize_all, tui_set_focus, tui_all_windows_info)
4427         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
4428         (tui_source_window_base::set_new_height)
4429         (tui_data_window::set_new_height)
4430         (make_invisible_and_set_new_height)
4431         (make_visible_with_new_height, new_height_ok)
4432         (parse_scrolling_args): Update.
4433         * tui/tui-stack.c (tui_show_frame_info): Update.
4434         * tui/tui-source.c (tui_set_source_content)
4435         (tui_set_source_content_nil, tui_source_is_displayed)
4436         (tui_source_window::do_scroll_vertical): Update.
4437         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4438         (tui_display_registers_from, tui_display_reg_element_at_line)
4439         (tui_check_register_values, tui_reg_command): Update.
4440         * tui/tui-layout.c (tui_default_win_height)
4441         (show_source_disasm_command, show_data, init_and_make_win)
4442         (show_source_or_disasm_and_command): Update.
4443         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
4444         (tui_redisplay_readline, tui_mld_flush)
4445         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
4446         (tui_getc): Update.
4447         * tui/tui-disasm.c (tui_set_disassem_content)
4448         (tui_disasm_window::do_scroll_vertical): Update.
4449         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
4450         Now virtual.
4451         (struct tui_win_info): Derive from tui_gen_win_info.
4452         <~tui_win_info>: Mark as override.
4453         <generic>: Remove member.
4454         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
4455         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
4456         (~tui_data_window, ~tui_win_info)
4457         (tui_free_all_source_wins_content): Update.
4458         * tui/tui-command.c (tui_refresh_cmd_win): Update.
4459
4460 2019-06-25  Tom Tromey  <tom@tromey.com>
4461
4462         * tui/tui-layout.c (init_and_make_win): Use new.
4463         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
4464         destructor, initializers.
4465         (tui_alloc_generic_win_info): Don't declare.
4466         * tui/tui-data.c (_locator): Add argument to constructor.
4467         (source_win, disasm_win): New globals.
4468         (exec_info): Remove.
4469         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4470         Update.
4471         (tui_alloc_generic_win_info): Remove.
4472         (init_content_element): Use new.
4473         (tui_win_info::tui_win_info): Update.
4474         (free_content_elements) <case DATA_WIN>: Use delete.
4475
4476 2019-06-25  Tom Tromey  <tom@tromey.com>
4477
4478         * tui/tui-wingeneral.c (tui_refresh_win): Update.
4479         * tui/tui-windata.c (tui_first_data_item_displayed)
4480         (tui_delete_data_content_windows): Update.
4481         * tui/tui-win.c (tui_data_window::set_new_height): Update.
4482         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4483         (tui_display_registers_from, tui_check_register_values): Update.
4484         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
4485         pointer.
4486         * tui/tui-data.c (init_content_element): Update.  Allocate the new
4487         window.
4488         (tui_free_data_content): Update.
4489         (free_content_elements) <case DATA_WIN>: Free the window.
4490
4491 2019-06-25  Tom Tromey  <tom@tromey.com>
4492
4493         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
4494         Update.
4495         * tui/tui-layout.c (make_command_window)
4496         (show_source_disasm_command, show_data, init_and_make_win)
4497         (show_source_or_disasm_and_command): Update.
4498         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
4499         method.
4500         <can_highight, is_highlighted>: Now bool.
4501         (tui_set_win_highlight): Don't declare.
4502         * tui/tui-data.c (tui_set_win_highlight): Remove.
4503
4504 2019-06-25  Tom Tromey  <tom@tromey.com>
4505
4506         * tui/tui-wingeneral.c (make_visible): Remove check of window
4507         type.
4508
4509 2019-06-25  Tom Tromey  <tom@tromey.com>
4510
4511         * tui/tui-win.c (tui_win_info::max_height)
4512         (tui_cmd_window::max_height): New methods.
4513         (new_height_ok): Call max_height.
4514         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
4515         <max_height>: New method.
4516
4517 2019-06-25  Tom Tromey  <tom@tromey.com>
4518
4519         * tui/tui-win.c (tui_source_window_base::set_new_height)
4520         (tui_data_window::set_new_height): New methods.
4521         (make_invisible_and_set_new_height): Call set_new_height method.
4522         * tui/tui-data.h (struct tui_win_info)
4523         (struct tui_source_window_base, struct tui_data_window)
4524         <set_new_height>: New method.
4525
4526 2019-06-25  Tom Tromey  <tom@tromey.com>
4527
4528         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
4529         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
4530         tui_refresh_data_win.
4531         * tui/tui-win.c (tui_source_window_base::refresh_all): New
4532         method.
4533         (tui_refresh_all_win): Call the refresh_all method.
4534         (tui_set_focus): Likewise.
4535         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
4536         (struct tui_source_window_base, struct tui_data_window) <refresh>:
4537         Likewise.
4538
4539 2019-06-25  Tom Tromey  <tom@tromey.com>
4540
4541         * tui/tui-winsource.h (tui_refill_source_window)
4542         (tui_set_is_exec_point_at): Don't declare.
4543         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4544         (tui_source_window_base::refill): Rename from
4545         tui_refill_source_window.
4546         (tui_source_window_base::do_scroll_horizontal): Update.
4547         (tui_source_window_base::set_is_exec_point_at): Rename from
4548         tui_set_is_exec_point_at.
4549         (tui_update_all_breakpoint_info): Update.
4550         * tui/tui-stack.c (tui_show_frame_info): Update.
4551         * tui/tui-layout.c (show_data): Add cast.
4552         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
4553         * tui/tui-data.h (struct tui_source_window_base) <refill,
4554         set_is_exec_point_at>: New methods.
4555         (tui_source_windows, tui_add_to_source_windows): Update types.
4556         (tui_add_to_source_windows): Remove redundant declaration.
4557         * tui/tui-data.c (source_windows): Store tui_source_window_base.
4558         (tui_source_windows): Change return type.
4559         (tui_clear_source_windows_detail): Update.
4560         (tui_add_to_source_windows): Change type of parameter.
4561         (tui_free_all_source_wins_content): Update.
4562
4563 2019-06-25  Tom Tromey  <tom@tromey.com>
4564
4565         * tui/tui-wingeneral.c (tui_win_info::refresh)
4566         (tui_source_window_base::refresh): New methods.
4567         (tui_refresh_all): Call the refresh method.
4568         * tui/tui-data.h (struct tui_win_info)
4569         (struct tui_source_window_base) <refresh>: New method.
4570
4571 2019-06-25  Tom Tromey  <tom@tromey.com>
4572
4573         * tui/tui.h (tui_is_window_visible): Return bool.
4574         * tui/tui.c (tui_is_window_visible): Return bool.
4575         * tui/tui-wingeneral.c (tui_make_window, make_visible)
4576         (tui_make_visible, tui_make_invisible)
4577         (tui_win_info::make_visible)
4578         (tui_source_window_base::make_visible, make_all_visible)
4579         (tui_make_all_visible, tui_make_all_invisible): Update.
4580         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
4581         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
4582         bool.
4583         (struct tui_win_info, struct tui_source_window_base)
4584         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
4585         * tui/tui-data.c (tui_init_generic_part): Update.
4586
4587 2019-06-25  Tom Tromey  <tom@tromey.com>
4588
4589         * tui/tui-wingeneral.c (tui_win_info::make_visible)
4590         (tui_source_window_base::make_visible): New methods.
4591         (make_all_visible): Make method call.
4592         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
4593         (struct tui_source_window_base, struct tui_cmd_window): Override
4594         make_visible.
4595         (tui_win_is_source_type): Don't declare.
4596         * tui/tui-data.c (tui_win_is_source_type): Remove.
4597
4598 2019-06-25  Tom Tromey  <tom@tromey.com>
4599
4600         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
4601         NULL check.
4602
4603 2019-06-25  Tom Tromey  <tom@tromey.com>
4604
4605         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
4606         Inline constructor.  Add initializers for members.
4607         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
4608         constructors; now inline in class.
4609
4610 2019-06-25  Tom Tromey  <tom@tromey.com>
4611
4612         * tui/tui-regs.c (tui_show_registers): Update.
4613         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
4614         bool.
4615         * tui/tui-data.c (tui_data_window::clear_detail)
4616         (tui_data_window): Update.
4617
4618 2019-06-25  Tom Tromey  <tom@tromey.com>
4619
4620         * tui/tui-windata.c (tui_display_all_data)
4621         (tui_display_data_from_line, tui_display_data_from)
4622         (tui_check_data_values, tui_data_window::do_scroll_vertical):
4623         Update.
4624         * tui/tui-regs.c (tui_last_regs_line_no)
4625         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4626         (tui_show_registers, tui_show_register_group)
4627         (tui_display_registers_from, tui_display_reg_element_at_line)
4628         (tui_display_registers_from_line, tui_check_register_values)
4629         (tui_reg_next, tui_reg_prev): Update.
4630         * tui/tui-layout.c (tui_set_layout, show_data): Update.
4631         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
4632         tui_data_window.
4633         (struct tui_win_info) <detail>: Remove.  Add new fields from
4634         tui_data_info.
4635         (TUI_DATA_WIN): Add cast.
4636         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
4637         (~tui_data_window): Simplify.
4638
4639 2019-06-25  Tom Tromey  <tom@tromey.com>
4640
4641         * tui/tui-layout.c (show_source_disasm_command)
4642         (show_source_or_disasm_and_command): Update.
4643         * tui/tui-io.c (update_cmdwin_start_line)
4644         (tui_redisplay_readline): Update.
4645         * tui/tui-data.h (struct tui_command_info): Remove.
4646         (struct tui_win_info) <detail>: Remove command_info member.
4647         (struct tui_data_window) <start_line>: New member, from
4648         tui_command_info.
4649         (TUI_CMD_WIN): Add casts.
4650
4651 2019-06-25  Tom Tromey  <tom@tromey.com>
4652
4653         * tui/tui-winsource.c (tui_update_source_window)
4654         (tui_refill_source_window)
4655         (tui_source_window_base::do_scroll_horizontal)
4656         (tui_update_breakpoint_info, tui_set_exec_info_content)
4657         (tui_show_exec_info_content, tui_erase_exec_info_content)
4658         (tui_clear_exec_info_content): Update.
4659         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
4660         Update.
4661         * tui/tui-win.c (make_invisible_and_set_new_height)
4662         (make_visible_with_new_height): Update.
4663         * tui/tui-source.c (tui_set_source_content)
4664         (tui_show_symtab_source): Update.
4665         * tui/tui-layout.c (extract_display_start_addr)
4666         (show_source_disasm_command, show_data)
4667         (make_source_or_disasm_window)
4668         (show_source_or_disasm_and_command): Update.
4669         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
4670         (tui_disasm_window::do_scroll_vertical): Remove shadowing
4671         "gdbarch".
4672         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
4673         to tui_source_window_base.
4674         (struct tui_win_info) <detail>: Remove source_info member.
4675         (struct tui_source_window_base) <has_locator>: Inline.
4676         Move contents from tui_source_info; rename has_locator member to
4677         m_has_locator.
4678         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
4679         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
4680         header file.
4681         (tui_source_window_base::clear_detail, ~tui_source_window_base):
4682         Simplify.
4683         (tui_free_all_source_wins_content): Cast to
4684         tui_source_window_base.
4685
4686 2019-06-25  Tom Tromey  <tom@tromey.com>
4687
4688         * tui/tui-win.c (make_invisible_and_set_new_height)
4689         (make_visible_with_new_height): Call has_locator method.
4690         * tui/tui-layout.c (show_source_disasm_command, show_data)
4691         (show_source_or_disasm_and_command): Update for bool change.
4692         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
4693         (tui_win_info) <has_locator>: New method.
4694         (struct tui_source_window_base) <has_locator>: New method.
4695         (tui_win_has_locator): Don't declare.
4696         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
4697         from tui_win_has_locator.
4698         (tui_source_window_base): Use false, not FALSE.
4699
4700 2019-06-25  Tom Tromey  <tom@tromey.com>
4701
4702         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
4703         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
4704         clear_detail method directly.
4705         (tui_clear_win_detail): Remove.
4706
4707 2019-06-25  Tom Tromey  <tom@tromey.com>
4708
4709         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
4710         "this", not TUI_DISASM_WIN.
4711
4712 2019-06-25  Tom Tromey  <tom@tromey.com>
4713
4714         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
4715         declare.
4716         * tui/tui-winsource.c
4717         (tui_source_window_base::do_scroll_horizontal): Rename from
4718         tui_horizontal_source_scroll.
4719         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
4720         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
4721         from tui_vertical_data_scroll.
4722         * tui/tui-win.h (tui_scroll): Don't declare.
4723         * tui/tui-win.c (tui_win_info::forward_scroll)
4724         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4725         (tui_win_info::right_scroll): Rename and update.
4726         (tui_scroll_forward_command, tui_scroll_backward_command)
4727         (tui_scroll_left_command, tui_scroll_right_command): Update.
4728         (tui_scroll): Remove.
4729         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
4730         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
4731         from tui_vertical_source_scroll.
4732         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
4733         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
4734         from tui_vertical_disassem_scroll.
4735         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
4736         do_scroll_horizontal>: New methods.
4737         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
4738         Likewise.
4739         (struct tui_source_window_base): Add do_scroll_horizontal.
4740         (struct tui_source_window, struct tui_disasm_window): Add
4741         do_scroll_vertical.
4742         (struct tui_data_window, struct tui_cmd_window): Add
4743         do_scroll_horizontal and do_scroll_vertical.
4744         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
4745
4746 2019-06-25  Tom Tromey  <tom@tromey.com>
4747
4748         * tui/tui-data.h (struct tui_source_window_base): New struct.
4749         (struct tui_source_window): Derive from tui_source_window_base.
4750         (struct tui_disasm_window): New struct.
4751         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
4752         from tui_source_window::clear_detail.
4753         (tui_source_window_base): Rename from tui_source_window.
4754         (~tui_source_window_base): Rename from ~tui_source_window.
4755         (tui_alloc_win_info): Create a tui_disasm_window.
4756
4757 2019-06-25  Tom Tromey  <tom@tromey.com>
4758
4759         * tui/tui-data.h (struct tui_source_window)
4760         (struct tui_data_window): Declare destructors.
4761         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
4762         destructors.
4763         (tui_win_info): Simplify.
4764
4765 2019-06-25  Tom Tromey  <tom@tromey.com>
4766
4767         * tui/tui-winsource.c (tui_display_main)
4768         (tui_update_source_windows_with_addr)
4769         (tui_update_all_breakpoint_info): Update.
4770         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4771         (new_height_ok, parse_scrolling_args): Update.
4772         * tui/tui-stack.c (tui_show_frame_info): Update.
4773         * tui/tui-data.h (struct tui_list): Remove.
4774         (tui_source_windows): Return a reference to a std::vector.
4775         * tui/tui-data.c (source_windows): Now a std::vector.
4776         (tui_source_windows): Change return type.
4777         (tui_clear_source_windows): Rewrite.
4778         (tui_clear_source_windows_detail, tui_add_to_source_windows)
4779         (tui_free_all_source_wins_content): Rewrite.
4780
4781 2019-06-25  Tom Tromey  <tom@tromey.com>
4782
4783         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
4784         (struct tui_data_window, struct tui_cmd_window): Declare
4785         clear_detail method.
4786         * tui/tui-data.c (tui_source_window::clear_detail)
4787         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
4788         methods.
4789         (tui_clear_win_detail): Simplify.
4790
4791 2019-06-25  Tom Tromey  <tom@tromey.com>
4792
4793         * tui/tui-layout.c (make_source_window, make_disasm_window)
4794         (make_source_or_disasm_window): Remove win_info_ptr parameter.
4795         Return the new window.
4796         (show_source_disasm_command, show_data)
4797         (show_source_or_disasm_and_command): Update.
4798
4799 2019-06-25  Tom Tromey  <tom@tromey.com>
4800
4801         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
4802         parameter.  Return the new window.
4803         (show_source_disasm_command): Update and remove NULL check.
4804         (show_source_or_disasm_and_command): Update.
4805
4806 2019-06-25  Tom Tromey  <tom@tromey.com>
4807
4808         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
4809
4810 2019-06-25  Tom Tromey  <tom@tromey.com>
4811
4812         * tui/tui-data.h (struct tui_win_info): Make constructor
4813         protected.  Make destructor virtual.  Add initializers.
4814         (tui_source_window, tui_data_window, tui_cmd_window): New
4815         classes.
4816         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
4817         constructor.  Add "type" parameter.
4818         (tui_source_window, tui_data_window, tui_cmd_window): New
4819         constructors.
4820         (tui_alloc_win_info): Instantiate the appropriate subclass.
4821
4822 2019-06-25  Tom Tromey  <tom@tromey.com>
4823
4824         * tui/tui-win.c (tui_resize_all): Use delete.
4825         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
4826         destructor.
4827         (tui_free_window): Don't declare.
4828         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
4829         Update.
4830
4831 2019-06-25  Tom Tromey  <tom@tromey.com>
4832
4833         * tui/tui-data.h (struct tui_win_info): Add constructor.
4834         * tui/tui-data.c (tui_alloc_win_info): Use new.
4835         (tui_free_window): Use delete.
4836
4837 2019-06-22  Tom Tromey  <tom@tromey.com>
4838
4839         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
4840         declare.
4841         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
4842
4843 2019-06-22  Tom Tromey  <tom@tromey.com>
4844
4845         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
4846         declare.
4847         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
4848
4849 2019-06-22  Tom de Vries  <tdevries@suse.de>
4850
4851         * dwarf2read.c (create_addrmap_from_aranges)
4852         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
4853         instead of '%zu'.
4854
4855 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
4856
4857         * dwarf2read.h (dwarf2_section_info_def): Remove.
4858         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
4859         * dwarf2read.c (struct dwo_sections) <types>: Change type to
4860         std::vector<dwarf2_section_info>.
4861         (struct dwo_file) <~dwo_file>: Remove.
4862         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
4863         types field.
4864         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
4865         (dwarf2_read_debug_names): Likewise.
4866         (create_debug_types_hash_table): Change parameter type to
4867         array_view, adjust code accordingly.
4868         (dwarf2_locate_dwo_sections): Adjust to std::vector.
4869         (partial_die_info::fixup): Likewise.
4870         (determine_prefix): Likewise.
4871         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
4872
4873 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4874
4875         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
4876         gdb_bfd_ref_ptr.
4877         <~dwo_file>: Remove call to gdb_bfd_unref.
4878         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
4879         gdb_bfd_ref_ptr::get.
4880
4881 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4882
4883         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
4884         type to htab_up.
4885         * dwarf2read.c (struct dwo_file): Initialize fields.
4886         <~dwo_file>: New.
4887         (free_dwo_file): Remove, move content to ~dwo_file.
4888         (struct dwo_file_deleter): Remove.
4889         (dwo_file_up>: Remove custom deleter.
4890         (free_dwo_files): Remove.
4891         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
4892         dwo_files.
4893         (process_skeletonless_type_units): Call unique_ptr::get.
4894         (allocate_dwo_file_hash_table): Add deleter to created hash
4895         table.  Change return type to htab_up.
4896         (lookup_dwo_file_slot): Don't memset dwo_file, call
4897         unique_ptr::get.
4898         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
4899         (create_dwo_unit_in_dwp_v2): Likewise.
4900         (open_and_init_dwo_file): Likewise.
4901         (free_dwo_file_from_slot): Remove.
4902
4903 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4904
4905         * dwarf2read.h (struct dwarf2_section_info) <readin,
4906         is_virtual>: Change type to bool.
4907         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
4908         true instead of 1.
4909
4910 2019-06-19  Tom Tromey  <tom@tromey.com>
4911
4912         * tui/tui-data.h (tui_init_content_element): Don't declare.
4913
4914 2019-06-19  Tom Tromey  <tom@tromey.com>
4915
4916         * tui/tui-data.h (tui_init_win_info): Don't declare.
4917
4918 2019-06-19  Tom de Vries  <tdevries@suse.de>
4919
4920         * dwarf2read.h (abstract_to_concrete): Change type to
4921         std::unordered_map<sect_offset, std::vector<sect_offset>,
4922         gdb::hash_enum<sect_offset>>.
4923
4924 2019-06-19  Tom Tromey  <tromey@adacore.com>
4925
4926         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
4927         EVAL_AVOID_SIDE_EFFECTS specially.
4928
4929 2019-06-19  Tom Tromey  <tromey@adacore.com>
4930
4931         * source-cache.c (highlighter): New global.
4932         (source_cache::get_source_lines): Create a highlighter on demand.
4933
4934 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4935
4936         * defs.h (deprecated_interactive_hook): Delete declaration.
4937         * interps.c (clear_interpreter_hooks): Remove use of
4938         deprecated_interactive_hook.
4939         * top.c (deprecated_interactive_hook): Delete definition.
4940         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
4941
4942 2019-06-18  Tom de Vries  <tdevries@suse.de>
4943
4944         PR gdb/24515
4945         * dwarf2read.h (abstract_to_concrete): Change type from
4946         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
4947         std::unordered_map<sect_offset, std::vector<sect_offset>>.
4948         * dwarf2read.c (read_variable): Update.
4949         (dwarf2_fetch_die_loc_sect_off): Update.
4950
4951 2019-06-17  Tom de Vries  <tdevries@suse.de>
4952
4953         PR gdb/24617
4954         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
4955         accessing parent[parent_len - 1].
4956
4957 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
4958
4959         PR gdb/24364
4960         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
4961         call dtrace_process_dof with NULL dof.
4962
4963 2019-06-16  Tom de Vries  <tdevries@suse.de>
4964
4965         PR gdb/24445
4966         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
4967
4968 2019-06-16  Tom Tromey  <tom@tromey.com>
4969
4970         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4971         (make_all_visible): Use address of member.
4972
4973 2019-06-16  Tom Tromey  <tom@tromey.com>
4974
4975         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
4976         (tui_free_window, free_content, free_content_elements): Remove
4977         unnecessary cast.
4978         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
4979         cast.
4980         * tui/tui-regs.c (tui_show_register_group)
4981         (tui_display_registers_from, tui_display_reg_element_at_line):
4982         Remove unnecessary cast.
4983
4984 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
4985
4986         * linux-nat.c (normal_mask): Delete.
4987         (_initialize_linux_nat): Don't initialise normal_mask.
4988
4989 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
4990
4991         PR gdb/24445
4992         * dwarf-index-write.h (write_psymtabs_to_index): Add
4993         dwz_basename parameter.
4994         * dwarf-index-write.c (write_gdbindex): Move file writing to
4995         write_gdbindex_1.  Change return type void.
4996         (assert_file_size): Move up, remove filename parameter.
4997         (write_gdbindex_1): New function.
4998         (write_debug_names): Change return type to void, call
4999         assert_file_size.
5000         (struct index_wip_file): New struct.
5001         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
5002         file logic to index_wip_file.  Write index for dwz file if
5003         needed.
5004         (save_gdb_index_command): Pass basename of dwz file, if present.
5005         * dwarf-index-cache.c (index_cache::store): Obtain and pass
5006         build-id of dwz file, if present.
5007         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
5008         (dwarf2_get_dwz_file): Likewise.
5009         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
5010         (dwarf2_get_dwz_file): Likewise.
5011
5012 2019-06-16  Tom Tromey  <tom@tromey.com>
5013
5014         * coffread.c (process_coff_symbol): Use xstrdup.
5015         * value.c (create_internalvar): Use xstrdup.
5016
5017 2019-06-16  Tom Tromey  <tom@tromey.com>
5018
5019         * valops.c (value_cast, value_slice): Remove unnecessary cast.
5020         * breakpoint.c (stopin_command, stopat_command)
5021         (until_break_command, decode_location_default): Remove unnecessary
5022         cast.
5023         * utils.c (subset_compare): Remove unnecessary cast.
5024         * ada-lang.c (ada_update_initial_language): Remove unnecessary
5025         cast.
5026         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
5027         cast.
5028         * infcmd.c (path_command): Remove unnecessary cast.
5029         * coffread.c (decode_type): Remove unnecessary cast.
5030         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
5031         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
5032         * tui/tui-stack.c (tui_show_locator_content)
5033         (tui_show_frame_info): Remove unnecessary cast.
5034         * tui/tui-win.c (tui_scroll_forward_command)
5035         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
5036         (parse_scrolling_args): Remove unnecessary cast.
5037         * tui/tui-data.c (init_win_info, tui_del_window)
5038         (tui_free_window, tui_del_data_windows, tui_free_data_content)
5039         (free_content_elements): Remove unnecessary cast.
5040         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
5041         unnecessary cast.
5042         * tui/tui-source.c (tui_set_source_content)
5043         (tui_vertical_source_scroll): Remove unnecessary cast.
5044         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
5045         cast.
5046         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
5047         * tui/tui-regs.c (tui_display_registers_from)
5048         (tui_display_register): Remove unnecessary cast.
5049         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
5050         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
5051         (make_visible): Remove unnecessary cast.
5052         * tui/tui-winsource.c (tui_erase_source_content)
5053         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
5054         unnecessary cast.
5055         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
5056         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
5057         * stabsread.c (read_type, read_array_type, read_range_type):
5058         Remove unnecessary cast.
5059         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
5060         (parse_symbol, parse_type, upgrade_type, parse_external)
5061         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
5062         unnecessary cast.
5063         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
5064
5065 2019-06-16  Tom Tromey  <tom@tromey.com>
5066
5067         * tui/tui-data.c (tui_alloc_generic_win_info)
5068         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
5069         checks.
5070
5071 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
5072             Andrew Burgess  <andrew.burgess@embecosm.com>
5073
5074         * f-typeprint.c (f_print_type): Don't return early for not
5075         associated or not allocated types.
5076         (f_type_print_varspec_suffix): Add print_rank parameter and print
5077         ranks of array types in case they dangling.
5078         (f_type_print_base): Add print_rank parameter.
5079
5080 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5081
5082         * NEWS: Mention new MI commands.
5083         * break-catch-throw.c (enum exception_event_kind): Move to
5084         breakpoint.h.
5085         (print_mention_exception_catchpoint): Output text as a single
5086         message.
5087         (catch_exception_command_1): Rename to...
5088         (catch_exception_event): ...this, make non-static, update header
5089         command, and change some parameter types.
5090         (catch_catch_command): Update for changes to
5091         catch_exception_command_1.
5092         (catch_throw_command): Likewise.
5093         (catch_rethrow_command): Likewise.
5094         * breakpoint.c (enum exception_event_kind): Delete.
5095         * breakpoint.h (enum exception_event_kind): Moved here from
5096         break-catch-throw.c.
5097         (catch_exception_event): Declare.
5098         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
5099         (mi_cmd_catch_throw): New function.
5100         (mi_cmd_catch_rethrow): New function.
5101         (mi_cmd_catch_catch): New function.
5102         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
5103         'catch-catch' entries.
5104         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
5105         (mi_cmd_catch_rethrow): Declare.
5106         (mi_cmd_catch_catch): Declare.
5107
5108 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5109
5110         * annotate.c (annotate_source_line): Change return type to void,
5111         update implementation to match.
5112         * annotate.h (annotate_source_line): Change return type to void,
5113         update header comment.
5114         * stack.c (print_frame_info): Don't change what frame information
5115         is printed based on whether annotations are on or not.
5116
5117 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5118
5119         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
5120         (annotate_source): Make static.
5121         (annotate_source_line): Moved from source.c and renamed from
5122         identify_source_line.  Update the return type.
5123         * annotate.h (annotate_source): Delete declaration.
5124         (annotate_source_line): Declaration moved from source.h, and
5125         renamed from identify_source_line.  Return type updated.
5126         * source.c (identify_source_line): Moved to annotate.c and renamed
5127         to annotate_source_line.
5128         (info_line_command): Remove check of annotation_level.
5129         * source.h (identify_source_line): Move declaration to annotate.h
5130         and rename to annotate_source_line.
5131         * stack.c: Add 'annotate.h' include.
5132         (print_frame_info): Remove check of annotation_level before
5133         calling annotate_source_line.
5134
5135 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5136
5137         * source-cache.c (source_cache::get_plain_source_lines): Use
5138         open_source_file_with_line_charpos instead of just
5139         open_source_file, remove call to find_source_lines.
5140         (source_cache::get_source_lines): Likewise.
5141         * source.c (find_source_lines): Make static.
5142         (get_filename_and_charpos): Renamed into...
5143         (open_source_file_with_line_charpos): ..this along with changes to
5144         return a scoped_fd, and some other minor clean ups.
5145         (identify_source_line): Use open_source_file_with_line_charpos.
5146         (search_command_helper): Use open_source_file_with_line_charpos
5147         instead of just open_source_file, remove call to
5148         find_source_lines.
5149         * source.h (open_source_file_with_line_charpos): Declare new
5150         function.
5151         (find_source_lines): Delete declaration.
5152
5153 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5154
5155         * source.c (get_filename_and_charpos): Remove fullname
5156         parameter.
5157         (identify_source_line): Update call to get_filename_and_charpos.
5158
5159 2019-06-14  Tom Tromey  <tromey@adacore.com>
5160
5161         PR gdb/24502:
5162         * ui-style.h (skip_ansi_escape): Update comment.
5163         * ui-file.h (class no_terminal_escape_file): New class.
5164         * ui-file.c (no_terminal_escape_file::write)
5165         (no_terminal_escape_file::puts): New methods.
5166         * cli/cli-logging.c (handle_redirections): Use
5167         no_terminal_escape_file.
5168
5169 2019-06-14  Tom Tromey  <tromey@adacore.com>
5170
5171         * NEWS: Move convenience variable news above Python news.
5172
5173 2019-06-14  Tom Tromey  <tom@tromey.com>
5174
5175         * gnulib: Move directory to top-level.
5176         * configure.ac: Don't configure gnulib.
5177         * configure: Rebuild.
5178         * common/common-defs.h: Use new path to gnulib.
5179         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
5180         (GNULIB_H): Remove.
5181         (INCGNU): Look in new gnulib location.
5182         (HFILES_NO_SRCDIR): Remove gnulib files.
5183         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
5184         (generated_files): Remove GNULIB_H.
5185         ($(LIBGNU), all-lib): Remove targets.
5186         (distclean): Don't mention GNULIB_BUILDDIR.
5187         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
5188
5189 2019-06-14  Tom Tromey  <tromey@adacore.com>
5190
5191         * symfile.c (add_symbol_file_command): Remove obsolete comment.
5192         Warn if symbol file does not provide any symbols.
5193
5194 2019-06-14  Tom Tromey  <tromey@adacore.com>
5195
5196         * source.c (find_and_open_source): Respect basenames_may_differ.
5197
5198 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
5199
5200         * annotate.c (annotate_breakpoints_invalid): Make use of
5201         scoped_restore_terminal_state.
5202         (annotate_frames_invalid): Likewise.
5203
5204 2019-06-14  Tom Tromey  <tromey@adacore.com>
5205
5206         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
5207         allow assignment to an internalvar.
5208
5209 2019-06-14  Tom Tromey  <tromey@adacore.com>
5210
5211         * ada-lex.l: Allow "_" in attribute names.
5212
5213 2019-06-14  Tom Tromey  <tromey@adacore.com>
5214
5215         PR gdb/24653:
5216         * regcache.c (registers_changed): Don't call alloca.
5217         * top.c (execute_command): Don't call alloca.
5218
5219 2019-06-13  Pedro Alves  <palves@redhat.com>
5220
5221         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
5222         'expression'.  When parsing an expression, error out if there's
5223         junk after "unlimited".
5224         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5225         (do_set_command): Adjust calls to is_unlimited_literal.
5226
5227 2019-06-13  Pedro Alves  <palves@redhat.com>
5228
5229         * compile/compile.c (make_compile_options_def_group): Add braces
5230         around array_view initializer.
5231         * thread.c (make_thread_apply_all_options_def_group)
5232         (make_thread_apply_all_options_def_group): Likewise.
5233
5234 2019-06-13  Pedro Alves  <palves@redhat.com>
5235
5236         * NEWS (New commands): Mention "maint test-options
5237         require-delimiter", "maint test-options unknown-is-error", "maint
5238         test-options unknown-is-operand" and "maint show
5239         test-options-completion-result".
5240         (New command options, command completion): New section.
5241         (Completion improvements): New section.
5242         Mention that you can abbreviate "unlimited".
5243
5244 2019-06-13  Pedro Alves  <palves@redhat.com>
5245
5246         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
5247         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
5248         * unittests/cli-utils-selftests.c (test_parse_flags)
5249         (test_parse_flags_qcs): Delete.
5250         (test_cli_utils): Don't call deleted functions.
5251
5252 2019-06-13  Pedro Alves  <palves@redhat.com>
5253
5254         * thread.c: Include "cli/cli-option.h".
5255         (tp_array_compar_ascending): Global.
5256         (tp_array_compar): Delete function.
5257         (tp_array_compar_ascending, tp_array_compar_descending): New
5258         functions.
5259         (ascending_option_def, qcs_flag_option_def)
5260         (thr_qcs_flags_option_defs)
5261         (make_thread_apply_all_options_def_group)
5262         (make_thread_apply_options_def_group): New.
5263         (thread_apply_all_command): Use gdb::option::process_options.
5264         (thread_apply_command_completer)
5265         (thread_apply_all_command_completer): New.
5266         (thread_apply_command): Use gdb::option::process_options.
5267         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
5268         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
5269         to generate help text of "thread apply".  Adjust "taas"'s help.
5270         * tid-parse.c (tid_range_parser::in_thread_range): New method.
5271         * tid-parse.h (tid_range_parser::in_thread_range): New method.
5272
5273 2019-06-13  Pedro Alves  <palves@redhat.com>
5274
5275         * thread.c (thread_apply_command): Check for invalid TID with
5276         isdigit instead of !isalpha.
5277
5278 2019-06-13  Pedro Alves  <palves@redhat.com>
5279
5280         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
5281         (validate_flags_qcs): New.
5282         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
5283         (validate_flags_qcs): Declare.
5284         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
5285         (make_frame_apply_options_def_group): New.
5286         (frame_apply_command_count): Process options with
5287         gdb::option::process_options.
5288         (frame_apply_completer): New.
5289         (frame_apply_level_completer, frame_apply_all_completer)
5290         (frame_apply_completer): New.
5291         (_initialize_stack): Update help of "frame apply", "frame apply
5292         level", "frame apply all" and "faas" to mention supported options
5293         and install command completers.
5294         * stack.h (frame_apply_all_completer): Declare.
5295         * thread.c: Include "stack.h".
5296         (tfaas_command): Add "--".
5297         (_initialize_thread): Update help "tfaas" to mention supported
5298         options and install command completer.
5299
5300 2019-06-13  Pedro Alves  <palves@redhat.com>
5301
5302         * completer.c (complete_nested_command_line): New.
5303         (gdb_completion_word_break_characters_throw): Add assertion.
5304         * completer.h (complete_nested_command_line): Declare.
5305
5306 2019-06-13  Pedro Alves  <palves@redhat.com>
5307
5308         * stack.c (parse_backtrace_qualifiers): New.
5309         (backtrace_command): Use it.
5310         (backtrace_command_completer): Complete on qualifiers.
5311
5312 2019-06-13  Pedro Alves  <palves@redhat.com>
5313
5314         * frame.c: Include "cli/cli-option.h.
5315         (user_set_backtrace_options): New.
5316         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
5317         Delete.
5318         (get_prev_frame): Adjust.
5319         (boolean_option_def, uinteger_option_def)
5320         (set_backtrace_option_defs): New.
5321         (_initialize_frame): Adjust and use
5322         gdb::option::add_setshow_cmds_for_options to install "set
5323         backtrace past-main" and "set backtrace past-entry".
5324         * frame.h: Include "cli/cli-option.h".
5325         (struct frame_print_options): Forward declare.
5326         (print_frame_arguments_all, print_frame_arguments_scalars)
5327         (print_frame_arguments_none): Declare.
5328         (print_entry_values): Delete declaration.
5329         (struct frame_print_options, user_frame_print_options): New.
5330         (struct set_backtrace_options): New.
5331         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
5332         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
5333         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
5334         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
5335         (list_args_or_locals): Add frame_print_options parameter.
5336         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5337         * python/py-framefilter.c (enumerate_args): Pass down
5338         USER_FRAME_PRINT_OPTIONS.
5339         * stack.c: Include "cli/cli-option.h".
5340         (print_frame_arguments_all, print_frame_arguments_scalars)
5341         (print_frame_arguments_none): Declare.
5342         (print_raw_frame_arguments, print_entry_values): Delete.
5343         (user_frame_print_options): New.
5344         (boolean_option_def, enum_option_def, frame_print_option_defs):
5345         New.
5346         (struct backtrace_cmd_options): New.
5347         (bt_flag_option_def): New.
5348         (backtrace_command_option_defs): New.
5349         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5350         (print_frame_arg, read_frame_arg, print_frame_args)
5351         (print_frame_info, print_frame): Add frame_print_options parameter
5352         and use it.
5353         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
5354         (backtrace_command_1): Add frame_print_options and
5355         backtrace_cmd_options parameters and use them.
5356         (make_backtrace_options_def_group): New.
5357         (backtrace_command): Process command options with
5358         gdb::option::process_options.
5359         (backtrace_command_completer): New.
5360         (_initialize_stack): Extend "backtrace"'s help to mention
5361         supported options.  Install completer for "backtrace".
5362         Install some settings commands with add_setshow_cmds_for_options.
5363
5364 2019-06-13  Pedro Alves  <palves@redhat.com>
5365
5366         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
5367         and that "set/show print raw frame-arguments" are now deprecated.
5368
5369         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
5370         command.
5371         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
5372         * stack.c (_initialize_stack): Install "set/show print
5373         raw-frame-arguments", and deprecate "set/show print raw
5374         frame-arguments".
5375         * valprint.c (_initialize_valprint): Deprecate "set/show print
5376         raw".
5377
5378 2019-06-13  Pedro Alves  <palves@redhat.com>
5379
5380         * compile/compile.c (struct compile_options): New.
5381         (compile_flag_option_def, compile_command_option_defs)
5382         (make_compile_options_def_group): New.
5383         (compile_file_command): Handle options with
5384         gdb::option::process_options.
5385         (compile_file_command_completer): New function.
5386         (compile_code_command): Handle options with
5387         gdb::option::process_options.
5388         (compile_code_command_completer): New function.
5389         (_initialize_compiler): Install completers for "compile code" and
5390         "compile file".  Mention available options in "compile code" and
5391         "compile code"'s help.
5392         * completer.c (advance_to_completion_word): New, factored out from
5393         ...
5394         (advance_to_expression_complete_word_point): ... this.
5395         (advance_to_filename_complete_word_point): New.
5396         * completer.h (advance_to_filename_complete_word_point): New
5397         declaration.
5398
5399 2019-06-13  Pedro Alves  <palves@redhat.com>
5400
5401         * compile/compile.c: Include "cli/cli-option.h".
5402         (compile_print_value): Scope data pointer is now a
5403         value_print_options pointer; adjust.
5404         (compile_print_command): Process options.  Scope data pointer is
5405         now a value_print_options pointer; adjust.
5406         (_initialize_compile): Update "compile print"'s help to include
5407         supported options.  Install a completer for "compile print".
5408         * cp-valprint.c (show_vtblprint, show_objectprint)
5409         (show_static_field_print): Delete.
5410         (_initialize_cp_valprint): Don't install "set print
5411         static-members", "set print vtbl", "set print object" here.
5412         * printcmd.c: Include "cli/cli-option.h" and
5413         "common/gdb_optional.h".
5414         (print_command_parse_format): Rework to fill in a
5415         value_print_options instead of a format_data.
5416         (print_value): Change parameter type from format_data pointer to
5417         value_print_options reference.  Adjust.
5418         (print_command_1): Process options.  Adjust to pass down a
5419         value_print_options.
5420         (print_command_completer): New.
5421         (_initialize_printcmd): Install print_command_completer as
5422         handle_brkchars completer for the "print" command.  Update
5423         "print"'s help to include supported options.
5424         * valprint.c: Include "cli/cli-option.h".
5425         (show_vtblprint, show_objectprint, show_static_field_print): Moved
5426         here from cp-valprint.c.
5427         (boolean_option_def, uinteger_option_def)
5428         (value_print_option_defs, make_value_print_options_def_group):
5429         New.  Use gdb::option::add_setshow_cmds_for_options to install
5430         "set print elements", "set print null-stop", "set print repeats",
5431         "set print pretty", "set print union", "set print array", "set
5432         print address", "set print symbol", "set print array-indexes".
5433         * valprint.h: Include <string> and "cli/cli-option.h".
5434         (make_value_print_options_def_group): Declare.
5435         (print_value): Change parameter type from format_data pointer to
5436         value_print_options reference.
5437         (print_command_completer): Declare.
5438
5439 2019-06-13  Pedro Alves  <palves@redhat.com>
5440
5441         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
5442         (COMMON_SFILES): Add maint-test-settings.c.
5443         * cli/cli-decode.c (boolean_enums): New global, factored out from
5444         ...
5445         (add_setshow_boolean_cmd): ... here.
5446         * cli/cli-decode.h (boolean_enums): Declare.
5447         * cli/cli-option.c: New file.
5448         * cli/cli-option.h: New file.
5449         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
5450         factored out from ...
5451         (parse_cli_boolean_value(const char *)): ... this.
5452         (is_unlimited_literal): Change parameter type to pointer to
5453         pointer.  Adjust and advance ARG pointer.
5454         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5455         (parse_cli_var_enum): New, factored out from ...
5456         (do_set_command): ... this.  Adjust.
5457         * cli/cli-setshow.h (parse_cli_boolean_value)
5458         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5459         (parse_cli_var_enum): Declare.
5460         * cli/cli-utils.c: Include "cli/cli-option.h".
5461         (get_ulongest): New.
5462         * cli/cli-utils.h (get_ulongest): Declare.
5463         (check_for_argument): New overloads.
5464         * maint-test-options.c: New file.
5465
5466 2019-06-13  Pedro Alves  <palves@redhat.com>
5467
5468         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
5469         parse a range if "-" is at the end of the string.
5470
5471 2019-06-13  Pedro Alves  <palves@redhat.com>
5472
5473         * cli/cli-setshow.c (parse_auto_binary_operation)
5474         (parse_cli_boolean_value): Don't allow "o".
5475
5476 2019-06-13  Pedro Alves  <palves@redhat.com>
5477
5478         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
5479         * NEWS: Mention maint test-settings KIND.
5480         * maint-test-settings.c: New file.
5481
5482 2019-06-13  Pedro Alves  <palves@redhat.com>
5483
5484         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
5485         completer.
5486         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
5487         "set" completers.
5488
5489 2019-06-13  Pedro Alves  <palves@redhat.com>
5490
5491         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
5492         after item.
5493
5494 2019-06-13  Pedro Alves  <palves@redhat.com>
5495
5496         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
5497
5498 2019-06-13  Pedro Alves <palves@redhat.com>
5499
5500         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
5501         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
5502         call.
5503         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
5504         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
5505         calls.
5506         (check_for_argument): Skip spaces after argument.
5507
5508 2019-06-13  Pedro Alves  <palves@redhat.com>
5509
5510         * thread.c (thread_apply_command): Adjust TID parsing.
5511         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
5512         detected before end of string.
5513         (tid_is_in_list): Error out if LIST is invalid.
5514
5515 2019-06-13  Pedro Alves  <palves@redhat.com>
5516
5517         * completer.c (complete_line_internal_1): Rewind completion word
5518         point.
5519         (completion_tracker::advance_custom_word_point_by): Change
5520         parameter type to int.
5521         * completer.h (completion_tracker::advance_custom_word_point_by):
5522         Likewise.
5523
5524 2019-06-13  Pedro Alves  <palves@redhat.com>
5525
5526         * completer.c (advance_to_completion_word): Handle delimiters.
5527
5528 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
5529
5530         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
5531
5532 2019-06-11  Tom Tromey  <tom@tromey.com>
5533
5534         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
5535         (xmalloc_failed): Move to alloc.c.
5536         * alloc.c: New file.
5537         * Makefile.in (COMMON_SFILES): Add alloc.c.
5538
5539 2019-06-11  Tom Tromey  <tom@tromey.com>
5540
5541         * nat/linux-waitpid.c: Don't include server.h.
5542         (linux_debug): Remove.
5543         (my_waitpid): Update.
5544
5545 2019-06-11  Tom Tromey  <tromey@adacore.com>
5546
5547         * infcall.c (_initialize_infcall): Remove trailing newline from
5548         help.
5549         * user-regs.c (_initialize_user_regs): Remove trailing newline
5550         from help.
5551         * typeprint.c (_initialize_typeprint): Remove trailing newline
5552         from help.
5553         * reverse.c (_initialize_reverse): Remove trailing newlines from
5554         help.
5555         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
5556         from help.
5557         * language.c (add_set_language_command): Remove trailing newline
5558         from help.
5559         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
5560         help.
5561         * disasm.c (_initialize_disasm): Remove trailing newline from
5562         help.
5563         * top.c (init_main): Remove trailing newline from help.
5564         * interps.c (_initialize_interpreter): Remove trailing newline
5565         from help.
5566         * btrace.c (_initialize_btrace): Remove trailing newlines from
5567         help.
5568         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
5569         from help.
5570         * python/python.c (_initialize_python): Remove trailing newline
5571         from help.
5572         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
5573         help.
5574         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
5575         from help.  Reformat some text.
5576         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
5577         from help.
5578         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
5579         newline from help.
5580
5581 2019-06-11  Tom Tromey  <tromey@adacore.com>
5582
5583         * darwin-nat.c (darwin_decode_exception_message)
5584         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
5585
5586 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5587
5588         * valops.c (value_slice): Check for not allocated or not
5589         associated values.
5590
5591 2019-06-10  Tom de Vries  <tdevries@suse.de>
5592
5593         PR gdb/24618
5594         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
5595         sure an empty slot (defined by a 32-bit zero pair) is recognized as
5596         invalid.
5597
5598 2019-06-10  Tom de Vries  <tdevries@suse.de>
5599
5600         PR gdb/24611
5601         * linespec.c (linespec_lexer_lex_string): Remove incorrect
5602         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
5603
5604 2019-06-10  Tom de Vries  <tdevries@suse.de>
5605
5606         PR symtab/24545
5607         * symtab.c (struct demangled_name_entry): Add language field.
5608         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
5609         static minimal symbol".  Set and use language field.
5610
5611 2019-06-10  Tom Tromey  <tromey@adacore.com>
5612
5613         * ada-lang.c (_initialize_ada_language): Update help text.
5614
5615 2019-06-10  Tom Tromey  <tromey@adacore.com>
5616
5617         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
5618         with a newline.
5619         * guile/guile.c (handle_boot_error): Don't end warning with a
5620         newline.
5621         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
5622         warning with a newline.
5623         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
5624         newline.
5625         (s12z_frame_cache): Likewise.
5626         * dwarf-index-cache.c (index_cache::store): Don't end warning with
5627         a newline.
5628         * solib-svr4.c (disable_probes_interface): Don't end warning with
5629         a newline.
5630         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
5631         newline.
5632         * python/python.c (do_finish_initialization): Don't end warning
5633         with a newline.
5634
5635 2019-06-10  Tom Tromey  <tom@tromey.com>
5636
5637         * python/py-breakpoint.c (gdbpy_breakpoint_created)
5638         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
5639         gdbpy_enter.
5640
5641 2019-06-10  Tom Tromey  <tromey@adacore.com>
5642
5643         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
5644         data.
5645         (elf_new_init): Don't call stabsread_new_init.
5646         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
5647         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
5648         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
5649
5650 2019-06-10  Tom de Vries  <tdevries@suse.de>
5651
5652         PR symtab/16264
5653         PR symtab/24517
5654         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
5655
5656 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
5657
5658         * source.c (find_and_open_source): Also rewrite relative file
5659         names.
5660
5661 2019-04-26  Amos Bird  <amosbird@gmail.com>
5662
5663         * annotate.c (annotate_thread_exited): Add "thread-exited"
5664         annotation.
5665
5666 2019-06-06  Tom Tromey  <tromey@adacore.com>
5667
5668         * maint.h (class scoped_command_stats): Use
5669         DISABLE_COPY_AND_ASSIGN.
5670         <print_time>: New method.
5671         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
5672         print_time.
5673         (scoped_command_stats::print_time): New method.
5674
5675 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
5676
5677         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
5678         instructions of lengths 6 or 8 bytes.
5679
5680 2019-06-04  Pedro Alves  <palves@redhat.com>
5681
5682         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
5683
5684         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
5685         * breakpoint.c (condition_completer): Likewise.
5686         * cli/cli-dump.c (scan_expression): Likewise.
5687         * common/filestuff.c (mkdir_recursive): Likewise.
5688         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
5689         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
5690         (gdb_abspath): Likewise.
5691         * compile/compile-cplus-types.c
5692         (compile_cplus_instance::decl_name): Likewise.
5693         * completer.c (complete_explicit_location):
5694         (signal_completer, reg_or_group_completer_1): Likewise.
5695         * cp-support.c (cp_remove_params_if_any): Likewise.
5696         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
5697         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
5698         * infcmd.c (strip_bg_char): Likewise.
5699         * linespec.c (copy_token_string): Likewise.
5700         * mi/mi-main.c (output_cores): Likewise.
5701         * psymtab.c (psymtab_search_name):
5702         * symfile.c (test_set_ext_lang_command): Likewise.
5703         * target.c (target_fileio_read_stralloc): Likewise.
5704         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
5705         * value.c (complete_internalvar): Likewise.
5706
5707 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
5708
5709         Add objfile property to gdb.Type.
5710         * NEWS: Mention Python API addition.
5711         * python/py-type.c (typy_get_objfile): New method.
5712
5713 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5714
5715         * NEWS: Mention the new set|show style [title|highlight].
5716         Mention changes to "show style", "help" and "apropos".
5717
5718 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5719
5720         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
5721         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
5722         instead of print_help_for_command.
5723         (print_doc_of_command): New function.
5724         (help_list): Add 'apropos -v word' suggestion.
5725         (print_help_for_command): Style the command name using title style.
5726         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
5727         (_initialize_cli_cmds): Describe -v in apropos_command help.
5728
5729 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5730
5731         * cli/cli-style.h (cli_style_option): Add name in constructor,
5732         add m_name class member, add constructor with intensity,
5733         add name class function.
5734         (cli_style_option::add_setshow_commands): Remove name argument.
5735         (highlight_style, title_style): New styles.
5736         * cli/cli-style.c (do_show): New function that shows a style
5737         characteristic styling the style name with itself.
5738         (set_style_name): New function.
5739         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
5740         Update all callers according to the changes in cli/cli-style.h.
5741         * utils.h (fputs_highlighted): New function.
5742         * utils.c (fputs_highlighted): Likewise.
5743
5744 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5745
5746         * NEWS: Mention new pipe command and new convenience variables.
5747
5748 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5749
5750         * cli/cli-cmds.c (pipe_command): New function.
5751         (_initialize_cli_cmds): Call add_com for pipe_command.
5752         Define | as an alias for pipe.
5753         (exit_status_set_internal_vars): New function.
5754         (shell_escape): Call exit_status_set_internal_vars.
5755         cli/cli-decode.c (find_command_name_length): Recognize | as
5756         a single character command.
5757
5758 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5759
5760         * gdbcmd.h (execute_command_to_ui_file): New declaration.
5761         top.c (execute_command_to_ui_file): New function, mostly a copy
5762         of execute_command_to_string.
5763         (execute_command_to_string): Implement by calling
5764         execute_command_to_ui_file.
5765
5766 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5767
5768         * top.h (saved_command_line): Remove declaration.
5769         * top.c (previous_saved_command_line, previous_repeat_arguments):
5770         New variables.
5771         (saved_command_line): Make static, define together with other
5772         'repeat variables'.
5773         (dont_repeat): Clear repeat_arguments.
5774         (repeat_previous, get_saved_command_line, save_command_line):
5775         New functions.
5776         (gdb_init): Initialize saved_command_line
5777         and previous_saved_command_line.
5778         * main.c (captured_main_1): Remove saved_command_line initialization.
5779         * event-top.c (handle_line_of_input): Update to use
5780         the new 'repeat' related functions instead of direct access to
5781         saved_command_line.
5782         * command.h (repeat_previous, get_saved_command_line,
5783         save_command_line): New declarations.
5784         (dont_repeat): Add comment.
5785
5786 2019-05-30  Tom Tromey  <tromey@adacore.com>
5787
5788         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
5789         Fix comment.
5790         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
5791
5792 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
5793
5794         PR cli/24587
5795         * completer.c (complete): Initialize variable word.
5796
5797 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
5798
5799         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5800         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
5801         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
5802         'body' is NULL to the outter 'if', protecting the '!is_define'
5803         situation as well.
5804
5805 2019-05-29  Tom Tromey  <tromey@adacore.com>
5806
5807         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
5808         (dwarf_unknown): New function.
5809         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
5810         (dwarf_type_encoding_name): Use dwarf_unknown.
5811
5812 2019-05-29  Tom Tromey  <tromey@adacore.com>
5813
5814         PR c++/20020:
5815         * cp-valprint.c (cp_print_value_fields): Call
5816         cp_print_static_field inside "try".
5817
5818 2019-05-29  Tom Tromey  <tromey@adacore.com>
5819
5820         * inflow.c (struct terminal_info): Add default operator=.
5821         * configure: Rebuild.
5822         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
5823         -Wdeprecated-copy-dtor, -Wredundant-move.
5824
5825 2019-05-29  Tom Tromey  <tromey@adacore.com>
5826
5827         * NEWS: Add entry.
5828         * infcmd.c (print_return_value_1): Handle finish_print
5829         option.
5830         (show_print_finish): New function.
5831         (_initialize_infcmd): Add "set/show print finish" commands.
5832         * valprint.c (user_print_options): Initialize new member.
5833         * valprint.h (struct value_print_options) <finish_print>: New
5834         member.
5835
5836 2019-05-28  Tom Tromey  <tromey@adacore.com>
5837
5838         * ada-lang.c (ada_remove_Xbn_suffix)
5839         (find_old_style_renaming_symbol)
5840         (parse_old_style_renaming): Remove.
5841         (ada_find_renaming_symbol): Don't call
5842         find_old_style_renaming_symbol.
5843         (ada_is_renaming_symbol): Rename from
5844         ada_find_renaming_symbol.  Remove "block" parameter.  Return
5845         bool.  Now static.
5846         (ada_read_var_value): Update and simplify.
5847         * ada-exp.y (write_var_or_type): Remove old code.
5848
5849 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
5850
5851         * event-top.c: Remove include comment.
5852         * inflow.c (class scoped_ignore_sigttou): Move from here...
5853         * inflow.h (class scoped_ignore_sigttou): ...to here.
5854         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
5855         * top.c:  Remove include comment.
5856
5857 2019-05-27  Tom Tromey  <tom@tromey.com>
5858
5859         * NEWS: Fix typo.
5860
5861 2019-05-22  Tom Tromey  <tromey@adacore.com>
5862
5863         * target.c (target_follow_exec): Constify parameter.
5864         * target-delegates.c: Rebuild.
5865         * remote.c (remote_target::follow_exec): Constify parameter.
5866         * infrun.c (follow_exec): Constify parameter.
5867         * target.h (struct target_ops) <follow_exec>: Constify parameter.
5868         (target_follow_exec): Likewise.
5869
5870 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5871
5872         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
5873         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
5874
5875 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5876
5877         * NEWS: Add debugredirect and testsuite sections.
5878
5879 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
5880
5881         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
5882         target descriptions using exclusively floating point register name
5883         aliases.
5884
5885 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
5886
5887         PR gdb/18644:
5888         * f-lang.c (build_fortran_types): Handle the case where
5889         gdbarch_floatformat_for_type returns a nullptr.
5890
5891 2019-05-21  Tom de Vries  <tdevries@suse.de>
5892
5893         PR cli/24587
5894         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
5895
5896 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5897
5898         PR gdb/18644:
5899         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
5900         16-byte floats.
5901         * i386-tdep.c (i386_floatformat_for_type): Use
5902         floatformats_ia64_quad for the 16-byte floating point component
5903         within a fortran 32-byte complex number.
5904
5905 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5906
5907         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
5908         delete default constructor.
5909         (find_partial_die): Update to return const struct.
5910         (partial_die_parent_scope): Move variable declaration into scope
5911         of its use and change its type to auto.
5912         (guess_partial_die_structure_name): Likewise.
5913         (partial_die_info::fixup): Likewise.
5914
5915 2019-05-17  Tom Tromey  <tromey@adacore.com>
5916
5917         * source.c (find_and_open_source): Remove cast.
5918
5919 2019-05-17  Tom Tromey  <tromey@adacore.com>
5920
5921         * annotate.c (annotate_source): Make "filename" const.
5922         * annotate.h (annotate_source): Use const.
5923
5924 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5925
5926         * disasm.c (set_disassembler_options): Send errors to stderr.
5927
5928 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5929
5930         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
5931         (cli_interp_base::set_logging): Check debug_redirect.
5932         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
5933         * cli/cli-logging.c (debug_redirect): Add static variable.
5934         (pop_output_files): Add default param.
5935         (handle_redirections): Print debug setting.
5936         (show_logging_command): Likewise.
5937         (_initialize_cli_logging): Add debugredirect command.
5938         * interps.c (current_interp_set_logging): Add debug_redirect
5939         parameter.
5940         * interps.h (set_logging): Add debug_redirect parameter.
5941         (current_interp_set_logging): Likewise.
5942         * mi/mi-common.h: Likewise.
5943         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
5944
5945 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5946             Tom Tromey  <tromey@adacore.com>
5947
5948         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
5949         directly.
5950         * cli/cli-interp.h (make_logging_output): Remove declaration.
5951         * cli/cli-logging.c (make_logging_output): Remove function.
5952         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
5953         directly.
5954         * ui-file.c (tee_file::tee_file): Remove bools.
5955         (tee_file::~tee_file): Remove deletes.
5956         * ui-file.h (tee_file): Remove bools.
5957
5958 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
5959
5960         * mi/mi-cmds.h (mi_cmd_complete): New function.
5961         * mi/mi-main.c (mi_cmd_complete): Likewise.
5962         * mi/mi-cmds.c: Define new MI command -complete.
5963         * NEWS: Mention new -complete command.
5964
5965 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
5966
5967         * completer.h (complete): New function.
5968         * completer.c (complete): Likewise.
5969         * cli/cli-cmds.c: (complete_command): Update to use new complete()
5970         function defined in completer.h.
5971
5972 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
5973
5974         * MAINTAINERS (Write After Approval): Add myself.
5975
5976 2019-05-17  Tom de Vries  <tdevries@suse.de>
5977
5978         PR gdb/24094
5979         * dwarf2read.c (struct cu_partial_die_info): New struct.
5980         (find_partial_die): Return cu_partial_die_info.
5981         (partial_die_parent_scope, guess_partial_die_structure_name)
5982         (partial_die_info::fixup): Handle new return type of find_partial_die.
5983
5984 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5985
5986         PR breakpoints/24541
5987         * stap-probe.c (stap_parse_register_operand): Make "regname" an
5988         "std::string", simplifying the algorithm.
5989
5990 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5991
5992         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
5993         (stap_static_probe_ops::get_probes): Likewise.
5994
5995 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5996
5997         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
5998         '-')" and "else if".
5999         (stap_parse_single_operand): Join checks for
6000         "gdbarch_stap_parse_special_token_p" and
6001         "gdbarch_stap_parse_special_token" in the same "if" statement.
6002         Invert check when verifying for operation on register
6003         displacement.
6004
6005 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6006
6007         * stap-probe.c (stap_get_opcode): Update comment.
6008         (stap_get_expected_argument_type): Likewise.
6009         (handle_stap_probe): Likewise.
6010
6011 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6012
6013         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
6014         return type to 'bool'.  Adjust comment.  Use 'bool' when
6015         appropriate.
6016         (i386_stap_parse_special_token_three_arg_disp): Likewise.
6017         * stap-probe.c (stap_parse_argument_1): Likewise.
6018         (stap_is_operator): Likewise.
6019         (stap_is_generic_prefix): Likewise.
6020         (stap_is_register_prefix): Likewise.
6021         (stap_is_register_indirection_prefix): Likewise.
6022         (stap_is_integer_prefix): Likewise.
6023         (stap_generic_check_suffix): Likewise.
6024         (stap_check_integer_suffix): Likewise.
6025         (stap_check_register_suffix): Likewise.
6026         (stap_check_register_indirection_suffix): Likewise.
6027         (stap_parse_register_operand): Likewise.
6028         (stap_parse_single_operand): Likewise.
6029         (stap_parse_argument_1): Likewise.
6030         (stap_probe::get_argument_count): Likewise.
6031         (stap_is_operator): Likewise.
6032
6033 2019-05-16  Tom Tromey  <tromey@adacore.com>
6034
6035         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
6036         keyword to foreach.
6037
6038 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
6039
6040         * linux-thread-db.c (try_thread_db_load_1): Change return type
6041         to bool.
6042         (try_thread_db_load): Likewise.
6043         (try_thread_db_load_from_pdir_1): Likewise.
6044         (try_thread_db_load_from_pdir): Likewise.
6045         (try_thread_db_load_from_sdir): Likewise.
6046         (try_thread_db_load_from_dir): Likewise.
6047         (thread_db_load_search): Likewise.
6048         (has_libpthread): Likewise.
6049         (thread_db_load): Likewise.
6050
6051 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
6052
6053         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6054         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
6055         NULL, and complain/return if that's the case.
6056
6057 2019-05-15  John Darrington <john@darrington.wattle.id.au>
6058
6059         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
6060         (advance, posn, abstract_read_memory): New functions.
6061         [struct mem_read_abstraction]: New struct.
6062         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
6063
6064 2019-05-14  Tom Tromey  <tromey@adacore.com>
6065
6066         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
6067         value is not lval_memory.
6068
6069 2019-05-14  Tom Tromey  <tromey@adacore.com>
6070
6071         * solib.c (info_sharedlibrary_command): Style the file name.
6072
6073 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
6074
6075         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
6076         (aarch64_vnv_type): Likewise.
6077         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
6078         * common/tdesc.c: Likewise.
6079         * common/tdesc.h (enum tdesc_type_kind): Likewise.
6080         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
6081         * features/aarch64-fpu.xml: Add ieee half view.
6082         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
6083         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
6084         * gdbtypes.h (struct builtin_type): Likewise.
6085         (struct objfile_type): Likewise.
6086
6087 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
6088
6089         * language.c (language_sniff_from_mangled_name): Fix "langauge"
6090         typo.
6091         * location.h (string_to_event_location): Likewise.
6092
6093 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
6094
6095         GDB 8.3 released.
6096
6097 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6098
6099         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
6100         New variable declaration.
6101         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
6102         New variable.
6103         (print_one_breakpoint): Use ui_out::test_flags and new global
6104         variable to compute use_fixed_output.
6105         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
6106         Remove.
6107         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
6108         (mi_multi_location_breakpoint_output_fixed): Remove.
6109         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
6110         new variable.
6111         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
6112         fix_multi_location_breakpoint_output flag if version >= 3.
6113         * ui-out.h (enum ui_out_flag)
6114         <fix_multi_location_breakpoint_output>: New enumerator.
6115
6116 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6117
6118         * contrib/cc-with-tweaks.sh: Validate dwz's work.
6119
6120 2019-05-10  Tom Tromey  <tromey@adacore.com>
6121
6122         * ada-lang.c (catch_ada_completer): New function.
6123         (_initialize_ada_language): Use it.
6124
6125 2019-05-10  Tom Tromey  <tromey@adacore.com>
6126
6127         * thread.c (print_thread_info): Make "requested_threads" const.
6128         * gdbthread.h (print_thread_info): Make "requested_threads"
6129         const.
6130         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
6131         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
6132
6133 2019-05-08  Tom Tromey  <tom@tromey.com>
6134
6135         * gdbtypes.c (objfile_type_data): Change type.
6136         (objfile_type, _initialize_gdbtypes): Update.
6137
6138 2019-05-08  Tom Tromey  <tom@tromey.com>
6139
6140         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
6141         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
6142         (_initialize_dwarf2_frame): Update.
6143
6144 2019-05-08  Tom Tromey  <tom@tromey.com>
6145
6146         * objc-lang.c (objc_objfile_data): Change type.
6147         (find_methods): Update.
6148         (_initialize_objc_lang): Remove.
6149
6150 2019-05-08  Tom Tromey  <tom@tromey.com>
6151
6152         * stabsread.c (rs6000_builtin_type_data): Change type.
6153         (rs6000_builtin_type, _initialize_stabsread): Update.
6154
6155 2019-05-08  Tom Tromey  <tom@tromey.com>
6156
6157         * mips-tdep.c (mips_pdr_data): Remove.
6158         (_initialize_mips_tdep): Update.
6159
6160 2019-05-08  Tom Tromey  <tom@tromey.com>
6161
6162         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
6163         (hppa_init_objfile_priv_data, read_unwind_info)
6164         (find_unwind_entry, _initialize_hppa_tdep): Update.
6165
6166 2019-05-08  Tom Tromey  <tom@tromey.com>
6167
6168         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
6169         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
6170         on obstack.
6171         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
6172
6173 2019-05-08  Tom Tromey  <tom@tromey.com>
6174
6175         * mdebugread.c (basic_type_data): Change type.
6176         (basic_type, _initialize_mdebugread): Update.
6177
6178 2019-05-08  Tom Tromey  <tom@tromey.com>
6179
6180         * common/gdb_unique_ptr.h (struct noop_deleter): New.
6181
6182 2019-05-08  Tom Tromey  <tom@tromey.com>
6183
6184         * nto-tdep.c (nto_inferior_data_reg): Change type.
6185         (nto_inferior_data): Update.
6186         (nto_inferior_data_cleanup, nto_new_inferior_data)
6187         (_initialize_nto_tdep): Remove.
6188         * nto-tdep.h (struct nto_inferior_data): Add initializers.
6189
6190 2019-05-08  Tom Tromey  <tom@tromey.com>
6191
6192         * ada-lang.c (struct ada_inferior_data): Add initializers.
6193         (ada_inferior_data): Change type.
6194         (ada_inferior_data_cleanup): Remove.
6195         (get_ada_inferior_data, ada_inferior_exit)
6196         (struct ada_pspace_data): Add initializers, destructor.
6197         (ada_pspace_data_handle): Change type.
6198         (get_ada_pspace_data): Update.
6199         (ada_pspace_data_cleanup): Remove.
6200
6201 2019-05-08  Tom Tromey  <tom@tromey.com>
6202
6203         * coffread.c (struct coff_symfile_info): Add initializers.
6204         (coff_objfile_data_key): Move lower.  Change type.
6205         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
6206         Update.
6207         (coff_free_info): Remove.
6208
6209 2019-05-08  Tom Tromey  <tom@tromey.com>
6210
6211         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
6212         (fbsd_pspace_data_handle): Move lower.  Change type.
6213         (get_fbsd_pspace_data): Update.
6214         (fbsd_pspace_data_cleanup): Remove.
6215         (_initialize_fbsd_tdep): Update.
6216
6217 2019-05-08  Tom Tromey  <tom@tromey.com>
6218
6219         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
6220         (get_ada_tasks_pspace_data): Update.
6221         (ada_tasks_pspace_data_cleanup): Remove.
6222         (_initialize_tasks): Update.
6223         (ada_tasks_inferior_data_handle): Change type.
6224         (get_ada_tasks_inferior_data): Update.
6225         (ada_tasks_inferior_data_cleanup): Remove.
6226         (struct ada_tasks_pspace_data): Add initializers.
6227
6228 2019-05-08  Tom Tromey  <tom@tromey.com>
6229
6230         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
6231         * symfile-debug.c (debug_sym_get_probes): Change type.
6232         * stap-probe.c (handle_stap_probe):
6233         (stap_static_probe_ops::get_probes): Change type.
6234         * probe.h (class static_probe_ops) <get_probes>: Change type.
6235         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
6236         (parse_probes_in_pspace): Update.
6237         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
6238         Update.
6239         (any_static_probe_ops::get_probes): Change type.
6240         * elfread.c (elfread_data): New typedef.
6241         (probe_key): Change type.
6242         (elf_get_probes): Likewise.  Update.
6243         (probe_key_free): Remove.
6244         (_initialize_elfread): Update.
6245         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
6246         Change type.
6247         (dtrace_process_dof_probe, dtrace_process_dof)
6248         (dtrace_static_probe_ops::get_probe): Change type.
6249
6250 2019-05-08  Tom Tromey  <tom@tromey.com>
6251
6252         * xcoffread.c (struct xcoff_symfile_info): Rename from
6253         coff_symfile_info.  Add initializers.
6254         (xcoff_objfile_data_key): Move lower.  Change type.
6255         (XCOFF_DATA): Rewrite.
6256         (xcoff_free_info): Remove.
6257         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
6258         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
6259         (xcoff_initial_scan): Update.
6260
6261 2019-05-08  Tom Tromey  <tom@tromey.com>
6262
6263         * solib-svr4.c (struct svr4_info): Add initializers and
6264         destructor.
6265         <probes_table>: Now an htab_up.
6266         (solib_svr4_pspace_data): Change type.
6267         (free_probes_table): Simplify.
6268         (~svr4_info): Rename from svr4_pspace_data_cleanup.
6269         (get_svr4_info, probes_table_htab_remove_objfile_probes)
6270         (probes_table_remove_objfile_probes, register_solib_event_probe)
6271         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
6272         (_initialize_svr4_solib): Update.
6273
6274 2019-05-08  Tom Tromey  <tom@tromey.com>
6275
6276         * remote.c (remote_pspace_data): Change type.
6277         (remote_pspace_data_cleanup): Remove.
6278         (get_remote_exec_file, set_pspace_remote_exec_file)
6279         (_initialize_remote): Update.
6280
6281 2019-05-08  Tom Tromey  <tom@tromey.com>
6282
6283         * breakpoint.c (breakpoint_objfile_key): Change type.
6284         (get_breakpoint_objfile_data): Update.
6285         (free_breakpoint_objfile_data): Remove.
6286         (_initialize_breakpoint): Update.
6287
6288 2019-05-08  Tom Tromey  <tom@tromey.com>
6289
6290         * linux-tdep.c (struct linux_info): Add initializers.
6291         (linux_inferior_data): Move.  Change type.
6292         (invalidate_linux_cache_inf): Update.
6293         (linux_inferior_data_cleanup): Remove.
6294         (get_linux_inferior_data, _initialize_linux_tdep): Update.
6295
6296 2019-05-08  Tom Tromey  <tom@tromey.com>
6297
6298         * auxv.c (auxv_inferior_data): Move.  Change type.
6299         (auxv_inferior_data_cleanup): Remove.
6300         (invalidate_auxv_cache_inf): Rewrite.
6301         (get_auxv_inferior_data, _initialize_auxv): Update.
6302
6303 2019-05-08  Tom Tromey  <tom@tromey.com>
6304
6305         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
6306         (symfile_debug_objfile_data_key): Change type.
6307         (symfile_debug_installed, debug_qf_has_symbols)
6308         (debug_qf_find_last_source_symtab)
6309         (debug_qf_forget_cached_source_info)
6310         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
6311         (debug_qf_print_stats, debug_qf_dump)
6312         (debug_qf_expand_symtabs_for_function)
6313         (debug_qf_expand_all_symtabs)
6314         (debug_qf_expand_symtabs_with_fullname)
6315         (debug_qf_map_matching_symbols)
6316         (debug_qf_expand_symtabs_matching)
6317         (debug_qf_find_pc_sect_compunit_symtab)
6318         (debug_qf_map_symbol_filenames)
6319         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
6320         (debug_sym_new_init, debug_sym_init, debug_sym_read)
6321         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
6322         (debug_sym_read_linetable, debug_sym_relocate): Update.
6323         (symfile_debug_free_objfile): Remove.
6324         (install_symfile_debug_logging, _initialize_symfile_debug):
6325         Update.
6326
6327 2019-05-08  Tom Tromey  <tom@tromey.com>
6328
6329         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
6330         allocate_on_obstack.
6331         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
6332         (get_dwarf2_per_objfile): Update.
6333         (set_dwarf2_per_objfile): Remove.
6334         (dwarf2_has_info, dwarf2_get_section_info): Update.
6335         (dwarf2_free_objfile): Remove.
6336         (_initialize_dwarf2_read): Update.
6337
6338 2019-05-08  Tom Tromey  <tom@tromey.com>
6339
6340         * auto-load.c (struct auto_load_pspace_info): Add destructor and
6341         initializers.
6342         <unsupported_script_warning_printed,
6343         script_not_found_warning_printed>: Now bool.
6344         (auto_load_pspace_data): Change type.
6345         (~auto_load_pspace_info): Rename from
6346         auto_load_pspace_data_cleanup.
6347         (get_auto_load_pspace_data, init_loaded_scripts_info)
6348         (clear_section_scripts, maybe_print_unsupported_script_warning)
6349         (maybe_print_script_not_found_warning, _initialize_auto_load):
6350         Update.
6351
6352 2019-05-08  Tom Tromey  <tom@tromey.com>
6353
6354         * objfiles.c (objfile_pspace_info): Add destructor and
6355         initializers.
6356         (objfiles_pspace_data): Change type.
6357         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
6358         (get_objfile_pspace_data): Update.
6359         (objfiles_bfd_data): Change type.
6360         (get_objfile_bfd_data): Update.
6361         (objfile_bfd_data_free, _initialize_objfiles): Remove.
6362
6363 2019-05-08  Tom Tromey  <tom@tromey.com>
6364
6365         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
6366         Change type.
6367         (get_catch_syscall_inferior_data): Update.
6368         (catch_syscall_inferior_data_cleanup): Remove.
6369         (_initialize_break_catch_syscall): Update.
6370
6371 2019-05-08  Tom Tromey  <tom@tromey.com>
6372
6373         * inflow.c (struct terminal_info): Add destructor and
6374         initializers.
6375         (inflow_inferior_data): Change type.
6376         (~terminal_info): Rename from inflow_inferior_data_cleanup.
6377         (get_inflow_inferior_data, inflow_inferior_exit)
6378         (swap_terminal_info, _initialize_inflow): Update.
6379
6380 2019-05-08  Tom Tromey  <tom@tromey.com>
6381
6382         * target-dcache.c (target_dcache_cleanup): Remove.
6383         (target_dcache_aspace_key): Change type.
6384         (target_dcache_init_p, target_dcache_invalidate)
6385         (target_dcache_get, target_dcache_get_or_init)
6386         (_initialize_target_dcache): Update.
6387         * dcache.h (struct dcache_deleter): New.
6388
6389 2019-05-08  Tom Tromey  <tom@tromey.com>
6390
6391         * symtab.c (struct symbol_cache): Add destructor and
6392         initializers.
6393         (symbol_cache_key): Move.  Change type.
6394         (make_symbol_cache, free_symbol_cache): Remove.
6395         (get_symbol_cache): Update.
6396         (symbol_cache_cleanup): Remove.
6397         (ALL_PSPACES, symbol_cache_flush)
6398         (maintenance_print_symbol_cache)
6399         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
6400         Update.
6401
6402 2019-05-08  Tom Tromey  <tom@tromey.com>
6403
6404         * symtab.c (struct main_info): Add destructor and initializers.
6405         (main_progspace_key): Move.  Change type.
6406         (get_main_info): Update.
6407         (main_info_cleanup): Remove.
6408         (_initialize_symtab): Update.
6409
6410 2019-05-08  Tom Tromey  <tom@tromey.com>
6411
6412         * registry.h (DECLARE_REGISTRY): Define the _key class.
6413
6414 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6415
6416         * NEWS: Merge two 'New commands' sections.
6417
6418 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
6419
6420         * ada-valprint.c (ada_val_print_gnat_array): Remove language
6421         parameter and use Ada language definition instead.
6422         (ada_val_print_ptr): Remove unused language parameter.
6423         (ada_val_print_num): Remove language parameter and use Ada language
6424         definition instead.
6425         (ada_val_print_enum, ada_val_print_flt): Remove unused language
6426         parameter.
6427         (ada_val_print_struct_union, ada_val_print_ref): Remove language
6428         parameter and use Ada language definition instead.
6429         (ada_val_print_1): Update all ada_val_print_xxx calls.
6430         Remove language parameter.
6431         (ada_val_print): Update ada_val_print_1 call.
6432
6433 2019-05-08  Tom Tromey  <tromey@adacore.com>
6434
6435         * remote.c (remote_hw_watchpoint_limit)
6436         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
6437         Now static.
6438
6439 2019-05-08  Tom Tromey  <tromey@adacore.com>
6440
6441         * maint.c (_initialize_maint_cmds): Move initialization code to
6442         remote.c.
6443         (watchdog, show_watchdog): Move to remote.c.
6444         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
6445         "watchdog" static.
6446         (_initialize_remote): Move initialization code from maint.c.
6447         * defs.h (watchdog): Don't declare.
6448
6449 2019-05-08  Tom Tromey  <tromey@adacore.com>
6450
6451         * tui/tui-interp.c: Include main.h.
6452         * interps.c: Include main.h.
6453         * main.h (interpreter_p): Declare.
6454         * defs.h (interpreter_p): Don't declare.
6455
6456 2019-05-08  Tom Tromey  <tromey@adacore.com>
6457
6458         * dwarf2loc.c: Include dwarf2read.h.
6459         * defs.h (read_unsigned_leb128): Don't declare.
6460         * dwarf2read.h (read_unsigned_leb128): Declare.
6461
6462 2019-05-08  Tom Tromey  <tromey@adacore.com>
6463
6464         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
6465         method.
6466
6467 2019-05-08  Tom Tromey  <tromey@adacore.com>
6468
6469         * utils.c (fputs_maybe_filtered): Reset style after paging, even
6470         when no wrap column is set.
6471
6472 2019-05-08  Tom Tromey  <tromey@adacore.com>
6473
6474         * c-lang.c (c_get_string): Handle non-C-style arrays.
6475
6476 2019-05-08  Tom Tromey  <tromey@adacore.com>
6477
6478         * typeprint.c (print_offset_data::update): Print the bit offset,
6479         not the number of bits remaining.
6480
6481 2019-05-08  Tom Tromey  <tromey@adacore.com>
6482
6483         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
6484         padding at end of comment.
6485
6486 2019-05-08  Tom Tromey  <tromey@adacore.com>
6487
6488         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
6489         Compare main types.
6490
6491 2019-05-06  Tom Tromey  <tom@tromey.com>
6492
6493         * common/scoped_mmap.c: Include common-defs.h.
6494         * common/scoped_mmap.h: Don't include config.h.
6495
6496 2019-05-04  Tom Tromey  <tom@tromey.com>
6497
6498         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
6499         (struct aarch64_call_info): Add initializers.
6500         <si>: Now a std::vector.
6501         (pass_on_stack, aarch64_push_dummy_call): Update.
6502
6503 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
6504             Tom Tromey  <tom@tromey.com>
6505
6506         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
6507         (ppc_threads): Now a std::vector.  Now static.
6508         (hwdebug_find_thread_points_by_tid)
6509         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
6510         Update.
6511
6512 2019-05-04  Tom Tromey  <tom@tromey.com>
6513
6514         * arc-tdep.c (arc_tdesc_init): Return bool.
6515
6516 2019-05-04  Tom Tromey  <tom@tromey.com>
6517
6518         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
6519         Use gdb_assert_not_reached.
6520
6521 2019-05-04  Tom Tromey  <tom@tromey.com>
6522
6523         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
6524         "false".
6525
6526 2019-05-04  Tom Tromey  <tom@tromey.com>
6527
6528         * arc-tdep.c (arc_tdesc_init): Use bool.
6529
6530 2019-05-04  Tom Tromey  <tom@tromey.com>
6531
6532         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
6533
6534 2019-05-04  Tom Tromey  <tom@tromey.com>
6535
6536         * cli/cli-cmds.c (valid_command_p): Return bool.
6537
6538 2019-05-04  Tom Tromey  <tom@tromey.com>
6539
6540         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
6541         * command.h (valid_user_defined_cmd_name_p): Channge return type.
6542
6543 2019-05-04  Raul Tambre  <raul@tambre.ee>
6544
6545         * python/lib/gdb/prompt.py (_ExtendedPrompt)
6546         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
6547         operator for comparison.
6548
6549 2019-05-04  Tom Tromey  <tom@tromey.com>
6550
6551         * psymtab.c (psymbol_name_matches, match_partial_symbol)
6552         (lookup_partial_symbol, print_partial_symbols)
6553         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
6554         (psymbol_compare): Update.
6555         (add_psymbol_to_bcache): Clear the entire psymbol.
6556         (maintenance_check_psymtabs): Update.
6557         * psympriv.h (struct partial_symbol): Don't derive from
6558         general_symbol_info.
6559         <obj_section, unrelocated_address, address,
6560         set_unrelocated_address>: Update.
6561         <ginfo>: New member.
6562         * dwarf-index-write.c (write_psymbols, debug_names::insert)
6563         (debug_names::write_psymbols): Update.
6564
6565 2019-05-04  Tom de Vries  <tdevries@suse.de>
6566
6567         * contrib/cc-with-tweaks.sh: Support -n arg.
6568
6569 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6570
6571         * corelow.c (core_target::detach): Ensure frame cache and
6572         register caches are cleared.
6573         inferior.c (exit_inferior_1): Likewise.
6574
6575 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
6576             Tom Tromey  <tom@tromey.com>
6577
6578         * dictionary.c (collate_pending_symbols_by_language): Remove
6579         "struct" from foreach.
6580         * symtab.c (lookup_global_symbol_from_objfile)
6581         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
6582         foreach.
6583         * ser-tcp.c (net_open): Remove "struct" from foreach.
6584         * objfiles.c (objfile_relocate, objfile_rebase)
6585         (objfile_has_symbols): Remove "struct" from foreach.
6586         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
6587         from foreach.
6588         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
6589         foreach.
6590         * darwin-nat.c (thread_info_from_private_thread_info): Remove
6591         "struct" from foreach.
6592         * ada-lang.c (create_excep_cond_exprs)
6593         (ada_exception_catchpoint_cond_string): Remove "struct" from
6594         foreach.
6595
6596 2019-05-03  Tom Tromey  <tromey@adacore.com>
6597
6598         * ada-exp.y (convert_char_literal): Check suffix of each
6599         enumerator.
6600
6601 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
6602
6603         PR ada/21406:
6604         * ada-exp.y (yywrap): Don't define.
6605         * ada-lex.l (%option): Add noyywrap
6606         (yywrap): Remove.
6607
6608 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
6609
6610         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
6611         _WIN32_WINNT to the XP level, unless already defined to a higher
6612         level.
6613
6614         * unittests/parse-connection-spec-selftests.c:
6615         * ser-tcp.c:
6616         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
6617         override.
6618
6619         * symfile.c (find_separate_debug_file): Remove colon from the
6620         drive spec of DOS/Windows file names of the target, so that the
6621         file name produced from DEBUGDIR and the target's directory will
6622         be valid on DOS/Windows systems.
6623
6624 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
6625
6626         * rust-lang.c (val_print_struct): Handle printing structures
6627         containing strings.
6628
6629 2019-05-02  Tom Tromey  <tromey@adacore.com>
6630
6631         * valarith.c (_initialize_valarith): Remove.
6632
6633 2019-05-01  Tom Tromey  <tromey@adacore.com>
6634
6635         * ada-lang.c (ada_value_primitive_field): Treat more fields as
6636         bitfields.
6637
6638 2019-05-01  Tom Tromey  <tromey@adacore.com>
6639
6640         * ada-lang.c (ada_value_assign): Correctly compute starting offset
6641         for big-endian copies.
6642
6643 2019-04-30  Ali Tamur  <tamur@google.com>
6644         * gdb/dwarf2read.c (read_3_bytes): New declaration.
6645         (read_attribute_value): Added DW_FORM_strx1-4 cases.
6646         (read_3_bytes): New function.
6647
6648 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6649
6650         * windows-nat.c (main_thread_id): Delete.
6651         (handle_output_debug_string): Replace main_thread_id by
6652         current_event.dwThreadId.
6653         (fake_create_process): Likewise.
6654         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
6655         Do not set main_thread_id.
6656         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
6657         current_event.dwThreadId.
6658         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
6659
6660 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6661
6662         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
6663         Use current_event.dwThreadId instead of main_thread_id.
6664
6665 2019-04-30  Tom Tromey  <tromey@adacore.com>
6666
6667         * ada-lang.c (ada_lookup_simple_minsyms): New function.
6668         (create_excep_cond_exprs): Iterate over program spaces.
6669         (ada_exception_catchpoint_cond_string): Examine all minimal
6670         symbols for exception types.
6671
6672 2019-04-30  Tom Tromey  <tromey@adacore.com>
6673
6674         PR c++/24470:
6675         * dwarf2read.c (process_structure_scope): Handle case where type
6676         has template parameters but no symbol was created.
6677
6678 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6679             Chris January  <chris.january@arm.com>
6680
6681         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
6682         qualifier.
6683         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
6684
6685 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6686
6687         * f-typeprint.c (f_print_type): Update rules for printing
6688         whitespace.
6689         (f_type_print_varspec_suffix): Likewise.
6690
6691 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6692             Chris January  <chris.january@arm.com>
6693
6694         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
6695         function arguments.
6696
6697 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6698
6699         * f-lang.c (build_fortran_types): Change name of void type to
6700         lower case.
6701         * f-typeprint.c (f_type_print_base): Print the name of the void
6702         type, rather than a fixed string.
6703         * f-valprint.c (f_decorations): Use lower case void string.
6704
6705 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6706             Chris January  <chris.january@arm.com>
6707
6708         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
6709         types for Fortran.
6710
6711 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6712             Chris January  <chris.january@arm.com>
6713             David Lecomber  <david.lecomber@arm.com>
6714
6715         * f-exp.y (BINOP_INTRINSIC): New token.
6716         (exp): New parser rule handling BINOP_INTRINSIC.
6717         (f77_keywords): Add new builtin procedures.
6718         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
6719         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6720         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
6721         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6722         (print_unop_subexp_f): New function.
6723         (print_binop_subexp_f): New function.
6724         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6725         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6726         (dump_subexp_body_f): Likewise.
6727         (operator_check_f): Likewise.
6728         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6729         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
6730
6731 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6732
6733         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
6734         UNOP_KIND.
6735         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
6736         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
6737         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
6738         (operator_length_f): New fuction.
6739         (print_subexp_f): New function.
6740         (op_name_f): New function.
6741         (dump_subexp_body_f): New function.
6742         (operator_check_f): New function.
6743         (exp_descriptor_f): Replace standard expression handling functions
6744         with new functions.
6745         * gdb/fortran-operator.def: New file.
6746         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
6747         * gdb/std-operator.def: Remove UNOP_KIND.
6748
6749 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6750
6751         * std-operator.def: Remove unbalanced, stray double quote
6752         character.
6753
6754 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6755             Chris January  <chris.january@arm.com>
6756             Daniel Everett  <daniel.everett@arm.com>
6757             Nick Forrington  <nick.forrington@arm.com>
6758             Richard Bunt  <richard.bunt@arm.com>
6759
6760         * cp-valprint.c (cp_print_value_fields): Allow an additional level
6761         of depth when printing anonymous structs or unions.
6762         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
6763         Don't print either the top-level value, or the children if the
6764         max-depth is exceeded.
6765         (ppscm_print_children): When printing the key of a map, allow one
6766         extra level of depth.
6767         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
6768         print either the top-level value, or the children if the max-depth
6769         is exceeded.
6770         (print_children): When printing the key of a map, allow one extra
6771         level of depth.
6772         * python/py-value.c (valpy_format_string): Add max_depth keyword.
6773         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
6774         (user_print_options): Initialise max_depth field.
6775         (val_print_scalar_or_string_type_p): New function.
6776         (val_print): Check to see if the max depth has been reached.
6777         (val_print_check_max_depth): Define new function.
6778         (show_print_max_depth): New function.
6779         (_initialize_valprint): Add 'print max-depth' option.
6780         * valprint.h (struct value_print_options) <max_depth>: New field.
6781         (val_print_check_max_depth): Declare new function.
6782         * NEWS: Document new feature.
6783
6784 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6785
6786         * ada-lang.c (ada_language_defn): Initialise new field.
6787         * c-lang.c (c_is_string_type_p): New function.
6788         (c_language_defn): Initialise new field.
6789         (cplus_language_defn): Initialise new field.
6790         (asm_language_defn): Initialise new field.
6791         (minimal_language_defn): Initialise new field.
6792         * c-lang.h (c_is_string_type_p): Declare new function.
6793         * d-lang.c (d_language_defn): Initialise new field.
6794         * f-lang.c (f_is_string_type_p): New function.
6795         (f_language_defn): Initialise new field.
6796         * go-lang.c (go_is_string_type_p): New function.
6797         (go_language_defn): Initialise new field.
6798         * language.c (default_is_string_type_p): New function.
6799         (unknown_language_defn): Initialise new field.
6800         (auto_language_defn): Initialise new field.
6801         * language.h (struct language_defn) <la_is_string_type_p>: New
6802         member variable.
6803         (default_is_string_type_p): Declare new function.
6804         * m2-lang.c (m2_language_defn): Initialise new field.
6805         * objc-lang.c (objc_language_defn): Initialise new field.
6806         * opencl-lang.c (opencl_language_defn): Initialise new field.
6807         * p-lang.c (pascal_is_string_type_p): New function.
6808         (pascal_language_defn): Initialise new field.
6809         * rust-lang.c (rust_is_string_type_p): New function.
6810         (rust_language_defn): Initialise new field.
6811
6812 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6813
6814         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
6815         New field.
6816         * ada-lang.c (ada_language_defn): Initialise new field.
6817         * c-lang.c (c_language_defn): Likewise.
6818         (cplus_language_defn): Likewise.
6819         (asm_language_defn): Likewise.
6820         (minimal_language_defn): Likewise.
6821         * d-lang.c (d_language_defn): Likewise.
6822         * f-lang.c (f_language_defn): Likewise.
6823         * go-lang.c (go_language_defn): Likewise.
6824         * language.c (unknown_language_defn): Likewise.
6825         (auto_language_defn): Likewise.
6826         * m2-lang.c (m2_language_defn): Likewise.
6827         * objc-lang.c (objc_language_defn): Likewise.
6828         * opencl-lang.c (opencl_language_defn): Likewise.
6829         * p-lang.c (pascal_language_defn): Likewise.
6830         * rust-lang.c (rust_language_defn): Likewise.
6831
6832 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6833
6834         * ada-lang.c (ada_is_character_type): Change return type to bool.
6835         (ada_is_string_type): Likewise.
6836         * ada-lang.h (ada_is_character_type): Update declaration
6837         (ada_is_string_type): Likewise.
6838
6839 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6840
6841         Support style in 'frame|thread apply'
6842
6843         * gdbcmd.h (execute_command_to_string): New term_out parameter.
6844         * record.c (record_start, record_stop): Update callers of
6845         execute_command_to_string with false.
6846         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
6847         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
6848         methods.
6849         (class string_file): New constructor with term_out parameter.
6850         Override methods term_out and can_emit_style_escape.  New member
6851         term_out.
6852         (class stdio_file): Override can_emit_style_escape.
6853         (class tee_file): Override term_out and can_emit_style_escape.
6854         * utils.h (can_emit_style_escape): Remove.
6855         * utils.c (can_emit_style_escape): Likewise.
6856         Update all callers of can_emit_style_escape (SOMESTREAM) to
6857         SOMESTREAM->can_emit_style_escape.
6858         * source-cache.c (source_cache::get_source_lines): Likewise.
6859         * stack.c (frame_apply_command_count): Call execute_command_to_string
6860         passing the term_out characteristic of the current gdb_stdout.
6861         * thread.c (thr_try_catch_cmd): Likewise.
6862         * top.c (execute_command_to_string): pass term_out parameter
6863         to construct the string_file for the command output.
6864         * ui-file.c (term_cli_styling): New function (most code moved
6865         from utils.c can_emit_style_escape).
6866         (string_file::string_file, string_file::can_emit_style_escape,
6867         stdio_file::can_emit_style_escape, tee_file::term_out,
6868         tee_file::can_emit_style_escape): New functions.
6869
6870 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6871
6872         * NEWS: Mention the new set|show may-call-functions.
6873         * infcall.c (may_call_functions_p): New variable.
6874         (show_may_call_functions_p): New function.
6875         (call_function_by_hand_dummy): Throws an error if not
6876         may-call-functions.
6877         (_initialize_infcall): Call add_setshow_boolean_cmd for
6878         may-call-functions.
6879
6880 2019-04-25  Keith Seitz  <keiths@redhat.com>
6881
6882         PR c++/24367
6883         * cp-support.c (inspect_type): Don't attempt substitutions
6884         of symbol with the same name.
6885
6886 2019-04-25  Tom Tromey  <tromey@adacore.com>
6887
6888         PR gdb/24475:
6889         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
6890         static.
6891
6892 2019-04-25  Tom Tromey  <tromey@adacore.com>
6893
6894         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
6895         rvalue reference.
6896         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
6897         (gdb_xml_parser::parse): Use std::move.
6898         * python/python-internal.h (gdbpy_convert_exception): Take a const
6899         reference.
6900         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
6901         std::move.
6902         * python/py-utils.c (gdbpy_convert_exception): Take a const
6903         reference.
6904         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6905         Use std::move.
6906         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6907         Use std::move.
6908         * mi/mi-main.c (mi_print_exception): Take a const reference.
6909         * main.c (handle_command_errors): Take a const reference.
6910         * linespec.c (parse_linespec): Use std::move.
6911         * infcall.c (run_inferior_call): Use std::move.
6912         (call_function_by_hand_dummy): Use std::move.
6913         * exec.c (try_open_exec_file): Use std::move.
6914         * exceptions.h (exception_print, exception_fprintf)
6915         (exception_print_same): Update.
6916         * exceptions.c (print_exception, exception_print)
6917         (exception_fprintf, exception_print_same): Change parameters to
6918         const reference.
6919         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
6920         * common/new-op.c: Use std::move.
6921         * common/common-exceptions.h (struct gdb_exception): Add move
6922         constructor.
6923         (struct gdb_exception_error, struct gdb_exception_quit, struct
6924         gdb_quit_bad_alloc): Change constructor to move constructor.
6925         (throw_exception): Change parameter to rvalue reference.
6926         * common/common-exceptions.c (throw_exception): Take rvalue
6927         reference.
6928         * cli/cli-interp.c (safe_execute_command): Use std::move.
6929         * breakpoint.c (insert_bp_location, location_to_sals): Use
6930         std::move.
6931
6932 2019-04-25  Tom Tromey  <tromey@adacore.com>
6933
6934         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
6935         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
6936         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
6937         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
6938         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
6939         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
6940         guile/scm-value.c: Use unpack.
6941         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
6942         gdbscm_gdb_exception.
6943         (gdbscm_throw_gdb_exception): Likewise.
6944         (struct gdbscm_gdb_exception): New.
6945         (unpack): New function.
6946         (gdbscm_wrap): Use unpack.
6947
6948 2019-04-25  Tom Tromey  <tromey@adacore.com>
6949
6950         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6951         (gdb_rl_callback_handler): Use std::move.
6952         * common/common-exceptions.h (struct gdb_exception): Add move
6953         assignment operator.
6954         (throw_exception_sjlj): Change "exception" to const reference.
6955         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
6956         (throw_exception_sjlj): Change "exception" to const reference.
6957
6958 2019-04-25  Tom Tromey  <tromey@adacore.com>
6959
6960         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
6961         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
6962         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6963         Update.
6964         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6965         Update.
6966         * mi/mi-interp.c (mi_interp::exec): Update.
6967         * linespec.c (parse_linespec): Update.
6968         * infcall.c (run_inferior_call): Update.
6969         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
6970         * guile/scm-symbol.c (gdbscm_lookup_symbol)
6971         (gdbscm_lookup_global_symbol): Update.
6972         * guile/scm-param.c (gdbscm_parameter_value): Update.
6973         * guile/scm-frame.c (gdbscm_frame_read_register)
6974         (gdbscm_frame_read_var): Update.
6975         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
6976         * exec.c (try_open_exec_file): Update.
6977         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6978         (gdb_rl_callback_handler): Update.
6979         * common/common-exceptions.h (exception_none): Don't declare.
6980         * common/common-exceptions.c (exception_none): Don't define.
6981         (struct catcher) <exception>: Update.
6982         * cli/cli-interp.c (safe_execute_command): Update.
6983         * breakpoint.c (insert_bp_location, location_to_sals): Update.
6984
6985 2019-04-25  Ali Tamur  <tamur@google.com>
6986
6987         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
6988         (read_attribute_value): Likewise.
6989         (dwarf2_read_addr_index): Update comment.
6990         (read_str_index): Add DW_FORM_strx.
6991         (dwarf2_string_attr): Likewise.
6992         (dwarf2_const_value_attr): Likewise.
6993         (dump_die_shallow): Likewise.
6994         (dwarf2_fetch_constant_bytes): Likewise.
6995         (skip_form_bytes): Likewise.
6996         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
6997
6998 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
6999
7000         PR corefiles/11608
7001         PR corefiles/18187
7002         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
7003         OFFSET.  Verify if current mapping contains an ELF header.
7004         (linux_find_memory_regions_full): Adjust call to
7005         dump_mapping_p.
7006
7007 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
7008             Kang Li <kanglictf@gmail.com>
7009
7010         PR gdb/21600
7011
7012         * dwarf2-frame.c (read_initial_length): Be consistent about using
7013         unsigned representation of length.
7014         (decode_frame_entry_1): Likewise.  Check for wraparound of
7015         end pointer as well as buffer overflow.
7016
7017 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
7018
7019         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
7020         "vq".
7021
7022 2019-04-24  Tom Tromey  <tromey@adacore.com>
7023
7024         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
7025
7026 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7027
7028         * s12z-tdep.c (s12z_unwind_pc): Delete.
7029         (s12z_unwind_sp): Delete.
7030         (s12z_gdbarch_init): Don't register deleted functions with
7031         gdbarch.
7032
7033 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7034
7035         * rl78-tdep.c (rl78_unwind_sp): Delete.
7036         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
7037
7038 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7039
7040         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
7041         (xstormy16_unwind_pc): Delete.
7042         (xstormy16_dummy_id): Delete.
7043         (xstormy16_gdbarch_init): Don't register deleted functions with
7044         gdbarch.
7045
7046 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7047
7048         * vax-tdep.c (vax_unwind_pc): Delete.
7049         (vax_gdbarch_init): Don't register deleted function with gdbarch.
7050
7051 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7052
7053         * v850-tdep.c (v850_unwind_sp): Delete.
7054         (v850_unwind_pc): Delete.
7055         (v850_dummy_id): Delete.
7056         (v850_gdbarch_init): Don't register deleted functions with
7057         gdbarch.
7058
7059 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7060
7061         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
7062         (tilegx_unwind_pc): Delete.
7063         (tilegx_unwind_dummy_id): Delete.
7064         (tilegx_gdbarch_init): Don't register deleted functions with
7065         gdbarch.
7066
7067 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7068
7069         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
7070         (tic6x_dummy_id): Delete.
7071         (tic6x_gdbarch_init): Don't register deleted functions with
7072         gdbarch.
7073
7074 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7075
7076         * sparc-tdep.c (sparc_unwind_pc): Delete.
7077         (sparc32_gdbarch_init): Don't register deleted function with
7078         gdbarch.
7079
7080 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7081
7082         * sh-tdep.c (sh_unwind_sp): Delete.
7083         (sh_unwind_pc): Delete.
7084         (sh_dummy_id): Delete.
7085         (sh_gdbarch_init): Don't register deleted functions with
7086         gdbarch.
7087
7088 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7089
7090         * score-tdep.c (score_unwind_sp): Delete.
7091         (score_unwind_pc): Delete.
7092         (score_dummy_id): Delete.
7093         (score_gdbarch_init): Don't register deleted functions with
7094         gdbarch.
7095
7096 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7097
7098         * rx-tdep.c (rx_unwind_pc): Delete.
7099         (rx_unwind_sp): Delete.
7100         (rx_dummy_id): Delete.
7101         (rx_gdbarch_init): Don't register deleted functions with
7102         gdbarch.  Update comment.
7103
7104 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7105
7106         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
7107         (rs6000_dummy_id): Delete.
7108         (rs6000_gdbarch_init): Don't register deleted functions with
7109         gdbarch.
7110
7111 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7112
7113         * or1k-tdep.c (or1k_dummy_id): Delete.
7114         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
7115
7116 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7117
7118         * nios2-tdep.c (nios2_dummy_id): Delete.
7119         (nios2_unwind_sp): Delete.
7120         (nios2_gdbarch_init): Don't register deleted functions with
7121         gdbarch.
7122
7123 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7124
7125         * nds32-tdep.c (nds32_dummy_id): Delete.
7126         (nds32_unwind_pc): Delete.
7127         (nds32_unwind_sp): Delete.
7128         (nds32_gdbarch_init): Don't register deleted functions with
7129         gdbarch.
7130
7131 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7132
7133         * msp430-tdep.c (msp430_unwind_pc): Delete.
7134         (msp430_unwind_sp): Delete.
7135         (msp430_dummy_id): Delete.
7136         (msp430_gdbarch_init): Don't register deleted functions with
7137         gdbarch.
7138
7139 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7140
7141         * moxie-tdep.c (moxie_unwind_sp): Delete.
7142         (moxie_unwind_pc): Delete.
7143         (moxie_dummy_id): Delete.
7144         (moxie_gdbarch_init): Don't register deleted functions with
7145         gdbarch.
7146
7147 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7148
7149         * mn10300-tdep.c (mn10300_dummy_id): Delete.
7150         (mn10300_unwind_pc): Delete.
7151         (mn10300_unwind_sp): Delete.
7152         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
7153         mn10300_unwind_sp.
7154         (mn10300_frame_unwind_init): Don't register deleted functions with
7155         gdbarch.
7156
7157 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7158
7159         * mep-tdep.c (mep_unwind_pc): Delete.
7160         (mep_unwind_sp): Delete.
7161         (mep_dummy_id): Delete.
7162         (mep_gdbarch_init): Don't register deleted functions with
7163         gdbarch.
7164
7165 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7166
7167         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
7168         (m68hc11_unwind_sp): Delete.
7169         (m68hc11_gdbarch_init): Don't register deleted functions with
7170         gdbarch.
7171
7172 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7173
7174         * m32r-tdep.c (m32r_unwind_sp): Delete.
7175         (m32r_unwind_pc): Delete.
7176         (m32r_dummy_id): Delete.
7177         (m32r_gdbarch_init): Don't register deleted functions with
7178         gdbarch.
7179
7180 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7181
7182         * m32c-tdep.c (m32c_unwind_pc): Delete.
7183         (m32c_unwind_sp): Delete.
7184         (m32c_dummy_id): Delete.
7185         (m32c_gdbarch_init): Don't register deleted functions with
7186         gdbarch.
7187
7188 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7189
7190         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
7191         (lm32_unwind_pc): Delete.
7192         (lm32_dummy_id): Delete.
7193         (lm32_gdbarch_init): Don't register deleted functions with
7194         gdbarch.
7195
7196 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7197
7198         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
7199         (iq2000_unwind_pc): Delete.
7200         (iq2000_dummy_id): Delete.
7201         (iq2000_gdbarch_init): Don't register deleted functions with
7202         gdbarch.
7203
7204 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7205
7206         * nds32-tdep.c (nds32_type_align): Delete.
7207         (nds32_push_dummy_call): Use type_align instead.
7208
7209 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7210
7211         * arm-tdep.c (arm_type_align): Only handle vector override case.
7212         (arm_push_dummy_call): Use type_align.
7213         (arm_gdbarch_init): Register arm_type_align gdbarch function.
7214
7215 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7216
7217         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
7218         case.
7219         (pass_on_stack): Use type_align.
7220         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
7221         function.
7222
7223 2019-04-23  Tom Tromey  <tromey@adacore.com>
7224
7225         * dwarf2read.c (line_header::file_name_at): Remove unused
7226         overload.
7227
7228 2019-04-23  Tom de Vries  <tdevries@suse.de>
7229
7230         PR gdb/24438
7231         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
7232         invocation.
7233
7234
7235 2019-03-27  Ali Tamur  <tamur@google.com>
7236
7237         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
7238         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
7239         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
7240         (dwarf_expr_context::get_addr_index): Likewise
7241         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
7242         (symbol_needs_eval_context::get_addr_index): Likewise
7243         (disassemble_dwarf_expression): Add DW_OP_addrx
7244         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
7245         (read_cutu_die_from_dwo): Update comment
7246         (skip_one_die): Add DW_FORM_addrx
7247         (read_attribute_value): Likewise
7248         (var_decode_location): Add DW_OP_addrx
7249         (dwarf2_const_value_attr): Add DW_FORM_addrx
7250         (dump_die_shallow): Likewise
7251         (dwarf2_fetch_constant_bytes): Likewise
7252         (decode_locdesc): Add DW_OP_addrx
7253         (skip_form_bytes): Add DW_FORM_addrx
7254
7255 2019-04-22  Ali Tamur  <tamur@google.com>
7256
7257         * MAINTAINERS (Write After Approval): Add self.
7258
7259 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
7260
7261         * solib-svr4.c (get_svr4_info): Add pspace parameter.
7262         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
7263         (open_symbol_file_object): Likewise.
7264         (svr4_default_sos): Add info parameter.
7265         (svr4_read_so_list): Likewise.
7266         (svr4_current_sos_direct): Adjust functions calls to pass down
7267         info.
7268         (svr4_current_sos_1): Add info parameter.
7269         (svr4_current_sos): Call get_svr4_info, pass info down to
7270         svr4_current_sos_1.
7271         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
7272         get_svr4_info.
7273         (svr4_in_dynsym_resolve_code): Pass current_program_space to
7274         get_svr4_info.
7275         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
7276         to get_svr4_info.
7277         (probes_table_remove_objfile_probes): Likewise.
7278         (register_solib_event_probe): Add info parameter.
7279         (solist_update_incremental): Pass info parameter down to
7280         svr4_read_so_list.
7281         (disable_probes_interface): Add info parameter.
7282         (svr4_handle_solib_event): Pass current_program_space to
7283         get_svr4_info.  Adjust disable_probes_interface cleanup.
7284         (svr4_create_probe_breakpoints): Add info parameter, pass it
7285         down to register_solib_event_probe.
7286         (svr4_create_solib_event_breakpoints): Add info parameter,
7287         pass it down to svr4_create_probe_breakpoints.
7288         (enable_break): Pass info down to
7289         svr4_create_solib_event_breakpoints.
7290         (svr4_solib_create_inferior_hook): Pass current_program_space to
7291         get_svr4_info.
7292         (svr4_clear_solib): Likewise.
7293
7294 2019-04-22  Pedro Alves  <palves@redhat.com>
7295
7296         * solib-svr4.c (svr4_free_objfile_observer): New.
7297         (probe_and_action::objfile): New field.
7298         (probes_table_htab_remove_objfile_probes)
7299         (probes_table_remove_objfile_probes): New functions.
7300         (register_solib_event_probe): Add 'objfile' parameter.  Store it
7301         in the new probe_and_action.  Don't store the probe in 'lookup'.
7302         (svr4_create_probe_breakpoints): Pass objfile to
7303         register_solib_event_probe.
7304         (_initialize_svr4_solib): Register a free_objfile observer.
7305
7306 2019-04-19  Tom Tromey  <tom@tromey.com>
7307
7308         * common/queue.h: Remove.
7309
7310 2019-04-19  Tom Tromey  <tom@tromey.com>
7311
7312         * event-loop.c: Don't include "common/queue.h".
7313
7314 2019-04-19  Tom Tromey  <tom@tromey.com>
7315
7316         * remote.c (remote_target): Use delete.
7317         * remote-notif.h: Include <list>, not "common/queue.h".
7318         (notif_client_p): Remove typedef.
7319         (remote_notif_state): Add constructor, destructor, initializer.
7320         <notif_queue>: Now a std::list.
7321         (remote_notif_state_xfree): Don't declare.
7322         * remote-notif.c (remote_notif_process, handle_notification)
7323         (remote_notif_state_allocate): Update.
7324         (~remote_notif_state): Rename from remote_notif_state_xfree.
7325
7326 2019-04-19  Tom Tromey  <tom@tromey.com>
7327
7328         * symfile.c (reread_symbols): Update.
7329         * objfiles.c (objfile_register_static_link)
7330         (objfile_lookup_static_link): Update
7331         (~objfile) Don't delete static_links.
7332         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
7333
7334 2019-04-19  Tom Tromey  <tom@tromey.com>
7335
7336         * type-stack.h (struct type_stack) <insert>: Constify string.
7337         * type-stack.c (type_stack::insert): Constify string.
7338         * gdbtypes.h (lookup_template_type): Update.
7339         (address_space_name_to_int): Update.
7340         * gdbtypes.c (address_space_name_to_int): Make space_identifier
7341         const.
7342         (lookup_template_type): Make name const.
7343         * c-exp.y: Update rules.
7344         (lex_one_token, classify_name, classify_inner_name)
7345         (c_print_token): Update.
7346         * p-exp.y: Update rules.
7347         (yylex): Update.
7348         * f-exp.y: Update rules.
7349         (yylex): Update.
7350         * d-exp.y: Update rules.
7351         (lex_one_token, classify_name, classify_inner_name): Update.
7352         * parse.c (write_dollar_variable, copy_name): Return std::string.
7353         * parser-defs.h (copy_name): Change return type.
7354         * m2-exp.y: Update rules.
7355         (yylex): Update.
7356         * go-exp.y (lex_one_token): Update.
7357         Update rules.
7358         (classify_unsafe_function, classify_packaged_name)
7359         (classify_name, yylex): Update.
7360
7361 2019-04-19  Sergei Trofimovich <siarheit@google.com>
7362
7363         * configure.ac: add --enable-source-highlight switch.
7364         * configure: Regenerate.
7365         * top.c (print_gdb_version): plumb --enable-source-highlight
7366         status to "show configuration".
7367
7368 2019-04-19  Tom Tromey  <tromey@adacore.com>
7369
7370         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
7371         Check ADA_TYPE_P.
7372         (empty_record, ada_template_to_fixed_record_type_1)
7373         (template_to_static_fixed_type)
7374         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
7375         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
7376         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
7377         macros.
7378
7379 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
7380
7381         PR symtab/24423:
7382         * source.c (print_source_lines_base): Advance "iter" when a
7383         control character is seen.
7384
7385 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7386
7387         * inferior.h (struct infcall_suspend_state_deleter):
7388         Catch exception in destructor to avoid crash.
7389
7390 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7391
7392         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
7393         close to the add_com "shell".
7394
7395 2019-04-18  Tom Tromey  <tromey@adacore.com>
7396
7397         * process-stratum-target.h (class process_stratum_target)
7398         <stratum>: Add "final".
7399
7400 2019-04-17  Tom Tromey  <tromey@adacore.com>
7401
7402         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
7403         against nullptr before use.
7404
7405 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
7406
7407         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
7408
7409 2019-04-17  Jim Wilson  <jimw@sifive.com>
7410             Andrew Burgess  <andrew.burgess@embecosm.com>
7411
7412         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
7413         code read might fail, assume 4-byte breakpoint in that case.
7414
7415 2019-04-15  Leszek Swirski  <leszeks@google.com>
7416
7417         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
7418         rather than a hand-rolled POD check when checking for forced MEMORY
7419         classification.
7420
7421 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7422
7423         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
7424         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
7425         function.
7426         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
7427         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
7428         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
7429         declaration.
7430
7431 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7432
7433         * aarch64-linux-nat.c
7434         (aarch64_linux_nat_target::thread_architecture): Add override.
7435         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
7436         each VQ.
7437
7438 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7439
7440         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
7441
7442 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
7443
7444         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
7445         target types of size 96-bits, add some additional comments, and
7446         check that the builtin type we found was the correct size.
7447
7448 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
7449
7450         * utils.c (prompt_for_continue): Don't restore the styling at the
7451         end, as applied_style has the wrong value.  This fixes styling in
7452         long lists of file names that are interrupted by the "Continue?"
7453         prompt.
7454
7455 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7456
7457         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
7458         * c-lang.c (c_language_defn): Likewise.
7459         (cplus_language_defn): Likewise.
7460         (asm_language_defn): Likewise.
7461         (minimal_language_defn): Likewise.
7462         * d-lang.c (d_language_defn): Likewise.
7463         * f-lang.c (f_language_defn): Likewise.
7464         * go-lang.c (go_language_defn): Likewise.
7465         * language.c (unknown_language_defn): Likewise.
7466         (auto_language_defn): Likewise.
7467         * language.h (struct language_defn): Remove la_magic field.
7468         (LANG_MAGIC): Delete.
7469         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
7470         * objc-lang.c (objc_language_defn): Likewise.
7471         * opencl-lang.c (opencl_language_defn): Likewise.
7472         * p-lang.c (pascal_language_defn): Likewise.
7473         * rust-lang.c (rust_language_defn): Likewise.
7474
7475 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7476
7477         * riscv-tdep.c (riscv_type_align): New function.
7478         (riscv_type_alignment): Delete.
7479         (riscv_arg_location): Use 'type_align'.
7480         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
7481
7482 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7483
7484         * gdbtypes.c (type_align): A struct with no non-static fields also
7485         has alignment of 1.
7486
7487 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7488
7489         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
7490         component to 0.
7491         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
7492         member.
7493         (riscv_struct_info::analyse): New implementation using new
7494         analyse_inner member function.
7495         (riscv_struct_info::field_offset): New member function.
7496         (riscv_struct_info::m_offsets): New member variable.
7497         (riscv_struct_info::analyse_inner): New private member function,
7498         takes the old implementation of riscv_struct_info::analyse but
7499         extended to track field offsets.
7500         (riscv_call_arg_struct): Update the struct folding special cases
7501         to handle cases where empty C++ structs, which are non-zero
7502         length, are found.
7503         (riscv_arg_location): Initialise the length of each location, a
7504         non-zero length now indicates the location is in use.
7505         (riscv_push_dummy_call): Allow for the first location having a
7506         non-zero offset when setting up arguments.
7507         (riscv_return_value): Likewise, but for return values.
7508
7509 2019-04-11  Tom Tromey  <tromey@adacore.com>
7510
7511         * utils.c (internal_vproblem): Make "msg" const.
7512
7513 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
7514
7515         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
7516         * trad-frame.c (trad_frame_reset_saved_regs): New function.
7517         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
7518         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
7519
7520 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
7521
7522         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
7523         function.
7524         (fill_gregset): Call amd64_linux_collect_native_gregset instead
7525         of amd64_collect_native_gregset.
7526         (amd64_linux_nat_target::store_registers): Likewise.
7527
7528 2019-04-10  Tom Tromey  <tom@tromey.com>
7529
7530         * symtab.c (lookup_global_symbol_from_objfile)
7531         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
7532         * objfiles.h (class separate_debug_iterator): New.
7533         (class separate_debug_range): New.
7534         (struct objfile) <separate_debug_objfiles>: New method.
7535         (objfile_separate_debug_iterate): Don't declare.
7536         * objfiles.c (separate_debug_iterator::operator++): Rename from
7537         objfile_separate_debug_iterate.
7538         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
7539         iterator.
7540         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
7541         iterator.
7542
7543 2019-04-10  Tom Tromey  <tom@tromey.com>
7544
7545         * symfile.c (reread_symbols): Remove old comment.
7546         * objfiles.c (free_all_objfiles): Fix a typo.
7547
7548 2019-04-10  Tom Tromey  <tom@tromey.com>
7549
7550         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
7551         * minsyms.c (lookup_minimal_symbol): Use foreach.
7552         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
7553         (lookup_minimal_symbol_solib_trampoline): Likewise.
7554         * symfile.c (reread_symbols): Use foreach.
7555
7556 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
7557             Tom Tromey  <tromey@adacore.com>
7558
7559         PR rust/24414:
7560         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
7561         (rust_lex_int_test): Change "value" to be LONGEST.
7562         (rust_lex_tests): Add test for long integer literal.
7563
7564 2019-04-09  Tom Tromey  <tromey@adacore.com>
7565
7566         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
7567         to bool.
7568         (extended_remote_target::attach): Update.
7569         (remote_target::remote_notice_new_inferior): Update.
7570         (remote_target::add_current_inferior_and_thread): Update.
7571         * inferior.c (exit_inferior_1): Use "false".
7572         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
7573
7574 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
7575
7576         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
7577         the "start" command.
7578
7579 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7580
7581         * python/py-inferior.c (infpy_thread_from_thread_handle):
7582         Adjust comments to reflect renaming of thread_from_thread_handle
7583         to thread_from_handle.  Adjust keywords.  Fix type error message.
7584         (inferior_object_methods): Add thread_from_handle.  Retain
7585         thread_from_thread_handle, but mark it as deprecated.
7586
7587 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7588
7589         * gdbthread.h (find_thread_by_handle): Revise declaration.
7590         * thread.c (find_thread_by_handle): Likewise.  Adjust
7591         implementation too.
7592         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
7593         support for buffer objects as handles.
7594
7595 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7596
7597         * python/py-infthread.c (thpy_thread_handle): New function.
7598         (thread_object_methods): Register thpy_thread_handle.
7599
7600 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7601
7602         * gdbthread.h (thread_to_thread_handle): Declare.
7603         * thread.c (gdbtypes.h): Include.
7604         (thread_to_thread_handle): New function.
7605
7606         * target.h (struct target_ops): Add thread_info_to_thread_handle.
7607         (target_thread_info_to_thread_handle): Declare.
7608         * target.c (target_thread_info_to_thread_handle): New function.
7609         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
7610         * target-delegates.c: Regenerate.
7611
7612         * linux-thread-db.c (class thread_db_target): Add method
7613         thread_info_to_thread_handle.
7614         (thread_db_target::thread_info_to_thread_handle): Define.
7615         * remote.c (class remote_target): Add new method
7616         thread_info_to_thread_handle.
7617         (remote_target::thread_info_to_thread_handle): Define.
7618
7619 2019-04-08  Pedro Alves  <palves@redhat.com>
7620
7621         * common/common-exceptions.c (throw_exception): Don't create
7622         named object to throw; throw directly.
7623         (throw_it): Likewise.  Don't initialize gdb_exception::message
7624         here, with new; pass FMT and AP to the ctor instead.
7625         * common/common-exceptions.h: Include <string>.
7626         (gdb_exception::gdb_exception(enum return_reason, enum errors,
7627         const char *, va_list)): New ctor.  Use std::make_shared.
7628         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
7629         errors)): Delete.
7630         (gdb_exception_error::gdb_exception_error(enum errors, const char
7631         *, va_list)): New.
7632         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
7633         Add assertion.
7634         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
7635         errors)): Delete.
7636         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
7637         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
7638         Add assertion.
7639
7640 2019-04-08  Tom Tromey  <tom@tromey.com>
7641
7642         * valops.c (value_rtti_indirect_type): Replace throw_exception
7643         with throw.
7644         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
7645         with throw.
7646         * thread.c (thr_try_catch_cmd): Replace throw_exception with
7647         throw.
7648         * target.c (target_translate_tls_address): Replace throw_exception
7649         with throw.
7650         * stack.c (frame_apply_command_count): Replace throw_exception
7651         with throw.
7652         * solib-spu.c (append_ocl_sos): Replace throw_exception with
7653         throw.
7654         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
7655         with throw.
7656         * rs6000-tdep.c (rs6000_frame_cache)
7657         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
7658         * remote.c: Replace throw_exception with throw.
7659         * record-full.c (record_full_message, record_full_wait_1)
7660         (record_full_restore): Replace throw_exception with throw.
7661         * record-btrace.c:
7662         (get_thread_current_frame_id, record_btrace_start_replaying)
7663         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
7664         (cmd_record_btrace_start): Replace throw_exception with throw.
7665         * parse.c (parse_exp_in_context_1): Replace throw_exception with
7666         throw.
7667         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
7668         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
7669         * linespec.c:
7670         (find_linespec_symbols): Replace throw_exception with throw.
7671         * infrun.c (displaced_step_prepare, resume): Replace
7672         throw_exception with throw.
7673         * infcmd.c (post_create_inferior): Replace throw_exception with
7674         throw.
7675         * inf-loop.c (inferior_event_handler): Replace throw_exception
7676         with throw.
7677         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
7678         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
7679         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
7680         (get_prev_frame_always, get_frame_pc_if_available)
7681         (get_frame_address_in_block_if_available, get_frame_language):
7682         Replace throw_exception with throw.
7683         * frame-unwind.c (frame_unwind_try_unwinder): Replace
7684         throw_exception with throw.
7685         * eval.c (fetch_subexp_value, evaluate_var_value)
7686         (evaluate_funcall, evaluate_subexp_standard): Replace
7687         throw_exception with throw.
7688         * dwarf2loc.c (call_site_find_chain)
7689         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
7690         Replace throw_exception with throw.
7691         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
7692         with throw.
7693         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
7694         throw.
7695         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
7696         * completer.c (complete_line_internal): Replace throw_exception
7697         with throw.
7698         * compile/compile-object-run.c (compile_object_run): Replace
7699         throw_exception with throw.
7700         * cli/cli-script.c (process_next_line): Replace throw_exception
7701         with throw.
7702         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
7703         (btrace_enable, btrace_maint_update_pt_packets): Replace
7704         throw_exception with throw.
7705         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
7706         throw_exception with throw.
7707         * break-catch-throw.c (re_set_exception_catchpoint): Replace
7708         throw_exception with throw.
7709         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
7710         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
7711         * aarch64-tdep.c (aarch64_make_prologue_cache)
7712         (aarch64_make_stub_cache): Replace throw_exception with throw.
7713
7714 2019-04-08  Tom Tromey  <tom@tromey.com>
7715
7716         * common/common-exceptions.c (throw_exception): Rename from
7717         throw_exception_cxx.  Remove old copy.  Make argument const.
7718         (throw_it): Create and throw exception objects directly.
7719         * common/common-exceptions.h (throw_exception): Make argument
7720         const.
7721         (struct gdb_exception_error): Add constructor.
7722         (struct gdb_exception_quit): Add constructor.
7723
7724 2019-04-08  Tom Tromey  <tom@tromey.com>
7725
7726         * common/common-exceptions.h (exception_rethrow): Don't declare.
7727         (TRY_SJLJ): Update comment.
7728         (TRY, CATCH, END_CATCH): Remove.
7729         * common/common-exceptions.c (exception_rethrow): Remove.
7730
7731 2019-04-08  Tom Tromey  <tom@tromey.com>
7732
7733         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
7734         Remove.
7735         (gdb_exception_error): Rename from
7736         gdb_exception_RETURN_MASK_ERROR.
7737         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
7738         (gdb_quit_bad_alloc): Update.
7739         * aarch64-tdep.c: Update.
7740         * ada-lang.c: Update.
7741         * ada-typeprint.c: Update.
7742         * ada-valprint.c: Update.
7743         * amd64-tdep.c: Update.
7744         * arch-utils.c: Update.
7745         * break-catch-throw.c: Update.
7746         * breakpoint.c: Update.
7747         * btrace.c: Update.
7748         * c-varobj.c: Update.
7749         * cli/cli-cmds.c: Update.
7750         * cli/cli-interp.c: Update.
7751         * cli/cli-script.c: Update.
7752         * common/common-exceptions.c: Update.
7753         * common/new-op.c: Update.
7754         * common/selftest.c: Update.
7755         * compile/compile-c-symbols.c: Update.
7756         * compile/compile-cplus-symbols.c: Update.
7757         * compile/compile-object-load.c: Update.
7758         * compile/compile-object-run.c: Update.
7759         * completer.c: Update.
7760         * corelow.c: Update.
7761         * cp-abi.c: Update.
7762         * cp-support.c: Update.
7763         * cp-valprint.c: Update.
7764         * darwin-nat.c: Update.
7765         * disasm-selftests.c: Update.
7766         * dtrace-probe.c: Update.
7767         * dwarf-index-cache.c: Update.
7768         * dwarf-index-write.c: Update.
7769         * dwarf2-frame-tailcall.c: Update.
7770         * dwarf2-frame.c: Update.
7771         * dwarf2loc.c: Update.
7772         * dwarf2read.c: Update.
7773         * eval.c: Update.
7774         * event-loop.c: Update.
7775         * event-top.c: Update.
7776         * exec.c: Update.
7777         * f-valprint.c: Update.
7778         * fbsd-tdep.c: Update.
7779         * frame-unwind.c: Update.
7780         * frame.c: Update.
7781         * gdbtypes.c: Update.
7782         * gnu-v3-abi.c: Update.
7783         * guile/guile-internal.h: Update.
7784         * guile/scm-block.c: Update.
7785         * guile/scm-breakpoint.c: Update.
7786         * guile/scm-cmd.c: Update.
7787         * guile/scm-disasm.c: Update.
7788         * guile/scm-frame.c: Update.
7789         * guile/scm-lazy-string.c: Update.
7790         * guile/scm-math.c: Update.
7791         * guile/scm-param.c: Update.
7792         * guile/scm-ports.c: Update.
7793         * guile/scm-pretty-print.c: Update.
7794         * guile/scm-symbol.c: Update.
7795         * guile/scm-symtab.c: Update.
7796         * guile/scm-type.c: Update.
7797         * guile/scm-value.c: Update.
7798         * i386-linux-tdep.c: Update.
7799         * i386-tdep.c: Update.
7800         * inf-loop.c: Update.
7801         * infcall.c: Update.
7802         * infcmd.c: Update.
7803         * infrun.c: Update.
7804         * jit.c: Update.
7805         * language.c: Update.
7806         * linespec.c: Update.
7807         * linux-fork.c: Update.
7808         * linux-nat.c: Update.
7809         * linux-tdep.c: Update.
7810         * linux-thread-db.c: Update.
7811         * main.c: Update.
7812         * mi/mi-cmd-break.c: Update.
7813         * mi/mi-cmd-stack.c: Update.
7814         * mi/mi-interp.c: Update.
7815         * mi/mi-main.c: Update.
7816         * objc-lang.c: Update.
7817         * p-valprint.c: Update.
7818         * parse.c: Update.
7819         * ppc-linux-tdep.c: Update.
7820         * printcmd.c: Update.
7821         * python/py-arch.c: Update.
7822         * python/py-breakpoint.c: Update.
7823         * python/py-cmd.c: Update.
7824         * python/py-finishbreakpoint.c: Update.
7825         * python/py-frame.c: Update.
7826         * python/py-framefilter.c: Update.
7827         * python/py-gdb-readline.c: Update.
7828         * python/py-inferior.c: Update.
7829         * python/py-infthread.c: Update.
7830         * python/py-lazy-string.c: Update.
7831         * python/py-linetable.c: Update.
7832         * python/py-objfile.c: Update.
7833         * python/py-param.c: Update.
7834         * python/py-prettyprint.c: Update.
7835         * python/py-progspace.c: Update.
7836         * python/py-record-btrace.c: Update.
7837         * python/py-record.c: Update.
7838         * python/py-symbol.c: Update.
7839         * python/py-type.c: Update.
7840         * python/py-unwind.c: Update.
7841         * python/py-utils.c: Update.
7842         * python/py-value.c: Update.
7843         * python/python.c: Update.
7844         * record-btrace.c: Update.
7845         * record-full.c: Update.
7846         * remote-fileio.c: Update.
7847         * remote.c: Update.
7848         * riscv-tdep.c: Update.
7849         * rs6000-aix-tdep.c: Update.
7850         * rs6000-tdep.c: Update.
7851         * rust-exp.y: Update.
7852         * rust-lang.c: Update.
7853         * s390-tdep.c: Update.
7854         * selftest-arch.c: Update.
7855         * solib-dsbt.c: Update.
7856         * solib-frv.c: Update.
7857         * solib-spu.c: Update.
7858         * solib-svr4.c: Update.
7859         * solib.c: Update.
7860         * sparc64-linux-tdep.c: Update.
7861         * stack.c: Update.
7862         * symfile-mem.c: Update.
7863         * symmisc.c: Update.
7864         * target.c: Update.
7865         * thread.c: Update.
7866         * top.c: Update.
7867         * tracefile-tfile.c: Update.
7868         * tui/tui.c: Update.
7869         * typeprint.c: Update.
7870         * unittests/cli-utils-selftests.c: Update.
7871         * unittests/parse-connection-spec-selftests.c: Update.
7872         * valops.c: Update.
7873         * valprint.c: Update.
7874         * value.c: Update.
7875         * varobj.c: Update.
7876         * windows-nat.c: Update.
7877         * x86-linux-nat.c: Update.
7878         * xml-support.c: Update.
7879
7880 2019-04-08  Tom Tromey  <tom@tromey.com>
7881
7882         * xml-support.c: Use C++ exception handling.
7883         * x86-linux-nat.c: Use C++ exception handling.
7884         * windows-nat.c: Use C++ exception handling.
7885         * varobj.c: Use C++ exception handling.
7886         * value.c: Use C++ exception handling.
7887         * valprint.c: Use C++ exception handling.
7888         * valops.c: Use C++ exception handling.
7889         * unittests/parse-connection-spec-selftests.c: Use C++ exception
7890         handling.
7891         * unittests/cli-utils-selftests.c: Use C++ exception handling.
7892         * typeprint.c: Use C++ exception handling.
7893         * tui/tui.c: Use C++ exception handling.
7894         * tracefile-tfile.c: Use C++ exception handling.
7895         * top.c: Use C++ exception handling.
7896         * thread.c: Use C++ exception handling.
7897         * target.c: Use C++ exception handling.
7898         * symmisc.c: Use C++ exception handling.
7899         * symfile-mem.c: Use C++ exception handling.
7900         * stack.c: Use C++ exception handling.
7901         * sparc64-linux-tdep.c: Use C++ exception handling.
7902         * solib.c: Use C++ exception handling.
7903         * solib-svr4.c: Use C++ exception handling.
7904         * solib-spu.c: Use C++ exception handling.
7905         * solib-frv.c: Use C++ exception handling.
7906         * solib-dsbt.c: Use C++ exception handling.
7907         * selftest-arch.c: Use C++ exception handling.
7908         * s390-tdep.c: Use C++ exception handling.
7909         * rust-lang.c: Use C++ exception handling.
7910         * rust-exp.y: Use C++ exception handling.
7911         * rs6000-tdep.c: Use C++ exception handling.
7912         * rs6000-aix-tdep.c: Use C++ exception handling.
7913         * riscv-tdep.c: Use C++ exception handling.
7914         * remote.c: Use C++ exception handling.
7915         * remote-fileio.c: Use C++ exception handling.
7916         * record-full.c: Use C++ exception handling.
7917         * record-btrace.c: Use C++ exception handling.
7918         * python/python.c: Use C++ exception handling.
7919         * python/py-value.c: Use C++ exception handling.
7920         * python/py-utils.c: Use C++ exception handling.
7921         * python/py-unwind.c: Use C++ exception handling.
7922         * python/py-type.c: Use C++ exception handling.
7923         * python/py-symbol.c: Use C++ exception handling.
7924         * python/py-record.c: Use C++ exception handling.
7925         * python/py-record-btrace.c: Use C++ exception handling.
7926         * python/py-progspace.c: Use C++ exception handling.
7927         * python/py-prettyprint.c: Use C++ exception handling.
7928         * python/py-param.c: Use C++ exception handling.
7929         * python/py-objfile.c: Use C++ exception handling.
7930         * python/py-linetable.c: Use C++ exception handling.
7931         * python/py-lazy-string.c: Use C++ exception handling.
7932         * python/py-infthread.c: Use C++ exception handling.
7933         * python/py-inferior.c: Use C++ exception handling.
7934         * python/py-gdb-readline.c: Use C++ exception handling.
7935         * python/py-framefilter.c: Use C++ exception handling.
7936         * python/py-frame.c: Use C++ exception handling.
7937         * python/py-finishbreakpoint.c: Use C++ exception handling.
7938         * python/py-cmd.c: Use C++ exception handling.
7939         * python/py-breakpoint.c: Use C++ exception handling.
7940         * python/py-arch.c: Use C++ exception handling.
7941         * printcmd.c: Use C++ exception handling.
7942         * ppc-linux-tdep.c: Use C++ exception handling.
7943         * parse.c: Use C++ exception handling.
7944         * p-valprint.c: Use C++ exception handling.
7945         * objc-lang.c: Use C++ exception handling.
7946         * mi/mi-main.c: Use C++ exception handling.
7947         * mi/mi-interp.c: Use C++ exception handling.
7948         * mi/mi-cmd-stack.c: Use C++ exception handling.
7949         * mi/mi-cmd-break.c: Use C++ exception handling.
7950         * main.c: Use C++ exception handling.
7951         * linux-thread-db.c: Use C++ exception handling.
7952         * linux-tdep.c: Use C++ exception handling.
7953         * linux-nat.c: Use C++ exception handling.
7954         * linux-fork.c: Use C++ exception handling.
7955         * linespec.c: Use C++ exception handling.
7956         * language.c: Use C++ exception handling.
7957         * jit.c: Use C++ exception handling.
7958         * infrun.c: Use C++ exception handling.
7959         * infcmd.c: Use C++ exception handling.
7960         * infcall.c: Use C++ exception handling.
7961         * inf-loop.c: Use C++ exception handling.
7962         * i386-tdep.c: Use C++ exception handling.
7963         * i386-linux-tdep.c: Use C++ exception handling.
7964         * guile/scm-value.c: Use C++ exception handling.
7965         * guile/scm-type.c: Use C++ exception handling.
7966         * guile/scm-symtab.c: Use C++ exception handling.
7967         * guile/scm-symbol.c: Use C++ exception handling.
7968         * guile/scm-pretty-print.c: Use C++ exception handling.
7969         * guile/scm-ports.c: Use C++ exception handling.
7970         * guile/scm-param.c: Use C++ exception handling.
7971         * guile/scm-math.c: Use C++ exception handling.
7972         * guile/scm-lazy-string.c: Use C++ exception handling.
7973         * guile/scm-frame.c: Use C++ exception handling.
7974         * guile/scm-disasm.c: Use C++ exception handling.
7975         * guile/scm-cmd.c: Use C++ exception handling.
7976         * guile/scm-breakpoint.c: Use C++ exception handling.
7977         * guile/scm-block.c: Use C++ exception handling.
7978         * guile/guile-internal.h: Use C++ exception handling.
7979         * gnu-v3-abi.c: Use C++ exception handling.
7980         * gdbtypes.c: Use C++ exception handling.
7981         * frame.c: Use C++ exception handling.
7982         * frame-unwind.c: Use C++ exception handling.
7983         * fbsd-tdep.c: Use C++ exception handling.
7984         * f-valprint.c: Use C++ exception handling.
7985         * exec.c: Use C++ exception handling.
7986         * event-top.c: Use C++ exception handling.
7987         * event-loop.c: Use C++ exception handling.
7988         * eval.c: Use C++ exception handling.
7989         * dwarf2read.c: Use C++ exception handling.
7990         * dwarf2loc.c: Use C++ exception handling.
7991         * dwarf2-frame.c: Use C++ exception handling.
7992         * dwarf2-frame-tailcall.c: Use C++ exception handling.
7993         * dwarf-index-write.c: Use C++ exception handling.
7994         * dwarf-index-cache.c: Use C++ exception handling.
7995         * dtrace-probe.c: Use C++ exception handling.
7996         * disasm-selftests.c: Use C++ exception handling.
7997         * darwin-nat.c: Use C++ exception handling.
7998         * cp-valprint.c: Use C++ exception handling.
7999         * cp-support.c: Use C++ exception handling.
8000         * cp-abi.c: Use C++ exception handling.
8001         * corelow.c: Use C++ exception handling.
8002         * completer.c: Use C++ exception handling.
8003         * compile/compile-object-run.c: Use C++ exception handling.
8004         * compile/compile-object-load.c: Use C++ exception handling.
8005         * compile/compile-cplus-symbols.c: Use C++ exception handling.
8006         * compile/compile-c-symbols.c: Use C++ exception handling.
8007         * common/selftest.c: Use C++ exception handling.
8008         * common/new-op.c: Use C++ exception handling.
8009         * cli/cli-script.c: Use C++ exception handling.
8010         * cli/cli-interp.c: Use C++ exception handling.
8011         * cli/cli-cmds.c: Use C++ exception handling.
8012         * c-varobj.c: Use C++ exception handling.
8013         * btrace.c: Use C++ exception handling.
8014         * breakpoint.c: Use C++ exception handling.
8015         * break-catch-throw.c: Use C++ exception handling.
8016         * arch-utils.c: Use C++ exception handling.
8017         * amd64-tdep.c: Use C++ exception handling.
8018         * ada-valprint.c: Use C++ exception handling.
8019         * ada-typeprint.c: Use C++ exception handling.
8020         * ada-lang.c: Use C++ exception handling.
8021         * aarch64-tdep.c: Use C++ exception handling.
8022
8023 2019-04-08  Tom Tromey  <tom@tromey.com>
8024
8025         * xml-support.c (gdb_xml_parser::parse): Update.
8026         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8027         * value.c (show_convenience): Update.
8028         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
8029         (test_parse_flags_qcs): Update.
8030         * thread.c (thr_try_catch_cmd): Update.
8031         * target.c (target_translate_tls_address): Update.
8032         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
8033         (info_frame_command_core, frame_apply_command_count): Update.
8034         * rust-exp.y (rust_lex_exception_test): Update.
8035         * riscv-tdep.c (riscv_print_one_register_info): Update.
8036         * remote.c (remote_target::enable_btrace): Update.
8037         * record-btrace.c (record_btrace_enable_warn): Update.
8038         * python/py-utils.c (gdbpy_convert_exception): Update.
8039         * printcmd.c (do_one_display, print_variable_and_value): Update.
8040         * mi/mi-main.c (mi_print_exception): Update.
8041         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
8042         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
8043         * linux-nat.c (linux_nat_target::attach): Update.
8044         * linux-fork.c (class scoped_switch_fork_info): Update.
8045         * infrun.c (displaced_step_prepare): Update.
8046         * infcall.c (call_function_by_hand_dummy): Update.
8047         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
8048         * gnu-v3-abi.c (print_one_vtable): Update.
8049         * frame.c (get_prev_frame_always): Update.
8050         * f-valprint.c (info_common_command_for_block): Update.
8051         * exec.c (try_open_exec_file): Update.
8052         * exceptions.c (print_exception, exception_print)
8053         (exception_fprintf, exception_print_same): Update.
8054         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
8055         * dwarf-index-cache.c (index_cache::store)
8056         (index_cache::lookup_gdb_index): Update.
8057         * darwin-nat.c (maybe_cache_shell): Update.
8058         * cp-valprint.c (cp_print_value_fields): Update.
8059         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
8060         (gcc_cplus_symbol_address): Update.
8061         * compile/compile-c-symbols.c (gcc_convert_symbol)
8062         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
8063         * common/selftest.c: Update.
8064         * common/common-exceptions.h (struct gdb_exception) <message>: Now
8065         a std::string.
8066         (exception_try_scope_entry, exception_try_scope_exit): Don't
8067         declare.
8068         (struct exception_try_scope): Remove.
8069         (TRY): Don't use exception_try_scope.
8070         (struct gdb_exception): Add constructor, operator=.
8071         <what>: New method.
8072         (struct gdb_exception_RETURN_MASK_ALL)
8073         (struct gdb_exception_RETURN_MASK_ERROR)
8074         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
8075         (struct gdb_quit_bad_alloc): Update.
8076         * common/common-exceptions.c (exception_none): Change
8077         initializer.
8078         (struct catcher) <state, exception>: Initialize inline.
8079         <prev>: Remove member.
8080         (current_catcher): Remove.
8081         (catchers): New global.
8082         (exceptions_state_mc_init): Simplify.
8083         (catcher_pop): Remove.
8084         (exceptions_state_mc, exceptions_state_mc_catch): Update.
8085         (try_scope_depth, exception_try_scope_entry)
8086         (exception_try_scope_exit): Remove.
8087         (throw_exception_sjlj): Update.
8088         (exception_messages, exception_messages_size): Remove.
8089         (throw_it): Simplify.
8090         (gdb_exception_sliced_copy): Remove.
8091         (throw_exception_cxx): Update.
8092         * cli/cli-script.c (script_from_file): Update.
8093         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
8094         Update.
8095         * ada-valprint.c (ada_val_print): Update.
8096         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
8097         (create_excep_cond_exprs): Update.
8098
8099 2019-04-08  Tom Tromey  <tom@tromey.com>
8100
8101         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
8102         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
8103         (TRY, CATCH, END_CATCH): Remove some definitions.
8104         * common/common-exceptions.c: Don't use GDB_XCPT.
8105         (catcher_list_size): Remove.
8106         (throw_exception, throw_it): Simplify.
8107
8108 2019-04-05  Tom Tromey  <tom@tromey.com>
8109
8110         Revert the header-sorting patch.
8111         * ft32-tdep.c: Revert.
8112         * frv-tdep.c: Revert.
8113         * frv-linux-tdep.c: Revert.
8114         * frame.c: Revert.
8115         * frame-unwind.c: Revert.
8116         * frame-base.c: Revert.
8117         * fork-child.c: Revert.
8118         * findvar.c: Revert.
8119         * findcmd.c: Revert.
8120         * filesystem.c: Revert.
8121         * filename-seen-cache.h: Revert.
8122         * filename-seen-cache.c: Revert.
8123         * fbsd-tdep.c: Revert.
8124         * fbsd-nat.h: Revert.
8125         * fbsd-nat.c: Revert.
8126         * f-valprint.c: Revert.
8127         * f-typeprint.c: Revert.
8128         * f-lang.c: Revert.
8129         * extension.h: Revert.
8130         * extension.c: Revert.
8131         * extension-priv.h: Revert.
8132         * expprint.c: Revert.
8133         * exec.h: Revert.
8134         * exec.c: Revert.
8135         * exceptions.c: Revert.
8136         * event-top.c: Revert.
8137         * event-loop.c: Revert.
8138         * eval.c: Revert.
8139         * elfread.c: Revert.
8140         * dwarf2read.h: Revert.
8141         * dwarf2read.c: Revert.
8142         * dwarf2loc.c: Revert.
8143         * dwarf2expr.h: Revert.
8144         * dwarf2expr.c: Revert.
8145         * dwarf2-frame.c: Revert.
8146         * dwarf2-frame-tailcall.c: Revert.
8147         * dwarf-index-write.h: Revert.
8148         * dwarf-index-write.c: Revert.
8149         * dwarf-index-common.c: Revert.
8150         * dwarf-index-cache.h: Revert.
8151         * dwarf-index-cache.c: Revert.
8152         * dummy-frame.c: Revert.
8153         * dtrace-probe.c: Revert.
8154         * disasm.h: Revert.
8155         * disasm.c: Revert.
8156         * disasm-selftests.c: Revert.
8157         * dictionary.c: Revert.
8158         * dicos-tdep.c: Revert.
8159         * demangle.c: Revert.
8160         * dcache.h: Revert.
8161         * dcache.c: Revert.
8162         * darwin-nat.h: Revert.
8163         * darwin-nat.c: Revert.
8164         * darwin-nat-info.c: Revert.
8165         * d-valprint.c: Revert.
8166         * d-namespace.c: Revert.
8167         * d-lang.c: Revert.
8168         * ctf.c: Revert.
8169         * csky-tdep.c: Revert.
8170         * csky-linux-tdep.c: Revert.
8171         * cris-tdep.c: Revert.
8172         * cris-linux-tdep.c: Revert.
8173         * cp-valprint.c: Revert.
8174         * cp-support.c: Revert.
8175         * cp-namespace.c: Revert.
8176         * cp-abi.c: Revert.
8177         * corelow.c: Revert.
8178         * corefile.c: Revert.
8179         * continuations.c: Revert.
8180         * completer.h: Revert.
8181         * completer.c: Revert.
8182         * complaints.c: Revert.
8183         * coffread.c: Revert.
8184         * coff-pe-read.c: Revert.
8185         * cli-out.h: Revert.
8186         * cli-out.c: Revert.
8187         * charset.c: Revert.
8188         * c-varobj.c: Revert.
8189         * c-valprint.c: Revert.
8190         * c-typeprint.c: Revert.
8191         * c-lang.c: Revert.
8192         * buildsym.c: Revert.
8193         * buildsym-legacy.c: Revert.
8194         * build-id.h: Revert.
8195         * build-id.c: Revert.
8196         * btrace.c: Revert.
8197         * bsd-uthread.c: Revert.
8198         * breakpoint.h: Revert.
8199         * breakpoint.c: Revert.
8200         * break-catch-throw.c: Revert.
8201         * break-catch-syscall.c: Revert.
8202         * break-catch-sig.c: Revert.
8203         * blockframe.c: Revert.
8204         * block.c: Revert.
8205         * bfin-tdep.c: Revert.
8206         * bfin-linux-tdep.c: Revert.
8207         * bfd-target.c: Revert.
8208         * bcache.c: Revert.
8209         * ax-general.c: Revert.
8210         * ax-gdb.h: Revert.
8211         * ax-gdb.c: Revert.
8212         * avr-tdep.c: Revert.
8213         * auxv.c: Revert.
8214         * auto-load.c: Revert.
8215         * arm-wince-tdep.c: Revert.
8216         * arm-tdep.c: Revert.
8217         * arm-symbian-tdep.c: Revert.
8218         * arm-pikeos-tdep.c: Revert.
8219         * arm-obsd-tdep.c: Revert.
8220         * arm-nbsd-tdep.c: Revert.
8221         * arm-nbsd-nat.c: Revert.
8222         * arm-linux-tdep.c: Revert.
8223         * arm-linux-nat.c: Revert.
8224         * arm-fbsd-tdep.c: Revert.
8225         * arm-fbsd-nat.c: Revert.
8226         * arm-bsd-tdep.c: Revert.
8227         * arch-utils.c: Revert.
8228         * arc-tdep.c: Revert.
8229         * arc-newlib-tdep.c: Revert.
8230         * annotate.h: Revert.
8231         * annotate.c: Revert.
8232         * amd64-windows-tdep.c: Revert.
8233         * amd64-windows-nat.c: Revert.
8234         * amd64-tdep.c: Revert.
8235         * amd64-sol2-tdep.c: Revert.
8236         * amd64-obsd-tdep.c: Revert.
8237         * amd64-obsd-nat.c: Revert.
8238         * amd64-nbsd-tdep.c: Revert.
8239         * amd64-nbsd-nat.c: Revert.
8240         * amd64-nat.c: Revert.
8241         * amd64-linux-tdep.c: Revert.
8242         * amd64-linux-nat.c: Revert.
8243         * amd64-fbsd-tdep.c: Revert.
8244         * amd64-fbsd-nat.c: Revert.
8245         * amd64-dicos-tdep.c: Revert.
8246         * amd64-darwin-tdep.c: Revert.
8247         * amd64-bsd-nat.c: Revert.
8248         * alpha-tdep.c: Revert.
8249         * alpha-obsd-tdep.c: Revert.
8250         * alpha-nbsd-tdep.c: Revert.
8251         * alpha-mdebug-tdep.c: Revert.
8252         * alpha-linux-tdep.c: Revert.
8253         * alpha-linux-nat.c: Revert.
8254         * alpha-bsd-tdep.c: Revert.
8255         * alpha-bsd-nat.c: Revert.
8256         * aix-thread.c: Revert.
8257         * agent.c: Revert.
8258         * addrmap.c: Revert.
8259         * ada-varobj.c: Revert.
8260         * ada-valprint.c: Revert.
8261         * ada-typeprint.c: Revert.
8262         * ada-tasks.c: Revert.
8263         * ada-lang.c: Revert.
8264         * aarch64-tdep.c: Revert.
8265         * aarch64-ravenscar-thread.c: Revert.
8266         * aarch64-newlib-tdep.c: Revert.
8267         * aarch64-linux-tdep.c: Revert.
8268         * aarch64-linux-nat.c: Revert.
8269         * aarch64-fbsd-tdep.c: Revert.
8270         * aarch64-fbsd-nat.c: Revert.
8271         * aarch32-linux-nat.c: Revert.
8272
8273 2019-04-05  Tom Tromey  <tom@tromey.com>
8274
8275         * ft32-tdep.c: Sort headers.
8276         * frv-tdep.c: Sort headers.
8277         * frv-linux-tdep.c: Sort headers.
8278         * frame.c: Sort headers.
8279         * frame-unwind.c: Sort headers.
8280         * frame-base.c: Sort headers.
8281         * fork-child.c: Sort headers.
8282         * findvar.c: Sort headers.
8283         * findcmd.c: Sort headers.
8284         * filesystem.c: Sort headers.
8285         * filename-seen-cache.h: Sort headers.
8286         * filename-seen-cache.c: Sort headers.
8287         * fbsd-tdep.c: Sort headers.
8288         * fbsd-nat.h: Sort headers.
8289         * fbsd-nat.c: Sort headers.
8290         * f-valprint.c: Sort headers.
8291         * f-typeprint.c: Sort headers.
8292         * f-lang.c: Sort headers.
8293         * extension.h: Sort headers.
8294         * extension.c: Sort headers.
8295         * extension-priv.h: Sort headers.
8296         * expprint.c: Sort headers.
8297         * exec.h: Sort headers.
8298         * exec.c: Sort headers.
8299         * exceptions.c: Sort headers.
8300         * event-top.c: Sort headers.
8301         * event-loop.c: Sort headers.
8302         * eval.c: Sort headers.
8303         * elfread.c: Sort headers.
8304         * dwarf2read.h: Sort headers.
8305         * dwarf2read.c: Sort headers.
8306         * dwarf2loc.c: Sort headers.
8307         * dwarf2expr.h: Sort headers.
8308         * dwarf2expr.c: Sort headers.
8309         * dwarf2-frame.c: Sort headers.
8310         * dwarf2-frame-tailcall.c: Sort headers.
8311         * dwarf-index-write.h: Sort headers.
8312         * dwarf-index-write.c: Sort headers.
8313         * dwarf-index-common.c: Sort headers.
8314         * dwarf-index-cache.h: Sort headers.
8315         * dwarf-index-cache.c: Sort headers.
8316         * dummy-frame.c: Sort headers.
8317         * dtrace-probe.c: Sort headers.
8318         * disasm.h: Sort headers.
8319         * disasm.c: Sort headers.
8320         * disasm-selftests.c: Sort headers.
8321         * dictionary.c: Sort headers.
8322         * dicos-tdep.c: Sort headers.
8323         * demangle.c: Sort headers.
8324         * dcache.h: Sort headers.
8325         * dcache.c: Sort headers.
8326         * darwin-nat.h: Sort headers.
8327         * darwin-nat.c: Sort headers.
8328         * darwin-nat-info.c: Sort headers.
8329         * d-valprint.c: Sort headers.
8330         * d-namespace.c: Sort headers.
8331         * d-lang.c: Sort headers.
8332         * ctf.c: Sort headers.
8333         * csky-tdep.c: Sort headers.
8334         * csky-linux-tdep.c: Sort headers.
8335         * cris-tdep.c: Sort headers.
8336         * cris-linux-tdep.c: Sort headers.
8337         * cp-valprint.c: Sort headers.
8338         * cp-support.c: Sort headers.
8339         * cp-namespace.c: Sort headers.
8340         * cp-abi.c: Sort headers.
8341         * corelow.c: Sort headers.
8342         * corefile.c: Sort headers.
8343         * continuations.c: Sort headers.
8344         * completer.h: Sort headers.
8345         * completer.c: Sort headers.
8346         * complaints.c: Sort headers.
8347         * coffread.c: Sort headers.
8348         * coff-pe-read.c: Sort headers.
8349         * cli-out.h: Sort headers.
8350         * cli-out.c: Sort headers.
8351         * charset.c: Sort headers.
8352         * c-varobj.c: Sort headers.
8353         * c-valprint.c: Sort headers.
8354         * c-typeprint.c: Sort headers.
8355         * c-lang.c: Sort headers.
8356         * buildsym.c: Sort headers.
8357         * buildsym-legacy.c: Sort headers.
8358         * build-id.h: Sort headers.
8359         * build-id.c: Sort headers.
8360         * btrace.c: Sort headers.
8361         * bsd-uthread.c: Sort headers.
8362         * breakpoint.h: Sort headers.
8363         * breakpoint.c: Sort headers.
8364         * break-catch-throw.c: Sort headers.
8365         * break-catch-syscall.c: Sort headers.
8366         * break-catch-sig.c: Sort headers.
8367         * blockframe.c: Sort headers.
8368         * block.c: Sort headers.
8369         * bfin-tdep.c: Sort headers.
8370         * bfin-linux-tdep.c: Sort headers.
8371         * bfd-target.c: Sort headers.
8372         * bcache.c: Sort headers.
8373         * ax-general.c: Sort headers.
8374         * ax-gdb.h: Sort headers.
8375         * ax-gdb.c: Sort headers.
8376         * avr-tdep.c: Sort headers.
8377         * auxv.c: Sort headers.
8378         * auto-load.c: Sort headers.
8379         * arm-wince-tdep.c: Sort headers.
8380         * arm-tdep.c: Sort headers.
8381         * arm-symbian-tdep.c: Sort headers.
8382         * arm-pikeos-tdep.c: Sort headers.
8383         * arm-obsd-tdep.c: Sort headers.
8384         * arm-nbsd-tdep.c: Sort headers.
8385         * arm-nbsd-nat.c: Sort headers.
8386         * arm-linux-tdep.c: Sort headers.
8387         * arm-linux-nat.c: Sort headers.
8388         * arm-fbsd-tdep.c: Sort headers.
8389         * arm-fbsd-nat.c: Sort headers.
8390         * arm-bsd-tdep.c: Sort headers.
8391         * arch-utils.c: Sort headers.
8392         * arc-tdep.c: Sort headers.
8393         * arc-newlib-tdep.c: Sort headers.
8394         * annotate.h: Sort headers.
8395         * annotate.c: Sort headers.
8396         * amd64-windows-tdep.c: Sort headers.
8397         * amd64-windows-nat.c: Sort headers.
8398         * amd64-tdep.c: Sort headers.
8399         * amd64-sol2-tdep.c: Sort headers.
8400         * amd64-obsd-tdep.c: Sort headers.
8401         * amd64-obsd-nat.c: Sort headers.
8402         * amd64-nbsd-tdep.c: Sort headers.
8403         * amd64-nbsd-nat.c: Sort headers.
8404         * amd64-nat.c: Sort headers.
8405         * amd64-linux-tdep.c: Sort headers.
8406         * amd64-linux-nat.c: Sort headers.
8407         * amd64-fbsd-tdep.c: Sort headers.
8408         * amd64-fbsd-nat.c: Sort headers.
8409         * amd64-dicos-tdep.c: Sort headers.
8410         * amd64-darwin-tdep.c: Sort headers.
8411         * amd64-bsd-nat.c: Sort headers.
8412         * alpha-tdep.c: Sort headers.
8413         * alpha-obsd-tdep.c: Sort headers.
8414         * alpha-nbsd-tdep.c: Sort headers.
8415         * alpha-mdebug-tdep.c: Sort headers.
8416         * alpha-linux-tdep.c: Sort headers.
8417         * alpha-linux-nat.c: Sort headers.
8418         * alpha-bsd-tdep.c: Sort headers.
8419         * alpha-bsd-nat.c: Sort headers.
8420         * aix-thread.c: Sort headers.
8421         * agent.c: Sort headers.
8422         * addrmap.c: Sort headers.
8423         * ada-varobj.c: Sort headers.
8424         * ada-valprint.c: Sort headers.
8425         * ada-typeprint.c: Sort headers.
8426         * ada-tasks.c: Sort headers.
8427         * ada-lang.c: Sort headers.
8428         * aarch64-tdep.c: Sort headers.
8429         * aarch64-ravenscar-thread.c: Sort headers.
8430         * aarch64-newlib-tdep.c: Sort headers.
8431         * aarch64-linux-tdep.c: Sort headers.
8432         * aarch64-linux-nat.c: Sort headers.
8433         * aarch64-fbsd-tdep.c: Sort headers.
8434         * aarch64-fbsd-nat.c: Sort headers.
8435         * aarch32-linux-nat.c: Sort headers.
8436
8437 2019-04-04  Tom Tromey  <tom@tromey.com>
8438
8439         * varobj.c (varobj_create): Update.
8440         * rust-exp.y (struct rust_parser) <update_innermost_block,
8441         lookup_symbol>: New methods.
8442         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
8443         Rename.
8444         (rust_parser::rust_lookup_type)
8445         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8446         * printcmd.c (display_command, do_one_display): Update.
8447         * parser-defs.h (struct parser_state) <parser_state>: Add
8448         "tracker" parameter.
8449         (block_tracker): New member.
8450         (class innermost_block_tracker) <innermost_block_tracker>: Add
8451         "types" parameter.
8452         <reset>: Remove method.
8453         (innermost_block): Don't declare.
8454         (null_post_parser): Update.
8455         * parse.c (innermost_block): Remove global.
8456         (write_dollar_variable): Update.
8457         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
8458         Remove "tracker_types" parameter.
8459         (parse_expression): Add "tracker" parameter.
8460         (parse_expression_for_completion): Update.
8461         (null_post_parser): Add "tracker" parameter.
8462         * p-exp.y: Update rules.
8463         * m2-exp.y: Update rules.
8464         * language.h (struct language_defn) <la_post_parser>: Add
8465         "tracker" parameter.
8466         * go-exp.y: Update rules.
8467         * f-exp.y: Update rules.
8468         * expression.h (parse_expression, parse_exp_1): Add "tracker"
8469         parameter.
8470         * d-exp.y: Update rules.
8471         * c-exp.y: Update rules.
8472         * breakpoint.c (set_breakpoint_condition): Create an
8473         innermost_block_tracker.
8474         (watch_command_1): Likewise.
8475         * ada-lang.c (resolve): Add "tracker" parameter.
8476         (resolve_subexp): Likewise.
8477         * ada-exp.y (write_var_from_sym): Update.
8478
8479 2019-04-04  Tom Tromey  <tom@tromey.com>
8480
8481         * type-stack.h: New file.
8482         * type-stack.c: New file.
8483         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
8484         type-stack.h.
8485         (insert_into_type_stack, insert_type, push_type, push_type_int)
8486         (insert_type_address_space, pop_type, pop_type_int)
8487         (pop_typelist, pop_type_stack, append_type_stack)
8488         (push_type_stack, get_type_stack, push_typelist)
8489         (follow_type_instance_flags, follow_types): Don't declare.
8490         * parse.c (type_stack): Remove global.
8491         (parse_exp_in_context): Update.
8492         (insert_into_type_stack, insert_type, push_type, push_type_int)
8493         (insert_type_address_space, pop_type, pop_type_int)
8494         (pop_typelist, pop_type_stack, append_type_stack)
8495         (push_type_stack, get_type_stack, push_typelist)
8496         (follow_type_instance_flags, follow_types): Remove (moved to
8497         type-stack.c).
8498         * f-exp.y (type_stack): New global.
8499         Update rules.
8500         (push_kind_type, f_parse): Update.
8501         * d-exp.y (type_stack): New global.
8502         Update rules.
8503         (d_parse): Update.
8504         * c-exp.y (struct c_parse_state) <type_stack>: New member.
8505         Update rules.
8506         * Makefile.in (COMMON_SFILES): Add type-stack.c.
8507         (HFILES_NO_SRCDIR): Add type-stack.h.
8508
8509 2019-04-04  Tom Tromey  <tom@tromey.com>
8510
8511         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
8512         (rust_parser::convert_ast_to_expression, rust_parse)
8513         (rust_lex_test_completion, rust_lex_tests): Update.
8514         * parser-defs.h (struct expr_completion_state): New.
8515         (struct parser_state) <parser_state>: Add completion parameter.
8516         <mark_struct_expression, mark_completion_tag>: New methods.
8517         <parse_completion, m_completion_state>: New members.
8518         (prefixify_expression, null_post_parser): Update.
8519         (mark_struct_expression, mark_completion_tag): Don't declare.
8520         * parse.c (parse_completion, expout_last_struct)
8521         (expout_tag_completion_type, expout_completion_name): Remove
8522         globals.
8523         (parser_state::mark_struct_expression)
8524         (parser_state::mark_completion_tag): Now methods.
8525         (prefixify_expression): Add last_struct parameter.
8526         (prefixify_subexp): Likewise.
8527         (parse_exp_1): Update.
8528         (parse_exp_in_context): Add cstate parameter.  Update.
8529         (parse_expression_for_completion): Create an
8530         expr_completion_state.
8531         (null_post_parser): Add "completion" parameter.
8532         * p-exp.y: Update rules.
8533         (yylex): Update.
8534         * language.h (struct language_defn) <la_post_parser>: Add
8535         "completing" parameter.
8536         * go-exp.y: Update rules.
8537         (lex_one_token): Update.
8538         * expression.h (parse_completion): Don't declare.
8539         * d-exp.y: Update rules.
8540         (lex_one_token): Update rules.
8541         * c-exp.y: Update rules.
8542         (lex_one_token): Update.
8543         * ada-lang.c (resolve): Add "parse_completion" parameter.
8544         (resolve_subexp): Likewise.
8545         (ada_resolve_function): Likewise.
8546
8547 2019-04-04  Tom Tromey  <tom@tromey.com>
8548
8549         * parser-defs.h (struct parser_state) <start_arglist,
8550         end_arglist>: New methods.
8551         <arglist_len, m_funcall_chain>: New members.
8552         (arglist_len, start_arglist, end_arglist): Don't declare.
8553         * parse.c (arglist_len, funcall_chain): Remove global.
8554         (start_arglist, end_arglist): Remove functions.
8555         (parse_exp_in_context): Update.
8556         * p-exp.y: Update rules.
8557         * m2-exp.y: Update rules.
8558         * go-exp.y: Update rules.
8559         * f-exp.y: Update rules.
8560         * d-exp.y: Update rules.
8561         * c-exp.y: Update rules.
8562
8563 2019-04-04  Tom Tromey  <tom@tromey.com>
8564
8565         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
8566         lex_operator, push_back>: New methods.
8567         Update all rules.
8568         (rust_parser::lex_hex, lex_escape): Rename and update.
8569         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
8570         (rust_parser::lex_operator): Rename and update.
8571         (rust_parser::lex_number, rustyylex, rustyyerror)
8572         (rust_lex_test_init, rust_lex_test_sequence)
8573         (rust_lex_test_push_back, rust_lex_tests): Update.
8574         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
8575         parameter.
8576         <lexptr, prev_lexptr>: New members.
8577         (lexptr, prev_lexptr): Don't declare.
8578         * parse.c (lexptr, prev_lexptr): Remove globals.
8579         (parse_exp_in_context): Update.
8580         * p-exp.y (yylex, yyerror): Update.
8581         * m2-exp.y (parse_number, yylex, yyerror): Update.
8582         * go-exp.y (lex_one_token, yyerror): Update.
8583         * f-exp.y (match_string_literal, yylex, yyerror): Update.
8584         * d-exp.y (lex_one_token, yyerror): Update.
8585         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
8586         (lex_one_token, yyerror): Update.
8587         * ada-lex.l (YY_INPUT): Update.
8588         (rewind_to_char): Update.
8589         * ada-exp.y (yyerror): Update.
8590
8591 2019-04-04  Tom Tromey  <tom@tromey.com>
8592
8593         * rust-exp.y (rustyylex, rust_lex_tests): Update.
8594         * parser-defs.h (struct parser_state) <parser_state>: Add new
8595         parameter.
8596         <comma_terminates>: New member.
8597         (comma_terminates): Don't declare global.
8598         * parse.c (comma_terminates): Remove global.
8599         (parse_exp_in_context): Update.
8600         * p-exp.y (yylex): Update.
8601         * m2-exp.y (yylex): Update.
8602         * go-exp.y (lex_one_token): Update.
8603         * f-exp.y (yylex): Update.
8604         * d-exp.y (lex_one_token): Update.
8605         * c-exp.y (lex_one_token): Update.
8606         * ada-lex.l: Update.
8607
8608 2019-04-04  Tom Tromey  <tom@tromey.com>
8609
8610         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
8611         (rustyylex, rust_lex_test_init, rust_lex_test_one)
8612         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
8613         * parser-defs.h (paren_depth): Don't declare.
8614         * parse.c (paren_depth): Remove global.
8615         (parse_exp_in_context): Update.
8616         * p-exp.y (paren_depth): New global.
8617         (pascal_parse): Initialize it.
8618         * m2-exp.y (paren_depth): New global.
8619         (m2_parse): Initialize it.
8620         * go-exp.y (paren_depth): New global.
8621         (go_parse): Initialize it.
8622         * f-exp.y (paren_depth): New global.
8623         (f_parse): Initialize it.
8624         * d-exp.y (paren_depth): New global.
8625         (d_parse): Initialize it.
8626         * c-exp.y (paren_depth): New global.
8627         (c_parse): Initialize it.
8628         * ada-lex.l (paren_depth): New global.
8629         (lexer_init): Initialize it.
8630
8631 2019-04-04  Tom Tromey  <tom@tromey.com>
8632
8633         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
8634         (rust_parser::convert_ast_to_type)
8635         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8636         * parser-defs.h (struct parser_state) <parser_state>: Add
8637         parameters.  Initialize new members.
8638         <expression_context_block, expression_context_pc>: New members.
8639         * parse.c (expression_context_block, expression_context_pc):
8640         Remove globals.
8641         (parse_exp_in_context): Update.
8642         * p-exp.y: Update all rules.
8643         (yylex): Update.
8644         * m2-exp.y: Update all rules.
8645         (yylex): Update.
8646         * go-exp.y (yylex): Update.
8647         * f-exp.y (yylex): Update.
8648         * d-exp.y: Update all rules.
8649         (yylex): Update.
8650         * c-exp.y: Update all rules.
8651         (lex_one_token, classify_name, yylex, c_parse): Update.
8652         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
8653
8654 2019-04-04  Tom Tromey  <tom@tromey.com>
8655
8656         * gdbarch.h, gdbarch.c: Rebuild.
8657         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
8658         * stap-probe.h:
8659         (struct stap_parse_info): Replace "parser_state" with
8660         "expr_builder".
8661         * parser-defs.h (struct expr_builder): Rename from "parser_state".
8662         (parser_state): New class.
8663         * parse.c (expr_builder): Rename.
8664         (expr_builder::release): Rename.
8665         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
8666         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
8667         (write_exp_elt_longcst, write_exp_elt_floatcst)
8668         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
8669         (write_exp_string_vector, write_exp_bitstring)
8670         (write_exp_msymbol, mark_struct_expression)
8671         (write_dollar_variable)
8672         (insert_type_address_space, increase_expout_size): Replace
8673         "parser_state" with "expr_builder".
8674         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
8675         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
8676         "parser_state" with "expr_builder".
8677
8678 2019-04-04  Tom Tromey  <tom@tromey.com>
8679
8680         * rust-exp.y: Replace "parse_language" with method call.
8681         * p-exp.y:
8682         (yylex): Replace "parse_language" with method call.
8683         * m2-exp.y:
8684         (yylex): Replace "parse_language" with method call.
8685         * go-exp.y (classify_name): Replace "parse_language" with method
8686         call.
8687         * f-exp.y (yylex): Replace "parse_language" with method call.
8688         * d-exp.y (lex_one_token): Replace "parse_language" with method
8689         call.
8690         * c-exp.y:
8691         (lex_one_token, classify_name, yylex): Replace "parse_language"
8692         with method call.
8693         * ada-exp.y (find_primitive_type, type_char)
8694         (type_system_address): Replace "parse_language" with method call.
8695
8696 2019-04-04  Tom Tromey  <tom@tromey.com>
8697
8698         * rust-exp.y: Replace "parse_gdbarch" with method call.
8699         * parse.c (write_dollar_variable, insert_type_address_space):
8700         Replace "parse_gdbarch" with method call.
8701         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
8702         call.
8703         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
8704         call.
8705         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
8706         "parse_gdbarch" with method call.
8707         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
8708         with method call.
8709         * f-exp.y (parse_type, parse_f_type, yylex): Replace
8710         "parse_gdbarch" with method call.
8711         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
8712         "parse_gdbarch" with method call.
8713         * c-exp.y (parse_type, parse_number, classify_name): Replace
8714         "parse_gdbarch" with method call.
8715         * ada-lex.l: Replace "parse_gdbarch" with method call.
8716         * ada-exp.y (parse_type, find_primitive_type, type_char)
8717         (type_system_address): Replace "parse_gdbarch" with method call.
8718
8719 2019-04-04  Tom Tromey  <tom@tromey.com>
8720
8721         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
8722         * stap-probe.c (stap_parse_argument): Update.
8723         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
8724         initial_size parameter.
8725         * rust-exp.y (rust_lex_tests): Update.
8726         * parse.c (parser_state): Update.
8727         (parse_exp_in_context): Update.
8728         * parser-defs.h (struct parser_state) <parser_state>: Remove
8729         "initial_size" parameter.
8730
8731 2019-04-04  Tom Tromey  <tom@tromey.com>
8732
8733         * parser-defs.h (increase_expout_size): Don't declare.
8734         * parse.c (increase_expout_size): Now static.
8735
8736 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
8737
8738         * gnu-nat.c (gnu_nat_target::wait): Fix
8739         target_waitstatus_to_string call.
8740
8741 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8742
8743         * eval.c (evaluate_subexp_standard): Handle internal functions
8744         during Fortran function call handling.
8745
8746 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8747
8748         * NEWS: Mention new internal functions.
8749         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
8750         (read_base_type): Use dwarf2_init_complex_target_type.
8751         * value.c (creal_internal_fn): New function.
8752         (cimag_internal_fn): New function.
8753         (_initialize_values): Register new internal functions.
8754
8755 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8756
8757         * infrun.c (stop_all_threads): If debug_infrun, always
8758         trace the wait status after wait_one, using
8759         target_waitstatus_to_string and target_pid_to_str.
8760         (handle_inferior_event): Replace various trace of
8761         wait status kind by a single trace.
8762         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
8763         wait status kind image by target_waitstatus_to_string.
8764         * target/waitstatus.c (target_waitstatus_to_string): Fix
8765         obsolete comment.
8766
8767 2019-04-01  Tom Tromey  <tromey@adacore.com>
8768
8769         PR symtab/23331:
8770         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
8771
8772 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
8773             Pedro Alves  <palves@redhat.com>
8774
8775         * top.c (quit_force): Call 'finalize_values'.
8776         * value.c (finalize_values): New function.
8777         * value.h (finalize_values): Declare.
8778
8779 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
8780
8781         * NEWS: Announce $_gdb_major and $_gdb_minor.
8782
8783         * top.c (init_gdb_version_vars): New function.
8784         (gdb_init): Call init_gdb_version_vars.
8785
8786 2019-03-29  Tom Tromey  <tromey@adacore.com>
8787
8788         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
8789         help text.  Remove dead code.
8790
8791 2019-03-29  Keith Seitz  <keiths@redhat.com>
8792
8793         From Siddhesh Poyarekar:
8794         * f-lang.h (f77_get_upperbound): Return LONGEST.
8795         (f77_get_lowerbound): Likewise.
8796         * f-typeprint.c (f_type_print_varspec_suffix): Expand
8797         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
8798         print them.
8799         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
8800         plongest to format print it.
8801         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
8802         (f77_get_upperbound): Likewise.
8803         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
8804         LOWER_BOUND to LONGEST.
8805         (f77_create_arrayprint_offset_tbl): Likewise.
8806
8807 2019-03-29  Keith Seitz  <keiths@redhat.com>
8808
8809         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
8810         %s/pulongest for TYPE_LENGTH instead of %d in format
8811         strings.
8812         * ada-typerint.c (ada_print_type): Likewise.
8813         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
8814         * compile/compile-c-support.c (generate_register_struct): Likewise.
8815         * gdbtypes.c (recursive_dump_type): Likewise.
8816         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
8817         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
8818         instead of %d in format strings.
8819         * riscv-tdep.c (riscv_type_alignment): Cast second argument
8820         to std::min to ULONGEST.
8821         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
8822         instead of %d in format strings.
8823         * tracepoint.c (info_scope_command): Likewise.
8824         * typeprint.c (print_offset_data::update)
8825         (print_offset_data::finish): Likewise.
8826         * xtensa-tdep.c (xtensa_store_return_value)
8827         (xtensa_push_dummy_call): Likewise.
8828
8829 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
8830
8831         * windows-nat.c (display_selector): Fixed format specifications
8832         for 64-bit Cygwin.
8833
8834 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8835
8836         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
8837
8838 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
8839
8840         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
8841         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
8842         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
8843         (nios2_linux_init_abi): Install it.
8844
8845 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8846
8847         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
8848
8849 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8850
8851         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
8852
8853 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8854             Tom Tromey  <tromey@adacore.com>
8855
8856         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
8857
8858 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
8859
8860         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
8861         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
8862         method to compute the bounds of range types. Also print "[evaluated]"
8863         if the bounds' values come from a dynamic evaluation.
8864
8865 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8866
8867         * cp-valprint.c (cp_print_value_fields): Don't print trailing
8868         whitespace when pretty printing is on.
8869
8870 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8871
8872         * ppc-linux-nat.c: Add include.
8873
8874 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8875
8876         * NEWS: Mention AArch64 Pointer Authentication.
8877
8878 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8879
8880         * arm-linux-nat.c: Add include.
8881
8882 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
8883
8884         * source-cache.c (source_cache::get_source_lines): Re-read
8885         fullname after calling open_source_file.
8886
8887 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
8888
8889         * NEWS: Mention TLS support for FreeBSD.
8890
8891 2019-03-25  Tom Tromey  <tromey@adacore.com>
8892
8893         * minsyms.c (BUNCH_SIZE): Update comment.
8894         (~minimal_symbol_reader): Remove old comment.
8895         (compact_minimal_symbols): Update comment.
8896         (minimal_symbol_reader::install): Remove old comment.  Update
8897         other comments.
8898
8899 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8900
8901         * s390-linux-nat.c: Add include.
8902
8903 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8904
8905         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
8906         Call linux_get_hwcap.
8907         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
8908         Likewise.
8909         (aarch64_linux_get_hwcap): Remove function.
8910         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
8911         declaration.
8912         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
8913         linux_get_hwcap.
8914         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
8915         * linux-tdep.c (linux_get_hwcap): Add function.
8916         (linux_get_hwcap2): Likewise.
8917         * linux-tdep.h (linux_get_hwcap): Add declaration.
8918         (linux_get_hwcap2): Likewise.
8919         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
8920         (ppc_linux_get_hwcap2): Likewise.
8921         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
8922         linux_get_hwcap.
8923         (ppc_linux_nat_target::insert_watchpoint): Likewise.
8924         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
8925         (ppc_linux_nat_target::read_description): Likewise.
8926         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
8927         * s390-linux-nat.c: Likewise.
8928         * s390-linux-tdep.c (s390_core_read_description): Likewise.
8929
8930 2019-03-24  Tom Tromey  <tom@tromey.com>
8931
8932         * ada-lang.c (standard_lookup): Simplify initialization.
8933         (ada_lookup_symbol_nonlocal): Simplify return.
8934         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
8935         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
8936         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
8937         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
8938         initialization.
8939         * solib.c (solib_global_lookup): Simplify.
8940         * symtab.c (null_block_symbol): Remove.
8941         (symbol_cache_lookup): Simplify returns.
8942         (lookup_language_this): Simplify returns.
8943         (lookup_symbol_aux): Simplify return.
8944         (lookup_local_symbol): Simplify returns.
8945         (lookup_global_symbol_from_objfile): Simplify return.
8946         (lookup_symbol_in_objfile_symtabs)
8947         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
8948         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
8949         (lookup_static_symbol, lookup_global_symbol): Simplify return.
8950         * cp-namespace.c (cp_lookup_bare_symbol)
8951         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
8952         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
8953         (cp_lookup_nested_symbol): Don't use null_block_symbol.
8954         (cp_lookup_symbol_via_imports): Simplify initialization.
8955         (find_symbol_in_baseclass): Likewise.
8956         * symtab.h (null_block_symbol): Remove.
8957         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
8958         (d_lookup_nested_symbol, d_lookup_symbol_imports)
8959         (d_lookup_symbol_module): Likewise.
8960         (find_symbol_in_baseclass): Simplify initialization.
8961
8962 2019-03-24  Tom Tromey  <tom@tromey.com>
8963
8964         * expression.h: Don't include symtab.h.
8965         (struct block): Forward declare.
8966
8967 2019-03-24  Tom Tromey  <tom@tromey.com>
8968
8969         * c-exp.y (typebase): Remove casts.
8970         * gdbtypes.c (lookup_unsigned_typename, )
8971         (lookup_signed_typename): Remove cast.
8972         * eval.c (parse_to_comma_and_eval): Remove cast.
8973         * parse.c (write_dollar_variable): Remove cast.
8974         * block.h (struct block) <superblock>: Now const.
8975         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
8976         * psymtab.c (psym_map_matching_symbols): Make "block" const.
8977         (map_block): Make "block" const.
8978         * symfile.h (struct quick_symbol_functions)
8979         <map_matching_symbols>: Constify block argument to "callback".
8980         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
8981         const.
8982         (find_pc_sect_compunit_symtab): Make "b" const.
8983         (find_symbol_at_address): Likewise.
8984         (search_symbols): Likewise.
8985         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
8986         (dw2_debug_names_lookup_symbol): Likewise.
8987         (dw2_map_matching_symbols): Update.
8988         * p-valprint.c (pascal_val_print): Remove "block".
8989         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
8990         (aux_add_nonlocal_symbols): Make "block" const.
8991         (resolve_subexp): Remove cast.
8992         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
8993         const.
8994         (iterate_over_file_blocks): Likewise.
8995         * f-exp.y (%union) <bval>: Remove.
8996         * coffread.c (patch_opaque_types): Make "b" const.
8997         * spu-tdep.c (spu_catch_start): Make "block" const.
8998         * c-valprint.c (print_unpacked_pointer): Remove "block".
8999         * symmisc.c (dump_symtab_1): Make "b" const.
9000         (block_depth): Make "block" const.
9001         * d-exp.y (%union) <bval>: Remove.
9002         * cp-support.h (cp_lookup_rtti_type): Update.
9003         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
9004         * psymtab.c (psym_lookup_symbol): Make "block" const.
9005         (maintenance_check_psymtabs): Make "b" const.
9006         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
9007         (enumerate_locals, enumerate_args): Update.
9008         * python/py-symtab.c (stpy_global_block): Make "block" const.
9009         (stpy_static_block): Likewise.
9010         * inline-frame.c (block_starting_point_at): Make "new_block"
9011         const.
9012         * block.c (find_block_in_blockvector): Make return type const.
9013         (blockvector_for_pc_sect): Make "b" const.
9014         (find_block_in_blockvector): Make "b" const.
9015
9016 2019-03-23  Tom Tromey  <tom@tromey.com>
9017
9018         * varobj.c (varobj_create): Update.
9019         * symfile.c (clear_symtab_users): Don't reset innermost_block.
9020         * printcmd.c (display_command, do_one_display): Don't reset
9021         innermost_block.
9022         * parser-defs.h (enum innermost_block_tracker_type): Move to
9023         expression.h.
9024         (innermost_block): Update comment.
9025         * parse.c (parse_exp_1): Add tracker_types parameter.
9026         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
9027         tracker_types parameter.  Reset innermost_block.
9028         (parse_exp_in_context): Remove.
9029         (parse_expression_for_completion): Update.
9030         * objfiles.c (~objfile): Don't reset expression_context_block or
9031         innermost_block.
9032         * expression.h (enum innermost_block_tracker_type): Move from
9033         parser-defs.h.
9034         (parse_exp_1): Add tracker_types parameter.
9035         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
9036         reset innermost_block.
9037
9038 2019-03-23  Tom Tromey  <tom@tromey.com>
9039
9040         * objfiles.h: Include bcache.h.
9041
9042 2019-03-23  Tom Tromey  <tom@tromey.com>
9043
9044         * linespec.c (get_current_search_block): Use
9045         scoped_restore_current_language.
9046         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
9047
9048 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9049             Jiong Wang  <jiong.wang@arm.com>
9050
9051         * aarch64-linux-tdep.c
9052         (aarch64_linux_iterate_over_regset_sections): Check for pauth
9053         section.
9054         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
9055
9056 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9057             Jiong Wang  <jiong.wang@arm.com>
9058
9059         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
9060         instructions.
9061         (aarch64_analyze_prologue_test): Add PACIASP test.
9062         (aarch64_prologue_prev_register): Unmask PC value.
9063
9064 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9065             Jiong Wang  <jiong.wang@arm.com>
9066
9067         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
9068         (aarch64_dwarf2_prev_register): Unmask PC value.
9069         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
9070         (aarch64_execute_dwarf_cfa_vendor_op): Check for
9071         DW_CFA_AARCH64_negate_ra_state.
9072         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
9073
9074 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9075             Jiong Wang  <jiong.wang@arm.com>
9076
9077         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
9078         registers.
9079         (aarch64_pseudo_register_name): Likewise.
9080         (aarch64_pseudo_register_type): Likewise.
9081         (aarch64_pseudo_register_reggroup_p): Likewise.
9082         (aarch64_gdbarch_init): Add pauth registers.
9083         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
9084         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
9085         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
9086         (struct gdbarch_tdep): Add regnum for ra_state.
9087
9088 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9089             Jiong Wang  <jiong.wang@arm.com>
9090
9091         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
9092
9093 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9094             Jiong Wang  <jiong.wang@arm.com>
9095
9096         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
9097         function.
9098         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
9099         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
9100         (aarch64_gdbarch_init): Add puth registers.
9101         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
9102         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
9103         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
9104
9105 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9106             Jiong Wang  <jiong.wang@arm.com>
9107
9108         * aarch64-linux-nat.c
9109         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
9110         * aarch64-linux-tdep.c
9111         (aarch64_linux_core_read_description): Likewise.
9112         (aarch64_linux_get_hwcap): New function.
9113         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
9114         (aarch64_linux_get_hwcap): New declaration.
9115
9116 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9117             Jiong Wang  <jiong.wang@arm.com>
9118
9119         * aarch64-linux-nat.c
9120         (aarch64_linux_nat_target::read_description): Add pauth param.
9121         * aarch64-linux-tdep.c
9122         (aarch64_linux_core_read_description): Likewise.
9123         * aarch64-tdep.c (struct target_desc): Add in pauth.
9124         (aarch64_read_description): Add pauth param.
9125         (aarch64_gdbarch_init): Likewise.
9126         * aarch64-tdep.h (aarch64_read_description): Likewise.
9127         * arch/aarch64.c (aarch64_create_target_description): Likewise.
9128         * arch/aarch64.h (aarch64_create_target_description): Likewise.
9129         * features/Makefile: Add new files.
9130         * features/aarch64-pauth.c: New file.
9131         * features/aarch64-pauth.xml: New file.
9132
9133 2019-03-20  Tom Tromey  <tromey@adacore.com>
9134
9135         * infrun.c (handle_inferior_event): Rename from
9136         handle_inferior_event_1.  Create a scoped_value_mark.
9137         (handle_inferior_event): Remove.
9138
9139 2019-03-19  Tom Tromey  <tromey@adacore.com>
9140
9141         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
9142         * infrun.h (print_stop_event): Add "displays" parameter.
9143         * infrun.c (print_stop_event): Add "displays" parameter.
9144
9145 2019-03-19  Pedro Alves  <palves@redhat.com>
9146
9147         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
9148         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
9149         to -1.  Fix TABs vs spaces.
9150         (tui_ui_out::tui_ui_out): Don't initialize fields here.
9151         * tui/tui-out.h (tui_ui_out) Add intro comments.
9152         <m_line, m_start_of_line>: In-class initialize, and add describing
9153         comment.
9154
9155 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
9156
9157         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
9158         variable names.
9159         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
9160
9161 2019-03-18  Pedro Alves  <palves@redhat.com>
9162             Eli Zaretskii <eliz@gnu.org>
9163
9164         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
9165         m_line and m_start_of_line.
9166
9167 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
9168
9169         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
9170         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
9171         it returns a newline.  This fixes a regression in TU mode, whereby
9172         the next line is output on the same screen line as the user input.
9173
9174 2019-03-18  Tom Tromey  <tromey@adacore.com>
9175
9176         * minsyms.c (minimal_symbol_reader::install): Remove call to
9177         obstack_blank.
9178
9179 2019-03-18  Pedro Alves  <palves@redhat.com>
9180
9181         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
9182         New globals.
9183         (apply_style): New, factored out from ...
9184         (apply_ansi_escape): ... this.  Handle reverse video mode.
9185         (tui_set_reverse_mode): New function.
9186         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
9187         * tui/tui-winsource.c (tui_show_source_line): Use
9188         tui_set_reverse_mode instead of setting A_STANDOUT.
9189         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
9190         New setter methods.
9191
9192 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
9193
9194         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
9195         Handle tabs.
9196
9197 2019-03-18  Tom Tromey  <tromey@adacore.com>
9198
9199         * ada-lang.c (empty_array): Add "high" parameter.
9200         (ada_evaluate_subexp): Update.
9201
9202 2019-03-17  Sergei Trofimovich <siarheit@google.com>
9203
9204         * unittests/string_view-selftests.c: Define
9205         _initialize_string_view_selftests unconditionally.
9206
9207 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9208
9209         PR gdb/24350
9210         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
9211
9212 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9213
9214         PR gdb/24351
9215         * windows-nat.c (display_selector): Fix format specifiers.
9216
9217 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
9218
9219         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
9220         tui_refill_source_window instead of tui_refresh_win, to update the
9221         current execution line.  This fixes redisplay of the current line
9222         when stepping through the code with "next" or "step".
9223
9224 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9225
9226         * source-cache.c (source_cache::get_source_lines): Call
9227         find_source_lines to initialize s->nlines.  This fixes vertical
9228         scrolling of TUI source window when the DOWN arrow is pressed.
9229
9230 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9231
9232         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
9233         linux-thread-db.c (_initialize_thread_db): Likewise.
9234
9235 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9236
9237         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
9238         wclrtoeol in tui_show_source_line".  This reverts changes made in
9239         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
9240
9241 2019-03-15  Tom Tromey  <tom@tromey.com>
9242
9243         * symtab.h (struct minimal_symbol): Derive from
9244         general_symbol_info.
9245         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
9246         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
9247         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
9248         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
9249         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
9250         (MSYMBOL_SEARCH_NAME): Update.
9251         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
9252         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
9253         * minsyms.c (minimal_symbol_reader::record_full): Update.
9254
9255 2019-03-15  Tom Tromey  <tom@tromey.com>
9256
9257         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
9258
9259 2019-03-15  Tom Tromey  <tom@tromey.com>
9260
9261         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
9262         unique_xmalloc_ptr.
9263         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
9264         Update.
9265         * minsyms.c (lookup_minimal_symbol_by_pc_section)
9266         (build_minimal_symbol_hash_tables)
9267         (minimal_symbol_reader::install): Update.
9268
9269 2019-03-15  Tom Tromey  <tom@tromey.com>
9270
9271         * symtab.c (create_demangled_names_hash): Update.
9272         (symbol_set_names): Update.
9273         * objfiles.h (struct objfile_per_bfd_storage)
9274         <demangled_names_hash>: Now an htab_up.
9275         * objfiles.c (objfile_per_bfd_storage): Simplify.
9276
9277 2019-03-15  Tom Tromey  <tom@tromey.com>
9278
9279         * objfiles.h (struct objfile_per_bfd_storage): Declare
9280         destructor.
9281         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
9282         New.
9283         (get_objfile_bfd_data): Use new.  Don't initialize
9284         language_of_main.
9285         (free_objfile_per_bfd_storage): Remove.
9286         (objfile_bfd_data_free, objfile::~objfile): Use delete.
9287
9288 2019-03-15  Tom Tromey  <tom@tromey.com>
9289
9290         * symfile.c (reread_symbols): Update.
9291         * objfiles.c (objfile::objfile): Update.
9292         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
9293         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
9294         comment.
9295         (minimal_symbol_reader::install): Update.
9296         (terminate_minimal_symbol_table): Remove.
9297         * jit.c (jit_object_close_impl): Update.
9298
9299 2019-03-15  Tom Tromey  <tom@tromey.com>
9300
9301         * minsyms.c (minimal_symbol_reader::record_full): Remove some
9302         initializations.
9303
9304 2019-03-15  Tom Tromey  <tom@tromey.com>
9305
9306         * objfiles.h (struct objfile_per_bfd_storage)
9307         <demangled_hash_languages>: Now a bitset.
9308         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
9309         (lookup_minimal_symbol): Update.
9310
9311 2019-03-15  Tom Tromey  <tom@tromey.com>
9312
9313         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
9314         Don't return the symbol.
9315         * coffread.c (record_minimal_symbol): Use record_full.
9316
9317 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
9318
9319         The MS-Windows port of ncurses fails to switch to a color pair if
9320         one or both of the colors are the implicit default colors.  This
9321         change records the default colors when TUI is initialized, and
9322         then specifies them explicitly when a color pair uses the default
9323         colors.  This allows color styling in TUI mode on MS-Windows.
9324
9325         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
9326         ncurses_norm_attr.
9327         (tui_initialize_io) [__MINGW32__]: Record the default terminal
9328         colors in ncurses_norm_attr.
9329         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
9330         "none", replace it with the default color recorded in
9331         ncurses_norm_attr.
9332
9333 2019-03-14  Tom Tromey  <tromey@adacore.com>
9334
9335         * source-cache.h (class source_cache) <get_source_lines>: Return
9336         std::string.
9337         * source-cache.c (source_cache::extract_lines): Handle case where
9338         first_pos==npos.  Return std::string.
9339         (source_cache::get_source_lines): Update.
9340
9341 2019-03-14  Tom Tromey  <tromey@adacore.com>
9342
9343         * NEWS: Add item for "style sources" commands.
9344         * source-cache.c (source_cache::get_source_lines): Check
9345         source_styling.
9346         * cli/cli-style.c (source_styling): New global.
9347         (_initialize_cli_style): Add "style sources" commands.
9348         (show_style_sources): New function.
9349         * cli/cli-style.h (source_styling): Declare.
9350
9351 2019-03-14  Pedro Alves  <palves@redhat.com>
9352             Tom Tromey  <tromey@adacore.com>
9353
9354         * tui/tui-winsource.h (tui_refill_source_window): Declare.
9355         * tui/tui-winsource.c (tui_refill_source_window): New function,
9356         from...
9357         (tui_horizontal_source_scroll): ... here.  Move some logic.
9358         * cli/cli-style.c (set_style_enabled): Notify new observable.
9359         * tui/tui-hooks.c (tui_redisplay_source): New function.
9360         (tui_attach_detach_observers): Attach or detach
9361         tui_redisplay_source.
9362         * observable.h (source_styling_changed): New observable.
9363         * observable.c: Define source_styling_changed observable.
9364
9365 2019-03-13  Tom Tromey  <tromey@adacore.com>
9366
9367         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
9368         (i386_gnu_nat_target::store_registers): Update.
9369         * target-debug.h (target_debug_print_std_string): New macro.
9370         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9371         * windows-tdep.c (display_one_tib): Update.
9372         * tui/tui-stack.c (tui_make_status_line): Update.
9373         * top.c (print_inferior_quit_action): Update.
9374         * thread.c (thr_try_catch_cmd): Update.
9375         (add_thread_with_info): Update.
9376         (thread_target_id_str): Update.
9377         (thr_try_catch_cmd): Update.
9378         (thread_command): Update.
9379         (thread_find_command): Update.
9380         * record-btrace.c (record_btrace_target::info_record)
9381         (record_btrace_resume_thread, record_btrace_target::resume)
9382         (record_btrace_cancel_resume, record_btrace_step_thread)
9383         (record_btrace_target::wait, record_btrace_target::wait)
9384         (record_btrace_target::wait, record_btrace_target::stop): Update.
9385         * progspace.c (print_program_space): Update.
9386         * process-stratum-target.c
9387         (process_stratum_target::thread_address_space): Update.
9388         * linux-fork.c (linux_fork_mourn_inferior)
9389         (detach_checkpoint_command, info_checkpoints_command)
9390         (linux_fork_context): Update.
9391         (linux_fork_detach): Update.
9392         (class scoped_switch_fork_info): Update.
9393         (delete_checkpoint_command): Update.
9394         * infrun.c (follow_fork_inferior): Update.
9395         (follow_fork_inferior): Update.
9396         (proceed_after_vfork_done): Update.
9397         (handle_vfork_child_exec_or_exit): Update.
9398         (follow_exec): Update.
9399         (displaced_step_prepare_throw): Update.
9400         (displaced_step_restore): Update.
9401         (start_step_over): Update.
9402         (resume_1): Update.
9403         (clear_proceed_status_thread): Update.
9404         (proceed): Update.
9405         (print_target_wait_results): Update.
9406         (do_target_wait): Update.
9407         (context_switch): Update.
9408         (stop_all_threads): Update.
9409         (restart_threads): Update.
9410         (finish_step_over): Update.
9411         (handle_signal_stop): Update.
9412         (switch_back_to_stepped_thread): Update.
9413         (keep_going_pass_signal): Update.
9414         (print_exited_reason): Update.
9415         (normal_stop): Update.
9416         * inferior.c (inferior_pid_to_str): Change return type.
9417         (print_selected_inferior): Update.
9418         (add_inferior): Update.
9419         (detach_inferior): Update.
9420         * dummy-frame.c (fprint_dummy_frames): Update.
9421         * dcache.c (dcache_info_1): Update.
9422         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
9423         (btrace_fetch, btrace_clear): Update.
9424         * linux-tdep.c (linux_core_pid_to_str): Change return type.
9425         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
9426         type.
9427         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
9428         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
9429         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
9430         * gdbarch.c, gdbarch.h: Rebuild.
9431         * gdbarch.sh (core_pid_to_str): Change return type.
9432         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
9433         return type.
9434         (windows_nat_target::pid_to_str): Change return type.
9435         (windows_delete_thread): Update.
9436         (windows_nat_target::attach): Update.
9437         (windows_nat_target::files_info): Update.
9438         * target-delegates.c: Rebuild.
9439         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
9440         return type.
9441         (sol_thread_target::pid_to_str): Change return type.
9442         * remote.c (class remote_target) <pid_to_str>: Change return
9443         type.
9444         (remote_target::pid_to_str): Change return type.
9445         (extended_remote_target::attach, remote_target::remote_stop_ns)
9446         (remote_target::remote_notif_remove_queued_reply)
9447         (remote_target::push_stop_reply, remote_target::disable_btrace):
9448         Update.
9449         (extended_remote_target::attach): Update.
9450         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
9451         type.
9452         (gdbsim_target::pid_to_str): Change return type.
9453         * ravenscar-thread.c (struct ravenscar_thread_target)
9454         <pid_to_str>: Change return type.
9455         (ravenscar_thread_target::pid_to_str): Change return type.
9456         * procfs.c (class procfs_target) <pid_to_str>: Change return
9457         type.
9458         (procfs_target::pid_to_str): Change return type.
9459         (procfs_target::attach): Update.
9460         (procfs_target::detach): Update.
9461         (procfs_target::fetch_registers): Update.
9462         (procfs_target::store_registers): Update.
9463         (procfs_target::wait): Update.
9464         (procfs_target::files_info): Update.
9465         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
9466         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
9467         return type.
9468         (nto_procfs_target::pid_to_str): Change return type.
9469         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
9470         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
9471         return type.
9472         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
9473         (exit_lwp): Update.
9474         (attach_proc_task_lwp_callback, get_detach_signal)
9475         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
9476         (linux_nat_target::resume, wait_lwp, stop_callback)
9477         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
9478         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
9479         (linux_nat_wait_1, resume_stopped_resumed_lwps)
9480         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
9481         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
9482         type.
9483         (inf_ptrace_target::attach): Update.
9484         (inf_ptrace_target::files_info): Update.
9485         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
9486         type.
9487         (go32_nat_target::pid_to_str): Change return type.
9488         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
9489         (gnu_nat_target::wait): Update.
9490         (gnu_nat_target::wait): Update.
9491         (gnu_nat_target::resume): Update.
9492         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
9493         (fbsd_nat_target::wait): Update.
9494         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
9495         type.
9496         (darwin_nat_target::attach): Update.
9497         * corelow.c (class core_target) <pid_to_str>: Change return type.
9498         (core_target::pid_to_str): Change return type.
9499         * target.c (normal_pid_to_str): Change return type.
9500         (default_pid_to_str): Likewise.
9501         (target_pid_to_str): Change return type.
9502         (target_translate_tls_address): Update.
9503         (target_announce_detach): Update.
9504         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
9505         return type.
9506         (bsd_uthread_target::pid_to_str): Change return type.
9507         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
9508         type.
9509         (bsd_kvm_target::pid_to_str): Change return type.
9510         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
9511         return type.
9512         (aix_thread_target::pid_to_str): Change return type.
9513         * target.h (struct target_ops) <pid_to_str>: Change return type.
9514         (target_pid_to_str, normal_pid_to_str): Likewise.
9515         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
9516         type.
9517         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
9518         type.
9519         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
9520         return type.
9521         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
9522         type.
9523         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
9524         type.
9525         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
9526         return type.
9527
9528 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
9529
9530         * NEWS: Mention that the new default MI version is 3.  Mention
9531         changes to the output of commands and events that deal with
9532         multi-location breakpoints.
9533         * breakpoint.c: Include "mi/mi-out.h".
9534         (print_one_breakpoint): Change output syntax if using MI version
9535         >= 3.
9536         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
9537         New.
9538         (mi_multi_location_breakpoint_output_fixed): New.
9539         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
9540         (mi_cmd_fix_multi_location_breakpoint_output): New.
9541         (mi_multi_location_breakpoint_output_fixed): New.
9542         * mi/mi-cmds.c (mi_cmds): Register command
9543         -fix-multi-location-breakpoint-output.
9544         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
9545         interpreter "mi".
9546
9547 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
9548
9549         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
9550         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
9551         instantiate mi_ui_out based on interpreter name.
9552         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
9553         * mi/mi-main.c (mi_load_progress): Likewise.
9554
9555 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9556
9557         * NEWS: Combine separate "New targets" sections for 8.3.
9558
9559 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9560
9561         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
9562         (ppcfbsd_init_abi): Install gdbarch
9563         "fetch_tls_load_module_address" and "get_thread_local_address"
9564         methods.
9565
9566 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9567
9568         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
9569         (riscv_fbsd_init_abi): Install gdbarch
9570         "fetch_tls_load_module_address" and "get_thread_local_address"
9571         methods.
9572
9573 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9574
9575         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
9576         (i386fbsd_init_abi): Install gdbarch
9577         "fetch_tls_load_module_address" and "get_thread_local_address"
9578         methods.
9579
9580 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9581
9582         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
9583         (amd64fbsd_init_abi): Install gdbarch
9584         "fetch_tls_load_module_address" and "get_thread_local_address"
9585         methods.
9586
9587 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9588
9589         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
9590         (struct fbsd_pspace_data): New type.
9591         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
9592         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
9593         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
9594         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
9595         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
9596
9597 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9598
9599         * gdbtypes.c (lookup_struct_elt): New function.
9600         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
9601         * gdbtypes.h (struct struct_elt): New type.
9602         (lookup_struct_elt): New prototype.
9603
9604 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9605
9606         * gdbtypes.c (lookup_struct_elt_type): Update comment and
9607         remove disabled code block.
9608
9609 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9610
9611         * gdbarch.sh (get_thread_local_address): New method.
9612         * gdbarch.h, gdbarch.c: Regenerate.
9613         * target.c (target_translate_tls_address): Use
9614         gdbarch_get_thread_local_address if present instead of
9615         target::get_thread_local_address.
9616
9617 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9618
9619         * target.h (target::get_thread_local_address): Update comment.
9620
9621 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9622
9623         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
9624         objfile->separate_debug_objfile_backlink if not NULL.
9625
9626 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9627
9628         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
9629         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
9630         (amd64bsd_store_inferior_registers): Likewise.
9631         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9632         Enable segment base registers.
9633         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
9634         PT_GETFSBASE and PT_GETGSBASE.
9635         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
9636         PT_SETGSBASE.
9637         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
9638         segment base registers.
9639         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9640
9641 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9642
9643         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9644         Update calls to i386_target_description to add 'segments'
9645         parameter.
9646         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
9647         add segment base registers.
9648         * arch/i386.c (i386_create_target_description): Add 'segments'
9649         parameter to enable segment base registers.
9650         * arch/i386.h (i386_create_target_description): Likewise.
9651         * features/i386/32bit-segments.xml: New file.
9652         * features/i386/32bit-segments.c: Generate.
9653         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
9654         call to i386_target_description to add 'segments' parameter.
9655         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9656         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
9657         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
9658         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
9659         if feature is present.
9660         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
9661         Add 'segments' parameter to call to i386_target_description.
9662         (i386_target_description): Add 'segments' parameter to enable
9663         segment base registers.
9664         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
9665         to call to i386_target_description.
9666         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
9667         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
9668         Define I386_NUM_REGS.
9669         (i386_target_description): Add 'segments' parameter to enable
9670         segment base registers.
9671
9672 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
9673
9674         PR/24325
9675         * source-cache.c: #undef open and close, to avoid unresolved
9676         externals during linking.
9677
9678 2019-03-12  Tom Tromey  <tromey@adacore.com>
9679
9680         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
9681         const.  Add initializers.
9682         (_initialize_remote): Don't initialize ptid globals.
9683
9684 2019-03-12  Pedro Alves  <palves@redhat.com>
9685
9686         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
9687
9688 2019-03-12  Pedro Alves  <palves@redhat.com>
9689
9690         * cp-name-parser.y (main): Remove unused 'len' variable.
9691
9692 2019-03-12  Tom Tromey  <tromey@adacore.com>
9693
9694         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
9695         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
9696
9697 2019-03-12  Tom Tromey  <tromey@adacore.com>
9698
9699         * linux-nat.c (iterate_over_lwps): Update.
9700         (stop_callback): Remove parameter.
9701         (stop_wait_callback, detach_callback, resume_set_callback)
9702         (select_singlestep_lwp_callback, set_ignore_sigint)
9703         (status_callback, resumed_callback, resume_clear_callback)
9704         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
9705         data parameter.
9706         (linux_nat_target::detach, linux_nat_target::resume)
9707         (linux_stop_and_wait_all_lwps, select_event_lwp)
9708         (linux_nat_filter_event, linux_nat_wait_1)
9709         (linux_nat_target::kill, linux_nat_target::stop)
9710         (linux_nat_target::stop): Update.
9711         (linux_nat_resume_callback): Change type.
9712         (resume_stopped_resumed_lwps, count_events_callback)
9713         (select_event_lwp_callback): Likewise.
9714         (linux_stop_lwp, linux_nat_stop_lwp): Update.
9715         * arm-linux-nat.c (struct update_registers_data): Remove.
9716         (update_registers_callback): Change type.
9717         (arm_linux_insert_hw_breakpoint1): Update.
9718         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
9719         parameter.
9720         (x86_linux_dr_set_addr): Update.
9721         (x86_linux_dr_set_control): Update.
9722         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
9723         (iterate_over_lwps): Use gdb::function_view.
9724         * nat/aarch64-linux-hw-point.c (struct
9725         aarch64_dr_update_callback_param): Remove.
9726         (debug_reg_change_callback): Change type.
9727         (aarch64_notify_debug_reg_change): Update.
9728         * s390-linux-nat.c (s390_refresh_per_info): Update.
9729
9730 2019-03-11  Tom Tromey  <tromey@adacore.com>
9731
9732         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
9733         redundant assignment to "this_cu".
9734
9735 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9736
9737         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
9738
9739 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9740
9741         * gdbtypes.c (rank_one_type_parm_set): New function extracted
9742         from...
9743         (rank_one_type): ... this.
9744
9745 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9746
9747         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
9748         from...
9749         (rank_one_type): ... this.
9750
9751 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9752
9753         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
9754         from...
9755         (rank_one_type): ... this.
9756
9757 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9758
9759         * gdbtypes.c (rank_one_type_parm_float): New function extracted
9760         from...
9761         (rank_one_type): ... this.
9762
9763 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9764
9765         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
9766         from...
9767         (rank_one_type): ... this.
9768
9769 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9770
9771         * gdbtypes.c (rank_one_type_parm_range): New function extracted
9772         from...
9773         (rank_one_type): ... this.
9774
9775 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9776
9777         * gdbtypes.c (rank_one_type_parm_char): New function extracted
9778         from...
9779         (rank_one_type): ... this.
9780
9781 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9782
9783         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
9784         from...
9785         (rank_one_type): ... this.
9786
9787 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9788
9789         * gdbtypes.c (rank_one_type_parm_int): New function extracted
9790         from...
9791         (rank_one_type): ... this.
9792
9793 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9794
9795         * gdbtypes.c (rank_one_type_parm_func): New function extracted
9796         from...
9797         (rank_one_type): ... this.
9798
9799 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9800
9801         * gdbtypes.c (rank_one_type_parm_array): New function extracted
9802         from...
9803         (rank_one_type): ... this.
9804
9805 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9806
9807         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
9808         from...
9809         (rank_one_type): ... this.
9810
9811 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9812
9813         * inferior.c (initialize_inferiors): Ensure 'help set/show print
9814         inferior-events' shows the example events.
9815
9816 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
9817
9818         Support styling on native MS-Windows console
9819
9820         PR/24315
9821         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
9822         on MS-Windows if $TERM is not defined.
9823
9824         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
9825
9826         * posix-hdep.c (gdb_console_fputs):
9827         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
9828         functions.
9829         * ui-file.h (gdb_console_fputs): Add prototype.
9830
9831         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
9832         back to fputs only if the former returns zero.
9833
9834 2019-03-07  Tom Tromey  <tom@tromey.com>
9835
9836         * symmisc.c (print_symbol_bcache_statistics): Update.
9837         (print_objfile_statistics): Update.
9838         * symfile.c (allocate_symtab): Update.
9839         * stabsread.c: Don't include bcache.h.
9840         * psymtab.h (struct psymbol_bcache): Don't declare.
9841         (class psymtab_storage) <psymbol_cache>: Now a bcache.
9842         (psymbol_bcache_init, psymbol_bcache_free)
9843         (psymbol_bcache_get_bcache): Don't declare.
9844         * psymtab.c (struct psymbol_bcache): Remove.
9845         (psymtab_storage::psymtab_storage): Update.
9846         (psymtab_storage::~psymtab_storage): Update.
9847         (psymbol_bcache_init, psymbol_bcache_free)
9848         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
9849         (add_psymbol_to_bcache): Update.
9850         (allocate_psymtab): Update.
9851         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
9852         macro_cache>: No longer pointers.
9853         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
9854         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
9855         * macrotab.c (macro_bcache): Update.
9856         * macroexp.c: Don't include bcache.h.
9857         * gdbtypes.c (check_types_worklist): Update.
9858         (types_deeply_equal): Remove TRY/CATCH.  Update.
9859         * elfread.c (elf_symtab_read): Update.
9860         * dwarf2read.c: Don't include bcache.h.
9861         * buildsym.c (buildsym_compunit::get_macro_table): Update.
9862         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
9863         (print_bcache_statistics, bcache_memory_used): Don't declare.
9864         (struct bcache): Move from bcache.c.  Add constructor, destructor,
9865         methods.  Rename all data members.
9866         * bcache.c (struct bcache): Move to bcache.h.
9867         (bcache::expand_hash_table): Rename from expand_hash_table.
9868         (bcache): Remove.
9869         (bcache::insert): Rename from bcache_full.
9870         (bcache::compare): Rename from bcache_compare.
9871         (bcache_xmalloc): Remove.
9872         (bcache::~bcache): Rename from bcache_xfree.
9873         (bcache::print_statistics): Rename from print_bcache_statistics.
9874         (bcache::memory_used): Rename from bcache_memory_used.
9875
9876 2019-03-07  Pedro Alves  <palves@redhat.com>
9877
9878         * infrun.c (normal_stop): Also check for
9879         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
9880
9881 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
9882
9883         * f-lang.c (value_from_host_double): Moved to...
9884         * value.c (value_from_host_double): ...here.
9885         * value.h (value_from_host_double): Declare.
9886         * guile/scm-math.c (vlscm_convert_typed_number): Use
9887         value_from_host_double.
9888         (vlscm_convert_number): Likewise.
9889         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
9890         * python/py-value.c (convert_value_from_python): Likewise.
9891
9892 2019-03-06  Tom Tromey  <tom@tromey.com>
9893
9894         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
9895
9896 2019-03-06  Tom Tromey  <tom@tromey.com>
9897
9898         * utils.h (free_current_contents): Don't declare.
9899         * utils.c (free_current_contents): Remove.
9900
9901 2019-03-06  Tom Tromey  <tom@tromey.com>
9902
9903         * top.c (quit_force): Update.
9904         * main.c (captured_command_loop): Update.
9905         * common/new-op.c (operator new): Update.
9906         * common/common-exceptions.c (struct catcher)
9907         <save_cleanup_chain>: Remove member.
9908         (exceptions_state_mc_init): Update.
9909         (exception_try_scope_entry): Return nullptr.
9910         (exception_try_scope_exit, exception_rethrow)
9911         (throw_exception_sjlj, throw_exception_cxx): Update.
9912         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
9913         (all_cleanups, do_cleanups, discard_cleanups)
9914         (discard_final_cleanups, save_cleanups, save_final_cleanups)
9915         (restore_cleanups, restore_final_cleanups): Don't declare.
9916         (do_final_cleanups): Remove parameter.
9917         * common/cleanups.c (cleanup_chain, make_cleanup)
9918         (make_cleanup_dtor, all_cleanups, do_cleanups)
9919         (discard_my_cleanups, discard_cleanups)
9920         (discard_final_cleanups, save_my_cleanups, save_cleanups)
9921         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
9922         (null_cleanup): Remove.
9923         (do_final_cleanups): Remove parameter.
9924
9925 2019-03-06  Tom Tromey  <tom@tromey.com>
9926
9927         * remote.c (remote_target::remote_parse_stop_reply): Use
9928         unique_xmalloc_ptr.
9929
9930 2019-03-06  Tom Tromey  <tom@tromey.com>
9931
9932         * stabsread.c (struct stabs_field_info): Rename from field_info.
9933         <list, fnlist>: Add initializers.
9934         <obstack>: New member.
9935         (read_member_functions, read_struct_fields, read_baseclasses):
9936         Allocate on obstack.  Don't use cleanups.
9937         (read_one_struct_field, read_member_functions, read_struct_fields)
9938         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
9939         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
9940         (read_struct_type): Update.
9941
9942 2019-03-06  Tom Tromey  <tom@tromey.com>
9943
9944         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
9945         * common/filestuff.h (make_cleanup_close): Don't declare.
9946         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
9947         Remove.
9948
9949 2019-03-06  Tom Tromey  <tom@tromey.com>
9950
9951         * solib-aix.c: Use make_scope_exit.
9952
9953 2019-03-06  Tom Tromey  <tom@tromey.com>
9954
9955         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
9956         Use make_scope_exit.
9957
9958 2019-03-06  Tom Tromey  <tom@tromey.com>
9959
9960         * solib-svr4.c (disable_probes_interface): Remove parameter.
9961         (svr4_handle_solib_event): Use make_scope_exit.
9962
9963 2019-03-06  Tom Tromey  <tom@tromey.com>
9964
9965         * remote.c (struct stop_reply_deleter): Remove.
9966         (stop_reply_up): Update.
9967         (struct stop_reply): Derive from notif_event.  Don't typedef.
9968         <regcache>: Now a std::vector.
9969         (stop_reply_xfree): Remove.
9970         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
9971         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
9972         (remote_target::discard_pending_stop_replies): Use delete.
9973         (remote_target::remote_parse_stop_reply): Update.
9974         (remote_target::process_stop_reply): Update.
9975         * remote-notif.h (struct notif_event): Add virtual destructor.
9976         Remove "dtr" member.
9977         (struct notif_client) <alloc_event>: Return a unique_ptr.
9978         (notif_event_xfree): Don't declare.
9979         (notif_event_up): New typedef.
9980         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
9981         (notif_event_xfree, do_notif_event_xfree): Remove.
9982         (remote_notif_state_xfree): Update.
9983
9984 2019-03-06  Tom Tromey  <tom@tromey.com>
9985
9986         * infrun.c (displaced_step_clear_cleanup): Now a
9987         forward_scope_exit type.
9988         (displaced_step_prepare_throw): Update.
9989         (displaced_step_fixup): Update.
9990
9991 2019-03-06  Tom Tromey  <tom@tromey.com>
9992
9993         * inferior.h (class inferior): Update comment.
9994         * gdbthread.h (class thread_info): Update comment.
9995
9996 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
9997             Tom Tromey  <tom@tromey.com>
9998
9999         * stabsread.h (struct stab_section_list): Remove.
10000         (coffstab_build_psymtabs): Update.
10001         * dbxread.c (symbuf_sections): Now a std::vector.
10002         (sect_idx): New global.
10003         (fill_symbuf): Update.
10004         (coffstab_build_psymtabs): Change type of stabsects parameter.
10005         Update.
10006         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
10007         std::vector.
10008         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
10009         (coff_locate_sections): Update.
10010         (coff_symfile_read): Remove cleanups.  Update.
10011         (init_stringtab): Add storage parameter.
10012         (free_stringtab, free_stringtab_cleanup): Remove.
10013         (init_lineno): Add storage parameter.
10014         (free_linetab, free_linetab_cleanup): Remove.
10015
10016 2019-03-06  Pedro Alves  <palves@redhat.com>
10017
10018         * linux-fork.c (fork_info::clobber_regs): Delete.
10019         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
10020         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
10021         comment.  Adjust.
10022         (scoped_switch_fork_info::scoped_switch_fork_info)
10023         (checkpoint_command, linux_fork_context): Adjust
10024         fork_save_infrun_state calls.
10025
10026 2019-03-06  Pedro Alves  <palves@redhat.com>
10027
10028         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
10029         (inf_has_multiple_threads): Return 'bool' and rewrite using
10030         inferior_info::threads().
10031
10032 2019-03-06  Pedro Alves  <palves@redhat.com>
10033
10034         * linux-fork.c: Include <list>.
10035         (fork_list): Now a std::list instance.
10036         (fork_info): Add ctor, dtor, and in-class initialize all fields.
10037         (forks_exist_p, find_last_fork): Adjust.
10038         (new_fork): Delete.
10039         (one_fork_p): New.
10040         (add_fork): Adjust.
10041         (free_fork): Delete, folded into fork_info::~fork_info().
10042         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
10043         Adjust.
10044         (init_fork_list): Delete.
10045         (linux_fork_killall, linux_fork_mourn_inferior)
10046         (linux_fork_detach, info_checkpoints_command): Adjust.
10047         (_initialize_linux_fork): No longer call init_fork_list.
10048
10049 2019-03-06  Pedro Alves  <palves@redhat.com>
10050
10051         * linux-fork.c (new_fork): New, split out of ...
10052         (add_fork): ... this.  Return void.  Move "first fork" special
10053         case from here, to ...
10054         (checkpoint_command): ... here.
10055         * linux-linux.h (add_fork): Return void.
10056
10057 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10058
10059         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
10060
10061 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10062             Chris January  <chris.january@arm.com>
10063             David Lecomber  <david.lecomber@arm.com>
10064
10065         * f-exp.y: New token, UNOP_INTRINSIC.
10066         (exp): New pattern using UNOP_INTRINSIC token.
10067         (f77_keywords): Add 'abs' keyword.
10068         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
10069         (value_from_host_double): New function.
10070         (evaluate_subexp_f): Support UNOP_ABS.
10071
10072 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10073
10074         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
10075         types.
10076
10077 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10078
10079         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
10080         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
10081         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
10082
10083 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10084
10085         * f-exp.y (convert_to_kind_type): Handle more type kinds.
10086
10087 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10088             Chris January  <chris.january@arm.com>
10089
10090         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
10091         * f-exp.y: Define 'KIND' token.
10092         (exp): New pattern for KIND expressions.
10093         (ptype): Handle types with a kind extension.
10094         (direct_abs_decl): Extend to spot kind extensions.
10095         (f77_keywords): Add 'kind' to the list.
10096         (push_kind_type): New function.
10097         (convert_to_kind_type): New function.
10098         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
10099         * parse.c (operator_length_standard): Likewise.
10100         * parser-defs.h (enum type_pieces): Add tp_kind.
10101         * std-operator.def: Add UNOP_KIND.
10102
10103 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10104
10105         * f-exp.y (f_parse): Set yydebug.
10106
10107 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10108
10109         * f-lang.c (evaluate_subexp_f): New function.
10110         (exp_descriptor_f): New global.
10111         (f_language_defn): Use exp_descriptor_f instead of
10112         exp_descriptor_standard.
10113
10114 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10115
10116         * f-exp.y (struct token): Add comments.
10117         (dot_ops): Remove uppercase versions and the end marker.
10118         (f77_keywords): Likewise.
10119         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
10120         entries in the dot_ops array are case insensitive, and use
10121         strncasecmp to compare strings.  Also some whitespace cleanup in
10122         this area.  Similar for the f77_keywords array, except entries in
10123         this list might be case sensitive.
10124
10125 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10126
10127         * f-exp.y (struct f77_boolean_val): Add comments.
10128         (boolean_values): Remove uppercase versions, and end marker.
10129         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
10130         and use strncasecmp to achieve case insensitivity.  Additionally,
10131         perform whitespace cleanup around this code.
10132
10133 2019-03-06  Tom Tromey  <tromey@adacore.com>
10134
10135         * remote-sim.c (gdbsim_target_open): Use result of
10136         gdb_argv::release.
10137
10138 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
10139         Dirk Schubert  <dirk.schubert@arm.com>
10140         Chris January  <chris.january@arm.com>
10141
10142         * eval.c (evaluate_subexp_standard): Call Fortran argument
10143         wrapping logic.
10144         * f-lang.c (struct value): A value which can be passed into a
10145         Fortran function call.
10146         (fortran_argument_convert): Wrap Fortran arguments in a pointer
10147         where appropriate.
10148         (struct type): Value ready for a Fortran function call.
10149         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
10150         is needed.
10151         * f-lang.h (fortran_argument_convert): Declaration.
10152         (fortran_preserve_arg_pointer): Declaration.
10153         * infcall.c (value_arg_coerce): Call Fortran argument logic.
10154
10155 2019-03-05  Tom Tromey  <tromey@adacore.com>
10156
10157         * python/py-prettyprint.c (print_string_repr): Remove #if.
10158         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
10159
10160 2019-03-05  Tom Tromey  <tromey@adacore.com>
10161
10162         * target.c (the_dummy_target): Move later.  Change type to
10163         "dummy_target".
10164         (initialize_targets): Don't initialize the_dummy_target.
10165
10166 2019-03-05  Tom Tromey  <tromey@adacore.com>
10167
10168         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
10169         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
10170
10171 2019-03-05  Tom Tromey  <tromey@adacore.com>
10172
10173         * windows-nat.c (windows_nat_target::attach)
10174         (windows_nat_target::detach): Don't call gdb_flush.
10175         * valprint.c (generic_val_print, val_print, val_print_string):
10176         Don't call gdb_flush.
10177         * utils.c (defaulted_query): Don't call gdb_flush.
10178         * typeprint.c (print_type_scalar): Don't call gdb_flush.
10179         * target.c (target_announce_detach): Don't call gdb_flush.
10180         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
10181         * remote.c (extended_remote_target::attach): Don't call
10182         gdb_flush.
10183         * procfs.c (procfs_target::detach): Don't call gdb_flush.
10184         * printcmd.c (do_examine): Don't call gdb_flush.
10185         (info_display_command): Don't call gdb_flush.
10186         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
10187         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
10188         * memattr.c (info_mem_command): Don't call gdb_flush.
10189         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
10190         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
10191         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
10192         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
10193         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
10194         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
10195         (gnu_nat_target::detach): Don't call gdb_flush.
10196         * f-valprint.c (f_val_print): Don't call gdb_flush.
10197         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
10198         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
10199         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
10200         gdb_flush.
10201         * c-valprint.c (c_val_print): Don't call gdb_flush.
10202         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
10203
10204 2019-03-05  Tom Tromey  <tromey@adacore.com>
10205
10206         * varobj.c (update_dynamic_varobj_children): Update.
10207         (install_default_visualizer): Use reset, not release.
10208         * value.c (set_internalvar): Update.
10209         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
10210         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
10211         ATTRIBUTE_UNUSED_RESULT.
10212
10213 2019-03-05  Tom Tromey  <tromey@adacore.com>
10214
10215         * remote.c (class scoped_remote_fd) <release>: Add
10216         ATTRIBUTE_UNUSED_RESULT.
10217
10218 2019-03-05  Tom Tromey  <tromey@adacore.com>
10219
10220         * macroexp.c (struct macro_buffer) <release>: Add
10221         ATTRIBUTE_UNUSED_RESULT.
10222
10223 2019-03-05  Tom Tromey  <tromey@adacore.com>
10224
10225         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
10226         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
10227         ATTRIBUTE_UNUSED_RESULT.
10228
10229 2019-03-05  Tom Tromey  <tromey@adacore.com>
10230
10231         * common/scoped_fd.h (class scoped_fd) <release>: Add
10232         ATTRIBUTE_UNUSED_RESULT.
10233
10234 2019-03-05  Tom Tromey  <tromey@adacore.com>
10235
10236         * parser-defs.h (struct parser_state) <release>: Add
10237         ATTRIBUTE_UNUSED_RESULT.
10238
10239 2019-03-05  Tom Tromey  <tromey@adacore.com>
10240
10241         * utils.h (class gdb_argv) <release>: Add
10242         ATTRIBUTE_UNUSED_RESULT.
10243         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
10244
10245 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
10246
10247         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
10248         for-loop range, to avoid compiler warnings.
10249
10250         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
10251         avoid compiler warnings about unused variables.
10252
10253         * NEWS: Mention end of support for native debugging on MS-Windows
10254         before XP.
10255
10256         PR gdb/24292
10257         * common/netstuff.c:
10258         * gdbserver/gdbreplay.c
10259         * gdbserver/remote-utils.c:
10260         * ser-tcp.c:
10261         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
10262         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
10263         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
10264         'getaddrinfo' and 'freeaddrinfo' were not available before
10265         Windows XP, and mingw.org's MinGW headers by default define
10266         _WIN32_WINNT to 0x500.
10267
10268 2019-03-01  Gary Benson <gbenson@redhat.com>
10269
10270         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
10271
10272 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
10273             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
10274
10275         PR gdb/8527
10276         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
10277         set_sigint_trap, clear_sigint_trap.
10278
10279 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10280
10281         * target.c (target_detach): Clear the regcache and the
10282         frame cache.
10283
10284 2019-02-27  Pedro Alves  <palves@redhat.com>
10285
10286         * utils.c (set_screen_size): When we cap the height/width sizes,
10287         tweak the corresponding command variable to show "unlimited":
10288
10289 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
10290             Pedro Alves  <palves@redhat.com>
10291
10292         * utils.c (set_screen_size): Reduce "infinite" rows and columns
10293         before calling rl_set_screen_size.
10294
10295 2019-02-27  Tom Tromey  <tromey@adacore.com>
10296
10297         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
10298         define.
10299         * python/py-value.c: Remove Python 2.4 workaround.
10300         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
10301         workaround.
10302         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
10303         Python 2.4 workaround.
10304         * python/python-internal.h: Remove Python 2.4 comment.
10305         (Py_ssize_t): Don't define.
10306         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
10307         (gdb_Py_DECREF): Remove Python 2.4 workaround.
10308         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
10309         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
10310         * python/python.c (do_start_initialization): Remove Python 2.4
10311         workaround.
10312         * python/py-prettyprint.c (class dummy_python_frame): Remove.
10313         (print_children): Remove Python 2.4 workaround.
10314         * python/py-inferior.c (buffer_procs): Remove Python 2.4
10315         workaround.
10316         (CHARBUFFERPROC_NAME): Remove.
10317         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
10318         Python 2.4 workaround.
10319
10320 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10321
10322         * NEWS: Note minimum Python version.
10323
10324 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10325
10326         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
10327         code from these functions.  Remove corresponding ifdefs.  Use
10328         Py_buffer_up instead of explicit calls to PyBuffer_Release.
10329         Remove gotos and target of gotos.
10330         (infpy_search_memory): Likewise.
10331
10332 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10333
10334         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
10335         (hppa_gdbarch_init): Don't register deleted functions with
10336         gdbarch.
10337
10338 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10339
10340         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
10341         (h8300_unwind_sp): Delete.
10342         (h8300_dummy_id): Delete.
10343         (h8300_gdbarch_init): Don't register deleted functions with
10344         gdbarch.
10345
10346 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10347
10348         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
10349         (ft32_unwind_pc): Delete.
10350         (ft32_unwind_sp): Delete.
10351         (ft32_gdbarch_init): Don't register deleted functions with
10352         gdbarch.
10353
10354 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10355
10356         * gdb/frv-tdep.c (frv_dummy_id): Delete.
10357         (frv_unwind_pc): Delete.
10358         (frv_unwind_sp): Delete.
10359         (frv_gdbarch_init): Don't register deleted functions with
10360         gdbarch.
10361
10362 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10363
10364         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
10365         (riscv_unwind_pc): Delete.
10366         (riscv_unwind_sp): Delete.
10367         (riscv_gdbarch_init): Don't register deleted functions with
10368         gdbarch.
10369
10370 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10371
10372         * gdb/csky-tdep.c (csky_dummy_id): Delete.
10373         (csky_unwind_pc): Delete.
10374         (csky_unwind_sp): Delete.
10375         (csky_gdbarch_init): Don't register deleted functions with
10376         gdbarch.
10377
10378 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10379
10380         * gdb/cris-tdep.c (cris_dummy_id): Delete.
10381         (cris_unwind_pc): Delete.
10382         (cris_unwind_sp): Delete.
10383         (cris_gdbarch_init): Don't register deleted functions with
10384         gdbarch.
10385
10386 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10387
10388         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
10389         (bfin_unwind_pc): Delete.
10390         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
10391
10392 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10393
10394         * gdb/arm-tdep.c (arm_dummy_id): Delete.
10395         (arm_unwind_pc): Delete.
10396         (arm_unwind_sp): Delete.
10397         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
10398
10399 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10400
10401         * gdb/arc-tdep.c (arc_dummy_id): Delete.
10402         (arc_unwind_pc): Delete.
10403         (arc_unwind_sp): Delete.
10404         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
10405
10406 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10407
10408         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
10409         (alpha_unwind_pc): Delete.
10410         (alpha_gdbarch_init): Don't register deleted functions with
10411         gdbarch.
10412
10413 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10414
10415         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
10416         (aarch64_unwind_pc): Delete.
10417         (aarch64_unwind_sp): Delete.
10418         (aarch64_gdbarch_init): Don't register deleted functions with
10419         gdbarch.
10420
10421 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10422
10423         * gdbtypes.c (type_align): Don't consider static members when
10424         computing structure alignment.
10425
10426 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10427
10428         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
10429         return 0 for other types.
10430         * arch-utils.c (default_type_align): Always return 0.
10431         * gdbarch.h: Regenerate.
10432         * gdbarch.sh (type_align): Extend comment.
10433         * gdbtypes.c (type_align): Add additional comments, always call
10434         gdbarch_type_align before applying the default rules.
10435         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
10436         generic code will then apply a suitable default.
10437         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
10438         types, return 0 for other types.
10439
10440 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
10441
10442         * NEWS: Create a new section for the next release branch.
10443         Rename the section of the current branch, now that it has
10444         been cut.
10445
10446 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
10447
10448         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
10449         * version.in: Bump version to 8.3.50.DATE-git.
10450
10451 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
10452
10453         * aix-thread.c (ptid_cmp): Remove unused variable.
10454         (get_signaled_thread): Likewise.
10455         (store_regs_user_thread): Likewise.
10456         (store_regs_kernel_thread): Likewise.
10457         (fetch_regs_kernel_thread): Remove shadowed variable.
10458
10459 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10460
10461         * features/riscv/32bit-cpu.xml: Add register numbers.
10462         * features/riscv/32bit-fpu.c: Regenerate.
10463         * features/riscv/32bit-fpu.xml: Add register numbers.
10464         * features/riscv/64bit-cpu.xml: Add register numbers.
10465         * features/riscv/64bit-fpu.c: Regenerate.
10466         * features/riscv/64bit-fpu.xml: Add register numbers.
10467
10468 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
10469
10470         * NEWS: Mention two argument form of gdb.Value constructor.
10471         * python/py-value.c (convert_buffer_and_type_to_value): New
10472         function.
10473         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
10474         Add support for handling an optional second argument.  Call
10475         convert_buffer_and_type_to_value as appropriate.
10476         * python/python-internal.h (Py_buffer_deleter): New struct.
10477         (Py_buffer_up): New typedef.
10478
10479 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
10480
10481         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
10482         instead of releasing ownership.
10483
10484 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
10485
10486         * dwarf2read.c (open_and_init_dwp_file): Call
10487         elf_numsections instead of bfd_count_sections to initialize
10488         dwp_file->num_sections.
10489
10490 2019-02-25  Tom Tromey  <tromey@adacore.com>
10491
10492         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
10493
10494 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
10495
10496         * gcore.in: Add '--readnever' option when invoking GDB.
10497
10498 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
10499
10500         * MAINTAINERS: Update my email address.
10501
10502 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
10503
10504         * build-id.c (build_id_to_debug_bfd_1): New function.
10505         (build_id_to_debug_bfd): Look for separate debug file in
10506         sysroot.
10507
10508 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
10509
10510         * gdbarch.sh: Update the copyright year range that is placed into
10511         generated files.
10512
10513 2019-02-22  Keith Seitz  <keiths@redhat.com>
10514
10515         PR symtab/23853
10516         * linespec.c (create_sals_line_offset): Search for the default
10517         symtab's filename instead of its fullname.
10518
10519 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
10520
10521         * NEWS: Update style defaults.
10522
10523 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
10524
10525         * main.c (captured_main_1): Disable styling in batch mode.
10526
10527 2019-02-20  Tom Tromey  <tom@tromey.com>
10528
10529         * symtab.c (symtab_symbol_info): Fix typos.
10530
10531 2019-02-20  Tom Tromey  <tromey@adacore.com>
10532
10533         * findcmd.c (_initialize_mem_search): Use upper case for
10534         metasyntactic variables.
10535
10536 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
10537
10538         * aarch64-tdep.c (aarch64_add_reggroups): New function.
10539         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
10540
10541 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
10542
10543         * top.h (source_file_name): Change to std::string.
10544         * top.c (source_file_name): Likewise.
10545         (command_line_input): Adjust.
10546         * cli/cli-script.c (script_from_file): Adjust.
10547
10548 2019-02-19  Tom Tromey  <tromey@adacore.com>
10549
10550         * ravenscar-thread.c
10551         (ravenscar_thread_target::update_thread_list): Don't call
10552         ada_build_task_list.
10553         * ada-lang.h (ada_build_task_list): Don't declare.
10554         * ada-tasks.c (struct ada_tasks_inferior_data)
10555         <task_list_valid_p>: Now bool.
10556         (read_known_tasks, ada_task_list_changed)
10557         (ada_tasks_invalidate_inferior_data): Update.
10558         (read_known_tasks_array): Return bool.
10559         (read_known_tasks_list): Likewise.
10560         (read_known_tasks): Return void.
10561         (ada_build_task_list): Now static.
10562
10563 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10564
10565         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
10566         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
10567
10568 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10569
10570         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
10571         variant for ada_tasks_pspace_data_handle and
10572         ada_tasks_inferior_data_handle.
10573         (ada_tasks_pspace_data_cleanup): New function.
10574         (ada_tasks_inferior_data_cleanup): New function.
10575
10576 2019-02-17  Tom Tromey  <tom@tromey.com>
10577
10578         * macrotab.h (macro_source_fullname): Return a std::string.
10579         * macrotab.c (macro_include, check_for_redefinition)
10580         (macro_undef, macro_lookup_definition, foreach_macro)
10581         (foreach_macro_in_scope): Update.
10582         (macro_source_fullname): Return a std::string.
10583         * macrocmd.c (show_pp_source_pos): Update.
10584
10585 2019-02-17  Tom Tromey  <tom@tromey.com>
10586
10587         * macrocmd.c (show_pp_source_pos): Style the file names.
10588
10589 2019-02-17  Tom Tromey  <tom@tromey.com>
10590
10591         PR tui/24197:
10592         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
10593
10594 2019-02-17  Tom Tromey  <tom@tromey.com>
10595
10596         * ada-lang.c (user_select_syms): Use filtered printing.
10597         * utils.c (wrap_style): New global.
10598         (desired_style): Remove.
10599         (emit_style_escape): Add stream parameter.
10600         (set_output_style, reset_terminal_style, prompt_for_continue):
10601         Update.
10602         (flush_wrap_buffer): Only flush gdb_stdout.
10603         (wrap_here): Set wrap_style.
10604         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
10605         treat escape sequences as a character.  Change when wrap buffer is
10606         flushed.
10607         (fputs_styled): Do not set the output style when the default is
10608         requested.
10609         * ui-style.h (struct ui_file_style) <is_default>: New method.
10610         * source.c (print_source_lines_base): Emit escape sequences in one
10611         piece.
10612
10613 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10614
10615         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
10616         integers and enumeration types.
10617
10618 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10619
10620         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
10621         instead of lookup_symbol_in_language
10622         (do_exact_match): New function.
10623         (ada_get_symbol_name_matcher): Return do_exact_match when
10624         doing a verbatim match.
10625
10626 2019-02-15  Tom Tromey  <tromey@adacore.com>
10627
10628         * ravenscar-thread.c (ravenscar_thread_target::resume)
10629         (ravenscar_thread_target::wait): Special case wildcard requests.
10630
10631 2019-02-15  Tom Tromey  <tromey@adacore.com>
10632
10633         * ravenscar-thread.c (base_ptid): Remove.
10634         (struct ravenscar_thread_target) <close>: New method.
10635         <m_base_ptid>: New member.
10636         <update_inferior_ptid, active_task, task_is_currently_active,
10637         runtime_initialized>: Declare methods.
10638         <ravenscar_thread_target>: Add constructor.
10639         (ravenscar_thread_target::task_is_currently_active)
10640         (ravenscar_thread_target::update_inferior_ptid)
10641         (ravenscar_runtime_initialized): Rename.  Now methods.
10642         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
10643         (ravenscar_thread_target::update_thread_list): Update.
10644         (ravenscar_thread_target::active_task): Now method.
10645         (ravenscar_thread_target::store_registers)
10646         (ravenscar_thread_target::prepare_to_store)
10647         (ravenscar_thread_target::prepare_to_store)
10648         (ravenscar_thread_target::mourn_inferior): Update.
10649         (ravenscar_inferior_created): Use "new" to create target.
10650         (ravenscar_thread_target::get_ada_task_ptid): Update.
10651         (_initialize_ravenscar): Don't initialize base_ptid.
10652         (ravenscar_ops): Remove global.
10653
10654 2019-02-15  Tom Tromey  <tromey@adacore.com>
10655
10656         * target.h (push_target): Declare new overload.
10657         * target.c (push_target): New overload, taking an rvalue reference.
10658         * remote.c (remote_target::open_1): Use push_target overload.
10659         * corelow.c (core_target_open): Use push_target overload.
10660
10661 2019-02-15  Tom Tromey  <tromey@adacore.com>
10662
10663         * ravenscar-thread.c (is_ravenscar_task)
10664         (ravenscar_task_is_currently_active): Return bool.
10665         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
10666         (_initialize_ravenscar): Remove "(void)".
10667         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
10668         Return bool.
10669
10670 2019-02-15  Tom Tromey  <tromey@adacore.com>
10671
10672         * ravenscar-thread.c (ravenscar_runtime_initializer)
10673         (has_ravenscar_runtime, get_running_thread_id)
10674         (ravenscar_thread_target::resume): Fix indentation.
10675
10676 2019-02-15  Tom Tromey  <tromey@adacore.com>
10677
10678         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
10679         from ravenscar_arch_ops.
10680         (sparc_ravenscar_ops::fetch_registers)
10681         (sparc_ravenscar_ops::store_registers): Now methods.
10682         (sparc_ravenscar_prepare_to_store): Remove.
10683         (sparc_ravenscar_ops): Redefine.
10684         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
10685         methods and destructor.  Remove members.
10686         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
10687         (ravenscar_thread_target::store_registers)
10688         (ravenscar_thread_target::prepare_to_store): Update.
10689         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
10690         Remove.
10691         (struct ppc_ravenscar_powerpc_ops): Derive from
10692         ravenscar_arch_ops.
10693         (ppc_ravenscar_powerpc_ops::fetch_registers)
10694         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
10695         (ppc_ravenscar_powerpc_ops): Redefine.
10696         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
10697         (ppc_ravenscar_e500_ops::fetch_registers)
10698         (ppc_ravenscar_e500_ops::store_registers): Now methods.
10699         (ppc_ravenscar_e500_ops): Redefine.
10700         * aarch64-ravenscar-thread.c
10701         (aarch64_ravenscar_generic_prepare_to_store): Remove.
10702         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
10703         (aarch64_ravenscar_fetch_registers)
10704         (aarch64_ravenscar_store_registers): Now methods.
10705         (aarch64_ravenscar_ops): Redefine.
10706
10707 2019-02-15  Tom Tromey  <tromey@adacore.com>
10708
10709         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
10710         (ravenscar_thread_target::stopped_by_hw_breakpoint)
10711         (ravenscar_thread_target::stopped_by_watchpoint)
10712         (ravenscar_thread_target::stopped_data_address)
10713         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
10714
10715 2019-02-15  Tom Tromey  <tromey@adacore.com>
10716
10717         * ravenscar-thread.c: Fix some typos.
10718
10719 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10720             Tom Tromey  <tromey@adacore.com>
10721
10722         * ada-lang.c (ada_exception_sal): Change addr_string to a
10723         std::string.
10724         (create_ada_exception_catchpoint): Update.
10725
10726 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10727             Tom Tromey  <tromey@adacore.com>
10728
10729         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
10730         (bp_location_ops): Remove.
10731         (base_breakpoint_allocate_location): Update.
10732         (free_bp_location): Update.
10733         * ada-lang.c (class ada_catchpoint_location)
10734         <ada_catchpoint_location>: Remove ops parameter.
10735         (ada_catchpoint_location_dtor): Remove.
10736         (ada_catchpoint_location_ops): Remove.
10737         (allocate_location_exception): Update.
10738         * breakpoint.h (struct bp_location_ops): Remove.
10739         (class bp_location) <bp_location>: Remove bp_location_ops
10740         parameter.
10741         <~bp_location>: Add destructor.
10742         <ops>: Remove.
10743
10744 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10745             Pedro Alves  <palves@redhat.com>
10746
10747         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
10748         'PATH_MAX'.
10749
10750 2019-02-14  David Michael  <fedora.dm0@gmail.com>
10751             Samuel Thibault  <samuel.thibault@gnu.org>
10752             Thomas Schwinge  <thomas@codesourcery.com>
10753
10754         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
10755         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
10756
10757 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10758
10759         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
10760         (check_empty): Use "const char *".
10761
10762         * gnu-nat.c (gnu_nat_target::detach): Instead of
10763         'detach_inferior (pid)' call
10764         'detach_inferior (find_inferior_pid (pid))'.
10765
10766         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
10767         'nat/fork-inferior.o'.
10768         * gnu-nat.c: #include "nat/fork-inferior.h".
10769
10770         * gnu-nat.c (gnu_nat_target::detach): Instead of
10771         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
10772         * gnu-nat.h: #include "inf-child.h".
10773         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
10774         'i386_gnu_nat_target::fetch_registers'.
10775         (gnu_store_registers): Rename/move to
10776         'i386_gnu_nat_target::store_registers'.
10777
10778         * config/i386/nm-i386gnu.h: Don't "#include" any files.
10779         * gnu-nat.h (mach_thread_info): New function.
10780         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
10781
10782         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
10783
10784 2019-02-14  Frederic Konrad  <konrad@adacore.com>
10785
10786         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
10787
10788 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
10789
10790         * windows-nat.c (windows_add_thread): Add new parameter
10791         "main_thread_p" with default value set to false.  Update
10792         function documentation as well as all callers.
10793         (windows_delete_thread): Likewise.
10794         (fake_create_process): Update call to windows_add_thread.
10795         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
10796         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
10797         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
10798         call to windows_delete_thread.
10799
10800 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
10801
10802         * MAINTAINERS: Add Andrew Burgess as global maintainer.
10803
10804 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10805
10806         * symfile.c (find_separate_debug_file): Use canonical path of
10807         sysroot with child_path instead of gdb_sysroot if it is valid.
10808
10809 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10810
10811         * symfile.c (find_separate_debug_file): Use child_path to
10812         determine if an object file is under a sysroot.
10813
10814 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10815
10816         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
10817         unittests/child-path-selftests.c.
10818         * common/pathstuff.c (child_path): New function.
10819         * common/pathstuff.h (child_path): New prototype.
10820         * unittests/child-path-selftests.c: New file.
10821
10822 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10823
10824         * symfile.c (find_separate_debug_file): Look for separate debug
10825         files in debug directories under the sysroot.
10826
10827 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10828
10829         * symtab.h (struct minimal_symbol data_p): New const method.
10830         (struct minimal_symbol text_p): Likewise.
10831         * symtab.c (output_source_filename): Use file name style
10832         to print file name.
10833         (print_symbol_info): Likewise.
10834         (print_msymbol_info): Use address style to print addresses.
10835         Use function name style to print executable text symbols.
10836         (expand_symtab_containing_pc): Use data_p.
10837         (find_pc_sect_compunit_symtab): Likewise.
10838
10839 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10840
10841         * breakpoint.c (describe_other_breakpoints): Use address style
10842         to print addresses.
10843         (say_where): Likewise.
10844
10845 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10846
10847         * ada-typeprint.c (print_func_type): Print function name
10848         style to print function name.
10849         * c-typeprint.c (c_print_type_1): Likewise.
10850
10851 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
10852
10853         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
10854         for execve.
10855
10856 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10857
10858         * c-exp.y (direct_abs_decl): Use emplace_back to record the
10859         type_stack.
10860
10861 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
10862
10863         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
10864         TYPE_CODE_REF types.
10865
10866 2019-02-08  Jim Wilson  <jimw@sifive.com>
10867
10868         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
10869         (riscv_linux_fregset): New.
10870         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
10871
10872 2019-02-07  Tom Tromey  <tom@tromey.com>
10873
10874         * thread.c (thread_cancel_execution_command): Update.
10875         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
10876         methods.
10877         (struct thread_fsm_ops): Remove.
10878         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
10879         (thread_fsm_should_stop, thread_fsm_return_value)
10880         (thread_fsm_set_finished, thread_fsm_finished_p)
10881         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
10882         Don't declare.
10883         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
10884         * infrun.c (clear_proceed_status_thread)
10885         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
10886         (print_stop_event): Update.
10887         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
10888         Add constructor.
10889         (step_command_fsm_ops): Remove.
10890         (new_step_command_fsm): Remove.
10891         (step_1): Update.
10892         (step_command_fsm::should_stop): Rename from
10893         step_command_fsm_should_stop.
10894         (step_command_fsm::clean_up): Rename from
10895         step_command_fsm_clean_up.
10896         (step_command_fsm::do_async_reply_reason): Rename from
10897         step_command_fsm_async_reply_reason.
10898         (struct until_next_fsm): Inherit from thread_fsm.  Add
10899         constructor.
10900         (until_next_fsm_ops): Remove.
10901         (new_until_next_fsm): Remove.
10902         (until_next_fsm::should_stop): Rename from
10903         until_next_fsm_should_stop.
10904         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
10905         (until_next_fsm::do_async_reply_reason): Rename from
10906         until_next_fsm_async_reply_reason.
10907         (struct finish_command_fsm): Inherit from thread_fsm.  Add
10908         constructor.  Change type of breakpoint.
10909         (finish_command_fsm_ops): Remove.
10910         (new_finish_command_fsm): Remove.
10911         (finish_command_fsm::should_stop): Rename from
10912         finish_command_fsm_should_stop.
10913         (finish_command_fsm::clean_up): Rename from
10914         finish_command_fsm_clean_up.
10915         (finish_command_fsm::return_value): Rename from
10916         finish_command_fsm_return_value.
10917         (finish_command_fsm::do_async_reply_reason): Rename from
10918         finish_command_fsm_async_reply_reason.
10919         (finish_command): Update.
10920         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
10921         Add constructor.
10922         (call_thread_fsm_ops): Remove.
10923         (call_thread_fsm::call_thread_fsm): Rename from
10924         new_call_thread_fsm.
10925         (call_thread_fsm::should_stop): Rename from
10926         call_thread_fsm_should_stop.
10927         (call_thread_fsm::should_notify_stop): Rename from
10928         call_thread_fsm_should_notify_stop.
10929         (run_inferior_call, call_function_by_hand_dummy): Update.
10930         * cli/cli-interp.c (should_print_stop_to_console): Update.
10931         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
10932         Add constructor.  Change type of location_breakpoint,
10933         caller_breakpoint.
10934         (until_break_fsm_ops): Remove.
10935         (new_until_break_fsm): Remove.
10936         (until_break_fsm::should_stop): Rename from
10937         until_break_fsm_should_stop.
10938         (until_break_fsm::clean_up): Rename from
10939         until_break_fsm_clean_up.
10940         (until_break_fsm::do_async_reply_reason): Rename from
10941         until_break_fsm_async_reply_reason.
10942         (until_break_command): Update.
10943         * thread-fsm.c: Remove.
10944         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
10945
10946 2019-02-07  Tom Tromey  <tom@tromey.com>
10947
10948         * yy-remap.h: Add include guard.
10949         * xtensa-tdep.h: Add include guard.
10950         * xcoffread.h: Rename include guard.
10951         * varobj-iter.h: Add include guard.
10952         * tui/tui.h: Rename include guard.
10953         * tui/tui-winsource.h: Rename include guard.
10954         * tui/tui-wingeneral.h: Rename include guard.
10955         * tui/tui-windata.h: Rename include guard.
10956         * tui/tui-win.h: Rename include guard.
10957         * tui/tui-stack.h: Rename include guard.
10958         * tui/tui-source.h: Rename include guard.
10959         * tui/tui-regs.h: Rename include guard.
10960         * tui/tui-out.h: Rename include guard.
10961         * tui/tui-layout.h: Rename include guard.
10962         * tui/tui-io.h: Rename include guard.
10963         * tui/tui-hooks.h: Rename include guard.
10964         * tui/tui-file.h: Rename include guard.
10965         * tui/tui-disasm.h: Rename include guard.
10966         * tui/tui-data.h: Rename include guard.
10967         * tui/tui-command.h: Rename include guard.
10968         * tic6x-tdep.h: Add include guard.
10969         * target/waitstatus.h: Rename include guard.
10970         * target/wait.h: Rename include guard.
10971         * target/target.h: Rename include guard.
10972         * target/resume.h: Rename include guard.
10973         * target-float.h: Rename include guard.
10974         * stabsread.h: Add include guard.
10975         * rs6000-tdep.h: Add include guard.
10976         * riscv-fbsd-tdep.h: Add include guard.
10977         * regformats/regdef.h: Rename include guard.
10978         * record.h: Rename include guard.
10979         * python/python.h: Rename include guard.
10980         * python/python-internal.h: Rename include guard.
10981         * python/py-stopevent.h: Rename include guard.
10982         * python/py-ref.h: Rename include guard.
10983         * python/py-record.h: Rename include guard.
10984         * python/py-record-full.h: Rename include guard.
10985         * python/py-record-btrace.h: Rename include guard.
10986         * python/py-instruction.h: Rename include guard.
10987         * python/py-events.h: Rename include guard.
10988         * python/py-event.h: Rename include guard.
10989         * procfs.h: Add include guard.
10990         * proc-utils.h: Add include guard.
10991         * p-lang.h: Add include guard.
10992         * or1k-tdep.h: Rename include guard.
10993         * observable.h: Rename include guard.
10994         * nto-tdep.h: Rename include guard.
10995         * nat/x86-linux.h: Rename include guard.
10996         * nat/x86-linux-dregs.h: Rename include guard.
10997         * nat/x86-gcc-cpuid.h: Add include guard.
10998         * nat/x86-dregs.h: Rename include guard.
10999         * nat/x86-cpuid.h: Rename include guard.
11000         * nat/ppc-linux.h: Rename include guard.
11001         * nat/mips-linux-watch.h: Rename include guard.
11002         * nat/linux-waitpid.h: Rename include guard.
11003         * nat/linux-ptrace.h: Rename include guard.
11004         * nat/linux-procfs.h: Rename include guard.
11005         * nat/linux-osdata.h: Rename include guard.
11006         * nat/linux-nat.h: Rename include guard.
11007         * nat/linux-namespaces.h: Rename include guard.
11008         * nat/linux-btrace.h: Rename include guard.
11009         * nat/glibc_thread_db.h: Rename include guard.
11010         * nat/gdb_thread_db.h: Rename include guard.
11011         * nat/gdb_ptrace.h: Rename include guard.
11012         * nat/fork-inferior.h: Rename include guard.
11013         * nat/amd64-linux-siginfo.h: Rename include guard.
11014         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
11015         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
11016         * nat/aarch64-linux.h: Rename include guard.
11017         * nat/aarch64-linux-hw-point.h: Rename include guard.
11018         * mn10300-tdep.h: Add include guard.
11019         * mips-linux-tdep.h: Add include guard.
11020         * mi/mi-parse.h: Rename include guard.
11021         * mi/mi-out.h: Rename include guard.
11022         * mi/mi-main.h: Rename include guard.
11023         * mi/mi-interp.h: Rename include guard.
11024         * mi/mi-getopt.h: Rename include guard.
11025         * mi/mi-console.h: Rename include guard.
11026         * mi/mi-common.h: Rename include guard.
11027         * mi/mi-cmds.h: Rename include guard.
11028         * mi/mi-cmd-break.h: Rename include guard.
11029         * m2-lang.h: Add include guard.
11030         * location.h: Rename include guard.
11031         * linux-record.h: Rename include guard.
11032         * linux-nat.h: Add include guard.
11033         * linux-fork.h: Add include guard.
11034         * i386-darwin-tdep.h: Rename include guard.
11035         * hppa-linux-offsets.h: Add include guard.
11036         * guile/guile.h: Rename include guard.
11037         * guile/guile-internal.h: Rename include guard.
11038         * gnu-nat.h: Rename include guard.
11039         * gdb-stabs.h: Rename include guard.
11040         * frv-tdep.h: Add include guard.
11041         * f-lang.h: Add include guard.
11042         * event-loop.h: Add include guard.
11043         * darwin-nat.h: Rename include guard.
11044         * cp-abi.h: Rename include guard.
11045         * config/sparc/nm-sol2.h: Rename include guard.
11046         * config/nm-nto.h: Rename include guard.
11047         * config/nm-linux.h: Add include guard.
11048         * config/i386/nm-i386gnu.h: Rename include guard.
11049         * config/djgpp/nl_types.h: Rename include guard.
11050         * config/djgpp/langinfo.h: Rename include guard.
11051         * compile/gcc-cp-plugin.h: Add include guard.
11052         * compile/gcc-c-plugin.h: Add include guard.
11053         * compile/compile.h: Rename include guard.
11054         * compile/compile-object-run.h: Rename include guard.
11055         * compile/compile-object-load.h: Rename include guard.
11056         * compile/compile-internal.h: Rename include guard.
11057         * compile/compile-cplus.h: Rename include guard.
11058         * compile/compile-c.h: Rename include guard.
11059         * common/xml-utils.h: Rename include guard.
11060         * common/x86-xstate.h: Rename include guard.
11061         * common/version.h: Rename include guard.
11062         * common/vec.h: Rename include guard.
11063         * common/tdesc.h: Rename include guard.
11064         * common/selftest.h: Rename include guard.
11065         * common/scoped_restore.h: Rename include guard.
11066         * common/scoped_mmap.h: Rename include guard.
11067         * common/scoped_fd.h: Rename include guard.
11068         * common/safe-iterator.h: Rename include guard.
11069         * common/run-time-clock.h: Rename include guard.
11070         * common/refcounted-object.h: Rename include guard.
11071         * common/queue.h: Rename include guard.
11072         * common/ptid.h: Rename include guard.
11073         * common/print-utils.h: Rename include guard.
11074         * common/preprocessor.h: Rename include guard.
11075         * common/pathstuff.h: Rename include guard.
11076         * common/observable.h: Rename include guard.
11077         * common/netstuff.h: Rename include guard.
11078         * common/job-control.h: Rename include guard.
11079         * common/host-defs.h: Rename include guard.
11080         * common/gdb_wait.h: Rename include guard.
11081         * common/gdb_vecs.h: Rename include guard.
11082         * common/gdb_unlinker.h: Rename include guard.
11083         * common/gdb_unique_ptr.h: Rename include guard.
11084         * common/gdb_tilde_expand.h: Rename include guard.
11085         * common/gdb_sys_time.h: Rename include guard.
11086         * common/gdb_string_view.h: Rename include guard.
11087         * common/gdb_splay_tree.h: Rename include guard.
11088         * common/gdb_setjmp.h: Rename include guard.
11089         * common/gdb_ref_ptr.h: Rename include guard.
11090         * common/gdb_optional.h: Rename include guard.
11091         * common/gdb_locale.h: Rename include guard.
11092         * common/gdb_assert.h: Rename include guard.
11093         * common/filtered-iterator.h: Rename include guard.
11094         * common/filestuff.h: Rename include guard.
11095         * common/fileio.h: Rename include guard.
11096         * common/environ.h: Rename include guard.
11097         * common/common-utils.h: Rename include guard.
11098         * common/common-types.h: Rename include guard.
11099         * common/common-regcache.h: Rename include guard.
11100         * common/common-inferior.h: Rename include guard.
11101         * common/common-gdbthread.h: Rename include guard.
11102         * common/common-exceptions.h: Rename include guard.
11103         * common/common-defs.h: Rename include guard.
11104         * common/common-debug.h: Rename include guard.
11105         * common/cleanups.h: Rename include guard.
11106         * common/buffer.h: Rename include guard.
11107         * common/btrace-common.h: Rename include guard.
11108         * common/break-common.h: Rename include guard.
11109         * cli/cli-utils.h: Rename include guard.
11110         * cli/cli-style.h: Rename include guard.
11111         * cli/cli-setshow.h: Rename include guard.
11112         * cli/cli-script.h: Rename include guard.
11113         * cli/cli-interp.h: Rename include guard.
11114         * cli/cli-decode.h: Rename include guard.
11115         * cli/cli-cmds.h: Rename include guard.
11116         * charset-list.h: Add include guard.
11117         * buildsym-legacy.h: Rename include guard.
11118         * bfin-tdep.h: Add include guard.
11119         * ax.h: Rename include guard.
11120         * arm-linux-tdep.h: Add include guard.
11121         * arm-fbsd-tdep.h: Add include guard.
11122         * arch/xtensa.h: Rename include guard.
11123         * arch/tic6x.h: Add include guard.
11124         * arch/i386.h: Add include guard.
11125         * arch/arm.h: Rename include guard.
11126         * arch/arm-linux.h: Rename include guard.
11127         * arch/arm-get-next-pcs.h: Rename include guard.
11128         * arch/amd64.h: Add include guard.
11129         * arch/aarch64-insn.h: Rename include guard.
11130         * arch-utils.h: Rename include guard.
11131         * annotate.h: Add include guard.
11132         * amd64-darwin-tdep.h: Rename include guard.
11133         * aarch64-linux-tdep.h: Add include guard.
11134         * aarch64-fbsd-tdep.h: Add include guard.
11135         * aarch32-linux-nat.h: Add include guard.
11136
11137 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11138
11139         * macrotab.c (macro_define_internal): New function that
11140         factorizes macro_define_object_internal and macro_define_function
11141         code.
11142         (macro_define_object_internal): Use macro_define_internal.
11143         (macro_define_function): Likewise.
11144
11145 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11146
11147         * macrocmd.c (extract_identifier): Return
11148         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
11149         callers.
11150
11151 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
11152
11153         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
11154
11155 2019-02-05  Tom Tromey  <tom@tromey.com>
11156
11157         * target.c (target_stack::unpush): Move assertion earlier.
11158
11159 2019-01-30  Tom Tromey  <tom@tromey.com>
11160
11161         PR python/23615:
11162         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
11163         (gdbpy_parse_and_eval): Likewise.
11164         * python/python-internal.h (gdbpy_allow_threads): New class.
11165
11166 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
11167
11168         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
11169         (aarch64_fbsd_fpregmap): Move earlier.
11170         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
11171         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11172         instead of individual calls to trad_frame_set_reg_addr.
11173         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
11174         earlier.
11175         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
11176         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11177         instead of individual calls to trad_frame_set_reg_addr.
11178
11179 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
11180
11181         * CONTRIBUTE: Replace contribution list with wiki link.
11182
11183 2019-01-25  Tom Tromey  <tom@tromey.com>
11184
11185         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
11186
11187 2019-01-25  Tom Tromey  <tom@tromey.com>
11188
11189         * xtensa-linux-nat.c: Fix common/ includes.
11190         * xml-support.h: Fix common/ includes.
11191         * xml-support.c: Fix common/ includes.
11192         * x86-linux-nat.c: Fix common/ includes.
11193         * windows-nat.c: Fix common/ includes.
11194         * varobj.h: Fix common/ includes.
11195         * varobj.c: Fix common/ includes.
11196         * value.c: Fix common/ includes.
11197         * valops.c: Fix common/ includes.
11198         * utils.c: Fix common/ includes.
11199         * unittests/xml-utils-selftests.c: Fix common/ includes.
11200         * unittests/utils-selftests.c: Fix common/ includes.
11201         * unittests/unpack-selftests.c: Fix common/ includes.
11202         * unittests/tracepoint-selftests.c: Fix common/ includes.
11203         * unittests/style-selftests.c: Fix common/ includes.
11204         * unittests/string_view-selftests.c: Fix common/ includes.
11205         * unittests/scoped_restore-selftests.c: Fix common/ includes.
11206         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
11207         * unittests/scoped_fd-selftests.c: Fix common/ includes.
11208         * unittests/rsp-low-selftests.c: Fix common/ includes.
11209         * unittests/parse-connection-spec-selftests.c: Fix common/
11210         includes.
11211         * unittests/optional-selftests.c: Fix common/ includes.
11212         * unittests/offset-type-selftests.c: Fix common/ includes.
11213         * unittests/observable-selftests.c: Fix common/ includes.
11214         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
11215         * unittests/memrange-selftests.c: Fix common/ includes.
11216         * unittests/memory-map-selftests.c: Fix common/ includes.
11217         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
11218         * unittests/function-view-selftests.c: Fix common/ includes.
11219         * unittests/environ-selftests.c: Fix common/ includes.
11220         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
11221         * unittests/common-utils-selftests.c: Fix common/ includes.
11222         * unittests/cli-utils-selftests.c: Fix common/ includes.
11223         * unittests/array-view-selftests.c: Fix common/ includes.
11224         * ui-file.c: Fix common/ includes.
11225         * tui/tui-io.c: Fix common/ includes.
11226         * tracepoint.h: Fix common/ includes.
11227         * tracepoint.c: Fix common/ includes.
11228         * tracefile-tfile.c: Fix common/ includes.
11229         * top.h: Fix common/ includes.
11230         * top.c: Fix common/ includes.
11231         * thread.c: Fix common/ includes.
11232         * target/waitstatus.h: Fix common/ includes.
11233         * target/waitstatus.c: Fix common/ includes.
11234         * target.h: Fix common/ includes.
11235         * target.c: Fix common/ includes.
11236         * target-memory.c: Fix common/ includes.
11237         * target-descriptions.c: Fix common/ includes.
11238         * symtab.h: Fix common/ includes.
11239         * symfile.c: Fix common/ includes.
11240         * stap-probe.c: Fix common/ includes.
11241         * spu-linux-nat.c: Fix common/ includes.
11242         * sparc-nat.c: Fix common/ includes.
11243         * source.c: Fix common/ includes.
11244         * solib.c: Fix common/ includes.
11245         * solib-target.c: Fix common/ includes.
11246         * ser-unix.c: Fix common/ includes.
11247         * ser-tcp.c: Fix common/ includes.
11248         * ser-pipe.c: Fix common/ includes.
11249         * ser-base.c: Fix common/ includes.
11250         * selftest-arch.c: Fix common/ includes.
11251         * s12z-tdep.c: Fix common/ includes.
11252         * rust-exp.y: Fix common/ includes.
11253         * rs6000-aix-tdep.c: Fix common/ includes.
11254         * riscv-tdep.c: Fix common/ includes.
11255         * remote.c: Fix common/ includes.
11256         * remote-notif.h: Fix common/ includes.
11257         * remote-fileio.h: Fix common/ includes.
11258         * remote-fileio.c: Fix common/ includes.
11259         * regcache.h: Fix common/ includes.
11260         * regcache.c: Fix common/ includes.
11261         * record-btrace.c: Fix common/ includes.
11262         * python/python.c: Fix common/ includes.
11263         * python/py-type.c: Fix common/ includes.
11264         * python/py-inferior.c: Fix common/ includes.
11265         * progspace.h: Fix common/ includes.
11266         * producer.c: Fix common/ includes.
11267         * procfs.c: Fix common/ includes.
11268         * proc-api.c: Fix common/ includes.
11269         * printcmd.c: Fix common/ includes.
11270         * ppc-linux-nat.c: Fix common/ includes.
11271         * parser-defs.h: Fix common/ includes.
11272         * osdata.c: Fix common/ includes.
11273         * obsd-nat.c: Fix common/ includes.
11274         * nat/x86-linux.c: Fix common/ includes.
11275         * nat/x86-linux-dregs.c: Fix common/ includes.
11276         * nat/x86-dregs.h: Fix common/ includes.
11277         * nat/x86-dregs.c: Fix common/ includes.
11278         * nat/ppc-linux.c: Fix common/ includes.
11279         * nat/mips-linux-watch.h: Fix common/ includes.
11280         * nat/mips-linux-watch.c: Fix common/ includes.
11281         * nat/linux-waitpid.c: Fix common/ includes.
11282         * nat/linux-ptrace.h: Fix common/ includes.
11283         * nat/linux-ptrace.c: Fix common/ includes.
11284         * nat/linux-procfs.c: Fix common/ includes.
11285         * nat/linux-personality.c: Fix common/ includes.
11286         * nat/linux-osdata.c: Fix common/ includes.
11287         * nat/linux-namespaces.c: Fix common/ includes.
11288         * nat/linux-btrace.h: Fix common/ includes.
11289         * nat/linux-btrace.c: Fix common/ includes.
11290         * nat/fork-inferior.c: Fix common/ includes.
11291         * nat/amd64-linux-siginfo.c: Fix common/ includes.
11292         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
11293         * nat/aarch64-linux.c: Fix common/ includes.
11294         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
11295         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
11296         * namespace.h: Fix common/ includes.
11297         * mips-linux-tdep.c: Fix common/ includes.
11298         * minsyms.c: Fix common/ includes.
11299         * mi/mi-parse.h: Fix common/ includes.
11300         * mi/mi-main.c: Fix common/ includes.
11301         * mi/mi-cmd-env.c: Fix common/ includes.
11302         * memrange.h: Fix common/ includes.
11303         * memattr.c: Fix common/ includes.
11304         * maint.h: Fix common/ includes.
11305         * maint.c: Fix common/ includes.
11306         * main.c: Fix common/ includes.
11307         * machoread.c: Fix common/ includes.
11308         * location.c: Fix common/ includes.
11309         * linux-thread-db.c: Fix common/ includes.
11310         * linux-nat.c: Fix common/ includes.
11311         * linux-fork.c: Fix common/ includes.
11312         * inline-frame.c: Fix common/ includes.
11313         * infrun.c: Fix common/ includes.
11314         * inflow.c: Fix common/ includes.
11315         * inferior.h: Fix common/ includes.
11316         * inferior.c: Fix common/ includes.
11317         * infcmd.c: Fix common/ includes.
11318         * inf-ptrace.c: Fix common/ includes.
11319         * inf-child.c: Fix common/ includes.
11320         * ia64-linux-nat.c: Fix common/ includes.
11321         * i387-tdep.c: Fix common/ includes.
11322         * i386-tdep.c: Fix common/ includes.
11323         * i386-linux-tdep.c: Fix common/ includes.
11324         * i386-linux-nat.c: Fix common/ includes.
11325         * i386-go32-tdep.c: Fix common/ includes.
11326         * i386-fbsd-tdep.c: Fix common/ includes.
11327         * i386-fbsd-nat.c: Fix common/ includes.
11328         * guile/scm-type.c: Fix common/ includes.
11329         * guile/guile.c: Fix common/ includes.
11330         * go32-nat.c: Fix common/ includes.
11331         * gnu-nat.c: Fix common/ includes.
11332         * gdbthread.h: Fix common/ includes.
11333         * gdbarch-selftests.c: Fix common/ includes.
11334         * gdb_usleep.c: Fix common/ includes.
11335         * gdb_select.h: Fix common/ includes.
11336         * gdb_bfd.c: Fix common/ includes.
11337         * gcore.c: Fix common/ includes.
11338         * fork-child.c: Fix common/ includes.
11339         * findvar.c: Fix common/ includes.
11340         * fbsd-nat.c: Fix common/ includes.
11341         * event-top.c: Fix common/ includes.
11342         * event-loop.c: Fix common/ includes.
11343         * dwarf2read.c: Fix common/ includes.
11344         * dwarf2loc.c: Fix common/ includes.
11345         * dwarf2-frame.c: Fix common/ includes.
11346         * dwarf-index-cache.c: Fix common/ includes.
11347         * dtrace-probe.c: Fix common/ includes.
11348         * disasm-selftests.c: Fix common/ includes.
11349         * defs.h: Fix common/ includes.
11350         * csky-tdep.c: Fix common/ includes.
11351         * cp-valprint.c: Fix common/ includes.
11352         * cp-support.h: Fix common/ includes.
11353         * cp-support.c: Fix common/ includes.
11354         * corelow.c: Fix common/ includes.
11355         * completer.h: Fix common/ includes.
11356         * completer.c: Fix common/ includes.
11357         * compile/compile.c: Fix common/ includes.
11358         * compile/compile-loc2c.c: Fix common/ includes.
11359         * compile/compile-cplus-types.c: Fix common/ includes.
11360         * compile/compile-cplus-symbols.c: Fix common/ includes.
11361         * command.h: Fix common/ includes.
11362         * cli/cli-dump.c: Fix common/ includes.
11363         * cli/cli-cmds.c: Fix common/ includes.
11364         * charset.c: Fix common/ includes.
11365         * build-id.c: Fix common/ includes.
11366         * btrace.h: Fix common/ includes.
11367         * btrace.c: Fix common/ includes.
11368         * breakpoint.h: Fix common/ includes.
11369         * breakpoint.c: Fix common/ includes.
11370         * ax.h:
11371         (enum agent_op): Fix common/ includes.
11372         * ax-general.c (struct aop_map): Fix common/ includes.
11373         * ax-gdb.c: Fix common/ includes.
11374         * auxv.c: Fix common/ includes.
11375         * auto-load.c: Fix common/ includes.
11376         * arm-tdep.c: Fix common/ includes.
11377         * arch/riscv.c: Fix common/ includes.
11378         * arch/ppc-linux-common.c: Fix common/ includes.
11379         * arch/i386.c: Fix common/ includes.
11380         * arch/arm.c: Fix common/ includes.
11381         * arch/arm-linux.c: Fix common/ includes.
11382         * arch/arm-get-next-pcs.c: Fix common/ includes.
11383         * arch/amd64.c: Fix common/ includes.
11384         * arch/aarch64.c: Fix common/ includes.
11385         * arch/aarch64-insn.c: Fix common/ includes.
11386         * arch-utils.c: Fix common/ includes.
11387         * amd64-windows-tdep.c: Fix common/ includes.
11388         * amd64-tdep.c: Fix common/ includes.
11389         * amd64-sol2-tdep.c: Fix common/ includes.
11390         * amd64-obsd-tdep.c: Fix common/ includes.
11391         * amd64-nbsd-tdep.c: Fix common/ includes.
11392         * amd64-linux-tdep.c: Fix common/ includes.
11393         * amd64-linux-nat.c: Fix common/ includes.
11394         * amd64-fbsd-tdep.c: Fix common/ includes.
11395         * amd64-fbsd-nat.c: Fix common/ includes.
11396         * amd64-dicos-tdep.c: Fix common/ includes.
11397         * amd64-darwin-tdep.c: Fix common/ includes.
11398         * agent.c: Fix common/ includes.
11399         * ada-lang.h: Fix common/ includes.
11400         * ada-lang.c: Fix common/ includes.
11401         * aarch64-tdep.c: Fix common/ includes.
11402
11403 2019-01-25  Tom Tromey  <tom@tromey.com>
11404
11405         * common/create-version.sh: Use common/version.h.
11406
11407 2019-01-24  Pedro Alves  <palves@redhat.com>
11408
11409         * infrun.c (signal_stop, signal_print, signal_program)
11410         (signal_catch, signal_pass): Now arrays instead of pointers.
11411         (update_signals_program_target, do_target_resume)
11412         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
11413         * linux-nat.c (linux_nat_target::pass_signals)
11414         (linux_nat_target::create_inferior, linux_nat_target::attach):
11415         Adjust.
11416         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
11417         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
11418         * procfs.c (procfs_target::pass_signals): Adjust.
11419         * record-full.c (record_full_target::resume): Adjust.
11420         * remote.c (remote_target::pass_signals)
11421         (remote_target::program_signals): Adjust.
11422         * target-debug.h (target_debug_print_signals): Now takes a
11423         gdb::array_view as parameter.  Adjust.
11424         * target.h (target_ops) <pass_signals, program_signals>: Replace
11425         pointer and length parameters with gdb::array_view.
11426         (target_pass_signals, target_program_signals): Likewise.
11427         * target-delegates.c: Regenerate.
11428
11429 2019-01-24  Pedro Alves  <palves@redhat.com>
11430
11431         * common/forward-scope-exit.h
11432         (forward_scope_exit::forward_scope_exit): Pass arguments to
11433         m_bind_function directly, instead of creating a std::bind and
11434         copying that.
11435
11436 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
11437
11438         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11439         for static members.
11440         (pass_in_v_vfp_candidate): Likewise.
11441
11442 2019-01-23  Tom Tromey  <tom@tromey.com>
11443             Pedro Alves  <palves@redhat.com>
11444
11445         * regcache.c (class regcache_invalidator): Remove.
11446         (regcache::raw_write): Use make_scope_exit.
11447
11448 2019-01-23  Tom Tromey  <tom@tromey.com>
11449
11450         * ui-out.h (class ui_out_emit_type): Update comment.
11451
11452 2019-01-23  Tom Tromey  <tom@tromey.com>
11453
11454         * infrun.c (fetch_inferior_event): Update comment.
11455
11456 2019-01-23  Tom Tromey  <tom@tromey.com>
11457             Pedro Alves  <palves@redhat.com>
11458
11459         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
11460         parameter.
11461         (fetch_inferior_event): Use SCOPE_EXIT.
11462
11463
11464 2019-01-23  Tom Tromey  <tom@tromey.com>
11465             Pedro Alves  <palves@redhat.com>
11466
11467         * infrun.c (disable_thread_events): Delete.
11468         (stop_all_threads): Use SCOPE_EXIT.
11469
11470 2019-01-23  Tom Tromey  <tom@tromey.com>
11471             Pedro Alves  <palves@redhat.com>
11472
11473         * symfile.c: Include forward-scope-exit.h.
11474         (clear_symtab_users_cleanup): Replace forward declaration with
11475         a FORWARD_SCOPE_EXIT.
11476         (syms_from_objfile_1): Use the forward_scope_exit and
11477         gdb::optional instead of cleanup_function.
11478         (reread_symbols): Use the forward_scope_exit instead of
11479         cleanup_function.
11480         (clear_symtab_users_cleanup): Remove function.
11481
11482 2019-01-23  Tom Tromey  <tom@tromey.com>
11483             Pedro Alves  <palves@redhat.com>
11484
11485         * linux-nat.c: Include scope-exit.h.
11486         (cleanup_target_stop): Remove.
11487         (linux_nat_target::static_tracepoint_markers_by_strid): Use
11488         SCOPE_EXIT.
11489
11490 2019-01-23  Tom Tromey  <tom@tromey.com>
11491             Pedro Alves  <palves@redhat.com>
11492
11493         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
11494         (call_function_by_hand_dummy): Use SCOPE_EXIT.
11495
11496 2019-01-23  Tom Tromey  <tom@tromey.com>
11497             Andrew Burgess  <andrew.burgess@embecosm.com>
11498             Pedro Alves  <palves@redhat.com>
11499
11500         * infrun.c (fetch_inferior_event): Use scope_exit.
11501         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
11502         * top.c (execute_command): Use scope_exit.
11503         * breakpoint.c (bpstat_do_actions): Use scope_exit.
11504         * utils.c (do_bpstat_clear_actions_cleanup)
11505         (make_bpstat_clear_actions_cleanup): Remove.
11506
11507 2019-01-23  Tom Tromey  <tom@tromey.com>
11508             Pedro Alves  <palves@redhat.com>
11509
11510         * infrun.c: Include "common/scope-exit.h"
11511         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
11512         (wait_for_inferior): Use SCOPE_EXIT.
11513         (fetch_inferior_event): Use scope_exit.
11514
11515 2019-01-23  Tom Tromey  <tom@tromey.com>
11516             Pedro Alves  <palves@redhat.com>
11517
11518         * breakpoint.c (create_breakpoint): Remove cleanup.
11519
11520 2019-01-23  Tom Tromey  <tom@tromey.com>
11521             Andrew Burgess  <andrew.burgess@embecosm.com>
11522             Pedro Alves  <palves@redhat.com>
11523
11524 2019-01-23  Pedro Alves  <palves@redhat.com>
11525
11526         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
11527
11528 2019-01-23  Pedro Alves  <palves@redhat.com>
11529             Andrew Burgess  <andrew.burgess@embecosm.com>
11530
11531         * gdbthread.h: Include "common/forward-scope-exit.h".
11532         (scoped_finish_thread_state): Redefine custom class in terms of
11533         forward_scope_exit.
11534
11535 2019-01-23  Pedro Alves  <palves@redhat.com>
11536             Andrew Burgess  <andrew.burgess@embecosm.com>
11537
11538         * common/forward-scope-exit.h: New file.
11539
11540 2019-01-23  Pedro Alves  <palves@redhat.com>
11541             Andrew Burgess  <andrew.burgess@embecosm.com>
11542             Tom Tromey  <tom@tromey.com>
11543
11544         * common/scope-exit.h: New file.
11545
11546 2019-01-23  Pedro Alves  <palves@redhat.com>
11547
11548         * common/preprocessor.h (ESC): Rename to ...
11549         (ESC_PARENS): ... this.
11550         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
11551         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
11552
11553 2019-01-23  Tom Tromey  <tom@tromey.com>
11554
11555         * language.h (class scoped_switch_to_sym_language_if_auto):
11556         Initialize m_lang in both cases.
11557
11558 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
11559
11560         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
11561         with XCNEW.
11562
11563 2019-01-22  Tom Tromey  <tom@tromey.com>
11564
11565         * corelow.c: Do not include sys/file.h.
11566
11567 2019-01-22  Tom Tromey  <tom@tromey.com>
11568
11569         * tui/tui-wingeneral.h: Include gdb_curses.h.
11570
11571 2019-01-22  Tom Tromey  <tom@tromey.com>
11572
11573         * source-cache.h (class source_cache) <get_source_lines,
11574         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
11575
11576 2019-01-22  Tom Tromey  <tom@tromey.com>
11577
11578         * remote-fileio.h (struct remote_target): Declare.
11579
11580 2019-01-22  Tom Tromey  <tom@tromey.com>
11581
11582         * python/py-arch.c: Do not include py-ref.h.
11583         * python/py-bpevent.c: Do not include py-ref.h.
11584         * python/py-cmd.c: Do not include py-ref.h.
11585         * python/py-continueevent.c: Do not include py-ref.h.
11586         * python/py-event.h: Do not include py-ref.h.
11587         * python/py-evtregistry.c: Do not include py-ref.h.
11588         * python/py-finishbreakpoint.c: Do not include py-ref.h.
11589         * python/py-frame.c: Do not include py-ref.h.
11590         * python/py-framefilter.c: Do not include py-ref.h.
11591         * python/py-function.c: Do not include py-ref.h.
11592         * python/py-infevents.c: Do not include py-ref.h.
11593         * python/py-linetable.c: Do not include py-ref.h.
11594         * python/py-objfile.c: Do not include py-ref.h.
11595         * python/py-param.c: Do not include py-ref.h.
11596         * python/py-prettyprint.c: Do not include py-ref.h.
11597         * python/py-progspace.c: Do not include py-ref.h.
11598         * python/py-symbol.c: Do not include py-ref.h.
11599         * python/py-symtab.c: Do not include py-ref.h.
11600         * python/py-type.c: Do not include py-ref.h.
11601         * python/py-unwind.c: Do not include py-ref.h.
11602         * python/py-utils.c: Do not include py-ref.h.
11603         * python/py-value.c: Do not include py-ref.h.
11604         * python/py-varobj.c: Do not include py-ref.h.
11605         * python/py-xmethods.c: Do not include py-ref.h.
11606         * python/python.c: Do not include py-ref.h.
11607         * varobj.c: Do not include py-ref.h.
11608
11609 2019-01-22  Tom Tromey  <tom@tromey.com>
11610
11611         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
11612         keyword for bcache.
11613
11614 2019-01-22  Tom Tromey  <tom@tromey.com>
11615
11616         * compile/compile-cplus-types.c: Remove a comment by #include.
11617
11618 2019-01-22  Tom Tromey  <tom@tromey.com>
11619
11620         * compile/gcc-c-plugin.h: Include compile-internal.h.
11621
11622 2019-01-22  Tom Tromey  <tom@tromey.com>
11623
11624         * stabsread.c (EXTERN): Do not define.
11625         (symnum, next_symbol_text_func, processing_gcc_compilation)
11626         (within_function, global_sym_chain, global_stabs)
11627         (previous_stab_code, this_object_header_files)
11628         (n_this_object_header_files)
11629         (n_allocated_this_object_header_files): Define.
11630         * stabsread.h (EXTERN): Never define.  Use "extern".
11631
11632 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11633
11634         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
11635         history_value.
11636
11637 2019-01-21  Tom Tromey  <tom@tromey.com>
11638
11639         * ui-out.c: Fix includes.
11640         * tui/tui-source.c: Fix includes.
11641         * target.c: Fix includes.
11642         * remote.c: Fix includes.
11643         * regcache.c: Fix includes.
11644         * python/py-block.c: Fix includes.
11645         * printcmd.c: Fix includes.
11646         * or1k-tdep.c: Fix includes.
11647         * mi/mi-main.c: Fix includes.
11648         * m32r-tdep.c: Fix includes.
11649         * csky-tdep.c: Fix includes.
11650         * compile/compile-cplus-types.c: Fix includes.
11651         * cli/cli-interp.c: Fix includes.
11652
11653 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
11654
11655         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11656         for padding.
11657
11658 2019-01-16  Tom Tromey  <tom@tromey.com>
11659
11660         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
11661         earlier.
11662         (struct objfile) <msymbols_range>: Move from top level.
11663         <msymbols>: New method.
11664         (class objfile_msymbols): Remove.
11665         * symtab.c (default_collect_symbol_completion_matches_break_on):
11666         Update.
11667         * symmisc.c (dump_msymbols): Update.
11668         * stabsread.c (scan_file_globals): Update.
11669         * objc-lang.c (info_selectors_command, info_classes_command)
11670         (find_methods): Update.
11671         * minsyms.c (find_solib_trampoline_target): Update.
11672         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
11673         * coffread.c (coff_symfile_read): Update.
11674         * ada-lang.c (ada_lookup_simple_minsym)
11675         (ada_collect_symbol_completion_matches): Update.
11676
11677 2019-01-16  Tom Tromey  <tom@tromey.com>
11678
11679         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
11680         type.  Remove no-argument constructor.
11681         <iterator::operator++>: Simplify.
11682         <begin>: Update.
11683         <end>: Use minimal_symbol_count.
11684
11685 2019-01-16  Tom Tromey  <tom@tromey.com>
11686
11687         * objfiles.h (struct objfile) <psymtabs>: New method.
11688         (class objfile_psymtabs): Remove.
11689         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
11690         typedef.
11691         <range>: New method.
11692         (require_partial_symbols): Change return type.
11693         * psymtab.c (require_partial_symbols)
11694         (psym_expand_symtabs_matching): Update.
11695         * mdebugread.c (parse_partial_symbols): Update.
11696         * dbxread.c (dbx_end_psymtab): Update.
11697
11698 2019-01-15  Tom Tromey  <tom@tromey.com>
11699
11700         * symtab.c (lookup_objfile_from_block)
11701         (lookup_symbol_in_objfile_symtabs)
11702         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
11703         (find_line_symtab, info_sources_command)
11704         (default_collect_symbol_completion_matches_break_on)
11705         (make_source_files_completion_list): Update.
11706         * symmisc.c (print_objfile_statistics, dump_objfile)
11707         (maintenance_print_symbols, maintenance_info_symtabs)
11708         (maintenance_check_symtabs, maintenance_info_line_tables):
11709         Update.
11710         * source.c (select_source_symtab)
11711         (forget_cached_source_info_for_objfile): Update.
11712         * objfiles.h (class objfile_compunits): Remove.
11713         (struct objfile) <compunits_range>: New typedef.
11714         (compunits): New method.
11715         * objfiles.c (objfile_relocate1): Update.
11716         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11717         * maint.c (count_symtabs_and_blocks): Update.
11718         * linespec.c (iterate_over_all_matching_symtabs): Update.
11719         * cp-support.c (add_symbol_overload_list_qualified): Update.
11720         * coffread.c (coff_symtab_read): Update.
11721         * ada-lang.c (add_nonlocal_symbols)
11722         (ada_collect_symbol_completion_matches)
11723         (ada_add_global_exceptions): Update.
11724
11725 2019-01-15  Tom Tromey  <tom@tromey.com>
11726
11727         * progspace.h (program_space) <objfiles_safe_range>: New
11728         typedef.
11729         <objfiles_safe>: New method.
11730         * objfiles.h (class all_objfiles_safe): Remove.
11731         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
11732         * jit.c (jit_inferior_exit_hook): Update.
11733
11734 2019-01-17  Tom Tromey  <tom@tromey.com>
11735
11736         * progspace.h (program_space) <objfiles_range>: New typedef.
11737         <objfiles>: New method.
11738         <objfiles_head>: Rename from objfiles.
11739         (object_files): Update.
11740         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
11741         * guile/scm-pretty-print.c
11742         (ppscm_find_pretty_printer_from_objfiles): Update.
11743         * guile/scm-objfile.c (gdbscm_objfiles): Update.
11744         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
11745         Update.
11746         * python/py-progspace.c (pspy_get_objfiles): Update.
11747         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11748         Update.
11749         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11750         (objfpy_lookup_objfile_by_build_id): Update.
11751         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11752         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11753         Update.
11754         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11755         (expand_symtab_containing_pc, lookup_objfile_from_block)
11756         (lookup_static_symbol, basic_lookup_transparent_type)
11757         (find_pc_sect_compunit_symtab, find_symbol_at_address)
11758         (find_line_symtab, info_sources_command)
11759         (default_collect_symbol_completion_matches_break_on)
11760         (make_source_files_completion_list, find_main_name): Update.
11761         * symmisc.c (print_symbol_bcache_statistics)
11762         (print_objfile_statistics, maintenance_print_symbols)
11763         (maintenance_print_msymbols, maintenance_print_objfiles)
11764         (maintenance_info_symtabs, maintenance_check_symtabs)
11765         (maintenance_expand_symtabs, maintenance_info_line_tables):
11766         Update.
11767         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
11768         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
11769         (map_overlay_command, unmap_overlay_command)
11770         (simple_overlay_update, expand_symtabs_matching)
11771         (map_symbol_filenames): Update.
11772         * symfile-debug.c (set_debug_symfile): Update.
11773         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
11774         Update.
11775         * source.c (select_source_symtab, forget_cached_source_info):
11776         Update.
11777         * solib.c (solib_read_symbols): Update.
11778         * solib-spu.c (append_ocl_sos): Update.
11779         * psymtab.c (maintenance_print_psymbols)
11780         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
11781         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
11782         * printcmd.c (info_symbol_command): Update.
11783         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
11784         Update.
11785         * objfiles.h (class all_objfiles): Remove.
11786         * objfiles.c (have_partial_symbols, have_full_symbols)
11787         (have_minimal_symbols, qsort_cmp, update_section_map)
11788         (shared_objfile_contains_address_p)
11789         (default_iterate_over_objfiles_in_search_order): Update.
11790         * objc-lang.c (info_selectors_command, info_classes_command)
11791         (find_methods): Update.
11792         * minsyms.c (find_solib_trampoline_target): Update.
11793         * maint.c (maintenance_info_sections)
11794         (maintenance_translate_address, count_symtabs_and_blocks):
11795         Update.
11796         * main.c (captured_main_1): Update.
11797         * linux-thread-db.c (try_thread_db_load_from_pdir)
11798         (has_libpthread): Update.
11799         * linespec.c (iterate_over_all_matching_symtabs)
11800         (search_minsyms_for_name): Update.
11801         * jit.c (jit_find_objf_with_entry_addr): Update.
11802         * hppa-tdep.c (find_unwind_entry)
11803         (hppa_lookup_stub_minimal_symbol): Update.
11804         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
11805         Update.
11806         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11807         (elf_gnu_ifunc_resolve_by_got): Update.
11808         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
11809         * dwarf-index-write.c (save_gdb_index_command): Update.
11810         * cp-support.c (add_symbol_overload_list_qualified): Update.
11811         * breakpoint.c (create_overlay_event_breakpoint)
11812         (create_longjmp_master_breakpoint)
11813         (create_std_terminate_master_breakpoint)
11814         (create_exception_master_breakpoint): Update.
11815         * blockframe.c (find_pc_partial_function): Update.
11816         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
11817         (ada_collect_symbol_completion_matches)
11818         (ada_add_global_exceptions): Update.
11819
11820 2019-01-17  Tom Tromey  <tom@tromey.com>
11821
11822         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
11823         declare VEC.
11824         (solib_target_parse_libraries): Change return type.
11825         (library_list_start_segment, library_list_start_section)
11826         (library_list_end_library, library_list_start_library); Update.
11827         (solib_target_free_library_list): Remove.
11828         (solib_target_parse_libraries): Remove cleanup.  Change return
11829         type.
11830         (solib_target_current_sos): Update.
11831
11832 2019-01-17  Tom Tromey  <tromey@bapiya>
11833
11834         * valprint.c: Replace "the the" with "the".
11835         * symtab.c: Replace "the the" with "the".
11836         * solib.c: Replace "the the" with "the".
11837         * solib-dsbt.c: Replace "the the" with "the".
11838         * linespec.c: Replace "the the" with "the".
11839         * dwarf2loc.h: Replace "the the" with "the".
11840         * amd64-windows-tdep.c: Replace "the the" with "the".
11841         * aarch64-tdep.c: Replace "the the" with "the".
11842
11843 2019-01-16  Keith Seitz  <keiths@redhat.com>
11844
11845         PR gdb/23773
11846         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
11847         <builder>: Rename to ..
11848         <m_builder>: ... this and make private.
11849         (dwarf2_cu::get_builder): New method.  Change all users of
11850         `builder' to use this method.
11851         (dwarf2_start_symtab): Move to ...
11852         (dwarf2_cu::start_symtab): ... here.  Update all callers
11853         (setup_type_unit_groups): Move to ...
11854         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
11855         callers.
11856         (dwarf2_cu::reset_builder): New method.
11857         (process_full_compunit, process_full_type_unit): Use
11858         dwarf2_cu::reset_builder.
11859         (follow_die_offset): Record the ancestor CU if it is different
11860         from the followed DIE's CU.
11861         (follow_die_sig_1): Likewise.
11862
11863 2019-01-15  Tom Tromey  <tom@tromey.com>
11864
11865         * remote.c (class remote_state) <buf>: Now a char_vector.
11866         <buf_size>: Remove.
11867         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
11868         parameter.
11869         (remote_target::getpkt_or_notif_sane_1)
11870         (remote_target::getpkt_sane)
11871         (remote_target::getpkt_or_notif_sane): Likewise.
11872         (class remote_target) <putpkt>: New overload.
11873         (remote_target::read_frame): Change type of "buf_p".  Remove
11874         sizeof_p parameter.
11875         (packet_ok): New overload.
11876         (packet_check_result): New overload.
11877         Update all uses.
11878
11879 2019-01-14  Tom Tromey  <tom@tromey.com>
11880
11881         * remote-notif.c (handle_notification, remote_notif_ack)
11882         (remote_notif_parse): Make "buf" const.
11883         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
11884         const.
11885         (remote_notif_parse, remote_notif_ack, handle_notification):
11886         Likewise.
11887         * remote.c (remote_notif_stop_parse): Make "buf" const.
11888         (remote_target::remote_parse_stop_reply): Make "buf" const.
11889         (remote_notif_stop_ack): Make "buf" const.
11890
11891 2019-01-14  Tom Tromey  <tom@tromey.com>
11892
11893         * remote.c (remote_console_output): Make parameter const.
11894
11895 2019-01-14  Tom Tromey  <tom@tromey.com>
11896
11897         * target-debug.h (target_debug_print_signals): Constify.
11898         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
11899         * procfs.c (procfs_target::pass_signals): Update.
11900         * linux-nat.c (linux_nat_target::pass_signals): Update.
11901         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
11902         * target-delegates.c: Rebuild.
11903         * remote.c (remote_target::program_signals): Update.
11904         (remote_target::pass_signals): Update.
11905         * target.c (target_pass_signals): Constify argument.
11906         (target_program_signals): Likewise.
11907         * target.h (struct target_ops) <pass_signals, program_signals>:
11908         Constify argument.
11909         (target_pass_signals, target_program_signals): Constify argument.
11910
11911 2019-01-14  Tom Tromey  <tom@tromey.com>
11912
11913         PR tui/28819:
11914         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
11915
11916 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
11917
11918         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
11919         field.
11920         * rs6000-tdep.c: Include reggroups.h.
11921         (IS_V_ALIAS_PSEUDOREG): Define.
11922         (rs6000_register_name): Return names for the "vX" aliases.
11923         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
11924         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
11925         aliases.  Call default_register_reggroup_p for all other
11926         pseudo-registers.
11927         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
11928         New functions.
11929         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
11930         Handle "vX" aliases.
11931         (v_alias_pseudo_register_collect): New function.
11932         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
11933         (rs6000_gdbarch_init): Initialize "vX" aliases as
11934         pseudo-registers.  Restore registration of
11935         rs6000_pseudo_register_reggroup_p with
11936         set_tdesc_pseudo_register_reggroup_p.
11937
11938 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
11939
11940         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
11941         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
11942         set_gdbarch_num_pseudo_regs.
11943
11944 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11945
11946         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
11947         Remove arg prefixname, add do_set and do_show.
11948         Add member functions set_list and show_list.
11949         * cli/cli-style.c (class cli_style_option): Update accordingly.
11950         (style_set_list): Move to file scope.
11951         (style_show_list): Likewise.
11952         (set_style): Call help_list.
11953         (show_style): Call cmd_show_list.
11954         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
11955         Update to use the new macro.
11956
11957 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
11958
11959         * ada-lang.c (_initialize_ada_language): Expand the help text
11960         for the "catch exception" command.
11961
11962 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11963
11964         * symtab.c (matching_obj_sections): Initialize obj,
11965         declare it closer to its usage.
11966
11967 2019-01-10  Tom Tromey  <tom@tromey.com>
11968
11969         * thread-iter.h (inf_threads_iterator): Use next_iterator.
11970         (basic_inf_threads_range): Remove.
11971         (inf_threads_range, inf_non_exited_threads_range)
11972         (safe_inf_threads_range): Use next_adapter.
11973
11974 2019-01-10  Keith Seitz  <keiths@redhat.com>
11975
11976         PR gdb/23712
11977         PR symtab/23010
11978         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
11979         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
11980
11981 2019-01-10  Keith Seitz  <keiths@redhat.com>
11982
11983         PR gdb/23712
11984         PR symtab/23010
11985         * dictionary.c (pending_to_vector): Remove.
11986         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11987         Remove _1 suffix, replacing functions of the same name.  Update
11988         all callers.
11989         (dict_create_hashed, dict_create_hashed_expandable)
11990         (dict_create_linear, dict_create_linear_expandable, dict_free)
11991         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
11992         Make functions static.
11993
11994 2019-01-10  Keith Seitz  <keiths@redhat.com>
11995
11996         PR gdb/23712
11997         PR symtab/23010
11998         * dictionary.h (struct dictionary): Replace declaration with
11999         multidictionary.
12000         (dict_create_hashed, dict_create_hashed_expandable)
12001         (dict_create_linear, dict_create_linear_expandable)
12002         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
12003         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
12004         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
12005         taking multidictionary argument.
12006         [ALL_DICT_SYMBOLS]: Update for multidictionary.
12007         * block.h (struct block) <dict>: Change to multidictionary
12008         and rename `multidict'.
12009         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
12010         symmisc.c: Update all dictionary references to multidictionary.
12011
12012 2019-01-10  Keith Seitz  <keiths@redhat.com>
12013
12014         PR gdb/23712
12015         PR symtab/23010
12016         * dictionary.c: Include unordered_map.
12017         (pending_to_vector): New function.
12018         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12019         Rewrite the non-"_1" functions to take vector instead
12020         of linked list.
12021         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
12022         "new" _1 versions of the same name.
12023         (multidictionary): Define.
12024         (std::hash<enum language): New definition.
12025         (collate_pending_symbols_by_language, mdict_create_hashed)
12026         (mdict_create_hashed_expandable, mdict_create_linear)
12027         (mdict_create_linear_expandable, mdict_free)
12028         (find_language_dictionary, create_new_language_dictionary)
12029         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
12030         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
12031         (mdict_size, mdict_empty): New functions.
12032         * dictionary.h (mdict_iterator): Define.
12033
12034 2019-01-10  Pedro Alves  <palves@redhat.com>
12035
12036         * breakpoint.c (read_uploaded_action)
12037         (create_tracepoint_from_upload): Adjust to use
12038         gdb::unique_xmalloc_ptr.
12039         * ctf.c (ctf_write_uploaded_tp):
12040         (SET_ARRAY_FIELD): Use emplace_back.
12041         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
12042         * tracefile-tfile.c (tfile_write_uploaded_tp):
12043         * tracepoint.c (parse_tracepoint_definition): Adjust to use
12044         gdb::unique_xmalloc_ptr.
12045         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
12046         at_string, cond_string, cmd_strings>: Replace char pointers
12047         with gdb::unique_xmalloc_ptr.
12048
12049 2019-01-10  Pedro Alves  <palves@redhat.com>
12050
12051         * solib-target.c (library_list_start_library): Don't xstrdup name.
12052
12053 2019-01-10  Pedro Alves  <palves@redhat.com>
12054
12055         * mdebugread.c (parse_partial_symbols): Use
12056         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
12057
12058 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12059
12060         * linux-fork.c (scoped_switch_fork_info)
12061         <~scoped_switch_fork_info>: Fix incorrect variable name.
12062
12063 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12064
12065         * linux-fork.c (scoped_switch_fork_info)
12066         <scoped_switch_fork_info>: Make explicit.
12067         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
12068
12069 2019-01-10  Tom Tromey  <tom@tromey.com>
12070
12071         * objfiles.h (objfile::reset_psymtabs): Update.
12072         * objfiles.c (objfile::objfile): Update.
12073         * psymtab.h (psymtab_storage::obstack): Update.
12074         (psymtab_storage::m_obstack): Use gdb::optional.
12075         (class psymtab_storage): Update comment.  Remove objfile
12076         parameter.
12077         * psymtab.c (psymtab_storage::psymtab_storage): Update.
12078
12079 2019-01-10  Tom Tromey  <tom@tromey.com>
12080
12081         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
12082         <free_psymtabs>: Now private.
12083         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
12084         (allocate_psymtab): Use new method.
12085
12086 2019-01-10  Tom Tromey  <tom@tromey.com>
12087
12088         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
12089         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
12090         * mdebugread.c (parse_partial_symbols): Use
12091         allocate_dependencies.
12092         * dwarf2read.c (dwarf2_create_include_psymtab): Use
12093         allocate_dependencies.
12094         (process_psymtab_comp_unit_reader)
12095         (build_type_psymtab_dependencies): Likewise.
12096         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
12097
12098 2019-01-10  Tom Tromey  <tom@tromey.com>
12099
12100         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
12101         PSYMBOL_SET_LANGUAGE.
12102         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
12103
12104 2019-01-10  Tom Tromey  <tom@tromey.com>
12105
12106         * psymtab.h (psymtab_storage::obstack): New method.
12107         <m_obstack>: Rename from obstack; now private.
12108         * psymtab.c (psymtab_storage): Update.
12109         * dwarf2read.c (create_addrmap_from_index)
12110         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
12111         Update.
12112
12113 2019-01-10  Tom Tromey  <tom@tromey.com>
12114
12115         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
12116         * objfiles.h (objfile::reset_psymtabs): New method.
12117
12118 2019-01-10  Tom Tromey  <tom@tromey.com>
12119
12120         * symmisc.c (print_symbol_bcache_statistics): Update.
12121         (print_objfile_statistics): Update.
12122         * symfile.c (reread_symbols): Update.
12123         * psymtab.h (class psymtab_storage): New.
12124         * psymtab.c (psymtab_storage): New constructor.
12125         (~psymtab_storage): New destructor.
12126         (require_partial_symbols): Update.
12127         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
12128         (find_pc_sect_psymtab, find_pc_sect_psymbol)
12129         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
12130         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
12131         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
12132         (start_psymtab_common, end_psymtab_common)
12133         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
12134         (allocate_psymtab): Update.
12135         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
12136         Update.
12137         (dump_psymtab_addrmap, maintenance_print_psymbols)
12138         (maintenance_check_psymtabs): Update.
12139         (class objfile_psymtabs): Move to objfiles.h.
12140         * psympriv.h (discard_psymtab): Now inline.
12141         (psymtab_discarder::psymtab_discarder): Update.
12142         (psymtab_discarder::~psymtab_discarder): Update.
12143         (ALL_OBJFILE_PSYMTABS): Rewrite.
12144         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
12145         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
12146         Remove fields.
12147         <partial_symtabs>: New field.
12148         (class objfile_psymtabs): Move from psymtab.h.  Update.
12149         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
12150         psymbol_cache.
12151         (objfile::~objfile): Don't destroy psymbol_cache.
12152         * mdebugread.c (parse_partial_symbols): Update.
12153         * dwarf2read.c (create_addrmap_from_index)
12154         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
12155         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
12156         (add_partial_subprogram, dwarf2_ranges_read): Update.
12157         * dwarf-index-write.c (write_address_map)
12158         (write_one_signatured_type, recursively_write_psymbols)
12159         (class debug_names, class debug_names, write_psymtabs_to_index):
12160         Update.
12161
12162 2019-01-10  Tom Tromey  <tom@tromey.com>
12163
12164         * symtab.h (SYMBOL_SET_NAMES): Update.
12165         (symbol_set_names): Update.
12166         (MSYMBOL_SET_NAMES): Update.
12167         * symtab.c (symbol_set_names): Change argument to be an
12168         objfile_per_bfd_storage.
12169         * psymtab.c (add_psymbol_to_bcache): Update.
12170         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
12171
12172 2019-01-10  Tom Tromey  <tom@tromey.com>
12173
12174         * symtab.c (create_demangled_names_hash): Change argument to be an
12175         objfile_per_bfd_storage.
12176         (symbol_set_names): Update.
12177
12178 2019-01-10  Tom Tromey  <tom@tromey.com>
12179
12180         * xcoffread.c (xcoff_initial_scan): Unconditionally call
12181         init_psymbol_list.
12182         * psymtab.c (init_psymbol_list): Do nothing if already called.
12183         * psympriv.h (init_psymbol_list): Add comment.
12184         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
12185         init_psymbol_list.
12186         * dbxread.c (dbx_symfile_read): Unconditionally call
12187         init_psymbol_list.
12188
12189 2019-01-10  Tom Tromey  <tom@tromey.com>
12190
12191         * xcoffread.c (scan_xcoff_symtab): Update.
12192         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
12193         "where".
12194         * mdebugread.c (parse_partial_symbols)
12195         (handle_psymbol_enumerators): Update.
12196         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
12197         * dbxread.c (read_dbx_symtab): Update.
12198         * psympriv.h (psymbol_placement): New enum.
12199         (add_psymbol_to_list): Update.
12200
12201 2019-01-10  Tom Tromey  <tom@tromey.com>
12202
12203         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
12204         static_psymbols parameters.
12205         (scan_xcoff_symtab): Update.
12206         * psymtab.c (start_psymtab_common): Remove global_psymbols and
12207         static_psymbols parameters.
12208         * psympriv.h (start_psymtab_common): Update.
12209         * mdebugread.c (parse_partial_symbols): Update.
12210         * dwarf2read.c (create_partial_symtab): Update.
12211         * dbxread.c (read_dbx_symtab): Update.
12212         (start_psymtab): Remove global_psymbols and static_psymbols
12213         parameters.
12214
12215 2019-01-10  Tom Tromey  <tom@tromey.com>
12216
12217         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
12218         * psymtab.c (allocate_psymtab): Add comment.
12219         * psympriv.h (allocate_psymtab): Add comment.
12220         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
12221         initializations.
12222         * dbxread.c (dbx_end_psymtab): Remove some initializations.
12223
12224 2019-01-10  Tom Tromey  <tom@tromey.com>
12225
12226         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12227         Don't declare.
12228         * mipsread.c: Include mdebugread.h.
12229         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12230         Declare.
12231         * elfread.c: Include mdebugread.h.
12232
12233 2019-01-09  Tom Tromey  <tom@tromey.com>
12234
12235         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
12236         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
12237         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
12238         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
12239         (psym_lookup_symbol, psym_find_last_source_symtab)
12240         (psym_forget_cached_source_info, psym_print_stats)
12241         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
12242         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
12243         (psym_map_matching_symbols, psym_expand_symtabs_matching)
12244         (psym_find_compunit_symtab_by_address)
12245         (maintenance_print_psymbols, maintenance_info_psymtabs)
12246         (maintenance_check_psymtabs): Use ranged for.
12247         * psymtab.h (class objfile_psymtabs): New.
12248         (require_partial_symbols): Return objfile_psymtabs.
12249         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
12250
12251 2019-01-09  Tom Tromey  <tom@tromey.com>
12252
12253         * symfile.c (overlay_invalidate_all, find_pc_overlay)
12254         (find_pc_mapped_section, list_overlays_command)
12255         (map_overlay_command, unmap_overlay_command)
12256         (simple_overlay_update): Use all_objfiles.
12257         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
12258         * printcmd.c (info_symbol_command): Use all_objfiles.
12259         * objfiles.h (ALL_OBJSECTIONS): Remove.
12260         * maint.c (maintenance_translate_address): Use all_objfiles.
12261         * gcore.c (gcore_create_callback): Use all_objfiles.
12262         (objfile_find_memory_regions): Likewise.
12263
12264 2019-01-09  Tom Tromey  <tom@tromey.com>
12265
12266         * symtab.c (find_line_symtab, info_sources_command)
12267         (make_source_files_completion_list): Use objfile_compunits.
12268         * source.c (select_source_symtab): Use objfile_compunits.
12269         * objfiles.h (struct objfile): Update comment.
12270         (ALL_OBJFILES): Remove.
12271         (ALL_FILETABS): Remove.
12272         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
12273         objfile_compunits.
12274
12275 2019-01-09  Tom Tromey  <tom@tromey.com>
12276
12277         * symmisc.c (print_objfile_statistics, dump_objfile)
12278         (maintenance_print_symbols): Use compunit_filetabs.
12279         * source.c (forget_cached_source_info_for_objfile): Use
12280         compunit_filetabs.
12281         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
12282         (ALL_FILETABS): Use compunit_filetabs.
12283         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
12284         * coffread.c (coff_symtab_read): Use compunit_filetabs.
12285
12286 2019-01-09  Tom Tromey  <tom@tromey.com>
12287
12288         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
12289         (compunit_filetabs): New.
12290         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
12291         compunit_filetabs.
12292         (info_sources_command, make_source_files_completion_list): Remove
12293         declaration.
12294         * symmisc.c (print_objfile_statistics, dump_objfile)
12295         (maintenance_print_symbols): Remove declaration.
12296         (maintenance_info_symtabs): Use compunit_filetabs.
12297         (maintenance_info_line_tables): Likewise.
12298         * source.c (select_source_symtab): Change local variable name.
12299         (forget_cached_source_info_for_objfile): Remove declaration.
12300         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
12301         * objfiles.c (objfile_relocate1): Remove declaration.
12302         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12303         declaration.
12304         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
12305         * coffread.c (coff_symtab_read): Remove declaration.
12306         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
12307         compunit_filetabs.
12308
12309 2019-01-09  Tom Tromey  <tom@tromey.com>
12310
12311         * symtab.c (lookup_objfile_from_block)
12312         (find_pc_sect_compunit_symtab, search_symbols)
12313         (default_collect_symbol_completion_matches_break_on): Use
12314         objfile_compunits.
12315         * objfiles.h (ALL_COMPUNITS): Remove.
12316         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
12317         * cp-support.c (add_symbol_overload_list_qualified): Use
12318         objfile_compunits.
12319         * ada-lang.c (ada_collect_symbol_completion_matches)
12320         (ada_add_global_exceptions): Use objfile_compunits.
12321
12322 2019-01-09  Tom Tromey  <tom@tromey.com>
12323
12324         * source.c (select_source_symtab)
12325         (forget_cached_source_info_for_objfile): Remove declaration.
12326         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12327         declaration.
12328         * maint.c (count_symtabs_and_blocks): Remove declaration.
12329         * cp-support.c (add_symbol_overload_list_qualified): Remove
12330         declaration.
12331         * coffread.c (coff_symtab_read): Remove declaration.
12332         * symtab.c (lookup_symbol_in_objfile_symtabs)
12333         (basic_lookup_transparent_type_1): Use objfile_compunits.
12334         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
12335         (info_sources_command, search_symbols)
12336         (default_collect_symbol_completion_matches_break_on)
12337         (make_source_files_completion_list): Remove declaration.
12338         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
12339         (ada_collect_symbol_completion_matches)
12340         (ada_add_global_exceptions): Remove declaration.
12341         * linespec.c (iterate_over_all_matching_symtabs): Use
12342         objfile_compunits.
12343         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
12344         (class objfile_compunits): New.
12345         (ALL_COMPUNITS): Use objfile_compunits.
12346         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
12347         (maintenance_check_symtabs, maintenance_info_line_tables): Use
12348         objfile_compunits.
12349         * objfiles.c (objfile_relocate1): Use objfile_compunits.
12350
12351 2019-01-09  Tom Tromey  <tom@tromey.com>
12352
12353         * symtab.c (search_symbols)
12354         (default_collect_symbol_completion_matches_break_on): Use
12355         objfile_msymbols.
12356         * ada-lang.c (ada_lookup_simple_minsym)
12357         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
12358         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
12359         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
12360         objfile_msymbols.
12361         * coffread.c (coff_symfile_read): Use objfile_msymbols.
12362         * symmisc.c (dump_msymbols): Use objfile_msymbols.
12363         * objc-lang.c (find_methods): Use objfile_msymbols.
12364         (info_selectors_command, info_classes_command): Likewise.
12365         * stabsread.c (scan_file_globals): Use objfile_msymbols.
12366         * objfiles.h (class objfile_msymbols): New.
12367         (ALL_OBJFILE_MSYMBOLS): Remove.
12368         (ALL_MSYMBOLS): Remove.
12369
12370 2019-01-09  Tom Tromey  <tom@tromey.com>
12371
12372         * common/next-iterator.h (next_adapter): Add Iterator template
12373         parameter.
12374         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
12375         (class all_objfiles_safe): New.
12376         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
12377         * objfiles.c (put_objfile_before): Update comment.
12378         (add_separate_debug_objfile): Likewise.
12379         (free_all_objfiles): Use all_objfiles_safe.
12380         (objfile_purge_solibs): Likewise.
12381
12382 2019-01-09  Tom Tromey  <tom@tromey.com>
12383
12384         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12385         (expand_symtab_containing_pc, lookup_static_symbol)
12386         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
12387         (find_symbol_at_address, find_line_symtab, find_main_name): Use
12388         all_objfiles.
12389         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
12390         * breakpoint.c (create_overlay_event_breakpoint)
12391         (create_longjmp_master_breakpoint)
12392         (create_std_terminate_master_breakpoint)
12393         (create_exception_master_breakpoint): Use all_objfiles.
12394         * linux-thread-db.c (try_thread_db_load_from_pdir)
12395         (has_libpthread): Use all_objfiles.
12396         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
12397         * linespec.c (iterate_over_all_matching_symtabs)
12398         (search_minsyms_for_name): Use all_objfiles.
12399         * maint.c (maintenance_info_sections): Use all_objfiles.
12400         * main.c (captured_main_1): Use all_objfiles.
12401         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
12402         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
12403         * guile/scm-pretty-print.c
12404         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
12405         * solib-spu.c (append_ocl_sos): Use all_objfiles.
12406         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
12407         (maintenance_print_msymbols): Use all_objfiles.
12408         * source.c (select_source_symtab): Use all_objfiles.
12409         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
12410         * symfile.c (remove_symbol_file_command)
12411         (expand_symtabs_matching, map_symbol_filenames): Use
12412         all_objfiles.
12413         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
12414         all_objfiles.
12415         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
12416         * objc-lang.c (find_methods): Use all_objfiles.
12417         * objfiles.c (have_partial_symbols, have_full_symbols)
12418         (have_minimal_symbols, qsort_cmp)
12419         (default_iterate_over_objfiles_in_search_order): Use
12420         all_objfiles.
12421         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
12422         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
12423         (maintenance_check_psymtabs): Use all_objfiles.
12424         (ALL_PSYMTABS): Remove.
12425         * compile/compile-object-run.c (do_module_cleanup): Use
12426         all_objfiles.
12427         * blockframe.c (find_pc_partial_function): Use all_objfiles.
12428         * cp-support.c (add_symbol_overload_list_qualified): Use
12429         all_objfiles.
12430         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12431         Use all_objfiles.
12432         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
12433         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
12434         all_objfiles.
12435         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12436         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
12437         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12438         Uses all_objfiles.
12439         * solib.c (solib_read_symbols): Use all_objfiles
12440
12441 2019-01-09  Tom Tromey  <tom@tromey.com>
12442
12443         * probe.c (parse_probes_in_pspace): Use all_objfiles.
12444         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
12445         all_objfiles.
12446         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
12447         * symmisc.c (print_symbol_bcache_statistics)
12448         (print_objfile_statistics, maintenance_print_objfiles)
12449         (maintenance_info_symtabs, maintenance_check_symtabs)
12450         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
12451         all_objfiles.
12452         * source.c (forget_cached_source_info): Use all_objfiles.
12453         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
12454         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12455         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
12456         * objfiles.c (update_section_map): Use all_objfiles.
12457         (shared_objfile_contains_address_p): Likewise.
12458         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
12459         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
12460
12461 2019-01-09  Tom Tromey  <tom@tromey.com>
12462
12463         * common/next-iterator.h: New file.
12464         * objfiles.h (class all_objfiles): New.
12465         (struct objfile_iterator): New.
12466
12467 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12468
12469         * NEWS: Move the description of the changed "frame", "select-frame",
12470          and "info frame" commands to the Changed commands section.
12471
12472 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
12473
12474         * gdbtypes.c (check_stub_method_group): Remove handling of old
12475         mangling schemes.
12476         * linespec.c (find_methods): Likewise.
12477         * stabsread.c (read_member_functions): Likewise.
12478         * valops.c (search_struct_method): Likewise.
12479         (value_struct_elt_for_reference): Likewise.
12480         * NEWS: Mention this change.
12481
12482 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
12483
12484         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
12485         print_source_lines.
12486         * source.c (print_source_lines_base): Update line number check.
12487         (print_source_lines): New function.
12488         (source_lines_range::source_lines_range): New function.
12489         * source.h (class source_lines_range): New class.
12490         (print_source_lines): New declaration.
12491
12492 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12493
12494         * linespec.c (linespec_state_destructor): Free self->canonical_names.
12495
12496 2019-01-08  Tom Tromey  <tom@tromey.com>
12497             Simon Marchi  <simon.marchi@ericsson.com>
12498
12499         PR gdb/24060
12500         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
12501         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
12502         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12503         * f-exp.y (DOLLAR_VARIABLE): Likewise.
12504         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
12505         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12506
12507 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12508
12509         * source.c (select_source_symtab): Move header comment to
12510         declaration in source.h.
12511         (forget_cached_source_info_for_objfile): Likewise.
12512         (forget_cached_source_info): Likewise.
12513         (identify_source_line): Likewise.
12514         * source.h (identify_source_line): Move declaration from symtab.h
12515         and add comment from source.c
12516         (print_source_lines): Likewise.
12517         (forget_cached_source_info_for_objfile): Likewise.
12518         (forget_cached_source_info): Likewise.
12519         (select_source_symtab): Likewise.
12520         (enum print_source_lines_flag): Move definition from symtab.h.
12521         * symtab.h (identify_source_line): Move declaration to source.h.
12522         (print_source_lines): Likewise.
12523         (forget_cached_source_info_for_objfile): Likewise.
12524         (forget_cached_source_info): Likewise.
12525         (select_source_symtab): Likewise.
12526         (enum print_source_lines_flag): Move definition to source.h.
12527         * tui/tui-hooks.c: Add 'source.h' include.
12528
12529 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12530
12531         * source.c (print_source_lines_base): Handle requests to print
12532         reverse line number sequences, and guard against empty lines
12533         string.
12534
12535 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12536
12537         * source.c (print_source_lines_base): Fix skip of '\r' if next
12538         character is '\n'.
12539
12540 2019-01-06  Tom Tromey  <tom@tromey.com>
12541
12542         * c-exp.y (struct c_parse_state) <macro_original_text,
12543         expansion_obstack>: New member.
12544         (macro_original_text, expansion_obstack): Remove globals.
12545         (scan_macro_expansion, scanning_macro_expansion)
12546         (finished_macro_expansion): Update.
12547         (scan_macro_cleanup): Remove.
12548         (yylex, c_parse): Update.
12549
12550 2019-01-06  Tom Tromey  <tom@tromey.com>
12551
12552         * c-exp.y (struct c_parse_state) <strings>: New member.
12553         (operator_stoken): Update.
12554
12555 2019-01-06  Tom Tromey  <tom@tromey.com>
12556
12557         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
12558         (union type_stack_elt) <typelist_val>: Now a pointer to
12559         std::vector.
12560         (type_stack_cleanup): Don't declare.
12561         (push_typelist): Update.
12562         * parse.c (pop_typelist): Return a std::vector.
12563         (push_typelist): Take a std::vector.
12564         (follow_types): Update.  Do not free args.
12565         (type_stack_cleanup): Remove.
12566         * c-exp.y (struct c_parse_state): New.
12567         (cpstate): New global.
12568         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
12569         (nonempty_typelist): Update.
12570         (func_mod): Create a new vector.
12571         (c_parse): Create a c_parse_state.
12572         (check_parameter_typelist): Do not delete params.
12573         (function_method): Update.  Do not delete type_list.
12574
12575 2019-01-06  Tom Tromey  <tom@tromey.com>
12576
12577         PR gdb/28155:
12578         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
12579         check_typedef.
12580         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
12581         (print_return_value): Likewise.
12582
12583 2019-01-05  Tom Tromey  <tom@tromey.com>
12584
12585         * contrib/cleanup_check.py: Remove.
12586         * contrib/gcc-with-excheck: Remove.
12587         * contrib/exsummary.py: Remove.
12588         * contrib/excheck.py: Remove.
12589
12590 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
12591
12592         * thread.c (delete_thread_1): Add gdb_assert that THR is not
12593         NULL. Initialize tpprev to NULL instead of assigning it
12594         to NULL on the next statement.
12595         * windows-nat.c (windows_delete_thread): Remove check for
12596         main_thread_id before printing thread exit notifications.
12597         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
12598         Remove thread ID check against main_thread_id.
12599         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
12600         windows_delete_thread.
12601         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
12602
12603 2019-01-04  Tom Tromey  <tom@tromey.com>
12604
12605         * compile/compile.c (_initialize_compile): Use upper case for
12606         metasyntactic variables.
12607         * symmisc.c (_initialize_symmisc): Use upper case for
12608         metasyntactic variables.
12609         * psymtab.c (_initialize_psymtab): Use upper case for
12610         metasyntactic variables.
12611         * demangle.c (demangle_command): Use upper case for metasyntactic
12612         variables.
12613         (_initialize_demangler): Likewise.
12614         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
12615         variables.
12616
12617 2019-01-03  Tom Tromey  <tom@tromey.com>
12618
12619         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
12620
12621 2019-01-03  Tom Tromey  <tom@tromey.com>
12622
12623         * python/py-symtab.c (salpy_str): Update.
12624         (struct salpy_sal_object) <symtab>: Now a PyObject.
12625         (salpy_dealloc): Update.
12626         (del_objfile_sal): Use gdbpy_ref.
12627
12628 2019-01-03  Tom Tromey  <tom@tromey.com>
12629
12630         * python/py-type.c (convert_field): Use new_reference.  Return
12631         gdbpy_ref.
12632         (make_fielditem): Return gdbpy_ref.
12633         (typy_fields): Update.
12634         (typy_getitem): Update.
12635         (field_name): Return gdbpy_ref.  Use new_reference.
12636         (typy_iterator_iternext): Update.
12637
12638 2019-01-03  Tom Tromey  <tom@tromey.com>
12639
12640         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
12641
12642 2019-01-03  Tom Tromey  <tom@tromey.com>
12643
12644         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
12645         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
12646         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
12647         (pspy_set_frame_filters, pspy_set_frame_unwinders)
12648         (pspy_set_type_printers): Likewise.
12649         * python/py-function.c (fnpy_init): Use gdbpy_ref.
12650         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
12651         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
12652         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
12653         (objfpy_set_type_printers): Likewise.
12654
12655 2019-01-03  Tom Tromey  <tom@tromey.com>
12656
12657         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
12658         (gdbpy_print_stack): Use gdbpy_err_fetch.
12659         * python/python-internal.h (class gdbpy_err_fetch): New class.
12660         (class gdbpy_enter) <m_error_type, m_error_value,
12661         m_error_traceback>: Remove.
12662         <m_error>: New member.
12663         (gdbpy_exception_to_string): Don't declare.
12664         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
12665         * python/py-value.c (convert_value_from_python): Use
12666         gdbpy_err_fetch.
12667         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
12668         gdbpy_exception_to_string.
12669         (gdbpy_handle_exception): Use gdbpy_err_fetch.
12670         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
12671         gdbpy_err_fetch.
12672
12673 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12674
12675         * linux-nat.c (delete_lwp_cleanup): Delete.
12676         (struct lwp_deleter): New struct.
12677         (lwp_info_up): New typedef.
12678         (linux_nat_target::follow_fork): Delete cleanup, and make use of
12679         lwp_info_up.
12680
12681 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12682
12683         * linux-fork.c (class scoped_switch_fork_info): New class.
12684         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
12685
12686 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12687
12688         * valops.c (find_overload_match): Remove use of null_cleanup, and
12689         calls to do_cleanups.
12690
12691 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12692
12693         * compile/compile-cplus-types.c
12694         (compile_cplus_instance::decl_name): Handle changes to
12695         cp_func_name.
12696         * cp-support.c (cp_func_name): Update header comment, update
12697         return type.
12698         * cp-support.h (cp_func_name): Update return type in declaration.
12699         * valops.c (find_overload_match): Move temp_func local to top
12700         level of function and change its type.  Use temp_func to hold and
12701         delete temporary string obtained from cp_func_name.
12702
12703 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12704
12705         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
12706         gdb::char_vector, remove cleanup, and update uses of `msg`.
12707
12708 2019-01-03  Jim Wilson  <jimw@sifive.com>
12709
12710         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
12711
12712 2019-01-02  Tom Tromey  <tom@tromey.com>
12713
12714         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
12715         (tdesc_parse_xml): Remove cleanups.
12716         * target-descriptions.h (make_cleanup_free_target_description):
12717         Don't declare.
12718         (target_desc_deleter): New struct.
12719         (target_desc_up): New typedef.
12720         * target-descriptions.c (target_desc_deleter::operator()): Rename
12721         from free_target_description.
12722         (make_cleanup_free_target_description): Remove.
12723
12724 2019-01-02  Tom Tromey  <tom@tromey.com>
12725
12726         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
12727         constructor, destructor.
12728         (linespec_parser): Remove typedef.
12729         (~linespec_parser): Rename from linespec_parser_delete.
12730         (linespec_lex_to_end, linespec_complete_label)
12731         (linespec_complete): Update.
12732         (decode_line_full): Remove cleanups.
12733         (decode_line_1): Update.
12734
12735 2019-01-02  Tom Tromey  <tom@tromey.com>
12736
12737         * python/python-internal.h (inferior_to_inferior_object): Change
12738         return type.
12739         * python/py-exitedevent.c (create_exited_event_object): Update.
12740         * python/py-inferior.c (inferior_to_inferior_object): Return
12741         gdbpy_ref.
12742         (python_new_inferior, python_inferior_deleted)
12743         (thread_to_thread_object, delete_thread_object)
12744         (build_inferior_list, gdbpy_selected_inferior): Update.
12745         * python/py-infthread.c (create_thread_object): Update.  Also fail
12746         if inferior_to_inferior_object fails.
12747
12748 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
12749
12750         * inferior.h (class inferior) <displaced_step_state>: New field.
12751         * infrun.h (struct displaced_step_state): Move here from
12752         infrun.c.  Initialize fields, add constructor.
12753         <inf>: Remove field.
12754         <reset>: New method.
12755         * infrun.c (struct displaced_step_inferior_state): Move to
12756         infrun.h.
12757         (displaced_step_inferior_states): Remove.
12758         (get_displaced_stepping_state): Adust.
12759         (displaced_step_in_progress_any_inferior): Adjust.
12760         (displaced_step_in_progress_thread): Adjust.
12761         (displaced_step_in_progress): Adjust.
12762         (add_displaced_stepping_state): Remove.
12763         (get_displaced_step_closure_by_addr): Adjust.
12764         (remove_displaced_stepping_state): Remove.
12765         (infrun_inferior_exit): Call displaced_step_state.reset.
12766         (use_displaced_stepping): Don't check for NULL.
12767         (displaced_step_prepare_throw): Call
12768         get_displaced_stepping_state.
12769         (displaced_step_fixup): Don't check for NULL.
12770         (prepare_for_detach): Don't check for NULL.
12771
12772 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12773
12774         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
12775          in case of call that did not complete.
12776
12777 2019-01-02  Andrey Utkin  <autkin@undo.io>
12778
12779         * symfile.c (find_separate_debug_file): Fix search of debug files for
12780         remote debuggee.
12781
12782 2019-01-02  Tom Tromey  <tom@tromey.com>
12783
12784         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
12785         indentation.
12786         * python/py-frame.c (frapy_older): Remove cast.
12787         (frapy_newer): Likewise.
12788         * python/py-breakpoint.c (local_setattro): Remove cast.
12789         * python/py-arch.c (archpy_name): Remove local variable.
12790         * python/py-type.c (gdbpy_lookup_type): Remove cast.
12791
12792 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
12793
12794         * unittests/basic_string_view/element_access/char/empty.cc:
12795         Fix year range in copyright header.
12796
12797 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12798
12799         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
12800         Delete.
12801         <operator==>: Update with for removed field.
12802         <hash>: Likewise.
12803         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
12804         <isa_features>: ...this.
12805         <abi_features>: New field.
12806         (riscv_isa_flen): Update comment.
12807         (riscv_abi_xlen): New declaration.
12808         (riscv_abi_flen): New declaration.
12809         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
12810         isa_features.
12811         (riscv_abi_xlen): New function.
12812         (riscv_isa_flen): Update to get answer from isa_features.
12813         (riscv_abi_flen): New function.
12814         (riscv_has_fp_abi): Update to get answer from abi_features.
12815         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
12816         xlen and flen.
12817         (riscv_call_info) <xlen, flen>: Update comment.
12818         (riscv_call_arg_struct): Remove invalid assertions
12819         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
12820         is removed.
12821         (riscv_gdbarch_init): Gather isa features and abi features
12822         separately, ensure both match on the gdbarch when reusing an old
12823         gdbarch.  Relax an error check to allow 32-bit abi float to run on
12824         a target with 64-bit float hardware.
12825
12826 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12827
12828         * source.c (search_command_helper): Stop reverse search
12829         when line 1 has been searched.
12830
12831 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12832
12833         * record-full.c (record_full_base_target::close): Rewrite
12834         record_full_core_buf_list free logic.
12835
12836 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12837
12838         * break-catch-syscall.c (print_one_catch_syscall): xfree
12839         the last text.
12840
12841 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12842
12843         * top.c (print_gdb_version): Update Copyright year in version
12844         message.
12845
12846 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12847
12848         Update copyright year range in all GDB files.
12849
12850 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
12851
12852         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
12853
12854 For older changes see ChangeLog-2018.
12855 \f
12856 Local Variables:
12857 mode: change-log
12858 left-margin: 8
12859 fill-column: 74
12860 version-control: never
12861 coding: utf-8
12862 End:
12863