gdb/ChangeLog

   1 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
   2
   3         * cli/cli-utils.c (info_print_command_completer): New function.
   4         * cli/cli-utils.h: Add 'completer.h' include, and forward
   5         declaration for 'struct cmd_list_element'.
   6         (info_print_command_completer): Declare.
   7         * stack.c (_initialize_stack): Add completer for 'info locals' and
   8         'info args'.
   9         * symtab.c (_initialize_symtab): Add completer for 'info
  10         variables' and 'info functions'.
  11         * NEWS: Mention completion for additional info commands.
  12
  13 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
  14
  15         * cli/cli-utils.c (extract_info_print_args): Delete.
  16         (extract_arg_maybe_quoted): Delete.
  17         (info_print_options_defs): New variable.
  18         (make_info_print_options_def_group): New function.
  19         (extract_info_print_options): Define new function.
  20         * cli/cli-utils.h (extract_info_print_args): Delete.
  21         (struct info_print_options): New structure.
  22         (extract_info_print_options): Declare new function.
  23         * stack.c (info_locals_command): Update to use new
  24         extract_info_print_options, also add a header comment.
  25         (info_args_command): Likewise.
  26         * symtab.c (info_variables_command): Likewise.
  27         (info_functions_command): Likewise.
  28
  29 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
  30
  31         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
  32         to extract string arguments.
  33         * common/common-utils.c (extract_string_maybe_quoted): New function.
  34         * common/common-utils.h (extract_string_maybe_quoted): Declare.
  35
  36 2019-07-11  Tom Tromey  <tromey@adacore.com>
  37
  38         * main.c (get_init_files): Use GDBINIT, not gdbinit.
  39         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
  40         * top.h (gdbinit): Don't declare.
  41         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
  42         into...
  43         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
  44         * top.c (gdb_init): Don't call init_cli_cmds.
  45         (gdbinit): Remove.
  46         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
  47
  48 2019-07-11  Tom Tromey  <tromey@adacore.com>
  49
  50         * python/py-inferior.c (add_thread_object): Don't use thread_obj
  51         after it has been moved.
  52
  53 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
  54
  55         * valops.c (value_must_coerce_to_target): Change return type to
  56         bool.
  57         * value.h (value_must_coerce_to_target): Likewise.
  58
  59 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
  60
  61         * breakpoint.c (is_hardware_watchpoint): Remove
  62         forward-declaration.
  63         (is_masked_watchpoint): Change return type to bool.
  64         (is_tracepoint): Likewise.
  65         (is_breakpoint): Likewise.
  66         (is_hardware_watchpoint): Likewise.
  67         (is_watchpoint): Likewise.
  68         (is_no_memory_software_watchpoint): Likewise.
  69         (is_catchpoint): Likewise.
  70         (breakpoint_1): Make FILTER parameter's return type bool.
  71         is_masked_watchpoint): Change return type to bool.
  72         (save_breakpoints): Make FILTER parameter's return type bool.
  73         * breakpoint.h (is_breakpoint): Change return type to bool.
  74         (is_watchpoint): Likewise.
  75         (is_catchpoint): Likewise.
  76         (is_tracepoint): Likewise.
  77
  78 2019-07-10  Tom Tromey  <tom@tromey.com>
  79
  80         * defs.h: Don't include gdbarch.h.
  81         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
  82         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
  83         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
  84         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
  85         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
  86         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
  87         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
  88         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
  89         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
  90         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
  91         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
  92         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
  93         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
  94         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
  95         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
  96         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
  97         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
  98         record-btrace.c, record.h, regcache-dump.c, regcache.h,
  99         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 100         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 101         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 102         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 103         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 104         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 105         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 106         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 107         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 108
 109 2019-07-10  Tom Tromey  <tromey@adacore.com>
 110
 111         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 112         * breakpoint.c (init_ada_exception_breakpoint): Register as
 113         bp_catchpoint.
 114         (print_one_breakpoint_location, print_one_breakpoint): Use
 115         is_ada_exception_catchpoint.
 116         * ada-lang.c (class ada_catchpoint_location): Pass
 117         bp_loc_software_breakpoint to bp_location constructor.
 118         (is_ada_exception_catchpoint): New function.
 119
 120 2019-07-10  Tom Tromey  <tromey@adacore.com>
 121
 122         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 123         VEC.
 124         (struct arm_exidx_entry): New method operator<.
 125         (struct arm_exidx_data) <section_maps>: Change type.
 126         (arm_exidx_data_free): Remove.
 127         (arm_exidx_data_key): Change type.  Move lower.
 128         (arm_exidx_new_objfile): Update.
 129         (arm_compare_exidx_entries): Remove.
 130         (arm_find_exidx_entry, _initialize_arm_tdep)
 131
 132 2019-07-10  Tom Tromey  <tromey@adacore.com>
 133
 134         * solib-spu.c (ocl_program_data_key): Change type.
 135         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 136         Update.
 137
 138 2019-07-10  Tom Tromey  <tromey@adacore.com>
 139
 140         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 141         (struct solib_aix_inferior_data) <library_list>: Change type.
 142         (solib_aix_inferior_data_handle): Change type.
 143         (get_solib_aix_inferior_data): Update.
 144         (solib_aix_free_library_list): Remove.
 145         (library_list_start_library): Update.
 146         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 147         return type.
 148         (solib_aix_get_library_list)
 149         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 150         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 151
 152 2019-07-10  Tom Tromey  <tromey@adacore.com>
 153
 154         * solib-dsbt.c (struct dsbt_info): Add initializers.
 155         (solib_dsbt_pspace_data): Change type.
 156         (dsbt_pspace_data_cleanup): Remove.
 157         (get_dsbt_info, _initialize_dsbt_solib): Update.
 158
 159 2019-07-10  Tom Tromey  <tromey@adacore.com>
 160
 161         * spu-tdep.c (spu_overlay_data): Change type.
 162         (spu_get_overlay_table, spu_overlay_new_objfile)
 163         (_initialize_spu_tdep): Update.
 164
 165 2019-07-10  Tom Tromey  <tromey@adacore.com>
 166
 167         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 168         destructor.
 169         (dbx_objfile_data_key): Change type and declare later.
 170         (DBX_SYMFILE_INFO): Rewrite.
 171         * dbxread.c (dbx_objfile_data_key): Change type.
 172         (dbx_symfile_init): Update.
 173         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 174         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 175         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 176
 177 2019-07-10  Tom Tromey  <tromey@adacore.com>
 178
 179         * jit.c (jit_program_space_key): Change type.  Move lower.
 180         (get_jit_program_space_data): Update.
 181         (jit_program_space_data_cleanup): Remove.
 182         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 183         Update.
 184         (struct jit_program_space_data): Add initializers.
 185
 186 2019-07-10  Tom Tromey  <tromey@adacore.com>
 187
 188         * solib-darwin.c (struct darwin_info): Add initializers.
 189         (solib_darwin_pspace_data): Change type.
 190         (darwin_pspace_data_cleanup): Remove.
 191         (get_darwin_info, _initialize_darwin_solib): Update.
 192
 193 2019-07-10  Tom Tromey  <tromey@adacore.com>
 194
 195         * remote-sim.c (struct sim_inferior_data): Add initializers,
 196         constructor, and destructor.
 197         (sim_inferior_data_key): Change type.  Move lower.
 198         (check_for_duplicate_sim_descriptor): Update.
 199         (get_sim_inferior_data): Use new.  Update.
 200         (~sim_inferior_data_cleanup): Rename from
 201         sim_inferior_data_cleanup.  Simplify.
 202         (gdbsim_close_inferior, simulator_command)
 203         (sim_command_completer, _initialize_remote_sim): Update.
 204         (next_pid, INITIAL_PID): Move earlier.
 205
 206 2019-07-10  Tom Tromey  <tromey@adacore.com>
 207
 208         * python/python-internal.h (create_thread_object): Return
 209         gdbpy_ref.
 210         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 211         * python/py-inferior.c (struct threadlist_entry): Add
 212         constructor.
 213         <thread_obj>: Now a gdbpy_ref.
 214         (thread_to_thread_object): Update.
 215         (add_thread_object): Use new.
 216         (delete_thread_object): Use delete.
 217         (infpy_threads): Update.
 218         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 219         GIL.
 220
 221 2019-07-10  Tom Tromey  <tromey@adacore.com>
 222
 223         * valops.c (value_cast): Specialize error message for Ada.
 224
 225 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 226
 227         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 228
 229 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 230
 231         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 232         bpstat_should_step): Return bool, adjust comments.
 233         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 234         bpstat_should_step): Likewise.
 235
 236 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 237
 238         * features/Makefile: Use feature target descriptions for Arm.
 239         * features/arm/arm-core.c: Generate new file.
 240         * features/arm/arm-fpa.c: Likewise.
 241         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 242         * features/arm/arm-m-profile.c: Likewise.
 243         * features/arm/arm-vfpv2.c: Likewise.
 244         * features/arm/arm-vfpv3.c: Likewise.
 245         * features/arm/xscale-iwmmxt.c: Likewise.
 246         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 247
 248 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 249
 250         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 251         ptrace earlier.
 252
 253 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 254
 255         * features/aarch64-pauth.c: Regenerate.
 256
 257 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 258
 259         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 260         bool.
 261         (bpstat_what): Use false instead of 0.
 262
 263 2019-07-09  Pedro Alves  <palves@redhat.com>
 264
 265         * break-catch-throw.c (is_exception_catchpoint): New.
 266         * breakpoint.c (print_one_breakpoint_location): New parameter
 267         'raw_loc'.  Handle it.  Use
 268         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 269         looking at the breakpoint's type.
 270         (print_one_breakpoint): If handling "maint info breakpoints", also
 271         print locations of exception catchpoints.
 272         * breakpoint.h (is_exception_catchpoint): Declare.
 273
 274 2019-07-09  Pedro Alves  <palves@redhat.com>
 275
 276         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 277         "addr" field.
 278         (allocate_location_exception_catchpoint): New.
 279         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 280         (initialize_throw_catchpoint_ops): Install
 281         allocate_location_exception_catchpoint as allocate_location
 282         method.
 283         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 284         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 285         bp_loc_other.
 286         (breakpoint_address_is_meaningful): Delete.
 287         (bl_address_is_meaningful): New.
 288         (breakpoint_locations_match): Adjust comment.
 289         (bp_location_from_bp_type): New, factored out of...
 290         (bp_location::bp_location(breakpoint *)): ... this.
 291         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 292         factored out of...
 293         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 294         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 295         breakpoint_address_is_meaningful.
 296         (bp_locations_compare): Adjust comment.
 297         (update_global_location_list): Use bl_address_is_meaningful
 298         instead of breakpoint_address_is_meaningful.
 299         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 300         explicit.
 301         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 302         * python/py-breakpoint.c (bppy_get_location): No longer check
 303         whether location is null.
 304
 305 2019-07-09  Pedro Alves  <palves@redhat.com>
 306
 307         PR c++/15468
 308         * breakpoint.c (print_one_breakpoint_location): Remove
 309         single-location assert.
 310
 311 2019-07-09  Tom Tromey  <tom@tromey.com>
 312
 313         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 314         * configure: Rebuild.
 315         * configure.ac: Change common to gdbsupport.
 316         * gdbsupport: Rename from common.
 317         * acinclude.m4: Change common to gdbsupport.
 318         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 319         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 320         gdbsupport.
 321         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 322         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 323         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 324         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 325         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 326         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 327         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 328         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 329         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 330         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 331         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 332         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 333         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 334         coff-pe-read.c, command.h, compile/compile-c-support.c,
 335         compile/compile-c.h, compile/compile-cplus-symbols.c,
 336         compile/compile-cplus-types.c, compile/compile-cplus.h,
 337         compile/compile-loc2c.c, compile/compile.c, completer.c,
 338         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 339         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 340         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 341         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 342         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 343         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 344         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 345         features/aarch64-core.c, features/aarch64-fpu.c,
 346         features/aarch64-pauth.c, features/aarch64-sve.c,
 347         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 348         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 349         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 350         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 351         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 352         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 353         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 354         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 355         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 356         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 357         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 358         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 359         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 360         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 361         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 362         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 363         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 364         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 365         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 366         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 367         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 368         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 369         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 370         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 371         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 372         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 373         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 374         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 375         minsyms.c, mips-linux-tdep.c, namespace.h,
 376         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 377         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 378         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 379         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 380         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 381         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 382         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 383         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 384         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 385         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 386         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 387         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 388         procfs.c, producer.c, progspace.h, psymtab.h,
 389         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 390         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 391         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 392         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 393         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 394         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 395         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 396         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 397         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 398         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 399         target-memory.c, target.c, target.h, target/waitstatus.c,
 400         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 401         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 402         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 403         unittests/array-view-selftests.c,
 404         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 405         unittests/common-utils-selftests.c,
 406         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 407         unittests/format_pieces-selftests.c,
 408         unittests/function-view-selftests.c,
 409         unittests/lookup_name_info-selftests.c,
 410         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 411         unittests/mkdir-recursive-selftests.c,
 412         unittests/observable-selftests.c,
 413         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 414         unittests/parse-connection-spec-selftests.c,
 415         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 416         unittests/scoped_fd-selftests.c,
 417         unittests/scoped_mmap-selftests.c,
 418         unittests/scoped_restore-selftests.c,
 419         unittests/string_view-selftests.c, unittests/style-selftests.c,
 420         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 421         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 422         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 423         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 424         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 425         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 426
 427 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 428
 429         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 430         bool value.
 431         (decode_digits_ordinary): Set explicit_line field in sal.
 432         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 433         symtab_and_line that was set on an explicit line number in
 434         assembler code.  Do always update the recorded symtab and line if
 435         we do skip the prologue.
 436
 437 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 438
 439         * breakpoint.c (set_breakpoint_location_function): Remove
 440         explicit_loc parameter.
 441         (momentary_breakpoint_from_master): Update call to
 442         set_breakpoint_location_function.
 443         (add_location_to_breakpoint): Likewise.
 444
 445 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 446
 447         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
 448         required features based on default bfd type when no specific bfd
 449         is present.
 450
 451 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 452
 453         * NEWS: Mention that GDB printf and eval commands can now print
 454         C-style and Ada-style convenience var strings without
 455         calling the inferior.
 456         * printcmd.c (printf_c_string): Locally print GDB internal var
 457         instead of transiting via the inferior.
 458         (printf_wide_c_string): Likewise.
 459
 460 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 461
 462         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
 463
 464 2019-07-04  Tom Tromey  <tom@tromey.com>
 465
 466         PR tui/24724:
 467         * tui/tui-winsource.c (tui_clear_source_content): Update.
 468         (tui_source_window_base::set_is_exec_point_at): Fix comment.
 469         (tui_update_breakpoint_info): Update.
 470         (tui_set_exec_info_content): Update.
 471         * tui/tui-source.c (tui_set_source_content_nil): Update.
 472         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
 473         has_break.
 474         * tui/tui-data.h (enum tui_bp_flag): New.
 475         (tui_bp_flags): New enum flags type.
 476         (struct tui_source_element) <break_mode>: Change type.  Rename
 477         from has_break.
 478         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
 479         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
 480         constants.
 481         * tui/tui-winsource.h: Fix comment.
 482
 483 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 484
 485         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
 486         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
 487         (store_fpregs_to_thread)
 488         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 489         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
 490         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
 491         (IWMMXT_REGS_SIZE): Add define.
 492         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
 493         (fetch_vfp_regs, store_vfp_regs)
 494         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 495         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
 496
 497 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 498
 499         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
 500         defines.
 501         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
 502         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
 503         (ARM_INT_REGISTER_SIZE): ...to this.
 504         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
 505         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
 506         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
 507         (arm_linux_collect_gregset, supply_nwfpe_register)
 508         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
 509         defines.
 510         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
 511         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
 512         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
 513         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
 514         (arm_return_in_memory, arm_store_return_value)
 515         (arm_get_longjmp_target, arm_register_g_packet_guesses)
 516         (arm_record_ld_st_multiple): Likewise.
 517         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
 518         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
 519
 520 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 521
 522         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
 523         AARCH64_DISPLACED_MODIFIED_INSNS.
 524         * aarch64-tdep.c (struct aarch64_displaced_step_data)
 525         (aarch64_displaced_step_copy_insn): Likewise.
 526         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 527         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
 528         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
 529         ARM_DISPLACED_MODIFIED_INSNS.
 530         * arm-tdep.c (arm_gdbarch_init): Likewise.
 531         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 532         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
 533         (struct arm_displaced_step_closure): Use
 534         ARM_DISPLACED_MODIFIED_INSNS.
 535
 536 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 537
 538         * features/Makefile: Remove unused xml files.
 539         * features/aarch64.xml: Remove.
 540         * features/i386/amd64-avx-avx512-linux.xml: Remove.
 541         * features/i386/amd64-avx-avx512.xml: Remove.
 542         * features/i386/amd64-avx-linux.xml: Remove.
 543         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
 544         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
 545         * features/i386/amd64-avx-mpx-linux.xml: Remove.
 546         * features/i386/amd64-avx-mpx.xml: Remove.
 547         * features/i386/amd64-avx.xml: Remove.
 548         * features/i386/amd64-linux.xml: Remove.
 549         * features/i386/amd64-mpx-linux.xml: Remove.
 550         * features/i386/amd64-mpx.xml: Remove.
 551         * features/i386/amd64.xml: Remove.
 552         * features/i386/i386-avx-avx512-linux.xml: Remove.
 553         * features/i386/i386-avx-avx512.xml: Remove.
 554         * features/i386/i386-avx-linux.xml: Remove.
 555         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
 556         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
 557         * features/i386/i386-avx-mpx-linux.xml: Remove.
 558         * features/i386/i386-avx-mpx.xml: Remove.
 559         * features/i386/i386-avx.xml: Remove.
 560         * features/i386/i386-linux.xml: Remove.
 561         * features/i386/i386-mmx-linux.xml: Remove.
 562         * features/i386/i386-mmx.xml: Remove.
 563         * features/i386/i386-mpx-linux.xml: Remove.
 564         * features/i386/i386-mpx.xml: Remove.
 565         * features/i386/i386.xml: Remove.
 566         * features/i386/x32-avx-avx512-linux.xml: Remove.
 567         * features/i386/x32-avx-linux.xml: Remove.
 568         * features/i386/x32-linux.xml: Remove.
 569
 570 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 571
 572         * regformats/aarch64.dat: Remove.
 573         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
 574         * regformats/i386/amd64-avx-linux.dat: Remove.
 575         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
 576         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
 577         * regformats/i386/amd64-linux.dat: Remove.
 578         * regformats/i386/amd64-mpx-linux.dat: Remove.
 579         * regformats/i386/amd64.dat: Remove.
 580         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
 581         * regformats/i386/i386-avx-linux.dat: Remove.
 582         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
 583         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
 584         * regformats/i386/i386-linux.dat: Remove.
 585         * regformats/i386/i386-mmx-linux.dat: Remove.
 586         * regformats/i386/i386-mpx-linux.dat: Remove.
 587         * regformats/i386/i386.dat: Remove.
 588         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
 589         * regformats/i386/x32-avx-linux.dat: Remove.
 590         * regformats/i386/x32-linux.dat: Remove.
 591
 592 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 593
 594         * aarch64-tdep.c: Remove xml self tests.
 595         * amd64-linux-tdep.c: Likewise.
 596         * amd64-tdep.c: Likewise.
 597         * i386-linux-tdep.c: Likewise.
 598         * i386-tdep.c: Likewise.
 599
 600 2019-07-03  Pedro Alves  <palves@redhat.com>
 601
 602         PR cli/24732
 603         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
 604         (pipe_cmd_option_defs): New.
 605         (make_pipe_cmd_options_def_group): New.
 606         (pipe_command): Use gdb::option::process_options.
 607         (pipe_command_completer): New function.
 608         (_initialize_cli_cmds): Install completer for "pipe" command.
 609
 610 2019-07-03  Pedro Alves  <palves@redhat.com>
 611
 612         * cli/cli-option.c (union option_value) <string>: New field.
 613         (struct option_def_and_value): Add ctor, move ctor, dtor and
 614         use DISABLE_COPY_AND_ASSIGN.
 615         (option_def_and_value::clear_value): New.
 616         (parse_option, save_option_value_in_ctx, get_val_type_str)
 617         (add_setshow_cmds_for_options): Handle var_string.
 618         * cli-option.h (union option_def::var_address) <string>: New
 619         field.
 620         (struct string_option_def): New.
 621         * maint-test-options.c (struct test_options_opts): Add default
 622         ctor and use DISABLE_COPY_AND_ASSIGN.
 623         <string_opt>: New field.
 624         (test_options_opts::~test_options_opts): New.
 625         (test_options_opts::dump): Also dump "-string".
 626         (test_options_option_defs): Install "string.
 627
 628 2019-07-03  Pedro Alves  <palves@redhat.com>
 629
 630         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
 631         option_value with a null enumeration.
 632         (complete_options): Save the option values in the context.
 633         (save_option_value_in_ctx): New, factored out from ...
 634         (process_options): ... here.
 635         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
 636         of the function.
 637         * maint-test-options.c (test_options_opts::dump): New, factored
 638         out from ...
 639         (maintenance_test_options_command_mode): ... here.
 640         (maintenance_test_options_command_completion_result): Delete.
 641         (maintenance_test_options_command_completion_text): Update
 642         comment.
 643         (maintenance_show_test_options_completion_result): Change
 644         prototype.  Just print
 645         maintenance_test_options_command_completion_text.
 646         (save_completion_result): New.
 647         (maintenance_test_options_completer_mode): Pass options context to
 648         complete_options, and then save a dump.
 649         (_initialize_maint_test_options): Use add_cmd to install "maint
 650         show test-options-completion-result".
 651
 652 2019-07-03  Pedro Alves  <palves@redhat.com>
 653
 654         * NEWS (New commands): Mention "with" and "maint with".
 655         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
 656         (with_command, with_command_completer): New.
 657         (pipe_command): Adjust to new repeat_previous
 658         interface.
 659         (_initialize_cli_cmds): Install the "with" command and its "w"
 660         alias.
 661         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
 662         declarations.
 663         * cli/cli-setshow.c (parse_cli_var_uinteger)
 664         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
 665         argument strings for all var_types.
 666         (get_setshow_command_value_string): New, factored out from ...
 667         (do_show_command): ... this.
 668         * cli/cli-setshow.h: Include <string>.
 669         (get_setshow_command_value_string): Declare.
 670         * command.h (repeat_previous): Now returns const char *.  Adjust
 671         comment.
 672         * maint.c: Include "cli/cli-cmds.h".
 673         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
 674         (_initialize_maint_cmds): Register the "maintenance with" command.
 675         * top.c (repeat_previous): Move bits from pipe_command here:
 676         Return the saved command line, if any; error out if there's no
 677         command to relaunch.
 678
 679 2019-07-03  Pedro Alves  <palves@redhat.com>
 680
 681         * NEWS (New commands): Mention "maint set/show test-settings"
 682         instead of "maint test-settings".
 683         * maint-test-settings.c (maintenance_test_settings_list): Delete.
 684         (maintenance_test_settings_set_list): Rename to ...
 685         (maintenance_set_test_settings_list): ... this.
 686         (maintenance_test_settings_show_list): Rename to  ...
 687         (maintenance_show_test_settings_list): ... this.
 688         (maintenance_test_settings_cmd): Delete.
 689         (maintenance_test_settings_set_cmd): ...
 690         (maintenance_set_test_settings_cmd): ... this.
 691         (maintenance_test_settings_show_cmd): ...
 692         (maintenance_show_test_settings_cmd): ... this.
 693         (maintenance_test_settings_show_value_cmd):
 694         (maintenance_show_test_settings_value_cmd): ... this.
 695         (_initialize_maint_test_settings): No longer install the "maint
 696         test-settings" prefix command.  Rename "maint test-settings set"
 697         to "maint set test-settings", and "maint test-settings show" to
 698         "maint show test-settings".  Adjust all subcommands.
 699
 700 2019-07-03  Pedro Alves  <palves@redhat.com>
 701
 702         * maint-test-settings.c: Fix file's intro comment.  Replace all
 703         references to "test-options" with references to "test-settings",
 704         in comments.
 705
 706 2019-07-03  Pedro Alves  <palves@redhat.com>
 707
 708         * maint-test-settings.c (maintenance_test_settings_xxx)
 709         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
 710         New.
 711         (maintenance_test_settings_enums): Use them.
 712         (maintenance_test_settings_enum): Default to
 713         maintenance_test_settings_xxx.
 714         (_initialize_maint_test_settings): Initialize
 715         MAINTENANCE_TEST_SETTINGS_FILENAME.
 716
 717 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 718
 719         * breakpoint.h (remove_breakpoints_inf): Change return type to
 720         void, move function documentation here.
 721         * breakpoint.c (remove_breakpoints_inf): Change return type to
 722         void, move function documentation to header.
 723
 724 2019-07-02  Pedro Alves  <palves@redhat.com>
 725
 726         * NEWS (Completion improvements): Mention "info threads".
 727         * thread.c (struct info_threads_opts, info_threads_option_defs)
 728         (make_info_threads_options_def_group): New.
 729         (info_threads_command): Use gdb::option::process_options.
 730         (info_threads_command_completer): New.
 731         (_initialize_thread): Use gdb::option::build_help to build the
 732         help text for "info threads".
 733
 734 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 735
 736         * defs.h (generic_load): Move from here...
 737         * symfile.h (generic_load): ... to here.  Rename name parameter
 738         to args.
 739         * symfile.c (generic_load): Add comment.
 740
 741 2019-07-01  Tom Tromey  <tromey@adacore.com>
 742
 743         * dwarf2read.c
 744         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
 745         declaration of without_params.  Fix formatting.
 746
 747 2019-07-01  Tom Tromey  <tromey@adacore.com>
 748
 749         * ada-exp.y (find_primitive_type): Update.
 750         * ada-lang.h (ada_lookup_symbol): Update.
 751         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
 752         parameter.
 753         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
 754
 755 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 756
 757         PR breakpoints/24541
 758         * gdbarch.c: Regenerate.
 759         * gdbarch.h: Regenerate.
 760         * gdbarch.sh: Add 'stap_adjust_register'.
 761         * i386-tdep.c: Include '<unordered_set>'.
 762         (i386_stap_adjust_register): New function.
 763         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
 764         * stap-probe.c (stap_parse_register_operand): Call
 765         'gdbarch_stap_adjust_register'.
 766
 767 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 768
 769         PR python/24742
 770         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
 771         * python/python.c (do_start_initialization): Use 'xmalloc'
 772         instead of 'PyMem_Malloc'.
 773
 774 2019-06-28  Tom Tromey  <tromey@adacore.com>
 775
 776         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
 777         for Ada.
 778
 779 2019-06-27  Tom Tromey  <tromey@adacore.com>
 780
 781         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
 782         objfile_key.
 783         (arm_find_mapping_symbol, arm_record_special_symbol)
 784         (_initialize_arm_tdep): Update.
 785         (arm_objfile_data_free): Remove.
 786
 787 2019-06-27  Tom Tromey  <tromey@adacore.com>
 788
 789         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
 790         to cp_print_static_field.
 791
 792 2019-06-26  Tom Tromey  <tromey@adacore.com>
 793
 794         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
 795         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
 796         declare.
 797
 798 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 799
 800         * features/aarch64-core.c (create_feature_aarch64_core):
 801         Regenerate.
 802         * features/aarch64-core.xml: Add cpsr flags.
 803
 804 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 805
 806         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
 807         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
 808
 809 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 810
 811         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
 812         field.
 813         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
 814         use.
 815         (arm_record_special_symbol): Don't insert new symbol in sorted
 816         position, push it at the end.
 817
 818 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 819
 820         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
 821         (arm_mapping_symbol_s): Remove.
 822         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
 823         (arm_mapping_symbol_vec): New typedef.
 824         (struct arm_per_objfile): Add constructor.
 825         <section_maps>: Change type to
 826         std::unique_ptr<arm_mapping_symbol_vec[]>.
 827         (arm_compare_mapping_symbols): Remove.
 828         (arm_find_mapping_symbol): Adjust to section_maps type change.
 829         (arm_objfile_data_free): Call delete on arm_per_objfile.
 830         (arm_record_special_symbol): Adjust to section_maps type change.
 831         Allocate arm_per_objfile with new.
 832
 833 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 834
 835         * cli/cli-cmds.c (alias_command): Compare the alias prefix
 836         with the command prefix.
 837
 838 2019-06-25  Tom Tromey  <tom@tromey.com>
 839
 840         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
 841         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
 842
 843 2019-06-25  Tom Tromey  <tom@tromey.com>
 844
 845         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
 846         type.
 847         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
 848         protected.
 849
 850 2019-06-25  Tom Tromey  <tom@tromey.com>
 851
 852         * tui/tui-winsource.c
 853         (tui_source_window_base::set_is_exec_point_at): Add check against
 854         LOA_ADDRESS.
 855
 856 2019-06-25  Tom Tromey  <tom@tromey.com>
 857
 858         * tui/tui-source.c (tui_set_source_content): Don't check before
 859         xfree.
 860         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
 861
 862 2019-06-25  Tom Tromey  <tom@tromey.com>
 863
 864         * tui/tui-winsource.h (tui_update_source_window_as_is)
 865         (tui_alloc_source_buffer, tui_line_is_displayed)
 866         (tui_addr_is_displayed): Change type of win_info.
 867         * tui/tui-winsource.c (tui_update_source_window_as_is)
 868         (tui_clear_source_content, tui_show_source_line)
 869         (tui_show_source_content, tui_source_window_base::refill)
 870         (tui_source_window_base::set_is_exec_point_at)
 871         (tui_source_window_base::set_is_exec_point_at)
 872         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
 873         (tui_alloc_source_buffer, tui_line_is_displayed)
 874         (tui_addr_is_displayed): Change type of win_info.  Update.
 875         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 876         (tui_source_window_base::do_make_visible_with_new_height):
 877         Update.
 878         * tui/tui-source.c (tui_set_source_content)
 879         (tui_set_source_content_nil)
 880         (tui_source_window::do_scroll_vertical): Update.
 881         * tui/tui-layout.c (show_layout): Update.
 882         * tui/tui-disasm.c (tui_set_disassem_content)
 883         (tui_disasm_window::do_scroll_vertical): Update.
 884         * tui/tui-data.h (tui_win_content): Remove.
 885         (struct tui_gen_win_info) <content, content_size>: Remove.
 886         (struct tui_source_element): Add initializers and destructor.
 887         (union tui_which_element, struct tui_win_element): Remove.
 888         (struct tui_source_window_base) <content>: New field.
 889         (struct tui_data_window): Remove destructor.
 890         (tui_alloc_content, tui_free_win_content)
 891         (tui_free_all_source_wins_content): Don't declare.
 892         * tui/tui-data.c (tui_initialize_static_data): Update.
 893         (init_content_element, tui_alloc_content): Remove.
 894         (~tui_gen_win_info): Update.
 895         (~tui_data_window, tui_free_all_source_wins_content)
 896         (tui_free_win_content, free_content, free_content_elements):
 897         Remove.
 898
 899 2019-06-25  Tom Tromey  <tom@tromey.com>
 900
 901         * tui/tui-winsource.h (tui_clear_source_content)
 902         (tui_erase_source_content, tui_show_source_content): Change type
 903         of win_info.
 904         * tui/tui-winsource.c (tui_clear_source_content)
 905         (tui_erase_source_content, tui_show_source_content): Change type
 906         of win_info.
 907         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 908         * tui/tui-source.h (tui_set_source_content_nil): Change type of
 909         win_info.
 910         * tui/tui-source.c (tui_set_source_content_nil): Change type of
 911         win_info.
 912         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
 913
 914 2019-06-25  Tom Tromey  <tom@tromey.com>
 915
 916         * tui/tui-winsource.c (tui_clear_source_content)
 917         (tui_source_window_base::set_is_exec_point_at): Update.
 918         * tui/tui-source.c (tui_set_source_content_nil): Update.
 919         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
 920         a bool.
 921         * tui/tui-data.c (init_content_element): Update.
 922
 923 2019-06-25  Tom Tromey  <tom@tromey.com>
 924
 925         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
 926         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
 927         * tui/tui-layout.c (init_and_make_win): Update.
 928         * tui/tui.h (enum tui_win_type): Update.
 929         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
 930         tui_win_is_auxillary.
 931         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
 932         tui_win_is_auxillary.
 933
 934 2019-06-25  Tom Tromey  <tom@tromey.com>
 935
 936         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
 937         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
 938         (tui_delete_data_content_windows, tui_display_all_data)
 939         (tui_data_window::do_scroll_vertical, tui_display_data_from):
 940         Update.
 941         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
 942         * tui/tui-regs.c (tui_last_regs_line_no)
 943         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 944         (tui_show_registers): Update.
 945         (tui_show_register_group): Return void.  Update.
 946         (tui_display_registers_from, tui_display_reg_element_at_line)
 947         (tui_display_registers_from_line, tui_check_register_values):
 948         Update.
 949         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
 950         member.
 951         (struct tui_data_window) <regs_content>: Now a std::vector.
 952         <regs_content_count>: Remove.
 953         (tui_add_content_elements, tui_free_data_content): Don't declare.
 954         * tui/tui-data.c (tui_data_window::clear_detail): Update.
 955         (init_content_element): Remove DATA_WIN case.  Add assert.
 956         (tui_add_content_elements): Remove.
 957         (tui_data_window): Update.
 958         (tui_free_data_content): Remove.
 959         (free_content_elements): Remove DATA_WIN case.
 960
 961 2019-06-25  Tom Tromey  <tom@tromey.com>
 962
 963         * tui/tui-data.c (tui_data_item_window): Update.
 964         * tui/tui-windata.h (tui_check_data_values): Don't declare.
 965         * tui/tui-windata.c (tui_display_all_data)
 966         (tui_display_data_from_line): Update.
 967         (tui_check_data_values): Remove.
 968         * tui/tui-regs.c (tui_show_register_group)
 969         (tui_display_reg_element_at_line): Update.
 970         * tui/tui-hooks.c (tui_register_changed)
 971         (tui_refresh_frame_and_register_information): Call
 972         tui_check_register_values.
 973         * tui/tui-data.h (struct tui_data_window) <data_content,
 974         data_content_count, data_type>: Remove.
 975         (enum tui_data_type): Remove.
 976
 977         * tui/tui-data.c (tui_data_window::clear_detail)
 978         (~tui_data_window): Update.
 979
 980 2019-06-25  Tom Tromey  <tom@tromey.com>
 981
 982         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
 983         declare.
 984         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
 985         Rename from tui_first_data_item_displayed.  Update.
 986         (tui_data_window::refresh_all)
 987         (tui_data_window::do_scroll_vertical): Update.
 988         * tui/tui-data.h (struct tui_data_window)
 989         <first_data_item_displayed>: Declare new method.
 990
 991 2019-06-25  Tom Tromey  <tom@tromey.com>
 992
 993         * tui/tui-data.h (tui_init_generic_part): Don't declare.
 994         * tui/tui-data.c (tui_init_generic_part): Remove, moving
 995         contents...
 996         (tui_initialize_static_data): ...here.
 997
 998 2019-06-25  Tom Tromey  <tom@tromey.com>
 999
1000         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1001         (tui_display_registers_from, tui_check_register_values): Update.
1002         (tui_display_register): Remove win_info parameter; update.
1003         (tui_get_register): Change type of parameters.
1004         * tui/tui-data.h (struct tui_data_element): Remove.
1005         (union tui_which_element) <data>: Remove.
1006         <data_window>: Change type.
1007         (struct tui_data_item_window): New.
1008         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1009         case.  Add assert.
1010         (~tui_data_item_window): New destructor.
1011         (free_content_elements): Remove DATA_ITEM_WIN case.
1012
1013 2019-06-25  Tom Tromey  <tom@tromey.com>
1014
1015         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1016         Remove.
1017
1018 2019-06-25  Tom Tromey  <tom@tromey.com>
1019
1020         * tui/tui-data.h (struct tui_command_element): Remove.
1021         (union tui_which_element) <command>: Remove.
1022         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1023         assert.
1024         (free_content_elements): Remove CMD_WIN case.
1025
1026 2019-06-25  Tom Tromey  <tom@tromey.com>
1027
1028         * tui/tui-layout.c (tui_set_layout): Update.
1029         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1030         * tui/tui-data.c (layout_def): Update.
1031
1032 2019-06-25  Tom Tromey  <tom@tromey.com>
1033
1034         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1035         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1036         (tui_source_window_base::set_new_height): Update.
1037         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1038         Update.
1039         (tui_set_locator_fullname, tui_set_locator_info)
1040         (tui_show_frame_info): Update.
1041         * tui/tui-source.c (tui_set_source_content)
1042         (tui_source_is_displayed): Update.
1043         * tui/tui-layout.c (show_source_disasm_command, show_data)
1044         (show_source_or_disasm_and_command): Update.
1045         * tui/tui-disasm.c (tui_set_disassem_content)
1046         (tui_get_begin_asm_address): Update.
1047         * tui/tui-data.h (struct tui_locator_element): Remove.
1048         (union tui_which_element) <locator>: Remove.
1049         (struct tui_locator_window): New.
1050         (tui_locator_win_info_ptr): Change return type.
1051         * tui/tui-data.c (_locator): Change type.
1052         (tui_locator_win_info_ptr): Change return type.
1053         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1054         (tui_alloc_content): Add assert.
1055
1056 2019-06-25  Tom Tromey  <tom@tromey.com>
1057
1058         * tui/tui-winsource.c
1059         (tui_exec_info_window::maybe_allocate_content): New method.
1060         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1061         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1062         (make_source_or_disasm_window): Add cast.
1063         * tui/tui-data.h (union tui_which_element) <simple_string>:
1064         Remove.
1065         (struct tui_source_info): New.
1066         (struct tui_source_window_base) <execution_info>: Change type.
1067         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1068         case, and add assert.
1069         (tui_alloc_content): Add assert.
1070
1071 2019-06-25  Tom Tromey  <tom@tromey.com>
1072
1073         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1074         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1075         * tui/tui-data.c (tui_alloc_win_info): Remove.
1076
1077 2019-06-25  Tom Tromey  <tom@tromey.com>
1078
1079         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1080         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1081         can_highlight.
1082
1083 2019-06-25  Tom Tromey  <tom@tromey.com>
1084
1085         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1086         make_visible_with_new_height method.
1087         (tui_win_info::make_visible_with_new_height): New method.
1088         (tui_source_window_base::do_make_visible_with_new_height)
1089         (tui_data_window::do_make_visible_with_new_height)
1090         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1091         (make_visible_with_new_height): Remove.
1092         (tui_resize_all, tui_adjust_win_heights): Use
1093         make_visible_with_new_height method.
1094         * tui/tui-data.h (struct tui_win_info)
1095         <do_make_visible_with_new_height, make_visible_with_new_height>:
1096         New methods.
1097         (struct tui_source_window_base, struct tui_data_window)
1098         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1099         methods.
1100
1101 2019-06-25  Tom Tromey  <tom@tromey.com>
1102
1103         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1104         method.
1105         (update_tab_width): Call update_tab_width method.
1106         * tui/tui-data.h (struct tui_win_info)
1107         (struct tui_source_window_base) <update_tab_width>: New methods.
1108
1109 2019-06-25  Tom Tromey  <tom@tromey.com>
1110
1111         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1112         parameter.
1113         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1114         parameter.
1115         (tui_gen_win_info::make_visible): Update.
1116         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1117         parameter.
1118         * tui/tui-data.h (enum tui_box): New enum.
1119         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1120
1121 2019-06-25  Tom Tromey  <tom@tromey.com>
1122
1123         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1124         init_and_make_win for EXEC_INFO_WIN.
1125         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1126         longer inline.
1127         (struct tui_win_info) <~tui_win_info>: Inline.
1128         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1129         Don't declare.
1130         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1131         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1132         Remove.
1133         (tui_initialize_static_data): Update.
1134         (~tui_gen_win_info): Handle more cleanup here.
1135         (~tui_source_window_base): Delete "execution_info".
1136         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1137
1138 2019-06-25  Tom Tromey  <tom@tromey.com>
1139
1140         * tui/tui-layout.c (make_command_window): Don't set
1141         can_highlight.
1142         (show_source_disasm_command): Call the reset method.
1143         (show_data): Don't set can_highlight.  Call the reset method.
1144         (tui_gen_win_info::reset): Rename from init_gen_win_info
1145         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1146         (show_source_or_disasm_and_command): Call the reset method.
1147         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1148         (struct tui_cmd_window): Set can_highlight.
1149
1150 2019-06-25  Tom Tromey  <tom@tromey.com>
1151
1152         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1153         from make_visible.
1154         (tui_make_visible, tui_make_invisible): Rewrite.
1155         (tui_win_info::make_visible): Remove.
1156         (tui_source_window_base::make_visible): Update.
1157         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1158         method.  Moved from...
1159         (struct tui_win_info) <make_visible>: ...here.
1160
1161 2019-06-25  Tom Tromey  <tom@tromey.com>
1162
1163         * tui/tui-winsource.c
1164         (tui_source_window_base::do_scroll_horizontal): Remove direction
1165         parameter.
1166         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1167         direction parameter.
1168         * tui/tui-win.c (tui_win_info::forward_scroll)
1169         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1170         (tui_win_info::right_scroll): Update.
1171         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1172         direction parameter.
1173         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1174         direction parameter.
1175         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1176         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1177         Remove direction parameter.
1178         (struct tui_source_window_base, struct tui_source_window)
1179         (struct tui_disasm_window, struct tui_data_window)
1180         (struct tui_cmd_window): Update.
1181
1182 2019-06-25  Tom Tromey  <tom@tromey.com>
1183
1184         * tui/tui-winsource.h (tui_set_exec_info_content)
1185         (tui_show_exec_info_content, tui_erase_exec_info_content)
1186         (tui_clear_exec_info_content, tui_update_exec_info): Change
1187         argument to tui_source_window_base.
1188         * tui/tui-winsource.c (tui_set_exec_info_content)
1189         (tui_show_exec_info_content, tui_erase_exec_info_content)
1190         (tui_clear_exec_info_content, tui_update_exec_info): Change
1191         argument to tui_source_window_base.
1192
1193 2019-06-25  Tom Tromey  <tom@tromey.com>
1194
1195         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1196         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1197
1198 2019-06-25  Tom Tromey  <tom@tromey.com>
1199
1200         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1201         check.
1202
1203 2019-06-25  Tom Tromey  <tom@tromey.com>
1204
1205         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1206         type to void.
1207         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1208         type to void.
1209         * tui/tui-source.c (tui_set_source_content): Update.
1210         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1211
1212 2019-06-25  Tom Tromey  <tom@tromey.com>
1213
1214         * tui/tui-win.c (window_name_completer, tui_set_focus)
1215         (tui_all_windows_info): Use name method.
1216         * tui/tui-data.h (struct tui_gen_win_info)
1217         (struct tui_source_window, struct tui_disasm_window)
1218         (struct tui_data_window, struct tui_cmd_window) <name>: New
1219         method.
1220         (tui_win_name): Don't declare.
1221         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1222         (tui_win_name): Remove.
1223
1224 2019-06-25  Tom Tromey  <tom@tromey.com>
1225
1226         * tui/tui-winsource.h (tui_update_source_window)
1227         (tui_update_source_window_as_is): Change parameter type.
1228         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1229         to be a tui_source_window_base.
1230         (tui_update_source_window_as_is): Likewise.
1231         * tui/tui-win.c (make_visible_with_new_height): Update.
1232
1233 2019-06-25  Tom Tromey  <tom@tromey.com>
1234
1235         * tui/tui-winsource.c (tui_erase_source_content)
1236         (tui_show_source_content, tui_show_exec_info_content)
1237         (tui_erase_exec_info_content): Use refresh_window method.
1238         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1239         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1240         from tui_refresh_win.
1241         (tui_data_window::refresh_window): New method.
1242         (tui_win_info::refresh, tui_source_window_base::refresh)
1243         (tui_refresh_all): Use refresh_window method.
1244         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1245         method.
1246         * tui/tui-regs.c (tui_display_register): Call refresh_window
1247         method.
1248         * tui/tui-layout.c (show_source_disasm_command)
1249         (show_source_or_disasm_and_command): Call refresh_window method.
1250         * tui/tui-data.h (struct tui_gen_win_info)
1251         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1252         New method.
1253
1254 2019-06-25  Tom Tromey  <tom@tromey.com>
1255
1256         * tui/tui.c (tui_rl_other_window, tui_enable)
1257         (tui_is_window_visible, tui_get_command_dimension): Update.
1258         * tui/tui-winsource.c (tui_update_source_window_as_is)
1259         (tui_clear_source_content, tui_erase_source_content)
1260         (tui_show_source_line, tui_source_window_base::refill)
1261         (tui_source_window_base::do_scroll_horizontal)
1262         (tui_source_window_base::set_is_exec_point_at)
1263         (tui_update_breakpoint_info, tui_set_exec_info_content)
1264         (tui_alloc_source_buffer, tui_line_is_displayed)
1265         (tui_addr_is_displayed): Update.
1266         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1267         (tui_check_and_display_highlight_if_needed)
1268         (tui_win_info::make_visible, tui_win_info::refresh)
1269         (tui_refresh_all): Update.
1270         * tui/tui-windata.c (tui_first_data_item_displayed)
1271         (tui_delete_data_content_windows, tui_erase_data_content)
1272         (tui_display_all_data, tui_data_window::refresh_all)
1273         (tui_check_data_values): Update.
1274         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1275         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1276         (tui_win_info::backward_scroll, tui_refresh_all_win)
1277         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1278         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1279         (tui_source_window_base::set_new_height)
1280         (tui_data_window::set_new_height)
1281         (make_invisible_and_set_new_height)
1282         (make_visible_with_new_height, new_height_ok)
1283         (parse_scrolling_args): Update.
1284         * tui/tui-stack.c (tui_show_frame_info): Update.
1285         * tui/tui-source.c (tui_set_source_content)
1286         (tui_set_source_content_nil, tui_source_is_displayed)
1287         (tui_source_window::do_scroll_vertical): Update.
1288         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1289         (tui_display_registers_from, tui_display_reg_element_at_line)
1290         (tui_check_register_values, tui_reg_command): Update.
1291         * tui/tui-layout.c (tui_default_win_height)
1292         (show_source_disasm_command, show_data, init_and_make_win)
1293         (show_source_or_disasm_and_command): Update.
1294         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1295         (tui_redisplay_readline, tui_mld_flush)
1296         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1297         (tui_getc): Update.
1298         * tui/tui-disasm.c (tui_set_disassem_content)
1299         (tui_disasm_window::do_scroll_vertical): Update.
1300         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1301         Now virtual.
1302         (struct tui_win_info): Derive from tui_gen_win_info.
1303         <~tui_win_info>: Mark as override.
1304         <generic>: Remove member.
1305         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1306         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1307         (~tui_data_window, ~tui_win_info)
1308         (tui_free_all_source_wins_content): Update.
1309         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1310
1311 2019-06-25  Tom Tromey  <tom@tromey.com>
1312
1313         * tui/tui-layout.c (init_and_make_win): Use new.
1314         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1315         destructor, initializers.
1316         (tui_alloc_generic_win_info): Don't declare.
1317         * tui/tui-data.c (_locator): Add argument to constructor.
1318         (source_win, disasm_win): New globals.
1319         (exec_info): Remove.
1320         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1321         Update.
1322         (tui_alloc_generic_win_info): Remove.
1323         (init_content_element): Use new.
1324         (tui_win_info::tui_win_info): Update.
1325         (free_content_elements) <case DATA_WIN>: Use delete.
1326
1327 2019-06-25  Tom Tromey  <tom@tromey.com>
1328
1329         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1330         * tui/tui-windata.c (tui_first_data_item_displayed)
1331         (tui_delete_data_content_windows): Update.
1332         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1333         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1334         (tui_display_registers_from, tui_check_register_values): Update.
1335         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1336         pointer.
1337         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1338         window.
1339         (tui_free_data_content): Update.
1340         (free_content_elements) <case DATA_WIN>: Free the window.
1341
1342 2019-06-25  Tom Tromey  <tom@tromey.com>
1343
1344         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1345         Update.
1346         * tui/tui-layout.c (make_command_window)
1347         (show_source_disasm_command, show_data, init_and_make_win)
1348         (show_source_or_disasm_and_command): Update.
1349         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1350         method.
1351         <can_highight, is_highlighted>: Now bool.
1352         (tui_set_win_highlight): Don't declare.
1353         * tui/tui-data.c (tui_set_win_highlight): Remove.
1354
1355 2019-06-25  Tom Tromey  <tom@tromey.com>
1356
1357         * tui/tui-wingeneral.c (make_visible): Remove check of window
1358         type.
1359
1360 2019-06-25  Tom Tromey  <tom@tromey.com>
1361
1362         * tui/tui-win.c (tui_win_info::max_height)
1363         (tui_cmd_window::max_height): New methods.
1364         (new_height_ok): Call max_height.
1365         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1366         <max_height>: New method.
1367
1368 2019-06-25  Tom Tromey  <tom@tromey.com>
1369
1370         * tui/tui-win.c (tui_source_window_base::set_new_height)
1371         (tui_data_window::set_new_height): New methods.
1372         (make_invisible_and_set_new_height): Call set_new_height method.
1373         * tui/tui-data.h (struct tui_win_info)
1374         (struct tui_source_window_base, struct tui_data_window)
1375         <set_new_height>: New method.
1376
1377 2019-06-25  Tom Tromey  <tom@tromey.com>
1378
1379         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1380         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1381         tui_refresh_data_win.
1382         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1383         method.
1384         (tui_refresh_all_win): Call the refresh_all method.
1385         (tui_set_focus): Likewise.
1386         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1387         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1388         Likewise.
1389
1390 2019-06-25  Tom Tromey  <tom@tromey.com>
1391
1392         * tui/tui-winsource.h (tui_refill_source_window)
1393         (tui_set_is_exec_point_at): Don't declare.
1394         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1395         (tui_source_window_base::refill): Rename from
1396         tui_refill_source_window.
1397         (tui_source_window_base::do_scroll_horizontal): Update.
1398         (tui_source_window_base::set_is_exec_point_at): Rename from
1399         tui_set_is_exec_point_at.
1400         (tui_update_all_breakpoint_info): Update.
1401         * tui/tui-stack.c (tui_show_frame_info): Update.
1402         * tui/tui-layout.c (show_data): Add cast.
1403         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1404         * tui/tui-data.h (struct tui_source_window_base) <refill,
1405         set_is_exec_point_at>: New methods.
1406         (tui_source_windows, tui_add_to_source_windows): Update types.
1407         (tui_add_to_source_windows): Remove redundant declaration.
1408         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1409         (tui_source_windows): Change return type.
1410         (tui_clear_source_windows_detail): Update.
1411         (tui_add_to_source_windows): Change type of parameter.
1412         (tui_free_all_source_wins_content): Update.
1413
1414 2019-06-25  Tom Tromey  <tom@tromey.com>
1415
1416         * tui/tui-wingeneral.c (tui_win_info::refresh)
1417         (tui_source_window_base::refresh): New methods.
1418         (tui_refresh_all): Call the refresh method.
1419         * tui/tui-data.h (struct tui_win_info)
1420         (struct tui_source_window_base) <refresh>: New method.
1421
1422 2019-06-25  Tom Tromey  <tom@tromey.com>
1423
1424         * tui/tui.h (tui_is_window_visible): Return bool.
1425         * tui/tui.c (tui_is_window_visible): Return bool.
1426         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1427         (tui_make_visible, tui_make_invisible)
1428         (tui_win_info::make_visible)
1429         (tui_source_window_base::make_visible, make_all_visible)
1430         (tui_make_all_visible, tui_make_all_invisible): Update.
1431         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1432         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1433         bool.
1434         (struct tui_win_info, struct tui_source_window_base)
1435         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1436         * tui/tui-data.c (tui_init_generic_part): Update.
1437
1438 2019-06-25  Tom Tromey  <tom@tromey.com>
1439
1440         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1441         (tui_source_window_base::make_visible): New methods.
1442         (make_all_visible): Make method call.
1443         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1444         (struct tui_source_window_base, struct tui_cmd_window): Override
1445         make_visible.
1446         (tui_win_is_source_type): Don't declare.
1447         * tui/tui-data.c (tui_win_is_source_type): Remove.
1448
1449 2019-06-25  Tom Tromey  <tom@tromey.com>
1450
1451         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1452         NULL check.
1453
1454 2019-06-25  Tom Tromey  <tom@tromey.com>
1455
1456         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1457         Inline constructor.  Add initializers for members.
1458         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1459         constructors; now inline in class.
1460
1461 2019-06-25  Tom Tromey  <tom@tromey.com>
1462
1463         * tui/tui-regs.c (tui_show_registers): Update.
1464         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1465         bool.
1466         * tui/tui-data.c (tui_data_window::clear_detail)
1467         (tui_data_window): Update.
1468
1469 2019-06-25  Tom Tromey  <tom@tromey.com>
1470
1471         * tui/tui-windata.c (tui_display_all_data)
1472         (tui_display_data_from_line, tui_display_data_from)
1473         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1474         Update.
1475         * tui/tui-regs.c (tui_last_regs_line_no)
1476         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1477         (tui_show_registers, tui_show_register_group)
1478         (tui_display_registers_from, tui_display_reg_element_at_line)
1479         (tui_display_registers_from_line, tui_check_register_values)
1480         (tui_reg_next, tui_reg_prev): Update.
1481         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1482         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1483         tui_data_window.
1484         (struct tui_win_info) <detail>: Remove.  Add new fields from
1485         tui_data_info.
1486         (TUI_DATA_WIN): Add cast.
1487         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1488         (~tui_data_window): Simplify.
1489
1490 2019-06-25  Tom Tromey  <tom@tromey.com>
1491
1492         * tui/tui-layout.c (show_source_disasm_command)
1493         (show_source_or_disasm_and_command): Update.
1494         * tui/tui-io.c (update_cmdwin_start_line)
1495         (tui_redisplay_readline): Update.
1496         * tui/tui-data.h (struct tui_command_info): Remove.
1497         (struct tui_win_info) <detail>: Remove command_info member.
1498         (struct tui_data_window) <start_line>: New member, from
1499         tui_command_info.
1500         (TUI_CMD_WIN): Add casts.
1501
1502 2019-06-25  Tom Tromey  <tom@tromey.com>
1503
1504         * tui/tui-winsource.c (tui_update_source_window)
1505         (tui_refill_source_window)
1506         (tui_source_window_base::do_scroll_horizontal)
1507         (tui_update_breakpoint_info, tui_set_exec_info_content)
1508         (tui_show_exec_info_content, tui_erase_exec_info_content)
1509         (tui_clear_exec_info_content): Update.
1510         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1511         Update.
1512         * tui/tui-win.c (make_invisible_and_set_new_height)
1513         (make_visible_with_new_height): Update.
1514         * tui/tui-source.c (tui_set_source_content)
1515         (tui_show_symtab_source): Update.
1516         * tui/tui-layout.c (extract_display_start_addr)
1517         (show_source_disasm_command, show_data)
1518         (make_source_or_disasm_window)
1519         (show_source_or_disasm_and_command): Update.
1520         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1521         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1522         "gdbarch".
1523         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1524         to tui_source_window_base.
1525         (struct tui_win_info) <detail>: Remove source_info member.
1526         (struct tui_source_window_base) <has_locator>: Inline.
1527         Move contents from tui_source_info; rename has_locator member to
1528         m_has_locator.
1529         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1530         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1531         header file.
1532         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1533         Simplify.
1534         (tui_free_all_source_wins_content): Cast to
1535         tui_source_window_base.
1536
1537 2019-06-25  Tom Tromey  <tom@tromey.com>
1538
1539         * tui/tui-win.c (make_invisible_and_set_new_height)
1540         (make_visible_with_new_height): Call has_locator method.
1541         * tui/tui-layout.c (show_source_disasm_command, show_data)
1542         (show_source_or_disasm_and_command): Update for bool change.
1543         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1544         (tui_win_info) <has_locator>: New method.
1545         (struct tui_source_window_base) <has_locator>: New method.
1546         (tui_win_has_locator): Don't declare.
1547         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1548         from tui_win_has_locator.
1549         (tui_source_window_base): Use false, not FALSE.
1550
1551 2019-06-25  Tom Tromey  <tom@tromey.com>
1552
1553         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1554         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1555         clear_detail method directly.
1556         (tui_clear_win_detail): Remove.
1557
1558 2019-06-25  Tom Tromey  <tom@tromey.com>
1559
1560         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
1561         "this", not TUI_DISASM_WIN.
1562
1563 2019-06-25  Tom Tromey  <tom@tromey.com>
1564
1565         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
1566         declare.
1567         * tui/tui-winsource.c
1568         (tui_source_window_base::do_scroll_horizontal): Rename from
1569         tui_horizontal_source_scroll.
1570         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
1571         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
1572         from tui_vertical_data_scroll.
1573         * tui/tui-win.h (tui_scroll): Don't declare.
1574         * tui/tui-win.c (tui_win_info::forward_scroll)
1575         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1576         (tui_win_info::right_scroll): Rename and update.
1577         (tui_scroll_forward_command, tui_scroll_backward_command)
1578         (tui_scroll_left_command, tui_scroll_right_command): Update.
1579         (tui_scroll): Remove.
1580         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
1581         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
1582         from tui_vertical_source_scroll.
1583         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
1584         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
1585         from tui_vertical_disassem_scroll.
1586         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
1587         do_scroll_horizontal>: New methods.
1588         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
1589         Likewise.
1590         (struct tui_source_window_base): Add do_scroll_horizontal.
1591         (struct tui_source_window, struct tui_disasm_window): Add
1592         do_scroll_vertical.
1593         (struct tui_data_window, struct tui_cmd_window): Add
1594         do_scroll_horizontal and do_scroll_vertical.
1595         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
1596
1597 2019-06-25  Tom Tromey  <tom@tromey.com>
1598
1599         * tui/tui-data.h (struct tui_source_window_base): New struct.
1600         (struct tui_source_window): Derive from tui_source_window_base.
1601         (struct tui_disasm_window): New struct.
1602         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
1603         from tui_source_window::clear_detail.
1604         (tui_source_window_base): Rename from tui_source_window.
1605         (~tui_source_window_base): Rename from ~tui_source_window.
1606         (tui_alloc_win_info): Create a tui_disasm_window.
1607
1608 2019-06-25  Tom Tromey  <tom@tromey.com>
1609
1610         * tui/tui-data.h (struct tui_source_window)
1611         (struct tui_data_window): Declare destructors.
1612         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
1613         destructors.
1614         (tui_win_info): Simplify.
1615
1616 2019-06-25  Tom Tromey  <tom@tromey.com>
1617
1618         * tui/tui-winsource.c (tui_display_main)
1619         (tui_update_source_windows_with_addr)
1620         (tui_update_all_breakpoint_info): Update.
1621         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1622         (new_height_ok, parse_scrolling_args): Update.
1623         * tui/tui-stack.c (tui_show_frame_info): Update.
1624         * tui/tui-data.h (struct tui_list): Remove.
1625         (tui_source_windows): Return a reference to a std::vector.
1626         * tui/tui-data.c (source_windows): Now a std::vector.
1627         (tui_source_windows): Change return type.
1628         (tui_clear_source_windows): Rewrite.
1629         (tui_clear_source_windows_detail, tui_add_to_source_windows)
1630         (tui_free_all_source_wins_content): Rewrite.
1631
1632 2019-06-25  Tom Tromey  <tom@tromey.com>
1633
1634         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
1635         (struct tui_data_window, struct tui_cmd_window): Declare
1636         clear_detail method.
1637         * tui/tui-data.c (tui_source_window::clear_detail)
1638         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
1639         methods.
1640         (tui_clear_win_detail): Simplify.
1641
1642 2019-06-25  Tom Tromey  <tom@tromey.com>
1643
1644         * tui/tui-layout.c (make_source_window, make_disasm_window)
1645         (make_source_or_disasm_window): Remove win_info_ptr parameter.
1646         Return the new window.
1647         (show_source_disasm_command, show_data)
1648         (show_source_or_disasm_and_command): Update.
1649
1650 2019-06-25  Tom Tromey  <tom@tromey.com>
1651
1652         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
1653         parameter.  Return the new window.
1654         (show_source_disasm_command): Update and remove NULL check.
1655         (show_source_or_disasm_and_command): Update.
1656
1657 2019-06-25  Tom Tromey  <tom@tromey.com>
1658
1659         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
1660
1661 2019-06-25  Tom Tromey  <tom@tromey.com>
1662
1663         * tui/tui-data.h (struct tui_win_info): Make constructor
1664         protected.  Make destructor virtual.  Add initializers.
1665         (tui_source_window, tui_data_window, tui_cmd_window): New
1666         classes.
1667         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
1668         constructor.  Add "type" parameter.
1669         (tui_source_window, tui_data_window, tui_cmd_window): New
1670         constructors.
1671         (tui_alloc_win_info): Instantiate the appropriate subclass.
1672
1673 2019-06-25  Tom Tromey  <tom@tromey.com>
1674
1675         * tui/tui-win.c (tui_resize_all): Use delete.
1676         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
1677         destructor.
1678         (tui_free_window): Don't declare.
1679         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
1680         Update.
1681
1682 2019-06-25  Tom Tromey  <tom@tromey.com>
1683
1684         * tui/tui-data.h (struct tui_win_info): Add constructor.
1685         * tui/tui-data.c (tui_alloc_win_info): Use new.
1686         (tui_free_window): Use delete.
1687
1688 2019-06-22  Tom Tromey  <tom@tromey.com>
1689
1690         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
1691         declare.
1692         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
1693
1694 2019-06-22  Tom Tromey  <tom@tromey.com>
1695
1696         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
1697         declare.
1698         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
1699
1700 2019-06-22  Tom de Vries  <tdevries@suse.de>
1701
1702         * dwarf2read.c (create_addrmap_from_aranges)
1703         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
1704         instead of '%zu'.
1705
1706 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
1707
1708         * dwarf2read.h (dwarf2_section_info_def): Remove.
1709         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
1710         * dwarf2read.c (struct dwo_sections) <types>: Change type to
1711         std::vector<dwarf2_section_info>.
1712         (struct dwo_file) <~dwo_file>: Remove.
1713         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
1714         types field.
1715         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
1716         (dwarf2_read_debug_names): Likewise.
1717         (create_debug_types_hash_table): Change parameter type to
1718         array_view, adjust code accordingly.
1719         (dwarf2_locate_dwo_sections): Adjust to std::vector.
1720         (partial_die_info::fixup): Likewise.
1721         (determine_prefix): Likewise.
1722         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
1723
1724 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1725
1726         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
1727         gdb_bfd_ref_ptr.
1728         <~dwo_file>: Remove call to gdb_bfd_unref.
1729         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
1730         gdb_bfd_ref_ptr::get.
1731
1732 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1733
1734         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
1735         type to htab_up.
1736         * dwarf2read.c (struct dwo_file): Initialize fields.
1737         <~dwo_file>: New.
1738         (free_dwo_file): Remove, move content to ~dwo_file.
1739         (struct dwo_file_deleter): Remove.
1740         (dwo_file_up>: Remove custom deleter.
1741         (free_dwo_files): Remove.
1742         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
1743         dwo_files.
1744         (process_skeletonless_type_units): Call unique_ptr::get.
1745         (allocate_dwo_file_hash_table): Add deleter to created hash
1746         table.  Change return type to htab_up.
1747         (lookup_dwo_file_slot): Don't memset dwo_file, call
1748         unique_ptr::get.
1749         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
1750         (create_dwo_unit_in_dwp_v2): Likewise.
1751         (open_and_init_dwo_file): Likewise.
1752         (free_dwo_file_from_slot): Remove.
1753
1754 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1755
1756         * dwarf2read.h (struct dwarf2_section_info) <readin,
1757         is_virtual>: Change type to bool.
1758         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
1759         true instead of 1.
1760
1761 2019-06-19  Tom Tromey  <tom@tromey.com>
1762
1763         * tui/tui-data.h (tui_init_content_element): Don't declare.
1764
1765 2019-06-19  Tom Tromey  <tom@tromey.com>
1766
1767         * tui/tui-data.h (tui_init_win_info): Don't declare.
1768
1769 2019-06-19  Tom de Vries  <tdevries@suse.de>
1770
1771         * dwarf2read.h (abstract_to_concrete): Change type to
1772         std::unordered_map<sect_offset, std::vector<sect_offset>,
1773         gdb::hash_enum<sect_offset>>.
1774
1775 2019-06-19  Tom Tromey  <tromey@adacore.com>
1776
1777         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
1778         EVAL_AVOID_SIDE_EFFECTS specially.
1779
1780 2019-06-19  Tom Tromey  <tromey@adacore.com>
1781
1782         * source-cache.c (highlighter): New global.
1783         (source_cache::get_source_lines): Create a highlighter on demand.
1784
1785 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1786
1787         * defs.h (deprecated_interactive_hook): Delete declaration.
1788         * interps.c (clear_interpreter_hooks): Remove use of
1789         deprecated_interactive_hook.
1790         * top.c (deprecated_interactive_hook): Delete definition.
1791         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
1792
1793 2019-06-18  Tom de Vries  <tdevries@suse.de>
1794
1795         PR gdb/24515
1796         * dwarf2read.h (abstract_to_concrete): Change type from
1797         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
1798         std::unordered_map<sect_offset, std::vector<sect_offset>>.
1799         * dwarf2read.c (read_variable): Update.
1800         (dwarf2_fetch_die_loc_sect_off): Update.
1801
1802 2019-06-17  Tom de Vries  <tdevries@suse.de>
1803
1804         PR gdb/24617
1805         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
1806         accessing parent[parent_len - 1].
1807
1808 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
1809
1810         PR gdb/24364
1811         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
1812         call dtrace_process_dof with NULL dof.
1813
1814 2019-06-16  Tom de Vries  <tdevries@suse.de>
1815
1816         PR gdb/24445
1817         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
1818
1819 2019-06-16  Tom Tromey  <tom@tromey.com>
1820
1821         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1822         (make_all_visible): Use address of member.
1823
1824 2019-06-16  Tom Tromey  <tom@tromey.com>
1825
1826         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
1827         (tui_free_window, free_content, free_content_elements): Remove
1828         unnecessary cast.
1829         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
1830         cast.
1831         * tui/tui-regs.c (tui_show_register_group)
1832         (tui_display_registers_from, tui_display_reg_element_at_line):
1833         Remove unnecessary cast.
1834
1835 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
1836
1837         * linux-nat.c (normal_mask): Delete.
1838         (_initialize_linux_nat): Don't initialise normal_mask.
1839
1840 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
1841
1842         PR gdb/24445
1843         * dwarf-index-write.h (write_psymtabs_to_index): Add
1844         dwz_basename parameter.
1845         * dwarf-index-write.c (write_gdbindex): Move file writing to
1846         write_gdbindex_1.  Change return type void.
1847         (assert_file_size): Move up, remove filename parameter.
1848         (write_gdbindex_1): New function.
1849         (write_debug_names): Change return type to void, call
1850         assert_file_size.
1851         (struct index_wip_file): New struct.
1852         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
1853         file logic to index_wip_file.  Write index for dwz file if
1854         needed.
1855         (save_gdb_index_command): Pass basename of dwz file, if present.
1856         * dwarf-index-cache.c (index_cache::store): Obtain and pass
1857         build-id of dwz file, if present.
1858         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
1859         (dwarf2_get_dwz_file): Likewise.
1860         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1861         (dwarf2_get_dwz_file): Likewise.
1862
1863 2019-06-16  Tom Tromey  <tom@tromey.com>
1864
1865         * coffread.c (process_coff_symbol): Use xstrdup.
1866         * value.c (create_internalvar): Use xstrdup.
1867
1868 2019-06-16  Tom Tromey  <tom@tromey.com>
1869
1870         * valops.c (value_cast, value_slice): Remove unnecessary cast.
1871         * breakpoint.c (stopin_command, stopat_command)
1872         (until_break_command, decode_location_default): Remove unnecessary
1873         cast.
1874         * utils.c (subset_compare): Remove unnecessary cast.
1875         * ada-lang.c (ada_update_initial_language): Remove unnecessary
1876         cast.
1877         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
1878         cast.
1879         * infcmd.c (path_command): Remove unnecessary cast.
1880         * coffread.c (decode_type): Remove unnecessary cast.
1881         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
1882         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
1883         * tui/tui-stack.c (tui_show_locator_content)
1884         (tui_show_frame_info): Remove unnecessary cast.
1885         * tui/tui-win.c (tui_scroll_forward_command)
1886         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
1887         (parse_scrolling_args): Remove unnecessary cast.
1888         * tui/tui-data.c (init_win_info, tui_del_window)
1889         (tui_free_window, tui_del_data_windows, tui_free_data_content)
1890         (free_content_elements): Remove unnecessary cast.
1891         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
1892         unnecessary cast.
1893         * tui/tui-source.c (tui_set_source_content)
1894         (tui_vertical_source_scroll): Remove unnecessary cast.
1895         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
1896         cast.
1897         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
1898         * tui/tui-regs.c (tui_display_registers_from)
1899         (tui_display_register): Remove unnecessary cast.
1900         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
1901         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
1902         (make_visible): Remove unnecessary cast.
1903         * tui/tui-winsource.c (tui_erase_source_content)
1904         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
1905         unnecessary cast.
1906         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
1907         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
1908         * stabsread.c (read_type, read_array_type, read_range_type):
1909         Remove unnecessary cast.
1910         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
1911         (parse_symbol, parse_type, upgrade_type, parse_external)
1912         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
1913         unnecessary cast.
1914         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
1915
1916 2019-06-16  Tom Tromey  <tom@tromey.com>
1917
1918         * tui/tui-data.c (tui_alloc_generic_win_info)
1919         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
1920         checks.
1921
1922 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
1923             Andrew Burgess  <andrew.burgess@embecosm.com>
1924
1925         * f-typeprint.c (f_print_type): Don't return early for not
1926         associated or not allocated types.
1927         (f_type_print_varspec_suffix): Add print_rank parameter and print
1928         ranks of array types in case they dangling.
1929         (f_type_print_base): Add print_rank parameter.
1930
1931 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1932
1933         * NEWS: Mention new MI commands.
1934         * break-catch-throw.c (enum exception_event_kind): Move to
1935         breakpoint.h.
1936         (print_mention_exception_catchpoint): Output text as a single
1937         message.
1938         (catch_exception_command_1): Rename to...
1939         (catch_exception_event): ...this, make non-static, update header
1940         command, and change some parameter types.
1941         (catch_catch_command): Update for changes to
1942         catch_exception_command_1.
1943         (catch_throw_command): Likewise.
1944         (catch_rethrow_command): Likewise.
1945         * breakpoint.c (enum exception_event_kind): Delete.
1946         * breakpoint.h (enum exception_event_kind): Moved here from
1947         break-catch-throw.c.
1948         (catch_exception_event): Declare.
1949         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
1950         (mi_cmd_catch_throw): New function.
1951         (mi_cmd_catch_rethrow): New function.
1952         (mi_cmd_catch_catch): New function.
1953         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
1954         'catch-catch' entries.
1955         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
1956         (mi_cmd_catch_rethrow): Declare.
1957         (mi_cmd_catch_catch): Declare.
1958
1959 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1960
1961         * annotate.c (annotate_source_line): Change return type to void,
1962         update implementation to match.
1963         * annotate.h (annotate_source_line): Change return type to void,
1964         update header comment.
1965         * stack.c (print_frame_info): Don't change what frame information
1966         is printed based on whether annotations are on or not.
1967
1968 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1969
1970         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
1971         (annotate_source): Make static.
1972         (annotate_source_line): Moved from source.c and renamed from
1973         identify_source_line.  Update the return type.
1974         * annotate.h (annotate_source): Delete declaration.
1975         (annotate_source_line): Declaration moved from source.h, and
1976         renamed from identify_source_line.  Return type updated.
1977         * source.c (identify_source_line): Moved to annotate.c and renamed
1978         to annotate_source_line.
1979         (info_line_command): Remove check of annotation_level.
1980         * source.h (identify_source_line): Move declaration to annotate.h
1981         and rename to annotate_source_line.
1982         * stack.c: Add 'annotate.h' include.
1983         (print_frame_info): Remove check of annotation_level before
1984         calling annotate_source_line.
1985
1986 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1987
1988         * source-cache.c (source_cache::get_plain_source_lines): Use
1989         open_source_file_with_line_charpos instead of just
1990         open_source_file, remove call to find_source_lines.
1991         (source_cache::get_source_lines): Likewise.
1992         * source.c (find_source_lines): Make static.
1993         (get_filename_and_charpos): Renamed into...
1994         (open_source_file_with_line_charpos): ..this along with changes to
1995         return a scoped_fd, and some other minor clean ups.
1996         (identify_source_line): Use open_source_file_with_line_charpos.
1997         (search_command_helper): Use open_source_file_with_line_charpos
1998         instead of just open_source_file, remove call to
1999         find_source_lines.
2000         * source.h (open_source_file_with_line_charpos): Declare new
2001         function.
2002         (find_source_lines): Delete declaration.
2003
2004 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2005
2006         * source.c (get_filename_and_charpos): Remove fullname
2007         parameter.
2008         (identify_source_line): Update call to get_filename_and_charpos.
2009
2010 2019-06-14  Tom Tromey  <tromey@adacore.com>
2011
2012         PR gdb/24502:
2013         * ui-style.h (skip_ansi_escape): Update comment.
2014         * ui-file.h (class no_terminal_escape_file): New class.
2015         * ui-file.c (no_terminal_escape_file::write)
2016         (no_terminal_escape_file::puts): New methods.
2017         * cli/cli-logging.c (handle_redirections): Use
2018         no_terminal_escape_file.
2019
2020 2019-06-14  Tom Tromey  <tromey@adacore.com>
2021
2022         * NEWS: Move convenience variable news above Python news.
2023
2024 2019-06-14  Tom Tromey  <tom@tromey.com>
2025
2026         * gnulib: Move directory to top-level.
2027         * configure.ac: Don't configure gnulib.
2028         * configure: Rebuild.
2029         * common/common-defs.h: Use new path to gnulib.
2030         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2031         (GNULIB_H): Remove.
2032         (INCGNU): Look in new gnulib location.
2033         (HFILES_NO_SRCDIR): Remove gnulib files.
2034         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2035         (generated_files): Remove GNULIB_H.
2036         ($(LIBGNU), all-lib): Remove targets.
2037         (distclean): Don't mention GNULIB_BUILDDIR.
2038         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2039
2040 2019-06-14  Tom Tromey  <tromey@adacore.com>
2041
2042         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2043         Warn if symbol file does not provide any symbols.
2044
2045 2019-06-14  Tom Tromey  <tromey@adacore.com>
2046
2047         * source.c (find_and_open_source): Respect basenames_may_differ.
2048
2049 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2050
2051         * annotate.c (annotate_breakpoints_invalid): Make use of
2052         scoped_restore_terminal_state.
2053         (annotate_frames_invalid): Likewise.
2054
2055 2019-06-14  Tom Tromey  <tromey@adacore.com>
2056
2057         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2058         allow assignment to an internalvar.
2059
2060 2019-06-14  Tom Tromey  <tromey@adacore.com>
2061
2062         * ada-lex.l: Allow "_" in attribute names.
2063
2064 2019-06-14  Tom Tromey  <tromey@adacore.com>
2065
2066         PR gdb/24653:
2067         * regcache.c (registers_changed): Don't call alloca.
2068         * top.c (execute_command): Don't call alloca.
2069
2070 2019-06-13  Pedro Alves  <palves@redhat.com>
2071
2072         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2073         'expression'.  When parsing an expression, error out if there's
2074         junk after "unlimited".
2075         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2076         (do_set_command): Adjust calls to is_unlimited_literal.
2077
2078 2019-06-13  Pedro Alves  <palves@redhat.com>
2079
2080         * compile/compile.c (make_compile_options_def_group): Add braces
2081         around array_view initializer.
2082         * thread.c (make_thread_apply_all_options_def_group)
2083         (make_thread_apply_all_options_def_group): Likewise.
2084
2085 2019-06-13  Pedro Alves  <palves@redhat.com>
2086
2087         * NEWS (New commands): Mention "maint test-options
2088         require-delimiter", "maint test-options unknown-is-error", "maint
2089         test-options unknown-is-operand" and "maint show
2090         test-options-completion-result".
2091         (New command options, command completion): New section.
2092         (Completion improvements): New section.
2093         Mention that you can abbreviate "unlimited".
2094
2095 2019-06-13  Pedro Alves  <palves@redhat.com>
2096
2097         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2098         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2099         * unittests/cli-utils-selftests.c (test_parse_flags)
2100         (test_parse_flags_qcs): Delete.
2101         (test_cli_utils): Don't call deleted functions.
2102
2103 2019-06-13  Pedro Alves  <palves@redhat.com>
2104
2105         * thread.c: Include "cli/cli-option.h".
2106         (tp_array_compar_ascending): Global.
2107         (tp_array_compar): Delete function.
2108         (tp_array_compar_ascending, tp_array_compar_descending): New
2109         functions.
2110         (ascending_option_def, qcs_flag_option_def)
2111         (thr_qcs_flags_option_defs)
2112         (make_thread_apply_all_options_def_group)
2113         (make_thread_apply_options_def_group): New.
2114         (thread_apply_all_command): Use gdb::option::process_options.
2115         (thread_apply_command_completer)
2116         (thread_apply_all_command_completer): New.
2117         (thread_apply_command): Use gdb::option::process_options.
2118         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2119         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2120         to generate help text of "thread apply".  Adjust "taas"'s help.
2121         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2122         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2123
2124 2019-06-13  Pedro Alves  <palves@redhat.com>
2125
2126         * thread.c (thread_apply_command): Check for invalid TID with
2127         isdigit instead of !isalpha.
2128
2129 2019-06-13  Pedro Alves  <palves@redhat.com>
2130
2131         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2132         (validate_flags_qcs): New.
2133         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2134         (validate_flags_qcs): Declare.
2135         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2136         (make_frame_apply_options_def_group): New.
2137         (frame_apply_command_count): Process options with
2138         gdb::option::process_options.
2139         (frame_apply_completer): New.
2140         (frame_apply_level_completer, frame_apply_all_completer)
2141         (frame_apply_completer): New.
2142         (_initialize_stack): Update help of "frame apply", "frame apply
2143         level", "frame apply all" and "faas" to mention supported options
2144         and install command completers.
2145         * stack.h (frame_apply_all_completer): Declare.
2146         * thread.c: Include "stack.h".
2147         (tfaas_command): Add "--".
2148         (_initialize_thread): Update help "tfaas" to mention supported
2149         options and install command completer.
2150
2151 2019-06-13  Pedro Alves  <palves@redhat.com>
2152
2153         * completer.c (complete_nested_command_line): New.
2154         (gdb_completion_word_break_characters_throw): Add assertion.
2155         * completer.h (complete_nested_command_line): Declare.
2156
2157 2019-06-13  Pedro Alves  <palves@redhat.com>
2158
2159         * stack.c (parse_backtrace_qualifiers): New.
2160         (backtrace_command): Use it.
2161         (backtrace_command_completer): Complete on qualifiers.
2162
2163 2019-06-13  Pedro Alves  <palves@redhat.com>
2164
2165         * frame.c: Include "cli/cli-option.h.
2166         (user_set_backtrace_options): New.
2167         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2168         Delete.
2169         (get_prev_frame): Adjust.
2170         (boolean_option_def, uinteger_option_def)
2171         (set_backtrace_option_defs): New.
2172         (_initialize_frame): Adjust and use
2173         gdb::option::add_setshow_cmds_for_options to install "set
2174         backtrace past-main" and "set backtrace past-entry".
2175         * frame.h: Include "cli/cli-option.h".
2176         (struct frame_print_options): Forward declare.
2177         (print_frame_arguments_all, print_frame_arguments_scalars)
2178         (print_frame_arguments_none): Declare.
2179         (print_entry_values): Delete declaration.
2180         (struct frame_print_options, user_frame_print_options): New.
2181         (struct set_backtrace_options): New.
2182         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2183         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2184         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2185         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2186         (list_args_or_locals): Add frame_print_options parameter.
2187         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2188         * python/py-framefilter.c (enumerate_args): Pass down
2189         USER_FRAME_PRINT_OPTIONS.
2190         * stack.c: Include "cli/cli-option.h".
2191         (print_frame_arguments_all, print_frame_arguments_scalars)
2192         (print_frame_arguments_none): Declare.
2193         (print_raw_frame_arguments, print_entry_values): Delete.
2194         (user_frame_print_options): New.
2195         (boolean_option_def, enum_option_def, frame_print_option_defs):
2196         New.
2197         (struct backtrace_cmd_options): New.
2198         (bt_flag_option_def): New.
2199         (backtrace_command_option_defs): New.
2200         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2201         (print_frame_arg, read_frame_arg, print_frame_args)
2202         (print_frame_info, print_frame): Add frame_print_options parameter
2203         and use it.
2204         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2205         (backtrace_command_1): Add frame_print_options and
2206         backtrace_cmd_options parameters and use them.
2207         (make_backtrace_options_def_group): New.
2208         (backtrace_command): Process command options with
2209         gdb::option::process_options.
2210         (backtrace_command_completer): New.
2211         (_initialize_stack): Extend "backtrace"'s help to mention
2212         supported options.  Install completer for "backtrace".
2213         Install some settings commands with add_setshow_cmds_for_options.
2214
2215 2019-06-13  Pedro Alves  <palves@redhat.com>
2216
2217         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2218         and that "set/show print raw frame-arguments" are now deprecated.
2219
2220         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2221         command.
2222         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2223         * stack.c (_initialize_stack): Install "set/show print
2224         raw-frame-arguments", and deprecate "set/show print raw
2225         frame-arguments".
2226         * valprint.c (_initialize_valprint): Deprecate "set/show print
2227         raw".
2228
2229 2019-06-13  Pedro Alves  <palves@redhat.com>
2230
2231         * compile/compile.c (struct compile_options): New.
2232         (compile_flag_option_def, compile_command_option_defs)
2233         (make_compile_options_def_group): New.
2234         (compile_file_command): Handle options with
2235         gdb::option::process_options.
2236         (compile_file_command_completer): New function.
2237         (compile_code_command): Handle options with
2238         gdb::option::process_options.
2239         (compile_code_command_completer): New function.
2240         (_initialize_compiler): Install completers for "compile code" and
2241         "compile file".  Mention available options in "compile code" and
2242         "compile code"'s help.
2243         * completer.c (advance_to_completion_word): New, factored out from
2244         ...
2245         (advance_to_expression_complete_word_point): ... this.
2246         (advance_to_filename_complete_word_point): New.
2247         * completer.h (advance_to_filename_complete_word_point): New
2248         declaration.
2249
2250 2019-06-13  Pedro Alves  <palves@redhat.com>
2251
2252         * compile/compile.c: Include "cli/cli-option.h".
2253         (compile_print_value): Scope data pointer is now a
2254         value_print_options pointer; adjust.
2255         (compile_print_command): Process options.  Scope data pointer is
2256         now a value_print_options pointer; adjust.
2257         (_initialize_compile): Update "compile print"'s help to include
2258         supported options.  Install a completer for "compile print".
2259         * cp-valprint.c (show_vtblprint, show_objectprint)
2260         (show_static_field_print): Delete.
2261         (_initialize_cp_valprint): Don't install "set print
2262         static-members", "set print vtbl", "set print object" here.
2263         * printcmd.c: Include "cli/cli-option.h" and
2264         "common/gdb_optional.h".
2265         (print_command_parse_format): Rework to fill in a
2266         value_print_options instead of a format_data.
2267         (print_value): Change parameter type from format_data pointer to
2268         value_print_options reference.  Adjust.
2269         (print_command_1): Process options.  Adjust to pass down a
2270         value_print_options.
2271         (print_command_completer): New.
2272         (_initialize_printcmd): Install print_command_completer as
2273         handle_brkchars completer for the "print" command.  Update
2274         "print"'s help to include supported options.
2275         * valprint.c: Include "cli/cli-option.h".
2276         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2277         here from cp-valprint.c.
2278         (boolean_option_def, uinteger_option_def)
2279         (value_print_option_defs, make_value_print_options_def_group):
2280         New.  Use gdb::option::add_setshow_cmds_for_options to install
2281         "set print elements", "set print null-stop", "set print repeats",
2282         "set print pretty", "set print union", "set print array", "set
2283         print address", "set print symbol", "set print array-indexes".
2284         * valprint.h: Include <string> and "cli/cli-option.h".
2285         (make_value_print_options_def_group): Declare.
2286         (print_value): Change parameter type from format_data pointer to
2287         value_print_options reference.
2288         (print_command_completer): Declare.
2289
2290 2019-06-13  Pedro Alves  <palves@redhat.com>
2291
2292         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2293         (COMMON_SFILES): Add maint-test-settings.c.
2294         * cli/cli-decode.c (boolean_enums): New global, factored out from
2295         ...
2296         (add_setshow_boolean_cmd): ... here.
2297         * cli/cli-decode.h (boolean_enums): Declare.
2298         * cli/cli-option.c: New file.
2299         * cli/cli-option.h: New file.
2300         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2301         factored out from ...
2302         (parse_cli_boolean_value(const char *)): ... this.
2303         (is_unlimited_literal): Change parameter type to pointer to
2304         pointer.  Adjust and advance ARG pointer.
2305         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2306         (parse_cli_var_enum): New, factored out from ...
2307         (do_set_command): ... this.  Adjust.
2308         * cli/cli-setshow.h (parse_cli_boolean_value)
2309         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2310         (parse_cli_var_enum): Declare.
2311         * cli/cli-utils.c: Include "cli/cli-option.h".
2312         (get_ulongest): New.
2313         * cli/cli-utils.h (get_ulongest): Declare.
2314         (check_for_argument): New overloads.
2315         * maint-test-options.c: New file.
2316
2317 2019-06-13  Pedro Alves  <palves@redhat.com>
2318
2319         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2320         parse a range if "-" is at the end of the string.
2321
2322 2019-06-13  Pedro Alves  <palves@redhat.com>
2323
2324         * cli/cli-setshow.c (parse_auto_binary_operation)
2325         (parse_cli_boolean_value): Don't allow "o".
2326
2327 2019-06-13  Pedro Alves  <palves@redhat.com>
2328
2329         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2330         * NEWS: Mention maint test-settings KIND.
2331         * maint-test-settings.c: New file.
2332
2333 2019-06-13  Pedro Alves  <palves@redhat.com>
2334
2335         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2336         completer.
2337         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2338         "set" completers.
2339
2340 2019-06-13  Pedro Alves  <palves@redhat.com>
2341
2342         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2343         after item.
2344
2345 2019-06-13  Pedro Alves  <palves@redhat.com>
2346
2347         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2348
2349 2019-06-13  Pedro Alves <palves@redhat.com>
2350
2351         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2352         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2353         call.
2354         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2355         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2356         calls.
2357         (check_for_argument): Skip spaces after argument.
2358
2359 2019-06-13  Pedro Alves  <palves@redhat.com>
2360
2361         * thread.c (thread_apply_command): Adjust TID parsing.
2362         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2363         detected before end of string.
2364         (tid_is_in_list): Error out if LIST is invalid.
2365
2366 2019-06-13  Pedro Alves  <palves@redhat.com>
2367
2368         * completer.c (complete_line_internal_1): Rewind completion word
2369         point.
2370         (completion_tracker::advance_custom_word_point_by): Change
2371         parameter type to int.
2372         * completer.h (completion_tracker::advance_custom_word_point_by):
2373         Likewise.
2374
2375 2019-06-13  Pedro Alves  <palves@redhat.com>
2376
2377         * completer.c (advance_to_completion_word): Handle delimiters.
2378
2379 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2380
2381         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2382
2383 2019-06-11  Tom Tromey  <tom@tromey.com>
2384
2385         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2386         (xmalloc_failed): Move to alloc.c.
2387         * alloc.c: New file.
2388         * Makefile.in (COMMON_SFILES): Add alloc.c.
2389
2390 2019-06-11  Tom Tromey  <tom@tromey.com>
2391
2392         * nat/linux-waitpid.c: Don't include server.h.
2393         (linux_debug): Remove.
2394         (my_waitpid): Update.
2395
2396 2019-06-11  Tom Tromey  <tromey@adacore.com>
2397
2398         * infcall.c (_initialize_infcall): Remove trailing newline from
2399         help.
2400         * user-regs.c (_initialize_user_regs): Remove trailing newline
2401         from help.
2402         * typeprint.c (_initialize_typeprint): Remove trailing newline
2403         from help.
2404         * reverse.c (_initialize_reverse): Remove trailing newlines from
2405         help.
2406         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2407         from help.
2408         * language.c (add_set_language_command): Remove trailing newline
2409         from help.
2410         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2411         help.
2412         * disasm.c (_initialize_disasm): Remove trailing newline from
2413         help.
2414         * top.c (init_main): Remove trailing newline from help.
2415         * interps.c (_initialize_interpreter): Remove trailing newline
2416         from help.
2417         * btrace.c (_initialize_btrace): Remove trailing newlines from
2418         help.
2419         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2420         from help.
2421         * python/python.c (_initialize_python): Remove trailing newline
2422         from help.
2423         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2424         help.
2425         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2426         from help.  Reformat some text.
2427         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2428         from help.
2429         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2430         newline from help.
2431
2432 2019-06-11  Tom Tromey  <tromey@adacore.com>
2433
2434         * darwin-nat.c (darwin_decode_exception_message)
2435         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2436
2437 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2438
2439         * valops.c (value_slice): Check for not allocated or not
2440         associated values.
2441
2442 2019-06-10  Tom de Vries  <tdevries@suse.de>
2443
2444         PR gdb/24618
2445         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2446         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2447         invalid.
2448
2449 2019-06-10  Tom de Vries  <tdevries@suse.de>
2450
2451         PR gdb/24611
2452         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2453         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2454
2455 2019-06-10  Tom de Vries  <tdevries@suse.de>
2456
2457         PR symtab/24545
2458         * symtab.c (struct demangled_name_entry): Add language field.
2459         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2460         static minimal symbol".  Set and use language field.
2461
2462 2019-06-10  Tom Tromey  <tromey@adacore.com>
2463
2464         * ada-lang.c (_initialize_ada_language): Update help text.
2465
2466 2019-06-10  Tom Tromey  <tromey@adacore.com>
2467
2468         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2469         with a newline.
2470         * guile/guile.c (handle_boot_error): Don't end warning with a
2471         newline.
2472         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2473         warning with a newline.
2474         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2475         newline.
2476         (s12z_frame_cache): Likewise.
2477         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2478         a newline.
2479         * solib-svr4.c (disable_probes_interface): Don't end warning with
2480         a newline.
2481         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2482         newline.
2483         * python/python.c (do_finish_initialization): Don't end warning
2484         with a newline.
2485
2486 2019-06-10  Tom Tromey  <tom@tromey.com>
2487
2488         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2489         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2490         gdbpy_enter.
2491
2492 2019-06-10  Tom Tromey  <tromey@adacore.com>
2493
2494         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2495         data.
2496         (elf_new_init): Don't call stabsread_new_init.
2497         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2498         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2499         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2500
2501 2019-06-10  Tom de Vries  <tdevries@suse.de>
2502
2503         PR symtab/16264
2504         PR symtab/24517
2505         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2506
2507 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2508
2509         * source.c (find_and_open_source): Also rewrite relative file
2510         names.
2511
2512 2019-04-26  Amos Bird  <amosbird@gmail.com>
2513
2514         * annotate.c (annotate_thread_exited): Add "thread-exited"
2515         annotation.
2516
2517 2019-06-06  Tom Tromey  <tromey@adacore.com>
2518
2519         * maint.h (class scoped_command_stats): Use
2520         DISABLE_COPY_AND_ASSIGN.
2521         <print_time>: New method.
2522         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2523         print_time.
2524         (scoped_command_stats::print_time): New method.
2525
2526 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2527
2528         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2529         instructions of lengths 6 or 8 bytes.
2530
2531 2019-06-04  Pedro Alves  <palves@redhat.com>
2532
2533         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2534
2535         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2536         * breakpoint.c (condition_completer): Likewise.
2537         * cli/cli-dump.c (scan_expression): Likewise.
2538         * common/filestuff.c (mkdir_recursive): Likewise.
2539         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2540         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2541         (gdb_abspath): Likewise.
2542         * compile/compile-cplus-types.c
2543         (compile_cplus_instance::decl_name): Likewise.
2544         * completer.c (complete_explicit_location):
2545         (signal_completer, reg_or_group_completer_1): Likewise.
2546         * cp-support.c (cp_remove_params_if_any): Likewise.
2547         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2548         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2549         * infcmd.c (strip_bg_char): Likewise.
2550         * linespec.c (copy_token_string): Likewise.
2551         * mi/mi-main.c (output_cores): Likewise.
2552         * psymtab.c (psymtab_search_name):
2553         * symfile.c (test_set_ext_lang_command): Likewise.
2554         * target.c (target_fileio_read_stralloc): Likewise.
2555         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2556         * value.c (complete_internalvar): Likewise.
2557
2558 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
2559
2560         Add objfile property to gdb.Type.
2561         * NEWS: Mention Python API addition.
2562         * python/py-type.c (typy_get_objfile): New method.
2563
2564 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2565
2566         * NEWS: Mention the new set|show style [title|highlight].
2567         Mention changes to "show style", "help" and "apropos".
2568
2569 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2570
2571         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
2572         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
2573         instead of print_help_for_command.
2574         (print_doc_of_command): New function.
2575         (help_list): Add 'apropos -v word' suggestion.
2576         (print_help_for_command): Style the command name using title style.
2577         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
2578         (_initialize_cli_cmds): Describe -v in apropos_command help.
2579
2580 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2581
2582         * cli/cli-style.h (cli_style_option): Add name in constructor,
2583         add m_name class member, add constructor with intensity,
2584         add name class function.
2585         (cli_style_option::add_setshow_commands): Remove name argument.
2586         (highlight_style, title_style): New styles.
2587         * cli/cli-style.c (do_show): New function that shows a style
2588         characteristic styling the style name with itself.
2589         (set_style_name): New function.
2590         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
2591         Update all callers according to the changes in cli/cli-style.h.
2592         * utils.h (fputs_highlighted): New function.
2593         * utils.c (fputs_highlighted): Likewise.
2594
2595 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2596
2597         * NEWS: Mention new pipe command and new convenience variables.
2598
2599 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2600
2601         * cli/cli-cmds.c (pipe_command): New function.
2602         (_initialize_cli_cmds): Call add_com for pipe_command.
2603         Define | as an alias for pipe.
2604         (exit_status_set_internal_vars): New function.
2605         (shell_escape): Call exit_status_set_internal_vars.
2606         cli/cli-decode.c (find_command_name_length): Recognize | as
2607         a single character command.
2608
2609 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2610
2611         * gdbcmd.h (execute_command_to_ui_file): New declaration.
2612         top.c (execute_command_to_ui_file): New function, mostly a copy
2613         of execute_command_to_string.
2614         (execute_command_to_string): Implement by calling
2615         execute_command_to_ui_file.
2616
2617 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2618
2619         * top.h (saved_command_line): Remove declaration.
2620         * top.c (previous_saved_command_line, previous_repeat_arguments):
2621         New variables.
2622         (saved_command_line): Make static, define together with other
2623         'repeat variables'.
2624         (dont_repeat): Clear repeat_arguments.
2625         (repeat_previous, get_saved_command_line, save_command_line):
2626         New functions.
2627         (gdb_init): Initialize saved_command_line
2628         and previous_saved_command_line.
2629         * main.c (captured_main_1): Remove saved_command_line initialization.
2630         * event-top.c (handle_line_of_input): Update to use
2631         the new 'repeat' related functions instead of direct access to
2632         saved_command_line.
2633         * command.h (repeat_previous, get_saved_command_line,
2634         save_command_line): New declarations.
2635         (dont_repeat): Add comment.
2636
2637 2019-05-30  Tom Tromey  <tromey@adacore.com>
2638
2639         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
2640         Fix comment.
2641         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
2642
2643 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
2644
2645         PR cli/24587
2646         * completer.c (complete): Initialize variable word.
2647
2648 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
2649
2650         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2651         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
2652         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
2653         'body' is NULL to the outter 'if', protecting the '!is_define'
2654         situation as well.
2655
2656 2019-05-29  Tom Tromey  <tromey@adacore.com>
2657
2658         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
2659         (dwarf_unknown): New function.
2660         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
2661         (dwarf_type_encoding_name): Use dwarf_unknown.
2662
2663 2019-05-29  Tom Tromey  <tromey@adacore.com>
2664
2665         PR c++/20020:
2666         * cp-valprint.c (cp_print_value_fields): Call
2667         cp_print_static_field inside "try".
2668
2669 2019-05-29  Tom Tromey  <tromey@adacore.com>
2670
2671         * inflow.c (struct terminal_info): Add default operator=.
2672         * configure: Rebuild.
2673         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
2674         -Wdeprecated-copy-dtor, -Wredundant-move.
2675
2676 2019-05-29  Tom Tromey  <tromey@adacore.com>
2677
2678         * NEWS: Add entry.
2679         * infcmd.c (print_return_value_1): Handle finish_print
2680         option.
2681         (show_print_finish): New function.
2682         (_initialize_infcmd): Add "set/show print finish" commands.
2683         * valprint.c (user_print_options): Initialize new member.
2684         * valprint.h (struct value_print_options) <finish_print>: New
2685         member.
2686
2687 2019-05-28  Tom Tromey  <tromey@adacore.com>
2688
2689         * ada-lang.c (ada_remove_Xbn_suffix)
2690         (find_old_style_renaming_symbol)
2691         (parse_old_style_renaming): Remove.
2692         (ada_find_renaming_symbol): Don't call
2693         find_old_style_renaming_symbol.
2694         (ada_is_renaming_symbol): Rename from
2695         ada_find_renaming_symbol.  Remove "block" parameter.  Return
2696         bool.  Now static.
2697         (ada_read_var_value): Update and simplify.
2698         * ada-exp.y (write_var_or_type): Remove old code.
2699
2700 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
2701
2702         * event-top.c: Remove include comment.
2703         * inflow.c (class scoped_ignore_sigttou): Move from here...
2704         * inflow.h (class scoped_ignore_sigttou): ...to here.
2705         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
2706         * top.c:  Remove include comment.
2707
2708 2019-05-27  Tom Tromey  <tom@tromey.com>
2709
2710         * NEWS: Fix typo.
2711
2712 2019-05-22  Tom Tromey  <tromey@adacore.com>
2713
2714         * target.c (target_follow_exec): Constify parameter.
2715         * target-delegates.c: Rebuild.
2716         * remote.c (remote_target::follow_exec): Constify parameter.
2717         * infrun.c (follow_exec): Constify parameter.
2718         * target.h (struct target_ops) <follow_exec>: Constify parameter.
2719         (target_follow_exec): Likewise.
2720
2721 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2722
2723         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
2724         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
2725
2726 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2727
2728         * NEWS: Add debugredirect and testsuite sections.
2729
2730 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
2731
2732         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
2733         target descriptions using exclusively floating point register name
2734         aliases.
2735
2736 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2737
2738         PR gdb/18644:
2739         * f-lang.c (build_fortran_types): Handle the case where
2740         gdbarch_floatformat_for_type returns a nullptr.
2741
2742 2019-05-21  Tom de Vries  <tdevries@suse.de>
2743
2744         PR cli/24587
2745         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
2746
2747 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2748
2749         PR gdb/18644:
2750         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
2751         16-byte floats.
2752         * i386-tdep.c (i386_floatformat_for_type): Use
2753         floatformats_ia64_quad for the 16-byte floating point component
2754         within a fortran 32-byte complex number.
2755
2756 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2757
2758         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
2759         delete default constructor.
2760         (find_partial_die): Update to return const struct.
2761         (partial_die_parent_scope): Move variable declaration into scope
2762         of its use and change its type to auto.
2763         (guess_partial_die_structure_name): Likewise.
2764         (partial_die_info::fixup): Likewise.
2765
2766 2019-05-17  Tom Tromey  <tromey@adacore.com>
2767
2768         * source.c (find_and_open_source): Remove cast.
2769
2770 2019-05-17  Tom Tromey  <tromey@adacore.com>
2771
2772         * annotate.c (annotate_source): Make "filename" const.
2773         * annotate.h (annotate_source): Use const.
2774
2775 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2776
2777         * disasm.c (set_disassembler_options): Send errors to stderr.
2778
2779 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2780
2781         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
2782         (cli_interp_base::set_logging): Check debug_redirect.
2783         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
2784         * cli/cli-logging.c (debug_redirect): Add static variable.
2785         (pop_output_files): Add default param.
2786         (handle_redirections): Print debug setting.
2787         (show_logging_command): Likewise.
2788         (_initialize_cli_logging): Add debugredirect command.
2789         * interps.c (current_interp_set_logging): Add debug_redirect
2790         parameter.
2791         * interps.h (set_logging): Add debug_redirect parameter.
2792         (current_interp_set_logging): Likewise.
2793         * mi/mi-common.h: Likewise.
2794         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
2795
2796 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2797             Tom Tromey  <tromey@adacore.com>
2798
2799         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
2800         directly.
2801         * cli/cli-interp.h (make_logging_output): Remove declaration.
2802         * cli/cli-logging.c (make_logging_output): Remove function.
2803         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
2804         directly.
2805         * ui-file.c (tee_file::tee_file): Remove bools.
2806         (tee_file::~tee_file): Remove deletes.
2807         * ui-file.h (tee_file): Remove bools.
2808
2809 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
2810
2811         * mi/mi-cmds.h (mi_cmd_complete): New function.
2812         * mi/mi-main.c (mi_cmd_complete): Likewise.
2813         * mi/mi-cmds.c: Define new MI command -complete.
2814         * NEWS: Mention new -complete command.
2815
2816 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
2817
2818         * completer.h (complete): New function.
2819         * completer.c (complete): Likewise.
2820         * cli/cli-cmds.c: (complete_command): Update to use new complete()
2821         function defined in completer.h.
2822
2823 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
2824
2825         * MAINTAINERS (Write After Approval): Add myself.
2826
2827 2019-05-17  Tom de Vries  <tdevries@suse.de>
2828
2829         PR gdb/24094
2830         * dwarf2read.c (struct cu_partial_die_info): New struct.
2831         (find_partial_die): Return cu_partial_die_info.
2832         (partial_die_parent_scope, guess_partial_die_structure_name)
2833         (partial_die_info::fixup): Handle new return type of find_partial_die.
2834
2835 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2836
2837         * stap-probe.c (stap_parse_register_operand): Make "regname" an
2838         "std::string", simplifying the algorithm.
2839
2840 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2841
2842         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
2843         (stap_static_probe_ops::get_probes): Likewise.
2844
2845 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2846
2847         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
2848         '-')" and "else if".
2849         (stap_parse_single_operand): Join checks for
2850         "gdbarch_stap_parse_special_token_p" and
2851         "gdbarch_stap_parse_special_token" in the same "if" statement.
2852         Invert check when verifying for operation on register
2853         displacement.
2854
2855 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2856
2857         * stap-probe.c (stap_get_opcode): Update comment.
2858         (stap_get_expected_argument_type): Likewise.
2859         (handle_stap_probe): Likewise.
2860
2861 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2862
2863         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2864         return type to 'bool'.  Adjust comment.  Use 'bool' when
2865         appropriate.
2866         (i386_stap_parse_special_token_three_arg_disp): Likewise.
2867         * stap-probe.c (stap_parse_argument_1): Likewise.
2868         (stap_is_operator): Likewise.
2869         (stap_is_generic_prefix): Likewise.
2870         (stap_is_register_prefix): Likewise.
2871         (stap_is_register_indirection_prefix): Likewise.
2872         (stap_is_integer_prefix): Likewise.
2873         (stap_generic_check_suffix): Likewise.
2874         (stap_check_integer_suffix): Likewise.
2875         (stap_check_register_suffix): Likewise.
2876         (stap_check_register_indirection_suffix): Likewise.
2877         (stap_parse_register_operand): Likewise.
2878         (stap_parse_single_operand): Likewise.
2879         (stap_parse_argument_1): Likewise.
2880         (stap_probe::get_argument_count): Likewise.
2881         (stap_is_operator): Likewise.
2882
2883 2019-05-16  Tom Tromey  <tromey@adacore.com>
2884
2885         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
2886         keyword to foreach.
2887
2888 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
2889
2890         * linux-thread-db.c (try_thread_db_load_1): Change return type
2891         to bool.
2892         (try_thread_db_load): Likewise.
2893         (try_thread_db_load_from_pdir_1): Likewise.
2894         (try_thread_db_load_from_pdir): Likewise.
2895         (try_thread_db_load_from_sdir): Likewise.
2896         (try_thread_db_load_from_dir): Likewise.
2897         (thread_db_load_search): Likewise.
2898         (has_libpthread): Likewise.
2899         (thread_db_load): Likewise.
2900
2901 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
2902
2903         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2904         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
2905         NULL, and complain/return if that's the case.
2906
2907 2019-05-15  John Darrington <john@darrington.wattle.id.au>
2908
2909         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
2910         (advance, posn, abstract_read_memory): New functions.
2911         [struct mem_read_abstraction]: New struct.
2912         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
2913
2914 2019-05-14  Tom Tromey  <tromey@adacore.com>
2915
2916         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
2917         value is not lval_memory.
2918
2919 2019-05-14  Tom Tromey  <tromey@adacore.com>
2920
2921         * solib.c (info_sharedlibrary_command): Style the file name.
2922
2923 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
2924
2925         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
2926         (aarch64_vnv_type): Likewise.
2927         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
2928         * common/tdesc.c: Likewise.
2929         * common/tdesc.h (enum tdesc_type_kind): Likewise.
2930         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
2931         * features/aarch64-fpu.xml: Add ieee half view.
2932         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
2933         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
2934         * gdbtypes.h (struct builtin_type): Likewise.
2935         (struct objfile_type): Likewise.
2936
2937 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
2938
2939         * language.c (language_sniff_from_mangled_name): Fix "langauge"
2940         typo.
2941         * location.h (string_to_event_location): Likewise.
2942
2943 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
2944
2945         GDB 8.3 released.
2946
2947 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2948
2949         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
2950         New variable declaration.
2951         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
2952         New variable.
2953         (print_one_breakpoint): Use ui_out::test_flags and new global
2954         variable to compute use_fixed_output.
2955         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
2956         Remove.
2957         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
2958         (mi_multi_location_breakpoint_output_fixed): Remove.
2959         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
2960         new variable.
2961         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
2962         fix_multi_location_breakpoint_output flag if version >= 3.
2963         * ui-out.h (enum ui_out_flag)
2964         <fix_multi_location_breakpoint_output>: New enumerator.
2965
2966 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2967
2968         * contrib/cc-with-tweaks.sh: Validate dwz's work.
2969
2970 2019-05-10  Tom Tromey  <tromey@adacore.com>
2971
2972         * ada-lang.c (catch_ada_completer): New function.
2973         (_initialize_ada_language): Use it.
2974
2975 2019-05-10  Tom Tromey  <tromey@adacore.com>
2976
2977         * thread.c (print_thread_info): Make "requested_threads" const.
2978         * gdbthread.h (print_thread_info): Make "requested_threads"
2979         const.
2980         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
2981         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
2982
2983 2019-05-08  Tom Tromey  <tom@tromey.com>
2984
2985         * gdbtypes.c (objfile_type_data): Change type.
2986         (objfile_type, _initialize_gdbtypes): Update.
2987
2988 2019-05-08  Tom Tromey  <tom@tromey.com>
2989
2990         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
2991         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
2992         (_initialize_dwarf2_frame): Update.
2993
2994 2019-05-08  Tom Tromey  <tom@tromey.com>
2995
2996         * objc-lang.c (objc_objfile_data): Change type.
2997         (find_methods): Update.
2998         (_initialize_objc_lang): Remove.
2999
3000 2019-05-08  Tom Tromey  <tom@tromey.com>
3001
3002         * stabsread.c (rs6000_builtin_type_data): Change type.
3003         (rs6000_builtin_type, _initialize_stabsread): Update.
3004
3005 2019-05-08  Tom Tromey  <tom@tromey.com>
3006
3007         * mips-tdep.c (mips_pdr_data): Remove.
3008         (_initialize_mips_tdep): Update.
3009
3010 2019-05-08  Tom Tromey  <tom@tromey.com>
3011
3012         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3013         (hppa_init_objfile_priv_data, read_unwind_info)
3014         (find_unwind_entry, _initialize_hppa_tdep): Update.
3015
3016 2019-05-08  Tom Tromey  <tom@tromey.com>
3017
3018         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3019         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3020         on obstack.
3021         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3022
3023 2019-05-08  Tom Tromey  <tom@tromey.com>
3024
3025         * mdebugread.c (basic_type_data): Change type.
3026         (basic_type, _initialize_mdebugread): Update.
3027
3028 2019-05-08  Tom Tromey  <tom@tromey.com>
3029
3030         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3031
3032 2019-05-08  Tom Tromey  <tom@tromey.com>
3033
3034         * nto-tdep.c (nto_inferior_data_reg): Change type.
3035         (nto_inferior_data): Update.
3036         (nto_inferior_data_cleanup, nto_new_inferior_data)
3037         (_initialize_nto_tdep): Remove.
3038         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3039
3040 2019-05-08  Tom Tromey  <tom@tromey.com>
3041
3042         * ada-lang.c (struct ada_inferior_data): Add initializers.
3043         (ada_inferior_data): Change type.
3044         (ada_inferior_data_cleanup): Remove.
3045         (get_ada_inferior_data, ada_inferior_exit)
3046         (struct ada_pspace_data): Add initializers, destructor.
3047         (ada_pspace_data_handle): Change type.
3048         (get_ada_pspace_data): Update.
3049         (ada_pspace_data_cleanup): Remove.
3050
3051 2019-05-08  Tom Tromey  <tom@tromey.com>
3052
3053         * coffread.c (struct coff_symfile_info): Add initializers.
3054         (coff_objfile_data_key): Move lower.  Change type.
3055         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3056         Update.
3057         (coff_free_info): Remove.
3058
3059 2019-05-08  Tom Tromey  <tom@tromey.com>
3060
3061         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3062         (fbsd_pspace_data_handle): Move lower.  Change type.
3063         (get_fbsd_pspace_data): Update.
3064         (fbsd_pspace_data_cleanup): Remove.
3065         (_initialize_fbsd_tdep): Update.
3066
3067 2019-05-08  Tom Tromey  <tom@tromey.com>
3068
3069         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3070         (get_ada_tasks_pspace_data): Update.
3071         (ada_tasks_pspace_data_cleanup): Remove.
3072         (_initialize_tasks): Update.
3073         (ada_tasks_inferior_data_handle): Change type.
3074         (get_ada_tasks_inferior_data): Update.
3075         (ada_tasks_inferior_data_cleanup): Remove.
3076         (struct ada_tasks_pspace_data): Add initializers.
3077
3078 2019-05-08  Tom Tromey  <tom@tromey.com>
3079
3080         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3081         * symfile-debug.c (debug_sym_get_probes): Change type.
3082         * stap-probe.c (handle_stap_probe):
3083         (stap_static_probe_ops::get_probes): Change type.
3084         * probe.h (class static_probe_ops) <get_probes>: Change type.
3085         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3086         (parse_probes_in_pspace): Update.
3087         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3088         Update.
3089         (any_static_probe_ops::get_probes): Change type.
3090         * elfread.c (elfread_data): New typedef.
3091         (probe_key): Change type.
3092         (elf_get_probes): Likewise.  Update.
3093         (probe_key_free): Remove.
3094         (_initialize_elfread): Update.
3095         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3096         Change type.
3097         (dtrace_process_dof_probe, dtrace_process_dof)
3098         (dtrace_static_probe_ops::get_probe): Change type.
3099
3100 2019-05-08  Tom Tromey  <tom@tromey.com>
3101
3102         * xcoffread.c (struct xcoff_symfile_info): Rename from
3103         coff_symfile_info.  Add initializers.
3104         (xcoff_objfile_data_key): Move lower.  Change type.
3105         (XCOFF_DATA): Rewrite.
3106         (xcoff_free_info): Remove.
3107         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3108         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3109         (xcoff_initial_scan): Update.
3110
3111 2019-05-08  Tom Tromey  <tom@tromey.com>
3112
3113         * solib-svr4.c (struct svr4_info): Add initializers and
3114         destructor.
3115         <probes_table>: Now an htab_up.
3116         (solib_svr4_pspace_data): Change type.
3117         (free_probes_table): Simplify.
3118         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3119         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3120         (probes_table_remove_objfile_probes, register_solib_event_probe)
3121         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3122         (_initialize_svr4_solib): Update.
3123
3124 2019-05-08  Tom Tromey  <tom@tromey.com>
3125
3126         * remote.c (remote_pspace_data): Change type.
3127         (remote_pspace_data_cleanup): Remove.
3128         (get_remote_exec_file, set_pspace_remote_exec_file)
3129         (_initialize_remote): Update.
3130
3131 2019-05-08  Tom Tromey  <tom@tromey.com>
3132
3133         * breakpoint.c (breakpoint_objfile_key): Change type.
3134         (get_breakpoint_objfile_data): Update.
3135         (free_breakpoint_objfile_data): Remove.
3136         (_initialize_breakpoint): Update.
3137
3138 2019-05-08  Tom Tromey  <tom@tromey.com>
3139
3140         * linux-tdep.c (struct linux_info): Add initializers.
3141         (linux_inferior_data): Move.  Change type.
3142         (invalidate_linux_cache_inf): Update.
3143         (linux_inferior_data_cleanup): Remove.
3144         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3145
3146 2019-05-08  Tom Tromey  <tom@tromey.com>
3147
3148         * auxv.c (auxv_inferior_data): Move.  Change type.
3149         (auxv_inferior_data_cleanup): Remove.
3150         (invalidate_auxv_cache_inf): Rewrite.
3151         (get_auxv_inferior_data, _initialize_auxv): Update.
3152
3153 2019-05-08  Tom Tromey  <tom@tromey.com>
3154
3155         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3156         (symfile_debug_objfile_data_key): Change type.
3157         (symfile_debug_installed, debug_qf_has_symbols)
3158         (debug_qf_find_last_source_symtab)
3159         (debug_qf_forget_cached_source_info)
3160         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3161         (debug_qf_print_stats, debug_qf_dump)
3162         (debug_qf_expand_symtabs_for_function)
3163         (debug_qf_expand_all_symtabs)
3164         (debug_qf_expand_symtabs_with_fullname)
3165         (debug_qf_map_matching_symbols)
3166         (debug_qf_expand_symtabs_matching)
3167         (debug_qf_find_pc_sect_compunit_symtab)
3168         (debug_qf_map_symbol_filenames)
3169         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3170         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3171         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3172         (debug_sym_read_linetable, debug_sym_relocate): Update.
3173         (symfile_debug_free_objfile): Remove.
3174         (install_symfile_debug_logging, _initialize_symfile_debug):
3175         Update.
3176
3177 2019-05-08  Tom Tromey  <tom@tromey.com>
3178
3179         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3180         allocate_on_obstack.
3181         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3182         (get_dwarf2_per_objfile): Update.
3183         (set_dwarf2_per_objfile): Remove.
3184         (dwarf2_has_info, dwarf2_get_section_info): Update.
3185         (dwarf2_free_objfile): Remove.
3186         (_initialize_dwarf2_read): Update.
3187
3188 2019-05-08  Tom Tromey  <tom@tromey.com>
3189
3190         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3191         initializers.
3192         <unsupported_script_warning_printed,
3193         script_not_found_warning_printed>: Now bool.
3194         (auto_load_pspace_data): Change type.
3195         (~auto_load_pspace_info): Rename from
3196         auto_load_pspace_data_cleanup.
3197         (get_auto_load_pspace_data, init_loaded_scripts_info)
3198         (clear_section_scripts, maybe_print_unsupported_script_warning)
3199         (maybe_print_script_not_found_warning, _initialize_auto_load):
3200         Update.
3201
3202 2019-05-08  Tom Tromey  <tom@tromey.com>
3203
3204         * objfiles.c (objfile_pspace_info): Add destructor and
3205         initializers.
3206         (objfiles_pspace_data): Change type.
3207         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3208         (get_objfile_pspace_data): Update.
3209         (objfiles_bfd_data): Change type.
3210         (get_objfile_bfd_data): Update.
3211         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3212
3213 2019-05-08  Tom Tromey  <tom@tromey.com>
3214
3215         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3216         Change type.
3217         (get_catch_syscall_inferior_data): Update.
3218         (catch_syscall_inferior_data_cleanup): Remove.
3219         (_initialize_break_catch_syscall): Update.
3220
3221 2019-05-08  Tom Tromey  <tom@tromey.com>
3222
3223         * inflow.c (struct terminal_info): Add destructor and
3224         initializers.
3225         (inflow_inferior_data): Change type.
3226         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3227         (get_inflow_inferior_data, inflow_inferior_exit)
3228         (swap_terminal_info, _initialize_inflow): Update.
3229
3230 2019-05-08  Tom Tromey  <tom@tromey.com>
3231
3232         * target-dcache.c (target_dcache_cleanup): Remove.
3233         (target_dcache_aspace_key): Change type.
3234         (target_dcache_init_p, target_dcache_invalidate)
3235         (target_dcache_get, target_dcache_get_or_init)
3236         (_initialize_target_dcache): Update.
3237         * dcache.h (struct dcache_deleter): New.
3238
3239 2019-05-08  Tom Tromey  <tom@tromey.com>
3240
3241         * symtab.c (struct symbol_cache): Add destructor and
3242         initializers.
3243         (symbol_cache_key): Move.  Change type.
3244         (make_symbol_cache, free_symbol_cache): Remove.
3245         (get_symbol_cache): Update.
3246         (symbol_cache_cleanup): Remove.
3247         (ALL_PSPACES, symbol_cache_flush)
3248         (maintenance_print_symbol_cache)
3249         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3250         Update.
3251
3252 2019-05-08  Tom Tromey  <tom@tromey.com>
3253
3254         * symtab.c (struct main_info): Add destructor and initializers.
3255         (main_progspace_key): Move.  Change type.
3256         (get_main_info): Update.
3257         (main_info_cleanup): Remove.
3258         (_initialize_symtab): Update.
3259
3260 2019-05-08  Tom Tromey  <tom@tromey.com>
3261
3262         * registry.h (DECLARE_REGISTRY): Define the _key class.
3263
3264 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3265
3266         * NEWS: Merge two 'New commands' sections.
3267
3268 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3269
3270         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3271         parameter and use Ada language definition instead.
3272         (ada_val_print_ptr): Remove unused language parameter.
3273         (ada_val_print_num): Remove language parameter and use Ada language
3274         definition instead.
3275         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3276         parameter.
3277         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3278         parameter and use Ada language definition instead.
3279         (ada_val_print_1): Update all ada_val_print_xxx calls.
3280         Remove language parameter.
3281         (ada_val_print): Update ada_val_print_1 call.
3282
3283 2019-05-08  Tom Tromey  <tromey@adacore.com>
3284
3285         * remote.c (remote_hw_watchpoint_limit)
3286         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3287         Now static.
3288
3289 2019-05-08  Tom Tromey  <tromey@adacore.com>
3290
3291         * maint.c (_initialize_maint_cmds): Move initialization code to
3292         remote.c.
3293         (watchdog, show_watchdog): Move to remote.c.
3294         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3295         "watchdog" static.
3296         (_initialize_remote): Move initialization code from maint.c.
3297         * defs.h (watchdog): Don't declare.
3298
3299 2019-05-08  Tom Tromey  <tromey@adacore.com>
3300
3301         * tui/tui-interp.c: Include main.h.
3302         * interps.c: Include main.h.
3303         * main.h (interpreter_p): Declare.
3304         * defs.h (interpreter_p): Don't declare.
3305
3306 2019-05-08  Tom Tromey  <tromey@adacore.com>
3307
3308         * dwarf2loc.c: Include dwarf2read.h.
3309         * defs.h (read_unsigned_leb128): Don't declare.
3310         * dwarf2read.h (read_unsigned_leb128): Declare.
3311
3312 2019-05-08  Tom Tromey  <tromey@adacore.com>
3313
3314         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3315         method.
3316
3317 2019-05-08  Tom Tromey  <tromey@adacore.com>
3318
3319         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3320         when no wrap column is set.
3321
3322 2019-05-08  Tom Tromey  <tromey@adacore.com>
3323
3324         * c-lang.c (c_get_string): Handle non-C-style arrays.
3325
3326 2019-05-08  Tom Tromey  <tromey@adacore.com>
3327
3328         * typeprint.c (print_offset_data::update): Print the bit offset,
3329         not the number of bits remaining.
3330
3331 2019-05-08  Tom Tromey  <tromey@adacore.com>
3332
3333         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3334         padding at end of comment.
3335
3336 2019-05-08  Tom Tromey  <tromey@adacore.com>
3337
3338         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3339         Compare main types.
3340
3341 2019-05-06  Tom Tromey  <tom@tromey.com>
3342
3343         * common/scoped_mmap.c: Include common-defs.h.
3344         * common/scoped_mmap.h: Don't include config.h.
3345
3346 2019-05-04  Tom Tromey  <tom@tromey.com>
3347
3348         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3349         (struct aarch64_call_info): Add initializers.
3350         <si>: Now a std::vector.
3351         (pass_on_stack, aarch64_push_dummy_call): Update.
3352
3353 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3354             Tom Tromey  <tom@tromey.com>
3355
3356         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3357         (ppc_threads): Now a std::vector.  Now static.
3358         (hwdebug_find_thread_points_by_tid)
3359         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3360         Update.
3361
3362 2019-05-04  Tom Tromey  <tom@tromey.com>
3363
3364         * arc-tdep.c (arc_tdesc_init): Return bool.
3365
3366 2019-05-04  Tom Tromey  <tom@tromey.com>
3367
3368         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3369         Use gdb_assert_not_reached.
3370
3371 2019-05-04  Tom Tromey  <tom@tromey.com>
3372
3373         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3374         "false".
3375
3376 2019-05-04  Tom Tromey  <tom@tromey.com>
3377
3378         * arc-tdep.c (arc_tdesc_init): Use bool.
3379
3380 2019-05-04  Tom Tromey  <tom@tromey.com>
3381
3382         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3383
3384 2019-05-04  Tom Tromey  <tom@tromey.com>
3385
3386         * cli/cli-cmds.c (valid_command_p): Return bool.
3387
3388 2019-05-04  Tom Tromey  <tom@tromey.com>
3389
3390         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3391         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3392
3393 2019-05-04  Raul Tambre  <raul@tambre.ee>
3394
3395         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3396         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3397         operator for comparison.
3398
3399 2019-05-04  Tom Tromey  <tom@tromey.com>
3400
3401         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3402         (lookup_partial_symbol, print_partial_symbols)
3403         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3404         (psymbol_compare): Update.
3405         (add_psymbol_to_bcache): Clear the entire psymbol.
3406         (maintenance_check_psymtabs): Update.
3407         * psympriv.h (struct partial_symbol): Don't derive from
3408         general_symbol_info.
3409         <obj_section, unrelocated_address, address,
3410         set_unrelocated_address>: Update.
3411         <ginfo>: New member.
3412         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3413         (debug_names::write_psymbols): Update.
3414
3415 2019-05-04  Tom de Vries  <tdevries@suse.de>
3416
3417         * contrib/cc-with-tweaks.sh: Support -n arg.
3418
3419 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3420
3421         * corelow.c (core_target::detach): Ensure frame cache and
3422         register caches are cleared.
3423         inferior.c (exit_inferior_1): Likewise.
3424
3425 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3426             Tom Tromey  <tom@tromey.com>
3427
3428         * dictionary.c (collate_pending_symbols_by_language): Remove
3429         "struct" from foreach.
3430         * symtab.c (lookup_global_symbol_from_objfile)
3431         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3432         foreach.
3433         * ser-tcp.c (net_open): Remove "struct" from foreach.
3434         * objfiles.c (objfile_relocate, objfile_rebase)
3435         (objfile_has_symbols): Remove "struct" from foreach.
3436         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3437         from foreach.
3438         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3439         foreach.
3440         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3441         "struct" from foreach.
3442         * ada-lang.c (create_excep_cond_exprs)
3443         (ada_exception_catchpoint_cond_string): Remove "struct" from
3444         foreach.
3445
3446 2019-05-03  Tom Tromey  <tromey@adacore.com>
3447
3448         * ada-exp.y (convert_char_literal): Check suffix of each
3449         enumerator.
3450
3451 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3452
3453         PR ada/21406:
3454         * ada-exp.y (yywrap): Don't define.
3455         * ada-lex.l (%option): Add noyywrap
3456         (yywrap): Remove.
3457
3458 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3459
3460         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3461         _WIN32_WINNT to the XP level, unless already defined to a higher
3462         level.
3463
3464         * unittests/parse-connection-spec-selftests.c:
3465         * ser-tcp.c:
3466         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3467         override.
3468
3469         * symfile.c (find_separate_debug_file): Remove colon from the
3470         drive spec of DOS/Windows file names of the target, so that the
3471         file name produced from DEBUGDIR and the target's directory will
3472         be valid on DOS/Windows systems.
3473
3474 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3475
3476         * rust-lang.c (val_print_struct): Handle printing structures
3477         containing strings.
3478
3479 2019-05-02  Tom Tromey  <tromey@adacore.com>
3480
3481         * valarith.c (_initialize_valarith): Remove.
3482
3483 2019-05-01  Tom Tromey  <tromey@adacore.com>
3484
3485         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3486         bitfields.
3487
3488 2019-05-01  Tom Tromey  <tromey@adacore.com>
3489
3490         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3491         for big-endian copies.
3492
3493 2019-04-30  Ali Tamur  <tamur@google.com>
3494         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3495         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3496         (read_3_bytes): New function.
3497
3498 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3499
3500         * windows-nat.c (main_thread_id): Delete.
3501         (handle_output_debug_string): Replace main_thread_id by
3502         current_event.dwThreadId.
3503         (fake_create_process): Likewise.
3504         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3505         Do not set main_thread_id.
3506         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3507         current_event.dwThreadId.
3508         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3509
3510 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3511
3512         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3513         Use current_event.dwThreadId instead of main_thread_id.
3514
3515 2019-04-30  Tom Tromey  <tromey@adacore.com>
3516
3517         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3518         (create_excep_cond_exprs): Iterate over program spaces.
3519         (ada_exception_catchpoint_cond_string): Examine all minimal
3520         symbols for exception types.
3521
3522 2019-04-30  Tom Tromey  <tromey@adacore.com>
3523
3524         PR c++/24470:
3525         * dwarf2read.c (process_structure_scope): Handle case where type
3526         has template parameters but no symbol was created.
3527
3528 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3529             Chris January  <chris.january@arm.com>
3530
3531         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3532         qualifier.
3533         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3534
3535 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3536
3537         * f-typeprint.c (f_print_type): Update rules for printing
3538         whitespace.
3539         (f_type_print_varspec_suffix): Likewise.
3540
3541 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3542             Chris January  <chris.january@arm.com>
3543
3544         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3545         function arguments.
3546
3547 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3548
3549         * f-lang.c (build_fortran_types): Change name of void type to
3550         lower case.
3551         * f-typeprint.c (f_type_print_base): Print the name of the void
3552         type, rather than a fixed string.
3553         * f-valprint.c (f_decorations): Use lower case void string.
3554
3555 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3556             Chris January  <chris.january@arm.com>
3557
3558         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3559         types for Fortran.
3560
3561 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3562             Chris January  <chris.january@arm.com>
3563             David Lecomber  <david.lecomber@arm.com>
3564
3565         * f-exp.y (BINOP_INTRINSIC): New token.
3566         (exp): New parser rule handling BINOP_INTRINSIC.
3567         (f77_keywords): Add new builtin procedures.
3568         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
3569         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3570         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
3571         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3572         (print_unop_subexp_f): New function.
3573         (print_binop_subexp_f): New function.
3574         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3575         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3576         (dump_subexp_body_f): Likewise.
3577         (operator_check_f): Likewise.
3578         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3579         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
3580
3581 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3582
3583         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
3584         UNOP_KIND.
3585         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
3586         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
3587         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
3588         (operator_length_f): New fuction.
3589         (print_subexp_f): New function.
3590         (op_name_f): New function.
3591         (dump_subexp_body_f): New function.
3592         (operator_check_f): New function.
3593         (exp_descriptor_f): Replace standard expression handling functions
3594         with new functions.
3595         * gdb/fortran-operator.def: New file.
3596         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
3597         * gdb/std-operator.def: Remove UNOP_KIND.
3598
3599 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3600
3601         * std-operator.def: Remove unbalanced, stray double quote
3602         character.
3603
3604 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3605             Chris January  <chris.january@arm.com>
3606             Daniel Everett  <daniel.everett@arm.com>
3607             Nick Forrington  <nick.forrington@arm.com>
3608             Richard Bunt  <richard.bunt@arm.com>
3609
3610         * cp-valprint.c (cp_print_value_fields): Allow an additional level
3611         of depth when printing anonymous structs or unions.
3612         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
3613         Don't print either the top-level value, or the children if the
3614         max-depth is exceeded.
3615         (ppscm_print_children): When printing the key of a map, allow one
3616         extra level of depth.
3617         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
3618         print either the top-level value, or the children if the max-depth
3619         is exceeded.
3620         (print_children): When printing the key of a map, allow one extra
3621         level of depth.
3622         * python/py-value.c (valpy_format_string): Add max_depth keyword.
3623         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
3624         (user_print_options): Initialise max_depth field.
3625         (val_print_scalar_or_string_type_p): New function.
3626         (val_print): Check to see if the max depth has been reached.
3627         (val_print_check_max_depth): Define new function.
3628         (show_print_max_depth): New function.
3629         (_initialize_valprint): Add 'print max-depth' option.
3630         * valprint.h (struct value_print_options) <max_depth>: New field.
3631         (val_print_check_max_depth): Declare new function.
3632         * NEWS: Document new feature.
3633
3634 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3635
3636         * ada-lang.c (ada_language_defn): Initialise new field.
3637         * c-lang.c (c_is_string_type_p): New function.
3638         (c_language_defn): Initialise new field.
3639         (cplus_language_defn): Initialise new field.
3640         (asm_language_defn): Initialise new field.
3641         (minimal_language_defn): Initialise new field.
3642         * c-lang.h (c_is_string_type_p): Declare new function.
3643         * d-lang.c (d_language_defn): Initialise new field.
3644         * f-lang.c (f_is_string_type_p): New function.
3645         (f_language_defn): Initialise new field.
3646         * go-lang.c (go_is_string_type_p): New function.
3647         (go_language_defn): Initialise new field.
3648         * language.c (default_is_string_type_p): New function.
3649         (unknown_language_defn): Initialise new field.
3650         (auto_language_defn): Initialise new field.
3651         * language.h (struct language_defn) <la_is_string_type_p>: New
3652         member variable.
3653         (default_is_string_type_p): Declare new function.
3654         * m2-lang.c (m2_language_defn): Initialise new field.
3655         * objc-lang.c (objc_language_defn): Initialise new field.
3656         * opencl-lang.c (opencl_language_defn): Initialise new field.
3657         * p-lang.c (pascal_is_string_type_p): New function.
3658         (pascal_language_defn): Initialise new field.
3659         * rust-lang.c (rust_is_string_type_p): New function.
3660         (rust_language_defn): Initialise new field.
3661
3662 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3663
3664         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
3665         New field.
3666         * ada-lang.c (ada_language_defn): Initialise new field.
3667         * c-lang.c (c_language_defn): Likewise.
3668         (cplus_language_defn): Likewise.
3669         (asm_language_defn): Likewise.
3670         (minimal_language_defn): Likewise.
3671         * d-lang.c (d_language_defn): Likewise.
3672         * f-lang.c (f_language_defn): Likewise.
3673         * go-lang.c (go_language_defn): Likewise.
3674         * language.c (unknown_language_defn): Likewise.
3675         (auto_language_defn): Likewise.
3676         * m2-lang.c (m2_language_defn): Likewise.
3677         * objc-lang.c (objc_language_defn): Likewise.
3678         * opencl-lang.c (opencl_language_defn): Likewise.
3679         * p-lang.c (pascal_language_defn): Likewise.
3680         * rust-lang.c (rust_language_defn): Likewise.
3681
3682 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3683
3684         * ada-lang.c (ada_is_character_type): Change return type to bool.
3685         (ada_is_string_type): Likewise.
3686         * ada-lang.h (ada_is_character_type): Update declaration
3687         (ada_is_string_type): Likewise.
3688
3689 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3690
3691         Support style in 'frame|thread apply'
3692
3693         * gdbcmd.h (execute_command_to_string): New term_out parameter.
3694         * record.c (record_start, record_stop): Update callers of
3695         execute_command_to_string with false.
3696         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
3697         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
3698         methods.
3699         (class string_file): New constructor with term_out parameter.
3700         Override methods term_out and can_emit_style_escape.  New member
3701         term_out.
3702         (class stdio_file): Override can_emit_style_escape.
3703         (class tee_file): Override term_out and can_emit_style_escape.
3704         * utils.h (can_emit_style_escape): Remove.
3705         * utils.c (can_emit_style_escape): Likewise.
3706         Update all callers of can_emit_style_escape (SOMESTREAM) to
3707         SOMESTREAM->can_emit_style_escape.
3708         * source-cache.c (source_cache::get_source_lines): Likewise.
3709         * stack.c (frame_apply_command_count): Call execute_command_to_string
3710         passing the term_out characteristic of the current gdb_stdout.
3711         * thread.c (thr_try_catch_cmd): Likewise.
3712         * top.c (execute_command_to_string): pass term_out parameter
3713         to construct the string_file for the command output.
3714         * ui-file.c (term_cli_styling): New function (most code moved
3715         from utils.c can_emit_style_escape).
3716         (string_file::string_file, string_file::can_emit_style_escape,
3717         stdio_file::can_emit_style_escape, tee_file::term_out,
3718         tee_file::can_emit_style_escape): New functions.
3719
3720 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3721
3722         * NEWS: Mention the new set|show may-call-functions.
3723         * infcall.c (may_call_functions_p): New variable.
3724         (show_may_call_functions_p): New function.
3725         (call_function_by_hand_dummy): Throws an error if not
3726         may-call-functions.
3727         (_initialize_infcall): Call add_setshow_boolean_cmd for
3728         may-call-functions.
3729
3730 2019-04-25  Keith Seitz  <keiths@redhat.com>
3731
3732         PR c++/24367
3733         * cp-support.c (inspect_type): Don't attempt substitutions
3734         of symbol with the same name.
3735
3736 2019-04-25  Tom Tromey  <tromey@adacore.com>
3737
3738         PR gdb/24475:
3739         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
3740         static.
3741
3742 2019-04-25  Tom Tromey  <tromey@adacore.com>
3743
3744         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
3745         rvalue reference.
3746         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
3747         (gdb_xml_parser::parse): Use std::move.
3748         * python/python-internal.h (gdbpy_convert_exception): Take a const
3749         reference.
3750         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
3751         std::move.
3752         * python/py-utils.c (gdbpy_convert_exception): Take a const
3753         reference.
3754         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3755         Use std::move.
3756         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3757         Use std::move.
3758         * mi/mi-main.c (mi_print_exception): Take a const reference.
3759         * main.c (handle_command_errors): Take a const reference.
3760         * linespec.c (parse_linespec): Use std::move.
3761         * infcall.c (run_inferior_call): Use std::move.
3762         (call_function_by_hand_dummy): Use std::move.
3763         * exec.c (try_open_exec_file): Use std::move.
3764         * exceptions.h (exception_print, exception_fprintf)
3765         (exception_print_same): Update.
3766         * exceptions.c (print_exception, exception_print)
3767         (exception_fprintf, exception_print_same): Change parameters to
3768         const reference.
3769         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
3770         * common/new-op.c: Use std::move.
3771         * common/common-exceptions.h (struct gdb_exception): Add move
3772         constructor.
3773         (struct gdb_exception_error, struct gdb_exception_quit, struct
3774         gdb_quit_bad_alloc): Change constructor to move constructor.
3775         (throw_exception): Change parameter to rvalue reference.
3776         * common/common-exceptions.c (throw_exception): Take rvalue
3777         reference.
3778         * cli/cli-interp.c (safe_execute_command): Use std::move.
3779         * breakpoint.c (insert_bp_location, location_to_sals): Use
3780         std::move.
3781
3782 2019-04-25  Tom Tromey  <tromey@adacore.com>
3783
3784         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
3785         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
3786         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
3787         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
3788         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
3789         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
3790         guile/scm-value.c: Use unpack.
3791         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
3792         gdbscm_gdb_exception.
3793         (gdbscm_throw_gdb_exception): Likewise.
3794         (struct gdbscm_gdb_exception): New.
3795         (unpack): New function.
3796         (gdbscm_wrap): Use unpack.
3797
3798 2019-04-25  Tom Tromey  <tromey@adacore.com>
3799
3800         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3801         (gdb_rl_callback_handler): Use std::move.
3802         * common/common-exceptions.h (struct gdb_exception): Add move
3803         assignment operator.
3804         (throw_exception_sjlj): Change "exception" to const reference.
3805         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
3806         (throw_exception_sjlj): Change "exception" to const reference.
3807
3808 2019-04-25  Tom Tromey  <tromey@adacore.com>
3809
3810         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
3811         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
3812         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3813         Update.
3814         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3815         Update.
3816         * mi/mi-interp.c (mi_interp::exec): Update.
3817         * linespec.c (parse_linespec): Update.
3818         * infcall.c (run_inferior_call): Update.
3819         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
3820         * guile/scm-symbol.c (gdbscm_lookup_symbol)
3821         (gdbscm_lookup_global_symbol): Update.
3822         * guile/scm-param.c (gdbscm_parameter_value): Update.
3823         * guile/scm-frame.c (gdbscm_frame_read_register)
3824         (gdbscm_frame_read_var): Update.
3825         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
3826         * exec.c (try_open_exec_file): Update.
3827         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3828         (gdb_rl_callback_handler): Update.
3829         * common/common-exceptions.h (exception_none): Don't declare.
3830         * common/common-exceptions.c (exception_none): Don't define.
3831         (struct catcher) <exception>: Update.
3832         * cli/cli-interp.c (safe_execute_command): Update.
3833         * breakpoint.c (insert_bp_location, location_to_sals): Update.
3834
3835 2019-04-25  Ali Tamur  <tamur@google.com>
3836
3837         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
3838         (read_attribute_value): Likewise.
3839         (dwarf2_read_addr_index): Update comment.
3840         (read_str_index): Add DW_FORM_strx.
3841         (dwarf2_string_attr): Likewise.
3842         (dwarf2_const_value_attr): Likewise.
3843         (dump_die_shallow): Likewise.
3844         (dwarf2_fetch_constant_bytes): Likewise.
3845         (skip_form_bytes): Likewise.
3846         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
3847
3848 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
3849
3850         PR corefiles/11608
3851         PR corefiles/18187
3852         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
3853         OFFSET.  Verify if current mapping contains an ELF header.
3854         (linux_find_memory_regions_full): Adjust call to
3855         dump_mapping_p.
3856
3857 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
3858             Kang Li <kanglictf@gmail.com>
3859
3860         PR gdb/21600
3861
3862         * dwarf2-frame.c (read_initial_length): Be consistent about using
3863         unsigned representation of length.
3864         (decode_frame_entry_1): Likewise.  Check for wraparound of
3865         end pointer as well as buffer overflow.
3866
3867 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
3868
3869         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
3870         "vq".
3871
3872 2019-04-24  Tom Tromey  <tromey@adacore.com>
3873
3874         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
3875
3876 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3877
3878         * s12z-tdep.c (s12z_unwind_pc): Delete.
3879         (s12z_unwind_sp): Delete.
3880         (s12z_gdbarch_init): Don't register deleted functions with
3881         gdbarch.
3882
3883 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3884
3885         * rl78-tdep.c (rl78_unwind_sp): Delete.
3886         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
3887
3888 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3889
3890         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
3891         (xstormy16_unwind_pc): Delete.
3892         (xstormy16_dummy_id): Delete.
3893         (xstormy16_gdbarch_init): Don't register deleted functions with
3894         gdbarch.
3895
3896 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3897
3898         * vax-tdep.c (vax_unwind_pc): Delete.
3899         (vax_gdbarch_init): Don't register deleted function with gdbarch.
3900
3901 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3902
3903         * v850-tdep.c (v850_unwind_sp): Delete.
3904         (v850_unwind_pc): Delete.
3905         (v850_dummy_id): Delete.
3906         (v850_gdbarch_init): Don't register deleted functions with
3907         gdbarch.
3908
3909 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3910
3911         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
3912         (tilegx_unwind_pc): Delete.
3913         (tilegx_unwind_dummy_id): Delete.
3914         (tilegx_gdbarch_init): Don't register deleted functions with
3915         gdbarch.
3916
3917 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3918
3919         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
3920         (tic6x_dummy_id): Delete.
3921         (tic6x_gdbarch_init): Don't register deleted functions with
3922         gdbarch.
3923
3924 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3925
3926         * sparc-tdep.c (sparc_unwind_pc): Delete.
3927         (sparc32_gdbarch_init): Don't register deleted function with
3928         gdbarch.
3929
3930 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3931
3932         * sh-tdep.c (sh_unwind_sp): Delete.
3933         (sh_unwind_pc): Delete.
3934         (sh_dummy_id): Delete.
3935         (sh_gdbarch_init): Don't register deleted functions with
3936         gdbarch.
3937
3938 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3939
3940         * score-tdep.c (score_unwind_sp): Delete.
3941         (score_unwind_pc): Delete.
3942         (score_dummy_id): Delete.
3943         (score_gdbarch_init): Don't register deleted functions with
3944         gdbarch.
3945
3946 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3947
3948         * rx-tdep.c (rx_unwind_pc): Delete.
3949         (rx_unwind_sp): Delete.
3950         (rx_dummy_id): Delete.
3951         (rx_gdbarch_init): Don't register deleted functions with
3952         gdbarch.  Update comment.
3953
3954 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3955
3956         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
3957         (rs6000_dummy_id): Delete.
3958         (rs6000_gdbarch_init): Don't register deleted functions with
3959         gdbarch.
3960
3961 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3962
3963         * or1k-tdep.c (or1k_dummy_id): Delete.
3964         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
3965
3966 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3967
3968         * nios2-tdep.c (nios2_dummy_id): Delete.
3969         (nios2_unwind_sp): Delete.
3970         (nios2_gdbarch_init): Don't register deleted functions with
3971         gdbarch.
3972
3973 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3974
3975         * nds32-tdep.c (nds32_dummy_id): Delete.
3976         (nds32_unwind_pc): Delete.
3977         (nds32_unwind_sp): Delete.
3978         (nds32_gdbarch_init): Don't register deleted functions with
3979         gdbarch.
3980
3981 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3982
3983         * msp430-tdep.c (msp430_unwind_pc): Delete.
3984         (msp430_unwind_sp): Delete.
3985         (msp430_dummy_id): Delete.
3986         (msp430_gdbarch_init): Don't register deleted functions with
3987         gdbarch.
3988
3989 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3990
3991         * moxie-tdep.c (moxie_unwind_sp): Delete.
3992         (moxie_unwind_pc): Delete.
3993         (moxie_dummy_id): Delete.
3994         (moxie_gdbarch_init): Don't register deleted functions with
3995         gdbarch.
3996
3997 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3998
3999         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4000         (mn10300_unwind_pc): Delete.
4001         (mn10300_unwind_sp): Delete.
4002         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4003         mn10300_unwind_sp.
4004         (mn10300_frame_unwind_init): Don't register deleted functions with
4005         gdbarch.
4006
4007 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4008
4009         * mep-tdep.c (mep_unwind_pc): Delete.
4010         (mep_unwind_sp): Delete.
4011         (mep_dummy_id): Delete.
4012         (mep_gdbarch_init): Don't register deleted functions with
4013         gdbarch.
4014
4015 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4016
4017         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4018         (m68hc11_unwind_sp): Delete.
4019         (m68hc11_gdbarch_init): Don't register deleted functions with
4020         gdbarch.
4021
4022 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4023
4024         * m32r-tdep.c (m32r_unwind_sp): Delete.
4025         (m32r_unwind_pc): Delete.
4026         (m32r_dummy_id): Delete.
4027         (m32r_gdbarch_init): Don't register deleted functions with
4028         gdbarch.
4029
4030 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4031
4032         * m32c-tdep.c (m32c_unwind_pc): Delete.
4033         (m32c_unwind_sp): Delete.
4034         (m32c_dummy_id): Delete.
4035         (m32c_gdbarch_init): Don't register deleted functions with
4036         gdbarch.
4037
4038 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4039
4040         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4041         (lm32_unwind_pc): Delete.
4042         (lm32_dummy_id): Delete.
4043         (lm32_gdbarch_init): Don't register deleted functions with
4044         gdbarch.
4045
4046 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4047
4048         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4049         (iq2000_unwind_pc): Delete.
4050         (iq2000_dummy_id): Delete.
4051         (iq2000_gdbarch_init): Don't register deleted functions with
4052         gdbarch.
4053
4054 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4055
4056         * nds32-tdep.c (nds32_type_align): Delete.
4057         (nds32_push_dummy_call): Use type_align instead.
4058
4059 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4060
4061         * arm-tdep.c (arm_type_align): Only handle vector override case.
4062         (arm_push_dummy_call): Use type_align.
4063         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4064
4065 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4066
4067         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4068         case.
4069         (pass_on_stack): Use type_align.
4070         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4071         function.
4072
4073 2019-04-23  Tom Tromey  <tromey@adacore.com>
4074
4075         * dwarf2read.c (line_header::file_name_at): Remove unused
4076         overload.
4077
4078 2019-04-23  Tom de Vries  <tdevries@suse.de>
4079
4080         PR gdb/24438
4081         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4082         invocation.
4083
4084
4085 2019-03-27  Ali Tamur  <tamur@google.com>
4086
4087         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4088         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4089         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4090         (dwarf_expr_context::get_addr_index): Likewise
4091         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4092         (symbol_needs_eval_context::get_addr_index): Likewise
4093         (disassemble_dwarf_expression): Add DW_OP_addrx
4094         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4095         (read_cutu_die_from_dwo): Update comment
4096         (skip_one_die): Add DW_FORM_addrx
4097         (read_attribute_value): Likewise
4098         (var_decode_location): Add DW_OP_addrx
4099         (dwarf2_const_value_attr): Add DW_FORM_addrx
4100         (dump_die_shallow): Likewise
4101         (dwarf2_fetch_constant_bytes): Likewise
4102         (decode_locdesc): Add DW_OP_addrx
4103         (skip_form_bytes): Add DW_FORM_addrx
4104
4105 2019-04-22  Ali Tamur  <tamur@google.com>
4106
4107         * MAINTAINERS (Write After Approval): Add self.
4108
4109 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4110
4111         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4112         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4113         (open_symbol_file_object): Likewise.
4114         (svr4_default_sos): Add info parameter.
4115         (svr4_read_so_list): Likewise.
4116         (svr4_current_sos_direct): Adjust functions calls to pass down
4117         info.
4118         (svr4_current_sos_1): Add info parameter.
4119         (svr4_current_sos): Call get_svr4_info, pass info down to
4120         svr4_current_sos_1.
4121         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4122         get_svr4_info.
4123         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4124         get_svr4_info.
4125         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4126         to get_svr4_info.
4127         (probes_table_remove_objfile_probes): Likewise.
4128         (register_solib_event_probe): Add info parameter.
4129         (solist_update_incremental): Pass info parameter down to
4130         svr4_read_so_list.
4131         (disable_probes_interface): Add info parameter.
4132         (svr4_handle_solib_event): Pass current_program_space to
4133         get_svr4_info.  Adjust disable_probes_interface cleanup.
4134         (svr4_create_probe_breakpoints): Add info parameter, pass it
4135         down to register_solib_event_probe.
4136         (svr4_create_solib_event_breakpoints): Add info parameter,
4137         pass it down to svr4_create_probe_breakpoints.
4138         (enable_break): Pass info down to
4139         svr4_create_solib_event_breakpoints.
4140         (svr4_solib_create_inferior_hook): Pass current_program_space to
4141         get_svr4_info.
4142         (svr4_clear_solib): Likewise.
4143
4144 2019-04-22  Pedro Alves  <palves@redhat.com>
4145
4146         * solib-svr4.c (svr4_free_objfile_observer): New.
4147         (probe_and_action::objfile): New field.
4148         (probes_table_htab_remove_objfile_probes)
4149         (probes_table_remove_objfile_probes): New functions.
4150         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4151         in the new probe_and_action.  Don't store the probe in 'lookup'.
4152         (svr4_create_probe_breakpoints): Pass objfile to
4153         register_solib_event_probe.
4154         (_initialize_svr4_solib): Register a free_objfile observer.
4155
4156 2019-04-19  Tom Tromey  <tom@tromey.com>
4157
4158         * common/queue.h: Remove.
4159
4160 2019-04-19  Tom Tromey  <tom@tromey.com>
4161
4162         * event-loop.c: Don't include "common/queue.h".
4163
4164 2019-04-19  Tom Tromey  <tom@tromey.com>
4165
4166         * remote.c (remote_target): Use delete.
4167         * remote-notif.h: Include <list>, not "common/queue.h".
4168         (notif_client_p): Remove typedef.
4169         (remote_notif_state): Add constructor, destructor, initializer.
4170         <notif_queue>: Now a std::list.
4171         (remote_notif_state_xfree): Don't declare.
4172         * remote-notif.c (remote_notif_process, handle_notification)
4173         (remote_notif_state_allocate): Update.
4174         (~remote_notif_state): Rename from remote_notif_state_xfree.
4175
4176 2019-04-19  Tom Tromey  <tom@tromey.com>
4177
4178         * symfile.c (reread_symbols): Update.
4179         * objfiles.c (objfile_register_static_link)
4180         (objfile_lookup_static_link): Update
4181         (~objfile) Don't delete static_links.
4182         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4183
4184 2019-04-19  Tom Tromey  <tom@tromey.com>
4185
4186         * type-stack.h (struct type_stack) <insert>: Constify string.
4187         * type-stack.c (type_stack::insert): Constify string.
4188         * gdbtypes.h (lookup_template_type): Update.
4189         (address_space_name_to_int): Update.
4190         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4191         const.
4192         (lookup_template_type): Make name const.
4193         * c-exp.y: Update rules.
4194         (lex_one_token, classify_name, classify_inner_name)
4195         (c_print_token): Update.
4196         * p-exp.y: Update rules.
4197         (yylex): Update.
4198         * f-exp.y: Update rules.
4199         (yylex): Update.
4200         * d-exp.y: Update rules.
4201         (lex_one_token, classify_name, classify_inner_name): Update.
4202         * parse.c (write_dollar_variable, copy_name): Return std::string.
4203         * parser-defs.h (copy_name): Change return type.
4204         * m2-exp.y: Update rules.
4205         (yylex): Update.
4206         * go-exp.y (lex_one_token): Update.
4207         Update rules.
4208         (classify_unsafe_function, classify_packaged_name)
4209         (classify_name, yylex): Update.
4210
4211 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4212
4213         * configure.ac: add --enable-source-highlight switch.
4214         * configure: Regenerate.
4215         * top.c (print_gdb_version): plumb --enable-source-highlight
4216         status to "show configuration".
4217
4218 2019-04-19  Tom Tromey  <tromey@adacore.com>
4219
4220         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4221         Check ADA_TYPE_P.
4222         (empty_record, ada_template_to_fixed_record_type_1)
4223         (template_to_static_fixed_type)
4224         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4225         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4226         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4227         macros.
4228
4229 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4230
4231         PR symtab/24423:
4232         * source.c (print_source_lines_base): Advance "iter" when a
4233         control character is seen.
4234
4235 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4236
4237         * inferior.h (struct infcall_suspend_state_deleter):
4238         Catch exception in destructor to avoid crash.
4239
4240 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4241
4242         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4243         close to the add_com "shell".
4244
4245 2019-04-18  Tom Tromey  <tromey@adacore.com>
4246
4247         * process-stratum-target.h (class process_stratum_target)
4248         <stratum>: Add "final".
4249
4250 2019-04-17  Tom Tromey  <tromey@adacore.com>
4251
4252         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4253         against nullptr before use.
4254
4255 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4256
4257         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4258
4259 2019-04-17  Jim Wilson  <jimw@sifive.com>
4260             Andrew Burgess  <andrew.burgess@embecosm.com>
4261
4262         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4263         code read might fail, assume 4-byte breakpoint in that case.
4264
4265 2019-04-15  Leszek Swirski  <leszeks@google.com>
4266
4267         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4268         rather than a hand-rolled POD check when checking for forced MEMORY
4269         classification.
4270
4271 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4272
4273         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4274         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4275         function.
4276         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4277         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4278         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4279         declaration.
4280
4281 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4282
4283         * aarch64-linux-nat.c
4284         (aarch64_linux_nat_target::thread_architecture): Add override.
4285         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4286         each VQ.
4287
4288 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4289
4290         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4291
4292 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4293
4294         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4295         target types of size 96-bits, add some additional comments, and
4296         check that the builtin type we found was the correct size.
4297
4298 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4299
4300         * utils.c (prompt_for_continue): Don't restore the styling at the
4301         end, as applied_style has the wrong value.  This fixes styling in
4302         long lists of file names that are interrupted by the "Continue?"
4303         prompt.
4304
4305 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4306
4307         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4308         * c-lang.c (c_language_defn): Likewise.
4309         (cplus_language_defn): Likewise.
4310         (asm_language_defn): Likewise.
4311         (minimal_language_defn): Likewise.
4312         * d-lang.c (d_language_defn): Likewise.
4313         * f-lang.c (f_language_defn): Likewise.
4314         * go-lang.c (go_language_defn): Likewise.
4315         * language.c (unknown_language_defn): Likewise.
4316         (auto_language_defn): Likewise.
4317         * language.h (struct language_defn): Remove la_magic field.
4318         (LANG_MAGIC): Delete.
4319         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4320         * objc-lang.c (objc_language_defn): Likewise.
4321         * opencl-lang.c (opencl_language_defn): Likewise.
4322         * p-lang.c (pascal_language_defn): Likewise.
4323         * rust-lang.c (rust_language_defn): Likewise.
4324
4325 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4326
4327         * riscv-tdep.c (riscv_type_align): New function.
4328         (riscv_type_alignment): Delete.
4329         (riscv_arg_location): Use 'type_align'.
4330         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4331
4332 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4333
4334         * gdbtypes.c (type_align): A struct with no non-static fields also
4335         has alignment of 1.
4336
4337 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4338
4339         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4340         component to 0.
4341         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4342         member.
4343         (riscv_struct_info::analyse): New implementation using new
4344         analyse_inner member function.
4345         (riscv_struct_info::field_offset): New member function.
4346         (riscv_struct_info::m_offsets): New member variable.
4347         (riscv_struct_info::analyse_inner): New private member function,
4348         takes the old implementation of riscv_struct_info::analyse but
4349         extended to track field offsets.
4350         (riscv_call_arg_struct): Update the struct folding special cases
4351         to handle cases where empty C++ structs, which are non-zero
4352         length, are found.
4353         (riscv_arg_location): Initialise the length of each location, a
4354         non-zero length now indicates the location is in use.
4355         (riscv_push_dummy_call): Allow for the first location having a
4356         non-zero offset when setting up arguments.
4357         (riscv_return_value): Likewise, but for return values.
4358
4359 2019-04-11  Tom Tromey  <tromey@adacore.com>
4360
4361         * utils.c (internal_vproblem): Make "msg" const.
4362
4363 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4364
4365         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4366         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4367         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4368         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4369
4370 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4371
4372         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4373         function.
4374         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4375         of amd64_collect_native_gregset.
4376         (amd64_linux_nat_target::store_registers): Likewise.
4377
4378 2019-04-10  Tom Tromey  <tom@tromey.com>
4379
4380         * symtab.c (lookup_global_symbol_from_objfile)
4381         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4382         * objfiles.h (class separate_debug_iterator): New.
4383         (class separate_debug_range): New.
4384         (struct objfile) <separate_debug_objfiles>: New method.
4385         (objfile_separate_debug_iterate): Don't declare.
4386         * objfiles.c (separate_debug_iterator::operator++): Rename from
4387         objfile_separate_debug_iterate.
4388         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4389         iterator.
4390         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4391         iterator.
4392
4393 2019-04-10  Tom Tromey  <tom@tromey.com>
4394
4395         * symfile.c (reread_symbols): Remove old comment.
4396         * objfiles.c (free_all_objfiles): Fix a typo.
4397
4398 2019-04-10  Tom Tromey  <tom@tromey.com>
4399
4400         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4401         * minsyms.c (lookup_minimal_symbol): Use foreach.
4402         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4403         (lookup_minimal_symbol_solib_trampoline): Likewise.
4404         * symfile.c (reread_symbols): Use foreach.
4405
4406 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4407             Tom Tromey  <tromey@adacore.com>
4408
4409         PR rust/24414:
4410         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4411         (rust_lex_int_test): Change "value" to be LONGEST.
4412         (rust_lex_tests): Add test for long integer literal.
4413
4414 2019-04-09  Tom Tromey  <tromey@adacore.com>
4415
4416         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4417         to bool.
4418         (extended_remote_target::attach): Update.
4419         (remote_target::remote_notice_new_inferior): Update.
4420         (remote_target::add_current_inferior_and_thread): Update.
4421         * inferior.c (exit_inferior_1): Use "false".
4422         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4423
4424 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4425
4426         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4427         the "start" command.
4428
4429 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4430
4431         * python/py-inferior.c (infpy_thread_from_thread_handle):
4432         Adjust comments to reflect renaming of thread_from_thread_handle
4433         to thread_from_handle.  Adjust keywords.  Fix type error message.
4434         (inferior_object_methods): Add thread_from_handle.  Retain
4435         thread_from_thread_handle, but mark it as deprecated.
4436
4437 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4438
4439         * gdbthread.h (find_thread_by_handle): Revise declaration.
4440         * thread.c (find_thread_by_handle): Likewise.  Adjust
4441         implementation too.
4442         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4443         support for buffer objects as handles.
4444
4445 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4446
4447         * python/py-infthread.c (thpy_thread_handle): New function.
4448         (thread_object_methods): Register thpy_thread_handle.
4449
4450 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4451
4452         * gdbthread.h (thread_to_thread_handle): Declare.
4453         * thread.c (gdbtypes.h): Include.
4454         (thread_to_thread_handle): New function.
4455
4456         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4457         (target_thread_info_to_thread_handle): Declare.
4458         * target.c (target_thread_info_to_thread_handle): New function.
4459         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4460         * target-delegates.c: Regenerate.
4461
4462         * linux-thread-db.c (class thread_db_target): Add method
4463         thread_info_to_thread_handle.
4464         (thread_db_target::thread_info_to_thread_handle): Define.
4465         * remote.c (class remote_target): Add new method
4466         thread_info_to_thread_handle.
4467         (remote_target::thread_info_to_thread_handle): Define.
4468
4469 2019-04-08  Pedro Alves  <palves@redhat.com>
4470
4471         * common/common-exceptions.c (throw_exception): Don't create
4472         named object to throw; throw directly.
4473         (throw_it): Likewise.  Don't initialize gdb_exception::message
4474         here, with new; pass FMT and AP to the ctor instead.
4475         * common/common-exceptions.h: Include <string>.
4476         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4477         const char *, va_list)): New ctor.  Use std::make_shared.
4478         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4479         errors)): Delete.
4480         (gdb_exception_error::gdb_exception_error(enum errors, const char
4481         *, va_list)): New.
4482         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4483         Add assertion.
4484         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4485         errors)): Delete.
4486         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4487         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4488         Add assertion.
4489
4490 2019-04-08  Tom Tromey  <tom@tromey.com>
4491
4492         * valops.c (value_rtti_indirect_type): Replace throw_exception
4493         with throw.
4494         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4495         with throw.
4496         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4497         throw.
4498         * target.c (target_translate_tls_address): Replace throw_exception
4499         with throw.
4500         * stack.c (frame_apply_command_count): Replace throw_exception
4501         with throw.
4502         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4503         throw.
4504         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4505         with throw.
4506         * rs6000-tdep.c (rs6000_frame_cache)
4507         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4508         * remote.c: Replace throw_exception with throw.
4509         * record-full.c (record_full_message, record_full_wait_1)
4510         (record_full_restore): Replace throw_exception with throw.
4511         * record-btrace.c:
4512         (get_thread_current_frame_id, record_btrace_start_replaying)
4513         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4514         (cmd_record_btrace_start): Replace throw_exception with throw.
4515         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4516         throw.
4517         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4518         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4519         * linespec.c:
4520         (find_linespec_symbols): Replace throw_exception with throw.
4521         * infrun.c (displaced_step_prepare, resume): Replace
4522         throw_exception with throw.
4523         * infcmd.c (post_create_inferior): Replace throw_exception with
4524         throw.
4525         * inf-loop.c (inferior_event_handler): Replace throw_exception
4526         with throw.
4527         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4528         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4529         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4530         (get_prev_frame_always, get_frame_pc_if_available)
4531         (get_frame_address_in_block_if_available, get_frame_language):
4532         Replace throw_exception with throw.
4533         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4534         throw_exception with throw.
4535         * eval.c (fetch_subexp_value, evaluate_var_value)
4536         (evaluate_funcall, evaluate_subexp_standard): Replace
4537         throw_exception with throw.
4538         * dwarf2loc.c (call_site_find_chain)
4539         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4540         Replace throw_exception with throw.
4541         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4542         with throw.
4543         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4544         throw.
4545         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4546         * completer.c (complete_line_internal): Replace throw_exception
4547         with throw.
4548         * compile/compile-object-run.c (compile_object_run): Replace
4549         throw_exception with throw.
4550         * cli/cli-script.c (process_next_line): Replace throw_exception
4551         with throw.
4552         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4553         (btrace_enable, btrace_maint_update_pt_packets): Replace
4554         throw_exception with throw.
4555         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4556         throw_exception with throw.
4557         * break-catch-throw.c (re_set_exception_catchpoint): Replace
4558         throw_exception with throw.
4559         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4560         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
4561         * aarch64-tdep.c (aarch64_make_prologue_cache)
4562         (aarch64_make_stub_cache): Replace throw_exception with throw.
4563
4564 2019-04-08  Tom Tromey  <tom@tromey.com>
4565
4566         * common/common-exceptions.c (throw_exception): Rename from
4567         throw_exception_cxx.  Remove old copy.  Make argument const.
4568         (throw_it): Create and throw exception objects directly.
4569         * common/common-exceptions.h (throw_exception): Make argument
4570         const.
4571         (struct gdb_exception_error): Add constructor.
4572         (struct gdb_exception_quit): Add constructor.
4573
4574 2019-04-08  Tom Tromey  <tom@tromey.com>
4575
4576         * common/common-exceptions.h (exception_rethrow): Don't declare.
4577         (TRY_SJLJ): Update comment.
4578         (TRY, CATCH, END_CATCH): Remove.
4579         * common/common-exceptions.c (exception_rethrow): Remove.
4580
4581 2019-04-08  Tom Tromey  <tom@tromey.com>
4582
4583         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
4584         Remove.
4585         (gdb_exception_error): Rename from
4586         gdb_exception_RETURN_MASK_ERROR.
4587         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
4588         (gdb_quit_bad_alloc): Update.
4589         * aarch64-tdep.c: Update.
4590         * ada-lang.c: Update.
4591         * ada-typeprint.c: Update.
4592         * ada-valprint.c: Update.
4593         * amd64-tdep.c: Update.
4594         * arch-utils.c: Update.
4595         * break-catch-throw.c: Update.
4596         * breakpoint.c: Update.
4597         * btrace.c: Update.
4598         * c-varobj.c: Update.
4599         * cli/cli-cmds.c: Update.
4600         * cli/cli-interp.c: Update.
4601         * cli/cli-script.c: Update.
4602         * common/common-exceptions.c: Update.
4603         * common/new-op.c: Update.
4604         * common/selftest.c: Update.
4605         * compile/compile-c-symbols.c: Update.
4606         * compile/compile-cplus-symbols.c: Update.
4607         * compile/compile-object-load.c: Update.
4608         * compile/compile-object-run.c: Update.
4609         * completer.c: Update.
4610         * corelow.c: Update.
4611         * cp-abi.c: Update.
4612         * cp-support.c: Update.
4613         * cp-valprint.c: Update.
4614         * darwin-nat.c: Update.
4615         * disasm-selftests.c: Update.
4616         * dtrace-probe.c: Update.
4617         * dwarf-index-cache.c: Update.
4618         * dwarf-index-write.c: Update.
4619         * dwarf2-frame-tailcall.c: Update.
4620         * dwarf2-frame.c: Update.
4621         * dwarf2loc.c: Update.
4622         * dwarf2read.c: Update.
4623         * eval.c: Update.
4624         * event-loop.c: Update.
4625         * event-top.c: Update.
4626         * exec.c: Update.
4627         * f-valprint.c: Update.
4628         * fbsd-tdep.c: Update.
4629         * frame-unwind.c: Update.
4630         * frame.c: Update.
4631         * gdbtypes.c: Update.
4632         * gnu-v3-abi.c: Update.
4633         * guile/guile-internal.h: Update.
4634         * guile/scm-block.c: Update.
4635         * guile/scm-breakpoint.c: Update.
4636         * guile/scm-cmd.c: Update.
4637         * guile/scm-disasm.c: Update.
4638         * guile/scm-frame.c: Update.
4639         * guile/scm-lazy-string.c: Update.
4640         * guile/scm-math.c: Update.
4641         * guile/scm-param.c: Update.
4642         * guile/scm-ports.c: Update.
4643         * guile/scm-pretty-print.c: Update.
4644         * guile/scm-symbol.c: Update.
4645         * guile/scm-symtab.c: Update.
4646         * guile/scm-type.c: Update.
4647         * guile/scm-value.c: Update.
4648         * i386-linux-tdep.c: Update.
4649         * i386-tdep.c: Update.
4650         * inf-loop.c: Update.
4651         * infcall.c: Update.
4652         * infcmd.c: Update.
4653         * infrun.c: Update.
4654         * jit.c: Update.
4655         * language.c: Update.
4656         * linespec.c: Update.
4657         * linux-fork.c: Update.
4658         * linux-nat.c: Update.
4659         * linux-tdep.c: Update.
4660         * linux-thread-db.c: Update.
4661         * main.c: Update.
4662         * mi/mi-cmd-break.c: Update.
4663         * mi/mi-cmd-stack.c: Update.
4664         * mi/mi-interp.c: Update.
4665         * mi/mi-main.c: Update.
4666         * objc-lang.c: Update.
4667         * p-valprint.c: Update.
4668         * parse.c: Update.
4669         * ppc-linux-tdep.c: Update.
4670         * printcmd.c: Update.
4671         * python/py-arch.c: Update.
4672         * python/py-breakpoint.c: Update.
4673         * python/py-cmd.c: Update.
4674         * python/py-finishbreakpoint.c: Update.
4675         * python/py-frame.c: Update.
4676         * python/py-framefilter.c: Update.
4677         * python/py-gdb-readline.c: Update.
4678         * python/py-inferior.c: Update.
4679         * python/py-infthread.c: Update.
4680         * python/py-lazy-string.c: Update.
4681         * python/py-linetable.c: Update.
4682         * python/py-objfile.c: Update.
4683         * python/py-param.c: Update.
4684         * python/py-prettyprint.c: Update.
4685         * python/py-progspace.c: Update.
4686         * python/py-record-btrace.c: Update.
4687         * python/py-record.c: Update.
4688         * python/py-symbol.c: Update.
4689         * python/py-type.c: Update.
4690         * python/py-unwind.c: Update.
4691         * python/py-utils.c: Update.
4692         * python/py-value.c: Update.
4693         * python/python.c: Update.
4694         * record-btrace.c: Update.
4695         * record-full.c: Update.
4696         * remote-fileio.c: Update.
4697         * remote.c: Update.
4698         * riscv-tdep.c: Update.
4699         * rs6000-aix-tdep.c: Update.
4700         * rs6000-tdep.c: Update.
4701         * rust-exp.y: Update.
4702         * rust-lang.c: Update.
4703         * s390-tdep.c: Update.
4704         * selftest-arch.c: Update.
4705         * solib-dsbt.c: Update.
4706         * solib-frv.c: Update.
4707         * solib-spu.c: Update.
4708         * solib-svr4.c: Update.
4709         * solib.c: Update.
4710         * sparc64-linux-tdep.c: Update.
4711         * stack.c: Update.
4712         * symfile-mem.c: Update.
4713         * symmisc.c: Update.
4714         * target.c: Update.
4715         * thread.c: Update.
4716         * top.c: Update.
4717         * tracefile-tfile.c: Update.
4718         * tui/tui.c: Update.
4719         * typeprint.c: Update.
4720         * unittests/cli-utils-selftests.c: Update.
4721         * unittests/parse-connection-spec-selftests.c: Update.
4722         * valops.c: Update.
4723         * valprint.c: Update.
4724         * value.c: Update.
4725         * varobj.c: Update.
4726         * windows-nat.c: Update.
4727         * x86-linux-nat.c: Update.
4728         * xml-support.c: Update.
4729
4730 2019-04-08  Tom Tromey  <tom@tromey.com>
4731
4732         * xml-support.c: Use C++ exception handling.
4733         * x86-linux-nat.c: Use C++ exception handling.
4734         * windows-nat.c: Use C++ exception handling.
4735         * varobj.c: Use C++ exception handling.
4736         * value.c: Use C++ exception handling.
4737         * valprint.c: Use C++ exception handling.
4738         * valops.c: Use C++ exception handling.
4739         * unittests/parse-connection-spec-selftests.c: Use C++ exception
4740         handling.
4741         * unittests/cli-utils-selftests.c: Use C++ exception handling.
4742         * typeprint.c: Use C++ exception handling.
4743         * tui/tui.c: Use C++ exception handling.
4744         * tracefile-tfile.c: Use C++ exception handling.
4745         * top.c: Use C++ exception handling.
4746         * thread.c: Use C++ exception handling.
4747         * target.c: Use C++ exception handling.
4748         * symmisc.c: Use C++ exception handling.
4749         * symfile-mem.c: Use C++ exception handling.
4750         * stack.c: Use C++ exception handling.
4751         * sparc64-linux-tdep.c: Use C++ exception handling.
4752         * solib.c: Use C++ exception handling.
4753         * solib-svr4.c: Use C++ exception handling.
4754         * solib-spu.c: Use C++ exception handling.
4755         * solib-frv.c: Use C++ exception handling.
4756         * solib-dsbt.c: Use C++ exception handling.
4757         * selftest-arch.c: Use C++ exception handling.
4758         * s390-tdep.c: Use C++ exception handling.
4759         * rust-lang.c: Use C++ exception handling.
4760         * rust-exp.y: Use C++ exception handling.
4761         * rs6000-tdep.c: Use C++ exception handling.
4762         * rs6000-aix-tdep.c: Use C++ exception handling.
4763         * riscv-tdep.c: Use C++ exception handling.
4764         * remote.c: Use C++ exception handling.
4765         * remote-fileio.c: Use C++ exception handling.
4766         * record-full.c: Use C++ exception handling.
4767         * record-btrace.c: Use C++ exception handling.
4768         * python/python.c: Use C++ exception handling.
4769         * python/py-value.c: Use C++ exception handling.
4770         * python/py-utils.c: Use C++ exception handling.
4771         * python/py-unwind.c: Use C++ exception handling.
4772         * python/py-type.c: Use C++ exception handling.
4773         * python/py-symbol.c: Use C++ exception handling.
4774         * python/py-record.c: Use C++ exception handling.
4775         * python/py-record-btrace.c: Use C++ exception handling.
4776         * python/py-progspace.c: Use C++ exception handling.
4777         * python/py-prettyprint.c: Use C++ exception handling.
4778         * python/py-param.c: Use C++ exception handling.
4779         * python/py-objfile.c: Use C++ exception handling.
4780         * python/py-linetable.c: Use C++ exception handling.
4781         * python/py-lazy-string.c: Use C++ exception handling.
4782         * python/py-infthread.c: Use C++ exception handling.
4783         * python/py-inferior.c: Use C++ exception handling.
4784         * python/py-gdb-readline.c: Use C++ exception handling.
4785         * python/py-framefilter.c: Use C++ exception handling.
4786         * python/py-frame.c: Use C++ exception handling.
4787         * python/py-finishbreakpoint.c: Use C++ exception handling.
4788         * python/py-cmd.c: Use C++ exception handling.
4789         * python/py-breakpoint.c: Use C++ exception handling.
4790         * python/py-arch.c: Use C++ exception handling.
4791         * printcmd.c: Use C++ exception handling.
4792         * ppc-linux-tdep.c: Use C++ exception handling.
4793         * parse.c: Use C++ exception handling.
4794         * p-valprint.c: Use C++ exception handling.
4795         * objc-lang.c: Use C++ exception handling.
4796         * mi/mi-main.c: Use C++ exception handling.
4797         * mi/mi-interp.c: Use C++ exception handling.
4798         * mi/mi-cmd-stack.c: Use C++ exception handling.
4799         * mi/mi-cmd-break.c: Use C++ exception handling.
4800         * main.c: Use C++ exception handling.
4801         * linux-thread-db.c: Use C++ exception handling.
4802         * linux-tdep.c: Use C++ exception handling.
4803         * linux-nat.c: Use C++ exception handling.
4804         * linux-fork.c: Use C++ exception handling.
4805         * linespec.c: Use C++ exception handling.
4806         * language.c: Use C++ exception handling.
4807         * jit.c: Use C++ exception handling.
4808         * infrun.c: Use C++ exception handling.
4809         * infcmd.c: Use C++ exception handling.
4810         * infcall.c: Use C++ exception handling.
4811         * inf-loop.c: Use C++ exception handling.
4812         * i386-tdep.c: Use C++ exception handling.
4813         * i386-linux-tdep.c: Use C++ exception handling.
4814         * guile/scm-value.c: Use C++ exception handling.
4815         * guile/scm-type.c: Use C++ exception handling.
4816         * guile/scm-symtab.c: Use C++ exception handling.
4817         * guile/scm-symbol.c: Use C++ exception handling.
4818         * guile/scm-pretty-print.c: Use C++ exception handling.
4819         * guile/scm-ports.c: Use C++ exception handling.
4820         * guile/scm-param.c: Use C++ exception handling.
4821         * guile/scm-math.c: Use C++ exception handling.
4822         * guile/scm-lazy-string.c: Use C++ exception handling.
4823         * guile/scm-frame.c: Use C++ exception handling.
4824         * guile/scm-disasm.c: Use C++ exception handling.
4825         * guile/scm-cmd.c: Use C++ exception handling.
4826         * guile/scm-breakpoint.c: Use C++ exception handling.
4827         * guile/scm-block.c: Use C++ exception handling.
4828         * guile/guile-internal.h: Use C++ exception handling.
4829         * gnu-v3-abi.c: Use C++ exception handling.
4830         * gdbtypes.c: Use C++ exception handling.
4831         * frame.c: Use C++ exception handling.
4832         * frame-unwind.c: Use C++ exception handling.
4833         * fbsd-tdep.c: Use C++ exception handling.
4834         * f-valprint.c: Use C++ exception handling.
4835         * exec.c: Use C++ exception handling.
4836         * event-top.c: Use C++ exception handling.
4837         * event-loop.c: Use C++ exception handling.
4838         * eval.c: Use C++ exception handling.
4839         * dwarf2read.c: Use C++ exception handling.
4840         * dwarf2loc.c: Use C++ exception handling.
4841         * dwarf2-frame.c: Use C++ exception handling.
4842         * dwarf2-frame-tailcall.c: Use C++ exception handling.
4843         * dwarf-index-write.c: Use C++ exception handling.
4844         * dwarf-index-cache.c: Use C++ exception handling.
4845         * dtrace-probe.c: Use C++ exception handling.
4846         * disasm-selftests.c: Use C++ exception handling.
4847         * darwin-nat.c: Use C++ exception handling.
4848         * cp-valprint.c: Use C++ exception handling.
4849         * cp-support.c: Use C++ exception handling.
4850         * cp-abi.c: Use C++ exception handling.
4851         * corelow.c: Use C++ exception handling.
4852         * completer.c: Use C++ exception handling.
4853         * compile/compile-object-run.c: Use C++ exception handling.
4854         * compile/compile-object-load.c: Use C++ exception handling.
4855         * compile/compile-cplus-symbols.c: Use C++ exception handling.
4856         * compile/compile-c-symbols.c: Use C++ exception handling.
4857         * common/selftest.c: Use C++ exception handling.
4858         * common/new-op.c: Use C++ exception handling.
4859         * cli/cli-script.c: Use C++ exception handling.
4860         * cli/cli-interp.c: Use C++ exception handling.
4861         * cli/cli-cmds.c: Use C++ exception handling.
4862         * c-varobj.c: Use C++ exception handling.
4863         * btrace.c: Use C++ exception handling.
4864         * breakpoint.c: Use C++ exception handling.
4865         * break-catch-throw.c: Use C++ exception handling.
4866         * arch-utils.c: Use C++ exception handling.
4867         * amd64-tdep.c: Use C++ exception handling.
4868         * ada-valprint.c: Use C++ exception handling.
4869         * ada-typeprint.c: Use C++ exception handling.
4870         * ada-lang.c: Use C++ exception handling.
4871         * aarch64-tdep.c: Use C++ exception handling.
4872
4873 2019-04-08  Tom Tromey  <tom@tromey.com>
4874
4875         * xml-support.c (gdb_xml_parser::parse): Update.
4876         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4877         * value.c (show_convenience): Update.
4878         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
4879         (test_parse_flags_qcs): Update.
4880         * thread.c (thr_try_catch_cmd): Update.
4881         * target.c (target_translate_tls_address): Update.
4882         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4883         (info_frame_command_core, frame_apply_command_count): Update.
4884         * rust-exp.y (rust_lex_exception_test): Update.
4885         * riscv-tdep.c (riscv_print_one_register_info): Update.
4886         * remote.c (remote_target::enable_btrace): Update.
4887         * record-btrace.c (record_btrace_enable_warn): Update.
4888         * python/py-utils.c (gdbpy_convert_exception): Update.
4889         * printcmd.c (do_one_display, print_variable_and_value): Update.
4890         * mi/mi-main.c (mi_print_exception): Update.
4891         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
4892         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4893         * linux-nat.c (linux_nat_target::attach): Update.
4894         * linux-fork.c (class scoped_switch_fork_info): Update.
4895         * infrun.c (displaced_step_prepare): Update.
4896         * infcall.c (call_function_by_hand_dummy): Update.
4897         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
4898         * gnu-v3-abi.c (print_one_vtable): Update.
4899         * frame.c (get_prev_frame_always): Update.
4900         * f-valprint.c (info_common_command_for_block): Update.
4901         * exec.c (try_open_exec_file): Update.
4902         * exceptions.c (print_exception, exception_print)
4903         (exception_fprintf, exception_print_same): Update.
4904         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
4905         * dwarf-index-cache.c (index_cache::store)
4906         (index_cache::lookup_gdb_index): Update.
4907         * darwin-nat.c (maybe_cache_shell): Update.
4908         * cp-valprint.c (cp_print_value_fields): Update.
4909         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
4910         (gcc_cplus_symbol_address): Update.
4911         * compile/compile-c-symbols.c (gcc_convert_symbol)
4912         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
4913         * common/selftest.c: Update.
4914         * common/common-exceptions.h (struct gdb_exception) <message>: Now
4915         a std::string.
4916         (exception_try_scope_entry, exception_try_scope_exit): Don't
4917         declare.
4918         (struct exception_try_scope): Remove.
4919         (TRY): Don't use exception_try_scope.
4920         (struct gdb_exception): Add constructor, operator=.
4921         <what>: New method.
4922         (struct gdb_exception_RETURN_MASK_ALL)
4923         (struct gdb_exception_RETURN_MASK_ERROR)
4924         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
4925         (struct gdb_quit_bad_alloc): Update.
4926         * common/common-exceptions.c (exception_none): Change
4927         initializer.
4928         (struct catcher) <state, exception>: Initialize inline.
4929         <prev>: Remove member.
4930         (current_catcher): Remove.
4931         (catchers): New global.
4932         (exceptions_state_mc_init): Simplify.
4933         (catcher_pop): Remove.
4934         (exceptions_state_mc, exceptions_state_mc_catch): Update.
4935         (try_scope_depth, exception_try_scope_entry)
4936         (exception_try_scope_exit): Remove.
4937         (throw_exception_sjlj): Update.
4938         (exception_messages, exception_messages_size): Remove.
4939         (throw_it): Simplify.
4940         (gdb_exception_sliced_copy): Remove.
4941         (throw_exception_cxx): Update.
4942         * cli/cli-script.c (script_from_file): Update.
4943         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
4944         Update.
4945         * ada-valprint.c (ada_val_print): Update.
4946         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
4947         (create_excep_cond_exprs): Update.
4948
4949 2019-04-08  Tom Tromey  <tom@tromey.com>
4950
4951         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
4952         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
4953         (TRY, CATCH, END_CATCH): Remove some definitions.
4954         * common/common-exceptions.c: Don't use GDB_XCPT.
4955         (catcher_list_size): Remove.
4956         (throw_exception, throw_it): Simplify.
4957
4958 2019-04-05  Tom Tromey  <tom@tromey.com>
4959
4960         Revert the header-sorting patch.
4961         * ft32-tdep.c: Revert.
4962         * frv-tdep.c: Revert.
4963         * frv-linux-tdep.c: Revert.
4964         * frame.c: Revert.
4965         * frame-unwind.c: Revert.
4966         * frame-base.c: Revert.
4967         * fork-child.c: Revert.
4968         * findvar.c: Revert.
4969         * findcmd.c: Revert.
4970         * filesystem.c: Revert.
4971         * filename-seen-cache.h: Revert.
4972         * filename-seen-cache.c: Revert.
4973         * fbsd-tdep.c: Revert.
4974         * fbsd-nat.h: Revert.
4975         * fbsd-nat.c: Revert.
4976         * f-valprint.c: Revert.
4977         * f-typeprint.c: Revert.
4978         * f-lang.c: Revert.
4979         * extension.h: Revert.
4980         * extension.c: Revert.
4981         * extension-priv.h: Revert.
4982         * expprint.c: Revert.
4983         * exec.h: Revert.
4984         * exec.c: Revert.
4985         * exceptions.c: Revert.
4986         * event-top.c: Revert.
4987         * event-loop.c: Revert.
4988         * eval.c: Revert.
4989         * elfread.c: Revert.
4990         * dwarf2read.h: Revert.
4991         * dwarf2read.c: Revert.
4992         * dwarf2loc.c: Revert.
4993         * dwarf2expr.h: Revert.
4994         * dwarf2expr.c: Revert.
4995         * dwarf2-frame.c: Revert.
4996         * dwarf2-frame-tailcall.c: Revert.
4997         * dwarf-index-write.h: Revert.
4998         * dwarf-index-write.c: Revert.
4999         * dwarf-index-common.c: Revert.
5000         * dwarf-index-cache.h: Revert.
5001         * dwarf-index-cache.c: Revert.
5002         * dummy-frame.c: Revert.
5003         * dtrace-probe.c: Revert.
5004         * disasm.h: Revert.
5005         * disasm.c: Revert.
5006         * disasm-selftests.c: Revert.
5007         * dictionary.c: Revert.
5008         * dicos-tdep.c: Revert.
5009         * demangle.c: Revert.
5010         * dcache.h: Revert.
5011         * dcache.c: Revert.
5012         * darwin-nat.h: Revert.
5013         * darwin-nat.c: Revert.
5014         * darwin-nat-info.c: Revert.
5015         * d-valprint.c: Revert.
5016         * d-namespace.c: Revert.
5017         * d-lang.c: Revert.
5018         * ctf.c: Revert.
5019         * csky-tdep.c: Revert.
5020         * csky-linux-tdep.c: Revert.
5021         * cris-tdep.c: Revert.
5022         * cris-linux-tdep.c: Revert.
5023         * cp-valprint.c: Revert.
5024         * cp-support.c: Revert.
5025         * cp-namespace.c: Revert.
5026         * cp-abi.c: Revert.
5027         * corelow.c: Revert.
5028         * corefile.c: Revert.
5029         * continuations.c: Revert.
5030         * completer.h: Revert.
5031         * completer.c: Revert.
5032         * complaints.c: Revert.
5033         * coffread.c: Revert.
5034         * coff-pe-read.c: Revert.
5035         * cli-out.h: Revert.
5036         * cli-out.c: Revert.
5037         * charset.c: Revert.
5038         * c-varobj.c: Revert.
5039         * c-valprint.c: Revert.
5040         * c-typeprint.c: Revert.
5041         * c-lang.c: Revert.
5042         * buildsym.c: Revert.
5043         * buildsym-legacy.c: Revert.
5044         * build-id.h: Revert.
5045         * build-id.c: Revert.
5046         * btrace.c: Revert.
5047         * bsd-uthread.c: Revert.
5048         * breakpoint.h: Revert.
5049         * breakpoint.c: Revert.
5050         * break-catch-throw.c: Revert.
5051         * break-catch-syscall.c: Revert.
5052         * break-catch-sig.c: Revert.
5053         * blockframe.c: Revert.
5054         * block.c: Revert.
5055         * bfin-tdep.c: Revert.
5056         * bfin-linux-tdep.c: Revert.
5057         * bfd-target.c: Revert.
5058         * bcache.c: Revert.
5059         * ax-general.c: Revert.
5060         * ax-gdb.h: Revert.
5061         * ax-gdb.c: Revert.
5062         * avr-tdep.c: Revert.
5063         * auxv.c: Revert.
5064         * auto-load.c: Revert.
5065         * arm-wince-tdep.c: Revert.
5066         * arm-tdep.c: Revert.
5067         * arm-symbian-tdep.c: Revert.
5068         * arm-pikeos-tdep.c: Revert.
5069         * arm-obsd-tdep.c: Revert.
5070         * arm-nbsd-tdep.c: Revert.
5071         * arm-nbsd-nat.c: Revert.
5072         * arm-linux-tdep.c: Revert.
5073         * arm-linux-nat.c: Revert.
5074         * arm-fbsd-tdep.c: Revert.
5075         * arm-fbsd-nat.c: Revert.
5076         * arm-bsd-tdep.c: Revert.
5077         * arch-utils.c: Revert.
5078         * arc-tdep.c: Revert.
5079         * arc-newlib-tdep.c: Revert.
5080         * annotate.h: Revert.
5081         * annotate.c: Revert.
5082         * amd64-windows-tdep.c: Revert.
5083         * amd64-windows-nat.c: Revert.
5084         * amd64-tdep.c: Revert.
5085         * amd64-sol2-tdep.c: Revert.
5086         * amd64-obsd-tdep.c: Revert.
5087         * amd64-obsd-nat.c: Revert.
5088         * amd64-nbsd-tdep.c: Revert.
5089         * amd64-nbsd-nat.c: Revert.
5090         * amd64-nat.c: Revert.
5091         * amd64-linux-tdep.c: Revert.
5092         * amd64-linux-nat.c: Revert.
5093         * amd64-fbsd-tdep.c: Revert.
5094         * amd64-fbsd-nat.c: Revert.
5095         * amd64-dicos-tdep.c: Revert.
5096         * amd64-darwin-tdep.c: Revert.
5097         * amd64-bsd-nat.c: Revert.
5098         * alpha-tdep.c: Revert.
5099         * alpha-obsd-tdep.c: Revert.
5100         * alpha-nbsd-tdep.c: Revert.
5101         * alpha-mdebug-tdep.c: Revert.
5102         * alpha-linux-tdep.c: Revert.
5103         * alpha-linux-nat.c: Revert.
5104         * alpha-bsd-tdep.c: Revert.
5105         * alpha-bsd-nat.c: Revert.
5106         * aix-thread.c: Revert.
5107         * agent.c: Revert.
5108         * addrmap.c: Revert.
5109         * ada-varobj.c: Revert.
5110         * ada-valprint.c: Revert.
5111         * ada-typeprint.c: Revert.
5112         * ada-tasks.c: Revert.
5113         * ada-lang.c: Revert.
5114         * aarch64-tdep.c: Revert.
5115         * aarch64-ravenscar-thread.c: Revert.
5116         * aarch64-newlib-tdep.c: Revert.
5117         * aarch64-linux-tdep.c: Revert.
5118         * aarch64-linux-nat.c: Revert.
5119         * aarch64-fbsd-tdep.c: Revert.
5120         * aarch64-fbsd-nat.c: Revert.
5121         * aarch32-linux-nat.c: Revert.
5122
5123 2019-04-05  Tom Tromey  <tom@tromey.com>
5124
5125         * ft32-tdep.c: Sort headers.
5126         * frv-tdep.c: Sort headers.
5127         * frv-linux-tdep.c: Sort headers.
5128         * frame.c: Sort headers.
5129         * frame-unwind.c: Sort headers.
5130         * frame-base.c: Sort headers.
5131         * fork-child.c: Sort headers.
5132         * findvar.c: Sort headers.
5133         * findcmd.c: Sort headers.
5134         * filesystem.c: Sort headers.
5135         * filename-seen-cache.h: Sort headers.
5136         * filename-seen-cache.c: Sort headers.
5137         * fbsd-tdep.c: Sort headers.
5138         * fbsd-nat.h: Sort headers.
5139         * fbsd-nat.c: Sort headers.
5140         * f-valprint.c: Sort headers.
5141         * f-typeprint.c: Sort headers.
5142         * f-lang.c: Sort headers.
5143         * extension.h: Sort headers.
5144         * extension.c: Sort headers.
5145         * extension-priv.h: Sort headers.
5146         * expprint.c: Sort headers.
5147         * exec.h: Sort headers.
5148         * exec.c: Sort headers.
5149         * exceptions.c: Sort headers.
5150         * event-top.c: Sort headers.
5151         * event-loop.c: Sort headers.
5152         * eval.c: Sort headers.
5153         * elfread.c: Sort headers.
5154         * dwarf2read.h: Sort headers.
5155         * dwarf2read.c: Sort headers.
5156         * dwarf2loc.c: Sort headers.
5157         * dwarf2expr.h: Sort headers.
5158         * dwarf2expr.c: Sort headers.
5159         * dwarf2-frame.c: Sort headers.
5160         * dwarf2-frame-tailcall.c: Sort headers.
5161         * dwarf-index-write.h: Sort headers.
5162         * dwarf-index-write.c: Sort headers.
5163         * dwarf-index-common.c: Sort headers.
5164         * dwarf-index-cache.h: Sort headers.
5165         * dwarf-index-cache.c: Sort headers.
5166         * dummy-frame.c: Sort headers.
5167         * dtrace-probe.c: Sort headers.
5168         * disasm.h: Sort headers.
5169         * disasm.c: Sort headers.
5170         * disasm-selftests.c: Sort headers.
5171         * dictionary.c: Sort headers.
5172         * dicos-tdep.c: Sort headers.
5173         * demangle.c: Sort headers.
5174         * dcache.h: Sort headers.
5175         * dcache.c: Sort headers.
5176         * darwin-nat.h: Sort headers.
5177         * darwin-nat.c: Sort headers.
5178         * darwin-nat-info.c: Sort headers.
5179         * d-valprint.c: Sort headers.
5180         * d-namespace.c: Sort headers.
5181         * d-lang.c: Sort headers.
5182         * ctf.c: Sort headers.
5183         * csky-tdep.c: Sort headers.
5184         * csky-linux-tdep.c: Sort headers.
5185         * cris-tdep.c: Sort headers.
5186         * cris-linux-tdep.c: Sort headers.
5187         * cp-valprint.c: Sort headers.
5188         * cp-support.c: Sort headers.
5189         * cp-namespace.c: Sort headers.
5190         * cp-abi.c: Sort headers.
5191         * corelow.c: Sort headers.
5192         * corefile.c: Sort headers.
5193         * continuations.c: Sort headers.
5194         * completer.h: Sort headers.
5195         * completer.c: Sort headers.
5196         * complaints.c: Sort headers.
5197         * coffread.c: Sort headers.
5198         * coff-pe-read.c: Sort headers.
5199         * cli-out.h: Sort headers.
5200         * cli-out.c: Sort headers.
5201         * charset.c: Sort headers.
5202         * c-varobj.c: Sort headers.
5203         * c-valprint.c: Sort headers.
5204         * c-typeprint.c: Sort headers.
5205         * c-lang.c: Sort headers.
5206         * buildsym.c: Sort headers.
5207         * buildsym-legacy.c: Sort headers.
5208         * build-id.h: Sort headers.
5209         * build-id.c: Sort headers.
5210         * btrace.c: Sort headers.
5211         * bsd-uthread.c: Sort headers.
5212         * breakpoint.h: Sort headers.
5213         * breakpoint.c: Sort headers.
5214         * break-catch-throw.c: Sort headers.
5215         * break-catch-syscall.c: Sort headers.
5216         * break-catch-sig.c: Sort headers.
5217         * blockframe.c: Sort headers.
5218         * block.c: Sort headers.
5219         * bfin-tdep.c: Sort headers.
5220         * bfin-linux-tdep.c: Sort headers.
5221         * bfd-target.c: Sort headers.
5222         * bcache.c: Sort headers.
5223         * ax-general.c: Sort headers.
5224         * ax-gdb.h: Sort headers.
5225         * ax-gdb.c: Sort headers.
5226         * avr-tdep.c: Sort headers.
5227         * auxv.c: Sort headers.
5228         * auto-load.c: Sort headers.
5229         * arm-wince-tdep.c: Sort headers.
5230         * arm-tdep.c: Sort headers.
5231         * arm-symbian-tdep.c: Sort headers.
5232         * arm-pikeos-tdep.c: Sort headers.
5233         * arm-obsd-tdep.c: Sort headers.
5234         * arm-nbsd-tdep.c: Sort headers.
5235         * arm-nbsd-nat.c: Sort headers.
5236         * arm-linux-tdep.c: Sort headers.
5237         * arm-linux-nat.c: Sort headers.
5238         * arm-fbsd-tdep.c: Sort headers.
5239         * arm-fbsd-nat.c: Sort headers.
5240         * arm-bsd-tdep.c: Sort headers.
5241         * arch-utils.c: Sort headers.
5242         * arc-tdep.c: Sort headers.
5243         * arc-newlib-tdep.c: Sort headers.
5244         * annotate.h: Sort headers.
5245         * annotate.c: Sort headers.
5246         * amd64-windows-tdep.c: Sort headers.
5247         * amd64-windows-nat.c: Sort headers.
5248         * amd64-tdep.c: Sort headers.
5249         * amd64-sol2-tdep.c: Sort headers.
5250         * amd64-obsd-tdep.c: Sort headers.
5251         * amd64-obsd-nat.c: Sort headers.
5252         * amd64-nbsd-tdep.c: Sort headers.
5253         * amd64-nbsd-nat.c: Sort headers.
5254         * amd64-nat.c: Sort headers.
5255         * amd64-linux-tdep.c: Sort headers.
5256         * amd64-linux-nat.c: Sort headers.
5257         * amd64-fbsd-tdep.c: Sort headers.
5258         * amd64-fbsd-nat.c: Sort headers.
5259         * amd64-dicos-tdep.c: Sort headers.
5260         * amd64-darwin-tdep.c: Sort headers.
5261         * amd64-bsd-nat.c: Sort headers.
5262         * alpha-tdep.c: Sort headers.
5263         * alpha-obsd-tdep.c: Sort headers.
5264         * alpha-nbsd-tdep.c: Sort headers.
5265         * alpha-mdebug-tdep.c: Sort headers.
5266         * alpha-linux-tdep.c: Sort headers.
5267         * alpha-linux-nat.c: Sort headers.
5268         * alpha-bsd-tdep.c: Sort headers.
5269         * alpha-bsd-nat.c: Sort headers.
5270         * aix-thread.c: Sort headers.
5271         * agent.c: Sort headers.
5272         * addrmap.c: Sort headers.
5273         * ada-varobj.c: Sort headers.
5274         * ada-valprint.c: Sort headers.
5275         * ada-typeprint.c: Sort headers.
5276         * ada-tasks.c: Sort headers.
5277         * ada-lang.c: Sort headers.
5278         * aarch64-tdep.c: Sort headers.
5279         * aarch64-ravenscar-thread.c: Sort headers.
5280         * aarch64-newlib-tdep.c: Sort headers.
5281         * aarch64-linux-tdep.c: Sort headers.
5282         * aarch64-linux-nat.c: Sort headers.
5283         * aarch64-fbsd-tdep.c: Sort headers.
5284         * aarch64-fbsd-nat.c: Sort headers.
5285         * aarch32-linux-nat.c: Sort headers.
5286
5287 2019-04-04  Tom Tromey  <tom@tromey.com>
5288
5289         * varobj.c (varobj_create): Update.
5290         * rust-exp.y (struct rust_parser) <update_innermost_block,
5291         lookup_symbol>: New methods.
5292         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5293         Rename.
5294         (rust_parser::rust_lookup_type)
5295         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5296         * printcmd.c (display_command, do_one_display): Update.
5297         * parser-defs.h (struct parser_state) <parser_state>: Add
5298         "tracker" parameter.
5299         (block_tracker): New member.
5300         (class innermost_block_tracker) <innermost_block_tracker>: Add
5301         "types" parameter.
5302         <reset>: Remove method.
5303         (innermost_block): Don't declare.
5304         (null_post_parser): Update.
5305         * parse.c (innermost_block): Remove global.
5306         (write_dollar_variable): Update.
5307         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5308         Remove "tracker_types" parameter.
5309         (parse_expression): Add "tracker" parameter.
5310         (parse_expression_for_completion): Update.
5311         (null_post_parser): Add "tracker" parameter.
5312         * p-exp.y: Update rules.
5313         * m2-exp.y: Update rules.
5314         * language.h (struct language_defn) <la_post_parser>: Add
5315         "tracker" parameter.
5316         * go-exp.y: Update rules.
5317         * f-exp.y: Update rules.
5318         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5319         parameter.
5320         * d-exp.y: Update rules.
5321         * c-exp.y: Update rules.
5322         * breakpoint.c (set_breakpoint_condition): Create an
5323         innermost_block_tracker.
5324         (watch_command_1): Likewise.
5325         * ada-lang.c (resolve): Add "tracker" parameter.
5326         (resolve_subexp): Likewise.
5327         * ada-exp.y (write_var_from_sym): Update.
5328
5329 2019-04-04  Tom Tromey  <tom@tromey.com>
5330
5331         * type-stack.h: New file.
5332         * type-stack.c: New file.
5333         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5334         type-stack.h.
5335         (insert_into_type_stack, insert_type, push_type, push_type_int)
5336         (insert_type_address_space, pop_type, pop_type_int)
5337         (pop_typelist, pop_type_stack, append_type_stack)
5338         (push_type_stack, get_type_stack, push_typelist)
5339         (follow_type_instance_flags, follow_types): Don't declare.
5340         * parse.c (type_stack): Remove global.
5341         (parse_exp_in_context): Update.
5342         (insert_into_type_stack, insert_type, push_type, push_type_int)
5343         (insert_type_address_space, pop_type, pop_type_int)
5344         (pop_typelist, pop_type_stack, append_type_stack)
5345         (push_type_stack, get_type_stack, push_typelist)
5346         (follow_type_instance_flags, follow_types): Remove (moved to
5347         type-stack.c).
5348         * f-exp.y (type_stack): New global.
5349         Update rules.
5350         (push_kind_type, f_parse): Update.
5351         * d-exp.y (type_stack): New global.
5352         Update rules.
5353         (d_parse): Update.
5354         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5355         Update rules.
5356         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5357         (HFILES_NO_SRCDIR): Add type-stack.h.
5358
5359 2019-04-04  Tom Tromey  <tom@tromey.com>
5360
5361         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5362         (rust_parser::convert_ast_to_expression, rust_parse)
5363         (rust_lex_test_completion, rust_lex_tests): Update.
5364         * parser-defs.h (struct expr_completion_state): New.
5365         (struct parser_state) <parser_state>: Add completion parameter.
5366         <mark_struct_expression, mark_completion_tag>: New methods.
5367         <parse_completion, m_completion_state>: New members.
5368         (prefixify_expression, null_post_parser): Update.
5369         (mark_struct_expression, mark_completion_tag): Don't declare.
5370         * parse.c (parse_completion, expout_last_struct)
5371         (expout_tag_completion_type, expout_completion_name): Remove
5372         globals.
5373         (parser_state::mark_struct_expression)
5374         (parser_state::mark_completion_tag): Now methods.
5375         (prefixify_expression): Add last_struct parameter.
5376         (prefixify_subexp): Likewise.
5377         (parse_exp_1): Update.
5378         (parse_exp_in_context): Add cstate parameter.  Update.
5379         (parse_expression_for_completion): Create an
5380         expr_completion_state.
5381         (null_post_parser): Add "completion" parameter.
5382         * p-exp.y: Update rules.
5383         (yylex): Update.
5384         * language.h (struct language_defn) <la_post_parser>: Add
5385         "completing" parameter.
5386         * go-exp.y: Update rules.
5387         (lex_one_token): Update.
5388         * expression.h (parse_completion): Don't declare.
5389         * d-exp.y: Update rules.
5390         (lex_one_token): Update rules.
5391         * c-exp.y: Update rules.
5392         (lex_one_token): Update.
5393         * ada-lang.c (resolve): Add "parse_completion" parameter.
5394         (resolve_subexp): Likewise.
5395         (ada_resolve_function): Likewise.
5396
5397 2019-04-04  Tom Tromey  <tom@tromey.com>
5398
5399         * parser-defs.h (struct parser_state) <start_arglist,
5400         end_arglist>: New methods.
5401         <arglist_len, m_funcall_chain>: New members.
5402         (arglist_len, start_arglist, end_arglist): Don't declare.
5403         * parse.c (arglist_len, funcall_chain): Remove global.
5404         (start_arglist, end_arglist): Remove functions.
5405         (parse_exp_in_context): Update.
5406         * p-exp.y: Update rules.
5407         * m2-exp.y: Update rules.
5408         * go-exp.y: Update rules.
5409         * f-exp.y: Update rules.
5410         * d-exp.y: Update rules.
5411         * c-exp.y: Update rules.
5412
5413 2019-04-04  Tom Tromey  <tom@tromey.com>
5414
5415         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5416         lex_operator, push_back>: New methods.
5417         Update all rules.
5418         (rust_parser::lex_hex, lex_escape): Rename and update.
5419         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5420         (rust_parser::lex_operator): Rename and update.
5421         (rust_parser::lex_number, rustyylex, rustyyerror)
5422         (rust_lex_test_init, rust_lex_test_sequence)
5423         (rust_lex_test_push_back, rust_lex_tests): Update.
5424         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5425         parameter.
5426         <lexptr, prev_lexptr>: New members.
5427         (lexptr, prev_lexptr): Don't declare.
5428         * parse.c (lexptr, prev_lexptr): Remove globals.
5429         (parse_exp_in_context): Update.
5430         * p-exp.y (yylex, yyerror): Update.
5431         * m2-exp.y (parse_number, yylex, yyerror): Update.
5432         * go-exp.y (lex_one_token, yyerror): Update.
5433         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5434         * d-exp.y (lex_one_token, yyerror): Update.
5435         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5436         (lex_one_token, yyerror): Update.
5437         * ada-lex.l (YY_INPUT): Update.
5438         (rewind_to_char): Update.
5439         * ada-exp.y (yyerror): Update.
5440
5441 2019-04-04  Tom Tromey  <tom@tromey.com>
5442
5443         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5444         * parser-defs.h (struct parser_state) <parser_state>: Add new
5445         parameter.
5446         <comma_terminates>: New member.
5447         (comma_terminates): Don't declare global.
5448         * parse.c (comma_terminates): Remove global.
5449         (parse_exp_in_context): Update.
5450         * p-exp.y (yylex): Update.
5451         * m2-exp.y (yylex): Update.
5452         * go-exp.y (lex_one_token): Update.
5453         * f-exp.y (yylex): Update.
5454         * d-exp.y (lex_one_token): Update.
5455         * c-exp.y (lex_one_token): Update.
5456         * ada-lex.l: Update.
5457
5458 2019-04-04  Tom Tromey  <tom@tromey.com>
5459
5460         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5461         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5462         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5463         * parser-defs.h (paren_depth): Don't declare.
5464         * parse.c (paren_depth): Remove global.
5465         (parse_exp_in_context): Update.
5466         * p-exp.y (paren_depth): New global.
5467         (pascal_parse): Initialize it.
5468         * m2-exp.y (paren_depth): New global.
5469         (m2_parse): Initialize it.
5470         * go-exp.y (paren_depth): New global.
5471         (go_parse): Initialize it.
5472         * f-exp.y (paren_depth): New global.
5473         (f_parse): Initialize it.
5474         * d-exp.y (paren_depth): New global.
5475         (d_parse): Initialize it.
5476         * c-exp.y (paren_depth): New global.
5477         (c_parse): Initialize it.
5478         * ada-lex.l (paren_depth): New global.
5479         (lexer_init): Initialize it.
5480
5481 2019-04-04  Tom Tromey  <tom@tromey.com>
5482
5483         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5484         (rust_parser::convert_ast_to_type)
5485         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5486         * parser-defs.h (struct parser_state) <parser_state>: Add
5487         parameters.  Initialize new members.
5488         <expression_context_block, expression_context_pc>: New members.
5489         * parse.c (expression_context_block, expression_context_pc):
5490         Remove globals.
5491         (parse_exp_in_context): Update.
5492         * p-exp.y: Update all rules.
5493         (yylex): Update.
5494         * m2-exp.y: Update all rules.
5495         (yylex): Update.
5496         * go-exp.y (yylex): Update.
5497         * f-exp.y (yylex): Update.
5498         * d-exp.y: Update all rules.
5499         (yylex): Update.
5500         * c-exp.y: Update all rules.
5501         (lex_one_token, classify_name, yylex, c_parse): Update.
5502         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5503
5504 2019-04-04  Tom Tromey  <tom@tromey.com>
5505
5506         * gdbarch.h, gdbarch.c: Rebuild.
5507         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5508         * stap-probe.h:
5509         (struct stap_parse_info): Replace "parser_state" with
5510         "expr_builder".
5511         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5512         (parser_state): New class.
5513         * parse.c (expr_builder): Rename.
5514         (expr_builder::release): Rename.
5515         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5516         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5517         (write_exp_elt_longcst, write_exp_elt_floatcst)
5518         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5519         (write_exp_string_vector, write_exp_bitstring)
5520         (write_exp_msymbol, mark_struct_expression)
5521         (write_dollar_variable)
5522         (insert_type_address_space, increase_expout_size): Replace
5523         "parser_state" with "expr_builder".
5524         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5525         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5526         "parser_state" with "expr_builder".
5527
5528 2019-04-04  Tom Tromey  <tom@tromey.com>
5529
5530         * rust-exp.y: Replace "parse_language" with method call.
5531         * p-exp.y:
5532         (yylex): Replace "parse_language" with method call.
5533         * m2-exp.y:
5534         (yylex): Replace "parse_language" with method call.
5535         * go-exp.y (classify_name): Replace "parse_language" with method
5536         call.
5537         * f-exp.y (yylex): Replace "parse_language" with method call.
5538         * d-exp.y (lex_one_token): Replace "parse_language" with method
5539         call.
5540         * c-exp.y:
5541         (lex_one_token, classify_name, yylex): Replace "parse_language"
5542         with method call.
5543         * ada-exp.y (find_primitive_type, type_char)
5544         (type_system_address): Replace "parse_language" with method call.
5545
5546 2019-04-04  Tom Tromey  <tom@tromey.com>
5547
5548         * rust-exp.y: Replace "parse_gdbarch" with method call.
5549         * parse.c (write_dollar_variable, insert_type_address_space):
5550         Replace "parse_gdbarch" with method call.
5551         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5552         call.
5553         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5554         call.
5555         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5556         "parse_gdbarch" with method call.
5557         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5558         with method call.
5559         * f-exp.y (parse_type, parse_f_type, yylex): Replace
5560         "parse_gdbarch" with method call.
5561         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
5562         "parse_gdbarch" with method call.
5563         * c-exp.y (parse_type, parse_number, classify_name): Replace
5564         "parse_gdbarch" with method call.
5565         * ada-lex.l: Replace "parse_gdbarch" with method call.
5566         * ada-exp.y (parse_type, find_primitive_type, type_char)
5567         (type_system_address): Replace "parse_gdbarch" with method call.
5568
5569 2019-04-04  Tom Tromey  <tom@tromey.com>
5570
5571         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
5572         * stap-probe.c (stap_parse_argument): Update.
5573         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
5574         initial_size parameter.
5575         * rust-exp.y (rust_lex_tests): Update.
5576         * parse.c (parser_state): Update.
5577         (parse_exp_in_context): Update.
5578         * parser-defs.h (struct parser_state) <parser_state>: Remove
5579         "initial_size" parameter.
5580
5581 2019-04-04  Tom Tromey  <tom@tromey.com>
5582
5583         * parser-defs.h (increase_expout_size): Don't declare.
5584         * parse.c (increase_expout_size): Now static.
5585
5586 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
5587
5588         * gnu-nat.c (gnu_nat_target::wait): Fix
5589         target_waitstatus_to_string call.
5590
5591 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5592
5593         * eval.c (evaluate_subexp_standard): Handle internal functions
5594         during Fortran function call handling.
5595
5596 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5597
5598         * NEWS: Mention new internal functions.
5599         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
5600         (read_base_type): Use dwarf2_init_complex_target_type.
5601         * value.c (creal_internal_fn): New function.
5602         (cimag_internal_fn): New function.
5603         (_initialize_values): Register new internal functions.
5604
5605 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5606
5607         * infrun.c (stop_all_threads): If debug_infrun, always
5608         trace the wait status after wait_one, using
5609         target_waitstatus_to_string and target_pid_to_str.
5610         (handle_inferior_event): Replace various trace of
5611         wait status kind by a single trace.
5612         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
5613         wait status kind image by target_waitstatus_to_string.
5614         * target/waitstatus.c (target_waitstatus_to_string): Fix
5615         obsolete comment.
5616
5617 2019-04-01  Tom Tromey  <tromey@adacore.com>
5618
5619         PR symtab/23331:
5620         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
5621
5622 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5623             Pedro Alves  <palves@redhat.com>
5624
5625         * top.c (quit_force): Call 'finalize_values'.
5626         * value.c (finalize_values): New function.
5627         * value.h (finalize_values): Declare.
5628
5629 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
5630
5631         * NEWS: Announce $_gdb_major and $_gdb_minor.
5632
5633         * top.c (init_gdb_version_vars): New function.
5634         (gdb_init): Call init_gdb_version_vars.
5635
5636 2019-03-29  Tom Tromey  <tromey@adacore.com>
5637
5638         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
5639         help text.  Remove dead code.
5640
5641 2019-03-29  Keith Seitz  <keiths@redhat.com>
5642
5643         From Siddhesh Poyarekar:
5644         * f-lang.h (f77_get_upperbound): Return LONGEST.
5645         (f77_get_lowerbound): Likewise.
5646         * f-typeprint.c (f_type_print_varspec_suffix): Expand
5647         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
5648         print them.
5649         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
5650         plongest to format print it.
5651         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
5652         (f77_get_upperbound): Likewise.
5653         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
5654         LOWER_BOUND to LONGEST.
5655         (f77_create_arrayprint_offset_tbl): Likewise.
5656
5657 2019-03-29  Keith Seitz  <keiths@redhat.com>
5658
5659         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
5660         %s/pulongest for TYPE_LENGTH instead of %d in format
5661         strings.
5662         * ada-typerint.c (ada_print_type): Likewise.
5663         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
5664         * compile/compile-c-support.c (generate_register_struct): Likewise.
5665         * gdbtypes.c (recursive_dump_type): Likewise.
5666         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
5667         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
5668         instead of %d in format strings.
5669         * riscv-tdep.c (riscv_type_alignment): Cast second argument
5670         to std::min to ULONGEST.
5671         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
5672         instead of %d in format strings.
5673         * tracepoint.c (info_scope_command): Likewise.
5674         * typeprint.c (print_offset_data::update)
5675         (print_offset_data::finish): Likewise.
5676         * xtensa-tdep.c (xtensa_store_return_value)
5677         (xtensa_push_dummy_call): Likewise.
5678
5679 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
5680
5681         * windows-nat.c (display_selector): Fixed format specifications
5682         for 64-bit Cygwin.
5683
5684 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5685
5686         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
5687
5688 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
5689
5690         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
5691         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
5692         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
5693         (nios2_linux_init_abi): Install it.
5694
5695 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5696
5697         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
5698
5699 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5700
5701         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
5702
5703 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5704             Tom Tromey  <tromey@adacore.com>
5705
5706         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
5707
5708 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
5709
5710         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
5711         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
5712         method to compute the bounds of range types. Also print "[evaluated]"
5713         if the bounds' values come from a dynamic evaluation.
5714
5715 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5716
5717         * cp-valprint.c (cp_print_value_fields): Don't print trailing
5718         whitespace when pretty printing is on.
5719
5720 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5721
5722         * ppc-linux-nat.c: Add include.
5723
5724 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5725
5726         * NEWS: Mention AArch64 Pointer Authentication.
5727
5728 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5729
5730         * arm-linux-nat.c: Add include.
5731
5732 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
5733
5734         * source-cache.c (source_cache::get_source_lines): Re-read
5735         fullname after calling open_source_file.
5736
5737 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
5738
5739         * NEWS: Mention TLS support for FreeBSD.
5740
5741 2019-03-25  Tom Tromey  <tromey@adacore.com>
5742
5743         * minsyms.c (BUNCH_SIZE): Update comment.
5744         (~minimal_symbol_reader): Remove old comment.
5745         (compact_minimal_symbols): Update comment.
5746         (minimal_symbol_reader::install): Remove old comment.  Update
5747         other comments.
5748
5749 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5750
5751         * s390-linux-nat.c: Add include.
5752
5753 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5754
5755         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5756         Call linux_get_hwcap.
5757         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
5758         Likewise.
5759         (aarch64_linux_get_hwcap): Remove function.
5760         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
5761         declaration.
5762         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
5763         linux_get_hwcap.
5764         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5765         * linux-tdep.c (linux_get_hwcap): Add function.
5766         (linux_get_hwcap2): Likewise.
5767         * linux-tdep.h (linux_get_hwcap): Add declaration.
5768         (linux_get_hwcap2): Likewise.
5769         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
5770         (ppc_linux_get_hwcap2): Likewise.
5771         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
5772         linux_get_hwcap.
5773         (ppc_linux_nat_target::insert_watchpoint): Likewise.
5774         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
5775         (ppc_linux_nat_target::read_description): Likewise.
5776         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
5777         * s390-linux-nat.c: Likewise.
5778         * s390-linux-tdep.c (s390_core_read_description): Likewise.
5779
5780 2019-03-24  Tom Tromey  <tom@tromey.com>
5781
5782         * ada-lang.c (standard_lookup): Simplify initialization.
5783         (ada_lookup_symbol_nonlocal): Simplify return.
5784         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
5785         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
5786         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
5787         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
5788         initialization.
5789         * solib.c (solib_global_lookup): Simplify.
5790         * symtab.c (null_block_symbol): Remove.
5791         (symbol_cache_lookup): Simplify returns.
5792         (lookup_language_this): Simplify returns.
5793         (lookup_symbol_aux): Simplify return.
5794         (lookup_local_symbol): Simplify returns.
5795         (lookup_global_symbol_from_objfile): Simplify return.
5796         (lookup_symbol_in_objfile_symtabs)
5797         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
5798         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
5799         (lookup_static_symbol, lookup_global_symbol): Simplify return.
5800         * cp-namespace.c (cp_lookup_bare_symbol)
5801         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
5802         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
5803         (cp_lookup_nested_symbol): Don't use null_block_symbol.
5804         (cp_lookup_symbol_via_imports): Simplify initialization.
5805         (find_symbol_in_baseclass): Likewise.
5806         * symtab.h (null_block_symbol): Remove.
5807         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
5808         (d_lookup_nested_symbol, d_lookup_symbol_imports)
5809         (d_lookup_symbol_module): Likewise.
5810         (find_symbol_in_baseclass): Simplify initialization.
5811
5812 2019-03-24  Tom Tromey  <tom@tromey.com>
5813
5814         * expression.h: Don't include symtab.h.
5815         (struct block): Forward declare.
5816
5817 2019-03-24  Tom Tromey  <tom@tromey.com>
5818
5819         * c-exp.y (typebase): Remove casts.
5820         * gdbtypes.c (lookup_unsigned_typename, )
5821         (lookup_signed_typename): Remove cast.
5822         * eval.c (parse_to_comma_and_eval): Remove cast.
5823         * parse.c (write_dollar_variable): Remove cast.
5824         * block.h (struct block) <superblock>: Now const.
5825         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
5826         * psymtab.c (psym_map_matching_symbols): Make "block" const.
5827         (map_block): Make "block" const.
5828         * symfile.h (struct quick_symbol_functions)
5829         <map_matching_symbols>: Constify block argument to "callback".
5830         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
5831         const.
5832         (find_pc_sect_compunit_symtab): Make "b" const.
5833         (find_symbol_at_address): Likewise.
5834         (search_symbols): Likewise.
5835         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
5836         (dw2_debug_names_lookup_symbol): Likewise.
5837         (dw2_map_matching_symbols): Update.
5838         * p-valprint.c (pascal_val_print): Remove "block".
5839         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
5840         (aux_add_nonlocal_symbols): Make "block" const.
5841         (resolve_subexp): Remove cast.
5842         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
5843         const.
5844         (iterate_over_file_blocks): Likewise.
5845         * f-exp.y (%union) <bval>: Remove.
5846         * coffread.c (patch_opaque_types): Make "b" const.
5847         * spu-tdep.c (spu_catch_start): Make "block" const.
5848         * c-valprint.c (print_unpacked_pointer): Remove "block".
5849         * symmisc.c (dump_symtab_1): Make "b" const.
5850         (block_depth): Make "block" const.
5851         * d-exp.y (%union) <bval>: Remove.
5852         * cp-support.h (cp_lookup_rtti_type): Update.
5853         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
5854         * psymtab.c (psym_lookup_symbol): Make "block" const.
5855         (maintenance_check_psymtabs): Make "b" const.
5856         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
5857         (enumerate_locals, enumerate_args): Update.
5858         * python/py-symtab.c (stpy_global_block): Make "block" const.
5859         (stpy_static_block): Likewise.
5860         * inline-frame.c (block_starting_point_at): Make "new_block"
5861         const.
5862         * block.c (find_block_in_blockvector): Make return type const.
5863         (blockvector_for_pc_sect): Make "b" const.
5864         (find_block_in_blockvector): Make "b" const.
5865
5866 2019-03-23  Tom Tromey  <tom@tromey.com>
5867
5868         * varobj.c (varobj_create): Update.
5869         * symfile.c (clear_symtab_users): Don't reset innermost_block.
5870         * printcmd.c (display_command, do_one_display): Don't reset
5871         innermost_block.
5872         * parser-defs.h (enum innermost_block_tracker_type): Move to
5873         expression.h.
5874         (innermost_block): Update comment.
5875         * parse.c (parse_exp_1): Add tracker_types parameter.
5876         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
5877         tracker_types parameter.  Reset innermost_block.
5878         (parse_exp_in_context): Remove.
5879         (parse_expression_for_completion): Update.
5880         * objfiles.c (~objfile): Don't reset expression_context_block or
5881         innermost_block.
5882         * expression.h (enum innermost_block_tracker_type): Move from
5883         parser-defs.h.
5884         (parse_exp_1): Add tracker_types parameter.
5885         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
5886         reset innermost_block.
5887
5888 2019-03-23  Tom Tromey  <tom@tromey.com>
5889
5890         * objfiles.h: Include bcache.h.
5891
5892 2019-03-23  Tom Tromey  <tom@tromey.com>
5893
5894         * linespec.c (get_current_search_block): Use
5895         scoped_restore_current_language.
5896         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
5897
5898 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5899             Jiong Wang  <jiong.wang@arm.com>
5900
5901         * aarch64-linux-tdep.c
5902         (aarch64_linux_iterate_over_regset_sections): Check for pauth
5903         section.
5904         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
5905
5906 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5907             Jiong Wang  <jiong.wang@arm.com>
5908
5909         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
5910         instructions.
5911         (aarch64_analyze_prologue_test): Add PACIASP test.
5912         (aarch64_prologue_prev_register): Unmask PC value.
5913
5914 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5915             Jiong Wang  <jiong.wang@arm.com>
5916
5917         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
5918         (aarch64_dwarf2_prev_register): Unmask PC value.
5919         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
5920         (aarch64_execute_dwarf_cfa_vendor_op): Check for
5921         DW_CFA_AARCH64_negate_ra_state.
5922         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
5923
5924 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5925             Jiong Wang  <jiong.wang@arm.com>
5926
5927         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
5928         registers.
5929         (aarch64_pseudo_register_name): Likewise.
5930         (aarch64_pseudo_register_type): Likewise.
5931         (aarch64_pseudo_register_reggroup_p): Likewise.
5932         (aarch64_gdbarch_init): Add pauth registers.
5933         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
5934         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
5935         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
5936         (struct gdbarch_tdep): Add regnum for ra_state.
5937
5938 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5939             Jiong Wang  <jiong.wang@arm.com>
5940
5941         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
5942
5943 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5944             Jiong Wang  <jiong.wang@arm.com>
5945
5946         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
5947         function.
5948         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
5949         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
5950         (aarch64_gdbarch_init): Add puth registers.
5951         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
5952         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
5953         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
5954
5955 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5956             Jiong Wang  <jiong.wang@arm.com>
5957
5958         * aarch64-linux-nat.c
5959         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
5960         * aarch64-linux-tdep.c
5961         (aarch64_linux_core_read_description): Likewise.
5962         (aarch64_linux_get_hwcap): New function.
5963         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
5964         (aarch64_linux_get_hwcap): New declaration.
5965
5966 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5967             Jiong Wang  <jiong.wang@arm.com>
5968
5969         * aarch64-linux-nat.c
5970         (aarch64_linux_nat_target::read_description): Add pauth param.
5971         * aarch64-linux-tdep.c
5972         (aarch64_linux_core_read_description): Likewise.
5973         * aarch64-tdep.c (struct target_desc): Add in pauth.
5974         (aarch64_read_description): Add pauth param.
5975         (aarch64_gdbarch_init): Likewise.
5976         * aarch64-tdep.h (aarch64_read_description): Likewise.
5977         * arch/aarch64.c (aarch64_create_target_description): Likewise.
5978         * arch/aarch64.h (aarch64_create_target_description): Likewise.
5979         * features/Makefile: Add new files.
5980         * features/aarch64-pauth.c: New file.
5981         * features/aarch64-pauth.xml: New file.
5982
5983 2019-03-20  Tom Tromey  <tromey@adacore.com>
5984
5985         * infrun.c (handle_inferior_event): Rename from
5986         handle_inferior_event_1.  Create a scoped_value_mark.
5987         (handle_inferior_event): Remove.
5988
5989 2019-03-19  Tom Tromey  <tromey@adacore.com>
5990
5991         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
5992         * infrun.h (print_stop_event): Add "displays" parameter.
5993         * infrun.c (print_stop_event): Add "displays" parameter.
5994
5995 2019-03-19  Pedro Alves  <palves@redhat.com>
5996
5997         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
5998         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
5999         to -1.  Fix TABs vs spaces.
6000         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6001         * tui/tui-out.h (tui_ui_out) Add intro comments.
6002         <m_line, m_start_of_line>: In-class initialize, and add describing
6003         comment.
6004
6005 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6006
6007         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6008         variable names.
6009         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6010
6011 2019-03-18  Pedro Alves  <palves@redhat.com>
6012             Eli Zaretskii <eliz@gnu.org>
6013
6014         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6015         m_line and m_start_of_line.
6016
6017 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6018
6019         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6020         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6021         it returns a newline.  This fixes a regression in TU mode, whereby
6022         the next line is output on the same screen line as the user input.
6023
6024 2019-03-18  Tom Tromey  <tromey@adacore.com>
6025
6026         * minsyms.c (minimal_symbol_reader::install): Remove call to
6027         obstack_blank.
6028
6029 2019-03-18  Pedro Alves  <palves@redhat.com>
6030
6031         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6032         New globals.
6033         (apply_style): New, factored out from ...
6034         (apply_ansi_escape): ... this.  Handle reverse video mode.
6035         (tui_set_reverse_mode): New function.
6036         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6037         * tui/tui-winsource.c (tui_show_source_line): Use
6038         tui_set_reverse_mode instead of setting A_STANDOUT.
6039         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6040         New setter methods.
6041
6042 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6043
6044         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6045         Handle tabs.
6046
6047 2019-03-18  Tom Tromey  <tromey@adacore.com>
6048
6049         * ada-lang.c (empty_array): Add "high" parameter.
6050         (ada_evaluate_subexp): Update.
6051
6052 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6053
6054         * unittests/string_view-selftests.c: Define
6055         _initialize_string_view_selftests unconditionally.
6056
6057 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6058
6059         PR gdb/24350
6060         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6061
6062 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6063
6064         PR gdb/24351
6065         * windows-nat.c (display_selector): Fix format specifiers.
6066
6067 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6068
6069         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6070         tui_refill_source_window instead of tui_refresh_win, to update the
6071         current execution line.  This fixes redisplay of the current line
6072         when stepping through the code with "next" or "step".
6073
6074 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6075
6076         * source-cache.c (source_cache::get_source_lines): Call
6077         find_source_lines to initialize s->nlines.  This fixes vertical
6078         scrolling of TUI source window when the DOWN arrow is pressed.
6079
6080 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6081
6082         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6083         linux-thread-db.c (_initialize_thread_db): Likewise.
6084
6085 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6086
6087         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6088         wclrtoeol in tui_show_source_line".  This reverts changes made in
6089         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6090
6091 2019-03-15  Tom Tromey  <tom@tromey.com>
6092
6093         * symtab.h (struct minimal_symbol): Derive from
6094         general_symbol_info.
6095         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6096         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6097         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6098         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6099         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6100         (MSYMBOL_SEARCH_NAME): Update.
6101         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6102         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6103         * minsyms.c (minimal_symbol_reader::record_full): Update.
6104
6105 2019-03-15  Tom Tromey  <tom@tromey.com>
6106
6107         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6108
6109 2019-03-15  Tom Tromey  <tom@tromey.com>
6110
6111         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6112         unique_xmalloc_ptr.
6113         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6114         Update.
6115         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6116         (build_minimal_symbol_hash_tables)
6117         (minimal_symbol_reader::install): Update.
6118
6119 2019-03-15  Tom Tromey  <tom@tromey.com>
6120
6121         * symtab.c (create_demangled_names_hash): Update.
6122         (symbol_set_names): Update.
6123         * objfiles.h (struct objfile_per_bfd_storage)
6124         <demangled_names_hash>: Now an htab_up.
6125         * objfiles.c (objfile_per_bfd_storage): Simplify.
6126
6127 2019-03-15  Tom Tromey  <tom@tromey.com>
6128
6129         * objfiles.h (struct objfile_per_bfd_storage): Declare
6130         destructor.
6131         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6132         New.
6133         (get_objfile_bfd_data): Use new.  Don't initialize
6134         language_of_main.
6135         (free_objfile_per_bfd_storage): Remove.
6136         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6137
6138 2019-03-15  Tom Tromey  <tom@tromey.com>
6139
6140         * symfile.c (reread_symbols): Update.
6141         * objfiles.c (objfile::objfile): Update.
6142         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6143         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6144         comment.
6145         (minimal_symbol_reader::install): Update.
6146         (terminate_minimal_symbol_table): Remove.
6147         * jit.c (jit_object_close_impl): Update.
6148
6149 2019-03-15  Tom Tromey  <tom@tromey.com>
6150
6151         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6152         initializations.
6153
6154 2019-03-15  Tom Tromey  <tom@tromey.com>
6155
6156         * objfiles.h (struct objfile_per_bfd_storage)
6157         <demangled_hash_languages>: Now a bitset.
6158         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6159         (lookup_minimal_symbol): Update.
6160
6161 2019-03-15  Tom Tromey  <tom@tromey.com>
6162
6163         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6164         Don't return the symbol.
6165         * coffread.c (record_minimal_symbol): Use record_full.
6166
6167 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6168
6169         The MS-Windows port of ncurses fails to switch to a color pair if
6170         one or both of the colors are the implicit default colors.  This
6171         change records the default colors when TUI is initialized, and
6172         then specifies them explicitly when a color pair uses the default
6173         colors.  This allows color styling in TUI mode on MS-Windows.
6174
6175         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6176         ncurses_norm_attr.
6177         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6178         colors in ncurses_norm_attr.
6179         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6180         "none", replace it with the default color recorded in
6181         ncurses_norm_attr.
6182
6183 2019-03-14  Tom Tromey  <tromey@adacore.com>
6184
6185         * source-cache.h (class source_cache) <get_source_lines>: Return
6186         std::string.
6187         * source-cache.c (source_cache::extract_lines): Handle case where
6188         first_pos==npos.  Return std::string.
6189         (source_cache::get_source_lines): Update.
6190
6191 2019-03-14  Tom Tromey  <tromey@adacore.com>
6192
6193         * NEWS: Add item for "style sources" commands.
6194         * source-cache.c (source_cache::get_source_lines): Check
6195         source_styling.
6196         * cli/cli-style.c (source_styling): New global.
6197         (_initialize_cli_style): Add "style sources" commands.
6198         (show_style_sources): New function.
6199         * cli/cli-style.h (source_styling): Declare.
6200
6201 2019-03-14  Pedro Alves  <palves@redhat.com>
6202             Tom Tromey  <tromey@adacore.com>
6203
6204         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6205         * tui/tui-winsource.c (tui_refill_source_window): New function,
6206         from...
6207         (tui_horizontal_source_scroll): ... here.  Move some logic.
6208         * cli/cli-style.c (set_style_enabled): Notify new observable.
6209         * tui/tui-hooks.c (tui_redisplay_source): New function.
6210         (tui_attach_detach_observers): Attach or detach
6211         tui_redisplay_source.
6212         * observable.h (source_styling_changed): New observable.
6213         * observable.c: Define source_styling_changed observable.
6214
6215 2019-03-13  Tom Tromey  <tromey@adacore.com>
6216
6217         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6218         (i386_gnu_nat_target::store_registers): Update.
6219         * target-debug.h (target_debug_print_std_string): New macro.
6220         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6221         * windows-tdep.c (display_one_tib): Update.
6222         * tui/tui-stack.c (tui_make_status_line): Update.
6223         * top.c (print_inferior_quit_action): Update.
6224         * thread.c (thr_try_catch_cmd): Update.
6225         (add_thread_with_info): Update.
6226         (thread_target_id_str): Update.
6227         (thr_try_catch_cmd): Update.
6228         (thread_command): Update.
6229         (thread_find_command): Update.
6230         * record-btrace.c (record_btrace_target::info_record)
6231         (record_btrace_resume_thread, record_btrace_target::resume)
6232         (record_btrace_cancel_resume, record_btrace_step_thread)
6233         (record_btrace_target::wait, record_btrace_target::wait)
6234         (record_btrace_target::wait, record_btrace_target::stop): Update.
6235         * progspace.c (print_program_space): Update.
6236         * process-stratum-target.c
6237         (process_stratum_target::thread_address_space): Update.
6238         * linux-fork.c (linux_fork_mourn_inferior)
6239         (detach_checkpoint_command, info_checkpoints_command)
6240         (linux_fork_context): Update.
6241         (linux_fork_detach): Update.
6242         (class scoped_switch_fork_info): Update.
6243         (delete_checkpoint_command): Update.
6244         * infrun.c (follow_fork_inferior): Update.
6245         (follow_fork_inferior): Update.
6246         (proceed_after_vfork_done): Update.
6247         (handle_vfork_child_exec_or_exit): Update.
6248         (follow_exec): Update.
6249         (displaced_step_prepare_throw): Update.
6250         (displaced_step_restore): Update.
6251         (start_step_over): Update.
6252         (resume_1): Update.
6253         (clear_proceed_status_thread): Update.
6254         (proceed): Update.
6255         (print_target_wait_results): Update.
6256         (do_target_wait): Update.
6257         (context_switch): Update.
6258         (stop_all_threads): Update.
6259         (restart_threads): Update.
6260         (finish_step_over): Update.
6261         (handle_signal_stop): Update.
6262         (switch_back_to_stepped_thread): Update.
6263         (keep_going_pass_signal): Update.
6264         (print_exited_reason): Update.
6265         (normal_stop): Update.
6266         * inferior.c (inferior_pid_to_str): Change return type.
6267         (print_selected_inferior): Update.
6268         (add_inferior): Update.
6269         (detach_inferior): Update.
6270         * dummy-frame.c (fprint_dummy_frames): Update.
6271         * dcache.c (dcache_info_1): Update.
6272         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6273         (btrace_fetch, btrace_clear): Update.
6274         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6275         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6276         type.
6277         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6278         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6279         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6280         * gdbarch.c, gdbarch.h: Rebuild.
6281         * gdbarch.sh (core_pid_to_str): Change return type.
6282         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6283         return type.
6284         (windows_nat_target::pid_to_str): Change return type.
6285         (windows_delete_thread): Update.
6286         (windows_nat_target::attach): Update.
6287         (windows_nat_target::files_info): Update.
6288         * target-delegates.c: Rebuild.
6289         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6290         return type.
6291         (sol_thread_target::pid_to_str): Change return type.
6292         * remote.c (class remote_target) <pid_to_str>: Change return
6293         type.
6294         (remote_target::pid_to_str): Change return type.
6295         (extended_remote_target::attach, remote_target::remote_stop_ns)
6296         (remote_target::remote_notif_remove_queued_reply)
6297         (remote_target::push_stop_reply, remote_target::disable_btrace):
6298         Update.
6299         (extended_remote_target::attach): Update.
6300         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6301         type.
6302         (gdbsim_target::pid_to_str): Change return type.
6303         * ravenscar-thread.c (struct ravenscar_thread_target)
6304         <pid_to_str>: Change return type.
6305         (ravenscar_thread_target::pid_to_str): Change return type.
6306         * procfs.c (class procfs_target) <pid_to_str>: Change return
6307         type.
6308         (procfs_target::pid_to_str): Change return type.
6309         (procfs_target::attach): Update.
6310         (procfs_target::detach): Update.
6311         (procfs_target::fetch_registers): Update.
6312         (procfs_target::store_registers): Update.
6313         (procfs_target::wait): Update.
6314         (procfs_target::files_info): Update.
6315         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6316         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6317         return type.
6318         (nto_procfs_target::pid_to_str): Change return type.
6319         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6320         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6321         return type.
6322         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6323         (exit_lwp): Update.
6324         (attach_proc_task_lwp_callback, get_detach_signal)
6325         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6326         (linux_nat_target::resume, wait_lwp, stop_callback)
6327         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6328         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6329         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6330         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6331         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6332         type.
6333         (inf_ptrace_target::attach): Update.
6334         (inf_ptrace_target::files_info): Update.
6335         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6336         type.
6337         (go32_nat_target::pid_to_str): Change return type.
6338         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6339         (gnu_nat_target::wait): Update.
6340         (gnu_nat_target::wait): Update.
6341         (gnu_nat_target::resume): Update.
6342         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6343         (fbsd_nat_target::wait): Update.
6344         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6345         type.
6346         (darwin_nat_target::attach): Update.
6347         * corelow.c (class core_target) <pid_to_str>: Change return type.
6348         (core_target::pid_to_str): Change return type.
6349         * target.c (normal_pid_to_str): Change return type.
6350         (default_pid_to_str): Likewise.
6351         (target_pid_to_str): Change return type.
6352         (target_translate_tls_address): Update.
6353         (target_announce_detach): Update.
6354         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6355         return type.
6356         (bsd_uthread_target::pid_to_str): Change return type.
6357         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6358         type.
6359         (bsd_kvm_target::pid_to_str): Change return type.
6360         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6361         return type.
6362         (aix_thread_target::pid_to_str): Change return type.
6363         * target.h (struct target_ops) <pid_to_str>: Change return type.
6364         (target_pid_to_str, normal_pid_to_str): Likewise.
6365         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6366         type.
6367         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6368         type.
6369         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6370         return type.
6371         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6372         type.
6373         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6374         type.
6375         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6376         return type.
6377
6378 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6379
6380         * NEWS: Mention that the new default MI version is 3.  Mention
6381         changes to the output of commands and events that deal with
6382         multi-location breakpoints.
6383         * breakpoint.c: Include "mi/mi-out.h".
6384         (print_one_breakpoint): Change output syntax if using MI version
6385         >= 3.
6386         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6387         New.
6388         (mi_multi_location_breakpoint_output_fixed): New.
6389         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6390         (mi_cmd_fix_multi_location_breakpoint_output): New.
6391         (mi_multi_location_breakpoint_output_fixed): New.
6392         * mi/mi-cmds.c (mi_cmds): Register command
6393         -fix-multi-location-breakpoint-output.
6394         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6395         interpreter "mi".
6396
6397 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6398
6399         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6400         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6401         instantiate mi_ui_out based on interpreter name.
6402         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6403         * mi/mi-main.c (mi_load_progress): Likewise.
6404
6405 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6406
6407         * NEWS: Combine separate "New targets" sections for 8.3.
6408
6409 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6410
6411         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6412         (ppcfbsd_init_abi): Install gdbarch
6413         "fetch_tls_load_module_address" and "get_thread_local_address"
6414         methods.
6415
6416 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6417
6418         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6419         (riscv_fbsd_init_abi): Install gdbarch
6420         "fetch_tls_load_module_address" and "get_thread_local_address"
6421         methods.
6422
6423 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6424
6425         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6426         (i386fbsd_init_abi): Install gdbarch
6427         "fetch_tls_load_module_address" and "get_thread_local_address"
6428         methods.
6429
6430 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6431
6432         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6433         (amd64fbsd_init_abi): Install gdbarch
6434         "fetch_tls_load_module_address" and "get_thread_local_address"
6435         methods.
6436
6437 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6438
6439         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6440         (struct fbsd_pspace_data): New type.
6441         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6442         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6443         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6444         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6445         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6446
6447 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6448
6449         * gdbtypes.c (lookup_struct_elt): New function.
6450         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6451         * gdbtypes.h (struct struct_elt): New type.
6452         (lookup_struct_elt): New prototype.
6453
6454 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6455
6456         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6457         remove disabled code block.
6458
6459 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6460
6461         * gdbarch.sh (get_thread_local_address): New method.
6462         * gdbarch.h, gdbarch.c: Regenerate.
6463         * target.c (target_translate_tls_address): Use
6464         gdbarch_get_thread_local_address if present instead of
6465         target::get_thread_local_address.
6466
6467 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6468
6469         * target.h (target::get_thread_local_address): Update comment.
6470
6471 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6472
6473         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6474         objfile->separate_debug_objfile_backlink if not NULL.
6475
6476 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6477
6478         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6479         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6480         (amd64bsd_store_inferior_registers): Likewise.
6481         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6482         Enable segment base registers.
6483         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6484         PT_GETFSBASE and PT_GETGSBASE.
6485         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6486         PT_SETGSBASE.
6487         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6488         segment base registers.
6489         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6490
6491 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6492
6493         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6494         Update calls to i386_target_description to add 'segments'
6495         parameter.
6496         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6497         add segment base registers.
6498         * arch/i386.c (i386_create_target_description): Add 'segments'
6499         parameter to enable segment base registers.
6500         * arch/i386.h (i386_create_target_description): Likewise.
6501         * features/i386/32bit-segments.xml: New file.
6502         * features/i386/32bit-segments.c: Generate.
6503         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6504         call to i386_target_description to add 'segments' parameter.
6505         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6506         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6507         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6508         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6509         if feature is present.
6510         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6511         Add 'segments' parameter to call to i386_target_description.
6512         (i386_target_description): Add 'segments' parameter to enable
6513         segment base registers.
6514         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6515         to call to i386_target_description.
6516         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6517         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6518         Define I386_NUM_REGS.
6519         (i386_target_description): Add 'segments' parameter to enable
6520         segment base registers.
6521
6522 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6523
6524         PR/24325
6525         * source-cache.c: #undef open and close, to avoid unresolved
6526         externals during linking.
6527
6528 2019-03-12  Tom Tromey  <tromey@adacore.com>
6529
6530         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6531         const.  Add initializers.
6532         (_initialize_remote): Don't initialize ptid globals.
6533
6534 2019-03-12  Pedro Alves  <palves@redhat.com>
6535
6536         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6537
6538 2019-03-12  Pedro Alves  <palves@redhat.com>
6539
6540         * cp-name-parser.y (main): Remove unused 'len' variable.
6541
6542 2019-03-12  Tom Tromey  <tromey@adacore.com>
6543
6544         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6545         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6546
6547 2019-03-12  Tom Tromey  <tromey@adacore.com>
6548
6549         * linux-nat.c (iterate_over_lwps): Update.
6550         (stop_callback): Remove parameter.
6551         (stop_wait_callback, detach_callback, resume_set_callback)
6552         (select_singlestep_lwp_callback, set_ignore_sigint)
6553         (status_callback, resumed_callback, resume_clear_callback)
6554         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6555         data parameter.
6556         (linux_nat_target::detach, linux_nat_target::resume)
6557         (linux_stop_and_wait_all_lwps, select_event_lwp)
6558         (linux_nat_filter_event, linux_nat_wait_1)
6559         (linux_nat_target::kill, linux_nat_target::stop)
6560         (linux_nat_target::stop): Update.
6561         (linux_nat_resume_callback): Change type.
6562         (resume_stopped_resumed_lwps, count_events_callback)
6563         (select_event_lwp_callback): Likewise.
6564         (linux_stop_lwp, linux_nat_stop_lwp): Update.
6565         * arm-linux-nat.c (struct update_registers_data): Remove.
6566         (update_registers_callback): Change type.
6567         (arm_linux_insert_hw_breakpoint1): Update.
6568         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
6569         parameter.
6570         (x86_linux_dr_set_addr): Update.
6571         (x86_linux_dr_set_control): Update.
6572         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
6573         (iterate_over_lwps): Use gdb::function_view.
6574         * nat/aarch64-linux-hw-point.c (struct
6575         aarch64_dr_update_callback_param): Remove.
6576         (debug_reg_change_callback): Change type.
6577         (aarch64_notify_debug_reg_change): Update.
6578         * s390-linux-nat.c (s390_refresh_per_info): Update.
6579
6580 2019-03-11  Tom Tromey  <tromey@adacore.com>
6581
6582         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
6583         redundant assignment to "this_cu".
6584
6585 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6586
6587         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
6588
6589 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6590
6591         * gdbtypes.c (rank_one_type_parm_set): New function extracted
6592         from...
6593         (rank_one_type): ... this.
6594
6595 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6596
6597         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
6598         from...
6599         (rank_one_type): ... this.
6600
6601 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6602
6603         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
6604         from...
6605         (rank_one_type): ... this.
6606
6607 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6608
6609         * gdbtypes.c (rank_one_type_parm_float): New function extracted
6610         from...
6611         (rank_one_type): ... this.
6612
6613 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6614
6615         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
6616         from...
6617         (rank_one_type): ... this.
6618
6619 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6620
6621         * gdbtypes.c (rank_one_type_parm_range): New function extracted
6622         from...
6623         (rank_one_type): ... this.
6624
6625 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6626
6627         * gdbtypes.c (rank_one_type_parm_char): New function extracted
6628         from...
6629         (rank_one_type): ... this.
6630
6631 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6632
6633         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
6634         from...
6635         (rank_one_type): ... this.
6636
6637 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6638
6639         * gdbtypes.c (rank_one_type_parm_int): New function extracted
6640         from...
6641         (rank_one_type): ... this.
6642
6643 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6644
6645         * gdbtypes.c (rank_one_type_parm_func): New function extracted
6646         from...
6647         (rank_one_type): ... this.
6648
6649 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6650
6651         * gdbtypes.c (rank_one_type_parm_array): New function extracted
6652         from...
6653         (rank_one_type): ... this.
6654
6655 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6656
6657         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
6658         from...
6659         (rank_one_type): ... this.
6660
6661 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6662
6663         * inferior.c (initialize_inferiors): Ensure 'help set/show print
6664         inferior-events' shows the example events.
6665
6666 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
6667
6668         Support styling on native MS-Windows console
6669
6670         PR/24315
6671         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
6672         on MS-Windows if $TERM is not defined.
6673
6674         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
6675
6676         * posix-hdep.c (gdb_console_fputs):
6677         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
6678         functions.
6679         * ui-file.h (gdb_console_fputs): Add prototype.
6680
6681         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
6682         back to fputs only if the former returns zero.
6683
6684 2019-03-07  Tom Tromey  <tom@tromey.com>
6685
6686         * symmisc.c (print_symbol_bcache_statistics): Update.
6687         (print_objfile_statistics): Update.
6688         * symfile.c (allocate_symtab): Update.
6689         * stabsread.c: Don't include bcache.h.
6690         * psymtab.h (struct psymbol_bcache): Don't declare.
6691         (class psymtab_storage) <psymbol_cache>: Now a bcache.
6692         (psymbol_bcache_init, psymbol_bcache_free)
6693         (psymbol_bcache_get_bcache): Don't declare.
6694         * psymtab.c (struct psymbol_bcache): Remove.
6695         (psymtab_storage::psymtab_storage): Update.
6696         (psymtab_storage::~psymtab_storage): Update.
6697         (psymbol_bcache_init, psymbol_bcache_free)
6698         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
6699         (add_psymbol_to_bcache): Update.
6700         (allocate_psymtab): Update.
6701         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6702         macro_cache>: No longer pointers.
6703         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
6704         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
6705         * macrotab.c (macro_bcache): Update.
6706         * macroexp.c: Don't include bcache.h.
6707         * gdbtypes.c (check_types_worklist): Update.
6708         (types_deeply_equal): Remove TRY/CATCH.  Update.
6709         * elfread.c (elf_symtab_read): Update.
6710         * dwarf2read.c: Don't include bcache.h.
6711         * buildsym.c (buildsym_compunit::get_macro_table): Update.
6712         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
6713         (print_bcache_statistics, bcache_memory_used): Don't declare.
6714         (struct bcache): Move from bcache.c.  Add constructor, destructor,
6715         methods.  Rename all data members.
6716         * bcache.c (struct bcache): Move to bcache.h.
6717         (bcache::expand_hash_table): Rename from expand_hash_table.
6718         (bcache): Remove.
6719         (bcache::insert): Rename from bcache_full.
6720         (bcache::compare): Rename from bcache_compare.
6721         (bcache_xmalloc): Remove.
6722         (bcache::~bcache): Rename from bcache_xfree.
6723         (bcache::print_statistics): Rename from print_bcache_statistics.
6724         (bcache::memory_used): Rename from bcache_memory_used.
6725
6726 2019-03-07  Pedro Alves  <palves@redhat.com>
6727
6728         * infrun.c (normal_stop): Also check for
6729         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
6730
6731 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
6732
6733         * f-lang.c (value_from_host_double): Moved to...
6734         * value.c (value_from_host_double): ...here.
6735         * value.h (value_from_host_double): Declare.
6736         * guile/scm-math.c (vlscm_convert_typed_number): Use
6737         value_from_host_double.
6738         (vlscm_convert_number): Likewise.
6739         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
6740         * python/py-value.c (convert_value_from_python): Likewise.
6741
6742 2019-03-06  Tom Tromey  <tom@tromey.com>
6743
6744         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
6745
6746 2019-03-06  Tom Tromey  <tom@tromey.com>
6747
6748         * utils.h (free_current_contents): Don't declare.
6749         * utils.c (free_current_contents): Remove.
6750
6751 2019-03-06  Tom Tromey  <tom@tromey.com>
6752
6753         * top.c (quit_force): Update.
6754         * main.c (captured_command_loop): Update.
6755         * common/new-op.c (operator new): Update.
6756         * common/common-exceptions.c (struct catcher)
6757         <save_cleanup_chain>: Remove member.
6758         (exceptions_state_mc_init): Update.
6759         (exception_try_scope_entry): Return nullptr.
6760         (exception_try_scope_exit, exception_rethrow)
6761         (throw_exception_sjlj, throw_exception_cxx): Update.
6762         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
6763         (all_cleanups, do_cleanups, discard_cleanups)
6764         (discard_final_cleanups, save_cleanups, save_final_cleanups)
6765         (restore_cleanups, restore_final_cleanups): Don't declare.
6766         (do_final_cleanups): Remove parameter.
6767         * common/cleanups.c (cleanup_chain, make_cleanup)
6768         (make_cleanup_dtor, all_cleanups, do_cleanups)
6769         (discard_my_cleanups, discard_cleanups)
6770         (discard_final_cleanups, save_my_cleanups, save_cleanups)
6771         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
6772         (null_cleanup): Remove.
6773         (do_final_cleanups): Remove parameter.
6774
6775 2019-03-06  Tom Tromey  <tom@tromey.com>
6776
6777         * remote.c (remote_target::remote_parse_stop_reply): Use
6778         unique_xmalloc_ptr.
6779
6780 2019-03-06  Tom Tromey  <tom@tromey.com>
6781
6782         * stabsread.c (struct stabs_field_info): Rename from field_info.
6783         <list, fnlist>: Add initializers.
6784         <obstack>: New member.
6785         (read_member_functions, read_struct_fields, read_baseclasses):
6786         Allocate on obstack.  Don't use cleanups.
6787         (read_one_struct_field, read_member_functions, read_struct_fields)
6788         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
6789         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
6790         (read_struct_type): Update.
6791
6792 2019-03-06  Tom Tromey  <tom@tromey.com>
6793
6794         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
6795         * common/filestuff.h (make_cleanup_close): Don't declare.
6796         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
6797         Remove.
6798
6799 2019-03-06  Tom Tromey  <tom@tromey.com>
6800
6801         * solib-aix.c: Use make_scope_exit.
6802
6803 2019-03-06  Tom Tromey  <tom@tromey.com>
6804
6805         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
6806         Use make_scope_exit.
6807
6808 2019-03-06  Tom Tromey  <tom@tromey.com>
6809
6810         * solib-svr4.c (disable_probes_interface): Remove parameter.
6811         (svr4_handle_solib_event): Use make_scope_exit.
6812
6813 2019-03-06  Tom Tromey  <tom@tromey.com>
6814
6815         * remote.c (struct stop_reply_deleter): Remove.
6816         (stop_reply_up): Update.
6817         (struct stop_reply): Derive from notif_event.  Don't typedef.
6818         <regcache>: Now a std::vector.
6819         (stop_reply_xfree): Remove.
6820         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
6821         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
6822         (remote_target::discard_pending_stop_replies): Use delete.
6823         (remote_target::remote_parse_stop_reply): Update.
6824         (remote_target::process_stop_reply): Update.
6825         * remote-notif.h (struct notif_event): Add virtual destructor.
6826         Remove "dtr" member.
6827         (struct notif_client) <alloc_event>: Return a unique_ptr.
6828         (notif_event_xfree): Don't declare.
6829         (notif_event_up): New typedef.
6830         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
6831         (notif_event_xfree, do_notif_event_xfree): Remove.
6832         (remote_notif_state_xfree): Update.
6833
6834 2019-03-06  Tom Tromey  <tom@tromey.com>
6835
6836         * infrun.c (displaced_step_clear_cleanup): Now a
6837         forward_scope_exit type.
6838         (displaced_step_prepare_throw): Update.
6839         (displaced_step_fixup): Update.
6840
6841 2019-03-06  Tom Tromey  <tom@tromey.com>
6842
6843         * inferior.h (class inferior): Update comment.
6844         * gdbthread.h (class thread_info): Update comment.
6845
6846 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
6847             Tom Tromey  <tom@tromey.com>
6848
6849         * stabsread.h (struct stab_section_list): Remove.
6850         (coffstab_build_psymtabs): Update.
6851         * dbxread.c (symbuf_sections): Now a std::vector.
6852         (sect_idx): New global.
6853         (fill_symbuf): Update.
6854         (coffstab_build_psymtabs): Change type of stabsects parameter.
6855         Update.
6856         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
6857         std::vector.
6858         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
6859         (coff_locate_sections): Update.
6860         (coff_symfile_read): Remove cleanups.  Update.
6861         (init_stringtab): Add storage parameter.
6862         (free_stringtab, free_stringtab_cleanup): Remove.
6863         (init_lineno): Add storage parameter.
6864         (free_linetab, free_linetab_cleanup): Remove.
6865
6866 2019-03-06  Pedro Alves  <palves@redhat.com>
6867
6868         * linux-fork.c (fork_info::clobber_regs): Delete.
6869         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
6870         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
6871         comment.  Adjust.
6872         (scoped_switch_fork_info::scoped_switch_fork_info)
6873         (checkpoint_command, linux_fork_context): Adjust
6874         fork_save_infrun_state calls.
6875
6876 2019-03-06  Pedro Alves  <palves@redhat.com>
6877
6878         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
6879         (inf_has_multiple_threads): Return 'bool' and rewrite using
6880         inferior_info::threads().
6881
6882 2019-03-06  Pedro Alves  <palves@redhat.com>
6883
6884         * linux-fork.c: Include <list>.
6885         (fork_list): Now a std::list instance.
6886         (fork_info): Add ctor, dtor, and in-class initialize all fields.
6887         (forks_exist_p, find_last_fork): Adjust.
6888         (new_fork): Delete.
6889         (one_fork_p): New.
6890         (add_fork): Adjust.
6891         (free_fork): Delete, folded into fork_info::~fork_info().
6892         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
6893         Adjust.
6894         (init_fork_list): Delete.
6895         (linux_fork_killall, linux_fork_mourn_inferior)
6896         (linux_fork_detach, info_checkpoints_command): Adjust.
6897         (_initialize_linux_fork): No longer call init_fork_list.
6898
6899 2019-03-06  Pedro Alves  <palves@redhat.com>
6900
6901         * linux-fork.c (new_fork): New, split out of ...
6902         (add_fork): ... this.  Return void.  Move "first fork" special
6903         case from here, to ...
6904         (checkpoint_command): ... here.
6905         * linux-linux.h (add_fork): Return void.
6906
6907 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6908
6909         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
6910
6911 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6912             Chris January  <chris.january@arm.com>
6913             David Lecomber  <david.lecomber@arm.com>
6914
6915         * f-exp.y: New token, UNOP_INTRINSIC.
6916         (exp): New pattern using UNOP_INTRINSIC token.
6917         (f77_keywords): Add 'abs' keyword.
6918         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
6919         (value_from_host_double): New function.
6920         (evaluate_subexp_f): Support UNOP_ABS.
6921
6922 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6923
6924         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
6925         types.
6926
6927 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6928
6929         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
6930         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
6931         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
6932
6933 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6934
6935         * f-exp.y (convert_to_kind_type): Handle more type kinds.
6936
6937 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6938             Chris January  <chris.january@arm.com>
6939
6940         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
6941         * f-exp.y: Define 'KIND' token.
6942         (exp): New pattern for KIND expressions.
6943         (ptype): Handle types with a kind extension.
6944         (direct_abs_decl): Extend to spot kind extensions.
6945         (f77_keywords): Add 'kind' to the list.
6946         (push_kind_type): New function.
6947         (convert_to_kind_type): New function.
6948         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
6949         * parse.c (operator_length_standard): Likewise.
6950         * parser-defs.h (enum type_pieces): Add tp_kind.
6951         * std-operator.def: Add UNOP_KIND.
6952
6953 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6954
6955         * f-exp.y (f_parse): Set yydebug.
6956
6957 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6958
6959         * f-lang.c (evaluate_subexp_f): New function.
6960         (exp_descriptor_f): New global.
6961         (f_language_defn): Use exp_descriptor_f instead of
6962         exp_descriptor_standard.
6963
6964 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6965
6966         * f-exp.y (struct token): Add comments.
6967         (dot_ops): Remove uppercase versions and the end marker.
6968         (f77_keywords): Likewise.
6969         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
6970         entries in the dot_ops array are case insensitive, and use
6971         strncasecmp to compare strings.  Also some whitespace cleanup in
6972         this area.  Similar for the f77_keywords array, except entries in
6973         this list might be case sensitive.
6974
6975 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6976
6977         * f-exp.y (struct f77_boolean_val): Add comments.
6978         (boolean_values): Remove uppercase versions, and end marker.
6979         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
6980         and use strncasecmp to achieve case insensitivity.  Additionally,
6981         perform whitespace cleanup around this code.
6982
6983 2019-03-06  Tom Tromey  <tromey@adacore.com>
6984
6985         * remote-sim.c (gdbsim_target_open): Use result of
6986         gdb_argv::release.
6987
6988 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
6989         Dirk Schubert  <dirk.schubert@arm.com>
6990         Chris January  <chris.january@arm.com>
6991
6992         * eval.c (evaluate_subexp_standard): Call Fortran argument
6993         wrapping logic.
6994         * f-lang.c (struct value): A value which can be passed into a
6995         Fortran function call.
6996         (fortran_argument_convert): Wrap Fortran arguments in a pointer
6997         where appropriate.
6998         (struct type): Value ready for a Fortran function call.
6999         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7000         is needed.
7001         * f-lang.h (fortran_argument_convert): Declaration.
7002         (fortran_preserve_arg_pointer): Declaration.
7003         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7004
7005 2019-03-05  Tom Tromey  <tromey@adacore.com>
7006
7007         * python/py-prettyprint.c (print_string_repr): Remove #if.
7008         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7009
7010 2019-03-05  Tom Tromey  <tromey@adacore.com>
7011
7012         * target.c (the_dummy_target): Move later.  Change type to
7013         "dummy_target".
7014         (initialize_targets): Don't initialize the_dummy_target.
7015
7016 2019-03-05  Tom Tromey  <tromey@adacore.com>
7017
7018         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7019         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7020
7021 2019-03-05  Tom Tromey  <tromey@adacore.com>
7022
7023         * windows-nat.c (windows_nat_target::attach)
7024         (windows_nat_target::detach): Don't call gdb_flush.
7025         * valprint.c (generic_val_print, val_print, val_print_string):
7026         Don't call gdb_flush.
7027         * utils.c (defaulted_query): Don't call gdb_flush.
7028         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7029         * target.c (target_announce_detach): Don't call gdb_flush.
7030         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7031         * remote.c (extended_remote_target::attach): Don't call
7032         gdb_flush.
7033         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7034         * printcmd.c (do_examine): Don't call gdb_flush.
7035         (info_display_command): Don't call gdb_flush.
7036         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7037         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7038         * memattr.c (info_mem_command): Don't call gdb_flush.
7039         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7040         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7041         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7042         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7043         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7044         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7045         (gnu_nat_target::detach): Don't call gdb_flush.
7046         * f-valprint.c (f_val_print): Don't call gdb_flush.
7047         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7048         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7049         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7050         gdb_flush.
7051         * c-valprint.c (c_val_print): Don't call gdb_flush.
7052         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7053
7054 2019-03-05  Tom Tromey  <tromey@adacore.com>
7055
7056         * varobj.c (update_dynamic_varobj_children): Update.
7057         (install_default_visualizer): Use reset, not release.
7058         * value.c (set_internalvar): Update.
7059         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7060         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7061         ATTRIBUTE_UNUSED_RESULT.
7062
7063 2019-03-05  Tom Tromey  <tromey@adacore.com>
7064
7065         * remote.c (class scoped_remote_fd) <release>: Add
7066         ATTRIBUTE_UNUSED_RESULT.
7067
7068 2019-03-05  Tom Tromey  <tromey@adacore.com>
7069
7070         * macroexp.c (struct macro_buffer) <release>: Add
7071         ATTRIBUTE_UNUSED_RESULT.
7072
7073 2019-03-05  Tom Tromey  <tromey@adacore.com>
7074
7075         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7076         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7077         ATTRIBUTE_UNUSED_RESULT.
7078
7079 2019-03-05  Tom Tromey  <tromey@adacore.com>
7080
7081         * common/scoped_fd.h (class scoped_fd) <release>: Add
7082         ATTRIBUTE_UNUSED_RESULT.
7083
7084 2019-03-05  Tom Tromey  <tromey@adacore.com>
7085
7086         * parser-defs.h (struct parser_state) <release>: Add
7087         ATTRIBUTE_UNUSED_RESULT.
7088
7089 2019-03-05  Tom Tromey  <tromey@adacore.com>
7090
7091         * utils.h (class gdb_argv) <release>: Add
7092         ATTRIBUTE_UNUSED_RESULT.
7093         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7094
7095 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7096
7097         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7098         for-loop range, to avoid compiler warnings.
7099
7100         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7101         avoid compiler warnings about unused variables.
7102
7103         * NEWS: Mention end of support for native debugging on MS-Windows
7104         before XP.
7105
7106         PR gdb/24292
7107         * common/netstuff.c:
7108         * gdbserver/gdbreplay.c
7109         * gdbserver/remote-utils.c:
7110         * ser-tcp.c:
7111         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7112         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7113         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7114         'getaddrinfo' and 'freeaddrinfo' were not available before
7115         Windows XP, and mingw.org's MinGW headers by default define
7116         _WIN32_WINNT to 0x500.
7117
7118 2019-03-01  Gary Benson <gbenson@redhat.com>
7119
7120         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7121
7122 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7123             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7124
7125         PR gdb/8527
7126         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7127         set_sigint_trap, clear_sigint_trap.
7128
7129 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7130
7131         * target.c (target_detach): Clear the regcache and the
7132         frame cache.
7133
7134 2019-02-27  Pedro Alves  <palves@redhat.com>
7135
7136         * utils.c (set_screen_size): When we cap the height/width sizes,
7137         tweak the corresponding command variable to show "unlimited":
7138
7139 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7140             Pedro Alves  <palves@redhat.com>
7141
7142         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7143         before calling rl_set_screen_size.
7144
7145 2019-02-27  Tom Tromey  <tromey@adacore.com>
7146
7147         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7148         define.
7149         * python/py-value.c: Remove Python 2.4 workaround.
7150         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7151         workaround.
7152         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7153         Python 2.4 workaround.
7154         * python/python-internal.h: Remove Python 2.4 comment.
7155         (Py_ssize_t): Don't define.
7156         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7157         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7158         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7159         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7160         * python/python.c (do_start_initialization): Remove Python 2.4
7161         workaround.
7162         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7163         (print_children): Remove Python 2.4 workaround.
7164         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7165         workaround.
7166         (CHARBUFFERPROC_NAME): Remove.
7167         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7168         Python 2.4 workaround.
7169
7170 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7171
7172         * NEWS: Note minimum Python version.
7173
7174 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7175
7176         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7177         code from these functions.  Remove corresponding ifdefs.  Use
7178         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7179         Remove gotos and target of gotos.
7180         (infpy_search_memory): Likewise.
7181
7182 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7183
7184         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7185         (hppa_gdbarch_init): Don't register deleted functions with
7186         gdbarch.
7187
7188 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7189
7190         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7191         (h8300_unwind_sp): Delete.
7192         (h8300_dummy_id): Delete.
7193         (h8300_gdbarch_init): Don't register deleted functions with
7194         gdbarch.
7195
7196 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7197
7198         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7199         (ft32_unwind_pc): Delete.
7200         (ft32_unwind_sp): Delete.
7201         (ft32_gdbarch_init): Don't register deleted functions with
7202         gdbarch.
7203
7204 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7205
7206         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7207         (frv_unwind_pc): Delete.
7208         (frv_unwind_sp): Delete.
7209         (frv_gdbarch_init): Don't register deleted functions with
7210         gdbarch.
7211
7212 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7213
7214         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7215         (riscv_unwind_pc): Delete.
7216         (riscv_unwind_sp): Delete.
7217         (riscv_gdbarch_init): Don't register deleted functions with
7218         gdbarch.
7219
7220 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7221
7222         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7223         (csky_unwind_pc): Delete.
7224         (csky_unwind_sp): Delete.
7225         (csky_gdbarch_init): Don't register deleted functions with
7226         gdbarch.
7227
7228 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7229
7230         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7231         (cris_unwind_pc): Delete.
7232         (cris_unwind_sp): Delete.
7233         (cris_gdbarch_init): Don't register deleted functions with
7234         gdbarch.
7235
7236 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7237
7238         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7239         (bfin_unwind_pc): Delete.
7240         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7241
7242 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7243
7244         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7245         (arm_unwind_pc): Delete.
7246         (arm_unwind_sp): Delete.
7247         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7248
7249 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7250
7251         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7252         (arc_unwind_pc): Delete.
7253         (arc_unwind_sp): Delete.
7254         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7255
7256 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7257
7258         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7259         (alpha_unwind_pc): Delete.
7260         (alpha_gdbarch_init): Don't register deleted functions with
7261         gdbarch.
7262
7263 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7264
7265         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7266         (aarch64_unwind_pc): Delete.
7267         (aarch64_unwind_sp): Delete.
7268         (aarch64_gdbarch_init): Don't register deleted functions with
7269         gdbarch.
7270
7271 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7272
7273         * gdbtypes.c (type_align): Don't consider static members when
7274         computing structure alignment.
7275
7276 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7277
7278         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7279         return 0 for other types.
7280         * arch-utils.c (default_type_align): Always return 0.
7281         * gdbarch.h: Regenerate.
7282         * gdbarch.sh (type_align): Extend comment.
7283         * gdbtypes.c (type_align): Add additional comments, always call
7284         gdbarch_type_align before applying the default rules.
7285         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7286         generic code will then apply a suitable default.
7287         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7288         types, return 0 for other types.
7289
7290 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7291
7292         * NEWS: Create a new section for the next release branch.
7293         Rename the section of the current branch, now that it has
7294         been cut.
7295
7296 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7297
7298         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7299         * version.in: Bump version to 8.3.50.DATE-git.
7300
7301 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7302
7303         * aix-thread.c (ptid_cmp): Remove unused variable.
7304         (get_signaled_thread): Likewise.
7305         (store_regs_user_thread): Likewise.
7306         (store_regs_kernel_thread): Likewise.
7307         (fetch_regs_kernel_thread): Remove shadowed variable.
7308
7309 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7310
7311         * features/riscv/32bit-cpu.xml: Add register numbers.
7312         * features/riscv/32bit-fpu.c: Regenerate.
7313         * features/riscv/32bit-fpu.xml: Add register numbers.
7314         * features/riscv/64bit-cpu.xml: Add register numbers.
7315         * features/riscv/64bit-fpu.c: Regenerate.
7316         * features/riscv/64bit-fpu.xml: Add register numbers.
7317
7318 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7319
7320         * NEWS: Mention two argument form of gdb.Value constructor.
7321         * python/py-value.c (convert_buffer_and_type_to_value): New
7322         function.
7323         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7324         Add support for handling an optional second argument.  Call
7325         convert_buffer_and_type_to_value as appropriate.
7326         * python/python-internal.h (Py_buffer_deleter): New struct.
7327         (Py_buffer_up): New typedef.
7328
7329 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7330
7331         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7332         instead of releasing ownership.
7333
7334 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7335
7336         * dwarf2read.c (open_and_init_dwp_file): Call
7337         elf_numsections instead of bfd_count_sections to initialize
7338         dwp_file->num_sections.
7339
7340 2019-02-25  Tom Tromey  <tromey@adacore.com>
7341
7342         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7343
7344 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7345
7346         * gcore.in: Add '--readnever' option when invoking GDB.
7347
7348 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7349
7350         * MAINTAINERS: Update my email address.
7351
7352 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7353
7354         * build-id.c (build_id_to_debug_bfd_1): New function.
7355         (build_id_to_debug_bfd): Look for separate debug file in
7356         sysroot.
7357
7358 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7359
7360         * gdbarch.sh: Update the copyright year range that is placed into
7361         generated files.
7362
7363 2019-02-22  Keith Seitz  <keiths@redhat.com>
7364
7365         PR symtab/23853
7366         * linespec.c (create_sals_line_offset): Search for the default
7367         symtab's filename instead of its fullname.
7368
7369 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7370
7371         * NEWS: Update style defaults.
7372
7373 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7374
7375         * main.c (captured_main_1): Disable styling in batch mode.
7376
7377 2019-02-20  Tom Tromey  <tom@tromey.com>
7378
7379         * symtab.c (symtab_symbol_info): Fix typos.
7380
7381 2019-02-20  Tom Tromey  <tromey@adacore.com>
7382
7383         * findcmd.c (_initialize_mem_search): Use upper case for
7384         metasyntactic variables.
7385
7386 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7387
7388         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7389         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7390
7391 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7392
7393         * top.h (source_file_name): Change to std::string.
7394         * top.c (source_file_name): Likewise.
7395         (command_line_input): Adjust.
7396         * cli/cli-script.c (script_from_file): Adjust.
7397
7398 2019-02-19  Tom Tromey  <tromey@adacore.com>
7399
7400         * ravenscar-thread.c
7401         (ravenscar_thread_target::update_thread_list): Don't call
7402         ada_build_task_list.
7403         * ada-lang.h (ada_build_task_list): Don't declare.
7404         * ada-tasks.c (struct ada_tasks_inferior_data)
7405         <task_list_valid_p>: Now bool.
7406         (read_known_tasks, ada_task_list_changed)
7407         (ada_tasks_invalidate_inferior_data): Update.
7408         (read_known_tasks_array): Return bool.
7409         (read_known_tasks_list): Likewise.
7410         (read_known_tasks): Return void.
7411         (ada_build_task_list): Now static.
7412
7413 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7414
7415         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7416         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7417
7418 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7419
7420         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7421         variant for ada_tasks_pspace_data_handle and
7422         ada_tasks_inferior_data_handle.
7423         (ada_tasks_pspace_data_cleanup): New function.
7424         (ada_tasks_inferior_data_cleanup): New function.
7425
7426 2019-02-17  Tom Tromey  <tom@tromey.com>
7427
7428         * macrotab.h (macro_source_fullname): Return a std::string.
7429         * macrotab.c (macro_include, check_for_redefinition)
7430         (macro_undef, macro_lookup_definition, foreach_macro)
7431         (foreach_macro_in_scope): Update.
7432         (macro_source_fullname): Return a std::string.
7433         * macrocmd.c (show_pp_source_pos): Update.
7434
7435 2019-02-17  Tom Tromey  <tom@tromey.com>
7436
7437         * macrocmd.c (show_pp_source_pos): Style the file names.
7438
7439 2019-02-17  Tom Tromey  <tom@tromey.com>
7440
7441         PR tui/24197:
7442         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7443
7444 2019-02-17  Tom Tromey  <tom@tromey.com>
7445
7446         * ada-lang.c (user_select_syms): Use filtered printing.
7447         * utils.c (wrap_style): New global.
7448         (desired_style): Remove.
7449         (emit_style_escape): Add stream parameter.
7450         (set_output_style, reset_terminal_style, prompt_for_continue):
7451         Update.
7452         (flush_wrap_buffer): Only flush gdb_stdout.
7453         (wrap_here): Set wrap_style.
7454         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7455         treat escape sequences as a character.  Change when wrap buffer is
7456         flushed.
7457         (fputs_styled): Do not set the output style when the default is
7458         requested.
7459         * ui-style.h (struct ui_file_style) <is_default>: New method.
7460         * source.c (print_source_lines_base): Emit escape sequences in one
7461         piece.
7462
7463 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7464
7465         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7466         integers and enumeration types.
7467
7468 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7469
7470         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7471         instead of lookup_symbol_in_language
7472         (do_exact_match): New function.
7473         (ada_get_symbol_name_matcher): Return do_exact_match when
7474         doing a verbatim match.
7475
7476 2019-02-15  Tom Tromey  <tromey@adacore.com>
7477
7478         * ravenscar-thread.c (ravenscar_thread_target::resume)
7479         (ravenscar_thread_target::wait): Special case wildcard requests.
7480
7481 2019-02-15  Tom Tromey  <tromey@adacore.com>
7482
7483         * ravenscar-thread.c (base_ptid): Remove.
7484         (struct ravenscar_thread_target) <close>: New method.
7485         <m_base_ptid>: New member.
7486         <update_inferior_ptid, active_task, task_is_currently_active,
7487         runtime_initialized>: Declare methods.
7488         <ravenscar_thread_target>: Add constructor.
7489         (ravenscar_thread_target::task_is_currently_active)
7490         (ravenscar_thread_target::update_inferior_ptid)
7491         (ravenscar_runtime_initialized): Rename.  Now methods.
7492         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7493         (ravenscar_thread_target::update_thread_list): Update.
7494         (ravenscar_thread_target::active_task): Now method.
7495         (ravenscar_thread_target::store_registers)
7496         (ravenscar_thread_target::prepare_to_store)
7497         (ravenscar_thread_target::prepare_to_store)
7498         (ravenscar_thread_target::mourn_inferior): Update.
7499         (ravenscar_inferior_created): Use "new" to create target.
7500         (ravenscar_thread_target::get_ada_task_ptid): Update.
7501         (_initialize_ravenscar): Don't initialize base_ptid.
7502         (ravenscar_ops): Remove global.
7503
7504 2019-02-15  Tom Tromey  <tromey@adacore.com>
7505
7506         * target.h (push_target): Declare new overload.
7507         * target.c (push_target): New overload, taking an rvalue reference.
7508         * remote.c (remote_target::open_1): Use push_target overload.
7509         * corelow.c (core_target_open): Use push_target overload.
7510
7511 2019-02-15  Tom Tromey  <tromey@adacore.com>
7512
7513         * ravenscar-thread.c (is_ravenscar_task)
7514         (ravenscar_task_is_currently_active): Return bool.
7515         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7516         (_initialize_ravenscar): Remove "(void)".
7517         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7518         Return bool.
7519
7520 2019-02-15  Tom Tromey  <tromey@adacore.com>
7521
7522         * ravenscar-thread.c (ravenscar_runtime_initializer)
7523         (has_ravenscar_runtime, get_running_thread_id)
7524         (ravenscar_thread_target::resume): Fix indentation.
7525
7526 2019-02-15  Tom Tromey  <tromey@adacore.com>
7527
7528         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7529         from ravenscar_arch_ops.
7530         (sparc_ravenscar_ops::fetch_registers)
7531         (sparc_ravenscar_ops::store_registers): Now methods.
7532         (sparc_ravenscar_prepare_to_store): Remove.
7533         (sparc_ravenscar_ops): Redefine.
7534         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7535         methods and destructor.  Remove members.
7536         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7537         (ravenscar_thread_target::store_registers)
7538         (ravenscar_thread_target::prepare_to_store): Update.
7539         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7540         Remove.
7541         (struct ppc_ravenscar_powerpc_ops): Derive from
7542         ravenscar_arch_ops.
7543         (ppc_ravenscar_powerpc_ops::fetch_registers)
7544         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7545         (ppc_ravenscar_powerpc_ops): Redefine.
7546         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7547         (ppc_ravenscar_e500_ops::fetch_registers)
7548         (ppc_ravenscar_e500_ops::store_registers): Now methods.
7549         (ppc_ravenscar_e500_ops): Redefine.
7550         * aarch64-ravenscar-thread.c
7551         (aarch64_ravenscar_generic_prepare_to_store): Remove.
7552         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7553         (aarch64_ravenscar_fetch_registers)
7554         (aarch64_ravenscar_store_registers): Now methods.
7555         (aarch64_ravenscar_ops): Redefine.
7556
7557 2019-02-15  Tom Tromey  <tromey@adacore.com>
7558
7559         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7560         (ravenscar_thread_target::stopped_by_hw_breakpoint)
7561         (ravenscar_thread_target::stopped_by_watchpoint)
7562         (ravenscar_thread_target::stopped_data_address)
7563         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
7564
7565 2019-02-15  Tom Tromey  <tromey@adacore.com>
7566
7567         * ravenscar-thread.c: Fix some typos.
7568
7569 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7570             Tom Tromey  <tromey@adacore.com>
7571
7572         * ada-lang.c (ada_exception_sal): Change addr_string to a
7573         std::string.
7574         (create_ada_exception_catchpoint): Update.
7575
7576 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7577             Tom Tromey  <tromey@adacore.com>
7578
7579         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
7580         (bp_location_ops): Remove.
7581         (base_breakpoint_allocate_location): Update.
7582         (free_bp_location): Update.
7583         * ada-lang.c (class ada_catchpoint_location)
7584         <ada_catchpoint_location>: Remove ops parameter.
7585         (ada_catchpoint_location_dtor): Remove.
7586         (ada_catchpoint_location_ops): Remove.
7587         (allocate_location_exception): Update.
7588         * breakpoint.h (struct bp_location_ops): Remove.
7589         (class bp_location) <bp_location>: Remove bp_location_ops
7590         parameter.
7591         <~bp_location>: Add destructor.
7592         <ops>: Remove.
7593
7594 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7595             Pedro Alves  <palves@redhat.com>
7596
7597         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
7598         'PATH_MAX'.
7599
7600 2019-02-14  David Michael  <fedora.dm0@gmail.com>
7601             Samuel Thibault  <samuel.thibault@gnu.org>
7602             Thomas Schwinge  <thomas@codesourcery.com>
7603
7604         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
7605         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
7606
7607 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7608
7609         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
7610         (check_empty): Use "const char *".
7611
7612         * gnu-nat.c (gnu_nat_target::detach): Instead of
7613         'detach_inferior (pid)' call
7614         'detach_inferior (find_inferior_pid (pid))'.
7615
7616         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
7617         'nat/fork-inferior.o'.
7618         * gnu-nat.c: #include "nat/fork-inferior.h".
7619
7620         * gnu-nat.c (gnu_nat_target::detach): Instead of
7621         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
7622         * gnu-nat.h: #include "inf-child.h".
7623         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
7624         'i386_gnu_nat_target::fetch_registers'.
7625         (gnu_store_registers): Rename/move to
7626         'i386_gnu_nat_target::store_registers'.
7627
7628         * config/i386/nm-i386gnu.h: Don't "#include" any files.
7629         * gnu-nat.h (mach_thread_info): New function.
7630         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
7631
7632         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
7633
7634 2019-02-14  Frederic Konrad  <konrad@adacore.com>
7635
7636         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
7637
7638 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
7639
7640         * windows-nat.c (windows_add_thread): Add new parameter
7641         "main_thread_p" with default value set to false.  Update
7642         function documentation as well as all callers.
7643         (windows_delete_thread): Likewise.
7644         (fake_create_process): Update call to windows_add_thread.
7645         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
7646         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
7647         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
7648         call to windows_delete_thread.
7649
7650 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
7651
7652         * MAINTAINERS: Add Andrew Burgess as global maintainer.
7653
7654 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7655
7656         * symfile.c (find_separate_debug_file): Use canonical path of
7657         sysroot with child_path instead of gdb_sysroot if it is valid.
7658
7659 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7660
7661         * symfile.c (find_separate_debug_file): Use child_path to
7662         determine if an object file is under a sysroot.
7663
7664 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7665
7666         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
7667         unittests/child-path-selftests.c.
7668         * common/pathstuff.c (child_path): New function.
7669         * common/pathstuff.h (child_path): New prototype.
7670         * unittests/child-path-selftests.c: New file.
7671
7672 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7673
7674         * symfile.c (find_separate_debug_file): Look for separate debug
7675         files in debug directories under the sysroot.
7676
7677 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7678
7679         * symtab.h (struct minimal_symbol data_p): New const method.
7680         (struct minimal_symbol text_p): Likewise.
7681         * symtab.c (output_source_filename): Use file name style
7682         to print file name.
7683         (print_symbol_info): Likewise.
7684         (print_msymbol_info): Use address style to print addresses.
7685         Use function name style to print executable text symbols.
7686         (expand_symtab_containing_pc): Use data_p.
7687         (find_pc_sect_compunit_symtab): Likewise.
7688
7689 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7690
7691         * breakpoint.c (describe_other_breakpoints): Use address style
7692         to print addresses.
7693         (say_where): Likewise.
7694
7695 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7696
7697         * ada-typeprint.c (print_func_type): Print function name
7698         style to print function name.
7699         * c-typeprint.c (c_print_type_1): Likewise.
7700
7701 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
7702
7703         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
7704         for execve.
7705
7706 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7707
7708         * c-exp.y (direct_abs_decl): Use emplace_back to record the
7709         type_stack.
7710
7711 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
7712
7713         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
7714         TYPE_CODE_REF types.
7715
7716 2019-02-08  Jim Wilson  <jimw@sifive.com>
7717
7718         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
7719         (riscv_linux_fregset): New.
7720         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
7721
7722 2019-02-07  Tom Tromey  <tom@tromey.com>
7723
7724         * thread.c (thread_cancel_execution_command): Update.
7725         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
7726         methods.
7727         (struct thread_fsm_ops): Remove.
7728         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
7729         (thread_fsm_should_stop, thread_fsm_return_value)
7730         (thread_fsm_set_finished, thread_fsm_finished_p)
7731         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
7732         Don't declare.
7733         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
7734         * infrun.c (clear_proceed_status_thread)
7735         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
7736         (print_stop_event): Update.
7737         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
7738         Add constructor.
7739         (step_command_fsm_ops): Remove.
7740         (new_step_command_fsm): Remove.
7741         (step_1): Update.
7742         (step_command_fsm::should_stop): Rename from
7743         step_command_fsm_should_stop.
7744         (step_command_fsm::clean_up): Rename from
7745         step_command_fsm_clean_up.
7746         (step_command_fsm::do_async_reply_reason): Rename from
7747         step_command_fsm_async_reply_reason.
7748         (struct until_next_fsm): Inherit from thread_fsm.  Add
7749         constructor.
7750         (until_next_fsm_ops): Remove.
7751         (new_until_next_fsm): Remove.
7752         (until_next_fsm::should_stop): Rename from
7753         until_next_fsm_should_stop.
7754         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
7755         (until_next_fsm::do_async_reply_reason): Rename from
7756         until_next_fsm_async_reply_reason.
7757         (struct finish_command_fsm): Inherit from thread_fsm.  Add
7758         constructor.  Change type of breakpoint.
7759         (finish_command_fsm_ops): Remove.
7760         (new_finish_command_fsm): Remove.
7761         (finish_command_fsm::should_stop): Rename from
7762         finish_command_fsm_should_stop.
7763         (finish_command_fsm::clean_up): Rename from
7764         finish_command_fsm_clean_up.
7765         (finish_command_fsm::return_value): Rename from
7766         finish_command_fsm_return_value.
7767         (finish_command_fsm::do_async_reply_reason): Rename from
7768         finish_command_fsm_async_reply_reason.
7769         (finish_command): Update.
7770         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
7771         Add constructor.
7772         (call_thread_fsm_ops): Remove.
7773         (call_thread_fsm::call_thread_fsm): Rename from
7774         new_call_thread_fsm.
7775         (call_thread_fsm::should_stop): Rename from
7776         call_thread_fsm_should_stop.
7777         (call_thread_fsm::should_notify_stop): Rename from
7778         call_thread_fsm_should_notify_stop.
7779         (run_inferior_call, call_function_by_hand_dummy): Update.
7780         * cli/cli-interp.c (should_print_stop_to_console): Update.
7781         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
7782         Add constructor.  Change type of location_breakpoint,
7783         caller_breakpoint.
7784         (until_break_fsm_ops): Remove.
7785         (new_until_break_fsm): Remove.
7786         (until_break_fsm::should_stop): Rename from
7787         until_break_fsm_should_stop.
7788         (until_break_fsm::clean_up): Rename from
7789         until_break_fsm_clean_up.
7790         (until_break_fsm::do_async_reply_reason): Rename from
7791         until_break_fsm_async_reply_reason.
7792         (until_break_command): Update.
7793         * thread-fsm.c: Remove.
7794         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
7795
7796 2019-02-07  Tom Tromey  <tom@tromey.com>
7797
7798         * yy-remap.h: Add include guard.
7799         * xtensa-tdep.h: Add include guard.
7800         * xcoffread.h: Rename include guard.
7801         * varobj-iter.h: Add include guard.
7802         * tui/tui.h: Rename include guard.
7803         * tui/tui-winsource.h: Rename include guard.
7804         * tui/tui-wingeneral.h: Rename include guard.
7805         * tui/tui-windata.h: Rename include guard.
7806         * tui/tui-win.h: Rename include guard.
7807         * tui/tui-stack.h: Rename include guard.
7808         * tui/tui-source.h: Rename include guard.
7809         * tui/tui-regs.h: Rename include guard.
7810         * tui/tui-out.h: Rename include guard.
7811         * tui/tui-layout.h: Rename include guard.
7812         * tui/tui-io.h: Rename include guard.
7813         * tui/tui-hooks.h: Rename include guard.
7814         * tui/tui-file.h: Rename include guard.
7815         * tui/tui-disasm.h: Rename include guard.
7816         * tui/tui-data.h: Rename include guard.
7817         * tui/tui-command.h: Rename include guard.
7818         * tic6x-tdep.h: Add include guard.
7819         * target/waitstatus.h: Rename include guard.
7820         * target/wait.h: Rename include guard.
7821         * target/target.h: Rename include guard.
7822         * target/resume.h: Rename include guard.
7823         * target-float.h: Rename include guard.
7824         * stabsread.h: Add include guard.
7825         * rs6000-tdep.h: Add include guard.
7826         * riscv-fbsd-tdep.h: Add include guard.
7827         * regformats/regdef.h: Rename include guard.
7828         * record.h: Rename include guard.
7829         * python/python.h: Rename include guard.
7830         * python/python-internal.h: Rename include guard.
7831         * python/py-stopevent.h: Rename include guard.
7832         * python/py-ref.h: Rename include guard.
7833         * python/py-record.h: Rename include guard.
7834         * python/py-record-full.h: Rename include guard.
7835         * python/py-record-btrace.h: Rename include guard.
7836         * python/py-instruction.h: Rename include guard.
7837         * python/py-events.h: Rename include guard.
7838         * python/py-event.h: Rename include guard.
7839         * procfs.h: Add include guard.
7840         * proc-utils.h: Add include guard.
7841         * p-lang.h: Add include guard.
7842         * or1k-tdep.h: Rename include guard.
7843         * observable.h: Rename include guard.
7844         * nto-tdep.h: Rename include guard.
7845         * nat/x86-linux.h: Rename include guard.
7846         * nat/x86-linux-dregs.h: Rename include guard.
7847         * nat/x86-gcc-cpuid.h: Add include guard.
7848         * nat/x86-dregs.h: Rename include guard.
7849         * nat/x86-cpuid.h: Rename include guard.
7850         * nat/ppc-linux.h: Rename include guard.
7851         * nat/mips-linux-watch.h: Rename include guard.
7852         * nat/linux-waitpid.h: Rename include guard.
7853         * nat/linux-ptrace.h: Rename include guard.
7854         * nat/linux-procfs.h: Rename include guard.
7855         * nat/linux-osdata.h: Rename include guard.
7856         * nat/linux-nat.h: Rename include guard.
7857         * nat/linux-namespaces.h: Rename include guard.
7858         * nat/linux-btrace.h: Rename include guard.
7859         * nat/glibc_thread_db.h: Rename include guard.
7860         * nat/gdb_thread_db.h: Rename include guard.
7861         * nat/gdb_ptrace.h: Rename include guard.
7862         * nat/fork-inferior.h: Rename include guard.
7863         * nat/amd64-linux-siginfo.h: Rename include guard.
7864         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7865         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7866         * nat/aarch64-linux.h: Rename include guard.
7867         * nat/aarch64-linux-hw-point.h: Rename include guard.
7868         * mn10300-tdep.h: Add include guard.
7869         * mips-linux-tdep.h: Add include guard.
7870         * mi/mi-parse.h: Rename include guard.
7871         * mi/mi-out.h: Rename include guard.
7872         * mi/mi-main.h: Rename include guard.
7873         * mi/mi-interp.h: Rename include guard.
7874         * mi/mi-getopt.h: Rename include guard.
7875         * mi/mi-console.h: Rename include guard.
7876         * mi/mi-common.h: Rename include guard.
7877         * mi/mi-cmds.h: Rename include guard.
7878         * mi/mi-cmd-break.h: Rename include guard.
7879         * m2-lang.h: Add include guard.
7880         * location.h: Rename include guard.
7881         * linux-record.h: Rename include guard.
7882         * linux-nat.h: Add include guard.
7883         * linux-fork.h: Add include guard.
7884         * i386-darwin-tdep.h: Rename include guard.
7885         * hppa-linux-offsets.h: Add include guard.
7886         * guile/guile.h: Rename include guard.
7887         * guile/guile-internal.h: Rename include guard.
7888         * gnu-nat.h: Rename include guard.
7889         * gdb-stabs.h: Rename include guard.
7890         * frv-tdep.h: Add include guard.
7891         * f-lang.h: Add include guard.
7892         * event-loop.h: Add include guard.
7893         * darwin-nat.h: Rename include guard.
7894         * cp-abi.h: Rename include guard.
7895         * config/sparc/nm-sol2.h: Rename include guard.
7896         * config/nm-nto.h: Rename include guard.
7897         * config/nm-linux.h: Add include guard.
7898         * config/i386/nm-i386gnu.h: Rename include guard.
7899         * config/djgpp/nl_types.h: Rename include guard.
7900         * config/djgpp/langinfo.h: Rename include guard.
7901         * compile/gcc-cp-plugin.h: Add include guard.
7902         * compile/gcc-c-plugin.h: Add include guard.
7903         * compile/compile.h: Rename include guard.
7904         * compile/compile-object-run.h: Rename include guard.
7905         * compile/compile-object-load.h: Rename include guard.
7906         * compile/compile-internal.h: Rename include guard.
7907         * compile/compile-cplus.h: Rename include guard.
7908         * compile/compile-c.h: Rename include guard.
7909         * common/xml-utils.h: Rename include guard.
7910         * common/x86-xstate.h: Rename include guard.
7911         * common/version.h: Rename include guard.
7912         * common/vec.h: Rename include guard.
7913         * common/tdesc.h: Rename include guard.
7914         * common/selftest.h: Rename include guard.
7915         * common/scoped_restore.h: Rename include guard.
7916         * common/scoped_mmap.h: Rename include guard.
7917         * common/scoped_fd.h: Rename include guard.
7918         * common/safe-iterator.h: Rename include guard.
7919         * common/run-time-clock.h: Rename include guard.
7920         * common/refcounted-object.h: Rename include guard.
7921         * common/queue.h: Rename include guard.
7922         * common/ptid.h: Rename include guard.
7923         * common/print-utils.h: Rename include guard.
7924         * common/preprocessor.h: Rename include guard.
7925         * common/pathstuff.h: Rename include guard.
7926         * common/observable.h: Rename include guard.
7927         * common/netstuff.h: Rename include guard.
7928         * common/job-control.h: Rename include guard.
7929         * common/host-defs.h: Rename include guard.
7930         * common/gdb_wait.h: Rename include guard.
7931         * common/gdb_vecs.h: Rename include guard.
7932         * common/gdb_unlinker.h: Rename include guard.
7933         * common/gdb_unique_ptr.h: Rename include guard.
7934         * common/gdb_tilde_expand.h: Rename include guard.
7935         * common/gdb_sys_time.h: Rename include guard.
7936         * common/gdb_string_view.h: Rename include guard.
7937         * common/gdb_splay_tree.h: Rename include guard.
7938         * common/gdb_setjmp.h: Rename include guard.
7939         * common/gdb_ref_ptr.h: Rename include guard.
7940         * common/gdb_optional.h: Rename include guard.
7941         * common/gdb_locale.h: Rename include guard.
7942         * common/gdb_assert.h: Rename include guard.
7943         * common/filtered-iterator.h: Rename include guard.
7944         * common/filestuff.h: Rename include guard.
7945         * common/fileio.h: Rename include guard.
7946         * common/environ.h: Rename include guard.
7947         * common/common-utils.h: Rename include guard.
7948         * common/common-types.h: Rename include guard.
7949         * common/common-regcache.h: Rename include guard.
7950         * common/common-inferior.h: Rename include guard.
7951         * common/common-gdbthread.h: Rename include guard.
7952         * common/common-exceptions.h: Rename include guard.
7953         * common/common-defs.h: Rename include guard.
7954         * common/common-debug.h: Rename include guard.
7955         * common/cleanups.h: Rename include guard.
7956         * common/buffer.h: Rename include guard.
7957         * common/btrace-common.h: Rename include guard.
7958         * common/break-common.h: Rename include guard.
7959         * cli/cli-utils.h: Rename include guard.
7960         * cli/cli-style.h: Rename include guard.
7961         * cli/cli-setshow.h: Rename include guard.
7962         * cli/cli-script.h: Rename include guard.
7963         * cli/cli-interp.h: Rename include guard.
7964         * cli/cli-decode.h: Rename include guard.
7965         * cli/cli-cmds.h: Rename include guard.
7966         * charset-list.h: Add include guard.
7967         * buildsym-legacy.h: Rename include guard.
7968         * bfin-tdep.h: Add include guard.
7969         * ax.h: Rename include guard.
7970         * arm-linux-tdep.h: Add include guard.
7971         * arm-fbsd-tdep.h: Add include guard.
7972         * arch/xtensa.h: Rename include guard.
7973         * arch/tic6x.h: Add include guard.
7974         * arch/i386.h: Add include guard.
7975         * arch/arm.h: Rename include guard.
7976         * arch/arm-linux.h: Rename include guard.
7977         * arch/arm-get-next-pcs.h: Rename include guard.
7978         * arch/amd64.h: Add include guard.
7979         * arch/aarch64-insn.h: Rename include guard.
7980         * arch-utils.h: Rename include guard.
7981         * annotate.h: Add include guard.
7982         * amd64-darwin-tdep.h: Rename include guard.
7983         * aarch64-linux-tdep.h: Add include guard.
7984         * aarch64-fbsd-tdep.h: Add include guard.
7985         * aarch32-linux-nat.h: Add include guard.
7986
7987 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7988
7989         * macrotab.c (macro_define_internal): New function that
7990         factorizes macro_define_object_internal and macro_define_function
7991         code.
7992         (macro_define_object_internal): Use macro_define_internal.
7993         (macro_define_function): Likewise.
7994
7995 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7996
7997         * macrocmd.c (extract_identifier): Return
7998         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
7999         callers.
8000
8001 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8002
8003         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8004
8005 2019-02-05  Tom Tromey  <tom@tromey.com>
8006
8007         * target.c (target_stack::unpush): Move assertion earlier.
8008
8009 2019-01-30  Tom Tromey  <tom@tromey.com>
8010
8011         PR python/23615:
8012         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8013         (gdbpy_parse_and_eval): Likewise.
8014         * python/python-internal.h (gdbpy_allow_threads): New class.
8015
8016 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8017
8018         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8019         (aarch64_fbsd_fpregmap): Move earlier.
8020         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8021         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8022         instead of individual calls to trad_frame_set_reg_addr.
8023         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8024         earlier.
8025         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8026         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8027         instead of individual calls to trad_frame_set_reg_addr.
8028
8029 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8030
8031         * CONTRIBUTE: Replace contribution list with wiki link.
8032
8033 2019-01-25  Tom Tromey  <tom@tromey.com>
8034
8035         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8036
8037 2019-01-25  Tom Tromey  <tom@tromey.com>
8038
8039         * xtensa-linux-nat.c: Fix common/ includes.
8040         * xml-support.h: Fix common/ includes.
8041         * xml-support.c: Fix common/ includes.
8042         * x86-linux-nat.c: Fix common/ includes.
8043         * windows-nat.c: Fix common/ includes.
8044         * varobj.h: Fix common/ includes.
8045         * varobj.c: Fix common/ includes.
8046         * value.c: Fix common/ includes.
8047         * valops.c: Fix common/ includes.
8048         * utils.c: Fix common/ includes.
8049         * unittests/xml-utils-selftests.c: Fix common/ includes.
8050         * unittests/utils-selftests.c: Fix common/ includes.
8051         * unittests/unpack-selftests.c: Fix common/ includes.
8052         * unittests/tracepoint-selftests.c: Fix common/ includes.
8053         * unittests/style-selftests.c: Fix common/ includes.
8054         * unittests/string_view-selftests.c: Fix common/ includes.
8055         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8056         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8057         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8058         * unittests/rsp-low-selftests.c: Fix common/ includes.
8059         * unittests/parse-connection-spec-selftests.c: Fix common/
8060         includes.
8061         * unittests/optional-selftests.c: Fix common/ includes.
8062         * unittests/offset-type-selftests.c: Fix common/ includes.
8063         * unittests/observable-selftests.c: Fix common/ includes.
8064         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8065         * unittests/memrange-selftests.c: Fix common/ includes.
8066         * unittests/memory-map-selftests.c: Fix common/ includes.
8067         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8068         * unittests/function-view-selftests.c: Fix common/ includes.
8069         * unittests/environ-selftests.c: Fix common/ includes.
8070         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8071         * unittests/common-utils-selftests.c: Fix common/ includes.
8072         * unittests/cli-utils-selftests.c: Fix common/ includes.
8073         * unittests/array-view-selftests.c: Fix common/ includes.
8074         * ui-file.c: Fix common/ includes.
8075         * tui/tui-io.c: Fix common/ includes.
8076         * tracepoint.h: Fix common/ includes.
8077         * tracepoint.c: Fix common/ includes.
8078         * tracefile-tfile.c: Fix common/ includes.
8079         * top.h: Fix common/ includes.
8080         * top.c: Fix common/ includes.
8081         * thread.c: Fix common/ includes.
8082         * target/waitstatus.h: Fix common/ includes.
8083         * target/waitstatus.c: Fix common/ includes.
8084         * target.h: Fix common/ includes.
8085         * target.c: Fix common/ includes.
8086         * target-memory.c: Fix common/ includes.
8087         * target-descriptions.c: Fix common/ includes.
8088         * symtab.h: Fix common/ includes.
8089         * symfile.c: Fix common/ includes.
8090         * stap-probe.c: Fix common/ includes.
8091         * spu-linux-nat.c: Fix common/ includes.
8092         * sparc-nat.c: Fix common/ includes.
8093         * source.c: Fix common/ includes.
8094         * solib.c: Fix common/ includes.
8095         * solib-target.c: Fix common/ includes.
8096         * ser-unix.c: Fix common/ includes.
8097         * ser-tcp.c: Fix common/ includes.
8098         * ser-pipe.c: Fix common/ includes.
8099         * ser-base.c: Fix common/ includes.
8100         * selftest-arch.c: Fix common/ includes.
8101         * s12z-tdep.c: Fix common/ includes.
8102         * rust-exp.y: Fix common/ includes.
8103         * rs6000-aix-tdep.c: Fix common/ includes.
8104         * riscv-tdep.c: Fix common/ includes.
8105         * remote.c: Fix common/ includes.
8106         * remote-notif.h: Fix common/ includes.
8107         * remote-fileio.h: Fix common/ includes.
8108         * remote-fileio.c: Fix common/ includes.
8109         * regcache.h: Fix common/ includes.
8110         * regcache.c: Fix common/ includes.
8111         * record-btrace.c: Fix common/ includes.
8112         * python/python.c: Fix common/ includes.
8113         * python/py-type.c: Fix common/ includes.
8114         * python/py-inferior.c: Fix common/ includes.
8115         * progspace.h: Fix common/ includes.
8116         * producer.c: Fix common/ includes.
8117         * procfs.c: Fix common/ includes.
8118         * proc-api.c: Fix common/ includes.
8119         * printcmd.c: Fix common/ includes.
8120         * ppc-linux-nat.c: Fix common/ includes.
8121         * parser-defs.h: Fix common/ includes.
8122         * osdata.c: Fix common/ includes.
8123         * obsd-nat.c: Fix common/ includes.
8124         * nat/x86-linux.c: Fix common/ includes.
8125         * nat/x86-linux-dregs.c: Fix common/ includes.
8126         * nat/x86-dregs.h: Fix common/ includes.
8127         * nat/x86-dregs.c: Fix common/ includes.
8128         * nat/ppc-linux.c: Fix common/ includes.
8129         * nat/mips-linux-watch.h: Fix common/ includes.
8130         * nat/mips-linux-watch.c: Fix common/ includes.
8131         * nat/linux-waitpid.c: Fix common/ includes.
8132         * nat/linux-ptrace.h: Fix common/ includes.
8133         * nat/linux-ptrace.c: Fix common/ includes.
8134         * nat/linux-procfs.c: Fix common/ includes.
8135         * nat/linux-personality.c: Fix common/ includes.
8136         * nat/linux-osdata.c: Fix common/ includes.
8137         * nat/linux-namespaces.c: Fix common/ includes.
8138         * nat/linux-btrace.h: Fix common/ includes.
8139         * nat/linux-btrace.c: Fix common/ includes.
8140         * nat/fork-inferior.c: Fix common/ includes.
8141         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8142         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8143         * nat/aarch64-linux.c: Fix common/ includes.
8144         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8145         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8146         * namespace.h: Fix common/ includes.
8147         * mips-linux-tdep.c: Fix common/ includes.
8148         * minsyms.c: Fix common/ includes.
8149         * mi/mi-parse.h: Fix common/ includes.
8150         * mi/mi-main.c: Fix common/ includes.
8151         * mi/mi-cmd-env.c: Fix common/ includes.
8152         * memrange.h: Fix common/ includes.
8153         * memattr.c: Fix common/ includes.
8154         * maint.h: Fix common/ includes.
8155         * maint.c: Fix common/ includes.
8156         * main.c: Fix common/ includes.
8157         * machoread.c: Fix common/ includes.
8158         * location.c: Fix common/ includes.
8159         * linux-thread-db.c: Fix common/ includes.
8160         * linux-nat.c: Fix common/ includes.
8161         * linux-fork.c: Fix common/ includes.
8162         * inline-frame.c: Fix common/ includes.
8163         * infrun.c: Fix common/ includes.
8164         * inflow.c: Fix common/ includes.
8165         * inferior.h: Fix common/ includes.
8166         * inferior.c: Fix common/ includes.
8167         * infcmd.c: Fix common/ includes.
8168         * inf-ptrace.c: Fix common/ includes.
8169         * inf-child.c: Fix common/ includes.
8170         * ia64-linux-nat.c: Fix common/ includes.
8171         * i387-tdep.c: Fix common/ includes.
8172         * i386-tdep.c: Fix common/ includes.
8173         * i386-linux-tdep.c: Fix common/ includes.
8174         * i386-linux-nat.c: Fix common/ includes.
8175         * i386-go32-tdep.c: Fix common/ includes.
8176         * i386-fbsd-tdep.c: Fix common/ includes.
8177         * i386-fbsd-nat.c: Fix common/ includes.
8178         * guile/scm-type.c: Fix common/ includes.
8179         * guile/guile.c: Fix common/ includes.
8180         * go32-nat.c: Fix common/ includes.
8181         * gnu-nat.c: Fix common/ includes.
8182         * gdbthread.h: Fix common/ includes.
8183         * gdbarch-selftests.c: Fix common/ includes.
8184         * gdb_usleep.c: Fix common/ includes.
8185         * gdb_select.h: Fix common/ includes.
8186         * gdb_bfd.c: Fix common/ includes.
8187         * gcore.c: Fix common/ includes.
8188         * fork-child.c: Fix common/ includes.
8189         * findvar.c: Fix common/ includes.
8190         * fbsd-nat.c: Fix common/ includes.
8191         * event-top.c: Fix common/ includes.
8192         * event-loop.c: Fix common/ includes.
8193         * dwarf2read.c: Fix common/ includes.
8194         * dwarf2loc.c: Fix common/ includes.
8195         * dwarf2-frame.c: Fix common/ includes.
8196         * dwarf-index-cache.c: Fix common/ includes.
8197         * dtrace-probe.c: Fix common/ includes.
8198         * disasm-selftests.c: Fix common/ includes.
8199         * defs.h: Fix common/ includes.
8200         * csky-tdep.c: Fix common/ includes.
8201         * cp-valprint.c: Fix common/ includes.
8202         * cp-support.h: Fix common/ includes.
8203         * cp-support.c: Fix common/ includes.
8204         * corelow.c: Fix common/ includes.
8205         * completer.h: Fix common/ includes.
8206         * completer.c: Fix common/ includes.
8207         * compile/compile.c: Fix common/ includes.
8208         * compile/compile-loc2c.c: Fix common/ includes.
8209         * compile/compile-cplus-types.c: Fix common/ includes.
8210         * compile/compile-cplus-symbols.c: Fix common/ includes.
8211         * command.h: Fix common/ includes.
8212         * cli/cli-dump.c: Fix common/ includes.
8213         * cli/cli-cmds.c: Fix common/ includes.
8214         * charset.c: Fix common/ includes.
8215         * build-id.c: Fix common/ includes.
8216         * btrace.h: Fix common/ includes.
8217         * btrace.c: Fix common/ includes.
8218         * breakpoint.h: Fix common/ includes.
8219         * breakpoint.c: Fix common/ includes.
8220         * ax.h:
8221         (enum agent_op): Fix common/ includes.
8222         * ax-general.c (struct aop_map): Fix common/ includes.
8223         * ax-gdb.c: Fix common/ includes.
8224         * auxv.c: Fix common/ includes.
8225         * auto-load.c: Fix common/ includes.
8226         * arm-tdep.c: Fix common/ includes.
8227         * arch/riscv.c: Fix common/ includes.
8228         * arch/ppc-linux-common.c: Fix common/ includes.
8229         * arch/i386.c: Fix common/ includes.
8230         * arch/arm.c: Fix common/ includes.
8231         * arch/arm-linux.c: Fix common/ includes.
8232         * arch/arm-get-next-pcs.c: Fix common/ includes.
8233         * arch/amd64.c: Fix common/ includes.
8234         * arch/aarch64.c: Fix common/ includes.
8235         * arch/aarch64-insn.c: Fix common/ includes.
8236         * arch-utils.c: Fix common/ includes.
8237         * amd64-windows-tdep.c: Fix common/ includes.
8238         * amd64-tdep.c: Fix common/ includes.
8239         * amd64-sol2-tdep.c: Fix common/ includes.
8240         * amd64-obsd-tdep.c: Fix common/ includes.
8241         * amd64-nbsd-tdep.c: Fix common/ includes.
8242         * amd64-linux-tdep.c: Fix common/ includes.
8243         * amd64-linux-nat.c: Fix common/ includes.
8244         * amd64-fbsd-tdep.c: Fix common/ includes.
8245         * amd64-fbsd-nat.c: Fix common/ includes.
8246         * amd64-dicos-tdep.c: Fix common/ includes.
8247         * amd64-darwin-tdep.c: Fix common/ includes.
8248         * agent.c: Fix common/ includes.
8249         * ada-lang.h: Fix common/ includes.
8250         * ada-lang.c: Fix common/ includes.
8251         * aarch64-tdep.c: Fix common/ includes.
8252
8253 2019-01-25  Tom Tromey  <tom@tromey.com>
8254
8255         * common/create-version.sh: Use common/version.h.
8256
8257 2019-01-24  Pedro Alves  <palves@redhat.com>
8258
8259         * infrun.c (signal_stop, signal_print, signal_program)
8260         (signal_catch, signal_pass): Now arrays instead of pointers.
8261         (update_signals_program_target, do_target_resume)
8262         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8263         * linux-nat.c (linux_nat_target::pass_signals)
8264         (linux_nat_target::create_inferior, linux_nat_target::attach):
8265         Adjust.
8266         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8267         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8268         * procfs.c (procfs_target::pass_signals): Adjust.
8269         * record-full.c (record_full_target::resume): Adjust.
8270         * remote.c (remote_target::pass_signals)
8271         (remote_target::program_signals): Adjust.
8272         * target-debug.h (target_debug_print_signals): Now takes a
8273         gdb::array_view as parameter.  Adjust.
8274         * target.h (target_ops) <pass_signals, program_signals>: Replace
8275         pointer and length parameters with gdb::array_view.
8276         (target_pass_signals, target_program_signals): Likewise.
8277         * target-delegates.c: Regenerate.
8278
8279 2019-01-24  Pedro Alves  <palves@redhat.com>
8280
8281         * common/forward-scope-exit.h
8282         (forward_scope_exit::forward_scope_exit): Pass arguments to
8283         m_bind_function directly, instead of creating a std::bind and
8284         copying that.
8285
8286 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8287
8288         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8289         for static members.
8290         (pass_in_v_vfp_candidate): Likewise.
8291
8292 2019-01-23  Tom Tromey  <tom@tromey.com>
8293             Pedro Alves  <palves@redhat.com>
8294
8295         * regcache.c (class regcache_invalidator): Remove.
8296         (regcache::raw_write): Use make_scope_exit.
8297
8298 2019-01-23  Tom Tromey  <tom@tromey.com>
8299
8300         * ui-out.h (class ui_out_emit_type): Update comment.
8301
8302 2019-01-23  Tom Tromey  <tom@tromey.com>
8303
8304         * infrun.c (fetch_inferior_event): Update comment.
8305
8306 2019-01-23  Tom Tromey  <tom@tromey.com>
8307             Pedro Alves  <palves@redhat.com>
8308
8309         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8310         parameter.
8311         (fetch_inferior_event): Use SCOPE_EXIT.
8312
8313
8314 2019-01-23  Tom Tromey  <tom@tromey.com>
8315             Pedro Alves  <palves@redhat.com>
8316
8317         * infrun.c (disable_thread_events): Delete.
8318         (stop_all_threads): Use SCOPE_EXIT.
8319
8320 2019-01-23  Tom Tromey  <tom@tromey.com>
8321             Pedro Alves  <palves@redhat.com>
8322
8323         * symfile.c: Include forward-scope-exit.h.
8324         (clear_symtab_users_cleanup): Replace forward declaration with
8325         a FORWARD_SCOPE_EXIT.
8326         (syms_from_objfile_1): Use the forward_scope_exit and
8327         gdb::optional instead of cleanup_function.
8328         (reread_symbols): Use the forward_scope_exit instead of
8329         cleanup_function.
8330         (clear_symtab_users_cleanup): Remove function.
8331
8332 2019-01-23  Tom Tromey  <tom@tromey.com>
8333             Pedro Alves  <palves@redhat.com>
8334
8335         * linux-nat.c: Include scope-exit.h.
8336         (cleanup_target_stop): Remove.
8337         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8338         SCOPE_EXIT.
8339
8340 2019-01-23  Tom Tromey  <tom@tromey.com>
8341             Pedro Alves  <palves@redhat.com>
8342
8343         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8344         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8345
8346 2019-01-23  Tom Tromey  <tom@tromey.com>
8347             Andrew Burgess  <andrew.burgess@embecosm.com>
8348             Pedro Alves  <palves@redhat.com>
8349
8350         * infrun.c (fetch_inferior_event): Use scope_exit.
8351         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8352         * top.c (execute_command): Use scope_exit.
8353         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8354         * utils.c (do_bpstat_clear_actions_cleanup)
8355         (make_bpstat_clear_actions_cleanup): Remove.
8356
8357 2019-01-23  Tom Tromey  <tom@tromey.com>
8358             Pedro Alves  <palves@redhat.com>
8359
8360         * infrun.c: Include "common/scope-exit.h"
8361         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8362         (wait_for_inferior): Use SCOPE_EXIT.
8363         (fetch_inferior_event): Use scope_exit.
8364
8365 2019-01-23  Tom Tromey  <tom@tromey.com>
8366             Pedro Alves  <palves@redhat.com>
8367
8368         * breakpoint.c (create_breakpoint): Remove cleanup.
8369
8370 2019-01-23  Tom Tromey  <tom@tromey.com>
8371             Andrew Burgess  <andrew.burgess@embecosm.com>
8372             Pedro Alves  <palves@redhat.com>
8373
8374 2019-01-23  Pedro Alves  <palves@redhat.com>
8375
8376         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8377
8378 2019-01-23  Pedro Alves  <palves@redhat.com>
8379             Andrew Burgess  <andrew.burgess@embecosm.com>
8380
8381         * gdbthread.h: Include "common/forward-scope-exit.h".
8382         (scoped_finish_thread_state): Redefine custom class in terms of
8383         forward_scope_exit.
8384
8385 2019-01-23  Pedro Alves  <palves@redhat.com>
8386             Andrew Burgess  <andrew.burgess@embecosm.com>
8387
8388         * common/forward-scope-exit.h: New file.
8389
8390 2019-01-23  Pedro Alves  <palves@redhat.com>
8391             Andrew Burgess  <andrew.burgess@embecosm.com>
8392             Tom Tromey  <tom@tromey.com>
8393
8394         * common/scope-exit.h: New file.
8395
8396 2019-01-23  Pedro Alves  <palves@redhat.com>
8397
8398         * common/preprocessor.h (ESC): Rename to ...
8399         (ESC_PARENS): ... this.
8400         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8401         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8402
8403 2019-01-23  Tom Tromey  <tom@tromey.com>
8404
8405         * language.h (class scoped_switch_to_sym_language_if_auto):
8406         Initialize m_lang in both cases.
8407
8408 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8409
8410         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8411         with XCNEW.
8412
8413 2019-01-22  Tom Tromey  <tom@tromey.com>
8414
8415         * corelow.c: Do not include sys/file.h.
8416
8417 2019-01-22  Tom Tromey  <tom@tromey.com>
8418
8419         * tui/tui-wingeneral.h: Include gdb_curses.h.
8420
8421 2019-01-22  Tom Tromey  <tom@tromey.com>
8422
8423         * source-cache.h (class source_cache) <get_source_lines,
8424         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8425
8426 2019-01-22  Tom Tromey  <tom@tromey.com>
8427
8428         * remote-fileio.h (struct remote_target): Declare.
8429
8430 2019-01-22  Tom Tromey  <tom@tromey.com>
8431
8432         * python/py-arch.c: Do not include py-ref.h.
8433         * python/py-bpevent.c: Do not include py-ref.h.
8434         * python/py-cmd.c: Do not include py-ref.h.
8435         * python/py-continueevent.c: Do not include py-ref.h.
8436         * python/py-event.h: Do not include py-ref.h.
8437         * python/py-evtregistry.c: Do not include py-ref.h.
8438         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8439         * python/py-frame.c: Do not include py-ref.h.
8440         * python/py-framefilter.c: Do not include py-ref.h.
8441         * python/py-function.c: Do not include py-ref.h.
8442         * python/py-infevents.c: Do not include py-ref.h.
8443         * python/py-linetable.c: Do not include py-ref.h.
8444         * python/py-objfile.c: Do not include py-ref.h.
8445         * python/py-param.c: Do not include py-ref.h.
8446         * python/py-prettyprint.c: Do not include py-ref.h.
8447         * python/py-progspace.c: Do not include py-ref.h.
8448         * python/py-symbol.c: Do not include py-ref.h.
8449         * python/py-symtab.c: Do not include py-ref.h.
8450         * python/py-type.c: Do not include py-ref.h.
8451         * python/py-unwind.c: Do not include py-ref.h.
8452         * python/py-utils.c: Do not include py-ref.h.
8453         * python/py-value.c: Do not include py-ref.h.
8454         * python/py-varobj.c: Do not include py-ref.h.
8455         * python/py-xmethods.c: Do not include py-ref.h.
8456         * python/python.c: Do not include py-ref.h.
8457         * varobj.c: Do not include py-ref.h.
8458
8459 2019-01-22  Tom Tromey  <tom@tromey.com>
8460
8461         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8462         keyword for bcache.
8463
8464 2019-01-22  Tom Tromey  <tom@tromey.com>
8465
8466         * compile/compile-cplus-types.c: Remove a comment by #include.
8467
8468 2019-01-22  Tom Tromey  <tom@tromey.com>
8469
8470         * compile/gcc-c-plugin.h: Include compile-internal.h.
8471
8472 2019-01-22  Tom Tromey  <tom@tromey.com>
8473
8474         * stabsread.c (EXTERN): Do not define.
8475         (symnum, next_symbol_text_func, processing_gcc_compilation)
8476         (within_function, global_sym_chain, global_stabs)
8477         (previous_stab_code, this_object_header_files)
8478         (n_this_object_header_files)
8479         (n_allocated_this_object_header_files): Define.
8480         * stabsread.h (EXTERN): Never define.  Use "extern".
8481
8482 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8483
8484         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8485         history_value.
8486
8487 2019-01-21  Tom Tromey  <tom@tromey.com>
8488
8489         * ui-out.c: Fix includes.
8490         * tui/tui-source.c: Fix includes.
8491         * target.c: Fix includes.
8492         * remote.c: Fix includes.
8493         * regcache.c: Fix includes.
8494         * python/py-block.c: Fix includes.
8495         * printcmd.c: Fix includes.
8496         * or1k-tdep.c: Fix includes.
8497         * mi/mi-main.c: Fix includes.
8498         * m32r-tdep.c: Fix includes.
8499         * csky-tdep.c: Fix includes.
8500         * compile/compile-cplus-types.c: Fix includes.
8501         * cli/cli-interp.c: Fix includes.
8502
8503 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8504
8505         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8506         for padding.
8507
8508 2019-01-16  Tom Tromey  <tom@tromey.com>
8509
8510         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8511         earlier.
8512         (struct objfile) <msymbols_range>: Move from top level.
8513         <msymbols>: New method.
8514         (class objfile_msymbols): Remove.
8515         * symtab.c (default_collect_symbol_completion_matches_break_on):
8516         Update.
8517         * symmisc.c (dump_msymbols): Update.
8518         * stabsread.c (scan_file_globals): Update.
8519         * objc-lang.c (info_selectors_command, info_classes_command)
8520         (find_methods): Update.
8521         * minsyms.c (find_solib_trampoline_target): Update.
8522         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8523         * coffread.c (coff_symfile_read): Update.
8524         * ada-lang.c (ada_lookup_simple_minsym)
8525         (ada_collect_symbol_completion_matches): Update.
8526
8527 2019-01-16  Tom Tromey  <tom@tromey.com>
8528
8529         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8530         type.  Remove no-argument constructor.
8531         <iterator::operator++>: Simplify.
8532         <begin>: Update.
8533         <end>: Use minimal_symbol_count.
8534
8535 2019-01-16  Tom Tromey  <tom@tromey.com>
8536
8537         * objfiles.h (struct objfile) <psymtabs>: New method.
8538         (class objfile_psymtabs): Remove.
8539         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8540         typedef.
8541         <range>: New method.
8542         (require_partial_symbols): Change return type.
8543         * psymtab.c (require_partial_symbols)
8544         (psym_expand_symtabs_matching): Update.
8545         * mdebugread.c (parse_partial_symbols): Update.
8546         * dbxread.c (dbx_end_psymtab): Update.
8547
8548 2019-01-15  Tom Tromey  <tom@tromey.com>
8549
8550         * symtab.c (lookup_objfile_from_block)
8551         (lookup_symbol_in_objfile_symtabs)
8552         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8553         (find_line_symtab, info_sources_command)
8554         (default_collect_symbol_completion_matches_break_on)
8555         (make_source_files_completion_list): Update.
8556         * symmisc.c (print_objfile_statistics, dump_objfile)
8557         (maintenance_print_symbols, maintenance_info_symtabs)
8558         (maintenance_check_symtabs, maintenance_info_line_tables):
8559         Update.
8560         * source.c (select_source_symtab)
8561         (forget_cached_source_info_for_objfile): Update.
8562         * objfiles.h (class objfile_compunits): Remove.
8563         (struct objfile) <compunits_range>: New typedef.
8564         (compunits): New method.
8565         * objfiles.c (objfile_relocate1): Update.
8566         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8567         * maint.c (count_symtabs_and_blocks): Update.
8568         * linespec.c (iterate_over_all_matching_symtabs): Update.
8569         * cp-support.c (add_symbol_overload_list_qualified): Update.
8570         * coffread.c (coff_symtab_read): Update.
8571         * ada-lang.c (add_nonlocal_symbols)
8572         (ada_collect_symbol_completion_matches)
8573         (ada_add_global_exceptions): Update.
8574
8575 2019-01-15  Tom Tromey  <tom@tromey.com>
8576
8577         * progspace.h (program_space) <objfiles_safe_range>: New
8578         typedef.
8579         <objfiles_safe>: New method.
8580         * objfiles.h (class all_objfiles_safe): Remove.
8581         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
8582         * jit.c (jit_inferior_exit_hook): Update.
8583
8584 2019-01-17  Tom Tromey  <tom@tromey.com>
8585
8586         * progspace.h (program_space) <objfiles_range>: New typedef.
8587         <objfiles>: New method.
8588         <objfiles_head>: Rename from objfiles.
8589         (object_files): Update.
8590         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
8591         * guile/scm-pretty-print.c
8592         (ppscm_find_pretty_printer_from_objfiles): Update.
8593         * guile/scm-objfile.c (gdbscm_objfiles): Update.
8594         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
8595         Update.
8596         * python/py-progspace.c (pspy_get_objfiles): Update.
8597         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8598         Update.
8599         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8600         (objfpy_lookup_objfile_by_build_id): Update.
8601         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8602         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8603         Update.
8604         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8605         (expand_symtab_containing_pc, lookup_objfile_from_block)
8606         (lookup_static_symbol, basic_lookup_transparent_type)
8607         (find_pc_sect_compunit_symtab, find_symbol_at_address)
8608         (find_line_symtab, info_sources_command)
8609         (default_collect_symbol_completion_matches_break_on)
8610         (make_source_files_completion_list, find_main_name): Update.
8611         * symmisc.c (print_symbol_bcache_statistics)
8612         (print_objfile_statistics, maintenance_print_symbols)
8613         (maintenance_print_msymbols, maintenance_print_objfiles)
8614         (maintenance_info_symtabs, maintenance_check_symtabs)
8615         (maintenance_expand_symtabs, maintenance_info_line_tables):
8616         Update.
8617         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
8618         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
8619         (map_overlay_command, unmap_overlay_command)
8620         (simple_overlay_update, expand_symtabs_matching)
8621         (map_symbol_filenames): Update.
8622         * symfile-debug.c (set_debug_symfile): Update.
8623         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
8624         Update.
8625         * source.c (select_source_symtab, forget_cached_source_info):
8626         Update.
8627         * solib.c (solib_read_symbols): Update.
8628         * solib-spu.c (append_ocl_sos): Update.
8629         * psymtab.c (maintenance_print_psymbols)
8630         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
8631         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
8632         * printcmd.c (info_symbol_command): Update.
8633         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
8634         Update.
8635         * objfiles.h (class all_objfiles): Remove.
8636         * objfiles.c (have_partial_symbols, have_full_symbols)
8637         (have_minimal_symbols, qsort_cmp, update_section_map)
8638         (shared_objfile_contains_address_p)
8639         (default_iterate_over_objfiles_in_search_order): Update.
8640         * objc-lang.c (info_selectors_command, info_classes_command)
8641         (find_methods): Update.
8642         * minsyms.c (find_solib_trampoline_target): Update.
8643         * maint.c (maintenance_info_sections)
8644         (maintenance_translate_address, count_symtabs_and_blocks):
8645         Update.
8646         * main.c (captured_main_1): Update.
8647         * linux-thread-db.c (try_thread_db_load_from_pdir)
8648         (has_libpthread): Update.
8649         * linespec.c (iterate_over_all_matching_symtabs)
8650         (search_minsyms_for_name): Update.
8651         * jit.c (jit_find_objf_with_entry_addr): Update.
8652         * hppa-tdep.c (find_unwind_entry)
8653         (hppa_lookup_stub_minimal_symbol): Update.
8654         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
8655         Update.
8656         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8657         (elf_gnu_ifunc_resolve_by_got): Update.
8658         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
8659         * dwarf-index-write.c (save_gdb_index_command): Update.
8660         * cp-support.c (add_symbol_overload_list_qualified): Update.
8661         * breakpoint.c (create_overlay_event_breakpoint)
8662         (create_longjmp_master_breakpoint)
8663         (create_std_terminate_master_breakpoint)
8664         (create_exception_master_breakpoint): Update.
8665         * blockframe.c (find_pc_partial_function): Update.
8666         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
8667         (ada_collect_symbol_completion_matches)
8668         (ada_add_global_exceptions): Update.
8669
8670 2019-01-17  Tom Tromey  <tom@tromey.com>
8671
8672         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
8673         declare VEC.
8674         (solib_target_parse_libraries): Change return type.
8675         (library_list_start_segment, library_list_start_section)
8676         (library_list_end_library, library_list_start_library); Update.
8677         (solib_target_free_library_list): Remove.
8678         (solib_target_parse_libraries): Remove cleanup.  Change return
8679         type.
8680         (solib_target_current_sos): Update.
8681
8682 2019-01-17  Tom Tromey  <tromey@bapiya>
8683
8684         * valprint.c: Replace "the the" with "the".
8685         * symtab.c: Replace "the the" with "the".
8686         * solib.c: Replace "the the" with "the".
8687         * solib-dsbt.c: Replace "the the" with "the".
8688         * linespec.c: Replace "the the" with "the".
8689         * dwarf2loc.h: Replace "the the" with "the".
8690         * amd64-windows-tdep.c: Replace "the the" with "the".
8691         * aarch64-tdep.c: Replace "the the" with "the".
8692
8693 2019-01-16  Keith Seitz  <keiths@redhat.com>
8694
8695         PR gdb/23773
8696         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
8697         <builder>: Rename to ..
8698         <m_builder>: ... this and make private.
8699         (dwarf2_cu::get_builder): New method.  Change all users of
8700         `builder' to use this method.
8701         (dwarf2_start_symtab): Move to ...
8702         (dwarf2_cu::start_symtab): ... here.  Update all callers
8703         (setup_type_unit_groups): Move to ...
8704         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
8705         callers.
8706         (dwarf2_cu::reset_builder): New method.
8707         (process_full_compunit, process_full_type_unit): Use
8708         dwarf2_cu::reset_builder.
8709         (follow_die_offset): Record the ancestor CU if it is different
8710         from the followed DIE's CU.
8711         (follow_die_sig_1): Likewise.
8712
8713 2019-01-15  Tom Tromey  <tom@tromey.com>
8714
8715         * remote.c (class remote_state) <buf>: Now a char_vector.
8716         <buf_size>: Remove.
8717         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
8718         parameter.
8719         (remote_target::getpkt_or_notif_sane_1)
8720         (remote_target::getpkt_sane)
8721         (remote_target::getpkt_or_notif_sane): Likewise.
8722         (class remote_target) <putpkt>: New overload.
8723         (remote_target::read_frame): Change type of "buf_p".  Remove
8724         sizeof_p parameter.
8725         (packet_ok): New overload.
8726         (packet_check_result): New overload.
8727         Update all uses.
8728
8729 2019-01-14  Tom Tromey  <tom@tromey.com>
8730
8731         * remote-notif.c (handle_notification, remote_notif_ack)
8732         (remote_notif_parse): Make "buf" const.
8733         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
8734         const.
8735         (remote_notif_parse, remote_notif_ack, handle_notification):
8736         Likewise.
8737         * remote.c (remote_notif_stop_parse): Make "buf" const.
8738         (remote_target::remote_parse_stop_reply): Make "buf" const.
8739         (remote_notif_stop_ack): Make "buf" const.
8740
8741 2019-01-14  Tom Tromey  <tom@tromey.com>
8742
8743         * remote.c (remote_console_output): Make parameter const.
8744
8745 2019-01-14  Tom Tromey  <tom@tromey.com>
8746
8747         * target-debug.h (target_debug_print_signals): Constify.
8748         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
8749         * procfs.c (procfs_target::pass_signals): Update.
8750         * linux-nat.c (linux_nat_target::pass_signals): Update.
8751         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
8752         * target-delegates.c: Rebuild.
8753         * remote.c (remote_target::program_signals): Update.
8754         (remote_target::pass_signals): Update.
8755         * target.c (target_pass_signals): Constify argument.
8756         (target_program_signals): Likewise.
8757         * target.h (struct target_ops) <pass_signals, program_signals>:
8758         Constify argument.
8759         (target_pass_signals, target_program_signals): Constify argument.
8760
8761 2019-01-14  Tom Tromey  <tom@tromey.com>
8762
8763         PR tui/28819:
8764         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
8765
8766 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
8767
8768         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
8769         field.
8770         * rs6000-tdep.c: Include reggroups.h.
8771         (IS_V_ALIAS_PSEUDOREG): Define.
8772         (rs6000_register_name): Return names for the "vX" aliases.
8773         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
8774         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
8775         aliases.  Call default_register_reggroup_p for all other
8776         pseudo-registers.
8777         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
8778         New functions.
8779         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
8780         Handle "vX" aliases.
8781         (v_alias_pseudo_register_collect): New function.
8782         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
8783         (rs6000_gdbarch_init): Initialize "vX" aliases as
8784         pseudo-registers.  Restore registration of
8785         rs6000_pseudo_register_reggroup_p with
8786         set_tdesc_pseudo_register_reggroup_p.
8787
8788 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
8789
8790         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
8791         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
8792         set_gdbarch_num_pseudo_regs.
8793
8794 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8795
8796         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
8797         Remove arg prefixname, add do_set and do_show.
8798         Add member functions set_list and show_list.
8799         * cli/cli-style.c (class cli_style_option): Update accordingly.
8800         (style_set_list): Move to file scope.
8801         (style_show_list): Likewise.
8802         (set_style): Call help_list.
8803         (show_style): Call cmd_show_list.
8804         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
8805         Update to use the new macro.
8806
8807 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
8808
8809         * ada-lang.c (_initialize_ada_language): Expand the help text
8810         for the "catch exception" command.
8811
8812 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8813
8814         * symtab.c (matching_obj_sections): Initialize obj,
8815         declare it closer to its usage.
8816
8817 2019-01-10  Tom Tromey  <tom@tromey.com>
8818
8819         * thread-iter.h (inf_threads_iterator): Use next_iterator.
8820         (basic_inf_threads_range): Remove.
8821         (inf_threads_range, inf_non_exited_threads_range)
8822         (safe_inf_threads_range): Use next_adapter.
8823
8824 2019-01-10  Keith Seitz  <keiths@redhat.com>
8825
8826         PR gdb/23712
8827         PR symtab/23010
8828         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
8829         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
8830
8831 2019-01-10  Keith Seitz  <keiths@redhat.com>
8832
8833         PR gdb/23712
8834         PR symtab/23010
8835         * dictionary.c (pending_to_vector): Remove.
8836         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8837         Remove _1 suffix, replacing functions of the same name.  Update
8838         all callers.
8839         (dict_create_hashed, dict_create_hashed_expandable)
8840         (dict_create_linear, dict_create_linear_expandable, dict_free)
8841         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
8842         Make functions static.
8843
8844 2019-01-10  Keith Seitz  <keiths@redhat.com>
8845
8846         PR gdb/23712
8847         PR symtab/23010
8848         * dictionary.h (struct dictionary): Replace declaration with
8849         multidictionary.
8850         (dict_create_hashed, dict_create_hashed_expandable)
8851         (dict_create_linear, dict_create_linear_expandable)
8852         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
8853         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
8854         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
8855         taking multidictionary argument.
8856         [ALL_DICT_SYMBOLS]: Update for multidictionary.
8857         * block.h (struct block) <dict>: Change to multidictionary
8858         and rename `multidict'.
8859         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
8860         symmisc.c: Update all dictionary references to multidictionary.
8861
8862 2019-01-10  Keith Seitz  <keiths@redhat.com>
8863
8864         PR gdb/23712
8865         PR symtab/23010
8866         * dictionary.c: Include unordered_map.
8867         (pending_to_vector): New function.
8868         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8869         Rewrite the non-"_1" functions to take vector instead
8870         of linked list.
8871         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
8872         "new" _1 versions of the same name.
8873         (multidictionary): Define.
8874         (std::hash<enum language): New definition.
8875         (collate_pending_symbols_by_language, mdict_create_hashed)
8876         (mdict_create_hashed_expandable, mdict_create_linear)
8877         (mdict_create_linear_expandable, mdict_free)
8878         (find_language_dictionary, create_new_language_dictionary)
8879         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
8880         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
8881         (mdict_size, mdict_empty): New functions.
8882         * dictionary.h (mdict_iterator): Define.
8883
8884 2019-01-10  Pedro Alves  <palves@redhat.com>
8885
8886         * breakpoint.c (read_uploaded_action)
8887         (create_tracepoint_from_upload): Adjust to use
8888         gdb::unique_xmalloc_ptr.
8889         * ctf.c (ctf_write_uploaded_tp):
8890         (SET_ARRAY_FIELD): Use emplace_back.
8891         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
8892         * tracefile-tfile.c (tfile_write_uploaded_tp):
8893         * tracepoint.c (parse_tracepoint_definition): Adjust to use
8894         gdb::unique_xmalloc_ptr.
8895         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
8896         at_string, cond_string, cmd_strings>: Replace char pointers
8897         with gdb::unique_xmalloc_ptr.
8898
8899 2019-01-10  Pedro Alves  <palves@redhat.com>
8900
8901         * solib-target.c (library_list_start_library): Don't xstrdup name.
8902
8903 2019-01-10  Pedro Alves  <palves@redhat.com>
8904
8905         * mdebugread.c (parse_partial_symbols): Use
8906         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
8907
8908 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8909
8910         * linux-fork.c (scoped_switch_fork_info)
8911         <~scoped_switch_fork_info>: Fix incorrect variable name.
8912
8913 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8914
8915         * linux-fork.c (scoped_switch_fork_info)
8916         <scoped_switch_fork_info>: Make explicit.
8917         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
8918
8919 2019-01-10  Tom Tromey  <tom@tromey.com>
8920
8921         * objfiles.h (objfile::reset_psymtabs): Update.
8922         * objfiles.c (objfile::objfile): Update.
8923         * psymtab.h (psymtab_storage::obstack): Update.
8924         (psymtab_storage::m_obstack): Use gdb::optional.
8925         (class psymtab_storage): Update comment.  Remove objfile
8926         parameter.
8927         * psymtab.c (psymtab_storage::psymtab_storage): Update.
8928
8929 2019-01-10  Tom Tromey  <tom@tromey.com>
8930
8931         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
8932         <free_psymtabs>: Now private.
8933         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
8934         (allocate_psymtab): Use new method.
8935
8936 2019-01-10  Tom Tromey  <tom@tromey.com>
8937
8938         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
8939         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
8940         * mdebugread.c (parse_partial_symbols): Use
8941         allocate_dependencies.
8942         * dwarf2read.c (dwarf2_create_include_psymtab): Use
8943         allocate_dependencies.
8944         (process_psymtab_comp_unit_reader)
8945         (build_type_psymtab_dependencies): Likewise.
8946         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
8947
8948 2019-01-10  Tom Tromey  <tom@tromey.com>
8949
8950         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
8951         PSYMBOL_SET_LANGUAGE.
8952         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
8953
8954 2019-01-10  Tom Tromey  <tom@tromey.com>
8955
8956         * psymtab.h (psymtab_storage::obstack): New method.
8957         <m_obstack>: Rename from obstack; now private.
8958         * psymtab.c (psymtab_storage): Update.
8959         * dwarf2read.c (create_addrmap_from_index)
8960         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
8961         Update.
8962
8963 2019-01-10  Tom Tromey  <tom@tromey.com>
8964
8965         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
8966         * objfiles.h (objfile::reset_psymtabs): New method.
8967
8968 2019-01-10  Tom Tromey  <tom@tromey.com>
8969
8970         * symmisc.c (print_symbol_bcache_statistics): Update.
8971         (print_objfile_statistics): Update.
8972         * symfile.c (reread_symbols): Update.
8973         * psymtab.h (class psymtab_storage): New.
8974         * psymtab.c (psymtab_storage): New constructor.
8975         (~psymtab_storage): New destructor.
8976         (require_partial_symbols): Update.
8977         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
8978         (find_pc_sect_psymtab, find_pc_sect_psymbol)
8979         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
8980         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
8981         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
8982         (start_psymtab_common, end_psymtab_common)
8983         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
8984         (allocate_psymtab): Update.
8985         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
8986         Update.
8987         (dump_psymtab_addrmap, maintenance_print_psymbols)
8988         (maintenance_check_psymtabs): Update.
8989         (class objfile_psymtabs): Move to objfiles.h.
8990         * psympriv.h (discard_psymtab): Now inline.
8991         (psymtab_discarder::psymtab_discarder): Update.
8992         (psymtab_discarder::~psymtab_discarder): Update.
8993         (ALL_OBJFILE_PSYMTABS): Rewrite.
8994         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
8995         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
8996         Remove fields.
8997         <partial_symtabs>: New field.
8998         (class objfile_psymtabs): Move from psymtab.h.  Update.
8999         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9000         psymbol_cache.
9001         (objfile::~objfile): Don't destroy psymbol_cache.
9002         * mdebugread.c (parse_partial_symbols): Update.
9003         * dwarf2read.c (create_addrmap_from_index)
9004         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9005         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9006         (add_partial_subprogram, dwarf2_ranges_read): Update.
9007         * dwarf-index-write.c (write_address_map)
9008         (write_one_signatured_type, recursively_write_psymbols)
9009         (class debug_names, class debug_names, write_psymtabs_to_index):
9010         Update.
9011
9012 2019-01-10  Tom Tromey  <tom@tromey.com>
9013
9014         * symtab.h (SYMBOL_SET_NAMES): Update.
9015         (symbol_set_names): Update.
9016         (MSYMBOL_SET_NAMES): Update.
9017         * symtab.c (symbol_set_names): Change argument to be an
9018         objfile_per_bfd_storage.
9019         * psymtab.c (add_psymbol_to_bcache): Update.
9020         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9021
9022 2019-01-10  Tom Tromey  <tom@tromey.com>
9023
9024         * symtab.c (create_demangled_names_hash): Change argument to be an
9025         objfile_per_bfd_storage.
9026         (symbol_set_names): Update.
9027
9028 2019-01-10  Tom Tromey  <tom@tromey.com>
9029
9030         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9031         init_psymbol_list.
9032         * psymtab.c (init_psymbol_list): Do nothing if already called.
9033         * psympriv.h (init_psymbol_list): Add comment.
9034         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9035         init_psymbol_list.
9036         * dbxread.c (dbx_symfile_read): Unconditionally call
9037         init_psymbol_list.
9038
9039 2019-01-10  Tom Tromey  <tom@tromey.com>
9040
9041         * xcoffread.c (scan_xcoff_symtab): Update.
9042         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9043         "where".
9044         * mdebugread.c (parse_partial_symbols)
9045         (handle_psymbol_enumerators): Update.
9046         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9047         * dbxread.c (read_dbx_symtab): Update.
9048         * psympriv.h (psymbol_placement): New enum.
9049         (add_psymbol_to_list): Update.
9050
9051 2019-01-10  Tom Tromey  <tom@tromey.com>
9052
9053         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9054         static_psymbols parameters.
9055         (scan_xcoff_symtab): Update.
9056         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9057         static_psymbols parameters.
9058         * psympriv.h (start_psymtab_common): Update.
9059         * mdebugread.c (parse_partial_symbols): Update.
9060         * dwarf2read.c (create_partial_symtab): Update.
9061         * dbxread.c (read_dbx_symtab): Update.
9062         (start_psymtab): Remove global_psymbols and static_psymbols
9063         parameters.
9064
9065 2019-01-10  Tom Tromey  <tom@tromey.com>
9066
9067         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9068         * psymtab.c (allocate_psymtab): Add comment.
9069         * psympriv.h (allocate_psymtab): Add comment.
9070         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9071         initializations.
9072         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9073
9074 2019-01-10  Tom Tromey  <tom@tromey.com>
9075
9076         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9077         Don't declare.
9078         * mipsread.c: Include mdebugread.h.
9079         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9080         Declare.
9081         * elfread.c: Include mdebugread.h.
9082
9083 2019-01-09  Tom Tromey  <tom@tromey.com>
9084
9085         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9086         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9087         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9088         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9089         (psym_lookup_symbol, psym_find_last_source_symtab)
9090         (psym_forget_cached_source_info, psym_print_stats)
9091         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9092         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9093         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9094         (psym_find_compunit_symtab_by_address)
9095         (maintenance_print_psymbols, maintenance_info_psymtabs)
9096         (maintenance_check_psymtabs): Use ranged for.
9097         * psymtab.h (class objfile_psymtabs): New.
9098         (require_partial_symbols): Return objfile_psymtabs.
9099         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9100
9101 2019-01-09  Tom Tromey  <tom@tromey.com>
9102
9103         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9104         (find_pc_mapped_section, list_overlays_command)
9105         (map_overlay_command, unmap_overlay_command)
9106         (simple_overlay_update): Use all_objfiles.
9107         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9108         * printcmd.c (info_symbol_command): Use all_objfiles.
9109         * objfiles.h (ALL_OBJSECTIONS): Remove.
9110         * maint.c (maintenance_translate_address): Use all_objfiles.
9111         * gcore.c (gcore_create_callback): Use all_objfiles.
9112         (objfile_find_memory_regions): Likewise.
9113
9114 2019-01-09  Tom Tromey  <tom@tromey.com>
9115
9116         * symtab.c (find_line_symtab, info_sources_command)
9117         (make_source_files_completion_list): Use objfile_compunits.
9118         * source.c (select_source_symtab): Use objfile_compunits.
9119         * objfiles.h (struct objfile): Update comment.
9120         (ALL_OBJFILES): Remove.
9121         (ALL_FILETABS): Remove.
9122         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9123         objfile_compunits.
9124
9125 2019-01-09  Tom Tromey  <tom@tromey.com>
9126
9127         * symmisc.c (print_objfile_statistics, dump_objfile)
9128         (maintenance_print_symbols): Use compunit_filetabs.
9129         * source.c (forget_cached_source_info_for_objfile): Use
9130         compunit_filetabs.
9131         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9132         (ALL_FILETABS): Use compunit_filetabs.
9133         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9134         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9135
9136 2019-01-09  Tom Tromey  <tom@tromey.com>
9137
9138         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9139         (compunit_filetabs): New.
9140         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9141         compunit_filetabs.
9142         (info_sources_command, make_source_files_completion_list): Remove
9143         declaration.
9144         * symmisc.c (print_objfile_statistics, dump_objfile)
9145         (maintenance_print_symbols): Remove declaration.
9146         (maintenance_info_symtabs): Use compunit_filetabs.
9147         (maintenance_info_line_tables): Likewise.
9148         * source.c (select_source_symtab): Change local variable name.
9149         (forget_cached_source_info_for_objfile): Remove declaration.
9150         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9151         * objfiles.c (objfile_relocate1): Remove declaration.
9152         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9153         declaration.
9154         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9155         * coffread.c (coff_symtab_read): Remove declaration.
9156         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9157         compunit_filetabs.
9158
9159 2019-01-09  Tom Tromey  <tom@tromey.com>
9160
9161         * symtab.c (lookup_objfile_from_block)
9162         (find_pc_sect_compunit_symtab, search_symbols)
9163         (default_collect_symbol_completion_matches_break_on): Use
9164         objfile_compunits.
9165         * objfiles.h (ALL_COMPUNITS): Remove.
9166         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9167         * cp-support.c (add_symbol_overload_list_qualified): Use
9168         objfile_compunits.
9169         * ada-lang.c (ada_collect_symbol_completion_matches)
9170         (ada_add_global_exceptions): Use objfile_compunits.
9171
9172 2019-01-09  Tom Tromey  <tom@tromey.com>
9173
9174         * source.c (select_source_symtab)
9175         (forget_cached_source_info_for_objfile): Remove declaration.
9176         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9177         declaration.
9178         * maint.c (count_symtabs_and_blocks): Remove declaration.
9179         * cp-support.c (add_symbol_overload_list_qualified): Remove
9180         declaration.
9181         * coffread.c (coff_symtab_read): Remove declaration.
9182         * symtab.c (lookup_symbol_in_objfile_symtabs)
9183         (basic_lookup_transparent_type_1): Use objfile_compunits.
9184         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9185         (info_sources_command, search_symbols)
9186         (default_collect_symbol_completion_matches_break_on)
9187         (make_source_files_completion_list): Remove declaration.
9188         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9189         (ada_collect_symbol_completion_matches)
9190         (ada_add_global_exceptions): Remove declaration.
9191         * linespec.c (iterate_over_all_matching_symtabs): Use
9192         objfile_compunits.
9193         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9194         (class objfile_compunits): New.
9195         (ALL_COMPUNITS): Use objfile_compunits.
9196         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9197         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9198         objfile_compunits.
9199         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9200
9201 2019-01-09  Tom Tromey  <tom@tromey.com>
9202
9203         * symtab.c (search_symbols)
9204         (default_collect_symbol_completion_matches_break_on): Use
9205         objfile_msymbols.
9206         * ada-lang.c (ada_lookup_simple_minsym)
9207         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9208         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9209         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9210         objfile_msymbols.
9211         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9212         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9213         * objc-lang.c (find_methods): Use objfile_msymbols.
9214         (info_selectors_command, info_classes_command): Likewise.
9215         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9216         * objfiles.h (class objfile_msymbols): New.
9217         (ALL_OBJFILE_MSYMBOLS): Remove.
9218         (ALL_MSYMBOLS): Remove.
9219
9220 2019-01-09  Tom Tromey  <tom@tromey.com>
9221
9222         * common/next-iterator.h (next_adapter): Add Iterator template
9223         parameter.
9224         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9225         (class all_objfiles_safe): New.
9226         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9227         * objfiles.c (put_objfile_before): Update comment.
9228         (add_separate_debug_objfile): Likewise.
9229         (free_all_objfiles): Use all_objfiles_safe.
9230         (objfile_purge_solibs): Likewise.
9231
9232 2019-01-09  Tom Tromey  <tom@tromey.com>
9233
9234         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9235         (expand_symtab_containing_pc, lookup_static_symbol)
9236         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9237         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9238         all_objfiles.
9239         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9240         * breakpoint.c (create_overlay_event_breakpoint)
9241         (create_longjmp_master_breakpoint)
9242         (create_std_terminate_master_breakpoint)
9243         (create_exception_master_breakpoint): Use all_objfiles.
9244         * linux-thread-db.c (try_thread_db_load_from_pdir)
9245         (has_libpthread): Use all_objfiles.
9246         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9247         * linespec.c (iterate_over_all_matching_symtabs)
9248         (search_minsyms_for_name): Use all_objfiles.
9249         * maint.c (maintenance_info_sections): Use all_objfiles.
9250         * main.c (captured_main_1): Use all_objfiles.
9251         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9252         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9253         * guile/scm-pretty-print.c
9254         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9255         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9256         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9257         (maintenance_print_msymbols): Use all_objfiles.
9258         * source.c (select_source_symtab): Use all_objfiles.
9259         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9260         * symfile.c (remove_symbol_file_command)
9261         (expand_symtabs_matching, map_symbol_filenames): Use
9262         all_objfiles.
9263         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9264         all_objfiles.
9265         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9266         * objc-lang.c (find_methods): Use all_objfiles.
9267         * objfiles.c (have_partial_symbols, have_full_symbols)
9268         (have_minimal_symbols, qsort_cmp)
9269         (default_iterate_over_objfiles_in_search_order): Use
9270         all_objfiles.
9271         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9272         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9273         (maintenance_check_psymtabs): Use all_objfiles.
9274         (ALL_PSYMTABS): Remove.
9275         * compile/compile-object-run.c (do_module_cleanup): Use
9276         all_objfiles.
9277         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9278         * cp-support.c (add_symbol_overload_list_qualified): Use
9279         all_objfiles.
9280         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9281         Use all_objfiles.
9282         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9283         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9284         all_objfiles.
9285         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9286         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9287         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9288         Uses all_objfiles.
9289         * solib.c (solib_read_symbols): Use all_objfiles
9290
9291 2019-01-09  Tom Tromey  <tom@tromey.com>
9292
9293         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9294         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9295         all_objfiles.
9296         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9297         * symmisc.c (print_symbol_bcache_statistics)
9298         (print_objfile_statistics, maintenance_print_objfiles)
9299         (maintenance_info_symtabs, maintenance_check_symtabs)
9300         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9301         all_objfiles.
9302         * source.c (forget_cached_source_info): Use all_objfiles.
9303         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9304         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9305         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9306         * objfiles.c (update_section_map): Use all_objfiles.
9307         (shared_objfile_contains_address_p): Likewise.
9308         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9309         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9310
9311 2019-01-09  Tom Tromey  <tom@tromey.com>
9312
9313         * common/next-iterator.h: New file.
9314         * objfiles.h (class all_objfiles): New.
9315         (struct objfile_iterator): New.
9316
9317 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9318
9319         * NEWS: Move the description of the changed "frame", "select-frame",
9320          and "info frame" commands to the Changed commands section.
9321
9322 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9323
9324         * gdbtypes.c (check_stub_method_group): Remove handling of old
9325         mangling schemes.
9326         * linespec.c (find_methods): Likewise.
9327         * stabsread.c (read_member_functions): Likewise.
9328         * valops.c (search_struct_method): Likewise.
9329         (value_struct_elt_for_reference): Likewise.
9330         * NEWS: Mention this change.
9331
9332 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9333
9334         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9335         print_source_lines.
9336         * source.c (print_source_lines_base): Update line number check.
9337         (print_source_lines): New function.
9338         (source_lines_range::source_lines_range): New function.
9339         * source.h (class source_lines_range): New class.
9340         (print_source_lines): New declaration.
9341
9342 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9343
9344         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9345
9346 2019-01-08  Tom Tromey  <tom@tromey.com>
9347             Simon Marchi  <simon.marchi@ericsson.com>
9348
9349         PR gdb/24060
9350         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9351         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9352         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9353         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9354         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9355         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9356
9357 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9358
9359         * source.c (select_source_symtab): Move header comment to
9360         declaration in source.h.
9361         (forget_cached_source_info_for_objfile): Likewise.
9362         (forget_cached_source_info): Likewise.
9363         (identify_source_line): Likewise.
9364         * source.h (identify_source_line): Move declaration from symtab.h
9365         and add comment from source.c
9366         (print_source_lines): Likewise.
9367         (forget_cached_source_info_for_objfile): Likewise.
9368         (forget_cached_source_info): Likewise.
9369         (select_source_symtab): Likewise.
9370         (enum print_source_lines_flag): Move definition from symtab.h.
9371         * symtab.h (identify_source_line): Move declaration to source.h.
9372         (print_source_lines): Likewise.
9373         (forget_cached_source_info_for_objfile): Likewise.
9374         (forget_cached_source_info): Likewise.
9375         (select_source_symtab): Likewise.
9376         (enum print_source_lines_flag): Move definition to source.h.
9377         * tui/tui-hooks.c: Add 'source.h' include.
9378
9379 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9380
9381         * source.c (print_source_lines_base): Handle requests to print
9382         reverse line number sequences, and guard against empty lines
9383         string.
9384
9385 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9386
9387         * source.c (print_source_lines_base): Fix skip of '\r' if next
9388         character is '\n'.
9389
9390 2019-01-06  Tom Tromey  <tom@tromey.com>
9391
9392         * c-exp.y (struct c_parse_state) <macro_original_text,
9393         expansion_obstack>: New member.
9394         (macro_original_text, expansion_obstack): Remove globals.
9395         (scan_macro_expansion, scanning_macro_expansion)
9396         (finished_macro_expansion): Update.
9397         (scan_macro_cleanup): Remove.
9398         (yylex, c_parse): Update.
9399
9400 2019-01-06  Tom Tromey  <tom@tromey.com>
9401
9402         * c-exp.y (struct c_parse_state) <strings>: New member.
9403         (operator_stoken): Update.
9404
9405 2019-01-06  Tom Tromey  <tom@tromey.com>
9406
9407         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9408         (union type_stack_elt) <typelist_val>: Now a pointer to
9409         std::vector.
9410         (type_stack_cleanup): Don't declare.
9411         (push_typelist): Update.
9412         * parse.c (pop_typelist): Return a std::vector.
9413         (push_typelist): Take a std::vector.
9414         (follow_types): Update.  Do not free args.
9415         (type_stack_cleanup): Remove.
9416         * c-exp.y (struct c_parse_state): New.
9417         (cpstate): New global.
9418         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9419         (nonempty_typelist): Update.
9420         (func_mod): Create a new vector.
9421         (c_parse): Create a c_parse_state.
9422         (check_parameter_typelist): Do not delete params.
9423         (function_method): Update.  Do not delete type_list.
9424
9425 2019-01-06  Tom Tromey  <tom@tromey.com>
9426
9427         PR gdb/28155:
9428         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9429         check_typedef.
9430         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9431         (print_return_value): Likewise.
9432
9433 2019-01-05  Tom Tromey  <tom@tromey.com>
9434
9435         * contrib/cleanup_check.py: Remove.
9436         * contrib/gcc-with-excheck: Remove.
9437         * contrib/exsummary.py: Remove.
9438         * contrib/excheck.py: Remove.
9439
9440 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9441
9442         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9443         NULL. Initialize tpprev to NULL instead of assigning it
9444         to NULL on the next statement.
9445         * windows-nat.c (windows_delete_thread): Remove check for
9446         main_thread_id before printing thread exit notifications.
9447         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9448         Remove thread ID check against main_thread_id.
9449         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9450         windows_delete_thread.
9451         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9452
9453 2019-01-04  Tom Tromey  <tom@tromey.com>
9454
9455         * compile/compile.c (_initialize_compile): Use upper case for
9456         metasyntactic variables.
9457         * symmisc.c (_initialize_symmisc): Use upper case for
9458         metasyntactic variables.
9459         * psymtab.c (_initialize_psymtab): Use upper case for
9460         metasyntactic variables.
9461         * demangle.c (demangle_command): Use upper case for metasyntactic
9462         variables.
9463         (_initialize_demangler): Likewise.
9464         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9465         variables.
9466
9467 2019-01-03  Tom Tromey  <tom@tromey.com>
9468
9469         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9470
9471 2019-01-03  Tom Tromey  <tom@tromey.com>
9472
9473         * python/py-symtab.c (salpy_str): Update.
9474         (struct salpy_sal_object) <symtab>: Now a PyObject.
9475         (salpy_dealloc): Update.
9476         (del_objfile_sal): Use gdbpy_ref.
9477
9478 2019-01-03  Tom Tromey  <tom@tromey.com>
9479
9480         * python/py-type.c (convert_field): Use new_reference.  Return
9481         gdbpy_ref.
9482         (make_fielditem): Return gdbpy_ref.
9483         (typy_fields): Update.
9484         (typy_getitem): Update.
9485         (field_name): Return gdbpy_ref.  Use new_reference.
9486         (typy_iterator_iternext): Update.
9487
9488 2019-01-03  Tom Tromey  <tom@tromey.com>
9489
9490         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9491
9492 2019-01-03  Tom Tromey  <tom@tromey.com>
9493
9494         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9495         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9496         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9497         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9498         (pspy_set_type_printers): Likewise.
9499         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9500         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9501         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9502         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9503         (objfpy_set_type_printers): Likewise.
9504
9505 2019-01-03  Tom Tromey  <tom@tromey.com>
9506
9507         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9508         (gdbpy_print_stack): Use gdbpy_err_fetch.
9509         * python/python-internal.h (class gdbpy_err_fetch): New class.
9510         (class gdbpy_enter) <m_error_type, m_error_value,
9511         m_error_traceback>: Remove.
9512         <m_error>: New member.
9513         (gdbpy_exception_to_string): Don't declare.
9514         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9515         * python/py-value.c (convert_value_from_python): Use
9516         gdbpy_err_fetch.
9517         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9518         gdbpy_exception_to_string.
9519         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9520         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9521         gdbpy_err_fetch.
9522
9523 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9524
9525         * linux-nat.c (delete_lwp_cleanup): Delete.
9526         (struct lwp_deleter): New struct.
9527         (lwp_info_up): New typedef.
9528         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9529         lwp_info_up.
9530
9531 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9532
9533         * linux-fork.c (class scoped_switch_fork_info): New class.
9534         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9535
9536 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9537
9538         * valops.c (find_overload_match): Remove use of null_cleanup, and
9539         calls to do_cleanups.
9540
9541 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9542
9543         * compile/compile-cplus-types.c
9544         (compile_cplus_instance::decl_name): Handle changes to
9545         cp_func_name.
9546         * cp-support.c (cp_func_name): Update header comment, update
9547         return type.
9548         * cp-support.h (cp_func_name): Update return type in declaration.
9549         * valops.c (find_overload_match): Move temp_func local to top
9550         level of function and change its type.  Use temp_func to hold and
9551         delete temporary string obtained from cp_func_name.
9552
9553 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9554
9555         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9556         gdb::char_vector, remove cleanup, and update uses of `msg`.
9557
9558 2019-01-03  Jim Wilson  <jimw@sifive.com>
9559
9560         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
9561
9562 2019-01-02  Tom Tromey  <tom@tromey.com>
9563
9564         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
9565         (tdesc_parse_xml): Remove cleanups.
9566         * target-descriptions.h (make_cleanup_free_target_description):
9567         Don't declare.
9568         (target_desc_deleter): New struct.
9569         (target_desc_up): New typedef.
9570         * target-descriptions.c (target_desc_deleter::operator()): Rename
9571         from free_target_description.
9572         (make_cleanup_free_target_description): Remove.
9573
9574 2019-01-02  Tom Tromey  <tom@tromey.com>
9575
9576         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
9577         constructor, destructor.
9578         (linespec_parser): Remove typedef.
9579         (~linespec_parser): Rename from linespec_parser_delete.
9580         (linespec_lex_to_end, linespec_complete_label)
9581         (linespec_complete): Update.
9582         (decode_line_full): Remove cleanups.
9583         (decode_line_1): Update.
9584
9585 2019-01-02  Tom Tromey  <tom@tromey.com>
9586
9587         * python/python-internal.h (inferior_to_inferior_object): Change
9588         return type.
9589         * python/py-exitedevent.c (create_exited_event_object): Update.
9590         * python/py-inferior.c (inferior_to_inferior_object): Return
9591         gdbpy_ref.
9592         (python_new_inferior, python_inferior_deleted)
9593         (thread_to_thread_object, delete_thread_object)
9594         (build_inferior_list, gdbpy_selected_inferior): Update.
9595         * python/py-infthread.c (create_thread_object): Update.  Also fail
9596         if inferior_to_inferior_object fails.
9597
9598 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
9599
9600         * inferior.h (class inferior) <displaced_step_state>: New field.
9601         * infrun.h (struct displaced_step_state): Move here from
9602         infrun.c.  Initialize fields, add constructor.
9603         <inf>: Remove field.
9604         <reset>: New method.
9605         * infrun.c (struct displaced_step_inferior_state): Move to
9606         infrun.h.
9607         (displaced_step_inferior_states): Remove.
9608         (get_displaced_stepping_state): Adust.
9609         (displaced_step_in_progress_any_inferior): Adjust.
9610         (displaced_step_in_progress_thread): Adjust.
9611         (displaced_step_in_progress): Adjust.
9612         (add_displaced_stepping_state): Remove.
9613         (get_displaced_step_closure_by_addr): Adjust.
9614         (remove_displaced_stepping_state): Remove.
9615         (infrun_inferior_exit): Call displaced_step_state.reset.
9616         (use_displaced_stepping): Don't check for NULL.
9617         (displaced_step_prepare_throw): Call
9618         get_displaced_stepping_state.
9619         (displaced_step_fixup): Don't check for NULL.
9620         (prepare_for_detach): Don't check for NULL.
9621
9622 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9623
9624         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
9625          in case of call that did not complete.
9626
9627 2019-01-02  Andrey Utkin  <autkin@undo.io>
9628
9629         * symfile.c (find_separate_debug_file): Fix search of debug files for
9630         remote debuggee.
9631
9632 2019-01-02  Tom Tromey  <tom@tromey.com>
9633
9634         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
9635         indentation.
9636         * python/py-frame.c (frapy_older): Remove cast.
9637         (frapy_newer): Likewise.
9638         * python/py-breakpoint.c (local_setattro): Remove cast.
9639         * python/py-arch.c (archpy_name): Remove local variable.
9640         * python/py-type.c (gdbpy_lookup_type): Remove cast.
9641
9642 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
9643
9644         * unittests/basic_string_view/element_access/char/empty.cc:
9645         Fix year range in copyright header.
9646
9647 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9648
9649         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
9650         Delete.
9651         <operator==>: Update with for removed field.
9652         <hash>: Likewise.
9653         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
9654         <isa_features>: ...this.
9655         <abi_features>: New field.
9656         (riscv_isa_flen): Update comment.
9657         (riscv_abi_xlen): New declaration.
9658         (riscv_abi_flen): New declaration.
9659         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
9660         isa_features.
9661         (riscv_abi_xlen): New function.
9662         (riscv_isa_flen): Update to get answer from isa_features.
9663         (riscv_abi_flen): New function.
9664         (riscv_has_fp_abi): Update to get answer from abi_features.
9665         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
9666         xlen and flen.
9667         (riscv_call_info) <xlen, flen>: Update comment.
9668         (riscv_call_arg_struct): Remove invalid assertions
9669         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
9670         is removed.
9671         (riscv_gdbarch_init): Gather isa features and abi features
9672         separately, ensure both match on the gdbarch when reusing an old
9673         gdbarch.  Relax an error check to allow 32-bit abi float to run on
9674         a target with 64-bit float hardware.
9675
9676 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9677
9678         * source.c (search_command_helper): Stop reverse search
9679         when line 1 has been searched.
9680
9681 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9682
9683         * record-full.c (record_full_base_target::close): Rewrite
9684         record_full_core_buf_list free logic.
9685
9686 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9687
9688         * break-catch-syscall.c (print_one_catch_syscall): xfree
9689         the last text.
9690
9691 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9692
9693         * top.c (print_gdb_version): Update Copyright year in version
9694         message.
9695
9696 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9697
9698         Update copyright year range in all GDB files.
9699
9700 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
9701
9702         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
9703
9704 For older changes see ChangeLog-2018.
9705 \f
9706 Local Variables:
9707 mode: change-log
9708 left-margin: 8
9709 fill-column: 74
9710 version-control: never
9711 coding: utf-8
9712 End:
9713