gdb/ChangeLog

   1 2019-01-23  Pedro Alves  <palves@redhat.com>
   2             Andrew Burgess  <andrew.burgess@embecosm.com>
   3             Tom Tromey  <tom@tromey.com>
   4
   5         * common/scope-exit.h: New file.
   6
   7 2019-01-23  Pedro Alves  <palves@redhat.com>
   8
   9         * common/preprocessor.h (ESC): Rename to ...
  10         (ESC_PARENS): ... this.
  11         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
  12         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
  13
  14 2019-01-23  Tom Tromey  <tom@tromey.com>
  15
  16         * language.h (class scoped_switch_to_sym_language_if_auto):
  17         Initialize m_lang in both cases.
  18
  19 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
  20
  21         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
  22         with XCNEW.
  23
  24 2019-01-22  Tom Tromey  <tom@tromey.com>
  25
  26         * corelow.c: Do not include sys/file.h.
  27
  28 2019-01-22  Tom Tromey  <tom@tromey.com>
  29
  30         * tui/tui-wingeneral.h: Include gdb_curses.h.
  31
  32 2019-01-22  Tom Tromey  <tom@tromey.com>
  33
  34         * source-cache.h (class source_cache) <get_source_lines,
  35         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
  36
  37 2019-01-22  Tom Tromey  <tom@tromey.com>
  38
  39         * remote-fileio.h (struct remote_target): Declare.
  40
  41 2019-01-22  Tom Tromey  <tom@tromey.com>
  42
  43         * python/py-arch.c: Do not include py-ref.h.
  44         * python/py-bpevent.c: Do not include py-ref.h.
  45         * python/py-cmd.c: Do not include py-ref.h.
  46         * python/py-continueevent.c: Do not include py-ref.h.
  47         * python/py-event.h: Do not include py-ref.h.
  48         * python/py-evtregistry.c: Do not include py-ref.h.
  49         * python/py-finishbreakpoint.c: Do not include py-ref.h.
  50         * python/py-frame.c: Do not include py-ref.h.
  51         * python/py-framefilter.c: Do not include py-ref.h.
  52         * python/py-function.c: Do not include py-ref.h.
  53         * python/py-infevents.c: Do not include py-ref.h.
  54         * python/py-linetable.c: Do not include py-ref.h.
  55         * python/py-objfile.c: Do not include py-ref.h.
  56         * python/py-param.c: Do not include py-ref.h.
  57         * python/py-prettyprint.c: Do not include py-ref.h.
  58         * python/py-progspace.c: Do not include py-ref.h.
  59         * python/py-symbol.c: Do not include py-ref.h.
  60         * python/py-symtab.c: Do not include py-ref.h.
  61         * python/py-type.c: Do not include py-ref.h.
  62         * python/py-unwind.c: Do not include py-ref.h.
  63         * python/py-utils.c: Do not include py-ref.h.
  64         * python/py-value.c: Do not include py-ref.h.
  65         * python/py-varobj.c: Do not include py-ref.h.
  66         * python/py-xmethods.c: Do not include py-ref.h.
  67         * python/python.c: Do not include py-ref.h.
  68         * varobj.c: Do not include py-ref.h.
  69
  70 2019-01-22  Tom Tromey  <tom@tromey.com>
  71
  72         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
  73         keyword for bcache.
  74
  75 2019-01-22  Tom Tromey  <tom@tromey.com>
  76
  77         * compile/compile-cplus-types.c: Remove a comment by #include.
  78
  79 2019-01-22  Tom Tromey  <tom@tromey.com>
  80
  81         * compile/gcc-c-plugin.h: Include compile-internal.h.
  82
  83 2019-01-22  Tom Tromey  <tom@tromey.com>
  84
  85         * stabsread.c (EXTERN): Do not define.
  86         (symnum, next_symbol_text_func, processing_gcc_compilation)
  87         (within_function, global_sym_chain, global_stabs)
  88         (previous_stab_code, this_object_header_files)
  89         (n_this_object_header_files)
  90         (n_allocated_this_object_header_files): Define.
  91         * stabsread.h (EXTERN): Never define.  Use "extern".
  92
  93 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  94
  95         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
  96         history_value.
  97
  98 2019-01-21  Tom Tromey  <tom@tromey.com>
  99
 100         * ui-out.c: Fix includes.
 101         * tui/tui-source.c: Fix includes.
 102         * target.c: Fix includes.
 103         * remote.c: Fix includes.
 104         * regcache.c: Fix includes.
 105         * python/py-block.c: Fix includes.
 106         * printcmd.c: Fix includes.
 107         * or1k-tdep.c: Fix includes.
 108         * mi/mi-main.c: Fix includes.
 109         * m32r-tdep.c: Fix includes.
 110         * csky-tdep.c: Fix includes.
 111         * compile/compile-cplus-types.c: Fix includes.
 112         * cli/cli-interp.c: Fix includes.
 113
 114 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
 115
 116         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 117         for padding.
 118
 119 2019-01-16  Tom Tromey  <tom@tromey.com>
 120
 121         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
 122         earlier.
 123         (struct objfile) <msymbols_range>: Move from top level.
 124         <msymbols>: New method.
 125         (class objfile_msymbols): Remove.
 126         * symtab.c (default_collect_symbol_completion_matches_break_on):
 127         Update.
 128         * symmisc.c (dump_msymbols): Update.
 129         * stabsread.c (scan_file_globals): Update.
 130         * objc-lang.c (info_selectors_command, info_classes_command)
 131         (find_methods): Update.
 132         * minsyms.c (find_solib_trampoline_target): Update.
 133         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
 134         * coffread.c (coff_symfile_read): Update.
 135         * ada-lang.c (ada_lookup_simple_minsym)
 136         (ada_collect_symbol_completion_matches): Update.
 137
 138 2019-01-16  Tom Tromey  <tom@tromey.com>
 139
 140         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
 141         type.  Remove no-argument constructor.
 142         <iterator::operator++>: Simplify.
 143         <begin>: Update.
 144         <end>: Use minimal_symbol_count.
 145
 146 2019-01-16  Tom Tromey  <tom@tromey.com>
 147
 148         * objfiles.h (struct objfile) <psymtabs>: New method.
 149         (class objfile_psymtabs): Remove.
 150         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
 151         typedef.
 152         <range>: New method.
 153         (require_partial_symbols): Change return type.
 154         * psymtab.c (require_partial_symbols)
 155         (psym_expand_symtabs_matching): Update.
 156         * mdebugread.c (parse_partial_symbols): Update.
 157         * dbxread.c (dbx_end_psymtab): Update.
 158
 159 2019-01-15  Tom Tromey  <tom@tromey.com>
 160
 161         * symtab.c (lookup_objfile_from_block)
 162         (lookup_symbol_in_objfile_symtabs)
 163         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
 164         (find_line_symtab, info_sources_command)
 165         (default_collect_symbol_completion_matches_break_on)
 166         (make_source_files_completion_list): Update.
 167         * symmisc.c (print_objfile_statistics, dump_objfile)
 168         (maintenance_print_symbols, maintenance_info_symtabs)
 169         (maintenance_check_symtabs, maintenance_info_line_tables):
 170         Update.
 171         * source.c (select_source_symtab)
 172         (forget_cached_source_info_for_objfile): Update.
 173         * objfiles.h (class objfile_compunits): Remove.
 174         (struct objfile) <compunits_range>: New typedef.
 175         (compunits): New method.
 176         * objfiles.c (objfile_relocate1): Update.
 177         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 178         * maint.c (count_symtabs_and_blocks): Update.
 179         * linespec.c (iterate_over_all_matching_symtabs): Update.
 180         * cp-support.c (add_symbol_overload_list_qualified): Update.
 181         * coffread.c (coff_symtab_read): Update.
 182         * ada-lang.c (add_nonlocal_symbols)
 183         (ada_collect_symbol_completion_matches)
 184         (ada_add_global_exceptions): Update.
 185
 186 2019-01-15  Tom Tromey  <tom@tromey.com>
 187
 188         * progspace.h (program_space) <objfiles_safe_range>: New
 189         typedef.
 190         <objfiles_safe>: New method.
 191         * objfiles.h (class all_objfiles_safe): Remove.
 192         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
 193         * jit.c (jit_inferior_exit_hook): Update.
 194
 195 2019-01-17  Tom Tromey  <tom@tromey.com>
 196
 197         * progspace.h (program_space) <objfiles_range>: New typedef.
 198         <objfiles>: New method.
 199         <objfiles_head>: Rename from objfiles.
 200         (object_files): Update.
 201         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
 202         * guile/scm-pretty-print.c
 203         (ppscm_find_pretty_printer_from_objfiles): Update.
 204         * guile/scm-objfile.c (gdbscm_objfiles): Update.
 205         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
 206         Update.
 207         * python/py-progspace.c (pspy_get_objfiles): Update.
 208         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 209         Update.
 210         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 211         (objfpy_lookup_objfile_by_build_id): Update.
 212         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 213         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 214         Update.
 215         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 216         (expand_symtab_containing_pc, lookup_objfile_from_block)
 217         (lookup_static_symbol, basic_lookup_transparent_type)
 218         (find_pc_sect_compunit_symtab, find_symbol_at_address)
 219         (find_line_symtab, info_sources_command)
 220         (default_collect_symbol_completion_matches_break_on)
 221         (make_source_files_completion_list, find_main_name): Update.
 222         * symmisc.c (print_symbol_bcache_statistics)
 223         (print_objfile_statistics, maintenance_print_symbols)
 224         (maintenance_print_msymbols, maintenance_print_objfiles)
 225         (maintenance_info_symtabs, maintenance_check_symtabs)
 226         (maintenance_expand_symtabs, maintenance_info_line_tables):
 227         Update.
 228         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
 229         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
 230         (map_overlay_command, unmap_overlay_command)
 231         (simple_overlay_update, expand_symtabs_matching)
 232         (map_symbol_filenames): Update.
 233         * symfile-debug.c (set_debug_symfile): Update.
 234         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
 235         Update.
 236         * source.c (select_source_symtab, forget_cached_source_info):
 237         Update.
 238         * solib.c (solib_read_symbols): Update.
 239         * solib-spu.c (append_ocl_sos): Update.
 240         * psymtab.c (maintenance_print_psymbols)
 241         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
 242         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
 243         * printcmd.c (info_symbol_command): Update.
 244         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
 245         Update.
 246         * objfiles.h (class all_objfiles): Remove.
 247         * objfiles.c (have_partial_symbols, have_full_symbols)
 248         (have_minimal_symbols, qsort_cmp, update_section_map)
 249         (shared_objfile_contains_address_p)
 250         (default_iterate_over_objfiles_in_search_order): Update.
 251         * objc-lang.c (info_selectors_command, info_classes_command)
 252         (find_methods): Update.
 253         * minsyms.c (find_solib_trampoline_target): Update.
 254         * maint.c (maintenance_info_sections)
 255         (maintenance_translate_address, count_symtabs_and_blocks):
 256         Update.
 257         * main.c (captured_main_1): Update.
 258         * linux-thread-db.c (try_thread_db_load_from_pdir)
 259         (has_libpthread): Update.
 260         * linespec.c (iterate_over_all_matching_symtabs)
 261         (search_minsyms_for_name): Update.
 262         * jit.c (jit_find_objf_with_entry_addr): Update.
 263         * hppa-tdep.c (find_unwind_entry)
 264         (hppa_lookup_stub_minimal_symbol): Update.
 265         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
 266         Update.
 267         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 268         (elf_gnu_ifunc_resolve_by_got): Update.
 269         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
 270         * dwarf-index-write.c (save_gdb_index_command): Update.
 271         * cp-support.c (add_symbol_overload_list_qualified): Update.
 272         * breakpoint.c (create_overlay_event_breakpoint)
 273         (create_longjmp_master_breakpoint)
 274         (create_std_terminate_master_breakpoint)
 275         (create_exception_master_breakpoint): Update.
 276         * blockframe.c (find_pc_partial_function): Update.
 277         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
 278         (ada_collect_symbol_completion_matches)
 279         (ada_add_global_exceptions): Update.
 280
 281 2019-01-17  Tom Tromey  <tom@tromey.com>
 282
 283         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
 284         declare VEC.
 285         (solib_target_parse_libraries): Change return type.
 286         (library_list_start_segment, library_list_start_section)
 287         (library_list_end_library, library_list_start_library); Update.
 288         (solib_target_free_library_list): Remove.
 289         (solib_target_parse_libraries): Remove cleanup.  Change return
 290         type.
 291         (solib_target_current_sos): Update.
 292
 293 2019-01-17  Tom Tromey  <tromey@bapiya>
 294
 295         * valprint.c: Replace "the the" with "the".
 296         * symtab.c: Replace "the the" with "the".
 297         * solib.c: Replace "the the" with "the".
 298         * solib-dsbt.c: Replace "the the" with "the".
 299         * linespec.c: Replace "the the" with "the".
 300         * dwarf2loc.h: Replace "the the" with "the".
 301         * amd64-windows-tdep.c: Replace "the the" with "the".
 302         * aarch64-tdep.c: Replace "the the" with "the".
 303
 304 2019-01-16  Keith Seitz  <keiths@redhat.com>
 305
 306         PR gdb/23773
 307         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
 308         <builder>: Rename to ..
 309         <m_builder>: ... this and make private.
 310         (dwarf2_cu::get_builder): New method.  Change all users of
 311         `builder' to use this method.
 312         (dwarf2_start_symtab): Move to ...
 313         (dwarf2_cu::start_symtab): ... here.  Update all callers
 314         (setup_type_unit_groups): Move to ...
 315         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
 316         callers.
 317         (dwarf2_cu::reset_builder): New method.
 318         (process_full_compunit, process_full_type_unit): Use
 319         dwarf2_cu::reset_builder.
 320         (follow_die_offset): Record the ancestor CU if it is different
 321         from the followed DIE's CU.
 322         (follow_die_sig_1): Likewise.
 323
 324 2019-01-15  Tom Tromey  <tom@tromey.com>
 325
 326         * remote.c (class remote_state) <buf>: Now a char_vector.
 327         <buf_size>: Remove.
 328         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
 329         parameter.
 330         (remote_target::getpkt_or_notif_sane_1)
 331         (remote_target::getpkt_sane)
 332         (remote_target::getpkt_or_notif_sane): Likewise.
 333         (class remote_target) <putpkt>: New overload.
 334         (remote_target::read_frame): Change type of "buf_p".  Remove
 335         sizeof_p parameter.
 336         (packet_ok): New overload.
 337         (packet_check_result): New overload.
 338         Update all uses.
 339
 340 2019-01-14  Tom Tromey  <tom@tromey.com>
 341
 342         * remote-notif.c (handle_notification, remote_notif_ack)
 343         (remote_notif_parse): Make "buf" const.
 344         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
 345         const.
 346         (remote_notif_parse, remote_notif_ack, handle_notification):
 347         Likewise.
 348         * remote.c (remote_notif_stop_parse): Make "buf" const.
 349         (remote_target::remote_parse_stop_reply): Make "buf" const.
 350         (remote_notif_stop_ack): Make "buf" const.
 351
 352 2019-01-14  Tom Tromey  <tom@tromey.com>
 353
 354         * remote.c (remote_console_output): Make parameter const.
 355
 356 2019-01-14  Tom Tromey  <tom@tromey.com>
 357
 358         * target-debug.h (target_debug_print_signals): Constify.
 359         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
 360         * procfs.c (procfs_target::pass_signals): Update.
 361         * linux-nat.c (linux_nat_target::pass_signals): Update.
 362         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
 363         * target-delegates.c: Rebuild.
 364         * remote.c (remote_target::program_signals): Update.
 365         (remote_target::pass_signals): Update.
 366         * target.c (target_pass_signals): Constify argument.
 367         (target_program_signals): Likewise.
 368         * target.h (struct target_ops) <pass_signals, program_signals>:
 369         Constify argument.
 370         (target_pass_signals, target_program_signals): Constify argument.
 371
 372 2019-01-14  Tom Tromey  <tom@tromey.com>
 373
 374         PR tui/28819:
 375         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
 376
 377 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 378
 379         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
 380         field.
 381         * rs6000-tdep.c: Include reggroups.h.
 382         (IS_V_ALIAS_PSEUDOREG): Define.
 383         (rs6000_register_name): Return names for the "vX" aliases.
 384         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
 385         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
 386         aliases.  Call default_register_reggroup_p for all other
 387         pseudo-registers.
 388         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
 389         New functions.
 390         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
 391         Handle "vX" aliases.
 392         (v_alias_pseudo_register_collect): New function.
 393         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
 394         (rs6000_gdbarch_init): Initialize "vX" aliases as
 395         pseudo-registers.  Restore registration of
 396         rs6000_pseudo_register_reggroup_p with
 397         set_tdesc_pseudo_register_reggroup_p.
 398
 399 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
 400
 401         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
 402         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
 403         set_gdbarch_num_pseudo_regs.
 404
 405 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 406
 407         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
 408         Remove arg prefixname, add do_set and do_show.
 409         Add member functions set_list and show_list.
 410         * cli/cli-style.c (class cli_style_option): Update accordingly.
 411         (style_set_list): Move to file scope.
 412         (style_show_list): Likewise.
 413         (set_style): Call help_list.
 414         (show_style): Call cmd_show_list.
 415         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
 416         Update to use the new macro.
 417
 418 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
 419
 420         * ada-lang.c (_initialize_ada_language): Expand the help text
 421         for the "catch exception" command.
 422
 423 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 424
 425         * symtab.c (matching_obj_sections): Initialize obj,
 426         declare it closer to its usage.
 427
 428 2019-01-10  Tom Tromey  <tom@tromey.com>
 429
 430         * thread-iter.h (inf_threads_iterator): Use next_iterator.
 431         (basic_inf_threads_range): Remove.
 432         (inf_threads_range, inf_non_exited_threads_range)
 433         (safe_inf_threads_range): Use next_adapter.
 434
 435 2019-01-10  Keith Seitz  <keiths@redhat.com>
 436
 437         PR gdb/23712
 438         PR symtab/23010
 439         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
 440         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
 441
 442 2019-01-10  Keith Seitz  <keiths@redhat.com>
 443
 444         PR gdb/23712
 445         PR symtab/23010
 446         * dictionary.c (pending_to_vector): Remove.
 447         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 448         Remove _1 suffix, replacing functions of the same name.  Update
 449         all callers.
 450         (dict_create_hashed, dict_create_hashed_expandable)
 451         (dict_create_linear, dict_create_linear_expandable, dict_free)
 452         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
 453         Make functions static.
 454
 455 2019-01-10  Keith Seitz  <keiths@redhat.com>
 456
 457         PR gdb/23712
 458         PR symtab/23010
 459         * dictionary.h (struct dictionary): Replace declaration with
 460         multidictionary.
 461         (dict_create_hashed, dict_create_hashed_expandable)
 462         (dict_create_linear, dict_create_linear_expandable)
 463         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
 464         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
 465         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
 466         taking multidictionary argument.
 467         [ALL_DICT_SYMBOLS]: Update for multidictionary.
 468         * block.h (struct block) <dict>: Change to multidictionary
 469         and rename `multidict'.
 470         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
 471         symmisc.c: Update all dictionary references to multidictionary.
 472
 473 2019-01-10  Keith Seitz  <keiths@redhat.com>
 474
 475         PR gdb/23712
 476         PR symtab/23010
 477         * dictionary.c: Include unordered_map.
 478         (pending_to_vector): New function.
 479         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 480         Rewrite the non-"_1" functions to take vector instead
 481         of linked list.
 482         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
 483         "new" _1 versions of the same name.
 484         (multidictionary): Define.
 485         (std::hash<enum language): New definition.
 486         (collate_pending_symbols_by_language, mdict_create_hashed)
 487         (mdict_create_hashed_expandable, mdict_create_linear)
 488         (mdict_create_linear_expandable, mdict_free)
 489         (find_language_dictionary, create_new_language_dictionary)
 490         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
 491         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
 492         (mdict_size, mdict_empty): New functions.
 493         * dictionary.h (mdict_iterator): Define.
 494
 495 2019-01-10  Pedro Alves  <palves@redhat.com>
 496
 497         * breakpoint.c (read_uploaded_action)
 498         (create_tracepoint_from_upload): Adjust to use
 499         gdb::unique_xmalloc_ptr.
 500         * ctf.c (ctf_write_uploaded_tp):
 501         (SET_ARRAY_FIELD): Use emplace_back.
 502         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
 503         * tracefile-tfile.c (tfile_write_uploaded_tp):
 504         * tracepoint.c (parse_tracepoint_definition): Adjust to use
 505         gdb::unique_xmalloc_ptr.
 506         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
 507         at_string, cond_string, cmd_strings>: Replace char pointers
 508         with gdb::unique_xmalloc_ptr.
 509
 510 2019-01-10  Pedro Alves  <palves@redhat.com>
 511
 512         * solib-target.c (library_list_start_library): Don't xstrdup name.
 513
 514 2019-01-10  Pedro Alves  <palves@redhat.com>
 515
 516         * mdebugread.c (parse_partial_symbols): Use
 517         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
 518
 519 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 520
 521         * linux-fork.c (scoped_switch_fork_info)
 522         <~scoped_switch_fork_info>: Fix incorrect variable name.
 523
 524 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 525
 526         * linux-fork.c (scoped_switch_fork_info)
 527         <scoped_switch_fork_info>: Make explicit.
 528         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
 529
 530 2019-01-10  Tom Tromey  <tom@tromey.com>
 531
 532         * objfiles.h (objfile::reset_psymtabs): Update.
 533         * objfiles.c (objfile::objfile): Update.
 534         * psymtab.h (psymtab_storage::obstack): Update.
 535         (psymtab_storage::m_obstack): Use gdb::optional.
 536         (class psymtab_storage): Update comment.  Remove objfile
 537         parameter.
 538         * psymtab.c (psymtab_storage::psymtab_storage): Update.
 539
 540 2019-01-10  Tom Tromey  <tom@tromey.com>
 541
 542         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
 543         <free_psymtabs>: Now private.
 544         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
 545         (allocate_psymtab): Use new method.
 546
 547 2019-01-10  Tom Tromey  <tom@tromey.com>
 548
 549         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
 550         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
 551         * mdebugread.c (parse_partial_symbols): Use
 552         allocate_dependencies.
 553         * dwarf2read.c (dwarf2_create_include_psymtab): Use
 554         allocate_dependencies.
 555         (process_psymtab_comp_unit_reader)
 556         (build_type_psymtab_dependencies): Likewise.
 557         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
 558
 559 2019-01-10  Tom Tromey  <tom@tromey.com>
 560
 561         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
 562         PSYMBOL_SET_LANGUAGE.
 563         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
 564
 565 2019-01-10  Tom Tromey  <tom@tromey.com>
 566
 567         * psymtab.h (psymtab_storage::obstack): New method.
 568         <m_obstack>: Rename from obstack; now private.
 569         * psymtab.c (psymtab_storage): Update.
 570         * dwarf2read.c (create_addrmap_from_index)
 571         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
 572         Update.
 573
 574 2019-01-10  Tom Tromey  <tom@tromey.com>
 575
 576         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
 577         * objfiles.h (objfile::reset_psymtabs): New method.
 578
 579 2019-01-10  Tom Tromey  <tom@tromey.com>
 580
 581         * symmisc.c (print_symbol_bcache_statistics): Update.
 582         (print_objfile_statistics): Update.
 583         * symfile.c (reread_symbols): Update.
 584         * psymtab.h (class psymtab_storage): New.
 585         * psymtab.c (psymtab_storage): New constructor.
 586         (~psymtab_storage): New destructor.
 587         (require_partial_symbols): Update.
 588         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
 589         (find_pc_sect_psymtab, find_pc_sect_psymbol)
 590         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
 591         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
 592         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
 593         (start_psymtab_common, end_psymtab_common)
 594         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
 595         (allocate_psymtab): Update.
 596         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
 597         Update.
 598         (dump_psymtab_addrmap, maintenance_print_psymbols)
 599         (maintenance_check_psymtabs): Update.
 600         (class objfile_psymtabs): Move to objfiles.h.
 601         * psympriv.h (discard_psymtab): Now inline.
 602         (psymtab_discarder::psymtab_discarder): Update.
 603         (psymtab_discarder::~psymtab_discarder): Update.
 604         (ALL_OBJFILE_PSYMTABS): Rewrite.
 605         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
 606         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
 607         Remove fields.
 608         <partial_symtabs>: New field.
 609         (class objfile_psymtabs): Move from psymtab.h.  Update.
 610         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
 611         psymbol_cache.
 612         (objfile::~objfile): Don't destroy psymbol_cache.
 613         * mdebugread.c (parse_partial_symbols): Update.
 614         * dwarf2read.c (create_addrmap_from_index)
 615         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
 616         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
 617         (add_partial_subprogram, dwarf2_ranges_read): Update.
 618         * dwarf-index-write.c (write_address_map)
 619         (write_one_signatured_type, recursively_write_psymbols)
 620         (class debug_names, class debug_names, write_psymtabs_to_index):
 621         Update.
 622
 623 2019-01-10  Tom Tromey  <tom@tromey.com>
 624
 625         * symtab.h (SYMBOL_SET_NAMES): Update.
 626         (symbol_set_names): Update.
 627         (MSYMBOL_SET_NAMES): Update.
 628         * symtab.c (symbol_set_names): Change argument to be an
 629         objfile_per_bfd_storage.
 630         * psymtab.c (add_psymbol_to_bcache): Update.
 631         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
 632
 633 2019-01-10  Tom Tromey  <tom@tromey.com>
 634
 635         * symtab.c (create_demangled_names_hash): Change argument to be an
 636         objfile_per_bfd_storage.
 637         (symbol_set_names): Update.
 638
 639 2019-01-10  Tom Tromey  <tom@tromey.com>
 640
 641         * xcoffread.c (xcoff_initial_scan): Unconditionally call
 642         init_psymbol_list.
 643         * psymtab.c (init_psymbol_list): Do nothing if already called.
 644         * psympriv.h (init_psymbol_list): Add comment.
 645         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
 646         init_psymbol_list.
 647         * dbxread.c (dbx_symfile_read): Unconditionally call
 648         init_psymbol_list.
 649
 650 2019-01-10  Tom Tromey  <tom@tromey.com>
 651
 652         * xcoffread.c (scan_xcoff_symtab): Update.
 653         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
 654         "where".
 655         * mdebugread.c (parse_partial_symbols)
 656         (handle_psymbol_enumerators): Update.
 657         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
 658         * dbxread.c (read_dbx_symtab): Update.
 659         * psympriv.h (psymbol_placement): New enum.
 660         (add_psymbol_to_list): Update.
 661
 662 2019-01-10  Tom Tromey  <tom@tromey.com>
 663
 664         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
 665         static_psymbols parameters.
 666         (scan_xcoff_symtab): Update.
 667         * psymtab.c (start_psymtab_common): Remove global_psymbols and
 668         static_psymbols parameters.
 669         * psympriv.h (start_psymtab_common): Update.
 670         * mdebugread.c (parse_partial_symbols): Update.
 671         * dwarf2read.c (create_partial_symtab): Update.
 672         * dbxread.c (read_dbx_symtab): Update.
 673         (start_psymtab): Remove global_psymbols and static_psymbols
 674         parameters.
 675
 676 2019-01-10  Tom Tromey  <tom@tromey.com>
 677
 678         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
 679         * psymtab.c (allocate_psymtab): Add comment.
 680         * psympriv.h (allocate_psymtab): Add comment.
 681         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
 682         initializations.
 683         * dbxread.c (dbx_end_psymtab): Remove some initializations.
 684
 685 2019-01-10  Tom Tromey  <tom@tromey.com>
 686
 687         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 688         Don't declare.
 689         * mipsread.c: Include mdebugread.h.
 690         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 691         Declare.
 692         * elfread.c: Include mdebugread.h.
 693
 694 2019-01-09  Tom Tromey  <tom@tromey.com>
 695
 696         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
 697         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
 698         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
 699         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
 700         (psym_lookup_symbol, psym_find_last_source_symtab)
 701         (psym_forget_cached_source_info, psym_print_stats)
 702         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
 703         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
 704         (psym_map_matching_symbols, psym_expand_symtabs_matching)
 705         (psym_find_compunit_symtab_by_address)
 706         (maintenance_print_psymbols, maintenance_info_psymtabs)
 707         (maintenance_check_psymtabs): Use ranged for.
 708         * psymtab.h (class objfile_psymtabs): New.
 709         (require_partial_symbols): Return objfile_psymtabs.
 710         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
 711
 712 2019-01-09  Tom Tromey  <tom@tromey.com>
 713
 714         * symfile.c (overlay_invalidate_all, find_pc_overlay)
 715         (find_pc_mapped_section, list_overlays_command)
 716         (map_overlay_command, unmap_overlay_command)
 717         (simple_overlay_update): Use all_objfiles.
 718         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
 719         * printcmd.c (info_symbol_command): Use all_objfiles.
 720         * objfiles.h (ALL_OBJSECTIONS): Remove.
 721         * maint.c (maintenance_translate_address): Use all_objfiles.
 722         * gcore.c (gcore_create_callback): Use all_objfiles.
 723         (objfile_find_memory_regions): Likewise.
 724
 725 2019-01-09  Tom Tromey  <tom@tromey.com>
 726
 727         * symtab.c (find_line_symtab, info_sources_command)
 728         (make_source_files_completion_list): Use objfile_compunits.
 729         * source.c (select_source_symtab): Use objfile_compunits.
 730         * objfiles.h (struct objfile): Update comment.
 731         (ALL_OBJFILES): Remove.
 732         (ALL_FILETABS): Remove.
 733         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
 734         objfile_compunits.
 735
 736 2019-01-09  Tom Tromey  <tom@tromey.com>
 737
 738         * symmisc.c (print_objfile_statistics, dump_objfile)
 739         (maintenance_print_symbols): Use compunit_filetabs.
 740         * source.c (forget_cached_source_info_for_objfile): Use
 741         compunit_filetabs.
 742         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
 743         (ALL_FILETABS): Use compunit_filetabs.
 744         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
 745         * coffread.c (coff_symtab_read): Use compunit_filetabs.
 746
 747 2019-01-09  Tom Tromey  <tom@tromey.com>
 748
 749         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
 750         (compunit_filetabs): New.
 751         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
 752         compunit_filetabs.
 753         (info_sources_command, make_source_files_completion_list): Remove
 754         declaration.
 755         * symmisc.c (print_objfile_statistics, dump_objfile)
 756         (maintenance_print_symbols): Remove declaration.
 757         (maintenance_info_symtabs): Use compunit_filetabs.
 758         (maintenance_info_line_tables): Likewise.
 759         * source.c (select_source_symtab): Change local variable name.
 760         (forget_cached_source_info_for_objfile): Remove declaration.
 761         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
 762         * objfiles.c (objfile_relocate1): Remove declaration.
 763         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 764         declaration.
 765         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
 766         * coffread.c (coff_symtab_read): Remove declaration.
 767         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 768         compunit_filetabs.
 769
 770 2019-01-09  Tom Tromey  <tom@tromey.com>
 771
 772         * symtab.c (lookup_objfile_from_block)
 773         (find_pc_sect_compunit_symtab, search_symbols)
 774         (default_collect_symbol_completion_matches_break_on): Use
 775         objfile_compunits.
 776         * objfiles.h (ALL_COMPUNITS): Remove.
 777         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
 778         * cp-support.c (add_symbol_overload_list_qualified): Use
 779         objfile_compunits.
 780         * ada-lang.c (ada_collect_symbol_completion_matches)
 781         (ada_add_global_exceptions): Use objfile_compunits.
 782
 783 2019-01-09  Tom Tromey  <tom@tromey.com>
 784
 785         * source.c (select_source_symtab)
 786         (forget_cached_source_info_for_objfile): Remove declaration.
 787         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 788         declaration.
 789         * maint.c (count_symtabs_and_blocks): Remove declaration.
 790         * cp-support.c (add_symbol_overload_list_qualified): Remove
 791         declaration.
 792         * coffread.c (coff_symtab_read): Remove declaration.
 793         * symtab.c (lookup_symbol_in_objfile_symtabs)
 794         (basic_lookup_transparent_type_1): Use objfile_compunits.
 795         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
 796         (info_sources_command, search_symbols)
 797         (default_collect_symbol_completion_matches_break_on)
 798         (make_source_files_completion_list): Remove declaration.
 799         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
 800         (ada_collect_symbol_completion_matches)
 801         (ada_add_global_exceptions): Remove declaration.
 802         * linespec.c (iterate_over_all_matching_symtabs): Use
 803         objfile_compunits.
 804         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
 805         (class objfile_compunits): New.
 806         (ALL_COMPUNITS): Use objfile_compunits.
 807         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
 808         (maintenance_check_symtabs, maintenance_info_line_tables): Use
 809         objfile_compunits.
 810         * objfiles.c (objfile_relocate1): Use objfile_compunits.
 811
 812 2019-01-09  Tom Tromey  <tom@tromey.com>
 813
 814         * symtab.c (search_symbols)
 815         (default_collect_symbol_completion_matches_break_on): Use
 816         objfile_msymbols.
 817         * ada-lang.c (ada_lookup_simple_minsym)
 818         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
 819         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
 820         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
 821         objfile_msymbols.
 822         * coffread.c (coff_symfile_read): Use objfile_msymbols.
 823         * symmisc.c (dump_msymbols): Use objfile_msymbols.
 824         * objc-lang.c (find_methods): Use objfile_msymbols.
 825         (info_selectors_command, info_classes_command): Likewise.
 826         * stabsread.c (scan_file_globals): Use objfile_msymbols.
 827         * objfiles.h (class objfile_msymbols): New.
 828         (ALL_OBJFILE_MSYMBOLS): Remove.
 829         (ALL_MSYMBOLS): Remove.
 830
 831 2019-01-09  Tom Tromey  <tom@tromey.com>
 832
 833         * common/next-iterator.h (next_adapter): Add Iterator template
 834         parameter.
 835         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
 836         (class all_objfiles_safe): New.
 837         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
 838         * objfiles.c (put_objfile_before): Update comment.
 839         (add_separate_debug_objfile): Likewise.
 840         (free_all_objfiles): Use all_objfiles_safe.
 841         (objfile_purge_solibs): Likewise.
 842
 843 2019-01-09  Tom Tromey  <tom@tromey.com>
 844
 845         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 846         (expand_symtab_containing_pc, lookup_static_symbol)
 847         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
 848         (find_symbol_at_address, find_line_symtab, find_main_name): Use
 849         all_objfiles.
 850         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
 851         * breakpoint.c (create_overlay_event_breakpoint)
 852         (create_longjmp_master_breakpoint)
 853         (create_std_terminate_master_breakpoint)
 854         (create_exception_master_breakpoint): Use all_objfiles.
 855         * linux-thread-db.c (try_thread_db_load_from_pdir)
 856         (has_libpthread): Use all_objfiles.
 857         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
 858         * linespec.c (iterate_over_all_matching_symtabs)
 859         (search_minsyms_for_name): Use all_objfiles.
 860         * maint.c (maintenance_info_sections): Use all_objfiles.
 861         * main.c (captured_main_1): Use all_objfiles.
 862         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
 863         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
 864         * guile/scm-pretty-print.c
 865         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
 866         * solib-spu.c (append_ocl_sos): Use all_objfiles.
 867         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
 868         (maintenance_print_msymbols): Use all_objfiles.
 869         * source.c (select_source_symtab): Use all_objfiles.
 870         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
 871         * symfile.c (remove_symbol_file_command)
 872         (expand_symtabs_matching, map_symbol_filenames): Use
 873         all_objfiles.
 874         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
 875         all_objfiles.
 876         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
 877         * objc-lang.c (find_methods): Use all_objfiles.
 878         * objfiles.c (have_partial_symbols, have_full_symbols)
 879         (have_minimal_symbols, qsort_cmp)
 880         (default_iterate_over_objfiles_in_search_order): Use
 881         all_objfiles.
 882         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
 883         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
 884         (maintenance_check_psymtabs): Use all_objfiles.
 885         (ALL_PSYMTABS): Remove.
 886         * compile/compile-object-run.c (do_module_cleanup): Use
 887         all_objfiles.
 888         * blockframe.c (find_pc_partial_function): Use all_objfiles.
 889         * cp-support.c (add_symbol_overload_list_qualified): Use
 890         all_objfiles.
 891         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 892         Use all_objfiles.
 893         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
 894         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
 895         all_objfiles.
 896         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 897         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
 898         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 899         Uses all_objfiles.
 900         * solib.c (solib_read_symbols): Use all_objfiles
 901
 902 2019-01-09  Tom Tromey  <tom@tromey.com>
 903
 904         * probe.c (parse_probes_in_pspace): Use all_objfiles.
 905         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
 906         all_objfiles.
 907         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
 908         * symmisc.c (print_symbol_bcache_statistics)
 909         (print_objfile_statistics, maintenance_print_objfiles)
 910         (maintenance_info_symtabs, maintenance_check_symtabs)
 911         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
 912         all_objfiles.
 913         * source.c (forget_cached_source_info): Use all_objfiles.
 914         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
 915         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 916         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
 917         * objfiles.c (update_section_map): Use all_objfiles.
 918         (shared_objfile_contains_address_p): Likewise.
 919         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
 920         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
 921
 922 2019-01-09  Tom Tromey  <tom@tromey.com>
 923
 924         * common/next-iterator.h: New file.
 925         * objfiles.h (class all_objfiles): New.
 926         (struct objfile_iterator): New.
 927
 928 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 929
 930         * NEWS: Move the description of the changed "frame", "select-frame",
 931          and "info frame" commands to the Changed commands section.
 932
 933 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
 934
 935         * gdbtypes.c (check_stub_method_group): Remove handling of old
 936         mangling schemes.
 937         * linespec.c (find_methods): Likewise.
 938         * stabsread.c (read_member_functions): Likewise.
 939         * valops.c (search_struct_method): Likewise.
 940         (value_struct_elt_for_reference): Likewise.
 941         * NEWS: Mention this change.
 942
 943 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 944
 945         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
 946         print_source_lines.
 947         * source.c (print_source_lines_base): Update line number check.
 948         (print_source_lines): New function.
 949         (source_lines_range::source_lines_range): New function.
 950         * source.h (class source_lines_range): New class.
 951         (print_source_lines): New declaration.
 952
 953 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 954
 955         * linespec.c (linespec_state_destructor): Free self->canonical_names.
 956
 957 2019-01-08  Tom Tromey  <tom@tromey.com>
 958             Simon Marchi  <simon.marchi@ericsson.com>
 959
 960         PR gdb/24060
 961         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
 962         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
 963         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
 964         * f-exp.y (DOLLAR_VARIABLE): Likewise.
 965         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
 966         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
 967
 968 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 969
 970         * source.c (select_source_symtab): Move header comment to
 971         declaration in source.h.
 972         (forget_cached_source_info_for_objfile): Likewise.
 973         (forget_cached_source_info): Likewise.
 974         (identify_source_line): Likewise.
 975         * source.h (identify_source_line): Move declaration from symtab.h
 976         and add comment from source.c
 977         (print_source_lines): Likewise.
 978         (forget_cached_source_info_for_objfile): Likewise.
 979         (forget_cached_source_info): Likewise.
 980         (select_source_symtab): Likewise.
 981         (enum print_source_lines_flag): Move definition from symtab.h.
 982         * symtab.h (identify_source_line): Move declaration to source.h.
 983         (print_source_lines): Likewise.
 984         (forget_cached_source_info_for_objfile): Likewise.
 985         (forget_cached_source_info): Likewise.
 986         (select_source_symtab): Likewise.
 987         (enum print_source_lines_flag): Move definition to source.h.
 988         * tui/tui-hooks.c: Add 'source.h' include.
 989
 990 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 991
 992         * source.c (print_source_lines_base): Handle requests to print
 993         reverse line number sequences, and guard against empty lines
 994         string.
 995
 996 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 997
 998         * source.c (print_source_lines_base): Fix skip of '\r' if next
 999         character is '\n'.
1000
1001 2019-01-06  Tom Tromey  <tom@tromey.com>
1002
1003         * c-exp.y (struct c_parse_state) <macro_original_text,
1004         expansion_obstack>: New member.
1005         (macro_original_text, expansion_obstack): Remove globals.
1006         (scan_macro_expansion, scanning_macro_expansion)
1007         (finished_macro_expansion): Update.
1008         (scan_macro_cleanup): Remove.
1009         (yylex, c_parse): Update.
1010
1011 2019-01-06  Tom Tromey  <tom@tromey.com>
1012
1013         * c-exp.y (struct c_parse_state) <strings>: New member.
1014         (operator_stoken): Update.
1015
1016 2019-01-06  Tom Tromey  <tom@tromey.com>
1017
1018         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
1019         (union type_stack_elt) <typelist_val>: Now a pointer to
1020         std::vector.
1021         (type_stack_cleanup): Don't declare.
1022         (push_typelist): Update.
1023         * parse.c (pop_typelist): Return a std::vector.
1024         (push_typelist): Take a std::vector.
1025         (follow_types): Update.  Do not free args.
1026         (type_stack_cleanup): Remove.
1027         * c-exp.y (struct c_parse_state): New.
1028         (cpstate): New global.
1029         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
1030         (nonempty_typelist): Update.
1031         (func_mod): Create a new vector.
1032         (c_parse): Create a c_parse_state.
1033         (check_parameter_typelist): Do not delete params.
1034         (function_method): Update.  Do not delete type_list.
1035
1036 2019-01-06  Tom Tromey  <tom@tromey.com>
1037
1038         PR gdb/28155:
1039         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
1040         check_typedef.
1041         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
1042         (print_return_value): Likewise.
1043
1044 2019-01-05  Tom Tromey  <tom@tromey.com>
1045
1046         * contrib/cleanup_check.py: Remove.
1047         * contrib/gcc-with-excheck: Remove.
1048         * contrib/exsummary.py: Remove.
1049         * contrib/excheck.py: Remove.
1050
1051 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
1052
1053         * thread.c (delete_thread_1): Add gdb_assert that THR is not
1054         NULL. Initialize tpprev to NULL instead of assigning it
1055         to NULL on the next statement.
1056         * windows-nat.c (windows_delete_thread): Remove check for
1057         main_thread_id before printing thread exit notifications.
1058         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
1059         Remove thread ID check against main_thread_id.
1060         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
1061         windows_delete_thread.
1062         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
1063
1064 2019-01-04  Tom Tromey  <tom@tromey.com>
1065
1066         * compile/compile.c (_initialize_compile): Use upper case for
1067         metasyntactic variables.
1068         * symmisc.c (_initialize_symmisc): Use upper case for
1069         metasyntactic variables.
1070         * psymtab.c (_initialize_psymtab): Use upper case for
1071         metasyntactic variables.
1072         * demangle.c (demangle_command): Use upper case for metasyntactic
1073         variables.
1074         (_initialize_demangler): Likewise.
1075         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
1076         variables.
1077
1078 2019-01-03  Tom Tromey  <tom@tromey.com>
1079
1080         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
1081
1082 2019-01-03  Tom Tromey  <tom@tromey.com>
1083
1084         * python/py-symtab.c (salpy_str): Update.
1085         (struct salpy_sal_object) <symtab>: Now a PyObject.
1086         (salpy_dealloc): Update.
1087         (del_objfile_sal): Use gdbpy_ref.
1088
1089 2019-01-03  Tom Tromey  <tom@tromey.com>
1090
1091         * python/py-type.c (convert_field): Use new_reference.  Return
1092         gdbpy_ref.
1093         (make_fielditem): Return gdbpy_ref.
1094         (typy_fields): Update.
1095         (typy_getitem): Update.
1096         (field_name): Return gdbpy_ref.  Use new_reference.
1097         (typy_iterator_iternext): Update.
1098
1099 2019-01-03  Tom Tromey  <tom@tromey.com>
1100
1101         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
1102
1103 2019-01-03  Tom Tromey  <tom@tromey.com>
1104
1105         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
1106         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
1107         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
1108         (pspy_set_frame_filters, pspy_set_frame_unwinders)
1109         (pspy_set_type_printers): Likewise.
1110         * python/py-function.c (fnpy_init): Use gdbpy_ref.
1111         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
1112         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
1113         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
1114         (objfpy_set_type_printers): Likewise.
1115
1116 2019-01-03  Tom Tromey  <tom@tromey.com>
1117
1118         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
1119         (gdbpy_print_stack): Use gdbpy_err_fetch.
1120         * python/python-internal.h (class gdbpy_err_fetch): New class.
1121         (class gdbpy_enter) <m_error_type, m_error_value,
1122         m_error_traceback>: Remove.
1123         <m_error>: New member.
1124         (gdbpy_exception_to_string): Don't declare.
1125         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
1126         * python/py-value.c (convert_value_from_python): Use
1127         gdbpy_err_fetch.
1128         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
1129         gdbpy_exception_to_string.
1130         (gdbpy_handle_exception): Use gdbpy_err_fetch.
1131         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1132         gdbpy_err_fetch.
1133
1134 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1135
1136         * linux-nat.c (delete_lwp_cleanup): Delete.
1137         (struct lwp_deleter): New struct.
1138         (lwp_info_up): New typedef.
1139         (linux_nat_target::follow_fork): Delete cleanup, and make use of
1140         lwp_info_up.
1141
1142 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1143
1144         * linux-fork.c (class scoped_switch_fork_info): New class.
1145         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
1146
1147 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1148
1149         * valops.c (find_overload_match): Remove use of null_cleanup, and
1150         calls to do_cleanups.
1151
1152 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1153
1154         * compile/compile-cplus-types.c
1155         (compile_cplus_instance::decl_name): Handle changes to
1156         cp_func_name.
1157         * cp-support.c (cp_func_name): Update header comment, update
1158         return type.
1159         * cp-support.h (cp_func_name): Update return type in declaration.
1160         * valops.c (find_overload_match): Move temp_func local to top
1161         level of function and change its type.  Use temp_func to hold and
1162         delete temporary string obtained from cp_func_name.
1163
1164 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1165
1166         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
1167         gdb::char_vector, remove cleanup, and update uses of `msg`.
1168
1169 2019-01-03  Jim Wilson  <jimw@sifive.com>
1170
1171         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
1172
1173 2019-01-02  Tom Tromey  <tom@tromey.com>
1174
1175         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
1176         (tdesc_parse_xml): Remove cleanups.
1177         * target-descriptions.h (make_cleanup_free_target_description):
1178         Don't declare.
1179         (target_desc_deleter): New struct.
1180         (target_desc_up): New typedef.
1181         * target-descriptions.c (target_desc_deleter::operator()): Rename
1182         from free_target_description.
1183         (make_cleanup_free_target_description): Remove.
1184
1185 2019-01-02  Tom Tromey  <tom@tromey.com>
1186
1187         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
1188         constructor, destructor.
1189         (linespec_parser): Remove typedef.
1190         (~linespec_parser): Rename from linespec_parser_delete.
1191         (linespec_lex_to_end, linespec_complete_label)
1192         (linespec_complete): Update.
1193         (decode_line_full): Remove cleanups.
1194         (decode_line_1): Update.
1195
1196 2019-01-02  Tom Tromey  <tom@tromey.com>
1197
1198         * python/python-internal.h (inferior_to_inferior_object): Change
1199         return type.
1200         * python/py-exitedevent.c (create_exited_event_object): Update.
1201         * python/py-inferior.c (inferior_to_inferior_object): Return
1202         gdbpy_ref.
1203         (python_new_inferior, python_inferior_deleted)
1204         (thread_to_thread_object, delete_thread_object)
1205         (build_inferior_list, gdbpy_selected_inferior): Update.
1206         * python/py-infthread.c (create_thread_object): Update.  Also fail
1207         if inferior_to_inferior_object fails.
1208
1209 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
1210
1211         * inferior.h (class inferior) <displaced_step_state>: New field.
1212         * infrun.h (struct displaced_step_state): Move here from
1213         infrun.c.  Initialize fields, add constructor.
1214         <inf>: Remove field.
1215         <reset>: New method.
1216         * infrun.c (struct displaced_step_inferior_state): Move to
1217         infrun.h.
1218         (displaced_step_inferior_states): Remove.
1219         (get_displaced_stepping_state): Adust.
1220         (displaced_step_in_progress_any_inferior): Adjust.
1221         (displaced_step_in_progress_thread): Adjust.
1222         (displaced_step_in_progress): Adjust.
1223         (add_displaced_stepping_state): Remove.
1224         (get_displaced_step_closure_by_addr): Adjust.
1225         (remove_displaced_stepping_state): Remove.
1226         (infrun_inferior_exit): Call displaced_step_state.reset.
1227         (use_displaced_stepping): Don't check for NULL.
1228         (displaced_step_prepare_throw): Call
1229         get_displaced_stepping_state.
1230         (displaced_step_fixup): Don't check for NULL.
1231         (prepare_for_detach): Don't check for NULL.
1232
1233 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1234
1235         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
1236          in case of call that did not complete.
1237
1238 2019-01-02  Andrey Utkin  <autkin@undo.io>
1239
1240         * symfile.c (find_separate_debug_file): Fix search of debug files for
1241         remote debuggee.
1242
1243 2019-01-02  Tom Tromey  <tom@tromey.com>
1244
1245         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
1246         indentation.
1247         * python/py-frame.c (frapy_older): Remove cast.
1248         (frapy_newer): Likewise.
1249         * python/py-breakpoint.c (local_setattro): Remove cast.
1250         * python/py-arch.c (archpy_name): Remove local variable.
1251         * python/py-type.c (gdbpy_lookup_type): Remove cast.
1252
1253 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
1254
1255         * unittests/basic_string_view/element_access/char/empty.cc:
1256         Fix year range in copyright header.
1257
1258 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1259
1260         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
1261         Delete.
1262         <operator==>: Update with for removed field.
1263         <hash>: Likewise.
1264         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
1265         <isa_features>: ...this.
1266         <abi_features>: New field.
1267         (riscv_isa_flen): Update comment.
1268         (riscv_abi_xlen): New declaration.
1269         (riscv_abi_flen): New declaration.
1270         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
1271         isa_features.
1272         (riscv_abi_xlen): New function.
1273         (riscv_isa_flen): Update to get answer from isa_features.
1274         (riscv_abi_flen): New function.
1275         (riscv_has_fp_abi): Update to get answer from abi_features.
1276         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
1277         xlen and flen.
1278         (riscv_call_info) <xlen, flen>: Update comment.
1279         (riscv_call_arg_struct): Remove invalid assertions
1280         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
1281         is removed.
1282         (riscv_gdbarch_init): Gather isa features and abi features
1283         separately, ensure both match on the gdbarch when reusing an old
1284         gdbarch.  Relax an error check to allow 32-bit abi float to run on
1285         a target with 64-bit float hardware.
1286
1287 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1288
1289         * source.c (search_command_helper): Stop reverse search
1290         when line 1 has been searched.
1291
1292 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1293
1294         * record-full.c (record_full_base_target::close): Rewrite
1295         record_full_core_buf_list free logic.
1296
1297 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1298
1299         * break-catch-syscall.c (print_one_catch_syscall): xfree
1300         the last text.
1301
1302 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1303
1304         * top.c (print_gdb_version): Update Copyright year in version
1305         message.
1306
1307 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1308
1309         Update copyright year range in all GDB files.
1310
1311 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
1312
1313         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
1314
1315 For older changes see ChangeLog-2018.
1316 \f
1317 Local Variables:
1318 mode: change-log
1319 left-margin: 8
1320 fill-column: 74
1321 version-control: never
1322 coding: utf-8
1323 End:
1324